Discourage in comments from defining HAVE_GETCWD on MS-Windows.
[bpt/emacs.git] / src / ChangeLog
1 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2
3 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4
5 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6
7 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8
9 2012-03-27 Glenn Morris <rgm@gnu.org>
10
11 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
12 Doc fixes.
13
14 2012-03-26 Kenichi Handa <handa@m17n.org>
15
16 * dispextern.h (struct glyph): Fix previous change. Change the
17 bit length of glyphless.ch to 25 (Bug#11082).
18
19 2012-03-26 Chong Yidong <cyd@gnu.org>
20
21 * keyboard.c (Vselection_inhibit_update_commands): New variable.
22 (command_loop_1): Use it; inhibit selection update for
23 handle-select-window too (Bug#8996).
24
25 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
26
27 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
28
29 2012-03-25 Kenichi Handa <handa@m17n.org>
30
31 * dispextern.h (struct glyph): Change the bit length of
32 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
33
34 2012-03-24 Eli Zaretskii <eliz@gnu.org>
35
36 * s/ms-w32.h (tzname): Include time.h before redirecting to
37 _tzname. Fixes the MSVC build. (Bug#9960)
38
39 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
40
41 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
42 characters.
43
44 * xterm.c (XTread_socket): Only modify handling_signal if
45 !SYNC_INPUT. (Bug#11080)
46
47 2012-03-23 Eli Zaretskii <eliz@gnu.org>
48
49 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
50 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
51 when fetching a multibyte character consumes more bytes than
52 CHAR_BYTES returns, due to unification of CJK characters in
53 string_char. (Bug#11073)
54
55 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
56
57 * process.c (wait_reading_process_output): Handle pty disconnect
58 by refraining from sending oneself a SIGCHLD (bug#10933).
59
60 2012-03-22 Chong Yidong <cyd@gnu.org>
61
62 * dispextern.h (struct it): New member string_from_prefix_prop_p.
63
64 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
65 Mark string as coming from a prefix property.
66 (handle_face_prop): Use default face for prefix strings (Bug#4281).
67 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
68
69 2012-03-21 Chong Yidong <cyd@gnu.org>
70
71 * xfaces.c (Vface_remapping_alist): Doc fix.
72
73 2012-03-20 Eli Zaretskii <eliz@gnu.org>
74
75 * w32proc.c (Fw32_set_console_codepage)
76 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
77 Doc fixes.
78
79 2012-03-20 Chong Yidong <cyd@gnu.org>
80
81 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
82 to reflect default non-nil value of redisplay-dont-pause.
83
84 2012-03-19 Kenichi Handa <handa@m17n.org>
85
86 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
87 it fit in a valid range (Bug#11003).
88
89 2012-03-18 Eli Zaretskii <eliz@gnu.org>
90
91 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
92 that is not from display property, accept the row as a "cursor
93 row" if one of the string's character has a non-nil `cursor'
94 property. Fixes cursor positioning when there are newlines in
95 overlay strings, e.g. in icomplete.el. (Bug#11035)
96
97 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
98
99 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
100
101 2012-03-12 Chong Yidong <cyd@gnu.org>
102
103 * eval.c (inhibit_lisp_code): Rename from
104 inhibit_window_configuration_change_hook; move from window.c.
105
106 * xfns.c (unwind_create_frame_1, Fx_create_frame):
107 * window.c (run_window_configuration_change_hook)
108 (syms_of_window): Callers changed.
109
110 2012-03-11 Chong Yidong <cyd@gnu.org>
111
112 * keymap.c (Fkey_description): Doc fix (Bug#9700).
113
114 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
115
116 2012-03-10 Chong Yidong <cyd@gnu.org>
117
118 * frame.c (other_visible_frames): Don't assume the selected frame
119 is visible (Bug#10955).
120
121 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
122
123 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
124
125 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
126
127 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
128 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
129 zero (Bug#10954).
130
131 2012-03-03 Glenn Morris <rgm@gnu.org>
132
133 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
134
135 2012-03-02 Eli Zaretskii <eliz@gnu.org>
136
137 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
138 position past the first glyph_row that ends at ZV. (Bug#10902)
139 (redisplay_window, next_element_from_string): Fix typos in
140 comments.
141 (redisplay_window): Pass to move_it_vertically the margin in
142 pixels, not in screen lines.
143
144 2012-03-02 Glenn Morris <rgm@gnu.org>
145
146 * buffer.c (buffer-list-update-hook): Doc fix.
147
148 2012-02-29 Eli Zaretskii <eliz@gnu.org>
149
150 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
151 push_it before setting up the iterator for the first overlay
152 string, even if we have an empty string loaded.
153 (next_overlay_string): If there's an empty string on the iterator
154 stack, pop the stack. (Bug#10903)
155
156 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
157
158 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
159 Suggested by Stefan Monnier in
160 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
161 * alloc.c (widen_to_Lisp_Object): New static function.
162 (mark_memory): Also mark Lisp_Objects by fetching pointer words
163 and widening them to Lisp_Objects. This would work even if
164 USE_LSB_TAG is defined and wide integers are used, which might
165 happen in a future version of Emacs.
166
167 2012-02-25 Chong Yidong <cyd@gnu.org>
168
169 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
170 Doc fix.
171
172 * xselect.c (Fx_selection_exists_p): Doc fix.
173 (x_clipboard_manager_save_all): Print an informative message
174 before saving to clipboard manager.
175
176 2012-02-24 Chong Yidong <cyd@gnu.org>
177
178 * keyboard.c (process_special_events): Handle all X selection
179 requests in kbd_buffer, not just the next one (Bug#8869).
180
181 2012-02-23 Chong Yidong <cyd@gnu.org>
182
183 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
184 call when setting menu-bar-lines and tool-bar-lines parameters.
185 (unwind_create_frame_1): New helper function.
186
187 * window.c (inhibit_window_configuration_change_hook): New var.
188 (run_window_configuration_change_hook): Obey it.
189 (syms_of_window): Initialize it.
190
191 2012-02-22 Chong Yidong <cyd@gnu.org>
192
193 * xterm.c (x_draw_image_relief): Add missing type check for
194 Vtool_bar_button_margin (Bug#10743).
195
196 2012-02-21 Chong Yidong <cyd@gnu.org>
197
198 * fileio.c (Vfile_name_handler_alist): Doc fix.
199
200 * buffer.c (Fget_file_buffer): Protect against invalid file
201 handler return value.
202
203 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
204
205 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
206 when computing $valmask.
207
208 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
209 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
210 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
211 It's useless in that case, and it can cause problems on hosts
212 that allocate halves of EMACS_INT values separately.
213 Reported by Dan Horák. Diagnosed by Andreas Schwab in
214 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
215 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
216 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
217 it avoids undefined behavior on hosts where shifting right by more
218 than the word width has undefined behavior.
219
220 2012-02-19 Chong Yidong <cyd@gnu.org>
221
222 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
223 (Funhandled_file_name_directory, Ffile_name_as_directory)
224 (Fdirectory_file_name, Fexpand_file_name)
225 (Fsubstitute_in_file_name): Protect against invalid file handler
226 return values (Bug#10845).
227
228 2012-02-18 Eli Zaretskii <eliz@gnu.org>
229
230 * .gdbinit (pitx): Fix incorrect references to fields of the
231 iterator stack.
232
233 2012-02-17 Chong Yidong <cyd@gnu.org>
234
235 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
236
237 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
238
239 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
240 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
241
242 2012-02-15 Chong Yidong <cyd@gnu.org>
243
244 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
245 marked as special. Also, starting docstrings with * is obsolete.
246
247 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
248
249 * gnutls.c (emacs_gnutls_write): Fix last change.
250
251 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
252
253 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
254 send_process.
255
256 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * keymap.c (Fsingle_key_description): Handle char ranges.
259
260 2012-02-12 Chong Yidong <cyd@gnu.org>
261
262 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
263 as that creates a dangerous corner case.
264
265 * window.c (Fdelete_window_internal): Invalidate the mouse
266 highlight (Bug#9904).
267
268 2012-02-12 Glenn Morris <rgm@gnu.org>
269
270 * xselect.c (Fx_own_selection_internal)
271 (Fx_get_selection_internal, Fx_disown_selection_internal)
272 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
273 * nsselect.m (Fx_own_selection_internal)
274 (Fx_disown_selection_internal, Fx_selection_exists_p)
275 (Fx_selection_owner_p, Fx_get_selection_internal):
276 Sync docs and argument specs with the xselect.c versions.
277
278 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
279
280 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
281
282 2012-02-11 Eli Zaretskii <eliz@gnu.org>
283
284 * w32select.c (Fx_selection_exists_p): Sync doc string and
285 argument list with xselect.c. (Bug#10783)
286
287 * w16select.c (Fx_selection_exists_p): Sync doc string and
288 argument list with xselect.c. (Bug#10783)
289
290 2012-02-10 Glenn Morris <rgm@gnu.org>
291
292 * fns.c (Fsecure_hash): Doc fix.
293
294 2012-02-09 Kenichi Handa <handa@m17n.org>
295
296 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
297
298 2012-02-07 Chong Yidong <cyd@gnu.org>
299
300 * buffer.c (Fbuffer_local_variables)
301 (buffer_lisp_local_variables): Handle unbound vars correctly;
302 don't let Qunbound leak into Lisp.
303
304 2012-02-07 Glenn Morris <rgm@gnu.org>
305
306 * image.c (Fimagemagick_types): Doc fix.
307
308 * image.c (imagemagick-render-type): Change it from a lisp object
309 to an integer. Move the doc here from the lisp manual.
310 Treat all values not equal to 0 the same.
311
312 2012-02-06 Chong Yidong <cyd@gnu.org>
313
314 * doc.c (store_function_docstring): Avoid applying docstring of
315 alias to base function (Bug#2603).
316
317 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
318
319 * .gdbinit (pp1, pv1): Remove redundant defines.
320 (pr): Use pp.
321
322 2012-02-04 Chong Yidong <cyd@gnu.org>
323
324 * nsterm.m: Declare a global (Bug#10694).
325
326 2012-02-04 Eli Zaretskii <eliz@gnu.org>
327
328 * w32.c (get_emacs_configuration_options):
329 Include --enable-checking, if specified, in the return value.
330
331 2012-02-04 Martin Rudalics <rudalics@gmx.at>
332
333 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
334 after rounding frame sizes. (Bug#9723)
335
336 2012-02-04 Eli Zaretskii <eliz@gnu.org>
337
338 * keyboard.c (adjust_point_for_property): Don't position point
339 before BEGV. (Bug#10696)
340
341 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
342
343 Handle overflow when computing char display width (Bug#9496).
344 * character.c (char_width): Return EMACS_INT, not int.
345 (char_width, c_string_width): Check for overflow when
346 computing the width; this is possible now that individual
347 characters can have unbounded width. Problem introduced
348 by merge from Emacs 23 on 2012-01-19.
349
350 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
351
352 * dbusbind.c (Fdbus_register_method): Mention the return value
353 :ignore in the docstring.
354
355 2012-02-02 Glenn Morris <rgm@gnu.org>
356
357 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
358
359 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
360 Unconditionally set to t. (Bug#10673)
361 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
362 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
363 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
364
365 2012-02-02 Kenichi Handa <handa@m17n.org>
366
367 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
368 0, do not call append_composite_glyph.
369
370 2012-02-02 Kenichi Handa <handa@m17n.org>
371
372 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
373 NULL (Bug#6988).
374 (x_produce_glyphs): If the component of a composition is a null
375 string, set it->pixel_width to 1 to avoid zero-width glyph.
376
377 2012-02-01 Eli Zaretskii <eliz@gnu.org>
378
379 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
380 first 2 arguments are identical. This makes inserting large
381 output from a subprocess an order of magnitude faster on
382 MS-Windows, where all sbrk'ed memory is always contiguous.
383
384 2012-01-31 Glenn Morris <rgm@gnu.org>
385
386 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
387 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
388 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
389
390 2012-01-29 Glenn Morris <rgm@gnu.org>
391
392 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
393
394 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
395
396 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
397
398 2012-01-28 Chong Yidong <cyd@gnu.org>
399
400 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
401
402 2012-01-26 Chong Yidong <cyd@gnu.org>
403
404 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
405
406 * search.c (Fsearch_forward, Fsearch_backward): Document negative
407 repeat counts (Bug#10507).
408
409 2012-01-26 Glenn Morris <rgm@gnu.org>
410
411 * lread.c (syms_of_lread): Doc fix.
412
413 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
414
415 * coding.c (encode_designation_at_bol): Change return value to
416 EMACS_INT.
417
418 2012-01-25 Chong Yidong <cyd@gnu.org>
419
420 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
421
422 2012-01-21 Chong Yidong <cyd@gnu.org>
423
424 * floatfns.c (Fcopysign): Make the second argument non-optional,
425 since nil is not allowed anyway.
426
427 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
428
429 * process.c (read_process_output): Use p instead of XPROCESS (proc).
430 (send_process): Likewise.
431
432 2012-01-19 Martin Rudalics <rudalics@gmx.at>
433
434 * window.c (save_window_save, Fcurrent_window_configuration)
435 (Vwindow_persistent_parameters): Do not use Qstate.
436 Rewrite doc-strings.
437
438 2012-01-19 Kenichi Handa <handa@m17n.org>
439
440 * character.c (char_width): New function.
441 (Fchar_width, c_string_width, lisp_string_width):
442 Use char_width (Bug#9496).
443
444 2012-01-16 Martin Rudalics <rudalics@gmx.at>
445
446 * window.c (Vwindow_persistent_parameters): New variable.
447 (Fset_window_configuration, save_window_save): Handle persistent
448 window parameters.
449
450 2012-01-14 Eli Zaretskii <eliz@gnu.org>
451
452 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
453 thrashing the stack of the thread. (Bug#9087)
454
455 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
456
457 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
458
459 2012-01-11 Eli Zaretskii <eliz@gnu.org>
460
461 * xdisp.c (rows_from_pos_range): Handle the case where the
462 highlight ends on a newline. (Bug#10464)
463 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
464 he end column for display of highlight that ends on a newline
465 before a R2L line.
466
467 2012-01-11 Glenn Morris <rgm@gnu.org>
468
469 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
470 from load-path also when installation-directory is nil. (Bug#10208)
471
472 2012-01-10 Glenn Morris <rgm@gnu.org>
473
474 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
475
476 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
477 Update template values to be closer to their typical values these days.
478
479 2012-01-09 Eli Zaretskii <eliz@gnu.org>
480
481 * xdisp.c (rows_from_pos_range): Accept additional argument
482 DISP_STRING, and accept any glyph in a row whose object is that
483 string as eligible for mouse highlight. Fixes mouse highlight of
484 display strings from overlays. (Bug#10464)
485
486 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
487
488 emacs: fix an auto-save permissions race condition (Bug#10400)
489 * fileio.c (auto_saving_dir_umask): New static var.
490 (Fmake_directory_internal): Use it.
491 (do_auto_save_make_dir): Set it, instead of invoking chmod after
492 creating the directory. The old code temporarily assigns
493 too-generous permissions to the directory.
494 (do_auto_save_eh): Clear it.
495 (Fdo_auto_save): Catch all errors, not just file errors, so
496 that the var is always cleared.
497
498 2012-01-07 Eli Zaretskii <eliz@gnu.org>
499
500 * search.c (scan_buffer): Pass character positions to
501 know_region_cache, not byte positions. (Bug#6540)
502
503 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
504
505 * w32.c (sys_rename): Report EXDEV when rename of a directory
506 fails because the target is on another logical disk. (Bug#10284)
507
508 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
509
510 * xterm.c (x_embed_request_focus): New function.
511
512 * xterm.h: Add prototype.
513
514 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
515
516 2012-01-05 Glenn Morris <rgm@gnu.org>
517
518 * emacs.c (emacs_copyright): Update short copyright year to 2012.
519
520 2012-01-01 Eli Zaretskii <eliz@gnu.org>
521
522 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
523 Load gnutls_transport_set_lowat only if GnuTLS version is below
524 2.11.1.
525 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
526 GnuTLS versions below 2.11.1.
527
528 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
529
530 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
531 to the doc string advising against its use for altering the way
532 windows are scrolled.
533
534 2011-12-28 Kenichi Handa <handa@m17n.org>
535
536 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
537 coding-system ASCII compatible only when it does not produce BOM
538 on encoding (Bug#10383).
539
540 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
541
542 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
543 can scroll.
544 (create_and_show_popup_menu): Always use menu_position_func for
545 Gtk3 (Bug#10361).
546
547 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
548
549 * callint.c (Fcall_interactively): Don't truncate prompt string.
550
551 2011-12-23 Eli Zaretskii <eliz@gnu.org>
552
553 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
554 property that ends at ZV, so that the bidi iteration could be
555 resumed from there (after widening). (Bug#10360)
556
557 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
558
559 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
560
561 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
562
563 * nsterm.m (x_free_frame_resources):
564 Release f->output_data.ns->miniimage.
565 (ns_index_color): Fix indentation. Do not retain
566 color_table->colors[i].
567
568 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
569 before returning.
570
571 * nsfns.m (x_set_background_color): Assign return value from
572 ns_index_color to face-background instead of NSColor*.
573 (ns_implicitly_set_icon_type): Fix indentation.
574 Change assignment in for loop to comparison.
575
576 * emacs.c (ns_pool): New variable.
577 (main): Assign ns_pool.
578 (Fkill_emacs): Call ns_release_autorelease_pool.
579
580 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
581 autorelease fdesc, release fdAttrs and tdict.
582 (ns_get_covering_families): Release charset.
583 (ns_findfonts): Release NSFontDescriptor created with new.
584 (ns_uni_to_glyphs): Fix indentation.
585 (setString): Release attrStr before assigning new value.
586
587 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
588
589 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
590 and NS_IMPL_COCOA.
591 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
592 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
593
594 2011-12-18 David Reitter <reitter@cmu.edu>
595
596 * nsterm.m (ns_term_init): Subscribe for notifications
597 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
598 to method trackingNotification in EmacsMenu.
599
600 * nsmenu.m (trackingMenu): New variable.
601 (trackingNotification): New method (from Aquamacs).
602 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
603 from Aquamacs (Bug#7030).
604
605 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
606
607 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
608 (symbol_to_nsstring): Fix indentation.
609 (ns_symbol_to_pb): New function.
610 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
611 (Fns_rotate_cut_buffers_internal): Remove.
612 (Fns_store_selection_internal): Rename from
613 Fns_store_cut_buffer_internal.
614 (ns_get_foreign_selection, Fx_own_selection_internal)
615 (Fx_disown_selection_internal, Fx_selection_exists_p)
616 (Fns_get_selection_internal, Fns_store_selection_internal):
617 Use ns_symbol_to_pb and check if return value is nil.
618 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
619 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
620 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
621 renamed to Sns_store_selection_internal.
622 (ns_handle_selection_request): Move code to Fx_own_selection_internal
623 and remove this function.
624 (ns_handle_selection_clear): Remove, never used.
625 (Fx_own_selection_internal): Move code from ns_handle_selection_request
626 here.
627
628 2011-12-17 Ken Brown <kbrown@cornell.edu>
629
630 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
631 GID is unknown (Bug#10257).
632
633 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
634
635 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
636 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
637 which caused a build failure on GNU/Linux IA-64. This problem was
638 introduced by my 2011-10-07 patch.
639
640 2011-12-15 Juri Linkov <juri@jurta.org>
641
642 * image.c (imagemagick_error): New function. (Bug#10112)
643 (imagemagick_load_image): Comment out `MagickSetResolution' call.
644 Use `imagemagick_error' where ImageMagick functions return
645 `MagickFalse'.
646 (Fimagemagick_types): Add `Fnreverse' to return the list in the
647 proper order.
648
649 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
650
651 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
652 fill background (Bug#8992).
653
654 2011-12-13 Martin Rudalics <rudalics@gmx.at>
655
656 * window.c (Vwindow_combination_resize)
657 (Vwindow_combination_limit): Use t instead of non-nil in
658 doc-strings.
659 (Vrecenter_redisplay): Add first sentence of doc-string on
660 separate line.
661 (Frecenter): Fix doc-string typo.
662
663 2011-12-11 Kenichi Handa <handa@m17n.org>
664
665 * coding.c (Funencodable_char_position): Pay attention to the
666 buffer text relocation (Bug#9389).
667
668 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
669
670 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
671 gtk_init (Bug#10100).
672
673 2011-12-10 Eli Zaretskii <eliz@gnu.org>
674
675 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
676 IT->string is nil. (Bug#10263)
677
678 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
679
680 * nsterm.h (x_free_frame_resources): Declare.
681
682 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
683 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
684
685 * nsterm.h (ns_get_defaults_value): Declare.
686
687 * nsterm.m (ns_default): Call ns_get_defaults_value.
688
689 2011-12-09 Eli Zaretskii <eliz@gnu.org>
690
691 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
692 (Bug#10170)
693
694 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
695
696 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
697 that where the value of an _OBJC_* symbol points to is in the .bss
698 section (Bug#10240).
699
700 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
701
702 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
703 after the loop to call ccl_driver at least once (Bug#8619).
704
705 2011-12-08 Kenichi Handa <handa@m17n.org>
706
707 * ftfont.c (get_adstyle_property): Fix previous change
708 (Bug#10233).
709
710 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
711
712 * w32.c (init_environment): If no_site_lisp, remove site-lisp
713 dirs from the default value of EMACSLOADPATH (bug#10208).
714
715 2011-12-07 Glenn Morris <rgm@gnu.org>
716
717 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
718 installation and source directories as well. (Bug#10208)
719
720 2011-12-06 Chong Yidong <cyd@gnu.org>
721
722 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
723
724 2011-12-06 Glenn Morris <rgm@gnu.org>
725
726 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
727 as an error, not just -1. (Bug#10217)
728
729 2011-12-05 Chong Yidong <cyd@gnu.org>
730
731 * keyboard.c (process_special_events): New function.
732 (swallow_events, Finput_pending_p): Use it (Bug#10195).
733
734 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
735
736 * coding.c (encode_designation_at_bol): Don't use uninitialized
737 local variable (Bug#9318).
738
739 2011-12-05 Kenichi Handa <handa@m17n.org>
740
741 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
742 return Qnil (Bug#8046, Bug#10193).
743
744 2011-12-05 Kenichi Handa <handa@m17n.org>
745
746 * coding.c (encode_designation_at_bol): New args charbuf_end and
747 dst. Return the number of produced bytes. Callers changed.
748 (coding_set_source): Return how many bytes coding->source was
749 relocated.
750 (coding_set_destination): Return how many bytes
751 coding->destination was relocated.
752 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
753 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
754
755 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
756
757 * coding.c (CODING_CHAR_CHARSET_P): New macro.
758 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
759 macro (Bug#9318).
760
761 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
762
763 The following changes are to fix Bug#9318.
764
765 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
766 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
767 (encode_coding_iso_2022, encode_coding_sjis)
768 (encode_coding_big5, encode_coding_charset): Use the above macros.
769
770 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
771
772 * lisp.h (process_quit_flag): Fix external declaration.
773
774 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
775
776 Don't macro-inline non-performance-critical code.
777 * eval.c (process_quit_flag): New function.
778 * lisp.h (QUIT): Use it.
779
780 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
781
782 * nsfns.m (get_geometry_from_preferences): New function.
783 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
784
785 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
786
787 * emacs.c (Qkill_emacs): Define.
788 (syms_of_emacs): Initialize it.
789 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
790 Qquit_flag to `kill-emacs' instead.
791 (quit_throw_to_read_char): Add parameter `from_signal'.
792 All callers changed. Call Fkill_emacs if requested and safe.
793 * lisp.h (QUIT): Call Fkill_emacs if requested.
794
795 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
796
797 * widget.c (update_wm_hints): Return if wmshell is null.
798 (widget_update_wm_size_hints): New function.
799
800 * widget.h (widget_update_wm_size_hints): Declare.
801
802 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
803 widget_update_wm_size_hints (Bug#10104).
804
805 2011-12-03 Eli Zaretskii <eliz@gnu.org>
806
807 * xdisp.c (handle_invisible_prop): If the invisible text ends just
808 before a newline, prepare the bidi iterator for consuming the
809 newline, and keep the current paragraph direction. (Bug#10183)
810 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
811
812 2011-12-02 Juri Linkov <juri@jurta.org>
813
814 * search.c (Fword_search_regexp): New Lisp function created from
815 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
816 (Fword_search_backward, Fword_search_forward)
817 (Fword_search_backward_lax, Fword_search_forward_lax):
818 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
819 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
820
821 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
822
823 * fileio.c (Finsert_file_contents): Move after-change-function call
824 to before the "handled:" label, since all "goto handled" appear in
825 cases where the *-change-functions have already been properly called
826 (bug#10117).
827
828 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
829
830 * keyboard.c (interrupt_signal): Don't call kill-emacs when
831 waiting for input. (Bug#10169)
832
833 2011-11-30 Eli Zaretskii <eliz@gnu.org>
834
835 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
836 verifies glyph row's hash code--we have just reallocated the
837 glyphs, so their contents can be complete garbage. (Bug#10164)
838
839 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
840
841 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
842
843 2011-11-30 Eli Zaretskii <eliz@gnu.org>
844
845 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
846 attributes are tested _before_ calling verify_row_hash, to protect
847 against GCC re-ordering of the tests. (Bug#10164)
848
849 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
850
851 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
852
853 * xterm.c (handle_one_xevent): Only set async_visible and friends
854 if net_wm_state_hidden_seen is non-zero (Bug#10002)
855 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
856 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
857
858 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
859
860 Remove GCPRO-related macros that exist only to avoid shadowing locals.
861 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
862 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
863 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
864 All uses changed to use GCPRO1 etc.
865 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
866 Revert to old implementation (i.e., before 2011-03-11).
867
868 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
869
870 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
871 of scroll runs so as to avoid assigning disabled bogus rows and
872 unnecessary graphics copy operations.
873
874 2011-11-27 Eli Zaretskii <eliz@gnu.org>
875
876 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
877 (snprintf) [_MSC_VER]: Redirect to _snprintf.
878 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
879 (malloc, free, realloc, calloc): Redirect to e_* only when
880 compiling Emacs.
881
882 * lisp.h (GCTYPEBITS): Move before first use.
883 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
884 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
885 this macro definition.
886
887 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
888 _MSC_VER.
889
890 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
891
892 * gtkutil.c (xg_create_frame_widgets):
893 Call gtk_window_set_has_resize_grip (FALSE) if that function is
894 present with Gtk+ 2.0.
895
896 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
897
898 * fileio.c (Finsert_file_contents): Undo previous change; see
899 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
900
901 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
902
903 Rename locals to avoid shadowing.
904 * fileio.c (Finsert_file_contents):
905 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
906 * process.c (wait_reading_process_output):
907 Rename inner 'proc' to 'p' to avoid shadowing.
908 Indent for consistency with usual Emacs style.
909
910 2011-11-25 Eli Zaretskii <eliz@gnu.org>
911
912 * xdisp.c (redisplay_window): If cursor row is not fully visible
913 after recentering, and scroll-conservatively is set to a large
914 number, scroll window by a few more lines to make the cursor fully
915 visible and out of scroll-margin. (Bug#10105)
916 (start_display): Don't move to the next line if the display should
917 start at a newline that is part of a display vector or an overlay
918 string. (Bug#10119)
919
920 2011-11-24 Juri Linkov <juri@jurta.org>
921
922 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
923 after the `MagickPingImage' call. (Bug#10112)
924
925 2011-11-23 Chong Yidong <cyd@gnu.org>
926
927 * window.c (Fcoordinates_in_window_p): Accept only live windows.
928
929 2011-11-23 Martin Rudalics <rudalics@gmx.at>
930
931 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
932 making another buffer current. (Bug#10114)
933
934 2011-11-23 Glenn Morris <rgm@gnu.org>
935
936 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
937
938 2011-11-23 Chong Yidong <cyd@gnu.org>
939
940 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
941 using it (Bug#5984).
942
943 2011-11-22 Eli Zaretskii <eliz@gnu.org>
944
945 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
946 and header-lines, as they don't have one computed for them.
947 (Bug#10098)
948
949 * .gdbinit (prow): Make displayed values more self-explaining.
950 Add row's hash code.
951
952 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
953
954 * process.c (wait_reading_process_output): Fix asynchrounous
955 GnuTLS socket handling on some versions of the GnuTLS library.
956 (wait_reading_process_output): Add comment and URL.
957
958 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
959
960 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
961
962 2011-11-21 Chong Yidong <cyd@gnu.org>
963
964 * window.c (Fnext_window, Fprevious_window): Doc fix.
965
966 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
967
968 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
969
970 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
971
972 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
973
974 2011-11-20 Martin Rudalics <rudalics@gmx.at>
975
976 * window.c (Fset_window_combination_limit): Rename argument
977 STATUS to LIMIT.
978 (Vwindow_combination_limit): Remove "status" from doc-string.
979
980 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
981
982 * m/ibms390.h: Remove.
983 * m/ibms390x.h: Don't include "ibms390.h".
984
985 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
986
987 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
988 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
989
990 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
991
992 * casetab.c (Fset_case_table):
993 * charset.c (Fcharset_after): Fix typos.
994
995 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
996
997 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
998 Otherwise, valgrind does not work on some platforms.
999 Problem reported by Andreas Schwab in
1000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1001 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1002 is set, removing the need for VIRT_ADDRESS_VARIES.
1003 (PURE_P): Use a more-efficient implementation that needs just one
1004 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1005 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1006 to 4 (xorl, subq, cmpq, setbe).
1007 * alloc.c (pure): Always extern now, since that's the
1008 VIRT_ADDR_VARIES behavior.
1009 (PURE_POINTER_P): Use a single comparison, not two, for
1010 consistency with the new puresize.h.
1011 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1012 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1013 Remove VIRT_ADDR_VARIES no longer needed.
1014
1015 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1018 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1019 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1020 behave as if the cursor position were at the window margin.
1021
1022 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1023 and the cursor position is out of bounds, behave as if the cursor
1024 position were at the window margin. (Bug#10075)
1025
1026 2011-11-18 Chong Yidong <cyd@gnu.org>
1027
1028 * window.c (Fwindow_combination_limit): Make first argument
1029 non-optional, since it is meaningless for live windows like the
1030 selected window.
1031
1032 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1033
1034 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1035
1036 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1037
1038 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1039 (graft_intervals_into_buffer): Simplify.
1040
1041 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1042
1043 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1044 hash values of the two rows.
1045 (copy_row_except_pointers): Preserve the used[] arrays and the
1046 hash values of the two rows. (Bug#10035)
1047 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1048
1049 * xdisp.c (row_hash): New function, body extracted from
1050 compute_line_metrics.
1051 (compute_line_metrics): Call row_hash, instead of computing the
1052 hash code inline.
1053
1054 * dispnew.c (verify_row_hash): Call row_hash for computing the
1055 hash code of a row, instead of duplicating code from xdisp.c.
1056
1057 * dispextern.h (row_hash): Add prototype.
1058
1059 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1060
1061 * frame.c (delete_frame): Don't delete the terminal when the last
1062 X frame is closed if emacs is built with GTK toolkit.
1063
1064 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1065
1066 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1067
1068 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1069
1070 * window.c (Vwindow_splits): Rename to
1071 Vwindow_combination_resize. Suggested by Juri Linkov.
1072 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1073 of Vwindow_splits.
1074
1075 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1076
1077 * nsfns.m (Fns_font_name):
1078 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1079
1080 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1081
1082 * window.h (window): Rename slot "nest" to "combination_limit".
1083 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1084 (Fset_window_nest): Rename to Fset_window_combination_limit.
1085 (Vwindow_nest): Rename to Vwindow_combination_limit.
1086 (recombine_windows, make_parent_window, make_window)
1087 (Fsplit_window_internal, saved_window)
1088 (Fset_window_configuration, save_window_save): Rename all
1089 occurrences of window_nest to window_combination_limit.
1090
1091 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1092
1093 * image.c (imagemagick_load_image): Fix typo.
1094
1095 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1096
1097 * xdisp.c (display_line): Move the call to
1098 highlight_trailing_whitespace before the call to
1099 compute_line_metrics, since the latter needs to see the final
1100 faces of all the glyphs to compute ROW's hash value.
1101 Fixes assertion violations in row_equal_p. (Bug#10035)
1102
1103 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1104
1105 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1106 just return (bug#10044).
1107
1108 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1109
1110 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1111 with user-defined heap size. Bump the default size of the temacs
1112 heap to 27MB, to avoid memory warning when running temacs.
1113 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1114
1115 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1116 current_matrix and desired_matrix. (Bug#9990)
1117 (verify_row_hash) [XASSERTS]: New function.
1118 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1119 that the hash value of glyph rows is correct.
1120
1121 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1122
1123 * window.h (window): Remove splits slot.
1124 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1125 (Fdelete_other_windows_internal, make_parent_window)
1126 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1127 (Fset_window_configuration, save_window_save): Don't deal with
1128 split status of windows.
1129 (saved_window): Remove splits slot.
1130 (Vwindow_splits): Rewrite doc-string.
1131
1132 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * xfns.c (unwind_create_frame):
1135 * nsfns.m (unwind_create_frame):
1136 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1137 Vframe_list (Bug#9999).
1138
1139 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1142
1143 2011-11-11 Kenichi Handa <handa@m17n.org>
1144
1145 * callproc.c (Fcall_process): Set the member dst_multibyte of
1146 process_coding.
1147
1148 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1149
1150 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1151 avoid a crash (bug#9496).
1152
1153 2011-11-09 Chong Yidong <cyd@gnu.org>
1154
1155 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1156 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1157
1158 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1161
1162 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 Avoid some portability problems by eschewing 'extern inline' functions.
1165 The trivial performance wins aren't worth the portability hassles; see
1166 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1167 et seq.
1168 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1169 (window_box_width, window_box_left, window_box_left_offset)
1170 (window_box_right, window_box_right_offset): Undo previous change,
1171 by removing the "extern"s.
1172 * intervals.c (adjust_intervals_for_insertion)
1173 (adjust_intervals_for_deletion): Undo previous change,
1174 making these static again.
1175 (offset_intervals, temp_set_point_both, temp_set_point)
1176 (copy_intervals_to_string): No longer inline.
1177 * xdisp.c (window_text_bottom_y, window_box_width)
1178 (window_box_height, window_box_left_offset)
1179 (window_box_right_offset, window_box_left, window_box_right)
1180 (window_box): No longer inline.
1181
1182 2011-11-08 Chong Yidong <cyd@gnu.org>
1183
1184 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1185 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1186 Signal an error if not a live window.
1187 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1188 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1189
1190 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1191
1192 * lisp.h (syms_of_abbrev): Remove declaration.
1193 Reported by CHENG Gao <chenggao@royau.me>.
1194
1195 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1196
1197 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1198 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1199 of temacs in GUI mode.
1200
1201 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1202
1203 * window.h: Declare delete_all_child_windows instead of
1204 delete_all_subwindows.
1205 * window.c (Fwindow_nest, Fset_window_nest)
1206 (Fset_window_new_total, Fset_window_new_normal)
1207 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1208 (delete_all_subwindows): Rename to delete_all_child_windows.
1209 (Fdelete_other_windows_internal, Fset_window_configuration):
1210 Call delete_all_child_windows instead of delete_all_subwindows.
1211 * frame.c (delete_frame): Call delete_all_child_windows instead
1212 of delete_all_subwindows.
1213
1214 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1217 This is also needed for porting to any host where GC_MARK_STACK is
1218 not GC_MAKE_GCPROS_NOOPS.
1219 (which_symbols): Use it.
1220
1221 2011-11-07 Kenichi Handa <handa@m17n.org>
1222
1223 * coding.c (coding_set_destination): Check coding->src_pos only
1224 when coding->src_object is a buffer (bug#9910).
1225
1226 * process.c (send_process): Set the member src_multibyte of coding
1227 to 0 (bug#9911) when sending a unibyte text.
1228
1229 * callproc.c (Fcall_process): Set the member src_multibyte of
1230 process_coding to 0 (bug#9912).
1231
1232 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1233
1234 * xmenu.c (cleanup_widget_value_tree): New function.
1235 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1236 calling free_menubar_widget_value_tree directly (Bug#9830).
1237
1238 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 Fix some portability problems with 'inline'.
1241 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1242 (window_box_width, window_box_left, window_box_left_offset)
1243 (window_box_right, window_box_right_offset): Declare extern.
1244 Otherwise, these inline functions do not conform to C99 and
1245 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1246 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1247 * intervals.c (adjust_intervals_for_insertion)
1248 (adjust_intervals_for_deletion): Now extern, because otherwise the
1249 extern inline functions 'offset_intervals' couldn't refer to it.
1250 (static_offset_intervals): Remove.
1251 (offset_intervals): Rewrite using the old contents of
1252 static_offset_intervals. The old version didn't conform to C99
1253 because an extern inline function contained a reference to an
1254 identifier with static linkage.
1255
1256 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1257
1258 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1259 GC.
1260
1261 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1262
1263 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1264 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1265 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1266 return Qleft_to_right.
1267
1268 2011-11-06 Chong Yidong <cyd@gnu.org>
1269
1270 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1271 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1272 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1273 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1274 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1275 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1276 (Fwindow_vscroll): Doc fix.
1277 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1278 argument, since it makes no sense to pass a live window and for
1279 consistency with window-child.
1280
1281 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1282
1283 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1284 support MSVC.
1285
1286 2011-11-05 Jason Rumney <jasonr@gnu.org>
1287
1288 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1289 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1290 fonts (Bug#6029).
1291 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1292 bitwise arithmetic preventing use of unicode-sip and non-truetype
1293 opentype fonts.
1294
1295 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1296
1297 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1298 "emacs"-only part.
1299
1300 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1301 initialization code to keep similarity to xfns.c after changes
1302 from 2011-11-05.
1303
1304 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1305
1306 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1307 (unwind_create_frame): New function (Bug#9943).
1308 (Fx_create_frame): Restructure code to be more similar to the one in
1309 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1310 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1311 Move terminal->reference_count++ just before making the frame official
1312 (Bug#9943).
1313
1314 * nsterm.m (x_free_frame_resources): New function.
1315 (x_destroy_window): Move code to x_free_frame_resources.
1316
1317 * xfns.c (unwind_create_frame): Fix comment.
1318 (Fx_create_frame, x_create_tip_frame):
1319 Move terminal->reference_count++ just before making the frame
1320 official. Move initialization of image_cache_refcount and
1321 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1322
1323 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1324
1325 Support MSVC build with newer versions of Visual Studio.
1326 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1327 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1328 nt/gmake.defs.
1329
1330 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1331 which are not supported by MSVC.
1332 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1333 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1334 bitfields.
1335 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1336 types in bitfields.
1337 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1338
1339 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1340
1341 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1342
1343 Support MSVC build with newer versions of Visual Studio.
1344 * w32.c: Don't include w32api.h for MSVC.
1345 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1346
1347 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1348 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1349 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1350 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1351 e_* cousins.
1352 (alloca) [_MSC_VER]: Define to _alloca.
1353
1354 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1355
1356 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1357
1358 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1359
1360 * xdisp.c (note_mouse_highlight): If either of
1361 previous/next-single-property-change returns nil, treat that as
1362 the beginning or the end of the buffer. (Bug#9955)
1363
1364 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1365
1366 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1367 label is not null (Bug#9951).
1368 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1369 may be NULL.
1370
1371 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1372
1373 * window.c (Fwindow_body_size): Mention in the doc string that the
1374 return value is in frame's canonical units. (Bug#9949)
1375
1376 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1377
1378 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1379
1380 * w32fns.c (unwind_create_frame): If needed, free the glyph
1381 matrices of the partially constructed frame. (Bug#9943)
1382 * xfns.c (unwind_create_frame): Likewise.
1383
1384 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1385
1386 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1387 Don't stop backward scan on the continuation glyph, even though
1388 its CHARPOS is positive.
1389 (mouse_face_from_buffer_pos, note_mouse_highlight):
1390 Rename cover_string to disp_string.
1391
1392 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1393
1394 * window.c (temp_output_buffer_show): Don't use
1395 Vtemp_buffer_show_specifiers.
1396 (Vtemp_buffer_show_specifiers): Remove unused variable.
1397
1398 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1399
1400 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1401 past the beginning of the current glyph matrix.
1402
1403 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1404
1405 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1406 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1407 HAVE_GTK3 (Bug#9869).
1408
1409 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1410 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1411
1412 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1413
1414 * xterm.c: Declare x_handle_net_wm_state to return int.
1415 (handle_one_xevent): Check if we are iconified but don't have
1416 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1417 (get_current_wm_state): Return non-zero if not hidden,
1418 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1419 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1420 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1421 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1422
1423 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1424
1425 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1426 so that this new function doesn't get optimized away by a
1427 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1428
1429 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1430
1431 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1432
1433 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1434
1435 Fix the `xbytecode' command.
1436 * .gdbinit (xprintbytestr): New command.
1437 (xwhichsymbols): Rename from `which'; all callers changed.
1438 (xbytecode): Print the byte-code string as well.
1439
1440 2011-10-29 Kim Storm <storm@cua.dk>
1441
1442 * alloc.c (which_symbols): New function.
1443
1444 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1445
1446 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1447 line. (Bug#9903)
1448
1449 2011-10-29 Glenn Morris <rgm@gnu.org>
1450
1451 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1452 Not clear what it was for, and it causes various bugs. (Bug#9839)
1453
1454 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1455
1456 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1457 possible random value that matches one of those tested as
1458 condition to clear the mouse face.
1459
1460 2011-10-28 Chong Yidong <cyd@gnu.org>
1461
1462 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1463
1464 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1465
1466 * window.c (make_window): Initialize phys_cursor_on_p.
1467
1468 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1469
1470 * lisp.h (struct Lisp_Symbol): Update comments.
1471
1472 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1473
1474 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1475
1476 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1477
1478 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1479 <oslsachem@gmail.com> for helping to debug this.
1480
1481 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1482 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1483 (g_b_init_get_glyph_outline_w): New static variables.
1484 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1485 (GetGlyphOutlineW_Proc): New typedefs.
1486 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1487 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1488 New functions.
1489 (w32font_open_internal, compute_metrics):
1490 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1491 instead of calling the "wide" APIs directly.
1492
1493 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1494
1495 * w32.h (syms_of_w32font): Add prototype.
1496
1497 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1500 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1501 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1502 (Fmove_to_window_line): Doc fix.
1503
1504 2011-10-27 Chong Yidong <cyd@gnu.org>
1505
1506 * process.c (make_process): Set gnutls_state to NULL.
1507
1508 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1509 non-NULL, regardless of GNUTLS_INITSTAGE.
1510 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1511 an error. Set process slots as soon as we allocate them.
1512
1513 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1514
1515 2011-10-27 Chong Yidong <cyd@gnu.org>
1516
1517 * gnutls.c (emacs_gnutls_deinit): New function.
1518 Deallocate credentials structures as well as calling gnutls_deinit.
1519 (Fgnutls_deinit, Fgnutls_boot): Use it.
1520
1521 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1522 (deactivate_process): Call emacs_gnutls_deinit.
1523
1524 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * image.c (x_create_x_image_and_pixmap):
1527 * w32.c (sys_rename, w32_delayed_load):
1528 * w32font.c (fill_in_logfont):
1529 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1530
1531 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * w32fns.c (w32_default_color_map): New function,
1534 extracted from Fw32_default_color_map.
1535 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1536
1537 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1538
1539 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1540
1541 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1542
1543 * keyboard.c (test_undefined): New function (bug#9751).
1544 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1545
1546 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1547
1548 * sysdep.c (init_sys_modes): Fix the check for the controlling
1549 terminal (Bug#6649).
1550
1551 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1552
1553 * dispextern.h (struct bidi_it): New member next_en_type.
1554
1555 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1556 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1557 current character, check also for next_en_type being WEAK_EN.
1558 (bidi_resolve_weak): Don't enter the expensive loop if the current
1559 position is before next_en_pos. Record the bidi type of the first
1560 non-ET, non-BN character we find, in addition to its position.
1561 (bidi_level_of_next_char): Invalidate next_en_type when
1562 next_en_pos is over-stepped.
1563
1564 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1567 * editfns.c: Rewrite current-time-zone so that it invokes
1568 the equivalent of (format-time-string "%Z") to get the time zone name.
1569 This fixes a bug when the time zone name contains characters that
1570 need converting from the system time locale to Emacs internal format.
1571 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1572 that patch fixed format-time-string to do the conversion, but
1573 I forgot to fix current-time-zone.
1574 (format_time_string): New function, containing most of
1575 what Fformat_time_string used to contain.
1576 (Fformat_time_string): Rewrite in terms of format_time_string.
1577 This doesn't change this function's behavior.
1578 (current-time-zone): Rewrite to use format_time_string.
1579 This fixes the bug reported by Michael Schierl in
1580 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1581 Jason Rumney's 2007-06-07 change worked around this bug, but
1582 didn't fix it.
1583 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1584
1585 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (start_display): If the character at POS is displayed
1588 via a display vector, reset IT->current.dpvec_index to zero.
1589 (try_window_reusing_current_matrix): If a line ends in a display
1590 vector or the next line starts in a display vector, continue
1591 redrawing the window even though the character position of
1592 start_row was reached.
1593 (Bug#9771, part 2)
1594
1595 2011-10-18 Chong Yidong <cyd@gnu.org>
1596
1597 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1598 with nobreak-char-display too.
1599
1600 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1601
1602 Fix part 3 of bug#9771.
1603 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1604 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1605 non-neutral characters if the current character is a paragraph
1606 separator (a.k.a. Newline). This avoids running the same
1607 expensive loop twice, once when we consume the preceding newline
1608 and the other time when the line actually needs to be displayed.
1609 Avoid the loop when we see neutrals on the base embedding level
1610 following a character whose directionality is the same as the
1611 paragraph's. This avoids running the expensive loop when a line
1612 ends in a long sequence of neutrals, like control characters.
1613 Add assertion against STRONG_AL type. Slightly rearrange code
1614 that determines the type of a neutral given the first non-neutral
1615 that follows it.
1616 (bidi_level_of_next_char): Set next_en_pos to zero when
1617 invalidating its info.
1618
1619 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1620
1621 * xdisp.c (push_display_prop): Determine whether to record string
1622 or buffer position by IT->string, not by IT->method. Allow
1623 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1624 (move_it_vertically_backward): Don't look for character position
1625 immediately after the newline when in a continuation line.
1626 (Bug#9771, part 1)
1627
1628 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1629
1630 * window.c (coordinates_in_window): Rewrite and delabelize
1631 vertical border check. (Bug#5357) (Bug#9618)
1632
1633 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1634
1635 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1636 errors in XSetWindowBorder (bug#9310).
1637
1638 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1639
1640 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1641 avoid crash when xmalloc overrun checking is enabled.
1642
1643 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1644
1645 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1646 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1647 cursor motion with <left> and <right> arrow keys.
1648
1649 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1650 some callers set that themselves.
1651
1652 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1653
1654 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1655 display string and the previous row comes from the same string and
1656 is empty. (Bug#9739) (Bug#9738)
1657
1658 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1659
1660 * doc.c (get_doc_string): Encode file name (bug#9735).
1661
1662 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1663
1664 * bidi.c (bidi_level_of_next_char):
1665 * xdisp.c (get_visually_first_element): Remove old incorrect
1666 comments regarding the Unicode Line Separator character.
1667
1668 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1669
1670 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1671
1672 * alloc.c (Fgc_status): Do not access beyond zombies array
1673 boundary if nzombies > MAX_ZOMBIES.
1674 * alloc.c (dump_zombies): Add missing format specifier.
1675
1676 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1679 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1680
1681 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1682 Some packages use them to denote characters with modifiers.
1683
1684 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1685
1686 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1687 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1688 matching a pp-number. Rename parameter var to var1.
1689
1690 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1693
1694 2011-10-08 Glenn Morris <rgm@gnu.org>
1695
1696 * callint.c (Fcall_interactively): Give a more explicit error for the
1697 'c' case with a non-character input. (Bug#8479)
1698
1699 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1700
1701 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1702 lines.
1703 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1704 lines that are hscrolled on the left.
1705
1706 * dispnew.c (buffer_posn_from_coords): Account for a possible
1707 presence of header-line. (Bug#4426)
1708
1709 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1710
1711 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1712 Don't advertise functionality which we discourage or doesn't work.
1713
1714 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1717 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1718 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1719 this makes Emacs dump core during garbage collection on rare
1720 occasions. sizeof is obviously inferior to offsetof here, so
1721 stick with offsetof.
1722 (GC_POINTER_ALIGNMENT): New macro.
1723 (mark_memory): Omit 3rd (offset) arg; caller changed.
1724 Don't assume EMACS_INT alignment is the same as pointer alignment.
1725
1726 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1727
1728 * keyboard.c (read_key_sequence_remapped): New var.
1729 (read_key_sequence): Compute remapping in the right buffer.
1730 (command_loop_1): Use read_key_sequence's remapping directly.
1731
1732 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1733
1734 * dired.c (file_name_completion): Don't expand file name.
1735 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1736 before checking file name handler.
1737
1738 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1739 they've been requested explicitly (bug#9591).
1740
1741 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1742
1743 * keymap.c (Fsingle_key_description): Use make_specified_string
1744 instead of build_string to build string from push_key_description.
1745 (Bug#5193)
1746
1747 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1750 This fixes a Y2038 bug on 64-bit hosts.
1751 * buffer.c (reset_buffer):
1752 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1753 (Fclear_buffer_auto_save_failure):
1754 Use 0, not -1, to represent an unset failure time, since time_t
1755 might not be signed.
1756
1757 Remove dependency on glibc malloc internals.
1758 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1759 Move back here from lisp.h, but with their new implementations.
1760 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1761 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1762 * charset.c (charset_table_init): New static var.
1763 (syms_of_charset): Use it instead of xmalloc. This removes a
1764 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1765 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1766 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1767 Move back to alloc.c.
1768 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1769 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1770
1771 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1772
1773 * nsterm.m (windowDidResize): Call x_set_window_size only when
1774 ns_in_resize is true. Otherwise set pixelwidth/height and
1775 call change_frame_size (Bug#9628).
1776
1777 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 Port --enable-checking=all to Fedora 14 x86-64.
1780 * charset.c (syms_of_charset): Also account for glibc malloc's
1781 internal overhead when calculating the initial malloc maximum.
1782
1783 Port --enable-checking=all to Fedora 14 x86.
1784 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1785 Move to lisp.h.
1786 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1787 (overrun_check_realloc, overrun_check_free):
1788 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1789 That way, xmalloc returns a properly-aligned pointer even if
1790 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1791 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1792 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1793 into account when calculating the initial malloc maximum.
1794 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1795 Move here from alloc.c, so that charset.c can use it too.
1796 Properly align; the old code wasn't right for common 32-bit hosts
1797 when configured with --enable-checking=all.
1798 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1799 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1800
1801 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1802
1803 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1804 use EDOM.
1805
1806 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xdisp.c (compute_display_string_end): If there's no display
1809 string at CHARPOS, return -1.
1810
1811 * bidi.c (bidi_fetch_char): When compute_display_string_end
1812 returns a negative value, treat the character as a normal
1813 character not covered by a display string. (Bug#9624)
1814
1815 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1816
1817 * lread.c (Fread_from_string): Fix typo in docstring.
1818
1819 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1820
1821 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1822 newline, reseat the iterator instead of bidi-iterating there one
1823 character at a time. (Bug#9610)
1824 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1825 TO_CHARPOS if the bidi iterator is at base embedding level.
1826
1827 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1828
1829 * lread.c (readevalloop): Use correct code for NBSP.
1830 (read1): Likewise. (Bug#9608)
1831
1832 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1833
1834 * dbusbind.c (Fdbus_register_signal): When service is not
1835 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1836
1837 2011-09-25 Glenn Morris <rgm@gnu.org>
1838
1839 * buffer.c (truncate-lines): Doc fix.
1840
1841 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1842
1843 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1844 (Fset_window_next_buffers): Doc fix.
1845
1846 2011-09-24 Glenn Morris <rgm@gnu.org>
1847
1848 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1849
1850 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 Fix minor problems found by static checking.
1853 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1854 * indent.c (Fvertical_motion): Fix == vs = typo.
1855
1856 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1857
1858 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1859 Default value is now t. Doc fix.
1860
1861 * indent.c (Fvertical_motion): Compute and apply the overshoot
1862 logic when moving up, not only when moving down. Fix the
1863 confusing name and values of the it_overshoot_expected variable;
1864 logic changes accordingly. (Bug#9254) (Bug#9549)
1865
1866 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1867 CHARPOS is covered by a display string which includes newlines.
1868 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1869 is covered by a display string with embedded newlines.
1870
1871 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1872
1873 * dbusbind.c (Fdbus_register_signal): Add match rule to
1874 Vdbus_registered_objects_table. (Bug#9581)
1875 (Fdbus_register_method, Vdbus_registered_objects_table):
1876 Fix docstring.
1877
1878 2011-09-24 Jim Meyering <meyering@redhat.com>
1879
1880 do not ignore write error for any output size
1881 The previous change was incomplete.
1882 While it makes emacs --batch detect the vast majority of stdout
1883 write failures, errors were still ignored whenever the output size is
1884 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1885 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1886 && echo FAIL: ignored write error
1887 FAIL: ignored write error
1888 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1889 && echo FAIL: ignored write error
1890 FAIL: ignored write error
1891 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1892
1893 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1894
1895 * emacs.c (Fkill_emacs): In noninteractive mode exit
1896 non-successfully if a write error occurred on stdout. (Bug#9574)
1897
1898 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1899
1900 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1901 the xassert test.
1902
1903 * dispextern.h (struct it): Update the comment documenting what
1904 can it->OBJECT be.
1905
1906 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1907
1908 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1909 a display string, extend search for cursor position to end of row.
1910 (find_row_edges): If the row ends in a newline from a display
1911 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1912 Handle the case of a display string with multiple newlines.
1913 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1914 non-empty line. Fixes confusing cursor motion with arrow keys at
1915 the beginning of a line that starts with whitespace.
1916
1917 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1918
1919 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1920 (bug#9493).
1921
1922 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1923
1924 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1925 boolean (Bug#9154).
1926
1927 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1928
1929 * xdisp.c (display_line): Record maximum and minimum buffer
1930 positions even if no glyphs were produced (e.g., by a zero-width
1931 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1932 buffer positions that will be removed from the glyph row because
1933 they don't fit.
1934 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1935 column is beyond frame width: don't subtract 1 "pixel" when
1936 computing width of the stretch.
1937 (reseat_at_next_visible_line_start): Undo the change made on
1938 2011-09-17 that saved paragraph information and restored it after
1939 the call to `reseat'. (Bug#9545)
1940
1941 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1942
1943 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1944 and turn window cursor on if cleared (Bug#9415).
1945
1946 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1947
1948 * search.c (boyer_moore): Take unibyte characters from pattern
1949 literally. (Bug#9458)
1950
1951 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1952
1953 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1954
1955 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 Fix minor problem found by static checking.
1958 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1959 initialized, to pacify gcc -Wuninitialized.
1960
1961 * fileio.c: Report proper errno when syscall falls.
1962 (Finsert_file_contents): Save and restore errno,
1963 so that report_file_error outputs the correct diagnostic.
1964 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1965
1966 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1967
1968 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1969
1970 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1973 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1974
1975 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1976
1977 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1978 about the current paragraph and restore it after the call to reseat.
1979
1980 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1981 (bidi_find_paragraph_start): Search back for paragraph beginning
1982 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1983 (bidi_move_to_visually_next): Only trigger paragraph-related
1984 computations when the last character is a newline or at EOB, not
1985 just any NEUTRAL_B. (Bug#9470)
1986
1987 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1988 truncated lines if point is covered by a display string. (Bug#9524)
1989
1990 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1993 (cons_to_x_long): New function.
1994 (lisp_data_to_selection_data): Use it. Correct the test for
1995 short-versus-long data; it was negated. Break out of vector
1996 loop, for efficiency, when a long datum is discovered.
1997
1998 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1999
2000 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2001
2002 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2003
2004 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2005 GCC PR/17406) by declaring this function with external scope.
2006
2007 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2010 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2011
2012 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2013
2014 * editfns.c (Fformat): Correctly handle text properties on "%%".
2015
2016 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2017
2018 * xterm.c (x_draw_composite_glyph_string_foreground):
2019 * w32term.c (x_draw_composite_glyph_string_foreground):
2020 * term.c (encode_terminal_code):
2021 * composite.c (composition_update_it, get_composition_id):
2022 * xdisp.c (get_next_display_element)
2023 (fill_composite_glyph_string): Add comments about special meaning
2024 of TAB characters in a composition.
2025
2026 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2029 This occurs when processing a multibyte format.
2030 Problem reported by Wolfgang Jenker.
2031
2032 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2033
2034 * xdisp.c (try_cursor_movement): Only check for exact match if
2035 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2036
2037 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 Remove unused external symbols.
2040 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2041 * xdisp.c (calc_pixel_width_or_height): Now static.
2042 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2043 * indent.c (check_display_width):
2044 * w32term.c: Fix comment to match code.
2045 * xterm.c, xterm.h (x_catching_errors): Remove.
2046
2047 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 * xselect.c: Use signed conversions more consistently (Bug#9498).
2050 (selection_data_to_lisp_data): Assume incoming selection data are
2051 signed integers, not unsigned. This is to be consistent with
2052 outgoing selection data, which was modified to use signed integers
2053 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2054 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2055 expects long, not unsigned long.
2056
2057 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2058
2059 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2060 computation of loop end. Reported by Johan Bockgård
2061 <bojohan@gnu.org>.
2062
2063 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2064
2065 * frame.c (Fother_visible_frames_p): Function deleted.
2066
2067 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2068
2069 * indent.c (compute_motion): Process display vector front to back
2070 rather than the other way around. (Bug#2496)
2071
2072 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2073
2074 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2075
2076 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2077
2078 * minibuf.c (Fread_from_minibuffer): Doc fix.
2079
2080 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2081
2082 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2083 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2084
2085 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2086
2087 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2088 value for non-existent files.
2089
2090 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2091
2092 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2093 set its "size" to -1. This will set the modtime_size field of
2094 the corresponding buffer to -1, which is what
2095 verify-visited-file-modtime expects for files that do not exist.
2096 (Bug#9139)
2097
2098 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2101 here ...
2102 * lisp.h: ... from here. push_key_description is no longer
2103 defined in keyboard.c, so its declaration should not be in
2104 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2105 logically belongs with push_key_description.
2106
2107 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 * buffer.h: Include <sys/types.h> instead of <time.h>.
2110 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2111 Problem reported by Herbert J. Skuhra.
2112
2113 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2114
2115 * xml.c (parse_region): Make the parsing work for
2116 non-comment-starting XML files again (bug#9144).
2117
2118 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2119
2120 * image.c (gif_load): Fix calculation of bottom and right corner.
2121 (Bug#9468)
2122
2123 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2124
2125 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2126 redisplay in small windows.
2127
2128 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2129
2130 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2131
2132 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2133
2134 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2135 Operate on live windows only.
2136
2137 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2138
2139 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2140
2141 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2142
2143 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2144 only under bidi iteration.
2145
2146 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2147
2148 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2149
2150 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2153 Without this fix, the command to link temacs failed due to an
2154 undefined symbol __builtin_isnan. This is because
2155 /usr/include/iso/math_c99.h #defines isnan(x) to
2156 __builtin_isnan(x), but the bundled gcc, which identifies itself
2157 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2158 a __builtin_isnan.
2159 * floatfns.c (isnan): #undef, and then #define to a clone of
2160 what's in data.c.
2161 (Fisnan): Always define, since it's always available now.
2162 (syms_of_floatfns): Always define isnan at the Lisp level.
2163
2164 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2167
2168 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2171 The previous code assumed that file offsets (off_t values) fit in
2172 EMACS_INT variables, which is not true on typical 32-bit hosts.
2173 The code messed up by falsely reporting buffer overflow in cases
2174 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2175 when "big" contains more than 2**29 bytes, even though this
2176 inserts just one byte and does not overflow the buffer.
2177 (Finsert_file_contents): Store file offsets as off_t
2178 values, not as EMACS_INT values. Check for overflow when
2179 converting between EMACS_INT and off_t. When checking for
2180 buffer overflow or for overlap, take the offsets into account.
2181 Don't use EMACS_INT for small values where int suffices.
2182 When checking for overlap, fix a typo: ZV was used where
2183 ZV_BYTE was intended.
2184 (Fwrite_region): Don't assume off_t fits into 'long'.
2185 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2186
2187 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2188
2189 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2190
2191 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 sprintf-related integer and memory overflow issues (Bug#9412).
2194
2195 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2196 (esprintf, exprintf, evxprintf): New functions.
2197 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2198 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2199 (modify_event_symbol): Do not assume that the length of
2200 name_alist_or_stem is safe to alloca and fits in int.
2201 (Fexecute_extended_command): Likewise for function name and binding.
2202 (Frecursion_depth): Wrap around reliably on integer overflow.
2203 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2204 since some callers pass EMACS_INT values.
2205 (Fsingle_key_description): Don't crash if symbol name contains more
2206 than MAX_ALLOCA bytes.
2207 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2208 (get_minibuffer): Arg is now EMACS_INT, not int.
2209 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2210 (esprintf, exprintf, evxprintf): New decls.
2211 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2212
2213 * dbusbind.c (signature_cat): New function.
2214 (xd_signature, Fdbus_register_signal):
2215 Do not overrun buffer; instead, report string overflow.
2216
2217 * dispnew.c (add_window_display_history): Don't overrun buffer.
2218 Truncate instead; this is OK since it's just a log.
2219
2220 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2221 even if the time zone offset is outlandishly large.
2222 Don't mishandle offset == INT_MIN.
2223
2224 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2225 when creating daemon; the previous buffer-overflow check was incorrect.
2226
2227 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2228 which has the guts of the old verror function.
2229
2230 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2231 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2232
2233 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2234 (font_unparse_xlfd): Don't blindly alloca long strings.
2235 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2236 fits in int, when using sprintf. Use single snprintf to count
2237 length of string rather than counting it via multiple sprintfs;
2238 that's simpler and more reliable.
2239 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2240 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2241 sprintf, in case result does not fit in int.
2242
2243 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2244 (fontset_from_font): Print it.
2245
2246 * frame.c (tty_frame_count): Now printmax_t, not int.
2247 (make_terminal_frame, set_term_frame_name): Print it.
2248 (x_report_frame_params): In X, window IDs are unsigned long,
2249 not signed long, so print them as unsigned.
2250 (validate_x_resource_name): Check for implausibly long names,
2251 and don't assume name length fits in 'int'.
2252 (x_get_resource_string): Don't blindly alloca invocation name;
2253 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2254 not fit in int.
2255
2256 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2257 (xg_check_special_colors, xg_set_geometry):
2258 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2259
2260 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2261 Use esprintf, not sprintf, in case result does not fit in int.
2262
2263 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2264 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2265 it as a large positive number.
2266 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2267 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2268
2269 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2270 in case result does not fit in int.
2271
2272 * print.c (float_to_string): Detect width overflow more reliably.
2273 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2274 buffer overrun. Don't assume list length fits in 'int'. Treat
2275 print length of 0 as 0, not as infinity; to be consistent with other
2276 uses of print length in this function. Don't overflow print length
2277 index. Don't assume hash table size fits in 'long', or that
2278 vectorlike size fits in 'unsigned long'.
2279
2280 * process.c (make_process): Use printmax_t, not int, to format
2281 process-name gensyms.
2282
2283 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2284
2285 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2286 to avoid potential buffer overrun.
2287
2288 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2289 if X resource line is longer than 512 bytes.
2290
2291 * xfns.c (x_window): Make sprintf buffer a bit bigger
2292 to avoid potential buffer overrun.
2293
2294 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2295
2296 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2297
2298 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2299
2300 Integer overflow fixes for scrolling, etc.
2301 Without these, Emacs silently mishandles large integers sometimes.
2302 For example, "C-u 4294967297 M-x recenter" was treated as if
2303 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2304
2305 * xdisp.c (try_window_id): Check Emacs fixnum range before
2306 converting to 'int'.
2307
2308 * window.c (window_scroll_line_based, Frecenter):
2309 Check that an Emacs fixnum is in range before assigning it to 'int'.
2310 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2311 values converted from Emacs fixnums.
2312 (Frecenter): Don't wrap around a line count if it is out of 'int'
2313 range; instead, treat it as an extreme value.
2314 (Fset_window_configuration, compare_window_configurations):
2315 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2316
2317 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2318 that can exceed INT_MAX. Check that EMACS_INT value is in range
2319 before assigning it to the (possibly-narrower) index.
2320 (match_limit): Don't assume that a fixnum can fit in 'int'.
2321
2322 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2323 exceed INT_MAX.
2324
2325 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2326 (Fvertical_motion): Don't wrap around LINES values that don't fit
2327 in 'int'. Instead, treat them as extreme values. This is good
2328 enough for windows, which can't have more than INT_MAX lines anyway.
2329
2330 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2331
2332 * Require libxml/parser.h to avoid compilation warning.
2333
2334 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2335
2336 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2337 since this reportedly can destroy thread storage.
2338
2339 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2340
2341 * syntax.c (find_defun_start): Update all cache variables if
2342 exiting early (Bug#9401).
2343
2344 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2345
2346 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2347
2348 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2349 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2350 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2351
2352 * term.c (tty_append_glyph): New function.
2353 (produce_stretch_glyph): Static function and its prototype deleted.
2354
2355 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2356 Add prototypes.
2357
2358 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2359
2360 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2361 when checking :margin (Bug#9390).
2362 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2363 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2364 so that the name doesn't mislead. All uses changed.
2365
2366 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2367
2368 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2369 set_tty_hooks.
2370
2371 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2372
2373 * xdisp.c (move_it_to): Don't bail out early when reaching
2374 position beyond to_charpos, if we are scanning backwards.
2375 (move_it_vertically_backward): When DY == 0, make sure we get to
2376 the first character in the line after the newline.
2377
2378 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2381 (ccl_driver): Do not generate an out-of-range pointer.
2382 (Fccl_execute_on_string): Remove unnecessary check for
2383 integer overflow, noted by Stefan Monnier in
2384 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2385 Remove a FIXME that didn't need fixing.
2386 Simplify the newly-introduced buffer reallocation code.
2387
2388 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2389
2390 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2391
2392 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 Integer and memory overflow issues (Bug#9196).
2395
2396 * doc.c (get_doc_string): Rework so that
2397 get_doc_string_buffer_size is the actual buffer size, rather than
2398 being 1 less than the actual buffer size; this makes xpalloc more
2399 convenient.
2400
2401 * image.c (x_allocate_bitmap_record, cache_image):
2402 * xselect.c (Fx_register_dnd_atom):
2403 Simplify previous changes by using xpalloc.
2404
2405 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2406 since either will do and ptrdiff_t is convenient with xpalloc.
2407
2408 * charset.c (charset_table_size)
2409 (struct charset_sort_data.priority): Now ptrdiff_t.
2410 (charset_compare): Don't overflow if priorities differ greatly.
2411 (Fsort_charsets): Don't assume list length fits in int.
2412 Check for size-calculation overflow when allocating sort data.
2413 (syms_of_charset): Allocate an initial charset table that is
2414 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2415
2416 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2417
2418 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2419 The actual value is always <= INT_MAX, and leaving it unsigned made
2420 overflow checking harder.
2421
2422 * dispextern.h (struct glyph_matrix.rows_allocated)
2423 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2424 with xpalloc. The values are still always <= INT_MAX.
2425
2426 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2427
2428 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2429 (SAFE_NALLOCA): New macro.
2430
2431 * region-cache.c (struct boundary.pos, find_cache_boundary)
2432 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2433 (set_cache_region, invalidate_region_cache)
2434 (revalidate_region_cache, know_region_cache, region_cache_forward)
2435 (region_cache_backward, pp_cache):
2436 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2437 so that ptrdiff_t * can be passed to xpalloc.
2438 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2439 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2440 (pp_cache): Don't assume cache_len fits in int.
2441 * region-cache.h: Adjust extern decls to match.
2442
2443 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2444 EMACS_INT, since either will do, for xpalloc.
2445
2446 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2447 (xnmalloc, xnrealloc, xpalloc): New functions.
2448
2449 * bidi.c (bidi_shelve_header_size): New constant.
2450 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2451 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2452
2453 * bidi.c (bidi_cache_shrink):
2454 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2455 (overlay_strings):
2456 Don't update size of array until after memory allocation succeeds,
2457 because xmalloc/xrealloc may not return.
2458 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2459 now that we have proper integer overflow checking.
2460 (record_overlay_string, overlay_strings): Catch overflows when
2461 calculating size of overlay_str_buf.
2462
2463 * callproc.c (Fcall_process): Check for size overflow when
2464 calculating size of args2.
2465 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2466 Normally we prefer signed values, but sticking with ptrdiff_t would
2467 require adding more-complicated checks.
2468
2469 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2470 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2471 Redo buffer-overflow calculations to avoid integer overflow.
2472 Add a FIXME comment where memory seems to be over-allocated.
2473
2474 * character.c (Fstring): Check for size-calculation overflow.
2475
2476 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2477 unnecessary integer overflow. Check for size overflow.
2478 (encode_coding_object): Don't update size until xmalloc succeeds.
2479
2480 * composite.c (get_composition_id): Check for overflow in glyph
2481 length calculations.
2482
2483 Integer and memory overflow fixes for display code.
2484 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2485 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2486 (scrolling_window): Check for overflow in size calculations.
2487 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2488 Don't assume glyph table len fits in int.
2489 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2490 (row_table_size): Now ptrdiff_t, not int.
2491 (scrolling_window): Avoid overflow in size calculations.
2492 Don't update size until allocation succeeds.
2493 * fns.c (concat): Check for overflow in size calculations.
2494 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2495 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2496 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2497
2498 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2499 (get_doc_string): Check for size calculation overflow.
2500 Don't update size until allocation succeeds.
2501 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2502 EMACS_INT, where ptrdiff_t will do.
2503 (Fsubstitute_command_keys): Check for string overflow.
2504
2505 * editfns.c (set_time_zone_rule): Don't assume environment length
2506 fits in int.
2507 (message_length): Now ptrdiff_t, not int.
2508 (Fmessage_box): Don't update size until allocation succeeds.
2509 Don't assume message length fits in int.
2510 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2511
2512 * emacs.c (main): Do not reallocate argv, since there is a null at
2513 the end that can be overwritten, and this way there's no need to
2514 worry about size-calculation overflow.
2515 (sort_args): Check for size-calculation overflow.
2516
2517 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2518 alloc succeeds.
2519 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2520
2521 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2522 (x_set_scroll_bar_width, x_figure_window_size):
2523 Check for integer overflow.
2524 (x_set_alpha): Do not assume XINT fits in int.
2525
2526 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2527 This is for the members text_lines, text_cols, total_lines, total_cols,
2528 where the system imposes an 'int' limit.
2529
2530 * fringe.c (Fdefine_fringe_bitmap):
2531 Don't update size until alloc works.
2532
2533 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2534 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2535
2536 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2537 Check for size-calculation overflow.
2538 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2539 do, as we prefer signed integers.
2540 (id_to_widget.max_size, id_to_widget.used)
2541 (xg_store_widget_in_map, xg_remove_widget_from_map)
2542 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2543 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2544 Use and return ptrdiff_t, not int.
2545 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2546 * gtkutil.h: Change prototypes to match the above.
2547
2548 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2549 are duplicate now that they've been promoted to lisp.h.
2550 (x_allocate_bitmap_record, x_alloc_image_color)
2551 (make_image_cache, cache_image, xpm_load):
2552 Don't update size until alloc is done.
2553 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2554 (x_detect_edges):
2555 Check for size calculation overflow.
2556 (ct_colors_allocated_max): New constant.
2557 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2558 overflow.
2559
2560 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2561 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2562 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2563 Use ptrdiff_t, not int, to count maps.
2564 (read_char_minibuf_menu_prompt): Check for overflow in size
2565 calculations. Don't update size until allocation succeeds.
2566 Redo calculations to avoid overflow.
2567 * keyboard.h: Change prototypes to match the above.
2568
2569 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2570 to count maps.
2571 (current_minor_maps): Check for size calculation overflow.
2572 * keymap.h: Change prototypes to match the above.
2573
2574 * lread.c (read1, init_obarray): Don't update size until alloc done.
2575
2576 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2577 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2578
2579 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2580 Now ptrdiff_t, not int.
2581 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2582 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2583
2584 * process.c (Fnetwork_interface_list): Check for overflow
2585 in size calculation.
2586
2587 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2588
2589 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2590 overflow. Don't bother calling xmalloc when xrealloc will do.
2591
2592 * search.c (Freplace_match): Check for size calculation overflow.
2593 (Fset_match_data): Don't assume list lengths fit in 'int'.
2594
2595 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2596 for command line length. Do not attempt to address one before the
2597 beginning of an array, as that's not portable.
2598
2599 * term.c (max_frame_lines): Remove; unused.
2600 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2601 not int.
2602 (encode_terminal_code, calculate_costs): Check for size
2603 calculation overflow.
2604 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2605 table lengths and related sizes. Don't update size until alloc
2606 done. Redo calculations to avoid overflow.
2607 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2608
2609 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2610 subtracting pointers.
2611 (gobble_line): Check for overflow more carefully. Don't update size
2612 until alloc done.
2613
2614 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2615 Don't update size until alloc done.
2616 Redo size calculations to avoid overflow.
2617 Check for size calculation overflow.
2618 (main) [DEBUG]: Fix typo in invoking tparam1.
2619
2620 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2621 Use ptrdiff_t, not int, for sizes.
2622 (store_mode_line_noprop_char): Don't update size until alloc done.
2623
2624 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2625 Use ptrdiff_t, not int, for sizes.
2626 (Finternal_make_lisp_face, cache_face):
2627 Check for size calculation overflow.
2628 (cache_face): Treat size calculation overflows as if they were
2629 memory exhaustion (the usual treatment), rather than aborting.
2630
2631 * xfns.c (x_encode_text, x_set_name_internal)
2632 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2633 sizes, since they can exceed INT_MAX in size. Check for size
2634 calculation overflow.
2635
2636 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2637 (xg_select): Check for size calculation overflow.
2638 Don't update size until alloc done.
2639
2640 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2641 as sprintf is limited to int lengths.
2642
2643 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2644 (X_LONG_MIN): New macros.
2645 Use them to make the following changes clearer.
2646 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2647 This change doesn't affect the value now, but it may help remind
2648 future maintainers not to raise the value too much later.
2649 (SELECTION_QUANTUM): Remove, replacing with ...
2650 (selection_quantum): ... new function, which avoids overflow.
2651 All uses changed.
2652 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2653 assumption that selection length fits in 'int'.
2654 (x_reply_selection_request, x_handle_selection_request)
2655 (x_get_window_property, receive_incremental_selection)
2656 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2657 (lisp_data_to_selection_data, clean_local_selection_data):
2658 Use ptrdiff_t, not int, to record length of selection.
2659 (x_reply_selection_request, x_get_window_property)
2660 (receive_incremental_selection, x_property_data_to_lisp):
2661 Redo calculations to avoid overflow.
2662 (x_reply_selection_request): When sending hint, ceiling it at
2663 X_LONG_MAX rather than relying on wraparound overflow to send
2664 something.
2665 (x_get_window_property, receive_incremental_selection)
2666 (lisp_data_to_selection_data, x_property_data_to_lisp):
2667 Check for size-calculation overflow.
2668 (x_get_window_property, receive_incremental_selection)
2669 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2670 Don't store size until memory allocation succeeds.
2671 (x_get_window_property): Plug memory leak on memory exhaustion.
2672 Don't double-block input; malloc is safe here. Don't assume 2**34
2673 - 4 fits in unsigned long. Add an xassert to check
2674 XGetWindowProperty overflow. Be more careful about overflow
2675 calculations, and distinguish size from memory overflow better.
2676 (receive_incremental_selection): When tracing, don't assume
2677 unsigned int is less than INT_MAX.
2678 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2679 harmful) conversions of unsigned short to int.
2680 (lisp_data_to_selection_data): Don't assume that integers
2681 in the range -65535 through -1 fit in an X unsigned short.
2682 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2683 result parameters unless successful. Rely on cons_to_unsigned
2684 to report problems with elements; the old code wasn't right anyway.
2685 (x_check_property_data): Check for int overflow; we cannot use
2686 a wider type due to X limits.
2687 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2688
2689 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2690
2691 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2692 (x_term_init): Check for size calculation overflow.
2693 (x_color_cells): Don't store size until memory allocation succeeds.
2694 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2695 Don't assume alloca size is less than MAX_ALLOCA.
2696 (x_term_init): Don't assume length fits in int (sprintf is limited
2697 to int size).
2698
2699 Use ptrdiff_t for composition IDs.
2700 * character.c (lisp_string_width):
2701 * composite.c (composition_table_size, n_compositions)
2702 (get_composition_id, composition_gstring_from_id):
2703 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2704 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2705 * window.c (Frecenter):
2706 Use ptrdiff_t, not int, for composition IDs.
2707 * composite.c (get_composition_id): Check for integer overflow.
2708 * composite.h: Adjust prototypes to match the above changes.
2709
2710 Use ptrdiff_t for hash table indexes.
2711 * category.c (hash_get_category_set):
2712 * ccl.c (ccl_driver):
2713 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2714 * coding.c (coding_system_charset_list, detect_coding_system):
2715 * coding.h (struct coding_system.id):
2716 * composite.c (get_composition_id, gstring_lookup_cache):
2717 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2718 * image.c (xpm_get_color_table_h):
2719 * lisp.h (hash_lookup, hash_put):
2720 * minibuf.c (Ftest_completion):
2721 Use ptrdiff_t for hash table indexes, not int (which is too
2722 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2723 32-bit --with-wide-int hosts).
2724
2725 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2726 Add a FIXME comment about memory leaks.
2727 (syms_of_charset): Don't assume xmalloc returns.
2728
2729 Don't assume that stated character widths fit in int.
2730 * character.c (Fchar_width, c_string_width, lisp_string_width):
2731 * character.h (CHAR_WIDTH):
2732 * indent.c (MULTIBYTE_BYTES_WIDTH):
2733 Use sanitize_char_width to avoid undefined and/or bad behavior
2734 with outlandish widths.
2735 * character.h (sanitize_tab_width): Rename from sanitize_width,
2736 now that we have two such functions. All uses changed.
2737 (sanitize_char_width): New inline function.
2738
2739 Don't assume that tab-width fits in int.
2740 * character.h (sanitize_width): New inline function.
2741 (SANE_TAB_WIDTH): New macro.
2742 (ASCII_CHAR_WIDTH): Use it.
2743 * indent.c (sane_tab_width): Remove. All uses replaced by
2744 SANE_TAB_WIDTH (current_buffer).
2745 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2746
2747 * fileio.c: Integer overflow issues with file modes.
2748 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2749
2750 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2751 Remove unreachable code.
2752 (read_hex, load_charset_map_from_file): Check for integer overflow.
2753
2754 * xterm.c: Don't go over XClientMessageEvent limit.
2755 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2756 (x_send_scroll_bar_event): Likewise. Check that the size does not
2757 exceed limits imposed by XClientMessageEvent, as well as the usual
2758 ptrdiff_t and size_t limits.
2759
2760 * keyboard.c: Overflow, signedness and related fixes.
2761 (make_lispy_movement): Use same integer type in forward decl
2762 that is used in the definition.
2763 (read_key_sequence, keyremap_step):
2764 Change bufsize argument back to int, undoing my 2011-03-30 change.
2765 We prefer signed types, and int is wide enough here.
2766 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2767 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2768 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2769 length, not size_t. Use ptrdiff_t for index, not int.
2770 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2771 possibility of integer overflow.
2772
2773 Overflow, signedness and related fixes for images.
2774
2775 * dispextern.h (struct it.stack[0].u.image.image_id)
2776 (struct_it.image_id, struct image.id, struct image_cache.size)
2777 (struct image_cache.used, struct image_cache.ref_count):
2778 * gtkutil.c (update_frame_tool_bar):
2779 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2780 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2781 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2782 * nsmenu.m (update_frame_tool_bar):
2783 * xdisp.c (calc_pixel_width_or_height):
2784 * xfns.c (image_cache_refcount):
2785 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2786 on typical 64-bit hosts.
2787
2788 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2789 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2790 Omit unnecessary casts to int.
2791 (parse_image_spec): Check that integers fall into 'int' range
2792 when the callers expect that.
2793 (image_ascent): Redo ascent calculation to avoid int overflow.
2794 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2795 (lookup_image): Remove unnecessary tests.
2796 (xbm_image_p): Locals are now of int, not EMACS_INT,
2797 since parse_image_check makes sure they fit into int.
2798 (png_load, gif_load, svg_load_image):
2799 Prefer int to unsigned where either will do.
2800 (tiff_handler): New function, combining the cores of the
2801 old tiff_error_handler and tiff_warning_handler.
2802 This function is rewritten to use vsnprintf and thereby avoid
2803 stack buffer overflows. It uses only the features of vsnprintf
2804 that are common to both POSIX and native Microsoft.
2805 (tiff_error_handler, tiff_warning_handler): Use it.
2806 (tiff_load, gif_load, imagemagick_load_image):
2807 Don't assume :index value fits in 'int'.
2808 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2809 (imagemagick_load_image): Check that crop parameters fit into
2810 the integer types that MagickCropImage accepts. Don't assume
2811 Vimagemagick_render_type has a nonnegative value. Don't assume
2812 size_t fits in 'long'.
2813 (gs_load): Use printmax_t to print the widest integers possible.
2814 Check for integer overflow when computing image height and width.
2815
2816 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2817
2818 * xdisp.c (redisplay_window): Don't force window start if point
2819 will be invisible in the resulting window. (Bug#9324)
2820
2821 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2822
2823 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2824 the display spec is of the form `(space ...)'.
2825 (handle_display_spec): Return the value returned by
2826 handle_single_display_spec, not just 1 or zero.
2827 (handle_single_display_spec): If the display spec is of the form
2828 `(space ...)', and specifies display in the text area, return 2
2829 rather than 1.
2830 (try_cursor_movement): Check for the need to scroll more
2831 accurately, and prefer exact match for point under bidi.
2832 Don't advance `row' beyond the last row of the window.
2833
2834 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2835 into disp_prop; all users changed.
2836
2837 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2838 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2839 for the text covered by the display property.
2840
2841 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2842
2843 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2844 Change return value to nil.
2845 (Frecord_buffer): Delete unused function.
2846
2847 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2848
2849 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2850 buffers, return left-to-right.
2851 (set_cursor_from_row): Consider candidate row a win if its glyph
2852 represents a newline and point is on that newline. Fixes cursor
2853 positioning on the newline at EOL of R2L text within L2R
2854 paragraph, and vice versa.
2855 (try_cursor_movement): Check continued rows, in addition to
2856 continuation rows. Fixes unwarranted scroll when point enters a
2857 continued line of R2L text within an L2R paragraph, or vice versa.
2858 (cursor_row_p): Consider the case of point being equal to
2859 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2860 from the end of a short line to the beginning of a continued line
2861 of R2L text within L2R paragraph.
2862 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2863 composed characters.
2864
2865 * bidi.c (bidi_check_type): Use xassert.
2866 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2867 members.
2868
2869 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2870
2871 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2872 a character.
2873
2874 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2875
2876 * nsfont.m (ns_otf_to_script): Fix typo.
2877
2878 2011-08-22 Kenichi Handa <handa@m17n.org>
2879
2880 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2881 extra slot even if the purpose is char-code-property-table.
2882
2883 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2884
2885 * xdisp.c (redisplay_window): When computing centering_position,
2886 account for the height of the header line. (Bug#8874)
2887
2888 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2889 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2890 candidate is selected by the mouse, and that candidate has a
2891 composed character under the mouse.
2892
2893 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2894 coordinates reported by pos-visible-in-window-p for a composed
2895 character in column zero.
2896
2897 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2898
2899 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2900
2901 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2902
2903 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2904 consider it a hit if to_charpos is anywhere in the range of the
2905 composed buffer positions.
2906
2907 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2908
2909 * image.c (gif_load): Don't assume that each subimage has the same
2910 dimensions as the base image. Handle disposal method that is
2911 "undefined" by the gif spec (Bug#9335).
2912
2913 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2914
2915 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2916 (Fcondition_case): Document `debug' symbol in error handler.
2917
2918 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2919
2920 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2921 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2922 from an Org mode buffer to a Speedbar frame.
2923
2924 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2925 a composition, take its buffer position from IT->cmp_it.charpos.
2926 Fixes cursor positioning at the beginning of a line that begins
2927 with a composed character.
2928
2929 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2930
2931 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2932 character bidirectional type, use STRONG_L instead. Fixes crashes
2933 in a buffer produced by `describe-categories'.
2934
2935 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2936 members before the level stack, so they would be saved and
2937 restored when copying iterator state. Fixes incorrect reordering
2938 around TABs covered by display properties.
2939
2940 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2941
2942 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2943
2944 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2945
2946 * eval.c (internal_condition_case, internal_condition_case_1)
2947 (internal_condition_case_2, internal_condition_case_n):
2948 Remove unnecessary aborts (Bug#9081).
2949
2950 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2951
2952 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2953 has no `load' handler, try opening the file locally. (Bug#9311)
2954
2955 2011-08-16 Ken Brown <kbrown@cornell.edu>
2956
2957 * gmalloc.c: Expand comment.
2958
2959 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2960
2961 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2962 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2963
2964 2011-08-16 Ken Brown <kbrown@cornell.edu>
2965
2966 Fix memory allocation problems in Cygwin build (Bug#9273).
2967
2968 * unexcw.c ( __malloc_initialized): Declare external variable.
2969 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2970
2971 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2972 New variables.
2973 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2974 dumped emacs.
2975 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2976 in the static heap.
2977 [CYGWIN] (special_realloc): New function.
2978 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2979 requests to realloc storage in the static heap.
2980
2981 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2982
2983 * bidi.c (bidi_initialize): Remove unused local.
2984
2985 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2986
2987 * bidimirror.h:
2988 * biditype.h: Remove file.
2989 * makefile.w32-in ($(BLD)/bidi.$(O)):
2990 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2991
2992 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2993
2994 * chartab.c: Improve commentary for the uniprop_table API.
2995
2996 * bidi.c (bidi_paragraph_init): Support zero value of
2997 bidi_ignore_explicit_marks_for_paragraph_level.
2998 (bidi_initialize): Use uniprop_table instead of including
2999 biditype.h and bidimirror.h.
3000
3001 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3002 coordinates of the iterator when restoring from ppos_it.
3003 (Bug#9296)
3004
3005 2011-08-14 Kenichi Handa <handa@m17n.org>
3006
3007 * process.c (create_process): Call setup_process_coding_systems
3008 after the pid of the process is set to -1 (Bug#8162).
3009
3010 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3011
3012 * xdisp.c (move_it_in_display_line_to): Don't invoke
3013 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3014 ppos_it. Fixes vertical cursor motion when line beginning is
3015 covered by an image. (Bug#9296)
3016
3017 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3018
3019 * nsterm.h (ns_run_ascript): Declare.
3020 (NSAPP_DATA2_RUNASSCRIPT): Define.
3021
3022 * nsfns.m (as_script, as_result, as_status): New static variables.
3023 (ns_run_ascript): New function.
3024 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3025 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3026 the event loop. Get status from as_status (Bug#7276).
3027
3028 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3029 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3030 the event loop (Bug#7276).
3031
3032 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3033
3034 * gnutls.c (QCgnutls_bootprop_priority)
3035 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3036 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3037 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3038 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3039 (QCgnutls_bootprop_verify_hostname_error)
3040 (QCgnutls_bootprop_callbacks_verify): Rename from
3041 Qgnutls_bootprop_..., all uses changed.
3042
3043 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3044 uses changed.
3045
3046 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3047
3048 * xfaces.c (Qframe_set_background_mode): Now static.
3049 * dispextern.h (Qframe_set_background_mode): Remove decl.
3050
3051 * process.c (Fnetwork_interface_info): Declare local only if needed.
3052
3053 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3054
3055 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3056 (Fnetwork_interface_list): Allocate in increments of bytes instead
3057 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3058 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3059 sockaddr.
3060 (struct ifflag_def): notrailers is smart on OSX.
3061 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3062 Get hardware address with getifaddrs if available.
3063
3064 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3065
3066 * xdisp.c (iterate_out_of_display_property): xassert that
3067 IT->position is set to within IT->object's boundaries. Break from
3068 the loop as soon as EOB is reached; avoids infloops in redisplay
3069 when IT->position is set up wrongly due to some bug.
3070 Set IT->current to match the bidi iterator unconditionally.
3071 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3072 entry. Force push_it to save on the stack the current
3073 buffer/string position, to be restored by pop_it. Fix flags in
3074 the iterator structure wrt the object coming from a display
3075 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3076 properties. (Bug#9284)
3077
3078 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3079
3080 * fontset.c (fontset_get_font_group): Add proper type checks.
3081 (Bug#9172)
3082
3083 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3084
3085 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3086 and LC_VERSION_MIN_MACOSX.
3087 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3088 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3089
3090 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3091
3092 * xdisp.c (forward_to_next_line_start): Allow to use the
3093 no-display-properties-and-no-overlays under bidi display.
3094 Set disp_pos in the bidi iterator to avoid searches for display
3095 properties and overlays.
3096
3097 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3098
3099 * editfns.c (Fset_time_zone_rule): Document relationship with the
3100 setenv function.
3101
3102 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3103 the font entity extracted from the cache (Bug#8109).
3104
3105 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * composite.c (autocmp_chars): Don't reset point. That is done by
3108 restore_point_unwind (Bug#5984).
3109
3110 2011-08-07 Juri Linkov <juri@jurta.org>
3111
3112 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3113 to show the arg `TIME' instead of `TIMEVAL'.
3114
3115 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3116
3117 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3118 display property strides EOL and includes a newline, as in
3119 longlines-mode. (Bug#9254)
3120 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3121 word-wrap under bidirectional display. (Bug#9224)
3122
3123 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3124 is non-zero, even if the data buffer is NULL. Fixes a crash in
3125 vertical-motion with longlines-mode. (Bug#9254)
3126
3127 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3128
3129 * bidi.c <bidi_cache_total_alloc>: Now static.
3130 (bidi_initialize): Initialize bidi_cache_total_alloc.
3131
3132 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3133 cache. (Bug#9221)
3134
3135 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3136 amount allocated this far in `bidi_cache_total_alloc'.
3137 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3138 non-zero, only free the data buffer without restoring the cache
3139 contents. All callers changed.
3140
3141 * dispextern.h (bidi_unshelve_cache): Update prototype.
3142
3143 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3144 (move_it_in_display_line, move_it_to)
3145 (move_it_vertically_backward, move_it_by_lines): Replace the call
3146 to xfree to an equivalent call to bidi_unshelve_cache.
3147 (move_it_in_display_line_to): Fix logic of returning
3148 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3149
3150 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3151
3152 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3153 came from a string character with a `cursor' property. (Bug#9229)
3154
3155 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3156
3157 * Makefile.in (LIB_PTHREAD): New variable.
3158 (LIBES): Add LIB_PTHREAD (Bug#9216).
3159
3160 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3161 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3162
3163 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3164
3165 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3166
3167 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3168
3169 * xterm.c (x_find_topmost_parent): New function.
3170 (x_set_frame_alpha): Find topmost parent window with
3171 x_find_topmost_parent and set the property there also (bug#9181).
3172 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3173
3174 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * callproc.c (Fcall_process): Avoid vfork clobbering
3177 the local vars buffer, coding_systems, current_dir.
3178
3179 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3180
3181 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3182
3183 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3186 so that it is not optimized away.
3187
3188 * xdisp.c (compute_display_string_pos): Remove unused local.
3189
3190 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3191
3192 Fix slow cursor motion and scrolling in large buffers with
3193 selective display, like Org Mode buffers. (Bug#9218)
3194
3195 * dispextern.h (struct bidi_it): New member disp_prop_p.
3196
3197 * xdisp.c: Remove one-slot cache of display string positions.
3198 (compute_display_string_pos): Accept an additional argument
3199 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3200 for a display string or property. If found, set DISP_PROP_P
3201 non-zero.
3202
3203 * bidi.c (bidi_fetch_char): Accept an additional argument
3204 DISP_PROP_P, and pass it to compute_display_string_pos.
3205 Only handle text covered by a display string if DISP_PROP_P is returned
3206 non-zero. All callers of bidi_fetch_char changed.
3207
3208 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3209
3210 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3211
3212 2010-12-03 Don March <don@ohspite.net>
3213
3214 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3215 last character M-[char] is translated to ESC [char] (bug#7541).
3216
3217 2011-08-02 Kenichi Handa <handa@m17n.org>
3218
3219 * lisp.h (uniprop_table): Extern it.
3220
3221 * chartab.c (uniprop_table): Make it non-static.
3222
3223 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3224
3225 * xdisp.c (forward_to_next_line_start): Accept additional argument
3226 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3227 on the newline.
3228 (reseat_at_next_visible_line_start): Use the bidi iterator state
3229 returned by forward_to_next_line_start to restore the state of
3230 it->bidi_it after backing up to previous newline. (Bug#9212)
3231
3232 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3233
3234 * regex.c (re_comp): Protoize.
3235 (re_exec): Fix return type.
3236 (regexec): Fix type of `ret'. (Bug#9203)
3237
3238 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3241 This is needed if max-image-size is a floating-point number.
3242
3243 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3244
3245 * print.c (print_object): Print empty symbol as ##.
3246
3247 * lread.c (read1): Read ## as empty symbol.
3248
3249 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3250
3251 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3252 setting frame foreground color (Bug#9175).
3253 (x_set_background_color): Likewise.
3254
3255 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3256 contents (Bug#9176).
3257 (EmacsTooltip -init): Remove bezels and add shadows to
3258 tooltip windows.
3259
3260 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3261 or scroll bar (Bug#8470).
3262
3263 * nsfont.m (nsfont_open): Remove assignment to voffset and
3264 unnecessary vars hshink, expand, hd, full_height, min_height.
3265 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3266
3267 * nsterm.h (nsfont_info): Remove voffset field.
3268
3269 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3270
3271 Implement strike-through and overline on NextStep (Bug#8863).
3272
3273 * nsfont.m (nsfont_open): Use underline position provided by font,
3274 instead of hard-coded value of 2.
3275 (nsfont_draw): Call ns_draw_text_decoration instead.
3276
3277 * nsterm.h: Add declaration for ns_draw_text_decoration.
3278
3279 * nsterm.m (ns_draw_text_decoration): New function for drawing
3280 underline, overline, and strike-through.
3281 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3282 ns_draw_text_decoration. Change treatment of cursor drawing to
3283 accommodate underlining, etc.
3284
3285 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3286
3287 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3288 default.
3289
3290 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3291
3292 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3293 Without this fix, if a signal arrives just after memory fills up,
3294 'malloc' might be invoked reentrantly.
3295
3296 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3297 In other words, assume that every image size is allowed, on non-X
3298 hosts. This assumption is probably wrong, but it lets Emacs compile.
3299
3300 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3301
3302 * regex.c (re_iswctype): Convert return values to boolean.
3303
3304 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3305
3306 * xdisp.c (compute_display_string_pos): Don't use cached display
3307 string position if the buffer had its restriction changed.
3308 (Bug#9184)
3309
3310 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3313
3314 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 Integer signedness and overflow and related fixes. (Bug#9079)
3317
3318 * bidi.c: Integer size and overflow fixes.
3319 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3320 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3321 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3322 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3323 (bidi_find_other_level_edge):
3324 Use ptrdiff_t instead of EMACS_INT where either will do.
3325 This works better on 32-bit hosts configured --with-wide-int.
3326 (bidi_cache_ensure_space): Check for size-calculation overflow.
3327 Use % rather than repeated addition, for better worst-case speed.
3328 Don't set bidi_cache_size until after xrealloc returns, because it
3329 might not return.
3330 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3331 (bidi_cache_ensure_space): Also check that the bidi cache size
3332 does not exceed that of the largest Lisp string or buffer. See Eli
3333 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3334
3335 * alloc.c (__malloc_size_t): Remove.
3336 All uses replaced by size_t. See Andreas Schwab's note
3337 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3338
3339 * image.c: Improve checking for integer overflow.
3340 (check_image_size): Assume that f is nonnull, since
3341 it is always nonnull in practice. This is one less thing to
3342 worry about when checking for integer overflow later.
3343 (x_check_image_size): New function, which checks for integer
3344 overflow issues inside X.
3345 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3346 This removes the need for a memory_full check.
3347 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3348 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3349 (xbm_read_bitmap_data): Change locals back to 'int', since
3350 their values must fit in 'int'.
3351 (xpm_load_image, png_load, tiff_load):
3352 Invoke x_create_x_image_and_pixmap earlier,
3353 to avoid much needless work if the image is too large.
3354 (tiff_load): Treat overly large images as if
3355 x_create_x_image_and_pixmap failed, not as malloc failures.
3356 (gs_load): Use x_check_image_size.
3357
3358 * gtkutil.c: Omit integer casts.
3359 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3360 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3361
3362 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3363
3364 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3365 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3366 would wrongly return t on a 64-bit host.
3367
3368 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3369 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3370 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3371 and therefore cause GCC to emit a bogus diagnostic in some cases.
3372
3373 * image.c: Integer signedness and overflow and related fixes.
3374 This is not an exhaustive set of fixes, but it's time to
3375 record what I've got.
3376 (lookup_pixel_color, check_image_size): Remove redundant decls.
3377 (check_image_size): Don't assume that arbitrary EMACS_INT values
3378 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3379 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3380 (tiff_load, imagemagick_load_image):
3381 Check for overflow in size calculations.
3382 (x_create_x_image_and_pixmap): Remove unnecessary test for
3383 xmalloc returning NULL; that can't happen.
3384 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3385 (xpm_color_bucket): Use better integer hashing function.
3386 (xpm_cache_color): Don't possibly over-allocate memory.
3387 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3388 (gif_memory_source):
3389 Use ptrdiff_t, not int or size_t, to record sizes.
3390 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3391 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3392 either works, as we prefer signed integers.
3393 (tiff_read_from_memory, tiff_write_from_memory):
3394 Return tsize_t, not size_t, since that's what the TIFF API wants.
3395 (tiff_read_from_memory): Don't fail simply because the read would
3396 go past EOF; instead, return a short read.
3397 (tiff_load): Omit no-longer-needed casts.
3398 (Fimagemagick_types): Don't assume size fits into 'int'.
3399
3400 Improve hashing quality when configured --with-wide-int.
3401 * fns.c (hash_string): New function, taken from sxhash_string.
3402 Do not discard information about ASCII character case; this
3403 discarding is no longer needed.
3404 (sxhash-string): Use it. Change sig to match it. Caller changed.
3405 * lisp.h: Declare it.
3406 * lread.c (hash_string): Remove, since we now use fns.c's version.
3407 The fns.c version returns a wider integer if --with-wide-int is
3408 specified, so this should help the quality of the hashing a bit.
3409
3410 * emacs.c: Integer overflow minor fix.
3411 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3412 Define only if GNU_LINUX.
3413 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3414
3415 * dispnew.c: Integer signedness and overflow fixes.
3416 Remove unnecessary forward decls, that were a maintenance hassle.
3417 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3418 All uses changed.
3419 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3420 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3421 (prepare_desired_row, line_draw_cost):
3422 Use int, not unsigned, where either works.
3423 (save_current_matrix, restore_current_matrix):
3424 Use ptrdiff_t, not size_t, where either works.
3425 (init_display): Check for overflow more accurately, and without
3426 relying on undefined behavior.
3427
3428 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3429 Remove, replacing with the new symbols in lisp.h. All uses changed.
3430 * fileio.c (make_temp_name):
3431 * filelock.c (lock_file_1, lock_file):
3432 * xdisp.c (message_dolog):
3433 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3434 Use pMd etc. instead.
3435 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3436 replacing the pWIDE etc. symbols removed from editfns.c.
3437
3438 * keyboard.h (num_input_events): Now uintmax_t.
3439 This is (very slightly) less likely to mess up due to wraparound.
3440 All uses changed.
3441
3442 * buffer.c: Integer signedness fixes.
3443 (alloc_buffer_text, enlarge_buffer_text):
3444 Use ptrdiff_t rather than size_t when either will do, as we prefer
3445 signed integers.
3446
3447 * alloc.c: Integer signedness and overflow fixes.
3448 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3449 (__malloc_size_t): Default to size_t, not to int.
3450 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3451 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3452 Prefer ptrdiff_t to size_t when either would do, as we prefer
3453 signed integers.
3454 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3455 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3456 Now const. Initialize with values that are in range even if char
3457 is signed.
3458 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3459 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3460 These functions do the right thing with sizes > 2**32.
3461 (check_depth): Now ptrdiff_t, not int.
3462 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3463 Adjust to new way of storing sizes. Check for size overflow bugs
3464 in rest of code.
3465 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3466 slightly wrong anyway, as it missed one instance of
3467 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3468 (refill_memory_reserve): Omit needless cast to size_t.
3469 (mark_object_loop_halt): Mark as externally visible.
3470
3471 * xselect.c: Integer signedness and overflow fixes.
3472 (Fx_register_dnd_atom, x_handle_dnd_message):
3473 Use ptrdiff_t, not size_t, since we prefer signed.
3474 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3475 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3476 x_dnd_atoms_size and x_dnd_atoms_length.
3477
3478 * doprnt.c: Prefer signed to unsigned when either works.
3479 * eval.c (verror):
3480 * doprnt.c (doprnt):
3481 * lisp.h (doprnt):
3482 * xdisp.c (vmessage):
3483 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3484 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3485 prefer signed arithmetic to avoid comparison confusion.
3486 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3487 but is a bit tricky.
3488
3489 Assume freestanding C89 headers, string.h, stdlib.h.
3490 * data.c, doprnt.c, floatfns.c, print.c:
3491 Include float.h unconditionally.
3492 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3493 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3494 * regex.c: Likewise for stddef.h, string.h.
3495 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3496 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3497 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3498 (STDC_HEADERS): Remove obsolete defines.
3499 * sysdep.c: Include limits.h unconditionally.
3500
3501 Assume support for memcmp, memcpy, memmove, memset.
3502 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3503 * regex.c (memcmp, memcpy):
3504 Remove; we assume C89 now.
3505
3506 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3507 (__malloc_safe_bcopy): Remove; no longer needed.
3508
3509 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3510 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3511 well either way, and we prefer signed to unsigned.
3512
3513 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3514
3515 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3516 closes the connection while we're reading (bug#9182).
3517
3518 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3519
3520 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3521 are specified (Bug#9168).
3522
3523 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3526 Found by GCC static checking and --with-wide-int on a 32-bit host.
3527
3528 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3529
3530 * xdisp.c (compute_display_string_pos): Fix logic of caching
3531 previous display string position. Initialize cached_prev_pos to
3532 -1. Fixes slow-down at the beginning of a buffer.
3533
3534 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3535
3536 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3537 for attrs[LFACE_FONTSET_INDEX].
3538
3539 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3540
3541 * xml.c (parse_region): Remove unused local
3542 that was recently introduced.
3543
3544 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3545
3546 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3547 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3548
3549 * xdisp.c (move_it_in_display_line_to): Record the best matching
3550 position for TO_CHARPOS while scanning the line, and restore it on
3551 exit if none of the characters scanned was an exact match.
3552 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3553 when exact match is impossible due to invisible text, and the
3554 lines are truncated.
3555
3556 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3557
3558 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3559 for OSX >= 10.7.
3560
3561 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3562
3563 Fix a significant slow-down of cursor motion with C-n, C-p,
3564 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3565 auto-repeat under bidi redisplay in fontified buffers.
3566 * xdisp.c (compute_stop_pos_backwards): New function.
3567 (next_element_from_buffer): Call compute_stop_pos_backwards to
3568 find a suitable prev_stop when we find ourselves before
3569 base_level_stop.
3570 (reseat): Don't look for prev_stop, as that could mean a very long
3571 run.
3572 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3573 <cached_disp_overlay_modiff>: Cache for last found display string
3574 position.
3575 (compute_display_string_pos): Return the cached position if asked
3576 about the same buffer in the same area of character positions, and
3577 the buffer wasn't changed since the time the display string
3578 position was cached.
3579
3580 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3581
3582 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3583 is an integer, which is important for empty lines. (Bug#9149)
3584
3585 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3586
3587 * frame.c (Fmodify_frame_parameters): In tty case, update the
3588 default face if necessary (Bug#4238).
3589
3590 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3591
3592 * editfns.c (Fstring_to_char): No need to explain what a character
3593 is in the docstring (Bug#6576).
3594
3595 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3596
3597 * xml.c (parse_region): Make sure we always return a tree.
3598
3599 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3600
3601 * xml.c (parse_region): If a document contains only comments,
3602 return that, too.
3603
3604 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3605
3606 * xml.c (make_dom): Return comments, too.
3607
3608 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3609
3610 Port to OpenBSD.
3611 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3612 and the surrounding thread.
3613 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3614 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3615 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3616 timer goes off.
3617 * s/openbsd.h (BROKEN_SIGIO): Define.
3618 * unexelf.c (unexec) [__OpenBSD__]:
3619 Don't update the .mdebug section of the Alpha COFF symbol table.
3620
3621 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3622
3623 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3624 (bug#8460).
3625
3626 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3629 This fixes some race conditions on the permissions of any newly
3630 created file.
3631
3632 * alloc.c (valid_pointer_p): Use pipe, not open.
3633 This fixes some permissions issues when debugging.
3634
3635 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3636 If fchown fails to set both uid and gid, try to set just gid,
3637 as that is sometimes allowed. Adjust the file's mode to eliminate
3638 setuid or setgid bits that are inappropriate if fchown fails.
3639
3640 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3641
3642 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3643 to compare Lisp_Objects.
3644 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3645 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3646 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3647
3648 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3649
3650 * lread.c (read_integer): Unread even EOF character.
3651 (read1): Likewise. Properly record start position of symbol.
3652
3653 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3654 symbol character follows.
3655
3656 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3659 This works around a problem with the previous change to Fcopy_file.
3660 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3661 and without this change, GCC might complain about discarding
3662 fchown's return value.
3663
3664 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3665
3666 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3667
3668 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3671
3672 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3673
3674 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3675 it's used from the C level.
3676
3677 * process.c: Use the same condition for POLL_FOR_INPUT in both
3678 keyboard.c and process.c (bug#1858).
3679
3680 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3681
3682 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3683 (Fgnutls_boot): Use it.
3684
3685 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3686
3687 * doc.c (Fsubstitute_command_keys): Revert last change.
3688
3689 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3690
3691 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3692 quotes the next character, and doesn't affect other longer
3693 sequences (bug#8935).
3694
3695 * lread.c (syms_of_lread): Clarify that is isn't only
3696 `eval-buffer' and `eval-defun' that's affected by
3697 `lexical-binding' (bug#8460).
3698
3699 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3700
3701 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3702 bidi redisplay when a line includes both an image and is truncated.
3703
3704 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3705
3706 Fix minor problems found by static checking.
3707 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3708 (elsz): Now a signed constant, not a size_t var. We prefer signed
3709 types to unsigned, to avoid integer comparison confusion. Without
3710 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3711 "cannot optimize loop, the loop counter may overflow", a symptom
3712 of the confusion.
3713 * indent.c (Fvertical_motion): Mark locals as initialized.
3714 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3715
3716 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3717
3718 * search.c (Fre_search_backward): Mention `case-fold-search' in
3719 all the re_search_* functions (bug#8138).
3720
3721 * keyboard.c (Fopen_dribble_file): Document when the file is
3722 closed (bug#8056).
3723
3724 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3725
3726 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3727 bidi_cache_idx.
3728
3729 Support bidi reordering of display and overlay strings.
3730 * xdisp.c (compute_display_string_pos)
3731 (compute_display_string_end): Accept additional argument STRING.
3732 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3733 (reseat_to_string): Initialize bidi_it->string.s and
3734 bidi_it->string.schars.
3735 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3736 NULL (avoids a crash in bidi_paragraph_init).
3737 Initialize itb.string.lstring.
3738 (init_iterator): Call bidi_init_it only of a valid
3739 buffer position was specified. Initialize paragraph_embedding to
3740 L2R.
3741 (reseat_to_string): Initialize the bidi iterator.
3742 (display_string): If we need to ignore text properties of
3743 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3744 original value of -1 will not work with bidi.)
3745 (compute_display_string_pos): First arg is now struct
3746 `text_pos *'; all callers changed. Support display properties on
3747 Lisp strings.
3748 (compute_display_string_end): Support display properties on Lisp
3749 strings.
3750 (init_iterator, reseat_1, reseat_to_string): Initialize the
3751 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3752 when iterating on a string not from display properties).
3753 (compute_display_string_pos, compute_display_string_end):
3754 Fix calculation of the object to scan. Fixes an error when using
3755 arrow keys.
3756 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3757 base_level_stop; instead, set base_level_stop to BEGV.
3758 Fixes crashes in vertical-motion.
3759 (next_element_from_buffer): Improve commentary for when
3760 the iterator is before prev_stop.
3761 (init_iterator): Initialize bidi_p from the default value of
3762 bidi-display-reordering, not from buffer-local value. Use the
3763 buffer-local value only if initializing for buffer iteration.
3764 (handle_invisible_prop): Support invisible properties on strings
3765 that are being bidi-reordered.
3766 (set_iterator_to_next): Support bidi reordering of C strings and
3767 Lisp strings.
3768 (next_element_from_string): Support bidi reordering of Lisp
3769 strings.
3770 (handle_stop_backwards): Support Lisp strings as well.
3771 (display_string): Support display of R2L glyph rows.
3772 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3773 (init_iterator): Don't initialize it->bidi_p for strings
3774 here.
3775 (reseat_to_string): Initialize it->bidi_p for strings here.
3776 (next_element_from_string, next_element_from_c_string)
3777 (next_element_from_buffer): Add xassert's for correspondence
3778 between IT's object being iterated and it->bidi_it.string
3779 structure.
3780 (face_before_or_after_it_pos): Support bidi iteration.
3781 (next_element_from_c_string): Handle the case of the first string
3782 character that is not the first one in the visual order.
3783 (get_visually_first_element): New function, refactored from common
3784 parts of next_element_from_buffer, next_element_from_string, and
3785 next_element_from_c_string.
3786 (tool_bar_lines_needed, redisplay_tool_bar)
3787 (display_menu_bar): Force left-to-right direction. Add a FIXME
3788 comment for making that be controlled by a user option.
3789 (push_it, pop_it): Save and restore the state of the
3790 bidi iterator. Save and restore the bidi_p flag.
3791 (pop_it): Iterate out of display property for string iteration as
3792 well.
3793 (iterate_out_of_display_property): Support iteration over strings.
3794 (handle_single_display_spec): Set up it->bidi_it for iteration
3795 over a display string, and call bidi_init_it.
3796 (handle_single_display_spec, next_overlay_string)
3797 (get_overlay_strings_1, push_display_prop): Set up the bidi
3798 iterator for displaying display or overlay strings.
3799 (forward_to_next_line_start): Don't use the shortcut if
3800 bidi-iterating.
3801 (back_to_previous_visible_line_start): If handle_display_prop
3802 pushed the iterator stack, restore the internal state of the bidi
3803 iterator by calling bidi_pop_it same number of times.
3804 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3805 and we are bidi-iterating, don't decrement the iterator position;
3806 instead, set the first_elt flag in the bidi iterator, to produce
3807 the same effect.
3808 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3809 (push_display_prop): xassert that we are iterating a buffer.
3810 (push_it, pop_it): Save and restore paragraph_embedding member.
3811 (handle_single_display_spec, next_overlay_string)
3812 (get_overlay_strings_1, reseat_1, reseat_to_string)
3813 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3814 correctly. Don't assume unibyte strings are not bidi-reordered.
3815 (compute_display_string_pos)
3816 (compute_display_string_end): Fix handling the case of C string.
3817 (push_it, pop_it): Save and restore from_disp_prop_p.
3818 (handle_single_display_spec, push_display_prop): Set the
3819 from_disp_prop_p flag.
3820 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3821 (pop_it): Call iterate_out_of_display_property only if we are
3822 popping after iteration over a string that came from a display
3823 property. Fix a typo in popping stretch info. Add an assertion
3824 for verifying that the iterator position is in sync with the bidi
3825 iterator.
3826 (handle_single_display_spec, get_overlay_strings_1)
3827 (push_display_prop): Fix initialization of paragraph direction for
3828 string when that of the parent object is not yet determined.
3829 (reseat_1): Call bidi_init_it to resync the bidi
3830 iterator with IT's position. (Bug#7616)
3831 (find_row_edges): If ROW->start.pos gives position
3832 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3833 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3834 Reset the from_disp_prop_p flag.
3835 (SAVE_IT, RESTORE_IT): New macros.
3836 (pos_visible_p, face_before_or_after_it_pos)
3837 (back_to_previous_visible_line_start)
3838 (move_it_in_display_line_to, move_it_in_display_line)
3839 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3840 (try_scrolling, redisplay_window, display_line): Use them when
3841 saving a temporary copy of the iterator and restoring it back.
3842 (back_to_previous_visible_line_start, reseat_1)
3843 (init_iterator): Empty the bidi cache "stack".
3844 (move_it_in_display_line_to): If iterator ended up at
3845 EOL, but we never saw any buffer positions smaller than
3846 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3847 motion in bidi-reordered lines.
3848 (move_it_in_display_line_to): Record prev_method and prev_pos
3849 immediately before the call to set_iterator_to_next. Fixes cursor
3850 motion in bidi-reordered lines with stretch glyphs and strings
3851 displayed in margins. (Bug#8133) (Bug#8867)
3852 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3853 TO_CHARPOS.
3854 (pos_visible_p): Support positions in bidi-reordered lines.
3855 Save and restore bidi cache.
3856
3857 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3858 (bidi_paragraph_info): Delete unused struct.
3859 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3860 (bidi_cache_start): New variable.
3861 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3862 to zero.
3863 (bidi_cache_fetch_state, bidi_cache_search)
3864 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3865 (bidi_cache_find, bidi_peek_at_next_level)
3866 (bidi_level_of_next_char, bidi_find_other_level_edge)
3867 (bidi_move_to_visually_next): Compare cache index with
3868 bidi_cache_start rather than with zero.
3869 (bidi_fetch_char): Accept new argument STRING; all callers
3870 changed. Support iteration over a string. Support strings with
3871 display properties. Support unibyte strings. Fix the type of
3872 `len' according to what STRING_CHAR_AND_LENGTH expects.
3873 (bidi_paragraph_init, bidi_resolve_explicit_1)
3874 (bidi_resolve_explicit, bidi_resolve_weak)
3875 (bidi_level_of_next_char, bidi_move_to_visually_next):
3876 Support iteration over a string.
3877 (bidi_set_sor_type, bidi_resolve_explicit_1)
3878 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3879 can now be zero (for strings); special values 0 and -1 were
3880 changed to -1 and -2, respectively.
3881 (bidi_char_at_pos): New function.
3882 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3883 Call it instead of FETCH_MULTIBYTE_CHAR.
3884 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3885 initialized to valid values.
3886 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3887 values.
3888 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3889 the test for valid cached positions. Fix the logic for looking up
3890 the sentinel state in the cache. GCPRO the Lisp string we are
3891 iterating.
3892 (bidi_push_it, bidi_pop_it): New functions.
3893 (bidi_initialize): Initialize the bidi cache start stack pointer.
3894 (bidi_cache_ensure_space): New function, refactored from part of
3895 bidi_cache_iterator_state. Don't assume the required size is just
3896 one BIDI_CACHE_CHUNK away.
3897 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3898 (bidi_count_bytes, bidi_char_at_pos): New functions.
3899 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3900 always valid if bidi_cache_idx is valid.
3901 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3902 is valid if it's going to be used.
3903 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3904 (bidi_cache_fetch_state, bidi_cache_search)
3905 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3906 (bidi_cache_iterator_state, bidi_cache_find)
3907 (bidi_find_other_level_edge, bidi_cache_start_stack):
3908 All variables related to cache indices are now EMACS_INT.
3909
3910 * dispextern.h (struct bidi_string_data): New structure.
3911 (struct bidi_it): New member `string'. Make flag members be 1-bit
3912 fields, and put them last in the struct.
3913 (compute_display_string_pos, compute_display_string_end):
3914 Update prototypes.
3915 (bidi_push_it, bidi_pop_it): Add prototypes.
3916 (struct iterator_stack_entry): New members bidi_p,
3917 paragraph_embedding, and from_disp_prop_p.
3918 (struct it): Member bidi_p is now a bit field 1 bit wide.
3919 (bidi_shelve_cache, bidi_unshelve_cache):
3920 Declare prototypes.
3921
3922 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3923 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3924 and vector-like objects.
3925
3926 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3927 cache around display iteration.
3928
3929 * window.c (Fwindow_end, window_scroll_pixel_based)
3930 (displayed_window_lines, Frecenter): Save and restore the bidi
3931 cache around display iteration.
3932
3933 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3934
3935 * editfns.c (Fdelete_region): Clarify the use of the named
3936 parameters (bug#6788).
3937
3938 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3939
3940 * indent.c (Fvertical_motion): Set and restore w->pointm when
3941 saving and restoring the window's buffer (Bug#9006).
3942
3943 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3944
3945 * editfns.c (Fstring_to_char): Clarify just what is returned
3946 (bug#6576). Text by Eli Zaretskii.
3947
3948 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3949
3950 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3951
3952 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3953
3954 * buffer.c (mmap_find): Fix a typo.
3955
3956 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3957
3958 Fix execution of x selection hooks.
3959 * xselect.c (Qx_lost_selection_functions)
3960 (Qx_sent_selection_functions): New vars.
3961 (syms_of_xselect): DEFSYM them.
3962 (x_handle_selection_request): Pass Qx_sent_selection_functions
3963 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3964 (x_handle_selection_clear,x_clear_frame_selections):
3965 Pass Qx_lost_selection_functions rather than
3966 Vx_lost_selection_functions to Frun_hook_with_args.
3967
3968 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3971 The old code sometimes used this field without initializing it.
3972
3973 * alloc.c (gc_sweep): Don't read past end of array.
3974 In theory, the old code could also have corrupted Emacs internals,
3975 though it'd be very unlikely.
3976
3977 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3978
3979 * character.c (Fcharacterp): Don't advertise optional ignored
3980 argument. (Bug#4026)
3981
3982 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3983
3984 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3985 key" (bug#4257).
3986
3987 * window.c (Fset_window_start): Doc fix (bug#4199).
3988 (Fset_window_hscroll): Ditto.
3989
3990 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 Fix minor new problems caught by GCC 4.6.1.
3993 * term.c (init_tty): Remove unused local.
3994 * xsettings.c (store_monospaced_changed): Define this function only
3995 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3996 not used otherwise.
3997
3998 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3999
4000 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4001
4002 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4003
4004 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4005 are the mini-buffer and the echo area (bug#3320).
4006
4007 * term.c (init_tty): Remove support for supdup, c10 and perq
4008 terminals, which are no longer supported (bug#1482).
4009
4010 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4011
4012 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4013
4014 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4015
4016 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4017 for non-popups (Bug#3642).
4018
4019 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4020
4021 * alloc.c (reset_malloc_hooks): Protoize.
4022 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4023 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4024 * cm.c (losecursor): Likewise.
4025 * data.c (fmod): Likewise.
4026 * dispnew.c (swap_glyphs_in_rows): Likewise.
4027 * emacs.c (memory_warning_signal): Likewise.
4028 * floatfns.c (float_error): Likewise.
4029 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4030 (otf_open, font_otf_capability, generate_otf_features)
4031 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4032 Likewise.
4033 * image.c (pbm_read_file): Likewise.
4034 * indent.c (string_display_width): Likewise.
4035 * intervals.c (check_for_interval, search_for_interval)
4036 (inc_interval_count, count_intervals, root_interval)
4037 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4038 * lread.c (defalias): Likewise.
4039 * ralloc.c (r_alloc_check): Likewise.
4040 * regex.c (set_image_of_range_1, set_image_of_range)
4041 (regex_grow_registers): Likewise.
4042 * sysdep.c (strerror): Likewise.
4043 * termcap.c (valid_filename_p, tprint, main): Likewise.
4044 * tparam.c (main): Likewise.
4045 * unexhp9k800.c (run_time_remap, save_data_space)
4046 (update_file_ptrs, read_header, write_header, calculate_checksum)
4047 (copy_file, copy_rest, display_header): Likewise.
4048 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4049 Likewise.
4050 * xdisp.c (check_it): Likewise.
4051 * xfaces.c (register_color, unregister_color, unregister_colors):
4052 Likewise.
4053 * xfns.c (print_fontset_result): Likewise.
4054 * xrdb.c (member, fatal, main): Likewise.
4055
4056 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 Fix minor problems found by static checking (Bug#9031).
4059 * chartab.c (char_table_set_range, map_sub_char_table):
4060 Remove unused locals.
4061 (uniprop_table): Now static.
4062 * composite.c (_work_char): Remove unused static var.
4063
4064 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4065
4066 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4067
4068 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4069
4070 * gtkutil.c (qttip_cb): Remove code without function.
4071
4072 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4073
4074 * w32.c (pthread_sigmask): New stub.
4075
4076 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 Use pthread_sigmask, not sigprocmask (Bug#9010).
4079 sigprocmask is portable only for single-threaded applications, and
4080 Emacs can be multi-threaded when it uses GTK.
4081 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4082 (LIBES): Use it.
4083 * callproc.c (Fcall_process):
4084 * process.c (create_process):
4085 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4086 Use pthread_sigmask, not sigprocmask.
4087
4088 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4089
4090 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4091 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4092 wrong (Bug#8591).
4093
4094 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4095
4096 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4097 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4098 (xg_hide_tooltip): Fix comment.
4099
4100 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4101 in registerServicesMenuSendTypes.
4102 (validRequestorForSendType): Don't check ns_return_types.
4103
4104 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4105 ns_return_type.
4106
4107 2011-07-08 Jason Rumney <jasonr@gnu.org>
4108
4109 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4110 SH_SHOW for hidden windows (Bug#5482).
4111
4112 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4113 frame struct members of non-existent frames (Bug#6284).
4114
4115 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4116
4117 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4118 variable firstTime not needed on OSX >= 10.6.
4119 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4120 >= 10.5. Use setKnobProportion, setDoubleValue.
4121
4122 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4123 (MAC_OS_X_VERSION_10_5): Define if not defined.
4124 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4125 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4126 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4127
4128 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4129 cString and lossyCString on OSX >= 10.4
4130
4131 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4132 sizeToFit on OSX >= 10.2.
4133
4134 * nsimage.m (allocInitFromFile): Don't use deprecated method
4135 bestRepresentationForDevice on OSX >= 10.6.
4136
4137 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4138 to avoid warning.
4139
4140 * emacs.c: Declare unexec_init_emacs_zone.
4141
4142 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4143
4144 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4145
4146 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4147 on svcsMenu (Bug#8842).
4148
4149 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4150 ns_return_types.
4151 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4152
4153 * nsterm.m (QUTF8_STRING): Declare.
4154 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4155 (validRequestorForSendType): Return type is (id).
4156 Change indexOfObjectIdenticalTo to indexOfObject.
4157 Check if we have local selection before returning self (Bug#8842).
4158 (writeSelectionToPasteboard): Put local selection into paste board
4159 if we have a local selection (Bug#8842).
4160 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4161
4162 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4163 (ns_get_local_selection): Declare.
4164
4165 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4166
4167 * keymap.c (describe_map_tree): Don't insert a double newline at
4168 the end of the buffer (bug#1169) and return whether we inserted
4169 something.
4170
4171 * callint.c (Fcall_interactively): Change "reading args" to
4172 "providing args" to try to clarify what it does (bug#1010).
4173
4174 2011-07-07 Kenichi Handa <handa@m17n.org>
4175
4176 * composite.c (composition_compute_stop_pos): Ignore a static
4177 composition starting before CHARPOS (Bug#8915).
4178
4179 * xdisp.c (handle_composition_prop): Likewise.
4180
4181 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4182
4183 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4184 (Bug#9015)
4185
4186 2011-07-07 Kenichi Handa <handa@m17n.org>
4187
4188 * character.h (unicode_category_t): New enum type.
4189
4190 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4191 (Qchar_code_property_table): New variable.
4192 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4193 (UNIPROP_COMPRESSED_FORM_P): New macros.
4194 (char_table_ascii): Uncompress the compressed values.
4195 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4196 Uncompress the compressed values.
4197 (sub_char_table_ref_and_range): Likewise.
4198 (char_table_ref_and_range): Uncompress the compressed values.
4199 (sub_char_table_set): New arg is_uniprop. Callers changed.
4200 Uncompress the compressed values.
4201 (sub_char_table_set_range): Args changed. Callers changed.
4202 (char_table_set_range): Adjuted for the above change.
4203 (map_sub_char_table): Delete args default_val and parent. Add arg
4204 top. Give decoded values to a Lisp function.
4205 (map_char_table): Adjust for the above change. Give decoded
4206 values to a Lisp function. Gcpro more variables.
4207 (uniprop_table_uncompress)
4208 (uniprop_decode_value_run_length): New functions.
4209 (uniprop_decoder, uniprop_decoder_count): New variables.
4210 (uniprop_get_decoder, uniprop_encode_value_character)
4211 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4212 New functions.
4213 (uniprop_encoder, uniprop_encoder_count): New variables.
4214 (uniprop_get_encoder, uniprop_table)
4215 (Funicode_property_table_internal, Fget_unicode_property_internal)
4216 (Fput_unicode_property_internal): New functions.
4217 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4218 Sunicode_property_table_internal, Sget_unicode_property_internal,
4219 and Sput_unicode_property_internal. Defvar_lisp
4220 char-code-property-alist.
4221
4222 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4223 Vunicode_category_table.
4224
4225 * font.c (font_range): Adjust for the change of
4226 Vunicode_category_table.
4227
4228 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4229
4230 * m/iris4d.h: Remove file, move contents ...
4231 * s/irix6-5.h: ... here.
4232
4233 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4234
4235 Remove unportable assumption about struct layout (Bug#8884).
4236 * alloc.c (mark_buffer):
4237 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4238 (clone_per_buffer_values): Don't assume that
4239 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4240 This isn't true in general, and it's particularly not true
4241 if Emacs is configured with --with-wide-int.
4242 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4243 New macros, used in the buffer.c change.
4244
4245 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4246
4247 * xsettings.c: Use both GConf and GSettings if both are available.
4248 (store_config_changed_event): Add comment.
4249 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4250 (store_tool_bar_style_changed): New functions.
4251 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4252 (struct xsettings): Move font inside HAVE_XFT.
4253 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4254 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4255 Move inside HAVE_XFT.
4256 (something_changed_gsettingsCB): Rename from something_changedCB.
4257 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4258 also.
4259 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4260 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4261 (something_changed_gconfCB): Rename from something_changedCB.
4262 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4263 (parse_settings): Move check for font inside HAVE_XFT.
4264 (read_settings, apply_xft_settings): Add comment.
4265 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4266 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4267 call store_font_name_changed.
4268 (xft_settings_event): Add comment.
4269 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4270 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4271 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4272 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4273 (xsettings_initialize): Call init_gsettings last.
4274 (xsettings_get_system_font, xsettings_get_system_normal_font):
4275 Add comment.
4276
4277 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 Random fixes. E.g., (random) never returned negative values.
4280 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4281 subseconds part to the entropy, as that's a bit more random.
4282 Prefer signed to unsigned, since the signedness doesn't matter and
4283 in general we prefer signed. When given a limit, use a
4284 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4285 latter isn't right if USE_2_TAGS_FOR_INTS.
4286 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4287 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4288
4289 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4290
4291 * textprop.c (text_property_stickiness):
4292 Obey Vtext_property_default_nonsticky.
4293 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4294 * w32fns.c (syms_of_w32fns):
4295 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4296
4297 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4298
4299 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4300 This is more efficient than Ffile_directory_p and avoids a minor race.
4301
4302 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4303
4304 * buffer.c (Foverlay_put): Say what the return value is
4305 (bug#7835).
4306
4307 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4308 is a directory before asking whether to use the file name
4309 (bug#7564).
4310 (barf_or_query_if_file_exists): Make the "File is a directory"
4311 error be more correct.
4312
4313 * fns.c (Frequire): Remove the mention of the .gz files, since
4314 that's installation-specific, but keep the mention of
4315 `get-load-suffixes'.
4316
4317 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4320 Report string overflow if the output is too long.
4321
4322 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4323
4324 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4325 (syms_of_gnutls): Remove duplicate DEFSYM for
4326 Qgnutls_bootprop_verify_hostname_error, an error for
4327 Qgnutls_bootprop_verify_error (which is no longer used).
4328
4329 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4330 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4331 Also (re)move comments that are misplaced or no longer relevant.
4332
4333 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4334
4335 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4336
4337 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4338
4339 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4340 and background color parameters if they have been changed.
4341
4342 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343
4344 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4345
4346 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4347
4348 * xsettings.c (SYSTEM_FONT): Define only when used.
4349 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4350
4351 * keymap.c (access_keymap_1): Now static.
4352
4353 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4354
4355 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4356 leave any prefix arg for the up event (Bug#1586).
4357
4358 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4359
4360 * lread.c (syms_of_lread): Mention single symbols defined by
4361 `defvar' or `defconst' (bug#7154).
4362
4363 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4364 (Frequire): Mention get-load-suffixes.
4365
4366 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4367
4368 * window.h (window): Remove clone_number slot.
4369 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4370 Remove.
4371 (make_parent_window, make_window, saved_window)
4372 (Fset_window_configuration, save_window_save): Don't deal with
4373 clone numbers.
4374 * buffer.c (Qclone_number): Remove declaration.
4375 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4376
4377 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4378
4379 Add multiple inheritance to keymaps.
4380 * keymap.c (Fmake_composed_keymap): New function.
4381 (Fset_keymap_parent): Simplify.
4382 (fix_submap_inheritance): Remove.
4383 (access_keymap_1): New function extracted from access_keymap to handle
4384 embedded parents and handle lists of maps.
4385 (access_keymap): Use it.
4386 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4387 (Fcopy_keymap): Handle embedded parents.
4388 (Fcommand_remapping, define_as_prefix): Simplify.
4389 (Fkey_binding): Simplify.
4390 (syms_of_keymap): Move minibuffer-local-completion-map,
4391 minibuffer-local-filename-completion-map,
4392 minibuffer-local-must-match-map, and
4393 minibuffer-local-filename-must-match-map to Elisp.
4394 (syms_of_keymap): Defsubr make-composed-keymap.
4395 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4396 (parse_menu_item): Trivial simplification.
4397
4398 2011-07-01 Glenn Morris <rgm@gnu.org>
4399
4400 * Makefile.in (SETTINGS_LIBS): Fix typo.
4401
4402 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4403
4404 * coding.c (Fencode_coding_string): Record the last coding system
4405 used, as the function doc string says (bug#8738).
4406
4407 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4408
4409 * xsettings.c (store_monospaced_changed): Take new font as arg and
4410 check for change against current_mono_font.
4411 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4412 (emacs_settings_constructor, emacs_settings_get_property)
4413 (emacs_settings_set_property, emacs_settings_class_init)
4414 (emacs_settings_init, gsettings_obj): Remove.
4415 (something_changedCB): New function for HAVE_GSETTINGS.
4416 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4417 with value as argument.
4418 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4419 g_settings_new (Bug#8967). Do not create gsettings_obj.
4420 Remove calls to g_settings_bind. Connect something_changedCB to
4421 "changed".
4422
4423 * xgselect.c: Add defined (HAVE_GSETTINGS).
4424 (xgselect_initialize): Ditto.
4425
4426 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4427 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4428 xg_select.
4429
4430 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4431
4432 * eval.c (struct backtrace): Simplify and port the data structure.
4433 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4434 signed bit field, as this assumption is not portable and it makes
4435 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4436 "char debug_on_exit : 1" as this is not portable either; instead,
4437 use the portable "unsigned int debug_on_exit : 1". Remove unused
4438 member evalargs. Remove obsolete comments about cc bombing out.
4439
4440 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4441
4442 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4443 Let HAVE_GSETTINGS override HAVE_GCONF.
4444 (store_monospaced_changed): New function.
4445 (EMACS_SETTINGS): A new type derived from GObject to handle
4446 GSettings notifications.
4447 (emacs_settings_constructor, emacs_settings_get_property)
4448 (emacs_settings_set_property, emacs_settings_class_init):
4449 New functions.
4450 (gsettings_client, gsettings_obj): New variables.
4451 (GSETTINGS_SCHEMA): New define.
4452 (something_changedCB): Call store_monospaced_changed.
4453 (init_gsettings): New function.
4454 (xsettings_initialize): Call init_gsettings.
4455 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4456 to NULL.
4457
4458 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4459 GCONF_CFLAGS/LIBS.
4460
4461 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4462
4463 * window.c (resize_root_window, grow_mini_window)
4464 (shrink_mini_window): Rename Qresize_root_window to
4465 Qwindow_resize_root_window and Qresize_root_window_vertically to
4466 Qwindow_resize_root_window_vertically.
4467
4468 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4469
4470 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4471
4472 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4473
4474 * makefile.w32-in: Redesign dependencies so they reflect more
4475 clearly which files are directly included by each source file,
4476 and not through other includes.
4477
4478 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4479
4480 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4481 (sort_overlays, overlay_strings): When an overlay's clone number
4482 matches the window's clone number process the overlay even if
4483 the overlay's window property doesn't match the current window.
4484
4485 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4486 (Fwindow_hchild): Rename to Fwindow_left_child.
4487 (Fwindow_next): Rename to Fwindow_next_sibling.
4488 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4489 (resize_window_check): Rename to window_resize_check.
4490 (resize_window_apply): Rename to window_resize_apply.
4491 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4492 (Fdelete_other_windows_internal, resize_frame_windows)
4493 (Fsplit_window_internal, Fdelete_window_internal)
4494 (grow_mini_window, shrink_mini_window)
4495 (Fresize_mini_window_internal): Fix callers accordingly.
4496
4497 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4498
4499 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4500 (emacs_fixed_set_min_size): Remove.
4501 (emacs_fixed_new): Take frame as argument.
4502
4503 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4504 (_EmacsFixedPrivate): Remove minwidth/height.
4505 Add struct frame *f.
4506 (emacs_fixed_init): Initialize priv->f.
4507 (get_parent_class, emacs_fixed_set_min_size): Remove.
4508 (emacs_fixed_new): Set priv->f to argument.
4509 (emacs_fixed_get_preferred_width)
4510 (emacs_fixed_get_preferred_height): Use min_width/height from
4511 frames size_hint to set minimum and natural (Bug#8919).
4512 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4513 and use min_width/height from frames size_hint to set
4514 min_width/height (Bug#8919).
4515
4516 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4517 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4518 Fix indentation.
4519
4520 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4521
4522 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4523 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4524 called at ZV.
4525
4526 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4527
4528 * process.c (wait_reading_process_output): Bypass select if
4529 waiting for a cell while ignoring keyboard input, and input is
4530 pending. Suggested by Jan Djärv (Bug#8869).
4531
4532 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4533
4534 Use gnulib's dup2 module instead of rolling our own.
4535 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4536
4537 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4538
4539 * dispnew.c (scrolling_window): Before scrolling, turn off a
4540 mouse-highlight in the window being scrolled.
4541
4542 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4543
4544 Move DEFSYM to lisp.h and use everywhere.
4545
4546 * character.h (DEFSYM): Move declaration...
4547 * lisp.h (DEFSYM): ...here.
4548
4549 * gnutls.c:
4550 * minibuf.c:
4551 * w32menu.c:
4552 * w32proc.c:
4553 * w32select.c: Don't include character.h.
4554
4555 * alloc.c (syms_of_alloc):
4556 * buffer.c (syms_of_buffer):
4557 * bytecode.c (syms_of_bytecode):
4558 * callint.c (syms_of_callint):
4559 * casefiddle.c (syms_of_casefiddle):
4560 * casetab.c (init_casetab_once):
4561 * category.c (init_category_once, syms_of_category):
4562 * ccl.c (syms_of_ccl):
4563 * cmds.c (syms_of_cmds):
4564 * composite.c (syms_of_composite):
4565 * dbusbind.c (syms_of_dbusbind):
4566 * dired.c (syms_of_dired):
4567 * dispnew.c (syms_of_display):
4568 * doc.c (syms_of_doc):
4569 * editfns.c (syms_of_editfns):
4570 * emacs.c (syms_of_emacs):
4571 * eval.c (syms_of_eval):
4572 * fileio.c (syms_of_fileio):
4573 * fns.c (syms_of_fns):
4574 * frame.c (syms_of_frame):
4575 * fringe.c (syms_of_fringe):
4576 * insdel.c (syms_of_insdel):
4577 * keymap.c (syms_of_keymap):
4578 * lread.c (init_obarray, syms_of_lread):
4579 * macros.c (syms_of_macros):
4580 * msdos.c (syms_of_msdos):
4581 * print.c (syms_of_print):
4582 * process.c (syms_of_process):
4583 * search.c (syms_of_search):
4584 * sound.c (syms_of_sound):
4585 * syntax.c (init_syntax_once, syms_of_syntax):
4586 * terminal.c (syms_of_terminal):
4587 * textprop.c (syms_of_textprop):
4588 * undo.c (syms_of_undo):
4589 * w32.c (globals_of_w32):
4590 * window.c (syms_of_window):
4591 * xdisp.c (syms_of_xdisp):
4592 * xfaces.c (syms_of_xfaces):
4593 * xfns.c (syms_of_xfns):
4594 * xmenu.c (syms_of_xmenu):
4595 * xsettings.c (syms_of_xsettings):
4596 * xterm.c (syms_of_xterm): Use DEFSYM.
4597
4598 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4599
4600 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4601
4602 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4603
4604 Integer and buffer overflow fixes (Bug#8873).
4605
4606 * print.c (printchar, strout): Check for string overflow.
4607 (PRINTPREPARE, printchar, strout):
4608 Don't set size unless allocation succeeds.
4609
4610 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4611 for sizes. Check for string overflow more accurately.
4612 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4613
4614 * macros.c: Integer and buffer overflow fixes.
4615 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4616 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4617 Use ptrdiff_t, not int, for sizes.
4618 Don't increment bufsize until after realloc succeeds.
4619 Check for size-calculation overflow.
4620 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4621
4622 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4623
4624 * lread.c: Integer overflow fixes.
4625 (read_integer): Radix is now EMACS_INT, not int,
4626 to improve quality of diagnostics for out-of-range radices.
4627 Calculate buffer size correctly for out-of-range radices.
4628 (read1): Check for integer overflow in radices, and in
4629 read-circle numbers.
4630 (read_escape): Avoid int overflow.
4631 (Fload, openp, read_buffer_size, read1)
4632 (substitute_object_recurse, read_vector, read_list, map_obarray):
4633 Use ptrdiff_t, not int, for sizes.
4634 (read1): Use EMACS_INT, not int, for sizes.
4635 Check for size overflow.
4636
4637 * image.c (cache_image): Check for size arithmetic overflow.
4638
4639 * lread.c: Integer overflow issues.
4640 (saved_doc_string_size, saved_doc_string_length)
4641 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4642 Now ptrdiff_t, not int.
4643 (read1): Don't assume doc string length fits in int. Check for
4644 out-of-range doc string lengths.
4645 (read_list): Don't assume file position fits in int.
4646 (read_escape): Check for hex character overflow.
4647
4648 2011-06-22 Leo Liu <sdl.web@gmail.com>
4649
4650 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4651 Move to minibuffer.el.
4652
4653 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4656 The following patches are for when GLYPH_DEBUG && !XASSERT.
4657 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4658 * dispnew.c (flush_stdout):
4659 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4660 Mark as externally visible.
4661 * dispnew.c (check_window_matrix_pointers): Now static.
4662 * dispnew.c (window_to_frame_vpos):
4663 * xfns.c (unwind_create_frame):
4664 * xterm.c (x_check_font): Remove unused local.
4665 * scroll.c (CHECK_BOUNDS):
4666 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4667 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4668 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4669 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4670 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4671 Now static.
4672 (debug_method_add): Use va_list and vsprintf rather than relying
4673 on undefined behavior with wrong number of arguments.
4674 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4675 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4676 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4677 since we're not interested in debugging glyphs with old libraries.
4678 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4679 GCC 4.6.0's static checking.
4680
4681 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4682
4683 Integer overflow and signedness fixes (Bug#8873).
4684 A few related buffer overrun fixes, too.
4685
4686 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4687
4688 * dispextern.h (struct face.stipple):
4689 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4690 (x_bitmap_mask, x_allocate_bitmap_record)
4691 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4692 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4693 (x_create_bitmap_from_xpm_data):
4694 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4695 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4696 (.bitmaps_last):
4697 * xfaces.c (load_pixmap):
4698 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4699 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4700 (.bitmaps_last, struct x_output.icon_bitmap):
4701 Use ptrdiff_t, not int, for bitmap indexes.
4702 (x_allocate_bitmap_record): Check for size overflow.
4703 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4704
4705 Use ptrdiff_t, not int, for overlay counts.
4706 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4707 * editfns.c (overlays_around, get_pos_property):
4708 * textprop.c (get_char_property_and_overlay):
4709 * xdisp.c (next_overlay_change, note_mouse_highlight):
4710 * xfaces.c (face_at_buffer_position):
4711 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4712 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4713 (Fnext_overlay_change, Fprevious_overlay_change)
4714 (mouse_face_overlay_overlaps, Foverlays_in):
4715 Use ptrdiff_t, not int, for sizes.
4716 (overlays_at, overlays_in): Check for size-calculation overflow.
4717
4718 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4719
4720 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4721 (x_session_initialize): Do not assume string length fits in int.
4722
4723 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4724 This is unlikely, but can occur if DPI is outlandish.
4725
4726 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4727 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4728
4729 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4730 * xrdb.c (magic_file_p, search_magic_path):
4731 Omit last arg SUFFIX; it was always 0. All callers changed.
4732 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4733
4734 * xfont.c (xfont_match): Avoid need for strlen.
4735
4736 * xfns.c: Don't assume strlen fits in int.
4737 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4738
4739 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4740 not unsigned long, as we prefer signed integers. All callers changed.
4741 Detect integer overflow in repeat count.
4742 (message_dolog): Don't assume print length fits in 39 bytes.
4743 (display_mode_element): Don't assume strlen fits in int.
4744
4745 * termcap.c: Don't assume sizes fit in int and never overflow.
4746 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4747 (gobble_line): Check for size-calculation overflow.
4748
4749 * minibuf.c (Fread_buffer):
4750 * lread.c (intern, intern_c_string):
4751 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4752 Don't assume string length fits in int.
4753
4754 * keyboard.c (parse_tool_bar_item):
4755 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4756
4757 * font.c: Don't assume string length fits in int.
4758 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4759 Use ptrdiff_t, not int.
4760 (font_intern_prop): Don't assume string length fits in int.
4761 Don't assume integer property fits in fixnum.
4762 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4763
4764 * filelock.c: Fix some buffer overrun and integer overflow issues.
4765 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4766 Reformulate so as not to need the command string.
4767 Invoke gzip -cd rather than gunzip, as it's more portable.
4768 (lock_info_type, lock_file_1, lock_file):
4769 Don't assume pid_t and time_t fit in unsigned long.
4770 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4771 (current_lock_owner): Prefer signed type for sizes.
4772 Use memcpy, not strncpy, where memcpy is what is really wanted.
4773 Don't assume (via atoi) that time_t and pid_t fit in int.
4774 Check for time_t and/or pid_t out of range, e.g., via a network share.
4775 Don't alloca where an auto var works fine.
4776
4777 * fileio.c: Fix some integer overflow issues.
4778 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4779 Don't assume string length fits in int.
4780 (directory_file_name): Don't assume string length fits in long.
4781 (make_temp_name): Don't assume pid fits in int, or that its print
4782 length is less than 20.
4783
4784 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4785
4786 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4787
4788 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4789
4790 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4791 We prefer signed integers, even for size calculations.
4792
4793 * emacs.c: Don't assume string length fits in 'int'.
4794 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4795 (main): Don't invoke strlen when not needed.
4796
4797 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4798 (XD_DEBUG_MESSAGE): Don't waste a byte.
4799
4800 * callproc.c (getenv_internal_1, getenv_internal)
4801 (Fgetenv_internal):
4802 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4803
4804 * lread.c (invalid_syntax): Omit length argument.
4805 All uses changed. This doesn't fix a bug, but it simplifies the
4806 code away from its former Hollerith-constant appearance, and it's
4807 one less 'int' to worry about when looking at integer-overflow issues.
4808 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4809
4810 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4811 This didn't break anything, but it didn't help either.
4812 It's confusing to put a bogus integer in a place where the actual
4813 value does not matter.
4814 (LIST_END_P): Remove unused macro and its bogus comment.
4815 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4816
4817 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4818 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4819 implementation.
4820 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4821 We prefer signed types, and the value cannot exceed the EMACS_INT
4822 range anyway (because otherwise the length would not be representable).
4823 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4824 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4825 This avoids a GCC warning when WIDE_EMACS_INT.
4826
4827 * indent.c (sane_tab_width): New function.
4828 (current_column, scan_for_column, Findent_to, position_indentation)
4829 (compute_motion): Use it. This is just for clarity.
4830 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4831
4832 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4833
4834 * lisp.h (lint_assume): New macro.
4835 * composite.c (composition_gstring_put_cache):
4836 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4837
4838 * editfns.c, insdel.c:
4839 Omit unnecessary forward decls, to simplify future changes.
4840
4841 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4842
4843 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4844
4845 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4846 Use much-faster test for byte-length change.
4847 Don't assume string byte-length fits in 'int'.
4848 Check that character arg fits in 'int'.
4849 (mapcar1): Declare byte as byte, for clarity.
4850
4851 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4852
4853 * fns.c (concat): Catch string overflow earlier.
4854 Do not rely on integer wraparound.
4855
4856 * dispextern.h (struct it.overlay_strings_charpos)
4857 (struct it.selective): Now EMACS_INT, not int.
4858 * xdisp.c (forward_to_next_line_start)
4859 (back_to_previous_visible_line_start)
4860 (reseat_at_next_visible_line_start, next_element_from_buffer):
4861 Don't arbitrarily truncate the value of 'selective' to int.
4862
4863 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4864
4865 * composite.c: Don't truncate sizes to 'int'.
4866 (composition_gstring_p, composition_reseat_it)
4867 (composition_adjust_point): Use EMACS_INT, not int.
4868 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4869 not EMACS_UINT, for indexes.
4870
4871 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4872
4873 * buffer.c: Include <verify.h>.
4874 (struct sortvec.priority, struct sortstr.priority):
4875 Now EMACS_INT, not int.
4876 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4877 (struct sortstr.size, record_overlay_string)
4878 (struct sortstrlist.size, struct sortlist.used):
4879 Don't truncate size to int.
4880 (record_overlay_string): Check for size-calculation overflow.
4881 (init_buffer_once): Check at compile-time, not run-time.
4882
4883 2011-06-22 Jim Meyering <meyering@redhat.com>
4884
4885 Don't leak an XBM-image-sized buffer
4886 * image.c (xbm_load): Free the image buffer after using it.
4887
4888 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4889
4890 Port to Sun C.
4891 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4892 that Sun C diagnosed.
4893 * fns.c (secure_hash): Fix pointer signedness issue.
4894 * intervals.c (static_offset_intervals): New function.
4895 (offset_intervals): Use it.
4896
4897 2011-06-21 Leo Liu <sdl.web@gmail.com>
4898
4899 * deps.mk (fns.o):
4900 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4901 sha512.h.
4902
4903 * fns.c (secure_hash): Rename from crypto_hash_function and change
4904 the first arg to accept symbols.
4905 (Fsecure_hash): New primitive.
4906 (syms_of_fns): New symbols.
4907
4908 2011-06-20 Deniz Dogan <deniz@dogan.se>
4909
4910 * process.c (Fset_process_buffer): Clarify return value in
4911 docstring.
4912
4913 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4914
4915 * dispnew.c (add_window_display_history): Use BVAR.
4916
4917 * xdisp.c (debug_method_add): Use BVAR.
4918 (check_window_end, dump_glyph_matrix, dump_glyph)
4919 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4920
4921 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4922 Likewise.
4923
4924 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4925 check till after the cache is created in init_frame_faces.
4926
4927 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4928
4929 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4930
4931 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4934 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4935 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4936
4937 Improve buffer-overflow checking (Bug#8873).
4938 * fileio.c (Finsert_file_contents):
4939 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4940 Remove the old (too-loose) buffer overflow checks.
4941 They weren't needed, since make_gap checks for buffer overflow.
4942 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4943 The old code merely checked for Emacs fixnum overflow, and relied
4944 on undefined (wraparound) behavior. The new code avoids undefined
4945 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4946
4947 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4948 Tune. Don't use wider integers than needed. Don't use alloca.
4949 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4950
4951 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4952
4953 * insdel.c, lisp.h (buffer_overflow): New function.
4954 (insert_from_buffer_1, replace_range, replace_range_2):
4955 * insdel.c (make_gap_larger):
4956 * editfns.c (Finsert_char):
4957 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4958
4959 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4960
4961 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4962
4963 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4964
4965 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4966 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4967
4968 * fileio.c: Don't assume EMACS_INT fits in off_t.
4969 (emacs_lseek): New static function.
4970 (Finsert_file_contents, Fwrite_region): Use it.
4971 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4972
4973 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4974
4975 * fns.c: Don't overflow int when computing a list length.
4976 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4977 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4978 truncation on 64-bit hosts. Check for QUIT every
4979 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4980 faster and is responsive enough.
4981 (Flength): Report an error instead of overflowing an integer.
4982 (Fsafe_length): Return a float if the value is not representable
4983 as a fixnum. This shouldn't happen except in contrived situations.
4984 (Fnthcdr, Fsort): Don't assume list length fits in int.
4985 (Fcopy_sequence): Don't assume vector length fits in int.
4986
4987 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4988 (header_size, word_size): New constants.
4989 (allocate_vectorlike): Don't check size overflow here.
4990 (allocate_vector): Check it here instead, since this is the only
4991 caller of allocate_vectorlike that could cause overflow.
4992 Check that the new vector's length is representable as a fixnum.
4993
4994 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4995 The previous code was bogus. For example, next_almost_prime (32)
4996 returned 39, which is undesirable as it is a multiple of 3; and
4997 next_almost_prime (24) returned 25, which is a multiple of 5 so
4998 why was the code bothering to check for multiples of 7?
4999
5000 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5001
5002 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5003
5004 Variadic C functions now count arguments with ptrdiff_t.
5005 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5006 Back then I didn't know that the Emacs coding style prefers signed int.
5007 Also, in the meantime I found a few more instances where arguments
5008 were being counted with int, which may truncate counts on 64-bit
5009 machines, or EMACS_INT, which may be unnecessarily wide.
5010 * lisp.h (struct Lisp_Subr.function.aMANY)
5011 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5012 Arg counts are now ptrdiff_t, not size_t.
5013 All variadic functions and their callers changed accordingly.
5014 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5015 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5016 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5017 * callint.c (Fcall_interactively): Check arg count for overflow,
5018 to avoid potential buffer overrun. Use signed char, not 'int',
5019 for 'varies' array, so that we needn't bother to check its size
5020 calculation for overflow.
5021 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5022 * eval.c (apply_lambda):
5023 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5024 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5025 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5026
5027 * callint.c (Fcall_interactively): Don't use index var as event count.
5028
5029 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5030 * mem-limits.h (SIZE): Remove; no longer used.
5031
5032 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5033
5034 Remove unnecessary casts.
5035 * xterm.c (x_term_init):
5036 * xfns.c (x_set_border_pixel):
5037 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5038 These aren't needed now that we assume ANSI C.
5039
5040 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5041 It's more likely to cause problems (due to unsigned overflow)
5042 than to cure them.
5043
5044 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5045
5046 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5047
5048 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5049
5050 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5051
5052 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5053
5054 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5055
5056 GLYPH_CODE_FACE returns EMACS_INT, not int.
5057 * dispextern.h (merge_faces):
5058 * xfaces.c (merge_faces):
5059 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5060 Don't assume EMACS_INT fits in int.
5061
5062 * character.h (CHAR_VALID_P): Remove unused parameter.
5063 * fontset.c, lisp.h, xdisp.c: All uses changed.
5064
5065 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5066
5067 * fns.c (concat): Minor tuning based on overflow analysis.
5068 This doesn't fix any bugs. Use int to hold character, instead
5069 of constantly refetching from Emacs object. Use XFASTINT, not
5070 XINT, for value known to be a character. Don't bother comparing
5071 a single byte to 0400, as it's always less.
5072
5073 * floatfns.c (Fexpt):
5074 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5075
5076 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5077 for characters.
5078
5079 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5080
5081 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5082 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5083 incorrectly succeed when S was a string, because 4294967386 was
5084 truncated before it was used.
5085
5086 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5087 Otherwise, an out-of-range integer could cause undefined behavior
5088 on a 64-bit host.
5089
5090 * composite.c: Use int, not EMACS_INT, for characters.
5091 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5092 EMACS_INT, for values that are known to be in character range.
5093 This doesn't fix any bugs but is the usual style inside Emacs and
5094 may generate better code on 32-bit machines.
5095
5096 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5097 This is for reasons similar to the recent CHAR_STRING fix.
5098 * charset.c (Fencode_char): Check that character arg is actually
5099 a character. Pass an int to ENCODE_CHAR.
5100 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5101 wider than 'int', as a compile-time check to prevent future regressions
5102 in this area.
5103
5104 * character.c (char_string): Remove unnecessary casts.
5105
5106 Make sure a 64-bit char is never passed to CHAR_STRING.
5107 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5108 by silently ignoring the top 32 bits, allowing some values
5109 that were far too large to be valid characters.
5110 * character.h: Include <verify.h>.
5111 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5112 arguments are no wider than unsigned, as a compile-time check
5113 to prevent future regressions in this area.
5114 * data.c (Faset):
5115 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5116 (Fsubst_char_in_region):
5117 * fns.c (concat):
5118 * xdisp.c (decode_mode_spec_coding):
5119 Adjust to CHAR_STRING's new requirement.
5120 * editfns.c (Finsert_char, Fsubst_char_in_region):
5121 * fns.c (concat): Check that character args are actually
5122 characters. Without this test, these functions did the wrong
5123 thing with wildly out-of-range values on 64-bit hosts.
5124
5125 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5126 These casts should not be needed on 32-bit hosts, either.
5127 * keyboard.c (read_char):
5128 * lread.c (Fload): Remove casts to unsigned.
5129
5130 * lisp.h (UNSIGNED_CMP): New macro.
5131 This fixes comparison bugs on 64-bit hosts.
5132 (ASCII_CHAR_P): Use it.
5133 * casefiddle.c (casify_object):
5134 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5135 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5136 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5137 * dispextern.h (FACE_FROM_ID):
5138 * keyboard.c (read_char): Use UNSIGNED_CMP.
5139
5140 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5141 not to EMACS_INT, to avoid GCC warning.
5142
5143 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5144
5145 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5146 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5147 isn't needed on 32-bit machines.
5148
5149 * buffer.c (Fgenerate_new_buffer_name):
5150 Use EMACS_INT for count, not int.
5151 (advance_to_char_boundary): Return EMACS_INT, not int.
5152
5153 * data.c (Qcompiled_function): Now static.
5154
5155 * window.c (window_body_lines): Now static.
5156
5157 * image.c (gif_load): Rename local to avoid shadowing.
5158
5159 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5160 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5161 * alloc.c (make_save_value): Integer argument is now of type
5162 ptrdiff_t, not int.
5163 (mark_object): Use ptrdiff_t, not int.
5164 * lisp.h (pD): New macro.
5165 * print.c (print_object): Use it.
5166
5167 * alloc.c: Use EMACS_INT, not int, to count objects.
5168 (total_conses, total_markers, total_symbols, total_vector_size)
5169 (total_free_conses, total_free_markers, total_free_symbols)
5170 (total_free_floats, total_floats, total_free_intervals)
5171 (total_intervals, total_strings, total_free_strings):
5172 Now EMACS_INT, not int. All uses changed.
5173 (Fgarbage_collect): Compute overall total using a double, so that
5174 integer overflow is less likely to be a problem. Check for overflow
5175 when converting back to an integer.
5176 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5177 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5178 These were 'int' variables that could overflow on 64-bit hosts;
5179 they were never used, so remove them instead of repairing them.
5180 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5181 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5182 Previously, this ceilinged at INT_MAX, but that doesn't work on
5183 64-bit machines.
5184 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5185
5186 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5187 (allocate_vectorlike): Check for ptrdiff_t overflow.
5188 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5189 when a (possibly-narrower) signed value would do just as well.
5190 We prefer using signed arithmetic, to avoid comparison confusion.
5191
5192 * alloc.c: Catch some string size overflows that we were missing.
5193 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5194 for convenience in STRING_BYTES_MAX.
5195 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5196 The definition here is exact; the one in lisp.h was approximate.
5197 (allocate_string_data): Check for string overflow. This catches
5198 some instances we weren't catching before. Also, it catches
5199 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5200 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5201 and ptrdiff_t and EMACS_INT are both 64 bits.
5202
5203 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5204 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5205 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5206
5207 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5208
5209 * alloc.c (Fmake_string): Check for out-of-range init.
5210
5211 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5212
5213 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5214
5215 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5216
5217 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5218 xg_get_default_scrollbar_width.
5219
5220 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5221 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5222 (style_changed_cb): Call update_theme_scrollbar_width and call
5223 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5224 all frames (Bug#8505).
5225 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5226 Call gtk_window_set_resizable if HAVE_GTK3.
5227 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5228 and height if HAVE_GTK3 (Bug#8505).
5229 (scroll_bar_width_for_theme): New variable.
5230 (update_theme_scrollbar_width): New function.
5231 (xg_get_default_scrollbar_width): Move code to
5232 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5233 (xg_initialize): Call update_theme_scrollbar_width.
5234
5235 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5236
5237 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5238
5239 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5240
5241 * frame.c (make_frame): Call other_buffer_safely instead of
5242 other_buffer.
5243
5244 * window.c (temp_output_buffer_show): Call display_buffer with
5245 second argument Vtemp_buffer_show_specifiers and reset latter
5246 immediately after the call.
5247 (Vtemp_buffer_show_specifiers): New variable.
5248 (auto_window_vscroll_p, next_screen_context_lines)
5249 (Vscroll_preserve_screen_position): Remove leading asterisks from
5250 doc-strings.
5251
5252 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 Fix minor problems found by GCC 4.6.0 static checking.
5255 * buffer.c (Qclone_number): Remove for now, as it's unused.
5256 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5257 (record_buffer): Remove unused local.
5258 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5259 (set_frame_buffer_list): Remove; unused.
5260 * frame.h (other_visible_frames): Remove decl.
5261 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5262 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5263 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5264 if HAVE_GPM.
5265 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5266 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5267 Define only if HAVE_GPM.
5268 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5269 (update_hints_inhibit): Remove; never set. All uses removed.
5270 * widgetprv.h (emacsFrameClassRec): Remove decl.
5271 * window.c (delete_deletable_window): Now returns void, since it
5272 wasn't returning anything.
5273 (compare_window_configurations): Remove unused locals.
5274 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5275 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5276 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5277 the same widths as pointers. This follows up on the 2011-05-06 patch.
5278 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5279 * xterm.h: Likewise.
5280 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5281
5282 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5283
5284 * makefile.w32-in: Update dependencies.
5285 (LISP_H): Add lib/intprops.h.
5286
5287 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5288
5289 * image.c (gif_load): Add animation frame delay to the metadata.
5290 (syms_of_image): Use DEFSYM. New symbol `delay'.
5291
5292 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5293
5294 * window.c (delete_deletable_window): Re-add.
5295 (Fset_window_configuration): Rewrite to handle dead buffers and
5296 consequently deletable windows.
5297 (window_tree, Fwindow_tree): Remove. Supply functionality in
5298 window.el.
5299 (compare_window_configurations): Simplify code.
5300
5301 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5302
5303 * image.c (imagemagick_load_image): Fix type mismatch.
5304 (Fimagemagick_types): Likewise.
5305
5306 * window.h (replace_buffer_in_windows): Declare.
5307
5308 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5309
5310 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5311 Qclone_number. Remove external declaration of Qdelete_window.
5312 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5313 code.
5314 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5315 Run Qbuffer_list_update_hook if allowed.
5316 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5317 buffer list implementation.
5318 (other_buffer_safely): New function.
5319 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5320 calls to replace_buffer_in_windows and
5321 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5322 if allowed.
5323 (record_buffer): Inhibit quitting and rewrite using quittable
5324 functions. Run Qbuffer_list_update_hook if allowed.
5325 (Frecord_buffer, Funrecord_buffer): New functions.
5326 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5327 Move switch-to-buffer to window.el.
5328 (bury-buffer): Move to window.el.
5329 (Vbuffer_list_update_hook): New variable.
5330
5331 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5332 section.
5333
5334 * window.h (resize_frame_windows): Move up in code.
5335 (Fwindow_frame): Remove EXFUN.
5336 (replace_buffer_in_all_windows): Remove prototype.
5337 (replace_buffer_in_windows_safely): Add prototype.
5338
5339 * window.c: Declare Qdelete_window static again. Move down
5340 declaration of select_count.
5341 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5342 (Fother_window): Move to window.el.
5343 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5344 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5345 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5346 window.el.
5347 (replace_buffer_in_windows): Implement by calling
5348 Qreplace_buffer_in_windows.
5349 (replace_buffer_in_all_windows): Remove with some functionality
5350 moved into replace_buffer_in_windows_safely.
5351 (replace_buffer_in_windows_safely): New function.
5352 (select_window_norecord, select_frame_norecord): Move in front
5353 of run_window_configuration_change_hook. Remove now obsolete
5354 declarations.
5355 (Fset_window_buffer): Rewrite doc-string.
5356 Call Qrecord_window_buffer.
5357 (keys_of_window): Move binding for other-window to window.el.
5358
5359 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5360
5361 * dispextern.h (struct image): Replace data member, whose int_val
5362 and ptr_val fields were not used by anything, with a single
5363 lisp_val object.
5364
5365 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5366 (gif_clear_image, gif_load, imagemagick_load_image)
5367 (gs_clear_image, gs_load): Callers changed.
5368
5369 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5370
5371 * buffer.h: Include <time.h>, for time_t.
5372 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5373
5374 Fix minor problems found by static checking.
5375
5376 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5377
5378 Make identifiers static if they are not used in other modules.
5379 * data.c (Qcompiled_function, Qframe, Qvector):
5380 * image.c (QimageMagick, Qsvg):
5381 * minibuf.c (Qmetadata):
5382 * window.c (resize_window_check, resize_root_window): Now static.
5383 * window.h (resize_window_check, resize_root_window): Remove decls.
5384
5385 * window.c (window_deletion_count, delete_deletable_window):
5386 Remove; unused.
5387 (window_body_lines): Now static.
5388 (Fdelete_other_windows_internal): Mark vars as initialized.
5389 Make sure 'resize_failed' is initialized.
5390 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5391 (resize_window_apply): Remove unused local.
5392 * window.h (delete_deletable_window): Remove decl.
5393
5394 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5395 (imagemagick_load_image): Fix pointer signedness problem by changing
5396 last arg from unsigned char * to char *. All uses changed.
5397 Also, fix a local for similar reasons.
5398 Remove unused locals. Remove locals to avoid shadowing.
5399 (fn_rsvg_handle_free): Remove; unused.
5400 (svg_load, svg_load_image): Fix pointer signedness problem.
5401 (imagemagick_load_image): Don't use garbage pointer image_wand.
5402
5403 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5404
5405 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5406
5407 * image.c (gif_load): Fix omitted cast error introduced by
5408 2011-06-06 change.
5409
5410 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5411
5412 * window.h (resize_proportionally, orig_total_lines)
5413 (orig_top_line): Remove from window structure.
5414 (set_window_height, set_window_width, change_window_heights)
5415 (Fdelete_window): Remove prototypes.
5416 (resize_frame_windows): Remove duplicate declaration.
5417
5418 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5419
5420 * window.h (resize_frame_windows, resize_window_check)
5421 (delete_deletable_window, resize_root_window)
5422 (resize_frame_windows): Declare prototypes.
5423
5424 * window.c (resize_window_apply): Make definition be "static" to
5425 match the prototype.
5426
5427 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5428
5429 * window.c: Remove declarations of Qwindow_size_fixed,
5430 window_min_size_1, window_min_size_2, window_min_size,
5431 size_window, window_fixed_size_p, enlarge_window, delete_window.
5432 Remove static from declaration of Qdelete_window, it's
5433 temporarily needed by Fbury_buffer.
5434 (replace_window): Don't assign orig_top_line and
5435 orig_total_lines.
5436 (Fdelete_window, delete_window): Remove. Window deletion is
5437 handled by window.el.
5438 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5439 Replace Fdelete_window calls with calls to Qdelete_window.
5440 (Fdelete_other_windows): Remove. Deleting other windows is
5441 handled by window.el.
5442 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5443 handled in window.el.
5444 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5445 Window minimum sizes are handled in window.el.
5446 (shrink_windows, size_window, set_window_height)
5447 (set_window_width, change_window_heights, window_height)
5448 (window_width, CURBEG, CURSIZE, enlarge_window)
5449 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5450 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5451 handled in window.el.
5452 (make_dummy_parent): Rename to make_parent_window and give it a
5453 second argument horflag.
5454 (make_window): Don't set resize_proportionally any more.
5455 (Fsplit_window): Remove. Windows are split in window.el.
5456 (save_restore_action, save_restore_orig_size)
5457 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5458 Resize mini windows in window.el.
5459 (grow_mini_window, shrink_mini_window): Implement by calling
5460 Qresize_root_window_vertically, resize_window_check and
5461 resize_window_apply.
5462 (saved_window, Fset_window_configuration, save_window_save):
5463 Do not handle orig_top_line, orig_total_lines, and
5464 resize_proportionally.
5465 (window_min_height, window_min_width): Move to window.el.
5466 (keys_of_window): Move bindings for delete-other-windows,
5467 split-window, delete-window and enlarge-window to window.el.
5468
5469 * buffer.c: Temporarily extern Qdelete_window.
5470 (Fbury_buffer): Temporarily call Qdelete_window instead of
5471 Fdelete_window (Fbury_buffer will move to window.el soon).
5472
5473 * frame.c (set_menu_bar_lines_1): Remove code handling
5474 orig_top_line and orig_total_lines.
5475
5476 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5477 set_window_height but set heights directly.
5478 (change_frame_size_1): Use resize_frame_windows.
5479
5480 * xdisp.c (init_xdisp): Don't use set_window_height but set
5481 heights directly.
5482
5483 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5484 Use resize_frame_windows instead of change_window_heights and run
5485 run_window_configuration_change_hook.
5486
5487 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5488 instead of change_window_heights and run
5489 run_window_configuration_change_hook.
5490
5491 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5492
5493 * window.c (replace_window): Rename second argument REPLACEMENT to
5494 NEW. New third argument SETFLAG. Rewrite.
5495 (delete_window, make_dummy_parent): Call replace_window with
5496 third argument 1.
5497 (window_list_1): Move down in code.
5498 (run_window_configuration_change_hook): Move set_buffer part
5499 before select_frame_norecord part in order to unwind correctly.
5500 Rename count1 to count.
5501 (recombine_windows, delete_deletable_window, resize_root_window)
5502 (Fdelete_other_windows_internal)
5503 (Frun_window_configuration_change_hook, make_parent_window)
5504 (resize_window_check, resize_window_apply, Fresize_window_apply)
5505 (resize_frame_windows, Fsplit_window_internal)
5506 (Fdelete_window_internal, Fresize_mini_window_internal):
5507 New functions.
5508 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5509
5510 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5511
5512 * window.h (window): Add some new members to window structure -
5513 normal_lines, normal_cols, new_total, new_normal, clone_number,
5514 splits, nest, prev_buffers, next_buffers.
5515 (WINDOW_TOTAL_SIZE): Move here from window.c.
5516 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5517
5518 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5519 Remove.
5520 (make_dummy_parent): Set new members of windows structure.
5521 (make_window): Move down in code. Handle new members of window
5522 structure.
5523 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5524 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5525 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5526 (Fset_window_prev_buffers, Fwindow_next_buffers)
5527 (Fset_window_next_buffers, Fset_window_clone_number):
5528 New functions.
5529 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5530 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5531 Doc-string fixes.
5532 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5533 Argument WINDOW can be now internal window too.
5534 (Fwindow_use_time): Move up in code.
5535 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5536 Rewrite doc-string.
5537 (Fset_window_configuration, saved_window)
5538 (Fcurrent_window_configuration, save_window_save): Handle new
5539 members of window structure.
5540 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5541 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5542 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5543 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5544 Qget_mru_window, Qresize_root_window,
5545 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5546 Qauto_buffer_name; staticpro them.
5547
5548 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5549
5550 * window.c (Fwindow_total_size, Fwindow_left_column)
5551 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5552 (Fwindow_list_1): New functions.
5553 (window_box_text_cols): Replace with window_body_cols.
5554 (Fwindow_width, Fscroll_left, Fscroll_right):
5555 Use window_body_cols instead of window_box_text_cols.
5556 (delete_window, Fset_window_configuration):
5557 Call delete_all_subwindows with window as argument.
5558 (delete_all_subwindows): Take a window as argument and not a
5559 structure. Rewrite.
5560 (window_loop): Remove handling of GET_LRU_WINDOW and
5561 GET_LARGEST_WINDOW.
5562 (Fget_lru_window, Fget_largest_window): Move to window.el.
5563
5564 * window.h: Extern window_body_cols instead of
5565 window_box_text_cols. delete_all_subwindows now takes a
5566 Lisp_Object as argument.
5567
5568 * indent.c (compute_motion, Fcompute_motion):
5569 Use window_body_cols instead of window_box_text_cols.
5570
5571 * frame.c (delete_frame): Call delete_all_subwindows with root
5572 window as argument.
5573
5574 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5575
5576 * fns.c (Fputhash): Document return value.
5577
5578 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5579
5580 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5581
5582 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5583
5584 Cons<->int and similar integer overflow fixes (Bug#8794).
5585
5586 Check for overflow when converting integer to cons and back.
5587 * charset.c (Fdefine_charset_internal, Fdecode_char):
5588 Use cons_to_unsigned to catch overflow.
5589 (Fencode_char): Use INTEGER_TO_CONS.
5590 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5591 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5592 * data.c (long_to_cons, cons_to_long): Remove.
5593 (cons_to_unsigned, cons_to_signed): New functions.
5594 These signal an error for invalid or out-of-range values.
5595 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5596 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5597 * font.c (Ffont_variation_glyphs):
5598 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5599 * lisp.h: Include <intprops.h>.
5600 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5601 (cons_to_signed, cons_to_unsigned): New decls.
5602 (long_to_cons, cons_to_long): Remove decls.
5603 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5604 (Fprimitive_undo): Use CONS_TO_INTEGER.
5605 * xfns.c (Fx_window_property): Likewise.
5606 * xselect.c: Include <limits.h>.
5607 (x_own_selection, selection_data_to_lisp_data):
5608 Use INTEGER_TO_CONS.
5609 (x_handle_selection_request, x_handle_selection_clear)
5610 (x_get_foreign_selection, Fx_disown_selection_internal)
5611 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5612 (lisp_data_to_selection_data): Use cons_to_unsigned.
5613 (x_fill_property_data): Use cons_to_signed.
5614 Report values out of range.
5615
5616 Check for buffer and string overflow more precisely.
5617 * buffer.h (BUF_BYTES_MAX): New macro.
5618 * lisp.h (STRING_BYTES_MAX): New macro.
5619 * alloc.c (Fmake_string):
5620 * character.c (string_escape_byte8):
5621 * coding.c (coding_alloc_by_realloc):
5622 * doprnt.c (doprnt):
5623 * editfns.c (Fformat):
5624 * eval.c (verror):
5625 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5626 since they may not be the same number.
5627 * editfns.c (Finsert_char):
5628 * fileio.c (Finsert_file_contents):
5629 Likewise for BUF_BYTES_MAX.
5630
5631 * image.c: Use ptrdiff_t, not int, for sizes.
5632 (slurp_file): Switch from int to ptrdiff_t.
5633 All uses changed.
5634 (slurp_file): Check that file size fits in both size_t (for
5635 malloc) and ptrdiff_t (for sanity and safety).
5636
5637 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5638 if b->modtime has its maximal value.
5639
5640 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5641
5642 Don't assume time_t can fit into int.
5643 * buffer.h (struct buffer.modtime): Now time_t, not int.
5644 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5645 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5646
5647 Minor fixes for signed vs unsigned integers.
5648 * character.h (MAYBE_UNIFY_CHAR):
5649 * charset.c (maybe_unify_char):
5650 * keyboard.c (read_char, reorder_modifiers):
5651 XINT -> XFASTINT, since the integer must be nonnegative.
5652 * ftfont.c (ftfont_spec_pattern):
5653 * keymap.c (access_keymap, silly_event_symbol_error):
5654 XUINT -> XFASTINT, since the integer must be nonnegative.
5655 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5656 since it makes no difference and we prefer signed.
5657 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5658 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5659 nonnegative.
5660
5661 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5662
5663 * window.h (Fwindow_frame): Declare.
5664
5665 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5668 (SPARE_MEMORY): Always define.
5669 (LARGE_REQUEST): Remove.
5670 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5671
5672 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5673
5674 * lisp.h: Move EXFUNS for Fframe_root_window,
5675 Fframe_first_window and Fset_frame_selected_window to window.h.
5676
5677 * window.h: Move EXFUNS for Fframe_root_window,
5678 Fframe_first_window and Fset_frame_selected_window here from
5679 lisp.h.
5680
5681 * frame.c (Fwindow_frame, Fframe_first_window)
5682 (Fframe_root_window, Fframe_selected_window)
5683 (Fset_frame_selected_window): Move to window.c.
5684 (Factive_minibuffer_window): Move to minibuf.c.
5685 (Fother_visible_frames_p): New function.
5686
5687 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5688
5689 * window.c (decode_window, decode_any_window): Move up in code.
5690 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5691 (inhibit_frame_unsplittable): Remove unused variable.
5692 (Fwindow_buffer): Move up and rewrite doc-string.
5693 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5694 (Fwindow_prev): New functions.
5695 (Fwindow_frame): Move here from frame.c. Accept any window as
5696 argument.
5697 (Fframe_root_window, Fframe_first_window)
5698 (Fframe_selected_window): Move here from frame.c. Accept frame
5699 or arbitrary window as argument. Update doc-strings.
5700 (Fminibuffer_window): Move up in code.
5701 (Fwindow_minibuffer_p): Move up in code and simplify.
5702 (Fset_frame_selected_window): Move here from frame.c.
5703 Marginal rewrite.
5704 (Fselected_window, select_window, Fselect_window): Move up in
5705 code. Minor doc-string fixes.
5706
5707 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5708
5709 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5710 Do not assume that spare memory exists; that assumption is valid
5711 only if SYSTEM_MALLOC.
5712 (LARGE_REQUEST): New macro, so that the issue of large requests
5713 is separated from the issue of spare memory.
5714
5715 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5716
5717 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5718 format. (Bug#8806)
5719
5720 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5721
5722 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5723 before statements.
5724
5725 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5726
5727 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5728
5729 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5730
5731 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5732 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5733
5734 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5735
5736 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5737
5738 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5739
5740 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5741 (x_clipboard_manager_save): Add return value.
5742 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5743 New error handlers.
5744 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5745 Obey Vx_select_enable_clipboard_manager. Catch errors in
5746 x_clipboard_manager_save (Bug#8779).
5747 (Vx_select_enable_clipboard_manager): New variable.
5748 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5749
5750 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5751
5752 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5753
5754 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5755
5756 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5757 in the current matrix if keep_current_p is non-zero.
5758
5759 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5760
5761 * bidi.c (bidi_level_of_next_char): Fix last change.
5762
5763 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5764
5765 Support bidi reordering of text covered by display properties.
5766
5767 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5768 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5769 (bidi_cache_search, bidi_cache_iterator_state)
5770 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5771 (bidi_level_of_next_char, bidi_move_to_visually_next):
5772 Support character positions inside a run of characters covered by a
5773 display string.
5774 (bidi_paragraph_init, bidi_resolve_explicit_1)
5775 (bidi_level_of_next_char): Call bidi_fetch_char and
5776 bidi_fetch_char_advance instead of FETCH_CHAR and
5777 FETCH_CHAR_ADVANCE.
5778 (bidi_init_it): Initialize new members.
5779 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5780 definitions.
5781 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5782 instead of using explicit *_CHAR codes.
5783 (bidi_resolve_explicit, bidi_resolve_weak):
5784 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5785 bidirectional text is supported only in multibyte buffers.
5786 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5787 it to initialize the frame_window_p member of struct bidi_it.
5788 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5789 (bidi_resolve_explicit, bidi_resolve_weak)
5790 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5791 bidi_it->nchars is non-positive.
5792 (bidi_level_of_next_char): Don't try to lookup the cache for the
5793 next/previous character if nothing is cached there yet, or if we
5794 were just reseat()'ed to a new position.
5795
5796 * xdisp.c (set_cursor_from_row): Set start and stop points
5797 according to the row's direction when priming the loop that looks
5798 for the glyph on which to display cursor.
5799 (single_display_spec_intangible_p): Function deleted.
5800 (display_prop_intangible_p): Reimplement to call
5801 handle_display_spec instead of single_display_spec_intangible_p.
5802 Accept 3 additional arguments needed by handle_display_spec.
5803 This fixes incorrect cursor motion across display property with complex
5804 values: lists, `(when COND...)' forms, etc.
5805 (single_display_spec_string_p): Support property values that are
5806 lists with the argument STRING its top-level element.
5807 (display_prop_string_p): Fix the condition for processing a
5808 property that is a list to be consistent with handle_display_spec.
5809 (handle_display_spec): New function, refactored from the
5810 last portion of handle_display_prop.
5811 (compute_display_string_pos): Accept additional argument
5812 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5813 value of a `display' property is a "replacing spec".
5814 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5815 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5816 the display property, but just return a value indicating whether
5817 the display property will replace the characters it covers.
5818 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5819 frame_window_p members of struct bidi_it.
5820 (compute_display_string_pos, compute_display_string_end):
5821 New functions.
5822 (push_it): Accept second argument POSITION, where pop_it should
5823 jump to continue iteration.
5824 (reseat_1): Initialize bidi_it.disp_pos.
5825
5826 * keyboard.c (adjust_point_for_property): Adjust the call to
5827 display_prop_intangible_p to its new signature.
5828
5829 * dispextern.h (struct bidi_it): New member frame_window_p.
5830 (bidi_init_it): Update prototypes.
5831 (display_prop_intangible_p): Update prototype.
5832 (compute_display_string_pos, compute_display_string_end):
5833 Declare prototypes.
5834 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5835 EMACS_INT.
5836
5837 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5838
5839 Malloc failure behavior now depends on size of allocation.
5840 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5841 * lisp.h: Change signatures accordingly.
5842 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5843 All callers changed. (Bug#8762)
5844
5845 * gnutls.c: Use Emacs's memory allocators.
5846 Without this change, the gnutls library would invoke malloc etc.
5847 directly, which causes problems on non-SYNC_INPUT hosts, and which
5848 runs afoul of improving memory_full behavior. (Bug#8761)
5849 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5850 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5851 xfree instead of the default malloc, realloc, free.
5852 (Fgnutls_boot): No need to check for memory allocation failure,
5853 since xmalloc does that for us.
5854
5855 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5856 * category.c (hash_get_category_set):
5857 * ccl.c (ccl_driver):
5858 * charset.c (Fdefine_charset_internal):
5859 * charset.h (struct charset.hash_index):
5860 * composite.c (get_composition_id, gstring_lookup_cache)
5861 (composition_gstring_put_cache):
5862 * composite.h (struct composition.hash_index):
5863 * dispextern.h (struct image.hash):
5864 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5865 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5866 (hashfn_equal, hashfn_user_defined, make_hash_table)
5867 (maybe_resize_hash_table, hash_lookup, hash_put)
5868 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5869 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5870 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5871 * image.c (make_image, search_image_cache, lookup_image)
5872 (xpm_put_color_table_h):
5873 * lisp.h (struct Lisp_Hash_Table):
5874 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5875 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5876 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5877 * alloc.c (allocate_vectorlike):
5878 Check for overflow in vector size calculations.
5879 * ccl.c (ccl_driver):
5880 Check for overflow when converting EMACS_INT to int.
5881 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5882 need to be updated by these changes.
5883 * fns.c (make_hash_table, maybe_resize_hash_table):
5884 Check for integer overflow with large hash tables.
5885 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5886 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5887 (SXHASH_REDUCE): New macro.
5888 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5889 Use it instead of discarding useful hash info with large hash values.
5890 (sxhash_float): New function.
5891 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5892 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5893 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5894 Rewrite to use FIXNUM_BITS, as this simplifies things.
5895 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5896 Adjust signatures to match updated version of code.
5897 (consing_since_gc): Now EMACS_INT, since a single hash table can
5898 use more than INT_MAX bytes.
5899
5900 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5901
5902 Make it possible to build with GCC-4.6+ -O2 -flto.
5903
5904 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5905
5906 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5907
5908 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5909 Call minibuffer-inactive-mode.
5910
5911 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5914 Update dependencies.
5915
5916 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5917
5918 * data.c (init_data): Remove code for UTS, this system is not
5919 supported anymore.
5920
5921 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5922
5923 Don't force ./temacs to start in terminal mode.
5924
5925 * frame.c (make_initial_frame): Initialize faces in all cases, not
5926 only when CANNOT_DUMP is defined.
5927 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5928
5929 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5930
5931 * dispnew.c (add_window_display_history): Use const for the string
5932 pointer. Remove declaration, not needed.
5933
5934 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5935
5936 Use 'inline', not 'INLINE'.
5937 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5938 * alloc.c, fontset.c (INLINE): Remove.
5939 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5940 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5941 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5942 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5943 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5944
5945 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5946
5947 Make it possible to run ./temacs.
5948
5949 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5950 syms_of_callproc does the same thing. Remove test for
5951 "initialized", do it in the caller.
5952 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5953
5954 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5955
5956 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5957 (read_minibuf): Use get_minibuffer.
5958 (syms_of_minibuf): Use DEFSYM.
5959 (Qmetadata): New var.
5960 * data.c (Qbuffer): Don't make it static.
5961 (syms_of_data): Use DEFSYM.
5962
5963 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5964
5965 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5966 (CCL_CODE_MIN): New macro.
5967
5968 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5969
5970 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5971
5972 * eval.c (Qdebug): Now static.
5973 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5974 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5975 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5976
5977 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5978
5979 * image.c: Various fixes to ImageMagick code comments.
5980 (Fimagemagick_types): Doc fix.
5981
5982 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5983
5984 Minor fixes prompted by GCC 4.6.0 warnings.
5985
5986 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5987
5988 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5989 (x_clipboard_manager_save_all): Move extern decl to ...
5990 * xterm.h: ... here, so that it can be checked for consistency.
5991
5992 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5993
5994 * xselect.c (x_clipboard_manager_save_frame)
5995 (x_clipboard_manager_save_all): New functions.
5996 (Fx_clipboard_manager_save): Lisp function deleted.
5997
5998 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5999 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6000
6001 * xterm.h: Update prototype.
6002
6003 2011-05-28 William Xu <william.xwl@gmail.com>
6004
6005 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6006 exiting (Bug#8239).
6007
6008 2011-05-28 Jim Meyering <meyering@redhat.com>
6009
6010 Avoid a sign-extension bug in crypto_hash_function.
6011 * fns.c (to_uchar): Define.
6012 (crypto_hash_function): Use it to convert some newly-signed
6013 variables to unsigned, to avoid sign-extension bugs. For example,
6014 without this change, (md5 "truc") would evaluate to
6015 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6016 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6017 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6018
6019 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6020
6021 Integer overflow fixes.
6022
6023 * dbusbind.c: Serial number integer overflow fixes.
6024 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6025 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6026 to hold a serial number that is too large for a fixnum.
6027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6028 Check for serial numbers out of range. Decode any serial number
6029 that was so large that it became a float. (Bug#8722)
6030
6031 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6032 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6033 Use XFASTINT rather than XUINT when numbers are nonnegative.
6034 (xd_append_arg, Fdbus_method_return_internal):
6035 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6036 arguments, check that Lisp number is nonnegative, rather than
6037 silently wrapping negative numbers around. (Bug#8722)
6038 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6039 (Bug#8722)
6040
6041 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6042
6043 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6044
6045 ccl: Add integer overflow checks.
6046 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6047 (IN_INT_RANGE): New macros.
6048 (ccl_driver): Use them to check for integer overflow when
6049 decoding a CCL program. Many of the new checks are whether XINT (x)
6050 fits in int; it doesn't always, on 64-bit hosts. The new version
6051 doesn't catch all possible integer overflows, but it's an
6052 improvement. (Bug#8719)
6053
6054 * alloc.c (make_event_array): Use XINT, not XUINT.
6055 There's no need for unsigned here.
6056
6057 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6058 This follows up to the 2011-05-06 change that substituted uintptr_t
6059 for EMACS_INT. This case wasn't caught back then.
6060
6061 Rework Fformat to avoid integer overflow issues.
6062 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6063 now (part of C89). Include <verify.h>.
6064 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6065 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6066 (Fformat): Avoid the prepass trying to compute sizes; it was only
6067 approximate and thus did not catch overflow reliably. Instead, walk
6068 through the format just once, formatting and computing sizes as we go,
6069 checking for integer overflow at every step, and allocating a larger
6070 buffer as needed. Keep track separately whether the format is
6071 multibyte. Keep only the most-recently calculated precision, rather
6072 than them all. Record whether each argument has been converted to
6073 string. Use EMACS_INT, not int, for byte and char and arg counts.
6074 Support field widths and precisions larger than INT_MAX. Avoid
6075 sprintf's undefined behavior with conversion specifications such as %#d
6076 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6077 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6078 formatting out-of-range floating point numbers with int
6079 formats. (Bug#8668)
6080
6081 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6082
6083 * data.c: Avoid integer truncation in expressions involving floats.
6084 * data.c: Include <intprops.h>.
6085 (arith_driver): When there's an integer overflow in an expression
6086 involving floating point, convert the integers to floating point
6087 so that the resulting value does not suffer from catastrophic
6088 integer truncation. For example, on a 64-bit host (* 4
6089 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6090 Do not rely on undefined behavior after integer overflow.
6091
6092 merge count_size_as_multibyte, parse_str_to_multibyte
6093 * character.c, character.h (count_size_as_multibyte):
6094 Rename from parse_str_to_multibyte; all uses changed.
6095 Check for integer overflow.
6096 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6097 since it's now a duplicate of the other. This is more of
6098 a character than a buffer op, so better that it's in character.c.
6099 * fns.c, print.c: Adjust to above changes.
6100
6101 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6102
6103 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6104
6105 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6106
6107 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6108 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6109 (x_clipboard_manager_save): Now static.
6110 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6111
6112 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6113 (crypto_hash_function): Now static.
6114 Fix pointer signedness problems. Avoid unnecessary initializations.
6115
6116 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6117
6118 * termhooks.h (Vselection_alist): Make it terminal-local.
6119
6120 * terminal.c (create_terminal): Initialize it.
6121
6122 * xselect.c: Support for clipboard managers.
6123 (Vselection_alist): Move to termhooks.h as terminal-local var.
6124 (LOCAL_SELECTION): New macro.
6125 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6126 (symbol_to_x_atom): Remove gratuitous arg.
6127 (x_handle_selection_request, lisp_data_to_selection_data)
6128 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6129 (x_own_selection, x_get_local_selection, x_convert_selection):
6130 New arg, specifying work frame. Use terminal-local Vselection_alist.
6131 (some_frame_on_display): Delete unused function.
6132 (Fx_own_selection_internal, Fx_get_selection_internal)
6133 (Fx_disown_selection_internal, Fx_selection_owner_p)
6134 (Fx_selection_exists_p): New optional frame arg.
6135 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6136 (x_handle_selection_clear): Don't treat other terminals with the
6137 same keyboard specially. Use the terminal-local Vselection_alist.
6138 (x_clear_frame_selections): Use Frun_hook_with_args.
6139
6140 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6141
6142 * xterm.h: Add support for those atoms.
6143
6144 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6145
6146 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6147 (converted_selections, conversion_fail_tag): New global variables.
6148 (x_selection_request_lisp_error): Free the above.
6149 (x_get_local_selection): Remove unnecessary code.
6150 (x_reply_selection_request): Args changed; handle arbitrary array
6151 of converted selections stored in converted_selections.
6152 Separate the XChangeProperty and SelectionNotify steps.
6153 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6154 (x_convert_selection): New function.
6155 (x_handle_selection_event): Simplify.
6156 (x_get_foreign_selection): Don't ignore incoming requests while
6157 waiting for an answer; this will fail when we implement
6158 SAVE_TARGETS, and seems unnecessary anyway.
6159 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6160 (Vx_sent_selection_functions): Doc fix.
6161
6162 2011-05-26 Leo Liu <sdl.web@gmail.com>
6163
6164 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6165
6166 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6167
6168 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6169
6170 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6171 for fringe update if it has periodic bitmap.
6172 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6173 and fringe_bitmap_periodic_p.
6174
6175 * fringe.c (get_fringe_bitmap_data): New function.
6176 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6177 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6178 row. Mark glyph row for fringe update if periodicity changed.
6179
6180 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6181 for fringe update unless it has periodic bitmap.
6182
6183 2011-05-25 Kenichi Handa <handa@m17n.org>
6184
6185 * xdisp.c (get_next_display_element): Set correct it->face_id for
6186 a static composition.
6187
6188 2011-05-24 Leo Liu <sdl.web@gmail.com>
6189
6190 * deps.mk (fns.o):
6191 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6192
6193 * fns.c (crypto_hash_function, Fsha1): New function.
6194 (Fmd5): Use crypto_hash_function.
6195 (syms_of_fns): Add Ssha1.
6196
6197 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6198
6199 * gnutls.c: Remove unused macros.
6200 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6201 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6202 Remove macros that are defined and never used.
6203 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6204
6205 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6206
6207 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6208 (Fx_get_selection_internal): Minor cleanup.
6209 (Fx_own_selection_internal): Rename arguments for consistency with
6210 select.el.
6211
6212 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6213
6214 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6215
6216 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6217
6218 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6219
6220 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6221
6222 * dispnew.c (scrolling_window): Don't exclude the case that the
6223 last enabled row in the desired matrix touches the bottom boundary.
6224
6225 2011-05-21 Glenn Morris <rgm@gnu.org>
6226
6227 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6228 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6229 and add some more files.
6230
6231 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6232
6233 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6234 report_file_error introduced by the change from 2011-05-07.
6235
6236 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6237
6238 * systime.h (Time): Define only if emacs is defined.
6239 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6240 where the include path doesn't have X11/X.h by default. See
6241 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6242
6243 2011-05-20 Kenichi Handa <handa@m17n.org>
6244
6245 * composite.c (find_automatic_composition): Fix previous change.
6246
6247 2011-05-20 Glenn Morris <rgm@gnu.org>
6248
6249 * lisp.mk: New file, split from Makefile.in.
6250 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6251 (shortlisp): Remove.
6252 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6253
6254 2011-05-19 Glenn Morris <rgm@gnu.org>
6255
6256 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6257 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6258 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6259 (lisp): Set the order to that of loadup.el.
6260 (shortlisp): Make it a copy of $lisp.
6261 (SOME_MACHINE_LISP): Remove.
6262 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6263 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6264
6265 2011-05-18 Kenichi Handa <handa@m17n.org>
6266
6267 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6268 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6269 (find_automatic_composition): Mostly rewrite for efficiency.
6270
6271 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6272
6273 * makefile.w32-in: Update dependencies.
6274
6275 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6276
6277 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6278 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6279
6280 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6281
6282 Fix some integer overflow issues, such as string length overflow.
6283
6284 * insdel.c (count_size_as_multibyte): Check for string overflow.
6285
6286 * character.c (lisp_string_width): Check for string overflow.
6287 Use EMACS_INT, not int, for string indexes and lengths; in
6288 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6289 the resulting string length overflows an EMACS_INT; instead,
6290 report a string overflow if no precision given. When checking for
6291 precision exhaustion, use a check that cannot possibly have
6292 integer overflow. (Bug#8675)
6293 * character.h (lisp_string_width): Adjust to new signature.
6294
6295 * alloc.c (string_overflow): New function.
6296 (Fmake_string): Use it. This doesn't change behavior, but saves
6297 a few bytes and will simplify future changes.
6298 * character.c (string_escape_byte8): Likewise.
6299 * lisp.h (string_overflow): New decl.
6300
6301 Fixups, following up to the user-interface timestamp change.
6302 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6303 for UI timestamps, instead of unsigned long.
6304 * msdos.c (mouse_get_pos): Likewise.
6305 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6306 * w32gui.h (Time): Define by including "systime.h" rather than by
6307 declaring it ourselves. (Bug#8664)
6308
6309 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6310 * image.c (clear_image_cache): Likewise.
6311
6312 * term.c (term_mouse_position): Don't assume time_t wraparound.
6313
6314 Be more systematic about user-interface timestamps.
6315 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6316 and sometimes 'EMACS_UINT', to represent these timestamps.
6317 This change causes it to use 'Time' uniformly, as that's what X uses.
6318 This makes the code easier to follow, and makes it easier to catch
6319 integer overflow bugs such as Bug#8664.
6320 * frame.c (Fmouse_position, Fmouse_pixel_position):
6321 Use Time, not unsigned long, for user-interface timestamps.
6322 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6323 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6324 * keyboard.h (last_event_timestamp): Likewise.
6325 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6326 * menu.h (xmenu_show): Likewise.
6327 * term.c (term_mouse_position): Likewise.
6328 * termhooks.h (struct input_event.timestamp): Likewise.
6329 (struct terminal.mouse_position_hook): Likewise.
6330 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6331 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6332 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6333 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6334 what it was before.
6335 * menu.h, termhooks.h: Include "systime.h", for Time.
6336
6337 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6338 Don't assume that the difference between two unsigned long values
6339 can fit into an integer. At this point, we know button_down_time
6340 <= event->timestamp, so the difference must be nonnegative, so
6341 there's no need to cast the result if double-click-time is
6342 nonnegative, as it should be; check that it's nonnegative, just in
6343 case. This bug is triggered when events are more than 2**31 ms
6344 apart (about 25 days). (Bug#8664)
6345
6346 * xselect.c (last_event_timestamp): Remove duplicate decl.
6347 (x_own_selection): Remove needless cast to unsigned long.
6348
6349 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6350 that always fit in int. Use a sentinel instead of a counter, to
6351 avoid a temp and to allay GCC's concerns about possible int overflow.
6352 * frame.h (struct frame): Use int for menu_bar_items_used
6353 instead of EMACS_INT, since it always fits in int.
6354
6355 * menu.c (grow_menu_items): Check for int overflow.
6356
6357 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6358
6359 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6360 Before, the code was not consistent. These values cannot exceed
6361 2**31 - 1 so there's no need to make them unsigned.
6362 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6363 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6364 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6365 as modifiers.
6366 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6367
6368 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6369 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6370 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6371 presumably because the widths might not match.
6372
6373 * window.c (size_window): Avoid needless test at loop start.
6374
6375 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6376
6377 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6378
6379 2011-05-12 Drew Adams <drew.adams@oracle.com>
6380
6381 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6382
6383 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6384
6385 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6386 `width' to `bar_area_x' and `bar_area_width', respectively.
6387 (x_scroll_run): Take account of fringe background extension.
6388
6389 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6390 Rename local vars `left' and `width' to `bar_area_x' and
6391 `bar_area_width', respectively.
6392 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6393 background extension.
6394
6395 2011-05-10 Jim Meyering <meyering@redhat.com>
6396
6397 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6398
6399 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6400
6401 * image.c (Finit_image_library): Return t for built-in image types,
6402 like pbm and xbm. (Bug#8640)
6403
6404 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6405
6406 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6407
6408 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6409
6410 * w32console.c (Fset_screen_color): Doc fix.
6411 (Fget_screen_color): New function.
6412 (syms_of_ntterm): Defsubr it.
6413
6414 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6415 unlink the temporary file if Fcall_process didn't create it in the
6416 first place.
6417 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6418 child process will be redirected to a file specified with `:file'.
6419 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6420 cue to call_process_cleanup not to close that handle.
6421
6422 2011-05-07 Ben Key <bkey76@gmail.com>
6423
6424 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6425 one of two shell specific rules, either bootstrap-temacs-CMD or
6426 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6427 to the previous implementation of the bootstrap-temacs rule.
6428 The bootstrap-temacs-CMD rule is similar to the previous
6429 implementation of the bootstrap-temacs rule except that it
6430 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6431 variable.
6432
6433 These changes, along with some changes to nt/configure.bat,
6434 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6435 earlier fix to add support for --cflags and --ldflags options
6436 that include quotes so that it works whether make uses cmd or
6437 sh as the shell.
6438
6439 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6440
6441 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6442 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6443 is a constant.
6444 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6445 a string. Handle both cases.
6446 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6447 (Fdbus_register_method): Use Qinvalid_function.
6448
6449 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6450
6451 * makefile.w32-in: Update dependencies.
6452 (LISP_H): Add inttypes.h and stdin.h.
6453 (PROCESS_H): Add unistd.h.
6454
6455 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6456
6457 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6458 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6459
6460 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6461
6462 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6463
6464 * term.c (vfatal): Remove stray call to va_end.
6465 It's not needed and the C Standard doesn't allow it here anyway.
6466
6467 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6468 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6469
6470 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6471 bytes.
6472
6473 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6474
6475 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6476
6477 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6478
6479 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6480
6481 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6482
6483 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6484 * charset.c (Fdefine_charset_internal): Don't initialize
6485 charset.code_space[15]. The value was garbage, on hosts with
6486 32-bit int (Bug#8600).
6487
6488 * lread.c (read_integer): Be more consistent with string-to-number.
6489 Use string_to_number to do the actual conversion; this avoids
6490 rounding errors and fixes some other screwups. Without this fix,
6491 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6492 (digit_to_number): Move earlier, for benefit of read_integer.
6493 Return -1 if the digit is out of range for the base, -2 if it is
6494 not a digit in any supported base. (Bug#8602)
6495
6496 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6497
6498 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6499 to match comment at start of function. This also removes a
6500 GCC warning about overflow in a 32+64-bit port.
6501
6502 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6503
6504 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6505 Reported by Stefan Monnier in
6506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6507 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6508 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6509
6510 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6511 (EMACS_UINTPTR): Likewise, with uintptr_t.
6512
6513 * lisp.h: Prefer 64-bit EMACS_INT if available.
6514 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6515 on 32-bit hosts that have 64-bit int, so that they can access
6516 large files.
6517 However, temporarily disable this change unless the temporary
6518 symbol WIDE_EMACS_INT is defined.
6519
6520 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6521
6522 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6523 This removes an assumption that EMACS_INT and long are the same
6524 width as pointers. The assumption is true for Emacs porting targets
6525 now, but we want to make other targets possible.
6526 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6527 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6528 In the rest of the code, change types of integers that hold casted
6529 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6530 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6531 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6532 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6533 No need to cast type when ORing.
6534 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6535 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6536 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6537 assume EMACS_INT is the same width as char *.
6538 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6539 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6540 Remove no-longer-needed casts.
6541 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6542 (xg_tool_bar_help_callback, xg_make_tool_item):
6543 Use EMACS_INTPTR to hold an integer
6544 that will be cast to void *; this can avoid a GCC warning
6545 if EMACS_INT is not the same width as void *.
6546 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6547 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6548 (current_message_1, set_message_1):
6549 Use a local to convert to proper width without a cast.
6550 * xmenu.c (dialog_selection_callback): Likewise.
6551
6552 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6553 Also, don't assume VALBITS / RAND_BITS is less than 5,
6554 and don't rely on undefined behavior when shifting a 1 left into
6555 the sign bit.
6556 * lisp.h (get_random): Change signature to match.
6557
6558 * lread.c (hash_string): Use size_t, not int, for hash computation.
6559 Normally we prefer signed values; but hashing is special, because
6560 it's better to use unsigned division on hash table sizes so that
6561 the remainder is nonnegative. Also, size_t is the natural width
6562 for hashing into memory. The previous code used 'int', which doesn't
6563 retain enough info to hash well into very large tables.
6564 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6565
6566 * dbusbind.c: Don't possibly lose pointer info when converting.
6567 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6568 Use XPNTR rather than XHASH, so that the high-order bits of
6569 the pointer aren't lost when converting through void *.
6570
6571 * eval.c (Fautoload): Don't double-shift a pointer.
6572
6573 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6574
6575 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6576
6577 * gnutls.c (DEF_GNUTLS_FN):
6578 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6579
6580 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6581
6582 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6583 marker. (Bug#8610)
6584
6585 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6586
6587 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6588 New version that can reserve upto 2GB of heap space.
6589
6590 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6591
6592 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6593
6594 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6595
6596 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6597 `gnutls_certificate_set_x509_key_file'.
6598
6599 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6602 Update dependencies.
6603
6604 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6607 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6608 Remove unused parameter `fildes'.
6609 * process.c (read_process_output, send_process): Don't pass it.
6610
6611 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6612
6613 Fix previous change: the library cache is defined in w32.c.
6614 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6615 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6616
6617 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6618
6619 Implement dynamic loading of GnuTLS on Windows.
6620
6621 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6622 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6623 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6624 Declare.
6625
6626 * gnutls.c (Qgnutls_dll): Define.
6627 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6628 (gnutls_*): Declare function pointers.
6629 (init_gnutls_functions): New function to initialize function pointers.
6630 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6631 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6632 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6633 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6634 (emacs_gnutls_write, emacs_gnutls_read)
6635 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6636 (Fgnutls_available_p): New function.
6637 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6638 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6639 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6640
6641 * image.c: Include w32.h.
6642 (Vimage_type_cache): Delete.
6643 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6644 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6645 (w32_delayed_load): Move to w32.c.
6646
6647 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6648
6649 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6650 (w32_delayed_load): Move from image.c. When loading a library, record
6651 its filename in the :loaded-from property of the library id.
6652 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6653 Initialize and staticpro them.
6654 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6655
6656 * process.c: Include lisp.h before w32.h, not after.
6657 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6658 instead of gnutls_record_check_pending.
6659
6660 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6661
6662 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6663
6664 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6665 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6666 as passed in.
6667
6668 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6669
6670 * xterm.c (x_set_frame_alpha): Do not set property on anything
6671 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6672
6673 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6674
6675 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6676
6677 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6678
6679 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6680 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6681 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6682 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6683 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6684 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6685 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6686 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6687 (Qgnutls_bootprop_callbacks_verify): Make static.
6688
6689 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6690
6691 * callproc.c: Indentation fixup.
6692
6693 * sysdep.c (wait_for_termination_1): Make static.
6694 (wait_for_termination, interruptible_wait_for_termination):
6695 Move after wait_for_termination_1.
6696
6697 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6698
6699 * sysdep.c (interruptible_wait_for_termination): New function
6700 which is like wait_for_termination, but allows keyboard
6701 interruptions.
6702
6703 * callproc.c (Fcall_process): Add (:file "file") as an option for
6704 the STDOUT buffer.
6705 (Fcall_process_region): Ditto.
6706
6707 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6708
6709 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6710 rather than `XVECTOR (FOO)->size'.
6711
6712 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6713 inttypes.h, as a gnulib replacement is used if it not available in
6714 system headers.
6715
6716 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6717
6718 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6719 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6720 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6721
6722 * coding.c (coding_alloc_by_realloc): Error out if destination
6723 will grow beyond MOST_POSITIVE_FIXNUM.
6724 (decode_coding_emacs_mule): Abort if there isn't enough place in
6725 charbuf for the composition carryover bytes. Reserve an extra
6726 space for up to 2 characters produced in a loop.
6727 (decode_coding_iso_2022): Abort if there isn't enough place in
6728 charbuf for the composition carryover bytes.
6729
6730 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6731
6732 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6733 aborting when %lld or %lll format is passed.
6734 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6735 %llo or %llx format is passed. (Bug#8545)
6736
6737 * window.c (window_scroll_line_based): Use a marker instead of
6738 simple variables to record original value of point. (Bug#7952)
6739
6740 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6741 produced by %s or %c overflows available buffer space. (Bug#8545)
6742
6743 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6744
6745 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6746 (SIZE_MAX): Move defn after all includes, as they might #define it.
6747
6748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6749
6750 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6751
6752 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6753
6754 * keyboard.c (Qdelayed_warnings_hook): Define.
6755 (command_loop_1): Run `delayed-warnings-hook'
6756 if Vdelayed_warnings_list is non-nil.
6757 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6758 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6759
6760 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6761
6762 * doprnt.c (doprnt): Don't return value smaller than the buffer
6763 size if the message was truncated. (Bug#8545).
6764
6765 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6766
6767 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6768 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6769
6770 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6771
6772 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6773
6774 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6775
6776 * makefile.w32-in: Update dependencies.
6777
6778 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6779
6780 Improve `doprnt' and its usage. (Bug#8545)
6781 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6782 `format_end'. Remove support for %l as a conversion specifier.
6783 Don't use xrealloc. Improve diagnostics when the %l size modifier
6784 is used. Update the commentary.
6785
6786 * eval.c (verror): Simplify calculation of size_t.
6787
6788 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6789 messages.
6790
6791 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6792
6793 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6794 change.
6795
6796 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6797
6798 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6799 This makes this file independent of the recent pseudovector change.
6800
6801 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6802
6803 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6804
6805 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6806 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6807 Remove unused local.
6808 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6809
6810 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6811 GCC 4.6.0 optimizes based on type-based alias analysis.
6812 For example, if b is of type struct buffer * and v of type struct
6813 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6814 != &v->size, and therefore "v->size = 1; b->size = 2; return
6815 v->size;" must therefore return 1. This assumption is incorrect
6816 for Emacs, since it type-puns struct Lisp_Vector * with many other
6817 types. To fix this problem, this patch adds a new type struct
6818 vectorlike_header that documents the constraints on layout of vectors
6819 and pseudovectors, and helps optimizing compilers not get fooled
6820 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6821 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6822 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6823 the size member.
6824 (XSETPVECTYPE): Rewrite in terms of new macro.
6825 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6826 This is a bit clearer, and further avoids the possibility of
6827 undesirable aliasing.
6828 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6829 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6830 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6831 since Lisp_Subr is a special case (no "next" field).
6832 (ASIZE): Now uses header.size rather than size.
6833 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6834 to avoid the hassle of writing XVECTOR (foo)->header.size.
6835 (struct vectorlike_header): New type.
6836 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6837 object, to help avoid aliasing.
6838 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6839 (SUBRP): Likewise, since Lisp_Subr is a special case.
6840 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6841 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6842 (struct Lisp_Hash_Table): Combine first two members into a single
6843 struct vectorlike_header member. All uses of "size" and "next" members
6844 changed to be "header.size" and "header.next".
6845 * buffer.h (struct buffer): Likewise.
6846 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6847 * frame.h (struct frame): Likewise.
6848 * process.h (struct Lisp_Process): Likewise.
6849 * termhooks.h (struct terminal): Likewise.
6850 * window.c (struct save_window_data, struct saved_window): Likewise.
6851 * window.h (struct window): Likewise.
6852 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6853 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6854 * buffer.c (init_buffer_once): Likewise.
6855 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6856 special case.
6857 * process.c (Fformat_network_address): Use local var for size,
6858 for brevity.
6859
6860 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6861
6862 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6863 * data.c (atof): Remove decl; no longer used or needed.
6864 (digit_to_number): Move to lread.c.
6865 (Fstring_to_number): Use new string_to_number function, to be
6866 consistent with how the Lisp reader treats infinities and NaNs.
6867 Do not assume that floating-point numbers represent EMACS_INT
6868 without losing information; this is not true on most 64-bit hosts.
6869 Avoid double-rounding errors, by insisting on integers when
6870 parsing non-base-10 numbers, as the documentation specifies.
6871 * lisp.h (string_to_number): New decl, replacing ...
6872 (isfloat_string): Remove.
6873 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6874 (read1): Do not accept +. and -. as integers; this
6875 appears to have been a coding error. Similarly, do not accept
6876 strings like +-1e0 as floating point numbers. Do not report
6877 overflow for integer overflows unless the base is not 10 which
6878 means we have no simple and reliable way to continue.
6879 Break out the floating-point parsing into a new
6880 function string_to_number, so that Fstring_to_number parses
6881 floating point numbers consistently with the Lisp reader.
6882 (digit_to_number): Move here from data.c. Make it static inline.
6883 (E_CHAR, EXP_INT): Remove, replacing with ...
6884 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6885 (string_to_number): New function, replacing isfloat_string.
6886 This function checks for valid syntax and produces the resulting
6887 Lisp float number too. Rework it so that string-to-number
6888 no longer mishandles examples like "1.0e+". Use strtoumax,
6889 so that overflow for non-base-10 numbers is reported only when
6890 there's no portable and simple way to convert to floating point.
6891
6892 * textprop.c (set_text_properties_1): Rewrite for clarity,
6893 and to avoid GCC warning about integer overflow.
6894
6895 * intervals.h (struct interval): Use EMACS_INT for members
6896 where EMACS_UINT might cause problems. See
6897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6898 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6899 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6900 All uses changed.
6901 (offset_intervals): Tell GCC not to worry about length overflow
6902 when negating a negative length.
6903
6904 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6905 (overrun_check_free): Likewise.
6906
6907 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6908 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6909 word size.
6910
6911 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6912 (gnutls_make_error): Rename local to avoid shadowing.
6913 (gnutls_emacs_global_deinit): ifdef out; not used.
6914 (Fgnutls_boot): Use const for pointer to readonly storage.
6915 Comment out unused local. Fix pointer signedness problems.
6916
6917 * lread.c (openp): Don't stuff size_t into an 'int'.
6918 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6919 about possible signed overflow.
6920
6921 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6922 (GDK_KEY_g): Don't define if already defined.
6923 (xg_prepare_tooltip): Avoid pointer signedness problem.
6924 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6925
6926 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6927 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6928
6929 * xfns.c (Fx_window_property): Simplify a bit,
6930 to make a bit faster and to avoid GCC 4.6.0 warning.
6931 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6932
6933 * fns.c (internal_equal): Don't assume size_t fits in int.
6934
6935 * alloc.c (compact_small_strings): Tighten assertion a little.
6936
6937 Replace pEd with more-general pI, and fix some printf arg casts.
6938 * lisp.h (pI): New macro, generalizing old pEd macro to other
6939 conversion specifiers. For example, use "...%"pI"d..." rather
6940 than "...%"pEd"...".
6941 (pEd): Remove. All uses replaced with similar uses of pI.
6942 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6943 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6944 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6945 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6946 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6947 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6948 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6949 64-bit hosts.
6950 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6951 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6952 * print.c (safe_debug_print, print_object): Likewise.
6953 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6954 to int.
6955 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6956 avoiding the 0 flag, which is not portable.
6957 * process.c (Fmake_network_process): Use pI to avoid cast.
6958 * region-cache.c (pp_cache): Likewise.
6959 * xdisp.c (decode_mode_spec): Likewise.
6960 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6961 behavior on 64-bit hosts with printf arg.
6962 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6963 (x_stop_queuing_selection_requests): Likewise.
6964 (x_get_window_property): Don't truncate byte count to an 'int'
6965 when tracing.
6966
6967 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6968 here, since it parses constructs like leading '-' and spaces,
6969 which are not wanted; and it overflows with large numbers.
6970 Instead, simply match F[0-9]+, which is what is wanted anyway.
6971
6972 * alloc.c: Remove unportable assumptions about struct layout.
6973 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6974 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6975 (allocate_vectorlike, make_pure_vector): Use the new macros,
6976 plus offsetof, to remove unportable assumptions about struct layout.
6977 These assumptions hold on all porting targets that I know of, but
6978 they are not guaranteed, they're easy to remove, and removing them
6979 makes further changes easier.
6980
6981 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6982 This doesn't fix a bug but makes the code clearer.
6983 (string_overrun_cookie): Now const. Use initializers that
6984 don't formally overflow signed char, to avoid warnings.
6985 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6986 can cause Emacs to crash when string overrun checking is enabled.
6987 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6988 multiple of sizeof (EMACS_INT); it need not be, if
6989 alignof(EMACS_INT) < sizeof (EMACS_INT).
6990 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6991
6992 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6993
6994 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6995
6996 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6997
6998 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6999 supposed to be handshaking. (Bug#8556)
7000 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7001
7002 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7003
7004 * lisp.h (Qdebug): List symbol.
7005 * eval.c (Qdebug): Restore global linkage.
7006 * keyboard.c (debug-on-event): New variable.
7007 (handle_user_signal): Break into debugger when debug-on-event
7008 matches the current signal symbol.
7009
7010 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7011
7012 * alloc.c (check_sblock, check_string_bytes)
7013 (check_string_free_list): Convert to standard C.
7014
7015 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7016
7017 * w32.c (emacs_gnutls_push): Fix typo.
7018
7019 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7020
7021 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7022 "cast to pointer from integer of different size".
7023
7024 Improve doprnt and its use in verror. (Bug#8545)
7025 * doprnt.c (doprnt): Document the set of format control sequences
7026 supported by the function. Use SAFE_ALLOCA instead of always
7027 using `alloca'.
7028
7029 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7030 is one byte too soon. Don't use xrealloc; instead xfree and
7031 xmalloc anew.
7032
7033 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7034
7035 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7036 callbacks stage.
7037
7038 * gnutls.c: Renamed global_initialized to
7039 gnutls_global_initialized. Added internals for the
7040 :verify-hostname-error, :verify-error, and :verify-flags
7041 parameters of `gnutls-boot' and documented those parameters in the
7042 docstring. Start callback support.
7043 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7044 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7045 on error. Return error code.
7046 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7047 (emacs_gnutls_read): Likewise.
7048 (Fgnutls_boot): Return handshake error code.
7049 (emacs_gnutls_handle_error): New function.
7050 (wsaerror_to_errno): Likewise.
7051
7052 * w32.h (emacs_gnutls_pull): Add prototype.
7053 (emacs_gnutls_push): Likewise.
7054
7055 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7056 (emacs_gnutls_push): Likewise.
7057
7058 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7059
7060 * process.c (wait_reading_process_output): Check if GnuTLS
7061 buffered some data internally if no FDs are set for TLS
7062 connections.
7063
7064 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7065 (LIBS): Link to USER_LIBS.
7066 ($(BLD)/gnutls.$(0)): New target.
7067
7068 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7069
7070 * xdisp.c (handle_single_display_spec): Rename the
7071 display_replaced_before_p argument into display_replaced_p, to
7072 make it consistent with the commentary. Fix typos in the
7073 commentary.
7074
7075 * textprop.c (syms_of_textprop): Remove dead code.
7076 (copy_text_properties): Delete obsolete commentary about an
7077 interface that was deleted long ago. Fix typos in the description
7078 of arguments.
7079
7080 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7081 to changes in oldXMenu/XMenu.h from 2011-04-16.
7082 <menu_help_message, prev_menu_help_message>: Constify.
7083 (IT_menu_make_room): menu->help_text is now `const char **';
7084 adjust.
7085
7086 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7087 to changes in oldXMenu/XMenu.h from 2011-04-16.
7088 (struct XMenu): Declare `help_text' `const char **'.
7089
7090 * xfaces.c <Qunspecified>: Make extern again.
7091
7092 * syntax.c: Include sys/types.h before including regex.h, as
7093 required by Posix.
7094
7095 * doc.c (get_doc_string): Improve the format passed to `error'.
7096
7097 * doprnt.c (doprnt): Improve commentary.
7098
7099 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7100
7101 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7102 them with etags.
7103
7104 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7105 changes in globals.h immediately force recompilation.
7106 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7107 $(CURDIR)/s/ms-w32.h.
7108 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7109
7110 * character.c (Fchar_direction): Function deleted.
7111 (syms_of_character): Don't defsubr it.
7112 <char-direction-table>: Deleted.
7113
7114 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7115
7116 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7117 * doprnt.c: Include limits.h.
7118 (SIZE_MAX): New macro.
7119 (doprnt): Return a size_t value. 2nd arg is now size_t.
7120 Many local variables are now size_t instead of int or unsigned.
7121 Improve overflow protection. Support `l' modifier for integer
7122 conversions. Support %l conversion. Don't assume an EMACS_INT
7123 argument for integer conversions and for %c.
7124
7125 * lisp.h (doprnt): Restore prototype.
7126
7127 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7128 $(SRC)/character.h.
7129
7130 * Makefile.in (base_obj): Add back doprnt.o.
7131
7132 * deps.mk (doprnt.o): Add back prerequisites.
7133 (callint.o): Depend on character.h.
7134
7135 * eval.c (internal_lisp_condition_case): Include the handler
7136 representation in the error message.
7137 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7138 when breaking from the loop.
7139
7140 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7141
7142 * callint.c (Fcall_interactively): When displaying error message
7143 about invalid control letter, pass the character's codepoint, not
7144 a pointer to its multibyte form. Improve display of the character
7145 in octal and display also its hex code.
7146
7147 * character.c (char_string): Use %x to display the (unsigned)
7148 codepoint of an invalid character, to avoid displaying a bogus
7149 negative value.
7150
7151 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7152 `error', not SYMBOL_NAME itself.
7153
7154 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7155 character arguments to `error'.
7156
7157 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7158 to `error' in error message about FINAL_CHAR argument. Make sure
7159 FINAL_CHAR is a character, and use %c when it is passed as
7160 argument to `error'.
7161
7162 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7163
7164 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7165
7166 * w32.c: Include <time.h>.
7167 (sys_localtime): New function.
7168
7169 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7170
7171 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7172
7173 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7174
7175 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7176
7177 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7178 zombies (Bug#8467).
7179
7180 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7181
7182 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7183 gl_state.e_property when gl_state.object is Qt.
7184
7185 * insdel.c (make_gap_larger): Remove limitation of buffer size
7186 to <= INT_MAX.
7187
7188 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7189
7190 * xdisp.c (lookup_glyphless_char_display)
7191 (produce_glyphless_glyph): Handle cons cell entry in
7192 glyphless-char-display.
7193 (Vglyphless_char_display): Document it.
7194
7195 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7196 glyphless-char-display.
7197
7198 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7199
7200 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7201
7202 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7203
7204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7205 definition for no-X builds.
7206
7207 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7208
7209 Static checks with GCC 4.6.0 and non-default toolkits.
7210
7211 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7212
7213 * process.c (keyboard_bit_set): Define only if SIGIO.
7214 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7215 (send_process): Repair possible setjmp clobbering.
7216
7217 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7218
7219 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7220
7221 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7222
7223 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7224 Define only if needed.
7225
7226 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7227 by pacifying GCC about it. Maybe it's time to retire it?
7228 * xfaces.c (USG, __TIMEVAL__): Likewise.
7229
7230 * dispextern.h (struct redisplay_interface): Rename param
7231 to avoid shadowing.
7232 * termhooks.h (struct terminal): Likewise.
7233 * xterm.c (xembed_send_message): Likewise.
7234
7235 * insdel.c (make_gap_smaller): Define only if
7236 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7237
7238 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7239 it.
7240
7241 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7242 so that we aren't warned about unused symbols.
7243
7244 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7245
7246 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7247
7248 * xfns.c (x_real_positions): Mark locals as initialized.
7249
7250 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7251
7252 * xterm.c: Fix problems found by static analysis with other toolkits.
7253 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7254 (x_dispatch_event): Declare static if USE_GTK, and
7255 define if USE_GTK || USE_X_TOOLKIT.
7256 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7257 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7258 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7259 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7260
7261 * xmenu.c (menu_help_callback): Pointer type fixes.
7262 Use const pointers when pointing at readonly data. Avoid pointer
7263 signedness clashes.
7264 (FALSE): Remove unused macro.
7265 (update_frame_menubar): Remove unused decl.
7266
7267 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7268
7269 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7270 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7271 (single_menu_item): Rename local to avoid shadowing.
7272
7273 * keyboard.c (make_lispy_event): Remove unused local var.
7274
7275 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7276 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7277
7278 * bitmaps: Change bitmaps from unsigned char back to the X11
7279 compatible char. Avoid the old compiler warnings about
7280 out-of-range initializers by using, for example, '\xab' rather
7281 than 0xab.
7282
7283 * xgselect.c (xgselect_initialize): Check vs interface
7284 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7285
7286 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7287
7288 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7289 to read-only memory.
7290
7291 * fns.c (vector): Remove; this old hack is no longer needed.
7292
7293 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7294 Remove unused var.
7295 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7296
7297 * xrdb.c (x_load_resources): Omit unused local.
7298
7299 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7300 (x_window): Rename locals to avoid shadowing.
7301 (USG): Use the kludged USG macro, to pacify gcc.
7302
7303 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7304 (x_term_init): Remove local to avoid shadowing.
7305
7306 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7307
7308 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7309 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7310
7311 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7312
7313 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7314
7315 Fix regex.c, syntax.c and friends for buffers > 2GB.
7316 * syntax.h (struct gl_state_s): Declare character position members
7317 EMACS_INT.
7318
7319 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7320
7321 * textprop.c (verify_interval_modification, interval_of):
7322 Declare arguments EMACS_INT.
7323
7324 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7325 EMACS_INT.
7326
7327 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7328
7329 * indent.c (Fvertical_motion): Local variable it_start is now
7330 EMACS_INT.
7331
7332 * regex.c (re_match, re_match_2, re_match_2_internal)
7333 (bcmp_translate, regcomp, regexec, print_double_string)
7334 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7335 (re_compile_pattern, re_exec): Declare arguments and local
7336 variables `size_t' and `ssize_t' and return values `regoff_t', as
7337 appropriate.
7338 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7339 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7340 <compile_stack_type>: `size' and `avail' are now `size_t'.
7341
7342 * regex.h <regoff_t>: Use ssize_t, not int.
7343 (re_search, re_search_2, re_match, re_match_2): Arguments that
7344 specify buffer/string position and length are now ssize_t and
7345 size_t. Return type is regoff_t.
7346
7347 2011-04-16 Ben Key <bkey76@gmail.com>
7348
7349 * nsfont.m: Fixed bugs in ns_get_family and
7350 ns_descriptor_to_entity that were caused by using free to
7351 deallocate memory blocks that were allocated by xmalloc (via
7352 xstrdup). This caused Emacs to crash when compiled with
7353 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7354 --enable-checking=xmallocoverrun). xfree is now used to
7355 deallocate these memory blocks.
7356
7357 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7358
7359 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7360
7361 emacs_write: Accept and return EMACS_INT for sizes.
7362 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7363 et seq.
7364 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7365 Accept and return EMACS_INT.
7366 (emacs_gnutls_write): Return the number of bytes written on
7367 partial writes.
7368 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7369 (emacs_read, emacs_write): Remove check for negative size, as the
7370 Emacs source code has been audited now.
7371 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7372 (emacs_read, emacs_write): Use it.
7373 * process.c (send_process): Adjust to the new signatures of
7374 emacs_write and emacs_gnutls_write. Do not attempt to store
7375 a byte offset into an 'int'; it might overflow.
7376 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7377
7378 * sound.c: Don't assume sizes fit in 'int'.
7379 (struct sound_device.period_size, alsa_period_size):
7380 Return EMACS_INT, not int.
7381 (struct sound_device.write, vox_write, alsa_write):
7382 Accept EMACS_INT, not int.
7383 (wav_play, au_play): Use EMACS_INT to store sizes and to
7384 record read return values.
7385
7386 2011-04-15 Ben Key <bkey76@gmail.com>
7387
7388 * keyboard.c (Qundefined): Don't declare static since it is used
7389 in nsfns.m.
7390 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7391 static since they are used in nsfont.m.
7392
7393 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7394
7395 * process.c (Qprocessp): Don't declare static.
7396 * lisp.h (Qprocessp): Declare again.
7397
7398 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7399
7400 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7401
7402 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7403
7404 Improve C-level modularity by making more things 'static'.
7405
7406 Don't publish debugger-only interfaces to other modules.
7407 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7408 (verify_bytepos, count_markers): Move decls to the only modules
7409 that need them.
7410 * region-cache.h (pp_cache): Likewise.
7411 * window.h (check_all_windows): Likewise.
7412 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7413
7414 * sysdep.c (croak): Now static, if
7415 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7416 * syssignal.h (croak): Declare only if not static.
7417
7418 * alloc.c (refill_memory_reserve): Now static if
7419 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7420 * lisp.h (refill_memory_reserve): Declare only if not static.
7421
7422 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7423 Define only if USE_LUCID.
7424
7425 * xrdb.c (x_customization_string, x_rm_string): Now static.
7426
7427 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7428 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7429
7430 * xdisp.c (draw_row_with_mouse_face): Now static.
7431 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7432
7433 * window.h (check_all_windows): Mark externally visible.
7434
7435 * window.c (window_deletion_count): Now static.
7436
7437 * undo.c: Make symbols static if they're not exported.
7438 (last_undo_buffer, last_boundary_position, pending_boundary):
7439 Now static.
7440
7441 * textprop.c (interval_insert_behind_hooks): Now static.
7442 (interval_insert_in_front_hooks): Likewise.
7443
7444 * term.c: Make symbols static if they're not exported.
7445 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7446 (max_frame_lines, tty_set_terminal_modes):
7447 (tty_reset_terminal_modes, tty_turn_off_highlight):
7448 (get_tty_terminal): Now static.
7449 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7450 * termhooks.h (term_mouse_moveto): Do not declare if
7451 HAVE_WINDOW_SYSTEM.
7452 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7453 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7454
7455 * sysdep.c: Make symbols static if they're not exported.
7456 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7457 Now static.
7458 (sigprocmask_set, full_mask): Remove; unused.
7459 (wait_debugging): Mark as visible.
7460 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7461 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7462
7463 * syntax.c (syntax_temp): Define only if !__GNUC__.
7464
7465 * sound.c (current_sound_device, current_sound): Now static.
7466
7467 * search.c (searchbufs, searchbuf_head): Now static.
7468
7469 * scroll.c (scroll_cost): Remove; unused.
7470 * dispextern.h (scroll_cost): Remove decl.
7471
7472 * region-cache.h (pp_cache): Mark as externally visible.
7473
7474 * process.c: Make symbols static if they're not exported.
7475 (process_tick, update_tick, create_process, chan_process):
7476 (Vprocess_alist, proc_buffered_char, datagram_access):
7477 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7478 (deactivate_process): Mark defn as static, as well as decl.
7479 * lisp.h (create_process): Remove decl.
7480 * process.h (chan_process, Vprocess_alist): Remove decls.
7481
7482 * print.c: Make symbols static if they're not exported.
7483 (print_depth, new_backquote_output, being_printed, print_buffer):
7484 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7485 (print_interval, print_number_index, initial_stderr_stream):
7486 Now static.
7487 * lisp.h (Fprinc): Remove decl.
7488 (debug_output_compilation_hack): Mark as externally visible.
7489
7490 * sysdep.c (croak): Move decl from here to syssignal.h.
7491 * syssignal.h (croak): Put it here, so the API can be checked when
7492 'croak' is called from dissociate_if_controlling_tty.
7493
7494 * minibuf.c: Make symbols static if they're not exported.
7495 (minibuf_save_list, choose_minibuf_frame): Now static.
7496 * lisp.h (choose_minibuf_frame): Remove decl.
7497
7498 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7499
7500 * lread.c: Make symbols static if they're not exported.
7501 (read_objects, initial_obarray, oblookup_last_bucket_number):
7502 Now static.
7503 (make_symbol): Remove; unused.
7504 * lisp.h (initial_obarray, make_symbol): Remove decls.
7505
7506 * keyboard.c: Make symbols static if they're not exported.
7507 (single_kboard, recent_keys_index, total_keys, recent_keys):
7508 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7509 (this_single_command_key_start, echoing, last_auto_save):
7510 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7511 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7512 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7513 (Vlispy_mouse_stem, double_click_count):
7514 Now static.
7515 (force_auto_save_soon): Define only if SIGDANGER.
7516 (ignore_mouse_drag_p): Now static if
7517 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7518 (print_help): Remove; unused.
7519 (stop_character, last_timer_event): Mark as externally visible.
7520 * keyboard.h (ignore_mouse_drag_p): Declare only if
7521 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7522 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7523 * lisp.h (echoing): Remove decl.
7524 (force_auto_save_soon): Declare only if SIGDANGER.
7525 * xdisp.c (redisplay_window): Simplify code, to make it more
7526 obvious that ignore_mouse_drag_p is not accessed if !defined
7527 USE_GTK && !defined HAVE_NS.
7528
7529 * intervals.c: Make symbols static if they're not exported.
7530 (merge_properties_sticky, merge_interval_right, delete_interval):
7531 Now static.
7532 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7533
7534 * insdel.c: Make symbols static if they're not exported.
7535 However, leave prepare_to_modify_buffer alone. It's never
7536 called from outside this function, but that appears to be a bug.
7537 (combine_after_change_list, combine_after_change_buffer):
7538 (adjust_after_replace, signal_before_change): Now static.
7539 (adjust_after_replace_noundo): Remove; unused.
7540 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7541 (signal_before_change): Remove decls.
7542
7543 * indent.c (val_compute_motion, val_vmotion): Now static.
7544
7545 * image.c: Make symbols static if they're not exported.
7546 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7547 if USE_GTK.
7548 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7549 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7550
7551 * fringe.c (standard_bitmaps): Now static.
7552 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7553
7554 * frame.c: Make symbols static if they're not exported.
7555 (x_report_frame_params, make_terminal_frame): Now static.
7556 (get_frame_param): Now static, unless HAVE_NS.
7557 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7558 (x_get_resource_string): Remove; not used.
7559 * frame.h (make_terminal_frame, x_report_frame_params):
7560 (x_get_resource_string); Remove decls.
7561 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7562 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7563
7564 * font.c, fontset.c: Make symbols static if they're not exported.
7565 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7566 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7567 * font.c (font_close_object): Now static.
7568 * font.h (font_close_object): Remove.
7569 * fontset.c (FONTSET_OBJLIST): Remove.
7570 (free_realized_fontset) #if-0 the body, which does nothing.
7571 (face_suitable_for_char_p): #if-0, as it's never called.
7572 * fontset.h (face_suitable_for_char_p): Remove decl.
7573 * xfaces.c (face_at_string_position):
7574 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7575 since 0 is always ASCII.
7576
7577 * fns.c (weak_hash_tables): Now static.
7578
7579 * fileio.c: Make symbols static if they're not exported.
7580 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7581 (Vwrite_region_annotation_buffers): Now static.
7582
7583 * eval.c: Make symbols static if they're not exported.
7584 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7585 * lisp.h (backtrace_list): Remove decl.
7586
7587 * emacs.c: Make symbols static if they're not exported.
7588 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7589 (fatal_error_code, fatal_error_signal_hook, standard_args):
7590 Now static.
7591 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7592 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7593 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7594 * lisp.h (fatal_error_signal_hook): Remove decl.
7595 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7596
7597 * editfns.c: Move a (normally-unused) function to its only use.
7598 * editfns.c, lisp.h (get_operating_system_release): Remove.
7599 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7600 worth the hassle of breaking this out.
7601
7602 * xterm.c: Make symbols static if they're not exported.
7603 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7604 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7605 (x_destroy_window, x_delete_display):
7606 Now static.
7607 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7608 (x_mouse_leave): Remove; unused.
7609 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7610 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7611 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7612 Remove decls.
7613 (x_mouse_leave): Declare only if WINDOWSNT.
7614 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7615 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7616 USE_X_TOOLKIT.
7617
7618 * ftxfont.c: Make symbols static if they're not exported.
7619 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7620 HAVE_FREETYPE.
7621 * font.h (ftxfont_driver): Likewise.
7622
7623 * xfns.c: Make symbols static if they're not exported.
7624 (x_last_font_name, x_display_info_for_name):
7625 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7626 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7627 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7628 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7629 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7630 (last_show_tip_args): Now static.
7631 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7632 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7633 (x_screen_planes): Remove; unused.
7634 * dispextern.h (x_screen_planes): Remove decl.
7635
7636 * dispnew.c: Make symbols static if they're not exported.
7637 * dispextern.h (redraw_garbaged_frames, scrolling):
7638 (increment_row_positions): Remove.
7639 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7640 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7641 Now static.
7642 (redraw_garbaged_frames): Remove; unused.
7643
7644 * xfaces.c: Make symbols static if they're not exported.
7645 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7646 Remove decls.
7647 * xterm.h (defined_color): Remove decls.
7648 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7649 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7650 (menu_face_changed_default, defined_color, free_realized_face):
7651 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7652 (ascii_face_of_lisp_face): Remove; unused.
7653
7654 * xdisp.c: Make symbols static if they're not exported.
7655 * dispextern.h (scratch_glyph_row, window_box_edges):
7656 (glyph_to_pixel_coords, set_cursor_from_row):
7657 (get_next_display_element, set_iterator_to_next):
7658 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7659 (show_mouse_face): Remove decls
7660 * frame.h (message_buf_print): Likewise.
7661 * lisp.h (pop_message, set_message, check_point_in_composition):
7662 Likewise.
7663 * xterm.h (set_vertical_scroll_bar): Likewise.
7664 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7665 (message_buf_print, scratch_glyph_row, displayed_buffer):
7666 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7667 (get_next_display_element, show_mouse_face, window_box_edges):
7668 (frame_to_window_pixel_xy, check_point_in_composition):
7669 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7670 (glyph_to_pixel_coords): Remove; unused.
7671
7672 * dired.c (file_name_completion): Now static.
7673
7674 * dbusbind.c (xd_in_read_queued_messages): Now static.
7675
7676 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7677 * data.c (circular_list_error): Remove.
7678
7679 * commands.h (last_point_position, last_point_position_buffer):
7680 (last_point_position_window): Remove decls.
7681 * keyboard.c: Make these variables static.
7682
7683 * coding.h (coding, code_convert_region, encode_coding_gap):
7684 Remove decls.
7685 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7686 (iso_code_class, detect_coding, code_convert_region): Now static.
7687 (encode_coding_gap): Remove; unused.
7688
7689 * chartab.c (chartab_chars, chartab_bits): Now static.
7690
7691 * charset.h (charset_iso_8859_1): Remove decl.
7692 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7693 Now static.
7694
7695 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7696 * ccl.c (Vccl_program_table): Now static.
7697 (check_ccl_update): Remove; unused.
7698
7699 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7700 * category.h: ... from here.
7701 * category.c (check_category_table, set_category_set): Now static.
7702
7703 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7704 * lisp.h: Remove these decls.
7705
7706 * buffer.c (buffer_count): Remove unused var.
7707
7708 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7709 so that it's not optimized away.
7710 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7711 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7712 exported only to the debugger.
7713
7714 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7715 * atimer.h (run_all_atimers): Remove; not exported.
7716
7717 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7718 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7719 was inaccessible from Lisp.
7720 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7721 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7722
7723 alloc.c: Import and export fewer symbols, and remove unused items.
7724 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7725 is defined.
7726 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7727 it's not optimized away by whole-program optimization.
7728 (message_enable_multibyte, free_misc): Remove.
7729 (catchlist, handlerlist, mark_backtrace):
7730 Declare only if BYTE_MARK_STACK.
7731 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7732 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7733 (message_enable_multibyte): Remove decl.
7734 (free_misc, interval_free_list, float_block, float_block_index):
7735 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7736 (cons_free_list, last_marked_index):
7737 Now static.
7738 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7739 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7740 (mark_backtrace): Define only if BYTE_MARK_STACK.
7741 * xdisp.c (message_enable_multibyte): Now static.
7742
7743 Declare Lisp_Object Q* variables to be 'static' if not exported.
7744 This makes it easier for human readers (and static analyzers)
7745 to see whether these variables are used from other modules.
7746 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7747 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7748 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7749 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7750 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7751 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7752 * xmenu.c, xselect.c:
7753 Declare Q* vars static if they are not used in other modules.
7754 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7755 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7756 Remove decls of unexported vars.
7757 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7758
7759 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7760
7761 Make Emacs functions such as Fatom 'static' by default.
7762 This makes it easier for human readers (and static analyzers)
7763 to see whether these functions can be called from other modules.
7764 DEFUN now defines a static function. To make the function external
7765 so that it can be used in other C modules, use the new macro DEFUE.
7766 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7767 (Finit_image_library):
7768 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7769 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7770 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7771 Remove decls, since these functions are now static.
7772 (Funintern, Fget_internal_run_time): New decls, since these functions
7773 were already external.
7774
7775 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7776 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7777 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7778 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7779 * keyboard.c, keymap.c, lread.c:
7780 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7781 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7782 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7783 Mark functions with DEFUE instead of DEFUN,
7784 if they are used in other modules.
7785 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7786 decls for now-static functions.
7787 * buffer.h (Fdelete_overlay): Remove decl.
7788 * callproc.c (Fgetenv_internal): Mark as internal.
7789 * composite.c (Fremove_list_of_text_properties): Remove decl.
7790 (Fcomposition_get_gstring): New forward static decl.
7791 * composite.h (Fcomposite_get_gstring): Remove decl.
7792 * dired.c (Ffile_attributes): New forward static decl.
7793 * doc.c (Fdocumntation_property): New forward static decl.
7794 * eval.c (Ffetch_bytecode): New forward static decl.
7795 (Funintern): Remove extern decl; now in .h file where it belongs.
7796 * fileio.c (Fmake_symbolic_link): New forward static decl.
7797 * image.c (Finit_image_library): New forward static decl.
7798 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7799 * intervals.h (Fprevious_property_change):
7800 (Fremove_list_of_text_properties): Remove decls.
7801 * keyboard.c (Fthis_command_keys): Remove decl.
7802 (Fcommand_execute): New forward static decl.
7803 * keymap.c (Flookup_key): New forward static decl.
7804 (Fcopy_keymap): Now static.
7805 * keymap.h (Flookup_key): Remove decl.
7806 * process.c (Fget_process): New forward static decl.
7807 (Fprocess_datagram_address): Mark as internal.
7808 * syntax.c (Fsyntax_table_p): New forward static decl.
7809 (skip_chars): Remove duplicate decl.
7810 * textprop.c (Fprevious_property_change): New forward static decl.
7811 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7812 Now internal.
7813 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7814 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7815
7816 * editfns.c (Fformat): Remove unreachable code.
7817
7818 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7819
7820 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7821 change. (Bug#8496)
7822
7823 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7824
7825 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7826 when at ZV. (Bug#8487)
7827
7828 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7829
7830 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7831 (Bug#8437)
7832 * keyboard.c (parse_tool_bar_item): Likewise.
7833 * sound.c (sound_cleanup, alsa_close): Likewise.
7834 * termcap.c (tgetent): Likewise.
7835 * xfns.c (x_default_font_parameter): Likewise.
7836 * xsettings.c (read_and_apply_settings): Likewise.
7837
7838 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7839 (overrun_check_free): Protoize.
7840
7841 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7842
7843 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7844 since callers should never pass a negative size.
7845 Change the signature to match that of plain 'read' and 'write'; see
7846 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7847 * lisp.h: Update prototypes of emacs_write and emacs_read.
7848
7849 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7850
7851 * xdisp.c (redisplay_window): Don't try to determine the character
7852 position of the scroll margin if the window start point w->startp
7853 is outside the buffer's accessible region. (Bug#8468)
7854
7855 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7856
7857 Fix write-region and its subroutines for buffers > 2GB.
7858 * fileio.c (a_write, e_write): Modify declaration of arguments and
7859 local variables to support buffers larger than 2GB.
7860 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7861
7862 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7863 argument, local variables, and return value.
7864
7865 * lisp.h: Update prototypes of emacs_write and emacs_read.
7866
7867 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7868
7869 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7870
7871 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7872
7873 Fix more problems found by GCC 4.6.0's static checks.
7874
7875 * xdisp.c (vmessage): Use a better test for character truncation.
7876
7877 * charset.c (load_charset_map): <, not <=, for optimization,
7878 and to avoid potential problems with integer overflow.
7879 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7880 * casetab.c (set_identity, shuffle): Likewise.
7881 * editfns.c (Fformat): Likewise.
7882 * syntax.c (skip_chars): Likewise.
7883
7884 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7885 This also lets GCC 4.6.0 generate slightly better loop code.
7886
7887 * callint.c (Fcall_interactively): <, not <=, for optimization.
7888 (Fcall_interactively): Count the number of arguments produced,
7889 not the number of arguments given. This is simpler and lets GCC
7890 4.6.0 generate slightly better code.
7891
7892 * ftfont.c: Distingish more carefully between FcChar8 and char.
7893 The previous code passed unsigned char * to a functions like
7894 strlen and xstrcasecmp that expect char *, which does not
7895 conform to the C standard.
7896 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7897 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7898 char * when the C standard requires it.
7899
7900 * keyboard.c (read_char): Remove unused var.
7901
7902 * eval.c: Port to Windows vsnprintf (Bug#8435).
7903 Include <limits.h>.
7904 (SIZE_MAX): Define if the headers do not.
7905 (verror): Do not give up if vsnprintf returns a negative count.
7906 Instead, grow the buffer. This ports to Windows vsnprintf, which
7907 does not conform to C99. Problem reported by Eli Zaretskii.
7908 Also, simplify the allocation scheme, by avoiding the need for
7909 calling realloc, and removing the ALLOCATED variable.
7910
7911 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7912
7913 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7914 But keep the doprint source code for now, as we might revamp it
7915 and use it again (Bug#8435).
7916 * lisp.h (doprnt): Remove.
7917 * Makefile.in (base_obj): Remove doprnt.o.
7918 * deps.mk (doprnt.o): Remove.
7919
7920 error: Print 32- and 64-bit integers portably (Bug#8435).
7921 Without this change, on typical 64-bit hosts error ("...%d...", N)
7922 was used to print both 32- and 64-bit integers N, which relied on
7923 undefined behavior.
7924 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7925 * lisp.h (error, verror): Mark as printf-like functions.
7926 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7927 Report overflow in size calculations when allocating printf buffer.
7928 Do not truncate output string at its first null byte.
7929 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7930 Truncate the output at a character boundary, since vsnprintf does not
7931 do that.
7932 * charset.c (check_iso_charset_parameter): Convert internal
7933 character to string before calling 'error', since %c now has the
7934 printf meaning.
7935 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7936 overflow when computing char to be passed to 'error'. Do not
7937 pass Lisp_Object to 'error'; pass the integer instead.
7938 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7939 formatted with plain %d.
7940
7941 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7942
7943 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7944
7945 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7946
7947 * xterm.c (x_catch_errors): Remove duplicate declaration.
7948
7949 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7950
7951 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7952
7953 2011-04-10 Jim Meyering <meyering@redhat.com>
7954
7955 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7956 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7957 return ssize_t not "int", and use size_t as the buffer length.
7958 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7959 * gnutls.h: Update declarations.
7960 * process.c (read_process_output): Use ssize_t, to match.
7961 (send_process): Likewise.
7962
7963 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7964
7965 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7966
7967 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7968
7969 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7970 Use unsigned char, to match FcChar8 type definition.
7971
7972 * xterm.c (handle_one_xevent):
7973 * xmenu.c (create_and_show_popup_menu):
7974 * xselect.c (x_decline_selection_request)
7975 (x_reply_selection_request): Avoid type-punned deref of X events.
7976
7977 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7978
7979 Fix some uses of `int' instead of EMACS_INT.
7980 * search.c (string_match_1, fast_string_match)
7981 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7982 (scan_buffer, find_next_newline_no_quit)
7983 (find_before_next_newline, search_command, Freplace_match)
7984 (Fmatch_data): Make some `int' variables be EMACS_INT.
7985
7986 * xdisp.c (display_count_lines): 3rd argument and return value now
7987 EMACS_INT. All callers changed.
7988 (pint2hrstr): Last argument is now EMACS_INT.
7989
7990 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7991 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7992 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7993 (decode_coding_utf_16, decode_coding_emacs_mule)
7994 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7995 (decode_coding_ccl, decode_coding_charset)
7996 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7997 (decode_coding_iso_2022, decode_coding_emacs_mule)
7998 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7999 <char_offset, last_offset>: Declare EMACS_INT.
8000 (encode_coding_utf_8, encode_coding_utf_16)
8001 (encode_coding_emacs_mule, encode_invocation_designation)
8002 (encode_designation_at_bol, encode_coding_iso_2022)
8003 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8004 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8005 Declare EMACS_INT.
8006 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8007 (encode_invocation_designation): Last argument P_NCHARS is now
8008 EMACS_INT.
8009 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8010 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8011
8012 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8013 All users changed.
8014
8015 * ccl.c (Fccl_execute_on_string): Declare some variables
8016 EMACS_INT.
8017
8018 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8019
8020 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8021
8022 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8023
8024 * process.c (Fformat_network_address): Doc fix.
8025
8026 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8027
8028 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8029
8030 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8031
8032 * keyboard.c (read_char): Call Lisp function help-form-show,
8033 instead of using internal_with_output_to_temp_buffer.
8034 (Qhelp_form_show): New var.
8035 (syms_of_keyboard): Use DEFSYM macro.
8036
8037 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8038
8039 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8040
8041 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8042
8043 * process.c (Flist_processes): Remove to Lisp.
8044 (list_processes_1): Delete.
8045
8046 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8047
8048 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8049
8050 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8051
8052 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8053
8054 Fix more problems found by GCC 4.6.0's static checks.
8055
8056 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8057
8058 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8059
8060 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8061
8062 * xdisp.c (vmessage): Mark as a printf-like function.
8063
8064 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8065
8066 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8067
8068 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8069 printf-like functions.
8070 (tiff_load): Add casts to remove these marks before passing them
8071 to system-supplied API.
8072
8073 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8074
8075 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8076 This avoids several warnings with gcc -Wstrict-overflow.
8077 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8078 directly, rather than having caller test rule sign. This avoids
8079 some unnecessary tests.
8080 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8081 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8082 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8083
8084 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8085 (xfont_open): Avoid unnecessary tests.
8086
8087 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8088
8089 * composite.h, composite.c (composition_gstring_put_cache):
8090 Use EMACS_INT, not int, for length.
8091
8092 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8093 breaking out part of COMPOSITION_DECODE_RULE.
8094 (COMPOSITION_DECODE_RULE): Use it.
8095 * composite.c (get_composition_id): Remove unused local vars,
8096 by using the new macro.
8097
8098 * textprop.c (set_text_properties_1): Change while to do-while,
8099 since the condition is always true at first.
8100
8101 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8102 (interval_deletion_adjustment): Return unsigned value.
8103 All uses changed.
8104
8105 * process.c (list_processes_1, create_pty, read_process_output):
8106 (exec_sentinel): Remove vars that were set but not used.
8107 (create_pty): Remove unnecessary "volatile"s.
8108 (Fnetwork_interface_info): Avoid possibility of int overflow.
8109 (read_process_output): Do adaptive read buffering even if carryover.
8110 (read_process_output): Simplify nbytes computation if buffered.
8111
8112 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8113
8114 * syntax.c (scan_words): Remove var that was set but not used.
8115 (update_syntax_table): Use unsigned instead of int.
8116
8117 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8118 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8119 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8120
8121 * print.c (print_error_message): Avoid int overflow.
8122
8123 * font.c (font_list_entities): Redo for clarity,
8124 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8125
8126 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8127 (font_score): Avoid potential overflow in diff calculation.
8128
8129 * fns.c (substring_both): Remove var that is set but not used.
8130 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8131
8132 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8133
8134 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8135 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8136 can always succeed if overflow has undefined behavior.
8137
8138 * search.c (boyer_moore, wordify): Remove vars set but not used.
8139 (wordify): Omit three unnecessary tests.
8140
8141 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8142 All callers changed. This avoids the need for an unused var.
8143
8144 * casefiddle.c (casify_region): Remove var that is set but not used.
8145
8146 * dired.c (file_name_completion): Remove var that is set but not used.
8147
8148 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8149
8150 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8151 (Finsert_file_contents): Remove unnecessary code checking fd.
8152
8153 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8154 Check for integer overflow on size calculations.
8155
8156 * buffer.c (Fprevious_overlay_change): Remove var that is set
8157 but not used.
8158
8159 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8160 Remove vars that are set but not used.
8161 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8162 (timer_check_2): Mark vars as initialized.
8163
8164 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8165
8166 * image.c (lookup_image): Remove var that is set but not used.
8167 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8168
8169 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8170 that are set but not used.
8171
8172 * xfns.c (make_invisible_cursor): Don't return garbage
8173 if XCreateBitmapFromData fails (Bug#8410).
8174
8175 * xselect.c (x_get_local_selection, x_handle_property_notify):
8176 Remove vars that are set but not used.
8177
8178 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8179 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8180
8181 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8182 Remove var that is set but not used.
8183 (scroll_bar_windows_size): Now size_t, not int.
8184 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8185 Check for overflow.
8186
8187 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8188 (map_tty_color) [!defined MSDOS]: Likewise.
8189
8190 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8191
8192 * coding.c: Remove vars that are set but not used.
8193 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8194 All callers changed.
8195 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8196 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8197 (decode_coding_charset): Remove vars that are set but not used.
8198
8199 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8200 that is set but not used.
8201
8202 * print.c (print_object): Remove var that is set but not used.
8203
8204 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8205 The gnulib version avoids calling malloc in the usual case,
8206 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8207 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8208 * filelock.c (current_lock_owner): Likewise.
8209 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8210 * sysdep.c: Include allocator.h, careadlinkat.h.
8211 (emacs_no_realloc_allocator): New static constant.
8212 (emacs_readlink): New function.
8213 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8214 ../lib/careadlinkat.h.
8215
8216 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8217
8218 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8219 first non-nil return value).
8220
8221 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8222
8223 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8224 if not defined (Bug#8403).
8225
8226 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8227
8228 * xdisp.c (display_count_lines): Remove parameter `start',
8229 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8230 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8231 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8232 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8233 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8234 and thereabouts. All callers changed.
8235 (get_per_char_metric): Remove parameter `f', unused since
8236 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8237
8238 2011-04-02 Jim Meyering <meyering@redhat.com>
8239
8240 do not dereference NULL upon failed strdup
8241 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8242 (ns_get_family): Likewise.
8243
8244 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8245
8246 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8247
8248 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8249
8250 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8251 later (Bug#8403).
8252
8253 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8254
8255 Add lexical binding.
8256
8257 * window.c (Ftemp_output_buffer_show): New fun.
8258 (Fsave_window_excursion):
8259 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8260
8261 * lread.c (lisp_file_lexically_bound_p): New function.
8262 (Fload): Bind Qlexical_binding.
8263 (readevalloop): Remove `evalfun' arg.
8264 Bind Qinternal_interpreter_environment.
8265 (Feval_buffer): Bind Qlexical_binding.
8266 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8267 Mark as dynamic.
8268 (syms_of_lread): Declare `lexical-binding'.
8269
8270 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8271
8272 * keyboard.c (eval_dyn): New fun.
8273 (menu_item_eval_property): Use it.
8274
8275 * image.c (parse_image_spec): Use Ffunctionp.
8276
8277 * fns.c (concat, mapcar1): Accept byte-code-functions.
8278
8279 * eval.c (Fsetq): Handle lexical vars.
8280 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8281 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8282 (FletX, Flet): Obey lexical binding.
8283 (Fcommandp): Handle closures.
8284 (Feval): New `lexical' arg.
8285 (eval_sub): New function extracted from Feval. Use it almost
8286 everywhere where Feval was used. Look up vars in lexical env.
8287 Handle closures.
8288 (Ffunctionp): Move from subr.el.
8289 (Ffuncall): Handle closures.
8290 (apply_lambda): Remove `eval_flags'.
8291 (funcall_lambda): Handle closures and new byte-code-functions.
8292 (Fspecial_variable_p): New function.
8293 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8294 but without exporting it to Lisp.
8295
8296 * doc.c (Fdocumentation, store_function_docstring):
8297 * data.c (Finteractive_form): Handle closures.
8298
8299 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8300 interactive spec.
8301
8302 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8303 New byte-codes.
8304 (exec_byte_code): New function extracted from Fbyte_code to handle new
8305 calling convention for byte-code-functions. Add new byte-codes.
8306
8307 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8308
8309 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8310
8311 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8312
8313 * xdisp.c (redisplay_internal): Fix prototype.
8314
8315 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8316
8317 * xdisp.c (SCROLL_LIMIT): New macro.
8318 (try_scrolling): Use it when setting scroll_limit.
8319 Limit scrolling to 100 screen lines.
8320 (redisplay_window): Even when falling back on "recentering",
8321 position point in the window according to scroll-conservatively,
8322 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8323
8324 (try_scrolling): When point is above the window, allow searching
8325 as far as scroll_max, or one screenful, to compute vertical
8326 distance from PT to the scroll margin position. This prevents
8327 try_scrolling from unnecessarily failing when
8328 scroll-conservatively is set to a value slightly larger than the
8329 window height. Clean up the case of PT below the margin at bottom
8330 of window: scroll_max can no longer be INT_MAX. When aggressive
8331 scrolling is in use, don't let point enter the opposite scroll
8332 margin as result of the scroll.
8333 (syms_of_xdisp) <scroll-conservatively>: Document the
8334 threshold of 100 lines for never-recentering scrolling.
8335
8336 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8337
8338 * dispextern.h (move_it_by_lines):
8339 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8340 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8341 (message_log_check_duplicate): Remove parameters `prev_bol' and
8342 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8343 (redisplay_internal): Remove parameter `preserve_echo_area',
8344 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8345
8346 * indent.c (Fvertical_motion):
8347 * window.c (window_scroll_pixel_based, Frecenter):
8348 Don't pass `need_y_p' to `move_it_by_lines'.
8349
8350 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8351
8352 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8353 steal a few bits to be more compact.
8354 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8355 Remove unneeded casts.
8356
8357 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8358
8359 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8360
8361 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8362 binding" message (bug#7967).
8363
8364 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8365
8366 Fix more problems found by GCC 4.6.0's static checks.
8367
8368 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8369 Remove unused local var.
8370
8371 * editfns.c (Fmessage_box): Remove unused local var.
8372
8373 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8375 Omit unused local vars.
8376 * window.c (shrink_windows): Omit unused local var.
8377 * menu.c (digest_single_submenu): Omit unused local var.
8378 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8379 Omit unused local var.
8380
8381 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8382 Don't assume string length fits in int.
8383 (keyremap_step, read_key_sequence): Use size_t for sizes.
8384 (read_key_sequence): Don't check last_real_key_start redundantly.
8385
8386 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8387 instead of alloca (Bug#8344).
8388
8389 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8390 (Fbacktrace_frame): Don't assume nframes fits in int.
8391
8392 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8393
8394 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8395 concerns.
8396
8397 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8398
8399 * cm.c (calccost): Turn while-do into do-while, for clarity.
8400
8401 * keyboard.c (syms_of_keyboard): Use the same style as later
8402 in this function when indexing through an array. This also
8403 works around GCC bug 48267.
8404
8405 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8406
8407 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8408
8409 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8410 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8411
8412 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8413 This avoids undefined behavior on integer overflow, and is a bit
8414 more convenient anyway since it is compared to a size_t variable.
8415
8416 Variadic C functions now count arguments with size_t, not int.
8417 This avoids an unnecessary limitation on 64-bit machines, which
8418 caused (substring ...) to crash on large vectors (Bug#8344).
8419 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8420 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8421 All variadic functions and their callers changed accordingly.
8422 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8423 * data.c (arith_driver, float_arith_driver): Likewise.
8424 * editfns.c (general_insert_function): Likewise.
8425 * eval.c (struct backtrace.nargs, interactive_p)
8426 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8427 (funcall_lambda, mark_backtrace): Likewise.
8428 * fns.c (concat): Likewise.
8429 * frame.c (x_set_frame_parameters): Likewise.
8430 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8431 0 if not found, not -1. All callers changed.
8432
8433 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8434 (stack_copy_size): Now size_t, not int.
8435 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8436
8437 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8438
8439 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8440 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8441 All callers changed.
8442
8443 * lisp.h (multibyte_char_to_unibyte):
8444 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8445 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8446 * character.h (CHAR_TO_BYTE8):
8447 * cmds.c (internal_self_insert):
8448 * editfns.c (general_insert_function):
8449 * keymap.c (push_key_description):
8450 * search.c (Freplace_match):
8451 * xdisp.c (message_dolog, set_message_1): All callers changed.
8452
8453 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8454
8455 * keyboard.c (safe_run_hook_funcall): New function.
8456 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8457 don't set the hook to nil, but remove the offending function instead.
8458 (Qcommand_hook_internal): Remove, unused.
8459 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8460 Vcommand_hook_internal.
8461
8462 * eval.c (enum run_hooks_condition): Remove.
8463 (funcall_nil, funcall_not): New functions.
8464 (run_hook_with_args): Call each function through a `funcall' argument.
8465 Remove `cond' argument, now redundant.
8466 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8467 (Frun_hook_with_args_until_failure): Adjust accordingly.
8468 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8469
8470 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8471
8472 * dispextern.h (string_buffer_position): Remove declaration.
8473
8474 * print.c (strout): Remove parameter `multibyte', unused since
8475 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8476
8477 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8478 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8479 All callers changed.
8480
8481 * w32.c (_wsa_errlist): Use braces for struct initializers.
8482
8483 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8484 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8485 All callers changed.
8486 (string_buffer_position): Likewise. Also, make static (it's never
8487 used outside xdisp.c).
8488 (cursor_row_p): Remove parameter `w', unused since
8489 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8490 (decode_mode_spec): Remove parameter `precision', introduced during
8491 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8492 All callers changed.
8493
8494 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8495
8496 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8497
8498 2011-03-27 Anders Lindgren <andlind@gmail.com>
8499
8500 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8501 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8502 (ns_update_auto_hide_menu_bar): New functions.
8503 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8504 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8505 ns_constrain_all_frames.
8506 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8507 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8508
8509 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8510
8511 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8512
8513 2011-03-27 Glenn Morris <rgm@gnu.org>
8514
8515 * syssignal.h: Replace RETSIGTYPE with void.
8516 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8517 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8518 Replace SIGTYPE with void everywhere.
8519 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8520 * s/template.h (SIGTYPE): Remove commented out definition.
8521
8522 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8523
8524 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8525 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8526
8527 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8528
8529 * w32.c (read_unc_volume): Use parameter `henum', instead of
8530 global variable `wget_enum_handle'.
8531
8532 * keymap.c (describe_vector): Remove parameters `indices' and
8533 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8534 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8535
8536 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8537
8538 * keyboard.c (timer_check): Remove parameter `do_it_now',
8539 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8540 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8541 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8542
8543 * keyboard.c (read_char):
8544 * w32menu.c (w32_menu_display_help):
8545 * xmenu.c (show_help_event, menu_help_callback):
8546 Adjust calls to `show_help_echo'.
8547
8548 * gtkutil.c (xg_maybe_add_timer):
8549 * keyboard.c (readable_events):
8550 * process.c (wait_reading_process_output):
8551 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8552
8553 * insdel.c (adjust_markers_gap_motion):
8554 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8555 (gap_left, gap_right): Don't call it.
8556
8557 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8558
8559 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8560 incurred during fontification.
8561
8562 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8563
8564 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8565 (DEFVAR_PER_BUFFER): Don't pass it.
8566
8567 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8568 (scrolling_window): Don't pass it.
8569
8570 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8571
8572 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8573
8574 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8575 and `suffix'.
8576 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8577 of variables specific to SELinux and computation of `encoded_absname'.
8578
8579 * image.c (XPutPixel): Remove unused variable `height'.
8580
8581 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8582
8583 * unexw32.c (get_section_info): Remove unused variable `section'.
8584
8585 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8586 (system_process_attributes): Remove unused variable `sess'.
8587 (sys_read): Remove unused variable `err'.
8588
8589 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8590 (w32_wnd_proc): Remove unused variable `isdead'.
8591 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8592 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8593 (x_create_tip_frame): Remove unused variable `tem'.
8594
8595 * w32inevt.c (w32_console_read_socket):
8596 Remove unused variable `no_events'.
8597
8598 * w32term.c (x_draw_composite_glyph_string_foreground):
8599 Remove unused variable `width'.
8600
8601 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8602
8603 * w32term.c (x_set_glyph_string_clipping):
8604 Don't pass uninitialized region to CombineRgn.
8605
8606 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8607
8608 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8609 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8610 (Fx_close_connection): Remove unused variable `i'.
8611
8612 * w32font.c (w32font_draw): Return number of glyphs.
8613 (w32font_open_internal): Remove unused variable `i'.
8614 (w32font_driver): Add missing initializer.
8615
8616 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8617 (fill_in_menu): Remove unused variable `items_added'.
8618
8619 * w32term.c (last_mouse_press_frame): Remove static global variable.
8620 (w32_clip_to_row): Remove unused variable `f'.
8621 (x_delete_terminal): Remove unused variable `i'.
8622
8623 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8624 (NOTHING): Remove unused static global variable.
8625 (uniscribe_check_otf): Remove unused variable `table'.
8626 (uniscribe_font_driver): Add missing initializers.
8627
8628 2011-03-23 Julien Danjou <julien@danjou.info>
8629
8630 * term.c (Fsuspend_tty, Fresume_tty):
8631 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8632 * window.c (temp_output_buffer_show):
8633 * insdel.c (signal_before_change):
8634 * frame.c (Fhandle_switch_frame):
8635 * fileio.c (Fdo_auto_save):
8636 * emacs.c (Fkill_emacs):
8637 * editfns.c (save_excursion_restore):
8638 * cmds.c (internal_self_insert):
8639 * callint.c (Fcall_interactively):
8640 * buffer.c (Fkill_all_local_variables):
8641 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8642 Use Frun_hooks.
8643 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8644 unconditionally since it does the check itself.
8645
8646 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8647
8648 Fix more problems found by GCC 4.5.2's static checks.
8649
8650 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8651 the first time through the loop, since we know p0 < p1 then.
8652 This also avoids a gcc -Wstrict-overflow warning.
8653
8654 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8655 leading to a memory leak, possible in functions like
8656 load_charset_map_from_file that can allocate an unbounded number
8657 of objects (Bug#8318).
8658
8659 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8660 that could (at least in theory) be that large.
8661
8662 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8663 This is less likely to overflow, and avoids undefined behavior if
8664 overflow does occur. All callers changed. Use strtoul to scan
8665 for the unsigned long integer.
8666 (pint2hrstr): Simplify and tune code slightly.
8667 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8668
8669 * scroll.c (do_scrolling): Work around GCC bug 48228.
8670 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8671
8672 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8673 This also avoids a warning with gcc -Wstrict-overflow.
8674 (validate_x_resource_name): Simplify count usage.
8675 This also avoids a warning with gcc -Wstrict-overflow.
8676
8677 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8678 fail (Bug#8306).
8679
8680 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8681
8682 * process.c (Fmake_network_process): Use socklen_t, not int,
8683 where POSIX says socklen_t is required in portable programs.
8684 This fixes a porting bug on hosts like 64-bit HP-UX, where
8685 socklen_t is wider than int (Bug#8277).
8686 (Fmake_network_process, server_accept_connection):
8687 (wait_reading_process_output, read_process_output):
8688 Likewise.
8689
8690 * process.c: Rename or move locals to avoid shadowing.
8691 (list_processes_1, Fmake_network_process):
8692 (read_process_output_error_handler, exec_sentinel_error_handler):
8693 Rename or move locals.
8694 (Fmake_network_process): Define label "retry_connect" only if needed.
8695 (Fnetwork_interface_info): Fix pointer signedness.
8696 (process_send_signal): Add cast to avoid pointer signedness problem.
8697 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8698 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8699
8700 Make tparam.h and terminfo.c consistent.
8701 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8702 Include tparam.h instead, since it declares them.
8703 * cm.h (PC): Remove extern decl; tparam.h now does this.
8704 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8705 * terminfo.c: Include tparam.h, to check interfaces.
8706 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8707 (tparam): Adjust signature to match interface in tparam.h;
8708 this removes some undefined behavior. Check that outstring and len
8709 are zero, which they always are with Emacs.
8710 * tparam.h (PC, BC, UP): New extern decls.
8711
8712 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8713 (xftfont_open): Rename locals to avoid shadowing.
8714
8715 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8716 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8717 (OTF_TAG_SYM): Omit macro if not needed.
8718 (ftfont_list): Remove unused local.
8719 (get_adstyle_property, ftfont_pattern_entity):
8720 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8721 Rename locals to avoid shadowing.
8722
8723 * xfont.c (xfont_list_family): Mark var as initialized.
8724
8725 * xml.c (make_dom): Now static.
8726
8727 * composite.c (composition_compute_stop_pos): Rename local to
8728 avoid shadowing.
8729 (composition_reseat_it): Remove unused locals.
8730 (find_automatic_composition, composition_adjust_point): Likewise.
8731 (composition_update_it): Mark var as initialized.
8732 (find_automatic_composition): Mark vars as initialized,
8733 with a FIXME (Bug#8290).
8734
8735 character.h: Rename locals to avoid shadowing.
8736 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8737 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8738 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8739 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8740 to avoid shadowing.
8741
8742 * textprop.c (property_change_between_p): Remove; unused.
8743
8744 * intervals.c (interval_start_pos): Now static.
8745
8746 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8747
8748 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8749 Rename locals to avoid shadowing.
8750
8751 * sound.c (wav_play, au_play, Fplay_sound_internal):
8752 Fix pointer signedness.
8753 (alsa_choose_format): Remove unused local var.
8754 (wav_play): Initialize a variable to 0, to prevent undefined
8755 behavior (Bug#8278).
8756
8757 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8758
8759 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8760
8761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8762 clobbering (Bug#8298).
8763 * sysdep.c (sys_subshell): Likewise.
8764 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8765
8766 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8767 This should get cleaned up, so that child_setup has the
8768 same signature on all platforms.
8769
8770 * callproc.c (call_process_cleanup): Now static.
8771 (relocate_fd): Rename locals to avoid shadowing.
8772
8773 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8774
8775 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8776 not to be necessary, and produces flickering.
8777
8778 2011-03-20 Glenn Morris <rgm@gnu.org>
8779
8780 * config.in: Remove file.
8781
8782 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8783
8784 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8785 are now in src/globals.h.
8786 (syms_of_minibuf): Remove spurious & from previous change.
8787
8788 2011-03-20 Leo Liu <sdl.web@gmail.com>
8789
8790 * minibuf.c (completing-read-function): New variable.
8791 (completing-read-default): Rename from completing-read.
8792 (completing-read): Call completing-read-function.
8793
8794 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8795
8796 * xfaces.c (Fx_load_color_file):
8797 Read color file from absolute filename (bug#8250).
8798
8799 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8800
8801 * makefile.w32-in: Update dependencies.
8802
8803 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8804
8805 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8806
8807 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8808
8809 Fix more problems found by GCC 4.5.2's static checks.
8810
8811 * process.c (make_serial_process_unwind, send_process_trap):
8812 (sigchld_handler): Now static.
8813
8814 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8815 That way, the code declares only the vars that it needs.
8816 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8817 * s/cygwin.h (PTY_ITERATION): Likewise.
8818 * s/darwin.h (PTY_ITERATION): Likewise.
8819 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8820
8821 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8822 * process.c (allocate_pty): Don't declare stb unless it's needed.
8823
8824 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8825 (CONSTANTLIM): Remove; unused.
8826 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8827 Define only if needed.
8828
8829 * unexelf.c (unexec): Name an expression,
8830 to avoid gcc -Wbad-function-cast warning.
8831 Use a different way to cause a compilation error if anyone uses
8832 n rather than nn, a way that does not involve shadowing.
8833 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8834
8835 * deps.mk (unexalpha.o): Remove; unused.
8836
8837 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8838 * unexec.h: New file.
8839 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8840 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8841 Depend on unexec.h.
8842 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8843 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8844 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8845 Change as necessary to match prototype in unexec.h.
8846
8847 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8848 shadowing.
8849 (back_comment, skip_chars): Mark vars as initialized.
8850
8851 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8852 Rename locals to avoid shadowing.
8853
8854 * lread.c (read1): Rewrite so as not to use empty "else".
8855 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8856
8857 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8858
8859 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8860 warning when compiling print.c.
8861
8862 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8863 instead of using an uninitialized var.
8864 (font_sort_entities): Mark var as initialized.
8865
8866 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8867
8868 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8869 pointers to constants.
8870 (font_parse_fcname): Remove unused vars.
8871 (font_delete_unmatched): Now static.
8872 (font_get_spec): Remove; unused.
8873 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8874 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8875 Rename or move locals to avoid shadowing.
8876
8877 * fns.c (require_nesting_list, require_unwind): Now static.
8878 (Ffillarray): Rename locals to avoid shadowing.
8879
8880 * floatfns.c (domain_error2): Define only if needed.
8881 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8882
8883 * alloc.c (mark_backtrace): Move decl from here ...
8884 * lisp.h: ... to here, so that it can be checked.
8885
8886 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8887 (Fdefvar): Rewrite so as not to use empty "else".
8888 (lisp_indirect_variable): Name an expression,
8889 to avoid gcc -Wbad-function-cast warning.
8890 (Fdefvar): Rename locals to avoid shadowing.
8891
8892 * callint.c (quotify_arg, quotify_args): Now static.
8893 (Fcall_interactively): Rename locals to avoid shadowing.
8894 Use const pointer when appropriate.
8895
8896 * lisp.h (get_system_name, get_operating_system_release):
8897 Move decls here, to check interfaces.
8898 * process.c (get_operating_system_release): Move decl to lisp.h.
8899 * xrdb.c (get_system_name): Likewise.
8900 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8901 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8902 some of which prompt warnings from gcc -Wbad-function-cast.
8903 (Fformat_time_string, Fencode_time, Finsert_char):
8904 (Ftranslate_region_internal, Fformat):
8905 Rename or remove local vars to avoid shadowing.
8906 (Ftranslate_region_internal): Mark var as initialized.
8907
8908 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8909 avoid shadowing.
8910
8911 * lisp.h (eassert): Check that the argument compiles, even if
8912 ENABLE_CHECKING is not defined.
8913
8914 * data.c (Findirect_variable): Name an expression, to avoid
8915 gcc -Wbad-function-cast warning.
8916 (default_value, arithcompare, arith_driver, arith_error): Now static.
8917 (store_symval_forwarding): Rename local to avoid shadowing.
8918 (Fmake_variable_buffer_local, Fmake_local_variable):
8919 Mark variables as initialized.
8920 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8921
8922 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8923 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8924 Rename locals to avoid shadowing.
8925 (mark_stack): Move local variables into the #ifdef region where
8926 they're used.
8927 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8928 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8929 needed otherwise.
8930 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8931 (GC_STRING_CHARS): Remove; not used.
8932 (Fmemory_limit): Cast sbrk's returned value to char *.
8933
8934 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8935 avoids undefined behavior in theory.
8936
8937 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8938
8939 Use functions, not macros, for up- and down-casing (Bug#8254).
8940 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8941 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8942 to use the following functions instead of these macros.
8943 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8944 EMACS_INT, since callers assume the returned value fits in int.
8945 (upcase1): Likewise, for UPCASE_TABLE.
8946 (uppercasep, lowercasep, upcase): New static inline functions.
8947 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8948 the race-condition problem in the old DOWNCASE.
8949
8950 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8951 Rename locals to avoid shadowing.
8952 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8953 (regex_compile, re_search_2, re_match_2_internal):
8954 Remove unused local vars.
8955 (FREE_VAR): Rewrite so as not to use empty "else",
8956 which gcc can warn about.
8957 (regex_compile, re_match_2_internal): Mark locals as initialized.
8958 (RETALLOC_IF): Define only if needed.
8959 (WORDCHAR_P): Likewise. This one is never needed, but is used
8960 only in a comment talking about a compiler bug, so put inside
8961 the #if 0 of that comment.
8962 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8963 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8964 Remove; unused.
8965
8966 * search.c (boyer_moore): Rename locals to avoid shadowing.
8967 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8968 (PREV_CHAR_BOUNDARY): Likewise.
8969
8970 * search.c (simple_search): Remove unused var.
8971
8972 * dired.c (compile_pattern): Move decl from here ...
8973 * lisp.h: ... to here, so that it can be checked.
8974 (struct re_registers): New forward decl.
8975
8976 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8977
8978 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8979 All uses changed.
8980 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8981 Rename locals to avoid shadowing.
8982 (Fvertical_motion): Mark locals as initialized.
8983
8984 * casefiddle.c (casify_object, casify_region): Now static.
8985 (casify_region): Mark local as initialized.
8986
8987 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8988
8989 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8990 New macros, so that the caller can use some names other than
8991 gcpro1, gcpro2, etc.
8992 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8993 of the new macros.
8994 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8995 argument, for consistency with GCPRO2_VAR, etc: it is now the
8996 prefix of the variable, not the variable itself. All uses
8997 changed.
8998 * dired.c (directory_files_internal, file_name_completion):
8999 Rename locals to avoid shadowing.
9000
9001 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9002 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9003 dired.c's scmp function, had undefined behavior.
9004 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9005 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9006 * buffer.h: ... to here, because these macros use current_buffer,
9007 and the new implementation with inline functions needs to have
9008 current_buffer in scope now, rather than later when the macros
9009 are used.
9010 (downcase, upcase1): New static inline functions.
9011 (DOWNCASE, UPCASE1): Reimplement using these functions.
9012 This avoids undefined behavior in expressions like
9013 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9014 from race conditions in accessing the global variables
9015 case_temp1 and case_temp2.
9016 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9017 * lisp.h (case_temp1, case_temp2): Remove their decls.
9018 * character.h (ASCII_CHAR_P): Move from here ...
9019 * lisp.h: ... to here, so that the inline functions mentioned
9020 above can use them.
9021
9022 * dired.c (directory_files_internal_unwind): Now static.
9023
9024 * fileio.c (file_name_as_directory, directory_file_name):
9025 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9026 Now static.
9027 (file_name_as_directory): Use const pointers when appropriate.
9028 (Fexpand_file_name): Likewise. In particular, newdir might
9029 point at constant storage, so make it a const pointer.
9030 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9031 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9032 signedness issues.
9033 (Fset_file_times, Finsert_file_contents, auto_save_error):
9034 Rename locals to avoid shadowing.
9035
9036 * minibuf.c (choose_minibuf_frame_1): Now static.
9037 (Ftry_completion, Fall_completions): Rename or remove locals
9038 to avoid shadowing.
9039
9040 * marker.c (bytepos_to_charpos): Remove; unused.
9041
9042 * lisp.h (verify_bytepos, count_markers): New decls,
9043 so that gcc does not warn that these functions aren't declared.
9044
9045 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9046 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9047 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9048 (copy_text): Remove unused local var.
9049
9050 * filelock.c (within_one_second): Now static.
9051 (lock_file_1): Rename local to avoid shadowing.
9052
9053 * buffer.c (fix_overlays_before): Mark locals as initialized.
9054 (fix_start_end_in_overlays): Likewise. This function should be
9055 simplified by using pointers-to-pointers, but that's a different
9056 matter.
9057 (switch_to_buffer_1): Now static.
9058 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9059 (report_overlay_modification): Rename locals to avoid shadowing.
9060
9061 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9062 Fix pointer signedness issue.
9063 (sys_subshell): Mark local as volatile if checking for lint,
9064 to suppress a gcc -Wclobbered warning that does not seem to be right.
9065 (MAXPATHLEN): Define only if needed.
9066
9067 * process.c (serial_open, serial_configure): Move decls from here ...
9068 * systty.h: ... to here, so that they can be checked.
9069
9070 * fns.c (get_random, seed_random): Move extern decls from here ...
9071 * lisp.h: ... to here, so that they can be checked.
9072
9073 * sysdep.c (reset_io): Now static.
9074 (wait_for_termination_signal): Remove; unused.
9075
9076 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9077 (copy_keymap_item, append_key, push_text_char_description):
9078 Now static.
9079 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9080 (DENSE_TABLE_SIZE): Remove; unused.
9081 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9082 (describe_map_tree):
9083 Rename locals to avoid shadowing.
9084
9085 * keyboard.c: Declare functions static if they are not used elsewhere.
9086 (echo_char, echo_dash, cmd_error, top_level_2):
9087 (poll_for_input, handle_async_input): Now static.
9088 (read_char, kbd_buffer_get_event, make_lispy_position):
9089 (make_lispy_event, make_lispy_movement, apply_modifiers):
9090 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9091 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9092 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9093 (read_key_sequence, read_char): Mark locals as initialized.
9094 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9095
9096 * keyboard.h (make_ctrl_char): New decl.
9097 (mark_kboards): Move decl here ...
9098 * alloc.c (mark_kboards): ... from here.
9099
9100 * lisp.h (force_auto_save_soon): New decl.
9101
9102 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9103 (DEFINE_DUMMY_FUNCTION): New macro.
9104 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9105 Use it.
9106 (main): Add casts to avoid warnings
9107 if GCC considers string literals to be constants.
9108
9109 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9110
9111 * dbusbind.c: Pointer signedness fixes.
9112 (xd_signature, xd_append_arg, xd_initialize):
9113 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9114 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9115 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9116 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9117
9118 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9119 if GCC considers string literals to be constants.
9120 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9121
9122 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9123
9124 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9125 (print_preprocess, print_object): New macro to fix last change.
9126
9127 * print.c (print_preprocess): Don't forget font objects.
9128
9129 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9130
9131 * emacs.c (USAGE3): Doc fixes.
9132
9133 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9134
9135 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9136 structure.
9137
9138 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9139
9140 * lisp.h (VWindow_system, Qfile_name_history):
9141 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9142 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9143 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9144
9145 * w32select.c: Don't #include "keyboard.h".
9146 (run_protected): Add extern declaration for waiting_for_input.
9147
9148 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9149 * w32console.c (detect_input_pending, read_input_pending)
9150 (encode_terminal_code):
9151 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9152 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9153 (w32_system_caret_y, Qfile_name_history):
9154 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9155 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9156 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9157 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9158 * w32proc.c (Qlocal, report_file_error):
9159 * w32term.c (Vwindow_system, updating_frame):
9160 * w32uniscribe.c (initialized, uniscribe_font_driver):
9161 Remove unneeded extern declarations.
9162
9163 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9164
9165 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9166
9167 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9168
9169 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9170 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9171 These macros can no longer be used for assignment.
9172
9173 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9174 Assign struct members directly, instead of using BUF_BEGV etc.
9175 (record_buffer_markers, fetch_buffer_markers): New functions for
9176 recording and fetching special buffer markers.
9177 (set_buffer_internal_1, set_buffer_temp): Use them.
9178
9179 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9180
9181 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9182
9183 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9184 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9185
9186 * xdisp.c (hscroll_window_tree):
9187 (reconsider_clip_changes): Use PT instead of BUF_PT.
9188
9189 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9190
9191 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9192 $(EMACS_ROOT)/lib/intprops.h.
9193
9194 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9195
9196 Fix more problems found by GCC 4.5.2's static checks.
9197
9198 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9199 to unsigned char * to avoid compiler diagnostic.
9200 (xg_free_frame_widgets): Make it clear that a local variable is
9201 needed only if USE_GTK_TOOLTIP.
9202 (gdk_window_get_screen): Make it clear that this macro is needed
9203 only if USE_GTK_TOOLTIP.
9204 (int_gtk_range_get_value): New function, which avoids a diagnostic
9205 from gcc -Wbad-function-cast.
9206 (xg_set_toolkit_scroll_bar_thumb): Use it.
9207 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9208 diagnostic from gcc -Wbad-function-cast.
9209 (get_utf8_string, xg_get_file_with_chooser):
9210 Rename locals to avoid shadowing.
9211 (create_dialog): Move locals to avoid shadowing.
9212
9213 * xgselect.c (xg_select): Remove unused var.
9214
9215 * image.c (four_corners_best): Mark locals as initialized.
9216 (gif_load): Initialize transparent_p to zero (Bug#8238).
9217 Mark another local as initialized.
9218 (my_png_error, my_error_exit): Mark with NO_RETURN.
9219
9220 * image.c (clear_image_cache): Now static.
9221 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9222 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9223 (x_edge_detection): Remove unnecessary cast that
9224 gcc -Wbad-function-cast diagnoses.
9225 (gif_load): Fix pointer signedness.
9226 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9227 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9228
9229 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9230
9231 Improve quality of tests for time stamp overflow.
9232 For example, without this patch (encode-time 0 0 0 1 1
9233 1152921504606846976) returns the obviously-bogus value (-948597
9234 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9235 reports time overflow. See
9236 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9237 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9238 * editfns.c: Include limits.h and intprops.h.
9239 (TIME_T_MIN, TIME_T_MAX): New macros.
9240 (time_overflow): Move earlier, to before first use.
9241 (hi_time, lo_time): New functions, for an accurate test for
9242 out-of-range times.
9243 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9244 (Fget_internal_run_time): Don't assume time_t fits in int.
9245 (make_time): Use list2 instead of Fcons twice.
9246 (Fdecode_time): More accurate test for out-of-range times.
9247 (check_tm_member): New function.
9248 (Fencode_time): Use it, to test for out-of-range times.
9249 (lisp_time_argument): Don't rely on undefined left-shift and
9250 right-shift behavior when checking for time stamp overflow.
9251
9252 * editfns.c (time_overflow): New function, refactoring common code.
9253 (Fformat_time_string, Fdecode_time, Fencode_time):
9254 (Fcurrent_time_string): Use it.
9255
9256 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9257 * dired.c (make_time): Move to ...
9258 * editfns.c (make_time): ... here.
9259 * systime.h: Note the move.
9260
9261 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9262
9263 * fringe.c (update_window_fringes): Remove unused variables.
9264
9265 * unexmacosx.c (copy_data_segment): Also copy __got section.
9266 (Bug#8223)
9267
9268 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9269
9270 * termcap.c [MSDOS]: Include "msdos.h".
9271 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9272 Constify `char *' arguments and their references according to
9273 prototypes in tparam.h.
9274
9275 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9276
9277 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9278 Adapt all references accordingly.
9279
9280 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9281
9282 2011-03-11 Tom Tromey <tromey@redhat.com>
9283
9284 * buffer.c (syms_of_buffer): Remove obsolete comment.
9285
9286 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9287
9288 * termhooks.h (encode_terminal_code): Declare prototype.
9289
9290 * msdos.c (encode_terminal_code): Don't declare prototype.
9291
9292 * term.c (encode_terminal_code): Now external again, used by
9293 w32console.c and msdos.c.
9294
9295 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9296 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9297
9298 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9299
9300 Fix some minor problems found by GCC 4.5.2's static checks.
9301
9302 * fringe.c (update_window_fringes): Mark locals as initialized
9303 (Bug#8227).
9304 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9305
9306 * alloc.c (mark_fringe_data): Move decl from here ...
9307 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9308 to check its interface.
9309 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9310
9311 * fontset.c (free_realized_fontset): Now static.
9312 (Fset_fontset_font): Rename local to avoid shadowing.
9313 (fontset_font): Mark local as initialized.
9314 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9315
9316 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9317
9318 * xselect.c (x_disown_buffer_selections): Remove; not used.
9319 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9320 (x_own_selection, Fx_disown_selection_internal): Rename locals
9321 to avoid shadowing.
9322 (x_handle_dnd_message): Remove local to avoid shadowing.
9323
9324 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9325 so that the caller can use some name other than gcpro1.
9326 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9327 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9328 (Fx_backspace_delete_keys_p):
9329 Use them to avoid shadowing, and rename vars to avoid shadowing.
9330 (x_decode_color, x_set_name, x_window): Now static.
9331 (Fx_create_frame): Add braces to silence GCC warning.
9332 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9333 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9334 Remove unused locals.
9335 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9336 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9337 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9338 macros.
9339
9340 * xterm.h (x_mouse_leave): New decl.
9341
9342 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9343 Remove unused functions.
9344 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9345 (x_calc_absolute_position): Now static.
9346 (XTread_socket): Don't define label "out" unless it's used.
9347 Don't declare local "event" unless it's used.
9348 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9349 unless they are used.
9350 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9351 (x_fatal_error_signal): Remove; not used.
9352 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9353 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9354 (x_error_catcher, x_connection_closed, x_error_handler):
9355 (x_error_quitter, xembed_send_message, x_iconify_frame):
9356 (my_log_handler): Rename locals to avoid shadowing.
9357 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9358 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9359
9360 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9361 Rename or move locals to avoid shadowing.
9362 (tty_defined_color, merge_face_heights): Now static.
9363 (free_realized_faces_for_fontset): Remove; not used.
9364 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9365 does not deduce is never used uninitialized.
9366 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9367 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9368
9369 * terminal.c (store_terminal_param): Now static.
9370
9371 * xmenu.c (menu_highlight_callback): Now static.
9372 (set_frame_menubar): Remove unused local.
9373 (xmenu_show): Rename parameter to avoid shadowing.
9374 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9375 since they might point to immutable storage.
9376 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9377 since it's unused otherwise.
9378
9379 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9380 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9381 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9382 avoids a gcc -Wuninitialized diagnostic.
9383 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9384 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9385 does not deduce are never used uninitialized.
9386
9387 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9388
9389 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9390 * window.c (window_loop, size_window):
9391 (run_window_configuration_change_hook, enlarge_window): Likewise.
9392
9393 * window.c (display_buffer): Now static.
9394 (size_window): Mark variables that gcc -Wuninitialized
9395 does not deduce are never used uninitialized.
9396 * window.h (check_all_windows): New decl, to forestall
9397 gcc -Wmissing-prototypes diagnostic.
9398 * dispextern.h (bidi_dump_cached_states): Likewise.
9399
9400 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9401 shadowing.
9402 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9403 Include <limits.h>.
9404 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9405 and to avoid gcc -Wuninitialized warning.
9406 (load_charset_map): Mark variables that gcc -Wuninitialized
9407 does not deduce are never used uninitialized.
9408 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9409
9410 * coding.c (coding_set_source, coding_set_destination):
9411 Use "else { /* comment */ }" rather than "else /* comment */;"
9412 for clarity, and to avoid gcc -Wempty-body warning.
9413 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9414 a block, when the outer 'i' will do.
9415 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9416 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9417 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9418 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9419 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9420 Rename locals to avoid shadowing.
9421 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9422 * coding.c (emacs_mule_char, encode_invocation_designation):
9423 Now static, since they're not used elsewhere.
9424 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9425 (decode_coding_object, encode_coding_object, detect_coding_system):
9426 (decode_coding_emacs_mule): Mark variables that gcc
9427 -Wuninitialized does not deduce are never used uninitialized.
9428 (detect_coding_iso_2022): Initialize a local variable that might
9429 be used uninitialized. Leave a FIXME because it's not clear that
9430 this initialization is needed. (Bug#8211)
9431 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9432 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9433 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9434 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9435 Remove unused macros.
9436
9437 * category.c (hash_get_category_set): Remove unused local var.
9438 (copy_category_table): Now static, since it's not used elsewhere.
9439 * character.c (string_count_byte8): Likewise.
9440
9441 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9442 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9443
9444 * chartab.c (copy_sub_char_table): Now static, since it's not used
9445 elsewhere.
9446 (sub_char_table_ref_and_range, char_table_ref_and_range):
9447 Rename locals to avoid shadowing.
9448 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9449
9450 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9451 (BIDI_BOB): Remove unused macro.
9452
9453 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9454 deduce are never used uninitialized.
9455 * term.c (encode_terminal_code): Likewise.
9456
9457 * term.c (encode_terminal_code): Now static. Remove unused local.
9458
9459 * tparam.h: New file.
9460 * term.c, tparam.h: Include it.
9461 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9462 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9463 Move these decls to tparam.h, and make them agree with what
9464 is actually in tparam.c. The previous trick of using incompatible
9465 decls in different modules does not conform to the C standard.
9466 All callers of tparam changed to use tparam's actual API.
9467 * tparam.c (tparam1, tparam, tgoto):
9468 Use const pointers where appropriate.
9469
9470 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9471 * cm.h (struct cm): Likewise.
9472 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9473 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9474 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9475 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9476 (turn_on_face, init_tty): Likewise.
9477 * termchar.h (struct tty_display_info): Likewise.
9478
9479 * term.c (term_mouse_position): Rename local to avoid shadowing.
9480
9481 * alloc.c (mark_ttys): Move decl from here ...
9482 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9483
9484 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9485
9486 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9487
9488 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9489
9490 * search.c (compile_pattern_1): Remove argument regp, unused since
9491 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9492 (compile_pattern): Don't pass it.
9493
9494 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9495
9496 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9497 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9498 for ! HAVE_GTK3.
9499 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9500
9501 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9502
9503 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9504 gdk_window_get_screen, gdk_window_get_geometry,
9505 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9506 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9507 (xg_get_pixbuf_from_pixmap): New function.
9508 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9509 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9510 Call xg_get_pixbuf_from_pixmap instead of
9511 gdk_pixbuf_get_from_drawable.
9512 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9513 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9514 (xg_check_special_colors): Use GtkStyleContext and its functions
9515 for HAVE_GTK3.
9516 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9517 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9518 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9519 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9520 Call gtk_widget_get_preferred_size.
9521 (xg_frame_resized): gdk_window_get_geometry only takes 5
9522 parameters.
9523 (xg_win_to_widget, xg_event_is_for_menubar):
9524 Call gdk_x11_window_lookup_for_display.
9525 (xg_set_widget_bg): New function.
9526 (delete_cb): New function.
9527 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9528 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9529 (xg_set_background_color): Call xg_set_widget_bg.
9530 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9531 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9532 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9533 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9534 if ! HAVE_GTK3.
9535 (update_frame_tool_bar): Call gtk_widget_hide.
9536 (xg_initialize): Use GDK_KEY_g.
9537
9538 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9539 if ! HAVE_GTK3
9540 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9541
9542 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9543 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9544 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9545
9546 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9547
9548 * w32xfns.c (select_palette): Check success of RealizePalette against
9549 GDI_ERROR, not zero.
9550
9551 See ChangeLog.11 for earlier changes.
9552
9553 ;; Local Variables:
9554 ;; coding: utf-8
9555 ;; End:
9556
9557 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9558
9559 This file is part of GNU Emacs.
9560
9561 GNU Emacs is free software: you can redistribute it and/or modify
9562 it under the terms of the GNU General Public License as published by
9563 the Free Software Foundation, either version 3 of the License, or
9564 (at your option) any later version.
9565
9566 GNU Emacs is distributed in the hope that it will be useful,
9567 but WITHOUT ANY WARRANTY; without even the implied warranty of
9568 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9569 GNU General Public License for more details.
9570
9571 You should have received a copy of the GNU General Public License
9572 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.