1 2012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3 * intervals.c (offset_intervals): Remove obsolete comment.
5 2012-08-14 Andreas Schwab <schwab@linux-m68k.org>
7 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
9 2012-08-14 Gergely Risko <gergely@risko.hu>
11 * coding.c (decode_coding): Record buffer modification before
12 disabling undo_list (Bug#11773).
14 2012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
16 Revert and cleanup some recent overlay changes.
17 * buffer.h (enum overlay_type): Remove.
18 (buffer_get_overlays, buffer_set_overlays): Likewise.
19 (buffer_set_overlays_before, buffer_set_overlays_after):
20 New function. Adjust users.
21 (unchain_both): Add eassert.
23 2012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
25 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
27 2012-08-14 Paul Eggert <eggert@cs.ucla.edu>
29 * gtkutil.c (xg_mark_data): Don't assume C99.
31 2012-08-13 Jan Djärv <jan.h.d@swipnet.se>
33 * gtkutil.c (xg_frame_tb_info): New struct.
34 (TB_INFO_KEY): New define.
35 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
36 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
37 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
39 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
40 is up to date. Otherwise store new data.
41 (free_frame_tool_bar): Free xg_frame_tb_info if present.
43 2012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
45 Use KSET for write access to Lisp_Object members of struct kboard.
46 * keyboard.h (KSET): New macro.
47 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
48 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
49 * xterm.c: Adjust users.
51 2012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
53 Use BSET for write access to Lisp_Object members of struct buffer.
54 * buffer.h (BSET): New macro.
55 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
56 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
57 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
58 * window.c, xdisp.c, xfns.c: Adjust users.
60 2012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
62 * lread.c (syms_of_lread): Initialize Vlexical_binding.
64 2012-08-11 Jan Djärv <jan.h.d@swipnet.se>
66 * nsterm.m (not_in_argv): New function.
67 (application:openFile, application:openTempFile:):
68 (application:openFileWithoutUI:, application:openFiles:): Open file
69 if not_in_argv returns non-zero (bug#12171).
71 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
72 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
73 Define for Gtk+ versions less than 3.2.
74 (xg_get_font_name): Use those functions/macros here.
75 Reported by Frans Oilinki <moilinki@gmail.com>.
77 2012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
79 * unexmacosx.c (copy_data_segment): Copy initialized data in
80 statically linked libraries from input file rather than memory.
82 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
83 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
84 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
86 2012-08-10 Glenn Morris <rgm@gnu.org>
88 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
89 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
91 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
93 Fix last change to allow compilation with low optimization levels.
94 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
95 Reported by Jan Djärv <jan.h.d@swipnet.se>.
97 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
99 Use common inline syntax in intervals.h.
100 * intervals.h (INTERVALS_INLINE): New macro.
101 Change all users from LISP_INLINE.
103 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
105 Define Qnone once for all platforms.
106 * frame.c (Qnone): Define here.
107 (syms_of_frame): DEFSYM it.
108 * lisp.h (Qnone): New declaration.
109 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
110 * xfns.c: Remove duplication. Adjust users.
112 2012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
114 Remove unused macros from intervals.h.
115 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
116 * intervals.c: Adjust comment.
118 2012-08-10 Eli Zaretskii <eliz@gnu.org>
120 * w32fns.c <w32_unicode_gui>: New static variable.
121 (globals_of_w32fns): Initialize it according to os_subtype.
122 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
125 2012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
126 Eli Zaretskii <eliz@gnu.org>
128 Fix bug #10299 with Unicode characters sent by customized
129 keyboards created by MSKLC.
130 * w32fns.c (INIT_WINDOW_CLASS): New macro.
131 (w32_init_class): Use it to initialize the Emacs class with either
132 ANSI or Unicode API calls.
133 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
135 (w32_wnd_proc): If the character code sent by WM_CHAR or
136 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
137 original message. Call DefWindowProcW on NT and later.
139 2012-08-10 Glenn Morris <rgm@gnu.org>
141 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
143 * lisp.h (DIRECTORY_SEP): Let configure set it.
145 2012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
147 Use TSET for write access to Lisp_Object slots of struct terminal.
148 * termhooks.h (TSET): New macro.
149 * coding.c, terminal.c, xselect.c: Adjust users.
151 2012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
153 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
154 the failing expression, include them in the error message.
155 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
156 * lisp.h (internal_condition_case_n): Update declaration.
158 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
160 Inline functions to examine and change buffer overlays.
161 * buffer.c (unchain_both): New function.
162 * buffer.h (buffer_get_overlays, buffer_set_overlays):
163 (buffer_has_overlays): New function.
164 (enum overlay_type): New enum.
165 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
166 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
168 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
170 Inline functions to examine and change buffer intervals.
171 * alloc.c (mark_interval_tree): Remove.
172 (MARK_INTERVAL_TREE): Simplify.
173 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
174 * intervals.c (buffer_balance_intervals): New function.
175 (graft_intervals_into_buffer): Adjust indentation.
176 (set_intervals_multibyte): Simplify.
177 * buffer.h (BUF_INTERVALS): Remove.
178 (buffer_get_intervals, buffer_set_intervals): New function.
179 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
180 * intervals.c, textprop.c: Adjust users.
182 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
184 Inline functions to examine and change string intervals.
185 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
186 (string_get_intervals, string_set_intervals): New function.
187 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
188 * lread.c, print.c, textprop.c: Adjust users.
190 2012-08-08 Glenn Morris <rgm@gnu.org>
192 * lisp.mk (lisp): Remove language/persian.elc.
194 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
197 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
198 (NULL_INTERVAL_P): Likewise. Adjust users.
199 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
200 Adjust comment. Move under #if 0.
201 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
202 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
204 2012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
206 Check total length of intervals with eassert.
207 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
208 * intervals.c: Change all users to eassert.
210 2012-08-07 Eli Zaretskii <eliz@gnu.org>
212 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
213 Rename fields to match removal of FGET and WGET and disuse of
214 INTERNAL_FIELD in Lisp_Cons.
216 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
218 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
219 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
220 name since all xname users are fixed long time ago. Do not
222 (set_symbol_name, set_symbol_function, set_symbol_plist):
223 (set_symbol_next, set_overlay_plist): New function.
224 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
225 (struct Lisp_Overlay): Likewise.
226 (CVAR, MVAR, SVAR): Remove.
227 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
228 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
229 * xterm.c: Adjust users.
230 * .gdbinit: Change to use name field of struct Lisp_Symbol
233 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
235 Basic functions to set Lisp_Object and pointer slots of intervals.
236 * intervals.h (interval_set_parent, interval_set_object):
237 (interval_set_left, interval_set_right, interval_set_plist):
238 (interval_copy_parent): New function.
239 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
240 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
242 (INTERVAL_SIZE): Remove. Adjust users.
243 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
245 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
247 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
248 * process.h (PGET): Remove.
249 (struct Lisp_Process): Do not use INTERNAL_FIELD.
250 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
252 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
254 Drop WGET and revert read access to Lisp_Objects slots of struct window.
255 * window.h (WGET): Remove.
256 (struct window): Do not use INTERNAL_FIELD.
257 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
258 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
259 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
260 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
261 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
264 2012-08-07 Chong Yidong <cyd@gnu.org>
266 * window.c (Fwindow_edges, Fwindow_pixel_edges)
267 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
268 (Fdelete_window_internal): Signal an error if the window is not on
269 a live frame (Bug#12025).
271 2012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
273 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
274 * frame.h (FGET): Remove.
275 (struct frame): Do not use INTERNAL_FIELD.
276 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
277 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
278 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
279 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
281 2012-08-06 Juanma Barranquero <lekktu@gmail.com>
283 * w32.c: Silence compiler warnings.
284 (map_w32_filename): Remove unused variable `is_fat'.
285 (chase_symlinks): Add parentheses around expression.
287 2012-08-06 Glenn Morris <rgm@gnu.org>
289 * sysdep.c: Respect BROKEN_GETWD.
291 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
292 Let configure handle it.
293 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
295 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
297 Use GCALIGNMENT where appropriate.
298 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
299 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
300 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
302 2012-08-06 Eli Zaretskii <eliz@gnu.org>
304 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
305 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
307 2012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
309 * buffer.h (struct buffer): Revert `indirections' to a simple int;
310 that should be sufficient for everyone.
312 2012-08-06 Jan Djärv <jan.h.d@swipnet.se>
314 * keyboard.c (timer_check_2): Add break so timer_check returns next
317 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
319 Fix Windows build errors introduced after converting to WGET and WSET.
320 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
321 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
323 2012-08-06 Jan Djärv <jan.h.d@swipnet.se>
325 * nsterm.m (ns_frame_rehighlight): Use FSET.
327 * nsmenu.m (ns_update_menubar): Use FSET.
329 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
331 Separate read and write access to Lisp_Object slots of Lisp_Process.
332 * process.h (PGET, PSET): New macros similar to AREF and ASET.
333 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
335 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
337 Separate read and write access to Lisp_Object slots of struct window.
338 * window.h (WGET, WSET): New macros similar to AREF and ASET.
339 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
340 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
341 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
342 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
343 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
346 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
348 Fix Windows build errors introduced after converting to FGET and FSET.
349 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
350 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
351 (w32_judge_scroll_bars): Change to use FSET.
352 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
354 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
356 Fix replacement typo.
357 * window.c (replace_window): Set root_window instead of
358 selected_window. This fixes a total window subsystem
359 malfunction reported by Bastien Guerry <bzg@gnu.org>.
361 2012-08-06 Glenn Morris <rgm@gnu.org>
363 * lisp.mk (lisp): Add language/persian.elc.
365 2012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
367 Separate read and write access to Lisp_Object slots of struct frame.
368 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
369 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
370 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
371 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
372 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
374 2012-08-05 Andreas Schwab <schwab@linux-m68k.org>
376 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
378 2012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
380 Generalize common compile-time constants.
381 * lisp.h (header_size, bool_header_size, word_size): Now here.
382 (struct Lisp_Vector): Add comment.
383 (struct Lisp_Bool_Vector): Move up to define handy constants.
384 (VECSIZE, PSEUDOVECSIZE): Simplify.
385 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
386 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
387 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
388 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
389 * xfont.c, xmenu.c: Use word_size where appropriate.
391 2012-08-05 Lawrence Mitchell <wence@gmx.li>
393 * search.c (Freplace_match): Treat \? in the replacement text
394 literally (Bug#8161).
396 2012-08-05 Chong Yidong <cyd@gnu.org>
398 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
399 * frame.c (Vdelete_frame_functions):
400 * emacs.c (Vkill_emacs_hook): Doc fix.
402 2012-08-04 Eli Zaretskii <eliz@gnu.org>
404 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
405 --with-x-toolkit=no builds.
406 Reported by Carsten Mattner <carstenmattner@gmail.com>.
408 2012-08-04 Chong Yidong <cyd@gnu.org>
410 * syntax.c (Fmodify_syntax_entry): Doc fix.
412 2012-08-04 Eli Zaretskii <eliz@gnu.org>
414 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
415 * w32.c (init_environment): Change the default values of many
416 environment variables in dflt_envvars[] to NULL, to avoid pushing
417 them into environment when they were not already defined.
418 Remove the code that deletes site-lisp subdirectories from the default
419 value of EMACSLOADPATH, as it is no longer needed.
420 (check_windows_init_file): Now external, not static.
421 Use Vload_path as is, without adding anything, as this function is now
422 called when Vload_path is already set up.
424 * w32.h (check_windows_init_file): Add prototype.
426 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
427 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
428 compatibility with Posix platforms.
429 (main): Move the call to check_windows_init_file to here from
431 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
432 any, in the DEFALT argument into the root of the Emacs build or
433 installation tree, as appropriate.
435 * callproc.c (init_callproc_1): Call decode_env_path instead of
436 doing its equivalent by hand.
437 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
438 the code that sets Vexec_path run on MS-Windows.
440 * lread.c (init_lread): Add comments to #ifdef's.
442 * msdos.c (dos_set_window_size, IT_update_begin)
443 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
444 instead of direct references.
446 2012-08-04 Paul Eggert <eggert@cs.ucla.edu>
448 Export DEFAULT_REHASH_* to GDB.
449 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
450 Now constants, not macros.
452 2012-08-03 Paul Eggert <eggert@cs.ucla.edu>
454 Remove unnecessary casts involving pointers.
455 These casts are no longer needed now that we assume C89 or later,
456 since they involve casting to or from void *.
457 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
458 (make_pure_float, make_pure_vector):
459 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
460 * macros.c (Fstart_kbd_macro):
461 * menu.c (find_and_return_menu_selection):
462 * minibuf.c (read_minibuf_noninteractive):
463 * sysdep.c (closedir):
464 * xdisp.c (x_produce_glyphs):
465 * xfaces.c (compare_fonts_by_sort_order):
466 * xfns.c (x_real_positions, select_visual):
467 * xselect.c (x_stop_queuing_selection_requests)
468 (x_get_window_property, x_get_window_property_as_lisp_data):
469 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
470 Remove unnecessary pointer casts.
471 * alloc.c (record_xmalloc): New function.
472 * lisp.h (record_xmalloc): New decl.
473 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
474 more like a function. This is because the pointer cast is not
475 needed. All uses changed.
476 * print.c (print_string, print_error_message): Avoid length recalc.
478 Improve fix for macroexp crash with debugging (Bug#12118).
479 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
480 ARRAY_MARK_FLAG when checking subscripts, because ASET is
481 not supposed to be invoked from the garbage collector.
482 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
483 (gc_aset): New function, which is like ASET but can be
484 used in the garbage collector.
485 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
486 (set_hash_index): Use it instead of ASET.
488 2012-08-03 Eli Zaretskii <eliz@gnu.org>
490 Support symlinks on latest versions of MS-Windows.
491 * w32.c: Include winioctl.h and aclapi.h.
492 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
493 (revert_to_self): Forward declarations of static functions.
494 <static BOOL g_b_init_get_security_info>:
495 <g_b_init_create_symbolic_link>: New static flags.
496 (globals_of_w32): Initialize them to zero.
497 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
498 (map_w32_filename): Improve commentary. Simplify switch.
499 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
500 headers (most versions of MinGW w32api don't).
501 (get_security_info, create_symbolic_link)
502 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
504 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
505 in the argument file name.
506 (sys_access): Call unc_volume_file_attributes only if
507 GetFileAttributes fails with network-related error codes.
508 (sys_rename): Diagnose renaming of a symlink when the user doesn't
509 have the required privileges.
510 (get_file_security_desc_by_name): Rename from
511 get_file_security_desc.
512 (stat_worker): New function, with most of the guts of 'stat', and
513 with addition of handling of symlinks and support for 'lstat'.
514 If possible, get file's attributes and security information by
515 handle, not by name. Produce S_IFLNK bit for symlinks, when
517 (stat, lstat): New functions, call 'stat_worker'.
518 (symlink, readlink, careadlinkat): Rewritten to create and resolve
519 symlinks when the underlying filesystem supports them.
521 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
523 Fix macroexp crash on Windows with debugging (Bug#12118).
524 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
525 checking subscripts; problem introduced with the recent
526 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
527 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
528 since it's used in non-static inline functions now.
530 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
531 Don't assume buffer size fits in 'int'. Remove unused local.
533 Use C99-style 'extern inline' if available.
534 * buffer.h (BUFFER_INLINE):
535 * category.h (CATEGORY_INLINE):
536 * character.h (CHARACTER_INLINE):
537 * charset.h (CHARSET_INLINE):
538 * composite.h (COMPOSITE_INLINE):
539 * dispextern.h (DISPEXTERN_INLINE):
540 * lisp.h (LISP_INLINE):
541 * systime.h (SYSTIME_INLINE):
542 New macro, replacing 'static inline' in this header.
543 * buffer.h, category.h, character.h, charset.h, composite.h:
544 * dispextern.h, lisp.h, systime.h:
545 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
546 * alloc.c (LISP_INLINE):
547 * buffer.c (BUFFER_INLINE):
548 * category.c (CATEGORY_INLINE):
549 * character.c (CHARACTER_INLINE):
550 * charset.c (CHARSET_INLINE):
551 * composite.c (COMPOSITE_INLINE):
552 * dispnew.c (DISPEXTERN_INLINE):
553 * sysdep.c (SYSTIME_INLINE):
554 Define to EXTERN_INLINE, so that the corresponding functions
555 are compiled into code.
556 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
557 (INLINE_HEADER_END): New macros.
558 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
559 since it's used in non-static inline functions now.
560 (VALMASK) [!USE_LSB_TAG]: Likewise.
562 2012-08-02 Glenn Morris <rgm@gnu.org>
564 * s/: Remove empty directory.
566 * s/ms-w32.h: Move to ../nt/inc.
567 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
568 Update for new ms-w32.h location.
570 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
573 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
575 2012-08-02 Glenn Morris <rgm@gnu.org>
577 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
578 hard-coding the path separator.
580 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
582 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
583 This how ASET and AREF are supposed to work, and makes
584 it easier to think about future improvements. See
585 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
586 * charset.h (set_charset_attr): New function.
587 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
588 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
589 (aref_addr): New function. All uses of &AREF(...) changed.
590 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
591 (set_hash_index): New functions. All lvalue-style uses of
592 HASH_KEY etc. changed.
593 * keyboard.c (set_prop): New function. All lvalue-style uses
596 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
598 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
599 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
600 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
601 * nsfns.m (ns_set_name_as_filename): Likewise.
602 * nsmenu.m (ns_update_menubar): Likewise.
603 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
605 2012-08-01 Eli Zaretskii <eliz@gnu.org>
607 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
608 Adapt to latest changes in field names of the corresponding Lisp
611 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
613 2012-08-01 Glenn Morris <rgm@gnu.org>
615 * s/msdos.h: Remove file.
616 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
617 * Makefile.in (S_FILE): Remove.
618 (config_h): Remove S_FILE.
620 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
622 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
623 Remove; moved to nt/config.nt.
625 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
627 Use INTERNAL_FIELD for conses and overlays.
628 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
629 Remove obsolete comment.
631 (struct Lisp_Overlay): Use INTERNAL_FIELD.
632 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
634 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
636 Use INTERNAL_FIELD for symbols.
637 * lisp.h (SVAR): New macro. Adjust users.
638 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
639 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
641 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
643 Use INTERNAL_FIELD for processes.
644 * process.h (PVAR): New macro. Adjust style.
645 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
646 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
648 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
650 Use INTERNAL_FIELD for windows.
651 * window.h (WVAR): New macro.
652 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
653 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
654 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
655 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
656 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
657 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
659 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
661 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
663 2012-08-01 Glenn Morris <rgm@gnu.org>
665 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
666 Move to configure.ac.
668 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
670 * makefile.w32-in (CONFIG_H): Update dependencies.
671 (CONF_POST_H): New macro.
673 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
675 2012-07-31 Glenn Morris <rgm@gnu.org>
677 * Makefile.in (S_FILE): No longer set by configure.
679 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
681 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
683 * process.h (NULL_DEVICE):
685 * editfns.c (USER_FULL_NAME): Let configure set them.
687 * s/README, s/template.h: Remove files.
689 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
691 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
692 Move to configure.ac.
694 2012-07-31 Eli Zaretskii <eliz@gnu.org>
696 * .gdbinit (xframe): Adapt to introduction of FVAR and the
697 resulting renaming of 'struct frame' members.
699 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
701 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
702 after introduction of FVAR.
704 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
706 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
708 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
709 instead of compositeToPoint.
710 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
712 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
714 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
716 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
717 * lisp.h (INTERNAL_FIELD): New macro.
718 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
719 (BVAR): Change to use INTERNAL_FIELD.
720 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
721 (KVAR): Change to use INTERNAL_FIELD.
722 * frame.h (FVAR): New macro.
723 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
724 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
725 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
726 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
727 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
729 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
731 Miscellaneous fixes for non-default X toolkits.
732 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
733 * xterm.c (x_frame_of_widget): Remove redundant prototype.
734 Move under #ifdef USE_LUCID.
735 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
736 definition and usage to avoid warnings.
738 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
740 * nsterm.m (openFiles): Fix previous checkin.
742 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
744 * indent.c (compute_motion): Remove unused local.
746 2012-07-31 Glenn Morris <rgm@gnu.org>
748 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
750 * conf_post.h [USG5_4]:
751 Move remaining contents of s/usg5-4-common.h here.
752 * s/usg5-4-common.h: Remove file.
754 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
755 * s/irix6-5.h: Remove file.
757 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
758 * s/darwin.h: Remove file.
760 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
761 * s/hpux10-20.h: Remove file, which is now empty.
763 2012-07-30 Glenn Morris <rgm@gnu.org>
765 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
766 * Makefile.in (config_h): Add conf_post.h.
767 * makefile.w32-in (CONFIG_H): Add conf_post.h.
769 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
771 * nsterm.m (ns_do_open_file): New variable.
772 (ns_term_init): Set ns_do_open_file to YES after run returns.
773 (openFile, openTempFile, openFileWithoutUI, openFiles):
774 Open files only if ns_do_open_file.
776 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
778 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
779 This no-op macro hasn't been needed for many years.
780 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
782 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
783 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
784 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
785 gdb_make_enums_visible.
786 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
787 (DIRECTORY_SEP): Now a constant, not a macro.
789 2012-07-30 Eli Zaretskii <eliz@gnu.org>
791 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
792 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
794 * w32term.c <w32_keyboard_codepage>: Renamed from
795 keyboard_codepage and now external. All users changed.
797 * w32term.h: Add declaration of w32_keyboard_codepage.
799 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
800 the codepage to translate keys to Unicode. If this argument is
801 -1, use the value returned by GetConsoleCP. All callers changed.
803 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
805 Update .PHONY listings in makefiles.
806 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
807 bootstrap-clean, distclean, maintainer-clean, versioclean,
810 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
811 This is a bit clearer. Fix some commentary typos.
813 2012-07-30 Glenn Morris <rgm@gnu.org>
815 * s/netbsd.h: Let configure include signal.h if needed.
816 Remove file, which is now empty.
818 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
819 Let configure set them.
820 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
821 No more need to undefine.
823 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
825 * keymap.c (Fkey_description): Don't remove 0x80 bit from
826 non-single-byte char when adding meta modifier. (Bug#12090)
828 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
830 Convert safe_call to use variable number of arguments.
831 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
832 (safe_call2): Fix comment.
833 * lisp.h (safe_call): Adjust prototype.
834 * coding.c (encode_coding_object): Change to use safe_call2.
835 * xfaces.c (merge_face_heights): Change to use safe_call1.
837 2012-07-30 Glenn Morris <rgm@gnu.org>
839 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
840 does that unconditionally. Remove file, which is now empty.
842 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
845 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
847 Export to GDB most of lisp.h's remaining object-like macros.
848 * lisp.h (min, max): Move earlier, because they're used earlier now.
849 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
850 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
851 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
852 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
853 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
854 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
855 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
856 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
857 Now constants, for GDB. They need not be macros.
858 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
859 Now constants, for GDB, as well as macros, for static initializers.
860 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
861 Move to after the definition of struct Lisp_Char_Table,
862 since the former now needs that type defined.
863 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
864 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
865 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
866 New enums, for gdb_make_enums_visible.
867 (GLYPH_MODE_LINE_FACE): Remove; unused.
868 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
869 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
870 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
871 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
872 enum maxargs, enum MAX_ALLOCA.
873 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
874 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
875 no longer needed, now that they are done in lisp.h.
877 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
879 Cleanup string bytes checking.
880 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
881 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
882 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
883 (check_sblock, compact_small_strings): Simplify.
885 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
887 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
888 These macros are confusing and no longer need to be defined, as
889 the enum values now suffice. All uses replaced with definiens.
890 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
892 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
894 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
895 ($(BLD)/w32console.$(O)): Update dependencies.
897 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
899 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
900 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
902 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
904 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
906 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
907 setting sitelisp (Bug#12010).
909 2012-07-29 Eli Zaretskii <eliz@gnu.org>
911 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
913 * w32heap.c (cache_system_info):
914 * w32.c (sys_rename):
915 * w32proc.c (find_child_console, sys_kill): All users changed.
917 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
919 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
921 2012-07-29 Eli Zaretskii <eliz@gnu.org>
923 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
925 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
927 Cleanup statistics calculation in Fgarbage_collect.
928 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
929 Fix zombies percentage calculation. Simplify elapsed time calculation.
931 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
933 Generalize marker debugging code under MARKER_DEBUG and use eassert.
934 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
935 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
936 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
937 (replace_range, replace_range_2, del_range_2): Change to eassert.
938 * marker.c (byte_char_debug_check): Adjust style.
940 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
942 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
943 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
944 long-ago-commented-out code that talks about "WIN32".
945 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
948 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
950 Use Gnulib stdalign module (Bug#9772, Bug#9960).
951 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
952 Simplify by using alignof.
953 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
954 * lisp.h: Include <stdalign.h>.
955 (GCALIGNMENT): New macro and constant.
956 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
957 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
958 (stdalign): New macro, if not already defined.
960 2012-07-28 Eli Zaretskii <eliz@gnu.org>
962 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
963 * w32inevt.c: Include w32inevt.h.
964 (w32_read_console_input): New inline function, calls either
965 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
966 w32_console_unicode_input.
967 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
968 (w32_kbd_patch_key, key_event): Use the codepage returned by
969 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
970 (key_event): use uChar.UnicodeChar only if
971 w32_console_unicode_input is non-zero.
973 * w32console.c: Include w32heap.h.
974 <w32_console_unicode_input>: New global variable.
975 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
976 family of Windows, zero otherwise.
978 * w32inevt.h: Declare w32_console_unicode_input.
980 * xdisp.c (init_iterator): Don't reference tip_frame in a build
981 --without-x. (Bug#11742)
983 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
985 Adjust GDB to reflect pvec_type changes (Bug#12036).
986 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
987 2012-07-04 changes to pseudovector representation.
988 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
990 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
992 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
994 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
996 2012-07-27 Eli Zaretskii <eliz@gnu.org>
998 * alloc.c (listn): Fix the order the arguments are consed onto the
1001 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1002 enumeration constants, as PURE and HEAP are too general, and clash
1003 with other headers and sources, such as gmalloc.c and the
1004 MS-Windows system headers. All users changed.
1006 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1008 Revert last save_excursion_save and save_excursion_restore changes.
1009 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1010 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1012 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1014 Fix recently-introduced typos in Windows port.
1015 Reported by Martin Rudalics <rudalics@gmx.at>.
1016 * w32.c (init_environment): Replace comma with semicolon.
1017 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
1019 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1021 Improve GDB symbol export (Bug#12036).
1022 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1023 arms of an 'if', not using conditional expressions; otherwise GDB
1024 complains about the types in the unevaluated arm when the argument
1025 is an integer literal.
1026 (xgetint): Simplify expression.
1027 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1028 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1029 Zaretskii in <http://bugs.gnu.org/12036#13>.
1030 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1031 needed now that we have gdb_make_enums_visible.
1032 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1033 (enum enum_USE_LSB_TAG):
1034 New enum types, packaging up enums that need to be exported to GDB.
1036 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1038 Utility function to make a list from specified amount of objects.
1039 * lisp.h (enum constype): New datatype.
1040 (listn): New prototype.
1041 * alloc.c (listn): New function.
1042 (Fmemory_use_count, syms_of_alloc): Use it.
1043 * buffer.c (syms_of_buffer): Likewise.
1044 * callint.c (syms_of_callint): Likewise.
1045 * charset.c (define_charset_internal): Likewise.
1046 * coding.c (syms_of_coding): Likewise.
1047 * keymap.c (syms_of_keymap): Likewise.
1048 * search.c (syms_of_search): Likewise.
1049 * syntax.c (syms_of_syntax): Likewise.
1050 * w32.c (init_environment): Likewise.
1051 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1052 * xdisp.c (syms_of_xdisp): Likewise.
1053 * xfns.c (syms_of_xfns): Likewise.
1055 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1057 Fast save_excursion_save and save_excursion_restore.
1058 * lisp.h (struct Lisp_Excursion): New data type.
1059 (PVEC_EXCURSION): New pseudovector type.
1060 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1061 to deal with it. Adjust comments.
1062 (init_marker, attach_marker): New prototype.
1063 (unchain_marker): Adjust prototype.
1064 * marker.c (attach_marker): Change to global.
1065 (init_marker): New function.
1066 * alloc.c (Fmake_marker, build_marker): Use it.
1067 (build_marker): More easserts.
1068 (mark_object): Handle struct Lisp_Excursion.
1069 * editfns.c (save_excursion_save, save_excursion_restore):
1070 Reimplement to use struct Lisp_Excursion. Add comments.
1072 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1074 Fix export of symbols to GDB (Bug#12036).
1075 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1076 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1077 emacs.c, as this is a more-suitable home. Had this been done earlier
1078 the fix for 12036 would have avoided some of the problems noted in
1079 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1080 would have been more obvious.
1081 * emacs.c: Do not include <verify.h>; no longer needed.
1082 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
1083 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1084 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1085 Remove; now done in lisp.h.
1086 * lisp.h (PUBLISH_TO_GDB): New macro.
1087 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1088 (DATA_SEG_BITS): Use it.
1089 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1090 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1091 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1092 not be usable in #if. This simplifies things.
1094 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
1096 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1098 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1100 Simplify export of symbols to GDB (Bug#12036).
1101 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1102 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1103 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1104 Adjust to changes in lisp.h and emacs.c, by using
1105 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1106 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1107 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1108 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1109 instead of gdb_valbits.
1110 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1111 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1112 instead of gdb_array_mark_flag.
1113 (xboolvector): Get size from $->size, not $->header.size.
1114 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1115 (xreload, hook-run, hookpost-run): Remove.
1116 * emacs.c: Include <verify.h>.
1117 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1118 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1120 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1121 (gdb_USE_LSB_TAG): New enum constants.
1122 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1123 Also define these as enum constants, so they're visible to GDB.
1124 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1125 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1126 as constants, so they're visible to GDB.
1127 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1128 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1129 Now enum constants, not macros, so they're visible to GDB.
1130 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1131 more convenient now. All uses changed.
1132 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1133 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1135 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1137 Explicitly free restriction data that are not needed anymore.
1138 * editfns.c (save_restriction_restore): Free restriction data.
1140 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1142 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1143 add argument, tune behavior, and adjust all callers.
1145 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1147 Use typedef for EMACS_INT, EMACS_UINT.
1148 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1149 than macros. This simplifies debugging in the usual case, since
1150 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1151 and it allows expressions involving EMACS_INT casts.
1152 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1154 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1156 * nsterm.m (ns_read_socket): Return early if there is a modal
1159 2012-07-25 Martin Rudalics <rudalics@gmx.at>
1161 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1162 that FOCUS-FRAME can be omitted.
1164 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1166 Adjust buffer text indirection counters at the end of Fkill_buffer.
1167 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1168 buffer is definitely dead. This should really fix an issue reported
1169 by Christoph Scholtes again. (Bug#12007).
1170 (init_buffer_once): Initialize indirection counters of
1171 buffer_defaults and buffer_local_symbols (for sanity and safety).
1173 2012-07-24 Eli Zaretskii <eliz@gnu.org>
1175 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1176 and continuation glyphs on tooltip frames, leave them at zero.
1177 Avoids continued lines in tooltips. (Bug#11832)
1179 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1181 Simplify copy_overlay.
1182 * buffer.c (copy_overlay): Simplify. Use build_marker.
1183 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1185 2012-07-23 Eli Zaretskii <eliz@gnu.org>
1187 * print.c (print_object): Don't crash when a frame's name is nil
1188 or invalid. (Bug#12025)
1190 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1191 it signals an error when a tooltip frame is being created.
1193 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1195 Cleanup miscellaneous objects allocation and initialization.
1196 * alloc.c (allocate_misc): Change to static. Add argument to
1197 specify the subtype. Adjust comment and users.
1198 (build_overlay): New function.
1199 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1200 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1201 (allocate_misc): Remove prototype.
1202 (build_overlay): Add prototype.
1204 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1206 Swap buffer text indirection counters in Fbuffer_swap_text.
1207 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1208 This avoids crash reported by Christoph Scholtes at
1209 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1211 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1213 * nsmenu.m (Popdown_data): New struct.
1214 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1216 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1217 (initWithContentRect): Make imgView and contentView non-static
1218 and autorelease them. Also autorelease img and matrix (Bug#12005).
1219 (dealloc): Remove (Bug#12005).
1221 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1223 Adjust consing_since_gc when objects are explicitly freed.
1224 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1225 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1226 (free_cons, free_misc): Subtract object size from consing_since_gc.
1228 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1230 Simplify and cleanup markers positioning code.
1231 * marker.c (attach_marker): More useful eassert.
1232 (live_buffer, set_marker_internal): New function.
1233 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1234 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1236 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1238 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1239 as it's limited by the amount of memory, not by INT_MAX.
1241 2012-07-21 Eli Zaretskii <eliz@gnu.org>
1243 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1244 in special-event-map. See the discussion at
1245 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1248 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
1249 info.dwItemData. Fixes crashes on 64-bit Windows.
1250 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
1252 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1254 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
1255 (conversationIdentifier): Return value is NSInteger.
1256 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
1258 2012-07-21 Chong Yidong <cyd@gnu.org>
1260 * window.c (decode_any_window): Signal an error if the window is
1261 on a dead frame (Bug#11984).
1263 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1265 Add indirection counting to speed up Fkill_buffer.
1266 * buffer.h (struct buffer): New member.
1267 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1268 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1269 base buffer indirection counter.
1270 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1271 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1272 through buffer list if indirection counter is 0.
1274 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1276 Extend the value returned by Fgarbage_collect with heap statistics.
1277 * alloc.c (Qheap): New symbol.
1278 (syms_of_alloc): DEFSYM it.
1279 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1280 (Fmemory_free): Remove.
1281 (syms_of_alloc): Don't defsubr it.
1282 * buffer.c (Fcompact_buffer): Remove.
1283 (syms_of_buffer): Don't defsubr it.
1285 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1287 Make maybe_gc inline.
1288 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1289 * lisp.h (consing_since_gc, gc_relative_threshold)
1290 (memory_full_cons_threshold): Revert declaration.
1291 (maybe_gc): Remove prototype, define as inline.
1292 * alloc.c: Remove old commented-out code.
1293 (consing_since_gc, gc_relative_threshold)
1294 (memory_full_cons_threshold): Revert to global.
1297 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1299 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1300 * lisp.h (build_unibyte_string): New function.
1301 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1302 * sysdep.c, w32fns.c, xfns.c: Use it.
1303 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1304 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1305 Adjust users accordingly.
1306 * font.h (font_open_by_name): Adjust prototype.
1308 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1310 Cleanup calls to Fgarbage_collect.
1311 * lisp.h (maybe_gc): New prototype.
1312 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1313 Remove declarations.
1314 * alloc.c (maybe_gc): New function.
1315 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1317 * bytecode.c (MAYBE_GC): Use maybe_gc.
1318 * eval.c (eval_sub, Ffuncall): Likewise.
1319 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1320 to avoid dependency from auto-save feature.
1322 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1324 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1325 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1326 'for_each_per_buffer_object_at'.
1327 All uses changed. It's better to use upper-case for macros that
1328 cannot be implemented as functions, to give the reader a clue
1329 that they're special.
1331 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1333 * alloc.c (Fgarbage_collect): Tweak docstring.
1335 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1337 Tweak the value returned from Fgarbage_collect again.
1338 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1339 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1340 Adjust documentation.
1341 (total_vector_bytes): Rename to total_vector_slots, adjust
1343 (total_free_vector_bytes): Rename to total_free_vector_slots,
1345 (Qstring_bytes, Qvector_slots): New symbols.
1346 (syms_of_alloc): DEFSYM them.
1348 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1350 Buffer compaction primitive which may be used from Lisp.
1351 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1352 (syms_of_buffer): Register Fcompact_buffer.
1353 * alloc.c (Fgarbage_collect): Use compact_buffer.
1354 * buffer.h (compact_buffer): New prototype.
1355 (struct buffer_text): New member.
1357 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1359 New macro to iterate over all buffers, miscellaneous cleanups.
1360 * lisp.h (all_buffers): Remove declaration.
1361 * buffer.h (all_buffers): Add declaration, with comment.
1362 (for_each_buffer): New macro.
1363 * alloc.c (Fgarbage_collect, mark_object): Use it.
1364 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1365 (init_buffer): Likewise.
1366 * data.c (Fset_default): Likewise.
1367 * coding.c (code_conversion_restore): Remove redundant check
1369 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1371 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1373 Fix bug that created negative-length intervals.
1374 * intervals.c (merge_interval_right, merge_interval_left):
1375 Do not zero out this interval if it is absorbed by its children,
1376 as this interval's total length doesn't change in that case. See
1377 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1379 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1381 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1382 when invoking (make-bool-vector N t) and N is a positive
1383 multiple of 8 -- the last 8 bits were mistakenly cleared.
1385 Remove some struct layout assumptions in bool vectors.
1386 * alloc.c (bool_header_size): New constant.
1387 (header_size, word_size): Move earlier, as they're now used earlier.
1388 Use 'word_size' in a few more places, where it's appropriate.
1389 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1390 padding before the data member of a bool vector.
1391 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1392 than doing the check by hand with an abort ().
1394 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1396 * eval.c (Fdefvar): Don't check constants since we only set the var if
1397 it's not yet defined anyway (bug#11904).
1399 * lisp.h (last_undo_boundary): Declare new var.
1400 * keyboard.c (command_loop_1): Set it.
1401 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1402 were auto-added by the command loop (bug#11774).
1404 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1406 * w32font.c (Qsymbol): Remove local definition.
1407 (syms_of_w32font): Don't DEFSYM it.
1409 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1411 Fix sweep_vectors to handle large bool vectors correctly.
1412 * alloc.c (sweep_vectors): Account total_vector_bytes for
1413 bool vectors larger than VBLOCK_BYTES_MAX.
1415 2012-07-18 Chong Yidong <cyd@gnu.org>
1417 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1418 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1420 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1422 Return more descriptive data from Fgarbage_collect.
1423 Suggested by Stefan Monnier in
1424 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1425 * alloc.c (bounded_number): New function.
1426 (total_buffers, total_vectors): New variable.
1427 (total_string_size): Rename to total_string_bytes, adjust users.
1428 (total_vector_size): Rename to total_vector_bytes, adjust users.
1429 (sweep_vectors): Account total_vectors and total_vector_bytes.
1430 (Fgarbage_collect): New return value. Adjust documentation.
1431 (gc_sweep): Account total_buffers.
1432 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1433 (VECTOR_SIZE): Remove.
1434 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1435 (Qinterval, Qmisc): New symbols.
1436 (syms_of_data): Initialize them.
1437 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1438 (Qcons, Qbuffer): New declarations.
1440 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1442 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1443 Round up, not down. Improve doc.
1445 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1447 Restore old code in allocate_string_data to avoid Faset breakage.
1448 Reported by Julien Danjou <julien@danjou.info> in
1449 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1450 * alloc.c (allocate_string_data): Restore old code with minor
1451 adjustments, fix comment to explain this subtle issue.
1453 2012-07-17 Eli Zaretskii <eliz@gnu.org>
1455 Remove FILE_SYSTEM_CASE.
1456 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1458 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1459 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1460 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1461 call-process-region passes it through expand-file-name.
1463 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1465 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1467 Fix crash when creating indirect buffer (Bug#11917)
1468 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1469 Don't handle unbound variables specially if non-zero.
1470 (Fbuffer_local_variables): Pass zero.
1471 (clone_per_buffer_values): Pass non-zero.
1473 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1475 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1476 to make the loop interruptible.
1478 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1480 * gnutls.c (emacs_gnutls_handshake): Only retry if
1481 GNUTLS_E_INTERRUPTED.
1483 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1485 Cleanup and convert miscellaneous checks to eassert.
1486 * alloc.c (mark_interval): Fix comment, partially rephrase
1487 old comment from intervals.h (see below).
1488 * intervals.c (find_interval, adjust_intervals_for_insertion)
1489 (delete_interval, adjust_intervals_for_deletion)
1490 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1492 (adjust_intervals_for_insertion, make_new_interval):
1493 Remove obsolete and unused code.
1494 * intervals.h (struct interval): Remove obsolete comment.
1495 * textprotp.c (erase_properties): Remove unused code.
1496 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1497 (Fremove_list_of_text_properties): Convert to eassert.
1499 2012-07-17 Chong Yidong <cyd@gnu.org>
1501 * editfns.c (Finsert_char): Doc fix.
1503 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1505 Fix previous change to make Fmemory_free always accurate.
1506 * alloc.c (make_interval): Update total_free_intervals.
1507 (make_float): Likewise for total_free_floats.
1508 (free_cons, Fcons): Likewise for total_free_conses.
1509 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1510 Likewise for total_free_vector_bytes.
1511 (Fmake_symbol): Likewise for total_free_symbols.
1512 (bytes_free): Remove.
1514 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1516 Simple free memory accounting feature.
1517 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1518 (sweep_vectors): Accumulate size of free vectors.
1519 (Fgarbage_collect): Setup bytes_free.
1520 (Fmemory_free): New function.
1521 (syms_of_alloc): Register it.
1523 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1525 Cleanup overlays checking.
1526 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1527 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1528 eassert and OVERLAYP.
1529 (sort_overlays): Change to use OVERLAYP.
1531 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1533 * editfns.c (Finsert_char): Make it interactive, and make the
1534 second arg optional. Copy interactive spec and docstring from
1537 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1539 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1540 Unlike the other wrapped functions, fabs has an unspecified
1543 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1545 * nsterm.m (keyDown): Interpret flags without left/right bits
1546 as the left key (Bug#11670).
1548 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1550 Remove empty and useless init functions.
1551 * lisp.h (init_character_once, init_fns, init_image)
1552 (init_filelock, init_sound): Remove prototype.
1553 * character.c (init_character_once): Remove.
1554 * filelock.c (init_filelock): Likewise.
1555 * fns.c (init_fns): Likewise.
1556 * image.c (init_image): Likewise.
1557 * sound.c (init_sound): Likewise.
1558 * emacs.c (main): Adjust accordingly.
1560 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1562 * gtkutil.h: Tiny cleanups.
1563 (use_old_gtk_file_dialog): Remove useless declaration.
1564 (xg_uses_old_file_dialog): Add suggested const attribute.
1566 2012-07-15 Eli Zaretskii <eliz@gnu.org>
1568 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1569 (bidi_paragraph_init): Use it to limit search forward for a strong
1570 directional character in abnormally large paragraphs full of
1571 neutral or weak characters. (Bug#11943)
1573 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1575 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1576 the toolbar (Bug#9451).
1577 (xg_make_tool_item): Give the widget event box a transparent
1580 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1582 Cleanup basic allocation variables and functions.
1583 * alloc.c (ignore_warnings, init_intervals, init_float)
1584 (init_cons, init_symbol, init_marker): Remove.
1585 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1586 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1587 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1588 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1589 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1590 (staticidx, init_alloc_once, init_strings, free_ablock):
1591 Remove redundant initialization.
1592 * fns.c (init_weak_hash_tables): Remove.
1593 * lisp.h (init_weak_hash_tables): Remove prototype.
1595 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1597 Use zero_vector where appropriate.
1598 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1600 * lisp.h (zero_vector): New declaration.
1601 * font.c (null_vector): Remove.
1602 (syms_of_font): Remove initialization and staticpro.
1603 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1604 * keymap.c (Faccessible_keymaps): Likewise.
1606 2012-07-15 Leo Liu <sdl.web@gmail.com>
1608 * fringe.c: Fix typo in comments.
1610 2012-07-14 Leo Liu <sdl.web@gmail.com>
1612 * fringe.c: Add a new bitmap exclamation-mark.
1614 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1616 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1618 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1619 (HAVE_MENUS): Don't define, defined by editing config.in with
1621 (GMALLOC_INHIBIT_VALLOC): Don't define.
1622 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1624 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1626 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1628 2012-07-14 Glenn Morris <rgm@gnu.org>
1630 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1631 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1632 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1634 2012-07-13 Glenn Morris <rgm@gnu.org>
1636 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1638 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1639 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1641 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1643 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1644 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1645 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1646 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1648 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1649 as boolean expression.
1650 (x_set_window_size): Remove unused variable toolbar.
1651 (ns_get_color_default, ns_mod_to_lisp): Remove.
1652 (ns_mouse_position): Remove unused variables xchar and ychar.
1653 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1654 (ns_set_vertical_scroll_bar): Remove unused variable count.
1655 (ns_delete_terminal): Remove unused variable i.
1656 (ns_term_init): Remove unused variables r, g and b.
1657 (mouseDown): Remove unused variable window.
1658 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1659 (initFrameFromEmacs): Remove unused variable vbextra.
1660 (mouseEntered): Remove unused variables p and dpyinfo.
1661 (mouseExited): Remove unused variables p and r.
1662 (ns_define_frame_cursor, ns_clear_frame_area)
1663 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1664 (menuDown): Assign [sender tag] to variable and cast the variable.
1666 * nsterm.h (menuDown): Add id as type to argument sender.
1667 (ns_display_info_for_name): Add Lisp_Object argument.
1668 (ns_term_init): Add Lisp_Object argument.
1669 (ns_map_event_to_object): Add void argument.
1670 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1671 prototype with arguments and only declare if __OBJC__.
1672 (nxatoms_of_nsselect): Add void argument.
1673 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1674 (ns_alloc_autorelease_pool): Add void argument.
1675 (ns_release_autorelease_pool): Add void* argument.
1676 (ns_get_defaults_value): Add const char* argument.
1678 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1679 (initFromContents): Use SSDATA where appropriate.
1680 (ns_update_menubar): Add braces to ambigous if-else.
1681 (initWithTitle): Put () around assignment in if statement.
1682 (ns_menu_show): Remove unused variables window and keymap.
1683 (update_frame_tool_bar): Remove unused variable selected_p.
1684 (initWithContentRect): Remove unused variable this_cmd_name.
1686 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1688 (setXBMColor): Remove unused variable len.
1689 (setPixmapData): Put () around assignment in loop statement.
1691 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1692 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1694 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1695 around assignment in loop statement.
1696 (nsfont_open): Remove unused variable i.
1697 (nsfont_open): Remove unused variable len.
1698 (nsfont_draw): Remove unused variable cs.
1700 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1701 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1702 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1703 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1704 (Fns_font_name, Fns_perform_service)
1705 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1706 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1707 (ns_set_name): Remove unused variable view.
1708 (x_set_menu_bar_lines): Remove unused variable olines.
1709 (x_set_tool_bar_lines): Remove unused variable root_window.
1710 (Fns_list_colors): Put () around assignment in while statement.
1711 (Fns_perform_service): Remove unused variable len.
1712 (Fns_display_usable_bounds): Remove unused variable top.
1713 (syms_of_nsfns): Remove unused variable i.
1715 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1718 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1720 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1721 and free it with DestroyExceptionInfo (Bug#11558).
1723 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1725 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1726 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1727 Set here, not in nt/config.nt.
1729 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1731 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1732 cursor overflow into the last glyph on display line when the right
1733 fringe is off. (Bug#11832)
1735 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1737 * xdisp.c (produce_special_glyphs): Now static.
1738 * dispextern.h (produce_special_glyphs): Remove decl.
1740 2012-07-13 Glenn Morris <rgm@gnu.org>
1742 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1743 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1745 * s/usg5-4-common.h (USG, USG5):
1746 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1747 * s/sol2-6.h (SOLARIS2):
1748 * s/irix6-5.h (IRIX6_5):
1749 * s/hpux10-20.h (USG, USG5, HPUX):
1750 * s/gnu-linux.h (USG, GNU_LINUX):
1751 * s/freebsd.h (BSD_SYSTEM):
1752 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1753 * s/cygwin.h (CYGWIN):
1754 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1755 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1757 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1759 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1761 2012-07-13 Glenn Morris <rgm@gnu.org>
1763 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1765 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1767 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1768 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1770 2012-07-12 Glenn Morris <rgm@gnu.org>
1772 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1774 * process.c (init_process_emacs): Rename from init_process.
1775 The old name is also the name of a Mach system call.
1776 * lisp.h, emacs.c: Update for this name change.
1777 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1780 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1782 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1783 memmove call that removes glyphs covered by the left truncation
1784 glyph. Improve commentary.
1785 (display_line): Fix display of continuation glyphs on GUI frames
1786 when the right fringe is turned off and variable-size fonts are
1787 used in the window. Move the code that appends a stretch glyph to
1788 produce_special_glyphs, so that it could be used for truncation
1789 and continuation glyphs alike.
1790 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1791 glyph of a suitably computed width, to align the special glyphs at
1792 the window margin. Code moved from display_line. (Bug#11832)
1794 2012-07-12 Glenn Morris <rgm@gnu.org>
1796 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1798 * s/gnu-linux.h, s/hpux10-20.h:
1799 Do not unconditionally define HAVE_XRMSETDATABASE.
1801 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1803 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1805 Fix typos that broke OS X build.
1806 Reported by Randal L. Schwartz in
1807 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1808 * nsterm.m (ns_timeout): Add missing local decl.
1809 (ns_get_color): snprintf -> sprintf, to fix typo.
1811 2012-07-12 Glenn Morris <rgm@gnu.org>
1813 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1814 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1815 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1816 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1818 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1819 Move PTY_OPEN to configure.
1821 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1822 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1823 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1825 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1827 Use empty_unibyte_string where applicable.
1828 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1829 * lread.c (read1): Likewise.
1830 * xsettings.c (syms_of_xsettings): Likewise.
1832 2012-07-12 Glenn Morris <rgm@gnu.org>
1834 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1835 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1836 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1837 * s/hpux10-20.h (RUN_TIME_REMAP):
1838 * s/bsd-common.h (TABDLY): Move to configure.
1840 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1842 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1844 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1845 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1847 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1849 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1850 * s/template.h: Move NARROWPROTO to configure.
1852 2012-07-11 Glenn Morris <rgm@gnu.org>
1854 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1855 unused since 2011-01-17 change to systty.h.
1857 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1858 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1859 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1861 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1863 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1865 2012-07-11 Glenn Morris <rgm@gnu.org>
1867 * s/darwin.h, s/gnu-linux.h, s/template.h:
1868 Move INTERRUPT_INPUT to configure.
1870 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1872 Minor adjustments to interning code.
1873 * lisp.h (intern, intern_c_string): Redefine as static inline
1874 wrappers for intern_1 and intern_c_string_1, respectively.
1875 (intern_1, intern_c_string_1): Rename prototypes.
1876 * lread.c (intern_1, intern_c_string_1, oblookup):
1877 Simplify Vobarray checking.
1878 * font.c (font_intern_prop): Likewise. Adjust comment.
1879 * w32font.c (intern_font_name): Likewise.
1881 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1883 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1885 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1886 of Fcar/Fcdr if possible.
1887 * font.c (check_otf_features): Likewise.
1888 * fontset.c (Fnew_fontset): Likewise.
1889 * gnutls.c (Fgnutls_boot): Likewise.
1890 * minibuf.c (read_minibuf): Likewise.
1891 * msdos.c (IT_set_frame_parameters): Likewise.
1892 * xmenu.c (Fx_popup_dialog): Likewise.
1893 * w32menu.c (Fx_popup_dialog): Likewise.
1895 2012-07-11 Glenn Morris <rgm@gnu.org>
1897 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1898 since nothing has defined it on these platforms.
1900 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1901 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1903 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1904 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1905 Move CLASH_DETECTION to configure.
1907 * s/gnu.h: Remove file, which is now empty.
1909 * s/gnu.h, s/gnu-linux.h:
1910 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1912 2012-07-11 John Wiegley <johnw@newartisans.com>
1914 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1915 function attribute, so we only use it if it exists in the
1918 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1920 Avoid call to strlen in fast_c_string_match_ignore_case.
1921 * search.c (fast_c_string_match_ignore_case): Change to use
1922 length argument. Adjust users accordingly.
1923 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1925 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1927 Assume mkdir, rmdir.
1928 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1929 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1932 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1935 * s/hpux10-20.h (HAVE_PERROR): Remove.
1936 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1937 Remove dummy definition, as this problem was obsolete long ago.
1940 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1942 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1944 Avoid calls to strlen in font processing functions.
1945 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1946 (font_open_by_name): Change to use length argument.
1947 Adjust users accordingly.
1948 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1950 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1951 Change to return ptrdiff_t.
1952 (xfont_list_pattern, xfont_match): Use length returned by
1953 xfont_decode_coding_xlfd.
1954 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1956 2012-07-11 Glenn Morris <rgm@gnu.org>
1958 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1959 Move DONT_REOPEN_PTY to configure.
1961 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1962 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1964 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1966 Remove "#define unix" that is no longer needed (Bug#11905).
1967 * s/aix4-2.h (unix): Remove; no longer needed.
1969 EMACS_TIME simplification (Bug#11875).
1970 This replaces macros (which typically do not work in GDB)
1971 with functions, typedefs and enums, making the code easier to debug.
1972 The functional style also makes code easier to read and maintain.
1973 * systime.h: Include <sys/time.h> on all hosts, not just if
1974 WINDOWSNT, since 'struct timeval' is needed in general.
1975 (EMACS_TIME): Now a typedef, not a macro.
1976 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1978 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1979 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1980 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1981 (EMACS_TIME_LE): Now functions, not macros.
1982 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1983 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1984 which are not functions. All uses rewritten to use:
1985 (make_emacs_time): New function.
1986 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1987 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1988 not functions. All uses rewritten to use the following, respectively:
1989 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1990 (add_emacs_time, sub_emacs_time): New functions.
1991 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1992 * fileio.c (Fcopy_file):
1993 * xterm.c (XTflash): Get the current time closer to when it's used.
1994 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1996 * bytecode.c (targets): Suppress -Woverride-init warnings.
1998 Simplify by avoiding confusing use of strncpy etc.
1999 * doc.c (Fsnarf_documentation):
2000 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2001 * frame.c (Fmake_terminal_frame):
2002 * gtkutil.c (get_utf8_string):
2004 * nsmenu.m (ns_update_menubar):
2005 * regex.c (regerror):
2006 Prefer memcpy to strncpy and strncat when either will do.
2007 * fileio.c (Fsubstitute_in_file_name):
2008 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2009 (menu_separator_name_p):
2010 * nsmenu.m (ns_update_menubar):
2011 Prefer memcmp to strncmp when either will do.
2012 * nsterm.m: Include <ftoastr.h>.
2014 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2015 Prefer snprintf to strncpy.
2016 * nsterm.m (ns_term_init):
2017 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2018 * nsterm.m (ns_term_init):
2019 Avoid the need for strncpy, by using build_string or
2020 make_unibyte_string directly. Use dtoastr, not snprintf.
2021 * process.c (Fmake_network_process): Diagnose service names that
2022 are too long, rather than silently truncating them or creating
2023 non-null-terminated names.
2024 (Fnetwork_interface_info): Likewise, for interface names.
2025 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2026 Prefer sprintf to strncat.
2027 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2028 Prefer vsnprintf to vsprintf + strncpy.
2030 2012-07-10 Glenn Morris <rgm@gnu.org>
2032 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2033 Clarify fallback case.
2035 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2037 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2038 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2039 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
2040 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
2041 where argument type is known to be a Lisp_Cons.
2043 2012-07-10 Tom Tromey <tromey@redhat.com>
2045 * bytecode.c (BYTE_CODE_THREADED): New macro.
2046 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2047 (enum byte_code_op): New type.
2048 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2049 (exec_byte_code): Use them. Use token threading when applicable.
2051 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2053 Optimize pure C strings initialization.
2054 * lisp.h (make_pure_string): Fix prototype.
2055 (build_pure_c_string): New function, defined as static inline. This
2056 provides a better opportunity to optimize away calls to strlen when
2057 the function is called with compile-time constant argument.
2058 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2059 argument, adjust users accordingly. Use build_pure_c_string where
2061 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2062 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2063 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2065 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2067 Avoid calls to strlen in miscellaneous functions.
2068 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2069 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2070 * lread.c (openp): Likewise.
2072 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2074 Avoid calls to strlen in path processing functions.
2075 * fileio.c (file_name_as_directory): Add comment. Change to add
2076 srclen argument and return the length of result. Adjust users
2078 (directory_file_name): Fix comment. Change to add srclen argument,
2079 swap 1st and 2nd arguments to obey the common convention.
2080 Adjust users accordingly.
2081 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2083 2012-07-10 Glenn Morris <rgm@gnu.org>
2085 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2086 Move PENDING_OUTPUT_COUNT definition to configure.
2088 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2089 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2090 * s/gnu.h (DATA_START): Move definitions to configure.
2092 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2093 We include usg5-4-common.h, which defines them both.
2095 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2096 O_RDONLY already includes it).
2098 Stop ns builds setting the EMACSLOADPATH environment variable.
2099 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2100 Now it does not set EMACSLOADPATH, just returns the load-path string.
2101 * nsterm.h: Update accordingly.
2102 * lread.c [HAVE_NS]: Include nsterm.h.
2103 (init_lread) [HAVE_NS]: Use ns_load_path.
2104 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2106 2012-07-09 Glenn Morris <rgm@gnu.org>
2108 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2109 since the included bsd-common.h does so.
2111 Stop ns builds setting the EMACSPATH environment variable.
2112 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2113 (ns_init_paths): Do not set EMACSPATH.
2114 * nsterm.h (ns_exec_path): Add it.
2115 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2118 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2120 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2122 * process.c (wait_reading_process_output): 'waitchannels' was unset
2123 when read_kbd || !NILP (wait_for_cell); fix this.
2125 Add GCC-style 'const' attribute to functions that can use it.
2126 * character.h (char_resolve_modifier_mask):
2127 * keyboard.h (make_ctrl_char):
2128 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2129 (init_character_once, next_almost_prime, init_fns, init_image)
2130 (flush_pending_output, init_sound):
2131 * mem-limits.h (start_of_data):
2132 * menu.h (finish_menu_items):
2133 Add ATTRIBUTE_CONST.
2134 * emacs.c (DEFINE_DUMMY_FUNCTION):
2135 Declare the dummy function with ATTRIBUTE_CONST.
2136 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2137 Add decls with ATTRIBUTE_CONST.
2139 Minor improvements to make_formatted_string.
2140 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2141 where int is good enough, as vsprintf returns an int.
2142 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2144 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2146 Use make_formatted_string to avoid double length calculation.
2147 * lisp.h (make_formatted_string): New prototype.
2148 * alloc.c (make_formatted_string): New function.
2149 * buffer.c (Fgenerate_new_buffer_name): Use it.
2150 * dbus.c (syms_of_dbusbind): Likewise.
2151 * editfns.c (Fcurrent_time_zone): Likewise.
2152 * filelock.c (get_boot_time): Likewise.
2153 * frame.c (make_terminal_frame, set_term_frame_name)
2154 (x_report_frame_params): Likewise.
2155 * image.c (gs_load): Likewise.
2156 * minibuf.c (get_minibuffer): Likewise.
2157 * msdos.c (dos_set_window_size): Likewise.
2158 * process.c (make_process): Likewise.
2159 * xdisp.c (ensure_echo_area_buffers): Likewise.
2160 * xsettings.c (apply_xft_settings): Likewise.
2162 2012-07-09 Glenn Morris <rgm@gnu.org>
2164 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2165 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2166 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2167 * nsterm.h (ns_etc_directory): Add it.
2168 * callproc.c [HAVE_NS]: Include nsterm.h.
2169 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2171 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2173 Move marker debugging code under MARKER_DEBUG.
2174 * marker.c (MARKER_DEBUG): Move marker debugging code under
2175 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2176 for bootstrap with --enable-checking (~3x slowdown reported
2177 by Juanma Barranquero <lekktu@gmail.com>).
2178 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2180 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2182 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2183 See <http://bugs.gnu.org/11825#29>.
2185 2012-07-08 Eli Zaretskii <eliz@gnu.org>
2187 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2188 has no font, use the frame's font. (Bug#11813)
2189 (display_line): Add commentary about displaying truncation glyphs
2191 (produce_special_glyphs): Move here from term.c.
2193 * term.c (produce_special_glyphs): Move to xdisp.c.
2195 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2198 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2200 * xdisp.c (display_line): Avoid warning about implicit declaration
2203 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2205 * lisp.h: Remove empty conditional.
2207 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2209 * lread.c (load_path_check): Now static.
2211 Fix some minor --with-ns problems found by static checking.
2212 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2213 (x_set_font) [!HAVE_X_WINDOWS]:
2214 * image.c (xpm_load_image) [HAVE_NS]:
2215 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2216 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2217 Remove unused local.
2218 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2219 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2220 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2221 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2222 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2223 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2224 Fix pointer signedness problem.
2225 * xfaces.c (FRAME_X_FONT_TABLE):
2226 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2228 2012-07-07 Glenn Morris <rgm@gnu.org>
2230 * lread.c (load_path_check): New function, split from init_lread.
2231 (init_lread): Reorganize. Motivation:
2232 If EMACSLOADPATH is set, check/warn about that rather than the
2233 defaults, which we are not going to use. Hence we can remove
2234 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2235 Don't warn if site-lisp directories are missing.
2236 If not installed, start from a blank load-path, since
2237 PATH_LOADSEARCH refers to the eventual installation directories.
2239 2012-07-07 Eli Zaretskii <eliz@gnu.org>
2241 Support truncation and continuation glyphs on GUI frames, when
2242 fringes are disabled. (Bug#11832)
2243 * xdisp.c (init_iterator): Get dimensions of truncation and
2244 continuation glyphs even if on GUI frames.
2245 Adjust it->last_visible_x on GUI frames when the left or right fringes,
2246 or both, are absent.
2247 (start_display, move_it_in_display_line_to): Handle the case of a
2248 GUI frame without a fringe to display continuation or truncation
2250 (insert_left_trunc_glyphs): Support GUI frames: make sure
2251 truncation glyphs overwrite enough glyphs from the current line to
2252 have sufficient space in pixels.
2253 (display_line): Support truncation and continuation glyphs on GUI
2254 frames. If some spare pixels are left on the line after inserting
2255 the truncation glyphs, fill that space with a stretch glyph of a
2256 suitably computed width.
2258 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2259 produce_glyphs, to support GUI sessions.
2261 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2263 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2265 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2267 Do not require float-time's arg to fit in time_t (Bug#11825).
2268 This works better on hosts where time_t is unsigned, and where
2269 float-time is applied to the (negative) difference between two times.
2270 * editfns.c (decode_time_components): Last arg is now double *,
2271 not int *, and means to store all the result as a double, without
2272 worrying about whether the seconds part fits in time_t.
2273 All callers changed.
2274 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2275 All callers changed.
2276 (Ffloat_time): Do not fail merely because the specified time falls
2277 outside of time_t range.
2279 2012-07-07 Glenn Morris <rgm@gnu.org>
2281 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2282 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2283 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2285 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
2287 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2288 Update dependencies.
2290 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2292 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2294 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2295 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2296 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2297 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2298 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2299 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2301 * xfont.c (compare_font_names): Redo to omit the need for casts.
2303 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2305 * xfns.c (Fx_change_window_property): Doc fix.
2306 * w32fns.c (Fx_change_window_property): Doc fix.
2308 * w32fns.c (Fx_window_property): Accept the same arguments as the
2309 X Windows version. Doc fix.
2310 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2312 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
2313 Eli Zaretskii <eliz@gnu.org>
2315 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2316 Windows-specific code from nt/config.nt moved here.
2317 Obsolete settings removed.
2319 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2321 * process.c: Avoid unnecessary calls to gettime.
2322 (wait_reading_process_output): Don't get the time of day
2323 when gobbling data immediately and not waiting, as there's no need
2324 for it in that case. This removes a FIXME.
2326 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2328 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2329 is defined (Bug#11768).
2331 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2333 Fix marker debugging code.
2334 * marker.c (byte_char_debug_check): Do not perform the check
2335 if buffer is not multibyte.
2336 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2337 Call byte_char_debug_check with correct arguments.
2339 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2341 Compile marker debugging code only if ENABLE_CHECKING is defined.
2342 * marker.c (byte_char_debug_check, count_markers):
2343 Use only if ENABLE_CHECKING is defined.
2344 (byte_debug_flag): Remove.
2345 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2346 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2348 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2350 Avoid code repetition in marker-related functions.
2351 * marker.c (attach_marker): New function.
2352 (Fset_marker, set_marker_restricted, set_marker_both)
2353 (set_marker_restricted_both): Use it.
2354 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2355 Consistently rename charno to charpos.
2356 (marker_position): Add eassert.
2357 (marker_byte_position): Convert to eassert.
2359 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2361 Simplify list operations in unchain_overlay and unchain_marker.
2362 * buffer.c (unchain_overlay): Simplify. Add comment.
2363 * marker.c (unchain_marker): Simplify. Fix comments.
2365 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2367 Introduce fast path for the widely used marker operation.
2368 * alloc.c (build_marker): New function.
2369 * lisp.h (build_marker): New prototype.
2370 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2371 * composite.c (autocmp_chars): Likewise.
2372 * editfns.c (buildmark): Remove.
2373 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2374 (save_restriction_save): Use build_marker.
2375 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2376 * window.c (save_window_save): Likewise.
2378 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2380 Do not use Fdelete_overlay in delete_all_overlays
2381 to avoid redundant calls to unchain_overlay.
2382 * buffer.c (drop_overlay): New function.
2383 (delete_all_overlays, Fdelete_overlay): Use it.
2384 * minibuf.c (get_minibuffer): Fix comment.
2386 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2388 Port to OpenBSD 5.1 amd64.
2389 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2390 This is needed for OpenBSD, and should be harmless on all BSD systems.
2391 Also, include <sys/sysctl.h>, as it should be available on all
2392 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2393 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2394 use p_pid member, not kp_proc.pid.
2396 2012-07-06 Glenn Morris <rgm@gnu.org>
2398 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2400 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2402 More xmalloc and related cleanup.
2403 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2404 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2405 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2406 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2407 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2408 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2409 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2410 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2411 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2413 Omit needless casts involving void * pointers and allocation.
2414 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2415 as the former is more robust if P's type is changed.
2416 Prefer xzalloc to xmalloc + memset 0.
2417 Simplify malloc-or-realloc to realloc.
2418 Don't worry about xmalloc returning a null pointer.
2419 Prefer xstrdup to xmalloc + strcpy.
2420 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2422 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2423 alloca of a constant.
2425 2012-07-05 Eli Zaretskii <eliz@gnu.org>
2427 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2428 hscroll is larger than the line width. Fixes long and futile
2429 looping inside extend_face_to_end_of_line (on a TTY) producing
2430 glyphs that are not needed and thrown away.
2432 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2434 * marker.c (set_marker_restricted_both): Simplify by using
2437 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2439 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2441 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2443 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2444 not defined (Bug#11768).
2445 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2446 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2447 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2448 followed by gtk_box_set_homogeneous (Bug#11768).
2449 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
2450 (update_theme_scrollbar_width, xg_create_scroll_bar):
2451 Use gtk_scrollbar_new (Bug#11768).
2452 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2453 (is_box_type): New function (Bug#11768).
2454 (xg_tool_item_stale_p): Call is_box_type.
2455 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
2456 with default display (Bug#11768).
2458 2012-07-05 Eli Zaretskii <eliz@gnu.org>
2460 * xdisp.c (window_hscroll_limited): New function.
2461 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2462 coordinates when window's hscroll is set to insanely large
2465 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
2467 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2468 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2470 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2473 * lisp.h (xzalloc): New prototype. Omit needless casts.
2474 * alloc.c (xzalloc): New function. Omit needless casts.
2475 * charset.c: Omit needless casts. Convert all calls to
2476 xmalloc with following memset to xzalloc.
2477 * dispnew.c: Likewise.
2478 * fringe.c: Likewise.
2479 * image.c: Likewise.
2480 * sound.c: Likewise.
2482 * w32fns.c: Likewise.
2483 * w32font.c: Likewise.
2484 * w32term.c: Likewise.
2485 * xfaces.c: Likewise.
2487 * xterm.c: Likewise.
2488 * atimer.c: Omit needless casts.
2489 * buffer.c: Likewise.
2490 * callproc.c: Likewise.
2492 * coding.c: Likewise.
2493 * composite.c: Likewise.
2495 * doprnt.c: Likewise.
2496 * editfns.c: Likewise.
2497 * emacs.c: Likewise.
2499 * filelock.c: Likewise.
2501 * gtkutil.c: Likewise.
2502 * keyboard.c: Likewise.
2504 * lread.c: Likewise.
2505 * minibuf.c: Likewise.
2506 * msdos.c: Likewise.
2507 * print.c: Likewise.
2508 * process.c: Likewise.
2509 * region-cache.c: Likewise.
2510 * search.c: Likewise.
2511 * sysdep.c: Likewise.
2512 * termcap.c: Likewise.
2513 * terminal.c: Likewise.
2514 * tparam.c: Likewise.
2515 * w16select.c: Likewise.
2517 * w32reg.c: Likewise.
2518 * w32select.c: Likewise.
2519 * w32uniscribe.c: Likewise.
2520 * widget.c: Likewise.
2521 * xdisp.c: Likewise.
2522 * xmenu.c: Likewise.
2524 * xselect.c: Likewise.
2526 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2528 * fileio.c (time_error_value): Check the right error number.
2529 Problem reported by Troels Nielsen in
2530 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2532 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2534 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2535 This should be fixed in a better way; see Eli Zaretskii in
2536 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2537 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2539 * fileio.c (time_error_value): Rename from special_mtime.
2540 The old name's problems were noted by Eli Zaretskii in
2541 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2543 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2544 This variable's comment says Emacs needs at least one GDB-visible
2545 symbol of type enum pvec_type, to work around GDB problems.
2546 The symbol's value doesn't matter.
2548 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2549 that causes compilation to fail on pre-C99 compilers.
2551 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
2553 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2554 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2556 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2558 * buffer.c (init_buffer_once): Fix initialization of
2559 headers for buffer_defaults and buffer_local_symbols.
2560 Reported by Juanma Barranquero <lekktu@gmail.com>.
2562 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2564 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2565 * lisp.h (enum pvec_type): Use fewer bits.
2566 (PSEUDOVECTOR_SIZE_BITS): New constant.
2567 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2568 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2569 change in pvec_type.
2570 (PSEUDOVECTOR_TYPEP): New macro.
2571 (TYPED_PSEUDOVECTORP): Use it.
2572 * fns.c (internal_equal): Adapt code to extract pvectype.
2573 * emacs.c (gdb_pvec_type): Update type.
2574 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2575 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2576 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2577 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2578 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2579 abusing vector->header.next.nbytes.
2580 (live_vector_p): Use PVEC_TYPE.
2581 (mark_object): Adapt code to extract pvectype. Use switch.
2583 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2585 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2586 Tighten new eassert a bit.
2588 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2590 Fix compilation with --enable-gcc-warnings and -O1
2592 * doprnt.c (doprnt): Change type of tem to int, initialize
2593 to avoid compiler warning. Add eassert.
2594 * search.c (simple_search): Initialize match_byte to avoid
2595 compiler warning. Add eassert.
2597 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2599 Avoid weird behavior with large horizontal scrolls.
2600 Without this change, for example, large hscroll values would
2601 mess up Emacs's display on Fedora 15 x86, presumably due to
2602 overflows in int calculations in the display code.
2603 Also, if buffers had long lines, Emacs would freeze.
2604 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2605 (set_window_hscroll): New function, containing the old guts of
2606 Fset_window_hscroll. Return the clipped value.
2607 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2608 This avoids the need to check against PTRDIFF_MAX.
2610 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2612 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2614 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2616 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2618 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2619 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2620 since GCC 4.4.6 issues a bogus warning for them.
2622 Fix bugs in file timestamp newness comparisons.
2623 * fileio.c (Ffile_newer_than_file_p):
2624 * lread.c (Fload): Use full timestamp resolution of files,
2625 not just the 1-second resolution, so that files that are only
2626 slightly newer still count as newer.
2627 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2628 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2630 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2632 * fileio.c: Improve handling of file time marker. (Bug#11852)
2633 (special_mtime): New function.
2634 (Finsert_file_contents, Fverify_visited_file_modtime):
2635 Use it to set special mtime values consistently.
2637 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2639 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2640 marker for non-existing file. (Bug#11852)
2642 2012-07-03 Glenn Morris <rgm@gnu.org>
2644 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2645 and did not make it into globals.h).
2647 2012-07-03 Tom Tromey <tromey@redhat.com>
2649 * window.c (Fset_window_margins, Fset_window_fringes)
2650 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2651 * textprop.c (Fprevious_property_change): No longer static.
2652 * syntax.c (Fsyntax_table_p): No longer static.
2653 * process.c (Fget_process, Fprocess_datagram_address): No longer
2655 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2656 * keyboard.c (Fcommand_execute): No longer static.
2658 * insdel.c (Fcombine_after_change_execute): No longer static.
2659 * image.c (Finit_image_library): No longer static.
2660 * fileio.c (Fmake_symbolic_link): No longer static.
2661 * eval.c (Ffetch_bytecode): No longer static.
2662 * editfns.c (Fuser_full_name): No longer static.
2663 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2665 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2667 * dired.c (Ffile_attributes): No longer static.
2668 * composite.c (Fcomposition_get_gstring): No longer static.
2669 * callproc.c (Fgetenv_internal): No longer static.
2671 * ccl.h: Remove EXFUNs.
2672 * buffer.h: Remove EXFUNs.
2673 * dispextern.h: Remove EXFUNs.
2674 * intervals.h: Remove EXFUNs.
2675 * fontset.h: Remove EXFUN.
2676 * font.h: Remove EXFUNs.
2677 * dosfns.c (system_process_attributes): Remove EXFUN.
2678 * keymap.h: Remove EXFUNs.
2679 * lisp.h: Remove EXFUNs.
2680 * w32term.h: Remove EXFUNs.
2681 * window.h: Remove EXFUNs.
2682 * xsettings.h: Remove EXFUN.
2683 * xterm.h: Remove EXFUN.
2685 2012-07-03 Glenn Morris <rgm@gnu.org>
2687 * lisp.h (Frandom): Make it visible to C.
2688 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2689 buffer for invisible buffers. (Bug#1229)
2691 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2693 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2694 values which aren't power of 2.
2695 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2696 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2699 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2701 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2703 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2705 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2707 * alloc.c (allocate_vector_block): Remove redundant
2708 calls to mallopt if DOUG_LEA_MALLOC is defined.
2709 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2710 avoid calls to mallopt if zero_vector is returned.
2712 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2714 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2715 is enabled, avoid dereferencing NULL current_sblock if
2718 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2720 Cleanup basic buffer management.
2721 * buffer.h (struct buffer): Change layout to use generic vector
2722 marking code. Fix some comments. Change type of 'clip_changed'
2723 to bitfield. Remove unused #ifndef old.
2724 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2725 (GET_OVERLAYS_AT): Fix indentation.
2726 (for_each_per_buffer_object_at): New macro.
2727 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2728 (Fbuffer_local_variables): Use it.
2729 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2730 * alloc.c (allocate_buffer): Adjust to match new layout of
2731 struct buffer. Fix comment.
2732 (mark_overlay): New function.
2733 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2734 Lisp area of struct buffer.
2735 (mark_object): Use it. Adjust marking of misc objects
2736 and related comments.
2738 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2740 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2741 wrapper that is not needed because the wrapped code is a no-op (zero
2742 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2743 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2745 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2747 * alloc.c (mark_buffer): Simplify. Remove prototype.
2748 (mark_object): Add comment. Reorganize marking of vector-like
2749 objects. Use CHECK_LIVE for all vector-like objects except buffers
2750 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2751 Avoid redundant calls to mark_vectorlike for bool vectors.
2753 2012-06-30 Glenn Morris <rgm@gnu.org>
2755 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2757 * epaths.in (PATH_SITELOADSEARCH): New.
2758 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2759 This is rather than relying on --enable-locallisppath elements
2760 having "site-lisp" in their names. (Bug#10208#25, 11658)
2762 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2764 * w32proc.c (sys_select): Accept and ignore one more argument.
2766 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2768 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2769 (pselect) [!MS_DOS]: Redirect to sys_select.
2771 * sysdep.c: Don't include dos.h and dosfns.h.
2773 * process.c (sys_select):
2774 * msdos.c (sys_select): Accept one more argument and ignore it.
2776 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2777 adapt data types and code to that.
2780 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2781 which clashes with the gnulib function of the same name.
2783 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2785 * font.c (font_style_to_value, font_style_symbolic)
2786 (font_prop_validate_style): Add type checks for values in
2789 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2791 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2794 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2796 * xdisp.c (try_window_id): Undo last change.
2798 * w32.c (getwd): Adjust commentary about startup_dir.
2799 (init_environment): Always call sys_access, even in non-MSVC
2800 builds. Don't chdir to the directory of the Emacs executable.
2801 This undoes code from 1997 which was justified by the need to
2802 "avoid conflicts when removing and renaming directories". But its
2803 downside was that every relative file name was being interpreted
2804 relative to the directory of the Emacs executable, which can never
2805 be TRT. In particular, it broke sys_access when called with
2806 relative file names.
2807 (sys_access): Map GetLastError to errno.
2809 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2811 * window.h (struct window): Change type of 'fringes_outside_margins'
2812 to bitfield. Fix comment. Adjust users accordingly.
2813 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2815 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2818 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2820 * gnutls.c (emacs_gnutls_handshake):
2821 Add QUIT to make the loop interruptible.
2823 2012-06-29 Glenn Morris <rgm@gnu.org>
2825 * charset.c (init_charset): Make lack of etc/charsets fatal.
2827 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2829 * editfns.c (region_limit): Fix type mismatch.
2831 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2833 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2834 undefined. Convert from xassert to eassert.
2835 * nsmenu.m: Convert from xassert to eassert.
2836 * nsterm.m: Likewise.
2838 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2840 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2842 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2844 Avoid integer overflow on scroll-left and scroll-right.
2845 * window.c (HSCROLL_MAX): New macro.
2846 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2847 overflow when requested scroll falls outside ptrdiff_t range.
2849 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2851 * window.h (struct window): Change type of 'hscroll',
2852 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2853 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2854 Adjust users accordingly.
2855 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2856 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2857 from EMACS_INT to ptrdiff_t.
2858 (make_window): Omit redundant initialization.
2860 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2862 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2864 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2866 * window.h (struct window): Change type of 'use_time' and
2867 'sequence_number' from Lisp_Object to int.
2868 * frame.c (make_frame): Adjust users accordingly.
2869 * print.c (print_object): Likewise.
2870 * window.c (select_window, Fwindow_use_time, make_parent_window)
2871 (make_window): Likewise.
2873 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2875 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2876 enabled with --enable-checking=[all,glyphs] configure option.
2877 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2878 adjust comments accordingly.
2879 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2880 undefined, adjust comments accordingly.
2881 * image.c: Likewise.
2882 * scroll.c: Likewise.
2883 * w32fns.c: Likewise.
2884 * w32term.c: Likewise.
2885 * xdisp.c: Likewise.
2886 * xfaces.c: Likewise.
2888 * xterm.c: Likewise.
2890 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2892 Generalize run-time debugging checks.
2893 * dispextern.h (XASSERTS): Remove.
2894 * fontset.c (xassert): Remove.
2895 Convert from xassert to eassert.
2896 * alloc.c: Convert from xassert to eassert.
2898 * dispnew.c: Likewise.
2900 * fringe.c: Likewise.
2901 * ftfont.c: Likewise.
2902 * gtkutil.c: Likewise.
2903 * image.c: Likewise.
2904 * keyboard.c: Likewise.
2906 * process.c: Likewise.
2907 * scroll.c: Likewise.
2908 * sound.c: Likewise.
2910 * w32console.c: Likewise.
2911 * w32fns.c: Likewise.
2912 * w32term.c: Likewise.
2913 * window.c: Likewise.
2914 * xdisp.c: Likewise.
2915 * xfaces.c: Likewise.
2917 * xselect.c: Likewise.
2918 * xterm.c: Likewise.
2920 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2922 * fns.c (maybe_resize_hash_table): Output message when growing the
2925 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2927 * alloc.c (allocate_string_data): Remove dead code.
2928 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2929 avoid GCC warning about unused macro.
2931 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2933 * alloc.c (allocate_string): Omit intervals initialization.
2934 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2935 as in make_pure_string and make_pure_c_string.
2937 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2939 * alloc.c (allocate_string): Fix last change.
2941 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2943 * alloc.c (allocate_string): Remove two redundant calls
2944 to memset, add explicit initialization where appropriate.
2946 2012-06-27 Glenn Morris <rgm@gnu.org>
2948 * lisp.mk (lisp): Remove paths.elc.
2950 2012-06-27 Chong Yidong <cyd@gnu.org>
2952 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2954 2012-06-26 John Wiegley <johnw@newartisans.com>
2956 * unexmacosx.c (copy_data_segment): Add two section names used
2957 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2959 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2960 when building with Clang.
2962 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2964 * eval.c (Fapply): Allow calling it with a single argument.
2966 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2968 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2969 _stricmp and _strnicmp.
2970 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2972 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2974 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2976 (allocate_process): Likewise for new process.
2977 (allocate_terminal): Change to use offsetof.
2978 (allocate_frame): Likewise.
2979 * frame.c (make_frame): Omit redundant initialization.
2980 * window.c (make_parent_window): Use memset.
2981 (make_window): Omit redundant initialization.
2982 * process.c (make_process): Omit redundant initialization.
2983 * terminal.c (create_terminal): Likewise.
2985 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2987 * term.c (delete_tty): Remove redundant call to memset.
2989 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2991 * alloc.c: Remove build_string.
2992 * lisp.h: Define build_string as static inline. This provides
2993 a better opportunity to optimize away calls to strlen when the
2994 function is called with compile-time constant argument.
2995 * image.c (imagemagick_error): Convert to build_string.
2996 * w32proc.c (sys_spawnve): Likewise.
2997 * xterm.c (x_term_init): Likewise.
2999 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3001 Use sprintf return value instead of invoking strlen on result.
3002 In the old days this wasn't portable, since some sprintf
3003 implementations returned char *. But they died out years ago and
3004 Emacs already assumes sprintf returns int.
3005 Similarly for float_to_string.
3006 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3007 * ccl.c (ccl_driver):
3008 * character.c (string_escape_byte8):
3009 * data.c (Fnumber_to_string):
3010 * doprnt.c (doprnt):
3011 * print.c (print_object):
3012 * xdisp.c (message_dolog):
3013 * xfns.c (syms_of_xfns):
3014 Use sprintf or float_to_string result to avoid need to call strlen.
3015 * data.c (Fnumber_to_string):
3016 Use make_unibyte_string, since the string must be ASCII.
3017 * lisp.h, print.c (float_to_string): Now returns int length.
3018 * term.c (produce_glyphless_glyph):
3019 Use sprintf result rather than recomputing it.
3021 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3022 * Makefile.in (ALL_CFLAGS):
3023 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3024 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3026 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3028 * dispextern.h (xstrcasecmp): Define to library function
3029 strcasecmp if available.
3030 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3032 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3034 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3035 Avoid comma operator.
3036 * menu.c (push_submenu_start, push_submenu_end)
3037 (push_left_right_boundary, push_menu_pane): Likewise.
3038 * msdos.c (dos_rawgetc): Likewise.
3040 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3042 * xfns.c (xic_create_fontsetname): Remove redundant calls
3045 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3047 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3048 sprintf already null-terminates its output.
3050 * xfns.c (x_window): Remove redundant cast.
3052 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3054 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3055 `const char *' to `char *' to avoid compiler warning.
3057 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3059 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3060 instead of truncating it to 63 (admittedly a generous limit).
3062 * process.c: Fix spelling and caps in comments.
3064 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3066 * emacs.c (setpgrp): Remove definition, unused.
3067 * sysdep.c (setpgrp): Remove definition, not used in this file.
3069 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
3071 * makefile.w32-in: Update dependencies.
3073 2012-06-24 Eli Zaretskii <eliz@gnu.org>
3075 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3076 (SYSTIME_H): Add nt/inc/sys/time.h.
3078 * systime.h [WINDOWSNT]: Include sys/time.h.
3080 * s/ms-w32.h (struct timespec): Definition moved from
3081 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3083 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3085 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3086 * buffer.h (buffer_slot_type_mismatch):
3087 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3088 * eval.c (unwind_to_catch):
3089 * image.c (my_png_error, my_error_exit):
3090 * keyboard.c (quit_throw_to_read_char, user_error)
3091 (Fexit_recursive_edit, Fabort_recursive_edit):
3092 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3093 (wrong_type_argument, buffer_overflow, __executable_start)
3094 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3095 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3096 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3098 (child_setup) [!DOS_NT]:
3099 * lread.c (end_of_file_error, invalid_syntax):
3100 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3101 * puresize.h (pure_write_error):
3102 * search.c (matcher_overflow):
3103 * sound.c (sound_perror, alsa_sound_perror):
3104 * sysdep.c, syssignal.h (croak):
3105 * term.c (maybe_fatal, vfatal):
3106 * textprop.c (text_read_only):
3107 * undo.c (user_error):
3108 * unexmacosx.c (unexec_error):
3109 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3110 Use _Noreturn rather than NO_RETURN.
3111 No need for separate decl merely because of _Noreturn.
3112 * sound.c (sound_warning, parse_sound):
3113 Remove unnecessary forward decls.
3115 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3117 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3118 * lisp.h (WAIT_READING_MAX): New macro.
3119 * dispnew.c (Fsleep_for, sit_for):
3120 * keyboard.c (kbd_buffer_get_event):
3121 * process.c (Faccept_process_output):
3122 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3123 This improves on the previous patch, which introduced a bug
3124 when time_t is unsigned and as wide as intmax_t.
3125 See <http://bugs.gnu.org/9000#51>.
3127 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3129 * dispnew.c (sit_for, Fsleep_for):
3130 * keyboard.c (kbd_buffer_get_event):
3131 * process.c (Faccept_process_output): Avoid compiler warnings when
3132 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3134 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
3136 * makefile.w32-in: Update dependencies.
3138 * w32.c (ltime): Add return type and declare static.
3139 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3141 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3143 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3144 Privately reported by Herbert J. Skuhra.
3145 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3147 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3148 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3150 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3152 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3153 last argument of make_unibyte_string.
3155 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3156 language ID in the event parameters.
3158 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3159 event.code, not the obscure "character set ID".
3161 2012-06-23 Chong Yidong <cyd@gnu.org>
3163 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3165 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3167 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3168 * w32.c (fdutimens): New function.
3170 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3172 * s/ms-w32.h (pselect): Redirect to sys_select.
3174 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3176 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3177 in the logic of incrementing and decrementing the value of
3178 use_relocatable_buffers.
3180 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3182 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3183 Privately reported by Herbert J. Skuhra.
3184 [__FreeBSD__]: Remove "*/" typo after "#include".
3185 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3186 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3187 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3188 Don't assume EMACS_TIME and struct timeval are the same type.
3190 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3192 Support higher-resolution time stamps (Bug#9000).
3193 The time stamps are only nanosecond-resolution at the C level,
3194 since that's the best that any real-world system supports now.
3195 But they are picosecond-resolution at the Lisp level, as that's
3196 easy, and leaves room for future OS improvements.
3198 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3201 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3202 Don't get current time unless it's needed.
3204 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3205 now provides it if it's absent.
3206 (start_atimer): Port to higher-res time stamps.
3207 Check for time stamp overflow. Don't get current time more
3208 often than is needed.
3210 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3211 Include systime.h, not time.h.
3212 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3214 * dired.c: Include stat-time.h.
3215 (Ffile-attributes): File times now have higher resolution.
3217 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3218 (struct image): Timestamp now has higher resolution.
3220 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3221 has at least microseconds now. All uses removed.
3222 (update_frame, update_single_window, update_window, update_frame_1)
3223 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3225 * editfns.c (time_overflow): Now extern.
3226 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3227 (float-time, Fformat_time_string, Fcurrent_time_string)
3228 (Fcurrent_time_zone): Accept and generate higher-resolution
3230 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3231 (decode_time_components, lisp_seconds_argument): New functions.
3232 (make_time): Now static.
3233 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3234 Report an error if the time is invalid, rather than having the caller
3237 * fileio.c: Include <stat-time.h>
3238 (Fcopy_file): Copy higher-resolution time stamps.
3239 Prefer to set the time stamp via a file descriptor if that works.
3240 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3241 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3242 (Fvisited_file_modtime, Fset_visited_file_modtime):
3243 Support higher-resolution time stamps.
3245 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3247 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3249 * image.c (prepare_image_for_display, clear_image_cache)
3250 (lookup_image): Port to higer-resolution time stamps.
3252 * keyboard.c (start_polling, bind_polling_period):
3253 Check for time stamp overflow.
3254 (read_char, kbd_buffer_get_event, timer_start_idle)
3255 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3256 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3257 Port to higher-resolution time stamps. Do not assume time_t is signed.
3258 (decode_timer): New function. Timers are now vectors of length 9,
3259 not 8, to accommodate the picosecond component.
3260 (timer_check_2): Use it.
3262 * nsterm.m (select_timeout, timeval_subtract): Remove.
3263 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3264 as they're a bit more accurate and handle overflow better.
3265 (ns_select): Change prototype to be compatible with pselect.
3266 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3267 * nsterm.h (ns_select): Adjust prototype.
3269 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3270 us-resolution time stamps.
3271 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3273 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3275 * lisp.h (time_overflow): New decl.
3276 (wait_reading_process_output): First arg is now intmax_t, not int,
3277 to accommodate larger waits.
3279 * process.h (struct Lisp_Process.read_output_delay):
3280 Now counts nanoseconds, not microseconds.
3281 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3283 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3284 (wait_reading_process_output):
3285 Port to ns-resolution time stamps.
3286 (Faccept_process_output, wait_reading_process_output):
3287 Check for time stamp overflow. Do not assume time_t is signed.
3288 (select_wrapper): Remove; we now use pselect.
3289 (Fprocess_attributes): Now generates ns-resolution time stamps.
3291 * sysdep.c: Include utimens.h. Don't include utime.h
3292 or worry about struct utimbuf; gnulib does that for us now.
3293 (gettimeofday): Remove; gnulib provides a substitute.
3294 (make_timeval): New function.
3295 (set_file_times): Now sets ns-resolution time stamps.
3296 New arg FD; all uses changed.
3297 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3298 (system_process_attributes):
3299 Now returns ns-resolution time stamp. All uses changed.
3300 Check for time stamp overflow.
3302 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3303 provides a substitute now.
3305 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3306 since it guarantees struct timespec.
3307 (EMACS_TIME): Now struct timespec, so that we can support
3308 ns-resolution time stamps.
3309 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3310 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3311 (EMACS_USECS): Remove.
3312 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3313 so multiply the arg by 1000 before storing it.
3314 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3316 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3317 Port to ns-resolution time stamps.
3318 (EMACS_TIME_NEG_P): Remove; replaced by....
3319 (EMACS_TIME_SIGN): New macro.
3320 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3321 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3322 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3323 (make_timeval, make_lisp_time, decode_time_components): New decls.
3324 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3325 that it mishandled time_t overflow. You can't compare by subtracting!
3326 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3327 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3329 * term.c: Include <sys/time.h>.
3330 (timeval_to_Time): New function, for proper overflow wraparound.
3331 (term_mouse_position, term_mouse_click): Use it.
3333 * undo.c (record_first_change): Support higher-resolution time stamps
3335 (Fprimitive_undo): Use them when restoring time stamps.
3337 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3338 (w32_get_internal_run_time):
3339 Port to higher-resolution Emacs time stamps.
3340 (ltime): Now accepts single 64-bit integer, as that's more convenient
3343 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3345 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3346 for compatibility with pselect. Support ns-resolution time stamps.
3348 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3350 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3351 Check for time stamp overflow, and support ns-resolution time stamps.
3353 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3354 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3355 (timeval_subtract): Remove; no longer needed.
3356 (XTflash, XTring_bell, x_wait_for_event):
3357 Port to ns-resolution time stamps. Don't assume time_t is signed.
3359 2012-06-22 Chong Yidong <cyd@gnu.org>
3361 * xdisp.c (x_consider_frame_title): Revert last change.
3363 2012-06-22 Eli Zaretskii <eliz@gnu.org>
3365 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3366 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3367 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3368 staticidx goes up to 1597 out of 1600 = 0x640.)
3370 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3372 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3373 Otherwise, the umask might be mistakenly 0 while handling input signals.
3375 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3377 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3379 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3381 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3382 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3383 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3384 access to `contents' member of Lisp_Vector objects with AREF and ASET
3387 2012-06-19 Chong Yidong <cyd@gnu.org>
3389 * frame.c (delete_frame): When selecting a frame on a different
3390 text terminal, do not alter the terminal's top-frame.
3392 * xdisp.c (format_mode_line_unwind_data): Record the target
3393 frame's selected window and its terminal's top-frame.
3394 (unwind_format_mode_line): Restore them.
3395 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3397 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3398 since tty frames can be explicitly named.
3399 (prepare_menu_bars): Likewise.
3401 * term.c (Ftty_top_frame): New function.
3403 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3405 Port byte-code-meter to modern targets.
3406 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3407 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
3408 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
3409 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3410 (METER_1, METER_2): Simplify.
3412 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3414 * data.c (Fdefalias): Return `symbol' (bug#11686).
3416 2012-06-18 Martin Rudalics <rudalics@gmx.at>
3418 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
3419 gets killed during executing of this function (Bug#11665).
3420 Try to always return Qt when the buffer has been actually killed.
3421 (Vkill_buffer_query_functions): In doc-string say that functions
3422 run by this hook should not change the current buffer.
3424 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3426 Fix recently-introduced process.c problems found by static checking.
3427 * process.c (write_queue_push, write_queue_pop, send_process):
3428 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3429 (write_queue_pop): Fix pointer signedness problem.
3430 (send_process): Remove unused local.
3432 2012-06-17 Chong Yidong <cyd@gnu.org>
3434 * xdisp.c (redisplay_internal): No need to redisplay terminal
3435 frames that are not on top.
3437 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
3439 * process.c (make_process): Initialize write_queue.
3440 (write_queue_push, write_queue_pop): New functions.
3441 (send_process): Use them to maintain correct ordering of process
3444 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3446 * lisp.h (eassert): Assume C89 or later.
3447 This removes the need for CHECK.
3448 (CHECK): Remove. Its comments about always evaluating its
3449 argument were confusing, as 'eassert' typically does not evaluate
3452 * coding.c (produce_chars): Use ptrdiff_t, not int.
3454 * xterm.c (x_draw_underwave): Check for integer overflow.
3455 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3457 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
3459 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3460 referenced (Bug#11583).
3462 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3464 Implement wave-style variant of underlining.
3465 * dispextern.h (face_underline_type): New enum.
3466 (face): Add field for underline type.
3467 * nsterm.m (ns_draw_underwave): New function.
3468 (ns_draw_text_decoration): Use it.
3469 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3471 (x_draw_glyph_string): Use them.
3472 * xfaces.c (Qline, Qwave): New Lisp objects.
3473 (check_lface_attrs, merge_face_ref)
3474 (Finternal_set_lisp_face_attribute, realize_x_face):
3475 Handle wave-style underline face attributes.
3476 * xterm.c (x_draw_underwave): New function.
3477 (x_draw_glyph_string): Use it.
3479 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
3481 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3482 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3483 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3484 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3485 ($(BLD)/w32select.$(O)): Update dependencies.
3487 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3489 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3490 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3491 * character.c (_fetch_multibyte_char_p): Remove.
3492 * alloc.c: Include "character.h" before "buffer.h".
3494 * buffer.c: Likewise.
3495 * bytecode.c: Likewise.
3496 * callint.c: Likewise.
3497 * callproc.c: Likewise.
3498 * casefiddle.c: Likewise.
3499 * casetab.c: Likewise.
3500 * category.c: Likewise.
3502 * coding.c: Likewise.
3503 * composite.c: Likewise.
3504 * dired.c: Likewise.
3505 * dispnew.c: Likewise.
3507 * dosfns.c: Likewise.
3508 * editfns.c: Likewise.
3509 * emacs.c: Likewise.
3510 * fileio.c: Likewise.
3511 * filelock.c: Likewise.
3513 * fontset.c: Likewise.
3514 * fringe.c: Likewise.
3515 * indent.c: Likewise.
3516 * insdel.c: Likewise.
3517 * intervals.c: Likewise.
3518 * keyboard.c: Likewise.
3519 * keymap.c: Likewise.
3520 * lread.c: Likewise.
3521 * macros.c: Likewise.
3522 * marker.c: Likewise.
3523 * minibuf.c: Likewise.
3524 * nsfns.m: Likewise.
3525 * nsmenu.m: Likewise.
3526 * print.c: Likewise.
3527 * process.c: Likewise.
3528 * regex.c: Likewise.
3529 * region-cache.c: Likewise.
3530 * search.c: Likewise.
3531 * syntax.c: Likewise.
3533 * textprop.c: Likewise.
3535 * unexsol.c: Likewise.
3536 * w16select.c: Likewise.
3537 * w32fns.c: Likewise.
3538 * w32menu.c: Likewise.
3539 * window.c: Likewise.
3540 * xdisp.c: Likewise.
3542 * xmenu.c: Likewise.
3544 * xselect.c: Likewise.
3546 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3548 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3549 If all the glyphs of the glyph row came from strings, and we have no
3550 cursor positioning clues, put the cursor on the first glyph of the
3552 (handle_face_prop): Use chunk-relative overlay string index when
3553 indexing into it->string_overlays array. (Bug#11653)
3554 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3555 the rightmost. (Bug#11720)
3557 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3559 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3560 (CATEGORY_MEMBER): Enforce 1/0 value.
3561 * category.c (_temp_category_set): Remove.
3563 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3565 * window.c (Fdelete_other_windows_internal)
3566 (Fdelete_window_internal): Don't access frame's mouse highlight
3567 info of the initial frame. (Bug#11677)
3569 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3571 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3572 Assume USE_2_TAGS_FOR_INTS.
3573 (xreload): Adjust $tagmask width to match recent lisp.h change.
3575 Simplify lisp.h in minor ways that should not affect code.
3576 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3577 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3578 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3579 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3580 (INTTYPEBITS): New macro, for clarity.
3581 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3582 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3583 Simplify now that USE_LSB_TAG is always defined.
3584 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3585 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3587 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3589 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3591 2012-06-13 Glenn Morris <rgm@gnu.org>
3593 * s/bsd-common.h (BSD4_3):
3594 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3596 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3598 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3601 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3603 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3604 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3605 * alloc.c (widen_to_Lisp_Object): Remove.
3606 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3607 * frame.c (delete_frame): Remove outdated comment.
3608 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3609 USE_LISP_UNION_TYPE.
3610 (Fw32_unregister_hot_key): Likewise.
3611 (Fw32_toggle_lock_key): Likewise.
3612 * w32menu.c (add_menu_item): Likewise.
3613 (w32_menu_display_help): Use XIL instead of checking
3614 USE_LISP_UNION_TYPE.
3615 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3616 (init_heap): Likewise.
3617 * w32term.c (w32_read_socket): Update comment.
3619 2012-06-13 Glenn Morris <rgm@gnu.org>
3621 * s/usg5-4-common.h, src/s/unixware.h:
3622 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3624 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3626 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3628 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3629 * alloc.c (make_number) [!defined make_number]:
3630 Remove, as lisp.h always defines this now.
3631 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3632 (roundup_size): Verify that it is a power of 2.
3633 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3634 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3635 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3636 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3637 USE_LSB_TAG now is always defined to be either 0 or 1.
3639 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3640 code works fine either way, and efficiency is not a concern here,
3641 as the union type is for debugging, not for production.
3642 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3643 Use an inline function on all platforms when using the union type,
3644 since this is simpler and 'static inline' can be used portably
3646 (LISP_INITIALLY_ZERO): New macro.
3647 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3648 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3650 2012-06-12 Glenn Morris <rgm@gnu.org>
3652 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3654 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3656 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3657 Move BROKEN_SIGIO to configure.
3659 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3660 Move NO_TERMIO to configure.
3662 2012-06-12 Chong Yidong <cyd@gnu.org>
3664 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3665 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3666 MagickExportImagePixels is undefined.
3668 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3670 * image.c (imagemagick_load_image): Remove unused label.
3672 2012-06-11 Glenn Morris <rgm@gnu.org>
3674 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3675 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3676 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3677 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3679 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3681 * alloc.c (make_byte_code): New function.
3682 (Fmake_byte_code): Use it. Don't purify here.
3683 * lread.c (read1): Use it as well to avoid extra allocation.
3685 2012-06-11 Chong Yidong <cyd@gnu.org>
3687 * image.c (imagemagick_load_image): Implement transparency.
3689 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3691 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3692 account for preceding backslashes. (Bug#11663)
3694 2012-06-09 Chong Yidong <cyd@gnu.org>
3696 * term.c: Support italics in capable terminals (Bug#9652).
3697 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3698 (turn_on_face): Output using TS_enter_italic_mode if available.
3699 Don't handle unused blinking and alt-charset cases.
3700 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3701 and tty_alt_charset_p cases.
3702 (tty_capable_p, init_tty): Support italics.
3704 * termchar.h (struct tty_display_info): Add field for italics.
3705 Remove unused blink field.
3707 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3710 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3711 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3712 tty_alt_charset_p. Add tty_italic_p.
3714 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3716 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3717 dbus_type_is_basic if available.
3718 (xd_extract_signed, xd_extract_unsigned): Rename from
3719 extract_signed and extract_unsigned, respectively. Adapt callers.
3721 2012-06-09 Chong Yidong <cyd@gnu.org>
3723 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3725 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3728 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3730 * xdisp.c (vmessage): Treat frame message as multibyte.
3731 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3732 would generate the diagnostic "Making \302\247 buffer-local while
3735 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3737 * dispnew.c (showing_window_margins_p): Undo last change, which
3738 was done due to an inadvertent commit.
3739 (adjust_frame_glyphs_for_frame_redisplay): Do call
3740 showing_window_margins_p.
3742 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3744 * eval.c (Fmake_var_non_special): New primitive.
3745 (syms_of_eval): Defsubr it.
3746 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3748 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3750 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3751 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3753 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3755 * alloc.c (allocate_vectorlike): Fix last change.
3757 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3759 Block-based vector allocation of small vectors.
3760 * lisp.h (struct vectorlike_header): New field `nbytes',
3761 adjust comment accordingly.
3762 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3763 to denote vector blocks. Adjust users (live_vector_p,
3764 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3765 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3766 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3767 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3768 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3769 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3770 (roundup_size): New constant.
3771 (struct vector_block): New data type.
3772 (vector_blocks, vector_free_lists, zero_vector): New variables.
3773 (all_vectors): Rename to `large_vectors'.
3774 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3775 (sweep_vectors): New functions.
3776 (allocate_vectorlike): Return `zero_vector' as the only vector of
3777 0 items. Allocate new vector from block if vector size is less than
3778 or equal to VBLOCK_BYTES_MAX.
3779 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3780 (init_alloc_once): Add call to init_vectors.
3782 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3784 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3786 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3788 * doprnt.c (doprnt): Truncate multibyte char correctly.
3789 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3790 would mishandle a string argument "Xc" if X was a multibyte
3791 character of length 2: it would truncate after X's first byte
3792 rather than including all of X.
3794 2012-06-06 Chong Yidong <cyd@gnu.org>
3796 * buffer.c (word_wrap): Doc fix.
3798 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3800 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3802 2012-06-03 Glenn Morris <rgm@gnu.org>
3804 * xdisp.c (tool-bar-style): Doc fix.
3806 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3808 * Makefile.in (PAXCTL): Define.
3809 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3810 binary via PaX flags if the paxctl utility is available.
3811 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3812 Restore PaX flags to their default. (Bug#11398)
3814 2012-06-03 Chong Yidong <cyd@gnu.org>
3816 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3819 2012-06-03 Chong Yidong <cyd@gnu.org>
3821 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3822 (note_mode_line_or_margin_highlight): If there is no help echo,
3823 use mode-line-default-help-echo. Handle the case where the mouse
3824 position is past the end of the mode line string.
3826 * buffer.c (buffer_local_value_1): New function, split from
3827 Fbuffer_local_value; can return Qunbound.
3828 (Fbuffer_local_value): Use it.
3829 (Vmode_line_format): Docstring tweaks.
3831 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3833 * sysdep.c (system_process_attributes): Improve comment.
3835 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3837 * keyboard.c: Export real-this-command to Elisp.
3838 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3839 and DEFVAR it. Update all users.
3841 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3843 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3845 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3846 Convert pctcpu and pctmem to Lisp float properly.
3847 Let the compiler fold better, as 100.0/0x8000 is exact.
3849 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3851 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3854 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3856 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3858 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3860 For a 'struct window', replace some Lisp_Object fields to
3861 bitfields where appropriate, remove unused fields.
3862 * window.h (struct window): Remove unused 'last_mark_x' and
3863 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3864 change it's type from Lisp_Object to bitfield.
3865 Change type of 'force_start', 'optional_new_start',
3866 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3867 fields from Lisp_Object to bitfield. Adjust users accordingly.
3869 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3871 Pacify gcc -Wdouble-precision when using Xaw.
3872 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3873 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3874 Use 'float' consistently, rather than 'float' in most places
3875 and 'double' in a couple of places.
3877 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3879 * xdisp.c (handle_stop): Detect whether we have overlay strings
3880 loaded by testing it->current.overlay_string_index to be
3881 non-negative, instead of checking whether n_overlay_strings is
3882 positive. (Bug#11587)
3884 2012-05-31 Chong Yidong <cyd@gnu.org>
3886 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3888 * doc.c (Fsubstitute_command_keys): Doc fix.
3890 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3892 * search.c (search_buffer): Remove calls to
3893 r_alloc_inhibit_buffer_relocation, as it is now called by
3894 maybe_unify_char, which was the cause of relocation of buffer text
3897 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3899 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3900 for the duration of call to load_charset, to avoid problems with
3901 callers of maybe_unify_char that access buffer text through C
3904 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3905 decrement the inhibition flag, instead of just setting or
3908 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3910 Remove obsolete '#define static' cruft.
3911 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3912 This #undef was "temporary" in 2000; it is no longer needed
3913 now that '#define static' has gone away.
3914 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3915 (gray_bitmap_bits): Remove; no longer needed.
3916 All uses replaced with definiens.
3917 * xterm.c: Include "bitmaps/gray.xbm".
3919 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3921 Clean up __executable_start, monstartup when --enable-profiling.
3922 The following changes affect the code only when profiling.
3923 * dispnew.c (__executable_start): Rename from safe_bcopy.
3924 Define only on platforms that need it.
3925 * emacs.c: Include <sys/gmon.h> when profiling.
3926 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3927 (__executable_start): Remove decl, since lisp.h does it now.
3928 (safe_bcopy): Remove decl; no longer has that name.
3929 (main): Coalesce #if into single bit of code, for simplicity.
3930 Cast pointers to uintptr_t, since standard libraries want integers
3932 * lisp.h (__executable_start): New decl.
3934 2012-05-31 Glenn Morris <rgm@gnu.org>
3936 * image.c (Fimagemagick_types): Doc fix.
3938 2012-05-30 Jim Meyering <meyering@redhat.com>
3940 * callproc.c (Fcall_process_region): Include directory component
3941 in mkstemp error message (Bug#11586).
3943 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3945 * alloc.c, lisp.h (make_pure_vector): Now static.
3947 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3949 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3950 Move to byte-run.el.
3951 (Fautoload): Do the hash-doc more carefully.
3952 * data.c (Fdefalias): Purify definition, except for keymaps.
3953 (Qdefun): Move from eval.c.
3954 * lisp.h (Qdefun): Remove.
3955 * lread.c (read1): Tiny simplification.
3957 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3959 Do not create empty overlays with the evaporate property (Bug#9642).
3960 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3961 Bug#9642, but explicitly check that the buffer the overlay would
3962 be moved to is live and rearrange lines to make sure that errors
3963 will not put the overlay in an inconsistent state.
3964 (Fdelete_overlay): Cosmetics.
3966 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3968 * w32term.c (my_bring_window_to_top): New function.
3969 (x_raise_frame): Use handle returned by DeferWindowPos, which
3970 could be different from the original one.
3971 Call my_bring_window_to_top instead of my_set_foreground_window.
3974 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3975 by calling BringWindowToTop.
3977 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3978 (WM_EMACS_END): Increase by one.
3980 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3982 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3983 This avoids undefined behavior that might cause the eassert
3984 to not catch an out-of-range value.
3986 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3988 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3989 Update dependencies.
3991 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3993 * bidi.c (bidi_mirror_char): Fix last change.
3995 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3997 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3998 when referring to sectname field in printf format.
4000 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4002 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4003 Only r_alloc_inhibit_buffer_relocation needed to be added;
4004 the others were already declared.
4006 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4007 before checking whether it's out of range. Put the check inside
4009 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4011 2012-05-27 Ken Brown <kbrown@cornell.edu>
4013 * callproc.c (Fcall_process): Restore a line that was accidentally
4014 commented out in the 2011-02-13 change (bug#11547).
4016 2012-05-27 Eli Zaretskii <eliz@gnu.org>
4018 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4019 defined on ralloc.c.
4021 * buffer.c [REL_ALLOC]: Remove prototypes of
4022 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4023 they are now on lisp.h.
4025 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4027 * search.c (search_buffer): Use it to inhibit relocation of buffer
4028 text while re_search_2 is doing its job, because re_search_2 is
4029 passed C pointers to buffer text. (Bug#11519)
4031 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4034 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4035 state after an additional call to move_it_in_display_line_to, keep
4036 the values of it->max_ascent and it->max_descent found for the
4038 (pos_visible_p): Revert the comparison against bottom_y to what it
4039 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4042 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4044 Fix coding-related core dumps with gcc -ftrapv.
4045 The code was computing A - B, where A and B are pointers, and B is
4046 random garbage. This can lead to core dumps on platforms that
4047 have special pointer registers, and it also leads to core dumps on
4048 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4049 A - B only when B is initialized properly.
4050 * coding.c (coding_set_source, coding_set_destination): Return void.
4051 (coding_change_source, coding_change_destinations): New functions,
4052 with the old behaviors of coding_set_source and coding_set_destination.
4053 All callers that need an offset changed to use these new functions.
4055 2012-05-26 Glenn Morris <rgm@gnu.org>
4057 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4059 2012-05-26 Eli Zaretskii <eliz@gnu.org>
4061 Extend mouse support on W32 text-mode console.
4062 * xdisp.c (draw_row_with_mouse_face):
4063 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
4065 * w32console.c: Include window.h.
4066 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4068 (initialize_w32_display): Initialize mouse-highlight data.
4070 * w32inevt.c: Include termchar.h and window.h.
4071 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4072 moves, call note_mouse_highlight. If help_echo changed, call
4073 gen_help_event to produce help-echo message in the echo area.
4074 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4077 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4079 * lread.c (read1): Simplify slightly to avoid an overflow warning
4080 with GCC 4.7.0 on x86-64.
4082 2012-05-26 Eli Zaretskii <eliz@gnu.org>
4084 * bidi.c (bidi_mirror_char): Revert last change: an int is
4085 definitely wide enough here.
4087 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
4089 Fix integer width and related bugs (Bug#9874).
4090 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
4091 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4092 (string_bytes, check_sblock, allocate_string_data):
4093 (compact_small_strings, Fmake_bool_vector, make_string)
4094 (make_unibyte_string, make_multibyte_string)
4095 (make_string_from_bytes, make_specified_string)
4096 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4097 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4100 (allocate_pseudovector):
4101 Use int, not EMACS_INT, where int is wide enough.
4102 (inhibit_garbage_collection, Fgarbage_collect):
4103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4104 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4105 int might not be wide enough.
4106 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4107 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4108 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4109 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4110 (bidi_level_of_next_char, bidi_move_to_visually_next):
4111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4112 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4113 (Fkill_buffer, Fset_buffer_major_mode)
4114 (advance_to_char_boundary, Fbuffer_swap_text)
4115 (Fset_buffer_multibyte, overlays_at, overlays_in)
4116 (overlay_touches_p, struct sortvec, record_overlay_string)
4117 (overlay_strings, recenter_overlay_lists)
4118 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4119 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4120 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4121 (Foverlay_recenter, last_overlay_modification_hooks_used)
4122 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4124 (validate_region): Omit unnecessary test for b <= e,
4125 since that's guaranteed by the previous test.
4126 (adjust_overlays_for_delete): Avoid pos + length overflow.
4127 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4128 (report_overlay_modification):
4129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4130 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4131 Omit pointer cast, which isn't needed anyway, and doesn't work
4132 after the EMACS_INT -> ptrdiff_t change.
4133 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
4134 * buffer.h: Adjust decls to match defn changes elsewhere.
4135 (struct buffer_text, struct buffer):
4136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4137 Use EMACS_INT, not int, where int might not be wide enough.
4138 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4139 not int, to avoid needless 32-bit limit on 64-bit hosts.
4140 (exec_byte_code): Use tighter memory-full test, one that checks
4141 for alloca overflow. Don't compute the address of the object just
4142 before an array, as that's not portable. Use EMACS_INT, not
4143 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
4144 * callint.c (Fcall_interactively):
4145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4146 * callproc.c (call_process_kill, Fcall_process):
4147 Don't assume pid_t fits into an Emacs fixnum.
4148 (call_process_cleanup, Fcall_process, child_setup):
4149 Don't assume pid_t fits into int.
4150 (call_process_cleanup, Fcall_process, delete_temp_file)
4151 (Fcall_process_region):
4152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4153 (Fcall_process): Simplify handling of volatile integers.
4154 Use int, not EMACS_INT, where int will do.
4155 * casefiddle.c (casify_object, casify_region, operate_on_word)
4156 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4158 (casify_object): Avoid integer overflow when overallocating buffer.
4159 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
4160 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
4161 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4162 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4163 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4164 integers are now checked earlier. All uses replaced with XINT.
4166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4167 For CCL_MapSingle, check that content and value are in int range.
4168 (ccl_driver, Fregister_code_conversion_map):
4169 Check that Vcode_version_map_vector is a vector.
4170 (resolve_symbol_ccl_program): Check that vector header is in range.
4171 Always copy the vector, so that we can check its contents reliably
4172 now rather than having to recheck each instruction as it's being
4173 executed. Check that vector words fit in 'int'.
4174 (ccl_get_compiled_code, Fregister_ccl_program)
4175 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4176 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4177 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4178 contents are in range.
4179 (Fccl_execute_on_string): Check that status is in range.
4180 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4181 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4182 Accept and return EMACS_INT, not int, because callers can pass values
4184 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4185 (multibyte_chars_in_text, parse_str_as_multibyte)
4186 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4187 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4188 (string_escape_byte8, Fget_byte):
4189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4190 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
4191 avoid mishandling large integers.
4192 * character.h: Adjust decls to match defn changes elsewhere.
4193 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4194 (Ffind_charset_region):
4195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4196 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4197 (load_charset_map_from_vector, Fdefine_charset_internal):
4198 Don't assume fixnum fits in int.
4199 (load_charset_map_from_vector, Fmap_charset_chars):
4200 Remove now-unnecessary CHECK_NATNUMs.
4201 (Fdefine_charset_internal): Check ranges here, more carefully.
4202 Don't rely on undefined behavior with signed left shift overflow.
4203 Don't assume unsigned int fits into fixnum, or that fixnum fits
4204 into unsigned int. Don't require max_code to be a valid fixnum;
4205 that's not true for gb10830 4-byte on a 32-bit host. Allow
4206 invalid_code to be a cons, for the same reason. Require code_offset
4207 to be a character. Avoid int overflow if max_char is close
4209 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4210 this is intended anyway and avoids some undefined behavior.
4211 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4212 INDEX_TO_CODE_POINT, as that's what it expects.
4213 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
4214 * charset.h (DECODE_CHAR): Return int, not unsigned;
4215 this is what was intended anyway, and it avoids undefined behavior.
4216 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4217 integer-overflow issues.
4218 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4219 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4220 where the argument is EMACS_INT, and this behavior is not intended.
4221 * chartab.c (Fmake_char_table, Fset_char_table_range)
4222 (uniprop_get_decoder, uniprop_get_encoder):
4223 Don't assume fixnum fits in int.
4224 * cmds.c (move_point): New function, that does the gist of
4225 Fforward_char and Fbackward_char, but does so while checking
4226 for integer overflow more accurately.
4227 (Fforward_char, Fbackward_char): Use it.
4228 (Fforward_line, Fend_of_line, internal_self_insert)
4229 (internal_self_insert):
4230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4231 Fix a FIXME, by checking for integer overflow when calculating
4232 target_clm and actual_clm.
4233 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
4234 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
4235 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4236 (coding_alloc_by_making_gap, alloc_destination)
4237 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4238 (encode_coding_utf_16, detect_coding_emacs_mule)
4239 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4240 (detect_coding_iso_2022, decode_coding_iso_2022)
4241 (encode_invocation_designation, encode_designation_at_bol)
4242 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4243 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4244 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4245 (encode_coding_ccl, encode_coding_raw_text)
4246 (detect_coding_charset, decode_coding_charset)
4247 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4248 (produce_composition, produce_charset, produce_annotation)
4249 (decode_coding, handle_composition_annotation)
4250 (handle_charset_annotation, consume_chars, decode_coding_gap)
4251 (decode_coding_object, encode_coding_object, detect_coding_system)
4252 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4253 (code_convert_region, code_convert_string)
4254 (Fdefine_coding_system_internal)
4255 (coding_set_source, coding_set_destination):
4256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4257 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4258 (Fdefine_coding_system_internal):
4259 Don't assume fixnums fit in int.
4260 (decode_coding_gap, decode_coding_object, encode_coding_object)
4261 (Fread_coding_system, Fdetect_coding_region)
4262 (Funencodable_char_position, Fcheck_coding_systems_region)
4263 (get_translation, handle_composition_annotation, consume_chars):
4264 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4265 (consume_chars): Rewrite to not calculate an address outside buffer.
4266 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
4267 Don't access memory outside of the args array.
4268 (Fdefine_coding_system_internal): Check for charset-id overflow.
4269 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4270 result of ENCODE_CHAR.
4271 * coding.h: Adjust decls to match defn changes elsewhere.
4272 (struct coding_system):
4273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4274 * composite.c (get_composition_id, find_composition)
4275 (run_composition_function, update_compositions)
4276 (compose_text, composition_gstring_put_cache)
4277 (composition_gstring_p, composition_gstring_width)
4278 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4279 (composition_compute_stop_pos, composition_reseat_it)
4280 (composition_update_it, struct position_record)
4281 (find_automatic_composition, composition_adjust_point)
4282 (Fcomposition_get_gstring, Ffind_composition_internal):
4283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4284 (update_compositions):
4285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4286 * composite.h: Adjust decls to match defn changes elsewhere.
4287 (struct composition):
4288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4289 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4290 Do not attempt to compute the address of the object just before a
4291 buffer; this is not portable.
4293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4294 (Faset): Use int, not EMACS_INT, where int is wide enough.
4295 (Fstring_to_number): Don't assume fixnums fit in int.
4296 (Frem): Don't assume arg is nonnegative.
4297 * dbusbind.c (xd_append_arg): Check for integers out of range.
4298 (Fdbus_call_method): Don't overflow the timeout int.
4299 (extract_signed, extract_unsigned): New functions.
4300 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4301 (xd_get_connection_references): Return ptrdiff_t, not int.
4303 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4304 (xd_read_message_1):
4305 Use int, not unsigned, where the dbus API uses int.
4306 (Fdbus_message_internal): Don't overflow mtype.
4307 (syms_of_dbusbind): Allocate right-sized buffer for integers.
4308 * dired.c (directory_files_internal, file_name_completion, scmp)
4309 (file_name_completion_stat):
4310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4311 (file_name_completion): Don't overflow matchcount.
4312 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4313 * dispextern.h: Adjust decls to match defn changes elsewhere.
4314 (struct text_pos, struct glyph, struct bidi_saved_info)
4315 (struct bidi_string_data, struct bidi_it, struct composition_it)
4317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4318 (struct display_pos, struct composition_it, struct it):
4319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4320 * dispnew.c (increment_matrix_positions)
4321 (increment_row_positions, mode_line_string)
4322 (marginal_area_string):
4323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4324 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
4325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4326 (duration_to_sec_usec): New function, to check for overflow better.
4327 (Fsleep_for, sit_for): Use it.
4328 * doc.c (get_doc_string, store_function_docstring):
4329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4330 (get_doc_string, Fsnarf_documentation):
4331 Use int, not EMACS_INT, where int is wide enough.
4333 Use SAFE_ALLOCA, not alloca.
4334 Check for overflow when converting EMACS_INT to off_t.
4335 * doprnt.c (doprnt):
4336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4337 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4338 Don't assume uid_t fits into fixnum.
4339 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4340 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4341 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4342 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4343 (general_insert_function)
4344 (Finsert_char, make_buffer_string, make_buffer_string_both)
4345 (update_buffer_properties, Fbuffer_substring)
4346 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4347 (Fsubst_char_in_region, check_translation)
4348 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4349 (transpose_markers, Ftranspose_regions):
4350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4351 (clip_to_bounds): Move to lisp.h as an inline function).
4352 (Fconstrain_to_field): Don't assume integers are nonnegative.
4353 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4354 (Fsubst_char_in_region, Fsave_restriction):
4355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4356 (Femacs_pid): Don't assume pid_t fits into fixnum.
4357 (lo_time): Use int, not EMACS_INT, when int suffices.
4358 (lisp_time_argument): Check for usec out of range.
4359 (Fencode_time): Don't assume fixnum fits in int.
4360 (Fuser_login_name, Fuser_full_name): Signal an error
4361 if a uid argument is out of range, rather than relying on
4363 (Fformat_time_string): Remove now-unnecessary check.
4364 lisp_time_argument checks for out-of-range usec now.
4365 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
4366 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4367 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4368 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4369 (init_cmdargs, Fdump_emacs):
4370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4371 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4372 the bottom (typically) 32 bits of the fixnum.
4373 * eval.c (specpdl_size, call_debugger):
4374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4375 (when_entered_debugger, Fbacktrace_debug):
4376 Don't assume fixnum can fit in int.
4377 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4378 the object just before a buffer; this is not portable.
4379 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4380 (grow_specpdl, unbind_to):
4381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4382 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4383 (grow_specpdl): Simplify allocation by using xpalloc.
4384 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
4385 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4386 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4388 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4391 (Fcopy_file, non_regular_nbytes, read_non_regular)
4392 (Finsert_file_contents):
4393 Use int, not EMACS_INT, where int is wide enough.
4394 (READ_BUF_SIZE): Verify that it fits in int.
4395 (Finsert_file_contents): Check that counts are in proper range,
4396 rather than assuming fixnums fit into ptrdiff_t etc.
4397 Don't assume fixnums fit into int.
4398 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
4399 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4400 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
4401 (string_char_to_byte, string_byte_to_char)
4402 (string_make_multibyte, string_to_multibyte)
4403 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4404 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4405 (substring_both, Fdelete, internal_equal, Ffillarray)
4406 (Fclear_string, mapcar1)
4407 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4408 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4409 (larger_vector, make_hash_table, maybe_resize_hash_table)
4410 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4411 (Fmaphash, secure_hash):
4412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4413 (concat): Check for string index and length overflow.
4414 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4417 (larger_vector): New API (vec, incr_min, size_max) replaces old
4418 one (vec, new_size, init). This catches size overflow.
4419 INIT was removed because it was always Qnil.
4420 All callers changed.
4421 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4422 the upper bound on a hash table index size.
4423 (make_hash_table, maybe_resize_hash_table): Use it.
4424 (secure_hash): Computer start_byte and end_byte only after
4425 they're known to be in ptrdiff_t range.
4426 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4427 (Ffont_get_glyphs, Ffont_at):
4428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4429 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4430 (Flist_fonts, Fopen_font):
4431 Don't assume fixnum can fit in int.
4432 (check_gstring): Don't assume index can fit in int.
4433 (font_match_p): Check that fixnum is a character, not a nonnegative
4434 fixnum, since the later code needs to stuff it into an int.
4435 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4436 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4437 conversion overflow issues.
4438 (Fopen_font): Check for integer out of range.
4439 (Ffont_get_glyphs): Don't assume index can fit in int.
4440 * font.h: Adjust decls to match defn changes elsewhere.
4441 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4443 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4444 printmax_t, where ptrdiff_t is wide enough.
4445 (Finternal_char_font):
4446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4447 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4448 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4449 (Fset_frame_position, x_set_frame_parameters)
4450 (x_set_line_spacing, x_set_border_width)
4451 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4452 Check that fixnums are in proper range for system types.
4453 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4455 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4456 Use SAFE_ALLOCA_LISP, not alloca.
4457 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4458 intptr_t is wide enough.
4459 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4460 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4461 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4462 Check for fixnum out of range.
4463 * ftfont.c (ftfont_list): Don't assume index fits in int.
4464 Check that fixnums are in proper range for system types.
4465 (ftfont_shape_by_flt):
4466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4467 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4469 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4470 Check that fixnums are in proper range for system types.
4471 * gnutls.h: Adjust decls to match defn changes elsewhere.
4472 * gtkutil.c (xg_dialog_run):
4473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4474 (update_frame_tool_bar):
4475 Check that fixnums are in proper range for system types.
4476 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
4477 (lookup_image): Check that fixnums are in range for system types.
4478 * indent.c (last_known_column, last_known_column_point):
4479 (current_column_bol_cache):
4480 (skip_invisible, current_column, check_display_width):
4481 (check_display_width, scan_for_column, current_column_1)
4482 (Findent_to, Fcurrent_indentation, position_indentation)
4483 (indented_beyond_p, Fmove_to_column, compute_motion):
4484 (Fcompute_motion, Fvertical_motion):
4485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4486 (last_known_column_modified): Use EMACS_INT, not int.
4487 (check_display_width):
4489 Check that fixnums and floats are in proper range for system types.
4490 (compute_motion): Don't assume index or fixnum fits in int.
4491 (compute_motion, Fcompute_motion):
4492 Use int, not EMACS_INT, when it is wide enough.
4493 (vmotion): Omit local var start_hpos that is always 0; that way
4494 we don't need to worry about overflow in expressions involving it.
4495 * indent.h: Adjust decls to match defn changes elsewhere.
4497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4498 Use int, not EMACS_INT, where int is wide enough.
4499 Remove unused members ovstring_chars_done and tab_offset;
4501 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4502 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4503 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4504 (make_gap, copy_text, insert, insert_and_inherit)
4505 (insert_before_markers, insert_before_markers_and_inherit)
4506 (insert_1, count_combining_before, count_combining_after)
4507 (insert_1_both, insert_from_string)
4508 (insert_from_string_before_markers, insert_from_string_1)
4509 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4510 (adjust_after_replace, adjust_after_insert, replace_range)
4511 (replace_range_2, del_range, del_range_1, del_range_byte)
4512 (del_range_both, del_range_2, modify_region)
4513 (prepare_to_modify_buffer, signal_before_change)
4514 (signal_after_change, Fcombine_after_change_execute):
4515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4516 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4517 (balance_an_interval, split_interval_right, split_interval_left)
4518 (find_interval, next_interval, update_interval)
4519 (adjust_intervals_for_insertion, delete_node, delete_interval)
4520 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4521 (static_offset_intervals, offset_intervals)
4522 (merge_interval_right, merge_interval_left, make_new_interval)
4523 (graft_intervals_into_buffer, temp_set_point_both)
4524 (temp_set_point, set_point, adjust_for_invis_intang)
4525 (set_point_both, move_if_not_intangible, get_property_and_range)
4526 (get_local_map, copy_intervals, copy_intervals_to_string)
4527 (compare_string_intervals, set_intervals_multibyte_1):
4528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4529 * intervals.h: Adjust decls to match defn changes elsewhere.
4531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4532 * keyboard.c (this_command_key_count, this_single_command_key_start)
4533 (before_command_key_count, before_command_echo_length, echo_now)
4534 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4535 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4536 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4537 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4539 (last_non_minibuf_size, last_point_position, echo_truncate)
4540 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4541 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4542 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4543 (stuff_buffered_input):
4544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4545 (last_auto_save, command_loop_1, read_char):
4546 Use EMACS_INT, not int, to avoid integer overflow.
4547 (record_char): Avoid overflow in total_keys computation.
4548 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4549 * keyboard.h: Adjust decls to match defn changes elsewhere.
4550 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4551 (Fkey_description, Fdescribe_vector, Flookup_key):
4552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4553 (click_position): New function, to check that positions are in range.
4554 (Fcurrent_active_maps):
4556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4557 (Faccessible_keymaps, Fkey_description):
4558 (preferred_sequence_p):
4559 Don't assume fixnum can fit into int.
4560 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4561 Check for integer overflow in size calculations.
4562 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4563 avoid mishandling large integers.
4564 * lisp.h: Adjust decls to match defn changes elsewhere.
4565 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4566 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4567 (struct Lisp_Marker):
4568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4569 (clip_to_bounds): Now an inline function, moved here from editfns.c.
4570 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4571 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4572 All callers changed.
4573 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4574 Assume the arg has valid form, since it always does.
4575 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4576 unsigned integer system type.
4577 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4578 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4580 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4581 (duration_to_sec_usec): New decl.
4582 * lread.c (read_from_string_index, read_from_string_index_byte)
4583 (read_from_string_limit, readchar, unreadchar, openp)
4584 (read_internal_start, read1, oblookup):
4585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4586 (Fload, readevalloop, Feval_buffer, Feval_region):
4587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4588 (openp): Check for out-of-range argument to 'access'.
4589 (read1): Use int, not EMACS_INT, where int is wide enough.
4590 Don't assume fixnum fits into int.
4591 Fix off-by-one error that can read outside a buffer.
4592 (read_filtered_event): Use duration_to_sec_usec
4593 to do proper overflow checking on durations.
4594 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4595 in size calculation.
4596 (Fexecute_kbd_macro):
4597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4598 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4599 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4600 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4601 (set_marker_both, set_marker_restricted_both, marker_position)
4602 (marker_byte_position, Fbuffer_has_markers_at):
4603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4604 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4605 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4606 It now merely ensures that the menu is large enough, without
4607 necessarily growing it, as this avoids some integer overflow issues.
4608 All callers changed.
4609 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4611 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4612 Use SAFE_ALLOCA_LISP, not alloca.
4613 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4614 to EMACS_INT. Check that fixnums are in proper range for system types.
4615 * minibuf.c (minibuf_prompt_width, string_to_object)
4616 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4617 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4619 (get_minibuffer, read_minibuf_unwind):
4620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4621 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4622 this simplifies overflow checking. All callers changed.
4623 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4626 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4627 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4628 Check that fixnums are in proper range for system types.
4629 (Fx_create_frame, Fx_show_tip):
4630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4631 * nsfont.m (ns_findfonts, nsfont_list_family):
4632 Don't assume fixnum fits in long.
4633 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4635 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4637 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4639 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4640 (PRINTDECLARE, PRINTPREPARE):
4641 (strout, print_string):
4642 (print, print_preprocess, print_check_string_charset_prop)
4644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4646 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4648 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4649 (printchar, strout): Use xpalloc to catch size calculation overflow.
4650 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4651 (print_error_message): Use SAFE_ALLOCA, not alloca.
4652 (print_object): Use int, not EMACS_INT, where int is wide enough.
4653 (print_depth, new_backquote_output, print_number_index):
4654 Use ptrdiff_t, not int, where int might not be wide enough.
4655 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4656 (Fset_process_window_size, Fformat_network_address)
4657 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4659 Check that fixnums are in proper range for system types.
4660 (Fsignal_process): Simplify by avoiding a goto.
4661 Check for process-ids out of pid_t range rather than relying on
4663 (process_tick, update_tick): Use EMACS_INT, not int.
4664 (Fformat_network_address, read_process_output, send_process)
4665 (Fprocess_send_region, status_notify):
4666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4667 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4668 (wait_reading_process_output, read_process_output, exec_sentinel):
4669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4670 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4671 (Faccept_process_output): Use duration_to_sec_usec to do proper
4672 overflow checking on durations.
4673 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4674 Don't assume pid_t fits in int.
4675 * process.h (struct Lisp_Process): Members tick and update_tick
4676 are now of type EMACS_INT, not int.
4677 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4678 configured --with-wide-int.
4679 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4680 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4681 * search.c (looking_at_1, string_match_1):
4682 (fast_string_match, fast_c_string_match_ignore_case)
4683 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4684 (scan_newline, find_before_next_newline, search_command)
4685 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4686 (set_search_regs, wordify):
4689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4690 (string_match_1, search_buffer, set_search_regs):
4692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4693 (wordify): Check for overflow in size calculation.
4694 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4695 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4696 Check that fixnums are in proper range for system types.
4697 * sound.c (struct sound_device)
4698 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4700 (Fplay_sound_internal):
4701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4702 * syntax.c (struct lisp_parse_state, find_start_modiff)
4703 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4704 (Fparse_partial_sexp):
4705 Don't assume fixnums can fit in int.
4706 (struct lisp_parse_state, find_start_pos, find_start_value)
4707 (find_start_value_byte, find_start_begv)
4708 (update_syntax_table, char_quoted, dec_bytepos)
4709 (find_defun_start, prev_char_comend_first, back_comment):
4710 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4711 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4713 (Finternal_describe_syntax_value): Check that match_lisp is a
4714 character, not an integer, since the code stuffs it into int.
4715 (scan_words, scan_sexps_forward):
4716 Check that fixnums are in proper range for system types.
4718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4719 (scan_sexps_forward):
4720 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4721 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4722 * syntax.h: Adjust decls to match defn changes elsewhere.
4723 (struct gl_state_s):
4724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4725 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4726 MOST_POSITIVE_FIXNUM.
4727 * sysdep.c (wait_for_termination_1, wait_for_termination)
4728 (interruptible_wait_for_termination, mkdir):
4729 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4730 (emacs_read, emacs_write):
4731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4732 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4733 and double all fit in int.
4734 * term.c (set_tty_color_mode):
4735 Check that fixnums are in proper range for system types.
4736 * termhooks.h (struct input_event):
4737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4738 * textprop.c (validate_interval_range, interval_of)
4739 (Fadd_text_properties, set_text_properties_1)
4740 (Fremove_text_properties, Fremove_list_of_text_properties)
4741 (Ftext_property_any, Ftext_property_not_all)
4742 (copy_text_properties, text_property_list, extend_property_ranges)
4743 (verify_interval_modification):
4744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4745 (Fnext_single_char_property_change)
4746 (Fprevious_single_char_property_change):
4747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4748 (copy_text_properties):
4749 Check for integer overflow in index calculation.
4750 * undo.c (last_boundary_position, record_point, record_insert)
4751 (record_delete, record_marker_adjustment, record_change)
4752 (record_property_change):
4753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4754 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4756 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4757 (Fx_hide_tip, Fx_file_dialog):
4758 * w32menu.c (set_frame_menubar):
4759 Use ptrdiff_t, not int, for consistency with rest of code.
4760 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4761 (select_window, Fdelete_other_windows_internal)
4762 (window_scroll_pixel_based, window_scroll_line_based)
4763 (Frecenter, Fset_window_configuration):
4764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4765 (Fset_window_hscroll, run_window_configuration_change_hook)
4766 (set_window_buffer, temp_output_buffer_show, scroll_command)
4767 (Fscroll_other_window, Frecenter):
4768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4769 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4770 Don't assume fixnum fits in int.
4771 (Fset_window_scroll_bars):
4772 Check that fixnums are in proper range for system types.
4773 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4774 (string_pos, c_string_pos, number_of_chars, init_iterator)
4775 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4776 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4777 (compute_display_string_end, handle_face_prop)
4778 (face_before_or_after_it_pos, handle_invisible_prop)
4779 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4780 (display_prop_intangible_p, string_buffer_position_lim)
4781 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4782 (get_overlay_strings_1, get_overlay_strings)
4783 (iterate_out_of_display_property, forward_to_next_line_start)
4784 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4785 (get_next_display_element, set_iterator_to_next)
4786 (get_visually_first_element, compute_stop_pos_backwards)
4787 (handle_stop_backwards, next_element_from_buffer)
4788 (move_it_in_display_line_to, move_it_in_display_line)
4789 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4790 (add_to_log, message_dolog, message_log_check_duplicate)
4791 (message2, message2_nolog, message3, message3_nolog
4792 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4793 (current_message_1, truncate_echo_area, truncate_message_1)
4794 (set_message, set_message_1, store_mode_line_noprop)
4795 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4796 (text_outside_line_unchanged_p, check_point_in_composition)
4797 (reconsider_clip_changes)
4798 (redisplay_internal, set_cursor_from_row, try_scrolling)
4799 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4800 (redisplay_window, find_last_unchanged_at_beg_row)
4801 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4802 (trailing_whitespace_p, find_row_edges, display_line)
4803 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4804 (display_mode_element, store_mode_line_string)
4805 (pint2str, pint2hrstr, decode_mode_spec)
4806 (display_count_lines, display_string, draw_glyphs)
4807 (x_produce_glyphs, x_insert_glyphs)
4808 (rows_from_pos_range, mouse_face_from_buffer_pos)
4809 (fast_find_string_pos, mouse_face_from_string_pos)
4810 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4812 (safe_call, init_from_display_pos, handle_fontified_prop)
4813 (handle_single_display_spec, load_overlay_strings)
4814 (with_echo_area_buffer, setup_echo_area_for_printing)
4815 (display_echo_area, echo_area_display)
4816 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4817 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4818 (redisplay_window, dump_glyph_row, display_mode_line)
4819 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4820 (handle_display_spec, display_prop_string_p):
4821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4822 (handle_single_display_spec, build_desired_tool_bar_string)
4823 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4824 (get_specified_cursor_type):
4825 Check that fixnums are in proper range for system types.
4826 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4827 (Flookup_image_map):
4828 Don't assume fixnums fit in int.
4829 (compare_overlay_entries):
4830 Avoid mishandling comparisons due to subtraction overflow.
4831 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4832 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4833 (handle_tool_bar_click):
4834 Use int, not unsigned, since we prefer signed and the signedness
4835 doesn't matter here.
4836 (get_next_display_element, next_element_from_display_vector):
4837 Use int, not EMACS_INT, when int is wide enough.
4838 (start_hourglass): Use duration_to_sec_usec to do proper
4839 overflow checking on durations.
4840 * xfaces.c (Fbitmap_spec_p):
4841 Check that fixnums are in proper range for system types.
4842 (compare_fonts_by_sort_order):
4843 Avoid mishandling comparisons due to subtraction overflow.
4844 (Fx_family_fonts, realize_basic_faces):
4845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4847 Don't assume fixnum fits in int.
4848 Use SAFE_ALLOCA_LISP, not alloca.
4849 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4850 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4851 (face_at_buffer_position, face_for_overlay_string)
4852 (face_at_string_position):
4853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4854 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4855 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4857 Check that fixnums are in proper range for system types.
4858 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4859 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4861 (Fx_change_window_property): Don't assume fixnums fit in int.
4862 * xfont.c (xfont_chars_supported):
4863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4864 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4865 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4867 * xml.c (parse_region):
4868 * xrdb.c (magic_file_p):
4869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4870 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4871 (x_get_local_selection, x_reply_selection_request)
4872 (x_handle_selection_request, wait_for_property_change):
4873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4874 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4875 short is wide enough.
4876 (x_send_client_event): Don't assume fixnum fits in int.
4877 * xterm.c (x_x_to_emacs_modifiers):
4878 Don't assume EMACS_INT overflows nicely into int.
4879 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4881 (handle_one_xevent): NATNUMP can eval its arg twice.
4882 (x_connection_closed):
4883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4884 * xterm.h: Adjust decls to match defn changes elsewhere.
4885 (struct scroll_bar): Use struct vectorlike_header
4886 rather than rolling our own approximation.
4887 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4889 2012-05-25 Glenn Morris <rgm@gnu.org>
4891 * lisp.mk (lisp): Update for more files being compiled now.
4893 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4895 * lread.c: Remove `read_pure' which makes no difference.
4896 (read_pure): Remove var.
4897 (unreadpure): Remove function.
4898 (readevalloop): Don't call read_list with -1 flag.
4899 (read1, read_vector): Don't test read_pure any more.
4900 (read_list): Simplify.
4902 * fileio.c, character.h: Minor style tweaks.
4904 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4906 * window.h (clip_changed): Remove useless declaration.
4908 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4910 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4911 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4913 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4916 This directory predates autoconf and is no longer needed nowadays.
4917 Move its few remaining bits of functionality to where they're needed.
4918 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4919 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4920 * m/template.h: Remove.
4921 * Makefile.in (M_FILE): Remove. All uses removed.
4922 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4923 * lisp.h (USE_LSB_TAG):
4924 * mem-limits.h (EXCEEDS_LISP_PTR):
4925 Use VAL_MAX, not VALBITS, in #if.
4926 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4927 (EMACS_UINT): Define unconditionally now.
4928 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4929 (BITS_PER_EMACS_INT): New constants, replacing
4930 what used to be in config.h, but not useful in #if.
4931 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4932 define them any more.
4933 (VAL_MAX): New macro.
4935 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4936 BITS_PER_EMACS_INT, in #if.
4937 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4938 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4939 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4940 * s/ms-w32.h (DATA_START):
4941 Move here from removed file m/intel386.h.
4942 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4943 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4945 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4947 Assume C89 or later.
4948 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4949 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4951 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4952 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4953 * textprop.c, tparam.c (NULL): Remove.
4954 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4955 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4956 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4957 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4958 * xterm.c (input_signal_count): Assume volatile works.
4960 2012-05-21 Ken Brown <kbrown@cornell.edu>
4962 * xgselect.c (xg_select): Fix first argument in call to 'select'
4965 2012-05-20 Ken Brown <kbrown@cornell.edu>
4967 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4968 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4970 2012-05-19 Ken Brown <kbrown@cornell.edu>
4972 * xfns.c (x_in_use): Remove `static' qualifier.
4973 * xterm.h (x_in_use): Declare.
4974 * xgselect.c: Include xterm.h.
4975 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4976 and `display_arg' (bug#9754).
4978 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4980 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4982 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4983 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4985 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4987 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4989 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4990 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4992 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4993 reference to image_cache->refcount.
4994 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4996 2012-05-17 Juri Linkov <juri@jurta.org>
4998 * search.c (Fword_search_regexp, Fword_search_backward)
4999 (Fword_search_forward, Fword_search_backward_lax)
5000 (Fword_search_forward_lax): Move functions to isearch.el
5001 (bug#10145, bug#11381).
5003 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5005 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5007 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5009 * lread.c (init_obarray): Declare Qt and Qnil as special.
5011 2012-05-14 Glenn Morris <rgm@gnu.org>
5013 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
5014 Put "libexec" before "bin", for the sake of init_callproc_1.
5016 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5018 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5020 * unexaix.c: Port to more-recent AIX compilers.
5021 (report_error, report_error_1, make_hdr, copy_sym)
5022 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5023 Make arguments const char *, not char *, to avoid violations of C
5024 standard and to fix some AIX warnings reported by Gilles Pion.
5026 2012-05-14 Eli Zaretskii <eliz@gnu.org>
5028 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5029 already have overlays loaded.
5030 (handle_single_display_spec): Before returning without displaying
5031 fringe bitmap, synchronize the bidi iterator with the main display
5032 iterator, by calling iterate_out_of_display_property.
5033 (iterate_out_of_display_property): Detect buffer iteration by
5034 testing that it->string is a Lisp string.
5035 (get_next_display_element): When the current object is exhausted,
5036 and there's something on it->stack, call set_iterator_to_next to
5037 proceed with what's on the stack, instead of returning zero.
5038 (set_iterator_to_next): If called at the end of a Lisp string,
5039 proceed to consider_string_end without incrementing string
5040 position. Don't increment display vector index past the end of
5041 the display vector. (Bug#11417)
5042 (pos_visible_p): Don't report a position visible when move_it_to
5043 stopped at the last line of window, which happens to be scanned
5044 backwards by the bidi iteration. (Bug#11464)
5046 2012-05-14 Eli Zaretskii <eliz@gnu.org>
5048 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5049 and right-margin display specs even if the spec is invalid or we
5050 are on a TTY, and thus unable to display on the fringes.
5051 That's because the text with the property will not be displayed anyway,
5052 so we need to signal to the caller that this is a "replacing"
5053 display spec. This fixes display when the spec is invalid or we
5056 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5058 * unexaix.c (make_hdr): Fix typo in prototype.
5059 This bug broke the build on AIX. Problem reported by Gilles Pion.
5061 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
5063 * keyboard.c (kbd_buffer_get_event): Read special events also in
5064 batch mode. (Bug#11415)
5066 2012-05-12 Glenn Morris <rgm@gnu.org>
5068 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5070 2012-05-12 Eli Zaretskii <eliz@gnu.org>
5072 * lisp.mk (lisp): Add newcomment.elc.
5074 2012-05-12 Glenn Morris <rgm@gnu.org>
5076 * Makefile.in (MKDIR_P): New, set by configure.
5077 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5079 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5081 Remove unused function hourglass_started.
5082 * dispextern.h (hourglass_started):
5083 * w32fns.c (hourglass_started):
5084 * xdisp.c (hourglass_started): Remove.
5086 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
5088 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5089 Update dependencies.
5091 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5093 * xgselect.c (xg_select): Put maxfds+1 into a var.
5094 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5096 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5098 2012-05-10 Dave Abrahams <dave@boostpro.com>
5100 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5101 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5103 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
5105 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5106 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5107 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5108 Initialize xd_registered_buses.
5110 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5112 Untag more efficiently if USE_LSB_TAG.
5113 This is based on a proposal by YAMAMOTO Mitsuharu in
5114 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5115 For an admittedly artificial (nth 8000 longlist) benchmark on
5116 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5117 Emacs's overall text size by 1%.
5118 * lisp.h (XUNTAG): New macro.
5119 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5120 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5121 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5122 * eval.c (Fautoload):
5123 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5124 * frame.h (XFRAME): Use XUNTAG.
5126 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5127 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5128 Remove unportable assumptions about print widths of types like
5130 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5131 intptr_t when converting between pointer and integer, to avoid GCC
5132 warnings about wrong width.
5134 2012-05-09 Eli Zaretskii <eliz@gnu.org>
5136 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5137 stack for each reader_thread, instead of defaulting to 8MB
5138 determined by the linker. This avoids failures in creating
5139 subprocesses on Windows 7, see the discussion in this thread:
5140 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5142 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5144 Fix up display of the *Minibuf-0* buffer in the mini window.
5145 * keyboard.c (read_char): Don't clear the echo area if there's no
5147 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
5148 contents of *Minibuf-0*) if there's no message displayed in its stead.
5150 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
5152 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5155 2012-05-06 Chong Yidong <cyd@gnu.org>
5157 * lisp.mk (lisp): Update.
5159 2012-05-05 Jim Meyering <meyering@redhat.com>
5161 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5163 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5165 * data.c (PUT_ERROR): New macro.
5166 (syms_of_data): Use it. Add new error type `user-error'.
5167 * undo.c (user_error): New function.
5168 (Fprimitive_undo): Use it.
5169 * print.c (print_error_message): Adjust print style for `user-error'.
5170 * keyboard.c (user_error): New function.
5171 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5173 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5175 Do not limit current-time-string to years 1000..9999.
5176 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5177 (Fcurrent_time_string): Support any year that is supported by the
5178 underlying localtime representation. Don't use asctime, as it
5179 has undefined behavior for years outside the range -999..9999.
5181 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5183 Fix race conditions involving setenv, gmtime, localtime, asctime.
5184 Without this fix, interrupts could mess up code that uses these
5185 nonreentrant functions, since setting TZ invalidates existing
5186 tm_zone or tzname values, and since most of these functions return
5187 pointers to static storage.
5188 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5189 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5190 Grow the critical sections to include not just invoking
5191 localtime/gmtime, but also accessing these functions' results
5192 including their tm_zone values if any, and any related TZ setting.
5193 (format_time_string): Last arg is now struct tm *, not struct tm **,
5194 so that the struct tm is saved in the critical section.
5195 All callers changed. Simplify allocation of initial buffer, partly
5196 motivated by the fact that memory allocation needs to be outside
5197 the critical section.
5199 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5201 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5202 with RESET_INTERVAL.
5204 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5205 Remove duplicated buffer name initialization.
5207 2012-05-02 Jim Meyering <jim@meyering.net>
5209 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5211 * xfns.c (x_window): Use xstrdup (Bug#11375).
5213 2012-05-02 Eli Zaretskii <eliz@gnu.org>
5215 * xdisp.c (pos_visible_p): If already at a newline from the
5216 display string before the 'while' loop, don't walk back the glyphs
5217 from it3.glyph_row. Solves assertion violation when the display
5218 string begins with a newline (egg.el). (Bug#11367)
5220 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5222 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5225 2012-05-01 Glenn Morris <rgm@gnu.org>
5227 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5228 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5229 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5230 All were removed before 23.1.
5232 * dispnew.c: Remove HAVE_LIBNCURSES test;
5233 it is always true on relevant platforms.
5235 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5236 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5238 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5240 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5242 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5243 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5246 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5248 Do not avoid creating empty evaporating overlays (Bug#9642).
5249 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5250 That is, do not delete an evaporating overlay if it becomes
5251 empty after its bounds are adjusted to fit within its buffer.
5252 This fix caused other problems, and I'm reverting it until we get
5253 to the bottom of them.
5255 2012-04-27 Chong Yidong <cyd@gnu.org>
5257 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5259 2012-04-27 Eli Zaretskii <eliz@gnu.org>
5261 * xdisp.c (pos_visible_p): If the window start position is beyond
5262 ZV, start the display from buffer beginning. Prevents assertion
5263 violation in init_iterator when the minibuffer window is scrolled
5266 * window.c (window_scroll_pixel_based): Likewise.
5268 2012-04-27 Chong Yidong <cyd@gnu.org>
5270 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5272 2012-04-27 Glenn Morris <rgm@gnu.org>
5274 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5275 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5277 2012-04-27 Eli Zaretskii <eliz@gnu.org>
5279 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5280 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
5282 2012-04-26 Eli Zaretskii <eliz@gnu.org>
5284 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5285 display element, check also the underlying string or buffer
5286 character. (Bug#11341)
5288 * w32menu.c: Include w32heap.h.
5289 (add_menu_item): If the call to AppendMenuW (via
5290 unicode_append_menu) fails, disable Unicode menus only if we are
5291 running on Windows 9X/Me.
5293 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5295 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5296 (xgetint): Add missing shift for LSB tags.
5298 2012-04-24 Martin Rudalics <rudalics@gmx.at>
5300 * keyboard.c (read_char): Don't wipe echo area for select window
5301 events: These might get delayed via `mouse-autoselect-window'
5304 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
5306 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5307 manipulation of :loaded-from data.
5309 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
5311 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5312 now a cons (bug#11311).
5314 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5316 Do not create empty overlays with the evaporate property (Bug#9642).
5317 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5318 if it becomes empty after its bounds are adjusted to fit within
5319 its buffer. Without this fix, in a nonempty buffer (let ((o
5320 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5321 yields an empty overlay that has the evaporate property, which is
5322 not supposed to happen.
5324 Fix minor GTK3 problems found by static checking.
5325 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5326 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5327 (struct _EmacsFixedClass, emacs_fixed_get_type):
5328 Move decls here from emacsgtkfixed.h, since they needn't be public.
5329 (emacs_fixed_get_type): Now static.
5330 (emacs_fixed_class_init): Omit unused local.
5331 (emacs_fixed_child_type): Remove; unused.
5332 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5333 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5334 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5335 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5336 (EMACS_FIXED_GET_CLASS): Remove; unused.
5337 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5339 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5340 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5342 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5344 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
5345 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
5346 (__malloc_size_t, __malloc_ptrdiff_t):
5347 Remove. All uses removed, replaced by the definiens if needed,
5348 since we can assume C89 or better now.
5349 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5350 (protect_malloc_state, align, get_contiguous_space)
5351 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5352 (malloc_atfork_handler_child, malloc_enable_thread)
5353 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5354 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5355 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5356 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5357 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5358 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5359 Define using prototypes, not old style.
5360 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5361 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5362 (align): Don't assume that signed integer overflow wraps around.
5363 Omit unused local var.
5364 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5365 (_free_internal_nolock, memalign, mallochook, reallochook):
5366 Omit no-longer-needed casts.
5367 (valloc): Use getpagesize, not __getpagesize.
5368 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5369 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5371 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5373 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
5375 Move functions from C to Lisp. Make non-blocking method calls
5376 the default. Implement further D-Bus standard interfaces.
5378 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5379 (QCdbus_request_name_allow_replacement)
5380 (QCdbus_request_name_replace_existing)
5381 (QCdbus_request_name_do_not_queue)
5382 (QCdbus_request_name_reply_primary_owner)
5383 (QCdbus_request_name_reply_in_queue)
5384 (QCdbus_request_name_reply_exists)
5385 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5386 (QCdbus_registered_serial, QCdbus_registered_method)
5387 (QCdbus_registered_signal): New Lisp objects.
5388 (XD_DEBUG_MESSAGE): Use sizeof.
5389 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5390 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5391 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5392 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5393 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5394 (xd_signature, xd_append_arg): Allow float for integer types.
5395 (xd_get_connection_references): New function.
5396 (xd_get_connection_address): Rename from xd_initialize.
5397 Return cached address.
5398 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5399 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5401 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
5402 Return number of refcounts.
5403 (Fdbus_get_unique_name): Make stronger parameter check.
5404 (Fdbus_message_internal): New defun.
5405 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5406 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5407 (Fdbus_send_signal, Fdbus_register_service)
5408 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5409 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5410 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5411 (Vdbus_compiled_version, Vdbus_runtime_version)
5412 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5413 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5414 (Vdbus_message_type_signal): New defvars.
5415 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5418 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5420 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5421 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5422 Do not assume ptrdiff_t is the same width as 'int'.
5424 * alloc.c: Handle unusual debugging option combinations.
5425 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5426 since the two debugging options are incompatible.
5427 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5429 (mem_init, mem_insert, mem_insert_fixup):
5430 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5431 (NEED_MEM_INSERT): Remove; no longer needed.
5433 2012-04-22 Leo Liu <sdl.web@gmail.com>
5435 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5437 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5439 * sysdep.c [__FreeBSD__]: Minor cleanups.
5440 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5441 Use Emacs indenting style more consistently. Avoid some casts.
5442 Use 'double' consistently rather than mixing 'float' and 'double'.
5444 2012-04-21 Eduard Wiebe <usenet@pusto.de>
5446 * sysdep.c (list_system_processes, system_process_attributes):
5447 Add implementation for FreeBSD (Bug#5243).
5449 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5451 * lisp.mk (lisp): Update.
5453 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5455 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5456 It is never used otherwise.
5458 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5460 * print.c (print_preprocess): Only check print_depth if print-circle
5462 (print_object): Check for cycles even when print-circle is nil and
5463 print-gensym is t, but only check print_depth if print-circle is nil.
5465 2012-04-20 Chong Yidong <cyd@gnu.org>
5467 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5468 set the status to "failed" and ensure that sentinel is run.
5470 2012-04-20 Glenn Morris <rgm@gnu.org>
5472 * process.c (Fset_process_inherit_coding_system_flag)
5473 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
5474 (Fmake_network_process, Fmake_serial_process): Doc fix.
5476 2012-04-20 Eli Zaretskii <eliz@gnu.org>
5478 * xdisp.c (string_buffer_position_lim): Limit starting position to
5480 (set_cursor_from_row): If called for a mode-line or header-line
5481 row, return zero immediately.
5482 (try_cursor_movement): If inside continuation line, don't back up
5483 farther than the first row after the header line, if any.
5484 Don't consider the header-line row as "partially visible", even if
5485 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5487 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5489 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5492 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
5493 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
5495 configure: new option --enable-gcc-warnings (Bug#11207)
5496 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5497 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5498 (ALL_CFLAGS): Use new macros rather than old.
5499 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5500 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5501 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5502 -Wunused-result, -Wunused-variable. This should go away once
5503 the Emacs and Gnulib regex code is merged.
5504 (xmalloc, xrealloc): Now static.
5506 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5508 * dired.c (Fsystem_groups): Remove unused local.
5510 2012-04-17 Glenn Morris <rgm@gnu.org>
5512 * dired.c (Fsystem_users): Doc fix.
5514 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5516 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5517 (syms_of_dired): Add them.
5519 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5521 Fix minor alloc.c problems found by static checking.
5522 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5523 New extern decls, to avoid calling undeclared functions.
5524 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5525 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5526 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5527 (NEED_MEM_INSERT): New macro.
5528 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
5529 Remove one incorrect comment and fix another.
5531 Fix minor ralloc.c problems found by static checking.
5532 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5533 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5534 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5535 (r_alloc_sbrk): Now static.
5537 Improve ralloc.c interface checking.
5538 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5539 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5540 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5541 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5542 [REL_ALLOC]: ... to here, to check interface.
5543 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5544 Remove decls. This fixes an "It stinks!".
5546 * alloc.c (which_symbols): Fix alignment issue / type clash.
5548 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5550 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5551 (struct Lisp_Misc_Any): Likewise.
5552 (struct Lisp_Free): Likewise.
5553 * alloc.c (union aligned_Lisp_Symbol): Define.
5554 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5555 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5556 (union aligned_Lisp_Misc): Define.
5557 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5558 aligned_Lisp_Misc instead of union Lisp_Misc.
5559 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
5561 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5563 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5564 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5565 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5566 * s/netbsd.h, s/sol2-6.h:
5567 Remove definition of GC_MARK_STACK, since the default now works.
5568 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5569 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5570 no longer the default.
5571 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5573 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5575 * lread.c (lisp_file_lexically_bound_p):
5576 Fix hang at ";-*-\n" (bug#11238).
5578 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5580 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5581 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5583 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5585 * nsterm.m (constrainFrameRect): Always constrain when there is only
5586 one screen (Bug#10962).
5588 2012-04-13 Ken Brown <kbrown@cornell.edu>
5590 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5592 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5594 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5596 2012-04-11 Daniel Colascione <dancol@dancol.org>
5598 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5599 against is gone. It's better to use vfork now so that when Cygwin
5600 gains a new, working vfork, we use it automatically (bug#10398).
5602 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5604 * window.c (save_window_save): Obey window-point-insertion-type.
5606 2012-04-11 Glenn Morris <rgm@gnu.org>
5608 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5610 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5612 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5614 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5616 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5617 (force_quit_count): New var.
5618 (handle_interrupt): Use it.
5620 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5622 * w32.c (w32_delayed_load): Record the full path of the library
5623 being loaded (bug#10424).
5625 2012-04-09 Glenn Morris <rgm@gnu.org>
5627 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5628 not just in the obarray, before snarfing them. (Bug#11036)
5630 * Makefile.in ($(leimdir)/leim-list.el):
5631 Pass EMACS rather than BUILT_EMACS.
5633 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5635 * process.c (make_process):
5636 * process.h: Add integer `gnutls_handshakes_tried' member to
5639 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5640 Add convenience `GNUTLS_LOG2i' macro.
5642 * gnutls.c (gnutls_log_function2i): Convenience log function.
5643 (emacs_gnutls_read): Use new log functions,
5644 `gnutls_handshakes_tried' process member, and
5645 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5646 attempts per process (connection).
5648 2012-04-09 Chong Yidong <cyd@gnu.org>
5650 * eval.c (Fuser_variable_p, user_variable_p_eh)
5651 (lisp_indirect_variable): Functions deleted.
5652 (Fdefvar): Caller changed.
5654 * callint.c (Finteractive, Fcall_interactively):
5655 * minibuf.c (Fread_variable): Callers changed.
5657 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5659 * xdisp.c (set_cursor_from_row): If the display string appears in
5660 the buffer at position that is closer to point than the position
5661 after the display string, display the cursor on the first glyph of
5662 the display string. Fixes cursor display when a 'display' text
5663 property immediately follows invisible text. (Bug#11094)
5665 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5667 composite.c: use 'double' consistently
5668 * composite.c (get_composition_id): Use 'double' consistently
5669 instead of converting 'float' to 'double' and vice versa; this is
5670 easier to understand and avoids a GCC warning.
5672 2012-04-09 Glenn Morris <rgm@gnu.org>
5674 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5675 preparation for dumping it with emacs. (Bug#4789)
5676 (leimdir): New variable.
5677 ($(leimdir)/leim-list.el): New rule.
5678 (emacs$(EXEEXT)): Depend on leim-list.el.
5680 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5681 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5682 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5684 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5686 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5689 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5691 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5692 Remove unused local variable.
5694 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5696 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5697 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5698 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5699 objects, as mark_maybe_pointer will catch them otherwise.
5700 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5701 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5703 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5705 Fix typo that broke non-Windows builds.
5706 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5708 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5710 Support building on MS-Windows with libxml2.
5712 * makefile.w32-in (OBJ2): Add xml.$(O).
5713 (GLOBAL_SOURCES): Add xml.c.
5714 ($(BLD)/xml.$(O)): New dependency list.
5716 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5717 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5718 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5719 [!WINDOWSNT]: New macros.
5720 (init_libxml2_functions, libxml2_loaded_p): New functions.
5721 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5722 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5723 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5724 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5726 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5727 Call init_libxml2_functions before calling libxml2 functions.
5728 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5730 * emacs.c: Don't include libxml/parser.h.
5731 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5732 xmlCleanupParser directly.
5734 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5736 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5738 * indent.c (Fvertical_motion): If there is a display string at
5739 point, use it.vpos to compute how many lines to backtrack after
5740 move_it_to point. (Bug#11133)
5742 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5744 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5745 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5746 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5747 macros related to unification of CJK characters. For the details,
5748 see the discussion following the message here:
5749 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5751 2012-04-04 Chong Yidong <cyd@gnu.org>
5753 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5755 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5757 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5758 instead of alloca. (Bug#11138)
5760 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5762 * w32menu.c (is_simple_dialog): Properly check lisp types.
5765 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5767 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5768 position we get to after a call to move_it_to fails the
5769 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5770 only if we wind up in a string from display property. (Bug#11063)
5772 * window.c (Fdelete_other_windows_internal): Invalidate the row
5773 and column information about mouse highlight, so that redisplay
5774 restores it after reallocating the glyph matrices. (Bug#7464)
5776 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5777 string comes from a `display' text property, use the buffer
5778 position of that property as if we actually saw that position in
5780 (move_it_by_lines): Remove the assertion that
5781 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5782 violated when there's a before-string at the beginning of a line.
5785 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5787 * xdisp.c (append_space_for_newline): If the default face was
5788 remapped, use the remapped face for the appended newline.
5789 (extend_face_to_end_of_line): Use the remapped default face for
5790 extending the face to the end of the line.
5791 (display_line): Call extend_face_to_end_of_line when the default
5792 face was remapped. (Bug#11068)
5794 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5796 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5798 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5800 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5802 2012-03-27 Glenn Morris <rgm@gnu.org>
5804 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5807 2012-03-26 Kenichi Handa <handa@m17n.org>
5809 * dispextern.h (struct glyph): Fix previous change. Change the
5810 bit length of glyphless.ch to 25 (Bug#11082).
5812 2012-03-26 Chong Yidong <cyd@gnu.org>
5814 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5815 (command_loop_1): Use it; inhibit selection update for
5816 handle-select-window too (Bug#8996).
5818 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5820 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5822 2012-03-25 Kenichi Handa <handa@m17n.org>
5824 * dispextern.h (struct glyph): Change the bit length of
5825 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5827 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5829 * s/ms-w32.h (tzname): Include time.h before redirecting to
5830 _tzname. Fixes the MSVC build. (Bug#9960)
5832 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5834 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5837 * xterm.c (XTread_socket): Only modify handling_signal if
5838 !SYNC_INPUT. (Bug#11080)
5840 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5842 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5843 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5844 when fetching a multibyte character consumes more bytes than
5845 CHAR_BYTES returns, due to unification of CJK characters in
5846 string_char. (Bug#11073)
5848 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5850 * process.c (wait_reading_process_output): Handle pty disconnect
5851 by refraining from sending oneself a SIGCHLD (bug#10933).
5853 2012-03-22 Chong Yidong <cyd@gnu.org>
5855 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5857 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5858 Mark string as coming from a prefix property.
5859 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5860 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5862 2012-03-21 Chong Yidong <cyd@gnu.org>
5864 * xfaces.c (Vface_remapping_alist): Doc fix.
5866 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5868 * w32proc.c (Fw32_set_console_codepage)
5869 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5872 2012-03-20 Chong Yidong <cyd@gnu.org>
5874 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5875 to reflect default non-nil value of redisplay-dont-pause.
5877 2012-03-19 Kenichi Handa <handa@m17n.org>
5879 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5880 it fit in a valid range (Bug#11003).
5882 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5884 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5885 that is not from display property, accept the row as a "cursor
5886 row" if one of the string's character has a non-nil `cursor'
5887 property. Fixes cursor positioning when there are newlines in
5888 overlay strings, e.g. in icomplete.el. (Bug#11035)
5890 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5892 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5894 2012-03-12 Chong Yidong <cyd@gnu.org>
5896 * eval.c (inhibit_lisp_code): Rename from
5897 inhibit_window_configuration_change_hook; move from window.c.
5899 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5900 * window.c (run_window_configuration_change_hook)
5901 (syms_of_window): Callers changed.
5903 2012-03-11 Chong Yidong <cyd@gnu.org>
5905 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5907 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5909 2012-03-10 Chong Yidong <cyd@gnu.org>
5911 * frame.c (other_visible_frames): Don't assume the selected frame
5912 is visible (Bug#10955).
5914 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5916 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5918 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5920 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5921 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5924 2012-03-03 Glenn Morris <rgm@gnu.org>
5926 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5928 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5930 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5931 position past the first glyph_row that ends at ZV. (Bug#10902)
5932 (redisplay_window, next_element_from_string): Fix typos in
5934 (redisplay_window): Pass to move_it_vertically the margin in
5935 pixels, not in screen lines.
5937 2012-03-02 Glenn Morris <rgm@gnu.org>
5939 * buffer.c (buffer-list-update-hook): Doc fix.
5941 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5943 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5944 push_it before setting up the iterator for the first overlay
5945 string, even if we have an empty string loaded.
5946 (next_overlay_string): If there's an empty string on the iterator
5947 stack, pop the stack. (Bug#10903)
5949 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5951 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5952 Suggested by Stefan Monnier in
5953 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5954 * alloc.c (widen_to_Lisp_Object): New static function.
5955 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5956 and widening them to Lisp_Objects. This would work even if
5957 USE_LSB_TAG is defined and wide integers are used, which might
5958 happen in a future version of Emacs.
5960 2012-02-25 Chong Yidong <cyd@gnu.org>
5962 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5965 * xselect.c (Fx_selection_exists_p): Doc fix.
5966 (x_clipboard_manager_save_all): Print an informative message
5967 before saving to clipboard manager.
5969 2012-02-24 Chong Yidong <cyd@gnu.org>
5971 * keyboard.c (process_special_events): Handle all X selection
5972 requests in kbd_buffer, not just the next one (Bug#8869).
5974 2012-02-23 Chong Yidong <cyd@gnu.org>
5976 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5977 call when setting menu-bar-lines and tool-bar-lines parameters.
5978 (unwind_create_frame_1): New helper function.
5980 * window.c (inhibit_window_configuration_change_hook): New var.
5981 (run_window_configuration_change_hook): Obey it.
5982 (syms_of_window): Initialize it.
5984 2012-02-22 Chong Yidong <cyd@gnu.org>
5986 * xterm.c (x_draw_image_relief): Add missing type check for
5987 Vtool_bar_button_margin (Bug#10743).
5989 2012-02-21 Chong Yidong <cyd@gnu.org>
5991 * fileio.c (Vfile_name_handler_alist): Doc fix.
5993 * buffer.c (Fget_file_buffer): Protect against invalid file
5994 handler return value.
5996 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5998 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5999 when computing $valmask.
6001 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6002 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6003 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6004 It's useless in that case, and it can cause problems on hosts
6005 that allocate halves of EMACS_INT values separately.
6006 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6007 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6008 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6009 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6010 it avoids undefined behavior on hosts where shifting right by more
6011 than the word width has undefined behavior.
6013 2012-02-19 Chong Yidong <cyd@gnu.org>
6015 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6016 (Funhandled_file_name_directory, Ffile_name_as_directory)
6017 (Fdirectory_file_name, Fexpand_file_name)
6018 (Fsubstitute_in_file_name): Protect against invalid file handler
6019 return values (Bug#10845).
6021 2012-02-18 Eli Zaretskii <eliz@gnu.org>
6023 * .gdbinit (pitx): Fix incorrect references to fields of the
6026 2012-02-17 Chong Yidong <cyd@gnu.org>
6028 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6030 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6032 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6033 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6035 2012-02-15 Chong Yidong <cyd@gnu.org>
6037 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6038 marked as special. Also, starting docstrings with * is obsolete.
6040 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6042 * gnutls.c (emacs_gnutls_write): Fix last change.
6044 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6046 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6049 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6051 * keymap.c (Fsingle_key_description): Handle char ranges.
6053 2012-02-12 Chong Yidong <cyd@gnu.org>
6055 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6056 as that creates a dangerous corner case.
6058 * window.c (Fdelete_window_internal): Invalidate the mouse
6059 highlight (Bug#9904).
6061 2012-02-12 Glenn Morris <rgm@gnu.org>
6063 * xselect.c (Fx_own_selection_internal)
6064 (Fx_get_selection_internal, Fx_disown_selection_internal)
6065 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6066 * nsselect.m (Fx_own_selection_internal)
6067 (Fx_disown_selection_internal, Fx_selection_exists_p)
6068 (Fx_selection_owner_p, Fx_get_selection_internal):
6069 Sync docs and argument specs with the xselect.c versions.
6071 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6073 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6075 2012-02-11 Eli Zaretskii <eliz@gnu.org>
6077 * w32select.c (Fx_selection_exists_p): Sync doc string and
6078 argument list with xselect.c. (Bug#10783)
6080 * w16select.c (Fx_selection_exists_p): Sync doc string and
6081 argument list with xselect.c. (Bug#10783)
6083 2012-02-10 Glenn Morris <rgm@gnu.org>
6085 * fns.c (Fsecure_hash): Doc fix.
6087 2012-02-09 Kenichi Handa <handa@m17n.org>
6089 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6091 2012-02-07 Chong Yidong <cyd@gnu.org>
6093 * buffer.c (Fbuffer_local_variables)
6094 (buffer_lisp_local_variables): Handle unbound vars correctly;
6095 don't let Qunbound leak into Lisp.
6097 2012-02-07 Glenn Morris <rgm@gnu.org>
6099 * image.c (Fimagemagick_types): Doc fix.
6101 * image.c (imagemagick-render-type): Change it from a lisp object
6102 to an integer. Move the doc here from the lisp manual.
6103 Treat all values not equal to 0 the same.
6105 2012-02-06 Chong Yidong <cyd@gnu.org>
6107 * doc.c (store_function_docstring): Avoid applying docstring of
6108 alias to base function (Bug#2603).
6110 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6112 * .gdbinit (pp1, pv1): Remove redundant defines.
6115 2012-02-04 Chong Yidong <cyd@gnu.org>
6117 * nsterm.m: Declare a global (Bug#10694).
6119 2012-02-04 Eli Zaretskii <eliz@gnu.org>
6121 * w32.c (get_emacs_configuration_options):
6122 Include --enable-checking, if specified, in the return value.
6124 2012-02-04 Martin Rudalics <rudalics@gmx.at>
6126 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6127 after rounding frame sizes. (Bug#9723)
6129 2012-02-04 Eli Zaretskii <eliz@gnu.org>
6131 * keyboard.c (adjust_point_for_property): Don't position point
6132 before BEGV. (Bug#10696)
6134 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6136 Handle overflow when computing char display width (Bug#9496).
6137 * character.c (char_width): Return EMACS_INT, not int.
6138 (char_width, c_string_width): Check for overflow when
6139 computing the width; this is possible now that individual
6140 characters can have unbounded width. Problem introduced
6141 by merge from Emacs 23 on 2012-01-19.
6143 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
6145 * dbusbind.c (Fdbus_register_method): Mention the return value
6146 :ignore in the docstring.
6148 2012-02-02 Glenn Morris <rgm@gnu.org>
6150 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6152 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6153 Unconditionally set to t. (Bug#10673)
6154 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6155 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6156 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6158 2012-02-02 Kenichi Handa <handa@m17n.org>
6160 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6161 0, do not call append_composite_glyph.
6163 2012-02-02 Kenichi Handa <handa@m17n.org>
6165 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6167 (x_produce_glyphs): If the component of a composition is a null
6168 string, set it->pixel_width to 1 to avoid zero-width glyph.
6170 2012-02-01 Eli Zaretskii <eliz@gnu.org>
6172 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6173 first 2 arguments are identical. This makes inserting large
6174 output from a subprocess an order of magnitude faster on
6175 MS-Windows, where all sbrk'ed memory is always contiguous.
6177 2012-01-31 Glenn Morris <rgm@gnu.org>
6179 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6180 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6181 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6183 2012-01-29 Glenn Morris <rgm@gnu.org>
6185 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6187 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6189 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6191 2012-01-28 Chong Yidong <cyd@gnu.org>
6193 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6195 2012-01-26 Chong Yidong <cyd@gnu.org>
6197 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6199 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6200 repeat counts (Bug#10507).
6202 2012-01-26 Glenn Morris <rgm@gnu.org>
6204 * lread.c (syms_of_lread): Doc fix.
6206 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6208 * coding.c (encode_designation_at_bol): Change return value to
6211 2012-01-25 Chong Yidong <cyd@gnu.org>
6213 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6215 2012-01-21 Chong Yidong <cyd@gnu.org>
6217 * floatfns.c (Fcopysign): Make the second argument non-optional,
6218 since nil is not allowed anyway.
6220 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6222 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6223 (send_process): Likewise.
6225 2012-01-19 Martin Rudalics <rudalics@gmx.at>
6227 * window.c (save_window_save, Fcurrent_window_configuration)
6228 (Vwindow_persistent_parameters): Do not use Qstate.
6229 Rewrite doc-strings.
6231 2012-01-19 Kenichi Handa <handa@m17n.org>
6233 * character.c (char_width): New function.
6234 (Fchar_width, c_string_width, lisp_string_width):
6235 Use char_width (Bug#9496).
6237 2012-01-16 Martin Rudalics <rudalics@gmx.at>
6239 * window.c (Vwindow_persistent_parameters): New variable.
6240 (Fset_window_configuration, save_window_save): Handle persistent
6243 2012-01-14 Eli Zaretskii <eliz@gnu.org>
6245 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6246 thrashing the stack of the thread. (Bug#9087)
6248 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6250 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6252 2012-01-11 Eli Zaretskii <eliz@gnu.org>
6254 * xdisp.c (rows_from_pos_range): Handle the case where the
6255 highlight ends on a newline. (Bug#10464)
6256 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6257 he end column for display of highlight that ends on a newline
6260 2012-01-11 Glenn Morris <rgm@gnu.org>
6262 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6263 from load-path also when installation-directory is nil. (Bug#10208)
6265 2012-01-10 Glenn Morris <rgm@gnu.org>
6267 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6269 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6270 Update template values to be closer to their typical values these days.
6272 2012-01-09 Eli Zaretskii <eliz@gnu.org>
6274 * xdisp.c (rows_from_pos_range): Accept additional argument
6275 DISP_STRING, and accept any glyph in a row whose object is that
6276 string as eligible for mouse highlight. Fixes mouse highlight of
6277 display strings from overlays. (Bug#10464)
6279 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
6281 emacs: fix an auto-save permissions race condition (Bug#10400)
6282 * fileio.c (auto_saving_dir_umask): New static var.
6283 (Fmake_directory_internal): Use it.
6284 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6285 creating the directory. The old code temporarily assigns
6286 too-generous permissions to the directory.
6287 (do_auto_save_eh): Clear it.
6288 (Fdo_auto_save): Catch all errors, not just file errors, so
6289 that the var is always cleared.
6291 2012-01-07 Eli Zaretskii <eliz@gnu.org>
6293 * search.c (scan_buffer): Pass character positions to
6294 know_region_cache, not byte positions. (Bug#6540)
6296 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
6298 * w32.c (sys_rename): Report EXDEV when rename of a directory
6299 fails because the target is on another logical disk. (Bug#10284)
6301 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6303 * xterm.c (x_embed_request_focus): New function.
6305 * xterm.h: Add prototype.
6307 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6309 2012-01-05 Glenn Morris <rgm@gnu.org>
6311 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6313 2012-01-01 Eli Zaretskii <eliz@gnu.org>
6315 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6316 Load gnutls_transport_set_lowat only if GnuTLS version is below
6318 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6319 GnuTLS versions below 2.11.1.
6321 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6323 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6324 to the doc string advising against its use for altering the way
6325 windows are scrolled.
6327 2011-12-28 Kenichi Handa <handa@m17n.org>
6329 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6330 coding-system ASCII compatible only when it does not produce BOM
6331 on encoding (Bug#10383).
6333 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6335 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6337 (create_and_show_popup_menu): Always use menu_position_func for
6340 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6342 * callint.c (Fcall_interactively): Don't truncate prompt string.
6344 2011-12-23 Eli Zaretskii <eliz@gnu.org>
6346 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6347 property that ends at ZV, so that the bidi iteration could be
6348 resumed from there (after widening). (Bug#10360)
6350 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6352 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6354 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6356 * nsterm.m (x_free_frame_resources):
6357 Release f->output_data.ns->miniimage.
6358 (ns_index_color): Fix indentation. Do not retain
6359 color_table->colors[i].
6361 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6364 * nsfns.m (x_set_background_color): Assign return value from
6365 ns_index_color to face-background instead of NSColor*.
6366 (ns_implicitly_set_icon_type): Fix indentation.
6367 Change assignment in for loop to comparison.
6369 * emacs.c (ns_pool): New variable.
6370 (main): Assign ns_pool.
6371 (Fkill_emacs): Call ns_release_autorelease_pool.
6373 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6374 autorelease fdesc, release fdAttrs and tdict.
6375 (ns_get_covering_families): Release charset.
6376 (ns_findfonts): Release NSFontDescriptor created with new.
6377 (ns_uni_to_glyphs): Fix indentation.
6378 (setString): Release attrStr before assigning new value.
6380 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6382 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6384 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6385 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6387 2011-12-18 David Reitter <reitter@cmu.edu>
6389 * nsterm.m (ns_term_init): Subscribe for notifications
6390 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6391 to method trackingNotification in EmacsMenu.
6393 * nsmenu.m (trackingMenu): New variable.
6394 (trackingNotification): New method (from Aquamacs).
6395 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
6396 from Aquamacs (Bug#7030).
6398 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6400 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6401 (symbol_to_nsstring): Fix indentation.
6402 (ns_symbol_to_pb): New function.
6403 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6404 (Fns_rotate_cut_buffers_internal): Remove.
6405 (Fns_store_selection_internal): Rename from
6406 Fns_store_cut_buffer_internal.
6407 (ns_get_foreign_selection, Fx_own_selection_internal)
6408 (Fx_disown_selection_internal, Fx_selection_exists_p)
6409 (Fns_get_selection_internal, Fns_store_selection_internal):
6410 Use ns_symbol_to_pb and check if return value is nil.
6411 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6412 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
6413 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6414 renamed to Sns_store_selection_internal.
6415 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6416 and remove this function.
6417 (ns_handle_selection_clear): Remove, never used.
6418 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6421 2011-12-17 Ken Brown <kbrown@cornell.edu>
6423 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6424 GID is unknown (Bug#10257).
6426 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6428 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6429 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6430 which caused a build failure on GNU/Linux IA-64. This problem was
6431 introduced by my 2011-10-07 patch.
6433 2011-12-15 Juri Linkov <juri@jurta.org>
6435 * image.c (imagemagick_error): New function. (Bug#10112)
6436 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6437 Use `imagemagick_error' where ImageMagick functions return
6439 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6442 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6444 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6445 fill background (Bug#8992).
6447 2011-12-13 Martin Rudalics <rudalics@gmx.at>
6449 * window.c (Vwindow_combination_resize)
6450 (Vwindow_combination_limit): Use t instead of non-nil in
6452 (Vrecenter_redisplay): Add first sentence of doc-string on
6454 (Frecenter): Fix doc-string typo.
6456 2011-12-11 Kenichi Handa <handa@m17n.org>
6458 * coding.c (Funencodable_char_position): Pay attention to the
6459 buffer text relocation (Bug#9389).
6461 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6463 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6464 gtk_init (Bug#10100).
6466 2011-12-10 Eli Zaretskii <eliz@gnu.org>
6468 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6469 IT->string is nil. (Bug#10263)
6471 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6473 * nsterm.h (x_free_frame_resources): Declare.
6475 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6476 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6478 * nsterm.h (ns_get_defaults_value): Declare.
6480 * nsterm.m (ns_default): Call ns_get_defaults_value.
6482 2011-12-09 Eli Zaretskii <eliz@gnu.org>
6484 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6487 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6489 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6490 that where the value of an _OBJC_* symbol points to is in the .bss
6491 section (Bug#10240).
6493 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6495 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
6496 after the loop to call ccl_driver at least once (Bug#8619).
6498 2011-12-08 Kenichi Handa <handa@m17n.org>
6500 * ftfont.c (get_adstyle_property): Fix previous change
6503 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
6505 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6506 dirs from the default value of EMACSLOADPATH (bug#10208).
6508 2011-12-07 Glenn Morris <rgm@gnu.org>
6510 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6511 installation and source directories as well. (Bug#10208)
6513 2011-12-06 Chong Yidong <cyd@gnu.org>
6515 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6517 2011-12-06 Glenn Morris <rgm@gnu.org>
6519 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6520 as an error, not just -1. (Bug#10217)
6522 2011-12-05 Chong Yidong <cyd@gnu.org>
6524 * keyboard.c (process_special_events): New function.
6525 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6527 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6529 * coding.c (encode_designation_at_bol): Don't use uninitialized
6530 local variable (Bug#9318).
6532 2011-12-05 Kenichi Handa <handa@m17n.org>
6534 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6535 return Qnil (Bug#8046, Bug#10193).
6537 2011-12-05 Kenichi Handa <handa@m17n.org>
6539 * coding.c (encode_designation_at_bol): New args charbuf_end and
6540 dst. Return the number of produced bytes. Callers changed.
6541 (coding_set_source): Return how many bytes coding->source was
6543 (coding_set_destination): Return how many bytes
6544 coding->destination was relocated.
6545 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
6546 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
6548 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6550 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6551 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6554 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6556 The following changes are to fix Bug#9318.
6558 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
6559 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6560 (encode_coding_iso_2022, encode_coding_sjis)
6561 (encode_coding_big5, encode_coding_charset): Use the above macros.
6563 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
6565 * lisp.h (process_quit_flag): Fix external declaration.
6567 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6569 Don't macro-inline non-performance-critical code.
6570 * eval.c (process_quit_flag): New function.
6571 * lisp.h (QUIT): Use it.
6573 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6575 * nsfns.m (get_geometry_from_preferences): New function.
6576 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6578 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6580 * emacs.c (Qkill_emacs): Define.
6581 (syms_of_emacs): Initialize it.
6582 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6583 Qquit_flag to `kill-emacs' instead.
6584 (quit_throw_to_read_char): Add parameter `from_signal'.
6585 All callers changed. Call Fkill_emacs if requested and safe.
6586 * lisp.h (QUIT): Call Fkill_emacs if requested.
6588 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6590 * widget.c (update_wm_hints): Return if wmshell is null.
6591 (widget_update_wm_size_hints): New function.
6593 * widget.h (widget_update_wm_size_hints): Declare.
6595 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6596 widget_update_wm_size_hints (Bug#10104).
6598 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6600 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6601 before a newline, prepare the bidi iterator for consuming the
6602 newline, and keep the current paragraph direction. (Bug#10183)
6603 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6605 2011-12-02 Juri Linkov <juri@jurta.org>
6607 * search.c (Fword_search_regexp): New Lisp function created from
6608 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6609 (Fword_search_backward, Fword_search_forward)
6610 (Fword_search_backward_lax, Fword_search_forward_lax):
6611 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6612 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6614 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6616 * fileio.c (Finsert_file_contents): Move after-change-function call
6617 to before the "handled:" label, since all "goto handled" appear in
6618 cases where the *-change-functions have already been properly called
6621 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6623 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6624 waiting for input. (Bug#10169)
6626 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6628 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6629 verifies glyph row's hash code--we have just reallocated the
6630 glyphs, so their contents can be complete garbage. (Bug#10164)
6632 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6634 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6636 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6638 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6639 attributes are tested _before_ calling verify_row_hash, to protect
6640 against GCC re-ordering of the tests. (Bug#10164)
6642 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6644 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6646 * xterm.c (handle_one_xevent): Only set async_visible and friends
6647 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6648 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6649 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6651 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6653 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6654 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6655 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6656 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6657 All uses changed to use GCPRO1 etc.
6658 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6659 Revert to old implementation (i.e., before 2011-03-11).
6661 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6663 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6664 of scroll runs so as to avoid assigning disabled bogus rows and
6665 unnecessary graphics copy operations.
6667 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6669 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6670 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6671 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6672 (malloc, free, realloc, calloc): Redirect to e_* only when
6675 * lisp.h (GCTYPEBITS): Move before first use.
6676 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6677 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6678 this macro definition.
6680 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6683 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6685 * gtkutil.c (xg_create_frame_widgets):
6686 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6687 present with Gtk+ 2.0.
6689 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6691 * fileio.c (Finsert_file_contents): Undo previous change; see
6692 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6694 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6696 Rename locals to avoid shadowing.
6697 * fileio.c (Finsert_file_contents):
6698 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6699 * process.c (wait_reading_process_output):
6700 Rename inner 'proc' to 'p' to avoid shadowing.
6701 Indent for consistency with usual Emacs style.
6703 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6705 * xdisp.c (redisplay_window): If cursor row is not fully visible
6706 after recentering, and scroll-conservatively is set to a large
6707 number, scroll window by a few more lines to make the cursor fully
6708 visible and out of scroll-margin. (Bug#10105)
6709 (start_display): Don't move to the next line if the display should
6710 start at a newline that is part of a display vector or an overlay
6713 2011-11-24 Juri Linkov <juri@jurta.org>
6715 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6716 after the `MagickPingImage' call. (Bug#10112)
6718 2011-11-23 Chong Yidong <cyd@gnu.org>
6720 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6722 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6724 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6725 making another buffer current. (Bug#10114)
6727 2011-11-23 Glenn Morris <rgm@gnu.org>
6729 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6731 2011-11-23 Chong Yidong <cyd@gnu.org>
6733 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6734 using it (Bug#5984).
6736 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6738 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6739 and header-lines, as they don't have one computed for them.
6742 * .gdbinit (prow): Make displayed values more self-explaining.
6743 Add row's hash code.
6745 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6747 * process.c (wait_reading_process_output): Fix asynchrounous
6748 GnuTLS socket handling on some versions of the GnuTLS library.
6749 (wait_reading_process_output): Add comment and URL.
6751 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6753 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6755 2011-11-21 Chong Yidong <cyd@gnu.org>
6757 * window.c (Fnext_window, Fprevious_window): Doc fix.
6759 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6761 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6763 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6765 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6767 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6769 * window.c (Fset_window_combination_limit): Rename argument
6771 (Vwindow_combination_limit): Remove "status" from doc-string.
6773 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6775 * m/ibms390.h: Remove.
6776 * m/ibms390x.h: Don't include "ibms390.h".
6778 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6780 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6781 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6783 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6785 * casetab.c (Fset_case_table):
6786 * charset.c (Fcharset_after): Fix typos.
6788 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6790 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6791 Otherwise, valgrind does not work on some platforms.
6792 Problem reported by Andreas Schwab in
6793 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6794 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6795 is set, removing the need for VIRT_ADDRESS_VARIES.
6796 (PURE_P): Use a more-efficient implementation that needs just one
6797 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6798 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6799 to 4 (xorl, subq, cmpq, setbe).
6800 * alloc.c (pure): Always extern now, since that's the
6801 VIRT_ADDR_VARIES behavior.
6802 (PURE_POINTER_P): Use a single comparison, not two, for
6803 consistency with the new puresize.h.
6804 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6805 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6806 Remove VIRT_ADDR_VARIES no longer needed.
6808 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6810 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6811 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6812 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6813 behave as if the cursor position were at the window margin.
6815 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6816 and the cursor position is out of bounds, behave as if the cursor
6817 position were at the window margin. (Bug#10075)
6819 2011-11-18 Chong Yidong <cyd@gnu.org>
6821 * window.c (Fwindow_combination_limit): Make first argument
6822 non-optional, since it is meaningless for live windows like the
6825 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6827 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6829 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6831 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6832 (graft_intervals_into_buffer): Simplify.
6834 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6836 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6837 hash values of the two rows.
6838 (copy_row_except_pointers): Preserve the used[] arrays and the
6839 hash values of the two rows. (Bug#10035)
6840 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6842 * xdisp.c (row_hash): New function, body extracted from
6843 compute_line_metrics.
6844 (compute_line_metrics): Call row_hash, instead of computing the
6847 * dispnew.c (verify_row_hash): Call row_hash for computing the
6848 hash code of a row, instead of duplicating code from xdisp.c.
6850 * dispextern.h (row_hash): Add prototype.
6852 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6854 * frame.c (delete_frame): Don't delete the terminal when the last
6855 X frame is closed if emacs is built with GTK toolkit.
6857 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6859 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6861 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6863 * window.c (Vwindow_splits): Rename to
6864 Vwindow_combination_resize. Suggested by Juri Linkov.
6865 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6868 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6870 * nsfns.m (Fns_font_name):
6871 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6873 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6875 * window.h (window): Rename slot "nest" to "combination_limit".
6876 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6877 (Fset_window_nest): Rename to Fset_window_combination_limit.
6878 (Vwindow_nest): Rename to Vwindow_combination_limit.
6879 (recombine_windows, make_parent_window, make_window)
6880 (Fsplit_window_internal, saved_window)
6881 (Fset_window_configuration, save_window_save): Rename all
6882 occurrences of window_nest to window_combination_limit.
6884 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6886 * image.c (imagemagick_load_image): Fix typo.
6888 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6890 * xdisp.c (display_line): Move the call to
6891 highlight_trailing_whitespace before the call to
6892 compute_line_metrics, since the latter needs to see the final
6893 faces of all the glyphs to compute ROW's hash value.
6894 Fixes assertion violations in row_equal_p. (Bug#10035)
6896 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6898 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6899 just return (bug#10044).
6901 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6903 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6904 with user-defined heap size. Bump the default size of the temacs
6905 heap to 27MB, to avoid memory warning when running temacs.
6906 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6908 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6909 current_matrix and desired_matrix. (Bug#9990)
6910 (verify_row_hash) [XASSERTS]: New function.
6911 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6912 that the hash value of glyph rows is correct.
6914 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6916 * window.h (window): Remove splits slot.
6917 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6918 (Fdelete_other_windows_internal, make_parent_window)
6919 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6920 (Fset_window_configuration, save_window_save): Don't deal with
6921 split status of windows.
6922 (saved_window): Remove splits slot.
6923 (Vwindow_splits): Rewrite doc-string.
6925 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6927 * xfns.c (unwind_create_frame):
6928 * nsfns.m (unwind_create_frame):
6929 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6930 Vframe_list (Bug#9999).
6932 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6934 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6936 2011-11-11 Kenichi Handa <handa@m17n.org>
6938 * callproc.c (Fcall_process): Set the member dst_multibyte of
6941 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6943 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6944 avoid a crash (bug#9496).
6946 2011-11-09 Chong Yidong <cyd@gnu.org>
6948 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6949 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6951 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6953 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6955 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6957 Avoid some portability problems by eschewing 'extern inline' functions.
6958 The trivial performance wins aren't worth the portability hassles; see
6959 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6961 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6962 (window_box_width, window_box_left, window_box_left_offset)
6963 (window_box_right, window_box_right_offset): Undo previous change,
6964 by removing the "extern"s.
6965 * intervals.c (adjust_intervals_for_insertion)
6966 (adjust_intervals_for_deletion): Undo previous change,
6967 making these static again.
6968 (offset_intervals, temp_set_point_both, temp_set_point)
6969 (copy_intervals_to_string): No longer inline.
6970 * xdisp.c (window_text_bottom_y, window_box_width)
6971 (window_box_height, window_box_left_offset)
6972 (window_box_right_offset, window_box_left, window_box_right)
6973 (window_box): No longer inline.
6975 2011-11-08 Chong Yidong <cyd@gnu.org>
6977 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6978 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6979 Signal an error if not a live window.
6980 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6981 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6983 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6985 * lisp.h (syms_of_abbrev): Remove declaration.
6986 Reported by CHENG Gao <chenggao@royau.me>.
6988 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6990 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6991 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6992 of temacs in GUI mode.
6994 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6996 * window.h: Declare delete_all_child_windows instead of
6997 delete_all_subwindows.
6998 * window.c (Fwindow_nest, Fset_window_nest)
6999 (Fset_window_new_total, Fset_window_new_normal)
7000 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7001 (delete_all_subwindows): Rename to delete_all_child_windows.
7002 (Fdelete_other_windows_internal, Fset_window_configuration):
7003 Call delete_all_child_windows instead of delete_all_subwindows.
7004 * frame.c (delete_frame): Call delete_all_child_windows instead
7005 of delete_all_subwindows.
7007 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7009 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7010 This is also needed for porting to any host where GC_MARK_STACK is
7011 not GC_MAKE_GCPROS_NOOPS.
7012 (which_symbols): Use it.
7014 2011-11-07 Kenichi Handa <handa@m17n.org>
7016 * coding.c (coding_set_destination): Check coding->src_pos only
7017 when coding->src_object is a buffer (bug#9910).
7019 * process.c (send_process): Set the member src_multibyte of coding
7020 to 0 (bug#9911) when sending a unibyte text.
7022 * callproc.c (Fcall_process): Set the member src_multibyte of
7023 process_coding to 0 (bug#9912).
7025 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7027 * xmenu.c (cleanup_widget_value_tree): New function.
7028 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7029 calling free_menubar_widget_value_tree directly (Bug#9830).
7031 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7033 Fix some portability problems with 'inline'.
7034 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7035 (window_box_width, window_box_left, window_box_left_offset)
7036 (window_box_right, window_box_right_offset): Declare extern.
7037 Otherwise, these inline functions do not conform to C99 and
7038 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7039 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7040 * intervals.c (adjust_intervals_for_insertion)
7041 (adjust_intervals_for_deletion): Now extern, because otherwise the
7042 extern inline functions 'offset_intervals' couldn't refer to it.
7043 (static_offset_intervals): Remove.
7044 (offset_intervals): Rewrite using the old contents of
7045 static_offset_intervals. The old version didn't conform to C99
7046 because an extern inline function contained a reference to an
7047 identifier with static linkage.
7049 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7051 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7054 2011-11-06 Eli Zaretskii <eliz@gnu.org>
7056 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7057 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7058 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7059 return Qleft_to_right.
7061 2011-11-06 Chong Yidong <cyd@gnu.org>
7063 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7064 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7065 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7066 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7067 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7068 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7069 (Fwindow_vscroll): Doc fix.
7070 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7071 argument, since it makes no sense to pass a live window and for
7072 consistency with window-child.
7074 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7076 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7079 2011-11-05 Jason Rumney <jasonr@gnu.org>
7081 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7082 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7084 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7085 bitwise arithmetic preventing use of unicode-sip and non-truetype
7088 2011-11-05 Eli Zaretskii <eliz@gnu.org>
7090 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7093 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7094 initialization code to keep similarity to xfns.c after changes
7097 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7099 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7100 (unwind_create_frame): New function (Bug#9943).
7101 (Fx_create_frame): Restructure code to be more similar to the one in
7102 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7103 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7104 Move terminal->reference_count++ just before making the frame official
7107 * nsterm.m (x_free_frame_resources): New function.
7108 (x_destroy_window): Move code to x_free_frame_resources.
7110 * xfns.c (unwind_create_frame): Fix comment.
7111 (Fx_create_frame, x_create_tip_frame):
7112 Move terminal->reference_count++ just before making the frame
7113 official. Move initialization of image_cache_refcount and
7114 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7116 2011-11-05 Eli Zaretskii <eliz@gnu.org>
7118 Support MSVC build with newer versions of Visual Studio.
7119 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7120 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7123 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7124 which are not supported by MSVC.
7125 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7126 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7128 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7130 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7132 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7134 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
7136 Support MSVC build with newer versions of Visual Studio.
7137 * w32.c: Don't include w32api.h for MSVC.
7138 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7140 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7141 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7142 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7143 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7145 (alloca) [_MSC_VER]: Define to _alloca.
7147 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7149 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7151 2011-11-04 Eli Zaretskii <eliz@gnu.org>
7153 * xdisp.c (note_mouse_highlight): If either of
7154 previous/next-single-property-change returns nil, treat that as
7155 the beginning or the end of the buffer. (Bug#9955)
7157 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7159 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
7160 label is not null (Bug#9951).
7161 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7164 2011-11-04 Eli Zaretskii <eliz@gnu.org>
7166 * window.c (Fwindow_body_size): Mention in the doc string that the
7167 return value is in frame's canonical units. (Bug#9949)
7169 2011-11-03 Eli Zaretskii <eliz@gnu.org>
7171 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7173 * w32fns.c (unwind_create_frame): If needed, free the glyph
7174 matrices of the partially constructed frame. (Bug#9943)
7175 * xfns.c (unwind_create_frame): Likewise.
7177 2011-11-01 Eli Zaretskii <eliz@gnu.org>
7179 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7180 Don't stop backward scan on the continuation glyph, even though
7181 its CHARPOS is positive.
7182 (mouse_face_from_buffer_pos, note_mouse_highlight):
7183 Rename cover_string to disp_string.
7185 2011-11-01 Martin Rudalics <rudalics@gmx.at>
7187 * window.c (temp_output_buffer_show): Don't use
7188 Vtemp_buffer_show_specifiers.
7189 (Vtemp_buffer_show_specifiers): Remove unused variable.
7191 2011-10-30 Eli Zaretskii <eliz@gnu.org>
7193 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7194 past the beginning of the current glyph matrix.
7196 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
7198 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7199 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7200 HAVE_GTK3 (Bug#9869).
7202 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7203 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7205 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7207 * xterm.c: Declare x_handle_net_wm_state to return int.
7208 (handle_one_xevent): Check if we are iconified but don't have
7209 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7210 (get_current_wm_state): Return non-zero if not hidden,
7211 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7212 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7213 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7214 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7216 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7218 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7219 so that this new function doesn't get optimized away by a
7220 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7222 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7224 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7226 2011-10-29 Eli Zaretskii <eliz@gnu.org>
7228 Fix the `xbytecode' command.
7229 * .gdbinit (xprintbytestr): New command.
7230 (xwhichsymbols): Rename from `which'; all callers changed.
7231 (xbytecode): Print the byte-code string as well.
7233 2011-10-29 Kim Storm <storm@cua.dk>
7235 * alloc.c (which_symbols): New function.
7237 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7239 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7242 2011-10-29 Glenn Morris <rgm@gnu.org>
7244 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7245 Not clear what it was for, and it causes various bugs. (Bug#9839)
7247 2011-10-28 Eli Zaretskii <eliz@gnu.org>
7249 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7250 possible random value that matches one of those tested as
7251 condition to clear the mouse face.
7253 2011-10-28 Chong Yidong <cyd@gnu.org>
7255 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7257 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7259 * window.c (make_window): Initialize phys_cursor_on_p.
7261 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7263 * lisp.h (struct Lisp_Symbol): Update comments.
7265 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
7267 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7269 2011-10-28 Eli Zaretskii <eliz@gnu.org>
7271 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7272 <oslsachem@gmail.com> for helping to debug this.
7274 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7275 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7276 (g_b_init_get_glyph_outline_w): New static variables.
7277 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7278 (GetGlyphOutlineW_Proc): New typedefs.
7279 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
7280 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7282 (w32font_open_internal, compute_metrics):
7283 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
7284 instead of calling the "wide" APIs directly.
7286 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7288 * w32.h (syms_of_w32font): Add prototype.
7290 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
7292 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7293 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7294 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7295 (Fmove_to_window_line): Doc fix.
7297 2011-10-27 Chong Yidong <cyd@gnu.org>
7299 * process.c (make_process): Set gnutls_state to NULL.
7301 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7302 non-NULL, regardless of GNUTLS_INITSTAGE.
7303 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7304 an error. Set process slots as soon as we allocate them.
7306 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7308 2011-10-27 Chong Yidong <cyd@gnu.org>
7310 * gnutls.c (emacs_gnutls_deinit): New function.
7311 Deallocate credentials structures as well as calling gnutls_deinit.
7312 (Fgnutls_deinit, Fgnutls_boot): Use it.
7314 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7315 (deactivate_process): Call emacs_gnutls_deinit.
7317 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
7319 * image.c (x_create_x_image_and_pixmap):
7320 * w32.c (sys_rename, w32_delayed_load):
7321 * w32font.c (fill_in_logfont):
7322 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7324 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
7326 * w32fns.c (w32_default_color_map): New function,
7327 extracted from Fw32_default_color_map.
7328 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
7330 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7332 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7334 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7336 * keyboard.c (test_undefined): New function (bug#9751).
7337 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7339 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7341 * sysdep.c (init_sys_modes): Fix the check for the controlling
7342 terminal (Bug#6649).
7344 2011-10-20 Eli Zaretskii <eliz@gnu.org>
7346 * dispextern.h (struct bidi_it): New member next_en_type.
7348 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7349 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7350 current character, check also for next_en_type being WEAK_EN.
7351 (bidi_resolve_weak): Don't enter the expensive loop if the current
7352 position is before next_en_pos. Record the bidi type of the first
7353 non-ET, non-BN character we find, in addition to its position.
7354 (bidi_level_of_next_char): Invalidate next_en_type when
7355 next_en_pos is over-stepped.
7357 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7359 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7360 * editfns.c: Rewrite current-time-zone so that it invokes
7361 the equivalent of (format-time-string "%Z") to get the time zone name.
7362 This fixes a bug when the time zone name contains characters that
7363 need converting from the system time locale to Emacs internal format.
7364 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7365 that patch fixed format-time-string to do the conversion, but
7366 I forgot to fix current-time-zone.
7367 (format_time_string): New function, containing most of
7368 what Fformat_time_string used to contain.
7369 (Fformat_time_string): Rewrite in terms of format_time_string.
7370 This doesn't change this function's behavior.
7371 (current-time-zone): Rewrite to use format_time_string.
7372 This fixes the bug reported by Michael Schierl in
7373 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7374 Jason Rumney's 2007-06-07 change worked around this bug, but
7376 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7378 2011-10-19 Eli Zaretskii <eliz@gnu.org>
7380 * xdisp.c (start_display): If the character at POS is displayed
7381 via a display vector, reset IT->current.dpvec_index to zero.
7382 (try_window_reusing_current_matrix): If a line ends in a display
7383 vector or the next line starts in a display vector, continue
7384 redrawing the window even though the character position of
7385 start_row was reached.
7388 2011-10-18 Chong Yidong <cyd@gnu.org>
7390 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7391 with nobreak-char-display too.
7393 2011-10-18 Eli Zaretskii <eliz@gnu.org>
7395 Fix part 3 of bug#9771.
7396 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7397 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7398 non-neutral characters if the current character is a paragraph
7399 separator (a.k.a. Newline). This avoids running the same
7400 expensive loop twice, once when we consume the preceding newline
7401 and the other time when the line actually needs to be displayed.
7402 Avoid the loop when we see neutrals on the base embedding level
7403 following a character whose directionality is the same as the
7404 paragraph's. This avoids running the expensive loop when a line
7405 ends in a long sequence of neutrals, like control characters.
7406 Add assertion against STRONG_AL type. Slightly rearrange code
7407 that determines the type of a neutral given the first non-neutral
7409 (bidi_level_of_next_char): Set next_en_pos to zero when
7410 invalidating its info.
7412 2011-10-17 Eli Zaretskii <eliz@gnu.org>
7414 * xdisp.c (push_display_prop): Determine whether to record string
7415 or buffer position by IT->string, not by IT->method. Allow
7416 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
7417 (move_it_vertically_backward): Don't look for character position
7418 immediately after the newline when in a continuation line.
7421 2011-10-15 Martin Rudalics <rudalics@gmx.at>
7423 * window.c (coordinates_in_window): Rewrite and delabelize
7424 vertical border check. (Bug#5357) (Bug#9618)
7426 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7428 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7429 errors in XSetWindowBorder (bug#9310).
7431 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7433 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7434 avoid crash when xmalloc overrun checking is enabled.
7436 2011-10-13 Eli Zaretskii <eliz@gnu.org>
7438 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7439 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7440 cursor motion with <left> and <right> arrow keys.
7442 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7443 some callers set that themselves.
7445 2011-10-12 Eli Zaretskii <eliz@gnu.org>
7447 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7448 display string and the previous row comes from the same string and
7449 is empty. (Bug#9739) (Bug#9738)
7451 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7453 * doc.c (get_doc_string): Encode file name (bug#9735).
7455 2011-10-12 Eli Zaretskii <eliz@gnu.org>
7457 * bidi.c (bidi_level_of_next_char):
7458 * xdisp.c (get_visually_first_element): Remove old incorrect
7459 comments regarding the Unicode Line Separator character.
7461 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7463 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7465 * alloc.c (Fgc_status): Do not access beyond zombies array
7466 boundary if nzombies > MAX_ZOMBIES.
7467 * alloc.c (dump_zombies): Add missing format specifier.
7469 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7471 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7472 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7474 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7475 Some packages use them to denote characters with modifiers.
7477 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7479 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7480 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7481 matching a pp-number. Rename parameter var to var1.
7483 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7485 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7487 2011-10-08 Glenn Morris <rgm@gnu.org>
7489 * callint.c (Fcall_interactively): Give a more explicit error for the
7490 'c' case with a non-character input. (Bug#8479)
7492 2011-10-08 Eli Zaretskii <eliz@gnu.org>
7494 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7496 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7497 lines that are hscrolled on the left.
7499 * dispnew.c (buffer_posn_from_coords): Account for a possible
7500 presence of header-line. (Bug#4426)
7502 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7504 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7505 Don't advertise functionality which we discourage or doesn't work.
7507 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7509 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7510 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7511 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7512 this makes Emacs dump core during garbage collection on rare
7513 occasions. sizeof is obviously inferior to offsetof here, so
7514 stick with offsetof.
7515 (GC_POINTER_ALIGNMENT): New macro.
7516 (mark_memory): Omit 3rd (offset) arg; caller changed.
7517 Don't assume EMACS_INT alignment is the same as pointer alignment.
7519 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7521 * keyboard.c (read_key_sequence_remapped): New var.
7522 (read_key_sequence): Compute remapping in the right buffer.
7523 (command_loop_1): Use read_key_sequence's remapping directly.
7525 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7527 * dired.c (file_name_completion): Don't expand file name.
7528 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7529 before checking file name handler.
7531 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7532 they've been requested explicitly (bug#9591).
7534 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
7536 * keymap.c (Fsingle_key_description): Use make_specified_string
7537 instead of build_string to build string from push_key_description.
7540 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7542 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7543 This fixes a Y2038 bug on 64-bit hosts.
7544 * buffer.c (reset_buffer):
7545 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7546 (Fclear_buffer_auto_save_failure):
7547 Use 0, not -1, to represent an unset failure time, since time_t
7548 might not be signed.
7550 Remove dependency on glibc malloc internals.
7551 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7552 Move back here from lisp.h, but with their new implementations.
7553 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7554 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7555 * charset.c (charset_table_init): New static var.
7556 (syms_of_charset): Use it instead of xmalloc. This removes a
7557 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7558 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7559 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7560 Move back to alloc.c.
7561 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7562 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7564 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7566 * nsterm.m (windowDidResize): Call x_set_window_size only when
7567 ns_in_resize is true. Otherwise set pixelwidth/height and
7568 call change_frame_size (Bug#9628).
7570 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7572 Port --enable-checking=all to Fedora 14 x86-64.
7573 * charset.c (syms_of_charset): Also account for glibc malloc's
7574 internal overhead when calculating the initial malloc maximum.
7576 Port --enable-checking=all to Fedora 14 x86.
7577 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7579 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7580 (overrun_check_realloc, overrun_check_free):
7581 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7582 That way, xmalloc returns a properly-aligned pointer even if
7583 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7584 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7585 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7586 into account when calculating the initial malloc maximum.
7587 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7588 Move here from alloc.c, so that charset.c can use it too.
7589 Properly align; the old code wasn't right for common 32-bit hosts
7590 when configured with --enable-checking=all.
7591 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7592 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7594 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7596 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7599 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7601 * xdisp.c (compute_display_string_end): If there's no display
7602 string at CHARPOS, return -1.
7604 * bidi.c (bidi_fetch_char): When compute_display_string_end
7605 returns a negative value, treat the character as a normal
7606 character not covered by a display string. (Bug#9624)
7608 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7610 * lread.c (Fread_from_string): Fix typo in docstring.
7612 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7614 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7615 newline, reseat the iterator instead of bidi-iterating there one
7616 character at a time. (Bug#9610)
7617 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7618 TO_CHARPOS if the bidi iterator is at base embedding level.
7620 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7622 * lread.c (readevalloop): Use correct code for NBSP.
7623 (read1): Likewise. (Bug#9608)
7625 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7627 * dbusbind.c (Fdbus_register_signal): When service is not
7628 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7630 2011-09-25 Glenn Morris <rgm@gnu.org>
7632 * buffer.c (truncate-lines): Doc fix.
7634 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7636 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7637 (Fset_window_next_buffers): Doc fix.
7639 2011-09-24 Glenn Morris <rgm@gnu.org>
7641 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7643 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7645 Fix minor problems found by static checking.
7646 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7647 * indent.c (Fvertical_motion): Fix == vs = typo.
7649 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7651 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7652 Default value is now t. Doc fix.
7654 * indent.c (Fvertical_motion): Compute and apply the overshoot
7655 logic when moving up, not only when moving down. Fix the
7656 confusing name and values of the it_overshoot_expected variable;
7657 logic changes accordingly. (Bug#9254) (Bug#9549)
7659 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7660 CHARPOS is covered by a display string which includes newlines.
7661 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7662 is covered by a display string with embedded newlines.
7664 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7666 * dbusbind.c (Fdbus_register_signal): Add match rule to
7667 Vdbus_registered_objects_table. (Bug#9581)
7668 (Fdbus_register_method, Vdbus_registered_objects_table):
7671 2011-09-24 Jim Meyering <meyering@redhat.com>
7673 do not ignore write error for any output size
7674 The previous change was incomplete.
7675 While it makes emacs --batch detect the vast majority of stdout
7676 write failures, errors were still ignored whenever the output size is
7677 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7678 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7679 && echo FAIL: ignored write error
7680 FAIL: ignored write error
7681 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7682 && echo FAIL: ignored write error
7683 FAIL: ignored write error
7684 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7686 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7688 * emacs.c (Fkill_emacs): In noninteractive mode exit
7689 non-successfully if a write error occurred on stdout. (Bug#9574)
7691 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7693 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7696 * dispextern.h (struct it): Update the comment documenting what
7699 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7701 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7702 a display string, extend search for cursor position to end of row.
7703 (find_row_edges): If the row ends in a newline from a display
7704 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7705 Handle the case of a display string with multiple newlines.
7706 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7707 non-empty line. Fixes confusing cursor motion with arrow keys at
7708 the beginning of a line that starts with whitespace.
7710 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7712 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7715 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7717 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7720 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7722 * xdisp.c (display_line): Record maximum and minimum buffer
7723 positions even if no glyphs were produced (e.g., by a zero-width
7724 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7725 buffer positions that will be removed from the glyph row because
7727 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7728 column is beyond frame width: don't subtract 1 "pixel" when
7729 computing width of the stretch.
7730 (reseat_at_next_visible_line_start): Undo the change made on
7731 2011-09-17 that saved paragraph information and restored it after
7732 the call to `reseat'. (Bug#9545)
7734 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7736 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7737 and turn window cursor on if cleared (Bug#9415).
7739 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7741 * search.c (boyer_moore): Take unibyte characters from pattern
7742 literally. (Bug#9458)
7744 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7746 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7748 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7750 Fix minor problem found by static checking.
7751 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7752 initialized, to pacify gcc -Wuninitialized.
7754 * fileio.c: Report proper errno when syscall falls.
7755 (Finsert_file_contents): Save and restore errno,
7756 so that report_file_error outputs the correct diagnostic.
7757 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7759 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7761 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7763 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7765 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7766 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7768 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7770 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7771 about the current paragraph and restore it after the call to reseat.
7773 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7774 (bidi_find_paragraph_start): Search back for paragraph beginning
7775 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7776 (bidi_move_to_visually_next): Only trigger paragraph-related
7777 computations when the last character is a newline or at EOB, not
7778 just any NEUTRAL_B. (Bug#9470)
7780 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7781 truncated lines if point is covered by a display string. (Bug#9524)
7783 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7785 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7786 (cons_to_x_long): New function.
7787 (lisp_data_to_selection_data): Use it. Correct the test for
7788 short-versus-long data; it was negated. Break out of vector
7789 loop, for efficiency, when a long datum is discovered.
7791 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7793 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7795 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7797 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7798 GCC PR/17406) by declaring this function with external scope.
7800 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7802 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7803 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7805 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7807 * editfns.c (Fformat): Correctly handle text properties on "%%".
7809 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7811 * xterm.c (x_draw_composite_glyph_string_foreground):
7812 * w32term.c (x_draw_composite_glyph_string_foreground):
7813 * term.c (encode_terminal_code):
7814 * composite.c (composition_update_it, get_composition_id):
7815 * xdisp.c (get_next_display_element)
7816 (fill_composite_glyph_string): Add comments about special meaning
7817 of TAB characters in a composition.
7819 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7821 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7822 This occurs when processing a multibyte format.
7823 Problem reported by Wolfgang Jenker.
7825 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7827 * xdisp.c (try_cursor_movement): Only check for exact match if
7828 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7830 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7832 Remove unused external symbols.
7833 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7834 * xdisp.c (calc_pixel_width_or_height): Now static.
7835 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7836 * indent.c (check_display_width):
7837 * w32term.c: Fix comment to match code.
7838 * xterm.c, xterm.h (x_catching_errors): Remove.
7840 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7842 * xselect.c: Use signed conversions more consistently (Bug#9498).
7843 (selection_data_to_lisp_data): Assume incoming selection data are
7844 signed integers, not unsigned. This is to be consistent with
7845 outgoing selection data, which was modified to use signed integers
7846 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7847 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7848 expects long, not unsigned long.
7850 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7852 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7853 computation of loop end. Reported by Johan Bockgård
7856 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7858 * frame.c (Fother_visible_frames_p): Function deleted.
7860 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7862 * indent.c (compute_motion): Process display vector front to back
7863 rather than the other way around. (Bug#2496)
7865 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7867 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7869 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7871 * minibuf.c (Fread_from_minibuffer): Doc fix.
7873 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7875 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7876 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7878 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7880 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7881 value for non-existent files.
7883 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7885 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7886 set its "size" to -1. This will set the modtime_size field of
7887 the corresponding buffer to -1, which is what
7888 verify-visited-file-modtime expects for files that do not exist.
7891 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7893 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7895 * lisp.h: ... from here. push_key_description is no longer
7896 defined in keyboard.c, so its declaration should not be in
7897 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7898 logically belongs with push_key_description.
7900 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7902 * buffer.h: Include <sys/types.h> instead of <time.h>.
7903 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7904 Problem reported by Herbert J. Skuhra.
7906 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7908 * xml.c (parse_region): Make the parsing work for
7909 non-comment-starting XML files again (bug#9144).
7911 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7913 * image.c (gif_load): Fix calculation of bottom and right corner.
7916 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7918 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7919 redisplay in small windows.
7921 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7923 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7925 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7927 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7928 Operate on live windows only.
7930 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7932 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7934 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7936 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7937 only under bidi iteration.
7939 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7941 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7943 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7945 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7946 Without this fix, the command to link temacs failed due to an
7947 undefined symbol __builtin_isnan. This is because
7948 /usr/include/iso/math_c99.h #defines isnan(x) to
7949 __builtin_isnan(x), but the bundled gcc, which identifies itself
7950 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7952 * floatfns.c (isnan): #undef, and then #define to a clone of
7954 (Fisnan): Always define, since it's always available now.
7955 (syms_of_floatfns): Always define isnan at the Lisp level.
7957 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7959 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7961 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7963 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7964 The previous code assumed that file offsets (off_t values) fit in
7965 EMACS_INT variables, which is not true on typical 32-bit hosts.
7966 The code messed up by falsely reporting buffer overflow in cases
7967 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7968 when "big" contains more than 2**29 bytes, even though this
7969 inserts just one byte and does not overflow the buffer.
7970 (Finsert_file_contents): Store file offsets as off_t
7971 values, not as EMACS_INT values. Check for overflow when
7972 converting between EMACS_INT and off_t. When checking for
7973 buffer overflow or for overlap, take the offsets into account.
7974 Don't use EMACS_INT for small values where int suffices.
7975 When checking for overlap, fix a typo: ZV was used where
7976 ZV_BYTE was intended.
7977 (Fwrite_region): Don't assume off_t fits into 'long'.
7978 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7980 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7982 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7984 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7986 sprintf-related integer and memory overflow issues (Bug#9412).
7988 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7989 (esprintf, exprintf, evxprintf): New functions.
7990 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7991 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7992 (modify_event_symbol): Do not assume that the length of
7993 name_alist_or_stem is safe to alloca and fits in int.
7994 (Fexecute_extended_command): Likewise for function name and binding.
7995 (Frecursion_depth): Wrap around reliably on integer overflow.
7996 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7997 since some callers pass EMACS_INT values.
7998 (Fsingle_key_description): Don't crash if symbol name contains more
7999 than MAX_ALLOCA bytes.
8000 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8001 (get_minibuffer): Arg is now EMACS_INT, not int.
8002 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8003 (esprintf, exprintf, evxprintf): New decls.
8004 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8006 * dbusbind.c (signature_cat): New function.
8007 (xd_signature, Fdbus_register_signal):
8008 Do not overrun buffer; instead, report string overflow.
8010 * dispnew.c (add_window_display_history): Don't overrun buffer.
8011 Truncate instead; this is OK since it's just a log.
8013 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8014 even if the time zone offset is outlandishly large.
8015 Don't mishandle offset == INT_MIN.
8017 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8018 when creating daemon; the previous buffer-overflow check was incorrect.
8020 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8021 which has the guts of the old verror function.
8023 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8024 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8026 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8027 (font_unparse_xlfd): Don't blindly alloca long strings.
8028 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8029 fits in int, when using sprintf. Use single snprintf to count
8030 length of string rather than counting it via multiple sprintfs;
8031 that's simpler and more reliable.
8032 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8033 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8034 sprintf, in case result does not fit in int.
8036 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8037 (fontset_from_font): Print it.
8039 * frame.c (tty_frame_count): Now printmax_t, not int.
8040 (make_terminal_frame, set_term_frame_name): Print it.
8041 (x_report_frame_params): In X, window IDs are unsigned long,
8042 not signed long, so print them as unsigned.
8043 (validate_x_resource_name): Check for implausibly long names,
8044 and don't assume name length fits in 'int'.
8045 (x_get_resource_string): Don't blindly alloca invocation name;
8046 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8049 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8050 (xg_check_special_colors, xg_set_geometry):
8051 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8053 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8054 Use esprintf, not sprintf, in case result does not fit in int.
8056 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8057 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8058 it as a large positive number.
8059 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8060 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8062 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8063 in case result does not fit in int.
8065 * print.c (float_to_string): Detect width overflow more reliably.
8066 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8067 buffer overrun. Don't assume list length fits in 'int'. Treat
8068 print length of 0 as 0, not as infinity; to be consistent with other
8069 uses of print length in this function. Don't overflow print length
8070 index. Don't assume hash table size fits in 'long', or that
8071 vectorlike size fits in 'unsigned long'.
8073 * process.c (make_process): Use printmax_t, not int, to format
8074 process-name gensyms.
8076 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8078 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8079 to avoid potential buffer overrun.
8081 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8082 if X resource line is longer than 512 bytes.
8084 * xfns.c (x_window): Make sprintf buffer a bit bigger
8085 to avoid potential buffer overrun.
8087 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8089 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8091 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8093 Integer overflow fixes for scrolling, etc.
8094 Without these, Emacs silently mishandles large integers sometimes.
8095 For example, "C-u 4294967297 M-x recenter" was treated as if
8096 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8098 * xdisp.c (try_window_id): Check Emacs fixnum range before
8099 converting to 'int'.
8101 * window.c (window_scroll_line_based, Frecenter):
8102 Check that an Emacs fixnum is in range before assigning it to 'int'.
8103 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8104 values converted from Emacs fixnums.
8105 (Frecenter): Don't wrap around a line count if it is out of 'int'
8106 range; instead, treat it as an extreme value.
8107 (Fset_window_configuration, compare_window_configurations):
8108 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8110 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8111 that can exceed INT_MAX. Check that EMACS_INT value is in range
8112 before assigning it to the (possibly-narrower) index.
8113 (match_limit): Don't assume that a fixnum can fit in 'int'.
8115 * print.c (print_object): Use ptrdiff_t, not int, for index that can
8118 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
8119 (Fvertical_motion): Don't wrap around LINES values that don't fit
8120 in 'int'. Instead, treat them as extreme values. This is good
8121 enough for windows, which can't have more than INT_MAX lines anyway.
8123 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8125 * Require libxml/parser.h to avoid compilation warning.
8127 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8129 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8130 since this reportedly can destroy thread storage.
8132 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
8134 * syntax.c (find_defun_start): Update all cache variables if
8135 exiting early (Bug#9401).
8137 2011-08-30 Eli Zaretskii <eliz@gnu.org>
8139 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8141 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8142 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8143 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8145 * term.c (tty_append_glyph): New function.
8146 (produce_stretch_glyph): Static function and its prototype deleted.
8148 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8151 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8153 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8154 when checking :margin (Bug#9390).
8155 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
8156 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
8157 so that the name doesn't mislead. All uses changed.
8159 2011-08-28 Johan Bockgård <bojohan@gnu.org>
8161 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8164 2011-08-27 Eli Zaretskii <eliz@gnu.org>
8166 * xdisp.c (move_it_to): Don't bail out early when reaching
8167 position beyond to_charpos, if we are scanning backwards.
8168 (move_it_vertically_backward): When DY == 0, make sure we get to
8169 the first character in the line after the newline.
8171 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8173 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8174 (ccl_driver): Do not generate an out-of-range pointer.
8175 (Fccl_execute_on_string): Remove unnecessary check for
8176 integer overflow, noted by Stefan Monnier in
8177 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8178 Remove a FIXME that didn't need fixing.
8179 Simplify the newly-introduced buffer reallocation code.
8181 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
8183 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8185 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
8187 Integer and memory overflow issues (Bug#9196).
8189 * doc.c (get_doc_string): Rework so that
8190 get_doc_string_buffer_size is the actual buffer size, rather than
8191 being 1 less than the actual buffer size; this makes xpalloc more
8194 * image.c (x_allocate_bitmap_record, cache_image):
8195 * xselect.c (Fx_register_dnd_atom):
8196 Simplify previous changes by using xpalloc.
8198 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8199 since either will do and ptrdiff_t is convenient with xpalloc.
8201 * charset.c (charset_table_size)
8202 (struct charset_sort_data.priority): Now ptrdiff_t.
8203 (charset_compare): Don't overflow if priorities differ greatly.
8204 (Fsort_charsets): Don't assume list length fits in int.
8205 Check for size-calculation overflow when allocating sort data.
8206 (syms_of_charset): Allocate an initial charset table that is
8207 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8209 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8211 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8212 The actual value is always <= INT_MAX, and leaving it unsigned made
8213 overflow checking harder.
8215 * dispextern.h (struct glyph_matrix.rows_allocated)
8216 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8217 with xpalloc. The values are still always <= INT_MAX.
8219 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8221 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8222 (SAFE_NALLOCA): New macro.
8224 * region-cache.c (struct boundary.pos, find_cache_boundary)
8225 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8226 (set_cache_region, invalidate_region_cache)
8227 (revalidate_region_cache, know_region_cache, region_cache_forward)
8228 (region_cache_backward, pp_cache):
8229 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8230 so that ptrdiff_t * can be passed to xpalloc.
8231 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8232 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8233 (pp_cache): Don't assume cache_len fits in int.
8234 * region-cache.h: Adjust extern decls to match.
8236 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8237 EMACS_INT, since either will do, for xpalloc.
8239 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8240 (xnmalloc, xnrealloc, xpalloc): New functions.
8242 * bidi.c (bidi_shelve_header_size): New constant.
8243 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8244 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8246 * bidi.c (bidi_cache_shrink):
8247 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8249 Don't update size of array until after memory allocation succeeds,
8250 because xmalloc/xrealloc may not return.
8251 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8252 now that we have proper integer overflow checking.
8253 (record_overlay_string, overlay_strings): Catch overflows when
8254 calculating size of overlay_str_buf.
8256 * callproc.c (Fcall_process): Check for size overflow when
8257 calculating size of args2.
8258 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8259 Normally we prefer signed values, but sticking with ptrdiff_t would
8260 require adding more-complicated checks.
8262 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8263 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8264 Redo buffer-overflow calculations to avoid integer overflow.
8265 Add a FIXME comment where memory seems to be over-allocated.
8267 * character.c (Fstring): Check for size-calculation overflow.
8269 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8270 unnecessary integer overflow. Check for size overflow.
8271 (encode_coding_object): Don't update size until xmalloc succeeds.
8273 * composite.c (get_composition_id): Check for overflow in glyph
8274 length calculations.
8276 Integer and memory overflow fixes for display code.
8277 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8278 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8279 (scrolling_window): Check for overflow in size calculations.
8280 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8281 Don't assume glyph table len fits in int.
8282 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8283 (row_table_size): Now ptrdiff_t, not int.
8284 (scrolling_window): Avoid overflow in size calculations.
8285 Don't update size until allocation succeeds.
8286 * fns.c (concat): Check for overflow in size calculations.
8287 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8288 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8289 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8291 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8292 (get_doc_string): Check for size calculation overflow.
8293 Don't update size until allocation succeeds.
8294 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8295 EMACS_INT, where ptrdiff_t will do.
8296 (Fsubstitute_command_keys): Check for string overflow.
8298 * editfns.c (set_time_zone_rule): Don't assume environment length
8300 (message_length): Now ptrdiff_t, not int.
8301 (Fmessage_box): Don't update size until allocation succeeds.
8302 Don't assume message length fits in int.
8303 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8305 * emacs.c (main): Do not reallocate argv, since there is a null at
8306 the end that can be overwritten, and this way there's no need to
8307 worry about size-calculation overflow.
8308 (sort_args): Check for size-calculation overflow.
8310 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8312 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8314 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8315 (x_set_scroll_bar_width, x_figure_window_size):
8316 Check for integer overflow.
8317 (x_set_alpha): Do not assume XINT fits in int.
8319 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8320 This is for the members text_lines, text_cols, total_lines, total_cols,
8321 where the system imposes an 'int' limit.
8323 * fringe.c (Fdefine_fringe_bitmap):
8324 Don't update size until alloc works.
8326 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8327 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8329 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8330 Check for size-calculation overflow.
8331 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8332 do, as we prefer signed integers.
8333 (id_to_widget.max_size, id_to_widget.used)
8334 (xg_store_widget_in_map, xg_remove_widget_from_map)
8335 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8336 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8337 Use and return ptrdiff_t, not int.
8338 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8339 * gtkutil.h: Change prototypes to match the above.
8341 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8342 are duplicate now that they've been promoted to lisp.h.
8343 (x_allocate_bitmap_record, x_alloc_image_color)
8344 (make_image_cache, cache_image, xpm_load):
8345 Don't update size until alloc is done.
8346 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8348 Check for size calculation overflow.
8349 (ct_colors_allocated_max): New constant.
8350 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8353 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8354 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8355 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8356 Use ptrdiff_t, not int, to count maps.
8357 (read_char_minibuf_menu_prompt): Check for overflow in size
8358 calculations. Don't update size until allocation succeeds.
8359 Redo calculations to avoid overflow.
8360 * keyboard.h: Change prototypes to match the above.
8362 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8364 (current_minor_maps): Check for size calculation overflow.
8365 * keymap.h: Change prototypes to match the above.
8367 * lread.c (read1, init_obarray): Don't update size until alloc done.
8369 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8370 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8372 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8373 Now ptrdiff_t, not int.
8374 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8375 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8377 * process.c (Fnetwork_interface_list): Check for overflow
8378 in size calculation.
8380 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8382 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8383 overflow. Don't bother calling xmalloc when xrealloc will do.
8385 * search.c (Freplace_match): Check for size calculation overflow.
8386 (Fset_match_data): Don't assume list lengths fit in 'int'.
8388 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8389 for command line length. Do not attempt to address one before the
8390 beginning of an array, as that's not portable.
8392 * term.c (max_frame_lines): Remove; unused.
8393 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8395 (encode_terminal_code, calculate_costs): Check for size
8396 calculation overflow.
8397 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8398 table lengths and related sizes. Don't update size until alloc
8399 done. Redo calculations to avoid overflow.
8400 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8402 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8403 subtracting pointers.
8404 (gobble_line): Check for overflow more carefully. Don't update size
8407 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8408 Don't update size until alloc done.
8409 Redo size calculations to avoid overflow.
8410 Check for size calculation overflow.
8411 (main) [DEBUG]: Fix typo in invoking tparam1.
8413 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8414 Use ptrdiff_t, not int, for sizes.
8415 (store_mode_line_noprop_char): Don't update size until alloc done.
8417 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8418 Use ptrdiff_t, not int, for sizes.
8419 (Finternal_make_lisp_face, cache_face):
8420 Check for size calculation overflow.
8421 (cache_face): Treat size calculation overflows as if they were
8422 memory exhaustion (the usual treatment), rather than aborting.
8424 * xfns.c (x_encode_text, x_set_name_internal)
8425 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8426 sizes, since they can exceed INT_MAX in size. Check for size
8427 calculation overflow.
8429 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8430 (xg_select): Check for size calculation overflow.
8431 Don't update size until alloc done.
8433 * xrdb.c (get_environ_db): Don't assume path length fits in int,
8434 as sprintf is limited to int lengths.
8436 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8437 (X_LONG_MIN): New macros.
8438 Use them to make the following changes clearer.
8439 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8440 This change doesn't affect the value now, but it may help remind
8441 future maintainers not to raise the value too much later.
8442 (SELECTION_QUANTUM): Remove, replacing with ...
8443 (selection_quantum): ... new function, which avoids overflow.
8445 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8446 assumption that selection length fits in 'int'.
8447 (x_reply_selection_request, x_handle_selection_request)
8448 (x_get_window_property, receive_incremental_selection)
8449 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8450 (lisp_data_to_selection_data, clean_local_selection_data):
8451 Use ptrdiff_t, not int, to record length of selection.
8452 (x_reply_selection_request, x_get_window_property)
8453 (receive_incremental_selection, x_property_data_to_lisp):
8454 Redo calculations to avoid overflow.
8455 (x_reply_selection_request): When sending hint, ceiling it at
8456 X_LONG_MAX rather than relying on wraparound overflow to send
8458 (x_get_window_property, receive_incremental_selection)
8459 (lisp_data_to_selection_data, x_property_data_to_lisp):
8460 Check for size-calculation overflow.
8461 (x_get_window_property, receive_incremental_selection)
8462 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8463 Don't store size until memory allocation succeeds.
8464 (x_get_window_property): Plug memory leak on memory exhaustion.
8465 Don't double-block input; malloc is safe here. Don't assume 2**34
8466 - 4 fits in unsigned long. Add an xassert to check
8467 XGetWindowProperty overflow. Be more careful about overflow
8468 calculations, and distinguish size from memory overflow better.
8469 (receive_incremental_selection): When tracing, don't assume
8470 unsigned int is less than INT_MAX.
8471 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8472 harmful) conversions of unsigned short to int.
8473 (lisp_data_to_selection_data): Don't assume that integers
8474 in the range -65535 through -1 fit in an X unsigned short.
8475 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8476 result parameters unless successful. Rely on cons_to_unsigned
8477 to report problems with elements; the old code wasn't right anyway.
8478 (x_check_property_data): Check for int overflow; we cannot use
8479 a wider type due to X limits.
8480 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8482 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
8484 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8485 (x_term_init): Check for size calculation overflow.
8486 (x_color_cells): Don't store size until memory allocation succeeds.
8487 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
8488 Don't assume alloca size is less than MAX_ALLOCA.
8489 (x_term_init): Don't assume length fits in int (sprintf is limited
8492 Use ptrdiff_t for composition IDs.
8493 * character.c (lisp_string_width):
8494 * composite.c (composition_table_size, n_compositions)
8495 (get_composition_id, composition_gstring_from_id):
8496 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8497 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8498 * window.c (Frecenter):
8499 Use ptrdiff_t, not int, for composition IDs.
8500 * composite.c (get_composition_id): Check for integer overflow.
8501 * composite.h: Adjust prototypes to match the above changes.
8503 Use ptrdiff_t for hash table indexes.
8504 * category.c (hash_get_category_set):
8505 * ccl.c (ccl_driver):
8506 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8507 * coding.c (coding_system_charset_list, detect_coding_system):
8508 * coding.h (struct coding_system.id):
8509 * composite.c (get_composition_id, gstring_lookup_cache):
8510 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8511 * image.c (xpm_get_color_table_h):
8512 * lisp.h (hash_lookup, hash_put):
8513 * minibuf.c (Ftest_completion):
8514 Use ptrdiff_t for hash table indexes, not int (which is too
8515 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8516 32-bit --with-wide-int hosts).
8518 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8519 Add a FIXME comment about memory leaks.
8520 (syms_of_charset): Don't assume xmalloc returns.
8522 Don't assume that stated character widths fit in int.
8523 * character.c (Fchar_width, c_string_width, lisp_string_width):
8524 * character.h (CHAR_WIDTH):
8525 * indent.c (MULTIBYTE_BYTES_WIDTH):
8526 Use sanitize_char_width to avoid undefined and/or bad behavior
8527 with outlandish widths.
8528 * character.h (sanitize_tab_width): Rename from sanitize_width,
8529 now that we have two such functions. All uses changed.
8530 (sanitize_char_width): New inline function.
8532 Don't assume that tab-width fits in int.
8533 * character.h (sanitize_width): New inline function.
8534 (SANE_TAB_WIDTH): New macro.
8535 (ASCII_CHAR_WIDTH): Use it.
8536 * indent.c (sane_tab_width): Remove. All uses replaced by
8537 SANE_TAB_WIDTH (current_buffer).
8538 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8540 * fileio.c: Integer overflow issues with file modes.
8541 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8543 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8544 Remove unreachable code.
8545 (read_hex, load_charset_map_from_file): Check for integer overflow.
8547 * xterm.c: Don't go over XClientMessageEvent limit.
8548 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8549 (x_send_scroll_bar_event): Likewise. Check that the size does not
8550 exceed limits imposed by XClientMessageEvent, as well as the usual
8551 ptrdiff_t and size_t limits.
8553 * keyboard.c: Overflow, signedness and related fixes.
8554 (make_lispy_movement): Use same integer type in forward decl
8555 that is used in the definition.
8556 (read_key_sequence, keyremap_step):
8557 Change bufsize argument back to int, undoing my 2011-03-30 change.
8558 We prefer signed types, and int is wide enough here.
8559 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8560 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8561 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8562 length, not size_t. Use ptrdiff_t for index, not int.
8563 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8564 possibility of integer overflow.
8566 Overflow, signedness and related fixes for images.
8568 * dispextern.h (struct it.stack[0].u.image.image_id)
8569 (struct_it.image_id, struct image.id, struct image_cache.size)
8570 (struct image_cache.used, struct image_cache.ref_count):
8571 * gtkutil.c (update_frame_tool_bar):
8572 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8573 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8574 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8575 * nsmenu.m (update_frame_tool_bar):
8576 * xdisp.c (calc_pixel_width_or_height):
8577 * xfns.c (image_cache_refcount):
8578 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8579 on typical 64-bit hosts.
8581 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8582 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8583 Omit unnecessary casts to int.
8584 (parse_image_spec): Check that integers fall into 'int' range
8585 when the callers expect that.
8586 (image_ascent): Redo ascent calculation to avoid int overflow.
8587 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8588 (lookup_image): Remove unnecessary tests.
8589 (xbm_image_p): Locals are now of int, not EMACS_INT,
8590 since parse_image_check makes sure they fit into int.
8591 (png_load, gif_load, svg_load_image):
8592 Prefer int to unsigned where either will do.
8593 (tiff_handler): New function, combining the cores of the
8594 old tiff_error_handler and tiff_warning_handler.
8595 This function is rewritten to use vsnprintf and thereby avoid
8596 stack buffer overflows. It uses only the features of vsnprintf
8597 that are common to both POSIX and native Microsoft.
8598 (tiff_error_handler, tiff_warning_handler): Use it.
8599 (tiff_load, gif_load, imagemagick_load_image):
8600 Don't assume :index value fits in 'int'.
8601 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8602 (imagemagick_load_image): Check that crop parameters fit into
8603 the integer types that MagickCropImage accepts. Don't assume
8604 Vimagemagick_render_type has a nonnegative value. Don't assume
8605 size_t fits in 'long'.
8606 (gs_load): Use printmax_t to print the widest integers possible.
8607 Check for integer overflow when computing image height and width.
8609 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8611 * xdisp.c (redisplay_window): Don't force window start if point
8612 will be invisible in the resulting window. (Bug#9324)
8614 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8616 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8617 the display spec is of the form `(space ...)'.
8618 (handle_display_spec): Return the value returned by
8619 handle_single_display_spec, not just 1 or zero.
8620 (handle_single_display_spec): If the display spec is of the form
8621 `(space ...)', and specifies display in the text area, return 2
8623 (try_cursor_movement): Check for the need to scroll more
8624 accurately, and prefer exact match for point under bidi.
8625 Don't advance `row' beyond the last row of the window.
8627 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8628 into disp_prop; all users changed.
8630 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8631 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8632 for the text covered by the display property.
8634 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8636 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8637 Change return value to nil.
8638 (Frecord_buffer): Delete unused function.
8640 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8642 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8643 buffers, return left-to-right.
8644 (set_cursor_from_row): Consider candidate row a win if its glyph
8645 represents a newline and point is on that newline. Fixes cursor
8646 positioning on the newline at EOL of R2L text within L2R
8647 paragraph, and vice versa.
8648 (try_cursor_movement): Check continued rows, in addition to
8649 continuation rows. Fixes unwarranted scroll when point enters a
8650 continued line of R2L text within an L2R paragraph, or vice versa.
8651 (cursor_row_p): Consider the case of point being equal to
8652 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8653 from the end of a short line to the beginning of a continued line
8654 of R2L text within L2R paragraph.
8655 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8656 composed characters.
8658 * bidi.c (bidi_check_type): Use xassert.
8659 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8662 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8664 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8667 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8669 * nsfont.m (ns_otf_to_script): Fix typo.
8671 2011-08-22 Kenichi Handa <handa@m17n.org>
8673 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8674 extra slot even if the purpose is char-code-property-table.
8676 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8678 * xdisp.c (redisplay_window): When computing centering_position,
8679 account for the height of the header line. (Bug#8874)
8681 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8682 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8683 candidate is selected by the mouse, and that candidate has a
8684 composed character under the mouse.
8686 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8687 coordinates reported by pos-visible-in-window-p for a composed
8688 character in column zero.
8690 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8692 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8694 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8696 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8697 consider it a hit if to_charpos is anywhere in the range of the
8698 composed buffer positions.
8700 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8702 * image.c (gif_load): Don't assume that each subimage has the same
8703 dimensions as the base image. Handle disposal method that is
8704 "undefined" by the gif spec (Bug#9335).
8706 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8708 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8709 (Fcondition_case): Document `debug' symbol in error handler.
8711 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8713 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8714 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8715 from an Org mode buffer to a Speedbar frame.
8717 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8718 a composition, take its buffer position from IT->cmp_it.charpos.
8719 Fixes cursor positioning at the beginning of a line that begins
8720 with a composed character.
8722 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8724 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8725 character bidirectional type, use STRONG_L instead. Fixes crashes
8726 in a buffer produced by `describe-categories'.
8728 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8729 members before the level stack, so they would be saved and
8730 restored when copying iterator state. Fixes incorrect reordering
8731 around TABs covered by display properties.
8733 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8735 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8737 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8739 * eval.c (internal_condition_case, internal_condition_case_1)
8740 (internal_condition_case_2, internal_condition_case_n):
8741 Remove unnecessary aborts (Bug#9081).
8743 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8745 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8746 has no `load' handler, try opening the file locally. (Bug#9311)
8748 2011-08-16 Ken Brown <kbrown@cornell.edu>
8750 * gmalloc.c: Expand comment.
8752 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8754 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8755 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8757 2011-08-16 Ken Brown <kbrown@cornell.edu>
8759 Fix memory allocation problems in Cygwin build (Bug#9273).
8761 * unexcw.c ( __malloc_initialized): Declare external variable.
8762 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8764 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8766 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8768 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8770 [CYGWIN] (special_realloc): New function.
8771 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8772 requests to realloc storage in the static heap.
8774 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8776 * bidi.c (bidi_initialize): Remove unused local.
8778 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8781 * biditype.h: Remove file.
8782 * makefile.w32-in ($(BLD)/bidi.$(O)):
8783 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8785 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8787 * chartab.c: Improve commentary for the uniprop_table API.
8789 * bidi.c (bidi_paragraph_init): Support zero value of
8790 bidi_ignore_explicit_marks_for_paragraph_level.
8791 (bidi_initialize): Use uniprop_table instead of including
8792 biditype.h and bidimirror.h.
8794 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8795 coordinates of the iterator when restoring from ppos_it.
8798 2011-08-14 Kenichi Handa <handa@m17n.org>
8800 * process.c (create_process): Call setup_process_coding_systems
8801 after the pid of the process is set to -1 (Bug#8162).
8803 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8805 * xdisp.c (move_it_in_display_line_to): Don't invoke
8806 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8807 ppos_it. Fixes vertical cursor motion when line beginning is
8808 covered by an image. (Bug#9296)
8810 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8812 * nsterm.h (ns_run_ascript): Declare.
8813 (NSAPP_DATA2_RUNASSCRIPT): Define.
8815 * nsfns.m (as_script, as_result, as_status): New static variables.
8816 (ns_run_ascript): New function.
8817 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8818 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8819 the event loop. Get status from as_status (Bug#7276).
8821 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8822 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8823 the event loop (Bug#7276).
8825 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8827 * gnutls.c (QCgnutls_bootprop_priority)
8828 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8829 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8830 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8831 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8832 (QCgnutls_bootprop_verify_hostname_error)
8833 (QCgnutls_bootprop_callbacks_verify): Rename from
8834 Qgnutls_bootprop_..., all uses changed.
8836 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8839 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8841 * xfaces.c (Qframe_set_background_mode): Now static.
8842 * dispextern.h (Qframe_set_background_mode): Remove decl.
8844 * process.c (Fnetwork_interface_info): Declare local only if needed.
8846 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8848 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8849 (Fnetwork_interface_list): Allocate in increments of bytes instead
8850 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8851 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8853 (struct ifflag_def): notrailers is smart on OSX.
8854 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8855 Get hardware address with getifaddrs if available.
8857 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8859 * xdisp.c (iterate_out_of_display_property): xassert that
8860 IT->position is set to within IT->object's boundaries. Break from
8861 the loop as soon as EOB is reached; avoids infloops in redisplay
8862 when IT->position is set up wrongly due to some bug.
8863 Set IT->current to match the bidi iterator unconditionally.
8864 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8865 entry. Force push_it to save on the stack the current
8866 buffer/string position, to be restored by pop_it. Fix flags in
8867 the iterator structure wrt the object coming from a display
8868 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8869 properties. (Bug#9284)
8871 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8873 * fontset.c (fontset_get_font_group): Add proper type checks.
8876 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8878 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8879 and LC_VERSION_MIN_MACOSX.
8880 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8881 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8883 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8885 * xdisp.c (forward_to_next_line_start): Allow to use the
8886 no-display-properties-and-no-overlays under bidi display.
8887 Set disp_pos in the bidi iterator to avoid searches for display
8888 properties and overlays.
8890 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8892 * editfns.c (Fset_time_zone_rule): Document relationship with the
8895 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8896 the font entity extracted from the cache (Bug#8109).
8898 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8900 * composite.c (autocmp_chars): Don't reset point. That is done by
8901 restore_point_unwind (Bug#5984).
8903 2011-08-07 Juri Linkov <juri@jurta.org>
8905 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8906 to show the arg `TIME' instead of `TIMEVAL'.
8908 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8910 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8911 display property strides EOL and includes a newline, as in
8912 longlines-mode. (Bug#9254)
8913 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8914 word-wrap under bidirectional display. (Bug#9224)
8916 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8917 is non-zero, even if the data buffer is NULL. Fixes a crash in
8918 vertical-motion with longlines-mode. (Bug#9254)
8920 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8922 * bidi.c <bidi_cache_total_alloc>: Now static.
8923 (bidi_initialize): Initialize bidi_cache_total_alloc.
8925 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8928 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8929 amount allocated this far in `bidi_cache_total_alloc'.
8930 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8931 non-zero, only free the data buffer without restoring the cache
8932 contents. All callers changed.
8934 * dispextern.h (bidi_unshelve_cache): Update prototype.
8936 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8937 (move_it_in_display_line, move_it_to)
8938 (move_it_vertically_backward, move_it_by_lines): Replace the call
8939 to xfree to an equivalent call to bidi_unshelve_cache.
8940 (move_it_in_display_line_to): Fix logic of returning
8941 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8943 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8945 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8946 came from a string character with a `cursor' property. (Bug#9229)
8948 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8950 * Makefile.in (LIB_PTHREAD): New variable.
8951 (LIBES): Add LIB_PTHREAD (Bug#9216).
8953 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8954 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8956 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8958 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8960 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8962 * xterm.c (x_find_topmost_parent): New function.
8963 (x_set_frame_alpha): Find topmost parent window with
8964 x_find_topmost_parent and set the property there also (bug#9181).
8965 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8967 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8969 * callproc.c (Fcall_process): Avoid vfork clobbering
8970 the local vars buffer, coding_systems, current_dir.
8972 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8974 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8976 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8978 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8979 so that it is not optimized away.
8981 * xdisp.c (compute_display_string_pos): Remove unused local.
8983 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8985 Fix slow cursor motion and scrolling in large buffers with
8986 selective display, like Org Mode buffers. (Bug#9218)
8988 * dispextern.h (struct bidi_it): New member disp_prop_p.
8990 * xdisp.c: Remove one-slot cache of display string positions.
8991 (compute_display_string_pos): Accept an additional argument
8992 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8993 for a display string or property. If found, set DISP_PROP_P
8996 * bidi.c (bidi_fetch_char): Accept an additional argument
8997 DISP_PROP_P, and pass it to compute_display_string_pos.
8998 Only handle text covered by a display string if DISP_PROP_P is returned
8999 non-zero. All callers of bidi_fetch_char changed.
9001 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9003 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9005 2010-12-03 Don March <don@ohspite.net>
9007 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9008 last character M-[char] is translated to ESC [char] (bug#7541).
9010 2011-08-02 Kenichi Handa <handa@m17n.org>
9012 * lisp.h (uniprop_table): Extern it.
9014 * chartab.c (uniprop_table): Make it non-static.
9016 2011-08-01 Eli Zaretskii <eliz@gnu.org>
9018 * xdisp.c (forward_to_next_line_start): Accept additional argument
9019 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9021 (reseat_at_next_visible_line_start): Use the bidi iterator state
9022 returned by forward_to_next_line_start to restore the state of
9023 it->bidi_it after backing up to previous newline. (Bug#9212)
9025 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9027 * regex.c (re_comp): Protoize.
9028 (re_exec): Fix return type.
9029 (regexec): Fix type of `ret'. (Bug#9203)
9031 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9033 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9034 This is needed if max-image-size is a floating-point number.
9036 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9038 * print.c (print_object): Print empty symbol as ##.
9040 * lread.c (read1): Read ## as empty symbol.
9042 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9044 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9045 setting frame foreground color (Bug#9175).
9046 (x_set_background_color): Likewise.
9048 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9049 contents (Bug#9176).
9050 (EmacsTooltip -init): Remove bezels and add shadows to
9053 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9054 or scroll bar (Bug#8470).
9056 * nsfont.m (nsfont_open): Remove assignment to voffset and
9057 unnecessary vars hshink, expand, hd, full_height, min_height.
9058 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9060 * nsterm.h (nsfont_info): Remove voffset field.
9062 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9064 Implement strike-through and overline on NextStep (Bug#8863).
9066 * nsfont.m (nsfont_open): Use underline position provided by font,
9067 instead of hard-coded value of 2.
9068 (nsfont_draw): Call ns_draw_text_decoration instead.
9070 * nsterm.h: Add declaration for ns_draw_text_decoration.
9072 * nsterm.m (ns_draw_text_decoration): New function for drawing
9073 underline, overline, and strike-through.
9074 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9075 ns_draw_text_decoration. Change treatment of cursor drawing to
9076 accommodate underlining, etc.
9078 2011-07-28 Eli Zaretskii <eliz@gnu.org>
9080 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9083 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9085 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9086 Without this fix, if a signal arrives just after memory fills up,
9087 'malloc' might be invoked reentrantly.
9089 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9090 In other words, assume that every image size is allowed, on non-X
9091 hosts. This assumption is probably wrong, but it lets Emacs compile.
9093 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9095 * regex.c (re_iswctype): Convert return values to boolean.
9097 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9099 * xdisp.c (compute_display_string_pos): Don't use cached display
9100 string position if the buffer had its restriction changed.
9103 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9105 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9107 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9109 Integer signedness and overflow and related fixes. (Bug#9079)
9111 * bidi.c: Integer size and overflow fixes.
9112 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9113 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9114 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9115 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9116 (bidi_find_other_level_edge):
9117 Use ptrdiff_t instead of EMACS_INT where either will do.
9118 This works better on 32-bit hosts configured --with-wide-int.
9119 (bidi_cache_ensure_space): Check for size-calculation overflow.
9120 Use % rather than repeated addition, for better worst-case speed.
9121 Don't set bidi_cache_size until after xrealloc returns, because it
9123 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
9124 (bidi_cache_ensure_space): Also check that the bidi cache size
9125 does not exceed that of the largest Lisp string or buffer. See Eli
9126 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
9128 * alloc.c (__malloc_size_t): Remove.
9129 All uses replaced by size_t. See Andreas Schwab's note
9130 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9132 * image.c: Improve checking for integer overflow.
9133 (check_image_size): Assume that f is nonnull, since
9134 it is always nonnull in practice. This is one less thing to
9135 worry about when checking for integer overflow later.
9136 (x_check_image_size): New function, which checks for integer
9137 overflow issues inside X.
9138 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9139 This removes the need for a memory_full check.
9140 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9141 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9142 (xbm_read_bitmap_data): Change locals back to 'int', since
9143 their values must fit in 'int'.
9144 (xpm_load_image, png_load, tiff_load):
9145 Invoke x_create_x_image_and_pixmap earlier,
9146 to avoid much needless work if the image is too large.
9147 (tiff_load): Treat overly large images as if
9148 x_create_x_image_and_pixmap failed, not as malloc failures.
9149 (gs_load): Use x_check_image_size.
9151 * gtkutil.c: Omit integer casts.
9152 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9153 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9155 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9157 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9158 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9159 would wrongly return t on a 64-bit host.
9161 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9162 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9163 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9164 and therefore cause GCC to emit a bogus diagnostic in some cases.
9166 * image.c: Integer signedness and overflow and related fixes.
9167 This is not an exhaustive set of fixes, but it's time to
9168 record what I've got.
9169 (lookup_pixel_color, check_image_size): Remove redundant decls.
9170 (check_image_size): Don't assume that arbitrary EMACS_INT values
9171 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9172 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9173 (tiff_load, imagemagick_load_image):
9174 Check for overflow in size calculations.
9175 (x_create_x_image_and_pixmap): Remove unnecessary test for
9176 xmalloc returning NULL; that can't happen.
9177 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9178 (xpm_color_bucket): Use better integer hashing function.
9179 (xpm_cache_color): Don't possibly over-allocate memory.
9180 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9181 (gif_memory_source):
9182 Use ptrdiff_t, not int or size_t, to record sizes.
9183 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9184 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9185 either works, as we prefer signed integers.
9186 (tiff_read_from_memory, tiff_write_from_memory):
9187 Return tsize_t, not size_t, since that's what the TIFF API wants.
9188 (tiff_read_from_memory): Don't fail simply because the read would
9189 go past EOF; instead, return a short read.
9190 (tiff_load): Omit no-longer-needed casts.
9191 (Fimagemagick_types): Don't assume size fits into 'int'.
9193 Improve hashing quality when configured --with-wide-int.
9194 * fns.c (hash_string): New function, taken from sxhash_string.
9195 Do not discard information about ASCII character case; this
9196 discarding is no longer needed.
9197 (sxhash-string): Use it. Change sig to match it. Caller changed.
9198 * lisp.h: Declare it.
9199 * lread.c (hash_string): Remove, since we now use fns.c's version.
9200 The fns.c version returns a wider integer if --with-wide-int is
9201 specified, so this should help the quality of the hashing a bit.
9203 * emacs.c: Integer overflow minor fix.
9204 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9205 Define only if GNU_LINUX.
9206 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9208 * dispnew.c: Integer signedness and overflow fixes.
9209 Remove unnecessary forward decls, that were a maintenance hassle.
9210 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9212 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9213 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9214 (prepare_desired_row, line_draw_cost):
9215 Use int, not unsigned, where either works.
9216 (save_current_matrix, restore_current_matrix):
9217 Use ptrdiff_t, not size_t, where either works.
9218 (init_display): Check for overflow more accurately, and without
9219 relying on undefined behavior.
9221 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9222 Remove, replacing with the new symbols in lisp.h. All uses changed.
9223 * fileio.c (make_temp_name):
9224 * filelock.c (lock_file_1, lock_file):
9225 * xdisp.c (message_dolog):
9226 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9227 Use pMd etc. instead.
9228 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9229 replacing the pWIDE etc. symbols removed from editfns.c.
9231 * keyboard.h (num_input_events): Now uintmax_t.
9232 This is (very slightly) less likely to mess up due to wraparound.
9235 * buffer.c: Integer signedness fixes.
9236 (alloc_buffer_text, enlarge_buffer_text):
9237 Use ptrdiff_t rather than size_t when either will do, as we prefer
9240 * alloc.c: Integer signedness and overflow fixes.
9241 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9242 (__malloc_size_t): Default to size_t, not to int.
9243 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9244 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9245 Prefer ptrdiff_t to size_t when either would do, as we prefer
9247 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9248 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9249 Now const. Initialize with values that are in range even if char
9251 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9252 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9253 These functions do the right thing with sizes > 2**32.
9254 (check_depth): Now ptrdiff_t, not int.
9255 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9256 Adjust to new way of storing sizes. Check for size overflow bugs
9258 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9259 slightly wrong anyway, as it missed one instance of
9260 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9261 (refill_memory_reserve): Omit needless cast to size_t.
9262 (mark_object_loop_halt): Mark as externally visible.
9264 * xselect.c: Integer signedness and overflow fixes.
9265 (Fx_register_dnd_atom, x_handle_dnd_message):
9266 Use ptrdiff_t, not size_t, since we prefer signed.
9267 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9268 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9269 x_dnd_atoms_size and x_dnd_atoms_length.
9271 * doprnt.c: Prefer signed to unsigned when either works.
9273 * doprnt.c (doprnt):
9275 * xdisp.c (vmessage):
9276 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9277 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9278 prefer signed arithmetic to avoid comparison confusion.
9279 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9280 but is a bit tricky.
9282 Assume freestanding C89 headers, string.h, stdlib.h.
9283 * data.c, doprnt.c, floatfns.c, print.c:
9284 Include float.h unconditionally.
9285 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9286 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9287 * regex.c: Likewise for stddef.h, string.h.
9288 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9289 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9290 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9291 (STDC_HEADERS): Remove obsolete defines.
9292 * sysdep.c: Include limits.h unconditionally.
9294 Assume support for memcmp, memcpy, memmove, memset.
9295 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9296 * regex.c (memcmp, memcpy):
9297 Remove; we assume C89 now.
9299 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9300 (__malloc_safe_bcopy): Remove; no longer needed.
9302 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
9303 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9304 well either way, and we prefer signed to unsigned.
9306 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9308 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9309 closes the connection while we're reading (bug#9182).
9311 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
9313 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9314 are specified (Bug#9168).
9316 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9318 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9319 Found by GCC static checking and --with-wide-int on a 32-bit host.
9321 2011-07-25 Eli Zaretskii <eliz@gnu.org>
9323 * xdisp.c (compute_display_string_pos): Fix logic of caching
9324 previous display string position. Initialize cached_prev_pos to
9325 -1. Fixes slow-down at the beginning of a buffer.
9327 2011-07-24 Eli Zaretskii <eliz@gnu.org>
9329 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9330 for attrs[LFACE_FONTSET_INDEX].
9332 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9334 * xml.c (parse_region): Remove unused local
9335 that was recently introduced.
9337 2011-07-23 Eli Zaretskii <eliz@gnu.org>
9339 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9340 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9342 * xdisp.c (move_it_in_display_line_to): Record the best matching
9343 position for TO_CHARPOS while scanning the line, and restore it on
9344 exit if none of the characters scanned was an exact match.
9345 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
9346 when exact match is impossible due to invisible text, and the
9347 lines are truncated.
9349 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9351 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9354 2011-07-22 Eli Zaretskii <eliz@gnu.org>
9356 Fix a significant slow-down of cursor motion with C-n, C-p,
9357 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9358 auto-repeat under bidi redisplay in fontified buffers.
9359 * xdisp.c (compute_stop_pos_backwards): New function.
9360 (next_element_from_buffer): Call compute_stop_pos_backwards to
9361 find a suitable prev_stop when we find ourselves before
9363 (reseat): Don't look for prev_stop, as that could mean a very long
9365 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9366 <cached_disp_overlay_modiff>: Cache for last found display string
9368 (compute_display_string_pos): Return the cached position if asked
9369 about the same buffer in the same area of character positions, and
9370 the buffer wasn't changed since the time the display string
9371 position was cached.
9373 2011-07-22 Eli Zaretskii <eliz@gnu.org>
9375 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9376 is an integer, which is important for empty lines. (Bug#9149)
9378 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
9380 * frame.c (Fmodify_frame_parameters): In tty case, update the
9381 default face if necessary (Bug#4238).
9383 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
9385 * editfns.c (Fstring_to_char): No need to explain what a character
9386 is in the docstring (Bug#6576).
9388 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9390 * xml.c (parse_region): Make sure we always return a tree.
9392 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9394 * xml.c (parse_region): If a document contains only comments,
9397 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9399 * xml.c (make_dom): Return comments, too.
9401 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9404 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9405 and the surrounding thread.
9406 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9407 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9408 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9410 * s/openbsd.h (BROKEN_SIGIO): Define.
9411 * unexelf.c (unexec) [__OpenBSD__]:
9412 Don't update the .mdebug section of the Alpha COFF symbol table.
9414 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9416 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9419 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9421 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9422 This fixes some race conditions on the permissions of any newly
9425 * alloc.c (valid_pointer_p): Use pipe, not open.
9426 This fixes some permissions issues when debugging.
9428 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9429 If fchown fails to set both uid and gid, try to set just gid,
9430 as that is sometimes allowed. Adjust the file's mode to eliminate
9431 setuid or setgid bits that are inappropriate if fchown fails.
9433 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9435 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9436 to compare Lisp_Objects.
9437 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9438 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9439 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9441 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9443 * lread.c (read_integer): Unread even EOF character.
9444 (read1): Likewise. Properly record start position of symbol.
9446 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9447 symbol character follows.
9449 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9451 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9452 This works around a problem with the previous change to Fcopy_file.
9453 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9454 and without this change, GCC might complain about discarding
9455 fchown's return value.
9457 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
9459 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9461 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9463 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9465 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9467 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9468 it's used from the C level.
9470 * process.c: Use the same condition for POLL_FOR_INPUT in both
9471 keyboard.c and process.c (bug#1858).
9473 2011-07-09 Lawrence Mitchell <wence@gmx.li>
9475 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9476 (Fgnutls_boot): Use it.
9478 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9480 * doc.c (Fsubstitute_command_keys): Revert last change.
9482 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9484 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9485 quotes the next character, and doesn't affect other longer
9486 sequences (bug#8935).
9488 * lread.c (syms_of_lread): Clarify that is isn't only
9489 `eval-buffer' and `eval-defun' that's affected by
9490 `lexical-binding' (bug#8460).
9492 2011-07-15 Eli Zaretskii <eliz@gnu.org>
9494 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
9495 bidi redisplay when a line includes both an image and is truncated.
9497 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9499 Fix minor problems found by static checking.
9500 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9501 (elsz): Now a signed constant, not a size_t var. We prefer signed
9502 types to unsigned, to avoid integer comparison confusion. Without
9503 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9504 "cannot optimize loop, the loop counter may overflow", a symptom
9506 * indent.c (Fvertical_motion): Mark locals as initialized.
9507 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9509 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9511 * search.c (Fre_search_backward): Mention `case-fold-search' in
9512 all the re_search_* functions (bug#8138).
9514 * keyboard.c (Fopen_dribble_file): Document when the file is
9517 2011-07-14 Eli Zaretskii <eliz@gnu.org>
9519 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9522 Support bidi reordering of display and overlay strings.
9523 * xdisp.c (compute_display_string_pos)
9524 (compute_display_string_end): Accept additional argument STRING.
9525 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9526 (reseat_to_string): Initialize bidi_it->string.s and
9527 bidi_it->string.schars.
9528 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
9529 NULL (avoids a crash in bidi_paragraph_init).
9530 Initialize itb.string.lstring.
9531 (init_iterator): Call bidi_init_it only of a valid
9532 buffer position was specified. Initialize paragraph_embedding to
9534 (reseat_to_string): Initialize the bidi iterator.
9535 (display_string): If we need to ignore text properties of
9536 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9537 original value of -1 will not work with bidi.)
9538 (compute_display_string_pos): First arg is now struct
9539 `text_pos *'; all callers changed. Support display properties on
9541 (compute_display_string_end): Support display properties on Lisp
9543 (init_iterator, reseat_1, reseat_to_string): Initialize the
9544 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9545 when iterating on a string not from display properties).
9546 (compute_display_string_pos, compute_display_string_end):
9547 Fix calculation of the object to scan. Fixes an error when using
9549 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
9550 base_level_stop; instead, set base_level_stop to BEGV.
9551 Fixes crashes in vertical-motion.
9552 (next_element_from_buffer): Improve commentary for when
9553 the iterator is before prev_stop.
9554 (init_iterator): Initialize bidi_p from the default value of
9555 bidi-display-reordering, not from buffer-local value. Use the
9556 buffer-local value only if initializing for buffer iteration.
9557 (handle_invisible_prop): Support invisible properties on strings
9558 that are being bidi-reordered.
9559 (set_iterator_to_next): Support bidi reordering of C strings and
9561 (next_element_from_string): Support bidi reordering of Lisp
9563 (handle_stop_backwards): Support Lisp strings as well.
9564 (display_string): Support display of R2L glyph rows.
9565 Use IT_STRING_CHARPOS when displaying from a Lisp string.
9566 (init_iterator): Don't initialize it->bidi_p for strings
9568 (reseat_to_string): Initialize it->bidi_p for strings here.
9569 (next_element_from_string, next_element_from_c_string)
9570 (next_element_from_buffer): Add xassert's for correspondence
9571 between IT's object being iterated and it->bidi_it.string
9573 (face_before_or_after_it_pos): Support bidi iteration.
9574 (next_element_from_c_string): Handle the case of the first string
9575 character that is not the first one in the visual order.
9576 (get_visually_first_element): New function, refactored from common
9577 parts of next_element_from_buffer, next_element_from_string, and
9578 next_element_from_c_string.
9579 (tool_bar_lines_needed, redisplay_tool_bar)
9580 (display_menu_bar): Force left-to-right direction. Add a FIXME
9581 comment for making that be controlled by a user option.
9582 (push_it, pop_it): Save and restore the state of the
9583 bidi iterator. Save and restore the bidi_p flag.
9584 (pop_it): Iterate out of display property for string iteration as
9586 (iterate_out_of_display_property): Support iteration over strings.
9587 (handle_single_display_spec): Set up it->bidi_it for iteration
9588 over a display string, and call bidi_init_it.
9589 (handle_single_display_spec, next_overlay_string)
9590 (get_overlay_strings_1, push_display_prop): Set up the bidi
9591 iterator for displaying display or overlay strings.
9592 (forward_to_next_line_start): Don't use the shortcut if
9594 (back_to_previous_visible_line_start): If handle_display_prop
9595 pushed the iterator stack, restore the internal state of the bidi
9596 iterator by calling bidi_pop_it same number of times.
9597 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9598 and we are bidi-iterating, don't decrement the iterator position;
9599 instead, set the first_elt flag in the bidi iterator, to produce
9601 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9602 (push_display_prop): xassert that we are iterating a buffer.
9603 (push_it, pop_it): Save and restore paragraph_embedding member.
9604 (handle_single_display_spec, next_overlay_string)
9605 (get_overlay_strings_1, reseat_1, reseat_to_string)
9606 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9607 correctly. Don't assume unibyte strings are not bidi-reordered.
9608 (compute_display_string_pos)
9609 (compute_display_string_end): Fix handling the case of C string.
9610 (push_it, pop_it): Save and restore from_disp_prop_p.
9611 (handle_single_display_spec, push_display_prop): Set the
9612 from_disp_prop_p flag.
9613 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9614 (pop_it): Call iterate_out_of_display_property only if we are
9615 popping after iteration over a string that came from a display
9616 property. Fix a typo in popping stretch info. Add an assertion
9617 for verifying that the iterator position is in sync with the bidi
9619 (handle_single_display_spec, get_overlay_strings_1)
9620 (push_display_prop): Fix initialization of paragraph direction for
9621 string when that of the parent object is not yet determined.
9622 (reseat_1): Call bidi_init_it to resync the bidi
9623 iterator with IT's position. (Bug#7616)
9624 (find_row_edges): If ROW->start.pos gives position
9625 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9626 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9627 Reset the from_disp_prop_p flag.
9628 (SAVE_IT, RESTORE_IT): New macros.
9629 (pos_visible_p, face_before_or_after_it_pos)
9630 (back_to_previous_visible_line_start)
9631 (move_it_in_display_line_to, move_it_in_display_line)
9632 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9633 (try_scrolling, redisplay_window, display_line): Use them when
9634 saving a temporary copy of the iterator and restoring it back.
9635 (back_to_previous_visible_line_start, reseat_1)
9636 (init_iterator): Empty the bidi cache "stack".
9637 (move_it_in_display_line_to): If iterator ended up at
9638 EOL, but we never saw any buffer positions smaller than
9639 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9640 motion in bidi-reordered lines.
9641 (move_it_in_display_line_to): Record prev_method and prev_pos
9642 immediately before the call to set_iterator_to_next. Fixes cursor
9643 motion in bidi-reordered lines with stretch glyphs and strings
9644 displayed in margins. (Bug#8133) (Bug#8867)
9645 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9647 (pos_visible_p): Support positions in bidi-reordered lines.
9648 Save and restore bidi cache.
9650 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9651 (bidi_paragraph_info): Delete unused struct.
9652 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9653 (bidi_cache_start): New variable.
9654 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9656 (bidi_cache_fetch_state, bidi_cache_search)
9657 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9658 (bidi_cache_find, bidi_peek_at_next_level)
9659 (bidi_level_of_next_char, bidi_find_other_level_edge)
9660 (bidi_move_to_visually_next): Compare cache index with
9661 bidi_cache_start rather than with zero.
9662 (bidi_fetch_char): Accept new argument STRING; all callers
9663 changed. Support iteration over a string. Support strings with
9664 display properties. Support unibyte strings. Fix the type of
9665 `len' according to what STRING_CHAR_AND_LENGTH expects.
9666 (bidi_paragraph_init, bidi_resolve_explicit_1)
9667 (bidi_resolve_explicit, bidi_resolve_weak)
9668 (bidi_level_of_next_char, bidi_move_to_visually_next):
9669 Support iteration over a string.
9670 (bidi_set_sor_type, bidi_resolve_explicit_1)
9671 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9672 can now be zero (for strings); special values 0 and -1 were
9673 changed to -1 and -2, respectively.
9674 (bidi_char_at_pos): New function.
9675 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9676 Call it instead of FETCH_MULTIBYTE_CHAR.
9677 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9678 initialized to valid values.
9679 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9681 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9682 the test for valid cached positions. Fix the logic for looking up
9683 the sentinel state in the cache. GCPRO the Lisp string we are
9685 (bidi_push_it, bidi_pop_it): New functions.
9686 (bidi_initialize): Initialize the bidi cache start stack pointer.
9687 (bidi_cache_ensure_space): New function, refactored from part of
9688 bidi_cache_iterator_state. Don't assume the required size is just
9689 one BIDI_CACHE_CHUNK away.
9690 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9691 (bidi_count_bytes, bidi_char_at_pos): New functions.
9692 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9693 always valid if bidi_cache_idx is valid.
9694 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9695 is valid if it's going to be used.
9696 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9697 (bidi_cache_fetch_state, bidi_cache_search)
9698 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9699 (bidi_cache_iterator_state, bidi_cache_find)
9700 (bidi_find_other_level_edge, bidi_cache_start_stack):
9701 All variables related to cache indices are now EMACS_INT.
9703 * dispextern.h (struct bidi_string_data): New structure.
9704 (struct bidi_it): New member `string'. Make flag members be 1-bit
9705 fields, and put them last in the struct.
9706 (compute_display_string_pos, compute_display_string_end):
9708 (bidi_push_it, bidi_pop_it): Add prototypes.
9709 (struct iterator_stack_entry): New members bidi_p,
9710 paragraph_embedding, and from_disp_prop_p.
9711 (struct it): Member bidi_p is now a bit field 1 bit wide.
9712 (bidi_shelve_cache, bidi_unshelve_cache):
9715 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9716 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9717 and vector-like objects.
9719 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9720 cache around display iteration.
9722 * window.c (Fwindow_end, window_scroll_pixel_based)
9723 (displayed_window_lines, Frecenter): Save and restore the bidi
9724 cache around display iteration.
9726 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9728 * editfns.c (Fdelete_region): Clarify the use of the named
9729 parameters (bug#6788).
9731 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9733 * indent.c (Fvertical_motion): Set and restore w->pointm when
9734 saving and restoring the window's buffer (Bug#9006).
9736 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9738 * editfns.c (Fstring_to_char): Clarify just what is returned
9739 (bug#6576). Text by Eli Zaretskii.
9741 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9743 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9745 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9747 * buffer.c (mmap_find): Fix a typo.
9749 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9751 Fix execution of x selection hooks.
9752 * xselect.c (Qx_lost_selection_functions)
9753 (Qx_sent_selection_functions): New vars.
9754 (syms_of_xselect): DEFSYM them.
9755 (x_handle_selection_request): Pass Qx_sent_selection_functions
9756 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9757 (x_handle_selection_clear,x_clear_frame_selections):
9758 Pass Qx_lost_selection_functions rather than
9759 Vx_lost_selection_functions to Frun_hook_with_args.
9761 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9763 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9764 The old code sometimes used this field without initializing it.
9766 * alloc.c (gc_sweep): Don't read past end of array.
9767 In theory, the old code could also have corrupted Emacs internals,
9768 though it'd be very unlikely.
9770 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9772 * character.c (Fcharacterp): Don't advertise optional ignored
9773 argument. (Bug#4026)
9775 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9777 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9780 * window.c (Fset_window_start): Doc fix (bug#4199).
9781 (Fset_window_hscroll): Ditto.
9783 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9785 Fix minor new problems caught by GCC 4.6.1.
9786 * term.c (init_tty): Remove unused local.
9787 * xsettings.c (store_monospaced_changed): Define this function only
9788 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9791 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9793 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9795 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9797 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9798 are the mini-buffer and the echo area (bug#3320).
9800 * term.c (init_tty): Remove support for supdup, c10 and perq
9801 terminals, which are no longer supported (bug#1482).
9803 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9805 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9807 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9809 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9810 for non-popups (Bug#3642).
9812 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9814 * alloc.c (reset_malloc_hooks): Protoize.
9815 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9816 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9817 * cm.c (losecursor): Likewise.
9818 * data.c (fmod): Likewise.
9819 * dispnew.c (swap_glyphs_in_rows): Likewise.
9820 * emacs.c (memory_warning_signal): Likewise.
9821 * floatfns.c (float_error): Likewise.
9822 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9823 (otf_open, font_otf_capability, generate_otf_features)
9824 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9826 * image.c (pbm_read_file): Likewise.
9827 * indent.c (string_display_width): Likewise.
9828 * intervals.c (check_for_interval, search_for_interval)
9829 (inc_interval_count, count_intervals, root_interval)
9830 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9831 * lread.c (defalias): Likewise.
9832 * ralloc.c (r_alloc_check): Likewise.
9833 * regex.c (set_image_of_range_1, set_image_of_range)
9834 (regex_grow_registers): Likewise.
9835 * sysdep.c (strerror): Likewise.
9836 * termcap.c (valid_filename_p, tprint, main): Likewise.
9837 * tparam.c (main): Likewise.
9838 * unexhp9k800.c (run_time_remap, save_data_space)
9839 (update_file_ptrs, read_header, write_header, calculate_checksum)
9840 (copy_file, copy_rest, display_header): Likewise.
9841 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9843 * xdisp.c (check_it): Likewise.
9844 * xfaces.c (register_color, unregister_color, unregister_colors):
9846 * xfns.c (print_fontset_result): Likewise.
9847 * xrdb.c (member, fatal, main): Likewise.
9849 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9851 Fix minor problems found by static checking (Bug#9031).
9852 * chartab.c (char_table_set_range, map_sub_char_table):
9853 Remove unused locals.
9854 (uniprop_table): Now static.
9855 * composite.c (_work_char): Remove unused static var.
9857 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9859 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9861 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9863 * gtkutil.c (qttip_cb): Remove code without function.
9865 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9867 * w32.c (pthread_sigmask): New stub.
9869 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9871 Use pthread_sigmask, not sigprocmask (Bug#9010).
9872 sigprocmask is portable only for single-threaded applications, and
9873 Emacs can be multi-threaded when it uses GTK.
9874 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9876 * callproc.c (Fcall_process):
9877 * process.c (create_process):
9878 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9879 Use pthread_sigmask, not sigprocmask.
9881 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9883 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9884 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9887 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9889 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9890 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9891 (xg_hide_tooltip): Fix comment.
9893 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9894 in registerServicesMenuSendTypes.
9895 (validRequestorForSendType): Don't check ns_return_types.
9897 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9900 2011-07-08 Jason Rumney <jasonr@gnu.org>
9902 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9903 SH_SHOW for hidden windows (Bug#5482).
9905 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9906 frame struct members of non-existent frames (Bug#6284).
9908 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9910 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9911 variable firstTime not needed on OSX >= 10.6.
9912 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9913 >= 10.5. Use setKnobProportion, setDoubleValue.
9915 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9916 (MAC_OS_X_VERSION_10_5): Define if not defined.
9917 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9918 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9919 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9921 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9922 cString and lossyCString on OSX >= 10.4.
9924 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9925 sizeToFit on OSX >= 10.2.
9927 * nsimage.m (allocInitFromFile): Don't use deprecated method
9928 bestRepresentationForDevice on OSX >= 10.6.
9930 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9933 * emacs.c: Declare unexec_init_emacs_zone.
9935 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9937 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9939 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9940 on svcsMenu (Bug#8842).
9942 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9944 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9946 * nsterm.m (QUTF8_STRING): Declare.
9947 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9948 (validRequestorForSendType): Return type is (id).
9949 Change indexOfObjectIdenticalTo to indexOfObject.
9950 Check if we have local selection before returning self (Bug#8842).
9951 (writeSelectionToPasteboard): Put local selection into paste board
9952 if we have a local selection (Bug#8842).
9953 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9955 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9956 (ns_get_local_selection): Declare.
9958 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9960 * keymap.c (describe_map_tree): Don't insert a double newline at
9961 the end of the buffer (bug#1169) and return whether we inserted
9964 * callint.c (Fcall_interactively): Change "reading args" to
9965 "providing args" to try to clarify what it does (bug#1010).
9967 2011-07-07 Kenichi Handa <handa@m17n.org>
9969 * composite.c (composition_compute_stop_pos): Ignore a static
9970 composition starting before CHARPOS (Bug#8915).
9972 * xdisp.c (handle_composition_prop): Likewise.
9974 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9976 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9979 2011-07-07 Kenichi Handa <handa@m17n.org>
9981 * character.h (unicode_category_t): New enum type.
9983 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9984 (Qchar_code_property_table): New variable.
9985 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9986 (UNIPROP_COMPRESSED_FORM_P): New macros.
9987 (char_table_ascii): Uncompress the compressed values.
9988 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9989 Uncompress the compressed values.
9990 (sub_char_table_ref_and_range): Likewise.
9991 (char_table_ref_and_range): Uncompress the compressed values.
9992 (sub_char_table_set): New arg is_uniprop. Callers changed.
9993 Uncompress the compressed values.
9994 (sub_char_table_set_range): Args changed. Callers changed.
9995 (char_table_set_range): Adjuted for the above change.
9996 (map_sub_char_table): Delete args default_val and parent. Add arg
9997 top. Give decoded values to a Lisp function.
9998 (map_char_table): Adjust for the above change. Give decoded
9999 values to a Lisp function. Gcpro more variables.
10000 (uniprop_table_uncompress)
10001 (uniprop_decode_value_run_length): New functions.
10002 (uniprop_decoder, uniprop_decoder_count): New variables.
10003 (uniprop_get_decoder, uniprop_encode_value_character)
10004 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10006 (uniprop_encoder, uniprop_encoder_count): New variables.
10007 (uniprop_get_encoder, uniprop_table)
10008 (Funicode_property_table_internal, Fget_unicode_property_internal)
10009 (Fput_unicode_property_internal): New functions.
10010 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10011 Sunicode_property_table_internal, Sget_unicode_property_internal,
10012 and Sput_unicode_property_internal. Defvar_lisp
10013 char-code-property-alist.
10015 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
10016 Vunicode_category_table.
10018 * font.c (font_range): Adjust for the change of
10019 Vunicode_category_table.
10021 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10023 * m/iris4d.h: Remove file, move contents ...
10024 * s/irix6-5.h: ... here.
10026 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10028 Remove unportable assumption about struct layout (Bug#8884).
10029 * alloc.c (mark_buffer):
10030 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10031 (clone_per_buffer_values): Don't assume that
10032 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10033 This isn't true in general, and it's particularly not true
10034 if Emacs is configured with --with-wide-int.
10035 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10036 New macros, used in the buffer.c change.
10038 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10040 * xsettings.c: Use both GConf and GSettings if both are available.
10041 (store_config_changed_event): Add comment.
10042 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10043 (store_tool_bar_style_changed): New functions.
10044 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
10045 (struct xsettings): Move font inside HAVE_XFT.
10046 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
10047 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
10048 Move inside HAVE_XFT.
10049 (something_changed_gsettingsCB): Rename from something_changedCB.
10050 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10052 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
10053 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
10054 (something_changed_gconfCB): Rename from something_changedCB.
10055 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10056 (parse_settings): Move check for font inside HAVE_XFT.
10057 (read_settings, apply_xft_settings): Add comment.
10058 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10059 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10060 call store_font_name_changed.
10061 (xft_settings_event): Add comment.
10062 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10063 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10064 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10065 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10066 (xsettings_initialize): Call init_gsettings last.
10067 (xsettings_get_system_font, xsettings_get_system_normal_font):
10070 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10072 Random fixes. E.g., (random) never returned negative values.
10073 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10074 subseconds part to the entropy, as that's a bit more random.
10075 Prefer signed to unsigned, since the signedness doesn't matter and
10076 in general we prefer signed. When given a limit, use a
10077 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10078 latter isn't right if USE_2_TAGS_FOR_INTS.
10079 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10080 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10082 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10084 * textprop.c (text_property_stickiness):
10085 Obey Vtext_property_default_nonsticky.
10086 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10087 * w32fns.c (syms_of_w32fns):
10088 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10090 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10092 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10093 This is more efficient than Ffile_directory_p and avoids a minor race.
10095 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10097 * buffer.c (Foverlay_put): Say what the return value is
10100 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10101 is a directory before asking whether to use the file name
10103 (barf_or_query_if_file_exists): Make the "File is a directory"
10104 error be more correct.
10106 * fns.c (Frequire): Remove the mention of the .gz files, since
10107 that's installation-specific, but keep the mention of
10108 `get-load-suffixes'.
10110 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10112 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10113 Report string overflow if the output is too long.
10115 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
10117 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10118 (syms_of_gnutls): Remove duplicate DEFSYM for
10119 Qgnutls_bootprop_verify_hostname_error, an error for
10120 Qgnutls_bootprop_verify_error (which is no longer used).
10122 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10123 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10124 Also (re)move comments that are misplaced or no longer relevant.
10126 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10128 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10130 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
10132 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10133 and background color parameters if they have been changed.
10135 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10137 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10139 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10141 * xsettings.c (SYSTEM_FONT): Define only when used.
10142 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10144 * keymap.c (access_keymap_1): Now static.
10146 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
10148 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10149 leave any prefix arg for the up event (Bug#1586).
10151 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10153 * lread.c (syms_of_lread): Mention single symbols defined by
10154 `defvar' or `defconst' (bug#7154).
10156 * fns.c (Frequire): Mention .el.gz files (bug#7314).
10157 (Frequire): Mention get-load-suffixes.
10159 2011-07-02 Martin Rudalics <rudalics@gmx.at>
10161 * window.h (window): Remove clone_number slot.
10162 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10164 (make_parent_window, make_window, saved_window)
10165 (Fset_window_configuration, save_window_save): Don't deal with
10167 * buffer.c (Qclone_number): Remove declaration.
10168 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10170 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10172 Add multiple inheritance to keymaps.
10173 * keymap.c (Fmake_composed_keymap): New function.
10174 (Fset_keymap_parent): Simplify.
10175 (fix_submap_inheritance): Remove.
10176 (access_keymap_1): New function extracted from access_keymap to handle
10177 embedded parents and handle lists of maps.
10178 (access_keymap): Use it.
10179 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10180 (Fcopy_keymap): Handle embedded parents.
10181 (Fcommand_remapping, define_as_prefix): Simplify.
10182 (Fkey_binding): Simplify.
10183 (syms_of_keymap): Move minibuffer-local-completion-map,
10184 minibuffer-local-filename-completion-map,
10185 minibuffer-local-must-match-map, and
10186 minibuffer-local-filename-must-match-map to Elisp.
10187 (syms_of_keymap): Defsubr make-composed-keymap.
10188 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10189 (parse_menu_item): Trivial simplification.
10191 2011-07-01 Glenn Morris <rgm@gnu.org>
10193 * Makefile.in (SETTINGS_LIBS): Fix typo.
10195 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10197 * coding.c (Fencode_coding_string): Record the last coding system
10198 used, as the function doc string says (bug#8738).
10200 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10202 * xsettings.c (store_monospaced_changed): Take new font as arg and
10203 check for change against current_mono_font.
10204 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10205 (emacs_settings_constructor, emacs_settings_get_property)
10206 (emacs_settings_set_property, emacs_settings_class_init)
10207 (emacs_settings_init, gsettings_obj): Remove.
10208 (something_changedCB): New function for HAVE_GSETTINGS.
10209 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10210 with value as argument.
10211 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10212 g_settings_new (Bug#8967). Do not create gsettings_obj.
10213 Remove calls to g_settings_bind. Connect something_changedCB to
10216 * xgselect.c: Add defined (HAVE_GSETTINGS).
10217 (xgselect_initialize): Ditto.
10219 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10220 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10223 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10225 * eval.c (struct backtrace): Simplify and port the data structure.
10226 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10227 signed bit field, as this assumption is not portable and it makes
10228 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10229 "char debug_on_exit : 1" as this is not portable either; instead,
10230 use the portable "unsigned int debug_on_exit : 1". Remove unused
10231 member evalargs. Remove obsolete comments about cc bombing out.
10233 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10235 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
10236 Let HAVE_GSETTINGS override HAVE_GCONF.
10237 (store_monospaced_changed): New function.
10238 (EMACS_SETTINGS): A new type derived from GObject to handle
10239 GSettings notifications.
10240 (emacs_settings_constructor, emacs_settings_get_property)
10241 (emacs_settings_set_property, emacs_settings_class_init):
10243 (gsettings_client, gsettings_obj): New variables.
10244 (GSETTINGS_SCHEMA): New define.
10245 (something_changedCB): Call store_monospaced_changed.
10246 (init_gsettings): New function.
10247 (xsettings_initialize): Call init_gsettings.
10248 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10251 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
10254 2011-06-29 Martin Rudalics <rudalics@gmx.at>
10256 * window.c (resize_root_window, grow_mini_window)
10257 (shrink_mini_window): Rename Qresize_root_window to
10258 Qwindow_resize_root_window and Qresize_root_window_vertically to
10259 Qwindow_resize_root_window_vertically.
10261 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10263 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10265 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
10267 * makefile.w32-in: Redesign dependencies so they reflect more
10268 clearly which files are directly included by each source file,
10269 and not through other includes.
10271 2011-06-27 Martin Rudalics <rudalics@gmx.at>
10273 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10274 (sort_overlays, overlay_strings): When an overlay's clone number
10275 matches the window's clone number process the overlay even if
10276 the overlay's window property doesn't match the current window.
10278 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10279 (Fwindow_hchild): Rename to Fwindow_left_child.
10280 (Fwindow_next): Rename to Fwindow_next_sibling.
10281 (Fwindow_prev): Rename to Fwindow_prev_sibling.
10282 (resize_window_check): Rename to window_resize_check.
10283 (resize_window_apply): Rename to window_resize_apply.
10284 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10285 (Fdelete_other_windows_internal, resize_frame_windows)
10286 (Fsplit_window_internal, Fdelete_window_internal)
10287 (grow_mini_window, shrink_mini_window)
10288 (Fresize_mini_window_internal): Fix callers accordingly.
10290 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10292 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10293 (emacs_fixed_set_min_size): Remove.
10294 (emacs_fixed_new): Take frame as argument.
10296 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10297 (_EmacsFixedPrivate): Remove minwidth/height.
10298 Add struct frame *f.
10299 (emacs_fixed_init): Initialize priv->f.
10300 (get_parent_class, emacs_fixed_set_min_size): Remove.
10301 (emacs_fixed_new): Set priv->f to argument.
10302 (emacs_fixed_get_preferred_width)
10303 (emacs_fixed_get_preferred_height): Use min_width/height from
10304 frames size_hint to set minimum and natural (Bug#8919).
10305 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10306 and use min_width/height from frames size_hint to set
10307 min_width/height (Bug#8919).
10309 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
10310 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10313 2011-06-26 Eli Zaretskii <eliz@gnu.org>
10315 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10316 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10319 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
10321 * process.c (wait_reading_process_output): Bypass select if
10322 waiting for a cell while ignoring keyboard input, and input is
10323 pending. Suggested by Jan Djärv (Bug#8869).
10325 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10327 Use gnulib's dup2 module instead of rolling our own.
10328 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10330 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10332 * dispnew.c (scrolling_window): Before scrolling, turn off a
10333 mouse-highlight in the window being scrolled.
10335 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
10337 Move DEFSYM to lisp.h and use everywhere.
10339 * character.h (DEFSYM): Move declaration...
10340 * lisp.h (DEFSYM): ...here.
10346 * w32select.c: Don't include character.h.
10348 * alloc.c (syms_of_alloc):
10349 * buffer.c (syms_of_buffer):
10350 * bytecode.c (syms_of_bytecode):
10351 * callint.c (syms_of_callint):
10352 * casefiddle.c (syms_of_casefiddle):
10353 * casetab.c (init_casetab_once):
10354 * category.c (init_category_once, syms_of_category):
10355 * ccl.c (syms_of_ccl):
10356 * cmds.c (syms_of_cmds):
10357 * composite.c (syms_of_composite):
10358 * dbusbind.c (syms_of_dbusbind):
10359 * dired.c (syms_of_dired):
10360 * dispnew.c (syms_of_display):
10361 * doc.c (syms_of_doc):
10362 * editfns.c (syms_of_editfns):
10363 * emacs.c (syms_of_emacs):
10364 * eval.c (syms_of_eval):
10365 * fileio.c (syms_of_fileio):
10366 * fns.c (syms_of_fns):
10367 * frame.c (syms_of_frame):
10368 * fringe.c (syms_of_fringe):
10369 * insdel.c (syms_of_insdel):
10370 * keymap.c (syms_of_keymap):
10371 * lread.c (init_obarray, syms_of_lread):
10372 * macros.c (syms_of_macros):
10373 * msdos.c (syms_of_msdos):
10374 * print.c (syms_of_print):
10375 * process.c (syms_of_process):
10376 * search.c (syms_of_search):
10377 * sound.c (syms_of_sound):
10378 * syntax.c (init_syntax_once, syms_of_syntax):
10379 * terminal.c (syms_of_terminal):
10380 * textprop.c (syms_of_textprop):
10381 * undo.c (syms_of_undo):
10382 * w32.c (globals_of_w32):
10383 * window.c (syms_of_window):
10384 * xdisp.c (syms_of_xdisp):
10385 * xfaces.c (syms_of_xfaces):
10386 * xfns.c (syms_of_xfns):
10387 * xmenu.c (syms_of_xmenu):
10388 * xsettings.c (syms_of_xsettings):
10389 * xterm.c (syms_of_xterm): Use DEFSYM.
10391 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10393 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
10395 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10397 Integer and buffer overflow fixes (Bug#8873).
10399 * print.c (printchar, strout): Check for string overflow.
10400 (PRINTPREPARE, printchar, strout):
10401 Don't set size unless allocation succeeds.
10403 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10404 for sizes. Check for string overflow more accurately.
10405 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10407 * macros.c: Integer and buffer overflow fixes.
10408 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10409 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10410 Use ptrdiff_t, not int, for sizes.
10411 Don't increment bufsize until after realloc succeeds.
10412 Check for size-calculation overflow.
10413 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10415 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10417 * lread.c: Integer overflow fixes.
10418 (read_integer): Radix is now EMACS_INT, not int,
10419 to improve quality of diagnostics for out-of-range radices.
10420 Calculate buffer size correctly for out-of-range radices.
10421 (read1): Check for integer overflow in radices, and in
10422 read-circle numbers.
10423 (read_escape): Avoid int overflow.
10424 (Fload, openp, read_buffer_size, read1)
10425 (substitute_object_recurse, read_vector, read_list, map_obarray):
10426 Use ptrdiff_t, not int, for sizes.
10427 (read1): Use EMACS_INT, not int, for sizes.
10428 Check for size overflow.
10430 * image.c (cache_image): Check for size arithmetic overflow.
10432 * lread.c: Integer overflow issues.
10433 (saved_doc_string_size, saved_doc_string_length)
10434 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10435 Now ptrdiff_t, not int.
10436 (read1): Don't assume doc string length fits in int. Check for
10437 out-of-range doc string lengths.
10438 (read_list): Don't assume file position fits in int.
10439 (read_escape): Check for hex character overflow.
10441 2011-06-22 Leo Liu <sdl.web@gmail.com>
10443 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10444 Move to minibuffer.el.
10446 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10448 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
10449 The following patches are for when GLYPH_DEBUG && !XASSERT.
10450 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10451 * dispnew.c (flush_stdout):
10452 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10453 Mark as externally visible.
10454 * dispnew.c (check_window_matrix_pointers): Now static.
10455 * dispnew.c (window_to_frame_vpos):
10456 * xfns.c (unwind_create_frame):
10457 * xterm.c (x_check_font): Remove unused local.
10458 * scroll.c (CHECK_BOUNDS):
10459 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10460 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10461 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10462 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10463 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10465 (debug_method_add): Use va_list and vsprintf rather than relying
10466 on undefined behavior with wrong number of arguments.
10467 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10468 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10469 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10470 since we're not interested in debugging glyphs with old libraries.
10471 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10472 GCC 4.6.0's static checking.
10474 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10476 Integer overflow and signedness fixes (Bug#8873).
10477 A few related buffer overrun fixes, too.
10479 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10481 * dispextern.h (struct face.stipple):
10482 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10483 (x_bitmap_mask, x_allocate_bitmap_record)
10484 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10485 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10486 (x_create_bitmap_from_xpm_data):
10487 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10488 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10490 * xfaces.c (load_pixmap):
10491 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10492 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10493 (.bitmaps_last, struct x_output.icon_bitmap):
10494 Use ptrdiff_t, not int, for bitmap indexes.
10495 (x_allocate_bitmap_record): Check for size overflow.
10496 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10498 Use ptrdiff_t, not int, for overlay counts.
10499 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10500 * editfns.c (overlays_around, get_pos_property):
10501 * textprop.c (get_char_property_and_overlay):
10502 * xdisp.c (next_overlay_change, note_mouse_highlight):
10503 * xfaces.c (face_at_buffer_position):
10504 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10505 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10506 (Fnext_overlay_change, Fprevious_overlay_change)
10507 (mouse_face_overlay_overlaps, Foverlays_in):
10508 Use ptrdiff_t, not int, for sizes.
10509 (overlays_at, overlays_in): Check for size-calculation overflow.
10511 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10513 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10514 (x_session_initialize): Do not assume string length fits in int.
10516 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10517 This is unlikely, but can occur if DPI is outlandish.
10519 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
10520 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10522 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10523 * xrdb.c (magic_file_p, search_magic_path):
10524 Omit last arg SUFFIX; it was always 0. All callers changed.
10525 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10527 * xfont.c (xfont_match): Avoid need for strlen.
10529 * xfns.c: Don't assume strlen fits in int.
10530 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10532 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10533 not unsigned long, as we prefer signed integers. All callers changed.
10534 Detect integer overflow in repeat count.
10535 (message_dolog): Don't assume print length fits in 39 bytes.
10536 (display_mode_element): Don't assume strlen fits in int.
10538 * termcap.c: Don't assume sizes fit in int and never overflow.
10539 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10540 (gobble_line): Check for size-calculation overflow.
10542 * minibuf.c (Fread_buffer):
10543 * lread.c (intern, intern_c_string):
10544 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10545 Don't assume string length fits in int.
10547 * keyboard.c (parse_tool_bar_item):
10548 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10550 * font.c: Don't assume string length fits in int.
10551 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10552 Use ptrdiff_t, not int.
10553 (font_intern_prop): Don't assume string length fits in int.
10554 Don't assume integer property fits in fixnum.
10555 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
10557 * filelock.c: Fix some buffer overrun and integer overflow issues.
10558 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
10559 Reformulate so as not to need the command string.
10560 Invoke gzip -cd rather than gunzip, as it's more portable.
10561 (lock_info_type, lock_file_1, lock_file):
10562 Don't assume pid_t and time_t fit in unsigned long.
10563 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10564 (current_lock_owner): Prefer signed type for sizes.
10565 Use memcpy, not strncpy, where memcpy is what is really wanted.
10566 Don't assume (via atoi) that time_t and pid_t fit in int.
10567 Check for time_t and/or pid_t out of range, e.g., via a network share.
10568 Don't alloca where an auto var works fine.
10570 * fileio.c: Fix some integer overflow issues.
10571 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10572 Don't assume string length fits in int.
10573 (directory_file_name): Don't assume string length fits in long.
10574 (make_temp_name): Don't assume pid fits in int, or that its print
10575 length is less than 20.
10577 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10579 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10581 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10583 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10584 We prefer signed integers, even for size calculations.
10586 * emacs.c: Don't assume string length fits in 'int'.
10587 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10588 (main): Don't invoke strlen when not needed.
10590 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10591 (XD_DEBUG_MESSAGE): Don't waste a byte.
10593 * callproc.c (getenv_internal_1, getenv_internal)
10594 (Fgetenv_internal):
10595 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10597 * lread.c (invalid_syntax): Omit length argument.
10598 All uses changed. This doesn't fix a bug, but it simplifies the
10599 code away from its former Hollerith-constant appearance, and it's
10600 one less 'int' to worry about when looking at integer-overflow issues.
10601 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10603 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10604 This didn't break anything, but it didn't help either.
10605 It's confusing to put a bogus integer in a place where the actual
10606 value does not matter.
10607 (LIST_END_P): Remove unused macro and its bogus comment.
10608 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10610 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10611 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10613 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10614 We prefer signed types, and the value cannot exceed the EMACS_INT
10615 range anyway (because otherwise the length would not be representable).
10616 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10617 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10618 This avoids a GCC warning when WIDE_EMACS_INT.
10620 * indent.c (sane_tab_width): New function.
10621 (current_column, scan_for_column, Findent_to, position_indentation)
10622 (compute_motion): Use it. This is just for clarity.
10623 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10625 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10627 * lisp.h (lint_assume): New macro.
10628 * composite.c (composition_gstring_put_cache):
10629 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10631 * editfns.c, insdel.c:
10632 Omit unnecessary forward decls, to simplify future changes.
10634 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10636 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10638 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10639 Use much-faster test for byte-length change.
10640 Don't assume string byte-length fits in 'int'.
10641 Check that character arg fits in 'int'.
10642 (mapcar1): Declare byte as byte, for clarity.
10644 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10646 * fns.c (concat): Catch string overflow earlier.
10647 Do not rely on integer wraparound.
10649 * dispextern.h (struct it.overlay_strings_charpos)
10650 (struct it.selective): Now EMACS_INT, not int.
10651 * xdisp.c (forward_to_next_line_start)
10652 (back_to_previous_visible_line_start)
10653 (reseat_at_next_visible_line_start, next_element_from_buffer):
10654 Don't arbitrarily truncate the value of 'selective' to int.
10656 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10658 * composite.c: Don't truncate sizes to 'int'.
10659 (composition_gstring_p, composition_reseat_it)
10660 (composition_adjust_point): Use EMACS_INT, not int.
10661 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10662 not EMACS_UINT, for indexes.
10664 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10666 * buffer.c: Include <verify.h>.
10667 (struct sortvec.priority, struct sortstr.priority):
10668 Now EMACS_INT, not int.
10669 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10670 (struct sortstr.size, record_overlay_string)
10671 (struct sortstrlist.size, struct sortlist.used):
10672 Don't truncate size to int.
10673 (record_overlay_string): Check for size-calculation overflow.
10674 (init_buffer_once): Check at compile-time, not run-time.
10676 2011-06-22 Jim Meyering <meyering@redhat.com>
10678 Don't leak an XBM-image-sized buffer
10679 * image.c (xbm_load): Free the image buffer after using it.
10681 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10684 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10685 that Sun C diagnosed.
10686 * fns.c (secure_hash): Fix pointer signedness issue.
10687 * intervals.c (static_offset_intervals): New function.
10688 (offset_intervals): Use it.
10690 2011-06-21 Leo Liu <sdl.web@gmail.com>
10693 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10696 * fns.c (secure_hash): Rename from crypto_hash_function and change
10697 the first arg to accept symbols.
10698 (Fsecure_hash): New primitive.
10699 (syms_of_fns): New symbols.
10701 2011-06-20 Deniz Dogan <deniz@dogan.se>
10703 * process.c (Fset_process_buffer): Clarify return value in
10706 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10708 * dispnew.c (add_window_display_history): Use BVAR.
10710 * xdisp.c (debug_method_add): Use BVAR.
10711 (check_window_end, dump_glyph_matrix, dump_glyph)
10712 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10714 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10717 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10718 check till after the cache is created in init_frame_faces.
10720 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10722 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10724 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10726 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10727 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10728 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10730 Improve buffer-overflow checking (Bug#8873).
10731 * fileio.c (Finsert_file_contents):
10732 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10733 Remove the old (too-loose) buffer overflow checks.
10734 They weren't needed, since make_gap checks for buffer overflow.
10735 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10736 The old code merely checked for Emacs fixnum overflow, and relied
10737 on undefined (wraparound) behavior. The new code avoids undefined
10738 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10740 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10741 Tune. Don't use wider integers than needed. Don't use alloca.
10742 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10744 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10746 * insdel.c, lisp.h (buffer_overflow): New function.
10747 (insert_from_buffer_1, replace_range, replace_range_2):
10748 * insdel.c (make_gap_larger):
10749 * editfns.c (Finsert_char):
10750 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10752 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10754 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10756 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10758 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10759 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10761 * fileio.c: Don't assume EMACS_INT fits in off_t.
10762 (emacs_lseek): New static function.
10763 (Finsert_file_contents, Fwrite_region): Use it.
10764 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10766 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10768 * fns.c: Don't overflow int when computing a list length.
10769 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10770 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10771 truncation on 64-bit hosts. Check for QUIT every
10772 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10773 faster and is responsive enough.
10774 (Flength): Report an error instead of overflowing an integer.
10775 (Fsafe_length): Return a float if the value is not representable
10776 as a fixnum. This shouldn't happen except in contrived situations.
10777 (Fnthcdr, Fsort): Don't assume list length fits in int.
10778 (Fcopy_sequence): Don't assume vector length fits in int.
10780 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10781 (header_size, word_size): New constants.
10782 (allocate_vectorlike): Don't check size overflow here.
10783 (allocate_vector): Check it here instead, since this is the only
10784 caller of allocate_vectorlike that could cause overflow.
10785 Check that the new vector's length is representable as a fixnum.
10787 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10788 The previous code was bogus. For example, next_almost_prime (32)
10789 returned 39, which is undesirable as it is a multiple of 3; and
10790 next_almost_prime (24) returned 25, which is a multiple of 5 so
10791 why was the code bothering to check for multiples of 7?
10793 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10795 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10797 Variadic C functions now count arguments with ptrdiff_t.
10798 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10799 Back then I didn't know that the Emacs coding style prefers signed int.
10800 Also, in the meantime I found a few more instances where arguments
10801 were being counted with int, which may truncate counts on 64-bit
10802 machines, or EMACS_INT, which may be unnecessarily wide.
10803 * lisp.h (struct Lisp_Subr.function.aMANY)
10804 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10805 Arg counts are now ptrdiff_t, not size_t.
10806 All variadic functions and their callers changed accordingly.
10807 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10808 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10809 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10810 * callint.c (Fcall_interactively): Check arg count for overflow,
10811 to avoid potential buffer overrun. Use signed char, not 'int',
10812 for 'varies' array, so that we needn't bother to check its size
10813 calculation for overflow.
10814 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10815 * eval.c (apply_lambda):
10816 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10817 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10818 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10820 * callint.c (Fcall_interactively): Don't use index var as event count.
10822 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10823 * mem-limits.h (SIZE): Remove; no longer used.
10825 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10827 Remove unnecessary casts.
10828 * xterm.c (x_term_init):
10829 * xfns.c (x_set_border_pixel):
10830 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10831 These aren't needed now that we assume ANSI C.
10833 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10834 It's more likely to cause problems (due to unsigned overflow)
10837 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10839 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10841 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10843 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10845 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10847 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10849 GLYPH_CODE_FACE returns EMACS_INT, not int.
10850 * dispextern.h (merge_faces):
10851 * xfaces.c (merge_faces):
10852 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10853 Don't assume EMACS_INT fits in int.
10855 * character.h (CHAR_VALID_P): Remove unused parameter.
10856 * fontset.c, lisp.h, xdisp.c: All uses changed.
10858 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10860 * fns.c (concat): Minor tuning based on overflow analysis.
10861 This doesn't fix any bugs. Use int to hold character, instead
10862 of constantly refetching from Emacs object. Use XFASTINT, not
10863 XINT, for value known to be a character. Don't bother comparing
10864 a single byte to 0400, as it's always less.
10866 * floatfns.c (Fexpt):
10867 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10869 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10872 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10874 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10875 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10876 incorrectly succeed when S was a string, because 4294967386 was
10877 truncated before it was used.
10879 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10880 Otherwise, an out-of-range integer could cause undefined behavior
10883 * composite.c: Use int, not EMACS_INT, for characters.
10884 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10885 EMACS_INT, for values that are known to be in character range.
10886 This doesn't fix any bugs but is the usual style inside Emacs and
10887 may generate better code on 32-bit machines.
10889 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10890 This is for reasons similar to the recent CHAR_STRING fix.
10891 * charset.c (Fencode_char): Check that character arg is actually
10892 a character. Pass an int to ENCODE_CHAR.
10893 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10894 wider than 'int', as a compile-time check to prevent future regressions
10897 * character.c (char_string): Remove unnecessary casts.
10899 Make sure a 64-bit char is never passed to CHAR_STRING.
10900 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10901 by silently ignoring the top 32 bits, allowing some values
10902 that were far too large to be valid characters.
10903 * character.h: Include <verify.h>.
10904 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10905 arguments are no wider than unsigned, as a compile-time check
10906 to prevent future regressions in this area.
10908 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10909 (Fsubst_char_in_region):
10911 * xdisp.c (decode_mode_spec_coding):
10912 Adjust to CHAR_STRING's new requirement.
10913 * editfns.c (Finsert_char, Fsubst_char_in_region):
10914 * fns.c (concat): Check that character args are actually
10915 characters. Without this test, these functions did the wrong
10916 thing with wildly out-of-range values on 64-bit hosts.
10918 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10919 These casts should not be needed on 32-bit hosts, either.
10920 * keyboard.c (read_char):
10921 * lread.c (Fload): Remove casts to unsigned.
10923 * lisp.h (UNSIGNED_CMP): New macro.
10924 This fixes comparison bugs on 64-bit hosts.
10925 (ASCII_CHAR_P): Use it.
10926 * casefiddle.c (casify_object):
10927 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10928 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10929 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10930 * dispextern.h (FACE_FROM_ID):
10931 * keyboard.c (read_char): Use UNSIGNED_CMP.
10933 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10934 not to EMACS_INT, to avoid GCC warning.
10936 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10938 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10939 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10940 isn't needed on 32-bit machines.
10942 * buffer.c (Fgenerate_new_buffer_name):
10943 Use EMACS_INT for count, not int.
10944 (advance_to_char_boundary): Return EMACS_INT, not int.
10946 * data.c (Qcompiled_function): Now static.
10948 * window.c (window_body_lines): Now static.
10950 * image.c (gif_load): Rename local to avoid shadowing.
10952 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10953 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10954 * alloc.c (make_save_value): Integer argument is now of type
10955 ptrdiff_t, not int.
10956 (mark_object): Use ptrdiff_t, not int.
10957 * lisp.h (pD): New macro.
10958 * print.c (print_object): Use it.
10960 * alloc.c: Use EMACS_INT, not int, to count objects.
10961 (total_conses, total_markers, total_symbols, total_vector_size)
10962 (total_free_conses, total_free_markers, total_free_symbols)
10963 (total_free_floats, total_floats, total_free_intervals)
10964 (total_intervals, total_strings, total_free_strings):
10965 Now EMACS_INT, not int. All uses changed.
10966 (Fgarbage_collect): Compute overall total using a double, so that
10967 integer overflow is less likely to be a problem. Check for overflow
10968 when converting back to an integer.
10969 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10970 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10971 These were 'int' variables that could overflow on 64-bit hosts;
10972 they were never used, so remove them instead of repairing them.
10973 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10974 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10975 Previously, this ceilinged at INT_MAX, but that doesn't work on
10977 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10979 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10980 (allocate_vectorlike): Check for ptrdiff_t overflow.
10981 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10982 when a (possibly-narrower) signed value would do just as well.
10983 We prefer using signed arithmetic, to avoid comparison confusion.
10985 * alloc.c: Catch some string size overflows that we were missing.
10986 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10987 for convenience in STRING_BYTES_MAX.
10988 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10989 The definition here is exact; the one in lisp.h was approximate.
10990 (allocate_string_data): Check for string overflow. This catches
10991 some instances we weren't catching before. Also, it catches
10992 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10993 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10994 and ptrdiff_t and EMACS_INT are both 64 bits.
10996 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10997 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10998 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
11000 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11002 * alloc.c (Fmake_string): Check for out-of-range init.
11004 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11006 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11008 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11010 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11011 xg_get_default_scrollbar_width.
11013 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11014 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11015 (style_changed_cb): Call update_theme_scrollbar_width and call
11016 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11017 all frames (Bug#8505).
11018 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11019 Call gtk_window_set_resizable if HAVE_GTK3.
11020 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11021 and height if HAVE_GTK3 (Bug#8505).
11022 (scroll_bar_width_for_theme): New variable.
11023 (update_theme_scrollbar_width): New function.
11024 (xg_get_default_scrollbar_width): Move code to
11025 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11026 (xg_initialize): Call update_theme_scrollbar_width.
11028 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11030 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11032 2011-06-12 Martin Rudalics <rudalics@gmx.at>
11034 * frame.c (make_frame): Call other_buffer_safely instead of
11037 * window.c (temp_output_buffer_show): Call display_buffer with
11038 second argument Vtemp_buffer_show_specifiers and reset latter
11039 immediately after the call.
11040 (Vtemp_buffer_show_specifiers): New variable.
11041 (auto_window_vscroll_p, next_screen_context_lines)
11042 (Vscroll_preserve_screen_position): Remove leading asterisks from
11045 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
11047 Fix minor problems found by GCC 4.6.0 static checking.
11048 * buffer.c (Qclone_number): Remove for now, as it's unused.
11049 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11050 (record_buffer): Remove unused local.
11051 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11052 (set_frame_buffer_list): Remove; unused.
11053 * frame.h (other_visible_frames): Remove decl.
11054 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11055 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11056 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11058 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11059 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11060 Define only if HAVE_GPM.
11061 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11062 (update_hints_inhibit): Remove; never set. All uses removed.
11063 * widgetprv.h (emacsFrameClassRec): Remove decl.
11064 * window.c (delete_deletable_window): Now returns void, since it
11065 wasn't returning anything.
11066 (compare_window_configurations): Remove unused locals.
11067 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11068 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
11069 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11070 the same widths as pointers. This follows up on the 2011-05-06 patch.
11071 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11072 * xterm.h: Likewise.
11073 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11075 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
11077 * makefile.w32-in: Update dependencies.
11078 (LISP_H): Add lib/intprops.h.
11080 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
11082 * image.c (gif_load): Add animation frame delay to the metadata.
11083 (syms_of_image): Use DEFSYM. New symbol `delay'.
11085 2011-06-11 Martin Rudalics <rudalics@gmx.at>
11087 * window.c (delete_deletable_window): Re-add.
11088 (Fset_window_configuration): Rewrite to handle dead buffers and
11089 consequently deletable windows.
11090 (window_tree, Fwindow_tree): Remove. Supply functionality in
11092 (compare_window_configurations): Simplify code.
11094 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11096 * image.c (imagemagick_load_image): Fix type mismatch.
11097 (Fimagemagick_types): Likewise.
11099 * window.h (replace_buffer_in_windows): Declare.
11101 2011-06-11 Martin Rudalics <rudalics@gmx.at>
11103 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11104 Qclone_number. Remove external declaration of Qdelete_window.
11105 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11107 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11108 Run Qbuffer_list_update_hook if allowed.
11109 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11110 buffer list implementation.
11111 (other_buffer_safely): New function.
11112 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11113 calls to replace_buffer_in_windows and
11114 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11116 (record_buffer): Inhibit quitting and rewrite using quittable
11117 functions. Run Qbuffer_list_update_hook if allowed.
11118 (Frecord_buffer, Funrecord_buffer): New functions.
11119 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11120 Move switch-to-buffer to window.el.
11121 (bury-buffer): Move to window.el.
11122 (Vbuffer_list_update_hook): New variable.
11124 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11127 * window.h (resize_frame_windows): Move up in code.
11128 (Fwindow_frame): Remove EXFUN.
11129 (replace_buffer_in_all_windows): Remove prototype.
11130 (replace_buffer_in_windows_safely): Add prototype.
11132 * window.c: Declare Qdelete_window static again. Move down
11133 declaration of select_count.
11134 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11135 (Fother_window): Move to window.el.
11136 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11137 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11138 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11140 (replace_buffer_in_windows): Implement by calling
11141 Qreplace_buffer_in_windows.
11142 (replace_buffer_in_all_windows): Remove with some functionality
11143 moved into replace_buffer_in_windows_safely.
11144 (replace_buffer_in_windows_safely): New function.
11145 (select_window_norecord, select_frame_norecord): Move in front
11146 of run_window_configuration_change_hook. Remove now obsolete
11148 (Fset_window_buffer): Rewrite doc-string.
11149 Call Qrecord_window_buffer.
11150 (keys_of_window): Move binding for other-window to window.el.
11152 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
11154 * dispextern.h (struct image): Replace data member, whose int_val
11155 and ptr_val fields were not used by anything, with a single
11158 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11159 (gif_clear_image, gif_load, imagemagick_load_image)
11160 (gs_clear_image, gs_load): Callers changed.
11162 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11164 * buffer.h: Include <time.h>, for time_t.
11165 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11167 Fix minor problems found by static checking.
11169 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11171 Make identifiers static if they are not used in other modules.
11172 * data.c (Qcompiled_function, Qframe, Qvector):
11173 * image.c (QimageMagick, Qsvg):
11174 * minibuf.c (Qmetadata):
11175 * window.c (resize_window_check, resize_root_window): Now static.
11176 * window.h (resize_window_check, resize_root_window): Remove decls.
11178 * window.c (window_deletion_count, delete_deletable_window):
11180 (window_body_lines): Now static.
11181 (Fdelete_other_windows_internal): Mark vars as initialized.
11182 Make sure 'resize_failed' is initialized.
11183 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11184 (resize_window_apply): Remove unused local.
11185 * window.h (delete_deletable_window): Remove decl.
11187 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
11188 (imagemagick_load_image): Fix pointer signedness problem by changing
11189 last arg from unsigned char * to char *. All uses changed.
11190 Also, fix a local for similar reasons.
11191 Remove unused locals. Remove locals to avoid shadowing.
11192 (fn_rsvg_handle_free): Remove; unused.
11193 (svg_load, svg_load_image): Fix pointer signedness problem.
11194 (imagemagick_load_image): Don't use garbage pointer image_wand.
11196 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11198 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
11200 * image.c (gif_load): Fix omitted cast error introduced by
11203 2011-06-10 Martin Rudalics <rudalics@gmx.at>
11205 * window.h (resize_proportionally, orig_total_lines)
11206 (orig_top_line): Remove from window structure.
11207 (set_window_height, set_window_width, change_window_heights)
11208 (Fdelete_window): Remove prototypes.
11209 (resize_frame_windows): Remove duplicate declaration.
11211 2011-06-10 Eli Zaretskii <eliz@gnu.org>
11213 * window.h (resize_frame_windows, resize_window_check)
11214 (delete_deletable_window, resize_root_window)
11215 (resize_frame_windows): Declare prototypes.
11217 * window.c (resize_window_apply): Make definition be "static" to
11218 match the prototype.
11220 2011-06-10 Martin Rudalics <rudalics@gmx.at>
11222 * window.c: Remove declarations of Qwindow_size_fixed,
11223 window_min_size_1, window_min_size_2, window_min_size,
11224 size_window, window_fixed_size_p, enlarge_window, delete_window.
11225 Remove static from declaration of Qdelete_window, it's
11226 temporarily needed by Fbury_buffer.
11227 (replace_window): Don't assign orig_top_line and
11229 (Fdelete_window, delete_window): Remove. Window deletion is
11230 handled by window.el.
11231 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11232 Replace Fdelete_window calls with calls to Qdelete_window.
11233 (Fdelete_other_windows): Remove. Deleting other windows is
11234 handled by window.el.
11235 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11236 handled in window.el.
11237 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11238 Window minimum sizes are handled in window.el.
11239 (shrink_windows, size_window, set_window_height)
11240 (set_window_width, change_window_heights, window_height)
11241 (window_width, CURBEG, CURSIZE, enlarge_window)
11242 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11243 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11244 handled in window.el.
11245 (make_dummy_parent): Rename to make_parent_window and give it a
11246 second argument horflag.
11247 (make_window): Don't set resize_proportionally any more.
11248 (Fsplit_window): Remove. Windows are split in window.el.
11249 (save_restore_action, save_restore_orig_size)
11250 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11251 Resize mini windows in window.el.
11252 (grow_mini_window, shrink_mini_window): Implement by calling
11253 Qresize_root_window_vertically, resize_window_check and
11254 resize_window_apply.
11255 (saved_window, Fset_window_configuration, save_window_save):
11256 Do not handle orig_top_line, orig_total_lines, and
11257 resize_proportionally.
11258 (window_min_height, window_min_width): Move to window.el.
11259 (keys_of_window): Move bindings for delete-other-windows,
11260 split-window, delete-window and enlarge-window to window.el.
11262 * buffer.c: Temporarily extern Qdelete_window.
11263 (Fbury_buffer): Temporarily call Qdelete_window instead of
11264 Fdelete_window (Fbury_buffer will move to window.el soon).
11266 * frame.c (set_menu_bar_lines_1): Remove code handling
11267 orig_top_line and orig_total_lines.
11269 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11270 set_window_height but set heights directly.
11271 (change_frame_size_1): Use resize_frame_windows.
11273 * xdisp.c (init_xdisp): Don't use set_window_height but set
11276 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11277 Use resize_frame_windows instead of change_window_heights and run
11278 run_window_configuration_change_hook.
11280 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11281 instead of change_window_heights and run
11282 run_window_configuration_change_hook.
11284 2011-06-09 Martin Rudalics <rudalics@gmx.at>
11286 * window.c (replace_window): Rename second argument REPLACEMENT to
11287 NEW. New third argument SETFLAG. Rewrite.
11288 (delete_window, make_dummy_parent): Call replace_window with
11290 (window_list_1): Move down in code.
11291 (run_window_configuration_change_hook): Move set_buffer part
11292 before select_frame_norecord part in order to unwind correctly.
11293 Rename count1 to count.
11294 (recombine_windows, delete_deletable_window, resize_root_window)
11295 (Fdelete_other_windows_internal)
11296 (Frun_window_configuration_change_hook, make_parent_window)
11297 (resize_window_check, resize_window_apply, Fresize_window_apply)
11298 (resize_frame_windows, Fsplit_window_internal)
11299 (Fdelete_window_internal, Fresize_mini_window_internal):
11301 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11303 2011-06-08 Martin Rudalics <rudalics@gmx.at>
11305 * window.h (window): Add some new members to window structure -
11306 normal_lines, normal_cols, new_total, new_normal, clone_number,
11307 splits, nest, prev_buffers, next_buffers.
11308 (WINDOW_TOTAL_SIZE): Move here from window.c.
11309 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
11311 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11313 (make_dummy_parent): Set new members of windows structure.
11314 (make_window): Move down in code. Handle new members of window
11316 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11317 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11318 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11319 (Fset_window_prev_buffers, Fwindow_next_buffers)
11320 (Fset_window_next_buffers, Fset_window_clone_number):
11322 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11323 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11325 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11326 Argument WINDOW can be now internal window too.
11327 (Fwindow_use_time): Move up in code.
11328 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11329 Rewrite doc-string.
11330 (Fset_window_configuration, saved_window)
11331 (Fcurrent_window_configuration, save_window_save): Handle new
11332 members of window structure.
11333 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11334 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11335 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11336 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11337 Qget_mru_window, Qresize_root_window,
11338 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11339 Qauto_buffer_name; staticpro them.
11341 2011-06-07 Martin Rudalics <rudalics@gmx.at>
11343 * window.c (Fwindow_total_size, Fwindow_left_column)
11344 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11345 (Fwindow_list_1): New functions.
11346 (window_box_text_cols): Replace with window_body_cols.
11347 (Fwindow_width, Fscroll_left, Fscroll_right):
11348 Use window_body_cols instead of window_box_text_cols.
11349 (delete_window, Fset_window_configuration):
11350 Call delete_all_subwindows with window as argument.
11351 (delete_all_subwindows): Take a window as argument and not a
11352 structure. Rewrite.
11353 (window_loop): Remove handling of GET_LRU_WINDOW and
11354 GET_LARGEST_WINDOW.
11355 (Fget_lru_window, Fget_largest_window): Move to window.el.
11357 * window.h: Extern window_body_cols instead of
11358 window_box_text_cols. delete_all_subwindows now takes a
11359 Lisp_Object as argument.
11361 * indent.c (compute_motion, Fcompute_motion):
11362 Use window_body_cols instead of window_box_text_cols.
11364 * frame.c (delete_frame): Call delete_all_subwindows with root
11365 window as argument.
11367 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11369 * fns.c (Fputhash): Document return value.
11371 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
11373 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11375 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11377 Cons<->int and similar integer overflow fixes (Bug#8794).
11379 Check for overflow when converting integer to cons and back.
11380 * charset.c (Fdefine_charset_internal, Fdecode_char):
11381 Use cons_to_unsigned to catch overflow.
11382 (Fencode_char): Use INTEGER_TO_CONS.
11383 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11384 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11385 * data.c (long_to_cons, cons_to_long): Remove.
11386 (cons_to_unsigned, cons_to_signed): New functions.
11387 These signal an error for invalid or out-of-range values.
11388 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11389 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11390 * font.c (Ffont_variation_glyphs):
11391 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11392 * lisp.h: Include <intprops.h>.
11393 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11394 (cons_to_signed, cons_to_unsigned): New decls.
11395 (long_to_cons, cons_to_long): Remove decls.
11396 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11397 (Fprimitive_undo): Use CONS_TO_INTEGER.
11398 * xfns.c (Fx_window_property): Likewise.
11399 * xselect.c: Include <limits.h>.
11400 (x_own_selection, selection_data_to_lisp_data):
11401 Use INTEGER_TO_CONS.
11402 (x_handle_selection_request, x_handle_selection_clear)
11403 (x_get_foreign_selection, Fx_disown_selection_internal)
11404 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11405 (lisp_data_to_selection_data): Use cons_to_unsigned.
11406 (x_fill_property_data): Use cons_to_signed.
11407 Report values out of range.
11409 Check for buffer and string overflow more precisely.
11410 * buffer.h (BUF_BYTES_MAX): New macro.
11411 * lisp.h (STRING_BYTES_MAX): New macro.
11412 * alloc.c (Fmake_string):
11413 * character.c (string_escape_byte8):
11414 * coding.c (coding_alloc_by_realloc):
11415 * doprnt.c (doprnt):
11416 * editfns.c (Fformat):
11418 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11419 since they may not be the same number.
11420 * editfns.c (Finsert_char):
11421 * fileio.c (Finsert_file_contents):
11422 Likewise for BUF_BYTES_MAX.
11424 * image.c: Use ptrdiff_t, not int, for sizes.
11425 (slurp_file): Switch from int to ptrdiff_t.
11427 (slurp_file): Check that file size fits in both size_t (for
11428 malloc) and ptrdiff_t (for sanity and safety).
11430 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11431 if b->modtime has its maximal value.
11433 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11435 Don't assume time_t can fit into int.
11436 * buffer.h (struct buffer.modtime): Now time_t, not int.
11437 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11438 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11440 Minor fixes for signed vs unsigned integers.
11441 * character.h (MAYBE_UNIFY_CHAR):
11442 * charset.c (maybe_unify_char):
11443 * keyboard.c (read_char, reorder_modifiers):
11444 XINT -> XFASTINT, since the integer must be nonnegative.
11445 * ftfont.c (ftfont_spec_pattern):
11446 * keymap.c (access_keymap, silly_event_symbol_error):
11447 XUINT -> XFASTINT, since the integer must be nonnegative.
11448 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11449 since it makes no difference and we prefer signed.
11450 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11451 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11454 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11456 * window.h (Fwindow_frame): Declare.
11458 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11460 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11461 (SPARE_MEMORY): Always define.
11462 (LARGE_REQUEST): Remove.
11463 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11465 2011-06-06 Martin Rudalics <rudalics@gmx.at>
11467 * lisp.h: Move EXFUNS for Fframe_root_window,
11468 Fframe_first_window and Fset_frame_selected_window to window.h.
11470 * window.h: Move EXFUNS for Fframe_root_window,
11471 Fframe_first_window and Fset_frame_selected_window here from
11474 * frame.c (Fwindow_frame, Fframe_first_window)
11475 (Fframe_root_window, Fframe_selected_window)
11476 (Fset_frame_selected_window): Move to window.c.
11477 (Factive_minibuffer_window): Move to minibuf.c.
11478 (Fother_visible_frames_p): New function.
11480 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11482 * window.c (decode_window, decode_any_window): Move up in code.
11483 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11484 (inhibit_frame_unsplittable): Remove unused variable.
11485 (Fwindow_buffer): Move up and rewrite doc-string.
11486 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11487 (Fwindow_prev): New functions.
11488 (Fwindow_frame): Move here from frame.c. Accept any window as
11490 (Fframe_root_window, Fframe_first_window)
11491 (Fframe_selected_window): Move here from frame.c. Accept frame
11492 or arbitrary window as argument. Update doc-strings.
11493 (Fminibuffer_window): Move up in code.
11494 (Fwindow_minibuffer_p): Move up in code and simplify.
11495 (Fset_frame_selected_window): Move here from frame.c.
11497 (Fselected_window, select_window, Fselect_window): Move up in
11498 code. Minor doc-string fixes.
11500 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11502 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11503 Do not assume that spare memory exists; that assumption is valid
11504 only if SYSTEM_MALLOC.
11505 (LARGE_REQUEST): New macro, so that the issue of large requests
11506 is separated from the issue of spare memory.
11508 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11510 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11513 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11515 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11518 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11520 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11522 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11524 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11525 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11527 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
11529 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11531 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
11533 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11534 (x_clipboard_manager_save): Add return value.
11535 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11536 New error handlers.
11537 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11538 Obey Vx_select_enable_clipboard_manager. Catch errors in
11539 x_clipboard_manager_save (Bug#8779).
11540 (Vx_select_enable_clipboard_manager): New variable.
11541 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
11543 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
11545 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11547 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11549 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11550 in the current matrix if keep_current_p is non-zero.
11552 2011-06-04 Eli Zaretskii <eliz@gnu.org>
11554 * bidi.c (bidi_level_of_next_char): Fix last change.
11556 2011-06-03 Eli Zaretskii <eliz@gnu.org>
11558 Support bidi reordering of text covered by display properties.
11560 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11561 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11562 (bidi_cache_search, bidi_cache_iterator_state)
11563 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
11564 (bidi_level_of_next_char, bidi_move_to_visually_next):
11565 Support character positions inside a run of characters covered by a
11567 (bidi_paragraph_init, bidi_resolve_explicit_1)
11568 (bidi_level_of_next_char): Call bidi_fetch_char and
11569 bidi_fetch_char_advance instead of FETCH_CHAR and
11570 FETCH_CHAR_ADVANCE.
11571 (bidi_init_it): Initialize new members.
11572 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11574 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11575 instead of using explicit *_CHAR codes.
11576 (bidi_resolve_explicit, bidi_resolve_weak):
11577 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
11578 bidirectional text is supported only in multibyte buffers.
11579 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11580 it to initialize the frame_window_p member of struct bidi_it.
11581 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11582 (bidi_resolve_explicit, bidi_resolve_weak)
11583 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11584 bidi_it->nchars is non-positive.
11585 (bidi_level_of_next_char): Don't try to lookup the cache for the
11586 next/previous character if nothing is cached there yet, or if we
11587 were just reseat()'ed to a new position.
11589 * xdisp.c (set_cursor_from_row): Set start and stop points
11590 according to the row's direction when priming the loop that looks
11591 for the glyph on which to display cursor.
11592 (single_display_spec_intangible_p): Function deleted.
11593 (display_prop_intangible_p): Reimplement to call
11594 handle_display_spec instead of single_display_spec_intangible_p.
11595 Accept 3 additional arguments needed by handle_display_spec.
11596 This fixes incorrect cursor motion across display property with complex
11597 values: lists, `(when COND...)' forms, etc.
11598 (single_display_spec_string_p): Support property values that are
11599 lists with the argument STRING its top-level element.
11600 (display_prop_string_p): Fix the condition for processing a
11601 property that is a list to be consistent with handle_display_spec.
11602 (handle_display_spec): New function, refactored from the
11603 last portion of handle_display_prop.
11604 (compute_display_string_pos): Accept additional argument
11605 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11606 value of a `display' property is a "replacing spec".
11607 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11608 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11609 the display property, but just return a value indicating whether
11610 the display property will replace the characters it covers.
11611 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11612 frame_window_p members of struct bidi_it.
11613 (compute_display_string_pos, compute_display_string_end):
11615 (push_it): Accept second argument POSITION, where pop_it should
11616 jump to continue iteration.
11617 (reseat_1): Initialize bidi_it.disp_pos.
11619 * keyboard.c (adjust_point_for_property): Adjust the call to
11620 display_prop_intangible_p to its new signature.
11622 * dispextern.h (struct bidi_it): New member frame_window_p.
11623 (bidi_init_it): Update prototypes.
11624 (display_prop_intangible_p): Update prototype.
11625 (compute_display_string_pos, compute_display_string_end):
11626 Declare prototypes.
11627 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11630 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11632 Malloc failure behavior now depends on size of allocation.
11633 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11634 * lisp.h: Change signatures accordingly.
11635 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11636 All callers changed. (Bug#8762)
11638 * gnutls.c: Use Emacs's memory allocators.
11639 Without this change, the gnutls library would invoke malloc etc.
11640 directly, which causes problems on non-SYNC_INPUT hosts, and which
11641 runs afoul of improving memory_full behavior. (Bug#8761)
11642 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11643 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11644 xfree instead of the default malloc, realloc, free.
11645 (Fgnutls_boot): No need to check for memory allocation failure,
11646 since xmalloc does that for us.
11648 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11649 * category.c (hash_get_category_set):
11650 * ccl.c (ccl_driver):
11651 * charset.c (Fdefine_charset_internal):
11652 * charset.h (struct charset.hash_index):
11653 * composite.c (get_composition_id, gstring_lookup_cache)
11654 (composition_gstring_put_cache):
11655 * composite.h (struct composition.hash_index):
11656 * dispextern.h (struct image.hash):
11657 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11658 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11659 (hashfn_equal, hashfn_user_defined, make_hash_table)
11660 (maybe_resize_hash_table, hash_lookup, hash_put)
11661 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11662 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11663 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11664 * image.c (make_image, search_image_cache, lookup_image)
11665 (xpm_put_color_table_h):
11666 * lisp.h (struct Lisp_Hash_Table):
11667 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11668 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11669 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11670 * alloc.c (allocate_vectorlike):
11671 Check for overflow in vector size calculations.
11672 * ccl.c (ccl_driver):
11673 Check for overflow when converting EMACS_INT to int.
11674 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11675 need to be updated by these changes.
11676 * fns.c (make_hash_table, maybe_resize_hash_table):
11677 Check for integer overflow with large hash tables.
11678 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11679 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11680 (SXHASH_REDUCE): New macro.
11681 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11682 Use it instead of discarding useful hash info with large hash values.
11683 (sxhash_float): New function.
11684 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11685 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11686 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11687 Rewrite to use FIXNUM_BITS, as this simplifies things.
11688 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11689 Adjust signatures to match updated version of code.
11690 (consing_since_gc): Now EMACS_INT, since a single hash table can
11691 use more than INT_MAX bytes.
11693 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11695 Make it possible to build with GCC-4.6+ -O2 -flto.
11697 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11699 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11701 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11702 Call minibuffer-inactive-mode.
11704 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11706 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11707 Update dependencies.
11709 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11711 * data.c (init_data): Remove code for UTS, this system is not
11714 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11716 Don't force ./temacs to start in terminal mode.
11718 * frame.c (make_initial_frame): Initialize faces in all cases, not
11719 only when CANNOT_DUMP is defined.
11720 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11722 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11724 * dispnew.c (add_window_display_history): Use const for the string
11725 pointer. Remove declaration, not needed.
11727 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11729 Use 'inline', not 'INLINE'.
11730 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11731 * alloc.c, fontset.c (INLINE): Remove.
11732 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11733 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11734 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11735 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11736 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11738 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11740 Make it possible to run ./temacs.
11742 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11743 syms_of_callproc does the same thing. Remove test for
11744 "initialized", do it in the caller.
11745 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11747 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11749 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11750 (read_minibuf): Use get_minibuffer.
11751 (syms_of_minibuf): Use DEFSYM.
11752 (Qmetadata): New var.
11753 * data.c (Qbuffer): Don't make it static.
11754 (syms_of_data): Use DEFSYM.
11756 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11758 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11759 (CCL_CODE_MIN): New macro.
11761 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11763 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11765 * eval.c (Qdebug): Now static.
11766 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11767 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11768 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11770 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11772 * image.c: Various fixes to ImageMagick code comments.
11773 (Fimagemagick_types): Doc fix.
11775 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11777 Minor fixes prompted by GCC 4.6.0 warnings.
11779 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11781 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11782 (x_clipboard_manager_save_all): Move extern decl to ...
11783 * xterm.h: ... here, so that it can be checked for consistency.
11785 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11787 * xselect.c (x_clipboard_manager_save_frame)
11788 (x_clipboard_manager_save_all): New functions.
11789 (Fx_clipboard_manager_save): Lisp function deleted.
11791 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11792 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11794 * xterm.h: Update prototype.
11796 2011-05-28 William Xu <william.xwl@gmail.com>
11798 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11799 exiting (Bug#8239).
11801 2011-05-28 Jim Meyering <meyering@redhat.com>
11803 Avoid a sign-extension bug in crypto_hash_function.
11804 * fns.c (to_uchar): Define.
11805 (crypto_hash_function): Use it to convert some newly-signed
11806 variables to unsigned, to avoid sign-extension bugs. For example,
11807 without this change, (md5 "truc") would evaluate to
11808 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11809 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11810 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11812 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11814 Integer overflow fixes.
11816 * dbusbind.c: Serial number integer overflow fixes.
11817 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11818 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11819 to hold a serial number that is too large for a fixnum.
11820 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11821 Check for serial numbers out of range. Decode any serial number
11822 that was so large that it became a float. (Bug#8722)
11824 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11825 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11826 Use XFASTINT rather than XUINT when numbers are nonnegative.
11827 (xd_append_arg, Fdbus_method_return_internal):
11828 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11829 arguments, check that Lisp number is nonnegative, rather than
11830 silently wrapping negative numbers around. (Bug#8722)
11831 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11834 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11836 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11838 ccl: Add integer overflow checks.
11839 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11840 (IN_INT_RANGE): New macros.
11841 (ccl_driver): Use them to check for integer overflow when
11842 decoding a CCL program. Many of the new checks are whether XINT (x)
11843 fits in int; it doesn't always, on 64-bit hosts. The new version
11844 doesn't catch all possible integer overflows, but it's an
11845 improvement. (Bug#8719)
11847 * alloc.c (make_event_array): Use XINT, not XUINT.
11848 There's no need for unsigned here.
11850 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11851 This follows up to the 2011-05-06 change that substituted uintptr_t
11852 for EMACS_INT. This case wasn't caught back then.
11854 Rework Fformat to avoid integer overflow issues.
11855 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11856 now (part of C89). Include <verify.h>.
11857 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11858 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11859 (Fformat): Avoid the prepass trying to compute sizes; it was only
11860 approximate and thus did not catch overflow reliably. Instead, walk
11861 through the format just once, formatting and computing sizes as we go,
11862 checking for integer overflow at every step, and allocating a larger
11863 buffer as needed. Keep track separately whether the format is
11864 multibyte. Keep only the most-recently calculated precision, rather
11865 than them all. Record whether each argument has been converted to
11866 string. Use EMACS_INT, not int, for byte and char and arg counts.
11867 Support field widths and precisions larger than INT_MAX. Avoid
11868 sprintf's undefined behavior with conversion specifications such as %#d
11869 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11870 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11871 formatting out-of-range floating point numbers with int
11872 formats. (Bug#8668)
11874 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11876 * data.c: Avoid integer truncation in expressions involving floats.
11877 * data.c: Include <intprops.h>.
11878 (arith_driver): When there's an integer overflow in an expression
11879 involving floating point, convert the integers to floating point
11880 so that the resulting value does not suffer from catastrophic
11881 integer truncation. For example, on a 64-bit host (* 4
11882 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11883 Do not rely on undefined behavior after integer overflow.
11885 merge count_size_as_multibyte, parse_str_to_multibyte
11886 * character.c, character.h (count_size_as_multibyte):
11887 Rename from parse_str_to_multibyte; all uses changed.
11888 Check for integer overflow.
11889 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11890 since it's now a duplicate of the other. This is more of
11891 a character than a buffer op, so better that it's in character.c.
11892 * fns.c, print.c: Adjust to above changes.
11894 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11896 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11898 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11900 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11901 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11902 (x_clipboard_manager_save): Now static.
11903 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11905 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11906 (crypto_hash_function): Now static.
11907 Fix pointer signedness problems. Avoid unnecessary initializations.
11909 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11911 * termhooks.h (Vselection_alist): Make it terminal-local.
11913 * terminal.c (create_terminal): Initialize it.
11915 * xselect.c: Support for clipboard managers.
11916 (Vselection_alist): Move to termhooks.h as terminal-local var.
11917 (LOCAL_SELECTION): New macro.
11918 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11919 (symbol_to_x_atom): Remove gratuitous arg.
11920 (x_handle_selection_request, lisp_data_to_selection_data)
11921 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11922 (x_own_selection, x_get_local_selection, x_convert_selection):
11923 New arg, specifying work frame. Use terminal-local Vselection_alist.
11924 (some_frame_on_display): Delete unused function.
11925 (Fx_own_selection_internal, Fx_get_selection_internal)
11926 (Fx_disown_selection_internal, Fx_selection_owner_p)
11927 (Fx_selection_exists_p): New optional frame arg.
11928 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11929 (x_handle_selection_clear): Don't treat other terminals with the
11930 same keyboard specially. Use the terminal-local Vselection_alist.
11931 (x_clear_frame_selections): Use Frun_hook_with_args.
11933 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11935 * xterm.h: Add support for those atoms.
11937 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11939 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11940 (converted_selections, conversion_fail_tag): New global variables.
11941 (x_selection_request_lisp_error): Free the above.
11942 (x_get_local_selection): Remove unnecessary code.
11943 (x_reply_selection_request): Args changed; handle arbitrary array
11944 of converted selections stored in converted_selections.
11945 Separate the XChangeProperty and SelectionNotify steps.
11946 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11947 (x_convert_selection): New function.
11948 (x_handle_selection_event): Simplify.
11949 (x_get_foreign_selection): Don't ignore incoming requests while
11950 waiting for an answer; this will fail when we implement
11951 SAVE_TARGETS, and seems unnecessary anyway.
11952 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11953 (Vx_sent_selection_functions): Doc fix.
11955 2011-05-26 Leo Liu <sdl.web@gmail.com>
11957 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11959 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11961 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11963 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11964 for fringe update if it has periodic bitmap.
11965 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11966 and fringe_bitmap_periodic_p.
11968 * fringe.c (get_fringe_bitmap_data): New function.
11969 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11970 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11971 row. Mark glyph row for fringe update if periodicity changed.
11973 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11974 for fringe update unless it has periodic bitmap.
11976 2011-05-25 Kenichi Handa <handa@m17n.org>
11978 * xdisp.c (get_next_display_element): Set correct it->face_id for
11979 a static composition.
11981 2011-05-24 Leo Liu <sdl.web@gmail.com>
11984 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11986 * fns.c (crypto_hash_function, Fsha1): New function.
11987 (Fmd5): Use crypto_hash_function.
11988 (syms_of_fns): Add Ssha1.
11990 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11992 * gnutls.c: Remove unused macros.
11993 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11994 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11995 Remove macros that are defined and never used.
11996 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11998 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
12000 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12001 (Fx_get_selection_internal): Minor cleanup.
12002 (Fx_own_selection_internal): Rename arguments for consistency with
12005 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12007 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12009 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
12011 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12013 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12015 * dispnew.c (scrolling_window): Don't exclude the case that the
12016 last enabled row in the desired matrix touches the bottom boundary.
12018 2011-05-21 Glenn Morris <rgm@gnu.org>
12020 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
12021 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12022 and add some more files.
12024 2011-05-20 Eli Zaretskii <eliz@gnu.org>
12026 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12027 report_file_error introduced by the change from 2011-05-07.
12029 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12031 * systime.h (Time): Define only if emacs is defined.
12032 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12033 where the include path doesn't have X11/X.h by default. See
12034 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12036 2011-05-20 Kenichi Handa <handa@m17n.org>
12038 * composite.c (find_automatic_composition): Fix previous change.
12040 2011-05-20 Glenn Morris <rgm@gnu.org>
12042 * lisp.mk: New file, split from Makefile.in.
12043 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12044 (shortlisp): Remove.
12045 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12047 2011-05-19 Glenn Morris <rgm@gnu.org>
12049 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12050 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12051 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12052 (lisp): Set the order to that of loadup.el.
12053 (shortlisp): Make it a copy of $lisp.
12054 (SOME_MACHINE_LISP): Remove.
12055 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12056 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12058 2011-05-18 Kenichi Handa <handa@m17n.org>
12060 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12061 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12062 (find_automatic_composition): Mostly rewrite for efficiency.
12064 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
12066 * makefile.w32-in: Update dependencies.
12068 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12070 * menu.c: Include limits.h (fixes the MS-Windows build broken by
12071 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
12073 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
12075 Fix some integer overflow issues, such as string length overflow.
12077 * insdel.c (count_size_as_multibyte): Check for string overflow.
12079 * character.c (lisp_string_width): Check for string overflow.
12080 Use EMACS_INT, not int, for string indexes and lengths; in
12081 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12082 the resulting string length overflows an EMACS_INT; instead,
12083 report a string overflow if no precision given. When checking for
12084 precision exhaustion, use a check that cannot possibly have
12085 integer overflow. (Bug#8675)
12086 * character.h (lisp_string_width): Adjust to new signature.
12088 * alloc.c (string_overflow): New function.
12089 (Fmake_string): Use it. This doesn't change behavior, but saves
12090 a few bytes and will simplify future changes.
12091 * character.c (string_escape_byte8): Likewise.
12092 * lisp.h (string_overflow): New decl.
12094 Fixups, following up to the user-interface timestamp change.
12095 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12096 for UI timestamps, instead of unsigned long.
12097 * msdos.c (mouse_get_pos): Likewise.
12098 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
12099 * w32gui.h (Time): Define by including "systime.h" rather than by
12100 declaring it ourselves. (Bug#8664)
12102 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12103 * image.c (clear_image_cache): Likewise.
12105 * term.c (term_mouse_position): Don't assume time_t wraparound.
12107 Be more systematic about user-interface timestamps.
12108 Before, the code sometimes used 'Time', sometimes 'unsigned long',
12109 and sometimes 'EMACS_UINT', to represent these timestamps.
12110 This change causes it to use 'Time' uniformly, as that's what X uses.
12111 This makes the code easier to follow, and makes it easier to catch
12112 integer overflow bugs such as Bug#8664.
12113 * frame.c (Fmouse_position, Fmouse_pixel_position):
12114 Use Time, not unsigned long, for user-interface timestamps.
12115 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12116 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12117 * keyboard.h (last_event_timestamp): Likewise.
12118 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12119 * menu.h (xmenu_show): Likewise.
12120 * term.c (term_mouse_position): Likewise.
12121 * termhooks.h (struct input_event.timestamp): Likewise.
12122 (struct terminal.mouse_position_hook): Likewise.
12123 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12124 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12125 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12126 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12127 what it was before.
12128 * menu.h, termhooks.h: Include "systime.h", for Time.
12130 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12131 Don't assume that the difference between two unsigned long values
12132 can fit into an integer. At this point, we know button_down_time
12133 <= event->timestamp, so the difference must be nonnegative, so
12134 there's no need to cast the result if double-click-time is
12135 nonnegative, as it should be; check that it's nonnegative, just in
12136 case. This bug is triggered when events are more than 2**31 ms
12137 apart (about 25 days). (Bug#8664)
12139 * xselect.c (last_event_timestamp): Remove duplicate decl.
12140 (x_own_selection): Remove needless cast to unsigned long.
12142 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12143 that always fit in int. Use a sentinel instead of a counter, to
12144 avoid a temp and to allay GCC's concerns about possible int overflow.
12145 * frame.h (struct frame): Use int for menu_bar_items_used
12146 instead of EMACS_INT, since it always fits in int.
12148 * menu.c (grow_menu_items): Check for int overflow.
12150 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12152 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12153 Before, the code was not consistent. These values cannot exceed
12154 2**31 - 1 so there's no need to make them unsigned.
12155 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12156 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12157 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12159 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12161 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12162 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12163 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12164 presumably because the widths might not match.
12166 * window.c (size_window): Avoid needless test at loop start.
12168 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12170 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12172 2011-05-12 Drew Adams <drew.adams@oracle.com>
12174 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12176 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12178 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12179 `width' to `bar_area_x' and `bar_area_width', respectively.
12180 (x_scroll_run): Take account of fringe background extension.
12182 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12183 Rename local vars `left' and `width' to `bar_area_x' and
12184 `bar_area_width', respectively.
12185 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12186 background extension.
12188 2011-05-10 Jim Meyering <meyering@redhat.com>
12190 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12192 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
12194 * image.c (Finit_image_library): Return t for built-in image types,
12195 like pbm and xbm. (Bug#8640)
12197 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12199 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12201 2011-05-07 Eli Zaretskii <eliz@gnu.org>
12203 * w32console.c (Fset_screen_color): Doc fix.
12204 (Fget_screen_color): New function.
12205 (syms_of_ntterm): Defsubr it.
12207 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12208 unlink the temporary file if Fcall_process didn't create it in the
12210 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12211 child process will be redirected to a file specified with `:file'.
12212 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12213 cue to call_process_cleanup not to close that handle.
12215 2011-05-07 Ben Key <bkey76@gmail.com>
12217 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12218 one of two shell specific rules, either bootstrap-temacs-CMD or
12219 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12220 to the previous implementation of the bootstrap-temacs rule.
12221 The bootstrap-temacs-CMD rule is similar to the previous
12222 implementation of the bootstrap-temacs rule except that it
12223 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12226 These changes, along with some changes to nt/configure.bat,
12227 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12228 earlier fix to add support for --cflags and --ldflags options
12229 that include quotes so that it works whether make uses cmd or
12232 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
12234 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12235 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12237 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12238 a string. Handle both cases.
12239 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12240 (Fdbus_register_method): Use Qinvalid_function.
12242 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
12244 * makefile.w32-in: Update dependencies.
12245 (LISP_H): Add inttypes.h and stdin.h.
12246 (PROCESS_H): Add unistd.h.
12248 2011-05-06 Eli Zaretskii <eliz@gnu.org>
12250 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12251 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12253 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
12255 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12257 * term.c (vfatal): Remove stray call to va_end.
12258 It's not needed and the C Standard doesn't allow it here anyway.
12260 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12261 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12263 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12266 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12268 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12270 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12272 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12274 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12276 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12277 * charset.c (Fdefine_charset_internal): Don't initialize
12278 charset.code_space[15]. The value was garbage, on hosts with
12279 32-bit int (Bug#8600).
12281 * lread.c (read_integer): Be more consistent with string-to-number.
12282 Use string_to_number to do the actual conversion; this avoids
12283 rounding errors and fixes some other screwups. Without this fix,
12284 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12285 (digit_to_number): Move earlier, for benefit of read_integer.
12286 Return -1 if the digit is out of range for the base, -2 if it is
12287 not a digit in any supported base. (Bug#8602)
12289 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12291 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12292 to match comment at start of function. This also removes a
12293 GCC warning about overflow in a 32+64-bit port.
12295 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12297 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12298 Reported by Stefan Monnier in
12299 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
12300 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12301 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
12303 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12304 (EMACS_UINTPTR): Likewise, with uintptr_t.
12306 * lisp.h: Prefer 64-bit EMACS_INT if available.
12307 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12308 on 32-bit hosts that have 64-bit int, so that they can access
12310 However, temporarily disable this change unless the temporary
12311 symbol WIDE_EMACS_INT is defined.
12313 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12315 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12316 This removes an assumption that EMACS_INT and long are the same
12317 width as pointers. The assumption is true for Emacs porting targets
12318 now, but we want to make other targets possible.
12319 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12320 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12321 In the rest of the code, change types of integers that hold casted
12322 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12323 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12324 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12325 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12326 No need to cast type when ORing.
12327 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12328 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12329 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12330 assume EMACS_INT is the same width as char *.
12331 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12332 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12333 Remove no-longer-needed casts.
12334 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12335 (xg_tool_bar_help_callback, xg_make_tool_item):
12336 Use EMACS_INTPTR to hold an integer
12337 that will be cast to void *; this can avoid a GCC warning
12338 if EMACS_INT is not the same width as void *.
12339 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12340 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12341 (current_message_1, set_message_1):
12342 Use a local to convert to proper width without a cast.
12343 * xmenu.c (dialog_selection_callback): Likewise.
12345 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12346 Also, don't assume VALBITS / RAND_BITS is less than 5,
12347 and don't rely on undefined behavior when shifting a 1 left into
12349 * lisp.h (get_random): Change signature to match.
12351 * lread.c (hash_string): Use size_t, not int, for hash computation.
12352 Normally we prefer signed values; but hashing is special, because
12353 it's better to use unsigned division on hash table sizes so that
12354 the remainder is nonnegative. Also, size_t is the natural width
12355 for hashing into memory. The previous code used 'int', which doesn't
12356 retain enough info to hash well into very large tables.
12357 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12359 * dbusbind.c: Don't possibly lose pointer info when converting.
12360 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12361 Use XPNTR rather than XHASH, so that the high-order bits of
12362 the pointer aren't lost when converting through void *.
12364 * eval.c (Fautoload): Don't double-shift a pointer.
12366 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12368 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
12370 * gnutls.c (DEF_GNUTLS_FN):
12371 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12373 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12375 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12378 2011-05-05 Eli Zaretskii <eliz@gnu.org>
12380 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12381 New version that can reserve upto 2GB of heap space.
12383 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
12385 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12387 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12389 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12390 `gnutls_certificate_set_x509_key_file'.
12392 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
12394 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12395 Update dependencies.
12397 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12399 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12400 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12401 Remove unused parameter `fildes'.
12402 * process.c (read_process_output, send_process): Don't pass it.
12404 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12406 Fix previous change: the library cache is defined in w32.c.
12407 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12408 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12410 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12412 Implement dynamic loading of GnuTLS on Windows.
12414 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12415 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12416 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12419 * gnutls.c (Qgnutls_dll): Define.
12420 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12421 (gnutls_*): Declare function pointers.
12422 (init_gnutls_functions): New function to initialize function pointers.
12423 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12424 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12425 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12426 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12427 (emacs_gnutls_write, emacs_gnutls_read)
12428 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12429 (Fgnutls_available_p): New function.
12430 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12431 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12432 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12434 * image.c: Include w32.h.
12435 (Vimage_type_cache): Delete.
12436 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12437 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12438 (w32_delayed_load): Move to w32.c.
12440 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12442 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12443 (w32_delayed_load): Move from image.c. When loading a library, record
12444 its filename in the :loaded-from property of the library id.
12445 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12446 Initialize and staticpro them.
12447 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12449 * process.c: Include lisp.h before w32.h, not after.
12450 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12451 instead of gnutls_record_check_pending.
12453 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12455 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12457 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12458 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12461 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12463 * xterm.c (x_set_frame_alpha): Do not set property on anything
12464 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12466 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
12468 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12470 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
12472 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12473 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12474 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12475 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12476 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12477 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12478 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12479 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12480 (Qgnutls_bootprop_callbacks_verify): Make static.
12482 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12484 * callproc.c: Indentation fixup.
12486 * sysdep.c (wait_for_termination_1): Make static.
12487 (wait_for_termination, interruptible_wait_for_termination):
12488 Move after wait_for_termination_1.
12490 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12492 * sysdep.c (interruptible_wait_for_termination): New function
12493 which is like wait_for_termination, but allows keyboard
12496 * callproc.c (Fcall_process): Add (:file "file") as an option for
12498 (Fcall_process_region): Ditto.
12500 2011-04-30 Eli Zaretskii <eliz@gnu.org>
12502 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12503 rather than `XVECTOR (FOO)->size'.
12505 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12506 inttypes.h, as a gnulib replacement is used if it not available in
12509 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12511 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12512 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12513 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12515 * coding.c (coding_alloc_by_realloc): Error out if destination
12516 will grow beyond MOST_POSITIVE_FIXNUM.
12517 (decode_coding_emacs_mule): Abort if there isn't enough place in
12518 charbuf for the composition carryover bytes. Reserve an extra
12519 space for up to 2 characters produced in a loop.
12520 (decode_coding_iso_2022): Abort if there isn't enough place in
12521 charbuf for the composition carryover bytes.
12523 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12525 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12526 aborting when %lld or %lll format is passed.
12527 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12528 %llo or %llx format is passed. (Bug#8545)
12530 * window.c (window_scroll_line_based): Use a marker instead of
12531 simple variables to record original value of point. (Bug#7952)
12533 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12534 produced by %s or %c overflows available buffer space. (Bug#8545)
12536 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12538 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
12539 (SIZE_MAX): Move defn after all includes, as they might #define it.
12541 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12543 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12545 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12547 * keyboard.c (Qdelayed_warnings_hook): Define.
12548 (command_loop_1): Run `delayed-warnings-hook'
12549 if Vdelayed_warnings_list is non-nil.
12550 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12551 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12553 2011-04-28 Eli Zaretskii <eliz@gnu.org>
12555 * doprnt.c (doprnt): Don't return value smaller than the buffer
12556 size if the message was truncated. (Bug#8545).
12558 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12560 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12561 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12563 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12565 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12567 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
12569 * makefile.w32-in: Update dependencies.
12571 2011-04-27 Eli Zaretskii <eliz@gnu.org>
12573 Improve `doprnt' and its usage. (Bug#8545)
12574 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12575 `format_end'. Remove support for %l as a conversion specifier.
12576 Don't use xrealloc. Improve diagnostics when the %l size modifier
12577 is used. Update the commentary.
12579 * eval.c (verror): Simplify calculation of size_t.
12581 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12584 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12586 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12589 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12591 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12592 This makes this file independent of the recent pseudovector change.
12594 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12596 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12598 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12599 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12600 Remove unused local.
12601 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12603 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12604 GCC 4.6.0 optimizes based on type-based alias analysis.
12605 For example, if b is of type struct buffer * and v of type struct
12606 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12607 != &v->size, and therefore "v->size = 1; b->size = 2; return
12608 v->size;" must therefore return 1. This assumption is incorrect
12609 for Emacs, since it type-puns struct Lisp_Vector * with many other
12610 types. To fix this problem, this patch adds a new type struct
12611 vectorlike_header that documents the constraints on layout of vectors
12612 and pseudovectors, and helps optimizing compilers not get fooled
12613 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12614 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12615 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12617 (XSETPVECTYPE): Rewrite in terms of new macro.
12618 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12619 This is a bit clearer, and further avoids the possibility of
12620 undesirable aliasing.
12621 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12622 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12623 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12624 since Lisp_Subr is a special case (no "next" field).
12625 (ASIZE): Now uses header.size rather than size.
12626 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12627 to avoid the hassle of writing XVECTOR (foo)->header.size.
12628 (struct vectorlike_header): New type.
12629 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12630 object, to help avoid aliasing.
12631 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12632 (SUBRP): Likewise, since Lisp_Subr is a special case.
12633 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12634 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12635 (struct Lisp_Hash_Table): Combine first two members into a single
12636 struct vectorlike_header member. All uses of "size" and "next" members
12637 changed to be "header.size" and "header.next".
12638 * buffer.h (struct buffer): Likewise.
12639 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12640 * frame.h (struct frame): Likewise.
12641 * process.h (struct Lisp_Process): Likewise.
12642 * termhooks.h (struct terminal): Likewise.
12643 * window.c (struct save_window_data, struct saved_window): Likewise.
12644 * window.h (struct window): Likewise.
12645 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12646 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12647 * buffer.c (init_buffer_once): Likewise.
12648 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12650 * process.c (Fformat_network_address): Use local var for size,
12653 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12655 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12656 * data.c (atof): Remove decl; no longer used or needed.
12657 (digit_to_number): Move to lread.c.
12658 (Fstring_to_number): Use new string_to_number function, to be
12659 consistent with how the Lisp reader treats infinities and NaNs.
12660 Do not assume that floating-point numbers represent EMACS_INT
12661 without losing information; this is not true on most 64-bit hosts.
12662 Avoid double-rounding errors, by insisting on integers when
12663 parsing non-base-10 numbers, as the documentation specifies.
12664 * lisp.h (string_to_number): New decl, replacing ...
12665 (isfloat_string): Remove.
12666 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12667 (read1): Do not accept +. and -. as integers; this
12668 appears to have been a coding error. Similarly, do not accept
12669 strings like +-1e0 as floating point numbers. Do not report
12670 overflow for integer overflows unless the base is not 10 which
12671 means we have no simple and reliable way to continue.
12672 Break out the floating-point parsing into a new
12673 function string_to_number, so that Fstring_to_number parses
12674 floating point numbers consistently with the Lisp reader.
12675 (digit_to_number): Move here from data.c. Make it static inline.
12676 (E_CHAR, EXP_INT): Remove, replacing with ...
12677 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12678 (string_to_number): New function, replacing isfloat_string.
12679 This function checks for valid syntax and produces the resulting
12680 Lisp float number too. Rework it so that string-to-number
12681 no longer mishandles examples like "1.0e+". Use strtoumax,
12682 so that overflow for non-base-10 numbers is reported only when
12683 there's no portable and simple way to convert to floating point.
12685 * textprop.c (set_text_properties_1): Rewrite for clarity,
12686 and to avoid GCC warning about integer overflow.
12688 * intervals.h (struct interval): Use EMACS_INT for members
12689 where EMACS_UINT might cause problems. See
12690 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12691 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12692 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12694 (offset_intervals): Tell GCC not to worry about length overflow
12695 when negating a negative length.
12697 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12698 (overrun_check_free): Likewise.
12700 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12701 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12704 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12705 (gnutls_make_error): Rename local to avoid shadowing.
12706 (gnutls_emacs_global_deinit): ifdef out; not used.
12707 (Fgnutls_boot): Use const for pointer to readonly storage.
12708 Comment out unused local. Fix pointer signedness problems.
12710 * lread.c (openp): Don't stuff size_t into an 'int'.
12711 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12712 about possible signed overflow.
12714 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12715 (GDK_KEY_g): Don't define if already defined.
12716 (xg_prepare_tooltip): Avoid pointer signedness problem.
12717 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12719 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12720 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12722 * xfns.c (Fx_window_property): Simplify a bit,
12723 to make a bit faster and to avoid GCC 4.6.0 warning.
12724 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12726 * fns.c (internal_equal): Don't assume size_t fits in int.
12728 * alloc.c (compact_small_strings): Tighten assertion a little.
12730 Replace pEd with more-general pI, and fix some printf arg casts.
12731 * lisp.h (pI): New macro, generalizing old pEd macro to other
12732 conversion specifiers. For example, use "...%"pI"d..." rather
12733 than "...%"pEd"...".
12734 (pEd): Remove. All uses replaced with similar uses of pI.
12735 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12736 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12737 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12738 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12739 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12740 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12741 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12743 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12744 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12745 * print.c (safe_debug_print, print_object): Likewise.
12746 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12748 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12749 avoiding the 0 flag, which is not portable.
12750 * process.c (Fmake_network_process): Use pI to avoid cast.
12751 * region-cache.c (pp_cache): Likewise.
12752 * xdisp.c (decode_mode_spec): Likewise.
12753 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12754 behavior on 64-bit hosts with printf arg.
12755 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12756 (x_stop_queuing_selection_requests): Likewise.
12757 (x_get_window_property): Don't truncate byte count to an 'int'
12760 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12761 here, since it parses constructs like leading '-' and spaces,
12762 which are not wanted; and it overflows with large numbers.
12763 Instead, simply match F[0-9]+, which is what is wanted anyway.
12765 * alloc.c: Remove unportable assumptions about struct layout.
12766 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12767 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12768 (allocate_vectorlike, make_pure_vector): Use the new macros,
12769 plus offsetof, to remove unportable assumptions about struct layout.
12770 These assumptions hold on all porting targets that I know of, but
12771 they are not guaranteed, they're easy to remove, and removing them
12772 makes further changes easier.
12774 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12775 This doesn't fix a bug but makes the code clearer.
12776 (string_overrun_cookie): Now const. Use initializers that
12777 don't formally overflow signed char, to avoid warnings.
12778 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12779 can cause Emacs to crash when string overrun checking is enabled.
12780 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12781 multiple of sizeof (EMACS_INT); it need not be, if
12782 alignof(EMACS_INT) < sizeof (EMACS_INT).
12783 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12785 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12787 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12789 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12791 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12792 supposed to be handshaking. (Bug#8556)
12793 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12795 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12797 * lisp.h (Qdebug): List symbol.
12798 * eval.c (Qdebug): Restore global linkage.
12799 * keyboard.c (debug-on-event): New variable.
12800 (handle_user_signal): Break into debugger when debug-on-event
12801 matches the current signal symbol.
12803 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12805 * alloc.c (check_sblock, check_string_bytes)
12806 (check_string_free_list): Convert to standard C.
12808 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12810 * w32.c (emacs_gnutls_push): Fix typo.
12812 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12814 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12815 "cast to pointer from integer of different size".
12817 Improve doprnt and its use in verror. (Bug#8545)
12818 * doprnt.c (doprnt): Document the set of format control sequences
12819 supported by the function. Use SAFE_ALLOCA instead of always
12822 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12823 is one byte too soon. Don't use xrealloc; instead xfree and
12826 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12828 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12831 * gnutls.c: Renamed global_initialized to
12832 gnutls_global_initialized. Added internals for the
12833 :verify-hostname-error, :verify-error, and :verify-flags
12834 parameters of `gnutls-boot' and documented those parameters in the
12835 docstring. Start callback support.
12836 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12837 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12838 on error. Return error code.
12839 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12840 (emacs_gnutls_read): Likewise.
12841 (Fgnutls_boot): Return handshake error code.
12842 (emacs_gnutls_handle_error): New function.
12843 (wsaerror_to_errno): Likewise.
12845 * w32.h (emacs_gnutls_pull): Add prototype.
12846 (emacs_gnutls_push): Likewise.
12848 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12849 (emacs_gnutls_push): Likewise.
12851 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12853 * process.c (wait_reading_process_output): Check if GnuTLS
12854 buffered some data internally if no FDs are set for TLS
12857 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12858 (LIBS): Link to USER_LIBS.
12859 ($(BLD)/gnutls.$(0)): New target.
12861 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12863 * xdisp.c (handle_single_display_spec): Rename the
12864 display_replaced_before_p argument into display_replaced_p, to
12865 make it consistent with the commentary. Fix typos in the
12868 * textprop.c (syms_of_textprop): Remove dead code.
12869 (copy_text_properties): Delete obsolete commentary about an
12870 interface that was deleted long ago. Fix typos in the description
12873 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12874 to changes in oldXMenu/XMenu.h from 2011-04-16.
12875 <menu_help_message, prev_menu_help_message>: Constify.
12876 (IT_menu_make_room): menu->help_text is now `const char **';
12879 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12880 to changes in oldXMenu/XMenu.h from 2011-04-16.
12881 (struct XMenu): Declare `help_text' `const char **'.
12883 * xfaces.c <Qunspecified>: Make extern again.
12885 * syntax.c: Include sys/types.h before including regex.h, as
12888 * doc.c (get_doc_string): Improve the format passed to `error'.
12890 * doprnt.c (doprnt): Improve commentary.
12892 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12894 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12897 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12898 changes in globals.h immediately force recompilation.
12899 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12900 $(CURDIR)/s/ms-w32.h.
12901 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12903 * character.c (Fchar_direction): Function deleted.
12904 (syms_of_character): Don't defsubr it.
12905 <char-direction-table>: Deleted.
12907 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12909 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12910 * doprnt.c: Include limits.h.
12911 (SIZE_MAX): New macro.
12912 (doprnt): Return a size_t value. 2nd arg is now size_t.
12913 Many local variables are now size_t instead of int or unsigned.
12914 Improve overflow protection. Support `l' modifier for integer
12915 conversions. Support %l conversion. Don't assume an EMACS_INT
12916 argument for integer conversions and for %c.
12918 * lisp.h (doprnt): Restore prototype.
12920 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12921 $(SRC)/character.h.
12923 * Makefile.in (base_obj): Add back doprnt.o.
12925 * deps.mk (doprnt.o): Add back prerequisites.
12926 (callint.o): Depend on character.h.
12928 * eval.c (internal_lisp_condition_case): Include the handler
12929 representation in the error message.
12930 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12931 when breaking from the loop.
12933 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12935 * callint.c (Fcall_interactively): When displaying error message
12936 about invalid control letter, pass the character's codepoint, not
12937 a pointer to its multibyte form. Improve display of the character
12938 in octal and display also its hex code.
12940 * character.c (char_string): Use %x to display the (unsigned)
12941 codepoint of an invalid character, to avoid displaying a bogus
12944 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12945 `error', not SYMBOL_NAME itself.
12947 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12948 character arguments to `error'.
12950 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12951 to `error' in error message about FINAL_CHAR argument. Make sure
12952 FINAL_CHAR is a character, and use %c when it is passed as
12953 argument to `error'.
12955 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12957 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12959 * w32.c: Include <time.h>.
12960 (sys_localtime): New function.
12962 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12964 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12966 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12968 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12970 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12971 zombies (Bug#8467).
12973 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12975 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12976 gl_state.e_property when gl_state.object is Qt.
12978 * insdel.c (make_gap_larger): Remove limitation of buffer size
12981 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12983 * xdisp.c (lookup_glyphless_char_display)
12984 (produce_glyphless_glyph): Handle cons cell entry in
12985 glyphless-char-display.
12986 (Vglyphless_char_display): Document it.
12988 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12989 glyphless-char-display.
12991 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12993 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12995 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12997 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12998 definition for no-X builds.
13000 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
13002 Static checks with GCC 4.6.0 and non-default toolkits.
13004 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13006 * process.c (keyboard_bit_set): Define only if SIGIO.
13007 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13008 (send_process): Repair possible setjmp clobbering.
13010 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13012 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13014 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13016 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13017 Define only if needed.
13019 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13020 by pacifying GCC about it. Maybe it's time to retire it?
13021 * xfaces.c (USG, __TIMEVAL__): Likewise.
13023 * dispextern.h (struct redisplay_interface): Rename param
13024 to avoid shadowing.
13025 * termhooks.h (struct terminal): Likewise.
13026 * xterm.c (xembed_send_message): Likewise.
13028 * insdel.c (make_gap_smaller): Define only if
13029 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13031 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13034 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13035 so that we aren't warned about unused symbols.
13037 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13039 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
13041 * xfns.c (x_real_positions): Mark locals as initialized.
13043 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13045 * xterm.c: Fix problems found by static analysis with other toolkits.
13046 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
13047 (x_dispatch_event): Declare static if USE_GTK, and
13048 define if USE_GTK || USE_X_TOOLKIT.
13049 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
13050 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
13051 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13052 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
13054 * xmenu.c (menu_help_callback): Pointer type fixes.
13055 Use const pointers when pointing at readonly data. Avoid pointer
13056 signedness clashes.
13057 (FALSE): Remove unused macro.
13058 (update_frame_menubar): Remove unused decl.
13060 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13062 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13063 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13064 (single_menu_item): Rename local to avoid shadowing.
13066 * keyboard.c (make_lispy_event): Remove unused local var.
13068 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13069 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13071 * bitmaps: Change bitmaps from unsigned char back to the X11
13072 compatible char. Avoid the old compiler warnings about
13073 out-of-range initializers by using, for example, '\xab' rather
13076 * xgselect.c (xgselect_initialize): Check vs interface
13077 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13079 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13081 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13082 to read-only memory.
13084 * fns.c (vector): Remove; this old hack is no longer needed.
13086 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
13088 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
13090 * xrdb.c (x_load_resources): Omit unused local.
13092 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
13093 (x_window): Rename locals to avoid shadowing.
13094 (USG): Use the kludged USG macro, to pacify gcc.
13096 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
13097 (x_term_init): Remove local to avoid shadowing.
13099 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
13101 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13102 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13104 2011-04-16 Eli Zaretskii <eliz@gnu.org>
13106 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13108 Fix regex.c, syntax.c and friends for buffers > 2GB.
13109 * syntax.h (struct gl_state_s): Declare character position members
13112 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13114 * textprop.c (verify_interval_modification, interval_of):
13115 Declare arguments EMACS_INT.
13117 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13120 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13122 * indent.c (Fvertical_motion): Local variable it_start is now
13125 * regex.c (re_match, re_match_2, re_match_2_internal)
13126 (bcmp_translate, regcomp, regexec, print_double_string)
13127 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13128 (re_compile_pattern, re_exec): Declare arguments and local
13129 variables `size_t' and `ssize_t' and return values `regoff_t', as
13131 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13132 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13133 <compile_stack_type>: `size' and `avail' are now `size_t'.
13135 * regex.h <regoff_t>: Use ssize_t, not int.
13136 (re_search, re_search_2, re_match, re_match_2): Arguments that
13137 specify buffer/string position and length are now ssize_t and
13138 size_t. Return type is regoff_t.
13140 2011-04-16 Ben Key <bkey76@gmail.com>
13142 * nsfont.m: Fixed bugs in ns_get_family and
13143 ns_descriptor_to_entity that were caused by using free to
13144 deallocate memory blocks that were allocated by xmalloc (via
13145 xstrdup). This caused Emacs to crash when compiled with
13146 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13147 --enable-checking=xmallocoverrun). xfree is now used to
13148 deallocate these memory blocks.
13150 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
13152 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13154 emacs_write: Accept and return EMACS_INT for sizes.
13155 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13157 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13158 Accept and return EMACS_INT.
13159 (emacs_gnutls_write): Return the number of bytes written on
13161 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
13162 (emacs_read, emacs_write): Remove check for negative size, as the
13163 Emacs source code has been audited now.
13164 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13165 (emacs_read, emacs_write): Use it.
13166 * process.c (send_process): Adjust to the new signatures of
13167 emacs_write and emacs_gnutls_write. Do not attempt to store
13168 a byte offset into an 'int'; it might overflow.
13169 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
13171 * sound.c: Don't assume sizes fit in 'int'.
13172 (struct sound_device.period_size, alsa_period_size):
13173 Return EMACS_INT, not int.
13174 (struct sound_device.write, vox_write, alsa_write):
13175 Accept EMACS_INT, not int.
13176 (wav_play, au_play): Use EMACS_INT to store sizes and to
13177 record read return values.
13179 2011-04-15 Ben Key <bkey76@gmail.com>
13181 * keyboard.c (Qundefined): Don't declare static since it is used
13183 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13184 static since they are used in nsfont.m.
13186 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13188 * process.c (Qprocessp): Don't declare static.
13189 * lisp.h (Qprocessp): Declare again.
13191 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
13193 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13195 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13197 Improve C-level modularity by making more things 'static'.
13199 Don't publish debugger-only interfaces to other modules.
13200 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13201 (verify_bytepos, count_markers): Move decls to the only modules
13203 * region-cache.h (pp_cache): Likewise.
13204 * window.h (check_all_windows): Likewise.
13205 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13207 * sysdep.c (croak): Now static, if
13208 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13209 * syssignal.h (croak): Declare only if not static.
13211 * alloc.c (refill_memory_reserve): Now static if
13212 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13213 * lisp.h (refill_memory_reserve): Declare only if not static.
13215 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13216 Define only if USE_LUCID.
13218 * xrdb.c (x_customization_string, x_rm_string): Now static.
13220 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13221 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13223 * xdisp.c (draw_row_with_mouse_face): Now static.
13224 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13226 * window.h (check_all_windows): Mark externally visible.
13228 * window.c (window_deletion_count): Now static.
13230 * undo.c: Make symbols static if they're not exported.
13231 (last_undo_buffer, last_boundary_position, pending_boundary):
13234 * textprop.c (interval_insert_behind_hooks): Now static.
13235 (interval_insert_in_front_hooks): Likewise.
13237 * term.c: Make symbols static if they're not exported.
13238 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13239 (max_frame_lines, tty_set_terminal_modes):
13240 (tty_reset_terminal_modes, tty_turn_off_highlight):
13241 (get_tty_terminal): Now static.
13242 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13243 * termhooks.h (term_mouse_moveto): Do not declare if
13244 HAVE_WINDOW_SYSTEM.
13245 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13246 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13248 * sysdep.c: Make symbols static if they're not exported.
13249 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13251 (sigprocmask_set, full_mask): Remove; unused.
13252 (wait_debugging): Mark as visible.
13253 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13254 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13256 * syntax.c (syntax_temp): Define only if !__GNUC__.
13258 * sound.c (current_sound_device, current_sound): Now static.
13260 * search.c (searchbufs, searchbuf_head): Now static.
13262 * scroll.c (scroll_cost): Remove; unused.
13263 * dispextern.h (scroll_cost): Remove decl.
13265 * region-cache.h (pp_cache): Mark as externally visible.
13267 * process.c: Make symbols static if they're not exported.
13268 (process_tick, update_tick, create_process, chan_process):
13269 (Vprocess_alist, proc_buffered_char, datagram_access):
13270 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13271 (deactivate_process): Mark defn as static, as well as decl.
13272 * lisp.h (create_process): Remove decl.
13273 * process.h (chan_process, Vprocess_alist): Remove decls.
13275 * print.c: Make symbols static if they're not exported.
13276 (print_depth, new_backquote_output, being_printed, print_buffer):
13277 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13278 (print_interval, print_number_index, initial_stderr_stream):
13280 * lisp.h (Fprinc): Remove decl.
13281 (debug_output_compilation_hack): Mark as externally visible.
13283 * sysdep.c (croak): Move decl from here to syssignal.h.
13284 * syssignal.h (croak): Put it here, so the API can be checked when
13285 'croak' is called from dissociate_if_controlling_tty.
13287 * minibuf.c: Make symbols static if they're not exported.
13288 (minibuf_save_list, choose_minibuf_frame): Now static.
13289 * lisp.h (choose_minibuf_frame): Remove decl.
13291 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13293 * lread.c: Make symbols static if they're not exported.
13294 (read_objects, initial_obarray, oblookup_last_bucket_number):
13296 (make_symbol): Remove; unused.
13297 * lisp.h (initial_obarray, make_symbol): Remove decls.
13299 * keyboard.c: Make symbols static if they're not exported.
13300 (single_kboard, recent_keys_index, total_keys, recent_keys):
13301 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13302 (this_single_command_key_start, echoing, last_auto_save):
13303 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13304 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13305 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13306 (Vlispy_mouse_stem, double_click_count):
13308 (force_auto_save_soon): Define only if SIGDANGER.
13309 (ignore_mouse_drag_p): Now static if
13310 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13311 (print_help): Remove; unused.
13312 (stop_character, last_timer_event): Mark as externally visible.
13313 * keyboard.h (ignore_mouse_drag_p): Declare only if
13314 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13315 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13316 * lisp.h (echoing): Remove decl.
13317 (force_auto_save_soon): Declare only if SIGDANGER.
13318 * xdisp.c (redisplay_window): Simplify code, to make it more
13319 obvious that ignore_mouse_drag_p is not accessed if !defined
13320 USE_GTK && !defined HAVE_NS.
13322 * intervals.c: Make symbols static if they're not exported.
13323 (merge_properties_sticky, merge_interval_right, delete_interval):
13325 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13327 * insdel.c: Make symbols static if they're not exported.
13328 However, leave prepare_to_modify_buffer alone. It's never
13329 called from outside this function, but that appears to be a bug.
13330 (combine_after_change_list, combine_after_change_buffer):
13331 (adjust_after_replace, signal_before_change): Now static.
13332 (adjust_after_replace_noundo): Remove; unused.
13333 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
13334 (signal_before_change): Remove decls.
13336 * indent.c (val_compute_motion, val_vmotion): Now static.
13338 * image.c: Make symbols static if they're not exported.
13339 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13341 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13342 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13344 * fringe.c (standard_bitmaps): Now static.
13345 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13347 * frame.c: Make symbols static if they're not exported.
13348 (x_report_frame_params, make_terminal_frame): Now static.
13349 (get_frame_param): Now static, unless HAVE_NS.
13350 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13351 (x_get_resource_string): Remove; not used.
13352 * frame.h (make_terminal_frame, x_report_frame_params):
13353 (x_get_resource_string); Remove decls.
13354 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13355 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13357 * font.c, fontset.c: Make symbols static if they're not exported.
13358 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13359 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13360 * font.c (font_close_object): Now static.
13361 * font.h (font_close_object): Remove.
13362 * fontset.c (FONTSET_OBJLIST): Remove.
13363 (free_realized_fontset) #if-0 the body, which does nothing.
13364 (face_suitable_for_char_p): #if-0, as it's never called.
13365 * fontset.h (face_suitable_for_char_p): Remove decl.
13366 * xfaces.c (face_at_string_position):
13367 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
13368 since 0 is always ASCII.
13370 * fns.c (weak_hash_tables): Now static.
13372 * fileio.c: Make symbols static if they're not exported.
13373 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13374 (Vwrite_region_annotation_buffers): Now static.
13376 * eval.c: Make symbols static if they're not exported.
13377 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13378 * lisp.h (backtrace_list): Remove decl.
13380 * emacs.c: Make symbols static if they're not exported.
13381 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13382 (fatal_error_code, fatal_error_signal_hook, standard_args):
13384 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13385 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13386 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13387 * lisp.h (fatal_error_signal_hook): Remove decl.
13388 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13390 * editfns.c: Move a (normally-unused) function to its only use.
13391 * editfns.c, lisp.h (get_operating_system_release): Remove.
13392 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13393 worth the hassle of breaking this out.
13395 * xterm.c: Make symbols static if they're not exported.
13396 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13397 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13398 (x_destroy_window, x_delete_display):
13400 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13401 (x_mouse_leave): Remove; unused.
13402 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13403 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13404 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13406 (x_mouse_leave): Declare only if WINDOWSNT.
13407 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13408 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13411 * ftxfont.c: Make symbols static if they're not exported.
13412 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13414 * font.h (ftxfont_driver): Likewise.
13416 * xfns.c: Make symbols static if they're not exported.
13417 (x_last_font_name, x_display_info_for_name):
13418 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13419 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13420 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13421 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13422 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13423 (last_show_tip_args): Now static.
13424 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13425 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13426 (x_screen_planes): Remove; unused.
13427 * dispextern.h (x_screen_planes): Remove decl.
13429 * dispnew.c: Make symbols static if they're not exported.
13430 * dispextern.h (redraw_garbaged_frames, scrolling):
13431 (increment_row_positions): Remove.
13432 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13433 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13435 (redraw_garbaged_frames): Remove; unused.
13437 * xfaces.c: Make symbols static if they're not exported.
13438 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13440 * xterm.h (defined_color): Remove decls.
13441 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13442 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13443 (menu_face_changed_default, defined_color, free_realized_face):
13444 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13445 (ascii_face_of_lisp_face): Remove; unused.
13447 * xdisp.c: Make symbols static if they're not exported.
13448 * dispextern.h (scratch_glyph_row, window_box_edges):
13449 (glyph_to_pixel_coords, set_cursor_from_row):
13450 (get_next_display_element, set_iterator_to_next):
13451 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13452 (show_mouse_face): Remove decls
13453 * frame.h (message_buf_print): Likewise.
13454 * lisp.h (pop_message, set_message, check_point_in_composition):
13456 * xterm.h (set_vertical_scroll_bar): Likewise.
13457 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13458 (message_buf_print, scratch_glyph_row, displayed_buffer):
13459 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13460 (get_next_display_element, show_mouse_face, window_box_edges):
13461 (frame_to_window_pixel_xy, check_point_in_composition):
13462 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13463 (glyph_to_pixel_coords): Remove; unused.
13465 * dired.c (file_name_completion): Now static.
13467 * dbusbind.c (xd_in_read_queued_messages): Now static.
13469 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13470 * data.c (circular_list_error): Remove.
13472 * commands.h (last_point_position, last_point_position_buffer):
13473 (last_point_position_window): Remove decls.
13474 * keyboard.c: Make these variables static.
13476 * coding.h (coding, code_convert_region, encode_coding_gap):
13478 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13479 (iso_code_class, detect_coding, code_convert_region): Now static.
13480 (encode_coding_gap): Remove; unused.
13482 * chartab.c (chartab_chars, chartab_bits): Now static.
13484 * charset.h (charset_iso_8859_1): Remove decl.
13485 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13488 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13489 * ccl.c (Vccl_program_table): Now static.
13490 (check_ccl_update): Remove; unused.
13492 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13493 * category.h: ... from here.
13494 * category.c (check_category_table, set_category_set): Now static.
13496 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13497 * lisp.h: Remove these decls.
13499 * buffer.c (buffer_count): Remove unused var.
13501 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13502 so that it's not optimized away.
13503 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13504 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13505 exported only to the debugger.
13507 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
13508 * atimer.h (run_all_atimers): Remove; not exported.
13510 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13511 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13512 was inaccessible from Lisp.
13513 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13514 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13516 alloc.c: Import and export fewer symbols, and remove unused items.
13517 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13519 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13520 it's not optimized away by whole-program optimization.
13521 (message_enable_multibyte, free_misc): Remove.
13522 (catchlist, handlerlist, mark_backtrace):
13523 Declare only if BYTE_MARK_STACK.
13524 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13525 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13526 (message_enable_multibyte): Remove decl.
13527 (free_misc, interval_free_list, float_block, float_block_index):
13528 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13529 (cons_free_list, last_marked_index):
13531 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13532 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13533 (mark_backtrace): Define only if BYTE_MARK_STACK.
13534 * xdisp.c (message_enable_multibyte): Now static.
13536 Declare Lisp_Object Q* variables to be 'static' if not exported.
13537 This makes it easier for human readers (and static analyzers)
13538 to see whether these variables are used from other modules.
13539 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13540 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13541 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13542 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13543 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13544 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13545 * xmenu.c, xselect.c:
13546 Declare Q* vars static if they are not used in other modules.
13547 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13548 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13549 Remove decls of unexported vars.
13550 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13552 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13554 Make Emacs functions such as Fatom 'static' by default.
13555 This makes it easier for human readers (and static analyzers)
13556 to see whether these functions can be called from other modules.
13557 DEFUN now defines a static function. To make the function external
13558 so that it can be used in other C modules, use the new macro DEFUE.
13559 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13560 (Finit_image_library):
13561 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13562 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13563 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13564 Remove decls, since these functions are now static.
13565 (Funintern, Fget_internal_run_time): New decls, since these functions
13566 were already external.
13568 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13569 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13570 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13571 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13572 * keyboard.c, keymap.c, lread.c:
13573 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13574 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13575 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13576 Mark functions with DEFUE instead of DEFUN,
13577 if they are used in other modules.
13578 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13579 decls for now-static functions.
13580 * buffer.h (Fdelete_overlay): Remove decl.
13581 * callproc.c (Fgetenv_internal): Mark as internal.
13582 * composite.c (Fremove_list_of_text_properties): Remove decl.
13583 (Fcomposition_get_gstring): New forward static decl.
13584 * composite.h (Fcomposite_get_gstring): Remove decl.
13585 * dired.c (Ffile_attributes): New forward static decl.
13586 * doc.c (Fdocumntation_property): New forward static decl.
13587 * eval.c (Ffetch_bytecode): New forward static decl.
13588 (Funintern): Remove extern decl; now in .h file where it belongs.
13589 * fileio.c (Fmake_symbolic_link): New forward static decl.
13590 * image.c (Finit_image_library): New forward static decl.
13591 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13592 * intervals.h (Fprevious_property_change):
13593 (Fremove_list_of_text_properties): Remove decls.
13594 * keyboard.c (Fthis_command_keys): Remove decl.
13595 (Fcommand_execute): New forward static decl.
13596 * keymap.c (Flookup_key): New forward static decl.
13597 (Fcopy_keymap): Now static.
13598 * keymap.h (Flookup_key): Remove decl.
13599 * process.c (Fget_process): New forward static decl.
13600 (Fprocess_datagram_address): Mark as internal.
13601 * syntax.c (Fsyntax_table_p): New forward static decl.
13602 (skip_chars): Remove duplicate decl.
13603 * textprop.c (Fprevious_property_change): New forward static decl.
13604 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13606 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13607 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13609 * editfns.c (Fformat): Remove unreachable code.
13611 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13613 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13616 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13618 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13619 when at ZV. (Bug#8487)
13621 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13623 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13625 * keyboard.c (parse_tool_bar_item): Likewise.
13626 * sound.c (sound_cleanup, alsa_close): Likewise.
13627 * termcap.c (tgetent): Likewise.
13628 * xfns.c (x_default_font_parameter): Likewise.
13629 * xsettings.c (read_and_apply_settings): Likewise.
13631 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13632 (overrun_check_free): Protoize.
13634 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13636 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13637 since callers should never pass a negative size.
13638 Change the signature to match that of plain 'read' and 'write'; see
13639 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13640 * lisp.h: Update prototypes of emacs_write and emacs_read.
13642 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13644 * xdisp.c (redisplay_window): Don't try to determine the character
13645 position of the scroll margin if the window start point w->startp
13646 is outside the buffer's accessible region. (Bug#8468)
13648 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13650 Fix write-region and its subroutines for buffers > 2GB.
13651 * fileio.c (a_write, e_write): Modify declaration of arguments and
13652 local variables to support buffers larger than 2GB.
13653 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13655 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13656 argument, local variables, and return value.
13658 * lisp.h: Update prototypes of emacs_write and emacs_read.
13660 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13662 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13664 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13666 Fix more problems found by GCC 4.6.0's static checks.
13668 * xdisp.c (vmessage): Use a better test for character truncation.
13670 * charset.c (load_charset_map): <, not <=, for optimization,
13671 and to avoid potential problems with integer overflow.
13672 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13673 * casetab.c (set_identity, shuffle): Likewise.
13674 * editfns.c (Fformat): Likewise.
13675 * syntax.c (skip_chars): Likewise.
13677 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13678 This also lets GCC 4.6.0 generate slightly better loop code.
13680 * callint.c (Fcall_interactively): <, not <=, for optimization.
13681 (Fcall_interactively): Count the number of arguments produced,
13682 not the number of arguments given. This is simpler and lets GCC
13683 4.6.0 generate slightly better code.
13685 * ftfont.c: Distingish more carefully between FcChar8 and char.
13686 The previous code passed unsigned char * to a functions like
13687 strlen and xstrcasecmp that expect char *, which does not
13688 conform to the C standard.
13689 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13690 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13691 char * when the C standard requires it.
13693 * keyboard.c (read_char): Remove unused var.
13695 * eval.c: Port to Windows vsnprintf (Bug#8435).
13696 Include <limits.h>.
13697 (SIZE_MAX): Define if the headers do not.
13698 (verror): Do not give up if vsnprintf returns a negative count.
13699 Instead, grow the buffer. This ports to Windows vsnprintf, which
13700 does not conform to C99. Problem reported by Eli Zaretskii.
13701 Also, simplify the allocation scheme, by avoiding the need for
13702 calling realloc, and removing the ALLOCATED variable.
13704 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13706 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13707 But keep the doprint source code for now, as we might revamp it
13708 and use it again (Bug#8435).
13709 * lisp.h (doprnt): Remove.
13710 * Makefile.in (base_obj): Remove doprnt.o.
13711 * deps.mk (doprnt.o): Remove.
13713 error: Print 32- and 64-bit integers portably (Bug#8435).
13714 Without this change, on typical 64-bit hosts error ("...%d...", N)
13715 was used to print both 32- and 64-bit integers N, which relied on
13716 undefined behavior.
13717 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13718 * lisp.h (error, verror): Mark as printf-like functions.
13719 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13720 Report overflow in size calculations when allocating printf buffer.
13721 Do not truncate output string at its first null byte.
13722 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13723 Truncate the output at a character boundary, since vsnprintf does not
13725 * charset.c (check_iso_charset_parameter): Convert internal
13726 character to string before calling 'error', since %c now has the
13728 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13729 overflow when computing char to be passed to 'error'. Do not
13730 pass Lisp_Object to 'error'; pass the integer instead.
13731 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13732 formatted with plain %d.
13734 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13736 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13738 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13740 * xterm.c (x_catch_errors): Remove duplicate declaration.
13742 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13744 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13746 2011-04-10 Jim Meyering <meyering@redhat.com>
13748 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13749 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13750 return ssize_t not "int", and use size_t as the buffer length.
13751 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13752 * gnutls.h: Update declarations.
13753 * process.c (read_process_output): Use ssize_t, to match.
13754 (send_process): Likewise.
13756 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13758 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13760 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13762 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13763 Use unsigned char, to match FcChar8 type definition.
13765 * xterm.c (handle_one_xevent):
13766 * xmenu.c (create_and_show_popup_menu):
13767 * xselect.c (x_decline_selection_request)
13768 (x_reply_selection_request): Avoid type-punned deref of X events.
13770 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13772 Fix some uses of `int' instead of EMACS_INT.
13773 * search.c (string_match_1, fast_string_match)
13774 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13775 (scan_buffer, find_next_newline_no_quit)
13776 (find_before_next_newline, search_command, Freplace_match)
13777 (Fmatch_data): Make some `int' variables be EMACS_INT.
13779 * xdisp.c (display_count_lines): 3rd argument and return value now
13780 EMACS_INT. All callers changed.
13781 (pint2hrstr): Last argument is now EMACS_INT.
13783 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13784 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13785 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13786 (decode_coding_utf_16, decode_coding_emacs_mule)
13787 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13788 (decode_coding_ccl, decode_coding_charset)
13789 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13790 (decode_coding_iso_2022, decode_coding_emacs_mule)
13791 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13792 <char_offset, last_offset>: Declare EMACS_INT.
13793 (encode_coding_utf_8, encode_coding_utf_16)
13794 (encode_coding_emacs_mule, encode_invocation_designation)
13795 (encode_designation_at_bol, encode_coding_iso_2022)
13796 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13797 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13799 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13800 (encode_invocation_designation): Last argument P_NCHARS is now
13802 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13803 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13805 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13808 * ccl.c (Fccl_execute_on_string): Declare some variables
13811 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13813 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13815 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13817 * process.c (Fformat_network_address): Doc fix.
13819 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13821 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13823 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13825 * keyboard.c (read_char): Call Lisp function help-form-show,
13826 instead of using internal_with_output_to_temp_buffer.
13827 (Qhelp_form_show): New var.
13828 (syms_of_keyboard): Use DEFSYM macro.
13830 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13832 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13834 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13836 * process.c (Flist_processes): Remove to Lisp.
13837 (list_processes_1): Delete.
13839 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13841 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13843 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13845 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13847 Fix more problems found by GCC 4.6.0's static checks.
13849 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13851 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13853 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13855 * xdisp.c (vmessage): Mark as a printf-like function.
13857 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13859 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13861 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13862 printf-like functions.
13863 (tiff_load): Add casts to remove these marks before passing them
13864 to system-supplied API.
13866 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13868 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13869 This avoids several warnings with gcc -Wstrict-overflow.
13870 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13871 directly, rather than having caller test rule sign. This avoids
13872 some unnecessary tests.
13873 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13874 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13875 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13877 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13878 (xfont_open): Avoid unnecessary tests.
13880 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13882 * composite.h, composite.c (composition_gstring_put_cache):
13883 Use EMACS_INT, not int, for length.
13885 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13886 breaking out part of COMPOSITION_DECODE_RULE.
13887 (COMPOSITION_DECODE_RULE): Use it.
13888 * composite.c (get_composition_id): Remove unused local vars,
13889 by using the new macro.
13891 * textprop.c (set_text_properties_1): Change while to do-while,
13892 since the condition is always true at first.
13894 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13895 (interval_deletion_adjustment): Return unsigned value.
13898 * process.c (list_processes_1, create_pty, read_process_output):
13899 (exec_sentinel): Remove vars that were set but not used.
13900 (create_pty): Remove unnecessary "volatile"s.
13901 (Fnetwork_interface_info): Avoid possibility of int overflow.
13902 (read_process_output): Do adaptive read buffering even if carryover.
13903 (read_process_output): Simplify nbytes computation if buffered.
13905 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13907 * syntax.c (scan_words): Remove var that was set but not used.
13908 (update_syntax_table): Use unsigned instead of int.
13910 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13911 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13912 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13914 * print.c (print_error_message): Avoid int overflow.
13916 * font.c (font_list_entities): Redo for clarity,
13917 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13919 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13920 (font_score): Avoid potential overflow in diff calculation.
13922 * fns.c (substring_both): Remove var that is set but not used.
13923 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13925 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13927 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13928 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13929 can always succeed if overflow has undefined behavior.
13931 * search.c (boyer_moore, wordify): Remove vars set but not used.
13932 (wordify): Omit three unnecessary tests.
13934 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13935 All callers changed. This avoids the need for an unused var.
13937 * casefiddle.c (casify_region): Remove var that is set but not used.
13939 * dired.c (file_name_completion): Remove var that is set but not used.
13941 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13943 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13944 (Finsert_file_contents): Remove unnecessary code checking fd.
13946 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13947 Check for integer overflow on size calculations.
13949 * buffer.c (Fprevious_overlay_change): Remove var that is set
13952 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13953 Remove vars that are set but not used.
13954 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13955 (timer_check_2): Mark vars as initialized.
13957 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13959 * image.c (lookup_image): Remove var that is set but not used.
13960 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13962 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13963 that are set but not used.
13965 * xfns.c (make_invisible_cursor): Don't return garbage
13966 if XCreateBitmapFromData fails (Bug#8410).
13968 * xselect.c (x_get_local_selection, x_handle_property_notify):
13969 Remove vars that are set but not used.
13971 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13972 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13974 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13975 Remove var that is set but not used.
13976 (scroll_bar_windows_size): Now size_t, not int.
13977 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13978 Check for overflow.
13980 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13981 (map_tty_color) [!defined MSDOS]: Likewise.
13983 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13985 * coding.c: Remove vars that are set but not used.
13986 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13987 All callers changed.
13988 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13989 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13990 (decode_coding_charset): Remove vars that are set but not used.
13992 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13993 that is set but not used.
13995 * print.c (print_object): Remove var that is set but not used.
13997 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13998 The gnulib version avoids calling malloc in the usual case,
13999 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14000 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14001 * filelock.c (current_lock_owner): Likewise.
14002 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14003 * sysdep.c: Include allocator.h, careadlinkat.h.
14004 (emacs_no_realloc_allocator): New static constant.
14005 (emacs_readlink): New function.
14006 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14007 ../lib/careadlinkat.h.
14009 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14011 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14012 first non-nil return value).
14014 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14016 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14017 if not defined (Bug#8403).
14019 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
14021 * xdisp.c (display_count_lines): Remove parameter `start',
14022 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14023 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14024 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14025 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14026 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14027 and thereabouts. All callers changed.
14028 (get_per_char_metric): Remove parameter `f', unused since
14029 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14031 2011-04-02 Jim Meyering <meyering@redhat.com>
14033 do not dereference NULL upon failed strdup
14034 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14035 (ns_get_family): Likewise.
14037 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
14039 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14041 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14043 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14046 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14048 Add lexical binding.
14050 * window.c (Ftemp_output_buffer_show): New fun.
14051 (Fsave_window_excursion):
14052 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14054 * lread.c (lisp_file_lexically_bound_p): New function.
14055 (Fload): Bind Qlexical_binding.
14056 (readevalloop): Remove `evalfun' arg.
14057 Bind Qinternal_interpreter_environment.
14058 (Feval_buffer): Bind Qlexical_binding.
14059 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14061 (syms_of_lread): Declare `lexical-binding'.
14063 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14065 * keyboard.c (eval_dyn): New fun.
14066 (menu_item_eval_property): Use it.
14068 * image.c (parse_image_spec): Use Ffunctionp.
14070 * fns.c (concat, mapcar1): Accept byte-code-functions.
14072 * eval.c (Fsetq): Handle lexical vars.
14073 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14074 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14075 (FletX, Flet): Obey lexical binding.
14076 (Fcommandp): Handle closures.
14077 (Feval): New `lexical' arg.
14078 (eval_sub): New function extracted from Feval. Use it almost
14079 everywhere where Feval was used. Look up vars in lexical env.
14081 (Ffunctionp): Move from subr.el.
14082 (Ffuncall): Handle closures.
14083 (apply_lambda): Remove `eval_flags'.
14084 (funcall_lambda): Handle closures and new byte-code-functions.
14085 (Fspecial_variable_p): New function.
14086 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14087 but without exporting it to Lisp.
14089 * doc.c (Fdocumentation, store_function_docstring):
14090 * data.c (Finteractive_form): Handle closures.
14092 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14095 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14097 (exec_byte_code): New function extracted from Fbyte_code to handle new
14098 calling convention for byte-code-functions. Add new byte-codes.
14100 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
14102 * alloc.c (Fmake_symbol): Init new `declared_special' field.
14104 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
14106 * xdisp.c (redisplay_internal): Fix prototype.
14108 2011-03-31 Eli Zaretskii <eliz@gnu.org>
14110 * xdisp.c (SCROLL_LIMIT): New macro.
14111 (try_scrolling): Use it when setting scroll_limit.
14112 Limit scrolling to 100 screen lines.
14113 (redisplay_window): Even when falling back on "recentering",
14114 position point in the window according to scroll-conservatively,
14115 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14117 (try_scrolling): When point is above the window, allow searching
14118 as far as scroll_max, or one screenful, to compute vertical
14119 distance from PT to the scroll margin position. This prevents
14120 try_scrolling from unnecessarily failing when
14121 scroll-conservatively is set to a value slightly larger than the
14122 window height. Clean up the case of PT below the margin at bottom
14123 of window: scroll_max can no longer be INT_MAX. When aggressive
14124 scrolling is in use, don't let point enter the opposite scroll
14125 margin as result of the scroll.
14126 (syms_of_xdisp) <scroll-conservatively>: Document the
14127 threshold of 100 lines for never-recentering scrolling.
14129 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
14131 * dispextern.h (move_it_by_lines):
14132 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14133 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14134 (message_log_check_duplicate): Remove parameters `prev_bol' and
14135 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14136 (redisplay_internal): Remove parameter `preserve_echo_area',
14137 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14139 * indent.c (Fvertical_motion):
14140 * window.c (window_scroll_pixel_based, Frecenter):
14141 Don't pass `need_y_p' to `move_it_by_lines'.
14143 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14145 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14146 steal a few bits to be more compact.
14147 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14148 Remove unneeded casts.
14150 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14152 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14154 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14155 binding" message (bug#7967).
14157 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14159 Fix more problems found by GCC 4.6.0's static checks.
14161 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14162 Remove unused local var.
14164 * editfns.c (Fmessage_box): Remove unused local var.
14166 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14167 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14168 Omit unused local vars.
14169 * window.c (shrink_windows): Omit unused local var.
14170 * menu.c (digest_single_submenu): Omit unused local var.
14171 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14172 Omit unused local var.
14174 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14175 Don't assume string length fits in int.
14176 (keyremap_step, read_key_sequence): Use size_t for sizes.
14177 (read_key_sequence): Don't check last_real_key_start redundantly.
14179 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14180 instead of alloca (Bug#8344).
14182 * eval.c (Fbacktrace): Don't assume nargs fits in int.
14183 (Fbacktrace_frame): Don't assume nframes fits in int.
14185 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14187 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14190 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14192 * cm.c (calccost): Turn while-do into do-while, for clarity.
14194 * keyboard.c (syms_of_keyboard): Use the same style as later
14195 in this function when indexing through an array. This also
14196 works around GCC bug 48267.
14198 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14200 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14202 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14203 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14205 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14206 This avoids undefined behavior on integer overflow, and is a bit
14207 more convenient anyway since it is compared to a size_t variable.
14209 Variadic C functions now count arguments with size_t, not int.
14210 This avoids an unnecessary limitation on 64-bit machines, which
14211 caused (substring ...) to crash on large vectors (Bug#8344).
14212 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14213 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
14214 All variadic functions and their callers changed accordingly.
14215 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14216 * data.c (arith_driver, float_arith_driver): Likewise.
14217 * editfns.c (general_insert_function): Likewise.
14218 * eval.c (struct backtrace.nargs, interactive_p)
14219 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14220 (funcall_lambda, mark_backtrace): Likewise.
14221 * fns.c (concat): Likewise.
14222 * frame.c (x_set_frame_parameters): Likewise.
14223 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14224 0 if not found, not -1. All callers changed.
14226 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14227 (stack_copy_size): Now size_t, not int.
14228 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14230 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
14232 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14233 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14234 All callers changed.
14236 * lisp.h (multibyte_char_to_unibyte):
14237 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14238 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14239 * character.h (CHAR_TO_BYTE8):
14240 * cmds.c (internal_self_insert):
14241 * editfns.c (general_insert_function):
14242 * keymap.c (push_key_description):
14243 * search.c (Freplace_match):
14244 * xdisp.c (message_dolog, set_message_1): All callers changed.
14246 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14248 * keyboard.c (safe_run_hook_funcall): New function.
14249 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14250 don't set the hook to nil, but remove the offending function instead.
14251 (Qcommand_hook_internal): Remove, unused.
14252 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14253 Vcommand_hook_internal.
14255 * eval.c (enum run_hooks_condition): Remove.
14256 (funcall_nil, funcall_not): New functions.
14257 (run_hook_with_args): Call each function through a `funcall' argument.
14258 Remove `cond' argument, now redundant.
14259 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14260 (Frun_hook_with_args_until_failure): Adjust accordingly.
14261 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14263 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
14265 * dispextern.h (string_buffer_position): Remove declaration.
14267 * print.c (strout): Remove parameter `multibyte', unused since
14268 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14270 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14271 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14272 All callers changed.
14274 * w32.c (_wsa_errlist): Use braces for struct initializers.
14276 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14277 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14278 All callers changed.
14279 (string_buffer_position): Likewise. Also, make static (it's never
14280 used outside xdisp.c).
14281 (cursor_row_p): Remove parameter `w', unused since
14282 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14283 (decode_mode_spec): Remove parameter `precision', introduced during
14284 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14285 All callers changed.
14287 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14289 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14291 2011-03-27 Anders Lindgren <andlind@gmail.com>
14293 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14294 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14295 (ns_update_auto_hide_menu_bar): New functions.
14296 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14297 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14298 ns_constrain_all_frames.
14299 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14300 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14302 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14304 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14306 2011-03-27 Glenn Morris <rgm@gnu.org>
14308 * syssignal.h: Replace RETSIGTYPE with void.
14309 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14310 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14311 Replace SIGTYPE with void everywhere.
14312 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14313 * s/template.h (SIGTYPE): Remove commented out definition.
14315 2011-03-26 Eli Zaretskii <eliz@gnu.org>
14317 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14318 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14320 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
14322 * w32.c (read_unc_volume): Use parameter `henum', instead of
14323 global variable `wget_enum_handle'.
14325 * keymap.c (describe_vector): Remove parameters `indices' and
14326 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14327 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14329 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14331 * keyboard.c (timer_check): Remove parameter `do_it_now',
14332 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14333 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14334 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14336 * keyboard.c (read_char):
14337 * w32menu.c (w32_menu_display_help):
14338 * xmenu.c (show_help_event, menu_help_callback):
14339 Adjust calls to `show_help_echo'.
14341 * gtkutil.c (xg_maybe_add_timer):
14342 * keyboard.c (readable_events):
14343 * process.c (wait_reading_process_output):
14344 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14346 * insdel.c (adjust_markers_gap_motion):
14347 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14348 (gap_left, gap_right): Don't call it.
14350 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
14352 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14353 incurred during fontification.
14355 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
14357 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14358 (DEFVAR_PER_BUFFER): Don't pass it.
14360 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14361 (scrolling_window): Don't pass it.
14363 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
14365 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14367 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14369 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14370 of variables specific to SELinux and computation of `encoded_absname'.
14372 * image.c (XPutPixel): Remove unused variable `height'.
14374 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14376 * unexw32.c (get_section_info): Remove unused variable `section'.
14378 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14379 (system_process_attributes): Remove unused variable `sess'.
14380 (sys_read): Remove unused variable `err'.
14382 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14383 (w32_wnd_proc): Remove unused variable `isdead'.
14384 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14385 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14386 (x_create_tip_frame): Remove unused variable `tem'.
14388 * w32inevt.c (w32_console_read_socket):
14389 Remove unused variable `no_events'.
14391 * w32term.c (x_draw_composite_glyph_string_foreground):
14392 Remove unused variable `width'.
14394 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
14396 * w32term.c (x_set_glyph_string_clipping):
14397 Don't pass uninitialized region to CombineRgn.
14399 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
14401 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14402 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14403 (Fx_close_connection): Remove unused variable `i'.
14405 * w32font.c (w32font_draw): Return number of glyphs.
14406 (w32font_open_internal): Remove unused variable `i'.
14407 (w32font_driver): Add missing initializer.
14409 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14410 (fill_in_menu): Remove unused variable `items_added'.
14412 * w32term.c (last_mouse_press_frame): Remove static global variable.
14413 (w32_clip_to_row): Remove unused variable `f'.
14414 (x_delete_terminal): Remove unused variable `i'.
14416 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14417 (NOTHING): Remove unused static global variable.
14418 (uniscribe_check_otf): Remove unused variable `table'.
14419 (uniscribe_font_driver): Add missing initializers.
14421 2011-03-23 Julien Danjou <julien@danjou.info>
14423 * term.c (Fsuspend_tty, Fresume_tty):
14424 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14425 * window.c (temp_output_buffer_show):
14426 * insdel.c (signal_before_change):
14427 * frame.c (Fhandle_switch_frame):
14428 * fileio.c (Fdo_auto_save):
14429 * emacs.c (Fkill_emacs):
14430 * editfns.c (save_excursion_restore):
14431 * cmds.c (internal_self_insert):
14432 * callint.c (Fcall_interactively):
14433 * buffer.c (Fkill_all_local_variables):
14434 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14436 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
14437 unconditionally since it does the check itself.
14439 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
14441 Fix more problems found by GCC 4.5.2's static checks.
14443 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14444 the first time through the loop, since we know p0 < p1 then.
14445 This also avoids a gcc -Wstrict-overflow warning.
14447 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14448 leading to a memory leak, possible in functions like
14449 load_charset_map_from_file that can allocate an unbounded number
14450 of objects (Bug#8318).
14452 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14453 that could (at least in theory) be that large.
14455 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14456 This is less likely to overflow, and avoids undefined behavior if
14457 overflow does occur. All callers changed. Use strtoul to scan
14458 for the unsigned long integer.
14459 (pint2hrstr): Simplify and tune code slightly.
14460 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
14462 * scroll.c (do_scrolling): Work around GCC bug 48228.
14463 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14465 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14466 This also avoids a warning with gcc -Wstrict-overflow.
14467 (validate_x_resource_name): Simplify count usage.
14468 This also avoids a warning with gcc -Wstrict-overflow.
14470 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14473 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
14475 * process.c (Fmake_network_process): Use socklen_t, not int,
14476 where POSIX says socklen_t is required in portable programs.
14477 This fixes a porting bug on hosts like 64-bit HP-UX, where
14478 socklen_t is wider than int (Bug#8277).
14479 (Fmake_network_process, server_accept_connection):
14480 (wait_reading_process_output, read_process_output):
14483 * process.c: Rename or move locals to avoid shadowing.
14484 (list_processes_1, Fmake_network_process):
14485 (read_process_output_error_handler, exec_sentinel_error_handler):
14486 Rename or move locals.
14487 (Fmake_network_process): Define label "retry_connect" only if needed.
14488 (Fnetwork_interface_info): Fix pointer signedness.
14489 (process_send_signal): Add cast to avoid pointer signedness problem.
14490 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
14491 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
14493 Make tparam.h and terminfo.c consistent.
14494 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14495 Include tparam.h instead, since it declares them.
14496 * cm.h (PC): Remove extern decl; tparam.h now does this.
14497 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14498 * terminfo.c: Include tparam.h, to check interfaces.
14499 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14500 (tparam): Adjust signature to match interface in tparam.h;
14501 this removes some undefined behavior. Check that outstring and len
14502 are zero, which they always are with Emacs.
14503 * tparam.h (PC, BC, UP): New extern decls.
14505 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
14506 (xftfont_open): Rename locals to avoid shadowing.
14508 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
14509 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14510 (OTF_TAG_SYM): Omit macro if not needed.
14511 (ftfont_list): Remove unused local.
14512 (get_adstyle_property, ftfont_pattern_entity):
14513 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14514 Rename locals to avoid shadowing.
14516 * xfont.c (xfont_list_family): Mark var as initialized.
14518 * xml.c (make_dom): Now static.
14520 * composite.c (composition_compute_stop_pos): Rename local to
14522 (composition_reseat_it): Remove unused locals.
14523 (find_automatic_composition, composition_adjust_point): Likewise.
14524 (composition_update_it): Mark var as initialized.
14525 (find_automatic_composition): Mark vars as initialized,
14526 with a FIXME (Bug#8290).
14528 character.h: Rename locals to avoid shadowing.
14529 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14530 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14531 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14532 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14533 to avoid shadowing.
14535 * textprop.c (property_change_between_p): Remove; unused.
14537 * intervals.c (interval_start_pos): Now static.
14539 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14541 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14542 Rename locals to avoid shadowing.
14544 * sound.c (wav_play, au_play, Fplay_sound_internal):
14545 Fix pointer signedness.
14546 (alsa_choose_format): Remove unused local var.
14547 (wav_play): Initialize a variable to 0, to prevent undefined
14548 behavior (Bug#8278).
14550 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14552 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14554 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14555 clobbering (Bug#8298).
14556 * sysdep.c (sys_subshell): Likewise.
14557 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
14559 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14560 This should get cleaned up, so that child_setup has the
14561 same signature on all platforms.
14563 * callproc.c (call_process_cleanup): Now static.
14564 (relocate_fd): Rename locals to avoid shadowing.
14566 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
14568 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14569 not to be necessary, and produces flickering.
14571 2011-03-20 Glenn Morris <rgm@gnu.org>
14573 * config.in: Remove file.
14575 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
14577 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14578 are now in src/globals.h.
14579 (syms_of_minibuf): Remove spurious & from previous change.
14581 2011-03-20 Leo Liu <sdl.web@gmail.com>
14583 * minibuf.c (completing-read-function): New variable.
14584 (completing-read-default): Rename from completing-read.
14585 (completing-read): Call completing-read-function.
14587 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14589 * xfaces.c (Fx_load_color_file):
14590 Read color file from absolute filename (bug#8250).
14592 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14594 * makefile.w32-in: Update dependencies.
14596 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14598 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14600 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14602 Fix more problems found by GCC 4.5.2's static checks.
14604 * process.c (make_serial_process_unwind, send_process_trap):
14605 (sigchld_handler): Now static.
14607 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14608 That way, the code declares only the vars that it needs.
14609 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14610 * s/cygwin.h (PTY_ITERATION): Likewise.
14611 * s/darwin.h (PTY_ITERATION): Likewise.
14612 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14614 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14615 * process.c (allocate_pty): Don't declare stb unless it's needed.
14617 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14618 (CONSTANTLIM): Remove; unused.
14619 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14620 Define only if needed.
14622 * unexelf.c (unexec): Name an expression,
14623 to avoid gcc -Wbad-function-cast warning.
14624 Use a different way to cause a compilation error if anyone uses
14625 n rather than nn, a way that does not involve shadowing.
14626 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14628 * deps.mk (unexalpha.o): Remove; unused.
14630 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14631 * unexec.h: New file.
14632 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14633 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14634 Depend on unexec.h.
14635 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14636 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14637 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14638 Change as necessary to match prototype in unexec.h.
14640 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14642 (back_comment, skip_chars): Mark vars as initialized.
14644 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14645 Rename locals to avoid shadowing.
14647 * lread.c (read1): Rewrite so as not to use empty "else".
14648 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14650 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14652 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14653 warning when compiling print.c.
14655 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14656 instead of using an uninitialized var.
14657 (font_sort_entities): Mark var as initialized.
14659 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14661 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14662 pointers to constants.
14663 (font_parse_fcname): Remove unused vars.
14664 (font_delete_unmatched): Now static.
14665 (font_get_spec): Remove; unused.
14666 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14667 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14668 Rename or move locals to avoid shadowing.
14670 * fns.c (require_nesting_list, require_unwind): Now static.
14671 (Ffillarray): Rename locals to avoid shadowing.
14673 * floatfns.c (domain_error2): Define only if needed.
14674 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14676 * alloc.c (mark_backtrace): Move decl from here ...
14677 * lisp.h: ... to here, so that it can be checked.
14679 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14680 (Fdefvar): Rewrite so as not to use empty "else".
14681 (lisp_indirect_variable): Name an expression,
14682 to avoid gcc -Wbad-function-cast warning.
14683 (Fdefvar): Rename locals to avoid shadowing.
14685 * callint.c (quotify_arg, quotify_args): Now static.
14686 (Fcall_interactively): Rename locals to avoid shadowing.
14687 Use const pointer when appropriate.
14689 * lisp.h (get_system_name, get_operating_system_release):
14690 Move decls here, to check interfaces.
14691 * process.c (get_operating_system_release): Move decl to lisp.h.
14692 * xrdb.c (get_system_name): Likewise.
14693 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14694 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14695 some of which prompt warnings from gcc -Wbad-function-cast.
14696 (Fformat_time_string, Fencode_time, Finsert_char):
14697 (Ftranslate_region_internal, Fformat):
14698 Rename or remove local vars to avoid shadowing.
14699 (Ftranslate_region_internal): Mark var as initialized.
14701 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14704 * lisp.h (eassert): Check that the argument compiles, even if
14705 ENABLE_CHECKING is not defined.
14707 * data.c (Findirect_variable): Name an expression, to avoid
14708 gcc -Wbad-function-cast warning.
14709 (default_value, arithcompare, arith_driver, arith_error): Now static.
14710 (store_symval_forwarding): Rename local to avoid shadowing.
14711 (Fmake_variable_buffer_local, Fmake_local_variable):
14712 Mark variables as initialized.
14713 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14715 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14716 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14717 Rename locals to avoid shadowing.
14718 (mark_stack): Move local variables into the #ifdef region where
14720 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14721 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14723 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14724 (GC_STRING_CHARS): Remove; not used.
14725 (Fmemory_limit): Cast sbrk's returned value to char *.
14727 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14728 avoids undefined behavior in theory.
14730 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14732 Use functions, not macros, for up- and down-casing (Bug#8254).
14733 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14734 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14735 to use the following functions instead of these macros.
14736 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14737 EMACS_INT, since callers assume the returned value fits in int.
14738 (upcase1): Likewise, for UPCASE_TABLE.
14739 (uppercasep, lowercasep, upcase): New static inline functions.
14740 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14741 the race-condition problem in the old DOWNCASE.
14743 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14744 Rename locals to avoid shadowing.
14745 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14746 (regex_compile, re_search_2, re_match_2_internal):
14747 Remove unused local vars.
14748 (FREE_VAR): Rewrite so as not to use empty "else",
14749 which gcc can warn about.
14750 (regex_compile, re_match_2_internal): Mark locals as initialized.
14751 (RETALLOC_IF): Define only if needed.
14752 (WORDCHAR_P): Likewise. This one is never needed, but is used
14753 only in a comment talking about a compiler bug, so put inside
14754 the #if 0 of that comment.
14755 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14756 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14759 * search.c (boyer_moore): Rename locals to avoid shadowing.
14760 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14761 (PREV_CHAR_BOUNDARY): Likewise.
14763 * search.c (simple_search): Remove unused var.
14765 * dired.c (compile_pattern): Move decl from here ...
14766 * lisp.h: ... to here, so that it can be checked.
14767 (struct re_registers): New forward decl.
14769 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14771 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14773 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14774 Rename locals to avoid shadowing.
14775 (Fvertical_motion): Mark locals as initialized.
14777 * casefiddle.c (casify_object, casify_region): Now static.
14778 (casify_region): Mark local as initialized.
14780 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14782 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14783 New macros, so that the caller can use some names other than
14784 gcpro1, gcpro2, etc.
14785 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14787 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14788 argument, for consistency with GCPRO2_VAR, etc: it is now the
14789 prefix of the variable, not the variable itself. All uses
14791 * dired.c (directory_files_internal, file_name_completion):
14792 Rename locals to avoid shadowing.
14794 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14795 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14796 dired.c's scmp function, had undefined behavior.
14797 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14798 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14799 * buffer.h: ... to here, because these macros use current_buffer,
14800 and the new implementation with inline functions needs to have
14801 current_buffer in scope now, rather than later when the macros
14803 (downcase, upcase1): New static inline functions.
14804 (DOWNCASE, UPCASE1): Reimplement using these functions.
14805 This avoids undefined behavior in expressions like
14806 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14807 from race conditions in accessing the global variables
14808 case_temp1 and case_temp2.
14809 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14810 * lisp.h (case_temp1, case_temp2): Remove their decls.
14811 * character.h (ASCII_CHAR_P): Move from here ...
14812 * lisp.h: ... to here, so that the inline functions mentioned
14813 above can use them.
14815 * dired.c (directory_files_internal_unwind): Now static.
14817 * fileio.c (file_name_as_directory, directory_file_name):
14818 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14820 (file_name_as_directory): Use const pointers when appropriate.
14821 (Fexpand_file_name): Likewise. In particular, newdir might
14822 point at constant storage, so make it a const pointer.
14823 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14824 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14826 (Fset_file_times, Finsert_file_contents, auto_save_error):
14827 Rename locals to avoid shadowing.
14829 * minibuf.c (choose_minibuf_frame_1): Now static.
14830 (Ftry_completion, Fall_completions): Rename or remove locals
14831 to avoid shadowing.
14833 * marker.c (bytepos_to_charpos): Remove; unused.
14835 * lisp.h (verify_bytepos, count_markers): New decls,
14836 so that gcc does not warn that these functions aren't declared.
14838 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14839 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14840 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14841 (copy_text): Remove unused local var.
14843 * filelock.c (within_one_second): Now static.
14844 (lock_file_1): Rename local to avoid shadowing.
14846 * buffer.c (fix_overlays_before): Mark locals as initialized.
14847 (fix_start_end_in_overlays): Likewise. This function should be
14848 simplified by using pointers-to-pointers, but that's a different
14850 (switch_to_buffer_1): Now static.
14851 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14852 (report_overlay_modification): Rename locals to avoid shadowing.
14854 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14855 Fix pointer signedness issue.
14856 (sys_subshell): Mark local as volatile if checking for lint,
14857 to suppress a gcc -Wclobbered warning that does not seem to be right.
14858 (MAXPATHLEN): Define only if needed.
14860 * process.c (serial_open, serial_configure): Move decls from here ...
14861 * systty.h: ... to here, so that they can be checked.
14863 * fns.c (get_random, seed_random): Move extern decls from here ...
14864 * lisp.h: ... to here, so that they can be checked.
14866 * sysdep.c (reset_io): Now static.
14867 (wait_for_termination_signal): Remove; unused.
14869 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14870 (copy_keymap_item, append_key, push_text_char_description):
14872 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14873 (DENSE_TABLE_SIZE): Remove; unused.
14874 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14875 (describe_map_tree):
14876 Rename locals to avoid shadowing.
14878 * keyboard.c: Declare functions static if they are not used elsewhere.
14879 (echo_char, echo_dash, cmd_error, top_level_2):
14880 (poll_for_input, handle_async_input): Now static.
14881 (read_char, kbd_buffer_get_event, make_lispy_position):
14882 (make_lispy_event, make_lispy_movement, apply_modifiers):
14883 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14884 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14885 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14886 (read_key_sequence, read_char): Mark locals as initialized.
14887 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14889 * keyboard.h (make_ctrl_char): New decl.
14890 (mark_kboards): Move decl here ...
14891 * alloc.c (mark_kboards): ... from here.
14893 * lisp.h (force_auto_save_soon): New decl.
14895 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14896 (DEFINE_DUMMY_FUNCTION): New macro.
14897 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14899 (main): Add casts to avoid warnings
14900 if GCC considers string literals to be constants.
14902 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14904 * dbusbind.c: Pointer signedness fixes.
14905 (xd_signature, xd_append_arg, xd_initialize):
14906 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14907 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14908 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14909 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14911 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14912 if GCC considers string literals to be constants.
14913 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14915 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14917 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14918 (print_preprocess, print_object): New macro to fix last change.
14920 * print.c (print_preprocess): Don't forget font objects.
14922 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14924 * emacs.c (USAGE3): Doc fixes.
14926 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14928 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14931 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14933 * lisp.h (VWindow_system, Qfile_name_history):
14934 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14935 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14936 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14938 * w32select.c: Don't #include "keyboard.h".
14939 (run_protected): Add extern declaration for waiting_for_input.
14941 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14942 * w32console.c (detect_input_pending, read_input_pending)
14943 (encode_terminal_code):
14944 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14945 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14946 (w32_system_caret_y, Qfile_name_history):
14947 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14948 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14949 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14950 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14951 * w32proc.c (Qlocal, report_file_error):
14952 * w32term.c (Vwindow_system, updating_frame):
14953 * w32uniscribe.c (initialized, uniscribe_font_driver):
14954 Remove unneeded extern declarations.
14956 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14958 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14960 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14962 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14963 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14964 These macros can no longer be used for assignment.
14966 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14967 Assign struct members directly, instead of using BUF_BEGV etc.
14968 (record_buffer_markers, fetch_buffer_markers): New functions for
14969 recording and fetching special buffer markers.
14970 (set_buffer_internal_1, set_buffer_temp): Use them.
14972 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14974 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14976 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14977 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14979 * xdisp.c (hscroll_window_tree):
14980 (reconsider_clip_changes): Use PT instead of BUF_PT.
14982 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14984 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14985 $(EMACS_ROOT)/lib/intprops.h.
14987 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14989 Fix more problems found by GCC 4.5.2's static checks.
14991 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14992 to unsigned char * to avoid compiler diagnostic.
14993 (xg_free_frame_widgets): Make it clear that a local variable is
14994 needed only if USE_GTK_TOOLTIP.
14995 (gdk_window_get_screen): Make it clear that this macro is needed
14996 only if USE_GTK_TOOLTIP.
14997 (int_gtk_range_get_value): New function, which avoids a diagnostic
14998 from gcc -Wbad-function-cast.
14999 (xg_set_toolkit_scroll_bar_thumb): Use it.
15000 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15001 diagnostic from gcc -Wbad-function-cast.
15002 (get_utf8_string, xg_get_file_with_chooser):
15003 Rename locals to avoid shadowing.
15004 (create_dialog): Move locals to avoid shadowing.
15006 * xgselect.c (xg_select): Remove unused var.
15008 * image.c (four_corners_best): Mark locals as initialized.
15009 (gif_load): Initialize transparent_p to zero (Bug#8238).
15010 Mark another local as initialized.
15011 (my_png_error, my_error_exit): Mark with NO_RETURN.
15013 * image.c (clear_image_cache): Now static.
15014 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
15015 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
15016 (x_edge_detection): Remove unnecessary cast that
15017 gcc -Wbad-function-cast diagnoses.
15018 (gif_load): Fix pointer signedness.
15019 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15020 (jpeg_load, gif_load): Rename locals to avoid shadowing.
15022 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
15024 Improve quality of tests for time stamp overflow.
15025 For example, without this patch (encode-time 0 0 0 1 1
15026 1152921504606846976) returns the obviously-bogus value (-948597
15027 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15028 reports time overflow. See
15029 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
15030 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15031 * editfns.c: Include limits.h and intprops.h.
15032 (TIME_T_MIN, TIME_T_MAX): New macros.
15033 (time_overflow): Move earlier, to before first use.
15034 (hi_time, lo_time): New functions, for an accurate test for
15035 out-of-range times.
15036 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15037 (Fget_internal_run_time): Don't assume time_t fits in int.
15038 (make_time): Use list2 instead of Fcons twice.
15039 (Fdecode_time): More accurate test for out-of-range times.
15040 (check_tm_member): New function.
15041 (Fencode_time): Use it, to test for out-of-range times.
15042 (lisp_time_argument): Don't rely on undefined left-shift and
15043 right-shift behavior when checking for time stamp overflow.
15045 * editfns.c (time_overflow): New function, refactoring common code.
15046 (Fformat_time_string, Fdecode_time, Fencode_time):
15047 (Fcurrent_time_string): Use it.
15049 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15050 * dired.c (make_time): Move to ...
15051 * editfns.c (make_time): ... here.
15052 * systime.h: Note the move.
15054 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15056 * fringe.c (update_window_fringes): Remove unused variables.
15058 * unexmacosx.c (copy_data_segment): Also copy __got section.
15061 2011-03-12 Eli Zaretskii <eliz@gnu.org>
15063 * termcap.c [MSDOS]: Include "msdos.h".
15064 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15065 Constify `char *' arguments and their references according to
15066 prototypes in tparam.h.
15068 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
15070 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15071 Adapt all references accordingly.
15073 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15075 2011-03-11 Tom Tromey <tromey@redhat.com>
15077 * buffer.c (syms_of_buffer): Remove obsolete comment.
15079 2011-03-11 Eli Zaretskii <eliz@gnu.org>
15081 * termhooks.h (encode_terminal_code): Declare prototype.
15083 * msdos.c (encode_terminal_code): Don't declare prototype.
15085 * term.c (encode_terminal_code): Now external again, used by
15086 w32console.c and msdos.c.
15088 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15089 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
15091 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
15093 Fix some minor problems found by GCC 4.5.2's static checks.
15095 * fringe.c (update_window_fringes): Mark locals as initialized
15097 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
15099 * alloc.c (mark_fringe_data): Move decl from here ...
15100 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15101 to check its interface.
15102 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15104 * fontset.c (free_realized_fontset): Now static.
15105 (Fset_fontset_font): Rename local to avoid shadowing.
15106 (fontset_font): Mark local as initialized.
15107 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
15109 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15111 * xselect.c (x_disown_buffer_selections): Remove; not used.
15112 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
15113 (x_own_selection, Fx_disown_selection_internal): Rename locals
15114 to avoid shadowing.
15115 (x_handle_dnd_message): Remove local to avoid shadowing.
15117 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15118 so that the caller can use some name other than gcpro1.
15119 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
15120 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15121 (Fx_backspace_delete_keys_p):
15122 Use them to avoid shadowing, and rename vars to avoid shadowing.
15123 (x_decode_color, x_set_name, x_window): Now static.
15124 (Fx_create_frame): Add braces to silence GCC warning.
15125 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
15126 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15127 Remove unused locals.
15128 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15129 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15130 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15133 * xterm.h (x_mouse_leave): New decl.
15135 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15136 Remove unused functions.
15137 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15138 (x_calc_absolute_position): Now static.
15139 (XTread_socket): Don't define label "out" unless it's used.
15140 Don't declare local "event" unless it's used.
15141 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15142 unless they are used.
15143 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15144 (x_fatal_error_signal): Remove; not used.
15145 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15146 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15147 (x_error_catcher, x_connection_closed, x_error_handler):
15148 (x_error_quitter, xembed_send_message, x_iconify_frame):
15149 (my_log_handler): Rename locals to avoid shadowing.
15150 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
15151 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
15153 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15154 Rename or move locals to avoid shadowing.
15155 (tty_defined_color, merge_face_heights): Now static.
15156 (free_realized_faces_for_fontset): Remove; not used.
15157 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15158 does not deduce is never used uninitialized.
15159 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15160 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
15162 * terminal.c (store_terminal_param): Now static.
15164 * xmenu.c (menu_highlight_callback): Now static.
15165 (set_frame_menubar): Remove unused local.
15166 (xmenu_show): Rename parameter to avoid shadowing.
15167 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15168 since they might point to immutable storage.
15169 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15170 since it's unused otherwise.
15172 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
15173 Add a FIXME, since the code still doesn't look right. (Bug#8215)
15174 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15175 avoids a gcc -Wuninitialized diagnostic.
15176 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
15177 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15178 does not deduce are never used uninitialized.
15180 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15182 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
15183 * window.c (window_loop, size_window):
15184 (run_window_configuration_change_hook, enlarge_window): Likewise.
15186 * window.c (display_buffer): Now static.
15187 (size_window): Mark variables that gcc -Wuninitialized
15188 does not deduce are never used uninitialized.
15189 * window.h (check_all_windows): New decl, to forestall
15190 gcc -Wmissing-prototypes diagnostic.
15191 * dispextern.h (bidi_dump_cached_states): Likewise.
15193 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15195 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
15196 Include <limits.h>.
15197 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15198 and to avoid gcc -Wuninitialized warning.
15199 (load_charset_map): Mark variables that gcc -Wuninitialized
15200 does not deduce are never used uninitialized.
15201 (load_charset): Abort instead of using uninitialized var (Bug#8229).
15203 * coding.c (coding_set_source, coding_set_destination):
15204 Use "else { /* comment */ }" rather than "else /* comment */;"
15205 for clarity, and to avoid gcc -Wempty-body warning.
15206 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15207 a block, when the outer 'i' will do.
15208 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15209 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15210 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15211 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15212 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15213 Rename locals to avoid shadowing.
15214 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
15215 * coding.c (emacs_mule_char, encode_invocation_designation):
15216 Now static, since they're not used elsewhere.
15217 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
15218 (decode_coding_object, encode_coding_object, detect_coding_system):
15219 (decode_coding_emacs_mule): Mark variables that gcc
15220 -Wuninitialized does not deduce are never used uninitialized.
15221 (detect_coding_iso_2022): Initialize a local variable that might
15222 be used uninitialized. Leave a FIXME because it's not clear that
15223 this initialization is needed. (Bug#8211)
15224 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15225 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15226 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15227 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15228 Remove unused macros.
15230 * category.c (hash_get_category_set): Remove unused local var.
15231 (copy_category_table): Now static, since it's not used elsewhere.
15232 * character.c (string_count_byte8): Likewise.
15234 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15235 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15237 * chartab.c (copy_sub_char_table): Now static, since it's not used
15239 (sub_char_table_ref_and_range, char_table_ref_and_range):
15240 Rename locals to avoid shadowing.
15241 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
15243 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
15244 (BIDI_BOB): Remove unused macro.
15246 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15247 deduce are never used uninitialized.
15248 * term.c (encode_terminal_code): Likewise.
15250 * term.c (encode_terminal_code): Now static. Remove unused local.
15252 * tparam.h: New file.
15253 * term.c, tparam.h: Include it.
15254 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15255 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15256 Move these decls to tparam.h, and make them agree with what
15257 is actually in tparam.c. The previous trick of using incompatible
15258 decls in different modules does not conform to the C standard.
15259 All callers of tparam changed to use tparam's actual API.
15260 * tparam.c (tparam1, tparam, tgoto):
15261 Use const pointers where appropriate.
15263 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15264 * cm.h (struct cm): Likewise.
15265 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15266 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15267 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15268 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15269 (turn_on_face, init_tty): Likewise.
15270 * termchar.h (struct tty_display_info): Likewise.
15272 * term.c (term_mouse_position): Rename local to avoid shadowing.
15274 * alloc.c (mark_ttys): Move decl from here ...
15275 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15277 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15279 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15281 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
15283 * search.c (compile_pattern_1): Remove argument regp, unused since
15284 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15285 (compile_pattern): Don't pass it.
15287 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15289 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15290 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15292 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15294 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15296 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15297 gdk_window_get_screen, gdk_window_get_geometry,
15298 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15299 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15300 (xg_get_pixbuf_from_pixmap): New function.
15301 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15302 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15303 Call xg_get_pixbuf_from_pixmap instead of
15304 gdk_pixbuf_get_from_drawable.
15305 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15306 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15307 (xg_check_special_colors): Use GtkStyleContext and its functions
15309 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15310 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15311 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
15312 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15313 Call gtk_widget_get_preferred_size.
15314 (xg_frame_resized): gdk_window_get_geometry only takes 5
15316 (xg_win_to_widget, xg_event_is_for_menubar):
15317 Call gdk_x11_window_lookup_for_display.
15318 (xg_set_widget_bg): New function.
15319 (delete_cb): New function.
15320 (xg_create_frame_widgets): Connect delete-event to delete_cb.
15321 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
15322 (xg_set_background_color): Call xg_set_widget_bg.
15323 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15324 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15325 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15326 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15328 (update_frame_tool_bar): Call gtk_widget_hide.
15329 (xg_initialize): Use GDK_KEY_g.
15331 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15333 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15335 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15336 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15337 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15339 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
15341 * w32xfns.c (select_palette): Check success of RealizePalette against
15342 GDI_ERROR, not zero.
15344 See ChangeLog.11 for earlier changes.
15346 ;; Local Variables:
15350 Copyright (C) 2011-2012 Free Software Foundation, Inc.
15352 This file is part of GNU Emacs.
15354 GNU Emacs is free software: you can redistribute it and/or modify
15355 it under the terms of the GNU General Public License as published by
15356 the Free Software Foundation, either version 3 of the License, or
15357 (at your option) any later version.
15359 GNU Emacs is distributed in the hope that it will be useful,
15360 but WITHOUT ANY WARRANTY; without even the implied warranty of
15361 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15362 GNU General Public License for more details.
15364 You should have received a copy of the GNU General Public License
15365 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.