[ChangeLog]
[bpt/emacs.git] / src / ChangeLog
1 2011-05-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 Use 'inline', not 'INLINE'.
4 * alloc.c, fontset.c (INLINE): Remove.
5 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10
11 2011-05-28 William Xu <william.xwl@gmail.com>
12
13 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14 exiting (Bug#8239).
15
16 2011-05-28 Jim Meyering <meyering@redhat.com>
17
18 Avoid a sign-extension bug in crypto_hash_function.
19 * fns.c (to_uchar): Define.
20 (crypto_hash_function): Use it to convert some newly-signed
21 variables to unsigned, to avoid sign-extension bugs. For example,
22 without this change, (md5 "truc") would evaluate to
23 45723a2aff78ff4fff7fff1114760e62 rather than the expected
24 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
25 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
26
27 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
28
29 Integer overflow fixes.
30
31 * dbusbind.c: Serial number integer overflow fixes.
32 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
33 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
34 to hold a serial number that is too large for a fixnum.
35 (Fdbus_method_return_internal, Fdbus_method_error_internal):
36 Check for serial numbers out of range. Decode any serial number
37 that was so large that it became a float. (Bug#8722)
38
39 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
40 (Fdbus_call_method, Fdbus_call_method_asynchronously):
41 Use XFASTINT rather than XUINT when numbers are nonnegative.
42 (xd_append_arg, Fdbus_method_return_internal):
43 (Fdbus_method_error_internal): Likewise. Also, for unsigned
44 arguments, check that Lisp number is nonnegative, rather than
45 silently wrapping negative numbers around. (Bug#8722)
46 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
47 (Bug#8722)
48
49 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
50
51 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
52
53 ccl: add integer overflow checks
54 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
55 (IN_INT_RANGE): New macros.
56 (ccl_driver): Use them to check for integer overflow when
57 decoding a CCL program. Many of the new checks are whether XINT (x)
58 fits in int; it doesn't always, on 64-bit hosts. The new version
59 doesn't catch all possible integer overflows, but it's an
60 improvement. (Bug#8719)
61
62 * alloc.c (make_event_array): Use XINT, not XUINT.
63 There's no need for unsigned here.
64
65 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
66 This follows up to the 2011-05-06 change that substituted uintptr_t
67 for EMACS_INT. This case wasn't caught back then.
68
69 Rework Fformat to avoid integer overflow issues.
70 * editfns.c: Include <float.h> unconditionally, as it's everywhere
71 now (part of C89). Include <verify.h>.
72 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
73 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
74 (Fformat): Avoid the prepass trying to compute sizes; it was only
75 approximate and thus did not catch overflow reliably. Instead, walk
76 through the format just once, formatting and computing sizes as we go,
77 checking for integer overflow at every step, and allocating a larger
78 buffer as needed. Keep track separately whether the format is
79 multibyte. Keep only the most-recently calculated precision, rather
80 than them all. Record whether each argument has been converted to
81 string. Use EMACS_INT, not int, for byte and char and arg counts.
82 Support field widths and precisions larger than INT_MAX. Avoid
83 sprintf's undefined behavior with conversion specifications such as %#d
84 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
85 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
86 formatting out-of-range floating point numbers with int
87 formats. (Bug#8668)
88
89 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
90
91 * data.c: Avoid integer truncation in expressions involving floats.
92 * data.c: Include <intprops.h>.
93 (arith_driver): When there's an integer overflow in an expression
94 involving floating point, convert the integers to floating point
95 so that the resulting value does not suffer from catastrophic
96 integer truncation. For example, on a 64-bit host (* 4
97 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
98 Do not rely on undefined behavior after integer overflow.
99
100 merge count_size_as_multibyte, parse_str_to_multibyte
101 * character.c, character.h (count_size_as_multibyte):
102 Renamed from parse_str_to_multibyte; all uses changed.
103 Check for integer overflow.
104 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
105 since it's now a duplicate of the other. This is more of
106 a character than a buffer op, so better that it's in character.c.
107 * fns.c, print.c: Adjust to above changes.
108
109 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
110
111 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
112
113 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
114
115 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
116 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
117 (x_clipboard_manager_save): Now static.
118 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
119
120 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
121 (crypto_hash_function): Now static.
122 Fix pointer signedness problems. Avoid unnecessary initializations.
123
124 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
125
126 * termhooks.h (Vselection_alist): Make it terminal-local.
127
128 * terminal.c (create_terminal): Initialize it.
129
130 * xselect.c: Support for clipboard managers.
131 (Vselection_alist): Move to termhooks.h as terminal-local var.
132 (LOCAL_SELECTION): New macro.
133 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
134 (symbol_to_x_atom): Remove gratuitous arg.
135 (x_handle_selection_request, lisp_data_to_selection_data)
136 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
137 (x_own_selection, x_get_local_selection, x_convert_selection): New
138 arg, specifying work frame. Use terminal-local Vselection_alist.
139 (some_frame_on_display): Delete unused function.
140 (Fx_own_selection_internal, Fx_get_selection_internal)
141 (Fx_disown_selection_internal, Fx_selection_owner_p)
142 (Fx_selection_exists_p): New optional frame arg.
143 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
144 (x_handle_selection_clear): Don't treat other terminals with the
145 same keyboard specially. Use the terminal-local Vselection_alist.
146 (x_clear_frame_selections): Use Frun_hook_with_args.
147
148 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
149
150 * xterm.h: Add support for those atoms.
151
152 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
153
154 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
155 (converted_selections, conversion_fail_tag): New global variables.
156 (x_selection_request_lisp_error): Free the above.
157 (x_get_local_selection): Remove unnecessary code.
158 (x_reply_selection_request): Args changed; handle arbitrary array
159 of converted selections stored in converted_selections. Separate
160 the XChangeProperty and SelectionNotify steps.
161 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
162 (x_convert_selection): New function.
163 (x_handle_selection_event): Simplify.
164 (x_get_foreign_selection): Don't ignore incoming requests while
165 waiting for an answer; this will fail when we implement
166 SAVE_TARGETS, and seems unnecessary anyway.
167 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
168 (Vx_sent_selection_functions): Doc fix.
169
170 2011-05-26 Leo Liu <sdl.web@gmail.com>
171
172 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
173
174 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
175
176 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
177
178 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
179 for fringe update if it has periodic bitmap.
180 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
181 and fringe_bitmap_periodic_p.
182
183 * fringe.c (get_fringe_bitmap_data): New function.
184 (draw_fringe_bitmap_1, update_window_fringes): Use it.
185 (update_window_fringes): Record periodicity of fringe bitmap in glyph
186 row. Mark glyph row for fringe update if periodicity changed.
187
188 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
189 for fringe update unless it has periodic bitmap.
190
191 2011-05-25 Kenichi Handa <handa@m17n.org>
192
193 * xdisp.c (get_next_display_element): Set correct it->face_id for
194 a static composition.
195
196 2011-05-24 Leo Liu <sdl.web@gmail.com>
197
198 * deps.mk (fns.o):
199 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
200
201 * fns.c (crypto_hash_function, Fsha1): New function.
202 (Fmd5): Use crypto_hash_function.
203 (syms_of_fns): Add Ssha1.
204
205 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
206
207 * gnutls.c: Remove unused macros.
208 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
209 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
210 Remove macros that are defined and never used.
211 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
212
213 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
214
215 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
216 (Fx_get_selection_internal): Minor cleanup.
217 (Fx_own_selection_internal): Rename arguments for consistency with
218 select.el.
219
220 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
221
222 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
223
224 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
225
226 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
227
228 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
229
230 * dispnew.c (scrolling_window): Don't exclude the case that the
231 last enabled row in the desired matrix touches the bottom boundary.
232
233 2011-05-21 Glenn Morris <rgm@gnu.org>
234
235 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
236 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
237 and add some more files.
238
239 2011-05-20 Eli Zaretskii <eliz@gnu.org>
240
241 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
242 report_file_error introduced by the change from 2011-05-07.
243
244 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
245
246 * systime.h (Time): Define only if emacs is defined.
247 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
248 where the include path doesn't have X11/X.h by default. See
249 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
250
251 2011-05-20 Kenichi Handa <handa@m17n.org>
252
253 * composite.c (find_automatic_composition): Fix previous change.
254
255 2011-05-20 Glenn Morris <rgm@gnu.org>
256
257 * lisp.mk: New file, split from Makefile.in.
258 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
259 (shortlisp): Remove.
260 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
261
262 2011-05-19 Glenn Morris <rgm@gnu.org>
263
264 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
265 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
266 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
267 (lisp): Set the order to that of loadup.el.
268 (shortlisp): Make it a copy of $lisp.
269 (SOME_MACHINE_LISP): Remove.
270 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
271 Use just $shortlisp, not $SOME_MACHINE_LISP too.
272
273 2011-05-18 Kenichi Handa <handa@m17n.org>
274
275 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
276 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
277 (find_automatic_composition): Mostly rewrite for efficiency.
278
279 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
280
281 * makefile.w32-in: Update dependencies.
282
283 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
284
285 * menu.c: Include limits.h (fixes the MS-Windows build broken by
286 revision 104625).
287
288 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
289
290 Fix some integer overflow issues, such as string length overflow.
291
292 * insdel.c (count_size_as_multibyte): Check for string overflow.
293
294 * character.c (lisp_string_width): Check for string overflow.
295 Use EMACS_INT, not int, for string indexes and lengths; in
296 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
297 the resulting string length overflows an EMACS_INT; instead,
298 report a string overflow if no precision given. When checking for
299 precision exhaustion, use a check that cannot possibly have
300 integer overflow. (Bug#8675)
301 * character.h (lisp_string_width): Adjust to new signature.
302
303 * alloc.c (string_overflow): New function.
304 (Fmake_string): Use it. This doesn't change behavior, but saves
305 a few bytes and will simplify future changes.
306 * character.c (string_escape_byte8): Likewise.
307 * lisp.h (string_overflow): New decl.
308
309 Fixups, following up to the user-interface timestamp change.
310 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
311 for UI timestamps, instead of unsigned long.
312 * msdos.c (mouse_get_pos): Likewise.
313 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
314 * w32gui.h (Time): Define by including "systime.h" rather than by
315 declaring it ourselves. (Bug#8664)
316
317 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
318 * image.c (clear_image_cache): Likewise.
319
320 * term.c (term_mouse_position): Don't assume time_t wraparound.
321
322 Be more systematic about user-interface timestamps.
323 Before, the code sometimes used 'Time', sometimes 'unsigned long',
324 and sometimes 'EMACS_UINT', to represent these timestamps. This
325 change causes it to use 'Time' uniformly, as that's what X uses.
326 This makes the code easier to follow, and makes it easier to catch
327 integer overflow bugs such as Bug#8664.
328 * frame.c (Fmouse_position, Fmouse_pixel_position):
329 Use Time, not unsigned long, for user-interface timestamps.
330 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
331 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
332 * keyboard.h (last_event_timestamp): Likewise.
333 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
334 * menu.h (xmenu_show): Likewise.
335 * term.c (term_mouse_position): Likewise.
336 * termhooks.h (struct input_event.timestamp): Likewise.
337 (struct terminal.mouse_position_hook): Likewise.
338 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
339 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
340 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
341 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
342 what it was before.
343 * menu.h, termhooks.h: Include "systime.h", for Time.
344
345 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
346 Don't assume that the difference between two unsigned long values
347 can fit into an integer. At this point, we know button_down_time
348 <= event->timestamp, so the difference must be nonnegative, so
349 there's no need to cast the result if double-click-time is
350 nonnegative, as it should be; check that it's nonnegative, just in
351 case. This bug is triggered when events are more than 2**31 ms
352 apart (about 25 days). (Bug#8664)
353
354 * xselect.c (last_event_timestamp): Remove duplicate decl.
355 (x_own_selection): Remove needless cast to unsigned long.
356
357 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
358 that always fit in int. Use a sentinel instead of a counter, to
359 avoid a temp and to allay GCC's concerns about possible int overflow.
360 * frame.h (struct frame): Use int for menu_bar_items_used
361 instead of EMACS_INT, since it always fits in int.
362
363 * menu.c (grow_menu_items): Check for int overflow.
364
365 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
366
367 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
368 Before, the code was not consistent. These values cannot exceed
369 2**31 - 1 so there's no need to make them unsigned.
370 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
371 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
372 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
373 as modifiers.
374 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
375
376 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
377 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
378 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
379 presumably because the widths might not match.
380
381 * window.c (size_window): Avoid needless test at loop start.
382
383 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
384
385 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
386
387 2011-05-12 Drew Adams <drew.adams@oracle.com>
388
389 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
390
391 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
392
393 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
394 `width' to `bar_area_x' and `bar_area_width', respectively.
395 (x_scroll_run): Take account of fringe background extension.
396
397 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
398 Rename local vars `left' and `width' to `bar_area_x' and
399 `bar_area_width', respectively.
400 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
401 background extension.
402
403 2011-05-10 Jim Meyering <meyering@redhat.com>
404
405 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
406
407 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
408
409 * image.c (Finit_image_library): Return t for built-in image types,
410 like pbm and xbm. (Bug#8640)
411
412 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
413
414 * w32menu.c (set_frame_menubar): Fix submenu allocation.
415
416 2011-05-07 Eli Zaretskii <eliz@gnu.org>
417
418 * w32console.c (Fset_screen_color): Doc fix.
419 (Fget_screen_color): New function.
420 (syms_of_ntterm): Defsubr it.
421
422 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
423 unlink the temporary file if Fcall_process didn't create it in the
424 first place.
425 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
426 child process will be redirected to a file specified with `:file'.
427 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
428 cue to call_process_cleanup not to close that handle.
429
430 2011-05-07 Ben Key <bkey76@gmail.com>
431
432 * makefile.w32-in: The bootstrap-temacs rule now makes use of
433 one of two shell specific rules, either bootstrap-temacs-CMD or
434 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
435 to the previous implementation of the bootstrap-temacs rule.
436 The bootstrap-temacs-CMD rule is similar to the previous
437 implementation of the bootstrap-temacs rule except that it
438 makes use of the ESC_CFLAGS variable instead of the CFLAGS
439 variable.
440
441 These changes, along with some changes to nt/configure.bat,
442 nt/gmake.defs, and nt/nmake.defs, are required to extend my
443 earlier fix to add support for --cflags and --ldflags options
444 that include quotes so that it works whether make uses cmd or
445 sh as the shell.
446
447 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
448
449 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
450 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
451 is a constant.
452 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
453 a string. Handle both cases.
454 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
455 (Fdbus_register_method): Use Qinvalid_function.
456
457 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
458
459 * makefile.w32-in: Update dependencies.
460 (LISP_H): Add inttypes.h and stdin.h.
461 (PROCESS_H): Add unistd.h.
462
463 2011-05-06 Eli Zaretskii <eliz@gnu.org>
464
465 * lread.c: Include limits.h (fixes the MS-Windows build broken by
466 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
467
468 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
469
470 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
471
472 * term.c (vfatal): Remove stray call to va_end.
473 It's not needed and the C Standard doesn't allow it here anyway.
474
475 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
476 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
477
478 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
479 bytes.
480
481 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
482
483 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
484
485 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
486
487 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
488
489 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
490
491 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
492 * charset.c (Fdefine_charset_internal): Don't initialize
493 charset.code_space[15]. The value was garbage, on hosts with
494 32-bit int (Bug#8600).
495
496 * lread.c (read_integer): Be more consistent with string-to-number.
497 Use string_to_number to do the actual conversion; this avoids
498 rounding errors and fixes some other screwups. Without this fix,
499 for example, #x1fffffffffffffff was misread as -2305843009213693952.
500 (digit_to_number): Move earlier, for benefit of read_integer.
501 Return -1 if the digit is out of range for the base, -2 if it is
502 not a digit in any supported base. (Bug#8602)
503
504 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
505
506 * dispnew.c (scrolling_window): Return 1 if we scrolled,
507 to match comment at start of function. This also removes a
508 GCC warning about overflow in a 32+64-bit port.
509
510 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
511
512 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
513 Reported by Stefan Monnier in
514 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
515 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
516 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
517
518 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
519 (EMACS_UINTPTR): Likewise, with uintptr_t.
520
521 * lisp.h: Prefer 64-bit EMACS_INT if available.
522 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
523 on 32-bit hosts that have 64-bit int, so that they can access
524 large files.
525 However, temporarily disable this change unless the temporary
526 symbol WIDE_EMACS_INT is defined.
527
528 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
529
530 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
531 This removes an assumption that EMACS_INT and long are the same
532 width as pointers. The assumption is true for Emacs porting targets
533 now, but we want to make other targets possible.
534 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
535 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
536 In the rest of the code, change types of integers that hold casted
537 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
538 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
539 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
540 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
541 No need to cast type when ORing.
542 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
543 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
544 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
545 assume EMACS_INT is the same width as char *.
546 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
547 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
548 Remove no-longer-needed casts.
549 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
550 (xg_tool_bar_help_callback, xg_make_tool_item):
551 Use EMACS_INTPTR to hold an integer
552 that will be cast to void *; this can avoid a GCC warning
553 if EMACS_INT is not the same width as void *.
554 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
555 * xdisp.c (display_echo_area_1, resize_mini_window_1):
556 (current_message_1, set_message_1):
557 Use a local to convert to proper width without a cast.
558 * xmenu.c (dialog_selection_callback): Likewise.
559
560 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
561 Also, don't assume VALBITS / RAND_BITS is less than 5,
562 and don't rely on undefined behavior when shifting a 1 left into
563 the sign bit.
564 * lisp.h (get_random): Change signature to match.
565
566 * lread.c (hash_string): Use size_t, not int, for hash computation.
567 Normally we prefer signed values; but hashing is special, because
568 it's better to use unsigned division on hash table sizes so that
569 the remainder is nonnegative. Also, size_t is the natural width
570 for hashing into memory. The previous code used 'int', which doesn't
571 retain enough info to hash well into very large tables.
572 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
573
574 * dbusbind.c: Don't possibly lose pointer info when converting.
575 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
576 Use XPNTR rather than XHASH, so that the high-order bits of
577 the pointer aren't lost when converting through void *.
578
579 * eval.c (Fautoload): Don't double-shift a pointer.
580
581 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
582
583 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
584
585 * gnutls.c (DEF_GNUTLS_FN):
586 * image.c (DEF_IMGLIB_FN): Make function pointers static.
587
588 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
589
590 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
591 marker. (Bug#8610)
592
593 2011-05-05 Eli Zaretskii <eliz@gnu.org>
594
595 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
596 New version that can reserve upto 2GB of heap space.
597
598 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
599
600 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
601
602 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
603
604 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
605 `gnutls_certificate_set_x509_key_file'.
606
607 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
608
609 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
610 Update dependencies.
611
612 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
613
614 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
615 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
616 Remove unused parameter `fildes'.
617 * process.c (read_process_output, send_process): Don't pass it.
618
619 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
620
621 Fix previous change: the library cache is defined in w32.c.
622 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
623 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
624
625 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
626
627 Implement dynamic loading of GnuTLS on Windows.
628
629 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
630 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
631 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
632 Declare.
633
634 * gnutls.c (Qgnutls_dll): Define.
635 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
636 (gnutls_*): Declare function pointers.
637 (init_gnutls_functions): New function to initialize function pointers.
638 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
639 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
640 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
641 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
642 (emacs_gnutls_write, emacs_gnutls_read)
643 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
644 (Fgnutls_available_p): New function.
645 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
646 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
647 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
648
649 * image.c: Include w32.h.
650 (Vimage_type_cache): Delete.
651 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
652 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
653 (w32_delayed_load): Move to w32.c.
654
655 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
656
657 * w32.c (QCloaded_from, Vlibrary_cache): Define.
658 (w32_delayed_load): Move from image.c. When loading a library, record
659 its filename in the :loaded-from property of the library id.
660 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
661 Initialize and staticpro them.
662 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
663
664 * process.c: Include lisp.h before w32.h, not after.
665 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
666 instead of gnutls_record_check_pending.
667
668 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
669
670 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
671
672 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
673 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
674 as passed in.
675
676 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
677
678 * xterm.c (x_set_frame_alpha): Do not set property on anything
679 else than FRAME_X_OUTER_WINDOW (Bug#8608).
680
681 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
682
683 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
684
685 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
686
687 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
688 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
689 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
690 (gnutls_global_initialized, Qgnutls_bootprop_priority)
691 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
692 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
693 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
694 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
695 (Qgnutls_bootprop_callbacks_verify): Make static.
696
697 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
698
699 * callproc.c: Indentation fixup.
700
701 * sysdep.c (wait_for_termination_1): Make static.
702 (wait_for_termination, interruptible_wait_for_termination):
703 Move after wait_for_termination_1.
704
705 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
706
707 * sysdep.c (interruptible_wait_for_termination): New function
708 which is like wait_for_termination, but allows keyboard
709 interruptions.
710
711 * callproc.c (Fcall_process): Add (:file "file") as an option for
712 the STDOUT buffer.
713 (Fcall_process_region): Ditto.
714
715 2011-04-30 Eli Zaretskii <eliz@gnu.org>
716
717 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
718 rather than `XVECTOR (FOO)->size'.
719
720 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
721 inttypes.h, as a gnulib replacement is used if it not available in
722 system headers.
723
724 2011-04-21 Eli Zaretskii <eliz@gnu.org>
725
726 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
727 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
728 of MOST_POSITIVE_FIXNUM. (Bug#8528)
729
730 * coding.c (coding_alloc_by_realloc): Error out if destination
731 will grow beyond MOST_POSITIVE_FIXNUM.
732 (decode_coding_emacs_mule): Abort if there isn't enough place in
733 charbuf for the composition carryover bytes. Reserve an extra
734 space for up to 2 characters produced in a loop.
735 (decode_coding_iso_2022): Abort if there isn't enough place in
736 charbuf for the composition carryover bytes.
737
738 2011-04-21 Eli Zaretskii <eliz@gnu.org>
739
740 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
741 aborting when %lld or %lll format is passed.
742 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
743 %llo or %llx format is passed. (Bug#8545)
744
745 * window.c (window_scroll_line_based): Use a marker instead of
746 simple variables to record original value of point. (Bug#7952)
747
748 * doprnt.c (doprnt): Fix the case where a multibyte sequence
749 produced by %s or %c overflows available buffer space. (Bug#8545)
750
751 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
752
753 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
754 (SIZE_MAX): Move defn after all includes, as they might #define it.
755
756 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
757
758 * w32.c (init_environment): Warn about defaulting HOME to C:\.
759
760 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
761
762 * keyboard.c (Qdelayed_warnings_hook): Define.
763 (command_loop_1): Run `delayed-warnings-hook'
764 if Vdelayed_warnings_list is non-nil.
765 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
766 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
767
768 2011-04-28 Eli Zaretskii <eliz@gnu.org>
769
770 * doprnt.c (doprnt): Don't return value smaller than the buffer
771 size if the message was truncated. (Bug#8545).
772
773 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
774
775 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
776 (Fx_window_property): #if-0 the whole functions, not just the bodies.
777
778 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
779
780 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
781
782 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
783
784 * makefile.w32-in: Update dependencies.
785
786 2011-04-27 Eli Zaretskii <eliz@gnu.org>
787
788 Improve `doprnt' and its usage. (Bug#8545)
789 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
790 `format_end'. Remove support for %l as a conversion specifier.
791 Don't use xrealloc. Improve diagnostics when the %l size modifier
792 is used. Update the commentary.
793
794 * eval.c (verror): Simplify calculation of size_t.
795
796 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
797 messages.
798
799 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
800
801 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
802 change.
803
804 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
805
806 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
807 This makes this file independent of the recent pseudovector change.
808
809 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
810
811 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
812
813 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
814 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
815 Remove unused local.
816 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
817
818 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
819 GCC 4.6.0 optimizes based on type-based alias analysis.
820 For example, if b is of type struct buffer * and v of type struct
821 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
822 != &v->size, and therefore "v->size = 1; b->size = 2; return
823 v->size;" must therefore return 1. This assumption is incorrect
824 for Emacs, since it type-puns struct Lisp_Vector * with many other
825 types. To fix this problem, this patch adds a new type struct
826 vectorlike_header that documents the constraints on layout of vectors
827 and pseudovectors, and helps optimizing compilers not get fooled
828 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
829 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
830 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
831 the size member.
832 (XSETPVECTYPE): Rewrite in terms of new macro.
833 (XSETPVECTYPESIZE): New macro, specifying both type and size.
834 This is a bit clearer, and further avoids the possibility of
835 undesirable aliasing.
836 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
837 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
838 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
839 since Lisp_Subr is a special case (no "next" field).
840 (ASIZE): Now uses header.size rather than size.
841 All previous uses of XVECTOR (foo)->size replaced to use this macro,
842 to avoid the hassle of writing XVECTOR (foo)->header.size.
843 (struct vectorlike_header): New type.
844 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
845 object, to help avoid aliasing.
846 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
847 (SUBRP): Likewise, since Lisp_Subr is a special case.
848 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
849 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
850 (struct Lisp_Hash_Table): Combine first two members into a single
851 struct vectorlike_header member. All uses of "size" and "next" members
852 changed to be "header.size" and "header.next".
853 * buffer.h (struct buffer): Likewise.
854 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
855 * frame.h (struct frame): Likewise.
856 * process.h (struct Lisp_Process): Likewise.
857 * termhooks.h (struct terminal): Likewise.
858 * window.c (struct save_window_data, struct saved_window): Likewise.
859 * window.h (struct window): Likewise.
860 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
861 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
862 * buffer.c (init_buffer_once): Likewise.
863 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
864 special case.
865 * process.c (Fformat_network_address): Use local var for size,
866 for brevity.
867
868 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
869
870 Make the Lisp reader and string-to-float more consistent (Bug#8525)
871 * data.c (atof): Remove decl; no longer used or needed.
872 (digit_to_number): Move to lread.c.
873 (Fstring_to_number): Use new string_to_number function, to be
874 consistent with how the Lisp reader treats infinities and NaNs.
875 Do not assume that floating-point numbers represent EMACS_INT
876 without losing information; this is not true on most 64-bit hosts.
877 Avoid double-rounding errors, by insisting on integers when
878 parsing non-base-10 numbers, as the documentation specifies.
879 * lisp.h (string_to_number): New decl, replacing ...
880 (isfloat_string): Remove.
881 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
882 (read1): Do not accept +. and -. as integers; this
883 appears to have been a coding error. Similarly, do not accept
884 strings like +-1e0 as floating point numbers. Do not report
885 overflow for integer overflows unless the base is not 10 which
886 means we have no simple and reliable way to continue.
887 Break out the floating-point parsing into a new
888 function string_to_number, so that Fstring_to_number parses
889 floating point numbers consistently with the Lisp reader.
890 (digit_to_number): Move here from data.c. Make it static inline.
891 (E_CHAR, EXP_INT): Remove, replacing with ...
892 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
893 (string_to_number): New function, replacing isfloat_string.
894 This function checks for valid syntax and produces the resulting
895 Lisp float number too. Rework it so that string-to-number
896 no longer mishandles examples like "1.0e+". Use strtoumax,
897 so that overflow for non-base-10 numbers is reported only when
898 there's no portable and simple way to convert to floating point.
899
900 * textprop.c (set_text_properties_1): Rewrite for clarity,
901 and to avoid GCC warning about integer overflow.
902
903 * intervals.h (struct interval): Use EMACS_INT for members
904 where EMACS_UINT might cause problems. See
905 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
906 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
907 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
908 All uses changed.
909 (offset_intervals): Tell GCC not to worry about length overflow
910 when negating a negative length.
911
912 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
913 (overrun_check_free): Likewise.
914
915 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
916 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
917 word size.
918
919 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
920 (gnutls_make_error): Rename local to avoid shadowing.
921 (gnutls_emacs_global_deinit): ifdef out; not used.
922 (Fgnutls_boot): Use const for pointer to readonly storage.
923 Comment out unused local. Fix pointer signedness problems.
924
925 * lread.c (openp): Don't stuff size_t into an 'int'.
926 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
927 about possible signed overflow.
928
929 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
930 (GDK_KEY_g): Don't define if already defined.
931 (xg_prepare_tooltip): Avoid pointer signedness problem.
932 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
933
934 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
935 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
936
937 * xfns.c (Fx_window_property): Simplify a bit,
938 to make a bit faster and to avoid GCC 4.6.0 warning.
939 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
940
941 * fns.c (internal_equal): Don't assume size_t fits in int.
942
943 * alloc.c (compact_small_strings): Tighten assertion a little.
944
945 Replace pEd with more-general pI, and fix some printf arg casts.
946 * lisp.h (pI): New macro, generalizing old pEd macro to other
947 conversion specifiers. For example, use "...%"pI"d..." rather
948 than "...%"pEd"...".
949 (pEd): Remove. All uses replaced with similar uses of pI.
950 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
951 * alloc.c (check_pure_size): Don't overflow by converting size to int.
952 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
953 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
954 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
955 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
956 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
957 64-bit hosts.
958 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
959 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
960 * print.c (safe_debug_print, print_object): Likewise.
961 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
962 to int.
963 Use pI instead of if-then-else-abort. Use %p to avoid casts,
964 avoiding the 0 flag, which is not portable.
965 * process.c (Fmake_network_process): Use pI to avoid cast.
966 * region-cache.c (pp_cache): Likewise.
967 * xdisp.c (decode_mode_spec): Likewise.
968 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
969 behavior on 64-bit hosts with printf arg.
970 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
971 (x_stop_queuing_selection_requests): Likewise.
972 (x_get_window_property): Don't truncate byte count to an 'int'
973 when tracing.
974
975 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
976 here, since it parses constructs like leading '-' and spaces,
977 which are not wanted; and it overflows with large numbers.
978 Instead, simply match F[0-9]+, which is what is wanted anyway.
979
980 * alloc.c: Remove unportable assumptions about struct layout.
981 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
982 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
983 (allocate_vectorlike, make_pure_vector): Use the new macros,
984 plus offsetof, to remove unportable assumptions about struct layout.
985 These assumptions hold on all porting targets that I know of, but
986 they are not guaranteed, they're easy to remove, and removing them
987 makes further changes easier.
988
989 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
990 This doesn't fix a bug but makes the code clearer.
991 (string_overrun_cookie): Now const. Use initializers that
992 don't formally overflow signed char, to avoid warnings.
993 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
994 can cause Emacs to crash when string overrun checking is enabled.
995 (allocate_buffer): Don't assume sizeof (struct buffer) is a
996 multiple of sizeof (EMACS_INT); it need not be, if
997 alignof(EMACS_INT) < sizeof (EMACS_INT).
998 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
999
1000 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1001
1002 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1003
1004 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1005
1006 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1007 supposed to be handshaking. (Bug#8556)
1008 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1009
1010 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1011
1012 * lisp.h (Qdebug): List symbol.
1013 * eval.c (Qdebug): Restore global linkage.
1014 * keyboard.c (debug-on-event): New variable.
1015 (handle_user_signal): Break into debugger when debug-on-event
1016 matches the current signal symbol.
1017
1018 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1019
1020 * alloc.c (check_sblock, check_string_bytes)
1021 (check_string_free_list): Convert to standard C.
1022
1023 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1024
1025 * w32.c (emacs_gnutls_push): Fix typo.
1026
1027 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1028
1029 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1030 "cast to pointer from integer of different size".
1031
1032 Improve doprnt and its use in verror. (Bug#8545)
1033 * doprnt.c (doprnt): Document the set of format control sequences
1034 supported by the function. Use SAFE_ALLOCA instead of always
1035 using `alloca'.
1036
1037 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1038 is one byte too soon. Don't use xrealloc; instead xfree and
1039 xmalloc anew.
1040
1041 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1042
1043 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1044 callbacks stage.
1045
1046 * gnutls.c: Renamed global_initialized to
1047 gnutls_global_initialized. Added internals for the
1048 :verify-hostname-error, :verify-error, and :verify-flags
1049 parameters of `gnutls-boot' and documented those parameters in the
1050 docstring. Start callback support.
1051 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1052 unless a fatal error occured. Call gnutls_alert_send_appropriate
1053 on error. Return error code.
1054 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1055 (emacs_gnutls_read): Likewise.
1056 (Fgnutls_boot): Return handshake error code.
1057 (emacs_gnutls_handle_error): New function.
1058 (wsaerror_to_errno): Likewise.
1059
1060 * w32.h (emacs_gnutls_pull): Add prototype.
1061 (emacs_gnutls_push): Likewise.
1062
1063 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1064 (emacs_gnutls_push): Likewise.
1065
1066 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1067
1068 * process.c (wait_reading_process_output): Check if GnuTLS
1069 buffered some data internally if no FDs are set for TLS
1070 connections.
1071
1072 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1073 (LIBS): Link to USER_LIBS.
1074 ($(BLD)/gnutls.$(0)): New target.
1075
1076 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1077
1078 * xdisp.c (handle_single_display_spec): Rename the
1079 display_replaced_before_p argument into display_replaced_p, to
1080 make it consistent with the commentary. Fix typos in the
1081 commentary.
1082
1083 * textprop.c (syms_of_textprop): Remove dead code.
1084 (copy_text_properties): Delete obsolete commentary about an
1085 interface that was deleted long ago. Fix typos in the description
1086 of arguments.
1087
1088 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1089 to changes in oldXMenu/XMenu.h from 2011-04-16.
1090 <menu_help_message, prev_menu_help_message>: Constify.
1091 (IT_menu_make_room): menu->help_text is now `const char **';
1092 adjust.
1093
1094 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1095 to changes in oldXMenu/XMenu.h from 2011-04-16.
1096 (struct XMenu): Declare `help_text' `const char **'.
1097
1098 * xfaces.c <Qunspecified>: Make extern again.
1099
1100 * syntax.c: Include sys/types.h before including regex.h, as
1101 required by Posix.
1102
1103 * doc.c (get_doc_string): Improve the format passed to `error'.
1104
1105 * doprnt.c (doprnt): Improve commentary.
1106
1107 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1108
1109 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1110 them with etags.
1111
1112 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1113 changes in globals.h immediately force recompilation.
1114 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1115 $(CURDIR)/s/ms-w32.h.
1116 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1117
1118 * character.c (Fchar_direction): Function deleted.
1119 (syms_of_character): Don't defsubr it.
1120 <char-direction-table>: Deleted.
1121
1122 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1123
1124 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1125 * doprnt.c: Include limits.h.
1126 (SIZE_MAX): New macro.
1127 (doprnt): Return a size_t value. 2nd arg is now size_t.
1128 Many local variables are now size_t instead of int or unsigned.
1129 Improve overflow protection. Support `l' modifier for integer
1130 conversions. Support %l conversion. Don't assume an EMACS_INT
1131 argument for integer conversions and for %c.
1132
1133 * lisp.h (doprnt): Restore prototype.
1134
1135 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1136 $(SRC)/character.h.
1137
1138 * Makefile.in (base_obj): Add back doprnt.o.
1139
1140 * deps.mk (doprnt.o): Add back prerequisites.
1141 (callint.o): Depend on character.h.
1142
1143 * eval.c (internal_lisp_condition_case): Include the handler
1144 representation in the error message.
1145 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1146 when breaking from the loop.
1147
1148 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1149
1150 * callint.c (Fcall_interactively): When displaying error message
1151 about invalid control letter, pass the character's codepoint, not
1152 a pointer to its multibyte form. Improve display of the character
1153 in octal and display also its hex code.
1154
1155 * character.c (char_string): Use %x to display the (unsigned)
1156 codepoint of an invalid character, to avoid displaying a bogus
1157 negative value.
1158
1159 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1160 `error', not SYMBOL_NAME itself.
1161
1162 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1163 character arguments to `error'.
1164
1165 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1166 to `error' in error message about FINAL_CHAR argument. Make sure
1167 FINAL_CHAR is a character, and use %c when it is passed as
1168 argument to `error'.
1169
1170 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1171
1172 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1173
1174 * w32.c: Include <time.h>.
1175 (sys_localtime): New function.
1176
1177 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1178
1179 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1180
1181 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1182
1183 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1184
1185 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1186 zombies (Bug#8467).
1187
1188 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1189
1190 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1191 gl_state.e_property when gl_state.object is Qt.
1192
1193 * insdel.c (make_gap_larger): Remove limitation of buffer size
1194 to <= INT_MAX.
1195
1196 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1197
1198 * xdisp.c (lookup_glyphless_char_display)
1199 (produce_glyphless_glyph): Handle cons cell entry in
1200 glyphless-char-display.
1201 (Vglyphless_char_display): Document it.
1202
1203 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1204 glyphless-char-display.
1205
1206 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1207
1208 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1209
1210 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1211
1212 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1213 definition for no-X builds.
1214
1215 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 Static checks with GCC 4.6.0 and non-default toolkits.
1218
1219 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1220
1221 * process.c (keyboard_bit_set): Define only if SIGIO.
1222 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1223 (send_process): Repair possible setjmp clobbering.
1224
1225 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1226
1227 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1228
1229 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1230
1231 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1232 Define only if needed.
1233
1234 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1235 by pacifying GCC about it. Maybe it's time to retire it?
1236 * xfaces.c (USG, __TIMEVAL__): Likewise.
1237
1238 * dispextern.h (struct redisplay_interface): Rename param
1239 to avoid shadowing.
1240 * termhooks.h (struct terminal): Likewise.
1241 * xterm.c (xembed_send_message): Likewise.
1242
1243 * insdel.c (make_gap_smaller): Define only if
1244 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1245
1246 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1247 it.
1248
1249 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1250 so that we aren't warned about unused symbols.
1251
1252 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1253
1254 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1255
1256 * xfns.c (x_real_positions): Mark locals as initialized.
1257
1258 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1259
1260 * xterm.c: Fix problems found by static analysis with other toolkits.
1261 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1262 (x_dispatch_event): Declare static if USE_GTK, and
1263 define if USE_GTK || USE_X_TOOLKIT.
1264 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1265 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1266 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1267 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1268
1269 * xmenu.c (menu_help_callback): Pointer type fixes.
1270 Use const pointers when pointing at readonly data. Avoid pointer
1271 signedness clashes.
1272 (FALSE): Remove unused macro.
1273 (update_frame_menubar): Remove unused decl.
1274
1275 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1276
1277 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1278 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1279 (single_menu_item): Rename local to avoid shadowing.
1280
1281 * keyboard.c (make_lispy_event): Remove unused local var.
1282
1283 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1284 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1285
1286 * bitmaps: Change bitmaps from unsigned char back to the X11
1287 compatible char. Avoid the old compiler warnings about
1288 out-of-range initializers by using, for example, '\xab' rather
1289 than 0xab.
1290
1291 * xgselect.c (xgselect_initialize): Check vs interface
1292 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1293
1294 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1295
1296 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1297 to read-only memory.
1298
1299 * fns.c (vector): Remove; this old hack is no longer needed.
1300
1301 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1302 Remove unused var.
1303 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1304
1305 * xrdb.c (x_load_resources): Omit unused local.
1306
1307 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1308 (x_window): Rename locals to avoid shadowing.
1309 (USG): Use the kludged USG macro, to pacify gcc.
1310
1311 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1312 (x_term_init): Remove local to avoid shadowing.
1313
1314 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1315
1316 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1317 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1318
1319 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1320
1321 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1322
1323 Fix regex.c, syntax.c and friends for buffers > 2GB.
1324 * syntax.h (struct gl_state_s): Declare character position members
1325 EMACS_INT.
1326
1327 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1328
1329 * textprop.c (verify_interval_modification, interval_of):
1330 Declare arguments EMACS_INT.
1331
1332 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1333 EMACS_INT.
1334
1335 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1336
1337 * indent.c (Fvertical_motion): Local variable it_start is now
1338 EMACS_INT.
1339
1340 * regex.c (re_match, re_match_2, re_match_2_internal)
1341 (bcmp_translate, regcomp, regexec, print_double_string)
1342 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1343 (re_compile_pattern, re_exec): Declare arguments and local
1344 variables `size_t' and `ssize_t' and return values `regoff_t', as
1345 appropriate.
1346 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1347 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1348 <compile_stack_type>: `size' and `avail' are now `size_t'.
1349
1350 * regex.h <regoff_t>: Use ssize_t, not int.
1351 (re_search, re_search_2, re_match, re_match_2): Arguments that
1352 specify buffer/string position and length are now ssize_t and
1353 size_t. Return type is regoff_t.
1354
1355 2011-04-16 Ben Key <bkey76@gmail.com>
1356
1357 * nsfont.m: Fixed bugs in ns_get_family and
1358 ns_descriptor_to_entity that were caused by using free to
1359 deallocate memory blocks that were allocated by xmalloc (via
1360 xstrdup). This caused Emacs to crash when compiled with
1361 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1362 --enable-checking=xmallocoverrun). xfree is now used to
1363 deallocate these memory blocks.
1364
1365 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1368
1369 emacs_write: Accept and return EMACS_INT for sizes.
1370 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1371 et seq.
1372 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1373 Accept and return EMACS_INT.
1374 (emacs_gnutls_write): Return the number of bytes written on
1375 partial writes.
1376 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1377 (emacs_read, emacs_write): Remove check for negative size, as the
1378 Emacs source code has been audited now.
1379 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1380 (emacs_read, emacs_write): Use it.
1381 * process.c (send_process): Adjust to the new signatures of
1382 emacs_write and emacs_gnutls_write. Do not attempt to store
1383 a byte offset into an 'int'; it might overflow.
1384 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1385
1386 * sound.c: Don't assume sizes fit in 'int'.
1387 (struct sound_device.period_size, alsa_period_size):
1388 Return EMACS_INT, not int.
1389 (struct sound_device.write, vox_write, alsa_write):
1390 Accept EMACS_INT, not int.
1391 (wav_play, au_play): Use EMACS_INT to store sizes and to
1392 record read return values.
1393
1394 2011-04-15 Ben Key <bkey76@gmail.com>
1395
1396 * keyboard.c (Qundefined): Don't declare static since it is used
1397 in nsfns.m.
1398 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1399 static since they are used in nsfont.m.
1400
1401 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1402
1403 * process.c (Qprocessp): Don't declare static.
1404 * lisp.h (Qprocessp): Declare again.
1405
1406 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1407
1408 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1409
1410 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 Improve C-level modularity by making more things 'static'.
1413
1414 Don't publish debugger-only interfaces to other modules.
1415 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1416 (verify_bytepos, count_markers): Move decls to the only modules
1417 that need them.
1418 * region-cache.h (pp_cache): Likewise.
1419 * window.h (check_all_windows): Likewise.
1420 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1421
1422 * sysdep.c (croak): Now static, if
1423 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1424 * syssignal.h (croak): Declare only if not static.
1425
1426 * alloc.c (refill_memory_reserve): Now static if
1427 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1428 * lisp.h (refill_memory_reserve): Declare only if not static.
1429
1430 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1431 Define only if USE_LUCID.
1432
1433 * xrdb.c (x_customization_string, x_rm_string): Now static.
1434
1435 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1436 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1437
1438 * xdisp.c (draw_row_with_mouse_face): Now static.
1439 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1440
1441 * window.h (check_all_windows): Mark externally visible.
1442
1443 * window.c (window_deletion_count): Now static.
1444
1445 * undo.c: Make symbols static if they're not exported.
1446 (last_undo_buffer, last_boundary_position, pending_boundary):
1447 Now static.
1448
1449 * textprop.c (interval_insert_behind_hooks): Now static.
1450 (interval_insert_in_front_hooks): Likewise.
1451
1452 * term.c: Make symbols static if they're not exported.
1453 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1454 (max_frame_lines, tty_set_terminal_modes):
1455 (tty_reset_terminal_modes, tty_turn_off_highlight):
1456 (get_tty_terminal): Now static.
1457 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1458 * termhooks.h (term_mouse_moveto): Do not declare if
1459 HAVE_WINDOW_SYSTEM.
1460 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1461 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1462
1463 * sysdep.c: Make symbols static if they're not exported.
1464 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1465 Now static.
1466 (sigprocmask_set, full_mask): Remove; unused.
1467 (wait_debugging): Mark as visible.
1468 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1469 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1470
1471 * syntax.c (syntax_temp): Define only if !__GNUC__.
1472
1473 * sound.c (current_sound_device, current_sound): Now static.
1474
1475 * search.c (searchbufs, searchbuf_head): Now static.
1476
1477 * scroll.c (scroll_cost): Remove; unused.
1478 * dispextern.h (scroll_cost): Remove decl.
1479
1480 * region-cache.h (pp_cache): Mark as externally visible.
1481
1482 * process.c: Make symbols static if they're not exported.
1483 (process_tick, update_tick, create_process, chan_process):
1484 (Vprocess_alist, proc_buffered_char, datagram_access):
1485 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1486 (deactivate_process): Mark defn as static, as well as decl.
1487 * lisp.h (create_process): Remove decl.
1488 * process.h (chan_process, Vprocess_alist): Remove decls.
1489
1490 * print.c: Make symbols static if they're not exported.
1491 (print_depth, new_backquote_output, being_printed, print_buffer):
1492 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1493 (print_interval, print_number_index, initial_stderr_stream):
1494 Now static.
1495 * lisp.h (Fprinc): Remove decl.
1496 (debug_output_compilation_hack): Mark as externally visible.
1497
1498 * sysdep.c (croak): Move decl from here to syssignal.h.
1499 * syssignal.h (croak): Put it here, so the API can be checked when
1500 'croak' is called from dissociate_if_controlling_tty.
1501
1502 * minibuf.c: Make symbols static if they're not exported.
1503 (minibuf_save_list, choose_minibuf_frame): Now static.
1504 * lisp.h (choose_minibuf_frame): Remove decl.
1505
1506 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1507
1508 * lread.c: Make symbols static if they're not exported.
1509 (read_objects, initial_obarray, oblookup_last_bucket_number):
1510 Now static.
1511 (make_symbol): Remove; unused.
1512 * lisp.h (initial_obarray, make_symbol): Remove decls.
1513
1514 * keyboard.c: Make symbols static if they're not exported.
1515 (single_kboard, recent_keys_index, total_keys, recent_keys):
1516 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1517 (this_single_command_key_start, echoing, last_auto_save):
1518 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1519 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1520 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1521 (Vlispy_mouse_stem, double_click_count):
1522 Now static.
1523 (force_auto_save_soon): Define only if SIGDANGER.
1524 (ignore_mouse_drag_p): Now static if
1525 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1526 (print_help): Remove; unused.
1527 (stop_character, last_timer_event): Mark as externally visible.
1528 * keyboard.h (ignore_mouse_drag_p): Declare only if
1529 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1530 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1531 * lisp.h (echoing): Remove decl.
1532 (force_auto_save_soon): Declare only if SIGDANGER.
1533 * xdisp.c (redisplay_window): Simplify code, to make it more
1534 obvious that ignore_mouse_drag_p is not accessed if !defined
1535 USE_GTK && !defined HAVE_NS.
1536
1537 * intervals.c: Make symbols static if they're not exported.
1538 (merge_properties_sticky, merge_interval_right, delete_interval):
1539 Now static.
1540 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1541
1542 * insdel.c: Make symbols static if they're not exported.
1543 However, leave prepare_to_modify_buffer alone. It's never
1544 called from outside this function, but that appears to be a bug.
1545 (combine_after_change_list, combine_after_change_buffer):
1546 (adjust_after_replace, signal_before_change): Now static.
1547 (adjust_after_replace_noundo): Remove; unused.
1548 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1549 (signal_before_change): Remove decls.
1550
1551 * indent.c (val_compute_motion, val_vmotion): Now static.
1552
1553 * image.c: Make symbols static if they're not exported.
1554 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1555 if USE_GTK.
1556 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1557 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1558
1559 * fringe.c (standard_bitmaps): Now static.
1560 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1561
1562 * frame.c: Make symbols static if they're not exported.
1563 (x_report_frame_params, make_terminal_frame): Now static.
1564 (get_frame_param): Now static, unless HAVE_NS.
1565 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1566 (x_get_resource_string): Remove; not used.
1567 * frame.h (make_terminal_frame, x_report_frame_params):
1568 (x_get_resource_string); Remove decls.
1569 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1570 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1571
1572 * font.c, fontset.c: Make symbols static if they're not exported.
1573 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1574 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1575 * font.c (font_close_object): Now static.
1576 * font.h (font_close_object): Remove.
1577 * fontset.c (FONTSET_OBJLIST): Remove.
1578 (free_realized_fontset) #if-0 the body, which does nothing.
1579 (face_suitable_for_char_p): #if-0, as it's never called.
1580 * fontset.h (face_suitable_for_char_p): Remove decl.
1581 * xfaces.c (face_at_string_position):
1582 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1583 since 0 is always ASCII.
1584
1585 * fns.c (weak_hash_tables): Now static.
1586
1587 * fileio.c: Make symbols static if they're not exported.
1588 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1589 (Vwrite_region_annotation_buffers): Now static.
1590
1591 * eval.c: Make symbols static if they're not exported.
1592 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1593 * lisp.h (backtrace_list): Remove decl.
1594
1595 * emacs.c: Make symbols static if they're not exported.
1596 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1597 (fatal_error_code, fatal_error_signal_hook, standard_args):
1598 Now static.
1599 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1600 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1601 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1602 * lisp.h (fatal_error_signal_hook): Remove decl.
1603 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1604
1605 * editfns.c: Move a (normally-unused) function to its only use.
1606 * editfns.c, lisp.h (get_operating_system_release): Remove.
1607 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1608 worth the hassle of breaking this out.
1609
1610 * xterm.c: Make symbols static if they're not exported.
1611 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1612 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1613 (x_destroy_window, x_delete_display):
1614 Now static.
1615 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1616 (x_mouse_leave): Remove; unused.
1617 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1618 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1619 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1620 Remove decls.
1621 (x_mouse_leave): Declare only if WINDOWSNT.
1622 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1623 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1624 USE_X_TOOLKIT.
1625
1626 * ftxfont.c: Make symbols static if they're not exported.
1627 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1628 HAVE_FREETYPE.
1629 * font.h (ftxfont_driver): Likewise.
1630
1631 * xfns.c: Make symbols static if they're not exported.
1632 (x_last_font_name, x_display_info_for_name):
1633 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1634 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1635 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1636 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1637 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1638 (last_show_tip_args): Now static.
1639 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1640 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1641 (x_screen_planes): Remove; unused.
1642 * dispextern.h (x_screen_planes): Remove decl.
1643
1644 * dispnew.c: Make symbols static if they're not exported.
1645 * dispextern.h (redraw_garbaged_frames, scrolling):
1646 (increment_row_positions): Remove.
1647 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1648 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1649 Now static.
1650 (redraw_garbaged_frames): Remove; unused.
1651
1652 * xfaces.c: Make symbols static if they're not exported.
1653 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1654 Remove decls.
1655 * xterm.h (defined_color): Remove decls.
1656 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1657 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1658 (menu_face_changed_default, defined_color, free_realized_face):
1659 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1660 (ascii_face_of_lisp_face): Remove; unused.
1661
1662 * xdisp.c: Make symbols static if they're not exported.
1663 * dispextern.h (scratch_glyph_row, window_box_edges):
1664 (glyph_to_pixel_coords, set_cursor_from_row):
1665 (get_next_display_element, set_iterator_to_next):
1666 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1667 (show_mouse_face): Remove decls
1668 * frame.h (message_buf_print): Likewise.
1669 * lisp.h (pop_message, set_message, check_point_in_composition):
1670 Likewise.
1671 * xterm.h (set_vertical_scroll_bar): Likewise.
1672 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1673 (message_buf_print, scratch_glyph_row, displayed_buffer):
1674 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1675 (get_next_display_element, show_mouse_face, window_box_edges):
1676 (frame_to_window_pixel_xy, check_point_in_composition):
1677 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1678 (glyph_to_pixel_coords): Remove; unused.
1679
1680 * dired.c (file_name_completion): Now static.
1681
1682 * dbusbind.c (xd_in_read_queued_messages): Now static.
1683
1684 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1685 * data.c (circular_list_error): Remove.
1686
1687 * commands.h (last_point_position, last_point_position_buffer):
1688 (last_point_position_window): Remove decls.
1689 * keyboard.c: Make these variables static.
1690
1691 * coding.h (coding, code_convert_region, encode_coding_gap):
1692 Remove decls.
1693 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1694 (iso_code_class, detect_coding, code_convert_region): Now static.
1695 (encode_coding_gap): Remove; unused.
1696
1697 * chartab.c (chartab_chars, chartab_bits): Now static.
1698
1699 * charset.h (charset_iso_8859_1): Remove decl.
1700 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1701 Now static.
1702
1703 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1704 * ccl.c (Vccl_program_table): Now static.
1705 (check_ccl_update): Remove; unused.
1706
1707 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1708 * category.h: ... from here.
1709 * category.c (check_category_table, set_category_set): Now static.
1710
1711 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1712 * lisp.h: Remove these decls.
1713
1714 * buffer.c (buffer_count): Remove unused var.
1715
1716 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1717 so that it's not optimized away.
1718 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1719 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1720 exported only to the debugger.
1721
1722 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1723 * atimer.h (run_all_atimers): Remove; not exported.
1724
1725 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1726 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1727 was inaccessible from Lisp.
1728 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1729 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1730
1731 alloc.c: Import and export fewer symbols, and remove unused items.
1732 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1733 is defined.
1734 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1735 it's not optimized away by whole-program optimization.
1736 (message_enable_multibyte, free_misc): Remove.
1737 (catchlist, handlerlist, mark_backtrace):
1738 Declare only if BYTE_MARK_STACK.
1739 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1740 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1741 (message_enable_multibyte): Remove decl.
1742 (free_misc, interval_free_list, float_block, float_block_index):
1743 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1744 (cons_free_list, last_marked_index):
1745 Now static.
1746 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1747 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1748 (mark_backtrace): Define only if BYTE_MARK_STACK.
1749 * xdisp.c (message_enable_multibyte): Now static.
1750
1751 Declare Lisp_Object Q* variables to be 'static' if not exported.
1752 This makes it easier for human readers (and static analyzers)
1753 to see whether these variables are used from other modules.
1754 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1755 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1756 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1757 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1758 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1759 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1760 * xmenu.c, xselect.c:
1761 Declare Q* vars static if they are not used in other modules.
1762 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1763 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1764 Remove decls of unexported vars.
1765 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1766
1767 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1768
1769 Make Emacs functions such as Fatom 'static' by default.
1770 This makes it easier for human readers (and static analyzers)
1771 to see whether these functions can be called from other modules.
1772 DEFUN now defines a static function. To make the function external
1773 so that it can be used in other C modules, use the new macro DEFUE.
1774 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1775 (Finit_image_library):
1776 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1777 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1778 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1779 Remove decls, since these functions are now static.
1780 (Funintern, Fget_internal_run_time): New decls, since these functions
1781 were already external.
1782
1783 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1784 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1785 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1786 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1787 * keyboard.c, keymap.c, lread.c:
1788 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1789 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1790 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1791 Mark functions with DEFUE instead of DEFUN,
1792 if they are used in other modules.
1793 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1794 decls for now-static functions.
1795 * buffer.h (Fdelete_overlay): Remove decl.
1796 * callproc.c (Fgetenv_internal): Mark as internal.
1797 * composite.c (Fremove_list_of_text_properties): Remove decl.
1798 (Fcomposition_get_gstring): New forward static decl.
1799 * composite.h (Fcomposite_get_gstring): Remove decl.
1800 * dired.c (Ffile_attributes): New forward static decl.
1801 * doc.c (Fdocumntation_property): New forward static decl.
1802 * eval.c (Ffetch_bytecode): New forward static decl.
1803 (Funintern): Remove extern decl; now in .h file where it belongs.
1804 * fileio.c (Fmake_symbolic_link): New forward static decl.
1805 * image.c (Finit_image_library): New forward static decl.
1806 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1807 * intervals.h (Fprevious_property_change):
1808 (Fremove_list_of_text_properties): Remove decls.
1809 * keyboard.c (Fthis_command_keys): Remove decl.
1810 (Fcommand_execute): New forward static decl.
1811 * keymap.c (Flookup_key): New forward static decl.
1812 (Fcopy_keymap): Now static.
1813 * keymap.h (Flookup_key): Remove decl.
1814 * process.c (Fget_process): New forward static decl.
1815 (Fprocess_datagram_address): Mark as internal.
1816 * syntax.c (Fsyntax_table_p): New forward static decl.
1817 (skip_chars): Remove duplicate decl.
1818 * textprop.c (Fprevious_property_change): New forward static decl.
1819 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1820 Now internal.
1821 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1822 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1823
1824 * editfns.c (Fformat): Remove unreachable code.
1825
1826 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1827
1828 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1829 change. (Bug#8496)
1830
1831 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1832
1833 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1834 when at ZV. (Bug#8487)
1835
1836 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1837
1838 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1839 (Bug#8437)
1840 * keyboard.c (parse_tool_bar_item): Likewise.
1841 * sound.c (sound_cleanup, alsa_close): Likewise.
1842 * termcap.c (tgetent): Likewise.
1843 * xfns.c (x_default_font_parameter): Likewise.
1844 * xsettings.c (read_and_apply_settings): Likewise.
1845
1846 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1847 (overrun_check_free): Protoize.
1848
1849 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1852 since callers should never pass a negative size.
1853 Change the signature to match that of plain 'read' and 'write'; see
1854 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1855 * lisp.h: Update prototypes of emacs_write and emacs_read.
1856
1857 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1858
1859 * xdisp.c (redisplay_window): Don't try to determine the character
1860 position of the scroll margin if the window start point w->startp
1861 is outside the buffer's accessible region. (Bug#8468)
1862
1863 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1864
1865 Fix write-region and its subroutines for buffers > 2GB.
1866 * fileio.c (a_write, e_write): Modify declaration of arguments and
1867 local variables to support buffers larger than 2GB.
1868 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1869
1870 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1871 argument, local variables, and return value.
1872
1873 * lisp.h: Update prototypes of emacs_write and emacs_read.
1874
1875 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1876
1877 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1880
1881 Fix more problems found by GCC 4.6.0's static checks.
1882
1883 * xdisp.c (vmessage): Use a better test for character truncation.
1884
1885 * charset.c (load_charset_map): <, not <=, for optimization,
1886 and to avoid potential problems with integer overflow.
1887 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1888 * casetab.c (set_identity, shuffle): Likewise.
1889 * editfns.c (Fformat): Likewise.
1890 * syntax.c (skip_chars): Likewise.
1891
1892 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1893 This also lets GCC 4.6.0 generate slightly better loop code.
1894
1895 * callint.c (Fcall_interactively): <, not <=, for optimization.
1896 (Fcall_interactively): Count the number of arguments produced,
1897 not the number of arguments given. This is simpler and lets GCC
1898 4.6.0 generate slightly better code.
1899
1900 * ftfont.c: Distingish more carefully between FcChar8 and char.
1901 The previous code passed unsigned char * to a functions like
1902 strlen and xstrcasecmp that expect char *, which does not
1903 conform to the C standard.
1904 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1905 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1906 char * when the C standard requires it.
1907
1908 * keyboard.c (read_char): Remove unused var.
1909
1910 * eval.c: Port to Windows vsnprintf (Bug#8435).
1911 Include <limits.h>.
1912 (SIZE_MAX): Define if the headers do not.
1913 (verror): Do not give up if vsnprintf returns a negative count.
1914 Instead, grow the buffer. This ports to Windows vsnprintf, which
1915 does not conform to C99. Problem reported by Eli Zaretskii.
1916 Also, simplify the allocation scheme, by avoiding the need for
1917 calling realloc, and removing the ALLOCATED variable.
1918
1919 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1920
1921 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1922 But keep the doprint source code for now, as we might revamp it
1923 and use it again (Bug#8435).
1924 * lisp.h (doprnt): Remove.
1925 * Makefile.in (base_obj): Remove doprnt.o.
1926 * deps.mk (doprnt.o): Remove.
1927
1928 error: Print 32- and 64-bit integers portably (Bug#8435).
1929 Without this change, on typical 64-bit hosts error ("...%d...", N)
1930 was used to print both 32- and 64-bit integers N, which relied on
1931 undefined behavior.
1932 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1933 New macro.
1934 * lisp.h (error, verror): Mark as printf-like functions.
1935 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1936 Report overflow in size calculations when allocating printf buffer.
1937 Do not truncate output string at its first null byte.
1938 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1939 Truncate the output at a character boundary, since vsnprintf does not
1940 do that.
1941 * charset.c (check_iso_charset_parameter): Convert internal
1942 character to string before calling 'error', since %c now has the
1943 printf meaning.
1944 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1945 overflow when computing char to be passed to 'error'. Do not
1946 pass Lisp_Object to 'error'; pass the integer instead.
1947 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1948 formatted with plain %d.
1949
1950 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1951
1952 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1953
1954 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1955
1956 * xterm.c (x_catch_errors): Remove duplicate declaration.
1957
1958 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1959
1960 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1961
1962 2011-04-10 Jim Meyering <meyering@redhat.com>
1963
1964 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1965 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1966 return ssize_t not "int", and use size_t as the buffer length.
1967 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1968 * gnutls.h: Update declarations.
1969 * process.c (read_process_output): Use ssize_t, to match.
1970 (send_process): Likewise.
1971
1972 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1973
1974 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1975
1976 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1977
1978 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1979 Use unsigned char, to match FcChar8 type definition.
1980
1981 * xterm.c (handle_one_xevent):
1982 * xmenu.c (create_and_show_popup_menu):
1983 * xselect.c (x_decline_selection_request)
1984 (x_reply_selection_request): Avoid type-punned deref of X events.
1985
1986 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1987
1988 Fix some uses of `int' instead of EMACS_INT.
1989 * search.c (string_match_1, fast_string_match)
1990 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1991 (scan_buffer, find_next_newline_no_quit)
1992 (find_before_next_newline, search_command, Freplace_match)
1993 (Fmatch_data): Make some `int' variables be EMACS_INT.
1994
1995 * xdisp.c (display_count_lines): 3rd argument and return value now
1996 EMACS_INT. All callers changed.
1997 (pint2hrstr): Last argument is now EMACS_INT.
1998
1999 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2000 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2001 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2002 (decode_coding_utf_16, decode_coding_emacs_mule)
2003 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2004 (decode_coding_ccl, decode_coding_charset)
2005 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2006 (decode_coding_iso_2022, decode_coding_emacs_mule)
2007 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2008 <char_offset, last_offset>: Declare EMACS_INT.
2009 (encode_coding_utf_8, encode_coding_utf_16)
2010 (encode_coding_emacs_mule, encode_invocation_designation)
2011 (encode_designation_at_bol, encode_coding_iso_2022)
2012 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2013 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2014 Declare EMACS_INT.
2015 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2016 (encode_invocation_designation): Last argument P_NCHARS is now
2017 EMACS_INT.
2018 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2019 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2020
2021 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2022 All users changed.
2023
2024 * ccl.c (Fccl_execute_on_string): Declare some variables
2025 EMACS_INT.
2026
2027 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2028
2029 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2030
2031 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2032
2033 * process.c (Fformat_network_address): Doc fix.
2034
2035 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2036
2037 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2038
2039 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2040
2041 * keyboard.c (read_char): Call Lisp function help-form-show,
2042 instead of using internal_with_output_to_temp_buffer.
2043 (Qhelp_form_show): New var.
2044 (syms_of_keyboard): Use DEFSYM macro.
2045
2046 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2047
2048 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2049
2050 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2051
2052 * process.c (Flist_processes): Remove to Lisp.
2053 (list_processes_1): Delete.
2054
2055 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2056
2057 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2058
2059 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2060
2061 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 Fix more problems found by GCC 4.6.0's static checks.
2064
2065 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2066
2067 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2068
2069 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2070
2071 * xdisp.c (vmessage): Mark as a printf-like function.
2072
2073 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2074
2075 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2076
2077 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2078 printf-like functions.
2079 (tiff_load): Add casts to remove these marks before passing them
2080 to system-supplied API.
2081
2082 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2083
2084 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2085 This avoids several warnings with gcc -Wstrict-overflow.
2086 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2087 directly, rather than having caller test rule sign. This avoids
2088 some unnecessary tests.
2089 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2090 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2091 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2092
2093 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2094 (xfont_open): Avoid unnecessary tests.
2095
2096 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2097
2098 * composite.h, composite.c (composition_gstring_put_cache):
2099 Use EMACS_INT, not int, for length.
2100
2101 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2102 breaking out part of COMPOSITION_DECODE_RULE.
2103 (COMPOSITION_DECODE_RULE): Use it.
2104 * composite.c (get_composition_id): Remove unused local vars,
2105 by using the new macro.
2106
2107 * textprop.c (set_text_properties_1): Change while to do-while,
2108 since the condition is always true at first.
2109
2110 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2111 (interval_deletion_adjustment): Return unsigned value.
2112 All uses changed.
2113
2114 * process.c (list_processes_1, create_pty, read_process_output):
2115 (exec_sentinel): Remove vars that were set but not used.
2116 (create_pty): Remove unnecessary "volatile"s.
2117 (Fnetwork_interface_info): Avoid possibility of int overflow.
2118 (read_process_output): Do adaptive read buffering even if carryover.
2119 (read_process_output): Simplify nbytes computation if buffered.
2120
2121 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2122
2123 * syntax.c (scan_words): Remove var that was set but not used.
2124 (update_syntax_table): Use unsigned instead of int.
2125
2126 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2127 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2128 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2129
2130 * print.c (print_error_message): Avoid int overflow.
2131
2132 * font.c (font_list_entities): Redo for clarity,
2133 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2134
2135 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2136 (font_score): Avoid potential overflow in diff calculation.
2137
2138 * fns.c (substring_both): Remove var that is set but not used.
2139 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2140
2141 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2142
2143 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2144 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2145 can always succeed if overflow has undefined behavior.
2146
2147 * search.c (boyer_moore, wordify): Remove vars set but not used.
2148 (wordify): Omit three unnecessary tests.
2149
2150 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2151 All callers changed. This avoids the need for an unused var.
2152
2153 * casefiddle.c (casify_region): Remove var that is set but not used.
2154
2155 * dired.c (file_name_completion): Remove var that is set but not used.
2156
2157 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2158
2159 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2160 (Finsert_file_contents): Remove unnecessary code checking fd.
2161
2162 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2163 Check for integer overflow on size calculations.
2164
2165 * buffer.c (Fprevious_overlay_change): Remove var that is set
2166 but not used.
2167
2168 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2169 Remove vars that are set but not used.
2170 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2171 (timer_check_2): Mark vars as initialized.
2172
2173 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2174
2175 * image.c (lookup_image): Remove var that is set but not used.
2176 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2177
2178 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2179 that are set but not used.
2180
2181 * xfns.c (make_invisible_cursor): Don't return garbage
2182 if XCreateBitmapFromData fails (Bug#8410).
2183
2184 * xselect.c (x_get_local_selection, x_handle_property_notify):
2185 Remove vars that are set but not used.
2186
2187 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2188 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2189
2190 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2191 Remove var that is set but not used.
2192 (scroll_bar_windows_size): Now size_t, not int.
2193 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2194 Check for overflow.
2195
2196 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2197 (map_tty_color) [!defined MSDOS]: Likewise.
2198
2199 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2200
2201 * coding.c: Remove vars that are set but not used.
2202 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2203 All callers changed.
2204 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2205 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2206 (decode_coding_charset): Remove vars that are set but not used.
2207
2208 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2209 that is set but not used.
2210
2211 * print.c (print_object): Remove var that is set but not used.
2212
2213 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2214 The gnulib version avoids calling malloc in the usual case,
2215 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2216 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2217 * filelock.c (current_lock_owner): Likewise.
2218 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2219 * sysdep.c: Include allocator.h, careadlinkat.h.
2220 (emacs_no_realloc_allocator): New static constant.
2221 (emacs_readlink): New function.
2222 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2223 ../lib/careadlinkat.h.
2224
2225 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2226
2227 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2228 first non-nil return value).
2229
2230 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2231
2232 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2233 if not defined (Bug#8403).
2234
2235 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2236
2237 * xdisp.c (display_count_lines): Remove parameter `start',
2238 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2239 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2240 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2241 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2242 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2243 and thereabouts. All callers changed.
2244 (get_per_char_metric): Remove parameter `f', unused since
2245 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2246
2247 2011-04-02 Jim Meyering <meyering@redhat.com>
2248
2249 do not dereference NULL upon failed strdup
2250 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2251 (ns_get_family): Likewise.
2252
2253 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2254
2255 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2256
2257 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2258
2259 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2260 later (Bug#8403).
2261
2262 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2263
2264 Add lexical binding.
2265
2266 * window.c (Ftemp_output_buffer_show): New fun.
2267 (Fsave_window_excursion):
2268 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2269
2270 * lread.c (lisp_file_lexically_bound_p): New function.
2271 (Fload): Bind Qlexical_binding.
2272 (readevalloop): Remove `evalfun' arg.
2273 Bind Qinternal_interpreter_environment.
2274 (Feval_buffer): Bind Qlexical_binding.
2275 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2276 Mark as dynamic.
2277 (syms_of_lread): Declare `lexical-binding'.
2278
2279 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2280
2281 * keyboard.c (eval_dyn): New fun.
2282 (menu_item_eval_property): Use it.
2283
2284 * image.c (parse_image_spec): Use Ffunctionp.
2285
2286 * fns.c (concat, mapcar1): Accept byte-code-functions.
2287
2288 * eval.c (Fsetq): Handle lexical vars.
2289 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2290 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2291 (FletX, Flet): Obey lexical binding.
2292 (Fcommandp): Handle closures.
2293 (Feval): New `lexical' arg.
2294 (eval_sub): New function extracted from Feval. Use it almost
2295 everywhere where Feval was used. Look up vars in lexical env.
2296 Handle closures.
2297 (Ffunctionp): Move from subr.el.
2298 (Ffuncall): Handle closures.
2299 (apply_lambda): Remove `eval_flags'.
2300 (funcall_lambda): Handle closures and new byte-code-functions.
2301 (Fspecial_variable_p): New function.
2302 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2303 but without exporting it to Lisp.
2304
2305 * doc.c (Fdocumentation, store_function_docstring):
2306 * data.c (Finteractive_form): Handle closures.
2307
2308 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2309 interactive spec.
2310
2311 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2312 New byte-codes.
2313 (exec_byte_code): New function extracted from Fbyte_code to handle new
2314 calling convention for byte-code-functions. Add new byte-codes.
2315
2316 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2317
2318 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2319
2320 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2321
2322 * xdisp.c (redisplay_internal): Fix prototype.
2323
2324 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2325
2326 * xdisp.c (SCROLL_LIMIT): New macro.
2327 (try_scrolling): Use it when setting scroll_limit.
2328 Limit scrolling to 100 screen lines.
2329 (redisplay_window): Even when falling back on "recentering",
2330 position point in the window according to scroll-conservatively,
2331 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2332
2333 (try_scrolling): When point is above the window, allow searching
2334 as far as scroll_max, or one screenful, to compute vertical
2335 distance from PT to the scroll margin position. This prevents
2336 try_scrolling from unnecessarily failing when
2337 scroll-conservatively is set to a value slightly larger than the
2338 window height. Clean up the case of PT below the margin at bottom
2339 of window: scroll_max can no longer be INT_MAX. When aggressive
2340 scrolling is in use, don't let point enter the opposite scroll
2341 margin as result of the scroll.
2342 (syms_of_xdisp) <scroll-conservatively>: Document the
2343 threshold of 100 lines for never-recentering scrolling.
2344
2345 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2346
2347 * dispextern.h (move_it_by_lines):
2348 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2349 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2350 (message_log_check_duplicate): Remove parameters `prev_bol' and
2351 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2352 (redisplay_internal): Remove parameter `preserve_echo_area',
2353 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2354
2355 * indent.c (Fvertical_motion):
2356 * window.c (window_scroll_pixel_based, Frecenter):
2357 Don't pass `need_y_p' to `move_it_by_lines'.
2358
2359 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2360
2361 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2362 steal a few bits to be more compact.
2363 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2364 Remove unneeded casts.
2365
2366 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2367
2368 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2369
2370 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2371 binding" message (bug#7967).
2372
2373 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 Fix more problems found by GCC 4.6.0's static checks.
2376
2377 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2378 Remove unused local var.
2379
2380 * editfns.c (Fmessage_box): Remove unused local var.
2381
2382 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2383 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2384 Omit unused local vars.
2385 * window.c (shrink_windows): Omit unused local var.
2386 * menu.c (digest_single_submenu): Omit unused local var.
2387 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2388 Omit unused local var.
2389
2390 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2391 Don't assume string length fits in int.
2392 (keyremap_step, read_key_sequence): Use size_t for sizes.
2393 (read_key_sequence): Don't check last_real_key_start redundantly.
2394
2395 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2396 instead of alloca (Bug#8344).
2397
2398 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2399 (Fbacktrace_frame): Don't assume nframes fits in int.
2400
2401 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2402
2403 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2404 concerns.
2405
2406 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2407
2408 * cm.c (calccost): Turn while-do into do-while, for clarity.
2409
2410 * keyboard.c (syms_of_keyboard): Use the same style as later
2411 in this function when indexing through an array. This also
2412 works around GCC bug 48267.
2413
2414 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2415
2416 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2417
2418 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2419 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2420
2421 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2422 This avoids undefined behavior on integer overflow, and is a bit
2423 more convenient anyway since it is compared to a size_t variable.
2424
2425 Variadic C functions now count arguments with size_t, not int.
2426 This avoids an unnecessary limitation on 64-bit machines, which
2427 caused (substring ...) to crash on large vectors (Bug#8344).
2428 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2429 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2430 All variadic functions and their callers changed accordingly.
2431 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2432 * data.c (arith_driver, float_arith_driver): Likewise.
2433 * editfns.c (general_insert_function): Likewise.
2434 * eval.c (struct backtrace.nargs, interactive_p)
2435 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2436 (funcall_lambda, mark_backtrace): Likewise.
2437 * fns.c (concat): Likewise.
2438 * frame.c (x_set_frame_parameters): Likewise.
2439 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2440 0 if not found, not -1. All callers changed.
2441
2442 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2443 (stack_copy_size): Now size_t, not int.
2444 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2445
2446 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2449 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2450 All callers changed.
2451
2452 * lisp.h (multibyte_char_to_unibyte):
2453 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2454 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2455 * character.h (CHAR_TO_BYTE8):
2456 * cmds.c (internal_self_insert):
2457 * editfns.c (general_insert_function):
2458 * keymap.c (push_key_description):
2459 * search.c (Freplace_match):
2460 * xdisp.c (message_dolog, set_message_1): All callers changed.
2461
2462 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2463
2464 * keyboard.c (safe_run_hook_funcall): New function.
2465 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2466 don't set the hook to nil, but remove the offending function instead.
2467 (Qcommand_hook_internal): Remove, unused.
2468 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2469 Vcommand_hook_internal.
2470
2471 * eval.c (enum run_hooks_condition): Remove.
2472 (funcall_nil, funcall_not): New functions.
2473 (run_hook_with_args): Call each function through a `funcall' argument.
2474 Remove `cond' argument, now redundant.
2475 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2476 (Frun_hook_with_args_until_failure): Adjust accordingly.
2477 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2478
2479 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2480
2481 * dispextern.h (string_buffer_position): Remove declaration.
2482
2483 * print.c (strout): Remove parameter `multibyte', unused since
2484 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2485
2486 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2487 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2488 All callers changed.
2489
2490 * w32.c (_wsa_errlist): Use braces for struct initializers.
2491
2492 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2493 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2494 All callers changed.
2495 (string_buffer_position): Likewise. Also, make static (it's never
2496 used outside xdisp.c).
2497 (cursor_row_p): Remove parameter `w', unused since
2498 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2499 (decode_mode_spec): Remove parameter `precision', introduced during
2500 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2501 All callers changed.
2502
2503 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2504
2505 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2506
2507 2011-03-27 Anders Lindgren <andlind@gmail.com>
2508
2509 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2510 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2511 (ns_update_auto_hide_menu_bar): New functions.
2512 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2513 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2514 ns_constrain_all_frames.
2515 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2516 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2517
2518 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2519
2520 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2521
2522 2011-03-27 Glenn Morris <rgm@gnu.org>
2523
2524 * syssignal.h: Replace RETSIGTYPE with void.
2525 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2526 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2527 Replace SIGTYPE with void everywhere.
2528 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2529 * s/template.h (SIGTYPE): Remove commented out definition.
2530
2531 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2532
2533 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2534 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2535
2536 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2537
2538 * w32.c (read_unc_volume): Use parameter `henum', instead of
2539 global variable `wget_enum_handle'.
2540
2541 * keymap.c (describe_vector): Remove parameters `indices' and
2542 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2543 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2544
2545 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2546
2547 * keyboard.c (timer_check): Remove parameter `do_it_now',
2548 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2549 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2550 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2551
2552 * keyboard.c (read_char):
2553 * w32menu.c (w32_menu_display_help):
2554 * xmenu.c (show_help_event, menu_help_callback):
2555 Adjust calls to `show_help_echo'.
2556
2557 * gtkutil.c (xg_maybe_add_timer):
2558 * keyboard.c (readable_events):
2559 * process.c (wait_reading_process_output):
2560 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2561
2562 * insdel.c (adjust_markers_gap_motion):
2563 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2564 (gap_left, gap_right): Don't call it.
2565
2566 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2567
2568 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2569 incurred during fontification.
2570
2571 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2572
2573 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2574 (DEFVAR_PER_BUFFER): Don't pass it.
2575
2576 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2577 (scrolling_window): Don't pass it.
2578
2579 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2580
2581 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2582
2583 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2584 and `suffix'.
2585 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2586 of variables specific to SELinux and computation of `encoded_absname'.
2587
2588 * image.c (XPutPixel): Remove unused variable `height'.
2589
2590 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2591
2592 * unexw32.c (get_section_info): Remove unused variable `section'.
2593
2594 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2595 (system_process_attributes): Remove unused variable `sess'.
2596 (sys_read): Remove unused variable `err'.
2597
2598 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2599 (w32_wnd_proc): Remove unused variable `isdead'.
2600 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2601 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2602 (x_create_tip_frame): Remove unused variable `tem'.
2603
2604 * w32inevt.c (w32_console_read_socket):
2605 Remove unused variable `no_events'.
2606
2607 * w32term.c (x_draw_composite_glyph_string_foreground):
2608 Remove unused variable `width'.
2609
2610 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2611
2612 * w32term.c (x_set_glyph_string_clipping):
2613 Don't pass uninitialized region to CombineRgn.
2614
2615 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2616
2617 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2618 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2619 (Fx_close_connection): Remove unused variable `i'.
2620
2621 * w32font.c (w32font_draw): Return number of glyphs.
2622 (w32font_open_internal): Remove unused variable `i'.
2623 (w32font_driver): Add missing initializer.
2624
2625 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2626 (fill_in_menu): Remove unused variable `items_added'.
2627
2628 * w32term.c (last_mouse_press_frame): Remove static global variable.
2629 (w32_clip_to_row): Remove unused variable `f'.
2630 (x_delete_terminal): Remove unused variable `i'.
2631
2632 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2633 (NOTHING): Remove unused static global variable.
2634 (uniscribe_check_otf): Remove unused variable `table'.
2635 (uniscribe_font_driver): Add missing initializers.
2636
2637 2011-03-23 Julien Danjou <julien@danjou.info>
2638
2639 * term.c (Fsuspend_tty, Fresume_tty):
2640 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2641 * window.c (temp_output_buffer_show):
2642 * insdel.c (signal_before_change):
2643 * frame.c (Fhandle_switch_frame):
2644 * fileio.c (Fdo_auto_save):
2645 * emacs.c (Fkill_emacs):
2646 * editfns.c (save_excursion_restore):
2647 * cmds.c (internal_self_insert):
2648 * callint.c (Fcall_interactively):
2649 * buffer.c (Fkill_all_local_variables):
2650 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2651 Use Frun_hooks.
2652 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2653 unconditionnaly since it does the check itself.
2654
2655 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 Fix more problems found by GCC 4.5.2's static checks.
2658
2659 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2660 the first time through the loop, since we know p0 < p1 then.
2661 This also avoids a gcc -Wstrict-overflow warning.
2662
2663 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2664 leading to a memory leak, possible in functions like
2665 load_charset_map_from_file that can allocate an unbounded number
2666 of objects (Bug#8318).
2667
2668 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2669 that could (at least in theory) be that large.
2670
2671 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2672 This is less likely to overflow, and avoids undefined behavior if
2673 overflow does occur. All callers changed. Use strtoul to scan
2674 for the unsigned long integer.
2675 (pint2hrstr): Simplify and tune code slightly.
2676 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2677
2678 * scroll.c (do_scrolling): Work around GCC bug 48228.
2679 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2680
2681 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2682 This also avoids a warning with gcc -Wstrict-overflow.
2683 (validate_x_resource_name): Simplify count usage.
2684 This also avoids a warning with gcc -Wstrict-overflow.
2685
2686 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2687 fail (Bug#8306).
2688
2689 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2690
2691 * process.c (Fmake_network_process): Use socklen_t, not int,
2692 where POSIX says socklen_t is required in portable programs.
2693 This fixes a porting bug on hosts like 64-bit HP-UX, where
2694 socklen_t is wider than int (Bug#8277).
2695 (Fmake_network_process, server_accept_connection):
2696 (wait_reading_process_output, read_process_output):
2697 Likewise.
2698
2699 * process.c: Rename or move locals to avoid shadowing.
2700 (list_processes_1, Fmake_network_process):
2701 (read_process_output_error_handler, exec_sentinel_error_handler):
2702 Rename or move locals.
2703 (Fmake_network_process): Define label "retry_connect" only if needed.
2704 (Fnetwork_interface_info): Fix pointer signedness.
2705 (process_send_signal): Add cast to avoid pointer signedness problem.
2706 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2707 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2708
2709 Make tparam.h and terminfo.c consistent.
2710 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2711 Include tparam.h instead, since it declares them.
2712 * cm.h (PC): Remove extern decl; tparam.h now does this.
2713 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2714 * terminfo.c: Include tparam.h, to check interfaces.
2715 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2716 (tparam): Adjust signature to match interface in tparam.h;
2717 this removes some undefined behavior. Check that outstring and len
2718 are zero, which they always are with Emacs.
2719 * tparam.h (PC, BC, UP): New extern decls.
2720
2721 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2722 (xftfont_open): Rename locals to avoid shadowing.
2723
2724 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2725 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2726 (OTF_TAG_SYM): Omit macro if not needed.
2727 (ftfont_list): Remove unused local.
2728 (get_adstyle_property, ftfont_pattern_entity):
2729 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2730 Rename locals to avoid shadowing.
2731
2732 * xfont.c (xfont_list_family): Mark var as initialized.
2733
2734 * xml.c (make_dom): Now static.
2735
2736 * composite.c (composition_compute_stop_pos): Rename local to
2737 avoid shadowing.
2738 (composition_reseat_it): Remove unused locals.
2739 (find_automatic_composition, composition_adjust_point): Likewise.
2740 (composition_update_it): Mark var as initialized.
2741 (find_automatic_composition): Mark vars as initialized,
2742 with a FIXME (Bug#8290).
2743
2744 character.h: Rename locals to avoid shadowing.
2745 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2746 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2747 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2748 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2749 to avoid shadowing.
2750
2751 * textprop.c (property_change_between_p): Remove; unused.
2752
2753 * intervals.c (interval_start_pos): Now static.
2754
2755 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2756
2757 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2758 Rename locals to avoid shadowing.
2759
2760 * sound.c (wav_play, au_play, Fplay_sound_internal):
2761 Fix pointer signedness.
2762 (alsa_choose_format): Remove unused local var.
2763 (wav_play): Initialize a variable to 0, to prevent undefined
2764 behavior (Bug#8278).
2765
2766 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2767
2768 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2769
2770 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2771 clobbering (Bug#8298).
2772 * sysdep.c (sys_subshell): Likewise.
2773 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2774
2775 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2776 This should get cleaned up, so that child_setup has the
2777 same signature on all platforms.
2778
2779 * callproc.c (call_process_cleanup): Now static.
2780 (relocate_fd): Rename locals to avoid shadowing.
2781
2782 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2783
2784 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2785 not to be necessary, and produces flickering.
2786
2787 2011-03-20 Glenn Morris <rgm@gnu.org>
2788
2789 * config.in: Remove file.
2790
2791 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2792
2793 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2794 are now in src/globals.h.
2795 (syms_of_minibuf): Remove spurious & from previous change.
2796
2797 2011-03-20 Leo <sdl.web@gmail.com>
2798
2799 * minibuf.c (completing-read-function): New variable.
2800 (completing-read-default): Rename from completing-read.
2801 (completing-read): Call completing-read-function.
2802
2803 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * xfaces.c (Fx_load_color_file):
2806 Read color file from absolute filename (bug#8250).
2807
2808 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2809
2810 * makefile.w32-in: Update dependencies.
2811
2812 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2813
2814 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2815
2816 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2817
2818 Fix more problems found by GCC 4.5.2's static checks.
2819
2820 * process.c (make_serial_process_unwind, send_process_trap):
2821 (sigchld_handler): Now static.
2822
2823 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2824 That way, the code declares only the vars that it needs.
2825 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2826 * s/cygwin.h (PTY_ITERATION): Likewise.
2827 * s/darwin.h (PTY_ITERATION): Likewise.
2828 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2829
2830 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2831 * process.c (allocate_pty): Don't declare stb unless it's needed.
2832
2833 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2834 (CONSTANTLIM): Remove; unused.
2835 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2836 Define only if needed.
2837
2838 * unexelf.c (unexec): Name an expression,
2839 to avoid gcc -Wbad-function-cast warning.
2840 Use a different way to cause a compilation error if anyone uses
2841 n rather than nn, a way that does not involve shadowing.
2842 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2843
2844 * deps.mk (unexalpha.o): Remove; unused.
2845
2846 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2847 * unexec.h: New file.
2848 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2849 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2850 Depend on unexec.h.
2851 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2852 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2853 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2854 Change as necessary to match prototype in unexec.h.
2855
2856 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2857 shadowing.
2858 (back_comment, skip_chars): Mark vars as initialized.
2859
2860 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2861 Rename locals to avoid shadowing.
2862
2863 * lread.c (read1): Rewrite so as not to use empty "else".
2864 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2865
2866 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2867
2868 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2869 warning when compiling print.c.
2870
2871 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2872 instead of using an uninitialized var.
2873 (font_sort_entities): Mark var as initialized.
2874
2875 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2876
2877 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2878 pointers to constants.
2879 (font_parse_fcname): Remove unused vars.
2880 (font_delete_unmatched): Now static.
2881 (font_get_spec): Remove; unused.
2882 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2883 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2884 Rename or move locals to avoid shadowing.
2885
2886 * fns.c (require_nesting_list, require_unwind): Now static.
2887 (Ffillarray): Rename locals to avoid shadowing.
2888
2889 * floatfns.c (domain_error2): Define only if needed.
2890 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2891
2892 * alloc.c (mark_backtrace): Move decl from here ...
2893 * lisp.h: ... to here, so that it can be checked.
2894
2895 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2896 (Fdefvar): Rewrite so as not to use empty "else".
2897 (lisp_indirect_variable): Name an expression,
2898 to avoid gcc -Wbad-function-cast warning.
2899 (Fdefvar): Rename locals to avoid shadowing.
2900
2901 * callint.c (quotify_arg, quotify_args): Now static.
2902 (Fcall_interactively): Rename locals to avoid shadowing.
2903 Use const pointer when appropriate.
2904
2905 * lisp.h (get_system_name, get_operating_system_release):
2906 Move decls here, to check interfaces.
2907 * process.c (get_operating_system_release): Move decl to lisp.h.
2908 * xrdb.c (get_system_name): Likewise.
2909 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2910 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2911 some of which prompt warnings from gcc -Wbad-function-cast.
2912 (Fformat_time_string, Fencode_time, Finsert_char):
2913 (Ftranslate_region_internal, Fformat):
2914 Rename or remove local vars to avoid shadowing.
2915 (Ftranslate_region_internal): Mark var as initialized.
2916
2917 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2918 avoid shadowing.
2919
2920 * lisp.h (eassert): Check that the argument compiles, even if
2921 ENABLE_CHECKING is not defined.
2922
2923 * data.c (Findirect_variable): Name an expression, to avoid
2924 gcc -Wbad-function-cast warning.
2925 (default_value, arithcompare, arith_driver, arith_error): Now static.
2926 (store_symval_forwarding): Rename local to avoid shadowing.
2927 (Fmake_variable_buffer_local, Fmake_local_variable):
2928 Mark variables as initialized.
2929 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2930
2931 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2932 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2933 Rename locals to avoid shadowing.
2934 (mark_stack): Move local variables into the #ifdef region where
2935 they're used.
2936 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2937 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2938 needed otherwise.
2939 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2940 (GC_STRING_CHARS): Remove; not used.
2941 (Fmemory_limit): Cast sbrk's returned value to char *.
2942
2943 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2944 avoids undefined behavior in theory.
2945
2946 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2947
2948 Use functions, not macros, for up- and down-casing (Bug#8254).
2949 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2950 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2951 to use the following functions instead of these macros.
2952 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2953 EMACS_INT, since callers assume the returned value fits in int.
2954 (upcase1): Likewise, for UPCASE_TABLE.
2955 (uppercasep, lowercasep, upcase): New static inline functions.
2956 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2957 the race-condition problem in the old DOWNCASE.
2958
2959 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2960 Rename locals to avoid shadowing.
2961 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2962 (regex_compile, re_search_2, re_match_2_internal):
2963 Remove unused local vars.
2964 (FREE_VAR): Rewrite so as not to use empty "else",
2965 which gcc can warn about.
2966 (regex_compile, re_match_2_internal): Mark locals as initialized.
2967 (RETALLOC_IF): Define only if needed.
2968 (WORDCHAR_P): Likewise. This one is never needed, but is used
2969 only in a comment talking about a compiler bug, so put inside
2970 the #if 0 of that comment.
2971 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2972 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2973 Remove; unused.
2974
2975 * search.c (boyer_moore): Rename locals to avoid shadowing.
2976 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2977 (PREV_CHAR_BOUNDARY): Likewise.
2978
2979 * search.c (simple_search): Remove unused var.
2980
2981 * dired.c (compile_pattern): Move decl from here ...
2982 * lisp.h: ... to here, so that it can be checked.
2983 (struct re_registers): New forward decl.
2984
2985 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2986
2987 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2988 All uses changed.
2989 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2990 Rename locals to avoid shadowing.
2991 (Fvertical_motion): Mark locals as initialized.
2992
2993 * casefiddle.c (casify_object, casify_region): Now static.
2994 (casify_region): Mark local as initialized.
2995
2996 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2997
2998 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2999 New macros, so that the caller can use some names other than
3000 gcpro1, gcpro2, etc.
3001 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3002 of the new macros.
3003 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3004 argument, for consistency with GCPRO2_VAR, etc: it is now the
3005 prefix of the variable, not the variable itself. All uses
3006 changed.
3007 * dired.c (directory_files_internal, file_name_completion):
3008 Rename locals to avoid shadowing.
3009
3010 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3011 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3012 dired.c's scmp function, had undefined behavior.
3013 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3014 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3015 * buffer.h: ... to here, because these macros use current_buffer,
3016 and the new implementation with inline functions needs to have
3017 current_buffer in scope now, rather than later when the macros
3018 are used.
3019 (downcase, upcase1): New static inline functions.
3020 (DOWNCASE, UPCASE1): Reimplement using these functions.
3021 This avoids undefined behavior in expressions like
3022 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3023 from race conditions in accessing the global variables
3024 case_temp1 and case_temp2.
3025 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3026 * lisp.h (case_temp1, case_temp2): Remove their decls.
3027 * character.h (ASCII_CHAR_P): Move from here ...
3028 * lisp.h: ... to here, so that the inline functions mentioned
3029 above can use them.
3030
3031 * dired.c (directory_files_internal_unwind): Now static.
3032
3033 * fileio.c (file_name_as_directory, directory_file_name):
3034 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3035 Now static.
3036 (file_name_as_directory): Use const pointers when appropriate.
3037 (Fexpand_file_name): Likewise. In particular, newdir might
3038 point at constant storage, so make it a const pointer.
3039 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3040 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3041 signedness issues.
3042 (Fset_file_times, Finsert_file_contents, auto_save_error):
3043 Rename locals to avoid shadowing.
3044
3045 * minibuf.c (choose_minibuf_frame_1): Now static.
3046 (Ftry_completion, Fall_completions): Rename or remove locals
3047 to avoid shadowing.
3048
3049 * marker.c (bytepos_to_charpos): Remove; unused.
3050
3051 * lisp.h (verify_bytepos, count_markers): New decls,
3052 so that gcc does not warn that these functions aren't declared.
3053
3054 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3055 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3056 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3057 (copy_text): Remove unused local var.
3058
3059 * filelock.c (within_one_second): Now static.
3060 (lock_file_1): Rename local to avoid shadowing.
3061
3062 * buffer.c (fix_overlays_before): Mark locals as initialized.
3063 (fix_start_end_in_overlays): Likewise. This function should be
3064 simplified by using pointers-to-pointers, but that's a different
3065 matter.
3066 (switch_to_buffer_1): Now static.
3067 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3068 (report_overlay_modification): Rename locals to avoid shadowing.
3069
3070 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3071 Fix pointer signedness issue.
3072 (sys_subshell): Mark local as volatile if checking for lint,
3073 to suppress a gcc -Wclobbered warning that does not seem to be right.
3074 (MAXPATHLEN): Define only if needed.
3075
3076 * process.c (serial_open, serial_configure): Move decls from here ...
3077 * systty.h: ... to here, so that they can be checked.
3078
3079 * fns.c (get_random, seed_random): Move extern decls from here ...
3080 * lisp.h: ... to here, so that they can be checked.
3081
3082 * sysdep.c (reset_io): Now static.
3083 (wait_for_termination_signal): Remove; unused.
3084
3085 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3086 (copy_keymap_item, append_key, push_text_char_description):
3087 Now static.
3088 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3089 (DENSE_TABLE_SIZE): Remove; unused.
3090 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3091 (describe_map_tree):
3092 Rename locals to avoid shadowing.
3093
3094 * keyboard.c: Declare functions static if they are not used elsewhere.
3095 (echo_char, echo_dash, cmd_error, top_level_2):
3096 (poll_for_input, handle_async_input): Now static.
3097 (read_char, kbd_buffer_get_event, make_lispy_position):
3098 (make_lispy_event, make_lispy_movement, apply_modifiers):
3099 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3100 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3101 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3102 (read_key_sequence, read_char): Mark locals as initialized.
3103 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3104
3105 * keyboard.h (make_ctrl_char): New decl.
3106 (mark_kboards): Move decl here ...
3107 * alloc.c (mark_kboards): ... from here.
3108
3109 * lisp.h (force_auto_save_soon): New decl.
3110
3111 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3112 (DEFINE_DUMMY_FUNCTION): New macro.
3113 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3114 Use it.
3115 (main): Add casts to avoid warnings
3116 if GCC considers string literals to be constants.
3117
3118 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3119
3120 * dbusbind.c: Pointer signedness fixes.
3121 (xd_signature, xd_append_arg, xd_initialize):
3122 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3123 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3124 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3125 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3126
3127 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3128 if GCC considers string literals to be constants.
3129 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3130
3131 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3132
3133 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3134 (print_preprocess, print_object): New macro to fix last change.
3135
3136 * print.c (print_preprocess): Don't forget font objects.
3137
3138 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3139
3140 * emacs.c (USAGE3): Doc fixes.
3141
3142 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3143
3144 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3145 structure.
3146
3147 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3148
3149 * lisp.h (VWindow_system, Qfile_name_history):
3150 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3151 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3152 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3153
3154 * w32select.c: Don't #include "keyboard.h".
3155 (run_protected): Add extern declaration for waiting_for_input.
3156
3157 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3158 * w32console.c (detect_input_pending, read_input_pending)
3159 (encode_terminal_code):
3160 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3161 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3162 (w32_system_caret_y, Qfile_name_history):
3163 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3164 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3165 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3166 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3167 * w32proc.c (Qlocal, report_file_error):
3168 * w32term.c (Vwindow_system, updating_frame):
3169 * w32uniscribe.c (initialized, uniscribe_font_driver):
3170 Remove unneeded extern declarations.
3171
3172 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3173
3174 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3175
3176 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3177
3178 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3179 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3180 These macros can no longer be used for assignment.
3181
3182 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3183 Assign struct members directly, instead of using BUF_BEGV etc.
3184 (record_buffer_markers, fetch_buffer_markers): New functions for
3185 recording and fetching special buffer markers.
3186 (set_buffer_internal_1, set_buffer_temp): Use them.
3187
3188 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3189
3190 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3191
3192 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3193 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3194
3195 * xdisp.c (hscroll_window_tree):
3196 (reconsider_clip_changes): Use PT instead of BUF_PT.
3197
3198 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3199
3200 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3201 $(EMACS_ROOT)/lib/intprops.h.
3202
3203 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 Fix more problems found by GCC 4.5.2's static checks.
3206
3207 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3208 to unsigned char * to avoid compiler diagnostic.
3209 (xg_free_frame_widgets): Make it clear that a local variable is
3210 needed only if USE_GTK_TOOLTIP.
3211 (gdk_window_get_screen): Make it clear that this macro is needed
3212 only if USE_GTK_TOOLTIP.
3213 (int_gtk_range_get_value): New function, which avoids a diagnostic
3214 from gcc -Wbad-function-cast.
3215 (xg_set_toolkit_scroll_bar_thumb): Use it.
3216 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3217 diagnostic from gcc -Wbad-function-cast.
3218 (get_utf8_string, xg_get_file_with_chooser):
3219 Rename locals to avoid shadowing.
3220 (create_dialog): Move locals to avoid shadowing.
3221
3222 * xgselect.c (xg_select): Remove unused var.
3223
3224 * image.c (four_corners_best): Mark locals as initialized.
3225 (gif_load): Initialize transparent_p to zero (Bug#8238).
3226 Mark another local as initialized.
3227 (my_png_error, my_error_exit): Mark with NO_RETURN.
3228
3229 * image.c (clear_image_cache): Now static.
3230 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3231 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3232 (x_edge_detection): Remove unnecessary cast that
3233 gcc -Wbad-function-cast diagnoses.
3234 (gif_load): Fix pointer signedness.
3235 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3236 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3237
3238 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 Improve quality of tests for time stamp overflow.
3241 For example, without this patch (encode-time 0 0 0 1 1
3242 1152921504606846976) returns the obviously-bogus value (-948597
3243 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3244 reports time overflow. See
3245 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3246 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3247 * editfns.c: Include limits.h and intprops.h.
3248 (TIME_T_MIN, TIME_T_MAX): New macros.
3249 (time_overflow): Move earlier, to before first use.
3250 (hi_time, lo_time): New functions, for an accurate test for
3251 out-of-range times.
3252 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3253 (Fget_internal_run_time): Don't assume time_t fits in int.
3254 (make_time): Use list2 instead of Fcons twice.
3255 (Fdecode_time): More accurate test for out-of-range times.
3256 (check_tm_member): New function.
3257 (Fencode_time): Use it, to test for out-of-range times.
3258 (lisp_time_argument): Don't rely on undefined left-shift and
3259 right-shift behavior when checking for time stamp overflow.
3260
3261 * editfns.c (time_overflow): New function, refactoring common code.
3262 (Fformat_time_string, Fdecode_time, Fencode_time):
3263 (Fcurrent_time_string): Use it.
3264
3265 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3266 * dired.c (make_time): Move to ...
3267 * editfns.c (make_time): ... here.
3268 * systime.h: Note the move.
3269
3270 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3271
3272 * fringe.c (update_window_fringes): Remove unused variables.
3273
3274 * unexmacosx.c (copy_data_segment): Also copy __got section.
3275 (Bug#8223)
3276
3277 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3278
3279 * termcap.c [MSDOS]: Include "msdos.h".
3280 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3281 Constify `char *' arguments and their references according to
3282 prototypes in tparam.h.
3283
3284 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3285
3286 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3287 Adapt all references accordingly.
3288
3289 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3290
3291 2011-03-11 Tom Tromey <tromey@redhat.com>
3292
3293 * buffer.c (syms_of_buffer): Remove obsolete comment.
3294
3295 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3296
3297 * termhooks.h (encode_terminal_code): Declare prototype.
3298
3299 * msdos.c (encode_terminal_code): Don't declare prototype.
3300
3301 * term.c (encode_terminal_code): Now external again, used by
3302 w32console.c and msdos.c.
3303
3304 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3305 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3306
3307 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 Fix some minor problems found by GCC 4.5.2's static checks.
3310
3311 * fringe.c (update_window_fringes): Mark locals as initialized
3312 (Bug#8227).
3313 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3314
3315 * alloc.c (mark_fringe_data): Move decl from here ...
3316 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3317 to check its interface.
3318 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3319
3320 * fontset.c (free_realized_fontset): Now static.
3321 (Fset_fontset_font): Rename local to avoid shadowing.
3322 (fontset_font): Mark local as initialized.
3323 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3324
3325 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3326
3327 * xselect.c (x_disown_buffer_selections): Remove; not used.
3328 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3329 (x_own_selection, Fx_disown_selection_internal): Rename locals
3330 to avoid shadowing.
3331 (x_handle_dnd_message): Remove local to avoid shadowing.
3332
3333 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3334 so that the caller can use some name other than gcpro1.
3335 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3336 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3337 (Fx_backspace_delete_keys_p):
3338 Use them to avoid shadowing, and rename vars to avoid shadowing.
3339 (x_decode_color, x_set_name, x_window): Now static.
3340 (Fx_create_frame): Add braces to silence GCC warning.
3341 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3342 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3343 Remove unused locals.
3344 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3345 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3346 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3347 macros.
3348
3349 * xterm.h (x_mouse_leave): New decl.
3350
3351 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3352 Remove unused functions.
3353 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3354 (x_calc_absolute_position): Now static.
3355 (XTread_socket): Don't define label "out" unless it's used.
3356 Don't declare local "event" unless it's used.
3357 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3358 unless they are used.
3359 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3360 (x_fatal_error_signal): Remove; not used.
3361 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3362 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3363 (x_error_catcher, x_connection_closed, x_error_handler):
3364 (x_error_quitter, xembed_send_message, x_iconify_frame):
3365 (my_log_handler): Rename locals to avoid shadowing.
3366 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3367 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3368
3369 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3370 Rename or move locals to avoid shadowing.
3371 (tty_defined_color, merge_face_heights): Now static.
3372 (free_realized_faces_for_fontset): Remove; not used.
3373 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3374 does not deduce is never used uninitialized.
3375 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3376 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3377
3378 * terminal.c (store_terminal_param): Now static.
3379
3380 * xmenu.c (menu_highlight_callback): Now static.
3381 (set_frame_menubar): Remove unused local.
3382 (xmenu_show): Rename parameter to avoid shadowing.
3383 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3384 since they might point to immutable storage.
3385 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3386 since it's unused otherwise.
3387
3388 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3389 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3390 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3391 avoids a gcc -Wuninitialized diagnostic.
3392 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3393 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3394 does not deduce are never used uninitialized.
3395
3396 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3397
3398 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3399 * window.c (window_loop, size_window):
3400 (run_window_configuration_change_hook, enlarge_window): Likewise.
3401
3402 * window.c (display_buffer): Now static.
3403 (size_window): Mark variables that gcc -Wuninitialized
3404 does not deduce are never used uninitialized.
3405 * window.h (check_all_windows): New decl, to forestall
3406 gcc -Wmissing-prototypes diagnostic.
3407 * dispextern.h (bidi_dump_cached_states): Likewise.
3408
3409 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3410 shadowing.
3411 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3412 Include <limits.h>.
3413 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3414 and to avoid gcc -Wuninitialized warning.
3415 (load_charset_map): Mark variables that gcc -Wuninitialized
3416 does not deduce are never used uninitialized.
3417 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3418
3419 * coding.c (coding_set_source, coding_set_destination):
3420 Use "else { /* comment */ }" rather than "else /* comment */;"
3421 for clarity, and to avoid gcc -Wempty-body warning.
3422 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3423 a block, when the outer 'i' will do.
3424 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3425 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3426 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3427 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3428 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3429 Rename locals to avoid shadowing.
3430 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3431 * coding.c (emacs_mule_char, encode_invocation_designation):
3432 Now static, since they're not used elsewhere.
3433 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3434 (decode_coding_object, encode_coding_object, detect_coding_system):
3435 (decode_coding_emacs_mule): Mark variables that gcc
3436 -Wuninitialized does not deduce are never used uninitialized.
3437 (detect_coding_iso_2022): Initialize a local variable that might
3438 be used uninitialized. Leave a FIXME because it's not clear that
3439 this initialization is needed. (Bug#8211)
3440 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3441 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3442 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3443 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3444 Remove unused macros.
3445
3446 * category.c (hash_get_category_set): Remove unused local var.
3447 (copy_category_table): Now static, since it's not used elsewhere.
3448 * character.c (string_count_byte8): Likewise.
3449
3450 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3451 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3452
3453 * chartab.c (copy_sub_char_table): Now static, since it's not used
3454 elsewhere.
3455 (sub_char_table_ref_and_range, char_table_ref_and_range):
3456 Rename locals to avoid shadowing.
3457 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3458
3459 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3460 (BIDI_BOB): Remove unused macro.
3461
3462 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3463 deduce are never used uninitialized.
3464 * term.c (encode_terminal_code): Likewise.
3465
3466 * term.c (encode_terminal_code): Now static. Remove unused local.
3467
3468 * tparam.h: New file.
3469 * term.c, tparam.h: Include it.
3470 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3471 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3472 Move these decls to tparam.h, and make them agree with what
3473 is actually in tparam.c. The previous trick of using incompatible
3474 decls in different modules does not conform to the C standard.
3475 All callers of tparam changed to use tparam's actual API.
3476 * tparam.c (tparam1, tparam, tgoto):
3477 Use const pointers where appropriate.
3478
3479 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3480 * cm.h (struct cm): Likewise.
3481 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3482 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3483 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3484 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3485 (turn_on_face, init_tty): Likewise.
3486 * termchar.h (struct tty_display_info): Likewise.
3487
3488 * term.c (term_mouse_position): Rename local to avoid shadowing.
3489
3490 * alloc.c (mark_ttys): Move decl from here ...
3491 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3492
3493 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3494
3495 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3496
3497 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3498
3499 * search.c (compile_pattern_1): Remove argument regp, unused since
3500 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3501 (compile_pattern): Don't pass it.
3502
3503 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3504
3505 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3506 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3507 for ! HAVE_GTK3.
3508 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3509
3510 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3511
3512 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3513 gdk_window_get_screen, gdk_window_get_geometry,
3514 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3515 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3516 (xg_get_pixbuf_from_pixmap): New function.
3517 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3518 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3519 Call xg_get_pixbuf_from_pixmap instead of
3520 gdk_pixbuf_get_from_drawable.
3521 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3522 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3523 (xg_check_special_colors): Use GtkStyleContext and its functions
3524 for HAVE_GTK3.
3525 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3526 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3527 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3528 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3529 Call gtk_widget_get_preferred_size.
3530 (xg_frame_resized): gdk_window_get_geometry only takes 5
3531 parameters.
3532 (xg_win_to_widget, xg_event_is_for_menubar):
3533 Call gdk_x11_window_lookup_for_display.
3534 (xg_set_widget_bg): New function.
3535 (delete_cb): New function.
3536 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3537 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3538 (xg_set_background_color): Call xg_set_widget_bg.
3539 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3540 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3541 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3542 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3543 if ! HAVE_GTK3.
3544 (update_frame_tool_bar): Call gtk_widget_hide.
3545 (xg_initialize): Use GDK_KEY_g.
3546
3547 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3548 if ! HAVE_GTK3
3549 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3550
3551 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3552 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3553 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3554
3555 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3556
3557 * w32xfns.c (select_palette): Check success of RealizePalette against
3558 GDI_ERROR, not zero.
3559
3560 See ChangeLog.11 for earlier changes.
3561
3562 ;; Local Variables:
3563 ;; coding: utf-8
3564 ;; End:
3565
3566 Copyright (C) 2011 Free Software Foundation, Inc.
3567
3568 This file is part of GNU Emacs.
3569
3570 GNU Emacs is free software: you can redistribute it and/or modify
3571 it under the terms of the GNU General Public License as published by
3572 the Free Software Foundation, either version 3 of the License, or
3573 (at your option) any later version.
3574
3575 GNU Emacs is distributed in the hope that it will be useful,
3576 but WITHOUT ANY WARRANTY; without even the implied warranty of
3577 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3578 GNU General Public License for more details.
3579
3580 You should have received a copy of the GNU General Public License
3581 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.