1 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8 In other words, assume that every image size is allowed, on non-X
9 hosts. This assumption is probably wrong, but it lets Emacs compile.
11 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
13 * regex.c (re_iswctype): Convert return values to boolean.
15 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
17 * xdisp.c (compute_display_string_pos): Don't use cached display
18 string position if the buffer had its restriction changed.
21 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
23 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
25 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
27 Integer signedness and overflow and related fixes. (Bug#9079)
29 * bidi.c: Integer size and overflow fixes.
30 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
31 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
32 (bidi_cache_find_level_change, bidi_cache_ensure_space)
33 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
34 (bidi_find_other_level_edge):
35 Use ptrdiff_t instead of EMACS_INT where either will do.
36 This works better on 32-bit hosts configured --with-wide-int.
37 (bidi_cache_ensure_space): Check for size-calculation overflow.
38 Use % rather than repeated addition, for better worst-case speed.
39 Don't set bidi_cache_size until after xrealloc returns, because it
41 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
42 (bidi_cache_ensure_space): Also check that the bidi cache size
43 does not exceed that of the largest Lisp string or buffer. See Eli
44 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
46 * alloc.c (__malloc_size_t): Remove.
47 All uses replaced by size_t. See Andreas Schwab's note
48 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
50 * image.c: Improve checking for integer overflow.
51 (check_image_size): Assume that f is nonnull, since
52 it is always nonnull in practice. This is one less thing to
53 worry about when checking for integer overflow later.
54 (x_check_image_size): New function, which checks for integer
55 overflow issues inside X.
56 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
57 This removes the need for a memory_full check.
58 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
59 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
60 (xbm_read_bitmap_data): Change locals back to 'int', since
61 their values must fit in 'int'.
62 (xpm_load_image, png_load, tiff_load):
63 Invoke x_create_x_image_and_pixmap earlier,
64 to avoid much needless work if the image is too large.
65 (tiff_load): Treat overly large images as if
66 x_create_x_image_and_pixmap failed, not as malloc failures.
67 (gs_load): Use x_check_image_size.
69 * gtkutil.c: Omit integer casts.
70 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
71 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
73 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
75 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
76 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
77 would wrongly return t on a 64-bit host.
79 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
80 The plain *_OVERFLOW macros run afoul of GCC bug 49705
81 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
82 and therefore cause GCC to emit a bogus diagnostic in some cases.
84 * image.c: Integer signedness and overflow and related fixes.
85 This is not an exhaustive set of fixes, but it's time to
87 (lookup_pixel_color, check_image_size): Remove redundant decls.
88 (check_image_size): Don't assume that arbitrary EMACS_INT values
89 fit in 'int', or that arbitrary 'double' values fit in 'int'.
90 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
91 (tiff_load, imagemagick_load_image):
92 Check for overflow in size calculations.
93 (x_create_x_image_and_pixmap): Remove unnecessary test for
94 xmalloc returning NULL; that can't happen.
95 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
96 (xpm_color_bucket): Use better integer hashing function.
97 (xpm_cache_color): Don't possibly over-allocate memory.
98 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
100 Use ptrdiff_t, not int or size_t, to record sizes.
101 (png_load): Don't assume values greater than 2**31 fit in 'int'.
102 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
103 either works, as we prefer signed integers.
104 (tiff_read_from_memory, tiff_write_from_memory):
105 Return tsize_t, not size_t, since that's what the TIFF API wants.
106 (tiff_read_from_memory): Don't fail simply because the read would
107 go past EOF; instead, return a short read.
108 (tiff_load): Omit no-longer-needed casts.
109 (Fimagemagick_types): Don't assume size fits into 'int'.
111 Improve hashing quality when configured --with-wide-int.
112 * fns.c (hash_string): New function, taken from sxhash_string.
113 Do not discard information about ASCII character case; this
114 discarding is no longer needed.
115 (sxhash-string): Use it. Change sig to match it. Caller changed.
116 * lisp.h: Declare it.
117 * lread.c (hash_string): Remove, since we now use fns.c's version.
118 The fns.c version returns a wider integer if --with-wide-int is
119 specified, so this should help the quality of the hashing a bit.
121 * emacs.c: Integer overflow minor fix.
122 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
123 Define only if GNU_LINUX.
124 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
126 * dispnew.c: Integer signedness and overflow fixes.
127 Remove unnecessary forward decls, that were a maintenance hassle.
128 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
130 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
131 (scrolling_window): Use ptrdiff_t, not int, for byte count.
132 (prepare_desired_row, line_draw_cost):
133 Use int, not unsigned, where either works.
134 (save_current_matrix, restore_current_matrix):
135 Use ptrdiff_t, not size_t, where either works.
136 (init_display): Check for overflow more accurately, and without
137 relying on undefined behavior.
139 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
140 Remove, replacing with the new symbols in lisp.h. All uses changed.
141 * fileio.c (make_temp_name):
142 * filelock.c (lock_file_1, lock_file):
143 * xdisp.c (message_dolog):
144 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
145 Use pMd etc. instead.
146 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
147 replacing the pWIDE etc. symbols removed from editfns.c.
149 * keyboard.h (num_input_events): Now uintmax_t.
150 This is (very slightly) less likely to mess up due to wraparound.
153 * buffer.c: Integer signedness fixes.
154 (alloc_buffer_text, enlarge_buffer_text):
155 Use ptrdiff_t rather than size_t when either will do, as we prefer
158 * alloc.c: Integer signedness and overflow fixes.
159 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
160 (__malloc_size_t): Default to size_t, not to int.
161 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
162 (Fgarbage_collect, mark_object_loop_halt, mark_object):
163 Prefer ptrdiff_t to size_t when either would do, as we prefer
165 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
166 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
167 Now const. Initialize with values that are in range even if char
169 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
170 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
171 These functions do the right thing with sizes > 2**32.
172 (check_depth): Now ptrdiff_t, not int.
173 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
174 Adjust to new way of storing sizes. Check for size overflow bugs
176 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
177 slightly wrong anyway, as it missed one instance of
178 XMALLOC_OVERRUN_CHECK_OVERHEAD.
179 (refill_memory_reserve): Omit needless cast to size_t.
180 (mark_object_loop_halt): Mark as externally visible.
182 * xselect.c: Integer signedness and overflow fixes.
183 (Fx_register_dnd_atom, x_handle_dnd_message):
184 Use ptrdiff_t, not size_t, since we prefer signed.
185 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
186 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
187 x_dnd_atoms_size and x_dnd_atoms_length.
189 * doprnt.c: Prefer signed to unsigned when either works.
193 * xdisp.c (vmessage):
194 Use ptrdiff_t, not size_t, when using or implementing doprnt,
195 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
196 prefer signed arithmetic to avoid comparison confusion.
197 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
200 Assume freestanding C89 headers, string.h, stdlib.h.
201 * data.c, doprnt.c, floatfns.c, print.c:
202 Include float.h unconditionally.
203 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
204 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
205 * regex.c: Likewise for stddef.h, string.h.
206 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
207 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
208 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
209 (STDC_HEADERS): Remove obsolete defines.
210 * sysdep.c: Include limits.h unconditionally.
212 Assume support for memcmp, memcpy, memmove, memset.
213 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
214 * regex.c (memcmp, memcpy):
215 Remove; we assume C89 now.
217 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
218 (__malloc_safe_bcopy): Remove; no longer needed.
220 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
221 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
222 well either way, and we prefer signed to unsigned.
224 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
226 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
227 closes the connection while we're reading (bug#9182).
229 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
231 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
232 are specified (Bug#9168).
234 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
236 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
237 Found by GCC static checking and --with-wide-int on a 32-bit host.
239 2011-07-25 Eli Zaretskii <eliz@gnu.org>
241 * xdisp.c (compute_display_string_pos): Fix logic of caching
242 previous display string position. Initialize cached_prev_pos to
243 -1. Fixes slow-down at the beginning of a buffer.
245 2011-07-24 Eli Zaretskii <eliz@gnu.org>
247 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
248 for attrs[LFACE_FONTSET_INDEX].
250 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
252 * xml.c (parse_region): Remove unused local
253 that was recently introduced.
255 2011-07-23 Eli Zaretskii <eliz@gnu.org>
257 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
258 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
260 * xdisp.c (move_it_in_display_line_to): Record the best matching
261 position for TO_CHARPOS while scanning the line, and restore it on
262 exit if none of the characters scanned was an exact match. Fixes
263 vertical-motion and pos-visible-in-window-p under bidi redisplay
264 when exact match is impossible due to invisible text, and the
267 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
269 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
272 2011-07-22 Eli Zaretskii <eliz@gnu.org>
274 Fix a significant slow-down of cursor motion with C-n, C-p,
275 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
276 auto-repeat under bidi redisplay in fontified buffers.
277 * xdisp.c (compute_stop_pos_backwards): New function.
278 (next_element_from_buffer): Call compute_stop_pos_backwards to
279 find a suitable prev_stop when we find ourselves before
281 (reseat): Don't look for prev_stop, as that could mean a very long
283 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
284 <cached_disp_overlay_modiff>: Cache for last found display string
286 (compute_display_string_pos): Return the cached position if asked
287 about the same buffer in the same area of character positions, and
288 the buffer wasn't changed since the time the display string
291 2011-07-22 Eli Zaretskii <eliz@gnu.org>
293 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
294 is an integer, which is important for empty lines. (Bug#9149)
296 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
298 * frame.c (Fmodify_frame_parameters): In tty case, update the
299 default face if necessary (Bug#4238).
301 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
303 * editfns.c (Fstring_to_char): No need to explain what a character
304 is in the docstring (Bug#6576).
306 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
308 * xml.c (parse_region): Make sure we always return a tree.
310 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
312 * xml.c (parse_region): If a document contains only comments,
315 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
317 * xml.c (make_dom): Return comments, too.
319 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
322 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
323 and the surrounding thread.
324 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
325 rather than fgets, and retry after EINTR. Otherwise, 'emacs
326 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
328 * s/openbsd.h (BROKEN_SIGIO): Define.
329 * unexelf.c (unexec) [__OpenBSD__]:
330 Don't update the .mdebug section of the Alpha COFF symbol table.
332 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
334 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
337 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
339 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
340 This fixes some race conditions on the permissions of any newly
343 * alloc.c (valid_pointer_p): Use pipe, not open.
344 This fixes some permissions issues when debugging.
346 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
347 If fchown fails to set both uid and gid, try to set just gid,
348 as that is sometimes allowed. Adjust the file's mode to eliminate
349 setuid or setgid bits that are inappropriate if fchown fails.
351 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
353 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
354 to compare Lisp_Objects.
355 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
356 global_gnutls_log_level, don't mistake it for a Lisp_Object.
357 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
359 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
361 * lread.c (read_integer): Unread even EOF character.
362 (read1): Likewise. Properly record start position of symbol.
364 * lread.c (read1): Read `#:' as empty uninterned symbol if no
365 symbol character follows.
367 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
369 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
370 This works around a problem with the previous change to Fcopy_file.
371 Recent glibc declares fchown with __attribute__((warn_unused_result)),
372 and without this change, GCC might complain about discarding
373 fchown's return value.
375 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
377 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
379 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
381 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
383 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
385 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
386 it's used from the C level.
388 * process.c: Use the same condition for POLL_FOR_INPUT in both
389 keyboard.c and process.c (bug#1858).
391 2011-07-09 Lawrence Mitchell <wence@gmx.li>
393 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
394 (Fgnutls_boot): Use it.
396 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
398 * doc.c (Fsubstitute_command_keys): Revert last change.
400 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
402 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
403 quotes the next character, and doesn't affect other longer
404 sequences (bug#8935).
406 * lread.c (syms_of_lread): Clarify that is isn't only
407 `eval-buffer' and `eval-defun' that's affected by
408 `lexical-binding' (bug#8460).
410 2011-07-15 Eli Zaretskii <eliz@gnu.org>
412 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
413 bidi redisplay when a line includes both an image and is
416 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
418 Fix minor problems found by static checking.
419 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
420 (elsz): Now a signed constant, not a size_t var. We prefer signed
421 types to unsigned, to avoid integer comparison confusion. Without
422 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
423 "cannot optimize loop, the loop counter may overflow", a symptom
425 * indent.c (Fvertical_motion): Mark locals as initialized.
426 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
428 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
430 * search.c (Fre_search_backward): Mention `case-fold-search' in
431 all the re_search_* functions (bug#8138).
433 * keyboard.c (Fopen_dribble_file): Document when the file is
436 2011-07-14 Eli Zaretskii <eliz@gnu.org>
438 * bidi.c (bidi_dump_cached_states): Fix format of displaying
441 Support bidi reordering of display and overlay strings.
442 * xdisp.c (compute_display_string_pos)
443 (compute_display_string_end): Accept additional argument STRING.
444 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
445 (reseat_to_string): Initialize bidi_it->string.s and
446 bidi_it->string.schars.
447 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
448 NULL (avoids a crash in bidi_paragraph_init). Initialize
450 (init_iterator): Call bidi_init_it only of a valid
451 buffer position was specified. Initialize paragraph_embedding to
453 (reseat_to_string): Initialize the bidi iterator.
454 (display_string): If we need to ignore text properties of
455 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
456 original value of -1 will not work with bidi.)
457 (compute_display_string_pos): First arg is now struct
458 `text_pos *'; all callers changed. Support display properties on
460 (compute_display_string_end): Support display properties on Lisp
462 (init_iterator, reseat_1, reseat_to_string): Initialize the
463 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
464 when iterating on a string not from display properties).
465 (compute_display_string_pos, compute_display_string_end): Fix
466 calculation of the object to scan. Fixes an error when using
468 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
469 base_level_stop; instead, set base_level_stop to BEGV. Fixes
470 crashes in vertical-motion.
471 (next_element_from_buffer): Improve commentary for when
472 the iterator is before prev_stop.
473 (init_iterator): Initialize bidi_p from the default value of
474 bidi-display-reordering, not from buffer-local value. Use the
475 buffer-local value only if initializing for buffer iteration.
476 (handle_invisible_prop): Support invisible properties on strings
477 that are being bidi-reordered.
478 (set_iterator_to_next): Support bidi reordering of C strings and
480 (next_element_from_string): Support bidi reordering of Lisp
482 (handle_stop_backwards): Support Lisp strings as well.
483 (display_string): Support display of R2L glyph rows. Use
484 IT_STRING_CHARPOS when displaying from a Lisp string.
485 (init_iterator): Don't initialize it->bidi_p for strings
487 (reseat_to_string): Initialize it->bidi_p for strings here.
488 (next_element_from_string, next_element_from_c_string)
489 (next_element_from_buffer): Add xassert's for correspondence
490 between IT's object being iterated and it->bidi_it.string
492 (face_before_or_after_it_pos): Support bidi iteration.
493 (next_element_from_c_string): Handle the case of the first string
494 character that is not the first one in the visual order.
495 (get_visually_first_element): New function, refactored from common
496 parts of next_element_from_buffer, next_element_from_string, and
497 next_element_from_c_string.
498 (tool_bar_lines_needed, redisplay_tool_bar)
499 (display_menu_bar): Force left-to-right direction. Add a FIXME
500 comment for making that be controlled by a user option.
501 (push_it, pop_it): Save and restore the state of the
502 bidi iterator. Save and restore the bidi_p flag.
503 (pop_it): Iterate out of display property for string iteration as
505 (iterate_out_of_display_property): Support iteration over strings.
506 (handle_single_display_spec): Set up it->bidi_it for iteration
507 over a display string, and call bidi_init_it.
508 (handle_single_display_spec, next_overlay_string)
509 (get_overlay_strings_1, push_display_prop): Set up the bidi
510 iterator for displaying display or overlay strings.
511 (forward_to_next_line_start): Don't use the shortcut if
513 (back_to_previous_visible_line_start): If handle_display_prop
514 pushed the iterator stack, restore the internal state of the bidi
515 iterator by calling bidi_pop_it same number of times.
516 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
517 and we are bidi-iterating, don't decrement the iterator position;
518 instead, set the first_elt flag in the bidi iterator, to produce
520 (reseat_1): Remove redundant setting of string_from_display_prop_p.
521 (push_display_prop): xassert that we are iterating a buffer.
522 (push_it, pop_it): Save and restore paragraph_embedding member.
523 (handle_single_display_spec, next_overlay_string)
524 (get_overlay_strings_1, reseat_1, reseat_to_string)
525 (push_display_prop): Set up the `unibyte' member of bidi_it.string
526 correctly. Don't assume unibyte strings are not bidi-reordered.
527 (compute_display_string_pos)
528 (compute_display_string_end): Fix handling the case of C string.
529 (push_it, pop_it): Save and restore from_disp_prop_p.
530 (handle_single_display_spec, push_display_prop): Set the
531 from_disp_prop_p flag.
532 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
533 (pop_it): Call iterate_out_of_display_property only if we are
534 popping after iteration over a string that came from a display
535 property. Fix a typo in popping stretch info. Add an assertion
536 for verifying that the iterator position is in sync with the bidi
538 (handle_single_display_spec, get_overlay_strings_1)
539 (push_display_prop): Fix initialization of paragraph direction for
540 string when that of the parent object is not yet determined.
541 (reseat_1): Call bidi_init_it to resync the bidi
542 iterator with IT's position. (Bug#7616)
543 (find_row_edges): If ROW->start.pos gives position
544 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
545 (handle_stop, back_to_previous_visible_line_start, reseat_1):
546 Reset the from_disp_prop_p flag.
547 (SAVE_IT, RESTORE_IT): New macros.
548 (pos_visible_p, face_before_or_after_it_pos)
549 (back_to_previous_visible_line_start)
550 (move_it_in_display_line_to, move_it_in_display_line)
551 (move_it_to, move_it_vertically_backward, move_it_by_lines)
552 (try_scrolling, redisplay_window, display_line): Use them when
553 saving a temporary copy of the iterator and restoring it back.
554 (back_to_previous_visible_line_start, reseat_1)
555 (init_iterator): Empty the bidi cache "stack".
556 (move_it_in_display_line_to): If iterator ended up at
557 EOL, but we never saw any buffer positions smaller than
558 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
559 motion in bidi-reordered lines.
560 (move_it_in_display_line_to): Record prev_method and prev_pos
561 immediately before the call to set_iterator_to_next. Fixes cursor
562 motion in bidi-reordered lines with stretch glyphs and strings
563 displayed in margins. (Bug#8133) (Bug#8867)
564 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
566 (pos_visible_p): Support positions in bidi-reordered lines. Save
567 and restore bidi cache.
569 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
570 (bidi_paragraph_info): Delete unused struct.
571 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
572 (bidi_cache_start): New variable.
573 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
575 (bidi_cache_fetch_state, bidi_cache_search)
576 (bidi_cache_find_level_change, bidi_cache_iterator_state)
577 (bidi_cache_find, bidi_peek_at_next_level)
578 (bidi_level_of_next_char, bidi_find_other_level_edge)
579 (bidi_move_to_visually_next): Compare cache index with
580 bidi_cache_start rather than with zero.
581 (bidi_fetch_char): Accept new argument STRING; all callers
582 changed. Support iteration over a string. Support strings with
583 display properties. Support unibyte strings. Fix the type of
584 `len' according to what STRING_CHAR_AND_LENGTH expects.
585 (bidi_paragraph_init, bidi_resolve_explicit_1)
586 (bidi_resolve_explicit, bidi_resolve_weak)
587 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
588 iteration over a string.
589 (bidi_set_sor_type, bidi_resolve_explicit_1)
590 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
591 can now be zero (for strings); special values 0 and -1 were
592 changed to -1 and -2, respectively.
593 (bidi_char_at_pos): New function.
594 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
595 Call it instead of FETCH_MULTIBYTE_CHAR.
596 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
597 initialized to valid values.
598 (bidi_init_it): Don't initialize charpos and bytepos with invalid
600 (bidi_level_of_next_char): Allow the sentinel "position" to pass
601 the test for valid cached positions. Fix the logic for looking up
602 the sentinel state in the cache. GCPRO the Lisp string we are
604 (bidi_push_it, bidi_pop_it): New functions.
605 (bidi_initialize): Initialize the bidi cache start stack pointer.
606 (bidi_cache_ensure_space): New function, refactored from part of
607 bidi_cache_iterator_state. Don't assume the required size is just
608 one BIDI_CACHE_CHUNK away.
609 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
610 (bidi_count_bytes, bidi_char_at_pos): New functions.
611 (bidi_cache_search): Don't assume bidi_cache_last_idx is
612 always valid if bidi_cache_idx is valid.
613 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
614 is valid if it's going to be used.
615 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
616 (bidi_cache_fetch_state, bidi_cache_search)
617 (bidi_cache_find_level_change, bidi_cache_ensure_space)
618 (bidi_cache_iterator_state, bidi_cache_find)
619 (bidi_find_other_level_edge, bidi_cache_start_stack): All
620 variables related to cache indices are now EMACS_INT.
622 * dispextern.h (struct bidi_string_data): New structure.
623 (struct bidi_it): New member `string'. Make flag members be 1-bit
624 fields, and put them last in the struct.
625 (compute_display_string_pos, compute_display_string_end): Update
627 (bidi_push_it, bidi_pop_it): Add prototypes.
628 (struct iterator_stack_entry): New members bidi_p,
629 paragraph_embedding, and from_disp_prop_p.
630 (struct it): Member bidi_p is now a bit field 1 bit wide.
631 (bidi_shelve_cache, bidi_unshelve_cache): Declare
634 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
635 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
636 and vector-like objects.
638 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
639 cache around display iteration.
641 * window.c (Fwindow_end, window_scroll_pixel_based)
642 (displayed_window_lines, Frecenter): Save and restore the bidi
643 cache around display iteration.
645 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
647 * editfns.c (Fdelete_region): Clarify the use of the named
648 parameters (bug#6788).
650 2011-07-14 Martin Rudalics <rudalics@gmx.at>
652 * indent.c (Fvertical_motion): Set and restore w->pointm when
653 saving and restoring the window's buffer (Bug#9006).
655 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
657 * editfns.c (Fstring_to_char): Clarify just what is returned
658 (bug#6576). Text by Eli Zaretskii.
660 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
662 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
664 2011-07-13 Eli Zaretskii <eliz@gnu.org>
666 * buffer.c (mmap_find): Fix a typo.
668 2011-07-13 Johan Bockgård <bojohan@gnu.org>
670 Fix execution of x selection hooks.
671 * xselect.c (Qx_lost_selection_functions)
672 (Qx_sent_selection_functions): New vars.
673 (syms_of_xselect): DEFSYM them.
674 (x_handle_selection_request): Pass Qx_sent_selection_functions
675 rather than Vx_sent_selection_functions to Frun_hook_with_args.
676 (x_handle_selection_clear,x_clear_frame_selections):
677 Pass Qx_lost_selection_functions rather than
678 Vx_lost_selection_functions to Frun_hook_with_args.
680 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
682 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
683 The old code sometimes used this field without initializing it.
685 * alloc.c (gc_sweep): Don't read past end of array.
686 In theory, the old code could also have corrupted Emacs internals,
687 though it'd be very unlikely.
689 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
691 * character.c (Fcharacterp): Don't advertise optional ignored
694 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
696 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
699 * window.c (Fset_window_start): Doc fix (bug#4199).
700 (Fset_window_hscroll): Ditto.
702 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
704 Fix minor new problems caught by GCC 4.6.1.
705 * term.c (init_tty): Remove unused local.
706 * xsettings.c (store_monospaced_changed): Define this function only
707 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
710 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
712 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
714 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
716 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
717 are the mini-buffer and the echo area (bug#3320).
719 * term.c (init_tty): Remove support for supdup, c10 and perq
720 terminals, which are no longer supported (bug#1482).
722 2011-07-10 Johan Bockgård <bojohan@gnu.org>
724 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
726 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
728 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
729 for non-popups (Bug#3642).
731 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
733 * alloc.c (reset_malloc_hooks): Protoize.
734 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
735 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
736 * cm.c (losecursor): Likewise.
737 * data.c (fmod): Likewise.
738 * dispnew.c (swap_glyphs_in_rows): Likewise.
739 * emacs.c (memory_warning_signal): Likewise.
740 * floatfns.c (float_error): Likewise.
741 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
742 (otf_open, font_otf_capability, generate_otf_features)
743 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
745 * image.c (pbm_read_file): Likewise.
746 * indent.c (string_display_width): Likewise.
747 * intervals.c (check_for_interval, search_for_interval)
748 (inc_interval_count, count_intervals, root_interval)
749 (adjust_intervals_for_insertion, make_new_interval): Likewise.
750 * lread.c (defalias): Likewise.
751 * ralloc.c (r_alloc_check): Likewise.
752 * regex.c (set_image_of_range_1, set_image_of_range)
753 (regex_grow_registers): Likewise.
754 * sysdep.c (strerror): Likewise.
755 * termcap.c (valid_filename_p, tprint, main): Likewise.
756 * tparam.c (main): Likewise.
757 * unexhp9k800.c (run_time_remap, save_data_space)
758 (update_file_ptrs, read_header, write_header, calculate_checksum)
759 (copy_file, copy_rest, display_header): Likewise.
760 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
762 * xdisp.c (check_it): Likewise.
763 * xfaces.c (register_color, unregister_color, unregister_colors):
765 * xfns.c (print_fontset_result): Likewise.
766 * xrdb.c (member, fatal, main): Likewise.
768 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
770 Fix minor problems found by static checking (Bug#9031).
771 * chartab.c (char_table_set_range, map_sub_char_table):
772 Remove unused locals.
773 (uniprop_table): Now static.
774 * composite.c (_work_char): Remove unused static var.
776 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
778 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
780 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
782 * gtkutil.c (qttip_cb): Remove code without function.
784 2011-07-09 Eli Zaretskii <eliz@gnu.org>
786 * w32.c (pthread_sigmask): New stub.
788 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
790 Use pthread_sigmask, not sigprocmask (Bug#9010).
791 sigprocmask is portable only for single-threaded applications, and
792 Emacs can be multi-threaded when it uses GTK.
793 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
795 * callproc.c (Fcall_process):
796 * process.c (create_process):
797 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
798 Use pthread_sigmask, not sigprocmask.
800 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
802 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
803 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
806 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
808 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
809 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
810 (xg_hide_tooltip): Fix comment.
812 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
813 in registerServicesMenuSendTypes.
814 (validRequestorForSendType): Don't check ns_return_types.
816 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
819 2011-07-08 Jason Rumney <jasonr@gnu.org>
821 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
822 frame struct members of non-existent frames (Bug#6284).
824 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
826 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
827 variable firstTime not needed on OSX >= 10.6.
828 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
829 >= 10.5. Use setKnobProportion, setDoubleValue.
831 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
832 (MAC_OS_X_VERSION_10_5): Define if not defined.
833 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
834 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
835 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
837 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
838 cString and lossyCString on OSX >= 10.4
840 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
841 sizeToFit on OSX >= 10.2.
843 * nsimage.m (allocInitFromFile): Don't use deprecated method
844 bestRepresentationForDevice on OSX >= 10.6.
846 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
849 * emacs.c: Declare unexec_init_emacs_zone.
851 * nsgui.h: Fix compiler warning about gnulib redefining verify.
853 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
855 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
856 on svcsMenu (Bug#8842).
858 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
860 (Fns_list_services): Just return Qnil on 10.6, code not working there.
862 * nsterm.m (QUTF8_STRING): Declare.
863 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
864 (validRequestorForSendType): Return type is (id).
865 Change indexOfObjectIdenticalTo to indexOfObject.
866 Check if we have local selection before returning self (Bug#8842).
867 (writeSelectionToPasteboard): Put local selection into paste board
868 if we have a local selection (Bug#8842).
869 (syms_of_nsterm): DEFSYM QUTF8_STRING.
871 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
872 (ns_get_local_selection): Declare.
874 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
876 * keymap.c (describe_map_tree): Don't insert a double newline at
877 the end of the buffer (bug#1169) and return whether we inserted
880 * callint.c (Fcall_interactively): Change "reading args" to
881 "providing args" to try to clarify what it does (bug#1010).
883 2011-07-07 Kenichi Handa <handa@m17n.org>
885 * composite.c (composition_compute_stop_pos): Ignore a static
886 composition starting before CHARPOS (Bug#8915).
888 * xdisp.c (handle_composition_prop): Likewise.
890 2011-07-07 Eli Zaretskii <eliz@gnu.org>
892 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
895 2011-07-07 Kenichi Handa <handa@m17n.org>
897 * character.h (unicode_category_t): New enum type.
899 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
900 (Qchar_code_property_table): New variable.
901 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
902 (UNIPROP_COMPRESSED_FORM_P): New macros.
903 (char_table_ascii): Uncompress the compressed values.
904 (sub_char_table_ref): New arg is_uniprop. Callers changed.
905 Uncompress the compressed values.
906 (sub_char_table_ref_and_range): Likewise.
907 (char_table_ref_and_range): Uncompress the compressed values.
908 (sub_char_table_set): New arg is_uniprop. Callers changed.
909 Uncompress the compressed values.
910 (sub_char_table_set_range): Args changed. Callers changed.
911 (char_table_set_range): Adjuted for the above change.
912 (map_sub_char_table): Delete args default_val and parent. Add arg
913 top. Give decoded values to a Lisp function.
914 (map_char_table): Adjusted for the above change. Give decoded
915 values to a Lisp function. Gcpro more variables.
916 (uniprop_table_uncompress)
917 (uniprop_decode_value_run_length): New functions.
918 (uniprop_decoder, uniprop_decoder_count): New variables.
919 (uniprop_get_decoder, uniprop_encode_value_character)
920 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
922 (uniprop_encoder, uniprop_encoder_count): New variables.
923 (uniprop_get_encoder, uniprop_table)
924 (Funicode_property_table_internal, Fget_unicode_property_internal)
925 (Fput_unicode_property_internal): New functions.
926 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
927 Sunicode_property_table_internal, Sget_unicode_property_internal,
928 and Sput_unicode_property_internal. Defvar_lisp
929 char-code-property-alist.
931 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
932 Vunicode_category_table.
934 * font.c (font_range): Adjusted for the change of
935 Vunicode_category_table.
937 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
939 * m/iris4d.h: Remove file, move contents ...
940 * s/irix6-5.h: ... here.
942 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
944 Remove unportable assumption about struct layout (Bug#8884).
945 * alloc.c (mark_buffer):
946 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
947 (clone_per_buffer_values): Don't assume that
948 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
949 This isn't true in general, and it's particularly not true
950 if Emacs is configured with --with-wide-int.
951 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
952 New macros, used in the buffer.c change.
954 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
956 * xsettings.c: Use both GConf and GSettings if both are available.
957 (store_config_changed_event): Add comment.
958 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
959 (store_tool_bar_style_changed): New functions.
960 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
961 (struct xsettings): Move font inside HAVE_XFT.
962 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
963 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
964 Move inside HAVE_XFT.
965 (something_changed_gsettingsCB): Renamed from something_changedCB.
966 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
968 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
969 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
970 (something_changed_gconfCB): Renamed from something_changedCB.
971 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
972 (parse_settings): Move check for font inside HAVE_XFT.
973 (read_settings, apply_xft_settings): Add comment.
974 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
975 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
976 call store_font_name_changed.
977 (xft_settings_event): Add comment.
978 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
979 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
980 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
981 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
982 (xsettings_initialize): Call init_gsettings last.
983 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
986 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
988 Random fixes. E.g., (random) never returned negative values.
989 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
990 subseconds part to the entropy, as that's a bit more random.
991 Prefer signed to unsigned, since the signedness doesn't matter and
992 in general we prefer signed. When given a limit, use a
993 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
994 latter isn't right if USE_2_TAGS_FOR_INTS.
995 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
996 not 0..VALMASK. Don't discard "excess" bits that random () returns.
998 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1000 * textprop.c (text_property_stickiness):
1001 Obey Vtext_property_default_nonsticky.
1002 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1003 * w32fns.c (syms_of_w32fns):
1004 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1006 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1008 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1009 This is more efficient than Ffile_directory_p and avoids a minor race.
1011 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1013 * buffer.c (Foverlay_put): Say what the return value is
1016 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1017 is a directory before asking whether to use the file name
1019 (barf_or_query_if_file_exists): Make the "File is a directory"
1020 error be more correct.
1022 * fns.c (Frequire): Remove the mention of the .gz files, since
1023 that's installation-specific, but keep the mention of
1024 `get-load-suffixes'.
1026 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1028 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1029 Report string overflow if the output is too long.
1031 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1033 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1034 (syms_of_gnutls): Remove duplicate DEFSYM for
1035 Qgnutls_bootprop_verify_hostname_error, an error for
1036 Qgnutls_bootprop_verify_error (which is no longer used).
1038 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1039 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1040 Also (re)move comments that are misplaced or no longer relevant.
1042 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1044 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1046 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1048 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1049 and background color parameters if they have been changed.
1051 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1053 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1055 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1057 * xsettings.c (SYSTEM_FONT): Define only when used.
1058 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1060 * keymap.c (access_keymap_1): Now static.
1062 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1064 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1065 leave any prefix arg for the up event (Bug#1586).
1067 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1069 * lread.c (syms_of_lread): Mention single symbols defined by
1070 `defvar' or `defconst' (bug#7154).
1072 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1073 (Frequire): Mention get-load-suffixes.
1075 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1077 * window.h (window): Remove clone_number slot.
1078 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1080 (make_parent_window, make_window, saved_window)
1081 (Fset_window_configuration, save_window_save): Don't deal with
1083 * buffer.c (Qclone_number): Remove declaration.
1084 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1086 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1088 Add multiple inheritance to keymaps.
1089 * keymap.c (Fmake_composed_keymap): New function.
1090 (Fset_keymap_parent): Simplify.
1091 (fix_submap_inheritance): Remove.
1092 (access_keymap_1): New function extracted from access_keymap to handle
1093 embedded parents and handle lists of maps.
1094 (access_keymap): Use it.
1095 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1096 (Fcopy_keymap): Handle embedded parents.
1097 (Fcommand_remapping, define_as_prefix): Simplify.
1098 (Fkey_binding): Simplify.
1099 (syms_of_keymap): Move minibuffer-local-completion-map,
1100 minibuffer-local-filename-completion-map,
1101 minibuffer-local-must-match-map, and
1102 minibuffer-local-filename-must-match-map to Elisp.
1103 (syms_of_keymap): Defsubr make-composed-keymap.
1104 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1105 (parse_menu_item): Trivial simplification.
1107 2011-07-01 Glenn Morris <rgm@gnu.org>
1109 * Makefile.in (SETTINGS_LIBS): Fix typo.
1111 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1113 * coding.c (Fencode_coding_string): Record the last coding system
1114 used, as the function doc string says (bug#8738).
1116 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1118 * xsettings.c (store_monospaced_changed): Take new font as arg and
1119 check for change against current_mono_font.
1120 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1121 (emacs_settings_constructor, emacs_settings_get_property)
1122 (emacs_settings_set_property, emacs_settings_class_init)
1123 (emacs_settings_init, gsettings_obj): Remove.
1124 (something_changedCB): New function for HAVE_GSETTINGS.
1125 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1126 with value as argument.
1127 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1128 g_settings_new (Bug#8967). Do not create gsettings_obj.
1129 Remove calls to g_settings_bind. Connect something_changedCB to
1132 * xgselect.c: Add defined (HAVE_GSETTINGS).
1133 (xgselect_initialize): Ditto.
1135 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1136 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1139 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1141 * eval.c (struct backtrace): Simplify and port the data structure.
1142 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1143 signed bit field, as this assumption is not portable and it makes
1144 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1145 "char debug_on_exit : 1" as this is not portable either; instead,
1146 use the portable "unsigned int debug_on_exit : 1". Remove unused
1147 member evalargs. Remove obsolete comments about cc bombing out.
1149 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1151 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1152 Let HAVE_GSETTINGS override HAVE_GCONF.
1153 (store_monospaced_changed): New function.
1154 (EMACS_SETTINGS): A new type derived from GObject to handle
1155 GSettings notifications.
1156 (emacs_settings_constructor, emacs_settings_get_property)
1157 (emacs_settings_set_property, emacs_settings_class_init):
1159 (gsettings_client, gsettings_obj): New variables.
1160 (GSETTINGS_SCHEMA): New define.
1161 (something_changedCB): Call store_monospaced_changed.
1162 (init_gsettings): New function.
1163 (xsettings_initialize): Call init_gsettings.
1164 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1167 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1170 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1172 * window.c (resize_root_window, grow_mini_window)
1173 (shrink_mini_window): Rename Qresize_root_window to
1174 Qwindow_resize_root_window and Qresize_root_window_vertically to
1175 Qwindow_resize_root_window_vertically.
1177 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1179 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1181 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1183 * makefile.w32-in: Redesign dependencies so they reflect more
1184 clearly which files are directly included by each source file,
1185 and not through other includes.
1187 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1189 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1190 (sort_overlays, overlay_strings): When an overlay's clone number
1191 matches the window's clone number process the overlay even if
1192 the overlay's window property doesn't match the current window.
1194 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1195 (Fwindow_hchild): Rename to Fwindow_left_child.
1196 (Fwindow_next): Rename to Fwindow_next_sibling.
1197 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1198 (resize_window_check): Rename to window_resize_check.
1199 (resize_window_apply): Rename to window_resize_apply.
1200 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1201 (Fdelete_other_windows_internal, resize_frame_windows)
1202 (Fsplit_window_internal, Fdelete_window_internal)
1203 (grow_mini_window, shrink_mini_window)
1204 (Fresize_mini_window_internal): Fix callers accordingly.
1206 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1208 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1209 (emacs_fixed_set_min_size): Remove.
1210 (emacs_fixed_new): Take frame as argument.
1212 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1213 (_EmacsFixedPrivate): Remove minwidth/height.
1214 Add struct frame *f.
1215 (emacs_fixed_init): Initialize priv->f.
1216 (get_parent_class, emacs_fixed_set_min_size): Remove.
1217 (emacs_fixed_new): Set priv->f to argument.
1218 (emacs_fixed_get_preferred_width)
1219 (emacs_fixed_get_preferred_height): Use min_width/height from
1220 frames size_hint to set minimum and natural (Bug#8919).
1221 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1222 and use min_width/height from frames size_hint to set
1223 min_width/height (Bug#8919).
1225 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1226 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1229 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1231 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1232 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1235 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1237 * process.c (wait_reading_process_output): Bypass select if
1238 waiting for a cell while ignoring keyboard input, and input is
1239 pending. Suggested by Jan Djärv (Bug#8869).
1241 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1243 Use gnulib's dup2 module instead of rolling our own.
1244 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1246 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1248 * dispnew.c (scrolling_window): Before scrolling, turn off a
1249 mouse-highlight in the window being scrolled.
1251 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1253 Move DEFSYM to lisp.h and use everywhere.
1255 * character.h (DEFSYM): Move declaration...
1256 * lisp.h (DEFSYM): ...here.
1262 * w32select.c: Don't include character.h.
1264 * alloc.c (syms_of_alloc):
1265 * buffer.c (syms_of_buffer):
1266 * bytecode.c (syms_of_bytecode):
1267 * callint.c (syms_of_callint):
1268 * casefiddle.c (syms_of_casefiddle):
1269 * casetab.c (init_casetab_once):
1270 * category.c (init_category_once, syms_of_category):
1271 * ccl.c (syms_of_ccl):
1272 * cmds.c (syms_of_cmds):
1273 * composite.c (syms_of_composite):
1274 * dbusbind.c (syms_of_dbusbind):
1275 * dired.c (syms_of_dired):
1276 * dispnew.c (syms_of_display):
1277 * doc.c (syms_of_doc):
1278 * editfns.c (syms_of_editfns):
1279 * emacs.c (syms_of_emacs):
1280 * eval.c (syms_of_eval):
1281 * fileio.c (syms_of_fileio):
1282 * fns.c (syms_of_fns):
1283 * frame.c (syms_of_frame):
1284 * fringe.c (syms_of_fringe):
1285 * insdel.c (syms_of_insdel):
1286 * keymap.c (syms_of_keymap):
1287 * lread.c (init_obarray, syms_of_lread):
1288 * macros.c (syms_of_macros):
1289 * msdos.c (syms_of_msdos):
1290 * print.c (syms_of_print):
1291 * process.c (syms_of_process):
1292 * search.c (syms_of_search):
1293 * sound.c (syms_of_sound):
1294 * syntax.c (init_syntax_once, syms_of_syntax):
1295 * terminal.c (syms_of_terminal):
1296 * textprop.c (syms_of_textprop):
1297 * undo.c (syms_of_undo):
1298 * w32.c (globals_of_w32):
1299 * window.c (syms_of_window):
1300 * xdisp.c (syms_of_xdisp):
1301 * xfaces.c (syms_of_xfaces):
1302 * xfns.c (syms_of_xfns):
1303 * xmenu.c (syms_of_xmenu):
1304 * xsettings.c (syms_of_xsettings):
1305 * xterm.c (syms_of_xterm): Use DEFSYM.
1307 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1309 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1311 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1313 Integer and buffer overflow fixes (Bug#8873).
1315 * print.c (printchar, strout): Check for string overflow.
1316 (PRINTPREPARE, printchar, strout):
1317 Don't set size unless allocation succeeds.
1319 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1320 for sizes. Check for string overflow more accurately.
1321 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1323 * macros.c: Integer and buffer overflow fixes.
1324 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1325 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1326 Use ptrdiff_t, not int, for sizes.
1327 Don't increment bufsize until after realloc succeeds.
1328 Check for size-calculation overflow.
1329 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1331 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1333 * lread.c: Integer overflow fixes.
1334 (read_integer): Radix is now EMACS_INT, not int,
1335 to improve quality of diagnostics for out-of-range radices.
1336 Calculate buffer size correctly for out-of-range radices.
1337 (read1): Check for integer overflow in radices, and in
1338 read-circle numbers.
1339 (read_escape): Avoid int overflow.
1340 (Fload, openp, read_buffer_size, read1)
1341 (substitute_object_recurse, read_vector, read_list, map_obarray):
1342 Use ptrdiff_t, not int, for sizes.
1343 (read1): Use EMACS_INT, not int, for sizes.
1344 Check for size overflow.
1346 * image.c (cache_image): Check for size arithmetic overflow.
1348 * lread.c: Integer overflow issues.
1349 (saved_doc_string_size, saved_doc_string_length)
1350 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1351 Now ptrdiff_t, not int.
1352 (read1): Don't assume doc string length fits in int. Check for
1353 out-of-range doc string lengths.
1354 (read_list): Don't assume file position fits in int.
1355 (read_escape): Check for hex character overflow.
1357 2011-06-22 Leo Liu <sdl.web@gmail.com>
1359 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1360 Move to minibuffer.el.
1362 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1364 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1365 The following patches are for when GLYPH_DEBUG && !XASSERT.
1366 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1367 * dispnew.c (flush_stdout):
1368 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1369 Mark as externally visible.
1370 * dispnew.c (check_window_matrix_pointers): Now static.
1371 * dispnew.c (window_to_frame_vpos):
1372 * xfns.c (unwind_create_frame):
1373 * xterm.c (x_check_font): Remove unused local.
1374 * scroll.c (CHECK_BOUNDS):
1375 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1376 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1377 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1378 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1379 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1381 (debug_method_add): Use va_list and vsprintf rather than relying
1382 on undefined behavior with wrong number of arguments.
1383 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1384 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1385 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1386 since we're not interested in debugging glyphs with old libraries.
1387 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1388 GCC 4.6.0's static checking.
1390 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1392 Integer overflow and signedness fixes (Bug#8873).
1393 A few related buffer overrun fixes, too.
1395 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1397 * dispextern.h (struct face.stipple):
1398 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1399 (x_bitmap_mask, x_allocate_bitmap_record)
1400 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1401 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1402 (x_create_bitmap_from_xpm_data):
1403 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1404 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1406 * xfaces.c (load_pixmap):
1407 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1408 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1409 (.bitmaps_last, struct x_output.icon_bitmap):
1410 Use ptrdiff_t, not int, for bitmap indexes.
1411 (x_allocate_bitmap_record): Check for size overflow.
1412 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1414 Use ptrdiff_t, not int, for overlay counts.
1415 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1416 * editfns.c (overlays_around, get_pos_property):
1417 * textprop.c (get_char_property_and_overlay):
1418 * xdisp.c (next_overlay_change, note_mouse_highlight):
1419 * xfaces.c (face_at_buffer_position):
1420 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1421 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1422 (Fnext_overlay_change, Fprevious_overlay_change)
1423 (mouse_face_overlay_overlaps, Foverlays_in):
1424 Use ptrdiff_t, not int, for sizes.
1425 (overlays_at, overlays_in): Check for size-calculation overflow.
1427 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1429 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1430 (x_session_initialize): Do not assume string length fits in int.
1432 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1433 This is unlikely, but can occur if DPI is outlandish.
1435 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1436 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1438 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1439 * xrdb.c (magic_file_p, search_magic_path):
1440 Omit last arg SUFFIX; it was always 0. All callers changed.
1441 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1443 * xfont.c (xfont_match): Avoid need for strlen.
1445 * xfns.c: Don't assume strlen fits in int.
1446 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1448 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1449 not unsigned long, as we prefer signed integers. All callers changed.
1450 Detect integer overflow in repeat count.
1451 (message_dolog): Don't assume print length fits in 39 bytes.
1452 (display_mode_element): Don't assume strlen fits in int.
1454 * termcap.c: Don't assume sizes fit in int and never overflow.
1455 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1456 (gobble_line): Check for size-calculation overflow.
1458 * minibuf.c (Fread_buffer):
1459 * lread.c (intern, intern_c_string):
1460 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1461 Don't assume string length fits in int.
1463 * keyboard.c (parse_tool_bar_item):
1464 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1466 * font.c: Don't assume string length fits in int.
1467 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1468 Use ptrdiff_t, not int.
1469 (font_intern_prop): Don't assume string length fits in int.
1470 Don't assume integer property fits in fixnum.
1471 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1473 * filelock.c: Fix some buffer overrun and integer overflow issues.
1474 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1475 Reformulate so as not to need the command string.
1476 Invoke gzip -cd rather than gunzip, as it's more portable.
1477 (lock_info_type, lock_file_1, lock_file):
1478 Don't assume pid_t and time_t fit in unsigned long.
1479 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1480 (current_lock_owner): Prefer signed type for sizes.
1481 Use memcpy, not strncpy, where memcpy is what is really wanted.
1482 Don't assume (via atoi) that time_t and pid_t fit in int.
1483 Check for time_t and/or pid_t out of range, e.g., via a network share.
1484 Don't alloca where an auto var works fine.
1486 * fileio.c: Fix some integer overflow issues.
1487 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1488 Don't assume string length fits in int.
1489 (directory_file_name): Don't assume string length fits in long.
1490 (make_temp_name): Don't assume pid fits in int, or that its print
1491 length is less than 20.
1493 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1495 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1497 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1499 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1500 We prefer signed integers, even for size calculations.
1502 * emacs.c: Don't assume string length fits in 'int'.
1503 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1504 (main): Don't invoke strlen when not needed.
1506 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1507 (XD_DEBUG_MESSAGE): Don't waste a byte.
1509 * callproc.c (getenv_internal_1, getenv_internal)
1511 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1513 * lread.c (invalid_syntax): Omit length argument.
1514 All uses changed. This doesn't fix a bug, but it simplifies the
1515 code away from its former Hollerith-constant appearance, and it's
1516 one less 'int' to worry about when looking at integer-overflow issues.
1517 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1519 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1520 This didn't break anything, but it didn't help either.
1521 It's confusing to put a bogus integer in a place where the actual
1522 value does not matter.
1523 (LIST_END_P): Remove unused macro and its bogus comment.
1524 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1526 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1527 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1529 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1530 We prefer signed types, and the value cannot exceed the EMACS_INT
1531 range anyway (because otherwise the length would not be representable).
1532 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1533 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1534 This avoids a GCC warning when WIDE_EMACS_INT.
1536 * indent.c (sane_tab_width): New function.
1537 (current_column, scan_for_column, Findent_to, position_indentation)
1538 (compute_motion): Use it. This is just for clarity.
1539 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1541 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1543 * lisp.h (lint_assume): New macro.
1544 * composite.c (composition_gstring_put_cache):
1545 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1547 * editfns.c, insdel.c:
1548 Omit unnecessary forward decls, to simplify future changes.
1550 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1552 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1554 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1555 Use much-faster test for byte-length change.
1556 Don't assume string byte-length fits in 'int'.
1557 Check that character arg fits in 'int'.
1558 (mapcar1): Declare byte as byte, for clarity.
1560 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1562 * fns.c (concat): Catch string overflow earlier.
1563 Do not rely on integer wraparound.
1565 * dispextern.h (struct it.overlay_strings_charpos)
1566 (struct it.selective): Now EMACS_INT, not int.
1567 * xdisp.c (forward_to_next_line_start)
1568 (back_to_previous_visible_line_start)
1569 (reseat_at_next_visible_line_start, next_element_from_buffer):
1570 Don't arbitrarily truncate the value of 'selective' to int.
1572 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1574 * composite.c: Don't truncate sizes to 'int'.
1575 (composition_gstring_p, composition_reseat_it)
1576 (composition_adjust_point): Use EMACS_INT, not int.
1577 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1578 not EMACS_UINT, for indexes.
1580 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1582 * buffer.c: Include <verify.h>.
1583 (struct sortvec.priority, struct sortstr.priority):
1584 Now EMACS_INT, not int.
1585 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1586 (struct sortstr.size, record_overlay_string)
1587 (struct sortstrlist.size, struct sortlist.used):
1588 Don't truncate size to int.
1589 (record_overlay_string): Check for size-calculation overflow.
1590 (init_buffer_once): Check at compile-time, not run-time.
1592 2011-06-22 Jim Meyering <meyering@redhat.com>
1594 Don't leak an XBM-image-sized buffer
1595 * image.c (xbm_load): Free the image buffer after using it.
1597 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1600 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1601 that Sun C diagnosed.
1602 * fns.c (secure_hash): Fix pointer signedness issue.
1603 * intervals.c (static_offset_intervals): New function.
1604 (offset_intervals): Use it.
1606 2011-06-21 Leo Liu <sdl.web@gmail.com>
1609 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1612 * fns.c (secure_hash): Rename from crypto_hash_function and change
1613 the first arg to accept symbols.
1614 (Fsecure_hash): New primitive.
1615 (syms_of_fns): New symbols.
1617 2011-06-20 Deniz Dogan <deniz@dogan.se>
1619 * process.c (Fset_process_buffer): Clarify return value in
1622 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1624 * dispnew.c (add_window_display_history): Use BVAR.
1626 * xdisp.c (debug_method_add): Use BVAR.
1627 (check_window_end, dump_glyph_matrix, dump_glyph)
1628 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1630 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1633 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1634 check till after the cache is created in init_frame_faces.
1636 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1638 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1640 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1642 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1643 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1644 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1646 Improve buffer-overflow checking (Bug#8873).
1647 * fileio.c (Finsert_file_contents):
1648 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1649 Remove the old (too-loose) buffer overflow checks.
1650 They weren't needed, since make_gap checks for buffer overflow.
1651 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1652 The old code merely checked for Emacs fixnum overflow, and relied
1653 on undefined (wraparound) behavior. The new code avoids undefined
1654 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1656 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1657 Tune. Don't use wider integers than needed. Don't use alloca.
1658 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1660 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1662 * insdel.c, lisp.h (buffer_overflow): New function.
1663 (insert_from_buffer_1, replace_range, replace_range_2):
1664 * insdel.c (make_gap_larger):
1665 * editfns.c (Finsert_char):
1666 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1668 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1670 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1672 Integer overflow and signedness fixes (Bug#8873).
1674 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1675 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1677 * fileio.c: Don't assume EMACS_INT fits in off_t.
1678 (emacs_lseek): New static function.
1679 (Finsert_file_contents, Fwrite_region): Use it.
1680 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1682 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1684 * fns.c: Don't overflow int when computing a list length.
1685 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1686 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1687 truncation on 64-bit hosts. Check for QUIT every
1688 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1689 faster and is responsive enough.
1690 (Flength): Report an error instead of overflowing an integer.
1691 (Fsafe_length): Return a float if the value is not representable
1692 as a fixnum. This shouldn't happen except in contrived situations.
1693 (Fnthcdr, Fsort): Don't assume list length fits in int.
1694 (Fcopy_sequence): Don't assume vector length fits in int.
1696 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1697 (header_size, word_size): New constants.
1698 (allocate_vectorlike): Don't check size overflow here.
1699 (allocate_vector): Check it here instead, since this is the only
1700 caller of allocate_vectorlike that could cause overflow.
1701 Check that the new vector's length is representable as a fixnum.
1703 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1704 The previous code was bogus. For example, next_almost_prime (32)
1705 returned 39, which is undesirable as it is a multiple of 3; and
1706 next_almost_prime (24) returned 25, which is a multiple of 5 so
1707 why was the code bothering to check for multiples of 7?
1709 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1711 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1713 Variadic C functions now count arguments with ptrdiff_t.
1714 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1715 Back then I didn't know that the Emacs coding style prefers signed int.
1716 Also, in the meantime I found a few more instances where arguments
1717 were being counted with int, which may truncate counts on 64-bit
1718 machines, or EMACS_INT, which may be unnecessarily wide.
1719 * lisp.h (struct Lisp_Subr.function.aMANY)
1720 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1721 Arg counts are now ptrdiff_t, not size_t.
1722 All variadic functions and their callers changed accordingly.
1723 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1724 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1725 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1726 * callint.c (Fcall_interactively): Check arg count for overflow,
1727 to avoid potential buffer overrun. Use signed char, not 'int',
1728 for 'varies' array, so that we needn't bother to check its size
1729 calculation for overflow.
1730 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1731 * eval.c (apply_lambda):
1732 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1733 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1734 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1736 * callint.c (Fcall_interactively): Don't use index var as event count.
1738 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1739 * mem-limits.h (SIZE): Remove; no longer used.
1741 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1743 Remove unnecessary casts.
1744 * xterm.c (x_term_init):
1745 * xfns.c (x_set_border_pixel):
1746 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1747 These aren't needed now that we assume ANSI C.
1749 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1750 It's more likely to cause problems (due to unsigned overflow)
1753 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1755 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1757 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1759 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1761 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1763 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1765 GLYPH_CODE_FACE returns EMACS_INT, not int.
1766 * dispextern.h (merge_faces):
1767 * xfaces.c (merge_faces):
1768 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1769 Don't assume EMACS_INT fits in int.
1771 * character.h (CHAR_VALID_P): Remove unused parameter.
1772 * fontset.c, lisp.h, xdisp.c: All uses changed.
1774 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1776 * fns.c (concat): Minor tuning based on overflow analysis.
1777 This doesn't fix any bugs. Use int to hold character, instead
1778 of constantly refetching from Emacs object. Use XFASTINT, not
1779 XINT, for value known to be a character. Don't bother comparing
1780 a single byte to 0400, as it's always less.
1782 * floatfns.c (Fexpt):
1783 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1785 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1788 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1790 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1791 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1792 incorrectly succeed when S was a string, because 4294967386 was
1793 truncated before it was used.
1795 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1796 Otherwise, an out-of-range integer could cause undefined behavior
1799 * composite.c: Use int, not EMACS_INT, for characters.
1800 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1801 EMACS_INT, for values that are known to be in character range.
1802 This doesn't fix any bugs but is the usual style inside Emacs and
1803 may generate better code on 32-bit machines.
1805 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1806 This is for reasons similar to the recent CHAR_STRING fix.
1807 * charset.c (Fencode_char): Check that character arg is actually
1808 a character. Pass an int to ENCODE_CHAR.
1809 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1810 wider than 'int', as a compile-time check to prevent future regressions
1813 * character.c (char_string): Remove unnecessary casts.
1815 Make sure a 64-bit char is never passed to CHAR_STRING.
1816 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1817 by silently ignoring the top 32 bits, allowing some values
1818 that were far too large to be valid characters.
1819 * character.h: Include <verify.h>.
1820 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1821 arguments are no wider than unsigned, as a compile-time check
1822 to prevent future regressions in this area.
1824 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1825 (Fsubst_char_in_region):
1827 * xdisp.c (decode_mode_spec_coding):
1828 Adjust to CHAR_STRING's new requirement.
1829 * editfns.c (Finsert_char, Fsubst_char_in_region):
1830 * fns.c (concat): Check that character args are actually
1831 characters. Without this test, these functions did the wrong
1832 thing with wildly out-of-range values on 64-bit hosts.
1834 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1835 These casts should not be needed on 32-bit hosts, either.
1836 * keyboard.c (read_char):
1837 * lread.c (Fload): Remove casts to unsigned.
1839 * lisp.h (UNSIGNED_CMP): New macro.
1840 This fixes comparison bugs on 64-bit hosts.
1841 (ASCII_CHAR_P): Use it.
1842 * casefiddle.c (casify_object):
1843 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1844 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1845 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1846 * dispextern.h (FACE_FROM_ID):
1847 * keyboard.c (read_char): Use UNSIGNED_CMP.
1849 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1850 not to EMACS_INT, to avoid GCC warning.
1852 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1854 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1855 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1856 isn't needed on 32-bit machines.
1858 * buffer.c (Fgenerate_new_buffer_name):
1859 Use EMACS_INT for count, not int.
1860 (advance_to_char_boundary): Return EMACS_INT, not int.
1862 * data.c (Qcompiled_function): Now static.
1864 * window.c (window_body_lines): Now static.
1866 * image.c (gif_load): Rename local to avoid shadowing.
1868 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1869 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1870 * alloc.c (make_save_value): Integer argument is now of type
1872 (mark_object): Use ptrdiff_t, not int.
1873 * lisp.h (pD): New macro.
1874 * print.c (print_object): Use it.
1876 * alloc.c: Use EMACS_INT, not int, to count objects.
1877 (total_conses, total_markers, total_symbols, total_vector_size)
1878 (total_free_conses, total_free_markers, total_free_symbols)
1879 (total_free_floats, total_floats, total_free_intervals)
1880 (total_intervals, total_strings, total_free_strings):
1881 Now EMACS_INT, not int. All uses changed.
1882 (Fgarbage_collect): Compute overall total using a double, so that
1883 integer overflow is less likely to be a problem. Check for overflow
1884 when converting back to an integer.
1885 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1886 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1887 These were 'int' variables that could overflow on 64-bit hosts;
1888 they were never used, so remove them instead of repairing them.
1889 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1890 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1891 Previously, this ceilinged at INT_MAX, but that doesn't work on
1893 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1895 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1896 (allocate_vectorlike): Check for ptrdiff_t overflow.
1897 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1898 when a (possibly-narrower) signed value would do just as well.
1899 We prefer using signed arithmetic, to avoid comparison confusion.
1901 * alloc.c: Catch some string size overflows that we were missing.
1902 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1903 for convenience in STRING_BYTES_MAX.
1904 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1905 The definition here is exact; the one in lisp.h was approximate.
1906 (allocate_string_data): Check for string overflow. This catches
1907 some instances we weren't catching before. Also, it catches
1908 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1909 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1910 and ptrdiff_t and EMACS_INT are both 64 bits.
1912 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1913 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1914 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1916 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1918 * alloc.c (Fmake_string): Check for out-of-range init.
1920 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1922 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1924 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1926 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1927 xg_get_default_scrollbar_width.
1929 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1930 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1931 (style_changed_cb): Call update_theme_scrollbar_width and call
1932 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1933 all frames (Bug#8505).
1934 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1935 Call gtk_window_set_resizable if HAVE_GTK3.
1936 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1937 and height if HAVE_GTK3 (Bug#8505).
1938 (scroll_bar_width_for_theme): New variable.
1939 (update_theme_scrollbar_width): New function.
1940 (xg_get_default_scrollbar_width): Move code to
1941 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1942 (xg_initialize): Call update_theme_scrollbar_width.
1944 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1946 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1948 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1950 * frame.c (make_frame): Call other_buffer_safely instead of
1953 * window.c (temp_output_buffer_show): Call display_buffer with
1954 second argument Vtemp_buffer_show_specifiers and reset latter
1955 immediately after the call.
1956 (Vtemp_buffer_show_specifiers): New variable.
1957 (auto_window_vscroll_p, next_screen_context_lines)
1958 (Vscroll_preserve_screen_position): Remove leading asterisks from
1961 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1963 Fix minor problems found by GCC 4.6.0 static checking.
1964 * buffer.c (Qclone_number): Remove for now, as it's unused.
1965 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1966 (record_buffer): Remove unused local.
1967 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1968 (set_frame_buffer_list): Remove; unused.
1969 * frame.h (other_visible_frames): Remove decl.
1970 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1971 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1972 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1974 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1975 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1976 Define only if HAVE_GPM.
1977 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1978 (update_hints_inhibit): Remove; never set. All uses removed.
1979 * widgetprv.h (emacsFrameClassRec): Remove decl.
1980 * window.c (delete_deletable_window): Now returns void, since it
1981 wasn't returning anything.
1982 (compare_window_configurations): Remove unused locals.
1983 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1984 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1985 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1986 the same widths as pointers. This follows up on the 2011-05-06 patch.
1987 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1988 * xterm.h: Likewise.
1989 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1991 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1993 * makefile.w32-in: Update dependencies.
1994 (LISP_H): Add lib/intprops.h.
1996 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1998 * image.c (gif_load): Add animation frame delay to the metadata.
1999 (syms_of_image): Use DEFSYM. New symbol `delay'.
2001 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2003 * window.c (delete_deletable_window): Re-add.
2004 (Fset_window_configuration): Rewrite to handle dead buffers and
2005 consequently deletable windows.
2006 (window_tree, Fwindow_tree): Remove. Supply functionality in
2008 (compare_window_configurations): Simplify code.
2010 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2012 * image.c (imagemagick_load_image): Fix type mismatch.
2013 (Fimagemagick_types): Likewise.
2015 * window.h (replace_buffer_in_windows): Declare.
2017 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2019 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2020 Qclone_number. Remove external declaration of Qdelete_window.
2021 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2023 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2024 Qbuffer_list_update_hook if allowed.
2025 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2026 buffer list implementation.
2027 (other_buffer_safely): New function.
2028 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2029 calls to replace_buffer_in_windows and
2030 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2032 (record_buffer): Inhibit quitting and rewrite using quittable
2033 functions. Run Qbuffer_list_update_hook if allowed.
2034 (Frecord_buffer, Funrecord_buffer): New functions.
2035 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2036 switch-to-buffer to window.el.
2037 (bury-buffer): Move to window.el.
2038 (Vbuffer_list_update_hook): New variable.
2040 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2043 * window.h (resize_frame_windows): Move up in code.
2044 (Fwindow_frame): Remove EXFUN.
2045 (replace_buffer_in_all_windows): Remove prototype.
2046 (replace_buffer_in_windows_safely): Add prototype.
2048 * window.c: Declare Qdelete_window static again. Move down
2049 declaration of select_count.
2050 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2051 (Fother_window): Move to window.el.
2052 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2053 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2054 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2056 (replace_buffer_in_windows): Implement by calling
2057 Qreplace_buffer_in_windows.
2058 (replace_buffer_in_all_windows): Remove with some functionality
2059 moved into replace_buffer_in_windows_safely.
2060 (replace_buffer_in_windows_safely): New function.
2061 (select_window_norecord, select_frame_norecord): Move in front
2062 of run_window_configuration_change_hook. Remove now obsolete
2064 (Fset_window_buffer): Rewrite doc-string. Call
2065 Qrecord_window_buffer.
2066 (keys_of_window): Move binding for other-window to window.el.
2068 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2070 * dispextern.h (struct image): Replace data member, whose int_val
2071 and ptr_val fields were not used by anything, with a single
2074 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2075 (gif_clear_image, gif_load, imagemagick_load_image)
2076 (gs_clear_image, gs_load): Callers changed.
2078 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2080 * buffer.h: Include <time.h>, for time_t.
2081 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2083 Fix minor problems found by static checking.
2085 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2087 Make identifiers static if they are not used in other modules.
2088 * data.c (Qcompiled_function, Qframe, Qvector):
2089 * image.c (QimageMagick, Qsvg):
2090 * minibuf.c (Qmetadata):
2091 * window.c (resize_window_check, resize_root_window): Now static.
2092 * window.h (resize_window_check, resize_root_window): Remove decls.
2094 * window.c (window_deletion_count, delete_deletable_window):
2096 (window_body_lines): Now static.
2097 (Fdelete_other_windows_internal): Mark vars as initialized.
2098 Make sure 'resize_failed' is initialized.
2099 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2100 (resize_window_apply): Remove unused local.
2101 * window.h (delete_deletable_window): Remove decl.
2103 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2104 (imagemagick_load_image): Fix pointer signedness problem by changing
2105 last arg from unsigned char * to char *. All uses changed.
2106 Also, fix a local for similar reasons.
2107 Remove unused locals. Remove locals to avoid shadowing.
2108 (fn_rsvg_handle_free): Remove; unused.
2109 (svg_load, svg_load_image): Fix pointer signedness problem.
2110 (imagemagick_load_image): Don't use garbage pointer image_wand.
2112 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2114 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2116 * image.c (gif_load): Fix omitted cast error introduced by
2119 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2121 * window.h (resize_proportionally, orig_total_lines)
2122 (orig_top_line): Remove from window structure.
2123 (set_window_height, set_window_width, change_window_heights)
2124 (Fdelete_window): Remove prototypes.
2125 (resize_frame_windows): Remove duplicate declaration.
2127 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2129 * window.h (resize_frame_windows, resize_window_check)
2130 (delete_deletable_window, resize_root_window)
2131 (resize_frame_windows): Declare prototypes.
2133 * window.c (resize_window_apply): Make definition be "static" to
2134 match the prototype.
2136 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2138 * window.c: Remove declarations of Qwindow_size_fixed,
2139 window_min_size_1, window_min_size_2, window_min_size,
2140 size_window, window_fixed_size_p, enlarge_window, delete_window.
2141 Remove static from declaration of Qdelete_window, it's
2142 temporarily needed by Fbury_buffer.
2143 (replace_window): Don't assign orig_top_line and
2145 (Fdelete_window, delete_window): Remove. Window deletion is
2146 handled by window.el.
2147 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2148 Fdelete_window calls with calls to Qdelete_window.
2149 (Fdelete_other_windows): Remove. Deleting other windows is
2150 handled by window.el.
2151 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2152 handled in window.el.
2153 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2154 Window minimum sizes are handled in window.el.
2155 (shrink_windows, size_window, set_window_height)
2156 (set_window_width, change_window_heights, window_height)
2157 (window_width, CURBEG, CURSIZE, enlarge_window)
2158 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2159 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2160 handled in window.el.
2161 (make_dummy_parent): Rename to make_parent_window and give it a
2162 second argument horflag.
2163 (make_window): Don't set resize_proportionally any more.
2164 (Fsplit_window): Remove. Windows are split in window.el.
2165 (save_restore_action, save_restore_orig_size)
2166 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2167 Resize mini windows in window.el.
2168 (grow_mini_window, shrink_mini_window): Implement by calling
2169 Qresize_root_window_vertically, resize_window_check and
2170 resize_window_apply.
2171 (saved_window, Fset_window_configuration, save_window_save): Do
2172 not handle orig_top_line, orig_total_lines, and
2173 resize_proportionally.
2174 (window_min_height, window_min_width): Move to window.el.
2175 (keys_of_window): Move bindings for delete-other-windows,
2176 split-window, delete-window and enlarge-window to window.el.
2178 * buffer.c: Temporarily extern Qdelete_window.
2179 (Fbury_buffer): Temporarily call Qdelete_window instead of
2180 Fdelete_window (Fbury_buffer will move to window.el soon).
2182 * frame.c (set_menu_bar_lines_1): Remove code handling
2183 orig_top_line and orig_total_lines.
2185 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2186 set_window_height but set heights directly.
2187 (change_frame_size_1): Use resize_frame_windows.
2189 * xdisp.c (init_xdisp): Don't use set_window_height but set
2192 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2193 resize_frame_windows instead of change_window_heights and run
2194 run_window_configuration_change_hook.
2196 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2197 instead of change_window_heights and run
2198 run_window_configuration_change_hook.
2200 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2202 * window.c (replace_window): Rename second argument REPLACEMENT to
2203 NEW. New third argument SETFLAG. Rewrite.
2204 (delete_window, make_dummy_parent): Call replace_window with
2206 (window_list_1): Move down in code.
2207 (run_window_configuration_change_hook): Move set_buffer part
2208 before select_frame_norecord part in order to unwind correctly.
2209 Rename count1 to count.
2210 (recombine_windows, delete_deletable_window, resize_root_window)
2211 (Fdelete_other_windows_internal)
2212 (Frun_window_configuration_change_hook, make_parent_window)
2213 (resize_window_check, resize_window_apply, Fresize_window_apply)
2214 (resize_frame_windows, Fsplit_window_internal)
2215 (Fdelete_window_internal, Fresize_mini_window_internal): New
2217 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2219 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2221 * window.h (window): Add some new members to window structure -
2222 normal_lines, normal_cols, new_total, new_normal, clone_number,
2223 splits, nest, prev_buffers, next_buffers.
2224 (WINDOW_TOTAL_SIZE): Move here from window.c.
2225 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2227 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2229 (make_dummy_parent): Set new members of windows structure.
2230 (make_window): Move down in code. Handle new members of window
2232 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2233 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2234 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2235 (Fset_window_prev_buffers, Fwindow_next_buffers)
2236 (Fset_window_next_buffers, Fset_window_clone_number): New
2238 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2239 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2241 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2242 Argument WINDOW can be now internal window too.
2243 (Fwindow_use_time): Move up in code.
2244 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2246 (Fset_window_configuration, saved_window)
2247 (Fcurrent_window_configuration, save_window_save): Handle new
2248 members of window structure.
2249 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2250 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2251 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2252 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2253 Qget_mru_window, Qresize_root_window,
2254 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2255 Qauto_buffer_name; staticpro them.
2257 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2259 * window.c (Fwindow_total_size, Fwindow_left_column)
2260 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2261 (Fwindow_list_1): New functions.
2262 (window_box_text_cols): Replace with window_body_cols.
2263 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2264 window_body_cols instead of window_box_text_cols.
2265 (delete_window, Fset_window_configuration): Call
2266 delete_all_subwindows with window as argument.
2267 (delete_all_subwindows): Take a window as argument and not a
2269 (window_loop): Remove handling of GET_LRU_WINDOW and
2271 (Fget_lru_window, Fget_largest_window): Move to window.el.
2273 * window.h: Extern window_body_cols instead of
2274 window_box_text_cols. delete_all_subwindows now takes a
2275 Lisp_Object as argument.
2277 * indent.c (compute_motion, Fcompute_motion): Use
2278 window_body_cols instead of window_box_text_cols.
2280 * frame.c (delete_frame): Call delete_all_subwindows with root
2283 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2285 * fns.c (Fputhash): Document return value.
2287 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2289 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2291 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2293 Cons<->int and similar integer overflow fixes (Bug#8794).
2295 Check for overflow when converting integer to cons and back.
2296 * charset.c (Fdefine_charset_internal, Fdecode_char):
2297 Use cons_to_unsigned to catch overflow.
2298 (Fencode_char): Use INTEGER_TO_CONS.
2299 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2300 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2301 * data.c (long_to_cons, cons_to_long): Remove.
2302 (cons_to_unsigned, cons_to_signed): New functions.
2303 These signal an error for invalid or out-of-range values.
2304 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2305 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2306 * font.c (Ffont_variation_glyphs):
2307 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2308 * lisp.h: Include <intprops.h>.
2309 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2310 (cons_to_signed, cons_to_unsigned): New decls.
2311 (long_to_cons, cons_to_long): Remove decls.
2312 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2313 (Fprimitive_undo): Use CONS_TO_INTEGER.
2314 * xfns.c (Fx_window_property): Likewise.
2315 * xselect.c: Include <limits.h>.
2316 (x_own_selection, selection_data_to_lisp_data):
2317 Use INTEGER_TO_CONS.
2318 (x_handle_selection_request, x_handle_selection_clear)
2319 (x_get_foreign_selection, Fx_disown_selection_internal)
2320 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2321 (lisp_data_to_selection_data): Use cons_to_unsigned.
2322 (x_fill_property_data): Use cons_to_signed.
2323 Report values out of range.
2325 Check for buffer and string overflow more precisely.
2326 * buffer.h (BUF_BYTES_MAX): New macro.
2327 * lisp.h (STRING_BYTES_MAX): New macro.
2328 * alloc.c (Fmake_string):
2329 * character.c (string_escape_byte8):
2330 * coding.c (coding_alloc_by_realloc):
2331 * doprnt.c (doprnt):
2332 * editfns.c (Fformat):
2334 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2335 since they may not be the same number.
2336 * editfns.c (Finsert_char):
2337 * fileio.c (Finsert_file_contents):
2338 Likewise for BUF_BYTES_MAX.
2340 * image.c: Use ptrdiff_t, not int, for sizes.
2341 (slurp_file): Switch from int to ptrdiff_t.
2343 (slurp_file): Check that file size fits in both size_t (for
2344 malloc) and ptrdiff_t (for sanity and safety).
2346 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2347 if b->modtime has its maximal value.
2349 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2351 Don't assume time_t can fit into int.
2352 * buffer.h (struct buffer.modtime): Now time_t, not int.
2353 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2354 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2356 Minor fixes for signed vs unsigned integers.
2357 * character.h (MAYBE_UNIFY_CHAR):
2358 * charset.c (maybe_unify_char):
2359 * keyboard.c (read_char, reorder_modifiers):
2360 XINT -> XFASTINT, since the integer must be nonnegative.
2361 * ftfont.c (ftfont_spec_pattern):
2362 * keymap.c (access_keymap, silly_event_symbol_error):
2363 XUINT -> XFASTINT, since the integer must be nonnegative.
2364 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2365 since it makes no difference and we prefer signed.
2366 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2367 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2370 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2372 * window.h (Fwindow_frame): Declare.
2374 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2376 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2377 (SPARE_MEMORY): Always define.
2378 (LARGE_REQUEST): Remove.
2379 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2381 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2383 * lisp.h: Move EXFUNS for Fframe_root_window,
2384 Fframe_first_window and Fset_frame_selected_window to window.h.
2386 * window.h: Move EXFUNS for Fframe_root_window,
2387 Fframe_first_window and Fset_frame_selected_window here from
2390 * frame.c (Fwindow_frame, Fframe_first_window)
2391 (Fframe_root_window, Fframe_selected_window)
2392 (Fset_frame_selected_window): Move to window.c.
2393 (Factive_minibuffer_window): Move to minibuf.c.
2394 (Fother_visible_frames_p): New function.
2396 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2398 * window.c (decode_window, decode_any_window): Move up in code.
2399 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2400 (inhibit_frame_unsplittable): Remove unused variable.
2401 (Fwindow_buffer): Move up and rewrite doc-string.
2402 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2403 (Fwindow_prev): New functions.
2404 (Fwindow_frame): Move here from frame.c. Accept any window as
2406 (Fframe_root_window, Fframe_first_window)
2407 (Fframe_selected_window): Move here from frame.c. Accept frame
2408 or arbitrary window as argument. Update doc-strings.
2409 (Fminibuffer_window): Move up in code.
2410 (Fwindow_minibuffer_p): Move up in code and simplify.
2411 (Fset_frame_selected_window): Move here from frame.c.
2413 (Fselected_window, select_window, Fselect_window): Move up in
2414 code. Minor doc-string fixes.
2416 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2418 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2419 Do not assume that spare memory exists; that assumption is valid
2420 only if SYSTEM_MALLOC.
2421 (LARGE_REQUEST): New macro, so that the issue of large requests
2422 is separated from the issue of spare memory.
2424 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2426 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2429 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2431 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2434 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2436 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2438 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2440 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2441 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2443 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2445 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2447 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2449 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2450 (x_clipboard_manager_save): Add return value.
2451 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2453 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2454 Obey Vx_select_enable_clipboard_manager. Catch errors in
2455 x_clipboard_manager_save (Bug#8779).
2456 (Vx_select_enable_clipboard_manager): New variable.
2457 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2459 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2461 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2463 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2465 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2466 in the current matrix if keep_current_p is non-zero.
2468 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2470 * bidi.c (bidi_level_of_next_char): Fix last change.
2472 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2474 Support bidi reordering of text covered by display properties.
2476 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2477 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2478 (bidi_cache_search, bidi_cache_iterator_state)
2479 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2480 (bidi_level_of_next_char, bidi_move_to_visually_next):
2481 Support character positions inside a run of characters covered by a
2483 (bidi_paragraph_init, bidi_resolve_explicit_1)
2484 (bidi_level_of_next_char): Call bidi_fetch_char and
2485 bidi_fetch_char_advance instead of FETCH_CHAR and
2487 (bidi_init_it): Initialize new members.
2488 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2490 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2491 instead of using explicit *_CHAR codes.
2492 (bidi_resolve_explicit, bidi_resolve_weak):
2493 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2494 bidirectional text is supported only in multibyte buffers.
2495 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2496 it to initialize the frame_window_p member of struct bidi_it.
2497 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2498 (bidi_resolve_explicit, bidi_resolve_weak)
2499 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2500 bidi_it->nchars is non-positive.
2501 (bidi_level_of_next_char): Don't try to lookup the cache for the
2502 next/previous character if nothing is cached there yet, or if we
2503 were just reseat()'ed to a new position.
2505 * xdisp.c (set_cursor_from_row): Set start and stop points
2506 according to the row's direction when priming the loop that looks
2507 for the glyph on which to display cursor.
2508 (single_display_spec_intangible_p): Function deleted.
2509 (display_prop_intangible_p): Reimplement to call
2510 handle_display_spec instead of single_display_spec_intangible_p.
2511 Accept 3 additional arguments needed by handle_display_spec.
2512 This fixes incorrect cursor motion across display property with complex
2513 values: lists, `(when COND...)' forms, etc.
2514 (single_display_spec_string_p): Support property values that are
2515 lists with the argument STRING its top-level element.
2516 (display_prop_string_p): Fix the condition for processing a
2517 property that is a list to be consistent with handle_display_spec.
2518 (handle_display_spec): New function, refactored from the
2519 last portion of handle_display_prop.
2520 (compute_display_string_pos): Accept additional argument
2521 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2522 value of a `display' property is a "replacing spec".
2523 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2524 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2525 the display property, but just return a value indicating whether
2526 the display property will replace the characters it covers.
2527 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2528 frame_window_p members of struct bidi_it.
2529 (compute_display_string_pos, compute_display_string_end):
2531 (push_it): Accept second argument POSITION, where pop_it should
2532 jump to continue iteration.
2533 (reseat_1): Initialize bidi_it.disp_pos.
2535 * keyboard.c (adjust_point_for_property): Adjust the call to
2536 display_prop_intangible_p to its new signature.
2538 * dispextern.h (struct bidi_it): New member frame_window_p.
2539 (bidi_init_it): Update prototypes.
2540 (display_prop_intangible_p): Update prototype.
2541 (compute_display_string_pos, compute_display_string_end):
2543 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2546 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2548 Malloc failure behavior now depends on size of allocation.
2549 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2550 * lisp.h: Change signatures accordingly.
2551 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2552 All callers changed. (Bug#8762)
2554 * gnutls.c: Use Emacs's memory allocators.
2555 Without this change, the gnutls library would invoke malloc etc.
2556 directly, which causes problems on non-SYNC_INPUT hosts, and which
2557 runs afoul of improving memory_full behavior. (Bug#8761)
2558 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2559 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2560 xfree instead of the default malloc, realloc, free.
2561 (Fgnutls_boot): No need to check for memory allocation failure,
2562 since xmalloc does that for us.
2564 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2565 * category.c (hash_get_category_set):
2566 * ccl.c (ccl_driver):
2567 * charset.c (Fdefine_charset_internal):
2568 * charset.h (struct charset.hash_index):
2569 * composite.c (get_composition_id, gstring_lookup_cache)
2570 (composition_gstring_put_cache):
2571 * composite.h (struct composition.hash_index):
2572 * dispextern.h (struct image.hash):
2573 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2574 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2575 (hashfn_equal, hashfn_user_defined, make_hash_table)
2576 (maybe_resize_hash_table, hash_lookup, hash_put)
2577 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2578 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2579 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2580 * image.c (make_image, search_image_cache, lookup_image)
2581 (xpm_put_color_table_h):
2582 * lisp.h (struct Lisp_Hash_Table):
2583 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2584 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2585 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2586 * alloc.c (allocate_vectorlike):
2587 Check for overflow in vector size calculations.
2588 * ccl.c (ccl_driver):
2589 Check for overflow when converting EMACS_INT to int.
2590 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2591 need to be updated by these changes.
2592 * fns.c (make_hash_table, maybe_resize_hash_table):
2593 Check for integer overflow with large hash tables.
2594 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2595 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2596 (SXHASH_REDUCE): New macro.
2597 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2598 Use it instead of discarding useful hash info with large hash values.
2599 (sxhash_float): New function.
2600 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2601 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2602 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2603 Rewrite to use FIXNUM_BITS, as this simplifies things.
2604 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2605 Adjust signatures to match updated version of code.
2606 (consing_since_gc): Now EMACS_INT, since a single hash table can
2607 use more than INT_MAX bytes.
2609 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2611 Make it possible to build with GCC-4.6+ -O2 -flto.
2613 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2615 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2617 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2618 Call minibuffer-inactive-mode.
2620 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2622 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2623 Update dependencies.
2625 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2627 * data.c (init_data): Remove code for UTS, this system is not
2630 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2632 Don't force ./temacs to start in terminal mode.
2634 * frame.c (make_initial_frame): Initialize faces in all cases, not
2635 only when CANNOT_DUMP is defined.
2636 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2638 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2640 * dispnew.c (add_window_display_history): Use const for the string
2641 pointer. Remove declaration, not needed.
2643 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2645 Use 'inline', not 'INLINE'.
2646 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2647 * alloc.c, fontset.c (INLINE): Remove.
2648 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2649 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2650 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2651 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2652 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2654 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2656 Make it possible to run ./temacs.
2658 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2659 syms_of_callproc does the same thing. Remove test for
2660 "initialized", do it in the caller.
2661 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2663 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2665 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2666 (read_minibuf): Use get_minibuffer.
2667 (syms_of_minibuf): Use DEFSYM.
2668 (Qmetadata): New var.
2669 * data.c (Qbuffer): Don't make it static.
2670 (syms_of_data): Use DEFSYM.
2672 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2674 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2675 (CCL_CODE_MIN): New macro.
2677 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2679 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2681 * eval.c (Qdebug): Now static.
2682 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2683 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2684 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2686 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2688 * image.c: Various fixes to ImageMagick code comments.
2689 (Fimagemagick_types): Doc fix.
2691 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2693 Minor fixes prompted by GCC 4.6.0 warnings.
2695 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2697 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2698 (x_clipboard_manager_save_all): Move extern decl to ...
2699 * xterm.h: ... here, so that it can be checked for consistency.
2701 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2703 * xselect.c (x_clipboard_manager_save_frame)
2704 (x_clipboard_manager_save_all): New functions.
2705 (Fx_clipboard_manager_save): Lisp function deleted.
2707 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2708 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2710 * xterm.h: Update prototype.
2712 2011-05-28 William Xu <william.xwl@gmail.com>
2714 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2717 2011-05-28 Jim Meyering <meyering@redhat.com>
2719 Avoid a sign-extension bug in crypto_hash_function.
2720 * fns.c (to_uchar): Define.
2721 (crypto_hash_function): Use it to convert some newly-signed
2722 variables to unsigned, to avoid sign-extension bugs. For example,
2723 without this change, (md5 "truc") would evaluate to
2724 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2725 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2726 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2728 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2730 Integer overflow fixes.
2732 * dbusbind.c: Serial number integer overflow fixes.
2733 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2734 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2735 to hold a serial number that is too large for a fixnum.
2736 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2737 Check for serial numbers out of range. Decode any serial number
2738 that was so large that it became a float. (Bug#8722)
2740 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2741 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2742 Use XFASTINT rather than XUINT when numbers are nonnegative.
2743 (xd_append_arg, Fdbus_method_return_internal):
2744 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2745 arguments, check that Lisp number is nonnegative, rather than
2746 silently wrapping negative numbers around. (Bug#8722)
2747 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2750 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2752 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2754 ccl: add integer overflow checks
2755 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2756 (IN_INT_RANGE): New macros.
2757 (ccl_driver): Use them to check for integer overflow when
2758 decoding a CCL program. Many of the new checks are whether XINT (x)
2759 fits in int; it doesn't always, on 64-bit hosts. The new version
2760 doesn't catch all possible integer overflows, but it's an
2761 improvement. (Bug#8719)
2763 * alloc.c (make_event_array): Use XINT, not XUINT.
2764 There's no need for unsigned here.
2766 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2767 This follows up to the 2011-05-06 change that substituted uintptr_t
2768 for EMACS_INT. This case wasn't caught back then.
2770 Rework Fformat to avoid integer overflow issues.
2771 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2772 now (part of C89). Include <verify.h>.
2773 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2774 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2775 (Fformat): Avoid the prepass trying to compute sizes; it was only
2776 approximate and thus did not catch overflow reliably. Instead, walk
2777 through the format just once, formatting and computing sizes as we go,
2778 checking for integer overflow at every step, and allocating a larger
2779 buffer as needed. Keep track separately whether the format is
2780 multibyte. Keep only the most-recently calculated precision, rather
2781 than them all. Record whether each argument has been converted to
2782 string. Use EMACS_INT, not int, for byte and char and arg counts.
2783 Support field widths and precisions larger than INT_MAX. Avoid
2784 sprintf's undefined behavior with conversion specifications such as %#d
2785 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2786 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2787 formatting out-of-range floating point numbers with int
2790 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2792 * data.c: Avoid integer truncation in expressions involving floats.
2793 * data.c: Include <intprops.h>.
2794 (arith_driver): When there's an integer overflow in an expression
2795 involving floating point, convert the integers to floating point
2796 so that the resulting value does not suffer from catastrophic
2797 integer truncation. For example, on a 64-bit host (* 4
2798 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2799 Do not rely on undefined behavior after integer overflow.
2801 merge count_size_as_multibyte, parse_str_to_multibyte
2802 * character.c, character.h (count_size_as_multibyte):
2803 Rename from parse_str_to_multibyte; all uses changed.
2804 Check for integer overflow.
2805 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2806 since it's now a duplicate of the other. This is more of
2807 a character than a buffer op, so better that it's in character.c.
2808 * fns.c, print.c: Adjust to above changes.
2810 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2812 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2814 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2816 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2817 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2818 (x_clipboard_manager_save): Now static.
2819 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2821 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2822 (crypto_hash_function): Now static.
2823 Fix pointer signedness problems. Avoid unnecessary initializations.
2825 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2827 * termhooks.h (Vselection_alist): Make it terminal-local.
2829 * terminal.c (create_terminal): Initialize it.
2831 * xselect.c: Support for clipboard managers.
2832 (Vselection_alist): Move to termhooks.h as terminal-local var.
2833 (LOCAL_SELECTION): New macro.
2834 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2835 (symbol_to_x_atom): Remove gratuitous arg.
2836 (x_handle_selection_request, lisp_data_to_selection_data)
2837 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2838 (x_own_selection, x_get_local_selection, x_convert_selection):
2839 New arg, specifying work frame. Use terminal-local Vselection_alist.
2840 (some_frame_on_display): Delete unused function.
2841 (Fx_own_selection_internal, Fx_get_selection_internal)
2842 (Fx_disown_selection_internal, Fx_selection_owner_p)
2843 (Fx_selection_exists_p): New optional frame arg.
2844 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2845 (x_handle_selection_clear): Don't treat other terminals with the
2846 same keyboard specially. Use the terminal-local Vselection_alist.
2847 (x_clear_frame_selections): Use Frun_hook_with_args.
2849 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2851 * xterm.h: Add support for those atoms.
2853 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2855 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2856 (converted_selections, conversion_fail_tag): New global variables.
2857 (x_selection_request_lisp_error): Free the above.
2858 (x_get_local_selection): Remove unnecessary code.
2859 (x_reply_selection_request): Args changed; handle arbitrary array
2860 of converted selections stored in converted_selections.
2861 Separate the XChangeProperty and SelectionNotify steps.
2862 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2863 (x_convert_selection): New function.
2864 (x_handle_selection_event): Simplify.
2865 (x_get_foreign_selection): Don't ignore incoming requests while
2866 waiting for an answer; this will fail when we implement
2867 SAVE_TARGETS, and seems unnecessary anyway.
2868 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2869 (Vx_sent_selection_functions): Doc fix.
2871 2011-05-26 Leo Liu <sdl.web@gmail.com>
2873 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2875 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2877 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2879 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2880 for fringe update if it has periodic bitmap.
2881 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2882 and fringe_bitmap_periodic_p.
2884 * fringe.c (get_fringe_bitmap_data): New function.
2885 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2886 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2887 row. Mark glyph row for fringe update if periodicity changed.
2889 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2890 for fringe update unless it has periodic bitmap.
2892 2011-05-25 Kenichi Handa <handa@m17n.org>
2894 * xdisp.c (get_next_display_element): Set correct it->face_id for
2895 a static composition.
2897 2011-05-24 Leo Liu <sdl.web@gmail.com>
2900 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2902 * fns.c (crypto_hash_function, Fsha1): New function.
2903 (Fmd5): Use crypto_hash_function.
2904 (syms_of_fns): Add Ssha1.
2906 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2908 * gnutls.c: Remove unused macros.
2909 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2910 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2911 Remove macros that are defined and never used.
2912 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2914 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2916 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2917 (Fx_get_selection_internal): Minor cleanup.
2918 (Fx_own_selection_internal): Rename arguments for consistency with
2921 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2923 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2925 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2927 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2929 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2931 * dispnew.c (scrolling_window): Don't exclude the case that the
2932 last enabled row in the desired matrix touches the bottom boundary.
2934 2011-05-21 Glenn Morris <rgm@gnu.org>
2936 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2937 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2938 and add some more files.
2940 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2942 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2943 report_file_error introduced by the change from 2011-05-07.
2945 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2947 * systime.h (Time): Define only if emacs is defined.
2948 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2949 where the include path doesn't have X11/X.h by default. See
2950 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2952 2011-05-20 Kenichi Handa <handa@m17n.org>
2954 * composite.c (find_automatic_composition): Fix previous change.
2956 2011-05-20 Glenn Morris <rgm@gnu.org>
2958 * lisp.mk: New file, split from Makefile.in.
2959 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2960 (shortlisp): Remove.
2961 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2963 2011-05-19 Glenn Morris <rgm@gnu.org>
2965 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2966 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2967 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2968 (lisp): Set the order to that of loadup.el.
2969 (shortlisp): Make it a copy of $lisp.
2970 (SOME_MACHINE_LISP): Remove.
2971 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2972 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2974 2011-05-18 Kenichi Handa <handa@m17n.org>
2976 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2977 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2978 (find_automatic_composition): Mostly rewrite for efficiency.
2980 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2982 * makefile.w32-in: Update dependencies.
2984 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2986 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2987 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2989 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2991 Fix some integer overflow issues, such as string length overflow.
2993 * insdel.c (count_size_as_multibyte): Check for string overflow.
2995 * character.c (lisp_string_width): Check for string overflow.
2996 Use EMACS_INT, not int, for string indexes and lengths; in
2997 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2998 the resulting string length overflows an EMACS_INT; instead,
2999 report a string overflow if no precision given. When checking for
3000 precision exhaustion, use a check that cannot possibly have
3001 integer overflow. (Bug#8675)
3002 * character.h (lisp_string_width): Adjust to new signature.
3004 * alloc.c (string_overflow): New function.
3005 (Fmake_string): Use it. This doesn't change behavior, but saves
3006 a few bytes and will simplify future changes.
3007 * character.c (string_escape_byte8): Likewise.
3008 * lisp.h (string_overflow): New decl.
3010 Fixups, following up to the user-interface timestamp change.
3011 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3012 for UI timestamps, instead of unsigned long.
3013 * msdos.c (mouse_get_pos): Likewise.
3014 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3015 * w32gui.h (Time): Define by including "systime.h" rather than by
3016 declaring it ourselves. (Bug#8664)
3018 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3019 * image.c (clear_image_cache): Likewise.
3021 * term.c (term_mouse_position): Don't assume time_t wraparound.
3023 Be more systematic about user-interface timestamps.
3024 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3025 and sometimes 'EMACS_UINT', to represent these timestamps.
3026 This change causes it to use 'Time' uniformly, as that's what X uses.
3027 This makes the code easier to follow, and makes it easier to catch
3028 integer overflow bugs such as Bug#8664.
3029 * frame.c (Fmouse_position, Fmouse_pixel_position):
3030 Use Time, not unsigned long, for user-interface timestamps.
3031 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3032 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3033 * keyboard.h (last_event_timestamp): Likewise.
3034 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3035 * menu.h (xmenu_show): Likewise.
3036 * term.c (term_mouse_position): Likewise.
3037 * termhooks.h (struct input_event.timestamp): Likewise.
3038 (struct terminal.mouse_position_hook): Likewise.
3039 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3040 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3041 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3042 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3044 * menu.h, termhooks.h: Include "systime.h", for Time.
3046 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3047 Don't assume that the difference between two unsigned long values
3048 can fit into an integer. At this point, we know button_down_time
3049 <= event->timestamp, so the difference must be nonnegative, so
3050 there's no need to cast the result if double-click-time is
3051 nonnegative, as it should be; check that it's nonnegative, just in
3052 case. This bug is triggered when events are more than 2**31 ms
3053 apart (about 25 days). (Bug#8664)
3055 * xselect.c (last_event_timestamp): Remove duplicate decl.
3056 (x_own_selection): Remove needless cast to unsigned long.
3058 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3059 that always fit in int. Use a sentinel instead of a counter, to
3060 avoid a temp and to allay GCC's concerns about possible int overflow.
3061 * frame.h (struct frame): Use int for menu_bar_items_used
3062 instead of EMACS_INT, since it always fits in int.
3064 * menu.c (grow_menu_items): Check for int overflow.
3066 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3068 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3069 Before, the code was not consistent. These values cannot exceed
3070 2**31 - 1 so there's no need to make them unsigned.
3071 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3072 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3073 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3075 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3077 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3078 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3079 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3080 presumably because the widths might not match.
3082 * window.c (size_window): Avoid needless test at loop start.
3084 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3086 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3088 2011-05-12 Drew Adams <drew.adams@oracle.com>
3090 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3092 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3094 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3095 `width' to `bar_area_x' and `bar_area_width', respectively.
3096 (x_scroll_run): Take account of fringe background extension.
3098 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3099 Rename local vars `left' and `width' to `bar_area_x' and
3100 `bar_area_width', respectively.
3101 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3102 background extension.
3104 2011-05-10 Jim Meyering <meyering@redhat.com>
3106 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3108 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3110 * image.c (Finit_image_library): Return t for built-in image types,
3111 like pbm and xbm. (Bug#8640)
3113 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3115 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3117 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3119 * w32console.c (Fset_screen_color): Doc fix.
3120 (Fget_screen_color): New function.
3121 (syms_of_ntterm): Defsubr it.
3123 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3124 unlink the temporary file if Fcall_process didn't create it in the
3126 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3127 child process will be redirected to a file specified with `:file'.
3128 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3129 cue to call_process_cleanup not to close that handle.
3131 2011-05-07 Ben Key <bkey76@gmail.com>
3133 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3134 one of two shell specific rules, either bootstrap-temacs-CMD or
3135 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3136 to the previous implementation of the bootstrap-temacs rule.
3137 The bootstrap-temacs-CMD rule is similar to the previous
3138 implementation of the bootstrap-temacs rule except that it
3139 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3142 These changes, along with some changes to nt/configure.bat,
3143 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3144 earlier fix to add support for --cflags and --ldflags options
3145 that include quotes so that it works whether make uses cmd or
3148 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3150 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3151 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3153 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3154 a string. Handle both cases.
3155 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3156 (Fdbus_register_method): Use Qinvalid_function.
3158 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3160 * makefile.w32-in: Update dependencies.
3161 (LISP_H): Add inttypes.h and stdin.h.
3162 (PROCESS_H): Add unistd.h.
3164 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3166 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3167 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3169 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3171 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3173 * term.c (vfatal): Remove stray call to va_end.
3174 It's not needed and the C Standard doesn't allow it here anyway.
3176 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3177 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3179 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3182 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3184 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3186 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3188 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3190 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3192 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3193 * charset.c (Fdefine_charset_internal): Don't initialize
3194 charset.code_space[15]. The value was garbage, on hosts with
3195 32-bit int (Bug#8600).
3197 * lread.c (read_integer): Be more consistent with string-to-number.
3198 Use string_to_number to do the actual conversion; this avoids
3199 rounding errors and fixes some other screwups. Without this fix,
3200 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3201 (digit_to_number): Move earlier, for benefit of read_integer.
3202 Return -1 if the digit is out of range for the base, -2 if it is
3203 not a digit in any supported base. (Bug#8602)
3205 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3207 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3208 to match comment at start of function. This also removes a
3209 GCC warning about overflow in a 32+64-bit port.
3211 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3213 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3214 Reported by Stefan Monnier in
3215 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3216 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3217 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3219 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3220 (EMACS_UINTPTR): Likewise, with uintptr_t.
3222 * lisp.h: Prefer 64-bit EMACS_INT if available.
3223 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3224 on 32-bit hosts that have 64-bit int, so that they can access
3226 However, temporarily disable this change unless the temporary
3227 symbol WIDE_EMACS_INT is defined.
3229 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3231 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3232 This removes an assumption that EMACS_INT and long are the same
3233 width as pointers. The assumption is true for Emacs porting targets
3234 now, but we want to make other targets possible.
3235 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3236 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3237 In the rest of the code, change types of integers that hold casted
3238 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3239 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3240 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3241 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3242 No need to cast type when ORing.
3243 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3244 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3245 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3246 assume EMACS_INT is the same width as char *.
3247 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3248 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3249 Remove no-longer-needed casts.
3250 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3251 (xg_tool_bar_help_callback, xg_make_tool_item):
3252 Use EMACS_INTPTR to hold an integer
3253 that will be cast to void *; this can avoid a GCC warning
3254 if EMACS_INT is not the same width as void *.
3255 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3256 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3257 (current_message_1, set_message_1):
3258 Use a local to convert to proper width without a cast.
3259 * xmenu.c (dialog_selection_callback): Likewise.
3261 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3262 Also, don't assume VALBITS / RAND_BITS is less than 5,
3263 and don't rely on undefined behavior when shifting a 1 left into
3265 * lisp.h (get_random): Change signature to match.
3267 * lread.c (hash_string): Use size_t, not int, for hash computation.
3268 Normally we prefer signed values; but hashing is special, because
3269 it's better to use unsigned division on hash table sizes so that
3270 the remainder is nonnegative. Also, size_t is the natural width
3271 for hashing into memory. The previous code used 'int', which doesn't
3272 retain enough info to hash well into very large tables.
3273 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3275 * dbusbind.c: Don't possibly lose pointer info when converting.
3276 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3277 Use XPNTR rather than XHASH, so that the high-order bits of
3278 the pointer aren't lost when converting through void *.
3280 * eval.c (Fautoload): Don't double-shift a pointer.
3282 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3284 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3286 * gnutls.c (DEF_GNUTLS_FN):
3287 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3289 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3291 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3294 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3296 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3297 New version that can reserve upto 2GB of heap space.
3299 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3301 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3303 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3305 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3306 `gnutls_certificate_set_x509_key_file'.
3308 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3310 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3311 Update dependencies.
3313 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3315 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3316 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3317 Remove unused parameter `fildes'.
3318 * process.c (read_process_output, send_process): Don't pass it.
3320 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3322 Fix previous change: the library cache is defined in w32.c.
3323 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3324 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3326 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3328 Implement dynamic loading of GnuTLS on Windows.
3330 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3331 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3332 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3335 * gnutls.c (Qgnutls_dll): Define.
3336 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3337 (gnutls_*): Declare function pointers.
3338 (init_gnutls_functions): New function to initialize function pointers.
3339 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3340 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3341 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3342 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3343 (emacs_gnutls_write, emacs_gnutls_read)
3344 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3345 (Fgnutls_available_p): New function.
3346 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3347 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3348 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3350 * image.c: Include w32.h.
3351 (Vimage_type_cache): Delete.
3352 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3353 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3354 (w32_delayed_load): Move to w32.c.
3356 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3358 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3359 (w32_delayed_load): Move from image.c. When loading a library, record
3360 its filename in the :loaded-from property of the library id.
3361 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3362 Initialize and staticpro them.
3363 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3365 * process.c: Include lisp.h before w32.h, not after.
3366 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3367 instead of gnutls_record_check_pending.
3369 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3371 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3373 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3374 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3377 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3379 * xterm.c (x_set_frame_alpha): Do not set property on anything
3380 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3382 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3384 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3386 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3388 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3389 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3390 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3391 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3392 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3393 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3394 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3395 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3396 (Qgnutls_bootprop_callbacks_verify): Make static.
3398 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3400 * callproc.c: Indentation fixup.
3402 * sysdep.c (wait_for_termination_1): Make static.
3403 (wait_for_termination, interruptible_wait_for_termination):
3404 Move after wait_for_termination_1.
3406 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3408 * sysdep.c (interruptible_wait_for_termination): New function
3409 which is like wait_for_termination, but allows keyboard
3412 * callproc.c (Fcall_process): Add (:file "file") as an option for
3414 (Fcall_process_region): Ditto.
3416 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3418 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3419 rather than `XVECTOR (FOO)->size'.
3421 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3422 inttypes.h, as a gnulib replacement is used if it not available in
3425 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3427 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3428 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3429 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3431 * coding.c (coding_alloc_by_realloc): Error out if destination
3432 will grow beyond MOST_POSITIVE_FIXNUM.
3433 (decode_coding_emacs_mule): Abort if there isn't enough place in
3434 charbuf for the composition carryover bytes. Reserve an extra
3435 space for up to 2 characters produced in a loop.
3436 (decode_coding_iso_2022): Abort if there isn't enough place in
3437 charbuf for the composition carryover bytes.
3439 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3441 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3442 aborting when %lld or %lll format is passed.
3443 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3444 %llo or %llx format is passed. (Bug#8545)
3446 * window.c (window_scroll_line_based): Use a marker instead of
3447 simple variables to record original value of point. (Bug#7952)
3449 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3450 produced by %s or %c overflows available buffer space. (Bug#8545)
3452 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3454 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3455 (SIZE_MAX): Move defn after all includes, as they might #define it.
3457 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3459 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3461 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3463 * keyboard.c (Qdelayed_warnings_hook): Define.
3464 (command_loop_1): Run `delayed-warnings-hook'
3465 if Vdelayed_warnings_list is non-nil.
3466 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3467 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3469 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3471 * doprnt.c (doprnt): Don't return value smaller than the buffer
3472 size if the message was truncated. (Bug#8545).
3474 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3476 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3477 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3479 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3481 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3483 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3485 * makefile.w32-in: Update dependencies.
3487 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3489 Improve `doprnt' and its usage. (Bug#8545)
3490 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3491 `format_end'. Remove support for %l as a conversion specifier.
3492 Don't use xrealloc. Improve diagnostics when the %l size modifier
3493 is used. Update the commentary.
3495 * eval.c (verror): Simplify calculation of size_t.
3497 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3500 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3502 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3505 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3507 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3508 This makes this file independent of the recent pseudovector change.
3510 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3512 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3514 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3515 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3516 Remove unused local.
3517 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3519 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3520 GCC 4.6.0 optimizes based on type-based alias analysis.
3521 For example, if b is of type struct buffer * and v of type struct
3522 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3523 != &v->size, and therefore "v->size = 1; b->size = 2; return
3524 v->size;" must therefore return 1. This assumption is incorrect
3525 for Emacs, since it type-puns struct Lisp_Vector * with many other
3526 types. To fix this problem, this patch adds a new type struct
3527 vectorlike_header that documents the constraints on layout of vectors
3528 and pseudovectors, and helps optimizing compilers not get fooled
3529 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3530 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3531 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3533 (XSETPVECTYPE): Rewrite in terms of new macro.
3534 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3535 This is a bit clearer, and further avoids the possibility of
3536 undesirable aliasing.
3537 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3538 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3539 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3540 since Lisp_Subr is a special case (no "next" field).
3541 (ASIZE): Now uses header.size rather than size.
3542 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3543 to avoid the hassle of writing XVECTOR (foo)->header.size.
3544 (struct vectorlike_header): New type.
3545 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3546 object, to help avoid aliasing.
3547 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3548 (SUBRP): Likewise, since Lisp_Subr is a special case.
3549 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3550 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3551 (struct Lisp_Hash_Table): Combine first two members into a single
3552 struct vectorlike_header member. All uses of "size" and "next" members
3553 changed to be "header.size" and "header.next".
3554 * buffer.h (struct buffer): Likewise.
3555 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3556 * frame.h (struct frame): Likewise.
3557 * process.h (struct Lisp_Process): Likewise.
3558 * termhooks.h (struct terminal): Likewise.
3559 * window.c (struct save_window_data, struct saved_window): Likewise.
3560 * window.h (struct window): Likewise.
3561 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3562 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3563 * buffer.c (init_buffer_once): Likewise.
3564 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3566 * process.c (Fformat_network_address): Use local var for size,
3569 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3571 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3572 * data.c (atof): Remove decl; no longer used or needed.
3573 (digit_to_number): Move to lread.c.
3574 (Fstring_to_number): Use new string_to_number function, to be
3575 consistent with how the Lisp reader treats infinities and NaNs.
3576 Do not assume that floating-point numbers represent EMACS_INT
3577 without losing information; this is not true on most 64-bit hosts.
3578 Avoid double-rounding errors, by insisting on integers when
3579 parsing non-base-10 numbers, as the documentation specifies.
3580 * lisp.h (string_to_number): New decl, replacing ...
3581 (isfloat_string): Remove.
3582 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3583 (read1): Do not accept +. and -. as integers; this
3584 appears to have been a coding error. Similarly, do not accept
3585 strings like +-1e0 as floating point numbers. Do not report
3586 overflow for integer overflows unless the base is not 10 which
3587 means we have no simple and reliable way to continue.
3588 Break out the floating-point parsing into a new
3589 function string_to_number, so that Fstring_to_number parses
3590 floating point numbers consistently with the Lisp reader.
3591 (digit_to_number): Move here from data.c. Make it static inline.
3592 (E_CHAR, EXP_INT): Remove, replacing with ...
3593 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3594 (string_to_number): New function, replacing isfloat_string.
3595 This function checks for valid syntax and produces the resulting
3596 Lisp float number too. Rework it so that string-to-number
3597 no longer mishandles examples like "1.0e+". Use strtoumax,
3598 so that overflow for non-base-10 numbers is reported only when
3599 there's no portable and simple way to convert to floating point.
3601 * textprop.c (set_text_properties_1): Rewrite for clarity,
3602 and to avoid GCC warning about integer overflow.
3604 * intervals.h (struct interval): Use EMACS_INT for members
3605 where EMACS_UINT might cause problems. See
3606 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3607 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3608 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3610 (offset_intervals): Tell GCC not to worry about length overflow
3611 when negating a negative length.
3613 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3614 (overrun_check_free): Likewise.
3616 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3617 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3620 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3621 (gnutls_make_error): Rename local to avoid shadowing.
3622 (gnutls_emacs_global_deinit): ifdef out; not used.
3623 (Fgnutls_boot): Use const for pointer to readonly storage.
3624 Comment out unused local. Fix pointer signedness problems.
3626 * lread.c (openp): Don't stuff size_t into an 'int'.
3627 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3628 about possible signed overflow.
3630 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3631 (GDK_KEY_g): Don't define if already defined.
3632 (xg_prepare_tooltip): Avoid pointer signedness problem.
3633 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3635 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3636 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3638 * xfns.c (Fx_window_property): Simplify a bit,
3639 to make a bit faster and to avoid GCC 4.6.0 warning.
3640 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3642 * fns.c (internal_equal): Don't assume size_t fits in int.
3644 * alloc.c (compact_small_strings): Tighten assertion a little.
3646 Replace pEd with more-general pI, and fix some printf arg casts.
3647 * lisp.h (pI): New macro, generalizing old pEd macro to other
3648 conversion specifiers. For example, use "...%"pI"d..." rather
3649 than "...%"pEd"...".
3650 (pEd): Remove. All uses replaced with similar uses of pI.
3651 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3652 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3653 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3654 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3655 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3656 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3657 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3659 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3660 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3661 * print.c (safe_debug_print, print_object): Likewise.
3662 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3664 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3665 avoiding the 0 flag, which is not portable.
3666 * process.c (Fmake_network_process): Use pI to avoid cast.
3667 * region-cache.c (pp_cache): Likewise.
3668 * xdisp.c (decode_mode_spec): Likewise.
3669 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3670 behavior on 64-bit hosts with printf arg.
3671 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3672 (x_stop_queuing_selection_requests): Likewise.
3673 (x_get_window_property): Don't truncate byte count to an 'int'
3676 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3677 here, since it parses constructs like leading '-' and spaces,
3678 which are not wanted; and it overflows with large numbers.
3679 Instead, simply match F[0-9]+, which is what is wanted anyway.
3681 * alloc.c: Remove unportable assumptions about struct layout.
3682 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3683 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3684 (allocate_vectorlike, make_pure_vector): Use the new macros,
3685 plus offsetof, to remove unportable assumptions about struct layout.
3686 These assumptions hold on all porting targets that I know of, but
3687 they are not guaranteed, they're easy to remove, and removing them
3688 makes further changes easier.
3690 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3691 This doesn't fix a bug but makes the code clearer.
3692 (string_overrun_cookie): Now const. Use initializers that
3693 don't formally overflow signed char, to avoid warnings.
3694 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3695 can cause Emacs to crash when string overrun checking is enabled.
3696 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3697 multiple of sizeof (EMACS_INT); it need not be, if
3698 alignof(EMACS_INT) < sizeof (EMACS_INT).
3699 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3701 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3703 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3705 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3707 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3708 supposed to be handshaking. (Bug#8556)
3709 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3711 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3713 * lisp.h (Qdebug): List symbol.
3714 * eval.c (Qdebug): Restore global linkage.
3715 * keyboard.c (debug-on-event): New variable.
3716 (handle_user_signal): Break into debugger when debug-on-event
3717 matches the current signal symbol.
3719 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3721 * alloc.c (check_sblock, check_string_bytes)
3722 (check_string_free_list): Convert to standard C.
3724 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3726 * w32.c (emacs_gnutls_push): Fix typo.
3728 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3730 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3731 "cast to pointer from integer of different size".
3733 Improve doprnt and its use in verror. (Bug#8545)
3734 * doprnt.c (doprnt): Document the set of format control sequences
3735 supported by the function. Use SAFE_ALLOCA instead of always
3738 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3739 is one byte too soon. Don't use xrealloc; instead xfree and
3742 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3744 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3747 * gnutls.c: Renamed global_initialized to
3748 gnutls_global_initialized. Added internals for the
3749 :verify-hostname-error, :verify-error, and :verify-flags
3750 parameters of `gnutls-boot' and documented those parameters in the
3751 docstring. Start callback support.
3752 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3753 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3754 on error. Return error code.
3755 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3756 (emacs_gnutls_read): Likewise.
3757 (Fgnutls_boot): Return handshake error code.
3758 (emacs_gnutls_handle_error): New function.
3759 (wsaerror_to_errno): Likewise.
3761 * w32.h (emacs_gnutls_pull): Add prototype.
3762 (emacs_gnutls_push): Likewise.
3764 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3765 (emacs_gnutls_push): Likewise.
3767 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3769 * process.c (wait_reading_process_output): Check if GnuTLS
3770 buffered some data internally if no FDs are set for TLS
3773 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3774 (LIBS): Link to USER_LIBS.
3775 ($(BLD)/gnutls.$(0)): New target.
3777 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3779 * xdisp.c (handle_single_display_spec): Rename the
3780 display_replaced_before_p argument into display_replaced_p, to
3781 make it consistent with the commentary. Fix typos in the
3784 * textprop.c (syms_of_textprop): Remove dead code.
3785 (copy_text_properties): Delete obsolete commentary about an
3786 interface that was deleted long ago. Fix typos in the description
3789 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3790 to changes in oldXMenu/XMenu.h from 2011-04-16.
3791 <menu_help_message, prev_menu_help_message>: Constify.
3792 (IT_menu_make_room): menu->help_text is now `const char **';
3795 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3796 to changes in oldXMenu/XMenu.h from 2011-04-16.
3797 (struct XMenu): Declare `help_text' `const char **'.
3799 * xfaces.c <Qunspecified>: Make extern again.
3801 * syntax.c: Include sys/types.h before including regex.h, as
3804 * doc.c (get_doc_string): Improve the format passed to `error'.
3806 * doprnt.c (doprnt): Improve commentary.
3808 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3810 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3813 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3814 changes in globals.h immediately force recompilation.
3815 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3816 $(CURDIR)/s/ms-w32.h.
3817 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3819 * character.c (Fchar_direction): Function deleted.
3820 (syms_of_character): Don't defsubr it.
3821 <char-direction-table>: Deleted.
3823 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3825 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3826 * doprnt.c: Include limits.h.
3827 (SIZE_MAX): New macro.
3828 (doprnt): Return a size_t value. 2nd arg is now size_t.
3829 Many local variables are now size_t instead of int or unsigned.
3830 Improve overflow protection. Support `l' modifier for integer
3831 conversions. Support %l conversion. Don't assume an EMACS_INT
3832 argument for integer conversions and for %c.
3834 * lisp.h (doprnt): Restore prototype.
3836 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3839 * Makefile.in (base_obj): Add back doprnt.o.
3841 * deps.mk (doprnt.o): Add back prerequisites.
3842 (callint.o): Depend on character.h.
3844 * eval.c (internal_lisp_condition_case): Include the handler
3845 representation in the error message.
3846 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3847 when breaking from the loop.
3849 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3851 * callint.c (Fcall_interactively): When displaying error message
3852 about invalid control letter, pass the character's codepoint, not
3853 a pointer to its multibyte form. Improve display of the character
3854 in octal and display also its hex code.
3856 * character.c (char_string): Use %x to display the (unsigned)
3857 codepoint of an invalid character, to avoid displaying a bogus
3860 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3861 `error', not SYMBOL_NAME itself.
3863 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3864 character arguments to `error'.
3866 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3867 to `error' in error message about FINAL_CHAR argument. Make sure
3868 FINAL_CHAR is a character, and use %c when it is passed as
3869 argument to `error'.
3871 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3873 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3875 * w32.c: Include <time.h>.
3876 (sys_localtime): New function.
3878 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3880 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3882 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3884 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3886 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3889 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3891 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3892 gl_state.e_property when gl_state.object is Qt.
3894 * insdel.c (make_gap_larger): Remove limitation of buffer size
3897 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3899 * xdisp.c (lookup_glyphless_char_display)
3900 (produce_glyphless_glyph): Handle cons cell entry in
3901 glyphless-char-display.
3902 (Vglyphless_char_display): Document it.
3904 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3905 glyphless-char-display.
3907 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3909 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3911 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3913 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3914 definition for no-X builds.
3916 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3918 Static checks with GCC 4.6.0 and non-default toolkits.
3920 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3922 * process.c (keyboard_bit_set): Define only if SIGIO.
3923 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3924 (send_process): Repair possible setjmp clobbering.
3926 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3928 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3930 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3932 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3933 Define only if needed.
3935 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3936 by pacifying GCC about it. Maybe it's time to retire it?
3937 * xfaces.c (USG, __TIMEVAL__): Likewise.
3939 * dispextern.h (struct redisplay_interface): Rename param
3941 * termhooks.h (struct terminal): Likewise.
3942 * xterm.c (xembed_send_message): Likewise.
3944 * insdel.c (make_gap_smaller): Define only if
3945 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3947 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3950 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3951 so that we aren't warned about unused symbols.
3953 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3955 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3957 * xfns.c (x_real_positions): Mark locals as initialized.
3959 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3961 * xterm.c: Fix problems found by static analysis with other toolkits.
3962 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3963 (x_dispatch_event): Declare static if USE_GTK, and
3964 define if USE_GTK || USE_X_TOOLKIT.
3965 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3966 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3967 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3968 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3970 * xmenu.c (menu_help_callback): Pointer type fixes.
3971 Use const pointers when pointing at readonly data. Avoid pointer
3973 (FALSE): Remove unused macro.
3974 (update_frame_menubar): Remove unused decl.
3976 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3978 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3979 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3980 (single_menu_item): Rename local to avoid shadowing.
3982 * keyboard.c (make_lispy_event): Remove unused local var.
3984 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3985 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3987 * bitmaps: Change bitmaps from unsigned char back to the X11
3988 compatible char. Avoid the old compiler warnings about
3989 out-of-range initializers by using, for example, '\xab' rather
3992 * xgselect.c (xgselect_initialize): Check vs interface
3993 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3995 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3997 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3998 to read-only memory.
4000 * fns.c (vector): Remove; this old hack is no longer needed.
4002 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4004 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4006 * xrdb.c (x_load_resources): Omit unused local.
4008 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4009 (x_window): Rename locals to avoid shadowing.
4010 (USG): Use the kludged USG macro, to pacify gcc.
4012 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4013 (x_term_init): Remove local to avoid shadowing.
4015 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4017 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4018 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4020 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4022 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4024 Fix regex.c, syntax.c and friends for buffers > 2GB.
4025 * syntax.h (struct gl_state_s): Declare character position members
4028 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4030 * textprop.c (verify_interval_modification, interval_of):
4031 Declare arguments EMACS_INT.
4033 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4036 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4038 * indent.c (Fvertical_motion): Local variable it_start is now
4041 * regex.c (re_match, re_match_2, re_match_2_internal)
4042 (bcmp_translate, regcomp, regexec, print_double_string)
4043 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4044 (re_compile_pattern, re_exec): Declare arguments and local
4045 variables `size_t' and `ssize_t' and return values `regoff_t', as
4047 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4048 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4049 <compile_stack_type>: `size' and `avail' are now `size_t'.
4051 * regex.h <regoff_t>: Use ssize_t, not int.
4052 (re_search, re_search_2, re_match, re_match_2): Arguments that
4053 specify buffer/string position and length are now ssize_t and
4054 size_t. Return type is regoff_t.
4056 2011-04-16 Ben Key <bkey76@gmail.com>
4058 * nsfont.m: Fixed bugs in ns_get_family and
4059 ns_descriptor_to_entity that were caused by using free to
4060 deallocate memory blocks that were allocated by xmalloc (via
4061 xstrdup). This caused Emacs to crash when compiled with
4062 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4063 --enable-checking=xmallocoverrun). xfree is now used to
4064 deallocate these memory blocks.
4066 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4068 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4070 emacs_write: Accept and return EMACS_INT for sizes.
4071 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4073 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4074 Accept and return EMACS_INT.
4075 (emacs_gnutls_write): Return the number of bytes written on
4077 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4078 (emacs_read, emacs_write): Remove check for negative size, as the
4079 Emacs source code has been audited now.
4080 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4081 (emacs_read, emacs_write): Use it.
4082 * process.c (send_process): Adjust to the new signatures of
4083 emacs_write and emacs_gnutls_write. Do not attempt to store
4084 a byte offset into an 'int'; it might overflow.
4085 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4087 * sound.c: Don't assume sizes fit in 'int'.
4088 (struct sound_device.period_size, alsa_period_size):
4089 Return EMACS_INT, not int.
4090 (struct sound_device.write, vox_write, alsa_write):
4091 Accept EMACS_INT, not int.
4092 (wav_play, au_play): Use EMACS_INT to store sizes and to
4093 record read return values.
4095 2011-04-15 Ben Key <bkey76@gmail.com>
4097 * keyboard.c (Qundefined): Don't declare static since it is used
4099 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4100 static since they are used in nsfont.m.
4102 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4104 * process.c (Qprocessp): Don't declare static.
4105 * lisp.h (Qprocessp): Declare again.
4107 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4109 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4111 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4113 Improve C-level modularity by making more things 'static'.
4115 Don't publish debugger-only interfaces to other modules.
4116 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4117 (verify_bytepos, count_markers): Move decls to the only modules
4119 * region-cache.h (pp_cache): Likewise.
4120 * window.h (check_all_windows): Likewise.
4121 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4123 * sysdep.c (croak): Now static, if
4124 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4125 * syssignal.h (croak): Declare only if not static.
4127 * alloc.c (refill_memory_reserve): Now static if
4128 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4129 * lisp.h (refill_memory_reserve): Declare only if not static.
4131 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4132 Define only if USE_LUCID.
4134 * xrdb.c (x_customization_string, x_rm_string): Now static.
4136 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4137 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4139 * xdisp.c (draw_row_with_mouse_face): Now static.
4140 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4142 * window.h (check_all_windows): Mark externally visible.
4144 * window.c (window_deletion_count): Now static.
4146 * undo.c: Make symbols static if they're not exported.
4147 (last_undo_buffer, last_boundary_position, pending_boundary):
4150 * textprop.c (interval_insert_behind_hooks): Now static.
4151 (interval_insert_in_front_hooks): Likewise.
4153 * term.c: Make symbols static if they're not exported.
4154 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4155 (max_frame_lines, tty_set_terminal_modes):
4156 (tty_reset_terminal_modes, tty_turn_off_highlight):
4157 (get_tty_terminal): Now static.
4158 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4159 * termhooks.h (term_mouse_moveto): Do not declare if
4161 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4162 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4164 * sysdep.c: Make symbols static if they're not exported.
4165 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4167 (sigprocmask_set, full_mask): Remove; unused.
4168 (wait_debugging): Mark as visible.
4169 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4170 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4172 * syntax.c (syntax_temp): Define only if !__GNUC__.
4174 * sound.c (current_sound_device, current_sound): Now static.
4176 * search.c (searchbufs, searchbuf_head): Now static.
4178 * scroll.c (scroll_cost): Remove; unused.
4179 * dispextern.h (scroll_cost): Remove decl.
4181 * region-cache.h (pp_cache): Mark as externally visible.
4183 * process.c: Make symbols static if they're not exported.
4184 (process_tick, update_tick, create_process, chan_process):
4185 (Vprocess_alist, proc_buffered_char, datagram_access):
4186 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4187 (deactivate_process): Mark defn as static, as well as decl.
4188 * lisp.h (create_process): Remove decl.
4189 * process.h (chan_process, Vprocess_alist): Remove decls.
4191 * print.c: Make symbols static if they're not exported.
4192 (print_depth, new_backquote_output, being_printed, print_buffer):
4193 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4194 (print_interval, print_number_index, initial_stderr_stream):
4196 * lisp.h (Fprinc): Remove decl.
4197 (debug_output_compilation_hack): Mark as externally visible.
4199 * sysdep.c (croak): Move decl from here to syssignal.h.
4200 * syssignal.h (croak): Put it here, so the API can be checked when
4201 'croak' is called from dissociate_if_controlling_tty.
4203 * minibuf.c: Make symbols static if they're not exported.
4204 (minibuf_save_list, choose_minibuf_frame): Now static.
4205 * lisp.h (choose_minibuf_frame): Remove decl.
4207 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4209 * lread.c: Make symbols static if they're not exported.
4210 (read_objects, initial_obarray, oblookup_last_bucket_number):
4212 (make_symbol): Remove; unused.
4213 * lisp.h (initial_obarray, make_symbol): Remove decls.
4215 * keyboard.c: Make symbols static if they're not exported.
4216 (single_kboard, recent_keys_index, total_keys, recent_keys):
4217 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4218 (this_single_command_key_start, echoing, last_auto_save):
4219 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4220 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4221 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4222 (Vlispy_mouse_stem, double_click_count):
4224 (force_auto_save_soon): Define only if SIGDANGER.
4225 (ignore_mouse_drag_p): Now static if
4226 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4227 (print_help): Remove; unused.
4228 (stop_character, last_timer_event): Mark as externally visible.
4229 * keyboard.h (ignore_mouse_drag_p): Declare only if
4230 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4231 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4232 * lisp.h (echoing): Remove decl.
4233 (force_auto_save_soon): Declare only if SIGDANGER.
4234 * xdisp.c (redisplay_window): Simplify code, to make it more
4235 obvious that ignore_mouse_drag_p is not accessed if !defined
4236 USE_GTK && !defined HAVE_NS.
4238 * intervals.c: Make symbols static if they're not exported.
4239 (merge_properties_sticky, merge_interval_right, delete_interval):
4241 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4243 * insdel.c: Make symbols static if they're not exported.
4244 However, leave prepare_to_modify_buffer alone. It's never
4245 called from outside this function, but that appears to be a bug.
4246 (combine_after_change_list, combine_after_change_buffer):
4247 (adjust_after_replace, signal_before_change): Now static.
4248 (adjust_after_replace_noundo): Remove; unused.
4249 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4250 (signal_before_change): Remove decls.
4252 * indent.c (val_compute_motion, val_vmotion): Now static.
4254 * image.c: Make symbols static if they're not exported.
4255 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4257 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4258 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4260 * fringe.c (standard_bitmaps): Now static.
4261 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4263 * frame.c: Make symbols static if they're not exported.
4264 (x_report_frame_params, make_terminal_frame): Now static.
4265 (get_frame_param): Now static, unless HAVE_NS.
4266 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4267 (x_get_resource_string): Remove; not used.
4268 * frame.h (make_terminal_frame, x_report_frame_params):
4269 (x_get_resource_string); Remove decls.
4270 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4271 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4273 * font.c, fontset.c: Make symbols static if they're not exported.
4274 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4275 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4276 * font.c (font_close_object): Now static.
4277 * font.h (font_close_object): Remove.
4278 * fontset.c (FONTSET_OBJLIST): Remove.
4279 (free_realized_fontset) #if-0 the body, which does nothing.
4280 (face_suitable_for_char_p): #if-0, as it's never called.
4281 * fontset.h (face_suitable_for_char_p): Remove decl.
4282 * xfaces.c (face_at_string_position):
4283 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4284 since 0 is always ASCII.
4286 * fns.c (weak_hash_tables): Now static.
4288 * fileio.c: Make symbols static if they're not exported.
4289 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4290 (Vwrite_region_annotation_buffers): Now static.
4292 * eval.c: Make symbols static if they're not exported.
4293 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4294 * lisp.h (backtrace_list): Remove decl.
4296 * emacs.c: Make symbols static if they're not exported.
4297 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4298 (fatal_error_code, fatal_error_signal_hook, standard_args):
4300 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4301 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4302 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4303 * lisp.h (fatal_error_signal_hook): Remove decl.
4304 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4306 * editfns.c: Move a (normally-unused) function to its only use.
4307 * editfns.c, lisp.h (get_operating_system_release): Remove.
4308 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4309 worth the hassle of breaking this out.
4311 * xterm.c: Make symbols static if they're not exported.
4312 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4313 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4314 (x_destroy_window, x_delete_display):
4316 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4317 (x_mouse_leave): Remove; unused.
4318 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4319 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4320 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4322 (x_mouse_leave): Declare only if WINDOWSNT.
4323 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4324 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4327 * ftxfont.c: Make symbols static if they're not exported.
4328 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4330 * font.h (ftxfont_driver): Likewise.
4332 * xfns.c: Make symbols static if they're not exported.
4333 (x_last_font_name, x_display_info_for_name):
4334 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4335 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4336 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4337 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4338 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4339 (last_show_tip_args): Now static.
4340 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4341 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4342 (x_screen_planes): Remove; unused.
4343 * dispextern.h (x_screen_planes): Remove decl.
4345 * dispnew.c: Make symbols static if they're not exported.
4346 * dispextern.h (redraw_garbaged_frames, scrolling):
4347 (increment_row_positions): Remove.
4348 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4349 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4351 (redraw_garbaged_frames): Remove; unused.
4353 * xfaces.c: Make symbols static if they're not exported.
4354 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4356 * xterm.h (defined_color): Remove decls.
4357 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4358 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4359 (menu_face_changed_default, defined_color, free_realized_face):
4360 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4361 (ascii_face_of_lisp_face): Remove; unused.
4363 * xdisp.c: Make symbols static if they're not exported.
4364 * dispextern.h (scratch_glyph_row, window_box_edges):
4365 (glyph_to_pixel_coords, set_cursor_from_row):
4366 (get_next_display_element, set_iterator_to_next):
4367 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4368 (show_mouse_face): Remove decls
4369 * frame.h (message_buf_print): Likewise.
4370 * lisp.h (pop_message, set_message, check_point_in_composition):
4372 * xterm.h (set_vertical_scroll_bar): Likewise.
4373 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4374 (message_buf_print, scratch_glyph_row, displayed_buffer):
4375 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4376 (get_next_display_element, show_mouse_face, window_box_edges):
4377 (frame_to_window_pixel_xy, check_point_in_composition):
4378 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4379 (glyph_to_pixel_coords): Remove; unused.
4381 * dired.c (file_name_completion): Now static.
4383 * dbusbind.c (xd_in_read_queued_messages): Now static.
4385 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4386 * data.c (circular_list_error): Remove.
4388 * commands.h (last_point_position, last_point_position_buffer):
4389 (last_point_position_window): Remove decls.
4390 * keyboard.c: Make these variables static.
4392 * coding.h (coding, code_convert_region, encode_coding_gap):
4394 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4395 (iso_code_class, detect_coding, code_convert_region): Now static.
4396 (encode_coding_gap): Remove; unused.
4398 * chartab.c (chartab_chars, chartab_bits): Now static.
4400 * charset.h (charset_iso_8859_1): Remove decl.
4401 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4404 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4405 * ccl.c (Vccl_program_table): Now static.
4406 (check_ccl_update): Remove; unused.
4408 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4409 * category.h: ... from here.
4410 * category.c (check_category_table, set_category_set): Now static.
4412 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4413 * lisp.h: Remove these decls.
4415 * buffer.c (buffer_count): Remove unused var.
4417 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4418 so that it's not optimized away.
4419 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4420 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4421 exported only to the debugger.
4423 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4424 * atimer.h (run_all_atimers): Remove; not exported.
4426 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4427 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4428 was inaccessible from Lisp.
4429 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4430 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4432 alloc.c: Import and export fewer symbols, and remove unused items.
4433 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4435 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4436 it's not optimized away by whole-program optimization.
4437 (message_enable_multibyte, free_misc): Remove.
4438 (catchlist, handlerlist, mark_backtrace):
4439 Declare only if BYTE_MARK_STACK.
4440 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4441 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4442 (message_enable_multibyte): Remove decl.
4443 (free_misc, interval_free_list, float_block, float_block_index):
4444 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4445 (cons_free_list, last_marked_index):
4447 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4448 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4449 (mark_backtrace): Define only if BYTE_MARK_STACK.
4450 * xdisp.c (message_enable_multibyte): Now static.
4452 Declare Lisp_Object Q* variables to be 'static' if not exported.
4453 This makes it easier for human readers (and static analyzers)
4454 to see whether these variables are used from other modules.
4455 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4456 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4457 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4458 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4459 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4460 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4461 * xmenu.c, xselect.c:
4462 Declare Q* vars static if they are not used in other modules.
4463 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4464 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4465 Remove decls of unexported vars.
4466 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4468 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4470 Make Emacs functions such as Fatom 'static' by default.
4471 This makes it easier for human readers (and static analyzers)
4472 to see whether these functions can be called from other modules.
4473 DEFUN now defines a static function. To make the function external
4474 so that it can be used in other C modules, use the new macro DEFUE.
4475 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4476 (Finit_image_library):
4477 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4478 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4479 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4480 Remove decls, since these functions are now static.
4481 (Funintern, Fget_internal_run_time): New decls, since these functions
4482 were already external.
4484 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4485 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4486 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4487 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4488 * keyboard.c, keymap.c, lread.c:
4489 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4490 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4491 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4492 Mark functions with DEFUE instead of DEFUN,
4493 if they are used in other modules.
4494 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4495 decls for now-static functions.
4496 * buffer.h (Fdelete_overlay): Remove decl.
4497 * callproc.c (Fgetenv_internal): Mark as internal.
4498 * composite.c (Fremove_list_of_text_properties): Remove decl.
4499 (Fcomposition_get_gstring): New forward static decl.
4500 * composite.h (Fcomposite_get_gstring): Remove decl.
4501 * dired.c (Ffile_attributes): New forward static decl.
4502 * doc.c (Fdocumntation_property): New forward static decl.
4503 * eval.c (Ffetch_bytecode): New forward static decl.
4504 (Funintern): Remove extern decl; now in .h file where it belongs.
4505 * fileio.c (Fmake_symbolic_link): New forward static decl.
4506 * image.c (Finit_image_library): New forward static decl.
4507 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4508 * intervals.h (Fprevious_property_change):
4509 (Fremove_list_of_text_properties): Remove decls.
4510 * keyboard.c (Fthis_command_keys): Remove decl.
4511 (Fcommand_execute): New forward static decl.
4512 * keymap.c (Flookup_key): New forward static decl.
4513 (Fcopy_keymap): Now static.
4514 * keymap.h (Flookup_key): Remove decl.
4515 * process.c (Fget_process): New forward static decl.
4516 (Fprocess_datagram_address): Mark as internal.
4517 * syntax.c (Fsyntax_table_p): New forward static decl.
4518 (skip_chars): Remove duplicate decl.
4519 * textprop.c (Fprevious_property_change): New forward static decl.
4520 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4522 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4523 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4525 * editfns.c (Fformat): Remove unreachable code.
4527 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4529 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4532 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4534 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4535 when at ZV. (Bug#8487)
4537 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4539 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4541 * keyboard.c (parse_tool_bar_item): Likewise.
4542 * sound.c (sound_cleanup, alsa_close): Likewise.
4543 * termcap.c (tgetent): Likewise.
4544 * xfns.c (x_default_font_parameter): Likewise.
4545 * xsettings.c (read_and_apply_settings): Likewise.
4547 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4548 (overrun_check_free): Protoize.
4550 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4552 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4553 since callers should never pass a negative size.
4554 Change the signature to match that of plain 'read' and 'write'; see
4555 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4556 * lisp.h: Update prototypes of emacs_write and emacs_read.
4558 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4560 * xdisp.c (redisplay_window): Don't try to determine the character
4561 position of the scroll margin if the window start point w->startp
4562 is outside the buffer's accessible region. (Bug#8468)
4564 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4566 Fix write-region and its subroutines for buffers > 2GB.
4567 * fileio.c (a_write, e_write): Modify declaration of arguments and
4568 local variables to support buffers larger than 2GB.
4569 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4571 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4572 argument, local variables, and return value.
4574 * lisp.h: Update prototypes of emacs_write and emacs_read.
4576 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4578 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4580 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4582 Fix more problems found by GCC 4.6.0's static checks.
4584 * xdisp.c (vmessage): Use a better test for character truncation.
4586 * charset.c (load_charset_map): <, not <=, for optimization,
4587 and to avoid potential problems with integer overflow.
4588 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4589 * casetab.c (set_identity, shuffle): Likewise.
4590 * editfns.c (Fformat): Likewise.
4591 * syntax.c (skip_chars): Likewise.
4593 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4594 This also lets GCC 4.6.0 generate slightly better loop code.
4596 * callint.c (Fcall_interactively): <, not <=, for optimization.
4597 (Fcall_interactively): Count the number of arguments produced,
4598 not the number of arguments given. This is simpler and lets GCC
4599 4.6.0 generate slightly better code.
4601 * ftfont.c: Distingish more carefully between FcChar8 and char.
4602 The previous code passed unsigned char * to a functions like
4603 strlen and xstrcasecmp that expect char *, which does not
4604 conform to the C standard.
4605 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4606 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4607 char * when the C standard requires it.
4609 * keyboard.c (read_char): Remove unused var.
4611 * eval.c: Port to Windows vsnprintf (Bug#8435).
4613 (SIZE_MAX): Define if the headers do not.
4614 (verror): Do not give up if vsnprintf returns a negative count.
4615 Instead, grow the buffer. This ports to Windows vsnprintf, which
4616 does not conform to C99. Problem reported by Eli Zaretskii.
4617 Also, simplify the allocation scheme, by avoiding the need for
4618 calling realloc, and removing the ALLOCATED variable.
4620 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4622 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4623 But keep the doprint source code for now, as we might revamp it
4624 and use it again (Bug#8435).
4625 * lisp.h (doprnt): Remove.
4626 * Makefile.in (base_obj): Remove doprnt.o.
4627 * deps.mk (doprnt.o): Remove.
4629 error: Print 32- and 64-bit integers portably (Bug#8435).
4630 Without this change, on typical 64-bit hosts error ("...%d...", N)
4631 was used to print both 32- and 64-bit integers N, which relied on
4633 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4635 * lisp.h (error, verror): Mark as printf-like functions.
4636 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4637 Report overflow in size calculations when allocating printf buffer.
4638 Do not truncate output string at its first null byte.
4639 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4640 Truncate the output at a character boundary, since vsnprintf does not
4642 * charset.c (check_iso_charset_parameter): Convert internal
4643 character to string before calling 'error', since %c now has the
4645 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4646 overflow when computing char to be passed to 'error'. Do not
4647 pass Lisp_Object to 'error'; pass the integer instead.
4648 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4649 formatted with plain %d.
4651 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4653 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4655 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4657 * xterm.c (x_catch_errors): Remove duplicate declaration.
4659 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4661 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4663 2011-04-10 Jim Meyering <meyering@redhat.com>
4665 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4666 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4667 return ssize_t not "int", and use size_t as the buffer length.
4668 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4669 * gnutls.h: Update declarations.
4670 * process.c (read_process_output): Use ssize_t, to match.
4671 (send_process): Likewise.
4673 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4675 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4677 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4679 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4680 Use unsigned char, to match FcChar8 type definition.
4682 * xterm.c (handle_one_xevent):
4683 * xmenu.c (create_and_show_popup_menu):
4684 * xselect.c (x_decline_selection_request)
4685 (x_reply_selection_request): Avoid type-punned deref of X events.
4687 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4689 Fix some uses of `int' instead of EMACS_INT.
4690 * search.c (string_match_1, fast_string_match)
4691 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4692 (scan_buffer, find_next_newline_no_quit)
4693 (find_before_next_newline, search_command, Freplace_match)
4694 (Fmatch_data): Make some `int' variables be EMACS_INT.
4696 * xdisp.c (display_count_lines): 3rd argument and return value now
4697 EMACS_INT. All callers changed.
4698 (pint2hrstr): Last argument is now EMACS_INT.
4700 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4701 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4702 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4703 (decode_coding_utf_16, decode_coding_emacs_mule)
4704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4705 (decode_coding_ccl, decode_coding_charset)
4706 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4707 (decode_coding_iso_2022, decode_coding_emacs_mule)
4708 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4709 <char_offset, last_offset>: Declare EMACS_INT.
4710 (encode_coding_utf_8, encode_coding_utf_16)
4711 (encode_coding_emacs_mule, encode_invocation_designation)
4712 (encode_designation_at_bol, encode_coding_iso_2022)
4713 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4714 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4716 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4717 (encode_invocation_designation): Last argument P_NCHARS is now
4719 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4720 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4722 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4725 * ccl.c (Fccl_execute_on_string): Declare some variables
4728 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4730 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4732 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4734 * process.c (Fformat_network_address): Doc fix.
4736 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4738 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4740 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4742 * keyboard.c (read_char): Call Lisp function help-form-show,
4743 instead of using internal_with_output_to_temp_buffer.
4744 (Qhelp_form_show): New var.
4745 (syms_of_keyboard): Use DEFSYM macro.
4747 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4749 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4751 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4753 * process.c (Flist_processes): Remove to Lisp.
4754 (list_processes_1): Delete.
4756 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4758 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4760 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4762 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4764 Fix more problems found by GCC 4.6.0's static checks.
4766 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4768 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4770 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4772 * xdisp.c (vmessage): Mark as a printf-like function.
4774 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4776 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4778 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4779 printf-like functions.
4780 (tiff_load): Add casts to remove these marks before passing them
4781 to system-supplied API.
4783 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4785 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4786 This avoids several warnings with gcc -Wstrict-overflow.
4787 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4788 directly, rather than having caller test rule sign. This avoids
4789 some unnecessary tests.
4790 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4791 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4792 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4794 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4795 (xfont_open): Avoid unnecessary tests.
4797 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4799 * composite.h, composite.c (composition_gstring_put_cache):
4800 Use EMACS_INT, not int, for length.
4802 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4803 breaking out part of COMPOSITION_DECODE_RULE.
4804 (COMPOSITION_DECODE_RULE): Use it.
4805 * composite.c (get_composition_id): Remove unused local vars,
4806 by using the new macro.
4808 * textprop.c (set_text_properties_1): Change while to do-while,
4809 since the condition is always true at first.
4811 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4812 (interval_deletion_adjustment): Return unsigned value.
4815 * process.c (list_processes_1, create_pty, read_process_output):
4816 (exec_sentinel): Remove vars that were set but not used.
4817 (create_pty): Remove unnecessary "volatile"s.
4818 (Fnetwork_interface_info): Avoid possibility of int overflow.
4819 (read_process_output): Do adaptive read buffering even if carryover.
4820 (read_process_output): Simplify nbytes computation if buffered.
4822 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4824 * syntax.c (scan_words): Remove var that was set but not used.
4825 (update_syntax_table): Use unsigned instead of int.
4827 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4828 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4829 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4831 * print.c (print_error_message): Avoid int overflow.
4833 * font.c (font_list_entities): Redo for clarity,
4834 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4836 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4837 (font_score): Avoid potential overflow in diff calculation.
4839 * fns.c (substring_both): Remove var that is set but not used.
4840 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4842 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4844 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4845 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4846 can always succeed if overflow has undefined behavior.
4848 * search.c (boyer_moore, wordify): Remove vars set but not used.
4849 (wordify): Omit three unnecessary tests.
4851 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4852 All callers changed. This avoids the need for an unused var.
4854 * casefiddle.c (casify_region): Remove var that is set but not used.
4856 * dired.c (file_name_completion): Remove var that is set but not used.
4858 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4860 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4861 (Finsert_file_contents): Remove unnecessary code checking fd.
4863 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4864 Check for integer overflow on size calculations.
4866 * buffer.c (Fprevious_overlay_change): Remove var that is set
4869 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4870 Remove vars that are set but not used.
4871 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4872 (timer_check_2): Mark vars as initialized.
4874 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4876 * image.c (lookup_image): Remove var that is set but not used.
4877 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4879 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4880 that are set but not used.
4882 * xfns.c (make_invisible_cursor): Don't return garbage
4883 if XCreateBitmapFromData fails (Bug#8410).
4885 * xselect.c (x_get_local_selection, x_handle_property_notify):
4886 Remove vars that are set but not used.
4888 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4889 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4891 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4892 Remove var that is set but not used.
4893 (scroll_bar_windows_size): Now size_t, not int.
4894 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4897 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4898 (map_tty_color) [!defined MSDOS]: Likewise.
4900 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4902 * coding.c: Remove vars that are set but not used.
4903 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4904 All callers changed.
4905 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4906 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4907 (decode_coding_charset): Remove vars that are set but not used.
4909 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4910 that is set but not used.
4912 * print.c (print_object): Remove var that is set but not used.
4914 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4915 The gnulib version avoids calling malloc in the usual case,
4916 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4917 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4918 * filelock.c (current_lock_owner): Likewise.
4919 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4920 * sysdep.c: Include allocator.h, careadlinkat.h.
4921 (emacs_no_realloc_allocator): New static constant.
4922 (emacs_readlink): New function.
4923 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4924 ../lib/careadlinkat.h.
4926 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4928 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4929 first non-nil return value).
4931 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4933 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4934 if not defined (Bug#8403).
4936 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4938 * xdisp.c (display_count_lines): Remove parameter `start',
4939 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4940 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4941 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4942 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4943 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4944 and thereabouts. All callers changed.
4945 (get_per_char_metric): Remove parameter `f', unused since
4946 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4948 2011-04-02 Jim Meyering <meyering@redhat.com>
4950 do not dereference NULL upon failed strdup
4951 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4952 (ns_get_family): Likewise.
4954 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4956 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4958 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4960 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4963 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4965 Add lexical binding.
4967 * window.c (Ftemp_output_buffer_show): New fun.
4968 (Fsave_window_excursion):
4969 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4971 * lread.c (lisp_file_lexically_bound_p): New function.
4972 (Fload): Bind Qlexical_binding.
4973 (readevalloop): Remove `evalfun' arg.
4974 Bind Qinternal_interpreter_environment.
4975 (Feval_buffer): Bind Qlexical_binding.
4976 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4978 (syms_of_lread): Declare `lexical-binding'.
4980 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4982 * keyboard.c (eval_dyn): New fun.
4983 (menu_item_eval_property): Use it.
4985 * image.c (parse_image_spec): Use Ffunctionp.
4987 * fns.c (concat, mapcar1): Accept byte-code-functions.
4989 * eval.c (Fsetq): Handle lexical vars.
4990 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4991 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4992 (FletX, Flet): Obey lexical binding.
4993 (Fcommandp): Handle closures.
4994 (Feval): New `lexical' arg.
4995 (eval_sub): New function extracted from Feval. Use it almost
4996 everywhere where Feval was used. Look up vars in lexical env.
4998 (Ffunctionp): Move from subr.el.
4999 (Ffuncall): Handle closures.
5000 (apply_lambda): Remove `eval_flags'.
5001 (funcall_lambda): Handle closures and new byte-code-functions.
5002 (Fspecial_variable_p): New function.
5003 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5004 but without exporting it to Lisp.
5006 * doc.c (Fdocumentation, store_function_docstring):
5007 * data.c (Finteractive_form): Handle closures.
5009 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5012 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5014 (exec_byte_code): New function extracted from Fbyte_code to handle new
5015 calling convention for byte-code-functions. Add new byte-codes.
5017 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5019 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5021 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5023 * xdisp.c (redisplay_internal): Fix prototype.
5025 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5027 * xdisp.c (SCROLL_LIMIT): New macro.
5028 (try_scrolling): Use it when setting scroll_limit.
5029 Limit scrolling to 100 screen lines.
5030 (redisplay_window): Even when falling back on "recentering",
5031 position point in the window according to scroll-conservatively,
5032 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5034 (try_scrolling): When point is above the window, allow searching
5035 as far as scroll_max, or one screenful, to compute vertical
5036 distance from PT to the scroll margin position. This prevents
5037 try_scrolling from unnecessarily failing when
5038 scroll-conservatively is set to a value slightly larger than the
5039 window height. Clean up the case of PT below the margin at bottom
5040 of window: scroll_max can no longer be INT_MAX. When aggressive
5041 scrolling is in use, don't let point enter the opposite scroll
5042 margin as result of the scroll.
5043 (syms_of_xdisp) <scroll-conservatively>: Document the
5044 threshold of 100 lines for never-recentering scrolling.
5046 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5048 * dispextern.h (move_it_by_lines):
5049 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5050 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5051 (message_log_check_duplicate): Remove parameters `prev_bol' and
5052 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5053 (redisplay_internal): Remove parameter `preserve_echo_area',
5054 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5056 * indent.c (Fvertical_motion):
5057 * window.c (window_scroll_pixel_based, Frecenter):
5058 Don't pass `need_y_p' to `move_it_by_lines'.
5060 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5062 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5063 steal a few bits to be more compact.
5064 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5065 Remove unneeded casts.
5067 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5069 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5071 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5072 binding" message (bug#7967).
5074 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5076 Fix more problems found by GCC 4.6.0's static checks.
5078 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5079 Remove unused local var.
5081 * editfns.c (Fmessage_box): Remove unused local var.
5083 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5084 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5085 Omit unused local vars.
5086 * window.c (shrink_windows): Omit unused local var.
5087 * menu.c (digest_single_submenu): Omit unused local var.
5088 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5089 Omit unused local var.
5091 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5092 Don't assume string length fits in int.
5093 (keyremap_step, read_key_sequence): Use size_t for sizes.
5094 (read_key_sequence): Don't check last_real_key_start redundantly.
5096 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5097 instead of alloca (Bug#8344).
5099 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5100 (Fbacktrace_frame): Don't assume nframes fits in int.
5102 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5104 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5107 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5109 * cm.c (calccost): Turn while-do into do-while, for clarity.
5111 * keyboard.c (syms_of_keyboard): Use the same style as later
5112 in this function when indexing through an array. This also
5113 works around GCC bug 48267.
5115 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5117 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5119 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5120 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5122 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5123 This avoids undefined behavior on integer overflow, and is a bit
5124 more convenient anyway since it is compared to a size_t variable.
5126 Variadic C functions now count arguments with size_t, not int.
5127 This avoids an unnecessary limitation on 64-bit machines, which
5128 caused (substring ...) to crash on large vectors (Bug#8344).
5129 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5130 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5131 All variadic functions and their callers changed accordingly.
5132 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5133 * data.c (arith_driver, float_arith_driver): Likewise.
5134 * editfns.c (general_insert_function): Likewise.
5135 * eval.c (struct backtrace.nargs, interactive_p)
5136 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5137 (funcall_lambda, mark_backtrace): Likewise.
5138 * fns.c (concat): Likewise.
5139 * frame.c (x_set_frame_parameters): Likewise.
5140 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5141 0 if not found, not -1. All callers changed.
5143 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5144 (stack_copy_size): Now size_t, not int.
5145 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5147 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5149 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5150 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5151 All callers changed.
5153 * lisp.h (multibyte_char_to_unibyte):
5154 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5155 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5156 * character.h (CHAR_TO_BYTE8):
5157 * cmds.c (internal_self_insert):
5158 * editfns.c (general_insert_function):
5159 * keymap.c (push_key_description):
5160 * search.c (Freplace_match):
5161 * xdisp.c (message_dolog, set_message_1): All callers changed.
5163 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5165 * keyboard.c (safe_run_hook_funcall): New function.
5166 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5167 don't set the hook to nil, but remove the offending function instead.
5168 (Qcommand_hook_internal): Remove, unused.
5169 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5170 Vcommand_hook_internal.
5172 * eval.c (enum run_hooks_condition): Remove.
5173 (funcall_nil, funcall_not): New functions.
5174 (run_hook_with_args): Call each function through a `funcall' argument.
5175 Remove `cond' argument, now redundant.
5176 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5177 (Frun_hook_with_args_until_failure): Adjust accordingly.
5178 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5180 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5182 * dispextern.h (string_buffer_position): Remove declaration.
5184 * print.c (strout): Remove parameter `multibyte', unused since
5185 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5187 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5188 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5189 All callers changed.
5191 * w32.c (_wsa_errlist): Use braces for struct initializers.
5193 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5194 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5195 All callers changed.
5196 (string_buffer_position): Likewise. Also, make static (it's never
5197 used outside xdisp.c).
5198 (cursor_row_p): Remove parameter `w', unused since
5199 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5200 (decode_mode_spec): Remove parameter `precision', introduced during
5201 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5202 All callers changed.
5204 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5206 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5208 2011-03-27 Anders Lindgren <andlind@gmail.com>
5210 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5211 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5212 (ns_update_auto_hide_menu_bar): New functions.
5213 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5214 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5215 ns_constrain_all_frames.
5216 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5217 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5219 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5221 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5223 2011-03-27 Glenn Morris <rgm@gnu.org>
5225 * syssignal.h: Replace RETSIGTYPE with void.
5226 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5227 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5228 Replace SIGTYPE with void everywhere.
5229 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5230 * s/template.h (SIGTYPE): Remove commented out definition.
5232 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5234 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5235 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5237 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5239 * w32.c (read_unc_volume): Use parameter `henum', instead of
5240 global variable `wget_enum_handle'.
5242 * keymap.c (describe_vector): Remove parameters `indices' and
5243 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5244 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5246 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5248 * keyboard.c (timer_check): Remove parameter `do_it_now',
5249 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5250 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5251 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5253 * keyboard.c (read_char):
5254 * w32menu.c (w32_menu_display_help):
5255 * xmenu.c (show_help_event, menu_help_callback):
5256 Adjust calls to `show_help_echo'.
5258 * gtkutil.c (xg_maybe_add_timer):
5259 * keyboard.c (readable_events):
5260 * process.c (wait_reading_process_output):
5261 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5263 * insdel.c (adjust_markers_gap_motion):
5264 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5265 (gap_left, gap_right): Don't call it.
5267 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5269 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5270 incurred during fontification.
5272 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5274 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5275 (DEFVAR_PER_BUFFER): Don't pass it.
5277 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5278 (scrolling_window): Don't pass it.
5280 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5282 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5284 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5286 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5287 of variables specific to SELinux and computation of `encoded_absname'.
5289 * image.c (XPutPixel): Remove unused variable `height'.
5291 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5293 * unexw32.c (get_section_info): Remove unused variable `section'.
5295 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5296 (system_process_attributes): Remove unused variable `sess'.
5297 (sys_read): Remove unused variable `err'.
5299 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5300 (w32_wnd_proc): Remove unused variable `isdead'.
5301 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5302 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5303 (x_create_tip_frame): Remove unused variable `tem'.
5305 * w32inevt.c (w32_console_read_socket):
5306 Remove unused variable `no_events'.
5308 * w32term.c (x_draw_composite_glyph_string_foreground):
5309 Remove unused variable `width'.
5311 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5313 * w32term.c (x_set_glyph_string_clipping):
5314 Don't pass uninitialized region to CombineRgn.
5316 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5318 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5319 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5320 (Fx_close_connection): Remove unused variable `i'.
5322 * w32font.c (w32font_draw): Return number of glyphs.
5323 (w32font_open_internal): Remove unused variable `i'.
5324 (w32font_driver): Add missing initializer.
5326 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5327 (fill_in_menu): Remove unused variable `items_added'.
5329 * w32term.c (last_mouse_press_frame): Remove static global variable.
5330 (w32_clip_to_row): Remove unused variable `f'.
5331 (x_delete_terminal): Remove unused variable `i'.
5333 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5334 (NOTHING): Remove unused static global variable.
5335 (uniscribe_check_otf): Remove unused variable `table'.
5336 (uniscribe_font_driver): Add missing initializers.
5338 2011-03-23 Julien Danjou <julien@danjou.info>
5340 * term.c (Fsuspend_tty, Fresume_tty):
5341 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5342 * window.c (temp_output_buffer_show):
5343 * insdel.c (signal_before_change):
5344 * frame.c (Fhandle_switch_frame):
5345 * fileio.c (Fdo_auto_save):
5346 * emacs.c (Fkill_emacs):
5347 * editfns.c (save_excursion_restore):
5348 * cmds.c (internal_self_insert):
5349 * callint.c (Fcall_interactively):
5350 * buffer.c (Fkill_all_local_variables):
5351 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5353 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5354 unconditionnaly since it does the check itself.
5356 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5358 Fix more problems found by GCC 4.5.2's static checks.
5360 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5361 the first time through the loop, since we know p0 < p1 then.
5362 This also avoids a gcc -Wstrict-overflow warning.
5364 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5365 leading to a memory leak, possible in functions like
5366 load_charset_map_from_file that can allocate an unbounded number
5367 of objects (Bug#8318).
5369 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5370 that could (at least in theory) be that large.
5372 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5373 This is less likely to overflow, and avoids undefined behavior if
5374 overflow does occur. All callers changed. Use strtoul to scan
5375 for the unsigned long integer.
5376 (pint2hrstr): Simplify and tune code slightly.
5377 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5379 * scroll.c (do_scrolling): Work around GCC bug 48228.
5380 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5382 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5383 This also avoids a warning with gcc -Wstrict-overflow.
5384 (validate_x_resource_name): Simplify count usage.
5385 This also avoids a warning with gcc -Wstrict-overflow.
5387 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5390 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5392 * process.c (Fmake_network_process): Use socklen_t, not int,
5393 where POSIX says socklen_t is required in portable programs.
5394 This fixes a porting bug on hosts like 64-bit HP-UX, where
5395 socklen_t is wider than int (Bug#8277).
5396 (Fmake_network_process, server_accept_connection):
5397 (wait_reading_process_output, read_process_output):
5400 * process.c: Rename or move locals to avoid shadowing.
5401 (list_processes_1, Fmake_network_process):
5402 (read_process_output_error_handler, exec_sentinel_error_handler):
5403 Rename or move locals.
5404 (Fmake_network_process): Define label "retry_connect" only if needed.
5405 (Fnetwork_interface_info): Fix pointer signedness.
5406 (process_send_signal): Add cast to avoid pointer signedness problem.
5407 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5408 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5410 Make tparam.h and terminfo.c consistent.
5411 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5412 Include tparam.h instead, since it declares them.
5413 * cm.h (PC): Remove extern decl; tparam.h now does this.
5414 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5415 * terminfo.c: Include tparam.h, to check interfaces.
5416 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5417 (tparam): Adjust signature to match interface in tparam.h;
5418 this removes some undefined behavior. Check that outstring and len
5419 are zero, which they always are with Emacs.
5420 * tparam.h (PC, BC, UP): New extern decls.
5422 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5423 (xftfont_open): Rename locals to avoid shadowing.
5425 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5426 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5427 (OTF_TAG_SYM): Omit macro if not needed.
5428 (ftfont_list): Remove unused local.
5429 (get_adstyle_property, ftfont_pattern_entity):
5430 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5431 Rename locals to avoid shadowing.
5433 * xfont.c (xfont_list_family): Mark var as initialized.
5435 * xml.c (make_dom): Now static.
5437 * composite.c (composition_compute_stop_pos): Rename local to
5439 (composition_reseat_it): Remove unused locals.
5440 (find_automatic_composition, composition_adjust_point): Likewise.
5441 (composition_update_it): Mark var as initialized.
5442 (find_automatic_composition): Mark vars as initialized,
5443 with a FIXME (Bug#8290).
5445 character.h: Rename locals to avoid shadowing.
5446 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5447 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5448 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5449 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5452 * textprop.c (property_change_between_p): Remove; unused.
5454 * intervals.c (interval_start_pos): Now static.
5456 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5458 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5459 Rename locals to avoid shadowing.
5461 * sound.c (wav_play, au_play, Fplay_sound_internal):
5462 Fix pointer signedness.
5463 (alsa_choose_format): Remove unused local var.
5464 (wav_play): Initialize a variable to 0, to prevent undefined
5465 behavior (Bug#8278).
5467 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5469 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5471 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5472 clobbering (Bug#8298).
5473 * sysdep.c (sys_subshell): Likewise.
5474 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5476 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5477 This should get cleaned up, so that child_setup has the
5478 same signature on all platforms.
5480 * callproc.c (call_process_cleanup): Now static.
5481 (relocate_fd): Rename locals to avoid shadowing.
5483 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5485 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5486 not to be necessary, and produces flickering.
5488 2011-03-20 Glenn Morris <rgm@gnu.org>
5490 * config.in: Remove file.
5492 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5494 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5495 are now in src/globals.h.
5496 (syms_of_minibuf): Remove spurious & from previous change.
5498 2011-03-20 Leo <sdl.web@gmail.com>
5500 * minibuf.c (completing-read-function): New variable.
5501 (completing-read-default): Rename from completing-read.
5502 (completing-read): Call completing-read-function.
5504 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5506 * xfaces.c (Fx_load_color_file):
5507 Read color file from absolute filename (bug#8250).
5509 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5511 * makefile.w32-in: Update dependencies.
5513 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5515 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5517 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5519 Fix more problems found by GCC 4.5.2's static checks.
5521 * process.c (make_serial_process_unwind, send_process_trap):
5522 (sigchld_handler): Now static.
5524 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5525 That way, the code declares only the vars that it needs.
5526 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5527 * s/cygwin.h (PTY_ITERATION): Likewise.
5528 * s/darwin.h (PTY_ITERATION): Likewise.
5529 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5531 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5532 * process.c (allocate_pty): Don't declare stb unless it's needed.
5534 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5535 (CONSTANTLIM): Remove; unused.
5536 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5537 Define only if needed.
5539 * unexelf.c (unexec): Name an expression,
5540 to avoid gcc -Wbad-function-cast warning.
5541 Use a different way to cause a compilation error if anyone uses
5542 n rather than nn, a way that does not involve shadowing.
5543 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5545 * deps.mk (unexalpha.o): Remove; unused.
5547 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5548 * unexec.h: New file.
5549 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5550 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5552 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5553 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5554 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5555 Change as necessary to match prototype in unexec.h.
5557 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5559 (back_comment, skip_chars): Mark vars as initialized.
5561 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5562 Rename locals to avoid shadowing.
5564 * lread.c (read1): Rewrite so as not to use empty "else".
5565 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5567 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5569 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5570 warning when compiling print.c.
5572 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5573 instead of using an uninitialized var.
5574 (font_sort_entities): Mark var as initialized.
5576 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5578 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5579 pointers to constants.
5580 (font_parse_fcname): Remove unused vars.
5581 (font_delete_unmatched): Now static.
5582 (font_get_spec): Remove; unused.
5583 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5584 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5585 Rename or move locals to avoid shadowing.
5587 * fns.c (require_nesting_list, require_unwind): Now static.
5588 (Ffillarray): Rename locals to avoid shadowing.
5590 * floatfns.c (domain_error2): Define only if needed.
5591 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5593 * alloc.c (mark_backtrace): Move decl from here ...
5594 * lisp.h: ... to here, so that it can be checked.
5596 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5597 (Fdefvar): Rewrite so as not to use empty "else".
5598 (lisp_indirect_variable): Name an expression,
5599 to avoid gcc -Wbad-function-cast warning.
5600 (Fdefvar): Rename locals to avoid shadowing.
5602 * callint.c (quotify_arg, quotify_args): Now static.
5603 (Fcall_interactively): Rename locals to avoid shadowing.
5604 Use const pointer when appropriate.
5606 * lisp.h (get_system_name, get_operating_system_release):
5607 Move decls here, to check interfaces.
5608 * process.c (get_operating_system_release): Move decl to lisp.h.
5609 * xrdb.c (get_system_name): Likewise.
5610 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5611 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5612 some of which prompt warnings from gcc -Wbad-function-cast.
5613 (Fformat_time_string, Fencode_time, Finsert_char):
5614 (Ftranslate_region_internal, Fformat):
5615 Rename or remove local vars to avoid shadowing.
5616 (Ftranslate_region_internal): Mark var as initialized.
5618 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5621 * lisp.h (eassert): Check that the argument compiles, even if
5622 ENABLE_CHECKING is not defined.
5624 * data.c (Findirect_variable): Name an expression, to avoid
5625 gcc -Wbad-function-cast warning.
5626 (default_value, arithcompare, arith_driver, arith_error): Now static.
5627 (store_symval_forwarding): Rename local to avoid shadowing.
5628 (Fmake_variable_buffer_local, Fmake_local_variable):
5629 Mark variables as initialized.
5630 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5632 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5633 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5634 Rename locals to avoid shadowing.
5635 (mark_stack): Move local variables into the #ifdef region where
5637 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5638 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5640 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5641 (GC_STRING_CHARS): Remove; not used.
5642 (Fmemory_limit): Cast sbrk's returned value to char *.
5644 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5645 avoids undefined behavior in theory.
5647 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5649 Use functions, not macros, for up- and down-casing (Bug#8254).
5650 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5651 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5652 to use the following functions instead of these macros.
5653 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5654 EMACS_INT, since callers assume the returned value fits in int.
5655 (upcase1): Likewise, for UPCASE_TABLE.
5656 (uppercasep, lowercasep, upcase): New static inline functions.
5657 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5658 the race-condition problem in the old DOWNCASE.
5660 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5661 Rename locals to avoid shadowing.
5662 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5663 (regex_compile, re_search_2, re_match_2_internal):
5664 Remove unused local vars.
5665 (FREE_VAR): Rewrite so as not to use empty "else",
5666 which gcc can warn about.
5667 (regex_compile, re_match_2_internal): Mark locals as initialized.
5668 (RETALLOC_IF): Define only if needed.
5669 (WORDCHAR_P): Likewise. This one is never needed, but is used
5670 only in a comment talking about a compiler bug, so put inside
5671 the #if 0 of that comment.
5672 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5673 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5676 * search.c (boyer_moore): Rename locals to avoid shadowing.
5677 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5678 (PREV_CHAR_BOUNDARY): Likewise.
5680 * search.c (simple_search): Remove unused var.
5682 * dired.c (compile_pattern): Move decl from here ...
5683 * lisp.h: ... to here, so that it can be checked.
5684 (struct re_registers): New forward decl.
5686 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5688 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5690 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5691 Rename locals to avoid shadowing.
5692 (Fvertical_motion): Mark locals as initialized.
5694 * casefiddle.c (casify_object, casify_region): Now static.
5695 (casify_region): Mark local as initialized.
5697 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5699 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5700 New macros, so that the caller can use some names other than
5701 gcpro1, gcpro2, etc.
5702 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5704 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5705 argument, for consistency with GCPRO2_VAR, etc: it is now the
5706 prefix of the variable, not the variable itself. All uses
5708 * dired.c (directory_files_internal, file_name_completion):
5709 Rename locals to avoid shadowing.
5711 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5712 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5713 dired.c's scmp function, had undefined behavior.
5714 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5715 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5716 * buffer.h: ... to here, because these macros use current_buffer,
5717 and the new implementation with inline functions needs to have
5718 current_buffer in scope now, rather than later when the macros
5720 (downcase, upcase1): New static inline functions.
5721 (DOWNCASE, UPCASE1): Reimplement using these functions.
5722 This avoids undefined behavior in expressions like
5723 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5724 from race conditions in accessing the global variables
5725 case_temp1 and case_temp2.
5726 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5727 * lisp.h (case_temp1, case_temp2): Remove their decls.
5728 * character.h (ASCII_CHAR_P): Move from here ...
5729 * lisp.h: ... to here, so that the inline functions mentioned
5732 * dired.c (directory_files_internal_unwind): Now static.
5734 * fileio.c (file_name_as_directory, directory_file_name):
5735 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5737 (file_name_as_directory): Use const pointers when appropriate.
5738 (Fexpand_file_name): Likewise. In particular, newdir might
5739 point at constant storage, so make it a const pointer.
5740 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5741 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5743 (Fset_file_times, Finsert_file_contents, auto_save_error):
5744 Rename locals to avoid shadowing.
5746 * minibuf.c (choose_minibuf_frame_1): Now static.
5747 (Ftry_completion, Fall_completions): Rename or remove locals
5750 * marker.c (bytepos_to_charpos): Remove; unused.
5752 * lisp.h (verify_bytepos, count_markers): New decls,
5753 so that gcc does not warn that these functions aren't declared.
5755 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5756 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5757 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5758 (copy_text): Remove unused local var.
5760 * filelock.c (within_one_second): Now static.
5761 (lock_file_1): Rename local to avoid shadowing.
5763 * buffer.c (fix_overlays_before): Mark locals as initialized.
5764 (fix_start_end_in_overlays): Likewise. This function should be
5765 simplified by using pointers-to-pointers, but that's a different
5767 (switch_to_buffer_1): Now static.
5768 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5769 (report_overlay_modification): Rename locals to avoid shadowing.
5771 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5772 Fix pointer signedness issue.
5773 (sys_subshell): Mark local as volatile if checking for lint,
5774 to suppress a gcc -Wclobbered warning that does not seem to be right.
5775 (MAXPATHLEN): Define only if needed.
5777 * process.c (serial_open, serial_configure): Move decls from here ...
5778 * systty.h: ... to here, so that they can be checked.
5780 * fns.c (get_random, seed_random): Move extern decls from here ...
5781 * lisp.h: ... to here, so that they can be checked.
5783 * sysdep.c (reset_io): Now static.
5784 (wait_for_termination_signal): Remove; unused.
5786 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5787 (copy_keymap_item, append_key, push_text_char_description):
5789 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5790 (DENSE_TABLE_SIZE): Remove; unused.
5791 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5792 (describe_map_tree):
5793 Rename locals to avoid shadowing.
5795 * keyboard.c: Declare functions static if they are not used elsewhere.
5796 (echo_char, echo_dash, cmd_error, top_level_2):
5797 (poll_for_input, handle_async_input): Now static.
5798 (read_char, kbd_buffer_get_event, make_lispy_position):
5799 (make_lispy_event, make_lispy_movement, apply_modifiers):
5800 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5801 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5802 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5803 (read_key_sequence, read_char): Mark locals as initialized.
5804 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5806 * keyboard.h (make_ctrl_char): New decl.
5807 (mark_kboards): Move decl here ...
5808 * alloc.c (mark_kboards): ... from here.
5810 * lisp.h (force_auto_save_soon): New decl.
5812 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5813 (DEFINE_DUMMY_FUNCTION): New macro.
5814 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5816 (main): Add casts to avoid warnings
5817 if GCC considers string literals to be constants.
5819 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5821 * dbusbind.c: Pointer signedness fixes.
5822 (xd_signature, xd_append_arg, xd_initialize):
5823 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5824 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5825 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5826 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5828 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5829 if GCC considers string literals to be constants.
5830 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5832 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5834 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5835 (print_preprocess, print_object): New macro to fix last change.
5837 * print.c (print_preprocess): Don't forget font objects.
5839 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5841 * emacs.c (USAGE3): Doc fixes.
5843 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5845 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5848 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5850 * lisp.h (VWindow_system, Qfile_name_history):
5851 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5852 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5853 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5855 * w32select.c: Don't #include "keyboard.h".
5856 (run_protected): Add extern declaration for waiting_for_input.
5858 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5859 * w32console.c (detect_input_pending, read_input_pending)
5860 (encode_terminal_code):
5861 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5862 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5863 (w32_system_caret_y, Qfile_name_history):
5864 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5865 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5866 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5867 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5868 * w32proc.c (Qlocal, report_file_error):
5869 * w32term.c (Vwindow_system, updating_frame):
5870 * w32uniscribe.c (initialized, uniscribe_font_driver):
5871 Remove unneeded extern declarations.
5873 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5875 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5877 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5879 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5880 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5881 These macros can no longer be used for assignment.
5883 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5884 Assign struct members directly, instead of using BUF_BEGV etc.
5885 (record_buffer_markers, fetch_buffer_markers): New functions for
5886 recording and fetching special buffer markers.
5887 (set_buffer_internal_1, set_buffer_temp): Use them.
5889 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5891 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5893 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5894 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5896 * xdisp.c (hscroll_window_tree):
5897 (reconsider_clip_changes): Use PT instead of BUF_PT.
5899 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5901 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5902 $(EMACS_ROOT)/lib/intprops.h.
5904 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5906 Fix more problems found by GCC 4.5.2's static checks.
5908 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5909 to unsigned char * to avoid compiler diagnostic.
5910 (xg_free_frame_widgets): Make it clear that a local variable is
5911 needed only if USE_GTK_TOOLTIP.
5912 (gdk_window_get_screen): Make it clear that this macro is needed
5913 only if USE_GTK_TOOLTIP.
5914 (int_gtk_range_get_value): New function, which avoids a diagnostic
5915 from gcc -Wbad-function-cast.
5916 (xg_set_toolkit_scroll_bar_thumb): Use it.
5917 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5918 diagnostic from gcc -Wbad-function-cast.
5919 (get_utf8_string, xg_get_file_with_chooser):
5920 Rename locals to avoid shadowing.
5921 (create_dialog): Move locals to avoid shadowing.
5923 * xgselect.c (xg_select): Remove unused var.
5925 * image.c (four_corners_best): Mark locals as initialized.
5926 (gif_load): Initialize transparent_p to zero (Bug#8238).
5927 Mark another local as initialized.
5928 (my_png_error, my_error_exit): Mark with NO_RETURN.
5930 * image.c (clear_image_cache): Now static.
5931 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5932 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5933 (x_edge_detection): Remove unnecessary cast that
5934 gcc -Wbad-function-cast diagnoses.
5935 (gif_load): Fix pointer signedness.
5936 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5937 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5939 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5941 Improve quality of tests for time stamp overflow.
5942 For example, without this patch (encode-time 0 0 0 1 1
5943 1152921504606846976) returns the obviously-bogus value (-948597
5944 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5945 reports time overflow. See
5946 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5947 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5948 * editfns.c: Include limits.h and intprops.h.
5949 (TIME_T_MIN, TIME_T_MAX): New macros.
5950 (time_overflow): Move earlier, to before first use.
5951 (hi_time, lo_time): New functions, for an accurate test for
5953 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5954 (Fget_internal_run_time): Don't assume time_t fits in int.
5955 (make_time): Use list2 instead of Fcons twice.
5956 (Fdecode_time): More accurate test for out-of-range times.
5957 (check_tm_member): New function.
5958 (Fencode_time): Use it, to test for out-of-range times.
5959 (lisp_time_argument): Don't rely on undefined left-shift and
5960 right-shift behavior when checking for time stamp overflow.
5962 * editfns.c (time_overflow): New function, refactoring common code.
5963 (Fformat_time_string, Fdecode_time, Fencode_time):
5964 (Fcurrent_time_string): Use it.
5966 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5967 * dired.c (make_time): Move to ...
5968 * editfns.c (make_time): ... here.
5969 * systime.h: Note the move.
5971 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5973 * fringe.c (update_window_fringes): Remove unused variables.
5975 * unexmacosx.c (copy_data_segment): Also copy __got section.
5978 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5980 * termcap.c [MSDOS]: Include "msdos.h".
5981 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5982 Constify `char *' arguments and their references according to
5983 prototypes in tparam.h.
5985 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5987 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5988 Adapt all references accordingly.
5990 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5992 2011-03-11 Tom Tromey <tromey@redhat.com>
5994 * buffer.c (syms_of_buffer): Remove obsolete comment.
5996 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5998 * termhooks.h (encode_terminal_code): Declare prototype.
6000 * msdos.c (encode_terminal_code): Don't declare prototype.
6002 * term.c (encode_terminal_code): Now external again, used by
6003 w32console.c and msdos.c.
6005 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6006 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6008 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6010 Fix some minor problems found by GCC 4.5.2's static checks.
6012 * fringe.c (update_window_fringes): Mark locals as initialized
6014 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6016 * alloc.c (mark_fringe_data): Move decl from here ...
6017 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6018 to check its interface.
6019 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6021 * fontset.c (free_realized_fontset): Now static.
6022 (Fset_fontset_font): Rename local to avoid shadowing.
6023 (fontset_font): Mark local as initialized.
6024 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6026 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6028 * xselect.c (x_disown_buffer_selections): Remove; not used.
6029 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6030 (x_own_selection, Fx_disown_selection_internal): Rename locals
6032 (x_handle_dnd_message): Remove local to avoid shadowing.
6034 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6035 so that the caller can use some name other than gcpro1.
6036 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6037 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6038 (Fx_backspace_delete_keys_p):
6039 Use them to avoid shadowing, and rename vars to avoid shadowing.
6040 (x_decode_color, x_set_name, x_window): Now static.
6041 (Fx_create_frame): Add braces to silence GCC warning.
6042 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6043 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6044 Remove unused locals.
6045 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6046 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6047 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6050 * xterm.h (x_mouse_leave): New decl.
6052 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6053 Remove unused functions.
6054 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6055 (x_calc_absolute_position): Now static.
6056 (XTread_socket): Don't define label "out" unless it's used.
6057 Don't declare local "event" unless it's used.
6058 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6059 unless they are used.
6060 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6061 (x_fatal_error_signal): Remove; not used.
6062 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6063 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6064 (x_error_catcher, x_connection_closed, x_error_handler):
6065 (x_error_quitter, xembed_send_message, x_iconify_frame):
6066 (my_log_handler): Rename locals to avoid shadowing.
6067 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6068 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6070 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6071 Rename or move locals to avoid shadowing.
6072 (tty_defined_color, merge_face_heights): Now static.
6073 (free_realized_faces_for_fontset): Remove; not used.
6074 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6075 does not deduce is never used uninitialized.
6076 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6077 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6079 * terminal.c (store_terminal_param): Now static.
6081 * xmenu.c (menu_highlight_callback): Now static.
6082 (set_frame_menubar): Remove unused local.
6083 (xmenu_show): Rename parameter to avoid shadowing.
6084 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6085 since they might point to immutable storage.
6086 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6087 since it's unused otherwise.
6089 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6090 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6091 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6092 avoids a gcc -Wuninitialized diagnostic.
6093 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6094 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6095 does not deduce are never used uninitialized.
6097 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6099 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6100 * window.c (window_loop, size_window):
6101 (run_window_configuration_change_hook, enlarge_window): Likewise.
6103 * window.c (display_buffer): Now static.
6104 (size_window): Mark variables that gcc -Wuninitialized
6105 does not deduce are never used uninitialized.
6106 * window.h (check_all_windows): New decl, to forestall
6107 gcc -Wmissing-prototypes diagnostic.
6108 * dispextern.h (bidi_dump_cached_states): Likewise.
6110 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6112 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6114 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6115 and to avoid gcc -Wuninitialized warning.
6116 (load_charset_map): Mark variables that gcc -Wuninitialized
6117 does not deduce are never used uninitialized.
6118 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6120 * coding.c (coding_set_source, coding_set_destination):
6121 Use "else { /* comment */ }" rather than "else /* comment */;"
6122 for clarity, and to avoid gcc -Wempty-body warning.
6123 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6124 a block, when the outer 'i' will do.
6125 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6126 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6127 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6128 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6129 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6130 Rename locals to avoid shadowing.
6131 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6132 * coding.c (emacs_mule_char, encode_invocation_designation):
6133 Now static, since they're not used elsewhere.
6134 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6135 (decode_coding_object, encode_coding_object, detect_coding_system):
6136 (decode_coding_emacs_mule): Mark variables that gcc
6137 -Wuninitialized does not deduce are never used uninitialized.
6138 (detect_coding_iso_2022): Initialize a local variable that might
6139 be used uninitialized. Leave a FIXME because it's not clear that
6140 this initialization is needed. (Bug#8211)
6141 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6142 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6143 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6144 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6145 Remove unused macros.
6147 * category.c (hash_get_category_set): Remove unused local var.
6148 (copy_category_table): Now static, since it's not used elsewhere.
6149 * character.c (string_count_byte8): Likewise.
6151 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6152 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6154 * chartab.c (copy_sub_char_table): Now static, since it's not used
6156 (sub_char_table_ref_and_range, char_table_ref_and_range):
6157 Rename locals to avoid shadowing.
6158 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6160 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6161 (BIDI_BOB): Remove unused macro.
6163 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6164 deduce are never used uninitialized.
6165 * term.c (encode_terminal_code): Likewise.
6167 * term.c (encode_terminal_code): Now static. Remove unused local.
6169 * tparam.h: New file.
6170 * term.c, tparam.h: Include it.
6171 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6172 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6173 Move these decls to tparam.h, and make them agree with what
6174 is actually in tparam.c. The previous trick of using incompatible
6175 decls in different modules does not conform to the C standard.
6176 All callers of tparam changed to use tparam's actual API.
6177 * tparam.c (tparam1, tparam, tgoto):
6178 Use const pointers where appropriate.
6180 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6181 * cm.h (struct cm): Likewise.
6182 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6183 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6184 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6185 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6186 (turn_on_face, init_tty): Likewise.
6187 * termchar.h (struct tty_display_info): Likewise.
6189 * term.c (term_mouse_position): Rename local to avoid shadowing.
6191 * alloc.c (mark_ttys): Move decl from here ...
6192 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6194 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6196 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6198 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6200 * search.c (compile_pattern_1): Remove argument regp, unused since
6201 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6202 (compile_pattern): Don't pass it.
6204 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6206 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6207 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6209 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6211 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6213 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6214 gdk_window_get_screen, gdk_window_get_geometry,
6215 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6216 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6217 (xg_get_pixbuf_from_pixmap): New function.
6218 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6219 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6220 Call xg_get_pixbuf_from_pixmap instead of
6221 gdk_pixbuf_get_from_drawable.
6222 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6223 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6224 (xg_check_special_colors): Use GtkStyleContext and its functions
6226 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6227 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6228 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6229 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6230 Call gtk_widget_get_preferred_size.
6231 (xg_frame_resized): gdk_window_get_geometry only takes 5
6233 (xg_win_to_widget, xg_event_is_for_menubar):
6234 Call gdk_x11_window_lookup_for_display.
6235 (xg_set_widget_bg): New function.
6236 (delete_cb): New function.
6237 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6238 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6239 (xg_set_background_color): Call xg_set_widget_bg.
6240 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6241 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6242 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6243 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6245 (update_frame_tool_bar): Call gtk_widget_hide.
6246 (xg_initialize): Use GDK_KEY_g.
6248 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6250 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6252 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6253 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6254 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6256 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6258 * w32xfns.c (select_palette): Check success of RealizePalette against
6259 GDI_ERROR, not zero.
6261 See ChangeLog.11 for earlier changes.
6267 Copyright (C) 2011 Free Software Foundation, Inc.
6269 This file is part of GNU Emacs.
6271 GNU Emacs is free software: you can redistribute it and/or modify
6272 it under the terms of the GNU General Public License as published by
6273 the Free Software Foundation, either version 3 of the License, or
6274 (at your option) any later version.
6276 GNU Emacs is distributed in the hope that it will be useful,
6277 but WITHOUT ANY WARRANTY; without even the implied warranty of
6278 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6279 GNU General Public License for more details.
6281 You should have received a copy of the GNU General Public License
6282 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.