Integer overflow fixes for scrolling, etc.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 Integer overflow fixes for scrolling, etc.
4 Without this fix, Emacs silently mishandles large integers sometimes.
5 For example, "C-u 4294967297 M-x recenter" was be treated as if
6 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7
8 * xdisp.c: Integer overflow fix.
9 (try_window_id): Check Emacs fixnum range before converting to 'int'.
10
11 * window.c: Integer overflow fixes.
12 (window_scroll_line_based, Frecenter):
13 Check that an Emacs fixnum is in range before assigning it to 'int'.
14 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
15 values converted from Emacs fixnums.
16 (Frecenter): Don't wrap around a line count if it is out of 'int'
17 range; instead, treat it as an extreme value.
18 (Fset_window_configuration, compare_window_configurations):
19 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
20
21 * search.c: Integer overflow fixes
22 (Freplace_match): Use ptrdiff_t, not int, for indexes that can
23 exceed INT_MAX. Check that EMACS_INT value is in range before
24 assigning it to the (possibly-narrower) index.
25 (match_limit): Don't assume that a fixnum can fit in 'int'.
26
27 * print.c: Integer overflow fix.
28 (print_object): Use ptrdiff_t, not int, for index that can
29 exceed INT_MAX.
30
31 * indent.c: Integer overflow fixes.
32 (position_indentation): Now takes ptrdiff_t, not int.
33 (Fvertical_motion): Don't wrap around LINES values that don't fit
34 in 'int'. Instead, treat them as extreme values. This is good
35 enough for windows, which can't have more than INT_MAX lines anyway.
36
37 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
38
39 * Require libxml/parser.h to avoid compilation warning.
40
41 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
42
43 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
44 since this reportedly can destroy thread storage.
45
46 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
47
48 * syntax.c (find_defun_start): Update all cache variables if
49 exiting early (Bug#9401).
50
51 2011-08-30 Eli Zaretskii <eliz@gnu.org>
52
53 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
54
55 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
56 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
57 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
58
59 * term.c (tty_append_glyph): New function.
60 (produce_stretch_glyph): Static function and its prototype deleted.
61
62 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
63 prototypes.
64
65 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
66
67 * image.c (parse_image_spec): Check for nonnegative, not for positive,
68 when checking :margin (Bug#9390).
69 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
70 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
71 so that the name doesn't mislead. All uses changed.
72
73 2011-08-28 Johan Bockgård <bojohan@gnu.org>
74
75 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
76 set_tty_hooks.
77
78 2011-08-27 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (move_it_to): Don't bail out early when reaching
81 position beyond to_charpos, if we are scanning backwards.
82 (move_it_vertically_backward): When DY == 0, make sure we get to
83 the first character in the line after the newline.
84
85 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
86
87 * ccl.c: Improve and simplify overflow checking (Bug#9196).
88 (ccl_driver): Do not generate an out-of-range pointer.
89 (Fccl_execute_on_string): Remove unnecessary check for
90 integer overflow, noted by Stefan Monnier in
91 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
92 Remove a FIXME that didn't need fixing.
93 Simplify the newly-introduced buffer reallocation code.
94
95 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
96
97 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
98
99 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
100
101 Integer and memory overflow issues (Bug#9196).
102
103 * doc.c (get_doc_string): Rework so that
104 get_doc_string_buffer_size is the actual buffer size, rather than
105 being 1 less than the actual buffer size; this makes xpalloc more
106 convenient.
107
108 * image.c (x_allocate_bitmap_record, cache_image):
109 * xselect.c (Fx_register_dnd_atom):
110 Simplify previous changes by using xpalloc.
111
112 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
113 since either will do and ptrdiff_t is convenient with xpalloc.
114
115 * charset.c (charset_table_size)
116 (struct charset_sort_data.priority): Now ptrdiff_t.
117 (charset_compare): Don't overflow if priorities differ greatly.
118 (Fsort_charsets): Don't assume list length fits in int.
119 Check for size-calculation overflow when allocating sort data.
120 (syms_of_charset): Allocate an initial charset table that is
121 just under 64 KiB, to avoid problems with glibc malloc and mmap.
122
123 * cmds.c (internal_self_insert): Check for size-calculation overflow.
124
125 * composite.h (struct composition.glyph_len): Now int, not unsigned.
126 The actual value is always <= INT_MAX, and leaving it unsigned made
127 overflow checking harder.
128
129 * dispextern.h (struct glyph_matrix.rows_allocated)
130 (struct face_cache.size): Now ptrdiff_t, for convenience in use
131 with xpalloc. The values are still always <= INT_MAX.
132
133 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
134
135 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
136 (SAFE_NALLOCA): New macro.
137
138 * region-cache.c (struct boundary.pos, find_cache_boundary)
139 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
140 (set_cache_region, invalidate_region_cache)
141 (revalidate_region_cache, know_region_cache, region_cache_forward)
142 (region_cache_backward, pp_cache):
143 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
144 so that ptrdiff_t * can be passed to xpalloc.
145 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
146 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
147 (pp_cache): Don't assume cache_len fits in int.
148 * region-cache.h: Adjust extern decls to match.
149
150 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
151 EMACS_INT, since either will do, for xpalloc.
152
153 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
154 (xnmalloc, xnrealloc, xpalloc): New functions.
155
156 * bidi.c (bidi_shelve_header_size): New constant.
157 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
158 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
159
160 * bidi.c (bidi_cache_shrink):
161 * buffer.c (overlays_at, overlays_in, record_overlay_string)
162 (overlay_strings):
163 Don't update size of array until after memory allocation succeeds,
164 because xmalloc/xrealloc may not return.
165 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
166 now that we have proper integer overflow checking.
167 (record_overlay_string, overlay_strings): Catch overflows when
168 calculating size of overlay_str_buf.
169
170 * callproc.c (Fcall_process): Check for size overflow when
171 calculating size of args2.
172 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
173 Normally we prefer signed values, but sticking with ptrdiff_t would
174 require adding more-complicated checks.
175
176 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
177 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
178 Redo buffer-overflow calculations to avoid integer overflow.
179 Add a FIXME comment where memory seems to be over-allocated.
180
181 * character.c (Fstring): Check for size-calculation overflow.
182
183 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
184 unnecessary integer overflow. Check for size overflow.
185 (encode_coding_object): Don't update size until xmalloc succeeds.
186
187 * composite.c (get_composition_id): Check for overflow in glyph
188 length calculations.
189
190 Integer and memory overflow fixes for display code.
191 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
192 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
193 (scrolling_window): Check for overflow in size calculations.
194 (line_draw_cost, realloc_glyph_pool, add_row_entry):
195 Don't assume glyph table len fits in int.
196 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
197 (row_table_size): Now ptrdiff_t, not int.
198 (scrolling_window): Avoid overflow in size calculations.
199 Don't update size until allocation succeeds.
200 * fns.c (concat): Check for overflow in size calculations.
201 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
202 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
203 (NEXT_ALMOST_PRIME_LIMIT): New constant.
204
205 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
206 (get_doc_string): Check for size calculation overflow.
207 Don't update size until allocation succeeds.
208 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
209 EMACS_INT, where ptrdiff_t will do.
210 (Fsubstitute_command_keys): Check for string overflow.
211
212 * editfns.c (set_time_zone_rule): Don't assume environment length
213 fits in int.
214 (message_length): Now ptrdiff_t, not int.
215 (Fmessage_box): Don't update size until allocation succeeds.
216 Don't assume message length fits in int.
217 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
218
219 * emacs.c (main): Do not reallocate argv, since there is a null at
220 the end that can be overwritten, and this way there's no need to
221 worry about size-calculation overflow.
222 (sort_args): Check for size-calculation overflow.
223
224 * eval.c (init_eval_once, grow_specpdl): Don't update size until
225 alloc succeeds.
226 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
227
228 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
229 (x_set_scroll_bar_width, x_figure_window_size):
230 Check for integer overflow.
231 (x_set_alpha): Do not assume XINT fits in int.
232
233 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
234 This is for the members text_lines, text_cols, total_lines, total_cols,
235 where the system imposes an 'int' limit.
236
237 * fringe.c (Fdefine_fringe_bitmap):
238 Don't update size until alloc works.
239
240 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
241 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
242
243 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
244 Check for size-calculation overflow.
245 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
246 do, as we prefer signed integers.
247 (id_to_widget.max_size, id_to_widget.used)
248 (xg_store_widget_in_map, xg_remove_widget_from_map)
249 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
250 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
251 Use and return ptrdiff_t, not int.
252 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
253 * gtkutil.h: Change prototypes to match the above.
254
255 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
256 are duplicate now that they've been promoted to lisp.h.
257 (x_allocate_bitmap_record, x_alloc_image_color)
258 (make_image_cache, cache_image, xpm_load):
259 Don't update size until alloc is done.
260 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
261 (x_detect_edges):
262 Check for size calculation overflow.
263 (ct_colors_allocated_max): New constant.
264 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
265 overflow.
266
267 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
268 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
269 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
270 Use ptrdiff_t, not int, to count maps.
271 (read_char_minibuf_menu_prompt): Check for overflow in size
272 calculations. Don't update size until allocation succeeds. Redo
273 calculations to avoid overflow.
274 * keyboard.h: Change prototypes to match the above.
275
276 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
277 to count maps.
278 (current_minor_maps): Check for size calculation overflow.
279 * keymap.h: Change prototypes to match the above.
280
281 * lread.c (read1, init_obarray): Don't update size until alloc done.
282
283 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
284 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
285
286 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
287 Now ptrdiff_t, not int.
288 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
289 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
290
291 * process.c (Fnetwork_interface_list): Check for overflow
292 in size calculation.
293
294 * region-cache.c (move_cache_gap): Check for size calculation overflow.
295
296 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
297 overflow. Don't bother calling xmalloc when xrealloc will do.
298
299 * search.c (Freplace_match): Check for size calculation overflow.
300 (Fset_match_data): Don't assume list lengths fit in 'int'.
301
302 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
303 for command line length. Do not attempt to address one before the
304 beginning of an array, as that's not portable.
305
306 * term.c (max_frame_lines): Remove; unused.
307 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
308 not int.
309 (encode_terminal_code, calculate_costs): Check for size
310 calculation overflow.
311 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
312 table lengths and related sizes. Don't update size until alloc
313 done. Redo calculations to avoid overflow.
314 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
315
316 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
317 subtracting pointers.
318 (gobble_line): Check for overflow more carefully. Don't update size
319 until alloc done.
320
321 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
322 Don't update size until alloc done.
323 Redo size calculations to avoid overflow.
324 Check for size calculation overflow.
325 (main) [DEBUG]: Fix typo in invoking tparam1.
326
327 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
328 Use ptrdiff_t, not int, for sizes.
329 (store_mode_line_noprop_char): Don't update size until alloc done.
330
331 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
332 Use ptrdiff_t, not int, for sizes.
333 (Finternal_make_lisp_face, cache_face):
334 Check for size calculation overflow.
335 (cache_face): Treat size calculation overflows as if they were
336 memory exhaustion (the usual treatment), rather than aborting.
337
338 * xfns.c (x_encode_text, x_set_name_internal)
339 (Fx_change_window_property): Use ptrdiff_t, not int, to count
340 sizes, since they can exceed INT_MAX in size. Check for size
341 calculation overflow.
342
343 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
344 (xg_select): Check for size calculation overflow.
345 Don't update size until alloc done.
346
347 * xrdb.c (get_environ_db): Don't assume path length fits in int,
348 as sprintf is limited to int lengths.
349
350 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
351 (X_LONG_MIN): New macros.
352 Use them to make the following changes clearer.
353 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
354 This change doesn't affect the value now, but it may help remind
355 future maintainers not to raise the value too much later.
356 (SELECTION_QUANTUM): Remove, replacing with ...
357 (selection_quantum): ... new function, which avoids overflow.
358 All uses changed.
359 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
360 assumption that selection length fits in 'int'.
361 (x_reply_selection_request, x_handle_selection_request)
362 (x_get_window_property, receive_incremental_selection)
363 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
364 (lisp_data_to_selection_data, clean_local_selection_data):
365 Use ptrdiff_t, not int, to record length of selection.
366 (x_reply_selection_request, x_get_window_property)
367 (receive_incremental_selection, x_property_data_to_lisp):
368 Redo calculations to avoid overflow.
369 (x_reply_selection_request): When sending hint, ceiling it at
370 X_LONG_MAX rather than relying on wraparound overflow to send
371 something.
372 (x_get_window_property, receive_incremental_selection)
373 (lisp_data_to_selection_data, x_property_data_to_lisp):
374 Check for size-calculation overflow.
375 (x_get_window_property, receive_incremental_selection)
376 (lisp_data_to_selection_data, Fx_register_dnd_atom):
377 Don't store size until memory allocation succeeds.
378 (x_get_window_property): Plug memory leak on memory exhaustion.
379 Don't double-block input; malloc is safe here. Don't assume 2**34
380 - 4 fits in unsigned long. Add an xassert to check
381 XGetWindowProperty overflow. Be more careful about overflow
382 calculations, and distinguish size from memory overflow better.
383 (receive_incremental_selection): When tracing, don't assume
384 unsigned int is less than INT_MAX.
385 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
386 harmful) conversions of unsigned short to int.
387 (lisp_data_to_selection_data): Don't assume that integers
388 in the range -65535 through -1 fit in an X unsigned short.
389 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
390 result parameters unless successful. Rely on cons_to_unsigned
391 to report problems with elements; the old code wasn't right anyway.
392 (x_check_property_data): Check for int overflow; we cannot use
393 a wider type due to X limits.
394 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
395
396 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
397
398 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
399 (x_term_init): Check for size calculation overflow.
400 (x_color_cells): Don't store size until memory allocation succeeds.
401 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
402 Don't assume alloca size is less than MAX_ALLOCA.
403 (x_term_init): Don't assume length fits in int (sprintf is limited
404 to int size).
405
406 Use ptrdiff_t for composition IDs.
407 * character.c (lisp_string_width):
408 * composite.c (composition_table_size, n_compositions)
409 (get_composition_id, composition_gstring_from_id):
410 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
411 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
412 * window.c (Frecenter):
413 Use ptrdiff_t, not int, for composition IDs.
414 * composite.c (get_composition_id): Check for integer overflow.
415 * composite.h: Adjust prototypes to match the above changes.
416
417 Use ptrdiff_t for hash table indexes.
418 * category.c (hash_get_category_set):
419 * ccl.c (ccl_driver):
420 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
421 * coding.c (coding_system_charset_list, detect_coding_system):
422 * coding.h (struct coding_system.id):
423 * composite.c (get_composition_id, gstring_lookup_cache):
424 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
425 * image.c (xpm_get_color_table_h):
426 * lisp.h (hash_lookup, hash_put):
427 * minibuf.c (Ftest_completion):
428 Use ptrdiff_t for hash table indexes, not int (which is too
429 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
430 32-bit --with-wide-int hosts).
431
432 * charset.c (Fdefine_charset_internal): Check for integer overflow.
433 Add a FIXME comment about memory leaks.
434 (syms_of_charset): Don't assume xmalloc returns.
435
436 Don't assume that stated character widths fit in int.
437 * character.c (Fchar_width, c_string_width, lisp_string_width):
438 * character.h (CHAR_WIDTH):
439 * indent.c (MULTIBYTE_BYTES_WIDTH):
440 Use sanitize_char_width to avoid undefined and/or bad behavior
441 with outlandish widths.
442 * character.h (sanitize_tab_width): Renamed from sanitize_width,
443 now that we have two such functions. All uses changed.
444 (sanitize_char_width): New inline function.
445
446 Don't assume that tab-width fits in int.
447 * character.h (sanitize_width): New inline function.
448 (SANE_TAB_WIDTH): New macro.
449 (ASCII_CHAR_WIDTH): Use it.
450 * indent.c (sane_tab_width): Remove. All uses replaced by
451 SANE_TAB_WIDTH (current_buffer).
452 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
453
454 * fileio.c: Integer overflow issues with file modes.
455 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
456
457 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
458 Remove unreachable code.
459 (read_hex, load_charset_map_from_file): Check for integer overflow.
460
461 * xterm.c: don't go over XClientMessageEvent limit
462 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
463 (x_send_scroll_bar_event): Likewise. Check that the size does not
464 exceed limits imposed by XClientMessageEvent, as well as the usual
465 ptrdiff_t and size_t limits.
466
467 * keyboard.c: Overflow, signedness and related fixes.
468 (make_lispy_movement): Use same integer type in forward decl
469 that is used in the definition.
470 (read_key_sequence, keyremap_step):
471 Change bufsize argument back to int, undoing my 2011-03-30 change.
472 We prefer signed types, and int is wide enough here.
473 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
474 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
475 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
476 length, not size_t. Use ptrdiff_t for index, not int.
477 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
478 possibility of integer overflow.
479
480 Overflow, signedness and related fixes for images.
481
482 * dispextern.h (struct it.stack[0].u.image.image_id)
483 (struct_it.image_id, struct image.id, struct image_cache.size)
484 (struct image_cache.used, struct image_cache.ref_count):
485 * gtkutil.c (update_frame_tool_bar):
486 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
487 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
488 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
489 * nsmenu.m (update_frame_tool_bar):
490 * xdisp.c (calc_pixel_width_or_height):
491 * xfns.c (image_cache_refcount):
492 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
493 on typical 64-bit hosts.
494
495 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
496 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
497 Omit unnecessary casts to int.
498 (parse_image_spec): Check that integers fall into 'int' range
499 when the callers expect that.
500 (image_ascent): Redo ascent calculation to avoid int overflow.
501 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
502 (lookup_image): Remove unnecessary tests.
503 (xbm_image_p): Locals are now of int, not EMACS_INT,
504 since parse_image_check makes sure they fit into int.
505 (png_load, gif_load, svg_load_image):
506 Prefer int to unsigned where either will do.
507 (tiff_handler): New function, combining the cores of the
508 old tiff_error_handler and tiff_warning_handler. This
509 function is rewritten to use vsnprintf and thereby avoid
510 stack buffer overflows. It uses only the features of vsnprintf
511 that are common to both POSIX and native Microsoft.
512 (tiff_error_handler, tiff_warning_handler): Use it.
513 (tiff_load, gif_load, imagemagick_load_image):
514 Don't assume :index value fits in 'int'.
515 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
516 (imagemagick_load_image): Check that crop parameters fit into
517 the integer types that MagickCropImage accepts. Don't assume
518 Vimagemagick_render_type has a nonnegative value. Don't assume
519 size_t fits in 'long'.
520 (gs_load): Use printmax_t to print the widest integers possible.
521 Check for integer overflow when computing image height and width.
522
523 2011-08-26 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (redisplay_window): Don't force window start if point
526 will be invisible in the resulting window. (Bug#9324)
527
528 2011-08-25 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
531 the display spec is of the form `(space ...)'.
532 (handle_display_spec): Return the value returned by
533 handle_single_display_spec, not just 1 or zero.
534 (handle_single_display_spec): If the display spec is of the form
535 `(space ...)', and specifies display in the text area, return 2
536 rather than 1.
537 (try_cursor_movement): Check for the need to scroll more
538 accurately, and prefer exact match for point under bidi. Don't
539 advance `row' beyond the last row of the window.
540
541 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
542 into disp_prop; all users changed.
543
544 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
545 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
546 for the text covered by the display property.
547
548 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
549
550 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
551 Change return value to nil.
552 (Frecord_buffer): Delete unused function.
553
554 2011-08-24 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
557 buffers, return left-to-right.
558 (set_cursor_from_row): Consider candidate row a win if its glyph
559 represents a newline and point is on that newline. Fixes cursor
560 positioning on the newline at EOL of R2L text within L2R
561 paragraph, and vice versa.
562 (try_cursor_movement): Check continued rows, in addition to
563 continuation rows. Fixes unwarranted scroll when point enters a
564 continued line of R2L text within an L2R paragraph, or vice versa.
565 (cursor_row_p): Consider the case of point being equal to
566 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
567 from the end of a short line to the beginning of a continued line
568 of R2L text within L2R paragraph.
569 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
570 composed characters.
571
572 * bidi.c (bidi_check_type): Use xassert.
573 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
574 members.
575
576 2011-08-23 Eli Zaretskii <eliz@gnu.org>
577
578 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
579 a character.
580
581 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
582
583 * nsfont.m (ns_otf_to_script): Fix typo.
584
585 2011-08-22 Kenichi Handa <handa@m17n.org>
586
587 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
588 extra slot even if the purpose is char-code-property-table.
589
590 2011-08-23 Eli Zaretskii <eliz@gnu.org>
591
592 * xdisp.c (redisplay_window): When computing centering_position,
593 account for the height of the header line. (Bug#8874)
594
595 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
596 instead of CHAR_TO_BYTE. Fixes a crash when a completion
597 candidate is selected by the mouse, and that candidate has a
598 composed character under the mouse.
599
600 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
601 coordinates reported by pos-visible-in-window-p for a composed
602 character in column zero.
603
604 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
605
606 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
607
608 2011-08-22 Eli Zaretskii <eliz@gnu.org>
609
610 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
611 consider it a hit if to_charpos is anywhere in the range of the
612 composed buffer positions.
613
614 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
615
616 * image.c (gif_load): Don't assume that each subimage has the same
617 dimensions as the base image. Handle disposal method that is
618 "undefined" by the gif spec (Bug#9335).
619
620 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
621
622 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
623 (Fcondition_case): Document `debug' symbol in error handler.
624
625 2011-08-19 Eli Zaretskii <eliz@gnu.org>
626
627 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
628 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
629 from an Org mode buffer to a Speedbar frame.
630
631 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
632 a composition, take its buffer position from IT->cmp_it.charpos.
633 Fixes cursor positioning at the beginning of a line that begins
634 with a composed character.
635
636 2011-08-18 Eli Zaretskii <eliz@gnu.org>
637
638 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
639 character bidirectional type, use STRONG_L instead. Fixes crashes
640 in a buffer produced by `describe-categories'.
641
642 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
643 members before the level stack, so they would be saved and
644 restored when copying iterator state. Fixes incorrect reordering
645 around TABs covered by display properties.
646
647 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
648
649 * process.c (Fnetwork_interface_list): Correctly determine buffer
650 size.
651
652 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
653
654 * eval.c (internal_condition_case, internal_condition_case_1)
655 (internal_condition_case_2, internal_condition_case_n):
656 Remove unnecessary aborts (Bug#9081).
657
658 2011-08-17 Eli Zaretskii <eliz@gnu.org>
659
660 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
661 has no `load' handler, try opening the file locally. (Bug#9311)
662
663 2011-08-16 Ken Brown <kbrown@cornell.edu>
664
665 * gmalloc.c: Expand comment.
666
667 2011-08-16 Eli Zaretskii <eliz@gnu.org>
668
669 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
670 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
671
672 2011-08-16 Ken Brown <kbrown@cornell.edu>
673
674 Fix memory allocation problems in Cygwin build (Bug#9273).
675
676 * unexcw.c ( __malloc_initialized): Declare external variable.
677 (fixup_executable): Force the dumped emacs to reinitialize malloc.
678
679 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
680 New variables.
681 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
682 dumped emacs.
683 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
684 in the static heap.
685 [CYGWIN] (special_realloc): New function.
686 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
687 requests to realloc storage in the static heap.
688
689 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
690
691 * bidi.c (bidi_initialize): Remove unused local.
692
693 2011-08-15 Eli Zaretskii <eliz@gnu.org>
694
695 * biditype.h: File removed.
696
697 * bidimirror.h: File removed.
698
699 * deps.mk (bidi.o): Remove biditype.h and
700 bidimirror.h.
701
702 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
703 bidimirror.h.
704
705 * dispextern.h: Fix a typo in the comment to bidi_type_t.
706
707 * chartab.c: Improve commentary for the uniprop_table API.
708
709 * bidi.c (bidi_paragraph_init): Support zero value of
710 bidi_ignore_explicit_marks_for_paragraph_level.
711 (bidi_initialize): Use uniprop_table instead of including
712 biditype.h and bidimirror.h.
713
714 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
715 coordinates of the iterator when restoring from ppos_it.
716 (Bug#9296)
717
718 2011-08-14 Kenichi Handa <handa@m17n.org>
719
720 * process.c (create_process): Call setup_process_coding_systems
721 after the pid of the process is set to -1 (Bug#8162).
722
723 2011-08-14 Eli Zaretskii <eliz@gnu.org>
724
725 * xdisp.c (move_it_in_display_line_to): Don't invoke
726 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
727 ppos_it. Fixes vertical cursor motion when line beginning is
728 covered by an image. (Bug#9296)
729
730 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
731
732 * nsterm.h (ns_run_ascript): Declare.
733 (NSAPP_DATA2_RUNASSCRIPT): Define.
734
735 * nsfns.m (as_script, as_result, as_status): New static variables.
736 (ns_run_ascript): New function.
737 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
738 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
739 the event loop. Get status from as_status (Bug#7276).
740
741 * nsterm.m (sendEvent): If event is NSApplicationDefined and
742 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
743 the event loop (Bug#7276).
744
745 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
746
747 * gnutls.c (QCgnutls_bootprop_priority)
748 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
749 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
750 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
751 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
752 (QCgnutls_bootprop_verify_hostname_error)
753 (QCgnutls_bootprop_callbacks_verify): Rename from
754 Qgnutls_bootprop_..., all uses changed.
755
756 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
757 uses changed.
758
759 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
760
761 * xfaces.c (Qframe_set_background_mode): Now static.
762 * dispextern.h (Qframe_set_background_mode): Remove decl.
763
764 * process.c (Fnetwork_interface_info): Declare local only if needed.
765
766 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
767
768 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
769 (Fnetwork_interface_list): Allocate in increments of bytes instead
770 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
771 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
772 sockaddr.
773 (struct ifflag_def): notrailers is smart on OSX.
774 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
775 Get hardware address with getifaddrs if available.
776
777 2011-08-12 Eli Zaretskii <eliz@gnu.org>
778
779 * xdisp.c (iterate_out_of_display_property): xassert that
780 IT->position is set to within IT->object's boundaries. Break from
781 the loop as soon as EOB is reached; avoids infloops in redisplay
782 when IT->position is set up wrongly due to some bug.
783 Set IT->current to match the bidi iterator unconditionally.
784 (push_display_prop): Allow GET_FROM_STRING as IT->method on
785 entry. Force push_it to save on the stack the current
786 buffer/string position, to be restored by pop_it. Fix flags in
787 the iterator structure wrt the object coming from a display
788 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
789 properties. (Bug#9284)
790
791 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
792
793 * fontset.c (fontset_get_font_group): Add proper type checks.
794 (Bug#9172)
795
796 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
797
798 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
799 and LC_VERSION_MIN_MACOSX.
800 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
801 (dump_it) [LC_FUNCTION_STARTS]: Use it.
802
803 2011-08-08 Eli Zaretskii <eliz@gnu.org>
804
805 * xdisp.c (forward_to_next_line_start): Allow to use the
806 no-display-properties-and-no-overlays under bidi display.
807 Set disp_pos in the bidi iterator to avoid searches for display
808 properties and overlays.
809
810 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
811
812 * editfns.c (Fset_time_zone_rule): Document relationship with the
813 setenv function.
814
815 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
816 the font entity extracted from the cache (Bug#8109).
817
818 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
819
820 * composite.c (autocmp_chars): Don't reset point. That is done by
821 restore_point_unwind (Bug#5984).
822
823 2011-08-07 Juri Linkov <juri@jurta.org>
824
825 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
826 to show the arg `TIME' instead of `TIMEVAL'.
827
828 2011-08-06 Eli Zaretskii <eliz@gnu.org>
829
830 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
831 display property strides EOL and includes a newline, as in
832 longlines-mode. (Bug#9254)
833 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
834 word-wrap under bidirectional display. (Bug#9224)
835
836 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
837 is non-zero, even if the data buffer is NULL. Fixes a crash in
838 vertical-motion with longlines-mode. (Bug#9254)
839
840 2011-08-05 Eli Zaretskii <eliz@gnu.org>
841
842 * bidi.c <bidi_cache_total_alloc>: Now static.
843 (bidi_initialize): Initialize bidi_cache_total_alloc.
844
845 * xdisp.c (display_line): Release buffer allocated for shelved bidi
846 cache. (Bug#9221)
847
848 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
849 amount allocated this far in `bidi_cache_total_alloc'.
850 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
851 non-zero, only free the data buffer without restoring the cache
852 contents. All callers changed.
853
854 * dispextern.h (bidi_unshelve_cache): Update prototype.
855
856 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
857 (move_it_in_display_line, move_it_to)
858 (move_it_vertically_backward, move_it_by_lines): Replace the call
859 to xfree to an equivalent call to bidi_unshelve_cache.
860 (move_it_in_display_line_to): Fix logic of returning
861 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
862
863 2011-08-05 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
866 came from a string character with a `cursor' property. (Bug#9229)
867
868 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
869
870 * Makefile.in (LIB_PTHREAD): New variable.
871 (LIBES): Add LIB_PTHREAD (Bug#9216).
872
873 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
874 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
875
876 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
877
878 * regex.c (re_iswctype): Remove some redundant boolean
879 conversions.
880
881 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
882
883 * xterm.c (x_find_topmost_parent): New function.
884 (x_set_frame_alpha): Find topmost parent window with
885 x_find_topmost_parent and set the property there also (bug#9181).
886 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
887
888 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
889
890 * callproc.c (Fcall_process): Avoid vfork clobbering
891 the local vars buffer, coding_systems, current_dir.
892
893 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
894
895 * keymap.c (Fmake_composed_keymap): Move to subr.el.
896
897 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
898
899 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
900 so that it is not optimized away.
901
902 * xdisp.c (compute_display_string_pos): Remove unused local.
903
904 2011-08-02 Eli Zaretskii <eliz@gnu.org>
905
906 Fix slow cursor motion and scrolling in large buffers with
907 selective display, like Org Mode buffers. (Bug#9218)
908
909 * dispextern.h (struct bidi_it): New member disp_prop_p.
910
911 * xdisp.c: Remove one-slot cache of display string positions.
912 (compute_display_string_pos): Accept an additional argument
913 DISP_PROP_P; callers changed. Scan at most 5K characters forward
914 for a display string or property. If found, set DISP_PROP_P
915 non-zero.
916
917 * bidi.c (bidi_fetch_char): Accept an additional argument
918 DISP_PROP_P, and pass it to compute_display_string_pos.
919 Only handle text covered by a display string if DISP_PROP_P is returned
920 non-zero. All callers of bidi_fetch_char changed.
921
922 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
923
924 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
925
926 2010-12-03 Don March <don@ohspite.net>
927
928 * keymap.c (Fdefine_key): Fix non-prefix key error message when
929 last character M-[char] is translated to ESC [char] (bug#7541).
930
931 2011-08-02 Kenichi Handa <handa@m17n.org>
932
933 * lisp.h (uniprop_table): Extern it.
934
935 * chartab.c (uniprop_table): Make it non-static.
936
937 2011-08-01 Eli Zaretskii <eliz@gnu.org>
938
939 * xdisp.c (forward_to_next_line_start): Accept additional argument
940 BIDI_IT_PREV, and store into it the state of the bidi iterator had
941 on the newline.
942 (reseat_at_next_visible_line_start): Use the bidi iterator state
943 returned by forward_to_next_line_start to restore the state of
944 it->bidi_it after backing up to previous newline. (Bug#9212)
945
946 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
947
948 * regex.c (re_comp): Protoize.
949 (re_exec): Fix return type.
950 (regexec): Fix type of `ret'. (Bug#9203)
951
952 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
953
954 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
955 This is needed if max-image-size is a floating-point number.
956
957 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
958
959 * print.c (print_object): Print empty symbol as ##.
960
961 * lread.c (read1): Read ## as empty symbol.
962
963 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
964
965 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
966 setting frame foreground color (Bug#9175).
967 (x_set_background_color): Likewise.
968
969 * nsmenu.m (-setText): Size tooltip dimensions precisely to
970 contents (Bug#9176).
971 (EmacsTooltip -init): Remove bezels and add shadows to
972 tooltip windows.
973
974 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
975 or scroll bar (Bug#8470).
976
977 * nsfont.m (nsfont_open): Remove assignment to voffset and
978 unnecessary vars hshink, expand, hd, full_height, min_height.
979 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
980
981 * nsterm.h (nsfont_info): Remove voffset field.
982
983 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
984
985 Implement strike-through and overline on NextStep (Bug#8863).
986
987 * nsfont.m (nsfont_open): Use underline position provided by font,
988 instead of hard-coded value of 2.
989 (nsfont_draw): Call ns_draw_text_decoration instead.
990
991 * nsterm.h: Add declaration for ns_draw_text_decoration.
992
993 * nsterm.m (ns_draw_text_decoration): New function for drawing
994 underline, overline, and strike-through.
995 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
996 ns_draw_text_decoration. Change treatment of cursor drawing to
997 accomodate underlining, etc.
998
999 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1000
1001 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1002 default.
1003
1004 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1007 Without this fix, if a signal arrives just after memory fills up,
1008 'malloc' might be invoked reentrantly.
1009
1010 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1011 In other words, assume that every image size is allowed, on non-X
1012 hosts. This assumption is probably wrong, but it lets Emacs compile.
1013
1014 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1015
1016 * regex.c (re_iswctype): Convert return values to boolean.
1017
1018 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1019
1020 * xdisp.c (compute_display_string_pos): Don't use cached display
1021 string position if the buffer had its restriction changed.
1022 (Bug#9184)
1023
1024 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1027
1028 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1029
1030 Integer signedness and overflow and related fixes. (Bug#9079)
1031
1032 * bidi.c: Integer size and overflow fixes.
1033 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1034 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1035 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1036 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1037 (bidi_find_other_level_edge):
1038 Use ptrdiff_t instead of EMACS_INT where either will do.
1039 This works better on 32-bit hosts configured --with-wide-int.
1040 (bidi_cache_ensure_space): Check for size-calculation overflow.
1041 Use % rather than repeated addition, for better worst-case speed.
1042 Don't set bidi_cache_size until after xrealloc returns, because it
1043 might not return.
1044 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1045 (bidi_cache_ensure_space): Also check that the bidi cache size
1046 does not exceed that of the largest Lisp string or buffer. See Eli
1047 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1048
1049 * alloc.c (__malloc_size_t): Remove.
1050 All uses replaced by size_t. See Andreas Schwab's note
1051 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1052
1053 * image.c: Improve checking for integer overflow.
1054 (check_image_size): Assume that f is nonnull, since
1055 it is always nonnull in practice. This is one less thing to
1056 worry about when checking for integer overflow later.
1057 (x_check_image_size): New function, which checks for integer
1058 overflow issues inside X.
1059 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1060 This removes the need for a memory_full check.
1061 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1062 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1063 (xbm_read_bitmap_data): Change locals back to 'int', since
1064 their values must fit in 'int'.
1065 (xpm_load_image, png_load, tiff_load):
1066 Invoke x_create_x_image_and_pixmap earlier,
1067 to avoid much needless work if the image is too large.
1068 (tiff_load): Treat overly large images as if
1069 x_create_x_image_and_pixmap failed, not as malloc failures.
1070 (gs_load): Use x_check_image_size.
1071
1072 * gtkutil.c: Omit integer casts.
1073 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1074 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1075
1076 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1077
1078 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1079 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1080 would wrongly return t on a 64-bit host.
1081
1082 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1083 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1084 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1085 and therefore cause GCC to emit a bogus diagnostic in some cases.
1086
1087 * image.c: Integer signedness and overflow and related fixes.
1088 This is not an exhaustive set of fixes, but it's time to
1089 record what I've got.
1090 (lookup_pixel_color, check_image_size): Remove redundant decls.
1091 (check_image_size): Don't assume that arbitrary EMACS_INT values
1092 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1093 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1094 (tiff_load, imagemagick_load_image):
1095 Check for overflow in size calculations.
1096 (x_create_x_image_and_pixmap): Remove unnecessary test for
1097 xmalloc returning NULL; that can't happen.
1098 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1099 (xpm_color_bucket): Use better integer hashing function.
1100 (xpm_cache_color): Don't possibly over-allocate memory.
1101 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1102 (gif_memory_source):
1103 Use ptrdiff_t, not int or size_t, to record sizes.
1104 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1105 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1106 either works, as we prefer signed integers.
1107 (tiff_read_from_memory, tiff_write_from_memory):
1108 Return tsize_t, not size_t, since that's what the TIFF API wants.
1109 (tiff_read_from_memory): Don't fail simply because the read would
1110 go past EOF; instead, return a short read.
1111 (tiff_load): Omit no-longer-needed casts.
1112 (Fimagemagick_types): Don't assume size fits into 'int'.
1113
1114 Improve hashing quality when configured --with-wide-int.
1115 * fns.c (hash_string): New function, taken from sxhash_string.
1116 Do not discard information about ASCII character case; this
1117 discarding is no longer needed.
1118 (sxhash-string): Use it. Change sig to match it. Caller changed.
1119 * lisp.h: Declare it.
1120 * lread.c (hash_string): Remove, since we now use fns.c's version.
1121 The fns.c version returns a wider integer if --with-wide-int is
1122 specified, so this should help the quality of the hashing a bit.
1123
1124 * emacs.c: Integer overflow minor fix.
1125 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1126 Define only if GNU_LINUX.
1127 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1128
1129 * dispnew.c: Integer signedness and overflow fixes.
1130 Remove unnecessary forward decls, that were a maintenance hassle.
1131 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1132 All uses changed.
1133 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1134 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1135 (prepare_desired_row, line_draw_cost):
1136 Use int, not unsigned, where either works.
1137 (save_current_matrix, restore_current_matrix):
1138 Use ptrdiff_t, not size_t, where either works.
1139 (init_display): Check for overflow more accurately, and without
1140 relying on undefined behavior.
1141
1142 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1143 Remove, replacing with the new symbols in lisp.h. All uses changed.
1144 * fileio.c (make_temp_name):
1145 * filelock.c (lock_file_1, lock_file):
1146 * xdisp.c (message_dolog):
1147 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1148 Use pMd etc. instead.
1149 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1150 replacing the pWIDE etc. symbols removed from editfns.c.
1151
1152 * keyboard.h (num_input_events): Now uintmax_t.
1153 This is (very slightly) less likely to mess up due to wraparound.
1154 All uses changed.
1155
1156 * buffer.c: Integer signedness fixes.
1157 (alloc_buffer_text, enlarge_buffer_text):
1158 Use ptrdiff_t rather than size_t when either will do, as we prefer
1159 signed integers.
1160
1161 * alloc.c: Integer signedness and overflow fixes.
1162 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1163 (__malloc_size_t): Default to size_t, not to int.
1164 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1165 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1166 Prefer ptrdiff_t to size_t when either would do, as we prefer
1167 signed integers.
1168 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1169 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1170 Now const. Initialize with values that are in range even if char
1171 is signed.
1172 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1173 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1174 These functions do the right thing with sizes > 2**32.
1175 (check_depth): Now ptrdiff_t, not int.
1176 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1177 Adjust to new way of storing sizes. Check for size overflow bugs
1178 in rest of code.
1179 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1180 slightly wrong anyway, as it missed one instance of
1181 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1182 (refill_memory_reserve): Omit needless cast to size_t.
1183 (mark_object_loop_halt): Mark as externally visible.
1184
1185 * xselect.c: Integer signedness and overflow fixes.
1186 (Fx_register_dnd_atom, x_handle_dnd_message):
1187 Use ptrdiff_t, not size_t, since we prefer signed.
1188 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1189 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1190 x_dnd_atoms_size and x_dnd_atoms_length.
1191
1192 * doprnt.c: Prefer signed to unsigned when either works.
1193 * eval.c (verror):
1194 * doprnt.c (doprnt):
1195 * lisp.h (doprnt):
1196 * xdisp.c (vmessage):
1197 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1198 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1199 prefer signed arithmetic to avoid comparison confusion.
1200 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1201 but is a bit tricky.
1202
1203 Assume freestanding C89 headers, string.h, stdlib.h.
1204 * data.c, doprnt.c, floatfns.c, print.c:
1205 Include float.h unconditionally.
1206 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1207 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1208 * regex.c: Likewise for stddef.h, string.h.
1209 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1210 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1211 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1212 (STDC_HEADERS): Remove obsolete defines.
1213 * sysdep.c: Include limits.h unconditionally.
1214
1215 Assume support for memcmp, memcpy, memmove, memset.
1216 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1217 * regex.c (memcmp, memcpy):
1218 Remove; we assume C89 now.
1219
1220 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1221 (__malloc_safe_bcopy): Remove; no longer needed.
1222
1223 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1224 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1225 well either way, and we prefer signed to unsigned.
1226
1227 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1228
1229 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1230 closes the connection while we're reading (bug#9182).
1231
1232 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1233
1234 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1235 are specified (Bug#9168).
1236
1237 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1240 Found by GCC static checking and --with-wide-int on a 32-bit host.
1241
1242 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1243
1244 * xdisp.c (compute_display_string_pos): Fix logic of caching
1245 previous display string position. Initialize cached_prev_pos to
1246 -1. Fixes slow-down at the beginning of a buffer.
1247
1248 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1249
1250 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1251 for attrs[LFACE_FONTSET_INDEX].
1252
1253 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 * xml.c (parse_region): Remove unused local
1256 that was recently introduced.
1257
1258 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1261 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1262
1263 * xdisp.c (move_it_in_display_line_to): Record the best matching
1264 position for TO_CHARPOS while scanning the line, and restore it on
1265 exit if none of the characters scanned was an exact match.
1266 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1267 when exact match is impossible due to invisible text, and the
1268 lines are truncated.
1269
1270 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1271
1272 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1273 for OSX >= 10.7.
1274
1275 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1276
1277 Fix a significant slow-down of cursor motion with C-n, C-p,
1278 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1279 auto-repeat under bidi redisplay in fontified buffers.
1280 * xdisp.c (compute_stop_pos_backwards): New function.
1281 (next_element_from_buffer): Call compute_stop_pos_backwards to
1282 find a suitable prev_stop when we find ourselves before
1283 base_level_stop.
1284 (reseat): Don't look for prev_stop, as that could mean a very long
1285 run.
1286 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1287 <cached_disp_overlay_modiff>: Cache for last found display string
1288 position.
1289 (compute_display_string_pos): Return the cached position if asked
1290 about the same buffer in the same area of character positions, and
1291 the buffer wasn't changed since the time the display string
1292 position was cached.
1293
1294 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1295
1296 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1297 is an integer, which is important for empty lines. (Bug#9149)
1298
1299 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1300
1301 * frame.c (Fmodify_frame_parameters): In tty case, update the
1302 default face if necessary (Bug#4238).
1303
1304 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1305
1306 * editfns.c (Fstring_to_char): No need to explain what a character
1307 is in the docstring (Bug#6576).
1308
1309 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1310
1311 * xml.c (parse_region): Make sure we always return a tree.
1312
1313 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1314
1315 * xml.c (parse_region): If a document contains only comments,
1316 return that, too.
1317
1318 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1319
1320 * xml.c (make_dom): Return comments, too.
1321
1322 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 Port to OpenBSD.
1325 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1326 and the surrounding thread.
1327 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1328 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1329 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1330 timer goes off.
1331 * s/openbsd.h (BROKEN_SIGIO): Define.
1332 * unexelf.c (unexec) [__OpenBSD__]:
1333 Don't update the .mdebug section of the Alpha COFF symbol table.
1334
1335 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1336
1337 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1338 (bug#8460).
1339
1340 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1343 This fixes some race conditions on the permissions of any newly
1344 created file.
1345
1346 * alloc.c (valid_pointer_p): Use pipe, not open.
1347 This fixes some permissions issues when debugging.
1348
1349 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1350 If fchown fails to set both uid and gid, try to set just gid,
1351 as that is sometimes allowed. Adjust the file's mode to eliminate
1352 setuid or setgid bits that are inappropriate if fchown fails.
1353
1354 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1355
1356 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1357 to compare Lisp_Objects.
1358 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1359 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1360 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1361
1362 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1363
1364 * lread.c (read_integer): Unread even EOF character.
1365 (read1): Likewise. Properly record start position of symbol.
1366
1367 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1368 symbol character follows.
1369
1370 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1373 This works around a problem with the previous change to Fcopy_file.
1374 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1375 and without this change, GCC might complain about discarding
1376 fchown's return value.
1377
1378 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1381
1382 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1385
1386 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1387
1388 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1389 it's used from the C level.
1390
1391 * process.c: Use the same condition for POLL_FOR_INPUT in both
1392 keyboard.c and process.c (bug#1858).
1393
1394 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1395
1396 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1397 (Fgnutls_boot): Use it.
1398
1399 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1400
1401 * doc.c (Fsubstitute_command_keys): Revert last change.
1402
1403 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1404
1405 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1406 quotes the next character, and doesn't affect other longer
1407 sequences (bug#8935).
1408
1409 * lread.c (syms_of_lread): Clarify that is isn't only
1410 `eval-buffer' and `eval-defun' that's affected by
1411 `lexical-binding' (bug#8460).
1412
1413 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1416 bidi redisplay when a line includes both an image and is
1417 truncated.
1418
1419 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 Fix minor problems found by static checking.
1422 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1423 (elsz): Now a signed constant, not a size_t var. We prefer signed
1424 types to unsigned, to avoid integer comparison confusion. Without
1425 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1426 "cannot optimize loop, the loop counter may overflow", a symptom
1427 of the confusion.
1428 * indent.c (Fvertical_motion): Mark locals as initialized.
1429 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1430
1431 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1432
1433 * search.c (Fre_search_backward): Mention `case-fold-search' in
1434 all the re_search_* functions (bug#8138).
1435
1436 * keyboard.c (Fopen_dribble_file): Document when the file is
1437 closed (bug#8056).
1438
1439 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1440
1441 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1442 bidi_cache_idx.
1443
1444 Support bidi reordering of display and overlay strings.
1445 * xdisp.c (compute_display_string_pos)
1446 (compute_display_string_end): Accept additional argument STRING.
1447 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1448 (reseat_to_string): Initialize bidi_it->string.s and
1449 bidi_it->string.schars.
1450 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1451 NULL (avoids a crash in bidi_paragraph_init).
1452 Initialize itb.string.lstring.
1453 (init_iterator): Call bidi_init_it only of a valid
1454 buffer position was specified. Initialize paragraph_embedding to
1455 L2R.
1456 (reseat_to_string): Initialize the bidi iterator.
1457 (display_string): If we need to ignore text properties of
1458 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1459 original value of -1 will not work with bidi.)
1460 (compute_display_string_pos): First arg is now struct
1461 `text_pos *'; all callers changed. Support display properties on
1462 Lisp strings.
1463 (compute_display_string_end): Support display properties on Lisp
1464 strings.
1465 (init_iterator, reseat_1, reseat_to_string): Initialize the
1466 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1467 when iterating on a string not from display properties).
1468 (compute_display_string_pos, compute_display_string_end):
1469 Fix calculation of the object to scan. Fixes an error when using
1470 arrow keys.
1471 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1472 base_level_stop; instead, set base_level_stop to BEGV.
1473 Fixes crashes in vertical-motion.
1474 (next_element_from_buffer): Improve commentary for when
1475 the iterator is before prev_stop.
1476 (init_iterator): Initialize bidi_p from the default value of
1477 bidi-display-reordering, not from buffer-local value. Use the
1478 buffer-local value only if initializing for buffer iteration.
1479 (handle_invisible_prop): Support invisible properties on strings
1480 that are being bidi-reordered.
1481 (set_iterator_to_next): Support bidi reordering of C strings and
1482 Lisp strings.
1483 (next_element_from_string): Support bidi reordering of Lisp
1484 strings.
1485 (handle_stop_backwards): Support Lisp strings as well.
1486 (display_string): Support display of R2L glyph rows.
1487 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1488 (init_iterator): Don't initialize it->bidi_p for strings
1489 here.
1490 (reseat_to_string): Initialize it->bidi_p for strings here.
1491 (next_element_from_string, next_element_from_c_string)
1492 (next_element_from_buffer): Add xassert's for correspondence
1493 between IT's object being iterated and it->bidi_it.string
1494 structure.
1495 (face_before_or_after_it_pos): Support bidi iteration.
1496 (next_element_from_c_string): Handle the case of the first string
1497 character that is not the first one in the visual order.
1498 (get_visually_first_element): New function, refactored from common
1499 parts of next_element_from_buffer, next_element_from_string, and
1500 next_element_from_c_string.
1501 (tool_bar_lines_needed, redisplay_tool_bar)
1502 (display_menu_bar): Force left-to-right direction. Add a FIXME
1503 comment for making that be controlled by a user option.
1504 (push_it, pop_it): Save and restore the state of the
1505 bidi iterator. Save and restore the bidi_p flag.
1506 (pop_it): Iterate out of display property for string iteration as
1507 well.
1508 (iterate_out_of_display_property): Support iteration over strings.
1509 (handle_single_display_spec): Set up it->bidi_it for iteration
1510 over a display string, and call bidi_init_it.
1511 (handle_single_display_spec, next_overlay_string)
1512 (get_overlay_strings_1, push_display_prop): Set up the bidi
1513 iterator for displaying display or overlay strings.
1514 (forward_to_next_line_start): Don't use the shortcut if
1515 bidi-iterating.
1516 (back_to_previous_visible_line_start): If handle_display_prop
1517 pushed the iterator stack, restore the internal state of the bidi
1518 iterator by calling bidi_pop_it same number of times.
1519 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1520 and we are bidi-iterating, don't decrement the iterator position;
1521 instead, set the first_elt flag in the bidi iterator, to produce
1522 the same effect.
1523 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1524 (push_display_prop): xassert that we are iterating a buffer.
1525 (push_it, pop_it): Save and restore paragraph_embedding member.
1526 (handle_single_display_spec, next_overlay_string)
1527 (get_overlay_strings_1, reseat_1, reseat_to_string)
1528 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1529 correctly. Don't assume unibyte strings are not bidi-reordered.
1530 (compute_display_string_pos)
1531 (compute_display_string_end): Fix handling the case of C string.
1532 (push_it, pop_it): Save and restore from_disp_prop_p.
1533 (handle_single_display_spec, push_display_prop): Set the
1534 from_disp_prop_p flag.
1535 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1536 (pop_it): Call iterate_out_of_display_property only if we are
1537 popping after iteration over a string that came from a display
1538 property. Fix a typo in popping stretch info. Add an assertion
1539 for verifying that the iterator position is in sync with the bidi
1540 iterator.
1541 (handle_single_display_spec, get_overlay_strings_1)
1542 (push_display_prop): Fix initialization of paragraph direction for
1543 string when that of the parent object is not yet determined.
1544 (reseat_1): Call bidi_init_it to resync the bidi
1545 iterator with IT's position. (Bug#7616)
1546 (find_row_edges): If ROW->start.pos gives position
1547 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1548 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1549 Reset the from_disp_prop_p flag.
1550 (SAVE_IT, RESTORE_IT): New macros.
1551 (pos_visible_p, face_before_or_after_it_pos)
1552 (back_to_previous_visible_line_start)
1553 (move_it_in_display_line_to, move_it_in_display_line)
1554 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1555 (try_scrolling, redisplay_window, display_line): Use them when
1556 saving a temporary copy of the iterator and restoring it back.
1557 (back_to_previous_visible_line_start, reseat_1)
1558 (init_iterator): Empty the bidi cache "stack".
1559 (move_it_in_display_line_to): If iterator ended up at
1560 EOL, but we never saw any buffer positions smaller than
1561 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1562 motion in bidi-reordered lines.
1563 (move_it_in_display_line_to): Record prev_method and prev_pos
1564 immediately before the call to set_iterator_to_next. Fixes cursor
1565 motion in bidi-reordered lines with stretch glyphs and strings
1566 displayed in margins. (Bug#8133) (Bug#8867)
1567 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1568 TO_CHARPOS.
1569 (pos_visible_p): Support positions in bidi-reordered lines.
1570 Save and restore bidi cache.
1571
1572 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1573 (bidi_paragraph_info): Delete unused struct.
1574 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1575 (bidi_cache_start): New variable.
1576 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1577 to zero.
1578 (bidi_cache_fetch_state, bidi_cache_search)
1579 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1580 (bidi_cache_find, bidi_peek_at_next_level)
1581 (bidi_level_of_next_char, bidi_find_other_level_edge)
1582 (bidi_move_to_visually_next): Compare cache index with
1583 bidi_cache_start rather than with zero.
1584 (bidi_fetch_char): Accept new argument STRING; all callers
1585 changed. Support iteration over a string. Support strings with
1586 display properties. Support unibyte strings. Fix the type of
1587 `len' according to what STRING_CHAR_AND_LENGTH expects.
1588 (bidi_paragraph_init, bidi_resolve_explicit_1)
1589 (bidi_resolve_explicit, bidi_resolve_weak)
1590 (bidi_level_of_next_char, bidi_move_to_visually_next):
1591 Support iteration over a string.
1592 (bidi_set_sor_type, bidi_resolve_explicit_1)
1593 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1594 can now be zero (for strings); special values 0 and -1 were
1595 changed to -1 and -2, respectively.
1596 (bidi_char_at_pos): New function.
1597 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1598 Call it instead of FETCH_MULTIBYTE_CHAR.
1599 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1600 initialized to valid values.
1601 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1602 values.
1603 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1604 the test for valid cached positions. Fix the logic for looking up
1605 the sentinel state in the cache. GCPRO the Lisp string we are
1606 iterating.
1607 (bidi_push_it, bidi_pop_it): New functions.
1608 (bidi_initialize): Initialize the bidi cache start stack pointer.
1609 (bidi_cache_ensure_space): New function, refactored from part of
1610 bidi_cache_iterator_state. Don't assume the required size is just
1611 one BIDI_CACHE_CHUNK away.
1612 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1613 (bidi_count_bytes, bidi_char_at_pos): New functions.
1614 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1615 always valid if bidi_cache_idx is valid.
1616 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1617 is valid if it's going to be used.
1618 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1619 (bidi_cache_fetch_state, bidi_cache_search)
1620 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1621 (bidi_cache_iterator_state, bidi_cache_find)
1622 (bidi_find_other_level_edge, bidi_cache_start_stack):
1623 All variables related to cache indices are now EMACS_INT.
1624
1625 * dispextern.h (struct bidi_string_data): New structure.
1626 (struct bidi_it): New member `string'. Make flag members be 1-bit
1627 fields, and put them last in the struct.
1628 (compute_display_string_pos, compute_display_string_end):
1629 Update prototypes.
1630 (bidi_push_it, bidi_pop_it): Add prototypes.
1631 (struct iterator_stack_entry): New members bidi_p,
1632 paragraph_embedding, and from_disp_prop_p.
1633 (struct it): Member bidi_p is now a bit field 1 bit wide.
1634 (bidi_shelve_cache, bidi_unshelve_cache):
1635 Declare prototypes.
1636
1637 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1638 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1639 and vector-like objects.
1640
1641 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1642 cache around display iteration.
1643
1644 * window.c (Fwindow_end, window_scroll_pixel_based)
1645 (displayed_window_lines, Frecenter): Save and restore the bidi
1646 cache around display iteration.
1647
1648 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1649
1650 * editfns.c (Fdelete_region): Clarify the use of the named
1651 parameters (bug#6788).
1652
1653 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1654
1655 * indent.c (Fvertical_motion): Set and restore w->pointm when
1656 saving and restoring the window's buffer (Bug#9006).
1657
1658 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1659
1660 * editfns.c (Fstring_to_char): Clarify just what is returned
1661 (bug#6576). Text by Eli Zaretskii.
1662
1663 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1664
1665 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1666
1667 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1668
1669 * buffer.c (mmap_find): Fix a typo.
1670
1671 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1672
1673 Fix execution of x selection hooks.
1674 * xselect.c (Qx_lost_selection_functions)
1675 (Qx_sent_selection_functions): New vars.
1676 (syms_of_xselect): DEFSYM them.
1677 (x_handle_selection_request): Pass Qx_sent_selection_functions
1678 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1679 (x_handle_selection_clear,x_clear_frame_selections):
1680 Pass Qx_lost_selection_functions rather than
1681 Vx_lost_selection_functions to Frun_hook_with_args.
1682
1683 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1686 The old code sometimes used this field without initializing it.
1687
1688 * alloc.c (gc_sweep): Don't read past end of array.
1689 In theory, the old code could also have corrupted Emacs internals,
1690 though it'd be very unlikely.
1691
1692 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1693
1694 * character.c (Fcharacterp): Don't advertise optional ignored
1695 argument. (Bug#4026)
1696
1697 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1698
1699 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1700 key" (bug#4257).
1701
1702 * window.c (Fset_window_start): Doc fix (bug#4199).
1703 (Fset_window_hscroll): Ditto.
1704
1705 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 Fix minor new problems caught by GCC 4.6.1.
1708 * term.c (init_tty): Remove unused local.
1709 * xsettings.c (store_monospaced_changed): Define this function only
1710 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1711 not used otherwise.
1712
1713 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1714
1715 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1716
1717 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1718
1719 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1720 are the mini-buffer and the echo area (bug#3320).
1721
1722 * term.c (init_tty): Remove support for supdup, c10 and perq
1723 terminals, which are no longer supported (bug#1482).
1724
1725 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1726
1727 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1728
1729 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1730
1731 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1732 for non-popups (Bug#3642).
1733
1734 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1735
1736 * alloc.c (reset_malloc_hooks): Protoize.
1737 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1738 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1739 * cm.c (losecursor): Likewise.
1740 * data.c (fmod): Likewise.
1741 * dispnew.c (swap_glyphs_in_rows): Likewise.
1742 * emacs.c (memory_warning_signal): Likewise.
1743 * floatfns.c (float_error): Likewise.
1744 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1745 (otf_open, font_otf_capability, generate_otf_features)
1746 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1747 Likewise.
1748 * image.c (pbm_read_file): Likewise.
1749 * indent.c (string_display_width): Likewise.
1750 * intervals.c (check_for_interval, search_for_interval)
1751 (inc_interval_count, count_intervals, root_interval)
1752 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1753 * lread.c (defalias): Likewise.
1754 * ralloc.c (r_alloc_check): Likewise.
1755 * regex.c (set_image_of_range_1, set_image_of_range)
1756 (regex_grow_registers): Likewise.
1757 * sysdep.c (strerror): Likewise.
1758 * termcap.c (valid_filename_p, tprint, main): Likewise.
1759 * tparam.c (main): Likewise.
1760 * unexhp9k800.c (run_time_remap, save_data_space)
1761 (update_file_ptrs, read_header, write_header, calculate_checksum)
1762 (copy_file, copy_rest, display_header): Likewise.
1763 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1764 Likewise.
1765 * xdisp.c (check_it): Likewise.
1766 * xfaces.c (register_color, unregister_color, unregister_colors):
1767 Likewise.
1768 * xfns.c (print_fontset_result): Likewise.
1769 * xrdb.c (member, fatal, main): Likewise.
1770
1771 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Fix minor problems found by static checking (Bug#9031).
1774 * chartab.c (char_table_set_range, map_sub_char_table):
1775 Remove unused locals.
1776 (uniprop_table): Now static.
1777 * composite.c (_work_char): Remove unused static var.
1778
1779 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1780
1781 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1782
1783 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1784
1785 * gtkutil.c (qttip_cb): Remove code without function.
1786
1787 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1788
1789 * w32.c (pthread_sigmask): New stub.
1790
1791 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 Use pthread_sigmask, not sigprocmask (Bug#9010).
1794 sigprocmask is portable only for single-threaded applications, and
1795 Emacs can be multi-threaded when it uses GTK.
1796 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1797 (LIBES): Use it.
1798 * callproc.c (Fcall_process):
1799 * process.c (create_process):
1800 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1801 Use pthread_sigmask, not sigprocmask.
1802
1803 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1804
1805 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1806 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1807 wrong (Bug#8591).
1808
1809 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1810
1811 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1812 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1813 (xg_hide_tooltip): Fix comment.
1814
1815 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1816 in registerServicesMenuSendTypes.
1817 (validRequestorForSendType): Don't check ns_return_types.
1818
1819 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1820 ns_return_type.
1821
1822 2011-07-08 Jason Rumney <jasonr@gnu.org>
1823
1824 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1825 frame struct members of non-existent frames (Bug#6284).
1826
1827 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1828
1829 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1830 variable firstTime not needed on OSX >= 10.6.
1831 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1832 >= 10.5. Use setKnobProportion, setDoubleValue.
1833
1834 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1835 (MAC_OS_X_VERSION_10_5): Define if not defined.
1836 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1837 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1838 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1839
1840 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1841 cString and lossyCString on OSX >= 10.4
1842
1843 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1844 sizeToFit on OSX >= 10.2.
1845
1846 * nsimage.m (allocInitFromFile): Don't use deprecated method
1847 bestRepresentationForDevice on OSX >= 10.6.
1848
1849 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1850 to avoid warning.
1851
1852 * emacs.c: Declare unexec_init_emacs_zone.
1853
1854 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1855
1856 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1857
1858 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1859 on svcsMenu (Bug#8842).
1860
1861 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1862 ns_return_types.
1863 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1864
1865 * nsterm.m (QUTF8_STRING): Declare.
1866 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1867 (validRequestorForSendType): Return type is (id).
1868 Change indexOfObjectIdenticalTo to indexOfObject.
1869 Check if we have local selection before returning self (Bug#8842).
1870 (writeSelectionToPasteboard): Put local selection into paste board
1871 if we have a local selection (Bug#8842).
1872 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1873
1874 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1875 (ns_get_local_selection): Declare.
1876
1877 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1878
1879 * keymap.c (describe_map_tree): Don't insert a double newline at
1880 the end of the buffer (bug#1169) and return whether we inserted
1881 something.
1882
1883 * callint.c (Fcall_interactively): Change "reading args" to
1884 "providing args" to try to clarify what it does (bug#1010).
1885
1886 2011-07-07 Kenichi Handa <handa@m17n.org>
1887
1888 * composite.c (composition_compute_stop_pos): Ignore a static
1889 composition starting before CHARPOS (Bug#8915).
1890
1891 * xdisp.c (handle_composition_prop): Likewise.
1892
1893 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1894
1895 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1896 (Bug#9015)
1897
1898 2011-07-07 Kenichi Handa <handa@m17n.org>
1899
1900 * character.h (unicode_category_t): New enum type.
1901
1902 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1903 (Qchar_code_property_table): New variable.
1904 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1905 (UNIPROP_COMPRESSED_FORM_P): New macros.
1906 (char_table_ascii): Uncompress the compressed values.
1907 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1908 Uncompress the compressed values.
1909 (sub_char_table_ref_and_range): Likewise.
1910 (char_table_ref_and_range): Uncompress the compressed values.
1911 (sub_char_table_set): New arg is_uniprop. Callers changed.
1912 Uncompress the compressed values.
1913 (sub_char_table_set_range): Args changed. Callers changed.
1914 (char_table_set_range): Adjuted for the above change.
1915 (map_sub_char_table): Delete args default_val and parent. Add arg
1916 top. Give decoded values to a Lisp function.
1917 (map_char_table): Adjust for the above change. Give decoded
1918 values to a Lisp function. Gcpro more variables.
1919 (uniprop_table_uncompress)
1920 (uniprop_decode_value_run_length): New functions.
1921 (uniprop_decoder, uniprop_decoder_count): New variables.
1922 (uniprop_get_decoder, uniprop_encode_value_character)
1923 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1924 New functions.
1925 (uniprop_encoder, uniprop_encoder_count): New variables.
1926 (uniprop_get_encoder, uniprop_table)
1927 (Funicode_property_table_internal, Fget_unicode_property_internal)
1928 (Fput_unicode_property_internal): New functions.
1929 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1930 Sunicode_property_table_internal, Sget_unicode_property_internal,
1931 and Sput_unicode_property_internal. Defvar_lisp
1932 char-code-property-alist.
1933
1934 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1935 Vunicode_category_table.
1936
1937 * font.c (font_range): Adjust for the change of
1938 Vunicode_category_table.
1939
1940 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1941
1942 * m/iris4d.h: Remove file, move contents ...
1943 * s/irix6-5.h: ... here.
1944
1945 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 Remove unportable assumption about struct layout (Bug#8884).
1948 * alloc.c (mark_buffer):
1949 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1950 (clone_per_buffer_values): Don't assume that
1951 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1952 This isn't true in general, and it's particularly not true
1953 if Emacs is configured with --with-wide-int.
1954 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1955 New macros, used in the buffer.c change.
1956
1957 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1958
1959 * xsettings.c: Use both GConf and GSettings if both are available.
1960 (store_config_changed_event): Add comment.
1961 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1962 (store_tool_bar_style_changed): New functions.
1963 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1964 (struct xsettings): Move font inside HAVE_XFT.
1965 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1966 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1967 Move inside HAVE_XFT.
1968 (something_changed_gsettingsCB): Rename from something_changedCB.
1969 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1970 also.
1971 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1972 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1973 (something_changed_gconfCB): Rename from something_changedCB.
1974 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1975 (parse_settings): Move check for font inside HAVE_XFT.
1976 (read_settings, apply_xft_settings): Add comment.
1977 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1978 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1979 call store_font_name_changed.
1980 (xft_settings_event): Add comment.
1981 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1982 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1983 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1984 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1985 (xsettings_initialize): Call init_gsettings last.
1986 (xsettings_get_system_font, xsettings_get_system_normal_font):
1987 Add comment.
1988
1989 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 Random fixes. E.g., (random) never returned negative values.
1992 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1993 subseconds part to the entropy, as that's a bit more random.
1994 Prefer signed to unsigned, since the signedness doesn't matter and
1995 in general we prefer signed. When given a limit, use a
1996 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1997 latter isn't right if USE_2_TAGS_FOR_INTS.
1998 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1999 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2000
2001 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2002
2003 * textprop.c (text_property_stickiness):
2004 Obey Vtext_property_default_nonsticky.
2005 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2006 * w32fns.c (syms_of_w32fns):
2007 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2008
2009 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2012 This is more efficient than Ffile_directory_p and avoids a minor race.
2013
2014 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2015
2016 * buffer.c (Foverlay_put): Say what the return value is
2017 (bug#7835).
2018
2019 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2020 is a directory before asking whether to use the file name
2021 (bug#7564).
2022 (barf_or_query_if_file_exists): Make the "File is a directory"
2023 error be more correct.
2024
2025 * fns.c (Frequire): Remove the mention of the .gz files, since
2026 that's installation-specific, but keep the mention of
2027 `get-load-suffixes'.
2028
2029 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2030
2031 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2032 Report string overflow if the output is too long.
2033
2034 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2037 (syms_of_gnutls): Remove duplicate DEFSYM for
2038 Qgnutls_bootprop_verify_hostname_error, an error for
2039 Qgnutls_bootprop_verify_error (which is no longer used).
2040
2041 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2042 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2043 Also (re)move comments that are misplaced or no longer relevant.
2044
2045 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2046
2047 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2048
2049 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2050
2051 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2052 and background color parameters if they have been changed.
2053
2054 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2055
2056 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2057
2058 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 * xsettings.c (SYSTEM_FONT): Define only when used.
2061 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2062
2063 * keymap.c (access_keymap_1): Now static.
2064
2065 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2066
2067 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2068 leave any prefix arg for the up event (Bug#1586).
2069
2070 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2071
2072 * lread.c (syms_of_lread): Mention single symbols defined by
2073 `defvar' or `defconst' (bug#7154).
2074
2075 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2076 (Frequire): Mention get-load-suffixes.
2077
2078 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2079
2080 * window.h (window): Remove clone_number slot.
2081 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2082 Remove.
2083 (make_parent_window, make_window, saved_window)
2084 (Fset_window_configuration, save_window_save): Don't deal with
2085 clone numbers.
2086 * buffer.c (Qclone_number): Remove declaration.
2087 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2088
2089 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2090
2091 Add multiple inheritance to keymaps.
2092 * keymap.c (Fmake_composed_keymap): New function.
2093 (Fset_keymap_parent): Simplify.
2094 (fix_submap_inheritance): Remove.
2095 (access_keymap_1): New function extracted from access_keymap to handle
2096 embedded parents and handle lists of maps.
2097 (access_keymap): Use it.
2098 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2099 (Fcopy_keymap): Handle embedded parents.
2100 (Fcommand_remapping, define_as_prefix): Simplify.
2101 (Fkey_binding): Simplify.
2102 (syms_of_keymap): Move minibuffer-local-completion-map,
2103 minibuffer-local-filename-completion-map,
2104 minibuffer-local-must-match-map, and
2105 minibuffer-local-filename-must-match-map to Elisp.
2106 (syms_of_keymap): Defsubr make-composed-keymap.
2107 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2108 (parse_menu_item): Trivial simplification.
2109
2110 2011-07-01 Glenn Morris <rgm@gnu.org>
2111
2112 * Makefile.in (SETTINGS_LIBS): Fix typo.
2113
2114 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2115
2116 * coding.c (Fencode_coding_string): Record the last coding system
2117 used, as the function doc string says (bug#8738).
2118
2119 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2120
2121 * xsettings.c (store_monospaced_changed): Take new font as arg and
2122 check for change against current_mono_font.
2123 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2124 (emacs_settings_constructor, emacs_settings_get_property)
2125 (emacs_settings_set_property, emacs_settings_class_init)
2126 (emacs_settings_init, gsettings_obj): Remove.
2127 (something_changedCB): New function for HAVE_GSETTINGS.
2128 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2129 with value as argument.
2130 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2131 g_settings_new (Bug#8967). Do not create gsettings_obj.
2132 Remove calls to g_settings_bind. Connect something_changedCB to
2133 "changed".
2134
2135 * xgselect.c: Add defined (HAVE_GSETTINGS).
2136 (xgselect_initialize): Ditto.
2137
2138 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2139 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2140 xg_select.
2141
2142 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 * eval.c (struct backtrace): Simplify and port the data structure.
2145 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2146 signed bit field, as this assumption is not portable and it makes
2147 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2148 "char debug_on_exit : 1" as this is not portable either; instead,
2149 use the portable "unsigned int debug_on_exit : 1". Remove unused
2150 member evalargs. Remove obsolete comments about cc bombing out.
2151
2152 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2153
2154 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2155 Let HAVE_GSETTINGS override HAVE_GCONF.
2156 (store_monospaced_changed): New function.
2157 (EMACS_SETTINGS): A new type derived from GObject to handle
2158 GSettings notifications.
2159 (emacs_settings_constructor, emacs_settings_get_property)
2160 (emacs_settings_set_property, emacs_settings_class_init):
2161 New functions.
2162 (gsettings_client, gsettings_obj): New variables.
2163 (GSETTINGS_SCHEMA): New define.
2164 (something_changedCB): Call store_monospaced_changed.
2165 (init_gsettings): New function.
2166 (xsettings_initialize): Call init_gsettings.
2167 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2168 to NULL.
2169
2170 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2171 GCONF_CFLAGS/LIBS.
2172
2173 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2174
2175 * window.c (resize_root_window, grow_mini_window)
2176 (shrink_mini_window): Rename Qresize_root_window to
2177 Qwindow_resize_root_window and Qresize_root_window_vertically to
2178 Qwindow_resize_root_window_vertically.
2179
2180 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2183
2184 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2185
2186 * makefile.w32-in: Redesign dependencies so they reflect more
2187 clearly which files are directly included by each source file,
2188 and not through other includes.
2189
2190 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2191
2192 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2193 (sort_overlays, overlay_strings): When an overlay's clone number
2194 matches the window's clone number process the overlay even if
2195 the overlay's window property doesn't match the current window.
2196
2197 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2198 (Fwindow_hchild): Rename to Fwindow_left_child.
2199 (Fwindow_next): Rename to Fwindow_next_sibling.
2200 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2201 (resize_window_check): Rename to window_resize_check.
2202 (resize_window_apply): Rename to window_resize_apply.
2203 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2204 (Fdelete_other_windows_internal, resize_frame_windows)
2205 (Fsplit_window_internal, Fdelete_window_internal)
2206 (grow_mini_window, shrink_mini_window)
2207 (Fresize_mini_window_internal): Fix callers accordingly.
2208
2209 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2210
2211 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2212 (emacs_fixed_set_min_size): Remove.
2213 (emacs_fixed_new): Take frame as argument.
2214
2215 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2216 (_EmacsFixedPrivate): Remove minwidth/height.
2217 Add struct frame *f.
2218 (emacs_fixed_init): Initialize priv->f.
2219 (get_parent_class, emacs_fixed_set_min_size): Remove.
2220 (emacs_fixed_new): Set priv->f to argument.
2221 (emacs_fixed_get_preferred_width)
2222 (emacs_fixed_get_preferred_height): Use min_width/height from
2223 frames size_hint to set minimum and natural (Bug#8919).
2224 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2225 and use min_width/height from frames size_hint to set
2226 min_width/height (Bug#8919).
2227
2228 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2229 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2230 Fix indentation.
2231
2232 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2233
2234 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2235 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2236 called at ZV.
2237
2238 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2239
2240 * process.c (wait_reading_process_output): Bypass select if
2241 waiting for a cell while ignoring keyboard input, and input is
2242 pending. Suggested by Jan Djärv (Bug#8869).
2243
2244 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 Use gnulib's dup2 module instead of rolling our own.
2247 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2248
2249 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2250
2251 * dispnew.c (scrolling_window): Before scrolling, turn off a
2252 mouse-highlight in the window being scrolled.
2253
2254 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2255
2256 Move DEFSYM to lisp.h and use everywhere.
2257
2258 * character.h (DEFSYM): Move declaration...
2259 * lisp.h (DEFSYM): ...here.
2260
2261 * gnutls.c:
2262 * minibuf.c:
2263 * w32menu.c:
2264 * w32proc.c:
2265 * w32select.c: Don't include character.h.
2266
2267 * alloc.c (syms_of_alloc):
2268 * buffer.c (syms_of_buffer):
2269 * bytecode.c (syms_of_bytecode):
2270 * callint.c (syms_of_callint):
2271 * casefiddle.c (syms_of_casefiddle):
2272 * casetab.c (init_casetab_once):
2273 * category.c (init_category_once, syms_of_category):
2274 * ccl.c (syms_of_ccl):
2275 * cmds.c (syms_of_cmds):
2276 * composite.c (syms_of_composite):
2277 * dbusbind.c (syms_of_dbusbind):
2278 * dired.c (syms_of_dired):
2279 * dispnew.c (syms_of_display):
2280 * doc.c (syms_of_doc):
2281 * editfns.c (syms_of_editfns):
2282 * emacs.c (syms_of_emacs):
2283 * eval.c (syms_of_eval):
2284 * fileio.c (syms_of_fileio):
2285 * fns.c (syms_of_fns):
2286 * frame.c (syms_of_frame):
2287 * fringe.c (syms_of_fringe):
2288 * insdel.c (syms_of_insdel):
2289 * keymap.c (syms_of_keymap):
2290 * lread.c (init_obarray, syms_of_lread):
2291 * macros.c (syms_of_macros):
2292 * msdos.c (syms_of_msdos):
2293 * print.c (syms_of_print):
2294 * process.c (syms_of_process):
2295 * search.c (syms_of_search):
2296 * sound.c (syms_of_sound):
2297 * syntax.c (init_syntax_once, syms_of_syntax):
2298 * terminal.c (syms_of_terminal):
2299 * textprop.c (syms_of_textprop):
2300 * undo.c (syms_of_undo):
2301 * w32.c (globals_of_w32):
2302 * window.c (syms_of_window):
2303 * xdisp.c (syms_of_xdisp):
2304 * xfaces.c (syms_of_xfaces):
2305 * xfns.c (syms_of_xfns):
2306 * xmenu.c (syms_of_xmenu):
2307 * xsettings.c (syms_of_xsettings):
2308 * xterm.c (syms_of_xterm): Use DEFSYM.
2309
2310 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2311
2312 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2313
2314 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 Integer and buffer overflow fixes (Bug#8873).
2317
2318 * print.c (printchar, strout): Check for string overflow.
2319 (PRINTPREPARE, printchar, strout):
2320 Don't set size unless allocation succeeds.
2321
2322 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2323 for sizes. Check for string overflow more accurately.
2324 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2325
2326 * macros.c: Integer and buffer overflow fixes.
2327 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2328 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2329 Use ptrdiff_t, not int, for sizes.
2330 Don't increment bufsize until after realloc succeeds.
2331 Check for size-calculation overflow.
2332 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2333
2334 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2335
2336 * lread.c: Integer overflow fixes.
2337 (read_integer): Radix is now EMACS_INT, not int,
2338 to improve quality of diagnostics for out-of-range radices.
2339 Calculate buffer size correctly for out-of-range radices.
2340 (read1): Check for integer overflow in radices, and in
2341 read-circle numbers.
2342 (read_escape): Avoid int overflow.
2343 (Fload, openp, read_buffer_size, read1)
2344 (substitute_object_recurse, read_vector, read_list, map_obarray):
2345 Use ptrdiff_t, not int, for sizes.
2346 (read1): Use EMACS_INT, not int, for sizes.
2347 Check for size overflow.
2348
2349 * image.c (cache_image): Check for size arithmetic overflow.
2350
2351 * lread.c: Integer overflow issues.
2352 (saved_doc_string_size, saved_doc_string_length)
2353 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2354 Now ptrdiff_t, not int.
2355 (read1): Don't assume doc string length fits in int. Check for
2356 out-of-range doc string lengths.
2357 (read_list): Don't assume file position fits in int.
2358 (read_escape): Check for hex character overflow.
2359
2360 2011-06-22 Leo Liu <sdl.web@gmail.com>
2361
2362 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2363 Move to minibuffer.el.
2364
2365 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2368 The following patches are for when GLYPH_DEBUG && !XASSERT.
2369 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2370 * dispnew.c (flush_stdout):
2371 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2372 Mark as externally visible.
2373 * dispnew.c (check_window_matrix_pointers): Now static.
2374 * dispnew.c (window_to_frame_vpos):
2375 * xfns.c (unwind_create_frame):
2376 * xterm.c (x_check_font): Remove unused local.
2377 * scroll.c (CHECK_BOUNDS):
2378 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2379 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2380 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2381 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2382 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2383 Now static.
2384 (debug_method_add): Use va_list and vsprintf rather than relying
2385 on undefined behavior with wrong number of arguments.
2386 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2387 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2388 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2389 since we're not interested in debugging glyphs with old libraries.
2390 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2391 GCC 4.6.0's static checking.
2392
2393 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 Integer overflow and signedness fixes (Bug#8873).
2396 A few related buffer overrun fixes, too.
2397
2398 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2399
2400 * dispextern.h (struct face.stipple):
2401 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2402 (x_bitmap_mask, x_allocate_bitmap_record)
2403 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2404 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2405 (x_create_bitmap_from_xpm_data):
2406 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2407 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2408 (.bitmaps_last):
2409 * xfaces.c (load_pixmap):
2410 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2411 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2412 (.bitmaps_last, struct x_output.icon_bitmap):
2413 Use ptrdiff_t, not int, for bitmap indexes.
2414 (x_allocate_bitmap_record): Check for size overflow.
2415 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2416
2417 Use ptrdiff_t, not int, for overlay counts.
2418 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2419 * editfns.c (overlays_around, get_pos_property):
2420 * textprop.c (get_char_property_and_overlay):
2421 * xdisp.c (next_overlay_change, note_mouse_highlight):
2422 * xfaces.c (face_at_buffer_position):
2423 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2424 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2425 (Fnext_overlay_change, Fprevious_overlay_change)
2426 (mouse_face_overlay_overlaps, Foverlays_in):
2427 Use ptrdiff_t, not int, for sizes.
2428 (overlays_at, overlays_in): Check for size-calculation overflow.
2429
2430 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2431
2432 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2433 (x_session_initialize): Do not assume string length fits in int.
2434
2435 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2436 This is unlikely, but can occur if DPI is outlandish.
2437
2438 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2439 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2440
2441 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2442 * xrdb.c (magic_file_p, search_magic_path):
2443 Omit last arg SUFFIX; it was always 0. All callers changed.
2444 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2445
2446 * xfont.c (xfont_match): Avoid need for strlen.
2447
2448 * xfns.c: Don't assume strlen fits in int.
2449 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2450
2451 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2452 not unsigned long, as we prefer signed integers. All callers changed.
2453 Detect integer overflow in repeat count.
2454 (message_dolog): Don't assume print length fits in 39 bytes.
2455 (display_mode_element): Don't assume strlen fits in int.
2456
2457 * termcap.c: Don't assume sizes fit in int and never overflow.
2458 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2459 (gobble_line): Check for size-calculation overflow.
2460
2461 * minibuf.c (Fread_buffer):
2462 * lread.c (intern, intern_c_string):
2463 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2464 Don't assume string length fits in int.
2465
2466 * keyboard.c (parse_tool_bar_item):
2467 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2468
2469 * font.c: Don't assume string length fits in int.
2470 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2471 Use ptrdiff_t, not int.
2472 (font_intern_prop): Don't assume string length fits in int.
2473 Don't assume integer property fits in fixnum.
2474 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2475
2476 * filelock.c: Fix some buffer overrun and integer overflow issues.
2477 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2478 Reformulate so as not to need the command string.
2479 Invoke gzip -cd rather than gunzip, as it's more portable.
2480 (lock_info_type, lock_file_1, lock_file):
2481 Don't assume pid_t and time_t fit in unsigned long.
2482 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2483 (current_lock_owner): Prefer signed type for sizes.
2484 Use memcpy, not strncpy, where memcpy is what is really wanted.
2485 Don't assume (via atoi) that time_t and pid_t fit in int.
2486 Check for time_t and/or pid_t out of range, e.g., via a network share.
2487 Don't alloca where an auto var works fine.
2488
2489 * fileio.c: Fix some integer overflow issues.
2490 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2491 Don't assume string length fits in int.
2492 (directory_file_name): Don't assume string length fits in long.
2493 (make_temp_name): Don't assume pid fits in int, or that its print
2494 length is less than 20.
2495
2496 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2497
2498 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2499
2500 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2501
2502 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2503 We prefer signed integers, even for size calculations.
2504
2505 * emacs.c: Don't assume string length fits in 'int'.
2506 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2507 (main): Don't invoke strlen when not needed.
2508
2509 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2510 (XD_DEBUG_MESSAGE): Don't waste a byte.
2511
2512 * callproc.c (getenv_internal_1, getenv_internal)
2513 (Fgetenv_internal):
2514 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2515
2516 * lread.c (invalid_syntax): Omit length argument.
2517 All uses changed. This doesn't fix a bug, but it simplifies the
2518 code away from its former Hollerith-constant appearance, and it's
2519 one less 'int' to worry about when looking at integer-overflow issues.
2520 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2521
2522 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2523 This didn't break anything, but it didn't help either.
2524 It's confusing to put a bogus integer in a place where the actual
2525 value does not matter.
2526 (LIST_END_P): Remove unused macro and its bogus comment.
2527 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2528
2529 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2530 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2531 implementation.
2532 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2533 We prefer signed types, and the value cannot exceed the EMACS_INT
2534 range anyway (because otherwise the length would not be representable).
2535 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2536 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2537 This avoids a GCC warning when WIDE_EMACS_INT.
2538
2539 * indent.c (sane_tab_width): New function.
2540 (current_column, scan_for_column, Findent_to, position_indentation)
2541 (compute_motion): Use it. This is just for clarity.
2542 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2543
2544 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2545
2546 * lisp.h (lint_assume): New macro.
2547 * composite.c (composition_gstring_put_cache):
2548 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2549
2550 * editfns.c, insdel.c:
2551 Omit unnecessary forward decls, to simplify future changes.
2552
2553 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2554
2555 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2556
2557 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2558 Use much-faster test for byte-length change.
2559 Don't assume string byte-length fits in 'int'.
2560 Check that character arg fits in 'int'.
2561 (mapcar1): Declare byte as byte, for clarity.
2562
2563 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2564
2565 * fns.c (concat): Catch string overflow earlier.
2566 Do not rely on integer wraparound.
2567
2568 * dispextern.h (struct it.overlay_strings_charpos)
2569 (struct it.selective): Now EMACS_INT, not int.
2570 * xdisp.c (forward_to_next_line_start)
2571 (back_to_previous_visible_line_start)
2572 (reseat_at_next_visible_line_start, next_element_from_buffer):
2573 Don't arbitrarily truncate the value of 'selective' to int.
2574
2575 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2576
2577 * composite.c: Don't truncate sizes to 'int'.
2578 (composition_gstring_p, composition_reseat_it)
2579 (composition_adjust_point): Use EMACS_INT, not int.
2580 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2581 not EMACS_UINT, for indexes.
2582
2583 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2584
2585 * buffer.c: Include <verify.h>.
2586 (struct sortvec.priority, struct sortstr.priority):
2587 Now EMACS_INT, not int.
2588 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2589 (struct sortstr.size, record_overlay_string)
2590 (struct sortstrlist.size, struct sortlist.used):
2591 Don't truncate size to int.
2592 (record_overlay_string): Check for size-calculation overflow.
2593 (init_buffer_once): Check at compile-time, not run-time.
2594
2595 2011-06-22 Jim Meyering <meyering@redhat.com>
2596
2597 Don't leak an XBM-image-sized buffer
2598 * image.c (xbm_load): Free the image buffer after using it.
2599
2600 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2601
2602 Port to Sun C.
2603 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2604 that Sun C diagnosed.
2605 * fns.c (secure_hash): Fix pointer signedness issue.
2606 * intervals.c (static_offset_intervals): New function.
2607 (offset_intervals): Use it.
2608
2609 2011-06-21 Leo Liu <sdl.web@gmail.com>
2610
2611 * deps.mk (fns.o):
2612 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2613 sha512.h.
2614
2615 * fns.c (secure_hash): Rename from crypto_hash_function and change
2616 the first arg to accept symbols.
2617 (Fsecure_hash): New primitive.
2618 (syms_of_fns): New symbols.
2619
2620 2011-06-20 Deniz Dogan <deniz@dogan.se>
2621
2622 * process.c (Fset_process_buffer): Clarify return value in
2623 docstring.
2624
2625 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2626
2627 * dispnew.c (add_window_display_history): Use BVAR.
2628
2629 * xdisp.c (debug_method_add): Use BVAR.
2630 (check_window_end, dump_glyph_matrix, dump_glyph)
2631 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2632
2633 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2634 Likewise.
2635
2636 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2637 check till after the cache is created in init_frame_faces.
2638
2639 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2640
2641 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2642
2643 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2646 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2647 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2648
2649 Improve buffer-overflow checking (Bug#8873).
2650 * fileio.c (Finsert_file_contents):
2651 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2652 Remove the old (too-loose) buffer overflow checks.
2653 They weren't needed, since make_gap checks for buffer overflow.
2654 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2655 The old code merely checked for Emacs fixnum overflow, and relied
2656 on undefined (wraparound) behavior. The new code avoids undefined
2657 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2658
2659 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2660 Tune. Don't use wider integers than needed. Don't use alloca.
2661 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2662
2663 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2664
2665 * insdel.c, lisp.h (buffer_overflow): New function.
2666 (insert_from_buffer_1, replace_range, replace_range_2):
2667 * insdel.c (make_gap_larger):
2668 * editfns.c (Finsert_char):
2669 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2670
2671 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2672
2673 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2674
2675 Integer overflow and signedness fixes (Bug#8873).
2676
2677 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2678 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2679
2680 * fileio.c: Don't assume EMACS_INT fits in off_t.
2681 (emacs_lseek): New static function.
2682 (Finsert_file_contents, Fwrite_region): Use it.
2683 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2684
2685 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2686
2687 * fns.c: Don't overflow int when computing a list length.
2688 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2689 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2690 truncation on 64-bit hosts. Check for QUIT every
2691 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2692 faster and is responsive enough.
2693 (Flength): Report an error instead of overflowing an integer.
2694 (Fsafe_length): Return a float if the value is not representable
2695 as a fixnum. This shouldn't happen except in contrived situations.
2696 (Fnthcdr, Fsort): Don't assume list length fits in int.
2697 (Fcopy_sequence): Don't assume vector length fits in int.
2698
2699 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2700 (header_size, word_size): New constants.
2701 (allocate_vectorlike): Don't check size overflow here.
2702 (allocate_vector): Check it here instead, since this is the only
2703 caller of allocate_vectorlike that could cause overflow.
2704 Check that the new vector's length is representable as a fixnum.
2705
2706 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2707 The previous code was bogus. For example, next_almost_prime (32)
2708 returned 39, which is undesirable as it is a multiple of 3; and
2709 next_almost_prime (24) returned 25, which is a multiple of 5 so
2710 why was the code bothering to check for multiples of 7?
2711
2712 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2713
2714 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2715
2716 Variadic C functions now count arguments with ptrdiff_t.
2717 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2718 Back then I didn't know that the Emacs coding style prefers signed int.
2719 Also, in the meantime I found a few more instances where arguments
2720 were being counted with int, which may truncate counts on 64-bit
2721 machines, or EMACS_INT, which may be unnecessarily wide.
2722 * lisp.h (struct Lisp_Subr.function.aMANY)
2723 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2724 Arg counts are now ptrdiff_t, not size_t.
2725 All variadic functions and their callers changed accordingly.
2726 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2727 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2728 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2729 * callint.c (Fcall_interactively): Check arg count for overflow,
2730 to avoid potential buffer overrun. Use signed char, not 'int',
2731 for 'varies' array, so that we needn't bother to check its size
2732 calculation for overflow.
2733 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2734 * eval.c (apply_lambda):
2735 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2736 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2737 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2738
2739 * callint.c (Fcall_interactively): Don't use index var as event count.
2740
2741 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2742 * mem-limits.h (SIZE): Remove; no longer used.
2743
2744 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2745
2746 Remove unnecessary casts.
2747 * xterm.c (x_term_init):
2748 * xfns.c (x_set_border_pixel):
2749 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2750 These aren't needed now that we assume ANSI C.
2751
2752 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2753 It's more likely to cause problems (due to unsigned overflow)
2754 than to cure them.
2755
2756 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2757
2758 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2759
2760 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2761
2762 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2763
2764 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2765
2766 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2767
2768 GLYPH_CODE_FACE returns EMACS_INT, not int.
2769 * dispextern.h (merge_faces):
2770 * xfaces.c (merge_faces):
2771 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2772 Don't assume EMACS_INT fits in int.
2773
2774 * character.h (CHAR_VALID_P): Remove unused parameter.
2775 * fontset.c, lisp.h, xdisp.c: All uses changed.
2776
2777 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2778
2779 * fns.c (concat): Minor tuning based on overflow analysis.
2780 This doesn't fix any bugs. Use int to hold character, instead
2781 of constantly refetching from Emacs object. Use XFASTINT, not
2782 XINT, for value known to be a character. Don't bother comparing
2783 a single byte to 0400, as it's always less.
2784
2785 * floatfns.c (Fexpt):
2786 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2787
2788 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2789 for characters.
2790
2791 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2792
2793 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2794 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2795 incorrectly succeed when S was a string, because 4294967386 was
2796 truncated before it was used.
2797
2798 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2799 Otherwise, an out-of-range integer could cause undefined behavior
2800 on a 64-bit host.
2801
2802 * composite.c: Use int, not EMACS_INT, for characters.
2803 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2804 EMACS_INT, for values that are known to be in character range.
2805 This doesn't fix any bugs but is the usual style inside Emacs and
2806 may generate better code on 32-bit machines.
2807
2808 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2809 This is for reasons similar to the recent CHAR_STRING fix.
2810 * charset.c (Fencode_char): Check that character arg is actually
2811 a character. Pass an int to ENCODE_CHAR.
2812 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2813 wider than 'int', as a compile-time check to prevent future regressions
2814 in this area.
2815
2816 * character.c (char_string): Remove unnecessary casts.
2817
2818 Make sure a 64-bit char is never passed to CHAR_STRING.
2819 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2820 by silently ignoring the top 32 bits, allowing some values
2821 that were far too large to be valid characters.
2822 * character.h: Include <verify.h>.
2823 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2824 arguments are no wider than unsigned, as a compile-time check
2825 to prevent future regressions in this area.
2826 * data.c (Faset):
2827 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2828 (Fsubst_char_in_region):
2829 * fns.c (concat):
2830 * xdisp.c (decode_mode_spec_coding):
2831 Adjust to CHAR_STRING's new requirement.
2832 * editfns.c (Finsert_char, Fsubst_char_in_region):
2833 * fns.c (concat): Check that character args are actually
2834 characters. Without this test, these functions did the wrong
2835 thing with wildly out-of-range values on 64-bit hosts.
2836
2837 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2838 These casts should not be needed on 32-bit hosts, either.
2839 * keyboard.c (read_char):
2840 * lread.c (Fload): Remove casts to unsigned.
2841
2842 * lisp.h (UNSIGNED_CMP): New macro.
2843 This fixes comparison bugs on 64-bit hosts.
2844 (ASCII_CHAR_P): Use it.
2845 * casefiddle.c (casify_object):
2846 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2847 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2848 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2849 * dispextern.h (FACE_FROM_ID):
2850 * keyboard.c (read_char): Use UNSIGNED_CMP.
2851
2852 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2853 not to EMACS_INT, to avoid GCC warning.
2854
2855 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2856
2857 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2858 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2859 isn't needed on 32-bit machines.
2860
2861 * buffer.c (Fgenerate_new_buffer_name):
2862 Use EMACS_INT for count, not int.
2863 (advance_to_char_boundary): Return EMACS_INT, not int.
2864
2865 * data.c (Qcompiled_function): Now static.
2866
2867 * window.c (window_body_lines): Now static.
2868
2869 * image.c (gif_load): Rename local to avoid shadowing.
2870
2871 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2872 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2873 * alloc.c (make_save_value): Integer argument is now of type
2874 ptrdiff_t, not int.
2875 (mark_object): Use ptrdiff_t, not int.
2876 * lisp.h (pD): New macro.
2877 * print.c (print_object): Use it.
2878
2879 * alloc.c: Use EMACS_INT, not int, to count objects.
2880 (total_conses, total_markers, total_symbols, total_vector_size)
2881 (total_free_conses, total_free_markers, total_free_symbols)
2882 (total_free_floats, total_floats, total_free_intervals)
2883 (total_intervals, total_strings, total_free_strings):
2884 Now EMACS_INT, not int. All uses changed.
2885 (Fgarbage_collect): Compute overall total using a double, so that
2886 integer overflow is less likely to be a problem. Check for overflow
2887 when converting back to an integer.
2888 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2889 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2890 These were 'int' variables that could overflow on 64-bit hosts;
2891 they were never used, so remove them instead of repairing them.
2892 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2893 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2894 Previously, this ceilinged at INT_MAX, but that doesn't work on
2895 64-bit machines.
2896 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2897
2898 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2899 (allocate_vectorlike): Check for ptrdiff_t overflow.
2900 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2901 when a (possibly-narrower) signed value would do just as well.
2902 We prefer using signed arithmetic, to avoid comparison confusion.
2903
2904 * alloc.c: Catch some string size overflows that we were missing.
2905 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2906 for convenience in STRING_BYTES_MAX.
2907 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2908 The definition here is exact; the one in lisp.h was approximate.
2909 (allocate_string_data): Check for string overflow. This catches
2910 some instances we weren't catching before. Also, it catches
2911 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2912 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2913 and ptrdiff_t and EMACS_INT are both 64 bits.
2914
2915 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2916 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2917 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2918
2919 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2920
2921 * alloc.c (Fmake_string): Check for out-of-range init.
2922
2923 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2924
2925 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2926
2927 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2928
2929 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2930 xg_get_default_scrollbar_width.
2931
2932 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2933 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2934 (style_changed_cb): Call update_theme_scrollbar_width and call
2935 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2936 all frames (Bug#8505).
2937 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2938 Call gtk_window_set_resizable if HAVE_GTK3.
2939 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2940 and height if HAVE_GTK3 (Bug#8505).
2941 (scroll_bar_width_for_theme): New variable.
2942 (update_theme_scrollbar_width): New function.
2943 (xg_get_default_scrollbar_width): Move code to
2944 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2945 (xg_initialize): Call update_theme_scrollbar_width.
2946
2947 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2948
2949 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2950
2951 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2952
2953 * frame.c (make_frame): Call other_buffer_safely instead of
2954 other_buffer.
2955
2956 * window.c (temp_output_buffer_show): Call display_buffer with
2957 second argument Vtemp_buffer_show_specifiers and reset latter
2958 immediately after the call.
2959 (Vtemp_buffer_show_specifiers): New variable.
2960 (auto_window_vscroll_p, next_screen_context_lines)
2961 (Vscroll_preserve_screen_position): Remove leading asterisks from
2962 doc-strings.
2963
2964 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2965
2966 Fix minor problems found by GCC 4.6.0 static checking.
2967 * buffer.c (Qclone_number): Remove for now, as it's unused.
2968 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2969 (record_buffer): Remove unused local.
2970 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2971 (set_frame_buffer_list): Remove; unused.
2972 * frame.h (other_visible_frames): Remove decl.
2973 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2974 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2975 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2976 if HAVE_GPM.
2977 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2978 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2979 Define only if HAVE_GPM.
2980 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2981 (update_hints_inhibit): Remove; never set. All uses removed.
2982 * widgetprv.h (emacsFrameClassRec): Remove decl.
2983 * window.c (delete_deletable_window): Now returns void, since it
2984 wasn't returning anything.
2985 (compare_window_configurations): Remove unused locals.
2986 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2987 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2988 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2989 the same widths as pointers. This follows up on the 2011-05-06 patch.
2990 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2991 * xterm.h: Likewise.
2992 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2993
2994 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * makefile.w32-in: Update dependencies.
2997 (LISP_H): Add lib/intprops.h.
2998
2999 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3000
3001 * image.c (gif_load): Add animation frame delay to the metadata.
3002 (syms_of_image): Use DEFSYM. New symbol `delay'.
3003
3004 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3005
3006 * window.c (delete_deletable_window): Re-add.
3007 (Fset_window_configuration): Rewrite to handle dead buffers and
3008 consequently deletable windows.
3009 (window_tree, Fwindow_tree): Remove. Supply functionality in
3010 window.el.
3011 (compare_window_configurations): Simplify code.
3012
3013 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3014
3015 * image.c (imagemagick_load_image): Fix type mismatch.
3016 (Fimagemagick_types): Likewise.
3017
3018 * window.h (replace_buffer_in_windows): Declare.
3019
3020 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3021
3022 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3023 Qclone_number. Remove external declaration of Qdelete_window.
3024 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3025 code.
3026 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3027 Run Qbuffer_list_update_hook if allowed.
3028 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3029 buffer list implementation.
3030 (other_buffer_safely): New function.
3031 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3032 calls to replace_buffer_in_windows and
3033 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3034 if allowed.
3035 (record_buffer): Inhibit quitting and rewrite using quittable
3036 functions. Run Qbuffer_list_update_hook if allowed.
3037 (Frecord_buffer, Funrecord_buffer): New functions.
3038 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3039 Move switch-to-buffer to window.el.
3040 (bury-buffer): Move to window.el.
3041 (Vbuffer_list_update_hook): New variable.
3042
3043 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3044 section.
3045
3046 * window.h (resize_frame_windows): Move up in code.
3047 (Fwindow_frame): Remove EXFUN.
3048 (replace_buffer_in_all_windows): Remove prototype.
3049 (replace_buffer_in_windows_safely): Add prototype.
3050
3051 * window.c: Declare Qdelete_window static again. Move down
3052 declaration of select_count.
3053 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3054 (Fother_window): Move to window.el.
3055 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3056 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3057 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3058 window.el.
3059 (replace_buffer_in_windows): Implement by calling
3060 Qreplace_buffer_in_windows.
3061 (replace_buffer_in_all_windows): Remove with some functionality
3062 moved into replace_buffer_in_windows_safely.
3063 (replace_buffer_in_windows_safely): New function.
3064 (select_window_norecord, select_frame_norecord): Move in front
3065 of run_window_configuration_change_hook. Remove now obsolete
3066 declarations.
3067 (Fset_window_buffer): Rewrite doc-string.
3068 Call Qrecord_window_buffer.
3069 (keys_of_window): Move binding for other-window to window.el.
3070
3071 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3072
3073 * dispextern.h (struct image): Replace data member, whose int_val
3074 and ptr_val fields were not used by anything, with a single
3075 lisp_val object.
3076
3077 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3078 (gif_clear_image, gif_load, imagemagick_load_image)
3079 (gs_clear_image, gs_load): Callers changed.
3080
3081 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * buffer.h: Include <time.h>, for time_t.
3084 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3085
3086 Fix minor problems found by static checking.
3087
3088 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3089
3090 Make identifiers static if they are not used in other modules.
3091 * data.c (Qcompiled_function, Qframe, Qvector):
3092 * image.c (QimageMagick, Qsvg):
3093 * minibuf.c (Qmetadata):
3094 * window.c (resize_window_check, resize_root_window): Now static.
3095 * window.h (resize_window_check, resize_root_window): Remove decls.
3096
3097 * window.c (window_deletion_count, delete_deletable_window):
3098 Remove; unused.
3099 (window_body_lines): Now static.
3100 (Fdelete_other_windows_internal): Mark vars as initialized.
3101 Make sure 'resize_failed' is initialized.
3102 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3103 (resize_window_apply): Remove unused local.
3104 * window.h (delete_deletable_window): Remove decl.
3105
3106 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3107 (imagemagick_load_image): Fix pointer signedness problem by changing
3108 last arg from unsigned char * to char *. All uses changed.
3109 Also, fix a local for similar reasons.
3110 Remove unused locals. Remove locals to avoid shadowing.
3111 (fn_rsvg_handle_free): Remove; unused.
3112 (svg_load, svg_load_image): Fix pointer signedness problem.
3113 (imagemagick_load_image): Don't use garbage pointer image_wand.
3114
3115 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3116
3117 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3118
3119 * image.c (gif_load): Fix omitted cast error introduced by
3120 2011-06-06 change.
3121
3122 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3123
3124 * window.h (resize_proportionally, orig_total_lines)
3125 (orig_top_line): Remove from window structure.
3126 (set_window_height, set_window_width, change_window_heights)
3127 (Fdelete_window): Remove prototypes.
3128 (resize_frame_windows): Remove duplicate declaration.
3129
3130 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3131
3132 * window.h (resize_frame_windows, resize_window_check)
3133 (delete_deletable_window, resize_root_window)
3134 (resize_frame_windows): Declare prototypes.
3135
3136 * window.c (resize_window_apply): Make definition be "static" to
3137 match the prototype.
3138
3139 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3140
3141 * window.c: Remove declarations of Qwindow_size_fixed,
3142 window_min_size_1, window_min_size_2, window_min_size,
3143 size_window, window_fixed_size_p, enlarge_window, delete_window.
3144 Remove static from declaration of Qdelete_window, it's
3145 temporarily needed by Fbury_buffer.
3146 (replace_window): Don't assign orig_top_line and
3147 orig_total_lines.
3148 (Fdelete_window, delete_window): Remove. Window deletion is
3149 handled by window.el.
3150 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3151 Replace Fdelete_window calls with calls to Qdelete_window.
3152 (Fdelete_other_windows): Remove. Deleting other windows is
3153 handled by window.el.
3154 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3155 handled in window.el.
3156 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3157 Window minimum sizes are handled in window.el.
3158 (shrink_windows, size_window, set_window_height)
3159 (set_window_width, change_window_heights, window_height)
3160 (window_width, CURBEG, CURSIZE, enlarge_window)
3161 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3162 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3163 handled in window.el.
3164 (make_dummy_parent): Rename to make_parent_window and give it a
3165 second argument horflag.
3166 (make_window): Don't set resize_proportionally any more.
3167 (Fsplit_window): Remove. Windows are split in window.el.
3168 (save_restore_action, save_restore_orig_size)
3169 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3170 Resize mini windows in window.el.
3171 (grow_mini_window, shrink_mini_window): Implement by calling
3172 Qresize_root_window_vertically, resize_window_check and
3173 resize_window_apply.
3174 (saved_window, Fset_window_configuration, save_window_save):
3175 Do not handle orig_top_line, orig_total_lines, and
3176 resize_proportionally.
3177 (window_min_height, window_min_width): Move to window.el.
3178 (keys_of_window): Move bindings for delete-other-windows,
3179 split-window, delete-window and enlarge-window to window.el.
3180
3181 * buffer.c: Temporarily extern Qdelete_window.
3182 (Fbury_buffer): Temporarily call Qdelete_window instead of
3183 Fdelete_window (Fbury_buffer will move to window.el soon).
3184
3185 * frame.c (set_menu_bar_lines_1): Remove code handling
3186 orig_top_line and orig_total_lines.
3187
3188 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3189 set_window_height but set heights directly.
3190 (change_frame_size_1): Use resize_frame_windows.
3191
3192 * xdisp.c (init_xdisp): Don't use set_window_height but set
3193 heights directly.
3194
3195 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3196 Use resize_frame_windows instead of change_window_heights and run
3197 run_window_configuration_change_hook.
3198
3199 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3200 instead of change_window_heights and run
3201 run_window_configuration_change_hook.
3202
3203 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3204
3205 * window.c (replace_window): Rename second argument REPLACEMENT to
3206 NEW. New third argument SETFLAG. Rewrite.
3207 (delete_window, make_dummy_parent): Call replace_window with
3208 third argument 1.
3209 (window_list_1): Move down in code.
3210 (run_window_configuration_change_hook): Move set_buffer part
3211 before select_frame_norecord part in order to unwind correctly.
3212 Rename count1 to count.
3213 (recombine_windows, delete_deletable_window, resize_root_window)
3214 (Fdelete_other_windows_internal)
3215 (Frun_window_configuration_change_hook, make_parent_window)
3216 (resize_window_check, resize_window_apply, Fresize_window_apply)
3217 (resize_frame_windows, Fsplit_window_internal)
3218 (Fdelete_window_internal, Fresize_mini_window_internal):
3219 New functions.
3220 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3221
3222 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3223
3224 * window.h (window): Add some new members to window structure -
3225 normal_lines, normal_cols, new_total, new_normal, clone_number,
3226 splits, nest, prev_buffers, next_buffers.
3227 (WINDOW_TOTAL_SIZE): Move here from window.c.
3228 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3229
3230 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3231 Remove.
3232 (make_dummy_parent): Set new members of windows structure.
3233 (make_window): Move down in code. Handle new members of window
3234 structure.
3235 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3236 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3237 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3238 (Fset_window_prev_buffers, Fwindow_next_buffers)
3239 (Fset_window_next_buffers, Fset_window_clone_number):
3240 New functions.
3241 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3242 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3243 Doc-string fixes.
3244 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3245 Argument WINDOW can be now internal window too.
3246 (Fwindow_use_time): Move up in code.
3247 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3248 Rewrite doc-string.
3249 (Fset_window_configuration, saved_window)
3250 (Fcurrent_window_configuration, save_window_save): Handle new
3251 members of window structure.
3252 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3253 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3254 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3255 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3256 Qget_mru_window, Qresize_root_window,
3257 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3258 Qauto_buffer_name; staticpro them.
3259
3260 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3261
3262 * window.c (Fwindow_total_size, Fwindow_left_column)
3263 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3264 (Fwindow_list_1): New functions.
3265 (window_box_text_cols): Replace with window_body_cols.
3266 (Fwindow_width, Fscroll_left, Fscroll_right):
3267 Use window_body_cols instead of window_box_text_cols.
3268 (delete_window, Fset_window_configuration):
3269 Call delete_all_subwindows with window as argument.
3270 (delete_all_subwindows): Take a window as argument and not a
3271 structure. Rewrite.
3272 (window_loop): Remove handling of GET_LRU_WINDOW and
3273 GET_LARGEST_WINDOW.
3274 (Fget_lru_window, Fget_largest_window): Move to window.el.
3275
3276 * window.h: Extern window_body_cols instead of
3277 window_box_text_cols. delete_all_subwindows now takes a
3278 Lisp_Object as argument.
3279
3280 * indent.c (compute_motion, Fcompute_motion):
3281 Use window_body_cols instead of window_box_text_cols.
3282
3283 * frame.c (delete_frame): Call delete_all_subwindows with root
3284 window as argument.
3285
3286 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3287
3288 * fns.c (Fputhash): Document return value.
3289
3290 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3291
3292 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3293
3294 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3295
3296 Cons<->int and similar integer overflow fixes (Bug#8794).
3297
3298 Check for overflow when converting integer to cons and back.
3299 * charset.c (Fdefine_charset_internal, Fdecode_char):
3300 Use cons_to_unsigned to catch overflow.
3301 (Fencode_char): Use INTEGER_TO_CONS.
3302 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3303 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3304 * data.c (long_to_cons, cons_to_long): Remove.
3305 (cons_to_unsigned, cons_to_signed): New functions.
3306 These signal an error for invalid or out-of-range values.
3307 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3308 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3309 * font.c (Ffont_variation_glyphs):
3310 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3311 * lisp.h: Include <intprops.h>.
3312 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3313 (cons_to_signed, cons_to_unsigned): New decls.
3314 (long_to_cons, cons_to_long): Remove decls.
3315 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3316 (Fprimitive_undo): Use CONS_TO_INTEGER.
3317 * xfns.c (Fx_window_property): Likewise.
3318 * xselect.c: Include <limits.h>.
3319 (x_own_selection, selection_data_to_lisp_data):
3320 Use INTEGER_TO_CONS.
3321 (x_handle_selection_request, x_handle_selection_clear)
3322 (x_get_foreign_selection, Fx_disown_selection_internal)
3323 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3324 (lisp_data_to_selection_data): Use cons_to_unsigned.
3325 (x_fill_property_data): Use cons_to_signed.
3326 Report values out of range.
3327
3328 Check for buffer and string overflow more precisely.
3329 * buffer.h (BUF_BYTES_MAX): New macro.
3330 * lisp.h (STRING_BYTES_MAX): New macro.
3331 * alloc.c (Fmake_string):
3332 * character.c (string_escape_byte8):
3333 * coding.c (coding_alloc_by_realloc):
3334 * doprnt.c (doprnt):
3335 * editfns.c (Fformat):
3336 * eval.c (verror):
3337 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3338 since they may not be the same number.
3339 * editfns.c (Finsert_char):
3340 * fileio.c (Finsert_file_contents):
3341 Likewise for BUF_BYTES_MAX.
3342
3343 * image.c: Use ptrdiff_t, not int, for sizes.
3344 (slurp_file): Switch from int to ptrdiff_t.
3345 All uses changed.
3346 (slurp_file): Check that file size fits in both size_t (for
3347 malloc) and ptrdiff_t (for sanity and safety).
3348
3349 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3350 if b->modtime has its maximal value.
3351
3352 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3353
3354 Don't assume time_t can fit into int.
3355 * buffer.h (struct buffer.modtime): Now time_t, not int.
3356 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3357 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3358
3359 Minor fixes for signed vs unsigned integers.
3360 * character.h (MAYBE_UNIFY_CHAR):
3361 * charset.c (maybe_unify_char):
3362 * keyboard.c (read_char, reorder_modifiers):
3363 XINT -> XFASTINT, since the integer must be nonnegative.
3364 * ftfont.c (ftfont_spec_pattern):
3365 * keymap.c (access_keymap, silly_event_symbol_error):
3366 XUINT -> XFASTINT, since the integer must be nonnegative.
3367 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3368 since it makes no difference and we prefer signed.
3369 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3370 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3371 nonnegative.
3372
3373 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3374
3375 * window.h (Fwindow_frame): Declare.
3376
3377 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3380 (SPARE_MEMORY): Always define.
3381 (LARGE_REQUEST): Remove.
3382 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3383
3384 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3385
3386 * lisp.h: Move EXFUNS for Fframe_root_window,
3387 Fframe_first_window and Fset_frame_selected_window to window.h.
3388
3389 * window.h: Move EXFUNS for Fframe_root_window,
3390 Fframe_first_window and Fset_frame_selected_window here from
3391 lisp.h.
3392
3393 * frame.c (Fwindow_frame, Fframe_first_window)
3394 (Fframe_root_window, Fframe_selected_window)
3395 (Fset_frame_selected_window): Move to window.c.
3396 (Factive_minibuffer_window): Move to minibuf.c.
3397 (Fother_visible_frames_p): New function.
3398
3399 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3400
3401 * window.c (decode_window, decode_any_window): Move up in code.
3402 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3403 (inhibit_frame_unsplittable): Remove unused variable.
3404 (Fwindow_buffer): Move up and rewrite doc-string.
3405 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3406 (Fwindow_prev): New functions.
3407 (Fwindow_frame): Move here from frame.c. Accept any window as
3408 argument.
3409 (Fframe_root_window, Fframe_first_window)
3410 (Fframe_selected_window): Move here from frame.c. Accept frame
3411 or arbitrary window as argument. Update doc-strings.
3412 (Fminibuffer_window): Move up in code.
3413 (Fwindow_minibuffer_p): Move up in code and simplify.
3414 (Fset_frame_selected_window): Move here from frame.c.
3415 Marginal rewrite.
3416 (Fselected_window, select_window, Fselect_window): Move up in
3417 code. Minor doc-string fixes.
3418
3419 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3422 Do not assume that spare memory exists; that assumption is valid
3423 only if SYSTEM_MALLOC.
3424 (LARGE_REQUEST): New macro, so that the issue of large requests
3425 is separated from the issue of spare memory.
3426
3427 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3428
3429 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3430 format. (Bug#8806)
3431
3432 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3433
3434 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3435 before statements.
3436
3437 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3438
3439 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3440
3441 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3442
3443 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3444 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3445
3446 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3447
3448 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3449
3450 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3451
3452 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3453 (x_clipboard_manager_save): Add return value.
3454 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3455 New error handlers.
3456 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3457 Obey Vx_select_enable_clipboard_manager. Catch errors in
3458 x_clipboard_manager_save (Bug#8779).
3459 (Vx_select_enable_clipboard_manager): New variable.
3460 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3461
3462 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3463
3464 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3465
3466 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3467
3468 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3469 in the current matrix if keep_current_p is non-zero.
3470
3471 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3472
3473 * bidi.c (bidi_level_of_next_char): Fix last change.
3474
3475 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3476
3477 Support bidi reordering of text covered by display properties.
3478
3479 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3480 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3481 (bidi_cache_search, bidi_cache_iterator_state)
3482 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3483 (bidi_level_of_next_char, bidi_move_to_visually_next):
3484 Support character positions inside a run of characters covered by a
3485 display string.
3486 (bidi_paragraph_init, bidi_resolve_explicit_1)
3487 (bidi_level_of_next_char): Call bidi_fetch_char and
3488 bidi_fetch_char_advance instead of FETCH_CHAR and
3489 FETCH_CHAR_ADVANCE.
3490 (bidi_init_it): Initialize new members.
3491 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3492 definitions.
3493 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3494 instead of using explicit *_CHAR codes.
3495 (bidi_resolve_explicit, bidi_resolve_weak):
3496 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3497 bidirectional text is supported only in multibyte buffers.
3498 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3499 it to initialize the frame_window_p member of struct bidi_it.
3500 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3501 (bidi_resolve_explicit, bidi_resolve_weak)
3502 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3503 bidi_it->nchars is non-positive.
3504 (bidi_level_of_next_char): Don't try to lookup the cache for the
3505 next/previous character if nothing is cached there yet, or if we
3506 were just reseat()'ed to a new position.
3507
3508 * xdisp.c (set_cursor_from_row): Set start and stop points
3509 according to the row's direction when priming the loop that looks
3510 for the glyph on which to display cursor.
3511 (single_display_spec_intangible_p): Function deleted.
3512 (display_prop_intangible_p): Reimplement to call
3513 handle_display_spec instead of single_display_spec_intangible_p.
3514 Accept 3 additional arguments needed by handle_display_spec.
3515 This fixes incorrect cursor motion across display property with complex
3516 values: lists, `(when COND...)' forms, etc.
3517 (single_display_spec_string_p): Support property values that are
3518 lists with the argument STRING its top-level element.
3519 (display_prop_string_p): Fix the condition for processing a
3520 property that is a list to be consistent with handle_display_spec.
3521 (handle_display_spec): New function, refactored from the
3522 last portion of handle_display_prop.
3523 (compute_display_string_pos): Accept additional argument
3524 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3525 value of a `display' property is a "replacing spec".
3526 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3527 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3528 the display property, but just return a value indicating whether
3529 the display property will replace the characters it covers.
3530 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3531 frame_window_p members of struct bidi_it.
3532 (compute_display_string_pos, compute_display_string_end):
3533 New functions.
3534 (push_it): Accept second argument POSITION, where pop_it should
3535 jump to continue iteration.
3536 (reseat_1): Initialize bidi_it.disp_pos.
3537
3538 * keyboard.c (adjust_point_for_property): Adjust the call to
3539 display_prop_intangible_p to its new signature.
3540
3541 * dispextern.h (struct bidi_it): New member frame_window_p.
3542 (bidi_init_it): Update prototypes.
3543 (display_prop_intangible_p): Update prototype.
3544 (compute_display_string_pos, compute_display_string_end):
3545 Declare prototypes.
3546 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3547 EMACS_INT.
3548
3549 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 Malloc failure behavior now depends on size of allocation.
3552 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3553 * lisp.h: Change signatures accordingly.
3554 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3555 All callers changed. (Bug#8762)
3556
3557 * gnutls.c: Use Emacs's memory allocators.
3558 Without this change, the gnutls library would invoke malloc etc.
3559 directly, which causes problems on non-SYNC_INPUT hosts, and which
3560 runs afoul of improving memory_full behavior. (Bug#8761)
3561 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3562 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3563 xfree instead of the default malloc, realloc, free.
3564 (Fgnutls_boot): No need to check for memory allocation failure,
3565 since xmalloc does that for us.
3566
3567 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3568 * category.c (hash_get_category_set):
3569 * ccl.c (ccl_driver):
3570 * charset.c (Fdefine_charset_internal):
3571 * charset.h (struct charset.hash_index):
3572 * composite.c (get_composition_id, gstring_lookup_cache)
3573 (composition_gstring_put_cache):
3574 * composite.h (struct composition.hash_index):
3575 * dispextern.h (struct image.hash):
3576 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3577 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3578 (hashfn_equal, hashfn_user_defined, make_hash_table)
3579 (maybe_resize_hash_table, hash_lookup, hash_put)
3580 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3581 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3582 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3583 * image.c (make_image, search_image_cache, lookup_image)
3584 (xpm_put_color_table_h):
3585 * lisp.h (struct Lisp_Hash_Table):
3586 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3587 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3588 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3589 * alloc.c (allocate_vectorlike):
3590 Check for overflow in vector size calculations.
3591 * ccl.c (ccl_driver):
3592 Check for overflow when converting EMACS_INT to int.
3593 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3594 need to be updated by these changes.
3595 * fns.c (make_hash_table, maybe_resize_hash_table):
3596 Check for integer overflow with large hash tables.
3597 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3598 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3599 (SXHASH_REDUCE): New macro.
3600 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3601 Use it instead of discarding useful hash info with large hash values.
3602 (sxhash_float): New function.
3603 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3604 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3605 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3606 Rewrite to use FIXNUM_BITS, as this simplifies things.
3607 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3608 Adjust signatures to match updated version of code.
3609 (consing_since_gc): Now EMACS_INT, since a single hash table can
3610 use more than INT_MAX bytes.
3611
3612 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3613
3614 Make it possible to build with GCC-4.6+ -O2 -flto.
3615
3616 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3617
3618 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3619
3620 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3621 Call minibuffer-inactive-mode.
3622
3623 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3626 Update dependencies.
3627
3628 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3629
3630 * data.c (init_data): Remove code for UTS, this system is not
3631 supported anymore.
3632
3633 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3634
3635 Don't force ./temacs to start in terminal mode.
3636
3637 * frame.c (make_initial_frame): Initialize faces in all cases, not
3638 only when CANNOT_DUMP is defined.
3639 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3640
3641 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3642
3643 * dispnew.c (add_window_display_history): Use const for the string
3644 pointer. Remove declaration, not needed.
3645
3646 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 Use 'inline', not 'INLINE'.
3649 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3650 * alloc.c, fontset.c (INLINE): Remove.
3651 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3652 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3653 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3654 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3655 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3656
3657 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3658
3659 Make it possible to run ./temacs.
3660
3661 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3662 syms_of_callproc does the same thing. Remove test for
3663 "initialized", do it in the caller.
3664 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3665
3666 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3667
3668 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3669 (read_minibuf): Use get_minibuffer.
3670 (syms_of_minibuf): Use DEFSYM.
3671 (Qmetadata): New var.
3672 * data.c (Qbuffer): Don't make it static.
3673 (syms_of_data): Use DEFSYM.
3674
3675 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3676
3677 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3678 (CCL_CODE_MIN): New macro.
3679
3680 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3681
3682 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3683
3684 * eval.c (Qdebug): Now static.
3685 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3686 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3687 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3688
3689 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3690
3691 * image.c: Various fixes to ImageMagick code comments.
3692 (Fimagemagick_types): Doc fix.
3693
3694 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 Minor fixes prompted by GCC 4.6.0 warnings.
3697
3698 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3699
3700 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3701 (x_clipboard_manager_save_all): Move extern decl to ...
3702 * xterm.h: ... here, so that it can be checked for consistency.
3703
3704 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3705
3706 * xselect.c (x_clipboard_manager_save_frame)
3707 (x_clipboard_manager_save_all): New functions.
3708 (Fx_clipboard_manager_save): Lisp function deleted.
3709
3710 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3711 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3712
3713 * xterm.h: Update prototype.
3714
3715 2011-05-28 William Xu <william.xwl@gmail.com>
3716
3717 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3718 exiting (Bug#8239).
3719
3720 2011-05-28 Jim Meyering <meyering@redhat.com>
3721
3722 Avoid a sign-extension bug in crypto_hash_function.
3723 * fns.c (to_uchar): Define.
3724 (crypto_hash_function): Use it to convert some newly-signed
3725 variables to unsigned, to avoid sign-extension bugs. For example,
3726 without this change, (md5 "truc") would evaluate to
3727 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3728 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3729 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3730
3731 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 Integer overflow fixes.
3734
3735 * dbusbind.c: Serial number integer overflow fixes.
3736 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3737 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3738 to hold a serial number that is too large for a fixnum.
3739 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3740 Check for serial numbers out of range. Decode any serial number
3741 that was so large that it became a float. (Bug#8722)
3742
3743 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3744 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3745 Use XFASTINT rather than XUINT when numbers are nonnegative.
3746 (xd_append_arg, Fdbus_method_return_internal):
3747 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3748 arguments, check that Lisp number is nonnegative, rather than
3749 silently wrapping negative numbers around. (Bug#8722)
3750 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3751 (Bug#8722)
3752
3753 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3754
3755 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3756
3757 ccl: add integer overflow checks
3758 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3759 (IN_INT_RANGE): New macros.
3760 (ccl_driver): Use them to check for integer overflow when
3761 decoding a CCL program. Many of the new checks are whether XINT (x)
3762 fits in int; it doesn't always, on 64-bit hosts. The new version
3763 doesn't catch all possible integer overflows, but it's an
3764 improvement. (Bug#8719)
3765
3766 * alloc.c (make_event_array): Use XINT, not XUINT.
3767 There's no need for unsigned here.
3768
3769 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3770 This follows up to the 2011-05-06 change that substituted uintptr_t
3771 for EMACS_INT. This case wasn't caught back then.
3772
3773 Rework Fformat to avoid integer overflow issues.
3774 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3775 now (part of C89). Include <verify.h>.
3776 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3777 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3778 (Fformat): Avoid the prepass trying to compute sizes; it was only
3779 approximate and thus did not catch overflow reliably. Instead, walk
3780 through the format just once, formatting and computing sizes as we go,
3781 checking for integer overflow at every step, and allocating a larger
3782 buffer as needed. Keep track separately whether the format is
3783 multibyte. Keep only the most-recently calculated precision, rather
3784 than them all. Record whether each argument has been converted to
3785 string. Use EMACS_INT, not int, for byte and char and arg counts.
3786 Support field widths and precisions larger than INT_MAX. Avoid
3787 sprintf's undefined behavior with conversion specifications such as %#d
3788 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3789 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3790 formatting out-of-range floating point numbers with int
3791 formats. (Bug#8668)
3792
3793 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3794
3795 * data.c: Avoid integer truncation in expressions involving floats.
3796 * data.c: Include <intprops.h>.
3797 (arith_driver): When there's an integer overflow in an expression
3798 involving floating point, convert the integers to floating point
3799 so that the resulting value does not suffer from catastrophic
3800 integer truncation. For example, on a 64-bit host (* 4
3801 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3802 Do not rely on undefined behavior after integer overflow.
3803
3804 merge count_size_as_multibyte, parse_str_to_multibyte
3805 * character.c, character.h (count_size_as_multibyte):
3806 Rename from parse_str_to_multibyte; all uses changed.
3807 Check for integer overflow.
3808 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3809 since it's now a duplicate of the other. This is more of
3810 a character than a buffer op, so better that it's in character.c.
3811 * fns.c, print.c: Adjust to above changes.
3812
3813 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3814
3815 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3816
3817 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3818
3819 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3820 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3821 (x_clipboard_manager_save): Now static.
3822 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3823
3824 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3825 (crypto_hash_function): Now static.
3826 Fix pointer signedness problems. Avoid unnecessary initializations.
3827
3828 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3829
3830 * termhooks.h (Vselection_alist): Make it terminal-local.
3831
3832 * terminal.c (create_terminal): Initialize it.
3833
3834 * xselect.c: Support for clipboard managers.
3835 (Vselection_alist): Move to termhooks.h as terminal-local var.
3836 (LOCAL_SELECTION): New macro.
3837 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3838 (symbol_to_x_atom): Remove gratuitous arg.
3839 (x_handle_selection_request, lisp_data_to_selection_data)
3840 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3841 (x_own_selection, x_get_local_selection, x_convert_selection):
3842 New arg, specifying work frame. Use terminal-local Vselection_alist.
3843 (some_frame_on_display): Delete unused function.
3844 (Fx_own_selection_internal, Fx_get_selection_internal)
3845 (Fx_disown_selection_internal, Fx_selection_owner_p)
3846 (Fx_selection_exists_p): New optional frame arg.
3847 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3848 (x_handle_selection_clear): Don't treat other terminals with the
3849 same keyboard specially. Use the terminal-local Vselection_alist.
3850 (x_clear_frame_selections): Use Frun_hook_with_args.
3851
3852 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3853
3854 * xterm.h: Add support for those atoms.
3855
3856 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3857
3858 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3859 (converted_selections, conversion_fail_tag): New global variables.
3860 (x_selection_request_lisp_error): Free the above.
3861 (x_get_local_selection): Remove unnecessary code.
3862 (x_reply_selection_request): Args changed; handle arbitrary array
3863 of converted selections stored in converted_selections.
3864 Separate the XChangeProperty and SelectionNotify steps.
3865 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3866 (x_convert_selection): New function.
3867 (x_handle_selection_event): Simplify.
3868 (x_get_foreign_selection): Don't ignore incoming requests while
3869 waiting for an answer; this will fail when we implement
3870 SAVE_TARGETS, and seems unnecessary anyway.
3871 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3872 (Vx_sent_selection_functions): Doc fix.
3873
3874 2011-05-26 Leo Liu <sdl.web@gmail.com>
3875
3876 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3877
3878 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3879
3880 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3881
3882 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3883 for fringe update if it has periodic bitmap.
3884 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3885 and fringe_bitmap_periodic_p.
3886
3887 * fringe.c (get_fringe_bitmap_data): New function.
3888 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3889 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3890 row. Mark glyph row for fringe update if periodicity changed.
3891
3892 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3893 for fringe update unless it has periodic bitmap.
3894
3895 2011-05-25 Kenichi Handa <handa@m17n.org>
3896
3897 * xdisp.c (get_next_display_element): Set correct it->face_id for
3898 a static composition.
3899
3900 2011-05-24 Leo Liu <sdl.web@gmail.com>
3901
3902 * deps.mk (fns.o):
3903 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3904
3905 * fns.c (crypto_hash_function, Fsha1): New function.
3906 (Fmd5): Use crypto_hash_function.
3907 (syms_of_fns): Add Ssha1.
3908
3909 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 * gnutls.c: Remove unused macros.
3912 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3913 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3914 Remove macros that are defined and never used.
3915 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3916
3917 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3918
3919 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3920 (Fx_get_selection_internal): Minor cleanup.
3921 (Fx_own_selection_internal): Rename arguments for consistency with
3922 select.el.
3923
3924 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3925
3926 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3927
3928 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3929
3930 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3931
3932 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3933
3934 * dispnew.c (scrolling_window): Don't exclude the case that the
3935 last enabled row in the desired matrix touches the bottom boundary.
3936
3937 2011-05-21 Glenn Morris <rgm@gnu.org>
3938
3939 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3940 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3941 and add some more files.
3942
3943 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3944
3945 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3946 report_file_error introduced by the change from 2011-05-07.
3947
3948 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 * systime.h (Time): Define only if emacs is defined.
3951 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3952 where the include path doesn't have X11/X.h by default. See
3953 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3954
3955 2011-05-20 Kenichi Handa <handa@m17n.org>
3956
3957 * composite.c (find_automatic_composition): Fix previous change.
3958
3959 2011-05-20 Glenn Morris <rgm@gnu.org>
3960
3961 * lisp.mk: New file, split from Makefile.in.
3962 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3963 (shortlisp): Remove.
3964 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3965
3966 2011-05-19 Glenn Morris <rgm@gnu.org>
3967
3968 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3969 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3970 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3971 (lisp): Set the order to that of loadup.el.
3972 (shortlisp): Make it a copy of $lisp.
3973 (SOME_MACHINE_LISP): Remove.
3974 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3975 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3976
3977 2011-05-18 Kenichi Handa <handa@m17n.org>
3978
3979 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3980 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3981 (find_automatic_composition): Mostly rewrite for efficiency.
3982
3983 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3984
3985 * makefile.w32-in: Update dependencies.
3986
3987 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3988
3989 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3990 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3991
3992 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3993
3994 Fix some integer overflow issues, such as string length overflow.
3995
3996 * insdel.c (count_size_as_multibyte): Check for string overflow.
3997
3998 * character.c (lisp_string_width): Check for string overflow.
3999 Use EMACS_INT, not int, for string indexes and lengths; in
4000 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4001 the resulting string length overflows an EMACS_INT; instead,
4002 report a string overflow if no precision given. When checking for
4003 precision exhaustion, use a check that cannot possibly have
4004 integer overflow. (Bug#8675)
4005 * character.h (lisp_string_width): Adjust to new signature.
4006
4007 * alloc.c (string_overflow): New function.
4008 (Fmake_string): Use it. This doesn't change behavior, but saves
4009 a few bytes and will simplify future changes.
4010 * character.c (string_escape_byte8): Likewise.
4011 * lisp.h (string_overflow): New decl.
4012
4013 Fixups, following up to the user-interface timestamp change.
4014 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4015 for UI timestamps, instead of unsigned long.
4016 * msdos.c (mouse_get_pos): Likewise.
4017 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4018 * w32gui.h (Time): Define by including "systime.h" rather than by
4019 declaring it ourselves. (Bug#8664)
4020
4021 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4022 * image.c (clear_image_cache): Likewise.
4023
4024 * term.c (term_mouse_position): Don't assume time_t wraparound.
4025
4026 Be more systematic about user-interface timestamps.
4027 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4028 and sometimes 'EMACS_UINT', to represent these timestamps.
4029 This change causes it to use 'Time' uniformly, as that's what X uses.
4030 This makes the code easier to follow, and makes it easier to catch
4031 integer overflow bugs such as Bug#8664.
4032 * frame.c (Fmouse_position, Fmouse_pixel_position):
4033 Use Time, not unsigned long, for user-interface timestamps.
4034 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4035 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4036 * keyboard.h (last_event_timestamp): Likewise.
4037 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4038 * menu.h (xmenu_show): Likewise.
4039 * term.c (term_mouse_position): Likewise.
4040 * termhooks.h (struct input_event.timestamp): Likewise.
4041 (struct terminal.mouse_position_hook): Likewise.
4042 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4043 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4044 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4045 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4046 what it was before.
4047 * menu.h, termhooks.h: Include "systime.h", for Time.
4048
4049 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4050 Don't assume that the difference between two unsigned long values
4051 can fit into an integer. At this point, we know button_down_time
4052 <= event->timestamp, so the difference must be nonnegative, so
4053 there's no need to cast the result if double-click-time is
4054 nonnegative, as it should be; check that it's nonnegative, just in
4055 case. This bug is triggered when events are more than 2**31 ms
4056 apart (about 25 days). (Bug#8664)
4057
4058 * xselect.c (last_event_timestamp): Remove duplicate decl.
4059 (x_own_selection): Remove needless cast to unsigned long.
4060
4061 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4062 that always fit in int. Use a sentinel instead of a counter, to
4063 avoid a temp and to allay GCC's concerns about possible int overflow.
4064 * frame.h (struct frame): Use int for menu_bar_items_used
4065 instead of EMACS_INT, since it always fits in int.
4066
4067 * menu.c (grow_menu_items): Check for int overflow.
4068
4069 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4070
4071 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4072 Before, the code was not consistent. These values cannot exceed
4073 2**31 - 1 so there's no need to make them unsigned.
4074 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4075 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4076 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4077 as modifiers.
4078 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4079
4080 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4081 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4082 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4083 presumably because the widths might not match.
4084
4085 * window.c (size_window): Avoid needless test at loop start.
4086
4087 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4088
4089 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4090
4091 2011-05-12 Drew Adams <drew.adams@oracle.com>
4092
4093 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4094
4095 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4096
4097 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4098 `width' to `bar_area_x' and `bar_area_width', respectively.
4099 (x_scroll_run): Take account of fringe background extension.
4100
4101 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4102 Rename local vars `left' and `width' to `bar_area_x' and
4103 `bar_area_width', respectively.
4104 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4105 background extension.
4106
4107 2011-05-10 Jim Meyering <meyering@redhat.com>
4108
4109 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4110
4111 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4112
4113 * image.c (Finit_image_library): Return t for built-in image types,
4114 like pbm and xbm. (Bug#8640)
4115
4116 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4117
4118 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4119
4120 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4121
4122 * w32console.c (Fset_screen_color): Doc fix.
4123 (Fget_screen_color): New function.
4124 (syms_of_ntterm): Defsubr it.
4125
4126 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4127 unlink the temporary file if Fcall_process didn't create it in the
4128 first place.
4129 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4130 child process will be redirected to a file specified with `:file'.
4131 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4132 cue to call_process_cleanup not to close that handle.
4133
4134 2011-05-07 Ben Key <bkey76@gmail.com>
4135
4136 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4137 one of two shell specific rules, either bootstrap-temacs-CMD or
4138 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4139 to the previous implementation of the bootstrap-temacs rule.
4140 The bootstrap-temacs-CMD rule is similar to the previous
4141 implementation of the bootstrap-temacs rule except that it
4142 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4143 variable.
4144
4145 These changes, along with some changes to nt/configure.bat,
4146 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4147 earlier fix to add support for --cflags and --ldflags options
4148 that include quotes so that it works whether make uses cmd or
4149 sh as the shell.
4150
4151 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4152
4153 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4154 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4155 is a constant.
4156 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4157 a string. Handle both cases.
4158 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4159 (Fdbus_register_method): Use Qinvalid_function.
4160
4161 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4162
4163 * makefile.w32-in: Update dependencies.
4164 (LISP_H): Add inttypes.h and stdin.h.
4165 (PROCESS_H): Add unistd.h.
4166
4167 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4168
4169 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4170 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4171
4172 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4173
4174 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4175
4176 * term.c (vfatal): Remove stray call to va_end.
4177 It's not needed and the C Standard doesn't allow it here anyway.
4178
4179 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4180 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4181
4182 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4183 bytes.
4184
4185 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4186
4187 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4188
4189 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4190
4191 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4192
4193 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4194
4195 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4196 * charset.c (Fdefine_charset_internal): Don't initialize
4197 charset.code_space[15]. The value was garbage, on hosts with
4198 32-bit int (Bug#8600).
4199
4200 * lread.c (read_integer): Be more consistent with string-to-number.
4201 Use string_to_number to do the actual conversion; this avoids
4202 rounding errors and fixes some other screwups. Without this fix,
4203 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4204 (digit_to_number): Move earlier, for benefit of read_integer.
4205 Return -1 if the digit is out of range for the base, -2 if it is
4206 not a digit in any supported base. (Bug#8602)
4207
4208 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4209
4210 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4211 to match comment at start of function. This also removes a
4212 GCC warning about overflow in a 32+64-bit port.
4213
4214 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4215
4216 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4217 Reported by Stefan Monnier in
4218 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4219 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4220 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4221
4222 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4223 (EMACS_UINTPTR): Likewise, with uintptr_t.
4224
4225 * lisp.h: Prefer 64-bit EMACS_INT if available.
4226 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4227 on 32-bit hosts that have 64-bit int, so that they can access
4228 large files.
4229 However, temporarily disable this change unless the temporary
4230 symbol WIDE_EMACS_INT is defined.
4231
4232 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4233
4234 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4235 This removes an assumption that EMACS_INT and long are the same
4236 width as pointers. The assumption is true for Emacs porting targets
4237 now, but we want to make other targets possible.
4238 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4239 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4240 In the rest of the code, change types of integers that hold casted
4241 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4242 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4243 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4244 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4245 No need to cast type when ORing.
4246 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4247 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4248 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4249 assume EMACS_INT is the same width as char *.
4250 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4251 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4252 Remove no-longer-needed casts.
4253 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4254 (xg_tool_bar_help_callback, xg_make_tool_item):
4255 Use EMACS_INTPTR to hold an integer
4256 that will be cast to void *; this can avoid a GCC warning
4257 if EMACS_INT is not the same width as void *.
4258 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4259 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4260 (current_message_1, set_message_1):
4261 Use a local to convert to proper width without a cast.
4262 * xmenu.c (dialog_selection_callback): Likewise.
4263
4264 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4265 Also, don't assume VALBITS / RAND_BITS is less than 5,
4266 and don't rely on undefined behavior when shifting a 1 left into
4267 the sign bit.
4268 * lisp.h (get_random): Change signature to match.
4269
4270 * lread.c (hash_string): Use size_t, not int, for hash computation.
4271 Normally we prefer signed values; but hashing is special, because
4272 it's better to use unsigned division on hash table sizes so that
4273 the remainder is nonnegative. Also, size_t is the natural width
4274 for hashing into memory. The previous code used 'int', which doesn't
4275 retain enough info to hash well into very large tables.
4276 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4277
4278 * dbusbind.c: Don't possibly lose pointer info when converting.
4279 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4280 Use XPNTR rather than XHASH, so that the high-order bits of
4281 the pointer aren't lost when converting through void *.
4282
4283 * eval.c (Fautoload): Don't double-shift a pointer.
4284
4285 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4286
4287 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * gnutls.c (DEF_GNUTLS_FN):
4290 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4291
4292 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4293
4294 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4295 marker. (Bug#8610)
4296
4297 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4298
4299 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4300 New version that can reserve upto 2GB of heap space.
4301
4302 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4303
4304 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4305
4306 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4307
4308 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4309 `gnutls_certificate_set_x509_key_file'.
4310
4311 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4312
4313 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4314 Update dependencies.
4315
4316 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4317
4318 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4319 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4320 Remove unused parameter `fildes'.
4321 * process.c (read_process_output, send_process): Don't pass it.
4322
4323 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4324
4325 Fix previous change: the library cache is defined in w32.c.
4326 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4327 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4328
4329 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4330
4331 Implement dynamic loading of GnuTLS on Windows.
4332
4333 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4334 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4335 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4336 Declare.
4337
4338 * gnutls.c (Qgnutls_dll): Define.
4339 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4340 (gnutls_*): Declare function pointers.
4341 (init_gnutls_functions): New function to initialize function pointers.
4342 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4343 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4344 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4345 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4346 (emacs_gnutls_write, emacs_gnutls_read)
4347 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4348 (Fgnutls_available_p): New function.
4349 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4350 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4351 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4352
4353 * image.c: Include w32.h.
4354 (Vimage_type_cache): Delete.
4355 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4356 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4357 (w32_delayed_load): Move to w32.c.
4358
4359 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4360
4361 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4362 (w32_delayed_load): Move from image.c. When loading a library, record
4363 its filename in the :loaded-from property of the library id.
4364 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4365 Initialize and staticpro them.
4366 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4367
4368 * process.c: Include lisp.h before w32.h, not after.
4369 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4370 instead of gnutls_record_check_pending.
4371
4372 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4373
4374 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4375
4376 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4377 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4378 as passed in.
4379
4380 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4381
4382 * xterm.c (x_set_frame_alpha): Do not set property on anything
4383 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4384
4385 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4386
4387 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4388
4389 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4390
4391 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4392 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4393 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4394 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4395 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4396 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4397 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4398 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4399 (Qgnutls_bootprop_callbacks_verify): Make static.
4400
4401 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4402
4403 * callproc.c: Indentation fixup.
4404
4405 * sysdep.c (wait_for_termination_1): Make static.
4406 (wait_for_termination, interruptible_wait_for_termination):
4407 Move after wait_for_termination_1.
4408
4409 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4410
4411 * sysdep.c (interruptible_wait_for_termination): New function
4412 which is like wait_for_termination, but allows keyboard
4413 interruptions.
4414
4415 * callproc.c (Fcall_process): Add (:file "file") as an option for
4416 the STDOUT buffer.
4417 (Fcall_process_region): Ditto.
4418
4419 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4420
4421 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4422 rather than `XVECTOR (FOO)->size'.
4423
4424 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4425 inttypes.h, as a gnulib replacement is used if it not available in
4426 system headers.
4427
4428 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4429
4430 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4431 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4432 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4433
4434 * coding.c (coding_alloc_by_realloc): Error out if destination
4435 will grow beyond MOST_POSITIVE_FIXNUM.
4436 (decode_coding_emacs_mule): Abort if there isn't enough place in
4437 charbuf for the composition carryover bytes. Reserve an extra
4438 space for up to 2 characters produced in a loop.
4439 (decode_coding_iso_2022): Abort if there isn't enough place in
4440 charbuf for the composition carryover bytes.
4441
4442 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4443
4444 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4445 aborting when %lld or %lll format is passed.
4446 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4447 %llo or %llx format is passed. (Bug#8545)
4448
4449 * window.c (window_scroll_line_based): Use a marker instead of
4450 simple variables to record original value of point. (Bug#7952)
4451
4452 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4453 produced by %s or %c overflows available buffer space. (Bug#8545)
4454
4455 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4456
4457 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4458 (SIZE_MAX): Move defn after all includes, as they might #define it.
4459
4460 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4463
4464 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4465
4466 * keyboard.c (Qdelayed_warnings_hook): Define.
4467 (command_loop_1): Run `delayed-warnings-hook'
4468 if Vdelayed_warnings_list is non-nil.
4469 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4470 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4471
4472 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4473
4474 * doprnt.c (doprnt): Don't return value smaller than the buffer
4475 size if the message was truncated. (Bug#8545).
4476
4477 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4478
4479 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4480 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4481
4482 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4485
4486 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4487
4488 * makefile.w32-in: Update dependencies.
4489
4490 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4491
4492 Improve `doprnt' and its usage. (Bug#8545)
4493 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4494 `format_end'. Remove support for %l as a conversion specifier.
4495 Don't use xrealloc. Improve diagnostics when the %l size modifier
4496 is used. Update the commentary.
4497
4498 * eval.c (verror): Simplify calculation of size_t.
4499
4500 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4501 messages.
4502
4503 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4504
4505 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4506 change.
4507
4508 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4509
4510 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4511 This makes this file independent of the recent pseudovector change.
4512
4513 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4516
4517 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4518 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4519 Remove unused local.
4520 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4521
4522 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4523 GCC 4.6.0 optimizes based on type-based alias analysis.
4524 For example, if b is of type struct buffer * and v of type struct
4525 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4526 != &v->size, and therefore "v->size = 1; b->size = 2; return
4527 v->size;" must therefore return 1. This assumption is incorrect
4528 for Emacs, since it type-puns struct Lisp_Vector * with many other
4529 types. To fix this problem, this patch adds a new type struct
4530 vectorlike_header that documents the constraints on layout of vectors
4531 and pseudovectors, and helps optimizing compilers not get fooled
4532 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4533 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4534 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4535 the size member.
4536 (XSETPVECTYPE): Rewrite in terms of new macro.
4537 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4538 This is a bit clearer, and further avoids the possibility of
4539 undesirable aliasing.
4540 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4541 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4542 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4543 since Lisp_Subr is a special case (no "next" field).
4544 (ASIZE): Now uses header.size rather than size.
4545 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4546 to avoid the hassle of writing XVECTOR (foo)->header.size.
4547 (struct vectorlike_header): New type.
4548 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4549 object, to help avoid aliasing.
4550 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4551 (SUBRP): Likewise, since Lisp_Subr is a special case.
4552 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4553 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4554 (struct Lisp_Hash_Table): Combine first two members into a single
4555 struct vectorlike_header member. All uses of "size" and "next" members
4556 changed to be "header.size" and "header.next".
4557 * buffer.h (struct buffer): Likewise.
4558 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4559 * frame.h (struct frame): Likewise.
4560 * process.h (struct Lisp_Process): Likewise.
4561 * termhooks.h (struct terminal): Likewise.
4562 * window.c (struct save_window_data, struct saved_window): Likewise.
4563 * window.h (struct window): Likewise.
4564 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4565 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4566 * buffer.c (init_buffer_once): Likewise.
4567 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4568 special case.
4569 * process.c (Fformat_network_address): Use local var for size,
4570 for brevity.
4571
4572 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4573
4574 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4575 * data.c (atof): Remove decl; no longer used or needed.
4576 (digit_to_number): Move to lread.c.
4577 (Fstring_to_number): Use new string_to_number function, to be
4578 consistent with how the Lisp reader treats infinities and NaNs.
4579 Do not assume that floating-point numbers represent EMACS_INT
4580 without losing information; this is not true on most 64-bit hosts.
4581 Avoid double-rounding errors, by insisting on integers when
4582 parsing non-base-10 numbers, as the documentation specifies.
4583 * lisp.h (string_to_number): New decl, replacing ...
4584 (isfloat_string): Remove.
4585 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4586 (read1): Do not accept +. and -. as integers; this
4587 appears to have been a coding error. Similarly, do not accept
4588 strings like +-1e0 as floating point numbers. Do not report
4589 overflow for integer overflows unless the base is not 10 which
4590 means we have no simple and reliable way to continue.
4591 Break out the floating-point parsing into a new
4592 function string_to_number, so that Fstring_to_number parses
4593 floating point numbers consistently with the Lisp reader.
4594 (digit_to_number): Move here from data.c. Make it static inline.
4595 (E_CHAR, EXP_INT): Remove, replacing with ...
4596 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4597 (string_to_number): New function, replacing isfloat_string.
4598 This function checks for valid syntax and produces the resulting
4599 Lisp float number too. Rework it so that string-to-number
4600 no longer mishandles examples like "1.0e+". Use strtoumax,
4601 so that overflow for non-base-10 numbers is reported only when
4602 there's no portable and simple way to convert to floating point.
4603
4604 * textprop.c (set_text_properties_1): Rewrite for clarity,
4605 and to avoid GCC warning about integer overflow.
4606
4607 * intervals.h (struct interval): Use EMACS_INT for members
4608 where EMACS_UINT might cause problems. See
4609 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4610 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4611 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4612 All uses changed.
4613 (offset_intervals): Tell GCC not to worry about length overflow
4614 when negating a negative length.
4615
4616 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4617 (overrun_check_free): Likewise.
4618
4619 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4620 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4621 word size.
4622
4623 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4624 (gnutls_make_error): Rename local to avoid shadowing.
4625 (gnutls_emacs_global_deinit): ifdef out; not used.
4626 (Fgnutls_boot): Use const for pointer to readonly storage.
4627 Comment out unused local. Fix pointer signedness problems.
4628
4629 * lread.c (openp): Don't stuff size_t into an 'int'.
4630 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4631 about possible signed overflow.
4632
4633 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4634 (GDK_KEY_g): Don't define if already defined.
4635 (xg_prepare_tooltip): Avoid pointer signedness problem.
4636 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4637
4638 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4639 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4640
4641 * xfns.c (Fx_window_property): Simplify a bit,
4642 to make a bit faster and to avoid GCC 4.6.0 warning.
4643 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4644
4645 * fns.c (internal_equal): Don't assume size_t fits in int.
4646
4647 * alloc.c (compact_small_strings): Tighten assertion a little.
4648
4649 Replace pEd with more-general pI, and fix some printf arg casts.
4650 * lisp.h (pI): New macro, generalizing old pEd macro to other
4651 conversion specifiers. For example, use "...%"pI"d..." rather
4652 than "...%"pEd"...".
4653 (pEd): Remove. All uses replaced with similar uses of pI.
4654 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4655 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4656 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4657 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4658 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4659 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4660 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4661 64-bit hosts.
4662 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4663 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4664 * print.c (safe_debug_print, print_object): Likewise.
4665 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4666 to int.
4667 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4668 avoiding the 0 flag, which is not portable.
4669 * process.c (Fmake_network_process): Use pI to avoid cast.
4670 * region-cache.c (pp_cache): Likewise.
4671 * xdisp.c (decode_mode_spec): Likewise.
4672 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4673 behavior on 64-bit hosts with printf arg.
4674 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4675 (x_stop_queuing_selection_requests): Likewise.
4676 (x_get_window_property): Don't truncate byte count to an 'int'
4677 when tracing.
4678
4679 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4680 here, since it parses constructs like leading '-' and spaces,
4681 which are not wanted; and it overflows with large numbers.
4682 Instead, simply match F[0-9]+, which is what is wanted anyway.
4683
4684 * alloc.c: Remove unportable assumptions about struct layout.
4685 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4686 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4687 (allocate_vectorlike, make_pure_vector): Use the new macros,
4688 plus offsetof, to remove unportable assumptions about struct layout.
4689 These assumptions hold on all porting targets that I know of, but
4690 they are not guaranteed, they're easy to remove, and removing them
4691 makes further changes easier.
4692
4693 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4694 This doesn't fix a bug but makes the code clearer.
4695 (string_overrun_cookie): Now const. Use initializers that
4696 don't formally overflow signed char, to avoid warnings.
4697 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4698 can cause Emacs to crash when string overrun checking is enabled.
4699 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4700 multiple of sizeof (EMACS_INT); it need not be, if
4701 alignof(EMACS_INT) < sizeof (EMACS_INT).
4702 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4703
4704 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4705
4706 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4707
4708 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4709
4710 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4711 supposed to be handshaking. (Bug#8556)
4712 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4713
4714 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4715
4716 * lisp.h (Qdebug): List symbol.
4717 * eval.c (Qdebug): Restore global linkage.
4718 * keyboard.c (debug-on-event): New variable.
4719 (handle_user_signal): Break into debugger when debug-on-event
4720 matches the current signal symbol.
4721
4722 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4723
4724 * alloc.c (check_sblock, check_string_bytes)
4725 (check_string_free_list): Convert to standard C.
4726
4727 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4728
4729 * w32.c (emacs_gnutls_push): Fix typo.
4730
4731 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4732
4733 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4734 "cast to pointer from integer of different size".
4735
4736 Improve doprnt and its use in verror. (Bug#8545)
4737 * doprnt.c (doprnt): Document the set of format control sequences
4738 supported by the function. Use SAFE_ALLOCA instead of always
4739 using `alloca'.
4740
4741 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4742 is one byte too soon. Don't use xrealloc; instead xfree and
4743 xmalloc anew.
4744
4745 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4746
4747 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4748 callbacks stage.
4749
4750 * gnutls.c: Renamed global_initialized to
4751 gnutls_global_initialized. Added internals for the
4752 :verify-hostname-error, :verify-error, and :verify-flags
4753 parameters of `gnutls-boot' and documented those parameters in the
4754 docstring. Start callback support.
4755 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4756 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4757 on error. Return error code.
4758 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4759 (emacs_gnutls_read): Likewise.
4760 (Fgnutls_boot): Return handshake error code.
4761 (emacs_gnutls_handle_error): New function.
4762 (wsaerror_to_errno): Likewise.
4763
4764 * w32.h (emacs_gnutls_pull): Add prototype.
4765 (emacs_gnutls_push): Likewise.
4766
4767 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4768 (emacs_gnutls_push): Likewise.
4769
4770 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4771
4772 * process.c (wait_reading_process_output): Check if GnuTLS
4773 buffered some data internally if no FDs are set for TLS
4774 connections.
4775
4776 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4777 (LIBS): Link to USER_LIBS.
4778 ($(BLD)/gnutls.$(0)): New target.
4779
4780 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4781
4782 * xdisp.c (handle_single_display_spec): Rename the
4783 display_replaced_before_p argument into display_replaced_p, to
4784 make it consistent with the commentary. Fix typos in the
4785 commentary.
4786
4787 * textprop.c (syms_of_textprop): Remove dead code.
4788 (copy_text_properties): Delete obsolete commentary about an
4789 interface that was deleted long ago. Fix typos in the description
4790 of arguments.
4791
4792 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4793 to changes in oldXMenu/XMenu.h from 2011-04-16.
4794 <menu_help_message, prev_menu_help_message>: Constify.
4795 (IT_menu_make_room): menu->help_text is now `const char **';
4796 adjust.
4797
4798 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4799 to changes in oldXMenu/XMenu.h from 2011-04-16.
4800 (struct XMenu): Declare `help_text' `const char **'.
4801
4802 * xfaces.c <Qunspecified>: Make extern again.
4803
4804 * syntax.c: Include sys/types.h before including regex.h, as
4805 required by Posix.
4806
4807 * doc.c (get_doc_string): Improve the format passed to `error'.
4808
4809 * doprnt.c (doprnt): Improve commentary.
4810
4811 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4812
4813 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4814 them with etags.
4815
4816 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4817 changes in globals.h immediately force recompilation.
4818 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4819 $(CURDIR)/s/ms-w32.h.
4820 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4821
4822 * character.c (Fchar_direction): Function deleted.
4823 (syms_of_character): Don't defsubr it.
4824 <char-direction-table>: Deleted.
4825
4826 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4827
4828 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4829 * doprnt.c: Include limits.h.
4830 (SIZE_MAX): New macro.
4831 (doprnt): Return a size_t value. 2nd arg is now size_t.
4832 Many local variables are now size_t instead of int or unsigned.
4833 Improve overflow protection. Support `l' modifier for integer
4834 conversions. Support %l conversion. Don't assume an EMACS_INT
4835 argument for integer conversions and for %c.
4836
4837 * lisp.h (doprnt): Restore prototype.
4838
4839 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4840 $(SRC)/character.h.
4841
4842 * Makefile.in (base_obj): Add back doprnt.o.
4843
4844 * deps.mk (doprnt.o): Add back prerequisites.
4845 (callint.o): Depend on character.h.
4846
4847 * eval.c (internal_lisp_condition_case): Include the handler
4848 representation in the error message.
4849 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4850 when breaking from the loop.
4851
4852 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4853
4854 * callint.c (Fcall_interactively): When displaying error message
4855 about invalid control letter, pass the character's codepoint, not
4856 a pointer to its multibyte form. Improve display of the character
4857 in octal and display also its hex code.
4858
4859 * character.c (char_string): Use %x to display the (unsigned)
4860 codepoint of an invalid character, to avoid displaying a bogus
4861 negative value.
4862
4863 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4864 `error', not SYMBOL_NAME itself.
4865
4866 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4867 character arguments to `error'.
4868
4869 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4870 to `error' in error message about FINAL_CHAR argument. Make sure
4871 FINAL_CHAR is a character, and use %c when it is passed as
4872 argument to `error'.
4873
4874 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4875
4876 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4877
4878 * w32.c: Include <time.h>.
4879 (sys_localtime): New function.
4880
4881 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4882
4883 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4884
4885 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4886
4887 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4888
4889 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4890 zombies (Bug#8467).
4891
4892 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4893
4894 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4895 gl_state.e_property when gl_state.object is Qt.
4896
4897 * insdel.c (make_gap_larger): Remove limitation of buffer size
4898 to <= INT_MAX.
4899
4900 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4901
4902 * xdisp.c (lookup_glyphless_char_display)
4903 (produce_glyphless_glyph): Handle cons cell entry in
4904 glyphless-char-display.
4905 (Vglyphless_char_display): Document it.
4906
4907 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4908 glyphless-char-display.
4909
4910 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4911
4912 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4913
4914 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4915
4916 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4917 definition for no-X builds.
4918
4919 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4920
4921 Static checks with GCC 4.6.0 and non-default toolkits.
4922
4923 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4924
4925 * process.c (keyboard_bit_set): Define only if SIGIO.
4926 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4927 (send_process): Repair possible setjmp clobbering.
4928
4929 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4930
4931 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4932
4933 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4934
4935 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4936 Define only if needed.
4937
4938 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4939 by pacifying GCC about it. Maybe it's time to retire it?
4940 * xfaces.c (USG, __TIMEVAL__): Likewise.
4941
4942 * dispextern.h (struct redisplay_interface): Rename param
4943 to avoid shadowing.
4944 * termhooks.h (struct terminal): Likewise.
4945 * xterm.c (xembed_send_message): Likewise.
4946
4947 * insdel.c (make_gap_smaller): Define only if
4948 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4949
4950 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4951 it.
4952
4953 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4954 so that we aren't warned about unused symbols.
4955
4956 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4957
4958 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4959
4960 * xfns.c (x_real_positions): Mark locals as initialized.
4961
4962 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4963
4964 * xterm.c: Fix problems found by static analysis with other toolkits.
4965 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4966 (x_dispatch_event): Declare static if USE_GTK, and
4967 define if USE_GTK || USE_X_TOOLKIT.
4968 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4969 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4970 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4971 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4972
4973 * xmenu.c (menu_help_callback): Pointer type fixes.
4974 Use const pointers when pointing at readonly data. Avoid pointer
4975 signedness clashes.
4976 (FALSE): Remove unused macro.
4977 (update_frame_menubar): Remove unused decl.
4978
4979 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4980
4981 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4982 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4983 (single_menu_item): Rename local to avoid shadowing.
4984
4985 * keyboard.c (make_lispy_event): Remove unused local var.
4986
4987 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4988 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4989
4990 * bitmaps: Change bitmaps from unsigned char back to the X11
4991 compatible char. Avoid the old compiler warnings about
4992 out-of-range initializers by using, for example, '\xab' rather
4993 than 0xab.
4994
4995 * xgselect.c (xgselect_initialize): Check vs interface
4996 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4997
4998 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4999
5000 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5001 to read-only memory.
5002
5003 * fns.c (vector): Remove; this old hack is no longer needed.
5004
5005 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5006 Remove unused var.
5007 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5008
5009 * xrdb.c (x_load_resources): Omit unused local.
5010
5011 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5012 (x_window): Rename locals to avoid shadowing.
5013 (USG): Use the kludged USG macro, to pacify gcc.
5014
5015 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5016 (x_term_init): Remove local to avoid shadowing.
5017
5018 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5019
5020 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5021 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5022
5023 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5024
5025 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5026
5027 Fix regex.c, syntax.c and friends for buffers > 2GB.
5028 * syntax.h (struct gl_state_s): Declare character position members
5029 EMACS_INT.
5030
5031 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5032
5033 * textprop.c (verify_interval_modification, interval_of):
5034 Declare arguments EMACS_INT.
5035
5036 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5037 EMACS_INT.
5038
5039 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5040
5041 * indent.c (Fvertical_motion): Local variable it_start is now
5042 EMACS_INT.
5043
5044 * regex.c (re_match, re_match_2, re_match_2_internal)
5045 (bcmp_translate, regcomp, regexec, print_double_string)
5046 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5047 (re_compile_pattern, re_exec): Declare arguments and local
5048 variables `size_t' and `ssize_t' and return values `regoff_t', as
5049 appropriate.
5050 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5051 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5052 <compile_stack_type>: `size' and `avail' are now `size_t'.
5053
5054 * regex.h <regoff_t>: Use ssize_t, not int.
5055 (re_search, re_search_2, re_match, re_match_2): Arguments that
5056 specify buffer/string position and length are now ssize_t and
5057 size_t. Return type is regoff_t.
5058
5059 2011-04-16 Ben Key <bkey76@gmail.com>
5060
5061 * nsfont.m: Fixed bugs in ns_get_family and
5062 ns_descriptor_to_entity that were caused by using free to
5063 deallocate memory blocks that were allocated by xmalloc (via
5064 xstrdup). This caused Emacs to crash when compiled with
5065 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5066 --enable-checking=xmallocoverrun). xfree is now used to
5067 deallocate these memory blocks.
5068
5069 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5070
5071 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5072
5073 emacs_write: Accept and return EMACS_INT for sizes.
5074 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5075 et seq.
5076 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5077 Accept and return EMACS_INT.
5078 (emacs_gnutls_write): Return the number of bytes written on
5079 partial writes.
5080 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5081 (emacs_read, emacs_write): Remove check for negative size, as the
5082 Emacs source code has been audited now.
5083 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5084 (emacs_read, emacs_write): Use it.
5085 * process.c (send_process): Adjust to the new signatures of
5086 emacs_write and emacs_gnutls_write. Do not attempt to store
5087 a byte offset into an 'int'; it might overflow.
5088 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5089
5090 * sound.c: Don't assume sizes fit in 'int'.
5091 (struct sound_device.period_size, alsa_period_size):
5092 Return EMACS_INT, not int.
5093 (struct sound_device.write, vox_write, alsa_write):
5094 Accept EMACS_INT, not int.
5095 (wav_play, au_play): Use EMACS_INT to store sizes and to
5096 record read return values.
5097
5098 2011-04-15 Ben Key <bkey76@gmail.com>
5099
5100 * keyboard.c (Qundefined): Don't declare static since it is used
5101 in nsfns.m.
5102 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5103 static since they are used in nsfont.m.
5104
5105 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5106
5107 * process.c (Qprocessp): Don't declare static.
5108 * lisp.h (Qprocessp): Declare again.
5109
5110 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5111
5112 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5113
5114 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5115
5116 Improve C-level modularity by making more things 'static'.
5117
5118 Don't publish debugger-only interfaces to other modules.
5119 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5120 (verify_bytepos, count_markers): Move decls to the only modules
5121 that need them.
5122 * region-cache.h (pp_cache): Likewise.
5123 * window.h (check_all_windows): Likewise.
5124 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5125
5126 * sysdep.c (croak): Now static, if
5127 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5128 * syssignal.h (croak): Declare only if not static.
5129
5130 * alloc.c (refill_memory_reserve): Now static if
5131 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5132 * lisp.h (refill_memory_reserve): Declare only if not static.
5133
5134 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5135 Define only if USE_LUCID.
5136
5137 * xrdb.c (x_customization_string, x_rm_string): Now static.
5138
5139 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5140 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5141
5142 * xdisp.c (draw_row_with_mouse_face): Now static.
5143 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5144
5145 * window.h (check_all_windows): Mark externally visible.
5146
5147 * window.c (window_deletion_count): Now static.
5148
5149 * undo.c: Make symbols static if they're not exported.
5150 (last_undo_buffer, last_boundary_position, pending_boundary):
5151 Now static.
5152
5153 * textprop.c (interval_insert_behind_hooks): Now static.
5154 (interval_insert_in_front_hooks): Likewise.
5155
5156 * term.c: Make symbols static if they're not exported.
5157 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5158 (max_frame_lines, tty_set_terminal_modes):
5159 (tty_reset_terminal_modes, tty_turn_off_highlight):
5160 (get_tty_terminal): Now static.
5161 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5162 * termhooks.h (term_mouse_moveto): Do not declare if
5163 HAVE_WINDOW_SYSTEM.
5164 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5165 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5166
5167 * sysdep.c: Make symbols static if they're not exported.
5168 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5169 Now static.
5170 (sigprocmask_set, full_mask): Remove; unused.
5171 (wait_debugging): Mark as visible.
5172 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5173 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5174
5175 * syntax.c (syntax_temp): Define only if !__GNUC__.
5176
5177 * sound.c (current_sound_device, current_sound): Now static.
5178
5179 * search.c (searchbufs, searchbuf_head): Now static.
5180
5181 * scroll.c (scroll_cost): Remove; unused.
5182 * dispextern.h (scroll_cost): Remove decl.
5183
5184 * region-cache.h (pp_cache): Mark as externally visible.
5185
5186 * process.c: Make symbols static if they're not exported.
5187 (process_tick, update_tick, create_process, chan_process):
5188 (Vprocess_alist, proc_buffered_char, datagram_access):
5189 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5190 (deactivate_process): Mark defn as static, as well as decl.
5191 * lisp.h (create_process): Remove decl.
5192 * process.h (chan_process, Vprocess_alist): Remove decls.
5193
5194 * print.c: Make symbols static if they're not exported.
5195 (print_depth, new_backquote_output, being_printed, print_buffer):
5196 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5197 (print_interval, print_number_index, initial_stderr_stream):
5198 Now static.
5199 * lisp.h (Fprinc): Remove decl.
5200 (debug_output_compilation_hack): Mark as externally visible.
5201
5202 * sysdep.c (croak): Move decl from here to syssignal.h.
5203 * syssignal.h (croak): Put it here, so the API can be checked when
5204 'croak' is called from dissociate_if_controlling_tty.
5205
5206 * minibuf.c: Make symbols static if they're not exported.
5207 (minibuf_save_list, choose_minibuf_frame): Now static.
5208 * lisp.h (choose_minibuf_frame): Remove decl.
5209
5210 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5211
5212 * lread.c: Make symbols static if they're not exported.
5213 (read_objects, initial_obarray, oblookup_last_bucket_number):
5214 Now static.
5215 (make_symbol): Remove; unused.
5216 * lisp.h (initial_obarray, make_symbol): Remove decls.
5217
5218 * keyboard.c: Make symbols static if they're not exported.
5219 (single_kboard, recent_keys_index, total_keys, recent_keys):
5220 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5221 (this_single_command_key_start, echoing, last_auto_save):
5222 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5223 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5224 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5225 (Vlispy_mouse_stem, double_click_count):
5226 Now static.
5227 (force_auto_save_soon): Define only if SIGDANGER.
5228 (ignore_mouse_drag_p): Now static if
5229 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5230 (print_help): Remove; unused.
5231 (stop_character, last_timer_event): Mark as externally visible.
5232 * keyboard.h (ignore_mouse_drag_p): Declare only if
5233 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5234 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5235 * lisp.h (echoing): Remove decl.
5236 (force_auto_save_soon): Declare only if SIGDANGER.
5237 * xdisp.c (redisplay_window): Simplify code, to make it more
5238 obvious that ignore_mouse_drag_p is not accessed if !defined
5239 USE_GTK && !defined HAVE_NS.
5240
5241 * intervals.c: Make symbols static if they're not exported.
5242 (merge_properties_sticky, merge_interval_right, delete_interval):
5243 Now static.
5244 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5245
5246 * insdel.c: Make symbols static if they're not exported.
5247 However, leave prepare_to_modify_buffer alone. It's never
5248 called from outside this function, but that appears to be a bug.
5249 (combine_after_change_list, combine_after_change_buffer):
5250 (adjust_after_replace, signal_before_change): Now static.
5251 (adjust_after_replace_noundo): Remove; unused.
5252 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5253 (signal_before_change): Remove decls.
5254
5255 * indent.c (val_compute_motion, val_vmotion): Now static.
5256
5257 * image.c: Make symbols static if they're not exported.
5258 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5259 if USE_GTK.
5260 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5261 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5262
5263 * fringe.c (standard_bitmaps): Now static.
5264 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5265
5266 * frame.c: Make symbols static if they're not exported.
5267 (x_report_frame_params, make_terminal_frame): Now static.
5268 (get_frame_param): Now static, unless HAVE_NS.
5269 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5270 (x_get_resource_string): Remove; not used.
5271 * frame.h (make_terminal_frame, x_report_frame_params):
5272 (x_get_resource_string); Remove decls.
5273 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5274 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5275
5276 * font.c, fontset.c: Make symbols static if they're not exported.
5277 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5278 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5279 * font.c (font_close_object): Now static.
5280 * font.h (font_close_object): Remove.
5281 * fontset.c (FONTSET_OBJLIST): Remove.
5282 (free_realized_fontset) #if-0 the body, which does nothing.
5283 (face_suitable_for_char_p): #if-0, as it's never called.
5284 * fontset.h (face_suitable_for_char_p): Remove decl.
5285 * xfaces.c (face_at_string_position):
5286 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5287 since 0 is always ASCII.
5288
5289 * fns.c (weak_hash_tables): Now static.
5290
5291 * fileio.c: Make symbols static if they're not exported.
5292 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5293 (Vwrite_region_annotation_buffers): Now static.
5294
5295 * eval.c: Make symbols static if they're not exported.
5296 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5297 * lisp.h (backtrace_list): Remove decl.
5298
5299 * emacs.c: Make symbols static if they're not exported.
5300 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5301 (fatal_error_code, fatal_error_signal_hook, standard_args):
5302 Now static.
5303 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5304 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5305 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5306 * lisp.h (fatal_error_signal_hook): Remove decl.
5307 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5308
5309 * editfns.c: Move a (normally-unused) function to its only use.
5310 * editfns.c, lisp.h (get_operating_system_release): Remove.
5311 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5312 worth the hassle of breaking this out.
5313
5314 * xterm.c: Make symbols static if they're not exported.
5315 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5316 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5317 (x_destroy_window, x_delete_display):
5318 Now static.
5319 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5320 (x_mouse_leave): Remove; unused.
5321 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5322 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5323 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5324 Remove decls.
5325 (x_mouse_leave): Declare only if WINDOWSNT.
5326 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5327 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5328 USE_X_TOOLKIT.
5329
5330 * ftxfont.c: Make symbols static if they're not exported.
5331 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5332 HAVE_FREETYPE.
5333 * font.h (ftxfont_driver): Likewise.
5334
5335 * xfns.c: Make symbols static if they're not exported.
5336 (x_last_font_name, x_display_info_for_name):
5337 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5338 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5339 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5340 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5341 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5342 (last_show_tip_args): Now static.
5343 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5344 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5345 (x_screen_planes): Remove; unused.
5346 * dispextern.h (x_screen_planes): Remove decl.
5347
5348 * dispnew.c: Make symbols static if they're not exported.
5349 * dispextern.h (redraw_garbaged_frames, scrolling):
5350 (increment_row_positions): Remove.
5351 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5352 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5353 Now static.
5354 (redraw_garbaged_frames): Remove; unused.
5355
5356 * xfaces.c: Make symbols static if they're not exported.
5357 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5358 Remove decls.
5359 * xterm.h (defined_color): Remove decls.
5360 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5361 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5362 (menu_face_changed_default, defined_color, free_realized_face):
5363 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5364 (ascii_face_of_lisp_face): Remove; unused.
5365
5366 * xdisp.c: Make symbols static if they're not exported.
5367 * dispextern.h (scratch_glyph_row, window_box_edges):
5368 (glyph_to_pixel_coords, set_cursor_from_row):
5369 (get_next_display_element, set_iterator_to_next):
5370 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5371 (show_mouse_face): Remove decls
5372 * frame.h (message_buf_print): Likewise.
5373 * lisp.h (pop_message, set_message, check_point_in_composition):
5374 Likewise.
5375 * xterm.h (set_vertical_scroll_bar): Likewise.
5376 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5377 (message_buf_print, scratch_glyph_row, displayed_buffer):
5378 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5379 (get_next_display_element, show_mouse_face, window_box_edges):
5380 (frame_to_window_pixel_xy, check_point_in_composition):
5381 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5382 (glyph_to_pixel_coords): Remove; unused.
5383
5384 * dired.c (file_name_completion): Now static.
5385
5386 * dbusbind.c (xd_in_read_queued_messages): Now static.
5387
5388 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5389 * data.c (circular_list_error): Remove.
5390
5391 * commands.h (last_point_position, last_point_position_buffer):
5392 (last_point_position_window): Remove decls.
5393 * keyboard.c: Make these variables static.
5394
5395 * coding.h (coding, code_convert_region, encode_coding_gap):
5396 Remove decls.
5397 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5398 (iso_code_class, detect_coding, code_convert_region): Now static.
5399 (encode_coding_gap): Remove; unused.
5400
5401 * chartab.c (chartab_chars, chartab_bits): Now static.
5402
5403 * charset.h (charset_iso_8859_1): Remove decl.
5404 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5405 Now static.
5406
5407 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5408 * ccl.c (Vccl_program_table): Now static.
5409 (check_ccl_update): Remove; unused.
5410
5411 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5412 * category.h: ... from here.
5413 * category.c (check_category_table, set_category_set): Now static.
5414
5415 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5416 * lisp.h: Remove these decls.
5417
5418 * buffer.c (buffer_count): Remove unused var.
5419
5420 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5421 so that it's not optimized away.
5422 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5423 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5424 exported only to the debugger.
5425
5426 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5427 * atimer.h (run_all_atimers): Remove; not exported.
5428
5429 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5430 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5431 was inaccessible from Lisp.
5432 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5433 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5434
5435 alloc.c: Import and export fewer symbols, and remove unused items.
5436 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5437 is defined.
5438 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5439 it's not optimized away by whole-program optimization.
5440 (message_enable_multibyte, free_misc): Remove.
5441 (catchlist, handlerlist, mark_backtrace):
5442 Declare only if BYTE_MARK_STACK.
5443 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5444 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5445 (message_enable_multibyte): Remove decl.
5446 (free_misc, interval_free_list, float_block, float_block_index):
5447 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5448 (cons_free_list, last_marked_index):
5449 Now static.
5450 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5451 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5452 (mark_backtrace): Define only if BYTE_MARK_STACK.
5453 * xdisp.c (message_enable_multibyte): Now static.
5454
5455 Declare Lisp_Object Q* variables to be 'static' if not exported.
5456 This makes it easier for human readers (and static analyzers)
5457 to see whether these variables are used from other modules.
5458 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5459 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5460 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5461 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5462 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5463 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5464 * xmenu.c, xselect.c:
5465 Declare Q* vars static if they are not used in other modules.
5466 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5467 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5468 Remove decls of unexported vars.
5469 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5470
5471 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5472
5473 Make Emacs functions such as Fatom 'static' by default.
5474 This makes it easier for human readers (and static analyzers)
5475 to see whether these functions can be called from other modules.
5476 DEFUN now defines a static function. To make the function external
5477 so that it can be used in other C modules, use the new macro DEFUE.
5478 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5479 (Finit_image_library):
5480 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5481 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5482 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5483 Remove decls, since these functions are now static.
5484 (Funintern, Fget_internal_run_time): New decls, since these functions
5485 were already external.
5486
5487 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5488 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5489 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5490 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5491 * keyboard.c, keymap.c, lread.c:
5492 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5493 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5494 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5495 Mark functions with DEFUE instead of DEFUN,
5496 if they are used in other modules.
5497 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5498 decls for now-static functions.
5499 * buffer.h (Fdelete_overlay): Remove decl.
5500 * callproc.c (Fgetenv_internal): Mark as internal.
5501 * composite.c (Fremove_list_of_text_properties): Remove decl.
5502 (Fcomposition_get_gstring): New forward static decl.
5503 * composite.h (Fcomposite_get_gstring): Remove decl.
5504 * dired.c (Ffile_attributes): New forward static decl.
5505 * doc.c (Fdocumntation_property): New forward static decl.
5506 * eval.c (Ffetch_bytecode): New forward static decl.
5507 (Funintern): Remove extern decl; now in .h file where it belongs.
5508 * fileio.c (Fmake_symbolic_link): New forward static decl.
5509 * image.c (Finit_image_library): New forward static decl.
5510 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5511 * intervals.h (Fprevious_property_change):
5512 (Fremove_list_of_text_properties): Remove decls.
5513 * keyboard.c (Fthis_command_keys): Remove decl.
5514 (Fcommand_execute): New forward static decl.
5515 * keymap.c (Flookup_key): New forward static decl.
5516 (Fcopy_keymap): Now static.
5517 * keymap.h (Flookup_key): Remove decl.
5518 * process.c (Fget_process): New forward static decl.
5519 (Fprocess_datagram_address): Mark as internal.
5520 * syntax.c (Fsyntax_table_p): New forward static decl.
5521 (skip_chars): Remove duplicate decl.
5522 * textprop.c (Fprevious_property_change): New forward static decl.
5523 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5524 Now internal.
5525 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5526 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5527
5528 * editfns.c (Fformat): Remove unreachable code.
5529
5530 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5531
5532 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5533 change. (Bug#8496)
5534
5535 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5536
5537 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5538 when at ZV. (Bug#8487)
5539
5540 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5541
5542 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5543 (Bug#8437)
5544 * keyboard.c (parse_tool_bar_item): Likewise.
5545 * sound.c (sound_cleanup, alsa_close): Likewise.
5546 * termcap.c (tgetent): Likewise.
5547 * xfns.c (x_default_font_parameter): Likewise.
5548 * xsettings.c (read_and_apply_settings): Likewise.
5549
5550 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5551 (overrun_check_free): Protoize.
5552
5553 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5554
5555 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5556 since callers should never pass a negative size.
5557 Change the signature to match that of plain 'read' and 'write'; see
5558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5559 * lisp.h: Update prototypes of emacs_write and emacs_read.
5560
5561 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5562
5563 * xdisp.c (redisplay_window): Don't try to determine the character
5564 position of the scroll margin if the window start point w->startp
5565 is outside the buffer's accessible region. (Bug#8468)
5566
5567 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5568
5569 Fix write-region and its subroutines for buffers > 2GB.
5570 * fileio.c (a_write, e_write): Modify declaration of arguments and
5571 local variables to support buffers larger than 2GB.
5572 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5573
5574 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5575 argument, local variables, and return value.
5576
5577 * lisp.h: Update prototypes of emacs_write and emacs_read.
5578
5579 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5580
5581 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5584
5585 Fix more problems found by GCC 4.6.0's static checks.
5586
5587 * xdisp.c (vmessage): Use a better test for character truncation.
5588
5589 * charset.c (load_charset_map): <, not <=, for optimization,
5590 and to avoid potential problems with integer overflow.
5591 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5592 * casetab.c (set_identity, shuffle): Likewise.
5593 * editfns.c (Fformat): Likewise.
5594 * syntax.c (skip_chars): Likewise.
5595
5596 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5597 This also lets GCC 4.6.0 generate slightly better loop code.
5598
5599 * callint.c (Fcall_interactively): <, not <=, for optimization.
5600 (Fcall_interactively): Count the number of arguments produced,
5601 not the number of arguments given. This is simpler and lets GCC
5602 4.6.0 generate slightly better code.
5603
5604 * ftfont.c: Distingish more carefully between FcChar8 and char.
5605 The previous code passed unsigned char * to a functions like
5606 strlen and xstrcasecmp that expect char *, which does not
5607 conform to the C standard.
5608 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5609 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5610 char * when the C standard requires it.
5611
5612 * keyboard.c (read_char): Remove unused var.
5613
5614 * eval.c: Port to Windows vsnprintf (Bug#8435).
5615 Include <limits.h>.
5616 (SIZE_MAX): Define if the headers do not.
5617 (verror): Do not give up if vsnprintf returns a negative count.
5618 Instead, grow the buffer. This ports to Windows vsnprintf, which
5619 does not conform to C99. Problem reported by Eli Zaretskii.
5620 Also, simplify the allocation scheme, by avoiding the need for
5621 calling realloc, and removing the ALLOCATED variable.
5622
5623 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5624
5625 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5626 But keep the doprint source code for now, as we might revamp it
5627 and use it again (Bug#8435).
5628 * lisp.h (doprnt): Remove.
5629 * Makefile.in (base_obj): Remove doprnt.o.
5630 * deps.mk (doprnt.o): Remove.
5631
5632 error: Print 32- and 64-bit integers portably (Bug#8435).
5633 Without this change, on typical 64-bit hosts error ("...%d...", N)
5634 was used to print both 32- and 64-bit integers N, which relied on
5635 undefined behavior.
5636 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5637 New macro.
5638 * lisp.h (error, verror): Mark as printf-like functions.
5639 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5640 Report overflow in size calculations when allocating printf buffer.
5641 Do not truncate output string at its first null byte.
5642 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5643 Truncate the output at a character boundary, since vsnprintf does not
5644 do that.
5645 * charset.c (check_iso_charset_parameter): Convert internal
5646 character to string before calling 'error', since %c now has the
5647 printf meaning.
5648 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5649 overflow when computing char to be passed to 'error'. Do not
5650 pass Lisp_Object to 'error'; pass the integer instead.
5651 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5652 formatted with plain %d.
5653
5654 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5655
5656 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5657
5658 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5659
5660 * xterm.c (x_catch_errors): Remove duplicate declaration.
5661
5662 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5663
5664 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5665
5666 2011-04-10 Jim Meyering <meyering@redhat.com>
5667
5668 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5669 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5670 return ssize_t not "int", and use size_t as the buffer length.
5671 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5672 * gnutls.h: Update declarations.
5673 * process.c (read_process_output): Use ssize_t, to match.
5674 (send_process): Likewise.
5675
5676 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5677
5678 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5679
5680 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5681
5682 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5683 Use unsigned char, to match FcChar8 type definition.
5684
5685 * xterm.c (handle_one_xevent):
5686 * xmenu.c (create_and_show_popup_menu):
5687 * xselect.c (x_decline_selection_request)
5688 (x_reply_selection_request): Avoid type-punned deref of X events.
5689
5690 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5691
5692 Fix some uses of `int' instead of EMACS_INT.
5693 * search.c (string_match_1, fast_string_match)
5694 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5695 (scan_buffer, find_next_newline_no_quit)
5696 (find_before_next_newline, search_command, Freplace_match)
5697 (Fmatch_data): Make some `int' variables be EMACS_INT.
5698
5699 * xdisp.c (display_count_lines): 3rd argument and return value now
5700 EMACS_INT. All callers changed.
5701 (pint2hrstr): Last argument is now EMACS_INT.
5702
5703 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5704 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5705 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5706 (decode_coding_utf_16, decode_coding_emacs_mule)
5707 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5708 (decode_coding_ccl, decode_coding_charset)
5709 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5710 (decode_coding_iso_2022, decode_coding_emacs_mule)
5711 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5712 <char_offset, last_offset>: Declare EMACS_INT.
5713 (encode_coding_utf_8, encode_coding_utf_16)
5714 (encode_coding_emacs_mule, encode_invocation_designation)
5715 (encode_designation_at_bol, encode_coding_iso_2022)
5716 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5717 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5718 Declare EMACS_INT.
5719 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5720 (encode_invocation_designation): Last argument P_NCHARS is now
5721 EMACS_INT.
5722 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5723 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5724
5725 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5726 All users changed.
5727
5728 * ccl.c (Fccl_execute_on_string): Declare some variables
5729 EMACS_INT.
5730
5731 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5732
5733 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5734
5735 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5736
5737 * process.c (Fformat_network_address): Doc fix.
5738
5739 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5740
5741 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5742
5743 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5744
5745 * keyboard.c (read_char): Call Lisp function help-form-show,
5746 instead of using internal_with_output_to_temp_buffer.
5747 (Qhelp_form_show): New var.
5748 (syms_of_keyboard): Use DEFSYM macro.
5749
5750 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5751
5752 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5753
5754 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5755
5756 * process.c (Flist_processes): Remove to Lisp.
5757 (list_processes_1): Delete.
5758
5759 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5760
5761 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5762
5763 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5764
5765 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 Fix more problems found by GCC 4.6.0's static checks.
5768
5769 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5770
5771 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5772
5773 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5774
5775 * xdisp.c (vmessage): Mark as a printf-like function.
5776
5777 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5778
5779 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5780
5781 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5782 printf-like functions.
5783 (tiff_load): Add casts to remove these marks before passing them
5784 to system-supplied API.
5785
5786 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5787
5788 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5789 This avoids several warnings with gcc -Wstrict-overflow.
5790 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5791 directly, rather than having caller test rule sign. This avoids
5792 some unnecessary tests.
5793 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5794 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5795 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5796
5797 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5798 (xfont_open): Avoid unnecessary tests.
5799
5800 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5801
5802 * composite.h, composite.c (composition_gstring_put_cache):
5803 Use EMACS_INT, not int, for length.
5804
5805 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5806 breaking out part of COMPOSITION_DECODE_RULE.
5807 (COMPOSITION_DECODE_RULE): Use it.
5808 * composite.c (get_composition_id): Remove unused local vars,
5809 by using the new macro.
5810
5811 * textprop.c (set_text_properties_1): Change while to do-while,
5812 since the condition is always true at first.
5813
5814 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5815 (interval_deletion_adjustment): Return unsigned value.
5816 All uses changed.
5817
5818 * process.c (list_processes_1, create_pty, read_process_output):
5819 (exec_sentinel): Remove vars that were set but not used.
5820 (create_pty): Remove unnecessary "volatile"s.
5821 (Fnetwork_interface_info): Avoid possibility of int overflow.
5822 (read_process_output): Do adaptive read buffering even if carryover.
5823 (read_process_output): Simplify nbytes computation if buffered.
5824
5825 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5826
5827 * syntax.c (scan_words): Remove var that was set but not used.
5828 (update_syntax_table): Use unsigned instead of int.
5829
5830 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5831 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5832 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5833
5834 * print.c (print_error_message): Avoid int overflow.
5835
5836 * font.c (font_list_entities): Redo for clarity,
5837 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5838
5839 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5840 (font_score): Avoid potential overflow in diff calculation.
5841
5842 * fns.c (substring_both): Remove var that is set but not used.
5843 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5844
5845 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5846
5847 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5848 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5849 can always succeed if overflow has undefined behavior.
5850
5851 * search.c (boyer_moore, wordify): Remove vars set but not used.
5852 (wordify): Omit three unnecessary tests.
5853
5854 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5855 All callers changed. This avoids the need for an unused var.
5856
5857 * casefiddle.c (casify_region): Remove var that is set but not used.
5858
5859 * dired.c (file_name_completion): Remove var that is set but not used.
5860
5861 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5862
5863 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5864 (Finsert_file_contents): Remove unnecessary code checking fd.
5865
5866 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5867 Check for integer overflow on size calculations.
5868
5869 * buffer.c (Fprevious_overlay_change): Remove var that is set
5870 but not used.
5871
5872 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5873 Remove vars that are set but not used.
5874 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5875 (timer_check_2): Mark vars as initialized.
5876
5877 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5878
5879 * image.c (lookup_image): Remove var that is set but not used.
5880 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5881
5882 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5883 that are set but not used.
5884
5885 * xfns.c (make_invisible_cursor): Don't return garbage
5886 if XCreateBitmapFromData fails (Bug#8410).
5887
5888 * xselect.c (x_get_local_selection, x_handle_property_notify):
5889 Remove vars that are set but not used.
5890
5891 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5892 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5893
5894 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5895 Remove var that is set but not used.
5896 (scroll_bar_windows_size): Now size_t, not int.
5897 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5898 Check for overflow.
5899
5900 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5901 (map_tty_color) [!defined MSDOS]: Likewise.
5902
5903 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5904
5905 * coding.c: Remove vars that are set but not used.
5906 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5907 All callers changed.
5908 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5909 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5910 (decode_coding_charset): Remove vars that are set but not used.
5911
5912 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5913 that is set but not used.
5914
5915 * print.c (print_object): Remove var that is set but not used.
5916
5917 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5918 The gnulib version avoids calling malloc in the usual case,
5919 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5920 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5921 * filelock.c (current_lock_owner): Likewise.
5922 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5923 * sysdep.c: Include allocator.h, careadlinkat.h.
5924 (emacs_no_realloc_allocator): New static constant.
5925 (emacs_readlink): New function.
5926 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5927 ../lib/careadlinkat.h.
5928
5929 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5930
5931 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5932 first non-nil return value).
5933
5934 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5935
5936 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5937 if not defined (Bug#8403).
5938
5939 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5940
5941 * xdisp.c (display_count_lines): Remove parameter `start',
5942 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5943 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5944 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5945 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5946 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5947 and thereabouts. All callers changed.
5948 (get_per_char_metric): Remove parameter `f', unused since
5949 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5950
5951 2011-04-02 Jim Meyering <meyering@redhat.com>
5952
5953 do not dereference NULL upon failed strdup
5954 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5955 (ns_get_family): Likewise.
5956
5957 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5958
5959 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5960
5961 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5962
5963 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5964 later (Bug#8403).
5965
5966 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5967
5968 Add lexical binding.
5969
5970 * window.c (Ftemp_output_buffer_show): New fun.
5971 (Fsave_window_excursion):
5972 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5973
5974 * lread.c (lisp_file_lexically_bound_p): New function.
5975 (Fload): Bind Qlexical_binding.
5976 (readevalloop): Remove `evalfun' arg.
5977 Bind Qinternal_interpreter_environment.
5978 (Feval_buffer): Bind Qlexical_binding.
5979 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5980 Mark as dynamic.
5981 (syms_of_lread): Declare `lexical-binding'.
5982
5983 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5984
5985 * keyboard.c (eval_dyn): New fun.
5986 (menu_item_eval_property): Use it.
5987
5988 * image.c (parse_image_spec): Use Ffunctionp.
5989
5990 * fns.c (concat, mapcar1): Accept byte-code-functions.
5991
5992 * eval.c (Fsetq): Handle lexical vars.
5993 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5994 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5995 (FletX, Flet): Obey lexical binding.
5996 (Fcommandp): Handle closures.
5997 (Feval): New `lexical' arg.
5998 (eval_sub): New function extracted from Feval. Use it almost
5999 everywhere where Feval was used. Look up vars in lexical env.
6000 Handle closures.
6001 (Ffunctionp): Move from subr.el.
6002 (Ffuncall): Handle closures.
6003 (apply_lambda): Remove `eval_flags'.
6004 (funcall_lambda): Handle closures and new byte-code-functions.
6005 (Fspecial_variable_p): New function.
6006 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6007 but without exporting it to Lisp.
6008
6009 * doc.c (Fdocumentation, store_function_docstring):
6010 * data.c (Finteractive_form): Handle closures.
6011
6012 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6013 interactive spec.
6014
6015 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6016 New byte-codes.
6017 (exec_byte_code): New function extracted from Fbyte_code to handle new
6018 calling convention for byte-code-functions. Add new byte-codes.
6019
6020 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6021
6022 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6023
6024 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6025
6026 * xdisp.c (redisplay_internal): Fix prototype.
6027
6028 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6029
6030 * xdisp.c (SCROLL_LIMIT): New macro.
6031 (try_scrolling): Use it when setting scroll_limit.
6032 Limit scrolling to 100 screen lines.
6033 (redisplay_window): Even when falling back on "recentering",
6034 position point in the window according to scroll-conservatively,
6035 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6036
6037 (try_scrolling): When point is above the window, allow searching
6038 as far as scroll_max, or one screenful, to compute vertical
6039 distance from PT to the scroll margin position. This prevents
6040 try_scrolling from unnecessarily failing when
6041 scroll-conservatively is set to a value slightly larger than the
6042 window height. Clean up the case of PT below the margin at bottom
6043 of window: scroll_max can no longer be INT_MAX. When aggressive
6044 scrolling is in use, don't let point enter the opposite scroll
6045 margin as result of the scroll.
6046 (syms_of_xdisp) <scroll-conservatively>: Document the
6047 threshold of 100 lines for never-recentering scrolling.
6048
6049 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6050
6051 * dispextern.h (move_it_by_lines):
6052 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6053 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6054 (message_log_check_duplicate): Remove parameters `prev_bol' and
6055 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6056 (redisplay_internal): Remove parameter `preserve_echo_area',
6057 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6058
6059 * indent.c (Fvertical_motion):
6060 * window.c (window_scroll_pixel_based, Frecenter):
6061 Don't pass `need_y_p' to `move_it_by_lines'.
6062
6063 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6064
6065 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6066 steal a few bits to be more compact.
6067 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6068 Remove unneeded casts.
6069
6070 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6071
6072 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6073
6074 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6075 binding" message (bug#7967).
6076
6077 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6078
6079 Fix more problems found by GCC 4.6.0's static checks.
6080
6081 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6082 Remove unused local var.
6083
6084 * editfns.c (Fmessage_box): Remove unused local var.
6085
6086 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6087 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6088 Omit unused local vars.
6089 * window.c (shrink_windows): Omit unused local var.
6090 * menu.c (digest_single_submenu): Omit unused local var.
6091 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6092 Omit unused local var.
6093
6094 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6095 Don't assume string length fits in int.
6096 (keyremap_step, read_key_sequence): Use size_t for sizes.
6097 (read_key_sequence): Don't check last_real_key_start redundantly.
6098
6099 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6100 instead of alloca (Bug#8344).
6101
6102 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6103 (Fbacktrace_frame): Don't assume nframes fits in int.
6104
6105 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6106
6107 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6108 concerns.
6109
6110 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6111
6112 * cm.c (calccost): Turn while-do into do-while, for clarity.
6113
6114 * keyboard.c (syms_of_keyboard): Use the same style as later
6115 in this function when indexing through an array. This also
6116 works around GCC bug 48267.
6117
6118 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6119
6120 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6121
6122 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6123 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6124
6125 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6126 This avoids undefined behavior on integer overflow, and is a bit
6127 more convenient anyway since it is compared to a size_t variable.
6128
6129 Variadic C functions now count arguments with size_t, not int.
6130 This avoids an unnecessary limitation on 64-bit machines, which
6131 caused (substring ...) to crash on large vectors (Bug#8344).
6132 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6133 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6134 All variadic functions and their callers changed accordingly.
6135 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6136 * data.c (arith_driver, float_arith_driver): Likewise.
6137 * editfns.c (general_insert_function): Likewise.
6138 * eval.c (struct backtrace.nargs, interactive_p)
6139 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6140 (funcall_lambda, mark_backtrace): Likewise.
6141 * fns.c (concat): Likewise.
6142 * frame.c (x_set_frame_parameters): Likewise.
6143 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6144 0 if not found, not -1. All callers changed.
6145
6146 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6147 (stack_copy_size): Now size_t, not int.
6148 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6149
6150 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6151
6152 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6153 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6154 All callers changed.
6155
6156 * lisp.h (multibyte_char_to_unibyte):
6157 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6158 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6159 * character.h (CHAR_TO_BYTE8):
6160 * cmds.c (internal_self_insert):
6161 * editfns.c (general_insert_function):
6162 * keymap.c (push_key_description):
6163 * search.c (Freplace_match):
6164 * xdisp.c (message_dolog, set_message_1): All callers changed.
6165
6166 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6167
6168 * keyboard.c (safe_run_hook_funcall): New function.
6169 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6170 don't set the hook to nil, but remove the offending function instead.
6171 (Qcommand_hook_internal): Remove, unused.
6172 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6173 Vcommand_hook_internal.
6174
6175 * eval.c (enum run_hooks_condition): Remove.
6176 (funcall_nil, funcall_not): New functions.
6177 (run_hook_with_args): Call each function through a `funcall' argument.
6178 Remove `cond' argument, now redundant.
6179 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6180 (Frun_hook_with_args_until_failure): Adjust accordingly.
6181 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6182
6183 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6184
6185 * dispextern.h (string_buffer_position): Remove declaration.
6186
6187 * print.c (strout): Remove parameter `multibyte', unused since
6188 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6189
6190 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6191 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6192 All callers changed.
6193
6194 * w32.c (_wsa_errlist): Use braces for struct initializers.
6195
6196 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6197 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6198 All callers changed.
6199 (string_buffer_position): Likewise. Also, make static (it's never
6200 used outside xdisp.c).
6201 (cursor_row_p): Remove parameter `w', unused since
6202 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6203 (decode_mode_spec): Remove parameter `precision', introduced during
6204 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6205 All callers changed.
6206
6207 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6208
6209 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6210
6211 2011-03-27 Anders Lindgren <andlind@gmail.com>
6212
6213 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6214 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6215 (ns_update_auto_hide_menu_bar): New functions.
6216 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6217 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6218 ns_constrain_all_frames.
6219 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6220 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6221
6222 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6223
6224 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6225
6226 2011-03-27 Glenn Morris <rgm@gnu.org>
6227
6228 * syssignal.h: Replace RETSIGTYPE with void.
6229 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6230 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6231 Replace SIGTYPE with void everywhere.
6232 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6233 * s/template.h (SIGTYPE): Remove commented out definition.
6234
6235 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6236
6237 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6238 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6239
6240 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6241
6242 * w32.c (read_unc_volume): Use parameter `henum', instead of
6243 global variable `wget_enum_handle'.
6244
6245 * keymap.c (describe_vector): Remove parameters `indices' and
6246 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6247 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6248
6249 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6250
6251 * keyboard.c (timer_check): Remove parameter `do_it_now',
6252 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6253 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6254 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6255
6256 * keyboard.c (read_char):
6257 * w32menu.c (w32_menu_display_help):
6258 * xmenu.c (show_help_event, menu_help_callback):
6259 Adjust calls to `show_help_echo'.
6260
6261 * gtkutil.c (xg_maybe_add_timer):
6262 * keyboard.c (readable_events):
6263 * process.c (wait_reading_process_output):
6264 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6265
6266 * insdel.c (adjust_markers_gap_motion):
6267 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6268 (gap_left, gap_right): Don't call it.
6269
6270 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6271
6272 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6273 incurred during fontification.
6274
6275 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6276
6277 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6278 (DEFVAR_PER_BUFFER): Don't pass it.
6279
6280 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6281 (scrolling_window): Don't pass it.
6282
6283 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6284
6285 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6286
6287 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6288 and `suffix'.
6289 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6290 of variables specific to SELinux and computation of `encoded_absname'.
6291
6292 * image.c (XPutPixel): Remove unused variable `height'.
6293
6294 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6295
6296 * unexw32.c (get_section_info): Remove unused variable `section'.
6297
6298 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6299 (system_process_attributes): Remove unused variable `sess'.
6300 (sys_read): Remove unused variable `err'.
6301
6302 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6303 (w32_wnd_proc): Remove unused variable `isdead'.
6304 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6305 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6306 (x_create_tip_frame): Remove unused variable `tem'.
6307
6308 * w32inevt.c (w32_console_read_socket):
6309 Remove unused variable `no_events'.
6310
6311 * w32term.c (x_draw_composite_glyph_string_foreground):
6312 Remove unused variable `width'.
6313
6314 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6315
6316 * w32term.c (x_set_glyph_string_clipping):
6317 Don't pass uninitialized region to CombineRgn.
6318
6319 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6322 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6323 (Fx_close_connection): Remove unused variable `i'.
6324
6325 * w32font.c (w32font_draw): Return number of glyphs.
6326 (w32font_open_internal): Remove unused variable `i'.
6327 (w32font_driver): Add missing initializer.
6328
6329 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6330 (fill_in_menu): Remove unused variable `items_added'.
6331
6332 * w32term.c (last_mouse_press_frame): Remove static global variable.
6333 (w32_clip_to_row): Remove unused variable `f'.
6334 (x_delete_terminal): Remove unused variable `i'.
6335
6336 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6337 (NOTHING): Remove unused static global variable.
6338 (uniscribe_check_otf): Remove unused variable `table'.
6339 (uniscribe_font_driver): Add missing initializers.
6340
6341 2011-03-23 Julien Danjou <julien@danjou.info>
6342
6343 * term.c (Fsuspend_tty, Fresume_tty):
6344 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6345 * window.c (temp_output_buffer_show):
6346 * insdel.c (signal_before_change):
6347 * frame.c (Fhandle_switch_frame):
6348 * fileio.c (Fdo_auto_save):
6349 * emacs.c (Fkill_emacs):
6350 * editfns.c (save_excursion_restore):
6351 * cmds.c (internal_self_insert):
6352 * callint.c (Fcall_interactively):
6353 * buffer.c (Fkill_all_local_variables):
6354 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6355 Use Frun_hooks.
6356 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6357 unconditionnaly since it does the check itself.
6358
6359 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6360
6361 Fix more problems found by GCC 4.5.2's static checks.
6362
6363 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6364 the first time through the loop, since we know p0 < p1 then.
6365 This also avoids a gcc -Wstrict-overflow warning.
6366
6367 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6368 leading to a memory leak, possible in functions like
6369 load_charset_map_from_file that can allocate an unbounded number
6370 of objects (Bug#8318).
6371
6372 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6373 that could (at least in theory) be that large.
6374
6375 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6376 This is less likely to overflow, and avoids undefined behavior if
6377 overflow does occur. All callers changed. Use strtoul to scan
6378 for the unsigned long integer.
6379 (pint2hrstr): Simplify and tune code slightly.
6380 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6381
6382 * scroll.c (do_scrolling): Work around GCC bug 48228.
6383 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6384
6385 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6386 This also avoids a warning with gcc -Wstrict-overflow.
6387 (validate_x_resource_name): Simplify count usage.
6388 This also avoids a warning with gcc -Wstrict-overflow.
6389
6390 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6391 fail (Bug#8306).
6392
6393 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6394
6395 * process.c (Fmake_network_process): Use socklen_t, not int,
6396 where POSIX says socklen_t is required in portable programs.
6397 This fixes a porting bug on hosts like 64-bit HP-UX, where
6398 socklen_t is wider than int (Bug#8277).
6399 (Fmake_network_process, server_accept_connection):
6400 (wait_reading_process_output, read_process_output):
6401 Likewise.
6402
6403 * process.c: Rename or move locals to avoid shadowing.
6404 (list_processes_1, Fmake_network_process):
6405 (read_process_output_error_handler, exec_sentinel_error_handler):
6406 Rename or move locals.
6407 (Fmake_network_process): Define label "retry_connect" only if needed.
6408 (Fnetwork_interface_info): Fix pointer signedness.
6409 (process_send_signal): Add cast to avoid pointer signedness problem.
6410 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6411 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6412
6413 Make tparam.h and terminfo.c consistent.
6414 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6415 Include tparam.h instead, since it declares them.
6416 * cm.h (PC): Remove extern decl; tparam.h now does this.
6417 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6418 * terminfo.c: Include tparam.h, to check interfaces.
6419 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6420 (tparam): Adjust signature to match interface in tparam.h;
6421 this removes some undefined behavior. Check that outstring and len
6422 are zero, which they always are with Emacs.
6423 * tparam.h (PC, BC, UP): New extern decls.
6424
6425 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6426 (xftfont_open): Rename locals to avoid shadowing.
6427
6428 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6429 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6430 (OTF_TAG_SYM): Omit macro if not needed.
6431 (ftfont_list): Remove unused local.
6432 (get_adstyle_property, ftfont_pattern_entity):
6433 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6434 Rename locals to avoid shadowing.
6435
6436 * xfont.c (xfont_list_family): Mark var as initialized.
6437
6438 * xml.c (make_dom): Now static.
6439
6440 * composite.c (composition_compute_stop_pos): Rename local to
6441 avoid shadowing.
6442 (composition_reseat_it): Remove unused locals.
6443 (find_automatic_composition, composition_adjust_point): Likewise.
6444 (composition_update_it): Mark var as initialized.
6445 (find_automatic_composition): Mark vars as initialized,
6446 with a FIXME (Bug#8290).
6447
6448 character.h: Rename locals to avoid shadowing.
6449 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6450 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6451 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6452 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6453 to avoid shadowing.
6454
6455 * textprop.c (property_change_between_p): Remove; unused.
6456
6457 * intervals.c (interval_start_pos): Now static.
6458
6459 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6460
6461 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6462 Rename locals to avoid shadowing.
6463
6464 * sound.c (wav_play, au_play, Fplay_sound_internal):
6465 Fix pointer signedness.
6466 (alsa_choose_format): Remove unused local var.
6467 (wav_play): Initialize a variable to 0, to prevent undefined
6468 behavior (Bug#8278).
6469
6470 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6471
6472 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6473
6474 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6475 clobbering (Bug#8298).
6476 * sysdep.c (sys_subshell): Likewise.
6477 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6478
6479 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6480 This should get cleaned up, so that child_setup has the
6481 same signature on all platforms.
6482
6483 * callproc.c (call_process_cleanup): Now static.
6484 (relocate_fd): Rename locals to avoid shadowing.
6485
6486 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6487
6488 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6489 not to be necessary, and produces flickering.
6490
6491 2011-03-20 Glenn Morris <rgm@gnu.org>
6492
6493 * config.in: Remove file.
6494
6495 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6496
6497 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6498 are now in src/globals.h.
6499 (syms_of_minibuf): Remove spurious & from previous change.
6500
6501 2011-03-20 Leo <sdl.web@gmail.com>
6502
6503 * minibuf.c (completing-read-function): New variable.
6504 (completing-read-default): Rename from completing-read.
6505 (completing-read): Call completing-read-function.
6506
6507 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * xfaces.c (Fx_load_color_file):
6510 Read color file from absolute filename (bug#8250).
6511
6512 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * makefile.w32-in: Update dependencies.
6515
6516 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6517
6518 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6519
6520 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6521
6522 Fix more problems found by GCC 4.5.2's static checks.
6523
6524 * process.c (make_serial_process_unwind, send_process_trap):
6525 (sigchld_handler): Now static.
6526
6527 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6528 That way, the code declares only the vars that it needs.
6529 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6530 * s/cygwin.h (PTY_ITERATION): Likewise.
6531 * s/darwin.h (PTY_ITERATION): Likewise.
6532 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6533
6534 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6535 * process.c (allocate_pty): Don't declare stb unless it's needed.
6536
6537 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6538 (CONSTANTLIM): Remove; unused.
6539 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6540 Define only if needed.
6541
6542 * unexelf.c (unexec): Name an expression,
6543 to avoid gcc -Wbad-function-cast warning.
6544 Use a different way to cause a compilation error if anyone uses
6545 n rather than nn, a way that does not involve shadowing.
6546 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6547
6548 * deps.mk (unexalpha.o): Remove; unused.
6549
6550 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6551 * unexec.h: New file.
6552 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6553 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6554 Depend on unexec.h.
6555 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6556 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6557 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6558 Change as necessary to match prototype in unexec.h.
6559
6560 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6561 shadowing.
6562 (back_comment, skip_chars): Mark vars as initialized.
6563
6564 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6565 Rename locals to avoid shadowing.
6566
6567 * lread.c (read1): Rewrite so as not to use empty "else".
6568 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6569
6570 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6571
6572 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6573 warning when compiling print.c.
6574
6575 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6576 instead of using an uninitialized var.
6577 (font_sort_entities): Mark var as initialized.
6578
6579 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6580
6581 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6582 pointers to constants.
6583 (font_parse_fcname): Remove unused vars.
6584 (font_delete_unmatched): Now static.
6585 (font_get_spec): Remove; unused.
6586 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6587 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6588 Rename or move locals to avoid shadowing.
6589
6590 * fns.c (require_nesting_list, require_unwind): Now static.
6591 (Ffillarray): Rename locals to avoid shadowing.
6592
6593 * floatfns.c (domain_error2): Define only if needed.
6594 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6595
6596 * alloc.c (mark_backtrace): Move decl from here ...
6597 * lisp.h: ... to here, so that it can be checked.
6598
6599 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6600 (Fdefvar): Rewrite so as not to use empty "else".
6601 (lisp_indirect_variable): Name an expression,
6602 to avoid gcc -Wbad-function-cast warning.
6603 (Fdefvar): Rename locals to avoid shadowing.
6604
6605 * callint.c (quotify_arg, quotify_args): Now static.
6606 (Fcall_interactively): Rename locals to avoid shadowing.
6607 Use const pointer when appropriate.
6608
6609 * lisp.h (get_system_name, get_operating_system_release):
6610 Move decls here, to check interfaces.
6611 * process.c (get_operating_system_release): Move decl to lisp.h.
6612 * xrdb.c (get_system_name): Likewise.
6613 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6614 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6615 some of which prompt warnings from gcc -Wbad-function-cast.
6616 (Fformat_time_string, Fencode_time, Finsert_char):
6617 (Ftranslate_region_internal, Fformat):
6618 Rename or remove local vars to avoid shadowing.
6619 (Ftranslate_region_internal): Mark var as initialized.
6620
6621 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6622 avoid shadowing.
6623
6624 * lisp.h (eassert): Check that the argument compiles, even if
6625 ENABLE_CHECKING is not defined.
6626
6627 * data.c (Findirect_variable): Name an expression, to avoid
6628 gcc -Wbad-function-cast warning.
6629 (default_value, arithcompare, arith_driver, arith_error): Now static.
6630 (store_symval_forwarding): Rename local to avoid shadowing.
6631 (Fmake_variable_buffer_local, Fmake_local_variable):
6632 Mark variables as initialized.
6633 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6634
6635 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6636 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6637 Rename locals to avoid shadowing.
6638 (mark_stack): Move local variables into the #ifdef region where
6639 they're used.
6640 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6641 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6642 needed otherwise.
6643 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6644 (GC_STRING_CHARS): Remove; not used.
6645 (Fmemory_limit): Cast sbrk's returned value to char *.
6646
6647 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6648 avoids undefined behavior in theory.
6649
6650 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6651
6652 Use functions, not macros, for up- and down-casing (Bug#8254).
6653 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6654 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6655 to use the following functions instead of these macros.
6656 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6657 EMACS_INT, since callers assume the returned value fits in int.
6658 (upcase1): Likewise, for UPCASE_TABLE.
6659 (uppercasep, lowercasep, upcase): New static inline functions.
6660 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6661 the race-condition problem in the old DOWNCASE.
6662
6663 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6664 Rename locals to avoid shadowing.
6665 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6666 (regex_compile, re_search_2, re_match_2_internal):
6667 Remove unused local vars.
6668 (FREE_VAR): Rewrite so as not to use empty "else",
6669 which gcc can warn about.
6670 (regex_compile, re_match_2_internal): Mark locals as initialized.
6671 (RETALLOC_IF): Define only if needed.
6672 (WORDCHAR_P): Likewise. This one is never needed, but is used
6673 only in a comment talking about a compiler bug, so put inside
6674 the #if 0 of that comment.
6675 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6676 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6677 Remove; unused.
6678
6679 * search.c (boyer_moore): Rename locals to avoid shadowing.
6680 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6681 (PREV_CHAR_BOUNDARY): Likewise.
6682
6683 * search.c (simple_search): Remove unused var.
6684
6685 * dired.c (compile_pattern): Move decl from here ...
6686 * lisp.h: ... to here, so that it can be checked.
6687 (struct re_registers): New forward decl.
6688
6689 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6690
6691 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6692 All uses changed.
6693 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6694 Rename locals to avoid shadowing.
6695 (Fvertical_motion): Mark locals as initialized.
6696
6697 * casefiddle.c (casify_object, casify_region): Now static.
6698 (casify_region): Mark local as initialized.
6699
6700 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6701
6702 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6703 New macros, so that the caller can use some names other than
6704 gcpro1, gcpro2, etc.
6705 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6706 of the new macros.
6707 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6708 argument, for consistency with GCPRO2_VAR, etc: it is now the
6709 prefix of the variable, not the variable itself. All uses
6710 changed.
6711 * dired.c (directory_files_internal, file_name_completion):
6712 Rename locals to avoid shadowing.
6713
6714 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6715 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6716 dired.c's scmp function, had undefined behavior.
6717 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6718 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6719 * buffer.h: ... to here, because these macros use current_buffer,
6720 and the new implementation with inline functions needs to have
6721 current_buffer in scope now, rather than later when the macros
6722 are used.
6723 (downcase, upcase1): New static inline functions.
6724 (DOWNCASE, UPCASE1): Reimplement using these functions.
6725 This avoids undefined behavior in expressions like
6726 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6727 from race conditions in accessing the global variables
6728 case_temp1 and case_temp2.
6729 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6730 * lisp.h (case_temp1, case_temp2): Remove their decls.
6731 * character.h (ASCII_CHAR_P): Move from here ...
6732 * lisp.h: ... to here, so that the inline functions mentioned
6733 above can use them.
6734
6735 * dired.c (directory_files_internal_unwind): Now static.
6736
6737 * fileio.c (file_name_as_directory, directory_file_name):
6738 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6739 Now static.
6740 (file_name_as_directory): Use const pointers when appropriate.
6741 (Fexpand_file_name): Likewise. In particular, newdir might
6742 point at constant storage, so make it a const pointer.
6743 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6744 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6745 signedness issues.
6746 (Fset_file_times, Finsert_file_contents, auto_save_error):
6747 Rename locals to avoid shadowing.
6748
6749 * minibuf.c (choose_minibuf_frame_1): Now static.
6750 (Ftry_completion, Fall_completions): Rename or remove locals
6751 to avoid shadowing.
6752
6753 * marker.c (bytepos_to_charpos): Remove; unused.
6754
6755 * lisp.h (verify_bytepos, count_markers): New decls,
6756 so that gcc does not warn that these functions aren't declared.
6757
6758 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6759 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6760 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6761 (copy_text): Remove unused local var.
6762
6763 * filelock.c (within_one_second): Now static.
6764 (lock_file_1): Rename local to avoid shadowing.
6765
6766 * buffer.c (fix_overlays_before): Mark locals as initialized.
6767 (fix_start_end_in_overlays): Likewise. This function should be
6768 simplified by using pointers-to-pointers, but that's a different
6769 matter.
6770 (switch_to_buffer_1): Now static.
6771 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6772 (report_overlay_modification): Rename locals to avoid shadowing.
6773
6774 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6775 Fix pointer signedness issue.
6776 (sys_subshell): Mark local as volatile if checking for lint,
6777 to suppress a gcc -Wclobbered warning that does not seem to be right.
6778 (MAXPATHLEN): Define only if needed.
6779
6780 * process.c (serial_open, serial_configure): Move decls from here ...
6781 * systty.h: ... to here, so that they can be checked.
6782
6783 * fns.c (get_random, seed_random): Move extern decls from here ...
6784 * lisp.h: ... to here, so that they can be checked.
6785
6786 * sysdep.c (reset_io): Now static.
6787 (wait_for_termination_signal): Remove; unused.
6788
6789 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6790 (copy_keymap_item, append_key, push_text_char_description):
6791 Now static.
6792 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6793 (DENSE_TABLE_SIZE): Remove; unused.
6794 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6795 (describe_map_tree):
6796 Rename locals to avoid shadowing.
6797
6798 * keyboard.c: Declare functions static if they are not used elsewhere.
6799 (echo_char, echo_dash, cmd_error, top_level_2):
6800 (poll_for_input, handle_async_input): Now static.
6801 (read_char, kbd_buffer_get_event, make_lispy_position):
6802 (make_lispy_event, make_lispy_movement, apply_modifiers):
6803 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6804 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6805 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6806 (read_key_sequence, read_char): Mark locals as initialized.
6807 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6808
6809 * keyboard.h (make_ctrl_char): New decl.
6810 (mark_kboards): Move decl here ...
6811 * alloc.c (mark_kboards): ... from here.
6812
6813 * lisp.h (force_auto_save_soon): New decl.
6814
6815 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6816 (DEFINE_DUMMY_FUNCTION): New macro.
6817 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6818 Use it.
6819 (main): Add casts to avoid warnings
6820 if GCC considers string literals to be constants.
6821
6822 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6823
6824 * dbusbind.c: Pointer signedness fixes.
6825 (xd_signature, xd_append_arg, xd_initialize):
6826 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6827 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6828 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6829 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6830
6831 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6832 if GCC considers string literals to be constants.
6833 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6834
6835 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6836
6837 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6838 (print_preprocess, print_object): New macro to fix last change.
6839
6840 * print.c (print_preprocess): Don't forget font objects.
6841
6842 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6843
6844 * emacs.c (USAGE3): Doc fixes.
6845
6846 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6847
6848 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6849 structure.
6850
6851 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6852
6853 * lisp.h (VWindow_system, Qfile_name_history):
6854 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6855 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6856 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6857
6858 * w32select.c: Don't #include "keyboard.h".
6859 (run_protected): Add extern declaration for waiting_for_input.
6860
6861 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6862 * w32console.c (detect_input_pending, read_input_pending)
6863 (encode_terminal_code):
6864 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6865 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6866 (w32_system_caret_y, Qfile_name_history):
6867 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6868 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6869 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6870 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6871 * w32proc.c (Qlocal, report_file_error):
6872 * w32term.c (Vwindow_system, updating_frame):
6873 * w32uniscribe.c (initialized, uniscribe_font_driver):
6874 Remove unneeded extern declarations.
6875
6876 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6877
6878 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6879
6880 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6881
6882 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6883 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6884 These macros can no longer be used for assignment.
6885
6886 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6887 Assign struct members directly, instead of using BUF_BEGV etc.
6888 (record_buffer_markers, fetch_buffer_markers): New functions for
6889 recording and fetching special buffer markers.
6890 (set_buffer_internal_1, set_buffer_temp): Use them.
6891
6892 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6893
6894 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6895
6896 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6897 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6898
6899 * xdisp.c (hscroll_window_tree):
6900 (reconsider_clip_changes): Use PT instead of BUF_PT.
6901
6902 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6903
6904 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6905 $(EMACS_ROOT)/lib/intprops.h.
6906
6907 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6908
6909 Fix more problems found by GCC 4.5.2's static checks.
6910
6911 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6912 to unsigned char * to avoid compiler diagnostic.
6913 (xg_free_frame_widgets): Make it clear that a local variable is
6914 needed only if USE_GTK_TOOLTIP.
6915 (gdk_window_get_screen): Make it clear that this macro is needed
6916 only if USE_GTK_TOOLTIP.
6917 (int_gtk_range_get_value): New function, which avoids a diagnostic
6918 from gcc -Wbad-function-cast.
6919 (xg_set_toolkit_scroll_bar_thumb): Use it.
6920 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6921 diagnostic from gcc -Wbad-function-cast.
6922 (get_utf8_string, xg_get_file_with_chooser):
6923 Rename locals to avoid shadowing.
6924 (create_dialog): Move locals to avoid shadowing.
6925
6926 * xgselect.c (xg_select): Remove unused var.
6927
6928 * image.c (four_corners_best): Mark locals as initialized.
6929 (gif_load): Initialize transparent_p to zero (Bug#8238).
6930 Mark another local as initialized.
6931 (my_png_error, my_error_exit): Mark with NO_RETURN.
6932
6933 * image.c (clear_image_cache): Now static.
6934 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6935 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6936 (x_edge_detection): Remove unnecessary cast that
6937 gcc -Wbad-function-cast diagnoses.
6938 (gif_load): Fix pointer signedness.
6939 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6940 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6941
6942 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6943
6944 Improve quality of tests for time stamp overflow.
6945 For example, without this patch (encode-time 0 0 0 1 1
6946 1152921504606846976) returns the obviously-bogus value (-948597
6947 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6948 reports time overflow. See
6949 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6950 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6951 * editfns.c: Include limits.h and intprops.h.
6952 (TIME_T_MIN, TIME_T_MAX): New macros.
6953 (time_overflow): Move earlier, to before first use.
6954 (hi_time, lo_time): New functions, for an accurate test for
6955 out-of-range times.
6956 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6957 (Fget_internal_run_time): Don't assume time_t fits in int.
6958 (make_time): Use list2 instead of Fcons twice.
6959 (Fdecode_time): More accurate test for out-of-range times.
6960 (check_tm_member): New function.
6961 (Fencode_time): Use it, to test for out-of-range times.
6962 (lisp_time_argument): Don't rely on undefined left-shift and
6963 right-shift behavior when checking for time stamp overflow.
6964
6965 * editfns.c (time_overflow): New function, refactoring common code.
6966 (Fformat_time_string, Fdecode_time, Fencode_time):
6967 (Fcurrent_time_string): Use it.
6968
6969 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6970 * dired.c (make_time): Move to ...
6971 * editfns.c (make_time): ... here.
6972 * systime.h: Note the move.
6973
6974 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6975
6976 * fringe.c (update_window_fringes): Remove unused variables.
6977
6978 * unexmacosx.c (copy_data_segment): Also copy __got section.
6979 (Bug#8223)
6980
6981 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6982
6983 * termcap.c [MSDOS]: Include "msdos.h".
6984 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6985 Constify `char *' arguments and their references according to
6986 prototypes in tparam.h.
6987
6988 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6989
6990 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6991 Adapt all references accordingly.
6992
6993 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6994
6995 2011-03-11 Tom Tromey <tromey@redhat.com>
6996
6997 * buffer.c (syms_of_buffer): Remove obsolete comment.
6998
6999 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7000
7001 * termhooks.h (encode_terminal_code): Declare prototype.
7002
7003 * msdos.c (encode_terminal_code): Don't declare prototype.
7004
7005 * term.c (encode_terminal_code): Now external again, used by
7006 w32console.c and msdos.c.
7007
7008 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7009 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7010
7011 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7012
7013 Fix some minor problems found by GCC 4.5.2's static checks.
7014
7015 * fringe.c (update_window_fringes): Mark locals as initialized
7016 (Bug#8227).
7017 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7018
7019 * alloc.c (mark_fringe_data): Move decl from here ...
7020 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7021 to check its interface.
7022 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7023
7024 * fontset.c (free_realized_fontset): Now static.
7025 (Fset_fontset_font): Rename local to avoid shadowing.
7026 (fontset_font): Mark local as initialized.
7027 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7028
7029 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7030
7031 * xselect.c (x_disown_buffer_selections): Remove; not used.
7032 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7033 (x_own_selection, Fx_disown_selection_internal): Rename locals
7034 to avoid shadowing.
7035 (x_handle_dnd_message): Remove local to avoid shadowing.
7036
7037 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7038 so that the caller can use some name other than gcpro1.
7039 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7040 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7041 (Fx_backspace_delete_keys_p):
7042 Use them to avoid shadowing, and rename vars to avoid shadowing.
7043 (x_decode_color, x_set_name, x_window): Now static.
7044 (Fx_create_frame): Add braces to silence GCC warning.
7045 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7046 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7047 Remove unused locals.
7048 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7049 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7050 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7051 macros.
7052
7053 * xterm.h (x_mouse_leave): New decl.
7054
7055 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7056 Remove unused functions.
7057 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7058 (x_calc_absolute_position): Now static.
7059 (XTread_socket): Don't define label "out" unless it's used.
7060 Don't declare local "event" unless it's used.
7061 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7062 unless they are used.
7063 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7064 (x_fatal_error_signal): Remove; not used.
7065 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7066 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7067 (x_error_catcher, x_connection_closed, x_error_handler):
7068 (x_error_quitter, xembed_send_message, x_iconify_frame):
7069 (my_log_handler): Rename locals to avoid shadowing.
7070 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7071 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7072
7073 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7074 Rename or move locals to avoid shadowing.
7075 (tty_defined_color, merge_face_heights): Now static.
7076 (free_realized_faces_for_fontset): Remove; not used.
7077 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7078 does not deduce is never used uninitialized.
7079 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7080 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7081
7082 * terminal.c (store_terminal_param): Now static.
7083
7084 * xmenu.c (menu_highlight_callback): Now static.
7085 (set_frame_menubar): Remove unused local.
7086 (xmenu_show): Rename parameter to avoid shadowing.
7087 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7088 since they might point to immutable storage.
7089 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7090 since it's unused otherwise.
7091
7092 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7093 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7094 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7095 avoids a gcc -Wuninitialized diagnostic.
7096 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7097 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7098 does not deduce are never used uninitialized.
7099
7100 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7101
7102 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7103 * window.c (window_loop, size_window):
7104 (run_window_configuration_change_hook, enlarge_window): Likewise.
7105
7106 * window.c (display_buffer): Now static.
7107 (size_window): Mark variables that gcc -Wuninitialized
7108 does not deduce are never used uninitialized.
7109 * window.h (check_all_windows): New decl, to forestall
7110 gcc -Wmissing-prototypes diagnostic.
7111 * dispextern.h (bidi_dump_cached_states): Likewise.
7112
7113 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7114 shadowing.
7115 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7116 Include <limits.h>.
7117 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7118 and to avoid gcc -Wuninitialized warning.
7119 (load_charset_map): Mark variables that gcc -Wuninitialized
7120 does not deduce are never used uninitialized.
7121 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7122
7123 * coding.c (coding_set_source, coding_set_destination):
7124 Use "else { /* comment */ }" rather than "else /* comment */;"
7125 for clarity, and to avoid gcc -Wempty-body warning.
7126 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7127 a block, when the outer 'i' will do.
7128 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7129 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7130 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7131 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7132 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7133 Rename locals to avoid shadowing.
7134 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7135 * coding.c (emacs_mule_char, encode_invocation_designation):
7136 Now static, since they're not used elsewhere.
7137 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7138 (decode_coding_object, encode_coding_object, detect_coding_system):
7139 (decode_coding_emacs_mule): Mark variables that gcc
7140 -Wuninitialized does not deduce are never used uninitialized.
7141 (detect_coding_iso_2022): Initialize a local variable that might
7142 be used uninitialized. Leave a FIXME because it's not clear that
7143 this initialization is needed. (Bug#8211)
7144 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7145 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7146 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7147 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7148 Remove unused macros.
7149
7150 * category.c (hash_get_category_set): Remove unused local var.
7151 (copy_category_table): Now static, since it's not used elsewhere.
7152 * character.c (string_count_byte8): Likewise.
7153
7154 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7155 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7156
7157 * chartab.c (copy_sub_char_table): Now static, since it's not used
7158 elsewhere.
7159 (sub_char_table_ref_and_range, char_table_ref_and_range):
7160 Rename locals to avoid shadowing.
7161 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7162
7163 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7164 (BIDI_BOB): Remove unused macro.
7165
7166 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7167 deduce are never used uninitialized.
7168 * term.c (encode_terminal_code): Likewise.
7169
7170 * term.c (encode_terminal_code): Now static. Remove unused local.
7171
7172 * tparam.h: New file.
7173 * term.c, tparam.h: Include it.
7174 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7175 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7176 Move these decls to tparam.h, and make them agree with what
7177 is actually in tparam.c. The previous trick of using incompatible
7178 decls in different modules does not conform to the C standard.
7179 All callers of tparam changed to use tparam's actual API.
7180 * tparam.c (tparam1, tparam, tgoto):
7181 Use const pointers where appropriate.
7182
7183 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7184 * cm.h (struct cm): Likewise.
7185 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7186 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7187 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7188 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7189 (turn_on_face, init_tty): Likewise.
7190 * termchar.h (struct tty_display_info): Likewise.
7191
7192 * term.c (term_mouse_position): Rename local to avoid shadowing.
7193
7194 * alloc.c (mark_ttys): Move decl from here ...
7195 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7196
7197 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7198
7199 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7200
7201 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7202
7203 * search.c (compile_pattern_1): Remove argument regp, unused since
7204 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7205 (compile_pattern): Don't pass it.
7206
7207 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7208
7209 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7210 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7211 for ! HAVE_GTK3.
7212 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7213
7214 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7215
7216 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7217 gdk_window_get_screen, gdk_window_get_geometry,
7218 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7219 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7220 (xg_get_pixbuf_from_pixmap): New function.
7221 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7222 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7223 Call xg_get_pixbuf_from_pixmap instead of
7224 gdk_pixbuf_get_from_drawable.
7225 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7226 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7227 (xg_check_special_colors): Use GtkStyleContext and its functions
7228 for HAVE_GTK3.
7229 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7230 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7231 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7232 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7233 Call gtk_widget_get_preferred_size.
7234 (xg_frame_resized): gdk_window_get_geometry only takes 5
7235 parameters.
7236 (xg_win_to_widget, xg_event_is_for_menubar):
7237 Call gdk_x11_window_lookup_for_display.
7238 (xg_set_widget_bg): New function.
7239 (delete_cb): New function.
7240 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7241 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7242 (xg_set_background_color): Call xg_set_widget_bg.
7243 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7244 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7245 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7246 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7247 if ! HAVE_GTK3.
7248 (update_frame_tool_bar): Call gtk_widget_hide.
7249 (xg_initialize): Use GDK_KEY_g.
7250
7251 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7252 if ! HAVE_GTK3
7253 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7254
7255 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7256 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7257 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7258
7259 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7260
7261 * w32xfns.c (select_palette): Check success of RealizePalette against
7262 GDI_ERROR, not zero.
7263
7264 See ChangeLog.11 for earlier changes.
7265
7266 ;; Local Variables:
7267 ;; coding: utf-8
7268 ;; End:
7269
7270 Copyright (C) 2011 Free Software Foundation, Inc.
7271
7272 This file is part of GNU Emacs.
7273
7274 GNU Emacs is free software: you can redistribute it and/or modify
7275 it under the terms of the GNU General Public License as published by
7276 the Free Software Foundation, either version 3 of the License, or
7277 (at your option) any later version.
7278
7279 GNU Emacs is distributed in the hope that it will be useful,
7280 but WITHOUT ANY WARRANTY; without even the implied warranty of
7281 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7282 GNU General Public License for more details.
7283
7284 You should have received a copy of the GNU General Public License
7285 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.