Fix stray '<' from last change.
[bpt/emacs.git] / src / ChangeLog
1 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4 is defined (Bug#11768).
5
6 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
7
8 Fix marker debugging code.
9 * marker.c (byte_char_debug_check): Do not perform the check
10 if buffer is not multibyte.
11 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
12 byte_char_debug_check with correct arguments.
13
14 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
15
16 Compile marker debugging code only if ENABLE_CHECKING is defined.
17 * marker.c (byte_char_debug_check, count_markers): Use
18 only if ENABLE_CHECKING is defined.
19 (byte_debug_flag): Remove.
20 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
21 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
22
23 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
24
25 Avoid code repetition in marker-related functions.
26 * marker.c (attach_marker): New function.
27 (Fset_marker, set_marker_restricted, set_marker_both)
28 (set_marker_restricted_both): Use it.
29 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
30 Consistently rename charno to charpos.
31 (marker_position): Add eassert.
32 (marker_byte_position): Convert to eassert.
33
34 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Simplify list operations in unchain_overlay and unchain_marker.
37 * buffer.c (unchain_overlay): Simplify. Add comment.
38 * marker.c (unchain_marker): Simplify. Fix comments.
39
40 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Introduce fast path for the widely used marker operation.
43 * alloc.c (build_marker): New function.
44 * lisp.h (build_marker): New prototype.
45 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
46 * composite.c (autocmp_chars): Likewise.
47 * editfns.c (buildmark): Remove.
48 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
49 (save_restriction_save): Use build_marker.
50 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
51 * window.c (save_window_save): Likewise.
52
53 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Do not use Fdelete_overlay in delete_all_overlays
56 to avoid redundant calls to unchain_overlay.
57 * buffer.c (drop_overlay): New function.
58 (delete_all_overlays, Fdelete_overlay): Use it.
59 * minibuf.c (get_minibuffer): Fix comment.
60
61 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
62
63 Port to OpenBSD 5.1 amd64.
64 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
65 This is needed for OpenBSD, and should be harmless on all BSD systems.
66 Also, include <sys/sysctl.h>, as it should be available on all
67 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
68 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
69 use p_pid member, not kp_proc.pid.
70
71 2012-07-06 Glenn Morris <rgm@gnu.org>
72
73 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
74
75 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
76
77 More xmalloc and related cleanup.
78 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
79 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
80 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
81 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
82 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
83 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
84 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
85 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
86 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
87 * xterm.c:
88 Omit needless casts involving void * pointers and allocation.
89 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
90 as the former is more robust if P's type is changed.
91 Prefer xzalloc to xmalloc + memset 0.
92 Simplify malloc-or-realloc to realloc.
93 Don't worry about xmalloc returning a null pointer.
94 Prefer xstrdup to xmalloc + strcpy.
95 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
96 growing it.
97 * keyboard.c (apply_modifiers_uncached): Prefer local array to
98 alloca of a constant.
99
100 2012-07-05 Eli Zaretskii <eliz@gnu.org>
101
102 * xdisp.c (display_line): Fix horizontal pixel coordinates when
103 hscroll is larger than the line width. Fixes long and futile
104 looping inside extend_face_to_end_of_line (on a TTY) producing
105 glyphs that are not needed and thrown away.
106
107 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
108
109 * marker.c (set_marker_restricted_both): Simplify by using
110 clip_to_bounds.
111
112 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
113
114 * editfns.c (region_limit): Simplify by using clip_to_bounds.
115
116 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
117
118 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
119 not defined (Bug#11768).
120 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
121 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
122 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
123 followed by gtk_box_set_homogeneous (Bug#11768).
124 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
125 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
126 gtk_scrollbar_new (Bug#11768).
127 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
128 (is_box_type): New function (Bug#11768).
129 (xg_tool_item_stale_p): Call is_box_type.
130 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
131 with default display (Bug#11768).
132
133 2012-07-05 Eli Zaretskii <eliz@gnu.org>
134
135 * xdisp.c (window_hscroll_limited): New function.
136 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
137 coordinates when window's hscroll is set to insanely large
138 values. (Bug#11857)
139
140 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
141
142 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
143 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
144
145 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
146
147 Cleanup xmalloc.
148 * lisp.h (xzalloc): New prototype. Omit needless casts.
149 * alloc.c (xzalloc): New function. Omit needless casts.
150 * charset.c: Omit needless casts. Convert all calls to
151 xmalloc with following memset to xzalloc.
152 * dispnew.c: Likewise.
153 * fringe.c: Likewise.
154 * image.c: Likewise.
155 * sound.c: Likewise.
156 * term.c: Likewise.
157 * w32fns.c: Likewise.
158 * w32font.c: Likewise.
159 * w32term.c: Likewise.
160 * xfaces.c: Likewise.
161 * xfns.c: Likewise.
162 * xterm.c: Likewise.
163 * atimer.c: Omit needless casts.
164 * buffer.c: Likewise.
165 * callproc.c: Likewise.
166 * ccl.c: Likewise.
167 * coding.c: Likewise.
168 * composite.c: Likewise.
169 * doc.c: Likewise.
170 * doprnt.c: Likewise.
171 * editfns.c: Likewise.
172 * emacs.c: Likewise.
173 * eval.c: Likewise.
174 * filelock.c: Likewise.
175 * fns.c: Likewise.
176 * gtkutil.c: Likewise.
177 * keyboard.c: Likewise.
178 * lisp.h: Likewise.
179 * lread.c: Likewise.
180 * minibuf.c: Likewise.
181 * msdos.c: Likewise.
182 * print.c: Likewise.
183 * process.c: Likewise.
184 * region-cache.c: Likewise.
185 * search.c: Likewise.
186 * sysdep.c: Likewise.
187 * termcap.c: Likewise.
188 * terminal.c: Likewise.
189 * tparam.c: Likewise.
190 * w16select.c: Likewise.
191 * w32.c: Likewise.
192 * w32reg.c: Likewise.
193 * w32select.c: Likewise.
194 * w32uniscribe.c: Likewise.
195 * widget.c: Likewise.
196 * xdisp.c: Likewise.
197 * xmenu.c: Likewise.
198 * xrdb.c: Likewise.
199 * xselect.c: Likewise.
200
201 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
202
203 * fileio.c (time_error_value): Check the right error number.
204 Problem reported by Troels Nielsen in
205 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
206
207 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
208
209 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
210 This should be fixed in a better way; see Eli Zaretskii in
211 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
212 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
213
214 * fileio.c (time_error_value): Rename from special_mtime.
215 The old name's problems were noted by Eli Zaretskii in
216 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
217
218 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
219 This variable's comment says Emacs needs at least one GDB-visible
220 symbol of type enum pvec_type, to work around GDB problems.
221 The symbol's value doesn't matter.
222
223 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
224 that causes compilation to fail on pre-C99 compilers.
225
226 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
227
228 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
229 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
230
231 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
232
233 * buffer.c (init_buffer_once): Fix initialization of
234 headers for buffer_defaults and buffer_local_symbols.
235 Reported by Juanma Barranquero <lekktu@gmail.com>.
236
237 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
238
239 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
240 * lisp.h (enum pvec_type): Use fewer bits.
241 (PSEUDOVECTOR_SIZE_BITS): New constant.
242 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
243 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
244 change in pvec_type.
245 (PSEUDOVECTOR_TYPEP): New macro.
246 (TYPED_PSEUDOVECTORP): Use it.
247 * fns.c (internal_equal): Adapt code to extract pvectype.
248 * emacs.c (gdb_pvec_type): Update type.
249 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
250 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
251 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
252 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
253 (sweep_vectors): Use it. Use local var `total_bytes' instead of
254 abusing vector->header.next.nbytes.
255 (live_vector_p): Use PVEC_TYPE.
256 (mark_object): Adapt code to extract pvectype. Use switch.
257
258 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
259
260 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
261 Tighten new eassert a bit.
262
263 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Fix compilation with --enable-gcc-warnings and -O1
266 optimization level.
267 * doprnt.c (doprnt): Change type of tem to int, initialize
268 to avoid compiler warning. Add eassert.
269 * search.c (simple_search): Initialize match_byte to avoid
270 compiler warning. Add eassert.
271
272 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
273
274 Avoid weird behavior with large horizontal scrolls.
275 Without this change, for example, large hscroll values would
276 mess up Emacs's display on Fedora 15 x86, presumably due to
277 overflows in int calculations in the display code.
278 Also, if buffers had long lines, Emacs would freeze.
279 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
280 (set_window_hscroll): New function, containing the old guts of
281 Fset_window_hscroll. Return the clipped value.
282 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
283 This avoids the need to check against PTRDIFF_MAX.
284
285 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
286
287 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
288
289 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
290
291 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
292
293 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
294 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
295 since GCC 4.4.6 issues a bogus warning for them.
296
297 Fix bugs in file timestamp newness comparisons.
298 * fileio.c (Ffile_newer_than_file_p):
299 * lread.c (Fload): Use full timestamp resolution of files,
300 not just the 1-second resolution, so that files that are only
301 slightly newer still count as newer.
302 * fileio.c (Ffile_newer_than_file_p): Don't assume file
303 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
304
305 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
306
307 * fileio.c: Improve handling of file time marker. (Bug#11852)
308 (special_mtime): New function.
309 (Finsert_file_contents, Fverify_visited_file_modtime):
310 Use it to set special mtime values consistently.
311
312 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
313
314 * fileio.c (Finsert_file_contents): Properly handle st_mtime
315 marker for non-existing file. (Bug#11852)
316
317 2012-07-03 Glenn Morris <rgm@gnu.org>
318
319 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
320 and did not make it into globals.h).
321
322 2012-07-03 Tom Tromey <tromey@redhat.com>
323
324 * window.c (Fset_window_margins, Fset_window_fringes)
325 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
326 * textprop.c (Fprevious_property_change): No longer static.
327 * syntax.c (Fsyntax_table_p): No longer static.
328 * process.c (Fget_process, Fprocess_datagram_address): No longer
329 static.
330 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
331 * keyboard.c (Fcommand_execute): No longer static.
332 Remove EXFUN.
333 * insdel.c (Fcombine_after_change_execute): No longer static.
334 * image.c (Finit_image_library): No longer static.
335 * fileio.c (Fmake_symbolic_link): No longer static.
336 * eval.c (Ffetch_bytecode): No longer static.
337 * editfns.c (Fuser_full_name): No longer static.
338 * doc.c (Fdocumentation_property, Fsnarf_documentation):
339 No longer static.
340 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
341 static.
342 * dired.c (Ffile_attributes): No longer static.
343 * composite.c (Fcomposition_get_gstring): No longer static.
344 * callproc.c (Fgetenv_internal): No longer static.
345
346 * ccl.h: Remove EXFUNs.
347 * buffer.h: Remove EXFUNs.
348 * dispextern.h: Remove EXFUNs.
349 * intervals.h: Remove EXFUNs.
350 * fontset.h: Remove EXFUN.
351 * font.h: Remove EXFUNs.
352 * dosfns.c (system_process_attributes): Remove EXFUN.
353 * keymap.h: Remove EXFUNs.
354 * lisp.h: Remove EXFUNs.
355 * w32term.h: Remove EXFUNs.
356 * window.h: Remove EXFUNs.
357 * xsettings.h: Remove EXFUN.
358 * xterm.h: Remove EXFUN.
359
360 2012-07-03 Glenn Morris <rgm@gnu.org>
361
362 * lisp.h (Frandom): Make it visible to C.
363 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
364 buffer for invisible buffers. (Bug#1229)
365
366 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
367
368 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
369 values which aren't power of 2.
370 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
371 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
372 accordingly.
373
374 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
375
376 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
377
378 * alloc.c (mark_object): Revert part of last patch to use `switch'.
379
380 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
381
382 * alloc.c (allocate_vector_block): Remove redundant
383 calls to mallopt if DOUG_LEA_MALLOC is defined.
384 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
385 avoid calls to mallopt if zero_vector is returned.
386
387 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
388
389 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
390 is enabled, avoid dereferencing NULL current_sblock if
391 running undumped.
392
393 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
394
395 Cleanup basic buffer management.
396 * buffer.h (struct buffer): Change layout to use generic vector
397 marking code. Fix some comments. Change type of 'clip_changed'
398 to bitfield. Remove unused #ifndef old.
399 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
400 (GET_OVERLAYS_AT): Fix indentation.
401 (for_each_per_buffer_object_at): New macro.
402 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
403 (Fbuffer_local_variables): Use it.
404 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
405 * alloc.c (allocate_buffer): Adjust to match new layout of
406 struct buffer. Fix comment.
407 (mark_overlay): New function.
408 (mark_buffer): Use it. Use mark_vectorlike to mark normal
409 Lisp area of struct buffer.
410 (mark_object): Use it. Adjust marking of misc objects
411 and related comments.
412
413 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
414
415 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
416 wrapper that is not needed because the wrapped code is a no-op (zero
417 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
418 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
419
420 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
421
422 * alloc.c (mark_buffer): Simplify. Remove prototype.
423 (mark_object): Add comment. Reorganize marking of vector-like
424 objects. Use CHECK_LIVE for all vector-like objects except buffers
425 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
426 redundant calls to mark_vectorlike for bool vectors.
427
428 2012-06-30 Glenn Morris <rgm@gnu.org>
429
430 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
431
432 * epaths.in (PATH_SITELOADSEARCH): New.
433 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
434 This is rather than relying on --enable-locallisppath elements
435 having "site-lisp" in their names. (Bug#10208#25, 11658)
436
437 2012-06-30 Eli Zaretskii <eliz@gnu.org>
438
439 * w32proc.c (sys_select): Accept and ignore one more argument.
440
441 * w32.c (emacs_gnutls_pull): Call select with one more argument.
442
443 * sysselect.h [DOS_NT]: Don't include sys/select.h.
444 (pselect) [!MS_DOS]: Redirect to sys_select.
445
446 * sysdep.c: Don't include dos.h and dosfns.h.
447
448 * process.c (sys_select):
449 * msdos.c (sys_select): Accept one more argument and ignore it.
450
451 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
452 adapt data types and code to that.
453
454 * dosfns.c:
455 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
456 which clashes with the gnulib function of the same name.
457
458 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
459
460 * font.c (font_style_to_value, font_style_symbolic)
461 (font_prop_validate_style): Add type checks for values in
462 font_style_table.
463
464 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
465 argument.
466 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
467 uses.
468
469 2012-06-29 Eli Zaretskii <eliz@gnu.org>
470
471 * xdisp.c (try_window_id): Undo last change.
472
473 * w32.c (getwd): Adjust commentary about startup_dir.
474 (init_environment): Always call sys_access, even in non-MSVC
475 builds. Don't chdir to the directory of the Emacs executable.
476 This undoes code from 1997 which was justified by the need to
477 "avoid conflicts when removing and renaming directories". But its
478 downside was that every relative file name was being interpreted
479 relative to the directory of the Emacs executable, which can never
480 be TRT. In particular, it broke sys_access when called with
481 relative file names.
482 (sys_access): Map GetLastError to errno.
483
484 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
485
486 * window.h (struct window): Change type of 'fringes_outside_margins'
487 to bitfield. Fix comment. Adjust users accordingly.
488 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
489 Adjust comment.
490 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
491 to ptrdiff_t.
492
493 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
494
495 * gnutls.c (emacs_gnutls_handshake):
496 Add QUIT to make the loop interruptible.
497
498 2012-06-29 Glenn Morris <rgm@gnu.org>
499
500 * charset.c (init_charset): Make lack of etc/charsets fatal.
501
502 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
503
504 * editfns.c (region_limit): Fix type mismatch.
505
506 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
507
508 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
509 undefined. Convert from xassert to eassert.
510 * nsmenu.m: Convert from xassert to eassert.
511 * nsterm.m: Likewise.
512
513 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
514
515 * editfns.c (region_limit): Clip to narrowing (bug#11770).
516
517 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
518
519 Avoid integer overflow on scroll-left and scroll-right.
520 * window.c (HSCROLL_MAX): New macro.
521 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
522 overflow when requested scroll falls outside ptrdiff_t range.
523
524 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
525
526 * window.h (struct window): Change type of 'hscroll',
527 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
528 'last_modified' and 'last_overlay_modified' to EMACS_INT.
529 Adjust users accordingly.
530 * xdisp.c (try_cursor_movement): Replace type check with eassert.
531 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
532 from EMACS_INT to ptrdiff_t.
533 (make_window): Omit redundant initialization.
534
535 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
536
537 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
538
539 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
540
541 * window.h (struct window): Change type of 'use_time' and
542 'sequence_number' from Lisp_Object to int.
543 * frame.c (make_frame): Adjust users accordingly.
544 * print.c (print_object): Likewise.
545 * window.c (select_window, Fwindow_use_time, make_parent_window)
546 (make_window): Likewise.
547
548 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
549
550 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
551 enabled with --enable-checking=[all,glyphs] configure option.
552 Fix GLYPH_DEBUG usage assuming that it may be undefined,
553 adjust comments accordingly.
554 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
555 undefined, adjust comments accordingly.
556 * image.c: Likewise.
557 * scroll.c: Likewise.
558 * w32fns.c: Likewise.
559 * w32term.c: Likewise.
560 * xdisp.c: Likewise.
561 * xfaces.c: Likewise.
562 * xfns.c: Likewise.
563 * xterm.c: Likewise.
564
565 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
566
567 Generalize run-time debugging checks.
568 * dispextern.h (XASSERTS): Remove.
569 * fontset.c (xassert): Remove.
570 Convert from xassert to eassert.
571 * alloc.c: Convert from xassert to eassert.
572 * bidi.c: Likewise.
573 * dispnew.c: Likewise.
574 * fns.c: Likewise.
575 * fringe.c: Likewise.
576 * ftfont.c: Likewise.
577 * gtkutil.c: Likewise.
578 * image.c: Likewise.
579 * keyboard.c: Likewise.
580 * menu.c: Likewise.
581 * process.c: Likewise.
582 * scroll.c: Likewise.
583 * sound.c: Likewise.
584 * term.c: Likewise.
585 * w32console.c: Likewise.
586 * w32fns.c: Likewise.
587 * w32term.c: Likewise.
588 * window.c: Likewise.
589 * xdisp.c: Likewise.
590 * xfaces.c: Likewise.
591 * xfns.c: Likewise.
592 * xselect.c: Likewise.
593 * xterm.c: Likewise.
594
595 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * fns.c (maybe_resize_hash_table): Output message when growing the
598 purify-hashtable.
599
600 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
601
602 * alloc.c (allocate_string_data): Remove dead code.
603 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
604 avoid GCC warning about unused macro.
605
606 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
607
608 * alloc.c (allocate_string): Omit intervals initialization.
609 * alloc.c (make_uninit_multibyte_string): Initialize intervals
610 as in make_pure_string and make_pure_c_string.
611
612 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
613
614 * alloc.c (allocate_string): Fix last change.
615
616 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
617
618 * alloc.c (allocate_string): Remove two redundant calls
619 to memset, add explicit initialization where appropriate.
620
621 2012-06-27 Glenn Morris <rgm@gnu.org>
622
623 * lisp.mk (lisp): Remove paths.elc.
624
625 2012-06-27 Chong Yidong <cyd@gnu.org>
626
627 * doc.c (Fsubstitute_command_keys): Fix punctuation.
628
629 2012-06-26 John Wiegley <johnw@newartisans.com>
630
631 * unexmacosx.c (copy_data_segment): Add two section names used
632 on Mac OS X Lion: __mod_init_func and __mod_term_func.
633
634 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
635 when building with Clang.
636
637 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
638
639 * eval.c (Fapply): Allow calling it with a single argument.
640
641 2012-06-26 Eli Zaretskii <eliz@gnu.org>
642
643 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
644 _stricmp and _strnicmp.
645 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
646
647 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
648
649 * alloc.c (allocate_window): Zero out non-Lisp part of newly
650 allocated window.
651 (allocate_process): Likewise for new process.
652 (allocate_terminal): Change to use offsetof.
653 (allocate_frame): Likewise.
654 * frame.c (make_frame): Omit redundant initialization.
655 * window.c (make_parent_window): Use memset.
656 (make_window): Omit redundant initialization.
657 * process.c (make_process): Omit redundant initialization.
658 * terminal.c (create_terminal): Likewise.
659
660 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
661
662 * term.c (delete_tty): Remove redundant call to memset.
663
664 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
665
666 * alloc.c: Remove build_string.
667 * lisp.h: Define build_string as static inline. This provides
668 a better opportunity to optimize away calls to strlen when the
669 function is called with compile-time constant argument.
670 * image.c (imagemagick_error): Convert to build_string.
671 * w32proc.c (sys_spawnve): Likewise.
672 * xterm.c (x_term_init): Likewise.
673
674 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
675
676 Use sprintf return value instead of invoking strlen on result.
677 In the old days this wasn't portable, since some sprintf
678 implementations returned char *. But they died out years ago and
679 Emacs already assumes sprintf returns int.
680 Similarly for float_to_string.
681 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
682 * ccl.c (ccl_driver):
683 * character.c (string_escape_byte8):
684 * data.c (Fnumber_to_string):
685 * doprnt.c (doprnt):
686 * print.c (print_object):
687 * xdisp.c (message_dolog):
688 * xfns.c (syms_of_xfns):
689 Use sprintf or float_to_string result to avoid need to call strlen.
690 * data.c (Fnumber_to_string):
691 Use make_unibyte_string, since the string must be ASCII.
692 * lisp.h, print.c (float_to_string): Now returns int length.
693 * term.c (produce_glyphless_glyph):
694 Use sprintf result rather than recomputing it.
695
696 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
697 * Makefile.in (ALL_CFLAGS):
698 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
699 * gmalloc.c, regex.c: Include <config.h> unconditionally.
700
701 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
702
703 * dispextern.h (xstrcasecmp): Define to library function
704 strcasecmp if available.
705 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
706
707 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
708
709 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
710 Avoid comma operator.
711 * menu.c (push_submenu_start, push_submenu_end)
712 (push_left_right_boundary, push_menu_pane): Likewise.
713 * msdos.c (dos_rawgetc): Likewise.
714
715 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
716
717 * xfns.c (xic_create_fontsetname): Remove redundant calls
718 to memset.
719
720 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
721
722 * gtkutil.c (get_utf8_string): Remove redundant assignment.
723 sprintf already null-terminates its output.
724
725 * xfns.c (x_window): Remove redundant cast.
726
727 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
728
729 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
730 `const char *' to `char *' to avoid compiler warning.
731
732 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
733
734 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
735 instead of truncating it to 63 (admittedly a generous limit).
736
737 * process.c: Fix spelling and caps in comments.
738
739 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
740
741 * emacs.c (setpgrp): Remove definition, unused.
742 * sysdep.c (setpgrp): Remove definition, not used in this file.
743
744 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
745
746 * makefile.w32-in: Update dependencies.
747
748 2012-06-24 Eli Zaretskii <eliz@gnu.org>
749
750 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
751 (SYSTIME_H): Add nt/inc/sys/time.h.
752
753 * systime.h [WINDOWSNT]: Include sys/time.h.
754
755 * s/ms-w32.h (struct timespec): Definition moved from
756 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
757
758 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
759
760 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
761 * buffer.h (buffer_slot_type_mismatch):
762 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
763 * eval.c (unwind_to_catch):
764 * image.c (my_png_error, my_error_exit):
765 * keyboard.c (quit_throw_to_read_char, user_error)
766 (Fexit_recursive_edit, Fabort_recursive_edit):
767 * lisp.h (die, args_out_of_range, args_out_of_range_3)
768 (wrong_type_argument, buffer_overflow, __executable_start)
769 (memory_full, buffer_memory_full, string_overflow, Fthrow)
770 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
771 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
772 (fatal):
773 (child_setup) [!DOS_NT]:
774 * lread.c (end_of_file_error, invalid_syntax):
775 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
776 * puresize.h (pure_write_error):
777 * search.c (matcher_overflow):
778 * sound.c (sound_perror, alsa_sound_perror):
779 * sysdep.c, syssignal.h (croak):
780 * term.c (maybe_fatal, vfatal):
781 * textprop.c (text_read_only):
782 * undo.c (user_error):
783 * unexmacosx.c (unexec_error):
784 * xterm.c (x_ins_del_lines, x_delete_glyphs):
785 Use _Noreturn rather than NO_RETURN.
786 No need for separate decl merely because of _Noreturn.
787 * sound.c (sound_warning, parse_sound):
788 Remove unnecessary forward decls.
789
790 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
791
792 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
793 * lisp.h (WAIT_READING_MAX): New macro.
794 * dispnew.c (Fsleep_for, sit_for):
795 * keyboard.c (kbd_buffer_get_event):
796 * process.c (Faccept_process_output):
797 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
798 This improves on the previous patch, which introduced a bug
799 when time_t is unsigned and as wide as intmax_t.
800 See <http://bugs.gnu.org/9000#51>.
801
802 2012-06-23 Eli Zaretskii <eliz@gnu.org>
803
804 * dispnew.c (sit_for, Fsleep_for):
805 * keyboard.c (kbd_buffer_get_event):
806 * process.c (Faccept_process_output): Avoid compiler warnings when
807 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
808
809 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
810
811 * makefile.w32-in: Update dependencies.
812
813 * w32.c (ltime): Add return type and declare static.
814 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
815
816 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
817
818 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
819 Privately reported by Herbert J. Skuhra.
820 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
821 All uses changed.
822 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
823 not make_lisp_timeval, when the argument is of type EMACS_TIME.
824
825 2012-06-23 Eli Zaretskii <eliz@gnu.org>
826
827 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
828 last argument of make_unibyte_string.
829
830 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
831 language ID in the event parameters.
832
833 * w32term.c (w32_read_socket): Put the new keyboard codepage into
834 event.code, not the obscure "character set ID".
835
836 2012-06-23 Chong Yidong <cyd@gnu.org>
837
838 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
839
840 2012-06-23 Eli Zaretskii <eliz@gnu.org>
841
842 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
843 * w32.c (fdutimens): New function.
844
845 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
846
847 * s/ms-w32.h (pselect): Redirect to sys_select.
848
849 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
850
851 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
852 in the logic of incrementing and decrementing the value of
853 use_relocatable_buffers.
854
855 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
856
857 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
858 Privately reported by Herbert J. Skuhra.
859 [__FreeBSD__]: Remove "*/" typo after "#include".
860 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
861 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
862 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
863 Don't assume EMACS_TIME and struct timeval are the same type.
864
865 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
866
867 Support higher-resolution time stamps (Bug#9000).
868 The time stamps are only nanosecond-resolution at the C level,
869 since that's the best that any real-world system supports now.
870 But they are picosecond-resolution at the Lisp level, as that's
871 easy, and leaves room for future OS improvements.
872
873 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
874 (LIBES): Use it.
875
876 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
877 Don't get current time unless it's needed.
878
879 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
880 now provides it if it's absent.
881 (start_atimer): Port to higher-res time stamps.
882 Check for time stamp overflow. Don't get current time more
883 often than is needed.
884
885 * buffer.h (struct buffer): Buffer modtime now has high resolution.
886 Include systime.h, not time.h.
887 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
888
889 * dired.c: Include stat-time.h.
890 (Ffile-attributes): File times now have higher resolution.
891
892 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
893 (struct image): Timestamp now has higher resolution.
894
895 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
896 has at least microseconds now. All uses removed.
897 (update_frame, update_single_window, update_window, update_frame_1)
898 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
899
900 * editfns.c (time_overflow): Now extern.
901 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
902 (float-time, Fformat_time_string, Fcurrent_time_string)
903 (Fcurrent_time_zone): Accept and generate higher-resolution
904 time stamps.
905 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
906 (decode_time_components, lisp_seconds_argument): New functions.
907 (make_time): Now static.
908 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
909 Report an error if the time is invalid, rather than having the caller
910 do that.
911
912 * fileio.c: Include <stat-time.h>
913 (Fcopy_file): Copy higher-resolution time stamps.
914 Prefer to set the time stamp via a file descriptor if that works.
915 (Fset_file_times, Finsert_file_contents, Fwrite_region)
916 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
917 (Fvisited_file_modtime, Fset_visited_file_modtime):
918 Support higher-resolution time stamps.
919
920 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
921
922 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
923
924 * image.c (prepare_image_for_display, clear_image_cache)
925 (lookup_image): Port to higer-resolution time stamps.
926
927 * keyboard.c (start_polling, bind_polling_period):
928 Check for time stamp overflow.
929 (read_char, kbd_buffer_get_event, timer_start_idle)
930 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
931 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
932 Port to higher-resolution time stamps. Do not assume time_t is signed.
933 (decode_timer): New function. Timers are now vectors of length 9,
934 not 8, to accommodate the picosecond component.
935 (timer_check_2): Use it.
936
937 * nsterm.m (select_timeout, timeval_subtract): Remove.
938 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
939 as they're a bit more accurate and handle overflow better.
940 (ns_select): Change prototype to be compatible with pselect.
941 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
942 * nsterm.h (ns_select): Adjust prototype.
943
944 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
945 us-resolution time stamps.
946 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
947
948 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
949
950 * lisp.h (time_overflow): New decl.
951 (wait_reading_process_output): First arg is now intmax_t, not int,
952 to accommodate larger waits.
953
954 * process.h (struct Lisp_Process.read_output_delay):
955 Now counts nanoseconds, not microseconds.
956 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
957 EMACS_HAS_USECS.
958 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
959 (wait_reading_process_output):
960 Port to ns-resolution time stamps.
961 (Faccept_process_output, wait_reading_process_output):
962 Check for time stamp overflow. Do not assume time_t is signed.
963 (select_wrapper): Remove; we now use pselect.
964 (Fprocess_attributes): Now generates ns-resolution time stamps.
965
966 * sysdep.c: Include utimens.h. Don't include utime.h
967 or worry about struct utimbuf; gnulib does that for us now.
968 (gettimeofday): Remove; gnulib provides a substitute.
969 (make_timeval): New function.
970 (set_file_times): Now sets ns-resolution time stamps.
971 New arg FD; all uses changed.
972 (time_from_jiffies, ltime_from_jiffies, get_up_time)
973 (system_process_attributes):
974 Now returns ns-resolution time stamp. All uses changed.
975 Check for time stamp overflow.
976
977 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
978 provides a substitute now.
979
980 * systime.h: Include timespec.h rather than sys/time.h and time.h,
981 since it guarantees struct timespec.
982 (EMACS_TIME): Now struct timespec, so that we can support
983 ns-resolution time stamps.
984 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
985 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
986 (EMACS_USECS): Remove.
987 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
988 so multiply the arg by 1000 before storing it.
989 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
990 New macros.
991 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
992 Port to ns-resolution time stamps.
993 (EMACS_TIME_NEG_P): Remove; replaced by....
994 (EMACS_TIME_SIGN): New macro.
995 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
996 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
997 (set_file_times, make_time, lisp_time_argument): Adjust signature.
998 (make_timeval, make_lisp_time, decode_time_components): New decls.
999 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1000 that it mishandled time_t overflow. You can't compare by subtracting!
1001 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1002 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1003
1004 * term.c: Include <sys/time.h>.
1005 (timeval_to_Time): New function, for proper overflow wraparound.
1006 (term_mouse_position, term_mouse_click): Use it.
1007
1008 * undo.c (record_first_change): Support higher-resolution time stamps
1009 in the undo buffer.
1010 (Fprimitive_undo): Use them when restoring time stamps.
1011
1012 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1013 (w32_get_internal_run_time):
1014 Port to higher-resolution Emacs time stamps.
1015 (ltime): Now accepts single 64-bit integer, as that's more convenient
1016 for callers.
1017
1018 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1019
1020 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1021 for compatibility with pselect. Support ns-resolution time stamps.
1022
1023 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1024
1025 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1026 Check for time stamp overflow, and support ns-resolution time stamps.
1027
1028 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1029 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1030 (timeval_subtract): Remove; no longer needed.
1031 (XTflash, XTring_bell, x_wait_for_event):
1032 Port to ns-resolution time stamps. Don't assume time_t is signed.
1033
1034 2012-06-22 Chong Yidong <cyd@gnu.org>
1035
1036 * xdisp.c (x_consider_frame_title): Revert last change.
1037
1038 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1039
1040 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1041 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1042 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1043 staticidx goes up to 1597 out of 1600 = 0x640.)
1044
1045 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1048 Otherwise, the umask might be mistakenly 0 while handling input signals.
1049
1050 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1051
1052 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1053
1054 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1055
1056 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1057 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1058 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1059 access to `contents' member of Lisp_Vector objects with AREF and ASET
1060 where appropriate.
1061
1062 2012-06-19 Chong Yidong <cyd@gnu.org>
1063
1064 * frame.c (delete_frame): When selecting a frame on a different
1065 text terminal, do not alter the terminal's top-frame.
1066
1067 * xdisp.c (format_mode_line_unwind_data): Record the target
1068 frame's selected window and its terminal's top-frame.
1069 (unwind_format_mode_line): Restore them.
1070 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1071 Callers changed.
1072 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1073 since tty frames can be explicitly named.
1074 (prepare_menu_bars): Likewise.
1075
1076 * term.c (Ftty_top_frame): New function.
1077
1078 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 Port byte-code-meter to modern targets.
1081 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1082 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1083 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1084 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1085 (METER_1, METER_2): Simplify.
1086
1087 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1088
1089 * data.c (Fdefalias): Return `symbol' (bug#11686).
1090
1091 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1092
1093 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1094 gets killed during executing of this function (Bug#11665).
1095 Try to always return Qt when the buffer has been actually killed.
1096 (Vkill_buffer_query_functions): In doc-string say that functions
1097 run by this hook should not change the current buffer.
1098
1099 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 Fix recently-introduced process.c problems found by static checking.
1102 * process.c (write_queue_push, write_queue_pop, send_process):
1103 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1104 (write_queue_pop): Fix pointer signedness problem.
1105 (send_process): Remove unused local.
1106
1107 2012-06-17 Chong Yidong <cyd@gnu.org>
1108
1109 * xdisp.c (redisplay_internal): No need to redisplay terminal
1110 frames that are not on top.
1111
1112 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1113
1114 * process.c (make_process): Initialize write_queue.
1115 (write_queue_push, write_queue_pop): New functions.
1116 (send_process): Use them to maintain correct ordering of process
1117 writes (Bug#10815).
1118
1119 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * lisp.h (eassert): Assume C89 or later.
1122 This removes the need for CHECK.
1123 (CHECK): Remove. Its comments about always evaluating its
1124 argument were confusing, as 'eassert' typically does not evaluate
1125 its argument.
1126
1127 * coding.c (produce_chars): Use ptrdiff_t, not int.
1128
1129 * xterm.c (x_draw_underwave): Check for integer overflow.
1130 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1131
1132 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1135 referenced (Bug#11583).
1136
1137 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1138
1139 Implement wave-style variant of underlining.
1140 * dispextern.h (face_underline_type): New enum.
1141 (face): Add field for underline type.
1142 * nsterm.m (ns_draw_underwave): New function.
1143 (ns_draw_text_decoration): Use it.
1144 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1145 New functions.
1146 (x_draw_glyph_string): Use them.
1147 * xfaces.c (Qline, Qwave): New Lisp objects.
1148 (check_lface_attrs, merge_face_ref)
1149 (Finternal_set_lisp_face_attribute, realize_x_face):
1150 Handle wave-style underline face attributes.
1151 * xterm.c (x_draw_underwave): New function.
1152 (x_draw_glyph_string): Use it.
1153
1154 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1155
1156 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1157 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1158 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1159 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1160 ($(BLD)/w32select.$(O)): Update dependencies.
1161
1162 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1163
1164 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1165 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1166 * character.c (_fetch_multibyte_char_p): Remove.
1167 * alloc.c: Include "character.h" before "buffer.h".
1168 * bidi.c: Likewise.
1169 * buffer.c: Likewise.
1170 * bytecode.c: Likewise.
1171 * callint.c: Likewise.
1172 * callproc.c: Likewise.
1173 * casefiddle.c: Likewise.
1174 * casetab.c: Likewise.
1175 * category.c: Likewise.
1176 * cmds.c: Likewise.
1177 * coding.c: Likewise.
1178 * composite.c: Likewise.
1179 * dired.c: Likewise.
1180 * dispnew.c: Likewise.
1181 * doc.c: Likewise.
1182 * dosfns.c: Likewise.
1183 * editfns.c: Likewise.
1184 * emacs.c: Likewise.
1185 * fileio.c: Likewise.
1186 * filelock.c: Likewise.
1187 * font.c: Likewise.
1188 * fontset.c: Likewise.
1189 * fringe.c: Likewise.
1190 * indent.c: Likewise.
1191 * insdel.c: Likewise.
1192 * intervals.c: Likewise.
1193 * keyboard.c: Likewise.
1194 * keymap.c: Likewise.
1195 * lread.c: Likewise.
1196 * macros.c: Likewise.
1197 * marker.c: Likewise.
1198 * minibuf.c: Likewise.
1199 * nsfns.m: Likewise.
1200 * nsmenu.m: Likewise.
1201 * print.c: Likewise.
1202 * process.c: Likewise.
1203 * regex.c: Likewise.
1204 * region-cache.c: Likewise.
1205 * search.c: Likewise.
1206 * syntax.c: Likewise.
1207 * term.c: Likewise.
1208 * textprop.c: Likewise.
1209 * undo.c: Likewise.
1210 * unexsol.c: Likewise.
1211 * w16select.c: Likewise.
1212 * w32fns.c: Likewise.
1213 * w32menu.c: Likewise.
1214 * window.c: Likewise.
1215 * xdisp.c: Likewise.
1216 * xfns.c: Likewise.
1217 * xmenu.c: Likewise.
1218 * xml.c: Likewise.
1219 * xselect.c: Likewise.
1220
1221 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1222
1223 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1224 If all the glyphs of the glyph row came from strings, and we have no
1225 cursor positioning clues, put the cursor on the first glyph of the
1226 row.
1227 (handle_face_prop): Use chunk-relative overlay string index when
1228 indexing into it->string_overlays array. (Bug#11653)
1229 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1230 the rightmost. (Bug#11720)
1231
1232 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1233
1234 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1235 (CATEGORY_MEMBER): Enforce 1/0 value.
1236 * category.c (_temp_category_set): Remove.
1237
1238 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1239
1240 * window.c (Fdelete_other_windows_internal)
1241 (Fdelete_window_internal): Don't access frame's mouse highlight
1242 info of the initial frame. (Bug#11677)
1243
1244 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1247 Assume USE_2_TAGS_FOR_INTS.
1248 (xreload): Adjust $tagmask width to match recent lisp.h change.
1249
1250 Simplify lisp.h in minor ways that should not affect code.
1251 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1252 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1253 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1254 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1255 (INTTYPEBITS): New macro, for clarity.
1256 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1257 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1258 Simplify now that USE_LSB_TAG is always defined.
1259 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1260 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1261
1262 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1263
1264 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1265
1266 2012-06-13 Glenn Morris <rgm@gnu.org>
1267
1268 * s/bsd-common.h (BSD4_3):
1269 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1270
1271 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1272
1273 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1274 instead of union.
1275 (XLI, XIL): Define.
1276 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1277 Use them.
1278 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1279 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1280 * alloc.c (widen_to_Lisp_Object): Remove.
1281 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1282 * frame.c (delete_frame): Remove outdated comment.
1283 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1284 USE_LISP_UNION_TYPE.
1285 (Fw32_unregister_hot_key): Likewise.
1286 (Fw32_toggle_lock_key): Likewise.
1287 * w32menu.c (add_menu_item): Likewise.
1288 (w32_menu_display_help): Use XIL instead of checking
1289 USE_LISP_UNION_TYPE.
1290 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1291 (init_heap): Likewise.
1292 * w32term.c (w32_read_socket): Update comment.
1293
1294 2012-06-13 Glenn Morris <rgm@gnu.org>
1295
1296 * s/usg5-4-common.h, src/s/unixware.h:
1297 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1298
1299 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1300
1301 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1304 * alloc.c (make_number) [!defined make_number]:
1305 Remove, as lisp.h always defines this now.
1306 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1307 (roundup_size): Verify that it is a power of 2.
1308 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1309 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1310 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1311 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1312 USE_LSB_TAG now is always defined to be either 0 or 1.
1313 All uses changed.
1314 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1315 code works fine either way, and efficiency is not a concern here,
1316 as the union type is for debugging, not for production.
1317 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1318 Use an inline function on all platforms when using the union type,
1319 since this is simpler and 'static inline' can be used portably
1320 within Emacs now.
1321 (LISP_INITIALLY_ZERO): New macro.
1322 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1323 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1324
1325 2012-06-12 Glenn Morris <rgm@gnu.org>
1326
1327 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1328
1329 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1330
1331 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1332 Move BROKEN_SIGIO to configure.
1333
1334 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1335 Move NO_TERMIO to configure.
1336
1337 2012-06-12 Chong Yidong <cyd@gnu.org>
1338
1339 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1340 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1341 MagickExportImagePixels is undefined.
1342
1343 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * image.c (imagemagick_load_image): Remove unused label.
1346
1347 2012-06-11 Glenn Morris <rgm@gnu.org>
1348
1349 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1350 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1351 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1352 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1353
1354 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1355
1356 * alloc.c (make_byte_code): New function.
1357 (Fmake_byte_code): Use it. Don't purify here.
1358 * lread.c (read1): Use it as well to avoid extra allocation.
1359
1360 2012-06-11 Chong Yidong <cyd@gnu.org>
1361
1362 * image.c (imagemagick_load_image): Implement transparency.
1363
1364 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1365
1366 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1367 account for preceding backslashes. (Bug#11663)
1368
1369 2012-06-09 Chong Yidong <cyd@gnu.org>
1370
1371 * term.c: Support italics in capable terminals (Bug#9652).
1372 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1373 (turn_on_face): Output using TS_enter_italic_mode if available.
1374 Don't handle unused blinking and alt-charset cases.
1375 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1376 and tty_alt_charset_p cases.
1377 (tty_capable_p, init_tty): Support italics.
1378
1379 * termchar.h (struct tty_display_info): Add field for italics.
1380 Remove unused blink field.
1381
1382 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1383 Handle slant.
1384
1385 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1386 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1387 tty_alt_charset_p. Add tty_italic_p.
1388
1389 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1390
1391 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1392 dbus_type_is_basic if available.
1393 (xd_extract_signed, xd_extract_unsigned): Rename from
1394 extract_signed and extract_unsigned, respectively. Adapt callers.
1395
1396 2012-06-09 Chong Yidong <cyd@gnu.org>
1397
1398 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1399
1400 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1401 case (Bug#9752).
1402
1403 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 * xdisp.c (vmessage): Treat frame message as multibyte.
1406 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1407 would generate the diagnostic "Making \302\247 buffer-local while
1408 let-bound!".
1409
1410 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1411
1412 * dispnew.c (showing_window_margins_p): Undo last change, which
1413 was done due to an inadvertent commit.
1414 (adjust_frame_glyphs_for_frame_redisplay): Do call
1415 showing_window_margins_p.
1416
1417 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * eval.c (Fmake_var_non_special): New primitive.
1420 (syms_of_eval): Defsubr it.
1421 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1422
1423 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1424
1425 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1426 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1427
1428 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1429
1430 * alloc.c (allocate_vectorlike): Fix last change.
1431
1432 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1433
1434 Block-based vector allocation of small vectors.
1435 * lisp.h (struct vectorlike_header): New field `nbytes',
1436 adjust comment accordingly.
1437 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1438 to denote vector blocks. Adjust users (live_vector_p,
1439 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1440 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1441 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1442 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1443 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1444 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1445 (roundup_size): New constant.
1446 (struct vector_block): New data type.
1447 (vector_blocks, vector_free_lists, zero_vector): New variables.
1448 (all_vectors): Rename to `large_vectors'.
1449 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1450 (sweep_vectors): New functions.
1451 (allocate_vectorlike): Return `zero_vector' as the only vector of
1452 0 items. Allocate new vector from block if vector size is less than
1453 or equal to VBLOCK_BYTES_MAX.
1454 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1455 (init_alloc_once): Add call to init_vectors.
1456
1457 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1458
1459 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1460
1461 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 * doprnt.c (doprnt): Truncate multibyte char correctly.
1464 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1465 would mishandle a string argument "Xc" if X was a multibyte
1466 character of length 2: it would truncate after X's first byte
1467 rather than including all of X.
1468
1469 2012-06-06 Chong Yidong <cyd@gnu.org>
1470
1471 * buffer.c (word_wrap): Doc fix.
1472
1473 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1474
1475 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1476
1477 2012-06-03 Glenn Morris <rgm@gnu.org>
1478
1479 * xdisp.c (tool-bar-style): Doc fix.
1480
1481 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1482
1483 * Makefile.in (PAXCTL): Define.
1484 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1485 binary via PaX flags if the paxctl utility is available.
1486 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1487 Restore PaX flags to their default. (Bug#11398)
1488
1489 2012-06-03 Chong Yidong <cyd@gnu.org>
1490
1491 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1492 buffer (Bug#11226).
1493
1494 2012-06-03 Chong Yidong <cyd@gnu.org>
1495
1496 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1497 (note_mode_line_or_margin_highlight): If there is no help echo,
1498 use mode-line-default-help-echo. Handle the case where the mouse
1499 position is past the end of the mode line string.
1500
1501 * buffer.c (buffer_local_value_1): New function, split from
1502 Fbuffer_local_value; can return Qunbound.
1503 (Fbuffer_local_value): Use it.
1504 (Vmode_line_format): Docstring tweaks.
1505
1506 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1507
1508 * sysdep.c (system_process_attributes): Improve comment.
1509
1510 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1511
1512 * keyboard.c: Export real-this-command to Elisp.
1513 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1514 and DEFVAR it. Update all users.
1515
1516 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1517
1518 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1519
1520 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1521 Convert pctcpu and pctmem to Lisp float properly.
1522 Let the compiler fold better, as 100.0/0x8000 is exact.
1523
1524 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1525
1526 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1527 cons_block.
1528
1529 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1532
1533 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1534
1535 For a 'struct window', replace some Lisp_Object fields to
1536 bitfields where appropriate, remove unused fields.
1537 * window.h (struct window): Remove unused 'last_mark_x' and
1538 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1539 change it's type from Lisp_Object to bitfield.
1540 Change type of 'force_start', 'optional_new_start',
1541 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1542 fields from Lisp_Object to bitfield. Adjust users accordingly.
1543
1544 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1545
1546 Pacify gcc -Wdouble-precision when using Xaw.
1547 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1548 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1549 Use 'float' consistently, rather than 'float' in most places
1550 and 'double' in a couple of places.
1551
1552 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (handle_stop): Detect whether we have overlay strings
1555 loaded by testing it->current.overlay_string_index to be
1556 non-negative, instead of checking whether n_overlay_strings is
1557 positive. (Bug#11587)
1558
1559 2012-05-31 Chong Yidong <cyd@gnu.org>
1560
1561 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1562
1563 * doc.c (Fsubstitute_command_keys): Doc fix.
1564
1565 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1566
1567 * search.c (search_buffer): Remove calls to
1568 r_alloc_inhibit_buffer_relocation, as it is now called by
1569 maybe_unify_char, which was the cause of relocation of buffer text
1570 in bug#11519.
1571
1572 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1573
1574 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1575 for the duration of call to load_charset, to avoid problems with
1576 callers of maybe_unify_char that access buffer text through C
1577 pointers.
1578
1579 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1580 decrement the inhibition flag, instead of just setting or
1581 resetting it.
1582
1583 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 Remove obsolete '#define static' cruft.
1586 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1587 This #undef was "temporary" in 2000; it is no longer needed
1588 now that '#define static' has gone away.
1589 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1590 (gray_bitmap_bits): Remove; no longer needed.
1591 All uses replaced with definiens.
1592 * xterm.c: Include "bitmaps/gray.xbm".
1593
1594 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 Clean up __executable_start, monstartup when --enable-profiling.
1597 The following changes affect the code only when profiling.
1598 * dispnew.c (__executable_start): Rename from safe_bcopy.
1599 Define only on platforms that need it.
1600 * emacs.c: Include <sys/gmon.h> when profiling.
1601 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1602 (__executable_start): Remove decl, since lisp.h does it now.
1603 (safe_bcopy): Remove decl; no longer has that name.
1604 (main): Coalesce #if into single bit of code, for simplicity.
1605 Cast pointers to uintptr_t, since standard libraries want integers
1606 and not pointers.
1607 * lisp.h (__executable_start): New decl.
1608
1609 2012-05-31 Glenn Morris <rgm@gnu.org>
1610
1611 * image.c (Fimagemagick_types): Doc fix.
1612
1613 2012-05-30 Jim Meyering <meyering@redhat.com>
1614
1615 * callproc.c (Fcall_process_region): Include directory component
1616 in mkstemp error message (Bug#11586).
1617
1618 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * alloc.c, lisp.h (make_pure_vector): Now static.
1621
1622 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1623
1624 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1625 Move to byte-run.el.
1626 (Fautoload): Do the hash-doc more carefully.
1627 * data.c (Fdefalias): Purify definition, except for keymaps.
1628 (Qdefun): Move from eval.c.
1629 * lisp.h (Qdefun): Remove.
1630 * lread.c (read1): Tiny simplification.
1631
1632 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1633
1634 Do not create empty overlays with the evaporate property (Bug#9642).
1635 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1636 Bug#9642, but explicitly check that the buffer the overlay would
1637 be moved to is live and rearrange lines to make sure that errors
1638 will not put the overlay in an inconsistent state.
1639 (Fdelete_overlay): Cosmetics.
1640
1641 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1642
1643 * w32term.c (my_bring_window_to_top): New function.
1644 (x_raise_frame): Use handle returned by DeferWindowPos, which
1645 could be different from the original one.
1646 Call my_bring_window_to_top instead of my_set_foreground_window.
1647 (Bug#11513)
1648
1649 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1650 by calling BringWindowToTop.
1651
1652 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1653 (WM_EMACS_END): Increase by one.
1654
1655 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1658 This avoids undefined behavior that might cause the eassert
1659 to not catch an out-of-range value.
1660
1661 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1664 Update dependencies.
1665
1666 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1667
1668 * bidi.c (bidi_mirror_char): Fix last change.
1669
1670 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1671
1672 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1673 when referring to sectname field in printf format.
1674
1675 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1678 Only r_alloc_inhibit_buffer_relocation needed to be added;
1679 the others were already declared.
1680
1681 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1682 before checking whether it's out of range. Put the check inside
1683 eassert. See
1684 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1685
1686 2012-05-27 Ken Brown <kbrown@cornell.edu>
1687
1688 * callproc.c (Fcall_process): Restore a line that was accidentally
1689 commented out in the 2011-02-13 change (bug#11547).
1690
1691 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1692
1693 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1694 defined on ralloc.c.
1695
1696 * buffer.c [REL_ALLOC]: Remove prototypes of
1697 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1698 they are now on lisp.h.
1699
1700 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1701
1702 * search.c (search_buffer): Use it to inhibit relocation of buffer
1703 text while re_search_2 is doing its job, because re_search_2 is
1704 passed C pointers to buffer text. (Bug#11519)
1705
1706 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1707 Update value to 24.
1708
1709 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1710 state after an additional call to move_it_in_display_line_to, keep
1711 the values of it->max_ascent and it->max_descent found for the
1712 entire line.
1713 (pos_visible_p): Revert the comparison against bottom_y to what it
1714 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1715 (Bug#11464)
1716
1717 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 Fix coding-related core dumps with gcc -ftrapv.
1720 The code was computing A - B, where A and B are pointers, and B is
1721 random garbage. This can lead to core dumps on platforms that
1722 have special pointer registers, and it also leads to core dumps on
1723 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1724 A - B only when B is initialized properly.
1725 * coding.c (coding_set_source, coding_set_destination): Return void.
1726 (coding_change_source, coding_change_destinations): New functions,
1727 with the old behaviors of coding_set_source and coding_set_destination.
1728 All callers that need an offset changed to use these new functions.
1729
1730 2012-05-26 Glenn Morris <rgm@gnu.org>
1731
1732 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1733
1734 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1735
1736 Extend mouse support on W32 text-mode console.
1737 * xdisp.c (draw_row_with_mouse_face):
1738 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1739
1740 * w32console.c: Include window.h.
1741 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1742 New functions.
1743 (initialize_w32_display): Initialize mouse-highlight data.
1744
1745 * w32inevt.c: Include termchar.h and window.h.
1746 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1747 moves, call note_mouse_highlight. If help_echo changed, call
1748 gen_help_event to produce help-echo message in the echo area.
1749 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1750 highlight info.
1751
1752 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 * lread.c (read1): Simplify slightly to avoid an overflow warning
1755 with GCC 4.7.0 on x86-64.
1756
1757 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1758
1759 * bidi.c (bidi_mirror_char): Revert last change: an int is
1760 definitely wide enough here.
1761
1762 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 Fix integer width and related bugs (Bug#9874).
1765 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1766 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1767 (string_bytes, check_sblock, allocate_string_data):
1768 (compact_small_strings, Fmake_bool_vector, make_string)
1769 (make_unibyte_string, make_multibyte_string)
1770 (make_string_from_bytes, make_specified_string)
1771 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1772 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1773 (mark_vectorlike):
1774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1775 (allocate_pseudovector):
1776 Use int, not EMACS_INT, where int is wide enough.
1777 (inhibit_garbage_collection, Fgarbage_collect):
1778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1779 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1780 int might not be wide enough.
1781 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1782 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1783 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1784 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1785 (bidi_level_of_next_char, bidi_move_to_visually_next):
1786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1787 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1788 (Fkill_buffer, Fset_buffer_major_mode)
1789 (advance_to_char_boundary, Fbuffer_swap_text)
1790 (Fset_buffer_multibyte, overlays_at, overlays_in)
1791 (overlay_touches_p, struct sortvec, record_overlay_string)
1792 (overlay_strings, recenter_overlay_lists)
1793 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1794 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1795 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1796 (Foverlay_recenter, last_overlay_modification_hooks_used)
1797 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1799 (validate_region): Omit unnecessary test for b <= e,
1800 since that's guaranteed by the previous test.
1801 (adjust_overlays_for_delete): Avoid pos + length overflow.
1802 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1803 (report_overlay_modification):
1804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1805 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1806 Omit pointer cast, which isn't needed anyway, and doesn't work
1807 after the EMACS_INT -> ptrdiff_t change.
1808 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1809 * buffer.h: Adjust decls to match defn changes elsewhere.
1810 (struct buffer_text, struct buffer):
1811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1812 Use EMACS_INT, not int, where int might not be wide enough.
1813 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1814 not int, to avoid needless 32-bit limit on 64-bit hosts.
1815 (exec_byte_code): Use tighter memory-full test, one that checks
1816 for alloca overflow. Don't compute the address of the object just
1817 before an array, as that's not portable. Use EMACS_INT, not
1818 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1819 * callint.c (Fcall_interactively):
1820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1821 * callproc.c (call_process_kill, Fcall_process):
1822 Don't assume pid_t fits into an Emacs fixnum.
1823 (call_process_cleanup, Fcall_process, child_setup):
1824 Don't assume pid_t fits into int.
1825 (call_process_cleanup, Fcall_process, delete_temp_file)
1826 (Fcall_process_region):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 (Fcall_process): Simplify handling of volatile integers.
1829 Use int, not EMACS_INT, where int will do.
1830 * casefiddle.c (casify_object, casify_region, operate_on_word)
1831 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1833 (casify_object): Avoid integer overflow when overallocating buffer.
1834 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1835 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1836 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1837 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1838 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1839 integers are now checked earlier. All uses replaced with XINT.
1840 (ccl_driver):
1841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1842 For CCL_MapSingle, check that content and value are in int range.
1843 (ccl_driver, Fregister_code_conversion_map):
1844 Check that Vcode_version_map_vector is a vector.
1845 (resolve_symbol_ccl_program): Check that vector header is in range.
1846 Always copy the vector, so that we can check its contents reliably
1847 now rather than having to recheck each instruction as it's being
1848 executed. Check that vector words fit in 'int'.
1849 (ccl_get_compiled_code, Fregister_ccl_program)
1850 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1851 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1852 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1853 contents are in range.
1854 (Fccl_execute_on_string): Check that status is in range.
1855 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1856 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1857 Accept and return EMACS_INT, not int, because callers can pass values
1858 out of 'int' range.
1859 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1860 (multibyte_chars_in_text, parse_str_as_multibyte)
1861 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1862 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1863 (string_escape_byte8, Fget_byte):
1864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1865 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1866 avoid mishandling large integers.
1867 * character.h: Adjust decls to match defn changes elsewhere.
1868 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1869 (Ffind_charset_region):
1870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1871 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1872 (load_charset_map_from_vector, Fdefine_charset_internal):
1873 Don't assume fixnum fits in int.
1874 (load_charset_map_from_vector, Fmap_charset_chars):
1875 Remove now-unnecessary CHECK_NATNUMs.
1876 (Fdefine_charset_internal): Check ranges here, more carefully.
1877 Don't rely on undefined behavior with signed left shift overflow.
1878 Don't assume unsigned int fits into fixnum, or that fixnum fits
1879 into unsigned int. Don't require max_code to be a valid fixnum;
1880 that's not true for gb10830 4-byte on a 32-bit host. Allow
1881 invalid_code to be a cons, for the same reason. Require code_offset
1882 to be a character. Avoid int overflow if max_char is close
1883 to INT_MAX.
1884 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1885 this is intended anyway and avoids some undefined behavior.
1886 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1887 INDEX_TO_CODE_POINT, as that's what it expects.
1888 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1889 * charset.h (DECODE_CHAR): Return int, not unsigned;
1890 this is what was intended anyway, and it avoids undefined behavior.
1891 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1892 integer-overflow issues.
1893 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1894 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1895 where the argument is EMACS_INT, and this behavior is not intended.
1896 * chartab.c (Fmake_char_table, Fset_char_table_range)
1897 (uniprop_get_decoder, uniprop_get_encoder):
1898 Don't assume fixnum fits in int.
1899 * cmds.c (move_point): New function, that does the gist of
1900 Fforward_char and Fbackward_char, but does so while checking
1901 for integer overflow more accurately.
1902 (Fforward_char, Fbackward_char): Use it.
1903 (Fforward_line, Fend_of_line, internal_self_insert)
1904 (internal_self_insert):
1905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1906 Fix a FIXME, by checking for integer overflow when calculating
1907 target_clm and actual_clm.
1908 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1909 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1910 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1911 (coding_alloc_by_making_gap, alloc_destination)
1912 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1913 (encode_coding_utf_16, detect_coding_emacs_mule)
1914 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1915 (detect_coding_iso_2022, decode_coding_iso_2022)
1916 (encode_invocation_designation, encode_designation_at_bol)
1917 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1918 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1919 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1920 (encode_coding_ccl, encode_coding_raw_text)
1921 (detect_coding_charset, decode_coding_charset)
1922 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1923 (produce_composition, produce_charset, produce_annotation)
1924 (decode_coding, handle_composition_annotation)
1925 (handle_charset_annotation, consume_chars, decode_coding_gap)
1926 (decode_coding_object, encode_coding_object, detect_coding_system)
1927 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1928 (code_convert_region, code_convert_string)
1929 (Fdefine_coding_system_internal)
1930 (coding_set_source, coding_set_destination):
1931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1932 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1933 (Fdefine_coding_system_internal):
1934 Don't assume fixnums fit in int.
1935 (decode_coding_gap, decode_coding_object, encode_coding_object)
1936 (Fread_coding_system, Fdetect_coding_region)
1937 (Funencodable_char_position, Fcheck_coding_systems_region)
1938 (get_translation, handle_composition_annotation, consume_chars):
1939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1940 (consume_chars): Rewrite to not calculate an address outside buffer.
1941 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1942 Don't access memory outside of the args array.
1943 (Fdefine_coding_system_internal): Check for charset-id overflow.
1944 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1945 result of ENCODE_CHAR.
1946 * coding.h: Adjust decls to match defn changes elsewhere.
1947 (struct coding_system):
1948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1949 * composite.c (get_composition_id, find_composition)
1950 (run_composition_function, update_compositions)
1951 (compose_text, composition_gstring_put_cache)
1952 (composition_gstring_p, composition_gstring_width)
1953 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1954 (composition_compute_stop_pos, composition_reseat_it)
1955 (composition_update_it, struct position_record)
1956 (find_automatic_composition, composition_adjust_point)
1957 (Fcomposition_get_gstring, Ffind_composition_internal):
1958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1959 (update_compositions):
1960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1961 * composite.h: Adjust decls to match defn changes elsewhere.
1962 (struct composition):
1963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1964 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1965 Do not attempt to compute the address of the object just before a
1966 buffer; this is not portable.
1967 (Faref, Faset):
1968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1969 (Faset): Use int, not EMACS_INT, where int is wide enough.
1970 (Fstring_to_number): Don't assume fixnums fit in int.
1971 (Frem): Don't assume arg is nonnegative.
1972 * dbusbind.c (xd_append_arg): Check for integers out of range.
1973 (Fdbus_call_method): Don't overflow the timeout int.
1974 (extract_signed, extract_unsigned): New functions.
1975 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1976 (xd_get_connection_references): Return ptrdiff_t, not int.
1977 All uses changed.
1978 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1979 (xd_read_message_1):
1980 Use int, not unsigned, where the dbus API uses int.
1981 (Fdbus_message_internal): Don't overflow mtype.
1982 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1983 * dired.c (directory_files_internal, file_name_completion, scmp)
1984 (file_name_completion_stat):
1985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1986 (file_name_completion): Don't overflow matchcount.
1987 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1988 * dispextern.h: Adjust decls to match defn changes elsewhere.
1989 (struct text_pos, struct glyph, struct bidi_saved_info)
1990 (struct bidi_string_data, struct bidi_it, struct composition_it)
1991 (struct it):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 (struct display_pos, struct composition_it, struct it):
1994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1995 * dispnew.c (increment_matrix_positions)
1996 (increment_row_positions, mode_line_string)
1997 (marginal_area_string):
1998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1999 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2001 (duration_to_sec_usec): New function, to check for overflow better.
2002 (Fsleep_for, sit_for): Use it.
2003 * doc.c (get_doc_string, store_function_docstring):
2004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2005 (get_doc_string, Fsnarf_documentation):
2006 Use int, not EMACS_INT, where int is wide enough.
2007 (get_doc_string):
2008 Use SAFE_ALLOCA, not alloca.
2009 Check for overflow when converting EMACS_INT to off_t.
2010 * doprnt.c (doprnt):
2011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2012 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2013 Don't assume uid_t fits into fixnum.
2014 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2015 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2016 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2017 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2018 (general_insert_function)
2019 (Finsert_char, make_buffer_string, make_buffer_string_both)
2020 (update_buffer_properties, Fbuffer_substring)
2021 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2022 (Fsubst_char_in_region, check_translation)
2023 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2024 (transpose_markers, Ftranspose_regions):
2025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2026 (clip_to_bounds): Move to lisp.h as an inline function).
2027 (Fconstrain_to_field): Don't assume integers are nonnegative.
2028 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2029 (Fsubst_char_in_region, Fsave_restriction):
2030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2031 (Femacs_pid): Don't assume pid_t fits into fixnum.
2032 (lo_time): Use int, not EMACS_INT, when int suffices.
2033 (lisp_time_argument): Check for usec out of range.
2034 (Fencode_time): Don't assume fixnum fits in int.
2035 (Fuser_login_name, Fuser_full_name): Signal an error
2036 if a uid argument is out of range, rather than relying on
2037 undefined behavior.
2038 (Fformat_time_string): Remove now-unnecessary check.
2039 lisp_time_argument checks for out-of-range usec now.
2040 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2041 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2042 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2043 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2044 (init_cmdargs, Fdump_emacs):
2045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2046 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2047 the bottom (typically) 32 bits of the fixnum.
2048 * eval.c (specpdl_size, call_debugger):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (when_entered_debugger, Fbacktrace_debug):
2051 Don't assume fixnum can fit in int.
2052 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2053 the object just before a buffer; this is not portable.
2054 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2055 (grow_specpdl, unbind_to):
2056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2057 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2058 (grow_specpdl): Simplify allocation by using xpalloc.
2059 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2060 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2061 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2063 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2064 (a_write, e_write):
2065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2066 (Fcopy_file, non_regular_nbytes, read_non_regular)
2067 (Finsert_file_contents):
2068 Use int, not EMACS_INT, where int is wide enough.
2069 (READ_BUF_SIZE): Verify that it fits in int.
2070 (Finsert_file_contents): Check that counts are in proper range,
2071 rather than assuming fixnums fit into ptrdiff_t etc.
2072 Don't assume fixnums fit into int.
2073 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2074 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2075 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2076 (string_char_to_byte, string_byte_to_char)
2077 (string_make_multibyte, string_to_multibyte)
2078 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2079 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2080 (substring_both, Fdelete, internal_equal, Ffillarray)
2081 (Fclear_string, mapcar1)
2082 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2083 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2084 (larger_vector, make_hash_table, maybe_resize_hash_table)
2085 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2086 (Fmaphash, secure_hash):
2087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2088 (concat): Check for string index and length overflow.
2089 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2090 (Frequire):
2091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2092 (larger_vector): New API (vec, incr_min, size_max) replaces old
2093 one (vec, new_size, init). This catches size overflow.
2094 INIT was removed because it was always Qnil.
2095 All callers changed.
2096 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2097 the upper bound on a hash table index size.
2098 (make_hash_table, maybe_resize_hash_table): Use it.
2099 (secure_hash): Computer start_byte and end_byte only after
2100 they're known to be in ptrdiff_t range.
2101 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2102 (Ffont_get_glyphs, Ffont_at):
2103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2104 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2105 (Flist_fonts, Fopen_font):
2106 Don't assume fixnum can fit in int.
2107 (check_gstring): Don't assume index can fit in int.
2108 (font_match_p): Check that fixnum is a character, not a nonnegative
2109 fixnum, since the later code needs to stuff it into an int.
2110 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2111 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2112 conversion overflow issues.
2113 (Fopen_font): Check for integer out of range.
2114 (Ffont_get_glyphs): Don't assume index can fit in int.
2115 * font.h: Adjust decls to match defn changes elsewhere.
2116 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2117 integer overflow.
2118 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2119 printmax_t, where ptrdiff_t is wide enough.
2120 (Finternal_char_font):
2121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2122 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2123 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2124 (Fset_frame_position, x_set_frame_parameters)
2125 (x_set_line_spacing, x_set_border_width)
2126 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2127 Check that fixnums are in proper range for system types.
2128 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2130 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2131 Use SAFE_ALLOCA_LISP, not alloca.
2132 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2133 intptr_t is wide enough.
2134 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2135 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2136 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2137 Check for fixnum out of range.
2138 * ftfont.c (ftfont_list): Don't assume index fits in int.
2139 Check that fixnums are in proper range for system types.
2140 (ftfont_shape_by_flt):
2141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2142 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2144 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2145 Check that fixnums are in proper range for system types.
2146 * gnutls.h: Adjust decls to match defn changes elsewhere.
2147 * gtkutil.c (xg_dialog_run):
2148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2149 (update_frame_tool_bar):
2150 Check that fixnums are in proper range for system types.
2151 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2152 (lookup_image): Check that fixnums are in range for system types.
2153 * indent.c (last_known_column, last_known_column_point):
2154 (current_column_bol_cache):
2155 (skip_invisible, current_column, check_display_width):
2156 (check_display_width, scan_for_column, current_column_1)
2157 (Findent_to, Fcurrent_indentation, position_indentation)
2158 (indented_beyond_p, Fmove_to_column, compute_motion):
2159 (Fcompute_motion, Fvertical_motion):
2160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2161 (last_known_column_modified): Use EMACS_INT, not int.
2162 (check_display_width):
2163 (Fcompute_motion):
2164 Check that fixnums and floats are in proper range for system types.
2165 (compute_motion): Don't assume index or fixnum fits in int.
2166 (compute_motion, Fcompute_motion):
2167 Use int, not EMACS_INT, when it is wide enough.
2168 (vmotion): Omit local var start_hpos that is always 0; that way
2169 we don't need to worry about overflow in expressions involving it.
2170 * indent.h: Adjust decls to match defn changes elsewhere.
2171 (struct position):
2172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2173 Use int, not EMACS_INT, where int is wide enough.
2174 Remove unused members ovstring_chars_done and tab_offset;
2175 all uses removed.
2176 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2177 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2178 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2179 (make_gap, copy_text, insert, insert_and_inherit)
2180 (insert_before_markers, insert_before_markers_and_inherit)
2181 (insert_1, count_combining_before, count_combining_after)
2182 (insert_1_both, insert_from_string)
2183 (insert_from_string_before_markers, insert_from_string_1)
2184 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2185 (adjust_after_replace, adjust_after_insert, replace_range)
2186 (replace_range_2, del_range, del_range_1, del_range_byte)
2187 (del_range_both, del_range_2, modify_region)
2188 (prepare_to_modify_buffer, signal_before_change)
2189 (signal_after_change, Fcombine_after_change_execute):
2190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2191 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2192 (balance_an_interval, split_interval_right, split_interval_left)
2193 (find_interval, next_interval, update_interval)
2194 (adjust_intervals_for_insertion, delete_node, delete_interval)
2195 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2196 (static_offset_intervals, offset_intervals)
2197 (merge_interval_right, merge_interval_left, make_new_interval)
2198 (graft_intervals_into_buffer, temp_set_point_both)
2199 (temp_set_point, set_point, adjust_for_invis_intang)
2200 (set_point_both, move_if_not_intangible, get_property_and_range)
2201 (get_local_map, copy_intervals, copy_intervals_to_string)
2202 (compare_string_intervals, set_intervals_multibyte_1):
2203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2204 * intervals.h: Adjust decls to match defn changes elsewhere.
2205 (struct interval):
2206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2207 * keyboard.c (this_command_key_count, this_single_command_key_start)
2208 (before_command_key_count, before_command_echo_length, echo_now)
2209 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2210 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2211 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2212 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2214 (last_non_minibuf_size, last_point_position, echo_truncate)
2215 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2216 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2217 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2218 (stuff_buffered_input):
2219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2220 (last_auto_save, command_loop_1, read_char):
2221 Use EMACS_INT, not int, to avoid integer overflow.
2222 (record_char): Avoid overflow in total_keys computation.
2223 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2224 * keyboard.h: Adjust decls to match defn changes elsewhere.
2225 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2226 (Fkey_description, Fdescribe_vector, Flookup_key):
2227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2228 (click_position): New function, to check that positions are in range.
2229 (Fcurrent_active_maps):
2230 (describe_command):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2232 (Faccessible_keymaps, Fkey_description):
2233 (preferred_sequence_p):
2234 Don't assume fixnum can fit into int.
2235 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2236 Check for integer overflow in size calculations.
2237 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2238 avoid mishandling large integers.
2239 * lisp.h: Adjust decls to match defn changes elsewhere.
2240 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2241 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2242 (struct Lisp_Marker):
2243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2244 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2245 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2246 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2247 All callers changed.
2248 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2249 Assume the arg has valid form, since it always does.
2250 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2251 unsigned integer system type.
2252 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2253 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2255 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2256 (duration_to_sec_usec): New decl.
2257 * lread.c (read_from_string_index, read_from_string_index_byte)
2258 (read_from_string_limit, readchar, unreadchar, openp)
2259 (read_internal_start, read1, oblookup):
2260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2261 (Fload, readevalloop, Feval_buffer, Feval_region):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 (openp): Check for out-of-range argument to 'access'.
2264 (read1): Use int, not EMACS_INT, where int is wide enough.
2265 Don't assume fixnum fits into int.
2266 Fix off-by-one error that can read outside a buffer.
2267 (read_filtered_event): Use duration_to_sec_usec
2268 to do proper overflow checking on durations.
2269 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2270 in size calculation.
2271 (Fexecute_kbd_macro):
2272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2273 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2274 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2275 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2276 (set_marker_both, set_marker_restricted_both, marker_position)
2277 (marker_byte_position, Fbuffer_has_markers_at):
2278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2279 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2280 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2281 It now merely ensures that the menu is large enough, without
2282 necessarily growing it, as this avoids some integer overflow issues.
2283 All callers changed.
2284 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2286 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2287 Use SAFE_ALLOCA_LISP, not alloca.
2288 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2289 to EMACS_INT. Check that fixnums are in proper range for system types.
2290 * minibuf.c (minibuf_prompt_width, string_to_object)
2291 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2292 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2294 (get_minibuffer, read_minibuf_unwind):
2295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2296 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2297 this simplifies overflow checking. All callers changed.
2298 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2299 (Ftest_completion):
2300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2301 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2302 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2303 Check that fixnums are in proper range for system types.
2304 (Fx_create_frame, Fx_show_tip):
2305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2306 * nsfont.m (ns_findfonts, nsfont_list_family):
2307 Don't assume fixnum fits in long.
2308 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2310 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2311 wide enough.
2312 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2314 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2315 (PRINTDECLARE, PRINTPREPARE):
2316 (strout, print_string):
2317 (print, print_preprocess, print_check_string_charset_prop)
2318 (print_object):
2319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2320 (PRINTDECLARE):
2321 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2323 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2324 (printchar, strout): Use xpalloc to catch size calculation overflow.
2325 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2326 (print_error_message): Use SAFE_ALLOCA, not alloca.
2327 (print_object): Use int, not EMACS_INT, where int is wide enough.
2328 (print_depth, new_backquote_output, print_number_index):
2329 Use ptrdiff_t, not int, where int might not be wide enough.
2330 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2331 (Fset_process_window_size, Fformat_network_address)
2332 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2333 (sigchld_handler):
2334 Check that fixnums are in proper range for system types.
2335 (Fsignal_process): Simplify by avoiding a goto.
2336 Check for process-ids out of pid_t range rather than relying on
2337 undefined behavior.
2338 (process_tick, update_tick): Use EMACS_INT, not int.
2339 (Fformat_network_address, read_process_output, send_process)
2340 (Fprocess_send_region, status_notify):
2341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2342 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2343 (wait_reading_process_output, read_process_output, exec_sentinel):
2344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2345 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2346 (Faccept_process_output): Use duration_to_sec_usec to do proper
2347 overflow checking on durations.
2348 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2349 Don't assume pid_t fits in int.
2350 * process.h (struct Lisp_Process): Members tick and update_tick
2351 are now of type EMACS_INT, not int.
2352 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2353 configured --with-wide-int.
2354 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2355 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2356 * search.c (looking_at_1, string_match_1):
2357 (fast_string_match, fast_c_string_match_ignore_case)
2358 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2359 (scan_newline, find_before_next_newline, search_command)
2360 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2361 (set_search_regs, wordify):
2362 (Freplace_match):
2363 (Fmatch_data):
2364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2365 (string_match_1, search_buffer, set_search_regs):
2366 (Fmatch_data):
2367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2368 (wordify): Check for overflow in size calculation.
2369 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2370 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2371 Check that fixnums are in proper range for system types.
2372 * sound.c (struct sound_device)
2373 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2375 (Fplay_sound_internal):
2376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2377 * syntax.c (struct lisp_parse_state, find_start_modiff)
2378 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2379 (Fparse_partial_sexp):
2380 Don't assume fixnums can fit in int.
2381 (struct lisp_parse_state, find_start_pos, find_start_value)
2382 (find_start_value_byte, find_start_begv)
2383 (update_syntax_table, char_quoted, dec_bytepos)
2384 (find_defun_start, prev_char_comend_first, back_comment):
2385 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2386 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2388 (Finternal_describe_syntax_value): Check that match_lisp is a
2389 character, not an integer, since the code stuffs it into int.
2390 (scan_words, scan_sexps_forward):
2391 Check that fixnums are in proper range for system types.
2392 (Fforward_word):
2393 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2394 (scan_sexps_forward):
2395 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2396 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2397 * syntax.h: Adjust decls to match defn changes elsewhere.
2398 (struct gl_state_s):
2399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2400 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2401 MOST_POSITIVE_FIXNUM.
2402 * sysdep.c (wait_for_termination_1, wait_for_termination)
2403 (interruptible_wait_for_termination, mkdir):
2404 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2405 (emacs_read, emacs_write):
2406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2407 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2408 and double all fit in int.
2409 * term.c (set_tty_color_mode):
2410 Check that fixnums are in proper range for system types.
2411 * termhooks.h (struct input_event):
2412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2413 * textprop.c (validate_interval_range, interval_of)
2414 (Fadd_text_properties, set_text_properties_1)
2415 (Fremove_text_properties, Fremove_list_of_text_properties)
2416 (Ftext_property_any, Ftext_property_not_all)
2417 (copy_text_properties, text_property_list, extend_property_ranges)
2418 (verify_interval_modification):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 (Fnext_single_char_property_change)
2421 (Fprevious_single_char_property_change):
2422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2423 (copy_text_properties):
2424 Check for integer overflow in index calculation.
2425 * undo.c (last_boundary_position, record_point, record_insert)
2426 (record_delete, record_marker_adjustment, record_change)
2427 (record_property_change):
2428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2429 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2431 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2432 (Fx_hide_tip, Fx_file_dialog):
2433 * w32menu.c (set_frame_menubar):
2434 Use ptrdiff_t, not int, for consistency with rest of code.
2435 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2436 (select_window, Fdelete_other_windows_internal)
2437 (window_scroll_pixel_based, window_scroll_line_based)
2438 (Frecenter, Fset_window_configuration):
2439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2440 (Fset_window_hscroll, run_window_configuration_change_hook)
2441 (set_window_buffer, temp_output_buffer_show, scroll_command)
2442 (Fscroll_other_window, Frecenter):
2443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2444 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2445 Don't assume fixnum fits in int.
2446 (Fset_window_scroll_bars):
2447 Check that fixnums are in proper range for system types.
2448 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2449 (string_pos, c_string_pos, number_of_chars, init_iterator)
2450 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2451 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2452 (compute_display_string_end, handle_face_prop)
2453 (face_before_or_after_it_pos, handle_invisible_prop)
2454 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2455 (display_prop_intangible_p, string_buffer_position_lim)
2456 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2457 (get_overlay_strings_1, get_overlay_strings)
2458 (iterate_out_of_display_property, forward_to_next_line_start)
2459 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2460 (get_next_display_element, set_iterator_to_next)
2461 (get_visually_first_element, compute_stop_pos_backwards)
2462 (handle_stop_backwards, next_element_from_buffer)
2463 (move_it_in_display_line_to, move_it_in_display_line)
2464 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2465 (add_to_log, message_dolog, message_log_check_duplicate)
2466 (message2, message2_nolog, message3, message3_nolog
2467 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2468 (current_message_1, truncate_echo_area, truncate_message_1)
2469 (set_message, set_message_1, store_mode_line_noprop)
2470 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2471 (text_outside_line_unchanged_p, check_point_in_composition)
2472 (reconsider_clip_changes)
2473 (redisplay_internal, set_cursor_from_row, try_scrolling)
2474 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2475 (redisplay_window, find_last_unchanged_at_beg_row)
2476 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2477 (trailing_whitespace_p, find_row_edges, display_line)
2478 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2479 (display_mode_element, store_mode_line_string)
2480 (pint2str, pint2hrstr, decode_mode_spec)
2481 (display_count_lines, display_string, draw_glyphs)
2482 (x_produce_glyphs, x_insert_glyphs)
2483 (rows_from_pos_range, mouse_face_from_buffer_pos)
2484 (fast_find_string_pos, mouse_face_from_string_pos)
2485 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2487 (safe_call, init_from_display_pos, handle_fontified_prop)
2488 (handle_single_display_spec, load_overlay_strings)
2489 (with_echo_area_buffer, setup_echo_area_for_printing)
2490 (display_echo_area, echo_area_display)
2491 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2492 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2493 (redisplay_window, dump_glyph_row, display_mode_line)
2494 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2495 (handle_display_spec, display_prop_string_p):
2496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2497 (handle_single_display_spec, build_desired_tool_bar_string)
2498 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2499 (get_specified_cursor_type):
2500 Check that fixnums are in proper range for system types.
2501 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2502 (Flookup_image_map):
2503 Don't assume fixnums fit in int.
2504 (compare_overlay_entries):
2505 Avoid mishandling comparisons due to subtraction overflow.
2506 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2507 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2508 (handle_tool_bar_click):
2509 Use int, not unsigned, since we prefer signed and the signedness
2510 doesn't matter here.
2511 (get_next_display_element, next_element_from_display_vector):
2512 Use int, not EMACS_INT, when int is wide enough.
2513 (start_hourglass): Use duration_to_sec_usec to do proper
2514 overflow checking on durations.
2515 * xfaces.c (Fbitmap_spec_p):
2516 Check that fixnums are in proper range for system types.
2517 (compare_fonts_by_sort_order):
2518 Avoid mishandling comparisons due to subtraction overflow.
2519 (Fx_family_fonts, realize_basic_faces):
2520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2521 (Fx_family_fonts):
2522 Don't assume fixnum fits in int.
2523 Use SAFE_ALLOCA_LISP, not alloca.
2524 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2525 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2526 (face_at_buffer_position, face_for_overlay_string)
2527 (face_at_string_position):
2528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2529 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2530 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2531 (Fx_show_tip):
2532 Check that fixnums are in proper range for system types.
2533 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2534 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2536 (Fx_change_window_property): Don't assume fixnums fit in int.
2537 * xfont.c (xfont_chars_supported):
2538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2539 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2540 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2542 * xml.c (parse_region):
2543 * xrdb.c (magic_file_p):
2544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2545 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2546 (x_get_local_selection, x_reply_selection_request)
2547 (x_handle_selection_request, wait_for_property_change):
2548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2549 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2550 short is wide enough.
2551 (x_send_client_event): Don't assume fixnum fits in int.
2552 * xterm.c (x_x_to_emacs_modifiers):
2553 Don't assume EMACS_INT overflows nicely into int.
2554 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2555 may come from Lisp.
2556 (handle_one_xevent): NATNUMP can eval its arg twice.
2557 (x_connection_closed):
2558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2559 * xterm.h: Adjust decls to match defn changes elsewhere.
2560 (struct scroll_bar): Use struct vectorlike_header
2561 rather than rolling our own approximation.
2562 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2563
2564 2012-05-25 Glenn Morris <rgm@gnu.org>
2565
2566 * lisp.mk (lisp): Update for more files being compiled now.
2567
2568 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2569
2570 * lread.c: Remove `read_pure' which makes no difference.
2571 (read_pure): Remove var.
2572 (unreadpure): Remove function.
2573 (readevalloop): Don't call read_list with -1 flag.
2574 (read1, read_vector): Don't test read_pure any more.
2575 (read_list): Simplify.
2576
2577 * fileio.c, character.h: Minor style tweaks.
2578
2579 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2580
2581 * window.h (clip_changed): Remove useless declaration.
2582
2583 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2584
2585 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2586 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2587
2588 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 Remove src/m/*.
2591 This directory predates autoconf and is no longer needed nowadays.
2592 Move its few remaining bits of functionality to where they're needed.
2593 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2594 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2595 * m/template.h: Remove.
2596 * Makefile.in (M_FILE): Remove. All uses removed.
2597 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2598 * lisp.h (USE_LSB_TAG):
2599 * mem-limits.h (EXCEEDS_LISP_PTR):
2600 Use VAL_MAX, not VALBITS, in #if.
2601 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2602 (EMACS_UINT): Define unconditionally now.
2603 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2604 (BITS_PER_EMACS_INT): New constants, replacing
2605 what used to be in config.h, but not useful in #if.
2606 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2607 define them any more.
2608 (VAL_MAX): New macro.
2609 (VALMASK): Use it.
2610 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2611 BITS_PER_EMACS_INT, in #if.
2612 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2613 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2614 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2615 * s/ms-w32.h (DATA_START):
2616 Move here from removed file m/intel386.h.
2617 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2618 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2619
2620 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2621
2622 Assume C89 or later.
2623 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2624 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2625 (xrealloc):
2626 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2627 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2628 * textprop.c, tparam.c (NULL): Remove.
2629 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2630 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2631 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2632 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2633 * xterm.c (input_signal_count): Assume volatile works.
2634
2635 2012-05-21 Ken Brown <kbrown@cornell.edu>
2636
2637 * xgselect.c (xg_select): Fix first argument in call to 'select'
2638 (bug#11508).
2639
2640 2012-05-20 Ken Brown <kbrown@cornell.edu>
2641
2642 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2643 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2644
2645 2012-05-19 Ken Brown <kbrown@cornell.edu>
2646
2647 * xfns.c (x_in_use): Remove `static' qualifier.
2648 * xterm.h (x_in_use): Declare.
2649 * xgselect.c: Include xterm.h.
2650 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2651 and `display_arg' (bug#9754).
2652
2653 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2656
2657 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2658 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2659
2660 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2661
2662 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2663
2664 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2665 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2666
2667 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2668 reference to image_cache->refcount.
2669 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2670
2671 2012-05-17 Juri Linkov <juri@jurta.org>
2672
2673 * search.c (Fword_search_regexp, Fword_search_backward)
2674 (Fword_search_forward, Fword_search_backward_lax)
2675 (Fword_search_forward_lax): Move functions to isearch.el
2676 (bug#10145, bug#11381).
2677
2678 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2681
2682 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2683
2684 * lread.c (init_obarray): Declare Qt and Qnil as special.
2685
2686 2012-05-14 Glenn Morris <rgm@gnu.org>
2687
2688 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2689 Put "libexec" before "bin", for the sake of init_callproc_1.
2690
2691 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2694
2695 * unexaix.c: Port to more-recent AIX compilers.
2696 (report_error, report_error_1, make_hdr, copy_sym)
2697 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2698 Make arguments const char *, not char *, to avoid violations of C
2699 standard and to fix some AIX warnings reported by Gilles Pion.
2700
2701 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2702
2703 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2704 already have overlays loaded.
2705 (handle_single_display_spec): Before returning without displaying
2706 fringe bitmap, synchronize the bidi iterator with the main display
2707 iterator, by calling iterate_out_of_display_property.
2708 (iterate_out_of_display_property): Detect buffer iteration by
2709 testing that it->string is a Lisp string.
2710 (get_next_display_element): When the current object is exhausted,
2711 and there's something on it->stack, call set_iterator_to_next to
2712 proceed with what's on the stack, instead of returning zero.
2713 (set_iterator_to_next): If called at the end of a Lisp string,
2714 proceed to consider_string_end without incrementing string
2715 position. Don't increment display vector index past the end of
2716 the display vector. (Bug#11417)
2717 (pos_visible_p): Don't report a position visible when move_it_to
2718 stopped at the last line of window, which happens to be scanned
2719 backwards by the bidi iteration. (Bug#11464)
2720
2721 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2722
2723 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2724 and right-margin display specs even if the spec is invalid or we
2725 are on a TTY, and thus unable to display on the fringes.
2726 That's because the text with the property will not be displayed anyway,
2727 so we need to signal to the caller that this is a "replacing"
2728 display spec. This fixes display when the spec is invalid or we
2729 are on a TTY.
2730
2731 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2732
2733 * unexaix.c (make_hdr): Fix typo in prototype.
2734 This bug broke the build on AIX. Problem reported by Gilles Pion.
2735
2736 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2737
2738 * keyboard.c (kbd_buffer_get_event): Read special events also in
2739 batch mode. (Bug#11415)
2740
2741 2012-05-12 Glenn Morris <rgm@gnu.org>
2742
2743 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2744
2745 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2746
2747 * lisp.mk (lisp): Add newcomment.elc.
2748
2749 2012-05-12 Glenn Morris <rgm@gnu.org>
2750
2751 * Makefile.in (MKDIR_P): New, set by configure.
2752 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2753
2754 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 Remove unused function hourglass_started.
2757 * dispextern.h (hourglass_started):
2758 * w32fns.c (hourglass_started):
2759 * xdisp.c (hourglass_started): Remove.
2760
2761 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2762
2763 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2764 Update dependencies.
2765
2766 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 * xgselect.c (xg_select): Put maxfds+1 into a var.
2769 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2770
2771 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2772
2773 2012-05-10 Dave Abrahams <dave@boostpro.com>
2774
2775 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2776 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2777
2778 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2779
2780 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2781 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2782 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2783 Initialize xd_registered_buses.
2784
2785 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 Untag more efficiently if USE_LSB_TAG.
2788 This is based on a proposal by YAMAMOTO Mitsuharu in
2789 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2790 For an admittedly artificial (nth 8000 longlist) benchmark on
2791 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2792 Emacs's overall text size by 1%.
2793 * lisp.h (XUNTAG): New macro.
2794 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2795 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2796 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2797 * eval.c (Fautoload):
2798 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2799 * frame.h (XFRAME): Use XUNTAG.
2800
2801 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2802 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2803 Remove unportable assumptions about print widths of types like
2804 dbus_uint32_t.
2805 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2806 intptr_t when converting between pointer and integer, to avoid GCC
2807 warnings about wrong width.
2808
2809 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2810
2811 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2812 stack for each reader_thread, instead of defaulting to 8MB
2813 determined by the linker. This avoids failures in creating
2814 subprocesses on Windows 7, see the discussion in this thread:
2815 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2816
2817 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2818
2819 Fix up display of the *Minibuf-0* buffer in the mini window.
2820 * keyboard.c (read_char): Don't clear the echo area if there's no
2821 message to clear.
2822 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2823 contents of *Minibuf-0*) if there's no message displayed in its stead.
2824
2825 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2826
2827 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2828 batch mode.
2829
2830 2012-05-06 Chong Yidong <cyd@gnu.org>
2831
2832 * lisp.mk (lisp): Update.
2833
2834 2012-05-05 Jim Meyering <meyering@redhat.com>
2835
2836 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2837
2838 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2839
2840 * data.c (PUT_ERROR): New macro.
2841 (syms_of_data): Use it. Add new error type `user-error'.
2842 * undo.c (user_error): New function.
2843 (Fprimitive_undo): Use it.
2844 * print.c (print_error_message): Adjust print style for `user-error'.
2845 * keyboard.c (user_error): New function.
2846 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2847
2848 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 Do not limit current-time-string to years 1000..9999.
2851 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2852 (Fcurrent_time_string): Support any year that is supported by the
2853 underlying localtime representation. Don't use asctime, as it
2854 has undefined behavior for years outside the range -999..9999.
2855
2856 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 Fix race conditions involving setenv, gmtime, localtime, asctime.
2859 Without this fix, interrupts could mess up code that uses these
2860 nonreentrant functions, since setting TZ invalidates existing
2861 tm_zone or tzname values, and since most of these functions return
2862 pointers to static storage.
2863 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2864 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2865 Grow the critical sections to include not just invoking
2866 localtime/gmtime, but also accessing these functions' results
2867 including their tm_zone values if any, and any related TZ setting.
2868 (format_time_string): Last arg is now struct tm *, not struct tm **,
2869 so that the struct tm is saved in the critical section.
2870 All callers changed. Simplify allocation of initial buffer, partly
2871 motivated by the fact that memory allocation needs to be outside
2872 the critical section.
2873
2874 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2875
2876 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2877 with RESET_INTERVAL.
2878
2879 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2880 Remove duplicated buffer name initialization.
2881
2882 2012-05-02 Jim Meyering <jim@meyering.net>
2883
2884 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2885
2886 * xfns.c (x_window): Use xstrdup (Bug#11375).
2887
2888 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2889
2890 * xdisp.c (pos_visible_p): If already at a newline from the
2891 display string before the 'while' loop, don't walk back the glyphs
2892 from it3.glyph_row. Solves assertion violation when the display
2893 string begins with a newline (egg.el). (Bug#11367)
2894
2895 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2896
2897 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2898 Move to simple.el.
2899
2900 2012-05-01 Glenn Morris <rgm@gnu.org>
2901
2902 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2903 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2904 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2905 All were removed before 23.1.
2906
2907 * dispnew.c: Remove HAVE_LIBNCURSES test;
2908 it is always true on relevant platforms.
2909
2910 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2911 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2912
2913 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2914
2915 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2916
2917 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2918 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2919 Remove.
2920
2921 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 Do not avoid creating empty evaporating overlays (Bug#9642).
2924 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2925 That is, do not delete an evaporating overlay if it becomes
2926 empty after its bounds are adjusted to fit within its buffer.
2927 This fix caused other problems, and I'm reverting it until we get
2928 to the bottom of them.
2929
2930 2012-04-27 Chong Yidong <cyd@gnu.org>
2931
2932 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2933
2934 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2935
2936 * xdisp.c (pos_visible_p): If the window start position is beyond
2937 ZV, start the display from buffer beginning. Prevents assertion
2938 violation in init_iterator when the minibuffer window is scrolled
2939 via the scroll bar.
2940
2941 * window.c (window_scroll_pixel_based): Likewise.
2942
2943 2012-04-27 Chong Yidong <cyd@gnu.org>
2944
2945 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2946
2947 2012-04-27 Glenn Morris <rgm@gnu.org>
2948
2949 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2950 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2951
2952 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2953
2954 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2955 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2956
2957 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2958
2959 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2960 display element, check also the underlying string or buffer
2961 character. (Bug#11341)
2962
2963 * w32menu.c: Include w32heap.h.
2964 (add_menu_item): If the call to AppendMenuW (via
2965 unicode_append_menu) fails, disable Unicode menus only if we are
2966 running on Windows 9X/Me.
2967
2968 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2969
2970 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2971 (xgetint): Add missing shift for LSB tags.
2972
2973 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2974
2975 * keyboard.c (read_char): Don't wipe echo area for select window
2976 events: These might get delayed via `mouse-autoselect-window'
2977 (Bug#11304).
2978
2979 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2980
2981 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2982 manipulation of :loaded-from data.
2983
2984 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2985
2986 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2987 now a cons (bug#11311).
2988
2989 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 Do not create empty overlays with the evaporate property (Bug#9642).
2992 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2993 if it becomes empty after its bounds are adjusted to fit within
2994 its buffer. Without this fix, in a nonempty buffer (let ((o
2995 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2996 yields an empty overlay that has the evaporate property, which is
2997 not supposed to happen.
2998
2999 Fix minor GTK3 problems found by static checking.
3000 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3001 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3002 (struct _EmacsFixedClass, emacs_fixed_get_type):
3003 Move decls here from emacsgtkfixed.h, since they needn't be public.
3004 (emacs_fixed_get_type): Now static.
3005 (emacs_fixed_class_init): Omit unused local.
3006 (emacs_fixed_child_type): Remove; unused.
3007 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3008 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3009 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3010 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3011 (EMACS_FIXED_GET_CLASS): Remove; unused.
3012 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3013
3014 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3015 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3016
3017 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3020 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3021 (__malloc_size_t, __malloc_ptrdiff_t):
3022 Remove. All uses removed, replaced by the definiens if needed,
3023 since we can assume C89 or better now.
3024 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3025 (protect_malloc_state, align, get_contiguous_space)
3026 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3027 (malloc_atfork_handler_child, malloc_enable_thread)
3028 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3029 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3030 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3031 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3032 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3033 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3034 Define using prototypes, not old style.
3035 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3036 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3037 (align): Don't assume that signed integer overflow wraps around.
3038 Omit unused local var.
3039 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3040 (_free_internal_nolock, memalign, mallochook, reallochook):
3041 Omit no-longer-needed casts.
3042 (valloc): Use getpagesize, not __getpagesize.
3043 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3044 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3045
3046 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3047
3048 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3049
3050 Move functions from C to Lisp. Make non-blocking method calls
3051 the default. Implement further D-Bus standard interfaces.
3052
3053 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3054 (QCdbus_request_name_allow_replacement)
3055 (QCdbus_request_name_replace_existing)
3056 (QCdbus_request_name_do_not_queue)
3057 (QCdbus_request_name_reply_primary_owner)
3058 (QCdbus_request_name_reply_in_queue)
3059 (QCdbus_request_name_reply_exists)
3060 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3061 (QCdbus_registered_serial, QCdbus_registered_method)
3062 (QCdbus_registered_signal): New Lisp objects.
3063 (XD_DEBUG_MESSAGE): Use sizeof.
3064 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3065 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3066 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3067 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3068 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3069 (xd_signature, xd_append_arg): Allow float for integer types.
3070 (xd_get_connection_references): New function.
3071 (xd_get_connection_address): Rename from xd_initialize.
3072 Return cached address.
3073 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3074 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3075 level.
3076 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3077 Return number of refcounts.
3078 (Fdbus_get_unique_name): Make stronger parameter check.
3079 (Fdbus_message_internal): New defun.
3080 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3081 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3082 (Fdbus_send_signal, Fdbus_register_service)
3083 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3084 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3085 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3086 (Vdbus_compiled_version, Vdbus_runtime_version)
3087 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3088 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3089 (Vdbus_message_type_signal): New defvars.
3090 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3091 Adapt docstring.
3092
3093 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3094
3095 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3096 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3097 Do not assume ptrdiff_t is the same width as 'int'.
3098
3099 * alloc.c: Handle unusual debugging option combinations.
3100 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3101 since the two debugging options are incompatible.
3102 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3103 is defined.
3104 (mem_init, mem_insert, mem_insert_fixup):
3105 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3106 (NEED_MEM_INSERT): Remove; no longer needed.
3107
3108 2012-04-22 Leo Liu <sdl.web@gmail.com>
3109
3110 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3111
3112 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 * sysdep.c [__FreeBSD__]: Minor cleanups.
3115 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3116 Use Emacs indenting style more consistently. Avoid some casts.
3117 Use 'double' consistently rather than mixing 'float' and 'double'.
3118
3119 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3120
3121 * sysdep.c (list_system_processes, system_process_attributes):
3122 Add implementation for FreeBSD (Bug#5243).
3123
3124 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3125
3126 * lisp.mk (lisp): Update.
3127
3128 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3131 It is never used otherwise.
3132
3133 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3134
3135 * print.c (print_preprocess): Only check print_depth if print-circle
3136 is nil.
3137 (print_object): Check for cycles even when print-circle is nil and
3138 print-gensym is t, but only check print_depth if print-circle is nil.
3139
3140 2012-04-20 Chong Yidong <cyd@gnu.org>
3141
3142 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3143 set the status to "failed" and ensure that sentinel is run.
3144
3145 2012-04-20 Glenn Morris <rgm@gnu.org>
3146
3147 * process.c (Fset_process_inherit_coding_system_flag)
3148 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3149 (Fmake_network_process, Fmake_serial_process): Doc fix.
3150
3151 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3152
3153 * xdisp.c (string_buffer_position_lim): Limit starting position to
3154 BEGV.
3155 (set_cursor_from_row): If called for a mode-line or header-line
3156 row, return zero immediately.
3157 (try_cursor_movement): If inside continuation line, don't back up
3158 farther than the first row after the header line, if any.
3159 Don't consider the header-line row as "partially visible", even if
3160 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3161
3162 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3163
3164 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3165 (bug#11238).
3166
3167 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3168 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3169
3170 configure: new option --enable-gcc-warnings (Bug#11207)
3171 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3172 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3173 (ALL_CFLAGS): Use new macros rather than old.
3174 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3175 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3176 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3177 -Wunused-result, -Wunused-variable. This should go away once
3178 the Emacs and Gnulib regex code is merged.
3179 (xmalloc, xrealloc): Now static.
3180
3181 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3182
3183 * dired.c (Fsystem_groups): Remove unused local.
3184
3185 2012-04-17 Glenn Morris <rgm@gnu.org>
3186
3187 * dired.c (Fsystem_users): Doc fix.
3188
3189 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3190
3191 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3192 (syms_of_dired): Add them.
3193
3194 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 Fix minor alloc.c problems found by static checking.
3197 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3198 New extern decls, to avoid calling undeclared functions.
3199 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3200 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3201 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3202 (NEED_MEM_INSERT): New macro.
3203 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3204 Remove one incorrect comment and fix another.
3205
3206 Fix minor ralloc.c problems found by static checking.
3207 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3208 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3209 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3210 (r_alloc_sbrk): Now static.
3211
3212 Improve ralloc.c interface checking.
3213 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3214 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3215 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3216 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3217 [REL_ALLOC]: ... to here, to check interface.
3218 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3219 Remove decls. This fixes an "It stinks!".
3220
3221 * alloc.c (which_symbols): Fix alignment issue / type clash.
3222
3223 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3224
3225 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3226 (struct Lisp_Misc_Any): Likewise.
3227 (struct Lisp_Free): Likewise.
3228 * alloc.c (union aligned_Lisp_Symbol): Define.
3229 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3230 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3231 (union aligned_Lisp_Misc): Define.
3232 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3233 aligned_Lisp_Misc instead of union Lisp_Misc.
3234 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3235
3236 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3239 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3240 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3241 * s/netbsd.h, s/sol2-6.h:
3242 Remove definition of GC_MARK_STACK, since the default now works.
3243 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3244 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3245 no longer the default.
3246 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3247
3248 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3249
3250 * lread.c (lisp_file_lexically_bound_p):
3251 Fix hang at ";-*-\n" (bug#11238).
3252
3253 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3254
3255 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3256 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3257
3258 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3259
3260 * nsterm.m (constrainFrameRect): Always constrain when there is only
3261 one screen (Bug#10962).
3262
3263 2012-04-13 Ken Brown <kbrown@cornell.edu>
3264
3265 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3266
3267 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3268
3269 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3270
3271 2012-04-11 Daniel Colascione <dancol@dancol.org>
3272
3273 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3274 against is gone. It's better to use vfork now so that when Cygwin
3275 gains a new, working vfork, we use it automatically (bug#10398).
3276
3277 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3278
3279 * window.c (save_window_save): Obey window-point-insertion-type.
3280
3281 2012-04-11 Glenn Morris <rgm@gnu.org>
3282
3283 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3284
3285 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3286
3287 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3288
3289 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3290
3291 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3292 (force_quit_count): New var.
3293 (handle_interrupt): Use it.
3294
3295 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3296
3297 * w32.c (w32_delayed_load): Record the full path of the library
3298 being loaded (bug#10424).
3299
3300 2012-04-09 Glenn Morris <rgm@gnu.org>
3301
3302 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3303 not just in the obarray, before snarfing them. (Bug#11036)
3304
3305 * Makefile.in ($(leimdir)/leim-list.el):
3306 Pass EMACS rather than BUILT_EMACS.
3307
3308 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3309
3310 * process.c (make_process):
3311 * process.h: Add integer `gnutls_handshakes_tried' member to
3312 process struct.
3313
3314 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3315 Add convenience `GNUTLS_LOG2i' macro.
3316
3317 * gnutls.c (gnutls_log_function2i): Convenience log function.
3318 (emacs_gnutls_read): Use new log functions,
3319 `gnutls_handshakes_tried' process member, and
3320 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3321 attempts per process (connection).
3322
3323 2012-04-09 Chong Yidong <cyd@gnu.org>
3324
3325 * eval.c (Fuser_variable_p, user_variable_p_eh)
3326 (lisp_indirect_variable): Functions deleted.
3327 (Fdefvar): Caller changed.
3328
3329 * callint.c (Finteractive, Fcall_interactively):
3330 * minibuf.c (Fread_variable): Callers changed.
3331
3332 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3333
3334 * xdisp.c (set_cursor_from_row): If the display string appears in
3335 the buffer at position that is closer to point than the position
3336 after the display string, display the cursor on the first glyph of
3337 the display string. Fixes cursor display when a 'display' text
3338 property immediately follows invisible text. (Bug#11094)
3339
3340 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 composite.c: use 'double' consistently
3343 * composite.c (get_composition_id): Use 'double' consistently
3344 instead of converting 'float' to 'double' and vice versa; this is
3345 easier to understand and avoids a GCC warning.
3346
3347 2012-04-09 Glenn Morris <rgm@gnu.org>
3348
3349 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3350 preparation for dumping it with emacs. (Bug#4789)
3351 (leimdir): New variable.
3352 ($(leimdir)/leim-list.el): New rule.
3353 (emacs$(EXEEXT)): Depend on leim-list.el.
3354
3355 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3356 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3357 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3358
3359 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3360
3361 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3362 proper alignment.
3363
3364 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3365
3366 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3367 Remove unused local variable.
3368
3369 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3370
3371 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3372 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3373 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3374 objects, as mark_maybe_pointer will catch them otherwise.
3375 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3376 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3377
3378 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 Fix typo that broke non-Windows builds.
3381 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3382
3383 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3384
3385 Support building on MS-Windows with libxml2.
3386
3387 * makefile.w32-in (OBJ2): Add xml.$(O).
3388 (GLOBAL_SOURCES): Add xml.c.
3389 ($(BLD)/xml.$(O)): New dependency list.
3390
3391 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3392 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3393 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3394 [!WINDOWSNT]: New macros.
3395 (init_libxml2_functions, libxml2_loaded_p): New functions.
3396 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3397 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3398 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3399 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3400 linked in).
3401 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3402 Call init_libxml2_functions before calling libxml2 functions.
3403 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3404
3405 * emacs.c: Don't include libxml/parser.h.
3406 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3407 xmlCleanupParser directly.
3408
3409 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3410
3411 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3412
3413 * indent.c (Fvertical_motion): If there is a display string at
3414 point, use it.vpos to compute how many lines to backtrack after
3415 move_it_to point. (Bug#11133)
3416
3417 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3418
3419 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3420 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3421 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3422 macros related to unification of CJK characters. For the details,
3423 see the discussion following the message here:
3424 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3425
3426 2012-04-04 Chong Yidong <cyd@gnu.org>
3427
3428 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3429
3430 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3431
3432 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3433 instead of alloca. (Bug#11138)
3434
3435 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3436
3437 * w32menu.c (is_simple_dialog): Properly check lisp types.
3438 (Bug#11141)
3439
3440 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3441
3442 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3443 position we get to after a call to move_it_to fails the
3444 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3445 only if we wind up in a string from display property. (Bug#11063)
3446
3447 * window.c (Fdelete_other_windows_internal): Invalidate the row
3448 and column information about mouse highlight, so that redisplay
3449 restores it after reallocating the glyph matrices. (Bug#7464)
3450
3451 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3452 string comes from a `display' text property, use the buffer
3453 position of that property as if we actually saw that position in
3454 the row's glyphs.
3455 (move_it_by_lines): Remove the assertion that
3456 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3457 violated when there's a before-string at the beginning of a line.
3458 (Bug#11063)
3459
3460 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3461
3462 * xdisp.c (append_space_for_newline): If the default face was
3463 remapped, use the remapped face for the appended newline.
3464 (extend_face_to_end_of_line): Use the remapped default face for
3465 extending the face to the end of the line.
3466 (display_line): Call extend_face_to_end_of_line when the default
3467 face was remapped. (Bug#11068)
3468
3469 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3470
3471 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3472
3473 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3474
3475 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3476
3477 2012-03-27 Glenn Morris <rgm@gnu.org>
3478
3479 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3480 Doc fixes.
3481
3482 2012-03-26 Kenichi Handa <handa@m17n.org>
3483
3484 * dispextern.h (struct glyph): Fix previous change. Change the
3485 bit length of glyphless.ch to 25 (Bug#11082).
3486
3487 2012-03-26 Chong Yidong <cyd@gnu.org>
3488
3489 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3490 (command_loop_1): Use it; inhibit selection update for
3491 handle-select-window too (Bug#8996).
3492
3493 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3494
3495 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3496
3497 2012-03-25 Kenichi Handa <handa@m17n.org>
3498
3499 * dispextern.h (struct glyph): Change the bit length of
3500 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3501
3502 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3503
3504 * s/ms-w32.h (tzname): Include time.h before redirecting to
3505 _tzname. Fixes the MSVC build. (Bug#9960)
3506
3507 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3508
3509 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3510 characters.
3511
3512 * xterm.c (XTread_socket): Only modify handling_signal if
3513 !SYNC_INPUT. (Bug#11080)
3514
3515 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3516
3517 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3518 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3519 when fetching a multibyte character consumes more bytes than
3520 CHAR_BYTES returns, due to unification of CJK characters in
3521 string_char. (Bug#11073)
3522
3523 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3524
3525 * process.c (wait_reading_process_output): Handle pty disconnect
3526 by refraining from sending oneself a SIGCHLD (bug#10933).
3527
3528 2012-03-22 Chong Yidong <cyd@gnu.org>
3529
3530 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3531
3532 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3533 Mark string as coming from a prefix property.
3534 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3535 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3536
3537 2012-03-21 Chong Yidong <cyd@gnu.org>
3538
3539 * xfaces.c (Vface_remapping_alist): Doc fix.
3540
3541 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3542
3543 * w32proc.c (Fw32_set_console_codepage)
3544 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3545 Doc fixes.
3546
3547 2012-03-20 Chong Yidong <cyd@gnu.org>
3548
3549 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3550 to reflect default non-nil value of redisplay-dont-pause.
3551
3552 2012-03-19 Kenichi Handa <handa@m17n.org>
3553
3554 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3555 it fit in a valid range (Bug#11003).
3556
3557 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3558
3559 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3560 that is not from display property, accept the row as a "cursor
3561 row" if one of the string's character has a non-nil `cursor'
3562 property. Fixes cursor positioning when there are newlines in
3563 overlay strings, e.g. in icomplete.el. (Bug#11035)
3564
3565 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3568
3569 2012-03-12 Chong Yidong <cyd@gnu.org>
3570
3571 * eval.c (inhibit_lisp_code): Rename from
3572 inhibit_window_configuration_change_hook; move from window.c.
3573
3574 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3575 * window.c (run_window_configuration_change_hook)
3576 (syms_of_window): Callers changed.
3577
3578 2012-03-11 Chong Yidong <cyd@gnu.org>
3579
3580 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3581
3582 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3583
3584 2012-03-10 Chong Yidong <cyd@gnu.org>
3585
3586 * frame.c (other_visible_frames): Don't assume the selected frame
3587 is visible (Bug#10955).
3588
3589 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3592
3593 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3594
3595 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3596 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3597 zero (Bug#10954).
3598
3599 2012-03-03 Glenn Morris <rgm@gnu.org>
3600
3601 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3602
3603 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3604
3605 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3606 position past the first glyph_row that ends at ZV. (Bug#10902)
3607 (redisplay_window, next_element_from_string): Fix typos in
3608 comments.
3609 (redisplay_window): Pass to move_it_vertically the margin in
3610 pixels, not in screen lines.
3611
3612 2012-03-02 Glenn Morris <rgm@gnu.org>
3613
3614 * buffer.c (buffer-list-update-hook): Doc fix.
3615
3616 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3617
3618 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3619 push_it before setting up the iterator for the first overlay
3620 string, even if we have an empty string loaded.
3621 (next_overlay_string): If there's an empty string on the iterator
3622 stack, pop the stack. (Bug#10903)
3623
3624 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3625
3626 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3627 Suggested by Stefan Monnier in
3628 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3629 * alloc.c (widen_to_Lisp_Object): New static function.
3630 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3631 and widening them to Lisp_Objects. This would work even if
3632 USE_LSB_TAG is defined and wide integers are used, which might
3633 happen in a future version of Emacs.
3634
3635 2012-02-25 Chong Yidong <cyd@gnu.org>
3636
3637 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3638 Doc fix.
3639
3640 * xselect.c (Fx_selection_exists_p): Doc fix.
3641 (x_clipboard_manager_save_all): Print an informative message
3642 before saving to clipboard manager.
3643
3644 2012-02-24 Chong Yidong <cyd@gnu.org>
3645
3646 * keyboard.c (process_special_events): Handle all X selection
3647 requests in kbd_buffer, not just the next one (Bug#8869).
3648
3649 2012-02-23 Chong Yidong <cyd@gnu.org>
3650
3651 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3652 call when setting menu-bar-lines and tool-bar-lines parameters.
3653 (unwind_create_frame_1): New helper function.
3654
3655 * window.c (inhibit_window_configuration_change_hook): New var.
3656 (run_window_configuration_change_hook): Obey it.
3657 (syms_of_window): Initialize it.
3658
3659 2012-02-22 Chong Yidong <cyd@gnu.org>
3660
3661 * xterm.c (x_draw_image_relief): Add missing type check for
3662 Vtool_bar_button_margin (Bug#10743).
3663
3664 2012-02-21 Chong Yidong <cyd@gnu.org>
3665
3666 * fileio.c (Vfile_name_handler_alist): Doc fix.
3667
3668 * buffer.c (Fget_file_buffer): Protect against invalid file
3669 handler return value.
3670
3671 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3674 when computing $valmask.
3675
3676 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3677 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3678 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3679 It's useless in that case, and it can cause problems on hosts
3680 that allocate halves of EMACS_INT values separately.
3681 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3682 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3683 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3684 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3685 it avoids undefined behavior on hosts where shifting right by more
3686 than the word width has undefined behavior.
3687
3688 2012-02-19 Chong Yidong <cyd@gnu.org>
3689
3690 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3691 (Funhandled_file_name_directory, Ffile_name_as_directory)
3692 (Fdirectory_file_name, Fexpand_file_name)
3693 (Fsubstitute_in_file_name): Protect against invalid file handler
3694 return values (Bug#10845).
3695
3696 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3697
3698 * .gdbinit (pitx): Fix incorrect references to fields of the
3699 iterator stack.
3700
3701 2012-02-17 Chong Yidong <cyd@gnu.org>
3702
3703 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3704
3705 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3708 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3709
3710 2012-02-15 Chong Yidong <cyd@gnu.org>
3711
3712 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3713 marked as special. Also, starting docstrings with * is obsolete.
3714
3715 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3716
3717 * gnutls.c (emacs_gnutls_write): Fix last change.
3718
3719 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3720
3721 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3722 send_process.
3723
3724 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3725
3726 * keymap.c (Fsingle_key_description): Handle char ranges.
3727
3728 2012-02-12 Chong Yidong <cyd@gnu.org>
3729
3730 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3731 as that creates a dangerous corner case.
3732
3733 * window.c (Fdelete_window_internal): Invalidate the mouse
3734 highlight (Bug#9904).
3735
3736 2012-02-12 Glenn Morris <rgm@gnu.org>
3737
3738 * xselect.c (Fx_own_selection_internal)
3739 (Fx_get_selection_internal, Fx_disown_selection_internal)
3740 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3741 * nsselect.m (Fx_own_selection_internal)
3742 (Fx_disown_selection_internal, Fx_selection_exists_p)
3743 (Fx_selection_owner_p, Fx_get_selection_internal):
3744 Sync docs and argument specs with the xselect.c versions.
3745
3746 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3747
3748 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3749
3750 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3751
3752 * w32select.c (Fx_selection_exists_p): Sync doc string and
3753 argument list with xselect.c. (Bug#10783)
3754
3755 * w16select.c (Fx_selection_exists_p): Sync doc string and
3756 argument list with xselect.c. (Bug#10783)
3757
3758 2012-02-10 Glenn Morris <rgm@gnu.org>
3759
3760 * fns.c (Fsecure_hash): Doc fix.
3761
3762 2012-02-09 Kenichi Handa <handa@m17n.org>
3763
3764 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3765
3766 2012-02-07 Chong Yidong <cyd@gnu.org>
3767
3768 * buffer.c (Fbuffer_local_variables)
3769 (buffer_lisp_local_variables): Handle unbound vars correctly;
3770 don't let Qunbound leak into Lisp.
3771
3772 2012-02-07 Glenn Morris <rgm@gnu.org>
3773
3774 * image.c (Fimagemagick_types): Doc fix.
3775
3776 * image.c (imagemagick-render-type): Change it from a lisp object
3777 to an integer. Move the doc here from the lisp manual.
3778 Treat all values not equal to 0 the same.
3779
3780 2012-02-06 Chong Yidong <cyd@gnu.org>
3781
3782 * doc.c (store_function_docstring): Avoid applying docstring of
3783 alias to base function (Bug#2603).
3784
3785 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3786
3787 * .gdbinit (pp1, pv1): Remove redundant defines.
3788 (pr): Use pp.
3789
3790 2012-02-04 Chong Yidong <cyd@gnu.org>
3791
3792 * nsterm.m: Declare a global (Bug#10694).
3793
3794 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3795
3796 * w32.c (get_emacs_configuration_options):
3797 Include --enable-checking, if specified, in the return value.
3798
3799 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3800
3801 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3802 after rounding frame sizes. (Bug#9723)
3803
3804 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3805
3806 * keyboard.c (adjust_point_for_property): Don't position point
3807 before BEGV. (Bug#10696)
3808
3809 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 Handle overflow when computing char display width (Bug#9496).
3812 * character.c (char_width): Return EMACS_INT, not int.
3813 (char_width, c_string_width): Check for overflow when
3814 computing the width; this is possible now that individual
3815 characters can have unbounded width. Problem introduced
3816 by merge from Emacs 23 on 2012-01-19.
3817
3818 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3819
3820 * dbusbind.c (Fdbus_register_method): Mention the return value
3821 :ignore in the docstring.
3822
3823 2012-02-02 Glenn Morris <rgm@gnu.org>
3824
3825 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3826
3827 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3828 Unconditionally set to t. (Bug#10673)
3829 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3830 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3831 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3832
3833 2012-02-02 Kenichi Handa <handa@m17n.org>
3834
3835 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3836 0, do not call append_composite_glyph.
3837
3838 2012-02-02 Kenichi Handa <handa@m17n.org>
3839
3840 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3841 NULL (Bug#6988).
3842 (x_produce_glyphs): If the component of a composition is a null
3843 string, set it->pixel_width to 1 to avoid zero-width glyph.
3844
3845 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3846
3847 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3848 first 2 arguments are identical. This makes inserting large
3849 output from a subprocess an order of magnitude faster on
3850 MS-Windows, where all sbrk'ed memory is always contiguous.
3851
3852 2012-01-31 Glenn Morris <rgm@gnu.org>
3853
3854 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3855 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3856 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3857
3858 2012-01-29 Glenn Morris <rgm@gnu.org>
3859
3860 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3861
3862 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3863
3864 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3865
3866 2012-01-28 Chong Yidong <cyd@gnu.org>
3867
3868 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3869
3870 2012-01-26 Chong Yidong <cyd@gnu.org>
3871
3872 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3873
3874 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3875 repeat counts (Bug#10507).
3876
3877 2012-01-26 Glenn Morris <rgm@gnu.org>
3878
3879 * lread.c (syms_of_lread): Doc fix.
3880
3881 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3882
3883 * coding.c (encode_designation_at_bol): Change return value to
3884 EMACS_INT.
3885
3886 2012-01-25 Chong Yidong <cyd@gnu.org>
3887
3888 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3889
3890 2012-01-21 Chong Yidong <cyd@gnu.org>
3891
3892 * floatfns.c (Fcopysign): Make the second argument non-optional,
3893 since nil is not allowed anyway.
3894
3895 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3896
3897 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3898 (send_process): Likewise.
3899
3900 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3901
3902 * window.c (save_window_save, Fcurrent_window_configuration)
3903 (Vwindow_persistent_parameters): Do not use Qstate.
3904 Rewrite doc-strings.
3905
3906 2012-01-19 Kenichi Handa <handa@m17n.org>
3907
3908 * character.c (char_width): New function.
3909 (Fchar_width, c_string_width, lisp_string_width):
3910 Use char_width (Bug#9496).
3911
3912 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3913
3914 * window.c (Vwindow_persistent_parameters): New variable.
3915 (Fset_window_configuration, save_window_save): Handle persistent
3916 window parameters.
3917
3918 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3919
3920 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3921 thrashing the stack of the thread. (Bug#9087)
3922
3923 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3924
3925 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3926
3927 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3928
3929 * xdisp.c (rows_from_pos_range): Handle the case where the
3930 highlight ends on a newline. (Bug#10464)
3931 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3932 he end column for display of highlight that ends on a newline
3933 before a R2L line.
3934
3935 2012-01-11 Glenn Morris <rgm@gnu.org>
3936
3937 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3938 from load-path also when installation-directory is nil. (Bug#10208)
3939
3940 2012-01-10 Glenn Morris <rgm@gnu.org>
3941
3942 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3943
3944 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3945 Update template values to be closer to their typical values these days.
3946
3947 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3948
3949 * xdisp.c (rows_from_pos_range): Accept additional argument
3950 DISP_STRING, and accept any glyph in a row whose object is that
3951 string as eligible for mouse highlight. Fixes mouse highlight of
3952 display strings from overlays. (Bug#10464)
3953
3954 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3955
3956 emacs: fix an auto-save permissions race condition (Bug#10400)
3957 * fileio.c (auto_saving_dir_umask): New static var.
3958 (Fmake_directory_internal): Use it.
3959 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3960 creating the directory. The old code temporarily assigns
3961 too-generous permissions to the directory.
3962 (do_auto_save_eh): Clear it.
3963 (Fdo_auto_save): Catch all errors, not just file errors, so
3964 that the var is always cleared.
3965
3966 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3967
3968 * search.c (scan_buffer): Pass character positions to
3969 know_region_cache, not byte positions. (Bug#6540)
3970
3971 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3972
3973 * w32.c (sys_rename): Report EXDEV when rename of a directory
3974 fails because the target is on another logical disk. (Bug#10284)
3975
3976 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3977
3978 * xterm.c (x_embed_request_focus): New function.
3979
3980 * xterm.h: Add prototype.
3981
3982 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3983
3984 2012-01-05 Glenn Morris <rgm@gnu.org>
3985
3986 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3987
3988 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3989
3990 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3991 Load gnutls_transport_set_lowat only if GnuTLS version is below
3992 2.11.1.
3993 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3994 GnuTLS versions below 2.11.1.
3995
3996 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3997
3998 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3999 to the doc string advising against its use for altering the way
4000 windows are scrolled.
4001
4002 2011-12-28 Kenichi Handa <handa@m17n.org>
4003
4004 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4005 coding-system ASCII compatible only when it does not produce BOM
4006 on encoding (Bug#10383).
4007
4008 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4009
4010 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4011 can scroll.
4012 (create_and_show_popup_menu): Always use menu_position_func for
4013 Gtk3 (Bug#10361).
4014
4015 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4016
4017 * callint.c (Fcall_interactively): Don't truncate prompt string.
4018
4019 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4020
4021 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4022 property that ends at ZV, so that the bidi iteration could be
4023 resumed from there (after widening). (Bug#10360)
4024
4025 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4026
4027 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4028
4029 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4030
4031 * nsterm.m (x_free_frame_resources):
4032 Release f->output_data.ns->miniimage.
4033 (ns_index_color): Fix indentation. Do not retain
4034 color_table->colors[i].
4035
4036 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4037 before returning.
4038
4039 * nsfns.m (x_set_background_color): Assign return value from
4040 ns_index_color to face-background instead of NSColor*.
4041 (ns_implicitly_set_icon_type): Fix indentation.
4042 Change assignment in for loop to comparison.
4043
4044 * emacs.c (ns_pool): New variable.
4045 (main): Assign ns_pool.
4046 (Fkill_emacs): Call ns_release_autorelease_pool.
4047
4048 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4049 autorelease fdesc, release fdAttrs and tdict.
4050 (ns_get_covering_families): Release charset.
4051 (ns_findfonts): Release NSFontDescriptor created with new.
4052 (ns_uni_to_glyphs): Fix indentation.
4053 (setString): Release attrStr before assigning new value.
4054
4055 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4056
4057 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4058 and NS_IMPL_COCOA.
4059 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4060 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4061
4062 2011-12-18 David Reitter <reitter@cmu.edu>
4063
4064 * nsterm.m (ns_term_init): Subscribe for notifications
4065 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4066 to method trackingNotification in EmacsMenu.
4067
4068 * nsmenu.m (trackingMenu): New variable.
4069 (trackingNotification): New method (from Aquamacs).
4070 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4071 from Aquamacs (Bug#7030).
4072
4073 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4074
4075 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4076 (symbol_to_nsstring): Fix indentation.
4077 (ns_symbol_to_pb): New function.
4078 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4079 (Fns_rotate_cut_buffers_internal): Remove.
4080 (Fns_store_selection_internal): Rename from
4081 Fns_store_cut_buffer_internal.
4082 (ns_get_foreign_selection, Fx_own_selection_internal)
4083 (Fx_disown_selection_internal, Fx_selection_exists_p)
4084 (Fns_get_selection_internal, Fns_store_selection_internal):
4085 Use ns_symbol_to_pb and check if return value is nil.
4086 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4087 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4088 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4089 renamed to Sns_store_selection_internal.
4090 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4091 and remove this function.
4092 (ns_handle_selection_clear): Remove, never used.
4093 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4094 here.
4095
4096 2011-12-17 Ken Brown <kbrown@cornell.edu>
4097
4098 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4099 GID is unknown (Bug#10257).
4100
4101 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4102
4103 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4104 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4105 which caused a build failure on GNU/Linux IA-64. This problem was
4106 introduced by my 2011-10-07 patch.
4107
4108 2011-12-15 Juri Linkov <juri@jurta.org>
4109
4110 * image.c (imagemagick_error): New function. (Bug#10112)
4111 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4112 Use `imagemagick_error' where ImageMagick functions return
4113 `MagickFalse'.
4114 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4115 proper order.
4116
4117 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4118
4119 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4120 fill background (Bug#8992).
4121
4122 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4123
4124 * window.c (Vwindow_combination_resize)
4125 (Vwindow_combination_limit): Use t instead of non-nil in
4126 doc-strings.
4127 (Vrecenter_redisplay): Add first sentence of doc-string on
4128 separate line.
4129 (Frecenter): Fix doc-string typo.
4130
4131 2011-12-11 Kenichi Handa <handa@m17n.org>
4132
4133 * coding.c (Funencodable_char_position): Pay attention to the
4134 buffer text relocation (Bug#9389).
4135
4136 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4137
4138 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4139 gtk_init (Bug#10100).
4140
4141 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4142
4143 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4144 IT->string is nil. (Bug#10263)
4145
4146 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4147
4148 * nsterm.h (x_free_frame_resources): Declare.
4149
4150 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4151 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4152
4153 * nsterm.h (ns_get_defaults_value): Declare.
4154
4155 * nsterm.m (ns_default): Call ns_get_defaults_value.
4156
4157 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4158
4159 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4160 (Bug#10170)
4161
4162 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4163
4164 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4165 that where the value of an _OBJC_* symbol points to is in the .bss
4166 section (Bug#10240).
4167
4168 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4169
4170 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4171 after the loop to call ccl_driver at least once (Bug#8619).
4172
4173 2011-12-08 Kenichi Handa <handa@m17n.org>
4174
4175 * ftfont.c (get_adstyle_property): Fix previous change
4176 (Bug#10233).
4177
4178 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4179
4180 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4181 dirs from the default value of EMACSLOADPATH (bug#10208).
4182
4183 2011-12-07 Glenn Morris <rgm@gnu.org>
4184
4185 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4186 installation and source directories as well. (Bug#10208)
4187
4188 2011-12-06 Chong Yidong <cyd@gnu.org>
4189
4190 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4191
4192 2011-12-06 Glenn Morris <rgm@gnu.org>
4193
4194 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4195 as an error, not just -1. (Bug#10217)
4196
4197 2011-12-05 Chong Yidong <cyd@gnu.org>
4198
4199 * keyboard.c (process_special_events): New function.
4200 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4201
4202 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4203
4204 * coding.c (encode_designation_at_bol): Don't use uninitialized
4205 local variable (Bug#9318).
4206
4207 2011-12-05 Kenichi Handa <handa@m17n.org>
4208
4209 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4210 return Qnil (Bug#8046, Bug#10193).
4211
4212 2011-12-05 Kenichi Handa <handa@m17n.org>
4213
4214 * coding.c (encode_designation_at_bol): New args charbuf_end and
4215 dst. Return the number of produced bytes. Callers changed.
4216 (coding_set_source): Return how many bytes coding->source was
4217 relocated.
4218 (coding_set_destination): Return how many bytes
4219 coding->destination was relocated.
4220 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4221 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4222
4223 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4224
4225 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4226 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4227 macro (Bug#9318).
4228
4229 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4230
4231 The following changes are to fix Bug#9318.
4232
4233 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4234 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4235 (encode_coding_iso_2022, encode_coding_sjis)
4236 (encode_coding_big5, encode_coding_charset): Use the above macros.
4237
4238 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * lisp.h (process_quit_flag): Fix external declaration.
4241
4242 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4243
4244 Don't macro-inline non-performance-critical code.
4245 * eval.c (process_quit_flag): New function.
4246 * lisp.h (QUIT): Use it.
4247
4248 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4249
4250 * nsfns.m (get_geometry_from_preferences): New function.
4251 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4252
4253 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4254
4255 * emacs.c (Qkill_emacs): Define.
4256 (syms_of_emacs): Initialize it.
4257 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4258 Qquit_flag to `kill-emacs' instead.
4259 (quit_throw_to_read_char): Add parameter `from_signal'.
4260 All callers changed. Call Fkill_emacs if requested and safe.
4261 * lisp.h (QUIT): Call Fkill_emacs if requested.
4262
4263 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4264
4265 * widget.c (update_wm_hints): Return if wmshell is null.
4266 (widget_update_wm_size_hints): New function.
4267
4268 * widget.h (widget_update_wm_size_hints): Declare.
4269
4270 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4271 widget_update_wm_size_hints (Bug#10104).
4272
4273 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4274
4275 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4276 before a newline, prepare the bidi iterator for consuming the
4277 newline, and keep the current paragraph direction. (Bug#10183)
4278 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4279
4280 2011-12-02 Juri Linkov <juri@jurta.org>
4281
4282 * search.c (Fword_search_regexp): New Lisp function created from
4283 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4284 (Fword_search_backward, Fword_search_forward)
4285 (Fword_search_backward_lax, Fword_search_forward_lax):
4286 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4287 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4288
4289 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4290
4291 * fileio.c (Finsert_file_contents): Move after-change-function call
4292 to before the "handled:" label, since all "goto handled" appear in
4293 cases where the *-change-functions have already been properly called
4294 (bug#10117).
4295
4296 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4297
4298 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4299 waiting for input. (Bug#10169)
4300
4301 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4302
4303 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4304 verifies glyph row's hash code--we have just reallocated the
4305 glyphs, so their contents can be complete garbage. (Bug#10164)
4306
4307 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4308
4309 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4310
4311 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4312
4313 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4314 attributes are tested _before_ calling verify_row_hash, to protect
4315 against GCC re-ordering of the tests. (Bug#10164)
4316
4317 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4318
4319 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4320
4321 * xterm.c (handle_one_xevent): Only set async_visible and friends
4322 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4323 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4324 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4325
4326 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4329 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4330 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4331 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4332 All uses changed to use GCPRO1 etc.
4333 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4334 Revert to old implementation (i.e., before 2011-03-11).
4335
4336 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4337
4338 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4339 of scroll runs so as to avoid assigning disabled bogus rows and
4340 unnecessary graphics copy operations.
4341
4342 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4343
4344 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4345 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4346 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4347 (malloc, free, realloc, calloc): Redirect to e_* only when
4348 compiling Emacs.
4349
4350 * lisp.h (GCTYPEBITS): Move before first use.
4351 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4352 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4353 this macro definition.
4354
4355 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4356 _MSC_VER.
4357
4358 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4359
4360 * gtkutil.c (xg_create_frame_widgets):
4361 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4362 present with Gtk+ 2.0.
4363
4364 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4365
4366 * fileio.c (Finsert_file_contents): Undo previous change; see
4367 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4368
4369 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 Rename locals to avoid shadowing.
4372 * fileio.c (Finsert_file_contents):
4373 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4374 * process.c (wait_reading_process_output):
4375 Rename inner 'proc' to 'p' to avoid shadowing.
4376 Indent for consistency with usual Emacs style.
4377
4378 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4379
4380 * xdisp.c (redisplay_window): If cursor row is not fully visible
4381 after recentering, and scroll-conservatively is set to a large
4382 number, scroll window by a few more lines to make the cursor fully
4383 visible and out of scroll-margin. (Bug#10105)
4384 (start_display): Don't move to the next line if the display should
4385 start at a newline that is part of a display vector or an overlay
4386 string. (Bug#10119)
4387
4388 2011-11-24 Juri Linkov <juri@jurta.org>
4389
4390 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4391 after the `MagickPingImage' call. (Bug#10112)
4392
4393 2011-11-23 Chong Yidong <cyd@gnu.org>
4394
4395 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4396
4397 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4398
4399 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4400 making another buffer current. (Bug#10114)
4401
4402 2011-11-23 Glenn Morris <rgm@gnu.org>
4403
4404 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4405
4406 2011-11-23 Chong Yidong <cyd@gnu.org>
4407
4408 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4409 using it (Bug#5984).
4410
4411 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4412
4413 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4414 and header-lines, as they don't have one computed for them.
4415 (Bug#10098)
4416
4417 * .gdbinit (prow): Make displayed values more self-explaining.
4418 Add row's hash code.
4419
4420 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4421
4422 * process.c (wait_reading_process_output): Fix asynchrounous
4423 GnuTLS socket handling on some versions of the GnuTLS library.
4424 (wait_reading_process_output): Add comment and URL.
4425
4426 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4427
4428 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4429
4430 2011-11-21 Chong Yidong <cyd@gnu.org>
4431
4432 * window.c (Fnext_window, Fprevious_window): Doc fix.
4433
4434 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4435
4436 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4437
4438 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4441
4442 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4443
4444 * window.c (Fset_window_combination_limit): Rename argument
4445 STATUS to LIMIT.
4446 (Vwindow_combination_limit): Remove "status" from doc-string.
4447
4448 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4449
4450 * m/ibms390.h: Remove.
4451 * m/ibms390x.h: Don't include "ibms390.h".
4452
4453 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4454
4455 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4456 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4457
4458 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4459
4460 * casetab.c (Fset_case_table):
4461 * charset.c (Fcharset_after): Fix typos.
4462
4463 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4466 Otherwise, valgrind does not work on some platforms.
4467 Problem reported by Andreas Schwab in
4468 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4469 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4470 is set, removing the need for VIRT_ADDRESS_VARIES.
4471 (PURE_P): Use a more-efficient implementation that needs just one
4472 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4473 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4474 to 4 (xorl, subq, cmpq, setbe).
4475 * alloc.c (pure): Always extern now, since that's the
4476 VIRT_ADDR_VARIES behavior.
4477 (PURE_POINTER_P): Use a single comparison, not two, for
4478 consistency with the new puresize.h.
4479 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4480 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4481 Remove VIRT_ADDR_VARIES no longer needed.
4482
4483 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4484
4485 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4486 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4487 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4488 behave as if the cursor position were at the window margin.
4489
4490 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4491 and the cursor position is out of bounds, behave as if the cursor
4492 position were at the window margin. (Bug#10075)
4493
4494 2011-11-18 Chong Yidong <cyd@gnu.org>
4495
4496 * window.c (Fwindow_combination_limit): Make first argument
4497 non-optional, since it is meaningless for live windows like the
4498 selected window.
4499
4500 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4501
4502 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4503
4504 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4505
4506 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4507 (graft_intervals_into_buffer): Simplify.
4508
4509 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4510
4511 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4512 hash values of the two rows.
4513 (copy_row_except_pointers): Preserve the used[] arrays and the
4514 hash values of the two rows. (Bug#10035)
4515 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4516
4517 * xdisp.c (row_hash): New function, body extracted from
4518 compute_line_metrics.
4519 (compute_line_metrics): Call row_hash, instead of computing the
4520 hash code inline.
4521
4522 * dispnew.c (verify_row_hash): Call row_hash for computing the
4523 hash code of a row, instead of duplicating code from xdisp.c.
4524
4525 * dispextern.h (row_hash): Add prototype.
4526
4527 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4528
4529 * frame.c (delete_frame): Don't delete the terminal when the last
4530 X frame is closed if emacs is built with GTK toolkit.
4531
4532 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4533
4534 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4535
4536 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4537
4538 * window.c (Vwindow_splits): Rename to
4539 Vwindow_combination_resize. Suggested by Juri Linkov.
4540 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4541 of Vwindow_splits.
4542
4543 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4544
4545 * nsfns.m (Fns_font_name):
4546 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4547
4548 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4549
4550 * window.h (window): Rename slot "nest" to "combination_limit".
4551 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4552 (Fset_window_nest): Rename to Fset_window_combination_limit.
4553 (Vwindow_nest): Rename to Vwindow_combination_limit.
4554 (recombine_windows, make_parent_window, make_window)
4555 (Fsplit_window_internal, saved_window)
4556 (Fset_window_configuration, save_window_save): Rename all
4557 occurrences of window_nest to window_combination_limit.
4558
4559 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4560
4561 * image.c (imagemagick_load_image): Fix typo.
4562
4563 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4564
4565 * xdisp.c (display_line): Move the call to
4566 highlight_trailing_whitespace before the call to
4567 compute_line_metrics, since the latter needs to see the final
4568 faces of all the glyphs to compute ROW's hash value.
4569 Fixes assertion violations in row_equal_p. (Bug#10035)
4570
4571 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4572
4573 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4574 just return (bug#10044).
4575
4576 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4577
4578 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4579 with user-defined heap size. Bump the default size of the temacs
4580 heap to 27MB, to avoid memory warning when running temacs.
4581 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4582
4583 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4584 current_matrix and desired_matrix. (Bug#9990)
4585 (verify_row_hash) [XASSERTS]: New function.
4586 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4587 that the hash value of glyph rows is correct.
4588
4589 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4590
4591 * window.h (window): Remove splits slot.
4592 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4593 (Fdelete_other_windows_internal, make_parent_window)
4594 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4595 (Fset_window_configuration, save_window_save): Don't deal with
4596 split status of windows.
4597 (saved_window): Remove splits slot.
4598 (Vwindow_splits): Rewrite doc-string.
4599
4600 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4601
4602 * xfns.c (unwind_create_frame):
4603 * nsfns.m (unwind_create_frame):
4604 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4605 Vframe_list (Bug#9999).
4606
4607 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4608
4609 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4610
4611 2011-11-11 Kenichi Handa <handa@m17n.org>
4612
4613 * callproc.c (Fcall_process): Set the member dst_multibyte of
4614 process_coding.
4615
4616 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4617
4618 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4619 avoid a crash (bug#9496).
4620
4621 2011-11-09 Chong Yidong <cyd@gnu.org>
4622
4623 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4624 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4625
4626 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4627
4628 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4629
4630 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4631
4632 Avoid some portability problems by eschewing 'extern inline' functions.
4633 The trivial performance wins aren't worth the portability hassles; see
4634 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4635 et seq.
4636 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4637 (window_box_width, window_box_left, window_box_left_offset)
4638 (window_box_right, window_box_right_offset): Undo previous change,
4639 by removing the "extern"s.
4640 * intervals.c (adjust_intervals_for_insertion)
4641 (adjust_intervals_for_deletion): Undo previous change,
4642 making these static again.
4643 (offset_intervals, temp_set_point_both, temp_set_point)
4644 (copy_intervals_to_string): No longer inline.
4645 * xdisp.c (window_text_bottom_y, window_box_width)
4646 (window_box_height, window_box_left_offset)
4647 (window_box_right_offset, window_box_left, window_box_right)
4648 (window_box): No longer inline.
4649
4650 2011-11-08 Chong Yidong <cyd@gnu.org>
4651
4652 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4653 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4654 Signal an error if not a live window.
4655 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4656 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4657
4658 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4659
4660 * lisp.h (syms_of_abbrev): Remove declaration.
4661 Reported by CHENG Gao <chenggao@royau.me>.
4662
4663 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4664
4665 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4666 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4667 of temacs in GUI mode.
4668
4669 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4670
4671 * window.h: Declare delete_all_child_windows instead of
4672 delete_all_subwindows.
4673 * window.c (Fwindow_nest, Fset_window_nest)
4674 (Fset_window_new_total, Fset_window_new_normal)
4675 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4676 (delete_all_subwindows): Rename to delete_all_child_windows.
4677 (Fdelete_other_windows_internal, Fset_window_configuration):
4678 Call delete_all_child_windows instead of delete_all_subwindows.
4679 * frame.c (delete_frame): Call delete_all_child_windows instead
4680 of delete_all_subwindows.
4681
4682 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4683
4684 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4685 This is also needed for porting to any host where GC_MARK_STACK is
4686 not GC_MAKE_GCPROS_NOOPS.
4687 (which_symbols): Use it.
4688
4689 2011-11-07 Kenichi Handa <handa@m17n.org>
4690
4691 * coding.c (coding_set_destination): Check coding->src_pos only
4692 when coding->src_object is a buffer (bug#9910).
4693
4694 * process.c (send_process): Set the member src_multibyte of coding
4695 to 0 (bug#9911) when sending a unibyte text.
4696
4697 * callproc.c (Fcall_process): Set the member src_multibyte of
4698 process_coding to 0 (bug#9912).
4699
4700 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4701
4702 * xmenu.c (cleanup_widget_value_tree): New function.
4703 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4704 calling free_menubar_widget_value_tree directly (Bug#9830).
4705
4706 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4707
4708 Fix some portability problems with 'inline'.
4709 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4710 (window_box_width, window_box_left, window_box_left_offset)
4711 (window_box_right, window_box_right_offset): Declare extern.
4712 Otherwise, these inline functions do not conform to C99 and
4713 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4714 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4715 * intervals.c (adjust_intervals_for_insertion)
4716 (adjust_intervals_for_deletion): Now extern, because otherwise the
4717 extern inline functions 'offset_intervals' couldn't refer to it.
4718 (static_offset_intervals): Remove.
4719 (offset_intervals): Rewrite using the old contents of
4720 static_offset_intervals. The old version didn't conform to C99
4721 because an extern inline function contained a reference to an
4722 identifier with static linkage.
4723
4724 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4725
4726 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4727 GC.
4728
4729 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4730
4731 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4732 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4733 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4734 return Qleft_to_right.
4735
4736 2011-11-06 Chong Yidong <cyd@gnu.org>
4737
4738 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4739 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4740 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4741 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4742 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4743 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4744 (Fwindow_vscroll): Doc fix.
4745 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4746 argument, since it makes no sense to pass a live window and for
4747 consistency with window-child.
4748
4749 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4750
4751 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4752 support MSVC.
4753
4754 2011-11-05 Jason Rumney <jasonr@gnu.org>
4755
4756 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4757 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4758 fonts (Bug#6029).
4759 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4760 bitwise arithmetic preventing use of unicode-sip and non-truetype
4761 opentype fonts.
4762
4763 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4764
4765 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4766 "emacs"-only part.
4767
4768 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4769 initialization code to keep similarity to xfns.c after changes
4770 from 2011-11-05.
4771
4772 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4773
4774 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4775 (unwind_create_frame): New function (Bug#9943).
4776 (Fx_create_frame): Restructure code to be more similar to the one in
4777 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4778 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4779 Move terminal->reference_count++ just before making the frame official
4780 (Bug#9943).
4781
4782 * nsterm.m (x_free_frame_resources): New function.
4783 (x_destroy_window): Move code to x_free_frame_resources.
4784
4785 * xfns.c (unwind_create_frame): Fix comment.
4786 (Fx_create_frame, x_create_tip_frame):
4787 Move terminal->reference_count++ just before making the frame
4788 official. Move initialization of image_cache_refcount and
4789 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4790
4791 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4792
4793 Support MSVC build with newer versions of Visual Studio.
4794 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4795 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4796 nt/gmake.defs.
4797
4798 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4799 which are not supported by MSVC.
4800 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4801 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4802 bitfields.
4803 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4804 types in bitfields.
4805 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4806
4807 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4808
4809 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4810
4811 Support MSVC build with newer versions of Visual Studio.
4812 * w32.c: Don't include w32api.h for MSVC.
4813 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4814
4815 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4816 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4817 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4818 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4819 e_* cousins.
4820 (alloca) [_MSC_VER]: Define to _alloca.
4821
4822 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4823
4824 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4825
4826 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4827
4828 * xdisp.c (note_mouse_highlight): If either of
4829 previous/next-single-property-change returns nil, treat that as
4830 the beginning or the end of the buffer. (Bug#9955)
4831
4832 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4833
4834 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4835 label is not null (Bug#9951).
4836 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4837 may be NULL.
4838
4839 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4840
4841 * window.c (Fwindow_body_size): Mention in the doc string that the
4842 return value is in frame's canonical units. (Bug#9949)
4843
4844 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4845
4846 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4847
4848 * w32fns.c (unwind_create_frame): If needed, free the glyph
4849 matrices of the partially constructed frame. (Bug#9943)
4850 * xfns.c (unwind_create_frame): Likewise.
4851
4852 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4853
4854 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4855 Don't stop backward scan on the continuation glyph, even though
4856 its CHARPOS is positive.
4857 (mouse_face_from_buffer_pos, note_mouse_highlight):
4858 Rename cover_string to disp_string.
4859
4860 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4861
4862 * window.c (temp_output_buffer_show): Don't use
4863 Vtemp_buffer_show_specifiers.
4864 (Vtemp_buffer_show_specifiers): Remove unused variable.
4865
4866 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4867
4868 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4869 past the beginning of the current glyph matrix.
4870
4871 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4872
4873 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4874 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4875 HAVE_GTK3 (Bug#9869).
4876
4877 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4878 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4879
4880 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4881
4882 * xterm.c: Declare x_handle_net_wm_state to return int.
4883 (handle_one_xevent): Check if we are iconified but don't have
4884 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4885 (get_current_wm_state): Return non-zero if not hidden,
4886 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4887 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4888 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4889 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4890
4891 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4894 so that this new function doesn't get optimized away by a
4895 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4896
4897 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4898
4899 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4900
4901 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4902
4903 Fix the `xbytecode' command.
4904 * .gdbinit (xprintbytestr): New command.
4905 (xwhichsymbols): Rename from `which'; all callers changed.
4906 (xbytecode): Print the byte-code string as well.
4907
4908 2011-10-29 Kim Storm <storm@cua.dk>
4909
4910 * alloc.c (which_symbols): New function.
4911
4912 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4913
4914 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4915 line. (Bug#9903)
4916
4917 2011-10-29 Glenn Morris <rgm@gnu.org>
4918
4919 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4920 Not clear what it was for, and it causes various bugs. (Bug#9839)
4921
4922 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4923
4924 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4925 possible random value that matches one of those tested as
4926 condition to clear the mouse face.
4927
4928 2011-10-28 Chong Yidong <cyd@gnu.org>
4929
4930 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4931
4932 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4933
4934 * window.c (make_window): Initialize phys_cursor_on_p.
4935
4936 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4937
4938 * lisp.h (struct Lisp_Symbol): Update comments.
4939
4940 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4943
4944 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4945
4946 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4947 <oslsachem@gmail.com> for helping to debug this.
4948
4949 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4950 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4951 (g_b_init_get_glyph_outline_w): New static variables.
4952 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4953 (GetGlyphOutlineW_Proc): New typedefs.
4954 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4955 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4956 New functions.
4957 (w32font_open_internal, compute_metrics):
4958 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4959 instead of calling the "wide" APIs directly.
4960
4961 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4962
4963 * w32.h (syms_of_w32font): Add prototype.
4964
4965 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4966
4967 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4968 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4969 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4970 (Fmove_to_window_line): Doc fix.
4971
4972 2011-10-27 Chong Yidong <cyd@gnu.org>
4973
4974 * process.c (make_process): Set gnutls_state to NULL.
4975
4976 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4977 non-NULL, regardless of GNUTLS_INITSTAGE.
4978 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4979 an error. Set process slots as soon as we allocate them.
4980
4981 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4982
4983 2011-10-27 Chong Yidong <cyd@gnu.org>
4984
4985 * gnutls.c (emacs_gnutls_deinit): New function.
4986 Deallocate credentials structures as well as calling gnutls_deinit.
4987 (Fgnutls_deinit, Fgnutls_boot): Use it.
4988
4989 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4990 (deactivate_process): Call emacs_gnutls_deinit.
4991
4992 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4993
4994 * image.c (x_create_x_image_and_pixmap):
4995 * w32.c (sys_rename, w32_delayed_load):
4996 * w32font.c (fill_in_logfont):
4997 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4998
4999 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5000
5001 * w32fns.c (w32_default_color_map): New function,
5002 extracted from Fw32_default_color_map.
5003 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5004
5005 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5008
5009 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5010
5011 * keyboard.c (test_undefined): New function (bug#9751).
5012 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5013
5014 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5015
5016 * sysdep.c (init_sys_modes): Fix the check for the controlling
5017 terminal (Bug#6649).
5018
5019 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5020
5021 * dispextern.h (struct bidi_it): New member next_en_type.
5022
5023 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5024 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5025 current character, check also for next_en_type being WEAK_EN.
5026 (bidi_resolve_weak): Don't enter the expensive loop if the current
5027 position is before next_en_pos. Record the bidi type of the first
5028 non-ET, non-BN character we find, in addition to its position.
5029 (bidi_level_of_next_char): Invalidate next_en_type when
5030 next_en_pos is over-stepped.
5031
5032 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5035 * editfns.c: Rewrite current-time-zone so that it invokes
5036 the equivalent of (format-time-string "%Z") to get the time zone name.
5037 This fixes a bug when the time zone name contains characters that
5038 need converting from the system time locale to Emacs internal format.
5039 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5040 that patch fixed format-time-string to do the conversion, but
5041 I forgot to fix current-time-zone.
5042 (format_time_string): New function, containing most of
5043 what Fformat_time_string used to contain.
5044 (Fformat_time_string): Rewrite in terms of format_time_string.
5045 This doesn't change this function's behavior.
5046 (current-time-zone): Rewrite to use format_time_string.
5047 This fixes the bug reported by Michael Schierl in
5048 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5049 Jason Rumney's 2007-06-07 change worked around this bug, but
5050 didn't fix it.
5051 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5052
5053 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5054
5055 * xdisp.c (start_display): If the character at POS is displayed
5056 via a display vector, reset IT->current.dpvec_index to zero.
5057 (try_window_reusing_current_matrix): If a line ends in a display
5058 vector or the next line starts in a display vector, continue
5059 redrawing the window even though the character position of
5060 start_row was reached.
5061 (Bug#9771, part 2)
5062
5063 2011-10-18 Chong Yidong <cyd@gnu.org>
5064
5065 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5066 with nobreak-char-display too.
5067
5068 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5069
5070 Fix part 3 of bug#9771.
5071 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5072 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5073 non-neutral characters if the current character is a paragraph
5074 separator (a.k.a. Newline). This avoids running the same
5075 expensive loop twice, once when we consume the preceding newline
5076 and the other time when the line actually needs to be displayed.
5077 Avoid the loop when we see neutrals on the base embedding level
5078 following a character whose directionality is the same as the
5079 paragraph's. This avoids running the expensive loop when a line
5080 ends in a long sequence of neutrals, like control characters.
5081 Add assertion against STRONG_AL type. Slightly rearrange code
5082 that determines the type of a neutral given the first non-neutral
5083 that follows it.
5084 (bidi_level_of_next_char): Set next_en_pos to zero when
5085 invalidating its info.
5086
5087 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5088
5089 * xdisp.c (push_display_prop): Determine whether to record string
5090 or buffer position by IT->string, not by IT->method. Allow
5091 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5092 (move_it_vertically_backward): Don't look for character position
5093 immediately after the newline when in a continuation line.
5094 (Bug#9771, part 1)
5095
5096 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5097
5098 * window.c (coordinates_in_window): Rewrite and delabelize
5099 vertical border check. (Bug#5357) (Bug#9618)
5100
5101 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5102
5103 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5104 errors in XSetWindowBorder (bug#9310).
5105
5106 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5107
5108 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5109 avoid crash when xmalloc overrun checking is enabled.
5110
5111 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5112
5113 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5114 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5115 cursor motion with <left> and <right> arrow keys.
5116
5117 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5118 some callers set that themselves.
5119
5120 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5121
5122 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5123 display string and the previous row comes from the same string and
5124 is empty. (Bug#9739) (Bug#9738)
5125
5126 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5127
5128 * doc.c (get_doc_string): Encode file name (bug#9735).
5129
5130 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5131
5132 * bidi.c (bidi_level_of_next_char):
5133 * xdisp.c (get_visually_first_element): Remove old incorrect
5134 comments regarding the Unicode Line Separator character.
5135
5136 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5137
5138 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5139
5140 * alloc.c (Fgc_status): Do not access beyond zombies array
5141 boundary if nzombies > MAX_ZOMBIES.
5142 * alloc.c (dump_zombies): Add missing format specifier.
5143
5144 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5145
5146 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5147 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5148
5149 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5150 Some packages use them to denote characters with modifiers.
5151
5152 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5153
5154 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5155 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5156 matching a pp-number. Rename parameter var to var1.
5157
5158 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5159
5160 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5161
5162 2011-10-08 Glenn Morris <rgm@gnu.org>
5163
5164 * callint.c (Fcall_interactively): Give a more explicit error for the
5165 'c' case with a non-character input. (Bug#8479)
5166
5167 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5168
5169 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5170 lines.
5171 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5172 lines that are hscrolled on the left.
5173
5174 * dispnew.c (buffer_posn_from_coords): Account for a possible
5175 presence of header-line. (Bug#4426)
5176
5177 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5178
5179 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5180 Don't advertise functionality which we discourage or doesn't work.
5181
5182 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5183
5184 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5185 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5186 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5187 this makes Emacs dump core during garbage collection on rare
5188 occasions. sizeof is obviously inferior to offsetof here, so
5189 stick with offsetof.
5190 (GC_POINTER_ALIGNMENT): New macro.
5191 (mark_memory): Omit 3rd (offset) arg; caller changed.
5192 Don't assume EMACS_INT alignment is the same as pointer alignment.
5193
5194 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5195
5196 * keyboard.c (read_key_sequence_remapped): New var.
5197 (read_key_sequence): Compute remapping in the right buffer.
5198 (command_loop_1): Use read_key_sequence's remapping directly.
5199
5200 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5201
5202 * dired.c (file_name_completion): Don't expand file name.
5203 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5204 before checking file name handler.
5205
5206 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5207 they've been requested explicitly (bug#9591).
5208
5209 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5210
5211 * keymap.c (Fsingle_key_description): Use make_specified_string
5212 instead of build_string to build string from push_key_description.
5213 (Bug#5193)
5214
5215 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5218 This fixes a Y2038 bug on 64-bit hosts.
5219 * buffer.c (reset_buffer):
5220 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5221 (Fclear_buffer_auto_save_failure):
5222 Use 0, not -1, to represent an unset failure time, since time_t
5223 might not be signed.
5224
5225 Remove dependency on glibc malloc internals.
5226 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5227 Move back here from lisp.h, but with their new implementations.
5228 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5229 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5230 * charset.c (charset_table_init): New static var.
5231 (syms_of_charset): Use it instead of xmalloc. This removes a
5232 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5233 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5234 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5235 Move back to alloc.c.
5236 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5237 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5238
5239 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5240
5241 * nsterm.m (windowDidResize): Call x_set_window_size only when
5242 ns_in_resize is true. Otherwise set pixelwidth/height and
5243 call change_frame_size (Bug#9628).
5244
5245 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 Port --enable-checking=all to Fedora 14 x86-64.
5248 * charset.c (syms_of_charset): Also account for glibc malloc's
5249 internal overhead when calculating the initial malloc maximum.
5250
5251 Port --enable-checking=all to Fedora 14 x86.
5252 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5253 Move to lisp.h.
5254 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5255 (overrun_check_realloc, overrun_check_free):
5256 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5257 That way, xmalloc returns a properly-aligned pointer even if
5258 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5259 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5260 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5261 into account when calculating the initial malloc maximum.
5262 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5263 Move here from alloc.c, so that charset.c can use it too.
5264 Properly align; the old code wasn't right for common 32-bit hosts
5265 when configured with --enable-checking=all.
5266 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5267 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5268
5269 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5270
5271 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5272 use EDOM.
5273
5274 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5275
5276 * xdisp.c (compute_display_string_end): If there's no display
5277 string at CHARPOS, return -1.
5278
5279 * bidi.c (bidi_fetch_char): When compute_display_string_end
5280 returns a negative value, treat the character as a normal
5281 character not covered by a display string. (Bug#9624)
5282
5283 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5284
5285 * lread.c (Fread_from_string): Fix typo in docstring.
5286
5287 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5290 newline, reseat the iterator instead of bidi-iterating there one
5291 character at a time. (Bug#9610)
5292 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5293 TO_CHARPOS if the bidi iterator is at base embedding level.
5294
5295 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5296
5297 * lread.c (readevalloop): Use correct code for NBSP.
5298 (read1): Likewise. (Bug#9608)
5299
5300 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5301
5302 * dbusbind.c (Fdbus_register_signal): When service is not
5303 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5304
5305 2011-09-25 Glenn Morris <rgm@gnu.org>
5306
5307 * buffer.c (truncate-lines): Doc fix.
5308
5309 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5310
5311 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5312 (Fset_window_next_buffers): Doc fix.
5313
5314 2011-09-24 Glenn Morris <rgm@gnu.org>
5315
5316 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5317
5318 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5319
5320 Fix minor problems found by static checking.
5321 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5322 * indent.c (Fvertical_motion): Fix == vs = typo.
5323
5324 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5325
5326 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5327 Default value is now t. Doc fix.
5328
5329 * indent.c (Fvertical_motion): Compute and apply the overshoot
5330 logic when moving up, not only when moving down. Fix the
5331 confusing name and values of the it_overshoot_expected variable;
5332 logic changes accordingly. (Bug#9254) (Bug#9549)
5333
5334 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5335 CHARPOS is covered by a display string which includes newlines.
5336 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5337 is covered by a display string with embedded newlines.
5338
5339 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5340
5341 * dbusbind.c (Fdbus_register_signal): Add match rule to
5342 Vdbus_registered_objects_table. (Bug#9581)
5343 (Fdbus_register_method, Vdbus_registered_objects_table):
5344 Fix docstring.
5345
5346 2011-09-24 Jim Meyering <meyering@redhat.com>
5347
5348 do not ignore write error for any output size
5349 The previous change was incomplete.
5350 While it makes emacs --batch detect the vast majority of stdout
5351 write failures, errors were still ignored whenever the output size is
5352 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5353 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5354 && echo FAIL: ignored write error
5355 FAIL: ignored write error
5356 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5357 && echo FAIL: ignored write error
5358 FAIL: ignored write error
5359 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5360
5361 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5362
5363 * emacs.c (Fkill_emacs): In noninteractive mode exit
5364 non-successfully if a write error occurred on stdout. (Bug#9574)
5365
5366 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5367
5368 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5369 the xassert test.
5370
5371 * dispextern.h (struct it): Update the comment documenting what
5372 can it->OBJECT be.
5373
5374 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5375
5376 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5377 a display string, extend search for cursor position to end of row.
5378 (find_row_edges): If the row ends in a newline from a display
5379 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5380 Handle the case of a display string with multiple newlines.
5381 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5382 non-empty line. Fixes confusing cursor motion with arrow keys at
5383 the beginning of a line that starts with whitespace.
5384
5385 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5386
5387 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5388 (bug#9493).
5389
5390 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5391
5392 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5393 boolean (Bug#9154).
5394
5395 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5396
5397 * xdisp.c (display_line): Record maximum and minimum buffer
5398 positions even if no glyphs were produced (e.g., by a zero-width
5399 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5400 buffer positions that will be removed from the glyph row because
5401 they don't fit.
5402 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5403 column is beyond frame width: don't subtract 1 "pixel" when
5404 computing width of the stretch.
5405 (reseat_at_next_visible_line_start): Undo the change made on
5406 2011-09-17 that saved paragraph information and restored it after
5407 the call to `reseat'. (Bug#9545)
5408
5409 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5410
5411 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5412 and turn window cursor on if cleared (Bug#9415).
5413
5414 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5415
5416 * search.c (boyer_moore): Take unibyte characters from pattern
5417 literally. (Bug#9458)
5418
5419 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5420
5421 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5422
5423 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5424
5425 Fix minor problem found by static checking.
5426 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5427 initialized, to pacify gcc -Wuninitialized.
5428
5429 * fileio.c: Report proper errno when syscall falls.
5430 (Finsert_file_contents): Save and restore errno,
5431 so that report_file_error outputs the correct diagnostic.
5432 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5433
5434 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5435
5436 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5437
5438 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5439
5440 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5441 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5442
5443 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5444
5445 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5446 about the current paragraph and restore it after the call to reseat.
5447
5448 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5449 (bidi_find_paragraph_start): Search back for paragraph beginning
5450 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5451 (bidi_move_to_visually_next): Only trigger paragraph-related
5452 computations when the last character is a newline or at EOB, not
5453 just any NEUTRAL_B. (Bug#9470)
5454
5455 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5456 truncated lines if point is covered by a display string. (Bug#9524)
5457
5458 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5459
5460 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5461 (cons_to_x_long): New function.
5462 (lisp_data_to_selection_data): Use it. Correct the test for
5463 short-versus-long data; it was negated. Break out of vector
5464 loop, for efficiency, when a long datum is discovered.
5465
5466 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5467
5468 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5469
5470 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5471
5472 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5473 GCC PR/17406) by declaring this function with external scope.
5474
5475 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5478 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5479
5480 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5481
5482 * editfns.c (Fformat): Correctly handle text properties on "%%".
5483
5484 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5485
5486 * xterm.c (x_draw_composite_glyph_string_foreground):
5487 * w32term.c (x_draw_composite_glyph_string_foreground):
5488 * term.c (encode_terminal_code):
5489 * composite.c (composition_update_it, get_composition_id):
5490 * xdisp.c (get_next_display_element)
5491 (fill_composite_glyph_string): Add comments about special meaning
5492 of TAB characters in a composition.
5493
5494 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5495
5496 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5497 This occurs when processing a multibyte format.
5498 Problem reported by Wolfgang Jenker.
5499
5500 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5501
5502 * xdisp.c (try_cursor_movement): Only check for exact match if
5503 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5504
5505 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 Remove unused external symbols.
5508 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5509 * xdisp.c (calc_pixel_width_or_height): Now static.
5510 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5511 * indent.c (check_display_width):
5512 * w32term.c: Fix comment to match code.
5513 * xterm.c, xterm.h (x_catching_errors): Remove.
5514
5515 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5516
5517 * xselect.c: Use signed conversions more consistently (Bug#9498).
5518 (selection_data_to_lisp_data): Assume incoming selection data are
5519 signed integers, not unsigned. This is to be consistent with
5520 outgoing selection data, which was modified to use signed integers
5521 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5522 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5523 expects long, not unsigned long.
5524
5525 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5526
5527 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5528 computation of loop end. Reported by Johan Bockgård
5529 <bojohan@gnu.org>.
5530
5531 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5532
5533 * frame.c (Fother_visible_frames_p): Function deleted.
5534
5535 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5536
5537 * indent.c (compute_motion): Process display vector front to back
5538 rather than the other way around. (Bug#2496)
5539
5540 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5541
5542 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5543
5544 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5545
5546 * minibuf.c (Fread_from_minibuffer): Doc fix.
5547
5548 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5549
5550 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5551 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5552
5553 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5554
5555 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5556 value for non-existent files.
5557
5558 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5559
5560 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5561 set its "size" to -1. This will set the modtime_size field of
5562 the corresponding buffer to -1, which is what
5563 verify-visited-file-modtime expects for files that do not exist.
5564 (Bug#9139)
5565
5566 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5567
5568 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5569 here ...
5570 * lisp.h: ... from here. push_key_description is no longer
5571 defined in keyboard.c, so its declaration should not be in
5572 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5573 logically belongs with push_key_description.
5574
5575 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5576
5577 * buffer.h: Include <sys/types.h> instead of <time.h>.
5578 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5579 Problem reported by Herbert J. Skuhra.
5580
5581 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5582
5583 * xml.c (parse_region): Make the parsing work for
5584 non-comment-starting XML files again (bug#9144).
5585
5586 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5587
5588 * image.c (gif_load): Fix calculation of bottom and right corner.
5589 (Bug#9468)
5590
5591 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5592
5593 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5594 redisplay in small windows.
5595
5596 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5597
5598 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5599
5600 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5601
5602 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5603 Operate on live windows only.
5604
5605 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5606
5607 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5608
5609 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5610
5611 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5612 only under bidi iteration.
5613
5614 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5615
5616 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5617
5618 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5619
5620 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5621 Without this fix, the command to link temacs failed due to an
5622 undefined symbol __builtin_isnan. This is because
5623 /usr/include/iso/math_c99.h #defines isnan(x) to
5624 __builtin_isnan(x), but the bundled gcc, which identifies itself
5625 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5626 a __builtin_isnan.
5627 * floatfns.c (isnan): #undef, and then #define to a clone of
5628 what's in data.c.
5629 (Fisnan): Always define, since it's always available now.
5630 (syms_of_floatfns): Always define isnan at the Lisp level.
5631
5632 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5633
5634 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5635
5636 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5637
5638 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5639 The previous code assumed that file offsets (off_t values) fit in
5640 EMACS_INT variables, which is not true on typical 32-bit hosts.
5641 The code messed up by falsely reporting buffer overflow in cases
5642 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5643 when "big" contains more than 2**29 bytes, even though this
5644 inserts just one byte and does not overflow the buffer.
5645 (Finsert_file_contents): Store file offsets as off_t
5646 values, not as EMACS_INT values. Check for overflow when
5647 converting between EMACS_INT and off_t. When checking for
5648 buffer overflow or for overlap, take the offsets into account.
5649 Don't use EMACS_INT for small values where int suffices.
5650 When checking for overlap, fix a typo: ZV was used where
5651 ZV_BYTE was intended.
5652 (Fwrite_region): Don't assume off_t fits into 'long'.
5653 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5654
5655 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5656
5657 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5658
5659 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5660
5661 sprintf-related integer and memory overflow issues (Bug#9412).
5662
5663 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5664 (esprintf, exprintf, evxprintf): New functions.
5665 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5666 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5667 (modify_event_symbol): Do not assume that the length of
5668 name_alist_or_stem is safe to alloca and fits in int.
5669 (Fexecute_extended_command): Likewise for function name and binding.
5670 (Frecursion_depth): Wrap around reliably on integer overflow.
5671 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5672 since some callers pass EMACS_INT values.
5673 (Fsingle_key_description): Don't crash if symbol name contains more
5674 than MAX_ALLOCA bytes.
5675 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5676 (get_minibuffer): Arg is now EMACS_INT, not int.
5677 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5678 (esprintf, exprintf, evxprintf): New decls.
5679 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5680
5681 * dbusbind.c (signature_cat): New function.
5682 (xd_signature, Fdbus_register_signal):
5683 Do not overrun buffer; instead, report string overflow.
5684
5685 * dispnew.c (add_window_display_history): Don't overrun buffer.
5686 Truncate instead; this is OK since it's just a log.
5687
5688 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5689 even if the time zone offset is outlandishly large.
5690 Don't mishandle offset == INT_MIN.
5691
5692 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5693 when creating daemon; the previous buffer-overflow check was incorrect.
5694
5695 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5696 which has the guts of the old verror function.
5697
5698 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5699 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5700
5701 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5702 (font_unparse_xlfd): Don't blindly alloca long strings.
5703 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5704 fits in int, when using sprintf. Use single snprintf to count
5705 length of string rather than counting it via multiple sprintfs;
5706 that's simpler and more reliable.
5707 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5708 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5709 sprintf, in case result does not fit in int.
5710
5711 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5712 (fontset_from_font): Print it.
5713
5714 * frame.c (tty_frame_count): Now printmax_t, not int.
5715 (make_terminal_frame, set_term_frame_name): Print it.
5716 (x_report_frame_params): In X, window IDs are unsigned long,
5717 not signed long, so print them as unsigned.
5718 (validate_x_resource_name): Check for implausibly long names,
5719 and don't assume name length fits in 'int'.
5720 (x_get_resource_string): Don't blindly alloca invocation name;
5721 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5722 not fit in int.
5723
5724 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5725 (xg_check_special_colors, xg_set_geometry):
5726 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5727
5728 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5729 Use esprintf, not sprintf, in case result does not fit in int.
5730
5731 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5732 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5733 it as a large positive number.
5734 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5735 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5736
5737 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5738 in case result does not fit in int.
5739
5740 * print.c (float_to_string): Detect width overflow more reliably.
5741 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5742 buffer overrun. Don't assume list length fits in 'int'. Treat
5743 print length of 0 as 0, not as infinity; to be consistent with other
5744 uses of print length in this function. Don't overflow print length
5745 index. Don't assume hash table size fits in 'long', or that
5746 vectorlike size fits in 'unsigned long'.
5747
5748 * process.c (make_process): Use printmax_t, not int, to format
5749 process-name gensyms.
5750
5751 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5752
5753 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5754 to avoid potential buffer overrun.
5755
5756 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5757 if X resource line is longer than 512 bytes.
5758
5759 * xfns.c (x_window): Make sprintf buffer a bit bigger
5760 to avoid potential buffer overrun.
5761
5762 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5763
5764 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5765
5766 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5767
5768 Integer overflow fixes for scrolling, etc.
5769 Without these, Emacs silently mishandles large integers sometimes.
5770 For example, "C-u 4294967297 M-x recenter" was treated as if
5771 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5772
5773 * xdisp.c (try_window_id): Check Emacs fixnum range before
5774 converting to 'int'.
5775
5776 * window.c (window_scroll_line_based, Frecenter):
5777 Check that an Emacs fixnum is in range before assigning it to 'int'.
5778 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5779 values converted from Emacs fixnums.
5780 (Frecenter): Don't wrap around a line count if it is out of 'int'
5781 range; instead, treat it as an extreme value.
5782 (Fset_window_configuration, compare_window_configurations):
5783 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5784
5785 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5786 that can exceed INT_MAX. Check that EMACS_INT value is in range
5787 before assigning it to the (possibly-narrower) index.
5788 (match_limit): Don't assume that a fixnum can fit in 'int'.
5789
5790 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5791 exceed INT_MAX.
5792
5793 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5794 (Fvertical_motion): Don't wrap around LINES values that don't fit
5795 in 'int'. Instead, treat them as extreme values. This is good
5796 enough for windows, which can't have more than INT_MAX lines anyway.
5797
5798 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5799
5800 * Require libxml/parser.h to avoid compilation warning.
5801
5802 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5803
5804 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5805 since this reportedly can destroy thread storage.
5806
5807 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5808
5809 * syntax.c (find_defun_start): Update all cache variables if
5810 exiting early (Bug#9401).
5811
5812 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5813
5814 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5815
5816 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5817 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5818 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5819
5820 * term.c (tty_append_glyph): New function.
5821 (produce_stretch_glyph): Static function and its prototype deleted.
5822
5823 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5824 Add prototypes.
5825
5826 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5827
5828 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5829 when checking :margin (Bug#9390).
5830 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5831 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5832 so that the name doesn't mislead. All uses changed.
5833
5834 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5835
5836 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5837 set_tty_hooks.
5838
5839 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (move_it_to): Don't bail out early when reaching
5842 position beyond to_charpos, if we are scanning backwards.
5843 (move_it_vertically_backward): When DY == 0, make sure we get to
5844 the first character in the line after the newline.
5845
5846 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5847
5848 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5849 (ccl_driver): Do not generate an out-of-range pointer.
5850 (Fccl_execute_on_string): Remove unnecessary check for
5851 integer overflow, noted by Stefan Monnier in
5852 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5853 Remove a FIXME that didn't need fixing.
5854 Simplify the newly-introduced buffer reallocation code.
5855
5856 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5857
5858 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5859
5860 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5861
5862 Integer and memory overflow issues (Bug#9196).
5863
5864 * doc.c (get_doc_string): Rework so that
5865 get_doc_string_buffer_size is the actual buffer size, rather than
5866 being 1 less than the actual buffer size; this makes xpalloc more
5867 convenient.
5868
5869 * image.c (x_allocate_bitmap_record, cache_image):
5870 * xselect.c (Fx_register_dnd_atom):
5871 Simplify previous changes by using xpalloc.
5872
5873 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5874 since either will do and ptrdiff_t is convenient with xpalloc.
5875
5876 * charset.c (charset_table_size)
5877 (struct charset_sort_data.priority): Now ptrdiff_t.
5878 (charset_compare): Don't overflow if priorities differ greatly.
5879 (Fsort_charsets): Don't assume list length fits in int.
5880 Check for size-calculation overflow when allocating sort data.
5881 (syms_of_charset): Allocate an initial charset table that is
5882 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5883
5884 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5885
5886 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5887 The actual value is always <= INT_MAX, and leaving it unsigned made
5888 overflow checking harder.
5889
5890 * dispextern.h (struct glyph_matrix.rows_allocated)
5891 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5892 with xpalloc. The values are still always <= INT_MAX.
5893
5894 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5895
5896 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5897 (SAFE_NALLOCA): New macro.
5898
5899 * region-cache.c (struct boundary.pos, find_cache_boundary)
5900 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5901 (set_cache_region, invalidate_region_cache)
5902 (revalidate_region_cache, know_region_cache, region_cache_forward)
5903 (region_cache_backward, pp_cache):
5904 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5905 so that ptrdiff_t * can be passed to xpalloc.
5906 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5907 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5908 (pp_cache): Don't assume cache_len fits in int.
5909 * region-cache.h: Adjust extern decls to match.
5910
5911 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5912 EMACS_INT, since either will do, for xpalloc.
5913
5914 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5915 (xnmalloc, xnrealloc, xpalloc): New functions.
5916
5917 * bidi.c (bidi_shelve_header_size): New constant.
5918 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5919 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5920
5921 * bidi.c (bidi_cache_shrink):
5922 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5923 (overlay_strings):
5924 Don't update size of array until after memory allocation succeeds,
5925 because xmalloc/xrealloc may not return.
5926 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5927 now that we have proper integer overflow checking.
5928 (record_overlay_string, overlay_strings): Catch overflows when
5929 calculating size of overlay_str_buf.
5930
5931 * callproc.c (Fcall_process): Check for size overflow when
5932 calculating size of args2.
5933 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5934 Normally we prefer signed values, but sticking with ptrdiff_t would
5935 require adding more-complicated checks.
5936
5937 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5938 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5939 Redo buffer-overflow calculations to avoid integer overflow.
5940 Add a FIXME comment where memory seems to be over-allocated.
5941
5942 * character.c (Fstring): Check for size-calculation overflow.
5943
5944 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5945 unnecessary integer overflow. Check for size overflow.
5946 (encode_coding_object): Don't update size until xmalloc succeeds.
5947
5948 * composite.c (get_composition_id): Check for overflow in glyph
5949 length calculations.
5950
5951 Integer and memory overflow fixes for display code.
5952 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5953 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5954 (scrolling_window): Check for overflow in size calculations.
5955 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5956 Don't assume glyph table len fits in int.
5957 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5958 (row_table_size): Now ptrdiff_t, not int.
5959 (scrolling_window): Avoid overflow in size calculations.
5960 Don't update size until allocation succeeds.
5961 * fns.c (concat): Check for overflow in size calculations.
5962 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5963 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5964 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5965
5966 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5967 (get_doc_string): Check for size calculation overflow.
5968 Don't update size until allocation succeeds.
5969 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5970 EMACS_INT, where ptrdiff_t will do.
5971 (Fsubstitute_command_keys): Check for string overflow.
5972
5973 * editfns.c (set_time_zone_rule): Don't assume environment length
5974 fits in int.
5975 (message_length): Now ptrdiff_t, not int.
5976 (Fmessage_box): Don't update size until allocation succeeds.
5977 Don't assume message length fits in int.
5978 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5979
5980 * emacs.c (main): Do not reallocate argv, since there is a null at
5981 the end that can be overwritten, and this way there's no need to
5982 worry about size-calculation overflow.
5983 (sort_args): Check for size-calculation overflow.
5984
5985 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5986 alloc succeeds.
5987 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5988
5989 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5990 (x_set_scroll_bar_width, x_figure_window_size):
5991 Check for integer overflow.
5992 (x_set_alpha): Do not assume XINT fits in int.
5993
5994 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5995 This is for the members text_lines, text_cols, total_lines, total_cols,
5996 where the system imposes an 'int' limit.
5997
5998 * fringe.c (Fdefine_fringe_bitmap):
5999 Don't update size until alloc works.
6000
6001 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6002 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6003
6004 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6005 Check for size-calculation overflow.
6006 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6007 do, as we prefer signed integers.
6008 (id_to_widget.max_size, id_to_widget.used)
6009 (xg_store_widget_in_map, xg_remove_widget_from_map)
6010 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6011 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6012 Use and return ptrdiff_t, not int.
6013 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6014 * gtkutil.h: Change prototypes to match the above.
6015
6016 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6017 are duplicate now that they've been promoted to lisp.h.
6018 (x_allocate_bitmap_record, x_alloc_image_color)
6019 (make_image_cache, cache_image, xpm_load):
6020 Don't update size until alloc is done.
6021 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6022 (x_detect_edges):
6023 Check for size calculation overflow.
6024 (ct_colors_allocated_max): New constant.
6025 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6026 overflow.
6027
6028 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6029 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6030 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6031 Use ptrdiff_t, not int, to count maps.
6032 (read_char_minibuf_menu_prompt): Check for overflow in size
6033 calculations. Don't update size until allocation succeeds.
6034 Redo calculations to avoid overflow.
6035 * keyboard.h: Change prototypes to match the above.
6036
6037 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6038 to count maps.
6039 (current_minor_maps): Check for size calculation overflow.
6040 * keymap.h: Change prototypes to match the above.
6041
6042 * lread.c (read1, init_obarray): Don't update size until alloc done.
6043
6044 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6045 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6046
6047 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6048 Now ptrdiff_t, not int.
6049 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6050 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6051
6052 * process.c (Fnetwork_interface_list): Check for overflow
6053 in size calculation.
6054
6055 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6056
6057 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6058 overflow. Don't bother calling xmalloc when xrealloc will do.
6059
6060 * search.c (Freplace_match): Check for size calculation overflow.
6061 (Fset_match_data): Don't assume list lengths fit in 'int'.
6062
6063 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6064 for command line length. Do not attempt to address one before the
6065 beginning of an array, as that's not portable.
6066
6067 * term.c (max_frame_lines): Remove; unused.
6068 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6069 not int.
6070 (encode_terminal_code, calculate_costs): Check for size
6071 calculation overflow.
6072 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6073 table lengths and related sizes. Don't update size until alloc
6074 done. Redo calculations to avoid overflow.
6075 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6076
6077 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6078 subtracting pointers.
6079 (gobble_line): Check for overflow more carefully. Don't update size
6080 until alloc done.
6081
6082 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6083 Don't update size until alloc done.
6084 Redo size calculations to avoid overflow.
6085 Check for size calculation overflow.
6086 (main) [DEBUG]: Fix typo in invoking tparam1.
6087
6088 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6089 Use ptrdiff_t, not int, for sizes.
6090 (store_mode_line_noprop_char): Don't update size until alloc done.
6091
6092 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6093 Use ptrdiff_t, not int, for sizes.
6094 (Finternal_make_lisp_face, cache_face):
6095 Check for size calculation overflow.
6096 (cache_face): Treat size calculation overflows as if they were
6097 memory exhaustion (the usual treatment), rather than aborting.
6098
6099 * xfns.c (x_encode_text, x_set_name_internal)
6100 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6101 sizes, since they can exceed INT_MAX in size. Check for size
6102 calculation overflow.
6103
6104 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6105 (xg_select): Check for size calculation overflow.
6106 Don't update size until alloc done.
6107
6108 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6109 as sprintf is limited to int lengths.
6110
6111 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6112 (X_LONG_MIN): New macros.
6113 Use them to make the following changes clearer.
6114 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6115 This change doesn't affect the value now, but it may help remind
6116 future maintainers not to raise the value too much later.
6117 (SELECTION_QUANTUM): Remove, replacing with ...
6118 (selection_quantum): ... new function, which avoids overflow.
6119 All uses changed.
6120 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6121 assumption that selection length fits in 'int'.
6122 (x_reply_selection_request, x_handle_selection_request)
6123 (x_get_window_property, receive_incremental_selection)
6124 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6125 (lisp_data_to_selection_data, clean_local_selection_data):
6126 Use ptrdiff_t, not int, to record length of selection.
6127 (x_reply_selection_request, x_get_window_property)
6128 (receive_incremental_selection, x_property_data_to_lisp):
6129 Redo calculations to avoid overflow.
6130 (x_reply_selection_request): When sending hint, ceiling it at
6131 X_LONG_MAX rather than relying on wraparound overflow to send
6132 something.
6133 (x_get_window_property, receive_incremental_selection)
6134 (lisp_data_to_selection_data, x_property_data_to_lisp):
6135 Check for size-calculation overflow.
6136 (x_get_window_property, receive_incremental_selection)
6137 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6138 Don't store size until memory allocation succeeds.
6139 (x_get_window_property): Plug memory leak on memory exhaustion.
6140 Don't double-block input; malloc is safe here. Don't assume 2**34
6141 - 4 fits in unsigned long. Add an xassert to check
6142 XGetWindowProperty overflow. Be more careful about overflow
6143 calculations, and distinguish size from memory overflow better.
6144 (receive_incremental_selection): When tracing, don't assume
6145 unsigned int is less than INT_MAX.
6146 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6147 harmful) conversions of unsigned short to int.
6148 (lisp_data_to_selection_data): Don't assume that integers
6149 in the range -65535 through -1 fit in an X unsigned short.
6150 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6151 result parameters unless successful. Rely on cons_to_unsigned
6152 to report problems with elements; the old code wasn't right anyway.
6153 (x_check_property_data): Check for int overflow; we cannot use
6154 a wider type due to X limits.
6155 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6156
6157 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6158
6159 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6160 (x_term_init): Check for size calculation overflow.
6161 (x_color_cells): Don't store size until memory allocation succeeds.
6162 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6163 Don't assume alloca size is less than MAX_ALLOCA.
6164 (x_term_init): Don't assume length fits in int (sprintf is limited
6165 to int size).
6166
6167 Use ptrdiff_t for composition IDs.
6168 * character.c (lisp_string_width):
6169 * composite.c (composition_table_size, n_compositions)
6170 (get_composition_id, composition_gstring_from_id):
6171 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6172 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6173 * window.c (Frecenter):
6174 Use ptrdiff_t, not int, for composition IDs.
6175 * composite.c (get_composition_id): Check for integer overflow.
6176 * composite.h: Adjust prototypes to match the above changes.
6177
6178 Use ptrdiff_t for hash table indexes.
6179 * category.c (hash_get_category_set):
6180 * ccl.c (ccl_driver):
6181 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6182 * coding.c (coding_system_charset_list, detect_coding_system):
6183 * coding.h (struct coding_system.id):
6184 * composite.c (get_composition_id, gstring_lookup_cache):
6185 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6186 * image.c (xpm_get_color_table_h):
6187 * lisp.h (hash_lookup, hash_put):
6188 * minibuf.c (Ftest_completion):
6189 Use ptrdiff_t for hash table indexes, not int (which is too
6190 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6191 32-bit --with-wide-int hosts).
6192
6193 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6194 Add a FIXME comment about memory leaks.
6195 (syms_of_charset): Don't assume xmalloc returns.
6196
6197 Don't assume that stated character widths fit in int.
6198 * character.c (Fchar_width, c_string_width, lisp_string_width):
6199 * character.h (CHAR_WIDTH):
6200 * indent.c (MULTIBYTE_BYTES_WIDTH):
6201 Use sanitize_char_width to avoid undefined and/or bad behavior
6202 with outlandish widths.
6203 * character.h (sanitize_tab_width): Rename from sanitize_width,
6204 now that we have two such functions. All uses changed.
6205 (sanitize_char_width): New inline function.
6206
6207 Don't assume that tab-width fits in int.
6208 * character.h (sanitize_width): New inline function.
6209 (SANE_TAB_WIDTH): New macro.
6210 (ASCII_CHAR_WIDTH): Use it.
6211 * indent.c (sane_tab_width): Remove. All uses replaced by
6212 SANE_TAB_WIDTH (current_buffer).
6213 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6214
6215 * fileio.c: Integer overflow issues with file modes.
6216 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6217
6218 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6219 Remove unreachable code.
6220 (read_hex, load_charset_map_from_file): Check for integer overflow.
6221
6222 * xterm.c: Don't go over XClientMessageEvent limit.
6223 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6224 (x_send_scroll_bar_event): Likewise. Check that the size does not
6225 exceed limits imposed by XClientMessageEvent, as well as the usual
6226 ptrdiff_t and size_t limits.
6227
6228 * keyboard.c: Overflow, signedness and related fixes.
6229 (make_lispy_movement): Use same integer type in forward decl
6230 that is used in the definition.
6231 (read_key_sequence, keyremap_step):
6232 Change bufsize argument back to int, undoing my 2011-03-30 change.
6233 We prefer signed types, and int is wide enough here.
6234 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6235 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6236 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6237 length, not size_t. Use ptrdiff_t for index, not int.
6238 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6239 possibility of integer overflow.
6240
6241 Overflow, signedness and related fixes for images.
6242
6243 * dispextern.h (struct it.stack[0].u.image.image_id)
6244 (struct_it.image_id, struct image.id, struct image_cache.size)
6245 (struct image_cache.used, struct image_cache.ref_count):
6246 * gtkutil.c (update_frame_tool_bar):
6247 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6248 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6249 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6250 * nsmenu.m (update_frame_tool_bar):
6251 * xdisp.c (calc_pixel_width_or_height):
6252 * xfns.c (image_cache_refcount):
6253 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6254 on typical 64-bit hosts.
6255
6256 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6257 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6258 Omit unnecessary casts to int.
6259 (parse_image_spec): Check that integers fall into 'int' range
6260 when the callers expect that.
6261 (image_ascent): Redo ascent calculation to avoid int overflow.
6262 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6263 (lookup_image): Remove unnecessary tests.
6264 (xbm_image_p): Locals are now of int, not EMACS_INT,
6265 since parse_image_check makes sure they fit into int.
6266 (png_load, gif_load, svg_load_image):
6267 Prefer int to unsigned where either will do.
6268 (tiff_handler): New function, combining the cores of the
6269 old tiff_error_handler and tiff_warning_handler.
6270 This function is rewritten to use vsnprintf and thereby avoid
6271 stack buffer overflows. It uses only the features of vsnprintf
6272 that are common to both POSIX and native Microsoft.
6273 (tiff_error_handler, tiff_warning_handler): Use it.
6274 (tiff_load, gif_load, imagemagick_load_image):
6275 Don't assume :index value fits in 'int'.
6276 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6277 (imagemagick_load_image): Check that crop parameters fit into
6278 the integer types that MagickCropImage accepts. Don't assume
6279 Vimagemagick_render_type has a nonnegative value. Don't assume
6280 size_t fits in 'long'.
6281 (gs_load): Use printmax_t to print the widest integers possible.
6282 Check for integer overflow when computing image height and width.
6283
6284 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6285
6286 * xdisp.c (redisplay_window): Don't force window start if point
6287 will be invisible in the resulting window. (Bug#9324)
6288
6289 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6290
6291 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6292 the display spec is of the form `(space ...)'.
6293 (handle_display_spec): Return the value returned by
6294 handle_single_display_spec, not just 1 or zero.
6295 (handle_single_display_spec): If the display spec is of the form
6296 `(space ...)', and specifies display in the text area, return 2
6297 rather than 1.
6298 (try_cursor_movement): Check for the need to scroll more
6299 accurately, and prefer exact match for point under bidi.
6300 Don't advance `row' beyond the last row of the window.
6301
6302 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6303 into disp_prop; all users changed.
6304
6305 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6306 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6307 for the text covered by the display property.
6308
6309 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6310
6311 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6312 Change return value to nil.
6313 (Frecord_buffer): Delete unused function.
6314
6315 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6316
6317 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6318 buffers, return left-to-right.
6319 (set_cursor_from_row): Consider candidate row a win if its glyph
6320 represents a newline and point is on that newline. Fixes cursor
6321 positioning on the newline at EOL of R2L text within L2R
6322 paragraph, and vice versa.
6323 (try_cursor_movement): Check continued rows, in addition to
6324 continuation rows. Fixes unwarranted scroll when point enters a
6325 continued line of R2L text within an L2R paragraph, or vice versa.
6326 (cursor_row_p): Consider the case of point being equal to
6327 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6328 from the end of a short line to the beginning of a continued line
6329 of R2L text within L2R paragraph.
6330 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6331 composed characters.
6332
6333 * bidi.c (bidi_check_type): Use xassert.
6334 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6335 members.
6336
6337 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6338
6339 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6340 a character.
6341
6342 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6343
6344 * nsfont.m (ns_otf_to_script): Fix typo.
6345
6346 2011-08-22 Kenichi Handa <handa@m17n.org>
6347
6348 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6349 extra slot even if the purpose is char-code-property-table.
6350
6351 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6352
6353 * xdisp.c (redisplay_window): When computing centering_position,
6354 account for the height of the header line. (Bug#8874)
6355
6356 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6357 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6358 candidate is selected by the mouse, and that candidate has a
6359 composed character under the mouse.
6360
6361 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6362 coordinates reported by pos-visible-in-window-p for a composed
6363 character in column zero.
6364
6365 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6366
6367 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6368
6369 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6370
6371 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6372 consider it a hit if to_charpos is anywhere in the range of the
6373 composed buffer positions.
6374
6375 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6376
6377 * image.c (gif_load): Don't assume that each subimage has the same
6378 dimensions as the base image. Handle disposal method that is
6379 "undefined" by the gif spec (Bug#9335).
6380
6381 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6382
6383 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6384 (Fcondition_case): Document `debug' symbol in error handler.
6385
6386 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6387
6388 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6389 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6390 from an Org mode buffer to a Speedbar frame.
6391
6392 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6393 a composition, take its buffer position from IT->cmp_it.charpos.
6394 Fixes cursor positioning at the beginning of a line that begins
6395 with a composed character.
6396
6397 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6398
6399 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6400 character bidirectional type, use STRONG_L instead. Fixes crashes
6401 in a buffer produced by `describe-categories'.
6402
6403 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6404 members before the level stack, so they would be saved and
6405 restored when copying iterator state. Fixes incorrect reordering
6406 around TABs covered by display properties.
6407
6408 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6409
6410 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6411
6412 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6413
6414 * eval.c (internal_condition_case, internal_condition_case_1)
6415 (internal_condition_case_2, internal_condition_case_n):
6416 Remove unnecessary aborts (Bug#9081).
6417
6418 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6419
6420 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6421 has no `load' handler, try opening the file locally. (Bug#9311)
6422
6423 2011-08-16 Ken Brown <kbrown@cornell.edu>
6424
6425 * gmalloc.c: Expand comment.
6426
6427 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6428
6429 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6430 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6431
6432 2011-08-16 Ken Brown <kbrown@cornell.edu>
6433
6434 Fix memory allocation problems in Cygwin build (Bug#9273).
6435
6436 * unexcw.c ( __malloc_initialized): Declare external variable.
6437 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6438
6439 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6440 New variables.
6441 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6442 dumped emacs.
6443 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6444 in the static heap.
6445 [CYGWIN] (special_realloc): New function.
6446 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6447 requests to realloc storage in the static heap.
6448
6449 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6450
6451 * bidi.c (bidi_initialize): Remove unused local.
6452
6453 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6454
6455 * bidimirror.h:
6456 * biditype.h: Remove file.
6457 * makefile.w32-in ($(BLD)/bidi.$(O)):
6458 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6459
6460 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6461
6462 * chartab.c: Improve commentary for the uniprop_table API.
6463
6464 * bidi.c (bidi_paragraph_init): Support zero value of
6465 bidi_ignore_explicit_marks_for_paragraph_level.
6466 (bidi_initialize): Use uniprop_table instead of including
6467 biditype.h and bidimirror.h.
6468
6469 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6470 coordinates of the iterator when restoring from ppos_it.
6471 (Bug#9296)
6472
6473 2011-08-14 Kenichi Handa <handa@m17n.org>
6474
6475 * process.c (create_process): Call setup_process_coding_systems
6476 after the pid of the process is set to -1 (Bug#8162).
6477
6478 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6479
6480 * xdisp.c (move_it_in_display_line_to): Don't invoke
6481 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6482 ppos_it. Fixes vertical cursor motion when line beginning is
6483 covered by an image. (Bug#9296)
6484
6485 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6486
6487 * nsterm.h (ns_run_ascript): Declare.
6488 (NSAPP_DATA2_RUNASSCRIPT): Define.
6489
6490 * nsfns.m (as_script, as_result, as_status): New static variables.
6491 (ns_run_ascript): New function.
6492 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6493 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6494 the event loop. Get status from as_status (Bug#7276).
6495
6496 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6497 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6498 the event loop (Bug#7276).
6499
6500 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6501
6502 * gnutls.c (QCgnutls_bootprop_priority)
6503 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6504 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6505 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6506 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6507 (QCgnutls_bootprop_verify_hostname_error)
6508 (QCgnutls_bootprop_callbacks_verify): Rename from
6509 Qgnutls_bootprop_..., all uses changed.
6510
6511 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6512 uses changed.
6513
6514 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6515
6516 * xfaces.c (Qframe_set_background_mode): Now static.
6517 * dispextern.h (Qframe_set_background_mode): Remove decl.
6518
6519 * process.c (Fnetwork_interface_info): Declare local only if needed.
6520
6521 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6522
6523 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6524 (Fnetwork_interface_list): Allocate in increments of bytes instead
6525 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6526 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6527 sockaddr.
6528 (struct ifflag_def): notrailers is smart on OSX.
6529 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6530 Get hardware address with getifaddrs if available.
6531
6532 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6533
6534 * xdisp.c (iterate_out_of_display_property): xassert that
6535 IT->position is set to within IT->object's boundaries. Break from
6536 the loop as soon as EOB is reached; avoids infloops in redisplay
6537 when IT->position is set up wrongly due to some bug.
6538 Set IT->current to match the bidi iterator unconditionally.
6539 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6540 entry. Force push_it to save on the stack the current
6541 buffer/string position, to be restored by pop_it. Fix flags in
6542 the iterator structure wrt the object coming from a display
6543 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6544 properties. (Bug#9284)
6545
6546 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6547
6548 * fontset.c (fontset_get_font_group): Add proper type checks.
6549 (Bug#9172)
6550
6551 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6552
6553 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6554 and LC_VERSION_MIN_MACOSX.
6555 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6556 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6557
6558 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6559
6560 * xdisp.c (forward_to_next_line_start): Allow to use the
6561 no-display-properties-and-no-overlays under bidi display.
6562 Set disp_pos in the bidi iterator to avoid searches for display
6563 properties and overlays.
6564
6565 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6566
6567 * editfns.c (Fset_time_zone_rule): Document relationship with the
6568 setenv function.
6569
6570 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6571 the font entity extracted from the cache (Bug#8109).
6572
6573 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6574
6575 * composite.c (autocmp_chars): Don't reset point. That is done by
6576 restore_point_unwind (Bug#5984).
6577
6578 2011-08-07 Juri Linkov <juri@jurta.org>
6579
6580 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6581 to show the arg `TIME' instead of `TIMEVAL'.
6582
6583 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6584
6585 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6586 display property strides EOL and includes a newline, as in
6587 longlines-mode. (Bug#9254)
6588 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6589 word-wrap under bidirectional display. (Bug#9224)
6590
6591 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6592 is non-zero, even if the data buffer is NULL. Fixes a crash in
6593 vertical-motion with longlines-mode. (Bug#9254)
6594
6595 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6596
6597 * bidi.c <bidi_cache_total_alloc>: Now static.
6598 (bidi_initialize): Initialize bidi_cache_total_alloc.
6599
6600 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6601 cache. (Bug#9221)
6602
6603 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6604 amount allocated this far in `bidi_cache_total_alloc'.
6605 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6606 non-zero, only free the data buffer without restoring the cache
6607 contents. All callers changed.
6608
6609 * dispextern.h (bidi_unshelve_cache): Update prototype.
6610
6611 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6612 (move_it_in_display_line, move_it_to)
6613 (move_it_vertically_backward, move_it_by_lines): Replace the call
6614 to xfree to an equivalent call to bidi_unshelve_cache.
6615 (move_it_in_display_line_to): Fix logic of returning
6616 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6617
6618 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6619
6620 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6621 came from a string character with a `cursor' property. (Bug#9229)
6622
6623 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6624
6625 * Makefile.in (LIB_PTHREAD): New variable.
6626 (LIBES): Add LIB_PTHREAD (Bug#9216).
6627
6628 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6629 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6630
6631 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6632
6633 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6634
6635 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6636
6637 * xterm.c (x_find_topmost_parent): New function.
6638 (x_set_frame_alpha): Find topmost parent window with
6639 x_find_topmost_parent and set the property there also (bug#9181).
6640 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6641
6642 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6643
6644 * callproc.c (Fcall_process): Avoid vfork clobbering
6645 the local vars buffer, coding_systems, current_dir.
6646
6647 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6648
6649 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6650
6651 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6652
6653 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6654 so that it is not optimized away.
6655
6656 * xdisp.c (compute_display_string_pos): Remove unused local.
6657
6658 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6659
6660 Fix slow cursor motion and scrolling in large buffers with
6661 selective display, like Org Mode buffers. (Bug#9218)
6662
6663 * dispextern.h (struct bidi_it): New member disp_prop_p.
6664
6665 * xdisp.c: Remove one-slot cache of display string positions.
6666 (compute_display_string_pos): Accept an additional argument
6667 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6668 for a display string or property. If found, set DISP_PROP_P
6669 non-zero.
6670
6671 * bidi.c (bidi_fetch_char): Accept an additional argument
6672 DISP_PROP_P, and pass it to compute_display_string_pos.
6673 Only handle text covered by a display string if DISP_PROP_P is returned
6674 non-zero. All callers of bidi_fetch_char changed.
6675
6676 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6677
6678 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6679
6680 2010-12-03 Don March <don@ohspite.net>
6681
6682 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6683 last character M-[char] is translated to ESC [char] (bug#7541).
6684
6685 2011-08-02 Kenichi Handa <handa@m17n.org>
6686
6687 * lisp.h (uniprop_table): Extern it.
6688
6689 * chartab.c (uniprop_table): Make it non-static.
6690
6691 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6692
6693 * xdisp.c (forward_to_next_line_start): Accept additional argument
6694 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6695 on the newline.
6696 (reseat_at_next_visible_line_start): Use the bidi iterator state
6697 returned by forward_to_next_line_start to restore the state of
6698 it->bidi_it after backing up to previous newline. (Bug#9212)
6699
6700 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6701
6702 * regex.c (re_comp): Protoize.
6703 (re_exec): Fix return type.
6704 (regexec): Fix type of `ret'. (Bug#9203)
6705
6706 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6707
6708 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6709 This is needed if max-image-size is a floating-point number.
6710
6711 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6712
6713 * print.c (print_object): Print empty symbol as ##.
6714
6715 * lread.c (read1): Read ## as empty symbol.
6716
6717 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6718
6719 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6720 setting frame foreground color (Bug#9175).
6721 (x_set_background_color): Likewise.
6722
6723 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6724 contents (Bug#9176).
6725 (EmacsTooltip -init): Remove bezels and add shadows to
6726 tooltip windows.
6727
6728 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6729 or scroll bar (Bug#8470).
6730
6731 * nsfont.m (nsfont_open): Remove assignment to voffset and
6732 unnecessary vars hshink, expand, hd, full_height, min_height.
6733 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6734
6735 * nsterm.h (nsfont_info): Remove voffset field.
6736
6737 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6738
6739 Implement strike-through and overline on NextStep (Bug#8863).
6740
6741 * nsfont.m (nsfont_open): Use underline position provided by font,
6742 instead of hard-coded value of 2.
6743 (nsfont_draw): Call ns_draw_text_decoration instead.
6744
6745 * nsterm.h: Add declaration for ns_draw_text_decoration.
6746
6747 * nsterm.m (ns_draw_text_decoration): New function for drawing
6748 underline, overline, and strike-through.
6749 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6750 ns_draw_text_decoration. Change treatment of cursor drawing to
6751 accommodate underlining, etc.
6752
6753 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6754
6755 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6756 default.
6757
6758 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6759
6760 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6761 Without this fix, if a signal arrives just after memory fills up,
6762 'malloc' might be invoked reentrantly.
6763
6764 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6765 In other words, assume that every image size is allowed, on non-X
6766 hosts. This assumption is probably wrong, but it lets Emacs compile.
6767
6768 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6769
6770 * regex.c (re_iswctype): Convert return values to boolean.
6771
6772 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6773
6774 * xdisp.c (compute_display_string_pos): Don't use cached display
6775 string position if the buffer had its restriction changed.
6776 (Bug#9184)
6777
6778 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6779
6780 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6781
6782 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6783
6784 Integer signedness and overflow and related fixes. (Bug#9079)
6785
6786 * bidi.c: Integer size and overflow fixes.
6787 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6788 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6789 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6790 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6791 (bidi_find_other_level_edge):
6792 Use ptrdiff_t instead of EMACS_INT where either will do.
6793 This works better on 32-bit hosts configured --with-wide-int.
6794 (bidi_cache_ensure_space): Check for size-calculation overflow.
6795 Use % rather than repeated addition, for better worst-case speed.
6796 Don't set bidi_cache_size until after xrealloc returns, because it
6797 might not return.
6798 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6799 (bidi_cache_ensure_space): Also check that the bidi cache size
6800 does not exceed that of the largest Lisp string or buffer. See Eli
6801 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6802
6803 * alloc.c (__malloc_size_t): Remove.
6804 All uses replaced by size_t. See Andreas Schwab's note
6805 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6806
6807 * image.c: Improve checking for integer overflow.
6808 (check_image_size): Assume that f is nonnull, since
6809 it is always nonnull in practice. This is one less thing to
6810 worry about when checking for integer overflow later.
6811 (x_check_image_size): New function, which checks for integer
6812 overflow issues inside X.
6813 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6814 This removes the need for a memory_full check.
6815 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6816 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6817 (xbm_read_bitmap_data): Change locals back to 'int', since
6818 their values must fit in 'int'.
6819 (xpm_load_image, png_load, tiff_load):
6820 Invoke x_create_x_image_and_pixmap earlier,
6821 to avoid much needless work if the image is too large.
6822 (tiff_load): Treat overly large images as if
6823 x_create_x_image_and_pixmap failed, not as malloc failures.
6824 (gs_load): Use x_check_image_size.
6825
6826 * gtkutil.c: Omit integer casts.
6827 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6828 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6829
6830 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6831
6832 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6833 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6834 would wrongly return t on a 64-bit host.
6835
6836 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6837 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6838 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6839 and therefore cause GCC to emit a bogus diagnostic in some cases.
6840
6841 * image.c: Integer signedness and overflow and related fixes.
6842 This is not an exhaustive set of fixes, but it's time to
6843 record what I've got.
6844 (lookup_pixel_color, check_image_size): Remove redundant decls.
6845 (check_image_size): Don't assume that arbitrary EMACS_INT values
6846 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6847 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6848 (tiff_load, imagemagick_load_image):
6849 Check for overflow in size calculations.
6850 (x_create_x_image_and_pixmap): Remove unnecessary test for
6851 xmalloc returning NULL; that can't happen.
6852 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6853 (xpm_color_bucket): Use better integer hashing function.
6854 (xpm_cache_color): Don't possibly over-allocate memory.
6855 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6856 (gif_memory_source):
6857 Use ptrdiff_t, not int or size_t, to record sizes.
6858 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6859 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6860 either works, as we prefer signed integers.
6861 (tiff_read_from_memory, tiff_write_from_memory):
6862 Return tsize_t, not size_t, since that's what the TIFF API wants.
6863 (tiff_read_from_memory): Don't fail simply because the read would
6864 go past EOF; instead, return a short read.
6865 (tiff_load): Omit no-longer-needed casts.
6866 (Fimagemagick_types): Don't assume size fits into 'int'.
6867
6868 Improve hashing quality when configured --with-wide-int.
6869 * fns.c (hash_string): New function, taken from sxhash_string.
6870 Do not discard information about ASCII character case; this
6871 discarding is no longer needed.
6872 (sxhash-string): Use it. Change sig to match it. Caller changed.
6873 * lisp.h: Declare it.
6874 * lread.c (hash_string): Remove, since we now use fns.c's version.
6875 The fns.c version returns a wider integer if --with-wide-int is
6876 specified, so this should help the quality of the hashing a bit.
6877
6878 * emacs.c: Integer overflow minor fix.
6879 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6880 Define only if GNU_LINUX.
6881 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6882
6883 * dispnew.c: Integer signedness and overflow fixes.
6884 Remove unnecessary forward decls, that were a maintenance hassle.
6885 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6886 All uses changed.
6887 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6888 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6889 (prepare_desired_row, line_draw_cost):
6890 Use int, not unsigned, where either works.
6891 (save_current_matrix, restore_current_matrix):
6892 Use ptrdiff_t, not size_t, where either works.
6893 (init_display): Check for overflow more accurately, and without
6894 relying on undefined behavior.
6895
6896 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6897 Remove, replacing with the new symbols in lisp.h. All uses changed.
6898 * fileio.c (make_temp_name):
6899 * filelock.c (lock_file_1, lock_file):
6900 * xdisp.c (message_dolog):
6901 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6902 Use pMd etc. instead.
6903 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6904 replacing the pWIDE etc. symbols removed from editfns.c.
6905
6906 * keyboard.h (num_input_events): Now uintmax_t.
6907 This is (very slightly) less likely to mess up due to wraparound.
6908 All uses changed.
6909
6910 * buffer.c: Integer signedness fixes.
6911 (alloc_buffer_text, enlarge_buffer_text):
6912 Use ptrdiff_t rather than size_t when either will do, as we prefer
6913 signed integers.
6914
6915 * alloc.c: Integer signedness and overflow fixes.
6916 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6917 (__malloc_size_t): Default to size_t, not to int.
6918 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6919 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6920 Prefer ptrdiff_t to size_t when either would do, as we prefer
6921 signed integers.
6922 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6923 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6924 Now const. Initialize with values that are in range even if char
6925 is signed.
6926 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6927 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6928 These functions do the right thing with sizes > 2**32.
6929 (check_depth): Now ptrdiff_t, not int.
6930 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6931 Adjust to new way of storing sizes. Check for size overflow bugs
6932 in rest of code.
6933 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6934 slightly wrong anyway, as it missed one instance of
6935 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6936 (refill_memory_reserve): Omit needless cast to size_t.
6937 (mark_object_loop_halt): Mark as externally visible.
6938
6939 * xselect.c: Integer signedness and overflow fixes.
6940 (Fx_register_dnd_atom, x_handle_dnd_message):
6941 Use ptrdiff_t, not size_t, since we prefer signed.
6942 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6943 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6944 x_dnd_atoms_size and x_dnd_atoms_length.
6945
6946 * doprnt.c: Prefer signed to unsigned when either works.
6947 * eval.c (verror):
6948 * doprnt.c (doprnt):
6949 * lisp.h (doprnt):
6950 * xdisp.c (vmessage):
6951 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6952 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6953 prefer signed arithmetic to avoid comparison confusion.
6954 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6955 but is a bit tricky.
6956
6957 Assume freestanding C89 headers, string.h, stdlib.h.
6958 * data.c, doprnt.c, floatfns.c, print.c:
6959 Include float.h unconditionally.
6960 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6961 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6962 * regex.c: Likewise for stddef.h, string.h.
6963 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6964 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6965 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6966 (STDC_HEADERS): Remove obsolete defines.
6967 * sysdep.c: Include limits.h unconditionally.
6968
6969 Assume support for memcmp, memcpy, memmove, memset.
6970 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6971 * regex.c (memcmp, memcpy):
6972 Remove; we assume C89 now.
6973
6974 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6975 (__malloc_safe_bcopy): Remove; no longer needed.
6976
6977 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6978 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6979 well either way, and we prefer signed to unsigned.
6980
6981 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6982
6983 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6984 closes the connection while we're reading (bug#9182).
6985
6986 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6987
6988 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6989 are specified (Bug#9168).
6990
6991 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6992
6993 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6994 Found by GCC static checking and --with-wide-int on a 32-bit host.
6995
6996 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6997
6998 * xdisp.c (compute_display_string_pos): Fix logic of caching
6999 previous display string position. Initialize cached_prev_pos to
7000 -1. Fixes slow-down at the beginning of a buffer.
7001
7002 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7003
7004 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7005 for attrs[LFACE_FONTSET_INDEX].
7006
7007 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7008
7009 * xml.c (parse_region): Remove unused local
7010 that was recently introduced.
7011
7012 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7013
7014 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7015 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7016
7017 * xdisp.c (move_it_in_display_line_to): Record the best matching
7018 position for TO_CHARPOS while scanning the line, and restore it on
7019 exit if none of the characters scanned was an exact match.
7020 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7021 when exact match is impossible due to invisible text, and the
7022 lines are truncated.
7023
7024 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7025
7026 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7027 for OSX >= 10.7.
7028
7029 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7030
7031 Fix a significant slow-down of cursor motion with C-n, C-p,
7032 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7033 auto-repeat under bidi redisplay in fontified buffers.
7034 * xdisp.c (compute_stop_pos_backwards): New function.
7035 (next_element_from_buffer): Call compute_stop_pos_backwards to
7036 find a suitable prev_stop when we find ourselves before
7037 base_level_stop.
7038 (reseat): Don't look for prev_stop, as that could mean a very long
7039 run.
7040 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7041 <cached_disp_overlay_modiff>: Cache for last found display string
7042 position.
7043 (compute_display_string_pos): Return the cached position if asked
7044 about the same buffer in the same area of character positions, and
7045 the buffer wasn't changed since the time the display string
7046 position was cached.
7047
7048 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7049
7050 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7051 is an integer, which is important for empty lines. (Bug#9149)
7052
7053 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7054
7055 * frame.c (Fmodify_frame_parameters): In tty case, update the
7056 default face if necessary (Bug#4238).
7057
7058 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7059
7060 * editfns.c (Fstring_to_char): No need to explain what a character
7061 is in the docstring (Bug#6576).
7062
7063 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7064
7065 * xml.c (parse_region): Make sure we always return a tree.
7066
7067 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7068
7069 * xml.c (parse_region): If a document contains only comments,
7070 return that, too.
7071
7072 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7073
7074 * xml.c (make_dom): Return comments, too.
7075
7076 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7077
7078 Port to OpenBSD.
7079 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7080 and the surrounding thread.
7081 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7082 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7083 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7084 timer goes off.
7085 * s/openbsd.h (BROKEN_SIGIO): Define.
7086 * unexelf.c (unexec) [__OpenBSD__]:
7087 Don't update the .mdebug section of the Alpha COFF symbol table.
7088
7089 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7090
7091 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7092 (bug#8460).
7093
7094 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7095
7096 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7097 This fixes some race conditions on the permissions of any newly
7098 created file.
7099
7100 * alloc.c (valid_pointer_p): Use pipe, not open.
7101 This fixes some permissions issues when debugging.
7102
7103 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7104 If fchown fails to set both uid and gid, try to set just gid,
7105 as that is sometimes allowed. Adjust the file's mode to eliminate
7106 setuid or setgid bits that are inappropriate if fchown fails.
7107
7108 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7109
7110 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7111 to compare Lisp_Objects.
7112 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7113 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7114 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7115
7116 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7117
7118 * lread.c (read_integer): Unread even EOF character.
7119 (read1): Likewise. Properly record start position of symbol.
7120
7121 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7122 symbol character follows.
7123
7124 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7125
7126 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7127 This works around a problem with the previous change to Fcopy_file.
7128 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7129 and without this change, GCC might complain about discarding
7130 fchown's return value.
7131
7132 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7133
7134 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7135
7136 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7137
7138 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7139
7140 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7141
7142 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7143 it's used from the C level.
7144
7145 * process.c: Use the same condition for POLL_FOR_INPUT in both
7146 keyboard.c and process.c (bug#1858).
7147
7148 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7149
7150 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7151 (Fgnutls_boot): Use it.
7152
7153 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7154
7155 * doc.c (Fsubstitute_command_keys): Revert last change.
7156
7157 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7158
7159 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7160 quotes the next character, and doesn't affect other longer
7161 sequences (bug#8935).
7162
7163 * lread.c (syms_of_lread): Clarify that is isn't only
7164 `eval-buffer' and `eval-defun' that's affected by
7165 `lexical-binding' (bug#8460).
7166
7167 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7168
7169 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7170 bidi redisplay when a line includes both an image and is truncated.
7171
7172 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7173
7174 Fix minor problems found by static checking.
7175 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7176 (elsz): Now a signed constant, not a size_t var. We prefer signed
7177 types to unsigned, to avoid integer comparison confusion. Without
7178 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7179 "cannot optimize loop, the loop counter may overflow", a symptom
7180 of the confusion.
7181 * indent.c (Fvertical_motion): Mark locals as initialized.
7182 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7183
7184 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7185
7186 * search.c (Fre_search_backward): Mention `case-fold-search' in
7187 all the re_search_* functions (bug#8138).
7188
7189 * keyboard.c (Fopen_dribble_file): Document when the file is
7190 closed (bug#8056).
7191
7192 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7193
7194 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7195 bidi_cache_idx.
7196
7197 Support bidi reordering of display and overlay strings.
7198 * xdisp.c (compute_display_string_pos)
7199 (compute_display_string_end): Accept additional argument STRING.
7200 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7201 (reseat_to_string): Initialize bidi_it->string.s and
7202 bidi_it->string.schars.
7203 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7204 NULL (avoids a crash in bidi_paragraph_init).
7205 Initialize itb.string.lstring.
7206 (init_iterator): Call bidi_init_it only of a valid
7207 buffer position was specified. Initialize paragraph_embedding to
7208 L2R.
7209 (reseat_to_string): Initialize the bidi iterator.
7210 (display_string): If we need to ignore text properties of
7211 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7212 original value of -1 will not work with bidi.)
7213 (compute_display_string_pos): First arg is now struct
7214 `text_pos *'; all callers changed. Support display properties on
7215 Lisp strings.
7216 (compute_display_string_end): Support display properties on Lisp
7217 strings.
7218 (init_iterator, reseat_1, reseat_to_string): Initialize the
7219 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7220 when iterating on a string not from display properties).
7221 (compute_display_string_pos, compute_display_string_end):
7222 Fix calculation of the object to scan. Fixes an error when using
7223 arrow keys.
7224 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7225 base_level_stop; instead, set base_level_stop to BEGV.
7226 Fixes crashes in vertical-motion.
7227 (next_element_from_buffer): Improve commentary for when
7228 the iterator is before prev_stop.
7229 (init_iterator): Initialize bidi_p from the default value of
7230 bidi-display-reordering, not from buffer-local value. Use the
7231 buffer-local value only if initializing for buffer iteration.
7232 (handle_invisible_prop): Support invisible properties on strings
7233 that are being bidi-reordered.
7234 (set_iterator_to_next): Support bidi reordering of C strings and
7235 Lisp strings.
7236 (next_element_from_string): Support bidi reordering of Lisp
7237 strings.
7238 (handle_stop_backwards): Support Lisp strings as well.
7239 (display_string): Support display of R2L glyph rows.
7240 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7241 (init_iterator): Don't initialize it->bidi_p for strings
7242 here.
7243 (reseat_to_string): Initialize it->bidi_p for strings here.
7244 (next_element_from_string, next_element_from_c_string)
7245 (next_element_from_buffer): Add xassert's for correspondence
7246 between IT's object being iterated and it->bidi_it.string
7247 structure.
7248 (face_before_or_after_it_pos): Support bidi iteration.
7249 (next_element_from_c_string): Handle the case of the first string
7250 character that is not the first one in the visual order.
7251 (get_visually_first_element): New function, refactored from common
7252 parts of next_element_from_buffer, next_element_from_string, and
7253 next_element_from_c_string.
7254 (tool_bar_lines_needed, redisplay_tool_bar)
7255 (display_menu_bar): Force left-to-right direction. Add a FIXME
7256 comment for making that be controlled by a user option.
7257 (push_it, pop_it): Save and restore the state of the
7258 bidi iterator. Save and restore the bidi_p flag.
7259 (pop_it): Iterate out of display property for string iteration as
7260 well.
7261 (iterate_out_of_display_property): Support iteration over strings.
7262 (handle_single_display_spec): Set up it->bidi_it for iteration
7263 over a display string, and call bidi_init_it.
7264 (handle_single_display_spec, next_overlay_string)
7265 (get_overlay_strings_1, push_display_prop): Set up the bidi
7266 iterator for displaying display or overlay strings.
7267 (forward_to_next_line_start): Don't use the shortcut if
7268 bidi-iterating.
7269 (back_to_previous_visible_line_start): If handle_display_prop
7270 pushed the iterator stack, restore the internal state of the bidi
7271 iterator by calling bidi_pop_it same number of times.
7272 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7273 and we are bidi-iterating, don't decrement the iterator position;
7274 instead, set the first_elt flag in the bidi iterator, to produce
7275 the same effect.
7276 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7277 (push_display_prop): xassert that we are iterating a buffer.
7278 (push_it, pop_it): Save and restore paragraph_embedding member.
7279 (handle_single_display_spec, next_overlay_string)
7280 (get_overlay_strings_1, reseat_1, reseat_to_string)
7281 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7282 correctly. Don't assume unibyte strings are not bidi-reordered.
7283 (compute_display_string_pos)
7284 (compute_display_string_end): Fix handling the case of C string.
7285 (push_it, pop_it): Save and restore from_disp_prop_p.
7286 (handle_single_display_spec, push_display_prop): Set the
7287 from_disp_prop_p flag.
7288 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7289 (pop_it): Call iterate_out_of_display_property only if we are
7290 popping after iteration over a string that came from a display
7291 property. Fix a typo in popping stretch info. Add an assertion
7292 for verifying that the iterator position is in sync with the bidi
7293 iterator.
7294 (handle_single_display_spec, get_overlay_strings_1)
7295 (push_display_prop): Fix initialization of paragraph direction for
7296 string when that of the parent object is not yet determined.
7297 (reseat_1): Call bidi_init_it to resync the bidi
7298 iterator with IT's position. (Bug#7616)
7299 (find_row_edges): If ROW->start.pos gives position
7300 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7301 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7302 Reset the from_disp_prop_p flag.
7303 (SAVE_IT, RESTORE_IT): New macros.
7304 (pos_visible_p, face_before_or_after_it_pos)
7305 (back_to_previous_visible_line_start)
7306 (move_it_in_display_line_to, move_it_in_display_line)
7307 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7308 (try_scrolling, redisplay_window, display_line): Use them when
7309 saving a temporary copy of the iterator and restoring it back.
7310 (back_to_previous_visible_line_start, reseat_1)
7311 (init_iterator): Empty the bidi cache "stack".
7312 (move_it_in_display_line_to): If iterator ended up at
7313 EOL, but we never saw any buffer positions smaller than
7314 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7315 motion in bidi-reordered lines.
7316 (move_it_in_display_line_to): Record prev_method and prev_pos
7317 immediately before the call to set_iterator_to_next. Fixes cursor
7318 motion in bidi-reordered lines with stretch glyphs and strings
7319 displayed in margins. (Bug#8133) (Bug#8867)
7320 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7321 TO_CHARPOS.
7322 (pos_visible_p): Support positions in bidi-reordered lines.
7323 Save and restore bidi cache.
7324
7325 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7326 (bidi_paragraph_info): Delete unused struct.
7327 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7328 (bidi_cache_start): New variable.
7329 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7330 to zero.
7331 (bidi_cache_fetch_state, bidi_cache_search)
7332 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7333 (bidi_cache_find, bidi_peek_at_next_level)
7334 (bidi_level_of_next_char, bidi_find_other_level_edge)
7335 (bidi_move_to_visually_next): Compare cache index with
7336 bidi_cache_start rather than with zero.
7337 (bidi_fetch_char): Accept new argument STRING; all callers
7338 changed. Support iteration over a string. Support strings with
7339 display properties. Support unibyte strings. Fix the type of
7340 `len' according to what STRING_CHAR_AND_LENGTH expects.
7341 (bidi_paragraph_init, bidi_resolve_explicit_1)
7342 (bidi_resolve_explicit, bidi_resolve_weak)
7343 (bidi_level_of_next_char, bidi_move_to_visually_next):
7344 Support iteration over a string.
7345 (bidi_set_sor_type, bidi_resolve_explicit_1)
7346 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7347 can now be zero (for strings); special values 0 and -1 were
7348 changed to -1 and -2, respectively.
7349 (bidi_char_at_pos): New function.
7350 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7351 Call it instead of FETCH_MULTIBYTE_CHAR.
7352 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7353 initialized to valid values.
7354 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7355 values.
7356 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7357 the test for valid cached positions. Fix the logic for looking up
7358 the sentinel state in the cache. GCPRO the Lisp string we are
7359 iterating.
7360 (bidi_push_it, bidi_pop_it): New functions.
7361 (bidi_initialize): Initialize the bidi cache start stack pointer.
7362 (bidi_cache_ensure_space): New function, refactored from part of
7363 bidi_cache_iterator_state. Don't assume the required size is just
7364 one BIDI_CACHE_CHUNK away.
7365 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7366 (bidi_count_bytes, bidi_char_at_pos): New functions.
7367 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7368 always valid if bidi_cache_idx is valid.
7369 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7370 is valid if it's going to be used.
7371 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7372 (bidi_cache_fetch_state, bidi_cache_search)
7373 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7374 (bidi_cache_iterator_state, bidi_cache_find)
7375 (bidi_find_other_level_edge, bidi_cache_start_stack):
7376 All variables related to cache indices are now EMACS_INT.
7377
7378 * dispextern.h (struct bidi_string_data): New structure.
7379 (struct bidi_it): New member `string'. Make flag members be 1-bit
7380 fields, and put them last in the struct.
7381 (compute_display_string_pos, compute_display_string_end):
7382 Update prototypes.
7383 (bidi_push_it, bidi_pop_it): Add prototypes.
7384 (struct iterator_stack_entry): New members bidi_p,
7385 paragraph_embedding, and from_disp_prop_p.
7386 (struct it): Member bidi_p is now a bit field 1 bit wide.
7387 (bidi_shelve_cache, bidi_unshelve_cache):
7388 Declare prototypes.
7389
7390 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7391 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7392 and vector-like objects.
7393
7394 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7395 cache around display iteration.
7396
7397 * window.c (Fwindow_end, window_scroll_pixel_based)
7398 (displayed_window_lines, Frecenter): Save and restore the bidi
7399 cache around display iteration.
7400
7401 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7402
7403 * editfns.c (Fdelete_region): Clarify the use of the named
7404 parameters (bug#6788).
7405
7406 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7407
7408 * indent.c (Fvertical_motion): Set and restore w->pointm when
7409 saving and restoring the window's buffer (Bug#9006).
7410
7411 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7412
7413 * editfns.c (Fstring_to_char): Clarify just what is returned
7414 (bug#6576). Text by Eli Zaretskii.
7415
7416 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7417
7418 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7419
7420 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7421
7422 * buffer.c (mmap_find): Fix a typo.
7423
7424 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7425
7426 Fix execution of x selection hooks.
7427 * xselect.c (Qx_lost_selection_functions)
7428 (Qx_sent_selection_functions): New vars.
7429 (syms_of_xselect): DEFSYM them.
7430 (x_handle_selection_request): Pass Qx_sent_selection_functions
7431 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7432 (x_handle_selection_clear,x_clear_frame_selections):
7433 Pass Qx_lost_selection_functions rather than
7434 Vx_lost_selection_functions to Frun_hook_with_args.
7435
7436 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7437
7438 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7439 The old code sometimes used this field without initializing it.
7440
7441 * alloc.c (gc_sweep): Don't read past end of array.
7442 In theory, the old code could also have corrupted Emacs internals,
7443 though it'd be very unlikely.
7444
7445 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7446
7447 * character.c (Fcharacterp): Don't advertise optional ignored
7448 argument. (Bug#4026)
7449
7450 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7451
7452 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7453 key" (bug#4257).
7454
7455 * window.c (Fset_window_start): Doc fix (bug#4199).
7456 (Fset_window_hscroll): Ditto.
7457
7458 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7459
7460 Fix minor new problems caught by GCC 4.6.1.
7461 * term.c (init_tty): Remove unused local.
7462 * xsettings.c (store_monospaced_changed): Define this function only
7463 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7464 not used otherwise.
7465
7466 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7467
7468 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7469
7470 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7471
7472 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7473 are the mini-buffer and the echo area (bug#3320).
7474
7475 * term.c (init_tty): Remove support for supdup, c10 and perq
7476 terminals, which are no longer supported (bug#1482).
7477
7478 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7479
7480 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7481
7482 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7483
7484 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7485 for non-popups (Bug#3642).
7486
7487 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7488
7489 * alloc.c (reset_malloc_hooks): Protoize.
7490 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7491 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7492 * cm.c (losecursor): Likewise.
7493 * data.c (fmod): Likewise.
7494 * dispnew.c (swap_glyphs_in_rows): Likewise.
7495 * emacs.c (memory_warning_signal): Likewise.
7496 * floatfns.c (float_error): Likewise.
7497 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7498 (otf_open, font_otf_capability, generate_otf_features)
7499 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7500 Likewise.
7501 * image.c (pbm_read_file): Likewise.
7502 * indent.c (string_display_width): Likewise.
7503 * intervals.c (check_for_interval, search_for_interval)
7504 (inc_interval_count, count_intervals, root_interval)
7505 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7506 * lread.c (defalias): Likewise.
7507 * ralloc.c (r_alloc_check): Likewise.
7508 * regex.c (set_image_of_range_1, set_image_of_range)
7509 (regex_grow_registers): Likewise.
7510 * sysdep.c (strerror): Likewise.
7511 * termcap.c (valid_filename_p, tprint, main): Likewise.
7512 * tparam.c (main): Likewise.
7513 * unexhp9k800.c (run_time_remap, save_data_space)
7514 (update_file_ptrs, read_header, write_header, calculate_checksum)
7515 (copy_file, copy_rest, display_header): Likewise.
7516 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7517 Likewise.
7518 * xdisp.c (check_it): Likewise.
7519 * xfaces.c (register_color, unregister_color, unregister_colors):
7520 Likewise.
7521 * xfns.c (print_fontset_result): Likewise.
7522 * xrdb.c (member, fatal, main): Likewise.
7523
7524 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7525
7526 Fix minor problems found by static checking (Bug#9031).
7527 * chartab.c (char_table_set_range, map_sub_char_table):
7528 Remove unused locals.
7529 (uniprop_table): Now static.
7530 * composite.c (_work_char): Remove unused static var.
7531
7532 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7533
7534 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7535
7536 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7537
7538 * gtkutil.c (qttip_cb): Remove code without function.
7539
7540 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7541
7542 * w32.c (pthread_sigmask): New stub.
7543
7544 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7545
7546 Use pthread_sigmask, not sigprocmask (Bug#9010).
7547 sigprocmask is portable only for single-threaded applications, and
7548 Emacs can be multi-threaded when it uses GTK.
7549 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7550 (LIBES): Use it.
7551 * callproc.c (Fcall_process):
7552 * process.c (create_process):
7553 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7554 Use pthread_sigmask, not sigprocmask.
7555
7556 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7557
7558 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7559 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7560 wrong (Bug#8591).
7561
7562 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7563
7564 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7565 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7566 (xg_hide_tooltip): Fix comment.
7567
7568 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7569 in registerServicesMenuSendTypes.
7570 (validRequestorForSendType): Don't check ns_return_types.
7571
7572 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7573 ns_return_type.
7574
7575 2011-07-08 Jason Rumney <jasonr@gnu.org>
7576
7577 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7578 SH_SHOW for hidden windows (Bug#5482).
7579
7580 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7581 frame struct members of non-existent frames (Bug#6284).
7582
7583 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7584
7585 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7586 variable firstTime not needed on OSX >= 10.6.
7587 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7588 >= 10.5. Use setKnobProportion, setDoubleValue.
7589
7590 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7591 (MAC_OS_X_VERSION_10_5): Define if not defined.
7592 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7593 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7594 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7595
7596 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7597 cString and lossyCString on OSX >= 10.4
7598
7599 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7600 sizeToFit on OSX >= 10.2.
7601
7602 * nsimage.m (allocInitFromFile): Don't use deprecated method
7603 bestRepresentationForDevice on OSX >= 10.6.
7604
7605 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7606 to avoid warning.
7607
7608 * emacs.c: Declare unexec_init_emacs_zone.
7609
7610 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7611
7612 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7613
7614 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7615 on svcsMenu (Bug#8842).
7616
7617 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7618 ns_return_types.
7619 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7620
7621 * nsterm.m (QUTF8_STRING): Declare.
7622 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7623 (validRequestorForSendType): Return type is (id).
7624 Change indexOfObjectIdenticalTo to indexOfObject.
7625 Check if we have local selection before returning self (Bug#8842).
7626 (writeSelectionToPasteboard): Put local selection into paste board
7627 if we have a local selection (Bug#8842).
7628 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7629
7630 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7631 (ns_get_local_selection): Declare.
7632
7633 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7634
7635 * keymap.c (describe_map_tree): Don't insert a double newline at
7636 the end of the buffer (bug#1169) and return whether we inserted
7637 something.
7638
7639 * callint.c (Fcall_interactively): Change "reading args" to
7640 "providing args" to try to clarify what it does (bug#1010).
7641
7642 2011-07-07 Kenichi Handa <handa@m17n.org>
7643
7644 * composite.c (composition_compute_stop_pos): Ignore a static
7645 composition starting before CHARPOS (Bug#8915).
7646
7647 * xdisp.c (handle_composition_prop): Likewise.
7648
7649 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7650
7651 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7652 (Bug#9015)
7653
7654 2011-07-07 Kenichi Handa <handa@m17n.org>
7655
7656 * character.h (unicode_category_t): New enum type.
7657
7658 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7659 (Qchar_code_property_table): New variable.
7660 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7661 (UNIPROP_COMPRESSED_FORM_P): New macros.
7662 (char_table_ascii): Uncompress the compressed values.
7663 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7664 Uncompress the compressed values.
7665 (sub_char_table_ref_and_range): Likewise.
7666 (char_table_ref_and_range): Uncompress the compressed values.
7667 (sub_char_table_set): New arg is_uniprop. Callers changed.
7668 Uncompress the compressed values.
7669 (sub_char_table_set_range): Args changed. Callers changed.
7670 (char_table_set_range): Adjuted for the above change.
7671 (map_sub_char_table): Delete args default_val and parent. Add arg
7672 top. Give decoded values to a Lisp function.
7673 (map_char_table): Adjust for the above change. Give decoded
7674 values to a Lisp function. Gcpro more variables.
7675 (uniprop_table_uncompress)
7676 (uniprop_decode_value_run_length): New functions.
7677 (uniprop_decoder, uniprop_decoder_count): New variables.
7678 (uniprop_get_decoder, uniprop_encode_value_character)
7679 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7680 New functions.
7681 (uniprop_encoder, uniprop_encoder_count): New variables.
7682 (uniprop_get_encoder, uniprop_table)
7683 (Funicode_property_table_internal, Fget_unicode_property_internal)
7684 (Fput_unicode_property_internal): New functions.
7685 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7686 Sunicode_property_table_internal, Sget_unicode_property_internal,
7687 and Sput_unicode_property_internal. Defvar_lisp
7688 char-code-property-alist.
7689
7690 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7691 Vunicode_category_table.
7692
7693 * font.c (font_range): Adjust for the change of
7694 Vunicode_category_table.
7695
7696 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7697
7698 * m/iris4d.h: Remove file, move contents ...
7699 * s/irix6-5.h: ... here.
7700
7701 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7702
7703 Remove unportable assumption about struct layout (Bug#8884).
7704 * alloc.c (mark_buffer):
7705 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7706 (clone_per_buffer_values): Don't assume that
7707 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7708 This isn't true in general, and it's particularly not true
7709 if Emacs is configured with --with-wide-int.
7710 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7711 New macros, used in the buffer.c change.
7712
7713 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7714
7715 * xsettings.c: Use both GConf and GSettings if both are available.
7716 (store_config_changed_event): Add comment.
7717 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7718 (store_tool_bar_style_changed): New functions.
7719 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7720 (struct xsettings): Move font inside HAVE_XFT.
7721 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7722 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7723 Move inside HAVE_XFT.
7724 (something_changed_gsettingsCB): Rename from something_changedCB.
7725 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7726 also.
7727 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7728 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7729 (something_changed_gconfCB): Rename from something_changedCB.
7730 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7731 (parse_settings): Move check for font inside HAVE_XFT.
7732 (read_settings, apply_xft_settings): Add comment.
7733 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7734 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7735 call store_font_name_changed.
7736 (xft_settings_event): Add comment.
7737 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7738 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7739 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7740 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7741 (xsettings_initialize): Call init_gsettings last.
7742 (xsettings_get_system_font, xsettings_get_system_normal_font):
7743 Add comment.
7744
7745 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7746
7747 Random fixes. E.g., (random) never returned negative values.
7748 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7749 subseconds part to the entropy, as that's a bit more random.
7750 Prefer signed to unsigned, since the signedness doesn't matter and
7751 in general we prefer signed. When given a limit, use a
7752 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7753 latter isn't right if USE_2_TAGS_FOR_INTS.
7754 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7755 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7756
7757 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7758
7759 * textprop.c (text_property_stickiness):
7760 Obey Vtext_property_default_nonsticky.
7761 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7762 * w32fns.c (syms_of_w32fns):
7763 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7764
7765 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7766
7767 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7768 This is more efficient than Ffile_directory_p and avoids a minor race.
7769
7770 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7771
7772 * buffer.c (Foverlay_put): Say what the return value is
7773 (bug#7835).
7774
7775 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7776 is a directory before asking whether to use the file name
7777 (bug#7564).
7778 (barf_or_query_if_file_exists): Make the "File is a directory"
7779 error be more correct.
7780
7781 * fns.c (Frequire): Remove the mention of the .gz files, since
7782 that's installation-specific, but keep the mention of
7783 `get-load-suffixes'.
7784
7785 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7786
7787 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7788 Report string overflow if the output is too long.
7789
7790 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7791
7792 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7793 (syms_of_gnutls): Remove duplicate DEFSYM for
7794 Qgnutls_bootprop_verify_hostname_error, an error for
7795 Qgnutls_bootprop_verify_error (which is no longer used).
7796
7797 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7798 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7799 Also (re)move comments that are misplaced or no longer relevant.
7800
7801 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7802
7803 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7804
7805 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7806
7807 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7808 and background color parameters if they have been changed.
7809
7810 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7811
7812 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7813
7814 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7815
7816 * xsettings.c (SYSTEM_FONT): Define only when used.
7817 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7818
7819 * keymap.c (access_keymap_1): Now static.
7820
7821 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7822
7823 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7824 leave any prefix arg for the up event (Bug#1586).
7825
7826 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7827
7828 * lread.c (syms_of_lread): Mention single symbols defined by
7829 `defvar' or `defconst' (bug#7154).
7830
7831 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7832 (Frequire): Mention get-load-suffixes.
7833
7834 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7835
7836 * window.h (window): Remove clone_number slot.
7837 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7838 Remove.
7839 (make_parent_window, make_window, saved_window)
7840 (Fset_window_configuration, save_window_save): Don't deal with
7841 clone numbers.
7842 * buffer.c (Qclone_number): Remove declaration.
7843 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7844
7845 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7846
7847 Add multiple inheritance to keymaps.
7848 * keymap.c (Fmake_composed_keymap): New function.
7849 (Fset_keymap_parent): Simplify.
7850 (fix_submap_inheritance): Remove.
7851 (access_keymap_1): New function extracted from access_keymap to handle
7852 embedded parents and handle lists of maps.
7853 (access_keymap): Use it.
7854 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7855 (Fcopy_keymap): Handle embedded parents.
7856 (Fcommand_remapping, define_as_prefix): Simplify.
7857 (Fkey_binding): Simplify.
7858 (syms_of_keymap): Move minibuffer-local-completion-map,
7859 minibuffer-local-filename-completion-map,
7860 minibuffer-local-must-match-map, and
7861 minibuffer-local-filename-must-match-map to Elisp.
7862 (syms_of_keymap): Defsubr make-composed-keymap.
7863 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7864 (parse_menu_item): Trivial simplification.
7865
7866 2011-07-01 Glenn Morris <rgm@gnu.org>
7867
7868 * Makefile.in (SETTINGS_LIBS): Fix typo.
7869
7870 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7871
7872 * coding.c (Fencode_coding_string): Record the last coding system
7873 used, as the function doc string says (bug#8738).
7874
7875 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7876
7877 * xsettings.c (store_monospaced_changed): Take new font as arg and
7878 check for change against current_mono_font.
7879 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7880 (emacs_settings_constructor, emacs_settings_get_property)
7881 (emacs_settings_set_property, emacs_settings_class_init)
7882 (emacs_settings_init, gsettings_obj): Remove.
7883 (something_changedCB): New function for HAVE_GSETTINGS.
7884 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7885 with value as argument.
7886 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7887 g_settings_new (Bug#8967). Do not create gsettings_obj.
7888 Remove calls to g_settings_bind. Connect something_changedCB to
7889 "changed".
7890
7891 * xgselect.c: Add defined (HAVE_GSETTINGS).
7892 (xgselect_initialize): Ditto.
7893
7894 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7895 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7896 xg_select.
7897
7898 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7899
7900 * eval.c (struct backtrace): Simplify and port the data structure.
7901 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7902 signed bit field, as this assumption is not portable and it makes
7903 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7904 "char debug_on_exit : 1" as this is not portable either; instead,
7905 use the portable "unsigned int debug_on_exit : 1". Remove unused
7906 member evalargs. Remove obsolete comments about cc bombing out.
7907
7908 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7909
7910 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7911 Let HAVE_GSETTINGS override HAVE_GCONF.
7912 (store_monospaced_changed): New function.
7913 (EMACS_SETTINGS): A new type derived from GObject to handle
7914 GSettings notifications.
7915 (emacs_settings_constructor, emacs_settings_get_property)
7916 (emacs_settings_set_property, emacs_settings_class_init):
7917 New functions.
7918 (gsettings_client, gsettings_obj): New variables.
7919 (GSETTINGS_SCHEMA): New define.
7920 (something_changedCB): Call store_monospaced_changed.
7921 (init_gsettings): New function.
7922 (xsettings_initialize): Call init_gsettings.
7923 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7924 to NULL.
7925
7926 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7927 GCONF_CFLAGS/LIBS.
7928
7929 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7930
7931 * window.c (resize_root_window, grow_mini_window)
7932 (shrink_mini_window): Rename Qresize_root_window to
7933 Qwindow_resize_root_window and Qresize_root_window_vertically to
7934 Qwindow_resize_root_window_vertically.
7935
7936 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7937
7938 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7939
7940 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7941
7942 * makefile.w32-in: Redesign dependencies so they reflect more
7943 clearly which files are directly included by each source file,
7944 and not through other includes.
7945
7946 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7947
7948 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7949 (sort_overlays, overlay_strings): When an overlay's clone number
7950 matches the window's clone number process the overlay even if
7951 the overlay's window property doesn't match the current window.
7952
7953 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7954 (Fwindow_hchild): Rename to Fwindow_left_child.
7955 (Fwindow_next): Rename to Fwindow_next_sibling.
7956 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7957 (resize_window_check): Rename to window_resize_check.
7958 (resize_window_apply): Rename to window_resize_apply.
7959 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7960 (Fdelete_other_windows_internal, resize_frame_windows)
7961 (Fsplit_window_internal, Fdelete_window_internal)
7962 (grow_mini_window, shrink_mini_window)
7963 (Fresize_mini_window_internal): Fix callers accordingly.
7964
7965 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7966
7967 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7968 (emacs_fixed_set_min_size): Remove.
7969 (emacs_fixed_new): Take frame as argument.
7970
7971 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7972 (_EmacsFixedPrivate): Remove minwidth/height.
7973 Add struct frame *f.
7974 (emacs_fixed_init): Initialize priv->f.
7975 (get_parent_class, emacs_fixed_set_min_size): Remove.
7976 (emacs_fixed_new): Set priv->f to argument.
7977 (emacs_fixed_get_preferred_width)
7978 (emacs_fixed_get_preferred_height): Use min_width/height from
7979 frames size_hint to set minimum and natural (Bug#8919).
7980 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7981 and use min_width/height from frames size_hint to set
7982 min_width/height (Bug#8919).
7983
7984 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7985 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7986 Fix indentation.
7987
7988 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7989
7990 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7991 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7992 called at ZV.
7993
7994 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7995
7996 * process.c (wait_reading_process_output): Bypass select if
7997 waiting for a cell while ignoring keyboard input, and input is
7998 pending. Suggested by Jan Djärv (Bug#8869).
7999
8000 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8001
8002 Use gnulib's dup2 module instead of rolling our own.
8003 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8004
8005 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8006
8007 * dispnew.c (scrolling_window): Before scrolling, turn off a
8008 mouse-highlight in the window being scrolled.
8009
8010 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8011
8012 Move DEFSYM to lisp.h and use everywhere.
8013
8014 * character.h (DEFSYM): Move declaration...
8015 * lisp.h (DEFSYM): ...here.
8016
8017 * gnutls.c:
8018 * minibuf.c:
8019 * w32menu.c:
8020 * w32proc.c:
8021 * w32select.c: Don't include character.h.
8022
8023 * alloc.c (syms_of_alloc):
8024 * buffer.c (syms_of_buffer):
8025 * bytecode.c (syms_of_bytecode):
8026 * callint.c (syms_of_callint):
8027 * casefiddle.c (syms_of_casefiddle):
8028 * casetab.c (init_casetab_once):
8029 * category.c (init_category_once, syms_of_category):
8030 * ccl.c (syms_of_ccl):
8031 * cmds.c (syms_of_cmds):
8032 * composite.c (syms_of_composite):
8033 * dbusbind.c (syms_of_dbusbind):
8034 * dired.c (syms_of_dired):
8035 * dispnew.c (syms_of_display):
8036 * doc.c (syms_of_doc):
8037 * editfns.c (syms_of_editfns):
8038 * emacs.c (syms_of_emacs):
8039 * eval.c (syms_of_eval):
8040 * fileio.c (syms_of_fileio):
8041 * fns.c (syms_of_fns):
8042 * frame.c (syms_of_frame):
8043 * fringe.c (syms_of_fringe):
8044 * insdel.c (syms_of_insdel):
8045 * keymap.c (syms_of_keymap):
8046 * lread.c (init_obarray, syms_of_lread):
8047 * macros.c (syms_of_macros):
8048 * msdos.c (syms_of_msdos):
8049 * print.c (syms_of_print):
8050 * process.c (syms_of_process):
8051 * search.c (syms_of_search):
8052 * sound.c (syms_of_sound):
8053 * syntax.c (init_syntax_once, syms_of_syntax):
8054 * terminal.c (syms_of_terminal):
8055 * textprop.c (syms_of_textprop):
8056 * undo.c (syms_of_undo):
8057 * w32.c (globals_of_w32):
8058 * window.c (syms_of_window):
8059 * xdisp.c (syms_of_xdisp):
8060 * xfaces.c (syms_of_xfaces):
8061 * xfns.c (syms_of_xfns):
8062 * xmenu.c (syms_of_xmenu):
8063 * xsettings.c (syms_of_xsettings):
8064 * xterm.c (syms_of_xterm): Use DEFSYM.
8065
8066 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8067
8068 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8069
8070 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8071
8072 Integer and buffer overflow fixes (Bug#8873).
8073
8074 * print.c (printchar, strout): Check for string overflow.
8075 (PRINTPREPARE, printchar, strout):
8076 Don't set size unless allocation succeeds.
8077
8078 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8079 for sizes. Check for string overflow more accurately.
8080 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8081
8082 * macros.c: Integer and buffer overflow fixes.
8083 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8084 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8085 Use ptrdiff_t, not int, for sizes.
8086 Don't increment bufsize until after realloc succeeds.
8087 Check for size-calculation overflow.
8088 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8089
8090 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8091
8092 * lread.c: Integer overflow fixes.
8093 (read_integer): Radix is now EMACS_INT, not int,
8094 to improve quality of diagnostics for out-of-range radices.
8095 Calculate buffer size correctly for out-of-range radices.
8096 (read1): Check for integer overflow in radices, and in
8097 read-circle numbers.
8098 (read_escape): Avoid int overflow.
8099 (Fload, openp, read_buffer_size, read1)
8100 (substitute_object_recurse, read_vector, read_list, map_obarray):
8101 Use ptrdiff_t, not int, for sizes.
8102 (read1): Use EMACS_INT, not int, for sizes.
8103 Check for size overflow.
8104
8105 * image.c (cache_image): Check for size arithmetic overflow.
8106
8107 * lread.c: Integer overflow issues.
8108 (saved_doc_string_size, saved_doc_string_length)
8109 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8110 Now ptrdiff_t, not int.
8111 (read1): Don't assume doc string length fits in int. Check for
8112 out-of-range doc string lengths.
8113 (read_list): Don't assume file position fits in int.
8114 (read_escape): Check for hex character overflow.
8115
8116 2011-06-22 Leo Liu <sdl.web@gmail.com>
8117
8118 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8119 Move to minibuffer.el.
8120
8121 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8122
8123 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8124 The following patches are for when GLYPH_DEBUG && !XASSERT.
8125 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8126 * dispnew.c (flush_stdout):
8127 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8128 Mark as externally visible.
8129 * dispnew.c (check_window_matrix_pointers): Now static.
8130 * dispnew.c (window_to_frame_vpos):
8131 * xfns.c (unwind_create_frame):
8132 * xterm.c (x_check_font): Remove unused local.
8133 * scroll.c (CHECK_BOUNDS):
8134 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8135 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8136 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8137 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8138 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8139 Now static.
8140 (debug_method_add): Use va_list and vsprintf rather than relying
8141 on undefined behavior with wrong number of arguments.
8142 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8143 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8144 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8145 since we're not interested in debugging glyphs with old libraries.
8146 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8147 GCC 4.6.0's static checking.
8148
8149 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8150
8151 Integer overflow and signedness fixes (Bug#8873).
8152 A few related buffer overrun fixes, too.
8153
8154 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8155
8156 * dispextern.h (struct face.stipple):
8157 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8158 (x_bitmap_mask, x_allocate_bitmap_record)
8159 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8160 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8161 (x_create_bitmap_from_xpm_data):
8162 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8163 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8164 (.bitmaps_last):
8165 * xfaces.c (load_pixmap):
8166 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8167 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8168 (.bitmaps_last, struct x_output.icon_bitmap):
8169 Use ptrdiff_t, not int, for bitmap indexes.
8170 (x_allocate_bitmap_record): Check for size overflow.
8171 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8172
8173 Use ptrdiff_t, not int, for overlay counts.
8174 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8175 * editfns.c (overlays_around, get_pos_property):
8176 * textprop.c (get_char_property_and_overlay):
8177 * xdisp.c (next_overlay_change, note_mouse_highlight):
8178 * xfaces.c (face_at_buffer_position):
8179 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8180 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8181 (Fnext_overlay_change, Fprevious_overlay_change)
8182 (mouse_face_overlay_overlaps, Foverlays_in):
8183 Use ptrdiff_t, not int, for sizes.
8184 (overlays_at, overlays_in): Check for size-calculation overflow.
8185
8186 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8187
8188 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8189 (x_session_initialize): Do not assume string length fits in int.
8190
8191 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8192 This is unlikely, but can occur if DPI is outlandish.
8193
8194 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8195 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8196
8197 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8198 * xrdb.c (magic_file_p, search_magic_path):
8199 Omit last arg SUFFIX; it was always 0. All callers changed.
8200 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8201
8202 * xfont.c (xfont_match): Avoid need for strlen.
8203
8204 * xfns.c: Don't assume strlen fits in int.
8205 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8206
8207 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8208 not unsigned long, as we prefer signed integers. All callers changed.
8209 Detect integer overflow in repeat count.
8210 (message_dolog): Don't assume print length fits in 39 bytes.
8211 (display_mode_element): Don't assume strlen fits in int.
8212
8213 * termcap.c: Don't assume sizes fit in int and never overflow.
8214 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8215 (gobble_line): Check for size-calculation overflow.
8216
8217 * minibuf.c (Fread_buffer):
8218 * lread.c (intern, intern_c_string):
8219 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8220 Don't assume string length fits in int.
8221
8222 * keyboard.c (parse_tool_bar_item):
8223 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8224
8225 * font.c: Don't assume string length fits in int.
8226 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8227 Use ptrdiff_t, not int.
8228 (font_intern_prop): Don't assume string length fits in int.
8229 Don't assume integer property fits in fixnum.
8230 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8231
8232 * filelock.c: Fix some buffer overrun and integer overflow issues.
8233 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8234 Reformulate so as not to need the command string.
8235 Invoke gzip -cd rather than gunzip, as it's more portable.
8236 (lock_info_type, lock_file_1, lock_file):
8237 Don't assume pid_t and time_t fit in unsigned long.
8238 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8239 (current_lock_owner): Prefer signed type for sizes.
8240 Use memcpy, not strncpy, where memcpy is what is really wanted.
8241 Don't assume (via atoi) that time_t and pid_t fit in int.
8242 Check for time_t and/or pid_t out of range, e.g., via a network share.
8243 Don't alloca where an auto var works fine.
8244
8245 * fileio.c: Fix some integer overflow issues.
8246 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8247 Don't assume string length fits in int.
8248 (directory_file_name): Don't assume string length fits in long.
8249 (make_temp_name): Don't assume pid fits in int, or that its print
8250 length is less than 20.
8251
8252 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8253
8254 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8255
8256 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8257
8258 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8259 We prefer signed integers, even for size calculations.
8260
8261 * emacs.c: Don't assume string length fits in 'int'.
8262 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8263 (main): Don't invoke strlen when not needed.
8264
8265 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8266 (XD_DEBUG_MESSAGE): Don't waste a byte.
8267
8268 * callproc.c (getenv_internal_1, getenv_internal)
8269 (Fgetenv_internal):
8270 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8271
8272 * lread.c (invalid_syntax): Omit length argument.
8273 All uses changed. This doesn't fix a bug, but it simplifies the
8274 code away from its former Hollerith-constant appearance, and it's
8275 one less 'int' to worry about when looking at integer-overflow issues.
8276 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8277
8278 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8279 This didn't break anything, but it didn't help either.
8280 It's confusing to put a bogus integer in a place where the actual
8281 value does not matter.
8282 (LIST_END_P): Remove unused macro and its bogus comment.
8283 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8284
8285 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8286 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8287 implementation.
8288 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8289 We prefer signed types, and the value cannot exceed the EMACS_INT
8290 range anyway (because otherwise the length would not be representable).
8291 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8292 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8293 This avoids a GCC warning when WIDE_EMACS_INT.
8294
8295 * indent.c (sane_tab_width): New function.
8296 (current_column, scan_for_column, Findent_to, position_indentation)
8297 (compute_motion): Use it. This is just for clarity.
8298 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8299
8300 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8301
8302 * lisp.h (lint_assume): New macro.
8303 * composite.c (composition_gstring_put_cache):
8304 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8305
8306 * editfns.c, insdel.c:
8307 Omit unnecessary forward decls, to simplify future changes.
8308
8309 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8310
8311 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8312
8313 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8314 Use much-faster test for byte-length change.
8315 Don't assume string byte-length fits in 'int'.
8316 Check that character arg fits in 'int'.
8317 (mapcar1): Declare byte as byte, for clarity.
8318
8319 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8320
8321 * fns.c (concat): Catch string overflow earlier.
8322 Do not rely on integer wraparound.
8323
8324 * dispextern.h (struct it.overlay_strings_charpos)
8325 (struct it.selective): Now EMACS_INT, not int.
8326 * xdisp.c (forward_to_next_line_start)
8327 (back_to_previous_visible_line_start)
8328 (reseat_at_next_visible_line_start, next_element_from_buffer):
8329 Don't arbitrarily truncate the value of 'selective' to int.
8330
8331 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8332
8333 * composite.c: Don't truncate sizes to 'int'.
8334 (composition_gstring_p, composition_reseat_it)
8335 (composition_adjust_point): Use EMACS_INT, not int.
8336 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8337 not EMACS_UINT, for indexes.
8338
8339 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8340
8341 * buffer.c: Include <verify.h>.
8342 (struct sortvec.priority, struct sortstr.priority):
8343 Now EMACS_INT, not int.
8344 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8345 (struct sortstr.size, record_overlay_string)
8346 (struct sortstrlist.size, struct sortlist.used):
8347 Don't truncate size to int.
8348 (record_overlay_string): Check for size-calculation overflow.
8349 (init_buffer_once): Check at compile-time, not run-time.
8350
8351 2011-06-22 Jim Meyering <meyering@redhat.com>
8352
8353 Don't leak an XBM-image-sized buffer
8354 * image.c (xbm_load): Free the image buffer after using it.
8355
8356 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8357
8358 Port to Sun C.
8359 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8360 that Sun C diagnosed.
8361 * fns.c (secure_hash): Fix pointer signedness issue.
8362 * intervals.c (static_offset_intervals): New function.
8363 (offset_intervals): Use it.
8364
8365 2011-06-21 Leo Liu <sdl.web@gmail.com>
8366
8367 * deps.mk (fns.o):
8368 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8369 sha512.h.
8370
8371 * fns.c (secure_hash): Rename from crypto_hash_function and change
8372 the first arg to accept symbols.
8373 (Fsecure_hash): New primitive.
8374 (syms_of_fns): New symbols.
8375
8376 2011-06-20 Deniz Dogan <deniz@dogan.se>
8377
8378 * process.c (Fset_process_buffer): Clarify return value in
8379 docstring.
8380
8381 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8382
8383 * dispnew.c (add_window_display_history): Use BVAR.
8384
8385 * xdisp.c (debug_method_add): Use BVAR.
8386 (check_window_end, dump_glyph_matrix, dump_glyph)
8387 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8388
8389 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8390 Likewise.
8391
8392 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8393 check till after the cache is created in init_frame_faces.
8394
8395 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8396
8397 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8398
8399 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8400
8401 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8402 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8403 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8404
8405 Improve buffer-overflow checking (Bug#8873).
8406 * fileio.c (Finsert_file_contents):
8407 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8408 Remove the old (too-loose) buffer overflow checks.
8409 They weren't needed, since make_gap checks for buffer overflow.
8410 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8411 The old code merely checked for Emacs fixnum overflow, and relied
8412 on undefined (wraparound) behavior. The new code avoids undefined
8413 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8414
8415 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8416 Tune. Don't use wider integers than needed. Don't use alloca.
8417 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8418
8419 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8420
8421 * insdel.c, lisp.h (buffer_overflow): New function.
8422 (insert_from_buffer_1, replace_range, replace_range_2):
8423 * insdel.c (make_gap_larger):
8424 * editfns.c (Finsert_char):
8425 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8426
8427 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8428
8429 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8430
8431 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8432
8433 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8434 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8435
8436 * fileio.c: Don't assume EMACS_INT fits in off_t.
8437 (emacs_lseek): New static function.
8438 (Finsert_file_contents, Fwrite_region): Use it.
8439 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8440
8441 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8442
8443 * fns.c: Don't overflow int when computing a list length.
8444 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8445 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8446 truncation on 64-bit hosts. Check for QUIT every
8447 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8448 faster and is responsive enough.
8449 (Flength): Report an error instead of overflowing an integer.
8450 (Fsafe_length): Return a float if the value is not representable
8451 as a fixnum. This shouldn't happen except in contrived situations.
8452 (Fnthcdr, Fsort): Don't assume list length fits in int.
8453 (Fcopy_sequence): Don't assume vector length fits in int.
8454
8455 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8456 (header_size, word_size): New constants.
8457 (allocate_vectorlike): Don't check size overflow here.
8458 (allocate_vector): Check it here instead, since this is the only
8459 caller of allocate_vectorlike that could cause overflow.
8460 Check that the new vector's length is representable as a fixnum.
8461
8462 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8463 The previous code was bogus. For example, next_almost_prime (32)
8464 returned 39, which is undesirable as it is a multiple of 3; and
8465 next_almost_prime (24) returned 25, which is a multiple of 5 so
8466 why was the code bothering to check for multiples of 7?
8467
8468 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8469
8470 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8471
8472 Variadic C functions now count arguments with ptrdiff_t.
8473 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8474 Back then I didn't know that the Emacs coding style prefers signed int.
8475 Also, in the meantime I found a few more instances where arguments
8476 were being counted with int, which may truncate counts on 64-bit
8477 machines, or EMACS_INT, which may be unnecessarily wide.
8478 * lisp.h (struct Lisp_Subr.function.aMANY)
8479 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8480 Arg counts are now ptrdiff_t, not size_t.
8481 All variadic functions and their callers changed accordingly.
8482 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8483 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8484 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8485 * callint.c (Fcall_interactively): Check arg count for overflow,
8486 to avoid potential buffer overrun. Use signed char, not 'int',
8487 for 'varies' array, so that we needn't bother to check its size
8488 calculation for overflow.
8489 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8490 * eval.c (apply_lambda):
8491 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8492 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8493 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8494
8495 * callint.c (Fcall_interactively): Don't use index var as event count.
8496
8497 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8498 * mem-limits.h (SIZE): Remove; no longer used.
8499
8500 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8501
8502 Remove unnecessary casts.
8503 * xterm.c (x_term_init):
8504 * xfns.c (x_set_border_pixel):
8505 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8506 These aren't needed now that we assume ANSI C.
8507
8508 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8509 It's more likely to cause problems (due to unsigned overflow)
8510 than to cure them.
8511
8512 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8513
8514 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8515
8516 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8517
8518 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8519
8520 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8521
8522 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8523
8524 GLYPH_CODE_FACE returns EMACS_INT, not int.
8525 * dispextern.h (merge_faces):
8526 * xfaces.c (merge_faces):
8527 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8528 Don't assume EMACS_INT fits in int.
8529
8530 * character.h (CHAR_VALID_P): Remove unused parameter.
8531 * fontset.c, lisp.h, xdisp.c: All uses changed.
8532
8533 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8534
8535 * fns.c (concat): Minor tuning based on overflow analysis.
8536 This doesn't fix any bugs. Use int to hold character, instead
8537 of constantly refetching from Emacs object. Use XFASTINT, not
8538 XINT, for value known to be a character. Don't bother comparing
8539 a single byte to 0400, as it's always less.
8540
8541 * floatfns.c (Fexpt):
8542 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8543
8544 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8545 for characters.
8546
8547 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8548
8549 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8550 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8551 incorrectly succeed when S was a string, because 4294967386 was
8552 truncated before it was used.
8553
8554 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8555 Otherwise, an out-of-range integer could cause undefined behavior
8556 on a 64-bit host.
8557
8558 * composite.c: Use int, not EMACS_INT, for characters.
8559 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8560 EMACS_INT, for values that are known to be in character range.
8561 This doesn't fix any bugs but is the usual style inside Emacs and
8562 may generate better code on 32-bit machines.
8563
8564 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8565 This is for reasons similar to the recent CHAR_STRING fix.
8566 * charset.c (Fencode_char): Check that character arg is actually
8567 a character. Pass an int to ENCODE_CHAR.
8568 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8569 wider than 'int', as a compile-time check to prevent future regressions
8570 in this area.
8571
8572 * character.c (char_string): Remove unnecessary casts.
8573
8574 Make sure a 64-bit char is never passed to CHAR_STRING.
8575 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8576 by silently ignoring the top 32 bits, allowing some values
8577 that were far too large to be valid characters.
8578 * character.h: Include <verify.h>.
8579 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8580 arguments are no wider than unsigned, as a compile-time check
8581 to prevent future regressions in this area.
8582 * data.c (Faset):
8583 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8584 (Fsubst_char_in_region):
8585 * fns.c (concat):
8586 * xdisp.c (decode_mode_spec_coding):
8587 Adjust to CHAR_STRING's new requirement.
8588 * editfns.c (Finsert_char, Fsubst_char_in_region):
8589 * fns.c (concat): Check that character args are actually
8590 characters. Without this test, these functions did the wrong
8591 thing with wildly out-of-range values on 64-bit hosts.
8592
8593 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8594 These casts should not be needed on 32-bit hosts, either.
8595 * keyboard.c (read_char):
8596 * lread.c (Fload): Remove casts to unsigned.
8597
8598 * lisp.h (UNSIGNED_CMP): New macro.
8599 This fixes comparison bugs on 64-bit hosts.
8600 (ASCII_CHAR_P): Use it.
8601 * casefiddle.c (casify_object):
8602 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8603 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8604 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8605 * dispextern.h (FACE_FROM_ID):
8606 * keyboard.c (read_char): Use UNSIGNED_CMP.
8607
8608 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8609 not to EMACS_INT, to avoid GCC warning.
8610
8611 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8612
8613 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8614 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8615 isn't needed on 32-bit machines.
8616
8617 * buffer.c (Fgenerate_new_buffer_name):
8618 Use EMACS_INT for count, not int.
8619 (advance_to_char_boundary): Return EMACS_INT, not int.
8620
8621 * data.c (Qcompiled_function): Now static.
8622
8623 * window.c (window_body_lines): Now static.
8624
8625 * image.c (gif_load): Rename local to avoid shadowing.
8626
8627 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8628 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8629 * alloc.c (make_save_value): Integer argument is now of type
8630 ptrdiff_t, not int.
8631 (mark_object): Use ptrdiff_t, not int.
8632 * lisp.h (pD): New macro.
8633 * print.c (print_object): Use it.
8634
8635 * alloc.c: Use EMACS_INT, not int, to count objects.
8636 (total_conses, total_markers, total_symbols, total_vector_size)
8637 (total_free_conses, total_free_markers, total_free_symbols)
8638 (total_free_floats, total_floats, total_free_intervals)
8639 (total_intervals, total_strings, total_free_strings):
8640 Now EMACS_INT, not int. All uses changed.
8641 (Fgarbage_collect): Compute overall total using a double, so that
8642 integer overflow is less likely to be a problem. Check for overflow
8643 when converting back to an integer.
8644 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8645 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8646 These were 'int' variables that could overflow on 64-bit hosts;
8647 they were never used, so remove them instead of repairing them.
8648 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8649 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8650 Previously, this ceilinged at INT_MAX, but that doesn't work on
8651 64-bit machines.
8652 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8653
8654 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8655 (allocate_vectorlike): Check for ptrdiff_t overflow.
8656 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8657 when a (possibly-narrower) signed value would do just as well.
8658 We prefer using signed arithmetic, to avoid comparison confusion.
8659
8660 * alloc.c: Catch some string size overflows that we were missing.
8661 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8662 for convenience in STRING_BYTES_MAX.
8663 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8664 The definition here is exact; the one in lisp.h was approximate.
8665 (allocate_string_data): Check for string overflow. This catches
8666 some instances we weren't catching before. Also, it catches
8667 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8668 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8669 and ptrdiff_t and EMACS_INT are both 64 bits.
8670
8671 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8672 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8673 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8674
8675 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8676
8677 * alloc.c (Fmake_string): Check for out-of-range init.
8678
8679 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8680
8681 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8682
8683 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8684
8685 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8686 xg_get_default_scrollbar_width.
8687
8688 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8689 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8690 (style_changed_cb): Call update_theme_scrollbar_width and call
8691 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8692 all frames (Bug#8505).
8693 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8694 Call gtk_window_set_resizable if HAVE_GTK3.
8695 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8696 and height if HAVE_GTK3 (Bug#8505).
8697 (scroll_bar_width_for_theme): New variable.
8698 (update_theme_scrollbar_width): New function.
8699 (xg_get_default_scrollbar_width): Move code to
8700 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8701 (xg_initialize): Call update_theme_scrollbar_width.
8702
8703 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8704
8705 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8706
8707 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8708
8709 * frame.c (make_frame): Call other_buffer_safely instead of
8710 other_buffer.
8711
8712 * window.c (temp_output_buffer_show): Call display_buffer with
8713 second argument Vtemp_buffer_show_specifiers and reset latter
8714 immediately after the call.
8715 (Vtemp_buffer_show_specifiers): New variable.
8716 (auto_window_vscroll_p, next_screen_context_lines)
8717 (Vscroll_preserve_screen_position): Remove leading asterisks from
8718 doc-strings.
8719
8720 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8721
8722 Fix minor problems found by GCC 4.6.0 static checking.
8723 * buffer.c (Qclone_number): Remove for now, as it's unused.
8724 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8725 (record_buffer): Remove unused local.
8726 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8727 (set_frame_buffer_list): Remove; unused.
8728 * frame.h (other_visible_frames): Remove decl.
8729 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8730 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8731 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8732 if HAVE_GPM.
8733 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8734 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8735 Define only if HAVE_GPM.
8736 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8737 (update_hints_inhibit): Remove; never set. All uses removed.
8738 * widgetprv.h (emacsFrameClassRec): Remove decl.
8739 * window.c (delete_deletable_window): Now returns void, since it
8740 wasn't returning anything.
8741 (compare_window_configurations): Remove unused locals.
8742 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8743 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8744 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8745 the same widths as pointers. This follows up on the 2011-05-06 patch.
8746 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8747 * xterm.h: Likewise.
8748 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8749
8750 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8751
8752 * makefile.w32-in: Update dependencies.
8753 (LISP_H): Add lib/intprops.h.
8754
8755 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8756
8757 * image.c (gif_load): Add animation frame delay to the metadata.
8758 (syms_of_image): Use DEFSYM. New symbol `delay'.
8759
8760 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8761
8762 * window.c (delete_deletable_window): Re-add.
8763 (Fset_window_configuration): Rewrite to handle dead buffers and
8764 consequently deletable windows.
8765 (window_tree, Fwindow_tree): Remove. Supply functionality in
8766 window.el.
8767 (compare_window_configurations): Simplify code.
8768
8769 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8770
8771 * image.c (imagemagick_load_image): Fix type mismatch.
8772 (Fimagemagick_types): Likewise.
8773
8774 * window.h (replace_buffer_in_windows): Declare.
8775
8776 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8777
8778 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8779 Qclone_number. Remove external declaration of Qdelete_window.
8780 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8781 code.
8782 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8783 Run Qbuffer_list_update_hook if allowed.
8784 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8785 buffer list implementation.
8786 (other_buffer_safely): New function.
8787 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8788 calls to replace_buffer_in_windows and
8789 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8790 if allowed.
8791 (record_buffer): Inhibit quitting and rewrite using quittable
8792 functions. Run Qbuffer_list_update_hook if allowed.
8793 (Frecord_buffer, Funrecord_buffer): New functions.
8794 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8795 Move switch-to-buffer to window.el.
8796 (bury-buffer): Move to window.el.
8797 (Vbuffer_list_update_hook): New variable.
8798
8799 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8800 section.
8801
8802 * window.h (resize_frame_windows): Move up in code.
8803 (Fwindow_frame): Remove EXFUN.
8804 (replace_buffer_in_all_windows): Remove prototype.
8805 (replace_buffer_in_windows_safely): Add prototype.
8806
8807 * window.c: Declare Qdelete_window static again. Move down
8808 declaration of select_count.
8809 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8810 (Fother_window): Move to window.el.
8811 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8812 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8813 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8814 window.el.
8815 (replace_buffer_in_windows): Implement by calling
8816 Qreplace_buffer_in_windows.
8817 (replace_buffer_in_all_windows): Remove with some functionality
8818 moved into replace_buffer_in_windows_safely.
8819 (replace_buffer_in_windows_safely): New function.
8820 (select_window_norecord, select_frame_norecord): Move in front
8821 of run_window_configuration_change_hook. Remove now obsolete
8822 declarations.
8823 (Fset_window_buffer): Rewrite doc-string.
8824 Call Qrecord_window_buffer.
8825 (keys_of_window): Move binding for other-window to window.el.
8826
8827 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8828
8829 * dispextern.h (struct image): Replace data member, whose int_val
8830 and ptr_val fields were not used by anything, with a single
8831 lisp_val object.
8832
8833 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8834 (gif_clear_image, gif_load, imagemagick_load_image)
8835 (gs_clear_image, gs_load): Callers changed.
8836
8837 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8838
8839 * buffer.h: Include <time.h>, for time_t.
8840 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8841
8842 Fix minor problems found by static checking.
8843
8844 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8845
8846 Make identifiers static if they are not used in other modules.
8847 * data.c (Qcompiled_function, Qframe, Qvector):
8848 * image.c (QimageMagick, Qsvg):
8849 * minibuf.c (Qmetadata):
8850 * window.c (resize_window_check, resize_root_window): Now static.
8851 * window.h (resize_window_check, resize_root_window): Remove decls.
8852
8853 * window.c (window_deletion_count, delete_deletable_window):
8854 Remove; unused.
8855 (window_body_lines): Now static.
8856 (Fdelete_other_windows_internal): Mark vars as initialized.
8857 Make sure 'resize_failed' is initialized.
8858 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8859 (resize_window_apply): Remove unused local.
8860 * window.h (delete_deletable_window): Remove decl.
8861
8862 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8863 (imagemagick_load_image): Fix pointer signedness problem by changing
8864 last arg from unsigned char * to char *. All uses changed.
8865 Also, fix a local for similar reasons.
8866 Remove unused locals. Remove locals to avoid shadowing.
8867 (fn_rsvg_handle_free): Remove; unused.
8868 (svg_load, svg_load_image): Fix pointer signedness problem.
8869 (imagemagick_load_image): Don't use garbage pointer image_wand.
8870
8871 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8872
8873 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8874
8875 * image.c (gif_load): Fix omitted cast error introduced by
8876 2011-06-06 change.
8877
8878 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8879
8880 * window.h (resize_proportionally, orig_total_lines)
8881 (orig_top_line): Remove from window structure.
8882 (set_window_height, set_window_width, change_window_heights)
8883 (Fdelete_window): Remove prototypes.
8884 (resize_frame_windows): Remove duplicate declaration.
8885
8886 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8887
8888 * window.h (resize_frame_windows, resize_window_check)
8889 (delete_deletable_window, resize_root_window)
8890 (resize_frame_windows): Declare prototypes.
8891
8892 * window.c (resize_window_apply): Make definition be "static" to
8893 match the prototype.
8894
8895 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8896
8897 * window.c: Remove declarations of Qwindow_size_fixed,
8898 window_min_size_1, window_min_size_2, window_min_size,
8899 size_window, window_fixed_size_p, enlarge_window, delete_window.
8900 Remove static from declaration of Qdelete_window, it's
8901 temporarily needed by Fbury_buffer.
8902 (replace_window): Don't assign orig_top_line and
8903 orig_total_lines.
8904 (Fdelete_window, delete_window): Remove. Window deletion is
8905 handled by window.el.
8906 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8907 Replace Fdelete_window calls with calls to Qdelete_window.
8908 (Fdelete_other_windows): Remove. Deleting other windows is
8909 handled by window.el.
8910 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8911 handled in window.el.
8912 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8913 Window minimum sizes are handled in window.el.
8914 (shrink_windows, size_window, set_window_height)
8915 (set_window_width, change_window_heights, window_height)
8916 (window_width, CURBEG, CURSIZE, enlarge_window)
8917 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8918 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8919 handled in window.el.
8920 (make_dummy_parent): Rename to make_parent_window and give it a
8921 second argument horflag.
8922 (make_window): Don't set resize_proportionally any more.
8923 (Fsplit_window): Remove. Windows are split in window.el.
8924 (save_restore_action, save_restore_orig_size)
8925 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8926 Resize mini windows in window.el.
8927 (grow_mini_window, shrink_mini_window): Implement by calling
8928 Qresize_root_window_vertically, resize_window_check and
8929 resize_window_apply.
8930 (saved_window, Fset_window_configuration, save_window_save):
8931 Do not handle orig_top_line, orig_total_lines, and
8932 resize_proportionally.
8933 (window_min_height, window_min_width): Move to window.el.
8934 (keys_of_window): Move bindings for delete-other-windows,
8935 split-window, delete-window and enlarge-window to window.el.
8936
8937 * buffer.c: Temporarily extern Qdelete_window.
8938 (Fbury_buffer): Temporarily call Qdelete_window instead of
8939 Fdelete_window (Fbury_buffer will move to window.el soon).
8940
8941 * frame.c (set_menu_bar_lines_1): Remove code handling
8942 orig_top_line and orig_total_lines.
8943
8944 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8945 set_window_height but set heights directly.
8946 (change_frame_size_1): Use resize_frame_windows.
8947
8948 * xdisp.c (init_xdisp): Don't use set_window_height but set
8949 heights directly.
8950
8951 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8952 Use resize_frame_windows instead of change_window_heights and run
8953 run_window_configuration_change_hook.
8954
8955 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8956 instead of change_window_heights and run
8957 run_window_configuration_change_hook.
8958
8959 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8960
8961 * window.c (replace_window): Rename second argument REPLACEMENT to
8962 NEW. New third argument SETFLAG. Rewrite.
8963 (delete_window, make_dummy_parent): Call replace_window with
8964 third argument 1.
8965 (window_list_1): Move down in code.
8966 (run_window_configuration_change_hook): Move set_buffer part
8967 before select_frame_norecord part in order to unwind correctly.
8968 Rename count1 to count.
8969 (recombine_windows, delete_deletable_window, resize_root_window)
8970 (Fdelete_other_windows_internal)
8971 (Frun_window_configuration_change_hook, make_parent_window)
8972 (resize_window_check, resize_window_apply, Fresize_window_apply)
8973 (resize_frame_windows, Fsplit_window_internal)
8974 (Fdelete_window_internal, Fresize_mini_window_internal):
8975 New functions.
8976 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8977
8978 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8979
8980 * window.h (window): Add some new members to window structure -
8981 normal_lines, normal_cols, new_total, new_normal, clone_number,
8982 splits, nest, prev_buffers, next_buffers.
8983 (WINDOW_TOTAL_SIZE): Move here from window.c.
8984 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8985
8986 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8987 Remove.
8988 (make_dummy_parent): Set new members of windows structure.
8989 (make_window): Move down in code. Handle new members of window
8990 structure.
8991 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8992 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8993 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8994 (Fset_window_prev_buffers, Fwindow_next_buffers)
8995 (Fset_window_next_buffers, Fset_window_clone_number):
8996 New functions.
8997 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8998 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8999 Doc-string fixes.
9000 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9001 Argument WINDOW can be now internal window too.
9002 (Fwindow_use_time): Move up in code.
9003 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9004 Rewrite doc-string.
9005 (Fset_window_configuration, saved_window)
9006 (Fcurrent_window_configuration, save_window_save): Handle new
9007 members of window structure.
9008 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9009 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9010 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9011 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9012 Qget_mru_window, Qresize_root_window,
9013 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9014 Qauto_buffer_name; staticpro them.
9015
9016 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9017
9018 * window.c (Fwindow_total_size, Fwindow_left_column)
9019 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9020 (Fwindow_list_1): New functions.
9021 (window_box_text_cols): Replace with window_body_cols.
9022 (Fwindow_width, Fscroll_left, Fscroll_right):
9023 Use window_body_cols instead of window_box_text_cols.
9024 (delete_window, Fset_window_configuration):
9025 Call delete_all_subwindows with window as argument.
9026 (delete_all_subwindows): Take a window as argument and not a
9027 structure. Rewrite.
9028 (window_loop): Remove handling of GET_LRU_WINDOW and
9029 GET_LARGEST_WINDOW.
9030 (Fget_lru_window, Fget_largest_window): Move to window.el.
9031
9032 * window.h: Extern window_body_cols instead of
9033 window_box_text_cols. delete_all_subwindows now takes a
9034 Lisp_Object as argument.
9035
9036 * indent.c (compute_motion, Fcompute_motion):
9037 Use window_body_cols instead of window_box_text_cols.
9038
9039 * frame.c (delete_frame): Call delete_all_subwindows with root
9040 window as argument.
9041
9042 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9043
9044 * fns.c (Fputhash): Document return value.
9045
9046 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9047
9048 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9049
9050 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9051
9052 Cons<->int and similar integer overflow fixes (Bug#8794).
9053
9054 Check for overflow when converting integer to cons and back.
9055 * charset.c (Fdefine_charset_internal, Fdecode_char):
9056 Use cons_to_unsigned to catch overflow.
9057 (Fencode_char): Use INTEGER_TO_CONS.
9058 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9059 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9060 * data.c (long_to_cons, cons_to_long): Remove.
9061 (cons_to_unsigned, cons_to_signed): New functions.
9062 These signal an error for invalid or out-of-range values.
9063 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9064 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9065 * font.c (Ffont_variation_glyphs):
9066 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9067 * lisp.h: Include <intprops.h>.
9068 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9069 (cons_to_signed, cons_to_unsigned): New decls.
9070 (long_to_cons, cons_to_long): Remove decls.
9071 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9072 (Fprimitive_undo): Use CONS_TO_INTEGER.
9073 * xfns.c (Fx_window_property): Likewise.
9074 * xselect.c: Include <limits.h>.
9075 (x_own_selection, selection_data_to_lisp_data):
9076 Use INTEGER_TO_CONS.
9077 (x_handle_selection_request, x_handle_selection_clear)
9078 (x_get_foreign_selection, Fx_disown_selection_internal)
9079 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9080 (lisp_data_to_selection_data): Use cons_to_unsigned.
9081 (x_fill_property_data): Use cons_to_signed.
9082 Report values out of range.
9083
9084 Check for buffer and string overflow more precisely.
9085 * buffer.h (BUF_BYTES_MAX): New macro.
9086 * lisp.h (STRING_BYTES_MAX): New macro.
9087 * alloc.c (Fmake_string):
9088 * character.c (string_escape_byte8):
9089 * coding.c (coding_alloc_by_realloc):
9090 * doprnt.c (doprnt):
9091 * editfns.c (Fformat):
9092 * eval.c (verror):
9093 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9094 since they may not be the same number.
9095 * editfns.c (Finsert_char):
9096 * fileio.c (Finsert_file_contents):
9097 Likewise for BUF_BYTES_MAX.
9098
9099 * image.c: Use ptrdiff_t, not int, for sizes.
9100 (slurp_file): Switch from int to ptrdiff_t.
9101 All uses changed.
9102 (slurp_file): Check that file size fits in both size_t (for
9103 malloc) and ptrdiff_t (for sanity and safety).
9104
9105 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9106 if b->modtime has its maximal value.
9107
9108 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9109
9110 Don't assume time_t can fit into int.
9111 * buffer.h (struct buffer.modtime): Now time_t, not int.
9112 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9113 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9114
9115 Minor fixes for signed vs unsigned integers.
9116 * character.h (MAYBE_UNIFY_CHAR):
9117 * charset.c (maybe_unify_char):
9118 * keyboard.c (read_char, reorder_modifiers):
9119 XINT -> XFASTINT, since the integer must be nonnegative.
9120 * ftfont.c (ftfont_spec_pattern):
9121 * keymap.c (access_keymap, silly_event_symbol_error):
9122 XUINT -> XFASTINT, since the integer must be nonnegative.
9123 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9124 since it makes no difference and we prefer signed.
9125 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9126 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9127 nonnegative.
9128
9129 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9130
9131 * window.h (Fwindow_frame): Declare.
9132
9133 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9134
9135 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9136 (SPARE_MEMORY): Always define.
9137 (LARGE_REQUEST): Remove.
9138 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9139
9140 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9141
9142 * lisp.h: Move EXFUNS for Fframe_root_window,
9143 Fframe_first_window and Fset_frame_selected_window to window.h.
9144
9145 * window.h: Move EXFUNS for Fframe_root_window,
9146 Fframe_first_window and Fset_frame_selected_window here from
9147 lisp.h.
9148
9149 * frame.c (Fwindow_frame, Fframe_first_window)
9150 (Fframe_root_window, Fframe_selected_window)
9151 (Fset_frame_selected_window): Move to window.c.
9152 (Factive_minibuffer_window): Move to minibuf.c.
9153 (Fother_visible_frames_p): New function.
9154
9155 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9156
9157 * window.c (decode_window, decode_any_window): Move up in code.
9158 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9159 (inhibit_frame_unsplittable): Remove unused variable.
9160 (Fwindow_buffer): Move up and rewrite doc-string.
9161 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9162 (Fwindow_prev): New functions.
9163 (Fwindow_frame): Move here from frame.c. Accept any window as
9164 argument.
9165 (Fframe_root_window, Fframe_first_window)
9166 (Fframe_selected_window): Move here from frame.c. Accept frame
9167 or arbitrary window as argument. Update doc-strings.
9168 (Fminibuffer_window): Move up in code.
9169 (Fwindow_minibuffer_p): Move up in code and simplify.
9170 (Fset_frame_selected_window): Move here from frame.c.
9171 Marginal rewrite.
9172 (Fselected_window, select_window, Fselect_window): Move up in
9173 code. Minor doc-string fixes.
9174
9175 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9176
9177 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9178 Do not assume that spare memory exists; that assumption is valid
9179 only if SYSTEM_MALLOC.
9180 (LARGE_REQUEST): New macro, so that the issue of large requests
9181 is separated from the issue of spare memory.
9182
9183 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9184
9185 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9186 format. (Bug#8806)
9187
9188 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9189
9190 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9191 before statements.
9192
9193 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9194
9195 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9196
9197 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9198
9199 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9200 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9201
9202 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9203
9204 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9205
9206 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9207
9208 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9209 (x_clipboard_manager_save): Add return value.
9210 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9211 New error handlers.
9212 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9213 Obey Vx_select_enable_clipboard_manager. Catch errors in
9214 x_clipboard_manager_save (Bug#8779).
9215 (Vx_select_enable_clipboard_manager): New variable.
9216 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9217
9218 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9219
9220 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9221
9222 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9223
9224 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9225 in the current matrix if keep_current_p is non-zero.
9226
9227 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9228
9229 * bidi.c (bidi_level_of_next_char): Fix last change.
9230
9231 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9232
9233 Support bidi reordering of text covered by display properties.
9234
9235 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9236 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9237 (bidi_cache_search, bidi_cache_iterator_state)
9238 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9239 (bidi_level_of_next_char, bidi_move_to_visually_next):
9240 Support character positions inside a run of characters covered by a
9241 display string.
9242 (bidi_paragraph_init, bidi_resolve_explicit_1)
9243 (bidi_level_of_next_char): Call bidi_fetch_char and
9244 bidi_fetch_char_advance instead of FETCH_CHAR and
9245 FETCH_CHAR_ADVANCE.
9246 (bidi_init_it): Initialize new members.
9247 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9248 definitions.
9249 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9250 instead of using explicit *_CHAR codes.
9251 (bidi_resolve_explicit, bidi_resolve_weak):
9252 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9253 bidirectional text is supported only in multibyte buffers.
9254 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9255 it to initialize the frame_window_p member of struct bidi_it.
9256 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9257 (bidi_resolve_explicit, bidi_resolve_weak)
9258 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9259 bidi_it->nchars is non-positive.
9260 (bidi_level_of_next_char): Don't try to lookup the cache for the
9261 next/previous character if nothing is cached there yet, or if we
9262 were just reseat()'ed to a new position.
9263
9264 * xdisp.c (set_cursor_from_row): Set start and stop points
9265 according to the row's direction when priming the loop that looks
9266 for the glyph on which to display cursor.
9267 (single_display_spec_intangible_p): Function deleted.
9268 (display_prop_intangible_p): Reimplement to call
9269 handle_display_spec instead of single_display_spec_intangible_p.
9270 Accept 3 additional arguments needed by handle_display_spec.
9271 This fixes incorrect cursor motion across display property with complex
9272 values: lists, `(when COND...)' forms, etc.
9273 (single_display_spec_string_p): Support property values that are
9274 lists with the argument STRING its top-level element.
9275 (display_prop_string_p): Fix the condition for processing a
9276 property that is a list to be consistent with handle_display_spec.
9277 (handle_display_spec): New function, refactored from the
9278 last portion of handle_display_prop.
9279 (compute_display_string_pos): Accept additional argument
9280 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9281 value of a `display' property is a "replacing spec".
9282 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9283 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9284 the display property, but just return a value indicating whether
9285 the display property will replace the characters it covers.
9286 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9287 frame_window_p members of struct bidi_it.
9288 (compute_display_string_pos, compute_display_string_end):
9289 New functions.
9290 (push_it): Accept second argument POSITION, where pop_it should
9291 jump to continue iteration.
9292 (reseat_1): Initialize bidi_it.disp_pos.
9293
9294 * keyboard.c (adjust_point_for_property): Adjust the call to
9295 display_prop_intangible_p to its new signature.
9296
9297 * dispextern.h (struct bidi_it): New member frame_window_p.
9298 (bidi_init_it): Update prototypes.
9299 (display_prop_intangible_p): Update prototype.
9300 (compute_display_string_pos, compute_display_string_end):
9301 Declare prototypes.
9302 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9303 EMACS_INT.
9304
9305 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9306
9307 Malloc failure behavior now depends on size of allocation.
9308 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9309 * lisp.h: Change signatures accordingly.
9310 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9311 All callers changed. (Bug#8762)
9312
9313 * gnutls.c: Use Emacs's memory allocators.
9314 Without this change, the gnutls library would invoke malloc etc.
9315 directly, which causes problems on non-SYNC_INPUT hosts, and which
9316 runs afoul of improving memory_full behavior. (Bug#8761)
9317 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9318 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9319 xfree instead of the default malloc, realloc, free.
9320 (Fgnutls_boot): No need to check for memory allocation failure,
9321 since xmalloc does that for us.
9322
9323 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9324 * category.c (hash_get_category_set):
9325 * ccl.c (ccl_driver):
9326 * charset.c (Fdefine_charset_internal):
9327 * charset.h (struct charset.hash_index):
9328 * composite.c (get_composition_id, gstring_lookup_cache)
9329 (composition_gstring_put_cache):
9330 * composite.h (struct composition.hash_index):
9331 * dispextern.h (struct image.hash):
9332 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9333 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9334 (hashfn_equal, hashfn_user_defined, make_hash_table)
9335 (maybe_resize_hash_table, hash_lookup, hash_put)
9336 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9337 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9338 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9339 * image.c (make_image, search_image_cache, lookup_image)
9340 (xpm_put_color_table_h):
9341 * lisp.h (struct Lisp_Hash_Table):
9342 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9343 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9344 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9345 * alloc.c (allocate_vectorlike):
9346 Check for overflow in vector size calculations.
9347 * ccl.c (ccl_driver):
9348 Check for overflow when converting EMACS_INT to int.
9349 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9350 need to be updated by these changes.
9351 * fns.c (make_hash_table, maybe_resize_hash_table):
9352 Check for integer overflow with large hash tables.
9353 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9354 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9355 (SXHASH_REDUCE): New macro.
9356 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9357 Use it instead of discarding useful hash info with large hash values.
9358 (sxhash_float): New function.
9359 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9360 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9361 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9362 Rewrite to use FIXNUM_BITS, as this simplifies things.
9363 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9364 Adjust signatures to match updated version of code.
9365 (consing_since_gc): Now EMACS_INT, since a single hash table can
9366 use more than INT_MAX bytes.
9367
9368 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9369
9370 Make it possible to build with GCC-4.6+ -O2 -flto.
9371
9372 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9373
9374 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9375
9376 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9377 Call minibuffer-inactive-mode.
9378
9379 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9380
9381 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9382 Update dependencies.
9383
9384 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9385
9386 * data.c (init_data): Remove code for UTS, this system is not
9387 supported anymore.
9388
9389 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9390
9391 Don't force ./temacs to start in terminal mode.
9392
9393 * frame.c (make_initial_frame): Initialize faces in all cases, not
9394 only when CANNOT_DUMP is defined.
9395 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9396
9397 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9398
9399 * dispnew.c (add_window_display_history): Use const for the string
9400 pointer. Remove declaration, not needed.
9401
9402 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9403
9404 Use 'inline', not 'INLINE'.
9405 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9406 * alloc.c, fontset.c (INLINE): Remove.
9407 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9408 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9409 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9410 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9411 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9412
9413 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9414
9415 Make it possible to run ./temacs.
9416
9417 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9418 syms_of_callproc does the same thing. Remove test for
9419 "initialized", do it in the caller.
9420 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9421
9422 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9423
9424 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9425 (read_minibuf): Use get_minibuffer.
9426 (syms_of_minibuf): Use DEFSYM.
9427 (Qmetadata): New var.
9428 * data.c (Qbuffer): Don't make it static.
9429 (syms_of_data): Use DEFSYM.
9430
9431 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9432
9433 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9434 (CCL_CODE_MIN): New macro.
9435
9436 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9437
9438 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9439
9440 * eval.c (Qdebug): Now static.
9441 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9442 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9443 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9444
9445 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9446
9447 * image.c: Various fixes to ImageMagick code comments.
9448 (Fimagemagick_types): Doc fix.
9449
9450 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9451
9452 Minor fixes prompted by GCC 4.6.0 warnings.
9453
9454 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9455
9456 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9457 (x_clipboard_manager_save_all): Move extern decl to ...
9458 * xterm.h: ... here, so that it can be checked for consistency.
9459
9460 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9461
9462 * xselect.c (x_clipboard_manager_save_frame)
9463 (x_clipboard_manager_save_all): New functions.
9464 (Fx_clipboard_manager_save): Lisp function deleted.
9465
9466 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9467 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9468
9469 * xterm.h: Update prototype.
9470
9471 2011-05-28 William Xu <william.xwl@gmail.com>
9472
9473 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9474 exiting (Bug#8239).
9475
9476 2011-05-28 Jim Meyering <meyering@redhat.com>
9477
9478 Avoid a sign-extension bug in crypto_hash_function.
9479 * fns.c (to_uchar): Define.
9480 (crypto_hash_function): Use it to convert some newly-signed
9481 variables to unsigned, to avoid sign-extension bugs. For example,
9482 without this change, (md5 "truc") would evaluate to
9483 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9484 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9485 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9486
9487 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9488
9489 Integer overflow fixes.
9490
9491 * dbusbind.c: Serial number integer overflow fixes.
9492 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9493 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9494 to hold a serial number that is too large for a fixnum.
9495 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9496 Check for serial numbers out of range. Decode any serial number
9497 that was so large that it became a float. (Bug#8722)
9498
9499 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9500 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9501 Use XFASTINT rather than XUINT when numbers are nonnegative.
9502 (xd_append_arg, Fdbus_method_return_internal):
9503 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9504 arguments, check that Lisp number is nonnegative, rather than
9505 silently wrapping negative numbers around. (Bug#8722)
9506 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9507 (Bug#8722)
9508
9509 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9510
9511 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9512
9513 ccl: Add integer overflow checks.
9514 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9515 (IN_INT_RANGE): New macros.
9516 (ccl_driver): Use them to check for integer overflow when
9517 decoding a CCL program. Many of the new checks are whether XINT (x)
9518 fits in int; it doesn't always, on 64-bit hosts. The new version
9519 doesn't catch all possible integer overflows, but it's an
9520 improvement. (Bug#8719)
9521
9522 * alloc.c (make_event_array): Use XINT, not XUINT.
9523 There's no need for unsigned here.
9524
9525 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9526 This follows up to the 2011-05-06 change that substituted uintptr_t
9527 for EMACS_INT. This case wasn't caught back then.
9528
9529 Rework Fformat to avoid integer overflow issues.
9530 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9531 now (part of C89). Include <verify.h>.
9532 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9533 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9534 (Fformat): Avoid the prepass trying to compute sizes; it was only
9535 approximate and thus did not catch overflow reliably. Instead, walk
9536 through the format just once, formatting and computing sizes as we go,
9537 checking for integer overflow at every step, and allocating a larger
9538 buffer as needed. Keep track separately whether the format is
9539 multibyte. Keep only the most-recently calculated precision, rather
9540 than them all. Record whether each argument has been converted to
9541 string. Use EMACS_INT, not int, for byte and char and arg counts.
9542 Support field widths and precisions larger than INT_MAX. Avoid
9543 sprintf's undefined behavior with conversion specifications such as %#d
9544 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9545 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9546 formatting out-of-range floating point numbers with int
9547 formats. (Bug#8668)
9548
9549 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9550
9551 * data.c: Avoid integer truncation in expressions involving floats.
9552 * data.c: Include <intprops.h>.
9553 (arith_driver): When there's an integer overflow in an expression
9554 involving floating point, convert the integers to floating point
9555 so that the resulting value does not suffer from catastrophic
9556 integer truncation. For example, on a 64-bit host (* 4
9557 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9558 Do not rely on undefined behavior after integer overflow.
9559
9560 merge count_size_as_multibyte, parse_str_to_multibyte
9561 * character.c, character.h (count_size_as_multibyte):
9562 Rename from parse_str_to_multibyte; all uses changed.
9563 Check for integer overflow.
9564 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9565 since it's now a duplicate of the other. This is more of
9566 a character than a buffer op, so better that it's in character.c.
9567 * fns.c, print.c: Adjust to above changes.
9568
9569 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9570
9571 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9572
9573 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9574
9575 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9576 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9577 (x_clipboard_manager_save): Now static.
9578 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9579
9580 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9581 (crypto_hash_function): Now static.
9582 Fix pointer signedness problems. Avoid unnecessary initializations.
9583
9584 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9585
9586 * termhooks.h (Vselection_alist): Make it terminal-local.
9587
9588 * terminal.c (create_terminal): Initialize it.
9589
9590 * xselect.c: Support for clipboard managers.
9591 (Vselection_alist): Move to termhooks.h as terminal-local var.
9592 (LOCAL_SELECTION): New macro.
9593 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9594 (symbol_to_x_atom): Remove gratuitous arg.
9595 (x_handle_selection_request, lisp_data_to_selection_data)
9596 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9597 (x_own_selection, x_get_local_selection, x_convert_selection):
9598 New arg, specifying work frame. Use terminal-local Vselection_alist.
9599 (some_frame_on_display): Delete unused function.
9600 (Fx_own_selection_internal, Fx_get_selection_internal)
9601 (Fx_disown_selection_internal, Fx_selection_owner_p)
9602 (Fx_selection_exists_p): New optional frame arg.
9603 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9604 (x_handle_selection_clear): Don't treat other terminals with the
9605 same keyboard specially. Use the terminal-local Vselection_alist.
9606 (x_clear_frame_selections): Use Frun_hook_with_args.
9607
9608 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9609
9610 * xterm.h: Add support for those atoms.
9611
9612 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9613
9614 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9615 (converted_selections, conversion_fail_tag): New global variables.
9616 (x_selection_request_lisp_error): Free the above.
9617 (x_get_local_selection): Remove unnecessary code.
9618 (x_reply_selection_request): Args changed; handle arbitrary array
9619 of converted selections stored in converted_selections.
9620 Separate the XChangeProperty and SelectionNotify steps.
9621 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9622 (x_convert_selection): New function.
9623 (x_handle_selection_event): Simplify.
9624 (x_get_foreign_selection): Don't ignore incoming requests while
9625 waiting for an answer; this will fail when we implement
9626 SAVE_TARGETS, and seems unnecessary anyway.
9627 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9628 (Vx_sent_selection_functions): Doc fix.
9629
9630 2011-05-26 Leo Liu <sdl.web@gmail.com>
9631
9632 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9633
9634 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9635
9636 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9637
9638 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9639 for fringe update if it has periodic bitmap.
9640 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9641 and fringe_bitmap_periodic_p.
9642
9643 * fringe.c (get_fringe_bitmap_data): New function.
9644 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9645 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9646 row. Mark glyph row for fringe update if periodicity changed.
9647
9648 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9649 for fringe update unless it has periodic bitmap.
9650
9651 2011-05-25 Kenichi Handa <handa@m17n.org>
9652
9653 * xdisp.c (get_next_display_element): Set correct it->face_id for
9654 a static composition.
9655
9656 2011-05-24 Leo Liu <sdl.web@gmail.com>
9657
9658 * deps.mk (fns.o):
9659 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9660
9661 * fns.c (crypto_hash_function, Fsha1): New function.
9662 (Fmd5): Use crypto_hash_function.
9663 (syms_of_fns): Add Ssha1.
9664
9665 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9666
9667 * gnutls.c: Remove unused macros.
9668 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9669 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9670 Remove macros that are defined and never used.
9671 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9672
9673 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9674
9675 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9676 (Fx_get_selection_internal): Minor cleanup.
9677 (Fx_own_selection_internal): Rename arguments for consistency with
9678 select.el.
9679
9680 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9681
9682 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9683
9684 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9685
9686 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9687
9688 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9689
9690 * dispnew.c (scrolling_window): Don't exclude the case that the
9691 last enabled row in the desired matrix touches the bottom boundary.
9692
9693 2011-05-21 Glenn Morris <rgm@gnu.org>
9694
9695 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9696 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9697 and add some more files.
9698
9699 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9700
9701 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9702 report_file_error introduced by the change from 2011-05-07.
9703
9704 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9705
9706 * systime.h (Time): Define only if emacs is defined.
9707 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9708 where the include path doesn't have X11/X.h by default. See
9709 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9710
9711 2011-05-20 Kenichi Handa <handa@m17n.org>
9712
9713 * composite.c (find_automatic_composition): Fix previous change.
9714
9715 2011-05-20 Glenn Morris <rgm@gnu.org>
9716
9717 * lisp.mk: New file, split from Makefile.in.
9718 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9719 (shortlisp): Remove.
9720 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9721
9722 2011-05-19 Glenn Morris <rgm@gnu.org>
9723
9724 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9725 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9726 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9727 (lisp): Set the order to that of loadup.el.
9728 (shortlisp): Make it a copy of $lisp.
9729 (SOME_MACHINE_LISP): Remove.
9730 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9731 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9732
9733 2011-05-18 Kenichi Handa <handa@m17n.org>
9734
9735 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9736 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9737 (find_automatic_composition): Mostly rewrite for efficiency.
9738
9739 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9740
9741 * makefile.w32-in: Update dependencies.
9742
9743 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9744
9745 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9746 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9747
9748 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9749
9750 Fix some integer overflow issues, such as string length overflow.
9751
9752 * insdel.c (count_size_as_multibyte): Check for string overflow.
9753
9754 * character.c (lisp_string_width): Check for string overflow.
9755 Use EMACS_INT, not int, for string indexes and lengths; in
9756 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9757 the resulting string length overflows an EMACS_INT; instead,
9758 report a string overflow if no precision given. When checking for
9759 precision exhaustion, use a check that cannot possibly have
9760 integer overflow. (Bug#8675)
9761 * character.h (lisp_string_width): Adjust to new signature.
9762
9763 * alloc.c (string_overflow): New function.
9764 (Fmake_string): Use it. This doesn't change behavior, but saves
9765 a few bytes and will simplify future changes.
9766 * character.c (string_escape_byte8): Likewise.
9767 * lisp.h (string_overflow): New decl.
9768
9769 Fixups, following up to the user-interface timestamp change.
9770 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9771 for UI timestamps, instead of unsigned long.
9772 * msdos.c (mouse_get_pos): Likewise.
9773 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9774 * w32gui.h (Time): Define by including "systime.h" rather than by
9775 declaring it ourselves. (Bug#8664)
9776
9777 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9778 * image.c (clear_image_cache): Likewise.
9779
9780 * term.c (term_mouse_position): Don't assume time_t wraparound.
9781
9782 Be more systematic about user-interface timestamps.
9783 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9784 and sometimes 'EMACS_UINT', to represent these timestamps.
9785 This change causes it to use 'Time' uniformly, as that's what X uses.
9786 This makes the code easier to follow, and makes it easier to catch
9787 integer overflow bugs such as Bug#8664.
9788 * frame.c (Fmouse_position, Fmouse_pixel_position):
9789 Use Time, not unsigned long, for user-interface timestamps.
9790 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9791 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9792 * keyboard.h (last_event_timestamp): Likewise.
9793 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9794 * menu.h (xmenu_show): Likewise.
9795 * term.c (term_mouse_position): Likewise.
9796 * termhooks.h (struct input_event.timestamp): Likewise.
9797 (struct terminal.mouse_position_hook): Likewise.
9798 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9799 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9800 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9801 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9802 what it was before.
9803 * menu.h, termhooks.h: Include "systime.h", for Time.
9804
9805 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9806 Don't assume that the difference between two unsigned long values
9807 can fit into an integer. At this point, we know button_down_time
9808 <= event->timestamp, so the difference must be nonnegative, so
9809 there's no need to cast the result if double-click-time is
9810 nonnegative, as it should be; check that it's nonnegative, just in
9811 case. This bug is triggered when events are more than 2**31 ms
9812 apart (about 25 days). (Bug#8664)
9813
9814 * xselect.c (last_event_timestamp): Remove duplicate decl.
9815 (x_own_selection): Remove needless cast to unsigned long.
9816
9817 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9818 that always fit in int. Use a sentinel instead of a counter, to
9819 avoid a temp and to allay GCC's concerns about possible int overflow.
9820 * frame.h (struct frame): Use int for menu_bar_items_used
9821 instead of EMACS_INT, since it always fits in int.
9822
9823 * menu.c (grow_menu_items): Check for int overflow.
9824
9825 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9826
9827 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9828 Before, the code was not consistent. These values cannot exceed
9829 2**31 - 1 so there's no need to make them unsigned.
9830 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9831 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9832 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9833 as modifiers.
9834 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9835
9836 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9837 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9838 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9839 presumably because the widths might not match.
9840
9841 * window.c (size_window): Avoid needless test at loop start.
9842
9843 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9844
9845 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9846
9847 2011-05-12 Drew Adams <drew.adams@oracle.com>
9848
9849 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9850
9851 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9852
9853 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9854 `width' to `bar_area_x' and `bar_area_width', respectively.
9855 (x_scroll_run): Take account of fringe background extension.
9856
9857 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9858 Rename local vars `left' and `width' to `bar_area_x' and
9859 `bar_area_width', respectively.
9860 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9861 background extension.
9862
9863 2011-05-10 Jim Meyering <meyering@redhat.com>
9864
9865 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9866
9867 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9868
9869 * image.c (Finit_image_library): Return t for built-in image types,
9870 like pbm and xbm. (Bug#8640)
9871
9872 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9873
9874 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9875
9876 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9877
9878 * w32console.c (Fset_screen_color): Doc fix.
9879 (Fget_screen_color): New function.
9880 (syms_of_ntterm): Defsubr it.
9881
9882 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9883 unlink the temporary file if Fcall_process didn't create it in the
9884 first place.
9885 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9886 child process will be redirected to a file specified with `:file'.
9887 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9888 cue to call_process_cleanup not to close that handle.
9889
9890 2011-05-07 Ben Key <bkey76@gmail.com>
9891
9892 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9893 one of two shell specific rules, either bootstrap-temacs-CMD or
9894 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9895 to the previous implementation of the bootstrap-temacs rule.
9896 The bootstrap-temacs-CMD rule is similar to the previous
9897 implementation of the bootstrap-temacs rule except that it
9898 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9899 variable.
9900
9901 These changes, along with some changes to nt/configure.bat,
9902 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9903 earlier fix to add support for --cflags and --ldflags options
9904 that include quotes so that it works whether make uses cmd or
9905 sh as the shell.
9906
9907 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9908
9909 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9910 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9911 is a constant.
9912 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9913 a string. Handle both cases.
9914 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9915 (Fdbus_register_method): Use Qinvalid_function.
9916
9917 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9918
9919 * makefile.w32-in: Update dependencies.
9920 (LISP_H): Add inttypes.h and stdin.h.
9921 (PROCESS_H): Add unistd.h.
9922
9923 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9924
9925 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9926 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9927
9928 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9929
9930 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9931
9932 * term.c (vfatal): Remove stray call to va_end.
9933 It's not needed and the C Standard doesn't allow it here anyway.
9934
9935 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9936 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9937
9938 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9939 bytes.
9940
9941 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9942
9943 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9944
9945 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9946
9947 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9948
9949 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9950
9951 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9952 * charset.c (Fdefine_charset_internal): Don't initialize
9953 charset.code_space[15]. The value was garbage, on hosts with
9954 32-bit int (Bug#8600).
9955
9956 * lread.c (read_integer): Be more consistent with string-to-number.
9957 Use string_to_number to do the actual conversion; this avoids
9958 rounding errors and fixes some other screwups. Without this fix,
9959 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9960 (digit_to_number): Move earlier, for benefit of read_integer.
9961 Return -1 if the digit is out of range for the base, -2 if it is
9962 not a digit in any supported base. (Bug#8602)
9963
9964 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9965
9966 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9967 to match comment at start of function. This also removes a
9968 GCC warning about overflow in a 32+64-bit port.
9969
9970 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9971
9972 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9973 Reported by Stefan Monnier in
9974 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9975 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9976 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9977
9978 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9979 (EMACS_UINTPTR): Likewise, with uintptr_t.
9980
9981 * lisp.h: Prefer 64-bit EMACS_INT if available.
9982 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9983 on 32-bit hosts that have 64-bit int, so that they can access
9984 large files.
9985 However, temporarily disable this change unless the temporary
9986 symbol WIDE_EMACS_INT is defined.
9987
9988 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9989
9990 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9991 This removes an assumption that EMACS_INT and long are the same
9992 width as pointers. The assumption is true for Emacs porting targets
9993 now, but we want to make other targets possible.
9994 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9995 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9996 In the rest of the code, change types of integers that hold casted
9997 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9998 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9999 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10000 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10001 No need to cast type when ORing.
10002 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10003 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10004 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10005 assume EMACS_INT is the same width as char *.
10006 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10007 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10008 Remove no-longer-needed casts.
10009 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10010 (xg_tool_bar_help_callback, xg_make_tool_item):
10011 Use EMACS_INTPTR to hold an integer
10012 that will be cast to void *; this can avoid a GCC warning
10013 if EMACS_INT is not the same width as void *.
10014 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10015 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10016 (current_message_1, set_message_1):
10017 Use a local to convert to proper width without a cast.
10018 * xmenu.c (dialog_selection_callback): Likewise.
10019
10020 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10021 Also, don't assume VALBITS / RAND_BITS is less than 5,
10022 and don't rely on undefined behavior when shifting a 1 left into
10023 the sign bit.
10024 * lisp.h (get_random): Change signature to match.
10025
10026 * lread.c (hash_string): Use size_t, not int, for hash computation.
10027 Normally we prefer signed values; but hashing is special, because
10028 it's better to use unsigned division on hash table sizes so that
10029 the remainder is nonnegative. Also, size_t is the natural width
10030 for hashing into memory. The previous code used 'int', which doesn't
10031 retain enough info to hash well into very large tables.
10032 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10033
10034 * dbusbind.c: Don't possibly lose pointer info when converting.
10035 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10036 Use XPNTR rather than XHASH, so that the high-order bits of
10037 the pointer aren't lost when converting through void *.
10038
10039 * eval.c (Fautoload): Don't double-shift a pointer.
10040
10041 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10042
10043 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10044
10045 * gnutls.c (DEF_GNUTLS_FN):
10046 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10047
10048 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10049
10050 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10051 marker. (Bug#8610)
10052
10053 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10054
10055 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10056 New version that can reserve upto 2GB of heap space.
10057
10058 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10059
10060 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10061
10062 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10063
10064 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10065 `gnutls_certificate_set_x509_key_file'.
10066
10067 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10068
10069 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10070 Update dependencies.
10071
10072 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10073
10074 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10075 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10076 Remove unused parameter `fildes'.
10077 * process.c (read_process_output, send_process): Don't pass it.
10078
10079 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10080
10081 Fix previous change: the library cache is defined in w32.c.
10082 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10083 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10084
10085 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10086
10087 Implement dynamic loading of GnuTLS on Windows.
10088
10089 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10090 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10091 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10092 Declare.
10093
10094 * gnutls.c (Qgnutls_dll): Define.
10095 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10096 (gnutls_*): Declare function pointers.
10097 (init_gnutls_functions): New function to initialize function pointers.
10098 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10099 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10100 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10101 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10102 (emacs_gnutls_write, emacs_gnutls_read)
10103 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10104 (Fgnutls_available_p): New function.
10105 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10106 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10107 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10108
10109 * image.c: Include w32.h.
10110 (Vimage_type_cache): Delete.
10111 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10112 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10113 (w32_delayed_load): Move to w32.c.
10114
10115 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10116
10117 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10118 (w32_delayed_load): Move from image.c. When loading a library, record
10119 its filename in the :loaded-from property of the library id.
10120 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10121 Initialize and staticpro them.
10122 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10123
10124 * process.c: Include lisp.h before w32.h, not after.
10125 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10126 instead of gnutls_record_check_pending.
10127
10128 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10129
10130 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10131
10132 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10133 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10134 as passed in.
10135
10136 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10137
10138 * xterm.c (x_set_frame_alpha): Do not set property on anything
10139 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10140
10141 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10142
10143 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10144
10145 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10146
10147 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10148 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10149 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10150 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10151 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10152 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10153 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10154 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10155 (Qgnutls_bootprop_callbacks_verify): Make static.
10156
10157 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10158
10159 * callproc.c: Indentation fixup.
10160
10161 * sysdep.c (wait_for_termination_1): Make static.
10162 (wait_for_termination, interruptible_wait_for_termination):
10163 Move after wait_for_termination_1.
10164
10165 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10166
10167 * sysdep.c (interruptible_wait_for_termination): New function
10168 which is like wait_for_termination, but allows keyboard
10169 interruptions.
10170
10171 * callproc.c (Fcall_process): Add (:file "file") as an option for
10172 the STDOUT buffer.
10173 (Fcall_process_region): Ditto.
10174
10175 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10176
10177 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10178 rather than `XVECTOR (FOO)->size'.
10179
10180 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10181 inttypes.h, as a gnulib replacement is used if it not available in
10182 system headers.
10183
10184 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10185
10186 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10187 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10188 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10189
10190 * coding.c (coding_alloc_by_realloc): Error out if destination
10191 will grow beyond MOST_POSITIVE_FIXNUM.
10192 (decode_coding_emacs_mule): Abort if there isn't enough place in
10193 charbuf for the composition carryover bytes. Reserve an extra
10194 space for up to 2 characters produced in a loop.
10195 (decode_coding_iso_2022): Abort if there isn't enough place in
10196 charbuf for the composition carryover bytes.
10197
10198 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10199
10200 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10201 aborting when %lld or %lll format is passed.
10202 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10203 %llo or %llx format is passed. (Bug#8545)
10204
10205 * window.c (window_scroll_line_based): Use a marker instead of
10206 simple variables to record original value of point. (Bug#7952)
10207
10208 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10209 produced by %s or %c overflows available buffer space. (Bug#8545)
10210
10211 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10212
10213 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10214 (SIZE_MAX): Move defn after all includes, as they might #define it.
10215
10216 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10217
10218 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10219
10220 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10221
10222 * keyboard.c (Qdelayed_warnings_hook): Define.
10223 (command_loop_1): Run `delayed-warnings-hook'
10224 if Vdelayed_warnings_list is non-nil.
10225 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10226 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10227
10228 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10229
10230 * doprnt.c (doprnt): Don't return value smaller than the buffer
10231 size if the message was truncated. (Bug#8545).
10232
10233 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10234
10235 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10236 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10237
10238 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10239
10240 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10241
10242 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10243
10244 * makefile.w32-in: Update dependencies.
10245
10246 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10247
10248 Improve `doprnt' and its usage. (Bug#8545)
10249 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10250 `format_end'. Remove support for %l as a conversion specifier.
10251 Don't use xrealloc. Improve diagnostics when the %l size modifier
10252 is used. Update the commentary.
10253
10254 * eval.c (verror): Simplify calculation of size_t.
10255
10256 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10257 messages.
10258
10259 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10260
10261 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10262 change.
10263
10264 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10265
10266 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10267 This makes this file independent of the recent pseudovector change.
10268
10269 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10270
10271 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10272
10273 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10274 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10275 Remove unused local.
10276 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10277
10278 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10279 GCC 4.6.0 optimizes based on type-based alias analysis.
10280 For example, if b is of type struct buffer * and v of type struct
10281 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10282 != &v->size, and therefore "v->size = 1; b->size = 2; return
10283 v->size;" must therefore return 1. This assumption is incorrect
10284 for Emacs, since it type-puns struct Lisp_Vector * with many other
10285 types. To fix this problem, this patch adds a new type struct
10286 vectorlike_header that documents the constraints on layout of vectors
10287 and pseudovectors, and helps optimizing compilers not get fooled
10288 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10289 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10290 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10291 the size member.
10292 (XSETPVECTYPE): Rewrite in terms of new macro.
10293 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10294 This is a bit clearer, and further avoids the possibility of
10295 undesirable aliasing.
10296 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10297 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10298 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10299 since Lisp_Subr is a special case (no "next" field).
10300 (ASIZE): Now uses header.size rather than size.
10301 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10302 to avoid the hassle of writing XVECTOR (foo)->header.size.
10303 (struct vectorlike_header): New type.
10304 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10305 object, to help avoid aliasing.
10306 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10307 (SUBRP): Likewise, since Lisp_Subr is a special case.
10308 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10309 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10310 (struct Lisp_Hash_Table): Combine first two members into a single
10311 struct vectorlike_header member. All uses of "size" and "next" members
10312 changed to be "header.size" and "header.next".
10313 * buffer.h (struct buffer): Likewise.
10314 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10315 * frame.h (struct frame): Likewise.
10316 * process.h (struct Lisp_Process): Likewise.
10317 * termhooks.h (struct terminal): Likewise.
10318 * window.c (struct save_window_data, struct saved_window): Likewise.
10319 * window.h (struct window): Likewise.
10320 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10321 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10322 * buffer.c (init_buffer_once): Likewise.
10323 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10324 special case.
10325 * process.c (Fformat_network_address): Use local var for size,
10326 for brevity.
10327
10328 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10329
10330 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10331 * data.c (atof): Remove decl; no longer used or needed.
10332 (digit_to_number): Move to lread.c.
10333 (Fstring_to_number): Use new string_to_number function, to be
10334 consistent with how the Lisp reader treats infinities and NaNs.
10335 Do not assume that floating-point numbers represent EMACS_INT
10336 without losing information; this is not true on most 64-bit hosts.
10337 Avoid double-rounding errors, by insisting on integers when
10338 parsing non-base-10 numbers, as the documentation specifies.
10339 * lisp.h (string_to_number): New decl, replacing ...
10340 (isfloat_string): Remove.
10341 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10342 (read1): Do not accept +. and -. as integers; this
10343 appears to have been a coding error. Similarly, do not accept
10344 strings like +-1e0 as floating point numbers. Do not report
10345 overflow for integer overflows unless the base is not 10 which
10346 means we have no simple and reliable way to continue.
10347 Break out the floating-point parsing into a new
10348 function string_to_number, so that Fstring_to_number parses
10349 floating point numbers consistently with the Lisp reader.
10350 (digit_to_number): Move here from data.c. Make it static inline.
10351 (E_CHAR, EXP_INT): Remove, replacing with ...
10352 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10353 (string_to_number): New function, replacing isfloat_string.
10354 This function checks for valid syntax and produces the resulting
10355 Lisp float number too. Rework it so that string-to-number
10356 no longer mishandles examples like "1.0e+". Use strtoumax,
10357 so that overflow for non-base-10 numbers is reported only when
10358 there's no portable and simple way to convert to floating point.
10359
10360 * textprop.c (set_text_properties_1): Rewrite for clarity,
10361 and to avoid GCC warning about integer overflow.
10362
10363 * intervals.h (struct interval): Use EMACS_INT for members
10364 where EMACS_UINT might cause problems. See
10365 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10366 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10367 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10368 All uses changed.
10369 (offset_intervals): Tell GCC not to worry about length overflow
10370 when negating a negative length.
10371
10372 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10373 (overrun_check_free): Likewise.
10374
10375 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10376 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10377 word size.
10378
10379 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10380 (gnutls_make_error): Rename local to avoid shadowing.
10381 (gnutls_emacs_global_deinit): ifdef out; not used.
10382 (Fgnutls_boot): Use const for pointer to readonly storage.
10383 Comment out unused local. Fix pointer signedness problems.
10384
10385 * lread.c (openp): Don't stuff size_t into an 'int'.
10386 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10387 about possible signed overflow.
10388
10389 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10390 (GDK_KEY_g): Don't define if already defined.
10391 (xg_prepare_tooltip): Avoid pointer signedness problem.
10392 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10393
10394 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10395 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10396
10397 * xfns.c (Fx_window_property): Simplify a bit,
10398 to make a bit faster and to avoid GCC 4.6.0 warning.
10399 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10400
10401 * fns.c (internal_equal): Don't assume size_t fits in int.
10402
10403 * alloc.c (compact_small_strings): Tighten assertion a little.
10404
10405 Replace pEd with more-general pI, and fix some printf arg casts.
10406 * lisp.h (pI): New macro, generalizing old pEd macro to other
10407 conversion specifiers. For example, use "...%"pI"d..." rather
10408 than "...%"pEd"...".
10409 (pEd): Remove. All uses replaced with similar uses of pI.
10410 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10411 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10412 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10413 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10414 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10415 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10416 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10417 64-bit hosts.
10418 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10419 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10420 * print.c (safe_debug_print, print_object): Likewise.
10421 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10422 to int.
10423 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10424 avoiding the 0 flag, which is not portable.
10425 * process.c (Fmake_network_process): Use pI to avoid cast.
10426 * region-cache.c (pp_cache): Likewise.
10427 * xdisp.c (decode_mode_spec): Likewise.
10428 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10429 behavior on 64-bit hosts with printf arg.
10430 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10431 (x_stop_queuing_selection_requests): Likewise.
10432 (x_get_window_property): Don't truncate byte count to an 'int'
10433 when tracing.
10434
10435 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10436 here, since it parses constructs like leading '-' and spaces,
10437 which are not wanted; and it overflows with large numbers.
10438 Instead, simply match F[0-9]+, which is what is wanted anyway.
10439
10440 * alloc.c: Remove unportable assumptions about struct layout.
10441 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10442 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10443 (allocate_vectorlike, make_pure_vector): Use the new macros,
10444 plus offsetof, to remove unportable assumptions about struct layout.
10445 These assumptions hold on all porting targets that I know of, but
10446 they are not guaranteed, they're easy to remove, and removing them
10447 makes further changes easier.
10448
10449 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10450 This doesn't fix a bug but makes the code clearer.
10451 (string_overrun_cookie): Now const. Use initializers that
10452 don't formally overflow signed char, to avoid warnings.
10453 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10454 can cause Emacs to crash when string overrun checking is enabled.
10455 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10456 multiple of sizeof (EMACS_INT); it need not be, if
10457 alignof(EMACS_INT) < sizeof (EMACS_INT).
10458 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10459
10460 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10461
10462 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10463
10464 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10465
10466 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10467 supposed to be handshaking. (Bug#8556)
10468 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10469
10470 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10471
10472 * lisp.h (Qdebug): List symbol.
10473 * eval.c (Qdebug): Restore global linkage.
10474 * keyboard.c (debug-on-event): New variable.
10475 (handle_user_signal): Break into debugger when debug-on-event
10476 matches the current signal symbol.
10477
10478 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10479
10480 * alloc.c (check_sblock, check_string_bytes)
10481 (check_string_free_list): Convert to standard C.
10482
10483 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10484
10485 * w32.c (emacs_gnutls_push): Fix typo.
10486
10487 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10488
10489 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10490 "cast to pointer from integer of different size".
10491
10492 Improve doprnt and its use in verror. (Bug#8545)
10493 * doprnt.c (doprnt): Document the set of format control sequences
10494 supported by the function. Use SAFE_ALLOCA instead of always
10495 using `alloca'.
10496
10497 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10498 is one byte too soon. Don't use xrealloc; instead xfree and
10499 xmalloc anew.
10500
10501 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10502
10503 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10504 callbacks stage.
10505
10506 * gnutls.c: Renamed global_initialized to
10507 gnutls_global_initialized. Added internals for the
10508 :verify-hostname-error, :verify-error, and :verify-flags
10509 parameters of `gnutls-boot' and documented those parameters in the
10510 docstring. Start callback support.
10511 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10512 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10513 on error. Return error code.
10514 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10515 (emacs_gnutls_read): Likewise.
10516 (Fgnutls_boot): Return handshake error code.
10517 (emacs_gnutls_handle_error): New function.
10518 (wsaerror_to_errno): Likewise.
10519
10520 * w32.h (emacs_gnutls_pull): Add prototype.
10521 (emacs_gnutls_push): Likewise.
10522
10523 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10524 (emacs_gnutls_push): Likewise.
10525
10526 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10527
10528 * process.c (wait_reading_process_output): Check if GnuTLS
10529 buffered some data internally if no FDs are set for TLS
10530 connections.
10531
10532 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10533 (LIBS): Link to USER_LIBS.
10534 ($(BLD)/gnutls.$(0)): New target.
10535
10536 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10537
10538 * xdisp.c (handle_single_display_spec): Rename the
10539 display_replaced_before_p argument into display_replaced_p, to
10540 make it consistent with the commentary. Fix typos in the
10541 commentary.
10542
10543 * textprop.c (syms_of_textprop): Remove dead code.
10544 (copy_text_properties): Delete obsolete commentary about an
10545 interface that was deleted long ago. Fix typos in the description
10546 of arguments.
10547
10548 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10549 to changes in oldXMenu/XMenu.h from 2011-04-16.
10550 <menu_help_message, prev_menu_help_message>: Constify.
10551 (IT_menu_make_room): menu->help_text is now `const char **';
10552 adjust.
10553
10554 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10555 to changes in oldXMenu/XMenu.h from 2011-04-16.
10556 (struct XMenu): Declare `help_text' `const char **'.
10557
10558 * xfaces.c <Qunspecified>: Make extern again.
10559
10560 * syntax.c: Include sys/types.h before including regex.h, as
10561 required by POSIX.
10562
10563 * doc.c (get_doc_string): Improve the format passed to `error'.
10564
10565 * doprnt.c (doprnt): Improve commentary.
10566
10567 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10568
10569 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10570 them with etags.
10571
10572 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10573 changes in globals.h immediately force recompilation.
10574 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10575 $(CURDIR)/s/ms-w32.h.
10576 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10577
10578 * character.c (Fchar_direction): Function deleted.
10579 (syms_of_character): Don't defsubr it.
10580 <char-direction-table>: Deleted.
10581
10582 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10583
10584 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10585 * doprnt.c: Include limits.h.
10586 (SIZE_MAX): New macro.
10587 (doprnt): Return a size_t value. 2nd arg is now size_t.
10588 Many local variables are now size_t instead of int or unsigned.
10589 Improve overflow protection. Support `l' modifier for integer
10590 conversions. Support %l conversion. Don't assume an EMACS_INT
10591 argument for integer conversions and for %c.
10592
10593 * lisp.h (doprnt): Restore prototype.
10594
10595 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10596 $(SRC)/character.h.
10597
10598 * Makefile.in (base_obj): Add back doprnt.o.
10599
10600 * deps.mk (doprnt.o): Add back prerequisites.
10601 (callint.o): Depend on character.h.
10602
10603 * eval.c (internal_lisp_condition_case): Include the handler
10604 representation in the error message.
10605 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10606 when breaking from the loop.
10607
10608 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10609
10610 * callint.c (Fcall_interactively): When displaying error message
10611 about invalid control letter, pass the character's codepoint, not
10612 a pointer to its multibyte form. Improve display of the character
10613 in octal and display also its hex code.
10614
10615 * character.c (char_string): Use %x to display the (unsigned)
10616 codepoint of an invalid character, to avoid displaying a bogus
10617 negative value.
10618
10619 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10620 `error', not SYMBOL_NAME itself.
10621
10622 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10623 character arguments to `error'.
10624
10625 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10626 to `error' in error message about FINAL_CHAR argument. Make sure
10627 FINAL_CHAR is a character, and use %c when it is passed as
10628 argument to `error'.
10629
10630 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10631
10632 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10633
10634 * w32.c: Include <time.h>.
10635 (sys_localtime): New function.
10636
10637 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10638
10639 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10640
10641 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10642
10643 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10644
10645 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10646 zombies (Bug#8467).
10647
10648 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10649
10650 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10651 gl_state.e_property when gl_state.object is Qt.
10652
10653 * insdel.c (make_gap_larger): Remove limitation of buffer size
10654 to <= INT_MAX.
10655
10656 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10657
10658 * xdisp.c (lookup_glyphless_char_display)
10659 (produce_glyphless_glyph): Handle cons cell entry in
10660 glyphless-char-display.
10661 (Vglyphless_char_display): Document it.
10662
10663 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10664 glyphless-char-display.
10665
10666 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10667
10668 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10669
10670 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10671
10672 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10673 definition for no-X builds.
10674
10675 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10676
10677 Static checks with GCC 4.6.0 and non-default toolkits.
10678
10679 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10680
10681 * process.c (keyboard_bit_set): Define only if SIGIO.
10682 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10683 (send_process): Repair possible setjmp clobbering.
10684
10685 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10686
10687 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10688
10689 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10690
10691 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10692 Define only if needed.
10693
10694 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10695 by pacifying GCC about it. Maybe it's time to retire it?
10696 * xfaces.c (USG, __TIMEVAL__): Likewise.
10697
10698 * dispextern.h (struct redisplay_interface): Rename param
10699 to avoid shadowing.
10700 * termhooks.h (struct terminal): Likewise.
10701 * xterm.c (xembed_send_message): Likewise.
10702
10703 * insdel.c (make_gap_smaller): Define only if
10704 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10705
10706 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10707 it.
10708
10709 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10710 so that we aren't warned about unused symbols.
10711
10712 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10713
10714 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10715
10716 * xfns.c (x_real_positions): Mark locals as initialized.
10717
10718 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10719
10720 * xterm.c: Fix problems found by static analysis with other toolkits.
10721 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10722 (x_dispatch_event): Declare static if USE_GTK, and
10723 define if USE_GTK || USE_X_TOOLKIT.
10724 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10725 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10726 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10727 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10728
10729 * xmenu.c (menu_help_callback): Pointer type fixes.
10730 Use const pointers when pointing at readonly data. Avoid pointer
10731 signedness clashes.
10732 (FALSE): Remove unused macro.
10733 (update_frame_menubar): Remove unused decl.
10734
10735 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10736
10737 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10738 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10739 (single_menu_item): Rename local to avoid shadowing.
10740
10741 * keyboard.c (make_lispy_event): Remove unused local var.
10742
10743 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10744 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10745
10746 * bitmaps: Change bitmaps from unsigned char back to the X11
10747 compatible char. Avoid the old compiler warnings about
10748 out-of-range initializers by using, for example, '\xab' rather
10749 than 0xab.
10750
10751 * xgselect.c (xgselect_initialize): Check vs interface
10752 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10753
10754 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10755
10756 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10757 to read-only memory.
10758
10759 * fns.c (vector): Remove; this old hack is no longer needed.
10760
10761 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10762 Remove unused var.
10763 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10764
10765 * xrdb.c (x_load_resources): Omit unused local.
10766
10767 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10768 (x_window): Rename locals to avoid shadowing.
10769 (USG): Use the kludged USG macro, to pacify gcc.
10770
10771 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10772 (x_term_init): Remove local to avoid shadowing.
10773
10774 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10775
10776 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10777 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10778
10779 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10780
10781 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10782
10783 Fix regex.c, syntax.c and friends for buffers > 2GB.
10784 * syntax.h (struct gl_state_s): Declare character position members
10785 EMACS_INT.
10786
10787 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10788
10789 * textprop.c (verify_interval_modification, interval_of):
10790 Declare arguments EMACS_INT.
10791
10792 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10793 EMACS_INT.
10794
10795 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10796
10797 * indent.c (Fvertical_motion): Local variable it_start is now
10798 EMACS_INT.
10799
10800 * regex.c (re_match, re_match_2, re_match_2_internal)
10801 (bcmp_translate, regcomp, regexec, print_double_string)
10802 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10803 (re_compile_pattern, re_exec): Declare arguments and local
10804 variables `size_t' and `ssize_t' and return values `regoff_t', as
10805 appropriate.
10806 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10807 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10808 <compile_stack_type>: `size' and `avail' are now `size_t'.
10809
10810 * regex.h <regoff_t>: Use ssize_t, not int.
10811 (re_search, re_search_2, re_match, re_match_2): Arguments that
10812 specify buffer/string position and length are now ssize_t and
10813 size_t. Return type is regoff_t.
10814
10815 2011-04-16 Ben Key <bkey76@gmail.com>
10816
10817 * nsfont.m: Fixed bugs in ns_get_family and
10818 ns_descriptor_to_entity that were caused by using free to
10819 deallocate memory blocks that were allocated by xmalloc (via
10820 xstrdup). This caused Emacs to crash when compiled with
10821 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10822 --enable-checking=xmallocoverrun). xfree is now used to
10823 deallocate these memory blocks.
10824
10825 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10826
10827 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10828
10829 emacs_write: Accept and return EMACS_INT for sizes.
10830 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10831 et seq.
10832 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10833 Accept and return EMACS_INT.
10834 (emacs_gnutls_write): Return the number of bytes written on
10835 partial writes.
10836 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10837 (emacs_read, emacs_write): Remove check for negative size, as the
10838 Emacs source code has been audited now.
10839 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10840 (emacs_read, emacs_write): Use it.
10841 * process.c (send_process): Adjust to the new signatures of
10842 emacs_write and emacs_gnutls_write. Do not attempt to store
10843 a byte offset into an 'int'; it might overflow.
10844 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10845
10846 * sound.c: Don't assume sizes fit in 'int'.
10847 (struct sound_device.period_size, alsa_period_size):
10848 Return EMACS_INT, not int.
10849 (struct sound_device.write, vox_write, alsa_write):
10850 Accept EMACS_INT, not int.
10851 (wav_play, au_play): Use EMACS_INT to store sizes and to
10852 record read return values.
10853
10854 2011-04-15 Ben Key <bkey76@gmail.com>
10855
10856 * keyboard.c (Qundefined): Don't declare static since it is used
10857 in nsfns.m.
10858 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10859 static since they are used in nsfont.m.
10860
10861 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10862
10863 * process.c (Qprocessp): Don't declare static.
10864 * lisp.h (Qprocessp): Declare again.
10865
10866 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10867
10868 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10869
10870 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10871
10872 Improve C-level modularity by making more things 'static'.
10873
10874 Don't publish debugger-only interfaces to other modules.
10875 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10876 (verify_bytepos, count_markers): Move decls to the only modules
10877 that need them.
10878 * region-cache.h (pp_cache): Likewise.
10879 * window.h (check_all_windows): Likewise.
10880 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10881
10882 * sysdep.c (croak): Now static, if
10883 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10884 * syssignal.h (croak): Declare only if not static.
10885
10886 * alloc.c (refill_memory_reserve): Now static if
10887 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10888 * lisp.h (refill_memory_reserve): Declare only if not static.
10889
10890 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10891 Define only if USE_LUCID.
10892
10893 * xrdb.c (x_customization_string, x_rm_string): Now static.
10894
10895 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10896 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10897
10898 * xdisp.c (draw_row_with_mouse_face): Now static.
10899 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10900
10901 * window.h (check_all_windows): Mark externally visible.
10902
10903 * window.c (window_deletion_count): Now static.
10904
10905 * undo.c: Make symbols static if they're not exported.
10906 (last_undo_buffer, last_boundary_position, pending_boundary):
10907 Now static.
10908
10909 * textprop.c (interval_insert_behind_hooks): Now static.
10910 (interval_insert_in_front_hooks): Likewise.
10911
10912 * term.c: Make symbols static if they're not exported.
10913 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10914 (max_frame_lines, tty_set_terminal_modes):
10915 (tty_reset_terminal_modes, tty_turn_off_highlight):
10916 (get_tty_terminal): Now static.
10917 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10918 * termhooks.h (term_mouse_moveto): Do not declare if
10919 HAVE_WINDOW_SYSTEM.
10920 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10921 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10922
10923 * sysdep.c: Make symbols static if they're not exported.
10924 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10925 Now static.
10926 (sigprocmask_set, full_mask): Remove; unused.
10927 (wait_debugging): Mark as visible.
10928 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10929 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10930
10931 * syntax.c (syntax_temp): Define only if !__GNUC__.
10932
10933 * sound.c (current_sound_device, current_sound): Now static.
10934
10935 * search.c (searchbufs, searchbuf_head): Now static.
10936
10937 * scroll.c (scroll_cost): Remove; unused.
10938 * dispextern.h (scroll_cost): Remove decl.
10939
10940 * region-cache.h (pp_cache): Mark as externally visible.
10941
10942 * process.c: Make symbols static if they're not exported.
10943 (process_tick, update_tick, create_process, chan_process):
10944 (Vprocess_alist, proc_buffered_char, datagram_access):
10945 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10946 (deactivate_process): Mark defn as static, as well as decl.
10947 * lisp.h (create_process): Remove decl.
10948 * process.h (chan_process, Vprocess_alist): Remove decls.
10949
10950 * print.c: Make symbols static if they're not exported.
10951 (print_depth, new_backquote_output, being_printed, print_buffer):
10952 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10953 (print_interval, print_number_index, initial_stderr_stream):
10954 Now static.
10955 * lisp.h (Fprinc): Remove decl.
10956 (debug_output_compilation_hack): Mark as externally visible.
10957
10958 * sysdep.c (croak): Move decl from here to syssignal.h.
10959 * syssignal.h (croak): Put it here, so the API can be checked when
10960 'croak' is called from dissociate_if_controlling_tty.
10961
10962 * minibuf.c: Make symbols static if they're not exported.
10963 (minibuf_save_list, choose_minibuf_frame): Now static.
10964 * lisp.h (choose_minibuf_frame): Remove decl.
10965
10966 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10967
10968 * lread.c: Make symbols static if they're not exported.
10969 (read_objects, initial_obarray, oblookup_last_bucket_number):
10970 Now static.
10971 (make_symbol): Remove; unused.
10972 * lisp.h (initial_obarray, make_symbol): Remove decls.
10973
10974 * keyboard.c: Make symbols static if they're not exported.
10975 (single_kboard, recent_keys_index, total_keys, recent_keys):
10976 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10977 (this_single_command_key_start, echoing, last_auto_save):
10978 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10979 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10980 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10981 (Vlispy_mouse_stem, double_click_count):
10982 Now static.
10983 (force_auto_save_soon): Define only if SIGDANGER.
10984 (ignore_mouse_drag_p): Now static if
10985 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10986 (print_help): Remove; unused.
10987 (stop_character, last_timer_event): Mark as externally visible.
10988 * keyboard.h (ignore_mouse_drag_p): Declare only if
10989 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10990 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10991 * lisp.h (echoing): Remove decl.
10992 (force_auto_save_soon): Declare only if SIGDANGER.
10993 * xdisp.c (redisplay_window): Simplify code, to make it more
10994 obvious that ignore_mouse_drag_p is not accessed if !defined
10995 USE_GTK && !defined HAVE_NS.
10996
10997 * intervals.c: Make symbols static if they're not exported.
10998 (merge_properties_sticky, merge_interval_right, delete_interval):
10999 Now static.
11000 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11001
11002 * insdel.c: Make symbols static if they're not exported.
11003 However, leave prepare_to_modify_buffer alone. It's never
11004 called from outside this function, but that appears to be a bug.
11005 (combine_after_change_list, combine_after_change_buffer):
11006 (adjust_after_replace, signal_before_change): Now static.
11007 (adjust_after_replace_noundo): Remove; unused.
11008 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11009 (signal_before_change): Remove decls.
11010
11011 * indent.c (val_compute_motion, val_vmotion): Now static.
11012
11013 * image.c: Make symbols static if they're not exported.
11014 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11015 if USE_GTK.
11016 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11017 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11018
11019 * fringe.c (standard_bitmaps): Now static.
11020 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11021
11022 * frame.c: Make symbols static if they're not exported.
11023 (x_report_frame_params, make_terminal_frame): Now static.
11024 (get_frame_param): Now static, unless HAVE_NS.
11025 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11026 (x_get_resource_string): Remove; not used.
11027 * frame.h (make_terminal_frame, x_report_frame_params):
11028 (x_get_resource_string); Remove decls.
11029 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11030 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11031
11032 * font.c, fontset.c: Make symbols static if they're not exported.
11033 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11034 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11035 * font.c (font_close_object): Now static.
11036 * font.h (font_close_object): Remove.
11037 * fontset.c (FONTSET_OBJLIST): Remove.
11038 (free_realized_fontset) #if-0 the body, which does nothing.
11039 (face_suitable_for_char_p): #if-0, as it's never called.
11040 * fontset.h (face_suitable_for_char_p): Remove decl.
11041 * xfaces.c (face_at_string_position):
11042 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11043 since 0 is always ASCII.
11044
11045 * fns.c (weak_hash_tables): Now static.
11046
11047 * fileio.c: Make symbols static if they're not exported.
11048 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11049 (Vwrite_region_annotation_buffers): Now static.
11050
11051 * eval.c: Make symbols static if they're not exported.
11052 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11053 * lisp.h (backtrace_list): Remove decl.
11054
11055 * emacs.c: Make symbols static if they're not exported.
11056 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11057 (fatal_error_code, fatal_error_signal_hook, standard_args):
11058 Now static.
11059 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11060 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11061 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11062 * lisp.h (fatal_error_signal_hook): Remove decl.
11063 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11064
11065 * editfns.c: Move a (normally-unused) function to its only use.
11066 * editfns.c, lisp.h (get_operating_system_release): Remove.
11067 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11068 worth the hassle of breaking this out.
11069
11070 * xterm.c: Make symbols static if they're not exported.
11071 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11072 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11073 (x_destroy_window, x_delete_display):
11074 Now static.
11075 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11076 (x_mouse_leave): Remove; unused.
11077 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11078 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11079 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11080 Remove decls.
11081 (x_mouse_leave): Declare only if WINDOWSNT.
11082 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11083 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11084 USE_X_TOOLKIT.
11085
11086 * ftxfont.c: Make symbols static if they're not exported.
11087 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11088 HAVE_FREETYPE.
11089 * font.h (ftxfont_driver): Likewise.
11090
11091 * xfns.c: Make symbols static if they're not exported.
11092 (x_last_font_name, x_display_info_for_name):
11093 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11094 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11095 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11096 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11097 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11098 (last_show_tip_args): Now static.
11099 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11100 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11101 (x_screen_planes): Remove; unused.
11102 * dispextern.h (x_screen_planes): Remove decl.
11103
11104 * dispnew.c: Make symbols static if they're not exported.
11105 * dispextern.h (redraw_garbaged_frames, scrolling):
11106 (increment_row_positions): Remove.
11107 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11108 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11109 Now static.
11110 (redraw_garbaged_frames): Remove; unused.
11111
11112 * xfaces.c: Make symbols static if they're not exported.
11113 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11114 Remove decls.
11115 * xterm.h (defined_color): Remove decls.
11116 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11117 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11118 (menu_face_changed_default, defined_color, free_realized_face):
11119 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11120 (ascii_face_of_lisp_face): Remove; unused.
11121
11122 * xdisp.c: Make symbols static if they're not exported.
11123 * dispextern.h (scratch_glyph_row, window_box_edges):
11124 (glyph_to_pixel_coords, set_cursor_from_row):
11125 (get_next_display_element, set_iterator_to_next):
11126 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11127 (show_mouse_face): Remove decls
11128 * frame.h (message_buf_print): Likewise.
11129 * lisp.h (pop_message, set_message, check_point_in_composition):
11130 Likewise.
11131 * xterm.h (set_vertical_scroll_bar): Likewise.
11132 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11133 (message_buf_print, scratch_glyph_row, displayed_buffer):
11134 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11135 (get_next_display_element, show_mouse_face, window_box_edges):
11136 (frame_to_window_pixel_xy, check_point_in_composition):
11137 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11138 (glyph_to_pixel_coords): Remove; unused.
11139
11140 * dired.c (file_name_completion): Now static.
11141
11142 * dbusbind.c (xd_in_read_queued_messages): Now static.
11143
11144 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11145 * data.c (circular_list_error): Remove.
11146
11147 * commands.h (last_point_position, last_point_position_buffer):
11148 (last_point_position_window): Remove decls.
11149 * keyboard.c: Make these variables static.
11150
11151 * coding.h (coding, code_convert_region, encode_coding_gap):
11152 Remove decls.
11153 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11154 (iso_code_class, detect_coding, code_convert_region): Now static.
11155 (encode_coding_gap): Remove; unused.
11156
11157 * chartab.c (chartab_chars, chartab_bits): Now static.
11158
11159 * charset.h (charset_iso_8859_1): Remove decl.
11160 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11161 Now static.
11162
11163 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11164 * ccl.c (Vccl_program_table): Now static.
11165 (check_ccl_update): Remove; unused.
11166
11167 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11168 * category.h: ... from here.
11169 * category.c (check_category_table, set_category_set): Now static.
11170
11171 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11172 * lisp.h: Remove these decls.
11173
11174 * buffer.c (buffer_count): Remove unused var.
11175
11176 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11177 so that it's not optimized away.
11178 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11179 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11180 exported only to the debugger.
11181
11182 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11183 * atimer.h (run_all_atimers): Remove; not exported.
11184
11185 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11186 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11187 was inaccessible from Lisp.
11188 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11189 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11190
11191 alloc.c: Import and export fewer symbols, and remove unused items.
11192 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11193 is defined.
11194 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11195 it's not optimized away by whole-program optimization.
11196 (message_enable_multibyte, free_misc): Remove.
11197 (catchlist, handlerlist, mark_backtrace):
11198 Declare only if BYTE_MARK_STACK.
11199 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11200 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11201 (message_enable_multibyte): Remove decl.
11202 (free_misc, interval_free_list, float_block, float_block_index):
11203 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11204 (cons_free_list, last_marked_index):
11205 Now static.
11206 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11207 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11208 (mark_backtrace): Define only if BYTE_MARK_STACK.
11209 * xdisp.c (message_enable_multibyte): Now static.
11210
11211 Declare Lisp_Object Q* variables to be 'static' if not exported.
11212 This makes it easier for human readers (and static analyzers)
11213 to see whether these variables are used from other modules.
11214 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11215 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11216 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11217 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11218 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11219 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11220 * xmenu.c, xselect.c:
11221 Declare Q* vars static if they are not used in other modules.
11222 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11223 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11224 Remove decls of unexported vars.
11225 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11226
11227 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11228
11229 Make Emacs functions such as Fatom 'static' by default.
11230 This makes it easier for human readers (and static analyzers)
11231 to see whether these functions can be called from other modules.
11232 DEFUN now defines a static function. To make the function external
11233 so that it can be used in other C modules, use the new macro DEFUE.
11234 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11235 (Finit_image_library):
11236 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11237 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11238 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11239 Remove decls, since these functions are now static.
11240 (Funintern, Fget_internal_run_time): New decls, since these functions
11241 were already external.
11242
11243 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11244 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11245 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11246 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11247 * keyboard.c, keymap.c, lread.c:
11248 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11249 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11250 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11251 Mark functions with DEFUE instead of DEFUN,
11252 if they are used in other modules.
11253 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11254 decls for now-static functions.
11255 * buffer.h (Fdelete_overlay): Remove decl.
11256 * callproc.c (Fgetenv_internal): Mark as internal.
11257 * composite.c (Fremove_list_of_text_properties): Remove decl.
11258 (Fcomposition_get_gstring): New forward static decl.
11259 * composite.h (Fcomposite_get_gstring): Remove decl.
11260 * dired.c (Ffile_attributes): New forward static decl.
11261 * doc.c (Fdocumntation_property): New forward static decl.
11262 * eval.c (Ffetch_bytecode): New forward static decl.
11263 (Funintern): Remove extern decl; now in .h file where it belongs.
11264 * fileio.c (Fmake_symbolic_link): New forward static decl.
11265 * image.c (Finit_image_library): New forward static decl.
11266 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11267 * intervals.h (Fprevious_property_change):
11268 (Fremove_list_of_text_properties): Remove decls.
11269 * keyboard.c (Fthis_command_keys): Remove decl.
11270 (Fcommand_execute): New forward static decl.
11271 * keymap.c (Flookup_key): New forward static decl.
11272 (Fcopy_keymap): Now static.
11273 * keymap.h (Flookup_key): Remove decl.
11274 * process.c (Fget_process): New forward static decl.
11275 (Fprocess_datagram_address): Mark as internal.
11276 * syntax.c (Fsyntax_table_p): New forward static decl.
11277 (skip_chars): Remove duplicate decl.
11278 * textprop.c (Fprevious_property_change): New forward static decl.
11279 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11280 Now internal.
11281 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11282 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11283
11284 * editfns.c (Fformat): Remove unreachable code.
11285
11286 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11287
11288 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11289 change. (Bug#8496)
11290
11291 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11292
11293 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11294 when at ZV. (Bug#8487)
11295
11296 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11297
11298 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11299 (Bug#8437)
11300 * keyboard.c (parse_tool_bar_item): Likewise.
11301 * sound.c (sound_cleanup, alsa_close): Likewise.
11302 * termcap.c (tgetent): Likewise.
11303 * xfns.c (x_default_font_parameter): Likewise.
11304 * xsettings.c (read_and_apply_settings): Likewise.
11305
11306 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11307 (overrun_check_free): Protoize.
11308
11309 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11310
11311 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11312 since callers should never pass a negative size.
11313 Change the signature to match that of plain 'read' and 'write'; see
11314 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11315 * lisp.h: Update prototypes of emacs_write and emacs_read.
11316
11317 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11318
11319 * xdisp.c (redisplay_window): Don't try to determine the character
11320 position of the scroll margin if the window start point w->startp
11321 is outside the buffer's accessible region. (Bug#8468)
11322
11323 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11324
11325 Fix write-region and its subroutines for buffers > 2GB.
11326 * fileio.c (a_write, e_write): Modify declaration of arguments and
11327 local variables to support buffers larger than 2GB.
11328 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11329
11330 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11331 argument, local variables, and return value.
11332
11333 * lisp.h: Update prototypes of emacs_write and emacs_read.
11334
11335 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11336
11337 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11338
11339 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11340
11341 Fix more problems found by GCC 4.6.0's static checks.
11342
11343 * xdisp.c (vmessage): Use a better test for character truncation.
11344
11345 * charset.c (load_charset_map): <, not <=, for optimization,
11346 and to avoid potential problems with integer overflow.
11347 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11348 * casetab.c (set_identity, shuffle): Likewise.
11349 * editfns.c (Fformat): Likewise.
11350 * syntax.c (skip_chars): Likewise.
11351
11352 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11353 This also lets GCC 4.6.0 generate slightly better loop code.
11354
11355 * callint.c (Fcall_interactively): <, not <=, for optimization.
11356 (Fcall_interactively): Count the number of arguments produced,
11357 not the number of arguments given. This is simpler and lets GCC
11358 4.6.0 generate slightly better code.
11359
11360 * ftfont.c: Distingish more carefully between FcChar8 and char.
11361 The previous code passed unsigned char * to a functions like
11362 strlen and xstrcasecmp that expect char *, which does not
11363 conform to the C standard.
11364 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11365 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11366 char * when the C standard requires it.
11367
11368 * keyboard.c (read_char): Remove unused var.
11369
11370 * eval.c: Port to Windows vsnprintf (Bug#8435).
11371 Include <limits.h>.
11372 (SIZE_MAX): Define if the headers do not.
11373 (verror): Do not give up if vsnprintf returns a negative count.
11374 Instead, grow the buffer. This ports to Windows vsnprintf, which
11375 does not conform to C99. Problem reported by Eli Zaretskii.
11376 Also, simplify the allocation scheme, by avoiding the need for
11377 calling realloc, and removing the ALLOCATED variable.
11378
11379 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11380
11381 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11382 But keep the doprint source code for now, as we might revamp it
11383 and use it again (Bug#8435).
11384 * lisp.h (doprnt): Remove.
11385 * Makefile.in (base_obj): Remove doprnt.o.
11386 * deps.mk (doprnt.o): Remove.
11387
11388 error: Print 32- and 64-bit integers portably (Bug#8435).
11389 Without this change, on typical 64-bit hosts error ("...%d...", N)
11390 was used to print both 32- and 64-bit integers N, which relied on
11391 undefined behavior.
11392 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11393 * lisp.h (error, verror): Mark as printf-like functions.
11394 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11395 Report overflow in size calculations when allocating printf buffer.
11396 Do not truncate output string at its first null byte.
11397 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11398 Truncate the output at a character boundary, since vsnprintf does not
11399 do that.
11400 * charset.c (check_iso_charset_parameter): Convert internal
11401 character to string before calling 'error', since %c now has the
11402 printf meaning.
11403 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11404 overflow when computing char to be passed to 'error'. Do not
11405 pass Lisp_Object to 'error'; pass the integer instead.
11406 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11407 formatted with plain %d.
11408
11409 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11410
11411 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11412
11413 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11414
11415 * xterm.c (x_catch_errors): Remove duplicate declaration.
11416
11417 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11418
11419 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11420
11421 2011-04-10 Jim Meyering <meyering@redhat.com>
11422
11423 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11424 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11425 return ssize_t not "int", and use size_t as the buffer length.
11426 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11427 * gnutls.h: Update declarations.
11428 * process.c (read_process_output): Use ssize_t, to match.
11429 (send_process): Likewise.
11430
11431 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11432
11433 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11434
11435 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11436
11437 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11438 Use unsigned char, to match FcChar8 type definition.
11439
11440 * xterm.c (handle_one_xevent):
11441 * xmenu.c (create_and_show_popup_menu):
11442 * xselect.c (x_decline_selection_request)
11443 (x_reply_selection_request): Avoid type-punned deref of X events.
11444
11445 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11446
11447 Fix some uses of `int' instead of EMACS_INT.
11448 * search.c (string_match_1, fast_string_match)
11449 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11450 (scan_buffer, find_next_newline_no_quit)
11451 (find_before_next_newline, search_command, Freplace_match)
11452 (Fmatch_data): Make some `int' variables be EMACS_INT.
11453
11454 * xdisp.c (display_count_lines): 3rd argument and return value now
11455 EMACS_INT. All callers changed.
11456 (pint2hrstr): Last argument is now EMACS_INT.
11457
11458 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11459 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11460 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11461 (decode_coding_utf_16, decode_coding_emacs_mule)
11462 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11463 (decode_coding_ccl, decode_coding_charset)
11464 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11465 (decode_coding_iso_2022, decode_coding_emacs_mule)
11466 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11467 <char_offset, last_offset>: Declare EMACS_INT.
11468 (encode_coding_utf_8, encode_coding_utf_16)
11469 (encode_coding_emacs_mule, encode_invocation_designation)
11470 (encode_designation_at_bol, encode_coding_iso_2022)
11471 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11472 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11473 Declare EMACS_INT.
11474 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11475 (encode_invocation_designation): Last argument P_NCHARS is now
11476 EMACS_INT.
11477 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11478 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11479
11480 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11481 All users changed.
11482
11483 * ccl.c (Fccl_execute_on_string): Declare some variables
11484 EMACS_INT.
11485
11486 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11487
11488 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11489
11490 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11491
11492 * process.c (Fformat_network_address): Doc fix.
11493
11494 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11495
11496 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11497
11498 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11499
11500 * keyboard.c (read_char): Call Lisp function help-form-show,
11501 instead of using internal_with_output_to_temp_buffer.
11502 (Qhelp_form_show): New var.
11503 (syms_of_keyboard): Use DEFSYM macro.
11504
11505 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11506
11507 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11508
11509 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11510
11511 * process.c (Flist_processes): Remove to Lisp.
11512 (list_processes_1): Delete.
11513
11514 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11515
11516 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11517
11518 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11519
11520 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11521
11522 Fix more problems found by GCC 4.6.0's static checks.
11523
11524 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11525
11526 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11527
11528 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11529
11530 * xdisp.c (vmessage): Mark as a printf-like function.
11531
11532 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11533
11534 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11535
11536 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11537 printf-like functions.
11538 (tiff_load): Add casts to remove these marks before passing them
11539 to system-supplied API.
11540
11541 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11542
11543 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11544 This avoids several warnings with gcc -Wstrict-overflow.
11545 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11546 directly, rather than having caller test rule sign. This avoids
11547 some unnecessary tests.
11548 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11549 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11550 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11551
11552 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11553 (xfont_open): Avoid unnecessary tests.
11554
11555 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11556
11557 * composite.h, composite.c (composition_gstring_put_cache):
11558 Use EMACS_INT, not int, for length.
11559
11560 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11561 breaking out part of COMPOSITION_DECODE_RULE.
11562 (COMPOSITION_DECODE_RULE): Use it.
11563 * composite.c (get_composition_id): Remove unused local vars,
11564 by using the new macro.
11565
11566 * textprop.c (set_text_properties_1): Change while to do-while,
11567 since the condition is always true at first.
11568
11569 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11570 (interval_deletion_adjustment): Return unsigned value.
11571 All uses changed.
11572
11573 * process.c (list_processes_1, create_pty, read_process_output):
11574 (exec_sentinel): Remove vars that were set but not used.
11575 (create_pty): Remove unnecessary "volatile"s.
11576 (Fnetwork_interface_info): Avoid possibility of int overflow.
11577 (read_process_output): Do adaptive read buffering even if carryover.
11578 (read_process_output): Simplify nbytes computation if buffered.
11579
11580 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11581
11582 * syntax.c (scan_words): Remove var that was set but not used.
11583 (update_syntax_table): Use unsigned instead of int.
11584
11585 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11586 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11587 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11588
11589 * print.c (print_error_message): Avoid int overflow.
11590
11591 * font.c (font_list_entities): Redo for clarity,
11592 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11593
11594 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11595 (font_score): Avoid potential overflow in diff calculation.
11596
11597 * fns.c (substring_both): Remove var that is set but not used.
11598 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11599
11600 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11601
11602 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11603 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11604 can always succeed if overflow has undefined behavior.
11605
11606 * search.c (boyer_moore, wordify): Remove vars set but not used.
11607 (wordify): Omit three unnecessary tests.
11608
11609 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11610 All callers changed. This avoids the need for an unused var.
11611
11612 * casefiddle.c (casify_region): Remove var that is set but not used.
11613
11614 * dired.c (file_name_completion): Remove var that is set but not used.
11615
11616 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11617
11618 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11619 (Finsert_file_contents): Remove unnecessary code checking fd.
11620
11621 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11622 Check for integer overflow on size calculations.
11623
11624 * buffer.c (Fprevious_overlay_change): Remove var that is set
11625 but not used.
11626
11627 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11628 Remove vars that are set but not used.
11629 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11630 (timer_check_2): Mark vars as initialized.
11631
11632 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11633
11634 * image.c (lookup_image): Remove var that is set but not used.
11635 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11636
11637 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11638 that are set but not used.
11639
11640 * xfns.c (make_invisible_cursor): Don't return garbage
11641 if XCreateBitmapFromData fails (Bug#8410).
11642
11643 * xselect.c (x_get_local_selection, x_handle_property_notify):
11644 Remove vars that are set but not used.
11645
11646 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11647 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11648
11649 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11650 Remove var that is set but not used.
11651 (scroll_bar_windows_size): Now size_t, not int.
11652 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11653 Check for overflow.
11654
11655 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11656 (map_tty_color) [!defined MSDOS]: Likewise.
11657
11658 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11659
11660 * coding.c: Remove vars that are set but not used.
11661 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11662 All callers changed.
11663 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11664 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11665 (decode_coding_charset): Remove vars that are set but not used.
11666
11667 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11668 that is set but not used.
11669
11670 * print.c (print_object): Remove var that is set but not used.
11671
11672 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11673 The gnulib version avoids calling malloc in the usual case,
11674 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11675 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11676 * filelock.c (current_lock_owner): Likewise.
11677 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11678 * sysdep.c: Include allocator.h, careadlinkat.h.
11679 (emacs_no_realloc_allocator): New static constant.
11680 (emacs_readlink): New function.
11681 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11682 ../lib/careadlinkat.h.
11683
11684 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11685
11686 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11687 first non-nil return value).
11688
11689 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11690
11691 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11692 if not defined (Bug#8403).
11693
11694 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11695
11696 * xdisp.c (display_count_lines): Remove parameter `start',
11697 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11698 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11699 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11700 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11701 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11702 and thereabouts. All callers changed.
11703 (get_per_char_metric): Remove parameter `f', unused since
11704 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11705
11706 2011-04-02 Jim Meyering <meyering@redhat.com>
11707
11708 do not dereference NULL upon failed strdup
11709 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11710 (ns_get_family): Likewise.
11711
11712 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11713
11714 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11715
11716 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11717
11718 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11719 later (Bug#8403).
11720
11721 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11722
11723 Add lexical binding.
11724
11725 * window.c (Ftemp_output_buffer_show): New fun.
11726 (Fsave_window_excursion):
11727 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11728
11729 * lread.c (lisp_file_lexically_bound_p): New function.
11730 (Fload): Bind Qlexical_binding.
11731 (readevalloop): Remove `evalfun' arg.
11732 Bind Qinternal_interpreter_environment.
11733 (Feval_buffer): Bind Qlexical_binding.
11734 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11735 Mark as dynamic.
11736 (syms_of_lread): Declare `lexical-binding'.
11737
11738 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11739
11740 * keyboard.c (eval_dyn): New fun.
11741 (menu_item_eval_property): Use it.
11742
11743 * image.c (parse_image_spec): Use Ffunctionp.
11744
11745 * fns.c (concat, mapcar1): Accept byte-code-functions.
11746
11747 * eval.c (Fsetq): Handle lexical vars.
11748 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11749 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11750 (FletX, Flet): Obey lexical binding.
11751 (Fcommandp): Handle closures.
11752 (Feval): New `lexical' arg.
11753 (eval_sub): New function extracted from Feval. Use it almost
11754 everywhere where Feval was used. Look up vars in lexical env.
11755 Handle closures.
11756 (Ffunctionp): Move from subr.el.
11757 (Ffuncall): Handle closures.
11758 (apply_lambda): Remove `eval_flags'.
11759 (funcall_lambda): Handle closures and new byte-code-functions.
11760 (Fspecial_variable_p): New function.
11761 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11762 but without exporting it to Lisp.
11763
11764 * doc.c (Fdocumentation, store_function_docstring):
11765 * data.c (Finteractive_form): Handle closures.
11766
11767 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11768 interactive spec.
11769
11770 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11771 New byte-codes.
11772 (exec_byte_code): New function extracted from Fbyte_code to handle new
11773 calling convention for byte-code-functions. Add new byte-codes.
11774
11775 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11776
11777 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11778
11779 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11780
11781 * xdisp.c (redisplay_internal): Fix prototype.
11782
11783 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11784
11785 * xdisp.c (SCROLL_LIMIT): New macro.
11786 (try_scrolling): Use it when setting scroll_limit.
11787 Limit scrolling to 100 screen lines.
11788 (redisplay_window): Even when falling back on "recentering",
11789 position point in the window according to scroll-conservatively,
11790 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11791
11792 (try_scrolling): When point is above the window, allow searching
11793 as far as scroll_max, or one screenful, to compute vertical
11794 distance from PT to the scroll margin position. This prevents
11795 try_scrolling from unnecessarily failing when
11796 scroll-conservatively is set to a value slightly larger than the
11797 window height. Clean up the case of PT below the margin at bottom
11798 of window: scroll_max can no longer be INT_MAX. When aggressive
11799 scrolling is in use, don't let point enter the opposite scroll
11800 margin as result of the scroll.
11801 (syms_of_xdisp) <scroll-conservatively>: Document the
11802 threshold of 100 lines for never-recentering scrolling.
11803
11804 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11805
11806 * dispextern.h (move_it_by_lines):
11807 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11808 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11809 (message_log_check_duplicate): Remove parameters `prev_bol' and
11810 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11811 (redisplay_internal): Remove parameter `preserve_echo_area',
11812 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11813
11814 * indent.c (Fvertical_motion):
11815 * window.c (window_scroll_pixel_based, Frecenter):
11816 Don't pass `need_y_p' to `move_it_by_lines'.
11817
11818 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11819
11820 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11821 steal a few bits to be more compact.
11822 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11823 Remove unneeded casts.
11824
11825 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11826
11827 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11828
11829 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11830 binding" message (bug#7967).
11831
11832 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11833
11834 Fix more problems found by GCC 4.6.0's static checks.
11835
11836 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11837 Remove unused local var.
11838
11839 * editfns.c (Fmessage_box): Remove unused local var.
11840
11841 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11842 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11843 Omit unused local vars.
11844 * window.c (shrink_windows): Omit unused local var.
11845 * menu.c (digest_single_submenu): Omit unused local var.
11846 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11847 Omit unused local var.
11848
11849 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11850 Don't assume string length fits in int.
11851 (keyremap_step, read_key_sequence): Use size_t for sizes.
11852 (read_key_sequence): Don't check last_real_key_start redundantly.
11853
11854 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11855 instead of alloca (Bug#8344).
11856
11857 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11858 (Fbacktrace_frame): Don't assume nframes fits in int.
11859
11860 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11861
11862 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11863 concerns.
11864
11865 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11866
11867 * cm.c (calccost): Turn while-do into do-while, for clarity.
11868
11869 * keyboard.c (syms_of_keyboard): Use the same style as later
11870 in this function when indexing through an array. This also
11871 works around GCC bug 48267.
11872
11873 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11874
11875 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11876
11877 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11878 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11879
11880 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11881 This avoids undefined behavior on integer overflow, and is a bit
11882 more convenient anyway since it is compared to a size_t variable.
11883
11884 Variadic C functions now count arguments with size_t, not int.
11885 This avoids an unnecessary limitation on 64-bit machines, which
11886 caused (substring ...) to crash on large vectors (Bug#8344).
11887 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11888 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11889 All variadic functions and their callers changed accordingly.
11890 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11891 * data.c (arith_driver, float_arith_driver): Likewise.
11892 * editfns.c (general_insert_function): Likewise.
11893 * eval.c (struct backtrace.nargs, interactive_p)
11894 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11895 (funcall_lambda, mark_backtrace): Likewise.
11896 * fns.c (concat): Likewise.
11897 * frame.c (x_set_frame_parameters): Likewise.
11898 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11899 0 if not found, not -1. All callers changed.
11900
11901 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11902 (stack_copy_size): Now size_t, not int.
11903 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11904
11905 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11906
11907 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11908 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11909 All callers changed.
11910
11911 * lisp.h (multibyte_char_to_unibyte):
11912 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11913 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11914 * character.h (CHAR_TO_BYTE8):
11915 * cmds.c (internal_self_insert):
11916 * editfns.c (general_insert_function):
11917 * keymap.c (push_key_description):
11918 * search.c (Freplace_match):
11919 * xdisp.c (message_dolog, set_message_1): All callers changed.
11920
11921 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11922
11923 * keyboard.c (safe_run_hook_funcall): New function.
11924 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11925 don't set the hook to nil, but remove the offending function instead.
11926 (Qcommand_hook_internal): Remove, unused.
11927 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11928 Vcommand_hook_internal.
11929
11930 * eval.c (enum run_hooks_condition): Remove.
11931 (funcall_nil, funcall_not): New functions.
11932 (run_hook_with_args): Call each function through a `funcall' argument.
11933 Remove `cond' argument, now redundant.
11934 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11935 (Frun_hook_with_args_until_failure): Adjust accordingly.
11936 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11937
11938 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11939
11940 * dispextern.h (string_buffer_position): Remove declaration.
11941
11942 * print.c (strout): Remove parameter `multibyte', unused since
11943 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11944
11945 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11946 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11947 All callers changed.
11948
11949 * w32.c (_wsa_errlist): Use braces for struct initializers.
11950
11951 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11952 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11953 All callers changed.
11954 (string_buffer_position): Likewise. Also, make static (it's never
11955 used outside xdisp.c).
11956 (cursor_row_p): Remove parameter `w', unused since
11957 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11958 (decode_mode_spec): Remove parameter `precision', introduced during
11959 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11960 All callers changed.
11961
11962 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11963
11964 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11965
11966 2011-03-27 Anders Lindgren <andlind@gmail.com>
11967
11968 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11969 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11970 (ns_update_auto_hide_menu_bar): New functions.
11971 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11972 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11973 ns_constrain_all_frames.
11974 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11975 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11976
11977 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11978
11979 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11980
11981 2011-03-27 Glenn Morris <rgm@gnu.org>
11982
11983 * syssignal.h: Replace RETSIGTYPE with void.
11984 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11985 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11986 Replace SIGTYPE with void everywhere.
11987 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11988 * s/template.h (SIGTYPE): Remove commented out definition.
11989
11990 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11991
11992 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11993 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11994
11995 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11996
11997 * w32.c (read_unc_volume): Use parameter `henum', instead of
11998 global variable `wget_enum_handle'.
11999
12000 * keymap.c (describe_vector): Remove parameters `indices' and
12001 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12002 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12003
12004 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12005
12006 * keyboard.c (timer_check): Remove parameter `do_it_now',
12007 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12008 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12009 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12010
12011 * keyboard.c (read_char):
12012 * w32menu.c (w32_menu_display_help):
12013 * xmenu.c (show_help_event, menu_help_callback):
12014 Adjust calls to `show_help_echo'.
12015
12016 * gtkutil.c (xg_maybe_add_timer):
12017 * keyboard.c (readable_events):
12018 * process.c (wait_reading_process_output):
12019 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12020
12021 * insdel.c (adjust_markers_gap_motion):
12022 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12023 (gap_left, gap_right): Don't call it.
12024
12025 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12026
12027 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12028 incurred during fontification.
12029
12030 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12031
12032 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12033 (DEFVAR_PER_BUFFER): Don't pass it.
12034
12035 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12036 (scrolling_window): Don't pass it.
12037
12038 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12039
12040 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12041
12042 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12043 and `suffix'.
12044 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12045 of variables specific to SELinux and computation of `encoded_absname'.
12046
12047 * image.c (XPutPixel): Remove unused variable `height'.
12048
12049 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12050
12051 * unexw32.c (get_section_info): Remove unused variable `section'.
12052
12053 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12054 (system_process_attributes): Remove unused variable `sess'.
12055 (sys_read): Remove unused variable `err'.
12056
12057 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12058 (w32_wnd_proc): Remove unused variable `isdead'.
12059 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12060 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12061 (x_create_tip_frame): Remove unused variable `tem'.
12062
12063 * w32inevt.c (w32_console_read_socket):
12064 Remove unused variable `no_events'.
12065
12066 * w32term.c (x_draw_composite_glyph_string_foreground):
12067 Remove unused variable `width'.
12068
12069 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12070
12071 * w32term.c (x_set_glyph_string_clipping):
12072 Don't pass uninitialized region to CombineRgn.
12073
12074 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12075
12076 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12077 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12078 (Fx_close_connection): Remove unused variable `i'.
12079
12080 * w32font.c (w32font_draw): Return number of glyphs.
12081 (w32font_open_internal): Remove unused variable `i'.
12082 (w32font_driver): Add missing initializer.
12083
12084 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12085 (fill_in_menu): Remove unused variable `items_added'.
12086
12087 * w32term.c (last_mouse_press_frame): Remove static global variable.
12088 (w32_clip_to_row): Remove unused variable `f'.
12089 (x_delete_terminal): Remove unused variable `i'.
12090
12091 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12092 (NOTHING): Remove unused static global variable.
12093 (uniscribe_check_otf): Remove unused variable `table'.
12094 (uniscribe_font_driver): Add missing initializers.
12095
12096 2011-03-23 Julien Danjou <julien@danjou.info>
12097
12098 * term.c (Fsuspend_tty, Fresume_tty):
12099 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12100 * window.c (temp_output_buffer_show):
12101 * insdel.c (signal_before_change):
12102 * frame.c (Fhandle_switch_frame):
12103 * fileio.c (Fdo_auto_save):
12104 * emacs.c (Fkill_emacs):
12105 * editfns.c (save_excursion_restore):
12106 * cmds.c (internal_self_insert):
12107 * callint.c (Fcall_interactively):
12108 * buffer.c (Fkill_all_local_variables):
12109 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12110 Use Frun_hooks.
12111 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12112 unconditionally since it does the check itself.
12113
12114 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12115
12116 Fix more problems found by GCC 4.5.2's static checks.
12117
12118 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12119 the first time through the loop, since we know p0 < p1 then.
12120 This also avoids a gcc -Wstrict-overflow warning.
12121
12122 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12123 leading to a memory leak, possible in functions like
12124 load_charset_map_from_file that can allocate an unbounded number
12125 of objects (Bug#8318).
12126
12127 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12128 that could (at least in theory) be that large.
12129
12130 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12131 This is less likely to overflow, and avoids undefined behavior if
12132 overflow does occur. All callers changed. Use strtoul to scan
12133 for the unsigned long integer.
12134 (pint2hrstr): Simplify and tune code slightly.
12135 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12136
12137 * scroll.c (do_scrolling): Work around GCC bug 48228.
12138 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12139
12140 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12141 This also avoids a warning with gcc -Wstrict-overflow.
12142 (validate_x_resource_name): Simplify count usage.
12143 This also avoids a warning with gcc -Wstrict-overflow.
12144
12145 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12146 fail (Bug#8306).
12147
12148 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12149
12150 * process.c (Fmake_network_process): Use socklen_t, not int,
12151 where POSIX says socklen_t is required in portable programs.
12152 This fixes a porting bug on hosts like 64-bit HP-UX, where
12153 socklen_t is wider than int (Bug#8277).
12154 (Fmake_network_process, server_accept_connection):
12155 (wait_reading_process_output, read_process_output):
12156 Likewise.
12157
12158 * process.c: Rename or move locals to avoid shadowing.
12159 (list_processes_1, Fmake_network_process):
12160 (read_process_output_error_handler, exec_sentinel_error_handler):
12161 Rename or move locals.
12162 (Fmake_network_process): Define label "retry_connect" only if needed.
12163 (Fnetwork_interface_info): Fix pointer signedness.
12164 (process_send_signal): Add cast to avoid pointer signedness problem.
12165 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12166 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12167
12168 Make tparam.h and terminfo.c consistent.
12169 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12170 Include tparam.h instead, since it declares them.
12171 * cm.h (PC): Remove extern decl; tparam.h now does this.
12172 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12173 * terminfo.c: Include tparam.h, to check interfaces.
12174 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12175 (tparam): Adjust signature to match interface in tparam.h;
12176 this removes some undefined behavior. Check that outstring and len
12177 are zero, which they always are with Emacs.
12178 * tparam.h (PC, BC, UP): New extern decls.
12179
12180 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12181 (xftfont_open): Rename locals to avoid shadowing.
12182
12183 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12184 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12185 (OTF_TAG_SYM): Omit macro if not needed.
12186 (ftfont_list): Remove unused local.
12187 (get_adstyle_property, ftfont_pattern_entity):
12188 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12189 Rename locals to avoid shadowing.
12190
12191 * xfont.c (xfont_list_family): Mark var as initialized.
12192
12193 * xml.c (make_dom): Now static.
12194
12195 * composite.c (composition_compute_stop_pos): Rename local to
12196 avoid shadowing.
12197 (composition_reseat_it): Remove unused locals.
12198 (find_automatic_composition, composition_adjust_point): Likewise.
12199 (composition_update_it): Mark var as initialized.
12200 (find_automatic_composition): Mark vars as initialized,
12201 with a FIXME (Bug#8290).
12202
12203 character.h: Rename locals to avoid shadowing.
12204 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12205 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12206 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12207 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12208 to avoid shadowing.
12209
12210 * textprop.c (property_change_between_p): Remove; unused.
12211
12212 * intervals.c (interval_start_pos): Now static.
12213
12214 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12215
12216 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12217 Rename locals to avoid shadowing.
12218
12219 * sound.c (wav_play, au_play, Fplay_sound_internal):
12220 Fix pointer signedness.
12221 (alsa_choose_format): Remove unused local var.
12222 (wav_play): Initialize a variable to 0, to prevent undefined
12223 behavior (Bug#8278).
12224
12225 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12226
12227 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12228
12229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12230 clobbering (Bug#8298).
12231 * sysdep.c (sys_subshell): Likewise.
12232 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12233
12234 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12235 This should get cleaned up, so that child_setup has the
12236 same signature on all platforms.
12237
12238 * callproc.c (call_process_cleanup): Now static.
12239 (relocate_fd): Rename locals to avoid shadowing.
12240
12241 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12242
12243 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12244 not to be necessary, and produces flickering.
12245
12246 2011-03-20 Glenn Morris <rgm@gnu.org>
12247
12248 * config.in: Remove file.
12249
12250 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12251
12252 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12253 are now in src/globals.h.
12254 (syms_of_minibuf): Remove spurious & from previous change.
12255
12256 2011-03-20 Leo Liu <sdl.web@gmail.com>
12257
12258 * minibuf.c (completing-read-function): New variable.
12259 (completing-read-default): Rename from completing-read.
12260 (completing-read): Call completing-read-function.
12261
12262 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12263
12264 * xfaces.c (Fx_load_color_file):
12265 Read color file from absolute filename (bug#8250).
12266
12267 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12268
12269 * makefile.w32-in: Update dependencies.
12270
12271 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12272
12273 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12274
12275 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12276
12277 Fix more problems found by GCC 4.5.2's static checks.
12278
12279 * process.c (make_serial_process_unwind, send_process_trap):
12280 (sigchld_handler): Now static.
12281
12282 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12283 That way, the code declares only the vars that it needs.
12284 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12285 * s/cygwin.h (PTY_ITERATION): Likewise.
12286 * s/darwin.h (PTY_ITERATION): Likewise.
12287 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12288
12289 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12290 * process.c (allocate_pty): Don't declare stb unless it's needed.
12291
12292 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12293 (CONSTANTLIM): Remove; unused.
12294 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12295 Define only if needed.
12296
12297 * unexelf.c (unexec): Name an expression,
12298 to avoid gcc -Wbad-function-cast warning.
12299 Use a different way to cause a compilation error if anyone uses
12300 n rather than nn, a way that does not involve shadowing.
12301 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12302
12303 * deps.mk (unexalpha.o): Remove; unused.
12304
12305 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12306 * unexec.h: New file.
12307 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12308 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12309 Depend on unexec.h.
12310 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12311 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12312 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12313 Change as necessary to match prototype in unexec.h.
12314
12315 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12316 shadowing.
12317 (back_comment, skip_chars): Mark vars as initialized.
12318
12319 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12320 Rename locals to avoid shadowing.
12321
12322 * lread.c (read1): Rewrite so as not to use empty "else".
12323 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12324
12325 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12326
12327 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12328 warning when compiling print.c.
12329
12330 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12331 instead of using an uninitialized var.
12332 (font_sort_entities): Mark var as initialized.
12333
12334 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12335
12336 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12337 pointers to constants.
12338 (font_parse_fcname): Remove unused vars.
12339 (font_delete_unmatched): Now static.
12340 (font_get_spec): Remove; unused.
12341 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12342 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12343 Rename or move locals to avoid shadowing.
12344
12345 * fns.c (require_nesting_list, require_unwind): Now static.
12346 (Ffillarray): Rename locals to avoid shadowing.
12347
12348 * floatfns.c (domain_error2): Define only if needed.
12349 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12350
12351 * alloc.c (mark_backtrace): Move decl from here ...
12352 * lisp.h: ... to here, so that it can be checked.
12353
12354 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12355 (Fdefvar): Rewrite so as not to use empty "else".
12356 (lisp_indirect_variable): Name an expression,
12357 to avoid gcc -Wbad-function-cast warning.
12358 (Fdefvar): Rename locals to avoid shadowing.
12359
12360 * callint.c (quotify_arg, quotify_args): Now static.
12361 (Fcall_interactively): Rename locals to avoid shadowing.
12362 Use const pointer when appropriate.
12363
12364 * lisp.h (get_system_name, get_operating_system_release):
12365 Move decls here, to check interfaces.
12366 * process.c (get_operating_system_release): Move decl to lisp.h.
12367 * xrdb.c (get_system_name): Likewise.
12368 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12369 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12370 some of which prompt warnings from gcc -Wbad-function-cast.
12371 (Fformat_time_string, Fencode_time, Finsert_char):
12372 (Ftranslate_region_internal, Fformat):
12373 Rename or remove local vars to avoid shadowing.
12374 (Ftranslate_region_internal): Mark var as initialized.
12375
12376 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12377 avoid shadowing.
12378
12379 * lisp.h (eassert): Check that the argument compiles, even if
12380 ENABLE_CHECKING is not defined.
12381
12382 * data.c (Findirect_variable): Name an expression, to avoid
12383 gcc -Wbad-function-cast warning.
12384 (default_value, arithcompare, arith_driver, arith_error): Now static.
12385 (store_symval_forwarding): Rename local to avoid shadowing.
12386 (Fmake_variable_buffer_local, Fmake_local_variable):
12387 Mark variables as initialized.
12388 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12389
12390 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12391 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12392 Rename locals to avoid shadowing.
12393 (mark_stack): Move local variables into the #ifdef region where
12394 they're used.
12395 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12396 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12397 needed otherwise.
12398 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12399 (GC_STRING_CHARS): Remove; not used.
12400 (Fmemory_limit): Cast sbrk's returned value to char *.
12401
12402 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12403 avoids undefined behavior in theory.
12404
12405 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12406
12407 Use functions, not macros, for up- and down-casing (Bug#8254).
12408 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12409 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12410 to use the following functions instead of these macros.
12411 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12412 EMACS_INT, since callers assume the returned value fits in int.
12413 (upcase1): Likewise, for UPCASE_TABLE.
12414 (uppercasep, lowercasep, upcase): New static inline functions.
12415 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12416 the race-condition problem in the old DOWNCASE.
12417
12418 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12419 Rename locals to avoid shadowing.
12420 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12421 (regex_compile, re_search_2, re_match_2_internal):
12422 Remove unused local vars.
12423 (FREE_VAR): Rewrite so as not to use empty "else",
12424 which gcc can warn about.
12425 (regex_compile, re_match_2_internal): Mark locals as initialized.
12426 (RETALLOC_IF): Define only if needed.
12427 (WORDCHAR_P): Likewise. This one is never needed, but is used
12428 only in a comment talking about a compiler bug, so put inside
12429 the #if 0 of that comment.
12430 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12431 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12432 Remove; unused.
12433
12434 * search.c (boyer_moore): Rename locals to avoid shadowing.
12435 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12436 (PREV_CHAR_BOUNDARY): Likewise.
12437
12438 * search.c (simple_search): Remove unused var.
12439
12440 * dired.c (compile_pattern): Move decl from here ...
12441 * lisp.h: ... to here, so that it can be checked.
12442 (struct re_registers): New forward decl.
12443
12444 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12445
12446 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12447 All uses changed.
12448 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12449 Rename locals to avoid shadowing.
12450 (Fvertical_motion): Mark locals as initialized.
12451
12452 * casefiddle.c (casify_object, casify_region): Now static.
12453 (casify_region): Mark local as initialized.
12454
12455 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12456
12457 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12458 New macros, so that the caller can use some names other than
12459 gcpro1, gcpro2, etc.
12460 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12461 of the new macros.
12462 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12463 argument, for consistency with GCPRO2_VAR, etc: it is now the
12464 prefix of the variable, not the variable itself. All uses
12465 changed.
12466 * dired.c (directory_files_internal, file_name_completion):
12467 Rename locals to avoid shadowing.
12468
12469 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12470 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12471 dired.c's scmp function, had undefined behavior.
12472 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12473 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12474 * buffer.h: ... to here, because these macros use current_buffer,
12475 and the new implementation with inline functions needs to have
12476 current_buffer in scope now, rather than later when the macros
12477 are used.
12478 (downcase, upcase1): New static inline functions.
12479 (DOWNCASE, UPCASE1): Reimplement using these functions.
12480 This avoids undefined behavior in expressions like
12481 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12482 from race conditions in accessing the global variables
12483 case_temp1 and case_temp2.
12484 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12485 * lisp.h (case_temp1, case_temp2): Remove their decls.
12486 * character.h (ASCII_CHAR_P): Move from here ...
12487 * lisp.h: ... to here, so that the inline functions mentioned
12488 above can use them.
12489
12490 * dired.c (directory_files_internal_unwind): Now static.
12491
12492 * fileio.c (file_name_as_directory, directory_file_name):
12493 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12494 Now static.
12495 (file_name_as_directory): Use const pointers when appropriate.
12496 (Fexpand_file_name): Likewise. In particular, newdir might
12497 point at constant storage, so make it a const pointer.
12498 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12499 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12500 signedness issues.
12501 (Fset_file_times, Finsert_file_contents, auto_save_error):
12502 Rename locals to avoid shadowing.
12503
12504 * minibuf.c (choose_minibuf_frame_1): Now static.
12505 (Ftry_completion, Fall_completions): Rename or remove locals
12506 to avoid shadowing.
12507
12508 * marker.c (bytepos_to_charpos): Remove; unused.
12509
12510 * lisp.h (verify_bytepos, count_markers): New decls,
12511 so that gcc does not warn that these functions aren't declared.
12512
12513 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12514 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12515 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12516 (copy_text): Remove unused local var.
12517
12518 * filelock.c (within_one_second): Now static.
12519 (lock_file_1): Rename local to avoid shadowing.
12520
12521 * buffer.c (fix_overlays_before): Mark locals as initialized.
12522 (fix_start_end_in_overlays): Likewise. This function should be
12523 simplified by using pointers-to-pointers, but that's a different
12524 matter.
12525 (switch_to_buffer_1): Now static.
12526 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12527 (report_overlay_modification): Rename locals to avoid shadowing.
12528
12529 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12530 Fix pointer signedness issue.
12531 (sys_subshell): Mark local as volatile if checking for lint,
12532 to suppress a gcc -Wclobbered warning that does not seem to be right.
12533 (MAXPATHLEN): Define only if needed.
12534
12535 * process.c (serial_open, serial_configure): Move decls from here ...
12536 * systty.h: ... to here, so that they can be checked.
12537
12538 * fns.c (get_random, seed_random): Move extern decls from here ...
12539 * lisp.h: ... to here, so that they can be checked.
12540
12541 * sysdep.c (reset_io): Now static.
12542 (wait_for_termination_signal): Remove; unused.
12543
12544 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12545 (copy_keymap_item, append_key, push_text_char_description):
12546 Now static.
12547 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12548 (DENSE_TABLE_SIZE): Remove; unused.
12549 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12550 (describe_map_tree):
12551 Rename locals to avoid shadowing.
12552
12553 * keyboard.c: Declare functions static if they are not used elsewhere.
12554 (echo_char, echo_dash, cmd_error, top_level_2):
12555 (poll_for_input, handle_async_input): Now static.
12556 (read_char, kbd_buffer_get_event, make_lispy_position):
12557 (make_lispy_event, make_lispy_movement, apply_modifiers):
12558 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12559 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12560 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12561 (read_key_sequence, read_char): Mark locals as initialized.
12562 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12563
12564 * keyboard.h (make_ctrl_char): New decl.
12565 (mark_kboards): Move decl here ...
12566 * alloc.c (mark_kboards): ... from here.
12567
12568 * lisp.h (force_auto_save_soon): New decl.
12569
12570 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12571 (DEFINE_DUMMY_FUNCTION): New macro.
12572 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12573 Use it.
12574 (main): Add casts to avoid warnings
12575 if GCC considers string literals to be constants.
12576
12577 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12578
12579 * dbusbind.c: Pointer signedness fixes.
12580 (xd_signature, xd_append_arg, xd_initialize):
12581 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12582 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12583 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12584 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12585
12586 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12587 if GCC considers string literals to be constants.
12588 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12589
12590 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12591
12592 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12593 (print_preprocess, print_object): New macro to fix last change.
12594
12595 * print.c (print_preprocess): Don't forget font objects.
12596
12597 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12598
12599 * emacs.c (USAGE3): Doc fixes.
12600
12601 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12602
12603 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12604 structure.
12605
12606 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12607
12608 * lisp.h (VWindow_system, Qfile_name_history):
12609 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12610 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12611 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12612
12613 * w32select.c: Don't #include "keyboard.h".
12614 (run_protected): Add extern declaration for waiting_for_input.
12615
12616 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12617 * w32console.c (detect_input_pending, read_input_pending)
12618 (encode_terminal_code):
12619 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12620 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12621 (w32_system_caret_y, Qfile_name_history):
12622 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12623 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12624 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12625 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12626 * w32proc.c (Qlocal, report_file_error):
12627 * w32term.c (Vwindow_system, updating_frame):
12628 * w32uniscribe.c (initialized, uniscribe_font_driver):
12629 Remove unneeded extern declarations.
12630
12631 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12632
12633 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12634
12635 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12636
12637 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12638 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12639 These macros can no longer be used for assignment.
12640
12641 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12642 Assign struct members directly, instead of using BUF_BEGV etc.
12643 (record_buffer_markers, fetch_buffer_markers): New functions for
12644 recording and fetching special buffer markers.
12645 (set_buffer_internal_1, set_buffer_temp): Use them.
12646
12647 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12648
12649 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12650
12651 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12652 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12653
12654 * xdisp.c (hscroll_window_tree):
12655 (reconsider_clip_changes): Use PT instead of BUF_PT.
12656
12657 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12658
12659 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12660 $(EMACS_ROOT)/lib/intprops.h.
12661
12662 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12663
12664 Fix more problems found by GCC 4.5.2's static checks.
12665
12666 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12667 to unsigned char * to avoid compiler diagnostic.
12668 (xg_free_frame_widgets): Make it clear that a local variable is
12669 needed only if USE_GTK_TOOLTIP.
12670 (gdk_window_get_screen): Make it clear that this macro is needed
12671 only if USE_GTK_TOOLTIP.
12672 (int_gtk_range_get_value): New function, which avoids a diagnostic
12673 from gcc -Wbad-function-cast.
12674 (xg_set_toolkit_scroll_bar_thumb): Use it.
12675 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12676 diagnostic from gcc -Wbad-function-cast.
12677 (get_utf8_string, xg_get_file_with_chooser):
12678 Rename locals to avoid shadowing.
12679 (create_dialog): Move locals to avoid shadowing.
12680
12681 * xgselect.c (xg_select): Remove unused var.
12682
12683 * image.c (four_corners_best): Mark locals as initialized.
12684 (gif_load): Initialize transparent_p to zero (Bug#8238).
12685 Mark another local as initialized.
12686 (my_png_error, my_error_exit): Mark with NO_RETURN.
12687
12688 * image.c (clear_image_cache): Now static.
12689 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12690 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12691 (x_edge_detection): Remove unnecessary cast that
12692 gcc -Wbad-function-cast diagnoses.
12693 (gif_load): Fix pointer signedness.
12694 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12695 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12696
12697 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12698
12699 Improve quality of tests for time stamp overflow.
12700 For example, without this patch (encode-time 0 0 0 1 1
12701 1152921504606846976) returns the obviously-bogus value (-948597
12702 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12703 reports time overflow. See
12704 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12705 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12706 * editfns.c: Include limits.h and intprops.h.
12707 (TIME_T_MIN, TIME_T_MAX): New macros.
12708 (time_overflow): Move earlier, to before first use.
12709 (hi_time, lo_time): New functions, for an accurate test for
12710 out-of-range times.
12711 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12712 (Fget_internal_run_time): Don't assume time_t fits in int.
12713 (make_time): Use list2 instead of Fcons twice.
12714 (Fdecode_time): More accurate test for out-of-range times.
12715 (check_tm_member): New function.
12716 (Fencode_time): Use it, to test for out-of-range times.
12717 (lisp_time_argument): Don't rely on undefined left-shift and
12718 right-shift behavior when checking for time stamp overflow.
12719
12720 * editfns.c (time_overflow): New function, refactoring common code.
12721 (Fformat_time_string, Fdecode_time, Fencode_time):
12722 (Fcurrent_time_string): Use it.
12723
12724 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12725 * dired.c (make_time): Move to ...
12726 * editfns.c (make_time): ... here.
12727 * systime.h: Note the move.
12728
12729 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12730
12731 * fringe.c (update_window_fringes): Remove unused variables.
12732
12733 * unexmacosx.c (copy_data_segment): Also copy __got section.
12734 (Bug#8223)
12735
12736 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12737
12738 * termcap.c [MSDOS]: Include "msdos.h".
12739 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12740 Constify `char *' arguments and their references according to
12741 prototypes in tparam.h.
12742
12743 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12744
12745 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12746 Adapt all references accordingly.
12747
12748 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12749
12750 2011-03-11 Tom Tromey <tromey@redhat.com>
12751
12752 * buffer.c (syms_of_buffer): Remove obsolete comment.
12753
12754 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12755
12756 * termhooks.h (encode_terminal_code): Declare prototype.
12757
12758 * msdos.c (encode_terminal_code): Don't declare prototype.
12759
12760 * term.c (encode_terminal_code): Now external again, used by
12761 w32console.c and msdos.c.
12762
12763 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12764 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12765
12766 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12767
12768 Fix some minor problems found by GCC 4.5.2's static checks.
12769
12770 * fringe.c (update_window_fringes): Mark locals as initialized
12771 (Bug#8227).
12772 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12773
12774 * alloc.c (mark_fringe_data): Move decl from here ...
12775 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12776 to check its interface.
12777 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12778
12779 * fontset.c (free_realized_fontset): Now static.
12780 (Fset_fontset_font): Rename local to avoid shadowing.
12781 (fontset_font): Mark local as initialized.
12782 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12783
12784 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12785
12786 * xselect.c (x_disown_buffer_selections): Remove; not used.
12787 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12788 (x_own_selection, Fx_disown_selection_internal): Rename locals
12789 to avoid shadowing.
12790 (x_handle_dnd_message): Remove local to avoid shadowing.
12791
12792 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12793 so that the caller can use some name other than gcpro1.
12794 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12795 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12796 (Fx_backspace_delete_keys_p):
12797 Use them to avoid shadowing, and rename vars to avoid shadowing.
12798 (x_decode_color, x_set_name, x_window): Now static.
12799 (Fx_create_frame): Add braces to silence GCC warning.
12800 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12801 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12802 Remove unused locals.
12803 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12804 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12805 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12806 macros.
12807
12808 * xterm.h (x_mouse_leave): New decl.
12809
12810 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12811 Remove unused functions.
12812 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12813 (x_calc_absolute_position): Now static.
12814 (XTread_socket): Don't define label "out" unless it's used.
12815 Don't declare local "event" unless it's used.
12816 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12817 unless they are used.
12818 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12819 (x_fatal_error_signal): Remove; not used.
12820 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12821 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12822 (x_error_catcher, x_connection_closed, x_error_handler):
12823 (x_error_quitter, xembed_send_message, x_iconify_frame):
12824 (my_log_handler): Rename locals to avoid shadowing.
12825 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12826 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12827
12828 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12829 Rename or move locals to avoid shadowing.
12830 (tty_defined_color, merge_face_heights): Now static.
12831 (free_realized_faces_for_fontset): Remove; not used.
12832 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12833 does not deduce is never used uninitialized.
12834 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12835 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12836
12837 * terminal.c (store_terminal_param): Now static.
12838
12839 * xmenu.c (menu_highlight_callback): Now static.
12840 (set_frame_menubar): Remove unused local.
12841 (xmenu_show): Rename parameter to avoid shadowing.
12842 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12843 since they might point to immutable storage.
12844 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12845 since it's unused otherwise.
12846
12847 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12848 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12849 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12850 avoids a gcc -Wuninitialized diagnostic.
12851 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12852 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12853 does not deduce are never used uninitialized.
12854
12855 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12856
12857 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12858 * window.c (window_loop, size_window):
12859 (run_window_configuration_change_hook, enlarge_window): Likewise.
12860
12861 * window.c (display_buffer): Now static.
12862 (size_window): Mark variables that gcc -Wuninitialized
12863 does not deduce are never used uninitialized.
12864 * window.h (check_all_windows): New decl, to forestall
12865 gcc -Wmissing-prototypes diagnostic.
12866 * dispextern.h (bidi_dump_cached_states): Likewise.
12867
12868 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12869 shadowing.
12870 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12871 Include <limits.h>.
12872 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12873 and to avoid gcc -Wuninitialized warning.
12874 (load_charset_map): Mark variables that gcc -Wuninitialized
12875 does not deduce are never used uninitialized.
12876 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12877
12878 * coding.c (coding_set_source, coding_set_destination):
12879 Use "else { /* comment */ }" rather than "else /* comment */;"
12880 for clarity, and to avoid gcc -Wempty-body warning.
12881 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12882 a block, when the outer 'i' will do.
12883 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12884 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12885 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12886 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12887 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12888 Rename locals to avoid shadowing.
12889 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12890 * coding.c (emacs_mule_char, encode_invocation_designation):
12891 Now static, since they're not used elsewhere.
12892 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12893 (decode_coding_object, encode_coding_object, detect_coding_system):
12894 (decode_coding_emacs_mule): Mark variables that gcc
12895 -Wuninitialized does not deduce are never used uninitialized.
12896 (detect_coding_iso_2022): Initialize a local variable that might
12897 be used uninitialized. Leave a FIXME because it's not clear that
12898 this initialization is needed. (Bug#8211)
12899 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12900 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12901 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12902 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12903 Remove unused macros.
12904
12905 * category.c (hash_get_category_set): Remove unused local var.
12906 (copy_category_table): Now static, since it's not used elsewhere.
12907 * character.c (string_count_byte8): Likewise.
12908
12909 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12910 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12911
12912 * chartab.c (copy_sub_char_table): Now static, since it's not used
12913 elsewhere.
12914 (sub_char_table_ref_and_range, char_table_ref_and_range):
12915 Rename locals to avoid shadowing.
12916 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12917
12918 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12919 (BIDI_BOB): Remove unused macro.
12920
12921 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12922 deduce are never used uninitialized.
12923 * term.c (encode_terminal_code): Likewise.
12924
12925 * term.c (encode_terminal_code): Now static. Remove unused local.
12926
12927 * tparam.h: New file.
12928 * term.c, tparam.h: Include it.
12929 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12930 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12931 Move these decls to tparam.h, and make them agree with what
12932 is actually in tparam.c. The previous trick of using incompatible
12933 decls in different modules does not conform to the C standard.
12934 All callers of tparam changed to use tparam's actual API.
12935 * tparam.c (tparam1, tparam, tgoto):
12936 Use const pointers where appropriate.
12937
12938 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12939 * cm.h (struct cm): Likewise.
12940 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12941 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12942 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12943 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12944 (turn_on_face, init_tty): Likewise.
12945 * termchar.h (struct tty_display_info): Likewise.
12946
12947 * term.c (term_mouse_position): Rename local to avoid shadowing.
12948
12949 * alloc.c (mark_ttys): Move decl from here ...
12950 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12951
12952 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12953
12954 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12955
12956 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12957
12958 * search.c (compile_pattern_1): Remove argument regp, unused since
12959 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12960 (compile_pattern): Don't pass it.
12961
12962 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12963
12964 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12965 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12966 for ! HAVE_GTK3.
12967 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12968
12969 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12970
12971 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12972 gdk_window_get_screen, gdk_window_get_geometry,
12973 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12974 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12975 (xg_get_pixbuf_from_pixmap): New function.
12976 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12977 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12978 Call xg_get_pixbuf_from_pixmap instead of
12979 gdk_pixbuf_get_from_drawable.
12980 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12981 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12982 (xg_check_special_colors): Use GtkStyleContext and its functions
12983 for HAVE_GTK3.
12984 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12985 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12986 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12987 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12988 Call gtk_widget_get_preferred_size.
12989 (xg_frame_resized): gdk_window_get_geometry only takes 5
12990 parameters.
12991 (xg_win_to_widget, xg_event_is_for_menubar):
12992 Call gdk_x11_window_lookup_for_display.
12993 (xg_set_widget_bg): New function.
12994 (delete_cb): New function.
12995 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12996 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12997 (xg_set_background_color): Call xg_set_widget_bg.
12998 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12999 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13000 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13001 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13002 if ! HAVE_GTK3.
13003 (update_frame_tool_bar): Call gtk_widget_hide.
13004 (xg_initialize): Use GDK_KEY_g.
13005
13006 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13007 if ! HAVE_GTK3
13008 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13009
13010 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13011 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13012 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13013
13014 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13015
13016 * w32xfns.c (select_palette): Check success of RealizePalette against
13017 GDI_ERROR, not zero.
13018
13019 See ChangeLog.11 for earlier changes.
13020
13021 ;; Local Variables:
13022 ;; coding: utf-8
13023 ;; End:
13024
13025 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13026
13027 This file is part of GNU Emacs.
13028
13029 GNU Emacs is free software: you can redistribute it and/or modify
13030 it under the terms of the GNU General Public License as published by
13031 the Free Software Foundation, either version 3 of the License, or
13032 (at your option) any later version.
13033
13034 GNU Emacs is distributed in the hope that it will be useful,
13035 but WITHOUT ANY WARRANTY; without even the implied warranty of
13036 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13037 GNU General Public License for more details.
13038
13039 You should have received a copy of the GNU General Public License
13040 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.