1 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3 * alloc.c: Handle unusual debugging option combinations.
4 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5 since the two debugging options are incompatible.
6 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8 (mem_init, mem_insert, mem_insert_fixup):
9 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
10 (NEED_MEM_INSERT): Remove; no longer needed.
12 2012-04-22 Leo Liu <sdl.web@gmail.com>
14 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
16 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
18 * sysdep.c [__FreeBSD__]: Minor cleanups.
19 (list_system_processes, system_process_attributes) [__FreeBSD__]:
20 Use Emacs indenting style more consistently. Avoid some casts.
21 Use 'double' consistently rather than mixing 'float' and 'double'.
23 2012-04-21 Eduard Wiebe <usenet@pusto.de>
25 * sysdep.c (list_system_processes, system_process_attributes): Add
26 implementation for FreeBSD (Bug#5243).
28 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
30 * lisp.mk (lisp): Update.
32 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
34 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
35 It is never used otherwise.
37 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
39 * print.c (print_preprocess): Only check print_depth if print-circle
41 (print_object): Check for cycles even when print-circle is nil and
42 print-gensym is t, but only check print_depth if print-circle is nil.
44 2012-04-20 Chong Yidong <cyd@gnu.org>
46 * process.c (wait_reading_process_output): If EIO occurs on a pty,
47 set the status to "failed" and ensure that sentinel is run.
49 2012-04-20 Glenn Morris <rgm@gnu.org>
51 * process.c (Fset_process_inherit_coding_system_flag)
52 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
53 (Fmake_network_process, Fmake_serial_process): Doc fix.
55 2012-04-20 Eli Zaretskii <eliz@gnu.org>
57 * xdisp.c (string_buffer_position_lim): Limit starting position to
59 (set_cursor_from_row): If called for a mode-line or header-line
60 row, return zero immediately.
61 (try_cursor_movement): If inside continuation line, don't back up
62 farther than the first row after the header line, if any.
63 Don't consider the header-line row as "partially visible", even if
64 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
66 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
68 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
71 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
72 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
74 configure: new option --enable-gcc-warnings (Bug#11207)
75 * Makefile.in (C_WARNINGS_SWITCH): Remove.
76 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
77 (ALL_CFLAGS): Use new macros rather than old.
78 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
79 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
80 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
81 -Wunused-result, -Wunused-variable. This should go away once
82 the Emacs and Gnulib regex code is merged.
83 (xmalloc, xrealloc): Now static.
85 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
87 * dired.c (Fsystem_groups): Remove unused local.
89 2012-04-17 Glenn Morris <rgm@gnu.org>
91 * dired.c (Fsystem_users): Doc fix.
93 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
95 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
96 (syms_of_dired): Add them.
98 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
100 Fix minor alloc.c problems found by static checking.
101 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
102 New extern decls, to avoid calling undeclared functions.
103 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
104 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
105 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
106 (NEED_MEM_INSERT): New macro.
107 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
108 Remove one incorrect comment and fix another.
110 Fix minor ralloc.c problems found by static checking.
111 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
112 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
113 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
114 (r_alloc_sbrk): Now static.
116 Improve ralloc.c interface checking.
117 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
118 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
119 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
120 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
121 [REL_ALLOC]: ... to here, to check interface.
122 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
123 Remove decls. This fixes an "It stinks!".
125 * alloc.c (which_symbols): Fix alignment issue / type clash.
127 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
129 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
130 (struct Lisp_Misc_Any): Likewise.
131 (struct Lisp_Free): Likewise.
132 * alloc.c (union aligned_Lisp_Symbol): Define.
133 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
134 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
135 (union aligned_Lisp_Misc): Define.
136 (MARKER_BLOCK_SIZE, struct marker_block): Use union
137 aligned_Lisp_Misc instead of union Lisp_Misc.
138 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
140 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
142 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
143 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
144 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
145 * s/netbsd.h, s/sol2-6.h:
146 Remove definition of GC_MARK_STACK, since the default now works.
147 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
148 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
149 no longer the default.
150 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
152 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
154 * lread.c (lisp_file_lexically_bound_p):
155 Fix hang at ";-*-\n" (bug#11238).
157 2012-04-14 Eli Zaretskii <eliz@gnu.org>
159 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
160 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
162 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
164 * nsterm.m (constrainFrameRect): Always constrain when there is only
165 one screen (Bug#10962).
167 2012-04-13 Ken Brown <kbrown@cornell.edu>
169 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
171 2012-04-13 Reuben Thomas <rrt@sc3d.org>
173 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
175 2012-04-11 Daniel Colascione <dancol@dancol.org>
177 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
178 against is gone. It's better to use vfork now so that when Cygwin
179 gains a new, working vfork, we use it automatically (bug#10398).
181 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
183 * window.c (save_window_save): Obey window-point-insertion-type.
185 2012-04-11 Glenn Morris <rgm@gnu.org>
187 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
189 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
191 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
193 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
195 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
196 (force_quit_count): New var.
197 (handle_interrupt): Use it.
199 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
201 * w32.c (w32_delayed_load): Record the full path of the library
202 being loaded (bug#10424).
204 2012-04-09 Glenn Morris <rgm@gnu.org>
206 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
207 not just in the obarray, before snarfing them. (Bug#11036)
209 * Makefile.in ($(leimdir)/leim-list.el):
210 Pass EMACS rather than BUILT_EMACS.
212 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
214 * process.c (make_process):
215 * process.h: Add integer `gnutls_handshakes_tried' member to
218 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
219 Add convenience `GNUTLS_LOG2i' macro.
221 * gnutls.c (gnutls_log_function2i): Convenience log function.
222 (emacs_gnutls_read): Use new log functions,
223 `gnutls_handshakes_tried' process member, and
224 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
225 attempts per process (connection).
227 2012-04-09 Chong Yidong <cyd@gnu.org>
229 * eval.c (Fuser_variable_p, user_variable_p_eh)
230 (lisp_indirect_variable): Functions deleted.
231 (Fdefvar): Caller changed.
233 * callint.c (Finteractive, Fcall_interactively):
234 * minibuf.c (Fread_variable): Callers changed.
236 2012-04-09 Eli Zaretskii <eliz@gnu.org>
238 * xdisp.c (set_cursor_from_row): If the display string appears in
239 the buffer at position that is closer to point than the position
240 after the display string, display the cursor on the first glyph of
241 the display string. Fixes cursor display when a 'display' text
242 property immediately follows invisible text. (Bug#11094)
244 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
246 composite.c: use 'double' consistently
247 * composite.c (get_composition_id): Use 'double' consistently
248 instead of converting 'float' to 'double' and vice versa; this is
249 easier to understand and avoids a GCC warning.
251 2012-04-09 Glenn Morris <rgm@gnu.org>
253 * Makefile.in: Generate leim-list with bootstrap-emacs, in
254 preparation for dumping it with emacs. (Bug#4789)
255 (leimdir): New variable.
256 ($(leimdir)/leim-list.el): New rule.
257 (emacs$(EXEEXT)): Depend on leim-list.el.
259 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
260 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
261 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
263 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
265 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
268 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
270 * xml.c (init_libxml2_functions) [WINDOWSNT]:
271 Remove unused local variable.
273 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
275 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
276 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
277 (mark_memory): Mark Lisp_Objects only if pointers might hide in
278 objects, as mark_maybe_pointer will catch them otherwise.
279 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
280 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
282 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
284 Fix typo that broke non-Windows builds.
285 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
287 2012-04-07 Eli Zaretskii <eliz@gnu.org>
289 Support building on MS-Windows with libxml2.
291 * makefile.w32-in (OBJ2): Add xml.$(O).
292 (GLOBAL_SOURCES): Add xml.c.
293 ($(BLD)/xml.$(O)): New dependency list.
295 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
296 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
297 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
298 [!WINDOWSNT]: New macros.
299 (init_libxml2_functions, libxml2_loaded_p): New functions.
300 (parse_region): Call fn_xmlCheckVersion instead of using the macro
301 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
302 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
303 Calls xmlCleanupParser only if libxml2 was loaded (or statically
305 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
306 Call init_libxml2_functions before calling libxml2 functions.
307 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
309 * emacs.c: Don't include libxml/parser.h.
310 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
311 xmlCleanupParser directly.
313 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
315 2012-04-07 Eli Zaretskii <eliz@gnu.org>
317 * indent.c (Fvertical_motion): If there is a display string at
318 point, use it.vpos to compute how many lines to backtrack after
319 move_it_to point. (Bug#11133)
321 2012-04-06 Eli Zaretskii <eliz@gnu.org>
323 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
324 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
325 about subtle differences between FETCH_CHAR* and STRING_CHAR*
326 macros related to unification of CJK characters. For the details,
327 see the discussion following the message here:
328 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
330 2012-04-04 Chong Yidong <cyd@gnu.org>
332 * keyboard.c (Vdelayed_warnings_list): Doc fix.
334 2012-04-01 Eli Zaretskii <eliz@gnu.org>
336 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
337 instead of alloca. (Bug#11138)
339 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
341 * w32menu.c (is_simple_dialog): Properly check lisp types.
344 2012-03-31 Eli Zaretskii <eliz@gnu.org>
346 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
347 position we get to after a call to move_it_to fails the
348 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
349 only if we wind up in a string from display property. (Bug#11063)
351 * window.c (Fdelete_other_windows_internal): Invalidate the row
352 and column information about mouse highlight, so that redisplay
353 restores it after reallocating the glyph matrices. (Bug#7464)
355 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
356 string comes from a `display' text property, use the buffer
357 position of that property as if we actually saw that position in
359 (move_it_by_lines): Remove the assertion that
360 "it->current_x == 0 && it->hpos == 0" which can be legitimately
361 violated when there's a before-string at the beginning of a line.
364 2012-03-30 Eli Zaretskii <eliz@gnu.org>
366 * xdisp.c (append_space_for_newline): If the default face was
367 remapped, use the remapped face for the appended newline.
368 (extend_face_to_end_of_line): Use the remapped default face for
369 extending the face to the end of the line.
370 (display_line): Call extend_face_to_end_of_line when the default
371 face was remapped. (Bug#11068)
373 2012-03-29 Eli Zaretskii <eliz@gnu.org>
375 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
377 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
379 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
381 2012-03-27 Glenn Morris <rgm@gnu.org>
383 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
386 2012-03-26 Kenichi Handa <handa@m17n.org>
388 * dispextern.h (struct glyph): Fix previous change. Change the
389 bit length of glyphless.ch to 25 (Bug#11082).
391 2012-03-26 Chong Yidong <cyd@gnu.org>
393 * keyboard.c (Vselection_inhibit_update_commands): New variable.
394 (command_loop_1): Use it; inhibit selection update for
395 handle-select-window too (Bug#8996).
397 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
399 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
401 2012-03-25 Kenichi Handa <handa@m17n.org>
403 * dispextern.h (struct glyph): Change the bit length of
404 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
406 2012-03-24 Eli Zaretskii <eliz@gnu.org>
408 * s/ms-w32.h (tzname): Include time.h before redirecting to
409 _tzname. Fixes the MSVC build. (Bug#9960)
411 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
413 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
416 * xterm.c (XTread_socket): Only modify handling_signal if
417 !SYNC_INPUT. (Bug#11080)
419 2012-03-23 Eli Zaretskii <eliz@gnu.org>
421 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
422 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
423 when fetching a multibyte character consumes more bytes than
424 CHAR_BYTES returns, due to unification of CJK characters in
425 string_char. (Bug#11073)
427 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
429 * process.c (wait_reading_process_output): Handle pty disconnect
430 by refraining from sending oneself a SIGCHLD (bug#10933).
432 2012-03-22 Chong Yidong <cyd@gnu.org>
434 * dispextern.h (struct it): New member string_from_prefix_prop_p.
436 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
437 Mark string as coming from a prefix property.
438 (handle_face_prop): Use default face for prefix strings (Bug#4281).
439 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
441 2012-03-21 Chong Yidong <cyd@gnu.org>
443 * xfaces.c (Vface_remapping_alist): Doc fix.
445 2012-03-20 Eli Zaretskii <eliz@gnu.org>
447 * w32proc.c (Fw32_set_console_codepage)
448 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
451 2012-03-20 Chong Yidong <cyd@gnu.org>
453 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
454 to reflect default non-nil value of redisplay-dont-pause.
456 2012-03-19 Kenichi Handa <handa@m17n.org>
458 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
459 it fit in a valid range (Bug#11003).
461 2012-03-18 Eli Zaretskii <eliz@gnu.org>
463 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
464 that is not from display property, accept the row as a "cursor
465 row" if one of the string's character has a non-nil `cursor'
466 property. Fixes cursor positioning when there are newlines in
467 overlay strings, e.g. in icomplete.el. (Bug#11035)
469 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
471 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
473 2012-03-12 Chong Yidong <cyd@gnu.org>
475 * eval.c (inhibit_lisp_code): Rename from
476 inhibit_window_configuration_change_hook; move from window.c.
478 * xfns.c (unwind_create_frame_1, Fx_create_frame):
479 * window.c (run_window_configuration_change_hook)
480 (syms_of_window): Callers changed.
482 2012-03-11 Chong Yidong <cyd@gnu.org>
484 * keymap.c (Fkey_description): Doc fix (Bug#9700).
486 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
488 2012-03-10 Chong Yidong <cyd@gnu.org>
490 * frame.c (other_visible_frames): Don't assume the selected frame
491 is visible (Bug#10955).
493 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
495 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
497 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
499 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
500 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
503 2012-03-03 Glenn Morris <rgm@gnu.org>
505 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
507 2012-03-02 Eli Zaretskii <eliz@gnu.org>
509 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
510 position past the first glyph_row that ends at ZV. (Bug#10902)
511 (redisplay_window, next_element_from_string): Fix typos in
513 (redisplay_window): Pass to move_it_vertically the margin in
514 pixels, not in screen lines.
516 2012-03-02 Glenn Morris <rgm@gnu.org>
518 * buffer.c (buffer-list-update-hook): Doc fix.
520 2012-02-29 Eli Zaretskii <eliz@gnu.org>
522 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
523 push_it before setting up the iterator for the first overlay
524 string, even if we have an empty string loaded.
525 (next_overlay_string): If there's an empty string on the iterator
526 stack, pop the stack. (Bug#10903)
528 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
530 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
531 Suggested by Stefan Monnier in
532 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
533 * alloc.c (widen_to_Lisp_Object): New static function.
534 (mark_memory): Also mark Lisp_Objects by fetching pointer words
535 and widening them to Lisp_Objects. This would work even if
536 USE_LSB_TAG is defined and wide integers are used, which might
537 happen in a future version of Emacs.
539 2012-02-25 Chong Yidong <cyd@gnu.org>
541 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
544 * xselect.c (Fx_selection_exists_p): Doc fix.
545 (x_clipboard_manager_save_all): Print an informative message
546 before saving to clipboard manager.
548 2012-02-24 Chong Yidong <cyd@gnu.org>
550 * keyboard.c (process_special_events): Handle all X selection
551 requests in kbd_buffer, not just the next one (Bug#8869).
553 2012-02-23 Chong Yidong <cyd@gnu.org>
555 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
556 call when setting menu-bar-lines and tool-bar-lines parameters.
557 (unwind_create_frame_1): New helper function.
559 * window.c (inhibit_window_configuration_change_hook): New var.
560 (run_window_configuration_change_hook): Obey it.
561 (syms_of_window): Initialize it.
563 2012-02-22 Chong Yidong <cyd@gnu.org>
565 * xterm.c (x_draw_image_relief): Add missing type check for
566 Vtool_bar_button_margin (Bug#10743).
568 2012-02-21 Chong Yidong <cyd@gnu.org>
570 * fileio.c (Vfile_name_handler_alist): Doc fix.
572 * buffer.c (Fget_file_buffer): Protect against invalid file
573 handler return value.
575 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
577 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
578 when computing $valmask.
580 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
581 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
582 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
583 It's useless in that case, and it can cause problems on hosts
584 that allocate halves of EMACS_INT values separately.
585 Reported by Dan Horák. Diagnosed by Andreas Schwab in
586 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
587 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
588 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
589 it avoids undefined behavior on hosts where shifting right by more
590 than the word width has undefined behavior.
592 2012-02-19 Chong Yidong <cyd@gnu.org>
594 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
595 (Funhandled_file_name_directory, Ffile_name_as_directory)
596 (Fdirectory_file_name, Fexpand_file_name)
597 (Fsubstitute_in_file_name): Protect against invalid file handler
598 return values (Bug#10845).
600 2012-02-18 Eli Zaretskii <eliz@gnu.org>
602 * .gdbinit (pitx): Fix incorrect references to fields of the
605 2012-02-17 Chong Yidong <cyd@gnu.org>
607 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
609 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
611 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
612 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
614 2012-02-15 Chong Yidong <cyd@gnu.org>
616 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
617 marked as special. Also, starting docstrings with * is obsolete.
619 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
621 * gnutls.c (emacs_gnutls_write): Fix last change.
623 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
625 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
628 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
630 * keymap.c (Fsingle_key_description): Handle char ranges.
632 2012-02-12 Chong Yidong <cyd@gnu.org>
634 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
635 as that creates a dangerous corner case.
637 * window.c (Fdelete_window_internal): Invalidate the mouse
638 highlight (Bug#9904).
640 2012-02-12 Glenn Morris <rgm@gnu.org>
642 * xselect.c (Fx_own_selection_internal)
643 (Fx_get_selection_internal, Fx_disown_selection_internal)
644 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
645 * nsselect.m (Fx_own_selection_internal)
646 (Fx_disown_selection_internal, Fx_selection_exists_p)
647 (Fx_selection_owner_p, Fx_get_selection_internal):
648 Sync docs and argument specs with the xselect.c versions.
650 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
652 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
654 2012-02-11 Eli Zaretskii <eliz@gnu.org>
656 * w32select.c (Fx_selection_exists_p): Sync doc string and
657 argument list with xselect.c. (Bug#10783)
659 * w16select.c (Fx_selection_exists_p): Sync doc string and
660 argument list with xselect.c. (Bug#10783)
662 2012-02-10 Glenn Morris <rgm@gnu.org>
664 * fns.c (Fsecure_hash): Doc fix.
666 2012-02-09 Kenichi Handa <handa@m17n.org>
668 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
670 2012-02-07 Chong Yidong <cyd@gnu.org>
672 * buffer.c (Fbuffer_local_variables)
673 (buffer_lisp_local_variables): Handle unbound vars correctly;
674 don't let Qunbound leak into Lisp.
676 2012-02-07 Glenn Morris <rgm@gnu.org>
678 * image.c (Fimagemagick_types): Doc fix.
680 * image.c (imagemagick-render-type): Change it from a lisp object
681 to an integer. Move the doc here from the lisp manual.
682 Treat all values not equal to 0 the same.
684 2012-02-06 Chong Yidong <cyd@gnu.org>
686 * doc.c (store_function_docstring): Avoid applying docstring of
687 alias to base function (Bug#2603).
689 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
691 * .gdbinit (pp1, pv1): Remove redundant defines.
694 2012-02-04 Chong Yidong <cyd@gnu.org>
696 * nsterm.m: Declare a global (Bug#10694).
698 2012-02-04 Eli Zaretskii <eliz@gnu.org>
700 * w32.c (get_emacs_configuration_options):
701 Include --enable-checking, if specified, in the return value.
703 2012-02-04 Martin Rudalics <rudalics@gmx.at>
705 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
706 after rounding frame sizes. (Bug#9723)
708 2012-02-04 Eli Zaretskii <eliz@gnu.org>
710 * keyboard.c (adjust_point_for_property): Don't position point
711 before BEGV. (Bug#10696)
713 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
715 Handle overflow when computing char display width (Bug#9496).
716 * character.c (char_width): Return EMACS_INT, not int.
717 (char_width, c_string_width): Check for overflow when
718 computing the width; this is possible now that individual
719 characters can have unbounded width. Problem introduced
720 by merge from Emacs 23 on 2012-01-19.
722 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
724 * dbusbind.c (Fdbus_register_method): Mention the return value
725 :ignore in the docstring.
727 2012-02-02 Glenn Morris <rgm@gnu.org>
729 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
731 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
732 Unconditionally set to t. (Bug#10673)
733 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
734 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
735 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
737 2012-02-02 Kenichi Handa <handa@m17n.org>
739 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
740 0, do not call append_composite_glyph.
742 2012-02-02 Kenichi Handa <handa@m17n.org>
744 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
746 (x_produce_glyphs): If the component of a composition is a null
747 string, set it->pixel_width to 1 to avoid zero-width glyph.
749 2012-02-01 Eli Zaretskii <eliz@gnu.org>
751 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
752 first 2 arguments are identical. This makes inserting large
753 output from a subprocess an order of magnitude faster on
754 MS-Windows, where all sbrk'ed memory is always contiguous.
756 2012-01-31 Glenn Morris <rgm@gnu.org>
758 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
759 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
760 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
762 2012-01-29 Glenn Morris <rgm@gnu.org>
764 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
766 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
768 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
770 2012-01-28 Chong Yidong <cyd@gnu.org>
772 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
774 2012-01-26 Chong Yidong <cyd@gnu.org>
776 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
778 * search.c (Fsearch_forward, Fsearch_backward): Document negative
779 repeat counts (Bug#10507).
781 2012-01-26 Glenn Morris <rgm@gnu.org>
783 * lread.c (syms_of_lread): Doc fix.
785 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
787 * coding.c (encode_designation_at_bol): Change return value to
790 2012-01-25 Chong Yidong <cyd@gnu.org>
792 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
794 2012-01-21 Chong Yidong <cyd@gnu.org>
796 * floatfns.c (Fcopysign): Make the second argument non-optional,
797 since nil is not allowed anyway.
799 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
801 * process.c (read_process_output): Use p instead of XPROCESS (proc).
802 (send_process): Likewise.
804 2012-01-19 Martin Rudalics <rudalics@gmx.at>
806 * window.c (save_window_save, Fcurrent_window_configuration)
807 (Vwindow_persistent_parameters): Do not use Qstate.
810 2012-01-19 Kenichi Handa <handa@m17n.org>
812 * character.c (char_width): New function.
813 (Fchar_width, c_string_width, lisp_string_width):
814 Use char_width (Bug#9496).
816 2012-01-16 Martin Rudalics <rudalics@gmx.at>
818 * window.c (Vwindow_persistent_parameters): New variable.
819 (Fset_window_configuration, save_window_save): Handle persistent
822 2012-01-14 Eli Zaretskii <eliz@gnu.org>
824 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
825 thrashing the stack of the thread. (Bug#9087)
827 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
829 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
831 2012-01-11 Eli Zaretskii <eliz@gnu.org>
833 * xdisp.c (rows_from_pos_range): Handle the case where the
834 highlight ends on a newline. (Bug#10464)
835 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
836 he end column for display of highlight that ends on a newline
839 2012-01-11 Glenn Morris <rgm@gnu.org>
841 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
842 from load-path also when installation-directory is nil. (Bug#10208)
844 2012-01-10 Glenn Morris <rgm@gnu.org>
846 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
848 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
849 Update template values to be closer to their typical values these days.
851 2012-01-09 Eli Zaretskii <eliz@gnu.org>
853 * xdisp.c (rows_from_pos_range): Accept additional argument
854 DISP_STRING, and accept any glyph in a row whose object is that
855 string as eligible for mouse highlight. Fixes mouse highlight of
856 display strings from overlays. (Bug#10464)
858 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
860 emacs: fix an auto-save permissions race condition (Bug#10400)
861 * fileio.c (auto_saving_dir_umask): New static var.
862 (Fmake_directory_internal): Use it.
863 (do_auto_save_make_dir): Set it, instead of invoking chmod after
864 creating the directory. The old code temporarily assigns
865 too-generous permissions to the directory.
866 (do_auto_save_eh): Clear it.
867 (Fdo_auto_save): Catch all errors, not just file errors, so
868 that the var is always cleared.
870 2012-01-07 Eli Zaretskii <eliz@gnu.org>
872 * search.c (scan_buffer): Pass character positions to
873 know_region_cache, not byte positions. (Bug#6540)
875 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
877 * w32.c (sys_rename): Report EXDEV when rename of a directory
878 fails because the target is on another logical disk. (Bug#10284)
880 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
882 * xterm.c (x_embed_request_focus): New function.
884 * xterm.h: Add prototype.
886 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
888 2012-01-05 Glenn Morris <rgm@gnu.org>
890 * emacs.c (emacs_copyright): Update short copyright year to 2012.
892 2012-01-01 Eli Zaretskii <eliz@gnu.org>
894 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
895 Load gnutls_transport_set_lowat only if GnuTLS version is below
897 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
898 GnuTLS versions below 2.11.1.
900 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
902 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
903 to the doc string advising against its use for altering the way
904 windows are scrolled.
906 2011-12-28 Kenichi Handa <handa@m17n.org>
908 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
909 coding-system ASCII compatible only when it does not produce BOM
910 on encoding (Bug#10383).
912 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
914 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
916 (create_and_show_popup_menu): Always use menu_position_func for
919 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
921 * callint.c (Fcall_interactively): Don't truncate prompt string.
923 2011-12-23 Eli Zaretskii <eliz@gnu.org>
925 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
926 property that ends at ZV, so that the bidi iteration could be
927 resumed from there (after widening). (Bug#10360)
929 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
931 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
933 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
935 * nsterm.m (x_free_frame_resources):
936 Release f->output_data.ns->miniimage.
937 (ns_index_color): Fix indentation. Do not retain
938 color_table->colors[i].
940 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
943 * nsfns.m (x_set_background_color): Assign return value from
944 ns_index_color to face-background instead of NSColor*.
945 (ns_implicitly_set_icon_type): Fix indentation.
946 Change assignment in for loop to comparison.
948 * emacs.c (ns_pool): New variable.
949 (main): Assign ns_pool.
950 (Fkill_emacs): Call ns_release_autorelease_pool.
952 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
953 autorelease fdesc, release fdAttrs and tdict.
954 (ns_get_covering_families): Release charset.
955 (ns_findfonts): Release NSFontDescriptor created with new.
956 (ns_uni_to_glyphs): Fix indentation.
957 (setString): Release attrStr before assigning new value.
959 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
961 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
963 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
964 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
966 2011-12-18 David Reitter <reitter@cmu.edu>
968 * nsterm.m (ns_term_init): Subscribe for notifications
969 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
970 to method trackingNotification in EmacsMenu.
972 * nsmenu.m (trackingMenu): New variable.
973 (trackingNotification): New method (from Aquamacs).
974 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
975 from Aquamacs (Bug#7030).
977 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
979 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
980 (symbol_to_nsstring): Fix indentation.
981 (ns_symbol_to_pb): New function.
982 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
983 (Fns_rotate_cut_buffers_internal): Remove.
984 (Fns_store_selection_internal): Rename from
985 Fns_store_cut_buffer_internal.
986 (ns_get_foreign_selection, Fx_own_selection_internal)
987 (Fx_disown_selection_internal, Fx_selection_exists_p)
988 (Fns_get_selection_internal, Fns_store_selection_internal):
989 Use ns_symbol_to_pb and check if return value is nil.
990 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
991 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
992 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
993 renamed to Sns_store_selection_internal.
994 (ns_handle_selection_request): Move code to Fx_own_selection_internal
995 and remove this function.
996 (ns_handle_selection_clear): Remove, never used.
997 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1000 2011-12-17 Ken Brown <kbrown@cornell.edu>
1002 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1003 GID is unknown (Bug#10257).
1005 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1007 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1008 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1009 which caused a build failure on GNU/Linux IA-64. This problem was
1010 introduced by my 2011-10-07 patch.
1012 2011-12-15 Juri Linkov <juri@jurta.org>
1014 * image.c (imagemagick_error): New function. (Bug#10112)
1015 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1016 Use `imagemagick_error' where ImageMagick functions return
1018 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1021 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1023 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1024 fill background (Bug#8992).
1026 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1028 * window.c (Vwindow_combination_resize)
1029 (Vwindow_combination_limit): Use t instead of non-nil in
1031 (Vrecenter_redisplay): Add first sentence of doc-string on
1033 (Frecenter): Fix doc-string typo.
1035 2011-12-11 Kenichi Handa <handa@m17n.org>
1037 * coding.c (Funencodable_char_position): Pay attention to the
1038 buffer text relocation (Bug#9389).
1040 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1042 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1043 gtk_init (Bug#10100).
1045 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1047 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1048 IT->string is nil. (Bug#10263)
1050 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1052 * nsterm.h (x_free_frame_resources): Declare.
1054 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1055 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1057 * nsterm.h (ns_get_defaults_value): Declare.
1059 * nsterm.m (ns_default): Call ns_get_defaults_value.
1061 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1063 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1066 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1068 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1069 that where the value of an _OBJC_* symbol points to is in the .bss
1070 section (Bug#10240).
1072 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1074 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1075 after the loop to call ccl_driver at least once (Bug#8619).
1077 2011-12-08 Kenichi Handa <handa@m17n.org>
1079 * ftfont.c (get_adstyle_property): Fix previous change
1082 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1084 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1085 dirs from the default value of EMACSLOADPATH (bug#10208).
1087 2011-12-07 Glenn Morris <rgm@gnu.org>
1089 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1090 installation and source directories as well. (Bug#10208)
1092 2011-12-06 Chong Yidong <cyd@gnu.org>
1094 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1096 2011-12-06 Glenn Morris <rgm@gnu.org>
1098 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1099 as an error, not just -1. (Bug#10217)
1101 2011-12-05 Chong Yidong <cyd@gnu.org>
1103 * keyboard.c (process_special_events): New function.
1104 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1106 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1108 * coding.c (encode_designation_at_bol): Don't use uninitialized
1109 local variable (Bug#9318).
1111 2011-12-05 Kenichi Handa <handa@m17n.org>
1113 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1114 return Qnil (Bug#8046, Bug#10193).
1116 2011-12-05 Kenichi Handa <handa@m17n.org>
1118 * coding.c (encode_designation_at_bol): New args charbuf_end and
1119 dst. Return the number of produced bytes. Callers changed.
1120 (coding_set_source): Return how many bytes coding->source was
1122 (coding_set_destination): Return how many bytes
1123 coding->destination was relocated.
1124 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1125 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1127 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1129 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1130 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1133 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1135 The following changes are to fix Bug#9318.
1137 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1138 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1139 (encode_coding_iso_2022, encode_coding_sjis)
1140 (encode_coding_big5, encode_coding_charset): Use the above macros.
1142 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1144 * lisp.h (process_quit_flag): Fix external declaration.
1146 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1148 Don't macro-inline non-performance-critical code.
1149 * eval.c (process_quit_flag): New function.
1150 * lisp.h (QUIT): Use it.
1152 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1154 * nsfns.m (get_geometry_from_preferences): New function.
1155 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1157 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1159 * emacs.c (Qkill_emacs): Define.
1160 (syms_of_emacs): Initialize it.
1161 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1162 Qquit_flag to `kill-emacs' instead.
1163 (quit_throw_to_read_char): Add parameter `from_signal'.
1164 All callers changed. Call Fkill_emacs if requested and safe.
1165 * lisp.h (QUIT): Call Fkill_emacs if requested.
1167 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1169 * widget.c (update_wm_hints): Return if wmshell is null.
1170 (widget_update_wm_size_hints): New function.
1172 * widget.h (widget_update_wm_size_hints): Declare.
1174 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1175 widget_update_wm_size_hints (Bug#10104).
1177 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1179 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1180 before a newline, prepare the bidi iterator for consuming the
1181 newline, and keep the current paragraph direction. (Bug#10183)
1182 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1184 2011-12-02 Juri Linkov <juri@jurta.org>
1186 * search.c (Fword_search_regexp): New Lisp function created from
1187 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1188 (Fword_search_backward, Fword_search_forward)
1189 (Fword_search_backward_lax, Fword_search_forward_lax):
1190 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1191 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1193 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1195 * fileio.c (Finsert_file_contents): Move after-change-function call
1196 to before the "handled:" label, since all "goto handled" appear in
1197 cases where the *-change-functions have already been properly called
1200 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1202 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1203 waiting for input. (Bug#10169)
1205 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1207 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1208 verifies glyph row's hash code--we have just reallocated the
1209 glyphs, so their contents can be complete garbage. (Bug#10164)
1211 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1213 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1215 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1217 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1218 attributes are tested _before_ calling verify_row_hash, to protect
1219 against GCC re-ordering of the tests. (Bug#10164)
1221 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1223 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1225 * xterm.c (handle_one_xevent): Only set async_visible and friends
1226 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1227 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1228 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1230 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1232 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1233 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1234 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1235 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1236 All uses changed to use GCPRO1 etc.
1237 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1238 Revert to old implementation (i.e., before 2011-03-11).
1240 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1242 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1243 of scroll runs so as to avoid assigning disabled bogus rows and
1244 unnecessary graphics copy operations.
1246 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1248 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1249 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1250 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1251 (malloc, free, realloc, calloc): Redirect to e_* only when
1254 * lisp.h (GCTYPEBITS): Move before first use.
1255 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1256 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1257 this macro definition.
1259 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1262 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1264 * gtkutil.c (xg_create_frame_widgets):
1265 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1266 present with Gtk+ 2.0.
1268 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1270 * fileio.c (Finsert_file_contents): Undo previous change; see
1271 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1273 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1275 Rename locals to avoid shadowing.
1276 * fileio.c (Finsert_file_contents):
1277 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1278 * process.c (wait_reading_process_output):
1279 Rename inner 'proc' to 'p' to avoid shadowing.
1280 Indent for consistency with usual Emacs style.
1282 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1284 * xdisp.c (redisplay_window): If cursor row is not fully visible
1285 after recentering, and scroll-conservatively is set to a large
1286 number, scroll window by a few more lines to make the cursor fully
1287 visible and out of scroll-margin. (Bug#10105)
1288 (start_display): Don't move to the next line if the display should
1289 start at a newline that is part of a display vector or an overlay
1292 2011-11-24 Juri Linkov <juri@jurta.org>
1294 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1295 after the `MagickPingImage' call. (Bug#10112)
1297 2011-11-23 Chong Yidong <cyd@gnu.org>
1299 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1301 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1303 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1304 making another buffer current. (Bug#10114)
1306 2011-11-23 Glenn Morris <rgm@gnu.org>
1308 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1310 2011-11-23 Chong Yidong <cyd@gnu.org>
1312 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1313 using it (Bug#5984).
1315 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1317 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1318 and header-lines, as they don't have one computed for them.
1321 * .gdbinit (prow): Make displayed values more self-explaining.
1322 Add row's hash code.
1324 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1326 * process.c (wait_reading_process_output): Fix asynchrounous
1327 GnuTLS socket handling on some versions of the GnuTLS library.
1328 (wait_reading_process_output): Add comment and URL.
1330 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1332 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1334 2011-11-21 Chong Yidong <cyd@gnu.org>
1336 * window.c (Fnext_window, Fprevious_window): Doc fix.
1338 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1340 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1342 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1344 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1346 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1348 * window.c (Fset_window_combination_limit): Rename argument
1350 (Vwindow_combination_limit): Remove "status" from doc-string.
1352 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1354 * m/ibms390.h: Remove.
1355 * m/ibms390x.h: Don't include "ibms390.h".
1357 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1359 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1360 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1362 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1364 * casetab.c (Fset_case_table):
1365 * charset.c (Fcharset_after): Fix typos.
1367 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1369 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1370 Otherwise, valgrind does not work on some platforms.
1371 Problem reported by Andreas Schwab in
1372 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1373 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1374 is set, removing the need for VIRT_ADDRESS_VARIES.
1375 (PURE_P): Use a more-efficient implementation that needs just one
1376 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1377 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1378 to 4 (xorl, subq, cmpq, setbe).
1379 * alloc.c (pure): Always extern now, since that's the
1380 VIRT_ADDR_VARIES behavior.
1381 (PURE_POINTER_P): Use a single comparison, not two, for
1382 consistency with the new puresize.h.
1383 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1384 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1385 Remove VIRT_ADDR_VARIES no longer needed.
1387 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1389 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1390 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1391 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1392 behave as if the cursor position were at the window margin.
1394 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1395 and the cursor position is out of bounds, behave as if the cursor
1396 position were at the window margin. (Bug#10075)
1398 2011-11-18 Chong Yidong <cyd@gnu.org>
1400 * window.c (Fwindow_combination_limit): Make first argument
1401 non-optional, since it is meaningless for live windows like the
1404 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1406 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1408 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1410 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1411 (graft_intervals_into_buffer): Simplify.
1413 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1415 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1416 hash values of the two rows.
1417 (copy_row_except_pointers): Preserve the used[] arrays and the
1418 hash values of the two rows. (Bug#10035)
1419 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1421 * xdisp.c (row_hash): New function, body extracted from
1422 compute_line_metrics.
1423 (compute_line_metrics): Call row_hash, instead of computing the
1426 * dispnew.c (verify_row_hash): Call row_hash for computing the
1427 hash code of a row, instead of duplicating code from xdisp.c.
1429 * dispextern.h (row_hash): Add prototype.
1431 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1433 * frame.c (delete_frame): Don't delete the terminal when the last
1434 X frame is closed if emacs is built with GTK toolkit.
1436 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1438 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1440 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1442 * window.c (Vwindow_splits): Rename to
1443 Vwindow_combination_resize. Suggested by Juri Linkov.
1444 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1447 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1449 * nsfns.m (Fns_font_name):
1450 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1452 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1454 * window.h (window): Rename slot "nest" to "combination_limit".
1455 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1456 (Fset_window_nest): Rename to Fset_window_combination_limit.
1457 (Vwindow_nest): Rename to Vwindow_combination_limit.
1458 (recombine_windows, make_parent_window, make_window)
1459 (Fsplit_window_internal, saved_window)
1460 (Fset_window_configuration, save_window_save): Rename all
1461 occurrences of window_nest to window_combination_limit.
1463 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1465 * image.c (imagemagick_load_image): Fix typo.
1467 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1469 * xdisp.c (display_line): Move the call to
1470 highlight_trailing_whitespace before the call to
1471 compute_line_metrics, since the latter needs to see the final
1472 faces of all the glyphs to compute ROW's hash value.
1473 Fixes assertion violations in row_equal_p. (Bug#10035)
1475 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1477 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1478 just return (bug#10044).
1480 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1482 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1483 with user-defined heap size. Bump the default size of the temacs
1484 heap to 27MB, to avoid memory warning when running temacs.
1485 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1487 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1488 current_matrix and desired_matrix. (Bug#9990)
1489 (verify_row_hash) [XASSERTS]: New function.
1490 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1491 that the hash value of glyph rows is correct.
1493 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1495 * window.h (window): Remove splits slot.
1496 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1497 (Fdelete_other_windows_internal, make_parent_window)
1498 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1499 (Fset_window_configuration, save_window_save): Don't deal with
1500 split status of windows.
1501 (saved_window): Remove splits slot.
1502 (Vwindow_splits): Rewrite doc-string.
1504 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1506 * xfns.c (unwind_create_frame):
1507 * nsfns.m (unwind_create_frame):
1508 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1509 Vframe_list (Bug#9999).
1511 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1513 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1515 2011-11-11 Kenichi Handa <handa@m17n.org>
1517 * callproc.c (Fcall_process): Set the member dst_multibyte of
1520 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1522 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1523 avoid a crash (bug#9496).
1525 2011-11-09 Chong Yidong <cyd@gnu.org>
1527 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1528 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1530 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1532 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1534 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1536 Avoid some portability problems by eschewing 'extern inline' functions.
1537 The trivial performance wins aren't worth the portability hassles; see
1538 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1540 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1541 (window_box_width, window_box_left, window_box_left_offset)
1542 (window_box_right, window_box_right_offset): Undo previous change,
1543 by removing the "extern"s.
1544 * intervals.c (adjust_intervals_for_insertion)
1545 (adjust_intervals_for_deletion): Undo previous change,
1546 making these static again.
1547 (offset_intervals, temp_set_point_both, temp_set_point)
1548 (copy_intervals_to_string): No longer inline.
1549 * xdisp.c (window_text_bottom_y, window_box_width)
1550 (window_box_height, window_box_left_offset)
1551 (window_box_right_offset, window_box_left, window_box_right)
1552 (window_box): No longer inline.
1554 2011-11-08 Chong Yidong <cyd@gnu.org>
1556 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1557 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1558 Signal an error if not a live window.
1559 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1560 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1562 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1564 * lisp.h (syms_of_abbrev): Remove declaration.
1565 Reported by CHENG Gao <chenggao@royau.me>.
1567 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1569 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1570 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1571 of temacs in GUI mode.
1573 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1575 * window.h: Declare delete_all_child_windows instead of
1576 delete_all_subwindows.
1577 * window.c (Fwindow_nest, Fset_window_nest)
1578 (Fset_window_new_total, Fset_window_new_normal)
1579 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1580 (delete_all_subwindows): Rename to delete_all_child_windows.
1581 (Fdelete_other_windows_internal, Fset_window_configuration):
1582 Call delete_all_child_windows instead of delete_all_subwindows.
1583 * frame.c (delete_frame): Call delete_all_child_windows instead
1584 of delete_all_subwindows.
1586 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1588 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1589 This is also needed for porting to any host where GC_MARK_STACK is
1590 not GC_MAKE_GCPROS_NOOPS.
1591 (which_symbols): Use it.
1593 2011-11-07 Kenichi Handa <handa@m17n.org>
1595 * coding.c (coding_set_destination): Check coding->src_pos only
1596 when coding->src_object is a buffer (bug#9910).
1598 * process.c (send_process): Set the member src_multibyte of coding
1599 to 0 (bug#9911) when sending a unibyte text.
1601 * callproc.c (Fcall_process): Set the member src_multibyte of
1602 process_coding to 0 (bug#9912).
1604 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1606 * xmenu.c (cleanup_widget_value_tree): New function.
1607 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1608 calling free_menubar_widget_value_tree directly (Bug#9830).
1610 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1612 Fix some portability problems with 'inline'.
1613 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1614 (window_box_width, window_box_left, window_box_left_offset)
1615 (window_box_right, window_box_right_offset): Declare extern.
1616 Otherwise, these inline functions do not conform to C99 and
1617 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1618 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1619 * intervals.c (adjust_intervals_for_insertion)
1620 (adjust_intervals_for_deletion): Now extern, because otherwise the
1621 extern inline functions 'offset_intervals' couldn't refer to it.
1622 (static_offset_intervals): Remove.
1623 (offset_intervals): Rewrite using the old contents of
1624 static_offset_intervals. The old version didn't conform to C99
1625 because an extern inline function contained a reference to an
1626 identifier with static linkage.
1628 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1630 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1633 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1635 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1636 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1637 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1638 return Qleft_to_right.
1640 2011-11-06 Chong Yidong <cyd@gnu.org>
1642 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1643 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1644 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1645 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1646 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1647 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1648 (Fwindow_vscroll): Doc fix.
1649 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1650 argument, since it makes no sense to pass a live window and for
1651 consistency with window-child.
1653 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1655 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1658 2011-11-05 Jason Rumney <jasonr@gnu.org>
1660 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1661 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1663 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1664 bitwise arithmetic preventing use of unicode-sip and non-truetype
1667 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1669 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1672 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1673 initialization code to keep similarity to xfns.c after changes
1676 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1678 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1679 (unwind_create_frame): New function (Bug#9943).
1680 (Fx_create_frame): Restructure code to be more similar to the one in
1681 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1682 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1683 Move terminal->reference_count++ just before making the frame official
1686 * nsterm.m (x_free_frame_resources): New function.
1687 (x_destroy_window): Move code to x_free_frame_resources.
1689 * xfns.c (unwind_create_frame): Fix comment.
1690 (Fx_create_frame, x_create_tip_frame):
1691 Move terminal->reference_count++ just before making the frame
1692 official. Move initialization of image_cache_refcount and
1693 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1695 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1697 Support MSVC build with newer versions of Visual Studio.
1698 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1699 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1702 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1703 which are not supported by MSVC.
1704 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1705 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1707 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1709 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1711 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1713 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1715 Support MSVC build with newer versions of Visual Studio.
1716 * w32.c: Don't include w32api.h for MSVC.
1717 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1719 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1720 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1721 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1722 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1724 (alloca) [_MSC_VER]: Define to _alloca.
1726 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1728 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1730 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1732 * xdisp.c (note_mouse_highlight): If either of
1733 previous/next-single-property-change returns nil, treat that as
1734 the beginning or the end of the buffer. (Bug#9955)
1736 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1738 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1739 label is not null (Bug#9951).
1740 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1743 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1745 * window.c (Fwindow_body_size): Mention in the doc string that the
1746 return value is in frame's canonical units. (Bug#9949)
1748 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1750 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1752 * w32fns.c (unwind_create_frame): If needed, free the glyph
1753 matrices of the partially constructed frame. (Bug#9943)
1754 * xfns.c (unwind_create_frame): Likewise.
1756 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1758 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1759 Don't stop backward scan on the continuation glyph, even though
1760 its CHARPOS is positive.
1761 (mouse_face_from_buffer_pos, note_mouse_highlight):
1762 Rename cover_string to disp_string.
1764 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1766 * window.c (temp_output_buffer_show): Don't use
1767 Vtemp_buffer_show_specifiers.
1768 (Vtemp_buffer_show_specifiers): Remove unused variable.
1770 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1772 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1773 past the beginning of the current glyph matrix.
1775 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1777 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1778 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1779 HAVE_GTK3 (Bug#9869).
1781 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1782 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1784 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1786 * xterm.c: Declare x_handle_net_wm_state to return int.
1787 (handle_one_xevent): Check if we are iconified but don't have
1788 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1789 (get_current_wm_state): Return non-zero if not hidden,
1790 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1791 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1792 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1793 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1795 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1797 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1798 so that this new function doesn't get optimized away by a
1799 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1801 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1803 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1805 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1807 Fix the `xbytecode' command.
1808 * .gdbinit (xprintbytestr): New command.
1809 (xwhichsymbols): Rename from `which'; all callers changed.
1810 (xbytecode): Print the byte-code string as well.
1812 2011-10-29 Kim Storm <storm@cua.dk>
1814 * alloc.c (which_symbols): New function.
1816 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1818 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1821 2011-10-29 Glenn Morris <rgm@gnu.org>
1823 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1824 Not clear what it was for, and it causes various bugs. (Bug#9839)
1826 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1828 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1829 possible random value that matches one of those tested as
1830 condition to clear the mouse face.
1832 2011-10-28 Chong Yidong <cyd@gnu.org>
1834 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1836 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1838 * window.c (make_window): Initialize phys_cursor_on_p.
1840 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1842 * lisp.h (struct Lisp_Symbol): Update comments.
1844 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1846 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1848 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1850 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1851 <oslsachem@gmail.com> for helping to debug this.
1853 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1854 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1855 (g_b_init_get_glyph_outline_w): New static variables.
1856 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1857 (GetGlyphOutlineW_Proc): New typedefs.
1858 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1859 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1861 (w32font_open_internal, compute_metrics):
1862 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1863 instead of calling the "wide" APIs directly.
1865 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1867 * w32.h (syms_of_w32font): Add prototype.
1869 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1871 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1872 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1873 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1874 (Fmove_to_window_line): Doc fix.
1876 2011-10-27 Chong Yidong <cyd@gnu.org>
1878 * process.c (make_process): Set gnutls_state to NULL.
1880 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1881 non-NULL, regardless of GNUTLS_INITSTAGE.
1882 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1883 an error. Set process slots as soon as we allocate them.
1885 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1887 2011-10-27 Chong Yidong <cyd@gnu.org>
1889 * gnutls.c (emacs_gnutls_deinit): New function.
1890 Deallocate credentials structures as well as calling gnutls_deinit.
1891 (Fgnutls_deinit, Fgnutls_boot): Use it.
1893 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1894 (deactivate_process): Call emacs_gnutls_deinit.
1896 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1898 * image.c (x_create_x_image_and_pixmap):
1899 * w32.c (sys_rename, w32_delayed_load):
1900 * w32font.c (fill_in_logfont):
1901 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1903 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1905 * w32fns.c (w32_default_color_map): New function,
1906 extracted from Fw32_default_color_map.
1907 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1909 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1911 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1913 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1915 * keyboard.c (test_undefined): New function (bug#9751).
1916 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1918 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1920 * sysdep.c (init_sys_modes): Fix the check for the controlling
1921 terminal (Bug#6649).
1923 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1925 * dispextern.h (struct bidi_it): New member next_en_type.
1927 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1928 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1929 current character, check also for next_en_type being WEAK_EN.
1930 (bidi_resolve_weak): Don't enter the expensive loop if the current
1931 position is before next_en_pos. Record the bidi type of the first
1932 non-ET, non-BN character we find, in addition to its position.
1933 (bidi_level_of_next_char): Invalidate next_en_type when
1934 next_en_pos is over-stepped.
1936 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1938 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1939 * editfns.c: Rewrite current-time-zone so that it invokes
1940 the equivalent of (format-time-string "%Z") to get the time zone name.
1941 This fixes a bug when the time zone name contains characters that
1942 need converting from the system time locale to Emacs internal format.
1943 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1944 that patch fixed format-time-string to do the conversion, but
1945 I forgot to fix current-time-zone.
1946 (format_time_string): New function, containing most of
1947 what Fformat_time_string used to contain.
1948 (Fformat_time_string): Rewrite in terms of format_time_string.
1949 This doesn't change this function's behavior.
1950 (current-time-zone): Rewrite to use format_time_string.
1951 This fixes the bug reported by Michael Schierl in
1952 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1953 Jason Rumney's 2007-06-07 change worked around this bug, but
1955 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1957 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1959 * xdisp.c (start_display): If the character at POS is displayed
1960 via a display vector, reset IT->current.dpvec_index to zero.
1961 (try_window_reusing_current_matrix): If a line ends in a display
1962 vector or the next line starts in a display vector, continue
1963 redrawing the window even though the character position of
1964 start_row was reached.
1967 2011-10-18 Chong Yidong <cyd@gnu.org>
1969 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1970 with nobreak-char-display too.
1972 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1974 Fix part 3 of bug#9771.
1975 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1976 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1977 non-neutral characters if the current character is a paragraph
1978 separator (a.k.a. Newline). This avoids running the same
1979 expensive loop twice, once when we consume the preceding newline
1980 and the other time when the line actually needs to be displayed.
1981 Avoid the loop when we see neutrals on the base embedding level
1982 following a character whose directionality is the same as the
1983 paragraph's. This avoids running the expensive loop when a line
1984 ends in a long sequence of neutrals, like control characters.
1985 Add assertion against STRONG_AL type. Slightly rearrange code
1986 that determines the type of a neutral given the first non-neutral
1988 (bidi_level_of_next_char): Set next_en_pos to zero when
1989 invalidating its info.
1991 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1993 * xdisp.c (push_display_prop): Determine whether to record string
1994 or buffer position by IT->string, not by IT->method. Allow
1995 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1996 (move_it_vertically_backward): Don't look for character position
1997 immediately after the newline when in a continuation line.
2000 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2002 * window.c (coordinates_in_window): Rewrite and delabelize
2003 vertical border check. (Bug#5357) (Bug#9618)
2005 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2007 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2008 errors in XSetWindowBorder (bug#9310).
2010 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2012 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2013 avoid crash when xmalloc overrun checking is enabled.
2015 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2017 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2018 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2019 cursor motion with <left> and <right> arrow keys.
2021 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2022 some callers set that themselves.
2024 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2026 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2027 display string and the previous row comes from the same string and
2028 is empty. (Bug#9739) (Bug#9738)
2030 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2032 * doc.c (get_doc_string): Encode file name (bug#9735).
2034 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2036 * bidi.c (bidi_level_of_next_char):
2037 * xdisp.c (get_visually_first_element): Remove old incorrect
2038 comments regarding the Unicode Line Separator character.
2040 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2042 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2044 * alloc.c (Fgc_status): Do not access beyond zombies array
2045 boundary if nzombies > MAX_ZOMBIES.
2046 * alloc.c (dump_zombies): Add missing format specifier.
2048 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2050 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2051 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2053 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2054 Some packages use them to denote characters with modifiers.
2056 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2058 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2059 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2060 matching a pp-number. Rename parameter var to var1.
2062 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2064 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2066 2011-10-08 Glenn Morris <rgm@gnu.org>
2068 * callint.c (Fcall_interactively): Give a more explicit error for the
2069 'c' case with a non-character input. (Bug#8479)
2071 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2073 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2075 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2076 lines that are hscrolled on the left.
2078 * dispnew.c (buffer_posn_from_coords): Account for a possible
2079 presence of header-line. (Bug#4426)
2081 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2083 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2084 Don't advertise functionality which we discourage or doesn't work.
2086 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2088 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2089 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2090 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2091 this makes Emacs dump core during garbage collection on rare
2092 occasions. sizeof is obviously inferior to offsetof here, so
2093 stick with offsetof.
2094 (GC_POINTER_ALIGNMENT): New macro.
2095 (mark_memory): Omit 3rd (offset) arg; caller changed.
2096 Don't assume EMACS_INT alignment is the same as pointer alignment.
2098 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2100 * keyboard.c (read_key_sequence_remapped): New var.
2101 (read_key_sequence): Compute remapping in the right buffer.
2102 (command_loop_1): Use read_key_sequence's remapping directly.
2104 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2106 * dired.c (file_name_completion): Don't expand file name.
2107 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2108 before checking file name handler.
2110 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2111 they've been requested explicitly (bug#9591).
2113 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2115 * keymap.c (Fsingle_key_description): Use make_specified_string
2116 instead of build_string to build string from push_key_description.
2119 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2121 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2122 This fixes a Y2038 bug on 64-bit hosts.
2123 * buffer.c (reset_buffer):
2124 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2125 (Fclear_buffer_auto_save_failure):
2126 Use 0, not -1, to represent an unset failure time, since time_t
2127 might not be signed.
2129 Remove dependency on glibc malloc internals.
2130 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2131 Move back here from lisp.h, but with their new implementations.
2132 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2133 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2134 * charset.c (charset_table_init): New static var.
2135 (syms_of_charset): Use it instead of xmalloc. This removes a
2136 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2137 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2138 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2139 Move back to alloc.c.
2140 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2141 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2143 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2145 * nsterm.m (windowDidResize): Call x_set_window_size only when
2146 ns_in_resize is true. Otherwise set pixelwidth/height and
2147 call change_frame_size (Bug#9628).
2149 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2151 Port --enable-checking=all to Fedora 14 x86-64.
2152 * charset.c (syms_of_charset): Also account for glibc malloc's
2153 internal overhead when calculating the initial malloc maximum.
2155 Port --enable-checking=all to Fedora 14 x86.
2156 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2158 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2159 (overrun_check_realloc, overrun_check_free):
2160 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2161 That way, xmalloc returns a properly-aligned pointer even if
2162 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2163 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2164 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2165 into account when calculating the initial malloc maximum.
2166 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2167 Move here from alloc.c, so that charset.c can use it too.
2168 Properly align; the old code wasn't right for common 32-bit hosts
2169 when configured with --enable-checking=all.
2170 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2171 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2173 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2175 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2178 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2180 * xdisp.c (compute_display_string_end): If there's no display
2181 string at CHARPOS, return -1.
2183 * bidi.c (bidi_fetch_char): When compute_display_string_end
2184 returns a negative value, treat the character as a normal
2185 character not covered by a display string. (Bug#9624)
2187 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2189 * lread.c (Fread_from_string): Fix typo in docstring.
2191 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2193 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2194 newline, reseat the iterator instead of bidi-iterating there one
2195 character at a time. (Bug#9610)
2196 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2197 TO_CHARPOS if the bidi iterator is at base embedding level.
2199 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2201 * lread.c (readevalloop): Use correct code for NBSP.
2202 (read1): Likewise. (Bug#9608)
2204 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2206 * dbusbind.c (Fdbus_register_signal): When service is not
2207 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2209 2011-09-25 Glenn Morris <rgm@gnu.org>
2211 * buffer.c (truncate-lines): Doc fix.
2213 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2215 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2216 (Fset_window_next_buffers): Doc fix.
2218 2011-09-24 Glenn Morris <rgm@gnu.org>
2220 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2222 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2224 Fix minor problems found by static checking.
2225 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2226 * indent.c (Fvertical_motion): Fix == vs = typo.
2228 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2230 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2231 Default value is now t. Doc fix.
2233 * indent.c (Fvertical_motion): Compute and apply the overshoot
2234 logic when moving up, not only when moving down. Fix the
2235 confusing name and values of the it_overshoot_expected variable;
2236 logic changes accordingly. (Bug#9254) (Bug#9549)
2238 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2239 CHARPOS is covered by a display string which includes newlines.
2240 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2241 is covered by a display string with embedded newlines.
2243 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2245 * dbusbind.c (Fdbus_register_signal): Add match rule to
2246 Vdbus_registered_objects_table. (Bug#9581)
2247 (Fdbus_register_method, Vdbus_registered_objects_table):
2250 2011-09-24 Jim Meyering <meyering@redhat.com>
2252 do not ignore write error for any output size
2253 The previous change was incomplete.
2254 While it makes emacs --batch detect the vast majority of stdout
2255 write failures, errors were still ignored whenever the output size is
2256 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2257 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2258 && echo FAIL: ignored write error
2259 FAIL: ignored write error
2260 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2261 && echo FAIL: ignored write error
2262 FAIL: ignored write error
2263 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2265 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2267 * emacs.c (Fkill_emacs): In noninteractive mode exit
2268 non-successfully if a write error occurred on stdout. (Bug#9574)
2270 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2272 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2275 * dispextern.h (struct it): Update the comment documenting what
2278 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2280 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2281 a display string, extend search for cursor position to end of row.
2282 (find_row_edges): If the row ends in a newline from a display
2283 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2284 Handle the case of a display string with multiple newlines.
2285 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2286 non-empty line. Fixes confusing cursor motion with arrow keys at
2287 the beginning of a line that starts with whitespace.
2289 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2291 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2294 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2296 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2299 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2301 * xdisp.c (display_line): Record maximum and minimum buffer
2302 positions even if no glyphs were produced (e.g., by a zero-width
2303 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2304 buffer positions that will be removed from the glyph row because
2306 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2307 column is beyond frame width: don't subtract 1 "pixel" when
2308 computing width of the stretch.
2309 (reseat_at_next_visible_line_start): Undo the change made on
2310 2011-09-17 that saved paragraph information and restored it after
2311 the call to `reseat'. (Bug#9545)
2313 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2315 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2316 and turn window cursor on if cleared (Bug#9415).
2318 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2320 * search.c (boyer_moore): Take unibyte characters from pattern
2321 literally. (Bug#9458)
2323 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2325 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2327 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2329 Fix minor problem found by static checking.
2330 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2331 initialized, to pacify gcc -Wuninitialized.
2333 * fileio.c: Report proper errno when syscall falls.
2334 (Finsert_file_contents): Save and restore errno,
2335 so that report_file_error outputs the correct diagnostic.
2336 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2338 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2340 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2342 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2344 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2345 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2347 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2349 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2350 about the current paragraph and restore it after the call to reseat.
2352 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2353 (bidi_find_paragraph_start): Search back for paragraph beginning
2354 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2355 (bidi_move_to_visually_next): Only trigger paragraph-related
2356 computations when the last character is a newline or at EOB, not
2357 just any NEUTRAL_B. (Bug#9470)
2359 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2360 truncated lines if point is covered by a display string. (Bug#9524)
2362 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2364 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2365 (cons_to_x_long): New function.
2366 (lisp_data_to_selection_data): Use it. Correct the test for
2367 short-versus-long data; it was negated. Break out of vector
2368 loop, for efficiency, when a long datum is discovered.
2370 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2372 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2374 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2376 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2377 GCC PR/17406) by declaring this function with external scope.
2379 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2381 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2382 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2384 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2386 * editfns.c (Fformat): Correctly handle text properties on "%%".
2388 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2390 * xterm.c (x_draw_composite_glyph_string_foreground):
2391 * w32term.c (x_draw_composite_glyph_string_foreground):
2392 * term.c (encode_terminal_code):
2393 * composite.c (composition_update_it, get_composition_id):
2394 * xdisp.c (get_next_display_element)
2395 (fill_composite_glyph_string): Add comments about special meaning
2396 of TAB characters in a composition.
2398 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2400 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2401 This occurs when processing a multibyte format.
2402 Problem reported by Wolfgang Jenker.
2404 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2406 * xdisp.c (try_cursor_movement): Only check for exact match if
2407 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2409 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2411 Remove unused external symbols.
2412 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2413 * xdisp.c (calc_pixel_width_or_height): Now static.
2414 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2415 * indent.c (check_display_width):
2416 * w32term.c: Fix comment to match code.
2417 * xterm.c, xterm.h (x_catching_errors): Remove.
2419 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2421 * xselect.c: Use signed conversions more consistently (Bug#9498).
2422 (selection_data_to_lisp_data): Assume incoming selection data are
2423 signed integers, not unsigned. This is to be consistent with
2424 outgoing selection data, which was modified to use signed integers
2425 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2426 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2427 expects long, not unsigned long.
2429 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2431 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2432 computation of loop end. Reported by Johan Bockgård
2435 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2437 * frame.c (Fother_visible_frames_p): Function deleted.
2439 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2441 * indent.c (compute_motion): Process display vector front to back
2442 rather than the other way around. (Bug#2496)
2444 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2446 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2448 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2450 * minibuf.c (Fread_from_minibuffer): Doc fix.
2452 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2454 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2455 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2457 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2459 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2460 value for non-existent files.
2462 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2464 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2465 set its "size" to -1. This will set the modtime_size field of
2466 the corresponding buffer to -1, which is what
2467 verify-visited-file-modtime expects for files that do not exist.
2470 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2472 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2474 * lisp.h: ... from here. push_key_description is no longer
2475 defined in keyboard.c, so its declaration should not be in
2476 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2477 logically belongs with push_key_description.
2479 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2481 * buffer.h: Include <sys/types.h> instead of <time.h>.
2482 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2483 Problem reported by Herbert J. Skuhra.
2485 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2487 * xml.c (parse_region): Make the parsing work for
2488 non-comment-starting XML files again (bug#9144).
2490 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2492 * image.c (gif_load): Fix calculation of bottom and right corner.
2495 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2497 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2498 redisplay in small windows.
2500 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2502 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2504 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2506 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2507 Operate on live windows only.
2509 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2511 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2513 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2515 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2516 only under bidi iteration.
2518 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2520 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2522 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2524 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2525 Without this fix, the command to link temacs failed due to an
2526 undefined symbol __builtin_isnan. This is because
2527 /usr/include/iso/math_c99.h #defines isnan(x) to
2528 __builtin_isnan(x), but the bundled gcc, which identifies itself
2529 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2531 * floatfns.c (isnan): #undef, and then #define to a clone of
2533 (Fisnan): Always define, since it's always available now.
2534 (syms_of_floatfns): Always define isnan at the Lisp level.
2536 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2538 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2540 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2542 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2543 The previous code assumed that file offsets (off_t values) fit in
2544 EMACS_INT variables, which is not true on typical 32-bit hosts.
2545 The code messed up by falsely reporting buffer overflow in cases
2546 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2547 when "big" contains more than 2**29 bytes, even though this
2548 inserts just one byte and does not overflow the buffer.
2549 (Finsert_file_contents): Store file offsets as off_t
2550 values, not as EMACS_INT values. Check for overflow when
2551 converting between EMACS_INT and off_t. When checking for
2552 buffer overflow or for overlap, take the offsets into account.
2553 Don't use EMACS_INT for small values where int suffices.
2554 When checking for overlap, fix a typo: ZV was used where
2555 ZV_BYTE was intended.
2556 (Fwrite_region): Don't assume off_t fits into 'long'.
2557 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2559 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2561 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2563 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2565 sprintf-related integer and memory overflow issues (Bug#9412).
2567 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2568 (esprintf, exprintf, evxprintf): New functions.
2569 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2570 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2571 (modify_event_symbol): Do not assume that the length of
2572 name_alist_or_stem is safe to alloca and fits in int.
2573 (Fexecute_extended_command): Likewise for function name and binding.
2574 (Frecursion_depth): Wrap around reliably on integer overflow.
2575 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2576 since some callers pass EMACS_INT values.
2577 (Fsingle_key_description): Don't crash if symbol name contains more
2578 than MAX_ALLOCA bytes.
2579 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2580 (get_minibuffer): Arg is now EMACS_INT, not int.
2581 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2582 (esprintf, exprintf, evxprintf): New decls.
2583 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2585 * dbusbind.c (signature_cat): New function.
2586 (xd_signature, Fdbus_register_signal):
2587 Do not overrun buffer; instead, report string overflow.
2589 * dispnew.c (add_window_display_history): Don't overrun buffer.
2590 Truncate instead; this is OK since it's just a log.
2592 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2593 even if the time zone offset is outlandishly large.
2594 Don't mishandle offset == INT_MIN.
2596 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2597 when creating daemon; the previous buffer-overflow check was incorrect.
2599 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2600 which has the guts of the old verror function.
2602 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2603 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2605 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2606 (font_unparse_xlfd): Don't blindly alloca long strings.
2607 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2608 fits in int, when using sprintf. Use single snprintf to count
2609 length of string rather than counting it via multiple sprintfs;
2610 that's simpler and more reliable.
2611 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2612 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2613 sprintf, in case result does not fit in int.
2615 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2616 (fontset_from_font): Print it.
2618 * frame.c (tty_frame_count): Now printmax_t, not int.
2619 (make_terminal_frame, set_term_frame_name): Print it.
2620 (x_report_frame_params): In X, window IDs are unsigned long,
2621 not signed long, so print them as unsigned.
2622 (validate_x_resource_name): Check for implausibly long names,
2623 and don't assume name length fits in 'int'.
2624 (x_get_resource_string): Don't blindly alloca invocation name;
2625 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2628 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2629 (xg_check_special_colors, xg_set_geometry):
2630 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2632 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2633 Use esprintf, not sprintf, in case result does not fit in int.
2635 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2636 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2637 it as a large positive number.
2638 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2639 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2641 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2642 in case result does not fit in int.
2644 * print.c (float_to_string): Detect width overflow more reliably.
2645 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2646 buffer overrun. Don't assume list length fits in 'int'. Treat
2647 print length of 0 as 0, not as infinity; to be consistent with other
2648 uses of print length in this function. Don't overflow print length
2649 index. Don't assume hash table size fits in 'long', or that
2650 vectorlike size fits in 'unsigned long'.
2652 * process.c (make_process): Use printmax_t, not int, to format
2653 process-name gensyms.
2655 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2657 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2658 to avoid potential buffer overrun.
2660 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2661 if X resource line is longer than 512 bytes.
2663 * xfns.c (x_window): Make sprintf buffer a bit bigger
2664 to avoid potential buffer overrun.
2666 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2668 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2670 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2672 Integer overflow fixes for scrolling, etc.
2673 Without these, Emacs silently mishandles large integers sometimes.
2674 For example, "C-u 4294967297 M-x recenter" was treated as if
2675 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2677 * xdisp.c (try_window_id): Check Emacs fixnum range before
2678 converting to 'int'.
2680 * window.c (window_scroll_line_based, Frecenter):
2681 Check that an Emacs fixnum is in range before assigning it to 'int'.
2682 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2683 values converted from Emacs fixnums.
2684 (Frecenter): Don't wrap around a line count if it is out of 'int'
2685 range; instead, treat it as an extreme value.
2686 (Fset_window_configuration, compare_window_configurations):
2687 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2689 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2690 that can exceed INT_MAX. Check that EMACS_INT value is in range
2691 before assigning it to the (possibly-narrower) index.
2692 (match_limit): Don't assume that a fixnum can fit in 'int'.
2694 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2697 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2698 (Fvertical_motion): Don't wrap around LINES values that don't fit
2699 in 'int'. Instead, treat them as extreme values. This is good
2700 enough for windows, which can't have more than INT_MAX lines anyway.
2702 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2704 * Require libxml/parser.h to avoid compilation warning.
2706 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2708 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2709 since this reportedly can destroy thread storage.
2711 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2713 * syntax.c (find_defun_start): Update all cache variables if
2714 exiting early (Bug#9401).
2716 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2718 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2720 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2721 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2722 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2724 * term.c (tty_append_glyph): New function.
2725 (produce_stretch_glyph): Static function and its prototype deleted.
2727 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2730 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2732 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2733 when checking :margin (Bug#9390).
2734 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2735 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2736 so that the name doesn't mislead. All uses changed.
2738 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2740 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2743 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2745 * xdisp.c (move_it_to): Don't bail out early when reaching
2746 position beyond to_charpos, if we are scanning backwards.
2747 (move_it_vertically_backward): When DY == 0, make sure we get to
2748 the first character in the line after the newline.
2750 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2752 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2753 (ccl_driver): Do not generate an out-of-range pointer.
2754 (Fccl_execute_on_string): Remove unnecessary check for
2755 integer overflow, noted by Stefan Monnier in
2756 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2757 Remove a FIXME that didn't need fixing.
2758 Simplify the newly-introduced buffer reallocation code.
2760 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2762 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2764 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2766 Integer and memory overflow issues (Bug#9196).
2768 * doc.c (get_doc_string): Rework so that
2769 get_doc_string_buffer_size is the actual buffer size, rather than
2770 being 1 less than the actual buffer size; this makes xpalloc more
2773 * image.c (x_allocate_bitmap_record, cache_image):
2774 * xselect.c (Fx_register_dnd_atom):
2775 Simplify previous changes by using xpalloc.
2777 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2778 since either will do and ptrdiff_t is convenient with xpalloc.
2780 * charset.c (charset_table_size)
2781 (struct charset_sort_data.priority): Now ptrdiff_t.
2782 (charset_compare): Don't overflow if priorities differ greatly.
2783 (Fsort_charsets): Don't assume list length fits in int.
2784 Check for size-calculation overflow when allocating sort data.
2785 (syms_of_charset): Allocate an initial charset table that is
2786 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2788 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2790 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2791 The actual value is always <= INT_MAX, and leaving it unsigned made
2792 overflow checking harder.
2794 * dispextern.h (struct glyph_matrix.rows_allocated)
2795 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2796 with xpalloc. The values are still always <= INT_MAX.
2798 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2800 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2801 (SAFE_NALLOCA): New macro.
2803 * region-cache.c (struct boundary.pos, find_cache_boundary)
2804 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2805 (set_cache_region, invalidate_region_cache)
2806 (revalidate_region_cache, know_region_cache, region_cache_forward)
2807 (region_cache_backward, pp_cache):
2808 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2809 so that ptrdiff_t * can be passed to xpalloc.
2810 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2811 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2812 (pp_cache): Don't assume cache_len fits in int.
2813 * region-cache.h: Adjust extern decls to match.
2815 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2816 EMACS_INT, since either will do, for xpalloc.
2818 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2819 (xnmalloc, xnrealloc, xpalloc): New functions.
2821 * bidi.c (bidi_shelve_header_size): New constant.
2822 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2823 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2825 * bidi.c (bidi_cache_shrink):
2826 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2828 Don't update size of array until after memory allocation succeeds,
2829 because xmalloc/xrealloc may not return.
2830 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2831 now that we have proper integer overflow checking.
2832 (record_overlay_string, overlay_strings): Catch overflows when
2833 calculating size of overlay_str_buf.
2835 * callproc.c (Fcall_process): Check for size overflow when
2836 calculating size of args2.
2837 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2838 Normally we prefer signed values, but sticking with ptrdiff_t would
2839 require adding more-complicated checks.
2841 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2842 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2843 Redo buffer-overflow calculations to avoid integer overflow.
2844 Add a FIXME comment where memory seems to be over-allocated.
2846 * character.c (Fstring): Check for size-calculation overflow.
2848 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2849 unnecessary integer overflow. Check for size overflow.
2850 (encode_coding_object): Don't update size until xmalloc succeeds.
2852 * composite.c (get_composition_id): Check for overflow in glyph
2853 length calculations.
2855 Integer and memory overflow fixes for display code.
2856 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2857 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2858 (scrolling_window): Check for overflow in size calculations.
2859 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2860 Don't assume glyph table len fits in int.
2861 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2862 (row_table_size): Now ptrdiff_t, not int.
2863 (scrolling_window): Avoid overflow in size calculations.
2864 Don't update size until allocation succeeds.
2865 * fns.c (concat): Check for overflow in size calculations.
2866 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2867 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2868 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2870 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2871 (get_doc_string): Check for size calculation overflow.
2872 Don't update size until allocation succeeds.
2873 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2874 EMACS_INT, where ptrdiff_t will do.
2875 (Fsubstitute_command_keys): Check for string overflow.
2877 * editfns.c (set_time_zone_rule): Don't assume environment length
2879 (message_length): Now ptrdiff_t, not int.
2880 (Fmessage_box): Don't update size until allocation succeeds.
2881 Don't assume message length fits in int.
2882 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2884 * emacs.c (main): Do not reallocate argv, since there is a null at
2885 the end that can be overwritten, and this way there's no need to
2886 worry about size-calculation overflow.
2887 (sort_args): Check for size-calculation overflow.
2889 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2891 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2893 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2894 (x_set_scroll_bar_width, x_figure_window_size):
2895 Check for integer overflow.
2896 (x_set_alpha): Do not assume XINT fits in int.
2898 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2899 This is for the members text_lines, text_cols, total_lines, total_cols,
2900 where the system imposes an 'int' limit.
2902 * fringe.c (Fdefine_fringe_bitmap):
2903 Don't update size until alloc works.
2905 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2906 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2908 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2909 Check for size-calculation overflow.
2910 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2911 do, as we prefer signed integers.
2912 (id_to_widget.max_size, id_to_widget.used)
2913 (xg_store_widget_in_map, xg_remove_widget_from_map)
2914 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2915 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2916 Use and return ptrdiff_t, not int.
2917 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2918 * gtkutil.h: Change prototypes to match the above.
2920 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2921 are duplicate now that they've been promoted to lisp.h.
2922 (x_allocate_bitmap_record, x_alloc_image_color)
2923 (make_image_cache, cache_image, xpm_load):
2924 Don't update size until alloc is done.
2925 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2927 Check for size calculation overflow.
2928 (ct_colors_allocated_max): New constant.
2929 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2932 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2933 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2934 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2935 Use ptrdiff_t, not int, to count maps.
2936 (read_char_minibuf_menu_prompt): Check for overflow in size
2937 calculations. Don't update size until allocation succeeds.
2938 Redo calculations to avoid overflow.
2939 * keyboard.h: Change prototypes to match the above.
2941 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2943 (current_minor_maps): Check for size calculation overflow.
2944 * keymap.h: Change prototypes to match the above.
2946 * lread.c (read1, init_obarray): Don't update size until alloc done.
2948 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2949 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2951 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2952 Now ptrdiff_t, not int.
2953 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2954 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2956 * process.c (Fnetwork_interface_list): Check for overflow
2957 in size calculation.
2959 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2961 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2962 overflow. Don't bother calling xmalloc when xrealloc will do.
2964 * search.c (Freplace_match): Check for size calculation overflow.
2965 (Fset_match_data): Don't assume list lengths fit in 'int'.
2967 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2968 for command line length. Do not attempt to address one before the
2969 beginning of an array, as that's not portable.
2971 * term.c (max_frame_lines): Remove; unused.
2972 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2974 (encode_terminal_code, calculate_costs): Check for size
2975 calculation overflow.
2976 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2977 table lengths and related sizes. Don't update size until alloc
2978 done. Redo calculations to avoid overflow.
2979 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2981 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2982 subtracting pointers.
2983 (gobble_line): Check for overflow more carefully. Don't update size
2986 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2987 Don't update size until alloc done.
2988 Redo size calculations to avoid overflow.
2989 Check for size calculation overflow.
2990 (main) [DEBUG]: Fix typo in invoking tparam1.
2992 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2993 Use ptrdiff_t, not int, for sizes.
2994 (store_mode_line_noprop_char): Don't update size until alloc done.
2996 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2997 Use ptrdiff_t, not int, for sizes.
2998 (Finternal_make_lisp_face, cache_face):
2999 Check for size calculation overflow.
3000 (cache_face): Treat size calculation overflows as if they were
3001 memory exhaustion (the usual treatment), rather than aborting.
3003 * xfns.c (x_encode_text, x_set_name_internal)
3004 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3005 sizes, since they can exceed INT_MAX in size. Check for size
3006 calculation overflow.
3008 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3009 (xg_select): Check for size calculation overflow.
3010 Don't update size until alloc done.
3012 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3013 as sprintf is limited to int lengths.
3015 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3016 (X_LONG_MIN): New macros.
3017 Use them to make the following changes clearer.
3018 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3019 This change doesn't affect the value now, but it may help remind
3020 future maintainers not to raise the value too much later.
3021 (SELECTION_QUANTUM): Remove, replacing with ...
3022 (selection_quantum): ... new function, which avoids overflow.
3024 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3025 assumption that selection length fits in 'int'.
3026 (x_reply_selection_request, x_handle_selection_request)
3027 (x_get_window_property, receive_incremental_selection)
3028 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3029 (lisp_data_to_selection_data, clean_local_selection_data):
3030 Use ptrdiff_t, not int, to record length of selection.
3031 (x_reply_selection_request, x_get_window_property)
3032 (receive_incremental_selection, x_property_data_to_lisp):
3033 Redo calculations to avoid overflow.
3034 (x_reply_selection_request): When sending hint, ceiling it at
3035 X_LONG_MAX rather than relying on wraparound overflow to send
3037 (x_get_window_property, receive_incremental_selection)
3038 (lisp_data_to_selection_data, x_property_data_to_lisp):
3039 Check for size-calculation overflow.
3040 (x_get_window_property, receive_incremental_selection)
3041 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3042 Don't store size until memory allocation succeeds.
3043 (x_get_window_property): Plug memory leak on memory exhaustion.
3044 Don't double-block input; malloc is safe here. Don't assume 2**34
3045 - 4 fits in unsigned long. Add an xassert to check
3046 XGetWindowProperty overflow. Be more careful about overflow
3047 calculations, and distinguish size from memory overflow better.
3048 (receive_incremental_selection): When tracing, don't assume
3049 unsigned int is less than INT_MAX.
3050 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3051 harmful) conversions of unsigned short to int.
3052 (lisp_data_to_selection_data): Don't assume that integers
3053 in the range -65535 through -1 fit in an X unsigned short.
3054 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3055 result parameters unless successful. Rely on cons_to_unsigned
3056 to report problems with elements; the old code wasn't right anyway.
3057 (x_check_property_data): Check for int overflow; we cannot use
3058 a wider type due to X limits.
3059 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3061 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3063 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3064 (x_term_init): Check for size calculation overflow.
3065 (x_color_cells): Don't store size until memory allocation succeeds.
3066 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3067 Don't assume alloca size is less than MAX_ALLOCA.
3068 (x_term_init): Don't assume length fits in int (sprintf is limited
3071 Use ptrdiff_t for composition IDs.
3072 * character.c (lisp_string_width):
3073 * composite.c (composition_table_size, n_compositions)
3074 (get_composition_id, composition_gstring_from_id):
3075 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3076 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3077 * window.c (Frecenter):
3078 Use ptrdiff_t, not int, for composition IDs.
3079 * composite.c (get_composition_id): Check for integer overflow.
3080 * composite.h: Adjust prototypes to match the above changes.
3082 Use ptrdiff_t for hash table indexes.
3083 * category.c (hash_get_category_set):
3084 * ccl.c (ccl_driver):
3085 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3086 * coding.c (coding_system_charset_list, detect_coding_system):
3087 * coding.h (struct coding_system.id):
3088 * composite.c (get_composition_id, gstring_lookup_cache):
3089 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3090 * image.c (xpm_get_color_table_h):
3091 * lisp.h (hash_lookup, hash_put):
3092 * minibuf.c (Ftest_completion):
3093 Use ptrdiff_t for hash table indexes, not int (which is too
3094 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3095 32-bit --with-wide-int hosts).
3097 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3098 Add a FIXME comment about memory leaks.
3099 (syms_of_charset): Don't assume xmalloc returns.
3101 Don't assume that stated character widths fit in int.
3102 * character.c (Fchar_width, c_string_width, lisp_string_width):
3103 * character.h (CHAR_WIDTH):
3104 * indent.c (MULTIBYTE_BYTES_WIDTH):
3105 Use sanitize_char_width to avoid undefined and/or bad behavior
3106 with outlandish widths.
3107 * character.h (sanitize_tab_width): Rename from sanitize_width,
3108 now that we have two such functions. All uses changed.
3109 (sanitize_char_width): New inline function.
3111 Don't assume that tab-width fits in int.
3112 * character.h (sanitize_width): New inline function.
3113 (SANE_TAB_WIDTH): New macro.
3114 (ASCII_CHAR_WIDTH): Use it.
3115 * indent.c (sane_tab_width): Remove. All uses replaced by
3116 SANE_TAB_WIDTH (current_buffer).
3117 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3119 * fileio.c: Integer overflow issues with file modes.
3120 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3122 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3123 Remove unreachable code.
3124 (read_hex, load_charset_map_from_file): Check for integer overflow.
3126 * xterm.c: Don't go over XClientMessageEvent limit.
3127 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3128 (x_send_scroll_bar_event): Likewise. Check that the size does not
3129 exceed limits imposed by XClientMessageEvent, as well as the usual
3130 ptrdiff_t and size_t limits.
3132 * keyboard.c: Overflow, signedness and related fixes.
3133 (make_lispy_movement): Use same integer type in forward decl
3134 that is used in the definition.
3135 (read_key_sequence, keyremap_step):
3136 Change bufsize argument back to int, undoing my 2011-03-30 change.
3137 We prefer signed types, and int is wide enough here.
3138 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3139 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3140 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3141 length, not size_t. Use ptrdiff_t for index, not int.
3142 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3143 possibility of integer overflow.
3145 Overflow, signedness and related fixes for images.
3147 * dispextern.h (struct it.stack[0].u.image.image_id)
3148 (struct_it.image_id, struct image.id, struct image_cache.size)
3149 (struct image_cache.used, struct image_cache.ref_count):
3150 * gtkutil.c (update_frame_tool_bar):
3151 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3152 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3153 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3154 * nsmenu.m (update_frame_tool_bar):
3155 * xdisp.c (calc_pixel_width_or_height):
3156 * xfns.c (image_cache_refcount):
3157 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3158 on typical 64-bit hosts.
3160 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3161 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3162 Omit unnecessary casts to int.
3163 (parse_image_spec): Check that integers fall into 'int' range
3164 when the callers expect that.
3165 (image_ascent): Redo ascent calculation to avoid int overflow.
3166 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3167 (lookup_image): Remove unnecessary tests.
3168 (xbm_image_p): Locals are now of int, not EMACS_INT,
3169 since parse_image_check makes sure they fit into int.
3170 (png_load, gif_load, svg_load_image):
3171 Prefer int to unsigned where either will do.
3172 (tiff_handler): New function, combining the cores of the
3173 old tiff_error_handler and tiff_warning_handler.
3174 This function is rewritten to use vsnprintf and thereby avoid
3175 stack buffer overflows. It uses only the features of vsnprintf
3176 that are common to both POSIX and native Microsoft.
3177 (tiff_error_handler, tiff_warning_handler): Use it.
3178 (tiff_load, gif_load, imagemagick_load_image):
3179 Don't assume :index value fits in 'int'.
3180 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3181 (imagemagick_load_image): Check that crop parameters fit into
3182 the integer types that MagickCropImage accepts. Don't assume
3183 Vimagemagick_render_type has a nonnegative value. Don't assume
3184 size_t fits in 'long'.
3185 (gs_load): Use printmax_t to print the widest integers possible.
3186 Check for integer overflow when computing image height and width.
3188 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3190 * xdisp.c (redisplay_window): Don't force window start if point
3191 will be invisible in the resulting window. (Bug#9324)
3193 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3195 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3196 the display spec is of the form `(space ...)'.
3197 (handle_display_spec): Return the value returned by
3198 handle_single_display_spec, not just 1 or zero.
3199 (handle_single_display_spec): If the display spec is of the form
3200 `(space ...)', and specifies display in the text area, return 2
3202 (try_cursor_movement): Check for the need to scroll more
3203 accurately, and prefer exact match for point under bidi.
3204 Don't advance `row' beyond the last row of the window.
3206 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3207 into disp_prop; all users changed.
3209 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3210 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3211 for the text covered by the display property.
3213 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3215 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3216 Change return value to nil.
3217 (Frecord_buffer): Delete unused function.
3219 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3221 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3222 buffers, return left-to-right.
3223 (set_cursor_from_row): Consider candidate row a win if its glyph
3224 represents a newline and point is on that newline. Fixes cursor
3225 positioning on the newline at EOL of R2L text within L2R
3226 paragraph, and vice versa.
3227 (try_cursor_movement): Check continued rows, in addition to
3228 continuation rows. Fixes unwarranted scroll when point enters a
3229 continued line of R2L text within an L2R paragraph, or vice versa.
3230 (cursor_row_p): Consider the case of point being equal to
3231 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3232 from the end of a short line to the beginning of a continued line
3233 of R2L text within L2R paragraph.
3234 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3235 composed characters.
3237 * bidi.c (bidi_check_type): Use xassert.
3238 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3241 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3243 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3246 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3248 * nsfont.m (ns_otf_to_script): Fix typo.
3250 2011-08-22 Kenichi Handa <handa@m17n.org>
3252 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3253 extra slot even if the purpose is char-code-property-table.
3255 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3257 * xdisp.c (redisplay_window): When computing centering_position,
3258 account for the height of the header line. (Bug#8874)
3260 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3261 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3262 candidate is selected by the mouse, and that candidate has a
3263 composed character under the mouse.
3265 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3266 coordinates reported by pos-visible-in-window-p for a composed
3267 character in column zero.
3269 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3271 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3273 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3275 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3276 consider it a hit if to_charpos is anywhere in the range of the
3277 composed buffer positions.
3279 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3281 * image.c (gif_load): Don't assume that each subimage has the same
3282 dimensions as the base image. Handle disposal method that is
3283 "undefined" by the gif spec (Bug#9335).
3285 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3287 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3288 (Fcondition_case): Document `debug' symbol in error handler.
3290 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3292 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3293 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3294 from an Org mode buffer to a Speedbar frame.
3296 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3297 a composition, take its buffer position from IT->cmp_it.charpos.
3298 Fixes cursor positioning at the beginning of a line that begins
3299 with a composed character.
3301 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3303 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3304 character bidirectional type, use STRONG_L instead. Fixes crashes
3305 in a buffer produced by `describe-categories'.
3307 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3308 members before the level stack, so they would be saved and
3309 restored when copying iterator state. Fixes incorrect reordering
3310 around TABs covered by display properties.
3312 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3314 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3316 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3318 * eval.c (internal_condition_case, internal_condition_case_1)
3319 (internal_condition_case_2, internal_condition_case_n):
3320 Remove unnecessary aborts (Bug#9081).
3322 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3324 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3325 has no `load' handler, try opening the file locally. (Bug#9311)
3327 2011-08-16 Ken Brown <kbrown@cornell.edu>
3329 * gmalloc.c: Expand comment.
3331 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3333 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3334 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3336 2011-08-16 Ken Brown <kbrown@cornell.edu>
3338 Fix memory allocation problems in Cygwin build (Bug#9273).
3340 * unexcw.c ( __malloc_initialized): Declare external variable.
3341 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3343 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3345 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3347 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3349 [CYGWIN] (special_realloc): New function.
3350 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3351 requests to realloc storage in the static heap.
3353 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3355 * bidi.c (bidi_initialize): Remove unused local.
3357 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3360 * biditype.h: Remove file.
3361 * makefile.w32-in ($(BLD)/bidi.$(O)):
3362 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3364 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3366 * chartab.c: Improve commentary for the uniprop_table API.
3368 * bidi.c (bidi_paragraph_init): Support zero value of
3369 bidi_ignore_explicit_marks_for_paragraph_level.
3370 (bidi_initialize): Use uniprop_table instead of including
3371 biditype.h and bidimirror.h.
3373 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3374 coordinates of the iterator when restoring from ppos_it.
3377 2011-08-14 Kenichi Handa <handa@m17n.org>
3379 * process.c (create_process): Call setup_process_coding_systems
3380 after the pid of the process is set to -1 (Bug#8162).
3382 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3384 * xdisp.c (move_it_in_display_line_to): Don't invoke
3385 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3386 ppos_it. Fixes vertical cursor motion when line beginning is
3387 covered by an image. (Bug#9296)
3389 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3391 * nsterm.h (ns_run_ascript): Declare.
3392 (NSAPP_DATA2_RUNASSCRIPT): Define.
3394 * nsfns.m (as_script, as_result, as_status): New static variables.
3395 (ns_run_ascript): New function.
3396 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3397 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3398 the event loop. Get status from as_status (Bug#7276).
3400 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3401 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3402 the event loop (Bug#7276).
3404 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3406 * gnutls.c (QCgnutls_bootprop_priority)
3407 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3408 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3409 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3410 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3411 (QCgnutls_bootprop_verify_hostname_error)
3412 (QCgnutls_bootprop_callbacks_verify): Rename from
3413 Qgnutls_bootprop_..., all uses changed.
3415 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3418 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3420 * xfaces.c (Qframe_set_background_mode): Now static.
3421 * dispextern.h (Qframe_set_background_mode): Remove decl.
3423 * process.c (Fnetwork_interface_info): Declare local only if needed.
3425 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3427 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3428 (Fnetwork_interface_list): Allocate in increments of bytes instead
3429 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3430 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3432 (struct ifflag_def): notrailers is smart on OSX.
3433 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3434 Get hardware address with getifaddrs if available.
3436 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3438 * xdisp.c (iterate_out_of_display_property): xassert that
3439 IT->position is set to within IT->object's boundaries. Break from
3440 the loop as soon as EOB is reached; avoids infloops in redisplay
3441 when IT->position is set up wrongly due to some bug.
3442 Set IT->current to match the bidi iterator unconditionally.
3443 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3444 entry. Force push_it to save on the stack the current
3445 buffer/string position, to be restored by pop_it. Fix flags in
3446 the iterator structure wrt the object coming from a display
3447 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3448 properties. (Bug#9284)
3450 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3452 * fontset.c (fontset_get_font_group): Add proper type checks.
3455 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3457 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3458 and LC_VERSION_MIN_MACOSX.
3459 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3460 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3462 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3464 * xdisp.c (forward_to_next_line_start): Allow to use the
3465 no-display-properties-and-no-overlays under bidi display.
3466 Set disp_pos in the bidi iterator to avoid searches for display
3467 properties and overlays.
3469 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3471 * editfns.c (Fset_time_zone_rule): Document relationship with the
3474 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3475 the font entity extracted from the cache (Bug#8109).
3477 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3479 * composite.c (autocmp_chars): Don't reset point. That is done by
3480 restore_point_unwind (Bug#5984).
3482 2011-08-07 Juri Linkov <juri@jurta.org>
3484 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3485 to show the arg `TIME' instead of `TIMEVAL'.
3487 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3489 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3490 display property strides EOL and includes a newline, as in
3491 longlines-mode. (Bug#9254)
3492 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3493 word-wrap under bidirectional display. (Bug#9224)
3495 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3496 is non-zero, even if the data buffer is NULL. Fixes a crash in
3497 vertical-motion with longlines-mode. (Bug#9254)
3499 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3501 * bidi.c <bidi_cache_total_alloc>: Now static.
3502 (bidi_initialize): Initialize bidi_cache_total_alloc.
3504 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3507 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3508 amount allocated this far in `bidi_cache_total_alloc'.
3509 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3510 non-zero, only free the data buffer without restoring the cache
3511 contents. All callers changed.
3513 * dispextern.h (bidi_unshelve_cache): Update prototype.
3515 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3516 (move_it_in_display_line, move_it_to)
3517 (move_it_vertically_backward, move_it_by_lines): Replace the call
3518 to xfree to an equivalent call to bidi_unshelve_cache.
3519 (move_it_in_display_line_to): Fix logic of returning
3520 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3522 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3524 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3525 came from a string character with a `cursor' property. (Bug#9229)
3527 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3529 * Makefile.in (LIB_PTHREAD): New variable.
3530 (LIBES): Add LIB_PTHREAD (Bug#9216).
3532 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3533 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3535 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3537 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3539 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3541 * xterm.c (x_find_topmost_parent): New function.
3542 (x_set_frame_alpha): Find topmost parent window with
3543 x_find_topmost_parent and set the property there also (bug#9181).
3544 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3546 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3548 * callproc.c (Fcall_process): Avoid vfork clobbering
3549 the local vars buffer, coding_systems, current_dir.
3551 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3553 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3555 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3557 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3558 so that it is not optimized away.
3560 * xdisp.c (compute_display_string_pos): Remove unused local.
3562 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3564 Fix slow cursor motion and scrolling in large buffers with
3565 selective display, like Org Mode buffers. (Bug#9218)
3567 * dispextern.h (struct bidi_it): New member disp_prop_p.
3569 * xdisp.c: Remove one-slot cache of display string positions.
3570 (compute_display_string_pos): Accept an additional argument
3571 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3572 for a display string or property. If found, set DISP_PROP_P
3575 * bidi.c (bidi_fetch_char): Accept an additional argument
3576 DISP_PROP_P, and pass it to compute_display_string_pos.
3577 Only handle text covered by a display string if DISP_PROP_P is returned
3578 non-zero. All callers of bidi_fetch_char changed.
3580 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3582 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3584 2010-12-03 Don March <don@ohspite.net>
3586 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3587 last character M-[char] is translated to ESC [char] (bug#7541).
3589 2011-08-02 Kenichi Handa <handa@m17n.org>
3591 * lisp.h (uniprop_table): Extern it.
3593 * chartab.c (uniprop_table): Make it non-static.
3595 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3597 * xdisp.c (forward_to_next_line_start): Accept additional argument
3598 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3600 (reseat_at_next_visible_line_start): Use the bidi iterator state
3601 returned by forward_to_next_line_start to restore the state of
3602 it->bidi_it after backing up to previous newline. (Bug#9212)
3604 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3606 * regex.c (re_comp): Protoize.
3607 (re_exec): Fix return type.
3608 (regexec): Fix type of `ret'. (Bug#9203)
3610 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3612 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3613 This is needed if max-image-size is a floating-point number.
3615 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3617 * print.c (print_object): Print empty symbol as ##.
3619 * lread.c (read1): Read ## as empty symbol.
3621 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3623 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3624 setting frame foreground color (Bug#9175).
3625 (x_set_background_color): Likewise.
3627 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3628 contents (Bug#9176).
3629 (EmacsTooltip -init): Remove bezels and add shadows to
3632 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3633 or scroll bar (Bug#8470).
3635 * nsfont.m (nsfont_open): Remove assignment to voffset and
3636 unnecessary vars hshink, expand, hd, full_height, min_height.
3637 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3639 * nsterm.h (nsfont_info): Remove voffset field.
3641 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3643 Implement strike-through and overline on NextStep (Bug#8863).
3645 * nsfont.m (nsfont_open): Use underline position provided by font,
3646 instead of hard-coded value of 2.
3647 (nsfont_draw): Call ns_draw_text_decoration instead.
3649 * nsterm.h: Add declaration for ns_draw_text_decoration.
3651 * nsterm.m (ns_draw_text_decoration): New function for drawing
3652 underline, overline, and strike-through.
3653 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3654 ns_draw_text_decoration. Change treatment of cursor drawing to
3655 accommodate underlining, etc.
3657 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3659 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3662 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3664 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3665 Without this fix, if a signal arrives just after memory fills up,
3666 'malloc' might be invoked reentrantly.
3668 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3669 In other words, assume that every image size is allowed, on non-X
3670 hosts. This assumption is probably wrong, but it lets Emacs compile.
3672 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3674 * regex.c (re_iswctype): Convert return values to boolean.
3676 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3678 * xdisp.c (compute_display_string_pos): Don't use cached display
3679 string position if the buffer had its restriction changed.
3682 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3684 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3686 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3688 Integer signedness and overflow and related fixes. (Bug#9079)
3690 * bidi.c: Integer size and overflow fixes.
3691 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3692 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3693 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3694 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3695 (bidi_find_other_level_edge):
3696 Use ptrdiff_t instead of EMACS_INT where either will do.
3697 This works better on 32-bit hosts configured --with-wide-int.
3698 (bidi_cache_ensure_space): Check for size-calculation overflow.
3699 Use % rather than repeated addition, for better worst-case speed.
3700 Don't set bidi_cache_size until after xrealloc returns, because it
3702 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3703 (bidi_cache_ensure_space): Also check that the bidi cache size
3704 does not exceed that of the largest Lisp string or buffer. See Eli
3705 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3707 * alloc.c (__malloc_size_t): Remove.
3708 All uses replaced by size_t. See Andreas Schwab's note
3709 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3711 * image.c: Improve checking for integer overflow.
3712 (check_image_size): Assume that f is nonnull, since
3713 it is always nonnull in practice. This is one less thing to
3714 worry about when checking for integer overflow later.
3715 (x_check_image_size): New function, which checks for integer
3716 overflow issues inside X.
3717 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3718 This removes the need for a memory_full check.
3719 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3720 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3721 (xbm_read_bitmap_data): Change locals back to 'int', since
3722 their values must fit in 'int'.
3723 (xpm_load_image, png_load, tiff_load):
3724 Invoke x_create_x_image_and_pixmap earlier,
3725 to avoid much needless work if the image is too large.
3726 (tiff_load): Treat overly large images as if
3727 x_create_x_image_and_pixmap failed, not as malloc failures.
3728 (gs_load): Use x_check_image_size.
3730 * gtkutil.c: Omit integer casts.
3731 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3732 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3734 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3736 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3737 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3738 would wrongly return t on a 64-bit host.
3740 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3741 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3742 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3743 and therefore cause GCC to emit a bogus diagnostic in some cases.
3745 * image.c: Integer signedness and overflow and related fixes.
3746 This is not an exhaustive set of fixes, but it's time to
3747 record what I've got.
3748 (lookup_pixel_color, check_image_size): Remove redundant decls.
3749 (check_image_size): Don't assume that arbitrary EMACS_INT values
3750 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3751 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3752 (tiff_load, imagemagick_load_image):
3753 Check for overflow in size calculations.
3754 (x_create_x_image_and_pixmap): Remove unnecessary test for
3755 xmalloc returning NULL; that can't happen.
3756 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3757 (xpm_color_bucket): Use better integer hashing function.
3758 (xpm_cache_color): Don't possibly over-allocate memory.
3759 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3760 (gif_memory_source):
3761 Use ptrdiff_t, not int or size_t, to record sizes.
3762 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3763 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3764 either works, as we prefer signed integers.
3765 (tiff_read_from_memory, tiff_write_from_memory):
3766 Return tsize_t, not size_t, since that's what the TIFF API wants.
3767 (tiff_read_from_memory): Don't fail simply because the read would
3768 go past EOF; instead, return a short read.
3769 (tiff_load): Omit no-longer-needed casts.
3770 (Fimagemagick_types): Don't assume size fits into 'int'.
3772 Improve hashing quality when configured --with-wide-int.
3773 * fns.c (hash_string): New function, taken from sxhash_string.
3774 Do not discard information about ASCII character case; this
3775 discarding is no longer needed.
3776 (sxhash-string): Use it. Change sig to match it. Caller changed.
3777 * lisp.h: Declare it.
3778 * lread.c (hash_string): Remove, since we now use fns.c's version.
3779 The fns.c version returns a wider integer if --with-wide-int is
3780 specified, so this should help the quality of the hashing a bit.
3782 * emacs.c: Integer overflow minor fix.
3783 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3784 Define only if GNU_LINUX.
3785 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3787 * dispnew.c: Integer signedness and overflow fixes.
3788 Remove unnecessary forward decls, that were a maintenance hassle.
3789 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3791 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3792 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3793 (prepare_desired_row, line_draw_cost):
3794 Use int, not unsigned, where either works.
3795 (save_current_matrix, restore_current_matrix):
3796 Use ptrdiff_t, not size_t, where either works.
3797 (init_display): Check for overflow more accurately, and without
3798 relying on undefined behavior.
3800 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3801 Remove, replacing with the new symbols in lisp.h. All uses changed.
3802 * fileio.c (make_temp_name):
3803 * filelock.c (lock_file_1, lock_file):
3804 * xdisp.c (message_dolog):
3805 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3806 Use pMd etc. instead.
3807 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3808 replacing the pWIDE etc. symbols removed from editfns.c.
3810 * keyboard.h (num_input_events): Now uintmax_t.
3811 This is (very slightly) less likely to mess up due to wraparound.
3814 * buffer.c: Integer signedness fixes.
3815 (alloc_buffer_text, enlarge_buffer_text):
3816 Use ptrdiff_t rather than size_t when either will do, as we prefer
3819 * alloc.c: Integer signedness and overflow fixes.
3820 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3821 (__malloc_size_t): Default to size_t, not to int.
3822 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3823 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3824 Prefer ptrdiff_t to size_t when either would do, as we prefer
3826 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3827 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3828 Now const. Initialize with values that are in range even if char
3830 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3831 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3832 These functions do the right thing with sizes > 2**32.
3833 (check_depth): Now ptrdiff_t, not int.
3834 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3835 Adjust to new way of storing sizes. Check for size overflow bugs
3837 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3838 slightly wrong anyway, as it missed one instance of
3839 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3840 (refill_memory_reserve): Omit needless cast to size_t.
3841 (mark_object_loop_halt): Mark as externally visible.
3843 * xselect.c: Integer signedness and overflow fixes.
3844 (Fx_register_dnd_atom, x_handle_dnd_message):
3845 Use ptrdiff_t, not size_t, since we prefer signed.
3846 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3847 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3848 x_dnd_atoms_size and x_dnd_atoms_length.
3850 * doprnt.c: Prefer signed to unsigned when either works.
3852 * doprnt.c (doprnt):
3854 * xdisp.c (vmessage):
3855 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3856 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3857 prefer signed arithmetic to avoid comparison confusion.
3858 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3859 but is a bit tricky.
3861 Assume freestanding C89 headers, string.h, stdlib.h.
3862 * data.c, doprnt.c, floatfns.c, print.c:
3863 Include float.h unconditionally.
3864 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3865 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3866 * regex.c: Likewise for stddef.h, string.h.
3867 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3868 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3869 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3870 (STDC_HEADERS): Remove obsolete defines.
3871 * sysdep.c: Include limits.h unconditionally.
3873 Assume support for memcmp, memcpy, memmove, memset.
3874 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3875 * regex.c (memcmp, memcpy):
3876 Remove; we assume C89 now.
3878 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3879 (__malloc_safe_bcopy): Remove; no longer needed.
3881 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3882 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3883 well either way, and we prefer signed to unsigned.
3885 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3887 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3888 closes the connection while we're reading (bug#9182).
3890 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3892 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3893 are specified (Bug#9168).
3895 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3897 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3898 Found by GCC static checking and --with-wide-int on a 32-bit host.
3900 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3902 * xdisp.c (compute_display_string_pos): Fix logic of caching
3903 previous display string position. Initialize cached_prev_pos to
3904 -1. Fixes slow-down at the beginning of a buffer.
3906 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3908 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3909 for attrs[LFACE_FONTSET_INDEX].
3911 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3913 * xml.c (parse_region): Remove unused local
3914 that was recently introduced.
3916 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3918 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3919 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3921 * xdisp.c (move_it_in_display_line_to): Record the best matching
3922 position for TO_CHARPOS while scanning the line, and restore it on
3923 exit if none of the characters scanned was an exact match.
3924 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3925 when exact match is impossible due to invisible text, and the
3926 lines are truncated.
3928 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3930 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3933 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3935 Fix a significant slow-down of cursor motion with C-n, C-p,
3936 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3937 auto-repeat under bidi redisplay in fontified buffers.
3938 * xdisp.c (compute_stop_pos_backwards): New function.
3939 (next_element_from_buffer): Call compute_stop_pos_backwards to
3940 find a suitable prev_stop when we find ourselves before
3942 (reseat): Don't look for prev_stop, as that could mean a very long
3944 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3945 <cached_disp_overlay_modiff>: Cache for last found display string
3947 (compute_display_string_pos): Return the cached position if asked
3948 about the same buffer in the same area of character positions, and
3949 the buffer wasn't changed since the time the display string
3950 position was cached.
3952 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3954 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3955 is an integer, which is important for empty lines. (Bug#9149)
3957 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3959 * frame.c (Fmodify_frame_parameters): In tty case, update the
3960 default face if necessary (Bug#4238).
3962 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3964 * editfns.c (Fstring_to_char): No need to explain what a character
3965 is in the docstring (Bug#6576).
3967 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3969 * xml.c (parse_region): Make sure we always return a tree.
3971 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3973 * xml.c (parse_region): If a document contains only comments,
3976 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3978 * xml.c (make_dom): Return comments, too.
3980 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3983 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3984 and the surrounding thread.
3985 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3986 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3987 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3989 * s/openbsd.h (BROKEN_SIGIO): Define.
3990 * unexelf.c (unexec) [__OpenBSD__]:
3991 Don't update the .mdebug section of the Alpha COFF symbol table.
3993 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3995 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3998 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4000 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4001 This fixes some race conditions on the permissions of any newly
4004 * alloc.c (valid_pointer_p): Use pipe, not open.
4005 This fixes some permissions issues when debugging.
4007 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4008 If fchown fails to set both uid and gid, try to set just gid,
4009 as that is sometimes allowed. Adjust the file's mode to eliminate
4010 setuid or setgid bits that are inappropriate if fchown fails.
4012 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4014 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4015 to compare Lisp_Objects.
4016 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4017 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4018 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4020 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4022 * lread.c (read_integer): Unread even EOF character.
4023 (read1): Likewise. Properly record start position of symbol.
4025 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4026 symbol character follows.
4028 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4030 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4031 This works around a problem with the previous change to Fcopy_file.
4032 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4033 and without this change, GCC might complain about discarding
4034 fchown's return value.
4036 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4038 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4040 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4042 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4044 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4046 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4047 it's used from the C level.
4049 * process.c: Use the same condition for POLL_FOR_INPUT in both
4050 keyboard.c and process.c (bug#1858).
4052 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4054 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4055 (Fgnutls_boot): Use it.
4057 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4059 * doc.c (Fsubstitute_command_keys): Revert last change.
4061 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4063 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4064 quotes the next character, and doesn't affect other longer
4065 sequences (bug#8935).
4067 * lread.c (syms_of_lread): Clarify that is isn't only
4068 `eval-buffer' and `eval-defun' that's affected by
4069 `lexical-binding' (bug#8460).
4071 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4073 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4074 bidi redisplay when a line includes both an image and is truncated.
4076 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4078 Fix minor problems found by static checking.
4079 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4080 (elsz): Now a signed constant, not a size_t var. We prefer signed
4081 types to unsigned, to avoid integer comparison confusion. Without
4082 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4083 "cannot optimize loop, the loop counter may overflow", a symptom
4085 * indent.c (Fvertical_motion): Mark locals as initialized.
4086 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4088 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4090 * search.c (Fre_search_backward): Mention `case-fold-search' in
4091 all the re_search_* functions (bug#8138).
4093 * keyboard.c (Fopen_dribble_file): Document when the file is
4096 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4098 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4101 Support bidi reordering of display and overlay strings.
4102 * xdisp.c (compute_display_string_pos)
4103 (compute_display_string_end): Accept additional argument STRING.
4104 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4105 (reseat_to_string): Initialize bidi_it->string.s and
4106 bidi_it->string.schars.
4107 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4108 NULL (avoids a crash in bidi_paragraph_init).
4109 Initialize itb.string.lstring.
4110 (init_iterator): Call bidi_init_it only of a valid
4111 buffer position was specified. Initialize paragraph_embedding to
4113 (reseat_to_string): Initialize the bidi iterator.
4114 (display_string): If we need to ignore text properties of
4115 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4116 original value of -1 will not work with bidi.)
4117 (compute_display_string_pos): First arg is now struct
4118 `text_pos *'; all callers changed. Support display properties on
4120 (compute_display_string_end): Support display properties on Lisp
4122 (init_iterator, reseat_1, reseat_to_string): Initialize the
4123 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4124 when iterating on a string not from display properties).
4125 (compute_display_string_pos, compute_display_string_end):
4126 Fix calculation of the object to scan. Fixes an error when using
4128 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4129 base_level_stop; instead, set base_level_stop to BEGV.
4130 Fixes crashes in vertical-motion.
4131 (next_element_from_buffer): Improve commentary for when
4132 the iterator is before prev_stop.
4133 (init_iterator): Initialize bidi_p from the default value of
4134 bidi-display-reordering, not from buffer-local value. Use the
4135 buffer-local value only if initializing for buffer iteration.
4136 (handle_invisible_prop): Support invisible properties on strings
4137 that are being bidi-reordered.
4138 (set_iterator_to_next): Support bidi reordering of C strings and
4140 (next_element_from_string): Support bidi reordering of Lisp
4142 (handle_stop_backwards): Support Lisp strings as well.
4143 (display_string): Support display of R2L glyph rows.
4144 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4145 (init_iterator): Don't initialize it->bidi_p for strings
4147 (reseat_to_string): Initialize it->bidi_p for strings here.
4148 (next_element_from_string, next_element_from_c_string)
4149 (next_element_from_buffer): Add xassert's for correspondence
4150 between IT's object being iterated and it->bidi_it.string
4152 (face_before_or_after_it_pos): Support bidi iteration.
4153 (next_element_from_c_string): Handle the case of the first string
4154 character that is not the first one in the visual order.
4155 (get_visually_first_element): New function, refactored from common
4156 parts of next_element_from_buffer, next_element_from_string, and
4157 next_element_from_c_string.
4158 (tool_bar_lines_needed, redisplay_tool_bar)
4159 (display_menu_bar): Force left-to-right direction. Add a FIXME
4160 comment for making that be controlled by a user option.
4161 (push_it, pop_it): Save and restore the state of the
4162 bidi iterator. Save and restore the bidi_p flag.
4163 (pop_it): Iterate out of display property for string iteration as
4165 (iterate_out_of_display_property): Support iteration over strings.
4166 (handle_single_display_spec): Set up it->bidi_it for iteration
4167 over a display string, and call bidi_init_it.
4168 (handle_single_display_spec, next_overlay_string)
4169 (get_overlay_strings_1, push_display_prop): Set up the bidi
4170 iterator for displaying display or overlay strings.
4171 (forward_to_next_line_start): Don't use the shortcut if
4173 (back_to_previous_visible_line_start): If handle_display_prop
4174 pushed the iterator stack, restore the internal state of the bidi
4175 iterator by calling bidi_pop_it same number of times.
4176 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4177 and we are bidi-iterating, don't decrement the iterator position;
4178 instead, set the first_elt flag in the bidi iterator, to produce
4180 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4181 (push_display_prop): xassert that we are iterating a buffer.
4182 (push_it, pop_it): Save and restore paragraph_embedding member.
4183 (handle_single_display_spec, next_overlay_string)
4184 (get_overlay_strings_1, reseat_1, reseat_to_string)
4185 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4186 correctly. Don't assume unibyte strings are not bidi-reordered.
4187 (compute_display_string_pos)
4188 (compute_display_string_end): Fix handling the case of C string.
4189 (push_it, pop_it): Save and restore from_disp_prop_p.
4190 (handle_single_display_spec, push_display_prop): Set the
4191 from_disp_prop_p flag.
4192 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4193 (pop_it): Call iterate_out_of_display_property only if we are
4194 popping after iteration over a string that came from a display
4195 property. Fix a typo in popping stretch info. Add an assertion
4196 for verifying that the iterator position is in sync with the bidi
4198 (handle_single_display_spec, get_overlay_strings_1)
4199 (push_display_prop): Fix initialization of paragraph direction for
4200 string when that of the parent object is not yet determined.
4201 (reseat_1): Call bidi_init_it to resync the bidi
4202 iterator with IT's position. (Bug#7616)
4203 (find_row_edges): If ROW->start.pos gives position
4204 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4205 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4206 Reset the from_disp_prop_p flag.
4207 (SAVE_IT, RESTORE_IT): New macros.
4208 (pos_visible_p, face_before_or_after_it_pos)
4209 (back_to_previous_visible_line_start)
4210 (move_it_in_display_line_to, move_it_in_display_line)
4211 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4212 (try_scrolling, redisplay_window, display_line): Use them when
4213 saving a temporary copy of the iterator and restoring it back.
4214 (back_to_previous_visible_line_start, reseat_1)
4215 (init_iterator): Empty the bidi cache "stack".
4216 (move_it_in_display_line_to): If iterator ended up at
4217 EOL, but we never saw any buffer positions smaller than
4218 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4219 motion in bidi-reordered lines.
4220 (move_it_in_display_line_to): Record prev_method and prev_pos
4221 immediately before the call to set_iterator_to_next. Fixes cursor
4222 motion in bidi-reordered lines with stretch glyphs and strings
4223 displayed in margins. (Bug#8133) (Bug#8867)
4224 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4226 (pos_visible_p): Support positions in bidi-reordered lines.
4227 Save and restore bidi cache.
4229 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4230 (bidi_paragraph_info): Delete unused struct.
4231 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4232 (bidi_cache_start): New variable.
4233 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4235 (bidi_cache_fetch_state, bidi_cache_search)
4236 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4237 (bidi_cache_find, bidi_peek_at_next_level)
4238 (bidi_level_of_next_char, bidi_find_other_level_edge)
4239 (bidi_move_to_visually_next): Compare cache index with
4240 bidi_cache_start rather than with zero.
4241 (bidi_fetch_char): Accept new argument STRING; all callers
4242 changed. Support iteration over a string. Support strings with
4243 display properties. Support unibyte strings. Fix the type of
4244 `len' according to what STRING_CHAR_AND_LENGTH expects.
4245 (bidi_paragraph_init, bidi_resolve_explicit_1)
4246 (bidi_resolve_explicit, bidi_resolve_weak)
4247 (bidi_level_of_next_char, bidi_move_to_visually_next):
4248 Support iteration over a string.
4249 (bidi_set_sor_type, bidi_resolve_explicit_1)
4250 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4251 can now be zero (for strings); special values 0 and -1 were
4252 changed to -1 and -2, respectively.
4253 (bidi_char_at_pos): New function.
4254 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4255 Call it instead of FETCH_MULTIBYTE_CHAR.
4256 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4257 initialized to valid values.
4258 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4260 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4261 the test for valid cached positions. Fix the logic for looking up
4262 the sentinel state in the cache. GCPRO the Lisp string we are
4264 (bidi_push_it, bidi_pop_it): New functions.
4265 (bidi_initialize): Initialize the bidi cache start stack pointer.
4266 (bidi_cache_ensure_space): New function, refactored from part of
4267 bidi_cache_iterator_state. Don't assume the required size is just
4268 one BIDI_CACHE_CHUNK away.
4269 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4270 (bidi_count_bytes, bidi_char_at_pos): New functions.
4271 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4272 always valid if bidi_cache_idx is valid.
4273 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4274 is valid if it's going to be used.
4275 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4276 (bidi_cache_fetch_state, bidi_cache_search)
4277 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4278 (bidi_cache_iterator_state, bidi_cache_find)
4279 (bidi_find_other_level_edge, bidi_cache_start_stack):
4280 All variables related to cache indices are now EMACS_INT.
4282 * dispextern.h (struct bidi_string_data): New structure.
4283 (struct bidi_it): New member `string'. Make flag members be 1-bit
4284 fields, and put them last in the struct.
4285 (compute_display_string_pos, compute_display_string_end):
4287 (bidi_push_it, bidi_pop_it): Add prototypes.
4288 (struct iterator_stack_entry): New members bidi_p,
4289 paragraph_embedding, and from_disp_prop_p.
4290 (struct it): Member bidi_p is now a bit field 1 bit wide.
4291 (bidi_shelve_cache, bidi_unshelve_cache):
4294 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4295 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4296 and vector-like objects.
4298 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4299 cache around display iteration.
4301 * window.c (Fwindow_end, window_scroll_pixel_based)
4302 (displayed_window_lines, Frecenter): Save and restore the bidi
4303 cache around display iteration.
4305 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4307 * editfns.c (Fdelete_region): Clarify the use of the named
4308 parameters (bug#6788).
4310 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4312 * indent.c (Fvertical_motion): Set and restore w->pointm when
4313 saving and restoring the window's buffer (Bug#9006).
4315 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4317 * editfns.c (Fstring_to_char): Clarify just what is returned
4318 (bug#6576). Text by Eli Zaretskii.
4320 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4322 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4324 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4326 * buffer.c (mmap_find): Fix a typo.
4328 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4330 Fix execution of x selection hooks.
4331 * xselect.c (Qx_lost_selection_functions)
4332 (Qx_sent_selection_functions): New vars.
4333 (syms_of_xselect): DEFSYM them.
4334 (x_handle_selection_request): Pass Qx_sent_selection_functions
4335 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4336 (x_handle_selection_clear,x_clear_frame_selections):
4337 Pass Qx_lost_selection_functions rather than
4338 Vx_lost_selection_functions to Frun_hook_with_args.
4340 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4342 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4343 The old code sometimes used this field without initializing it.
4345 * alloc.c (gc_sweep): Don't read past end of array.
4346 In theory, the old code could also have corrupted Emacs internals,
4347 though it'd be very unlikely.
4349 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4351 * character.c (Fcharacterp): Don't advertise optional ignored
4352 argument. (Bug#4026)
4354 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4356 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4359 * window.c (Fset_window_start): Doc fix (bug#4199).
4360 (Fset_window_hscroll): Ditto.
4362 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4364 Fix minor new problems caught by GCC 4.6.1.
4365 * term.c (init_tty): Remove unused local.
4366 * xsettings.c (store_monospaced_changed): Define this function only
4367 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4370 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4372 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4374 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4376 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4377 are the mini-buffer and the echo area (bug#3320).
4379 * term.c (init_tty): Remove support for supdup, c10 and perq
4380 terminals, which are no longer supported (bug#1482).
4382 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4384 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4386 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4388 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4389 for non-popups (Bug#3642).
4391 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4393 * alloc.c (reset_malloc_hooks): Protoize.
4394 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4395 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4396 * cm.c (losecursor): Likewise.
4397 * data.c (fmod): Likewise.
4398 * dispnew.c (swap_glyphs_in_rows): Likewise.
4399 * emacs.c (memory_warning_signal): Likewise.
4400 * floatfns.c (float_error): Likewise.
4401 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4402 (otf_open, font_otf_capability, generate_otf_features)
4403 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4405 * image.c (pbm_read_file): Likewise.
4406 * indent.c (string_display_width): Likewise.
4407 * intervals.c (check_for_interval, search_for_interval)
4408 (inc_interval_count, count_intervals, root_interval)
4409 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4410 * lread.c (defalias): Likewise.
4411 * ralloc.c (r_alloc_check): Likewise.
4412 * regex.c (set_image_of_range_1, set_image_of_range)
4413 (regex_grow_registers): Likewise.
4414 * sysdep.c (strerror): Likewise.
4415 * termcap.c (valid_filename_p, tprint, main): Likewise.
4416 * tparam.c (main): Likewise.
4417 * unexhp9k800.c (run_time_remap, save_data_space)
4418 (update_file_ptrs, read_header, write_header, calculate_checksum)
4419 (copy_file, copy_rest, display_header): Likewise.
4420 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4422 * xdisp.c (check_it): Likewise.
4423 * xfaces.c (register_color, unregister_color, unregister_colors):
4425 * xfns.c (print_fontset_result): Likewise.
4426 * xrdb.c (member, fatal, main): Likewise.
4428 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4430 Fix minor problems found by static checking (Bug#9031).
4431 * chartab.c (char_table_set_range, map_sub_char_table):
4432 Remove unused locals.
4433 (uniprop_table): Now static.
4434 * composite.c (_work_char): Remove unused static var.
4436 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4438 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4440 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4442 * gtkutil.c (qttip_cb): Remove code without function.
4444 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4446 * w32.c (pthread_sigmask): New stub.
4448 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4450 Use pthread_sigmask, not sigprocmask (Bug#9010).
4451 sigprocmask is portable only for single-threaded applications, and
4452 Emacs can be multi-threaded when it uses GTK.
4453 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4455 * callproc.c (Fcall_process):
4456 * process.c (create_process):
4457 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4458 Use pthread_sigmask, not sigprocmask.
4460 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4462 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4463 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4466 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4468 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4469 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4470 (xg_hide_tooltip): Fix comment.
4472 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4473 in registerServicesMenuSendTypes.
4474 (validRequestorForSendType): Don't check ns_return_types.
4476 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4479 2011-07-08 Jason Rumney <jasonr@gnu.org>
4481 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4482 SH_SHOW for hidden windows (Bug#5482).
4484 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4485 frame struct members of non-existent frames (Bug#6284).
4487 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4489 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4490 variable firstTime not needed on OSX >= 10.6.
4491 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4492 >= 10.5. Use setKnobProportion, setDoubleValue.
4494 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4495 (MAC_OS_X_VERSION_10_5): Define if not defined.
4496 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4497 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4498 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4500 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4501 cString and lossyCString on OSX >= 10.4
4503 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4504 sizeToFit on OSX >= 10.2.
4506 * nsimage.m (allocInitFromFile): Don't use deprecated method
4507 bestRepresentationForDevice on OSX >= 10.6.
4509 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4512 * emacs.c: Declare unexec_init_emacs_zone.
4514 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4516 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4518 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4519 on svcsMenu (Bug#8842).
4521 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4523 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4525 * nsterm.m (QUTF8_STRING): Declare.
4526 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4527 (validRequestorForSendType): Return type is (id).
4528 Change indexOfObjectIdenticalTo to indexOfObject.
4529 Check if we have local selection before returning self (Bug#8842).
4530 (writeSelectionToPasteboard): Put local selection into paste board
4531 if we have a local selection (Bug#8842).
4532 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4534 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4535 (ns_get_local_selection): Declare.
4537 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4539 * keymap.c (describe_map_tree): Don't insert a double newline at
4540 the end of the buffer (bug#1169) and return whether we inserted
4543 * callint.c (Fcall_interactively): Change "reading args" to
4544 "providing args" to try to clarify what it does (bug#1010).
4546 2011-07-07 Kenichi Handa <handa@m17n.org>
4548 * composite.c (composition_compute_stop_pos): Ignore a static
4549 composition starting before CHARPOS (Bug#8915).
4551 * xdisp.c (handle_composition_prop): Likewise.
4553 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4555 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4558 2011-07-07 Kenichi Handa <handa@m17n.org>
4560 * character.h (unicode_category_t): New enum type.
4562 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4563 (Qchar_code_property_table): New variable.
4564 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4565 (UNIPROP_COMPRESSED_FORM_P): New macros.
4566 (char_table_ascii): Uncompress the compressed values.
4567 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4568 Uncompress the compressed values.
4569 (sub_char_table_ref_and_range): Likewise.
4570 (char_table_ref_and_range): Uncompress the compressed values.
4571 (sub_char_table_set): New arg is_uniprop. Callers changed.
4572 Uncompress the compressed values.
4573 (sub_char_table_set_range): Args changed. Callers changed.
4574 (char_table_set_range): Adjuted for the above change.
4575 (map_sub_char_table): Delete args default_val and parent. Add arg
4576 top. Give decoded values to a Lisp function.
4577 (map_char_table): Adjust for the above change. Give decoded
4578 values to a Lisp function. Gcpro more variables.
4579 (uniprop_table_uncompress)
4580 (uniprop_decode_value_run_length): New functions.
4581 (uniprop_decoder, uniprop_decoder_count): New variables.
4582 (uniprop_get_decoder, uniprop_encode_value_character)
4583 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4585 (uniprop_encoder, uniprop_encoder_count): New variables.
4586 (uniprop_get_encoder, uniprop_table)
4587 (Funicode_property_table_internal, Fget_unicode_property_internal)
4588 (Fput_unicode_property_internal): New functions.
4589 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4590 Sunicode_property_table_internal, Sget_unicode_property_internal,
4591 and Sput_unicode_property_internal. Defvar_lisp
4592 char-code-property-alist.
4594 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4595 Vunicode_category_table.
4597 * font.c (font_range): Adjust for the change of
4598 Vunicode_category_table.
4600 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4602 * m/iris4d.h: Remove file, move contents ...
4603 * s/irix6-5.h: ... here.
4605 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4607 Remove unportable assumption about struct layout (Bug#8884).
4608 * alloc.c (mark_buffer):
4609 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4610 (clone_per_buffer_values): Don't assume that
4611 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4612 This isn't true in general, and it's particularly not true
4613 if Emacs is configured with --with-wide-int.
4614 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4615 New macros, used in the buffer.c change.
4617 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4619 * xsettings.c: Use both GConf and GSettings if both are available.
4620 (store_config_changed_event): Add comment.
4621 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4622 (store_tool_bar_style_changed): New functions.
4623 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4624 (struct xsettings): Move font inside HAVE_XFT.
4625 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4626 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4627 Move inside HAVE_XFT.
4628 (something_changed_gsettingsCB): Rename from something_changedCB.
4629 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4631 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4632 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4633 (something_changed_gconfCB): Rename from something_changedCB.
4634 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4635 (parse_settings): Move check for font inside HAVE_XFT.
4636 (read_settings, apply_xft_settings): Add comment.
4637 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4638 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4639 call store_font_name_changed.
4640 (xft_settings_event): Add comment.
4641 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4642 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4643 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4644 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4645 (xsettings_initialize): Call init_gsettings last.
4646 (xsettings_get_system_font, xsettings_get_system_normal_font):
4649 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4651 Random fixes. E.g., (random) never returned negative values.
4652 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4653 subseconds part to the entropy, as that's a bit more random.
4654 Prefer signed to unsigned, since the signedness doesn't matter and
4655 in general we prefer signed. When given a limit, use a
4656 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4657 latter isn't right if USE_2_TAGS_FOR_INTS.
4658 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4659 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4661 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4663 * textprop.c (text_property_stickiness):
4664 Obey Vtext_property_default_nonsticky.
4665 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4666 * w32fns.c (syms_of_w32fns):
4667 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4669 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4671 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4672 This is more efficient than Ffile_directory_p and avoids a minor race.
4674 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4676 * buffer.c (Foverlay_put): Say what the return value is
4679 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4680 is a directory before asking whether to use the file name
4682 (barf_or_query_if_file_exists): Make the "File is a directory"
4683 error be more correct.
4685 * fns.c (Frequire): Remove the mention of the .gz files, since
4686 that's installation-specific, but keep the mention of
4687 `get-load-suffixes'.
4689 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4691 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4692 Report string overflow if the output is too long.
4694 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4696 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4697 (syms_of_gnutls): Remove duplicate DEFSYM for
4698 Qgnutls_bootprop_verify_hostname_error, an error for
4699 Qgnutls_bootprop_verify_error (which is no longer used).
4701 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4702 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4703 Also (re)move comments that are misplaced or no longer relevant.
4705 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4707 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4709 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4711 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4712 and background color parameters if they have been changed.
4714 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4716 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4718 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4720 * xsettings.c (SYSTEM_FONT): Define only when used.
4721 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4723 * keymap.c (access_keymap_1): Now static.
4725 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4727 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4728 leave any prefix arg for the up event (Bug#1586).
4730 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4732 * lread.c (syms_of_lread): Mention single symbols defined by
4733 `defvar' or `defconst' (bug#7154).
4735 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4736 (Frequire): Mention get-load-suffixes.
4738 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4740 * window.h (window): Remove clone_number slot.
4741 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4743 (make_parent_window, make_window, saved_window)
4744 (Fset_window_configuration, save_window_save): Don't deal with
4746 * buffer.c (Qclone_number): Remove declaration.
4747 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4749 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4751 Add multiple inheritance to keymaps.
4752 * keymap.c (Fmake_composed_keymap): New function.
4753 (Fset_keymap_parent): Simplify.
4754 (fix_submap_inheritance): Remove.
4755 (access_keymap_1): New function extracted from access_keymap to handle
4756 embedded parents and handle lists of maps.
4757 (access_keymap): Use it.
4758 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4759 (Fcopy_keymap): Handle embedded parents.
4760 (Fcommand_remapping, define_as_prefix): Simplify.
4761 (Fkey_binding): Simplify.
4762 (syms_of_keymap): Move minibuffer-local-completion-map,
4763 minibuffer-local-filename-completion-map,
4764 minibuffer-local-must-match-map, and
4765 minibuffer-local-filename-must-match-map to Elisp.
4766 (syms_of_keymap): Defsubr make-composed-keymap.
4767 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4768 (parse_menu_item): Trivial simplification.
4770 2011-07-01 Glenn Morris <rgm@gnu.org>
4772 * Makefile.in (SETTINGS_LIBS): Fix typo.
4774 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4776 * coding.c (Fencode_coding_string): Record the last coding system
4777 used, as the function doc string says (bug#8738).
4779 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4781 * xsettings.c (store_monospaced_changed): Take new font as arg and
4782 check for change against current_mono_font.
4783 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4784 (emacs_settings_constructor, emacs_settings_get_property)
4785 (emacs_settings_set_property, emacs_settings_class_init)
4786 (emacs_settings_init, gsettings_obj): Remove.
4787 (something_changedCB): New function for HAVE_GSETTINGS.
4788 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4789 with value as argument.
4790 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4791 g_settings_new (Bug#8967). Do not create gsettings_obj.
4792 Remove calls to g_settings_bind. Connect something_changedCB to
4795 * xgselect.c: Add defined (HAVE_GSETTINGS).
4796 (xgselect_initialize): Ditto.
4798 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4799 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4802 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4804 * eval.c (struct backtrace): Simplify and port the data structure.
4805 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4806 signed bit field, as this assumption is not portable and it makes
4807 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4808 "char debug_on_exit : 1" as this is not portable either; instead,
4809 use the portable "unsigned int debug_on_exit : 1". Remove unused
4810 member evalargs. Remove obsolete comments about cc bombing out.
4812 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4814 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4815 Let HAVE_GSETTINGS override HAVE_GCONF.
4816 (store_monospaced_changed): New function.
4817 (EMACS_SETTINGS): A new type derived from GObject to handle
4818 GSettings notifications.
4819 (emacs_settings_constructor, emacs_settings_get_property)
4820 (emacs_settings_set_property, emacs_settings_class_init):
4822 (gsettings_client, gsettings_obj): New variables.
4823 (GSETTINGS_SCHEMA): New define.
4824 (something_changedCB): Call store_monospaced_changed.
4825 (init_gsettings): New function.
4826 (xsettings_initialize): Call init_gsettings.
4827 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4830 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4833 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4835 * window.c (resize_root_window, grow_mini_window)
4836 (shrink_mini_window): Rename Qresize_root_window to
4837 Qwindow_resize_root_window and Qresize_root_window_vertically to
4838 Qwindow_resize_root_window_vertically.
4840 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4842 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4844 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4846 * makefile.w32-in: Redesign dependencies so they reflect more
4847 clearly which files are directly included by each source file,
4848 and not through other includes.
4850 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4852 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4853 (sort_overlays, overlay_strings): When an overlay's clone number
4854 matches the window's clone number process the overlay even if
4855 the overlay's window property doesn't match the current window.
4857 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4858 (Fwindow_hchild): Rename to Fwindow_left_child.
4859 (Fwindow_next): Rename to Fwindow_next_sibling.
4860 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4861 (resize_window_check): Rename to window_resize_check.
4862 (resize_window_apply): Rename to window_resize_apply.
4863 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4864 (Fdelete_other_windows_internal, resize_frame_windows)
4865 (Fsplit_window_internal, Fdelete_window_internal)
4866 (grow_mini_window, shrink_mini_window)
4867 (Fresize_mini_window_internal): Fix callers accordingly.
4869 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4871 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4872 (emacs_fixed_set_min_size): Remove.
4873 (emacs_fixed_new): Take frame as argument.
4875 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4876 (_EmacsFixedPrivate): Remove minwidth/height.
4877 Add struct frame *f.
4878 (emacs_fixed_init): Initialize priv->f.
4879 (get_parent_class, emacs_fixed_set_min_size): Remove.
4880 (emacs_fixed_new): Set priv->f to argument.
4881 (emacs_fixed_get_preferred_width)
4882 (emacs_fixed_get_preferred_height): Use min_width/height from
4883 frames size_hint to set minimum and natural (Bug#8919).
4884 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4885 and use min_width/height from frames size_hint to set
4886 min_width/height (Bug#8919).
4888 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4889 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4892 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4894 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4895 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4898 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4900 * process.c (wait_reading_process_output): Bypass select if
4901 waiting for a cell while ignoring keyboard input, and input is
4902 pending. Suggested by Jan Djärv (Bug#8869).
4904 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4906 Use gnulib's dup2 module instead of rolling our own.
4907 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4909 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4911 * dispnew.c (scrolling_window): Before scrolling, turn off a
4912 mouse-highlight in the window being scrolled.
4914 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4916 Move DEFSYM to lisp.h and use everywhere.
4918 * character.h (DEFSYM): Move declaration...
4919 * lisp.h (DEFSYM): ...here.
4925 * w32select.c: Don't include character.h.
4927 * alloc.c (syms_of_alloc):
4928 * buffer.c (syms_of_buffer):
4929 * bytecode.c (syms_of_bytecode):
4930 * callint.c (syms_of_callint):
4931 * casefiddle.c (syms_of_casefiddle):
4932 * casetab.c (init_casetab_once):
4933 * category.c (init_category_once, syms_of_category):
4934 * ccl.c (syms_of_ccl):
4935 * cmds.c (syms_of_cmds):
4936 * composite.c (syms_of_composite):
4937 * dbusbind.c (syms_of_dbusbind):
4938 * dired.c (syms_of_dired):
4939 * dispnew.c (syms_of_display):
4940 * doc.c (syms_of_doc):
4941 * editfns.c (syms_of_editfns):
4942 * emacs.c (syms_of_emacs):
4943 * eval.c (syms_of_eval):
4944 * fileio.c (syms_of_fileio):
4945 * fns.c (syms_of_fns):
4946 * frame.c (syms_of_frame):
4947 * fringe.c (syms_of_fringe):
4948 * insdel.c (syms_of_insdel):
4949 * keymap.c (syms_of_keymap):
4950 * lread.c (init_obarray, syms_of_lread):
4951 * macros.c (syms_of_macros):
4952 * msdos.c (syms_of_msdos):
4953 * print.c (syms_of_print):
4954 * process.c (syms_of_process):
4955 * search.c (syms_of_search):
4956 * sound.c (syms_of_sound):
4957 * syntax.c (init_syntax_once, syms_of_syntax):
4958 * terminal.c (syms_of_terminal):
4959 * textprop.c (syms_of_textprop):
4960 * undo.c (syms_of_undo):
4961 * w32.c (globals_of_w32):
4962 * window.c (syms_of_window):
4963 * xdisp.c (syms_of_xdisp):
4964 * xfaces.c (syms_of_xfaces):
4965 * xfns.c (syms_of_xfns):
4966 * xmenu.c (syms_of_xmenu):
4967 * xsettings.c (syms_of_xsettings):
4968 * xterm.c (syms_of_xterm): Use DEFSYM.
4970 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4972 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4974 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4976 Integer and buffer overflow fixes (Bug#8873).
4978 * print.c (printchar, strout): Check for string overflow.
4979 (PRINTPREPARE, printchar, strout):
4980 Don't set size unless allocation succeeds.
4982 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4983 for sizes. Check for string overflow more accurately.
4984 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4986 * macros.c: Integer and buffer overflow fixes.
4987 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4988 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4989 Use ptrdiff_t, not int, for sizes.
4990 Don't increment bufsize until after realloc succeeds.
4991 Check for size-calculation overflow.
4992 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4994 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4996 * lread.c: Integer overflow fixes.
4997 (read_integer): Radix is now EMACS_INT, not int,
4998 to improve quality of diagnostics for out-of-range radices.
4999 Calculate buffer size correctly for out-of-range radices.
5000 (read1): Check for integer overflow in radices, and in
5001 read-circle numbers.
5002 (read_escape): Avoid int overflow.
5003 (Fload, openp, read_buffer_size, read1)
5004 (substitute_object_recurse, read_vector, read_list, map_obarray):
5005 Use ptrdiff_t, not int, for sizes.
5006 (read1): Use EMACS_INT, not int, for sizes.
5007 Check for size overflow.
5009 * image.c (cache_image): Check for size arithmetic overflow.
5011 * lread.c: Integer overflow issues.
5012 (saved_doc_string_size, saved_doc_string_length)
5013 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5014 Now ptrdiff_t, not int.
5015 (read1): Don't assume doc string length fits in int. Check for
5016 out-of-range doc string lengths.
5017 (read_list): Don't assume file position fits in int.
5018 (read_escape): Check for hex character overflow.
5020 2011-06-22 Leo Liu <sdl.web@gmail.com>
5022 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5023 Move to minibuffer.el.
5025 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5027 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5028 The following patches are for when GLYPH_DEBUG && !XASSERT.
5029 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5030 * dispnew.c (flush_stdout):
5031 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5032 Mark as externally visible.
5033 * dispnew.c (check_window_matrix_pointers): Now static.
5034 * dispnew.c (window_to_frame_vpos):
5035 * xfns.c (unwind_create_frame):
5036 * xterm.c (x_check_font): Remove unused local.
5037 * scroll.c (CHECK_BOUNDS):
5038 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5039 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5040 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5041 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5042 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5044 (debug_method_add): Use va_list and vsprintf rather than relying
5045 on undefined behavior with wrong number of arguments.
5046 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5047 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5048 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5049 since we're not interested in debugging glyphs with old libraries.
5050 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5051 GCC 4.6.0's static checking.
5053 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5055 Integer overflow and signedness fixes (Bug#8873).
5056 A few related buffer overrun fixes, too.
5058 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5060 * dispextern.h (struct face.stipple):
5061 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5062 (x_bitmap_mask, x_allocate_bitmap_record)
5063 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5064 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5065 (x_create_bitmap_from_xpm_data):
5066 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5067 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5069 * xfaces.c (load_pixmap):
5070 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5071 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5072 (.bitmaps_last, struct x_output.icon_bitmap):
5073 Use ptrdiff_t, not int, for bitmap indexes.
5074 (x_allocate_bitmap_record): Check for size overflow.
5075 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5077 Use ptrdiff_t, not int, for overlay counts.
5078 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5079 * editfns.c (overlays_around, get_pos_property):
5080 * textprop.c (get_char_property_and_overlay):
5081 * xdisp.c (next_overlay_change, note_mouse_highlight):
5082 * xfaces.c (face_at_buffer_position):
5083 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5084 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5085 (Fnext_overlay_change, Fprevious_overlay_change)
5086 (mouse_face_overlay_overlaps, Foverlays_in):
5087 Use ptrdiff_t, not int, for sizes.
5088 (overlays_at, overlays_in): Check for size-calculation overflow.
5090 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5092 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5093 (x_session_initialize): Do not assume string length fits in int.
5095 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5096 This is unlikely, but can occur if DPI is outlandish.
5098 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5099 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5101 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5102 * xrdb.c (magic_file_p, search_magic_path):
5103 Omit last arg SUFFIX; it was always 0. All callers changed.
5104 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5106 * xfont.c (xfont_match): Avoid need for strlen.
5108 * xfns.c: Don't assume strlen fits in int.
5109 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5111 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5112 not unsigned long, as we prefer signed integers. All callers changed.
5113 Detect integer overflow in repeat count.
5114 (message_dolog): Don't assume print length fits in 39 bytes.
5115 (display_mode_element): Don't assume strlen fits in int.
5117 * termcap.c: Don't assume sizes fit in int and never overflow.
5118 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5119 (gobble_line): Check for size-calculation overflow.
5121 * minibuf.c (Fread_buffer):
5122 * lread.c (intern, intern_c_string):
5123 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5124 Don't assume string length fits in int.
5126 * keyboard.c (parse_tool_bar_item):
5127 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5129 * font.c: Don't assume string length fits in int.
5130 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5131 Use ptrdiff_t, not int.
5132 (font_intern_prop): Don't assume string length fits in int.
5133 Don't assume integer property fits in fixnum.
5134 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5136 * filelock.c: Fix some buffer overrun and integer overflow issues.
5137 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5138 Reformulate so as not to need the command string.
5139 Invoke gzip -cd rather than gunzip, as it's more portable.
5140 (lock_info_type, lock_file_1, lock_file):
5141 Don't assume pid_t and time_t fit in unsigned long.
5142 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5143 (current_lock_owner): Prefer signed type for sizes.
5144 Use memcpy, not strncpy, where memcpy is what is really wanted.
5145 Don't assume (via atoi) that time_t and pid_t fit in int.
5146 Check for time_t and/or pid_t out of range, e.g., via a network share.
5147 Don't alloca where an auto var works fine.
5149 * fileio.c: Fix some integer overflow issues.
5150 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5151 Don't assume string length fits in int.
5152 (directory_file_name): Don't assume string length fits in long.
5153 (make_temp_name): Don't assume pid fits in int, or that its print
5154 length is less than 20.
5156 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5158 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5160 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5162 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5163 We prefer signed integers, even for size calculations.
5165 * emacs.c: Don't assume string length fits in 'int'.
5166 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5167 (main): Don't invoke strlen when not needed.
5169 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5170 (XD_DEBUG_MESSAGE): Don't waste a byte.
5172 * callproc.c (getenv_internal_1, getenv_internal)
5174 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5176 * lread.c (invalid_syntax): Omit length argument.
5177 All uses changed. This doesn't fix a bug, but it simplifies the
5178 code away from its former Hollerith-constant appearance, and it's
5179 one less 'int' to worry about when looking at integer-overflow issues.
5180 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5182 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5183 This didn't break anything, but it didn't help either.
5184 It's confusing to put a bogus integer in a place where the actual
5185 value does not matter.
5186 (LIST_END_P): Remove unused macro and its bogus comment.
5187 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5189 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5190 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5192 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5193 We prefer signed types, and the value cannot exceed the EMACS_INT
5194 range anyway (because otherwise the length would not be representable).
5195 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5196 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5197 This avoids a GCC warning when WIDE_EMACS_INT.
5199 * indent.c (sane_tab_width): New function.
5200 (current_column, scan_for_column, Findent_to, position_indentation)
5201 (compute_motion): Use it. This is just for clarity.
5202 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5204 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5206 * lisp.h (lint_assume): New macro.
5207 * composite.c (composition_gstring_put_cache):
5208 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5210 * editfns.c, insdel.c:
5211 Omit unnecessary forward decls, to simplify future changes.
5213 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5215 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5217 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5218 Use much-faster test for byte-length change.
5219 Don't assume string byte-length fits in 'int'.
5220 Check that character arg fits in 'int'.
5221 (mapcar1): Declare byte as byte, for clarity.
5223 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5225 * fns.c (concat): Catch string overflow earlier.
5226 Do not rely on integer wraparound.
5228 * dispextern.h (struct it.overlay_strings_charpos)
5229 (struct it.selective): Now EMACS_INT, not int.
5230 * xdisp.c (forward_to_next_line_start)
5231 (back_to_previous_visible_line_start)
5232 (reseat_at_next_visible_line_start, next_element_from_buffer):
5233 Don't arbitrarily truncate the value of 'selective' to int.
5235 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5237 * composite.c: Don't truncate sizes to 'int'.
5238 (composition_gstring_p, composition_reseat_it)
5239 (composition_adjust_point): Use EMACS_INT, not int.
5240 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5241 not EMACS_UINT, for indexes.
5243 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5245 * buffer.c: Include <verify.h>.
5246 (struct sortvec.priority, struct sortstr.priority):
5247 Now EMACS_INT, not int.
5248 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5249 (struct sortstr.size, record_overlay_string)
5250 (struct sortstrlist.size, struct sortlist.used):
5251 Don't truncate size to int.
5252 (record_overlay_string): Check for size-calculation overflow.
5253 (init_buffer_once): Check at compile-time, not run-time.
5255 2011-06-22 Jim Meyering <meyering@redhat.com>
5257 Don't leak an XBM-image-sized buffer
5258 * image.c (xbm_load): Free the image buffer after using it.
5260 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5263 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5264 that Sun C diagnosed.
5265 * fns.c (secure_hash): Fix pointer signedness issue.
5266 * intervals.c (static_offset_intervals): New function.
5267 (offset_intervals): Use it.
5269 2011-06-21 Leo Liu <sdl.web@gmail.com>
5272 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5275 * fns.c (secure_hash): Rename from crypto_hash_function and change
5276 the first arg to accept symbols.
5277 (Fsecure_hash): New primitive.
5278 (syms_of_fns): New symbols.
5280 2011-06-20 Deniz Dogan <deniz@dogan.se>
5282 * process.c (Fset_process_buffer): Clarify return value in
5285 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5287 * dispnew.c (add_window_display_history): Use BVAR.
5289 * xdisp.c (debug_method_add): Use BVAR.
5290 (check_window_end, dump_glyph_matrix, dump_glyph)
5291 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5293 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5296 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5297 check till after the cache is created in init_frame_faces.
5299 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5301 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5303 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5305 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5306 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5307 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5309 Improve buffer-overflow checking (Bug#8873).
5310 * fileio.c (Finsert_file_contents):
5311 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5312 Remove the old (too-loose) buffer overflow checks.
5313 They weren't needed, since make_gap checks for buffer overflow.
5314 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5315 The old code merely checked for Emacs fixnum overflow, and relied
5316 on undefined (wraparound) behavior. The new code avoids undefined
5317 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5319 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5320 Tune. Don't use wider integers than needed. Don't use alloca.
5321 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5323 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5325 * insdel.c, lisp.h (buffer_overflow): New function.
5326 (insert_from_buffer_1, replace_range, replace_range_2):
5327 * insdel.c (make_gap_larger):
5328 * editfns.c (Finsert_char):
5329 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5331 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5333 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5335 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5337 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5338 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5340 * fileio.c: Don't assume EMACS_INT fits in off_t.
5341 (emacs_lseek): New static function.
5342 (Finsert_file_contents, Fwrite_region): Use it.
5343 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5345 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5347 * fns.c: Don't overflow int when computing a list length.
5348 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5349 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5350 truncation on 64-bit hosts. Check for QUIT every
5351 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5352 faster and is responsive enough.
5353 (Flength): Report an error instead of overflowing an integer.
5354 (Fsafe_length): Return a float if the value is not representable
5355 as a fixnum. This shouldn't happen except in contrived situations.
5356 (Fnthcdr, Fsort): Don't assume list length fits in int.
5357 (Fcopy_sequence): Don't assume vector length fits in int.
5359 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5360 (header_size, word_size): New constants.
5361 (allocate_vectorlike): Don't check size overflow here.
5362 (allocate_vector): Check it here instead, since this is the only
5363 caller of allocate_vectorlike that could cause overflow.
5364 Check that the new vector's length is representable as a fixnum.
5366 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5367 The previous code was bogus. For example, next_almost_prime (32)
5368 returned 39, which is undesirable as it is a multiple of 3; and
5369 next_almost_prime (24) returned 25, which is a multiple of 5 so
5370 why was the code bothering to check for multiples of 7?
5372 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5374 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5376 Variadic C functions now count arguments with ptrdiff_t.
5377 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5378 Back then I didn't know that the Emacs coding style prefers signed int.
5379 Also, in the meantime I found a few more instances where arguments
5380 were being counted with int, which may truncate counts on 64-bit
5381 machines, or EMACS_INT, which may be unnecessarily wide.
5382 * lisp.h (struct Lisp_Subr.function.aMANY)
5383 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5384 Arg counts are now ptrdiff_t, not size_t.
5385 All variadic functions and their callers changed accordingly.
5386 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5387 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5388 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5389 * callint.c (Fcall_interactively): Check arg count for overflow,
5390 to avoid potential buffer overrun. Use signed char, not 'int',
5391 for 'varies' array, so that we needn't bother to check its size
5392 calculation for overflow.
5393 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5394 * eval.c (apply_lambda):
5395 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5396 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5397 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5399 * callint.c (Fcall_interactively): Don't use index var as event count.
5401 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5402 * mem-limits.h (SIZE): Remove; no longer used.
5404 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5406 Remove unnecessary casts.
5407 * xterm.c (x_term_init):
5408 * xfns.c (x_set_border_pixel):
5409 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5410 These aren't needed now that we assume ANSI C.
5412 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5413 It's more likely to cause problems (due to unsigned overflow)
5416 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5418 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5420 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5422 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5424 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5426 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5428 GLYPH_CODE_FACE returns EMACS_INT, not int.
5429 * dispextern.h (merge_faces):
5430 * xfaces.c (merge_faces):
5431 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5432 Don't assume EMACS_INT fits in int.
5434 * character.h (CHAR_VALID_P): Remove unused parameter.
5435 * fontset.c, lisp.h, xdisp.c: All uses changed.
5437 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5439 * fns.c (concat): Minor tuning based on overflow analysis.
5440 This doesn't fix any bugs. Use int to hold character, instead
5441 of constantly refetching from Emacs object. Use XFASTINT, not
5442 XINT, for value known to be a character. Don't bother comparing
5443 a single byte to 0400, as it's always less.
5445 * floatfns.c (Fexpt):
5446 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5448 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5451 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5453 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5454 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5455 incorrectly succeed when S was a string, because 4294967386 was
5456 truncated before it was used.
5458 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5459 Otherwise, an out-of-range integer could cause undefined behavior
5462 * composite.c: Use int, not EMACS_INT, for characters.
5463 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5464 EMACS_INT, for values that are known to be in character range.
5465 This doesn't fix any bugs but is the usual style inside Emacs and
5466 may generate better code on 32-bit machines.
5468 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5469 This is for reasons similar to the recent CHAR_STRING fix.
5470 * charset.c (Fencode_char): Check that character arg is actually
5471 a character. Pass an int to ENCODE_CHAR.
5472 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5473 wider than 'int', as a compile-time check to prevent future regressions
5476 * character.c (char_string): Remove unnecessary casts.
5478 Make sure a 64-bit char is never passed to CHAR_STRING.
5479 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5480 by silently ignoring the top 32 bits, allowing some values
5481 that were far too large to be valid characters.
5482 * character.h: Include <verify.h>.
5483 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5484 arguments are no wider than unsigned, as a compile-time check
5485 to prevent future regressions in this area.
5487 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5488 (Fsubst_char_in_region):
5490 * xdisp.c (decode_mode_spec_coding):
5491 Adjust to CHAR_STRING's new requirement.
5492 * editfns.c (Finsert_char, Fsubst_char_in_region):
5493 * fns.c (concat): Check that character args are actually
5494 characters. Without this test, these functions did the wrong
5495 thing with wildly out-of-range values on 64-bit hosts.
5497 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5498 These casts should not be needed on 32-bit hosts, either.
5499 * keyboard.c (read_char):
5500 * lread.c (Fload): Remove casts to unsigned.
5502 * lisp.h (UNSIGNED_CMP): New macro.
5503 This fixes comparison bugs on 64-bit hosts.
5504 (ASCII_CHAR_P): Use it.
5505 * casefiddle.c (casify_object):
5506 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5507 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5508 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5509 * dispextern.h (FACE_FROM_ID):
5510 * keyboard.c (read_char): Use UNSIGNED_CMP.
5512 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5513 not to EMACS_INT, to avoid GCC warning.
5515 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5517 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5518 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5519 isn't needed on 32-bit machines.
5521 * buffer.c (Fgenerate_new_buffer_name):
5522 Use EMACS_INT for count, not int.
5523 (advance_to_char_boundary): Return EMACS_INT, not int.
5525 * data.c (Qcompiled_function): Now static.
5527 * window.c (window_body_lines): Now static.
5529 * image.c (gif_load): Rename local to avoid shadowing.
5531 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5532 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5533 * alloc.c (make_save_value): Integer argument is now of type
5535 (mark_object): Use ptrdiff_t, not int.
5536 * lisp.h (pD): New macro.
5537 * print.c (print_object): Use it.
5539 * alloc.c: Use EMACS_INT, not int, to count objects.
5540 (total_conses, total_markers, total_symbols, total_vector_size)
5541 (total_free_conses, total_free_markers, total_free_symbols)
5542 (total_free_floats, total_floats, total_free_intervals)
5543 (total_intervals, total_strings, total_free_strings):
5544 Now EMACS_INT, not int. All uses changed.
5545 (Fgarbage_collect): Compute overall total using a double, so that
5546 integer overflow is less likely to be a problem. Check for overflow
5547 when converting back to an integer.
5548 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5549 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5550 These were 'int' variables that could overflow on 64-bit hosts;
5551 they were never used, so remove them instead of repairing them.
5552 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5553 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5554 Previously, this ceilinged at INT_MAX, but that doesn't work on
5556 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5558 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5559 (allocate_vectorlike): Check for ptrdiff_t overflow.
5560 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5561 when a (possibly-narrower) signed value would do just as well.
5562 We prefer using signed arithmetic, to avoid comparison confusion.
5564 * alloc.c: Catch some string size overflows that we were missing.
5565 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5566 for convenience in STRING_BYTES_MAX.
5567 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5568 The definition here is exact; the one in lisp.h was approximate.
5569 (allocate_string_data): Check for string overflow. This catches
5570 some instances we weren't catching before. Also, it catches
5571 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5572 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5573 and ptrdiff_t and EMACS_INT are both 64 bits.
5575 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5576 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5577 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5579 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5581 * alloc.c (Fmake_string): Check for out-of-range init.
5583 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5585 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5587 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5589 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5590 xg_get_default_scrollbar_width.
5592 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5593 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5594 (style_changed_cb): Call update_theme_scrollbar_width and call
5595 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5596 all frames (Bug#8505).
5597 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5598 Call gtk_window_set_resizable if HAVE_GTK3.
5599 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5600 and height if HAVE_GTK3 (Bug#8505).
5601 (scroll_bar_width_for_theme): New variable.
5602 (update_theme_scrollbar_width): New function.
5603 (xg_get_default_scrollbar_width): Move code to
5604 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5605 (xg_initialize): Call update_theme_scrollbar_width.
5607 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5609 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5611 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5613 * frame.c (make_frame): Call other_buffer_safely instead of
5616 * window.c (temp_output_buffer_show): Call display_buffer with
5617 second argument Vtemp_buffer_show_specifiers and reset latter
5618 immediately after the call.
5619 (Vtemp_buffer_show_specifiers): New variable.
5620 (auto_window_vscroll_p, next_screen_context_lines)
5621 (Vscroll_preserve_screen_position): Remove leading asterisks from
5624 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5626 Fix minor problems found by GCC 4.6.0 static checking.
5627 * buffer.c (Qclone_number): Remove for now, as it's unused.
5628 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5629 (record_buffer): Remove unused local.
5630 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5631 (set_frame_buffer_list): Remove; unused.
5632 * frame.h (other_visible_frames): Remove decl.
5633 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5634 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5635 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5637 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5638 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5639 Define only if HAVE_GPM.
5640 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5641 (update_hints_inhibit): Remove; never set. All uses removed.
5642 * widgetprv.h (emacsFrameClassRec): Remove decl.
5643 * window.c (delete_deletable_window): Now returns void, since it
5644 wasn't returning anything.
5645 (compare_window_configurations): Remove unused locals.
5646 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5647 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5648 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5649 the same widths as pointers. This follows up on the 2011-05-06 patch.
5650 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5651 * xterm.h: Likewise.
5652 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5654 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5656 * makefile.w32-in: Update dependencies.
5657 (LISP_H): Add lib/intprops.h.
5659 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5661 * image.c (gif_load): Add animation frame delay to the metadata.
5662 (syms_of_image): Use DEFSYM. New symbol `delay'.
5664 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5666 * window.c (delete_deletable_window): Re-add.
5667 (Fset_window_configuration): Rewrite to handle dead buffers and
5668 consequently deletable windows.
5669 (window_tree, Fwindow_tree): Remove. Supply functionality in
5671 (compare_window_configurations): Simplify code.
5673 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5675 * image.c (imagemagick_load_image): Fix type mismatch.
5676 (Fimagemagick_types): Likewise.
5678 * window.h (replace_buffer_in_windows): Declare.
5680 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5682 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5683 Qclone_number. Remove external declaration of Qdelete_window.
5684 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5686 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5687 Run Qbuffer_list_update_hook if allowed.
5688 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5689 buffer list implementation.
5690 (other_buffer_safely): New function.
5691 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5692 calls to replace_buffer_in_windows and
5693 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5695 (record_buffer): Inhibit quitting and rewrite using quittable
5696 functions. Run Qbuffer_list_update_hook if allowed.
5697 (Frecord_buffer, Funrecord_buffer): New functions.
5698 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5699 Move switch-to-buffer to window.el.
5700 (bury-buffer): Move to window.el.
5701 (Vbuffer_list_update_hook): New variable.
5703 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5706 * window.h (resize_frame_windows): Move up in code.
5707 (Fwindow_frame): Remove EXFUN.
5708 (replace_buffer_in_all_windows): Remove prototype.
5709 (replace_buffer_in_windows_safely): Add prototype.
5711 * window.c: Declare Qdelete_window static again. Move down
5712 declaration of select_count.
5713 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5714 (Fother_window): Move to window.el.
5715 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5716 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5717 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5719 (replace_buffer_in_windows): Implement by calling
5720 Qreplace_buffer_in_windows.
5721 (replace_buffer_in_all_windows): Remove with some functionality
5722 moved into replace_buffer_in_windows_safely.
5723 (replace_buffer_in_windows_safely): New function.
5724 (select_window_norecord, select_frame_norecord): Move in front
5725 of run_window_configuration_change_hook. Remove now obsolete
5727 (Fset_window_buffer): Rewrite doc-string.
5728 Call Qrecord_window_buffer.
5729 (keys_of_window): Move binding for other-window to window.el.
5731 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5733 * dispextern.h (struct image): Replace data member, whose int_val
5734 and ptr_val fields were not used by anything, with a single
5737 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5738 (gif_clear_image, gif_load, imagemagick_load_image)
5739 (gs_clear_image, gs_load): Callers changed.
5741 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5743 * buffer.h: Include <time.h>, for time_t.
5744 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5746 Fix minor problems found by static checking.
5748 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5750 Make identifiers static if they are not used in other modules.
5751 * data.c (Qcompiled_function, Qframe, Qvector):
5752 * image.c (QimageMagick, Qsvg):
5753 * minibuf.c (Qmetadata):
5754 * window.c (resize_window_check, resize_root_window): Now static.
5755 * window.h (resize_window_check, resize_root_window): Remove decls.
5757 * window.c (window_deletion_count, delete_deletable_window):
5759 (window_body_lines): Now static.
5760 (Fdelete_other_windows_internal): Mark vars as initialized.
5761 Make sure 'resize_failed' is initialized.
5762 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5763 (resize_window_apply): Remove unused local.
5764 * window.h (delete_deletable_window): Remove decl.
5766 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5767 (imagemagick_load_image): Fix pointer signedness problem by changing
5768 last arg from unsigned char * to char *. All uses changed.
5769 Also, fix a local for similar reasons.
5770 Remove unused locals. Remove locals to avoid shadowing.
5771 (fn_rsvg_handle_free): Remove; unused.
5772 (svg_load, svg_load_image): Fix pointer signedness problem.
5773 (imagemagick_load_image): Don't use garbage pointer image_wand.
5775 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5777 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5779 * image.c (gif_load): Fix omitted cast error introduced by
5782 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5784 * window.h (resize_proportionally, orig_total_lines)
5785 (orig_top_line): Remove from window structure.
5786 (set_window_height, set_window_width, change_window_heights)
5787 (Fdelete_window): Remove prototypes.
5788 (resize_frame_windows): Remove duplicate declaration.
5790 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5792 * window.h (resize_frame_windows, resize_window_check)
5793 (delete_deletable_window, resize_root_window)
5794 (resize_frame_windows): Declare prototypes.
5796 * window.c (resize_window_apply): Make definition be "static" to
5797 match the prototype.
5799 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5801 * window.c: Remove declarations of Qwindow_size_fixed,
5802 window_min_size_1, window_min_size_2, window_min_size,
5803 size_window, window_fixed_size_p, enlarge_window, delete_window.
5804 Remove static from declaration of Qdelete_window, it's
5805 temporarily needed by Fbury_buffer.
5806 (replace_window): Don't assign orig_top_line and
5808 (Fdelete_window, delete_window): Remove. Window deletion is
5809 handled by window.el.
5810 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5811 Replace Fdelete_window calls with calls to Qdelete_window.
5812 (Fdelete_other_windows): Remove. Deleting other windows is
5813 handled by window.el.
5814 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5815 handled in window.el.
5816 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5817 Window minimum sizes are handled in window.el.
5818 (shrink_windows, size_window, set_window_height)
5819 (set_window_width, change_window_heights, window_height)
5820 (window_width, CURBEG, CURSIZE, enlarge_window)
5821 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5822 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5823 handled in window.el.
5824 (make_dummy_parent): Rename to make_parent_window and give it a
5825 second argument horflag.
5826 (make_window): Don't set resize_proportionally any more.
5827 (Fsplit_window): Remove. Windows are split in window.el.
5828 (save_restore_action, save_restore_orig_size)
5829 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5830 Resize mini windows in window.el.
5831 (grow_mini_window, shrink_mini_window): Implement by calling
5832 Qresize_root_window_vertically, resize_window_check and
5833 resize_window_apply.
5834 (saved_window, Fset_window_configuration, save_window_save):
5835 Do not handle orig_top_line, orig_total_lines, and
5836 resize_proportionally.
5837 (window_min_height, window_min_width): Move to window.el.
5838 (keys_of_window): Move bindings for delete-other-windows,
5839 split-window, delete-window and enlarge-window to window.el.
5841 * buffer.c: Temporarily extern Qdelete_window.
5842 (Fbury_buffer): Temporarily call Qdelete_window instead of
5843 Fdelete_window (Fbury_buffer will move to window.el soon).
5845 * frame.c (set_menu_bar_lines_1): Remove code handling
5846 orig_top_line and orig_total_lines.
5848 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5849 set_window_height but set heights directly.
5850 (change_frame_size_1): Use resize_frame_windows.
5852 * xdisp.c (init_xdisp): Don't use set_window_height but set
5855 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5856 Use resize_frame_windows instead of change_window_heights and run
5857 run_window_configuration_change_hook.
5859 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5860 instead of change_window_heights and run
5861 run_window_configuration_change_hook.
5863 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5865 * window.c (replace_window): Rename second argument REPLACEMENT to
5866 NEW. New third argument SETFLAG. Rewrite.
5867 (delete_window, make_dummy_parent): Call replace_window with
5869 (window_list_1): Move down in code.
5870 (run_window_configuration_change_hook): Move set_buffer part
5871 before select_frame_norecord part in order to unwind correctly.
5872 Rename count1 to count.
5873 (recombine_windows, delete_deletable_window, resize_root_window)
5874 (Fdelete_other_windows_internal)
5875 (Frun_window_configuration_change_hook, make_parent_window)
5876 (resize_window_check, resize_window_apply, Fresize_window_apply)
5877 (resize_frame_windows, Fsplit_window_internal)
5878 (Fdelete_window_internal, Fresize_mini_window_internal):
5880 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5882 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5884 * window.h (window): Add some new members to window structure -
5885 normal_lines, normal_cols, new_total, new_normal, clone_number,
5886 splits, nest, prev_buffers, next_buffers.
5887 (WINDOW_TOTAL_SIZE): Move here from window.c.
5888 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5890 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5892 (make_dummy_parent): Set new members of windows structure.
5893 (make_window): Move down in code. Handle new members of window
5895 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5896 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5897 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5898 (Fset_window_prev_buffers, Fwindow_next_buffers)
5899 (Fset_window_next_buffers, Fset_window_clone_number):
5901 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5902 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5904 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5905 Argument WINDOW can be now internal window too.
5906 (Fwindow_use_time): Move up in code.
5907 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5909 (Fset_window_configuration, saved_window)
5910 (Fcurrent_window_configuration, save_window_save): Handle new
5911 members of window structure.
5912 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5913 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5914 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5915 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5916 Qget_mru_window, Qresize_root_window,
5917 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5918 Qauto_buffer_name; staticpro them.
5920 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5922 * window.c (Fwindow_total_size, Fwindow_left_column)
5923 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5924 (Fwindow_list_1): New functions.
5925 (window_box_text_cols): Replace with window_body_cols.
5926 (Fwindow_width, Fscroll_left, Fscroll_right):
5927 Use window_body_cols instead of window_box_text_cols.
5928 (delete_window, Fset_window_configuration):
5929 Call delete_all_subwindows with window as argument.
5930 (delete_all_subwindows): Take a window as argument and not a
5932 (window_loop): Remove handling of GET_LRU_WINDOW and
5934 (Fget_lru_window, Fget_largest_window): Move to window.el.
5936 * window.h: Extern window_body_cols instead of
5937 window_box_text_cols. delete_all_subwindows now takes a
5938 Lisp_Object as argument.
5940 * indent.c (compute_motion, Fcompute_motion):
5941 Use window_body_cols instead of window_box_text_cols.
5943 * frame.c (delete_frame): Call delete_all_subwindows with root
5946 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5948 * fns.c (Fputhash): Document return value.
5950 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5952 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5954 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5956 Cons<->int and similar integer overflow fixes (Bug#8794).
5958 Check for overflow when converting integer to cons and back.
5959 * charset.c (Fdefine_charset_internal, Fdecode_char):
5960 Use cons_to_unsigned to catch overflow.
5961 (Fencode_char): Use INTEGER_TO_CONS.
5962 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5963 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5964 * data.c (long_to_cons, cons_to_long): Remove.
5965 (cons_to_unsigned, cons_to_signed): New functions.
5966 These signal an error for invalid or out-of-range values.
5967 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5968 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5969 * font.c (Ffont_variation_glyphs):
5970 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5971 * lisp.h: Include <intprops.h>.
5972 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5973 (cons_to_signed, cons_to_unsigned): New decls.
5974 (long_to_cons, cons_to_long): Remove decls.
5975 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5976 (Fprimitive_undo): Use CONS_TO_INTEGER.
5977 * xfns.c (Fx_window_property): Likewise.
5978 * xselect.c: Include <limits.h>.
5979 (x_own_selection, selection_data_to_lisp_data):
5980 Use INTEGER_TO_CONS.
5981 (x_handle_selection_request, x_handle_selection_clear)
5982 (x_get_foreign_selection, Fx_disown_selection_internal)
5983 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5984 (lisp_data_to_selection_data): Use cons_to_unsigned.
5985 (x_fill_property_data): Use cons_to_signed.
5986 Report values out of range.
5988 Check for buffer and string overflow more precisely.
5989 * buffer.h (BUF_BYTES_MAX): New macro.
5990 * lisp.h (STRING_BYTES_MAX): New macro.
5991 * alloc.c (Fmake_string):
5992 * character.c (string_escape_byte8):
5993 * coding.c (coding_alloc_by_realloc):
5994 * doprnt.c (doprnt):
5995 * editfns.c (Fformat):
5997 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5998 since they may not be the same number.
5999 * editfns.c (Finsert_char):
6000 * fileio.c (Finsert_file_contents):
6001 Likewise for BUF_BYTES_MAX.
6003 * image.c: Use ptrdiff_t, not int, for sizes.
6004 (slurp_file): Switch from int to ptrdiff_t.
6006 (slurp_file): Check that file size fits in both size_t (for
6007 malloc) and ptrdiff_t (for sanity and safety).
6009 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6010 if b->modtime has its maximal value.
6012 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6014 Don't assume time_t can fit into int.
6015 * buffer.h (struct buffer.modtime): Now time_t, not int.
6016 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6017 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6019 Minor fixes for signed vs unsigned integers.
6020 * character.h (MAYBE_UNIFY_CHAR):
6021 * charset.c (maybe_unify_char):
6022 * keyboard.c (read_char, reorder_modifiers):
6023 XINT -> XFASTINT, since the integer must be nonnegative.
6024 * ftfont.c (ftfont_spec_pattern):
6025 * keymap.c (access_keymap, silly_event_symbol_error):
6026 XUINT -> XFASTINT, since the integer must be nonnegative.
6027 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6028 since it makes no difference and we prefer signed.
6029 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6030 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6033 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6035 * window.h (Fwindow_frame): Declare.
6037 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6039 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6040 (SPARE_MEMORY): Always define.
6041 (LARGE_REQUEST): Remove.
6042 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6044 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6046 * lisp.h: Move EXFUNS for Fframe_root_window,
6047 Fframe_first_window and Fset_frame_selected_window to window.h.
6049 * window.h: Move EXFUNS for Fframe_root_window,
6050 Fframe_first_window and Fset_frame_selected_window here from
6053 * frame.c (Fwindow_frame, Fframe_first_window)
6054 (Fframe_root_window, Fframe_selected_window)
6055 (Fset_frame_selected_window): Move to window.c.
6056 (Factive_minibuffer_window): Move to minibuf.c.
6057 (Fother_visible_frames_p): New function.
6059 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6061 * window.c (decode_window, decode_any_window): Move up in code.
6062 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6063 (inhibit_frame_unsplittable): Remove unused variable.
6064 (Fwindow_buffer): Move up and rewrite doc-string.
6065 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6066 (Fwindow_prev): New functions.
6067 (Fwindow_frame): Move here from frame.c. Accept any window as
6069 (Fframe_root_window, Fframe_first_window)
6070 (Fframe_selected_window): Move here from frame.c. Accept frame
6071 or arbitrary window as argument. Update doc-strings.
6072 (Fminibuffer_window): Move up in code.
6073 (Fwindow_minibuffer_p): Move up in code and simplify.
6074 (Fset_frame_selected_window): Move here from frame.c.
6076 (Fselected_window, select_window, Fselect_window): Move up in
6077 code. Minor doc-string fixes.
6079 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6081 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6082 Do not assume that spare memory exists; that assumption is valid
6083 only if SYSTEM_MALLOC.
6084 (LARGE_REQUEST): New macro, so that the issue of large requests
6085 is separated from the issue of spare memory.
6087 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6089 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6092 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6094 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6097 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6099 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6101 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6103 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6104 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6106 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6108 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6110 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6112 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6113 (x_clipboard_manager_save): Add return value.
6114 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6116 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6117 Obey Vx_select_enable_clipboard_manager. Catch errors in
6118 x_clipboard_manager_save (Bug#8779).
6119 (Vx_select_enable_clipboard_manager): New variable.
6120 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6122 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6124 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6126 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6128 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6129 in the current matrix if keep_current_p is non-zero.
6131 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6133 * bidi.c (bidi_level_of_next_char): Fix last change.
6135 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6137 Support bidi reordering of text covered by display properties.
6139 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6140 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6141 (bidi_cache_search, bidi_cache_iterator_state)
6142 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6143 (bidi_level_of_next_char, bidi_move_to_visually_next):
6144 Support character positions inside a run of characters covered by a
6146 (bidi_paragraph_init, bidi_resolve_explicit_1)
6147 (bidi_level_of_next_char): Call bidi_fetch_char and
6148 bidi_fetch_char_advance instead of FETCH_CHAR and
6150 (bidi_init_it): Initialize new members.
6151 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6153 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6154 instead of using explicit *_CHAR codes.
6155 (bidi_resolve_explicit, bidi_resolve_weak):
6156 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6157 bidirectional text is supported only in multibyte buffers.
6158 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6159 it to initialize the frame_window_p member of struct bidi_it.
6160 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6161 (bidi_resolve_explicit, bidi_resolve_weak)
6162 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6163 bidi_it->nchars is non-positive.
6164 (bidi_level_of_next_char): Don't try to lookup the cache for the
6165 next/previous character if nothing is cached there yet, or if we
6166 were just reseat()'ed to a new position.
6168 * xdisp.c (set_cursor_from_row): Set start and stop points
6169 according to the row's direction when priming the loop that looks
6170 for the glyph on which to display cursor.
6171 (single_display_spec_intangible_p): Function deleted.
6172 (display_prop_intangible_p): Reimplement to call
6173 handle_display_spec instead of single_display_spec_intangible_p.
6174 Accept 3 additional arguments needed by handle_display_spec.
6175 This fixes incorrect cursor motion across display property with complex
6176 values: lists, `(when COND...)' forms, etc.
6177 (single_display_spec_string_p): Support property values that are
6178 lists with the argument STRING its top-level element.
6179 (display_prop_string_p): Fix the condition for processing a
6180 property that is a list to be consistent with handle_display_spec.
6181 (handle_display_spec): New function, refactored from the
6182 last portion of handle_display_prop.
6183 (compute_display_string_pos): Accept additional argument
6184 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6185 value of a `display' property is a "replacing spec".
6186 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6187 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6188 the display property, but just return a value indicating whether
6189 the display property will replace the characters it covers.
6190 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6191 frame_window_p members of struct bidi_it.
6192 (compute_display_string_pos, compute_display_string_end):
6194 (push_it): Accept second argument POSITION, where pop_it should
6195 jump to continue iteration.
6196 (reseat_1): Initialize bidi_it.disp_pos.
6198 * keyboard.c (adjust_point_for_property): Adjust the call to
6199 display_prop_intangible_p to its new signature.
6201 * dispextern.h (struct bidi_it): New member frame_window_p.
6202 (bidi_init_it): Update prototypes.
6203 (display_prop_intangible_p): Update prototype.
6204 (compute_display_string_pos, compute_display_string_end):
6206 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6209 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6211 Malloc failure behavior now depends on size of allocation.
6212 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6213 * lisp.h: Change signatures accordingly.
6214 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6215 All callers changed. (Bug#8762)
6217 * gnutls.c: Use Emacs's memory allocators.
6218 Without this change, the gnutls library would invoke malloc etc.
6219 directly, which causes problems on non-SYNC_INPUT hosts, and which
6220 runs afoul of improving memory_full behavior. (Bug#8761)
6221 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6222 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6223 xfree instead of the default malloc, realloc, free.
6224 (Fgnutls_boot): No need to check for memory allocation failure,
6225 since xmalloc does that for us.
6227 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6228 * category.c (hash_get_category_set):
6229 * ccl.c (ccl_driver):
6230 * charset.c (Fdefine_charset_internal):
6231 * charset.h (struct charset.hash_index):
6232 * composite.c (get_composition_id, gstring_lookup_cache)
6233 (composition_gstring_put_cache):
6234 * composite.h (struct composition.hash_index):
6235 * dispextern.h (struct image.hash):
6236 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6237 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6238 (hashfn_equal, hashfn_user_defined, make_hash_table)
6239 (maybe_resize_hash_table, hash_lookup, hash_put)
6240 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6241 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6242 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6243 * image.c (make_image, search_image_cache, lookup_image)
6244 (xpm_put_color_table_h):
6245 * lisp.h (struct Lisp_Hash_Table):
6246 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6247 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6248 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6249 * alloc.c (allocate_vectorlike):
6250 Check for overflow in vector size calculations.
6251 * ccl.c (ccl_driver):
6252 Check for overflow when converting EMACS_INT to int.
6253 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6254 need to be updated by these changes.
6255 * fns.c (make_hash_table, maybe_resize_hash_table):
6256 Check for integer overflow with large hash tables.
6257 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6258 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6259 (SXHASH_REDUCE): New macro.
6260 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6261 Use it instead of discarding useful hash info with large hash values.
6262 (sxhash_float): New function.
6263 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6264 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6265 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6266 Rewrite to use FIXNUM_BITS, as this simplifies things.
6267 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6268 Adjust signatures to match updated version of code.
6269 (consing_since_gc): Now EMACS_INT, since a single hash table can
6270 use more than INT_MAX bytes.
6272 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6274 Make it possible to build with GCC-4.6+ -O2 -flto.
6276 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6278 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6280 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6281 Call minibuffer-inactive-mode.
6283 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6285 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6286 Update dependencies.
6288 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6290 * data.c (init_data): Remove code for UTS, this system is not
6293 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6295 Don't force ./temacs to start in terminal mode.
6297 * frame.c (make_initial_frame): Initialize faces in all cases, not
6298 only when CANNOT_DUMP is defined.
6299 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6301 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6303 * dispnew.c (add_window_display_history): Use const for the string
6304 pointer. Remove declaration, not needed.
6306 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6308 Use 'inline', not 'INLINE'.
6309 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6310 * alloc.c, fontset.c (INLINE): Remove.
6311 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6312 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6313 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6314 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6315 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6317 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6319 Make it possible to run ./temacs.
6321 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6322 syms_of_callproc does the same thing. Remove test for
6323 "initialized", do it in the caller.
6324 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6326 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6328 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6329 (read_minibuf): Use get_minibuffer.
6330 (syms_of_minibuf): Use DEFSYM.
6331 (Qmetadata): New var.
6332 * data.c (Qbuffer): Don't make it static.
6333 (syms_of_data): Use DEFSYM.
6335 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6337 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6338 (CCL_CODE_MIN): New macro.
6340 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6342 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6344 * eval.c (Qdebug): Now static.
6345 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6346 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6347 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6349 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6351 * image.c: Various fixes to ImageMagick code comments.
6352 (Fimagemagick_types): Doc fix.
6354 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6356 Minor fixes prompted by GCC 4.6.0 warnings.
6358 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6360 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6361 (x_clipboard_manager_save_all): Move extern decl to ...
6362 * xterm.h: ... here, so that it can be checked for consistency.
6364 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6366 * xselect.c (x_clipboard_manager_save_frame)
6367 (x_clipboard_manager_save_all): New functions.
6368 (Fx_clipboard_manager_save): Lisp function deleted.
6370 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6371 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6373 * xterm.h: Update prototype.
6375 2011-05-28 William Xu <william.xwl@gmail.com>
6377 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6380 2011-05-28 Jim Meyering <meyering@redhat.com>
6382 Avoid a sign-extension bug in crypto_hash_function.
6383 * fns.c (to_uchar): Define.
6384 (crypto_hash_function): Use it to convert some newly-signed
6385 variables to unsigned, to avoid sign-extension bugs. For example,
6386 without this change, (md5 "truc") would evaluate to
6387 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6388 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6389 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6391 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6393 Integer overflow fixes.
6395 * dbusbind.c: Serial number integer overflow fixes.
6396 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6397 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6398 to hold a serial number that is too large for a fixnum.
6399 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6400 Check for serial numbers out of range. Decode any serial number
6401 that was so large that it became a float. (Bug#8722)
6403 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6404 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6405 Use XFASTINT rather than XUINT when numbers are nonnegative.
6406 (xd_append_arg, Fdbus_method_return_internal):
6407 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6408 arguments, check that Lisp number is nonnegative, rather than
6409 silently wrapping negative numbers around. (Bug#8722)
6410 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6413 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6415 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6417 ccl: Add integer overflow checks.
6418 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6419 (IN_INT_RANGE): New macros.
6420 (ccl_driver): Use them to check for integer overflow when
6421 decoding a CCL program. Many of the new checks are whether XINT (x)
6422 fits in int; it doesn't always, on 64-bit hosts. The new version
6423 doesn't catch all possible integer overflows, but it's an
6424 improvement. (Bug#8719)
6426 * alloc.c (make_event_array): Use XINT, not XUINT.
6427 There's no need for unsigned here.
6429 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6430 This follows up to the 2011-05-06 change that substituted uintptr_t
6431 for EMACS_INT. This case wasn't caught back then.
6433 Rework Fformat to avoid integer overflow issues.
6434 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6435 now (part of C89). Include <verify.h>.
6436 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6437 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6438 (Fformat): Avoid the prepass trying to compute sizes; it was only
6439 approximate and thus did not catch overflow reliably. Instead, walk
6440 through the format just once, formatting and computing sizes as we go,
6441 checking for integer overflow at every step, and allocating a larger
6442 buffer as needed. Keep track separately whether the format is
6443 multibyte. Keep only the most-recently calculated precision, rather
6444 than them all. Record whether each argument has been converted to
6445 string. Use EMACS_INT, not int, for byte and char and arg counts.
6446 Support field widths and precisions larger than INT_MAX. Avoid
6447 sprintf's undefined behavior with conversion specifications such as %#d
6448 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6449 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6450 formatting out-of-range floating point numbers with int
6453 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6455 * data.c: Avoid integer truncation in expressions involving floats.
6456 * data.c: Include <intprops.h>.
6457 (arith_driver): When there's an integer overflow in an expression
6458 involving floating point, convert the integers to floating point
6459 so that the resulting value does not suffer from catastrophic
6460 integer truncation. For example, on a 64-bit host (* 4
6461 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6462 Do not rely on undefined behavior after integer overflow.
6464 merge count_size_as_multibyte, parse_str_to_multibyte
6465 * character.c, character.h (count_size_as_multibyte):
6466 Rename from parse_str_to_multibyte; all uses changed.
6467 Check for integer overflow.
6468 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6469 since it's now a duplicate of the other. This is more of
6470 a character than a buffer op, so better that it's in character.c.
6471 * fns.c, print.c: Adjust to above changes.
6473 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6475 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6477 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6479 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6480 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6481 (x_clipboard_manager_save): Now static.
6482 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6484 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6485 (crypto_hash_function): Now static.
6486 Fix pointer signedness problems. Avoid unnecessary initializations.
6488 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6490 * termhooks.h (Vselection_alist): Make it terminal-local.
6492 * terminal.c (create_terminal): Initialize it.
6494 * xselect.c: Support for clipboard managers.
6495 (Vselection_alist): Move to termhooks.h as terminal-local var.
6496 (LOCAL_SELECTION): New macro.
6497 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6498 (symbol_to_x_atom): Remove gratuitous arg.
6499 (x_handle_selection_request, lisp_data_to_selection_data)
6500 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6501 (x_own_selection, x_get_local_selection, x_convert_selection):
6502 New arg, specifying work frame. Use terminal-local Vselection_alist.
6503 (some_frame_on_display): Delete unused function.
6504 (Fx_own_selection_internal, Fx_get_selection_internal)
6505 (Fx_disown_selection_internal, Fx_selection_owner_p)
6506 (Fx_selection_exists_p): New optional frame arg.
6507 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6508 (x_handle_selection_clear): Don't treat other terminals with the
6509 same keyboard specially. Use the terminal-local Vselection_alist.
6510 (x_clear_frame_selections): Use Frun_hook_with_args.
6512 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6514 * xterm.h: Add support for those atoms.
6516 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6518 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6519 (converted_selections, conversion_fail_tag): New global variables.
6520 (x_selection_request_lisp_error): Free the above.
6521 (x_get_local_selection): Remove unnecessary code.
6522 (x_reply_selection_request): Args changed; handle arbitrary array
6523 of converted selections stored in converted_selections.
6524 Separate the XChangeProperty and SelectionNotify steps.
6525 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6526 (x_convert_selection): New function.
6527 (x_handle_selection_event): Simplify.
6528 (x_get_foreign_selection): Don't ignore incoming requests while
6529 waiting for an answer; this will fail when we implement
6530 SAVE_TARGETS, and seems unnecessary anyway.
6531 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6532 (Vx_sent_selection_functions): Doc fix.
6534 2011-05-26 Leo Liu <sdl.web@gmail.com>
6536 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6538 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6540 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6542 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6543 for fringe update if it has periodic bitmap.
6544 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6545 and fringe_bitmap_periodic_p.
6547 * fringe.c (get_fringe_bitmap_data): New function.
6548 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6549 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6550 row. Mark glyph row for fringe update if periodicity changed.
6552 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6553 for fringe update unless it has periodic bitmap.
6555 2011-05-25 Kenichi Handa <handa@m17n.org>
6557 * xdisp.c (get_next_display_element): Set correct it->face_id for
6558 a static composition.
6560 2011-05-24 Leo Liu <sdl.web@gmail.com>
6563 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6565 * fns.c (crypto_hash_function, Fsha1): New function.
6566 (Fmd5): Use crypto_hash_function.
6567 (syms_of_fns): Add Ssha1.
6569 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6571 * gnutls.c: Remove unused macros.
6572 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6573 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6574 Remove macros that are defined and never used.
6575 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6577 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6579 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6580 (Fx_get_selection_internal): Minor cleanup.
6581 (Fx_own_selection_internal): Rename arguments for consistency with
6584 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6586 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6588 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6590 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6592 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6594 * dispnew.c (scrolling_window): Don't exclude the case that the
6595 last enabled row in the desired matrix touches the bottom boundary.
6597 2011-05-21 Glenn Morris <rgm@gnu.org>
6599 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6600 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6601 and add some more files.
6603 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6605 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6606 report_file_error introduced by the change from 2011-05-07.
6608 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6610 * systime.h (Time): Define only if emacs is defined.
6611 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6612 where the include path doesn't have X11/X.h by default. See
6613 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6615 2011-05-20 Kenichi Handa <handa@m17n.org>
6617 * composite.c (find_automatic_composition): Fix previous change.
6619 2011-05-20 Glenn Morris <rgm@gnu.org>
6621 * lisp.mk: New file, split from Makefile.in.
6622 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6623 (shortlisp): Remove.
6624 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6626 2011-05-19 Glenn Morris <rgm@gnu.org>
6628 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6629 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6630 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6631 (lisp): Set the order to that of loadup.el.
6632 (shortlisp): Make it a copy of $lisp.
6633 (SOME_MACHINE_LISP): Remove.
6634 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6635 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6637 2011-05-18 Kenichi Handa <handa@m17n.org>
6639 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6640 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6641 (find_automatic_composition): Mostly rewrite for efficiency.
6643 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6645 * makefile.w32-in: Update dependencies.
6647 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6649 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6650 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6652 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6654 Fix some integer overflow issues, such as string length overflow.
6656 * insdel.c (count_size_as_multibyte): Check for string overflow.
6658 * character.c (lisp_string_width): Check for string overflow.
6659 Use EMACS_INT, not int, for string indexes and lengths; in
6660 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6661 the resulting string length overflows an EMACS_INT; instead,
6662 report a string overflow if no precision given. When checking for
6663 precision exhaustion, use a check that cannot possibly have
6664 integer overflow. (Bug#8675)
6665 * character.h (lisp_string_width): Adjust to new signature.
6667 * alloc.c (string_overflow): New function.
6668 (Fmake_string): Use it. This doesn't change behavior, but saves
6669 a few bytes and will simplify future changes.
6670 * character.c (string_escape_byte8): Likewise.
6671 * lisp.h (string_overflow): New decl.
6673 Fixups, following up to the user-interface timestamp change.
6674 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6675 for UI timestamps, instead of unsigned long.
6676 * msdos.c (mouse_get_pos): Likewise.
6677 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6678 * w32gui.h (Time): Define by including "systime.h" rather than by
6679 declaring it ourselves. (Bug#8664)
6681 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6682 * image.c (clear_image_cache): Likewise.
6684 * term.c (term_mouse_position): Don't assume time_t wraparound.
6686 Be more systematic about user-interface timestamps.
6687 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6688 and sometimes 'EMACS_UINT', to represent these timestamps.
6689 This change causes it to use 'Time' uniformly, as that's what X uses.
6690 This makes the code easier to follow, and makes it easier to catch
6691 integer overflow bugs such as Bug#8664.
6692 * frame.c (Fmouse_position, Fmouse_pixel_position):
6693 Use Time, not unsigned long, for user-interface timestamps.
6694 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6695 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6696 * keyboard.h (last_event_timestamp): Likewise.
6697 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6698 * menu.h (xmenu_show): Likewise.
6699 * term.c (term_mouse_position): Likewise.
6700 * termhooks.h (struct input_event.timestamp): Likewise.
6701 (struct terminal.mouse_position_hook): Likewise.
6702 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6703 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6704 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6705 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6707 * menu.h, termhooks.h: Include "systime.h", for Time.
6709 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6710 Don't assume that the difference between two unsigned long values
6711 can fit into an integer. At this point, we know button_down_time
6712 <= event->timestamp, so the difference must be nonnegative, so
6713 there's no need to cast the result if double-click-time is
6714 nonnegative, as it should be; check that it's nonnegative, just in
6715 case. This bug is triggered when events are more than 2**31 ms
6716 apart (about 25 days). (Bug#8664)
6718 * xselect.c (last_event_timestamp): Remove duplicate decl.
6719 (x_own_selection): Remove needless cast to unsigned long.
6721 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6722 that always fit in int. Use a sentinel instead of a counter, to
6723 avoid a temp and to allay GCC's concerns about possible int overflow.
6724 * frame.h (struct frame): Use int for menu_bar_items_used
6725 instead of EMACS_INT, since it always fits in int.
6727 * menu.c (grow_menu_items): Check for int overflow.
6729 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6731 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6732 Before, the code was not consistent. These values cannot exceed
6733 2**31 - 1 so there's no need to make them unsigned.
6734 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6735 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6736 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6738 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6740 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6741 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6742 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6743 presumably because the widths might not match.
6745 * window.c (size_window): Avoid needless test at loop start.
6747 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6749 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6751 2011-05-12 Drew Adams <drew.adams@oracle.com>
6753 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6755 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6757 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6758 `width' to `bar_area_x' and `bar_area_width', respectively.
6759 (x_scroll_run): Take account of fringe background extension.
6761 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6762 Rename local vars `left' and `width' to `bar_area_x' and
6763 `bar_area_width', respectively.
6764 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6765 background extension.
6767 2011-05-10 Jim Meyering <meyering@redhat.com>
6769 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6771 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6773 * image.c (Finit_image_library): Return t for built-in image types,
6774 like pbm and xbm. (Bug#8640)
6776 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6778 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6780 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6782 * w32console.c (Fset_screen_color): Doc fix.
6783 (Fget_screen_color): New function.
6784 (syms_of_ntterm): Defsubr it.
6786 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6787 unlink the temporary file if Fcall_process didn't create it in the
6789 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6790 child process will be redirected to a file specified with `:file'.
6791 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6792 cue to call_process_cleanup not to close that handle.
6794 2011-05-07 Ben Key <bkey76@gmail.com>
6796 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6797 one of two shell specific rules, either bootstrap-temacs-CMD or
6798 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6799 to the previous implementation of the bootstrap-temacs rule.
6800 The bootstrap-temacs-CMD rule is similar to the previous
6801 implementation of the bootstrap-temacs rule except that it
6802 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6805 These changes, along with some changes to nt/configure.bat,
6806 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6807 earlier fix to add support for --cflags and --ldflags options
6808 that include quotes so that it works whether make uses cmd or
6811 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6813 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6814 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6816 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6817 a string. Handle both cases.
6818 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6819 (Fdbus_register_method): Use Qinvalid_function.
6821 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6823 * makefile.w32-in: Update dependencies.
6824 (LISP_H): Add inttypes.h and stdin.h.
6825 (PROCESS_H): Add unistd.h.
6827 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6829 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6830 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6832 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6834 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6836 * term.c (vfatal): Remove stray call to va_end.
6837 It's not needed and the C Standard doesn't allow it here anyway.
6839 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6840 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6842 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6845 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6847 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6849 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6851 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6853 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6855 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6856 * charset.c (Fdefine_charset_internal): Don't initialize
6857 charset.code_space[15]. The value was garbage, on hosts with
6858 32-bit int (Bug#8600).
6860 * lread.c (read_integer): Be more consistent with string-to-number.
6861 Use string_to_number to do the actual conversion; this avoids
6862 rounding errors and fixes some other screwups. Without this fix,
6863 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6864 (digit_to_number): Move earlier, for benefit of read_integer.
6865 Return -1 if the digit is out of range for the base, -2 if it is
6866 not a digit in any supported base. (Bug#8602)
6868 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6870 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6871 to match comment at start of function. This also removes a
6872 GCC warning about overflow in a 32+64-bit port.
6874 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6876 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6877 Reported by Stefan Monnier in
6878 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6879 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6880 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6882 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6883 (EMACS_UINTPTR): Likewise, with uintptr_t.
6885 * lisp.h: Prefer 64-bit EMACS_INT if available.
6886 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6887 on 32-bit hosts that have 64-bit int, so that they can access
6889 However, temporarily disable this change unless the temporary
6890 symbol WIDE_EMACS_INT is defined.
6892 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6894 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6895 This removes an assumption that EMACS_INT and long are the same
6896 width as pointers. The assumption is true for Emacs porting targets
6897 now, but we want to make other targets possible.
6898 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6899 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6900 In the rest of the code, change types of integers that hold casted
6901 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6902 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6903 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6904 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6905 No need to cast type when ORing.
6906 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6907 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6908 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6909 assume EMACS_INT is the same width as char *.
6910 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6911 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6912 Remove no-longer-needed casts.
6913 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6914 (xg_tool_bar_help_callback, xg_make_tool_item):
6915 Use EMACS_INTPTR to hold an integer
6916 that will be cast to void *; this can avoid a GCC warning
6917 if EMACS_INT is not the same width as void *.
6918 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6919 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6920 (current_message_1, set_message_1):
6921 Use a local to convert to proper width without a cast.
6922 * xmenu.c (dialog_selection_callback): Likewise.
6924 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6925 Also, don't assume VALBITS / RAND_BITS is less than 5,
6926 and don't rely on undefined behavior when shifting a 1 left into
6928 * lisp.h (get_random): Change signature to match.
6930 * lread.c (hash_string): Use size_t, not int, for hash computation.
6931 Normally we prefer signed values; but hashing is special, because
6932 it's better to use unsigned division on hash table sizes so that
6933 the remainder is nonnegative. Also, size_t is the natural width
6934 for hashing into memory. The previous code used 'int', which doesn't
6935 retain enough info to hash well into very large tables.
6936 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6938 * dbusbind.c: Don't possibly lose pointer info when converting.
6939 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6940 Use XPNTR rather than XHASH, so that the high-order bits of
6941 the pointer aren't lost when converting through void *.
6943 * eval.c (Fautoload): Don't double-shift a pointer.
6945 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6947 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6949 * gnutls.c (DEF_GNUTLS_FN):
6950 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6952 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6954 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6957 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6959 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6960 New version that can reserve upto 2GB of heap space.
6962 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6964 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6966 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6968 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6969 `gnutls_certificate_set_x509_key_file'.
6971 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6973 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6974 Update dependencies.
6976 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6978 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6979 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6980 Remove unused parameter `fildes'.
6981 * process.c (read_process_output, send_process): Don't pass it.
6983 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6985 Fix previous change: the library cache is defined in w32.c.
6986 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6987 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6989 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6991 Implement dynamic loading of GnuTLS on Windows.
6993 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6994 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6995 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6998 * gnutls.c (Qgnutls_dll): Define.
6999 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7000 (gnutls_*): Declare function pointers.
7001 (init_gnutls_functions): New function to initialize function pointers.
7002 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7003 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7004 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7005 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7006 (emacs_gnutls_write, emacs_gnutls_read)
7007 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7008 (Fgnutls_available_p): New function.
7009 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7010 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7011 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7013 * image.c: Include w32.h.
7014 (Vimage_type_cache): Delete.
7015 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7016 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7017 (w32_delayed_load): Move to w32.c.
7019 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7021 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7022 (w32_delayed_load): Move from image.c. When loading a library, record
7023 its filename in the :loaded-from property of the library id.
7024 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7025 Initialize and staticpro them.
7026 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7028 * process.c: Include lisp.h before w32.h, not after.
7029 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7030 instead of gnutls_record_check_pending.
7032 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7034 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7036 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7037 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7040 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7042 * xterm.c (x_set_frame_alpha): Do not set property on anything
7043 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7045 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7047 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7049 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7051 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7052 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7053 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7054 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7055 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7056 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7057 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7058 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7059 (Qgnutls_bootprop_callbacks_verify): Make static.
7061 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7063 * callproc.c: Indentation fixup.
7065 * sysdep.c (wait_for_termination_1): Make static.
7066 (wait_for_termination, interruptible_wait_for_termination):
7067 Move after wait_for_termination_1.
7069 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7071 * sysdep.c (interruptible_wait_for_termination): New function
7072 which is like wait_for_termination, but allows keyboard
7075 * callproc.c (Fcall_process): Add (:file "file") as an option for
7077 (Fcall_process_region): Ditto.
7079 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7081 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7082 rather than `XVECTOR (FOO)->size'.
7084 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7085 inttypes.h, as a gnulib replacement is used if it not available in
7088 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7090 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7091 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7092 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7094 * coding.c (coding_alloc_by_realloc): Error out if destination
7095 will grow beyond MOST_POSITIVE_FIXNUM.
7096 (decode_coding_emacs_mule): Abort if there isn't enough place in
7097 charbuf for the composition carryover bytes. Reserve an extra
7098 space for up to 2 characters produced in a loop.
7099 (decode_coding_iso_2022): Abort if there isn't enough place in
7100 charbuf for the composition carryover bytes.
7102 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7104 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7105 aborting when %lld or %lll format is passed.
7106 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7107 %llo or %llx format is passed. (Bug#8545)
7109 * window.c (window_scroll_line_based): Use a marker instead of
7110 simple variables to record original value of point. (Bug#7952)
7112 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7113 produced by %s or %c overflows available buffer space. (Bug#8545)
7115 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7117 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7118 (SIZE_MAX): Move defn after all includes, as they might #define it.
7120 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7122 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7124 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7126 * keyboard.c (Qdelayed_warnings_hook): Define.
7127 (command_loop_1): Run `delayed-warnings-hook'
7128 if Vdelayed_warnings_list is non-nil.
7129 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7130 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7132 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7134 * doprnt.c (doprnt): Don't return value smaller than the buffer
7135 size if the message was truncated. (Bug#8545).
7137 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7139 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7140 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7142 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7144 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7146 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7148 * makefile.w32-in: Update dependencies.
7150 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7152 Improve `doprnt' and its usage. (Bug#8545)
7153 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7154 `format_end'. Remove support for %l as a conversion specifier.
7155 Don't use xrealloc. Improve diagnostics when the %l size modifier
7156 is used. Update the commentary.
7158 * eval.c (verror): Simplify calculation of size_t.
7160 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7163 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7165 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7168 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7170 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7171 This makes this file independent of the recent pseudovector change.
7173 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7175 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7177 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7178 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7179 Remove unused local.
7180 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7182 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7183 GCC 4.6.0 optimizes based on type-based alias analysis.
7184 For example, if b is of type struct buffer * and v of type struct
7185 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7186 != &v->size, and therefore "v->size = 1; b->size = 2; return
7187 v->size;" must therefore return 1. This assumption is incorrect
7188 for Emacs, since it type-puns struct Lisp_Vector * with many other
7189 types. To fix this problem, this patch adds a new type struct
7190 vectorlike_header that documents the constraints on layout of vectors
7191 and pseudovectors, and helps optimizing compilers not get fooled
7192 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7193 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7194 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7196 (XSETPVECTYPE): Rewrite in terms of new macro.
7197 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7198 This is a bit clearer, and further avoids the possibility of
7199 undesirable aliasing.
7200 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7201 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7202 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7203 since Lisp_Subr is a special case (no "next" field).
7204 (ASIZE): Now uses header.size rather than size.
7205 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7206 to avoid the hassle of writing XVECTOR (foo)->header.size.
7207 (struct vectorlike_header): New type.
7208 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7209 object, to help avoid aliasing.
7210 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7211 (SUBRP): Likewise, since Lisp_Subr is a special case.
7212 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7213 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7214 (struct Lisp_Hash_Table): Combine first two members into a single
7215 struct vectorlike_header member. All uses of "size" and "next" members
7216 changed to be "header.size" and "header.next".
7217 * buffer.h (struct buffer): Likewise.
7218 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7219 * frame.h (struct frame): Likewise.
7220 * process.h (struct Lisp_Process): Likewise.
7221 * termhooks.h (struct terminal): Likewise.
7222 * window.c (struct save_window_data, struct saved_window): Likewise.
7223 * window.h (struct window): Likewise.
7224 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7225 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7226 * buffer.c (init_buffer_once): Likewise.
7227 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7229 * process.c (Fformat_network_address): Use local var for size,
7232 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7234 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7235 * data.c (atof): Remove decl; no longer used or needed.
7236 (digit_to_number): Move to lread.c.
7237 (Fstring_to_number): Use new string_to_number function, to be
7238 consistent with how the Lisp reader treats infinities and NaNs.
7239 Do not assume that floating-point numbers represent EMACS_INT
7240 without losing information; this is not true on most 64-bit hosts.
7241 Avoid double-rounding errors, by insisting on integers when
7242 parsing non-base-10 numbers, as the documentation specifies.
7243 * lisp.h (string_to_number): New decl, replacing ...
7244 (isfloat_string): Remove.
7245 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7246 (read1): Do not accept +. and -. as integers; this
7247 appears to have been a coding error. Similarly, do not accept
7248 strings like +-1e0 as floating point numbers. Do not report
7249 overflow for integer overflows unless the base is not 10 which
7250 means we have no simple and reliable way to continue.
7251 Break out the floating-point parsing into a new
7252 function string_to_number, so that Fstring_to_number parses
7253 floating point numbers consistently with the Lisp reader.
7254 (digit_to_number): Move here from data.c. Make it static inline.
7255 (E_CHAR, EXP_INT): Remove, replacing with ...
7256 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7257 (string_to_number): New function, replacing isfloat_string.
7258 This function checks for valid syntax and produces the resulting
7259 Lisp float number too. Rework it so that string-to-number
7260 no longer mishandles examples like "1.0e+". Use strtoumax,
7261 so that overflow for non-base-10 numbers is reported only when
7262 there's no portable and simple way to convert to floating point.
7264 * textprop.c (set_text_properties_1): Rewrite for clarity,
7265 and to avoid GCC warning about integer overflow.
7267 * intervals.h (struct interval): Use EMACS_INT for members
7268 where EMACS_UINT might cause problems. See
7269 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7270 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7271 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7273 (offset_intervals): Tell GCC not to worry about length overflow
7274 when negating a negative length.
7276 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7277 (overrun_check_free): Likewise.
7279 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7280 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7283 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7284 (gnutls_make_error): Rename local to avoid shadowing.
7285 (gnutls_emacs_global_deinit): ifdef out; not used.
7286 (Fgnutls_boot): Use const for pointer to readonly storage.
7287 Comment out unused local. Fix pointer signedness problems.
7289 * lread.c (openp): Don't stuff size_t into an 'int'.
7290 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7291 about possible signed overflow.
7293 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7294 (GDK_KEY_g): Don't define if already defined.
7295 (xg_prepare_tooltip): Avoid pointer signedness problem.
7296 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7298 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7299 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7301 * xfns.c (Fx_window_property): Simplify a bit,
7302 to make a bit faster and to avoid GCC 4.6.0 warning.
7303 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7305 * fns.c (internal_equal): Don't assume size_t fits in int.
7307 * alloc.c (compact_small_strings): Tighten assertion a little.
7309 Replace pEd with more-general pI, and fix some printf arg casts.
7310 * lisp.h (pI): New macro, generalizing old pEd macro to other
7311 conversion specifiers. For example, use "...%"pI"d..." rather
7312 than "...%"pEd"...".
7313 (pEd): Remove. All uses replaced with similar uses of pI.
7314 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7315 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7316 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7317 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7318 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7319 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7320 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7322 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7323 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7324 * print.c (safe_debug_print, print_object): Likewise.
7325 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7327 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7328 avoiding the 0 flag, which is not portable.
7329 * process.c (Fmake_network_process): Use pI to avoid cast.
7330 * region-cache.c (pp_cache): Likewise.
7331 * xdisp.c (decode_mode_spec): Likewise.
7332 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7333 behavior on 64-bit hosts with printf arg.
7334 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7335 (x_stop_queuing_selection_requests): Likewise.
7336 (x_get_window_property): Don't truncate byte count to an 'int'
7339 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7340 here, since it parses constructs like leading '-' and spaces,
7341 which are not wanted; and it overflows with large numbers.
7342 Instead, simply match F[0-9]+, which is what is wanted anyway.
7344 * alloc.c: Remove unportable assumptions about struct layout.
7345 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7346 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7347 (allocate_vectorlike, make_pure_vector): Use the new macros,
7348 plus offsetof, to remove unportable assumptions about struct layout.
7349 These assumptions hold on all porting targets that I know of, but
7350 they are not guaranteed, they're easy to remove, and removing them
7351 makes further changes easier.
7353 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7354 This doesn't fix a bug but makes the code clearer.
7355 (string_overrun_cookie): Now const. Use initializers that
7356 don't formally overflow signed char, to avoid warnings.
7357 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7358 can cause Emacs to crash when string overrun checking is enabled.
7359 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7360 multiple of sizeof (EMACS_INT); it need not be, if
7361 alignof(EMACS_INT) < sizeof (EMACS_INT).
7362 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7364 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7366 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7368 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7370 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7371 supposed to be handshaking. (Bug#8556)
7372 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7374 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7376 * lisp.h (Qdebug): List symbol.
7377 * eval.c (Qdebug): Restore global linkage.
7378 * keyboard.c (debug-on-event): New variable.
7379 (handle_user_signal): Break into debugger when debug-on-event
7380 matches the current signal symbol.
7382 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7384 * alloc.c (check_sblock, check_string_bytes)
7385 (check_string_free_list): Convert to standard C.
7387 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7389 * w32.c (emacs_gnutls_push): Fix typo.
7391 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7393 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7394 "cast to pointer from integer of different size".
7396 Improve doprnt and its use in verror. (Bug#8545)
7397 * doprnt.c (doprnt): Document the set of format control sequences
7398 supported by the function. Use SAFE_ALLOCA instead of always
7401 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7402 is one byte too soon. Don't use xrealloc; instead xfree and
7405 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7407 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7410 * gnutls.c: Renamed global_initialized to
7411 gnutls_global_initialized. Added internals for the
7412 :verify-hostname-error, :verify-error, and :verify-flags
7413 parameters of `gnutls-boot' and documented those parameters in the
7414 docstring. Start callback support.
7415 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7416 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7417 on error. Return error code.
7418 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7419 (emacs_gnutls_read): Likewise.
7420 (Fgnutls_boot): Return handshake error code.
7421 (emacs_gnutls_handle_error): New function.
7422 (wsaerror_to_errno): Likewise.
7424 * w32.h (emacs_gnutls_pull): Add prototype.
7425 (emacs_gnutls_push): Likewise.
7427 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7428 (emacs_gnutls_push): Likewise.
7430 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7432 * process.c (wait_reading_process_output): Check if GnuTLS
7433 buffered some data internally if no FDs are set for TLS
7436 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7437 (LIBS): Link to USER_LIBS.
7438 ($(BLD)/gnutls.$(0)): New target.
7440 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7442 * xdisp.c (handle_single_display_spec): Rename the
7443 display_replaced_before_p argument into display_replaced_p, to
7444 make it consistent with the commentary. Fix typos in the
7447 * textprop.c (syms_of_textprop): Remove dead code.
7448 (copy_text_properties): Delete obsolete commentary about an
7449 interface that was deleted long ago. Fix typos in the description
7452 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7453 to changes in oldXMenu/XMenu.h from 2011-04-16.
7454 <menu_help_message, prev_menu_help_message>: Constify.
7455 (IT_menu_make_room): menu->help_text is now `const char **';
7458 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7459 to changes in oldXMenu/XMenu.h from 2011-04-16.
7460 (struct XMenu): Declare `help_text' `const char **'.
7462 * xfaces.c <Qunspecified>: Make extern again.
7464 * syntax.c: Include sys/types.h before including regex.h, as
7467 * doc.c (get_doc_string): Improve the format passed to `error'.
7469 * doprnt.c (doprnt): Improve commentary.
7471 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7473 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7476 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7477 changes in globals.h immediately force recompilation.
7478 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7479 $(CURDIR)/s/ms-w32.h.
7480 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7482 * character.c (Fchar_direction): Function deleted.
7483 (syms_of_character): Don't defsubr it.
7484 <char-direction-table>: Deleted.
7486 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7488 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7489 * doprnt.c: Include limits.h.
7490 (SIZE_MAX): New macro.
7491 (doprnt): Return a size_t value. 2nd arg is now size_t.
7492 Many local variables are now size_t instead of int or unsigned.
7493 Improve overflow protection. Support `l' modifier for integer
7494 conversions. Support %l conversion. Don't assume an EMACS_INT
7495 argument for integer conversions and for %c.
7497 * lisp.h (doprnt): Restore prototype.
7499 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7502 * Makefile.in (base_obj): Add back doprnt.o.
7504 * deps.mk (doprnt.o): Add back prerequisites.
7505 (callint.o): Depend on character.h.
7507 * eval.c (internal_lisp_condition_case): Include the handler
7508 representation in the error message.
7509 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7510 when breaking from the loop.
7512 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7514 * callint.c (Fcall_interactively): When displaying error message
7515 about invalid control letter, pass the character's codepoint, not
7516 a pointer to its multibyte form. Improve display of the character
7517 in octal and display also its hex code.
7519 * character.c (char_string): Use %x to display the (unsigned)
7520 codepoint of an invalid character, to avoid displaying a bogus
7523 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7524 `error', not SYMBOL_NAME itself.
7526 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7527 character arguments to `error'.
7529 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7530 to `error' in error message about FINAL_CHAR argument. Make sure
7531 FINAL_CHAR is a character, and use %c when it is passed as
7532 argument to `error'.
7534 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7536 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7538 * w32.c: Include <time.h>.
7539 (sys_localtime): New function.
7541 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7543 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7545 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7547 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7549 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7552 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7554 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7555 gl_state.e_property when gl_state.object is Qt.
7557 * insdel.c (make_gap_larger): Remove limitation of buffer size
7560 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7562 * xdisp.c (lookup_glyphless_char_display)
7563 (produce_glyphless_glyph): Handle cons cell entry in
7564 glyphless-char-display.
7565 (Vglyphless_char_display): Document it.
7567 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7568 glyphless-char-display.
7570 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7572 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7574 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7576 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7577 definition for no-X builds.
7579 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7581 Static checks with GCC 4.6.0 and non-default toolkits.
7583 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7585 * process.c (keyboard_bit_set): Define only if SIGIO.
7586 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7587 (send_process): Repair possible setjmp clobbering.
7589 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7591 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7593 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7595 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7596 Define only if needed.
7598 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7599 by pacifying GCC about it. Maybe it's time to retire it?
7600 * xfaces.c (USG, __TIMEVAL__): Likewise.
7602 * dispextern.h (struct redisplay_interface): Rename param
7604 * termhooks.h (struct terminal): Likewise.
7605 * xterm.c (xembed_send_message): Likewise.
7607 * insdel.c (make_gap_smaller): Define only if
7608 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7610 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7613 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7614 so that we aren't warned about unused symbols.
7616 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7618 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7620 * xfns.c (x_real_positions): Mark locals as initialized.
7622 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7624 * xterm.c: Fix problems found by static analysis with other toolkits.
7625 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7626 (x_dispatch_event): Declare static if USE_GTK, and
7627 define if USE_GTK || USE_X_TOOLKIT.
7628 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7629 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7630 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7631 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7633 * xmenu.c (menu_help_callback): Pointer type fixes.
7634 Use const pointers when pointing at readonly data. Avoid pointer
7636 (FALSE): Remove unused macro.
7637 (update_frame_menubar): Remove unused decl.
7639 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7641 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7642 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7643 (single_menu_item): Rename local to avoid shadowing.
7645 * keyboard.c (make_lispy_event): Remove unused local var.
7647 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7648 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7650 * bitmaps: Change bitmaps from unsigned char back to the X11
7651 compatible char. Avoid the old compiler warnings about
7652 out-of-range initializers by using, for example, '\xab' rather
7655 * xgselect.c (xgselect_initialize): Check vs interface
7656 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7658 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7660 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7661 to read-only memory.
7663 * fns.c (vector): Remove; this old hack is no longer needed.
7665 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7667 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7669 * xrdb.c (x_load_resources): Omit unused local.
7671 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7672 (x_window): Rename locals to avoid shadowing.
7673 (USG): Use the kludged USG macro, to pacify gcc.
7675 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7676 (x_term_init): Remove local to avoid shadowing.
7678 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7680 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7681 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7683 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7685 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7687 Fix regex.c, syntax.c and friends for buffers > 2GB.
7688 * syntax.h (struct gl_state_s): Declare character position members
7691 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7693 * textprop.c (verify_interval_modification, interval_of):
7694 Declare arguments EMACS_INT.
7696 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7699 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7701 * indent.c (Fvertical_motion): Local variable it_start is now
7704 * regex.c (re_match, re_match_2, re_match_2_internal)
7705 (bcmp_translate, regcomp, regexec, print_double_string)
7706 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7707 (re_compile_pattern, re_exec): Declare arguments and local
7708 variables `size_t' and `ssize_t' and return values `regoff_t', as
7710 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7711 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7712 <compile_stack_type>: `size' and `avail' are now `size_t'.
7714 * regex.h <regoff_t>: Use ssize_t, not int.
7715 (re_search, re_search_2, re_match, re_match_2): Arguments that
7716 specify buffer/string position and length are now ssize_t and
7717 size_t. Return type is regoff_t.
7719 2011-04-16 Ben Key <bkey76@gmail.com>
7721 * nsfont.m: Fixed bugs in ns_get_family and
7722 ns_descriptor_to_entity that were caused by using free to
7723 deallocate memory blocks that were allocated by xmalloc (via
7724 xstrdup). This caused Emacs to crash when compiled with
7725 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7726 --enable-checking=xmallocoverrun). xfree is now used to
7727 deallocate these memory blocks.
7729 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7731 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7733 emacs_write: Accept and return EMACS_INT for sizes.
7734 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7736 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7737 Accept and return EMACS_INT.
7738 (emacs_gnutls_write): Return the number of bytes written on
7740 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7741 (emacs_read, emacs_write): Remove check for negative size, as the
7742 Emacs source code has been audited now.
7743 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7744 (emacs_read, emacs_write): Use it.
7745 * process.c (send_process): Adjust to the new signatures of
7746 emacs_write and emacs_gnutls_write. Do not attempt to store
7747 a byte offset into an 'int'; it might overflow.
7748 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7750 * sound.c: Don't assume sizes fit in 'int'.
7751 (struct sound_device.period_size, alsa_period_size):
7752 Return EMACS_INT, not int.
7753 (struct sound_device.write, vox_write, alsa_write):
7754 Accept EMACS_INT, not int.
7755 (wav_play, au_play): Use EMACS_INT to store sizes and to
7756 record read return values.
7758 2011-04-15 Ben Key <bkey76@gmail.com>
7760 * keyboard.c (Qundefined): Don't declare static since it is used
7762 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7763 static since they are used in nsfont.m.
7765 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7767 * process.c (Qprocessp): Don't declare static.
7768 * lisp.h (Qprocessp): Declare again.
7770 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7772 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7774 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7776 Improve C-level modularity by making more things 'static'.
7778 Don't publish debugger-only interfaces to other modules.
7779 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7780 (verify_bytepos, count_markers): Move decls to the only modules
7782 * region-cache.h (pp_cache): Likewise.
7783 * window.h (check_all_windows): Likewise.
7784 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7786 * sysdep.c (croak): Now static, if
7787 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7788 * syssignal.h (croak): Declare only if not static.
7790 * alloc.c (refill_memory_reserve): Now static if
7791 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7792 * lisp.h (refill_memory_reserve): Declare only if not static.
7794 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7795 Define only if USE_LUCID.
7797 * xrdb.c (x_customization_string, x_rm_string): Now static.
7799 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7800 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7802 * xdisp.c (draw_row_with_mouse_face): Now static.
7803 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7805 * window.h (check_all_windows): Mark externally visible.
7807 * window.c (window_deletion_count): Now static.
7809 * undo.c: Make symbols static if they're not exported.
7810 (last_undo_buffer, last_boundary_position, pending_boundary):
7813 * textprop.c (interval_insert_behind_hooks): Now static.
7814 (interval_insert_in_front_hooks): Likewise.
7816 * term.c: Make symbols static if they're not exported.
7817 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7818 (max_frame_lines, tty_set_terminal_modes):
7819 (tty_reset_terminal_modes, tty_turn_off_highlight):
7820 (get_tty_terminal): Now static.
7821 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7822 * termhooks.h (term_mouse_moveto): Do not declare if
7824 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7825 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7827 * sysdep.c: Make symbols static if they're not exported.
7828 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7830 (sigprocmask_set, full_mask): Remove; unused.
7831 (wait_debugging): Mark as visible.
7832 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7833 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7835 * syntax.c (syntax_temp): Define only if !__GNUC__.
7837 * sound.c (current_sound_device, current_sound): Now static.
7839 * search.c (searchbufs, searchbuf_head): Now static.
7841 * scroll.c (scroll_cost): Remove; unused.
7842 * dispextern.h (scroll_cost): Remove decl.
7844 * region-cache.h (pp_cache): Mark as externally visible.
7846 * process.c: Make symbols static if they're not exported.
7847 (process_tick, update_tick, create_process, chan_process):
7848 (Vprocess_alist, proc_buffered_char, datagram_access):
7849 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7850 (deactivate_process): Mark defn as static, as well as decl.
7851 * lisp.h (create_process): Remove decl.
7852 * process.h (chan_process, Vprocess_alist): Remove decls.
7854 * print.c: Make symbols static if they're not exported.
7855 (print_depth, new_backquote_output, being_printed, print_buffer):
7856 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7857 (print_interval, print_number_index, initial_stderr_stream):
7859 * lisp.h (Fprinc): Remove decl.
7860 (debug_output_compilation_hack): Mark as externally visible.
7862 * sysdep.c (croak): Move decl from here to syssignal.h.
7863 * syssignal.h (croak): Put it here, so the API can be checked when
7864 'croak' is called from dissociate_if_controlling_tty.
7866 * minibuf.c: Make symbols static if they're not exported.
7867 (minibuf_save_list, choose_minibuf_frame): Now static.
7868 * lisp.h (choose_minibuf_frame): Remove decl.
7870 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7872 * lread.c: Make symbols static if they're not exported.
7873 (read_objects, initial_obarray, oblookup_last_bucket_number):
7875 (make_symbol): Remove; unused.
7876 * lisp.h (initial_obarray, make_symbol): Remove decls.
7878 * keyboard.c: Make symbols static if they're not exported.
7879 (single_kboard, recent_keys_index, total_keys, recent_keys):
7880 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7881 (this_single_command_key_start, echoing, last_auto_save):
7882 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7883 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7884 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7885 (Vlispy_mouse_stem, double_click_count):
7887 (force_auto_save_soon): Define only if SIGDANGER.
7888 (ignore_mouse_drag_p): Now static if
7889 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7890 (print_help): Remove; unused.
7891 (stop_character, last_timer_event): Mark as externally visible.
7892 * keyboard.h (ignore_mouse_drag_p): Declare only if
7893 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7894 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7895 * lisp.h (echoing): Remove decl.
7896 (force_auto_save_soon): Declare only if SIGDANGER.
7897 * xdisp.c (redisplay_window): Simplify code, to make it more
7898 obvious that ignore_mouse_drag_p is not accessed if !defined
7899 USE_GTK && !defined HAVE_NS.
7901 * intervals.c: Make symbols static if they're not exported.
7902 (merge_properties_sticky, merge_interval_right, delete_interval):
7904 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7906 * insdel.c: Make symbols static if they're not exported.
7907 However, leave prepare_to_modify_buffer alone. It's never
7908 called from outside this function, but that appears to be a bug.
7909 (combine_after_change_list, combine_after_change_buffer):
7910 (adjust_after_replace, signal_before_change): Now static.
7911 (adjust_after_replace_noundo): Remove; unused.
7912 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7913 (signal_before_change): Remove decls.
7915 * indent.c (val_compute_motion, val_vmotion): Now static.
7917 * image.c: Make symbols static if they're not exported.
7918 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7920 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7921 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7923 * fringe.c (standard_bitmaps): Now static.
7924 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7926 * frame.c: Make symbols static if they're not exported.
7927 (x_report_frame_params, make_terminal_frame): Now static.
7928 (get_frame_param): Now static, unless HAVE_NS.
7929 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7930 (x_get_resource_string): Remove; not used.
7931 * frame.h (make_terminal_frame, x_report_frame_params):
7932 (x_get_resource_string); Remove decls.
7933 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7934 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7936 * font.c, fontset.c: Make symbols static if they're not exported.
7937 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7938 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7939 * font.c (font_close_object): Now static.
7940 * font.h (font_close_object): Remove.
7941 * fontset.c (FONTSET_OBJLIST): Remove.
7942 (free_realized_fontset) #if-0 the body, which does nothing.
7943 (face_suitable_for_char_p): #if-0, as it's never called.
7944 * fontset.h (face_suitable_for_char_p): Remove decl.
7945 * xfaces.c (face_at_string_position):
7946 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7947 since 0 is always ASCII.
7949 * fns.c (weak_hash_tables): Now static.
7951 * fileio.c: Make symbols static if they're not exported.
7952 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7953 (Vwrite_region_annotation_buffers): Now static.
7955 * eval.c: Make symbols static if they're not exported.
7956 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7957 * lisp.h (backtrace_list): Remove decl.
7959 * emacs.c: Make symbols static if they're not exported.
7960 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7961 (fatal_error_code, fatal_error_signal_hook, standard_args):
7963 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7964 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7965 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7966 * lisp.h (fatal_error_signal_hook): Remove decl.
7967 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7969 * editfns.c: Move a (normally-unused) function to its only use.
7970 * editfns.c, lisp.h (get_operating_system_release): Remove.
7971 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7972 worth the hassle of breaking this out.
7974 * xterm.c: Make symbols static if they're not exported.
7975 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7976 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7977 (x_destroy_window, x_delete_display):
7979 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7980 (x_mouse_leave): Remove; unused.
7981 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7982 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7983 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7985 (x_mouse_leave): Declare only if WINDOWSNT.
7986 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7987 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7990 * ftxfont.c: Make symbols static if they're not exported.
7991 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7993 * font.h (ftxfont_driver): Likewise.
7995 * xfns.c: Make symbols static if they're not exported.
7996 (x_last_font_name, x_display_info_for_name):
7997 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7998 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7999 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8000 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8001 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8002 (last_show_tip_args): Now static.
8003 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8004 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8005 (x_screen_planes): Remove; unused.
8006 * dispextern.h (x_screen_planes): Remove decl.
8008 * dispnew.c: Make symbols static if they're not exported.
8009 * dispextern.h (redraw_garbaged_frames, scrolling):
8010 (increment_row_positions): Remove.
8011 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8012 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8014 (redraw_garbaged_frames): Remove; unused.
8016 * xfaces.c: Make symbols static if they're not exported.
8017 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8019 * xterm.h (defined_color): Remove decls.
8020 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8021 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8022 (menu_face_changed_default, defined_color, free_realized_face):
8023 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8024 (ascii_face_of_lisp_face): Remove; unused.
8026 * xdisp.c: Make symbols static if they're not exported.
8027 * dispextern.h (scratch_glyph_row, window_box_edges):
8028 (glyph_to_pixel_coords, set_cursor_from_row):
8029 (get_next_display_element, set_iterator_to_next):
8030 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8031 (show_mouse_face): Remove decls
8032 * frame.h (message_buf_print): Likewise.
8033 * lisp.h (pop_message, set_message, check_point_in_composition):
8035 * xterm.h (set_vertical_scroll_bar): Likewise.
8036 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8037 (message_buf_print, scratch_glyph_row, displayed_buffer):
8038 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8039 (get_next_display_element, show_mouse_face, window_box_edges):
8040 (frame_to_window_pixel_xy, check_point_in_composition):
8041 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8042 (glyph_to_pixel_coords): Remove; unused.
8044 * dired.c (file_name_completion): Now static.
8046 * dbusbind.c (xd_in_read_queued_messages): Now static.
8048 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8049 * data.c (circular_list_error): Remove.
8051 * commands.h (last_point_position, last_point_position_buffer):
8052 (last_point_position_window): Remove decls.
8053 * keyboard.c: Make these variables static.
8055 * coding.h (coding, code_convert_region, encode_coding_gap):
8057 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8058 (iso_code_class, detect_coding, code_convert_region): Now static.
8059 (encode_coding_gap): Remove; unused.
8061 * chartab.c (chartab_chars, chartab_bits): Now static.
8063 * charset.h (charset_iso_8859_1): Remove decl.
8064 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8067 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8068 * ccl.c (Vccl_program_table): Now static.
8069 (check_ccl_update): Remove; unused.
8071 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8072 * category.h: ... from here.
8073 * category.c (check_category_table, set_category_set): Now static.
8075 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8076 * lisp.h: Remove these decls.
8078 * buffer.c (buffer_count): Remove unused var.
8080 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8081 so that it's not optimized away.
8082 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8083 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8084 exported only to the debugger.
8086 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8087 * atimer.h (run_all_atimers): Remove; not exported.
8089 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8090 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8091 was inaccessible from Lisp.
8092 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8093 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8095 alloc.c: Import and export fewer symbols, and remove unused items.
8096 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8098 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8099 it's not optimized away by whole-program optimization.
8100 (message_enable_multibyte, free_misc): Remove.
8101 (catchlist, handlerlist, mark_backtrace):
8102 Declare only if BYTE_MARK_STACK.
8103 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8104 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8105 (message_enable_multibyte): Remove decl.
8106 (free_misc, interval_free_list, float_block, float_block_index):
8107 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8108 (cons_free_list, last_marked_index):
8110 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8111 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8112 (mark_backtrace): Define only if BYTE_MARK_STACK.
8113 * xdisp.c (message_enable_multibyte): Now static.
8115 Declare Lisp_Object Q* variables to be 'static' if not exported.
8116 This makes it easier for human readers (and static analyzers)
8117 to see whether these variables are used from other modules.
8118 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8119 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8120 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8121 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8122 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8123 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8124 * xmenu.c, xselect.c:
8125 Declare Q* vars static if they are not used in other modules.
8126 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8127 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8128 Remove decls of unexported vars.
8129 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8131 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8133 Make Emacs functions such as Fatom 'static' by default.
8134 This makes it easier for human readers (and static analyzers)
8135 to see whether these functions can be called from other modules.
8136 DEFUN now defines a static function. To make the function external
8137 so that it can be used in other C modules, use the new macro DEFUE.
8138 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8139 (Finit_image_library):
8140 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8141 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8142 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8143 Remove decls, since these functions are now static.
8144 (Funintern, Fget_internal_run_time): New decls, since these functions
8145 were already external.
8147 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8148 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8149 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8150 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8151 * keyboard.c, keymap.c, lread.c:
8152 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8153 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8154 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8155 Mark functions with DEFUE instead of DEFUN,
8156 if they are used in other modules.
8157 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8158 decls for now-static functions.
8159 * buffer.h (Fdelete_overlay): Remove decl.
8160 * callproc.c (Fgetenv_internal): Mark as internal.
8161 * composite.c (Fremove_list_of_text_properties): Remove decl.
8162 (Fcomposition_get_gstring): New forward static decl.
8163 * composite.h (Fcomposite_get_gstring): Remove decl.
8164 * dired.c (Ffile_attributes): New forward static decl.
8165 * doc.c (Fdocumntation_property): New forward static decl.
8166 * eval.c (Ffetch_bytecode): New forward static decl.
8167 (Funintern): Remove extern decl; now in .h file where it belongs.
8168 * fileio.c (Fmake_symbolic_link): New forward static decl.
8169 * image.c (Finit_image_library): New forward static decl.
8170 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8171 * intervals.h (Fprevious_property_change):
8172 (Fremove_list_of_text_properties): Remove decls.
8173 * keyboard.c (Fthis_command_keys): Remove decl.
8174 (Fcommand_execute): New forward static decl.
8175 * keymap.c (Flookup_key): New forward static decl.
8176 (Fcopy_keymap): Now static.
8177 * keymap.h (Flookup_key): Remove decl.
8178 * process.c (Fget_process): New forward static decl.
8179 (Fprocess_datagram_address): Mark as internal.
8180 * syntax.c (Fsyntax_table_p): New forward static decl.
8181 (skip_chars): Remove duplicate decl.
8182 * textprop.c (Fprevious_property_change): New forward static decl.
8183 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8185 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8186 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8188 * editfns.c (Fformat): Remove unreachable code.
8190 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8192 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8195 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8197 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8198 when at ZV. (Bug#8487)
8200 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8202 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8204 * keyboard.c (parse_tool_bar_item): Likewise.
8205 * sound.c (sound_cleanup, alsa_close): Likewise.
8206 * termcap.c (tgetent): Likewise.
8207 * xfns.c (x_default_font_parameter): Likewise.
8208 * xsettings.c (read_and_apply_settings): Likewise.
8210 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8211 (overrun_check_free): Protoize.
8213 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8215 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8216 since callers should never pass a negative size.
8217 Change the signature to match that of plain 'read' and 'write'; see
8218 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8219 * lisp.h: Update prototypes of emacs_write and emacs_read.
8221 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8223 * xdisp.c (redisplay_window): Don't try to determine the character
8224 position of the scroll margin if the window start point w->startp
8225 is outside the buffer's accessible region. (Bug#8468)
8227 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8229 Fix write-region and its subroutines for buffers > 2GB.
8230 * fileio.c (a_write, e_write): Modify declaration of arguments and
8231 local variables to support buffers larger than 2GB.
8232 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8234 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8235 argument, local variables, and return value.
8237 * lisp.h: Update prototypes of emacs_write and emacs_read.
8239 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8241 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8243 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8245 Fix more problems found by GCC 4.6.0's static checks.
8247 * xdisp.c (vmessage): Use a better test for character truncation.
8249 * charset.c (load_charset_map): <, not <=, for optimization,
8250 and to avoid potential problems with integer overflow.
8251 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8252 * casetab.c (set_identity, shuffle): Likewise.
8253 * editfns.c (Fformat): Likewise.
8254 * syntax.c (skip_chars): Likewise.
8256 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8257 This also lets GCC 4.6.0 generate slightly better loop code.
8259 * callint.c (Fcall_interactively): <, not <=, for optimization.
8260 (Fcall_interactively): Count the number of arguments produced,
8261 not the number of arguments given. This is simpler and lets GCC
8262 4.6.0 generate slightly better code.
8264 * ftfont.c: Distingish more carefully between FcChar8 and char.
8265 The previous code passed unsigned char * to a functions like
8266 strlen and xstrcasecmp that expect char *, which does not
8267 conform to the C standard.
8268 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8269 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8270 char * when the C standard requires it.
8272 * keyboard.c (read_char): Remove unused var.
8274 * eval.c: Port to Windows vsnprintf (Bug#8435).
8276 (SIZE_MAX): Define if the headers do not.
8277 (verror): Do not give up if vsnprintf returns a negative count.
8278 Instead, grow the buffer. This ports to Windows vsnprintf, which
8279 does not conform to C99. Problem reported by Eli Zaretskii.
8280 Also, simplify the allocation scheme, by avoiding the need for
8281 calling realloc, and removing the ALLOCATED variable.
8283 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8285 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8286 But keep the doprint source code for now, as we might revamp it
8287 and use it again (Bug#8435).
8288 * lisp.h (doprnt): Remove.
8289 * Makefile.in (base_obj): Remove doprnt.o.
8290 * deps.mk (doprnt.o): Remove.
8292 error: Print 32- and 64-bit integers portably (Bug#8435).
8293 Without this change, on typical 64-bit hosts error ("...%d...", N)
8294 was used to print both 32- and 64-bit integers N, which relied on
8296 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8297 * lisp.h (error, verror): Mark as printf-like functions.
8298 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8299 Report overflow in size calculations when allocating printf buffer.
8300 Do not truncate output string at its first null byte.
8301 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8302 Truncate the output at a character boundary, since vsnprintf does not
8304 * charset.c (check_iso_charset_parameter): Convert internal
8305 character to string before calling 'error', since %c now has the
8307 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8308 overflow when computing char to be passed to 'error'. Do not
8309 pass Lisp_Object to 'error'; pass the integer instead.
8310 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8311 formatted with plain %d.
8313 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8315 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8317 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8319 * xterm.c (x_catch_errors): Remove duplicate declaration.
8321 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8323 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8325 2011-04-10 Jim Meyering <meyering@redhat.com>
8327 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8328 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8329 return ssize_t not "int", and use size_t as the buffer length.
8330 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8331 * gnutls.h: Update declarations.
8332 * process.c (read_process_output): Use ssize_t, to match.
8333 (send_process): Likewise.
8335 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8337 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8339 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8341 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8342 Use unsigned char, to match FcChar8 type definition.
8344 * xterm.c (handle_one_xevent):
8345 * xmenu.c (create_and_show_popup_menu):
8346 * xselect.c (x_decline_selection_request)
8347 (x_reply_selection_request): Avoid type-punned deref of X events.
8349 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8351 Fix some uses of `int' instead of EMACS_INT.
8352 * search.c (string_match_1, fast_string_match)
8353 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8354 (scan_buffer, find_next_newline_no_quit)
8355 (find_before_next_newline, search_command, Freplace_match)
8356 (Fmatch_data): Make some `int' variables be EMACS_INT.
8358 * xdisp.c (display_count_lines): 3rd argument and return value now
8359 EMACS_INT. All callers changed.
8360 (pint2hrstr): Last argument is now EMACS_INT.
8362 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8363 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8364 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8365 (decode_coding_utf_16, decode_coding_emacs_mule)
8366 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8367 (decode_coding_ccl, decode_coding_charset)
8368 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8369 (decode_coding_iso_2022, decode_coding_emacs_mule)
8370 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8371 <char_offset, last_offset>: Declare EMACS_INT.
8372 (encode_coding_utf_8, encode_coding_utf_16)
8373 (encode_coding_emacs_mule, encode_invocation_designation)
8374 (encode_designation_at_bol, encode_coding_iso_2022)
8375 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8376 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8378 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8379 (encode_invocation_designation): Last argument P_NCHARS is now
8381 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8382 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8384 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8387 * ccl.c (Fccl_execute_on_string): Declare some variables
8390 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8392 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8394 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8396 * process.c (Fformat_network_address): Doc fix.
8398 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8400 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8402 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8404 * keyboard.c (read_char): Call Lisp function help-form-show,
8405 instead of using internal_with_output_to_temp_buffer.
8406 (Qhelp_form_show): New var.
8407 (syms_of_keyboard): Use DEFSYM macro.
8409 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8411 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8413 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8415 * process.c (Flist_processes): Remove to Lisp.
8416 (list_processes_1): Delete.
8418 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8420 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8422 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8424 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8426 Fix more problems found by GCC 4.6.0's static checks.
8428 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8430 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8432 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8434 * xdisp.c (vmessage): Mark as a printf-like function.
8436 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8438 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8440 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8441 printf-like functions.
8442 (tiff_load): Add casts to remove these marks before passing them
8443 to system-supplied API.
8445 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8447 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8448 This avoids several warnings with gcc -Wstrict-overflow.
8449 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8450 directly, rather than having caller test rule sign. This avoids
8451 some unnecessary tests.
8452 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8453 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8454 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8456 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8457 (xfont_open): Avoid unnecessary tests.
8459 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8461 * composite.h, composite.c (composition_gstring_put_cache):
8462 Use EMACS_INT, not int, for length.
8464 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8465 breaking out part of COMPOSITION_DECODE_RULE.
8466 (COMPOSITION_DECODE_RULE): Use it.
8467 * composite.c (get_composition_id): Remove unused local vars,
8468 by using the new macro.
8470 * textprop.c (set_text_properties_1): Change while to do-while,
8471 since the condition is always true at first.
8473 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8474 (interval_deletion_adjustment): Return unsigned value.
8477 * process.c (list_processes_1, create_pty, read_process_output):
8478 (exec_sentinel): Remove vars that were set but not used.
8479 (create_pty): Remove unnecessary "volatile"s.
8480 (Fnetwork_interface_info): Avoid possibility of int overflow.
8481 (read_process_output): Do adaptive read buffering even if carryover.
8482 (read_process_output): Simplify nbytes computation if buffered.
8484 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8486 * syntax.c (scan_words): Remove var that was set but not used.
8487 (update_syntax_table): Use unsigned instead of int.
8489 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8490 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8491 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8493 * print.c (print_error_message): Avoid int overflow.
8495 * font.c (font_list_entities): Redo for clarity,
8496 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8498 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8499 (font_score): Avoid potential overflow in diff calculation.
8501 * fns.c (substring_both): Remove var that is set but not used.
8502 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8504 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8506 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8507 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8508 can always succeed if overflow has undefined behavior.
8510 * search.c (boyer_moore, wordify): Remove vars set but not used.
8511 (wordify): Omit three unnecessary tests.
8513 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8514 All callers changed. This avoids the need for an unused var.
8516 * casefiddle.c (casify_region): Remove var that is set but not used.
8518 * dired.c (file_name_completion): Remove var that is set but not used.
8520 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8522 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8523 (Finsert_file_contents): Remove unnecessary code checking fd.
8525 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8526 Check for integer overflow on size calculations.
8528 * buffer.c (Fprevious_overlay_change): Remove var that is set
8531 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8532 Remove vars that are set but not used.
8533 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8534 (timer_check_2): Mark vars as initialized.
8536 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8538 * image.c (lookup_image): Remove var that is set but not used.
8539 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8541 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8542 that are set but not used.
8544 * xfns.c (make_invisible_cursor): Don't return garbage
8545 if XCreateBitmapFromData fails (Bug#8410).
8547 * xselect.c (x_get_local_selection, x_handle_property_notify):
8548 Remove vars that are set but not used.
8550 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8551 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8553 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8554 Remove var that is set but not used.
8555 (scroll_bar_windows_size): Now size_t, not int.
8556 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8559 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8560 (map_tty_color) [!defined MSDOS]: Likewise.
8562 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8564 * coding.c: Remove vars that are set but not used.
8565 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8566 All callers changed.
8567 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8568 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8569 (decode_coding_charset): Remove vars that are set but not used.
8571 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8572 that is set but not used.
8574 * print.c (print_object): Remove var that is set but not used.
8576 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8577 The gnulib version avoids calling malloc in the usual case,
8578 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8579 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8580 * filelock.c (current_lock_owner): Likewise.
8581 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8582 * sysdep.c: Include allocator.h, careadlinkat.h.
8583 (emacs_no_realloc_allocator): New static constant.
8584 (emacs_readlink): New function.
8585 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8586 ../lib/careadlinkat.h.
8588 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8590 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8591 first non-nil return value).
8593 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8595 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8596 if not defined (Bug#8403).
8598 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8600 * xdisp.c (display_count_lines): Remove parameter `start',
8601 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8602 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8603 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8604 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8605 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8606 and thereabouts. All callers changed.
8607 (get_per_char_metric): Remove parameter `f', unused since
8608 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8610 2011-04-02 Jim Meyering <meyering@redhat.com>
8612 do not dereference NULL upon failed strdup
8613 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8614 (ns_get_family): Likewise.
8616 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8618 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8620 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8622 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8625 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8627 Add lexical binding.
8629 * window.c (Ftemp_output_buffer_show): New fun.
8630 (Fsave_window_excursion):
8631 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8633 * lread.c (lisp_file_lexically_bound_p): New function.
8634 (Fload): Bind Qlexical_binding.
8635 (readevalloop): Remove `evalfun' arg.
8636 Bind Qinternal_interpreter_environment.
8637 (Feval_buffer): Bind Qlexical_binding.
8638 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8640 (syms_of_lread): Declare `lexical-binding'.
8642 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8644 * keyboard.c (eval_dyn): New fun.
8645 (menu_item_eval_property): Use it.
8647 * image.c (parse_image_spec): Use Ffunctionp.
8649 * fns.c (concat, mapcar1): Accept byte-code-functions.
8651 * eval.c (Fsetq): Handle lexical vars.
8652 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8653 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8654 (FletX, Flet): Obey lexical binding.
8655 (Fcommandp): Handle closures.
8656 (Feval): New `lexical' arg.
8657 (eval_sub): New function extracted from Feval. Use it almost
8658 everywhere where Feval was used. Look up vars in lexical env.
8660 (Ffunctionp): Move from subr.el.
8661 (Ffuncall): Handle closures.
8662 (apply_lambda): Remove `eval_flags'.
8663 (funcall_lambda): Handle closures and new byte-code-functions.
8664 (Fspecial_variable_p): New function.
8665 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8666 but without exporting it to Lisp.
8668 * doc.c (Fdocumentation, store_function_docstring):
8669 * data.c (Finteractive_form): Handle closures.
8671 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8674 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8676 (exec_byte_code): New function extracted from Fbyte_code to handle new
8677 calling convention for byte-code-functions. Add new byte-codes.
8679 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8681 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8683 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8685 * xdisp.c (redisplay_internal): Fix prototype.
8687 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8689 * xdisp.c (SCROLL_LIMIT): New macro.
8690 (try_scrolling): Use it when setting scroll_limit.
8691 Limit scrolling to 100 screen lines.
8692 (redisplay_window): Even when falling back on "recentering",
8693 position point in the window according to scroll-conservatively,
8694 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8696 (try_scrolling): When point is above the window, allow searching
8697 as far as scroll_max, or one screenful, to compute vertical
8698 distance from PT to the scroll margin position. This prevents
8699 try_scrolling from unnecessarily failing when
8700 scroll-conservatively is set to a value slightly larger than the
8701 window height. Clean up the case of PT below the margin at bottom
8702 of window: scroll_max can no longer be INT_MAX. When aggressive
8703 scrolling is in use, don't let point enter the opposite scroll
8704 margin as result of the scroll.
8705 (syms_of_xdisp) <scroll-conservatively>: Document the
8706 threshold of 100 lines for never-recentering scrolling.
8708 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8710 * dispextern.h (move_it_by_lines):
8711 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8712 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8713 (message_log_check_duplicate): Remove parameters `prev_bol' and
8714 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8715 (redisplay_internal): Remove parameter `preserve_echo_area',
8716 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8718 * indent.c (Fvertical_motion):
8719 * window.c (window_scroll_pixel_based, Frecenter):
8720 Don't pass `need_y_p' to `move_it_by_lines'.
8722 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8724 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8725 steal a few bits to be more compact.
8726 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8727 Remove unneeded casts.
8729 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8731 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8733 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8734 binding" message (bug#7967).
8736 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8738 Fix more problems found by GCC 4.6.0's static checks.
8740 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8741 Remove unused local var.
8743 * editfns.c (Fmessage_box): Remove unused local var.
8745 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8746 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8747 Omit unused local vars.
8748 * window.c (shrink_windows): Omit unused local var.
8749 * menu.c (digest_single_submenu): Omit unused local var.
8750 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8751 Omit unused local var.
8753 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8754 Don't assume string length fits in int.
8755 (keyremap_step, read_key_sequence): Use size_t for sizes.
8756 (read_key_sequence): Don't check last_real_key_start redundantly.
8758 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8759 instead of alloca (Bug#8344).
8761 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8762 (Fbacktrace_frame): Don't assume nframes fits in int.
8764 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8766 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8769 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8771 * cm.c (calccost): Turn while-do into do-while, for clarity.
8773 * keyboard.c (syms_of_keyboard): Use the same style as later
8774 in this function when indexing through an array. This also
8775 works around GCC bug 48267.
8777 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8779 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8781 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8782 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8784 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8785 This avoids undefined behavior on integer overflow, and is a bit
8786 more convenient anyway since it is compared to a size_t variable.
8788 Variadic C functions now count arguments with size_t, not int.
8789 This avoids an unnecessary limitation on 64-bit machines, which
8790 caused (substring ...) to crash on large vectors (Bug#8344).
8791 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8792 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8793 All variadic functions and their callers changed accordingly.
8794 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8795 * data.c (arith_driver, float_arith_driver): Likewise.
8796 * editfns.c (general_insert_function): Likewise.
8797 * eval.c (struct backtrace.nargs, interactive_p)
8798 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8799 (funcall_lambda, mark_backtrace): Likewise.
8800 * fns.c (concat): Likewise.
8801 * frame.c (x_set_frame_parameters): Likewise.
8802 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8803 0 if not found, not -1. All callers changed.
8805 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8806 (stack_copy_size): Now size_t, not int.
8807 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8809 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8811 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8812 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8813 All callers changed.
8815 * lisp.h (multibyte_char_to_unibyte):
8816 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8817 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8818 * character.h (CHAR_TO_BYTE8):
8819 * cmds.c (internal_self_insert):
8820 * editfns.c (general_insert_function):
8821 * keymap.c (push_key_description):
8822 * search.c (Freplace_match):
8823 * xdisp.c (message_dolog, set_message_1): All callers changed.
8825 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8827 * keyboard.c (safe_run_hook_funcall): New function.
8828 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8829 don't set the hook to nil, but remove the offending function instead.
8830 (Qcommand_hook_internal): Remove, unused.
8831 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8832 Vcommand_hook_internal.
8834 * eval.c (enum run_hooks_condition): Remove.
8835 (funcall_nil, funcall_not): New functions.
8836 (run_hook_with_args): Call each function through a `funcall' argument.
8837 Remove `cond' argument, now redundant.
8838 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8839 (Frun_hook_with_args_until_failure): Adjust accordingly.
8840 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8842 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8844 * dispextern.h (string_buffer_position): Remove declaration.
8846 * print.c (strout): Remove parameter `multibyte', unused since
8847 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8849 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8850 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8851 All callers changed.
8853 * w32.c (_wsa_errlist): Use braces for struct initializers.
8855 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8856 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8857 All callers changed.
8858 (string_buffer_position): Likewise. Also, make static (it's never
8859 used outside xdisp.c).
8860 (cursor_row_p): Remove parameter `w', unused since
8861 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8862 (decode_mode_spec): Remove parameter `precision', introduced during
8863 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8864 All callers changed.
8866 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8868 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8870 2011-03-27 Anders Lindgren <andlind@gmail.com>
8872 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8873 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8874 (ns_update_auto_hide_menu_bar): New functions.
8875 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8876 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8877 ns_constrain_all_frames.
8878 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8879 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8881 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8883 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8885 2011-03-27 Glenn Morris <rgm@gnu.org>
8887 * syssignal.h: Replace RETSIGTYPE with void.
8888 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8889 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8890 Replace SIGTYPE with void everywhere.
8891 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8892 * s/template.h (SIGTYPE): Remove commented out definition.
8894 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8896 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8897 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8899 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8901 * w32.c (read_unc_volume): Use parameter `henum', instead of
8902 global variable `wget_enum_handle'.
8904 * keymap.c (describe_vector): Remove parameters `indices' and
8905 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8906 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8908 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8910 * keyboard.c (timer_check): Remove parameter `do_it_now',
8911 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8912 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8913 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8915 * keyboard.c (read_char):
8916 * w32menu.c (w32_menu_display_help):
8917 * xmenu.c (show_help_event, menu_help_callback):
8918 Adjust calls to `show_help_echo'.
8920 * gtkutil.c (xg_maybe_add_timer):
8921 * keyboard.c (readable_events):
8922 * process.c (wait_reading_process_output):
8923 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8925 * insdel.c (adjust_markers_gap_motion):
8926 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8927 (gap_left, gap_right): Don't call it.
8929 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8931 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8932 incurred during fontification.
8934 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8936 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8937 (DEFVAR_PER_BUFFER): Don't pass it.
8939 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8940 (scrolling_window): Don't pass it.
8942 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8944 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8946 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8948 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8949 of variables specific to SELinux and computation of `encoded_absname'.
8951 * image.c (XPutPixel): Remove unused variable `height'.
8953 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8955 * unexw32.c (get_section_info): Remove unused variable `section'.
8957 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8958 (system_process_attributes): Remove unused variable `sess'.
8959 (sys_read): Remove unused variable `err'.
8961 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8962 (w32_wnd_proc): Remove unused variable `isdead'.
8963 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8964 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8965 (x_create_tip_frame): Remove unused variable `tem'.
8967 * w32inevt.c (w32_console_read_socket):
8968 Remove unused variable `no_events'.
8970 * w32term.c (x_draw_composite_glyph_string_foreground):
8971 Remove unused variable `width'.
8973 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8975 * w32term.c (x_set_glyph_string_clipping):
8976 Don't pass uninitialized region to CombineRgn.
8978 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8980 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8981 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8982 (Fx_close_connection): Remove unused variable `i'.
8984 * w32font.c (w32font_draw): Return number of glyphs.
8985 (w32font_open_internal): Remove unused variable `i'.
8986 (w32font_driver): Add missing initializer.
8988 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8989 (fill_in_menu): Remove unused variable `items_added'.
8991 * w32term.c (last_mouse_press_frame): Remove static global variable.
8992 (w32_clip_to_row): Remove unused variable `f'.
8993 (x_delete_terminal): Remove unused variable `i'.
8995 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8996 (NOTHING): Remove unused static global variable.
8997 (uniscribe_check_otf): Remove unused variable `table'.
8998 (uniscribe_font_driver): Add missing initializers.
9000 2011-03-23 Julien Danjou <julien@danjou.info>
9002 * term.c (Fsuspend_tty, Fresume_tty):
9003 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9004 * window.c (temp_output_buffer_show):
9005 * insdel.c (signal_before_change):
9006 * frame.c (Fhandle_switch_frame):
9007 * fileio.c (Fdo_auto_save):
9008 * emacs.c (Fkill_emacs):
9009 * editfns.c (save_excursion_restore):
9010 * cmds.c (internal_self_insert):
9011 * callint.c (Fcall_interactively):
9012 * buffer.c (Fkill_all_local_variables):
9013 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9015 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9016 unconditionally since it does the check itself.
9018 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9020 Fix more problems found by GCC 4.5.2's static checks.
9022 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9023 the first time through the loop, since we know p0 < p1 then.
9024 This also avoids a gcc -Wstrict-overflow warning.
9026 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9027 leading to a memory leak, possible in functions like
9028 load_charset_map_from_file that can allocate an unbounded number
9029 of objects (Bug#8318).
9031 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9032 that could (at least in theory) be that large.
9034 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9035 This is less likely to overflow, and avoids undefined behavior if
9036 overflow does occur. All callers changed. Use strtoul to scan
9037 for the unsigned long integer.
9038 (pint2hrstr): Simplify and tune code slightly.
9039 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9041 * scroll.c (do_scrolling): Work around GCC bug 48228.
9042 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9044 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9045 This also avoids a warning with gcc -Wstrict-overflow.
9046 (validate_x_resource_name): Simplify count usage.
9047 This also avoids a warning with gcc -Wstrict-overflow.
9049 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9052 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9054 * process.c (Fmake_network_process): Use socklen_t, not int,
9055 where POSIX says socklen_t is required in portable programs.
9056 This fixes a porting bug on hosts like 64-bit HP-UX, where
9057 socklen_t is wider than int (Bug#8277).
9058 (Fmake_network_process, server_accept_connection):
9059 (wait_reading_process_output, read_process_output):
9062 * process.c: Rename or move locals to avoid shadowing.
9063 (list_processes_1, Fmake_network_process):
9064 (read_process_output_error_handler, exec_sentinel_error_handler):
9065 Rename or move locals.
9066 (Fmake_network_process): Define label "retry_connect" only if needed.
9067 (Fnetwork_interface_info): Fix pointer signedness.
9068 (process_send_signal): Add cast to avoid pointer signedness problem.
9069 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9070 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9072 Make tparam.h and terminfo.c consistent.
9073 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9074 Include tparam.h instead, since it declares them.
9075 * cm.h (PC): Remove extern decl; tparam.h now does this.
9076 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9077 * terminfo.c: Include tparam.h, to check interfaces.
9078 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9079 (tparam): Adjust signature to match interface in tparam.h;
9080 this removes some undefined behavior. Check that outstring and len
9081 are zero, which they always are with Emacs.
9082 * tparam.h (PC, BC, UP): New extern decls.
9084 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9085 (xftfont_open): Rename locals to avoid shadowing.
9087 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9088 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9089 (OTF_TAG_SYM): Omit macro if not needed.
9090 (ftfont_list): Remove unused local.
9091 (get_adstyle_property, ftfont_pattern_entity):
9092 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9093 Rename locals to avoid shadowing.
9095 * xfont.c (xfont_list_family): Mark var as initialized.
9097 * xml.c (make_dom): Now static.
9099 * composite.c (composition_compute_stop_pos): Rename local to
9101 (composition_reseat_it): Remove unused locals.
9102 (find_automatic_composition, composition_adjust_point): Likewise.
9103 (composition_update_it): Mark var as initialized.
9104 (find_automatic_composition): Mark vars as initialized,
9105 with a FIXME (Bug#8290).
9107 character.h: Rename locals to avoid shadowing.
9108 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9109 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9110 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9111 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9114 * textprop.c (property_change_between_p): Remove; unused.
9116 * intervals.c (interval_start_pos): Now static.
9118 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9120 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9121 Rename locals to avoid shadowing.
9123 * sound.c (wav_play, au_play, Fplay_sound_internal):
9124 Fix pointer signedness.
9125 (alsa_choose_format): Remove unused local var.
9126 (wav_play): Initialize a variable to 0, to prevent undefined
9127 behavior (Bug#8278).
9129 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9131 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9133 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9134 clobbering (Bug#8298).
9135 * sysdep.c (sys_subshell): Likewise.
9136 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9138 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9139 This should get cleaned up, so that child_setup has the
9140 same signature on all platforms.
9142 * callproc.c (call_process_cleanup): Now static.
9143 (relocate_fd): Rename locals to avoid shadowing.
9145 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9147 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9148 not to be necessary, and produces flickering.
9150 2011-03-20 Glenn Morris <rgm@gnu.org>
9152 * config.in: Remove file.
9154 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9156 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9157 are now in src/globals.h.
9158 (syms_of_minibuf): Remove spurious & from previous change.
9160 2011-03-20 Leo Liu <sdl.web@gmail.com>
9162 * minibuf.c (completing-read-function): New variable.
9163 (completing-read-default): Rename from completing-read.
9164 (completing-read): Call completing-read-function.
9166 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9168 * xfaces.c (Fx_load_color_file):
9169 Read color file from absolute filename (bug#8250).
9171 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9173 * makefile.w32-in: Update dependencies.
9175 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9177 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9179 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9181 Fix more problems found by GCC 4.5.2's static checks.
9183 * process.c (make_serial_process_unwind, send_process_trap):
9184 (sigchld_handler): Now static.
9186 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9187 That way, the code declares only the vars that it needs.
9188 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9189 * s/cygwin.h (PTY_ITERATION): Likewise.
9190 * s/darwin.h (PTY_ITERATION): Likewise.
9191 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9193 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9194 * process.c (allocate_pty): Don't declare stb unless it's needed.
9196 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9197 (CONSTANTLIM): Remove; unused.
9198 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9199 Define only if needed.
9201 * unexelf.c (unexec): Name an expression,
9202 to avoid gcc -Wbad-function-cast warning.
9203 Use a different way to cause a compilation error if anyone uses
9204 n rather than nn, a way that does not involve shadowing.
9205 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9207 * deps.mk (unexalpha.o): Remove; unused.
9209 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9210 * unexec.h: New file.
9211 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9212 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9214 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9215 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9216 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9217 Change as necessary to match prototype in unexec.h.
9219 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9221 (back_comment, skip_chars): Mark vars as initialized.
9223 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9224 Rename locals to avoid shadowing.
9226 * lread.c (read1): Rewrite so as not to use empty "else".
9227 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9229 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9231 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9232 warning when compiling print.c.
9234 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9235 instead of using an uninitialized var.
9236 (font_sort_entities): Mark var as initialized.
9238 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9240 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9241 pointers to constants.
9242 (font_parse_fcname): Remove unused vars.
9243 (font_delete_unmatched): Now static.
9244 (font_get_spec): Remove; unused.
9245 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9246 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9247 Rename or move locals to avoid shadowing.
9249 * fns.c (require_nesting_list, require_unwind): Now static.
9250 (Ffillarray): Rename locals to avoid shadowing.
9252 * floatfns.c (domain_error2): Define only if needed.
9253 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9255 * alloc.c (mark_backtrace): Move decl from here ...
9256 * lisp.h: ... to here, so that it can be checked.
9258 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9259 (Fdefvar): Rewrite so as not to use empty "else".
9260 (lisp_indirect_variable): Name an expression,
9261 to avoid gcc -Wbad-function-cast warning.
9262 (Fdefvar): Rename locals to avoid shadowing.
9264 * callint.c (quotify_arg, quotify_args): Now static.
9265 (Fcall_interactively): Rename locals to avoid shadowing.
9266 Use const pointer when appropriate.
9268 * lisp.h (get_system_name, get_operating_system_release):
9269 Move decls here, to check interfaces.
9270 * process.c (get_operating_system_release): Move decl to lisp.h.
9271 * xrdb.c (get_system_name): Likewise.
9272 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9273 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9274 some of which prompt warnings from gcc -Wbad-function-cast.
9275 (Fformat_time_string, Fencode_time, Finsert_char):
9276 (Ftranslate_region_internal, Fformat):
9277 Rename or remove local vars to avoid shadowing.
9278 (Ftranslate_region_internal): Mark var as initialized.
9280 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9283 * lisp.h (eassert): Check that the argument compiles, even if
9284 ENABLE_CHECKING is not defined.
9286 * data.c (Findirect_variable): Name an expression, to avoid
9287 gcc -Wbad-function-cast warning.
9288 (default_value, arithcompare, arith_driver, arith_error): Now static.
9289 (store_symval_forwarding): Rename local to avoid shadowing.
9290 (Fmake_variable_buffer_local, Fmake_local_variable):
9291 Mark variables as initialized.
9292 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9294 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9295 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9296 Rename locals to avoid shadowing.
9297 (mark_stack): Move local variables into the #ifdef region where
9299 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9300 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9302 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9303 (GC_STRING_CHARS): Remove; not used.
9304 (Fmemory_limit): Cast sbrk's returned value to char *.
9306 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9307 avoids undefined behavior in theory.
9309 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9311 Use functions, not macros, for up- and down-casing (Bug#8254).
9312 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9313 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9314 to use the following functions instead of these macros.
9315 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9316 EMACS_INT, since callers assume the returned value fits in int.
9317 (upcase1): Likewise, for UPCASE_TABLE.
9318 (uppercasep, lowercasep, upcase): New static inline functions.
9319 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9320 the race-condition problem in the old DOWNCASE.
9322 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9323 Rename locals to avoid shadowing.
9324 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9325 (regex_compile, re_search_2, re_match_2_internal):
9326 Remove unused local vars.
9327 (FREE_VAR): Rewrite so as not to use empty "else",
9328 which gcc can warn about.
9329 (regex_compile, re_match_2_internal): Mark locals as initialized.
9330 (RETALLOC_IF): Define only if needed.
9331 (WORDCHAR_P): Likewise. This one is never needed, but is used
9332 only in a comment talking about a compiler bug, so put inside
9333 the #if 0 of that comment.
9334 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9335 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9338 * search.c (boyer_moore): Rename locals to avoid shadowing.
9339 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9340 (PREV_CHAR_BOUNDARY): Likewise.
9342 * search.c (simple_search): Remove unused var.
9344 * dired.c (compile_pattern): Move decl from here ...
9345 * lisp.h: ... to here, so that it can be checked.
9346 (struct re_registers): New forward decl.
9348 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9350 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9352 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9353 Rename locals to avoid shadowing.
9354 (Fvertical_motion): Mark locals as initialized.
9356 * casefiddle.c (casify_object, casify_region): Now static.
9357 (casify_region): Mark local as initialized.
9359 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9361 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9362 New macros, so that the caller can use some names other than
9363 gcpro1, gcpro2, etc.
9364 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9366 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9367 argument, for consistency with GCPRO2_VAR, etc: it is now the
9368 prefix of the variable, not the variable itself. All uses
9370 * dired.c (directory_files_internal, file_name_completion):
9371 Rename locals to avoid shadowing.
9373 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9374 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9375 dired.c's scmp function, had undefined behavior.
9376 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9377 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9378 * buffer.h: ... to here, because these macros use current_buffer,
9379 and the new implementation with inline functions needs to have
9380 current_buffer in scope now, rather than later when the macros
9382 (downcase, upcase1): New static inline functions.
9383 (DOWNCASE, UPCASE1): Reimplement using these functions.
9384 This avoids undefined behavior in expressions like
9385 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9386 from race conditions in accessing the global variables
9387 case_temp1 and case_temp2.
9388 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9389 * lisp.h (case_temp1, case_temp2): Remove their decls.
9390 * character.h (ASCII_CHAR_P): Move from here ...
9391 * lisp.h: ... to here, so that the inline functions mentioned
9394 * dired.c (directory_files_internal_unwind): Now static.
9396 * fileio.c (file_name_as_directory, directory_file_name):
9397 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9399 (file_name_as_directory): Use const pointers when appropriate.
9400 (Fexpand_file_name): Likewise. In particular, newdir might
9401 point at constant storage, so make it a const pointer.
9402 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9403 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9405 (Fset_file_times, Finsert_file_contents, auto_save_error):
9406 Rename locals to avoid shadowing.
9408 * minibuf.c (choose_minibuf_frame_1): Now static.
9409 (Ftry_completion, Fall_completions): Rename or remove locals
9412 * marker.c (bytepos_to_charpos): Remove; unused.
9414 * lisp.h (verify_bytepos, count_markers): New decls,
9415 so that gcc does not warn that these functions aren't declared.
9417 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9418 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9419 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9420 (copy_text): Remove unused local var.
9422 * filelock.c (within_one_second): Now static.
9423 (lock_file_1): Rename local to avoid shadowing.
9425 * buffer.c (fix_overlays_before): Mark locals as initialized.
9426 (fix_start_end_in_overlays): Likewise. This function should be
9427 simplified by using pointers-to-pointers, but that's a different
9429 (switch_to_buffer_1): Now static.
9430 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9431 (report_overlay_modification): Rename locals to avoid shadowing.
9433 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9434 Fix pointer signedness issue.
9435 (sys_subshell): Mark local as volatile if checking for lint,
9436 to suppress a gcc -Wclobbered warning that does not seem to be right.
9437 (MAXPATHLEN): Define only if needed.
9439 * process.c (serial_open, serial_configure): Move decls from here ...
9440 * systty.h: ... to here, so that they can be checked.
9442 * fns.c (get_random, seed_random): Move extern decls from here ...
9443 * lisp.h: ... to here, so that they can be checked.
9445 * sysdep.c (reset_io): Now static.
9446 (wait_for_termination_signal): Remove; unused.
9448 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9449 (copy_keymap_item, append_key, push_text_char_description):
9451 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9452 (DENSE_TABLE_SIZE): Remove; unused.
9453 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9454 (describe_map_tree):
9455 Rename locals to avoid shadowing.
9457 * keyboard.c: Declare functions static if they are not used elsewhere.
9458 (echo_char, echo_dash, cmd_error, top_level_2):
9459 (poll_for_input, handle_async_input): Now static.
9460 (read_char, kbd_buffer_get_event, make_lispy_position):
9461 (make_lispy_event, make_lispy_movement, apply_modifiers):
9462 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9463 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9464 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9465 (read_key_sequence, read_char): Mark locals as initialized.
9466 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9468 * keyboard.h (make_ctrl_char): New decl.
9469 (mark_kboards): Move decl here ...
9470 * alloc.c (mark_kboards): ... from here.
9472 * lisp.h (force_auto_save_soon): New decl.
9474 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9475 (DEFINE_DUMMY_FUNCTION): New macro.
9476 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9478 (main): Add casts to avoid warnings
9479 if GCC considers string literals to be constants.
9481 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9483 * dbusbind.c: Pointer signedness fixes.
9484 (xd_signature, xd_append_arg, xd_initialize):
9485 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9486 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9487 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9488 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9490 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9491 if GCC considers string literals to be constants.
9492 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9494 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9496 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9497 (print_preprocess, print_object): New macro to fix last change.
9499 * print.c (print_preprocess): Don't forget font objects.
9501 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9503 * emacs.c (USAGE3): Doc fixes.
9505 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9507 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9510 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9512 * lisp.h (VWindow_system, Qfile_name_history):
9513 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9514 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9515 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9517 * w32select.c: Don't #include "keyboard.h".
9518 (run_protected): Add extern declaration for waiting_for_input.
9520 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9521 * w32console.c (detect_input_pending, read_input_pending)
9522 (encode_terminal_code):
9523 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9524 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9525 (w32_system_caret_y, Qfile_name_history):
9526 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9527 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9528 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9529 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9530 * w32proc.c (Qlocal, report_file_error):
9531 * w32term.c (Vwindow_system, updating_frame):
9532 * w32uniscribe.c (initialized, uniscribe_font_driver):
9533 Remove unneeded extern declarations.
9535 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9537 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9539 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9541 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9542 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9543 These macros can no longer be used for assignment.
9545 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9546 Assign struct members directly, instead of using BUF_BEGV etc.
9547 (record_buffer_markers, fetch_buffer_markers): New functions for
9548 recording and fetching special buffer markers.
9549 (set_buffer_internal_1, set_buffer_temp): Use them.
9551 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9553 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9555 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9556 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9558 * xdisp.c (hscroll_window_tree):
9559 (reconsider_clip_changes): Use PT instead of BUF_PT.
9561 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9563 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9564 $(EMACS_ROOT)/lib/intprops.h.
9566 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9568 Fix more problems found by GCC 4.5.2's static checks.
9570 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9571 to unsigned char * to avoid compiler diagnostic.
9572 (xg_free_frame_widgets): Make it clear that a local variable is
9573 needed only if USE_GTK_TOOLTIP.
9574 (gdk_window_get_screen): Make it clear that this macro is needed
9575 only if USE_GTK_TOOLTIP.
9576 (int_gtk_range_get_value): New function, which avoids a diagnostic
9577 from gcc -Wbad-function-cast.
9578 (xg_set_toolkit_scroll_bar_thumb): Use it.
9579 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9580 diagnostic from gcc -Wbad-function-cast.
9581 (get_utf8_string, xg_get_file_with_chooser):
9582 Rename locals to avoid shadowing.
9583 (create_dialog): Move locals to avoid shadowing.
9585 * xgselect.c (xg_select): Remove unused var.
9587 * image.c (four_corners_best): Mark locals as initialized.
9588 (gif_load): Initialize transparent_p to zero (Bug#8238).
9589 Mark another local as initialized.
9590 (my_png_error, my_error_exit): Mark with NO_RETURN.
9592 * image.c (clear_image_cache): Now static.
9593 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9594 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9595 (x_edge_detection): Remove unnecessary cast that
9596 gcc -Wbad-function-cast diagnoses.
9597 (gif_load): Fix pointer signedness.
9598 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9599 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9601 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9603 Improve quality of tests for time stamp overflow.
9604 For example, without this patch (encode-time 0 0 0 1 1
9605 1152921504606846976) returns the obviously-bogus value (-948597
9606 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9607 reports time overflow. See
9608 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9609 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9610 * editfns.c: Include limits.h and intprops.h.
9611 (TIME_T_MIN, TIME_T_MAX): New macros.
9612 (time_overflow): Move earlier, to before first use.
9613 (hi_time, lo_time): New functions, for an accurate test for
9615 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9616 (Fget_internal_run_time): Don't assume time_t fits in int.
9617 (make_time): Use list2 instead of Fcons twice.
9618 (Fdecode_time): More accurate test for out-of-range times.
9619 (check_tm_member): New function.
9620 (Fencode_time): Use it, to test for out-of-range times.
9621 (lisp_time_argument): Don't rely on undefined left-shift and
9622 right-shift behavior when checking for time stamp overflow.
9624 * editfns.c (time_overflow): New function, refactoring common code.
9625 (Fformat_time_string, Fdecode_time, Fencode_time):
9626 (Fcurrent_time_string): Use it.
9628 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9629 * dired.c (make_time): Move to ...
9630 * editfns.c (make_time): ... here.
9631 * systime.h: Note the move.
9633 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9635 * fringe.c (update_window_fringes): Remove unused variables.
9637 * unexmacosx.c (copy_data_segment): Also copy __got section.
9640 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9642 * termcap.c [MSDOS]: Include "msdos.h".
9643 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9644 Constify `char *' arguments and their references according to
9645 prototypes in tparam.h.
9647 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9649 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9650 Adapt all references accordingly.
9652 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9654 2011-03-11 Tom Tromey <tromey@redhat.com>
9656 * buffer.c (syms_of_buffer): Remove obsolete comment.
9658 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9660 * termhooks.h (encode_terminal_code): Declare prototype.
9662 * msdos.c (encode_terminal_code): Don't declare prototype.
9664 * term.c (encode_terminal_code): Now external again, used by
9665 w32console.c and msdos.c.
9667 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9668 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9670 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9672 Fix some minor problems found by GCC 4.5.2's static checks.
9674 * fringe.c (update_window_fringes): Mark locals as initialized
9676 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9678 * alloc.c (mark_fringe_data): Move decl from here ...
9679 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9680 to check its interface.
9681 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9683 * fontset.c (free_realized_fontset): Now static.
9684 (Fset_fontset_font): Rename local to avoid shadowing.
9685 (fontset_font): Mark local as initialized.
9686 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9688 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9690 * xselect.c (x_disown_buffer_selections): Remove; not used.
9691 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9692 (x_own_selection, Fx_disown_selection_internal): Rename locals
9694 (x_handle_dnd_message): Remove local to avoid shadowing.
9696 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9697 so that the caller can use some name other than gcpro1.
9698 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9699 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9700 (Fx_backspace_delete_keys_p):
9701 Use them to avoid shadowing, and rename vars to avoid shadowing.
9702 (x_decode_color, x_set_name, x_window): Now static.
9703 (Fx_create_frame): Add braces to silence GCC warning.
9704 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9705 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9706 Remove unused locals.
9707 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9708 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9709 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9712 * xterm.h (x_mouse_leave): New decl.
9714 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9715 Remove unused functions.
9716 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9717 (x_calc_absolute_position): Now static.
9718 (XTread_socket): Don't define label "out" unless it's used.
9719 Don't declare local "event" unless it's used.
9720 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9721 unless they are used.
9722 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9723 (x_fatal_error_signal): Remove; not used.
9724 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9725 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9726 (x_error_catcher, x_connection_closed, x_error_handler):
9727 (x_error_quitter, xembed_send_message, x_iconify_frame):
9728 (my_log_handler): Rename locals to avoid shadowing.
9729 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9730 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9732 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9733 Rename or move locals to avoid shadowing.
9734 (tty_defined_color, merge_face_heights): Now static.
9735 (free_realized_faces_for_fontset): Remove; not used.
9736 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9737 does not deduce is never used uninitialized.
9738 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9739 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9741 * terminal.c (store_terminal_param): Now static.
9743 * xmenu.c (menu_highlight_callback): Now static.
9744 (set_frame_menubar): Remove unused local.
9745 (xmenu_show): Rename parameter to avoid shadowing.
9746 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9747 since they might point to immutable storage.
9748 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9749 since it's unused otherwise.
9751 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9752 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9753 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9754 avoids a gcc -Wuninitialized diagnostic.
9755 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9756 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9757 does not deduce are never used uninitialized.
9759 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9761 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9762 * window.c (window_loop, size_window):
9763 (run_window_configuration_change_hook, enlarge_window): Likewise.
9765 * window.c (display_buffer): Now static.
9766 (size_window): Mark variables that gcc -Wuninitialized
9767 does not deduce are never used uninitialized.
9768 * window.h (check_all_windows): New decl, to forestall
9769 gcc -Wmissing-prototypes diagnostic.
9770 * dispextern.h (bidi_dump_cached_states): Likewise.
9772 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9774 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9776 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9777 and to avoid gcc -Wuninitialized warning.
9778 (load_charset_map): Mark variables that gcc -Wuninitialized
9779 does not deduce are never used uninitialized.
9780 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9782 * coding.c (coding_set_source, coding_set_destination):
9783 Use "else { /* comment */ }" rather than "else /* comment */;"
9784 for clarity, and to avoid gcc -Wempty-body warning.
9785 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9786 a block, when the outer 'i' will do.
9787 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9788 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9789 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9790 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9791 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9792 Rename locals to avoid shadowing.
9793 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9794 * coding.c (emacs_mule_char, encode_invocation_designation):
9795 Now static, since they're not used elsewhere.
9796 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9797 (decode_coding_object, encode_coding_object, detect_coding_system):
9798 (decode_coding_emacs_mule): Mark variables that gcc
9799 -Wuninitialized does not deduce are never used uninitialized.
9800 (detect_coding_iso_2022): Initialize a local variable that might
9801 be used uninitialized. Leave a FIXME because it's not clear that
9802 this initialization is needed. (Bug#8211)
9803 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9804 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9805 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9806 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9807 Remove unused macros.
9809 * category.c (hash_get_category_set): Remove unused local var.
9810 (copy_category_table): Now static, since it's not used elsewhere.
9811 * character.c (string_count_byte8): Likewise.
9813 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9814 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9816 * chartab.c (copy_sub_char_table): Now static, since it's not used
9818 (sub_char_table_ref_and_range, char_table_ref_and_range):
9819 Rename locals to avoid shadowing.
9820 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9822 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9823 (BIDI_BOB): Remove unused macro.
9825 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9826 deduce are never used uninitialized.
9827 * term.c (encode_terminal_code): Likewise.
9829 * term.c (encode_terminal_code): Now static. Remove unused local.
9831 * tparam.h: New file.
9832 * term.c, tparam.h: Include it.
9833 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9834 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9835 Move these decls to tparam.h, and make them agree with what
9836 is actually in tparam.c. The previous trick of using incompatible
9837 decls in different modules does not conform to the C standard.
9838 All callers of tparam changed to use tparam's actual API.
9839 * tparam.c (tparam1, tparam, tgoto):
9840 Use const pointers where appropriate.
9842 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9843 * cm.h (struct cm): Likewise.
9844 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9845 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9846 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9847 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9848 (turn_on_face, init_tty): Likewise.
9849 * termchar.h (struct tty_display_info): Likewise.
9851 * term.c (term_mouse_position): Rename local to avoid shadowing.
9853 * alloc.c (mark_ttys): Move decl from here ...
9854 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9856 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9858 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9860 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9862 * search.c (compile_pattern_1): Remove argument regp, unused since
9863 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9864 (compile_pattern): Don't pass it.
9866 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9868 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9869 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9871 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9873 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9875 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9876 gdk_window_get_screen, gdk_window_get_geometry,
9877 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9878 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9879 (xg_get_pixbuf_from_pixmap): New function.
9880 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9881 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9882 Call xg_get_pixbuf_from_pixmap instead of
9883 gdk_pixbuf_get_from_drawable.
9884 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9885 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9886 (xg_check_special_colors): Use GtkStyleContext and its functions
9888 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9889 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9890 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9891 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9892 Call gtk_widget_get_preferred_size.
9893 (xg_frame_resized): gdk_window_get_geometry only takes 5
9895 (xg_win_to_widget, xg_event_is_for_menubar):
9896 Call gdk_x11_window_lookup_for_display.
9897 (xg_set_widget_bg): New function.
9898 (delete_cb): New function.
9899 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9900 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9901 (xg_set_background_color): Call xg_set_widget_bg.
9902 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9903 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9904 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9905 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9907 (update_frame_tool_bar): Call gtk_widget_hide.
9908 (xg_initialize): Use GDK_KEY_g.
9910 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9912 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9914 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9915 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9916 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9918 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9920 * w32xfns.c (select_palette): Check success of RealizePalette against
9921 GDI_ERROR, not zero.
9923 See ChangeLog.11 for earlier changes.
9929 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9931 This file is part of GNU Emacs.
9933 GNU Emacs is free software: you can redistribute it and/or modify
9934 it under the terms of the GNU General Public License as published by
9935 the Free Software Foundation, either version 3 of the License, or
9936 (at your option) any later version.
9938 GNU Emacs is distributed in the hope that it will be useful,
9939 but WITHOUT ANY WARRANTY; without even the implied warranty of
9940 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9941 GNU General Public License for more details.
9943 You should have received a copy of the GNU General Public License
9944 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.