1 2012-04-09 Glenn Morris <rgm@gnu.org>
3 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4 preparation for dumping it with emacs. (Bug#4789)
5 (leimdir): New variable.
6 ($(leimdir)/leim-list.el): New rule.
7 (emacs$(EXEEXT)): Depend on leim-list.el.
9 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
10 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
11 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
13 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
15 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
18 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
20 * xml.c (init_libxml2_functions) [WINDOWSNT]:
21 Remove unused local variable.
23 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
25 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
26 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
27 (mark_memory): Mark Lisp_Objects only if pointers might hide in
28 objects, as mark_maybe_pointer will catch them otherwise.
29 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
30 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
32 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
34 Fix typo that broke non-Windows builds.
35 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
37 2012-04-07 Eli Zaretskii <eliz@gnu.org>
39 Support building on MS-Windows with libxml2.
41 * makefile.w32-in (OBJ2): Add xml.$(O).
42 (GLOBAL_SOURCES): Add xml.c.
43 ($(BLD)/xml.$(O)): New dependency list.
45 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
46 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
47 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
48 [!WINDOWSNT]: New macros.
49 (init_libxml2_functions, libxml2_loaded_p): New functions.
50 (parse_region): Call fn_xmlCheckVersion instead of using the macro
51 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
52 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
53 Calls xmlCleanupParser only if libxml2 was loaded (or statically
55 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
56 init_libxml2_functions before calling libxml2 functions.
57 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
59 * emacs.c: Don't include libxml/parser.h.
60 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
61 xmlCleanupParser directly.
63 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
65 2012-04-07 Eli Zaretskii <eliz@gnu.org>
67 * indent.c (Fvertical_motion): If there is a display string at
68 point, use it.vpos to compute how many lines to backtrack after
69 move_it_to point. (Bug#11133)
71 2012-04-06 Eli Zaretskii <eliz@gnu.org>
73 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
74 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
75 about subtle differences between FETCH_CHAR* and STRING_CHAR*
76 macros related to unification of CJK characters. For the details,
77 see the discussion following the message here:
78 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
80 2012-04-04 Chong Yidong <cyd@gnu.org>
82 * keyboard.c (Vdelayed_warnings_list): Doc fix.
84 2012-04-01 Eli Zaretskii <eliz@gnu.org>
86 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
87 instead of alloca. (Bug#11138)
89 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
91 * w32menu.c (is_simple_dialog): Properly check lisp types.
94 2012-03-31 Eli Zaretskii <eliz@gnu.org>
96 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
97 position we get to after a call to move_it_to fails the
98 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
99 only if we wind up in a string from display property. (Bug#11063)
101 * window.c (Fdelete_other_windows_internal): Invalidate the row
102 and column information about mouse highlight, so that redisplay
103 restores it after reallocating the glyph matrices. (Bug#7464)
105 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
106 string comes from a `display' text property, use the buffer
107 position of that property as if we actually saw that position in
109 (move_it_by_lines): Remove the assertion that
110 "it->current_x == 0 && it->hpos == 0" which can be legitimately
111 violated when there's a before-string at the beginning of a line.
114 2012-03-30 Eli Zaretskii <eliz@gnu.org>
116 * xdisp.c (append_space_for_newline): If the default face was
117 remapped, use the remapped face for the appended newline.
118 (extend_face_to_end_of_line): Use the remapped default face for
119 extending the face to the end of the line.
120 (display_line): Call extend_face_to_end_of_line when the default
121 face was remapped. (Bug#11068)
123 2012-03-29 Eli Zaretskii <eliz@gnu.org>
125 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
127 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
129 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
131 2012-03-27 Glenn Morris <rgm@gnu.org>
133 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
136 2012-03-26 Kenichi Handa <handa@m17n.org>
138 * dispextern.h (struct glyph): Fix previous change. Change the
139 bit length of glyphless.ch to 25 (Bug#11082).
141 2012-03-26 Chong Yidong <cyd@gnu.org>
143 * keyboard.c (Vselection_inhibit_update_commands): New variable.
144 (command_loop_1): Use it; inhibit selection update for
145 handle-select-window too (Bug#8996).
147 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
149 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
151 2012-03-25 Kenichi Handa <handa@m17n.org>
153 * dispextern.h (struct glyph): Change the bit length of
154 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
156 2012-03-24 Eli Zaretskii <eliz@gnu.org>
158 * s/ms-w32.h (tzname): Include time.h before redirecting to
159 _tzname. Fixes the MSVC build. (Bug#9960)
161 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
163 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
166 * xterm.c (XTread_socket): Only modify handling_signal if
167 !SYNC_INPUT. (Bug#11080)
169 2012-03-23 Eli Zaretskii <eliz@gnu.org>
171 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
172 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
173 when fetching a multibyte character consumes more bytes than
174 CHAR_BYTES returns, due to unification of CJK characters in
175 string_char. (Bug#11073)
177 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
179 * process.c (wait_reading_process_output): Handle pty disconnect
180 by refraining from sending oneself a SIGCHLD (bug#10933).
182 2012-03-22 Chong Yidong <cyd@gnu.org>
184 * dispextern.h (struct it): New member string_from_prefix_prop_p.
186 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
187 Mark string as coming from a prefix property.
188 (handle_face_prop): Use default face for prefix strings (Bug#4281).
189 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
191 2012-03-21 Chong Yidong <cyd@gnu.org>
193 * xfaces.c (Vface_remapping_alist): Doc fix.
195 2012-03-20 Eli Zaretskii <eliz@gnu.org>
197 * w32proc.c (Fw32_set_console_codepage)
198 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
201 2012-03-20 Chong Yidong <cyd@gnu.org>
203 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
204 to reflect default non-nil value of redisplay-dont-pause.
206 2012-03-19 Kenichi Handa <handa@m17n.org>
208 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
209 it fit in a valid range (Bug#11003).
211 2012-03-18 Eli Zaretskii <eliz@gnu.org>
213 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
214 that is not from display property, accept the row as a "cursor
215 row" if one of the string's character has a non-nil `cursor'
216 property. Fixes cursor positioning when there are newlines in
217 overlay strings, e.g. in icomplete.el. (Bug#11035)
219 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
221 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
223 2012-03-12 Chong Yidong <cyd@gnu.org>
225 * eval.c (inhibit_lisp_code): Rename from
226 inhibit_window_configuration_change_hook; move from window.c.
228 * xfns.c (unwind_create_frame_1, Fx_create_frame):
229 * window.c (run_window_configuration_change_hook)
230 (syms_of_window): Callers changed.
232 2012-03-11 Chong Yidong <cyd@gnu.org>
234 * keymap.c (Fkey_description): Doc fix (Bug#9700).
236 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
238 2012-03-10 Chong Yidong <cyd@gnu.org>
240 * frame.c (other_visible_frames): Don't assume the selected frame
241 is visible (Bug#10955).
243 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
245 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
247 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
249 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
250 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
253 2012-03-03 Glenn Morris <rgm@gnu.org>
255 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
257 2012-03-02 Eli Zaretskii <eliz@gnu.org>
259 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
260 position past the first glyph_row that ends at ZV. (Bug#10902)
261 (redisplay_window, next_element_from_string): Fix typos in
263 (redisplay_window): Pass to move_it_vertically the margin in
264 pixels, not in screen lines.
266 2012-03-02 Glenn Morris <rgm@gnu.org>
268 * buffer.c (buffer-list-update-hook): Doc fix.
270 2012-02-29 Eli Zaretskii <eliz@gnu.org>
272 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
273 push_it before setting up the iterator for the first overlay
274 string, even if we have an empty string loaded.
275 (next_overlay_string): If there's an empty string on the iterator
276 stack, pop the stack. (Bug#10903)
278 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
280 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
281 Suggested by Stefan Monnier in
282 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
283 * alloc.c (widen_to_Lisp_Object): New static function.
284 (mark_memory): Also mark Lisp_Objects by fetching pointer words
285 and widening them to Lisp_Objects. This would work even if
286 USE_LSB_TAG is defined and wide integers are used, which might
287 happen in a future version of Emacs.
289 2012-02-25 Chong Yidong <cyd@gnu.org>
291 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
294 * xselect.c (Fx_selection_exists_p): Doc fix.
295 (x_clipboard_manager_save_all): Print an informative message
296 before saving to clipboard manager.
298 2012-02-24 Chong Yidong <cyd@gnu.org>
300 * keyboard.c (process_special_events): Handle all X selection
301 requests in kbd_buffer, not just the next one (Bug#8869).
303 2012-02-23 Chong Yidong <cyd@gnu.org>
305 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
306 call when setting menu-bar-lines and tool-bar-lines parameters.
307 (unwind_create_frame_1): New helper function.
309 * window.c (inhibit_window_configuration_change_hook): New var.
310 (run_window_configuration_change_hook): Obey it.
311 (syms_of_window): Initialize it.
313 2012-02-22 Chong Yidong <cyd@gnu.org>
315 * xterm.c (x_draw_image_relief): Add missing type check for
316 Vtool_bar_button_margin (Bug#10743).
318 2012-02-21 Chong Yidong <cyd@gnu.org>
320 * fileio.c (Vfile_name_handler_alist): Doc fix.
322 * buffer.c (Fget_file_buffer): Protect against invalid file
323 handler return value.
325 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
327 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
328 when computing $valmask.
330 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
331 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
332 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
333 It's useless in that case, and it can cause problems on hosts
334 that allocate halves of EMACS_INT values separately.
335 Reported by Dan Horák. Diagnosed by Andreas Schwab in
336 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
337 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
338 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
339 it avoids undefined behavior on hosts where shifting right by more
340 than the word width has undefined behavior.
342 2012-02-19 Chong Yidong <cyd@gnu.org>
344 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
345 (Funhandled_file_name_directory, Ffile_name_as_directory)
346 (Fdirectory_file_name, Fexpand_file_name)
347 (Fsubstitute_in_file_name): Protect against invalid file handler
348 return values (Bug#10845).
350 2012-02-18 Eli Zaretskii <eliz@gnu.org>
352 * .gdbinit (pitx): Fix incorrect references to fields of the
355 2012-02-17 Chong Yidong <cyd@gnu.org>
357 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
359 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
361 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
362 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
364 2012-02-15 Chong Yidong <cyd@gnu.org>
366 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
367 marked as special. Also, starting docstrings with * is obsolete.
369 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
371 * gnutls.c (emacs_gnutls_write): Fix last change.
373 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
375 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
378 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
380 * keymap.c (Fsingle_key_description): Handle char ranges.
382 2012-02-12 Chong Yidong <cyd@gnu.org>
384 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
385 as that creates a dangerous corner case.
387 * window.c (Fdelete_window_internal): Invalidate the mouse
388 highlight (Bug#9904).
390 2012-02-12 Glenn Morris <rgm@gnu.org>
392 * xselect.c (Fx_own_selection_internal)
393 (Fx_get_selection_internal, Fx_disown_selection_internal)
394 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
395 * nsselect.m (Fx_own_selection_internal)
396 (Fx_disown_selection_internal, Fx_selection_exists_p)
397 (Fx_selection_owner_p, Fx_get_selection_internal):
398 Sync docs and argument specs with the xselect.c versions.
400 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
402 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
404 2012-02-11 Eli Zaretskii <eliz@gnu.org>
406 * w32select.c (Fx_selection_exists_p): Sync doc string and
407 argument list with xselect.c. (Bug#10783)
409 * w16select.c (Fx_selection_exists_p): Sync doc string and
410 argument list with xselect.c. (Bug#10783)
412 2012-02-10 Glenn Morris <rgm@gnu.org>
414 * fns.c (Fsecure_hash): Doc fix.
416 2012-02-09 Kenichi Handa <handa@m17n.org>
418 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
420 2012-02-07 Chong Yidong <cyd@gnu.org>
422 * buffer.c (Fbuffer_local_variables)
423 (buffer_lisp_local_variables): Handle unbound vars correctly;
424 don't let Qunbound leak into Lisp.
426 2012-02-07 Glenn Morris <rgm@gnu.org>
428 * image.c (Fimagemagick_types): Doc fix.
430 * image.c (imagemagick-render-type): Change it from a lisp object
431 to an integer. Move the doc here from the lisp manual.
432 Treat all values not equal to 0 the same.
434 2012-02-06 Chong Yidong <cyd@gnu.org>
436 * doc.c (store_function_docstring): Avoid applying docstring of
437 alias to base function (Bug#2603).
439 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
441 * .gdbinit (pp1, pv1): Remove redundant defines.
444 2012-02-04 Chong Yidong <cyd@gnu.org>
446 * nsterm.m: Declare a global (Bug#10694).
448 2012-02-04 Eli Zaretskii <eliz@gnu.org>
450 * w32.c (get_emacs_configuration_options):
451 Include --enable-checking, if specified, in the return value.
453 2012-02-04 Martin Rudalics <rudalics@gmx.at>
455 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
456 after rounding frame sizes. (Bug#9723)
458 2012-02-04 Eli Zaretskii <eliz@gnu.org>
460 * keyboard.c (adjust_point_for_property): Don't position point
461 before BEGV. (Bug#10696)
463 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
465 Handle overflow when computing char display width (Bug#9496).
466 * character.c (char_width): Return EMACS_INT, not int.
467 (char_width, c_string_width): Check for overflow when
468 computing the width; this is possible now that individual
469 characters can have unbounded width. Problem introduced
470 by merge from Emacs 23 on 2012-01-19.
472 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
474 * dbusbind.c (Fdbus_register_method): Mention the return value
475 :ignore in the docstring.
477 2012-02-02 Glenn Morris <rgm@gnu.org>
479 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
481 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
482 Unconditionally set to t. (Bug#10673)
483 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
484 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
485 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
487 2012-02-02 Kenichi Handa <handa@m17n.org>
489 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
490 0, do not call append_composite_glyph.
492 2012-02-02 Kenichi Handa <handa@m17n.org>
494 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
496 (x_produce_glyphs): If the component of a composition is a null
497 string, set it->pixel_width to 1 to avoid zero-width glyph.
499 2012-02-01 Eli Zaretskii <eliz@gnu.org>
501 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
502 first 2 arguments are identical. This makes inserting large
503 output from a subprocess an order of magnitude faster on
504 MS-Windows, where all sbrk'ed memory is always contiguous.
506 2012-01-31 Glenn Morris <rgm@gnu.org>
508 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
509 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
510 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
512 2012-01-29 Glenn Morris <rgm@gnu.org>
514 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
516 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
518 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
520 2012-01-28 Chong Yidong <cyd@gnu.org>
522 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
524 2012-01-26 Chong Yidong <cyd@gnu.org>
526 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
528 * search.c (Fsearch_forward, Fsearch_backward): Document negative
529 repeat counts (Bug#10507).
531 2012-01-26 Glenn Morris <rgm@gnu.org>
533 * lread.c (syms_of_lread): Doc fix.
535 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
537 * coding.c (encode_designation_at_bol): Change return value to
540 2012-01-25 Chong Yidong <cyd@gnu.org>
542 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
544 2012-01-21 Chong Yidong <cyd@gnu.org>
546 * floatfns.c (Fcopysign): Make the second argument non-optional,
547 since nil is not allowed anyway.
549 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
551 * process.c (read_process_output): Use p instead of XPROCESS (proc).
552 (send_process): Likewise.
554 2012-01-19 Martin Rudalics <rudalics@gmx.at>
556 * window.c (save_window_save, Fcurrent_window_configuration)
557 (Vwindow_persistent_parameters): Do not use Qstate.
560 2012-01-19 Kenichi Handa <handa@m17n.org>
562 * character.c (char_width): New function.
563 (Fchar_width, c_string_width, lisp_string_width):
564 Use char_width (Bug#9496).
566 2012-01-16 Martin Rudalics <rudalics@gmx.at>
568 * window.c (Vwindow_persistent_parameters): New variable.
569 (Fset_window_configuration, save_window_save): Handle persistent
572 2012-01-14 Eli Zaretskii <eliz@gnu.org>
574 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
575 thrashing the stack of the thread. (Bug#9087)
577 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
579 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
581 2012-01-11 Eli Zaretskii <eliz@gnu.org>
583 * xdisp.c (rows_from_pos_range): Handle the case where the
584 highlight ends on a newline. (Bug#10464)
585 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
586 he end column for display of highlight that ends on a newline
589 2012-01-11 Glenn Morris <rgm@gnu.org>
591 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
592 from load-path also when installation-directory is nil. (Bug#10208)
594 2012-01-10 Glenn Morris <rgm@gnu.org>
596 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
598 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
599 Update template values to be closer to their typical values these days.
601 2012-01-09 Eli Zaretskii <eliz@gnu.org>
603 * xdisp.c (rows_from_pos_range): Accept additional argument
604 DISP_STRING, and accept any glyph in a row whose object is that
605 string as eligible for mouse highlight. Fixes mouse highlight of
606 display strings from overlays. (Bug#10464)
608 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
610 emacs: fix an auto-save permissions race condition (Bug#10400)
611 * fileio.c (auto_saving_dir_umask): New static var.
612 (Fmake_directory_internal): Use it.
613 (do_auto_save_make_dir): Set it, instead of invoking chmod after
614 creating the directory. The old code temporarily assigns
615 too-generous permissions to the directory.
616 (do_auto_save_eh): Clear it.
617 (Fdo_auto_save): Catch all errors, not just file errors, so
618 that the var is always cleared.
620 2012-01-07 Eli Zaretskii <eliz@gnu.org>
622 * search.c (scan_buffer): Pass character positions to
623 know_region_cache, not byte positions. (Bug#6540)
625 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
627 * w32.c (sys_rename): Report EXDEV when rename of a directory
628 fails because the target is on another logical disk. (Bug#10284)
630 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
632 * xterm.c (x_embed_request_focus): New function.
634 * xterm.h: Add prototype.
636 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
638 2012-01-05 Glenn Morris <rgm@gnu.org>
640 * emacs.c (emacs_copyright): Update short copyright year to 2012.
642 2012-01-01 Eli Zaretskii <eliz@gnu.org>
644 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
645 Load gnutls_transport_set_lowat only if GnuTLS version is below
647 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
648 GnuTLS versions below 2.11.1.
650 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
652 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
653 to the doc string advising against its use for altering the way
654 windows are scrolled.
656 2011-12-28 Kenichi Handa <handa@m17n.org>
658 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
659 coding-system ASCII compatible only when it does not produce BOM
660 on encoding (Bug#10383).
662 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
664 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
666 (create_and_show_popup_menu): Always use menu_position_func for
669 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
671 * callint.c (Fcall_interactively): Don't truncate prompt string.
673 2011-12-23 Eli Zaretskii <eliz@gnu.org>
675 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
676 property that ends at ZV, so that the bidi iteration could be
677 resumed from there (after widening). (Bug#10360)
679 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
681 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
683 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
685 * nsterm.m (x_free_frame_resources):
686 Release f->output_data.ns->miniimage.
687 (ns_index_color): Fix indentation. Do not retain
688 color_table->colors[i].
690 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
693 * nsfns.m (x_set_background_color): Assign return value from
694 ns_index_color to face-background instead of NSColor*.
695 (ns_implicitly_set_icon_type): Fix indentation.
696 Change assignment in for loop to comparison.
698 * emacs.c (ns_pool): New variable.
699 (main): Assign ns_pool.
700 (Fkill_emacs): Call ns_release_autorelease_pool.
702 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
703 autorelease fdesc, release fdAttrs and tdict.
704 (ns_get_covering_families): Release charset.
705 (ns_findfonts): Release NSFontDescriptor created with new.
706 (ns_uni_to_glyphs): Fix indentation.
707 (setString): Release attrStr before assigning new value.
709 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
711 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
713 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
714 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
716 2011-12-18 David Reitter <reitter@cmu.edu>
718 * nsterm.m (ns_term_init): Subscribe for notifications
719 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
720 to method trackingNotification in EmacsMenu.
722 * nsmenu.m (trackingMenu): New variable.
723 (trackingNotification): New method (from Aquamacs).
724 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
725 from Aquamacs (Bug#7030).
727 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
729 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
730 (symbol_to_nsstring): Fix indentation.
731 (ns_symbol_to_pb): New function.
732 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
733 (Fns_rotate_cut_buffers_internal): Remove.
734 (Fns_store_selection_internal): Rename from
735 Fns_store_cut_buffer_internal.
736 (ns_get_foreign_selection, Fx_own_selection_internal)
737 (Fx_disown_selection_internal, Fx_selection_exists_p)
738 (Fns_get_selection_internal, Fns_store_selection_internal):
739 Use ns_symbol_to_pb and check if return value is nil.
740 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
741 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
742 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
743 renamed to Sns_store_selection_internal.
744 (ns_handle_selection_request): Move code to Fx_own_selection_internal
745 and remove this function.
746 (ns_handle_selection_clear): Remove, never used.
747 (Fx_own_selection_internal): Move code from ns_handle_selection_request
750 2011-12-17 Ken Brown <kbrown@cornell.edu>
752 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
753 GID is unknown (Bug#10257).
755 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
757 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
758 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
759 which caused a build failure on GNU/Linux IA-64. This problem was
760 introduced by my 2011-10-07 patch.
762 2011-12-15 Juri Linkov <juri@jurta.org>
764 * image.c (imagemagick_error): New function. (Bug#10112)
765 (imagemagick_load_image): Comment out `MagickSetResolution' call.
766 Use `imagemagick_error' where ImageMagick functions return
768 (Fimagemagick_types): Add `Fnreverse' to return the list in the
771 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
773 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
774 fill background (Bug#8992).
776 2011-12-13 Martin Rudalics <rudalics@gmx.at>
778 * window.c (Vwindow_combination_resize)
779 (Vwindow_combination_limit): Use t instead of non-nil in
781 (Vrecenter_redisplay): Add first sentence of doc-string on
783 (Frecenter): Fix doc-string typo.
785 2011-12-11 Kenichi Handa <handa@m17n.org>
787 * coding.c (Funencodable_char_position): Pay attention to the
788 buffer text relocation (Bug#9389).
790 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
792 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
793 gtk_init (Bug#10100).
795 2011-12-10 Eli Zaretskii <eliz@gnu.org>
797 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
798 IT->string is nil. (Bug#10263)
800 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
802 * nsterm.h (x_free_frame_resources): Declare.
804 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
805 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
807 * nsterm.h (ns_get_defaults_value): Declare.
809 * nsterm.m (ns_default): Call ns_get_defaults_value.
811 2011-12-09 Eli Zaretskii <eliz@gnu.org>
813 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
816 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
818 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
819 that where the value of an _OBJC_* symbol points to is in the .bss
822 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
824 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
825 after the loop to call ccl_driver at least once (Bug#8619).
827 2011-12-08 Kenichi Handa <handa@m17n.org>
829 * ftfont.c (get_adstyle_property): Fix previous change
832 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
834 * w32.c (init_environment): If no_site_lisp, remove site-lisp
835 dirs from the default value of EMACSLOADPATH (bug#10208).
837 2011-12-07 Glenn Morris <rgm@gnu.org>
839 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
840 installation and source directories as well. (Bug#10208)
842 2011-12-06 Chong Yidong <cyd@gnu.org>
844 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
846 2011-12-06 Glenn Morris <rgm@gnu.org>
848 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
849 as an error, not just -1. (Bug#10217)
851 2011-12-05 Chong Yidong <cyd@gnu.org>
853 * keyboard.c (process_special_events): New function.
854 (swallow_events, Finput_pending_p): Use it (Bug#10195).
856 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
858 * coding.c (encode_designation_at_bol): Don't use uninitialized
859 local variable (Bug#9318).
861 2011-12-05 Kenichi Handa <handa@m17n.org>
863 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
864 return Qnil (Bug#8046, Bug#10193).
866 2011-12-05 Kenichi Handa <handa@m17n.org>
868 * coding.c (encode_designation_at_bol): New args charbuf_end and
869 dst. Return the number of produced bytes. Callers changed.
870 (coding_set_source): Return how many bytes coding->source was
872 (coding_set_destination): Return how many bytes
873 coding->destination was relocated.
874 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
875 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
877 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
879 * coding.c (CODING_CHAR_CHARSET_P): New macro.
880 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
883 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
885 The following changes are to fix Bug#9318.
887 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
888 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
889 (encode_coding_iso_2022, encode_coding_sjis)
890 (encode_coding_big5, encode_coding_charset): Use the above macros.
892 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
894 * lisp.h (process_quit_flag): Fix external declaration.
896 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
898 Don't macro-inline non-performance-critical code.
899 * eval.c (process_quit_flag): New function.
900 * lisp.h (QUIT): Use it.
902 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
904 * nsfns.m (get_geometry_from_preferences): New function.
905 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
907 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
909 * emacs.c (Qkill_emacs): Define.
910 (syms_of_emacs): Initialize it.
911 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
912 Qquit_flag to `kill-emacs' instead.
913 (quit_throw_to_read_char): Add parameter `from_signal'.
914 All callers changed. Call Fkill_emacs if requested and safe.
915 * lisp.h (QUIT): Call Fkill_emacs if requested.
917 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
919 * widget.c (update_wm_hints): Return if wmshell is null.
920 (widget_update_wm_size_hints): New function.
922 * widget.h (widget_update_wm_size_hints): Declare.
924 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
925 widget_update_wm_size_hints (Bug#10104).
927 2011-12-03 Eli Zaretskii <eliz@gnu.org>
929 * xdisp.c (handle_invisible_prop): If the invisible text ends just
930 before a newline, prepare the bidi iterator for consuming the
931 newline, and keep the current paragraph direction. (Bug#10183)
932 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
934 2011-12-02 Juri Linkov <juri@jurta.org>
936 * search.c (Fword_search_regexp): New Lisp function created from
937 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
938 (Fword_search_backward, Fword_search_forward)
939 (Fword_search_backward_lax, Fword_search_forward_lax):
940 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
941 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
943 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
945 * fileio.c (Finsert_file_contents): Move after-change-function call
946 to before the "handled:" label, since all "goto handled" appear in
947 cases where the *-change-functions have already been properly called
950 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
952 * keyboard.c (interrupt_signal): Don't call kill-emacs when
953 waiting for input. (Bug#10169)
955 2011-11-30 Eli Zaretskii <eliz@gnu.org>
957 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
958 verifies glyph row's hash code--we have just reallocated the
959 glyphs, so their contents can be complete garbage. (Bug#10164)
961 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
963 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
965 2011-11-30 Eli Zaretskii <eliz@gnu.org>
967 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
968 attributes are tested _before_ calling verify_row_hash, to protect
969 against GCC re-ordering of the tests. (Bug#10164)
971 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
973 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
975 * xterm.c (handle_one_xevent): Only set async_visible and friends
976 if net_wm_state_hidden_seen is non-zero (Bug#10002)
977 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
978 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
980 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
982 Remove GCPRO-related macros that exist only to avoid shadowing locals.
983 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
984 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
985 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
986 All uses changed to use GCPRO1 etc.
987 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
988 Revert to old implementation (i.e., before 2011-03-11).
990 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
992 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
993 of scroll runs so as to avoid assigning disabled bogus rows and
994 unnecessary graphics copy operations.
996 2011-11-27 Eli Zaretskii <eliz@gnu.org>
998 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
999 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1000 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1001 (malloc, free, realloc, calloc): Redirect to e_* only when
1004 * lisp.h (GCTYPEBITS): Move before first use.
1005 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1006 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1007 this macro definition.
1009 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1012 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1014 * gtkutil.c (xg_create_frame_widgets):
1015 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1016 present with Gtk+ 2.0.
1018 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1020 * fileio.c (Finsert_file_contents): Undo previous change; see
1021 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1023 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1025 Rename locals to avoid shadowing.
1026 * fileio.c (Finsert_file_contents):
1027 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1028 * process.c (wait_reading_process_output):
1029 Rename inner 'proc' to 'p' to avoid shadowing.
1030 Indent for consistency with usual Emacs style.
1032 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1034 * xdisp.c (redisplay_window): If cursor row is not fully visible
1035 after recentering, and scroll-conservatively is set to a large
1036 number, scroll window by a few more lines to make the cursor fully
1037 visible and out of scroll-margin. (Bug#10105)
1038 (start_display): Don't move to the next line if the display should
1039 start at a newline that is part of a display vector or an overlay
1042 2011-11-24 Juri Linkov <juri@jurta.org>
1044 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1045 after the `MagickPingImage' call. (Bug#10112)
1047 2011-11-23 Chong Yidong <cyd@gnu.org>
1049 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1051 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1053 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1054 making another buffer current. (Bug#10114)
1056 2011-11-23 Glenn Morris <rgm@gnu.org>
1058 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1060 2011-11-23 Chong Yidong <cyd@gnu.org>
1062 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1063 using it (Bug#5984).
1065 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1067 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1068 and header-lines, as they don't have one computed for them.
1071 * .gdbinit (prow): Make displayed values more self-explaining.
1072 Add row's hash code.
1074 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1076 * process.c (wait_reading_process_output): Fix asynchrounous
1077 GnuTLS socket handling on some versions of the GnuTLS library.
1078 (wait_reading_process_output): Add comment and URL.
1080 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1082 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1084 2011-11-21 Chong Yidong <cyd@gnu.org>
1086 * window.c (Fnext_window, Fprevious_window): Doc fix.
1088 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1090 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1092 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1094 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1096 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1098 * window.c (Fset_window_combination_limit): Rename argument
1100 (Vwindow_combination_limit): Remove "status" from doc-string.
1102 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1104 * m/ibms390.h: Remove.
1105 * m/ibms390x.h: Don't include "ibms390.h".
1107 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1109 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1110 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1112 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1114 * casetab.c (Fset_case_table):
1115 * charset.c (Fcharset_after): Fix typos.
1117 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1119 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1120 Otherwise, valgrind does not work on some platforms.
1121 Problem reported by Andreas Schwab in
1122 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1123 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1124 is set, removing the need for VIRT_ADDRESS_VARIES.
1125 (PURE_P): Use a more-efficient implementation that needs just one
1126 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1127 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1128 to 4 (xorl, subq, cmpq, setbe).
1129 * alloc.c (pure): Always extern now, since that's the
1130 VIRT_ADDR_VARIES behavior.
1131 (PURE_POINTER_P): Use a single comparison, not two, for
1132 consistency with the new puresize.h.
1133 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1134 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1135 Remove VIRT_ADDR_VARIES no longer needed.
1137 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1139 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1140 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1141 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1142 behave as if the cursor position were at the window margin.
1144 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1145 and the cursor position is out of bounds, behave as if the cursor
1146 position were at the window margin. (Bug#10075)
1148 2011-11-18 Chong Yidong <cyd@gnu.org>
1150 * window.c (Fwindow_combination_limit): Make first argument
1151 non-optional, since it is meaningless for live windows like the
1154 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1156 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1158 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1160 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1161 (graft_intervals_into_buffer): Simplify.
1163 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1165 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1166 hash values of the two rows.
1167 (copy_row_except_pointers): Preserve the used[] arrays and the
1168 hash values of the two rows. (Bug#10035)
1169 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1171 * xdisp.c (row_hash): New function, body extracted from
1172 compute_line_metrics.
1173 (compute_line_metrics): Call row_hash, instead of computing the
1176 * dispnew.c (verify_row_hash): Call row_hash for computing the
1177 hash code of a row, instead of duplicating code from xdisp.c.
1179 * dispextern.h (row_hash): Add prototype.
1181 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1183 * frame.c (delete_frame): Don't delete the terminal when the last
1184 X frame is closed if emacs is built with GTK toolkit.
1186 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1188 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1190 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1192 * window.c (Vwindow_splits): Rename to
1193 Vwindow_combination_resize. Suggested by Juri Linkov.
1194 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1197 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1199 * nsfns.m (Fns_font_name):
1200 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1202 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1204 * window.h (window): Rename slot "nest" to "combination_limit".
1205 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1206 (Fset_window_nest): Rename to Fset_window_combination_limit.
1207 (Vwindow_nest): Rename to Vwindow_combination_limit.
1208 (recombine_windows, make_parent_window, make_window)
1209 (Fsplit_window_internal, saved_window)
1210 (Fset_window_configuration, save_window_save): Rename all
1211 occurrences of window_nest to window_combination_limit.
1213 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1215 * image.c (imagemagick_load_image): Fix typo.
1217 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1219 * xdisp.c (display_line): Move the call to
1220 highlight_trailing_whitespace before the call to
1221 compute_line_metrics, since the latter needs to see the final
1222 faces of all the glyphs to compute ROW's hash value.
1223 Fixes assertion violations in row_equal_p. (Bug#10035)
1225 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1227 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1228 just return (bug#10044).
1230 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1232 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1233 with user-defined heap size. Bump the default size of the temacs
1234 heap to 27MB, to avoid memory warning when running temacs.
1235 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1237 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1238 current_matrix and desired_matrix. (Bug#9990)
1239 (verify_row_hash) [XASSERTS]: New function.
1240 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1241 that the hash value of glyph rows is correct.
1243 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1245 * window.h (window): Remove splits slot.
1246 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1247 (Fdelete_other_windows_internal, make_parent_window)
1248 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1249 (Fset_window_configuration, save_window_save): Don't deal with
1250 split status of windows.
1251 (saved_window): Remove splits slot.
1252 (Vwindow_splits): Rewrite doc-string.
1254 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1256 * xfns.c (unwind_create_frame):
1257 * nsfns.m (unwind_create_frame):
1258 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1259 Vframe_list (Bug#9999).
1261 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1263 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1265 2011-11-11 Kenichi Handa <handa@m17n.org>
1267 * callproc.c (Fcall_process): Set the member dst_multibyte of
1270 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1272 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1273 avoid a crash (bug#9496).
1275 2011-11-09 Chong Yidong <cyd@gnu.org>
1277 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1278 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1280 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1282 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1284 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1286 Avoid some portability problems by eschewing 'extern inline' functions.
1287 The trivial performance wins aren't worth the portability hassles; see
1288 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1290 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1291 (window_box_width, window_box_left, window_box_left_offset)
1292 (window_box_right, window_box_right_offset): Undo previous change,
1293 by removing the "extern"s.
1294 * intervals.c (adjust_intervals_for_insertion)
1295 (adjust_intervals_for_deletion): Undo previous change,
1296 making these static again.
1297 (offset_intervals, temp_set_point_both, temp_set_point)
1298 (copy_intervals_to_string): No longer inline.
1299 * xdisp.c (window_text_bottom_y, window_box_width)
1300 (window_box_height, window_box_left_offset)
1301 (window_box_right_offset, window_box_left, window_box_right)
1302 (window_box): No longer inline.
1304 2011-11-08 Chong Yidong <cyd@gnu.org>
1306 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1307 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1308 Signal an error if not a live window.
1309 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1310 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1312 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1314 * lisp.h (syms_of_abbrev): Remove declaration.
1315 Reported by CHENG Gao <chenggao@royau.me>.
1317 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1319 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1320 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1321 of temacs in GUI mode.
1323 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1325 * window.h: Declare delete_all_child_windows instead of
1326 delete_all_subwindows.
1327 * window.c (Fwindow_nest, Fset_window_nest)
1328 (Fset_window_new_total, Fset_window_new_normal)
1329 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1330 (delete_all_subwindows): Rename to delete_all_child_windows.
1331 (Fdelete_other_windows_internal, Fset_window_configuration):
1332 Call delete_all_child_windows instead of delete_all_subwindows.
1333 * frame.c (delete_frame): Call delete_all_child_windows instead
1334 of delete_all_subwindows.
1336 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1338 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1339 This is also needed for porting to any host where GC_MARK_STACK is
1340 not GC_MAKE_GCPROS_NOOPS.
1341 (which_symbols): Use it.
1343 2011-11-07 Kenichi Handa <handa@m17n.org>
1345 * coding.c (coding_set_destination): Check coding->src_pos only
1346 when coding->src_object is a buffer (bug#9910).
1348 * process.c (send_process): Set the member src_multibyte of coding
1349 to 0 (bug#9911) when sending a unibyte text.
1351 * callproc.c (Fcall_process): Set the member src_multibyte of
1352 process_coding to 0 (bug#9912).
1354 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1356 * xmenu.c (cleanup_widget_value_tree): New function.
1357 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1358 calling free_menubar_widget_value_tree directly (Bug#9830).
1360 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1362 Fix some portability problems with 'inline'.
1363 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1364 (window_box_width, window_box_left, window_box_left_offset)
1365 (window_box_right, window_box_right_offset): Declare extern.
1366 Otherwise, these inline functions do not conform to C99 and
1367 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1368 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1369 * intervals.c (adjust_intervals_for_insertion)
1370 (adjust_intervals_for_deletion): Now extern, because otherwise the
1371 extern inline functions 'offset_intervals' couldn't refer to it.
1372 (static_offset_intervals): Remove.
1373 (offset_intervals): Rewrite using the old contents of
1374 static_offset_intervals. The old version didn't conform to C99
1375 because an extern inline function contained a reference to an
1376 identifier with static linkage.
1378 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1380 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1383 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1385 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1386 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1387 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1388 return Qleft_to_right.
1390 2011-11-06 Chong Yidong <cyd@gnu.org>
1392 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1393 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1394 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1395 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1396 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1397 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1398 (Fwindow_vscroll): Doc fix.
1399 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1400 argument, since it makes no sense to pass a live window and for
1401 consistency with window-child.
1403 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1405 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1408 2011-11-05 Jason Rumney <jasonr@gnu.org>
1410 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1411 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1413 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1414 bitwise arithmetic preventing use of unicode-sip and non-truetype
1417 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1419 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1422 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1423 initialization code to keep similarity to xfns.c after changes
1426 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1428 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1429 (unwind_create_frame): New function (Bug#9943).
1430 (Fx_create_frame): Restructure code to be more similar to the one in
1431 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1432 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1433 Move terminal->reference_count++ just before making the frame official
1436 * nsterm.m (x_free_frame_resources): New function.
1437 (x_destroy_window): Move code to x_free_frame_resources.
1439 * xfns.c (unwind_create_frame): Fix comment.
1440 (Fx_create_frame, x_create_tip_frame):
1441 Move terminal->reference_count++ just before making the frame
1442 official. Move initialization of image_cache_refcount and
1443 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1445 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1447 Support MSVC build with newer versions of Visual Studio.
1448 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1449 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1452 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1453 which are not supported by MSVC.
1454 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1455 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1457 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1459 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1461 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1463 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1465 Support MSVC build with newer versions of Visual Studio.
1466 * w32.c: Don't include w32api.h for MSVC.
1467 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1469 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1470 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1471 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1472 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1474 (alloca) [_MSC_VER]: Define to _alloca.
1476 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1478 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1480 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1482 * xdisp.c (note_mouse_highlight): If either of
1483 previous/next-single-property-change returns nil, treat that as
1484 the beginning or the end of the buffer. (Bug#9955)
1486 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1488 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1489 label is not null (Bug#9951).
1490 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1493 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1495 * window.c (Fwindow_body_size): Mention in the doc string that the
1496 return value is in frame's canonical units. (Bug#9949)
1498 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1500 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1502 * w32fns.c (unwind_create_frame): If needed, free the glyph
1503 matrices of the partially constructed frame. (Bug#9943)
1504 * xfns.c (unwind_create_frame): Likewise.
1506 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1508 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1509 Don't stop backward scan on the continuation glyph, even though
1510 its CHARPOS is positive.
1511 (mouse_face_from_buffer_pos, note_mouse_highlight):
1512 Rename cover_string to disp_string.
1514 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1516 * window.c (temp_output_buffer_show): Don't use
1517 Vtemp_buffer_show_specifiers.
1518 (Vtemp_buffer_show_specifiers): Remove unused variable.
1520 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1522 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1523 past the beginning of the current glyph matrix.
1525 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1527 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1528 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1529 HAVE_GTK3 (Bug#9869).
1531 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1532 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1534 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1536 * xterm.c: Declare x_handle_net_wm_state to return int.
1537 (handle_one_xevent): Check if we are iconified but don't have
1538 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1539 (get_current_wm_state): Return non-zero if not hidden,
1540 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1541 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1542 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1543 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1545 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1547 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1548 so that this new function doesn't get optimized away by a
1549 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1551 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1553 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1555 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1557 Fix the `xbytecode' command.
1558 * .gdbinit (xprintbytestr): New command.
1559 (xwhichsymbols): Rename from `which'; all callers changed.
1560 (xbytecode): Print the byte-code string as well.
1562 2011-10-29 Kim Storm <storm@cua.dk>
1564 * alloc.c (which_symbols): New function.
1566 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1568 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1571 2011-10-29 Glenn Morris <rgm@gnu.org>
1573 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1574 Not clear what it was for, and it causes various bugs. (Bug#9839)
1576 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1578 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1579 possible random value that matches one of those tested as
1580 condition to clear the mouse face.
1582 2011-10-28 Chong Yidong <cyd@gnu.org>
1584 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1586 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1588 * window.c (make_window): Initialize phys_cursor_on_p.
1590 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1592 * lisp.h (struct Lisp_Symbol): Update comments.
1594 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1596 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1598 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1600 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1601 <oslsachem@gmail.com> for helping to debug this.
1603 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1604 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1605 (g_b_init_get_glyph_outline_w): New static variables.
1606 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1607 (GetGlyphOutlineW_Proc): New typedefs.
1608 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1609 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1611 (w32font_open_internal, compute_metrics):
1612 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1613 instead of calling the "wide" APIs directly.
1615 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1617 * w32.h (syms_of_w32font): Add prototype.
1619 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1621 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1622 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1623 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1624 (Fmove_to_window_line): Doc fix.
1626 2011-10-27 Chong Yidong <cyd@gnu.org>
1628 * process.c (make_process): Set gnutls_state to NULL.
1630 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1631 non-NULL, regardless of GNUTLS_INITSTAGE.
1632 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1633 an error. Set process slots as soon as we allocate them.
1635 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1637 2011-10-27 Chong Yidong <cyd@gnu.org>
1639 * gnutls.c (emacs_gnutls_deinit): New function.
1640 Deallocate credentials structures as well as calling gnutls_deinit.
1641 (Fgnutls_deinit, Fgnutls_boot): Use it.
1643 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1644 (deactivate_process): Call emacs_gnutls_deinit.
1646 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1648 * image.c (x_create_x_image_and_pixmap):
1649 * w32.c (sys_rename, w32_delayed_load):
1650 * w32font.c (fill_in_logfont):
1651 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1653 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1655 * w32fns.c (w32_default_color_map): New function,
1656 extracted from Fw32_default_color_map.
1657 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1659 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1661 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1663 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1665 * keyboard.c (test_undefined): New function (bug#9751).
1666 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1668 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1670 * sysdep.c (init_sys_modes): Fix the check for the controlling
1671 terminal (Bug#6649).
1673 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1675 * dispextern.h (struct bidi_it): New member next_en_type.
1677 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1678 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1679 current character, check also for next_en_type being WEAK_EN.
1680 (bidi_resolve_weak): Don't enter the expensive loop if the current
1681 position is before next_en_pos. Record the bidi type of the first
1682 non-ET, non-BN character we find, in addition to its position.
1683 (bidi_level_of_next_char): Invalidate next_en_type when
1684 next_en_pos is over-stepped.
1686 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1688 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1689 * editfns.c: Rewrite current-time-zone so that it invokes
1690 the equivalent of (format-time-string "%Z") to get the time zone name.
1691 This fixes a bug when the time zone name contains characters that
1692 need converting from the system time locale to Emacs internal format.
1693 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1694 that patch fixed format-time-string to do the conversion, but
1695 I forgot to fix current-time-zone.
1696 (format_time_string): New function, containing most of
1697 what Fformat_time_string used to contain.
1698 (Fformat_time_string): Rewrite in terms of format_time_string.
1699 This doesn't change this function's behavior.
1700 (current-time-zone): Rewrite to use format_time_string.
1701 This fixes the bug reported by Michael Schierl in
1702 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1703 Jason Rumney's 2007-06-07 change worked around this bug, but
1705 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1707 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1709 * xdisp.c (start_display): If the character at POS is displayed
1710 via a display vector, reset IT->current.dpvec_index to zero.
1711 (try_window_reusing_current_matrix): If a line ends in a display
1712 vector or the next line starts in a display vector, continue
1713 redrawing the window even though the character position of
1714 start_row was reached.
1717 2011-10-18 Chong Yidong <cyd@gnu.org>
1719 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1720 with nobreak-char-display too.
1722 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1724 Fix part 3 of bug#9771.
1725 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1726 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1727 non-neutral characters if the current character is a paragraph
1728 separator (a.k.a. Newline). This avoids running the same
1729 expensive loop twice, once when we consume the preceding newline
1730 and the other time when the line actually needs to be displayed.
1731 Avoid the loop when we see neutrals on the base embedding level
1732 following a character whose directionality is the same as the
1733 paragraph's. This avoids running the expensive loop when a line
1734 ends in a long sequence of neutrals, like control characters.
1735 Add assertion against STRONG_AL type. Slightly rearrange code
1736 that determines the type of a neutral given the first non-neutral
1738 (bidi_level_of_next_char): Set next_en_pos to zero when
1739 invalidating its info.
1741 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1743 * xdisp.c (push_display_prop): Determine whether to record string
1744 or buffer position by IT->string, not by IT->method. Allow
1745 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1746 (move_it_vertically_backward): Don't look for character position
1747 immediately after the newline when in a continuation line.
1750 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1752 * window.c (coordinates_in_window): Rewrite and delabelize
1753 vertical border check. (Bug#5357) (Bug#9618)
1755 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1757 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1758 errors in XSetWindowBorder (bug#9310).
1760 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1762 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1763 avoid crash when xmalloc overrun checking is enabled.
1765 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1767 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1768 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1769 cursor motion with <left> and <right> arrow keys.
1771 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1772 some callers set that themselves.
1774 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1776 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1777 display string and the previous row comes from the same string and
1778 is empty. (Bug#9739) (Bug#9738)
1780 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1782 * doc.c (get_doc_string): Encode file name (bug#9735).
1784 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1786 * bidi.c (bidi_level_of_next_char):
1787 * xdisp.c (get_visually_first_element): Remove old incorrect
1788 comments regarding the Unicode Line Separator character.
1790 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1792 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1794 * alloc.c (Fgc_status): Do not access beyond zombies array
1795 boundary if nzombies > MAX_ZOMBIES.
1796 * alloc.c (dump_zombies): Add missing format specifier.
1798 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1800 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1801 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1803 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1804 Some packages use them to denote characters with modifiers.
1806 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1808 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1809 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1810 matching a pp-number. Rename parameter var to var1.
1812 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1814 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1816 2011-10-08 Glenn Morris <rgm@gnu.org>
1818 * callint.c (Fcall_interactively): Give a more explicit error for the
1819 'c' case with a non-character input. (Bug#8479)
1821 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1823 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1825 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1826 lines that are hscrolled on the left.
1828 * dispnew.c (buffer_posn_from_coords): Account for a possible
1829 presence of header-line. (Bug#4426)
1831 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1833 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1834 Don't advertise functionality which we discourage or doesn't work.
1836 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1838 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1839 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1840 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1841 this makes Emacs dump core during garbage collection on rare
1842 occasions. sizeof is obviously inferior to offsetof here, so
1843 stick with offsetof.
1844 (GC_POINTER_ALIGNMENT): New macro.
1845 (mark_memory): Omit 3rd (offset) arg; caller changed.
1846 Don't assume EMACS_INT alignment is the same as pointer alignment.
1848 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1850 * keyboard.c (read_key_sequence_remapped): New var.
1851 (read_key_sequence): Compute remapping in the right buffer.
1852 (command_loop_1): Use read_key_sequence's remapping directly.
1854 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1856 * dired.c (file_name_completion): Don't expand file name.
1857 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1858 before checking file name handler.
1860 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1861 they've been requested explicitly (bug#9591).
1863 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1865 * keymap.c (Fsingle_key_description): Use make_specified_string
1866 instead of build_string to build string from push_key_description.
1869 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1871 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1872 This fixes a Y2038 bug on 64-bit hosts.
1873 * buffer.c (reset_buffer):
1874 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1875 (Fclear_buffer_auto_save_failure):
1876 Use 0, not -1, to represent an unset failure time, since time_t
1877 might not be signed.
1879 Remove dependency on glibc malloc internals.
1880 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1881 Move back here from lisp.h, but with their new implementations.
1882 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1883 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1884 * charset.c (charset_table_init): New static var.
1885 (syms_of_charset): Use it instead of xmalloc. This removes a
1886 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1887 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1888 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1889 Move back to alloc.c.
1890 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1891 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1893 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1895 * nsterm.m (windowDidResize): Call x_set_window_size only when
1896 ns_in_resize is true. Otherwise set pixelwidth/height and
1897 call change_frame_size (Bug#9628).
1899 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1901 Port --enable-checking=all to Fedora 14 x86-64.
1902 * charset.c (syms_of_charset): Also account for glibc malloc's
1903 internal overhead when calculating the initial malloc maximum.
1905 Port --enable-checking=all to Fedora 14 x86.
1906 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1908 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1909 (overrun_check_realloc, overrun_check_free):
1910 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1911 That way, xmalloc returns a properly-aligned pointer even if
1912 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1913 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1914 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1915 into account when calculating the initial malloc maximum.
1916 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1917 Move here from alloc.c, so that charset.c can use it too.
1918 Properly align; the old code wasn't right for common 32-bit hosts
1919 when configured with --enable-checking=all.
1920 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1921 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1923 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1925 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1928 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1930 * xdisp.c (compute_display_string_end): If there's no display
1931 string at CHARPOS, return -1.
1933 * bidi.c (bidi_fetch_char): When compute_display_string_end
1934 returns a negative value, treat the character as a normal
1935 character not covered by a display string. (Bug#9624)
1937 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1939 * lread.c (Fread_from_string): Fix typo in docstring.
1941 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1943 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1944 newline, reseat the iterator instead of bidi-iterating there one
1945 character at a time. (Bug#9610)
1946 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1947 TO_CHARPOS if the bidi iterator is at base embedding level.
1949 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1951 * lread.c (readevalloop): Use correct code for NBSP.
1952 (read1): Likewise. (Bug#9608)
1954 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1956 * dbusbind.c (Fdbus_register_signal): When service is not
1957 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1959 2011-09-25 Glenn Morris <rgm@gnu.org>
1961 * buffer.c (truncate-lines): Doc fix.
1963 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1965 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1966 (Fset_window_next_buffers): Doc fix.
1968 2011-09-24 Glenn Morris <rgm@gnu.org>
1970 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1972 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1974 Fix minor problems found by static checking.
1975 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1976 * indent.c (Fvertical_motion): Fix == vs = typo.
1978 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1980 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1981 Default value is now t. Doc fix.
1983 * indent.c (Fvertical_motion): Compute and apply the overshoot
1984 logic when moving up, not only when moving down. Fix the
1985 confusing name and values of the it_overshoot_expected variable;
1986 logic changes accordingly. (Bug#9254) (Bug#9549)
1988 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1989 CHARPOS is covered by a display string which includes newlines.
1990 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1991 is covered by a display string with embedded newlines.
1993 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1995 * dbusbind.c (Fdbus_register_signal): Add match rule to
1996 Vdbus_registered_objects_table. (Bug#9581)
1997 (Fdbus_register_method, Vdbus_registered_objects_table):
2000 2011-09-24 Jim Meyering <meyering@redhat.com>
2002 do not ignore write error for any output size
2003 The previous change was incomplete.
2004 While it makes emacs --batch detect the vast majority of stdout
2005 write failures, errors were still ignored whenever the output size is
2006 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2007 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2008 && echo FAIL: ignored write error
2009 FAIL: ignored write error
2010 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2011 && echo FAIL: ignored write error
2012 FAIL: ignored write error
2013 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2015 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2017 * emacs.c (Fkill_emacs): In noninteractive mode exit
2018 non-successfully if a write error occurred on stdout. (Bug#9574)
2020 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2022 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2025 * dispextern.h (struct it): Update the comment documenting what
2028 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2030 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2031 a display string, extend search for cursor position to end of row.
2032 (find_row_edges): If the row ends in a newline from a display
2033 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2034 Handle the case of a display string with multiple newlines.
2035 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2036 non-empty line. Fixes confusing cursor motion with arrow keys at
2037 the beginning of a line that starts with whitespace.
2039 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2041 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2044 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2046 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2049 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2051 * xdisp.c (display_line): Record maximum and minimum buffer
2052 positions even if no glyphs were produced (e.g., by a zero-width
2053 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2054 buffer positions that will be removed from the glyph row because
2056 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2057 column is beyond frame width: don't subtract 1 "pixel" when
2058 computing width of the stretch.
2059 (reseat_at_next_visible_line_start): Undo the change made on
2060 2011-09-17 that saved paragraph information and restored it after
2061 the call to `reseat'. (Bug#9545)
2063 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2065 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2066 and turn window cursor on if cleared (Bug#9415).
2068 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2070 * search.c (boyer_moore): Take unibyte characters from pattern
2071 literally. (Bug#9458)
2073 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2075 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2077 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2079 Fix minor problem found by static checking.
2080 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2081 initialized, to pacify gcc -Wuninitialized.
2083 * fileio.c: Report proper errno when syscall falls.
2084 (Finsert_file_contents): Save and restore errno,
2085 so that report_file_error outputs the correct diagnostic.
2086 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2088 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2090 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2092 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2094 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2095 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2097 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2099 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2100 about the current paragraph and restore it after the call to reseat.
2102 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2103 (bidi_find_paragraph_start): Search back for paragraph beginning
2104 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2105 (bidi_move_to_visually_next): Only trigger paragraph-related
2106 computations when the last character is a newline or at EOB, not
2107 just any NEUTRAL_B. (Bug#9470)
2109 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2110 truncated lines if point is covered by a display string. (Bug#9524)
2112 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2114 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2115 (cons_to_x_long): New function.
2116 (lisp_data_to_selection_data): Use it. Correct the test for
2117 short-versus-long data; it was negated. Break out of vector
2118 loop, for efficiency, when a long datum is discovered.
2120 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2122 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2124 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2126 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2127 GCC PR/17406) by declaring this function with external scope.
2129 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2131 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2132 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2134 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2136 * editfns.c (Fformat): Correctly handle text properties on "%%".
2138 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2140 * xterm.c (x_draw_composite_glyph_string_foreground):
2141 * w32term.c (x_draw_composite_glyph_string_foreground):
2142 * term.c (encode_terminal_code):
2143 * composite.c (composition_update_it, get_composition_id):
2144 * xdisp.c (get_next_display_element)
2145 (fill_composite_glyph_string): Add comments about special meaning
2146 of TAB characters in a composition.
2148 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2150 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2151 This occurs when processing a multibyte format.
2152 Problem reported by Wolfgang Jenker.
2154 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2156 * xdisp.c (try_cursor_movement): Only check for exact match if
2157 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2159 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2161 Remove unused external symbols.
2162 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2163 * xdisp.c (calc_pixel_width_or_height): Now static.
2164 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2165 * indent.c (check_display_width):
2166 * w32term.c: Fix comment to match code.
2167 * xterm.c, xterm.h (x_catching_errors): Remove.
2169 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2171 * xselect.c: Use signed conversions more consistently (Bug#9498).
2172 (selection_data_to_lisp_data): Assume incoming selection data are
2173 signed integers, not unsigned. This is to be consistent with
2174 outgoing selection data, which was modified to use signed integers
2175 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2176 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2177 expects long, not unsigned long.
2179 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2181 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2182 computation of loop end. Reported by Johan Bockgård
2185 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2187 * frame.c (Fother_visible_frames_p): Function deleted.
2189 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2191 * indent.c (compute_motion): Process display vector front to back
2192 rather than the other way around. (Bug#2496)
2194 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2196 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2198 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2200 * minibuf.c (Fread_from_minibuffer): Doc fix.
2202 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2204 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2205 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2207 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2209 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2210 value for non-existent files.
2212 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2214 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2215 set its "size" to -1. This will set the modtime_size field of
2216 the corresponding buffer to -1, which is what
2217 verify-visited-file-modtime expects for files that do not exist.
2220 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2222 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2224 * lisp.h: ... from here. push_key_description is no longer
2225 defined in keyboard.c, so its declaration should not be in
2226 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2227 logically belongs with push_key_description.
2229 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2231 * buffer.h: Include <sys/types.h> instead of <time.h>.
2232 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2233 Problem reported by Herbert J. Skuhra.
2235 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237 * xml.c (parse_region): Make the parsing work for
2238 non-comment-starting XML files again (bug#9144).
2240 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2242 * image.c (gif_load): Fix calculation of bottom and right corner.
2245 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2247 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2248 redisplay in small windows.
2250 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2252 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2254 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2256 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2257 Operate on live windows only.
2259 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2261 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2263 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2265 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2266 only under bidi iteration.
2268 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2270 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2272 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2274 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2275 Without this fix, the command to link temacs failed due to an
2276 undefined symbol __builtin_isnan. This is because
2277 /usr/include/iso/math_c99.h #defines isnan(x) to
2278 __builtin_isnan(x), but the bundled gcc, which identifies itself
2279 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2281 * floatfns.c (isnan): #undef, and then #define to a clone of
2283 (Fisnan): Always define, since it's always available now.
2284 (syms_of_floatfns): Always define isnan at the Lisp level.
2286 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2288 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2290 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2292 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2293 The previous code assumed that file offsets (off_t values) fit in
2294 EMACS_INT variables, which is not true on typical 32-bit hosts.
2295 The code messed up by falsely reporting buffer overflow in cases
2296 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2297 when "big" contains more than 2**29 bytes, even though this
2298 inserts just one byte and does not overflow the buffer.
2299 (Finsert_file_contents): Store file offsets as off_t
2300 values, not as EMACS_INT values. Check for overflow when
2301 converting between EMACS_INT and off_t. When checking for
2302 buffer overflow or for overlap, take the offsets into account.
2303 Don't use EMACS_INT for small values where int suffices.
2304 When checking for overlap, fix a typo: ZV was used where
2305 ZV_BYTE was intended.
2306 (Fwrite_region): Don't assume off_t fits into 'long'.
2307 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2309 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2311 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2313 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2315 sprintf-related integer and memory overflow issues (Bug#9412).
2317 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2318 (esprintf, exprintf, evxprintf): New functions.
2319 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2320 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2321 (modify_event_symbol): Do not assume that the length of
2322 name_alist_or_stem is safe to alloca and fits in int.
2323 (Fexecute_extended_command): Likewise for function name and binding.
2324 (Frecursion_depth): Wrap around reliably on integer overflow.
2325 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2326 since some callers pass EMACS_INT values.
2327 (Fsingle_key_description): Don't crash if symbol name contains more
2328 than MAX_ALLOCA bytes.
2329 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2330 (get_minibuffer): Arg is now EMACS_INT, not int.
2331 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2332 (esprintf, exprintf, evxprintf): New decls.
2333 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2335 * dbusbind.c (signature_cat): New function.
2336 (xd_signature, Fdbus_register_signal):
2337 Do not overrun buffer; instead, report string overflow.
2339 * dispnew.c (add_window_display_history): Don't overrun buffer.
2340 Truncate instead; this is OK since it's just a log.
2342 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2343 even if the time zone offset is outlandishly large.
2344 Don't mishandle offset == INT_MIN.
2346 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2347 when creating daemon; the previous buffer-overflow check was incorrect.
2349 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2350 which has the guts of the old verror function.
2352 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2353 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2355 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2356 (font_unparse_xlfd): Don't blindly alloca long strings.
2357 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2358 fits in int, when using sprintf. Use single snprintf to count
2359 length of string rather than counting it via multiple sprintfs;
2360 that's simpler and more reliable.
2361 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2362 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2363 sprintf, in case result does not fit in int.
2365 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2366 (fontset_from_font): Print it.
2368 * frame.c (tty_frame_count): Now printmax_t, not int.
2369 (make_terminal_frame, set_term_frame_name): Print it.
2370 (x_report_frame_params): In X, window IDs are unsigned long,
2371 not signed long, so print them as unsigned.
2372 (validate_x_resource_name): Check for implausibly long names,
2373 and don't assume name length fits in 'int'.
2374 (x_get_resource_string): Don't blindly alloca invocation name;
2375 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2378 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2379 (xg_check_special_colors, xg_set_geometry):
2380 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2382 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2383 Use esprintf, not sprintf, in case result does not fit in int.
2385 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2386 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2387 it as a large positive number.
2388 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2389 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2391 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2392 in case result does not fit in int.
2394 * print.c (float_to_string): Detect width overflow more reliably.
2395 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2396 buffer overrun. Don't assume list length fits in 'int'. Treat
2397 print length of 0 as 0, not as infinity; to be consistent with other
2398 uses of print length in this function. Don't overflow print length
2399 index. Don't assume hash table size fits in 'long', or that
2400 vectorlike size fits in 'unsigned long'.
2402 * process.c (make_process): Use printmax_t, not int, to format
2403 process-name gensyms.
2405 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2407 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2408 to avoid potential buffer overrun.
2410 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2411 if X resource line is longer than 512 bytes.
2413 * xfns.c (x_window): Make sprintf buffer a bit bigger
2414 to avoid potential buffer overrun.
2416 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2418 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2420 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2422 Integer overflow fixes for scrolling, etc.
2423 Without these, Emacs silently mishandles large integers sometimes.
2424 For example, "C-u 4294967297 M-x recenter" was treated as if
2425 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2427 * xdisp.c (try_window_id): Check Emacs fixnum range before
2428 converting to 'int'.
2430 * window.c (window_scroll_line_based, Frecenter):
2431 Check that an Emacs fixnum is in range before assigning it to 'int'.
2432 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2433 values converted from Emacs fixnums.
2434 (Frecenter): Don't wrap around a line count if it is out of 'int'
2435 range; instead, treat it as an extreme value.
2436 (Fset_window_configuration, compare_window_configurations):
2437 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2439 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2440 that can exceed INT_MAX. Check that EMACS_INT value is in range
2441 before assigning it to the (possibly-narrower) index.
2442 (match_limit): Don't assume that a fixnum can fit in 'int'.
2444 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2447 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2448 (Fvertical_motion): Don't wrap around LINES values that don't fit
2449 in 'int'. Instead, treat them as extreme values. This is good
2450 enough for windows, which can't have more than INT_MAX lines anyway.
2452 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2454 * Require libxml/parser.h to avoid compilation warning.
2456 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2458 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2459 since this reportedly can destroy thread storage.
2461 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2463 * syntax.c (find_defun_start): Update all cache variables if
2464 exiting early (Bug#9401).
2466 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2468 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2470 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2471 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2472 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2474 * term.c (tty_append_glyph): New function.
2475 (produce_stretch_glyph): Static function and its prototype deleted.
2477 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2480 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2482 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2483 when checking :margin (Bug#9390).
2484 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2485 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2486 so that the name doesn't mislead. All uses changed.
2488 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2490 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2493 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2495 * xdisp.c (move_it_to): Don't bail out early when reaching
2496 position beyond to_charpos, if we are scanning backwards.
2497 (move_it_vertically_backward): When DY == 0, make sure we get to
2498 the first character in the line after the newline.
2500 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2502 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2503 (ccl_driver): Do not generate an out-of-range pointer.
2504 (Fccl_execute_on_string): Remove unnecessary check for
2505 integer overflow, noted by Stefan Monnier in
2506 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2507 Remove a FIXME that didn't need fixing.
2508 Simplify the newly-introduced buffer reallocation code.
2510 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2512 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2514 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2516 Integer and memory overflow issues (Bug#9196).
2518 * doc.c (get_doc_string): Rework so that
2519 get_doc_string_buffer_size is the actual buffer size, rather than
2520 being 1 less than the actual buffer size; this makes xpalloc more
2523 * image.c (x_allocate_bitmap_record, cache_image):
2524 * xselect.c (Fx_register_dnd_atom):
2525 Simplify previous changes by using xpalloc.
2527 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2528 since either will do and ptrdiff_t is convenient with xpalloc.
2530 * charset.c (charset_table_size)
2531 (struct charset_sort_data.priority): Now ptrdiff_t.
2532 (charset_compare): Don't overflow if priorities differ greatly.
2533 (Fsort_charsets): Don't assume list length fits in int.
2534 Check for size-calculation overflow when allocating sort data.
2535 (syms_of_charset): Allocate an initial charset table that is
2536 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2538 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2540 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2541 The actual value is always <= INT_MAX, and leaving it unsigned made
2542 overflow checking harder.
2544 * dispextern.h (struct glyph_matrix.rows_allocated)
2545 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2546 with xpalloc. The values are still always <= INT_MAX.
2548 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2550 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2551 (SAFE_NALLOCA): New macro.
2553 * region-cache.c (struct boundary.pos, find_cache_boundary)
2554 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2555 (set_cache_region, invalidate_region_cache)
2556 (revalidate_region_cache, know_region_cache, region_cache_forward)
2557 (region_cache_backward, pp_cache):
2558 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2559 so that ptrdiff_t * can be passed to xpalloc.
2560 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2561 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2562 (pp_cache): Don't assume cache_len fits in int.
2563 * region-cache.h: Adjust extern decls to match.
2565 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2566 EMACS_INT, since either will do, for xpalloc.
2568 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2569 (xnmalloc, xnrealloc, xpalloc): New functions.
2571 * bidi.c (bidi_shelve_header_size): New constant.
2572 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2573 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2575 * bidi.c (bidi_cache_shrink):
2576 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2578 Don't update size of array until after memory allocation succeeds,
2579 because xmalloc/xrealloc may not return.
2580 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2581 now that we have proper integer overflow checking.
2582 (record_overlay_string, overlay_strings): Catch overflows when
2583 calculating size of overlay_str_buf.
2585 * callproc.c (Fcall_process): Check for size overflow when
2586 calculating size of args2.
2587 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2588 Normally we prefer signed values, but sticking with ptrdiff_t would
2589 require adding more-complicated checks.
2591 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2592 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2593 Redo buffer-overflow calculations to avoid integer overflow.
2594 Add a FIXME comment where memory seems to be over-allocated.
2596 * character.c (Fstring): Check for size-calculation overflow.
2598 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2599 unnecessary integer overflow. Check for size overflow.
2600 (encode_coding_object): Don't update size until xmalloc succeeds.
2602 * composite.c (get_composition_id): Check for overflow in glyph
2603 length calculations.
2605 Integer and memory overflow fixes for display code.
2606 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2607 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2608 (scrolling_window): Check for overflow in size calculations.
2609 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2610 Don't assume glyph table len fits in int.
2611 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2612 (row_table_size): Now ptrdiff_t, not int.
2613 (scrolling_window): Avoid overflow in size calculations.
2614 Don't update size until allocation succeeds.
2615 * fns.c (concat): Check for overflow in size calculations.
2616 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2617 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2618 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2620 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2621 (get_doc_string): Check for size calculation overflow.
2622 Don't update size until allocation succeeds.
2623 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2624 EMACS_INT, where ptrdiff_t will do.
2625 (Fsubstitute_command_keys): Check for string overflow.
2627 * editfns.c (set_time_zone_rule): Don't assume environment length
2629 (message_length): Now ptrdiff_t, not int.
2630 (Fmessage_box): Don't update size until allocation succeeds.
2631 Don't assume message length fits in int.
2632 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2634 * emacs.c (main): Do not reallocate argv, since there is a null at
2635 the end that can be overwritten, and this way there's no need to
2636 worry about size-calculation overflow.
2637 (sort_args): Check for size-calculation overflow.
2639 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2641 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2643 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2644 (x_set_scroll_bar_width, x_figure_window_size):
2645 Check for integer overflow.
2646 (x_set_alpha): Do not assume XINT fits in int.
2648 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2649 This is for the members text_lines, text_cols, total_lines, total_cols,
2650 where the system imposes an 'int' limit.
2652 * fringe.c (Fdefine_fringe_bitmap):
2653 Don't update size until alloc works.
2655 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2656 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2658 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2659 Check for size-calculation overflow.
2660 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2661 do, as we prefer signed integers.
2662 (id_to_widget.max_size, id_to_widget.used)
2663 (xg_store_widget_in_map, xg_remove_widget_from_map)
2664 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2665 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2666 Use and return ptrdiff_t, not int.
2667 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2668 * gtkutil.h: Change prototypes to match the above.
2670 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2671 are duplicate now that they've been promoted to lisp.h.
2672 (x_allocate_bitmap_record, x_alloc_image_color)
2673 (make_image_cache, cache_image, xpm_load):
2674 Don't update size until alloc is done.
2675 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2677 Check for size calculation overflow.
2678 (ct_colors_allocated_max): New constant.
2679 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2682 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2683 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2684 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2685 Use ptrdiff_t, not int, to count maps.
2686 (read_char_minibuf_menu_prompt): Check for overflow in size
2687 calculations. Don't update size until allocation succeeds.
2688 Redo calculations to avoid overflow.
2689 * keyboard.h: Change prototypes to match the above.
2691 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2693 (current_minor_maps): Check for size calculation overflow.
2694 * keymap.h: Change prototypes to match the above.
2696 * lread.c (read1, init_obarray): Don't update size until alloc done.
2698 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2699 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2701 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2702 Now ptrdiff_t, not int.
2703 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2704 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2706 * process.c (Fnetwork_interface_list): Check for overflow
2707 in size calculation.
2709 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2711 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2712 overflow. Don't bother calling xmalloc when xrealloc will do.
2714 * search.c (Freplace_match): Check for size calculation overflow.
2715 (Fset_match_data): Don't assume list lengths fit in 'int'.
2717 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2718 for command line length. Do not attempt to address one before the
2719 beginning of an array, as that's not portable.
2721 * term.c (max_frame_lines): Remove; unused.
2722 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2724 (encode_terminal_code, calculate_costs): Check for size
2725 calculation overflow.
2726 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2727 table lengths and related sizes. Don't update size until alloc
2728 done. Redo calculations to avoid overflow.
2729 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2731 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2732 subtracting pointers.
2733 (gobble_line): Check for overflow more carefully. Don't update size
2736 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2737 Don't update size until alloc done.
2738 Redo size calculations to avoid overflow.
2739 Check for size calculation overflow.
2740 (main) [DEBUG]: Fix typo in invoking tparam1.
2742 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2743 Use ptrdiff_t, not int, for sizes.
2744 (store_mode_line_noprop_char): Don't update size until alloc done.
2746 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2747 Use ptrdiff_t, not int, for sizes.
2748 (Finternal_make_lisp_face, cache_face):
2749 Check for size calculation overflow.
2750 (cache_face): Treat size calculation overflows as if they were
2751 memory exhaustion (the usual treatment), rather than aborting.
2753 * xfns.c (x_encode_text, x_set_name_internal)
2754 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2755 sizes, since they can exceed INT_MAX in size. Check for size
2756 calculation overflow.
2758 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2759 (xg_select): Check for size calculation overflow.
2760 Don't update size until alloc done.
2762 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2763 as sprintf is limited to int lengths.
2765 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2766 (X_LONG_MIN): New macros.
2767 Use them to make the following changes clearer.
2768 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2769 This change doesn't affect the value now, but it may help remind
2770 future maintainers not to raise the value too much later.
2771 (SELECTION_QUANTUM): Remove, replacing with ...
2772 (selection_quantum): ... new function, which avoids overflow.
2774 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2775 assumption that selection length fits in 'int'.
2776 (x_reply_selection_request, x_handle_selection_request)
2777 (x_get_window_property, receive_incremental_selection)
2778 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2779 (lisp_data_to_selection_data, clean_local_selection_data):
2780 Use ptrdiff_t, not int, to record length of selection.
2781 (x_reply_selection_request, x_get_window_property)
2782 (receive_incremental_selection, x_property_data_to_lisp):
2783 Redo calculations to avoid overflow.
2784 (x_reply_selection_request): When sending hint, ceiling it at
2785 X_LONG_MAX rather than relying on wraparound overflow to send
2787 (x_get_window_property, receive_incremental_selection)
2788 (lisp_data_to_selection_data, x_property_data_to_lisp):
2789 Check for size-calculation overflow.
2790 (x_get_window_property, receive_incremental_selection)
2791 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2792 Don't store size until memory allocation succeeds.
2793 (x_get_window_property): Plug memory leak on memory exhaustion.
2794 Don't double-block input; malloc is safe here. Don't assume 2**34
2795 - 4 fits in unsigned long. Add an xassert to check
2796 XGetWindowProperty overflow. Be more careful about overflow
2797 calculations, and distinguish size from memory overflow better.
2798 (receive_incremental_selection): When tracing, don't assume
2799 unsigned int is less than INT_MAX.
2800 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2801 harmful) conversions of unsigned short to int.
2802 (lisp_data_to_selection_data): Don't assume that integers
2803 in the range -65535 through -1 fit in an X unsigned short.
2804 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2805 result parameters unless successful. Rely on cons_to_unsigned
2806 to report problems with elements; the old code wasn't right anyway.
2807 (x_check_property_data): Check for int overflow; we cannot use
2808 a wider type due to X limits.
2809 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2811 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2813 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2814 (x_term_init): Check for size calculation overflow.
2815 (x_color_cells): Don't store size until memory allocation succeeds.
2816 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2817 Don't assume alloca size is less than MAX_ALLOCA.
2818 (x_term_init): Don't assume length fits in int (sprintf is limited
2821 Use ptrdiff_t for composition IDs.
2822 * character.c (lisp_string_width):
2823 * composite.c (composition_table_size, n_compositions)
2824 (get_composition_id, composition_gstring_from_id):
2825 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2826 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2827 * window.c (Frecenter):
2828 Use ptrdiff_t, not int, for composition IDs.
2829 * composite.c (get_composition_id): Check for integer overflow.
2830 * composite.h: Adjust prototypes to match the above changes.
2832 Use ptrdiff_t for hash table indexes.
2833 * category.c (hash_get_category_set):
2834 * ccl.c (ccl_driver):
2835 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2836 * coding.c (coding_system_charset_list, detect_coding_system):
2837 * coding.h (struct coding_system.id):
2838 * composite.c (get_composition_id, gstring_lookup_cache):
2839 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2840 * image.c (xpm_get_color_table_h):
2841 * lisp.h (hash_lookup, hash_put):
2842 * minibuf.c (Ftest_completion):
2843 Use ptrdiff_t for hash table indexes, not int (which is too
2844 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2845 32-bit --with-wide-int hosts).
2847 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2848 Add a FIXME comment about memory leaks.
2849 (syms_of_charset): Don't assume xmalloc returns.
2851 Don't assume that stated character widths fit in int.
2852 * character.c (Fchar_width, c_string_width, lisp_string_width):
2853 * character.h (CHAR_WIDTH):
2854 * indent.c (MULTIBYTE_BYTES_WIDTH):
2855 Use sanitize_char_width to avoid undefined and/or bad behavior
2856 with outlandish widths.
2857 * character.h (sanitize_tab_width): Rename from sanitize_width,
2858 now that we have two such functions. All uses changed.
2859 (sanitize_char_width): New inline function.
2861 Don't assume that tab-width fits in int.
2862 * character.h (sanitize_width): New inline function.
2863 (SANE_TAB_WIDTH): New macro.
2864 (ASCII_CHAR_WIDTH): Use it.
2865 * indent.c (sane_tab_width): Remove. All uses replaced by
2866 SANE_TAB_WIDTH (current_buffer).
2867 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2869 * fileio.c: Integer overflow issues with file modes.
2870 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2872 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2873 Remove unreachable code.
2874 (read_hex, load_charset_map_from_file): Check for integer overflow.
2876 * xterm.c: Don't go over XClientMessageEvent limit.
2877 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2878 (x_send_scroll_bar_event): Likewise. Check that the size does not
2879 exceed limits imposed by XClientMessageEvent, as well as the usual
2880 ptrdiff_t and size_t limits.
2882 * keyboard.c: Overflow, signedness and related fixes.
2883 (make_lispy_movement): Use same integer type in forward decl
2884 that is used in the definition.
2885 (read_key_sequence, keyremap_step):
2886 Change bufsize argument back to int, undoing my 2011-03-30 change.
2887 We prefer signed types, and int is wide enough here.
2888 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2889 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2890 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2891 length, not size_t. Use ptrdiff_t for index, not int.
2892 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2893 possibility of integer overflow.
2895 Overflow, signedness and related fixes for images.
2897 * dispextern.h (struct it.stack[0].u.image.image_id)
2898 (struct_it.image_id, struct image.id, struct image_cache.size)
2899 (struct image_cache.used, struct image_cache.ref_count):
2900 * gtkutil.c (update_frame_tool_bar):
2901 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2902 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2903 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2904 * nsmenu.m (update_frame_tool_bar):
2905 * xdisp.c (calc_pixel_width_or_height):
2906 * xfns.c (image_cache_refcount):
2907 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2908 on typical 64-bit hosts.
2910 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2911 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2912 Omit unnecessary casts to int.
2913 (parse_image_spec): Check that integers fall into 'int' range
2914 when the callers expect that.
2915 (image_ascent): Redo ascent calculation to avoid int overflow.
2916 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2917 (lookup_image): Remove unnecessary tests.
2918 (xbm_image_p): Locals are now of int, not EMACS_INT,
2919 since parse_image_check makes sure they fit into int.
2920 (png_load, gif_load, svg_load_image):
2921 Prefer int to unsigned where either will do.
2922 (tiff_handler): New function, combining the cores of the
2923 old tiff_error_handler and tiff_warning_handler.
2924 This function is rewritten to use vsnprintf and thereby avoid
2925 stack buffer overflows. It uses only the features of vsnprintf
2926 that are common to both POSIX and native Microsoft.
2927 (tiff_error_handler, tiff_warning_handler): Use it.
2928 (tiff_load, gif_load, imagemagick_load_image):
2929 Don't assume :index value fits in 'int'.
2930 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2931 (imagemagick_load_image): Check that crop parameters fit into
2932 the integer types that MagickCropImage accepts. Don't assume
2933 Vimagemagick_render_type has a nonnegative value. Don't assume
2934 size_t fits in 'long'.
2935 (gs_load): Use printmax_t to print the widest integers possible.
2936 Check for integer overflow when computing image height and width.
2938 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2940 * xdisp.c (redisplay_window): Don't force window start if point
2941 will be invisible in the resulting window. (Bug#9324)
2943 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2945 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2946 the display spec is of the form `(space ...)'.
2947 (handle_display_spec): Return the value returned by
2948 handle_single_display_spec, not just 1 or zero.
2949 (handle_single_display_spec): If the display spec is of the form
2950 `(space ...)', and specifies display in the text area, return 2
2952 (try_cursor_movement): Check for the need to scroll more
2953 accurately, and prefer exact match for point under bidi.
2954 Don't advance `row' beyond the last row of the window.
2956 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2957 into disp_prop; all users changed.
2959 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2960 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2961 for the text covered by the display property.
2963 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2965 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2966 Change return value to nil.
2967 (Frecord_buffer): Delete unused function.
2969 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2971 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2972 buffers, return left-to-right.
2973 (set_cursor_from_row): Consider candidate row a win if its glyph
2974 represents a newline and point is on that newline. Fixes cursor
2975 positioning on the newline at EOL of R2L text within L2R
2976 paragraph, and vice versa.
2977 (try_cursor_movement): Check continued rows, in addition to
2978 continuation rows. Fixes unwarranted scroll when point enters a
2979 continued line of R2L text within an L2R paragraph, or vice versa.
2980 (cursor_row_p): Consider the case of point being equal to
2981 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2982 from the end of a short line to the beginning of a continued line
2983 of R2L text within L2R paragraph.
2984 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2985 composed characters.
2987 * bidi.c (bidi_check_type): Use xassert.
2988 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2991 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2993 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2996 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2998 * nsfont.m (ns_otf_to_script): Fix typo.
3000 2011-08-22 Kenichi Handa <handa@m17n.org>
3002 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3003 extra slot even if the purpose is char-code-property-table.
3005 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3007 * xdisp.c (redisplay_window): When computing centering_position,
3008 account for the height of the header line. (Bug#8874)
3010 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3011 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3012 candidate is selected by the mouse, and that candidate has a
3013 composed character under the mouse.
3015 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3016 coordinates reported by pos-visible-in-window-p for a composed
3017 character in column zero.
3019 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3021 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3023 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3025 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3026 consider it a hit if to_charpos is anywhere in the range of the
3027 composed buffer positions.
3029 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3031 * image.c (gif_load): Don't assume that each subimage has the same
3032 dimensions as the base image. Handle disposal method that is
3033 "undefined" by the gif spec (Bug#9335).
3035 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3037 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3038 (Fcondition_case): Document `debug' symbol in error handler.
3040 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3042 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3043 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3044 from an Org mode buffer to a Speedbar frame.
3046 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3047 a composition, take its buffer position from IT->cmp_it.charpos.
3048 Fixes cursor positioning at the beginning of a line that begins
3049 with a composed character.
3051 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3053 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3054 character bidirectional type, use STRONG_L instead. Fixes crashes
3055 in a buffer produced by `describe-categories'.
3057 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3058 members before the level stack, so they would be saved and
3059 restored when copying iterator state. Fixes incorrect reordering
3060 around TABs covered by display properties.
3062 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3064 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3066 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3068 * eval.c (internal_condition_case, internal_condition_case_1)
3069 (internal_condition_case_2, internal_condition_case_n):
3070 Remove unnecessary aborts (Bug#9081).
3072 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3074 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3075 has no `load' handler, try opening the file locally. (Bug#9311)
3077 2011-08-16 Ken Brown <kbrown@cornell.edu>
3079 * gmalloc.c: Expand comment.
3081 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3083 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3084 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3086 2011-08-16 Ken Brown <kbrown@cornell.edu>
3088 Fix memory allocation problems in Cygwin build (Bug#9273).
3090 * unexcw.c ( __malloc_initialized): Declare external variable.
3091 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3093 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3095 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3097 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3099 [CYGWIN] (special_realloc): New function.
3100 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3101 requests to realloc storage in the static heap.
3103 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3105 * bidi.c (bidi_initialize): Remove unused local.
3107 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3110 * biditype.h: Remove file.
3111 * makefile.w32-in ($(BLD)/bidi.$(O)):
3112 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3114 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3116 * chartab.c: Improve commentary for the uniprop_table API.
3118 * bidi.c (bidi_paragraph_init): Support zero value of
3119 bidi_ignore_explicit_marks_for_paragraph_level.
3120 (bidi_initialize): Use uniprop_table instead of including
3121 biditype.h and bidimirror.h.
3123 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3124 coordinates of the iterator when restoring from ppos_it.
3127 2011-08-14 Kenichi Handa <handa@m17n.org>
3129 * process.c (create_process): Call setup_process_coding_systems
3130 after the pid of the process is set to -1 (Bug#8162).
3132 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3134 * xdisp.c (move_it_in_display_line_to): Don't invoke
3135 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3136 ppos_it. Fixes vertical cursor motion when line beginning is
3137 covered by an image. (Bug#9296)
3139 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3141 * nsterm.h (ns_run_ascript): Declare.
3142 (NSAPP_DATA2_RUNASSCRIPT): Define.
3144 * nsfns.m (as_script, as_result, as_status): New static variables.
3145 (ns_run_ascript): New function.
3146 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3147 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3148 the event loop. Get status from as_status (Bug#7276).
3150 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3151 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3152 the event loop (Bug#7276).
3154 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3156 * gnutls.c (QCgnutls_bootprop_priority)
3157 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3158 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3159 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3160 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3161 (QCgnutls_bootprop_verify_hostname_error)
3162 (QCgnutls_bootprop_callbacks_verify): Rename from
3163 Qgnutls_bootprop_..., all uses changed.
3165 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3168 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3170 * xfaces.c (Qframe_set_background_mode): Now static.
3171 * dispextern.h (Qframe_set_background_mode): Remove decl.
3173 * process.c (Fnetwork_interface_info): Declare local only if needed.
3175 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3177 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3178 (Fnetwork_interface_list): Allocate in increments of bytes instead
3179 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3180 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3182 (struct ifflag_def): notrailers is smart on OSX.
3183 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3184 Get hardware address with getifaddrs if available.
3186 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3188 * xdisp.c (iterate_out_of_display_property): xassert that
3189 IT->position is set to within IT->object's boundaries. Break from
3190 the loop as soon as EOB is reached; avoids infloops in redisplay
3191 when IT->position is set up wrongly due to some bug.
3192 Set IT->current to match the bidi iterator unconditionally.
3193 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3194 entry. Force push_it to save on the stack the current
3195 buffer/string position, to be restored by pop_it. Fix flags in
3196 the iterator structure wrt the object coming from a display
3197 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3198 properties. (Bug#9284)
3200 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3202 * fontset.c (fontset_get_font_group): Add proper type checks.
3205 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3207 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3208 and LC_VERSION_MIN_MACOSX.
3209 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3210 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3212 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3214 * xdisp.c (forward_to_next_line_start): Allow to use the
3215 no-display-properties-and-no-overlays under bidi display.
3216 Set disp_pos in the bidi iterator to avoid searches for display
3217 properties and overlays.
3219 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3221 * editfns.c (Fset_time_zone_rule): Document relationship with the
3224 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3225 the font entity extracted from the cache (Bug#8109).
3227 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3229 * composite.c (autocmp_chars): Don't reset point. That is done by
3230 restore_point_unwind (Bug#5984).
3232 2011-08-07 Juri Linkov <juri@jurta.org>
3234 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3235 to show the arg `TIME' instead of `TIMEVAL'.
3237 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3239 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3240 display property strides EOL and includes a newline, as in
3241 longlines-mode. (Bug#9254)
3242 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3243 word-wrap under bidirectional display. (Bug#9224)
3245 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3246 is non-zero, even if the data buffer is NULL. Fixes a crash in
3247 vertical-motion with longlines-mode. (Bug#9254)
3249 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3251 * bidi.c <bidi_cache_total_alloc>: Now static.
3252 (bidi_initialize): Initialize bidi_cache_total_alloc.
3254 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3257 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3258 amount allocated this far in `bidi_cache_total_alloc'.
3259 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3260 non-zero, only free the data buffer without restoring the cache
3261 contents. All callers changed.
3263 * dispextern.h (bidi_unshelve_cache): Update prototype.
3265 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3266 (move_it_in_display_line, move_it_to)
3267 (move_it_vertically_backward, move_it_by_lines): Replace the call
3268 to xfree to an equivalent call to bidi_unshelve_cache.
3269 (move_it_in_display_line_to): Fix logic of returning
3270 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3272 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3274 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3275 came from a string character with a `cursor' property. (Bug#9229)
3277 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3279 * Makefile.in (LIB_PTHREAD): New variable.
3280 (LIBES): Add LIB_PTHREAD (Bug#9216).
3282 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3283 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3285 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3287 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3289 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3291 * xterm.c (x_find_topmost_parent): New function.
3292 (x_set_frame_alpha): Find topmost parent window with
3293 x_find_topmost_parent and set the property there also (bug#9181).
3294 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3296 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3298 * callproc.c (Fcall_process): Avoid vfork clobbering
3299 the local vars buffer, coding_systems, current_dir.
3301 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3303 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3305 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3307 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3308 so that it is not optimized away.
3310 * xdisp.c (compute_display_string_pos): Remove unused local.
3312 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3314 Fix slow cursor motion and scrolling in large buffers with
3315 selective display, like Org Mode buffers. (Bug#9218)
3317 * dispextern.h (struct bidi_it): New member disp_prop_p.
3319 * xdisp.c: Remove one-slot cache of display string positions.
3320 (compute_display_string_pos): Accept an additional argument
3321 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3322 for a display string or property. If found, set DISP_PROP_P
3325 * bidi.c (bidi_fetch_char): Accept an additional argument
3326 DISP_PROP_P, and pass it to compute_display_string_pos.
3327 Only handle text covered by a display string if DISP_PROP_P is returned
3328 non-zero. All callers of bidi_fetch_char changed.
3330 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3332 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3334 2010-12-03 Don March <don@ohspite.net>
3336 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3337 last character M-[char] is translated to ESC [char] (bug#7541).
3339 2011-08-02 Kenichi Handa <handa@m17n.org>
3341 * lisp.h (uniprop_table): Extern it.
3343 * chartab.c (uniprop_table): Make it non-static.
3345 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3347 * xdisp.c (forward_to_next_line_start): Accept additional argument
3348 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3350 (reseat_at_next_visible_line_start): Use the bidi iterator state
3351 returned by forward_to_next_line_start to restore the state of
3352 it->bidi_it after backing up to previous newline. (Bug#9212)
3354 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3356 * regex.c (re_comp): Protoize.
3357 (re_exec): Fix return type.
3358 (regexec): Fix type of `ret'. (Bug#9203)
3360 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3362 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3363 This is needed if max-image-size is a floating-point number.
3365 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3367 * print.c (print_object): Print empty symbol as ##.
3369 * lread.c (read1): Read ## as empty symbol.
3371 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3373 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3374 setting frame foreground color (Bug#9175).
3375 (x_set_background_color): Likewise.
3377 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3378 contents (Bug#9176).
3379 (EmacsTooltip -init): Remove bezels and add shadows to
3382 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3383 or scroll bar (Bug#8470).
3385 * nsfont.m (nsfont_open): Remove assignment to voffset and
3386 unnecessary vars hshink, expand, hd, full_height, min_height.
3387 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3389 * nsterm.h (nsfont_info): Remove voffset field.
3391 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3393 Implement strike-through and overline on NextStep (Bug#8863).
3395 * nsfont.m (nsfont_open): Use underline position provided by font,
3396 instead of hard-coded value of 2.
3397 (nsfont_draw): Call ns_draw_text_decoration instead.
3399 * nsterm.h: Add declaration for ns_draw_text_decoration.
3401 * nsterm.m (ns_draw_text_decoration): New function for drawing
3402 underline, overline, and strike-through.
3403 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3404 ns_draw_text_decoration. Change treatment of cursor drawing to
3405 accommodate underlining, etc.
3407 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3409 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3412 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3414 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3415 Without this fix, if a signal arrives just after memory fills up,
3416 'malloc' might be invoked reentrantly.
3418 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3419 In other words, assume that every image size is allowed, on non-X
3420 hosts. This assumption is probably wrong, but it lets Emacs compile.
3422 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3424 * regex.c (re_iswctype): Convert return values to boolean.
3426 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3428 * xdisp.c (compute_display_string_pos): Don't use cached display
3429 string position if the buffer had its restriction changed.
3432 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3434 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3436 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3438 Integer signedness and overflow and related fixes. (Bug#9079)
3440 * bidi.c: Integer size and overflow fixes.
3441 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3442 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3443 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3444 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3445 (bidi_find_other_level_edge):
3446 Use ptrdiff_t instead of EMACS_INT where either will do.
3447 This works better on 32-bit hosts configured --with-wide-int.
3448 (bidi_cache_ensure_space): Check for size-calculation overflow.
3449 Use % rather than repeated addition, for better worst-case speed.
3450 Don't set bidi_cache_size until after xrealloc returns, because it
3452 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3453 (bidi_cache_ensure_space): Also check that the bidi cache size
3454 does not exceed that of the largest Lisp string or buffer. See Eli
3455 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3457 * alloc.c (__malloc_size_t): Remove.
3458 All uses replaced by size_t. See Andreas Schwab's note
3459 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3461 * image.c: Improve checking for integer overflow.
3462 (check_image_size): Assume that f is nonnull, since
3463 it is always nonnull in practice. This is one less thing to
3464 worry about when checking for integer overflow later.
3465 (x_check_image_size): New function, which checks for integer
3466 overflow issues inside X.
3467 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3468 This removes the need for a memory_full check.
3469 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3470 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3471 (xbm_read_bitmap_data): Change locals back to 'int', since
3472 their values must fit in 'int'.
3473 (xpm_load_image, png_load, tiff_load):
3474 Invoke x_create_x_image_and_pixmap earlier,
3475 to avoid much needless work if the image is too large.
3476 (tiff_load): Treat overly large images as if
3477 x_create_x_image_and_pixmap failed, not as malloc failures.
3478 (gs_load): Use x_check_image_size.
3480 * gtkutil.c: Omit integer casts.
3481 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3482 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3484 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3486 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3487 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3488 would wrongly return t on a 64-bit host.
3490 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3491 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3492 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3493 and therefore cause GCC to emit a bogus diagnostic in some cases.
3495 * image.c: Integer signedness and overflow and related fixes.
3496 This is not an exhaustive set of fixes, but it's time to
3497 record what I've got.
3498 (lookup_pixel_color, check_image_size): Remove redundant decls.
3499 (check_image_size): Don't assume that arbitrary EMACS_INT values
3500 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3501 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3502 (tiff_load, imagemagick_load_image):
3503 Check for overflow in size calculations.
3504 (x_create_x_image_and_pixmap): Remove unnecessary test for
3505 xmalloc returning NULL; that can't happen.
3506 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3507 (xpm_color_bucket): Use better integer hashing function.
3508 (xpm_cache_color): Don't possibly over-allocate memory.
3509 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3510 (gif_memory_source):
3511 Use ptrdiff_t, not int or size_t, to record sizes.
3512 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3513 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3514 either works, as we prefer signed integers.
3515 (tiff_read_from_memory, tiff_write_from_memory):
3516 Return tsize_t, not size_t, since that's what the TIFF API wants.
3517 (tiff_read_from_memory): Don't fail simply because the read would
3518 go past EOF; instead, return a short read.
3519 (tiff_load): Omit no-longer-needed casts.
3520 (Fimagemagick_types): Don't assume size fits into 'int'.
3522 Improve hashing quality when configured --with-wide-int.
3523 * fns.c (hash_string): New function, taken from sxhash_string.
3524 Do not discard information about ASCII character case; this
3525 discarding is no longer needed.
3526 (sxhash-string): Use it. Change sig to match it. Caller changed.
3527 * lisp.h: Declare it.
3528 * lread.c (hash_string): Remove, since we now use fns.c's version.
3529 The fns.c version returns a wider integer if --with-wide-int is
3530 specified, so this should help the quality of the hashing a bit.
3532 * emacs.c: Integer overflow minor fix.
3533 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3534 Define only if GNU_LINUX.
3535 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3537 * dispnew.c: Integer signedness and overflow fixes.
3538 Remove unnecessary forward decls, that were a maintenance hassle.
3539 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3541 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3542 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3543 (prepare_desired_row, line_draw_cost):
3544 Use int, not unsigned, where either works.
3545 (save_current_matrix, restore_current_matrix):
3546 Use ptrdiff_t, not size_t, where either works.
3547 (init_display): Check for overflow more accurately, and without
3548 relying on undefined behavior.
3550 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3551 Remove, replacing with the new symbols in lisp.h. All uses changed.
3552 * fileio.c (make_temp_name):
3553 * filelock.c (lock_file_1, lock_file):
3554 * xdisp.c (message_dolog):
3555 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3556 Use pMd etc. instead.
3557 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3558 replacing the pWIDE etc. symbols removed from editfns.c.
3560 * keyboard.h (num_input_events): Now uintmax_t.
3561 This is (very slightly) less likely to mess up due to wraparound.
3564 * buffer.c: Integer signedness fixes.
3565 (alloc_buffer_text, enlarge_buffer_text):
3566 Use ptrdiff_t rather than size_t when either will do, as we prefer
3569 * alloc.c: Integer signedness and overflow fixes.
3570 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3571 (__malloc_size_t): Default to size_t, not to int.
3572 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3573 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3574 Prefer ptrdiff_t to size_t when either would do, as we prefer
3576 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3577 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3578 Now const. Initialize with values that are in range even if char
3580 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3581 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3582 These functions do the right thing with sizes > 2**32.
3583 (check_depth): Now ptrdiff_t, not int.
3584 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3585 Adjust to new way of storing sizes. Check for size overflow bugs
3587 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3588 slightly wrong anyway, as it missed one instance of
3589 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3590 (refill_memory_reserve): Omit needless cast to size_t.
3591 (mark_object_loop_halt): Mark as externally visible.
3593 * xselect.c: Integer signedness and overflow fixes.
3594 (Fx_register_dnd_atom, x_handle_dnd_message):
3595 Use ptrdiff_t, not size_t, since we prefer signed.
3596 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3597 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3598 x_dnd_atoms_size and x_dnd_atoms_length.
3600 * doprnt.c: Prefer signed to unsigned when either works.
3602 * doprnt.c (doprnt):
3604 * xdisp.c (vmessage):
3605 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3606 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3607 prefer signed arithmetic to avoid comparison confusion.
3608 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3609 but is a bit tricky.
3611 Assume freestanding C89 headers, string.h, stdlib.h.
3612 * data.c, doprnt.c, floatfns.c, print.c:
3613 Include float.h unconditionally.
3614 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3615 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3616 * regex.c: Likewise for stddef.h, string.h.
3617 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3618 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3619 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3620 (STDC_HEADERS): Remove obsolete defines.
3621 * sysdep.c: Include limits.h unconditionally.
3623 Assume support for memcmp, memcpy, memmove, memset.
3624 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3625 * regex.c (memcmp, memcpy):
3626 Remove; we assume C89 now.
3628 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3629 (__malloc_safe_bcopy): Remove; no longer needed.
3631 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3632 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3633 well either way, and we prefer signed to unsigned.
3635 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3637 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3638 closes the connection while we're reading (bug#9182).
3640 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3642 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3643 are specified (Bug#9168).
3645 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3647 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3648 Found by GCC static checking and --with-wide-int on a 32-bit host.
3650 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3652 * xdisp.c (compute_display_string_pos): Fix logic of caching
3653 previous display string position. Initialize cached_prev_pos to
3654 -1. Fixes slow-down at the beginning of a buffer.
3656 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3658 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3659 for attrs[LFACE_FONTSET_INDEX].
3661 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3663 * xml.c (parse_region): Remove unused local
3664 that was recently introduced.
3666 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3668 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3669 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3671 * xdisp.c (move_it_in_display_line_to): Record the best matching
3672 position for TO_CHARPOS while scanning the line, and restore it on
3673 exit if none of the characters scanned was an exact match.
3674 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3675 when exact match is impossible due to invisible text, and the
3676 lines are truncated.
3678 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3680 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3683 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3685 Fix a significant slow-down of cursor motion with C-n, C-p,
3686 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3687 auto-repeat under bidi redisplay in fontified buffers.
3688 * xdisp.c (compute_stop_pos_backwards): New function.
3689 (next_element_from_buffer): Call compute_stop_pos_backwards to
3690 find a suitable prev_stop when we find ourselves before
3692 (reseat): Don't look for prev_stop, as that could mean a very long
3694 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3695 <cached_disp_overlay_modiff>: Cache for last found display string
3697 (compute_display_string_pos): Return the cached position if asked
3698 about the same buffer in the same area of character positions, and
3699 the buffer wasn't changed since the time the display string
3700 position was cached.
3702 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3704 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3705 is an integer, which is important for empty lines. (Bug#9149)
3707 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3709 * frame.c (Fmodify_frame_parameters): In tty case, update the
3710 default face if necessary (Bug#4238).
3712 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3714 * editfns.c (Fstring_to_char): No need to explain what a character
3715 is in the docstring (Bug#6576).
3717 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3719 * xml.c (parse_region): Make sure we always return a tree.
3721 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3723 * xml.c (parse_region): If a document contains only comments,
3726 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3728 * xml.c (make_dom): Return comments, too.
3730 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3733 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3734 and the surrounding thread.
3735 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3736 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3737 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3739 * s/openbsd.h (BROKEN_SIGIO): Define.
3740 * unexelf.c (unexec) [__OpenBSD__]:
3741 Don't update the .mdebug section of the Alpha COFF symbol table.
3743 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3745 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3748 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3750 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3751 This fixes some race conditions on the permissions of any newly
3754 * alloc.c (valid_pointer_p): Use pipe, not open.
3755 This fixes some permissions issues when debugging.
3757 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3758 If fchown fails to set both uid and gid, try to set just gid,
3759 as that is sometimes allowed. Adjust the file's mode to eliminate
3760 setuid or setgid bits that are inappropriate if fchown fails.
3762 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3764 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3765 to compare Lisp_Objects.
3766 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3767 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3768 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3770 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3772 * lread.c (read_integer): Unread even EOF character.
3773 (read1): Likewise. Properly record start position of symbol.
3775 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3776 symbol character follows.
3778 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3780 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3781 This works around a problem with the previous change to Fcopy_file.
3782 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3783 and without this change, GCC might complain about discarding
3784 fchown's return value.
3786 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3788 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3790 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3792 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3794 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3796 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3797 it's used from the C level.
3799 * process.c: Use the same condition for POLL_FOR_INPUT in both
3800 keyboard.c and process.c (bug#1858).
3802 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3804 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3805 (Fgnutls_boot): Use it.
3807 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3809 * doc.c (Fsubstitute_command_keys): Revert last change.
3811 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3813 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3814 quotes the next character, and doesn't affect other longer
3815 sequences (bug#8935).
3817 * lread.c (syms_of_lread): Clarify that is isn't only
3818 `eval-buffer' and `eval-defun' that's affected by
3819 `lexical-binding' (bug#8460).
3821 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3823 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3824 bidi redisplay when a line includes both an image and is truncated.
3826 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3828 Fix minor problems found by static checking.
3829 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3830 (elsz): Now a signed constant, not a size_t var. We prefer signed
3831 types to unsigned, to avoid integer comparison confusion. Without
3832 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3833 "cannot optimize loop, the loop counter may overflow", a symptom
3835 * indent.c (Fvertical_motion): Mark locals as initialized.
3836 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3838 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3840 * search.c (Fre_search_backward): Mention `case-fold-search' in
3841 all the re_search_* functions (bug#8138).
3843 * keyboard.c (Fopen_dribble_file): Document when the file is
3846 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3848 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3851 Support bidi reordering of display and overlay strings.
3852 * xdisp.c (compute_display_string_pos)
3853 (compute_display_string_end): Accept additional argument STRING.
3854 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3855 (reseat_to_string): Initialize bidi_it->string.s and
3856 bidi_it->string.schars.
3857 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3858 NULL (avoids a crash in bidi_paragraph_init).
3859 Initialize itb.string.lstring.
3860 (init_iterator): Call bidi_init_it only of a valid
3861 buffer position was specified. Initialize paragraph_embedding to
3863 (reseat_to_string): Initialize the bidi iterator.
3864 (display_string): If we need to ignore text properties of
3865 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3866 original value of -1 will not work with bidi.)
3867 (compute_display_string_pos): First arg is now struct
3868 `text_pos *'; all callers changed. Support display properties on
3870 (compute_display_string_end): Support display properties on Lisp
3872 (init_iterator, reseat_1, reseat_to_string): Initialize the
3873 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3874 when iterating on a string not from display properties).
3875 (compute_display_string_pos, compute_display_string_end):
3876 Fix calculation of the object to scan. Fixes an error when using
3878 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3879 base_level_stop; instead, set base_level_stop to BEGV.
3880 Fixes crashes in vertical-motion.
3881 (next_element_from_buffer): Improve commentary for when
3882 the iterator is before prev_stop.
3883 (init_iterator): Initialize bidi_p from the default value of
3884 bidi-display-reordering, not from buffer-local value. Use the
3885 buffer-local value only if initializing for buffer iteration.
3886 (handle_invisible_prop): Support invisible properties on strings
3887 that are being bidi-reordered.
3888 (set_iterator_to_next): Support bidi reordering of C strings and
3890 (next_element_from_string): Support bidi reordering of Lisp
3892 (handle_stop_backwards): Support Lisp strings as well.
3893 (display_string): Support display of R2L glyph rows.
3894 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3895 (init_iterator): Don't initialize it->bidi_p for strings
3897 (reseat_to_string): Initialize it->bidi_p for strings here.
3898 (next_element_from_string, next_element_from_c_string)
3899 (next_element_from_buffer): Add xassert's for correspondence
3900 between IT's object being iterated and it->bidi_it.string
3902 (face_before_or_after_it_pos): Support bidi iteration.
3903 (next_element_from_c_string): Handle the case of the first string
3904 character that is not the first one in the visual order.
3905 (get_visually_first_element): New function, refactored from common
3906 parts of next_element_from_buffer, next_element_from_string, and
3907 next_element_from_c_string.
3908 (tool_bar_lines_needed, redisplay_tool_bar)
3909 (display_menu_bar): Force left-to-right direction. Add a FIXME
3910 comment for making that be controlled by a user option.
3911 (push_it, pop_it): Save and restore the state of the
3912 bidi iterator. Save and restore the bidi_p flag.
3913 (pop_it): Iterate out of display property for string iteration as
3915 (iterate_out_of_display_property): Support iteration over strings.
3916 (handle_single_display_spec): Set up it->bidi_it for iteration
3917 over a display string, and call bidi_init_it.
3918 (handle_single_display_spec, next_overlay_string)
3919 (get_overlay_strings_1, push_display_prop): Set up the bidi
3920 iterator for displaying display or overlay strings.
3921 (forward_to_next_line_start): Don't use the shortcut if
3923 (back_to_previous_visible_line_start): If handle_display_prop
3924 pushed the iterator stack, restore the internal state of the bidi
3925 iterator by calling bidi_pop_it same number of times.
3926 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3927 and we are bidi-iterating, don't decrement the iterator position;
3928 instead, set the first_elt flag in the bidi iterator, to produce
3930 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3931 (push_display_prop): xassert that we are iterating a buffer.
3932 (push_it, pop_it): Save and restore paragraph_embedding member.
3933 (handle_single_display_spec, next_overlay_string)
3934 (get_overlay_strings_1, reseat_1, reseat_to_string)
3935 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3936 correctly. Don't assume unibyte strings are not bidi-reordered.
3937 (compute_display_string_pos)
3938 (compute_display_string_end): Fix handling the case of C string.
3939 (push_it, pop_it): Save and restore from_disp_prop_p.
3940 (handle_single_display_spec, push_display_prop): Set the
3941 from_disp_prop_p flag.
3942 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3943 (pop_it): Call iterate_out_of_display_property only if we are
3944 popping after iteration over a string that came from a display
3945 property. Fix a typo in popping stretch info. Add an assertion
3946 for verifying that the iterator position is in sync with the bidi
3948 (handle_single_display_spec, get_overlay_strings_1)
3949 (push_display_prop): Fix initialization of paragraph direction for
3950 string when that of the parent object is not yet determined.
3951 (reseat_1): Call bidi_init_it to resync the bidi
3952 iterator with IT's position. (Bug#7616)
3953 (find_row_edges): If ROW->start.pos gives position
3954 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3955 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3956 Reset the from_disp_prop_p flag.
3957 (SAVE_IT, RESTORE_IT): New macros.
3958 (pos_visible_p, face_before_or_after_it_pos)
3959 (back_to_previous_visible_line_start)
3960 (move_it_in_display_line_to, move_it_in_display_line)
3961 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3962 (try_scrolling, redisplay_window, display_line): Use them when
3963 saving a temporary copy of the iterator and restoring it back.
3964 (back_to_previous_visible_line_start, reseat_1)
3965 (init_iterator): Empty the bidi cache "stack".
3966 (move_it_in_display_line_to): If iterator ended up at
3967 EOL, but we never saw any buffer positions smaller than
3968 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3969 motion in bidi-reordered lines.
3970 (move_it_in_display_line_to): Record prev_method and prev_pos
3971 immediately before the call to set_iterator_to_next. Fixes cursor
3972 motion in bidi-reordered lines with stretch glyphs and strings
3973 displayed in margins. (Bug#8133) (Bug#8867)
3974 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3976 (pos_visible_p): Support positions in bidi-reordered lines.
3977 Save and restore bidi cache.
3979 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3980 (bidi_paragraph_info): Delete unused struct.
3981 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3982 (bidi_cache_start): New variable.
3983 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3985 (bidi_cache_fetch_state, bidi_cache_search)
3986 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3987 (bidi_cache_find, bidi_peek_at_next_level)
3988 (bidi_level_of_next_char, bidi_find_other_level_edge)
3989 (bidi_move_to_visually_next): Compare cache index with
3990 bidi_cache_start rather than with zero.
3991 (bidi_fetch_char): Accept new argument STRING; all callers
3992 changed. Support iteration over a string. Support strings with
3993 display properties. Support unibyte strings. Fix the type of
3994 `len' according to what STRING_CHAR_AND_LENGTH expects.
3995 (bidi_paragraph_init, bidi_resolve_explicit_1)
3996 (bidi_resolve_explicit, bidi_resolve_weak)
3997 (bidi_level_of_next_char, bidi_move_to_visually_next):
3998 Support iteration over a string.
3999 (bidi_set_sor_type, bidi_resolve_explicit_1)
4000 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4001 can now be zero (for strings); special values 0 and -1 were
4002 changed to -1 and -2, respectively.
4003 (bidi_char_at_pos): New function.
4004 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4005 Call it instead of FETCH_MULTIBYTE_CHAR.
4006 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4007 initialized to valid values.
4008 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4010 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4011 the test for valid cached positions. Fix the logic for looking up
4012 the sentinel state in the cache. GCPRO the Lisp string we are
4014 (bidi_push_it, bidi_pop_it): New functions.
4015 (bidi_initialize): Initialize the bidi cache start stack pointer.
4016 (bidi_cache_ensure_space): New function, refactored from part of
4017 bidi_cache_iterator_state. Don't assume the required size is just
4018 one BIDI_CACHE_CHUNK away.
4019 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4020 (bidi_count_bytes, bidi_char_at_pos): New functions.
4021 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4022 always valid if bidi_cache_idx is valid.
4023 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4024 is valid if it's going to be used.
4025 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4026 (bidi_cache_fetch_state, bidi_cache_search)
4027 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4028 (bidi_cache_iterator_state, bidi_cache_find)
4029 (bidi_find_other_level_edge, bidi_cache_start_stack):
4030 All variables related to cache indices are now EMACS_INT.
4032 * dispextern.h (struct bidi_string_data): New structure.
4033 (struct bidi_it): New member `string'. Make flag members be 1-bit
4034 fields, and put them last in the struct.
4035 (compute_display_string_pos, compute_display_string_end):
4037 (bidi_push_it, bidi_pop_it): Add prototypes.
4038 (struct iterator_stack_entry): New members bidi_p,
4039 paragraph_embedding, and from_disp_prop_p.
4040 (struct it): Member bidi_p is now a bit field 1 bit wide.
4041 (bidi_shelve_cache, bidi_unshelve_cache):
4044 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4045 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4046 and vector-like objects.
4048 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4049 cache around display iteration.
4051 * window.c (Fwindow_end, window_scroll_pixel_based)
4052 (displayed_window_lines, Frecenter): Save and restore the bidi
4053 cache around display iteration.
4055 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4057 * editfns.c (Fdelete_region): Clarify the use of the named
4058 parameters (bug#6788).
4060 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4062 * indent.c (Fvertical_motion): Set and restore w->pointm when
4063 saving and restoring the window's buffer (Bug#9006).
4065 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4067 * editfns.c (Fstring_to_char): Clarify just what is returned
4068 (bug#6576). Text by Eli Zaretskii.
4070 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4072 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4074 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4076 * buffer.c (mmap_find): Fix a typo.
4078 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4080 Fix execution of x selection hooks.
4081 * xselect.c (Qx_lost_selection_functions)
4082 (Qx_sent_selection_functions): New vars.
4083 (syms_of_xselect): DEFSYM them.
4084 (x_handle_selection_request): Pass Qx_sent_selection_functions
4085 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4086 (x_handle_selection_clear,x_clear_frame_selections):
4087 Pass Qx_lost_selection_functions rather than
4088 Vx_lost_selection_functions to Frun_hook_with_args.
4090 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4092 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4093 The old code sometimes used this field without initializing it.
4095 * alloc.c (gc_sweep): Don't read past end of array.
4096 In theory, the old code could also have corrupted Emacs internals,
4097 though it'd be very unlikely.
4099 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4101 * character.c (Fcharacterp): Don't advertise optional ignored
4102 argument. (Bug#4026)
4104 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4106 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4109 * window.c (Fset_window_start): Doc fix (bug#4199).
4110 (Fset_window_hscroll): Ditto.
4112 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4114 Fix minor new problems caught by GCC 4.6.1.
4115 * term.c (init_tty): Remove unused local.
4116 * xsettings.c (store_monospaced_changed): Define this function only
4117 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4120 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4122 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4124 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4126 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4127 are the mini-buffer and the echo area (bug#3320).
4129 * term.c (init_tty): Remove support for supdup, c10 and perq
4130 terminals, which are no longer supported (bug#1482).
4132 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4134 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4136 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4138 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4139 for non-popups (Bug#3642).
4141 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4143 * alloc.c (reset_malloc_hooks): Protoize.
4144 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4145 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4146 * cm.c (losecursor): Likewise.
4147 * data.c (fmod): Likewise.
4148 * dispnew.c (swap_glyphs_in_rows): Likewise.
4149 * emacs.c (memory_warning_signal): Likewise.
4150 * floatfns.c (float_error): Likewise.
4151 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4152 (otf_open, font_otf_capability, generate_otf_features)
4153 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4155 * image.c (pbm_read_file): Likewise.
4156 * indent.c (string_display_width): Likewise.
4157 * intervals.c (check_for_interval, search_for_interval)
4158 (inc_interval_count, count_intervals, root_interval)
4159 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4160 * lread.c (defalias): Likewise.
4161 * ralloc.c (r_alloc_check): Likewise.
4162 * regex.c (set_image_of_range_1, set_image_of_range)
4163 (regex_grow_registers): Likewise.
4164 * sysdep.c (strerror): Likewise.
4165 * termcap.c (valid_filename_p, tprint, main): Likewise.
4166 * tparam.c (main): Likewise.
4167 * unexhp9k800.c (run_time_remap, save_data_space)
4168 (update_file_ptrs, read_header, write_header, calculate_checksum)
4169 (copy_file, copy_rest, display_header): Likewise.
4170 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4172 * xdisp.c (check_it): Likewise.
4173 * xfaces.c (register_color, unregister_color, unregister_colors):
4175 * xfns.c (print_fontset_result): Likewise.
4176 * xrdb.c (member, fatal, main): Likewise.
4178 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4180 Fix minor problems found by static checking (Bug#9031).
4181 * chartab.c (char_table_set_range, map_sub_char_table):
4182 Remove unused locals.
4183 (uniprop_table): Now static.
4184 * composite.c (_work_char): Remove unused static var.
4186 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4188 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4190 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4192 * gtkutil.c (qttip_cb): Remove code without function.
4194 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4196 * w32.c (pthread_sigmask): New stub.
4198 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4200 Use pthread_sigmask, not sigprocmask (Bug#9010).
4201 sigprocmask is portable only for single-threaded applications, and
4202 Emacs can be multi-threaded when it uses GTK.
4203 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4205 * callproc.c (Fcall_process):
4206 * process.c (create_process):
4207 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4208 Use pthread_sigmask, not sigprocmask.
4210 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4212 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4213 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4216 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4218 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4219 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4220 (xg_hide_tooltip): Fix comment.
4222 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4223 in registerServicesMenuSendTypes.
4224 (validRequestorForSendType): Don't check ns_return_types.
4226 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4229 2011-07-08 Jason Rumney <jasonr@gnu.org>
4231 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4232 SH_SHOW for hidden windows (Bug#5482).
4234 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4235 frame struct members of non-existent frames (Bug#6284).
4237 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4239 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4240 variable firstTime not needed on OSX >= 10.6.
4241 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4242 >= 10.5. Use setKnobProportion, setDoubleValue.
4244 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4245 (MAC_OS_X_VERSION_10_5): Define if not defined.
4246 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4247 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4248 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4250 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4251 cString and lossyCString on OSX >= 10.4
4253 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4254 sizeToFit on OSX >= 10.2.
4256 * nsimage.m (allocInitFromFile): Don't use deprecated method
4257 bestRepresentationForDevice on OSX >= 10.6.
4259 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4262 * emacs.c: Declare unexec_init_emacs_zone.
4264 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4266 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4268 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4269 on svcsMenu (Bug#8842).
4271 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4273 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4275 * nsterm.m (QUTF8_STRING): Declare.
4276 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4277 (validRequestorForSendType): Return type is (id).
4278 Change indexOfObjectIdenticalTo to indexOfObject.
4279 Check if we have local selection before returning self (Bug#8842).
4280 (writeSelectionToPasteboard): Put local selection into paste board
4281 if we have a local selection (Bug#8842).
4282 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4284 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4285 (ns_get_local_selection): Declare.
4287 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4289 * keymap.c (describe_map_tree): Don't insert a double newline at
4290 the end of the buffer (bug#1169) and return whether we inserted
4293 * callint.c (Fcall_interactively): Change "reading args" to
4294 "providing args" to try to clarify what it does (bug#1010).
4296 2011-07-07 Kenichi Handa <handa@m17n.org>
4298 * composite.c (composition_compute_stop_pos): Ignore a static
4299 composition starting before CHARPOS (Bug#8915).
4301 * xdisp.c (handle_composition_prop): Likewise.
4303 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4305 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4308 2011-07-07 Kenichi Handa <handa@m17n.org>
4310 * character.h (unicode_category_t): New enum type.
4312 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4313 (Qchar_code_property_table): New variable.
4314 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4315 (UNIPROP_COMPRESSED_FORM_P): New macros.
4316 (char_table_ascii): Uncompress the compressed values.
4317 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4318 Uncompress the compressed values.
4319 (sub_char_table_ref_and_range): Likewise.
4320 (char_table_ref_and_range): Uncompress the compressed values.
4321 (sub_char_table_set): New arg is_uniprop. Callers changed.
4322 Uncompress the compressed values.
4323 (sub_char_table_set_range): Args changed. Callers changed.
4324 (char_table_set_range): Adjuted for the above change.
4325 (map_sub_char_table): Delete args default_val and parent. Add arg
4326 top. Give decoded values to a Lisp function.
4327 (map_char_table): Adjust for the above change. Give decoded
4328 values to a Lisp function. Gcpro more variables.
4329 (uniprop_table_uncompress)
4330 (uniprop_decode_value_run_length): New functions.
4331 (uniprop_decoder, uniprop_decoder_count): New variables.
4332 (uniprop_get_decoder, uniprop_encode_value_character)
4333 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4335 (uniprop_encoder, uniprop_encoder_count): New variables.
4336 (uniprop_get_encoder, uniprop_table)
4337 (Funicode_property_table_internal, Fget_unicode_property_internal)
4338 (Fput_unicode_property_internal): New functions.
4339 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4340 Sunicode_property_table_internal, Sget_unicode_property_internal,
4341 and Sput_unicode_property_internal. Defvar_lisp
4342 char-code-property-alist.
4344 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4345 Vunicode_category_table.
4347 * font.c (font_range): Adjust for the change of
4348 Vunicode_category_table.
4350 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4352 * m/iris4d.h: Remove file, move contents ...
4353 * s/irix6-5.h: ... here.
4355 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4357 Remove unportable assumption about struct layout (Bug#8884).
4358 * alloc.c (mark_buffer):
4359 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4360 (clone_per_buffer_values): Don't assume that
4361 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4362 This isn't true in general, and it's particularly not true
4363 if Emacs is configured with --with-wide-int.
4364 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4365 New macros, used in the buffer.c change.
4367 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4369 * xsettings.c: Use both GConf and GSettings if both are available.
4370 (store_config_changed_event): Add comment.
4371 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4372 (store_tool_bar_style_changed): New functions.
4373 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4374 (struct xsettings): Move font inside HAVE_XFT.
4375 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4376 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4377 Move inside HAVE_XFT.
4378 (something_changed_gsettingsCB): Rename from something_changedCB.
4379 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4381 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4382 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4383 (something_changed_gconfCB): Rename from something_changedCB.
4384 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4385 (parse_settings): Move check for font inside HAVE_XFT.
4386 (read_settings, apply_xft_settings): Add comment.
4387 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4388 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4389 call store_font_name_changed.
4390 (xft_settings_event): Add comment.
4391 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4392 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4393 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4394 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4395 (xsettings_initialize): Call init_gsettings last.
4396 (xsettings_get_system_font, xsettings_get_system_normal_font):
4399 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4401 Random fixes. E.g., (random) never returned negative values.
4402 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4403 subseconds part to the entropy, as that's a bit more random.
4404 Prefer signed to unsigned, since the signedness doesn't matter and
4405 in general we prefer signed. When given a limit, use a
4406 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4407 latter isn't right if USE_2_TAGS_FOR_INTS.
4408 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4409 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4411 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4413 * textprop.c (text_property_stickiness):
4414 Obey Vtext_property_default_nonsticky.
4415 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4416 * w32fns.c (syms_of_w32fns):
4417 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4419 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4421 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4422 This is more efficient than Ffile_directory_p and avoids a minor race.
4424 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4426 * buffer.c (Foverlay_put): Say what the return value is
4429 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4430 is a directory before asking whether to use the file name
4432 (barf_or_query_if_file_exists): Make the "File is a directory"
4433 error be more correct.
4435 * fns.c (Frequire): Remove the mention of the .gz files, since
4436 that's installation-specific, but keep the mention of
4437 `get-load-suffixes'.
4439 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4441 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4442 Report string overflow if the output is too long.
4444 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4446 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4447 (syms_of_gnutls): Remove duplicate DEFSYM for
4448 Qgnutls_bootprop_verify_hostname_error, an error for
4449 Qgnutls_bootprop_verify_error (which is no longer used).
4451 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4452 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4453 Also (re)move comments that are misplaced or no longer relevant.
4455 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4457 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4459 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4461 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4462 and background color parameters if they have been changed.
4464 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4466 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4468 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4470 * xsettings.c (SYSTEM_FONT): Define only when used.
4471 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4473 * keymap.c (access_keymap_1): Now static.
4475 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4477 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4478 leave any prefix arg for the up event (Bug#1586).
4480 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4482 * lread.c (syms_of_lread): Mention single symbols defined by
4483 `defvar' or `defconst' (bug#7154).
4485 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4486 (Frequire): Mention get-load-suffixes.
4488 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4490 * window.h (window): Remove clone_number slot.
4491 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4493 (make_parent_window, make_window, saved_window)
4494 (Fset_window_configuration, save_window_save): Don't deal with
4496 * buffer.c (Qclone_number): Remove declaration.
4497 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4499 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4501 Add multiple inheritance to keymaps.
4502 * keymap.c (Fmake_composed_keymap): New function.
4503 (Fset_keymap_parent): Simplify.
4504 (fix_submap_inheritance): Remove.
4505 (access_keymap_1): New function extracted from access_keymap to handle
4506 embedded parents and handle lists of maps.
4507 (access_keymap): Use it.
4508 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4509 (Fcopy_keymap): Handle embedded parents.
4510 (Fcommand_remapping, define_as_prefix): Simplify.
4511 (Fkey_binding): Simplify.
4512 (syms_of_keymap): Move minibuffer-local-completion-map,
4513 minibuffer-local-filename-completion-map,
4514 minibuffer-local-must-match-map, and
4515 minibuffer-local-filename-must-match-map to Elisp.
4516 (syms_of_keymap): Defsubr make-composed-keymap.
4517 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4518 (parse_menu_item): Trivial simplification.
4520 2011-07-01 Glenn Morris <rgm@gnu.org>
4522 * Makefile.in (SETTINGS_LIBS): Fix typo.
4524 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4526 * coding.c (Fencode_coding_string): Record the last coding system
4527 used, as the function doc string says (bug#8738).
4529 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4531 * xsettings.c (store_monospaced_changed): Take new font as arg and
4532 check for change against current_mono_font.
4533 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4534 (emacs_settings_constructor, emacs_settings_get_property)
4535 (emacs_settings_set_property, emacs_settings_class_init)
4536 (emacs_settings_init, gsettings_obj): Remove.
4537 (something_changedCB): New function for HAVE_GSETTINGS.
4538 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4539 with value as argument.
4540 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4541 g_settings_new (Bug#8967). Do not create gsettings_obj.
4542 Remove calls to g_settings_bind. Connect something_changedCB to
4545 * xgselect.c: Add defined (HAVE_GSETTINGS).
4546 (xgselect_initialize): Ditto.
4548 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4549 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4552 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4554 * eval.c (struct backtrace): Simplify and port the data structure.
4555 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4556 signed bit field, as this assumption is not portable and it makes
4557 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4558 "char debug_on_exit : 1" as this is not portable either; instead,
4559 use the portable "unsigned int debug_on_exit : 1". Remove unused
4560 member evalargs. Remove obsolete comments about cc bombing out.
4562 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4564 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4565 Let HAVE_GSETTINGS override HAVE_GCONF.
4566 (store_monospaced_changed): New function.
4567 (EMACS_SETTINGS): A new type derived from GObject to handle
4568 GSettings notifications.
4569 (emacs_settings_constructor, emacs_settings_get_property)
4570 (emacs_settings_set_property, emacs_settings_class_init):
4572 (gsettings_client, gsettings_obj): New variables.
4573 (GSETTINGS_SCHEMA): New define.
4574 (something_changedCB): Call store_monospaced_changed.
4575 (init_gsettings): New function.
4576 (xsettings_initialize): Call init_gsettings.
4577 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4580 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4583 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4585 * window.c (resize_root_window, grow_mini_window)
4586 (shrink_mini_window): Rename Qresize_root_window to
4587 Qwindow_resize_root_window and Qresize_root_window_vertically to
4588 Qwindow_resize_root_window_vertically.
4590 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4592 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4594 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4596 * makefile.w32-in: Redesign dependencies so they reflect more
4597 clearly which files are directly included by each source file,
4598 and not through other includes.
4600 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4602 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4603 (sort_overlays, overlay_strings): When an overlay's clone number
4604 matches the window's clone number process the overlay even if
4605 the overlay's window property doesn't match the current window.
4607 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4608 (Fwindow_hchild): Rename to Fwindow_left_child.
4609 (Fwindow_next): Rename to Fwindow_next_sibling.
4610 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4611 (resize_window_check): Rename to window_resize_check.
4612 (resize_window_apply): Rename to window_resize_apply.
4613 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4614 (Fdelete_other_windows_internal, resize_frame_windows)
4615 (Fsplit_window_internal, Fdelete_window_internal)
4616 (grow_mini_window, shrink_mini_window)
4617 (Fresize_mini_window_internal): Fix callers accordingly.
4619 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4621 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4622 (emacs_fixed_set_min_size): Remove.
4623 (emacs_fixed_new): Take frame as argument.
4625 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4626 (_EmacsFixedPrivate): Remove minwidth/height.
4627 Add struct frame *f.
4628 (emacs_fixed_init): Initialize priv->f.
4629 (get_parent_class, emacs_fixed_set_min_size): Remove.
4630 (emacs_fixed_new): Set priv->f to argument.
4631 (emacs_fixed_get_preferred_width)
4632 (emacs_fixed_get_preferred_height): Use min_width/height from
4633 frames size_hint to set minimum and natural (Bug#8919).
4634 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4635 and use min_width/height from frames size_hint to set
4636 min_width/height (Bug#8919).
4638 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4639 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4642 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4644 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4645 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4648 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4650 * process.c (wait_reading_process_output): Bypass select if
4651 waiting for a cell while ignoring keyboard input, and input is
4652 pending. Suggested by Jan Djärv (Bug#8869).
4654 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4656 Use gnulib's dup2 module instead of rolling our own.
4657 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4659 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4661 * dispnew.c (scrolling_window): Before scrolling, turn off a
4662 mouse-highlight in the window being scrolled.
4664 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4666 Move DEFSYM to lisp.h and use everywhere.
4668 * character.h (DEFSYM): Move declaration...
4669 * lisp.h (DEFSYM): ...here.
4675 * w32select.c: Don't include character.h.
4677 * alloc.c (syms_of_alloc):
4678 * buffer.c (syms_of_buffer):
4679 * bytecode.c (syms_of_bytecode):
4680 * callint.c (syms_of_callint):
4681 * casefiddle.c (syms_of_casefiddle):
4682 * casetab.c (init_casetab_once):
4683 * category.c (init_category_once, syms_of_category):
4684 * ccl.c (syms_of_ccl):
4685 * cmds.c (syms_of_cmds):
4686 * composite.c (syms_of_composite):
4687 * dbusbind.c (syms_of_dbusbind):
4688 * dired.c (syms_of_dired):
4689 * dispnew.c (syms_of_display):
4690 * doc.c (syms_of_doc):
4691 * editfns.c (syms_of_editfns):
4692 * emacs.c (syms_of_emacs):
4693 * eval.c (syms_of_eval):
4694 * fileio.c (syms_of_fileio):
4695 * fns.c (syms_of_fns):
4696 * frame.c (syms_of_frame):
4697 * fringe.c (syms_of_fringe):
4698 * insdel.c (syms_of_insdel):
4699 * keymap.c (syms_of_keymap):
4700 * lread.c (init_obarray, syms_of_lread):
4701 * macros.c (syms_of_macros):
4702 * msdos.c (syms_of_msdos):
4703 * print.c (syms_of_print):
4704 * process.c (syms_of_process):
4705 * search.c (syms_of_search):
4706 * sound.c (syms_of_sound):
4707 * syntax.c (init_syntax_once, syms_of_syntax):
4708 * terminal.c (syms_of_terminal):
4709 * textprop.c (syms_of_textprop):
4710 * undo.c (syms_of_undo):
4711 * w32.c (globals_of_w32):
4712 * window.c (syms_of_window):
4713 * xdisp.c (syms_of_xdisp):
4714 * xfaces.c (syms_of_xfaces):
4715 * xfns.c (syms_of_xfns):
4716 * xmenu.c (syms_of_xmenu):
4717 * xsettings.c (syms_of_xsettings):
4718 * xterm.c (syms_of_xterm): Use DEFSYM.
4720 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4722 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4724 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4726 Integer and buffer overflow fixes (Bug#8873).
4728 * print.c (printchar, strout): Check for string overflow.
4729 (PRINTPREPARE, printchar, strout):
4730 Don't set size unless allocation succeeds.
4732 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4733 for sizes. Check for string overflow more accurately.
4734 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4736 * macros.c: Integer and buffer overflow fixes.
4737 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4738 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4739 Use ptrdiff_t, not int, for sizes.
4740 Don't increment bufsize until after realloc succeeds.
4741 Check for size-calculation overflow.
4742 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4744 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4746 * lread.c: Integer overflow fixes.
4747 (read_integer): Radix is now EMACS_INT, not int,
4748 to improve quality of diagnostics for out-of-range radices.
4749 Calculate buffer size correctly for out-of-range radices.
4750 (read1): Check for integer overflow in radices, and in
4751 read-circle numbers.
4752 (read_escape): Avoid int overflow.
4753 (Fload, openp, read_buffer_size, read1)
4754 (substitute_object_recurse, read_vector, read_list, map_obarray):
4755 Use ptrdiff_t, not int, for sizes.
4756 (read1): Use EMACS_INT, not int, for sizes.
4757 Check for size overflow.
4759 * image.c (cache_image): Check for size arithmetic overflow.
4761 * lread.c: Integer overflow issues.
4762 (saved_doc_string_size, saved_doc_string_length)
4763 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4764 Now ptrdiff_t, not int.
4765 (read1): Don't assume doc string length fits in int. Check for
4766 out-of-range doc string lengths.
4767 (read_list): Don't assume file position fits in int.
4768 (read_escape): Check for hex character overflow.
4770 2011-06-22 Leo Liu <sdl.web@gmail.com>
4772 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4773 Move to minibuffer.el.
4775 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4777 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4778 The following patches are for when GLYPH_DEBUG && !XASSERT.
4779 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4780 * dispnew.c (flush_stdout):
4781 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4782 Mark as externally visible.
4783 * dispnew.c (check_window_matrix_pointers): Now static.
4784 * dispnew.c (window_to_frame_vpos):
4785 * xfns.c (unwind_create_frame):
4786 * xterm.c (x_check_font): Remove unused local.
4787 * scroll.c (CHECK_BOUNDS):
4788 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4789 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4790 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4791 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4792 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4794 (debug_method_add): Use va_list and vsprintf rather than relying
4795 on undefined behavior with wrong number of arguments.
4796 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4797 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4798 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4799 since we're not interested in debugging glyphs with old libraries.
4800 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4801 GCC 4.6.0's static checking.
4803 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4805 Integer overflow and signedness fixes (Bug#8873).
4806 A few related buffer overrun fixes, too.
4808 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4810 * dispextern.h (struct face.stipple):
4811 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4812 (x_bitmap_mask, x_allocate_bitmap_record)
4813 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4814 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4815 (x_create_bitmap_from_xpm_data):
4816 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4817 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4819 * xfaces.c (load_pixmap):
4820 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4821 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4822 (.bitmaps_last, struct x_output.icon_bitmap):
4823 Use ptrdiff_t, not int, for bitmap indexes.
4824 (x_allocate_bitmap_record): Check for size overflow.
4825 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4827 Use ptrdiff_t, not int, for overlay counts.
4828 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4829 * editfns.c (overlays_around, get_pos_property):
4830 * textprop.c (get_char_property_and_overlay):
4831 * xdisp.c (next_overlay_change, note_mouse_highlight):
4832 * xfaces.c (face_at_buffer_position):
4833 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4834 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4835 (Fnext_overlay_change, Fprevious_overlay_change)
4836 (mouse_face_overlay_overlaps, Foverlays_in):
4837 Use ptrdiff_t, not int, for sizes.
4838 (overlays_at, overlays_in): Check for size-calculation overflow.
4840 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4842 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4843 (x_session_initialize): Do not assume string length fits in int.
4845 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4846 This is unlikely, but can occur if DPI is outlandish.
4848 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4849 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4851 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4852 * xrdb.c (magic_file_p, search_magic_path):
4853 Omit last arg SUFFIX; it was always 0. All callers changed.
4854 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4856 * xfont.c (xfont_match): Avoid need for strlen.
4858 * xfns.c: Don't assume strlen fits in int.
4859 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4861 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4862 not unsigned long, as we prefer signed integers. All callers changed.
4863 Detect integer overflow in repeat count.
4864 (message_dolog): Don't assume print length fits in 39 bytes.
4865 (display_mode_element): Don't assume strlen fits in int.
4867 * termcap.c: Don't assume sizes fit in int and never overflow.
4868 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4869 (gobble_line): Check for size-calculation overflow.
4871 * minibuf.c (Fread_buffer):
4872 * lread.c (intern, intern_c_string):
4873 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4874 Don't assume string length fits in int.
4876 * keyboard.c (parse_tool_bar_item):
4877 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4879 * font.c: Don't assume string length fits in int.
4880 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4881 Use ptrdiff_t, not int.
4882 (font_intern_prop): Don't assume string length fits in int.
4883 Don't assume integer property fits in fixnum.
4884 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4886 * filelock.c: Fix some buffer overrun and integer overflow issues.
4887 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4888 Reformulate so as not to need the command string.
4889 Invoke gzip -cd rather than gunzip, as it's more portable.
4890 (lock_info_type, lock_file_1, lock_file):
4891 Don't assume pid_t and time_t fit in unsigned long.
4892 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4893 (current_lock_owner): Prefer signed type for sizes.
4894 Use memcpy, not strncpy, where memcpy is what is really wanted.
4895 Don't assume (via atoi) that time_t and pid_t fit in int.
4896 Check for time_t and/or pid_t out of range, e.g., via a network share.
4897 Don't alloca where an auto var works fine.
4899 * fileio.c: Fix some integer overflow issues.
4900 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4901 Don't assume string length fits in int.
4902 (directory_file_name): Don't assume string length fits in long.
4903 (make_temp_name): Don't assume pid fits in int, or that its print
4904 length is less than 20.
4906 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4908 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4910 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4912 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4913 We prefer signed integers, even for size calculations.
4915 * emacs.c: Don't assume string length fits in 'int'.
4916 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4917 (main): Don't invoke strlen when not needed.
4919 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4920 (XD_DEBUG_MESSAGE): Don't waste a byte.
4922 * callproc.c (getenv_internal_1, getenv_internal)
4924 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4926 * lread.c (invalid_syntax): Omit length argument.
4927 All uses changed. This doesn't fix a bug, but it simplifies the
4928 code away from its former Hollerith-constant appearance, and it's
4929 one less 'int' to worry about when looking at integer-overflow issues.
4930 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4932 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4933 This didn't break anything, but it didn't help either.
4934 It's confusing to put a bogus integer in a place where the actual
4935 value does not matter.
4936 (LIST_END_P): Remove unused macro and its bogus comment.
4937 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4939 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4940 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4942 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4943 We prefer signed types, and the value cannot exceed the EMACS_INT
4944 range anyway (because otherwise the length would not be representable).
4945 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4946 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4947 This avoids a GCC warning when WIDE_EMACS_INT.
4949 * indent.c (sane_tab_width): New function.
4950 (current_column, scan_for_column, Findent_to, position_indentation)
4951 (compute_motion): Use it. This is just for clarity.
4952 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4954 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4956 * lisp.h (lint_assume): New macro.
4957 * composite.c (composition_gstring_put_cache):
4958 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4960 * editfns.c, insdel.c:
4961 Omit unnecessary forward decls, to simplify future changes.
4963 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4965 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4967 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4968 Use much-faster test for byte-length change.
4969 Don't assume string byte-length fits in 'int'.
4970 Check that character arg fits in 'int'.
4971 (mapcar1): Declare byte as byte, for clarity.
4973 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4975 * fns.c (concat): Catch string overflow earlier.
4976 Do not rely on integer wraparound.
4978 * dispextern.h (struct it.overlay_strings_charpos)
4979 (struct it.selective): Now EMACS_INT, not int.
4980 * xdisp.c (forward_to_next_line_start)
4981 (back_to_previous_visible_line_start)
4982 (reseat_at_next_visible_line_start, next_element_from_buffer):
4983 Don't arbitrarily truncate the value of 'selective' to int.
4985 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4987 * composite.c: Don't truncate sizes to 'int'.
4988 (composition_gstring_p, composition_reseat_it)
4989 (composition_adjust_point): Use EMACS_INT, not int.
4990 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4991 not EMACS_UINT, for indexes.
4993 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4995 * buffer.c: Include <verify.h>.
4996 (struct sortvec.priority, struct sortstr.priority):
4997 Now EMACS_INT, not int.
4998 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4999 (struct sortstr.size, record_overlay_string)
5000 (struct sortstrlist.size, struct sortlist.used):
5001 Don't truncate size to int.
5002 (record_overlay_string): Check for size-calculation overflow.
5003 (init_buffer_once): Check at compile-time, not run-time.
5005 2011-06-22 Jim Meyering <meyering@redhat.com>
5007 Don't leak an XBM-image-sized buffer
5008 * image.c (xbm_load): Free the image buffer after using it.
5010 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5013 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5014 that Sun C diagnosed.
5015 * fns.c (secure_hash): Fix pointer signedness issue.
5016 * intervals.c (static_offset_intervals): New function.
5017 (offset_intervals): Use it.
5019 2011-06-21 Leo Liu <sdl.web@gmail.com>
5022 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5025 * fns.c (secure_hash): Rename from crypto_hash_function and change
5026 the first arg to accept symbols.
5027 (Fsecure_hash): New primitive.
5028 (syms_of_fns): New symbols.
5030 2011-06-20 Deniz Dogan <deniz@dogan.se>
5032 * process.c (Fset_process_buffer): Clarify return value in
5035 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5037 * dispnew.c (add_window_display_history): Use BVAR.
5039 * xdisp.c (debug_method_add): Use BVAR.
5040 (check_window_end, dump_glyph_matrix, dump_glyph)
5041 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5043 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5046 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5047 check till after the cache is created in init_frame_faces.
5049 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5051 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5053 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5055 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5056 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5057 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5059 Improve buffer-overflow checking (Bug#8873).
5060 * fileio.c (Finsert_file_contents):
5061 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5062 Remove the old (too-loose) buffer overflow checks.
5063 They weren't needed, since make_gap checks for buffer overflow.
5064 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5065 The old code merely checked for Emacs fixnum overflow, and relied
5066 on undefined (wraparound) behavior. The new code avoids undefined
5067 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5069 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5070 Tune. Don't use wider integers than needed. Don't use alloca.
5071 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5073 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5075 * insdel.c, lisp.h (buffer_overflow): New function.
5076 (insert_from_buffer_1, replace_range, replace_range_2):
5077 * insdel.c (make_gap_larger):
5078 * editfns.c (Finsert_char):
5079 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5081 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5083 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5085 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5087 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5088 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5090 * fileio.c: Don't assume EMACS_INT fits in off_t.
5091 (emacs_lseek): New static function.
5092 (Finsert_file_contents, Fwrite_region): Use it.
5093 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5095 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5097 * fns.c: Don't overflow int when computing a list length.
5098 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5099 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5100 truncation on 64-bit hosts. Check for QUIT every
5101 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5102 faster and is responsive enough.
5103 (Flength): Report an error instead of overflowing an integer.
5104 (Fsafe_length): Return a float if the value is not representable
5105 as a fixnum. This shouldn't happen except in contrived situations.
5106 (Fnthcdr, Fsort): Don't assume list length fits in int.
5107 (Fcopy_sequence): Don't assume vector length fits in int.
5109 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5110 (header_size, word_size): New constants.
5111 (allocate_vectorlike): Don't check size overflow here.
5112 (allocate_vector): Check it here instead, since this is the only
5113 caller of allocate_vectorlike that could cause overflow.
5114 Check that the new vector's length is representable as a fixnum.
5116 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5117 The previous code was bogus. For example, next_almost_prime (32)
5118 returned 39, which is undesirable as it is a multiple of 3; and
5119 next_almost_prime (24) returned 25, which is a multiple of 5 so
5120 why was the code bothering to check for multiples of 7?
5122 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5124 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5126 Variadic C functions now count arguments with ptrdiff_t.
5127 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5128 Back then I didn't know that the Emacs coding style prefers signed int.
5129 Also, in the meantime I found a few more instances where arguments
5130 were being counted with int, which may truncate counts on 64-bit
5131 machines, or EMACS_INT, which may be unnecessarily wide.
5132 * lisp.h (struct Lisp_Subr.function.aMANY)
5133 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5134 Arg counts are now ptrdiff_t, not size_t.
5135 All variadic functions and their callers changed accordingly.
5136 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5137 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5138 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5139 * callint.c (Fcall_interactively): Check arg count for overflow,
5140 to avoid potential buffer overrun. Use signed char, not 'int',
5141 for 'varies' array, so that we needn't bother to check its size
5142 calculation for overflow.
5143 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5144 * eval.c (apply_lambda):
5145 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5146 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5147 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5149 * callint.c (Fcall_interactively): Don't use index var as event count.
5151 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5152 * mem-limits.h (SIZE): Remove; no longer used.
5154 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5156 Remove unnecessary casts.
5157 * xterm.c (x_term_init):
5158 * xfns.c (x_set_border_pixel):
5159 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5160 These aren't needed now that we assume ANSI C.
5162 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5163 It's more likely to cause problems (due to unsigned overflow)
5166 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5168 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5170 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5172 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5174 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5176 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5178 GLYPH_CODE_FACE returns EMACS_INT, not int.
5179 * dispextern.h (merge_faces):
5180 * xfaces.c (merge_faces):
5181 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5182 Don't assume EMACS_INT fits in int.
5184 * character.h (CHAR_VALID_P): Remove unused parameter.
5185 * fontset.c, lisp.h, xdisp.c: All uses changed.
5187 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5189 * fns.c (concat): Minor tuning based on overflow analysis.
5190 This doesn't fix any bugs. Use int to hold character, instead
5191 of constantly refetching from Emacs object. Use XFASTINT, not
5192 XINT, for value known to be a character. Don't bother comparing
5193 a single byte to 0400, as it's always less.
5195 * floatfns.c (Fexpt):
5196 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5198 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5201 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5203 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5204 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5205 incorrectly succeed when S was a string, because 4294967386 was
5206 truncated before it was used.
5208 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5209 Otherwise, an out-of-range integer could cause undefined behavior
5212 * composite.c: Use int, not EMACS_INT, for characters.
5213 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5214 EMACS_INT, for values that are known to be in character range.
5215 This doesn't fix any bugs but is the usual style inside Emacs and
5216 may generate better code on 32-bit machines.
5218 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5219 This is for reasons similar to the recent CHAR_STRING fix.
5220 * charset.c (Fencode_char): Check that character arg is actually
5221 a character. Pass an int to ENCODE_CHAR.
5222 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5223 wider than 'int', as a compile-time check to prevent future regressions
5226 * character.c (char_string): Remove unnecessary casts.
5228 Make sure a 64-bit char is never passed to CHAR_STRING.
5229 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5230 by silently ignoring the top 32 bits, allowing some values
5231 that were far too large to be valid characters.
5232 * character.h: Include <verify.h>.
5233 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5234 arguments are no wider than unsigned, as a compile-time check
5235 to prevent future regressions in this area.
5237 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5238 (Fsubst_char_in_region):
5240 * xdisp.c (decode_mode_spec_coding):
5241 Adjust to CHAR_STRING's new requirement.
5242 * editfns.c (Finsert_char, Fsubst_char_in_region):
5243 * fns.c (concat): Check that character args are actually
5244 characters. Without this test, these functions did the wrong
5245 thing with wildly out-of-range values on 64-bit hosts.
5247 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5248 These casts should not be needed on 32-bit hosts, either.
5249 * keyboard.c (read_char):
5250 * lread.c (Fload): Remove casts to unsigned.
5252 * lisp.h (UNSIGNED_CMP): New macro.
5253 This fixes comparison bugs on 64-bit hosts.
5254 (ASCII_CHAR_P): Use it.
5255 * casefiddle.c (casify_object):
5256 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5257 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5258 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5259 * dispextern.h (FACE_FROM_ID):
5260 * keyboard.c (read_char): Use UNSIGNED_CMP.
5262 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5263 not to EMACS_INT, to avoid GCC warning.
5265 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5267 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5268 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5269 isn't needed on 32-bit machines.
5271 * buffer.c (Fgenerate_new_buffer_name):
5272 Use EMACS_INT for count, not int.
5273 (advance_to_char_boundary): Return EMACS_INT, not int.
5275 * data.c (Qcompiled_function): Now static.
5277 * window.c (window_body_lines): Now static.
5279 * image.c (gif_load): Rename local to avoid shadowing.
5281 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5282 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5283 * alloc.c (make_save_value): Integer argument is now of type
5285 (mark_object): Use ptrdiff_t, not int.
5286 * lisp.h (pD): New macro.
5287 * print.c (print_object): Use it.
5289 * alloc.c: Use EMACS_INT, not int, to count objects.
5290 (total_conses, total_markers, total_symbols, total_vector_size)
5291 (total_free_conses, total_free_markers, total_free_symbols)
5292 (total_free_floats, total_floats, total_free_intervals)
5293 (total_intervals, total_strings, total_free_strings):
5294 Now EMACS_INT, not int. All uses changed.
5295 (Fgarbage_collect): Compute overall total using a double, so that
5296 integer overflow is less likely to be a problem. Check for overflow
5297 when converting back to an integer.
5298 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5299 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5300 These were 'int' variables that could overflow on 64-bit hosts;
5301 they were never used, so remove them instead of repairing them.
5302 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5303 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5304 Previously, this ceilinged at INT_MAX, but that doesn't work on
5306 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5308 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5309 (allocate_vectorlike): Check for ptrdiff_t overflow.
5310 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5311 when a (possibly-narrower) signed value would do just as well.
5312 We prefer using signed arithmetic, to avoid comparison confusion.
5314 * alloc.c: Catch some string size overflows that we were missing.
5315 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5316 for convenience in STRING_BYTES_MAX.
5317 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5318 The definition here is exact; the one in lisp.h was approximate.
5319 (allocate_string_data): Check for string overflow. This catches
5320 some instances we weren't catching before. Also, it catches
5321 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5322 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5323 and ptrdiff_t and EMACS_INT are both 64 bits.
5325 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5326 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5327 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5329 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5331 * alloc.c (Fmake_string): Check for out-of-range init.
5333 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5335 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5337 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5339 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5340 xg_get_default_scrollbar_width.
5342 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5343 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5344 (style_changed_cb): Call update_theme_scrollbar_width and call
5345 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5346 all frames (Bug#8505).
5347 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5348 Call gtk_window_set_resizable if HAVE_GTK3.
5349 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5350 and height if HAVE_GTK3 (Bug#8505).
5351 (scroll_bar_width_for_theme): New variable.
5352 (update_theme_scrollbar_width): New function.
5353 (xg_get_default_scrollbar_width): Move code to
5354 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5355 (xg_initialize): Call update_theme_scrollbar_width.
5357 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5359 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5361 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5363 * frame.c (make_frame): Call other_buffer_safely instead of
5366 * window.c (temp_output_buffer_show): Call display_buffer with
5367 second argument Vtemp_buffer_show_specifiers and reset latter
5368 immediately after the call.
5369 (Vtemp_buffer_show_specifiers): New variable.
5370 (auto_window_vscroll_p, next_screen_context_lines)
5371 (Vscroll_preserve_screen_position): Remove leading asterisks from
5374 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5376 Fix minor problems found by GCC 4.6.0 static checking.
5377 * buffer.c (Qclone_number): Remove for now, as it's unused.
5378 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5379 (record_buffer): Remove unused local.
5380 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5381 (set_frame_buffer_list): Remove; unused.
5382 * frame.h (other_visible_frames): Remove decl.
5383 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5384 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5385 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5387 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5388 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5389 Define only if HAVE_GPM.
5390 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5391 (update_hints_inhibit): Remove; never set. All uses removed.
5392 * widgetprv.h (emacsFrameClassRec): Remove decl.
5393 * window.c (delete_deletable_window): Now returns void, since it
5394 wasn't returning anything.
5395 (compare_window_configurations): Remove unused locals.
5396 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5397 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5398 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5399 the same widths as pointers. This follows up on the 2011-05-06 patch.
5400 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5401 * xterm.h: Likewise.
5402 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5404 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5406 * makefile.w32-in: Update dependencies.
5407 (LISP_H): Add lib/intprops.h.
5409 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5411 * image.c (gif_load): Add animation frame delay to the metadata.
5412 (syms_of_image): Use DEFSYM. New symbol `delay'.
5414 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5416 * window.c (delete_deletable_window): Re-add.
5417 (Fset_window_configuration): Rewrite to handle dead buffers and
5418 consequently deletable windows.
5419 (window_tree, Fwindow_tree): Remove. Supply functionality in
5421 (compare_window_configurations): Simplify code.
5423 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5425 * image.c (imagemagick_load_image): Fix type mismatch.
5426 (Fimagemagick_types): Likewise.
5428 * window.h (replace_buffer_in_windows): Declare.
5430 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5432 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5433 Qclone_number. Remove external declaration of Qdelete_window.
5434 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5436 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5437 Run Qbuffer_list_update_hook if allowed.
5438 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5439 buffer list implementation.
5440 (other_buffer_safely): New function.
5441 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5442 calls to replace_buffer_in_windows and
5443 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5445 (record_buffer): Inhibit quitting and rewrite using quittable
5446 functions. Run Qbuffer_list_update_hook if allowed.
5447 (Frecord_buffer, Funrecord_buffer): New functions.
5448 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5449 Move switch-to-buffer to window.el.
5450 (bury-buffer): Move to window.el.
5451 (Vbuffer_list_update_hook): New variable.
5453 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5456 * window.h (resize_frame_windows): Move up in code.
5457 (Fwindow_frame): Remove EXFUN.
5458 (replace_buffer_in_all_windows): Remove prototype.
5459 (replace_buffer_in_windows_safely): Add prototype.
5461 * window.c: Declare Qdelete_window static again. Move down
5462 declaration of select_count.
5463 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5464 (Fother_window): Move to window.el.
5465 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5466 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5467 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5469 (replace_buffer_in_windows): Implement by calling
5470 Qreplace_buffer_in_windows.
5471 (replace_buffer_in_all_windows): Remove with some functionality
5472 moved into replace_buffer_in_windows_safely.
5473 (replace_buffer_in_windows_safely): New function.
5474 (select_window_norecord, select_frame_norecord): Move in front
5475 of run_window_configuration_change_hook. Remove now obsolete
5477 (Fset_window_buffer): Rewrite doc-string.
5478 Call Qrecord_window_buffer.
5479 (keys_of_window): Move binding for other-window to window.el.
5481 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5483 * dispextern.h (struct image): Replace data member, whose int_val
5484 and ptr_val fields were not used by anything, with a single
5487 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5488 (gif_clear_image, gif_load, imagemagick_load_image)
5489 (gs_clear_image, gs_load): Callers changed.
5491 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5493 * buffer.h: Include <time.h>, for time_t.
5494 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5496 Fix minor problems found by static checking.
5498 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5500 Make identifiers static if they are not used in other modules.
5501 * data.c (Qcompiled_function, Qframe, Qvector):
5502 * image.c (QimageMagick, Qsvg):
5503 * minibuf.c (Qmetadata):
5504 * window.c (resize_window_check, resize_root_window): Now static.
5505 * window.h (resize_window_check, resize_root_window): Remove decls.
5507 * window.c (window_deletion_count, delete_deletable_window):
5509 (window_body_lines): Now static.
5510 (Fdelete_other_windows_internal): Mark vars as initialized.
5511 Make sure 'resize_failed' is initialized.
5512 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5513 (resize_window_apply): Remove unused local.
5514 * window.h (delete_deletable_window): Remove decl.
5516 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5517 (imagemagick_load_image): Fix pointer signedness problem by changing
5518 last arg from unsigned char * to char *. All uses changed.
5519 Also, fix a local for similar reasons.
5520 Remove unused locals. Remove locals to avoid shadowing.
5521 (fn_rsvg_handle_free): Remove; unused.
5522 (svg_load, svg_load_image): Fix pointer signedness problem.
5523 (imagemagick_load_image): Don't use garbage pointer image_wand.
5525 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5527 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5529 * image.c (gif_load): Fix omitted cast error introduced by
5532 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5534 * window.h (resize_proportionally, orig_total_lines)
5535 (orig_top_line): Remove from window structure.
5536 (set_window_height, set_window_width, change_window_heights)
5537 (Fdelete_window): Remove prototypes.
5538 (resize_frame_windows): Remove duplicate declaration.
5540 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5542 * window.h (resize_frame_windows, resize_window_check)
5543 (delete_deletable_window, resize_root_window)
5544 (resize_frame_windows): Declare prototypes.
5546 * window.c (resize_window_apply): Make definition be "static" to
5547 match the prototype.
5549 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5551 * window.c: Remove declarations of Qwindow_size_fixed,
5552 window_min_size_1, window_min_size_2, window_min_size,
5553 size_window, window_fixed_size_p, enlarge_window, delete_window.
5554 Remove static from declaration of Qdelete_window, it's
5555 temporarily needed by Fbury_buffer.
5556 (replace_window): Don't assign orig_top_line and
5558 (Fdelete_window, delete_window): Remove. Window deletion is
5559 handled by window.el.
5560 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5561 Replace Fdelete_window calls with calls to Qdelete_window.
5562 (Fdelete_other_windows): Remove. Deleting other windows is
5563 handled by window.el.
5564 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5565 handled in window.el.
5566 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5567 Window minimum sizes are handled in window.el.
5568 (shrink_windows, size_window, set_window_height)
5569 (set_window_width, change_window_heights, window_height)
5570 (window_width, CURBEG, CURSIZE, enlarge_window)
5571 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5572 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5573 handled in window.el.
5574 (make_dummy_parent): Rename to make_parent_window and give it a
5575 second argument horflag.
5576 (make_window): Don't set resize_proportionally any more.
5577 (Fsplit_window): Remove. Windows are split in window.el.
5578 (save_restore_action, save_restore_orig_size)
5579 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5580 Resize mini windows in window.el.
5581 (grow_mini_window, shrink_mini_window): Implement by calling
5582 Qresize_root_window_vertically, resize_window_check and
5583 resize_window_apply.
5584 (saved_window, Fset_window_configuration, save_window_save):
5585 Do not handle orig_top_line, orig_total_lines, and
5586 resize_proportionally.
5587 (window_min_height, window_min_width): Move to window.el.
5588 (keys_of_window): Move bindings for delete-other-windows,
5589 split-window, delete-window and enlarge-window to window.el.
5591 * buffer.c: Temporarily extern Qdelete_window.
5592 (Fbury_buffer): Temporarily call Qdelete_window instead of
5593 Fdelete_window (Fbury_buffer will move to window.el soon).
5595 * frame.c (set_menu_bar_lines_1): Remove code handling
5596 orig_top_line and orig_total_lines.
5598 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5599 set_window_height but set heights directly.
5600 (change_frame_size_1): Use resize_frame_windows.
5602 * xdisp.c (init_xdisp): Don't use set_window_height but set
5605 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5606 Use resize_frame_windows instead of change_window_heights and run
5607 run_window_configuration_change_hook.
5609 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5610 instead of change_window_heights and run
5611 run_window_configuration_change_hook.
5613 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5615 * window.c (replace_window): Rename second argument REPLACEMENT to
5616 NEW. New third argument SETFLAG. Rewrite.
5617 (delete_window, make_dummy_parent): Call replace_window with
5619 (window_list_1): Move down in code.
5620 (run_window_configuration_change_hook): Move set_buffer part
5621 before select_frame_norecord part in order to unwind correctly.
5622 Rename count1 to count.
5623 (recombine_windows, delete_deletable_window, resize_root_window)
5624 (Fdelete_other_windows_internal)
5625 (Frun_window_configuration_change_hook, make_parent_window)
5626 (resize_window_check, resize_window_apply, Fresize_window_apply)
5627 (resize_frame_windows, Fsplit_window_internal)
5628 (Fdelete_window_internal, Fresize_mini_window_internal):
5630 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5632 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5634 * window.h (window): Add some new members to window structure -
5635 normal_lines, normal_cols, new_total, new_normal, clone_number,
5636 splits, nest, prev_buffers, next_buffers.
5637 (WINDOW_TOTAL_SIZE): Move here from window.c.
5638 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5640 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5642 (make_dummy_parent): Set new members of windows structure.
5643 (make_window): Move down in code. Handle new members of window
5645 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5646 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5647 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5648 (Fset_window_prev_buffers, Fwindow_next_buffers)
5649 (Fset_window_next_buffers, Fset_window_clone_number):
5651 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5652 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5654 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5655 Argument WINDOW can be now internal window too.
5656 (Fwindow_use_time): Move up in code.
5657 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5659 (Fset_window_configuration, saved_window)
5660 (Fcurrent_window_configuration, save_window_save): Handle new
5661 members of window structure.
5662 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5663 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5664 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5665 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5666 Qget_mru_window, Qresize_root_window,
5667 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5668 Qauto_buffer_name; staticpro them.
5670 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5672 * window.c (Fwindow_total_size, Fwindow_left_column)
5673 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5674 (Fwindow_list_1): New functions.
5675 (window_box_text_cols): Replace with window_body_cols.
5676 (Fwindow_width, Fscroll_left, Fscroll_right):
5677 Use window_body_cols instead of window_box_text_cols.
5678 (delete_window, Fset_window_configuration):
5679 Call delete_all_subwindows with window as argument.
5680 (delete_all_subwindows): Take a window as argument and not a
5682 (window_loop): Remove handling of GET_LRU_WINDOW and
5684 (Fget_lru_window, Fget_largest_window): Move to window.el.
5686 * window.h: Extern window_body_cols instead of
5687 window_box_text_cols. delete_all_subwindows now takes a
5688 Lisp_Object as argument.
5690 * indent.c (compute_motion, Fcompute_motion):
5691 Use window_body_cols instead of window_box_text_cols.
5693 * frame.c (delete_frame): Call delete_all_subwindows with root
5696 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5698 * fns.c (Fputhash): Document return value.
5700 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5702 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5704 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5706 Cons<->int and similar integer overflow fixes (Bug#8794).
5708 Check for overflow when converting integer to cons and back.
5709 * charset.c (Fdefine_charset_internal, Fdecode_char):
5710 Use cons_to_unsigned to catch overflow.
5711 (Fencode_char): Use INTEGER_TO_CONS.
5712 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5713 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5714 * data.c (long_to_cons, cons_to_long): Remove.
5715 (cons_to_unsigned, cons_to_signed): New functions.
5716 These signal an error for invalid or out-of-range values.
5717 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5718 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5719 * font.c (Ffont_variation_glyphs):
5720 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5721 * lisp.h: Include <intprops.h>.
5722 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5723 (cons_to_signed, cons_to_unsigned): New decls.
5724 (long_to_cons, cons_to_long): Remove decls.
5725 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5726 (Fprimitive_undo): Use CONS_TO_INTEGER.
5727 * xfns.c (Fx_window_property): Likewise.
5728 * xselect.c: Include <limits.h>.
5729 (x_own_selection, selection_data_to_lisp_data):
5730 Use INTEGER_TO_CONS.
5731 (x_handle_selection_request, x_handle_selection_clear)
5732 (x_get_foreign_selection, Fx_disown_selection_internal)
5733 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5734 (lisp_data_to_selection_data): Use cons_to_unsigned.
5735 (x_fill_property_data): Use cons_to_signed.
5736 Report values out of range.
5738 Check for buffer and string overflow more precisely.
5739 * buffer.h (BUF_BYTES_MAX): New macro.
5740 * lisp.h (STRING_BYTES_MAX): New macro.
5741 * alloc.c (Fmake_string):
5742 * character.c (string_escape_byte8):
5743 * coding.c (coding_alloc_by_realloc):
5744 * doprnt.c (doprnt):
5745 * editfns.c (Fformat):
5747 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5748 since they may not be the same number.
5749 * editfns.c (Finsert_char):
5750 * fileio.c (Finsert_file_contents):
5751 Likewise for BUF_BYTES_MAX.
5753 * image.c: Use ptrdiff_t, not int, for sizes.
5754 (slurp_file): Switch from int to ptrdiff_t.
5756 (slurp_file): Check that file size fits in both size_t (for
5757 malloc) and ptrdiff_t (for sanity and safety).
5759 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5760 if b->modtime has its maximal value.
5762 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5764 Don't assume time_t can fit into int.
5765 * buffer.h (struct buffer.modtime): Now time_t, not int.
5766 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5767 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5769 Minor fixes for signed vs unsigned integers.
5770 * character.h (MAYBE_UNIFY_CHAR):
5771 * charset.c (maybe_unify_char):
5772 * keyboard.c (read_char, reorder_modifiers):
5773 XINT -> XFASTINT, since the integer must be nonnegative.
5774 * ftfont.c (ftfont_spec_pattern):
5775 * keymap.c (access_keymap, silly_event_symbol_error):
5776 XUINT -> XFASTINT, since the integer must be nonnegative.
5777 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5778 since it makes no difference and we prefer signed.
5779 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5780 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5783 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5785 * window.h (Fwindow_frame): Declare.
5787 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5789 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5790 (SPARE_MEMORY): Always define.
5791 (LARGE_REQUEST): Remove.
5792 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5794 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5796 * lisp.h: Move EXFUNS for Fframe_root_window,
5797 Fframe_first_window and Fset_frame_selected_window to window.h.
5799 * window.h: Move EXFUNS for Fframe_root_window,
5800 Fframe_first_window and Fset_frame_selected_window here from
5803 * frame.c (Fwindow_frame, Fframe_first_window)
5804 (Fframe_root_window, Fframe_selected_window)
5805 (Fset_frame_selected_window): Move to window.c.
5806 (Factive_minibuffer_window): Move to minibuf.c.
5807 (Fother_visible_frames_p): New function.
5809 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5811 * window.c (decode_window, decode_any_window): Move up in code.
5812 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5813 (inhibit_frame_unsplittable): Remove unused variable.
5814 (Fwindow_buffer): Move up and rewrite doc-string.
5815 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5816 (Fwindow_prev): New functions.
5817 (Fwindow_frame): Move here from frame.c. Accept any window as
5819 (Fframe_root_window, Fframe_first_window)
5820 (Fframe_selected_window): Move here from frame.c. Accept frame
5821 or arbitrary window as argument. Update doc-strings.
5822 (Fminibuffer_window): Move up in code.
5823 (Fwindow_minibuffer_p): Move up in code and simplify.
5824 (Fset_frame_selected_window): Move here from frame.c.
5826 (Fselected_window, select_window, Fselect_window): Move up in
5827 code. Minor doc-string fixes.
5829 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5831 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5832 Do not assume that spare memory exists; that assumption is valid
5833 only if SYSTEM_MALLOC.
5834 (LARGE_REQUEST): New macro, so that the issue of large requests
5835 is separated from the issue of spare memory.
5837 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5839 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5842 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5844 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5847 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5849 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5851 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5853 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5854 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5856 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5858 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5860 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5862 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5863 (x_clipboard_manager_save): Add return value.
5864 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5866 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5867 Obey Vx_select_enable_clipboard_manager. Catch errors in
5868 x_clipboard_manager_save (Bug#8779).
5869 (Vx_select_enable_clipboard_manager): New variable.
5870 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5872 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5874 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5876 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5878 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5879 in the current matrix if keep_current_p is non-zero.
5881 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5883 * bidi.c (bidi_level_of_next_char): Fix last change.
5885 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5887 Support bidi reordering of text covered by display properties.
5889 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5890 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5891 (bidi_cache_search, bidi_cache_iterator_state)
5892 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5893 (bidi_level_of_next_char, bidi_move_to_visually_next):
5894 Support character positions inside a run of characters covered by a
5896 (bidi_paragraph_init, bidi_resolve_explicit_1)
5897 (bidi_level_of_next_char): Call bidi_fetch_char and
5898 bidi_fetch_char_advance instead of FETCH_CHAR and
5900 (bidi_init_it): Initialize new members.
5901 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5903 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5904 instead of using explicit *_CHAR codes.
5905 (bidi_resolve_explicit, bidi_resolve_weak):
5906 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5907 bidirectional text is supported only in multibyte buffers.
5908 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5909 it to initialize the frame_window_p member of struct bidi_it.
5910 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5911 (bidi_resolve_explicit, bidi_resolve_weak)
5912 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5913 bidi_it->nchars is non-positive.
5914 (bidi_level_of_next_char): Don't try to lookup the cache for the
5915 next/previous character if nothing is cached there yet, or if we
5916 were just reseat()'ed to a new position.
5918 * xdisp.c (set_cursor_from_row): Set start and stop points
5919 according to the row's direction when priming the loop that looks
5920 for the glyph on which to display cursor.
5921 (single_display_spec_intangible_p): Function deleted.
5922 (display_prop_intangible_p): Reimplement to call
5923 handle_display_spec instead of single_display_spec_intangible_p.
5924 Accept 3 additional arguments needed by handle_display_spec.
5925 This fixes incorrect cursor motion across display property with complex
5926 values: lists, `(when COND...)' forms, etc.
5927 (single_display_spec_string_p): Support property values that are
5928 lists with the argument STRING its top-level element.
5929 (display_prop_string_p): Fix the condition for processing a
5930 property that is a list to be consistent with handle_display_spec.
5931 (handle_display_spec): New function, refactored from the
5932 last portion of handle_display_prop.
5933 (compute_display_string_pos): Accept additional argument
5934 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5935 value of a `display' property is a "replacing spec".
5936 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5937 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5938 the display property, but just return a value indicating whether
5939 the display property will replace the characters it covers.
5940 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5941 frame_window_p members of struct bidi_it.
5942 (compute_display_string_pos, compute_display_string_end):
5944 (push_it): Accept second argument POSITION, where pop_it should
5945 jump to continue iteration.
5946 (reseat_1): Initialize bidi_it.disp_pos.
5948 * keyboard.c (adjust_point_for_property): Adjust the call to
5949 display_prop_intangible_p to its new signature.
5951 * dispextern.h (struct bidi_it): New member frame_window_p.
5952 (bidi_init_it): Update prototypes.
5953 (display_prop_intangible_p): Update prototype.
5954 (compute_display_string_pos, compute_display_string_end):
5956 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5959 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5961 Malloc failure behavior now depends on size of allocation.
5962 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5963 * lisp.h: Change signatures accordingly.
5964 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5965 All callers changed. (Bug#8762)
5967 * gnutls.c: Use Emacs's memory allocators.
5968 Without this change, the gnutls library would invoke malloc etc.
5969 directly, which causes problems on non-SYNC_INPUT hosts, and which
5970 runs afoul of improving memory_full behavior. (Bug#8761)
5971 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5972 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5973 xfree instead of the default malloc, realloc, free.
5974 (Fgnutls_boot): No need to check for memory allocation failure,
5975 since xmalloc does that for us.
5977 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5978 * category.c (hash_get_category_set):
5979 * ccl.c (ccl_driver):
5980 * charset.c (Fdefine_charset_internal):
5981 * charset.h (struct charset.hash_index):
5982 * composite.c (get_composition_id, gstring_lookup_cache)
5983 (composition_gstring_put_cache):
5984 * composite.h (struct composition.hash_index):
5985 * dispextern.h (struct image.hash):
5986 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5987 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5988 (hashfn_equal, hashfn_user_defined, make_hash_table)
5989 (maybe_resize_hash_table, hash_lookup, hash_put)
5990 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5991 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5992 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5993 * image.c (make_image, search_image_cache, lookup_image)
5994 (xpm_put_color_table_h):
5995 * lisp.h (struct Lisp_Hash_Table):
5996 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5997 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5998 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5999 * alloc.c (allocate_vectorlike):
6000 Check for overflow in vector size calculations.
6001 * ccl.c (ccl_driver):
6002 Check for overflow when converting EMACS_INT to int.
6003 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6004 need to be updated by these changes.
6005 * fns.c (make_hash_table, maybe_resize_hash_table):
6006 Check for integer overflow with large hash tables.
6007 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6008 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6009 (SXHASH_REDUCE): New macro.
6010 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6011 Use it instead of discarding useful hash info with large hash values.
6012 (sxhash_float): New function.
6013 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6014 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6015 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6016 Rewrite to use FIXNUM_BITS, as this simplifies things.
6017 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6018 Adjust signatures to match updated version of code.
6019 (consing_since_gc): Now EMACS_INT, since a single hash table can
6020 use more than INT_MAX bytes.
6022 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6024 Make it possible to build with GCC-4.6+ -O2 -flto.
6026 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6028 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6030 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6031 Call minibuffer-inactive-mode.
6033 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6035 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6036 Update dependencies.
6038 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6040 * data.c (init_data): Remove code for UTS, this system is not
6043 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6045 Don't force ./temacs to start in terminal mode.
6047 * frame.c (make_initial_frame): Initialize faces in all cases, not
6048 only when CANNOT_DUMP is defined.
6049 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6051 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6053 * dispnew.c (add_window_display_history): Use const for the string
6054 pointer. Remove declaration, not needed.
6056 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6058 Use 'inline', not 'INLINE'.
6059 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6060 * alloc.c, fontset.c (INLINE): Remove.
6061 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6062 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6063 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6064 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6065 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6067 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6069 Make it possible to run ./temacs.
6071 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6072 syms_of_callproc does the same thing. Remove test for
6073 "initialized", do it in the caller.
6074 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6076 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6078 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6079 (read_minibuf): Use get_minibuffer.
6080 (syms_of_minibuf): Use DEFSYM.
6081 (Qmetadata): New var.
6082 * data.c (Qbuffer): Don't make it static.
6083 (syms_of_data): Use DEFSYM.
6085 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6087 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6088 (CCL_CODE_MIN): New macro.
6090 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6092 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6094 * eval.c (Qdebug): Now static.
6095 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6096 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6097 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6099 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6101 * image.c: Various fixes to ImageMagick code comments.
6102 (Fimagemagick_types): Doc fix.
6104 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6106 Minor fixes prompted by GCC 4.6.0 warnings.
6108 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6110 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6111 (x_clipboard_manager_save_all): Move extern decl to ...
6112 * xterm.h: ... here, so that it can be checked for consistency.
6114 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6116 * xselect.c (x_clipboard_manager_save_frame)
6117 (x_clipboard_manager_save_all): New functions.
6118 (Fx_clipboard_manager_save): Lisp function deleted.
6120 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6121 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6123 * xterm.h: Update prototype.
6125 2011-05-28 William Xu <william.xwl@gmail.com>
6127 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6130 2011-05-28 Jim Meyering <meyering@redhat.com>
6132 Avoid a sign-extension bug in crypto_hash_function.
6133 * fns.c (to_uchar): Define.
6134 (crypto_hash_function): Use it to convert some newly-signed
6135 variables to unsigned, to avoid sign-extension bugs. For example,
6136 without this change, (md5 "truc") would evaluate to
6137 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6138 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6139 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6141 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6143 Integer overflow fixes.
6145 * dbusbind.c: Serial number integer overflow fixes.
6146 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6147 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6148 to hold a serial number that is too large for a fixnum.
6149 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6150 Check for serial numbers out of range. Decode any serial number
6151 that was so large that it became a float. (Bug#8722)
6153 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6154 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6155 Use XFASTINT rather than XUINT when numbers are nonnegative.
6156 (xd_append_arg, Fdbus_method_return_internal):
6157 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6158 arguments, check that Lisp number is nonnegative, rather than
6159 silently wrapping negative numbers around. (Bug#8722)
6160 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6163 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6165 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6167 ccl: Add integer overflow checks.
6168 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6169 (IN_INT_RANGE): New macros.
6170 (ccl_driver): Use them to check for integer overflow when
6171 decoding a CCL program. Many of the new checks are whether XINT (x)
6172 fits in int; it doesn't always, on 64-bit hosts. The new version
6173 doesn't catch all possible integer overflows, but it's an
6174 improvement. (Bug#8719)
6176 * alloc.c (make_event_array): Use XINT, not XUINT.
6177 There's no need for unsigned here.
6179 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6180 This follows up to the 2011-05-06 change that substituted uintptr_t
6181 for EMACS_INT. This case wasn't caught back then.
6183 Rework Fformat to avoid integer overflow issues.
6184 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6185 now (part of C89). Include <verify.h>.
6186 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6187 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6188 (Fformat): Avoid the prepass trying to compute sizes; it was only
6189 approximate and thus did not catch overflow reliably. Instead, walk
6190 through the format just once, formatting and computing sizes as we go,
6191 checking for integer overflow at every step, and allocating a larger
6192 buffer as needed. Keep track separately whether the format is
6193 multibyte. Keep only the most-recently calculated precision, rather
6194 than them all. Record whether each argument has been converted to
6195 string. Use EMACS_INT, not int, for byte and char and arg counts.
6196 Support field widths and precisions larger than INT_MAX. Avoid
6197 sprintf's undefined behavior with conversion specifications such as %#d
6198 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6199 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6200 formatting out-of-range floating point numbers with int
6203 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6205 * data.c: Avoid integer truncation in expressions involving floats.
6206 * data.c: Include <intprops.h>.
6207 (arith_driver): When there's an integer overflow in an expression
6208 involving floating point, convert the integers to floating point
6209 so that the resulting value does not suffer from catastrophic
6210 integer truncation. For example, on a 64-bit host (* 4
6211 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6212 Do not rely on undefined behavior after integer overflow.
6214 merge count_size_as_multibyte, parse_str_to_multibyte
6215 * character.c, character.h (count_size_as_multibyte):
6216 Rename from parse_str_to_multibyte; all uses changed.
6217 Check for integer overflow.
6218 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6219 since it's now a duplicate of the other. This is more of
6220 a character than a buffer op, so better that it's in character.c.
6221 * fns.c, print.c: Adjust to above changes.
6223 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6225 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6227 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6229 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6230 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6231 (x_clipboard_manager_save): Now static.
6232 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6234 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6235 (crypto_hash_function): Now static.
6236 Fix pointer signedness problems. Avoid unnecessary initializations.
6238 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6240 * termhooks.h (Vselection_alist): Make it terminal-local.
6242 * terminal.c (create_terminal): Initialize it.
6244 * xselect.c: Support for clipboard managers.
6245 (Vselection_alist): Move to termhooks.h as terminal-local var.
6246 (LOCAL_SELECTION): New macro.
6247 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6248 (symbol_to_x_atom): Remove gratuitous arg.
6249 (x_handle_selection_request, lisp_data_to_selection_data)
6250 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6251 (x_own_selection, x_get_local_selection, x_convert_selection):
6252 New arg, specifying work frame. Use terminal-local Vselection_alist.
6253 (some_frame_on_display): Delete unused function.
6254 (Fx_own_selection_internal, Fx_get_selection_internal)
6255 (Fx_disown_selection_internal, Fx_selection_owner_p)
6256 (Fx_selection_exists_p): New optional frame arg.
6257 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6258 (x_handle_selection_clear): Don't treat other terminals with the
6259 same keyboard specially. Use the terminal-local Vselection_alist.
6260 (x_clear_frame_selections): Use Frun_hook_with_args.
6262 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6264 * xterm.h: Add support for those atoms.
6266 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6268 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6269 (converted_selections, conversion_fail_tag): New global variables.
6270 (x_selection_request_lisp_error): Free the above.
6271 (x_get_local_selection): Remove unnecessary code.
6272 (x_reply_selection_request): Args changed; handle arbitrary array
6273 of converted selections stored in converted_selections.
6274 Separate the XChangeProperty and SelectionNotify steps.
6275 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6276 (x_convert_selection): New function.
6277 (x_handle_selection_event): Simplify.
6278 (x_get_foreign_selection): Don't ignore incoming requests while
6279 waiting for an answer; this will fail when we implement
6280 SAVE_TARGETS, and seems unnecessary anyway.
6281 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6282 (Vx_sent_selection_functions): Doc fix.
6284 2011-05-26 Leo Liu <sdl.web@gmail.com>
6286 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6288 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6290 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6292 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6293 for fringe update if it has periodic bitmap.
6294 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6295 and fringe_bitmap_periodic_p.
6297 * fringe.c (get_fringe_bitmap_data): New function.
6298 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6299 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6300 row. Mark glyph row for fringe update if periodicity changed.
6302 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6303 for fringe update unless it has periodic bitmap.
6305 2011-05-25 Kenichi Handa <handa@m17n.org>
6307 * xdisp.c (get_next_display_element): Set correct it->face_id for
6308 a static composition.
6310 2011-05-24 Leo Liu <sdl.web@gmail.com>
6313 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6315 * fns.c (crypto_hash_function, Fsha1): New function.
6316 (Fmd5): Use crypto_hash_function.
6317 (syms_of_fns): Add Ssha1.
6319 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6321 * gnutls.c: Remove unused macros.
6322 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6323 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6324 Remove macros that are defined and never used.
6325 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6327 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6329 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6330 (Fx_get_selection_internal): Minor cleanup.
6331 (Fx_own_selection_internal): Rename arguments for consistency with
6334 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6336 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6338 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6340 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6342 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6344 * dispnew.c (scrolling_window): Don't exclude the case that the
6345 last enabled row in the desired matrix touches the bottom boundary.
6347 2011-05-21 Glenn Morris <rgm@gnu.org>
6349 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6350 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6351 and add some more files.
6353 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6355 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6356 report_file_error introduced by the change from 2011-05-07.
6358 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6360 * systime.h (Time): Define only if emacs is defined.
6361 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6362 where the include path doesn't have X11/X.h by default. See
6363 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6365 2011-05-20 Kenichi Handa <handa@m17n.org>
6367 * composite.c (find_automatic_composition): Fix previous change.
6369 2011-05-20 Glenn Morris <rgm@gnu.org>
6371 * lisp.mk: New file, split from Makefile.in.
6372 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6373 (shortlisp): Remove.
6374 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6376 2011-05-19 Glenn Morris <rgm@gnu.org>
6378 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6379 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6380 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6381 (lisp): Set the order to that of loadup.el.
6382 (shortlisp): Make it a copy of $lisp.
6383 (SOME_MACHINE_LISP): Remove.
6384 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6385 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6387 2011-05-18 Kenichi Handa <handa@m17n.org>
6389 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6390 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6391 (find_automatic_composition): Mostly rewrite for efficiency.
6393 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6395 * makefile.w32-in: Update dependencies.
6397 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6399 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6400 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6402 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6404 Fix some integer overflow issues, such as string length overflow.
6406 * insdel.c (count_size_as_multibyte): Check for string overflow.
6408 * character.c (lisp_string_width): Check for string overflow.
6409 Use EMACS_INT, not int, for string indexes and lengths; in
6410 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6411 the resulting string length overflows an EMACS_INT; instead,
6412 report a string overflow if no precision given. When checking for
6413 precision exhaustion, use a check that cannot possibly have
6414 integer overflow. (Bug#8675)
6415 * character.h (lisp_string_width): Adjust to new signature.
6417 * alloc.c (string_overflow): New function.
6418 (Fmake_string): Use it. This doesn't change behavior, but saves
6419 a few bytes and will simplify future changes.
6420 * character.c (string_escape_byte8): Likewise.
6421 * lisp.h (string_overflow): New decl.
6423 Fixups, following up to the user-interface timestamp change.
6424 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6425 for UI timestamps, instead of unsigned long.
6426 * msdos.c (mouse_get_pos): Likewise.
6427 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6428 * w32gui.h (Time): Define by including "systime.h" rather than by
6429 declaring it ourselves. (Bug#8664)
6431 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6432 * image.c (clear_image_cache): Likewise.
6434 * term.c (term_mouse_position): Don't assume time_t wraparound.
6436 Be more systematic about user-interface timestamps.
6437 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6438 and sometimes 'EMACS_UINT', to represent these timestamps.
6439 This change causes it to use 'Time' uniformly, as that's what X uses.
6440 This makes the code easier to follow, and makes it easier to catch
6441 integer overflow bugs such as Bug#8664.
6442 * frame.c (Fmouse_position, Fmouse_pixel_position):
6443 Use Time, not unsigned long, for user-interface timestamps.
6444 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6445 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6446 * keyboard.h (last_event_timestamp): Likewise.
6447 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6448 * menu.h (xmenu_show): Likewise.
6449 * term.c (term_mouse_position): Likewise.
6450 * termhooks.h (struct input_event.timestamp): Likewise.
6451 (struct terminal.mouse_position_hook): Likewise.
6452 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6453 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6454 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6455 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6457 * menu.h, termhooks.h: Include "systime.h", for Time.
6459 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6460 Don't assume that the difference between two unsigned long values
6461 can fit into an integer. At this point, we know button_down_time
6462 <= event->timestamp, so the difference must be nonnegative, so
6463 there's no need to cast the result if double-click-time is
6464 nonnegative, as it should be; check that it's nonnegative, just in
6465 case. This bug is triggered when events are more than 2**31 ms
6466 apart (about 25 days). (Bug#8664)
6468 * xselect.c (last_event_timestamp): Remove duplicate decl.
6469 (x_own_selection): Remove needless cast to unsigned long.
6471 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6472 that always fit in int. Use a sentinel instead of a counter, to
6473 avoid a temp and to allay GCC's concerns about possible int overflow.
6474 * frame.h (struct frame): Use int for menu_bar_items_used
6475 instead of EMACS_INT, since it always fits in int.
6477 * menu.c (grow_menu_items): Check for int overflow.
6479 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6481 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6482 Before, the code was not consistent. These values cannot exceed
6483 2**31 - 1 so there's no need to make them unsigned.
6484 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6485 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6486 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6488 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6490 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6491 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6492 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6493 presumably because the widths might not match.
6495 * window.c (size_window): Avoid needless test at loop start.
6497 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6499 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6501 2011-05-12 Drew Adams <drew.adams@oracle.com>
6503 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6505 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6507 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6508 `width' to `bar_area_x' and `bar_area_width', respectively.
6509 (x_scroll_run): Take account of fringe background extension.
6511 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6512 Rename local vars `left' and `width' to `bar_area_x' and
6513 `bar_area_width', respectively.
6514 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6515 background extension.
6517 2011-05-10 Jim Meyering <meyering@redhat.com>
6519 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6521 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6523 * image.c (Finit_image_library): Return t for built-in image types,
6524 like pbm and xbm. (Bug#8640)
6526 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6528 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6530 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6532 * w32console.c (Fset_screen_color): Doc fix.
6533 (Fget_screen_color): New function.
6534 (syms_of_ntterm): Defsubr it.
6536 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6537 unlink the temporary file if Fcall_process didn't create it in the
6539 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6540 child process will be redirected to a file specified with `:file'.
6541 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6542 cue to call_process_cleanup not to close that handle.
6544 2011-05-07 Ben Key <bkey76@gmail.com>
6546 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6547 one of two shell specific rules, either bootstrap-temacs-CMD or
6548 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6549 to the previous implementation of the bootstrap-temacs rule.
6550 The bootstrap-temacs-CMD rule is similar to the previous
6551 implementation of the bootstrap-temacs rule except that it
6552 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6555 These changes, along with some changes to nt/configure.bat,
6556 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6557 earlier fix to add support for --cflags and --ldflags options
6558 that include quotes so that it works whether make uses cmd or
6561 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6563 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6564 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6566 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6567 a string. Handle both cases.
6568 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6569 (Fdbus_register_method): Use Qinvalid_function.
6571 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6573 * makefile.w32-in: Update dependencies.
6574 (LISP_H): Add inttypes.h and stdin.h.
6575 (PROCESS_H): Add unistd.h.
6577 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6579 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6580 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6582 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6584 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6586 * term.c (vfatal): Remove stray call to va_end.
6587 It's not needed and the C Standard doesn't allow it here anyway.
6589 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6590 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6592 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6595 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6597 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6599 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6601 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6603 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6605 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6606 * charset.c (Fdefine_charset_internal): Don't initialize
6607 charset.code_space[15]. The value was garbage, on hosts with
6608 32-bit int (Bug#8600).
6610 * lread.c (read_integer): Be more consistent with string-to-number.
6611 Use string_to_number to do the actual conversion; this avoids
6612 rounding errors and fixes some other screwups. Without this fix,
6613 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6614 (digit_to_number): Move earlier, for benefit of read_integer.
6615 Return -1 if the digit is out of range for the base, -2 if it is
6616 not a digit in any supported base. (Bug#8602)
6618 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6620 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6621 to match comment at start of function. This also removes a
6622 GCC warning about overflow in a 32+64-bit port.
6624 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6626 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6627 Reported by Stefan Monnier in
6628 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6629 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6630 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6632 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6633 (EMACS_UINTPTR): Likewise, with uintptr_t.
6635 * lisp.h: Prefer 64-bit EMACS_INT if available.
6636 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6637 on 32-bit hosts that have 64-bit int, so that they can access
6639 However, temporarily disable this change unless the temporary
6640 symbol WIDE_EMACS_INT is defined.
6642 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6644 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6645 This removes an assumption that EMACS_INT and long are the same
6646 width as pointers. The assumption is true for Emacs porting targets
6647 now, but we want to make other targets possible.
6648 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6649 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6650 In the rest of the code, change types of integers that hold casted
6651 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6652 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6653 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6654 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6655 No need to cast type when ORing.
6656 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6657 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6658 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6659 assume EMACS_INT is the same width as char *.
6660 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6661 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6662 Remove no-longer-needed casts.
6663 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6664 (xg_tool_bar_help_callback, xg_make_tool_item):
6665 Use EMACS_INTPTR to hold an integer
6666 that will be cast to void *; this can avoid a GCC warning
6667 if EMACS_INT is not the same width as void *.
6668 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6669 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6670 (current_message_1, set_message_1):
6671 Use a local to convert to proper width without a cast.
6672 * xmenu.c (dialog_selection_callback): Likewise.
6674 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6675 Also, don't assume VALBITS / RAND_BITS is less than 5,
6676 and don't rely on undefined behavior when shifting a 1 left into
6678 * lisp.h (get_random): Change signature to match.
6680 * lread.c (hash_string): Use size_t, not int, for hash computation.
6681 Normally we prefer signed values; but hashing is special, because
6682 it's better to use unsigned division on hash table sizes so that
6683 the remainder is nonnegative. Also, size_t is the natural width
6684 for hashing into memory. The previous code used 'int', which doesn't
6685 retain enough info to hash well into very large tables.
6686 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6688 * dbusbind.c: Don't possibly lose pointer info when converting.
6689 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6690 Use XPNTR rather than XHASH, so that the high-order bits of
6691 the pointer aren't lost when converting through void *.
6693 * eval.c (Fautoload): Don't double-shift a pointer.
6695 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6697 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6699 * gnutls.c (DEF_GNUTLS_FN):
6700 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6702 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6704 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6707 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6709 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6710 New version that can reserve upto 2GB of heap space.
6712 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6714 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6716 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6718 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6719 `gnutls_certificate_set_x509_key_file'.
6721 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6723 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6724 Update dependencies.
6726 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6728 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6729 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6730 Remove unused parameter `fildes'.
6731 * process.c (read_process_output, send_process): Don't pass it.
6733 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6735 Fix previous change: the library cache is defined in w32.c.
6736 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6737 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6739 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6741 Implement dynamic loading of GnuTLS on Windows.
6743 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6744 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6745 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6748 * gnutls.c (Qgnutls_dll): Define.
6749 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6750 (gnutls_*): Declare function pointers.
6751 (init_gnutls_functions): New function to initialize function pointers.
6752 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6753 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6754 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6755 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6756 (emacs_gnutls_write, emacs_gnutls_read)
6757 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6758 (Fgnutls_available_p): New function.
6759 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6760 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6761 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6763 * image.c: Include w32.h.
6764 (Vimage_type_cache): Delete.
6765 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6766 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6767 (w32_delayed_load): Move to w32.c.
6769 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6771 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6772 (w32_delayed_load): Move from image.c. When loading a library, record
6773 its filename in the :loaded-from property of the library id.
6774 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6775 Initialize and staticpro them.
6776 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6778 * process.c: Include lisp.h before w32.h, not after.
6779 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6780 instead of gnutls_record_check_pending.
6782 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6784 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6786 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6787 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6790 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6792 * xterm.c (x_set_frame_alpha): Do not set property on anything
6793 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6795 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6797 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6799 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6801 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6802 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6803 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6804 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6805 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6806 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6807 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6808 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6809 (Qgnutls_bootprop_callbacks_verify): Make static.
6811 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6813 * callproc.c: Indentation fixup.
6815 * sysdep.c (wait_for_termination_1): Make static.
6816 (wait_for_termination, interruptible_wait_for_termination):
6817 Move after wait_for_termination_1.
6819 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6821 * sysdep.c (interruptible_wait_for_termination): New function
6822 which is like wait_for_termination, but allows keyboard
6825 * callproc.c (Fcall_process): Add (:file "file") as an option for
6827 (Fcall_process_region): Ditto.
6829 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6831 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6832 rather than `XVECTOR (FOO)->size'.
6834 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6835 inttypes.h, as a gnulib replacement is used if it not available in
6838 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6840 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6841 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6842 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6844 * coding.c (coding_alloc_by_realloc): Error out if destination
6845 will grow beyond MOST_POSITIVE_FIXNUM.
6846 (decode_coding_emacs_mule): Abort if there isn't enough place in
6847 charbuf for the composition carryover bytes. Reserve an extra
6848 space for up to 2 characters produced in a loop.
6849 (decode_coding_iso_2022): Abort if there isn't enough place in
6850 charbuf for the composition carryover bytes.
6852 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6854 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6855 aborting when %lld or %lll format is passed.
6856 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6857 %llo or %llx format is passed. (Bug#8545)
6859 * window.c (window_scroll_line_based): Use a marker instead of
6860 simple variables to record original value of point. (Bug#7952)
6862 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6863 produced by %s or %c overflows available buffer space. (Bug#8545)
6865 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6867 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6868 (SIZE_MAX): Move defn after all includes, as they might #define it.
6870 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6872 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6874 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6876 * keyboard.c (Qdelayed_warnings_hook): Define.
6877 (command_loop_1): Run `delayed-warnings-hook'
6878 if Vdelayed_warnings_list is non-nil.
6879 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6880 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6882 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6884 * doprnt.c (doprnt): Don't return value smaller than the buffer
6885 size if the message was truncated. (Bug#8545).
6887 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6889 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6890 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6892 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6894 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6896 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6898 * makefile.w32-in: Update dependencies.
6900 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6902 Improve `doprnt' and its usage. (Bug#8545)
6903 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6904 `format_end'. Remove support for %l as a conversion specifier.
6905 Don't use xrealloc. Improve diagnostics when the %l size modifier
6906 is used. Update the commentary.
6908 * eval.c (verror): Simplify calculation of size_t.
6910 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6913 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6915 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6918 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6920 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6921 This makes this file independent of the recent pseudovector change.
6923 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6925 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6927 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6928 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6929 Remove unused local.
6930 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6932 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6933 GCC 4.6.0 optimizes based on type-based alias analysis.
6934 For example, if b is of type struct buffer * and v of type struct
6935 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6936 != &v->size, and therefore "v->size = 1; b->size = 2; return
6937 v->size;" must therefore return 1. This assumption is incorrect
6938 for Emacs, since it type-puns struct Lisp_Vector * with many other
6939 types. To fix this problem, this patch adds a new type struct
6940 vectorlike_header that documents the constraints on layout of vectors
6941 and pseudovectors, and helps optimizing compilers not get fooled
6942 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6943 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6944 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6946 (XSETPVECTYPE): Rewrite in terms of new macro.
6947 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6948 This is a bit clearer, and further avoids the possibility of
6949 undesirable aliasing.
6950 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6951 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6952 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6953 since Lisp_Subr is a special case (no "next" field).
6954 (ASIZE): Now uses header.size rather than size.
6955 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6956 to avoid the hassle of writing XVECTOR (foo)->header.size.
6957 (struct vectorlike_header): New type.
6958 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6959 object, to help avoid aliasing.
6960 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6961 (SUBRP): Likewise, since Lisp_Subr is a special case.
6962 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6963 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6964 (struct Lisp_Hash_Table): Combine first two members into a single
6965 struct vectorlike_header member. All uses of "size" and "next" members
6966 changed to be "header.size" and "header.next".
6967 * buffer.h (struct buffer): Likewise.
6968 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6969 * frame.h (struct frame): Likewise.
6970 * process.h (struct Lisp_Process): Likewise.
6971 * termhooks.h (struct terminal): Likewise.
6972 * window.c (struct save_window_data, struct saved_window): Likewise.
6973 * window.h (struct window): Likewise.
6974 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6975 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6976 * buffer.c (init_buffer_once): Likewise.
6977 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6979 * process.c (Fformat_network_address): Use local var for size,
6982 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6984 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6985 * data.c (atof): Remove decl; no longer used or needed.
6986 (digit_to_number): Move to lread.c.
6987 (Fstring_to_number): Use new string_to_number function, to be
6988 consistent with how the Lisp reader treats infinities and NaNs.
6989 Do not assume that floating-point numbers represent EMACS_INT
6990 without losing information; this is not true on most 64-bit hosts.
6991 Avoid double-rounding errors, by insisting on integers when
6992 parsing non-base-10 numbers, as the documentation specifies.
6993 * lisp.h (string_to_number): New decl, replacing ...
6994 (isfloat_string): Remove.
6995 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6996 (read1): Do not accept +. and -. as integers; this
6997 appears to have been a coding error. Similarly, do not accept
6998 strings like +-1e0 as floating point numbers. Do not report
6999 overflow for integer overflows unless the base is not 10 which
7000 means we have no simple and reliable way to continue.
7001 Break out the floating-point parsing into a new
7002 function string_to_number, so that Fstring_to_number parses
7003 floating point numbers consistently with the Lisp reader.
7004 (digit_to_number): Move here from data.c. Make it static inline.
7005 (E_CHAR, EXP_INT): Remove, replacing with ...
7006 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7007 (string_to_number): New function, replacing isfloat_string.
7008 This function checks for valid syntax and produces the resulting
7009 Lisp float number too. Rework it so that string-to-number
7010 no longer mishandles examples like "1.0e+". Use strtoumax,
7011 so that overflow for non-base-10 numbers is reported only when
7012 there's no portable and simple way to convert to floating point.
7014 * textprop.c (set_text_properties_1): Rewrite for clarity,
7015 and to avoid GCC warning about integer overflow.
7017 * intervals.h (struct interval): Use EMACS_INT for members
7018 where EMACS_UINT might cause problems. See
7019 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7020 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7021 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7023 (offset_intervals): Tell GCC not to worry about length overflow
7024 when negating a negative length.
7026 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7027 (overrun_check_free): Likewise.
7029 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7030 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7033 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7034 (gnutls_make_error): Rename local to avoid shadowing.
7035 (gnutls_emacs_global_deinit): ifdef out; not used.
7036 (Fgnutls_boot): Use const for pointer to readonly storage.
7037 Comment out unused local. Fix pointer signedness problems.
7039 * lread.c (openp): Don't stuff size_t into an 'int'.
7040 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7041 about possible signed overflow.
7043 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7044 (GDK_KEY_g): Don't define if already defined.
7045 (xg_prepare_tooltip): Avoid pointer signedness problem.
7046 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7048 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7049 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7051 * xfns.c (Fx_window_property): Simplify a bit,
7052 to make a bit faster and to avoid GCC 4.6.0 warning.
7053 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7055 * fns.c (internal_equal): Don't assume size_t fits in int.
7057 * alloc.c (compact_small_strings): Tighten assertion a little.
7059 Replace pEd with more-general pI, and fix some printf arg casts.
7060 * lisp.h (pI): New macro, generalizing old pEd macro to other
7061 conversion specifiers. For example, use "...%"pI"d..." rather
7062 than "...%"pEd"...".
7063 (pEd): Remove. All uses replaced with similar uses of pI.
7064 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7065 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7066 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7067 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7068 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7069 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7070 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7072 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7073 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7074 * print.c (safe_debug_print, print_object): Likewise.
7075 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7077 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7078 avoiding the 0 flag, which is not portable.
7079 * process.c (Fmake_network_process): Use pI to avoid cast.
7080 * region-cache.c (pp_cache): Likewise.
7081 * xdisp.c (decode_mode_spec): Likewise.
7082 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7083 behavior on 64-bit hosts with printf arg.
7084 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7085 (x_stop_queuing_selection_requests): Likewise.
7086 (x_get_window_property): Don't truncate byte count to an 'int'
7089 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7090 here, since it parses constructs like leading '-' and spaces,
7091 which are not wanted; and it overflows with large numbers.
7092 Instead, simply match F[0-9]+, which is what is wanted anyway.
7094 * alloc.c: Remove unportable assumptions about struct layout.
7095 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7096 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7097 (allocate_vectorlike, make_pure_vector): Use the new macros,
7098 plus offsetof, to remove unportable assumptions about struct layout.
7099 These assumptions hold on all porting targets that I know of, but
7100 they are not guaranteed, they're easy to remove, and removing them
7101 makes further changes easier.
7103 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7104 This doesn't fix a bug but makes the code clearer.
7105 (string_overrun_cookie): Now const. Use initializers that
7106 don't formally overflow signed char, to avoid warnings.
7107 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7108 can cause Emacs to crash when string overrun checking is enabled.
7109 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7110 multiple of sizeof (EMACS_INT); it need not be, if
7111 alignof(EMACS_INT) < sizeof (EMACS_INT).
7112 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7114 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7116 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7118 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7120 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7121 supposed to be handshaking. (Bug#8556)
7122 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7124 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7126 * lisp.h (Qdebug): List symbol.
7127 * eval.c (Qdebug): Restore global linkage.
7128 * keyboard.c (debug-on-event): New variable.
7129 (handle_user_signal): Break into debugger when debug-on-event
7130 matches the current signal symbol.
7132 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7134 * alloc.c (check_sblock, check_string_bytes)
7135 (check_string_free_list): Convert to standard C.
7137 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7139 * w32.c (emacs_gnutls_push): Fix typo.
7141 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7143 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7144 "cast to pointer from integer of different size".
7146 Improve doprnt and its use in verror. (Bug#8545)
7147 * doprnt.c (doprnt): Document the set of format control sequences
7148 supported by the function. Use SAFE_ALLOCA instead of always
7151 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7152 is one byte too soon. Don't use xrealloc; instead xfree and
7155 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7157 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7160 * gnutls.c: Renamed global_initialized to
7161 gnutls_global_initialized. Added internals for the
7162 :verify-hostname-error, :verify-error, and :verify-flags
7163 parameters of `gnutls-boot' and documented those parameters in the
7164 docstring. Start callback support.
7165 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7166 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7167 on error. Return error code.
7168 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7169 (emacs_gnutls_read): Likewise.
7170 (Fgnutls_boot): Return handshake error code.
7171 (emacs_gnutls_handle_error): New function.
7172 (wsaerror_to_errno): Likewise.
7174 * w32.h (emacs_gnutls_pull): Add prototype.
7175 (emacs_gnutls_push): Likewise.
7177 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7178 (emacs_gnutls_push): Likewise.
7180 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7182 * process.c (wait_reading_process_output): Check if GnuTLS
7183 buffered some data internally if no FDs are set for TLS
7186 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7187 (LIBS): Link to USER_LIBS.
7188 ($(BLD)/gnutls.$(0)): New target.
7190 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7192 * xdisp.c (handle_single_display_spec): Rename the
7193 display_replaced_before_p argument into display_replaced_p, to
7194 make it consistent with the commentary. Fix typos in the
7197 * textprop.c (syms_of_textprop): Remove dead code.
7198 (copy_text_properties): Delete obsolete commentary about an
7199 interface that was deleted long ago. Fix typos in the description
7202 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7203 to changes in oldXMenu/XMenu.h from 2011-04-16.
7204 <menu_help_message, prev_menu_help_message>: Constify.
7205 (IT_menu_make_room): menu->help_text is now `const char **';
7208 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7209 to changes in oldXMenu/XMenu.h from 2011-04-16.
7210 (struct XMenu): Declare `help_text' `const char **'.
7212 * xfaces.c <Qunspecified>: Make extern again.
7214 * syntax.c: Include sys/types.h before including regex.h, as
7217 * doc.c (get_doc_string): Improve the format passed to `error'.
7219 * doprnt.c (doprnt): Improve commentary.
7221 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7223 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7226 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7227 changes in globals.h immediately force recompilation.
7228 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7229 $(CURDIR)/s/ms-w32.h.
7230 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7232 * character.c (Fchar_direction): Function deleted.
7233 (syms_of_character): Don't defsubr it.
7234 <char-direction-table>: Deleted.
7236 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7238 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7239 * doprnt.c: Include limits.h.
7240 (SIZE_MAX): New macro.
7241 (doprnt): Return a size_t value. 2nd arg is now size_t.
7242 Many local variables are now size_t instead of int or unsigned.
7243 Improve overflow protection. Support `l' modifier for integer
7244 conversions. Support %l conversion. Don't assume an EMACS_INT
7245 argument for integer conversions and for %c.
7247 * lisp.h (doprnt): Restore prototype.
7249 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7252 * Makefile.in (base_obj): Add back doprnt.o.
7254 * deps.mk (doprnt.o): Add back prerequisites.
7255 (callint.o): Depend on character.h.
7257 * eval.c (internal_lisp_condition_case): Include the handler
7258 representation in the error message.
7259 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7260 when breaking from the loop.
7262 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7264 * callint.c (Fcall_interactively): When displaying error message
7265 about invalid control letter, pass the character's codepoint, not
7266 a pointer to its multibyte form. Improve display of the character
7267 in octal and display also its hex code.
7269 * character.c (char_string): Use %x to display the (unsigned)
7270 codepoint of an invalid character, to avoid displaying a bogus
7273 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7274 `error', not SYMBOL_NAME itself.
7276 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7277 character arguments to `error'.
7279 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7280 to `error' in error message about FINAL_CHAR argument. Make sure
7281 FINAL_CHAR is a character, and use %c when it is passed as
7282 argument to `error'.
7284 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7286 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7288 * w32.c: Include <time.h>.
7289 (sys_localtime): New function.
7291 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7293 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7295 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7297 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7299 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7302 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7304 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7305 gl_state.e_property when gl_state.object is Qt.
7307 * insdel.c (make_gap_larger): Remove limitation of buffer size
7310 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7312 * xdisp.c (lookup_glyphless_char_display)
7313 (produce_glyphless_glyph): Handle cons cell entry in
7314 glyphless-char-display.
7315 (Vglyphless_char_display): Document it.
7317 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7318 glyphless-char-display.
7320 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7322 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7324 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7326 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7327 definition for no-X builds.
7329 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7331 Static checks with GCC 4.6.0 and non-default toolkits.
7333 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7335 * process.c (keyboard_bit_set): Define only if SIGIO.
7336 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7337 (send_process): Repair possible setjmp clobbering.
7339 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7341 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7343 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7345 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7346 Define only if needed.
7348 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7349 by pacifying GCC about it. Maybe it's time to retire it?
7350 * xfaces.c (USG, __TIMEVAL__): Likewise.
7352 * dispextern.h (struct redisplay_interface): Rename param
7354 * termhooks.h (struct terminal): Likewise.
7355 * xterm.c (xembed_send_message): Likewise.
7357 * insdel.c (make_gap_smaller): Define only if
7358 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7360 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7363 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7364 so that we aren't warned about unused symbols.
7366 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7368 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7370 * xfns.c (x_real_positions): Mark locals as initialized.
7372 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7374 * xterm.c: Fix problems found by static analysis with other toolkits.
7375 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7376 (x_dispatch_event): Declare static if USE_GTK, and
7377 define if USE_GTK || USE_X_TOOLKIT.
7378 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7379 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7380 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7381 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7383 * xmenu.c (menu_help_callback): Pointer type fixes.
7384 Use const pointers when pointing at readonly data. Avoid pointer
7386 (FALSE): Remove unused macro.
7387 (update_frame_menubar): Remove unused decl.
7389 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7391 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7392 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7393 (single_menu_item): Rename local to avoid shadowing.
7395 * keyboard.c (make_lispy_event): Remove unused local var.
7397 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7398 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7400 * bitmaps: Change bitmaps from unsigned char back to the X11
7401 compatible char. Avoid the old compiler warnings about
7402 out-of-range initializers by using, for example, '\xab' rather
7405 * xgselect.c (xgselect_initialize): Check vs interface
7406 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7408 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7410 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7411 to read-only memory.
7413 * fns.c (vector): Remove; this old hack is no longer needed.
7415 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7417 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7419 * xrdb.c (x_load_resources): Omit unused local.
7421 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7422 (x_window): Rename locals to avoid shadowing.
7423 (USG): Use the kludged USG macro, to pacify gcc.
7425 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7426 (x_term_init): Remove local to avoid shadowing.
7428 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7430 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7431 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7433 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7435 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7437 Fix regex.c, syntax.c and friends for buffers > 2GB.
7438 * syntax.h (struct gl_state_s): Declare character position members
7441 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7443 * textprop.c (verify_interval_modification, interval_of):
7444 Declare arguments EMACS_INT.
7446 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7449 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7451 * indent.c (Fvertical_motion): Local variable it_start is now
7454 * regex.c (re_match, re_match_2, re_match_2_internal)
7455 (bcmp_translate, regcomp, regexec, print_double_string)
7456 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7457 (re_compile_pattern, re_exec): Declare arguments and local
7458 variables `size_t' and `ssize_t' and return values `regoff_t', as
7460 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7461 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7462 <compile_stack_type>: `size' and `avail' are now `size_t'.
7464 * regex.h <regoff_t>: Use ssize_t, not int.
7465 (re_search, re_search_2, re_match, re_match_2): Arguments that
7466 specify buffer/string position and length are now ssize_t and
7467 size_t. Return type is regoff_t.
7469 2011-04-16 Ben Key <bkey76@gmail.com>
7471 * nsfont.m: Fixed bugs in ns_get_family and
7472 ns_descriptor_to_entity that were caused by using free to
7473 deallocate memory blocks that were allocated by xmalloc (via
7474 xstrdup). This caused Emacs to crash when compiled with
7475 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7476 --enable-checking=xmallocoverrun). xfree is now used to
7477 deallocate these memory blocks.
7479 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7481 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7483 emacs_write: Accept and return EMACS_INT for sizes.
7484 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7486 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7487 Accept and return EMACS_INT.
7488 (emacs_gnutls_write): Return the number of bytes written on
7490 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7491 (emacs_read, emacs_write): Remove check for negative size, as the
7492 Emacs source code has been audited now.
7493 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7494 (emacs_read, emacs_write): Use it.
7495 * process.c (send_process): Adjust to the new signatures of
7496 emacs_write and emacs_gnutls_write. Do not attempt to store
7497 a byte offset into an 'int'; it might overflow.
7498 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7500 * sound.c: Don't assume sizes fit in 'int'.
7501 (struct sound_device.period_size, alsa_period_size):
7502 Return EMACS_INT, not int.
7503 (struct sound_device.write, vox_write, alsa_write):
7504 Accept EMACS_INT, not int.
7505 (wav_play, au_play): Use EMACS_INT to store sizes and to
7506 record read return values.
7508 2011-04-15 Ben Key <bkey76@gmail.com>
7510 * keyboard.c (Qundefined): Don't declare static since it is used
7512 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7513 static since they are used in nsfont.m.
7515 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7517 * process.c (Qprocessp): Don't declare static.
7518 * lisp.h (Qprocessp): Declare again.
7520 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7522 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7524 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7526 Improve C-level modularity by making more things 'static'.
7528 Don't publish debugger-only interfaces to other modules.
7529 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7530 (verify_bytepos, count_markers): Move decls to the only modules
7532 * region-cache.h (pp_cache): Likewise.
7533 * window.h (check_all_windows): Likewise.
7534 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7536 * sysdep.c (croak): Now static, if
7537 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7538 * syssignal.h (croak): Declare only if not static.
7540 * alloc.c (refill_memory_reserve): Now static if
7541 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7542 * lisp.h (refill_memory_reserve): Declare only if not static.
7544 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7545 Define only if USE_LUCID.
7547 * xrdb.c (x_customization_string, x_rm_string): Now static.
7549 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7550 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7552 * xdisp.c (draw_row_with_mouse_face): Now static.
7553 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7555 * window.h (check_all_windows): Mark externally visible.
7557 * window.c (window_deletion_count): Now static.
7559 * undo.c: Make symbols static if they're not exported.
7560 (last_undo_buffer, last_boundary_position, pending_boundary):
7563 * textprop.c (interval_insert_behind_hooks): Now static.
7564 (interval_insert_in_front_hooks): Likewise.
7566 * term.c: Make symbols static if they're not exported.
7567 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7568 (max_frame_lines, tty_set_terminal_modes):
7569 (tty_reset_terminal_modes, tty_turn_off_highlight):
7570 (get_tty_terminal): Now static.
7571 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7572 * termhooks.h (term_mouse_moveto): Do not declare if
7574 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7575 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7577 * sysdep.c: Make symbols static if they're not exported.
7578 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7580 (sigprocmask_set, full_mask): Remove; unused.
7581 (wait_debugging): Mark as visible.
7582 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7583 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7585 * syntax.c (syntax_temp): Define only if !__GNUC__.
7587 * sound.c (current_sound_device, current_sound): Now static.
7589 * search.c (searchbufs, searchbuf_head): Now static.
7591 * scroll.c (scroll_cost): Remove; unused.
7592 * dispextern.h (scroll_cost): Remove decl.
7594 * region-cache.h (pp_cache): Mark as externally visible.
7596 * process.c: Make symbols static if they're not exported.
7597 (process_tick, update_tick, create_process, chan_process):
7598 (Vprocess_alist, proc_buffered_char, datagram_access):
7599 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7600 (deactivate_process): Mark defn as static, as well as decl.
7601 * lisp.h (create_process): Remove decl.
7602 * process.h (chan_process, Vprocess_alist): Remove decls.
7604 * print.c: Make symbols static if they're not exported.
7605 (print_depth, new_backquote_output, being_printed, print_buffer):
7606 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7607 (print_interval, print_number_index, initial_stderr_stream):
7609 * lisp.h (Fprinc): Remove decl.
7610 (debug_output_compilation_hack): Mark as externally visible.
7612 * sysdep.c (croak): Move decl from here to syssignal.h.
7613 * syssignal.h (croak): Put it here, so the API can be checked when
7614 'croak' is called from dissociate_if_controlling_tty.
7616 * minibuf.c: Make symbols static if they're not exported.
7617 (minibuf_save_list, choose_minibuf_frame): Now static.
7618 * lisp.h (choose_minibuf_frame): Remove decl.
7620 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7622 * lread.c: Make symbols static if they're not exported.
7623 (read_objects, initial_obarray, oblookup_last_bucket_number):
7625 (make_symbol): Remove; unused.
7626 * lisp.h (initial_obarray, make_symbol): Remove decls.
7628 * keyboard.c: Make symbols static if they're not exported.
7629 (single_kboard, recent_keys_index, total_keys, recent_keys):
7630 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7631 (this_single_command_key_start, echoing, last_auto_save):
7632 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7633 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7634 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7635 (Vlispy_mouse_stem, double_click_count):
7637 (force_auto_save_soon): Define only if SIGDANGER.
7638 (ignore_mouse_drag_p): Now static if
7639 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7640 (print_help): Remove; unused.
7641 (stop_character, last_timer_event): Mark as externally visible.
7642 * keyboard.h (ignore_mouse_drag_p): Declare only if
7643 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7644 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7645 * lisp.h (echoing): Remove decl.
7646 (force_auto_save_soon): Declare only if SIGDANGER.
7647 * xdisp.c (redisplay_window): Simplify code, to make it more
7648 obvious that ignore_mouse_drag_p is not accessed if !defined
7649 USE_GTK && !defined HAVE_NS.
7651 * intervals.c: Make symbols static if they're not exported.
7652 (merge_properties_sticky, merge_interval_right, delete_interval):
7654 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7656 * insdel.c: Make symbols static if they're not exported.
7657 However, leave prepare_to_modify_buffer alone. It's never
7658 called from outside this function, but that appears to be a bug.
7659 (combine_after_change_list, combine_after_change_buffer):
7660 (adjust_after_replace, signal_before_change): Now static.
7661 (adjust_after_replace_noundo): Remove; unused.
7662 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7663 (signal_before_change): Remove decls.
7665 * indent.c (val_compute_motion, val_vmotion): Now static.
7667 * image.c: Make symbols static if they're not exported.
7668 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7670 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7671 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7673 * fringe.c (standard_bitmaps): Now static.
7674 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7676 * frame.c: Make symbols static if they're not exported.
7677 (x_report_frame_params, make_terminal_frame): Now static.
7678 (get_frame_param): Now static, unless HAVE_NS.
7679 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7680 (x_get_resource_string): Remove; not used.
7681 * frame.h (make_terminal_frame, x_report_frame_params):
7682 (x_get_resource_string); Remove decls.
7683 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7684 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7686 * font.c, fontset.c: Make symbols static if they're not exported.
7687 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7688 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7689 * font.c (font_close_object): Now static.
7690 * font.h (font_close_object): Remove.
7691 * fontset.c (FONTSET_OBJLIST): Remove.
7692 (free_realized_fontset) #if-0 the body, which does nothing.
7693 (face_suitable_for_char_p): #if-0, as it's never called.
7694 * fontset.h (face_suitable_for_char_p): Remove decl.
7695 * xfaces.c (face_at_string_position):
7696 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7697 since 0 is always ASCII.
7699 * fns.c (weak_hash_tables): Now static.
7701 * fileio.c: Make symbols static if they're not exported.
7702 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7703 (Vwrite_region_annotation_buffers): Now static.
7705 * eval.c: Make symbols static if they're not exported.
7706 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7707 * lisp.h (backtrace_list): Remove decl.
7709 * emacs.c: Make symbols static if they're not exported.
7710 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7711 (fatal_error_code, fatal_error_signal_hook, standard_args):
7713 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7714 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7715 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7716 * lisp.h (fatal_error_signal_hook): Remove decl.
7717 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7719 * editfns.c: Move a (normally-unused) function to its only use.
7720 * editfns.c, lisp.h (get_operating_system_release): Remove.
7721 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7722 worth the hassle of breaking this out.
7724 * xterm.c: Make symbols static if they're not exported.
7725 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7726 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7727 (x_destroy_window, x_delete_display):
7729 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7730 (x_mouse_leave): Remove; unused.
7731 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7732 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7733 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7735 (x_mouse_leave): Declare only if WINDOWSNT.
7736 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7737 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7740 * ftxfont.c: Make symbols static if they're not exported.
7741 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7743 * font.h (ftxfont_driver): Likewise.
7745 * xfns.c: Make symbols static if they're not exported.
7746 (x_last_font_name, x_display_info_for_name):
7747 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7748 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7749 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7750 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7751 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7752 (last_show_tip_args): Now static.
7753 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7754 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7755 (x_screen_planes): Remove; unused.
7756 * dispextern.h (x_screen_planes): Remove decl.
7758 * dispnew.c: Make symbols static if they're not exported.
7759 * dispextern.h (redraw_garbaged_frames, scrolling):
7760 (increment_row_positions): Remove.
7761 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7762 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7764 (redraw_garbaged_frames): Remove; unused.
7766 * xfaces.c: Make symbols static if they're not exported.
7767 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7769 * xterm.h (defined_color): Remove decls.
7770 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7771 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7772 (menu_face_changed_default, defined_color, free_realized_face):
7773 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7774 (ascii_face_of_lisp_face): Remove; unused.
7776 * xdisp.c: Make symbols static if they're not exported.
7777 * dispextern.h (scratch_glyph_row, window_box_edges):
7778 (glyph_to_pixel_coords, set_cursor_from_row):
7779 (get_next_display_element, set_iterator_to_next):
7780 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7781 (show_mouse_face): Remove decls
7782 * frame.h (message_buf_print): Likewise.
7783 * lisp.h (pop_message, set_message, check_point_in_composition):
7785 * xterm.h (set_vertical_scroll_bar): Likewise.
7786 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7787 (message_buf_print, scratch_glyph_row, displayed_buffer):
7788 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7789 (get_next_display_element, show_mouse_face, window_box_edges):
7790 (frame_to_window_pixel_xy, check_point_in_composition):
7791 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7792 (glyph_to_pixel_coords): Remove; unused.
7794 * dired.c (file_name_completion): Now static.
7796 * dbusbind.c (xd_in_read_queued_messages): Now static.
7798 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7799 * data.c (circular_list_error): Remove.
7801 * commands.h (last_point_position, last_point_position_buffer):
7802 (last_point_position_window): Remove decls.
7803 * keyboard.c: Make these variables static.
7805 * coding.h (coding, code_convert_region, encode_coding_gap):
7807 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7808 (iso_code_class, detect_coding, code_convert_region): Now static.
7809 (encode_coding_gap): Remove; unused.
7811 * chartab.c (chartab_chars, chartab_bits): Now static.
7813 * charset.h (charset_iso_8859_1): Remove decl.
7814 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7817 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7818 * ccl.c (Vccl_program_table): Now static.
7819 (check_ccl_update): Remove; unused.
7821 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7822 * category.h: ... from here.
7823 * category.c (check_category_table, set_category_set): Now static.
7825 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7826 * lisp.h: Remove these decls.
7828 * buffer.c (buffer_count): Remove unused var.
7830 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7831 so that it's not optimized away.
7832 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7833 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7834 exported only to the debugger.
7836 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7837 * atimer.h (run_all_atimers): Remove; not exported.
7839 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7840 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7841 was inaccessible from Lisp.
7842 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7843 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7845 alloc.c: Import and export fewer symbols, and remove unused items.
7846 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7848 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7849 it's not optimized away by whole-program optimization.
7850 (message_enable_multibyte, free_misc): Remove.
7851 (catchlist, handlerlist, mark_backtrace):
7852 Declare only if BYTE_MARK_STACK.
7853 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7854 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7855 (message_enable_multibyte): Remove decl.
7856 (free_misc, interval_free_list, float_block, float_block_index):
7857 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7858 (cons_free_list, last_marked_index):
7860 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7861 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7862 (mark_backtrace): Define only if BYTE_MARK_STACK.
7863 * xdisp.c (message_enable_multibyte): Now static.
7865 Declare Lisp_Object Q* variables to be 'static' if not exported.
7866 This makes it easier for human readers (and static analyzers)
7867 to see whether these variables are used from other modules.
7868 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7869 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7870 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7871 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7872 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7873 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7874 * xmenu.c, xselect.c:
7875 Declare Q* vars static if they are not used in other modules.
7876 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7877 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7878 Remove decls of unexported vars.
7879 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7881 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7883 Make Emacs functions such as Fatom 'static' by default.
7884 This makes it easier for human readers (and static analyzers)
7885 to see whether these functions can be called from other modules.
7886 DEFUN now defines a static function. To make the function external
7887 so that it can be used in other C modules, use the new macro DEFUE.
7888 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7889 (Finit_image_library):
7890 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7891 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7892 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7893 Remove decls, since these functions are now static.
7894 (Funintern, Fget_internal_run_time): New decls, since these functions
7895 were already external.
7897 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7898 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7899 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7900 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7901 * keyboard.c, keymap.c, lread.c:
7902 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7903 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7904 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7905 Mark functions with DEFUE instead of DEFUN,
7906 if they are used in other modules.
7907 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7908 decls for now-static functions.
7909 * buffer.h (Fdelete_overlay): Remove decl.
7910 * callproc.c (Fgetenv_internal): Mark as internal.
7911 * composite.c (Fremove_list_of_text_properties): Remove decl.
7912 (Fcomposition_get_gstring): New forward static decl.
7913 * composite.h (Fcomposite_get_gstring): Remove decl.
7914 * dired.c (Ffile_attributes): New forward static decl.
7915 * doc.c (Fdocumntation_property): New forward static decl.
7916 * eval.c (Ffetch_bytecode): New forward static decl.
7917 (Funintern): Remove extern decl; now in .h file where it belongs.
7918 * fileio.c (Fmake_symbolic_link): New forward static decl.
7919 * image.c (Finit_image_library): New forward static decl.
7920 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7921 * intervals.h (Fprevious_property_change):
7922 (Fremove_list_of_text_properties): Remove decls.
7923 * keyboard.c (Fthis_command_keys): Remove decl.
7924 (Fcommand_execute): New forward static decl.
7925 * keymap.c (Flookup_key): New forward static decl.
7926 (Fcopy_keymap): Now static.
7927 * keymap.h (Flookup_key): Remove decl.
7928 * process.c (Fget_process): New forward static decl.
7929 (Fprocess_datagram_address): Mark as internal.
7930 * syntax.c (Fsyntax_table_p): New forward static decl.
7931 (skip_chars): Remove duplicate decl.
7932 * textprop.c (Fprevious_property_change): New forward static decl.
7933 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7935 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7936 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7938 * editfns.c (Fformat): Remove unreachable code.
7940 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7942 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7945 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7947 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7948 when at ZV. (Bug#8487)
7950 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7952 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7954 * keyboard.c (parse_tool_bar_item): Likewise.
7955 * sound.c (sound_cleanup, alsa_close): Likewise.
7956 * termcap.c (tgetent): Likewise.
7957 * xfns.c (x_default_font_parameter): Likewise.
7958 * xsettings.c (read_and_apply_settings): Likewise.
7960 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7961 (overrun_check_free): Protoize.
7963 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7965 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7966 since callers should never pass a negative size.
7967 Change the signature to match that of plain 'read' and 'write'; see
7968 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7969 * lisp.h: Update prototypes of emacs_write and emacs_read.
7971 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7973 * xdisp.c (redisplay_window): Don't try to determine the character
7974 position of the scroll margin if the window start point w->startp
7975 is outside the buffer's accessible region. (Bug#8468)
7977 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7979 Fix write-region and its subroutines for buffers > 2GB.
7980 * fileio.c (a_write, e_write): Modify declaration of arguments and
7981 local variables to support buffers larger than 2GB.
7982 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7984 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7985 argument, local variables, and return value.
7987 * lisp.h: Update prototypes of emacs_write and emacs_read.
7989 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7991 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7993 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7995 Fix more problems found by GCC 4.6.0's static checks.
7997 * xdisp.c (vmessage): Use a better test for character truncation.
7999 * charset.c (load_charset_map): <, not <=, for optimization,
8000 and to avoid potential problems with integer overflow.
8001 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8002 * casetab.c (set_identity, shuffle): Likewise.
8003 * editfns.c (Fformat): Likewise.
8004 * syntax.c (skip_chars): Likewise.
8006 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8007 This also lets GCC 4.6.0 generate slightly better loop code.
8009 * callint.c (Fcall_interactively): <, not <=, for optimization.
8010 (Fcall_interactively): Count the number of arguments produced,
8011 not the number of arguments given. This is simpler and lets GCC
8012 4.6.0 generate slightly better code.
8014 * ftfont.c: Distingish more carefully between FcChar8 and char.
8015 The previous code passed unsigned char * to a functions like
8016 strlen and xstrcasecmp that expect char *, which does not
8017 conform to the C standard.
8018 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8019 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8020 char * when the C standard requires it.
8022 * keyboard.c (read_char): Remove unused var.
8024 * eval.c: Port to Windows vsnprintf (Bug#8435).
8026 (SIZE_MAX): Define if the headers do not.
8027 (verror): Do not give up if vsnprintf returns a negative count.
8028 Instead, grow the buffer. This ports to Windows vsnprintf, which
8029 does not conform to C99. Problem reported by Eli Zaretskii.
8030 Also, simplify the allocation scheme, by avoiding the need for
8031 calling realloc, and removing the ALLOCATED variable.
8033 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8035 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8036 But keep the doprint source code for now, as we might revamp it
8037 and use it again (Bug#8435).
8038 * lisp.h (doprnt): Remove.
8039 * Makefile.in (base_obj): Remove doprnt.o.
8040 * deps.mk (doprnt.o): Remove.
8042 error: Print 32- and 64-bit integers portably (Bug#8435).
8043 Without this change, on typical 64-bit hosts error ("...%d...", N)
8044 was used to print both 32- and 64-bit integers N, which relied on
8046 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8047 * lisp.h (error, verror): Mark as printf-like functions.
8048 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8049 Report overflow in size calculations when allocating printf buffer.
8050 Do not truncate output string at its first null byte.
8051 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8052 Truncate the output at a character boundary, since vsnprintf does not
8054 * charset.c (check_iso_charset_parameter): Convert internal
8055 character to string before calling 'error', since %c now has the
8057 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8058 overflow when computing char to be passed to 'error'. Do not
8059 pass Lisp_Object to 'error'; pass the integer instead.
8060 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8061 formatted with plain %d.
8063 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8065 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8067 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8069 * xterm.c (x_catch_errors): Remove duplicate declaration.
8071 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8073 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8075 2011-04-10 Jim Meyering <meyering@redhat.com>
8077 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8078 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8079 return ssize_t not "int", and use size_t as the buffer length.
8080 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8081 * gnutls.h: Update declarations.
8082 * process.c (read_process_output): Use ssize_t, to match.
8083 (send_process): Likewise.
8085 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8087 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8089 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8091 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8092 Use unsigned char, to match FcChar8 type definition.
8094 * xterm.c (handle_one_xevent):
8095 * xmenu.c (create_and_show_popup_menu):
8096 * xselect.c (x_decline_selection_request)
8097 (x_reply_selection_request): Avoid type-punned deref of X events.
8099 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8101 Fix some uses of `int' instead of EMACS_INT.
8102 * search.c (string_match_1, fast_string_match)
8103 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8104 (scan_buffer, find_next_newline_no_quit)
8105 (find_before_next_newline, search_command, Freplace_match)
8106 (Fmatch_data): Make some `int' variables be EMACS_INT.
8108 * xdisp.c (display_count_lines): 3rd argument and return value now
8109 EMACS_INT. All callers changed.
8110 (pint2hrstr): Last argument is now EMACS_INT.
8112 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8113 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8114 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8115 (decode_coding_utf_16, decode_coding_emacs_mule)
8116 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8117 (decode_coding_ccl, decode_coding_charset)
8118 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8119 (decode_coding_iso_2022, decode_coding_emacs_mule)
8120 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8121 <char_offset, last_offset>: Declare EMACS_INT.
8122 (encode_coding_utf_8, encode_coding_utf_16)
8123 (encode_coding_emacs_mule, encode_invocation_designation)
8124 (encode_designation_at_bol, encode_coding_iso_2022)
8125 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8126 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8128 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8129 (encode_invocation_designation): Last argument P_NCHARS is now
8131 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8132 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8134 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8137 * ccl.c (Fccl_execute_on_string): Declare some variables
8140 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8142 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8144 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8146 * process.c (Fformat_network_address): Doc fix.
8148 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8150 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8152 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8154 * keyboard.c (read_char): Call Lisp function help-form-show,
8155 instead of using internal_with_output_to_temp_buffer.
8156 (Qhelp_form_show): New var.
8157 (syms_of_keyboard): Use DEFSYM macro.
8159 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8161 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8163 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8165 * process.c (Flist_processes): Remove to Lisp.
8166 (list_processes_1): Delete.
8168 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8170 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8172 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8174 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8176 Fix more problems found by GCC 4.6.0's static checks.
8178 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8180 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8182 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8184 * xdisp.c (vmessage): Mark as a printf-like function.
8186 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8188 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8190 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8191 printf-like functions.
8192 (tiff_load): Add casts to remove these marks before passing them
8193 to system-supplied API.
8195 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8197 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8198 This avoids several warnings with gcc -Wstrict-overflow.
8199 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8200 directly, rather than having caller test rule sign. This avoids
8201 some unnecessary tests.
8202 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8203 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8204 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8206 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8207 (xfont_open): Avoid unnecessary tests.
8209 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8211 * composite.h, composite.c (composition_gstring_put_cache):
8212 Use EMACS_INT, not int, for length.
8214 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8215 breaking out part of COMPOSITION_DECODE_RULE.
8216 (COMPOSITION_DECODE_RULE): Use it.
8217 * composite.c (get_composition_id): Remove unused local vars,
8218 by using the new macro.
8220 * textprop.c (set_text_properties_1): Change while to do-while,
8221 since the condition is always true at first.
8223 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8224 (interval_deletion_adjustment): Return unsigned value.
8227 * process.c (list_processes_1, create_pty, read_process_output):
8228 (exec_sentinel): Remove vars that were set but not used.
8229 (create_pty): Remove unnecessary "volatile"s.
8230 (Fnetwork_interface_info): Avoid possibility of int overflow.
8231 (read_process_output): Do adaptive read buffering even if carryover.
8232 (read_process_output): Simplify nbytes computation if buffered.
8234 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8236 * syntax.c (scan_words): Remove var that was set but not used.
8237 (update_syntax_table): Use unsigned instead of int.
8239 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8240 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8241 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8243 * print.c (print_error_message): Avoid int overflow.
8245 * font.c (font_list_entities): Redo for clarity,
8246 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8248 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8249 (font_score): Avoid potential overflow in diff calculation.
8251 * fns.c (substring_both): Remove var that is set but not used.
8252 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8254 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8256 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8257 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8258 can always succeed if overflow has undefined behavior.
8260 * search.c (boyer_moore, wordify): Remove vars set but not used.
8261 (wordify): Omit three unnecessary tests.
8263 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8264 All callers changed. This avoids the need for an unused var.
8266 * casefiddle.c (casify_region): Remove var that is set but not used.
8268 * dired.c (file_name_completion): Remove var that is set but not used.
8270 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8272 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8273 (Finsert_file_contents): Remove unnecessary code checking fd.
8275 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8276 Check for integer overflow on size calculations.
8278 * buffer.c (Fprevious_overlay_change): Remove var that is set
8281 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8282 Remove vars that are set but not used.
8283 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8284 (timer_check_2): Mark vars as initialized.
8286 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8288 * image.c (lookup_image): Remove var that is set but not used.
8289 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8291 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8292 that are set but not used.
8294 * xfns.c (make_invisible_cursor): Don't return garbage
8295 if XCreateBitmapFromData fails (Bug#8410).
8297 * xselect.c (x_get_local_selection, x_handle_property_notify):
8298 Remove vars that are set but not used.
8300 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8301 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8303 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8304 Remove var that is set but not used.
8305 (scroll_bar_windows_size): Now size_t, not int.
8306 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8309 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8310 (map_tty_color) [!defined MSDOS]: Likewise.
8312 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8314 * coding.c: Remove vars that are set but not used.
8315 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8316 All callers changed.
8317 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8318 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8319 (decode_coding_charset): Remove vars that are set but not used.
8321 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8322 that is set but not used.
8324 * print.c (print_object): Remove var that is set but not used.
8326 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8327 The gnulib version avoids calling malloc in the usual case,
8328 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8329 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8330 * filelock.c (current_lock_owner): Likewise.
8331 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8332 * sysdep.c: Include allocator.h, careadlinkat.h.
8333 (emacs_no_realloc_allocator): New static constant.
8334 (emacs_readlink): New function.
8335 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8336 ../lib/careadlinkat.h.
8338 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8340 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8341 first non-nil return value).
8343 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8345 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8346 if not defined (Bug#8403).
8348 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8350 * xdisp.c (display_count_lines): Remove parameter `start',
8351 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8352 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8353 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8354 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8355 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8356 and thereabouts. All callers changed.
8357 (get_per_char_metric): Remove parameter `f', unused since
8358 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8360 2011-04-02 Jim Meyering <meyering@redhat.com>
8362 do not dereference NULL upon failed strdup
8363 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8364 (ns_get_family): Likewise.
8366 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8368 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8370 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8372 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8375 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8377 Add lexical binding.
8379 * window.c (Ftemp_output_buffer_show): New fun.
8380 (Fsave_window_excursion):
8381 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8383 * lread.c (lisp_file_lexically_bound_p): New function.
8384 (Fload): Bind Qlexical_binding.
8385 (readevalloop): Remove `evalfun' arg.
8386 Bind Qinternal_interpreter_environment.
8387 (Feval_buffer): Bind Qlexical_binding.
8388 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8390 (syms_of_lread): Declare `lexical-binding'.
8392 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8394 * keyboard.c (eval_dyn): New fun.
8395 (menu_item_eval_property): Use it.
8397 * image.c (parse_image_spec): Use Ffunctionp.
8399 * fns.c (concat, mapcar1): Accept byte-code-functions.
8401 * eval.c (Fsetq): Handle lexical vars.
8402 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8403 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8404 (FletX, Flet): Obey lexical binding.
8405 (Fcommandp): Handle closures.
8406 (Feval): New `lexical' arg.
8407 (eval_sub): New function extracted from Feval. Use it almost
8408 everywhere where Feval was used. Look up vars in lexical env.
8410 (Ffunctionp): Move from subr.el.
8411 (Ffuncall): Handle closures.
8412 (apply_lambda): Remove `eval_flags'.
8413 (funcall_lambda): Handle closures and new byte-code-functions.
8414 (Fspecial_variable_p): New function.
8415 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8416 but without exporting it to Lisp.
8418 * doc.c (Fdocumentation, store_function_docstring):
8419 * data.c (Finteractive_form): Handle closures.
8421 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8424 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8426 (exec_byte_code): New function extracted from Fbyte_code to handle new
8427 calling convention for byte-code-functions. Add new byte-codes.
8429 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8431 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8433 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8435 * xdisp.c (redisplay_internal): Fix prototype.
8437 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8439 * xdisp.c (SCROLL_LIMIT): New macro.
8440 (try_scrolling): Use it when setting scroll_limit.
8441 Limit scrolling to 100 screen lines.
8442 (redisplay_window): Even when falling back on "recentering",
8443 position point in the window according to scroll-conservatively,
8444 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8446 (try_scrolling): When point is above the window, allow searching
8447 as far as scroll_max, or one screenful, to compute vertical
8448 distance from PT to the scroll margin position. This prevents
8449 try_scrolling from unnecessarily failing when
8450 scroll-conservatively is set to a value slightly larger than the
8451 window height. Clean up the case of PT below the margin at bottom
8452 of window: scroll_max can no longer be INT_MAX. When aggressive
8453 scrolling is in use, don't let point enter the opposite scroll
8454 margin as result of the scroll.
8455 (syms_of_xdisp) <scroll-conservatively>: Document the
8456 threshold of 100 lines for never-recentering scrolling.
8458 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8460 * dispextern.h (move_it_by_lines):
8461 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8462 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8463 (message_log_check_duplicate): Remove parameters `prev_bol' and
8464 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8465 (redisplay_internal): Remove parameter `preserve_echo_area',
8466 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8468 * indent.c (Fvertical_motion):
8469 * window.c (window_scroll_pixel_based, Frecenter):
8470 Don't pass `need_y_p' to `move_it_by_lines'.
8472 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8474 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8475 steal a few bits to be more compact.
8476 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8477 Remove unneeded casts.
8479 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8481 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8483 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8484 binding" message (bug#7967).
8486 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8488 Fix more problems found by GCC 4.6.0's static checks.
8490 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8491 Remove unused local var.
8493 * editfns.c (Fmessage_box): Remove unused local var.
8495 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8496 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8497 Omit unused local vars.
8498 * window.c (shrink_windows): Omit unused local var.
8499 * menu.c (digest_single_submenu): Omit unused local var.
8500 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8501 Omit unused local var.
8503 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8504 Don't assume string length fits in int.
8505 (keyremap_step, read_key_sequence): Use size_t for sizes.
8506 (read_key_sequence): Don't check last_real_key_start redundantly.
8508 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8509 instead of alloca (Bug#8344).
8511 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8512 (Fbacktrace_frame): Don't assume nframes fits in int.
8514 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8516 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8519 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8521 * cm.c (calccost): Turn while-do into do-while, for clarity.
8523 * keyboard.c (syms_of_keyboard): Use the same style as later
8524 in this function when indexing through an array. This also
8525 works around GCC bug 48267.
8527 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8529 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8531 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8532 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8534 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8535 This avoids undefined behavior on integer overflow, and is a bit
8536 more convenient anyway since it is compared to a size_t variable.
8538 Variadic C functions now count arguments with size_t, not int.
8539 This avoids an unnecessary limitation on 64-bit machines, which
8540 caused (substring ...) to crash on large vectors (Bug#8344).
8541 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8542 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8543 All variadic functions and their callers changed accordingly.
8544 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8545 * data.c (arith_driver, float_arith_driver): Likewise.
8546 * editfns.c (general_insert_function): Likewise.
8547 * eval.c (struct backtrace.nargs, interactive_p)
8548 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8549 (funcall_lambda, mark_backtrace): Likewise.
8550 * fns.c (concat): Likewise.
8551 * frame.c (x_set_frame_parameters): Likewise.
8552 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8553 0 if not found, not -1. All callers changed.
8555 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8556 (stack_copy_size): Now size_t, not int.
8557 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8559 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8561 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8562 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8563 All callers changed.
8565 * lisp.h (multibyte_char_to_unibyte):
8566 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8567 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8568 * character.h (CHAR_TO_BYTE8):
8569 * cmds.c (internal_self_insert):
8570 * editfns.c (general_insert_function):
8571 * keymap.c (push_key_description):
8572 * search.c (Freplace_match):
8573 * xdisp.c (message_dolog, set_message_1): All callers changed.
8575 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8577 * keyboard.c (safe_run_hook_funcall): New function.
8578 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8579 don't set the hook to nil, but remove the offending function instead.
8580 (Qcommand_hook_internal): Remove, unused.
8581 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8582 Vcommand_hook_internal.
8584 * eval.c (enum run_hooks_condition): Remove.
8585 (funcall_nil, funcall_not): New functions.
8586 (run_hook_with_args): Call each function through a `funcall' argument.
8587 Remove `cond' argument, now redundant.
8588 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8589 (Frun_hook_with_args_until_failure): Adjust accordingly.
8590 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8592 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8594 * dispextern.h (string_buffer_position): Remove declaration.
8596 * print.c (strout): Remove parameter `multibyte', unused since
8597 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8599 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8600 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8601 All callers changed.
8603 * w32.c (_wsa_errlist): Use braces for struct initializers.
8605 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8606 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8607 All callers changed.
8608 (string_buffer_position): Likewise. Also, make static (it's never
8609 used outside xdisp.c).
8610 (cursor_row_p): Remove parameter `w', unused since
8611 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8612 (decode_mode_spec): Remove parameter `precision', introduced during
8613 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8614 All callers changed.
8616 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8618 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8620 2011-03-27 Anders Lindgren <andlind@gmail.com>
8622 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8623 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8624 (ns_update_auto_hide_menu_bar): New functions.
8625 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8626 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8627 ns_constrain_all_frames.
8628 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8629 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8631 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8633 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8635 2011-03-27 Glenn Morris <rgm@gnu.org>
8637 * syssignal.h: Replace RETSIGTYPE with void.
8638 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8639 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8640 Replace SIGTYPE with void everywhere.
8641 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8642 * s/template.h (SIGTYPE): Remove commented out definition.
8644 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8646 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8647 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8649 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8651 * w32.c (read_unc_volume): Use parameter `henum', instead of
8652 global variable `wget_enum_handle'.
8654 * keymap.c (describe_vector): Remove parameters `indices' and
8655 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8656 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8658 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8660 * keyboard.c (timer_check): Remove parameter `do_it_now',
8661 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8662 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8663 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8665 * keyboard.c (read_char):
8666 * w32menu.c (w32_menu_display_help):
8667 * xmenu.c (show_help_event, menu_help_callback):
8668 Adjust calls to `show_help_echo'.
8670 * gtkutil.c (xg_maybe_add_timer):
8671 * keyboard.c (readable_events):
8672 * process.c (wait_reading_process_output):
8673 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8675 * insdel.c (adjust_markers_gap_motion):
8676 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8677 (gap_left, gap_right): Don't call it.
8679 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8681 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8682 incurred during fontification.
8684 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8686 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8687 (DEFVAR_PER_BUFFER): Don't pass it.
8689 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8690 (scrolling_window): Don't pass it.
8692 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8694 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8696 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8698 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8699 of variables specific to SELinux and computation of `encoded_absname'.
8701 * image.c (XPutPixel): Remove unused variable `height'.
8703 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8705 * unexw32.c (get_section_info): Remove unused variable `section'.
8707 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8708 (system_process_attributes): Remove unused variable `sess'.
8709 (sys_read): Remove unused variable `err'.
8711 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8712 (w32_wnd_proc): Remove unused variable `isdead'.
8713 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8714 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8715 (x_create_tip_frame): Remove unused variable `tem'.
8717 * w32inevt.c (w32_console_read_socket):
8718 Remove unused variable `no_events'.
8720 * w32term.c (x_draw_composite_glyph_string_foreground):
8721 Remove unused variable `width'.
8723 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8725 * w32term.c (x_set_glyph_string_clipping):
8726 Don't pass uninitialized region to CombineRgn.
8728 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8730 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8731 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8732 (Fx_close_connection): Remove unused variable `i'.
8734 * w32font.c (w32font_draw): Return number of glyphs.
8735 (w32font_open_internal): Remove unused variable `i'.
8736 (w32font_driver): Add missing initializer.
8738 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8739 (fill_in_menu): Remove unused variable `items_added'.
8741 * w32term.c (last_mouse_press_frame): Remove static global variable.
8742 (w32_clip_to_row): Remove unused variable `f'.
8743 (x_delete_terminal): Remove unused variable `i'.
8745 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8746 (NOTHING): Remove unused static global variable.
8747 (uniscribe_check_otf): Remove unused variable `table'.
8748 (uniscribe_font_driver): Add missing initializers.
8750 2011-03-23 Julien Danjou <julien@danjou.info>
8752 * term.c (Fsuspend_tty, Fresume_tty):
8753 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8754 * window.c (temp_output_buffer_show):
8755 * insdel.c (signal_before_change):
8756 * frame.c (Fhandle_switch_frame):
8757 * fileio.c (Fdo_auto_save):
8758 * emacs.c (Fkill_emacs):
8759 * editfns.c (save_excursion_restore):
8760 * cmds.c (internal_self_insert):
8761 * callint.c (Fcall_interactively):
8762 * buffer.c (Fkill_all_local_variables):
8763 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8765 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8766 unconditionally since it does the check itself.
8768 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8770 Fix more problems found by GCC 4.5.2's static checks.
8772 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8773 the first time through the loop, since we know p0 < p1 then.
8774 This also avoids a gcc -Wstrict-overflow warning.
8776 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8777 leading to a memory leak, possible in functions like
8778 load_charset_map_from_file that can allocate an unbounded number
8779 of objects (Bug#8318).
8781 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8782 that could (at least in theory) be that large.
8784 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8785 This is less likely to overflow, and avoids undefined behavior if
8786 overflow does occur. All callers changed. Use strtoul to scan
8787 for the unsigned long integer.
8788 (pint2hrstr): Simplify and tune code slightly.
8789 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8791 * scroll.c (do_scrolling): Work around GCC bug 48228.
8792 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8794 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8795 This also avoids a warning with gcc -Wstrict-overflow.
8796 (validate_x_resource_name): Simplify count usage.
8797 This also avoids a warning with gcc -Wstrict-overflow.
8799 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8802 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8804 * process.c (Fmake_network_process): Use socklen_t, not int,
8805 where POSIX says socklen_t is required in portable programs.
8806 This fixes a porting bug on hosts like 64-bit HP-UX, where
8807 socklen_t is wider than int (Bug#8277).
8808 (Fmake_network_process, server_accept_connection):
8809 (wait_reading_process_output, read_process_output):
8812 * process.c: Rename or move locals to avoid shadowing.
8813 (list_processes_1, Fmake_network_process):
8814 (read_process_output_error_handler, exec_sentinel_error_handler):
8815 Rename or move locals.
8816 (Fmake_network_process): Define label "retry_connect" only if needed.
8817 (Fnetwork_interface_info): Fix pointer signedness.
8818 (process_send_signal): Add cast to avoid pointer signedness problem.
8819 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8820 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8822 Make tparam.h and terminfo.c consistent.
8823 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8824 Include tparam.h instead, since it declares them.
8825 * cm.h (PC): Remove extern decl; tparam.h now does this.
8826 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8827 * terminfo.c: Include tparam.h, to check interfaces.
8828 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8829 (tparam): Adjust signature to match interface in tparam.h;
8830 this removes some undefined behavior. Check that outstring and len
8831 are zero, which they always are with Emacs.
8832 * tparam.h (PC, BC, UP): New extern decls.
8834 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8835 (xftfont_open): Rename locals to avoid shadowing.
8837 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8838 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8839 (OTF_TAG_SYM): Omit macro if not needed.
8840 (ftfont_list): Remove unused local.
8841 (get_adstyle_property, ftfont_pattern_entity):
8842 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8843 Rename locals to avoid shadowing.
8845 * xfont.c (xfont_list_family): Mark var as initialized.
8847 * xml.c (make_dom): Now static.
8849 * composite.c (composition_compute_stop_pos): Rename local to
8851 (composition_reseat_it): Remove unused locals.
8852 (find_automatic_composition, composition_adjust_point): Likewise.
8853 (composition_update_it): Mark var as initialized.
8854 (find_automatic_composition): Mark vars as initialized,
8855 with a FIXME (Bug#8290).
8857 character.h: Rename locals to avoid shadowing.
8858 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8859 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8860 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8861 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8864 * textprop.c (property_change_between_p): Remove; unused.
8866 * intervals.c (interval_start_pos): Now static.
8868 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8870 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8871 Rename locals to avoid shadowing.
8873 * sound.c (wav_play, au_play, Fplay_sound_internal):
8874 Fix pointer signedness.
8875 (alsa_choose_format): Remove unused local var.
8876 (wav_play): Initialize a variable to 0, to prevent undefined
8877 behavior (Bug#8278).
8879 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8881 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8883 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8884 clobbering (Bug#8298).
8885 * sysdep.c (sys_subshell): Likewise.
8886 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8888 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8889 This should get cleaned up, so that child_setup has the
8890 same signature on all platforms.
8892 * callproc.c (call_process_cleanup): Now static.
8893 (relocate_fd): Rename locals to avoid shadowing.
8895 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8897 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8898 not to be necessary, and produces flickering.
8900 2011-03-20 Glenn Morris <rgm@gnu.org>
8902 * config.in: Remove file.
8904 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8906 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8907 are now in src/globals.h.
8908 (syms_of_minibuf): Remove spurious & from previous change.
8910 2011-03-20 Leo Liu <sdl.web@gmail.com>
8912 * minibuf.c (completing-read-function): New variable.
8913 (completing-read-default): Rename from completing-read.
8914 (completing-read): Call completing-read-function.
8916 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8918 * xfaces.c (Fx_load_color_file):
8919 Read color file from absolute filename (bug#8250).
8921 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8923 * makefile.w32-in: Update dependencies.
8925 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8927 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8929 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8931 Fix more problems found by GCC 4.5.2's static checks.
8933 * process.c (make_serial_process_unwind, send_process_trap):
8934 (sigchld_handler): Now static.
8936 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8937 That way, the code declares only the vars that it needs.
8938 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8939 * s/cygwin.h (PTY_ITERATION): Likewise.
8940 * s/darwin.h (PTY_ITERATION): Likewise.
8941 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8943 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8944 * process.c (allocate_pty): Don't declare stb unless it's needed.
8946 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8947 (CONSTANTLIM): Remove; unused.
8948 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8949 Define only if needed.
8951 * unexelf.c (unexec): Name an expression,
8952 to avoid gcc -Wbad-function-cast warning.
8953 Use a different way to cause a compilation error if anyone uses
8954 n rather than nn, a way that does not involve shadowing.
8955 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8957 * deps.mk (unexalpha.o): Remove; unused.
8959 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8960 * unexec.h: New file.
8961 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8962 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8964 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8965 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8966 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8967 Change as necessary to match prototype in unexec.h.
8969 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8971 (back_comment, skip_chars): Mark vars as initialized.
8973 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8974 Rename locals to avoid shadowing.
8976 * lread.c (read1): Rewrite so as not to use empty "else".
8977 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8979 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8981 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8982 warning when compiling print.c.
8984 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8985 instead of using an uninitialized var.
8986 (font_sort_entities): Mark var as initialized.
8988 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8990 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8991 pointers to constants.
8992 (font_parse_fcname): Remove unused vars.
8993 (font_delete_unmatched): Now static.
8994 (font_get_spec): Remove; unused.
8995 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8996 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8997 Rename or move locals to avoid shadowing.
8999 * fns.c (require_nesting_list, require_unwind): Now static.
9000 (Ffillarray): Rename locals to avoid shadowing.
9002 * floatfns.c (domain_error2): Define only if needed.
9003 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9005 * alloc.c (mark_backtrace): Move decl from here ...
9006 * lisp.h: ... to here, so that it can be checked.
9008 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9009 (Fdefvar): Rewrite so as not to use empty "else".
9010 (lisp_indirect_variable): Name an expression,
9011 to avoid gcc -Wbad-function-cast warning.
9012 (Fdefvar): Rename locals to avoid shadowing.
9014 * callint.c (quotify_arg, quotify_args): Now static.
9015 (Fcall_interactively): Rename locals to avoid shadowing.
9016 Use const pointer when appropriate.
9018 * lisp.h (get_system_name, get_operating_system_release):
9019 Move decls here, to check interfaces.
9020 * process.c (get_operating_system_release): Move decl to lisp.h.
9021 * xrdb.c (get_system_name): Likewise.
9022 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9023 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9024 some of which prompt warnings from gcc -Wbad-function-cast.
9025 (Fformat_time_string, Fencode_time, Finsert_char):
9026 (Ftranslate_region_internal, Fformat):
9027 Rename or remove local vars to avoid shadowing.
9028 (Ftranslate_region_internal): Mark var as initialized.
9030 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9033 * lisp.h (eassert): Check that the argument compiles, even if
9034 ENABLE_CHECKING is not defined.
9036 * data.c (Findirect_variable): Name an expression, to avoid
9037 gcc -Wbad-function-cast warning.
9038 (default_value, arithcompare, arith_driver, arith_error): Now static.
9039 (store_symval_forwarding): Rename local to avoid shadowing.
9040 (Fmake_variable_buffer_local, Fmake_local_variable):
9041 Mark variables as initialized.
9042 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9044 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9045 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9046 Rename locals to avoid shadowing.
9047 (mark_stack): Move local variables into the #ifdef region where
9049 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9050 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9052 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9053 (GC_STRING_CHARS): Remove; not used.
9054 (Fmemory_limit): Cast sbrk's returned value to char *.
9056 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9057 avoids undefined behavior in theory.
9059 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9061 Use functions, not macros, for up- and down-casing (Bug#8254).
9062 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9063 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9064 to use the following functions instead of these macros.
9065 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9066 EMACS_INT, since callers assume the returned value fits in int.
9067 (upcase1): Likewise, for UPCASE_TABLE.
9068 (uppercasep, lowercasep, upcase): New static inline functions.
9069 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9070 the race-condition problem in the old DOWNCASE.
9072 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9073 Rename locals to avoid shadowing.
9074 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9075 (regex_compile, re_search_2, re_match_2_internal):
9076 Remove unused local vars.
9077 (FREE_VAR): Rewrite so as not to use empty "else",
9078 which gcc can warn about.
9079 (regex_compile, re_match_2_internal): Mark locals as initialized.
9080 (RETALLOC_IF): Define only if needed.
9081 (WORDCHAR_P): Likewise. This one is never needed, but is used
9082 only in a comment talking about a compiler bug, so put inside
9083 the #if 0 of that comment.
9084 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9085 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9088 * search.c (boyer_moore): Rename locals to avoid shadowing.
9089 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9090 (PREV_CHAR_BOUNDARY): Likewise.
9092 * search.c (simple_search): Remove unused var.
9094 * dired.c (compile_pattern): Move decl from here ...
9095 * lisp.h: ... to here, so that it can be checked.
9096 (struct re_registers): New forward decl.
9098 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9100 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9102 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9103 Rename locals to avoid shadowing.
9104 (Fvertical_motion): Mark locals as initialized.
9106 * casefiddle.c (casify_object, casify_region): Now static.
9107 (casify_region): Mark local as initialized.
9109 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9111 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9112 New macros, so that the caller can use some names other than
9113 gcpro1, gcpro2, etc.
9114 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9116 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9117 argument, for consistency with GCPRO2_VAR, etc: it is now the
9118 prefix of the variable, not the variable itself. All uses
9120 * dired.c (directory_files_internal, file_name_completion):
9121 Rename locals to avoid shadowing.
9123 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9124 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9125 dired.c's scmp function, had undefined behavior.
9126 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9127 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9128 * buffer.h: ... to here, because these macros use current_buffer,
9129 and the new implementation with inline functions needs to have
9130 current_buffer in scope now, rather than later when the macros
9132 (downcase, upcase1): New static inline functions.
9133 (DOWNCASE, UPCASE1): Reimplement using these functions.
9134 This avoids undefined behavior in expressions like
9135 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9136 from race conditions in accessing the global variables
9137 case_temp1 and case_temp2.
9138 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9139 * lisp.h (case_temp1, case_temp2): Remove their decls.
9140 * character.h (ASCII_CHAR_P): Move from here ...
9141 * lisp.h: ... to here, so that the inline functions mentioned
9144 * dired.c (directory_files_internal_unwind): Now static.
9146 * fileio.c (file_name_as_directory, directory_file_name):
9147 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9149 (file_name_as_directory): Use const pointers when appropriate.
9150 (Fexpand_file_name): Likewise. In particular, newdir might
9151 point at constant storage, so make it a const pointer.
9152 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9153 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9155 (Fset_file_times, Finsert_file_contents, auto_save_error):
9156 Rename locals to avoid shadowing.
9158 * minibuf.c (choose_minibuf_frame_1): Now static.
9159 (Ftry_completion, Fall_completions): Rename or remove locals
9162 * marker.c (bytepos_to_charpos): Remove; unused.
9164 * lisp.h (verify_bytepos, count_markers): New decls,
9165 so that gcc does not warn that these functions aren't declared.
9167 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9168 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9169 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9170 (copy_text): Remove unused local var.
9172 * filelock.c (within_one_second): Now static.
9173 (lock_file_1): Rename local to avoid shadowing.
9175 * buffer.c (fix_overlays_before): Mark locals as initialized.
9176 (fix_start_end_in_overlays): Likewise. This function should be
9177 simplified by using pointers-to-pointers, but that's a different
9179 (switch_to_buffer_1): Now static.
9180 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9181 (report_overlay_modification): Rename locals to avoid shadowing.
9183 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9184 Fix pointer signedness issue.
9185 (sys_subshell): Mark local as volatile if checking for lint,
9186 to suppress a gcc -Wclobbered warning that does not seem to be right.
9187 (MAXPATHLEN): Define only if needed.
9189 * process.c (serial_open, serial_configure): Move decls from here ...
9190 * systty.h: ... to here, so that they can be checked.
9192 * fns.c (get_random, seed_random): Move extern decls from here ...
9193 * lisp.h: ... to here, so that they can be checked.
9195 * sysdep.c (reset_io): Now static.
9196 (wait_for_termination_signal): Remove; unused.
9198 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9199 (copy_keymap_item, append_key, push_text_char_description):
9201 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9202 (DENSE_TABLE_SIZE): Remove; unused.
9203 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9204 (describe_map_tree):
9205 Rename locals to avoid shadowing.
9207 * keyboard.c: Declare functions static if they are not used elsewhere.
9208 (echo_char, echo_dash, cmd_error, top_level_2):
9209 (poll_for_input, handle_async_input): Now static.
9210 (read_char, kbd_buffer_get_event, make_lispy_position):
9211 (make_lispy_event, make_lispy_movement, apply_modifiers):
9212 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9213 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9214 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9215 (read_key_sequence, read_char): Mark locals as initialized.
9216 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9218 * keyboard.h (make_ctrl_char): New decl.
9219 (mark_kboards): Move decl here ...
9220 * alloc.c (mark_kboards): ... from here.
9222 * lisp.h (force_auto_save_soon): New decl.
9224 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9225 (DEFINE_DUMMY_FUNCTION): New macro.
9226 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9228 (main): Add casts to avoid warnings
9229 if GCC considers string literals to be constants.
9231 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9233 * dbusbind.c: Pointer signedness fixes.
9234 (xd_signature, xd_append_arg, xd_initialize):
9235 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9236 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9237 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9238 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9240 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9241 if GCC considers string literals to be constants.
9242 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9244 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9246 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9247 (print_preprocess, print_object): New macro to fix last change.
9249 * print.c (print_preprocess): Don't forget font objects.
9251 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9253 * emacs.c (USAGE3): Doc fixes.
9255 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9257 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9260 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9262 * lisp.h (VWindow_system, Qfile_name_history):
9263 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9264 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9265 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9267 * w32select.c: Don't #include "keyboard.h".
9268 (run_protected): Add extern declaration for waiting_for_input.
9270 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9271 * w32console.c (detect_input_pending, read_input_pending)
9272 (encode_terminal_code):
9273 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9274 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9275 (w32_system_caret_y, Qfile_name_history):
9276 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9277 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9278 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9279 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9280 * w32proc.c (Qlocal, report_file_error):
9281 * w32term.c (Vwindow_system, updating_frame):
9282 * w32uniscribe.c (initialized, uniscribe_font_driver):
9283 Remove unneeded extern declarations.
9285 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9287 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9289 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9291 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9292 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9293 These macros can no longer be used for assignment.
9295 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9296 Assign struct members directly, instead of using BUF_BEGV etc.
9297 (record_buffer_markers, fetch_buffer_markers): New functions for
9298 recording and fetching special buffer markers.
9299 (set_buffer_internal_1, set_buffer_temp): Use them.
9301 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9303 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9305 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9306 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9308 * xdisp.c (hscroll_window_tree):
9309 (reconsider_clip_changes): Use PT instead of BUF_PT.
9311 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9313 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9314 $(EMACS_ROOT)/lib/intprops.h.
9316 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9318 Fix more problems found by GCC 4.5.2's static checks.
9320 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9321 to unsigned char * to avoid compiler diagnostic.
9322 (xg_free_frame_widgets): Make it clear that a local variable is
9323 needed only if USE_GTK_TOOLTIP.
9324 (gdk_window_get_screen): Make it clear that this macro is needed
9325 only if USE_GTK_TOOLTIP.
9326 (int_gtk_range_get_value): New function, which avoids a diagnostic
9327 from gcc -Wbad-function-cast.
9328 (xg_set_toolkit_scroll_bar_thumb): Use it.
9329 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9330 diagnostic from gcc -Wbad-function-cast.
9331 (get_utf8_string, xg_get_file_with_chooser):
9332 Rename locals to avoid shadowing.
9333 (create_dialog): Move locals to avoid shadowing.
9335 * xgselect.c (xg_select): Remove unused var.
9337 * image.c (four_corners_best): Mark locals as initialized.
9338 (gif_load): Initialize transparent_p to zero (Bug#8238).
9339 Mark another local as initialized.
9340 (my_png_error, my_error_exit): Mark with NO_RETURN.
9342 * image.c (clear_image_cache): Now static.
9343 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9344 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9345 (x_edge_detection): Remove unnecessary cast that
9346 gcc -Wbad-function-cast diagnoses.
9347 (gif_load): Fix pointer signedness.
9348 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9349 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9351 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9353 Improve quality of tests for time stamp overflow.
9354 For example, without this patch (encode-time 0 0 0 1 1
9355 1152921504606846976) returns the obviously-bogus value (-948597
9356 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9357 reports time overflow. See
9358 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9359 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9360 * editfns.c: Include limits.h and intprops.h.
9361 (TIME_T_MIN, TIME_T_MAX): New macros.
9362 (time_overflow): Move earlier, to before first use.
9363 (hi_time, lo_time): New functions, for an accurate test for
9365 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9366 (Fget_internal_run_time): Don't assume time_t fits in int.
9367 (make_time): Use list2 instead of Fcons twice.
9368 (Fdecode_time): More accurate test for out-of-range times.
9369 (check_tm_member): New function.
9370 (Fencode_time): Use it, to test for out-of-range times.
9371 (lisp_time_argument): Don't rely on undefined left-shift and
9372 right-shift behavior when checking for time stamp overflow.
9374 * editfns.c (time_overflow): New function, refactoring common code.
9375 (Fformat_time_string, Fdecode_time, Fencode_time):
9376 (Fcurrent_time_string): Use it.
9378 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9379 * dired.c (make_time): Move to ...
9380 * editfns.c (make_time): ... here.
9381 * systime.h: Note the move.
9383 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9385 * fringe.c (update_window_fringes): Remove unused variables.
9387 * unexmacosx.c (copy_data_segment): Also copy __got section.
9390 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9392 * termcap.c [MSDOS]: Include "msdos.h".
9393 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9394 Constify `char *' arguments and their references according to
9395 prototypes in tparam.h.
9397 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9399 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9400 Adapt all references accordingly.
9402 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9404 2011-03-11 Tom Tromey <tromey@redhat.com>
9406 * buffer.c (syms_of_buffer): Remove obsolete comment.
9408 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9410 * termhooks.h (encode_terminal_code): Declare prototype.
9412 * msdos.c (encode_terminal_code): Don't declare prototype.
9414 * term.c (encode_terminal_code): Now external again, used by
9415 w32console.c and msdos.c.
9417 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9418 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9420 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9422 Fix some minor problems found by GCC 4.5.2's static checks.
9424 * fringe.c (update_window_fringes): Mark locals as initialized
9426 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9428 * alloc.c (mark_fringe_data): Move decl from here ...
9429 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9430 to check its interface.
9431 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9433 * fontset.c (free_realized_fontset): Now static.
9434 (Fset_fontset_font): Rename local to avoid shadowing.
9435 (fontset_font): Mark local as initialized.
9436 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9438 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9440 * xselect.c (x_disown_buffer_selections): Remove; not used.
9441 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9442 (x_own_selection, Fx_disown_selection_internal): Rename locals
9444 (x_handle_dnd_message): Remove local to avoid shadowing.
9446 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9447 so that the caller can use some name other than gcpro1.
9448 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9449 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9450 (Fx_backspace_delete_keys_p):
9451 Use them to avoid shadowing, and rename vars to avoid shadowing.
9452 (x_decode_color, x_set_name, x_window): Now static.
9453 (Fx_create_frame): Add braces to silence GCC warning.
9454 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9455 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9456 Remove unused locals.
9457 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9458 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9459 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9462 * xterm.h (x_mouse_leave): New decl.
9464 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9465 Remove unused functions.
9466 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9467 (x_calc_absolute_position): Now static.
9468 (XTread_socket): Don't define label "out" unless it's used.
9469 Don't declare local "event" unless it's used.
9470 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9471 unless they are used.
9472 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9473 (x_fatal_error_signal): Remove; not used.
9474 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9475 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9476 (x_error_catcher, x_connection_closed, x_error_handler):
9477 (x_error_quitter, xembed_send_message, x_iconify_frame):
9478 (my_log_handler): Rename locals to avoid shadowing.
9479 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9480 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9482 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9483 Rename or move locals to avoid shadowing.
9484 (tty_defined_color, merge_face_heights): Now static.
9485 (free_realized_faces_for_fontset): Remove; not used.
9486 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9487 does not deduce is never used uninitialized.
9488 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9489 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9491 * terminal.c (store_terminal_param): Now static.
9493 * xmenu.c (menu_highlight_callback): Now static.
9494 (set_frame_menubar): Remove unused local.
9495 (xmenu_show): Rename parameter to avoid shadowing.
9496 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9497 since they might point to immutable storage.
9498 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9499 since it's unused otherwise.
9501 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9502 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9503 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9504 avoids a gcc -Wuninitialized diagnostic.
9505 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9506 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9507 does not deduce are never used uninitialized.
9509 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9511 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9512 * window.c (window_loop, size_window):
9513 (run_window_configuration_change_hook, enlarge_window): Likewise.
9515 * window.c (display_buffer): Now static.
9516 (size_window): Mark variables that gcc -Wuninitialized
9517 does not deduce are never used uninitialized.
9518 * window.h (check_all_windows): New decl, to forestall
9519 gcc -Wmissing-prototypes diagnostic.
9520 * dispextern.h (bidi_dump_cached_states): Likewise.
9522 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9524 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9526 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9527 and to avoid gcc -Wuninitialized warning.
9528 (load_charset_map): Mark variables that gcc -Wuninitialized
9529 does not deduce are never used uninitialized.
9530 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9532 * coding.c (coding_set_source, coding_set_destination):
9533 Use "else { /* comment */ }" rather than "else /* comment */;"
9534 for clarity, and to avoid gcc -Wempty-body warning.
9535 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9536 a block, when the outer 'i' will do.
9537 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9538 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9539 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9540 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9541 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9542 Rename locals to avoid shadowing.
9543 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9544 * coding.c (emacs_mule_char, encode_invocation_designation):
9545 Now static, since they're not used elsewhere.
9546 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9547 (decode_coding_object, encode_coding_object, detect_coding_system):
9548 (decode_coding_emacs_mule): Mark variables that gcc
9549 -Wuninitialized does not deduce are never used uninitialized.
9550 (detect_coding_iso_2022): Initialize a local variable that might
9551 be used uninitialized. Leave a FIXME because it's not clear that
9552 this initialization is needed. (Bug#8211)
9553 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9554 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9555 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9556 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9557 Remove unused macros.
9559 * category.c (hash_get_category_set): Remove unused local var.
9560 (copy_category_table): Now static, since it's not used elsewhere.
9561 * character.c (string_count_byte8): Likewise.
9563 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9564 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9566 * chartab.c (copy_sub_char_table): Now static, since it's not used
9568 (sub_char_table_ref_and_range, char_table_ref_and_range):
9569 Rename locals to avoid shadowing.
9570 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9572 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9573 (BIDI_BOB): Remove unused macro.
9575 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9576 deduce are never used uninitialized.
9577 * term.c (encode_terminal_code): Likewise.
9579 * term.c (encode_terminal_code): Now static. Remove unused local.
9581 * tparam.h: New file.
9582 * term.c, tparam.h: Include it.
9583 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9584 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9585 Move these decls to tparam.h, and make them agree with what
9586 is actually in tparam.c. The previous trick of using incompatible
9587 decls in different modules does not conform to the C standard.
9588 All callers of tparam changed to use tparam's actual API.
9589 * tparam.c (tparam1, tparam, tgoto):
9590 Use const pointers where appropriate.
9592 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9593 * cm.h (struct cm): Likewise.
9594 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9595 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9596 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9597 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9598 (turn_on_face, init_tty): Likewise.
9599 * termchar.h (struct tty_display_info): Likewise.
9601 * term.c (term_mouse_position): Rename local to avoid shadowing.
9603 * alloc.c (mark_ttys): Move decl from here ...
9604 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9606 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9608 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9610 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9612 * search.c (compile_pattern_1): Remove argument regp, unused since
9613 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9614 (compile_pattern): Don't pass it.
9616 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9618 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9619 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9621 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9623 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9625 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9626 gdk_window_get_screen, gdk_window_get_geometry,
9627 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9628 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9629 (xg_get_pixbuf_from_pixmap): New function.
9630 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9631 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9632 Call xg_get_pixbuf_from_pixmap instead of
9633 gdk_pixbuf_get_from_drawable.
9634 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9635 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9636 (xg_check_special_colors): Use GtkStyleContext and its functions
9638 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9639 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9640 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9641 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9642 Call gtk_widget_get_preferred_size.
9643 (xg_frame_resized): gdk_window_get_geometry only takes 5
9645 (xg_win_to_widget, xg_event_is_for_menubar):
9646 Call gdk_x11_window_lookup_for_display.
9647 (xg_set_widget_bg): New function.
9648 (delete_cb): New function.
9649 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9650 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9651 (xg_set_background_color): Call xg_set_widget_bg.
9652 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9653 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9654 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9655 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9657 (update_frame_tool_bar): Call gtk_widget_hide.
9658 (xg_initialize): Use GDK_KEY_g.
9660 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9662 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9664 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9665 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9666 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9668 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9670 * w32xfns.c (select_palette): Check success of RealizePalette against
9671 GDI_ERROR, not zero.
9673 See ChangeLog.11 for earlier changes.
9679 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9681 This file is part of GNU Emacs.
9683 GNU Emacs is free software: you can redistribute it and/or modify
9684 it under the terms of the GNU General Public License as published by
9685 the Free Software Foundation, either version 3 of the License, or
9686 (at your option) any later version.
9688 GNU Emacs is distributed in the hope that it will be useful,
9689 but WITHOUT ANY WARRANTY; without even the implied warranty of
9690 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9691 GNU General Public License for more details.
9693 You should have received a copy of the GNU General Public License
9694 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.