merge trunk
[bpt/emacs.git] / src / ChangeLog
1 2012-03-19 Kenichi Handa <handa@m17n.org>
2
3 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4 it fit in a valid range (Bug#11003).
5
6 2012-03-18 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
9 that is not from display property, accept the row as a "cursor
10 row" if one of the string's character has a non-nil `cursor'
11 property. Fixes cursor positioning when there are newlines in
12 overlay strings, e.g. in icomplete.el. (Bug#11035)
13
14 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
15
16 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
17
18 2012-03-12 Chong Yidong <cyd@gnu.org>
19
20 * eval.c (inhibit_lisp_code): Rename from
21 inhibit_window_configuration_change_hook; move from window.c.
22
23 * xfns.c (unwind_create_frame_1, Fx_create_frame):
24 * window.c (run_window_configuration_change_hook)
25 (syms_of_window): Callers changed.
26
27 2012-03-11 Chong Yidong <cyd@gnu.org>
28
29 * keymap.c (Fkey_description): Doc fix (Bug#9700).
30
31 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
32
33 2012-03-10 Chong Yidong <cyd@gnu.org>
34
35 * frame.c (other_visible_frames): Don't assume the selected frame
36 is visible (Bug#10955).
37
38 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
41
42 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
43
44 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
45 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
46 zero (Bug#10954).
47
48 2012-03-03 Glenn Morris <rgm@gnu.org>
49
50 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
51
52 2012-03-02 Eli Zaretskii <eliz@gnu.org>
53
54 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
55 position past the first glyph_row that ends at ZV. (Bug#10902)
56 (redisplay_window, next_element_from_string): Fix typos in
57 comments.
58 (redisplay_window): Pass to move_it_vertically the margin in
59 pixels, not in screen lines.
60
61 2012-03-02 Glenn Morris <rgm@gnu.org>
62
63 * buffer.c (buffer-list-update-hook): Doc fix.
64
65 2012-02-29 Eli Zaretskii <eliz@gnu.org>
66
67 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
68 push_it before setting up the iterator for the first overlay
69 string, even if we have an empty string loaded.
70 (next_overlay_string): If there's an empty string on the iterator
71 stack, pop the stack. (Bug#10903)
72
73 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
74
75 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
76 Suggested by Stefan Monnier in
77 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
78 * alloc.c (widen_to_Lisp_Object): New static function.
79 (mark_memory): Also mark Lisp_Objects by fetching pointer words
80 and widening them to Lisp_Objects. This would work even if
81 USE_LSB_TAG is defined and wide integers are used, which might
82 happen in a future version of Emacs.
83
84 2012-02-25 Chong Yidong <cyd@gnu.org>
85
86 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
87 Doc fix.
88
89 * xselect.c (Fx_selection_exists_p): Doc fix.
90 (x_clipboard_manager_save_all): Print an informative message
91 before saving to clipboard manager.
92
93 2012-02-24 Chong Yidong <cyd@gnu.org>
94
95 * keyboard.c (process_special_events): Handle all X selection
96 requests in kbd_buffer, not just the next one (Bug#8869).
97
98 2012-02-23 Chong Yidong <cyd@gnu.org>
99
100 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
101 call when setting menu-bar-lines and tool-bar-lines parameters.
102 (unwind_create_frame_1): New helper function.
103
104 * window.c (inhibit_window_configuration_change_hook): New var.
105 (run_window_configuration_change_hook): Obey it.
106 (syms_of_window): Initialize it.
107
108 2012-02-22 Chong Yidong <cyd@gnu.org>
109
110 * xterm.c (x_draw_image_relief): Add missing type check for
111 Vtool_bar_button_margin (Bug#10743).
112
113 2012-02-21 Chong Yidong <cyd@gnu.org>
114
115 * fileio.c (Vfile_name_handler_alist): Doc fix.
116
117 * buffer.c (Fget_file_buffer): Protect against invalid file
118 handler return value.
119
120 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
121
122 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
123 when computing $valmask.
124
125 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
126 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
127 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
128 It's useless in that case, and it can cause problems on hosts
129 that allocate halves of EMACS_INT values separately.
130 Reported by Dan Horák. Diagnosed by Andreas Schwab in
131 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
132 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
133 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
134 it avoids undefined behavior on hosts where shifting right by more
135 than the word width has undefined behavior.
136
137 2012-02-19 Chong Yidong <cyd@gnu.org>
138
139 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
140 (Funhandled_file_name_directory, Ffile_name_as_directory)
141 (Fdirectory_file_name, Fexpand_file_name)
142 (Fsubstitute_in_file_name): Protect against invalid file handler
143 return values (Bug#10845).
144
145 2012-02-18 Eli Zaretskii <eliz@gnu.org>
146
147 * .gdbinit (pitx): Fix incorrect references to fields of the
148 iterator stack.
149
150 2012-02-17 Chong Yidong <cyd@gnu.org>
151
152 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
153
154 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
155
156 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
157 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
158
159 2012-02-15 Chong Yidong <cyd@gnu.org>
160
161 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
162 marked as special. Also, starting docstrings with * is obsolete.
163
164 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
165
166 * gnutls.c (emacs_gnutls_write): Fix last change.
167
168 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
169
170 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
171 send_process.
172
173 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
174
175 * keymap.c (Fsingle_key_description): Handle char ranges.
176
177 2012-02-12 Chong Yidong <cyd@gnu.org>
178
179 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
180 as that creates a dangerous corner case.
181
182 * window.c (Fdelete_window_internal): Invalidate the mouse
183 highlight (Bug#9904).
184
185 2012-02-12 Glenn Morris <rgm@gnu.org>
186
187 * xselect.c (Fx_own_selection_internal)
188 (Fx_get_selection_internal, Fx_disown_selection_internal)
189 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
190 * nsselect.m (Fx_own_selection_internal)
191 (Fx_disown_selection_internal, Fx_selection_exists_p)
192 (Fx_selection_owner_p, Fx_get_selection_internal):
193 Sync docs and argument specs with the xselect.c versions.
194
195 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
196
197 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
198
199 2012-02-11 Eli Zaretskii <eliz@gnu.org>
200
201 * w32select.c (Fx_selection_exists_p): Sync doc string and
202 argument list with xselect.c. (Bug#10783)
203
204 * w16select.c (Fx_selection_exists_p): Sync doc string and
205 argument list with xselect.c. (Bug#10783)
206
207 2012-02-10 Glenn Morris <rgm@gnu.org>
208
209 * fns.c (Fsecure_hash): Doc fix.
210
211 2012-02-09 Kenichi Handa <handa@m17n.org>
212
213 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
214
215 2012-02-07 Chong Yidong <cyd@gnu.org>
216
217 * buffer.c (Fbuffer_local_variables)
218 (buffer_lisp_local_variables): Handle unbound vars correctly;
219 don't let Qunbound leak into Lisp.
220
221 2012-02-07 Glenn Morris <rgm@gnu.org>
222
223 * image.c (Fimagemagick_types): Doc fix.
224
225 * image.c (imagemagick-render-type): Change it from a lisp object
226 to an integer. Move the doc here from the lisp manual.
227 Treat all values not equal to 0 the same.
228
229 2012-02-06 Chong Yidong <cyd@gnu.org>
230
231 * doc.c (store_function_docstring): Avoid applying docstring of
232 alias to base function (Bug#2603).
233
234 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
235
236 * .gdbinit (pp1, pv1): Remove redundant defines.
237 (pr): Use pp.
238
239 2012-02-04 Chong Yidong <cyd@gnu.org>
240
241 * nsterm.m: Declare a global (Bug#10694).
242
243 2012-02-04 Eli Zaretskii <eliz@gnu.org>
244
245 * w32.c (get_emacs_configuration_options):
246 Include --enable-checking, if specified, in the return value.
247
248 2012-02-04 Martin Rudalics <rudalics@gmx.at>
249
250 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
251 after rounding frame sizes. (Bug#9723)
252
253 2012-02-04 Eli Zaretskii <eliz@gnu.org>
254
255 * keyboard.c (adjust_point_for_property): Don't position point
256 before BEGV. (Bug#10696)
257
258 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
259
260 Handle overflow when computing char display width (Bug#9496).
261 * character.c (char_width): Return EMACS_INT, not int.
262 (char_width, c_string_width): Check for overflow when
263 computing the width; this is possible now that individual
264 characters can have unbounded width. Problem introduced
265 by merge from Emacs 23 on 2012-01-19.
266
267 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
268
269 * dbusbind.c (Fdbus_register_method): Mention the return value
270 :ignore in the docstring.
271
272 2012-02-02 Glenn Morris <rgm@gnu.org>
273
274 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
275
276 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
277 Unconditionally set to t. (Bug#10673)
278 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
279 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
280 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
281
282 2012-02-02 Kenichi Handa <handa@m17n.org>
283
284 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
285 0, do not call append_composite_glyph.
286
287 2012-02-02 Kenichi Handa <handa@m17n.org>
288
289 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
290 NULL (Bug#6988).
291 (x_produce_glyphs): If the component of a composition is a null
292 string, set it->pixel_width to 1 to avoid zero-width glyph.
293
294 2012-02-01 Eli Zaretskii <eliz@gnu.org>
295
296 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
297 first 2 arguments are identical. This makes inserting large
298 output from a subprocess an order of magnitude faster on
299 MS-Windows, where all sbrk'ed memory is always contiguous.
300
301 2012-01-31 Glenn Morris <rgm@gnu.org>
302
303 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
304 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
305 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
306
307 2012-01-29 Glenn Morris <rgm@gnu.org>
308
309 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
310
311 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
312
313 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
314
315 2012-01-28 Chong Yidong <cyd@gnu.org>
316
317 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
318
319 2012-01-26 Chong Yidong <cyd@gnu.org>
320
321 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
322
323 * search.c (Fsearch_forward, Fsearch_backward): Document negative
324 repeat counts (Bug#10507).
325
326 2012-01-26 Glenn Morris <rgm@gnu.org>
327
328 * lread.c (syms_of_lread): Doc fix.
329
330 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
331
332 * coding.c (encode_designation_at_bol): Change return value to
333 EMACS_INT.
334
335 2012-01-25 Chong Yidong <cyd@gnu.org>
336
337 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
338
339 2012-01-21 Chong Yidong <cyd@gnu.org>
340
341 * floatfns.c (Fcopysign): Make the second argument non-optional,
342 since nil is not allowed anyway.
343
344 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
345
346 * process.c (read_process_output): Use p instead of XPROCESS (proc).
347 (send_process): Likewise.
348
349 2012-01-19 Martin Rudalics <rudalics@gmx.at>
350
351 * window.c (save_window_save, Fcurrent_window_configuration)
352 (Vwindow_persistent_parameters): Do not use Qstate.
353 Rewrite doc-strings.
354
355 2012-01-19 Kenichi Handa <handa@m17n.org>
356
357 * character.c (char_width): New function.
358 (Fchar_width, c_string_width, lisp_string_width):
359 Use char_width (Bug#9496).
360
361 2012-01-16 Martin Rudalics <rudalics@gmx.at>
362
363 * window.c (Vwindow_persistent_parameters): New variable.
364 (Fset_window_configuration, save_window_save): Handle persistent
365 window parameters.
366
367 2012-01-14 Eli Zaretskii <eliz@gnu.org>
368
369 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
370 thrashing the stack of the thread. (Bug#9087)
371
372 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
373
374 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
375
376 2012-01-11 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (rows_from_pos_range): Handle the case where the
379 highlight ends on a newline. (Bug#10464)
380 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
381 he end column for display of highlight that ends on a newline
382 before a R2L line.
383
384 2012-01-11 Glenn Morris <rgm@gnu.org>
385
386 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
387 from load-path also when installation-directory is nil. (Bug#10208)
388
389 2012-01-10 Glenn Morris <rgm@gnu.org>
390
391 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
392
393 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
394 Update template values to be closer to their typical values these days.
395
396 2012-01-09 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (rows_from_pos_range): Accept additional argument
399 DISP_STRING, and accept any glyph in a row whose object is that
400 string as eligible for mouse highlight. Fixes mouse highlight of
401 display strings from overlays. (Bug#10464)
402
403 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
404
405 emacs: fix an auto-save permissions race condition (Bug#10400)
406 * fileio.c (auto_saving_dir_umask): New static var.
407 (Fmake_directory_internal): Use it.
408 (do_auto_save_make_dir): Set it, instead of invoking chmod after
409 creating the directory. The old code temporarily assigns
410 too-generous permissions to the directory.
411 (do_auto_save_eh): Clear it.
412 (Fdo_auto_save): Catch all errors, not just file errors, so
413 that the var is always cleared.
414
415 2012-01-07 Eli Zaretskii <eliz@gnu.org>
416
417 * search.c (scan_buffer): Pass character positions to
418 know_region_cache, not byte positions. (Bug#6540)
419
420 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
421
422 * w32.c (sys_rename): Report EXDEV when rename of a directory
423 fails because the target is on another logical disk. (Bug#10284)
424
425 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
426
427 * xterm.c (x_embed_request_focus): New function.
428
429 * xterm.h: Add prototype.
430
431 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
432
433 2012-01-05 Glenn Morris <rgm@gnu.org>
434
435 * emacs.c (emacs_copyright): Update short copyright year to 2012.
436
437 2012-01-01 Eli Zaretskii <eliz@gnu.org>
438
439 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
440 Load gnutls_transport_set_lowat only if GnuTLS version is below
441 2.11.1.
442 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
443 GnuTLS versions below 2.11.1.
444
445 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
446
447 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
448 to the doc string advising against its use for altering the way
449 windows are scrolled.
450
451 2011-12-28 Kenichi Handa <handa@m17n.org>
452
453 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
454 coding-system ASCII compatible only when it does not produce BOM
455 on encoding (Bug#10383).
456
457 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
458
459 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
460 can scroll.
461 (create_and_show_popup_menu): Always use menu_position_func for
462 Gtk3 (Bug#10361).
463
464 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
465
466 * callint.c (Fcall_interactively): Don't truncate prompt string.
467
468 2011-12-23 Eli Zaretskii <eliz@gnu.org>
469
470 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
471 property that ends at ZV, so that the bidi iteration could be
472 resumed from there (after widening). (Bug#10360)
473
474 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
475
476 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
477
478 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
479
480 * nsterm.m (x_free_frame_resources):
481 Release f->output_data.ns->miniimage.
482 (ns_index_color): Fix indentation. Do not retain
483 color_table->colors[i].
484
485 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
486 before returning.
487
488 * nsfns.m (x_set_background_color): Assign return value from
489 ns_index_color to face-background instead of NSColor*.
490 (ns_implicitly_set_icon_type): Fix indentation.
491 Change assignment in for loop to comparison.
492
493 * emacs.c (ns_pool): New variable.
494 (main): Assign ns_pool.
495 (Fkill_emacs): Call ns_release_autorelease_pool.
496
497 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
498 autorelease fdesc, release fdAttrs and tdict.
499 (ns_get_covering_families): Release charset.
500 (ns_findfonts): Release NSFontDescriptor created with new.
501 (ns_uni_to_glyphs): Fix indentation.
502 (setString): Release attrStr before assigning new value.
503
504 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
505
506 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
507 and NS_IMPL_COCOA.
508 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
509 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
510
511 2011-12-18 David Reitter <reitter@cmu.edu>
512
513 * nsterm.m (ns_term_init): Subscribe for notifications
514 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
515 to method trackingNotification in EmacsMenu.
516
517 * nsmenu.m (trackingMenu): New variable.
518 (trackingNotification): New method (from Aquamacs).
519 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
520 from Aquamacs (Bug#7030).
521
522 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
523
524 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
525 (symbol_to_nsstring): Fix indentation.
526 (ns_symbol_to_pb): New function.
527 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
528 (Fns_rotate_cut_buffers_internal): Remove.
529 (Fns_store_selection_internal): Rename from
530 Fns_store_cut_buffer_internal.
531 (ns_get_foreign_selection, Fx_own_selection_internal)
532 (Fx_disown_selection_internal, Fx_selection_exists_p)
533 (Fns_get_selection_internal, Fns_store_selection_internal):
534 Use ns_symbol_to_pb and check if return value is nil.
535 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
536 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
537 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
538 renamed to Sns_store_selection_internal.
539 (ns_handle_selection_request): Move code to Fx_own_selection_internal
540 and remove this function.
541 (ns_handle_selection_clear): Remove, never used.
542 (Fx_own_selection_internal): Move code from ns_handle_selection_request
543 here.
544
545 2011-12-17 Ken Brown <kbrown@cornell.edu>
546
547 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
548 GID is unknown (Bug#10257).
549
550 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
551
552 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
553 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
554 which caused a build failure on GNU/Linux IA-64. This problem was
555 introduced by my 2011-10-07 patch.
556
557 2011-12-15 Juri Linkov <juri@jurta.org>
558
559 * image.c (imagemagick_error): New function. (Bug#10112)
560 (imagemagick_load_image): Comment out `MagickSetResolution' call.
561 Use `imagemagick_error' where ImageMagick functions return
562 `MagickFalse'.
563 (Fimagemagick_types): Add `Fnreverse' to return the list in the
564 proper order.
565
566 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
567
568 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
569 fill background (Bug#8992).
570
571 2011-12-13 Martin Rudalics <rudalics@gmx.at>
572
573 * window.c (Vwindow_combination_resize)
574 (Vwindow_combination_limit): Use t instead of non-nil in
575 doc-strings.
576 (Vrecenter_redisplay): Add first sentence of doc-string on
577 separate line.
578 (Frecenter): Fix doc-string typo.
579
580 2011-12-11 Kenichi Handa <handa@m17n.org>
581
582 * coding.c (Funencodable_char_position): Pay attention to the
583 buffer text relocation (Bug#9389).
584
585 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
586
587 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
588 gtk_init (Bug#10100).
589
590 2011-12-10 Eli Zaretskii <eliz@gnu.org>
591
592 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
593 IT->string is nil. (Bug#10263)
594
595 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
596
597 * nsterm.h (x_free_frame_resources): Declare.
598
599 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
600 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
601
602 * nsterm.h (ns_get_defaults_value): Declare.
603
604 * nsterm.m (ns_default): Call ns_get_defaults_value.
605
606 2011-12-09 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
609 (Bug#10170)
610
611 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
612
613 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
614 that where the value of an _OBJC_* symbol points to is in the .bss
615 section (Bug#10240).
616
617 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
618
619 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
620 after the loop to call ccl_driver at least once (Bug#8619).
621
622 2011-12-08 Kenichi Handa <handa@m17n.org>
623
624 * ftfont.c (get_adstyle_property): Fix previous change
625 (Bug#10233).
626
627 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
628
629 * w32.c (init_environment): If no_site_lisp, remove site-lisp
630 dirs from the default value of EMACSLOADPATH (bug#10208).
631
632 2011-12-07 Glenn Morris <rgm@gnu.org>
633
634 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
635 installation and source directories as well. (Bug#10208)
636
637 2011-12-06 Chong Yidong <cyd@gnu.org>
638
639 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
640
641 2011-12-06 Glenn Morris <rgm@gnu.org>
642
643 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
644 as an error, not just -1. (Bug#10217)
645
646 2011-12-05 Chong Yidong <cyd@gnu.org>
647
648 * keyboard.c (process_special_events): New function.
649 (swallow_events, Finput_pending_p): Use it (Bug#10195).
650
651 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
652
653 * coding.c (encode_designation_at_bol): Don't use uninitialized
654 local variable (Bug#9318).
655
656 2011-12-05 Kenichi Handa <handa@m17n.org>
657
658 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
659 return Qnil (Bug#8046, Bug#10193).
660
661 2011-12-05 Kenichi Handa <handa@m17n.org>
662
663 * coding.c (encode_designation_at_bol): New args charbuf_end and
664 dst. Return the number of produced bytes. Callers changed.
665 (coding_set_source): Return how many bytes coding->source was
666 relocated.
667 (coding_set_destination): Return how many bytes
668 coding->destination was relocated.
669 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
670 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
671
672 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
673
674 * coding.c (CODING_CHAR_CHARSET_P): New macro.
675 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
676 macro (Bug#9318).
677
678 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
679
680 The following changes are to fix Bug#9318.
681
682 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
683 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
684 (encode_coding_iso_2022, encode_coding_sjis)
685 (encode_coding_big5, encode_coding_charset): Use the above macros.
686
687 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
688
689 * lisp.h (process_quit_flag): Fix external declaration.
690
691 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
692
693 Don't macro-inline non-performance-critical code.
694 * eval.c (process_quit_flag): New function.
695 * lisp.h (QUIT): Use it.
696
697 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
698
699 * nsfns.m (get_geometry_from_preferences): New function.
700 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
701
702 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
703
704 * emacs.c (Qkill_emacs): Define.
705 (syms_of_emacs): Initialize it.
706 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
707 Qquit_flag to `kill-emacs' instead.
708 (quit_throw_to_read_char): Add parameter `from_signal'.
709 All callers changed. Call Fkill_emacs if requested and safe.
710 * lisp.h (QUIT): Call Fkill_emacs if requested.
711
712 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
713
714 * widget.c (update_wm_hints): Return if wmshell is null.
715 (widget_update_wm_size_hints): New function.
716
717 * widget.h (widget_update_wm_size_hints): Declare.
718
719 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
720 widget_update_wm_size_hints (Bug#10104).
721
722 2011-12-03 Eli Zaretskii <eliz@gnu.org>
723
724 * xdisp.c (handle_invisible_prop): If the invisible text ends just
725 before a newline, prepare the bidi iterator for consuming the
726 newline, and keep the current paragraph direction. (Bug#10183)
727 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
728
729 2011-12-02 Juri Linkov <juri@jurta.org>
730
731 * search.c (Fword_search_regexp): New Lisp function created from
732 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
733 (Fword_search_backward, Fword_search_forward)
734 (Fword_search_backward_lax, Fword_search_forward_lax):
735 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
736 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
737
738 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
739
740 * fileio.c (Finsert_file_contents): Move after-change-function call
741 to before the "handled:" label, since all "goto handled" appear in
742 cases where the *-change-functions have already been properly called
743 (bug#10117).
744
745 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
746
747 * keyboard.c (interrupt_signal): Don't call kill-emacs when
748 waiting for input. (Bug#10169)
749
750 2011-11-30 Eli Zaretskii <eliz@gnu.org>
751
752 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
753 verifies glyph row's hash code--we have just reallocated the
754 glyphs, so their contents can be complete garbage. (Bug#10164)
755
756 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
757
758 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
759
760 2011-11-30 Eli Zaretskii <eliz@gnu.org>
761
762 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
763 attributes are tested _before_ calling verify_row_hash, to protect
764 against GCC re-ordering of the tests. (Bug#10164)
765
766 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
767
768 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
769
770 * xterm.c (handle_one_xevent): Only set async_visible and friends
771 if net_wm_state_hidden_seen is non-zero (Bug#10002)
772 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
773 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
774
775 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
776
777 Remove GCPRO-related macros that exist only to avoid shadowing locals.
778 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
779 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
780 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
781 All uses changed to use GCPRO1 etc.
782 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
783 Revert to old implementation (i.e., before 2011-03-11).
784
785 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
786
787 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
788 of scroll runs so as to avoid assigning disabled bogus rows and
789 unnecessary graphics copy operations.
790
791 2011-11-27 Eli Zaretskii <eliz@gnu.org>
792
793 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
794 (snprintf) [_MSC_VER]: Redirect to _snprintf.
795 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
796 (malloc, free, realloc, calloc): Redirect to e_* only when
797 compiling Emacs.
798
799 * lisp.h (GCTYPEBITS): Move before first use.
800 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
801 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
802 this macro definition.
803
804 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
805 _MSC_VER.
806
807 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
808
809 * gtkutil.c (xg_create_frame_widgets):
810 Call gtk_window_set_has_resize_grip (FALSE) if that function is
811 present with Gtk+ 2.0.
812
813 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
814
815 * fileio.c (Finsert_file_contents): Undo previous change; see
816 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
817
818 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
819
820 Rename locals to avoid shadowing.
821 * fileio.c (Finsert_file_contents):
822 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
823 * process.c (wait_reading_process_output):
824 Rename inner 'proc' to 'p' to avoid shadowing.
825 Indent for consistency with usual Emacs style.
826
827 2011-11-25 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (redisplay_window): If cursor row is not fully visible
830 after recentering, and scroll-conservatively is set to a large
831 number, scroll window by a few more lines to make the cursor fully
832 visible and out of scroll-margin. (Bug#10105)
833 (start_display): Don't move to the next line if the display should
834 start at a newline that is part of a display vector or an overlay
835 string. (Bug#10119)
836
837 2011-11-24 Juri Linkov <juri@jurta.org>
838
839 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
840 after the `MagickPingImage' call. (Bug#10112)
841
842 2011-11-23 Chong Yidong <cyd@gnu.org>
843
844 * window.c (Fcoordinates_in_window_p): Accept only live windows.
845
846 2011-11-23 Martin Rudalics <rudalics@gmx.at>
847
848 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
849 making another buffer current. (Bug#10114)
850
851 2011-11-23 Glenn Morris <rgm@gnu.org>
852
853 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
854
855 2011-11-23 Chong Yidong <cyd@gnu.org>
856
857 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
858 using it (Bug#5984).
859
860 2011-11-22 Eli Zaretskii <eliz@gnu.org>
861
862 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
863 and header-lines, as they don't have one computed for them.
864 (Bug#10098)
865
866 * .gdbinit (prow): Make displayed values more self-explaining.
867 Add row's hash code.
868
869 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
870
871 * process.c (wait_reading_process_output): Fix asynchrounous
872 GnuTLS socket handling on some versions of the GnuTLS library.
873 (wait_reading_process_output): Add comment and URL.
874
875 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
876
877 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
878
879 2011-11-21 Chong Yidong <cyd@gnu.org>
880
881 * window.c (Fnext_window, Fprevious_window): Doc fix.
882
883 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
884
885 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
886
887 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
888
889 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
890
891 2011-11-20 Martin Rudalics <rudalics@gmx.at>
892
893 * window.c (Fset_window_combination_limit): Rename argument
894 STATUS to LIMIT.
895 (Vwindow_combination_limit): Remove "status" from doc-string.
896
897 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
898
899 * m/ibms390.h: Remove.
900 * m/ibms390x.h: Don't include "ibms390.h".
901
902 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
903
904 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
905 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
906
907 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
908
909 * casetab.c (Fset_case_table):
910 * charset.c (Fcharset_after): Fix typos.
911
912 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
913
914 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
915 Otherwise, valgrind does not work on some platforms.
916 Problem reported by Andreas Schwab in
917 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
918 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
919 is set, removing the need for VIRT_ADDRESS_VARIES.
920 (PURE_P): Use a more-efficient implementation that needs just one
921 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
922 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
923 to 4 (xorl, subq, cmpq, setbe).
924 * alloc.c (pure): Always extern now, since that's the
925 VIRT_ADDR_VARIES behavior.
926 (PURE_POINTER_P): Use a single comparison, not two, for
927 consistency with the new puresize.h.
928 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
929 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
930 Remove VIRT_ADDR_VARIES no longer needed.
931
932 2011-11-19 Eli Zaretskii <eliz@gnu.org>
933
934 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
935 (erase_phys_cursor, update_window_cursor, show_mouse_face)
936 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
937 behave as if the cursor position were at the window margin.
938
939 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
940 and the cursor position is out of bounds, behave as if the cursor
941 position were at the window margin. (Bug#10075)
942
943 2011-11-18 Chong Yidong <cyd@gnu.org>
944
945 * window.c (Fwindow_combination_limit): Make first argument
946 non-optional, since it is meaningless for live windows like the
947 selected window.
948
949 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
950
951 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
952
953 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
954
955 * intervals.c: Fix grafting over the whole buffer (bug#10071).
956 (graft_intervals_into_buffer): Simplify.
957
958 2011-11-18 Eli Zaretskii <eliz@gnu.org>
959
960 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
961 hash values of the two rows.
962 (copy_row_except_pointers): Preserve the used[] arrays and the
963 hash values of the two rows. (Bug#10035)
964 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
965
966 * xdisp.c (row_hash): New function, body extracted from
967 compute_line_metrics.
968 (compute_line_metrics): Call row_hash, instead of computing the
969 hash code inline.
970
971 * dispnew.c (verify_row_hash): Call row_hash for computing the
972 hash code of a row, instead of duplicating code from xdisp.c.
973
974 * dispextern.h (row_hash): Add prototype.
975
976 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
977
978 * frame.c (delete_frame): Don't delete the terminal when the last
979 X frame is closed if emacs is built with GTK toolkit.
980
981 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
982
983 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
984
985 2011-11-17 Martin Rudalics <rudalics@gmx.at>
986
987 * window.c (Vwindow_splits): Rename to
988 Vwindow_combination_resize. Suggested by Juri Linkov.
989 (Fsplit_window_internal): Use Vwindow_combination_resize instead
990 of Vwindow_splits.
991
992 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
993
994 * nsfns.m (Fns_font_name):
995 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
996
997 2011-11-16 Martin Rudalics <rudalics@gmx.at>
998
999 * window.h (window): Rename slot "nest" to "combination_limit".
1000 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1001 (Fset_window_nest): Rename to Fset_window_combination_limit.
1002 (Vwindow_nest): Rename to Vwindow_combination_limit.
1003 (recombine_windows, make_parent_window, make_window)
1004 (Fsplit_window_internal, saved_window)
1005 (Fset_window_configuration, save_window_save): Rename all
1006 occurrences of window_nest to window_combination_limit.
1007
1008 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1009
1010 * image.c (imagemagick_load_image): Fix typo.
1011
1012 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1013
1014 * xdisp.c (display_line): Move the call to
1015 highlight_trailing_whitespace before the call to
1016 compute_line_metrics, since the latter needs to see the final
1017 faces of all the glyphs to compute ROW's hash value.
1018 Fixes assertion violations in row_equal_p. (Bug#10035)
1019
1020 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1021
1022 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1023 just return (bug#10044).
1024
1025 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1026
1027 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1028 with user-defined heap size. Bump the default size of the temacs
1029 heap to 27MB, to avoid memory warning when running temacs.
1030 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1031
1032 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1033 current_matrix and desired_matrix. (Bug#9990)
1034 (verify_row_hash) [XASSERTS]: New function.
1035 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1036 that the hash value of glyph rows is correct.
1037
1038 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1039
1040 * window.h (window): Remove splits slot.
1041 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1042 (Fdelete_other_windows_internal, make_parent_window)
1043 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1044 (Fset_window_configuration, save_window_save): Don't deal with
1045 split status of windows.
1046 (saved_window): Remove splits slot.
1047 (Vwindow_splits): Rewrite doc-string.
1048
1049 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1050
1051 * xfns.c (unwind_create_frame):
1052 * nsfns.m (unwind_create_frame):
1053 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1054 Vframe_list (Bug#9999).
1055
1056 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1057
1058 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1059
1060 2011-11-11 Kenichi Handa <handa@m17n.org>
1061
1062 * callproc.c (Fcall_process): Set the member dst_multibyte of
1063 process_coding.
1064
1065 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1066
1067 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1068 avoid a crash (bug#9496).
1069
1070 2011-11-09 Chong Yidong <cyd@gnu.org>
1071
1072 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1073 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1074
1075 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1078
1079 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Avoid some portability problems by eschewing 'extern inline' functions.
1082 The trivial performance wins aren't worth the portability hassles; see
1083 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1084 et seq.
1085 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1086 (window_box_width, window_box_left, window_box_left_offset)
1087 (window_box_right, window_box_right_offset): Undo previous change,
1088 by removing the "extern"s.
1089 * intervals.c (adjust_intervals_for_insertion)
1090 (adjust_intervals_for_deletion): Undo previous change,
1091 making these static again.
1092 (offset_intervals, temp_set_point_both, temp_set_point)
1093 (copy_intervals_to_string): No longer inline.
1094 * xdisp.c (window_text_bottom_y, window_box_width)
1095 (window_box_height, window_box_left_offset)
1096 (window_box_right_offset, window_box_left, window_box_right)
1097 (window_box): No longer inline.
1098
1099 2011-11-08 Chong Yidong <cyd@gnu.org>
1100
1101 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1102 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1103 Signal an error if not a live window.
1104 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1105 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1106
1107 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1108
1109 * lisp.h (syms_of_abbrev): Remove declaration.
1110 Reported by CHENG Gao <chenggao@royau.me>.
1111
1112 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1113
1114 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1115 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1116 of temacs in GUI mode.
1117
1118 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1119
1120 * window.h: Declare delete_all_child_windows instead of
1121 delete_all_subwindows.
1122 * window.c (Fwindow_nest, Fset_window_nest)
1123 (Fset_window_new_total, Fset_window_new_normal)
1124 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1125 (delete_all_subwindows): Rename to delete_all_child_windows.
1126 (Fdelete_other_windows_internal, Fset_window_configuration):
1127 Call delete_all_child_windows instead of delete_all_subwindows.
1128 * frame.c (delete_frame): Call delete_all_child_windows instead
1129 of delete_all_subwindows.
1130
1131 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1134 This is also needed for porting to any host where GC_MARK_STACK is
1135 not GC_MAKE_GCPROS_NOOPS.
1136 (which_symbols): Use it.
1137
1138 2011-11-07 Kenichi Handa <handa@m17n.org>
1139
1140 * coding.c (coding_set_destination): Check coding->src_pos only
1141 when coding->src_object is a buffer (bug#9910).
1142
1143 * process.c (send_process): Set the member src_multibyte of coding
1144 to 0 (bug#9911) when sending a unibyte text.
1145
1146 * callproc.c (Fcall_process): Set the member src_multibyte of
1147 process_coding to 0 (bug#9912).
1148
1149 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1150
1151 * xmenu.c (cleanup_widget_value_tree): New function.
1152 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1153 calling free_menubar_widget_value_tree directly (Bug#9830).
1154
1155 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 Fix some portability problems with 'inline'.
1158 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1159 (window_box_width, window_box_left, window_box_left_offset)
1160 (window_box_right, window_box_right_offset): Declare extern.
1161 Otherwise, these inline functions do not conform to C99 and
1162 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1163 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1164 * intervals.c (adjust_intervals_for_insertion)
1165 (adjust_intervals_for_deletion): Now extern, because otherwise the
1166 extern inline functions 'offset_intervals' couldn't refer to it.
1167 (static_offset_intervals): Remove.
1168 (offset_intervals): Rewrite using the old contents of
1169 static_offset_intervals. The old version didn't conform to C99
1170 because an extern inline function contained a reference to an
1171 identifier with static linkage.
1172
1173 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1174
1175 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1176 GC.
1177
1178 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1179
1180 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1181 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1182 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1183 return Qleft_to_right.
1184
1185 2011-11-06 Chong Yidong <cyd@gnu.org>
1186
1187 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1188 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1189 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1190 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1191 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1192 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1193 (Fwindow_vscroll): Doc fix.
1194 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1195 argument, since it makes no sense to pass a live window and for
1196 consistency with window-child.
1197
1198 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1199
1200 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1201 support MSVC.
1202
1203 2011-11-05 Jason Rumney <jasonr@gnu.org>
1204
1205 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1206 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1207 fonts (Bug#6029).
1208 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1209 bitwise arithmetic preventing use of unicode-sip and non-truetype
1210 opentype fonts.
1211
1212 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1213
1214 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1215 "emacs"-only part.
1216
1217 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1218 initialization code to keep similarity to xfns.c after changes
1219 from 2011-11-05.
1220
1221 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1222
1223 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1224 (unwind_create_frame): New function (Bug#9943).
1225 (Fx_create_frame): Restructure code to be more similar to the one in
1226 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1227 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1228 Move terminal->reference_count++ just before making the frame official
1229 (Bug#9943).
1230
1231 * nsterm.m (x_free_frame_resources): New function.
1232 (x_destroy_window): Move code to x_free_frame_resources.
1233
1234 * xfns.c (unwind_create_frame): Fix comment.
1235 (Fx_create_frame, x_create_tip_frame):
1236 Move terminal->reference_count++ just before making the frame
1237 official. Move initialization of image_cache_refcount and
1238 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1239
1240 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1241
1242 Support MSVC build with newer versions of Visual Studio.
1243 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1244 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1245 nt/gmake.defs.
1246
1247 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1248 which are not supported by MSVC.
1249 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1250 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1251 bitfields.
1252 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1253 types in bitfields.
1254 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1255
1256 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1257
1258 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1259
1260 Support MSVC build with newer versions of Visual Studio.
1261 * w32.c: Don't include w32api.h for MSVC.
1262 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1263
1264 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1265 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1266 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1267 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1268 e_* cousins.
1269 (alloca) [_MSC_VER]: Define to _alloca.
1270
1271 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1272
1273 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1274
1275 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1276
1277 * xdisp.c (note_mouse_highlight): If either of
1278 previous/next-single-property-change returns nil, treat that as
1279 the beginning or the end of the buffer. (Bug#9955)
1280
1281 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1282
1283 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1284 label is not null (Bug#9951).
1285 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1286 may be NULL.
1287
1288 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1289
1290 * window.c (Fwindow_body_size): Mention in the doc string that the
1291 return value is in frame's canonical units. (Bug#9949)
1292
1293 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1294
1295 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1296
1297 * w32fns.c (unwind_create_frame): If needed, free the glyph
1298 matrices of the partially constructed frame. (Bug#9943)
1299 * xfns.c (unwind_create_frame): Likewise.
1300
1301 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1302
1303 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1304 Don't stop backward scan on the continuation glyph, even though
1305 its CHARPOS is positive.
1306 (mouse_face_from_buffer_pos, note_mouse_highlight):
1307 Rename cover_string to disp_string.
1308
1309 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1310
1311 * window.c (temp_output_buffer_show): Don't use
1312 Vtemp_buffer_show_specifiers.
1313 (Vtemp_buffer_show_specifiers): Remove unused variable.
1314
1315 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1316
1317 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1318 past the beginning of the current glyph matrix.
1319
1320 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1321
1322 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1323 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1324 HAVE_GTK3 (Bug#9869).
1325
1326 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1327 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1328
1329 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1330
1331 * xterm.c: Declare x_handle_net_wm_state to return int.
1332 (handle_one_xevent): Check if we are iconified but don't have
1333 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1334 (get_current_wm_state): Return non-zero if not hidden,
1335 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1336 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1337 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1338 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1339
1340 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1343 so that this new function doesn't get optimized away by a
1344 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1345
1346 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1347
1348 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1349
1350 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1351
1352 Fix the `xbytecode' command.
1353 * .gdbinit (xprintbytestr): New command.
1354 (xwhichsymbols): Rename from `which'; all callers changed.
1355 (xbytecode): Print the byte-code string as well.
1356
1357 2011-10-29 Kim Storm <storm@cua.dk>
1358
1359 * alloc.c (which_symbols): New function.
1360
1361 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1362
1363 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1364 line. (Bug#9903)
1365
1366 2011-10-29 Glenn Morris <rgm@gnu.org>
1367
1368 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1369 Not clear what it was for, and it causes various bugs. (Bug#9839)
1370
1371 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1374 possible random value that matches one of those tested as
1375 condition to clear the mouse face.
1376
1377 2011-10-28 Chong Yidong <cyd@gnu.org>
1378
1379 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1380
1381 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1382
1383 * window.c (make_window): Initialize phys_cursor_on_p.
1384
1385 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1386
1387 * lisp.h (struct Lisp_Symbol): Update comments.
1388
1389 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1390
1391 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1392
1393 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1394
1395 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1396 <oslsachem@gmail.com> for helping to debug this.
1397
1398 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1399 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1400 (g_b_init_get_glyph_outline_w): New static variables.
1401 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1402 (GetGlyphOutlineW_Proc): New typedefs.
1403 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1404 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1405 New functions.
1406 (w32font_open_internal, compute_metrics):
1407 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1408 instead of calling the "wide" APIs directly.
1409
1410 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1411
1412 * w32.h (syms_of_w32font): Add prototype.
1413
1414 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1415
1416 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1417 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1418 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1419 (Fmove_to_window_line): Doc fix.
1420
1421 2011-10-27 Chong Yidong <cyd@gnu.org>
1422
1423 * process.c (make_process): Set gnutls_state to NULL.
1424
1425 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1426 non-NULL, regardless of GNUTLS_INITSTAGE.
1427 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1428 an error. Set process slots as soon as we allocate them.
1429
1430 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1431
1432 2011-10-27 Chong Yidong <cyd@gnu.org>
1433
1434 * gnutls.c (emacs_gnutls_deinit): New function.
1435 Deallocate credentials structures as well as calling gnutls_deinit.
1436 (Fgnutls_deinit, Fgnutls_boot): Use it.
1437
1438 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1439 (deactivate_process): Call emacs_gnutls_deinit.
1440
1441 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * image.c (x_create_x_image_and_pixmap):
1444 * w32.c (sys_rename, w32_delayed_load):
1445 * w32font.c (fill_in_logfont):
1446 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1447
1448 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1449
1450 * w32fns.c (w32_default_color_map): New function,
1451 extracted from Fw32_default_color_map.
1452 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1453
1454 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1457
1458 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1459
1460 * keyboard.c (test_undefined): New function (bug#9751).
1461 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1462
1463 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1464
1465 * sysdep.c (init_sys_modes): Fix the check for the controlling
1466 terminal (Bug#6649).
1467
1468 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1469
1470 * dispextern.h (struct bidi_it): New member next_en_type.
1471
1472 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1473 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1474 current character, check also for next_en_type being WEAK_EN.
1475 (bidi_resolve_weak): Don't enter the expensive loop if the current
1476 position is before next_en_pos. Record the bidi type of the first
1477 non-ET, non-BN character we find, in addition to its position.
1478 (bidi_level_of_next_char): Invalidate next_en_type when
1479 next_en_pos is over-stepped.
1480
1481 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1484 * editfns.c: Rewrite current-time-zone so that it invokes
1485 the equivalent of (format-time-string "%Z") to get the time zone name.
1486 This fixes a bug when the time zone name contains characters that
1487 need converting from the system time locale to Emacs internal format.
1488 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1489 that patch fixed format-time-string to do the conversion, but
1490 I forgot to fix current-time-zone.
1491 (format_time_string): New function, containing most of
1492 what Fformat_time_string used to contain.
1493 (Fformat_time_string): Rewrite in terms of format_time_string.
1494 This doesn't change this function's behavior.
1495 (current-time-zone): Rewrite to use format_time_string.
1496 This fixes the bug reported by Michael Schierl in
1497 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1498 Jason Rumney's 2007-06-07 change worked around this bug, but
1499 didn't fix it.
1500 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1501
1502 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1503
1504 * xdisp.c (start_display): If the character at POS is displayed
1505 via a display vector, reset IT->current.dpvec_index to zero.
1506 (try_window_reusing_current_matrix): If a line ends in a display
1507 vector or the next line starts in a display vector, continue
1508 redrawing the window even though the character position of
1509 start_row was reached.
1510 (Bug#9771, part 2)
1511
1512 2011-10-18 Chong Yidong <cyd@gnu.org>
1513
1514 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1515 with nobreak-char-display too.
1516
1517 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1518
1519 Fix part 3 of bug#9771.
1520 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1521 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1522 non-neutral characters if the current character is a paragraph
1523 separator (a.k.a. Newline). This avoids running the same
1524 expensive loop twice, once when we consume the preceding newline
1525 and the other time when the line actually needs to be displayed.
1526 Avoid the loop when we see neutrals on the base embedding level
1527 following a character whose directionality is the same as the
1528 paragraph's. This avoids running the expensive loop when a line
1529 ends in a long sequence of neutrals, like control characters.
1530 Add assertion against STRONG_AL type. Slightly rearrange code
1531 that determines the type of a neutral given the first non-neutral
1532 that follows it.
1533 (bidi_level_of_next_char): Set next_en_pos to zero when
1534 invalidating its info.
1535
1536 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xdisp.c (push_display_prop): Determine whether to record string
1539 or buffer position by IT->string, not by IT->method. Allow
1540 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1541 (move_it_vertically_backward): Don't look for character position
1542 immediately after the newline when in a continuation line.
1543 (Bug#9771, part 1)
1544
1545 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1546
1547 * window.c (coordinates_in_window): Rewrite and delabelize
1548 vertical border check. (Bug#5357) (Bug#9618)
1549
1550 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1551
1552 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1553 errors in XSetWindowBorder (bug#9310).
1554
1555 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1556
1557 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1558 avoid crash when xmalloc overrun checking is enabled.
1559
1560 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1561
1562 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1563 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1564 cursor motion with <left> and <right> arrow keys.
1565
1566 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1567 some callers set that themselves.
1568
1569 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1570
1571 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1572 display string and the previous row comes from the same string and
1573 is empty. (Bug#9739) (Bug#9738)
1574
1575 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1576
1577 * doc.c (get_doc_string): Encode file name (bug#9735).
1578
1579 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1580
1581 * bidi.c (bidi_level_of_next_char):
1582 * xdisp.c (get_visually_first_element): Remove old incorrect
1583 comments regarding the Unicode Line Separator character.
1584
1585 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1586
1587 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1588
1589 * alloc.c (Fgc_status): Do not access beyond zombies array
1590 boundary if nzombies > MAX_ZOMBIES.
1591 * alloc.c (dump_zombies): Add missing format specifier.
1592
1593 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1594
1595 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1596 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1597
1598 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1599 Some packages use them to denote characters with modifiers.
1600
1601 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1602
1603 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1604 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1605 matching a pp-number. Rename parameter var to var1.
1606
1607 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1608
1609 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1610
1611 2011-10-08 Glenn Morris <rgm@gnu.org>
1612
1613 * callint.c (Fcall_interactively): Give a more explicit error for the
1614 'c' case with a non-character input. (Bug#8479)
1615
1616 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1619 lines.
1620 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1621 lines that are hscrolled on the left.
1622
1623 * dispnew.c (buffer_posn_from_coords): Account for a possible
1624 presence of header-line. (Bug#4426)
1625
1626 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1627
1628 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1629 Don't advertise functionality which we discourage or doesn't work.
1630
1631 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1634 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1635 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1636 this makes Emacs dump core during garbage collection on rare
1637 occasions. sizeof is obviously inferior to offsetof here, so
1638 stick with offsetof.
1639 (GC_POINTER_ALIGNMENT): New macro.
1640 (mark_memory): Omit 3rd (offset) arg; caller changed.
1641 Don't assume EMACS_INT alignment is the same as pointer alignment.
1642
1643 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1644
1645 * keyboard.c (read_key_sequence_remapped): New var.
1646 (read_key_sequence): Compute remapping in the right buffer.
1647 (command_loop_1): Use read_key_sequence's remapping directly.
1648
1649 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1650
1651 * dired.c (file_name_completion): Don't expand file name.
1652 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1653 before checking file name handler.
1654
1655 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1656 they've been requested explicitly (bug#9591).
1657
1658 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1659
1660 * keymap.c (Fsingle_key_description): Use make_specified_string
1661 instead of build_string to build string from push_key_description.
1662 (Bug#5193)
1663
1664 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1667 This fixes a Y2038 bug on 64-bit hosts.
1668 * buffer.c (reset_buffer):
1669 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1670 (Fclear_buffer_auto_save_failure):
1671 Use 0, not -1, to represent an unset failure time, since time_t
1672 might not be signed.
1673
1674 Remove dependency on glibc malloc internals.
1675 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1676 Move back here from lisp.h, but with their new implementations.
1677 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1678 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1679 * charset.c (charset_table_init): New static var.
1680 (syms_of_charset): Use it instead of xmalloc. This removes a
1681 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1682 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1683 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1684 Move back to alloc.c.
1685 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1686 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1687
1688 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1689
1690 * nsterm.m (windowDidResize): Call x_set_window_size only when
1691 ns_in_resize is true. Otherwise set pixelwidth/height and
1692 call change_frame_size (Bug#9628).
1693
1694 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 Port --enable-checking=all to Fedora 14 x86-64.
1697 * charset.c (syms_of_charset): Also account for glibc malloc's
1698 internal overhead when calculating the initial malloc maximum.
1699
1700 Port --enable-checking=all to Fedora 14 x86.
1701 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1702 Move to lisp.h.
1703 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1704 (overrun_check_realloc, overrun_check_free):
1705 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1706 That way, xmalloc returns a properly-aligned pointer even if
1707 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1708 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1709 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1710 into account when calculating the initial malloc maximum.
1711 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1712 Move here from alloc.c, so that charset.c can use it too.
1713 Properly align; the old code wasn't right for common 32-bit hosts
1714 when configured with --enable-checking=all.
1715 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1716 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1717
1718 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1719
1720 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1721 use EDOM.
1722
1723 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1724
1725 * xdisp.c (compute_display_string_end): If there's no display
1726 string at CHARPOS, return -1.
1727
1728 * bidi.c (bidi_fetch_char): When compute_display_string_end
1729 returns a negative value, treat the character as a normal
1730 character not covered by a display string. (Bug#9624)
1731
1732 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1733
1734 * lread.c (Fread_from_string): Fix typo in docstring.
1735
1736 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1737
1738 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1739 newline, reseat the iterator instead of bidi-iterating there one
1740 character at a time. (Bug#9610)
1741 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1742 TO_CHARPOS if the bidi iterator is at base embedding level.
1743
1744 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1745
1746 * lread.c (readevalloop): Use correct code for NBSP.
1747 (read1): Likewise. (Bug#9608)
1748
1749 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1750
1751 * dbusbind.c (Fdbus_register_signal): When service is not
1752 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1753
1754 2011-09-25 Glenn Morris <rgm@gnu.org>
1755
1756 * buffer.c (truncate-lines): Doc fix.
1757
1758 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1759
1760 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1761 (Fset_window_next_buffers): Doc fix.
1762
1763 2011-09-24 Glenn Morris <rgm@gnu.org>
1764
1765 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1766
1767 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 Fix minor problems found by static checking.
1770 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1771 * indent.c (Fvertical_motion): Fix == vs = typo.
1772
1773 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1774
1775 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1776 Default value is now t. Doc fix.
1777
1778 * indent.c (Fvertical_motion): Compute and apply the overshoot
1779 logic when moving up, not only when moving down. Fix the
1780 confusing name and values of the it_overshoot_expected variable;
1781 logic changes accordingly. (Bug#9254) (Bug#9549)
1782
1783 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1784 CHARPOS is covered by a display string which includes newlines.
1785 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1786 is covered by a display string with embedded newlines.
1787
1788 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1789
1790 * dbusbind.c (Fdbus_register_signal): Add match rule to
1791 Vdbus_registered_objects_table. (Bug#9581)
1792 (Fdbus_register_method, Vdbus_registered_objects_table):
1793 Fix docstring.
1794
1795 2011-09-24 Jim Meyering <meyering@redhat.com>
1796
1797 do not ignore write error for any output size
1798 The previous change was incomplete.
1799 While it makes emacs --batch detect the vast majority of stdout
1800 write failures, errors were still ignored whenever the output size is
1801 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1802 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1803 && echo FAIL: ignored write error
1804 FAIL: ignored write error
1805 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1806 && echo FAIL: ignored write error
1807 FAIL: ignored write error
1808 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1809
1810 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1811
1812 * emacs.c (Fkill_emacs): In noninteractive mode exit
1813 non-successfully if a write error occurred on stdout. (Bug#9574)
1814
1815 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1818 the xassert test.
1819
1820 * dispextern.h (struct it): Update the comment documenting what
1821 can it->OBJECT be.
1822
1823 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1824
1825 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1826 a display string, extend search for cursor position to end of row.
1827 (find_row_edges): If the row ends in a newline from a display
1828 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1829 Handle the case of a display string with multiple newlines.
1830 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1831 non-empty line. Fixes confusing cursor motion with arrow keys at
1832 the beginning of a line that starts with whitespace.
1833
1834 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1835
1836 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1837 (bug#9493).
1838
1839 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1840
1841 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1842 boolean (Bug#9154).
1843
1844 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (display_line): Record maximum and minimum buffer
1847 positions even if no glyphs were produced (e.g., by a zero-width
1848 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1849 buffer positions that will be removed from the glyph row because
1850 they don't fit.
1851 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1852 column is beyond frame width: don't subtract 1 "pixel" when
1853 computing width of the stretch.
1854 (reseat_at_next_visible_line_start): Undo the change made on
1855 2011-09-17 that saved paragraph information and restored it after
1856 the call to `reseat'. (Bug#9545)
1857
1858 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1859
1860 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1861 and turn window cursor on if cleared (Bug#9415).
1862
1863 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1864
1865 * search.c (boyer_moore): Take unibyte characters from pattern
1866 literally. (Bug#9458)
1867
1868 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1869
1870 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1871
1872 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 Fix minor problem found by static checking.
1875 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1876 initialized, to pacify gcc -Wuninitialized.
1877
1878 * fileio.c: Report proper errno when syscall falls.
1879 (Finsert_file_contents): Save and restore errno,
1880 so that report_file_error outputs the correct diagnostic.
1881 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1882
1883 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1884
1885 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1886
1887 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1888
1889 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1890 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1891
1892 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1895 about the current paragraph and restore it after the call to reseat.
1896
1897 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1898 (bidi_find_paragraph_start): Search back for paragraph beginning
1899 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1900 (bidi_move_to_visually_next): Only trigger paragraph-related
1901 computations when the last character is a newline or at EOB, not
1902 just any NEUTRAL_B. (Bug#9470)
1903
1904 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1905 truncated lines if point is covered by a display string. (Bug#9524)
1906
1907 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1910 (cons_to_x_long): New function.
1911 (lisp_data_to_selection_data): Use it. Correct the test for
1912 short-versus-long data; it was negated. Break out of vector
1913 loop, for efficiency, when a long datum is discovered.
1914
1915 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1916
1917 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1918
1919 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1920
1921 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1922 GCC PR/17406) by declaring this function with external scope.
1923
1924 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1925
1926 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1927 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1928
1929 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1930
1931 * editfns.c (Fformat): Correctly handle text properties on "%%".
1932
1933 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1934
1935 * xterm.c (x_draw_composite_glyph_string_foreground):
1936 * w32term.c (x_draw_composite_glyph_string_foreground):
1937 * term.c (encode_terminal_code):
1938 * composite.c (composition_update_it, get_composition_id):
1939 * xdisp.c (get_next_display_element)
1940 (fill_composite_glyph_string): Add comments about special meaning
1941 of TAB characters in a composition.
1942
1943 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1946 This occurs when processing a multibyte format.
1947 Problem reported by Wolfgang Jenker.
1948
1949 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1950
1951 * xdisp.c (try_cursor_movement): Only check for exact match if
1952 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1953
1954 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1955
1956 Remove unused external symbols.
1957 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1958 * xdisp.c (calc_pixel_width_or_height): Now static.
1959 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1960 * indent.c (check_display_width):
1961 * w32term.c: Fix comment to match code.
1962 * xterm.c, xterm.h (x_catching_errors): Remove.
1963
1964 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * xselect.c: Use signed conversions more consistently (Bug#9498).
1967 (selection_data_to_lisp_data): Assume incoming selection data are
1968 signed integers, not unsigned. This is to be consistent with
1969 outgoing selection data, which was modified to use signed integers
1970 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1971 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1972 expects long, not unsigned long.
1973
1974 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1975
1976 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1977 computation of loop end. Reported by Johan Bockgård
1978 <bojohan@gnu.org>.
1979
1980 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1981
1982 * frame.c (Fother_visible_frames_p): Function deleted.
1983
1984 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1985
1986 * indent.c (compute_motion): Process display vector front to back
1987 rather than the other way around. (Bug#2496)
1988
1989 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1990
1991 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1992
1993 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1994
1995 * minibuf.c (Fread_from_minibuffer): Doc fix.
1996
1997 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1998
1999 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2000 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2001
2002 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2003
2004 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2005 value for non-existent files.
2006
2007 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2008
2009 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2010 set its "size" to -1. This will set the modtime_size field of
2011 the corresponding buffer to -1, which is what
2012 verify-visited-file-modtime expects for files that do not exist.
2013 (Bug#9139)
2014
2015 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2016
2017 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2018 here ...
2019 * lisp.h: ... from here. push_key_description is no longer
2020 defined in keyboard.c, so its declaration should not be in
2021 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2022 logically belongs with push_key_description.
2023
2024 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * buffer.h: Include <sys/types.h> instead of <time.h>.
2027 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2028 Problem reported by Herbert J. Skuhra.
2029
2030 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2031
2032 * xml.c (parse_region): Make the parsing work for
2033 non-comment-starting XML files again (bug#9144).
2034
2035 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2036
2037 * image.c (gif_load): Fix calculation of bottom and right corner.
2038 (Bug#9468)
2039
2040 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2041
2042 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2043 redisplay in small windows.
2044
2045 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2046
2047 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2048
2049 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2050
2051 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2052 Operate on live windows only.
2053
2054 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2055
2056 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2057
2058 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2059
2060 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2061 only under bidi iteration.
2062
2063 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2064
2065 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2066
2067 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2068
2069 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2070 Without this fix, the command to link temacs failed due to an
2071 undefined symbol __builtin_isnan. This is because
2072 /usr/include/iso/math_c99.h #defines isnan(x) to
2073 __builtin_isnan(x), but the bundled gcc, which identifies itself
2074 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2075 a __builtin_isnan.
2076 * floatfns.c (isnan): #undef, and then #define to a clone of
2077 what's in data.c.
2078 (Fisnan): Always define, since it's always available now.
2079 (syms_of_floatfns): Always define isnan at the Lisp level.
2080
2081 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2084
2085 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2088 The previous code assumed that file offsets (off_t values) fit in
2089 EMACS_INT variables, which is not true on typical 32-bit hosts.
2090 The code messed up by falsely reporting buffer overflow in cases
2091 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2092 when "big" contains more than 2**29 bytes, even though this
2093 inserts just one byte and does not overflow the buffer.
2094 (Finsert_file_contents): Store file offsets as off_t
2095 values, not as EMACS_INT values. Check for overflow when
2096 converting between EMACS_INT and off_t. When checking for
2097 buffer overflow or for overlap, take the offsets into account.
2098 Don't use EMACS_INT for small values where int suffices.
2099 When checking for overlap, fix a typo: ZV was used where
2100 ZV_BYTE was intended.
2101 (Fwrite_region): Don't assume off_t fits into 'long'.
2102 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2103
2104 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2105
2106 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2107
2108 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 sprintf-related integer and memory overflow issues (Bug#9412).
2111
2112 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2113 (esprintf, exprintf, evxprintf): New functions.
2114 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2115 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2116 (modify_event_symbol): Do not assume that the length of
2117 name_alist_or_stem is safe to alloca and fits in int.
2118 (Fexecute_extended_command): Likewise for function name and binding.
2119 (Frecursion_depth): Wrap around reliably on integer overflow.
2120 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2121 since some callers pass EMACS_INT values.
2122 (Fsingle_key_description): Don't crash if symbol name contains more
2123 than MAX_ALLOCA bytes.
2124 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2125 (get_minibuffer): Arg is now EMACS_INT, not int.
2126 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2127 (esprintf, exprintf, evxprintf): New decls.
2128 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2129
2130 * dbusbind.c (signature_cat): New function.
2131 (xd_signature, Fdbus_register_signal):
2132 Do not overrun buffer; instead, report string overflow.
2133
2134 * dispnew.c (add_window_display_history): Don't overrun buffer.
2135 Truncate instead; this is OK since it's just a log.
2136
2137 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2138 even if the time zone offset is outlandishly large.
2139 Don't mishandle offset == INT_MIN.
2140
2141 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2142 when creating daemon; the previous buffer-overflow check was incorrect.
2143
2144 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2145 which has the guts of the old verror function.
2146
2147 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2148 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2149
2150 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2151 (font_unparse_xlfd): Don't blindly alloca long strings.
2152 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2153 fits in int, when using sprintf. Use single snprintf to count
2154 length of string rather than counting it via multiple sprintfs;
2155 that's simpler and more reliable.
2156 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2157 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2158 sprintf, in case result does not fit in int.
2159
2160 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2161 (fontset_from_font): Print it.
2162
2163 * frame.c (tty_frame_count): Now printmax_t, not int.
2164 (make_terminal_frame, set_term_frame_name): Print it.
2165 (x_report_frame_params): In X, window IDs are unsigned long,
2166 not signed long, so print them as unsigned.
2167 (validate_x_resource_name): Check for implausibly long names,
2168 and don't assume name length fits in 'int'.
2169 (x_get_resource_string): Don't blindly alloca invocation name;
2170 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2171 not fit in int.
2172
2173 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2174 (xg_check_special_colors, xg_set_geometry):
2175 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2176
2177 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2178 Use esprintf, not sprintf, in case result does not fit in int.
2179
2180 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2181 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2182 it as a large positive number.
2183 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2184 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2185
2186 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2187 in case result does not fit in int.
2188
2189 * print.c (float_to_string): Detect width overflow more reliably.
2190 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2191 buffer overrun. Don't assume list length fits in 'int'. Treat
2192 print length of 0 as 0, not as infinity; to be consistent with other
2193 uses of print length in this function. Don't overflow print length
2194 index. Don't assume hash table size fits in 'long', or that
2195 vectorlike size fits in 'unsigned long'.
2196
2197 * process.c (make_process): Use printmax_t, not int, to format
2198 process-name gensyms.
2199
2200 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2201
2202 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2203 to avoid potential buffer overrun.
2204
2205 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2206 if X resource line is longer than 512 bytes.
2207
2208 * xfns.c (x_window): Make sprintf buffer a bit bigger
2209 to avoid potential buffer overrun.
2210
2211 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2212
2213 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2214
2215 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 Integer overflow fixes for scrolling, etc.
2218 Without these, Emacs silently mishandles large integers sometimes.
2219 For example, "C-u 4294967297 M-x recenter" was treated as if
2220 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2221
2222 * xdisp.c (try_window_id): Check Emacs fixnum range before
2223 converting to 'int'.
2224
2225 * window.c (window_scroll_line_based, Frecenter):
2226 Check that an Emacs fixnum is in range before assigning it to 'int'.
2227 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2228 values converted from Emacs fixnums.
2229 (Frecenter): Don't wrap around a line count if it is out of 'int'
2230 range; instead, treat it as an extreme value.
2231 (Fset_window_configuration, compare_window_configurations):
2232 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2233
2234 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2235 that can exceed INT_MAX. Check that EMACS_INT value is in range
2236 before assigning it to the (possibly-narrower) index.
2237 (match_limit): Don't assume that a fixnum can fit in 'int'.
2238
2239 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2240 exceed INT_MAX.
2241
2242 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2243 (Fvertical_motion): Don't wrap around LINES values that don't fit
2244 in 'int'. Instead, treat them as extreme values. This is good
2245 enough for windows, which can't have more than INT_MAX lines anyway.
2246
2247 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2248
2249 * Require libxml/parser.h to avoid compilation warning.
2250
2251 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2252
2253 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2254 since this reportedly can destroy thread storage.
2255
2256 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2257
2258 * syntax.c (find_defun_start): Update all cache variables if
2259 exiting early (Bug#9401).
2260
2261 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2262
2263 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2264
2265 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2266 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2267 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2268
2269 * term.c (tty_append_glyph): New function.
2270 (produce_stretch_glyph): Static function and its prototype deleted.
2271
2272 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2273 Add prototypes.
2274
2275 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2276
2277 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2278 when checking :margin (Bug#9390).
2279 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2280 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2281 so that the name doesn't mislead. All uses changed.
2282
2283 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2284
2285 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2286 set_tty_hooks.
2287
2288 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (move_it_to): Don't bail out early when reaching
2291 position beyond to_charpos, if we are scanning backwards.
2292 (move_it_vertically_backward): When DY == 0, make sure we get to
2293 the first character in the line after the newline.
2294
2295 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2296
2297 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2298 (ccl_driver): Do not generate an out-of-range pointer.
2299 (Fccl_execute_on_string): Remove unnecessary check for
2300 integer overflow, noted by Stefan Monnier in
2301 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2302 Remove a FIXME that didn't need fixing.
2303 Simplify the newly-introduced buffer reallocation code.
2304
2305 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2306
2307 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2308
2309 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2310
2311 Integer and memory overflow issues (Bug#9196).
2312
2313 * doc.c (get_doc_string): Rework so that
2314 get_doc_string_buffer_size is the actual buffer size, rather than
2315 being 1 less than the actual buffer size; this makes xpalloc more
2316 convenient.
2317
2318 * image.c (x_allocate_bitmap_record, cache_image):
2319 * xselect.c (Fx_register_dnd_atom):
2320 Simplify previous changes by using xpalloc.
2321
2322 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2323 since either will do and ptrdiff_t is convenient with xpalloc.
2324
2325 * charset.c (charset_table_size)
2326 (struct charset_sort_data.priority): Now ptrdiff_t.
2327 (charset_compare): Don't overflow if priorities differ greatly.
2328 (Fsort_charsets): Don't assume list length fits in int.
2329 Check for size-calculation overflow when allocating sort data.
2330 (syms_of_charset): Allocate an initial charset table that is
2331 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2332
2333 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2334
2335 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2336 The actual value is always <= INT_MAX, and leaving it unsigned made
2337 overflow checking harder.
2338
2339 * dispextern.h (struct glyph_matrix.rows_allocated)
2340 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2341 with xpalloc. The values are still always <= INT_MAX.
2342
2343 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2344
2345 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2346 (SAFE_NALLOCA): New macro.
2347
2348 * region-cache.c (struct boundary.pos, find_cache_boundary)
2349 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2350 (set_cache_region, invalidate_region_cache)
2351 (revalidate_region_cache, know_region_cache, region_cache_forward)
2352 (region_cache_backward, pp_cache):
2353 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2354 so that ptrdiff_t * can be passed to xpalloc.
2355 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2356 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2357 (pp_cache): Don't assume cache_len fits in int.
2358 * region-cache.h: Adjust extern decls to match.
2359
2360 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2361 EMACS_INT, since either will do, for xpalloc.
2362
2363 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2364 (xnmalloc, xnrealloc, xpalloc): New functions.
2365
2366 * bidi.c (bidi_shelve_header_size): New constant.
2367 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2368 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2369
2370 * bidi.c (bidi_cache_shrink):
2371 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2372 (overlay_strings):
2373 Don't update size of array until after memory allocation succeeds,
2374 because xmalloc/xrealloc may not return.
2375 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2376 now that we have proper integer overflow checking.
2377 (record_overlay_string, overlay_strings): Catch overflows when
2378 calculating size of overlay_str_buf.
2379
2380 * callproc.c (Fcall_process): Check for size overflow when
2381 calculating size of args2.
2382 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2383 Normally we prefer signed values, but sticking with ptrdiff_t would
2384 require adding more-complicated checks.
2385
2386 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2387 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2388 Redo buffer-overflow calculations to avoid integer overflow.
2389 Add a FIXME comment where memory seems to be over-allocated.
2390
2391 * character.c (Fstring): Check for size-calculation overflow.
2392
2393 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2394 unnecessary integer overflow. Check for size overflow.
2395 (encode_coding_object): Don't update size until xmalloc succeeds.
2396
2397 * composite.c (get_composition_id): Check for overflow in glyph
2398 length calculations.
2399
2400 Integer and memory overflow fixes for display code.
2401 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2402 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2403 (scrolling_window): Check for overflow in size calculations.
2404 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2405 Don't assume glyph table len fits in int.
2406 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2407 (row_table_size): Now ptrdiff_t, not int.
2408 (scrolling_window): Avoid overflow in size calculations.
2409 Don't update size until allocation succeeds.
2410 * fns.c (concat): Check for overflow in size calculations.
2411 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2412 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2413 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2414
2415 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2416 (get_doc_string): Check for size calculation overflow.
2417 Don't update size until allocation succeeds.
2418 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2419 EMACS_INT, where ptrdiff_t will do.
2420 (Fsubstitute_command_keys): Check for string overflow.
2421
2422 * editfns.c (set_time_zone_rule): Don't assume environment length
2423 fits in int.
2424 (message_length): Now ptrdiff_t, not int.
2425 (Fmessage_box): Don't update size until allocation succeeds.
2426 Don't assume message length fits in int.
2427 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2428
2429 * emacs.c (main): Do not reallocate argv, since there is a null at
2430 the end that can be overwritten, and this way there's no need to
2431 worry about size-calculation overflow.
2432 (sort_args): Check for size-calculation overflow.
2433
2434 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2435 alloc succeeds.
2436 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2437
2438 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2439 (x_set_scroll_bar_width, x_figure_window_size):
2440 Check for integer overflow.
2441 (x_set_alpha): Do not assume XINT fits in int.
2442
2443 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2444 This is for the members text_lines, text_cols, total_lines, total_cols,
2445 where the system imposes an 'int' limit.
2446
2447 * fringe.c (Fdefine_fringe_bitmap):
2448 Don't update size until alloc works.
2449
2450 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2451 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2452
2453 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2454 Check for size-calculation overflow.
2455 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2456 do, as we prefer signed integers.
2457 (id_to_widget.max_size, id_to_widget.used)
2458 (xg_store_widget_in_map, xg_remove_widget_from_map)
2459 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2460 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2461 Use and return ptrdiff_t, not int.
2462 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2463 * gtkutil.h: Change prototypes to match the above.
2464
2465 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2466 are duplicate now that they've been promoted to lisp.h.
2467 (x_allocate_bitmap_record, x_alloc_image_color)
2468 (make_image_cache, cache_image, xpm_load):
2469 Don't update size until alloc is done.
2470 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2471 (x_detect_edges):
2472 Check for size calculation overflow.
2473 (ct_colors_allocated_max): New constant.
2474 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2475 overflow.
2476
2477 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2478 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2479 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2480 Use ptrdiff_t, not int, to count maps.
2481 (read_char_minibuf_menu_prompt): Check for overflow in size
2482 calculations. Don't update size until allocation succeeds.
2483 Redo calculations to avoid overflow.
2484 * keyboard.h: Change prototypes to match the above.
2485
2486 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2487 to count maps.
2488 (current_minor_maps): Check for size calculation overflow.
2489 * keymap.h: Change prototypes to match the above.
2490
2491 * lread.c (read1, init_obarray): Don't update size until alloc done.
2492
2493 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2494 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2495
2496 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2497 Now ptrdiff_t, not int.
2498 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2499 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2500
2501 * process.c (Fnetwork_interface_list): Check for overflow
2502 in size calculation.
2503
2504 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2505
2506 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2507 overflow. Don't bother calling xmalloc when xrealloc will do.
2508
2509 * search.c (Freplace_match): Check for size calculation overflow.
2510 (Fset_match_data): Don't assume list lengths fit in 'int'.
2511
2512 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2513 for command line length. Do not attempt to address one before the
2514 beginning of an array, as that's not portable.
2515
2516 * term.c (max_frame_lines): Remove; unused.
2517 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2518 not int.
2519 (encode_terminal_code, calculate_costs): Check for size
2520 calculation overflow.
2521 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2522 table lengths and related sizes. Don't update size until alloc
2523 done. Redo calculations to avoid overflow.
2524 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2525
2526 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2527 subtracting pointers.
2528 (gobble_line): Check for overflow more carefully. Don't update size
2529 until alloc done.
2530
2531 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2532 Don't update size until alloc done.
2533 Redo size calculations to avoid overflow.
2534 Check for size calculation overflow.
2535 (main) [DEBUG]: Fix typo in invoking tparam1.
2536
2537 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2538 Use ptrdiff_t, not int, for sizes.
2539 (store_mode_line_noprop_char): Don't update size until alloc done.
2540
2541 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2542 Use ptrdiff_t, not int, for sizes.
2543 (Finternal_make_lisp_face, cache_face):
2544 Check for size calculation overflow.
2545 (cache_face): Treat size calculation overflows as if they were
2546 memory exhaustion (the usual treatment), rather than aborting.
2547
2548 * xfns.c (x_encode_text, x_set_name_internal)
2549 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2550 sizes, since they can exceed INT_MAX in size. Check for size
2551 calculation overflow.
2552
2553 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2554 (xg_select): Check for size calculation overflow.
2555 Don't update size until alloc done.
2556
2557 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2558 as sprintf is limited to int lengths.
2559
2560 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2561 (X_LONG_MIN): New macros.
2562 Use them to make the following changes clearer.
2563 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2564 This change doesn't affect the value now, but it may help remind
2565 future maintainers not to raise the value too much later.
2566 (SELECTION_QUANTUM): Remove, replacing with ...
2567 (selection_quantum): ... new function, which avoids overflow.
2568 All uses changed.
2569 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2570 assumption that selection length fits in 'int'.
2571 (x_reply_selection_request, x_handle_selection_request)
2572 (x_get_window_property, receive_incremental_selection)
2573 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2574 (lisp_data_to_selection_data, clean_local_selection_data):
2575 Use ptrdiff_t, not int, to record length of selection.
2576 (x_reply_selection_request, x_get_window_property)
2577 (receive_incremental_selection, x_property_data_to_lisp):
2578 Redo calculations to avoid overflow.
2579 (x_reply_selection_request): When sending hint, ceiling it at
2580 X_LONG_MAX rather than relying on wraparound overflow to send
2581 something.
2582 (x_get_window_property, receive_incremental_selection)
2583 (lisp_data_to_selection_data, x_property_data_to_lisp):
2584 Check for size-calculation overflow.
2585 (x_get_window_property, receive_incremental_selection)
2586 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2587 Don't store size until memory allocation succeeds.
2588 (x_get_window_property): Plug memory leak on memory exhaustion.
2589 Don't double-block input; malloc is safe here. Don't assume 2**34
2590 - 4 fits in unsigned long. Add an xassert to check
2591 XGetWindowProperty overflow. Be more careful about overflow
2592 calculations, and distinguish size from memory overflow better.
2593 (receive_incremental_selection): When tracing, don't assume
2594 unsigned int is less than INT_MAX.
2595 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2596 harmful) conversions of unsigned short to int.
2597 (lisp_data_to_selection_data): Don't assume that integers
2598 in the range -65535 through -1 fit in an X unsigned short.
2599 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2600 result parameters unless successful. Rely on cons_to_unsigned
2601 to report problems with elements; the old code wasn't right anyway.
2602 (x_check_property_data): Check for int overflow; we cannot use
2603 a wider type due to X limits.
2604 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2605
2606 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2607
2608 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2609 (x_term_init): Check for size calculation overflow.
2610 (x_color_cells): Don't store size until memory allocation succeeds.
2611 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2612 Don't assume alloca size is less than MAX_ALLOCA.
2613 (x_term_init): Don't assume length fits in int (sprintf is limited
2614 to int size).
2615
2616 Use ptrdiff_t for composition IDs.
2617 * character.c (lisp_string_width):
2618 * composite.c (composition_table_size, n_compositions)
2619 (get_composition_id, composition_gstring_from_id):
2620 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2621 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2622 * window.c (Frecenter):
2623 Use ptrdiff_t, not int, for composition IDs.
2624 * composite.c (get_composition_id): Check for integer overflow.
2625 * composite.h: Adjust prototypes to match the above changes.
2626
2627 Use ptrdiff_t for hash table indexes.
2628 * category.c (hash_get_category_set):
2629 * ccl.c (ccl_driver):
2630 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2631 * coding.c (coding_system_charset_list, detect_coding_system):
2632 * coding.h (struct coding_system.id):
2633 * composite.c (get_composition_id, gstring_lookup_cache):
2634 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2635 * image.c (xpm_get_color_table_h):
2636 * lisp.h (hash_lookup, hash_put):
2637 * minibuf.c (Ftest_completion):
2638 Use ptrdiff_t for hash table indexes, not int (which is too
2639 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2640 32-bit --with-wide-int hosts).
2641
2642 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2643 Add a FIXME comment about memory leaks.
2644 (syms_of_charset): Don't assume xmalloc returns.
2645
2646 Don't assume that stated character widths fit in int.
2647 * character.c (Fchar_width, c_string_width, lisp_string_width):
2648 * character.h (CHAR_WIDTH):
2649 * indent.c (MULTIBYTE_BYTES_WIDTH):
2650 Use sanitize_char_width to avoid undefined and/or bad behavior
2651 with outlandish widths.
2652 * character.h (sanitize_tab_width): Rename from sanitize_width,
2653 now that we have two such functions. All uses changed.
2654 (sanitize_char_width): New inline function.
2655
2656 Don't assume that tab-width fits in int.
2657 * character.h (sanitize_width): New inline function.
2658 (SANE_TAB_WIDTH): New macro.
2659 (ASCII_CHAR_WIDTH): Use it.
2660 * indent.c (sane_tab_width): Remove. All uses replaced by
2661 SANE_TAB_WIDTH (current_buffer).
2662 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2663
2664 * fileio.c: Integer overflow issues with file modes.
2665 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2666
2667 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2668 Remove unreachable code.
2669 (read_hex, load_charset_map_from_file): Check for integer overflow.
2670
2671 * xterm.c: Don't go over XClientMessageEvent limit.
2672 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2673 (x_send_scroll_bar_event): Likewise. Check that the size does not
2674 exceed limits imposed by XClientMessageEvent, as well as the usual
2675 ptrdiff_t and size_t limits.
2676
2677 * keyboard.c: Overflow, signedness and related fixes.
2678 (make_lispy_movement): Use same integer type in forward decl
2679 that is used in the definition.
2680 (read_key_sequence, keyremap_step):
2681 Change bufsize argument back to int, undoing my 2011-03-30 change.
2682 We prefer signed types, and int is wide enough here.
2683 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2684 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2685 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2686 length, not size_t. Use ptrdiff_t for index, not int.
2687 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2688 possibility of integer overflow.
2689
2690 Overflow, signedness and related fixes for images.
2691
2692 * dispextern.h (struct it.stack[0].u.image.image_id)
2693 (struct_it.image_id, struct image.id, struct image_cache.size)
2694 (struct image_cache.used, struct image_cache.ref_count):
2695 * gtkutil.c (update_frame_tool_bar):
2696 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2697 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2698 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2699 * nsmenu.m (update_frame_tool_bar):
2700 * xdisp.c (calc_pixel_width_or_height):
2701 * xfns.c (image_cache_refcount):
2702 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2703 on typical 64-bit hosts.
2704
2705 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2706 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2707 Omit unnecessary casts to int.
2708 (parse_image_spec): Check that integers fall into 'int' range
2709 when the callers expect that.
2710 (image_ascent): Redo ascent calculation to avoid int overflow.
2711 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2712 (lookup_image): Remove unnecessary tests.
2713 (xbm_image_p): Locals are now of int, not EMACS_INT,
2714 since parse_image_check makes sure they fit into int.
2715 (png_load, gif_load, svg_load_image):
2716 Prefer int to unsigned where either will do.
2717 (tiff_handler): New function, combining the cores of the
2718 old tiff_error_handler and tiff_warning_handler.
2719 This function is rewritten to use vsnprintf and thereby avoid
2720 stack buffer overflows. It uses only the features of vsnprintf
2721 that are common to both POSIX and native Microsoft.
2722 (tiff_error_handler, tiff_warning_handler): Use it.
2723 (tiff_load, gif_load, imagemagick_load_image):
2724 Don't assume :index value fits in 'int'.
2725 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2726 (imagemagick_load_image): Check that crop parameters fit into
2727 the integer types that MagickCropImage accepts. Don't assume
2728 Vimagemagick_render_type has a nonnegative value. Don't assume
2729 size_t fits in 'long'.
2730 (gs_load): Use printmax_t to print the widest integers possible.
2731 Check for integer overflow when computing image height and width.
2732
2733 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2734
2735 * xdisp.c (redisplay_window): Don't force window start if point
2736 will be invisible in the resulting window. (Bug#9324)
2737
2738 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2739
2740 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2741 the display spec is of the form `(space ...)'.
2742 (handle_display_spec): Return the value returned by
2743 handle_single_display_spec, not just 1 or zero.
2744 (handle_single_display_spec): If the display spec is of the form
2745 `(space ...)', and specifies display in the text area, return 2
2746 rather than 1.
2747 (try_cursor_movement): Check for the need to scroll more
2748 accurately, and prefer exact match for point under bidi.
2749 Don't advance `row' beyond the last row of the window.
2750
2751 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2752 into disp_prop; all users changed.
2753
2754 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2755 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2756 for the text covered by the display property.
2757
2758 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2759
2760 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2761 Change return value to nil.
2762 (Frecord_buffer): Delete unused function.
2763
2764 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2765
2766 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2767 buffers, return left-to-right.
2768 (set_cursor_from_row): Consider candidate row a win if its glyph
2769 represents a newline and point is on that newline. Fixes cursor
2770 positioning on the newline at EOL of R2L text within L2R
2771 paragraph, and vice versa.
2772 (try_cursor_movement): Check continued rows, in addition to
2773 continuation rows. Fixes unwarranted scroll when point enters a
2774 continued line of R2L text within an L2R paragraph, or vice versa.
2775 (cursor_row_p): Consider the case of point being equal to
2776 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2777 from the end of a short line to the beginning of a continued line
2778 of R2L text within L2R paragraph.
2779 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2780 composed characters.
2781
2782 * bidi.c (bidi_check_type): Use xassert.
2783 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2784 members.
2785
2786 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2787
2788 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2789 a character.
2790
2791 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2792
2793 * nsfont.m (ns_otf_to_script): Fix typo.
2794
2795 2011-08-22 Kenichi Handa <handa@m17n.org>
2796
2797 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2798 extra slot even if the purpose is char-code-property-table.
2799
2800 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2801
2802 * xdisp.c (redisplay_window): When computing centering_position,
2803 account for the height of the header line. (Bug#8874)
2804
2805 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2806 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2807 candidate is selected by the mouse, and that candidate has a
2808 composed character under the mouse.
2809
2810 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2811 coordinates reported by pos-visible-in-window-p for a composed
2812 character in column zero.
2813
2814 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2815
2816 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2817
2818 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2819
2820 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2821 consider it a hit if to_charpos is anywhere in the range of the
2822 composed buffer positions.
2823
2824 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2825
2826 * image.c (gif_load): Don't assume that each subimage has the same
2827 dimensions as the base image. Handle disposal method that is
2828 "undefined" by the gif spec (Bug#9335).
2829
2830 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2831
2832 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2833 (Fcondition_case): Document `debug' symbol in error handler.
2834
2835 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2838 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2839 from an Org mode buffer to a Speedbar frame.
2840
2841 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2842 a composition, take its buffer position from IT->cmp_it.charpos.
2843 Fixes cursor positioning at the beginning of a line that begins
2844 with a composed character.
2845
2846 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2847
2848 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2849 character bidirectional type, use STRONG_L instead. Fixes crashes
2850 in a buffer produced by `describe-categories'.
2851
2852 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2853 members before the level stack, so they would be saved and
2854 restored when copying iterator state. Fixes incorrect reordering
2855 around TABs covered by display properties.
2856
2857 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2858
2859 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2860
2861 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2862
2863 * eval.c (internal_condition_case, internal_condition_case_1)
2864 (internal_condition_case_2, internal_condition_case_n):
2865 Remove unnecessary aborts (Bug#9081).
2866
2867 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2868
2869 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2870 has no `load' handler, try opening the file locally. (Bug#9311)
2871
2872 2011-08-16 Ken Brown <kbrown@cornell.edu>
2873
2874 * gmalloc.c: Expand comment.
2875
2876 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2877
2878 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2879 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2880
2881 2011-08-16 Ken Brown <kbrown@cornell.edu>
2882
2883 Fix memory allocation problems in Cygwin build (Bug#9273).
2884
2885 * unexcw.c ( __malloc_initialized): Declare external variable.
2886 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2887
2888 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2889 New variables.
2890 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2891 dumped emacs.
2892 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2893 in the static heap.
2894 [CYGWIN] (special_realloc): New function.
2895 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2896 requests to realloc storage in the static heap.
2897
2898 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 * bidi.c (bidi_initialize): Remove unused local.
2901
2902 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2903
2904 * bidimirror.h:
2905 * biditype.h: Remove file.
2906 * makefile.w32-in ($(BLD)/bidi.$(O)):
2907 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2908
2909 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2910
2911 * chartab.c: Improve commentary for the uniprop_table API.
2912
2913 * bidi.c (bidi_paragraph_init): Support zero value of
2914 bidi_ignore_explicit_marks_for_paragraph_level.
2915 (bidi_initialize): Use uniprop_table instead of including
2916 biditype.h and bidimirror.h.
2917
2918 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2919 coordinates of the iterator when restoring from ppos_it.
2920 (Bug#9296)
2921
2922 2011-08-14 Kenichi Handa <handa@m17n.org>
2923
2924 * process.c (create_process): Call setup_process_coding_systems
2925 after the pid of the process is set to -1 (Bug#8162).
2926
2927 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2928
2929 * xdisp.c (move_it_in_display_line_to): Don't invoke
2930 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2931 ppos_it. Fixes vertical cursor motion when line beginning is
2932 covered by an image. (Bug#9296)
2933
2934 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2935
2936 * nsterm.h (ns_run_ascript): Declare.
2937 (NSAPP_DATA2_RUNASSCRIPT): Define.
2938
2939 * nsfns.m (as_script, as_result, as_status): New static variables.
2940 (ns_run_ascript): New function.
2941 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2942 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2943 the event loop. Get status from as_status (Bug#7276).
2944
2945 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2946 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2947 the event loop (Bug#7276).
2948
2949 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2950
2951 * gnutls.c (QCgnutls_bootprop_priority)
2952 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2953 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2954 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2955 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2956 (QCgnutls_bootprop_verify_hostname_error)
2957 (QCgnutls_bootprop_callbacks_verify): Rename from
2958 Qgnutls_bootprop_..., all uses changed.
2959
2960 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2961 uses changed.
2962
2963 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2964
2965 * xfaces.c (Qframe_set_background_mode): Now static.
2966 * dispextern.h (Qframe_set_background_mode): Remove decl.
2967
2968 * process.c (Fnetwork_interface_info): Declare local only if needed.
2969
2970 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2971
2972 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2973 (Fnetwork_interface_list): Allocate in increments of bytes instead
2974 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2975 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2976 sockaddr.
2977 (struct ifflag_def): notrailers is smart on OSX.
2978 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2979 Get hardware address with getifaddrs if available.
2980
2981 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2982
2983 * xdisp.c (iterate_out_of_display_property): xassert that
2984 IT->position is set to within IT->object's boundaries. Break from
2985 the loop as soon as EOB is reached; avoids infloops in redisplay
2986 when IT->position is set up wrongly due to some bug.
2987 Set IT->current to match the bidi iterator unconditionally.
2988 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2989 entry. Force push_it to save on the stack the current
2990 buffer/string position, to be restored by pop_it. Fix flags in
2991 the iterator structure wrt the object coming from a display
2992 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2993 properties. (Bug#9284)
2994
2995 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2996
2997 * fontset.c (fontset_get_font_group): Add proper type checks.
2998 (Bug#9172)
2999
3000 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3001
3002 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3003 and LC_VERSION_MIN_MACOSX.
3004 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3005 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3006
3007 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3008
3009 * xdisp.c (forward_to_next_line_start): Allow to use the
3010 no-display-properties-and-no-overlays under bidi display.
3011 Set disp_pos in the bidi iterator to avoid searches for display
3012 properties and overlays.
3013
3014 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3015
3016 * editfns.c (Fset_time_zone_rule): Document relationship with the
3017 setenv function.
3018
3019 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3020 the font entity extracted from the cache (Bug#8109).
3021
3022 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3023
3024 * composite.c (autocmp_chars): Don't reset point. That is done by
3025 restore_point_unwind (Bug#5984).
3026
3027 2011-08-07 Juri Linkov <juri@jurta.org>
3028
3029 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3030 to show the arg `TIME' instead of `TIMEVAL'.
3031
3032 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3033
3034 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3035 display property strides EOL and includes a newline, as in
3036 longlines-mode. (Bug#9254)
3037 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3038 word-wrap under bidirectional display. (Bug#9224)
3039
3040 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3041 is non-zero, even if the data buffer is NULL. Fixes a crash in
3042 vertical-motion with longlines-mode. (Bug#9254)
3043
3044 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3045
3046 * bidi.c <bidi_cache_total_alloc>: Now static.
3047 (bidi_initialize): Initialize bidi_cache_total_alloc.
3048
3049 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3050 cache. (Bug#9221)
3051
3052 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3053 amount allocated this far in `bidi_cache_total_alloc'.
3054 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3055 non-zero, only free the data buffer without restoring the cache
3056 contents. All callers changed.
3057
3058 * dispextern.h (bidi_unshelve_cache): Update prototype.
3059
3060 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3061 (move_it_in_display_line, move_it_to)
3062 (move_it_vertically_backward, move_it_by_lines): Replace the call
3063 to xfree to an equivalent call to bidi_unshelve_cache.
3064 (move_it_in_display_line_to): Fix logic of returning
3065 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3066
3067 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3068
3069 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3070 came from a string character with a `cursor' property. (Bug#9229)
3071
3072 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3073
3074 * Makefile.in (LIB_PTHREAD): New variable.
3075 (LIBES): Add LIB_PTHREAD (Bug#9216).
3076
3077 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3078 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3079
3080 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3081
3082 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3083
3084 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3085
3086 * xterm.c (x_find_topmost_parent): New function.
3087 (x_set_frame_alpha): Find topmost parent window with
3088 x_find_topmost_parent and set the property there also (bug#9181).
3089 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3090
3091 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 * callproc.c (Fcall_process): Avoid vfork clobbering
3094 the local vars buffer, coding_systems, current_dir.
3095
3096 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3097
3098 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3099
3100 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3101
3102 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3103 so that it is not optimized away.
3104
3105 * xdisp.c (compute_display_string_pos): Remove unused local.
3106
3107 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3108
3109 Fix slow cursor motion and scrolling in large buffers with
3110 selective display, like Org Mode buffers. (Bug#9218)
3111
3112 * dispextern.h (struct bidi_it): New member disp_prop_p.
3113
3114 * xdisp.c: Remove one-slot cache of display string positions.
3115 (compute_display_string_pos): Accept an additional argument
3116 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3117 for a display string or property. If found, set DISP_PROP_P
3118 non-zero.
3119
3120 * bidi.c (bidi_fetch_char): Accept an additional argument
3121 DISP_PROP_P, and pass it to compute_display_string_pos.
3122 Only handle text covered by a display string if DISP_PROP_P is returned
3123 non-zero. All callers of bidi_fetch_char changed.
3124
3125 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3126
3127 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3128
3129 2010-12-03 Don March <don@ohspite.net>
3130
3131 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3132 last character M-[char] is translated to ESC [char] (bug#7541).
3133
3134 2011-08-02 Kenichi Handa <handa@m17n.org>
3135
3136 * lisp.h (uniprop_table): Extern it.
3137
3138 * chartab.c (uniprop_table): Make it non-static.
3139
3140 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3141
3142 * xdisp.c (forward_to_next_line_start): Accept additional argument
3143 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3144 on the newline.
3145 (reseat_at_next_visible_line_start): Use the bidi iterator state
3146 returned by forward_to_next_line_start to restore the state of
3147 it->bidi_it after backing up to previous newline. (Bug#9212)
3148
3149 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3150
3151 * regex.c (re_comp): Protoize.
3152 (re_exec): Fix return type.
3153 (regexec): Fix type of `ret'. (Bug#9203)
3154
3155 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3158 This is needed if max-image-size is a floating-point number.
3159
3160 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3161
3162 * print.c (print_object): Print empty symbol as ##.
3163
3164 * lread.c (read1): Read ## as empty symbol.
3165
3166 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3167
3168 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3169 setting frame foreground color (Bug#9175).
3170 (x_set_background_color): Likewise.
3171
3172 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3173 contents (Bug#9176).
3174 (EmacsTooltip -init): Remove bezels and add shadows to
3175 tooltip windows.
3176
3177 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3178 or scroll bar (Bug#8470).
3179
3180 * nsfont.m (nsfont_open): Remove assignment to voffset and
3181 unnecessary vars hshink, expand, hd, full_height, min_height.
3182 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3183
3184 * nsterm.h (nsfont_info): Remove voffset field.
3185
3186 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3187
3188 Implement strike-through and overline on NextStep (Bug#8863).
3189
3190 * nsfont.m (nsfont_open): Use underline position provided by font,
3191 instead of hard-coded value of 2.
3192 (nsfont_draw): Call ns_draw_text_decoration instead.
3193
3194 * nsterm.h: Add declaration for ns_draw_text_decoration.
3195
3196 * nsterm.m (ns_draw_text_decoration): New function for drawing
3197 underline, overline, and strike-through.
3198 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3199 ns_draw_text_decoration. Change treatment of cursor drawing to
3200 accommodate underlining, etc.
3201
3202 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3203
3204 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3205 default.
3206
3207 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3210 Without this fix, if a signal arrives just after memory fills up,
3211 'malloc' might be invoked reentrantly.
3212
3213 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3214 In other words, assume that every image size is allowed, on non-X
3215 hosts. This assumption is probably wrong, but it lets Emacs compile.
3216
3217 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3218
3219 * regex.c (re_iswctype): Convert return values to boolean.
3220
3221 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3222
3223 * xdisp.c (compute_display_string_pos): Don't use cached display
3224 string position if the buffer had its restriction changed.
3225 (Bug#9184)
3226
3227 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3230
3231 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 Integer signedness and overflow and related fixes. (Bug#9079)
3234
3235 * bidi.c: Integer size and overflow fixes.
3236 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3237 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3238 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3239 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3240 (bidi_find_other_level_edge):
3241 Use ptrdiff_t instead of EMACS_INT where either will do.
3242 This works better on 32-bit hosts configured --with-wide-int.
3243 (bidi_cache_ensure_space): Check for size-calculation overflow.
3244 Use % rather than repeated addition, for better worst-case speed.
3245 Don't set bidi_cache_size until after xrealloc returns, because it
3246 might not return.
3247 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3248 (bidi_cache_ensure_space): Also check that the bidi cache size
3249 does not exceed that of the largest Lisp string or buffer. See Eli
3250 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3251
3252 * alloc.c (__malloc_size_t): Remove.
3253 All uses replaced by size_t. See Andreas Schwab's note
3254 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3255
3256 * image.c: Improve checking for integer overflow.
3257 (check_image_size): Assume that f is nonnull, since
3258 it is always nonnull in practice. This is one less thing to
3259 worry about when checking for integer overflow later.
3260 (x_check_image_size): New function, which checks for integer
3261 overflow issues inside X.
3262 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3263 This removes the need for a memory_full check.
3264 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3265 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3266 (xbm_read_bitmap_data): Change locals back to 'int', since
3267 their values must fit in 'int'.
3268 (xpm_load_image, png_load, tiff_load):
3269 Invoke x_create_x_image_and_pixmap earlier,
3270 to avoid much needless work if the image is too large.
3271 (tiff_load): Treat overly large images as if
3272 x_create_x_image_and_pixmap failed, not as malloc failures.
3273 (gs_load): Use x_check_image_size.
3274
3275 * gtkutil.c: Omit integer casts.
3276 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3277 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3278
3279 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3280
3281 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3282 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3283 would wrongly return t on a 64-bit host.
3284
3285 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3286 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3287 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3288 and therefore cause GCC to emit a bogus diagnostic in some cases.
3289
3290 * image.c: Integer signedness and overflow and related fixes.
3291 This is not an exhaustive set of fixes, but it's time to
3292 record what I've got.
3293 (lookup_pixel_color, check_image_size): Remove redundant decls.
3294 (check_image_size): Don't assume that arbitrary EMACS_INT values
3295 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3296 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3297 (tiff_load, imagemagick_load_image):
3298 Check for overflow in size calculations.
3299 (x_create_x_image_and_pixmap): Remove unnecessary test for
3300 xmalloc returning NULL; that can't happen.
3301 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3302 (xpm_color_bucket): Use better integer hashing function.
3303 (xpm_cache_color): Don't possibly over-allocate memory.
3304 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3305 (gif_memory_source):
3306 Use ptrdiff_t, not int or size_t, to record sizes.
3307 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3308 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3309 either works, as we prefer signed integers.
3310 (tiff_read_from_memory, tiff_write_from_memory):
3311 Return tsize_t, not size_t, since that's what the TIFF API wants.
3312 (tiff_read_from_memory): Don't fail simply because the read would
3313 go past EOF; instead, return a short read.
3314 (tiff_load): Omit no-longer-needed casts.
3315 (Fimagemagick_types): Don't assume size fits into 'int'.
3316
3317 Improve hashing quality when configured --with-wide-int.
3318 * fns.c (hash_string): New function, taken from sxhash_string.
3319 Do not discard information about ASCII character case; this
3320 discarding is no longer needed.
3321 (sxhash-string): Use it. Change sig to match it. Caller changed.
3322 * lisp.h: Declare it.
3323 * lread.c (hash_string): Remove, since we now use fns.c's version.
3324 The fns.c version returns a wider integer if --with-wide-int is
3325 specified, so this should help the quality of the hashing a bit.
3326
3327 * emacs.c: Integer overflow minor fix.
3328 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3329 Define only if GNU_LINUX.
3330 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3331
3332 * dispnew.c: Integer signedness and overflow fixes.
3333 Remove unnecessary forward decls, that were a maintenance hassle.
3334 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3335 All uses changed.
3336 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3337 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3338 (prepare_desired_row, line_draw_cost):
3339 Use int, not unsigned, where either works.
3340 (save_current_matrix, restore_current_matrix):
3341 Use ptrdiff_t, not size_t, where either works.
3342 (init_display): Check for overflow more accurately, and without
3343 relying on undefined behavior.
3344
3345 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3346 Remove, replacing with the new symbols in lisp.h. All uses changed.
3347 * fileio.c (make_temp_name):
3348 * filelock.c (lock_file_1, lock_file):
3349 * xdisp.c (message_dolog):
3350 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3351 Use pMd etc. instead.
3352 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3353 replacing the pWIDE etc. symbols removed from editfns.c.
3354
3355 * keyboard.h (num_input_events): Now uintmax_t.
3356 This is (very slightly) less likely to mess up due to wraparound.
3357 All uses changed.
3358
3359 * buffer.c: Integer signedness fixes.
3360 (alloc_buffer_text, enlarge_buffer_text):
3361 Use ptrdiff_t rather than size_t when either will do, as we prefer
3362 signed integers.
3363
3364 * alloc.c: Integer signedness and overflow fixes.
3365 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3366 (__malloc_size_t): Default to size_t, not to int.
3367 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3368 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3369 Prefer ptrdiff_t to size_t when either would do, as we prefer
3370 signed integers.
3371 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3372 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3373 Now const. Initialize with values that are in range even if char
3374 is signed.
3375 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3376 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3377 These functions do the right thing with sizes > 2**32.
3378 (check_depth): Now ptrdiff_t, not int.
3379 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3380 Adjust to new way of storing sizes. Check for size overflow bugs
3381 in rest of code.
3382 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3383 slightly wrong anyway, as it missed one instance of
3384 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3385 (refill_memory_reserve): Omit needless cast to size_t.
3386 (mark_object_loop_halt): Mark as externally visible.
3387
3388 * xselect.c: Integer signedness and overflow fixes.
3389 (Fx_register_dnd_atom, x_handle_dnd_message):
3390 Use ptrdiff_t, not size_t, since we prefer signed.
3391 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3392 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3393 x_dnd_atoms_size and x_dnd_atoms_length.
3394
3395 * doprnt.c: Prefer signed to unsigned when either works.
3396 * eval.c (verror):
3397 * doprnt.c (doprnt):
3398 * lisp.h (doprnt):
3399 * xdisp.c (vmessage):
3400 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3401 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3402 prefer signed arithmetic to avoid comparison confusion.
3403 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3404 but is a bit tricky.
3405
3406 Assume freestanding C89 headers, string.h, stdlib.h.
3407 * data.c, doprnt.c, floatfns.c, print.c:
3408 Include float.h unconditionally.
3409 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3410 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3411 * regex.c: Likewise for stddef.h, string.h.
3412 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3413 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3414 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3415 (STDC_HEADERS): Remove obsolete defines.
3416 * sysdep.c: Include limits.h unconditionally.
3417
3418 Assume support for memcmp, memcpy, memmove, memset.
3419 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3420 * regex.c (memcmp, memcpy):
3421 Remove; we assume C89 now.
3422
3423 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3424 (__malloc_safe_bcopy): Remove; no longer needed.
3425
3426 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3427 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3428 well either way, and we prefer signed to unsigned.
3429
3430 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3431
3432 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3433 closes the connection while we're reading (bug#9182).
3434
3435 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3436
3437 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3438 are specified (Bug#9168).
3439
3440 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3443 Found by GCC static checking and --with-wide-int on a 32-bit host.
3444
3445 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3446
3447 * xdisp.c (compute_display_string_pos): Fix logic of caching
3448 previous display string position. Initialize cached_prev_pos to
3449 -1. Fixes slow-down at the beginning of a buffer.
3450
3451 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3452
3453 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3454 for attrs[LFACE_FONTSET_INDEX].
3455
3456 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3457
3458 * xml.c (parse_region): Remove unused local
3459 that was recently introduced.
3460
3461 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3462
3463 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3464 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3465
3466 * xdisp.c (move_it_in_display_line_to): Record the best matching
3467 position for TO_CHARPOS while scanning the line, and restore it on
3468 exit if none of the characters scanned was an exact match.
3469 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3470 when exact match is impossible due to invisible text, and the
3471 lines are truncated.
3472
3473 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3474
3475 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3476 for OSX >= 10.7.
3477
3478 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3479
3480 Fix a significant slow-down of cursor motion with C-n, C-p,
3481 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3482 auto-repeat under bidi redisplay in fontified buffers.
3483 * xdisp.c (compute_stop_pos_backwards): New function.
3484 (next_element_from_buffer): Call compute_stop_pos_backwards to
3485 find a suitable prev_stop when we find ourselves before
3486 base_level_stop.
3487 (reseat): Don't look for prev_stop, as that could mean a very long
3488 run.
3489 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3490 <cached_disp_overlay_modiff>: Cache for last found display string
3491 position.
3492 (compute_display_string_pos): Return the cached position if asked
3493 about the same buffer in the same area of character positions, and
3494 the buffer wasn't changed since the time the display string
3495 position was cached.
3496
3497 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3498
3499 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3500 is an integer, which is important for empty lines. (Bug#9149)
3501
3502 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3503
3504 * frame.c (Fmodify_frame_parameters): In tty case, update the
3505 default face if necessary (Bug#4238).
3506
3507 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3508
3509 * editfns.c (Fstring_to_char): No need to explain what a character
3510 is in the docstring (Bug#6576).
3511
3512 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3513
3514 * xml.c (parse_region): Make sure we always return a tree.
3515
3516 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3517
3518 * xml.c (parse_region): If a document contains only comments,
3519 return that, too.
3520
3521 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3522
3523 * xml.c (make_dom): Return comments, too.
3524
3525 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 Port to OpenBSD.
3528 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3529 and the surrounding thread.
3530 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3531 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3532 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3533 timer goes off.
3534 * s/openbsd.h (BROKEN_SIGIO): Define.
3535 * unexelf.c (unexec) [__OpenBSD__]:
3536 Don't update the .mdebug section of the Alpha COFF symbol table.
3537
3538 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3539
3540 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3541 (bug#8460).
3542
3543 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3546 This fixes some race conditions on the permissions of any newly
3547 created file.
3548
3549 * alloc.c (valid_pointer_p): Use pipe, not open.
3550 This fixes some permissions issues when debugging.
3551
3552 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3553 If fchown fails to set both uid and gid, try to set just gid,
3554 as that is sometimes allowed. Adjust the file's mode to eliminate
3555 setuid or setgid bits that are inappropriate if fchown fails.
3556
3557 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3558
3559 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3560 to compare Lisp_Objects.
3561 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3562 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3563 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3564
3565 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * lread.c (read_integer): Unread even EOF character.
3568 (read1): Likewise. Properly record start position of symbol.
3569
3570 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3571 symbol character follows.
3572
3573 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3576 This works around a problem with the previous change to Fcopy_file.
3577 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3578 and without this change, GCC might complain about discarding
3579 fchown's return value.
3580
3581 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3584
3585 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3588
3589 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3590
3591 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3592 it's used from the C level.
3593
3594 * process.c: Use the same condition for POLL_FOR_INPUT in both
3595 keyboard.c and process.c (bug#1858).
3596
3597 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3598
3599 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3600 (Fgnutls_boot): Use it.
3601
3602 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3603
3604 * doc.c (Fsubstitute_command_keys): Revert last change.
3605
3606 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3607
3608 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3609 quotes the next character, and doesn't affect other longer
3610 sequences (bug#8935).
3611
3612 * lread.c (syms_of_lread): Clarify that is isn't only
3613 `eval-buffer' and `eval-defun' that's affected by
3614 `lexical-binding' (bug#8460).
3615
3616 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3617
3618 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3619 bidi redisplay when a line includes both an image and is truncated.
3620
3621 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3622
3623 Fix minor problems found by static checking.
3624 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3625 (elsz): Now a signed constant, not a size_t var. We prefer signed
3626 types to unsigned, to avoid integer comparison confusion. Without
3627 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3628 "cannot optimize loop, the loop counter may overflow", a symptom
3629 of the confusion.
3630 * indent.c (Fvertical_motion): Mark locals as initialized.
3631 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3632
3633 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3634
3635 * search.c (Fre_search_backward): Mention `case-fold-search' in
3636 all the re_search_* functions (bug#8138).
3637
3638 * keyboard.c (Fopen_dribble_file): Document when the file is
3639 closed (bug#8056).
3640
3641 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3642
3643 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3644 bidi_cache_idx.
3645
3646 Support bidi reordering of display and overlay strings.
3647 * xdisp.c (compute_display_string_pos)
3648 (compute_display_string_end): Accept additional argument STRING.
3649 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3650 (reseat_to_string): Initialize bidi_it->string.s and
3651 bidi_it->string.schars.
3652 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3653 NULL (avoids a crash in bidi_paragraph_init).
3654 Initialize itb.string.lstring.
3655 (init_iterator): Call bidi_init_it only of a valid
3656 buffer position was specified. Initialize paragraph_embedding to
3657 L2R.
3658 (reseat_to_string): Initialize the bidi iterator.
3659 (display_string): If we need to ignore text properties of
3660 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3661 original value of -1 will not work with bidi.)
3662 (compute_display_string_pos): First arg is now struct
3663 `text_pos *'; all callers changed. Support display properties on
3664 Lisp strings.
3665 (compute_display_string_end): Support display properties on Lisp
3666 strings.
3667 (init_iterator, reseat_1, reseat_to_string): Initialize the
3668 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3669 when iterating on a string not from display properties).
3670 (compute_display_string_pos, compute_display_string_end):
3671 Fix calculation of the object to scan. Fixes an error when using
3672 arrow keys.
3673 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3674 base_level_stop; instead, set base_level_stop to BEGV.
3675 Fixes crashes in vertical-motion.
3676 (next_element_from_buffer): Improve commentary for when
3677 the iterator is before prev_stop.
3678 (init_iterator): Initialize bidi_p from the default value of
3679 bidi-display-reordering, not from buffer-local value. Use the
3680 buffer-local value only if initializing for buffer iteration.
3681 (handle_invisible_prop): Support invisible properties on strings
3682 that are being bidi-reordered.
3683 (set_iterator_to_next): Support bidi reordering of C strings and
3684 Lisp strings.
3685 (next_element_from_string): Support bidi reordering of Lisp
3686 strings.
3687 (handle_stop_backwards): Support Lisp strings as well.
3688 (display_string): Support display of R2L glyph rows.
3689 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3690 (init_iterator): Don't initialize it->bidi_p for strings
3691 here.
3692 (reseat_to_string): Initialize it->bidi_p for strings here.
3693 (next_element_from_string, next_element_from_c_string)
3694 (next_element_from_buffer): Add xassert's for correspondence
3695 between IT's object being iterated and it->bidi_it.string
3696 structure.
3697 (face_before_or_after_it_pos): Support bidi iteration.
3698 (next_element_from_c_string): Handle the case of the first string
3699 character that is not the first one in the visual order.
3700 (get_visually_first_element): New function, refactored from common
3701 parts of next_element_from_buffer, next_element_from_string, and
3702 next_element_from_c_string.
3703 (tool_bar_lines_needed, redisplay_tool_bar)
3704 (display_menu_bar): Force left-to-right direction. Add a FIXME
3705 comment for making that be controlled by a user option.
3706 (push_it, pop_it): Save and restore the state of the
3707 bidi iterator. Save and restore the bidi_p flag.
3708 (pop_it): Iterate out of display property for string iteration as
3709 well.
3710 (iterate_out_of_display_property): Support iteration over strings.
3711 (handle_single_display_spec): Set up it->bidi_it for iteration
3712 over a display string, and call bidi_init_it.
3713 (handle_single_display_spec, next_overlay_string)
3714 (get_overlay_strings_1, push_display_prop): Set up the bidi
3715 iterator for displaying display or overlay strings.
3716 (forward_to_next_line_start): Don't use the shortcut if
3717 bidi-iterating.
3718 (back_to_previous_visible_line_start): If handle_display_prop
3719 pushed the iterator stack, restore the internal state of the bidi
3720 iterator by calling bidi_pop_it same number of times.
3721 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3722 and we are bidi-iterating, don't decrement the iterator position;
3723 instead, set the first_elt flag in the bidi iterator, to produce
3724 the same effect.
3725 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3726 (push_display_prop): xassert that we are iterating a buffer.
3727 (push_it, pop_it): Save and restore paragraph_embedding member.
3728 (handle_single_display_spec, next_overlay_string)
3729 (get_overlay_strings_1, reseat_1, reseat_to_string)
3730 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3731 correctly. Don't assume unibyte strings are not bidi-reordered.
3732 (compute_display_string_pos)
3733 (compute_display_string_end): Fix handling the case of C string.
3734 (push_it, pop_it): Save and restore from_disp_prop_p.
3735 (handle_single_display_spec, push_display_prop): Set the
3736 from_disp_prop_p flag.
3737 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3738 (pop_it): Call iterate_out_of_display_property only if we are
3739 popping after iteration over a string that came from a display
3740 property. Fix a typo in popping stretch info. Add an assertion
3741 for verifying that the iterator position is in sync with the bidi
3742 iterator.
3743 (handle_single_display_spec, get_overlay_strings_1)
3744 (push_display_prop): Fix initialization of paragraph direction for
3745 string when that of the parent object is not yet determined.
3746 (reseat_1): Call bidi_init_it to resync the bidi
3747 iterator with IT's position. (Bug#7616)
3748 (find_row_edges): If ROW->start.pos gives position
3749 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3750 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3751 Reset the from_disp_prop_p flag.
3752 (SAVE_IT, RESTORE_IT): New macros.
3753 (pos_visible_p, face_before_or_after_it_pos)
3754 (back_to_previous_visible_line_start)
3755 (move_it_in_display_line_to, move_it_in_display_line)
3756 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3757 (try_scrolling, redisplay_window, display_line): Use them when
3758 saving a temporary copy of the iterator and restoring it back.
3759 (back_to_previous_visible_line_start, reseat_1)
3760 (init_iterator): Empty the bidi cache "stack".
3761 (move_it_in_display_line_to): If iterator ended up at
3762 EOL, but we never saw any buffer positions smaller than
3763 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3764 motion in bidi-reordered lines.
3765 (move_it_in_display_line_to): Record prev_method and prev_pos
3766 immediately before the call to set_iterator_to_next. Fixes cursor
3767 motion in bidi-reordered lines with stretch glyphs and strings
3768 displayed in margins. (Bug#8133) (Bug#8867)
3769 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3770 TO_CHARPOS.
3771 (pos_visible_p): Support positions in bidi-reordered lines.
3772 Save and restore bidi cache.
3773
3774 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3775 (bidi_paragraph_info): Delete unused struct.
3776 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3777 (bidi_cache_start): New variable.
3778 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3779 to zero.
3780 (bidi_cache_fetch_state, bidi_cache_search)
3781 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3782 (bidi_cache_find, bidi_peek_at_next_level)
3783 (bidi_level_of_next_char, bidi_find_other_level_edge)
3784 (bidi_move_to_visually_next): Compare cache index with
3785 bidi_cache_start rather than with zero.
3786 (bidi_fetch_char): Accept new argument STRING; all callers
3787 changed. Support iteration over a string. Support strings with
3788 display properties. Support unibyte strings. Fix the type of
3789 `len' according to what STRING_CHAR_AND_LENGTH expects.
3790 (bidi_paragraph_init, bidi_resolve_explicit_1)
3791 (bidi_resolve_explicit, bidi_resolve_weak)
3792 (bidi_level_of_next_char, bidi_move_to_visually_next):
3793 Support iteration over a string.
3794 (bidi_set_sor_type, bidi_resolve_explicit_1)
3795 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3796 can now be zero (for strings); special values 0 and -1 were
3797 changed to -1 and -2, respectively.
3798 (bidi_char_at_pos): New function.
3799 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3800 Call it instead of FETCH_MULTIBYTE_CHAR.
3801 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3802 initialized to valid values.
3803 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3804 values.
3805 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3806 the test for valid cached positions. Fix the logic for looking up
3807 the sentinel state in the cache. GCPRO the Lisp string we are
3808 iterating.
3809 (bidi_push_it, bidi_pop_it): New functions.
3810 (bidi_initialize): Initialize the bidi cache start stack pointer.
3811 (bidi_cache_ensure_space): New function, refactored from part of
3812 bidi_cache_iterator_state. Don't assume the required size is just
3813 one BIDI_CACHE_CHUNK away.
3814 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3815 (bidi_count_bytes, bidi_char_at_pos): New functions.
3816 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3817 always valid if bidi_cache_idx is valid.
3818 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3819 is valid if it's going to be used.
3820 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3821 (bidi_cache_fetch_state, bidi_cache_search)
3822 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3823 (bidi_cache_iterator_state, bidi_cache_find)
3824 (bidi_find_other_level_edge, bidi_cache_start_stack):
3825 All variables related to cache indices are now EMACS_INT.
3826
3827 * dispextern.h (struct bidi_string_data): New structure.
3828 (struct bidi_it): New member `string'. Make flag members be 1-bit
3829 fields, and put them last in the struct.
3830 (compute_display_string_pos, compute_display_string_end):
3831 Update prototypes.
3832 (bidi_push_it, bidi_pop_it): Add prototypes.
3833 (struct iterator_stack_entry): New members bidi_p,
3834 paragraph_embedding, and from_disp_prop_p.
3835 (struct it): Member bidi_p is now a bit field 1 bit wide.
3836 (bidi_shelve_cache, bidi_unshelve_cache):
3837 Declare prototypes.
3838
3839 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3840 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3841 and vector-like objects.
3842
3843 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3844 cache around display iteration.
3845
3846 * window.c (Fwindow_end, window_scroll_pixel_based)
3847 (displayed_window_lines, Frecenter): Save and restore the bidi
3848 cache around display iteration.
3849
3850 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3851
3852 * editfns.c (Fdelete_region): Clarify the use of the named
3853 parameters (bug#6788).
3854
3855 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3856
3857 * indent.c (Fvertical_motion): Set and restore w->pointm when
3858 saving and restoring the window's buffer (Bug#9006).
3859
3860 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3861
3862 * editfns.c (Fstring_to_char): Clarify just what is returned
3863 (bug#6576). Text by Eli Zaretskii.
3864
3865 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3868
3869 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3870
3871 * buffer.c (mmap_find): Fix a typo.
3872
3873 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3874
3875 Fix execution of x selection hooks.
3876 * xselect.c (Qx_lost_selection_functions)
3877 (Qx_sent_selection_functions): New vars.
3878 (syms_of_xselect): DEFSYM them.
3879 (x_handle_selection_request): Pass Qx_sent_selection_functions
3880 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3881 (x_handle_selection_clear,x_clear_frame_selections):
3882 Pass Qx_lost_selection_functions rather than
3883 Vx_lost_selection_functions to Frun_hook_with_args.
3884
3885 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3886
3887 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3888 The old code sometimes used this field without initializing it.
3889
3890 * alloc.c (gc_sweep): Don't read past end of array.
3891 In theory, the old code could also have corrupted Emacs internals,
3892 though it'd be very unlikely.
3893
3894 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3895
3896 * character.c (Fcharacterp): Don't advertise optional ignored
3897 argument. (Bug#4026)
3898
3899 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3900
3901 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3902 key" (bug#4257).
3903
3904 * window.c (Fset_window_start): Doc fix (bug#4199).
3905 (Fset_window_hscroll): Ditto.
3906
3907 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 Fix minor new problems caught by GCC 4.6.1.
3910 * term.c (init_tty): Remove unused local.
3911 * xsettings.c (store_monospaced_changed): Define this function only
3912 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3913 not used otherwise.
3914
3915 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3916
3917 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3918
3919 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3920
3921 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3922 are the mini-buffer and the echo area (bug#3320).
3923
3924 * term.c (init_tty): Remove support for supdup, c10 and perq
3925 terminals, which are no longer supported (bug#1482).
3926
3927 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3928
3929 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3930
3931 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3932
3933 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3934 for non-popups (Bug#3642).
3935
3936 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3937
3938 * alloc.c (reset_malloc_hooks): Protoize.
3939 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3940 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3941 * cm.c (losecursor): Likewise.
3942 * data.c (fmod): Likewise.
3943 * dispnew.c (swap_glyphs_in_rows): Likewise.
3944 * emacs.c (memory_warning_signal): Likewise.
3945 * floatfns.c (float_error): Likewise.
3946 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3947 (otf_open, font_otf_capability, generate_otf_features)
3948 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3949 Likewise.
3950 * image.c (pbm_read_file): Likewise.
3951 * indent.c (string_display_width): Likewise.
3952 * intervals.c (check_for_interval, search_for_interval)
3953 (inc_interval_count, count_intervals, root_interval)
3954 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3955 * lread.c (defalias): Likewise.
3956 * ralloc.c (r_alloc_check): Likewise.
3957 * regex.c (set_image_of_range_1, set_image_of_range)
3958 (regex_grow_registers): Likewise.
3959 * sysdep.c (strerror): Likewise.
3960 * termcap.c (valid_filename_p, tprint, main): Likewise.
3961 * tparam.c (main): Likewise.
3962 * unexhp9k800.c (run_time_remap, save_data_space)
3963 (update_file_ptrs, read_header, write_header, calculate_checksum)
3964 (copy_file, copy_rest, display_header): Likewise.
3965 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3966 Likewise.
3967 * xdisp.c (check_it): Likewise.
3968 * xfaces.c (register_color, unregister_color, unregister_colors):
3969 Likewise.
3970 * xfns.c (print_fontset_result): Likewise.
3971 * xrdb.c (member, fatal, main): Likewise.
3972
3973 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3974
3975 Fix minor problems found by static checking (Bug#9031).
3976 * chartab.c (char_table_set_range, map_sub_char_table):
3977 Remove unused locals.
3978 (uniprop_table): Now static.
3979 * composite.c (_work_char): Remove unused static var.
3980
3981 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3982
3983 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3984
3985 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * gtkutil.c (qttip_cb): Remove code without function.
3988
3989 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3990
3991 * w32.c (pthread_sigmask): New stub.
3992
3993 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3994
3995 Use pthread_sigmask, not sigprocmask (Bug#9010).
3996 sigprocmask is portable only for single-threaded applications, and
3997 Emacs can be multi-threaded when it uses GTK.
3998 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3999 (LIBES): Use it.
4000 * callproc.c (Fcall_process):
4001 * process.c (create_process):
4002 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4003 Use pthread_sigmask, not sigprocmask.
4004
4005 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4006
4007 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4008 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4009 wrong (Bug#8591).
4010
4011 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4012
4013 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4014 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4015 (xg_hide_tooltip): Fix comment.
4016
4017 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4018 in registerServicesMenuSendTypes.
4019 (validRequestorForSendType): Don't check ns_return_types.
4020
4021 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4022 ns_return_type.
4023
4024 2011-07-08 Jason Rumney <jasonr@gnu.org>
4025
4026 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4027 SH_SHOW for hidden windows (Bug#5482).
4028
4029 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4030 frame struct members of non-existent frames (Bug#6284).
4031
4032 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4033
4034 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4035 variable firstTime not needed on OSX >= 10.6.
4036 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4037 >= 10.5. Use setKnobProportion, setDoubleValue.
4038
4039 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4040 (MAC_OS_X_VERSION_10_5): Define if not defined.
4041 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4042 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4043 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4044
4045 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4046 cString and lossyCString on OSX >= 10.4
4047
4048 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4049 sizeToFit on OSX >= 10.2.
4050
4051 * nsimage.m (allocInitFromFile): Don't use deprecated method
4052 bestRepresentationForDevice on OSX >= 10.6.
4053
4054 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4055 to avoid warning.
4056
4057 * emacs.c: Declare unexec_init_emacs_zone.
4058
4059 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4060
4061 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4062
4063 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4064 on svcsMenu (Bug#8842).
4065
4066 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4067 ns_return_types.
4068 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4069
4070 * nsterm.m (QUTF8_STRING): Declare.
4071 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4072 (validRequestorForSendType): Return type is (id).
4073 Change indexOfObjectIdenticalTo to indexOfObject.
4074 Check if we have local selection before returning self (Bug#8842).
4075 (writeSelectionToPasteboard): Put local selection into paste board
4076 if we have a local selection (Bug#8842).
4077 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4078
4079 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4080 (ns_get_local_selection): Declare.
4081
4082 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4083
4084 * keymap.c (describe_map_tree): Don't insert a double newline at
4085 the end of the buffer (bug#1169) and return whether we inserted
4086 something.
4087
4088 * callint.c (Fcall_interactively): Change "reading args" to
4089 "providing args" to try to clarify what it does (bug#1010).
4090
4091 2011-07-07 Kenichi Handa <handa@m17n.org>
4092
4093 * composite.c (composition_compute_stop_pos): Ignore a static
4094 composition starting before CHARPOS (Bug#8915).
4095
4096 * xdisp.c (handle_composition_prop): Likewise.
4097
4098 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4099
4100 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4101 (Bug#9015)
4102
4103 2011-07-07 Kenichi Handa <handa@m17n.org>
4104
4105 * character.h (unicode_category_t): New enum type.
4106
4107 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4108 (Qchar_code_property_table): New variable.
4109 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4110 (UNIPROP_COMPRESSED_FORM_P): New macros.
4111 (char_table_ascii): Uncompress the compressed values.
4112 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4113 Uncompress the compressed values.
4114 (sub_char_table_ref_and_range): Likewise.
4115 (char_table_ref_and_range): Uncompress the compressed values.
4116 (sub_char_table_set): New arg is_uniprop. Callers changed.
4117 Uncompress the compressed values.
4118 (sub_char_table_set_range): Args changed. Callers changed.
4119 (char_table_set_range): Adjuted for the above change.
4120 (map_sub_char_table): Delete args default_val and parent. Add arg
4121 top. Give decoded values to a Lisp function.
4122 (map_char_table): Adjust for the above change. Give decoded
4123 values to a Lisp function. Gcpro more variables.
4124 (uniprop_table_uncompress)
4125 (uniprop_decode_value_run_length): New functions.
4126 (uniprop_decoder, uniprop_decoder_count): New variables.
4127 (uniprop_get_decoder, uniprop_encode_value_character)
4128 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4129 New functions.
4130 (uniprop_encoder, uniprop_encoder_count): New variables.
4131 (uniprop_get_encoder, uniprop_table)
4132 (Funicode_property_table_internal, Fget_unicode_property_internal)
4133 (Fput_unicode_property_internal): New functions.
4134 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4135 Sunicode_property_table_internal, Sget_unicode_property_internal,
4136 and Sput_unicode_property_internal. Defvar_lisp
4137 char-code-property-alist.
4138
4139 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4140 Vunicode_category_table.
4141
4142 * font.c (font_range): Adjust for the change of
4143 Vunicode_category_table.
4144
4145 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4146
4147 * m/iris4d.h: Remove file, move contents ...
4148 * s/irix6-5.h: ... here.
4149
4150 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 Remove unportable assumption about struct layout (Bug#8884).
4153 * alloc.c (mark_buffer):
4154 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4155 (clone_per_buffer_values): Don't assume that
4156 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4157 This isn't true in general, and it's particularly not true
4158 if Emacs is configured with --with-wide-int.
4159 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4160 New macros, used in the buffer.c change.
4161
4162 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4163
4164 * xsettings.c: Use both GConf and GSettings if both are available.
4165 (store_config_changed_event): Add comment.
4166 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4167 (store_tool_bar_style_changed): New functions.
4168 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4169 (struct xsettings): Move font inside HAVE_XFT.
4170 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4171 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4172 Move inside HAVE_XFT.
4173 (something_changed_gsettingsCB): Rename from something_changedCB.
4174 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4175 also.
4176 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4177 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4178 (something_changed_gconfCB): Rename from something_changedCB.
4179 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4180 (parse_settings): Move check for font inside HAVE_XFT.
4181 (read_settings, apply_xft_settings): Add comment.
4182 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4183 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4184 call store_font_name_changed.
4185 (xft_settings_event): Add comment.
4186 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4187 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4188 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4189 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4190 (xsettings_initialize): Call init_gsettings last.
4191 (xsettings_get_system_font, xsettings_get_system_normal_font):
4192 Add comment.
4193
4194 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4195
4196 Random fixes. E.g., (random) never returned negative values.
4197 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4198 subseconds part to the entropy, as that's a bit more random.
4199 Prefer signed to unsigned, since the signedness doesn't matter and
4200 in general we prefer signed. When given a limit, use a
4201 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4202 latter isn't right if USE_2_TAGS_FOR_INTS.
4203 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4204 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4205
4206 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4207
4208 * textprop.c (text_property_stickiness):
4209 Obey Vtext_property_default_nonsticky.
4210 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4211 * w32fns.c (syms_of_w32fns):
4212 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4213
4214 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4217 This is more efficient than Ffile_directory_p and avoids a minor race.
4218
4219 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4220
4221 * buffer.c (Foverlay_put): Say what the return value is
4222 (bug#7835).
4223
4224 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4225 is a directory before asking whether to use the file name
4226 (bug#7564).
4227 (barf_or_query_if_file_exists): Make the "File is a directory"
4228 error be more correct.
4229
4230 * fns.c (Frequire): Remove the mention of the .gz files, since
4231 that's installation-specific, but keep the mention of
4232 `get-load-suffixes'.
4233
4234 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4237 Report string overflow if the output is too long.
4238
4239 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4242 (syms_of_gnutls): Remove duplicate DEFSYM for
4243 Qgnutls_bootprop_verify_hostname_error, an error for
4244 Qgnutls_bootprop_verify_error (which is no longer used).
4245
4246 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4247 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4248 Also (re)move comments that are misplaced or no longer relevant.
4249
4250 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4251
4252 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4253
4254 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4255
4256 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4257 and background color parameters if they have been changed.
4258
4259 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4260
4261 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4262
4263 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4264
4265 * xsettings.c (SYSTEM_FONT): Define only when used.
4266 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4267
4268 * keymap.c (access_keymap_1): Now static.
4269
4270 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4271
4272 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4273 leave any prefix arg for the up event (Bug#1586).
4274
4275 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4276
4277 * lread.c (syms_of_lread): Mention single symbols defined by
4278 `defvar' or `defconst' (bug#7154).
4279
4280 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4281 (Frequire): Mention get-load-suffixes.
4282
4283 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4284
4285 * window.h (window): Remove clone_number slot.
4286 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4287 Remove.
4288 (make_parent_window, make_window, saved_window)
4289 (Fset_window_configuration, save_window_save): Don't deal with
4290 clone numbers.
4291 * buffer.c (Qclone_number): Remove declaration.
4292 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4293
4294 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4295
4296 Add multiple inheritance to keymaps.
4297 * keymap.c (Fmake_composed_keymap): New function.
4298 (Fset_keymap_parent): Simplify.
4299 (fix_submap_inheritance): Remove.
4300 (access_keymap_1): New function extracted from access_keymap to handle
4301 embedded parents and handle lists of maps.
4302 (access_keymap): Use it.
4303 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4304 (Fcopy_keymap): Handle embedded parents.
4305 (Fcommand_remapping, define_as_prefix): Simplify.
4306 (Fkey_binding): Simplify.
4307 (syms_of_keymap): Move minibuffer-local-completion-map,
4308 minibuffer-local-filename-completion-map,
4309 minibuffer-local-must-match-map, and
4310 minibuffer-local-filename-must-match-map to Elisp.
4311 (syms_of_keymap): Defsubr make-composed-keymap.
4312 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4313 (parse_menu_item): Trivial simplification.
4314
4315 2011-07-01 Glenn Morris <rgm@gnu.org>
4316
4317 * Makefile.in (SETTINGS_LIBS): Fix typo.
4318
4319 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4320
4321 * coding.c (Fencode_coding_string): Record the last coding system
4322 used, as the function doc string says (bug#8738).
4323
4324 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4325
4326 * xsettings.c (store_monospaced_changed): Take new font as arg and
4327 check for change against current_mono_font.
4328 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4329 (emacs_settings_constructor, emacs_settings_get_property)
4330 (emacs_settings_set_property, emacs_settings_class_init)
4331 (emacs_settings_init, gsettings_obj): Remove.
4332 (something_changedCB): New function for HAVE_GSETTINGS.
4333 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4334 with value as argument.
4335 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4336 g_settings_new (Bug#8967). Do not create gsettings_obj.
4337 Remove calls to g_settings_bind. Connect something_changedCB to
4338 "changed".
4339
4340 * xgselect.c: Add defined (HAVE_GSETTINGS).
4341 (xgselect_initialize): Ditto.
4342
4343 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4344 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4345 xg_select.
4346
4347 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4348
4349 * eval.c (struct backtrace): Simplify and port the data structure.
4350 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4351 signed bit field, as this assumption is not portable and it makes
4352 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4353 "char debug_on_exit : 1" as this is not portable either; instead,
4354 use the portable "unsigned int debug_on_exit : 1". Remove unused
4355 member evalargs. Remove obsolete comments about cc bombing out.
4356
4357 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4358
4359 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4360 Let HAVE_GSETTINGS override HAVE_GCONF.
4361 (store_monospaced_changed): New function.
4362 (EMACS_SETTINGS): A new type derived from GObject to handle
4363 GSettings notifications.
4364 (emacs_settings_constructor, emacs_settings_get_property)
4365 (emacs_settings_set_property, emacs_settings_class_init):
4366 New functions.
4367 (gsettings_client, gsettings_obj): New variables.
4368 (GSETTINGS_SCHEMA): New define.
4369 (something_changedCB): Call store_monospaced_changed.
4370 (init_gsettings): New function.
4371 (xsettings_initialize): Call init_gsettings.
4372 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4373 to NULL.
4374
4375 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4376 GCONF_CFLAGS/LIBS.
4377
4378 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4379
4380 * window.c (resize_root_window, grow_mini_window)
4381 (shrink_mini_window): Rename Qresize_root_window to
4382 Qwindow_resize_root_window and Qresize_root_window_vertically to
4383 Qwindow_resize_root_window_vertically.
4384
4385 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4388
4389 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4390
4391 * makefile.w32-in: Redesign dependencies so they reflect more
4392 clearly which files are directly included by each source file,
4393 and not through other includes.
4394
4395 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4396
4397 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4398 (sort_overlays, overlay_strings): When an overlay's clone number
4399 matches the window's clone number process the overlay even if
4400 the overlay's window property doesn't match the current window.
4401
4402 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4403 (Fwindow_hchild): Rename to Fwindow_left_child.
4404 (Fwindow_next): Rename to Fwindow_next_sibling.
4405 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4406 (resize_window_check): Rename to window_resize_check.
4407 (resize_window_apply): Rename to window_resize_apply.
4408 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4409 (Fdelete_other_windows_internal, resize_frame_windows)
4410 (Fsplit_window_internal, Fdelete_window_internal)
4411 (grow_mini_window, shrink_mini_window)
4412 (Fresize_mini_window_internal): Fix callers accordingly.
4413
4414 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4415
4416 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4417 (emacs_fixed_set_min_size): Remove.
4418 (emacs_fixed_new): Take frame as argument.
4419
4420 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4421 (_EmacsFixedPrivate): Remove minwidth/height.
4422 Add struct frame *f.
4423 (emacs_fixed_init): Initialize priv->f.
4424 (get_parent_class, emacs_fixed_set_min_size): Remove.
4425 (emacs_fixed_new): Set priv->f to argument.
4426 (emacs_fixed_get_preferred_width)
4427 (emacs_fixed_get_preferred_height): Use min_width/height from
4428 frames size_hint to set minimum and natural (Bug#8919).
4429 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4430 and use min_width/height from frames size_hint to set
4431 min_width/height (Bug#8919).
4432
4433 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4434 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4435 Fix indentation.
4436
4437 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4438
4439 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4440 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4441 called at ZV.
4442
4443 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4444
4445 * process.c (wait_reading_process_output): Bypass select if
4446 waiting for a cell while ignoring keyboard input, and input is
4447 pending. Suggested by Jan Djärv (Bug#8869).
4448
4449 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 Use gnulib's dup2 module instead of rolling our own.
4452 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4453
4454 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4455
4456 * dispnew.c (scrolling_window): Before scrolling, turn off a
4457 mouse-highlight in the window being scrolled.
4458
4459 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4460
4461 Move DEFSYM to lisp.h and use everywhere.
4462
4463 * character.h (DEFSYM): Move declaration...
4464 * lisp.h (DEFSYM): ...here.
4465
4466 * gnutls.c:
4467 * minibuf.c:
4468 * w32menu.c:
4469 * w32proc.c:
4470 * w32select.c: Don't include character.h.
4471
4472 * alloc.c (syms_of_alloc):
4473 * buffer.c (syms_of_buffer):
4474 * bytecode.c (syms_of_bytecode):
4475 * callint.c (syms_of_callint):
4476 * casefiddle.c (syms_of_casefiddle):
4477 * casetab.c (init_casetab_once):
4478 * category.c (init_category_once, syms_of_category):
4479 * ccl.c (syms_of_ccl):
4480 * cmds.c (syms_of_cmds):
4481 * composite.c (syms_of_composite):
4482 * dbusbind.c (syms_of_dbusbind):
4483 * dired.c (syms_of_dired):
4484 * dispnew.c (syms_of_display):
4485 * doc.c (syms_of_doc):
4486 * editfns.c (syms_of_editfns):
4487 * emacs.c (syms_of_emacs):
4488 * eval.c (syms_of_eval):
4489 * fileio.c (syms_of_fileio):
4490 * fns.c (syms_of_fns):
4491 * frame.c (syms_of_frame):
4492 * fringe.c (syms_of_fringe):
4493 * insdel.c (syms_of_insdel):
4494 * keymap.c (syms_of_keymap):
4495 * lread.c (init_obarray, syms_of_lread):
4496 * macros.c (syms_of_macros):
4497 * msdos.c (syms_of_msdos):
4498 * print.c (syms_of_print):
4499 * process.c (syms_of_process):
4500 * search.c (syms_of_search):
4501 * sound.c (syms_of_sound):
4502 * syntax.c (init_syntax_once, syms_of_syntax):
4503 * terminal.c (syms_of_terminal):
4504 * textprop.c (syms_of_textprop):
4505 * undo.c (syms_of_undo):
4506 * w32.c (globals_of_w32):
4507 * window.c (syms_of_window):
4508 * xdisp.c (syms_of_xdisp):
4509 * xfaces.c (syms_of_xfaces):
4510 * xfns.c (syms_of_xfns):
4511 * xmenu.c (syms_of_xmenu):
4512 * xsettings.c (syms_of_xsettings):
4513 * xterm.c (syms_of_xterm): Use DEFSYM.
4514
4515 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4516
4517 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4518
4519 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 Integer and buffer overflow fixes (Bug#8873).
4522
4523 * print.c (printchar, strout): Check for string overflow.
4524 (PRINTPREPARE, printchar, strout):
4525 Don't set size unless allocation succeeds.
4526
4527 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4528 for sizes. Check for string overflow more accurately.
4529 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4530
4531 * macros.c: Integer and buffer overflow fixes.
4532 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4533 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4534 Use ptrdiff_t, not int, for sizes.
4535 Don't increment bufsize until after realloc succeeds.
4536 Check for size-calculation overflow.
4537 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4538
4539 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4540
4541 * lread.c: Integer overflow fixes.
4542 (read_integer): Radix is now EMACS_INT, not int,
4543 to improve quality of diagnostics for out-of-range radices.
4544 Calculate buffer size correctly for out-of-range radices.
4545 (read1): Check for integer overflow in radices, and in
4546 read-circle numbers.
4547 (read_escape): Avoid int overflow.
4548 (Fload, openp, read_buffer_size, read1)
4549 (substitute_object_recurse, read_vector, read_list, map_obarray):
4550 Use ptrdiff_t, not int, for sizes.
4551 (read1): Use EMACS_INT, not int, for sizes.
4552 Check for size overflow.
4553
4554 * image.c (cache_image): Check for size arithmetic overflow.
4555
4556 * lread.c: Integer overflow issues.
4557 (saved_doc_string_size, saved_doc_string_length)
4558 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4559 Now ptrdiff_t, not int.
4560 (read1): Don't assume doc string length fits in int. Check for
4561 out-of-range doc string lengths.
4562 (read_list): Don't assume file position fits in int.
4563 (read_escape): Check for hex character overflow.
4564
4565 2011-06-22 Leo Liu <sdl.web@gmail.com>
4566
4567 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4568 Move to minibuffer.el.
4569
4570 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4573 The following patches are for when GLYPH_DEBUG && !XASSERT.
4574 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4575 * dispnew.c (flush_stdout):
4576 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4577 Mark as externally visible.
4578 * dispnew.c (check_window_matrix_pointers): Now static.
4579 * dispnew.c (window_to_frame_vpos):
4580 * xfns.c (unwind_create_frame):
4581 * xterm.c (x_check_font): Remove unused local.
4582 * scroll.c (CHECK_BOUNDS):
4583 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4584 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4585 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4586 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4587 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4588 Now static.
4589 (debug_method_add): Use va_list and vsprintf rather than relying
4590 on undefined behavior with wrong number of arguments.
4591 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4592 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4593 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4594 since we're not interested in debugging glyphs with old libraries.
4595 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4596 GCC 4.6.0's static checking.
4597
4598 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 Integer overflow and signedness fixes (Bug#8873).
4601 A few related buffer overrun fixes, too.
4602
4603 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4604
4605 * dispextern.h (struct face.stipple):
4606 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4607 (x_bitmap_mask, x_allocate_bitmap_record)
4608 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4609 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4610 (x_create_bitmap_from_xpm_data):
4611 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4612 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4613 (.bitmaps_last):
4614 * xfaces.c (load_pixmap):
4615 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4616 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4617 (.bitmaps_last, struct x_output.icon_bitmap):
4618 Use ptrdiff_t, not int, for bitmap indexes.
4619 (x_allocate_bitmap_record): Check for size overflow.
4620 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4621
4622 Use ptrdiff_t, not int, for overlay counts.
4623 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4624 * editfns.c (overlays_around, get_pos_property):
4625 * textprop.c (get_char_property_and_overlay):
4626 * xdisp.c (next_overlay_change, note_mouse_highlight):
4627 * xfaces.c (face_at_buffer_position):
4628 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4629 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4630 (Fnext_overlay_change, Fprevious_overlay_change)
4631 (mouse_face_overlay_overlaps, Foverlays_in):
4632 Use ptrdiff_t, not int, for sizes.
4633 (overlays_at, overlays_in): Check for size-calculation overflow.
4634
4635 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4636
4637 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4638 (x_session_initialize): Do not assume string length fits in int.
4639
4640 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4641 This is unlikely, but can occur if DPI is outlandish.
4642
4643 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4644 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4645
4646 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4647 * xrdb.c (magic_file_p, search_magic_path):
4648 Omit last arg SUFFIX; it was always 0. All callers changed.
4649 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4650
4651 * xfont.c (xfont_match): Avoid need for strlen.
4652
4653 * xfns.c: Don't assume strlen fits in int.
4654 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4655
4656 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4657 not unsigned long, as we prefer signed integers. All callers changed.
4658 Detect integer overflow in repeat count.
4659 (message_dolog): Don't assume print length fits in 39 bytes.
4660 (display_mode_element): Don't assume strlen fits in int.
4661
4662 * termcap.c: Don't assume sizes fit in int and never overflow.
4663 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4664 (gobble_line): Check for size-calculation overflow.
4665
4666 * minibuf.c (Fread_buffer):
4667 * lread.c (intern, intern_c_string):
4668 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4669 Don't assume string length fits in int.
4670
4671 * keyboard.c (parse_tool_bar_item):
4672 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4673
4674 * font.c: Don't assume string length fits in int.
4675 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4676 Use ptrdiff_t, not int.
4677 (font_intern_prop): Don't assume string length fits in int.
4678 Don't assume integer property fits in fixnum.
4679 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4680
4681 * filelock.c: Fix some buffer overrun and integer overflow issues.
4682 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4683 Reformulate so as not to need the command string.
4684 Invoke gzip -cd rather than gunzip, as it's more portable.
4685 (lock_info_type, lock_file_1, lock_file):
4686 Don't assume pid_t and time_t fit in unsigned long.
4687 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4688 (current_lock_owner): Prefer signed type for sizes.
4689 Use memcpy, not strncpy, where memcpy is what is really wanted.
4690 Don't assume (via atoi) that time_t and pid_t fit in int.
4691 Check for time_t and/or pid_t out of range, e.g., via a network share.
4692 Don't alloca where an auto var works fine.
4693
4694 * fileio.c: Fix some integer overflow issues.
4695 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4696 Don't assume string length fits in int.
4697 (directory_file_name): Don't assume string length fits in long.
4698 (make_temp_name): Don't assume pid fits in int, or that its print
4699 length is less than 20.
4700
4701 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4702
4703 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4704
4705 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4706
4707 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4708 We prefer signed integers, even for size calculations.
4709
4710 * emacs.c: Don't assume string length fits in 'int'.
4711 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4712 (main): Don't invoke strlen when not needed.
4713
4714 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4715 (XD_DEBUG_MESSAGE): Don't waste a byte.
4716
4717 * callproc.c (getenv_internal_1, getenv_internal)
4718 (Fgetenv_internal):
4719 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4720
4721 * lread.c (invalid_syntax): Omit length argument.
4722 All uses changed. This doesn't fix a bug, but it simplifies the
4723 code away from its former Hollerith-constant appearance, and it's
4724 one less 'int' to worry about when looking at integer-overflow issues.
4725 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4726
4727 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4728 This didn't break anything, but it didn't help either.
4729 It's confusing to put a bogus integer in a place where the actual
4730 value does not matter.
4731 (LIST_END_P): Remove unused macro and its bogus comment.
4732 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4733
4734 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4735 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4736 implementation.
4737 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4738 We prefer signed types, and the value cannot exceed the EMACS_INT
4739 range anyway (because otherwise the length would not be representable).
4740 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4741 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4742 This avoids a GCC warning when WIDE_EMACS_INT.
4743
4744 * indent.c (sane_tab_width): New function.
4745 (current_column, scan_for_column, Findent_to, position_indentation)
4746 (compute_motion): Use it. This is just for clarity.
4747 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4748
4749 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4750
4751 * lisp.h (lint_assume): New macro.
4752 * composite.c (composition_gstring_put_cache):
4753 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4754
4755 * editfns.c, insdel.c:
4756 Omit unnecessary forward decls, to simplify future changes.
4757
4758 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4759
4760 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4761
4762 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4763 Use much-faster test for byte-length change.
4764 Don't assume string byte-length fits in 'int'.
4765 Check that character arg fits in 'int'.
4766 (mapcar1): Declare byte as byte, for clarity.
4767
4768 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4769
4770 * fns.c (concat): Catch string overflow earlier.
4771 Do not rely on integer wraparound.
4772
4773 * dispextern.h (struct it.overlay_strings_charpos)
4774 (struct it.selective): Now EMACS_INT, not int.
4775 * xdisp.c (forward_to_next_line_start)
4776 (back_to_previous_visible_line_start)
4777 (reseat_at_next_visible_line_start, next_element_from_buffer):
4778 Don't arbitrarily truncate the value of 'selective' to int.
4779
4780 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4781
4782 * composite.c: Don't truncate sizes to 'int'.
4783 (composition_gstring_p, composition_reseat_it)
4784 (composition_adjust_point): Use EMACS_INT, not int.
4785 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4786 not EMACS_UINT, for indexes.
4787
4788 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4789
4790 * buffer.c: Include <verify.h>.
4791 (struct sortvec.priority, struct sortstr.priority):
4792 Now EMACS_INT, not int.
4793 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4794 (struct sortstr.size, record_overlay_string)
4795 (struct sortstrlist.size, struct sortlist.used):
4796 Don't truncate size to int.
4797 (record_overlay_string): Check for size-calculation overflow.
4798 (init_buffer_once): Check at compile-time, not run-time.
4799
4800 2011-06-22 Jim Meyering <meyering@redhat.com>
4801
4802 Don't leak an XBM-image-sized buffer
4803 * image.c (xbm_load): Free the image buffer after using it.
4804
4805 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4806
4807 Port to Sun C.
4808 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4809 that Sun C diagnosed.
4810 * fns.c (secure_hash): Fix pointer signedness issue.
4811 * intervals.c (static_offset_intervals): New function.
4812 (offset_intervals): Use it.
4813
4814 2011-06-21 Leo Liu <sdl.web@gmail.com>
4815
4816 * deps.mk (fns.o):
4817 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4818 sha512.h.
4819
4820 * fns.c (secure_hash): Rename from crypto_hash_function and change
4821 the first arg to accept symbols.
4822 (Fsecure_hash): New primitive.
4823 (syms_of_fns): New symbols.
4824
4825 2011-06-20 Deniz Dogan <deniz@dogan.se>
4826
4827 * process.c (Fset_process_buffer): Clarify return value in
4828 docstring.
4829
4830 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4831
4832 * dispnew.c (add_window_display_history): Use BVAR.
4833
4834 * xdisp.c (debug_method_add): Use BVAR.
4835 (check_window_end, dump_glyph_matrix, dump_glyph)
4836 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4837
4838 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4839 Likewise.
4840
4841 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4842 check till after the cache is created in init_frame_faces.
4843
4844 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4845
4846 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4847
4848 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4851 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4852 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4853
4854 Improve buffer-overflow checking (Bug#8873).
4855 * fileio.c (Finsert_file_contents):
4856 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4857 Remove the old (too-loose) buffer overflow checks.
4858 They weren't needed, since make_gap checks for buffer overflow.
4859 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4860 The old code merely checked for Emacs fixnum overflow, and relied
4861 on undefined (wraparound) behavior. The new code avoids undefined
4862 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4863
4864 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4865 Tune. Don't use wider integers than needed. Don't use alloca.
4866 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4867
4868 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4869
4870 * insdel.c, lisp.h (buffer_overflow): New function.
4871 (insert_from_buffer_1, replace_range, replace_range_2):
4872 * insdel.c (make_gap_larger):
4873 * editfns.c (Finsert_char):
4874 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4875
4876 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4877
4878 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4879
4880 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4881
4882 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4883 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4884
4885 * fileio.c: Don't assume EMACS_INT fits in off_t.
4886 (emacs_lseek): New static function.
4887 (Finsert_file_contents, Fwrite_region): Use it.
4888 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4889
4890 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4891
4892 * fns.c: Don't overflow int when computing a list length.
4893 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4894 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4895 truncation on 64-bit hosts. Check for QUIT every
4896 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4897 faster and is responsive enough.
4898 (Flength): Report an error instead of overflowing an integer.
4899 (Fsafe_length): Return a float if the value is not representable
4900 as a fixnum. This shouldn't happen except in contrived situations.
4901 (Fnthcdr, Fsort): Don't assume list length fits in int.
4902 (Fcopy_sequence): Don't assume vector length fits in int.
4903
4904 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4905 (header_size, word_size): New constants.
4906 (allocate_vectorlike): Don't check size overflow here.
4907 (allocate_vector): Check it here instead, since this is the only
4908 caller of allocate_vectorlike that could cause overflow.
4909 Check that the new vector's length is representable as a fixnum.
4910
4911 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4912 The previous code was bogus. For example, next_almost_prime (32)
4913 returned 39, which is undesirable as it is a multiple of 3; and
4914 next_almost_prime (24) returned 25, which is a multiple of 5 so
4915 why was the code bothering to check for multiples of 7?
4916
4917 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4918
4919 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4920
4921 Variadic C functions now count arguments with ptrdiff_t.
4922 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4923 Back then I didn't know that the Emacs coding style prefers signed int.
4924 Also, in the meantime I found a few more instances where arguments
4925 were being counted with int, which may truncate counts on 64-bit
4926 machines, or EMACS_INT, which may be unnecessarily wide.
4927 * lisp.h (struct Lisp_Subr.function.aMANY)
4928 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4929 Arg counts are now ptrdiff_t, not size_t.
4930 All variadic functions and their callers changed accordingly.
4931 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4932 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4933 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4934 * callint.c (Fcall_interactively): Check arg count for overflow,
4935 to avoid potential buffer overrun. Use signed char, not 'int',
4936 for 'varies' array, so that we needn't bother to check its size
4937 calculation for overflow.
4938 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4939 * eval.c (apply_lambda):
4940 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4941 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4942 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4943
4944 * callint.c (Fcall_interactively): Don't use index var as event count.
4945
4946 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4947 * mem-limits.h (SIZE): Remove; no longer used.
4948
4949 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4950
4951 Remove unnecessary casts.
4952 * xterm.c (x_term_init):
4953 * xfns.c (x_set_border_pixel):
4954 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4955 These aren't needed now that we assume ANSI C.
4956
4957 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4958 It's more likely to cause problems (due to unsigned overflow)
4959 than to cure them.
4960
4961 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4962
4963 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4964
4965 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4966
4967 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4968
4969 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4970
4971 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4972
4973 GLYPH_CODE_FACE returns EMACS_INT, not int.
4974 * dispextern.h (merge_faces):
4975 * xfaces.c (merge_faces):
4976 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4977 Don't assume EMACS_INT fits in int.
4978
4979 * character.h (CHAR_VALID_P): Remove unused parameter.
4980 * fontset.c, lisp.h, xdisp.c: All uses changed.
4981
4982 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4983
4984 * fns.c (concat): Minor tuning based on overflow analysis.
4985 This doesn't fix any bugs. Use int to hold character, instead
4986 of constantly refetching from Emacs object. Use XFASTINT, not
4987 XINT, for value known to be a character. Don't bother comparing
4988 a single byte to 0400, as it's always less.
4989
4990 * floatfns.c (Fexpt):
4991 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4992
4993 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4994 for characters.
4995
4996 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4997
4998 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4999 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5000 incorrectly succeed when S was a string, because 4294967386 was
5001 truncated before it was used.
5002
5003 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5004 Otherwise, an out-of-range integer could cause undefined behavior
5005 on a 64-bit host.
5006
5007 * composite.c: Use int, not EMACS_INT, for characters.
5008 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5009 EMACS_INT, for values that are known to be in character range.
5010 This doesn't fix any bugs but is the usual style inside Emacs and
5011 may generate better code on 32-bit machines.
5012
5013 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5014 This is for reasons similar to the recent CHAR_STRING fix.
5015 * charset.c (Fencode_char): Check that character arg is actually
5016 a character. Pass an int to ENCODE_CHAR.
5017 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5018 wider than 'int', as a compile-time check to prevent future regressions
5019 in this area.
5020
5021 * character.c (char_string): Remove unnecessary casts.
5022
5023 Make sure a 64-bit char is never passed to CHAR_STRING.
5024 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5025 by silently ignoring the top 32 bits, allowing some values
5026 that were far too large to be valid characters.
5027 * character.h: Include <verify.h>.
5028 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5029 arguments are no wider than unsigned, as a compile-time check
5030 to prevent future regressions in this area.
5031 * data.c (Faset):
5032 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5033 (Fsubst_char_in_region):
5034 * fns.c (concat):
5035 * xdisp.c (decode_mode_spec_coding):
5036 Adjust to CHAR_STRING's new requirement.
5037 * editfns.c (Finsert_char, Fsubst_char_in_region):
5038 * fns.c (concat): Check that character args are actually
5039 characters. Without this test, these functions did the wrong
5040 thing with wildly out-of-range values on 64-bit hosts.
5041
5042 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5043 These casts should not be needed on 32-bit hosts, either.
5044 * keyboard.c (read_char):
5045 * lread.c (Fload): Remove casts to unsigned.
5046
5047 * lisp.h (UNSIGNED_CMP): New macro.
5048 This fixes comparison bugs on 64-bit hosts.
5049 (ASCII_CHAR_P): Use it.
5050 * casefiddle.c (casify_object):
5051 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5052 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5053 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5054 * dispextern.h (FACE_FROM_ID):
5055 * keyboard.c (read_char): Use UNSIGNED_CMP.
5056
5057 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5058 not to EMACS_INT, to avoid GCC warning.
5059
5060 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5061
5062 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5063 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5064 isn't needed on 32-bit machines.
5065
5066 * buffer.c (Fgenerate_new_buffer_name):
5067 Use EMACS_INT for count, not int.
5068 (advance_to_char_boundary): Return EMACS_INT, not int.
5069
5070 * data.c (Qcompiled_function): Now static.
5071
5072 * window.c (window_body_lines): Now static.
5073
5074 * image.c (gif_load): Rename local to avoid shadowing.
5075
5076 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5077 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5078 * alloc.c (make_save_value): Integer argument is now of type
5079 ptrdiff_t, not int.
5080 (mark_object): Use ptrdiff_t, not int.
5081 * lisp.h (pD): New macro.
5082 * print.c (print_object): Use it.
5083
5084 * alloc.c: Use EMACS_INT, not int, to count objects.
5085 (total_conses, total_markers, total_symbols, total_vector_size)
5086 (total_free_conses, total_free_markers, total_free_symbols)
5087 (total_free_floats, total_floats, total_free_intervals)
5088 (total_intervals, total_strings, total_free_strings):
5089 Now EMACS_INT, not int. All uses changed.
5090 (Fgarbage_collect): Compute overall total using a double, so that
5091 integer overflow is less likely to be a problem. Check for overflow
5092 when converting back to an integer.
5093 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5094 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5095 These were 'int' variables that could overflow on 64-bit hosts;
5096 they were never used, so remove them instead of repairing them.
5097 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5098 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5099 Previously, this ceilinged at INT_MAX, but that doesn't work on
5100 64-bit machines.
5101 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5102
5103 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5104 (allocate_vectorlike): Check for ptrdiff_t overflow.
5105 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5106 when a (possibly-narrower) signed value would do just as well.
5107 We prefer using signed arithmetic, to avoid comparison confusion.
5108
5109 * alloc.c: Catch some string size overflows that we were missing.
5110 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5111 for convenience in STRING_BYTES_MAX.
5112 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5113 The definition here is exact; the one in lisp.h was approximate.
5114 (allocate_string_data): Check for string overflow. This catches
5115 some instances we weren't catching before. Also, it catches
5116 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5117 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5118 and ptrdiff_t and EMACS_INT are both 64 bits.
5119
5120 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5121 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5122 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5123
5124 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5125
5126 * alloc.c (Fmake_string): Check for out-of-range init.
5127
5128 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5129
5130 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5131
5132 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5133
5134 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5135 xg_get_default_scrollbar_width.
5136
5137 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5138 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5139 (style_changed_cb): Call update_theme_scrollbar_width and call
5140 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5141 all frames (Bug#8505).
5142 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5143 Call gtk_window_set_resizable if HAVE_GTK3.
5144 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5145 and height if HAVE_GTK3 (Bug#8505).
5146 (scroll_bar_width_for_theme): New variable.
5147 (update_theme_scrollbar_width): New function.
5148 (xg_get_default_scrollbar_width): Move code to
5149 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5150 (xg_initialize): Call update_theme_scrollbar_width.
5151
5152 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5153
5154 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5155
5156 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5157
5158 * frame.c (make_frame): Call other_buffer_safely instead of
5159 other_buffer.
5160
5161 * window.c (temp_output_buffer_show): Call display_buffer with
5162 second argument Vtemp_buffer_show_specifiers and reset latter
5163 immediately after the call.
5164 (Vtemp_buffer_show_specifiers): New variable.
5165 (auto_window_vscroll_p, next_screen_context_lines)
5166 (Vscroll_preserve_screen_position): Remove leading asterisks from
5167 doc-strings.
5168
5169 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5170
5171 Fix minor problems found by GCC 4.6.0 static checking.
5172 * buffer.c (Qclone_number): Remove for now, as it's unused.
5173 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5174 (record_buffer): Remove unused local.
5175 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5176 (set_frame_buffer_list): Remove; unused.
5177 * frame.h (other_visible_frames): Remove decl.
5178 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5179 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5180 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5181 if HAVE_GPM.
5182 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5183 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5184 Define only if HAVE_GPM.
5185 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5186 (update_hints_inhibit): Remove; never set. All uses removed.
5187 * widgetprv.h (emacsFrameClassRec): Remove decl.
5188 * window.c (delete_deletable_window): Now returns void, since it
5189 wasn't returning anything.
5190 (compare_window_configurations): Remove unused locals.
5191 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5192 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5193 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5194 the same widths as pointers. This follows up on the 2011-05-06 patch.
5195 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5196 * xterm.h: Likewise.
5197 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5198
5199 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * makefile.w32-in: Update dependencies.
5202 (LISP_H): Add lib/intprops.h.
5203
5204 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5205
5206 * image.c (gif_load): Add animation frame delay to the metadata.
5207 (syms_of_image): Use DEFSYM. New symbol `delay'.
5208
5209 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5210
5211 * window.c (delete_deletable_window): Re-add.
5212 (Fset_window_configuration): Rewrite to handle dead buffers and
5213 consequently deletable windows.
5214 (window_tree, Fwindow_tree): Remove. Supply functionality in
5215 window.el.
5216 (compare_window_configurations): Simplify code.
5217
5218 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5219
5220 * image.c (imagemagick_load_image): Fix type mismatch.
5221 (Fimagemagick_types): Likewise.
5222
5223 * window.h (replace_buffer_in_windows): Declare.
5224
5225 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5226
5227 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5228 Qclone_number. Remove external declaration of Qdelete_window.
5229 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5230 code.
5231 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5232 Run Qbuffer_list_update_hook if allowed.
5233 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5234 buffer list implementation.
5235 (other_buffer_safely): New function.
5236 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5237 calls to replace_buffer_in_windows and
5238 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5239 if allowed.
5240 (record_buffer): Inhibit quitting and rewrite using quittable
5241 functions. Run Qbuffer_list_update_hook if allowed.
5242 (Frecord_buffer, Funrecord_buffer): New functions.
5243 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5244 Move switch-to-buffer to window.el.
5245 (bury-buffer): Move to window.el.
5246 (Vbuffer_list_update_hook): New variable.
5247
5248 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5249 section.
5250
5251 * window.h (resize_frame_windows): Move up in code.
5252 (Fwindow_frame): Remove EXFUN.
5253 (replace_buffer_in_all_windows): Remove prototype.
5254 (replace_buffer_in_windows_safely): Add prototype.
5255
5256 * window.c: Declare Qdelete_window static again. Move down
5257 declaration of select_count.
5258 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5259 (Fother_window): Move to window.el.
5260 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5261 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5262 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5263 window.el.
5264 (replace_buffer_in_windows): Implement by calling
5265 Qreplace_buffer_in_windows.
5266 (replace_buffer_in_all_windows): Remove with some functionality
5267 moved into replace_buffer_in_windows_safely.
5268 (replace_buffer_in_windows_safely): New function.
5269 (select_window_norecord, select_frame_norecord): Move in front
5270 of run_window_configuration_change_hook. Remove now obsolete
5271 declarations.
5272 (Fset_window_buffer): Rewrite doc-string.
5273 Call Qrecord_window_buffer.
5274 (keys_of_window): Move binding for other-window to window.el.
5275
5276 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5277
5278 * dispextern.h (struct image): Replace data member, whose int_val
5279 and ptr_val fields were not used by anything, with a single
5280 lisp_val object.
5281
5282 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5283 (gif_clear_image, gif_load, imagemagick_load_image)
5284 (gs_clear_image, gs_load): Callers changed.
5285
5286 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 * buffer.h: Include <time.h>, for time_t.
5289 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5290
5291 Fix minor problems found by static checking.
5292
5293 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5294
5295 Make identifiers static if they are not used in other modules.
5296 * data.c (Qcompiled_function, Qframe, Qvector):
5297 * image.c (QimageMagick, Qsvg):
5298 * minibuf.c (Qmetadata):
5299 * window.c (resize_window_check, resize_root_window): Now static.
5300 * window.h (resize_window_check, resize_root_window): Remove decls.
5301
5302 * window.c (window_deletion_count, delete_deletable_window):
5303 Remove; unused.
5304 (window_body_lines): Now static.
5305 (Fdelete_other_windows_internal): Mark vars as initialized.
5306 Make sure 'resize_failed' is initialized.
5307 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5308 (resize_window_apply): Remove unused local.
5309 * window.h (delete_deletable_window): Remove decl.
5310
5311 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5312 (imagemagick_load_image): Fix pointer signedness problem by changing
5313 last arg from unsigned char * to char *. All uses changed.
5314 Also, fix a local for similar reasons.
5315 Remove unused locals. Remove locals to avoid shadowing.
5316 (fn_rsvg_handle_free): Remove; unused.
5317 (svg_load, svg_load_image): Fix pointer signedness problem.
5318 (imagemagick_load_image): Don't use garbage pointer image_wand.
5319
5320 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5321
5322 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5323
5324 * image.c (gif_load): Fix omitted cast error introduced by
5325 2011-06-06 change.
5326
5327 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5328
5329 * window.h (resize_proportionally, orig_total_lines)
5330 (orig_top_line): Remove from window structure.
5331 (set_window_height, set_window_width, change_window_heights)
5332 (Fdelete_window): Remove prototypes.
5333 (resize_frame_windows): Remove duplicate declaration.
5334
5335 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5336
5337 * window.h (resize_frame_windows, resize_window_check)
5338 (delete_deletable_window, resize_root_window)
5339 (resize_frame_windows): Declare prototypes.
5340
5341 * window.c (resize_window_apply): Make definition be "static" to
5342 match the prototype.
5343
5344 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5345
5346 * window.c: Remove declarations of Qwindow_size_fixed,
5347 window_min_size_1, window_min_size_2, window_min_size,
5348 size_window, window_fixed_size_p, enlarge_window, delete_window.
5349 Remove static from declaration of Qdelete_window, it's
5350 temporarily needed by Fbury_buffer.
5351 (replace_window): Don't assign orig_top_line and
5352 orig_total_lines.
5353 (Fdelete_window, delete_window): Remove. Window deletion is
5354 handled by window.el.
5355 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5356 Replace Fdelete_window calls with calls to Qdelete_window.
5357 (Fdelete_other_windows): Remove. Deleting other windows is
5358 handled by window.el.
5359 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5360 handled in window.el.
5361 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5362 Window minimum sizes are handled in window.el.
5363 (shrink_windows, size_window, set_window_height)
5364 (set_window_width, change_window_heights, window_height)
5365 (window_width, CURBEG, CURSIZE, enlarge_window)
5366 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5367 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5368 handled in window.el.
5369 (make_dummy_parent): Rename to make_parent_window and give it a
5370 second argument horflag.
5371 (make_window): Don't set resize_proportionally any more.
5372 (Fsplit_window): Remove. Windows are split in window.el.
5373 (save_restore_action, save_restore_orig_size)
5374 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5375 Resize mini windows in window.el.
5376 (grow_mini_window, shrink_mini_window): Implement by calling
5377 Qresize_root_window_vertically, resize_window_check and
5378 resize_window_apply.
5379 (saved_window, Fset_window_configuration, save_window_save):
5380 Do not handle orig_top_line, orig_total_lines, and
5381 resize_proportionally.
5382 (window_min_height, window_min_width): Move to window.el.
5383 (keys_of_window): Move bindings for delete-other-windows,
5384 split-window, delete-window and enlarge-window to window.el.
5385
5386 * buffer.c: Temporarily extern Qdelete_window.
5387 (Fbury_buffer): Temporarily call Qdelete_window instead of
5388 Fdelete_window (Fbury_buffer will move to window.el soon).
5389
5390 * frame.c (set_menu_bar_lines_1): Remove code handling
5391 orig_top_line and orig_total_lines.
5392
5393 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5394 set_window_height but set heights directly.
5395 (change_frame_size_1): Use resize_frame_windows.
5396
5397 * xdisp.c (init_xdisp): Don't use set_window_height but set
5398 heights directly.
5399
5400 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5401 Use resize_frame_windows instead of change_window_heights and run
5402 run_window_configuration_change_hook.
5403
5404 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5405 instead of change_window_heights and run
5406 run_window_configuration_change_hook.
5407
5408 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5409
5410 * window.c (replace_window): Rename second argument REPLACEMENT to
5411 NEW. New third argument SETFLAG. Rewrite.
5412 (delete_window, make_dummy_parent): Call replace_window with
5413 third argument 1.
5414 (window_list_1): Move down in code.
5415 (run_window_configuration_change_hook): Move set_buffer part
5416 before select_frame_norecord part in order to unwind correctly.
5417 Rename count1 to count.
5418 (recombine_windows, delete_deletable_window, resize_root_window)
5419 (Fdelete_other_windows_internal)
5420 (Frun_window_configuration_change_hook, make_parent_window)
5421 (resize_window_check, resize_window_apply, Fresize_window_apply)
5422 (resize_frame_windows, Fsplit_window_internal)
5423 (Fdelete_window_internal, Fresize_mini_window_internal):
5424 New functions.
5425 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5426
5427 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5428
5429 * window.h (window): Add some new members to window structure -
5430 normal_lines, normal_cols, new_total, new_normal, clone_number,
5431 splits, nest, prev_buffers, next_buffers.
5432 (WINDOW_TOTAL_SIZE): Move here from window.c.
5433 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5434
5435 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5436 Remove.
5437 (make_dummy_parent): Set new members of windows structure.
5438 (make_window): Move down in code. Handle new members of window
5439 structure.
5440 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5441 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5442 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5443 (Fset_window_prev_buffers, Fwindow_next_buffers)
5444 (Fset_window_next_buffers, Fset_window_clone_number):
5445 New functions.
5446 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5447 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5448 Doc-string fixes.
5449 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5450 Argument WINDOW can be now internal window too.
5451 (Fwindow_use_time): Move up in code.
5452 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5453 Rewrite doc-string.
5454 (Fset_window_configuration, saved_window)
5455 (Fcurrent_window_configuration, save_window_save): Handle new
5456 members of window structure.
5457 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5458 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5459 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5460 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5461 Qget_mru_window, Qresize_root_window,
5462 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5463 Qauto_buffer_name; staticpro them.
5464
5465 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5466
5467 * window.c (Fwindow_total_size, Fwindow_left_column)
5468 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5469 (Fwindow_list_1): New functions.
5470 (window_box_text_cols): Replace with window_body_cols.
5471 (Fwindow_width, Fscroll_left, Fscroll_right):
5472 Use window_body_cols instead of window_box_text_cols.
5473 (delete_window, Fset_window_configuration):
5474 Call delete_all_subwindows with window as argument.
5475 (delete_all_subwindows): Take a window as argument and not a
5476 structure. Rewrite.
5477 (window_loop): Remove handling of GET_LRU_WINDOW and
5478 GET_LARGEST_WINDOW.
5479 (Fget_lru_window, Fget_largest_window): Move to window.el.
5480
5481 * window.h: Extern window_body_cols instead of
5482 window_box_text_cols. delete_all_subwindows now takes a
5483 Lisp_Object as argument.
5484
5485 * indent.c (compute_motion, Fcompute_motion):
5486 Use window_body_cols instead of window_box_text_cols.
5487
5488 * frame.c (delete_frame): Call delete_all_subwindows with root
5489 window as argument.
5490
5491 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5492
5493 * fns.c (Fputhash): Document return value.
5494
5495 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5496
5497 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5498
5499 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5500
5501 Cons<->int and similar integer overflow fixes (Bug#8794).
5502
5503 Check for overflow when converting integer to cons and back.
5504 * charset.c (Fdefine_charset_internal, Fdecode_char):
5505 Use cons_to_unsigned to catch overflow.
5506 (Fencode_char): Use INTEGER_TO_CONS.
5507 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5508 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5509 * data.c (long_to_cons, cons_to_long): Remove.
5510 (cons_to_unsigned, cons_to_signed): New functions.
5511 These signal an error for invalid or out-of-range values.
5512 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5513 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5514 * font.c (Ffont_variation_glyphs):
5515 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5516 * lisp.h: Include <intprops.h>.
5517 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5518 (cons_to_signed, cons_to_unsigned): New decls.
5519 (long_to_cons, cons_to_long): Remove decls.
5520 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5521 (Fprimitive_undo): Use CONS_TO_INTEGER.
5522 * xfns.c (Fx_window_property): Likewise.
5523 * xselect.c: Include <limits.h>.
5524 (x_own_selection, selection_data_to_lisp_data):
5525 Use INTEGER_TO_CONS.
5526 (x_handle_selection_request, x_handle_selection_clear)
5527 (x_get_foreign_selection, Fx_disown_selection_internal)
5528 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5529 (lisp_data_to_selection_data): Use cons_to_unsigned.
5530 (x_fill_property_data): Use cons_to_signed.
5531 Report values out of range.
5532
5533 Check for buffer and string overflow more precisely.
5534 * buffer.h (BUF_BYTES_MAX): New macro.
5535 * lisp.h (STRING_BYTES_MAX): New macro.
5536 * alloc.c (Fmake_string):
5537 * character.c (string_escape_byte8):
5538 * coding.c (coding_alloc_by_realloc):
5539 * doprnt.c (doprnt):
5540 * editfns.c (Fformat):
5541 * eval.c (verror):
5542 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5543 since they may not be the same number.
5544 * editfns.c (Finsert_char):
5545 * fileio.c (Finsert_file_contents):
5546 Likewise for BUF_BYTES_MAX.
5547
5548 * image.c: Use ptrdiff_t, not int, for sizes.
5549 (slurp_file): Switch from int to ptrdiff_t.
5550 All uses changed.
5551 (slurp_file): Check that file size fits in both size_t (for
5552 malloc) and ptrdiff_t (for sanity and safety).
5553
5554 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5555 if b->modtime has its maximal value.
5556
5557 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5558
5559 Don't assume time_t can fit into int.
5560 * buffer.h (struct buffer.modtime): Now time_t, not int.
5561 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5562 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5563
5564 Minor fixes for signed vs unsigned integers.
5565 * character.h (MAYBE_UNIFY_CHAR):
5566 * charset.c (maybe_unify_char):
5567 * keyboard.c (read_char, reorder_modifiers):
5568 XINT -> XFASTINT, since the integer must be nonnegative.
5569 * ftfont.c (ftfont_spec_pattern):
5570 * keymap.c (access_keymap, silly_event_symbol_error):
5571 XUINT -> XFASTINT, since the integer must be nonnegative.
5572 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5573 since it makes no difference and we prefer signed.
5574 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5575 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5576 nonnegative.
5577
5578 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5579
5580 * window.h (Fwindow_frame): Declare.
5581
5582 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5583
5584 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5585 (SPARE_MEMORY): Always define.
5586 (LARGE_REQUEST): Remove.
5587 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5588
5589 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5590
5591 * lisp.h: Move EXFUNS for Fframe_root_window,
5592 Fframe_first_window and Fset_frame_selected_window to window.h.
5593
5594 * window.h: Move EXFUNS for Fframe_root_window,
5595 Fframe_first_window and Fset_frame_selected_window here from
5596 lisp.h.
5597
5598 * frame.c (Fwindow_frame, Fframe_first_window)
5599 (Fframe_root_window, Fframe_selected_window)
5600 (Fset_frame_selected_window): Move to window.c.
5601 (Factive_minibuffer_window): Move to minibuf.c.
5602 (Fother_visible_frames_p): New function.
5603
5604 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5605
5606 * window.c (decode_window, decode_any_window): Move up in code.
5607 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5608 (inhibit_frame_unsplittable): Remove unused variable.
5609 (Fwindow_buffer): Move up and rewrite doc-string.
5610 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5611 (Fwindow_prev): New functions.
5612 (Fwindow_frame): Move here from frame.c. Accept any window as
5613 argument.
5614 (Fframe_root_window, Fframe_first_window)
5615 (Fframe_selected_window): Move here from frame.c. Accept frame
5616 or arbitrary window as argument. Update doc-strings.
5617 (Fminibuffer_window): Move up in code.
5618 (Fwindow_minibuffer_p): Move up in code and simplify.
5619 (Fset_frame_selected_window): Move here from frame.c.
5620 Marginal rewrite.
5621 (Fselected_window, select_window, Fselect_window): Move up in
5622 code. Minor doc-string fixes.
5623
5624 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5625
5626 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5627 Do not assume that spare memory exists; that assumption is valid
5628 only if SYSTEM_MALLOC.
5629 (LARGE_REQUEST): New macro, so that the issue of large requests
5630 is separated from the issue of spare memory.
5631
5632 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5633
5634 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5635 format. (Bug#8806)
5636
5637 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5638
5639 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5640 before statements.
5641
5642 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5643
5644 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5645
5646 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5647
5648 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5649 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5650
5651 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5652
5653 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5654
5655 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5656
5657 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5658 (x_clipboard_manager_save): Add return value.
5659 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5660 New error handlers.
5661 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5662 Obey Vx_select_enable_clipboard_manager. Catch errors in
5663 x_clipboard_manager_save (Bug#8779).
5664 (Vx_select_enable_clipboard_manager): New variable.
5665 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5666
5667 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5668
5669 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5670
5671 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5672
5673 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5674 in the current matrix if keep_current_p is non-zero.
5675
5676 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5677
5678 * bidi.c (bidi_level_of_next_char): Fix last change.
5679
5680 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5681
5682 Support bidi reordering of text covered by display properties.
5683
5684 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5685 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5686 (bidi_cache_search, bidi_cache_iterator_state)
5687 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5688 (bidi_level_of_next_char, bidi_move_to_visually_next):
5689 Support character positions inside a run of characters covered by a
5690 display string.
5691 (bidi_paragraph_init, bidi_resolve_explicit_1)
5692 (bidi_level_of_next_char): Call bidi_fetch_char and
5693 bidi_fetch_char_advance instead of FETCH_CHAR and
5694 FETCH_CHAR_ADVANCE.
5695 (bidi_init_it): Initialize new members.
5696 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5697 definitions.
5698 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5699 instead of using explicit *_CHAR codes.
5700 (bidi_resolve_explicit, bidi_resolve_weak):
5701 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5702 bidirectional text is supported only in multibyte buffers.
5703 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5704 it to initialize the frame_window_p member of struct bidi_it.
5705 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5706 (bidi_resolve_explicit, bidi_resolve_weak)
5707 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5708 bidi_it->nchars is non-positive.
5709 (bidi_level_of_next_char): Don't try to lookup the cache for the
5710 next/previous character if nothing is cached there yet, or if we
5711 were just reseat()'ed to a new position.
5712
5713 * xdisp.c (set_cursor_from_row): Set start and stop points
5714 according to the row's direction when priming the loop that looks
5715 for the glyph on which to display cursor.
5716 (single_display_spec_intangible_p): Function deleted.
5717 (display_prop_intangible_p): Reimplement to call
5718 handle_display_spec instead of single_display_spec_intangible_p.
5719 Accept 3 additional arguments needed by handle_display_spec.
5720 This fixes incorrect cursor motion across display property with complex
5721 values: lists, `(when COND...)' forms, etc.
5722 (single_display_spec_string_p): Support property values that are
5723 lists with the argument STRING its top-level element.
5724 (display_prop_string_p): Fix the condition for processing a
5725 property that is a list to be consistent with handle_display_spec.
5726 (handle_display_spec): New function, refactored from the
5727 last portion of handle_display_prop.
5728 (compute_display_string_pos): Accept additional argument
5729 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5730 value of a `display' property is a "replacing spec".
5731 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5732 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5733 the display property, but just return a value indicating whether
5734 the display property will replace the characters it covers.
5735 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5736 frame_window_p members of struct bidi_it.
5737 (compute_display_string_pos, compute_display_string_end):
5738 New functions.
5739 (push_it): Accept second argument POSITION, where pop_it should
5740 jump to continue iteration.
5741 (reseat_1): Initialize bidi_it.disp_pos.
5742
5743 * keyboard.c (adjust_point_for_property): Adjust the call to
5744 display_prop_intangible_p to its new signature.
5745
5746 * dispextern.h (struct bidi_it): New member frame_window_p.
5747 (bidi_init_it): Update prototypes.
5748 (display_prop_intangible_p): Update prototype.
5749 (compute_display_string_pos, compute_display_string_end):
5750 Declare prototypes.
5751 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5752 EMACS_INT.
5753
5754 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5755
5756 Malloc failure behavior now depends on size of allocation.
5757 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5758 * lisp.h: Change signatures accordingly.
5759 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5760 All callers changed. (Bug#8762)
5761
5762 * gnutls.c: Use Emacs's memory allocators.
5763 Without this change, the gnutls library would invoke malloc etc.
5764 directly, which causes problems on non-SYNC_INPUT hosts, and which
5765 runs afoul of improving memory_full behavior. (Bug#8761)
5766 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5767 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5768 xfree instead of the default malloc, realloc, free.
5769 (Fgnutls_boot): No need to check for memory allocation failure,
5770 since xmalloc does that for us.
5771
5772 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5773 * category.c (hash_get_category_set):
5774 * ccl.c (ccl_driver):
5775 * charset.c (Fdefine_charset_internal):
5776 * charset.h (struct charset.hash_index):
5777 * composite.c (get_composition_id, gstring_lookup_cache)
5778 (composition_gstring_put_cache):
5779 * composite.h (struct composition.hash_index):
5780 * dispextern.h (struct image.hash):
5781 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5782 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5783 (hashfn_equal, hashfn_user_defined, make_hash_table)
5784 (maybe_resize_hash_table, hash_lookup, hash_put)
5785 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5786 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5787 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5788 * image.c (make_image, search_image_cache, lookup_image)
5789 (xpm_put_color_table_h):
5790 * lisp.h (struct Lisp_Hash_Table):
5791 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5792 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5793 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5794 * alloc.c (allocate_vectorlike):
5795 Check for overflow in vector size calculations.
5796 * ccl.c (ccl_driver):
5797 Check for overflow when converting EMACS_INT to int.
5798 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5799 need to be updated by these changes.
5800 * fns.c (make_hash_table, maybe_resize_hash_table):
5801 Check for integer overflow with large hash tables.
5802 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5803 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5804 (SXHASH_REDUCE): New macro.
5805 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5806 Use it instead of discarding useful hash info with large hash values.
5807 (sxhash_float): New function.
5808 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5809 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5810 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5811 Rewrite to use FIXNUM_BITS, as this simplifies things.
5812 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5813 Adjust signatures to match updated version of code.
5814 (consing_since_gc): Now EMACS_INT, since a single hash table can
5815 use more than INT_MAX bytes.
5816
5817 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5818
5819 Make it possible to build with GCC-4.6+ -O2 -flto.
5820
5821 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5822
5823 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5824
5825 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5826 Call minibuffer-inactive-mode.
5827
5828 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5829
5830 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5831 Update dependencies.
5832
5833 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5834
5835 * data.c (init_data): Remove code for UTS, this system is not
5836 supported anymore.
5837
5838 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5839
5840 Don't force ./temacs to start in terminal mode.
5841
5842 * frame.c (make_initial_frame): Initialize faces in all cases, not
5843 only when CANNOT_DUMP is defined.
5844 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5845
5846 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5847
5848 * dispnew.c (add_window_display_history): Use const for the string
5849 pointer. Remove declaration, not needed.
5850
5851 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5852
5853 Use 'inline', not 'INLINE'.
5854 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5855 * alloc.c, fontset.c (INLINE): Remove.
5856 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5857 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5858 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5859 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5860 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5861
5862 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5863
5864 Make it possible to run ./temacs.
5865
5866 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5867 syms_of_callproc does the same thing. Remove test for
5868 "initialized", do it in the caller.
5869 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5870
5871 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5872
5873 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5874 (read_minibuf): Use get_minibuffer.
5875 (syms_of_minibuf): Use DEFSYM.
5876 (Qmetadata): New var.
5877 * data.c (Qbuffer): Don't make it static.
5878 (syms_of_data): Use DEFSYM.
5879
5880 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5881
5882 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5883 (CCL_CODE_MIN): New macro.
5884
5885 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5886
5887 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5888
5889 * eval.c (Qdebug): Now static.
5890 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5891 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5892 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5893
5894 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5895
5896 * image.c: Various fixes to ImageMagick code comments.
5897 (Fimagemagick_types): Doc fix.
5898
5899 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5900
5901 Minor fixes prompted by GCC 4.6.0 warnings.
5902
5903 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5904
5905 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5906 (x_clipboard_manager_save_all): Move extern decl to ...
5907 * xterm.h: ... here, so that it can be checked for consistency.
5908
5909 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5910
5911 * xselect.c (x_clipboard_manager_save_frame)
5912 (x_clipboard_manager_save_all): New functions.
5913 (Fx_clipboard_manager_save): Lisp function deleted.
5914
5915 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5916 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5917
5918 * xterm.h: Update prototype.
5919
5920 2011-05-28 William Xu <william.xwl@gmail.com>
5921
5922 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5923 exiting (Bug#8239).
5924
5925 2011-05-28 Jim Meyering <meyering@redhat.com>
5926
5927 Avoid a sign-extension bug in crypto_hash_function.
5928 * fns.c (to_uchar): Define.
5929 (crypto_hash_function): Use it to convert some newly-signed
5930 variables to unsigned, to avoid sign-extension bugs. For example,
5931 without this change, (md5 "truc") would evaluate to
5932 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5933 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5934 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5935
5936 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 Integer overflow fixes.
5939
5940 * dbusbind.c: Serial number integer overflow fixes.
5941 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5942 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5943 to hold a serial number that is too large for a fixnum.
5944 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5945 Check for serial numbers out of range. Decode any serial number
5946 that was so large that it became a float. (Bug#8722)
5947
5948 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5949 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5950 Use XFASTINT rather than XUINT when numbers are nonnegative.
5951 (xd_append_arg, Fdbus_method_return_internal):
5952 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5953 arguments, check that Lisp number is nonnegative, rather than
5954 silently wrapping negative numbers around. (Bug#8722)
5955 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5956 (Bug#8722)
5957
5958 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5959
5960 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5961
5962 ccl: Add integer overflow checks.
5963 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5964 (IN_INT_RANGE): New macros.
5965 (ccl_driver): Use them to check for integer overflow when
5966 decoding a CCL program. Many of the new checks are whether XINT (x)
5967 fits in int; it doesn't always, on 64-bit hosts. The new version
5968 doesn't catch all possible integer overflows, but it's an
5969 improvement. (Bug#8719)
5970
5971 * alloc.c (make_event_array): Use XINT, not XUINT.
5972 There's no need for unsigned here.
5973
5974 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5975 This follows up to the 2011-05-06 change that substituted uintptr_t
5976 for EMACS_INT. This case wasn't caught back then.
5977
5978 Rework Fformat to avoid integer overflow issues.
5979 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5980 now (part of C89). Include <verify.h>.
5981 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5982 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5983 (Fformat): Avoid the prepass trying to compute sizes; it was only
5984 approximate and thus did not catch overflow reliably. Instead, walk
5985 through the format just once, formatting and computing sizes as we go,
5986 checking for integer overflow at every step, and allocating a larger
5987 buffer as needed. Keep track separately whether the format is
5988 multibyte. Keep only the most-recently calculated precision, rather
5989 than them all. Record whether each argument has been converted to
5990 string. Use EMACS_INT, not int, for byte and char and arg counts.
5991 Support field widths and precisions larger than INT_MAX. Avoid
5992 sprintf's undefined behavior with conversion specifications such as %#d
5993 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5994 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5995 formatting out-of-range floating point numbers with int
5996 formats. (Bug#8668)
5997
5998 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5999
6000 * data.c: Avoid integer truncation in expressions involving floats.
6001 * data.c: Include <intprops.h>.
6002 (arith_driver): When there's an integer overflow in an expression
6003 involving floating point, convert the integers to floating point
6004 so that the resulting value does not suffer from catastrophic
6005 integer truncation. For example, on a 64-bit host (* 4
6006 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6007 Do not rely on undefined behavior after integer overflow.
6008
6009 merge count_size_as_multibyte, parse_str_to_multibyte
6010 * character.c, character.h (count_size_as_multibyte):
6011 Rename from parse_str_to_multibyte; all uses changed.
6012 Check for integer overflow.
6013 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6014 since it's now a duplicate of the other. This is more of
6015 a character than a buffer op, so better that it's in character.c.
6016 * fns.c, print.c: Adjust to above changes.
6017
6018 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6019
6020 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6021
6022 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6025 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6026 (x_clipboard_manager_save): Now static.
6027 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6028
6029 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6030 (crypto_hash_function): Now static.
6031 Fix pointer signedness problems. Avoid unnecessary initializations.
6032
6033 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6034
6035 * termhooks.h (Vselection_alist): Make it terminal-local.
6036
6037 * terminal.c (create_terminal): Initialize it.
6038
6039 * xselect.c: Support for clipboard managers.
6040 (Vselection_alist): Move to termhooks.h as terminal-local var.
6041 (LOCAL_SELECTION): New macro.
6042 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6043 (symbol_to_x_atom): Remove gratuitous arg.
6044 (x_handle_selection_request, lisp_data_to_selection_data)
6045 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6046 (x_own_selection, x_get_local_selection, x_convert_selection):
6047 New arg, specifying work frame. Use terminal-local Vselection_alist.
6048 (some_frame_on_display): Delete unused function.
6049 (Fx_own_selection_internal, Fx_get_selection_internal)
6050 (Fx_disown_selection_internal, Fx_selection_owner_p)
6051 (Fx_selection_exists_p): New optional frame arg.
6052 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6053 (x_handle_selection_clear): Don't treat other terminals with the
6054 same keyboard specially. Use the terminal-local Vselection_alist.
6055 (x_clear_frame_selections): Use Frun_hook_with_args.
6056
6057 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6058
6059 * xterm.h: Add support for those atoms.
6060
6061 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6062
6063 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6064 (converted_selections, conversion_fail_tag): New global variables.
6065 (x_selection_request_lisp_error): Free the above.
6066 (x_get_local_selection): Remove unnecessary code.
6067 (x_reply_selection_request): Args changed; handle arbitrary array
6068 of converted selections stored in converted_selections.
6069 Separate the XChangeProperty and SelectionNotify steps.
6070 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6071 (x_convert_selection): New function.
6072 (x_handle_selection_event): Simplify.
6073 (x_get_foreign_selection): Don't ignore incoming requests while
6074 waiting for an answer; this will fail when we implement
6075 SAVE_TARGETS, and seems unnecessary anyway.
6076 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6077 (Vx_sent_selection_functions): Doc fix.
6078
6079 2011-05-26 Leo Liu <sdl.web@gmail.com>
6080
6081 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6082
6083 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6084
6085 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6086
6087 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6088 for fringe update if it has periodic bitmap.
6089 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6090 and fringe_bitmap_periodic_p.
6091
6092 * fringe.c (get_fringe_bitmap_data): New function.
6093 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6094 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6095 row. Mark glyph row for fringe update if periodicity changed.
6096
6097 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6098 for fringe update unless it has periodic bitmap.
6099
6100 2011-05-25 Kenichi Handa <handa@m17n.org>
6101
6102 * xdisp.c (get_next_display_element): Set correct it->face_id for
6103 a static composition.
6104
6105 2011-05-24 Leo Liu <sdl.web@gmail.com>
6106
6107 * deps.mk (fns.o):
6108 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6109
6110 * fns.c (crypto_hash_function, Fsha1): New function.
6111 (Fmd5): Use crypto_hash_function.
6112 (syms_of_fns): Add Ssha1.
6113
6114 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6115
6116 * gnutls.c: Remove unused macros.
6117 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6118 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6119 Remove macros that are defined and never used.
6120 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6121
6122 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6123
6124 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6125 (Fx_get_selection_internal): Minor cleanup.
6126 (Fx_own_selection_internal): Rename arguments for consistency with
6127 select.el.
6128
6129 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6130
6131 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6132
6133 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6134
6135 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6136
6137 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6138
6139 * dispnew.c (scrolling_window): Don't exclude the case that the
6140 last enabled row in the desired matrix touches the bottom boundary.
6141
6142 2011-05-21 Glenn Morris <rgm@gnu.org>
6143
6144 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6145 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6146 and add some more files.
6147
6148 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6149
6150 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6151 report_file_error introduced by the change from 2011-05-07.
6152
6153 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6154
6155 * systime.h (Time): Define only if emacs is defined.
6156 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6157 where the include path doesn't have X11/X.h by default. See
6158 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6159
6160 2011-05-20 Kenichi Handa <handa@m17n.org>
6161
6162 * composite.c (find_automatic_composition): Fix previous change.
6163
6164 2011-05-20 Glenn Morris <rgm@gnu.org>
6165
6166 * lisp.mk: New file, split from Makefile.in.
6167 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6168 (shortlisp): Remove.
6169 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6170
6171 2011-05-19 Glenn Morris <rgm@gnu.org>
6172
6173 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6174 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6175 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6176 (lisp): Set the order to that of loadup.el.
6177 (shortlisp): Make it a copy of $lisp.
6178 (SOME_MACHINE_LISP): Remove.
6179 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6180 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6181
6182 2011-05-18 Kenichi Handa <handa@m17n.org>
6183
6184 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6185 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6186 (find_automatic_composition): Mostly rewrite for efficiency.
6187
6188 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6189
6190 * makefile.w32-in: Update dependencies.
6191
6192 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6193
6194 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6195 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6196
6197 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6198
6199 Fix some integer overflow issues, such as string length overflow.
6200
6201 * insdel.c (count_size_as_multibyte): Check for string overflow.
6202
6203 * character.c (lisp_string_width): Check for string overflow.
6204 Use EMACS_INT, not int, for string indexes and lengths; in
6205 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6206 the resulting string length overflows an EMACS_INT; instead,
6207 report a string overflow if no precision given. When checking for
6208 precision exhaustion, use a check that cannot possibly have
6209 integer overflow. (Bug#8675)
6210 * character.h (lisp_string_width): Adjust to new signature.
6211
6212 * alloc.c (string_overflow): New function.
6213 (Fmake_string): Use it. This doesn't change behavior, but saves
6214 a few bytes and will simplify future changes.
6215 * character.c (string_escape_byte8): Likewise.
6216 * lisp.h (string_overflow): New decl.
6217
6218 Fixups, following up to the user-interface timestamp change.
6219 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6220 for UI timestamps, instead of unsigned long.
6221 * msdos.c (mouse_get_pos): Likewise.
6222 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6223 * w32gui.h (Time): Define by including "systime.h" rather than by
6224 declaring it ourselves. (Bug#8664)
6225
6226 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6227 * image.c (clear_image_cache): Likewise.
6228
6229 * term.c (term_mouse_position): Don't assume time_t wraparound.
6230
6231 Be more systematic about user-interface timestamps.
6232 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6233 and sometimes 'EMACS_UINT', to represent these timestamps.
6234 This change causes it to use 'Time' uniformly, as that's what X uses.
6235 This makes the code easier to follow, and makes it easier to catch
6236 integer overflow bugs such as Bug#8664.
6237 * frame.c (Fmouse_position, Fmouse_pixel_position):
6238 Use Time, not unsigned long, for user-interface timestamps.
6239 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6240 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6241 * keyboard.h (last_event_timestamp): Likewise.
6242 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6243 * menu.h (xmenu_show): Likewise.
6244 * term.c (term_mouse_position): Likewise.
6245 * termhooks.h (struct input_event.timestamp): Likewise.
6246 (struct terminal.mouse_position_hook): Likewise.
6247 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6248 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6249 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6250 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6251 what it was before.
6252 * menu.h, termhooks.h: Include "systime.h", for Time.
6253
6254 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6255 Don't assume that the difference between two unsigned long values
6256 can fit into an integer. At this point, we know button_down_time
6257 <= event->timestamp, so the difference must be nonnegative, so
6258 there's no need to cast the result if double-click-time is
6259 nonnegative, as it should be; check that it's nonnegative, just in
6260 case. This bug is triggered when events are more than 2**31 ms
6261 apart (about 25 days). (Bug#8664)
6262
6263 * xselect.c (last_event_timestamp): Remove duplicate decl.
6264 (x_own_selection): Remove needless cast to unsigned long.
6265
6266 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6267 that always fit in int. Use a sentinel instead of a counter, to
6268 avoid a temp and to allay GCC's concerns about possible int overflow.
6269 * frame.h (struct frame): Use int for menu_bar_items_used
6270 instead of EMACS_INT, since it always fits in int.
6271
6272 * menu.c (grow_menu_items): Check for int overflow.
6273
6274 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6275
6276 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6277 Before, the code was not consistent. These values cannot exceed
6278 2**31 - 1 so there's no need to make them unsigned.
6279 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6280 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6281 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6282 as modifiers.
6283 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6284
6285 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6286 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6287 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6288 presumably because the widths might not match.
6289
6290 * window.c (size_window): Avoid needless test at loop start.
6291
6292 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6293
6294 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6295
6296 2011-05-12 Drew Adams <drew.adams@oracle.com>
6297
6298 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6299
6300 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6301
6302 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6303 `width' to `bar_area_x' and `bar_area_width', respectively.
6304 (x_scroll_run): Take account of fringe background extension.
6305
6306 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6307 Rename local vars `left' and `width' to `bar_area_x' and
6308 `bar_area_width', respectively.
6309 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6310 background extension.
6311
6312 2011-05-10 Jim Meyering <meyering@redhat.com>
6313
6314 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6315
6316 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6317
6318 * image.c (Finit_image_library): Return t for built-in image types,
6319 like pbm and xbm. (Bug#8640)
6320
6321 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6322
6323 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6324
6325 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6326
6327 * w32console.c (Fset_screen_color): Doc fix.
6328 (Fget_screen_color): New function.
6329 (syms_of_ntterm): Defsubr it.
6330
6331 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6332 unlink the temporary file if Fcall_process didn't create it in the
6333 first place.
6334 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6335 child process will be redirected to a file specified with `:file'.
6336 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6337 cue to call_process_cleanup not to close that handle.
6338
6339 2011-05-07 Ben Key <bkey76@gmail.com>
6340
6341 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6342 one of two shell specific rules, either bootstrap-temacs-CMD or
6343 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6344 to the previous implementation of the bootstrap-temacs rule.
6345 The bootstrap-temacs-CMD rule is similar to the previous
6346 implementation of the bootstrap-temacs rule except that it
6347 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6348 variable.
6349
6350 These changes, along with some changes to nt/configure.bat,
6351 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6352 earlier fix to add support for --cflags and --ldflags options
6353 that include quotes so that it works whether make uses cmd or
6354 sh as the shell.
6355
6356 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6357
6358 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6359 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6360 is a constant.
6361 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6362 a string. Handle both cases.
6363 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6364 (Fdbus_register_method): Use Qinvalid_function.
6365
6366 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6367
6368 * makefile.w32-in: Update dependencies.
6369 (LISP_H): Add inttypes.h and stdin.h.
6370 (PROCESS_H): Add unistd.h.
6371
6372 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6373
6374 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6375 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6376
6377 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6378
6379 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6380
6381 * term.c (vfatal): Remove stray call to va_end.
6382 It's not needed and the C Standard doesn't allow it here anyway.
6383
6384 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6385 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6386
6387 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6388 bytes.
6389
6390 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6391
6392 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6393
6394 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6395
6396 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6397
6398 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6399
6400 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6401 * charset.c (Fdefine_charset_internal): Don't initialize
6402 charset.code_space[15]. The value was garbage, on hosts with
6403 32-bit int (Bug#8600).
6404
6405 * lread.c (read_integer): Be more consistent with string-to-number.
6406 Use string_to_number to do the actual conversion; this avoids
6407 rounding errors and fixes some other screwups. Without this fix,
6408 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6409 (digit_to_number): Move earlier, for benefit of read_integer.
6410 Return -1 if the digit is out of range for the base, -2 if it is
6411 not a digit in any supported base. (Bug#8602)
6412
6413 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6414
6415 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6416 to match comment at start of function. This also removes a
6417 GCC warning about overflow in a 32+64-bit port.
6418
6419 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6420
6421 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6422 Reported by Stefan Monnier in
6423 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6424 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6425 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6426
6427 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6428 (EMACS_UINTPTR): Likewise, with uintptr_t.
6429
6430 * lisp.h: Prefer 64-bit EMACS_INT if available.
6431 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6432 on 32-bit hosts that have 64-bit int, so that they can access
6433 large files.
6434 However, temporarily disable this change unless the temporary
6435 symbol WIDE_EMACS_INT is defined.
6436
6437 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6438
6439 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6440 This removes an assumption that EMACS_INT and long are the same
6441 width as pointers. The assumption is true for Emacs porting targets
6442 now, but we want to make other targets possible.
6443 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6444 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6445 In the rest of the code, change types of integers that hold casted
6446 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6447 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6448 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6449 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6450 No need to cast type when ORing.
6451 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6452 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6453 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6454 assume EMACS_INT is the same width as char *.
6455 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6456 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6457 Remove no-longer-needed casts.
6458 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6459 (xg_tool_bar_help_callback, xg_make_tool_item):
6460 Use EMACS_INTPTR to hold an integer
6461 that will be cast to void *; this can avoid a GCC warning
6462 if EMACS_INT is not the same width as void *.
6463 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6464 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6465 (current_message_1, set_message_1):
6466 Use a local to convert to proper width without a cast.
6467 * xmenu.c (dialog_selection_callback): Likewise.
6468
6469 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6470 Also, don't assume VALBITS / RAND_BITS is less than 5,
6471 and don't rely on undefined behavior when shifting a 1 left into
6472 the sign bit.
6473 * lisp.h (get_random): Change signature to match.
6474
6475 * lread.c (hash_string): Use size_t, not int, for hash computation.
6476 Normally we prefer signed values; but hashing is special, because
6477 it's better to use unsigned division on hash table sizes so that
6478 the remainder is nonnegative. Also, size_t is the natural width
6479 for hashing into memory. The previous code used 'int', which doesn't
6480 retain enough info to hash well into very large tables.
6481 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6482
6483 * dbusbind.c: Don't possibly lose pointer info when converting.
6484 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6485 Use XPNTR rather than XHASH, so that the high-order bits of
6486 the pointer aren't lost when converting through void *.
6487
6488 * eval.c (Fautoload): Don't double-shift a pointer.
6489
6490 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6491
6492 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6493
6494 * gnutls.c (DEF_GNUTLS_FN):
6495 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6496
6497 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6498
6499 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6500 marker. (Bug#8610)
6501
6502 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6503
6504 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6505 New version that can reserve upto 2GB of heap space.
6506
6507 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6508
6509 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6510
6511 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6512
6513 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6514 `gnutls_certificate_set_x509_key_file'.
6515
6516 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6517
6518 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6519 Update dependencies.
6520
6521 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6522
6523 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6524 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6525 Remove unused parameter `fildes'.
6526 * process.c (read_process_output, send_process): Don't pass it.
6527
6528 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6529
6530 Fix previous change: the library cache is defined in w32.c.
6531 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6532 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6533
6534 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6535
6536 Implement dynamic loading of GnuTLS on Windows.
6537
6538 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6539 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6540 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6541 Declare.
6542
6543 * gnutls.c (Qgnutls_dll): Define.
6544 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6545 (gnutls_*): Declare function pointers.
6546 (init_gnutls_functions): New function to initialize function pointers.
6547 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6548 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6549 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6550 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6551 (emacs_gnutls_write, emacs_gnutls_read)
6552 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6553 (Fgnutls_available_p): New function.
6554 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6555 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6556 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6557
6558 * image.c: Include w32.h.
6559 (Vimage_type_cache): Delete.
6560 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6561 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6562 (w32_delayed_load): Move to w32.c.
6563
6564 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6565
6566 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6567 (w32_delayed_load): Move from image.c. When loading a library, record
6568 its filename in the :loaded-from property of the library id.
6569 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6570 Initialize and staticpro them.
6571 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6572
6573 * process.c: Include lisp.h before w32.h, not after.
6574 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6575 instead of gnutls_record_check_pending.
6576
6577 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6578
6579 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6580
6581 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6582 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6583 as passed in.
6584
6585 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6586
6587 * xterm.c (x_set_frame_alpha): Do not set property on anything
6588 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6589
6590 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6591
6592 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6593
6594 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6597 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6598 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6599 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6600 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6601 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6602 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6603 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6604 (Qgnutls_bootprop_callbacks_verify): Make static.
6605
6606 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6607
6608 * callproc.c: Indentation fixup.
6609
6610 * sysdep.c (wait_for_termination_1): Make static.
6611 (wait_for_termination, interruptible_wait_for_termination):
6612 Move after wait_for_termination_1.
6613
6614 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6615
6616 * sysdep.c (interruptible_wait_for_termination): New function
6617 which is like wait_for_termination, but allows keyboard
6618 interruptions.
6619
6620 * callproc.c (Fcall_process): Add (:file "file") as an option for
6621 the STDOUT buffer.
6622 (Fcall_process_region): Ditto.
6623
6624 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6625
6626 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6627 rather than `XVECTOR (FOO)->size'.
6628
6629 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6630 inttypes.h, as a gnulib replacement is used if it not available in
6631 system headers.
6632
6633 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6634
6635 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6636 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6637 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6638
6639 * coding.c (coding_alloc_by_realloc): Error out if destination
6640 will grow beyond MOST_POSITIVE_FIXNUM.
6641 (decode_coding_emacs_mule): Abort if there isn't enough place in
6642 charbuf for the composition carryover bytes. Reserve an extra
6643 space for up to 2 characters produced in a loop.
6644 (decode_coding_iso_2022): Abort if there isn't enough place in
6645 charbuf for the composition carryover bytes.
6646
6647 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6648
6649 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6650 aborting when %lld or %lll format is passed.
6651 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6652 %llo or %llx format is passed. (Bug#8545)
6653
6654 * window.c (window_scroll_line_based): Use a marker instead of
6655 simple variables to record original value of point. (Bug#7952)
6656
6657 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6658 produced by %s or %c overflows available buffer space. (Bug#8545)
6659
6660 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6661
6662 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6663 (SIZE_MAX): Move defn after all includes, as they might #define it.
6664
6665 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6666
6667 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6668
6669 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6670
6671 * keyboard.c (Qdelayed_warnings_hook): Define.
6672 (command_loop_1): Run `delayed-warnings-hook'
6673 if Vdelayed_warnings_list is non-nil.
6674 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6675 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6676
6677 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6678
6679 * doprnt.c (doprnt): Don't return value smaller than the buffer
6680 size if the message was truncated. (Bug#8545).
6681
6682 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6683
6684 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6685 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6686
6687 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6688
6689 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6690
6691 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6692
6693 * makefile.w32-in: Update dependencies.
6694
6695 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6696
6697 Improve `doprnt' and its usage. (Bug#8545)
6698 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6699 `format_end'. Remove support for %l as a conversion specifier.
6700 Don't use xrealloc. Improve diagnostics when the %l size modifier
6701 is used. Update the commentary.
6702
6703 * eval.c (verror): Simplify calculation of size_t.
6704
6705 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6706 messages.
6707
6708 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6709
6710 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6711 change.
6712
6713 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6714
6715 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6716 This makes this file independent of the recent pseudovector change.
6717
6718 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6719
6720 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6721
6722 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6723 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6724 Remove unused local.
6725 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6726
6727 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6728 GCC 4.6.0 optimizes based on type-based alias analysis.
6729 For example, if b is of type struct buffer * and v of type struct
6730 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6731 != &v->size, and therefore "v->size = 1; b->size = 2; return
6732 v->size;" must therefore return 1. This assumption is incorrect
6733 for Emacs, since it type-puns struct Lisp_Vector * with many other
6734 types. To fix this problem, this patch adds a new type struct
6735 vectorlike_header that documents the constraints on layout of vectors
6736 and pseudovectors, and helps optimizing compilers not get fooled
6737 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6738 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6739 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6740 the size member.
6741 (XSETPVECTYPE): Rewrite in terms of new macro.
6742 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6743 This is a bit clearer, and further avoids the possibility of
6744 undesirable aliasing.
6745 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6746 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6747 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6748 since Lisp_Subr is a special case (no "next" field).
6749 (ASIZE): Now uses header.size rather than size.
6750 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6751 to avoid the hassle of writing XVECTOR (foo)->header.size.
6752 (struct vectorlike_header): New type.
6753 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6754 object, to help avoid aliasing.
6755 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6756 (SUBRP): Likewise, since Lisp_Subr is a special case.
6757 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6758 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6759 (struct Lisp_Hash_Table): Combine first two members into a single
6760 struct vectorlike_header member. All uses of "size" and "next" members
6761 changed to be "header.size" and "header.next".
6762 * buffer.h (struct buffer): Likewise.
6763 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6764 * frame.h (struct frame): Likewise.
6765 * process.h (struct Lisp_Process): Likewise.
6766 * termhooks.h (struct terminal): Likewise.
6767 * window.c (struct save_window_data, struct saved_window): Likewise.
6768 * window.h (struct window): Likewise.
6769 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6770 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6771 * buffer.c (init_buffer_once): Likewise.
6772 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6773 special case.
6774 * process.c (Fformat_network_address): Use local var for size,
6775 for brevity.
6776
6777 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6778
6779 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6780 * data.c (atof): Remove decl; no longer used or needed.
6781 (digit_to_number): Move to lread.c.
6782 (Fstring_to_number): Use new string_to_number function, to be
6783 consistent with how the Lisp reader treats infinities and NaNs.
6784 Do not assume that floating-point numbers represent EMACS_INT
6785 without losing information; this is not true on most 64-bit hosts.
6786 Avoid double-rounding errors, by insisting on integers when
6787 parsing non-base-10 numbers, as the documentation specifies.
6788 * lisp.h (string_to_number): New decl, replacing ...
6789 (isfloat_string): Remove.
6790 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6791 (read1): Do not accept +. and -. as integers; this
6792 appears to have been a coding error. Similarly, do not accept
6793 strings like +-1e0 as floating point numbers. Do not report
6794 overflow for integer overflows unless the base is not 10 which
6795 means we have no simple and reliable way to continue.
6796 Break out the floating-point parsing into a new
6797 function string_to_number, so that Fstring_to_number parses
6798 floating point numbers consistently with the Lisp reader.
6799 (digit_to_number): Move here from data.c. Make it static inline.
6800 (E_CHAR, EXP_INT): Remove, replacing with ...
6801 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6802 (string_to_number): New function, replacing isfloat_string.
6803 This function checks for valid syntax and produces the resulting
6804 Lisp float number too. Rework it so that string-to-number
6805 no longer mishandles examples like "1.0e+". Use strtoumax,
6806 so that overflow for non-base-10 numbers is reported only when
6807 there's no portable and simple way to convert to floating point.
6808
6809 * textprop.c (set_text_properties_1): Rewrite for clarity,
6810 and to avoid GCC warning about integer overflow.
6811
6812 * intervals.h (struct interval): Use EMACS_INT for members
6813 where EMACS_UINT might cause problems. See
6814 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6815 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6816 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6817 All uses changed.
6818 (offset_intervals): Tell GCC not to worry about length overflow
6819 when negating a negative length.
6820
6821 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6822 (overrun_check_free): Likewise.
6823
6824 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6825 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6826 word size.
6827
6828 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6829 (gnutls_make_error): Rename local to avoid shadowing.
6830 (gnutls_emacs_global_deinit): ifdef out; not used.
6831 (Fgnutls_boot): Use const for pointer to readonly storage.
6832 Comment out unused local. Fix pointer signedness problems.
6833
6834 * lread.c (openp): Don't stuff size_t into an 'int'.
6835 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6836 about possible signed overflow.
6837
6838 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6839 (GDK_KEY_g): Don't define if already defined.
6840 (xg_prepare_tooltip): Avoid pointer signedness problem.
6841 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6842
6843 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6844 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6845
6846 * xfns.c (Fx_window_property): Simplify a bit,
6847 to make a bit faster and to avoid GCC 4.6.0 warning.
6848 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6849
6850 * fns.c (internal_equal): Don't assume size_t fits in int.
6851
6852 * alloc.c (compact_small_strings): Tighten assertion a little.
6853
6854 Replace pEd with more-general pI, and fix some printf arg casts.
6855 * lisp.h (pI): New macro, generalizing old pEd macro to other
6856 conversion specifiers. For example, use "...%"pI"d..." rather
6857 than "...%"pEd"...".
6858 (pEd): Remove. All uses replaced with similar uses of pI.
6859 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6860 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6861 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6862 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6863 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6864 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6865 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6866 64-bit hosts.
6867 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6868 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6869 * print.c (safe_debug_print, print_object): Likewise.
6870 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6871 to int.
6872 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6873 avoiding the 0 flag, which is not portable.
6874 * process.c (Fmake_network_process): Use pI to avoid cast.
6875 * region-cache.c (pp_cache): Likewise.
6876 * xdisp.c (decode_mode_spec): Likewise.
6877 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6878 behavior on 64-bit hosts with printf arg.
6879 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6880 (x_stop_queuing_selection_requests): Likewise.
6881 (x_get_window_property): Don't truncate byte count to an 'int'
6882 when tracing.
6883
6884 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6885 here, since it parses constructs like leading '-' and spaces,
6886 which are not wanted; and it overflows with large numbers.
6887 Instead, simply match F[0-9]+, which is what is wanted anyway.
6888
6889 * alloc.c: Remove unportable assumptions about struct layout.
6890 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6891 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6892 (allocate_vectorlike, make_pure_vector): Use the new macros,
6893 plus offsetof, to remove unportable assumptions about struct layout.
6894 These assumptions hold on all porting targets that I know of, but
6895 they are not guaranteed, they're easy to remove, and removing them
6896 makes further changes easier.
6897
6898 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6899 This doesn't fix a bug but makes the code clearer.
6900 (string_overrun_cookie): Now const. Use initializers that
6901 don't formally overflow signed char, to avoid warnings.
6902 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6903 can cause Emacs to crash when string overrun checking is enabled.
6904 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6905 multiple of sizeof (EMACS_INT); it need not be, if
6906 alignof(EMACS_INT) < sizeof (EMACS_INT).
6907 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6908
6909 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6910
6911 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6912
6913 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6914
6915 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6916 supposed to be handshaking. (Bug#8556)
6917 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6918
6919 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6920
6921 * lisp.h (Qdebug): List symbol.
6922 * eval.c (Qdebug): Restore global linkage.
6923 * keyboard.c (debug-on-event): New variable.
6924 (handle_user_signal): Break into debugger when debug-on-event
6925 matches the current signal symbol.
6926
6927 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6928
6929 * alloc.c (check_sblock, check_string_bytes)
6930 (check_string_free_list): Convert to standard C.
6931
6932 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6933
6934 * w32.c (emacs_gnutls_push): Fix typo.
6935
6936 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6937
6938 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6939 "cast to pointer from integer of different size".
6940
6941 Improve doprnt and its use in verror. (Bug#8545)
6942 * doprnt.c (doprnt): Document the set of format control sequences
6943 supported by the function. Use SAFE_ALLOCA instead of always
6944 using `alloca'.
6945
6946 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6947 is one byte too soon. Don't use xrealloc; instead xfree and
6948 xmalloc anew.
6949
6950 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6951
6952 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6953 callbacks stage.
6954
6955 * gnutls.c: Renamed global_initialized to
6956 gnutls_global_initialized. Added internals for the
6957 :verify-hostname-error, :verify-error, and :verify-flags
6958 parameters of `gnutls-boot' and documented those parameters in the
6959 docstring. Start callback support.
6960 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6961 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6962 on error. Return error code.
6963 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6964 (emacs_gnutls_read): Likewise.
6965 (Fgnutls_boot): Return handshake error code.
6966 (emacs_gnutls_handle_error): New function.
6967 (wsaerror_to_errno): Likewise.
6968
6969 * w32.h (emacs_gnutls_pull): Add prototype.
6970 (emacs_gnutls_push): Likewise.
6971
6972 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6973 (emacs_gnutls_push): Likewise.
6974
6975 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6976
6977 * process.c (wait_reading_process_output): Check if GnuTLS
6978 buffered some data internally if no FDs are set for TLS
6979 connections.
6980
6981 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6982 (LIBS): Link to USER_LIBS.
6983 ($(BLD)/gnutls.$(0)): New target.
6984
6985 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6986
6987 * xdisp.c (handle_single_display_spec): Rename the
6988 display_replaced_before_p argument into display_replaced_p, to
6989 make it consistent with the commentary. Fix typos in the
6990 commentary.
6991
6992 * textprop.c (syms_of_textprop): Remove dead code.
6993 (copy_text_properties): Delete obsolete commentary about an
6994 interface that was deleted long ago. Fix typos in the description
6995 of arguments.
6996
6997 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6998 to changes in oldXMenu/XMenu.h from 2011-04-16.
6999 <menu_help_message, prev_menu_help_message>: Constify.
7000 (IT_menu_make_room): menu->help_text is now `const char **';
7001 adjust.
7002
7003 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7004 to changes in oldXMenu/XMenu.h from 2011-04-16.
7005 (struct XMenu): Declare `help_text' `const char **'.
7006
7007 * xfaces.c <Qunspecified>: Make extern again.
7008
7009 * syntax.c: Include sys/types.h before including regex.h, as
7010 required by Posix.
7011
7012 * doc.c (get_doc_string): Improve the format passed to `error'.
7013
7014 * doprnt.c (doprnt): Improve commentary.
7015
7016 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7017
7018 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7019 them with etags.
7020
7021 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7022 changes in globals.h immediately force recompilation.
7023 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7024 $(CURDIR)/s/ms-w32.h.
7025 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7026
7027 * character.c (Fchar_direction): Function deleted.
7028 (syms_of_character): Don't defsubr it.
7029 <char-direction-table>: Deleted.
7030
7031 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7032
7033 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7034 * doprnt.c: Include limits.h.
7035 (SIZE_MAX): New macro.
7036 (doprnt): Return a size_t value. 2nd arg is now size_t.
7037 Many local variables are now size_t instead of int or unsigned.
7038 Improve overflow protection. Support `l' modifier for integer
7039 conversions. Support %l conversion. Don't assume an EMACS_INT
7040 argument for integer conversions and for %c.
7041
7042 * lisp.h (doprnt): Restore prototype.
7043
7044 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7045 $(SRC)/character.h.
7046
7047 * Makefile.in (base_obj): Add back doprnt.o.
7048
7049 * deps.mk (doprnt.o): Add back prerequisites.
7050 (callint.o): Depend on character.h.
7051
7052 * eval.c (internal_lisp_condition_case): Include the handler
7053 representation in the error message.
7054 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7055 when breaking from the loop.
7056
7057 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7058
7059 * callint.c (Fcall_interactively): When displaying error message
7060 about invalid control letter, pass the character's codepoint, not
7061 a pointer to its multibyte form. Improve display of the character
7062 in octal and display also its hex code.
7063
7064 * character.c (char_string): Use %x to display the (unsigned)
7065 codepoint of an invalid character, to avoid displaying a bogus
7066 negative value.
7067
7068 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7069 `error', not SYMBOL_NAME itself.
7070
7071 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7072 character arguments to `error'.
7073
7074 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7075 to `error' in error message about FINAL_CHAR argument. Make sure
7076 FINAL_CHAR is a character, and use %c when it is passed as
7077 argument to `error'.
7078
7079 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7080
7081 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7082
7083 * w32.c: Include <time.h>.
7084 (sys_localtime): New function.
7085
7086 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7087
7088 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7089
7090 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7091
7092 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7093
7094 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7095 zombies (Bug#8467).
7096
7097 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7098
7099 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7100 gl_state.e_property when gl_state.object is Qt.
7101
7102 * insdel.c (make_gap_larger): Remove limitation of buffer size
7103 to <= INT_MAX.
7104
7105 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7106
7107 * xdisp.c (lookup_glyphless_char_display)
7108 (produce_glyphless_glyph): Handle cons cell entry in
7109 glyphless-char-display.
7110 (Vglyphless_char_display): Document it.
7111
7112 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7113 glyphless-char-display.
7114
7115 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7116
7117 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7118
7119 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7120
7121 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7122 definition for no-X builds.
7123
7124 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7125
7126 Static checks with GCC 4.6.0 and non-default toolkits.
7127
7128 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7129
7130 * process.c (keyboard_bit_set): Define only if SIGIO.
7131 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7132 (send_process): Repair possible setjmp clobbering.
7133
7134 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7135
7136 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7137
7138 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7139
7140 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7141 Define only if needed.
7142
7143 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7144 by pacifying GCC about it. Maybe it's time to retire it?
7145 * xfaces.c (USG, __TIMEVAL__): Likewise.
7146
7147 * dispextern.h (struct redisplay_interface): Rename param
7148 to avoid shadowing.
7149 * termhooks.h (struct terminal): Likewise.
7150 * xterm.c (xembed_send_message): Likewise.
7151
7152 * insdel.c (make_gap_smaller): Define only if
7153 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7154
7155 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7156 it.
7157
7158 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7159 so that we aren't warned about unused symbols.
7160
7161 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7162
7163 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7164
7165 * xfns.c (x_real_positions): Mark locals as initialized.
7166
7167 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7168
7169 * xterm.c: Fix problems found by static analysis with other toolkits.
7170 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7171 (x_dispatch_event): Declare static if USE_GTK, and
7172 define if USE_GTK || USE_X_TOOLKIT.
7173 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7174 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7175 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7176 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7177
7178 * xmenu.c (menu_help_callback): Pointer type fixes.
7179 Use const pointers when pointing at readonly data. Avoid pointer
7180 signedness clashes.
7181 (FALSE): Remove unused macro.
7182 (update_frame_menubar): Remove unused decl.
7183
7184 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7185
7186 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7187 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7188 (single_menu_item): Rename local to avoid shadowing.
7189
7190 * keyboard.c (make_lispy_event): Remove unused local var.
7191
7192 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7193 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7194
7195 * bitmaps: Change bitmaps from unsigned char back to the X11
7196 compatible char. Avoid the old compiler warnings about
7197 out-of-range initializers by using, for example, '\xab' rather
7198 than 0xab.
7199
7200 * xgselect.c (xgselect_initialize): Check vs interface
7201 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7202
7203 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7204
7205 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7206 to read-only memory.
7207
7208 * fns.c (vector): Remove; this old hack is no longer needed.
7209
7210 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7211 Remove unused var.
7212 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7213
7214 * xrdb.c (x_load_resources): Omit unused local.
7215
7216 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7217 (x_window): Rename locals to avoid shadowing.
7218 (USG): Use the kludged USG macro, to pacify gcc.
7219
7220 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7221 (x_term_init): Remove local to avoid shadowing.
7222
7223 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7224
7225 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7226 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7227
7228 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7229
7230 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7231
7232 Fix regex.c, syntax.c and friends for buffers > 2GB.
7233 * syntax.h (struct gl_state_s): Declare character position members
7234 EMACS_INT.
7235
7236 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7237
7238 * textprop.c (verify_interval_modification, interval_of):
7239 Declare arguments EMACS_INT.
7240
7241 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7242 EMACS_INT.
7243
7244 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7245
7246 * indent.c (Fvertical_motion): Local variable it_start is now
7247 EMACS_INT.
7248
7249 * regex.c (re_match, re_match_2, re_match_2_internal)
7250 (bcmp_translate, regcomp, regexec, print_double_string)
7251 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7252 (re_compile_pattern, re_exec): Declare arguments and local
7253 variables `size_t' and `ssize_t' and return values `regoff_t', as
7254 appropriate.
7255 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7256 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7257 <compile_stack_type>: `size' and `avail' are now `size_t'.
7258
7259 * regex.h <regoff_t>: Use ssize_t, not int.
7260 (re_search, re_search_2, re_match, re_match_2): Arguments that
7261 specify buffer/string position and length are now ssize_t and
7262 size_t. Return type is regoff_t.
7263
7264 2011-04-16 Ben Key <bkey76@gmail.com>
7265
7266 * nsfont.m: Fixed bugs in ns_get_family and
7267 ns_descriptor_to_entity that were caused by using free to
7268 deallocate memory blocks that were allocated by xmalloc (via
7269 xstrdup). This caused Emacs to crash when compiled with
7270 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7271 --enable-checking=xmallocoverrun). xfree is now used to
7272 deallocate these memory blocks.
7273
7274 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7275
7276 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7277
7278 emacs_write: Accept and return EMACS_INT for sizes.
7279 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7280 et seq.
7281 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7282 Accept and return EMACS_INT.
7283 (emacs_gnutls_write): Return the number of bytes written on
7284 partial writes.
7285 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7286 (emacs_read, emacs_write): Remove check for negative size, as the
7287 Emacs source code has been audited now.
7288 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7289 (emacs_read, emacs_write): Use it.
7290 * process.c (send_process): Adjust to the new signatures of
7291 emacs_write and emacs_gnutls_write. Do not attempt to store
7292 a byte offset into an 'int'; it might overflow.
7293 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7294
7295 * sound.c: Don't assume sizes fit in 'int'.
7296 (struct sound_device.period_size, alsa_period_size):
7297 Return EMACS_INT, not int.
7298 (struct sound_device.write, vox_write, alsa_write):
7299 Accept EMACS_INT, not int.
7300 (wav_play, au_play): Use EMACS_INT to store sizes and to
7301 record read return values.
7302
7303 2011-04-15 Ben Key <bkey76@gmail.com>
7304
7305 * keyboard.c (Qundefined): Don't declare static since it is used
7306 in nsfns.m.
7307 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7308 static since they are used in nsfont.m.
7309
7310 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7311
7312 * process.c (Qprocessp): Don't declare static.
7313 * lisp.h (Qprocessp): Declare again.
7314
7315 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7316
7317 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7318
7319 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7320
7321 Improve C-level modularity by making more things 'static'.
7322
7323 Don't publish debugger-only interfaces to other modules.
7324 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7325 (verify_bytepos, count_markers): Move decls to the only modules
7326 that need them.
7327 * region-cache.h (pp_cache): Likewise.
7328 * window.h (check_all_windows): Likewise.
7329 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7330
7331 * sysdep.c (croak): Now static, if
7332 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7333 * syssignal.h (croak): Declare only if not static.
7334
7335 * alloc.c (refill_memory_reserve): Now static if
7336 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7337 * lisp.h (refill_memory_reserve): Declare only if not static.
7338
7339 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7340 Define only if USE_LUCID.
7341
7342 * xrdb.c (x_customization_string, x_rm_string): Now static.
7343
7344 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7345 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7346
7347 * xdisp.c (draw_row_with_mouse_face): Now static.
7348 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7349
7350 * window.h (check_all_windows): Mark externally visible.
7351
7352 * window.c (window_deletion_count): Now static.
7353
7354 * undo.c: Make symbols static if they're not exported.
7355 (last_undo_buffer, last_boundary_position, pending_boundary):
7356 Now static.
7357
7358 * textprop.c (interval_insert_behind_hooks): Now static.
7359 (interval_insert_in_front_hooks): Likewise.
7360
7361 * term.c: Make symbols static if they're not exported.
7362 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7363 (max_frame_lines, tty_set_terminal_modes):
7364 (tty_reset_terminal_modes, tty_turn_off_highlight):
7365 (get_tty_terminal): Now static.
7366 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7367 * termhooks.h (term_mouse_moveto): Do not declare if
7368 HAVE_WINDOW_SYSTEM.
7369 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7370 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7371
7372 * sysdep.c: Make symbols static if they're not exported.
7373 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7374 Now static.
7375 (sigprocmask_set, full_mask): Remove; unused.
7376 (wait_debugging): Mark as visible.
7377 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7378 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7379
7380 * syntax.c (syntax_temp): Define only if !__GNUC__.
7381
7382 * sound.c (current_sound_device, current_sound): Now static.
7383
7384 * search.c (searchbufs, searchbuf_head): Now static.
7385
7386 * scroll.c (scroll_cost): Remove; unused.
7387 * dispextern.h (scroll_cost): Remove decl.
7388
7389 * region-cache.h (pp_cache): Mark as externally visible.
7390
7391 * process.c: Make symbols static if they're not exported.
7392 (process_tick, update_tick, create_process, chan_process):
7393 (Vprocess_alist, proc_buffered_char, datagram_access):
7394 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7395 (deactivate_process): Mark defn as static, as well as decl.
7396 * lisp.h (create_process): Remove decl.
7397 * process.h (chan_process, Vprocess_alist): Remove decls.
7398
7399 * print.c: Make symbols static if they're not exported.
7400 (print_depth, new_backquote_output, being_printed, print_buffer):
7401 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7402 (print_interval, print_number_index, initial_stderr_stream):
7403 Now static.
7404 * lisp.h (Fprinc): Remove decl.
7405 (debug_output_compilation_hack): Mark as externally visible.
7406
7407 * sysdep.c (croak): Move decl from here to syssignal.h.
7408 * syssignal.h (croak): Put it here, so the API can be checked when
7409 'croak' is called from dissociate_if_controlling_tty.
7410
7411 * minibuf.c: Make symbols static if they're not exported.
7412 (minibuf_save_list, choose_minibuf_frame): Now static.
7413 * lisp.h (choose_minibuf_frame): Remove decl.
7414
7415 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7416
7417 * lread.c: Make symbols static if they're not exported.
7418 (read_objects, initial_obarray, oblookup_last_bucket_number):
7419 Now static.
7420 (make_symbol): Remove; unused.
7421 * lisp.h (initial_obarray, make_symbol): Remove decls.
7422
7423 * keyboard.c: Make symbols static if they're not exported.
7424 (single_kboard, recent_keys_index, total_keys, recent_keys):
7425 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7426 (this_single_command_key_start, echoing, last_auto_save):
7427 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7428 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7429 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7430 (Vlispy_mouse_stem, double_click_count):
7431 Now static.
7432 (force_auto_save_soon): Define only if SIGDANGER.
7433 (ignore_mouse_drag_p): Now static if
7434 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7435 (print_help): Remove; unused.
7436 (stop_character, last_timer_event): Mark as externally visible.
7437 * keyboard.h (ignore_mouse_drag_p): Declare only if
7438 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7439 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7440 * lisp.h (echoing): Remove decl.
7441 (force_auto_save_soon): Declare only if SIGDANGER.
7442 * xdisp.c (redisplay_window): Simplify code, to make it more
7443 obvious that ignore_mouse_drag_p is not accessed if !defined
7444 USE_GTK && !defined HAVE_NS.
7445
7446 * intervals.c: Make symbols static if they're not exported.
7447 (merge_properties_sticky, merge_interval_right, delete_interval):
7448 Now static.
7449 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7450
7451 * insdel.c: Make symbols static if they're not exported.
7452 However, leave prepare_to_modify_buffer alone. It's never
7453 called from outside this function, but that appears to be a bug.
7454 (combine_after_change_list, combine_after_change_buffer):
7455 (adjust_after_replace, signal_before_change): Now static.
7456 (adjust_after_replace_noundo): Remove; unused.
7457 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7458 (signal_before_change): Remove decls.
7459
7460 * indent.c (val_compute_motion, val_vmotion): Now static.
7461
7462 * image.c: Make symbols static if they're not exported.
7463 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7464 if USE_GTK.
7465 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7466 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7467
7468 * fringe.c (standard_bitmaps): Now static.
7469 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7470
7471 * frame.c: Make symbols static if they're not exported.
7472 (x_report_frame_params, make_terminal_frame): Now static.
7473 (get_frame_param): Now static, unless HAVE_NS.
7474 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7475 (x_get_resource_string): Remove; not used.
7476 * frame.h (make_terminal_frame, x_report_frame_params):
7477 (x_get_resource_string); Remove decls.
7478 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7479 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7480
7481 * font.c, fontset.c: Make symbols static if they're not exported.
7482 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7483 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7484 * font.c (font_close_object): Now static.
7485 * font.h (font_close_object): Remove.
7486 * fontset.c (FONTSET_OBJLIST): Remove.
7487 (free_realized_fontset) #if-0 the body, which does nothing.
7488 (face_suitable_for_char_p): #if-0, as it's never called.
7489 * fontset.h (face_suitable_for_char_p): Remove decl.
7490 * xfaces.c (face_at_string_position):
7491 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7492 since 0 is always ASCII.
7493
7494 * fns.c (weak_hash_tables): Now static.
7495
7496 * fileio.c: Make symbols static if they're not exported.
7497 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7498 (Vwrite_region_annotation_buffers): Now static.
7499
7500 * eval.c: Make symbols static if they're not exported.
7501 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7502 * lisp.h (backtrace_list): Remove decl.
7503
7504 * emacs.c: Make symbols static if they're not exported.
7505 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7506 (fatal_error_code, fatal_error_signal_hook, standard_args):
7507 Now static.
7508 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7509 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7510 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7511 * lisp.h (fatal_error_signal_hook): Remove decl.
7512 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7513
7514 * editfns.c: Move a (normally-unused) function to its only use.
7515 * editfns.c, lisp.h (get_operating_system_release): Remove.
7516 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7517 worth the hassle of breaking this out.
7518
7519 * xterm.c: Make symbols static if they're not exported.
7520 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7521 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7522 (x_destroy_window, x_delete_display):
7523 Now static.
7524 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7525 (x_mouse_leave): Remove; unused.
7526 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7527 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7528 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7529 Remove decls.
7530 (x_mouse_leave): Declare only if WINDOWSNT.
7531 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7532 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7533 USE_X_TOOLKIT.
7534
7535 * ftxfont.c: Make symbols static if they're not exported.
7536 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7537 HAVE_FREETYPE.
7538 * font.h (ftxfont_driver): Likewise.
7539
7540 * xfns.c: Make symbols static if they're not exported.
7541 (x_last_font_name, x_display_info_for_name):
7542 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7543 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7544 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7545 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7546 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7547 (last_show_tip_args): Now static.
7548 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7549 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7550 (x_screen_planes): Remove; unused.
7551 * dispextern.h (x_screen_planes): Remove decl.
7552
7553 * dispnew.c: Make symbols static if they're not exported.
7554 * dispextern.h (redraw_garbaged_frames, scrolling):
7555 (increment_row_positions): Remove.
7556 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7557 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7558 Now static.
7559 (redraw_garbaged_frames): Remove; unused.
7560
7561 * xfaces.c: Make symbols static if they're not exported.
7562 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7563 Remove decls.
7564 * xterm.h (defined_color): Remove decls.
7565 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7566 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7567 (menu_face_changed_default, defined_color, free_realized_face):
7568 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7569 (ascii_face_of_lisp_face): Remove; unused.
7570
7571 * xdisp.c: Make symbols static if they're not exported.
7572 * dispextern.h (scratch_glyph_row, window_box_edges):
7573 (glyph_to_pixel_coords, set_cursor_from_row):
7574 (get_next_display_element, set_iterator_to_next):
7575 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7576 (show_mouse_face): Remove decls
7577 * frame.h (message_buf_print): Likewise.
7578 * lisp.h (pop_message, set_message, check_point_in_composition):
7579 Likewise.
7580 * xterm.h (set_vertical_scroll_bar): Likewise.
7581 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7582 (message_buf_print, scratch_glyph_row, displayed_buffer):
7583 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7584 (get_next_display_element, show_mouse_face, window_box_edges):
7585 (frame_to_window_pixel_xy, check_point_in_composition):
7586 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7587 (glyph_to_pixel_coords): Remove; unused.
7588
7589 * dired.c (file_name_completion): Now static.
7590
7591 * dbusbind.c (xd_in_read_queued_messages): Now static.
7592
7593 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7594 * data.c (circular_list_error): Remove.
7595
7596 * commands.h (last_point_position, last_point_position_buffer):
7597 (last_point_position_window): Remove decls.
7598 * keyboard.c: Make these variables static.
7599
7600 * coding.h (coding, code_convert_region, encode_coding_gap):
7601 Remove decls.
7602 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7603 (iso_code_class, detect_coding, code_convert_region): Now static.
7604 (encode_coding_gap): Remove; unused.
7605
7606 * chartab.c (chartab_chars, chartab_bits): Now static.
7607
7608 * charset.h (charset_iso_8859_1): Remove decl.
7609 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7610 Now static.
7611
7612 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7613 * ccl.c (Vccl_program_table): Now static.
7614 (check_ccl_update): Remove; unused.
7615
7616 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7617 * category.h: ... from here.
7618 * category.c (check_category_table, set_category_set): Now static.
7619
7620 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7621 * lisp.h: Remove these decls.
7622
7623 * buffer.c (buffer_count): Remove unused var.
7624
7625 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7626 so that it's not optimized away.
7627 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7628 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7629 exported only to the debugger.
7630
7631 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7632 * atimer.h (run_all_atimers): Remove; not exported.
7633
7634 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7635 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7636 was inaccessible from Lisp.
7637 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7638 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7639
7640 alloc.c: Import and export fewer symbols, and remove unused items.
7641 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7642 is defined.
7643 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7644 it's not optimized away by whole-program optimization.
7645 (message_enable_multibyte, free_misc): Remove.
7646 (catchlist, handlerlist, mark_backtrace):
7647 Declare only if BYTE_MARK_STACK.
7648 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7649 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7650 (message_enable_multibyte): Remove decl.
7651 (free_misc, interval_free_list, float_block, float_block_index):
7652 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7653 (cons_free_list, last_marked_index):
7654 Now static.
7655 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7656 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7657 (mark_backtrace): Define only if BYTE_MARK_STACK.
7658 * xdisp.c (message_enable_multibyte): Now static.
7659
7660 Declare Lisp_Object Q* variables to be 'static' if not exported.
7661 This makes it easier for human readers (and static analyzers)
7662 to see whether these variables are used from other modules.
7663 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7664 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7665 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7666 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7667 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7668 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7669 * xmenu.c, xselect.c:
7670 Declare Q* vars static if they are not used in other modules.
7671 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7672 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7673 Remove decls of unexported vars.
7674 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7675
7676 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7677
7678 Make Emacs functions such as Fatom 'static' by default.
7679 This makes it easier for human readers (and static analyzers)
7680 to see whether these functions can be called from other modules.
7681 DEFUN now defines a static function. To make the function external
7682 so that it can be used in other C modules, use the new macro DEFUE.
7683 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7684 (Finit_image_library):
7685 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7686 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7687 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7688 Remove decls, since these functions are now static.
7689 (Funintern, Fget_internal_run_time): New decls, since these functions
7690 were already external.
7691
7692 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7693 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7694 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7695 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7696 * keyboard.c, keymap.c, lread.c:
7697 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7698 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7699 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7700 Mark functions with DEFUE instead of DEFUN,
7701 if they are used in other modules.
7702 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7703 decls for now-static functions.
7704 * buffer.h (Fdelete_overlay): Remove decl.
7705 * callproc.c (Fgetenv_internal): Mark as internal.
7706 * composite.c (Fremove_list_of_text_properties): Remove decl.
7707 (Fcomposition_get_gstring): New forward static decl.
7708 * composite.h (Fcomposite_get_gstring): Remove decl.
7709 * dired.c (Ffile_attributes): New forward static decl.
7710 * doc.c (Fdocumntation_property): New forward static decl.
7711 * eval.c (Ffetch_bytecode): New forward static decl.
7712 (Funintern): Remove extern decl; now in .h file where it belongs.
7713 * fileio.c (Fmake_symbolic_link): New forward static decl.
7714 * image.c (Finit_image_library): New forward static decl.
7715 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7716 * intervals.h (Fprevious_property_change):
7717 (Fremove_list_of_text_properties): Remove decls.
7718 * keyboard.c (Fthis_command_keys): Remove decl.
7719 (Fcommand_execute): New forward static decl.
7720 * keymap.c (Flookup_key): New forward static decl.
7721 (Fcopy_keymap): Now static.
7722 * keymap.h (Flookup_key): Remove decl.
7723 * process.c (Fget_process): New forward static decl.
7724 (Fprocess_datagram_address): Mark as internal.
7725 * syntax.c (Fsyntax_table_p): New forward static decl.
7726 (skip_chars): Remove duplicate decl.
7727 * textprop.c (Fprevious_property_change): New forward static decl.
7728 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7729 Now internal.
7730 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7731 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7732
7733 * editfns.c (Fformat): Remove unreachable code.
7734
7735 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7736
7737 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7738 change. (Bug#8496)
7739
7740 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7741
7742 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7743 when at ZV. (Bug#8487)
7744
7745 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7746
7747 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7748 (Bug#8437)
7749 * keyboard.c (parse_tool_bar_item): Likewise.
7750 * sound.c (sound_cleanup, alsa_close): Likewise.
7751 * termcap.c (tgetent): Likewise.
7752 * xfns.c (x_default_font_parameter): Likewise.
7753 * xsettings.c (read_and_apply_settings): Likewise.
7754
7755 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7756 (overrun_check_free): Protoize.
7757
7758 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7759
7760 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7761 since callers should never pass a negative size.
7762 Change the signature to match that of plain 'read' and 'write'; see
7763 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7764 * lisp.h: Update prototypes of emacs_write and emacs_read.
7765
7766 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7767
7768 * xdisp.c (redisplay_window): Don't try to determine the character
7769 position of the scroll margin if the window start point w->startp
7770 is outside the buffer's accessible region. (Bug#8468)
7771
7772 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7773
7774 Fix write-region and its subroutines for buffers > 2GB.
7775 * fileio.c (a_write, e_write): Modify declaration of arguments and
7776 local variables to support buffers larger than 2GB.
7777 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7778
7779 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7780 argument, local variables, and return value.
7781
7782 * lisp.h: Update prototypes of emacs_write and emacs_read.
7783
7784 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7785
7786 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7787
7788 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7789
7790 Fix more problems found by GCC 4.6.0's static checks.
7791
7792 * xdisp.c (vmessage): Use a better test for character truncation.
7793
7794 * charset.c (load_charset_map): <, not <=, for optimization,
7795 and to avoid potential problems with integer overflow.
7796 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7797 * casetab.c (set_identity, shuffle): Likewise.
7798 * editfns.c (Fformat): Likewise.
7799 * syntax.c (skip_chars): Likewise.
7800
7801 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7802 This also lets GCC 4.6.0 generate slightly better loop code.
7803
7804 * callint.c (Fcall_interactively): <, not <=, for optimization.
7805 (Fcall_interactively): Count the number of arguments produced,
7806 not the number of arguments given. This is simpler and lets GCC
7807 4.6.0 generate slightly better code.
7808
7809 * ftfont.c: Distingish more carefully between FcChar8 and char.
7810 The previous code passed unsigned char * to a functions like
7811 strlen and xstrcasecmp that expect char *, which does not
7812 conform to the C standard.
7813 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7814 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7815 char * when the C standard requires it.
7816
7817 * keyboard.c (read_char): Remove unused var.
7818
7819 * eval.c: Port to Windows vsnprintf (Bug#8435).
7820 Include <limits.h>.
7821 (SIZE_MAX): Define if the headers do not.
7822 (verror): Do not give up if vsnprintf returns a negative count.
7823 Instead, grow the buffer. This ports to Windows vsnprintf, which
7824 does not conform to C99. Problem reported by Eli Zaretskii.
7825 Also, simplify the allocation scheme, by avoiding the need for
7826 calling realloc, and removing the ALLOCATED variable.
7827
7828 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7829
7830 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7831 But keep the doprint source code for now, as we might revamp it
7832 and use it again (Bug#8435).
7833 * lisp.h (doprnt): Remove.
7834 * Makefile.in (base_obj): Remove doprnt.o.
7835 * deps.mk (doprnt.o): Remove.
7836
7837 error: Print 32- and 64-bit integers portably (Bug#8435).
7838 Without this change, on typical 64-bit hosts error ("...%d...", N)
7839 was used to print both 32- and 64-bit integers N, which relied on
7840 undefined behavior.
7841 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7842 * lisp.h (error, verror): Mark as printf-like functions.
7843 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7844 Report overflow in size calculations when allocating printf buffer.
7845 Do not truncate output string at its first null byte.
7846 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7847 Truncate the output at a character boundary, since vsnprintf does not
7848 do that.
7849 * charset.c (check_iso_charset_parameter): Convert internal
7850 character to string before calling 'error', since %c now has the
7851 printf meaning.
7852 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7853 overflow when computing char to be passed to 'error'. Do not
7854 pass Lisp_Object to 'error'; pass the integer instead.
7855 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7856 formatted with plain %d.
7857
7858 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7859
7860 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7861
7862 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7863
7864 * xterm.c (x_catch_errors): Remove duplicate declaration.
7865
7866 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7867
7868 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7869
7870 2011-04-10 Jim Meyering <meyering@redhat.com>
7871
7872 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7873 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7874 return ssize_t not "int", and use size_t as the buffer length.
7875 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7876 * gnutls.h: Update declarations.
7877 * process.c (read_process_output): Use ssize_t, to match.
7878 (send_process): Likewise.
7879
7880 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7881
7882 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7883
7884 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7885
7886 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7887 Use unsigned char, to match FcChar8 type definition.
7888
7889 * xterm.c (handle_one_xevent):
7890 * xmenu.c (create_and_show_popup_menu):
7891 * xselect.c (x_decline_selection_request)
7892 (x_reply_selection_request): Avoid type-punned deref of X events.
7893
7894 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7895
7896 Fix some uses of `int' instead of EMACS_INT.
7897 * search.c (string_match_1, fast_string_match)
7898 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7899 (scan_buffer, find_next_newline_no_quit)
7900 (find_before_next_newline, search_command, Freplace_match)
7901 (Fmatch_data): Make some `int' variables be EMACS_INT.
7902
7903 * xdisp.c (display_count_lines): 3rd argument and return value now
7904 EMACS_INT. All callers changed.
7905 (pint2hrstr): Last argument is now EMACS_INT.
7906
7907 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7908 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7909 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7910 (decode_coding_utf_16, decode_coding_emacs_mule)
7911 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7912 (decode_coding_ccl, decode_coding_charset)
7913 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7914 (decode_coding_iso_2022, decode_coding_emacs_mule)
7915 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7916 <char_offset, last_offset>: Declare EMACS_INT.
7917 (encode_coding_utf_8, encode_coding_utf_16)
7918 (encode_coding_emacs_mule, encode_invocation_designation)
7919 (encode_designation_at_bol, encode_coding_iso_2022)
7920 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7921 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7922 Declare EMACS_INT.
7923 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7924 (encode_invocation_designation): Last argument P_NCHARS is now
7925 EMACS_INT.
7926 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7927 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7928
7929 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7930 All users changed.
7931
7932 * ccl.c (Fccl_execute_on_string): Declare some variables
7933 EMACS_INT.
7934
7935 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7936
7937 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7938
7939 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7940
7941 * process.c (Fformat_network_address): Doc fix.
7942
7943 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7944
7945 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7946
7947 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7948
7949 * keyboard.c (read_char): Call Lisp function help-form-show,
7950 instead of using internal_with_output_to_temp_buffer.
7951 (Qhelp_form_show): New var.
7952 (syms_of_keyboard): Use DEFSYM macro.
7953
7954 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7955
7956 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7957
7958 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7959
7960 * process.c (Flist_processes): Remove to Lisp.
7961 (list_processes_1): Delete.
7962
7963 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7964
7965 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7966
7967 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7968
7969 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7970
7971 Fix more problems found by GCC 4.6.0's static checks.
7972
7973 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7974
7975 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7976
7977 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7978
7979 * xdisp.c (vmessage): Mark as a printf-like function.
7980
7981 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7982
7983 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7984
7985 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7986 printf-like functions.
7987 (tiff_load): Add casts to remove these marks before passing them
7988 to system-supplied API.
7989
7990 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7991
7992 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7993 This avoids several warnings with gcc -Wstrict-overflow.
7994 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7995 directly, rather than having caller test rule sign. This avoids
7996 some unnecessary tests.
7997 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7998 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7999 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8000
8001 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8002 (xfont_open): Avoid unnecessary tests.
8003
8004 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8005
8006 * composite.h, composite.c (composition_gstring_put_cache):
8007 Use EMACS_INT, not int, for length.
8008
8009 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8010 breaking out part of COMPOSITION_DECODE_RULE.
8011 (COMPOSITION_DECODE_RULE): Use it.
8012 * composite.c (get_composition_id): Remove unused local vars,
8013 by using the new macro.
8014
8015 * textprop.c (set_text_properties_1): Change while to do-while,
8016 since the condition is always true at first.
8017
8018 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8019 (interval_deletion_adjustment): Return unsigned value.
8020 All uses changed.
8021
8022 * process.c (list_processes_1, create_pty, read_process_output):
8023 (exec_sentinel): Remove vars that were set but not used.
8024 (create_pty): Remove unnecessary "volatile"s.
8025 (Fnetwork_interface_info): Avoid possibility of int overflow.
8026 (read_process_output): Do adaptive read buffering even if carryover.
8027 (read_process_output): Simplify nbytes computation if buffered.
8028
8029 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8030
8031 * syntax.c (scan_words): Remove var that was set but not used.
8032 (update_syntax_table): Use unsigned instead of int.
8033
8034 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8035 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8036 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8037
8038 * print.c (print_error_message): Avoid int overflow.
8039
8040 * font.c (font_list_entities): Redo for clarity,
8041 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8042
8043 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8044 (font_score): Avoid potential overflow in diff calculation.
8045
8046 * fns.c (substring_both): Remove var that is set but not used.
8047 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8048
8049 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8050
8051 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8052 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8053 can always succeed if overflow has undefined behavior.
8054
8055 * search.c (boyer_moore, wordify): Remove vars set but not used.
8056 (wordify): Omit three unnecessary tests.
8057
8058 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8059 All callers changed. This avoids the need for an unused var.
8060
8061 * casefiddle.c (casify_region): Remove var that is set but not used.
8062
8063 * dired.c (file_name_completion): Remove var that is set but not used.
8064
8065 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8066
8067 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8068 (Finsert_file_contents): Remove unnecessary code checking fd.
8069
8070 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8071 Check for integer overflow on size calculations.
8072
8073 * buffer.c (Fprevious_overlay_change): Remove var that is set
8074 but not used.
8075
8076 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8077 Remove vars that are set but not used.
8078 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8079 (timer_check_2): Mark vars as initialized.
8080
8081 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8082
8083 * image.c (lookup_image): Remove var that is set but not used.
8084 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8085
8086 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8087 that are set but not used.
8088
8089 * xfns.c (make_invisible_cursor): Don't return garbage
8090 if XCreateBitmapFromData fails (Bug#8410).
8091
8092 * xselect.c (x_get_local_selection, x_handle_property_notify):
8093 Remove vars that are set but not used.
8094
8095 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8096 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8097
8098 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8099 Remove var that is set but not used.
8100 (scroll_bar_windows_size): Now size_t, not int.
8101 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8102 Check for overflow.
8103
8104 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8105 (map_tty_color) [!defined MSDOS]: Likewise.
8106
8107 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8108
8109 * coding.c: Remove vars that are set but not used.
8110 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8111 All callers changed.
8112 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8113 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8114 (decode_coding_charset): Remove vars that are set but not used.
8115
8116 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8117 that is set but not used.
8118
8119 * print.c (print_object): Remove var that is set but not used.
8120
8121 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8122 The gnulib version avoids calling malloc in the usual case,
8123 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8124 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8125 * filelock.c (current_lock_owner): Likewise.
8126 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8127 * sysdep.c: Include allocator.h, careadlinkat.h.
8128 (emacs_no_realloc_allocator): New static constant.
8129 (emacs_readlink): New function.
8130 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8131 ../lib/careadlinkat.h.
8132
8133 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8134
8135 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8136 first non-nil return value).
8137
8138 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8139
8140 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8141 if not defined (Bug#8403).
8142
8143 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8144
8145 * xdisp.c (display_count_lines): Remove parameter `start',
8146 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8147 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8148 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8149 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8150 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8151 and thereabouts. All callers changed.
8152 (get_per_char_metric): Remove parameter `f', unused since
8153 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8154
8155 2011-04-02 Jim Meyering <meyering@redhat.com>
8156
8157 do not dereference NULL upon failed strdup
8158 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8159 (ns_get_family): Likewise.
8160
8161 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8162
8163 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8164
8165 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8166
8167 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8168 later (Bug#8403).
8169
8170 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8171
8172 Add lexical binding.
8173
8174 * window.c (Ftemp_output_buffer_show): New fun.
8175 (Fsave_window_excursion):
8176 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8177
8178 * lread.c (lisp_file_lexically_bound_p): New function.
8179 (Fload): Bind Qlexical_binding.
8180 (readevalloop): Remove `evalfun' arg.
8181 Bind Qinternal_interpreter_environment.
8182 (Feval_buffer): Bind Qlexical_binding.
8183 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8184 Mark as dynamic.
8185 (syms_of_lread): Declare `lexical-binding'.
8186
8187 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8188
8189 * keyboard.c (eval_dyn): New fun.
8190 (menu_item_eval_property): Use it.
8191
8192 * image.c (parse_image_spec): Use Ffunctionp.
8193
8194 * fns.c (concat, mapcar1): Accept byte-code-functions.
8195
8196 * eval.c (Fsetq): Handle lexical vars.
8197 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8198 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8199 (FletX, Flet): Obey lexical binding.
8200 (Fcommandp): Handle closures.
8201 (Feval): New `lexical' arg.
8202 (eval_sub): New function extracted from Feval. Use it almost
8203 everywhere where Feval was used. Look up vars in lexical env.
8204 Handle closures.
8205 (Ffunctionp): Move from subr.el.
8206 (Ffuncall): Handle closures.
8207 (apply_lambda): Remove `eval_flags'.
8208 (funcall_lambda): Handle closures and new byte-code-functions.
8209 (Fspecial_variable_p): New function.
8210 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8211 but without exporting it to Lisp.
8212
8213 * doc.c (Fdocumentation, store_function_docstring):
8214 * data.c (Finteractive_form): Handle closures.
8215
8216 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8217 interactive spec.
8218
8219 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8220 New byte-codes.
8221 (exec_byte_code): New function extracted from Fbyte_code to handle new
8222 calling convention for byte-code-functions. Add new byte-codes.
8223
8224 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8225
8226 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8227
8228 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8229
8230 * xdisp.c (redisplay_internal): Fix prototype.
8231
8232 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8233
8234 * xdisp.c (SCROLL_LIMIT): New macro.
8235 (try_scrolling): Use it when setting scroll_limit.
8236 Limit scrolling to 100 screen lines.
8237 (redisplay_window): Even when falling back on "recentering",
8238 position point in the window according to scroll-conservatively,
8239 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8240
8241 (try_scrolling): When point is above the window, allow searching
8242 as far as scroll_max, or one screenful, to compute vertical
8243 distance from PT to the scroll margin position. This prevents
8244 try_scrolling from unnecessarily failing when
8245 scroll-conservatively is set to a value slightly larger than the
8246 window height. Clean up the case of PT below the margin at bottom
8247 of window: scroll_max can no longer be INT_MAX. When aggressive
8248 scrolling is in use, don't let point enter the opposite scroll
8249 margin as result of the scroll.
8250 (syms_of_xdisp) <scroll-conservatively>: Document the
8251 threshold of 100 lines for never-recentering scrolling.
8252
8253 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8254
8255 * dispextern.h (move_it_by_lines):
8256 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8257 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8258 (message_log_check_duplicate): Remove parameters `prev_bol' and
8259 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8260 (redisplay_internal): Remove parameter `preserve_echo_area',
8261 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8262
8263 * indent.c (Fvertical_motion):
8264 * window.c (window_scroll_pixel_based, Frecenter):
8265 Don't pass `need_y_p' to `move_it_by_lines'.
8266
8267 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8268
8269 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8270 steal a few bits to be more compact.
8271 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8272 Remove unneeded casts.
8273
8274 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8275
8276 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8277
8278 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8279 binding" message (bug#7967).
8280
8281 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8282
8283 Fix more problems found by GCC 4.6.0's static checks.
8284
8285 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8286 Remove unused local var.
8287
8288 * editfns.c (Fmessage_box): Remove unused local var.
8289
8290 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8291 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8292 Omit unused local vars.
8293 * window.c (shrink_windows): Omit unused local var.
8294 * menu.c (digest_single_submenu): Omit unused local var.
8295 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8296 Omit unused local var.
8297
8298 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8299 Don't assume string length fits in int.
8300 (keyremap_step, read_key_sequence): Use size_t for sizes.
8301 (read_key_sequence): Don't check last_real_key_start redundantly.
8302
8303 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8304 instead of alloca (Bug#8344).
8305
8306 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8307 (Fbacktrace_frame): Don't assume nframes fits in int.
8308
8309 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8310
8311 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8312 concerns.
8313
8314 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8315
8316 * cm.c (calccost): Turn while-do into do-while, for clarity.
8317
8318 * keyboard.c (syms_of_keyboard): Use the same style as later
8319 in this function when indexing through an array. This also
8320 works around GCC bug 48267.
8321
8322 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8323
8324 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8325
8326 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8327 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8328
8329 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8330 This avoids undefined behavior on integer overflow, and is a bit
8331 more convenient anyway since it is compared to a size_t variable.
8332
8333 Variadic C functions now count arguments with size_t, not int.
8334 This avoids an unnecessary limitation on 64-bit machines, which
8335 caused (substring ...) to crash on large vectors (Bug#8344).
8336 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8337 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8338 All variadic functions and their callers changed accordingly.
8339 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8340 * data.c (arith_driver, float_arith_driver): Likewise.
8341 * editfns.c (general_insert_function): Likewise.
8342 * eval.c (struct backtrace.nargs, interactive_p)
8343 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8344 (funcall_lambda, mark_backtrace): Likewise.
8345 * fns.c (concat): Likewise.
8346 * frame.c (x_set_frame_parameters): Likewise.
8347 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8348 0 if not found, not -1. All callers changed.
8349
8350 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8351 (stack_copy_size): Now size_t, not int.
8352 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8353
8354 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8355
8356 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8357 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8358 All callers changed.
8359
8360 * lisp.h (multibyte_char_to_unibyte):
8361 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8362 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8363 * character.h (CHAR_TO_BYTE8):
8364 * cmds.c (internal_self_insert):
8365 * editfns.c (general_insert_function):
8366 * keymap.c (push_key_description):
8367 * search.c (Freplace_match):
8368 * xdisp.c (message_dolog, set_message_1): All callers changed.
8369
8370 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8371
8372 * keyboard.c (safe_run_hook_funcall): New function.
8373 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8374 don't set the hook to nil, but remove the offending function instead.
8375 (Qcommand_hook_internal): Remove, unused.
8376 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8377 Vcommand_hook_internal.
8378
8379 * eval.c (enum run_hooks_condition): Remove.
8380 (funcall_nil, funcall_not): New functions.
8381 (run_hook_with_args): Call each function through a `funcall' argument.
8382 Remove `cond' argument, now redundant.
8383 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8384 (Frun_hook_with_args_until_failure): Adjust accordingly.
8385 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8386
8387 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * dispextern.h (string_buffer_position): Remove declaration.
8390
8391 * print.c (strout): Remove parameter `multibyte', unused since
8392 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8393
8394 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8395 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8396 All callers changed.
8397
8398 * w32.c (_wsa_errlist): Use braces for struct initializers.
8399
8400 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8401 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8402 All callers changed.
8403 (string_buffer_position): Likewise. Also, make static (it's never
8404 used outside xdisp.c).
8405 (cursor_row_p): Remove parameter `w', unused since
8406 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8407 (decode_mode_spec): Remove parameter `precision', introduced during
8408 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8409 All callers changed.
8410
8411 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8412
8413 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8414
8415 2011-03-27 Anders Lindgren <andlind@gmail.com>
8416
8417 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8418 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8419 (ns_update_auto_hide_menu_bar): New functions.
8420 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8421 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8422 ns_constrain_all_frames.
8423 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8424 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8425
8426 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8427
8428 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8429
8430 2011-03-27 Glenn Morris <rgm@gnu.org>
8431
8432 * syssignal.h: Replace RETSIGTYPE with void.
8433 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8434 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8435 Replace SIGTYPE with void everywhere.
8436 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8437 * s/template.h (SIGTYPE): Remove commented out definition.
8438
8439 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8440
8441 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8442 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8443
8444 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8445
8446 * w32.c (read_unc_volume): Use parameter `henum', instead of
8447 global variable `wget_enum_handle'.
8448
8449 * keymap.c (describe_vector): Remove parameters `indices' and
8450 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8451 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8452
8453 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8454
8455 * keyboard.c (timer_check): Remove parameter `do_it_now',
8456 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8457 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8458 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8459
8460 * keyboard.c (read_char):
8461 * w32menu.c (w32_menu_display_help):
8462 * xmenu.c (show_help_event, menu_help_callback):
8463 Adjust calls to `show_help_echo'.
8464
8465 * gtkutil.c (xg_maybe_add_timer):
8466 * keyboard.c (readable_events):
8467 * process.c (wait_reading_process_output):
8468 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8469
8470 * insdel.c (adjust_markers_gap_motion):
8471 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8472 (gap_left, gap_right): Don't call it.
8473
8474 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8475
8476 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8477 incurred during fontification.
8478
8479 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8480
8481 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8482 (DEFVAR_PER_BUFFER): Don't pass it.
8483
8484 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8485 (scrolling_window): Don't pass it.
8486
8487 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8488
8489 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8490
8491 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8492 and `suffix'.
8493 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8494 of variables specific to SELinux and computation of `encoded_absname'.
8495
8496 * image.c (XPutPixel): Remove unused variable `height'.
8497
8498 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8499
8500 * unexw32.c (get_section_info): Remove unused variable `section'.
8501
8502 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8503 (system_process_attributes): Remove unused variable `sess'.
8504 (sys_read): Remove unused variable `err'.
8505
8506 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8507 (w32_wnd_proc): Remove unused variable `isdead'.
8508 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8509 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8510 (x_create_tip_frame): Remove unused variable `tem'.
8511
8512 * w32inevt.c (w32_console_read_socket):
8513 Remove unused variable `no_events'.
8514
8515 * w32term.c (x_draw_composite_glyph_string_foreground):
8516 Remove unused variable `width'.
8517
8518 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8519
8520 * w32term.c (x_set_glyph_string_clipping):
8521 Don't pass uninitialized region to CombineRgn.
8522
8523 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8524
8525 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8526 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8527 (Fx_close_connection): Remove unused variable `i'.
8528
8529 * w32font.c (w32font_draw): Return number of glyphs.
8530 (w32font_open_internal): Remove unused variable `i'.
8531 (w32font_driver): Add missing initializer.
8532
8533 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8534 (fill_in_menu): Remove unused variable `items_added'.
8535
8536 * w32term.c (last_mouse_press_frame): Remove static global variable.
8537 (w32_clip_to_row): Remove unused variable `f'.
8538 (x_delete_terminal): Remove unused variable `i'.
8539
8540 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8541 (NOTHING): Remove unused static global variable.
8542 (uniscribe_check_otf): Remove unused variable `table'.
8543 (uniscribe_font_driver): Add missing initializers.
8544
8545 2011-03-23 Julien Danjou <julien@danjou.info>
8546
8547 * term.c (Fsuspend_tty, Fresume_tty):
8548 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8549 * window.c (temp_output_buffer_show):
8550 * insdel.c (signal_before_change):
8551 * frame.c (Fhandle_switch_frame):
8552 * fileio.c (Fdo_auto_save):
8553 * emacs.c (Fkill_emacs):
8554 * editfns.c (save_excursion_restore):
8555 * cmds.c (internal_self_insert):
8556 * callint.c (Fcall_interactively):
8557 * buffer.c (Fkill_all_local_variables):
8558 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8559 Use Frun_hooks.
8560 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8561 unconditionally since it does the check itself.
8562
8563 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8564
8565 Fix more problems found by GCC 4.5.2's static checks.
8566
8567 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8568 the first time through the loop, since we know p0 < p1 then.
8569 This also avoids a gcc -Wstrict-overflow warning.
8570
8571 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8572 leading to a memory leak, possible in functions like
8573 load_charset_map_from_file that can allocate an unbounded number
8574 of objects (Bug#8318).
8575
8576 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8577 that could (at least in theory) be that large.
8578
8579 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8580 This is less likely to overflow, and avoids undefined behavior if
8581 overflow does occur. All callers changed. Use strtoul to scan
8582 for the unsigned long integer.
8583 (pint2hrstr): Simplify and tune code slightly.
8584 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8585
8586 * scroll.c (do_scrolling): Work around GCC bug 48228.
8587 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8588
8589 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8590 This also avoids a warning with gcc -Wstrict-overflow.
8591 (validate_x_resource_name): Simplify count usage.
8592 This also avoids a warning with gcc -Wstrict-overflow.
8593
8594 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8595 fail (Bug#8306).
8596
8597 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8598
8599 * process.c (Fmake_network_process): Use socklen_t, not int,
8600 where POSIX says socklen_t is required in portable programs.
8601 This fixes a porting bug on hosts like 64-bit HP-UX, where
8602 socklen_t is wider than int (Bug#8277).
8603 (Fmake_network_process, server_accept_connection):
8604 (wait_reading_process_output, read_process_output):
8605 Likewise.
8606
8607 * process.c: Rename or move locals to avoid shadowing.
8608 (list_processes_1, Fmake_network_process):
8609 (read_process_output_error_handler, exec_sentinel_error_handler):
8610 Rename or move locals.
8611 (Fmake_network_process): Define label "retry_connect" only if needed.
8612 (Fnetwork_interface_info): Fix pointer signedness.
8613 (process_send_signal): Add cast to avoid pointer signedness problem.
8614 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8615 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8616
8617 Make tparam.h and terminfo.c consistent.
8618 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8619 Include tparam.h instead, since it declares them.
8620 * cm.h (PC): Remove extern decl; tparam.h now does this.
8621 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8622 * terminfo.c: Include tparam.h, to check interfaces.
8623 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8624 (tparam): Adjust signature to match interface in tparam.h;
8625 this removes some undefined behavior. Check that outstring and len
8626 are zero, which they always are with Emacs.
8627 * tparam.h (PC, BC, UP): New extern decls.
8628
8629 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8630 (xftfont_open): Rename locals to avoid shadowing.
8631
8632 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8633 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8634 (OTF_TAG_SYM): Omit macro if not needed.
8635 (ftfont_list): Remove unused local.
8636 (get_adstyle_property, ftfont_pattern_entity):
8637 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8638 Rename locals to avoid shadowing.
8639
8640 * xfont.c (xfont_list_family): Mark var as initialized.
8641
8642 * xml.c (make_dom): Now static.
8643
8644 * composite.c (composition_compute_stop_pos): Rename local to
8645 avoid shadowing.
8646 (composition_reseat_it): Remove unused locals.
8647 (find_automatic_composition, composition_adjust_point): Likewise.
8648 (composition_update_it): Mark var as initialized.
8649 (find_automatic_composition): Mark vars as initialized,
8650 with a FIXME (Bug#8290).
8651
8652 character.h: Rename locals to avoid shadowing.
8653 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8654 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8655 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8656 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8657 to avoid shadowing.
8658
8659 * textprop.c (property_change_between_p): Remove; unused.
8660
8661 * intervals.c (interval_start_pos): Now static.
8662
8663 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8664
8665 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8666 Rename locals to avoid shadowing.
8667
8668 * sound.c (wav_play, au_play, Fplay_sound_internal):
8669 Fix pointer signedness.
8670 (alsa_choose_format): Remove unused local var.
8671 (wav_play): Initialize a variable to 0, to prevent undefined
8672 behavior (Bug#8278).
8673
8674 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8675
8676 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8677
8678 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8679 clobbering (Bug#8298).
8680 * sysdep.c (sys_subshell): Likewise.
8681 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8682
8683 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8684 This should get cleaned up, so that child_setup has the
8685 same signature on all platforms.
8686
8687 * callproc.c (call_process_cleanup): Now static.
8688 (relocate_fd): Rename locals to avoid shadowing.
8689
8690 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8691
8692 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8693 not to be necessary, and produces flickering.
8694
8695 2011-03-20 Glenn Morris <rgm@gnu.org>
8696
8697 * config.in: Remove file.
8698
8699 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8700
8701 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8702 are now in src/globals.h.
8703 (syms_of_minibuf): Remove spurious & from previous change.
8704
8705 2011-03-20 Leo Liu <sdl.web@gmail.com>
8706
8707 * minibuf.c (completing-read-function): New variable.
8708 (completing-read-default): Rename from completing-read.
8709 (completing-read): Call completing-read-function.
8710
8711 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8712
8713 * xfaces.c (Fx_load_color_file):
8714 Read color file from absolute filename (bug#8250).
8715
8716 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8717
8718 * makefile.w32-in: Update dependencies.
8719
8720 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8721
8722 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8723
8724 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8725
8726 Fix more problems found by GCC 4.5.2's static checks.
8727
8728 * process.c (make_serial_process_unwind, send_process_trap):
8729 (sigchld_handler): Now static.
8730
8731 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8732 That way, the code declares only the vars that it needs.
8733 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8734 * s/cygwin.h (PTY_ITERATION): Likewise.
8735 * s/darwin.h (PTY_ITERATION): Likewise.
8736 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8737
8738 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8739 * process.c (allocate_pty): Don't declare stb unless it's needed.
8740
8741 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8742 (CONSTANTLIM): Remove; unused.
8743 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8744 Define only if needed.
8745
8746 * unexelf.c (unexec): Name an expression,
8747 to avoid gcc -Wbad-function-cast warning.
8748 Use a different way to cause a compilation error if anyone uses
8749 n rather than nn, a way that does not involve shadowing.
8750 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8751
8752 * deps.mk (unexalpha.o): Remove; unused.
8753
8754 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8755 * unexec.h: New file.
8756 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8757 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8758 Depend on unexec.h.
8759 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8760 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8761 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8762 Change as necessary to match prototype in unexec.h.
8763
8764 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8765 shadowing.
8766 (back_comment, skip_chars): Mark vars as initialized.
8767
8768 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8769 Rename locals to avoid shadowing.
8770
8771 * lread.c (read1): Rewrite so as not to use empty "else".
8772 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8773
8774 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8775
8776 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8777 warning when compiling print.c.
8778
8779 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8780 instead of using an uninitialized var.
8781 (font_sort_entities): Mark var as initialized.
8782
8783 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8784
8785 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8786 pointers to constants.
8787 (font_parse_fcname): Remove unused vars.
8788 (font_delete_unmatched): Now static.
8789 (font_get_spec): Remove; unused.
8790 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8791 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8792 Rename or move locals to avoid shadowing.
8793
8794 * fns.c (require_nesting_list, require_unwind): Now static.
8795 (Ffillarray): Rename locals to avoid shadowing.
8796
8797 * floatfns.c (domain_error2): Define only if needed.
8798 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8799
8800 * alloc.c (mark_backtrace): Move decl from here ...
8801 * lisp.h: ... to here, so that it can be checked.
8802
8803 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8804 (Fdefvar): Rewrite so as not to use empty "else".
8805 (lisp_indirect_variable): Name an expression,
8806 to avoid gcc -Wbad-function-cast warning.
8807 (Fdefvar): Rename locals to avoid shadowing.
8808
8809 * callint.c (quotify_arg, quotify_args): Now static.
8810 (Fcall_interactively): Rename locals to avoid shadowing.
8811 Use const pointer when appropriate.
8812
8813 * lisp.h (get_system_name, get_operating_system_release):
8814 Move decls here, to check interfaces.
8815 * process.c (get_operating_system_release): Move decl to lisp.h.
8816 * xrdb.c (get_system_name): Likewise.
8817 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8818 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8819 some of which prompt warnings from gcc -Wbad-function-cast.
8820 (Fformat_time_string, Fencode_time, Finsert_char):
8821 (Ftranslate_region_internal, Fformat):
8822 Rename or remove local vars to avoid shadowing.
8823 (Ftranslate_region_internal): Mark var as initialized.
8824
8825 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8826 avoid shadowing.
8827
8828 * lisp.h (eassert): Check that the argument compiles, even if
8829 ENABLE_CHECKING is not defined.
8830
8831 * data.c (Findirect_variable): Name an expression, to avoid
8832 gcc -Wbad-function-cast warning.
8833 (default_value, arithcompare, arith_driver, arith_error): Now static.
8834 (store_symval_forwarding): Rename local to avoid shadowing.
8835 (Fmake_variable_buffer_local, Fmake_local_variable):
8836 Mark variables as initialized.
8837 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8838
8839 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8840 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8841 Rename locals to avoid shadowing.
8842 (mark_stack): Move local variables into the #ifdef region where
8843 they're used.
8844 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8845 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8846 needed otherwise.
8847 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8848 (GC_STRING_CHARS): Remove; not used.
8849 (Fmemory_limit): Cast sbrk's returned value to char *.
8850
8851 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8852 avoids undefined behavior in theory.
8853
8854 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8855
8856 Use functions, not macros, for up- and down-casing (Bug#8254).
8857 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8858 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8859 to use the following functions instead of these macros.
8860 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8861 EMACS_INT, since callers assume the returned value fits in int.
8862 (upcase1): Likewise, for UPCASE_TABLE.
8863 (uppercasep, lowercasep, upcase): New static inline functions.
8864 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8865 the race-condition problem in the old DOWNCASE.
8866
8867 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8868 Rename locals to avoid shadowing.
8869 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8870 (regex_compile, re_search_2, re_match_2_internal):
8871 Remove unused local vars.
8872 (FREE_VAR): Rewrite so as not to use empty "else",
8873 which gcc can warn about.
8874 (regex_compile, re_match_2_internal): Mark locals as initialized.
8875 (RETALLOC_IF): Define only if needed.
8876 (WORDCHAR_P): Likewise. This one is never needed, but is used
8877 only in a comment talking about a compiler bug, so put inside
8878 the #if 0 of that comment.
8879 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8880 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8881 Remove; unused.
8882
8883 * search.c (boyer_moore): Rename locals to avoid shadowing.
8884 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8885 (PREV_CHAR_BOUNDARY): Likewise.
8886
8887 * search.c (simple_search): Remove unused var.
8888
8889 * dired.c (compile_pattern): Move decl from here ...
8890 * lisp.h: ... to here, so that it can be checked.
8891 (struct re_registers): New forward decl.
8892
8893 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8894
8895 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8896 All uses changed.
8897 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8898 Rename locals to avoid shadowing.
8899 (Fvertical_motion): Mark locals as initialized.
8900
8901 * casefiddle.c (casify_object, casify_region): Now static.
8902 (casify_region): Mark local as initialized.
8903
8904 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8905
8906 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8907 New macros, so that the caller can use some names other than
8908 gcpro1, gcpro2, etc.
8909 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8910 of the new macros.
8911 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8912 argument, for consistency with GCPRO2_VAR, etc: it is now the
8913 prefix of the variable, not the variable itself. All uses
8914 changed.
8915 * dired.c (directory_files_internal, file_name_completion):
8916 Rename locals to avoid shadowing.
8917
8918 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8919 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8920 dired.c's scmp function, had undefined behavior.
8921 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8922 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8923 * buffer.h: ... to here, because these macros use current_buffer,
8924 and the new implementation with inline functions needs to have
8925 current_buffer in scope now, rather than later when the macros
8926 are used.
8927 (downcase, upcase1): New static inline functions.
8928 (DOWNCASE, UPCASE1): Reimplement using these functions.
8929 This avoids undefined behavior in expressions like
8930 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8931 from race conditions in accessing the global variables
8932 case_temp1 and case_temp2.
8933 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8934 * lisp.h (case_temp1, case_temp2): Remove their decls.
8935 * character.h (ASCII_CHAR_P): Move from here ...
8936 * lisp.h: ... to here, so that the inline functions mentioned
8937 above can use them.
8938
8939 * dired.c (directory_files_internal_unwind): Now static.
8940
8941 * fileio.c (file_name_as_directory, directory_file_name):
8942 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8943 Now static.
8944 (file_name_as_directory): Use const pointers when appropriate.
8945 (Fexpand_file_name): Likewise. In particular, newdir might
8946 point at constant storage, so make it a const pointer.
8947 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8948 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8949 signedness issues.
8950 (Fset_file_times, Finsert_file_contents, auto_save_error):
8951 Rename locals to avoid shadowing.
8952
8953 * minibuf.c (choose_minibuf_frame_1): Now static.
8954 (Ftry_completion, Fall_completions): Rename or remove locals
8955 to avoid shadowing.
8956
8957 * marker.c (bytepos_to_charpos): Remove; unused.
8958
8959 * lisp.h (verify_bytepos, count_markers): New decls,
8960 so that gcc does not warn that these functions aren't declared.
8961
8962 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8963 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8964 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8965 (copy_text): Remove unused local var.
8966
8967 * filelock.c (within_one_second): Now static.
8968 (lock_file_1): Rename local to avoid shadowing.
8969
8970 * buffer.c (fix_overlays_before): Mark locals as initialized.
8971 (fix_start_end_in_overlays): Likewise. This function should be
8972 simplified by using pointers-to-pointers, but that's a different
8973 matter.
8974 (switch_to_buffer_1): Now static.
8975 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8976 (report_overlay_modification): Rename locals to avoid shadowing.
8977
8978 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8979 Fix pointer signedness issue.
8980 (sys_subshell): Mark local as volatile if checking for lint,
8981 to suppress a gcc -Wclobbered warning that does not seem to be right.
8982 (MAXPATHLEN): Define only if needed.
8983
8984 * process.c (serial_open, serial_configure): Move decls from here ...
8985 * systty.h: ... to here, so that they can be checked.
8986
8987 * fns.c (get_random, seed_random): Move extern decls from here ...
8988 * lisp.h: ... to here, so that they can be checked.
8989
8990 * sysdep.c (reset_io): Now static.
8991 (wait_for_termination_signal): Remove; unused.
8992
8993 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8994 (copy_keymap_item, append_key, push_text_char_description):
8995 Now static.
8996 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8997 (DENSE_TABLE_SIZE): Remove; unused.
8998 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8999 (describe_map_tree):
9000 Rename locals to avoid shadowing.
9001
9002 * keyboard.c: Declare functions static if they are not used elsewhere.
9003 (echo_char, echo_dash, cmd_error, top_level_2):
9004 (poll_for_input, handle_async_input): Now static.
9005 (read_char, kbd_buffer_get_event, make_lispy_position):
9006 (make_lispy_event, make_lispy_movement, apply_modifiers):
9007 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9008 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9009 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9010 (read_key_sequence, read_char): Mark locals as initialized.
9011 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9012
9013 * keyboard.h (make_ctrl_char): New decl.
9014 (mark_kboards): Move decl here ...
9015 * alloc.c (mark_kboards): ... from here.
9016
9017 * lisp.h (force_auto_save_soon): New decl.
9018
9019 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9020 (DEFINE_DUMMY_FUNCTION): New macro.
9021 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9022 Use it.
9023 (main): Add casts to avoid warnings
9024 if GCC considers string literals to be constants.
9025
9026 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9027
9028 * dbusbind.c: Pointer signedness fixes.
9029 (xd_signature, xd_append_arg, xd_initialize):
9030 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9031 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9032 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9033 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9034
9035 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9036 if GCC considers string literals to be constants.
9037 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9038
9039 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9040
9041 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9042 (print_preprocess, print_object): New macro to fix last change.
9043
9044 * print.c (print_preprocess): Don't forget font objects.
9045
9046 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9047
9048 * emacs.c (USAGE3): Doc fixes.
9049
9050 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9051
9052 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9053 structure.
9054
9055 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9056
9057 * lisp.h (VWindow_system, Qfile_name_history):
9058 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9059 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9060 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9061
9062 * w32select.c: Don't #include "keyboard.h".
9063 (run_protected): Add extern declaration for waiting_for_input.
9064
9065 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9066 * w32console.c (detect_input_pending, read_input_pending)
9067 (encode_terminal_code):
9068 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9069 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9070 (w32_system_caret_y, Qfile_name_history):
9071 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9072 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9073 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9074 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9075 * w32proc.c (Qlocal, report_file_error):
9076 * w32term.c (Vwindow_system, updating_frame):
9077 * w32uniscribe.c (initialized, uniscribe_font_driver):
9078 Remove unneeded extern declarations.
9079
9080 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9081
9082 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9083
9084 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9085
9086 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9087 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9088 These macros can no longer be used for assignment.
9089
9090 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9091 Assign struct members directly, instead of using BUF_BEGV etc.
9092 (record_buffer_markers, fetch_buffer_markers): New functions for
9093 recording and fetching special buffer markers.
9094 (set_buffer_internal_1, set_buffer_temp): Use them.
9095
9096 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9097
9098 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9099
9100 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9101 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9102
9103 * xdisp.c (hscroll_window_tree):
9104 (reconsider_clip_changes): Use PT instead of BUF_PT.
9105
9106 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9107
9108 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9109 $(EMACS_ROOT)/lib/intprops.h.
9110
9111 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9112
9113 Fix more problems found by GCC 4.5.2's static checks.
9114
9115 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9116 to unsigned char * to avoid compiler diagnostic.
9117 (xg_free_frame_widgets): Make it clear that a local variable is
9118 needed only if USE_GTK_TOOLTIP.
9119 (gdk_window_get_screen): Make it clear that this macro is needed
9120 only if USE_GTK_TOOLTIP.
9121 (int_gtk_range_get_value): New function, which avoids a diagnostic
9122 from gcc -Wbad-function-cast.
9123 (xg_set_toolkit_scroll_bar_thumb): Use it.
9124 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9125 diagnostic from gcc -Wbad-function-cast.
9126 (get_utf8_string, xg_get_file_with_chooser):
9127 Rename locals to avoid shadowing.
9128 (create_dialog): Move locals to avoid shadowing.
9129
9130 * xgselect.c (xg_select): Remove unused var.
9131
9132 * image.c (four_corners_best): Mark locals as initialized.
9133 (gif_load): Initialize transparent_p to zero (Bug#8238).
9134 Mark another local as initialized.
9135 (my_png_error, my_error_exit): Mark with NO_RETURN.
9136
9137 * image.c (clear_image_cache): Now static.
9138 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9139 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9140 (x_edge_detection): Remove unnecessary cast that
9141 gcc -Wbad-function-cast diagnoses.
9142 (gif_load): Fix pointer signedness.
9143 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9144 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9145
9146 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9147
9148 Improve quality of tests for time stamp overflow.
9149 For example, without this patch (encode-time 0 0 0 1 1
9150 1152921504606846976) returns the obviously-bogus value (-948597
9151 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9152 reports time overflow. See
9153 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9154 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9155 * editfns.c: Include limits.h and intprops.h.
9156 (TIME_T_MIN, TIME_T_MAX): New macros.
9157 (time_overflow): Move earlier, to before first use.
9158 (hi_time, lo_time): New functions, for an accurate test for
9159 out-of-range times.
9160 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9161 (Fget_internal_run_time): Don't assume time_t fits in int.
9162 (make_time): Use list2 instead of Fcons twice.
9163 (Fdecode_time): More accurate test for out-of-range times.
9164 (check_tm_member): New function.
9165 (Fencode_time): Use it, to test for out-of-range times.
9166 (lisp_time_argument): Don't rely on undefined left-shift and
9167 right-shift behavior when checking for time stamp overflow.
9168
9169 * editfns.c (time_overflow): New function, refactoring common code.
9170 (Fformat_time_string, Fdecode_time, Fencode_time):
9171 (Fcurrent_time_string): Use it.
9172
9173 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9174 * dired.c (make_time): Move to ...
9175 * editfns.c (make_time): ... here.
9176 * systime.h: Note the move.
9177
9178 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9179
9180 * fringe.c (update_window_fringes): Remove unused variables.
9181
9182 * unexmacosx.c (copy_data_segment): Also copy __got section.
9183 (Bug#8223)
9184
9185 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9186
9187 * termcap.c [MSDOS]: Include "msdos.h".
9188 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9189 Constify `char *' arguments and their references according to
9190 prototypes in tparam.h.
9191
9192 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9193
9194 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9195 Adapt all references accordingly.
9196
9197 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9198
9199 2011-03-11 Tom Tromey <tromey@redhat.com>
9200
9201 * buffer.c (syms_of_buffer): Remove obsolete comment.
9202
9203 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9204
9205 * termhooks.h (encode_terminal_code): Declare prototype.
9206
9207 * msdos.c (encode_terminal_code): Don't declare prototype.
9208
9209 * term.c (encode_terminal_code): Now external again, used by
9210 w32console.c and msdos.c.
9211
9212 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9213 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9214
9215 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9216
9217 Fix some minor problems found by GCC 4.5.2's static checks.
9218
9219 * fringe.c (update_window_fringes): Mark locals as initialized
9220 (Bug#8227).
9221 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9222
9223 * alloc.c (mark_fringe_data): Move decl from here ...
9224 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9225 to check its interface.
9226 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9227
9228 * fontset.c (free_realized_fontset): Now static.
9229 (Fset_fontset_font): Rename local to avoid shadowing.
9230 (fontset_font): Mark local as initialized.
9231 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9232
9233 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9234
9235 * xselect.c (x_disown_buffer_selections): Remove; not used.
9236 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9237 (x_own_selection, Fx_disown_selection_internal): Rename locals
9238 to avoid shadowing.
9239 (x_handle_dnd_message): Remove local to avoid shadowing.
9240
9241 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9242 so that the caller can use some name other than gcpro1.
9243 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9244 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9245 (Fx_backspace_delete_keys_p):
9246 Use them to avoid shadowing, and rename vars to avoid shadowing.
9247 (x_decode_color, x_set_name, x_window): Now static.
9248 (Fx_create_frame): Add braces to silence GCC warning.
9249 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9250 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9251 Remove unused locals.
9252 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9253 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9254 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9255 macros.
9256
9257 * xterm.h (x_mouse_leave): New decl.
9258
9259 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9260 Remove unused functions.
9261 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9262 (x_calc_absolute_position): Now static.
9263 (XTread_socket): Don't define label "out" unless it's used.
9264 Don't declare local "event" unless it's used.
9265 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9266 unless they are used.
9267 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9268 (x_fatal_error_signal): Remove; not used.
9269 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9270 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9271 (x_error_catcher, x_connection_closed, x_error_handler):
9272 (x_error_quitter, xembed_send_message, x_iconify_frame):
9273 (my_log_handler): Rename locals to avoid shadowing.
9274 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9275 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9276
9277 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9278 Rename or move locals to avoid shadowing.
9279 (tty_defined_color, merge_face_heights): Now static.
9280 (free_realized_faces_for_fontset): Remove; not used.
9281 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9282 does not deduce is never used uninitialized.
9283 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9284 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9285
9286 * terminal.c (store_terminal_param): Now static.
9287
9288 * xmenu.c (menu_highlight_callback): Now static.
9289 (set_frame_menubar): Remove unused local.
9290 (xmenu_show): Rename parameter to avoid shadowing.
9291 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9292 since they might point to immutable storage.
9293 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9294 since it's unused otherwise.
9295
9296 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9297 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9298 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9299 avoids a gcc -Wuninitialized diagnostic.
9300 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9301 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9302 does not deduce are never used uninitialized.
9303
9304 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9305
9306 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9307 * window.c (window_loop, size_window):
9308 (run_window_configuration_change_hook, enlarge_window): Likewise.
9309
9310 * window.c (display_buffer): Now static.
9311 (size_window): Mark variables that gcc -Wuninitialized
9312 does not deduce are never used uninitialized.
9313 * window.h (check_all_windows): New decl, to forestall
9314 gcc -Wmissing-prototypes diagnostic.
9315 * dispextern.h (bidi_dump_cached_states): Likewise.
9316
9317 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9318 shadowing.
9319 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9320 Include <limits.h>.
9321 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9322 and to avoid gcc -Wuninitialized warning.
9323 (load_charset_map): Mark variables that gcc -Wuninitialized
9324 does not deduce are never used uninitialized.
9325 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9326
9327 * coding.c (coding_set_source, coding_set_destination):
9328 Use "else { /* comment */ }" rather than "else /* comment */;"
9329 for clarity, and to avoid gcc -Wempty-body warning.
9330 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9331 a block, when the outer 'i' will do.
9332 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9333 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9334 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9335 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9336 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9337 Rename locals to avoid shadowing.
9338 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9339 * coding.c (emacs_mule_char, encode_invocation_designation):
9340 Now static, since they're not used elsewhere.
9341 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9342 (decode_coding_object, encode_coding_object, detect_coding_system):
9343 (decode_coding_emacs_mule): Mark variables that gcc
9344 -Wuninitialized does not deduce are never used uninitialized.
9345 (detect_coding_iso_2022): Initialize a local variable that might
9346 be used uninitialized. Leave a FIXME because it's not clear that
9347 this initialization is needed. (Bug#8211)
9348 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9349 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9350 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9351 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9352 Remove unused macros.
9353
9354 * category.c (hash_get_category_set): Remove unused local var.
9355 (copy_category_table): Now static, since it's not used elsewhere.
9356 * character.c (string_count_byte8): Likewise.
9357
9358 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9359 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9360
9361 * chartab.c (copy_sub_char_table): Now static, since it's not used
9362 elsewhere.
9363 (sub_char_table_ref_and_range, char_table_ref_and_range):
9364 Rename locals to avoid shadowing.
9365 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9366
9367 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9368 (BIDI_BOB): Remove unused macro.
9369
9370 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9371 deduce are never used uninitialized.
9372 * term.c (encode_terminal_code): Likewise.
9373
9374 * term.c (encode_terminal_code): Now static. Remove unused local.
9375
9376 * tparam.h: New file.
9377 * term.c, tparam.h: Include it.
9378 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9379 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9380 Move these decls to tparam.h, and make them agree with what
9381 is actually in tparam.c. The previous trick of using incompatible
9382 decls in different modules does not conform to the C standard.
9383 All callers of tparam changed to use tparam's actual API.
9384 * tparam.c (tparam1, tparam, tgoto):
9385 Use const pointers where appropriate.
9386
9387 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9388 * cm.h (struct cm): Likewise.
9389 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9390 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9391 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9392 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9393 (turn_on_face, init_tty): Likewise.
9394 * termchar.h (struct tty_display_info): Likewise.
9395
9396 * term.c (term_mouse_position): Rename local to avoid shadowing.
9397
9398 * alloc.c (mark_ttys): Move decl from here ...
9399 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9400
9401 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9402
9403 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9404
9405 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9406
9407 * search.c (compile_pattern_1): Remove argument regp, unused since
9408 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9409 (compile_pattern): Don't pass it.
9410
9411 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9412
9413 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9414 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9415 for ! HAVE_GTK3.
9416 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9417
9418 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9419
9420 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9421 gdk_window_get_screen, gdk_window_get_geometry,
9422 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9423 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9424 (xg_get_pixbuf_from_pixmap): New function.
9425 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9426 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9427 Call xg_get_pixbuf_from_pixmap instead of
9428 gdk_pixbuf_get_from_drawable.
9429 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9430 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9431 (xg_check_special_colors): Use GtkStyleContext and its functions
9432 for HAVE_GTK3.
9433 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9434 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9435 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9436 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9437 Call gtk_widget_get_preferred_size.
9438 (xg_frame_resized): gdk_window_get_geometry only takes 5
9439 parameters.
9440 (xg_win_to_widget, xg_event_is_for_menubar):
9441 Call gdk_x11_window_lookup_for_display.
9442 (xg_set_widget_bg): New function.
9443 (delete_cb): New function.
9444 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9445 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9446 (xg_set_background_color): Call xg_set_widget_bg.
9447 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9448 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9449 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9450 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9451 if ! HAVE_GTK3.
9452 (update_frame_tool_bar): Call gtk_widget_hide.
9453 (xg_initialize): Use GDK_KEY_g.
9454
9455 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9456 if ! HAVE_GTK3
9457 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9458
9459 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9460 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9461 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9462
9463 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9464
9465 * w32xfns.c (select_palette): Check success of RealizePalette against
9466 GDI_ERROR, not zero.
9467
9468 See ChangeLog.11 for earlier changes.
9469
9470 ;; Local Variables:
9471 ;; coding: utf-8
9472 ;; End:
9473
9474 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9475
9476 This file is part of GNU Emacs.
9477
9478 GNU Emacs is free software: you can redistribute it and/or modify
9479 it under the terms of the GNU General Public License as published by
9480 the Free Software Foundation, either version 3 of the License, or
9481 (at your option) any later version.
9482
9483 GNU Emacs is distributed in the hope that it will be useful,
9484 but WITHOUT ANY WARRANTY; without even the implied warranty of
9485 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9486 GNU General Public License for more details.
9487
9488 You should have received a copy of the GNU General Public License
9489 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.