* xdisp.c (message_log_check_duplicate): Return intmax_t,
[bpt/emacs.git] / src / ChangeLog
1 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4 not unsigned long, as we prefer signed integers. All callers changed.
5 Detect integer overflow in repeat count.
6 (message_dolog): Don't assume print length fits in 39 bytes.
7
8 * termcap.c: Don't assume sizes fit in int and never overflow.
9 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10 (gobble_line): Check for size-calculation overflow.
11
12 * minibuf.c (Fread_buffer):
13 * lread.c (intern, intern_c_string):
14 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
15 Don't assume string length fits in int.
16
17 * keyboard.c (parse_tool_bar_item):
18 * gtkutil.c (style_changed_cb): Avoid need for strlen.
19
20 * font.c: Don't assume string length fits in int.
21 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
22 Use ptrdiff_t, not int.
23 (font_intern_prop): Don't assume string length fits in int.
24 Don't assume integer property fits in fixnum.
25 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
26
27 * filelock.c: Fix some buffer overrun and integer overflow issues.
28 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
29 Reformulate so as not to need the command string.
30 Invoke gzip -cd rather than gunzip, as it's more portable.
31 (lock_info_type, lock_file_1, lock_file):
32 Don't assume pid_t and time_t fit in unsigned long.
33 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
34 (current_lock_owner): Prefer signed type for sizes.
35 Use memcpy, not strncpy, where memcpy is what is really wanted.
36 Don't assume (via atoi) that time_t and pid_t fit in int.
37 Check for time_t and/or pid_t out of range, e.g., via a network share.
38 Don't alloca where an auto var works fine.
39
40 * fileio.c: Fix some integer overflow issues.
41 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
42 Don't assume string length fits in int.
43 (directory_file_name): Don't assume string length fits in long.
44 (make_temp_name): Don't assume pid fits in int, or that its print
45 length is less than 20.
46
47 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
48
49 * coding.c (make_subsidiaries): Don't assume string length fits in int.
50
51 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
52
53 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
54 We prefer signed integers, even for size calculations.
55
56 * emacs.c: Don't assume string length fits in 'int'.
57 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
58 (main): Don't invoke strlen when not needed.
59
60 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
61 (XD_DEBUG_MESSAGE): Don't waste a byte.
62
63 * callproc.c (getenv_internal_1, getenv_internal)
64 (Fgetenv_internal):
65 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
66
67 * lread.c (invalid_syntax): Omit length argument.
68 All uses changed. This doesn't fix a bug, but it simplifies the
69 code away from its former Hollerith-constant appearance, and it's
70 one less 'int' to worry about when looking at integer-overflow issues.
71 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
72
73 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
74 This didn't break anything, but it didn't help either.
75 It's confusing to put a bogus integer in a place where the actual
76 value does not matter.
77 (LIST_END_P): Remove unused macro and its bogus comment.
78 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
79
80 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
81 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
82 implementation.
83 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
84 We prefer signed types, and the value cannot exceed the EMACS_INT
85 range anyway (because otherwise the length would not be representable).
86 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
87 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
88 This avoids a GCC warning when WIDE_EMACS_INT.
89
90 * indent.c (sane_tab_width): New function.
91 (current_column, scan_for_column, Findent_to, position_indentation)
92 (compute_motion): Use it. This is just for clarity.
93 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
94
95 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
96
97 * lisp.h (lint_assume): New macro.
98 * composite.c (composition_gstring_put_cache):
99 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
100
101 * editfns.c, insdel.c:
102 Omit unnecessary forward decls, to simplify future changes.
103
104 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
105
106 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
107
108 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
109 Use much-faster test for byte-length change.
110 Don't assume string byte-length fits in 'int'.
111 Check that character arg fits in 'int'.
112 (mapcar1): Declare byte as byte, for clarity.
113
114 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
115
116 * fns.c (concat): Catch string overflow earlier.
117 Do not rely on integer wraparound.
118
119 * dispextern.h (struct it.overlay_strings_charpos)
120 (struct it.selective): Now EMACS_INT, not int.
121 * xdisp.c (forward_to_next_line_start)
122 (back_to_previous_visible_line_start)
123 (reseat_at_next_visible_line_start, next_element_from_buffer):
124 Don't arbitrarily truncate the value of 'selective' to int.
125
126 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
127
128 * composite.c: Don't truncate sizes to 'int'.
129 (composition_gstring_p, composition_reseat_it)
130 (composition_adjust_point): Use EMACS_INT, not int.
131 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
132 not EMACS_UINT, for indexes.
133
134 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
135
136 * buffer.c: Include <verify.h>.
137 (struct sortvec.priority, struct sortstr.priority):
138 Now EMACS_INT, not int.
139 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
140 (struct sortstr.size, record_overlay_string)
141 (struct sortstrlist.size, struct sortlist.used):
142 Don't truncate size to int.
143 (record_overlay_string): Check for size-calculation overflow.
144 (init_buffer_once): Check at compile-time, not run-time.
145
146 2011-06-20 Deniz Dogan <deniz@dogan.se>
147
148 * process.c (Fset_process_buffer): Clarify return value in
149 docstring.
150
151 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
152
153 * dispnew.c (add_window_display_history): Use BVAR.
154
155 * xdisp.c (debug_method_add): Use BVAR.
156 (check_window_end, dump_glyph_matrix, dump_glyph)
157 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
158
159 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
160 Likewise.
161
162 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
163 check till after the cache is created in init_frame_faces.
164
165 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
166
167 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
168
169 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
170
171 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
172 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
173 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
174
175 Improve buffer-overflow checking (Bug#8873).
176 * fileio.c (Finsert_file_contents):
177 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
178 Remove the old (too-loose) buffer overflow checks.
179 They weren't needed, since make_gap checks for buffer overflow.
180 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
181 The old code merely checked for Emacs fixnum overflow, and relied
182 on undefined (wraparound) behavior. The new code avoids undefined
183 behavior, and also checks for ptrdiff_t and/or size_t overflow.
184
185 * editfns.c (Finsert_char): Don't dump core with very negative counts.
186 Tune. Don't use wider integers than needed. Don't use alloca.
187 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
188
189 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
190
191 * insdel.c, lisp.h (buffer_overflow): New function.
192 (insert_from_buffer_1, replace_range, replace_range_2):
193 * insdel.c (make_gap_larger):
194 * editfns.c (Finsert_char):
195 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
196
197 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
198
199 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
200
201 Integer overflow and signedness fixes (Bug#8873).
202
203 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
204 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
205
206 * fileio.c: Don't assume EMACS_INT fits in off_t.
207 (emacs_lseek): New static function.
208 (Finsert_file_contents, Fwrite_region): Use it.
209 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
210
211 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
212
213 * fns.c: Don't overflow int when computing a list length.
214 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
215 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
216 truncation on 64-bit hosts. Check for QUIT every
217 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
218 faster and is responsive enough.
219 (Flength): Report an error instead of overflowing an integer.
220 (Fsafe_length): Return a float if the value is not representable
221 as a fixnum. This shouldn't happen except in contrived situations.
222 (Fnthcdr, Fsort): Don't assume list length fits in int.
223 (Fcopy_sequence): Don't assume vector length fits in int.
224
225 * alloc.c: Check that resized vectors' lengths fit in fixnums.
226 (header_size, word_size): New constants.
227 (allocate_vectorlike): Don't check size overflow here.
228 (allocate_vector): Check it here instead, since this is the only
229 caller of allocate_vectorlike that could cause overflow.
230 Check that the new vector's length is representable as a fixnum.
231
232 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
233 The previous code was bogus. For example, next_almost_prime (32)
234 returned 39, which is undesirable as it is a multiple of 3; and
235 next_almost_prime (24) returned 25, which is a multiple of 5 so
236 why was the code bothering to check for multiples of 7?
237
238 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
239
240 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
241
242 Variadic C functions now count arguments with ptrdiff_t.
243 This partly undoes my 2011-03-30 change, which replaced int with size_t.
244 Back then I didn't know that the Emacs coding style prefers signed int.
245 Also, in the meantime I found a few more instances where arguments
246 were being counted with int, which may truncate counts on 64-bit
247 machines, or EMACS_INT, which may be unnecessarily wide.
248 * lisp.h (struct Lisp_Subr.function.aMANY)
249 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
250 Arg counts are now ptrdiff_t, not size_t.
251 All variadic functions and their callers changed accordingly.
252 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
253 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
254 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
255 * callint.c (Fcall_interactively): Check arg count for overflow,
256 to avoid potential buffer overrun. Use signed char, not 'int',
257 for 'varies' array, so that we needn't bother to check its size
258 calculation for overflow.
259 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
260 * eval.c (apply_lambda):
261 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
262 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
263 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
264
265 * callint.c (Fcall_interactively): Don't use index var as event count.
266
267 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
268 * mem-limits.h (SIZE): Remove; no longer used.
269
270 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
271
272 Remove unnecessary casts.
273 * xterm.c (x_term_init):
274 * xfns.c (x_set_border_pixel):
275 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
276 These aren't needed now that we assume ANSI C.
277
278 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
279 It's more likely to cause problems (due to unsigned overflow)
280 than to cure them.
281
282 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
283
284 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
285
286 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
287
288 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
289
290 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
291
292 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
293
294 GLYPH_CODE_FACE returns EMACS_INT, not int.
295 * dispextern.h (merge_faces):
296 * xfaces.c (merge_faces):
297 * xdisp.c (get_next_display_element, next_element_from_display_vector):
298 Don't assume EMACS_INT fits in int.
299
300 * character.h (CHAR_VALID_P): Remove unused parameter.
301 * fontset.c, lisp.h, xdisp.c: All uses changed.
302
303 * editfns.c (Ftranslate_region_internal): Omit redundant test.
304
305 * fns.c (concat): Minor tuning based on overflow analysis.
306 This doesn't fix any bugs. Use int to hold character, instead
307 of constantly refetching from Emacs object. Use XFASTINT, not
308 XINT, for value known to be a character. Don't bother comparing
309 a single byte to 0400, as it's always less.
310
311 * floatfns.c (Fexpt):
312 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
313
314 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
315 for characters.
316
317 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
318
319 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
320 Without this fix, on a 64-bit host (aset S 0 4294967386) would
321 incorrectly succeed when S was a string, because 4294967386 was
322 truncated before it was used.
323
324 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
325 Otherwise, an out-of-range integer could cause undefined behavior
326 on a 64-bit host.
327
328 * composite.c: Use int, not EMACS_INT, for characters.
329 (fill_gstring_body, composition_compute_stop_pos): Use int, not
330 EMACS_INT, for values that are known to be in character range.
331 This doesn't fix any bugs but is the usual style inside Emacs and
332 may generate better code on 32-bit machines.
333
334 Make sure a 64-bit char is never passed to ENCODE_CHAR.
335 This is for reasons similar to the recent CHAR_STRING fix.
336 * charset.c (Fencode_char): Check that character arg is actually
337 a character. Pass an int to ENCODE_CHAR.
338 * charset.h (ENCODE_CHAR): Verify that the character argument is no
339 wider than 'int', as a compile-time check to prevent future regressions
340 in this area.
341
342 * character.c (char_string): Remove unnecessary casts.
343
344 Make sure a 64-bit char is never passed to CHAR_STRING.
345 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
346 by silently ignoring the top 32 bits, allowing some values
347 that were far too large to be valid characters.
348 * character.h: Include <verify.h>.
349 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
350 arguments are no wider than unsigned, as a compile-time check
351 to prevent future regressions in this area.
352 * data.c (Faset):
353 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
354 (Fsubst_char_in_region):
355 * fns.c (concat):
356 * xdisp.c (decode_mode_spec_coding):
357 Adjust to CHAR_STRING's new requirement.
358 * editfns.c (Finsert_char, Fsubst_char_in_region):
359 * fns.c (concat): Check that character args are actually
360 characters. Without this test, these functions did the wrong
361 thing with wildly out-of-range values on 64-bit hosts.
362
363 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
364 These casts should not be needed on 32-bit hosts, either.
365 * keyboard.c (read_char):
366 * lread.c (Fload): Remove casts to unsigned.
367
368 * lisp.h (UNSIGNED_CMP): New macro.
369 This fixes comparison bugs on 64-bit hosts.
370 (ASCII_CHAR_P): Use it.
371 * casefiddle.c (casify_object):
372 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
373 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
374 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
375 * dispextern.h (FACE_FROM_ID):
376 * keyboard.c (read_char): Use UNSIGNED_CMP.
377
378 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
379 not to EMACS_INT, to avoid GCC warning.
380
381 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
382
383 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
384 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
385 isn't needed on 32-bit machines.
386
387 * buffer.c (Fgenerate_new_buffer_name):
388 Use EMACS_INT for count, not int.
389 (advance_to_char_boundary): Return EMACS_INT, not int.
390
391 * data.c (Qcompiled_function): Now static.
392
393 * window.c (window_body_lines): Now static.
394
395 * image.c (gif_load): Rename local to avoid shadowing.
396
397 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
398 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
399 * alloc.c (make_save_value): Integer argument is now of type
400 ptrdiff_t, not int.
401 (mark_object): Use ptrdiff_t, not int.
402 * lisp.h (pD): New macro.
403 * print.c (print_object): Use it.
404
405 * alloc.c: Use EMACS_INT, not int, to count objects.
406 (total_conses, total_markers, total_symbols, total_vector_size)
407 (total_free_conses, total_free_markers, total_free_symbols)
408 (total_free_floats, total_floats, total_free_intervals)
409 (total_intervals, total_strings, total_free_strings):
410 Now EMACS_INT, not int. All uses changed.
411 (Fgarbage_collect): Compute overall total using a double, so that
412 integer overflow is less likely to be a problem. Check for overflow
413 when converting back to an integer.
414 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
415 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
416 These were 'int' variables that could overflow on 64-bit hosts;
417 they were never used, so remove them instead of repairing them.
418 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
419 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
420 Previously, this ceilinged at INT_MAX, but that doesn't work on
421 64-bit machines.
422 (allocate_pseudovector): Don't use EMACS_INT when int would do.
423
424 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
425 (allocate_vectorlike): Check for ptrdiff_t overflow.
426 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
427 when a (possibly-narrower) signed value would do just as well.
428 We prefer using signed arithmetic, to avoid comparison confusion.
429
430 * alloc.c: Catch some string size overflows that we were missing.
431 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
432 for convenience in STRING_BYTES_MAX.
433 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
434 The definition here is exact; the one in lisp.h was approximate.
435 (allocate_string_data): Check for string overflow. This catches
436 some instances we weren't catching before. Also, it catches
437 size_t overflow on (unusual) hosts where SIZE_MAX <= min
438 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
439 and ptrdiff_t and EMACS_INT are both 64 bits.
440
441 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
442 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
443 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
444
445 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
446
447 * alloc.c (Fmake_string): Check for out-of-range init.
448
449 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
450
451 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
452
453 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
454
455 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
456 xg_get_default_scrollbar_width.
457
458 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
459 (int_gtk_range_get_value): Move to the scroll bar part of the file.
460 (style_changed_cb): Call update_theme_scrollbar_width and call
461 x_set_scroll_bar_default_width and xg_frame_set_char_size for
462 all frames (Bug#8505).
463 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
464 Call gtk_window_set_resizable if HAVE_GTK3.
465 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
466 and height if HAVE_GTK3 (Bug#8505).
467 (scroll_bar_width_for_theme): New variable.
468 (update_theme_scrollbar_width): New function.
469 (xg_get_default_scrollbar_width): Move code to
470 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
471 (xg_initialize): Call update_theme_scrollbar_width.
472
473 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
474
475 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
476
477 2011-06-12 Martin Rudalics <rudalics@gmx.at>
478
479 * frame.c (make_frame): Call other_buffer_safely instead of
480 other_buffer.
481
482 * window.c (temp_output_buffer_show): Call display_buffer with
483 second argument Vtemp_buffer_show_specifiers and reset latter
484 immediately after the call.
485 (Vtemp_buffer_show_specifiers): New variable.
486 (auto_window_vscroll_p, next_screen_context_lines)
487 (Vscroll_preserve_screen_position): Remove leading asterisks from
488 doc-strings.
489
490 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
491
492 Fix minor problems found by GCC 4.6.0 static checking.
493 * buffer.c (Qclone_number): Remove for now, as it's unused.
494 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
495 (record_buffer): Remove unused local.
496 * frame.c (other_visible_frames, frame_buffer_list): Now static.
497 (set_frame_buffer_list): Remove; unused.
498 * frame.h (other_visible_frames): Remove decl.
499 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
500 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
501 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
502 if HAVE_GPM.
503 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
504 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
505 Define only if HAVE_GPM.
506 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
507 (update_hints_inhibit): Remove; never set. All uses removed.
508 * widgetprv.h (emacsFrameClassRec): Remove decl.
509 * window.c (delete_deletable_window): Now returns void, since it
510 wasn't returning anything.
511 (compare_window_configurations): Remove unused locals.
512 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
513 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
514 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
515 the same widths as pointers. This follows up on the 2011-05-06 patch.
516 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
517 * xterm.h: Likewise.
518 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
519
520 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
521
522 * makefile.w32-in: Update dependencies.
523 (LISP_H): Add lib/intprops.h.
524
525 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
526
527 * image.c (gif_load): Add animation frame delay to the metadata.
528 (syms_of_image): Use DEFSYM. New symbol `delay'.
529
530 2011-06-11 Martin Rudalics <rudalics@gmx.at>
531
532 * window.c (delete_deletable_window): Re-add.
533 (Fset_window_configuration): Rewrite to handle dead buffers and
534 consequently deletable windows.
535 (window_tree, Fwindow_tree): Remove. Supply functionality in
536 window.el.
537 (compare_window_configurations): Simplify code.
538
539 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
540
541 * image.c (imagemagick_load_image): Fix type mismatch.
542 (Fimagemagick_types): Likewise.
543
544 * window.h (replace_buffer_in_windows): Declare.
545
546 2011-06-11 Martin Rudalics <rudalics@gmx.at>
547
548 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
549 Qclone_number. Remove external declaration of Qdelete_window.
550 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
551 code.
552 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
553 Qbuffer_list_update_hook if allowed.
554 (Fother_buffer): Rewrite doc-string. Major rewrite for new
555 buffer list implementation.
556 (other_buffer_safely): New function.
557 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
558 calls to replace_buffer_in_windows and
559 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
560 if allowed.
561 (record_buffer): Inhibit quitting and rewrite using quittable
562 functions. Run Qbuffer_list_update_hook if allowed.
563 (Frecord_buffer, Funrecord_buffer): New functions.
564 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
565 switch-to-buffer to window.el.
566 (bury-buffer): Move to window.el.
567 (Vbuffer_list_update_hook): New variable.
568
569 * lisp.h (other_buffer_safely): Add prototype in buffer.c
570 section.
571
572 * window.h (resize_frame_windows): Move up in code.
573 (Fwindow_frame): Remove EXFUN.
574 (replace_buffer_in_all_windows): Remove prototype.
575 (replace_buffer_in_windows_safely): Add prototype.
576
577 * window.c: Declare Qdelete_window static again. Move down
578 declaration of select_count.
579 (Fnext_window, Fprevious_window): Rewrite doc-strings.
580 (Fother_window): Move to window.el.
581 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
582 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
583 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
584 window.el.
585 (replace_buffer_in_windows): Implement by calling
586 Qreplace_buffer_in_windows.
587 (replace_buffer_in_all_windows): Remove with some functionality
588 moved into replace_buffer_in_windows_safely.
589 (replace_buffer_in_windows_safely): New function.
590 (select_window_norecord, select_frame_norecord): Move in front
591 of run_window_configuration_change_hook. Remove now obsolete
592 declarations.
593 (Fset_window_buffer): Rewrite doc-string. Call
594 Qrecord_window_buffer.
595 (keys_of_window): Move binding for other-window to window.el.
596
597 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
598
599 * dispextern.h (struct image): Replace data member, whose int_val
600 and ptr_val fields were not used by anything, with a single
601 lisp_val object.
602
603 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
604 (gif_clear_image, gif_load, imagemagick_load_image)
605 (gs_clear_image, gs_load): Callers changed.
606
607 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
608
609 * buffer.h: Include <time.h>, for time_t.
610 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
611
612 Fix minor problems found by static checking.
613
614 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
615
616 Make identifiers static if they are not used in other modules.
617 * data.c (Qcompiled_function, Qframe, Qvector):
618 * image.c (QimageMagick, Qsvg):
619 * minibuf.c (Qmetadata):
620 * window.c (resize_window_check, resize_root_window): Now static.
621 * window.h (resize_window_check, resize_root_window): Remove decls.
622
623 * window.c (window_deletion_count, delete_deletable_window):
624 Remove; unused.
625 (window_body_lines): Now static.
626 (Fdelete_other_windows_internal): Mark vars as initialized.
627 Make sure 'resize_failed' is initialized.
628 (run_window_configuration_change_hook): Rename local to avoid shadowing.
629 (resize_window_apply): Remove unused local.
630 * window.h (delete_deletable_window): Remove decl.
631
632 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
633 (imagemagick_load_image): Fix pointer signedness problem by changing
634 last arg from unsigned char * to char *. All uses changed.
635 Also, fix a local for similar reasons.
636 Remove unused locals. Remove locals to avoid shadowing.
637 (fn_rsvg_handle_free): Remove; unused.
638 (svg_load, svg_load_image): Fix pointer signedness problem.
639 (imagemagick_load_image): Don't use garbage pointer image_wand.
640
641 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
642
643 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
644
645 * image.c (gif_load): Fix omitted cast error introduced by
646 2011-06-06 change.
647
648 2011-06-10 Martin Rudalics <rudalics@gmx.at>
649
650 * window.h (resize_proportionally, orig_total_lines)
651 (orig_top_line): Remove from window structure.
652 (set_window_height, set_window_width, change_window_heights)
653 (Fdelete_window): Remove prototypes.
654 (resize_frame_windows): Remove duplicate declaration.
655
656 2011-06-10 Eli Zaretskii <eliz@gnu.org>
657
658 * window.h (resize_frame_windows, resize_window_check)
659 (delete_deletable_window, resize_root_window)
660 (resize_frame_windows): Declare prototypes.
661
662 * window.c (resize_window_apply): Make definition be "static" to
663 match the prototype.
664
665 2011-06-10 Martin Rudalics <rudalics@gmx.at>
666
667 * window.c: Remove declarations of Qwindow_size_fixed,
668 window_min_size_1, window_min_size_2, window_min_size,
669 size_window, window_fixed_size_p, enlarge_window, delete_window.
670 Remove static from declaration of Qdelete_window, it's
671 temporarily needed by Fbury_buffer.
672 (replace_window): Don't assign orig_top_line and
673 orig_total_lines.
674 (Fdelete_window, delete_window): Remove. Window deletion is
675 handled by window.el.
676 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
677 Fdelete_window calls with calls to Qdelete_window.
678 (Fdelete_other_windows): Remove. Deleting other windows is
679 handled by window.el.
680 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
681 handled in window.el.
682 (window_min_size_2, window_min_size_1, window_min_size): Remove.
683 Window minimum sizes are handled in window.el.
684 (shrink_windows, size_window, set_window_height)
685 (set_window_width, change_window_heights, window_height)
686 (window_width, CURBEG, CURSIZE, enlarge_window)
687 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
688 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
689 handled in window.el.
690 (make_dummy_parent): Rename to make_parent_window and give it a
691 second argument horflag.
692 (make_window): Don't set resize_proportionally any more.
693 (Fsplit_window): Remove. Windows are split in window.el.
694 (save_restore_action, save_restore_orig_size)
695 (shrink_window_lowest_first, save_restore_orig_size): Remove.
696 Resize mini windows in window.el.
697 (grow_mini_window, shrink_mini_window): Implement by calling
698 Qresize_root_window_vertically, resize_window_check and
699 resize_window_apply.
700 (saved_window, Fset_window_configuration, save_window_save): Do
701 not handle orig_top_line, orig_total_lines, and
702 resize_proportionally.
703 (window_min_height, window_min_width): Move to window.el.
704 (keys_of_window): Move bindings for delete-other-windows,
705 split-window, delete-window and enlarge-window to window.el.
706
707 * buffer.c: Temporarily extern Qdelete_window.
708 (Fbury_buffer): Temporarily call Qdelete_window instead of
709 Fdelete_window (Fbury_buffer will move to window.el soon).
710
711 * frame.c (set_menu_bar_lines_1): Remove code handling
712 orig_top_line and orig_total_lines.
713
714 * dispnew.c (adjust_frame_glyphs_initially): Don't use
715 set_window_height but set heights directly.
716 (change_frame_size_1): Use resize_frame_windows.
717
718 * xdisp.c (init_xdisp): Don't use set_window_height but set
719 heights directly.
720
721 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
722 resize_frame_windows instead of change_window_heights and run
723 run_window_configuration_change_hook.
724
725 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
726 instead of change_window_heights and run
727 run_window_configuration_change_hook.
728
729 2011-06-09 Martin Rudalics <rudalics@gmx.at>
730
731 * window.c (replace_window): Rename second argument REPLACEMENT to
732 NEW. New third argument SETFLAG. Rewrite.
733 (delete_window, make_dummy_parent): Call replace_window with
734 third argument 1.
735 (window_list_1): Move down in code.
736 (run_window_configuration_change_hook): Move set_buffer part
737 before select_frame_norecord part in order to unwind correctly.
738 Rename count1 to count.
739 (recombine_windows, delete_deletable_window, resize_root_window)
740 (Fdelete_other_windows_internal)
741 (Frun_window_configuration_change_hook, make_parent_window)
742 (resize_window_check, resize_window_apply, Fresize_window_apply)
743 (resize_frame_windows, Fsplit_window_internal)
744 (Fdelete_window_internal, Fresize_mini_window_internal): New
745 functions.
746 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
747
748 2011-06-08 Martin Rudalics <rudalics@gmx.at>
749
750 * window.h (window): Add some new members to window structure -
751 normal_lines, normal_cols, new_total, new_normal, clone_number,
752 splits, nest, prev_buffers, next_buffers.
753 (WINDOW_TOTAL_SIZE): Move here from window.c.
754 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
755
756 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
757 Remove.
758 (make_dummy_parent): Set new members of windows structure.
759 (make_window): Move down in code. Handle new members of window
760 structure.
761 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
762 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
763 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
764 (Fset_window_prev_buffers, Fwindow_next_buffers)
765 (Fset_window_next_buffers, Fset_window_clone_number): New
766 functions.
767 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
768 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
769 Doc-string fixes.
770 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
771 Argument WINDOW can be now internal window too.
772 (Fwindow_use_time): Move up in code.
773 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
774 Rewrite doc-string.
775 (Fset_window_configuration, saved_window)
776 (Fcurrent_window_configuration, save_window_save): Handle new
777 members of window structure.
778 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
779 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
780 (syms_of_window): New Lisp objects Qrecord_window_buffer,
781 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
782 Qget_mru_window, Qresize_root_window,
783 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
784 Qauto_buffer_name; staticpro them.
785
786 2011-06-07 Martin Rudalics <rudalics@gmx.at>
787
788 * window.c (Fwindow_total_size, Fwindow_left_column)
789 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
790 (Fwindow_list_1): New functions.
791 (window_box_text_cols): Replace with window_body_cols.
792 (Fwindow_width, Fscroll_left, Fscroll_right): Use
793 window_body_cols instead of window_box_text_cols.
794 (delete_window, Fset_window_configuration): Call
795 delete_all_subwindows with window as argument.
796 (delete_all_subwindows): Take a window as argument and not a
797 structure. Rewrite.
798 (window_loop): Remove handling of GET_LRU_WINDOW and
799 GET_LARGEST_WINDOW.
800 (Fget_lru_window, Fget_largest_window): Move to window.el.
801
802 * window.h: Extern window_body_cols instead of
803 window_box_text_cols. delete_all_subwindows now takes a
804 Lisp_Object as argument.
805
806 * indent.c (compute_motion, Fcompute_motion): Use
807 window_body_cols instead of window_box_text_cols.
808
809 * frame.c (delete_frame): Call delete_all_subwindows with root
810 window as argument.
811
812 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
813
814 * fns.c (Fputhash): Document return value.
815
816 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
817
818 * image.c (gif_load): Implement gif89a spec "no disposal" method.
819
820 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
821
822 Cons<->int and similar integer overflow fixes (Bug#8794).
823
824 Check for overflow when converting integer to cons and back.
825 * charset.c (Fdefine_charset_internal, Fdecode_char):
826 Use cons_to_unsigned to catch overflow.
827 (Fencode_char): Use INTEGER_TO_CONS.
828 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
829 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
830 * data.c (long_to_cons, cons_to_long): Remove.
831 (cons_to_unsigned, cons_to_signed): New functions.
832 These signal an error for invalid or out-of-range values.
833 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
834 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
835 * font.c (Ffont_variation_glyphs):
836 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
837 * lisp.h: Include <intprops.h>.
838 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
839 (cons_to_signed, cons_to_unsigned): New decls.
840 (long_to_cons, cons_to_long): Remove decls.
841 * undo.c (record_first_change): Use INTEGER_TO_CONS.
842 (Fprimitive_undo): Use CONS_TO_INTEGER.
843 * xfns.c (Fx_window_property): Likewise.
844 * xselect.c: Include <limits.h>.
845 (x_own_selection, selection_data_to_lisp_data):
846 Use INTEGER_TO_CONS.
847 (x_handle_selection_request, x_handle_selection_clear)
848 (x_get_foreign_selection, Fx_disown_selection_internal)
849 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
850 (lisp_data_to_selection_data): Use cons_to_unsigned.
851 (x_fill_property_data): Use cons_to_signed.
852 Report values out of range.
853
854 Check for buffer and string overflow more precisely.
855 * buffer.h (BUF_BYTES_MAX): New macro.
856 * lisp.h (STRING_BYTES_MAX): New macro.
857 * alloc.c (Fmake_string):
858 * character.c (string_escape_byte8):
859 * coding.c (coding_alloc_by_realloc):
860 * doprnt.c (doprnt):
861 * editfns.c (Fformat):
862 * eval.c (verror):
863 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
864 since they may not be the same number.
865 * editfns.c (Finsert_char):
866 * fileio.c (Finsert_file_contents):
867 Likewise for BUF_BYTES_MAX.
868
869 * image.c: Use ptrdiff_t, not int, for sizes.
870 (slurp_file): Switch from int to ptrdiff_t.
871 All uses changed.
872 (slurp_file): Check that file size fits in both size_t (for
873 malloc) and ptrdiff_t (for sanity and safety).
874
875 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
876 if b->modtime has its maximal value.
877
878 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
879
880 Don't assume time_t can fit into int.
881 * buffer.h (struct buffer.modtime): Now time_t, not int.
882 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
883 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
884
885 Minor fixes for signed vs unsigned integers.
886 * character.h (MAYBE_UNIFY_CHAR):
887 * charset.c (maybe_unify_char):
888 * keyboard.c (read_char, reorder_modifiers):
889 XINT -> XFASTINT, since the integer must be nonnegative.
890 * ftfont.c (ftfont_spec_pattern):
891 * keymap.c (access_keymap, silly_event_symbol_error):
892 XUINT -> XFASTINT, since the integer must be nonnegative.
893 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
894 since it makes no difference and we prefer signed.
895 * keyboard.c (record_char): Use XUINT when all the neighbors do.
896 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
897 nonnegative.
898
899 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
900
901 * window.h (Fwindow_frame): Declare.
902
903 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
904
905 * alloc.c: Simplify handling of large-request failures (Bug#8800).
906 (SPARE_MEMORY): Always define.
907 (LARGE_REQUEST): Remove.
908 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
909
910 2011-06-06 Martin Rudalics <rudalics@gmx.at>
911
912 * lisp.h: Move EXFUNS for Fframe_root_window,
913 Fframe_first_window and Fset_frame_selected_window to window.h.
914
915 * window.h: Move EXFUNS for Fframe_root_window,
916 Fframe_first_window and Fset_frame_selected_window here from
917 lisp.h.
918
919 * frame.c (Fwindow_frame, Fframe_first_window)
920 (Fframe_root_window, Fframe_selected_window)
921 (Fset_frame_selected_window): Move to window.c.
922 (Factive_minibuffer_window): Move to minibuf.c.
923 (Fother_visible_frames_p): New function.
924
925 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
926
927 * window.c (decode_window, decode_any_window): Move up in code.
928 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
929 (inhibit_frame_unsplittable): Remove unused variable.
930 (Fwindow_buffer): Move up and rewrite doc-string.
931 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
932 (Fwindow_prev): New functions.
933 (Fwindow_frame): Move here from frame.c. Accept any window as
934 argument.
935 (Fframe_root_window, Fframe_first_window)
936 (Fframe_selected_window): Move here from frame.c. Accept frame
937 or arbitrary window as argument. Update doc-strings.
938 (Fminibuffer_window): Move up in code.
939 (Fwindow_minibuffer_p): Move up in code and simplify.
940 (Fset_frame_selected_window): Move here from frame.c.
941 Marginal rewrite.
942 (Fselected_window, select_window, Fselect_window): Move up in
943 code. Minor doc-string fixes.
944
945 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
946
947 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
948 Do not assume that spare memory exists; that assumption is valid
949 only if SYSTEM_MALLOC.
950 (LARGE_REQUEST): New macro, so that the issue of large requests
951 is separated from the issue of spare memory.
952
953 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
954
955 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
956 format. (Bug#8806)
957
958 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
959
960 * xfns.c (x_set_scroll_bar_default_width): Move declarations
961 before statements.
962
963 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
964
965 * gtkutil.c (xg_get_default_scrollbar_width): New function.
966
967 * gtkutil.h: Declare xg_get_default_scrollbar_width.
968
969 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
970 min width by calling x_set_scroll_bar_default_width (Bug#8505).
971
972 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
973
974 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
975
976 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
977
978 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
979 (x_clipboard_manager_save): Add return value.
980 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
981 New error handlers.
982 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
983 Obey Vx_select_enable_clipboard_manager. Catch errors in
984 x_clipboard_manager_save (Bug#8779).
985 (Vx_select_enable_clipboard_manager): New variable.
986 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
987
988 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
989
990 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
991
992 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
993
994 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
995 in the current matrix if keep_current_p is non-zero.
996
997 2011-06-04 Eli Zaretskii <eliz@gnu.org>
998
999 * bidi.c (bidi_level_of_next_char): Fix last change.
1000
1001 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1002
1003 Support bidi reordering of text covered by display properties.
1004
1005 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1006 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1007 (bidi_cache_search, bidi_cache_iterator_state)
1008 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1009 (bidi_level_of_next_char, bidi_move_to_visually_next):
1010 Support character positions inside a run of characters covered by a
1011 display string.
1012 (bidi_paragraph_init, bidi_resolve_explicit_1)
1013 (bidi_level_of_next_char): Call bidi_fetch_char and
1014 bidi_fetch_char_advance instead of FETCH_CHAR and
1015 FETCH_CHAR_ADVANCE.
1016 (bidi_init_it): Initialize new members.
1017 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1018 definitions.
1019 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1020 instead of using explicit *_CHAR codes.
1021 (bidi_resolve_explicit, bidi_resolve_weak):
1022 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1023 bidirectional text is supported only in multibyte buffers.
1024 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1025 it to initialize the frame_window_p member of struct bidi_it.
1026 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1027 (bidi_resolve_explicit, bidi_resolve_weak)
1028 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1029 bidi_it->nchars is non-positive.
1030 (bidi_level_of_next_char): Don't try to lookup the cache for the
1031 next/previous character if nothing is cached there yet, or if we
1032 were just reseat()'ed to a new position.
1033
1034 * xdisp.c (set_cursor_from_row): Set start and stop points
1035 according to the row's direction when priming the loop that looks
1036 for the glyph on which to display cursor.
1037 (single_display_spec_intangible_p): Function deleted.
1038 (display_prop_intangible_p): Reimplement to call
1039 handle_display_spec instead of single_display_spec_intangible_p.
1040 Accept 3 additional arguments needed by handle_display_spec.
1041 This fixes incorrect cursor motion across display property with complex
1042 values: lists, `(when COND...)' forms, etc.
1043 (single_display_spec_string_p): Support property values that are
1044 lists with the argument STRING its top-level element.
1045 (display_prop_string_p): Fix the condition for processing a
1046 property that is a list to be consistent with handle_display_spec.
1047 (handle_display_spec): New function, refactored from the
1048 last portion of handle_display_prop.
1049 (compute_display_string_pos): Accept additional argument
1050 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1051 value of a `display' property is a "replacing spec".
1052 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1053 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1054 the display property, but just return a value indicating whether
1055 the display property will replace the characters it covers.
1056 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1057 frame_window_p members of struct bidi_it.
1058 (compute_display_string_pos, compute_display_string_end):
1059 New functions.
1060 (push_it): Accept second argument POSITION, where pop_it should
1061 jump to continue iteration.
1062 (reseat_1): Initialize bidi_it.disp_pos.
1063
1064 * keyboard.c (adjust_point_for_property): Adjust the call to
1065 display_prop_intangible_p to its new signature.
1066
1067 * dispextern.h (struct bidi_it): New member frame_window_p.
1068 (bidi_init_it): Update prototypes.
1069 (display_prop_intangible_p): Update prototype.
1070 (compute_display_string_pos, compute_display_string_end):
1071 Declare prototypes.
1072 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1073 EMACS_INT.
1074
1075 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 Malloc failure behavior now depends on size of allocation.
1078 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1079 * lisp.h: Change signatures accordingly.
1080 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1081 All callers changed. (Bug#8762)
1082
1083 * gnutls.c: Use Emacs's memory allocators.
1084 Without this change, the gnutls library would invoke malloc etc.
1085 directly, which causes problems on non-SYNC_INPUT hosts, and which
1086 runs afoul of improving memory_full behavior. (Bug#8761)
1087 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1088 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1089 xfree instead of the default malloc, realloc, free.
1090 (Fgnutls_boot): No need to check for memory allocation failure,
1091 since xmalloc does that for us.
1092
1093 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1094 * category.c (hash_get_category_set):
1095 * ccl.c (ccl_driver):
1096 * charset.c (Fdefine_charset_internal):
1097 * charset.h (struct charset.hash_index):
1098 * composite.c (get_composition_id, gstring_lookup_cache)
1099 (composition_gstring_put_cache):
1100 * composite.h (struct composition.hash_index):
1101 * dispextern.h (struct image.hash):
1102 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1103 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1104 (hashfn_equal, hashfn_user_defined, make_hash_table)
1105 (maybe_resize_hash_table, hash_lookup, hash_put)
1106 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1107 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1108 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1109 * image.c (make_image, search_image_cache, lookup_image)
1110 (xpm_put_color_table_h):
1111 * lisp.h (struct Lisp_Hash_Table):
1112 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1113 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1114 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1115 * alloc.c (allocate_vectorlike):
1116 Check for overflow in vector size calculations.
1117 * ccl.c (ccl_driver):
1118 Check for overflow when converting EMACS_INT to int.
1119 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1120 need to be updated by these changes.
1121 * fns.c (make_hash_table, maybe_resize_hash_table):
1122 Check for integer overflow with large hash tables.
1123 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1124 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1125 (SXHASH_REDUCE): New macro.
1126 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1127 Use it instead of discarding useful hash info with large hash values.
1128 (sxhash_float): New function.
1129 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1130 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1131 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1132 Rewrite to use FIXNUM_BITS, as this simplifies things.
1133 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1134 Adjust signatures to match updated version of code.
1135 (consing_since_gc): Now EMACS_INT, since a single hash table can
1136 use more than INT_MAX bytes.
1137
1138 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1139
1140 Make it possible to build with GCC-4.6+ -O2 -flto.
1141
1142 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1143
1144 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1145
1146 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1147 Call minibuffer-inactive-mode.
1148
1149 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1152 Update dependencies.
1153
1154 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1155
1156 * data.c (init_data): Remove code for UTS, this system is not
1157 supported anymore.
1158
1159 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1160
1161 Don't force ./temacs to start in terminal mode.
1162
1163 * frame.c (make_initial_frame): Initialize faces in all cases, not
1164 only when CANNOT_DUMP is defined.
1165 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1166
1167 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1168
1169 * dispnew.c (add_window_display_history): Use const for the string
1170 pointer. Remove declaration, not needed.
1171
1172 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1173
1174 Use 'inline', not 'INLINE'.
1175 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1176 * alloc.c, fontset.c (INLINE): Remove.
1177 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1178 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1179 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1180 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1181 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1182
1183 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1184
1185 Make it possible to run ./temacs.
1186
1187 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1188 syms_of_callproc does the same thing. Remove test for
1189 "initialized", do it in the caller.
1190 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1191
1192 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1193
1194 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1195 (read_minibuf): Use get_minibuffer.
1196 (syms_of_minibuf): Use DEFSYM.
1197 (Qmetadata): New var.
1198 * data.c (Qbuffer): Don't make it static.
1199 (syms_of_data): Use DEFSYM.
1200
1201 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1204 (CCL_CODE_MIN): New macro.
1205
1206 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1209
1210 * eval.c (Qdebug): Now static.
1211 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1212 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1213 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1214
1215 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * image.c: Various fixes to ImageMagick code comments.
1218 (Fimagemagick_types): Doc fix.
1219
1220 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 Minor fixes prompted by GCC 4.6.0 warnings.
1223
1224 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1225
1226 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1227 (x_clipboard_manager_save_all): Move extern decl to ...
1228 * xterm.h: ... here, so that it can be checked for consistency.
1229
1230 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1231
1232 * xselect.c (x_clipboard_manager_save_frame)
1233 (x_clipboard_manager_save_all): New functions.
1234 (Fx_clipboard_manager_save): Lisp function deleted.
1235
1236 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1237 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1238
1239 * xterm.h: Update prototype.
1240
1241 2011-05-28 William Xu <william.xwl@gmail.com>
1242
1243 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1244 exiting (Bug#8239).
1245
1246 2011-05-28 Jim Meyering <meyering@redhat.com>
1247
1248 Avoid a sign-extension bug in crypto_hash_function.
1249 * fns.c (to_uchar): Define.
1250 (crypto_hash_function): Use it to convert some newly-signed
1251 variables to unsigned, to avoid sign-extension bugs. For example,
1252 without this change, (md5 "truc") would evaluate to
1253 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1254 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1255 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1256
1257 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 Integer overflow fixes.
1260
1261 * dbusbind.c: Serial number integer overflow fixes.
1262 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1263 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1264 to hold a serial number that is too large for a fixnum.
1265 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1266 Check for serial numbers out of range. Decode any serial number
1267 that was so large that it became a float. (Bug#8722)
1268
1269 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1270 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1271 Use XFASTINT rather than XUINT when numbers are nonnegative.
1272 (xd_append_arg, Fdbus_method_return_internal):
1273 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1274 arguments, check that Lisp number is nonnegative, rather than
1275 silently wrapping negative numbers around. (Bug#8722)
1276 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1277 (Bug#8722)
1278
1279 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1280
1281 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1282
1283 ccl: add integer overflow checks
1284 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1285 (IN_INT_RANGE): New macros.
1286 (ccl_driver): Use them to check for integer overflow when
1287 decoding a CCL program. Many of the new checks are whether XINT (x)
1288 fits in int; it doesn't always, on 64-bit hosts. The new version
1289 doesn't catch all possible integer overflows, but it's an
1290 improvement. (Bug#8719)
1291
1292 * alloc.c (make_event_array): Use XINT, not XUINT.
1293 There's no need for unsigned here.
1294
1295 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1296 This follows up to the 2011-05-06 change that substituted uintptr_t
1297 for EMACS_INT. This case wasn't caught back then.
1298
1299 Rework Fformat to avoid integer overflow issues.
1300 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1301 now (part of C89). Include <verify.h>.
1302 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1303 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1304 (Fformat): Avoid the prepass trying to compute sizes; it was only
1305 approximate and thus did not catch overflow reliably. Instead, walk
1306 through the format just once, formatting and computing sizes as we go,
1307 checking for integer overflow at every step, and allocating a larger
1308 buffer as needed. Keep track separately whether the format is
1309 multibyte. Keep only the most-recently calculated precision, rather
1310 than them all. Record whether each argument has been converted to
1311 string. Use EMACS_INT, not int, for byte and char and arg counts.
1312 Support field widths and precisions larger than INT_MAX. Avoid
1313 sprintf's undefined behavior with conversion specifications such as %#d
1314 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1315 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1316 formatting out-of-range floating point numbers with int
1317 formats. (Bug#8668)
1318
1319 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1320
1321 * data.c: Avoid integer truncation in expressions involving floats.
1322 * data.c: Include <intprops.h>.
1323 (arith_driver): When there's an integer overflow in an expression
1324 involving floating point, convert the integers to floating point
1325 so that the resulting value does not suffer from catastrophic
1326 integer truncation. For example, on a 64-bit host (* 4
1327 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1328 Do not rely on undefined behavior after integer overflow.
1329
1330 merge count_size_as_multibyte, parse_str_to_multibyte
1331 * character.c, character.h (count_size_as_multibyte):
1332 Rename from parse_str_to_multibyte; all uses changed.
1333 Check for integer overflow.
1334 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1335 since it's now a duplicate of the other. This is more of
1336 a character than a buffer op, so better that it's in character.c.
1337 * fns.c, print.c: Adjust to above changes.
1338
1339 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1340
1341 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1342
1343 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1346 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1347 (x_clipboard_manager_save): Now static.
1348 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1349
1350 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1351 (crypto_hash_function): Now static.
1352 Fix pointer signedness problems. Avoid unnecessary initializations.
1353
1354 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1355
1356 * termhooks.h (Vselection_alist): Make it terminal-local.
1357
1358 * terminal.c (create_terminal): Initialize it.
1359
1360 * xselect.c: Support for clipboard managers.
1361 (Vselection_alist): Move to termhooks.h as terminal-local var.
1362 (LOCAL_SELECTION): New macro.
1363 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1364 (symbol_to_x_atom): Remove gratuitous arg.
1365 (x_handle_selection_request, lisp_data_to_selection_data)
1366 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1367 (x_own_selection, x_get_local_selection, x_convert_selection):
1368 New arg, specifying work frame. Use terminal-local Vselection_alist.
1369 (some_frame_on_display): Delete unused function.
1370 (Fx_own_selection_internal, Fx_get_selection_internal)
1371 (Fx_disown_selection_internal, Fx_selection_owner_p)
1372 (Fx_selection_exists_p): New optional frame arg.
1373 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1374 (x_handle_selection_clear): Don't treat other terminals with the
1375 same keyboard specially. Use the terminal-local Vselection_alist.
1376 (x_clear_frame_selections): Use Frun_hook_with_args.
1377
1378 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1379
1380 * xterm.h: Add support for those atoms.
1381
1382 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1383
1384 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1385 (converted_selections, conversion_fail_tag): New global variables.
1386 (x_selection_request_lisp_error): Free the above.
1387 (x_get_local_selection): Remove unnecessary code.
1388 (x_reply_selection_request): Args changed; handle arbitrary array
1389 of converted selections stored in converted_selections.
1390 Separate the XChangeProperty and SelectionNotify steps.
1391 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1392 (x_convert_selection): New function.
1393 (x_handle_selection_event): Simplify.
1394 (x_get_foreign_selection): Don't ignore incoming requests while
1395 waiting for an answer; this will fail when we implement
1396 SAVE_TARGETS, and seems unnecessary anyway.
1397 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1398 (Vx_sent_selection_functions): Doc fix.
1399
1400 2011-05-26 Leo Liu <sdl.web@gmail.com>
1401
1402 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1403
1404 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1405
1406 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1407
1408 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1409 for fringe update if it has periodic bitmap.
1410 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1411 and fringe_bitmap_periodic_p.
1412
1413 * fringe.c (get_fringe_bitmap_data): New function.
1414 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1415 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1416 row. Mark glyph row for fringe update if periodicity changed.
1417
1418 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1419 for fringe update unless it has periodic bitmap.
1420
1421 2011-05-25 Kenichi Handa <handa@m17n.org>
1422
1423 * xdisp.c (get_next_display_element): Set correct it->face_id for
1424 a static composition.
1425
1426 2011-05-24 Leo Liu <sdl.web@gmail.com>
1427
1428 * deps.mk (fns.o):
1429 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1430
1431 * fns.c (crypto_hash_function, Fsha1): New function.
1432 (Fmd5): Use crypto_hash_function.
1433 (syms_of_fns): Add Ssha1.
1434
1435 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * gnutls.c: Remove unused macros.
1438 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1439 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1440 Remove macros that are defined and never used.
1441 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1442
1443 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1444
1445 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1446 (Fx_get_selection_internal): Minor cleanup.
1447 (Fx_own_selection_internal): Rename arguments for consistency with
1448 select.el.
1449
1450 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1453
1454 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1455
1456 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1457
1458 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1459
1460 * dispnew.c (scrolling_window): Don't exclude the case that the
1461 last enabled row in the desired matrix touches the bottom boundary.
1462
1463 2011-05-21 Glenn Morris <rgm@gnu.org>
1464
1465 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1466 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1467 and add some more files.
1468
1469 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1470
1471 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1472 report_file_error introduced by the change from 2011-05-07.
1473
1474 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * systime.h (Time): Define only if emacs is defined.
1477 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1478 where the include path doesn't have X11/X.h by default. See
1479 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1480
1481 2011-05-20 Kenichi Handa <handa@m17n.org>
1482
1483 * composite.c (find_automatic_composition): Fix previous change.
1484
1485 2011-05-20 Glenn Morris <rgm@gnu.org>
1486
1487 * lisp.mk: New file, split from Makefile.in.
1488 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1489 (shortlisp): Remove.
1490 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1491
1492 2011-05-19 Glenn Morris <rgm@gnu.org>
1493
1494 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1495 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1496 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1497 (lisp): Set the order to that of loadup.el.
1498 (shortlisp): Make it a copy of $lisp.
1499 (SOME_MACHINE_LISP): Remove.
1500 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1501 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1502
1503 2011-05-18 Kenichi Handa <handa@m17n.org>
1504
1505 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1506 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1507 (find_automatic_composition): Mostly rewrite for efficiency.
1508
1509 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * makefile.w32-in: Update dependencies.
1512
1513 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1514
1515 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1516 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1517
1518 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Fix some integer overflow issues, such as string length overflow.
1521
1522 * insdel.c (count_size_as_multibyte): Check for string overflow.
1523
1524 * character.c (lisp_string_width): Check for string overflow.
1525 Use EMACS_INT, not int, for string indexes and lengths; in
1526 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1527 the resulting string length overflows an EMACS_INT; instead,
1528 report a string overflow if no precision given. When checking for
1529 precision exhaustion, use a check that cannot possibly have
1530 integer overflow. (Bug#8675)
1531 * character.h (lisp_string_width): Adjust to new signature.
1532
1533 * alloc.c (string_overflow): New function.
1534 (Fmake_string): Use it. This doesn't change behavior, but saves
1535 a few bytes and will simplify future changes.
1536 * character.c (string_escape_byte8): Likewise.
1537 * lisp.h (string_overflow): New decl.
1538
1539 Fixups, following up to the user-interface timestamp change.
1540 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1541 for UI timestamps, instead of unsigned long.
1542 * msdos.c (mouse_get_pos): Likewise.
1543 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1544 * w32gui.h (Time): Define by including "systime.h" rather than by
1545 declaring it ourselves. (Bug#8664)
1546
1547 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1548 * image.c (clear_image_cache): Likewise.
1549
1550 * term.c (term_mouse_position): Don't assume time_t wraparound.
1551
1552 Be more systematic about user-interface timestamps.
1553 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1554 and sometimes 'EMACS_UINT', to represent these timestamps.
1555 This change causes it to use 'Time' uniformly, as that's what X uses.
1556 This makes the code easier to follow, and makes it easier to catch
1557 integer overflow bugs such as Bug#8664.
1558 * frame.c (Fmouse_position, Fmouse_pixel_position):
1559 Use Time, not unsigned long, for user-interface timestamps.
1560 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1561 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1562 * keyboard.h (last_event_timestamp): Likewise.
1563 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1564 * menu.h (xmenu_show): Likewise.
1565 * term.c (term_mouse_position): Likewise.
1566 * termhooks.h (struct input_event.timestamp): Likewise.
1567 (struct terminal.mouse_position_hook): Likewise.
1568 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1569 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1570 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1571 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1572 what it was before.
1573 * menu.h, termhooks.h: Include "systime.h", for Time.
1574
1575 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1576 Don't assume that the difference between two unsigned long values
1577 can fit into an integer. At this point, we know button_down_time
1578 <= event->timestamp, so the difference must be nonnegative, so
1579 there's no need to cast the result if double-click-time is
1580 nonnegative, as it should be; check that it's nonnegative, just in
1581 case. This bug is triggered when events are more than 2**31 ms
1582 apart (about 25 days). (Bug#8664)
1583
1584 * xselect.c (last_event_timestamp): Remove duplicate decl.
1585 (x_own_selection): Remove needless cast to unsigned long.
1586
1587 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1588 that always fit in int. Use a sentinel instead of a counter, to
1589 avoid a temp and to allay GCC's concerns about possible int overflow.
1590 * frame.h (struct frame): Use int for menu_bar_items_used
1591 instead of EMACS_INT, since it always fits in int.
1592
1593 * menu.c (grow_menu_items): Check for int overflow.
1594
1595 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1596
1597 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1598 Before, the code was not consistent. These values cannot exceed
1599 2**31 - 1 so there's no need to make them unsigned.
1600 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1601 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1602 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1603 as modifiers.
1604 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1605
1606 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1607 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1608 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1609 presumably because the widths might not match.
1610
1611 * window.c (size_window): Avoid needless test at loop start.
1612
1613 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1614
1615 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1616
1617 2011-05-12 Drew Adams <drew.adams@oracle.com>
1618
1619 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1620
1621 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1622
1623 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1624 `width' to `bar_area_x' and `bar_area_width', respectively.
1625 (x_scroll_run): Take account of fringe background extension.
1626
1627 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1628 Rename local vars `left' and `width' to `bar_area_x' and
1629 `bar_area_width', respectively.
1630 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1631 background extension.
1632
1633 2011-05-10 Jim Meyering <meyering@redhat.com>
1634
1635 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1636
1637 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1638
1639 * image.c (Finit_image_library): Return t for built-in image types,
1640 like pbm and xbm. (Bug#8640)
1641
1642 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1643
1644 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1645
1646 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1647
1648 * w32console.c (Fset_screen_color): Doc fix.
1649 (Fget_screen_color): New function.
1650 (syms_of_ntterm): Defsubr it.
1651
1652 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1653 unlink the temporary file if Fcall_process didn't create it in the
1654 first place.
1655 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1656 child process will be redirected to a file specified with `:file'.
1657 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1658 cue to call_process_cleanup not to close that handle.
1659
1660 2011-05-07 Ben Key <bkey76@gmail.com>
1661
1662 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1663 one of two shell specific rules, either bootstrap-temacs-CMD or
1664 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1665 to the previous implementation of the bootstrap-temacs rule.
1666 The bootstrap-temacs-CMD rule is similar to the previous
1667 implementation of the bootstrap-temacs rule except that it
1668 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1669 variable.
1670
1671 These changes, along with some changes to nt/configure.bat,
1672 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1673 earlier fix to add support for --cflags and --ldflags options
1674 that include quotes so that it works whether make uses cmd or
1675 sh as the shell.
1676
1677 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1678
1679 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1680 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1681 is a constant.
1682 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1683 a string. Handle both cases.
1684 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1685 (Fdbus_register_method): Use Qinvalid_function.
1686
1687 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1688
1689 * makefile.w32-in: Update dependencies.
1690 (LISP_H): Add inttypes.h and stdin.h.
1691 (PROCESS_H): Add unistd.h.
1692
1693 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1694
1695 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1696 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1697
1698 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1701
1702 * term.c (vfatal): Remove stray call to va_end.
1703 It's not needed and the C Standard doesn't allow it here anyway.
1704
1705 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1706 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1707
1708 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1709 bytes.
1710
1711 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1712
1713 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1714
1715 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1716
1717 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1718
1719 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1720
1721 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1722 * charset.c (Fdefine_charset_internal): Don't initialize
1723 charset.code_space[15]. The value was garbage, on hosts with
1724 32-bit int (Bug#8600).
1725
1726 * lread.c (read_integer): Be more consistent with string-to-number.
1727 Use string_to_number to do the actual conversion; this avoids
1728 rounding errors and fixes some other screwups. Without this fix,
1729 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1730 (digit_to_number): Move earlier, for benefit of read_integer.
1731 Return -1 if the digit is out of range for the base, -2 if it is
1732 not a digit in any supported base. (Bug#8602)
1733
1734 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1735
1736 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1737 to match comment at start of function. This also removes a
1738 GCC warning about overflow in a 32+64-bit port.
1739
1740 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1741
1742 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1743 Reported by Stefan Monnier in
1744 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1745 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1746 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1747
1748 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1749 (EMACS_UINTPTR): Likewise, with uintptr_t.
1750
1751 * lisp.h: Prefer 64-bit EMACS_INT if available.
1752 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1753 on 32-bit hosts that have 64-bit int, so that they can access
1754 large files.
1755 However, temporarily disable this change unless the temporary
1756 symbol WIDE_EMACS_INT is defined.
1757
1758 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1759
1760 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1761 This removes an assumption that EMACS_INT and long are the same
1762 width as pointers. The assumption is true for Emacs porting targets
1763 now, but we want to make other targets possible.
1764 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1765 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1766 In the rest of the code, change types of integers that hold casted
1767 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1768 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1769 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1770 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1771 No need to cast type when ORing.
1772 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1773 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1774 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1775 assume EMACS_INT is the same width as char *.
1776 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1777 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1778 Remove no-longer-needed casts.
1779 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1780 (xg_tool_bar_help_callback, xg_make_tool_item):
1781 Use EMACS_INTPTR to hold an integer
1782 that will be cast to void *; this can avoid a GCC warning
1783 if EMACS_INT is not the same width as void *.
1784 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1785 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1786 (current_message_1, set_message_1):
1787 Use a local to convert to proper width without a cast.
1788 * xmenu.c (dialog_selection_callback): Likewise.
1789
1790 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1791 Also, don't assume VALBITS / RAND_BITS is less than 5,
1792 and don't rely on undefined behavior when shifting a 1 left into
1793 the sign bit.
1794 * lisp.h (get_random): Change signature to match.
1795
1796 * lread.c (hash_string): Use size_t, not int, for hash computation.
1797 Normally we prefer signed values; but hashing is special, because
1798 it's better to use unsigned division on hash table sizes so that
1799 the remainder is nonnegative. Also, size_t is the natural width
1800 for hashing into memory. The previous code used 'int', which doesn't
1801 retain enough info to hash well into very large tables.
1802 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1803
1804 * dbusbind.c: Don't possibly lose pointer info when converting.
1805 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1806 Use XPNTR rather than XHASH, so that the high-order bits of
1807 the pointer aren't lost when converting through void *.
1808
1809 * eval.c (Fautoload): Don't double-shift a pointer.
1810
1811 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1812
1813 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1814
1815 * gnutls.c (DEF_GNUTLS_FN):
1816 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1817
1818 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1819
1820 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1821 marker. (Bug#8610)
1822
1823 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1824
1825 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1826 New version that can reserve upto 2GB of heap space.
1827
1828 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1829
1830 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1831
1832 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1833
1834 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1835 `gnutls_certificate_set_x509_key_file'.
1836
1837 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1838
1839 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1840 Update dependencies.
1841
1842 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1845 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1846 Remove unused parameter `fildes'.
1847 * process.c (read_process_output, send_process): Don't pass it.
1848
1849 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1850
1851 Fix previous change: the library cache is defined in w32.c.
1852 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1853 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1854
1855 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1856
1857 Implement dynamic loading of GnuTLS on Windows.
1858
1859 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1860 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1861 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1862 Declare.
1863
1864 * gnutls.c (Qgnutls_dll): Define.
1865 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1866 (gnutls_*): Declare function pointers.
1867 (init_gnutls_functions): New function to initialize function pointers.
1868 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1869 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1870 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1871 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1872 (emacs_gnutls_write, emacs_gnutls_read)
1873 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1874 (Fgnutls_available_p): New function.
1875 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1876 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1877 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1878
1879 * image.c: Include w32.h.
1880 (Vimage_type_cache): Delete.
1881 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1882 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1883 (w32_delayed_load): Move to w32.c.
1884
1885 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1886
1887 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1888 (w32_delayed_load): Move from image.c. When loading a library, record
1889 its filename in the :loaded-from property of the library id.
1890 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1891 Initialize and staticpro them.
1892 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1893
1894 * process.c: Include lisp.h before w32.h, not after.
1895 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1896 instead of gnutls_record_check_pending.
1897
1898 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1899
1900 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1901
1902 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1903 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1904 as passed in.
1905
1906 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1907
1908 * xterm.c (x_set_frame_alpha): Do not set property on anything
1909 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1910
1911 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1912
1913 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1914
1915 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1918 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1919 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1920 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1921 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1922 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1923 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1924 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1925 (Qgnutls_bootprop_callbacks_verify): Make static.
1926
1927 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1928
1929 * callproc.c: Indentation fixup.
1930
1931 * sysdep.c (wait_for_termination_1): Make static.
1932 (wait_for_termination, interruptible_wait_for_termination):
1933 Move after wait_for_termination_1.
1934
1935 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1936
1937 * sysdep.c (interruptible_wait_for_termination): New function
1938 which is like wait_for_termination, but allows keyboard
1939 interruptions.
1940
1941 * callproc.c (Fcall_process): Add (:file "file") as an option for
1942 the STDOUT buffer.
1943 (Fcall_process_region): Ditto.
1944
1945 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1946
1947 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1948 rather than `XVECTOR (FOO)->size'.
1949
1950 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1951 inttypes.h, as a gnulib replacement is used if it not available in
1952 system headers.
1953
1954 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1955
1956 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1957 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1958 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1959
1960 * coding.c (coding_alloc_by_realloc): Error out if destination
1961 will grow beyond MOST_POSITIVE_FIXNUM.
1962 (decode_coding_emacs_mule): Abort if there isn't enough place in
1963 charbuf for the composition carryover bytes. Reserve an extra
1964 space for up to 2 characters produced in a loop.
1965 (decode_coding_iso_2022): Abort if there isn't enough place in
1966 charbuf for the composition carryover bytes.
1967
1968 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1969
1970 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1971 aborting when %lld or %lll format is passed.
1972 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1973 %llo or %llx format is passed. (Bug#8545)
1974
1975 * window.c (window_scroll_line_based): Use a marker instead of
1976 simple variables to record original value of point. (Bug#7952)
1977
1978 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1979 produced by %s or %c overflows available buffer space. (Bug#8545)
1980
1981 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1984 (SIZE_MAX): Move defn after all includes, as they might #define it.
1985
1986 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1987
1988 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1989
1990 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1991
1992 * keyboard.c (Qdelayed_warnings_hook): Define.
1993 (command_loop_1): Run `delayed-warnings-hook'
1994 if Vdelayed_warnings_list is non-nil.
1995 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1996 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1997
1998 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1999
2000 * doprnt.c (doprnt): Don't return value smaller than the buffer
2001 size if the message was truncated. (Bug#8545).
2002
2003 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2006 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2007
2008 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2011
2012 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2013
2014 * makefile.w32-in: Update dependencies.
2015
2016 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2017
2018 Improve `doprnt' and its usage. (Bug#8545)
2019 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2020 `format_end'. Remove support for %l as a conversion specifier.
2021 Don't use xrealloc. Improve diagnostics when the %l size modifier
2022 is used. Update the commentary.
2023
2024 * eval.c (verror): Simplify calculation of size_t.
2025
2026 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2027 messages.
2028
2029 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2030
2031 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2032 change.
2033
2034 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2037 This makes this file independent of the recent pseudovector change.
2038
2039 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2042
2043 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2044 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2045 Remove unused local.
2046 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2047
2048 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2049 GCC 4.6.0 optimizes based on type-based alias analysis.
2050 For example, if b is of type struct buffer * and v of type struct
2051 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2052 != &v->size, and therefore "v->size = 1; b->size = 2; return
2053 v->size;" must therefore return 1. This assumption is incorrect
2054 for Emacs, since it type-puns struct Lisp_Vector * with many other
2055 types. To fix this problem, this patch adds a new type struct
2056 vectorlike_header that documents the constraints on layout of vectors
2057 and pseudovectors, and helps optimizing compilers not get fooled
2058 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2059 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2060 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2061 the size member.
2062 (XSETPVECTYPE): Rewrite in terms of new macro.
2063 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2064 This is a bit clearer, and further avoids the possibility of
2065 undesirable aliasing.
2066 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2067 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2068 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2069 since Lisp_Subr is a special case (no "next" field).
2070 (ASIZE): Now uses header.size rather than size.
2071 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2072 to avoid the hassle of writing XVECTOR (foo)->header.size.
2073 (struct vectorlike_header): New type.
2074 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2075 object, to help avoid aliasing.
2076 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2077 (SUBRP): Likewise, since Lisp_Subr is a special case.
2078 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2079 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2080 (struct Lisp_Hash_Table): Combine first two members into a single
2081 struct vectorlike_header member. All uses of "size" and "next" members
2082 changed to be "header.size" and "header.next".
2083 * buffer.h (struct buffer): Likewise.
2084 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2085 * frame.h (struct frame): Likewise.
2086 * process.h (struct Lisp_Process): Likewise.
2087 * termhooks.h (struct terminal): Likewise.
2088 * window.c (struct save_window_data, struct saved_window): Likewise.
2089 * window.h (struct window): Likewise.
2090 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2091 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2092 * buffer.c (init_buffer_once): Likewise.
2093 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2094 special case.
2095 * process.c (Fformat_network_address): Use local var for size,
2096 for brevity.
2097
2098 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2099
2100 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2101 * data.c (atof): Remove decl; no longer used or needed.
2102 (digit_to_number): Move to lread.c.
2103 (Fstring_to_number): Use new string_to_number function, to be
2104 consistent with how the Lisp reader treats infinities and NaNs.
2105 Do not assume that floating-point numbers represent EMACS_INT
2106 without losing information; this is not true on most 64-bit hosts.
2107 Avoid double-rounding errors, by insisting on integers when
2108 parsing non-base-10 numbers, as the documentation specifies.
2109 * lisp.h (string_to_number): New decl, replacing ...
2110 (isfloat_string): Remove.
2111 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2112 (read1): Do not accept +. and -. as integers; this
2113 appears to have been a coding error. Similarly, do not accept
2114 strings like +-1e0 as floating point numbers. Do not report
2115 overflow for integer overflows unless the base is not 10 which
2116 means we have no simple and reliable way to continue.
2117 Break out the floating-point parsing into a new
2118 function string_to_number, so that Fstring_to_number parses
2119 floating point numbers consistently with the Lisp reader.
2120 (digit_to_number): Move here from data.c. Make it static inline.
2121 (E_CHAR, EXP_INT): Remove, replacing with ...
2122 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2123 (string_to_number): New function, replacing isfloat_string.
2124 This function checks for valid syntax and produces the resulting
2125 Lisp float number too. Rework it so that string-to-number
2126 no longer mishandles examples like "1.0e+". Use strtoumax,
2127 so that overflow for non-base-10 numbers is reported only when
2128 there's no portable and simple way to convert to floating point.
2129
2130 * textprop.c (set_text_properties_1): Rewrite for clarity,
2131 and to avoid GCC warning about integer overflow.
2132
2133 * intervals.h (struct interval): Use EMACS_INT for members
2134 where EMACS_UINT might cause problems. See
2135 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2136 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2137 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2138 All uses changed.
2139 (offset_intervals): Tell GCC not to worry about length overflow
2140 when negating a negative length.
2141
2142 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2143 (overrun_check_free): Likewise.
2144
2145 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2146 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2147 word size.
2148
2149 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2150 (gnutls_make_error): Rename local to avoid shadowing.
2151 (gnutls_emacs_global_deinit): ifdef out; not used.
2152 (Fgnutls_boot): Use const for pointer to readonly storage.
2153 Comment out unused local. Fix pointer signedness problems.
2154
2155 * lread.c (openp): Don't stuff size_t into an 'int'.
2156 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2157 about possible signed overflow.
2158
2159 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2160 (GDK_KEY_g): Don't define if already defined.
2161 (xg_prepare_tooltip): Avoid pointer signedness problem.
2162 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2163
2164 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2165 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2166
2167 * xfns.c (Fx_window_property): Simplify a bit,
2168 to make a bit faster and to avoid GCC 4.6.0 warning.
2169 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2170
2171 * fns.c (internal_equal): Don't assume size_t fits in int.
2172
2173 * alloc.c (compact_small_strings): Tighten assertion a little.
2174
2175 Replace pEd with more-general pI, and fix some printf arg casts.
2176 * lisp.h (pI): New macro, generalizing old pEd macro to other
2177 conversion specifiers. For example, use "...%"pI"d..." rather
2178 than "...%"pEd"...".
2179 (pEd): Remove. All uses replaced with similar uses of pI.
2180 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2181 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2182 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2183 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2184 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2185 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2186 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2187 64-bit hosts.
2188 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2189 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2190 * print.c (safe_debug_print, print_object): Likewise.
2191 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2192 to int.
2193 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2194 avoiding the 0 flag, which is not portable.
2195 * process.c (Fmake_network_process): Use pI to avoid cast.
2196 * region-cache.c (pp_cache): Likewise.
2197 * xdisp.c (decode_mode_spec): Likewise.
2198 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2199 behavior on 64-bit hosts with printf arg.
2200 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2201 (x_stop_queuing_selection_requests): Likewise.
2202 (x_get_window_property): Don't truncate byte count to an 'int'
2203 when tracing.
2204
2205 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2206 here, since it parses constructs like leading '-' and spaces,
2207 which are not wanted; and it overflows with large numbers.
2208 Instead, simply match F[0-9]+, which is what is wanted anyway.
2209
2210 * alloc.c: Remove unportable assumptions about struct layout.
2211 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2212 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2213 (allocate_vectorlike, make_pure_vector): Use the new macros,
2214 plus offsetof, to remove unportable assumptions about struct layout.
2215 These assumptions hold on all porting targets that I know of, but
2216 they are not guaranteed, they're easy to remove, and removing them
2217 makes further changes easier.
2218
2219 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2220 This doesn't fix a bug but makes the code clearer.
2221 (string_overrun_cookie): Now const. Use initializers that
2222 don't formally overflow signed char, to avoid warnings.
2223 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2224 can cause Emacs to crash when string overrun checking is enabled.
2225 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2226 multiple of sizeof (EMACS_INT); it need not be, if
2227 alignof(EMACS_INT) < sizeof (EMACS_INT).
2228 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2229
2230 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2233
2234 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2235
2236 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2237 supposed to be handshaking. (Bug#8556)
2238 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2239
2240 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2241
2242 * lisp.h (Qdebug): List symbol.
2243 * eval.c (Qdebug): Restore global linkage.
2244 * keyboard.c (debug-on-event): New variable.
2245 (handle_user_signal): Break into debugger when debug-on-event
2246 matches the current signal symbol.
2247
2248 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2249
2250 * alloc.c (check_sblock, check_string_bytes)
2251 (check_string_free_list): Convert to standard C.
2252
2253 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2254
2255 * w32.c (emacs_gnutls_push): Fix typo.
2256
2257 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2258
2259 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2260 "cast to pointer from integer of different size".
2261
2262 Improve doprnt and its use in verror. (Bug#8545)
2263 * doprnt.c (doprnt): Document the set of format control sequences
2264 supported by the function. Use SAFE_ALLOCA instead of always
2265 using `alloca'.
2266
2267 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2268 is one byte too soon. Don't use xrealloc; instead xfree and
2269 xmalloc anew.
2270
2271 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2272
2273 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2274 callbacks stage.
2275
2276 * gnutls.c: Renamed global_initialized to
2277 gnutls_global_initialized. Added internals for the
2278 :verify-hostname-error, :verify-error, and :verify-flags
2279 parameters of `gnutls-boot' and documented those parameters in the
2280 docstring. Start callback support.
2281 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2282 unless a fatal error occured. Call gnutls_alert_send_appropriate
2283 on error. Return error code.
2284 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2285 (emacs_gnutls_read): Likewise.
2286 (Fgnutls_boot): Return handshake error code.
2287 (emacs_gnutls_handle_error): New function.
2288 (wsaerror_to_errno): Likewise.
2289
2290 * w32.h (emacs_gnutls_pull): Add prototype.
2291 (emacs_gnutls_push): Likewise.
2292
2293 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2294 (emacs_gnutls_push): Likewise.
2295
2296 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2297
2298 * process.c (wait_reading_process_output): Check if GnuTLS
2299 buffered some data internally if no FDs are set for TLS
2300 connections.
2301
2302 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2303 (LIBS): Link to USER_LIBS.
2304 ($(BLD)/gnutls.$(0)): New target.
2305
2306 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2307
2308 * xdisp.c (handle_single_display_spec): Rename the
2309 display_replaced_before_p argument into display_replaced_p, to
2310 make it consistent with the commentary. Fix typos in the
2311 commentary.
2312
2313 * textprop.c (syms_of_textprop): Remove dead code.
2314 (copy_text_properties): Delete obsolete commentary about an
2315 interface that was deleted long ago. Fix typos in the description
2316 of arguments.
2317
2318 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2319 to changes in oldXMenu/XMenu.h from 2011-04-16.
2320 <menu_help_message, prev_menu_help_message>: Constify.
2321 (IT_menu_make_room): menu->help_text is now `const char **';
2322 adjust.
2323
2324 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2325 to changes in oldXMenu/XMenu.h from 2011-04-16.
2326 (struct XMenu): Declare `help_text' `const char **'.
2327
2328 * xfaces.c <Qunspecified>: Make extern again.
2329
2330 * syntax.c: Include sys/types.h before including regex.h, as
2331 required by Posix.
2332
2333 * doc.c (get_doc_string): Improve the format passed to `error'.
2334
2335 * doprnt.c (doprnt): Improve commentary.
2336
2337 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2338
2339 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2340 them with etags.
2341
2342 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2343 changes in globals.h immediately force recompilation.
2344 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2345 $(CURDIR)/s/ms-w32.h.
2346 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2347
2348 * character.c (Fchar_direction): Function deleted.
2349 (syms_of_character): Don't defsubr it.
2350 <char-direction-table>: Deleted.
2351
2352 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2353
2354 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2355 * doprnt.c: Include limits.h.
2356 (SIZE_MAX): New macro.
2357 (doprnt): Return a size_t value. 2nd arg is now size_t.
2358 Many local variables are now size_t instead of int or unsigned.
2359 Improve overflow protection. Support `l' modifier for integer
2360 conversions. Support %l conversion. Don't assume an EMACS_INT
2361 argument for integer conversions and for %c.
2362
2363 * lisp.h (doprnt): Restore prototype.
2364
2365 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2366 $(SRC)/character.h.
2367
2368 * Makefile.in (base_obj): Add back doprnt.o.
2369
2370 * deps.mk (doprnt.o): Add back prerequisites.
2371 (callint.o): Depend on character.h.
2372
2373 * eval.c (internal_lisp_condition_case): Include the handler
2374 representation in the error message.
2375 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2376 when breaking from the loop.
2377
2378 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2379
2380 * callint.c (Fcall_interactively): When displaying error message
2381 about invalid control letter, pass the character's codepoint, not
2382 a pointer to its multibyte form. Improve display of the character
2383 in octal and display also its hex code.
2384
2385 * character.c (char_string): Use %x to display the (unsigned)
2386 codepoint of an invalid character, to avoid displaying a bogus
2387 negative value.
2388
2389 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2390 `error', not SYMBOL_NAME itself.
2391
2392 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2393 character arguments to `error'.
2394
2395 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2396 to `error' in error message about FINAL_CHAR argument. Make sure
2397 FINAL_CHAR is a character, and use %c when it is passed as
2398 argument to `error'.
2399
2400 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2401
2402 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2403
2404 * w32.c: Include <time.h>.
2405 (sys_localtime): New function.
2406
2407 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2408
2409 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2410
2411 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2412
2413 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2414
2415 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2416 zombies (Bug#8467).
2417
2418 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2419
2420 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2421 gl_state.e_property when gl_state.object is Qt.
2422
2423 * insdel.c (make_gap_larger): Remove limitation of buffer size
2424 to <= INT_MAX.
2425
2426 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2427
2428 * xdisp.c (lookup_glyphless_char_display)
2429 (produce_glyphless_glyph): Handle cons cell entry in
2430 glyphless-char-display.
2431 (Vglyphless_char_display): Document it.
2432
2433 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2434 glyphless-char-display.
2435
2436 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2437
2438 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2439
2440 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2441
2442 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2443 definition for no-X builds.
2444
2445 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2446
2447 Static checks with GCC 4.6.0 and non-default toolkits.
2448
2449 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2450
2451 * process.c (keyboard_bit_set): Define only if SIGIO.
2452 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2453 (send_process): Repair possible setjmp clobbering.
2454
2455 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2456
2457 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2458
2459 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2460
2461 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2462 Define only if needed.
2463
2464 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2465 by pacifying GCC about it. Maybe it's time to retire it?
2466 * xfaces.c (USG, __TIMEVAL__): Likewise.
2467
2468 * dispextern.h (struct redisplay_interface): Rename param
2469 to avoid shadowing.
2470 * termhooks.h (struct terminal): Likewise.
2471 * xterm.c (xembed_send_message): Likewise.
2472
2473 * insdel.c (make_gap_smaller): Define only if
2474 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2475
2476 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2477 it.
2478
2479 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2480 so that we aren't warned about unused symbols.
2481
2482 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2483
2484 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2485
2486 * xfns.c (x_real_positions): Mark locals as initialized.
2487
2488 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2489
2490 * xterm.c: Fix problems found by static analysis with other toolkits.
2491 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2492 (x_dispatch_event): Declare static if USE_GTK, and
2493 define if USE_GTK || USE_X_TOOLKIT.
2494 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2495 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2496 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2497 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2498
2499 * xmenu.c (menu_help_callback): Pointer type fixes.
2500 Use const pointers when pointing at readonly data. Avoid pointer
2501 signedness clashes.
2502 (FALSE): Remove unused macro.
2503 (update_frame_menubar): Remove unused decl.
2504
2505 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2506
2507 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2508 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2509 (single_menu_item): Rename local to avoid shadowing.
2510
2511 * keyboard.c (make_lispy_event): Remove unused local var.
2512
2513 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2514 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2515
2516 * bitmaps: Change bitmaps from unsigned char back to the X11
2517 compatible char. Avoid the old compiler warnings about
2518 out-of-range initializers by using, for example, '\xab' rather
2519 than 0xab.
2520
2521 * xgselect.c (xgselect_initialize): Check vs interface
2522 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2523
2524 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2525
2526 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2527 to read-only memory.
2528
2529 * fns.c (vector): Remove; this old hack is no longer needed.
2530
2531 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2532 Remove unused var.
2533 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2534
2535 * xrdb.c (x_load_resources): Omit unused local.
2536
2537 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2538 (x_window): Rename locals to avoid shadowing.
2539 (USG): Use the kludged USG macro, to pacify gcc.
2540
2541 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2542 (x_term_init): Remove local to avoid shadowing.
2543
2544 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2545
2546 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2547 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2548
2549 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2550
2551 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2552
2553 Fix regex.c, syntax.c and friends for buffers > 2GB.
2554 * syntax.h (struct gl_state_s): Declare character position members
2555 EMACS_INT.
2556
2557 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2558
2559 * textprop.c (verify_interval_modification, interval_of):
2560 Declare arguments EMACS_INT.
2561
2562 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2563 EMACS_INT.
2564
2565 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2566
2567 * indent.c (Fvertical_motion): Local variable it_start is now
2568 EMACS_INT.
2569
2570 * regex.c (re_match, re_match_2, re_match_2_internal)
2571 (bcmp_translate, regcomp, regexec, print_double_string)
2572 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2573 (re_compile_pattern, re_exec): Declare arguments and local
2574 variables `size_t' and `ssize_t' and return values `regoff_t', as
2575 appropriate.
2576 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2577 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2578 <compile_stack_type>: `size' and `avail' are now `size_t'.
2579
2580 * regex.h <regoff_t>: Use ssize_t, not int.
2581 (re_search, re_search_2, re_match, re_match_2): Arguments that
2582 specify buffer/string position and length are now ssize_t and
2583 size_t. Return type is regoff_t.
2584
2585 2011-04-16 Ben Key <bkey76@gmail.com>
2586
2587 * nsfont.m: Fixed bugs in ns_get_family and
2588 ns_descriptor_to_entity that were caused by using free to
2589 deallocate memory blocks that were allocated by xmalloc (via
2590 xstrdup). This caused Emacs to crash when compiled with
2591 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2592 --enable-checking=xmallocoverrun). xfree is now used to
2593 deallocate these memory blocks.
2594
2595 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2596
2597 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2598
2599 emacs_write: Accept and return EMACS_INT for sizes.
2600 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2601 et seq.
2602 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2603 Accept and return EMACS_INT.
2604 (emacs_gnutls_write): Return the number of bytes written on
2605 partial writes.
2606 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2607 (emacs_read, emacs_write): Remove check for negative size, as the
2608 Emacs source code has been audited now.
2609 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2610 (emacs_read, emacs_write): Use it.
2611 * process.c (send_process): Adjust to the new signatures of
2612 emacs_write and emacs_gnutls_write. Do not attempt to store
2613 a byte offset into an 'int'; it might overflow.
2614 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2615
2616 * sound.c: Don't assume sizes fit in 'int'.
2617 (struct sound_device.period_size, alsa_period_size):
2618 Return EMACS_INT, not int.
2619 (struct sound_device.write, vox_write, alsa_write):
2620 Accept EMACS_INT, not int.
2621 (wav_play, au_play): Use EMACS_INT to store sizes and to
2622 record read return values.
2623
2624 2011-04-15 Ben Key <bkey76@gmail.com>
2625
2626 * keyboard.c (Qundefined): Don't declare static since it is used
2627 in nsfns.m.
2628 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2629 static since they are used in nsfont.m.
2630
2631 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2632
2633 * process.c (Qprocessp): Don't declare static.
2634 * lisp.h (Qprocessp): Declare again.
2635
2636 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2637
2638 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2639
2640 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 Improve C-level modularity by making more things 'static'.
2643
2644 Don't publish debugger-only interfaces to other modules.
2645 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2646 (verify_bytepos, count_markers): Move decls to the only modules
2647 that need them.
2648 * region-cache.h (pp_cache): Likewise.
2649 * window.h (check_all_windows): Likewise.
2650 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2651
2652 * sysdep.c (croak): Now static, if
2653 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2654 * syssignal.h (croak): Declare only if not static.
2655
2656 * alloc.c (refill_memory_reserve): Now static if
2657 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2658 * lisp.h (refill_memory_reserve): Declare only if not static.
2659
2660 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2661 Define only if USE_LUCID.
2662
2663 * xrdb.c (x_customization_string, x_rm_string): Now static.
2664
2665 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2666 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2667
2668 * xdisp.c (draw_row_with_mouse_face): Now static.
2669 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2670
2671 * window.h (check_all_windows): Mark externally visible.
2672
2673 * window.c (window_deletion_count): Now static.
2674
2675 * undo.c: Make symbols static if they're not exported.
2676 (last_undo_buffer, last_boundary_position, pending_boundary):
2677 Now static.
2678
2679 * textprop.c (interval_insert_behind_hooks): Now static.
2680 (interval_insert_in_front_hooks): Likewise.
2681
2682 * term.c: Make symbols static if they're not exported.
2683 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2684 (max_frame_lines, tty_set_terminal_modes):
2685 (tty_reset_terminal_modes, tty_turn_off_highlight):
2686 (get_tty_terminal): Now static.
2687 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2688 * termhooks.h (term_mouse_moveto): Do not declare if
2689 HAVE_WINDOW_SYSTEM.
2690 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2691 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2692
2693 * sysdep.c: Make symbols static if they're not exported.
2694 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2695 Now static.
2696 (sigprocmask_set, full_mask): Remove; unused.
2697 (wait_debugging): Mark as visible.
2698 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2699 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2700
2701 * syntax.c (syntax_temp): Define only if !__GNUC__.
2702
2703 * sound.c (current_sound_device, current_sound): Now static.
2704
2705 * search.c (searchbufs, searchbuf_head): Now static.
2706
2707 * scroll.c (scroll_cost): Remove; unused.
2708 * dispextern.h (scroll_cost): Remove decl.
2709
2710 * region-cache.h (pp_cache): Mark as externally visible.
2711
2712 * process.c: Make symbols static if they're not exported.
2713 (process_tick, update_tick, create_process, chan_process):
2714 (Vprocess_alist, proc_buffered_char, datagram_access):
2715 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2716 (deactivate_process): Mark defn as static, as well as decl.
2717 * lisp.h (create_process): Remove decl.
2718 * process.h (chan_process, Vprocess_alist): Remove decls.
2719
2720 * print.c: Make symbols static if they're not exported.
2721 (print_depth, new_backquote_output, being_printed, print_buffer):
2722 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2723 (print_interval, print_number_index, initial_stderr_stream):
2724 Now static.
2725 * lisp.h (Fprinc): Remove decl.
2726 (debug_output_compilation_hack): Mark as externally visible.
2727
2728 * sysdep.c (croak): Move decl from here to syssignal.h.
2729 * syssignal.h (croak): Put it here, so the API can be checked when
2730 'croak' is called from dissociate_if_controlling_tty.
2731
2732 * minibuf.c: Make symbols static if they're not exported.
2733 (minibuf_save_list, choose_minibuf_frame): Now static.
2734 * lisp.h (choose_minibuf_frame): Remove decl.
2735
2736 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2737
2738 * lread.c: Make symbols static if they're not exported.
2739 (read_objects, initial_obarray, oblookup_last_bucket_number):
2740 Now static.
2741 (make_symbol): Remove; unused.
2742 * lisp.h (initial_obarray, make_symbol): Remove decls.
2743
2744 * keyboard.c: Make symbols static if they're not exported.
2745 (single_kboard, recent_keys_index, total_keys, recent_keys):
2746 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2747 (this_single_command_key_start, echoing, last_auto_save):
2748 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2749 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2750 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2751 (Vlispy_mouse_stem, double_click_count):
2752 Now static.
2753 (force_auto_save_soon): Define only if SIGDANGER.
2754 (ignore_mouse_drag_p): Now static if
2755 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2756 (print_help): Remove; unused.
2757 (stop_character, last_timer_event): Mark as externally visible.
2758 * keyboard.h (ignore_mouse_drag_p): Declare only if
2759 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2760 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2761 * lisp.h (echoing): Remove decl.
2762 (force_auto_save_soon): Declare only if SIGDANGER.
2763 * xdisp.c (redisplay_window): Simplify code, to make it more
2764 obvious that ignore_mouse_drag_p is not accessed if !defined
2765 USE_GTK && !defined HAVE_NS.
2766
2767 * intervals.c: Make symbols static if they're not exported.
2768 (merge_properties_sticky, merge_interval_right, delete_interval):
2769 Now static.
2770 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2771
2772 * insdel.c: Make symbols static if they're not exported.
2773 However, leave prepare_to_modify_buffer alone. It's never
2774 called from outside this function, but that appears to be a bug.
2775 (combine_after_change_list, combine_after_change_buffer):
2776 (adjust_after_replace, signal_before_change): Now static.
2777 (adjust_after_replace_noundo): Remove; unused.
2778 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2779 (signal_before_change): Remove decls.
2780
2781 * indent.c (val_compute_motion, val_vmotion): Now static.
2782
2783 * image.c: Make symbols static if they're not exported.
2784 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2785 if USE_GTK.
2786 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2787 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2788
2789 * fringe.c (standard_bitmaps): Now static.
2790 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2791
2792 * frame.c: Make symbols static if they're not exported.
2793 (x_report_frame_params, make_terminal_frame): Now static.
2794 (get_frame_param): Now static, unless HAVE_NS.
2795 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2796 (x_get_resource_string): Remove; not used.
2797 * frame.h (make_terminal_frame, x_report_frame_params):
2798 (x_get_resource_string); Remove decls.
2799 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2800 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2801
2802 * font.c, fontset.c: Make symbols static if they're not exported.
2803 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2804 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2805 * font.c (font_close_object): Now static.
2806 * font.h (font_close_object): Remove.
2807 * fontset.c (FONTSET_OBJLIST): Remove.
2808 (free_realized_fontset) #if-0 the body, which does nothing.
2809 (face_suitable_for_char_p): #if-0, as it's never called.
2810 * fontset.h (face_suitable_for_char_p): Remove decl.
2811 * xfaces.c (face_at_string_position):
2812 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2813 since 0 is always ASCII.
2814
2815 * fns.c (weak_hash_tables): Now static.
2816
2817 * fileio.c: Make symbols static if they're not exported.
2818 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2819 (Vwrite_region_annotation_buffers): Now static.
2820
2821 * eval.c: Make symbols static if they're not exported.
2822 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2823 * lisp.h (backtrace_list): Remove decl.
2824
2825 * emacs.c: Make symbols static if they're not exported.
2826 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2827 (fatal_error_code, fatal_error_signal_hook, standard_args):
2828 Now static.
2829 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2830 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2831 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2832 * lisp.h (fatal_error_signal_hook): Remove decl.
2833 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2834
2835 * editfns.c: Move a (normally-unused) function to its only use.
2836 * editfns.c, lisp.h (get_operating_system_release): Remove.
2837 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2838 worth the hassle of breaking this out.
2839
2840 * xterm.c: Make symbols static if they're not exported.
2841 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2842 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2843 (x_destroy_window, x_delete_display):
2844 Now static.
2845 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2846 (x_mouse_leave): Remove; unused.
2847 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2848 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2849 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2850 Remove decls.
2851 (x_mouse_leave): Declare only if WINDOWSNT.
2852 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2853 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2854 USE_X_TOOLKIT.
2855
2856 * ftxfont.c: Make symbols static if they're not exported.
2857 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2858 HAVE_FREETYPE.
2859 * font.h (ftxfont_driver): Likewise.
2860
2861 * xfns.c: Make symbols static if they're not exported.
2862 (x_last_font_name, x_display_info_for_name):
2863 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2864 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2865 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2866 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2867 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2868 (last_show_tip_args): Now static.
2869 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2870 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2871 (x_screen_planes): Remove; unused.
2872 * dispextern.h (x_screen_planes): Remove decl.
2873
2874 * dispnew.c: Make symbols static if they're not exported.
2875 * dispextern.h (redraw_garbaged_frames, scrolling):
2876 (increment_row_positions): Remove.
2877 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2878 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2879 Now static.
2880 (redraw_garbaged_frames): Remove; unused.
2881
2882 * xfaces.c: Make symbols static if they're not exported.
2883 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2884 Remove decls.
2885 * xterm.h (defined_color): Remove decls.
2886 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2887 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2888 (menu_face_changed_default, defined_color, free_realized_face):
2889 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2890 (ascii_face_of_lisp_face): Remove; unused.
2891
2892 * xdisp.c: Make symbols static if they're not exported.
2893 * dispextern.h (scratch_glyph_row, window_box_edges):
2894 (glyph_to_pixel_coords, set_cursor_from_row):
2895 (get_next_display_element, set_iterator_to_next):
2896 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2897 (show_mouse_face): Remove decls
2898 * frame.h (message_buf_print): Likewise.
2899 * lisp.h (pop_message, set_message, check_point_in_composition):
2900 Likewise.
2901 * xterm.h (set_vertical_scroll_bar): Likewise.
2902 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2903 (message_buf_print, scratch_glyph_row, displayed_buffer):
2904 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2905 (get_next_display_element, show_mouse_face, window_box_edges):
2906 (frame_to_window_pixel_xy, check_point_in_composition):
2907 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2908 (glyph_to_pixel_coords): Remove; unused.
2909
2910 * dired.c (file_name_completion): Now static.
2911
2912 * dbusbind.c (xd_in_read_queued_messages): Now static.
2913
2914 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2915 * data.c (circular_list_error): Remove.
2916
2917 * commands.h (last_point_position, last_point_position_buffer):
2918 (last_point_position_window): Remove decls.
2919 * keyboard.c: Make these variables static.
2920
2921 * coding.h (coding, code_convert_region, encode_coding_gap):
2922 Remove decls.
2923 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2924 (iso_code_class, detect_coding, code_convert_region): Now static.
2925 (encode_coding_gap): Remove; unused.
2926
2927 * chartab.c (chartab_chars, chartab_bits): Now static.
2928
2929 * charset.h (charset_iso_8859_1): Remove decl.
2930 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2931 Now static.
2932
2933 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2934 * ccl.c (Vccl_program_table): Now static.
2935 (check_ccl_update): Remove; unused.
2936
2937 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2938 * category.h: ... from here.
2939 * category.c (check_category_table, set_category_set): Now static.
2940
2941 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2942 * lisp.h: Remove these decls.
2943
2944 * buffer.c (buffer_count): Remove unused var.
2945
2946 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2947 so that it's not optimized away.
2948 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2949 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2950 exported only to the debugger.
2951
2952 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2953 * atimer.h (run_all_atimers): Remove; not exported.
2954
2955 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2956 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2957 was inaccessible from Lisp.
2958 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2959 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2960
2961 alloc.c: Import and export fewer symbols, and remove unused items.
2962 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2963 is defined.
2964 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2965 it's not optimized away by whole-program optimization.
2966 (message_enable_multibyte, free_misc): Remove.
2967 (catchlist, handlerlist, mark_backtrace):
2968 Declare only if BYTE_MARK_STACK.
2969 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2970 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2971 (message_enable_multibyte): Remove decl.
2972 (free_misc, interval_free_list, float_block, float_block_index):
2973 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2974 (cons_free_list, last_marked_index):
2975 Now static.
2976 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2977 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2978 (mark_backtrace): Define only if BYTE_MARK_STACK.
2979 * xdisp.c (message_enable_multibyte): Now static.
2980
2981 Declare Lisp_Object Q* variables to be 'static' if not exported.
2982 This makes it easier for human readers (and static analyzers)
2983 to see whether these variables are used from other modules.
2984 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2985 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2986 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2987 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2988 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2989 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2990 * xmenu.c, xselect.c:
2991 Declare Q* vars static if they are not used in other modules.
2992 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2993 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2994 Remove decls of unexported vars.
2995 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2996
2997 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2998
2999 Make Emacs functions such as Fatom 'static' by default.
3000 This makes it easier for human readers (and static analyzers)
3001 to see whether these functions can be called from other modules.
3002 DEFUN now defines a static function. To make the function external
3003 so that it can be used in other C modules, use the new macro DEFUE.
3004 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3005 (Finit_image_library):
3006 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3007 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3008 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3009 Remove decls, since these functions are now static.
3010 (Funintern, Fget_internal_run_time): New decls, since these functions
3011 were already external.
3012
3013 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3014 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3015 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3016 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3017 * keyboard.c, keymap.c, lread.c:
3018 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3019 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3020 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3021 Mark functions with DEFUE instead of DEFUN,
3022 if they are used in other modules.
3023 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3024 decls for now-static functions.
3025 * buffer.h (Fdelete_overlay): Remove decl.
3026 * callproc.c (Fgetenv_internal): Mark as internal.
3027 * composite.c (Fremove_list_of_text_properties): Remove decl.
3028 (Fcomposition_get_gstring): New forward static decl.
3029 * composite.h (Fcomposite_get_gstring): Remove decl.
3030 * dired.c (Ffile_attributes): New forward static decl.
3031 * doc.c (Fdocumntation_property): New forward static decl.
3032 * eval.c (Ffetch_bytecode): New forward static decl.
3033 (Funintern): Remove extern decl; now in .h file where it belongs.
3034 * fileio.c (Fmake_symbolic_link): New forward static decl.
3035 * image.c (Finit_image_library): New forward static decl.
3036 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3037 * intervals.h (Fprevious_property_change):
3038 (Fremove_list_of_text_properties): Remove decls.
3039 * keyboard.c (Fthis_command_keys): Remove decl.
3040 (Fcommand_execute): New forward static decl.
3041 * keymap.c (Flookup_key): New forward static decl.
3042 (Fcopy_keymap): Now static.
3043 * keymap.h (Flookup_key): Remove decl.
3044 * process.c (Fget_process): New forward static decl.
3045 (Fprocess_datagram_address): Mark as internal.
3046 * syntax.c (Fsyntax_table_p): New forward static decl.
3047 (skip_chars): Remove duplicate decl.
3048 * textprop.c (Fprevious_property_change): New forward static decl.
3049 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3050 Now internal.
3051 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3052 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3053
3054 * editfns.c (Fformat): Remove unreachable code.
3055
3056 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3057
3058 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3059 change. (Bug#8496)
3060
3061 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3062
3063 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3064 when at ZV. (Bug#8487)
3065
3066 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3067
3068 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3069 (Bug#8437)
3070 * keyboard.c (parse_tool_bar_item): Likewise.
3071 * sound.c (sound_cleanup, alsa_close): Likewise.
3072 * termcap.c (tgetent): Likewise.
3073 * xfns.c (x_default_font_parameter): Likewise.
3074 * xsettings.c (read_and_apply_settings): Likewise.
3075
3076 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3077 (overrun_check_free): Protoize.
3078
3079 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3082 since callers should never pass a negative size.
3083 Change the signature to match that of plain 'read' and 'write'; see
3084 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3085 * lisp.h: Update prototypes of emacs_write and emacs_read.
3086
3087 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3088
3089 * xdisp.c (redisplay_window): Don't try to determine the character
3090 position of the scroll margin if the window start point w->startp
3091 is outside the buffer's accessible region. (Bug#8468)
3092
3093 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3094
3095 Fix write-region and its subroutines for buffers > 2GB.
3096 * fileio.c (a_write, e_write): Modify declaration of arguments and
3097 local variables to support buffers larger than 2GB.
3098 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3099
3100 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3101 argument, local variables, and return value.
3102
3103 * lisp.h: Update prototypes of emacs_write and emacs_read.
3104
3105 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3106
3107 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3110
3111 Fix more problems found by GCC 4.6.0's static checks.
3112
3113 * xdisp.c (vmessage): Use a better test for character truncation.
3114
3115 * charset.c (load_charset_map): <, not <=, for optimization,
3116 and to avoid potential problems with integer overflow.
3117 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3118 * casetab.c (set_identity, shuffle): Likewise.
3119 * editfns.c (Fformat): Likewise.
3120 * syntax.c (skip_chars): Likewise.
3121
3122 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3123 This also lets GCC 4.6.0 generate slightly better loop code.
3124
3125 * callint.c (Fcall_interactively): <, not <=, for optimization.
3126 (Fcall_interactively): Count the number of arguments produced,
3127 not the number of arguments given. This is simpler and lets GCC
3128 4.6.0 generate slightly better code.
3129
3130 * ftfont.c: Distingish more carefully between FcChar8 and char.
3131 The previous code passed unsigned char * to a functions like
3132 strlen and xstrcasecmp that expect char *, which does not
3133 conform to the C standard.
3134 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3135 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3136 char * when the C standard requires it.
3137
3138 * keyboard.c (read_char): Remove unused var.
3139
3140 * eval.c: Port to Windows vsnprintf (Bug#8435).
3141 Include <limits.h>.
3142 (SIZE_MAX): Define if the headers do not.
3143 (verror): Do not give up if vsnprintf returns a negative count.
3144 Instead, grow the buffer. This ports to Windows vsnprintf, which
3145 does not conform to C99. Problem reported by Eli Zaretskii.
3146 Also, simplify the allocation scheme, by avoiding the need for
3147 calling realloc, and removing the ALLOCATED variable.
3148
3149 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3150
3151 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3152 But keep the doprint source code for now, as we might revamp it
3153 and use it again (Bug#8435).
3154 * lisp.h (doprnt): Remove.
3155 * Makefile.in (base_obj): Remove doprnt.o.
3156 * deps.mk (doprnt.o): Remove.
3157
3158 error: Print 32- and 64-bit integers portably (Bug#8435).
3159 Without this change, on typical 64-bit hosts error ("...%d...", N)
3160 was used to print both 32- and 64-bit integers N, which relied on
3161 undefined behavior.
3162 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3163 New macro.
3164 * lisp.h (error, verror): Mark as printf-like functions.
3165 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3166 Report overflow in size calculations when allocating printf buffer.
3167 Do not truncate output string at its first null byte.
3168 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3169 Truncate the output at a character boundary, since vsnprintf does not
3170 do that.
3171 * charset.c (check_iso_charset_parameter): Convert internal
3172 character to string before calling 'error', since %c now has the
3173 printf meaning.
3174 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3175 overflow when computing char to be passed to 'error'. Do not
3176 pass Lisp_Object to 'error'; pass the integer instead.
3177 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3178 formatted with plain %d.
3179
3180 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3181
3182 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3183
3184 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3185
3186 * xterm.c (x_catch_errors): Remove duplicate declaration.
3187
3188 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3189
3190 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3191
3192 2011-04-10 Jim Meyering <meyering@redhat.com>
3193
3194 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3195 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3196 return ssize_t not "int", and use size_t as the buffer length.
3197 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3198 * gnutls.h: Update declarations.
3199 * process.c (read_process_output): Use ssize_t, to match.
3200 (send_process): Likewise.
3201
3202 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3203
3204 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3205
3206 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3207
3208 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3209 Use unsigned char, to match FcChar8 type definition.
3210
3211 * xterm.c (handle_one_xevent):
3212 * xmenu.c (create_and_show_popup_menu):
3213 * xselect.c (x_decline_selection_request)
3214 (x_reply_selection_request): Avoid type-punned deref of X events.
3215
3216 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3217
3218 Fix some uses of `int' instead of EMACS_INT.
3219 * search.c (string_match_1, fast_string_match)
3220 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3221 (scan_buffer, find_next_newline_no_quit)
3222 (find_before_next_newline, search_command, Freplace_match)
3223 (Fmatch_data): Make some `int' variables be EMACS_INT.
3224
3225 * xdisp.c (display_count_lines): 3rd argument and return value now
3226 EMACS_INT. All callers changed.
3227 (pint2hrstr): Last argument is now EMACS_INT.
3228
3229 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3230 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3231 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3232 (decode_coding_utf_16, decode_coding_emacs_mule)
3233 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3234 (decode_coding_ccl, decode_coding_charset)
3235 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3236 (decode_coding_iso_2022, decode_coding_emacs_mule)
3237 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3238 <char_offset, last_offset>: Declare EMACS_INT.
3239 (encode_coding_utf_8, encode_coding_utf_16)
3240 (encode_coding_emacs_mule, encode_invocation_designation)
3241 (encode_designation_at_bol, encode_coding_iso_2022)
3242 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3243 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3244 Declare EMACS_INT.
3245 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3246 (encode_invocation_designation): Last argument P_NCHARS is now
3247 EMACS_INT.
3248 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3249 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3250
3251 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3252 All users changed.
3253
3254 * ccl.c (Fccl_execute_on_string): Declare some variables
3255 EMACS_INT.
3256
3257 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3258
3259 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3260
3261 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3262
3263 * process.c (Fformat_network_address): Doc fix.
3264
3265 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3266
3267 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3268
3269 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3270
3271 * keyboard.c (read_char): Call Lisp function help-form-show,
3272 instead of using internal_with_output_to_temp_buffer.
3273 (Qhelp_form_show): New var.
3274 (syms_of_keyboard): Use DEFSYM macro.
3275
3276 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3277
3278 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3279
3280 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3281
3282 * process.c (Flist_processes): Remove to Lisp.
3283 (list_processes_1): Delete.
3284
3285 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3286
3287 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3288
3289 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3290
3291 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3292
3293 Fix more problems found by GCC 4.6.0's static checks.
3294
3295 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3296
3297 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3298
3299 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3300
3301 * xdisp.c (vmessage): Mark as a printf-like function.
3302
3303 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3304
3305 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3306
3307 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3308 printf-like functions.
3309 (tiff_load): Add casts to remove these marks before passing them
3310 to system-supplied API.
3311
3312 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3313
3314 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3315 This avoids several warnings with gcc -Wstrict-overflow.
3316 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3317 directly, rather than having caller test rule sign. This avoids
3318 some unnecessary tests.
3319 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3320 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3321 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3322
3323 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3324 (xfont_open): Avoid unnecessary tests.
3325
3326 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3327
3328 * composite.h, composite.c (composition_gstring_put_cache):
3329 Use EMACS_INT, not int, for length.
3330
3331 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3332 breaking out part of COMPOSITION_DECODE_RULE.
3333 (COMPOSITION_DECODE_RULE): Use it.
3334 * composite.c (get_composition_id): Remove unused local vars,
3335 by using the new macro.
3336
3337 * textprop.c (set_text_properties_1): Change while to do-while,
3338 since the condition is always true at first.
3339
3340 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3341 (interval_deletion_adjustment): Return unsigned value.
3342 All uses changed.
3343
3344 * process.c (list_processes_1, create_pty, read_process_output):
3345 (exec_sentinel): Remove vars that were set but not used.
3346 (create_pty): Remove unnecessary "volatile"s.
3347 (Fnetwork_interface_info): Avoid possibility of int overflow.
3348 (read_process_output): Do adaptive read buffering even if carryover.
3349 (read_process_output): Simplify nbytes computation if buffered.
3350
3351 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3352
3353 * syntax.c (scan_words): Remove var that was set but not used.
3354 (update_syntax_table): Use unsigned instead of int.
3355
3356 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3357 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3358 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3359
3360 * print.c (print_error_message): Avoid int overflow.
3361
3362 * font.c (font_list_entities): Redo for clarity,
3363 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3364
3365 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3366 (font_score): Avoid potential overflow in diff calculation.
3367
3368 * fns.c (substring_both): Remove var that is set but not used.
3369 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3370
3371 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3372
3373 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3374 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3375 can always succeed if overflow has undefined behavior.
3376
3377 * search.c (boyer_moore, wordify): Remove vars set but not used.
3378 (wordify): Omit three unnecessary tests.
3379
3380 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3381 All callers changed. This avoids the need for an unused var.
3382
3383 * casefiddle.c (casify_region): Remove var that is set but not used.
3384
3385 * dired.c (file_name_completion): Remove var that is set but not used.
3386
3387 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3388
3389 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3390 (Finsert_file_contents): Remove unnecessary code checking fd.
3391
3392 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3393 Check for integer overflow on size calculations.
3394
3395 * buffer.c (Fprevious_overlay_change): Remove var that is set
3396 but not used.
3397
3398 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3399 Remove vars that are set but not used.
3400 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3401 (timer_check_2): Mark vars as initialized.
3402
3403 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3404
3405 * image.c (lookup_image): Remove var that is set but not used.
3406 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3407
3408 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3409 that are set but not used.
3410
3411 * xfns.c (make_invisible_cursor): Don't return garbage
3412 if XCreateBitmapFromData fails (Bug#8410).
3413
3414 * xselect.c (x_get_local_selection, x_handle_property_notify):
3415 Remove vars that are set but not used.
3416
3417 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3418 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3419
3420 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3421 Remove var that is set but not used.
3422 (scroll_bar_windows_size): Now size_t, not int.
3423 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3424 Check for overflow.
3425
3426 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3427 (map_tty_color) [!defined MSDOS]: Likewise.
3428
3429 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3430
3431 * coding.c: Remove vars that are set but not used.
3432 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3433 All callers changed.
3434 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3435 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3436 (decode_coding_charset): Remove vars that are set but not used.
3437
3438 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3439 that is set but not used.
3440
3441 * print.c (print_object): Remove var that is set but not used.
3442
3443 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3444 The gnulib version avoids calling malloc in the usual case,
3445 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3446 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3447 * filelock.c (current_lock_owner): Likewise.
3448 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3449 * sysdep.c: Include allocator.h, careadlinkat.h.
3450 (emacs_no_realloc_allocator): New static constant.
3451 (emacs_readlink): New function.
3452 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3453 ../lib/careadlinkat.h.
3454
3455 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3456
3457 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3458 first non-nil return value).
3459
3460 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3461
3462 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3463 if not defined (Bug#8403).
3464
3465 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3466
3467 * xdisp.c (display_count_lines): Remove parameter `start',
3468 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3469 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3470 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3471 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3472 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3473 and thereabouts. All callers changed.
3474 (get_per_char_metric): Remove parameter `f', unused since
3475 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3476
3477 2011-04-02 Jim Meyering <meyering@redhat.com>
3478
3479 do not dereference NULL upon failed strdup
3480 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3481 (ns_get_family): Likewise.
3482
3483 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3484
3485 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3486
3487 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3488
3489 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3490 later (Bug#8403).
3491
3492 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3493
3494 Add lexical binding.
3495
3496 * window.c (Ftemp_output_buffer_show): New fun.
3497 (Fsave_window_excursion):
3498 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3499
3500 * lread.c (lisp_file_lexically_bound_p): New function.
3501 (Fload): Bind Qlexical_binding.
3502 (readevalloop): Remove `evalfun' arg.
3503 Bind Qinternal_interpreter_environment.
3504 (Feval_buffer): Bind Qlexical_binding.
3505 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3506 Mark as dynamic.
3507 (syms_of_lread): Declare `lexical-binding'.
3508
3509 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3510
3511 * keyboard.c (eval_dyn): New fun.
3512 (menu_item_eval_property): Use it.
3513
3514 * image.c (parse_image_spec): Use Ffunctionp.
3515
3516 * fns.c (concat, mapcar1): Accept byte-code-functions.
3517
3518 * eval.c (Fsetq): Handle lexical vars.
3519 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3520 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3521 (FletX, Flet): Obey lexical binding.
3522 (Fcommandp): Handle closures.
3523 (Feval): New `lexical' arg.
3524 (eval_sub): New function extracted from Feval. Use it almost
3525 everywhere where Feval was used. Look up vars in lexical env.
3526 Handle closures.
3527 (Ffunctionp): Move from subr.el.
3528 (Ffuncall): Handle closures.
3529 (apply_lambda): Remove `eval_flags'.
3530 (funcall_lambda): Handle closures and new byte-code-functions.
3531 (Fspecial_variable_p): New function.
3532 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3533 but without exporting it to Lisp.
3534
3535 * doc.c (Fdocumentation, store_function_docstring):
3536 * data.c (Finteractive_form): Handle closures.
3537
3538 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3539 interactive spec.
3540
3541 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3542 New byte-codes.
3543 (exec_byte_code): New function extracted from Fbyte_code to handle new
3544 calling convention for byte-code-functions. Add new byte-codes.
3545
3546 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3547
3548 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3549
3550 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3551
3552 * xdisp.c (redisplay_internal): Fix prototype.
3553
3554 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3555
3556 * xdisp.c (SCROLL_LIMIT): New macro.
3557 (try_scrolling): Use it when setting scroll_limit.
3558 Limit scrolling to 100 screen lines.
3559 (redisplay_window): Even when falling back on "recentering",
3560 position point in the window according to scroll-conservatively,
3561 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3562
3563 (try_scrolling): When point is above the window, allow searching
3564 as far as scroll_max, or one screenful, to compute vertical
3565 distance from PT to the scroll margin position. This prevents
3566 try_scrolling from unnecessarily failing when
3567 scroll-conservatively is set to a value slightly larger than the
3568 window height. Clean up the case of PT below the margin at bottom
3569 of window: scroll_max can no longer be INT_MAX. When aggressive
3570 scrolling is in use, don't let point enter the opposite scroll
3571 margin as result of the scroll.
3572 (syms_of_xdisp) <scroll-conservatively>: Document the
3573 threshold of 100 lines for never-recentering scrolling.
3574
3575 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3576
3577 * dispextern.h (move_it_by_lines):
3578 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3579 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3580 (message_log_check_duplicate): Remove parameters `prev_bol' and
3581 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3582 (redisplay_internal): Remove parameter `preserve_echo_area',
3583 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3584
3585 * indent.c (Fvertical_motion):
3586 * window.c (window_scroll_pixel_based, Frecenter):
3587 Don't pass `need_y_p' to `move_it_by_lines'.
3588
3589 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3592 steal a few bits to be more compact.
3593 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3594 Remove unneeded casts.
3595
3596 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3597
3598 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3599
3600 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3601 binding" message (bug#7967).
3602
3603 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 Fix more problems found by GCC 4.6.0's static checks.
3606
3607 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3608 Remove unused local var.
3609
3610 * editfns.c (Fmessage_box): Remove unused local var.
3611
3612 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3613 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3614 Omit unused local vars.
3615 * window.c (shrink_windows): Omit unused local var.
3616 * menu.c (digest_single_submenu): Omit unused local var.
3617 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3618 Omit unused local var.
3619
3620 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3621 Don't assume string length fits in int.
3622 (keyremap_step, read_key_sequence): Use size_t for sizes.
3623 (read_key_sequence): Don't check last_real_key_start redundantly.
3624
3625 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3626 instead of alloca (Bug#8344).
3627
3628 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3629 (Fbacktrace_frame): Don't assume nframes fits in int.
3630
3631 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3632
3633 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3634 concerns.
3635
3636 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3637
3638 * cm.c (calccost): Turn while-do into do-while, for clarity.
3639
3640 * keyboard.c (syms_of_keyboard): Use the same style as later
3641 in this function when indexing through an array. This also
3642 works around GCC bug 48267.
3643
3644 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3645
3646 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3647
3648 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3649 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3650
3651 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3652 This avoids undefined behavior on integer overflow, and is a bit
3653 more convenient anyway since it is compared to a size_t variable.
3654
3655 Variadic C functions now count arguments with size_t, not int.
3656 This avoids an unnecessary limitation on 64-bit machines, which
3657 caused (substring ...) to crash on large vectors (Bug#8344).
3658 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3659 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3660 All variadic functions and their callers changed accordingly.
3661 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3662 * data.c (arith_driver, float_arith_driver): Likewise.
3663 * editfns.c (general_insert_function): Likewise.
3664 * eval.c (struct backtrace.nargs, interactive_p)
3665 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3666 (funcall_lambda, mark_backtrace): Likewise.
3667 * fns.c (concat): Likewise.
3668 * frame.c (x_set_frame_parameters): Likewise.
3669 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3670 0 if not found, not -1. All callers changed.
3671
3672 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3673 (stack_copy_size): Now size_t, not int.
3674 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3675
3676 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3679 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3680 All callers changed.
3681
3682 * lisp.h (multibyte_char_to_unibyte):
3683 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3684 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3685 * character.h (CHAR_TO_BYTE8):
3686 * cmds.c (internal_self_insert):
3687 * editfns.c (general_insert_function):
3688 * keymap.c (push_key_description):
3689 * search.c (Freplace_match):
3690 * xdisp.c (message_dolog, set_message_1): All callers changed.
3691
3692 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3693
3694 * keyboard.c (safe_run_hook_funcall): New function.
3695 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3696 don't set the hook to nil, but remove the offending function instead.
3697 (Qcommand_hook_internal): Remove, unused.
3698 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3699 Vcommand_hook_internal.
3700
3701 * eval.c (enum run_hooks_condition): Remove.
3702 (funcall_nil, funcall_not): New functions.
3703 (run_hook_with_args): Call each function through a `funcall' argument.
3704 Remove `cond' argument, now redundant.
3705 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3706 (Frun_hook_with_args_until_failure): Adjust accordingly.
3707 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3708
3709 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3710
3711 * dispextern.h (string_buffer_position): Remove declaration.
3712
3713 * print.c (strout): Remove parameter `multibyte', unused since
3714 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3715
3716 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3717 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3718 All callers changed.
3719
3720 * w32.c (_wsa_errlist): Use braces for struct initializers.
3721
3722 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3723 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3724 All callers changed.
3725 (string_buffer_position): Likewise. Also, make static (it's never
3726 used outside xdisp.c).
3727 (cursor_row_p): Remove parameter `w', unused since
3728 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3729 (decode_mode_spec): Remove parameter `precision', introduced during
3730 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3731 All callers changed.
3732
3733 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3736
3737 2011-03-27 Anders Lindgren <andlind@gmail.com>
3738
3739 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3740 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3741 (ns_update_auto_hide_menu_bar): New functions.
3742 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3743 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3744 ns_constrain_all_frames.
3745 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3746 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3747
3748 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3749
3750 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3751
3752 2011-03-27 Glenn Morris <rgm@gnu.org>
3753
3754 * syssignal.h: Replace RETSIGTYPE with void.
3755 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3756 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3757 Replace SIGTYPE with void everywhere.
3758 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3759 * s/template.h (SIGTYPE): Remove commented out definition.
3760
3761 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3762
3763 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3764 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3765
3766 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3767
3768 * w32.c (read_unc_volume): Use parameter `henum', instead of
3769 global variable `wget_enum_handle'.
3770
3771 * keymap.c (describe_vector): Remove parameters `indices' and
3772 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3773 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3774
3775 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3776
3777 * keyboard.c (timer_check): Remove parameter `do_it_now',
3778 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3779 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3780 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3781
3782 * keyboard.c (read_char):
3783 * w32menu.c (w32_menu_display_help):
3784 * xmenu.c (show_help_event, menu_help_callback):
3785 Adjust calls to `show_help_echo'.
3786
3787 * gtkutil.c (xg_maybe_add_timer):
3788 * keyboard.c (readable_events):
3789 * process.c (wait_reading_process_output):
3790 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3791
3792 * insdel.c (adjust_markers_gap_motion):
3793 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3794 (gap_left, gap_right): Don't call it.
3795
3796 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3797
3798 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3799 incurred during fontification.
3800
3801 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3802
3803 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3804 (DEFVAR_PER_BUFFER): Don't pass it.
3805
3806 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3807 (scrolling_window): Don't pass it.
3808
3809 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3810
3811 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3812
3813 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3814 and `suffix'.
3815 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3816 of variables specific to SELinux and computation of `encoded_absname'.
3817
3818 * image.c (XPutPixel): Remove unused variable `height'.
3819
3820 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3821
3822 * unexw32.c (get_section_info): Remove unused variable `section'.
3823
3824 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3825 (system_process_attributes): Remove unused variable `sess'.
3826 (sys_read): Remove unused variable `err'.
3827
3828 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3829 (w32_wnd_proc): Remove unused variable `isdead'.
3830 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3831 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3832 (x_create_tip_frame): Remove unused variable `tem'.
3833
3834 * w32inevt.c (w32_console_read_socket):
3835 Remove unused variable `no_events'.
3836
3837 * w32term.c (x_draw_composite_glyph_string_foreground):
3838 Remove unused variable `width'.
3839
3840 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * w32term.c (x_set_glyph_string_clipping):
3843 Don't pass uninitialized region to CombineRgn.
3844
3845 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3846
3847 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3848 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3849 (Fx_close_connection): Remove unused variable `i'.
3850
3851 * w32font.c (w32font_draw): Return number of glyphs.
3852 (w32font_open_internal): Remove unused variable `i'.
3853 (w32font_driver): Add missing initializer.
3854
3855 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3856 (fill_in_menu): Remove unused variable `items_added'.
3857
3858 * w32term.c (last_mouse_press_frame): Remove static global variable.
3859 (w32_clip_to_row): Remove unused variable `f'.
3860 (x_delete_terminal): Remove unused variable `i'.
3861
3862 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3863 (NOTHING): Remove unused static global variable.
3864 (uniscribe_check_otf): Remove unused variable `table'.
3865 (uniscribe_font_driver): Add missing initializers.
3866
3867 2011-03-23 Julien Danjou <julien@danjou.info>
3868
3869 * term.c (Fsuspend_tty, Fresume_tty):
3870 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3871 * window.c (temp_output_buffer_show):
3872 * insdel.c (signal_before_change):
3873 * frame.c (Fhandle_switch_frame):
3874 * fileio.c (Fdo_auto_save):
3875 * emacs.c (Fkill_emacs):
3876 * editfns.c (save_excursion_restore):
3877 * cmds.c (internal_self_insert):
3878 * callint.c (Fcall_interactively):
3879 * buffer.c (Fkill_all_local_variables):
3880 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3881 Use Frun_hooks.
3882 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3883 unconditionnaly since it does the check itself.
3884
3885 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3886
3887 Fix more problems found by GCC 4.5.2's static checks.
3888
3889 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3890 the first time through the loop, since we know p0 < p1 then.
3891 This also avoids a gcc -Wstrict-overflow warning.
3892
3893 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3894 leading to a memory leak, possible in functions like
3895 load_charset_map_from_file that can allocate an unbounded number
3896 of objects (Bug#8318).
3897
3898 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3899 that could (at least in theory) be that large.
3900
3901 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3902 This is less likely to overflow, and avoids undefined behavior if
3903 overflow does occur. All callers changed. Use strtoul to scan
3904 for the unsigned long integer.
3905 (pint2hrstr): Simplify and tune code slightly.
3906 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3907
3908 * scroll.c (do_scrolling): Work around GCC bug 48228.
3909 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3910
3911 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3912 This also avoids a warning with gcc -Wstrict-overflow.
3913 (validate_x_resource_name): Simplify count usage.
3914 This also avoids a warning with gcc -Wstrict-overflow.
3915
3916 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3917 fail (Bug#8306).
3918
3919 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3920
3921 * process.c (Fmake_network_process): Use socklen_t, not int,
3922 where POSIX says socklen_t is required in portable programs.
3923 This fixes a porting bug on hosts like 64-bit HP-UX, where
3924 socklen_t is wider than int (Bug#8277).
3925 (Fmake_network_process, server_accept_connection):
3926 (wait_reading_process_output, read_process_output):
3927 Likewise.
3928
3929 * process.c: Rename or move locals to avoid shadowing.
3930 (list_processes_1, Fmake_network_process):
3931 (read_process_output_error_handler, exec_sentinel_error_handler):
3932 Rename or move locals.
3933 (Fmake_network_process): Define label "retry_connect" only if needed.
3934 (Fnetwork_interface_info): Fix pointer signedness.
3935 (process_send_signal): Add cast to avoid pointer signedness problem.
3936 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3937 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3938
3939 Make tparam.h and terminfo.c consistent.
3940 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3941 Include tparam.h instead, since it declares them.
3942 * cm.h (PC): Remove extern decl; tparam.h now does this.
3943 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3944 * terminfo.c: Include tparam.h, to check interfaces.
3945 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3946 (tparam): Adjust signature to match interface in tparam.h;
3947 this removes some undefined behavior. Check that outstring and len
3948 are zero, which they always are with Emacs.
3949 * tparam.h (PC, BC, UP): New extern decls.
3950
3951 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3952 (xftfont_open): Rename locals to avoid shadowing.
3953
3954 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3955 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3956 (OTF_TAG_SYM): Omit macro if not needed.
3957 (ftfont_list): Remove unused local.
3958 (get_adstyle_property, ftfont_pattern_entity):
3959 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3960 Rename locals to avoid shadowing.
3961
3962 * xfont.c (xfont_list_family): Mark var as initialized.
3963
3964 * xml.c (make_dom): Now static.
3965
3966 * composite.c (composition_compute_stop_pos): Rename local to
3967 avoid shadowing.
3968 (composition_reseat_it): Remove unused locals.
3969 (find_automatic_composition, composition_adjust_point): Likewise.
3970 (composition_update_it): Mark var as initialized.
3971 (find_automatic_composition): Mark vars as initialized,
3972 with a FIXME (Bug#8290).
3973
3974 character.h: Rename locals to avoid shadowing.
3975 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3976 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3977 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3978 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3979 to avoid shadowing.
3980
3981 * textprop.c (property_change_between_p): Remove; unused.
3982
3983 * intervals.c (interval_start_pos): Now static.
3984
3985 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3986
3987 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3988 Rename locals to avoid shadowing.
3989
3990 * sound.c (wav_play, au_play, Fplay_sound_internal):
3991 Fix pointer signedness.
3992 (alsa_choose_format): Remove unused local var.
3993 (wav_play): Initialize a variable to 0, to prevent undefined
3994 behavior (Bug#8278).
3995
3996 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3997
3998 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3999
4000 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4001 clobbering (Bug#8298).
4002 * sysdep.c (sys_subshell): Likewise.
4003 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4004
4005 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4006 This should get cleaned up, so that child_setup has the
4007 same signature on all platforms.
4008
4009 * callproc.c (call_process_cleanup): Now static.
4010 (relocate_fd): Rename locals to avoid shadowing.
4011
4012 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4013
4014 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4015 not to be necessary, and produces flickering.
4016
4017 2011-03-20 Glenn Morris <rgm@gnu.org>
4018
4019 * config.in: Remove file.
4020
4021 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4022
4023 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4024 are now in src/globals.h.
4025 (syms_of_minibuf): Remove spurious & from previous change.
4026
4027 2011-03-20 Leo <sdl.web@gmail.com>
4028
4029 * minibuf.c (completing-read-function): New variable.
4030 (completing-read-default): Rename from completing-read.
4031 (completing-read): Call completing-read-function.
4032
4033 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4034
4035 * xfaces.c (Fx_load_color_file):
4036 Read color file from absolute filename (bug#8250).
4037
4038 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4039
4040 * makefile.w32-in: Update dependencies.
4041
4042 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4043
4044 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4045
4046 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4047
4048 Fix more problems found by GCC 4.5.2's static checks.
4049
4050 * process.c (make_serial_process_unwind, send_process_trap):
4051 (sigchld_handler): Now static.
4052
4053 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4054 That way, the code declares only the vars that it needs.
4055 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4056 * s/cygwin.h (PTY_ITERATION): Likewise.
4057 * s/darwin.h (PTY_ITERATION): Likewise.
4058 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4059
4060 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4061 * process.c (allocate_pty): Don't declare stb unless it's needed.
4062
4063 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4064 (CONSTANTLIM): Remove; unused.
4065 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4066 Define only if needed.
4067
4068 * unexelf.c (unexec): Name an expression,
4069 to avoid gcc -Wbad-function-cast warning.
4070 Use a different way to cause a compilation error if anyone uses
4071 n rather than nn, a way that does not involve shadowing.
4072 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4073
4074 * deps.mk (unexalpha.o): Remove; unused.
4075
4076 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4077 * unexec.h: New file.
4078 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4079 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4080 Depend on unexec.h.
4081 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4082 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4083 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4084 Change as necessary to match prototype in unexec.h.
4085
4086 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4087 shadowing.
4088 (back_comment, skip_chars): Mark vars as initialized.
4089
4090 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4091 Rename locals to avoid shadowing.
4092
4093 * lread.c (read1): Rewrite so as not to use empty "else".
4094 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4095
4096 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4097
4098 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4099 warning when compiling print.c.
4100
4101 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4102 instead of using an uninitialized var.
4103 (font_sort_entities): Mark var as initialized.
4104
4105 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4106
4107 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4108 pointers to constants.
4109 (font_parse_fcname): Remove unused vars.
4110 (font_delete_unmatched): Now static.
4111 (font_get_spec): Remove; unused.
4112 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4113 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4114 Rename or move locals to avoid shadowing.
4115
4116 * fns.c (require_nesting_list, require_unwind): Now static.
4117 (Ffillarray): Rename locals to avoid shadowing.
4118
4119 * floatfns.c (domain_error2): Define only if needed.
4120 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4121
4122 * alloc.c (mark_backtrace): Move decl from here ...
4123 * lisp.h: ... to here, so that it can be checked.
4124
4125 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4126 (Fdefvar): Rewrite so as not to use empty "else".
4127 (lisp_indirect_variable): Name an expression,
4128 to avoid gcc -Wbad-function-cast warning.
4129 (Fdefvar): Rename locals to avoid shadowing.
4130
4131 * callint.c (quotify_arg, quotify_args): Now static.
4132 (Fcall_interactively): Rename locals to avoid shadowing.
4133 Use const pointer when appropriate.
4134
4135 * lisp.h (get_system_name, get_operating_system_release):
4136 Move decls here, to check interfaces.
4137 * process.c (get_operating_system_release): Move decl to lisp.h.
4138 * xrdb.c (get_system_name): Likewise.
4139 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4140 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4141 some of which prompt warnings from gcc -Wbad-function-cast.
4142 (Fformat_time_string, Fencode_time, Finsert_char):
4143 (Ftranslate_region_internal, Fformat):
4144 Rename or remove local vars to avoid shadowing.
4145 (Ftranslate_region_internal): Mark var as initialized.
4146
4147 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4148 avoid shadowing.
4149
4150 * lisp.h (eassert): Check that the argument compiles, even if
4151 ENABLE_CHECKING is not defined.
4152
4153 * data.c (Findirect_variable): Name an expression, to avoid
4154 gcc -Wbad-function-cast warning.
4155 (default_value, arithcompare, arith_driver, arith_error): Now static.
4156 (store_symval_forwarding): Rename local to avoid shadowing.
4157 (Fmake_variable_buffer_local, Fmake_local_variable):
4158 Mark variables as initialized.
4159 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4160
4161 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4162 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4163 Rename locals to avoid shadowing.
4164 (mark_stack): Move local variables into the #ifdef region where
4165 they're used.
4166 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4167 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4168 needed otherwise.
4169 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4170 (GC_STRING_CHARS): Remove; not used.
4171 (Fmemory_limit): Cast sbrk's returned value to char *.
4172
4173 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4174 avoids undefined behavior in theory.
4175
4176 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4177
4178 Use functions, not macros, for up- and down-casing (Bug#8254).
4179 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4180 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4181 to use the following functions instead of these macros.
4182 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4183 EMACS_INT, since callers assume the returned value fits in int.
4184 (upcase1): Likewise, for UPCASE_TABLE.
4185 (uppercasep, lowercasep, upcase): New static inline functions.
4186 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4187 the race-condition problem in the old DOWNCASE.
4188
4189 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4190 Rename locals to avoid shadowing.
4191 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4192 (regex_compile, re_search_2, re_match_2_internal):
4193 Remove unused local vars.
4194 (FREE_VAR): Rewrite so as not to use empty "else",
4195 which gcc can warn about.
4196 (regex_compile, re_match_2_internal): Mark locals as initialized.
4197 (RETALLOC_IF): Define only if needed.
4198 (WORDCHAR_P): Likewise. This one is never needed, but is used
4199 only in a comment talking about a compiler bug, so put inside
4200 the #if 0 of that comment.
4201 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4202 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4203 Remove; unused.
4204
4205 * search.c (boyer_moore): Rename locals to avoid shadowing.
4206 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4207 (PREV_CHAR_BOUNDARY): Likewise.
4208
4209 * search.c (simple_search): Remove unused var.
4210
4211 * dired.c (compile_pattern): Move decl from here ...
4212 * lisp.h: ... to here, so that it can be checked.
4213 (struct re_registers): New forward decl.
4214
4215 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4216
4217 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4218 All uses changed.
4219 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4220 Rename locals to avoid shadowing.
4221 (Fvertical_motion): Mark locals as initialized.
4222
4223 * casefiddle.c (casify_object, casify_region): Now static.
4224 (casify_region): Mark local as initialized.
4225
4226 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4227
4228 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4229 New macros, so that the caller can use some names other than
4230 gcpro1, gcpro2, etc.
4231 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4232 of the new macros.
4233 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4234 argument, for consistency with GCPRO2_VAR, etc: it is now the
4235 prefix of the variable, not the variable itself. All uses
4236 changed.
4237 * dired.c (directory_files_internal, file_name_completion):
4238 Rename locals to avoid shadowing.
4239
4240 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4241 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4242 dired.c's scmp function, had undefined behavior.
4243 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4244 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4245 * buffer.h: ... to here, because these macros use current_buffer,
4246 and the new implementation with inline functions needs to have
4247 current_buffer in scope now, rather than later when the macros
4248 are used.
4249 (downcase, upcase1): New static inline functions.
4250 (DOWNCASE, UPCASE1): Reimplement using these functions.
4251 This avoids undefined behavior in expressions like
4252 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4253 from race conditions in accessing the global variables
4254 case_temp1 and case_temp2.
4255 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4256 * lisp.h (case_temp1, case_temp2): Remove their decls.
4257 * character.h (ASCII_CHAR_P): Move from here ...
4258 * lisp.h: ... to here, so that the inline functions mentioned
4259 above can use them.
4260
4261 * dired.c (directory_files_internal_unwind): Now static.
4262
4263 * fileio.c (file_name_as_directory, directory_file_name):
4264 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4265 Now static.
4266 (file_name_as_directory): Use const pointers when appropriate.
4267 (Fexpand_file_name): Likewise. In particular, newdir might
4268 point at constant storage, so make it a const pointer.
4269 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4270 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4271 signedness issues.
4272 (Fset_file_times, Finsert_file_contents, auto_save_error):
4273 Rename locals to avoid shadowing.
4274
4275 * minibuf.c (choose_minibuf_frame_1): Now static.
4276 (Ftry_completion, Fall_completions): Rename or remove locals
4277 to avoid shadowing.
4278
4279 * marker.c (bytepos_to_charpos): Remove; unused.
4280
4281 * lisp.h (verify_bytepos, count_markers): New decls,
4282 so that gcc does not warn that these functions aren't declared.
4283
4284 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4285 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4286 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4287 (copy_text): Remove unused local var.
4288
4289 * filelock.c (within_one_second): Now static.
4290 (lock_file_1): Rename local to avoid shadowing.
4291
4292 * buffer.c (fix_overlays_before): Mark locals as initialized.
4293 (fix_start_end_in_overlays): Likewise. This function should be
4294 simplified by using pointers-to-pointers, but that's a different
4295 matter.
4296 (switch_to_buffer_1): Now static.
4297 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4298 (report_overlay_modification): Rename locals to avoid shadowing.
4299
4300 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4301 Fix pointer signedness issue.
4302 (sys_subshell): Mark local as volatile if checking for lint,
4303 to suppress a gcc -Wclobbered warning that does not seem to be right.
4304 (MAXPATHLEN): Define only if needed.
4305
4306 * process.c (serial_open, serial_configure): Move decls from here ...
4307 * systty.h: ... to here, so that they can be checked.
4308
4309 * fns.c (get_random, seed_random): Move extern decls from here ...
4310 * lisp.h: ... to here, so that they can be checked.
4311
4312 * sysdep.c (reset_io): Now static.
4313 (wait_for_termination_signal): Remove; unused.
4314
4315 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4316 (copy_keymap_item, append_key, push_text_char_description):
4317 Now static.
4318 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4319 (DENSE_TABLE_SIZE): Remove; unused.
4320 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4321 (describe_map_tree):
4322 Rename locals to avoid shadowing.
4323
4324 * keyboard.c: Declare functions static if they are not used elsewhere.
4325 (echo_char, echo_dash, cmd_error, top_level_2):
4326 (poll_for_input, handle_async_input): Now static.
4327 (read_char, kbd_buffer_get_event, make_lispy_position):
4328 (make_lispy_event, make_lispy_movement, apply_modifiers):
4329 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4330 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4331 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4332 (read_key_sequence, read_char): Mark locals as initialized.
4333 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4334
4335 * keyboard.h (make_ctrl_char): New decl.
4336 (mark_kboards): Move decl here ...
4337 * alloc.c (mark_kboards): ... from here.
4338
4339 * lisp.h (force_auto_save_soon): New decl.
4340
4341 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4342 (DEFINE_DUMMY_FUNCTION): New macro.
4343 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4344 Use it.
4345 (main): Add casts to avoid warnings
4346 if GCC considers string literals to be constants.
4347
4348 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4349
4350 * dbusbind.c: Pointer signedness fixes.
4351 (xd_signature, xd_append_arg, xd_initialize):
4352 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4353 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4354 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4355 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4356
4357 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4358 if GCC considers string literals to be constants.
4359 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4360
4361 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4362
4363 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4364 (print_preprocess, print_object): New macro to fix last change.
4365
4366 * print.c (print_preprocess): Don't forget font objects.
4367
4368 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4369
4370 * emacs.c (USAGE3): Doc fixes.
4371
4372 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4373
4374 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4375 structure.
4376
4377 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4378
4379 * lisp.h (VWindow_system, Qfile_name_history):
4380 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4381 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4382 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4383
4384 * w32select.c: Don't #include "keyboard.h".
4385 (run_protected): Add extern declaration for waiting_for_input.
4386
4387 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4388 * w32console.c (detect_input_pending, read_input_pending)
4389 (encode_terminal_code):
4390 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4391 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4392 (w32_system_caret_y, Qfile_name_history):
4393 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4394 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4395 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4396 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4397 * w32proc.c (Qlocal, report_file_error):
4398 * w32term.c (Vwindow_system, updating_frame):
4399 * w32uniscribe.c (initialized, uniscribe_font_driver):
4400 Remove unneeded extern declarations.
4401
4402 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4403
4404 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4405
4406 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4407
4408 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4409 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4410 These macros can no longer be used for assignment.
4411
4412 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4413 Assign struct members directly, instead of using BUF_BEGV etc.
4414 (record_buffer_markers, fetch_buffer_markers): New functions for
4415 recording and fetching special buffer markers.
4416 (set_buffer_internal_1, set_buffer_temp): Use them.
4417
4418 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4419
4420 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4421
4422 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4423 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4424
4425 * xdisp.c (hscroll_window_tree):
4426 (reconsider_clip_changes): Use PT instead of BUF_PT.
4427
4428 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4429
4430 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4431 $(EMACS_ROOT)/lib/intprops.h.
4432
4433 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4434
4435 Fix more problems found by GCC 4.5.2's static checks.
4436
4437 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4438 to unsigned char * to avoid compiler diagnostic.
4439 (xg_free_frame_widgets): Make it clear that a local variable is
4440 needed only if USE_GTK_TOOLTIP.
4441 (gdk_window_get_screen): Make it clear that this macro is needed
4442 only if USE_GTK_TOOLTIP.
4443 (int_gtk_range_get_value): New function, which avoids a diagnostic
4444 from gcc -Wbad-function-cast.
4445 (xg_set_toolkit_scroll_bar_thumb): Use it.
4446 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4447 diagnostic from gcc -Wbad-function-cast.
4448 (get_utf8_string, xg_get_file_with_chooser):
4449 Rename locals to avoid shadowing.
4450 (create_dialog): Move locals to avoid shadowing.
4451
4452 * xgselect.c (xg_select): Remove unused var.
4453
4454 * image.c (four_corners_best): Mark locals as initialized.
4455 (gif_load): Initialize transparent_p to zero (Bug#8238).
4456 Mark another local as initialized.
4457 (my_png_error, my_error_exit): Mark with NO_RETURN.
4458
4459 * image.c (clear_image_cache): Now static.
4460 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4461 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4462 (x_edge_detection): Remove unnecessary cast that
4463 gcc -Wbad-function-cast diagnoses.
4464 (gif_load): Fix pointer signedness.
4465 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4466 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4467
4468 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4469
4470 Improve quality of tests for time stamp overflow.
4471 For example, without this patch (encode-time 0 0 0 1 1
4472 1152921504606846976) returns the obviously-bogus value (-948597
4473 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4474 reports time overflow. See
4475 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4476 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4477 * editfns.c: Include limits.h and intprops.h.
4478 (TIME_T_MIN, TIME_T_MAX): New macros.
4479 (time_overflow): Move earlier, to before first use.
4480 (hi_time, lo_time): New functions, for an accurate test for
4481 out-of-range times.
4482 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4483 (Fget_internal_run_time): Don't assume time_t fits in int.
4484 (make_time): Use list2 instead of Fcons twice.
4485 (Fdecode_time): More accurate test for out-of-range times.
4486 (check_tm_member): New function.
4487 (Fencode_time): Use it, to test for out-of-range times.
4488 (lisp_time_argument): Don't rely on undefined left-shift and
4489 right-shift behavior when checking for time stamp overflow.
4490
4491 * editfns.c (time_overflow): New function, refactoring common code.
4492 (Fformat_time_string, Fdecode_time, Fencode_time):
4493 (Fcurrent_time_string): Use it.
4494
4495 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4496 * dired.c (make_time): Move to ...
4497 * editfns.c (make_time): ... here.
4498 * systime.h: Note the move.
4499
4500 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4501
4502 * fringe.c (update_window_fringes): Remove unused variables.
4503
4504 * unexmacosx.c (copy_data_segment): Also copy __got section.
4505 (Bug#8223)
4506
4507 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4508
4509 * termcap.c [MSDOS]: Include "msdos.h".
4510 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4511 Constify `char *' arguments and their references according to
4512 prototypes in tparam.h.
4513
4514 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4515
4516 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4517 Adapt all references accordingly.
4518
4519 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4520
4521 2011-03-11 Tom Tromey <tromey@redhat.com>
4522
4523 * buffer.c (syms_of_buffer): Remove obsolete comment.
4524
4525 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4526
4527 * termhooks.h (encode_terminal_code): Declare prototype.
4528
4529 * msdos.c (encode_terminal_code): Don't declare prototype.
4530
4531 * term.c (encode_terminal_code): Now external again, used by
4532 w32console.c and msdos.c.
4533
4534 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4535 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4536
4537 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4538
4539 Fix some minor problems found by GCC 4.5.2's static checks.
4540
4541 * fringe.c (update_window_fringes): Mark locals as initialized
4542 (Bug#8227).
4543 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4544
4545 * alloc.c (mark_fringe_data): Move decl from here ...
4546 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4547 to check its interface.
4548 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4549
4550 * fontset.c (free_realized_fontset): Now static.
4551 (Fset_fontset_font): Rename local to avoid shadowing.
4552 (fontset_font): Mark local as initialized.
4553 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4554
4555 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4556
4557 * xselect.c (x_disown_buffer_selections): Remove; not used.
4558 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4559 (x_own_selection, Fx_disown_selection_internal): Rename locals
4560 to avoid shadowing.
4561 (x_handle_dnd_message): Remove local to avoid shadowing.
4562
4563 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4564 so that the caller can use some name other than gcpro1.
4565 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4566 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4567 (Fx_backspace_delete_keys_p):
4568 Use them to avoid shadowing, and rename vars to avoid shadowing.
4569 (x_decode_color, x_set_name, x_window): Now static.
4570 (Fx_create_frame): Add braces to silence GCC warning.
4571 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4572 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4573 Remove unused locals.
4574 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4575 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4576 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4577 macros.
4578
4579 * xterm.h (x_mouse_leave): New decl.
4580
4581 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4582 Remove unused functions.
4583 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4584 (x_calc_absolute_position): Now static.
4585 (XTread_socket): Don't define label "out" unless it's used.
4586 Don't declare local "event" unless it's used.
4587 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4588 unless they are used.
4589 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4590 (x_fatal_error_signal): Remove; not used.
4591 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4592 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4593 (x_error_catcher, x_connection_closed, x_error_handler):
4594 (x_error_quitter, xembed_send_message, x_iconify_frame):
4595 (my_log_handler): Rename locals to avoid shadowing.
4596 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4597 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4598
4599 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4600 Rename or move locals to avoid shadowing.
4601 (tty_defined_color, merge_face_heights): Now static.
4602 (free_realized_faces_for_fontset): Remove; not used.
4603 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4604 does not deduce is never used uninitialized.
4605 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4606 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4607
4608 * terminal.c (store_terminal_param): Now static.
4609
4610 * xmenu.c (menu_highlight_callback): Now static.
4611 (set_frame_menubar): Remove unused local.
4612 (xmenu_show): Rename parameter to avoid shadowing.
4613 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4614 since they might point to immutable storage.
4615 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4616 since it's unused otherwise.
4617
4618 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4619 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4620 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4621 avoids a gcc -Wuninitialized diagnostic.
4622 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4623 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4624 does not deduce are never used uninitialized.
4625
4626 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4627
4628 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4629 * window.c (window_loop, size_window):
4630 (run_window_configuration_change_hook, enlarge_window): Likewise.
4631
4632 * window.c (display_buffer): Now static.
4633 (size_window): Mark variables that gcc -Wuninitialized
4634 does not deduce are never used uninitialized.
4635 * window.h (check_all_windows): New decl, to forestall
4636 gcc -Wmissing-prototypes diagnostic.
4637 * dispextern.h (bidi_dump_cached_states): Likewise.
4638
4639 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4640 shadowing.
4641 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4642 Include <limits.h>.
4643 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4644 and to avoid gcc -Wuninitialized warning.
4645 (load_charset_map): Mark variables that gcc -Wuninitialized
4646 does not deduce are never used uninitialized.
4647 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4648
4649 * coding.c (coding_set_source, coding_set_destination):
4650 Use "else { /* comment */ }" rather than "else /* comment */;"
4651 for clarity, and to avoid gcc -Wempty-body warning.
4652 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4653 a block, when the outer 'i' will do.
4654 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4655 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4656 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4657 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4658 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4659 Rename locals to avoid shadowing.
4660 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4661 * coding.c (emacs_mule_char, encode_invocation_designation):
4662 Now static, since they're not used elsewhere.
4663 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4664 (decode_coding_object, encode_coding_object, detect_coding_system):
4665 (decode_coding_emacs_mule): Mark variables that gcc
4666 -Wuninitialized does not deduce are never used uninitialized.
4667 (detect_coding_iso_2022): Initialize a local variable that might
4668 be used uninitialized. Leave a FIXME because it's not clear that
4669 this initialization is needed. (Bug#8211)
4670 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4671 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4672 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4673 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4674 Remove unused macros.
4675
4676 * category.c (hash_get_category_set): Remove unused local var.
4677 (copy_category_table): Now static, since it's not used elsewhere.
4678 * character.c (string_count_byte8): Likewise.
4679
4680 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4681 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4682
4683 * chartab.c (copy_sub_char_table): Now static, since it's not used
4684 elsewhere.
4685 (sub_char_table_ref_and_range, char_table_ref_and_range):
4686 Rename locals to avoid shadowing.
4687 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4688
4689 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4690 (BIDI_BOB): Remove unused macro.
4691
4692 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4693 deduce are never used uninitialized.
4694 * term.c (encode_terminal_code): Likewise.
4695
4696 * term.c (encode_terminal_code): Now static. Remove unused local.
4697
4698 * tparam.h: New file.
4699 * term.c, tparam.h: Include it.
4700 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4701 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4702 Move these decls to tparam.h, and make them agree with what
4703 is actually in tparam.c. The previous trick of using incompatible
4704 decls in different modules does not conform to the C standard.
4705 All callers of tparam changed to use tparam's actual API.
4706 * tparam.c (tparam1, tparam, tgoto):
4707 Use const pointers where appropriate.
4708
4709 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4710 * cm.h (struct cm): Likewise.
4711 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4712 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4713 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4714 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4715 (turn_on_face, init_tty): Likewise.
4716 * termchar.h (struct tty_display_info): Likewise.
4717
4718 * term.c (term_mouse_position): Rename local to avoid shadowing.
4719
4720 * alloc.c (mark_ttys): Move decl from here ...
4721 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4722
4723 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4724
4725 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4726
4727 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4728
4729 * search.c (compile_pattern_1): Remove argument regp, unused since
4730 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4731 (compile_pattern): Don't pass it.
4732
4733 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4734
4735 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4736 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4737 for ! HAVE_GTK3.
4738 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4739
4740 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4741
4742 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4743 gdk_window_get_screen, gdk_window_get_geometry,
4744 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4745 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4746 (xg_get_pixbuf_from_pixmap): New function.
4747 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4748 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4749 Call xg_get_pixbuf_from_pixmap instead of
4750 gdk_pixbuf_get_from_drawable.
4751 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4752 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4753 (xg_check_special_colors): Use GtkStyleContext and its functions
4754 for HAVE_GTK3.
4755 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4756 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4757 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4758 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4759 Call gtk_widget_get_preferred_size.
4760 (xg_frame_resized): gdk_window_get_geometry only takes 5
4761 parameters.
4762 (xg_win_to_widget, xg_event_is_for_menubar):
4763 Call gdk_x11_window_lookup_for_display.
4764 (xg_set_widget_bg): New function.
4765 (delete_cb): New function.
4766 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4767 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4768 (xg_set_background_color): Call xg_set_widget_bg.
4769 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4770 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4771 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4772 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4773 if ! HAVE_GTK3.
4774 (update_frame_tool_bar): Call gtk_widget_hide.
4775 (xg_initialize): Use GDK_KEY_g.
4776
4777 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4778 if ! HAVE_GTK3
4779 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4780
4781 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4782 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4783 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4784
4785 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4786
4787 * w32xfns.c (select_palette): Check success of RealizePalette against
4788 GDI_ERROR, not zero.
4789
4790 See ChangeLog.11 for earlier changes.
4791
4792 ;; Local Variables:
4793 ;; coding: utf-8
4794 ;; End:
4795
4796 Copyright (C) 2011 Free Software Foundation, Inc.
4797
4798 This file is part of GNU Emacs.
4799
4800 GNU Emacs is free software: you can redistribute it and/or modify
4801 it under the terms of the GNU General Public License as published by
4802 the Free Software Foundation, either version 3 of the License, or
4803 (at your option) any later version.
4804
4805 GNU Emacs is distributed in the hope that it will be useful,
4806 but WITHOUT ANY WARRANTY; without even the implied warranty of
4807 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4808 GNU General Public License for more details.
4809
4810 You should have received a copy of the GNU General Public License
4811 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.