Fix bug #9947 with referencing uninitialized variable.
[bpt/emacs.git] / src / ChangeLog
1 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4
5 * w32fns.c (unwind_create_frame): If needed, free the glyph
6 matrices of the partially constructed frame. (Bug#9943)
7 * xfns.c (unwind_create_frame): Likewise.
8
9 2011-11-01 Eli Zaretskii <eliz@gnu.org>
10
11 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
12 Don't stop backward scan on the continuation glyph, even though
13 its CHARPOS is positive.
14 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
15 cover_string to disp_string.
16
17 2011-11-01 Martin Rudalics <rudalics@gmx.at>
18
19 * window.c (temp_output_buffer_show): Don't use
20 Vtemp_buffer_show_specifiers.
21 (Vtemp_buffer_show_specifiers): Remove unused variable.
22
23 2011-10-30 Eli Zaretskii <eliz@gnu.org>
24
25 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
26 past the beginning of the current glyph matrix.
27
28 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
29
30 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
31 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
32 HAVE_GTK3 (Bug#9869).
33
34 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
35 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
36
37 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
38
39 * xterm.c: Declare x_handle_net_wm_state to return int.
40 (handle_one_xevent): Check if we are iconified but don't have
41 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
42 (get_current_wm_state): Return non-zero if not hidden,
43 check for _NET_WM_STATE_HIDDEN (Bug#9893).
44 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
45 (x_handle_net_wm_state): Return what get_current_wm_state returns.
46 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
47
48 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
49
50 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
51 so that this new function doesn't get optimized away by a
52 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
53
54 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
55
56 * frame.h (MOUSE_HL_INFO): Remove excess parens.
57
58 2011-10-29 Eli Zaretskii <eliz@gnu.org>
59
60 Fix the `xbytecode' command.
61 * .gdbinit (xprintbytestr): New command.
62 (xwhichsymbols): Renamed from `which'; all callers changed.
63 (xbytecode): Print the byte-code string as well.
64
65 2011-10-29 Kim Storm <storm@cua.dk>
66
67 * alloc.c (which_symbols): New function.
68
69 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
70
71 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
72 line. (Bug#9903)
73
74 2011-10-29 Glenn Morris <rgm@gnu.org>
75
76 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
77 Not clear what it was for, and it causes various bugs. (Bug#9839)
78
79 2011-10-28 Eli Zaretskii <eliz@gnu.org>
80
81 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
82 possible random value that matches one of those tested as
83 condition to clear the mouse face.
84
85 2011-10-28 Chong Yidong <cyd@gnu.org>
86
87 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
88
89 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
90
91 * window.c (make_window): Initialize phys_cursor_on_p.
92
93 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 * lisp.h (struct Lisp_Symbol): Update comments.
96
97 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
98
99 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
100
101 2011-10-28 Eli Zaretskii <eliz@gnu.org>
102
103 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
104 <oslsachem@gmail.com> for helping to debug this.
105
106 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
107 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
108 (g_b_init_get_glyph_outline_w): New static variables.
109 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
110 (GetGlyphOutlineW_Proc): New typedefs.
111 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
112 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
113 New functions.
114 (w32font_open_internal, compute_metrics):
115 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
116 instead of calling the "wide" APIs directly.
117
118 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
119
120 * w32.h (syms_of_w32font): Add prototype.
121
122 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
123
124 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
125 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
126 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
127 (Fmove_to_window_line): Doc fix.
128
129 2011-10-27 Chong Yidong <cyd@gnu.org>
130
131 * process.c (make_process): Set gnutls_state to NULL.
132
133 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
134 non-NULL, regardless of GNUTLS_INITSTAGE.
135 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
136 an error. Set process slots as soon as we allocate them.
137
138 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
139
140 2011-10-27 Chong Yidong <cyd@gnu.org>
141
142 * gnutls.c (emacs_gnutls_deinit): New function.
143 Deallocate credentials structures as well as calling gnutls_deinit.
144 (Fgnutls_deinit, Fgnutls_boot): Use it.
145
146 * process.c (make_process): Initialize GnuTLS credentials to NULL.
147 (deactivate_process): Call emacs_gnutls_deinit.
148
149 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
150
151 * image.c (x_create_x_image_and_pixmap):
152 * w32.c (sys_rename, w32_delayed_load):
153 * w32font.c (fill_in_logfont):
154 * w32reg.c (x_get_string_resource): Silence compiler warnings.
155
156 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
157
158 * w32fns.c (w32_default_color_map): New function,
159 extracted from Fw32_default_color_map.
160 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
161
162 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
163
164 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
165
166 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
167
168 * keyboard.c (test_undefined): New function (bug#9751).
169 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
170
171 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
172
173 * sysdep.c (init_sys_modes): Fix the check for the controlling
174 terminal (Bug#6649).
175
176 2011-10-20 Eli Zaretskii <eliz@gnu.org>
177
178 * dispextern.h (struct bidi_it): New member next_en_type.
179
180 * bidi.c (bidi_line_init): Initialize the next_en_type member.
181 (bidi_resolve_explicit_1): When next_en_pos is valid for the
182 current character, check also for next_en_type being WEAK_EN.
183 (bidi_resolve_weak): Don't enter the expensive loop if the current
184 position is before next_en_pos. Record the bidi type of the first
185 non-ET, non-BN character we find, in addition to its position.
186 (bidi_level_of_next_char): Invalidate next_en_type when
187 next_en_pos is over-stepped.
188
189 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
190
191 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
192 * editfns.c: Rewrite current-time-zone so that it invokes
193 the equivalent of (format-time-string "%Z") to get the time zone name.
194 This fixes a bug when the time zone name contains characters that
195 need converting from the system time locale to Emacs internal format.
196 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
197 that patch fixed format-time-string to do the conversion, but
198 I forgot to fix current-time-zone.
199 (format_time_string): New function, containing most of
200 what Fformat_time_string used to contain.
201 (Fformat_time_string): Rewrite in terms of format_time_string.
202 This doesn't change this function's behavior.
203 (current-time-zone): Rewrite to use format_time_string.
204 This fixes the bug reported by Michael Schierl in
205 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
206 Jason Rumney's 2007-06-07 change worked around this bug, but
207 didn't fix it.
208 * systime.h (tzname, timezone): Remove no-longer-used declarations.
209
210 2011-10-19 Eli Zaretskii <eliz@gnu.org>
211
212 * xdisp.c (start_display): If the character at POS is displayed
213 via a display vector, reset IT->current.dpvec_index to zero.
214 (try_window_reusing_current_matrix): If a line ends in a display
215 vector or the next line starts in a display vector, continue
216 redrawing the window even though the character position of
217 start_row was reached.
218 (Bug#9771, part 2)
219
220 2011-10-18 Chong Yidong <cyd@gnu.org>
221
222 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
223 with nobreak-char-display too.
224
225 2011-10-18 Eli Zaretskii <eliz@gnu.org>
226
227 Fix part 3 of bug#9771.
228 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
229 (bidi_resolve_neutral): Don't enter the expensive loop looking for
230 non-neutral characters if the current character is a paragraph
231 separator (a.k.a. Newline). This avoids running the same
232 expensive loop twice, once when we consume the preceding newline
233 and the other time when the line actually needs to be displayed.
234 Avoid the loop when we see neutrals on the base embedding level
235 following a character whose directionality is the same as the
236 paragraph's. This avoids running the expensive loop when a line
237 ends in a long sequence of neutrals, like control characters.
238 Add assertion against STRONG_AL type. Slightly rearrange code
239 that determines the type of a neutral given the first non-neutral
240 that follows it.
241 (bidi_level_of_next_char): Set next_en_pos to zero when
242 invalidating its info.
243
244 2011-10-17 Eli Zaretskii <eliz@gnu.org>
245
246 * xdisp.c (push_display_prop): Determine whether to record string
247 or buffer position by IT->string, not by IT->method. Allow
248 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
249 (move_it_vertically_backward): Don't look for character position
250 immediately after the newline when in a continuation line.
251 (Bug#9771, part 1)
252
253 2011-10-15 Martin Rudalics <rudalics@gmx.at>
254
255 * window.c (coordinates_in_window): Rewrite and delabelize
256 vertical border check. (Bug#5357) (Bug#9618)
257
258 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
259
260 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
261 errors in XSetWindowBorder (bug#9310).
262
263 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
264
265 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
266 avoid crash when xmalloc overrun checking is enabled.
267
268 2011-10-13 Eli Zaretskii <eliz@gnu.org>
269
270 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
271 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
272 cursor motion with <left> and <right> arrow keys.
273
274 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
275 some callers set that themselves.
276
277 2011-10-12 Eli Zaretskii <eliz@gnu.org>
278
279 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
280 display string and the previous row comes from the same string and
281 is empty. (Bug#9739) (Bug#9738)
282
283 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
284
285 * doc.c (get_doc_string): Encode file name (bug#9735).
286
287 2011-10-12 Eli Zaretskii <eliz@gnu.org>
288
289 * bidi.c (bidi_level_of_next_char):
290 * xdisp.c (get_visually_first_element): Remove old incorrect
291 comments regarding the Unicode Line Separator character.
292
293 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
294
295 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
296
297 * alloc.c (Fgc_status): Do not access beyond zombies array
298 boundary if nzombies > MAX_ZOMBIES.
299 * alloc.c (dump_zombies): Add missing format specifier.
300
301 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
302
303 * xdisp.c (set_cursor_from_row): Simplify conditionals,
304 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
305
306 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
307 Some packages use them to denote characters with modifiers.
308
309 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
310
311 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
312 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
313 matching a pp-number. Rename parameter var to var1.
314
315 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
316
317 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
318
319 2011-10-08 Glenn Morris <rgm@gnu.org>
320
321 * callint.c (Fcall_interactively): Give a more explicit error for the
322 'c' case with a non-character input. (Bug#8479)
323
324 2011-10-08 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
327 lines.
328 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
329 lines that are hscrolled on the left.
330
331 * dispnew.c (buffer_posn_from_coords): Account for a possible
332 presence of header-line. (Bug#4426)
333
334 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
335
336 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
337 Don't advertise functionality which we discourage or doesn't work.
338
339 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
340
341 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
342 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
343 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
344 this makes Emacs dump core during garbage collection on rare
345 occasions. sizeof is obviously inferior to offsetof here, so
346 stick with offsetof.
347 (GC_POINTER_ALIGNMENT): New macro.
348 (mark_memory): Omit 3rd (offset) arg; caller changed.
349 Don't assume EMACS_INT alignment is the same as pointer alignment.
350
351 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
352
353 * keyboard.c (read_key_sequence_remapped): New var.
354 (read_key_sequence): Compute remapping in the right buffer.
355 (command_loop_1): Use read_key_sequence's remapping directly.
356
357 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
358
359 * dired.c (file_name_completion): Don't expand file name.
360 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
361 before checking file name handler.
362
363 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
364 they've been requested explicitly (bug#9591).
365
366 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
367
368 * keymap.c (Fsingle_key_description): Use make_specified_string
369 instead of build_string to build string from push_key_description.
370 (Bug#5193)
371
372 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
373
374 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
375 This fixes a Y2038 bug on 64-bit hosts.
376 * buffer.c (reset_buffer):
377 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
378 (Fclear_buffer_auto_save_failure):
379 Use 0, not -1, to represent an unset failure time, since time_t
380 might not be signed.
381
382 Remove dependency on glibc malloc internals.
383 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
384 Move back here from lisp.h, but with their new implementations.
385 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
386 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
387 * charset.c (charset_table_init): New static var.
388 (syms_of_charset): Use it instead of xmalloc. This removes a
389 dependency on glibc malloc internals. See Eli Zaretskii's comment in
390 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
391 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
392 Move back to alloc.c.
393 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
394 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
395
396 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
397
398 * nsterm.m (windowDidResize): Call x_set_window_size only when
399 ns_in_resize is true. Otherwise set pixelwidth/height and
400 call change_frame_size (Bug#9628).
401
402 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
403
404 Port --enable-checking=all to Fedora 14 x86-64.
405 * charset.c (syms_of_charset): Also account for glibc malloc's
406 internal overhead when calculating the initial malloc maximum.
407
408 Port --enable-checking=all to Fedora 14 x86.
409 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
410 Move to lisp.h.
411 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
412 (overrun_check_realloc, overrun_check_free):
413 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
414 That way, xmalloc returns a properly-aligned pointer even if
415 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
416 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
417 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
418 into account when calculating the initial malloc maximum.
419 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
420 Move here from alloc.c, so that charset.c can use it too.
421 Properly align; the old code wasn't right for common 32-bit hosts
422 when configured with --enable-checking=all.
423 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
424 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
425
426 2011-09-29 Eli Zaretskii <eliz@gnu.org>
427
428 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
429 use EDOM.
430
431 2011-09-28 Eli Zaretskii <eliz@gnu.org>
432
433 * xdisp.c (compute_display_string_end): If there's no display
434 string at CHARPOS, return -1.
435
436 * bidi.c (bidi_fetch_char): When compute_display_string_end
437 returns a negative value, treat the character as a normal
438 character not covered by a display string. (Bug#9624)
439
440 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
441
442 * lread.c (Fread_from_string): Fix typo in docstring.
443
444 2011-09-27 Eli Zaretskii <eliz@gnu.org>
445
446 * xdisp.c (handle_invisible_prop): If invisible text ends on a
447 newline, reseat the iterator instead of bidi-iterating there one
448 character at a time. (Bug#9610)
449 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
450 TO_CHARPOS if the bidi iterator is at base embedding level.
451
452 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
453
454 * lread.c (readevalloop): Use correct code for NBSP.
455 (read1): Likewise. (Bug#9608)
456
457 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
458
459 * dbusbind.c (Fdbus_register_signal): When service is not
460 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
461
462 2011-09-25 Glenn Morris <rgm@gnu.org>
463
464 * buffer.c (truncate-lines): Doc fix.
465
466 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
467
468 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
469 (Fset_window_next_buffers): Doc fix.
470
471 2011-09-24 Glenn Morris <rgm@gnu.org>
472
473 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
474
475 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
476
477 Fix minor problems found by static checking.
478 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
479 * indent.c (Fvertical_motion): Fix == vs = typo.
480
481 2011-09-24 Eli Zaretskii <eliz@gnu.org>
482
483 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
484 Default value is now t. Doc fix.
485
486 * indent.c (Fvertical_motion): Compute and apply the overshoot
487 logic when moving up, not only when moving down. Fix the
488 confusing name and values of the it_overshoot_expected variable;
489 logic changes accordingly. (Bug#9254) (Bug#9549)
490
491 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
492 CHARPOS is covered by a display string which includes newlines.
493 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
494 is covered by a display string with embedded newlines.
495
496 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
497
498 * dbusbind.c (Fdbus_register_signal): Add match rule to
499 Vdbus_registered_objects_table. (Bug#9581)
500 (Fdbus_register_method, Vdbus_registered_objects_table):
501 Fix docstring.
502
503 2011-09-24 Jim Meyering <meyering@redhat.com>
504
505 do not ignore write error for any output size
506 The previous change was incomplete.
507 While it makes emacs --batch detect the vast majority of stdout
508 write failures, errors were still ignored whenever the output size is
509 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
510 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
511 && echo FAIL: ignored write error
512 FAIL: ignored write error
513 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
514 && echo FAIL: ignored write error
515 FAIL: ignored write error
516 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
517
518 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
519
520 * emacs.c (Fkill_emacs): In noninteractive mode exit
521 non-successfully if a write error occurred on stdout. (Bug#9574)
522
523 2011-09-21 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
526 the xassert test.
527
528 * dispextern.h (struct it): Update the comment documenting what
529 can it->OBJECT be.
530
531 2011-09-20 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
534 a display string, extend search for cursor position to end of row.
535 (find_row_edges): If the row ends in a newline from a display
536 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
537 Handle the case of a display string with multiple newlines.
538 (Fcurrent_bidi_paragraph_direction): Fix search for previous
539 non-empty line. Fixes confusing cursor motion with arrow keys at
540 the beginning of a line that starts with whitespace.
541
542 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
543
544 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
545 (bug#9493).
546
547 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
548
549 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
550 boolean (Bug#9154).
551
552 2011-09-18 Eli Zaretskii <eliz@gnu.org>
553
554 * xdisp.c (display_line): Record maximum and minimum buffer
555 positions even if no glyphs were produced (e.g., by a zero-width
556 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
557 buffer positions that will be removed from the glyph row because
558 they don't fit.
559 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
560 column is beyond frame width: don't subtract 1 "pixel" when
561 computing width of the stretch.
562 (reseat_at_next_visible_line_start): Undo the change made on
563 2011-09-17 that saved paragraph information and restored it after
564 the call to `reseat'. (Bug#9545)
565
566 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
567
568 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
569 and turn window cursor on if cleared (Bug#9415).
570
571 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
572
573 * search.c (boyer_moore): Take unibyte characters from pattern
574 literally. (Bug#9458)
575
576 2011-09-18 Eli Zaretskii <eliz@gnu.org>
577
578 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
579
580 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
581
582 Fix minor problem found by static checking.
583 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
584 initialized, to pacify gcc -Wuninitialized.
585
586 * fileio.c: Report proper errno when syscall falls.
587 (Finsert_file_contents): Save and restore errno,
588 so that report_file_error outputs the correct diagnostic.
589 (Fwrite_region) [CLASH_DETECTION]: Likewise.
590
591 2011-09-18 Eli Zaretskii <eliz@gnu.org>
592
593 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
594
595 2011-09-17 Eli Zaretskii <eliz@gnu.org>
596
597 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
598 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
599
600 2011-09-17 Eli Zaretskii <eliz@gnu.org>
601
602 * xdisp.c (reseat_at_next_visible_line_start): Keep information
603 about the current paragraph and restore it after the call to reseat.
604
605 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
606 (bidi_find_paragraph_start): Search back for paragraph beginning
607 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
608 (bidi_move_to_visually_next): Only trigger paragraph-related
609 computations when the last character is a newline or at EOB, not
610 just any NEUTRAL_B. (Bug#9470)
611
612 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
613 truncated lines if point is covered by a display string. (Bug#9524)
614
615 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
616
617 * xselect.c: Relax test for outgoing X longs (Bug#9498).
618 (cons_to_x_long): New function.
619 (lisp_data_to_selection_data): Use it. Correct the test for
620 short-versus-long data; it was negated. Break out of vector
621 loop, for efficiency, when a long datum is discovered.
622
623 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
626
627 2011-09-16 Eli Zaretskii <eliz@gnu.org>
628
629 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
630 GCC PR/17406) by declaring this function with external scope.
631
632 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
633
634 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
635 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
636
637 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
638
639 * editfns.c (Fformat): Correctly handle text properties on "%%".
640
641 2011-09-15 Eli Zaretskii <eliz@gnu.org>
642
643 * xterm.c (x_draw_composite_glyph_string_foreground):
644 * w32term.c (x_draw_composite_glyph_string_foreground):
645 * term.c (encode_terminal_code):
646 * composite.c (composition_update_it, get_composition_id):
647 * xdisp.c (get_next_display_element)
648 (fill_composite_glyph_string): Add comments about special meaning
649 of TAB characters in a composition.
650
651 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
652
653 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
654 This occurs when processing a multibyte format.
655 Problem reported by Wolfgang Jenker.
656
657 2011-09-15 Johan Bockgård <bojohan@gnu.org>
658
659 * xdisp.c (try_cursor_movement): Only check for exact match if
660 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
661
662 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
663
664 Remove unused external symbols.
665 * dispextern.h (calc_pixel_width_or_height): Remove decl.
666 * xdisp.c (calc_pixel_width_or_height): Now static.
667 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
668 * indent.c (check_display_width):
669 * w32term.c: Fix comment to match code.
670 * xterm.c, xterm.h (x_catching_errors): Remove.
671
672 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
673
674 * xselect.c: Use signed conversions more consistently (Bug#9498).
675 (selection_data_to_lisp_data): Assume incoming selection data are
676 signed integers, not unsigned. This is to be consistent with
677 outgoing selection data, which was modified to use signed integers
678 in as part of the fix to Bug#9196 in response to Jan D.'s comment
679 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
680 expects long, not unsigned long.
681
682 2011-09-14 Eli Zaretskii <eliz@gnu.org>
683
684 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
685 computation of loop end. Reported by Johan Bockgård
686 <bojohan@gnu.org>.
687
688 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
689
690 * frame.c (Fother_visible_frames_p): Function deleted.
691
692 2011-09-12 Eli Zaretskii <eliz@gnu.org>
693
694 * indent.c (compute_motion): Process display vector front to back
695 rather than the other way around. (Bug#2496)
696
697 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
698
699 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
700
701 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
702
703 * minibuf.c (Fread_from_minibuffer): Doc fix.
704
705 2011-09-11 Eli Zaretskii <eliz@gnu.org>
706
707 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
708 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
709
710 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
711
712 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
713 value for non-existent files.
714
715 2011-09-11 Eli Zaretskii <eliz@gnu.org>
716
717 * fileio.c (Finsert_file_contents): If the file cannot be opened,
718 set its "size" to -1. This will set the modtime_size field of
719 the corresponding buffer to -1, which is what
720 verify-visited-file-modtime expects for files that do not exist.
721 (Bug#9139)
722
723 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
724
725 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
726 here ...
727 * lisp.h: ... from here. push_key_description is no longer
728 defined in keyboard.c, so its declaration should not be in
729 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
730 logically belongs with push_key_description.
731
732 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
733
734 * buffer.h: Include <sys/types.h> instead of <time.h>.
735 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
736 Problem reported by Herbert J. Skuhra.
737
738 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
739
740 * xml.c (parse_region): Make the parsing work for
741 non-comment-starting XML files again (bug#9144).
742
743 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
744
745 * image.c (gif_load): Fix calculation of bottom and right corner.
746 (Bug#9468)
747
748 2011-09-10 Eli Zaretskii <eliz@gnu.org>
749
750 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
751 redisplay in small windows.
752
753 2011-09-09 Eli Zaretskii <eliz@gnu.org>
754
755 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
756
757 2011-09-08 Martin Rudalics <rudalics@gmx.at>
758
759 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
760 Operate on live windows only.
761
762 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
763
764 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
765
766 2011-09-07 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
769 only under bidi iteration.
770
771 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
772
773 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
774
775 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
776
777 isnan: Fix porting problem to Solaris 10 with bundled gcc.
778 Without this fix, the command to link temacs failed due to an
779 undefined symbol __builtin_isnan. This is because
780 /usr/include/iso/math_c99.h #defines isnan(x) to
781 __builtin_isnan(x), but the bundled gcc, which identifies itself
782 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
783 a __builtin_isnan.
784 * floatfns.c (isnan): #undef, and then #define to a clone of
785 what's in data.c.
786 (Fisnan): Always define, since it's always available now.
787 (syms_of_floatfns): Always define isnan at the Lisp level.
788
789 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
790
791 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
792
793 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
794
795 * fileio.c: Fix bugs with large file offsets (Bug#9428).
796 The previous code assumed that file offsets (off_t values) fit in
797 EMACS_INT variables, which is not true on typical 32-bit hosts.
798 The code messed up by falsely reporting buffer overflow in cases
799 such as (insert-file-contents "big" nil 1 2) into an empty buffer
800 when "big" contains more than 2**29 bytes, even though this
801 inserts just one byte and does not overflow the buffer.
802 (Finsert_file_contents): Store file offsets as off_t
803 values, not as EMACS_INT values. Check for overflow when
804 converting between EMACS_INT and off_t. When checking for
805 buffer overflow or for overlap, take the offsets into account.
806 Don't use EMACS_INT for small values where int suffices.
807 When checking for overlap, fix a typo: ZV was used where
808 ZV_BYTE was intended.
809 (Fwrite_region): Don't assume off_t fits into 'long'.
810 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
811
812 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
813
814 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
815
816 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
817
818 sprintf-related integer and memory overflow issues (Bug#9412).
819
820 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
821 (esprintf, exprintf, evxprintf): New functions.
822 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
823 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
824 (modify_event_symbol): Do not assume that the length of
825 name_alist_or_stem is safe to alloca and fits in int.
826 (Fexecute_extended_command): Likewise for function name and binding.
827 (Frecursion_depth): Wrap around reliably on integer overflow.
828 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
829 since some callers pass EMACS_INT values.
830 (Fsingle_key_description): Don't crash if symbol name contains more
831 than MAX_ALLOCA bytes.
832 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
833 (get_minibuffer): Arg is now EMACS_INT, not int.
834 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
835 (esprintf, exprintf, evxprintf): New decls.
836 * window.h (command_loop_level, minibuf_level): Reflect API changes.
837
838 * dbusbind.c (signature_cat): New function.
839 (xd_signature, Fdbus_register_signal):
840 Do not overrun buffer; instead, report string overflow.
841
842 * dispnew.c (add_window_display_history): Don't overrun buffer.
843 Truncate instead; this is OK since it's just a log.
844
845 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
846 even if the time zone offset is outlandishly large.
847 Don't mishandle offset == INT_MIN.
848
849 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
850 when creating daemon; the previous buffer-overflow check was incorrect.
851
852 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
853 which has the guts of the old verror function.
854
855 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
856 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
857
858 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
859 (font_unparse_xlfd): Don't blindly alloca long strings.
860 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
861 fits in int, when using sprintf. Use single snprintf to count
862 length of string rather than counting it via multiple sprintfs;
863 that's simpler and more reliable.
864 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
865 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
866 sprintf, in case result does not fit in int.
867
868 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
869 (fontset_from_font): Print it.
870
871 * frame.c (tty_frame_count): Now printmax_t, not int.
872 (make_terminal_frame, set_term_frame_name): Print it.
873 (x_report_frame_params): In X, window IDs are unsigned long,
874 not signed long, so print them as unsigned.
875 (validate_x_resource_name): Check for implausibly long names,
876 and don't assume name length fits in 'int'.
877 (x_get_resource_string): Don't blindly alloca invocation name;
878 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
879 not fit in int.
880
881 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
882 (xg_check_special_colors, xg_set_geometry):
883 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
884
885 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
886 Use esprintf, not sprintf, in case result does not fit in int.
887
888 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
889 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
890 it as a large positive number.
891 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
892 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
893
894 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
895 in case result does not fit in int.
896
897 * print.c (float_to_string): Detect width overflow more reliably.
898 (print_object): Make sprintf buffer a bit bigger, to avoid potential
899 buffer overrun. Don't assume list length fits in 'int'. Treat
900 print length of 0 as 0, not as infinity; to be consistent with other
901 uses of print length in this function. Don't overflow print length
902 index. Don't assume hash table size fits in 'long', or that
903 vectorlike size fits in 'unsigned long'.
904
905 * process.c (make_process): Use printmax_t, not int, to format
906 process-name gensyms.
907
908 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
909
910 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
911 to avoid potential buffer overrun.
912
913 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
914 if X resource line is longer than 512 bytes.
915
916 * xfns.c (x_window): Make sprintf buffer a bit bigger
917 to avoid potential buffer overrun.
918
919 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
920
921 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
922
923 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
924
925 Integer overflow fixes for scrolling, etc.
926 Without these, Emacs silently mishandles large integers sometimes.
927 For example, "C-u 4294967297 M-x recenter" was treated as if
928 it were "C-u 1 M-x recenter" on a typical 64-bit host.
929
930 * xdisp.c (try_window_id): Check Emacs fixnum range before
931 converting to 'int'.
932
933 * window.c (window_scroll_line_based, Frecenter):
934 Check that an Emacs fixnum is in range before assigning it to 'int'.
935 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
936 values converted from Emacs fixnums.
937 (Frecenter): Don't wrap around a line count if it is out of 'int'
938 range; instead, treat it as an extreme value.
939 (Fset_window_configuration, compare_window_configurations):
940 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
941
942 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
943 that can exceed INT_MAX. Check that EMACS_INT value is in range
944 before assigning it to the (possibly-narrower) index.
945 (match_limit): Don't assume that a fixnum can fit in 'int'.
946
947 * print.c (print_object): Use ptrdiff_t, not int, for index that can
948 exceed INT_MAX.
949
950 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
951 (Fvertical_motion): Don't wrap around LINES values that don't fit
952 in 'int'. Instead, treat them as extreme values. This is good
953 enough for windows, which can't have more than INT_MAX lines anyway.
954
955 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
956
957 * Require libxml/parser.h to avoid compilation warning.
958
959 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
960
961 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
962 since this reportedly can destroy thread storage.
963
964 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
965
966 * syntax.c (find_defun_start): Update all cache variables if
967 exiting early (Bug#9401).
968
969 2011-08-30 Eli Zaretskii <eliz@gnu.org>
970
971 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
972
973 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
974 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
975 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
976
977 * term.c (tty_append_glyph): New function.
978 (produce_stretch_glyph): Static function and its prototype deleted.
979
980 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
981 Add prototypes.
982
983 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
984
985 * image.c (parse_image_spec): Check for nonnegative, not for positive,
986 when checking :margin (Bug#9390).
987 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
988 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
989 so that the name doesn't mislead. All uses changed.
990
991 2011-08-28 Johan Bockgård <bojohan@gnu.org>
992
993 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
994 set_tty_hooks.
995
996 2011-08-27 Eli Zaretskii <eliz@gnu.org>
997
998 * xdisp.c (move_it_to): Don't bail out early when reaching
999 position beyond to_charpos, if we are scanning backwards.
1000 (move_it_vertically_backward): When DY == 0, make sure we get to
1001 the first character in the line after the newline.
1002
1003 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1006 (ccl_driver): Do not generate an out-of-range pointer.
1007 (Fccl_execute_on_string): Remove unnecessary check for
1008 integer overflow, noted by Stefan Monnier in
1009 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1010 Remove a FIXME that didn't need fixing.
1011 Simplify the newly-introduced buffer reallocation code.
1012
1013 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1014
1015 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1016
1017 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1018
1019 Integer and memory overflow issues (Bug#9196).
1020
1021 * doc.c (get_doc_string): Rework so that
1022 get_doc_string_buffer_size is the actual buffer size, rather than
1023 being 1 less than the actual buffer size; this makes xpalloc more
1024 convenient.
1025
1026 * image.c (x_allocate_bitmap_record, cache_image):
1027 * xselect.c (Fx_register_dnd_atom):
1028 Simplify previous changes by using xpalloc.
1029
1030 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1031 since either will do and ptrdiff_t is convenient with xpalloc.
1032
1033 * charset.c (charset_table_size)
1034 (struct charset_sort_data.priority): Now ptrdiff_t.
1035 (charset_compare): Don't overflow if priorities differ greatly.
1036 (Fsort_charsets): Don't assume list length fits in int.
1037 Check for size-calculation overflow when allocating sort data.
1038 (syms_of_charset): Allocate an initial charset table that is
1039 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1040
1041 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1042
1043 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1044 The actual value is always <= INT_MAX, and leaving it unsigned made
1045 overflow checking harder.
1046
1047 * dispextern.h (struct glyph_matrix.rows_allocated)
1048 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1049 with xpalloc. The values are still always <= INT_MAX.
1050
1051 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1052
1053 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1054 (SAFE_NALLOCA): New macro.
1055
1056 * region-cache.c (struct boundary.pos, find_cache_boundary)
1057 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1058 (set_cache_region, invalidate_region_cache)
1059 (revalidate_region_cache, know_region_cache, region_cache_forward)
1060 (region_cache_backward, pp_cache):
1061 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1062 so that ptrdiff_t * can be passed to xpalloc.
1063 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1064 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1065 (pp_cache): Don't assume cache_len fits in int.
1066 * region-cache.h: Adjust extern decls to match.
1067
1068 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1069 EMACS_INT, since either will do, for xpalloc.
1070
1071 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1072 (xnmalloc, xnrealloc, xpalloc): New functions.
1073
1074 * bidi.c (bidi_shelve_header_size): New constant.
1075 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1076 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1077
1078 * bidi.c (bidi_cache_shrink):
1079 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1080 (overlay_strings):
1081 Don't update size of array until after memory allocation succeeds,
1082 because xmalloc/xrealloc may not return.
1083 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1084 now that we have proper integer overflow checking.
1085 (record_overlay_string, overlay_strings): Catch overflows when
1086 calculating size of overlay_str_buf.
1087
1088 * callproc.c (Fcall_process): Check for size overflow when
1089 calculating size of args2.
1090 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1091 Normally we prefer signed values, but sticking with ptrdiff_t would
1092 require adding more-complicated checks.
1093
1094 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1095 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1096 Redo buffer-overflow calculations to avoid integer overflow.
1097 Add a FIXME comment where memory seems to be over-allocated.
1098
1099 * character.c (Fstring): Check for size-calculation overflow.
1100
1101 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1102 unnecessary integer overflow. Check for size overflow.
1103 (encode_coding_object): Don't update size until xmalloc succeeds.
1104
1105 * composite.c (get_composition_id): Check for overflow in glyph
1106 length calculations.
1107
1108 Integer and memory overflow fixes for display code.
1109 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1110 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1111 (scrolling_window): Check for overflow in size calculations.
1112 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1113 Don't assume glyph table len fits in int.
1114 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1115 (row_table_size): Now ptrdiff_t, not int.
1116 (scrolling_window): Avoid overflow in size calculations.
1117 Don't update size until allocation succeeds.
1118 * fns.c (concat): Check for overflow in size calculations.
1119 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1120 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1121 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1122
1123 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1124 (get_doc_string): Check for size calculation overflow.
1125 Don't update size until allocation succeeds.
1126 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1127 EMACS_INT, where ptrdiff_t will do.
1128 (Fsubstitute_command_keys): Check for string overflow.
1129
1130 * editfns.c (set_time_zone_rule): Don't assume environment length
1131 fits in int.
1132 (message_length): Now ptrdiff_t, not int.
1133 (Fmessage_box): Don't update size until allocation succeeds.
1134 Don't assume message length fits in int.
1135 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1136
1137 * emacs.c (main): Do not reallocate argv, since there is a null at
1138 the end that can be overwritten, and this way there's no need to
1139 worry about size-calculation overflow.
1140 (sort_args): Check for size-calculation overflow.
1141
1142 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1143 alloc succeeds.
1144 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1145
1146 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1147 (x_set_scroll_bar_width, x_figure_window_size):
1148 Check for integer overflow.
1149 (x_set_alpha): Do not assume XINT fits in int.
1150
1151 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1152 This is for the members text_lines, text_cols, total_lines, total_cols,
1153 where the system imposes an 'int' limit.
1154
1155 * fringe.c (Fdefine_fringe_bitmap):
1156 Don't update size until alloc works.
1157
1158 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1159 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1160
1161 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1162 Check for size-calculation overflow.
1163 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1164 do, as we prefer signed integers.
1165 (id_to_widget.max_size, id_to_widget.used)
1166 (xg_store_widget_in_map, xg_remove_widget_from_map)
1167 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1168 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1169 Use and return ptrdiff_t, not int.
1170 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1171 * gtkutil.h: Change prototypes to match the above.
1172
1173 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1174 are duplicate now that they've been promoted to lisp.h.
1175 (x_allocate_bitmap_record, x_alloc_image_color)
1176 (make_image_cache, cache_image, xpm_load):
1177 Don't update size until alloc is done.
1178 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1179 (x_detect_edges):
1180 Check for size calculation overflow.
1181 (ct_colors_allocated_max): New constant.
1182 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1183 overflow.
1184
1185 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1186 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1187 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1188 Use ptrdiff_t, not int, to count maps.
1189 (read_char_minibuf_menu_prompt): Check for overflow in size
1190 calculations. Don't update size until allocation succeeds.
1191 Redo calculations to avoid overflow.
1192 * keyboard.h: Change prototypes to match the above.
1193
1194 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1195 to count maps.
1196 (current_minor_maps): Check for size calculation overflow.
1197 * keymap.h: Change prototypes to match the above.
1198
1199 * lread.c (read1, init_obarray): Don't update size until alloc done.
1200
1201 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1202 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1203
1204 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1205 Now ptrdiff_t, not int.
1206 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1207 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1208
1209 * process.c (Fnetwork_interface_list): Check for overflow
1210 in size calculation.
1211
1212 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1213
1214 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1215 overflow. Don't bother calling xmalloc when xrealloc will do.
1216
1217 * search.c (Freplace_match): Check for size calculation overflow.
1218 (Fset_match_data): Don't assume list lengths fit in 'int'.
1219
1220 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1221 for command line length. Do not attempt to address one before the
1222 beginning of an array, as that's not portable.
1223
1224 * term.c (max_frame_lines): Remove; unused.
1225 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1226 not int.
1227 (encode_terminal_code, calculate_costs): Check for size
1228 calculation overflow.
1229 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1230 table lengths and related sizes. Don't update size until alloc
1231 done. Redo calculations to avoid overflow.
1232 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1233
1234 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1235 subtracting pointers.
1236 (gobble_line): Check for overflow more carefully. Don't update size
1237 until alloc done.
1238
1239 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1240 Don't update size until alloc done.
1241 Redo size calculations to avoid overflow.
1242 Check for size calculation overflow.
1243 (main) [DEBUG]: Fix typo in invoking tparam1.
1244
1245 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1246 Use ptrdiff_t, not int, for sizes.
1247 (store_mode_line_noprop_char): Don't update size until alloc done.
1248
1249 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1250 Use ptrdiff_t, not int, for sizes.
1251 (Finternal_make_lisp_face, cache_face):
1252 Check for size calculation overflow.
1253 (cache_face): Treat size calculation overflows as if they were
1254 memory exhaustion (the usual treatment), rather than aborting.
1255
1256 * xfns.c (x_encode_text, x_set_name_internal)
1257 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1258 sizes, since they can exceed INT_MAX in size. Check for size
1259 calculation overflow.
1260
1261 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1262 (xg_select): Check for size calculation overflow.
1263 Don't update size until alloc done.
1264
1265 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1266 as sprintf is limited to int lengths.
1267
1268 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1269 (X_LONG_MIN): New macros.
1270 Use them to make the following changes clearer.
1271 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1272 This change doesn't affect the value now, but it may help remind
1273 future maintainers not to raise the value too much later.
1274 (SELECTION_QUANTUM): Remove, replacing with ...
1275 (selection_quantum): ... new function, which avoids overflow.
1276 All uses changed.
1277 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1278 assumption that selection length fits in 'int'.
1279 (x_reply_selection_request, x_handle_selection_request)
1280 (x_get_window_property, receive_incremental_selection)
1281 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1282 (lisp_data_to_selection_data, clean_local_selection_data):
1283 Use ptrdiff_t, not int, to record length of selection.
1284 (x_reply_selection_request, x_get_window_property)
1285 (receive_incremental_selection, x_property_data_to_lisp):
1286 Redo calculations to avoid overflow.
1287 (x_reply_selection_request): When sending hint, ceiling it at
1288 X_LONG_MAX rather than relying on wraparound overflow to send
1289 something.
1290 (x_get_window_property, receive_incremental_selection)
1291 (lisp_data_to_selection_data, x_property_data_to_lisp):
1292 Check for size-calculation overflow.
1293 (x_get_window_property, receive_incremental_selection)
1294 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1295 Don't store size until memory allocation succeeds.
1296 (x_get_window_property): Plug memory leak on memory exhaustion.
1297 Don't double-block input; malloc is safe here. Don't assume 2**34
1298 - 4 fits in unsigned long. Add an xassert to check
1299 XGetWindowProperty overflow. Be more careful about overflow
1300 calculations, and distinguish size from memory overflow better.
1301 (receive_incremental_selection): When tracing, don't assume
1302 unsigned int is less than INT_MAX.
1303 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1304 harmful) conversions of unsigned short to int.
1305 (lisp_data_to_selection_data): Don't assume that integers
1306 in the range -65535 through -1 fit in an X unsigned short.
1307 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1308 result parameters unless successful. Rely on cons_to_unsigned
1309 to report problems with elements; the old code wasn't right anyway.
1310 (x_check_property_data): Check for int overflow; we cannot use
1311 a wider type due to X limits.
1312 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1313
1314 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1315
1316 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1317 (x_term_init): Check for size calculation overflow.
1318 (x_color_cells): Don't store size until memory allocation succeeds.
1319 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1320 Don't assume alloca size is less than MAX_ALLOCA.
1321 (x_term_init): Don't assume length fits in int (sprintf is limited
1322 to int size).
1323
1324 Use ptrdiff_t for composition IDs.
1325 * character.c (lisp_string_width):
1326 * composite.c (composition_table_size, n_compositions)
1327 (get_composition_id, composition_gstring_from_id):
1328 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1329 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1330 * window.c (Frecenter):
1331 Use ptrdiff_t, not int, for composition IDs.
1332 * composite.c (get_composition_id): Check for integer overflow.
1333 * composite.h: Adjust prototypes to match the above changes.
1334
1335 Use ptrdiff_t for hash table indexes.
1336 * category.c (hash_get_category_set):
1337 * ccl.c (ccl_driver):
1338 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1339 * coding.c (coding_system_charset_list, detect_coding_system):
1340 * coding.h (struct coding_system.id):
1341 * composite.c (get_composition_id, gstring_lookup_cache):
1342 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1343 * image.c (xpm_get_color_table_h):
1344 * lisp.h (hash_lookup, hash_put):
1345 * minibuf.c (Ftest_completion):
1346 Use ptrdiff_t for hash table indexes, not int (which is too
1347 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1348 32-bit --with-wide-int hosts).
1349
1350 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1351 Add a FIXME comment about memory leaks.
1352 (syms_of_charset): Don't assume xmalloc returns.
1353
1354 Don't assume that stated character widths fit in int.
1355 * character.c (Fchar_width, c_string_width, lisp_string_width):
1356 * character.h (CHAR_WIDTH):
1357 * indent.c (MULTIBYTE_BYTES_WIDTH):
1358 Use sanitize_char_width to avoid undefined and/or bad behavior
1359 with outlandish widths.
1360 * character.h (sanitize_tab_width): Rename from sanitize_width,
1361 now that we have two such functions. All uses changed.
1362 (sanitize_char_width): New inline function.
1363
1364 Don't assume that tab-width fits in int.
1365 * character.h (sanitize_width): New inline function.
1366 (SANE_TAB_WIDTH): New macro.
1367 (ASCII_CHAR_WIDTH): Use it.
1368 * indent.c (sane_tab_width): Remove. All uses replaced by
1369 SANE_TAB_WIDTH (current_buffer).
1370 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1371
1372 * fileio.c: Integer overflow issues with file modes.
1373 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1374
1375 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1376 Remove unreachable code.
1377 (read_hex, load_charset_map_from_file): Check for integer overflow.
1378
1379 * xterm.c: don't go over XClientMessageEvent limit
1380 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1381 (x_send_scroll_bar_event): Likewise. Check that the size does not
1382 exceed limits imposed by XClientMessageEvent, as well as the usual
1383 ptrdiff_t and size_t limits.
1384
1385 * keyboard.c: Overflow, signedness and related fixes.
1386 (make_lispy_movement): Use same integer type in forward decl
1387 that is used in the definition.
1388 (read_key_sequence, keyremap_step):
1389 Change bufsize argument back to int, undoing my 2011-03-30 change.
1390 We prefer signed types, and int is wide enough here.
1391 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1392 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1393 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1394 length, not size_t. Use ptrdiff_t for index, not int.
1395 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1396 possibility of integer overflow.
1397
1398 Overflow, signedness and related fixes for images.
1399
1400 * dispextern.h (struct it.stack[0].u.image.image_id)
1401 (struct_it.image_id, struct image.id, struct image_cache.size)
1402 (struct image_cache.used, struct image_cache.ref_count):
1403 * gtkutil.c (update_frame_tool_bar):
1404 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1405 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1406 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1407 * nsmenu.m (update_frame_tool_bar):
1408 * xdisp.c (calc_pixel_width_or_height):
1409 * xfns.c (image_cache_refcount):
1410 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1411 on typical 64-bit hosts.
1412
1413 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1414 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1415 Omit unnecessary casts to int.
1416 (parse_image_spec): Check that integers fall into 'int' range
1417 when the callers expect that.
1418 (image_ascent): Redo ascent calculation to avoid int overflow.
1419 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1420 (lookup_image): Remove unnecessary tests.
1421 (xbm_image_p): Locals are now of int, not EMACS_INT,
1422 since parse_image_check makes sure they fit into int.
1423 (png_load, gif_load, svg_load_image):
1424 Prefer int to unsigned where either will do.
1425 (tiff_handler): New function, combining the cores of the
1426 old tiff_error_handler and tiff_warning_handler.
1427 This function is rewritten to use vsnprintf and thereby avoid
1428 stack buffer overflows. It uses only the features of vsnprintf
1429 that are common to both POSIX and native Microsoft.
1430 (tiff_error_handler, tiff_warning_handler): Use it.
1431 (tiff_load, gif_load, imagemagick_load_image):
1432 Don't assume :index value fits in 'int'.
1433 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1434 (imagemagick_load_image): Check that crop parameters fit into
1435 the integer types that MagickCropImage accepts. Don't assume
1436 Vimagemagick_render_type has a nonnegative value. Don't assume
1437 size_t fits in 'long'.
1438 (gs_load): Use printmax_t to print the widest integers possible.
1439 Check for integer overflow when computing image height and width.
1440
1441 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1442
1443 * xdisp.c (redisplay_window): Don't force window start if point
1444 will be invisible in the resulting window. (Bug#9324)
1445
1446 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1449 the display spec is of the form `(space ...)'.
1450 (handle_display_spec): Return the value returned by
1451 handle_single_display_spec, not just 1 or zero.
1452 (handle_single_display_spec): If the display spec is of the form
1453 `(space ...)', and specifies display in the text area, return 2
1454 rather than 1.
1455 (try_cursor_movement): Check for the need to scroll more
1456 accurately, and prefer exact match for point under bidi.
1457 Don't advance `row' beyond the last row of the window.
1458
1459 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1460 into disp_prop; all users changed.
1461
1462 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1463 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1464 for the text covered by the display property.
1465
1466 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1467
1468 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1469 Change return value to nil.
1470 (Frecord_buffer): Delete unused function.
1471
1472 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1473
1474 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1475 buffers, return left-to-right.
1476 (set_cursor_from_row): Consider candidate row a win if its glyph
1477 represents a newline and point is on that newline. Fixes cursor
1478 positioning on the newline at EOL of R2L text within L2R
1479 paragraph, and vice versa.
1480 (try_cursor_movement): Check continued rows, in addition to
1481 continuation rows. Fixes unwarranted scroll when point enters a
1482 continued line of R2L text within an L2R paragraph, or vice versa.
1483 (cursor_row_p): Consider the case of point being equal to
1484 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1485 from the end of a short line to the beginning of a continued line
1486 of R2L text within L2R paragraph.
1487 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1488 composed characters.
1489
1490 * bidi.c (bidi_check_type): Use xassert.
1491 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1492 members.
1493
1494 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1495
1496 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1497 a character.
1498
1499 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1500
1501 * nsfont.m (ns_otf_to_script): Fix typo.
1502
1503 2011-08-22 Kenichi Handa <handa@m17n.org>
1504
1505 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1506 extra slot even if the purpose is char-code-property-table.
1507
1508 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1509
1510 * xdisp.c (redisplay_window): When computing centering_position,
1511 account for the height of the header line. (Bug#8874)
1512
1513 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1514 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1515 candidate is selected by the mouse, and that candidate has a
1516 composed character under the mouse.
1517
1518 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1519 coordinates reported by pos-visible-in-window-p for a composed
1520 character in column zero.
1521
1522 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1523
1524 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1525
1526 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1527
1528 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1529 consider it a hit if to_charpos is anywhere in the range of the
1530 composed buffer positions.
1531
1532 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1533
1534 * image.c (gif_load): Don't assume that each subimage has the same
1535 dimensions as the base image. Handle disposal method that is
1536 "undefined" by the gif spec (Bug#9335).
1537
1538 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1539
1540 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1541 (Fcondition_case): Document `debug' symbol in error handler.
1542
1543 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1544
1545 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1546 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1547 from an Org mode buffer to a Speedbar frame.
1548
1549 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1550 a composition, take its buffer position from IT->cmp_it.charpos.
1551 Fixes cursor positioning at the beginning of a line that begins
1552 with a composed character.
1553
1554 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1555
1556 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1557 character bidirectional type, use STRONG_L instead. Fixes crashes
1558 in a buffer produced by `describe-categories'.
1559
1560 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1561 members before the level stack, so they would be saved and
1562 restored when copying iterator state. Fixes incorrect reordering
1563 around TABs covered by display properties.
1564
1565 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1566
1567 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1568
1569 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1570
1571 * eval.c (internal_condition_case, internal_condition_case_1)
1572 (internal_condition_case_2, internal_condition_case_n):
1573 Remove unnecessary aborts (Bug#9081).
1574
1575 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1576
1577 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1578 has no `load' handler, try opening the file locally. (Bug#9311)
1579
1580 2011-08-16 Ken Brown <kbrown@cornell.edu>
1581
1582 * gmalloc.c: Expand comment.
1583
1584 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1585
1586 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1587 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1588
1589 2011-08-16 Ken Brown <kbrown@cornell.edu>
1590
1591 Fix memory allocation problems in Cygwin build (Bug#9273).
1592
1593 * unexcw.c ( __malloc_initialized): Declare external variable.
1594 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1595
1596 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1597 New variables.
1598 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1599 dumped emacs.
1600 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1601 in the static heap.
1602 [CYGWIN] (special_realloc): New function.
1603 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1604 requests to realloc storage in the static heap.
1605
1606 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * bidi.c (bidi_initialize): Remove unused local.
1609
1610 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1611
1612 * bidimirror.h:
1613 * biditype.h: Remove file.
1614 * makefile.w32-in ($(BLD)/bidi.$(O)):
1615 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1616
1617 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1618
1619 * chartab.c: Improve commentary for the uniprop_table API.
1620
1621 * bidi.c (bidi_paragraph_init): Support zero value of
1622 bidi_ignore_explicit_marks_for_paragraph_level.
1623 (bidi_initialize): Use uniprop_table instead of including
1624 biditype.h and bidimirror.h.
1625
1626 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1627 coordinates of the iterator when restoring from ppos_it.
1628 (Bug#9296)
1629
1630 2011-08-14 Kenichi Handa <handa@m17n.org>
1631
1632 * process.c (create_process): Call setup_process_coding_systems
1633 after the pid of the process is set to -1 (Bug#8162).
1634
1635 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1636
1637 * xdisp.c (move_it_in_display_line_to): Don't invoke
1638 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1639 ppos_it. Fixes vertical cursor motion when line beginning is
1640 covered by an image. (Bug#9296)
1641
1642 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1643
1644 * nsterm.h (ns_run_ascript): Declare.
1645 (NSAPP_DATA2_RUNASSCRIPT): Define.
1646
1647 * nsfns.m (as_script, as_result, as_status): New static variables.
1648 (ns_run_ascript): New function.
1649 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1650 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1651 the event loop. Get status from as_status (Bug#7276).
1652
1653 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1654 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1655 the event loop (Bug#7276).
1656
1657 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1658
1659 * gnutls.c (QCgnutls_bootprop_priority)
1660 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1661 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1662 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1663 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1664 (QCgnutls_bootprop_verify_hostname_error)
1665 (QCgnutls_bootprop_callbacks_verify): Rename from
1666 Qgnutls_bootprop_..., all uses changed.
1667
1668 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1669 uses changed.
1670
1671 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 * xfaces.c (Qframe_set_background_mode): Now static.
1674 * dispextern.h (Qframe_set_background_mode): Remove decl.
1675
1676 * process.c (Fnetwork_interface_info): Declare local only if needed.
1677
1678 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1679
1680 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1681 (Fnetwork_interface_list): Allocate in increments of bytes instead
1682 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1683 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1684 sockaddr.
1685 (struct ifflag_def): notrailers is smart on OSX.
1686 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1687 Get hardware address with getifaddrs if available.
1688
1689 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1690
1691 * xdisp.c (iterate_out_of_display_property): xassert that
1692 IT->position is set to within IT->object's boundaries. Break from
1693 the loop as soon as EOB is reached; avoids infloops in redisplay
1694 when IT->position is set up wrongly due to some bug.
1695 Set IT->current to match the bidi iterator unconditionally.
1696 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1697 entry. Force push_it to save on the stack the current
1698 buffer/string position, to be restored by pop_it. Fix flags in
1699 the iterator structure wrt the object coming from a display
1700 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1701 properties. (Bug#9284)
1702
1703 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1704
1705 * fontset.c (fontset_get_font_group): Add proper type checks.
1706 (Bug#9172)
1707
1708 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1709
1710 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1711 and LC_VERSION_MIN_MACOSX.
1712 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1713 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1714
1715 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1716
1717 * xdisp.c (forward_to_next_line_start): Allow to use the
1718 no-display-properties-and-no-overlays under bidi display.
1719 Set disp_pos in the bidi iterator to avoid searches for display
1720 properties and overlays.
1721
1722 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1723
1724 * editfns.c (Fset_time_zone_rule): Document relationship with the
1725 setenv function.
1726
1727 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1728 the font entity extracted from the cache (Bug#8109).
1729
1730 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1731
1732 * composite.c (autocmp_chars): Don't reset point. That is done by
1733 restore_point_unwind (Bug#5984).
1734
1735 2011-08-07 Juri Linkov <juri@jurta.org>
1736
1737 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1738 to show the arg `TIME' instead of `TIMEVAL'.
1739
1740 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1743 display property strides EOL and includes a newline, as in
1744 longlines-mode. (Bug#9254)
1745 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1746 word-wrap under bidirectional display. (Bug#9224)
1747
1748 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1749 is non-zero, even if the data buffer is NULL. Fixes a crash in
1750 vertical-motion with longlines-mode. (Bug#9254)
1751
1752 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1753
1754 * bidi.c <bidi_cache_total_alloc>: Now static.
1755 (bidi_initialize): Initialize bidi_cache_total_alloc.
1756
1757 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1758 cache. (Bug#9221)
1759
1760 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1761 amount allocated this far in `bidi_cache_total_alloc'.
1762 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1763 non-zero, only free the data buffer without restoring the cache
1764 contents. All callers changed.
1765
1766 * dispextern.h (bidi_unshelve_cache): Update prototype.
1767
1768 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1769 (move_it_in_display_line, move_it_to)
1770 (move_it_vertically_backward, move_it_by_lines): Replace the call
1771 to xfree to an equivalent call to bidi_unshelve_cache.
1772 (move_it_in_display_line_to): Fix logic of returning
1773 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1774
1775 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1776
1777 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1778 came from a string character with a `cursor' property. (Bug#9229)
1779
1780 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1781
1782 * Makefile.in (LIB_PTHREAD): New variable.
1783 (LIBES): Add LIB_PTHREAD (Bug#9216).
1784
1785 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1786 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1787
1788 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1789
1790 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1791
1792 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1793
1794 * xterm.c (x_find_topmost_parent): New function.
1795 (x_set_frame_alpha): Find topmost parent window with
1796 x_find_topmost_parent and set the property there also (bug#9181).
1797 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1798
1799 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * callproc.c (Fcall_process): Avoid vfork clobbering
1802 the local vars buffer, coding_systems, current_dir.
1803
1804 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1805
1806 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1807
1808 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1811 so that it is not optimized away.
1812
1813 * xdisp.c (compute_display_string_pos): Remove unused local.
1814
1815 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1816
1817 Fix slow cursor motion and scrolling in large buffers with
1818 selective display, like Org Mode buffers. (Bug#9218)
1819
1820 * dispextern.h (struct bidi_it): New member disp_prop_p.
1821
1822 * xdisp.c: Remove one-slot cache of display string positions.
1823 (compute_display_string_pos): Accept an additional argument
1824 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1825 for a display string or property. If found, set DISP_PROP_P
1826 non-zero.
1827
1828 * bidi.c (bidi_fetch_char): Accept an additional argument
1829 DISP_PROP_P, and pass it to compute_display_string_pos.
1830 Only handle text covered by a display string if DISP_PROP_P is returned
1831 non-zero. All callers of bidi_fetch_char changed.
1832
1833 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1834
1835 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1836
1837 2010-12-03 Don March <don@ohspite.net>
1838
1839 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1840 last character M-[char] is translated to ESC [char] (bug#7541).
1841
1842 2011-08-02 Kenichi Handa <handa@m17n.org>
1843
1844 * lisp.h (uniprop_table): Extern it.
1845
1846 * chartab.c (uniprop_table): Make it non-static.
1847
1848 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1849
1850 * xdisp.c (forward_to_next_line_start): Accept additional argument
1851 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1852 on the newline.
1853 (reseat_at_next_visible_line_start): Use the bidi iterator state
1854 returned by forward_to_next_line_start to restore the state of
1855 it->bidi_it after backing up to previous newline. (Bug#9212)
1856
1857 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1858
1859 * regex.c (re_comp): Protoize.
1860 (re_exec): Fix return type.
1861 (regexec): Fix type of `ret'. (Bug#9203)
1862
1863 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1864
1865 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1866 This is needed if max-image-size is a floating-point number.
1867
1868 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1869
1870 * print.c (print_object): Print empty symbol as ##.
1871
1872 * lread.c (read1): Read ## as empty symbol.
1873
1874 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1875
1876 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1877 setting frame foreground color (Bug#9175).
1878 (x_set_background_color): Likewise.
1879
1880 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1881 contents (Bug#9176).
1882 (EmacsTooltip -init): Remove bezels and add shadows to
1883 tooltip windows.
1884
1885 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1886 or scroll bar (Bug#8470).
1887
1888 * nsfont.m (nsfont_open): Remove assignment to voffset and
1889 unnecessary vars hshink, expand, hd, full_height, min_height.
1890 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1891
1892 * nsterm.h (nsfont_info): Remove voffset field.
1893
1894 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1895
1896 Implement strike-through and overline on NextStep (Bug#8863).
1897
1898 * nsfont.m (nsfont_open): Use underline position provided by font,
1899 instead of hard-coded value of 2.
1900 (nsfont_draw): Call ns_draw_text_decoration instead.
1901
1902 * nsterm.h: Add declaration for ns_draw_text_decoration.
1903
1904 * nsterm.m (ns_draw_text_decoration): New function for drawing
1905 underline, overline, and strike-through.
1906 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1907 ns_draw_text_decoration. Change treatment of cursor drawing to
1908 accommodate underlining, etc.
1909
1910 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1911
1912 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1913 default.
1914
1915 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1918 Without this fix, if a signal arrives just after memory fills up,
1919 'malloc' might be invoked reentrantly.
1920
1921 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1922 In other words, assume that every image size is allowed, on non-X
1923 hosts. This assumption is probably wrong, but it lets Emacs compile.
1924
1925 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1926
1927 * regex.c (re_iswctype): Convert return values to boolean.
1928
1929 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1930
1931 * xdisp.c (compute_display_string_pos): Don't use cached display
1932 string position if the buffer had its restriction changed.
1933 (Bug#9184)
1934
1935 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1938
1939 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1940
1941 Integer signedness and overflow and related fixes. (Bug#9079)
1942
1943 * bidi.c: Integer size and overflow fixes.
1944 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1945 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1946 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1947 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1948 (bidi_find_other_level_edge):
1949 Use ptrdiff_t instead of EMACS_INT where either will do.
1950 This works better on 32-bit hosts configured --with-wide-int.
1951 (bidi_cache_ensure_space): Check for size-calculation overflow.
1952 Use % rather than repeated addition, for better worst-case speed.
1953 Don't set bidi_cache_size until after xrealloc returns, because it
1954 might not return.
1955 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1956 (bidi_cache_ensure_space): Also check that the bidi cache size
1957 does not exceed that of the largest Lisp string or buffer. See Eli
1958 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1959
1960 * alloc.c (__malloc_size_t): Remove.
1961 All uses replaced by size_t. See Andreas Schwab's note
1962 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1963
1964 * image.c: Improve checking for integer overflow.
1965 (check_image_size): Assume that f is nonnull, since
1966 it is always nonnull in practice. This is one less thing to
1967 worry about when checking for integer overflow later.
1968 (x_check_image_size): New function, which checks for integer
1969 overflow issues inside X.
1970 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1971 This removes the need for a memory_full check.
1972 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1973 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1974 (xbm_read_bitmap_data): Change locals back to 'int', since
1975 their values must fit in 'int'.
1976 (xpm_load_image, png_load, tiff_load):
1977 Invoke x_create_x_image_and_pixmap earlier,
1978 to avoid much needless work if the image is too large.
1979 (tiff_load): Treat overly large images as if
1980 x_create_x_image_and_pixmap failed, not as malloc failures.
1981 (gs_load): Use x_check_image_size.
1982
1983 * gtkutil.c: Omit integer casts.
1984 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1985 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1986
1987 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1988
1989 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1990 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1991 would wrongly return t on a 64-bit host.
1992
1993 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1994 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1995 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1996 and therefore cause GCC to emit a bogus diagnostic in some cases.
1997
1998 * image.c: Integer signedness and overflow and related fixes.
1999 This is not an exhaustive set of fixes, but it's time to
2000 record what I've got.
2001 (lookup_pixel_color, check_image_size): Remove redundant decls.
2002 (check_image_size): Don't assume that arbitrary EMACS_INT values
2003 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2004 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2005 (tiff_load, imagemagick_load_image):
2006 Check for overflow in size calculations.
2007 (x_create_x_image_and_pixmap): Remove unnecessary test for
2008 xmalloc returning NULL; that can't happen.
2009 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2010 (xpm_color_bucket): Use better integer hashing function.
2011 (xpm_cache_color): Don't possibly over-allocate memory.
2012 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2013 (gif_memory_source):
2014 Use ptrdiff_t, not int or size_t, to record sizes.
2015 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2016 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2017 either works, as we prefer signed integers.
2018 (tiff_read_from_memory, tiff_write_from_memory):
2019 Return tsize_t, not size_t, since that's what the TIFF API wants.
2020 (tiff_read_from_memory): Don't fail simply because the read would
2021 go past EOF; instead, return a short read.
2022 (tiff_load): Omit no-longer-needed casts.
2023 (Fimagemagick_types): Don't assume size fits into 'int'.
2024
2025 Improve hashing quality when configured --with-wide-int.
2026 * fns.c (hash_string): New function, taken from sxhash_string.
2027 Do not discard information about ASCII character case; this
2028 discarding is no longer needed.
2029 (sxhash-string): Use it. Change sig to match it. Caller changed.
2030 * lisp.h: Declare it.
2031 * lread.c (hash_string): Remove, since we now use fns.c's version.
2032 The fns.c version returns a wider integer if --with-wide-int is
2033 specified, so this should help the quality of the hashing a bit.
2034
2035 * emacs.c: Integer overflow minor fix.
2036 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2037 Define only if GNU_LINUX.
2038 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2039
2040 * dispnew.c: Integer signedness and overflow fixes.
2041 Remove unnecessary forward decls, that were a maintenance hassle.
2042 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2043 All uses changed.
2044 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2045 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2046 (prepare_desired_row, line_draw_cost):
2047 Use int, not unsigned, where either works.
2048 (save_current_matrix, restore_current_matrix):
2049 Use ptrdiff_t, not size_t, where either works.
2050 (init_display): Check for overflow more accurately, and without
2051 relying on undefined behavior.
2052
2053 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2054 Remove, replacing with the new symbols in lisp.h. All uses changed.
2055 * fileio.c (make_temp_name):
2056 * filelock.c (lock_file_1, lock_file):
2057 * xdisp.c (message_dolog):
2058 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2059 Use pMd etc. instead.
2060 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2061 replacing the pWIDE etc. symbols removed from editfns.c.
2062
2063 * keyboard.h (num_input_events): Now uintmax_t.
2064 This is (very slightly) less likely to mess up due to wraparound.
2065 All uses changed.
2066
2067 * buffer.c: Integer signedness fixes.
2068 (alloc_buffer_text, enlarge_buffer_text):
2069 Use ptrdiff_t rather than size_t when either will do, as we prefer
2070 signed integers.
2071
2072 * alloc.c: Integer signedness and overflow fixes.
2073 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2074 (__malloc_size_t): Default to size_t, not to int.
2075 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2076 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2077 Prefer ptrdiff_t to size_t when either would do, as we prefer
2078 signed integers.
2079 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2080 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2081 Now const. Initialize with values that are in range even if char
2082 is signed.
2083 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2084 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2085 These functions do the right thing with sizes > 2**32.
2086 (check_depth): Now ptrdiff_t, not int.
2087 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2088 Adjust to new way of storing sizes. Check for size overflow bugs
2089 in rest of code.
2090 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2091 slightly wrong anyway, as it missed one instance of
2092 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2093 (refill_memory_reserve): Omit needless cast to size_t.
2094 (mark_object_loop_halt): Mark as externally visible.
2095
2096 * xselect.c: Integer signedness and overflow fixes.
2097 (Fx_register_dnd_atom, x_handle_dnd_message):
2098 Use ptrdiff_t, not size_t, since we prefer signed.
2099 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2100 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2101 x_dnd_atoms_size and x_dnd_atoms_length.
2102
2103 * doprnt.c: Prefer signed to unsigned when either works.
2104 * eval.c (verror):
2105 * doprnt.c (doprnt):
2106 * lisp.h (doprnt):
2107 * xdisp.c (vmessage):
2108 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2109 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2110 prefer signed arithmetic to avoid comparison confusion.
2111 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2112 but is a bit tricky.
2113
2114 Assume freestanding C89 headers, string.h, stdlib.h.
2115 * data.c, doprnt.c, floatfns.c, print.c:
2116 Include float.h unconditionally.
2117 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2118 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2119 * regex.c: Likewise for stddef.h, string.h.
2120 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2121 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2122 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2123 (STDC_HEADERS): Remove obsolete defines.
2124 * sysdep.c: Include limits.h unconditionally.
2125
2126 Assume support for memcmp, memcpy, memmove, memset.
2127 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2128 * regex.c (memcmp, memcpy):
2129 Remove; we assume C89 now.
2130
2131 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2132 (__malloc_safe_bcopy): Remove; no longer needed.
2133
2134 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2135 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2136 well either way, and we prefer signed to unsigned.
2137
2138 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2139
2140 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2141 closes the connection while we're reading (bug#9182).
2142
2143 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2144
2145 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2146 are specified (Bug#9168).
2147
2148 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2149
2150 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2151 Found by GCC static checking and --with-wide-int on a 32-bit host.
2152
2153 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2154
2155 * xdisp.c (compute_display_string_pos): Fix logic of caching
2156 previous display string position. Initialize cached_prev_pos to
2157 -1. Fixes slow-down at the beginning of a buffer.
2158
2159 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2160
2161 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2162 for attrs[LFACE_FONTSET_INDEX].
2163
2164 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * xml.c (parse_region): Remove unused local
2167 that was recently introduced.
2168
2169 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2170
2171 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2172 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2173
2174 * xdisp.c (move_it_in_display_line_to): Record the best matching
2175 position for TO_CHARPOS while scanning the line, and restore it on
2176 exit if none of the characters scanned was an exact match.
2177 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2178 when exact match is impossible due to invisible text, and the
2179 lines are truncated.
2180
2181 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2182
2183 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2184 for OSX >= 10.7.
2185
2186 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2187
2188 Fix a significant slow-down of cursor motion with C-n, C-p,
2189 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2190 auto-repeat under bidi redisplay in fontified buffers.
2191 * xdisp.c (compute_stop_pos_backwards): New function.
2192 (next_element_from_buffer): Call compute_stop_pos_backwards to
2193 find a suitable prev_stop when we find ourselves before
2194 base_level_stop.
2195 (reseat): Don't look for prev_stop, as that could mean a very long
2196 run.
2197 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2198 <cached_disp_overlay_modiff>: Cache for last found display string
2199 position.
2200 (compute_display_string_pos): Return the cached position if asked
2201 about the same buffer in the same area of character positions, and
2202 the buffer wasn't changed since the time the display string
2203 position was cached.
2204
2205 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2206
2207 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2208 is an integer, which is important for empty lines. (Bug#9149)
2209
2210 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2211
2212 * frame.c (Fmodify_frame_parameters): In tty case, update the
2213 default face if necessary (Bug#4238).
2214
2215 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2216
2217 * editfns.c (Fstring_to_char): No need to explain what a character
2218 is in the docstring (Bug#6576).
2219
2220 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2221
2222 * xml.c (parse_region): Make sure we always return a tree.
2223
2224 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2225
2226 * xml.c (parse_region): If a document contains only comments,
2227 return that, too.
2228
2229 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2230
2231 * xml.c (make_dom): Return comments, too.
2232
2233 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 Port to OpenBSD.
2236 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2237 and the surrounding thread.
2238 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2239 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2240 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2241 timer goes off.
2242 * s/openbsd.h (BROKEN_SIGIO): Define.
2243 * unexelf.c (unexec) [__OpenBSD__]:
2244 Don't update the .mdebug section of the Alpha COFF symbol table.
2245
2246 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2247
2248 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2249 (bug#8460).
2250
2251 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2254 This fixes some race conditions on the permissions of any newly
2255 created file.
2256
2257 * alloc.c (valid_pointer_p): Use pipe, not open.
2258 This fixes some permissions issues when debugging.
2259
2260 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2261 If fchown fails to set both uid and gid, try to set just gid,
2262 as that is sometimes allowed. Adjust the file's mode to eliminate
2263 setuid or setgid bits that are inappropriate if fchown fails.
2264
2265 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2266
2267 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2268 to compare Lisp_Objects.
2269 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2270 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2271 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2272
2273 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2274
2275 * lread.c (read_integer): Unread even EOF character.
2276 (read1): Likewise. Properly record start position of symbol.
2277
2278 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2279 symbol character follows.
2280
2281 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2284 This works around a problem with the previous change to Fcopy_file.
2285 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2286 and without this change, GCC might complain about discarding
2287 fchown's return value.
2288
2289 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2290
2291 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2292
2293 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2296
2297 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2298
2299 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2300 it's used from the C level.
2301
2302 * process.c: Use the same condition for POLL_FOR_INPUT in both
2303 keyboard.c and process.c (bug#1858).
2304
2305 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2306
2307 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2308 (Fgnutls_boot): Use it.
2309
2310 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2311
2312 * doc.c (Fsubstitute_command_keys): Revert last change.
2313
2314 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2315
2316 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2317 quotes the next character, and doesn't affect other longer
2318 sequences (bug#8935).
2319
2320 * lread.c (syms_of_lread): Clarify that is isn't only
2321 `eval-buffer' and `eval-defun' that's affected by
2322 `lexical-binding' (bug#8460).
2323
2324 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2325
2326 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2327 bidi redisplay when a line includes both an image and is truncated.
2328
2329 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Fix minor problems found by static checking.
2332 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2333 (elsz): Now a signed constant, not a size_t var. We prefer signed
2334 types to unsigned, to avoid integer comparison confusion. Without
2335 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2336 "cannot optimize loop, the loop counter may overflow", a symptom
2337 of the confusion.
2338 * indent.c (Fvertical_motion): Mark locals as initialized.
2339 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2340
2341 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2342
2343 * search.c (Fre_search_backward): Mention `case-fold-search' in
2344 all the re_search_* functions (bug#8138).
2345
2346 * keyboard.c (Fopen_dribble_file): Document when the file is
2347 closed (bug#8056).
2348
2349 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2350
2351 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2352 bidi_cache_idx.
2353
2354 Support bidi reordering of display and overlay strings.
2355 * xdisp.c (compute_display_string_pos)
2356 (compute_display_string_end): Accept additional argument STRING.
2357 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2358 (reseat_to_string): Initialize bidi_it->string.s and
2359 bidi_it->string.schars.
2360 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2361 NULL (avoids a crash in bidi_paragraph_init).
2362 Initialize itb.string.lstring.
2363 (init_iterator): Call bidi_init_it only of a valid
2364 buffer position was specified. Initialize paragraph_embedding to
2365 L2R.
2366 (reseat_to_string): Initialize the bidi iterator.
2367 (display_string): If we need to ignore text properties of
2368 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2369 original value of -1 will not work with bidi.)
2370 (compute_display_string_pos): First arg is now struct
2371 `text_pos *'; all callers changed. Support display properties on
2372 Lisp strings.
2373 (compute_display_string_end): Support display properties on Lisp
2374 strings.
2375 (init_iterator, reseat_1, reseat_to_string): Initialize the
2376 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2377 when iterating on a string not from display properties).
2378 (compute_display_string_pos, compute_display_string_end):
2379 Fix calculation of the object to scan. Fixes an error when using
2380 arrow keys.
2381 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2382 base_level_stop; instead, set base_level_stop to BEGV.
2383 Fixes crashes in vertical-motion.
2384 (next_element_from_buffer): Improve commentary for when
2385 the iterator is before prev_stop.
2386 (init_iterator): Initialize bidi_p from the default value of
2387 bidi-display-reordering, not from buffer-local value. Use the
2388 buffer-local value only if initializing for buffer iteration.
2389 (handle_invisible_prop): Support invisible properties on strings
2390 that are being bidi-reordered.
2391 (set_iterator_to_next): Support bidi reordering of C strings and
2392 Lisp strings.
2393 (next_element_from_string): Support bidi reordering of Lisp
2394 strings.
2395 (handle_stop_backwards): Support Lisp strings as well.
2396 (display_string): Support display of R2L glyph rows.
2397 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2398 (init_iterator): Don't initialize it->bidi_p for strings
2399 here.
2400 (reseat_to_string): Initialize it->bidi_p for strings here.
2401 (next_element_from_string, next_element_from_c_string)
2402 (next_element_from_buffer): Add xassert's for correspondence
2403 between IT's object being iterated and it->bidi_it.string
2404 structure.
2405 (face_before_or_after_it_pos): Support bidi iteration.
2406 (next_element_from_c_string): Handle the case of the first string
2407 character that is not the first one in the visual order.
2408 (get_visually_first_element): New function, refactored from common
2409 parts of next_element_from_buffer, next_element_from_string, and
2410 next_element_from_c_string.
2411 (tool_bar_lines_needed, redisplay_tool_bar)
2412 (display_menu_bar): Force left-to-right direction. Add a FIXME
2413 comment for making that be controlled by a user option.
2414 (push_it, pop_it): Save and restore the state of the
2415 bidi iterator. Save and restore the bidi_p flag.
2416 (pop_it): Iterate out of display property for string iteration as
2417 well.
2418 (iterate_out_of_display_property): Support iteration over strings.
2419 (handle_single_display_spec): Set up it->bidi_it for iteration
2420 over a display string, and call bidi_init_it.
2421 (handle_single_display_spec, next_overlay_string)
2422 (get_overlay_strings_1, push_display_prop): Set up the bidi
2423 iterator for displaying display or overlay strings.
2424 (forward_to_next_line_start): Don't use the shortcut if
2425 bidi-iterating.
2426 (back_to_previous_visible_line_start): If handle_display_prop
2427 pushed the iterator stack, restore the internal state of the bidi
2428 iterator by calling bidi_pop_it same number of times.
2429 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2430 and we are bidi-iterating, don't decrement the iterator position;
2431 instead, set the first_elt flag in the bidi iterator, to produce
2432 the same effect.
2433 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2434 (push_display_prop): xassert that we are iterating a buffer.
2435 (push_it, pop_it): Save and restore paragraph_embedding member.
2436 (handle_single_display_spec, next_overlay_string)
2437 (get_overlay_strings_1, reseat_1, reseat_to_string)
2438 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2439 correctly. Don't assume unibyte strings are not bidi-reordered.
2440 (compute_display_string_pos)
2441 (compute_display_string_end): Fix handling the case of C string.
2442 (push_it, pop_it): Save and restore from_disp_prop_p.
2443 (handle_single_display_spec, push_display_prop): Set the
2444 from_disp_prop_p flag.
2445 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2446 (pop_it): Call iterate_out_of_display_property only if we are
2447 popping after iteration over a string that came from a display
2448 property. Fix a typo in popping stretch info. Add an assertion
2449 for verifying that the iterator position is in sync with the bidi
2450 iterator.
2451 (handle_single_display_spec, get_overlay_strings_1)
2452 (push_display_prop): Fix initialization of paragraph direction for
2453 string when that of the parent object is not yet determined.
2454 (reseat_1): Call bidi_init_it to resync the bidi
2455 iterator with IT's position. (Bug#7616)
2456 (find_row_edges): If ROW->start.pos gives position
2457 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2458 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2459 Reset the from_disp_prop_p flag.
2460 (SAVE_IT, RESTORE_IT): New macros.
2461 (pos_visible_p, face_before_or_after_it_pos)
2462 (back_to_previous_visible_line_start)
2463 (move_it_in_display_line_to, move_it_in_display_line)
2464 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2465 (try_scrolling, redisplay_window, display_line): Use them when
2466 saving a temporary copy of the iterator and restoring it back.
2467 (back_to_previous_visible_line_start, reseat_1)
2468 (init_iterator): Empty the bidi cache "stack".
2469 (move_it_in_display_line_to): If iterator ended up at
2470 EOL, but we never saw any buffer positions smaller than
2471 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2472 motion in bidi-reordered lines.
2473 (move_it_in_display_line_to): Record prev_method and prev_pos
2474 immediately before the call to set_iterator_to_next. Fixes cursor
2475 motion in bidi-reordered lines with stretch glyphs and strings
2476 displayed in margins. (Bug#8133) (Bug#8867)
2477 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2478 TO_CHARPOS.
2479 (pos_visible_p): Support positions in bidi-reordered lines.
2480 Save and restore bidi cache.
2481
2482 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2483 (bidi_paragraph_info): Delete unused struct.
2484 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2485 (bidi_cache_start): New variable.
2486 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2487 to zero.
2488 (bidi_cache_fetch_state, bidi_cache_search)
2489 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2490 (bidi_cache_find, bidi_peek_at_next_level)
2491 (bidi_level_of_next_char, bidi_find_other_level_edge)
2492 (bidi_move_to_visually_next): Compare cache index with
2493 bidi_cache_start rather than with zero.
2494 (bidi_fetch_char): Accept new argument STRING; all callers
2495 changed. Support iteration over a string. Support strings with
2496 display properties. Support unibyte strings. Fix the type of
2497 `len' according to what STRING_CHAR_AND_LENGTH expects.
2498 (bidi_paragraph_init, bidi_resolve_explicit_1)
2499 (bidi_resolve_explicit, bidi_resolve_weak)
2500 (bidi_level_of_next_char, bidi_move_to_visually_next):
2501 Support iteration over a string.
2502 (bidi_set_sor_type, bidi_resolve_explicit_1)
2503 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2504 can now be zero (for strings); special values 0 and -1 were
2505 changed to -1 and -2, respectively.
2506 (bidi_char_at_pos): New function.
2507 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2508 Call it instead of FETCH_MULTIBYTE_CHAR.
2509 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2510 initialized to valid values.
2511 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2512 values.
2513 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2514 the test for valid cached positions. Fix the logic for looking up
2515 the sentinel state in the cache. GCPRO the Lisp string we are
2516 iterating.
2517 (bidi_push_it, bidi_pop_it): New functions.
2518 (bidi_initialize): Initialize the bidi cache start stack pointer.
2519 (bidi_cache_ensure_space): New function, refactored from part of
2520 bidi_cache_iterator_state. Don't assume the required size is just
2521 one BIDI_CACHE_CHUNK away.
2522 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2523 (bidi_count_bytes, bidi_char_at_pos): New functions.
2524 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2525 always valid if bidi_cache_idx is valid.
2526 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2527 is valid if it's going to be used.
2528 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2529 (bidi_cache_fetch_state, bidi_cache_search)
2530 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2531 (bidi_cache_iterator_state, bidi_cache_find)
2532 (bidi_find_other_level_edge, bidi_cache_start_stack):
2533 All variables related to cache indices are now EMACS_INT.
2534
2535 * dispextern.h (struct bidi_string_data): New structure.
2536 (struct bidi_it): New member `string'. Make flag members be 1-bit
2537 fields, and put them last in the struct.
2538 (compute_display_string_pos, compute_display_string_end):
2539 Update prototypes.
2540 (bidi_push_it, bidi_pop_it): Add prototypes.
2541 (struct iterator_stack_entry): New members bidi_p,
2542 paragraph_embedding, and from_disp_prop_p.
2543 (struct it): Member bidi_p is now a bit field 1 bit wide.
2544 (bidi_shelve_cache, bidi_unshelve_cache):
2545 Declare prototypes.
2546
2547 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2548 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2549 and vector-like objects.
2550
2551 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2552 cache around display iteration.
2553
2554 * window.c (Fwindow_end, window_scroll_pixel_based)
2555 (displayed_window_lines, Frecenter): Save and restore the bidi
2556 cache around display iteration.
2557
2558 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2559
2560 * editfns.c (Fdelete_region): Clarify the use of the named
2561 parameters (bug#6788).
2562
2563 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2564
2565 * indent.c (Fvertical_motion): Set and restore w->pointm when
2566 saving and restoring the window's buffer (Bug#9006).
2567
2568 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2569
2570 * editfns.c (Fstring_to_char): Clarify just what is returned
2571 (bug#6576). Text by Eli Zaretskii.
2572
2573 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2574
2575 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2576
2577 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2578
2579 * buffer.c (mmap_find): Fix a typo.
2580
2581 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2582
2583 Fix execution of x selection hooks.
2584 * xselect.c (Qx_lost_selection_functions)
2585 (Qx_sent_selection_functions): New vars.
2586 (syms_of_xselect): DEFSYM them.
2587 (x_handle_selection_request): Pass Qx_sent_selection_functions
2588 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2589 (x_handle_selection_clear,x_clear_frame_selections):
2590 Pass Qx_lost_selection_functions rather than
2591 Vx_lost_selection_functions to Frun_hook_with_args.
2592
2593 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2594
2595 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2596 The old code sometimes used this field without initializing it.
2597
2598 * alloc.c (gc_sweep): Don't read past end of array.
2599 In theory, the old code could also have corrupted Emacs internals,
2600 though it'd be very unlikely.
2601
2602 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2603
2604 * character.c (Fcharacterp): Don't advertise optional ignored
2605 argument. (Bug#4026)
2606
2607 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2608
2609 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2610 key" (bug#4257).
2611
2612 * window.c (Fset_window_start): Doc fix (bug#4199).
2613 (Fset_window_hscroll): Ditto.
2614
2615 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 Fix minor new problems caught by GCC 4.6.1.
2618 * term.c (init_tty): Remove unused local.
2619 * xsettings.c (store_monospaced_changed): Define this function only
2620 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2621 not used otherwise.
2622
2623 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2624
2625 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2626
2627 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2628
2629 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2630 are the mini-buffer and the echo area (bug#3320).
2631
2632 * term.c (init_tty): Remove support for supdup, c10 and perq
2633 terminals, which are no longer supported (bug#1482).
2634
2635 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2636
2637 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2638
2639 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2640
2641 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2642 for non-popups (Bug#3642).
2643
2644 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2645
2646 * alloc.c (reset_malloc_hooks): Protoize.
2647 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2648 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2649 * cm.c (losecursor): Likewise.
2650 * data.c (fmod): Likewise.
2651 * dispnew.c (swap_glyphs_in_rows): Likewise.
2652 * emacs.c (memory_warning_signal): Likewise.
2653 * floatfns.c (float_error): Likewise.
2654 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2655 (otf_open, font_otf_capability, generate_otf_features)
2656 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2657 Likewise.
2658 * image.c (pbm_read_file): Likewise.
2659 * indent.c (string_display_width): Likewise.
2660 * intervals.c (check_for_interval, search_for_interval)
2661 (inc_interval_count, count_intervals, root_interval)
2662 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2663 * lread.c (defalias): Likewise.
2664 * ralloc.c (r_alloc_check): Likewise.
2665 * regex.c (set_image_of_range_1, set_image_of_range)
2666 (regex_grow_registers): Likewise.
2667 * sysdep.c (strerror): Likewise.
2668 * termcap.c (valid_filename_p, tprint, main): Likewise.
2669 * tparam.c (main): Likewise.
2670 * unexhp9k800.c (run_time_remap, save_data_space)
2671 (update_file_ptrs, read_header, write_header, calculate_checksum)
2672 (copy_file, copy_rest, display_header): Likewise.
2673 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2674 Likewise.
2675 * xdisp.c (check_it): Likewise.
2676 * xfaces.c (register_color, unregister_color, unregister_colors):
2677 Likewise.
2678 * xfns.c (print_fontset_result): Likewise.
2679 * xrdb.c (member, fatal, main): Likewise.
2680
2681 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 Fix minor problems found by static checking (Bug#9031).
2684 * chartab.c (char_table_set_range, map_sub_char_table):
2685 Remove unused locals.
2686 (uniprop_table): Now static.
2687 * composite.c (_work_char): Remove unused static var.
2688
2689 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2690
2691 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2692
2693 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2694
2695 * gtkutil.c (qttip_cb): Remove code without function.
2696
2697 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2698
2699 * w32.c (pthread_sigmask): New stub.
2700
2701 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 Use pthread_sigmask, not sigprocmask (Bug#9010).
2704 sigprocmask is portable only for single-threaded applications, and
2705 Emacs can be multi-threaded when it uses GTK.
2706 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2707 (LIBES): Use it.
2708 * callproc.c (Fcall_process):
2709 * process.c (create_process):
2710 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2711 Use pthread_sigmask, not sigprocmask.
2712
2713 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2714
2715 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2716 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2717 wrong (Bug#8591).
2718
2719 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2720
2721 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2722 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2723 (xg_hide_tooltip): Fix comment.
2724
2725 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2726 in registerServicesMenuSendTypes.
2727 (validRequestorForSendType): Don't check ns_return_types.
2728
2729 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2730 ns_return_type.
2731
2732 2011-07-08 Jason Rumney <jasonr@gnu.org>
2733
2734 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2735 frame struct members of non-existent frames (Bug#6284).
2736
2737 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2738
2739 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2740 variable firstTime not needed on OSX >= 10.6.
2741 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2742 >= 10.5. Use setKnobProportion, setDoubleValue.
2743
2744 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2745 (MAC_OS_X_VERSION_10_5): Define if not defined.
2746 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2747 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2748 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2749
2750 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2751 cString and lossyCString on OSX >= 10.4
2752
2753 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2754 sizeToFit on OSX >= 10.2.
2755
2756 * nsimage.m (allocInitFromFile): Don't use deprecated method
2757 bestRepresentationForDevice on OSX >= 10.6.
2758
2759 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2760 to avoid warning.
2761
2762 * emacs.c: Declare unexec_init_emacs_zone.
2763
2764 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2765
2766 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2767
2768 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2769 on svcsMenu (Bug#8842).
2770
2771 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2772 ns_return_types.
2773 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2774
2775 * nsterm.m (QUTF8_STRING): Declare.
2776 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2777 (validRequestorForSendType): Return type is (id).
2778 Change indexOfObjectIdenticalTo to indexOfObject.
2779 Check if we have local selection before returning self (Bug#8842).
2780 (writeSelectionToPasteboard): Put local selection into paste board
2781 if we have a local selection (Bug#8842).
2782 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2783
2784 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2785 (ns_get_local_selection): Declare.
2786
2787 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2788
2789 * keymap.c (describe_map_tree): Don't insert a double newline at
2790 the end of the buffer (bug#1169) and return whether we inserted
2791 something.
2792
2793 * callint.c (Fcall_interactively): Change "reading args" to
2794 "providing args" to try to clarify what it does (bug#1010).
2795
2796 2011-07-07 Kenichi Handa <handa@m17n.org>
2797
2798 * composite.c (composition_compute_stop_pos): Ignore a static
2799 composition starting before CHARPOS (Bug#8915).
2800
2801 * xdisp.c (handle_composition_prop): Likewise.
2802
2803 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2804
2805 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2806 (Bug#9015)
2807
2808 2011-07-07 Kenichi Handa <handa@m17n.org>
2809
2810 * character.h (unicode_category_t): New enum type.
2811
2812 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2813 (Qchar_code_property_table): New variable.
2814 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2815 (UNIPROP_COMPRESSED_FORM_P): New macros.
2816 (char_table_ascii): Uncompress the compressed values.
2817 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2818 Uncompress the compressed values.
2819 (sub_char_table_ref_and_range): Likewise.
2820 (char_table_ref_and_range): Uncompress the compressed values.
2821 (sub_char_table_set): New arg is_uniprop. Callers changed.
2822 Uncompress the compressed values.
2823 (sub_char_table_set_range): Args changed. Callers changed.
2824 (char_table_set_range): Adjuted for the above change.
2825 (map_sub_char_table): Delete args default_val and parent. Add arg
2826 top. Give decoded values to a Lisp function.
2827 (map_char_table): Adjust for the above change. Give decoded
2828 values to a Lisp function. Gcpro more variables.
2829 (uniprop_table_uncompress)
2830 (uniprop_decode_value_run_length): New functions.
2831 (uniprop_decoder, uniprop_decoder_count): New variables.
2832 (uniprop_get_decoder, uniprop_encode_value_character)
2833 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2834 New functions.
2835 (uniprop_encoder, uniprop_encoder_count): New variables.
2836 (uniprop_get_encoder, uniprop_table)
2837 (Funicode_property_table_internal, Fget_unicode_property_internal)
2838 (Fput_unicode_property_internal): New functions.
2839 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2840 Sunicode_property_table_internal, Sget_unicode_property_internal,
2841 and Sput_unicode_property_internal. Defvar_lisp
2842 char-code-property-alist.
2843
2844 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2845 Vunicode_category_table.
2846
2847 * font.c (font_range): Adjust for the change of
2848 Vunicode_category_table.
2849
2850 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2851
2852 * m/iris4d.h: Remove file, move contents ...
2853 * s/irix6-5.h: ... here.
2854
2855 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 Remove unportable assumption about struct layout (Bug#8884).
2858 * alloc.c (mark_buffer):
2859 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2860 (clone_per_buffer_values): Don't assume that
2861 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2862 This isn't true in general, and it's particularly not true
2863 if Emacs is configured with --with-wide-int.
2864 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2865 New macros, used in the buffer.c change.
2866
2867 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * xsettings.c: Use both GConf and GSettings if both are available.
2870 (store_config_changed_event): Add comment.
2871 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2872 (store_tool_bar_style_changed): New functions.
2873 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2874 (struct xsettings): Move font inside HAVE_XFT.
2875 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2876 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2877 Move inside HAVE_XFT.
2878 (something_changed_gsettingsCB): Rename from something_changedCB.
2879 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2880 also.
2881 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2882 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2883 (something_changed_gconfCB): Rename from something_changedCB.
2884 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2885 (parse_settings): Move check for font inside HAVE_XFT.
2886 (read_settings, apply_xft_settings): Add comment.
2887 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2888 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2889 call store_font_name_changed.
2890 (xft_settings_event): Add comment.
2891 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2892 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2893 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2894 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2895 (xsettings_initialize): Call init_gsettings last.
2896 (xsettings_get_system_font, xsettings_get_system_normal_font):
2897 Add comment.
2898
2899 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2900
2901 Random fixes. E.g., (random) never returned negative values.
2902 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2903 subseconds part to the entropy, as that's a bit more random.
2904 Prefer signed to unsigned, since the signedness doesn't matter and
2905 in general we prefer signed. When given a limit, use a
2906 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2907 latter isn't right if USE_2_TAGS_FOR_INTS.
2908 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2909 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2910
2911 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2912
2913 * textprop.c (text_property_stickiness):
2914 Obey Vtext_property_default_nonsticky.
2915 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2916 * w32fns.c (syms_of_w32fns):
2917 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2918
2919 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2922 This is more efficient than Ffile_directory_p and avoids a minor race.
2923
2924 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2925
2926 * buffer.c (Foverlay_put): Say what the return value is
2927 (bug#7835).
2928
2929 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2930 is a directory before asking whether to use the file name
2931 (bug#7564).
2932 (barf_or_query_if_file_exists): Make the "File is a directory"
2933 error be more correct.
2934
2935 * fns.c (Frequire): Remove the mention of the .gz files, since
2936 that's installation-specific, but keep the mention of
2937 `get-load-suffixes'.
2938
2939 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2940
2941 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2942 Report string overflow if the output is too long.
2943
2944 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2945
2946 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2947 (syms_of_gnutls): Remove duplicate DEFSYM for
2948 Qgnutls_bootprop_verify_hostname_error, an error for
2949 Qgnutls_bootprop_verify_error (which is no longer used).
2950
2951 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2952 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2953 Also (re)move comments that are misplaced or no longer relevant.
2954
2955 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2956
2957 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2958
2959 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2960
2961 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2962 and background color parameters if they have been changed.
2963
2964 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2965
2966 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2967
2968 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 * xsettings.c (SYSTEM_FONT): Define only when used.
2971 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2972
2973 * keymap.c (access_keymap_1): Now static.
2974
2975 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2976
2977 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2978 leave any prefix arg for the up event (Bug#1586).
2979
2980 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2981
2982 * lread.c (syms_of_lread): Mention single symbols defined by
2983 `defvar' or `defconst' (bug#7154).
2984
2985 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2986 (Frequire): Mention get-load-suffixes.
2987
2988 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2989
2990 * window.h (window): Remove clone_number slot.
2991 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2992 Remove.
2993 (make_parent_window, make_window, saved_window)
2994 (Fset_window_configuration, save_window_save): Don't deal with
2995 clone numbers.
2996 * buffer.c (Qclone_number): Remove declaration.
2997 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2998
2999 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 Add multiple inheritance to keymaps.
3002 * keymap.c (Fmake_composed_keymap): New function.
3003 (Fset_keymap_parent): Simplify.
3004 (fix_submap_inheritance): Remove.
3005 (access_keymap_1): New function extracted from access_keymap to handle
3006 embedded parents and handle lists of maps.
3007 (access_keymap): Use it.
3008 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3009 (Fcopy_keymap): Handle embedded parents.
3010 (Fcommand_remapping, define_as_prefix): Simplify.
3011 (Fkey_binding): Simplify.
3012 (syms_of_keymap): Move minibuffer-local-completion-map,
3013 minibuffer-local-filename-completion-map,
3014 minibuffer-local-must-match-map, and
3015 minibuffer-local-filename-must-match-map to Elisp.
3016 (syms_of_keymap): Defsubr make-composed-keymap.
3017 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3018 (parse_menu_item): Trivial simplification.
3019
3020 2011-07-01 Glenn Morris <rgm@gnu.org>
3021
3022 * Makefile.in (SETTINGS_LIBS): Fix typo.
3023
3024 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3025
3026 * coding.c (Fencode_coding_string): Record the last coding system
3027 used, as the function doc string says (bug#8738).
3028
3029 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3030
3031 * xsettings.c (store_monospaced_changed): Take new font as arg and
3032 check for change against current_mono_font.
3033 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3034 (emacs_settings_constructor, emacs_settings_get_property)
3035 (emacs_settings_set_property, emacs_settings_class_init)
3036 (emacs_settings_init, gsettings_obj): Remove.
3037 (something_changedCB): New function for HAVE_GSETTINGS.
3038 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3039 with value as argument.
3040 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3041 g_settings_new (Bug#8967). Do not create gsettings_obj.
3042 Remove calls to g_settings_bind. Connect something_changedCB to
3043 "changed".
3044
3045 * xgselect.c: Add defined (HAVE_GSETTINGS).
3046 (xgselect_initialize): Ditto.
3047
3048 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3049 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3050 xg_select.
3051
3052 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * eval.c (struct backtrace): Simplify and port the data structure.
3055 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3056 signed bit field, as this assumption is not portable and it makes
3057 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3058 "char debug_on_exit : 1" as this is not portable either; instead,
3059 use the portable "unsigned int debug_on_exit : 1". Remove unused
3060 member evalargs. Remove obsolete comments about cc bombing out.
3061
3062 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3063
3064 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3065 Let HAVE_GSETTINGS override HAVE_GCONF.
3066 (store_monospaced_changed): New function.
3067 (EMACS_SETTINGS): A new type derived from GObject to handle
3068 GSettings notifications.
3069 (emacs_settings_constructor, emacs_settings_get_property)
3070 (emacs_settings_set_property, emacs_settings_class_init):
3071 New functions.
3072 (gsettings_client, gsettings_obj): New variables.
3073 (GSETTINGS_SCHEMA): New define.
3074 (something_changedCB): Call store_monospaced_changed.
3075 (init_gsettings): New function.
3076 (xsettings_initialize): Call init_gsettings.
3077 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3078 to NULL.
3079
3080 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3081 GCONF_CFLAGS/LIBS.
3082
3083 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3084
3085 * window.c (resize_root_window, grow_mini_window)
3086 (shrink_mini_window): Rename Qresize_root_window to
3087 Qwindow_resize_root_window and Qresize_root_window_vertically to
3088 Qwindow_resize_root_window_vertically.
3089
3090 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3093
3094 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3095
3096 * makefile.w32-in: Redesign dependencies so they reflect more
3097 clearly which files are directly included by each source file,
3098 and not through other includes.
3099
3100 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3101
3102 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3103 (sort_overlays, overlay_strings): When an overlay's clone number
3104 matches the window's clone number process the overlay even if
3105 the overlay's window property doesn't match the current window.
3106
3107 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3108 (Fwindow_hchild): Rename to Fwindow_left_child.
3109 (Fwindow_next): Rename to Fwindow_next_sibling.
3110 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3111 (resize_window_check): Rename to window_resize_check.
3112 (resize_window_apply): Rename to window_resize_apply.
3113 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3114 (Fdelete_other_windows_internal, resize_frame_windows)
3115 (Fsplit_window_internal, Fdelete_window_internal)
3116 (grow_mini_window, shrink_mini_window)
3117 (Fresize_mini_window_internal): Fix callers accordingly.
3118
3119 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3120
3121 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3122 (emacs_fixed_set_min_size): Remove.
3123 (emacs_fixed_new): Take frame as argument.
3124
3125 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3126 (_EmacsFixedPrivate): Remove minwidth/height.
3127 Add struct frame *f.
3128 (emacs_fixed_init): Initialize priv->f.
3129 (get_parent_class, emacs_fixed_set_min_size): Remove.
3130 (emacs_fixed_new): Set priv->f to argument.
3131 (emacs_fixed_get_preferred_width)
3132 (emacs_fixed_get_preferred_height): Use min_width/height from
3133 frames size_hint to set minimum and natural (Bug#8919).
3134 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3135 and use min_width/height from frames size_hint to set
3136 min_width/height (Bug#8919).
3137
3138 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3139 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3140 Fix indentation.
3141
3142 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3143
3144 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3145 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3146 called at ZV.
3147
3148 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3149
3150 * process.c (wait_reading_process_output): Bypass select if
3151 waiting for a cell while ignoring keyboard input, and input is
3152 pending. Suggested by Jan Djärv (Bug#8869).
3153
3154 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 Use gnulib's dup2 module instead of rolling our own.
3157 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3158
3159 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3160
3161 * dispnew.c (scrolling_window): Before scrolling, turn off a
3162 mouse-highlight in the window being scrolled.
3163
3164 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3165
3166 Move DEFSYM to lisp.h and use everywhere.
3167
3168 * character.h (DEFSYM): Move declaration...
3169 * lisp.h (DEFSYM): ...here.
3170
3171 * gnutls.c:
3172 * minibuf.c:
3173 * w32menu.c:
3174 * w32proc.c:
3175 * w32select.c: Don't include character.h.
3176
3177 * alloc.c (syms_of_alloc):
3178 * buffer.c (syms_of_buffer):
3179 * bytecode.c (syms_of_bytecode):
3180 * callint.c (syms_of_callint):
3181 * casefiddle.c (syms_of_casefiddle):
3182 * casetab.c (init_casetab_once):
3183 * category.c (init_category_once, syms_of_category):
3184 * ccl.c (syms_of_ccl):
3185 * cmds.c (syms_of_cmds):
3186 * composite.c (syms_of_composite):
3187 * dbusbind.c (syms_of_dbusbind):
3188 * dired.c (syms_of_dired):
3189 * dispnew.c (syms_of_display):
3190 * doc.c (syms_of_doc):
3191 * editfns.c (syms_of_editfns):
3192 * emacs.c (syms_of_emacs):
3193 * eval.c (syms_of_eval):
3194 * fileio.c (syms_of_fileio):
3195 * fns.c (syms_of_fns):
3196 * frame.c (syms_of_frame):
3197 * fringe.c (syms_of_fringe):
3198 * insdel.c (syms_of_insdel):
3199 * keymap.c (syms_of_keymap):
3200 * lread.c (init_obarray, syms_of_lread):
3201 * macros.c (syms_of_macros):
3202 * msdos.c (syms_of_msdos):
3203 * print.c (syms_of_print):
3204 * process.c (syms_of_process):
3205 * search.c (syms_of_search):
3206 * sound.c (syms_of_sound):
3207 * syntax.c (init_syntax_once, syms_of_syntax):
3208 * terminal.c (syms_of_terminal):
3209 * textprop.c (syms_of_textprop):
3210 * undo.c (syms_of_undo):
3211 * w32.c (globals_of_w32):
3212 * window.c (syms_of_window):
3213 * xdisp.c (syms_of_xdisp):
3214 * xfaces.c (syms_of_xfaces):
3215 * xfns.c (syms_of_xfns):
3216 * xmenu.c (syms_of_xmenu):
3217 * xsettings.c (syms_of_xsettings):
3218 * xterm.c (syms_of_xterm): Use DEFSYM.
3219
3220 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3221
3222 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3223
3224 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3225
3226 Integer and buffer overflow fixes (Bug#8873).
3227
3228 * print.c (printchar, strout): Check for string overflow.
3229 (PRINTPREPARE, printchar, strout):
3230 Don't set size unless allocation succeeds.
3231
3232 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3233 for sizes. Check for string overflow more accurately.
3234 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3235
3236 * macros.c: Integer and buffer overflow fixes.
3237 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3238 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3239 Use ptrdiff_t, not int, for sizes.
3240 Don't increment bufsize until after realloc succeeds.
3241 Check for size-calculation overflow.
3242 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3243
3244 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3245
3246 * lread.c: Integer overflow fixes.
3247 (read_integer): Radix is now EMACS_INT, not int,
3248 to improve quality of diagnostics for out-of-range radices.
3249 Calculate buffer size correctly for out-of-range radices.
3250 (read1): Check for integer overflow in radices, and in
3251 read-circle numbers.
3252 (read_escape): Avoid int overflow.
3253 (Fload, openp, read_buffer_size, read1)
3254 (substitute_object_recurse, read_vector, read_list, map_obarray):
3255 Use ptrdiff_t, not int, for sizes.
3256 (read1): Use EMACS_INT, not int, for sizes.
3257 Check for size overflow.
3258
3259 * image.c (cache_image): Check for size arithmetic overflow.
3260
3261 * lread.c: Integer overflow issues.
3262 (saved_doc_string_size, saved_doc_string_length)
3263 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3264 Now ptrdiff_t, not int.
3265 (read1): Don't assume doc string length fits in int. Check for
3266 out-of-range doc string lengths.
3267 (read_list): Don't assume file position fits in int.
3268 (read_escape): Check for hex character overflow.
3269
3270 2011-06-22 Leo Liu <sdl.web@gmail.com>
3271
3272 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3273 Move to minibuffer.el.
3274
3275 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3276
3277 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3278 The following patches are for when GLYPH_DEBUG && !XASSERT.
3279 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3280 * dispnew.c (flush_stdout):
3281 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3282 Mark as externally visible.
3283 * dispnew.c (check_window_matrix_pointers): Now static.
3284 * dispnew.c (window_to_frame_vpos):
3285 * xfns.c (unwind_create_frame):
3286 * xterm.c (x_check_font): Remove unused local.
3287 * scroll.c (CHECK_BOUNDS):
3288 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3289 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3290 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3291 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3292 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3293 Now static.
3294 (debug_method_add): Use va_list and vsprintf rather than relying
3295 on undefined behavior with wrong number of arguments.
3296 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3297 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3298 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3299 since we're not interested in debugging glyphs with old libraries.
3300 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3301 GCC 4.6.0's static checking.
3302
3303 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 Integer overflow and signedness fixes (Bug#8873).
3306 A few related buffer overrun fixes, too.
3307
3308 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3309
3310 * dispextern.h (struct face.stipple):
3311 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3312 (x_bitmap_mask, x_allocate_bitmap_record)
3313 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3314 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3315 (x_create_bitmap_from_xpm_data):
3316 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3317 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3318 (.bitmaps_last):
3319 * xfaces.c (load_pixmap):
3320 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3321 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3322 (.bitmaps_last, struct x_output.icon_bitmap):
3323 Use ptrdiff_t, not int, for bitmap indexes.
3324 (x_allocate_bitmap_record): Check for size overflow.
3325 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3326
3327 Use ptrdiff_t, not int, for overlay counts.
3328 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3329 * editfns.c (overlays_around, get_pos_property):
3330 * textprop.c (get_char_property_and_overlay):
3331 * xdisp.c (next_overlay_change, note_mouse_highlight):
3332 * xfaces.c (face_at_buffer_position):
3333 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3334 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3335 (Fnext_overlay_change, Fprevious_overlay_change)
3336 (mouse_face_overlay_overlaps, Foverlays_in):
3337 Use ptrdiff_t, not int, for sizes.
3338 (overlays_at, overlays_in): Check for size-calculation overflow.
3339
3340 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3341
3342 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3343 (x_session_initialize): Do not assume string length fits in int.
3344
3345 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3346 This is unlikely, but can occur if DPI is outlandish.
3347
3348 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3349 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3350
3351 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3352 * xrdb.c (magic_file_p, search_magic_path):
3353 Omit last arg SUFFIX; it was always 0. All callers changed.
3354 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3355
3356 * xfont.c (xfont_match): Avoid need for strlen.
3357
3358 * xfns.c: Don't assume strlen fits in int.
3359 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3360
3361 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3362 not unsigned long, as we prefer signed integers. All callers changed.
3363 Detect integer overflow in repeat count.
3364 (message_dolog): Don't assume print length fits in 39 bytes.
3365 (display_mode_element): Don't assume strlen fits in int.
3366
3367 * termcap.c: Don't assume sizes fit in int and never overflow.
3368 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3369 (gobble_line): Check for size-calculation overflow.
3370
3371 * minibuf.c (Fread_buffer):
3372 * lread.c (intern, intern_c_string):
3373 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3374 Don't assume string length fits in int.
3375
3376 * keyboard.c (parse_tool_bar_item):
3377 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3378
3379 * font.c: Don't assume string length fits in int.
3380 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3381 Use ptrdiff_t, not int.
3382 (font_intern_prop): Don't assume string length fits in int.
3383 Don't assume integer property fits in fixnum.
3384 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3385
3386 * filelock.c: Fix some buffer overrun and integer overflow issues.
3387 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3388 Reformulate so as not to need the command string.
3389 Invoke gzip -cd rather than gunzip, as it's more portable.
3390 (lock_info_type, lock_file_1, lock_file):
3391 Don't assume pid_t and time_t fit in unsigned long.
3392 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3393 (current_lock_owner): Prefer signed type for sizes.
3394 Use memcpy, not strncpy, where memcpy is what is really wanted.
3395 Don't assume (via atoi) that time_t and pid_t fit in int.
3396 Check for time_t and/or pid_t out of range, e.g., via a network share.
3397 Don't alloca where an auto var works fine.
3398
3399 * fileio.c: Fix some integer overflow issues.
3400 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3401 Don't assume string length fits in int.
3402 (directory_file_name): Don't assume string length fits in long.
3403 (make_temp_name): Don't assume pid fits in int, or that its print
3404 length is less than 20.
3405
3406 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3407
3408 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3409
3410 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3411
3412 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3413 We prefer signed integers, even for size calculations.
3414
3415 * emacs.c: Don't assume string length fits in 'int'.
3416 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3417 (main): Don't invoke strlen when not needed.
3418
3419 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3420 (XD_DEBUG_MESSAGE): Don't waste a byte.
3421
3422 * callproc.c (getenv_internal_1, getenv_internal)
3423 (Fgetenv_internal):
3424 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3425
3426 * lread.c (invalid_syntax): Omit length argument.
3427 All uses changed. This doesn't fix a bug, but it simplifies the
3428 code away from its former Hollerith-constant appearance, and it's
3429 one less 'int' to worry about when looking at integer-overflow issues.
3430 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3431
3432 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3433 This didn't break anything, but it didn't help either.
3434 It's confusing to put a bogus integer in a place where the actual
3435 value does not matter.
3436 (LIST_END_P): Remove unused macro and its bogus comment.
3437 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3438
3439 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3440 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3441 implementation.
3442 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3443 We prefer signed types, and the value cannot exceed the EMACS_INT
3444 range anyway (because otherwise the length would not be representable).
3445 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3446 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3447 This avoids a GCC warning when WIDE_EMACS_INT.
3448
3449 * indent.c (sane_tab_width): New function.
3450 (current_column, scan_for_column, Findent_to, position_indentation)
3451 (compute_motion): Use it. This is just for clarity.
3452 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3453
3454 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3455
3456 * lisp.h (lint_assume): New macro.
3457 * composite.c (composition_gstring_put_cache):
3458 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3459
3460 * editfns.c, insdel.c:
3461 Omit unnecessary forward decls, to simplify future changes.
3462
3463 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3464
3465 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3466
3467 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3468 Use much-faster test for byte-length change.
3469 Don't assume string byte-length fits in 'int'.
3470 Check that character arg fits in 'int'.
3471 (mapcar1): Declare byte as byte, for clarity.
3472
3473 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3474
3475 * fns.c (concat): Catch string overflow earlier.
3476 Do not rely on integer wraparound.
3477
3478 * dispextern.h (struct it.overlay_strings_charpos)
3479 (struct it.selective): Now EMACS_INT, not int.
3480 * xdisp.c (forward_to_next_line_start)
3481 (back_to_previous_visible_line_start)
3482 (reseat_at_next_visible_line_start, next_element_from_buffer):
3483 Don't arbitrarily truncate the value of 'selective' to int.
3484
3485 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3486
3487 * composite.c: Don't truncate sizes to 'int'.
3488 (composition_gstring_p, composition_reseat_it)
3489 (composition_adjust_point): Use EMACS_INT, not int.
3490 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3491 not EMACS_UINT, for indexes.
3492
3493 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3494
3495 * buffer.c: Include <verify.h>.
3496 (struct sortvec.priority, struct sortstr.priority):
3497 Now EMACS_INT, not int.
3498 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3499 (struct sortstr.size, record_overlay_string)
3500 (struct sortstrlist.size, struct sortlist.used):
3501 Don't truncate size to int.
3502 (record_overlay_string): Check for size-calculation overflow.
3503 (init_buffer_once): Check at compile-time, not run-time.
3504
3505 2011-06-22 Jim Meyering <meyering@redhat.com>
3506
3507 Don't leak an XBM-image-sized buffer
3508 * image.c (xbm_load): Free the image buffer after using it.
3509
3510 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3511
3512 Port to Sun C.
3513 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3514 that Sun C diagnosed.
3515 * fns.c (secure_hash): Fix pointer signedness issue.
3516 * intervals.c (static_offset_intervals): New function.
3517 (offset_intervals): Use it.
3518
3519 2011-06-21 Leo Liu <sdl.web@gmail.com>
3520
3521 * deps.mk (fns.o):
3522 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3523 sha512.h.
3524
3525 * fns.c (secure_hash): Rename from crypto_hash_function and change
3526 the first arg to accept symbols.
3527 (Fsecure_hash): New primitive.
3528 (syms_of_fns): New symbols.
3529
3530 2011-06-20 Deniz Dogan <deniz@dogan.se>
3531
3532 * process.c (Fset_process_buffer): Clarify return value in
3533 docstring.
3534
3535 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3536
3537 * dispnew.c (add_window_display_history): Use BVAR.
3538
3539 * xdisp.c (debug_method_add): Use BVAR.
3540 (check_window_end, dump_glyph_matrix, dump_glyph)
3541 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3542
3543 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3544 Likewise.
3545
3546 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3547 check till after the cache is created in init_frame_faces.
3548
3549 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3550
3551 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3552
3553 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3556 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3557 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3558
3559 Improve buffer-overflow checking (Bug#8873).
3560 * fileio.c (Finsert_file_contents):
3561 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3562 Remove the old (too-loose) buffer overflow checks.
3563 They weren't needed, since make_gap checks for buffer overflow.
3564 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3565 The old code merely checked for Emacs fixnum overflow, and relied
3566 on undefined (wraparound) behavior. The new code avoids undefined
3567 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3568
3569 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3570 Tune. Don't use wider integers than needed. Don't use alloca.
3571 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3572
3573 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3574
3575 * insdel.c, lisp.h (buffer_overflow): New function.
3576 (insert_from_buffer_1, replace_range, replace_range_2):
3577 * insdel.c (make_gap_larger):
3578 * editfns.c (Finsert_char):
3579 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3580
3581 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3582
3583 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 Integer overflow and signedness fixes (Bug#8873).
3586
3587 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3588 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3589
3590 * fileio.c: Don't assume EMACS_INT fits in off_t.
3591 (emacs_lseek): New static function.
3592 (Finsert_file_contents, Fwrite_region): Use it.
3593 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3594
3595 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3596
3597 * fns.c: Don't overflow int when computing a list length.
3598 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3599 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3600 truncation on 64-bit hosts. Check for QUIT every
3601 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3602 faster and is responsive enough.
3603 (Flength): Report an error instead of overflowing an integer.
3604 (Fsafe_length): Return a float if the value is not representable
3605 as a fixnum. This shouldn't happen except in contrived situations.
3606 (Fnthcdr, Fsort): Don't assume list length fits in int.
3607 (Fcopy_sequence): Don't assume vector length fits in int.
3608
3609 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3610 (header_size, word_size): New constants.
3611 (allocate_vectorlike): Don't check size overflow here.
3612 (allocate_vector): Check it here instead, since this is the only
3613 caller of allocate_vectorlike that could cause overflow.
3614 Check that the new vector's length is representable as a fixnum.
3615
3616 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3617 The previous code was bogus. For example, next_almost_prime (32)
3618 returned 39, which is undesirable as it is a multiple of 3; and
3619 next_almost_prime (24) returned 25, which is a multiple of 5 so
3620 why was the code bothering to check for multiples of 7?
3621
3622 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3623
3624 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3625
3626 Variadic C functions now count arguments with ptrdiff_t.
3627 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3628 Back then I didn't know that the Emacs coding style prefers signed int.
3629 Also, in the meantime I found a few more instances where arguments
3630 were being counted with int, which may truncate counts on 64-bit
3631 machines, or EMACS_INT, which may be unnecessarily wide.
3632 * lisp.h (struct Lisp_Subr.function.aMANY)
3633 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3634 Arg counts are now ptrdiff_t, not size_t.
3635 All variadic functions and their callers changed accordingly.
3636 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3637 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3638 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3639 * callint.c (Fcall_interactively): Check arg count for overflow,
3640 to avoid potential buffer overrun. Use signed char, not 'int',
3641 for 'varies' array, so that we needn't bother to check its size
3642 calculation for overflow.
3643 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3644 * eval.c (apply_lambda):
3645 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3646 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3647 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3648
3649 * callint.c (Fcall_interactively): Don't use index var as event count.
3650
3651 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3652 * mem-limits.h (SIZE): Remove; no longer used.
3653
3654 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3655
3656 Remove unnecessary casts.
3657 * xterm.c (x_term_init):
3658 * xfns.c (x_set_border_pixel):
3659 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3660 These aren't needed now that we assume ANSI C.
3661
3662 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3663 It's more likely to cause problems (due to unsigned overflow)
3664 than to cure them.
3665
3666 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3667
3668 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3669
3670 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3671
3672 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3673
3674 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3675
3676 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3677
3678 GLYPH_CODE_FACE returns EMACS_INT, not int.
3679 * dispextern.h (merge_faces):
3680 * xfaces.c (merge_faces):
3681 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3682 Don't assume EMACS_INT fits in int.
3683
3684 * character.h (CHAR_VALID_P): Remove unused parameter.
3685 * fontset.c, lisp.h, xdisp.c: All uses changed.
3686
3687 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3688
3689 * fns.c (concat): Minor tuning based on overflow analysis.
3690 This doesn't fix any bugs. Use int to hold character, instead
3691 of constantly refetching from Emacs object. Use XFASTINT, not
3692 XINT, for value known to be a character. Don't bother comparing
3693 a single byte to 0400, as it's always less.
3694
3695 * floatfns.c (Fexpt):
3696 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3697
3698 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3699 for characters.
3700
3701 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3702
3703 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3704 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3705 incorrectly succeed when S was a string, because 4294967386 was
3706 truncated before it was used.
3707
3708 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3709 Otherwise, an out-of-range integer could cause undefined behavior
3710 on a 64-bit host.
3711
3712 * composite.c: Use int, not EMACS_INT, for characters.
3713 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3714 EMACS_INT, for values that are known to be in character range.
3715 This doesn't fix any bugs but is the usual style inside Emacs and
3716 may generate better code on 32-bit machines.
3717
3718 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3719 This is for reasons similar to the recent CHAR_STRING fix.
3720 * charset.c (Fencode_char): Check that character arg is actually
3721 a character. Pass an int to ENCODE_CHAR.
3722 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3723 wider than 'int', as a compile-time check to prevent future regressions
3724 in this area.
3725
3726 * character.c (char_string): Remove unnecessary casts.
3727
3728 Make sure a 64-bit char is never passed to CHAR_STRING.
3729 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3730 by silently ignoring the top 32 bits, allowing some values
3731 that were far too large to be valid characters.
3732 * character.h: Include <verify.h>.
3733 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3734 arguments are no wider than unsigned, as a compile-time check
3735 to prevent future regressions in this area.
3736 * data.c (Faset):
3737 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3738 (Fsubst_char_in_region):
3739 * fns.c (concat):
3740 * xdisp.c (decode_mode_spec_coding):
3741 Adjust to CHAR_STRING's new requirement.
3742 * editfns.c (Finsert_char, Fsubst_char_in_region):
3743 * fns.c (concat): Check that character args are actually
3744 characters. Without this test, these functions did the wrong
3745 thing with wildly out-of-range values on 64-bit hosts.
3746
3747 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3748 These casts should not be needed on 32-bit hosts, either.
3749 * keyboard.c (read_char):
3750 * lread.c (Fload): Remove casts to unsigned.
3751
3752 * lisp.h (UNSIGNED_CMP): New macro.
3753 This fixes comparison bugs on 64-bit hosts.
3754 (ASCII_CHAR_P): Use it.
3755 * casefiddle.c (casify_object):
3756 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3757 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3758 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3759 * dispextern.h (FACE_FROM_ID):
3760 * keyboard.c (read_char): Use UNSIGNED_CMP.
3761
3762 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3763 not to EMACS_INT, to avoid GCC warning.
3764
3765 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3766
3767 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3768 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3769 isn't needed on 32-bit machines.
3770
3771 * buffer.c (Fgenerate_new_buffer_name):
3772 Use EMACS_INT for count, not int.
3773 (advance_to_char_boundary): Return EMACS_INT, not int.
3774
3775 * data.c (Qcompiled_function): Now static.
3776
3777 * window.c (window_body_lines): Now static.
3778
3779 * image.c (gif_load): Rename local to avoid shadowing.
3780
3781 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3782 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3783 * alloc.c (make_save_value): Integer argument is now of type
3784 ptrdiff_t, not int.
3785 (mark_object): Use ptrdiff_t, not int.
3786 * lisp.h (pD): New macro.
3787 * print.c (print_object): Use it.
3788
3789 * alloc.c: Use EMACS_INT, not int, to count objects.
3790 (total_conses, total_markers, total_symbols, total_vector_size)
3791 (total_free_conses, total_free_markers, total_free_symbols)
3792 (total_free_floats, total_floats, total_free_intervals)
3793 (total_intervals, total_strings, total_free_strings):
3794 Now EMACS_INT, not int. All uses changed.
3795 (Fgarbage_collect): Compute overall total using a double, so that
3796 integer overflow is less likely to be a problem. Check for overflow
3797 when converting back to an integer.
3798 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3799 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3800 These were 'int' variables that could overflow on 64-bit hosts;
3801 they were never used, so remove them instead of repairing them.
3802 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3803 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3804 Previously, this ceilinged at INT_MAX, but that doesn't work on
3805 64-bit machines.
3806 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3807
3808 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3809 (allocate_vectorlike): Check for ptrdiff_t overflow.
3810 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3811 when a (possibly-narrower) signed value would do just as well.
3812 We prefer using signed arithmetic, to avoid comparison confusion.
3813
3814 * alloc.c: Catch some string size overflows that we were missing.
3815 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3816 for convenience in STRING_BYTES_MAX.
3817 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3818 The definition here is exact; the one in lisp.h was approximate.
3819 (allocate_string_data): Check for string overflow. This catches
3820 some instances we weren't catching before. Also, it catches
3821 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3822 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3823 and ptrdiff_t and EMACS_INT are both 64 bits.
3824
3825 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3826 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3827 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3828
3829 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3830
3831 * alloc.c (Fmake_string): Check for out-of-range init.
3832
3833 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3834
3835 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3836
3837 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3838
3839 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3840 xg_get_default_scrollbar_width.
3841
3842 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3843 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3844 (style_changed_cb): Call update_theme_scrollbar_width and call
3845 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3846 all frames (Bug#8505).
3847 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3848 Call gtk_window_set_resizable if HAVE_GTK3.
3849 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3850 and height if HAVE_GTK3 (Bug#8505).
3851 (scroll_bar_width_for_theme): New variable.
3852 (update_theme_scrollbar_width): New function.
3853 (xg_get_default_scrollbar_width): Move code to
3854 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3855 (xg_initialize): Call update_theme_scrollbar_width.
3856
3857 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3858
3859 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3860
3861 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3862
3863 * frame.c (make_frame): Call other_buffer_safely instead of
3864 other_buffer.
3865
3866 * window.c (temp_output_buffer_show): Call display_buffer with
3867 second argument Vtemp_buffer_show_specifiers and reset latter
3868 immediately after the call.
3869 (Vtemp_buffer_show_specifiers): New variable.
3870 (auto_window_vscroll_p, next_screen_context_lines)
3871 (Vscroll_preserve_screen_position): Remove leading asterisks from
3872 doc-strings.
3873
3874 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Fix minor problems found by GCC 4.6.0 static checking.
3877 * buffer.c (Qclone_number): Remove for now, as it's unused.
3878 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3879 (record_buffer): Remove unused local.
3880 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3881 (set_frame_buffer_list): Remove; unused.
3882 * frame.h (other_visible_frames): Remove decl.
3883 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3884 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3885 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3886 if HAVE_GPM.
3887 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3888 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3889 Define only if HAVE_GPM.
3890 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3891 (update_hints_inhibit): Remove; never set. All uses removed.
3892 * widgetprv.h (emacsFrameClassRec): Remove decl.
3893 * window.c (delete_deletable_window): Now returns void, since it
3894 wasn't returning anything.
3895 (compare_window_configurations): Remove unused locals.
3896 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3897 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3898 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3899 the same widths as pointers. This follows up on the 2011-05-06 patch.
3900 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3901 * xterm.h: Likewise.
3902 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3903
3904 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3905
3906 * makefile.w32-in: Update dependencies.
3907 (LISP_H): Add lib/intprops.h.
3908
3909 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3910
3911 * image.c (gif_load): Add animation frame delay to the metadata.
3912 (syms_of_image): Use DEFSYM. New symbol `delay'.
3913
3914 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3915
3916 * window.c (delete_deletable_window): Re-add.
3917 (Fset_window_configuration): Rewrite to handle dead buffers and
3918 consequently deletable windows.
3919 (window_tree, Fwindow_tree): Remove. Supply functionality in
3920 window.el.
3921 (compare_window_configurations): Simplify code.
3922
3923 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3924
3925 * image.c (imagemagick_load_image): Fix type mismatch.
3926 (Fimagemagick_types): Likewise.
3927
3928 * window.h (replace_buffer_in_windows): Declare.
3929
3930 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3931
3932 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3933 Qclone_number. Remove external declaration of Qdelete_window.
3934 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3935 code.
3936 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3937 Run Qbuffer_list_update_hook if allowed.
3938 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3939 buffer list implementation.
3940 (other_buffer_safely): New function.
3941 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3942 calls to replace_buffer_in_windows and
3943 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3944 if allowed.
3945 (record_buffer): Inhibit quitting and rewrite using quittable
3946 functions. Run Qbuffer_list_update_hook if allowed.
3947 (Frecord_buffer, Funrecord_buffer): New functions.
3948 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3949 Move switch-to-buffer to window.el.
3950 (bury-buffer): Move to window.el.
3951 (Vbuffer_list_update_hook): New variable.
3952
3953 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3954 section.
3955
3956 * window.h (resize_frame_windows): Move up in code.
3957 (Fwindow_frame): Remove EXFUN.
3958 (replace_buffer_in_all_windows): Remove prototype.
3959 (replace_buffer_in_windows_safely): Add prototype.
3960
3961 * window.c: Declare Qdelete_window static again. Move down
3962 declaration of select_count.
3963 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3964 (Fother_window): Move to window.el.
3965 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3966 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3967 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3968 window.el.
3969 (replace_buffer_in_windows): Implement by calling
3970 Qreplace_buffer_in_windows.
3971 (replace_buffer_in_all_windows): Remove with some functionality
3972 moved into replace_buffer_in_windows_safely.
3973 (replace_buffer_in_windows_safely): New function.
3974 (select_window_norecord, select_frame_norecord): Move in front
3975 of run_window_configuration_change_hook. Remove now obsolete
3976 declarations.
3977 (Fset_window_buffer): Rewrite doc-string.
3978 Call Qrecord_window_buffer.
3979 (keys_of_window): Move binding for other-window to window.el.
3980
3981 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3982
3983 * dispextern.h (struct image): Replace data member, whose int_val
3984 and ptr_val fields were not used by anything, with a single
3985 lisp_val object.
3986
3987 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3988 (gif_clear_image, gif_load, imagemagick_load_image)
3989 (gs_clear_image, gs_load): Callers changed.
3990
3991 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3992
3993 * buffer.h: Include <time.h>, for time_t.
3994 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3995
3996 Fix minor problems found by static checking.
3997
3998 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3999
4000 Make identifiers static if they are not used in other modules.
4001 * data.c (Qcompiled_function, Qframe, Qvector):
4002 * image.c (QimageMagick, Qsvg):
4003 * minibuf.c (Qmetadata):
4004 * window.c (resize_window_check, resize_root_window): Now static.
4005 * window.h (resize_window_check, resize_root_window): Remove decls.
4006
4007 * window.c (window_deletion_count, delete_deletable_window):
4008 Remove; unused.
4009 (window_body_lines): Now static.
4010 (Fdelete_other_windows_internal): Mark vars as initialized.
4011 Make sure 'resize_failed' is initialized.
4012 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4013 (resize_window_apply): Remove unused local.
4014 * window.h (delete_deletable_window): Remove decl.
4015
4016 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4017 (imagemagick_load_image): Fix pointer signedness problem by changing
4018 last arg from unsigned char * to char *. All uses changed.
4019 Also, fix a local for similar reasons.
4020 Remove unused locals. Remove locals to avoid shadowing.
4021 (fn_rsvg_handle_free): Remove; unused.
4022 (svg_load, svg_load_image): Fix pointer signedness problem.
4023 (imagemagick_load_image): Don't use garbage pointer image_wand.
4024
4025 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4026
4027 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * image.c (gif_load): Fix omitted cast error introduced by
4030 2011-06-06 change.
4031
4032 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4033
4034 * window.h (resize_proportionally, orig_total_lines)
4035 (orig_top_line): Remove from window structure.
4036 (set_window_height, set_window_width, change_window_heights)
4037 (Fdelete_window): Remove prototypes.
4038 (resize_frame_windows): Remove duplicate declaration.
4039
4040 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4041
4042 * window.h (resize_frame_windows, resize_window_check)
4043 (delete_deletable_window, resize_root_window)
4044 (resize_frame_windows): Declare prototypes.
4045
4046 * window.c (resize_window_apply): Make definition be "static" to
4047 match the prototype.
4048
4049 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4050
4051 * window.c: Remove declarations of Qwindow_size_fixed,
4052 window_min_size_1, window_min_size_2, window_min_size,
4053 size_window, window_fixed_size_p, enlarge_window, delete_window.
4054 Remove static from declaration of Qdelete_window, it's
4055 temporarily needed by Fbury_buffer.
4056 (replace_window): Don't assign orig_top_line and
4057 orig_total_lines.
4058 (Fdelete_window, delete_window): Remove. Window deletion is
4059 handled by window.el.
4060 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4061 Replace Fdelete_window calls with calls to Qdelete_window.
4062 (Fdelete_other_windows): Remove. Deleting other windows is
4063 handled by window.el.
4064 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4065 handled in window.el.
4066 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4067 Window minimum sizes are handled in window.el.
4068 (shrink_windows, size_window, set_window_height)
4069 (set_window_width, change_window_heights, window_height)
4070 (window_width, CURBEG, CURSIZE, enlarge_window)
4071 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4072 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4073 handled in window.el.
4074 (make_dummy_parent): Rename to make_parent_window and give it a
4075 second argument horflag.
4076 (make_window): Don't set resize_proportionally any more.
4077 (Fsplit_window): Remove. Windows are split in window.el.
4078 (save_restore_action, save_restore_orig_size)
4079 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4080 Resize mini windows in window.el.
4081 (grow_mini_window, shrink_mini_window): Implement by calling
4082 Qresize_root_window_vertically, resize_window_check and
4083 resize_window_apply.
4084 (saved_window, Fset_window_configuration, save_window_save):
4085 Do not handle orig_top_line, orig_total_lines, and
4086 resize_proportionally.
4087 (window_min_height, window_min_width): Move to window.el.
4088 (keys_of_window): Move bindings for delete-other-windows,
4089 split-window, delete-window and enlarge-window to window.el.
4090
4091 * buffer.c: Temporarily extern Qdelete_window.
4092 (Fbury_buffer): Temporarily call Qdelete_window instead of
4093 Fdelete_window (Fbury_buffer will move to window.el soon).
4094
4095 * frame.c (set_menu_bar_lines_1): Remove code handling
4096 orig_top_line and orig_total_lines.
4097
4098 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4099 set_window_height but set heights directly.
4100 (change_frame_size_1): Use resize_frame_windows.
4101
4102 * xdisp.c (init_xdisp): Don't use set_window_height but set
4103 heights directly.
4104
4105 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4106 Use resize_frame_windows instead of change_window_heights and run
4107 run_window_configuration_change_hook.
4108
4109 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4110 instead of change_window_heights and run
4111 run_window_configuration_change_hook.
4112
4113 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4114
4115 * window.c (replace_window): Rename second argument REPLACEMENT to
4116 NEW. New third argument SETFLAG. Rewrite.
4117 (delete_window, make_dummy_parent): Call replace_window with
4118 third argument 1.
4119 (window_list_1): Move down in code.
4120 (run_window_configuration_change_hook): Move set_buffer part
4121 before select_frame_norecord part in order to unwind correctly.
4122 Rename count1 to count.
4123 (recombine_windows, delete_deletable_window, resize_root_window)
4124 (Fdelete_other_windows_internal)
4125 (Frun_window_configuration_change_hook, make_parent_window)
4126 (resize_window_check, resize_window_apply, Fresize_window_apply)
4127 (resize_frame_windows, Fsplit_window_internal)
4128 (Fdelete_window_internal, Fresize_mini_window_internal):
4129 New functions.
4130 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4131
4132 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4133
4134 * window.h (window): Add some new members to window structure -
4135 normal_lines, normal_cols, new_total, new_normal, clone_number,
4136 splits, nest, prev_buffers, next_buffers.
4137 (WINDOW_TOTAL_SIZE): Move here from window.c.
4138 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4139
4140 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4141 Remove.
4142 (make_dummy_parent): Set new members of windows structure.
4143 (make_window): Move down in code. Handle new members of window
4144 structure.
4145 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4146 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4147 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4148 (Fset_window_prev_buffers, Fwindow_next_buffers)
4149 (Fset_window_next_buffers, Fset_window_clone_number):
4150 New functions.
4151 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4152 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4153 Doc-string fixes.
4154 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4155 Argument WINDOW can be now internal window too.
4156 (Fwindow_use_time): Move up in code.
4157 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4158 Rewrite doc-string.
4159 (Fset_window_configuration, saved_window)
4160 (Fcurrent_window_configuration, save_window_save): Handle new
4161 members of window structure.
4162 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4163 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4164 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4165 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4166 Qget_mru_window, Qresize_root_window,
4167 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4168 Qauto_buffer_name; staticpro them.
4169
4170 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4171
4172 * window.c (Fwindow_total_size, Fwindow_left_column)
4173 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4174 (Fwindow_list_1): New functions.
4175 (window_box_text_cols): Replace with window_body_cols.
4176 (Fwindow_width, Fscroll_left, Fscroll_right):
4177 Use window_body_cols instead of window_box_text_cols.
4178 (delete_window, Fset_window_configuration):
4179 Call delete_all_subwindows with window as argument.
4180 (delete_all_subwindows): Take a window as argument and not a
4181 structure. Rewrite.
4182 (window_loop): Remove handling of GET_LRU_WINDOW and
4183 GET_LARGEST_WINDOW.
4184 (Fget_lru_window, Fget_largest_window): Move to window.el.
4185
4186 * window.h: Extern window_body_cols instead of
4187 window_box_text_cols. delete_all_subwindows now takes a
4188 Lisp_Object as argument.
4189
4190 * indent.c (compute_motion, Fcompute_motion):
4191 Use window_body_cols instead of window_box_text_cols.
4192
4193 * frame.c (delete_frame): Call delete_all_subwindows with root
4194 window as argument.
4195
4196 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4197
4198 * fns.c (Fputhash): Document return value.
4199
4200 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4201
4202 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4203
4204 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4205
4206 Cons<->int and similar integer overflow fixes (Bug#8794).
4207
4208 Check for overflow when converting integer to cons and back.
4209 * charset.c (Fdefine_charset_internal, Fdecode_char):
4210 Use cons_to_unsigned to catch overflow.
4211 (Fencode_char): Use INTEGER_TO_CONS.
4212 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4213 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4214 * data.c (long_to_cons, cons_to_long): Remove.
4215 (cons_to_unsigned, cons_to_signed): New functions.
4216 These signal an error for invalid or out-of-range values.
4217 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4218 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4219 * font.c (Ffont_variation_glyphs):
4220 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4221 * lisp.h: Include <intprops.h>.
4222 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4223 (cons_to_signed, cons_to_unsigned): New decls.
4224 (long_to_cons, cons_to_long): Remove decls.
4225 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4226 (Fprimitive_undo): Use CONS_TO_INTEGER.
4227 * xfns.c (Fx_window_property): Likewise.
4228 * xselect.c: Include <limits.h>.
4229 (x_own_selection, selection_data_to_lisp_data):
4230 Use INTEGER_TO_CONS.
4231 (x_handle_selection_request, x_handle_selection_clear)
4232 (x_get_foreign_selection, Fx_disown_selection_internal)
4233 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4234 (lisp_data_to_selection_data): Use cons_to_unsigned.
4235 (x_fill_property_data): Use cons_to_signed.
4236 Report values out of range.
4237
4238 Check for buffer and string overflow more precisely.
4239 * buffer.h (BUF_BYTES_MAX): New macro.
4240 * lisp.h (STRING_BYTES_MAX): New macro.
4241 * alloc.c (Fmake_string):
4242 * character.c (string_escape_byte8):
4243 * coding.c (coding_alloc_by_realloc):
4244 * doprnt.c (doprnt):
4245 * editfns.c (Fformat):
4246 * eval.c (verror):
4247 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4248 since they may not be the same number.
4249 * editfns.c (Finsert_char):
4250 * fileio.c (Finsert_file_contents):
4251 Likewise for BUF_BYTES_MAX.
4252
4253 * image.c: Use ptrdiff_t, not int, for sizes.
4254 (slurp_file): Switch from int to ptrdiff_t.
4255 All uses changed.
4256 (slurp_file): Check that file size fits in both size_t (for
4257 malloc) and ptrdiff_t (for sanity and safety).
4258
4259 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4260 if b->modtime has its maximal value.
4261
4262 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4263
4264 Don't assume time_t can fit into int.
4265 * buffer.h (struct buffer.modtime): Now time_t, not int.
4266 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4267 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4268
4269 Minor fixes for signed vs unsigned integers.
4270 * character.h (MAYBE_UNIFY_CHAR):
4271 * charset.c (maybe_unify_char):
4272 * keyboard.c (read_char, reorder_modifiers):
4273 XINT -> XFASTINT, since the integer must be nonnegative.
4274 * ftfont.c (ftfont_spec_pattern):
4275 * keymap.c (access_keymap, silly_event_symbol_error):
4276 XUINT -> XFASTINT, since the integer must be nonnegative.
4277 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4278 since it makes no difference and we prefer signed.
4279 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4280 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4281 nonnegative.
4282
4283 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4284
4285 * window.h (Fwindow_frame): Declare.
4286
4287 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4288
4289 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4290 (SPARE_MEMORY): Always define.
4291 (LARGE_REQUEST): Remove.
4292 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4293
4294 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4295
4296 * lisp.h: Move EXFUNS for Fframe_root_window,
4297 Fframe_first_window and Fset_frame_selected_window to window.h.
4298
4299 * window.h: Move EXFUNS for Fframe_root_window,
4300 Fframe_first_window and Fset_frame_selected_window here from
4301 lisp.h.
4302
4303 * frame.c (Fwindow_frame, Fframe_first_window)
4304 (Fframe_root_window, Fframe_selected_window)
4305 (Fset_frame_selected_window): Move to window.c.
4306 (Factive_minibuffer_window): Move to minibuf.c.
4307 (Fother_visible_frames_p): New function.
4308
4309 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4310
4311 * window.c (decode_window, decode_any_window): Move up in code.
4312 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4313 (inhibit_frame_unsplittable): Remove unused variable.
4314 (Fwindow_buffer): Move up and rewrite doc-string.
4315 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4316 (Fwindow_prev): New functions.
4317 (Fwindow_frame): Move here from frame.c. Accept any window as
4318 argument.
4319 (Fframe_root_window, Fframe_first_window)
4320 (Fframe_selected_window): Move here from frame.c. Accept frame
4321 or arbitrary window as argument. Update doc-strings.
4322 (Fminibuffer_window): Move up in code.
4323 (Fwindow_minibuffer_p): Move up in code and simplify.
4324 (Fset_frame_selected_window): Move here from frame.c.
4325 Marginal rewrite.
4326 (Fselected_window, select_window, Fselect_window): Move up in
4327 code. Minor doc-string fixes.
4328
4329 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4330
4331 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4332 Do not assume that spare memory exists; that assumption is valid
4333 only if SYSTEM_MALLOC.
4334 (LARGE_REQUEST): New macro, so that the issue of large requests
4335 is separated from the issue of spare memory.
4336
4337 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4338
4339 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4340 format. (Bug#8806)
4341
4342 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4343
4344 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4345 before statements.
4346
4347 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4348
4349 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4350
4351 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4352
4353 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4354 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4355
4356 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4357
4358 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4359
4360 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4361
4362 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4363 (x_clipboard_manager_save): Add return value.
4364 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4365 New error handlers.
4366 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4367 Obey Vx_select_enable_clipboard_manager. Catch errors in
4368 x_clipboard_manager_save (Bug#8779).
4369 (Vx_select_enable_clipboard_manager): New variable.
4370 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4371
4372 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4373
4374 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4375
4376 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4377
4378 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4379 in the current matrix if keep_current_p is non-zero.
4380
4381 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4382
4383 * bidi.c (bidi_level_of_next_char): Fix last change.
4384
4385 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4386
4387 Support bidi reordering of text covered by display properties.
4388
4389 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4390 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4391 (bidi_cache_search, bidi_cache_iterator_state)
4392 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4393 (bidi_level_of_next_char, bidi_move_to_visually_next):
4394 Support character positions inside a run of characters covered by a
4395 display string.
4396 (bidi_paragraph_init, bidi_resolve_explicit_1)
4397 (bidi_level_of_next_char): Call bidi_fetch_char and
4398 bidi_fetch_char_advance instead of FETCH_CHAR and
4399 FETCH_CHAR_ADVANCE.
4400 (bidi_init_it): Initialize new members.
4401 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4402 definitions.
4403 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4404 instead of using explicit *_CHAR codes.
4405 (bidi_resolve_explicit, bidi_resolve_weak):
4406 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4407 bidirectional text is supported only in multibyte buffers.
4408 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4409 it to initialize the frame_window_p member of struct bidi_it.
4410 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4411 (bidi_resolve_explicit, bidi_resolve_weak)
4412 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4413 bidi_it->nchars is non-positive.
4414 (bidi_level_of_next_char): Don't try to lookup the cache for the
4415 next/previous character if nothing is cached there yet, or if we
4416 were just reseat()'ed to a new position.
4417
4418 * xdisp.c (set_cursor_from_row): Set start and stop points
4419 according to the row's direction when priming the loop that looks
4420 for the glyph on which to display cursor.
4421 (single_display_spec_intangible_p): Function deleted.
4422 (display_prop_intangible_p): Reimplement to call
4423 handle_display_spec instead of single_display_spec_intangible_p.
4424 Accept 3 additional arguments needed by handle_display_spec.
4425 This fixes incorrect cursor motion across display property with complex
4426 values: lists, `(when COND...)' forms, etc.
4427 (single_display_spec_string_p): Support property values that are
4428 lists with the argument STRING its top-level element.
4429 (display_prop_string_p): Fix the condition for processing a
4430 property that is a list to be consistent with handle_display_spec.
4431 (handle_display_spec): New function, refactored from the
4432 last portion of handle_display_prop.
4433 (compute_display_string_pos): Accept additional argument
4434 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4435 value of a `display' property is a "replacing spec".
4436 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4437 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4438 the display property, but just return a value indicating whether
4439 the display property will replace the characters it covers.
4440 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4441 frame_window_p members of struct bidi_it.
4442 (compute_display_string_pos, compute_display_string_end):
4443 New functions.
4444 (push_it): Accept second argument POSITION, where pop_it should
4445 jump to continue iteration.
4446 (reseat_1): Initialize bidi_it.disp_pos.
4447
4448 * keyboard.c (adjust_point_for_property): Adjust the call to
4449 display_prop_intangible_p to its new signature.
4450
4451 * dispextern.h (struct bidi_it): New member frame_window_p.
4452 (bidi_init_it): Update prototypes.
4453 (display_prop_intangible_p): Update prototype.
4454 (compute_display_string_pos, compute_display_string_end):
4455 Declare prototypes.
4456 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4457 EMACS_INT.
4458
4459 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4460
4461 Malloc failure behavior now depends on size of allocation.
4462 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4463 * lisp.h: Change signatures accordingly.
4464 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4465 All callers changed. (Bug#8762)
4466
4467 * gnutls.c: Use Emacs's memory allocators.
4468 Without this change, the gnutls library would invoke malloc etc.
4469 directly, which causes problems on non-SYNC_INPUT hosts, and which
4470 runs afoul of improving memory_full behavior. (Bug#8761)
4471 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4472 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4473 xfree instead of the default malloc, realloc, free.
4474 (Fgnutls_boot): No need to check for memory allocation failure,
4475 since xmalloc does that for us.
4476
4477 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4478 * category.c (hash_get_category_set):
4479 * ccl.c (ccl_driver):
4480 * charset.c (Fdefine_charset_internal):
4481 * charset.h (struct charset.hash_index):
4482 * composite.c (get_composition_id, gstring_lookup_cache)
4483 (composition_gstring_put_cache):
4484 * composite.h (struct composition.hash_index):
4485 * dispextern.h (struct image.hash):
4486 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4487 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4488 (hashfn_equal, hashfn_user_defined, make_hash_table)
4489 (maybe_resize_hash_table, hash_lookup, hash_put)
4490 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4491 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4492 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4493 * image.c (make_image, search_image_cache, lookup_image)
4494 (xpm_put_color_table_h):
4495 * lisp.h (struct Lisp_Hash_Table):
4496 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4497 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4498 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4499 * alloc.c (allocate_vectorlike):
4500 Check for overflow in vector size calculations.
4501 * ccl.c (ccl_driver):
4502 Check for overflow when converting EMACS_INT to int.
4503 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4504 need to be updated by these changes.
4505 * fns.c (make_hash_table, maybe_resize_hash_table):
4506 Check for integer overflow with large hash tables.
4507 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4508 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4509 (SXHASH_REDUCE): New macro.
4510 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4511 Use it instead of discarding useful hash info with large hash values.
4512 (sxhash_float): New function.
4513 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4514 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4515 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4516 Rewrite to use FIXNUM_BITS, as this simplifies things.
4517 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4518 Adjust signatures to match updated version of code.
4519 (consing_since_gc): Now EMACS_INT, since a single hash table can
4520 use more than INT_MAX bytes.
4521
4522 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4523
4524 Make it possible to build with GCC-4.6+ -O2 -flto.
4525
4526 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4527
4528 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4529
4530 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4531 Call minibuffer-inactive-mode.
4532
4533 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4536 Update dependencies.
4537
4538 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4539
4540 * data.c (init_data): Remove code for UTS, this system is not
4541 supported anymore.
4542
4543 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4544
4545 Don't force ./temacs to start in terminal mode.
4546
4547 * frame.c (make_initial_frame): Initialize faces in all cases, not
4548 only when CANNOT_DUMP is defined.
4549 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4550
4551 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4552
4553 * dispnew.c (add_window_display_history): Use const for the string
4554 pointer. Remove declaration, not needed.
4555
4556 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4557
4558 Use 'inline', not 'INLINE'.
4559 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4560 * alloc.c, fontset.c (INLINE): Remove.
4561 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4562 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4563 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4564 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4565 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4566
4567 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4568
4569 Make it possible to run ./temacs.
4570
4571 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4572 syms_of_callproc does the same thing. Remove test for
4573 "initialized", do it in the caller.
4574 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4575
4576 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4577
4578 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4579 (read_minibuf): Use get_minibuffer.
4580 (syms_of_minibuf): Use DEFSYM.
4581 (Qmetadata): New var.
4582 * data.c (Qbuffer): Don't make it static.
4583 (syms_of_data): Use DEFSYM.
4584
4585 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4588 (CCL_CODE_MIN): New macro.
4589
4590 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4591
4592 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4593
4594 * eval.c (Qdebug): Now static.
4595 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4596 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4597 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4598
4599 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4600
4601 * image.c: Various fixes to ImageMagick code comments.
4602 (Fimagemagick_types): Doc fix.
4603
4604 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4605
4606 Minor fixes prompted by GCC 4.6.0 warnings.
4607
4608 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4609
4610 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4611 (x_clipboard_manager_save_all): Move extern decl to ...
4612 * xterm.h: ... here, so that it can be checked for consistency.
4613
4614 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4615
4616 * xselect.c (x_clipboard_manager_save_frame)
4617 (x_clipboard_manager_save_all): New functions.
4618 (Fx_clipboard_manager_save): Lisp function deleted.
4619
4620 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4621 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4622
4623 * xterm.h: Update prototype.
4624
4625 2011-05-28 William Xu <william.xwl@gmail.com>
4626
4627 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4628 exiting (Bug#8239).
4629
4630 2011-05-28 Jim Meyering <meyering@redhat.com>
4631
4632 Avoid a sign-extension bug in crypto_hash_function.
4633 * fns.c (to_uchar): Define.
4634 (crypto_hash_function): Use it to convert some newly-signed
4635 variables to unsigned, to avoid sign-extension bugs. For example,
4636 without this change, (md5 "truc") would evaluate to
4637 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4638 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4639 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4640
4641 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 Integer overflow fixes.
4644
4645 * dbusbind.c: Serial number integer overflow fixes.
4646 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4647 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4648 to hold a serial number that is too large for a fixnum.
4649 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4650 Check for serial numbers out of range. Decode any serial number
4651 that was so large that it became a float. (Bug#8722)
4652
4653 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4654 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4655 Use XFASTINT rather than XUINT when numbers are nonnegative.
4656 (xd_append_arg, Fdbus_method_return_internal):
4657 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4658 arguments, check that Lisp number is nonnegative, rather than
4659 silently wrapping negative numbers around. (Bug#8722)
4660 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4661 (Bug#8722)
4662
4663 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4664
4665 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4666
4667 ccl: add integer overflow checks
4668 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4669 (IN_INT_RANGE): New macros.
4670 (ccl_driver): Use them to check for integer overflow when
4671 decoding a CCL program. Many of the new checks are whether XINT (x)
4672 fits in int; it doesn't always, on 64-bit hosts. The new version
4673 doesn't catch all possible integer overflows, but it's an
4674 improvement. (Bug#8719)
4675
4676 * alloc.c (make_event_array): Use XINT, not XUINT.
4677 There's no need for unsigned here.
4678
4679 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4680 This follows up to the 2011-05-06 change that substituted uintptr_t
4681 for EMACS_INT. This case wasn't caught back then.
4682
4683 Rework Fformat to avoid integer overflow issues.
4684 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4685 now (part of C89). Include <verify.h>.
4686 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4687 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4688 (Fformat): Avoid the prepass trying to compute sizes; it was only
4689 approximate and thus did not catch overflow reliably. Instead, walk
4690 through the format just once, formatting and computing sizes as we go,
4691 checking for integer overflow at every step, and allocating a larger
4692 buffer as needed. Keep track separately whether the format is
4693 multibyte. Keep only the most-recently calculated precision, rather
4694 than them all. Record whether each argument has been converted to
4695 string. Use EMACS_INT, not int, for byte and char and arg counts.
4696 Support field widths and precisions larger than INT_MAX. Avoid
4697 sprintf's undefined behavior with conversion specifications such as %#d
4698 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4699 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4700 formatting out-of-range floating point numbers with int
4701 formats. (Bug#8668)
4702
4703 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4704
4705 * data.c: Avoid integer truncation in expressions involving floats.
4706 * data.c: Include <intprops.h>.
4707 (arith_driver): When there's an integer overflow in an expression
4708 involving floating point, convert the integers to floating point
4709 so that the resulting value does not suffer from catastrophic
4710 integer truncation. For example, on a 64-bit host (* 4
4711 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4712 Do not rely on undefined behavior after integer overflow.
4713
4714 merge count_size_as_multibyte, parse_str_to_multibyte
4715 * character.c, character.h (count_size_as_multibyte):
4716 Rename from parse_str_to_multibyte; all uses changed.
4717 Check for integer overflow.
4718 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4719 since it's now a duplicate of the other. This is more of
4720 a character than a buffer op, so better that it's in character.c.
4721 * fns.c, print.c: Adjust to above changes.
4722
4723 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4724
4725 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4726
4727 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4728
4729 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4730 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4731 (x_clipboard_manager_save): Now static.
4732 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4733
4734 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4735 (crypto_hash_function): Now static.
4736 Fix pointer signedness problems. Avoid unnecessary initializations.
4737
4738 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4739
4740 * termhooks.h (Vselection_alist): Make it terminal-local.
4741
4742 * terminal.c (create_terminal): Initialize it.
4743
4744 * xselect.c: Support for clipboard managers.
4745 (Vselection_alist): Move to termhooks.h as terminal-local var.
4746 (LOCAL_SELECTION): New macro.
4747 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4748 (symbol_to_x_atom): Remove gratuitous arg.
4749 (x_handle_selection_request, lisp_data_to_selection_data)
4750 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4751 (x_own_selection, x_get_local_selection, x_convert_selection):
4752 New arg, specifying work frame. Use terminal-local Vselection_alist.
4753 (some_frame_on_display): Delete unused function.
4754 (Fx_own_selection_internal, Fx_get_selection_internal)
4755 (Fx_disown_selection_internal, Fx_selection_owner_p)
4756 (Fx_selection_exists_p): New optional frame arg.
4757 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4758 (x_handle_selection_clear): Don't treat other terminals with the
4759 same keyboard specially. Use the terminal-local Vselection_alist.
4760 (x_clear_frame_selections): Use Frun_hook_with_args.
4761
4762 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4763
4764 * xterm.h: Add support for those atoms.
4765
4766 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4767
4768 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4769 (converted_selections, conversion_fail_tag): New global variables.
4770 (x_selection_request_lisp_error): Free the above.
4771 (x_get_local_selection): Remove unnecessary code.
4772 (x_reply_selection_request): Args changed; handle arbitrary array
4773 of converted selections stored in converted_selections.
4774 Separate the XChangeProperty and SelectionNotify steps.
4775 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4776 (x_convert_selection): New function.
4777 (x_handle_selection_event): Simplify.
4778 (x_get_foreign_selection): Don't ignore incoming requests while
4779 waiting for an answer; this will fail when we implement
4780 SAVE_TARGETS, and seems unnecessary anyway.
4781 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4782 (Vx_sent_selection_functions): Doc fix.
4783
4784 2011-05-26 Leo Liu <sdl.web@gmail.com>
4785
4786 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4787
4788 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4789
4790 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4791
4792 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4793 for fringe update if it has periodic bitmap.
4794 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4795 and fringe_bitmap_periodic_p.
4796
4797 * fringe.c (get_fringe_bitmap_data): New function.
4798 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4799 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4800 row. Mark glyph row for fringe update if periodicity changed.
4801
4802 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4803 for fringe update unless it has periodic bitmap.
4804
4805 2011-05-25 Kenichi Handa <handa@m17n.org>
4806
4807 * xdisp.c (get_next_display_element): Set correct it->face_id for
4808 a static composition.
4809
4810 2011-05-24 Leo Liu <sdl.web@gmail.com>
4811
4812 * deps.mk (fns.o):
4813 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4814
4815 * fns.c (crypto_hash_function, Fsha1): New function.
4816 (Fmd5): Use crypto_hash_function.
4817 (syms_of_fns): Add Ssha1.
4818
4819 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 * gnutls.c: Remove unused macros.
4822 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4823 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4824 Remove macros that are defined and never used.
4825 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4826
4827 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4828
4829 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4830 (Fx_get_selection_internal): Minor cleanup.
4831 (Fx_own_selection_internal): Rename arguments for consistency with
4832 select.el.
4833
4834 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4837
4838 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4841
4842 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4843
4844 * dispnew.c (scrolling_window): Don't exclude the case that the
4845 last enabled row in the desired matrix touches the bottom boundary.
4846
4847 2011-05-21 Glenn Morris <rgm@gnu.org>
4848
4849 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4850 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4851 and add some more files.
4852
4853 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4854
4855 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4856 report_file_error introduced by the change from 2011-05-07.
4857
4858 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4859
4860 * systime.h (Time): Define only if emacs is defined.
4861 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4862 where the include path doesn't have X11/X.h by default. See
4863 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4864
4865 2011-05-20 Kenichi Handa <handa@m17n.org>
4866
4867 * composite.c (find_automatic_composition): Fix previous change.
4868
4869 2011-05-20 Glenn Morris <rgm@gnu.org>
4870
4871 * lisp.mk: New file, split from Makefile.in.
4872 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4873 (shortlisp): Remove.
4874 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4875
4876 2011-05-19 Glenn Morris <rgm@gnu.org>
4877
4878 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4879 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4880 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4881 (lisp): Set the order to that of loadup.el.
4882 (shortlisp): Make it a copy of $lisp.
4883 (SOME_MACHINE_LISP): Remove.
4884 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4885 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4886
4887 2011-05-18 Kenichi Handa <handa@m17n.org>
4888
4889 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4890 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4891 (find_automatic_composition): Mostly rewrite for efficiency.
4892
4893 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * makefile.w32-in: Update dependencies.
4896
4897 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4898
4899 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4900 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4901
4902 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 Fix some integer overflow issues, such as string length overflow.
4905
4906 * insdel.c (count_size_as_multibyte): Check for string overflow.
4907
4908 * character.c (lisp_string_width): Check for string overflow.
4909 Use EMACS_INT, not int, for string indexes and lengths; in
4910 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4911 the resulting string length overflows an EMACS_INT; instead,
4912 report a string overflow if no precision given. When checking for
4913 precision exhaustion, use a check that cannot possibly have
4914 integer overflow. (Bug#8675)
4915 * character.h (lisp_string_width): Adjust to new signature.
4916
4917 * alloc.c (string_overflow): New function.
4918 (Fmake_string): Use it. This doesn't change behavior, but saves
4919 a few bytes and will simplify future changes.
4920 * character.c (string_escape_byte8): Likewise.
4921 * lisp.h (string_overflow): New decl.
4922
4923 Fixups, following up to the user-interface timestamp change.
4924 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4925 for UI timestamps, instead of unsigned long.
4926 * msdos.c (mouse_get_pos): Likewise.
4927 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4928 * w32gui.h (Time): Define by including "systime.h" rather than by
4929 declaring it ourselves. (Bug#8664)
4930
4931 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4932 * image.c (clear_image_cache): Likewise.
4933
4934 * term.c (term_mouse_position): Don't assume time_t wraparound.
4935
4936 Be more systematic about user-interface timestamps.
4937 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4938 and sometimes 'EMACS_UINT', to represent these timestamps.
4939 This change causes it to use 'Time' uniformly, as that's what X uses.
4940 This makes the code easier to follow, and makes it easier to catch
4941 integer overflow bugs such as Bug#8664.
4942 * frame.c (Fmouse_position, Fmouse_pixel_position):
4943 Use Time, not unsigned long, for user-interface timestamps.
4944 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4945 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4946 * keyboard.h (last_event_timestamp): Likewise.
4947 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4948 * menu.h (xmenu_show): Likewise.
4949 * term.c (term_mouse_position): Likewise.
4950 * termhooks.h (struct input_event.timestamp): Likewise.
4951 (struct terminal.mouse_position_hook): Likewise.
4952 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4953 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4954 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4955 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4956 what it was before.
4957 * menu.h, termhooks.h: Include "systime.h", for Time.
4958
4959 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4960 Don't assume that the difference between two unsigned long values
4961 can fit into an integer. At this point, we know button_down_time
4962 <= event->timestamp, so the difference must be nonnegative, so
4963 there's no need to cast the result if double-click-time is
4964 nonnegative, as it should be; check that it's nonnegative, just in
4965 case. This bug is triggered when events are more than 2**31 ms
4966 apart (about 25 days). (Bug#8664)
4967
4968 * xselect.c (last_event_timestamp): Remove duplicate decl.
4969 (x_own_selection): Remove needless cast to unsigned long.
4970
4971 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4972 that always fit in int. Use a sentinel instead of a counter, to
4973 avoid a temp and to allay GCC's concerns about possible int overflow.
4974 * frame.h (struct frame): Use int for menu_bar_items_used
4975 instead of EMACS_INT, since it always fits in int.
4976
4977 * menu.c (grow_menu_items): Check for int overflow.
4978
4979 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4980
4981 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4982 Before, the code was not consistent. These values cannot exceed
4983 2**31 - 1 so there's no need to make them unsigned.
4984 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4985 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4986 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4987 as modifiers.
4988 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4989
4990 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4991 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4992 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4993 presumably because the widths might not match.
4994
4995 * window.c (size_window): Avoid needless test at loop start.
4996
4997 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4998
4999 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5000
5001 2011-05-12 Drew Adams <drew.adams@oracle.com>
5002
5003 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5004
5005 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5006
5007 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5008 `width' to `bar_area_x' and `bar_area_width', respectively.
5009 (x_scroll_run): Take account of fringe background extension.
5010
5011 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5012 Rename local vars `left' and `width' to `bar_area_x' and
5013 `bar_area_width', respectively.
5014 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5015 background extension.
5016
5017 2011-05-10 Jim Meyering <meyering@redhat.com>
5018
5019 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5020
5021 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5022
5023 * image.c (Finit_image_library): Return t for built-in image types,
5024 like pbm and xbm. (Bug#8640)
5025
5026 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5027
5028 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5029
5030 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5031
5032 * w32console.c (Fset_screen_color): Doc fix.
5033 (Fget_screen_color): New function.
5034 (syms_of_ntterm): Defsubr it.
5035
5036 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5037 unlink the temporary file if Fcall_process didn't create it in the
5038 first place.
5039 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5040 child process will be redirected to a file specified with `:file'.
5041 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5042 cue to call_process_cleanup not to close that handle.
5043
5044 2011-05-07 Ben Key <bkey76@gmail.com>
5045
5046 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5047 one of two shell specific rules, either bootstrap-temacs-CMD or
5048 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5049 to the previous implementation of the bootstrap-temacs rule.
5050 The bootstrap-temacs-CMD rule is similar to the previous
5051 implementation of the bootstrap-temacs rule except that it
5052 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5053 variable.
5054
5055 These changes, along with some changes to nt/configure.bat,
5056 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5057 earlier fix to add support for --cflags and --ldflags options
5058 that include quotes so that it works whether make uses cmd or
5059 sh as the shell.
5060
5061 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5062
5063 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5064 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5065 is a constant.
5066 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5067 a string. Handle both cases.
5068 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5069 (Fdbus_register_method): Use Qinvalid_function.
5070
5071 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * makefile.w32-in: Update dependencies.
5074 (LISP_H): Add inttypes.h and stdin.h.
5075 (PROCESS_H): Add unistd.h.
5076
5077 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5078
5079 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5080 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5081
5082 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5083
5084 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5085
5086 * term.c (vfatal): Remove stray call to va_end.
5087 It's not needed and the C Standard doesn't allow it here anyway.
5088
5089 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5090 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5091
5092 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5093 bytes.
5094
5095 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5096
5097 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5098
5099 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5100
5101 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5102
5103 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5104
5105 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5106 * charset.c (Fdefine_charset_internal): Don't initialize
5107 charset.code_space[15]. The value was garbage, on hosts with
5108 32-bit int (Bug#8600).
5109
5110 * lread.c (read_integer): Be more consistent with string-to-number.
5111 Use string_to_number to do the actual conversion; this avoids
5112 rounding errors and fixes some other screwups. Without this fix,
5113 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5114 (digit_to_number): Move earlier, for benefit of read_integer.
5115 Return -1 if the digit is out of range for the base, -2 if it is
5116 not a digit in any supported base. (Bug#8602)
5117
5118 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5119
5120 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5121 to match comment at start of function. This also removes a
5122 GCC warning about overflow in a 32+64-bit port.
5123
5124 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5125
5126 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5127 Reported by Stefan Monnier in
5128 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5129 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5130 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5131
5132 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5133 (EMACS_UINTPTR): Likewise, with uintptr_t.
5134
5135 * lisp.h: Prefer 64-bit EMACS_INT if available.
5136 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5137 on 32-bit hosts that have 64-bit int, so that they can access
5138 large files.
5139 However, temporarily disable this change unless the temporary
5140 symbol WIDE_EMACS_INT is defined.
5141
5142 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5143
5144 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5145 This removes an assumption that EMACS_INT and long are the same
5146 width as pointers. The assumption is true for Emacs porting targets
5147 now, but we want to make other targets possible.
5148 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5149 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5150 In the rest of the code, change types of integers that hold casted
5151 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5152 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5153 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5154 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5155 No need to cast type when ORing.
5156 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5157 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5158 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5159 assume EMACS_INT is the same width as char *.
5160 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5161 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5162 Remove no-longer-needed casts.
5163 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5164 (xg_tool_bar_help_callback, xg_make_tool_item):
5165 Use EMACS_INTPTR to hold an integer
5166 that will be cast to void *; this can avoid a GCC warning
5167 if EMACS_INT is not the same width as void *.
5168 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5169 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5170 (current_message_1, set_message_1):
5171 Use a local to convert to proper width without a cast.
5172 * xmenu.c (dialog_selection_callback): Likewise.
5173
5174 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5175 Also, don't assume VALBITS / RAND_BITS is less than 5,
5176 and don't rely on undefined behavior when shifting a 1 left into
5177 the sign bit.
5178 * lisp.h (get_random): Change signature to match.
5179
5180 * lread.c (hash_string): Use size_t, not int, for hash computation.
5181 Normally we prefer signed values; but hashing is special, because
5182 it's better to use unsigned division on hash table sizes so that
5183 the remainder is nonnegative. Also, size_t is the natural width
5184 for hashing into memory. The previous code used 'int', which doesn't
5185 retain enough info to hash well into very large tables.
5186 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5187
5188 * dbusbind.c: Don't possibly lose pointer info when converting.
5189 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5190 Use XPNTR rather than XHASH, so that the high-order bits of
5191 the pointer aren't lost when converting through void *.
5192
5193 * eval.c (Fautoload): Don't double-shift a pointer.
5194
5195 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5196
5197 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5198
5199 * gnutls.c (DEF_GNUTLS_FN):
5200 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5201
5202 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5203
5204 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5205 marker. (Bug#8610)
5206
5207 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5208
5209 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5210 New version that can reserve upto 2GB of heap space.
5211
5212 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5213
5214 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5215
5216 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5217
5218 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5219 `gnutls_certificate_set_x509_key_file'.
5220
5221 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5222
5223 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5224 Update dependencies.
5225
5226 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5227
5228 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5229 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5230 Remove unused parameter `fildes'.
5231 * process.c (read_process_output, send_process): Don't pass it.
5232
5233 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5234
5235 Fix previous change: the library cache is defined in w32.c.
5236 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5237 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5238
5239 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5240
5241 Implement dynamic loading of GnuTLS on Windows.
5242
5243 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5244 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5245 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5246 Declare.
5247
5248 * gnutls.c (Qgnutls_dll): Define.
5249 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5250 (gnutls_*): Declare function pointers.
5251 (init_gnutls_functions): New function to initialize function pointers.
5252 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5253 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5254 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5255 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5256 (emacs_gnutls_write, emacs_gnutls_read)
5257 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5258 (Fgnutls_available_p): New function.
5259 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5260 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5261 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5262
5263 * image.c: Include w32.h.
5264 (Vimage_type_cache): Delete.
5265 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5266 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5267 (w32_delayed_load): Move to w32.c.
5268
5269 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5270
5271 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5272 (w32_delayed_load): Move from image.c. When loading a library, record
5273 its filename in the :loaded-from property of the library id.
5274 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5275 Initialize and staticpro them.
5276 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5277
5278 * process.c: Include lisp.h before w32.h, not after.
5279 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5280 instead of gnutls_record_check_pending.
5281
5282 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5283
5284 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5285
5286 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5287 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5288 as passed in.
5289
5290 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5291
5292 * xterm.c (x_set_frame_alpha): Do not set property on anything
5293 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5294
5295 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5296
5297 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5298
5299 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5300
5301 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5302 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5303 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5304 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5305 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5306 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5307 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5308 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5309 (Qgnutls_bootprop_callbacks_verify): Make static.
5310
5311 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5312
5313 * callproc.c: Indentation fixup.
5314
5315 * sysdep.c (wait_for_termination_1): Make static.
5316 (wait_for_termination, interruptible_wait_for_termination):
5317 Move after wait_for_termination_1.
5318
5319 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5320
5321 * sysdep.c (interruptible_wait_for_termination): New function
5322 which is like wait_for_termination, but allows keyboard
5323 interruptions.
5324
5325 * callproc.c (Fcall_process): Add (:file "file") as an option for
5326 the STDOUT buffer.
5327 (Fcall_process_region): Ditto.
5328
5329 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5330
5331 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5332 rather than `XVECTOR (FOO)->size'.
5333
5334 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5335 inttypes.h, as a gnulib replacement is used if it not available in
5336 system headers.
5337
5338 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5339
5340 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5341 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5342 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5343
5344 * coding.c (coding_alloc_by_realloc): Error out if destination
5345 will grow beyond MOST_POSITIVE_FIXNUM.
5346 (decode_coding_emacs_mule): Abort if there isn't enough place in
5347 charbuf for the composition carryover bytes. Reserve an extra
5348 space for up to 2 characters produced in a loop.
5349 (decode_coding_iso_2022): Abort if there isn't enough place in
5350 charbuf for the composition carryover bytes.
5351
5352 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5353
5354 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5355 aborting when %lld or %lll format is passed.
5356 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5357 %llo or %llx format is passed. (Bug#8545)
5358
5359 * window.c (window_scroll_line_based): Use a marker instead of
5360 simple variables to record original value of point. (Bug#7952)
5361
5362 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5363 produced by %s or %c overflows available buffer space. (Bug#8545)
5364
5365 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5366
5367 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5368 (SIZE_MAX): Move defn after all includes, as they might #define it.
5369
5370 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5371
5372 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5373
5374 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5375
5376 * keyboard.c (Qdelayed_warnings_hook): Define.
5377 (command_loop_1): Run `delayed-warnings-hook'
5378 if Vdelayed_warnings_list is non-nil.
5379 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5380 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5381
5382 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5383
5384 * doprnt.c (doprnt): Don't return value smaller than the buffer
5385 size if the message was truncated. (Bug#8545).
5386
5387 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5388
5389 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5390 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5391
5392 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5395
5396 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5397
5398 * makefile.w32-in: Update dependencies.
5399
5400 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5401
5402 Improve `doprnt' and its usage. (Bug#8545)
5403 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5404 `format_end'. Remove support for %l as a conversion specifier.
5405 Don't use xrealloc. Improve diagnostics when the %l size modifier
5406 is used. Update the commentary.
5407
5408 * eval.c (verror): Simplify calculation of size_t.
5409
5410 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5411 messages.
5412
5413 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5414
5415 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5416 change.
5417
5418 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5419
5420 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5421 This makes this file independent of the recent pseudovector change.
5422
5423 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5424
5425 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5426
5427 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5428 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5429 Remove unused local.
5430 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5431
5432 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5433 GCC 4.6.0 optimizes based on type-based alias analysis.
5434 For example, if b is of type struct buffer * and v of type struct
5435 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5436 != &v->size, and therefore "v->size = 1; b->size = 2; return
5437 v->size;" must therefore return 1. This assumption is incorrect
5438 for Emacs, since it type-puns struct Lisp_Vector * with many other
5439 types. To fix this problem, this patch adds a new type struct
5440 vectorlike_header that documents the constraints on layout of vectors
5441 and pseudovectors, and helps optimizing compilers not get fooled
5442 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5443 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5444 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5445 the size member.
5446 (XSETPVECTYPE): Rewrite in terms of new macro.
5447 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5448 This is a bit clearer, and further avoids the possibility of
5449 undesirable aliasing.
5450 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5451 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5452 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5453 since Lisp_Subr is a special case (no "next" field).
5454 (ASIZE): Now uses header.size rather than size.
5455 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5456 to avoid the hassle of writing XVECTOR (foo)->header.size.
5457 (struct vectorlike_header): New type.
5458 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5459 object, to help avoid aliasing.
5460 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5461 (SUBRP): Likewise, since Lisp_Subr is a special case.
5462 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5463 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5464 (struct Lisp_Hash_Table): Combine first two members into a single
5465 struct vectorlike_header member. All uses of "size" and "next" members
5466 changed to be "header.size" and "header.next".
5467 * buffer.h (struct buffer): Likewise.
5468 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5469 * frame.h (struct frame): Likewise.
5470 * process.h (struct Lisp_Process): Likewise.
5471 * termhooks.h (struct terminal): Likewise.
5472 * window.c (struct save_window_data, struct saved_window): Likewise.
5473 * window.h (struct window): Likewise.
5474 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5475 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5476 * buffer.c (init_buffer_once): Likewise.
5477 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5478 special case.
5479 * process.c (Fformat_network_address): Use local var for size,
5480 for brevity.
5481
5482 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5483
5484 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5485 * data.c (atof): Remove decl; no longer used or needed.
5486 (digit_to_number): Move to lread.c.
5487 (Fstring_to_number): Use new string_to_number function, to be
5488 consistent with how the Lisp reader treats infinities and NaNs.
5489 Do not assume that floating-point numbers represent EMACS_INT
5490 without losing information; this is not true on most 64-bit hosts.
5491 Avoid double-rounding errors, by insisting on integers when
5492 parsing non-base-10 numbers, as the documentation specifies.
5493 * lisp.h (string_to_number): New decl, replacing ...
5494 (isfloat_string): Remove.
5495 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5496 (read1): Do not accept +. and -. as integers; this
5497 appears to have been a coding error. Similarly, do not accept
5498 strings like +-1e0 as floating point numbers. Do not report
5499 overflow for integer overflows unless the base is not 10 which
5500 means we have no simple and reliable way to continue.
5501 Break out the floating-point parsing into a new
5502 function string_to_number, so that Fstring_to_number parses
5503 floating point numbers consistently with the Lisp reader.
5504 (digit_to_number): Move here from data.c. Make it static inline.
5505 (E_CHAR, EXP_INT): Remove, replacing with ...
5506 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5507 (string_to_number): New function, replacing isfloat_string.
5508 This function checks for valid syntax and produces the resulting
5509 Lisp float number too. Rework it so that string-to-number
5510 no longer mishandles examples like "1.0e+". Use strtoumax,
5511 so that overflow for non-base-10 numbers is reported only when
5512 there's no portable and simple way to convert to floating point.
5513
5514 * textprop.c (set_text_properties_1): Rewrite for clarity,
5515 and to avoid GCC warning about integer overflow.
5516
5517 * intervals.h (struct interval): Use EMACS_INT for members
5518 where EMACS_UINT might cause problems. See
5519 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5520 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5521 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5522 All uses changed.
5523 (offset_intervals): Tell GCC not to worry about length overflow
5524 when negating a negative length.
5525
5526 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5527 (overrun_check_free): Likewise.
5528
5529 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5530 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5531 word size.
5532
5533 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5534 (gnutls_make_error): Rename local to avoid shadowing.
5535 (gnutls_emacs_global_deinit): ifdef out; not used.
5536 (Fgnutls_boot): Use const for pointer to readonly storage.
5537 Comment out unused local. Fix pointer signedness problems.
5538
5539 * lread.c (openp): Don't stuff size_t into an 'int'.
5540 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5541 about possible signed overflow.
5542
5543 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5544 (GDK_KEY_g): Don't define if already defined.
5545 (xg_prepare_tooltip): Avoid pointer signedness problem.
5546 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5547
5548 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5549 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5550
5551 * xfns.c (Fx_window_property): Simplify a bit,
5552 to make a bit faster and to avoid GCC 4.6.0 warning.
5553 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5554
5555 * fns.c (internal_equal): Don't assume size_t fits in int.
5556
5557 * alloc.c (compact_small_strings): Tighten assertion a little.
5558
5559 Replace pEd with more-general pI, and fix some printf arg casts.
5560 * lisp.h (pI): New macro, generalizing old pEd macro to other
5561 conversion specifiers. For example, use "...%"pI"d..." rather
5562 than "...%"pEd"...".
5563 (pEd): Remove. All uses replaced with similar uses of pI.
5564 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5565 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5566 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5567 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5568 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5569 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5570 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5571 64-bit hosts.
5572 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5573 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5574 * print.c (safe_debug_print, print_object): Likewise.
5575 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5576 to int.
5577 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5578 avoiding the 0 flag, which is not portable.
5579 * process.c (Fmake_network_process): Use pI to avoid cast.
5580 * region-cache.c (pp_cache): Likewise.
5581 * xdisp.c (decode_mode_spec): Likewise.
5582 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5583 behavior on 64-bit hosts with printf arg.
5584 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5585 (x_stop_queuing_selection_requests): Likewise.
5586 (x_get_window_property): Don't truncate byte count to an 'int'
5587 when tracing.
5588
5589 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5590 here, since it parses constructs like leading '-' and spaces,
5591 which are not wanted; and it overflows with large numbers.
5592 Instead, simply match F[0-9]+, which is what is wanted anyway.
5593
5594 * alloc.c: Remove unportable assumptions about struct layout.
5595 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5596 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5597 (allocate_vectorlike, make_pure_vector): Use the new macros,
5598 plus offsetof, to remove unportable assumptions about struct layout.
5599 These assumptions hold on all porting targets that I know of, but
5600 they are not guaranteed, they're easy to remove, and removing them
5601 makes further changes easier.
5602
5603 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5604 This doesn't fix a bug but makes the code clearer.
5605 (string_overrun_cookie): Now const. Use initializers that
5606 don't formally overflow signed char, to avoid warnings.
5607 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5608 can cause Emacs to crash when string overrun checking is enabled.
5609 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5610 multiple of sizeof (EMACS_INT); it need not be, if
5611 alignof(EMACS_INT) < sizeof (EMACS_INT).
5612 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5613
5614 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5615
5616 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5617
5618 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5619
5620 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5621 supposed to be handshaking. (Bug#8556)
5622 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5623
5624 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5625
5626 * lisp.h (Qdebug): List symbol.
5627 * eval.c (Qdebug): Restore global linkage.
5628 * keyboard.c (debug-on-event): New variable.
5629 (handle_user_signal): Break into debugger when debug-on-event
5630 matches the current signal symbol.
5631
5632 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5633
5634 * alloc.c (check_sblock, check_string_bytes)
5635 (check_string_free_list): Convert to standard C.
5636
5637 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5638
5639 * w32.c (emacs_gnutls_push): Fix typo.
5640
5641 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5642
5643 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5644 "cast to pointer from integer of different size".
5645
5646 Improve doprnt and its use in verror. (Bug#8545)
5647 * doprnt.c (doprnt): Document the set of format control sequences
5648 supported by the function. Use SAFE_ALLOCA instead of always
5649 using `alloca'.
5650
5651 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5652 is one byte too soon. Don't use xrealloc; instead xfree and
5653 xmalloc anew.
5654
5655 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5656
5657 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5658 callbacks stage.
5659
5660 * gnutls.c: Renamed global_initialized to
5661 gnutls_global_initialized. Added internals for the
5662 :verify-hostname-error, :verify-error, and :verify-flags
5663 parameters of `gnutls-boot' and documented those parameters in the
5664 docstring. Start callback support.
5665 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5666 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5667 on error. Return error code.
5668 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5669 (emacs_gnutls_read): Likewise.
5670 (Fgnutls_boot): Return handshake error code.
5671 (emacs_gnutls_handle_error): New function.
5672 (wsaerror_to_errno): Likewise.
5673
5674 * w32.h (emacs_gnutls_pull): Add prototype.
5675 (emacs_gnutls_push): Likewise.
5676
5677 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5678 (emacs_gnutls_push): Likewise.
5679
5680 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5681
5682 * process.c (wait_reading_process_output): Check if GnuTLS
5683 buffered some data internally if no FDs are set for TLS
5684 connections.
5685
5686 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5687 (LIBS): Link to USER_LIBS.
5688 ($(BLD)/gnutls.$(0)): New target.
5689
5690 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5691
5692 * xdisp.c (handle_single_display_spec): Rename the
5693 display_replaced_before_p argument into display_replaced_p, to
5694 make it consistent with the commentary. Fix typos in the
5695 commentary.
5696
5697 * textprop.c (syms_of_textprop): Remove dead code.
5698 (copy_text_properties): Delete obsolete commentary about an
5699 interface that was deleted long ago. Fix typos in the description
5700 of arguments.
5701
5702 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5703 to changes in oldXMenu/XMenu.h from 2011-04-16.
5704 <menu_help_message, prev_menu_help_message>: Constify.
5705 (IT_menu_make_room): menu->help_text is now `const char **';
5706 adjust.
5707
5708 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5709 to changes in oldXMenu/XMenu.h from 2011-04-16.
5710 (struct XMenu): Declare `help_text' `const char **'.
5711
5712 * xfaces.c <Qunspecified>: Make extern again.
5713
5714 * syntax.c: Include sys/types.h before including regex.h, as
5715 required by Posix.
5716
5717 * doc.c (get_doc_string): Improve the format passed to `error'.
5718
5719 * doprnt.c (doprnt): Improve commentary.
5720
5721 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5722
5723 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5724 them with etags.
5725
5726 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5727 changes in globals.h immediately force recompilation.
5728 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5729 $(CURDIR)/s/ms-w32.h.
5730 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5731
5732 * character.c (Fchar_direction): Function deleted.
5733 (syms_of_character): Don't defsubr it.
5734 <char-direction-table>: Deleted.
5735
5736 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5737
5738 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5739 * doprnt.c: Include limits.h.
5740 (SIZE_MAX): New macro.
5741 (doprnt): Return a size_t value. 2nd arg is now size_t.
5742 Many local variables are now size_t instead of int or unsigned.
5743 Improve overflow protection. Support `l' modifier for integer
5744 conversions. Support %l conversion. Don't assume an EMACS_INT
5745 argument for integer conversions and for %c.
5746
5747 * lisp.h (doprnt): Restore prototype.
5748
5749 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5750 $(SRC)/character.h.
5751
5752 * Makefile.in (base_obj): Add back doprnt.o.
5753
5754 * deps.mk (doprnt.o): Add back prerequisites.
5755 (callint.o): Depend on character.h.
5756
5757 * eval.c (internal_lisp_condition_case): Include the handler
5758 representation in the error message.
5759 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5760 when breaking from the loop.
5761
5762 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5763
5764 * callint.c (Fcall_interactively): When displaying error message
5765 about invalid control letter, pass the character's codepoint, not
5766 a pointer to its multibyte form. Improve display of the character
5767 in octal and display also its hex code.
5768
5769 * character.c (char_string): Use %x to display the (unsigned)
5770 codepoint of an invalid character, to avoid displaying a bogus
5771 negative value.
5772
5773 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5774 `error', not SYMBOL_NAME itself.
5775
5776 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5777 character arguments to `error'.
5778
5779 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5780 to `error' in error message about FINAL_CHAR argument. Make sure
5781 FINAL_CHAR is a character, and use %c when it is passed as
5782 argument to `error'.
5783
5784 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5785
5786 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5787
5788 * w32.c: Include <time.h>.
5789 (sys_localtime): New function.
5790
5791 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5792
5793 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5794
5795 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5796
5797 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5798
5799 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5800 zombies (Bug#8467).
5801
5802 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5803
5804 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5805 gl_state.e_property when gl_state.object is Qt.
5806
5807 * insdel.c (make_gap_larger): Remove limitation of buffer size
5808 to <= INT_MAX.
5809
5810 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5811
5812 * xdisp.c (lookup_glyphless_char_display)
5813 (produce_glyphless_glyph): Handle cons cell entry in
5814 glyphless-char-display.
5815 (Vglyphless_char_display): Document it.
5816
5817 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5818 glyphless-char-display.
5819
5820 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5821
5822 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5823
5824 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5825
5826 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5827 definition for no-X builds.
5828
5829 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5830
5831 Static checks with GCC 4.6.0 and non-default toolkits.
5832
5833 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5834
5835 * process.c (keyboard_bit_set): Define only if SIGIO.
5836 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5837 (send_process): Repair possible setjmp clobbering.
5838
5839 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5840
5841 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5842
5843 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5844
5845 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5846 Define only if needed.
5847
5848 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5849 by pacifying GCC about it. Maybe it's time to retire it?
5850 * xfaces.c (USG, __TIMEVAL__): Likewise.
5851
5852 * dispextern.h (struct redisplay_interface): Rename param
5853 to avoid shadowing.
5854 * termhooks.h (struct terminal): Likewise.
5855 * xterm.c (xembed_send_message): Likewise.
5856
5857 * insdel.c (make_gap_smaller): Define only if
5858 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5859
5860 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5861 it.
5862
5863 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5864 so that we aren't warned about unused symbols.
5865
5866 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5867
5868 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5869
5870 * xfns.c (x_real_positions): Mark locals as initialized.
5871
5872 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5873
5874 * xterm.c: Fix problems found by static analysis with other toolkits.
5875 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5876 (x_dispatch_event): Declare static if USE_GTK, and
5877 define if USE_GTK || USE_X_TOOLKIT.
5878 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5879 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5880 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5881 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5882
5883 * xmenu.c (menu_help_callback): Pointer type fixes.
5884 Use const pointers when pointing at readonly data. Avoid pointer
5885 signedness clashes.
5886 (FALSE): Remove unused macro.
5887 (update_frame_menubar): Remove unused decl.
5888
5889 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5890
5891 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5892 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5893 (single_menu_item): Rename local to avoid shadowing.
5894
5895 * keyboard.c (make_lispy_event): Remove unused local var.
5896
5897 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5898 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5899
5900 * bitmaps: Change bitmaps from unsigned char back to the X11
5901 compatible char. Avoid the old compiler warnings about
5902 out-of-range initializers by using, for example, '\xab' rather
5903 than 0xab.
5904
5905 * xgselect.c (xgselect_initialize): Check vs interface
5906 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5907
5908 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5909
5910 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5911 to read-only memory.
5912
5913 * fns.c (vector): Remove; this old hack is no longer needed.
5914
5915 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5916 Remove unused var.
5917 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5918
5919 * xrdb.c (x_load_resources): Omit unused local.
5920
5921 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5922 (x_window): Rename locals to avoid shadowing.
5923 (USG): Use the kludged USG macro, to pacify gcc.
5924
5925 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5926 (x_term_init): Remove local to avoid shadowing.
5927
5928 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5929
5930 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5931 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5932
5933 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5934
5935 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5936
5937 Fix regex.c, syntax.c and friends for buffers > 2GB.
5938 * syntax.h (struct gl_state_s): Declare character position members
5939 EMACS_INT.
5940
5941 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5942
5943 * textprop.c (verify_interval_modification, interval_of):
5944 Declare arguments EMACS_INT.
5945
5946 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5947 EMACS_INT.
5948
5949 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5950
5951 * indent.c (Fvertical_motion): Local variable it_start is now
5952 EMACS_INT.
5953
5954 * regex.c (re_match, re_match_2, re_match_2_internal)
5955 (bcmp_translate, regcomp, regexec, print_double_string)
5956 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5957 (re_compile_pattern, re_exec): Declare arguments and local
5958 variables `size_t' and `ssize_t' and return values `regoff_t', as
5959 appropriate.
5960 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5961 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5962 <compile_stack_type>: `size' and `avail' are now `size_t'.
5963
5964 * regex.h <regoff_t>: Use ssize_t, not int.
5965 (re_search, re_search_2, re_match, re_match_2): Arguments that
5966 specify buffer/string position and length are now ssize_t and
5967 size_t. Return type is regoff_t.
5968
5969 2011-04-16 Ben Key <bkey76@gmail.com>
5970
5971 * nsfont.m: Fixed bugs in ns_get_family and
5972 ns_descriptor_to_entity that were caused by using free to
5973 deallocate memory blocks that were allocated by xmalloc (via
5974 xstrdup). This caused Emacs to crash when compiled with
5975 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5976 --enable-checking=xmallocoverrun). xfree is now used to
5977 deallocate these memory blocks.
5978
5979 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5980
5981 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5982
5983 emacs_write: Accept and return EMACS_INT for sizes.
5984 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5985 et seq.
5986 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5987 Accept and return EMACS_INT.
5988 (emacs_gnutls_write): Return the number of bytes written on
5989 partial writes.
5990 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5991 (emacs_read, emacs_write): Remove check for negative size, as the
5992 Emacs source code has been audited now.
5993 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5994 (emacs_read, emacs_write): Use it.
5995 * process.c (send_process): Adjust to the new signatures of
5996 emacs_write and emacs_gnutls_write. Do not attempt to store
5997 a byte offset into an 'int'; it might overflow.
5998 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5999
6000 * sound.c: Don't assume sizes fit in 'int'.
6001 (struct sound_device.period_size, alsa_period_size):
6002 Return EMACS_INT, not int.
6003 (struct sound_device.write, vox_write, alsa_write):
6004 Accept EMACS_INT, not int.
6005 (wav_play, au_play): Use EMACS_INT to store sizes and to
6006 record read return values.
6007
6008 2011-04-15 Ben Key <bkey76@gmail.com>
6009
6010 * keyboard.c (Qundefined): Don't declare static since it is used
6011 in nsfns.m.
6012 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6013 static since they are used in nsfont.m.
6014
6015 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6016
6017 * process.c (Qprocessp): Don't declare static.
6018 * lisp.h (Qprocessp): Declare again.
6019
6020 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6021
6022 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6023
6024 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6025
6026 Improve C-level modularity by making more things 'static'.
6027
6028 Don't publish debugger-only interfaces to other modules.
6029 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6030 (verify_bytepos, count_markers): Move decls to the only modules
6031 that need them.
6032 * region-cache.h (pp_cache): Likewise.
6033 * window.h (check_all_windows): Likewise.
6034 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6035
6036 * sysdep.c (croak): Now static, if
6037 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6038 * syssignal.h (croak): Declare only if not static.
6039
6040 * alloc.c (refill_memory_reserve): Now static if
6041 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6042 * lisp.h (refill_memory_reserve): Declare only if not static.
6043
6044 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6045 Define only if USE_LUCID.
6046
6047 * xrdb.c (x_customization_string, x_rm_string): Now static.
6048
6049 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6050 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6051
6052 * xdisp.c (draw_row_with_mouse_face): Now static.
6053 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6054
6055 * window.h (check_all_windows): Mark externally visible.
6056
6057 * window.c (window_deletion_count): Now static.
6058
6059 * undo.c: Make symbols static if they're not exported.
6060 (last_undo_buffer, last_boundary_position, pending_boundary):
6061 Now static.
6062
6063 * textprop.c (interval_insert_behind_hooks): Now static.
6064 (interval_insert_in_front_hooks): Likewise.
6065
6066 * term.c: Make symbols static if they're not exported.
6067 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6068 (max_frame_lines, tty_set_terminal_modes):
6069 (tty_reset_terminal_modes, tty_turn_off_highlight):
6070 (get_tty_terminal): Now static.
6071 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6072 * termhooks.h (term_mouse_moveto): Do not declare if
6073 HAVE_WINDOW_SYSTEM.
6074 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6075 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6076
6077 * sysdep.c: Make symbols static if they're not exported.
6078 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6079 Now static.
6080 (sigprocmask_set, full_mask): Remove; unused.
6081 (wait_debugging): Mark as visible.
6082 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6083 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6084
6085 * syntax.c (syntax_temp): Define only if !__GNUC__.
6086
6087 * sound.c (current_sound_device, current_sound): Now static.
6088
6089 * search.c (searchbufs, searchbuf_head): Now static.
6090
6091 * scroll.c (scroll_cost): Remove; unused.
6092 * dispextern.h (scroll_cost): Remove decl.
6093
6094 * region-cache.h (pp_cache): Mark as externally visible.
6095
6096 * process.c: Make symbols static if they're not exported.
6097 (process_tick, update_tick, create_process, chan_process):
6098 (Vprocess_alist, proc_buffered_char, datagram_access):
6099 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6100 (deactivate_process): Mark defn as static, as well as decl.
6101 * lisp.h (create_process): Remove decl.
6102 * process.h (chan_process, Vprocess_alist): Remove decls.
6103
6104 * print.c: Make symbols static if they're not exported.
6105 (print_depth, new_backquote_output, being_printed, print_buffer):
6106 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6107 (print_interval, print_number_index, initial_stderr_stream):
6108 Now static.
6109 * lisp.h (Fprinc): Remove decl.
6110 (debug_output_compilation_hack): Mark as externally visible.
6111
6112 * sysdep.c (croak): Move decl from here to syssignal.h.
6113 * syssignal.h (croak): Put it here, so the API can be checked when
6114 'croak' is called from dissociate_if_controlling_tty.
6115
6116 * minibuf.c: Make symbols static if they're not exported.
6117 (minibuf_save_list, choose_minibuf_frame): Now static.
6118 * lisp.h (choose_minibuf_frame): Remove decl.
6119
6120 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6121
6122 * lread.c: Make symbols static if they're not exported.
6123 (read_objects, initial_obarray, oblookup_last_bucket_number):
6124 Now static.
6125 (make_symbol): Remove; unused.
6126 * lisp.h (initial_obarray, make_symbol): Remove decls.
6127
6128 * keyboard.c: Make symbols static if they're not exported.
6129 (single_kboard, recent_keys_index, total_keys, recent_keys):
6130 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6131 (this_single_command_key_start, echoing, last_auto_save):
6132 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6133 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6134 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6135 (Vlispy_mouse_stem, double_click_count):
6136 Now static.
6137 (force_auto_save_soon): Define only if SIGDANGER.
6138 (ignore_mouse_drag_p): Now static if
6139 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6140 (print_help): Remove; unused.
6141 (stop_character, last_timer_event): Mark as externally visible.
6142 * keyboard.h (ignore_mouse_drag_p): Declare only if
6143 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6144 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6145 * lisp.h (echoing): Remove decl.
6146 (force_auto_save_soon): Declare only if SIGDANGER.
6147 * xdisp.c (redisplay_window): Simplify code, to make it more
6148 obvious that ignore_mouse_drag_p is not accessed if !defined
6149 USE_GTK && !defined HAVE_NS.
6150
6151 * intervals.c: Make symbols static if they're not exported.
6152 (merge_properties_sticky, merge_interval_right, delete_interval):
6153 Now static.
6154 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6155
6156 * insdel.c: Make symbols static if they're not exported.
6157 However, leave prepare_to_modify_buffer alone. It's never
6158 called from outside this function, but that appears to be a bug.
6159 (combine_after_change_list, combine_after_change_buffer):
6160 (adjust_after_replace, signal_before_change): Now static.
6161 (adjust_after_replace_noundo): Remove; unused.
6162 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6163 (signal_before_change): Remove decls.
6164
6165 * indent.c (val_compute_motion, val_vmotion): Now static.
6166
6167 * image.c: Make symbols static if they're not exported.
6168 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6169 if USE_GTK.
6170 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6171 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6172
6173 * fringe.c (standard_bitmaps): Now static.
6174 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6175
6176 * frame.c: Make symbols static if they're not exported.
6177 (x_report_frame_params, make_terminal_frame): Now static.
6178 (get_frame_param): Now static, unless HAVE_NS.
6179 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6180 (x_get_resource_string): Remove; not used.
6181 * frame.h (make_terminal_frame, x_report_frame_params):
6182 (x_get_resource_string); Remove decls.
6183 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6184 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6185
6186 * font.c, fontset.c: Make symbols static if they're not exported.
6187 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6188 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6189 * font.c (font_close_object): Now static.
6190 * font.h (font_close_object): Remove.
6191 * fontset.c (FONTSET_OBJLIST): Remove.
6192 (free_realized_fontset) #if-0 the body, which does nothing.
6193 (face_suitable_for_char_p): #if-0, as it's never called.
6194 * fontset.h (face_suitable_for_char_p): Remove decl.
6195 * xfaces.c (face_at_string_position):
6196 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6197 since 0 is always ASCII.
6198
6199 * fns.c (weak_hash_tables): Now static.
6200
6201 * fileio.c: Make symbols static if they're not exported.
6202 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6203 (Vwrite_region_annotation_buffers): Now static.
6204
6205 * eval.c: Make symbols static if they're not exported.
6206 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6207 * lisp.h (backtrace_list): Remove decl.
6208
6209 * emacs.c: Make symbols static if they're not exported.
6210 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6211 (fatal_error_code, fatal_error_signal_hook, standard_args):
6212 Now static.
6213 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6214 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6215 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6216 * lisp.h (fatal_error_signal_hook): Remove decl.
6217 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6218
6219 * editfns.c: Move a (normally-unused) function to its only use.
6220 * editfns.c, lisp.h (get_operating_system_release): Remove.
6221 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6222 worth the hassle of breaking this out.
6223
6224 * xterm.c: Make symbols static if they're not exported.
6225 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6226 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6227 (x_destroy_window, x_delete_display):
6228 Now static.
6229 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6230 (x_mouse_leave): Remove; unused.
6231 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6232 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6233 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6234 Remove decls.
6235 (x_mouse_leave): Declare only if WINDOWSNT.
6236 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6237 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6238 USE_X_TOOLKIT.
6239
6240 * ftxfont.c: Make symbols static if they're not exported.
6241 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6242 HAVE_FREETYPE.
6243 * font.h (ftxfont_driver): Likewise.
6244
6245 * xfns.c: Make symbols static if they're not exported.
6246 (x_last_font_name, x_display_info_for_name):
6247 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6248 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6249 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6250 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6251 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6252 (last_show_tip_args): Now static.
6253 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6254 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6255 (x_screen_planes): Remove; unused.
6256 * dispextern.h (x_screen_planes): Remove decl.
6257
6258 * dispnew.c: Make symbols static if they're not exported.
6259 * dispextern.h (redraw_garbaged_frames, scrolling):
6260 (increment_row_positions): Remove.
6261 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6262 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6263 Now static.
6264 (redraw_garbaged_frames): Remove; unused.
6265
6266 * xfaces.c: Make symbols static if they're not exported.
6267 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6268 Remove decls.
6269 * xterm.h (defined_color): Remove decls.
6270 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6271 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6272 (menu_face_changed_default, defined_color, free_realized_face):
6273 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6274 (ascii_face_of_lisp_face): Remove; unused.
6275
6276 * xdisp.c: Make symbols static if they're not exported.
6277 * dispextern.h (scratch_glyph_row, window_box_edges):
6278 (glyph_to_pixel_coords, set_cursor_from_row):
6279 (get_next_display_element, set_iterator_to_next):
6280 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6281 (show_mouse_face): Remove decls
6282 * frame.h (message_buf_print): Likewise.
6283 * lisp.h (pop_message, set_message, check_point_in_composition):
6284 Likewise.
6285 * xterm.h (set_vertical_scroll_bar): Likewise.
6286 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6287 (message_buf_print, scratch_glyph_row, displayed_buffer):
6288 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6289 (get_next_display_element, show_mouse_face, window_box_edges):
6290 (frame_to_window_pixel_xy, check_point_in_composition):
6291 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6292 (glyph_to_pixel_coords): Remove; unused.
6293
6294 * dired.c (file_name_completion): Now static.
6295
6296 * dbusbind.c (xd_in_read_queued_messages): Now static.
6297
6298 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6299 * data.c (circular_list_error): Remove.
6300
6301 * commands.h (last_point_position, last_point_position_buffer):
6302 (last_point_position_window): Remove decls.
6303 * keyboard.c: Make these variables static.
6304
6305 * coding.h (coding, code_convert_region, encode_coding_gap):
6306 Remove decls.
6307 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6308 (iso_code_class, detect_coding, code_convert_region): Now static.
6309 (encode_coding_gap): Remove; unused.
6310
6311 * chartab.c (chartab_chars, chartab_bits): Now static.
6312
6313 * charset.h (charset_iso_8859_1): Remove decl.
6314 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6315 Now static.
6316
6317 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6318 * ccl.c (Vccl_program_table): Now static.
6319 (check_ccl_update): Remove; unused.
6320
6321 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6322 * category.h: ... from here.
6323 * category.c (check_category_table, set_category_set): Now static.
6324
6325 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6326 * lisp.h: Remove these decls.
6327
6328 * buffer.c (buffer_count): Remove unused var.
6329
6330 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6331 so that it's not optimized away.
6332 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6333 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6334 exported only to the debugger.
6335
6336 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6337 * atimer.h (run_all_atimers): Remove; not exported.
6338
6339 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6340 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6341 was inaccessible from Lisp.
6342 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6343 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6344
6345 alloc.c: Import and export fewer symbols, and remove unused items.
6346 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6347 is defined.
6348 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6349 it's not optimized away by whole-program optimization.
6350 (message_enable_multibyte, free_misc): Remove.
6351 (catchlist, handlerlist, mark_backtrace):
6352 Declare only if BYTE_MARK_STACK.
6353 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6354 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6355 (message_enable_multibyte): Remove decl.
6356 (free_misc, interval_free_list, float_block, float_block_index):
6357 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6358 (cons_free_list, last_marked_index):
6359 Now static.
6360 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6361 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6362 (mark_backtrace): Define only if BYTE_MARK_STACK.
6363 * xdisp.c (message_enable_multibyte): Now static.
6364
6365 Declare Lisp_Object Q* variables to be 'static' if not exported.
6366 This makes it easier for human readers (and static analyzers)
6367 to see whether these variables are used from other modules.
6368 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6369 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6370 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6371 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6372 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6373 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6374 * xmenu.c, xselect.c:
6375 Declare Q* vars static if they are not used in other modules.
6376 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6377 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6378 Remove decls of unexported vars.
6379 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6380
6381 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6382
6383 Make Emacs functions such as Fatom 'static' by default.
6384 This makes it easier for human readers (and static analyzers)
6385 to see whether these functions can be called from other modules.
6386 DEFUN now defines a static function. To make the function external
6387 so that it can be used in other C modules, use the new macro DEFUE.
6388 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6389 (Finit_image_library):
6390 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6391 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6392 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6393 Remove decls, since these functions are now static.
6394 (Funintern, Fget_internal_run_time): New decls, since these functions
6395 were already external.
6396
6397 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6398 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6399 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6400 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6401 * keyboard.c, keymap.c, lread.c:
6402 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6403 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6404 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6405 Mark functions with DEFUE instead of DEFUN,
6406 if they are used in other modules.
6407 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6408 decls for now-static functions.
6409 * buffer.h (Fdelete_overlay): Remove decl.
6410 * callproc.c (Fgetenv_internal): Mark as internal.
6411 * composite.c (Fremove_list_of_text_properties): Remove decl.
6412 (Fcomposition_get_gstring): New forward static decl.
6413 * composite.h (Fcomposite_get_gstring): Remove decl.
6414 * dired.c (Ffile_attributes): New forward static decl.
6415 * doc.c (Fdocumntation_property): New forward static decl.
6416 * eval.c (Ffetch_bytecode): New forward static decl.
6417 (Funintern): Remove extern decl; now in .h file where it belongs.
6418 * fileio.c (Fmake_symbolic_link): New forward static decl.
6419 * image.c (Finit_image_library): New forward static decl.
6420 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6421 * intervals.h (Fprevious_property_change):
6422 (Fremove_list_of_text_properties): Remove decls.
6423 * keyboard.c (Fthis_command_keys): Remove decl.
6424 (Fcommand_execute): New forward static decl.
6425 * keymap.c (Flookup_key): New forward static decl.
6426 (Fcopy_keymap): Now static.
6427 * keymap.h (Flookup_key): Remove decl.
6428 * process.c (Fget_process): New forward static decl.
6429 (Fprocess_datagram_address): Mark as internal.
6430 * syntax.c (Fsyntax_table_p): New forward static decl.
6431 (skip_chars): Remove duplicate decl.
6432 * textprop.c (Fprevious_property_change): New forward static decl.
6433 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6434 Now internal.
6435 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6436 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6437
6438 * editfns.c (Fformat): Remove unreachable code.
6439
6440 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6441
6442 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6443 change. (Bug#8496)
6444
6445 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6446
6447 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6448 when at ZV. (Bug#8487)
6449
6450 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6451
6452 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6453 (Bug#8437)
6454 * keyboard.c (parse_tool_bar_item): Likewise.
6455 * sound.c (sound_cleanup, alsa_close): Likewise.
6456 * termcap.c (tgetent): Likewise.
6457 * xfns.c (x_default_font_parameter): Likewise.
6458 * xsettings.c (read_and_apply_settings): Likewise.
6459
6460 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6461 (overrun_check_free): Protoize.
6462
6463 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6464
6465 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6466 since callers should never pass a negative size.
6467 Change the signature to match that of plain 'read' and 'write'; see
6468 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6469 * lisp.h: Update prototypes of emacs_write and emacs_read.
6470
6471 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6472
6473 * xdisp.c (redisplay_window): Don't try to determine the character
6474 position of the scroll margin if the window start point w->startp
6475 is outside the buffer's accessible region. (Bug#8468)
6476
6477 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6478
6479 Fix write-region and its subroutines for buffers > 2GB.
6480 * fileio.c (a_write, e_write): Modify declaration of arguments and
6481 local variables to support buffers larger than 2GB.
6482 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6483
6484 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6485 argument, local variables, and return value.
6486
6487 * lisp.h: Update prototypes of emacs_write and emacs_read.
6488
6489 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6490
6491 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6492
6493 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6494
6495 Fix more problems found by GCC 4.6.0's static checks.
6496
6497 * xdisp.c (vmessage): Use a better test for character truncation.
6498
6499 * charset.c (load_charset_map): <, not <=, for optimization,
6500 and to avoid potential problems with integer overflow.
6501 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6502 * casetab.c (set_identity, shuffle): Likewise.
6503 * editfns.c (Fformat): Likewise.
6504 * syntax.c (skip_chars): Likewise.
6505
6506 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6507 This also lets GCC 4.6.0 generate slightly better loop code.
6508
6509 * callint.c (Fcall_interactively): <, not <=, for optimization.
6510 (Fcall_interactively): Count the number of arguments produced,
6511 not the number of arguments given. This is simpler and lets GCC
6512 4.6.0 generate slightly better code.
6513
6514 * ftfont.c: Distingish more carefully between FcChar8 and char.
6515 The previous code passed unsigned char * to a functions like
6516 strlen and xstrcasecmp that expect char *, which does not
6517 conform to the C standard.
6518 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6519 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6520 char * when the C standard requires it.
6521
6522 * keyboard.c (read_char): Remove unused var.
6523
6524 * eval.c: Port to Windows vsnprintf (Bug#8435).
6525 Include <limits.h>.
6526 (SIZE_MAX): Define if the headers do not.
6527 (verror): Do not give up if vsnprintf returns a negative count.
6528 Instead, grow the buffer. This ports to Windows vsnprintf, which
6529 does not conform to C99. Problem reported by Eli Zaretskii.
6530 Also, simplify the allocation scheme, by avoiding the need for
6531 calling realloc, and removing the ALLOCATED variable.
6532
6533 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6534
6535 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6536 But keep the doprint source code for now, as we might revamp it
6537 and use it again (Bug#8435).
6538 * lisp.h (doprnt): Remove.
6539 * Makefile.in (base_obj): Remove doprnt.o.
6540 * deps.mk (doprnt.o): Remove.
6541
6542 error: Print 32- and 64-bit integers portably (Bug#8435).
6543 Without this change, on typical 64-bit hosts error ("...%d...", N)
6544 was used to print both 32- and 64-bit integers N, which relied on
6545 undefined behavior.
6546 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6547 New macro.
6548 * lisp.h (error, verror): Mark as printf-like functions.
6549 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6550 Report overflow in size calculations when allocating printf buffer.
6551 Do not truncate output string at its first null byte.
6552 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6553 Truncate the output at a character boundary, since vsnprintf does not
6554 do that.
6555 * charset.c (check_iso_charset_parameter): Convert internal
6556 character to string before calling 'error', since %c now has the
6557 printf meaning.
6558 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6559 overflow when computing char to be passed to 'error'. Do not
6560 pass Lisp_Object to 'error'; pass the integer instead.
6561 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6562 formatted with plain %d.
6563
6564 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6565
6566 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6567
6568 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6569
6570 * xterm.c (x_catch_errors): Remove duplicate declaration.
6571
6572 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6573
6574 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6575
6576 2011-04-10 Jim Meyering <meyering@redhat.com>
6577
6578 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6579 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6580 return ssize_t not "int", and use size_t as the buffer length.
6581 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6582 * gnutls.h: Update declarations.
6583 * process.c (read_process_output): Use ssize_t, to match.
6584 (send_process): Likewise.
6585
6586 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6587
6588 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6589
6590 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6591
6592 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6593 Use unsigned char, to match FcChar8 type definition.
6594
6595 * xterm.c (handle_one_xevent):
6596 * xmenu.c (create_and_show_popup_menu):
6597 * xselect.c (x_decline_selection_request)
6598 (x_reply_selection_request): Avoid type-punned deref of X events.
6599
6600 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6601
6602 Fix some uses of `int' instead of EMACS_INT.
6603 * search.c (string_match_1, fast_string_match)
6604 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6605 (scan_buffer, find_next_newline_no_quit)
6606 (find_before_next_newline, search_command, Freplace_match)
6607 (Fmatch_data): Make some `int' variables be EMACS_INT.
6608
6609 * xdisp.c (display_count_lines): 3rd argument and return value now
6610 EMACS_INT. All callers changed.
6611 (pint2hrstr): Last argument is now EMACS_INT.
6612
6613 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6614 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6615 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6616 (decode_coding_utf_16, decode_coding_emacs_mule)
6617 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6618 (decode_coding_ccl, decode_coding_charset)
6619 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6620 (decode_coding_iso_2022, decode_coding_emacs_mule)
6621 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6622 <char_offset, last_offset>: Declare EMACS_INT.
6623 (encode_coding_utf_8, encode_coding_utf_16)
6624 (encode_coding_emacs_mule, encode_invocation_designation)
6625 (encode_designation_at_bol, encode_coding_iso_2022)
6626 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6627 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6628 Declare EMACS_INT.
6629 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6630 (encode_invocation_designation): Last argument P_NCHARS is now
6631 EMACS_INT.
6632 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6633 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6634
6635 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6636 All users changed.
6637
6638 * ccl.c (Fccl_execute_on_string): Declare some variables
6639 EMACS_INT.
6640
6641 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6642
6643 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6644
6645 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6646
6647 * process.c (Fformat_network_address): Doc fix.
6648
6649 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6650
6651 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6652
6653 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6654
6655 * keyboard.c (read_char): Call Lisp function help-form-show,
6656 instead of using internal_with_output_to_temp_buffer.
6657 (Qhelp_form_show): New var.
6658 (syms_of_keyboard): Use DEFSYM macro.
6659
6660 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6661
6662 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6663
6664 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6665
6666 * process.c (Flist_processes): Remove to Lisp.
6667 (list_processes_1): Delete.
6668
6669 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6670
6671 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6672
6673 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6674
6675 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6676
6677 Fix more problems found by GCC 4.6.0's static checks.
6678
6679 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6680
6681 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6682
6683 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6684
6685 * xdisp.c (vmessage): Mark as a printf-like function.
6686
6687 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6688
6689 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6690
6691 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6692 printf-like functions.
6693 (tiff_load): Add casts to remove these marks before passing them
6694 to system-supplied API.
6695
6696 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6697
6698 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6699 This avoids several warnings with gcc -Wstrict-overflow.
6700 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6701 directly, rather than having caller test rule sign. This avoids
6702 some unnecessary tests.
6703 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6704 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6705 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6706
6707 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6708 (xfont_open): Avoid unnecessary tests.
6709
6710 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6711
6712 * composite.h, composite.c (composition_gstring_put_cache):
6713 Use EMACS_INT, not int, for length.
6714
6715 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6716 breaking out part of COMPOSITION_DECODE_RULE.
6717 (COMPOSITION_DECODE_RULE): Use it.
6718 * composite.c (get_composition_id): Remove unused local vars,
6719 by using the new macro.
6720
6721 * textprop.c (set_text_properties_1): Change while to do-while,
6722 since the condition is always true at first.
6723
6724 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6725 (interval_deletion_adjustment): Return unsigned value.
6726 All uses changed.
6727
6728 * process.c (list_processes_1, create_pty, read_process_output):
6729 (exec_sentinel): Remove vars that were set but not used.
6730 (create_pty): Remove unnecessary "volatile"s.
6731 (Fnetwork_interface_info): Avoid possibility of int overflow.
6732 (read_process_output): Do adaptive read buffering even if carryover.
6733 (read_process_output): Simplify nbytes computation if buffered.
6734
6735 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6736
6737 * syntax.c (scan_words): Remove var that was set but not used.
6738 (update_syntax_table): Use unsigned instead of int.
6739
6740 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6741 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6742 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6743
6744 * print.c (print_error_message): Avoid int overflow.
6745
6746 * font.c (font_list_entities): Redo for clarity,
6747 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6748
6749 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6750 (font_score): Avoid potential overflow in diff calculation.
6751
6752 * fns.c (substring_both): Remove var that is set but not used.
6753 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6754
6755 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6756
6757 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6758 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6759 can always succeed if overflow has undefined behavior.
6760
6761 * search.c (boyer_moore, wordify): Remove vars set but not used.
6762 (wordify): Omit three unnecessary tests.
6763
6764 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6765 All callers changed. This avoids the need for an unused var.
6766
6767 * casefiddle.c (casify_region): Remove var that is set but not used.
6768
6769 * dired.c (file_name_completion): Remove var that is set but not used.
6770
6771 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6772
6773 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6774 (Finsert_file_contents): Remove unnecessary code checking fd.
6775
6776 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6777 Check for integer overflow on size calculations.
6778
6779 * buffer.c (Fprevious_overlay_change): Remove var that is set
6780 but not used.
6781
6782 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6783 Remove vars that are set but not used.
6784 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6785 (timer_check_2): Mark vars as initialized.
6786
6787 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6788
6789 * image.c (lookup_image): Remove var that is set but not used.
6790 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6791
6792 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6793 that are set but not used.
6794
6795 * xfns.c (make_invisible_cursor): Don't return garbage
6796 if XCreateBitmapFromData fails (Bug#8410).
6797
6798 * xselect.c (x_get_local_selection, x_handle_property_notify):
6799 Remove vars that are set but not used.
6800
6801 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6802 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6803
6804 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6805 Remove var that is set but not used.
6806 (scroll_bar_windows_size): Now size_t, not int.
6807 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6808 Check for overflow.
6809
6810 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6811 (map_tty_color) [!defined MSDOS]: Likewise.
6812
6813 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6814
6815 * coding.c: Remove vars that are set but not used.
6816 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6817 All callers changed.
6818 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6819 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6820 (decode_coding_charset): Remove vars that are set but not used.
6821
6822 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6823 that is set but not used.
6824
6825 * print.c (print_object): Remove var that is set but not used.
6826
6827 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6828 The gnulib version avoids calling malloc in the usual case,
6829 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6830 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6831 * filelock.c (current_lock_owner): Likewise.
6832 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6833 * sysdep.c: Include allocator.h, careadlinkat.h.
6834 (emacs_no_realloc_allocator): New static constant.
6835 (emacs_readlink): New function.
6836 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6837 ../lib/careadlinkat.h.
6838
6839 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6840
6841 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6842 first non-nil return value).
6843
6844 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6845
6846 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6847 if not defined (Bug#8403).
6848
6849 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6850
6851 * xdisp.c (display_count_lines): Remove parameter `start',
6852 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6853 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6854 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6855 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6856 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6857 and thereabouts. All callers changed.
6858 (get_per_char_metric): Remove parameter `f', unused since
6859 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6860
6861 2011-04-02 Jim Meyering <meyering@redhat.com>
6862
6863 do not dereference NULL upon failed strdup
6864 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6865 (ns_get_family): Likewise.
6866
6867 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6868
6869 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6870
6871 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6872
6873 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6874 later (Bug#8403).
6875
6876 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6877
6878 Add lexical binding.
6879
6880 * window.c (Ftemp_output_buffer_show): New fun.
6881 (Fsave_window_excursion):
6882 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6883
6884 * lread.c (lisp_file_lexically_bound_p): New function.
6885 (Fload): Bind Qlexical_binding.
6886 (readevalloop): Remove `evalfun' arg.
6887 Bind Qinternal_interpreter_environment.
6888 (Feval_buffer): Bind Qlexical_binding.
6889 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6890 Mark as dynamic.
6891 (syms_of_lread): Declare `lexical-binding'.
6892
6893 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6894
6895 * keyboard.c (eval_dyn): New fun.
6896 (menu_item_eval_property): Use it.
6897
6898 * image.c (parse_image_spec): Use Ffunctionp.
6899
6900 * fns.c (concat, mapcar1): Accept byte-code-functions.
6901
6902 * eval.c (Fsetq): Handle lexical vars.
6903 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6904 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6905 (FletX, Flet): Obey lexical binding.
6906 (Fcommandp): Handle closures.
6907 (Feval): New `lexical' arg.
6908 (eval_sub): New function extracted from Feval. Use it almost
6909 everywhere where Feval was used. Look up vars in lexical env.
6910 Handle closures.
6911 (Ffunctionp): Move from subr.el.
6912 (Ffuncall): Handle closures.
6913 (apply_lambda): Remove `eval_flags'.
6914 (funcall_lambda): Handle closures and new byte-code-functions.
6915 (Fspecial_variable_p): New function.
6916 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6917 but without exporting it to Lisp.
6918
6919 * doc.c (Fdocumentation, store_function_docstring):
6920 * data.c (Finteractive_form): Handle closures.
6921
6922 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6923 interactive spec.
6924
6925 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6926 New byte-codes.
6927 (exec_byte_code): New function extracted from Fbyte_code to handle new
6928 calling convention for byte-code-functions. Add new byte-codes.
6929
6930 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6931
6932 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6933
6934 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6935
6936 * xdisp.c (redisplay_internal): Fix prototype.
6937
6938 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6939
6940 * xdisp.c (SCROLL_LIMIT): New macro.
6941 (try_scrolling): Use it when setting scroll_limit.
6942 Limit scrolling to 100 screen lines.
6943 (redisplay_window): Even when falling back on "recentering",
6944 position point in the window according to scroll-conservatively,
6945 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6946
6947 (try_scrolling): When point is above the window, allow searching
6948 as far as scroll_max, or one screenful, to compute vertical
6949 distance from PT to the scroll margin position. This prevents
6950 try_scrolling from unnecessarily failing when
6951 scroll-conservatively is set to a value slightly larger than the
6952 window height. Clean up the case of PT below the margin at bottom
6953 of window: scroll_max can no longer be INT_MAX. When aggressive
6954 scrolling is in use, don't let point enter the opposite scroll
6955 margin as result of the scroll.
6956 (syms_of_xdisp) <scroll-conservatively>: Document the
6957 threshold of 100 lines for never-recentering scrolling.
6958
6959 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6960
6961 * dispextern.h (move_it_by_lines):
6962 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6963 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6964 (message_log_check_duplicate): Remove parameters `prev_bol' and
6965 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6966 (redisplay_internal): Remove parameter `preserve_echo_area',
6967 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6968
6969 * indent.c (Fvertical_motion):
6970 * window.c (window_scroll_pixel_based, Frecenter):
6971 Don't pass `need_y_p' to `move_it_by_lines'.
6972
6973 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6974
6975 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6976 steal a few bits to be more compact.
6977 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6978 Remove unneeded casts.
6979
6980 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6981
6982 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6983
6984 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6985 binding" message (bug#7967).
6986
6987 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6988
6989 Fix more problems found by GCC 4.6.0's static checks.
6990
6991 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6992 Remove unused local var.
6993
6994 * editfns.c (Fmessage_box): Remove unused local var.
6995
6996 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6997 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6998 Omit unused local vars.
6999 * window.c (shrink_windows): Omit unused local var.
7000 * menu.c (digest_single_submenu): Omit unused local var.
7001 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7002 Omit unused local var.
7003
7004 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7005 Don't assume string length fits in int.
7006 (keyremap_step, read_key_sequence): Use size_t for sizes.
7007 (read_key_sequence): Don't check last_real_key_start redundantly.
7008
7009 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7010 instead of alloca (Bug#8344).
7011
7012 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7013 (Fbacktrace_frame): Don't assume nframes fits in int.
7014
7015 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7016
7017 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7018 concerns.
7019
7020 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7021
7022 * cm.c (calccost): Turn while-do into do-while, for clarity.
7023
7024 * keyboard.c (syms_of_keyboard): Use the same style as later
7025 in this function when indexing through an array. This also
7026 works around GCC bug 48267.
7027
7028 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7029
7030 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7031
7032 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7033 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7034
7035 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7036 This avoids undefined behavior on integer overflow, and is a bit
7037 more convenient anyway since it is compared to a size_t variable.
7038
7039 Variadic C functions now count arguments with size_t, not int.
7040 This avoids an unnecessary limitation on 64-bit machines, which
7041 caused (substring ...) to crash on large vectors (Bug#8344).
7042 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7043 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7044 All variadic functions and their callers changed accordingly.
7045 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7046 * data.c (arith_driver, float_arith_driver): Likewise.
7047 * editfns.c (general_insert_function): Likewise.
7048 * eval.c (struct backtrace.nargs, interactive_p)
7049 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7050 (funcall_lambda, mark_backtrace): Likewise.
7051 * fns.c (concat): Likewise.
7052 * frame.c (x_set_frame_parameters): Likewise.
7053 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7054 0 if not found, not -1. All callers changed.
7055
7056 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7057 (stack_copy_size): Now size_t, not int.
7058 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7059
7060 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7061
7062 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7063 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7064 All callers changed.
7065
7066 * lisp.h (multibyte_char_to_unibyte):
7067 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7068 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7069 * character.h (CHAR_TO_BYTE8):
7070 * cmds.c (internal_self_insert):
7071 * editfns.c (general_insert_function):
7072 * keymap.c (push_key_description):
7073 * search.c (Freplace_match):
7074 * xdisp.c (message_dolog, set_message_1): All callers changed.
7075
7076 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7077
7078 * keyboard.c (safe_run_hook_funcall): New function.
7079 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7080 don't set the hook to nil, but remove the offending function instead.
7081 (Qcommand_hook_internal): Remove, unused.
7082 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7083 Vcommand_hook_internal.
7084
7085 * eval.c (enum run_hooks_condition): Remove.
7086 (funcall_nil, funcall_not): New functions.
7087 (run_hook_with_args): Call each function through a `funcall' argument.
7088 Remove `cond' argument, now redundant.
7089 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7090 (Frun_hook_with_args_until_failure): Adjust accordingly.
7091 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7092
7093 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7094
7095 * dispextern.h (string_buffer_position): Remove declaration.
7096
7097 * print.c (strout): Remove parameter `multibyte', unused since
7098 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7099
7100 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7101 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7102 All callers changed.
7103
7104 * w32.c (_wsa_errlist): Use braces for struct initializers.
7105
7106 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7107 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7108 All callers changed.
7109 (string_buffer_position): Likewise. Also, make static (it's never
7110 used outside xdisp.c).
7111 (cursor_row_p): Remove parameter `w', unused since
7112 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7113 (decode_mode_spec): Remove parameter `precision', introduced during
7114 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7115 All callers changed.
7116
7117 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7118
7119 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7120
7121 2011-03-27 Anders Lindgren <andlind@gmail.com>
7122
7123 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7124 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7125 (ns_update_auto_hide_menu_bar): New functions.
7126 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7127 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7128 ns_constrain_all_frames.
7129 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7130 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7131
7132 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7133
7134 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7135
7136 2011-03-27 Glenn Morris <rgm@gnu.org>
7137
7138 * syssignal.h: Replace RETSIGTYPE with void.
7139 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7140 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7141 Replace SIGTYPE with void everywhere.
7142 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7143 * s/template.h (SIGTYPE): Remove commented out definition.
7144
7145 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7146
7147 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7148 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7149
7150 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7151
7152 * w32.c (read_unc_volume): Use parameter `henum', instead of
7153 global variable `wget_enum_handle'.
7154
7155 * keymap.c (describe_vector): Remove parameters `indices' and
7156 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7157 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7158
7159 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7160
7161 * keyboard.c (timer_check): Remove parameter `do_it_now',
7162 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7163 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7164 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7165
7166 * keyboard.c (read_char):
7167 * w32menu.c (w32_menu_display_help):
7168 * xmenu.c (show_help_event, menu_help_callback):
7169 Adjust calls to `show_help_echo'.
7170
7171 * gtkutil.c (xg_maybe_add_timer):
7172 * keyboard.c (readable_events):
7173 * process.c (wait_reading_process_output):
7174 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7175
7176 * insdel.c (adjust_markers_gap_motion):
7177 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7178 (gap_left, gap_right): Don't call it.
7179
7180 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7181
7182 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7183 incurred during fontification.
7184
7185 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7186
7187 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7188 (DEFVAR_PER_BUFFER): Don't pass it.
7189
7190 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7191 (scrolling_window): Don't pass it.
7192
7193 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7194
7195 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7196
7197 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7198 and `suffix'.
7199 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7200 of variables specific to SELinux and computation of `encoded_absname'.
7201
7202 * image.c (XPutPixel): Remove unused variable `height'.
7203
7204 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7205
7206 * unexw32.c (get_section_info): Remove unused variable `section'.
7207
7208 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7209 (system_process_attributes): Remove unused variable `sess'.
7210 (sys_read): Remove unused variable `err'.
7211
7212 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7213 (w32_wnd_proc): Remove unused variable `isdead'.
7214 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7215 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7216 (x_create_tip_frame): Remove unused variable `tem'.
7217
7218 * w32inevt.c (w32_console_read_socket):
7219 Remove unused variable `no_events'.
7220
7221 * w32term.c (x_draw_composite_glyph_string_foreground):
7222 Remove unused variable `width'.
7223
7224 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7225
7226 * w32term.c (x_set_glyph_string_clipping):
7227 Don't pass uninitialized region to CombineRgn.
7228
7229 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7230
7231 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7232 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7233 (Fx_close_connection): Remove unused variable `i'.
7234
7235 * w32font.c (w32font_draw): Return number of glyphs.
7236 (w32font_open_internal): Remove unused variable `i'.
7237 (w32font_driver): Add missing initializer.
7238
7239 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7240 (fill_in_menu): Remove unused variable `items_added'.
7241
7242 * w32term.c (last_mouse_press_frame): Remove static global variable.
7243 (w32_clip_to_row): Remove unused variable `f'.
7244 (x_delete_terminal): Remove unused variable `i'.
7245
7246 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7247 (NOTHING): Remove unused static global variable.
7248 (uniscribe_check_otf): Remove unused variable `table'.
7249 (uniscribe_font_driver): Add missing initializers.
7250
7251 2011-03-23 Julien Danjou <julien@danjou.info>
7252
7253 * term.c (Fsuspend_tty, Fresume_tty):
7254 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7255 * window.c (temp_output_buffer_show):
7256 * insdel.c (signal_before_change):
7257 * frame.c (Fhandle_switch_frame):
7258 * fileio.c (Fdo_auto_save):
7259 * emacs.c (Fkill_emacs):
7260 * editfns.c (save_excursion_restore):
7261 * cmds.c (internal_self_insert):
7262 * callint.c (Fcall_interactively):
7263 * buffer.c (Fkill_all_local_variables):
7264 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7265 Use Frun_hooks.
7266 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7267 unconditionnaly since it does the check itself.
7268
7269 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7270
7271 Fix more problems found by GCC 4.5.2's static checks.
7272
7273 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7274 the first time through the loop, since we know p0 < p1 then.
7275 This also avoids a gcc -Wstrict-overflow warning.
7276
7277 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7278 leading to a memory leak, possible in functions like
7279 load_charset_map_from_file that can allocate an unbounded number
7280 of objects (Bug#8318).
7281
7282 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7283 that could (at least in theory) be that large.
7284
7285 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7286 This is less likely to overflow, and avoids undefined behavior if
7287 overflow does occur. All callers changed. Use strtoul to scan
7288 for the unsigned long integer.
7289 (pint2hrstr): Simplify and tune code slightly.
7290 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7291
7292 * scroll.c (do_scrolling): Work around GCC bug 48228.
7293 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7294
7295 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7296 This also avoids a warning with gcc -Wstrict-overflow.
7297 (validate_x_resource_name): Simplify count usage.
7298 This also avoids a warning with gcc -Wstrict-overflow.
7299
7300 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7301 fail (Bug#8306).
7302
7303 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7304
7305 * process.c (Fmake_network_process): Use socklen_t, not int,
7306 where POSIX says socklen_t is required in portable programs.
7307 This fixes a porting bug on hosts like 64-bit HP-UX, where
7308 socklen_t is wider than int (Bug#8277).
7309 (Fmake_network_process, server_accept_connection):
7310 (wait_reading_process_output, read_process_output):
7311 Likewise.
7312
7313 * process.c: Rename or move locals to avoid shadowing.
7314 (list_processes_1, Fmake_network_process):
7315 (read_process_output_error_handler, exec_sentinel_error_handler):
7316 Rename or move locals.
7317 (Fmake_network_process): Define label "retry_connect" only if needed.
7318 (Fnetwork_interface_info): Fix pointer signedness.
7319 (process_send_signal): Add cast to avoid pointer signedness problem.
7320 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7321 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7322
7323 Make tparam.h and terminfo.c consistent.
7324 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7325 Include tparam.h instead, since it declares them.
7326 * cm.h (PC): Remove extern decl; tparam.h now does this.
7327 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7328 * terminfo.c: Include tparam.h, to check interfaces.
7329 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7330 (tparam): Adjust signature to match interface in tparam.h;
7331 this removes some undefined behavior. Check that outstring and len
7332 are zero, which they always are with Emacs.
7333 * tparam.h (PC, BC, UP): New extern decls.
7334
7335 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7336 (xftfont_open): Rename locals to avoid shadowing.
7337
7338 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7339 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7340 (OTF_TAG_SYM): Omit macro if not needed.
7341 (ftfont_list): Remove unused local.
7342 (get_adstyle_property, ftfont_pattern_entity):
7343 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7344 Rename locals to avoid shadowing.
7345
7346 * xfont.c (xfont_list_family): Mark var as initialized.
7347
7348 * xml.c (make_dom): Now static.
7349
7350 * composite.c (composition_compute_stop_pos): Rename local to
7351 avoid shadowing.
7352 (composition_reseat_it): Remove unused locals.
7353 (find_automatic_composition, composition_adjust_point): Likewise.
7354 (composition_update_it): Mark var as initialized.
7355 (find_automatic_composition): Mark vars as initialized,
7356 with a FIXME (Bug#8290).
7357
7358 character.h: Rename locals to avoid shadowing.
7359 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7360 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7361 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7362 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7363 to avoid shadowing.
7364
7365 * textprop.c (property_change_between_p): Remove; unused.
7366
7367 * intervals.c (interval_start_pos): Now static.
7368
7369 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7370
7371 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7372 Rename locals to avoid shadowing.
7373
7374 * sound.c (wav_play, au_play, Fplay_sound_internal):
7375 Fix pointer signedness.
7376 (alsa_choose_format): Remove unused local var.
7377 (wav_play): Initialize a variable to 0, to prevent undefined
7378 behavior (Bug#8278).
7379
7380 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7381
7382 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7383
7384 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7385 clobbering (Bug#8298).
7386 * sysdep.c (sys_subshell): Likewise.
7387 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7388
7389 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7390 This should get cleaned up, so that child_setup has the
7391 same signature on all platforms.
7392
7393 * callproc.c (call_process_cleanup): Now static.
7394 (relocate_fd): Rename locals to avoid shadowing.
7395
7396 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7397
7398 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7399 not to be necessary, and produces flickering.
7400
7401 2011-03-20 Glenn Morris <rgm@gnu.org>
7402
7403 * config.in: Remove file.
7404
7405 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7406
7407 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7408 are now in src/globals.h.
7409 (syms_of_minibuf): Remove spurious & from previous change.
7410
7411 2011-03-20 Leo <sdl.web@gmail.com>
7412
7413 * minibuf.c (completing-read-function): New variable.
7414 (completing-read-default): Rename from completing-read.
7415 (completing-read): Call completing-read-function.
7416
7417 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7418
7419 * xfaces.c (Fx_load_color_file):
7420 Read color file from absolute filename (bug#8250).
7421
7422 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7423
7424 * makefile.w32-in: Update dependencies.
7425
7426 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7427
7428 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7429
7430 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7431
7432 Fix more problems found by GCC 4.5.2's static checks.
7433
7434 * process.c (make_serial_process_unwind, send_process_trap):
7435 (sigchld_handler): Now static.
7436
7437 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7438 That way, the code declares only the vars that it needs.
7439 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7440 * s/cygwin.h (PTY_ITERATION): Likewise.
7441 * s/darwin.h (PTY_ITERATION): Likewise.
7442 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7443
7444 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7445 * process.c (allocate_pty): Don't declare stb unless it's needed.
7446
7447 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7448 (CONSTANTLIM): Remove; unused.
7449 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7450 Define only if needed.
7451
7452 * unexelf.c (unexec): Name an expression,
7453 to avoid gcc -Wbad-function-cast warning.
7454 Use a different way to cause a compilation error if anyone uses
7455 n rather than nn, a way that does not involve shadowing.
7456 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7457
7458 * deps.mk (unexalpha.o): Remove; unused.
7459
7460 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7461 * unexec.h: New file.
7462 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7463 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7464 Depend on unexec.h.
7465 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7466 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7467 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7468 Change as necessary to match prototype in unexec.h.
7469
7470 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7471 shadowing.
7472 (back_comment, skip_chars): Mark vars as initialized.
7473
7474 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7475 Rename locals to avoid shadowing.
7476
7477 * lread.c (read1): Rewrite so as not to use empty "else".
7478 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7479
7480 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7481
7482 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7483 warning when compiling print.c.
7484
7485 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7486 instead of using an uninitialized var.
7487 (font_sort_entities): Mark var as initialized.
7488
7489 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7490
7491 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7492 pointers to constants.
7493 (font_parse_fcname): Remove unused vars.
7494 (font_delete_unmatched): Now static.
7495 (font_get_spec): Remove; unused.
7496 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7497 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7498 Rename or move locals to avoid shadowing.
7499
7500 * fns.c (require_nesting_list, require_unwind): Now static.
7501 (Ffillarray): Rename locals to avoid shadowing.
7502
7503 * floatfns.c (domain_error2): Define only if needed.
7504 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7505
7506 * alloc.c (mark_backtrace): Move decl from here ...
7507 * lisp.h: ... to here, so that it can be checked.
7508
7509 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7510 (Fdefvar): Rewrite so as not to use empty "else".
7511 (lisp_indirect_variable): Name an expression,
7512 to avoid gcc -Wbad-function-cast warning.
7513 (Fdefvar): Rename locals to avoid shadowing.
7514
7515 * callint.c (quotify_arg, quotify_args): Now static.
7516 (Fcall_interactively): Rename locals to avoid shadowing.
7517 Use const pointer when appropriate.
7518
7519 * lisp.h (get_system_name, get_operating_system_release):
7520 Move decls here, to check interfaces.
7521 * process.c (get_operating_system_release): Move decl to lisp.h.
7522 * xrdb.c (get_system_name): Likewise.
7523 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7524 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7525 some of which prompt warnings from gcc -Wbad-function-cast.
7526 (Fformat_time_string, Fencode_time, Finsert_char):
7527 (Ftranslate_region_internal, Fformat):
7528 Rename or remove local vars to avoid shadowing.
7529 (Ftranslate_region_internal): Mark var as initialized.
7530
7531 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7532 avoid shadowing.
7533
7534 * lisp.h (eassert): Check that the argument compiles, even if
7535 ENABLE_CHECKING is not defined.
7536
7537 * data.c (Findirect_variable): Name an expression, to avoid
7538 gcc -Wbad-function-cast warning.
7539 (default_value, arithcompare, arith_driver, arith_error): Now static.
7540 (store_symval_forwarding): Rename local to avoid shadowing.
7541 (Fmake_variable_buffer_local, Fmake_local_variable):
7542 Mark variables as initialized.
7543 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7544
7545 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7546 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7547 Rename locals to avoid shadowing.
7548 (mark_stack): Move local variables into the #ifdef region where
7549 they're used.
7550 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7551 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7552 needed otherwise.
7553 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7554 (GC_STRING_CHARS): Remove; not used.
7555 (Fmemory_limit): Cast sbrk's returned value to char *.
7556
7557 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7558 avoids undefined behavior in theory.
7559
7560 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7561
7562 Use functions, not macros, for up- and down-casing (Bug#8254).
7563 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7564 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7565 to use the following functions instead of these macros.
7566 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7567 EMACS_INT, since callers assume the returned value fits in int.
7568 (upcase1): Likewise, for UPCASE_TABLE.
7569 (uppercasep, lowercasep, upcase): New static inline functions.
7570 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7571 the race-condition problem in the old DOWNCASE.
7572
7573 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7574 Rename locals to avoid shadowing.
7575 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7576 (regex_compile, re_search_2, re_match_2_internal):
7577 Remove unused local vars.
7578 (FREE_VAR): Rewrite so as not to use empty "else",
7579 which gcc can warn about.
7580 (regex_compile, re_match_2_internal): Mark locals as initialized.
7581 (RETALLOC_IF): Define only if needed.
7582 (WORDCHAR_P): Likewise. This one is never needed, but is used
7583 only in a comment talking about a compiler bug, so put inside
7584 the #if 0 of that comment.
7585 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7586 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7587 Remove; unused.
7588
7589 * search.c (boyer_moore): Rename locals to avoid shadowing.
7590 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7591 (PREV_CHAR_BOUNDARY): Likewise.
7592
7593 * search.c (simple_search): Remove unused var.
7594
7595 * dired.c (compile_pattern): Move decl from here ...
7596 * lisp.h: ... to here, so that it can be checked.
7597 (struct re_registers): New forward decl.
7598
7599 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7600
7601 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7602 All uses changed.
7603 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7604 Rename locals to avoid shadowing.
7605 (Fvertical_motion): Mark locals as initialized.
7606
7607 * casefiddle.c (casify_object, casify_region): Now static.
7608 (casify_region): Mark local as initialized.
7609
7610 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7611
7612 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7613 New macros, so that the caller can use some names other than
7614 gcpro1, gcpro2, etc.
7615 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7616 of the new macros.
7617 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7618 argument, for consistency with GCPRO2_VAR, etc: it is now the
7619 prefix of the variable, not the variable itself. All uses
7620 changed.
7621 * dired.c (directory_files_internal, file_name_completion):
7622 Rename locals to avoid shadowing.
7623
7624 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7625 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7626 dired.c's scmp function, had undefined behavior.
7627 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7628 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7629 * buffer.h: ... to here, because these macros use current_buffer,
7630 and the new implementation with inline functions needs to have
7631 current_buffer in scope now, rather than later when the macros
7632 are used.
7633 (downcase, upcase1): New static inline functions.
7634 (DOWNCASE, UPCASE1): Reimplement using these functions.
7635 This avoids undefined behavior in expressions like
7636 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7637 from race conditions in accessing the global variables
7638 case_temp1 and case_temp2.
7639 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7640 * lisp.h (case_temp1, case_temp2): Remove their decls.
7641 * character.h (ASCII_CHAR_P): Move from here ...
7642 * lisp.h: ... to here, so that the inline functions mentioned
7643 above can use them.
7644
7645 * dired.c (directory_files_internal_unwind): Now static.
7646
7647 * fileio.c (file_name_as_directory, directory_file_name):
7648 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7649 Now static.
7650 (file_name_as_directory): Use const pointers when appropriate.
7651 (Fexpand_file_name): Likewise. In particular, newdir might
7652 point at constant storage, so make it a const pointer.
7653 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7654 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7655 signedness issues.
7656 (Fset_file_times, Finsert_file_contents, auto_save_error):
7657 Rename locals to avoid shadowing.
7658
7659 * minibuf.c (choose_minibuf_frame_1): Now static.
7660 (Ftry_completion, Fall_completions): Rename or remove locals
7661 to avoid shadowing.
7662
7663 * marker.c (bytepos_to_charpos): Remove; unused.
7664
7665 * lisp.h (verify_bytepos, count_markers): New decls,
7666 so that gcc does not warn that these functions aren't declared.
7667
7668 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7669 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7670 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7671 (copy_text): Remove unused local var.
7672
7673 * filelock.c (within_one_second): Now static.
7674 (lock_file_1): Rename local to avoid shadowing.
7675
7676 * buffer.c (fix_overlays_before): Mark locals as initialized.
7677 (fix_start_end_in_overlays): Likewise. This function should be
7678 simplified by using pointers-to-pointers, but that's a different
7679 matter.
7680 (switch_to_buffer_1): Now static.
7681 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7682 (report_overlay_modification): Rename locals to avoid shadowing.
7683
7684 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7685 Fix pointer signedness issue.
7686 (sys_subshell): Mark local as volatile if checking for lint,
7687 to suppress a gcc -Wclobbered warning that does not seem to be right.
7688 (MAXPATHLEN): Define only if needed.
7689
7690 * process.c (serial_open, serial_configure): Move decls from here ...
7691 * systty.h: ... to here, so that they can be checked.
7692
7693 * fns.c (get_random, seed_random): Move extern decls from here ...
7694 * lisp.h: ... to here, so that they can be checked.
7695
7696 * sysdep.c (reset_io): Now static.
7697 (wait_for_termination_signal): Remove; unused.
7698
7699 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7700 (copy_keymap_item, append_key, push_text_char_description):
7701 Now static.
7702 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7703 (DENSE_TABLE_SIZE): Remove; unused.
7704 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7705 (describe_map_tree):
7706 Rename locals to avoid shadowing.
7707
7708 * keyboard.c: Declare functions static if they are not used elsewhere.
7709 (echo_char, echo_dash, cmd_error, top_level_2):
7710 (poll_for_input, handle_async_input): Now static.
7711 (read_char, kbd_buffer_get_event, make_lispy_position):
7712 (make_lispy_event, make_lispy_movement, apply_modifiers):
7713 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7714 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7715 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7716 (read_key_sequence, read_char): Mark locals as initialized.
7717 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7718
7719 * keyboard.h (make_ctrl_char): New decl.
7720 (mark_kboards): Move decl here ...
7721 * alloc.c (mark_kboards): ... from here.
7722
7723 * lisp.h (force_auto_save_soon): New decl.
7724
7725 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7726 (DEFINE_DUMMY_FUNCTION): New macro.
7727 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7728 Use it.
7729 (main): Add casts to avoid warnings
7730 if GCC considers string literals to be constants.
7731
7732 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7733
7734 * dbusbind.c: Pointer signedness fixes.
7735 (xd_signature, xd_append_arg, xd_initialize):
7736 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7737 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7738 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7739 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7740
7741 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7742 if GCC considers string literals to be constants.
7743 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7744
7745 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7746
7747 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7748 (print_preprocess, print_object): New macro to fix last change.
7749
7750 * print.c (print_preprocess): Don't forget font objects.
7751
7752 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7753
7754 * emacs.c (USAGE3): Doc fixes.
7755
7756 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7757
7758 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7759 structure.
7760
7761 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7762
7763 * lisp.h (VWindow_system, Qfile_name_history):
7764 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7765 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7766 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7767
7768 * w32select.c: Don't #include "keyboard.h".
7769 (run_protected): Add extern declaration for waiting_for_input.
7770
7771 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7772 * w32console.c (detect_input_pending, read_input_pending)
7773 (encode_terminal_code):
7774 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7775 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7776 (w32_system_caret_y, Qfile_name_history):
7777 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7778 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7779 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7780 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7781 * w32proc.c (Qlocal, report_file_error):
7782 * w32term.c (Vwindow_system, updating_frame):
7783 * w32uniscribe.c (initialized, uniscribe_font_driver):
7784 Remove unneeded extern declarations.
7785
7786 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7787
7788 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7789
7790 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7791
7792 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7793 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7794 These macros can no longer be used for assignment.
7795
7796 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7797 Assign struct members directly, instead of using BUF_BEGV etc.
7798 (record_buffer_markers, fetch_buffer_markers): New functions for
7799 recording and fetching special buffer markers.
7800 (set_buffer_internal_1, set_buffer_temp): Use them.
7801
7802 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7803
7804 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7805
7806 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7807 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7808
7809 * xdisp.c (hscroll_window_tree):
7810 (reconsider_clip_changes): Use PT instead of BUF_PT.
7811
7812 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7813
7814 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7815 $(EMACS_ROOT)/lib/intprops.h.
7816
7817 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7818
7819 Fix more problems found by GCC 4.5.2's static checks.
7820
7821 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7822 to unsigned char * to avoid compiler diagnostic.
7823 (xg_free_frame_widgets): Make it clear that a local variable is
7824 needed only if USE_GTK_TOOLTIP.
7825 (gdk_window_get_screen): Make it clear that this macro is needed
7826 only if USE_GTK_TOOLTIP.
7827 (int_gtk_range_get_value): New function, which avoids a diagnostic
7828 from gcc -Wbad-function-cast.
7829 (xg_set_toolkit_scroll_bar_thumb): Use it.
7830 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7831 diagnostic from gcc -Wbad-function-cast.
7832 (get_utf8_string, xg_get_file_with_chooser):
7833 Rename locals to avoid shadowing.
7834 (create_dialog): Move locals to avoid shadowing.
7835
7836 * xgselect.c (xg_select): Remove unused var.
7837
7838 * image.c (four_corners_best): Mark locals as initialized.
7839 (gif_load): Initialize transparent_p to zero (Bug#8238).
7840 Mark another local as initialized.
7841 (my_png_error, my_error_exit): Mark with NO_RETURN.
7842
7843 * image.c (clear_image_cache): Now static.
7844 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7845 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7846 (x_edge_detection): Remove unnecessary cast that
7847 gcc -Wbad-function-cast diagnoses.
7848 (gif_load): Fix pointer signedness.
7849 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7850 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7851
7852 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7853
7854 Improve quality of tests for time stamp overflow.
7855 For example, without this patch (encode-time 0 0 0 1 1
7856 1152921504606846976) returns the obviously-bogus value (-948597
7857 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7858 reports time overflow. See
7859 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7860 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7861 * editfns.c: Include limits.h and intprops.h.
7862 (TIME_T_MIN, TIME_T_MAX): New macros.
7863 (time_overflow): Move earlier, to before first use.
7864 (hi_time, lo_time): New functions, for an accurate test for
7865 out-of-range times.
7866 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7867 (Fget_internal_run_time): Don't assume time_t fits in int.
7868 (make_time): Use list2 instead of Fcons twice.
7869 (Fdecode_time): More accurate test for out-of-range times.
7870 (check_tm_member): New function.
7871 (Fencode_time): Use it, to test for out-of-range times.
7872 (lisp_time_argument): Don't rely on undefined left-shift and
7873 right-shift behavior when checking for time stamp overflow.
7874
7875 * editfns.c (time_overflow): New function, refactoring common code.
7876 (Fformat_time_string, Fdecode_time, Fencode_time):
7877 (Fcurrent_time_string): Use it.
7878
7879 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7880 * dired.c (make_time): Move to ...
7881 * editfns.c (make_time): ... here.
7882 * systime.h: Note the move.
7883
7884 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7885
7886 * fringe.c (update_window_fringes): Remove unused variables.
7887
7888 * unexmacosx.c (copy_data_segment): Also copy __got section.
7889 (Bug#8223)
7890
7891 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7892
7893 * termcap.c [MSDOS]: Include "msdos.h".
7894 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7895 Constify `char *' arguments and their references according to
7896 prototypes in tparam.h.
7897
7898 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7899
7900 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7901 Adapt all references accordingly.
7902
7903 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7904
7905 2011-03-11 Tom Tromey <tromey@redhat.com>
7906
7907 * buffer.c (syms_of_buffer): Remove obsolete comment.
7908
7909 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7910
7911 * termhooks.h (encode_terminal_code): Declare prototype.
7912
7913 * msdos.c (encode_terminal_code): Don't declare prototype.
7914
7915 * term.c (encode_terminal_code): Now external again, used by
7916 w32console.c and msdos.c.
7917
7918 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7919 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7920
7921 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7922
7923 Fix some minor problems found by GCC 4.5.2's static checks.
7924
7925 * fringe.c (update_window_fringes): Mark locals as initialized
7926 (Bug#8227).
7927 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7928
7929 * alloc.c (mark_fringe_data): Move decl from here ...
7930 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7931 to check its interface.
7932 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7933
7934 * fontset.c (free_realized_fontset): Now static.
7935 (Fset_fontset_font): Rename local to avoid shadowing.
7936 (fontset_font): Mark local as initialized.
7937 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7938
7939 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7940
7941 * xselect.c (x_disown_buffer_selections): Remove; not used.
7942 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7943 (x_own_selection, Fx_disown_selection_internal): Rename locals
7944 to avoid shadowing.
7945 (x_handle_dnd_message): Remove local to avoid shadowing.
7946
7947 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7948 so that the caller can use some name other than gcpro1.
7949 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7950 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7951 (Fx_backspace_delete_keys_p):
7952 Use them to avoid shadowing, and rename vars to avoid shadowing.
7953 (x_decode_color, x_set_name, x_window): Now static.
7954 (Fx_create_frame): Add braces to silence GCC warning.
7955 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7956 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7957 Remove unused locals.
7958 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7959 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7960 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7961 macros.
7962
7963 * xterm.h (x_mouse_leave): New decl.
7964
7965 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7966 Remove unused functions.
7967 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7968 (x_calc_absolute_position): Now static.
7969 (XTread_socket): Don't define label "out" unless it's used.
7970 Don't declare local "event" unless it's used.
7971 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7972 unless they are used.
7973 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7974 (x_fatal_error_signal): Remove; not used.
7975 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7976 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7977 (x_error_catcher, x_connection_closed, x_error_handler):
7978 (x_error_quitter, xembed_send_message, x_iconify_frame):
7979 (my_log_handler): Rename locals to avoid shadowing.
7980 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7981 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7982
7983 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7984 Rename or move locals to avoid shadowing.
7985 (tty_defined_color, merge_face_heights): Now static.
7986 (free_realized_faces_for_fontset): Remove; not used.
7987 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7988 does not deduce is never used uninitialized.
7989 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7990 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7991
7992 * terminal.c (store_terminal_param): Now static.
7993
7994 * xmenu.c (menu_highlight_callback): Now static.
7995 (set_frame_menubar): Remove unused local.
7996 (xmenu_show): Rename parameter to avoid shadowing.
7997 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7998 since they might point to immutable storage.
7999 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8000 since it's unused otherwise.
8001
8002 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8003 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8004 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8005 avoids a gcc -Wuninitialized diagnostic.
8006 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8007 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8008 does not deduce are never used uninitialized.
8009
8010 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8011
8012 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8013 * window.c (window_loop, size_window):
8014 (run_window_configuration_change_hook, enlarge_window): Likewise.
8015
8016 * window.c (display_buffer): Now static.
8017 (size_window): Mark variables that gcc -Wuninitialized
8018 does not deduce are never used uninitialized.
8019 * window.h (check_all_windows): New decl, to forestall
8020 gcc -Wmissing-prototypes diagnostic.
8021 * dispextern.h (bidi_dump_cached_states): Likewise.
8022
8023 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8024 shadowing.
8025 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8026 Include <limits.h>.
8027 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8028 and to avoid gcc -Wuninitialized warning.
8029 (load_charset_map): Mark variables that gcc -Wuninitialized
8030 does not deduce are never used uninitialized.
8031 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8032
8033 * coding.c (coding_set_source, coding_set_destination):
8034 Use "else { /* comment */ }" rather than "else /* comment */;"
8035 for clarity, and to avoid gcc -Wempty-body warning.
8036 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8037 a block, when the outer 'i' will do.
8038 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8039 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8040 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8041 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8042 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8043 Rename locals to avoid shadowing.
8044 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8045 * coding.c (emacs_mule_char, encode_invocation_designation):
8046 Now static, since they're not used elsewhere.
8047 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8048 (decode_coding_object, encode_coding_object, detect_coding_system):
8049 (decode_coding_emacs_mule): Mark variables that gcc
8050 -Wuninitialized does not deduce are never used uninitialized.
8051 (detect_coding_iso_2022): Initialize a local variable that might
8052 be used uninitialized. Leave a FIXME because it's not clear that
8053 this initialization is needed. (Bug#8211)
8054 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8055 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8056 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8057 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8058 Remove unused macros.
8059
8060 * category.c (hash_get_category_set): Remove unused local var.
8061 (copy_category_table): Now static, since it's not used elsewhere.
8062 * character.c (string_count_byte8): Likewise.
8063
8064 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8065 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8066
8067 * chartab.c (copy_sub_char_table): Now static, since it's not used
8068 elsewhere.
8069 (sub_char_table_ref_and_range, char_table_ref_and_range):
8070 Rename locals to avoid shadowing.
8071 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8072
8073 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8074 (BIDI_BOB): Remove unused macro.
8075
8076 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8077 deduce are never used uninitialized.
8078 * term.c (encode_terminal_code): Likewise.
8079
8080 * term.c (encode_terminal_code): Now static. Remove unused local.
8081
8082 * tparam.h: New file.
8083 * term.c, tparam.h: Include it.
8084 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8085 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8086 Move these decls to tparam.h, and make them agree with what
8087 is actually in tparam.c. The previous trick of using incompatible
8088 decls in different modules does not conform to the C standard.
8089 All callers of tparam changed to use tparam's actual API.
8090 * tparam.c (tparam1, tparam, tgoto):
8091 Use const pointers where appropriate.
8092
8093 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8094 * cm.h (struct cm): Likewise.
8095 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8096 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8097 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8098 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8099 (turn_on_face, init_tty): Likewise.
8100 * termchar.h (struct tty_display_info): Likewise.
8101
8102 * term.c (term_mouse_position): Rename local to avoid shadowing.
8103
8104 * alloc.c (mark_ttys): Move decl from here ...
8105 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8106
8107 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8108
8109 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8110
8111 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8112
8113 * search.c (compile_pattern_1): Remove argument regp, unused since
8114 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8115 (compile_pattern): Don't pass it.
8116
8117 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8118
8119 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8120 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8121 for ! HAVE_GTK3.
8122 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8123
8124 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8125
8126 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8127 gdk_window_get_screen, gdk_window_get_geometry,
8128 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8129 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8130 (xg_get_pixbuf_from_pixmap): New function.
8131 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8132 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8133 Call xg_get_pixbuf_from_pixmap instead of
8134 gdk_pixbuf_get_from_drawable.
8135 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8136 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8137 (xg_check_special_colors): Use GtkStyleContext and its functions
8138 for HAVE_GTK3.
8139 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8140 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8141 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8142 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8143 Call gtk_widget_get_preferred_size.
8144 (xg_frame_resized): gdk_window_get_geometry only takes 5
8145 parameters.
8146 (xg_win_to_widget, xg_event_is_for_menubar):
8147 Call gdk_x11_window_lookup_for_display.
8148 (xg_set_widget_bg): New function.
8149 (delete_cb): New function.
8150 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8151 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8152 (xg_set_background_color): Call xg_set_widget_bg.
8153 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8154 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8155 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8156 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8157 if ! HAVE_GTK3.
8158 (update_frame_tool_bar): Call gtk_widget_hide.
8159 (xg_initialize): Use GDK_KEY_g.
8160
8161 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8162 if ! HAVE_GTK3
8163 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8164
8165 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8166 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8167 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8168
8169 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8170
8171 * w32xfns.c (select_palette): Check success of RealizePalette against
8172 GDI_ERROR, not zero.
8173
8174 See ChangeLog.11 for earlier changes.
8175
8176 ;; Local Variables:
8177 ;; coding: utf-8
8178 ;; End:
8179
8180 Copyright (C) 2011 Free Software Foundation, Inc.
8181
8182 This file is part of GNU Emacs.
8183
8184 GNU Emacs is free software: you can redistribute it and/or modify
8185 it under the terms of the GNU General Public License as published by
8186 the Free Software Foundation, either version 3 of the License, or
8187 (at your option) any later version.
8188
8189 GNU Emacs is distributed in the hope that it will be useful,
8190 but WITHOUT ANY WARRANTY; without even the implied warranty of
8191 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8192 GNU General Public License for more details.
8193
8194 You should have received a copy of the GNU General Public License
8195 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.