Don't assume time_t can fit into int.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 Don't assume time_t can fit into int.
4 * buffer.h (struct buffer.modtime): Now time_t, not int.
5 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7
8 Minor fixes for signed vs unsigned integers.
9 * character.h (MAYBE_UNIFY_CHAR):
10 * charset.c (maybe_unify_char):
11 * keyboard.c (read_char, reorder_modifiers):
12 XINT -> XFASTINT, since the integer must be nonnegative.
13 * ftfont.c (ftfont_spec_pattern):
14 * keymap.c (access_keymap, silly_event_symbol_error):
15 XUINT -> XFASTINT, since the integer must be nonnegative.
16 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
17 since it makes no difference and we prefer signed.
18 * keyboard.c (record_char): Use XUINT when all the neighbors do.
19 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
20 nonnegative.
21
22 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
23
24 Malloc failure behavior now depends on size of allocation.
25 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
26 * lisp.h: Change signatures accordingly.
27 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
28 All callers changed. (Bug#8762)
29
30 * gnutls.c: Use Emacs's memory allocators.
31 Without this change, the gnutls library would invoke malloc etc.
32 directly, which causes problems on non-SYNC_INPUT hosts, and which
33 runs afoul of improving memory_full behavior. (Bug#8761)
34 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
35 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
36 xfree instead of the default malloc, realloc, free.
37 (Fgnutls_boot): No need to check for memory allocation failure,
38 since xmalloc does that for us.
39
40 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
41 * category.c (hash_get_category_set):
42 * ccl.c (ccl_driver):
43 * charset.c (Fdefine_charset_internal):
44 * charset.h (struct charset.hash_index):
45 * composite.c (get_composition_id, gstring_lookup_cache)
46 (composition_gstring_put_cache):
47 * composite.h (struct composition.hash_index):
48 * dispextern.h (struct image.hash):
49 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
50 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
51 (hashfn_equal, hashfn_user_defined, make_hash_table)
52 (maybe_resize_hash_table, hash_lookup, hash_put)
53 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
54 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
55 (Fsxhash, Fgethash, Fputhash, Fmaphash):
56 * image.c (make_image, search_image_cache, lookup_image)
57 (xpm_put_color_table_h):
58 * lisp.h (struct Lisp_Hash_Table):
59 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
60 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
61 for hashes and hash indexes, instead of 'unsigned' and 'int'.
62 * alloc.c (allocate_vectorlike):
63 Check for overflow in vector size calculations.
64 * ccl.c (ccl_driver):
65 Check for overflow when converting EMACS_INT to int.
66 * fns.c, image.c: Remove unnecessary static decls that would otherwise
67 need to be updated by these changes.
68 * fns.c (make_hash_table, maybe_resize_hash_table):
69 Check for integer overflow with large hash tables.
70 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
71 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
72 (SXHASH_REDUCE): New macro.
73 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
74 Use it instead of discarding useful hash info with large hash values.
75 (sxhash_float): New function.
76 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
77 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
78 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
79 Rewrite to use FIXNUM_BITS, as this simplifies things.
80 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
81 Adjust signatures to match updated version of code.
82 (consing_since_gc): Now EMACS_INT, since a single hash table can
83 use more than INT_MAX bytes.
84
85 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
86
87 Make it possible to build with GCC-4.6+ -O2 -flto.
88
89 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
90
91 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
92
93 * minibuf.c (get_minibuffer, read_minibuf_unwind):
94 Call minibuffer-inactive-mode.
95
96 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
97
98 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
99 Update dependencies.
100
101 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
102
103 * data.c (init_data): Remove code for UTS, this system is not
104 supported anymore.
105
106 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
107
108 Don't force ./temacs to start in terminal mode.
109
110 * frame.c (make_initial_frame): Initialize faces in all cases, not
111 only when CANNOT_DUMP is defined.
112 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
113
114 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
115
116 * dispnew.c (add_window_display_history): Use const for the string
117 pointer. Remove declaration, not needed.
118
119 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
120
121 Use 'inline', not 'INLINE'.
122 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
123 * alloc.c, fontset.c (INLINE): Remove.
124 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
125 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
126 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
127 * gmalloc.c (register_heapinfo): Use inline unconditionally.
128 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
129
130 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
131
132 Make it possible to run ./temacs.
133
134 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
135 syms_of_callproc does the same thing. Remove test for
136 "initialized", do it in the caller.
137 * emacs.c (main): Avoid calling set_initial_environment when dumping.
138
139 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
140
141 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
142 (read_minibuf): Use get_minibuffer.
143 (syms_of_minibuf): Use DEFSYM.
144 (Qmetadata): New var.
145 * data.c (Qbuffer): Don't make it static.
146 (syms_of_data): Use DEFSYM.
147
148 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
149
150 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
151 (CCL_CODE_MIN): New macro.
152
153 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
154
155 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
156
157 * eval.c (Qdebug): Now static.
158 * lisp.h (Qdebug): Remove decl. This reverts a part of the
159 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
160 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
161
162 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
163
164 * image.c: Various fixes to ImageMagick code comments.
165 (Fimagemagick_types): Doc fix.
166
167 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
168
169 Minor fixes prompted by GCC 4.6.0 warnings.
170
171 * xselect.c (converted_selections, conversion_fail_tag): Now static.
172
173 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
174 (x_clipboard_manager_save_all): Move extern decl to ...
175 * xterm.h: ... here, so that it can be checked for consistency.
176
177 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
178
179 * xselect.c (x_clipboard_manager_save_frame)
180 (x_clipboard_manager_save_all): New functions.
181 (Fx_clipboard_manager_save): Lisp function deleted.
182
183 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
184 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
185
186 * xterm.h: Update prototype.
187
188 2011-05-28 William Xu <william.xwl@gmail.com>
189
190 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
191 exiting (Bug#8239).
192
193 2011-05-28 Jim Meyering <meyering@redhat.com>
194
195 Avoid a sign-extension bug in crypto_hash_function.
196 * fns.c (to_uchar): Define.
197 (crypto_hash_function): Use it to convert some newly-signed
198 variables to unsigned, to avoid sign-extension bugs. For example,
199 without this change, (md5 "truc") would evaluate to
200 45723a2aff78ff4fff7fff1114760e62 rather than the expected
201 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
202 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
203
204 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
205
206 Integer overflow fixes.
207
208 * dbusbind.c: Serial number integer overflow fixes.
209 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
210 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
211 to hold a serial number that is too large for a fixnum.
212 (Fdbus_method_return_internal, Fdbus_method_error_internal):
213 Check for serial numbers out of range. Decode any serial number
214 that was so large that it became a float. (Bug#8722)
215
216 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
217 (Fdbus_call_method, Fdbus_call_method_asynchronously):
218 Use XFASTINT rather than XUINT when numbers are nonnegative.
219 (xd_append_arg, Fdbus_method_return_internal):
220 (Fdbus_method_error_internal): Likewise. Also, for unsigned
221 arguments, check that Lisp number is nonnegative, rather than
222 silently wrapping negative numbers around. (Bug#8722)
223 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
224 (Bug#8722)
225
226 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
227
228 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
229
230 ccl: add integer overflow checks
231 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
232 (IN_INT_RANGE): New macros.
233 (ccl_driver): Use them to check for integer overflow when
234 decoding a CCL program. Many of the new checks are whether XINT (x)
235 fits in int; it doesn't always, on 64-bit hosts. The new version
236 doesn't catch all possible integer overflows, but it's an
237 improvement. (Bug#8719)
238
239 * alloc.c (make_event_array): Use XINT, not XUINT.
240 There's no need for unsigned here.
241
242 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
243 This follows up to the 2011-05-06 change that substituted uintptr_t
244 for EMACS_INT. This case wasn't caught back then.
245
246 Rework Fformat to avoid integer overflow issues.
247 * editfns.c: Include <float.h> unconditionally, as it's everywhere
248 now (part of C89). Include <verify.h>.
249 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
250 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
251 (Fformat): Avoid the prepass trying to compute sizes; it was only
252 approximate and thus did not catch overflow reliably. Instead, walk
253 through the format just once, formatting and computing sizes as we go,
254 checking for integer overflow at every step, and allocating a larger
255 buffer as needed. Keep track separately whether the format is
256 multibyte. Keep only the most-recently calculated precision, rather
257 than them all. Record whether each argument has been converted to
258 string. Use EMACS_INT, not int, for byte and char and arg counts.
259 Support field widths and precisions larger than INT_MAX. Avoid
260 sprintf's undefined behavior with conversion specifications such as %#d
261 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
262 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
263 formatting out-of-range floating point numbers with int
264 formats. (Bug#8668)
265
266 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
267
268 * data.c: Avoid integer truncation in expressions involving floats.
269 * data.c: Include <intprops.h>.
270 (arith_driver): When there's an integer overflow in an expression
271 involving floating point, convert the integers to floating point
272 so that the resulting value does not suffer from catastrophic
273 integer truncation. For example, on a 64-bit host (* 4
274 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
275 Do not rely on undefined behavior after integer overflow.
276
277 merge count_size_as_multibyte, parse_str_to_multibyte
278 * character.c, character.h (count_size_as_multibyte):
279 Rename from parse_str_to_multibyte; all uses changed.
280 Check for integer overflow.
281 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
282 since it's now a duplicate of the other. This is more of
283 a character than a buffer op, so better that it's in character.c.
284 * fns.c, print.c: Adjust to above changes.
285
286 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
287
288 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
289
290 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
291
292 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
293 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
294 (x_clipboard_manager_save): Now static.
295 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
296
297 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
298 (crypto_hash_function): Now static.
299 Fix pointer signedness problems. Avoid unnecessary initializations.
300
301 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
302
303 * termhooks.h (Vselection_alist): Make it terminal-local.
304
305 * terminal.c (create_terminal): Initialize it.
306
307 * xselect.c: Support for clipboard managers.
308 (Vselection_alist): Move to termhooks.h as terminal-local var.
309 (LOCAL_SELECTION): New macro.
310 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
311 (symbol_to_x_atom): Remove gratuitous arg.
312 (x_handle_selection_request, lisp_data_to_selection_data)
313 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
314 (x_own_selection, x_get_local_selection, x_convert_selection):
315 New arg, specifying work frame. Use terminal-local Vselection_alist.
316 (some_frame_on_display): Delete unused function.
317 (Fx_own_selection_internal, Fx_get_selection_internal)
318 (Fx_disown_selection_internal, Fx_selection_owner_p)
319 (Fx_selection_exists_p): New optional frame arg.
320 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
321 (x_handle_selection_clear): Don't treat other terminals with the
322 same keyboard specially. Use the terminal-local Vselection_alist.
323 (x_clear_frame_selections): Use Frun_hook_with_args.
324
325 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
326
327 * xterm.h: Add support for those atoms.
328
329 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
330
331 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
332 (converted_selections, conversion_fail_tag): New global variables.
333 (x_selection_request_lisp_error): Free the above.
334 (x_get_local_selection): Remove unnecessary code.
335 (x_reply_selection_request): Args changed; handle arbitrary array
336 of converted selections stored in converted_selections.
337 Separate the XChangeProperty and SelectionNotify steps.
338 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
339 (x_convert_selection): New function.
340 (x_handle_selection_event): Simplify.
341 (x_get_foreign_selection): Don't ignore incoming requests while
342 waiting for an answer; this will fail when we implement
343 SAVE_TARGETS, and seems unnecessary anyway.
344 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
345 (Vx_sent_selection_functions): Doc fix.
346
347 2011-05-26 Leo Liu <sdl.web@gmail.com>
348
349 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
350
351 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
352
353 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
354
355 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
356 for fringe update if it has periodic bitmap.
357 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
358 and fringe_bitmap_periodic_p.
359
360 * fringe.c (get_fringe_bitmap_data): New function.
361 (draw_fringe_bitmap_1, update_window_fringes): Use it.
362 (update_window_fringes): Record periodicity of fringe bitmap in glyph
363 row. Mark glyph row for fringe update if periodicity changed.
364
365 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
366 for fringe update unless it has periodic bitmap.
367
368 2011-05-25 Kenichi Handa <handa@m17n.org>
369
370 * xdisp.c (get_next_display_element): Set correct it->face_id for
371 a static composition.
372
373 2011-05-24 Leo Liu <sdl.web@gmail.com>
374
375 * deps.mk (fns.o):
376 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
377
378 * fns.c (crypto_hash_function, Fsha1): New function.
379 (Fmd5): Use crypto_hash_function.
380 (syms_of_fns): Add Ssha1.
381
382 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
383
384 * gnutls.c: Remove unused macros.
385 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
386 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
387 Remove macros that are defined and never used.
388 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
389
390 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
391
392 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
393 (Fx_get_selection_internal): Minor cleanup.
394 (Fx_own_selection_internal): Rename arguments for consistency with
395 select.el.
396
397 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
398
399 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
400
401 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
402
403 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
404
405 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
406
407 * dispnew.c (scrolling_window): Don't exclude the case that the
408 last enabled row in the desired matrix touches the bottom boundary.
409
410 2011-05-21 Glenn Morris <rgm@gnu.org>
411
412 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
413 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
414 and add some more files.
415
416 2011-05-20 Eli Zaretskii <eliz@gnu.org>
417
418 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
419 report_file_error introduced by the change from 2011-05-07.
420
421 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
422
423 * systime.h (Time): Define only if emacs is defined.
424 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
425 where the include path doesn't have X11/X.h by default. See
426 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
427
428 2011-05-20 Kenichi Handa <handa@m17n.org>
429
430 * composite.c (find_automatic_composition): Fix previous change.
431
432 2011-05-20 Glenn Morris <rgm@gnu.org>
433
434 * lisp.mk: New file, split from Makefile.in.
435 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
436 (shortlisp): Remove.
437 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
438
439 2011-05-19 Glenn Morris <rgm@gnu.org>
440
441 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
442 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
443 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
444 (lisp): Set the order to that of loadup.el.
445 (shortlisp): Make it a copy of $lisp.
446 (SOME_MACHINE_LISP): Remove.
447 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
448 Use just $shortlisp, not $SOME_MACHINE_LISP too.
449
450 2011-05-18 Kenichi Handa <handa@m17n.org>
451
452 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
453 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
454 (find_automatic_composition): Mostly rewrite for efficiency.
455
456 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
457
458 * makefile.w32-in: Update dependencies.
459
460 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
461
462 * menu.c: Include limits.h (fixes the MS-Windows build broken by
463 revision 104625).
464
465 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
466
467 Fix some integer overflow issues, such as string length overflow.
468
469 * insdel.c (count_size_as_multibyte): Check for string overflow.
470
471 * character.c (lisp_string_width): Check for string overflow.
472 Use EMACS_INT, not int, for string indexes and lengths; in
473 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
474 the resulting string length overflows an EMACS_INT; instead,
475 report a string overflow if no precision given. When checking for
476 precision exhaustion, use a check that cannot possibly have
477 integer overflow. (Bug#8675)
478 * character.h (lisp_string_width): Adjust to new signature.
479
480 * alloc.c (string_overflow): New function.
481 (Fmake_string): Use it. This doesn't change behavior, but saves
482 a few bytes and will simplify future changes.
483 * character.c (string_escape_byte8): Likewise.
484 * lisp.h (string_overflow): New decl.
485
486 Fixups, following up to the user-interface timestamp change.
487 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
488 for UI timestamps, instead of unsigned long.
489 * msdos.c (mouse_get_pos): Likewise.
490 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
491 * w32gui.h (Time): Define by including "systime.h" rather than by
492 declaring it ourselves. (Bug#8664)
493
494 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
495 * image.c (clear_image_cache): Likewise.
496
497 * term.c (term_mouse_position): Don't assume time_t wraparound.
498
499 Be more systematic about user-interface timestamps.
500 Before, the code sometimes used 'Time', sometimes 'unsigned long',
501 and sometimes 'EMACS_UINT', to represent these timestamps.
502 This change causes it to use 'Time' uniformly, as that's what X uses.
503 This makes the code easier to follow, and makes it easier to catch
504 integer overflow bugs such as Bug#8664.
505 * frame.c (Fmouse_position, Fmouse_pixel_position):
506 Use Time, not unsigned long, for user-interface timestamps.
507 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
508 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
509 * keyboard.h (last_event_timestamp): Likewise.
510 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
511 * menu.h (xmenu_show): Likewise.
512 * term.c (term_mouse_position): Likewise.
513 * termhooks.h (struct input_event.timestamp): Likewise.
514 (struct terminal.mouse_position_hook): Likewise.
515 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
516 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
517 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
518 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
519 what it was before.
520 * menu.h, termhooks.h: Include "systime.h", for Time.
521
522 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
523 Don't assume that the difference between two unsigned long values
524 can fit into an integer. At this point, we know button_down_time
525 <= event->timestamp, so the difference must be nonnegative, so
526 there's no need to cast the result if double-click-time is
527 nonnegative, as it should be; check that it's nonnegative, just in
528 case. This bug is triggered when events are more than 2**31 ms
529 apart (about 25 days). (Bug#8664)
530
531 * xselect.c (last_event_timestamp): Remove duplicate decl.
532 (x_own_selection): Remove needless cast to unsigned long.
533
534 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
535 that always fit in int. Use a sentinel instead of a counter, to
536 avoid a temp and to allay GCC's concerns about possible int overflow.
537 * frame.h (struct frame): Use int for menu_bar_items_used
538 instead of EMACS_INT, since it always fits in int.
539
540 * menu.c (grow_menu_items): Check for int overflow.
541
542 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
543
544 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
545 Before, the code was not consistent. These values cannot exceed
546 2**31 - 1 so there's no need to make them unsigned.
547 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
548 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
549 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
550 as modifiers.
551 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
552
553 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
554 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
555 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
556 presumably because the widths might not match.
557
558 * window.c (size_window): Avoid needless test at loop start.
559
560 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
561
562 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
563
564 2011-05-12 Drew Adams <drew.adams@oracle.com>
565
566 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
567
568 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
569
570 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
571 `width' to `bar_area_x' and `bar_area_width', respectively.
572 (x_scroll_run): Take account of fringe background extension.
573
574 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
575 Rename local vars `left' and `width' to `bar_area_x' and
576 `bar_area_width', respectively.
577 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
578 background extension.
579
580 2011-05-10 Jim Meyering <meyering@redhat.com>
581
582 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
583
584 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
585
586 * image.c (Finit_image_library): Return t for built-in image types,
587 like pbm and xbm. (Bug#8640)
588
589 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
590
591 * w32menu.c (set_frame_menubar): Fix submenu allocation.
592
593 2011-05-07 Eli Zaretskii <eliz@gnu.org>
594
595 * w32console.c (Fset_screen_color): Doc fix.
596 (Fget_screen_color): New function.
597 (syms_of_ntterm): Defsubr it.
598
599 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
600 unlink the temporary file if Fcall_process didn't create it in the
601 first place.
602 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
603 child process will be redirected to a file specified with `:file'.
604 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
605 cue to call_process_cleanup not to close that handle.
606
607 2011-05-07 Ben Key <bkey76@gmail.com>
608
609 * makefile.w32-in: The bootstrap-temacs rule now makes use of
610 one of two shell specific rules, either bootstrap-temacs-CMD or
611 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
612 to the previous implementation of the bootstrap-temacs rule.
613 The bootstrap-temacs-CMD rule is similar to the previous
614 implementation of the bootstrap-temacs rule except that it
615 makes use of the ESC_CFLAGS variable instead of the CFLAGS
616 variable.
617
618 These changes, along with some changes to nt/configure.bat,
619 nt/gmake.defs, and nt/nmake.defs, are required to extend my
620 earlier fix to add support for --cflags and --ldflags options
621 that include quotes so that it works whether make uses cmd or
622 sh as the shell.
623
624 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
625
626 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
627 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
628 is a constant.
629 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
630 a string. Handle both cases.
631 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
632 (Fdbus_register_method): Use Qinvalid_function.
633
634 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
635
636 * makefile.w32-in: Update dependencies.
637 (LISP_H): Add inttypes.h and stdin.h.
638 (PROCESS_H): Add unistd.h.
639
640 2011-05-06 Eli Zaretskii <eliz@gnu.org>
641
642 * lread.c: Include limits.h (fixes the MS-Windows build broken by
643 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
644
645 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
646
647 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
648
649 * term.c (vfatal): Remove stray call to va_end.
650 It's not needed and the C Standard doesn't allow it here anyway.
651
652 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
653 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
654
655 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
656 bytes.
657
658 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
659
660 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
661
662 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
663
664 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
665
666 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
667
668 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
669 * charset.c (Fdefine_charset_internal): Don't initialize
670 charset.code_space[15]. The value was garbage, on hosts with
671 32-bit int (Bug#8600).
672
673 * lread.c (read_integer): Be more consistent with string-to-number.
674 Use string_to_number to do the actual conversion; this avoids
675 rounding errors and fixes some other screwups. Without this fix,
676 for example, #x1fffffffffffffff was misread as -2305843009213693952.
677 (digit_to_number): Move earlier, for benefit of read_integer.
678 Return -1 if the digit is out of range for the base, -2 if it is
679 not a digit in any supported base. (Bug#8602)
680
681 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
682
683 * dispnew.c (scrolling_window): Return 1 if we scrolled,
684 to match comment at start of function. This also removes a
685 GCC warning about overflow in a 32+64-bit port.
686
687 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
688
689 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
690 Reported by Stefan Monnier in
691 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
692 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
693 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
694
695 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
696 (EMACS_UINTPTR): Likewise, with uintptr_t.
697
698 * lisp.h: Prefer 64-bit EMACS_INT if available.
699 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
700 on 32-bit hosts that have 64-bit int, so that they can access
701 large files.
702 However, temporarily disable this change unless the temporary
703 symbol WIDE_EMACS_INT is defined.
704
705 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
706
707 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
708 This removes an assumption that EMACS_INT and long are the same
709 width as pointers. The assumption is true for Emacs porting targets
710 now, but we want to make other targets possible.
711 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
712 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
713 In the rest of the code, change types of integers that hold casted
714 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
715 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
716 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
717 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
718 No need to cast type when ORing.
719 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
720 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
721 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
722 assume EMACS_INT is the same width as char *.
723 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
724 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
725 Remove no-longer-needed casts.
726 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
727 (xg_tool_bar_help_callback, xg_make_tool_item):
728 Use EMACS_INTPTR to hold an integer
729 that will be cast to void *; this can avoid a GCC warning
730 if EMACS_INT is not the same width as void *.
731 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
732 * xdisp.c (display_echo_area_1, resize_mini_window_1):
733 (current_message_1, set_message_1):
734 Use a local to convert to proper width without a cast.
735 * xmenu.c (dialog_selection_callback): Likewise.
736
737 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
738 Also, don't assume VALBITS / RAND_BITS is less than 5,
739 and don't rely on undefined behavior when shifting a 1 left into
740 the sign bit.
741 * lisp.h (get_random): Change signature to match.
742
743 * lread.c (hash_string): Use size_t, not int, for hash computation.
744 Normally we prefer signed values; but hashing is special, because
745 it's better to use unsigned division on hash table sizes so that
746 the remainder is nonnegative. Also, size_t is the natural width
747 for hashing into memory. The previous code used 'int', which doesn't
748 retain enough info to hash well into very large tables.
749 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
750
751 * dbusbind.c: Don't possibly lose pointer info when converting.
752 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
753 Use XPNTR rather than XHASH, so that the high-order bits of
754 the pointer aren't lost when converting through void *.
755
756 * eval.c (Fautoload): Don't double-shift a pointer.
757
758 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
759
760 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
761
762 * gnutls.c (DEF_GNUTLS_FN):
763 * image.c (DEF_IMGLIB_FN): Make function pointers static.
764
765 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
766
767 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
768 marker. (Bug#8610)
769
770 2011-05-05 Eli Zaretskii <eliz@gnu.org>
771
772 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
773 New version that can reserve upto 2GB of heap space.
774
775 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
776
777 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
778
779 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
780
781 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
782 `gnutls_certificate_set_x509_key_file'.
783
784 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
785
786 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
787 Update dependencies.
788
789 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
790
791 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
792 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
793 Remove unused parameter `fildes'.
794 * process.c (read_process_output, send_process): Don't pass it.
795
796 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
797
798 Fix previous change: the library cache is defined in w32.c.
799 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
800 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
801
802 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
803
804 Implement dynamic loading of GnuTLS on Windows.
805
806 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
807 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
808 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
809 Declare.
810
811 * gnutls.c (Qgnutls_dll): Define.
812 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
813 (gnutls_*): Declare function pointers.
814 (init_gnutls_functions): New function to initialize function pointers.
815 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
816 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
817 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
818 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
819 (emacs_gnutls_write, emacs_gnutls_read)
820 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
821 (Fgnutls_available_p): New function.
822 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
823 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
824 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
825
826 * image.c: Include w32.h.
827 (Vimage_type_cache): Delete.
828 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
829 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
830 (w32_delayed_load): Move to w32.c.
831
832 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
833
834 * w32.c (QCloaded_from, Vlibrary_cache): Define.
835 (w32_delayed_load): Move from image.c. When loading a library, record
836 its filename in the :loaded-from property of the library id.
837 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
838 Initialize and staticpro them.
839 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
840
841 * process.c: Include lisp.h before w32.h, not after.
842 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
843 instead of gnutls_record_check_pending.
844
845 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
846
847 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
848
849 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
850 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
851 as passed in.
852
853 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
854
855 * xterm.c (x_set_frame_alpha): Do not set property on anything
856 else than FRAME_X_OUTER_WINDOW (Bug#8608).
857
858 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
859
860 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
861
862 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
863
864 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
865 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
866 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
867 (gnutls_global_initialized, Qgnutls_bootprop_priority)
868 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
869 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
870 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
871 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
872 (Qgnutls_bootprop_callbacks_verify): Make static.
873
874 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
875
876 * callproc.c: Indentation fixup.
877
878 * sysdep.c (wait_for_termination_1): Make static.
879 (wait_for_termination, interruptible_wait_for_termination):
880 Move after wait_for_termination_1.
881
882 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
883
884 * sysdep.c (interruptible_wait_for_termination): New function
885 which is like wait_for_termination, but allows keyboard
886 interruptions.
887
888 * callproc.c (Fcall_process): Add (:file "file") as an option for
889 the STDOUT buffer.
890 (Fcall_process_region): Ditto.
891
892 2011-04-30 Eli Zaretskii <eliz@gnu.org>
893
894 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
895 rather than `XVECTOR (FOO)->size'.
896
897 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
898 inttypes.h, as a gnulib replacement is used if it not available in
899 system headers.
900
901 2011-04-21 Eli Zaretskii <eliz@gnu.org>
902
903 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
904 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
905 of MOST_POSITIVE_FIXNUM. (Bug#8528)
906
907 * coding.c (coding_alloc_by_realloc): Error out if destination
908 will grow beyond MOST_POSITIVE_FIXNUM.
909 (decode_coding_emacs_mule): Abort if there isn't enough place in
910 charbuf for the composition carryover bytes. Reserve an extra
911 space for up to 2 characters produced in a loop.
912 (decode_coding_iso_2022): Abort if there isn't enough place in
913 charbuf for the composition carryover bytes.
914
915 2011-04-21 Eli Zaretskii <eliz@gnu.org>
916
917 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
918 aborting when %lld or %lll format is passed.
919 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
920 %llo or %llx format is passed. (Bug#8545)
921
922 * window.c (window_scroll_line_based): Use a marker instead of
923 simple variables to record original value of point. (Bug#7952)
924
925 * doprnt.c (doprnt): Fix the case where a multibyte sequence
926 produced by %s or %c overflows available buffer space. (Bug#8545)
927
928 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
929
930 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
931 (SIZE_MAX): Move defn after all includes, as they might #define it.
932
933 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
934
935 * w32.c (init_environment): Warn about defaulting HOME to C:\.
936
937 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
938
939 * keyboard.c (Qdelayed_warnings_hook): Define.
940 (command_loop_1): Run `delayed-warnings-hook'
941 if Vdelayed_warnings_list is non-nil.
942 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
943 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
944
945 2011-04-28 Eli Zaretskii <eliz@gnu.org>
946
947 * doprnt.c (doprnt): Don't return value smaller than the buffer
948 size if the message was truncated. (Bug#8545).
949
950 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
951
952 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
953 (Fx_window_property): #if-0 the whole functions, not just the bodies.
954
955 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
956
957 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
958
959 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
960
961 * makefile.w32-in: Update dependencies.
962
963 2011-04-27 Eli Zaretskii <eliz@gnu.org>
964
965 Improve `doprnt' and its usage. (Bug#8545)
966 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
967 `format_end'. Remove support for %l as a conversion specifier.
968 Don't use xrealloc. Improve diagnostics when the %l size modifier
969 is used. Update the commentary.
970
971 * eval.c (verror): Simplify calculation of size_t.
972
973 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
974 messages.
975
976 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
977
978 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
979 change.
980
981 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
982
983 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
984 This makes this file independent of the recent pseudovector change.
985
986 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
987
988 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
989
990 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
991 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
992 Remove unused local.
993 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
994
995 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
996 GCC 4.6.0 optimizes based on type-based alias analysis.
997 For example, if b is of type struct buffer * and v of type struct
998 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
999 != &v->size, and therefore "v->size = 1; b->size = 2; return
1000 v->size;" must therefore return 1. This assumption is incorrect
1001 for Emacs, since it type-puns struct Lisp_Vector * with many other
1002 types. To fix this problem, this patch adds a new type struct
1003 vectorlike_header that documents the constraints on layout of vectors
1004 and pseudovectors, and helps optimizing compilers not get fooled
1005 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1006 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1007 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1008 the size member.
1009 (XSETPVECTYPE): Rewrite in terms of new macro.
1010 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1011 This is a bit clearer, and further avoids the possibility of
1012 undesirable aliasing.
1013 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1014 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1015 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1016 since Lisp_Subr is a special case (no "next" field).
1017 (ASIZE): Now uses header.size rather than size.
1018 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1019 to avoid the hassle of writing XVECTOR (foo)->header.size.
1020 (struct vectorlike_header): New type.
1021 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1022 object, to help avoid aliasing.
1023 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1024 (SUBRP): Likewise, since Lisp_Subr is a special case.
1025 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1026 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1027 (struct Lisp_Hash_Table): Combine first two members into a single
1028 struct vectorlike_header member. All uses of "size" and "next" members
1029 changed to be "header.size" and "header.next".
1030 * buffer.h (struct buffer): Likewise.
1031 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1032 * frame.h (struct frame): Likewise.
1033 * process.h (struct Lisp_Process): Likewise.
1034 * termhooks.h (struct terminal): Likewise.
1035 * window.c (struct save_window_data, struct saved_window): Likewise.
1036 * window.h (struct window): Likewise.
1037 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1038 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1039 * buffer.c (init_buffer_once): Likewise.
1040 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1041 special case.
1042 * process.c (Fformat_network_address): Use local var for size,
1043 for brevity.
1044
1045 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1046
1047 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1048 * data.c (atof): Remove decl; no longer used or needed.
1049 (digit_to_number): Move to lread.c.
1050 (Fstring_to_number): Use new string_to_number function, to be
1051 consistent with how the Lisp reader treats infinities and NaNs.
1052 Do not assume that floating-point numbers represent EMACS_INT
1053 without losing information; this is not true on most 64-bit hosts.
1054 Avoid double-rounding errors, by insisting on integers when
1055 parsing non-base-10 numbers, as the documentation specifies.
1056 * lisp.h (string_to_number): New decl, replacing ...
1057 (isfloat_string): Remove.
1058 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1059 (read1): Do not accept +. and -. as integers; this
1060 appears to have been a coding error. Similarly, do not accept
1061 strings like +-1e0 as floating point numbers. Do not report
1062 overflow for integer overflows unless the base is not 10 which
1063 means we have no simple and reliable way to continue.
1064 Break out the floating-point parsing into a new
1065 function string_to_number, so that Fstring_to_number parses
1066 floating point numbers consistently with the Lisp reader.
1067 (digit_to_number): Move here from data.c. Make it static inline.
1068 (E_CHAR, EXP_INT): Remove, replacing with ...
1069 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1070 (string_to_number): New function, replacing isfloat_string.
1071 This function checks for valid syntax and produces the resulting
1072 Lisp float number too. Rework it so that string-to-number
1073 no longer mishandles examples like "1.0e+". Use strtoumax,
1074 so that overflow for non-base-10 numbers is reported only when
1075 there's no portable and simple way to convert to floating point.
1076
1077 * textprop.c (set_text_properties_1): Rewrite for clarity,
1078 and to avoid GCC warning about integer overflow.
1079
1080 * intervals.h (struct interval): Use EMACS_INT for members
1081 where EMACS_UINT might cause problems. See
1082 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1083 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1084 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1085 All uses changed.
1086 (offset_intervals): Tell GCC not to worry about length overflow
1087 when negating a negative length.
1088
1089 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1090 (overrun_check_free): Likewise.
1091
1092 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1093 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1094 word size.
1095
1096 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1097 (gnutls_make_error): Rename local to avoid shadowing.
1098 (gnutls_emacs_global_deinit): ifdef out; not used.
1099 (Fgnutls_boot): Use const for pointer to readonly storage.
1100 Comment out unused local. Fix pointer signedness problems.
1101
1102 * lread.c (openp): Don't stuff size_t into an 'int'.
1103 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1104 about possible signed overflow.
1105
1106 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1107 (GDK_KEY_g): Don't define if already defined.
1108 (xg_prepare_tooltip): Avoid pointer signedness problem.
1109 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1110
1111 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1112 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1113
1114 * xfns.c (Fx_window_property): Simplify a bit,
1115 to make a bit faster and to avoid GCC 4.6.0 warning.
1116 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1117
1118 * fns.c (internal_equal): Don't assume size_t fits in int.
1119
1120 * alloc.c (compact_small_strings): Tighten assertion a little.
1121
1122 Replace pEd with more-general pI, and fix some printf arg casts.
1123 * lisp.h (pI): New macro, generalizing old pEd macro to other
1124 conversion specifiers. For example, use "...%"pI"d..." rather
1125 than "...%"pEd"...".
1126 (pEd): Remove. All uses replaced with similar uses of pI.
1127 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1128 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1129 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1130 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1131 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1132 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1133 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1134 64-bit hosts.
1135 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1136 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1137 * print.c (safe_debug_print, print_object): Likewise.
1138 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1139 to int.
1140 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1141 avoiding the 0 flag, which is not portable.
1142 * process.c (Fmake_network_process): Use pI to avoid cast.
1143 * region-cache.c (pp_cache): Likewise.
1144 * xdisp.c (decode_mode_spec): Likewise.
1145 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1146 behavior on 64-bit hosts with printf arg.
1147 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1148 (x_stop_queuing_selection_requests): Likewise.
1149 (x_get_window_property): Don't truncate byte count to an 'int'
1150 when tracing.
1151
1152 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1153 here, since it parses constructs like leading '-' and spaces,
1154 which are not wanted; and it overflows with large numbers.
1155 Instead, simply match F[0-9]+, which is what is wanted anyway.
1156
1157 * alloc.c: Remove unportable assumptions about struct layout.
1158 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1159 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1160 (allocate_vectorlike, make_pure_vector): Use the new macros,
1161 plus offsetof, to remove unportable assumptions about struct layout.
1162 These assumptions hold on all porting targets that I know of, but
1163 they are not guaranteed, they're easy to remove, and removing them
1164 makes further changes easier.
1165
1166 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1167 This doesn't fix a bug but makes the code clearer.
1168 (string_overrun_cookie): Now const. Use initializers that
1169 don't formally overflow signed char, to avoid warnings.
1170 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1171 can cause Emacs to crash when string overrun checking is enabled.
1172 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1173 multiple of sizeof (EMACS_INT); it need not be, if
1174 alignof(EMACS_INT) < sizeof (EMACS_INT).
1175 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1176
1177 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1178
1179 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1180
1181 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1182
1183 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1184 supposed to be handshaking. (Bug#8556)
1185 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1186
1187 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1188
1189 * lisp.h (Qdebug): List symbol.
1190 * eval.c (Qdebug): Restore global linkage.
1191 * keyboard.c (debug-on-event): New variable.
1192 (handle_user_signal): Break into debugger when debug-on-event
1193 matches the current signal symbol.
1194
1195 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1196
1197 * alloc.c (check_sblock, check_string_bytes)
1198 (check_string_free_list): Convert to standard C.
1199
1200 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1201
1202 * w32.c (emacs_gnutls_push): Fix typo.
1203
1204 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1205
1206 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1207 "cast to pointer from integer of different size".
1208
1209 Improve doprnt and its use in verror. (Bug#8545)
1210 * doprnt.c (doprnt): Document the set of format control sequences
1211 supported by the function. Use SAFE_ALLOCA instead of always
1212 using `alloca'.
1213
1214 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1215 is one byte too soon. Don't use xrealloc; instead xfree and
1216 xmalloc anew.
1217
1218 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1219
1220 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1221 callbacks stage.
1222
1223 * gnutls.c: Renamed global_initialized to
1224 gnutls_global_initialized. Added internals for the
1225 :verify-hostname-error, :verify-error, and :verify-flags
1226 parameters of `gnutls-boot' and documented those parameters in the
1227 docstring. Start callback support.
1228 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1229 unless a fatal error occured. Call gnutls_alert_send_appropriate
1230 on error. Return error code.
1231 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1232 (emacs_gnutls_read): Likewise.
1233 (Fgnutls_boot): Return handshake error code.
1234 (emacs_gnutls_handle_error): New function.
1235 (wsaerror_to_errno): Likewise.
1236
1237 * w32.h (emacs_gnutls_pull): Add prototype.
1238 (emacs_gnutls_push): Likewise.
1239
1240 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1241 (emacs_gnutls_push): Likewise.
1242
1243 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1244
1245 * process.c (wait_reading_process_output): Check if GnuTLS
1246 buffered some data internally if no FDs are set for TLS
1247 connections.
1248
1249 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1250 (LIBS): Link to USER_LIBS.
1251 ($(BLD)/gnutls.$(0)): New target.
1252
1253 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (handle_single_display_spec): Rename the
1256 display_replaced_before_p argument into display_replaced_p, to
1257 make it consistent with the commentary. Fix typos in the
1258 commentary.
1259
1260 * textprop.c (syms_of_textprop): Remove dead code.
1261 (copy_text_properties): Delete obsolete commentary about an
1262 interface that was deleted long ago. Fix typos in the description
1263 of arguments.
1264
1265 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1266 to changes in oldXMenu/XMenu.h from 2011-04-16.
1267 <menu_help_message, prev_menu_help_message>: Constify.
1268 (IT_menu_make_room): menu->help_text is now `const char **';
1269 adjust.
1270
1271 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1272 to changes in oldXMenu/XMenu.h from 2011-04-16.
1273 (struct XMenu): Declare `help_text' `const char **'.
1274
1275 * xfaces.c <Qunspecified>: Make extern again.
1276
1277 * syntax.c: Include sys/types.h before including regex.h, as
1278 required by Posix.
1279
1280 * doc.c (get_doc_string): Improve the format passed to `error'.
1281
1282 * doprnt.c (doprnt): Improve commentary.
1283
1284 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1285
1286 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1287 them with etags.
1288
1289 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1290 changes in globals.h immediately force recompilation.
1291 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1292 $(CURDIR)/s/ms-w32.h.
1293 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1294
1295 * character.c (Fchar_direction): Function deleted.
1296 (syms_of_character): Don't defsubr it.
1297 <char-direction-table>: Deleted.
1298
1299 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1300
1301 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1302 * doprnt.c: Include limits.h.
1303 (SIZE_MAX): New macro.
1304 (doprnt): Return a size_t value. 2nd arg is now size_t.
1305 Many local variables are now size_t instead of int or unsigned.
1306 Improve overflow protection. Support `l' modifier for integer
1307 conversions. Support %l conversion. Don't assume an EMACS_INT
1308 argument for integer conversions and for %c.
1309
1310 * lisp.h (doprnt): Restore prototype.
1311
1312 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1313 $(SRC)/character.h.
1314
1315 * Makefile.in (base_obj): Add back doprnt.o.
1316
1317 * deps.mk (doprnt.o): Add back prerequisites.
1318 (callint.o): Depend on character.h.
1319
1320 * eval.c (internal_lisp_condition_case): Include the handler
1321 representation in the error message.
1322 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1323 when breaking from the loop.
1324
1325 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1326
1327 * callint.c (Fcall_interactively): When displaying error message
1328 about invalid control letter, pass the character's codepoint, not
1329 a pointer to its multibyte form. Improve display of the character
1330 in octal and display also its hex code.
1331
1332 * character.c (char_string): Use %x to display the (unsigned)
1333 codepoint of an invalid character, to avoid displaying a bogus
1334 negative value.
1335
1336 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1337 `error', not SYMBOL_NAME itself.
1338
1339 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1340 character arguments to `error'.
1341
1342 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1343 to `error' in error message about FINAL_CHAR argument. Make sure
1344 FINAL_CHAR is a character, and use %c when it is passed as
1345 argument to `error'.
1346
1347 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1348
1349 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1350
1351 * w32.c: Include <time.h>.
1352 (sys_localtime): New function.
1353
1354 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1355
1356 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1357
1358 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1359
1360 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1361
1362 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1363 zombies (Bug#8467).
1364
1365 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1366
1367 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1368 gl_state.e_property when gl_state.object is Qt.
1369
1370 * insdel.c (make_gap_larger): Remove limitation of buffer size
1371 to <= INT_MAX.
1372
1373 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1374
1375 * xdisp.c (lookup_glyphless_char_display)
1376 (produce_glyphless_glyph): Handle cons cell entry in
1377 glyphless-char-display.
1378 (Vglyphless_char_display): Document it.
1379
1380 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1381 glyphless-char-display.
1382
1383 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1384
1385 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1386
1387 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1388
1389 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1390 definition for no-X builds.
1391
1392 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 Static checks with GCC 4.6.0 and non-default toolkits.
1395
1396 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1397
1398 * process.c (keyboard_bit_set): Define only if SIGIO.
1399 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1400 (send_process): Repair possible setjmp clobbering.
1401
1402 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1403
1404 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1405
1406 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1407
1408 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1409 Define only if needed.
1410
1411 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1412 by pacifying GCC about it. Maybe it's time to retire it?
1413 * xfaces.c (USG, __TIMEVAL__): Likewise.
1414
1415 * dispextern.h (struct redisplay_interface): Rename param
1416 to avoid shadowing.
1417 * termhooks.h (struct terminal): Likewise.
1418 * xterm.c (xembed_send_message): Likewise.
1419
1420 * insdel.c (make_gap_smaller): Define only if
1421 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1422
1423 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1424 it.
1425
1426 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1427 so that we aren't warned about unused symbols.
1428
1429 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1430
1431 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1432
1433 * xfns.c (x_real_positions): Mark locals as initialized.
1434
1435 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1436
1437 * xterm.c: Fix problems found by static analysis with other toolkits.
1438 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1439 (x_dispatch_event): Declare static if USE_GTK, and
1440 define if USE_GTK || USE_X_TOOLKIT.
1441 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1442 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1443 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1444 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1445
1446 * xmenu.c (menu_help_callback): Pointer type fixes.
1447 Use const pointers when pointing at readonly data. Avoid pointer
1448 signedness clashes.
1449 (FALSE): Remove unused macro.
1450 (update_frame_menubar): Remove unused decl.
1451
1452 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1453
1454 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1455 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1456 (single_menu_item): Rename local to avoid shadowing.
1457
1458 * keyboard.c (make_lispy_event): Remove unused local var.
1459
1460 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1461 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1462
1463 * bitmaps: Change bitmaps from unsigned char back to the X11
1464 compatible char. Avoid the old compiler warnings about
1465 out-of-range initializers by using, for example, '\xab' rather
1466 than 0xab.
1467
1468 * xgselect.c (xgselect_initialize): Check vs interface
1469 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1470
1471 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1472
1473 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1474 to read-only memory.
1475
1476 * fns.c (vector): Remove; this old hack is no longer needed.
1477
1478 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1479 Remove unused var.
1480 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1481
1482 * xrdb.c (x_load_resources): Omit unused local.
1483
1484 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1485 (x_window): Rename locals to avoid shadowing.
1486 (USG): Use the kludged USG macro, to pacify gcc.
1487
1488 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1489 (x_term_init): Remove local to avoid shadowing.
1490
1491 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1492
1493 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1494 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1495
1496 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1497
1498 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1499
1500 Fix regex.c, syntax.c and friends for buffers > 2GB.
1501 * syntax.h (struct gl_state_s): Declare character position members
1502 EMACS_INT.
1503
1504 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1505
1506 * textprop.c (verify_interval_modification, interval_of):
1507 Declare arguments EMACS_INT.
1508
1509 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1510 EMACS_INT.
1511
1512 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1513
1514 * indent.c (Fvertical_motion): Local variable it_start is now
1515 EMACS_INT.
1516
1517 * regex.c (re_match, re_match_2, re_match_2_internal)
1518 (bcmp_translate, regcomp, regexec, print_double_string)
1519 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1520 (re_compile_pattern, re_exec): Declare arguments and local
1521 variables `size_t' and `ssize_t' and return values `regoff_t', as
1522 appropriate.
1523 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1524 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1525 <compile_stack_type>: `size' and `avail' are now `size_t'.
1526
1527 * regex.h <regoff_t>: Use ssize_t, not int.
1528 (re_search, re_search_2, re_match, re_match_2): Arguments that
1529 specify buffer/string position and length are now ssize_t and
1530 size_t. Return type is regoff_t.
1531
1532 2011-04-16 Ben Key <bkey76@gmail.com>
1533
1534 * nsfont.m: Fixed bugs in ns_get_family and
1535 ns_descriptor_to_entity that were caused by using free to
1536 deallocate memory blocks that were allocated by xmalloc (via
1537 xstrdup). This caused Emacs to crash when compiled with
1538 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1539 --enable-checking=xmallocoverrun). xfree is now used to
1540 deallocate these memory blocks.
1541
1542 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1545
1546 emacs_write: Accept and return EMACS_INT for sizes.
1547 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1548 et seq.
1549 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1550 Accept and return EMACS_INT.
1551 (emacs_gnutls_write): Return the number of bytes written on
1552 partial writes.
1553 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1554 (emacs_read, emacs_write): Remove check for negative size, as the
1555 Emacs source code has been audited now.
1556 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1557 (emacs_read, emacs_write): Use it.
1558 * process.c (send_process): Adjust to the new signatures of
1559 emacs_write and emacs_gnutls_write. Do not attempt to store
1560 a byte offset into an 'int'; it might overflow.
1561 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1562
1563 * sound.c: Don't assume sizes fit in 'int'.
1564 (struct sound_device.period_size, alsa_period_size):
1565 Return EMACS_INT, not int.
1566 (struct sound_device.write, vox_write, alsa_write):
1567 Accept EMACS_INT, not int.
1568 (wav_play, au_play): Use EMACS_INT to store sizes and to
1569 record read return values.
1570
1571 2011-04-15 Ben Key <bkey76@gmail.com>
1572
1573 * keyboard.c (Qundefined): Don't declare static since it is used
1574 in nsfns.m.
1575 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1576 static since they are used in nsfont.m.
1577
1578 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1579
1580 * process.c (Qprocessp): Don't declare static.
1581 * lisp.h (Qprocessp): Declare again.
1582
1583 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1586
1587 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 Improve C-level modularity by making more things 'static'.
1590
1591 Don't publish debugger-only interfaces to other modules.
1592 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1593 (verify_bytepos, count_markers): Move decls to the only modules
1594 that need them.
1595 * region-cache.h (pp_cache): Likewise.
1596 * window.h (check_all_windows): Likewise.
1597 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1598
1599 * sysdep.c (croak): Now static, if
1600 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1601 * syssignal.h (croak): Declare only if not static.
1602
1603 * alloc.c (refill_memory_reserve): Now static if
1604 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1605 * lisp.h (refill_memory_reserve): Declare only if not static.
1606
1607 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1608 Define only if USE_LUCID.
1609
1610 * xrdb.c (x_customization_string, x_rm_string): Now static.
1611
1612 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1613 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1614
1615 * xdisp.c (draw_row_with_mouse_face): Now static.
1616 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1617
1618 * window.h (check_all_windows): Mark externally visible.
1619
1620 * window.c (window_deletion_count): Now static.
1621
1622 * undo.c: Make symbols static if they're not exported.
1623 (last_undo_buffer, last_boundary_position, pending_boundary):
1624 Now static.
1625
1626 * textprop.c (interval_insert_behind_hooks): Now static.
1627 (interval_insert_in_front_hooks): Likewise.
1628
1629 * term.c: Make symbols static if they're not exported.
1630 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1631 (max_frame_lines, tty_set_terminal_modes):
1632 (tty_reset_terminal_modes, tty_turn_off_highlight):
1633 (get_tty_terminal): Now static.
1634 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1635 * termhooks.h (term_mouse_moveto): Do not declare if
1636 HAVE_WINDOW_SYSTEM.
1637 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1638 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1639
1640 * sysdep.c: Make symbols static if they're not exported.
1641 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1642 Now static.
1643 (sigprocmask_set, full_mask): Remove; unused.
1644 (wait_debugging): Mark as visible.
1645 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1646 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1647
1648 * syntax.c (syntax_temp): Define only if !__GNUC__.
1649
1650 * sound.c (current_sound_device, current_sound): Now static.
1651
1652 * search.c (searchbufs, searchbuf_head): Now static.
1653
1654 * scroll.c (scroll_cost): Remove; unused.
1655 * dispextern.h (scroll_cost): Remove decl.
1656
1657 * region-cache.h (pp_cache): Mark as externally visible.
1658
1659 * process.c: Make symbols static if they're not exported.
1660 (process_tick, update_tick, create_process, chan_process):
1661 (Vprocess_alist, proc_buffered_char, datagram_access):
1662 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1663 (deactivate_process): Mark defn as static, as well as decl.
1664 * lisp.h (create_process): Remove decl.
1665 * process.h (chan_process, Vprocess_alist): Remove decls.
1666
1667 * print.c: Make symbols static if they're not exported.
1668 (print_depth, new_backquote_output, being_printed, print_buffer):
1669 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1670 (print_interval, print_number_index, initial_stderr_stream):
1671 Now static.
1672 * lisp.h (Fprinc): Remove decl.
1673 (debug_output_compilation_hack): Mark as externally visible.
1674
1675 * sysdep.c (croak): Move decl from here to syssignal.h.
1676 * syssignal.h (croak): Put it here, so the API can be checked when
1677 'croak' is called from dissociate_if_controlling_tty.
1678
1679 * minibuf.c: Make symbols static if they're not exported.
1680 (minibuf_save_list, choose_minibuf_frame): Now static.
1681 * lisp.h (choose_minibuf_frame): Remove decl.
1682
1683 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1684
1685 * lread.c: Make symbols static if they're not exported.
1686 (read_objects, initial_obarray, oblookup_last_bucket_number):
1687 Now static.
1688 (make_symbol): Remove; unused.
1689 * lisp.h (initial_obarray, make_symbol): Remove decls.
1690
1691 * keyboard.c: Make symbols static if they're not exported.
1692 (single_kboard, recent_keys_index, total_keys, recent_keys):
1693 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1694 (this_single_command_key_start, echoing, last_auto_save):
1695 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1696 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1697 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1698 (Vlispy_mouse_stem, double_click_count):
1699 Now static.
1700 (force_auto_save_soon): Define only if SIGDANGER.
1701 (ignore_mouse_drag_p): Now static if
1702 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1703 (print_help): Remove; unused.
1704 (stop_character, last_timer_event): Mark as externally visible.
1705 * keyboard.h (ignore_mouse_drag_p): Declare only if
1706 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1707 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1708 * lisp.h (echoing): Remove decl.
1709 (force_auto_save_soon): Declare only if SIGDANGER.
1710 * xdisp.c (redisplay_window): Simplify code, to make it more
1711 obvious that ignore_mouse_drag_p is not accessed if !defined
1712 USE_GTK && !defined HAVE_NS.
1713
1714 * intervals.c: Make symbols static if they're not exported.
1715 (merge_properties_sticky, merge_interval_right, delete_interval):
1716 Now static.
1717 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1718
1719 * insdel.c: Make symbols static if they're not exported.
1720 However, leave prepare_to_modify_buffer alone. It's never
1721 called from outside this function, but that appears to be a bug.
1722 (combine_after_change_list, combine_after_change_buffer):
1723 (adjust_after_replace, signal_before_change): Now static.
1724 (adjust_after_replace_noundo): Remove; unused.
1725 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1726 (signal_before_change): Remove decls.
1727
1728 * indent.c (val_compute_motion, val_vmotion): Now static.
1729
1730 * image.c: Make symbols static if they're not exported.
1731 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1732 if USE_GTK.
1733 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1734 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1735
1736 * fringe.c (standard_bitmaps): Now static.
1737 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1738
1739 * frame.c: Make symbols static if they're not exported.
1740 (x_report_frame_params, make_terminal_frame): Now static.
1741 (get_frame_param): Now static, unless HAVE_NS.
1742 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1743 (x_get_resource_string): Remove; not used.
1744 * frame.h (make_terminal_frame, x_report_frame_params):
1745 (x_get_resource_string); Remove decls.
1746 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1747 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1748
1749 * font.c, fontset.c: Make symbols static if they're not exported.
1750 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1751 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1752 * font.c (font_close_object): Now static.
1753 * font.h (font_close_object): Remove.
1754 * fontset.c (FONTSET_OBJLIST): Remove.
1755 (free_realized_fontset) #if-0 the body, which does nothing.
1756 (face_suitable_for_char_p): #if-0, as it's never called.
1757 * fontset.h (face_suitable_for_char_p): Remove decl.
1758 * xfaces.c (face_at_string_position):
1759 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1760 since 0 is always ASCII.
1761
1762 * fns.c (weak_hash_tables): Now static.
1763
1764 * fileio.c: Make symbols static if they're not exported.
1765 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1766 (Vwrite_region_annotation_buffers): Now static.
1767
1768 * eval.c: Make symbols static if they're not exported.
1769 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1770 * lisp.h (backtrace_list): Remove decl.
1771
1772 * emacs.c: Make symbols static if they're not exported.
1773 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1774 (fatal_error_code, fatal_error_signal_hook, standard_args):
1775 Now static.
1776 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1777 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1778 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1779 * lisp.h (fatal_error_signal_hook): Remove decl.
1780 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1781
1782 * editfns.c: Move a (normally-unused) function to its only use.
1783 * editfns.c, lisp.h (get_operating_system_release): Remove.
1784 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1785 worth the hassle of breaking this out.
1786
1787 * xterm.c: Make symbols static if they're not exported.
1788 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1789 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1790 (x_destroy_window, x_delete_display):
1791 Now static.
1792 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1793 (x_mouse_leave): Remove; unused.
1794 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1795 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1796 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1797 Remove decls.
1798 (x_mouse_leave): Declare only if WINDOWSNT.
1799 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1800 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1801 USE_X_TOOLKIT.
1802
1803 * ftxfont.c: Make symbols static if they're not exported.
1804 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1805 HAVE_FREETYPE.
1806 * font.h (ftxfont_driver): Likewise.
1807
1808 * xfns.c: Make symbols static if they're not exported.
1809 (x_last_font_name, x_display_info_for_name):
1810 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1811 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1812 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1813 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1814 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1815 (last_show_tip_args): Now static.
1816 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1817 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1818 (x_screen_planes): Remove; unused.
1819 * dispextern.h (x_screen_planes): Remove decl.
1820
1821 * dispnew.c: Make symbols static if they're not exported.
1822 * dispextern.h (redraw_garbaged_frames, scrolling):
1823 (increment_row_positions): Remove.
1824 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1825 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1826 Now static.
1827 (redraw_garbaged_frames): Remove; unused.
1828
1829 * xfaces.c: Make symbols static if they're not exported.
1830 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1831 Remove decls.
1832 * xterm.h (defined_color): Remove decls.
1833 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1834 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1835 (menu_face_changed_default, defined_color, free_realized_face):
1836 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1837 (ascii_face_of_lisp_face): Remove; unused.
1838
1839 * xdisp.c: Make symbols static if they're not exported.
1840 * dispextern.h (scratch_glyph_row, window_box_edges):
1841 (glyph_to_pixel_coords, set_cursor_from_row):
1842 (get_next_display_element, set_iterator_to_next):
1843 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1844 (show_mouse_face): Remove decls
1845 * frame.h (message_buf_print): Likewise.
1846 * lisp.h (pop_message, set_message, check_point_in_composition):
1847 Likewise.
1848 * xterm.h (set_vertical_scroll_bar): Likewise.
1849 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1850 (message_buf_print, scratch_glyph_row, displayed_buffer):
1851 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1852 (get_next_display_element, show_mouse_face, window_box_edges):
1853 (frame_to_window_pixel_xy, check_point_in_composition):
1854 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1855 (glyph_to_pixel_coords): Remove; unused.
1856
1857 * dired.c (file_name_completion): Now static.
1858
1859 * dbusbind.c (xd_in_read_queued_messages): Now static.
1860
1861 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1862 * data.c (circular_list_error): Remove.
1863
1864 * commands.h (last_point_position, last_point_position_buffer):
1865 (last_point_position_window): Remove decls.
1866 * keyboard.c: Make these variables static.
1867
1868 * coding.h (coding, code_convert_region, encode_coding_gap):
1869 Remove decls.
1870 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1871 (iso_code_class, detect_coding, code_convert_region): Now static.
1872 (encode_coding_gap): Remove; unused.
1873
1874 * chartab.c (chartab_chars, chartab_bits): Now static.
1875
1876 * charset.h (charset_iso_8859_1): Remove decl.
1877 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1878 Now static.
1879
1880 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1881 * ccl.c (Vccl_program_table): Now static.
1882 (check_ccl_update): Remove; unused.
1883
1884 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1885 * category.h: ... from here.
1886 * category.c (check_category_table, set_category_set): Now static.
1887
1888 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1889 * lisp.h: Remove these decls.
1890
1891 * buffer.c (buffer_count): Remove unused var.
1892
1893 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1894 so that it's not optimized away.
1895 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1896 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1897 exported only to the debugger.
1898
1899 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1900 * atimer.h (run_all_atimers): Remove; not exported.
1901
1902 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1903 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1904 was inaccessible from Lisp.
1905 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1906 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1907
1908 alloc.c: Import and export fewer symbols, and remove unused items.
1909 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1910 is defined.
1911 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1912 it's not optimized away by whole-program optimization.
1913 (message_enable_multibyte, free_misc): Remove.
1914 (catchlist, handlerlist, mark_backtrace):
1915 Declare only if BYTE_MARK_STACK.
1916 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1917 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1918 (message_enable_multibyte): Remove decl.
1919 (free_misc, interval_free_list, float_block, float_block_index):
1920 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1921 (cons_free_list, last_marked_index):
1922 Now static.
1923 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1924 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1925 (mark_backtrace): Define only if BYTE_MARK_STACK.
1926 * xdisp.c (message_enable_multibyte): Now static.
1927
1928 Declare Lisp_Object Q* variables to be 'static' if not exported.
1929 This makes it easier for human readers (and static analyzers)
1930 to see whether these variables are used from other modules.
1931 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1932 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1933 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1934 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1935 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1936 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1937 * xmenu.c, xselect.c:
1938 Declare Q* vars static if they are not used in other modules.
1939 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1940 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1941 Remove decls of unexported vars.
1942 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1943
1944 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1945
1946 Make Emacs functions such as Fatom 'static' by default.
1947 This makes it easier for human readers (and static analyzers)
1948 to see whether these functions can be called from other modules.
1949 DEFUN now defines a static function. To make the function external
1950 so that it can be used in other C modules, use the new macro DEFUE.
1951 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1952 (Finit_image_library):
1953 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1954 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1955 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1956 Remove decls, since these functions are now static.
1957 (Funintern, Fget_internal_run_time): New decls, since these functions
1958 were already external.
1959
1960 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1961 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1962 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1963 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1964 * keyboard.c, keymap.c, lread.c:
1965 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1966 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1967 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1968 Mark functions with DEFUE instead of DEFUN,
1969 if they are used in other modules.
1970 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1971 decls for now-static functions.
1972 * buffer.h (Fdelete_overlay): Remove decl.
1973 * callproc.c (Fgetenv_internal): Mark as internal.
1974 * composite.c (Fremove_list_of_text_properties): Remove decl.
1975 (Fcomposition_get_gstring): New forward static decl.
1976 * composite.h (Fcomposite_get_gstring): Remove decl.
1977 * dired.c (Ffile_attributes): New forward static decl.
1978 * doc.c (Fdocumntation_property): New forward static decl.
1979 * eval.c (Ffetch_bytecode): New forward static decl.
1980 (Funintern): Remove extern decl; now in .h file where it belongs.
1981 * fileio.c (Fmake_symbolic_link): New forward static decl.
1982 * image.c (Finit_image_library): New forward static decl.
1983 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1984 * intervals.h (Fprevious_property_change):
1985 (Fremove_list_of_text_properties): Remove decls.
1986 * keyboard.c (Fthis_command_keys): Remove decl.
1987 (Fcommand_execute): New forward static decl.
1988 * keymap.c (Flookup_key): New forward static decl.
1989 (Fcopy_keymap): Now static.
1990 * keymap.h (Flookup_key): Remove decl.
1991 * process.c (Fget_process): New forward static decl.
1992 (Fprocess_datagram_address): Mark as internal.
1993 * syntax.c (Fsyntax_table_p): New forward static decl.
1994 (skip_chars): Remove duplicate decl.
1995 * textprop.c (Fprevious_property_change): New forward static decl.
1996 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1997 Now internal.
1998 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1999 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2000
2001 * editfns.c (Fformat): Remove unreachable code.
2002
2003 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2004
2005 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2006 change. (Bug#8496)
2007
2008 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2011 when at ZV. (Bug#8487)
2012
2013 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2014
2015 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2016 (Bug#8437)
2017 * keyboard.c (parse_tool_bar_item): Likewise.
2018 * sound.c (sound_cleanup, alsa_close): Likewise.
2019 * termcap.c (tgetent): Likewise.
2020 * xfns.c (x_default_font_parameter): Likewise.
2021 * xsettings.c (read_and_apply_settings): Likewise.
2022
2023 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2024 (overrun_check_free): Protoize.
2025
2026 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2029 since callers should never pass a negative size.
2030 Change the signature to match that of plain 'read' and 'write'; see
2031 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2032 * lisp.h: Update prototypes of emacs_write and emacs_read.
2033
2034 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2035
2036 * xdisp.c (redisplay_window): Don't try to determine the character
2037 position of the scroll margin if the window start point w->startp
2038 is outside the buffer's accessible region. (Bug#8468)
2039
2040 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2041
2042 Fix write-region and its subroutines for buffers > 2GB.
2043 * fileio.c (a_write, e_write): Modify declaration of arguments and
2044 local variables to support buffers larger than 2GB.
2045 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2046
2047 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2048 argument, local variables, and return value.
2049
2050 * lisp.h: Update prototypes of emacs_write and emacs_read.
2051
2052 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2053
2054 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2057
2058 Fix more problems found by GCC 4.6.0's static checks.
2059
2060 * xdisp.c (vmessage): Use a better test for character truncation.
2061
2062 * charset.c (load_charset_map): <, not <=, for optimization,
2063 and to avoid potential problems with integer overflow.
2064 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2065 * casetab.c (set_identity, shuffle): Likewise.
2066 * editfns.c (Fformat): Likewise.
2067 * syntax.c (skip_chars): Likewise.
2068
2069 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2070 This also lets GCC 4.6.0 generate slightly better loop code.
2071
2072 * callint.c (Fcall_interactively): <, not <=, for optimization.
2073 (Fcall_interactively): Count the number of arguments produced,
2074 not the number of arguments given. This is simpler and lets GCC
2075 4.6.0 generate slightly better code.
2076
2077 * ftfont.c: Distingish more carefully between FcChar8 and char.
2078 The previous code passed unsigned char * to a functions like
2079 strlen and xstrcasecmp that expect char *, which does not
2080 conform to the C standard.
2081 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2082 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2083 char * when the C standard requires it.
2084
2085 * keyboard.c (read_char): Remove unused var.
2086
2087 * eval.c: Port to Windows vsnprintf (Bug#8435).
2088 Include <limits.h>.
2089 (SIZE_MAX): Define if the headers do not.
2090 (verror): Do not give up if vsnprintf returns a negative count.
2091 Instead, grow the buffer. This ports to Windows vsnprintf, which
2092 does not conform to C99. Problem reported by Eli Zaretskii.
2093 Also, simplify the allocation scheme, by avoiding the need for
2094 calling realloc, and removing the ALLOCATED variable.
2095
2096 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2097
2098 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2099 But keep the doprint source code for now, as we might revamp it
2100 and use it again (Bug#8435).
2101 * lisp.h (doprnt): Remove.
2102 * Makefile.in (base_obj): Remove doprnt.o.
2103 * deps.mk (doprnt.o): Remove.
2104
2105 error: Print 32- and 64-bit integers portably (Bug#8435).
2106 Without this change, on typical 64-bit hosts error ("...%d...", N)
2107 was used to print both 32- and 64-bit integers N, which relied on
2108 undefined behavior.
2109 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2110 New macro.
2111 * lisp.h (error, verror): Mark as printf-like functions.
2112 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2113 Report overflow in size calculations when allocating printf buffer.
2114 Do not truncate output string at its first null byte.
2115 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2116 Truncate the output at a character boundary, since vsnprintf does not
2117 do that.
2118 * charset.c (check_iso_charset_parameter): Convert internal
2119 character to string before calling 'error', since %c now has the
2120 printf meaning.
2121 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2122 overflow when computing char to be passed to 'error'. Do not
2123 pass Lisp_Object to 'error'; pass the integer instead.
2124 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2125 formatted with plain %d.
2126
2127 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2128
2129 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2130
2131 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2132
2133 * xterm.c (x_catch_errors): Remove duplicate declaration.
2134
2135 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2136
2137 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2138
2139 2011-04-10 Jim Meyering <meyering@redhat.com>
2140
2141 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2142 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2143 return ssize_t not "int", and use size_t as the buffer length.
2144 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2145 * gnutls.h: Update declarations.
2146 * process.c (read_process_output): Use ssize_t, to match.
2147 (send_process): Likewise.
2148
2149 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2150
2151 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2152
2153 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2154
2155 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2156 Use unsigned char, to match FcChar8 type definition.
2157
2158 * xterm.c (handle_one_xevent):
2159 * xmenu.c (create_and_show_popup_menu):
2160 * xselect.c (x_decline_selection_request)
2161 (x_reply_selection_request): Avoid type-punned deref of X events.
2162
2163 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2164
2165 Fix some uses of `int' instead of EMACS_INT.
2166 * search.c (string_match_1, fast_string_match)
2167 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2168 (scan_buffer, find_next_newline_no_quit)
2169 (find_before_next_newline, search_command, Freplace_match)
2170 (Fmatch_data): Make some `int' variables be EMACS_INT.
2171
2172 * xdisp.c (display_count_lines): 3rd argument and return value now
2173 EMACS_INT. All callers changed.
2174 (pint2hrstr): Last argument is now EMACS_INT.
2175
2176 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2177 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2178 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2179 (decode_coding_utf_16, decode_coding_emacs_mule)
2180 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2181 (decode_coding_ccl, decode_coding_charset)
2182 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2183 (decode_coding_iso_2022, decode_coding_emacs_mule)
2184 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2185 <char_offset, last_offset>: Declare EMACS_INT.
2186 (encode_coding_utf_8, encode_coding_utf_16)
2187 (encode_coding_emacs_mule, encode_invocation_designation)
2188 (encode_designation_at_bol, encode_coding_iso_2022)
2189 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2190 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2191 Declare EMACS_INT.
2192 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2193 (encode_invocation_designation): Last argument P_NCHARS is now
2194 EMACS_INT.
2195 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2196 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2197
2198 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2199 All users changed.
2200
2201 * ccl.c (Fccl_execute_on_string): Declare some variables
2202 EMACS_INT.
2203
2204 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2205
2206 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2207
2208 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2209
2210 * process.c (Fformat_network_address): Doc fix.
2211
2212 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2213
2214 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2215
2216 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2217
2218 * keyboard.c (read_char): Call Lisp function help-form-show,
2219 instead of using internal_with_output_to_temp_buffer.
2220 (Qhelp_form_show): New var.
2221 (syms_of_keyboard): Use DEFSYM macro.
2222
2223 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2224
2225 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2226
2227 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2228
2229 * process.c (Flist_processes): Remove to Lisp.
2230 (list_processes_1): Delete.
2231
2232 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2233
2234 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2235
2236 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2237
2238 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 Fix more problems found by GCC 4.6.0's static checks.
2241
2242 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2243
2244 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2245
2246 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2247
2248 * xdisp.c (vmessage): Mark as a printf-like function.
2249
2250 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2251
2252 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2253
2254 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2255 printf-like functions.
2256 (tiff_load): Add casts to remove these marks before passing them
2257 to system-supplied API.
2258
2259 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2260
2261 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2262 This avoids several warnings with gcc -Wstrict-overflow.
2263 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2264 directly, rather than having caller test rule sign. This avoids
2265 some unnecessary tests.
2266 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2267 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2268 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2269
2270 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2271 (xfont_open): Avoid unnecessary tests.
2272
2273 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2274
2275 * composite.h, composite.c (composition_gstring_put_cache):
2276 Use EMACS_INT, not int, for length.
2277
2278 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2279 breaking out part of COMPOSITION_DECODE_RULE.
2280 (COMPOSITION_DECODE_RULE): Use it.
2281 * composite.c (get_composition_id): Remove unused local vars,
2282 by using the new macro.
2283
2284 * textprop.c (set_text_properties_1): Change while to do-while,
2285 since the condition is always true at first.
2286
2287 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2288 (interval_deletion_adjustment): Return unsigned value.
2289 All uses changed.
2290
2291 * process.c (list_processes_1, create_pty, read_process_output):
2292 (exec_sentinel): Remove vars that were set but not used.
2293 (create_pty): Remove unnecessary "volatile"s.
2294 (Fnetwork_interface_info): Avoid possibility of int overflow.
2295 (read_process_output): Do adaptive read buffering even if carryover.
2296 (read_process_output): Simplify nbytes computation if buffered.
2297
2298 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2299
2300 * syntax.c (scan_words): Remove var that was set but not used.
2301 (update_syntax_table): Use unsigned instead of int.
2302
2303 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2304 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2305 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2306
2307 * print.c (print_error_message): Avoid int overflow.
2308
2309 * font.c (font_list_entities): Redo for clarity,
2310 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2311
2312 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2313 (font_score): Avoid potential overflow in diff calculation.
2314
2315 * fns.c (substring_both): Remove var that is set but not used.
2316 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2317
2318 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2319
2320 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2321 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2322 can always succeed if overflow has undefined behavior.
2323
2324 * search.c (boyer_moore, wordify): Remove vars set but not used.
2325 (wordify): Omit three unnecessary tests.
2326
2327 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2328 All callers changed. This avoids the need for an unused var.
2329
2330 * casefiddle.c (casify_region): Remove var that is set but not used.
2331
2332 * dired.c (file_name_completion): Remove var that is set but not used.
2333
2334 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2335
2336 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2337 (Finsert_file_contents): Remove unnecessary code checking fd.
2338
2339 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2340 Check for integer overflow on size calculations.
2341
2342 * buffer.c (Fprevious_overlay_change): Remove var that is set
2343 but not used.
2344
2345 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2346 Remove vars that are set but not used.
2347 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2348 (timer_check_2): Mark vars as initialized.
2349
2350 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2351
2352 * image.c (lookup_image): Remove var that is set but not used.
2353 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2354
2355 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2356 that are set but not used.
2357
2358 * xfns.c (make_invisible_cursor): Don't return garbage
2359 if XCreateBitmapFromData fails (Bug#8410).
2360
2361 * xselect.c (x_get_local_selection, x_handle_property_notify):
2362 Remove vars that are set but not used.
2363
2364 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2365 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2366
2367 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2368 Remove var that is set but not used.
2369 (scroll_bar_windows_size): Now size_t, not int.
2370 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2371 Check for overflow.
2372
2373 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2374 (map_tty_color) [!defined MSDOS]: Likewise.
2375
2376 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2377
2378 * coding.c: Remove vars that are set but not used.
2379 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2380 All callers changed.
2381 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2382 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2383 (decode_coding_charset): Remove vars that are set but not used.
2384
2385 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2386 that is set but not used.
2387
2388 * print.c (print_object): Remove var that is set but not used.
2389
2390 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2391 The gnulib version avoids calling malloc in the usual case,
2392 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2393 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2394 * filelock.c (current_lock_owner): Likewise.
2395 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2396 * sysdep.c: Include allocator.h, careadlinkat.h.
2397 (emacs_no_realloc_allocator): New static constant.
2398 (emacs_readlink): New function.
2399 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2400 ../lib/careadlinkat.h.
2401
2402 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2403
2404 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2405 first non-nil return value).
2406
2407 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2408
2409 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2410 if not defined (Bug#8403).
2411
2412 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2413
2414 * xdisp.c (display_count_lines): Remove parameter `start',
2415 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2416 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2417 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2418 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2419 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2420 and thereabouts. All callers changed.
2421 (get_per_char_metric): Remove parameter `f', unused since
2422 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2423
2424 2011-04-02 Jim Meyering <meyering@redhat.com>
2425
2426 do not dereference NULL upon failed strdup
2427 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2428 (ns_get_family): Likewise.
2429
2430 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2431
2432 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2433
2434 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2435
2436 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2437 later (Bug#8403).
2438
2439 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2440
2441 Add lexical binding.
2442
2443 * window.c (Ftemp_output_buffer_show): New fun.
2444 (Fsave_window_excursion):
2445 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2446
2447 * lread.c (lisp_file_lexically_bound_p): New function.
2448 (Fload): Bind Qlexical_binding.
2449 (readevalloop): Remove `evalfun' arg.
2450 Bind Qinternal_interpreter_environment.
2451 (Feval_buffer): Bind Qlexical_binding.
2452 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2453 Mark as dynamic.
2454 (syms_of_lread): Declare `lexical-binding'.
2455
2456 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2457
2458 * keyboard.c (eval_dyn): New fun.
2459 (menu_item_eval_property): Use it.
2460
2461 * image.c (parse_image_spec): Use Ffunctionp.
2462
2463 * fns.c (concat, mapcar1): Accept byte-code-functions.
2464
2465 * eval.c (Fsetq): Handle lexical vars.
2466 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2467 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2468 (FletX, Flet): Obey lexical binding.
2469 (Fcommandp): Handle closures.
2470 (Feval): New `lexical' arg.
2471 (eval_sub): New function extracted from Feval. Use it almost
2472 everywhere where Feval was used. Look up vars in lexical env.
2473 Handle closures.
2474 (Ffunctionp): Move from subr.el.
2475 (Ffuncall): Handle closures.
2476 (apply_lambda): Remove `eval_flags'.
2477 (funcall_lambda): Handle closures and new byte-code-functions.
2478 (Fspecial_variable_p): New function.
2479 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2480 but without exporting it to Lisp.
2481
2482 * doc.c (Fdocumentation, store_function_docstring):
2483 * data.c (Finteractive_form): Handle closures.
2484
2485 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2486 interactive spec.
2487
2488 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2489 New byte-codes.
2490 (exec_byte_code): New function extracted from Fbyte_code to handle new
2491 calling convention for byte-code-functions. Add new byte-codes.
2492
2493 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2494
2495 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2496
2497 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2498
2499 * xdisp.c (redisplay_internal): Fix prototype.
2500
2501 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2502
2503 * xdisp.c (SCROLL_LIMIT): New macro.
2504 (try_scrolling): Use it when setting scroll_limit.
2505 Limit scrolling to 100 screen lines.
2506 (redisplay_window): Even when falling back on "recentering",
2507 position point in the window according to scroll-conservatively,
2508 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2509
2510 (try_scrolling): When point is above the window, allow searching
2511 as far as scroll_max, or one screenful, to compute vertical
2512 distance from PT to the scroll margin position. This prevents
2513 try_scrolling from unnecessarily failing when
2514 scroll-conservatively is set to a value slightly larger than the
2515 window height. Clean up the case of PT below the margin at bottom
2516 of window: scroll_max can no longer be INT_MAX. When aggressive
2517 scrolling is in use, don't let point enter the opposite scroll
2518 margin as result of the scroll.
2519 (syms_of_xdisp) <scroll-conservatively>: Document the
2520 threshold of 100 lines for never-recentering scrolling.
2521
2522 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2523
2524 * dispextern.h (move_it_by_lines):
2525 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2526 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2527 (message_log_check_duplicate): Remove parameters `prev_bol' and
2528 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2529 (redisplay_internal): Remove parameter `preserve_echo_area',
2530 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2531
2532 * indent.c (Fvertical_motion):
2533 * window.c (window_scroll_pixel_based, Frecenter):
2534 Don't pass `need_y_p' to `move_it_by_lines'.
2535
2536 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2537
2538 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2539 steal a few bits to be more compact.
2540 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2541 Remove unneeded casts.
2542
2543 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2544
2545 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2546
2547 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2548 binding" message (bug#7967).
2549
2550 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 Fix more problems found by GCC 4.6.0's static checks.
2553
2554 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2555 Remove unused local var.
2556
2557 * editfns.c (Fmessage_box): Remove unused local var.
2558
2559 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2560 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2561 Omit unused local vars.
2562 * window.c (shrink_windows): Omit unused local var.
2563 * menu.c (digest_single_submenu): Omit unused local var.
2564 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2565 Omit unused local var.
2566
2567 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2568 Don't assume string length fits in int.
2569 (keyremap_step, read_key_sequence): Use size_t for sizes.
2570 (read_key_sequence): Don't check last_real_key_start redundantly.
2571
2572 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2573 instead of alloca (Bug#8344).
2574
2575 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2576 (Fbacktrace_frame): Don't assume nframes fits in int.
2577
2578 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2579
2580 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2581 concerns.
2582
2583 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2584
2585 * cm.c (calccost): Turn while-do into do-while, for clarity.
2586
2587 * keyboard.c (syms_of_keyboard): Use the same style as later
2588 in this function when indexing through an array. This also
2589 works around GCC bug 48267.
2590
2591 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2592
2593 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2594
2595 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2596 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2597
2598 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2599 This avoids undefined behavior on integer overflow, and is a bit
2600 more convenient anyway since it is compared to a size_t variable.
2601
2602 Variadic C functions now count arguments with size_t, not int.
2603 This avoids an unnecessary limitation on 64-bit machines, which
2604 caused (substring ...) to crash on large vectors (Bug#8344).
2605 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2606 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2607 All variadic functions and their callers changed accordingly.
2608 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2609 * data.c (arith_driver, float_arith_driver): Likewise.
2610 * editfns.c (general_insert_function): Likewise.
2611 * eval.c (struct backtrace.nargs, interactive_p)
2612 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2613 (funcall_lambda, mark_backtrace): Likewise.
2614 * fns.c (concat): Likewise.
2615 * frame.c (x_set_frame_parameters): Likewise.
2616 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2617 0 if not found, not -1. All callers changed.
2618
2619 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2620 (stack_copy_size): Now size_t, not int.
2621 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2622
2623 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2626 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2627 All callers changed.
2628
2629 * lisp.h (multibyte_char_to_unibyte):
2630 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2631 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2632 * character.h (CHAR_TO_BYTE8):
2633 * cmds.c (internal_self_insert):
2634 * editfns.c (general_insert_function):
2635 * keymap.c (push_key_description):
2636 * search.c (Freplace_match):
2637 * xdisp.c (message_dolog, set_message_1): All callers changed.
2638
2639 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2640
2641 * keyboard.c (safe_run_hook_funcall): New function.
2642 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2643 don't set the hook to nil, but remove the offending function instead.
2644 (Qcommand_hook_internal): Remove, unused.
2645 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2646 Vcommand_hook_internal.
2647
2648 * eval.c (enum run_hooks_condition): Remove.
2649 (funcall_nil, funcall_not): New functions.
2650 (run_hook_with_args): Call each function through a `funcall' argument.
2651 Remove `cond' argument, now redundant.
2652 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2653 (Frun_hook_with_args_until_failure): Adjust accordingly.
2654 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2655
2656 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2657
2658 * dispextern.h (string_buffer_position): Remove declaration.
2659
2660 * print.c (strout): Remove parameter `multibyte', unused since
2661 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2662
2663 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2664 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2665 All callers changed.
2666
2667 * w32.c (_wsa_errlist): Use braces for struct initializers.
2668
2669 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2670 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2671 All callers changed.
2672 (string_buffer_position): Likewise. Also, make static (it's never
2673 used outside xdisp.c).
2674 (cursor_row_p): Remove parameter `w', unused since
2675 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2676 (decode_mode_spec): Remove parameter `precision', introduced during
2677 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2678 All callers changed.
2679
2680 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2681
2682 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2683
2684 2011-03-27 Anders Lindgren <andlind@gmail.com>
2685
2686 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2687 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2688 (ns_update_auto_hide_menu_bar): New functions.
2689 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2690 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2691 ns_constrain_all_frames.
2692 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2693 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2694
2695 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2696
2697 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2698
2699 2011-03-27 Glenn Morris <rgm@gnu.org>
2700
2701 * syssignal.h: Replace RETSIGTYPE with void.
2702 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2703 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2704 Replace SIGTYPE with void everywhere.
2705 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2706 * s/template.h (SIGTYPE): Remove commented out definition.
2707
2708 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2709
2710 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2711 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2712
2713 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2714
2715 * w32.c (read_unc_volume): Use parameter `henum', instead of
2716 global variable `wget_enum_handle'.
2717
2718 * keymap.c (describe_vector): Remove parameters `indices' and
2719 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2720 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2721
2722 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2723
2724 * keyboard.c (timer_check): Remove parameter `do_it_now',
2725 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2726 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2727 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2728
2729 * keyboard.c (read_char):
2730 * w32menu.c (w32_menu_display_help):
2731 * xmenu.c (show_help_event, menu_help_callback):
2732 Adjust calls to `show_help_echo'.
2733
2734 * gtkutil.c (xg_maybe_add_timer):
2735 * keyboard.c (readable_events):
2736 * process.c (wait_reading_process_output):
2737 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2738
2739 * insdel.c (adjust_markers_gap_motion):
2740 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2741 (gap_left, gap_right): Don't call it.
2742
2743 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2744
2745 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2746 incurred during fontification.
2747
2748 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2751 (DEFVAR_PER_BUFFER): Don't pass it.
2752
2753 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2754 (scrolling_window): Don't pass it.
2755
2756 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2757
2758 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2759
2760 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2761 and `suffix'.
2762 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2763 of variables specific to SELinux and computation of `encoded_absname'.
2764
2765 * image.c (XPutPixel): Remove unused variable `height'.
2766
2767 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2768
2769 * unexw32.c (get_section_info): Remove unused variable `section'.
2770
2771 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2772 (system_process_attributes): Remove unused variable `sess'.
2773 (sys_read): Remove unused variable `err'.
2774
2775 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2776 (w32_wnd_proc): Remove unused variable `isdead'.
2777 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2778 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2779 (x_create_tip_frame): Remove unused variable `tem'.
2780
2781 * w32inevt.c (w32_console_read_socket):
2782 Remove unused variable `no_events'.
2783
2784 * w32term.c (x_draw_composite_glyph_string_foreground):
2785 Remove unused variable `width'.
2786
2787 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2788
2789 * w32term.c (x_set_glyph_string_clipping):
2790 Don't pass uninitialized region to CombineRgn.
2791
2792 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2793
2794 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2795 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2796 (Fx_close_connection): Remove unused variable `i'.
2797
2798 * w32font.c (w32font_draw): Return number of glyphs.
2799 (w32font_open_internal): Remove unused variable `i'.
2800 (w32font_driver): Add missing initializer.
2801
2802 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2803 (fill_in_menu): Remove unused variable `items_added'.
2804
2805 * w32term.c (last_mouse_press_frame): Remove static global variable.
2806 (w32_clip_to_row): Remove unused variable `f'.
2807 (x_delete_terminal): Remove unused variable `i'.
2808
2809 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2810 (NOTHING): Remove unused static global variable.
2811 (uniscribe_check_otf): Remove unused variable `table'.
2812 (uniscribe_font_driver): Add missing initializers.
2813
2814 2011-03-23 Julien Danjou <julien@danjou.info>
2815
2816 * term.c (Fsuspend_tty, Fresume_tty):
2817 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2818 * window.c (temp_output_buffer_show):
2819 * insdel.c (signal_before_change):
2820 * frame.c (Fhandle_switch_frame):
2821 * fileio.c (Fdo_auto_save):
2822 * emacs.c (Fkill_emacs):
2823 * editfns.c (save_excursion_restore):
2824 * cmds.c (internal_self_insert):
2825 * callint.c (Fcall_interactively):
2826 * buffer.c (Fkill_all_local_variables):
2827 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2828 Use Frun_hooks.
2829 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2830 unconditionnaly since it does the check itself.
2831
2832 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 Fix more problems found by GCC 4.5.2's static checks.
2835
2836 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2837 the first time through the loop, since we know p0 < p1 then.
2838 This also avoids a gcc -Wstrict-overflow warning.
2839
2840 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2841 leading to a memory leak, possible in functions like
2842 load_charset_map_from_file that can allocate an unbounded number
2843 of objects (Bug#8318).
2844
2845 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2846 that could (at least in theory) be that large.
2847
2848 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2849 This is less likely to overflow, and avoids undefined behavior if
2850 overflow does occur. All callers changed. Use strtoul to scan
2851 for the unsigned long integer.
2852 (pint2hrstr): Simplify and tune code slightly.
2853 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2854
2855 * scroll.c (do_scrolling): Work around GCC bug 48228.
2856 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2857
2858 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2859 This also avoids a warning with gcc -Wstrict-overflow.
2860 (validate_x_resource_name): Simplify count usage.
2861 This also avoids a warning with gcc -Wstrict-overflow.
2862
2863 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2864 fail (Bug#8306).
2865
2866 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2867
2868 * process.c (Fmake_network_process): Use socklen_t, not int,
2869 where POSIX says socklen_t is required in portable programs.
2870 This fixes a porting bug on hosts like 64-bit HP-UX, where
2871 socklen_t is wider than int (Bug#8277).
2872 (Fmake_network_process, server_accept_connection):
2873 (wait_reading_process_output, read_process_output):
2874 Likewise.
2875
2876 * process.c: Rename or move locals to avoid shadowing.
2877 (list_processes_1, Fmake_network_process):
2878 (read_process_output_error_handler, exec_sentinel_error_handler):
2879 Rename or move locals.
2880 (Fmake_network_process): Define label "retry_connect" only if needed.
2881 (Fnetwork_interface_info): Fix pointer signedness.
2882 (process_send_signal): Add cast to avoid pointer signedness problem.
2883 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2884 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2885
2886 Make tparam.h and terminfo.c consistent.
2887 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2888 Include tparam.h instead, since it declares them.
2889 * cm.h (PC): Remove extern decl; tparam.h now does this.
2890 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2891 * terminfo.c: Include tparam.h, to check interfaces.
2892 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2893 (tparam): Adjust signature to match interface in tparam.h;
2894 this removes some undefined behavior. Check that outstring and len
2895 are zero, which they always are with Emacs.
2896 * tparam.h (PC, BC, UP): New extern decls.
2897
2898 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2899 (xftfont_open): Rename locals to avoid shadowing.
2900
2901 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2902 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2903 (OTF_TAG_SYM): Omit macro if not needed.
2904 (ftfont_list): Remove unused local.
2905 (get_adstyle_property, ftfont_pattern_entity):
2906 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2907 Rename locals to avoid shadowing.
2908
2909 * xfont.c (xfont_list_family): Mark var as initialized.
2910
2911 * xml.c (make_dom): Now static.
2912
2913 * composite.c (composition_compute_stop_pos): Rename local to
2914 avoid shadowing.
2915 (composition_reseat_it): Remove unused locals.
2916 (find_automatic_composition, composition_adjust_point): Likewise.
2917 (composition_update_it): Mark var as initialized.
2918 (find_automatic_composition): Mark vars as initialized,
2919 with a FIXME (Bug#8290).
2920
2921 character.h: Rename locals to avoid shadowing.
2922 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2923 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2924 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2925 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2926 to avoid shadowing.
2927
2928 * textprop.c (property_change_between_p): Remove; unused.
2929
2930 * intervals.c (interval_start_pos): Now static.
2931
2932 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2933
2934 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2935 Rename locals to avoid shadowing.
2936
2937 * sound.c (wav_play, au_play, Fplay_sound_internal):
2938 Fix pointer signedness.
2939 (alsa_choose_format): Remove unused local var.
2940 (wav_play): Initialize a variable to 0, to prevent undefined
2941 behavior (Bug#8278).
2942
2943 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2944
2945 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2946
2947 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2948 clobbering (Bug#8298).
2949 * sysdep.c (sys_subshell): Likewise.
2950 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2951
2952 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2953 This should get cleaned up, so that child_setup has the
2954 same signature on all platforms.
2955
2956 * callproc.c (call_process_cleanup): Now static.
2957 (relocate_fd): Rename locals to avoid shadowing.
2958
2959 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2960
2961 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2962 not to be necessary, and produces flickering.
2963
2964 2011-03-20 Glenn Morris <rgm@gnu.org>
2965
2966 * config.in: Remove file.
2967
2968 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2969
2970 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2971 are now in src/globals.h.
2972 (syms_of_minibuf): Remove spurious & from previous change.
2973
2974 2011-03-20 Leo <sdl.web@gmail.com>
2975
2976 * minibuf.c (completing-read-function): New variable.
2977 (completing-read-default): Rename from completing-read.
2978 (completing-read): Call completing-read-function.
2979
2980 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2981
2982 * xfaces.c (Fx_load_color_file):
2983 Read color file from absolute filename (bug#8250).
2984
2985 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2986
2987 * makefile.w32-in: Update dependencies.
2988
2989 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2990
2991 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2992
2993 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2994
2995 Fix more problems found by GCC 4.5.2's static checks.
2996
2997 * process.c (make_serial_process_unwind, send_process_trap):
2998 (sigchld_handler): Now static.
2999
3000 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3001 That way, the code declares only the vars that it needs.
3002 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3003 * s/cygwin.h (PTY_ITERATION): Likewise.
3004 * s/darwin.h (PTY_ITERATION): Likewise.
3005 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3006
3007 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3008 * process.c (allocate_pty): Don't declare stb unless it's needed.
3009
3010 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3011 (CONSTANTLIM): Remove; unused.
3012 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3013 Define only if needed.
3014
3015 * unexelf.c (unexec): Name an expression,
3016 to avoid gcc -Wbad-function-cast warning.
3017 Use a different way to cause a compilation error if anyone uses
3018 n rather than nn, a way that does not involve shadowing.
3019 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3020
3021 * deps.mk (unexalpha.o): Remove; unused.
3022
3023 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3024 * unexec.h: New file.
3025 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3026 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3027 Depend on unexec.h.
3028 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3029 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3030 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3031 Change as necessary to match prototype in unexec.h.
3032
3033 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3034 shadowing.
3035 (back_comment, skip_chars): Mark vars as initialized.
3036
3037 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3038 Rename locals to avoid shadowing.
3039
3040 * lread.c (read1): Rewrite so as not to use empty "else".
3041 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3042
3043 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3044
3045 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3046 warning when compiling print.c.
3047
3048 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3049 instead of using an uninitialized var.
3050 (font_sort_entities): Mark var as initialized.
3051
3052 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3053
3054 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3055 pointers to constants.
3056 (font_parse_fcname): Remove unused vars.
3057 (font_delete_unmatched): Now static.
3058 (font_get_spec): Remove; unused.
3059 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3060 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3061 Rename or move locals to avoid shadowing.
3062
3063 * fns.c (require_nesting_list, require_unwind): Now static.
3064 (Ffillarray): Rename locals to avoid shadowing.
3065
3066 * floatfns.c (domain_error2): Define only if needed.
3067 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3068
3069 * alloc.c (mark_backtrace): Move decl from here ...
3070 * lisp.h: ... to here, so that it can be checked.
3071
3072 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3073 (Fdefvar): Rewrite so as not to use empty "else".
3074 (lisp_indirect_variable): Name an expression,
3075 to avoid gcc -Wbad-function-cast warning.
3076 (Fdefvar): Rename locals to avoid shadowing.
3077
3078 * callint.c (quotify_arg, quotify_args): Now static.
3079 (Fcall_interactively): Rename locals to avoid shadowing.
3080 Use const pointer when appropriate.
3081
3082 * lisp.h (get_system_name, get_operating_system_release):
3083 Move decls here, to check interfaces.
3084 * process.c (get_operating_system_release): Move decl to lisp.h.
3085 * xrdb.c (get_system_name): Likewise.
3086 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3087 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3088 some of which prompt warnings from gcc -Wbad-function-cast.
3089 (Fformat_time_string, Fencode_time, Finsert_char):
3090 (Ftranslate_region_internal, Fformat):
3091 Rename or remove local vars to avoid shadowing.
3092 (Ftranslate_region_internal): Mark var as initialized.
3093
3094 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3095 avoid shadowing.
3096
3097 * lisp.h (eassert): Check that the argument compiles, even if
3098 ENABLE_CHECKING is not defined.
3099
3100 * data.c (Findirect_variable): Name an expression, to avoid
3101 gcc -Wbad-function-cast warning.
3102 (default_value, arithcompare, arith_driver, arith_error): Now static.
3103 (store_symval_forwarding): Rename local to avoid shadowing.
3104 (Fmake_variable_buffer_local, Fmake_local_variable):
3105 Mark variables as initialized.
3106 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3107
3108 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3109 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3110 Rename locals to avoid shadowing.
3111 (mark_stack): Move local variables into the #ifdef region where
3112 they're used.
3113 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3114 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3115 needed otherwise.
3116 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3117 (GC_STRING_CHARS): Remove; not used.
3118 (Fmemory_limit): Cast sbrk's returned value to char *.
3119
3120 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3121 avoids undefined behavior in theory.
3122
3123 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3124
3125 Use functions, not macros, for up- and down-casing (Bug#8254).
3126 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3127 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3128 to use the following functions instead of these macros.
3129 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3130 EMACS_INT, since callers assume the returned value fits in int.
3131 (upcase1): Likewise, for UPCASE_TABLE.
3132 (uppercasep, lowercasep, upcase): New static inline functions.
3133 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3134 the race-condition problem in the old DOWNCASE.
3135
3136 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3137 Rename locals to avoid shadowing.
3138 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3139 (regex_compile, re_search_2, re_match_2_internal):
3140 Remove unused local vars.
3141 (FREE_VAR): Rewrite so as not to use empty "else",
3142 which gcc can warn about.
3143 (regex_compile, re_match_2_internal): Mark locals as initialized.
3144 (RETALLOC_IF): Define only if needed.
3145 (WORDCHAR_P): Likewise. This one is never needed, but is used
3146 only in a comment talking about a compiler bug, so put inside
3147 the #if 0 of that comment.
3148 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3149 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3150 Remove; unused.
3151
3152 * search.c (boyer_moore): Rename locals to avoid shadowing.
3153 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3154 (PREV_CHAR_BOUNDARY): Likewise.
3155
3156 * search.c (simple_search): Remove unused var.
3157
3158 * dired.c (compile_pattern): Move decl from here ...
3159 * lisp.h: ... to here, so that it can be checked.
3160 (struct re_registers): New forward decl.
3161
3162 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3163
3164 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3165 All uses changed.
3166 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3167 Rename locals to avoid shadowing.
3168 (Fvertical_motion): Mark locals as initialized.
3169
3170 * casefiddle.c (casify_object, casify_region): Now static.
3171 (casify_region): Mark local as initialized.
3172
3173 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3174
3175 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3176 New macros, so that the caller can use some names other than
3177 gcpro1, gcpro2, etc.
3178 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3179 of the new macros.
3180 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3181 argument, for consistency with GCPRO2_VAR, etc: it is now the
3182 prefix of the variable, not the variable itself. All uses
3183 changed.
3184 * dired.c (directory_files_internal, file_name_completion):
3185 Rename locals to avoid shadowing.
3186
3187 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3188 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3189 dired.c's scmp function, had undefined behavior.
3190 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3191 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3192 * buffer.h: ... to here, because these macros use current_buffer,
3193 and the new implementation with inline functions needs to have
3194 current_buffer in scope now, rather than later when the macros
3195 are used.
3196 (downcase, upcase1): New static inline functions.
3197 (DOWNCASE, UPCASE1): Reimplement using these functions.
3198 This avoids undefined behavior in expressions like
3199 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3200 from race conditions in accessing the global variables
3201 case_temp1 and case_temp2.
3202 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3203 * lisp.h (case_temp1, case_temp2): Remove their decls.
3204 * character.h (ASCII_CHAR_P): Move from here ...
3205 * lisp.h: ... to here, so that the inline functions mentioned
3206 above can use them.
3207
3208 * dired.c (directory_files_internal_unwind): Now static.
3209
3210 * fileio.c (file_name_as_directory, directory_file_name):
3211 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3212 Now static.
3213 (file_name_as_directory): Use const pointers when appropriate.
3214 (Fexpand_file_name): Likewise. In particular, newdir might
3215 point at constant storage, so make it a const pointer.
3216 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3217 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3218 signedness issues.
3219 (Fset_file_times, Finsert_file_contents, auto_save_error):
3220 Rename locals to avoid shadowing.
3221
3222 * minibuf.c (choose_minibuf_frame_1): Now static.
3223 (Ftry_completion, Fall_completions): Rename or remove locals
3224 to avoid shadowing.
3225
3226 * marker.c (bytepos_to_charpos): Remove; unused.
3227
3228 * lisp.h (verify_bytepos, count_markers): New decls,
3229 so that gcc does not warn that these functions aren't declared.
3230
3231 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3232 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3233 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3234 (copy_text): Remove unused local var.
3235
3236 * filelock.c (within_one_second): Now static.
3237 (lock_file_1): Rename local to avoid shadowing.
3238
3239 * buffer.c (fix_overlays_before): Mark locals as initialized.
3240 (fix_start_end_in_overlays): Likewise. This function should be
3241 simplified by using pointers-to-pointers, but that's a different
3242 matter.
3243 (switch_to_buffer_1): Now static.
3244 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3245 (report_overlay_modification): Rename locals to avoid shadowing.
3246
3247 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3248 Fix pointer signedness issue.
3249 (sys_subshell): Mark local as volatile if checking for lint,
3250 to suppress a gcc -Wclobbered warning that does not seem to be right.
3251 (MAXPATHLEN): Define only if needed.
3252
3253 * process.c (serial_open, serial_configure): Move decls from here ...
3254 * systty.h: ... to here, so that they can be checked.
3255
3256 * fns.c (get_random, seed_random): Move extern decls from here ...
3257 * lisp.h: ... to here, so that they can be checked.
3258
3259 * sysdep.c (reset_io): Now static.
3260 (wait_for_termination_signal): Remove; unused.
3261
3262 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3263 (copy_keymap_item, append_key, push_text_char_description):
3264 Now static.
3265 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3266 (DENSE_TABLE_SIZE): Remove; unused.
3267 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3268 (describe_map_tree):
3269 Rename locals to avoid shadowing.
3270
3271 * keyboard.c: Declare functions static if they are not used elsewhere.
3272 (echo_char, echo_dash, cmd_error, top_level_2):
3273 (poll_for_input, handle_async_input): Now static.
3274 (read_char, kbd_buffer_get_event, make_lispy_position):
3275 (make_lispy_event, make_lispy_movement, apply_modifiers):
3276 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3277 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3278 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3279 (read_key_sequence, read_char): Mark locals as initialized.
3280 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3281
3282 * keyboard.h (make_ctrl_char): New decl.
3283 (mark_kboards): Move decl here ...
3284 * alloc.c (mark_kboards): ... from here.
3285
3286 * lisp.h (force_auto_save_soon): New decl.
3287
3288 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3289 (DEFINE_DUMMY_FUNCTION): New macro.
3290 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3291 Use it.
3292 (main): Add casts to avoid warnings
3293 if GCC considers string literals to be constants.
3294
3295 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3296
3297 * dbusbind.c: Pointer signedness fixes.
3298 (xd_signature, xd_append_arg, xd_initialize):
3299 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3300 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3301 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3302 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3303
3304 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3305 if GCC considers string literals to be constants.
3306 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3307
3308 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3309
3310 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3311 (print_preprocess, print_object): New macro to fix last change.
3312
3313 * print.c (print_preprocess): Don't forget font objects.
3314
3315 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3316
3317 * emacs.c (USAGE3): Doc fixes.
3318
3319 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3320
3321 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3322 structure.
3323
3324 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * lisp.h (VWindow_system, Qfile_name_history):
3327 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3328 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3329 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3330
3331 * w32select.c: Don't #include "keyboard.h".
3332 (run_protected): Add extern declaration for waiting_for_input.
3333
3334 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3335 * w32console.c (detect_input_pending, read_input_pending)
3336 (encode_terminal_code):
3337 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3338 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3339 (w32_system_caret_y, Qfile_name_history):
3340 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3341 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3342 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3343 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3344 * w32proc.c (Qlocal, report_file_error):
3345 * w32term.c (Vwindow_system, updating_frame):
3346 * w32uniscribe.c (initialized, uniscribe_font_driver):
3347 Remove unneeded extern declarations.
3348
3349 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3350
3351 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3352
3353 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3354
3355 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3356 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3357 These macros can no longer be used for assignment.
3358
3359 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3360 Assign struct members directly, instead of using BUF_BEGV etc.
3361 (record_buffer_markers, fetch_buffer_markers): New functions for
3362 recording and fetching special buffer markers.
3363 (set_buffer_internal_1, set_buffer_temp): Use them.
3364
3365 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3366
3367 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3368
3369 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3370 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3371
3372 * xdisp.c (hscroll_window_tree):
3373 (reconsider_clip_changes): Use PT instead of BUF_PT.
3374
3375 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3376
3377 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3378 $(EMACS_ROOT)/lib/intprops.h.
3379
3380 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 Fix more problems found by GCC 4.5.2's static checks.
3383
3384 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3385 to unsigned char * to avoid compiler diagnostic.
3386 (xg_free_frame_widgets): Make it clear that a local variable is
3387 needed only if USE_GTK_TOOLTIP.
3388 (gdk_window_get_screen): Make it clear that this macro is needed
3389 only if USE_GTK_TOOLTIP.
3390 (int_gtk_range_get_value): New function, which avoids a diagnostic
3391 from gcc -Wbad-function-cast.
3392 (xg_set_toolkit_scroll_bar_thumb): Use it.
3393 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3394 diagnostic from gcc -Wbad-function-cast.
3395 (get_utf8_string, xg_get_file_with_chooser):
3396 Rename locals to avoid shadowing.
3397 (create_dialog): Move locals to avoid shadowing.
3398
3399 * xgselect.c (xg_select): Remove unused var.
3400
3401 * image.c (four_corners_best): Mark locals as initialized.
3402 (gif_load): Initialize transparent_p to zero (Bug#8238).
3403 Mark another local as initialized.
3404 (my_png_error, my_error_exit): Mark with NO_RETURN.
3405
3406 * image.c (clear_image_cache): Now static.
3407 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3408 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3409 (x_edge_detection): Remove unnecessary cast that
3410 gcc -Wbad-function-cast diagnoses.
3411 (gif_load): Fix pointer signedness.
3412 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3413 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3414
3415 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 Improve quality of tests for time stamp overflow.
3418 For example, without this patch (encode-time 0 0 0 1 1
3419 1152921504606846976) returns the obviously-bogus value (-948597
3420 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3421 reports time overflow. See
3422 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3423 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3424 * editfns.c: Include limits.h and intprops.h.
3425 (TIME_T_MIN, TIME_T_MAX): New macros.
3426 (time_overflow): Move earlier, to before first use.
3427 (hi_time, lo_time): New functions, for an accurate test for
3428 out-of-range times.
3429 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3430 (Fget_internal_run_time): Don't assume time_t fits in int.
3431 (make_time): Use list2 instead of Fcons twice.
3432 (Fdecode_time): More accurate test for out-of-range times.
3433 (check_tm_member): New function.
3434 (Fencode_time): Use it, to test for out-of-range times.
3435 (lisp_time_argument): Don't rely on undefined left-shift and
3436 right-shift behavior when checking for time stamp overflow.
3437
3438 * editfns.c (time_overflow): New function, refactoring common code.
3439 (Fformat_time_string, Fdecode_time, Fencode_time):
3440 (Fcurrent_time_string): Use it.
3441
3442 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3443 * dired.c (make_time): Move to ...
3444 * editfns.c (make_time): ... here.
3445 * systime.h: Note the move.
3446
3447 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3448
3449 * fringe.c (update_window_fringes): Remove unused variables.
3450
3451 * unexmacosx.c (copy_data_segment): Also copy __got section.
3452 (Bug#8223)
3453
3454 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3455
3456 * termcap.c [MSDOS]: Include "msdos.h".
3457 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3458 Constify `char *' arguments and their references according to
3459 prototypes in tparam.h.
3460
3461 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3462
3463 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3464 Adapt all references accordingly.
3465
3466 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3467
3468 2011-03-11 Tom Tromey <tromey@redhat.com>
3469
3470 * buffer.c (syms_of_buffer): Remove obsolete comment.
3471
3472 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3473
3474 * termhooks.h (encode_terminal_code): Declare prototype.
3475
3476 * msdos.c (encode_terminal_code): Don't declare prototype.
3477
3478 * term.c (encode_terminal_code): Now external again, used by
3479 w32console.c and msdos.c.
3480
3481 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3482 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3483
3484 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 Fix some minor problems found by GCC 4.5.2's static checks.
3487
3488 * fringe.c (update_window_fringes): Mark locals as initialized
3489 (Bug#8227).
3490 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3491
3492 * alloc.c (mark_fringe_data): Move decl from here ...
3493 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3494 to check its interface.
3495 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3496
3497 * fontset.c (free_realized_fontset): Now static.
3498 (Fset_fontset_font): Rename local to avoid shadowing.
3499 (fontset_font): Mark local as initialized.
3500 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3501
3502 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3503
3504 * xselect.c (x_disown_buffer_selections): Remove; not used.
3505 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3506 (x_own_selection, Fx_disown_selection_internal): Rename locals
3507 to avoid shadowing.
3508 (x_handle_dnd_message): Remove local to avoid shadowing.
3509
3510 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3511 so that the caller can use some name other than gcpro1.
3512 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3513 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3514 (Fx_backspace_delete_keys_p):
3515 Use them to avoid shadowing, and rename vars to avoid shadowing.
3516 (x_decode_color, x_set_name, x_window): Now static.
3517 (Fx_create_frame): Add braces to silence GCC warning.
3518 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3519 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3520 Remove unused locals.
3521 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3522 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3523 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3524 macros.
3525
3526 * xterm.h (x_mouse_leave): New decl.
3527
3528 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3529 Remove unused functions.
3530 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3531 (x_calc_absolute_position): Now static.
3532 (XTread_socket): Don't define label "out" unless it's used.
3533 Don't declare local "event" unless it's used.
3534 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3535 unless they are used.
3536 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3537 (x_fatal_error_signal): Remove; not used.
3538 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3539 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3540 (x_error_catcher, x_connection_closed, x_error_handler):
3541 (x_error_quitter, xembed_send_message, x_iconify_frame):
3542 (my_log_handler): Rename locals to avoid shadowing.
3543 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3544 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3545
3546 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3547 Rename or move locals to avoid shadowing.
3548 (tty_defined_color, merge_face_heights): Now static.
3549 (free_realized_faces_for_fontset): Remove; not used.
3550 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3551 does not deduce is never used uninitialized.
3552 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3553 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3554
3555 * terminal.c (store_terminal_param): Now static.
3556
3557 * xmenu.c (menu_highlight_callback): Now static.
3558 (set_frame_menubar): Remove unused local.
3559 (xmenu_show): Rename parameter to avoid shadowing.
3560 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3561 since they might point to immutable storage.
3562 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3563 since it's unused otherwise.
3564
3565 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3566 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3567 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3568 avoids a gcc -Wuninitialized diagnostic.
3569 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3570 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3571 does not deduce are never used uninitialized.
3572
3573 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3574
3575 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3576 * window.c (window_loop, size_window):
3577 (run_window_configuration_change_hook, enlarge_window): Likewise.
3578
3579 * window.c (display_buffer): Now static.
3580 (size_window): Mark variables that gcc -Wuninitialized
3581 does not deduce are never used uninitialized.
3582 * window.h (check_all_windows): New decl, to forestall
3583 gcc -Wmissing-prototypes diagnostic.
3584 * dispextern.h (bidi_dump_cached_states): Likewise.
3585
3586 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3587 shadowing.
3588 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3589 Include <limits.h>.
3590 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3591 and to avoid gcc -Wuninitialized warning.
3592 (load_charset_map): Mark variables that gcc -Wuninitialized
3593 does not deduce are never used uninitialized.
3594 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3595
3596 * coding.c (coding_set_source, coding_set_destination):
3597 Use "else { /* comment */ }" rather than "else /* comment */;"
3598 for clarity, and to avoid gcc -Wempty-body warning.
3599 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3600 a block, when the outer 'i' will do.
3601 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3602 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3603 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3604 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3605 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3606 Rename locals to avoid shadowing.
3607 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3608 * coding.c (emacs_mule_char, encode_invocation_designation):
3609 Now static, since they're not used elsewhere.
3610 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3611 (decode_coding_object, encode_coding_object, detect_coding_system):
3612 (decode_coding_emacs_mule): Mark variables that gcc
3613 -Wuninitialized does not deduce are never used uninitialized.
3614 (detect_coding_iso_2022): Initialize a local variable that might
3615 be used uninitialized. Leave a FIXME because it's not clear that
3616 this initialization is needed. (Bug#8211)
3617 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3618 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3619 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3620 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3621 Remove unused macros.
3622
3623 * category.c (hash_get_category_set): Remove unused local var.
3624 (copy_category_table): Now static, since it's not used elsewhere.
3625 * character.c (string_count_byte8): Likewise.
3626
3627 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3628 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3629
3630 * chartab.c (copy_sub_char_table): Now static, since it's not used
3631 elsewhere.
3632 (sub_char_table_ref_and_range, char_table_ref_and_range):
3633 Rename locals to avoid shadowing.
3634 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3635
3636 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3637 (BIDI_BOB): Remove unused macro.
3638
3639 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3640 deduce are never used uninitialized.
3641 * term.c (encode_terminal_code): Likewise.
3642
3643 * term.c (encode_terminal_code): Now static. Remove unused local.
3644
3645 * tparam.h: New file.
3646 * term.c, tparam.h: Include it.
3647 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3648 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3649 Move these decls to tparam.h, and make them agree with what
3650 is actually in tparam.c. The previous trick of using incompatible
3651 decls in different modules does not conform to the C standard.
3652 All callers of tparam changed to use tparam's actual API.
3653 * tparam.c (tparam1, tparam, tgoto):
3654 Use const pointers where appropriate.
3655
3656 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3657 * cm.h (struct cm): Likewise.
3658 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3659 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3660 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3661 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3662 (turn_on_face, init_tty): Likewise.
3663 * termchar.h (struct tty_display_info): Likewise.
3664
3665 * term.c (term_mouse_position): Rename local to avoid shadowing.
3666
3667 * alloc.c (mark_ttys): Move decl from here ...
3668 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3669
3670 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3671
3672 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3673
3674 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3675
3676 * search.c (compile_pattern_1): Remove argument regp, unused since
3677 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3678 (compile_pattern): Don't pass it.
3679
3680 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3681
3682 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3683 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3684 for ! HAVE_GTK3.
3685 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3686
3687 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3688
3689 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3690 gdk_window_get_screen, gdk_window_get_geometry,
3691 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3692 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3693 (xg_get_pixbuf_from_pixmap): New function.
3694 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3695 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3696 Call xg_get_pixbuf_from_pixmap instead of
3697 gdk_pixbuf_get_from_drawable.
3698 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3699 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3700 (xg_check_special_colors): Use GtkStyleContext and its functions
3701 for HAVE_GTK3.
3702 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3703 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3704 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3705 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3706 Call gtk_widget_get_preferred_size.
3707 (xg_frame_resized): gdk_window_get_geometry only takes 5
3708 parameters.
3709 (xg_win_to_widget, xg_event_is_for_menubar):
3710 Call gdk_x11_window_lookup_for_display.
3711 (xg_set_widget_bg): New function.
3712 (delete_cb): New function.
3713 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3714 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3715 (xg_set_background_color): Call xg_set_widget_bg.
3716 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3717 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3718 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3719 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3720 if ! HAVE_GTK3.
3721 (update_frame_tool_bar): Call gtk_widget_hide.
3722 (xg_initialize): Use GDK_KEY_g.
3723
3724 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3725 if ! HAVE_GTK3
3726 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3727
3728 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3729 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3730 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3731
3732 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * w32xfns.c (select_palette): Check success of RealizePalette against
3735 GDI_ERROR, not zero.
3736
3737 See ChangeLog.11 for earlier changes.
3738
3739 ;; Local Variables:
3740 ;; coding: utf-8
3741 ;; End:
3742
3743 Copyright (C) 2011 Free Software Foundation, Inc.
3744
3745 This file is part of GNU Emacs.
3746
3747 GNU Emacs is free software: you can redistribute it and/or modify
3748 it under the terms of the GNU General Public License as published by
3749 the Free Software Foundation, either version 3 of the License, or
3750 (at your option) any later version.
3751
3752 GNU Emacs is distributed in the hope that it will be useful,
3753 but WITHOUT ANY WARRANTY; without even the implied warranty of
3754 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3755 GNU General Public License for more details.
3756
3757 You should have received a copy of the GNU General Public License
3758 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.