1 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3 * editfns.c (Fformat): Correctly handle text properties on "%%".
5 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7 * xterm.c (x_draw_composite_glyph_string_foreground):
8 * w32term.c (x_draw_composite_glyph_string_foreground):
9 * term.c (encode_terminal_code):
10 * composite.c (composition_update_it, get_composition_id):
11 * xdisp.c (get_next_display_element)
12 (fill_composite_glyph_string): Add comments about special meaning
13 of TAB characters in a composition.
15 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
17 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
18 This occurs when processing a multibyte format.
19 Problem reported by Wolfgang Jenker.
21 2011-09-15 Johan Bockgård <bojohan@gnu.org>
23 * xdisp.c (try_cursor_movement): Only check for exact match if
24 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
26 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
28 Remove unused external symbols.
29 * dispextern.h (calc_pixel_width_or_height): Remove decl.
30 * xdisp.c (calc_pixel_width_or_height): Now static.
31 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
32 * indent.c (check_display_width):
33 * w32term.c: Fix comment to match code.
34 * xterm.c, xterm.h (x_catching_errors): Remove.
36 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
38 * xselect.c: Use signed conversions more consistently (Bug#9498).
39 (selection_data_to_lisp_data): Assume incoming selection data are
40 signed integers, not unsigned. This is to be consistent with
41 outgoing selection data, which was modified to use signed integers
42 in as part of the fix to Bug#9196 in response to Jan D.'s comment
43 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
44 expects long, not unsigned long.
46 2011-09-14 Eli Zaretskii <eliz@gnu.org>
48 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
49 computation of loop end. Reported by Johan Bockgård
52 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
54 * frame.c (Fother_visible_frames_p): Function deleted.
56 2011-09-12 Eli Zaretskii <eliz@gnu.org>
58 * indent.c (compute_motion): Process display vector front to back
59 rather than the other way around. (Bug#2496)
61 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
63 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
65 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
67 * minibuf.c (Fread_from_minibuffer): Doc fix.
69 2011-09-11 Eli Zaretskii <eliz@gnu.org>
71 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
72 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
74 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
76 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
77 value for non-existent files.
79 2011-09-11 Eli Zaretskii <eliz@gnu.org>
81 * fileio.c (Finsert_file_contents): If the file cannot be opened,
82 set its "size" to -1. This will set the modtime_size field of
83 the corresponding buffer to -1, which is what
84 verify-visited-file-modtime expects for files that do not exist.
87 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
89 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
91 * lisp.h: ... from here. push_key_description is no longer
92 defined in keyboard.c, so its declaration should not be in
93 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
94 logically belongs with push_key_description.
96 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
98 * buffer.h: Include <sys/types.h> instead of <time.h>.
99 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
100 Problem reported by Herbert J. Skuhra.
102 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
104 * xml.c (parse_region): Make the parsing work for
105 non-comment-starting XML files again (bug#9144).
107 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
109 * image.c (gif_load): Fix calculation of bottom and right corner.
112 2011-09-10 Eli Zaretskii <eliz@gnu.org>
114 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
115 redisplay in small windows.
117 2011-09-09 Eli Zaretskii <eliz@gnu.org>
119 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
121 2011-09-08 Martin Rudalics <rudalics@gmx.at>
123 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
124 Operate on live windows only.
126 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
128 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
130 2011-09-07 Eli Zaretskii <eliz@gnu.org>
132 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
133 only under bidi iteration.
135 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
137 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
139 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
141 isnan: Fix porting problem to Solaris 10 with bundled gcc.
142 Without this fix, the command to link temacs failed due to an
143 undefined symbol __builtin_isnan. This is because
144 /usr/include/iso/math_c99.h #defines isnan(x) to
145 __builtin_isnan(x), but the bundled gcc, which identifies itself
146 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
148 * floatfns.c (isnan): #undef, and then #define to a clone of
150 (Fisnan): Always define, since it's always available now.
151 (syms_of_floatfns): Always define isnan at the Lisp level.
153 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
155 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
157 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
159 * fileio.c: Fix bugs with large file offsets (Bug#9428).
160 The previous code assumed that file offsets (off_t values) fit in
161 EMACS_INT variables, which is not true on typical 32-bit hosts.
162 The code messed up by falsely reporting buffer overflow in cases
163 such as (insert-file-contents "big" nil 1 2) into an empty buffer
164 when "big" contains more than 2**29 bytes, even though this
165 inserts just one byte and does not overflow the buffer.
166 (Finsert_file_contents): Store file offsets as off_t
167 values, not as EMACS_INT values. Check for overflow when
168 converting between EMACS_INT and off_t. When checking for
169 buffer overflow or for overlap, take the offsets into account.
170 Don't use EMACS_INT for small values where int suffices.
171 When checking for overlap, fix a typo: ZV was used where
172 ZV_BYTE was intended.
173 (Fwrite_region): Don't assume off_t fits into 'long'.
174 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
176 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
178 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
180 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
182 sprintf-related integer and memory overflow issues (Bug#9412).
184 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
185 (esprintf, exprintf, evxprintf): New functions.
186 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
187 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
188 (modify_event_symbol): Do not assume that the length of
189 name_alist_or_stem is safe to alloca and fits in int.
190 (Fexecute_extended_command): Likewise for function name and binding.
191 (Frecursion_depth): Wrap around reliably on integer overflow.
192 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
193 since some callers pass EMACS_INT values.
194 (Fsingle_key_description): Don't crash if symbol name contains more
195 than MAX_ALLOCA bytes.
196 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
197 (get_minibuffer): Arg is now EMACS_INT, not int.
198 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
199 (esprintf, exprintf, evxprintf): New decls.
200 * window.h (command_loop_level, minibuf_level): Reflect API changes.
202 * dbusbind.c (signature_cat): New function.
203 (xd_signature, Fdbus_register_signal):
204 Do not overrun buffer; instead, report string overflow.
206 * dispnew.c (add_window_display_history): Don't overrun buffer.
207 Truncate instead; this is OK since it's just a log.
209 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
210 even if the time zone offset is outlandishly large.
211 Don't mishandle offset == INT_MIN.
213 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
214 when creating daemon; the previous buffer-overflow check was incorrect.
216 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
217 which has the guts of the old verror function.
219 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
220 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
222 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
223 (font_unparse_xlfd): Don't blindly alloca long strings.
224 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
225 fits in int, when using sprintf. Use single snprintf to count
226 length of string rather than counting it via multiple sprintfs;
227 that's simpler and more reliable.
228 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
229 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
230 sprintf, in case result does not fit in int.
232 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
233 (fontset_from_font): Print it.
235 * frame.c (tty_frame_count): Now printmax_t, not int.
236 (make_terminal_frame, set_term_frame_name): Print it.
237 (x_report_frame_params): In X, window IDs are unsigned long,
238 not signed long, so print them as unsigned.
239 (validate_x_resource_name): Check for implausibly long names,
240 and don't assume name length fits in 'int'.
241 (x_get_resource_string): Don't blindly alloca invocation name;
242 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
245 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
246 (xg_check_special_colors, xg_set_geometry):
247 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
249 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
250 Use esprintf, not sprintf, in case result does not fit in int.
252 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
253 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
254 it as a large positive number.
255 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
256 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
258 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
259 in case result does not fit in int.
261 * print.c (float_to_string): Detect width overflow more reliably.
262 (print_object): Make sprintf buffer a bit bigger, to avoid potential
263 buffer overrun. Don't assume list length fits in 'int'. Treat
264 print length of 0 as 0, not as infinity; to be consistent with other
265 uses of print length in this function. Don't overflow print length
266 index. Don't assume hash table size fits in 'long', or that
267 vectorlike size fits in 'unsigned long'.
269 * process.c (make_process): Use printmax_t, not int, to format
270 process-name gensyms.
272 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
274 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
275 to avoid potential buffer overrun.
277 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
278 if X resource line is longer than 512 bytes.
280 * xfns.c (x_window): Make sprintf buffer a bit bigger
281 to avoid potential buffer overrun.
283 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
285 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
287 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
289 Integer overflow fixes for scrolling, etc.
290 Without these, Emacs silently mishandles large integers sometimes.
291 For example, "C-u 4294967297 M-x recenter" was treated as if
292 it were "C-u 1 M-x recenter" on a typical 64-bit host.
294 * xdisp.c (try_window_id): Check Emacs fixnum range before
297 * window.c (window_scroll_line_based, Frecenter):
298 Check that an Emacs fixnum is in range before assigning it to 'int'.
299 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
300 values converted from Emacs fixnums.
301 (Frecenter): Don't wrap around a line count if it is out of 'int'
302 range; instead, treat it as an extreme value.
303 (Fset_window_configuration, compare_window_configurations):
304 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
306 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
307 that can exceed INT_MAX. Check that EMACS_INT value is in range
308 before assigning it to the (possibly-narrower) index.
309 (match_limit): Don't assume that a fixnum can fit in 'int'.
311 * print.c (print_object): Use ptrdiff_t, not int, for index that can
314 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
315 (Fvertical_motion): Don't wrap around LINES values that don't fit
316 in 'int'. Instead, treat them as extreme values. This is good
317 enough for windows, which can't have more than INT_MAX lines anyway.
319 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
321 * Require libxml/parser.h to avoid compilation warning.
323 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
325 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
326 since this reportedly can destroy thread storage.
328 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
330 * syntax.c (find_defun_start): Update all cache variables if
331 exiting early (Bug#9401).
333 2011-08-30 Eli Zaretskii <eliz@gnu.org>
335 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
337 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
338 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
339 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
341 * term.c (tty_append_glyph): New function.
342 (produce_stretch_glyph): Static function and its prototype deleted.
344 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
347 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
349 * image.c (parse_image_spec): Check for nonnegative, not for positive,
350 when checking :margin (Bug#9390).
351 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
352 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
353 so that the name doesn't mislead. All uses changed.
355 2011-08-28 Johan Bockgård <bojohan@gnu.org>
357 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
360 2011-08-27 Eli Zaretskii <eliz@gnu.org>
362 * xdisp.c (move_it_to): Don't bail out early when reaching
363 position beyond to_charpos, if we are scanning backwards.
364 (move_it_vertically_backward): When DY == 0, make sure we get to
365 the first character in the line after the newline.
367 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
369 * ccl.c: Improve and simplify overflow checking (Bug#9196).
370 (ccl_driver): Do not generate an out-of-range pointer.
371 (Fccl_execute_on_string): Remove unnecessary check for
372 integer overflow, noted by Stefan Monnier in
373 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
374 Remove a FIXME that didn't need fixing.
375 Simplify the newly-introduced buffer reallocation code.
377 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
379 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
381 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
383 Integer and memory overflow issues (Bug#9196).
385 * doc.c (get_doc_string): Rework so that
386 get_doc_string_buffer_size is the actual buffer size, rather than
387 being 1 less than the actual buffer size; this makes xpalloc more
390 * image.c (x_allocate_bitmap_record, cache_image):
391 * xselect.c (Fx_register_dnd_atom):
392 Simplify previous changes by using xpalloc.
394 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
395 since either will do and ptrdiff_t is convenient with xpalloc.
397 * charset.c (charset_table_size)
398 (struct charset_sort_data.priority): Now ptrdiff_t.
399 (charset_compare): Don't overflow if priorities differ greatly.
400 (Fsort_charsets): Don't assume list length fits in int.
401 Check for size-calculation overflow when allocating sort data.
402 (syms_of_charset): Allocate an initial charset table that is
403 just under 64 KiB, to avoid problems with glibc malloc and mmap.
405 * cmds.c (internal_self_insert): Check for size-calculation overflow.
407 * composite.h (struct composition.glyph_len): Now int, not unsigned.
408 The actual value is always <= INT_MAX, and leaving it unsigned made
409 overflow checking harder.
411 * dispextern.h (struct glyph_matrix.rows_allocated)
412 (struct face_cache.size): Now ptrdiff_t, for convenience in use
413 with xpalloc. The values are still always <= INT_MAX.
415 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
417 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
418 (SAFE_NALLOCA): New macro.
420 * region-cache.c (struct boundary.pos, find_cache_boundary)
421 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
422 (set_cache_region, invalidate_region_cache)
423 (revalidate_region_cache, know_region_cache, region_cache_forward)
424 (region_cache_backward, pp_cache):
425 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
426 so that ptrdiff_t * can be passed to xpalloc.
427 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
428 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
429 (pp_cache): Don't assume cache_len fits in int.
430 * region-cache.h: Adjust extern decls to match.
432 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
433 EMACS_INT, since either will do, for xpalloc.
435 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
436 (xnmalloc, xnrealloc, xpalloc): New functions.
438 * bidi.c (bidi_shelve_header_size): New constant.
439 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
440 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
442 * bidi.c (bidi_cache_shrink):
443 * buffer.c (overlays_at, overlays_in, record_overlay_string)
445 Don't update size of array until after memory allocation succeeds,
446 because xmalloc/xrealloc may not return.
447 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
448 now that we have proper integer overflow checking.
449 (record_overlay_string, overlay_strings): Catch overflows when
450 calculating size of overlay_str_buf.
452 * callproc.c (Fcall_process): Check for size overflow when
453 calculating size of args2.
454 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
455 Normally we prefer signed values, but sticking with ptrdiff_t would
456 require adding more-complicated checks.
458 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
459 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
460 Redo buffer-overflow calculations to avoid integer overflow.
461 Add a FIXME comment where memory seems to be over-allocated.
463 * character.c (Fstring): Check for size-calculation overflow.
465 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
466 unnecessary integer overflow. Check for size overflow.
467 (encode_coding_object): Don't update size until xmalloc succeeds.
469 * composite.c (get_composition_id): Check for overflow in glyph
472 Integer and memory overflow fixes for display code.
473 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
474 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
475 (scrolling_window): Check for overflow in size calculations.
476 (line_draw_cost, realloc_glyph_pool, add_row_entry):
477 Don't assume glyph table len fits in int.
478 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
479 (row_table_size): Now ptrdiff_t, not int.
480 (scrolling_window): Avoid overflow in size calculations.
481 Don't update size until allocation succeeds.
482 * fns.c (concat): Check for overflow in size calculations.
483 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
484 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
485 (NEXT_ALMOST_PRIME_LIMIT): New constant.
487 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
488 (get_doc_string): Check for size calculation overflow.
489 Don't update size until allocation succeeds.
490 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
491 EMACS_INT, where ptrdiff_t will do.
492 (Fsubstitute_command_keys): Check for string overflow.
494 * editfns.c (set_time_zone_rule): Don't assume environment length
496 (message_length): Now ptrdiff_t, not int.
497 (Fmessage_box): Don't update size until allocation succeeds.
498 Don't assume message length fits in int.
499 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
501 * emacs.c (main): Do not reallocate argv, since there is a null at
502 the end that can be overwritten, and this way there's no need to
503 worry about size-calculation overflow.
504 (sort_args): Check for size-calculation overflow.
506 * eval.c (init_eval_once, grow_specpdl): Don't update size until
508 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
510 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
511 (x_set_scroll_bar_width, x_figure_window_size):
512 Check for integer overflow.
513 (x_set_alpha): Do not assume XINT fits in int.
515 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
516 This is for the members text_lines, text_cols, total_lines, total_cols,
517 where the system imposes an 'int' limit.
519 * fringe.c (Fdefine_fringe_bitmap):
520 Don't update size until alloc works.
522 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
523 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
525 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
526 Check for size-calculation overflow.
527 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
528 do, as we prefer signed integers.
529 (id_to_widget.max_size, id_to_widget.used)
530 (xg_store_widget_in_map, xg_remove_widget_from_map)
531 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
532 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
533 Use and return ptrdiff_t, not int.
534 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
535 * gtkutil.h: Change prototypes to match the above.
537 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
538 are duplicate now that they've been promoted to lisp.h.
539 (x_allocate_bitmap_record, x_alloc_image_color)
540 (make_image_cache, cache_image, xpm_load):
541 Don't update size until alloc is done.
542 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
544 Check for size calculation overflow.
545 (ct_colors_allocated_max): New constant.
546 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
549 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
550 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
551 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
552 Use ptrdiff_t, not int, to count maps.
553 (read_char_minibuf_menu_prompt): Check for overflow in size
554 calculations. Don't update size until allocation succeeds. Redo
555 calculations to avoid overflow.
556 * keyboard.h: Change prototypes to match the above.
558 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
560 (current_minor_maps): Check for size calculation overflow.
561 * keymap.h: Change prototypes to match the above.
563 * lread.c (read1, init_obarray): Don't update size until alloc done.
565 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
566 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
568 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
569 Now ptrdiff_t, not int.
570 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
571 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
573 * process.c (Fnetwork_interface_list): Check for overflow
576 * region-cache.c (move_cache_gap): Check for size calculation overflow.
578 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
579 overflow. Don't bother calling xmalloc when xrealloc will do.
581 * search.c (Freplace_match): Check for size calculation overflow.
582 (Fset_match_data): Don't assume list lengths fit in 'int'.
584 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
585 for command line length. Do not attempt to address one before the
586 beginning of an array, as that's not portable.
588 * term.c (max_frame_lines): Remove; unused.
589 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
591 (encode_terminal_code, calculate_costs): Check for size
592 calculation overflow.
593 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
594 table lengths and related sizes. Don't update size until alloc
595 done. Redo calculations to avoid overflow.
596 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
598 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
599 subtracting pointers.
600 (gobble_line): Check for overflow more carefully. Don't update size
603 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
604 Don't update size until alloc done.
605 Redo size calculations to avoid overflow.
606 Check for size calculation overflow.
607 (main) [DEBUG]: Fix typo in invoking tparam1.
609 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
610 Use ptrdiff_t, not int, for sizes.
611 (store_mode_line_noprop_char): Don't update size until alloc done.
613 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
614 Use ptrdiff_t, not int, for sizes.
615 (Finternal_make_lisp_face, cache_face):
616 Check for size calculation overflow.
617 (cache_face): Treat size calculation overflows as if they were
618 memory exhaustion (the usual treatment), rather than aborting.
620 * xfns.c (x_encode_text, x_set_name_internal)
621 (Fx_change_window_property): Use ptrdiff_t, not int, to count
622 sizes, since they can exceed INT_MAX in size. Check for size
623 calculation overflow.
625 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
626 (xg_select): Check for size calculation overflow.
627 Don't update size until alloc done.
629 * xrdb.c (get_environ_db): Don't assume path length fits in int,
630 as sprintf is limited to int lengths.
632 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
633 (X_LONG_MIN): New macros.
634 Use them to make the following changes clearer.
635 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
636 This change doesn't affect the value now, but it may help remind
637 future maintainers not to raise the value too much later.
638 (SELECTION_QUANTUM): Remove, replacing with ...
639 (selection_quantum): ... new function, which avoids overflow.
641 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
642 assumption that selection length fits in 'int'.
643 (x_reply_selection_request, x_handle_selection_request)
644 (x_get_window_property, receive_incremental_selection)
645 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
646 (lisp_data_to_selection_data, clean_local_selection_data):
647 Use ptrdiff_t, not int, to record length of selection.
648 (x_reply_selection_request, x_get_window_property)
649 (receive_incremental_selection, x_property_data_to_lisp):
650 Redo calculations to avoid overflow.
651 (x_reply_selection_request): When sending hint, ceiling it at
652 X_LONG_MAX rather than relying on wraparound overflow to send
654 (x_get_window_property, receive_incremental_selection)
655 (lisp_data_to_selection_data, x_property_data_to_lisp):
656 Check for size-calculation overflow.
657 (x_get_window_property, receive_incremental_selection)
658 (lisp_data_to_selection_data, Fx_register_dnd_atom):
659 Don't store size until memory allocation succeeds.
660 (x_get_window_property): Plug memory leak on memory exhaustion.
661 Don't double-block input; malloc is safe here. Don't assume 2**34
662 - 4 fits in unsigned long. Add an xassert to check
663 XGetWindowProperty overflow. Be more careful about overflow
664 calculations, and distinguish size from memory overflow better.
665 (receive_incremental_selection): When tracing, don't assume
666 unsigned int is less than INT_MAX.
667 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
668 harmful) conversions of unsigned short to int.
669 (lisp_data_to_selection_data): Don't assume that integers
670 in the range -65535 through -1 fit in an X unsigned short.
671 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
672 result parameters unless successful. Rely on cons_to_unsigned
673 to report problems with elements; the old code wasn't right anyway.
674 (x_check_property_data): Check for int overflow; we cannot use
675 a wider type due to X limits.
676 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
678 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
680 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
681 (x_term_init): Check for size calculation overflow.
682 (x_color_cells): Don't store size until memory allocation succeeds.
683 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
684 Don't assume alloca size is less than MAX_ALLOCA.
685 (x_term_init): Don't assume length fits in int (sprintf is limited
688 Use ptrdiff_t for composition IDs.
689 * character.c (lisp_string_width):
690 * composite.c (composition_table_size, n_compositions)
691 (get_composition_id, composition_gstring_from_id):
692 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
693 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
694 * window.c (Frecenter):
695 Use ptrdiff_t, not int, for composition IDs.
696 * composite.c (get_composition_id): Check for integer overflow.
697 * composite.h: Adjust prototypes to match the above changes.
699 Use ptrdiff_t for hash table indexes.
700 * category.c (hash_get_category_set):
701 * ccl.c (ccl_driver):
702 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
703 * coding.c (coding_system_charset_list, detect_coding_system):
704 * coding.h (struct coding_system.id):
705 * composite.c (get_composition_id, gstring_lookup_cache):
706 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
707 * image.c (xpm_get_color_table_h):
708 * lisp.h (hash_lookup, hash_put):
709 * minibuf.c (Ftest_completion):
710 Use ptrdiff_t for hash table indexes, not int (which is too
711 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
712 32-bit --with-wide-int hosts).
714 * charset.c (Fdefine_charset_internal): Check for integer overflow.
715 Add a FIXME comment about memory leaks.
716 (syms_of_charset): Don't assume xmalloc returns.
718 Don't assume that stated character widths fit in int.
719 * character.c (Fchar_width, c_string_width, lisp_string_width):
720 * character.h (CHAR_WIDTH):
721 * indent.c (MULTIBYTE_BYTES_WIDTH):
722 Use sanitize_char_width to avoid undefined and/or bad behavior
723 with outlandish widths.
724 * character.h (sanitize_tab_width): Renamed from sanitize_width,
725 now that we have two such functions. All uses changed.
726 (sanitize_char_width): New inline function.
728 Don't assume that tab-width fits in int.
729 * character.h (sanitize_width): New inline function.
730 (SANE_TAB_WIDTH): New macro.
731 (ASCII_CHAR_WIDTH): Use it.
732 * indent.c (sane_tab_width): Remove. All uses replaced by
733 SANE_TAB_WIDTH (current_buffer).
734 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
736 * fileio.c: Integer overflow issues with file modes.
737 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
739 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
740 Remove unreachable code.
741 (read_hex, load_charset_map_from_file): Check for integer overflow.
743 * xterm.c: don't go over XClientMessageEvent limit
744 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
745 (x_send_scroll_bar_event): Likewise. Check that the size does not
746 exceed limits imposed by XClientMessageEvent, as well as the usual
747 ptrdiff_t and size_t limits.
749 * keyboard.c: Overflow, signedness and related fixes.
750 (make_lispy_movement): Use same integer type in forward decl
751 that is used in the definition.
752 (read_key_sequence, keyremap_step):
753 Change bufsize argument back to int, undoing my 2011-03-30 change.
754 We prefer signed types, and int is wide enough here.
755 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
756 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
757 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
758 length, not size_t. Use ptrdiff_t for index, not int.
759 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
760 possibility of integer overflow.
762 Overflow, signedness and related fixes for images.
764 * dispextern.h (struct it.stack[0].u.image.image_id)
765 (struct_it.image_id, struct image.id, struct image_cache.size)
766 (struct image_cache.used, struct image_cache.ref_count):
767 * gtkutil.c (update_frame_tool_bar):
768 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
769 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
770 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
771 * nsmenu.m (update_frame_tool_bar):
772 * xdisp.c (calc_pixel_width_or_height):
773 * xfns.c (image_cache_refcount):
774 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
775 on typical 64-bit hosts.
777 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
778 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
779 Omit unnecessary casts to int.
780 (parse_image_spec): Check that integers fall into 'int' range
781 when the callers expect that.
782 (image_ascent): Redo ascent calculation to avoid int overflow.
783 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
784 (lookup_image): Remove unnecessary tests.
785 (xbm_image_p): Locals are now of int, not EMACS_INT,
786 since parse_image_check makes sure they fit into int.
787 (png_load, gif_load, svg_load_image):
788 Prefer int to unsigned where either will do.
789 (tiff_handler): New function, combining the cores of the
790 old tiff_error_handler and tiff_warning_handler. This
791 function is rewritten to use vsnprintf and thereby avoid
792 stack buffer overflows. It uses only the features of vsnprintf
793 that are common to both POSIX and native Microsoft.
794 (tiff_error_handler, tiff_warning_handler): Use it.
795 (tiff_load, gif_load, imagemagick_load_image):
796 Don't assume :index value fits in 'int'.
797 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
798 (imagemagick_load_image): Check that crop parameters fit into
799 the integer types that MagickCropImage accepts. Don't assume
800 Vimagemagick_render_type has a nonnegative value. Don't assume
801 size_t fits in 'long'.
802 (gs_load): Use printmax_t to print the widest integers possible.
803 Check for integer overflow when computing image height and width.
805 2011-08-26 Eli Zaretskii <eliz@gnu.org>
807 * xdisp.c (redisplay_window): Don't force window start if point
808 will be invisible in the resulting window. (Bug#9324)
810 2011-08-25 Eli Zaretskii <eliz@gnu.org>
812 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
813 the display spec is of the form `(space ...)'.
814 (handle_display_spec): Return the value returned by
815 handle_single_display_spec, not just 1 or zero.
816 (handle_single_display_spec): If the display spec is of the form
817 `(space ...)', and specifies display in the text area, return 2
819 (try_cursor_movement): Check for the need to scroll more
820 accurately, and prefer exact match for point under bidi. Don't
821 advance `row' beyond the last row of the window.
823 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
824 into disp_prop; all users changed.
826 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
827 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
828 for the text covered by the display property.
830 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
832 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
833 Change return value to nil.
834 (Frecord_buffer): Delete unused function.
836 2011-08-24 Eli Zaretskii <eliz@gnu.org>
838 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
839 buffers, return left-to-right.
840 (set_cursor_from_row): Consider candidate row a win if its glyph
841 represents a newline and point is on that newline. Fixes cursor
842 positioning on the newline at EOL of R2L text within L2R
843 paragraph, and vice versa.
844 (try_cursor_movement): Check continued rows, in addition to
845 continuation rows. Fixes unwarranted scroll when point enters a
846 continued line of R2L text within an L2R paragraph, or vice versa.
847 (cursor_row_p): Consider the case of point being equal to
848 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
849 from the end of a short line to the beginning of a continued line
850 of R2L text within L2R paragraph.
851 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
854 * bidi.c (bidi_check_type): Use xassert.
855 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
858 2011-08-23 Eli Zaretskii <eliz@gnu.org>
860 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
863 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
865 * nsfont.m (ns_otf_to_script): Fix typo.
867 2011-08-22 Kenichi Handa <handa@m17n.org>
869 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
870 extra slot even if the purpose is char-code-property-table.
872 2011-08-23 Eli Zaretskii <eliz@gnu.org>
874 * xdisp.c (redisplay_window): When computing centering_position,
875 account for the height of the header line. (Bug#8874)
877 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
878 instead of CHAR_TO_BYTE. Fixes a crash when a completion
879 candidate is selected by the mouse, and that candidate has a
880 composed character under the mouse.
882 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
883 coordinates reported by pos-visible-in-window-p for a composed
884 character in column zero.
886 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
888 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
890 2011-08-22 Eli Zaretskii <eliz@gnu.org>
892 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
893 consider it a hit if to_charpos is anywhere in the range of the
894 composed buffer positions.
896 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
898 * image.c (gif_load): Don't assume that each subimage has the same
899 dimensions as the base image. Handle disposal method that is
900 "undefined" by the gif spec (Bug#9335).
902 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
904 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
905 (Fcondition_case): Document `debug' symbol in error handler.
907 2011-08-19 Eli Zaretskii <eliz@gnu.org>
909 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
910 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
911 from an Org mode buffer to a Speedbar frame.
913 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
914 a composition, take its buffer position from IT->cmp_it.charpos.
915 Fixes cursor positioning at the beginning of a line that begins
916 with a composed character.
918 2011-08-18 Eli Zaretskii <eliz@gnu.org>
920 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
921 character bidirectional type, use STRONG_L instead. Fixes crashes
922 in a buffer produced by `describe-categories'.
924 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
925 members before the level stack, so they would be saved and
926 restored when copying iterator state. Fixes incorrect reordering
927 around TABs covered by display properties.
929 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
931 * process.c (Fnetwork_interface_list): Correctly determine buffer
934 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
936 * eval.c (internal_condition_case, internal_condition_case_1)
937 (internal_condition_case_2, internal_condition_case_n):
938 Remove unnecessary aborts (Bug#9081).
940 2011-08-17 Eli Zaretskii <eliz@gnu.org>
942 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
943 has no `load' handler, try opening the file locally. (Bug#9311)
945 2011-08-16 Ken Brown <kbrown@cornell.edu>
947 * gmalloc.c: Expand comment.
949 2011-08-16 Eli Zaretskii <eliz@gnu.org>
951 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
952 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
954 2011-08-16 Ken Brown <kbrown@cornell.edu>
956 Fix memory allocation problems in Cygwin build (Bug#9273).
958 * unexcw.c ( __malloc_initialized): Declare external variable.
959 (fixup_executable): Force the dumped emacs to reinitialize malloc.
961 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
963 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
965 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
967 [CYGWIN] (special_realloc): New function.
968 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
969 requests to realloc storage in the static heap.
971 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
973 * bidi.c (bidi_initialize): Remove unused local.
975 2011-08-15 Eli Zaretskii <eliz@gnu.org>
977 * biditype.h: File removed.
979 * bidimirror.h: File removed.
981 * deps.mk (bidi.o): Remove biditype.h and
984 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
987 * dispextern.h: Fix a typo in the comment to bidi_type_t.
989 * chartab.c: Improve commentary for the uniprop_table API.
991 * bidi.c (bidi_paragraph_init): Support zero value of
992 bidi_ignore_explicit_marks_for_paragraph_level.
993 (bidi_initialize): Use uniprop_table instead of including
994 biditype.h and bidimirror.h.
996 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
997 coordinates of the iterator when restoring from ppos_it.
1000 2011-08-14 Kenichi Handa <handa@m17n.org>
1002 * process.c (create_process): Call setup_process_coding_systems
1003 after the pid of the process is set to -1 (Bug#8162).
1005 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1007 * xdisp.c (move_it_in_display_line_to): Don't invoke
1008 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1009 ppos_it. Fixes vertical cursor motion when line beginning is
1010 covered by an image. (Bug#9296)
1012 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1014 * nsterm.h (ns_run_ascript): Declare.
1015 (NSAPP_DATA2_RUNASSCRIPT): Define.
1017 * nsfns.m (as_script, as_result, as_status): New static variables.
1018 (ns_run_ascript): New function.
1019 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1020 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1021 the event loop. Get status from as_status (Bug#7276).
1023 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1024 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1025 the event loop (Bug#7276).
1027 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1029 * gnutls.c (QCgnutls_bootprop_priority)
1030 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1031 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1032 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1033 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1034 (QCgnutls_bootprop_verify_hostname_error)
1035 (QCgnutls_bootprop_callbacks_verify): Rename from
1036 Qgnutls_bootprop_..., all uses changed.
1038 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1041 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1043 * xfaces.c (Qframe_set_background_mode): Now static.
1044 * dispextern.h (Qframe_set_background_mode): Remove decl.
1046 * process.c (Fnetwork_interface_info): Declare local only if needed.
1048 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1050 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1051 (Fnetwork_interface_list): Allocate in increments of bytes instead
1052 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1053 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1055 (struct ifflag_def): notrailers is smart on OSX.
1056 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1057 Get hardware address with getifaddrs if available.
1059 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1061 * xdisp.c (iterate_out_of_display_property): xassert that
1062 IT->position is set to within IT->object's boundaries. Break from
1063 the loop as soon as EOB is reached; avoids infloops in redisplay
1064 when IT->position is set up wrongly due to some bug.
1065 Set IT->current to match the bidi iterator unconditionally.
1066 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1067 entry. Force push_it to save on the stack the current
1068 buffer/string position, to be restored by pop_it. Fix flags in
1069 the iterator structure wrt the object coming from a display
1070 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1071 properties. (Bug#9284)
1073 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1075 * fontset.c (fontset_get_font_group): Add proper type checks.
1078 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1080 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1081 and LC_VERSION_MIN_MACOSX.
1082 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1083 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1085 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1087 * xdisp.c (forward_to_next_line_start): Allow to use the
1088 no-display-properties-and-no-overlays under bidi display.
1089 Set disp_pos in the bidi iterator to avoid searches for display
1090 properties and overlays.
1092 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1094 * editfns.c (Fset_time_zone_rule): Document relationship with the
1097 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1098 the font entity extracted from the cache (Bug#8109).
1100 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1102 * composite.c (autocmp_chars): Don't reset point. That is done by
1103 restore_point_unwind (Bug#5984).
1105 2011-08-07 Juri Linkov <juri@jurta.org>
1107 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1108 to show the arg `TIME' instead of `TIMEVAL'.
1110 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1112 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1113 display property strides EOL and includes a newline, as in
1114 longlines-mode. (Bug#9254)
1115 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1116 word-wrap under bidirectional display. (Bug#9224)
1118 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1119 is non-zero, even if the data buffer is NULL. Fixes a crash in
1120 vertical-motion with longlines-mode. (Bug#9254)
1122 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1124 * bidi.c <bidi_cache_total_alloc>: Now static.
1125 (bidi_initialize): Initialize bidi_cache_total_alloc.
1127 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1130 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1131 amount allocated this far in `bidi_cache_total_alloc'.
1132 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1133 non-zero, only free the data buffer without restoring the cache
1134 contents. All callers changed.
1136 * dispextern.h (bidi_unshelve_cache): Update prototype.
1138 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1139 (move_it_in_display_line, move_it_to)
1140 (move_it_vertically_backward, move_it_by_lines): Replace the call
1141 to xfree to an equivalent call to bidi_unshelve_cache.
1142 (move_it_in_display_line_to): Fix logic of returning
1143 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1145 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1147 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1148 came from a string character with a `cursor' property. (Bug#9229)
1150 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1152 * Makefile.in (LIB_PTHREAD): New variable.
1153 (LIBES): Add LIB_PTHREAD (Bug#9216).
1155 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1156 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1158 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1160 * regex.c (re_iswctype): Remove some redundant boolean
1163 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1165 * xterm.c (x_find_topmost_parent): New function.
1166 (x_set_frame_alpha): Find topmost parent window with
1167 x_find_topmost_parent and set the property there also (bug#9181).
1168 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1170 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1172 * callproc.c (Fcall_process): Avoid vfork clobbering
1173 the local vars buffer, coding_systems, current_dir.
1175 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1177 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1179 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1181 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1182 so that it is not optimized away.
1184 * xdisp.c (compute_display_string_pos): Remove unused local.
1186 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1188 Fix slow cursor motion and scrolling in large buffers with
1189 selective display, like Org Mode buffers. (Bug#9218)
1191 * dispextern.h (struct bidi_it): New member disp_prop_p.
1193 * xdisp.c: Remove one-slot cache of display string positions.
1194 (compute_display_string_pos): Accept an additional argument
1195 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1196 for a display string or property. If found, set DISP_PROP_P
1199 * bidi.c (bidi_fetch_char): Accept an additional argument
1200 DISP_PROP_P, and pass it to compute_display_string_pos.
1201 Only handle text covered by a display string if DISP_PROP_P is returned
1202 non-zero. All callers of bidi_fetch_char changed.
1204 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1206 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1208 2010-12-03 Don March <don@ohspite.net>
1210 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1211 last character M-[char] is translated to ESC [char] (bug#7541).
1213 2011-08-02 Kenichi Handa <handa@m17n.org>
1215 * lisp.h (uniprop_table): Extern it.
1217 * chartab.c (uniprop_table): Make it non-static.
1219 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1221 * xdisp.c (forward_to_next_line_start): Accept additional argument
1222 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1224 (reseat_at_next_visible_line_start): Use the bidi iterator state
1225 returned by forward_to_next_line_start to restore the state of
1226 it->bidi_it after backing up to previous newline. (Bug#9212)
1228 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1230 * regex.c (re_comp): Protoize.
1231 (re_exec): Fix return type.
1232 (regexec): Fix type of `ret'. (Bug#9203)
1234 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1236 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1237 This is needed if max-image-size is a floating-point number.
1239 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1241 * print.c (print_object): Print empty symbol as ##.
1243 * lread.c (read1): Read ## as empty symbol.
1245 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1247 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1248 setting frame foreground color (Bug#9175).
1249 (x_set_background_color): Likewise.
1251 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1252 contents (Bug#9176).
1253 (EmacsTooltip -init): Remove bezels and add shadows to
1256 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1257 or scroll bar (Bug#8470).
1259 * nsfont.m (nsfont_open): Remove assignment to voffset and
1260 unnecessary vars hshink, expand, hd, full_height, min_height.
1261 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1263 * nsterm.h (nsfont_info): Remove voffset field.
1265 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1267 Implement strike-through and overline on NextStep (Bug#8863).
1269 * nsfont.m (nsfont_open): Use underline position provided by font,
1270 instead of hard-coded value of 2.
1271 (nsfont_draw): Call ns_draw_text_decoration instead.
1273 * nsterm.h: Add declaration for ns_draw_text_decoration.
1275 * nsterm.m (ns_draw_text_decoration): New function for drawing
1276 underline, overline, and strike-through.
1277 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1278 ns_draw_text_decoration. Change treatment of cursor drawing to
1279 accomodate underlining, etc.
1281 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1283 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1286 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1288 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1289 Without this fix, if a signal arrives just after memory fills up,
1290 'malloc' might be invoked reentrantly.
1292 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1293 In other words, assume that every image size is allowed, on non-X
1294 hosts. This assumption is probably wrong, but it lets Emacs compile.
1296 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1298 * regex.c (re_iswctype): Convert return values to boolean.
1300 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1302 * xdisp.c (compute_display_string_pos): Don't use cached display
1303 string position if the buffer had its restriction changed.
1306 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1308 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1310 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1312 Integer signedness and overflow and related fixes. (Bug#9079)
1314 * bidi.c: Integer size and overflow fixes.
1315 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1316 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1317 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1318 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1319 (bidi_find_other_level_edge):
1320 Use ptrdiff_t instead of EMACS_INT where either will do.
1321 This works better on 32-bit hosts configured --with-wide-int.
1322 (bidi_cache_ensure_space): Check for size-calculation overflow.
1323 Use % rather than repeated addition, for better worst-case speed.
1324 Don't set bidi_cache_size until after xrealloc returns, because it
1326 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1327 (bidi_cache_ensure_space): Also check that the bidi cache size
1328 does not exceed that of the largest Lisp string or buffer. See Eli
1329 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1331 * alloc.c (__malloc_size_t): Remove.
1332 All uses replaced by size_t. See Andreas Schwab's note
1333 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1335 * image.c: Improve checking for integer overflow.
1336 (check_image_size): Assume that f is nonnull, since
1337 it is always nonnull in practice. This is one less thing to
1338 worry about when checking for integer overflow later.
1339 (x_check_image_size): New function, which checks for integer
1340 overflow issues inside X.
1341 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1342 This removes the need for a memory_full check.
1343 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1344 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1345 (xbm_read_bitmap_data): Change locals back to 'int', since
1346 their values must fit in 'int'.
1347 (xpm_load_image, png_load, tiff_load):
1348 Invoke x_create_x_image_and_pixmap earlier,
1349 to avoid much needless work if the image is too large.
1350 (tiff_load): Treat overly large images as if
1351 x_create_x_image_and_pixmap failed, not as malloc failures.
1352 (gs_load): Use x_check_image_size.
1354 * gtkutil.c: Omit integer casts.
1355 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1356 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1358 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1360 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1361 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1362 would wrongly return t on a 64-bit host.
1364 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1365 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1366 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1367 and therefore cause GCC to emit a bogus diagnostic in some cases.
1369 * image.c: Integer signedness and overflow and related fixes.
1370 This is not an exhaustive set of fixes, but it's time to
1371 record what I've got.
1372 (lookup_pixel_color, check_image_size): Remove redundant decls.
1373 (check_image_size): Don't assume that arbitrary EMACS_INT values
1374 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1375 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1376 (tiff_load, imagemagick_load_image):
1377 Check for overflow in size calculations.
1378 (x_create_x_image_and_pixmap): Remove unnecessary test for
1379 xmalloc returning NULL; that can't happen.
1380 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1381 (xpm_color_bucket): Use better integer hashing function.
1382 (xpm_cache_color): Don't possibly over-allocate memory.
1383 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1384 (gif_memory_source):
1385 Use ptrdiff_t, not int or size_t, to record sizes.
1386 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1387 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1388 either works, as we prefer signed integers.
1389 (tiff_read_from_memory, tiff_write_from_memory):
1390 Return tsize_t, not size_t, since that's what the TIFF API wants.
1391 (tiff_read_from_memory): Don't fail simply because the read would
1392 go past EOF; instead, return a short read.
1393 (tiff_load): Omit no-longer-needed casts.
1394 (Fimagemagick_types): Don't assume size fits into 'int'.
1396 Improve hashing quality when configured --with-wide-int.
1397 * fns.c (hash_string): New function, taken from sxhash_string.
1398 Do not discard information about ASCII character case; this
1399 discarding is no longer needed.
1400 (sxhash-string): Use it. Change sig to match it. Caller changed.
1401 * lisp.h: Declare it.
1402 * lread.c (hash_string): Remove, since we now use fns.c's version.
1403 The fns.c version returns a wider integer if --with-wide-int is
1404 specified, so this should help the quality of the hashing a bit.
1406 * emacs.c: Integer overflow minor fix.
1407 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1408 Define only if GNU_LINUX.
1409 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1411 * dispnew.c: Integer signedness and overflow fixes.
1412 Remove unnecessary forward decls, that were a maintenance hassle.
1413 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1415 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1416 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1417 (prepare_desired_row, line_draw_cost):
1418 Use int, not unsigned, where either works.
1419 (save_current_matrix, restore_current_matrix):
1420 Use ptrdiff_t, not size_t, where either works.
1421 (init_display): Check for overflow more accurately, and without
1422 relying on undefined behavior.
1424 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1425 Remove, replacing with the new symbols in lisp.h. All uses changed.
1426 * fileio.c (make_temp_name):
1427 * filelock.c (lock_file_1, lock_file):
1428 * xdisp.c (message_dolog):
1429 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1430 Use pMd etc. instead.
1431 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1432 replacing the pWIDE etc. symbols removed from editfns.c.
1434 * keyboard.h (num_input_events): Now uintmax_t.
1435 This is (very slightly) less likely to mess up due to wraparound.
1438 * buffer.c: Integer signedness fixes.
1439 (alloc_buffer_text, enlarge_buffer_text):
1440 Use ptrdiff_t rather than size_t when either will do, as we prefer
1443 * alloc.c: Integer signedness and overflow fixes.
1444 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1445 (__malloc_size_t): Default to size_t, not to int.
1446 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1447 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1448 Prefer ptrdiff_t to size_t when either would do, as we prefer
1450 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1451 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1452 Now const. Initialize with values that are in range even if char
1454 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1455 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1456 These functions do the right thing with sizes > 2**32.
1457 (check_depth): Now ptrdiff_t, not int.
1458 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1459 Adjust to new way of storing sizes. Check for size overflow bugs
1461 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1462 slightly wrong anyway, as it missed one instance of
1463 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1464 (refill_memory_reserve): Omit needless cast to size_t.
1465 (mark_object_loop_halt): Mark as externally visible.
1467 * xselect.c: Integer signedness and overflow fixes.
1468 (Fx_register_dnd_atom, x_handle_dnd_message):
1469 Use ptrdiff_t, not size_t, since we prefer signed.
1470 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1471 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1472 x_dnd_atoms_size and x_dnd_atoms_length.
1474 * doprnt.c: Prefer signed to unsigned when either works.
1476 * doprnt.c (doprnt):
1478 * xdisp.c (vmessage):
1479 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1480 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1481 prefer signed arithmetic to avoid comparison confusion.
1482 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1483 but is a bit tricky.
1485 Assume freestanding C89 headers, string.h, stdlib.h.
1486 * data.c, doprnt.c, floatfns.c, print.c:
1487 Include float.h unconditionally.
1488 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1489 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1490 * regex.c: Likewise for stddef.h, string.h.
1491 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1492 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1493 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1494 (STDC_HEADERS): Remove obsolete defines.
1495 * sysdep.c: Include limits.h unconditionally.
1497 Assume support for memcmp, memcpy, memmove, memset.
1498 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1499 * regex.c (memcmp, memcpy):
1500 Remove; we assume C89 now.
1502 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1503 (__malloc_safe_bcopy): Remove; no longer needed.
1505 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1506 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1507 well either way, and we prefer signed to unsigned.
1509 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1511 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1512 closes the connection while we're reading (bug#9182).
1514 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1516 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1517 are specified (Bug#9168).
1519 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1521 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1522 Found by GCC static checking and --with-wide-int on a 32-bit host.
1524 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1526 * xdisp.c (compute_display_string_pos): Fix logic of caching
1527 previous display string position. Initialize cached_prev_pos to
1528 -1. Fixes slow-down at the beginning of a buffer.
1530 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1532 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1533 for attrs[LFACE_FONTSET_INDEX].
1535 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1537 * xml.c (parse_region): Remove unused local
1538 that was recently introduced.
1540 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1542 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1543 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1545 * xdisp.c (move_it_in_display_line_to): Record the best matching
1546 position for TO_CHARPOS while scanning the line, and restore it on
1547 exit if none of the characters scanned was an exact match.
1548 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1549 when exact match is impossible due to invisible text, and the
1550 lines are truncated.
1552 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1554 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1557 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1559 Fix a significant slow-down of cursor motion with C-n, C-p,
1560 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1561 auto-repeat under bidi redisplay in fontified buffers.
1562 * xdisp.c (compute_stop_pos_backwards): New function.
1563 (next_element_from_buffer): Call compute_stop_pos_backwards to
1564 find a suitable prev_stop when we find ourselves before
1566 (reseat): Don't look for prev_stop, as that could mean a very long
1568 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1569 <cached_disp_overlay_modiff>: Cache for last found display string
1571 (compute_display_string_pos): Return the cached position if asked
1572 about the same buffer in the same area of character positions, and
1573 the buffer wasn't changed since the time the display string
1574 position was cached.
1576 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1578 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1579 is an integer, which is important for empty lines. (Bug#9149)
1581 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1583 * frame.c (Fmodify_frame_parameters): In tty case, update the
1584 default face if necessary (Bug#4238).
1586 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1588 * editfns.c (Fstring_to_char): No need to explain what a character
1589 is in the docstring (Bug#6576).
1591 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1593 * xml.c (parse_region): Make sure we always return a tree.
1595 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1597 * xml.c (parse_region): If a document contains only comments,
1600 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1602 * xml.c (make_dom): Return comments, too.
1604 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1607 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1608 and the surrounding thread.
1609 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1610 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1611 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1613 * s/openbsd.h (BROKEN_SIGIO): Define.
1614 * unexelf.c (unexec) [__OpenBSD__]:
1615 Don't update the .mdebug section of the Alpha COFF symbol table.
1617 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1619 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1622 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1624 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1625 This fixes some race conditions on the permissions of any newly
1628 * alloc.c (valid_pointer_p): Use pipe, not open.
1629 This fixes some permissions issues when debugging.
1631 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1632 If fchown fails to set both uid and gid, try to set just gid,
1633 as that is sometimes allowed. Adjust the file's mode to eliminate
1634 setuid or setgid bits that are inappropriate if fchown fails.
1636 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1638 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1639 to compare Lisp_Objects.
1640 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1641 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1642 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1644 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1646 * lread.c (read_integer): Unread even EOF character.
1647 (read1): Likewise. Properly record start position of symbol.
1649 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1650 symbol character follows.
1652 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1654 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1655 This works around a problem with the previous change to Fcopy_file.
1656 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1657 and without this change, GCC might complain about discarding
1658 fchown's return value.
1660 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1662 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1664 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1666 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1668 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1670 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1671 it's used from the C level.
1673 * process.c: Use the same condition for POLL_FOR_INPUT in both
1674 keyboard.c and process.c (bug#1858).
1676 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1678 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1679 (Fgnutls_boot): Use it.
1681 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1683 * doc.c (Fsubstitute_command_keys): Revert last change.
1685 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1687 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1688 quotes the next character, and doesn't affect other longer
1689 sequences (bug#8935).
1691 * lread.c (syms_of_lread): Clarify that is isn't only
1692 `eval-buffer' and `eval-defun' that's affected by
1693 `lexical-binding' (bug#8460).
1695 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1697 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1698 bidi redisplay when a line includes both an image and is
1701 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1703 Fix minor problems found by static checking.
1704 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1705 (elsz): Now a signed constant, not a size_t var. We prefer signed
1706 types to unsigned, to avoid integer comparison confusion. Without
1707 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1708 "cannot optimize loop, the loop counter may overflow", a symptom
1710 * indent.c (Fvertical_motion): Mark locals as initialized.
1711 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1713 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1715 * search.c (Fre_search_backward): Mention `case-fold-search' in
1716 all the re_search_* functions (bug#8138).
1718 * keyboard.c (Fopen_dribble_file): Document when the file is
1721 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1723 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1726 Support bidi reordering of display and overlay strings.
1727 * xdisp.c (compute_display_string_pos)
1728 (compute_display_string_end): Accept additional argument STRING.
1729 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1730 (reseat_to_string): Initialize bidi_it->string.s and
1731 bidi_it->string.schars.
1732 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1733 NULL (avoids a crash in bidi_paragraph_init).
1734 Initialize itb.string.lstring.
1735 (init_iterator): Call bidi_init_it only of a valid
1736 buffer position was specified. Initialize paragraph_embedding to
1738 (reseat_to_string): Initialize the bidi iterator.
1739 (display_string): If we need to ignore text properties of
1740 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1741 original value of -1 will not work with bidi.)
1742 (compute_display_string_pos): First arg is now struct
1743 `text_pos *'; all callers changed. Support display properties on
1745 (compute_display_string_end): Support display properties on Lisp
1747 (init_iterator, reseat_1, reseat_to_string): Initialize the
1748 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1749 when iterating on a string not from display properties).
1750 (compute_display_string_pos, compute_display_string_end):
1751 Fix calculation of the object to scan. Fixes an error when using
1753 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1754 base_level_stop; instead, set base_level_stop to BEGV.
1755 Fixes crashes in vertical-motion.
1756 (next_element_from_buffer): Improve commentary for when
1757 the iterator is before prev_stop.
1758 (init_iterator): Initialize bidi_p from the default value of
1759 bidi-display-reordering, not from buffer-local value. Use the
1760 buffer-local value only if initializing for buffer iteration.
1761 (handle_invisible_prop): Support invisible properties on strings
1762 that are being bidi-reordered.
1763 (set_iterator_to_next): Support bidi reordering of C strings and
1765 (next_element_from_string): Support bidi reordering of Lisp
1767 (handle_stop_backwards): Support Lisp strings as well.
1768 (display_string): Support display of R2L glyph rows.
1769 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1770 (init_iterator): Don't initialize it->bidi_p for strings
1772 (reseat_to_string): Initialize it->bidi_p for strings here.
1773 (next_element_from_string, next_element_from_c_string)
1774 (next_element_from_buffer): Add xassert's for correspondence
1775 between IT's object being iterated and it->bidi_it.string
1777 (face_before_or_after_it_pos): Support bidi iteration.
1778 (next_element_from_c_string): Handle the case of the first string
1779 character that is not the first one in the visual order.
1780 (get_visually_first_element): New function, refactored from common
1781 parts of next_element_from_buffer, next_element_from_string, and
1782 next_element_from_c_string.
1783 (tool_bar_lines_needed, redisplay_tool_bar)
1784 (display_menu_bar): Force left-to-right direction. Add a FIXME
1785 comment for making that be controlled by a user option.
1786 (push_it, pop_it): Save and restore the state of the
1787 bidi iterator. Save and restore the bidi_p flag.
1788 (pop_it): Iterate out of display property for string iteration as
1790 (iterate_out_of_display_property): Support iteration over strings.
1791 (handle_single_display_spec): Set up it->bidi_it for iteration
1792 over a display string, and call bidi_init_it.
1793 (handle_single_display_spec, next_overlay_string)
1794 (get_overlay_strings_1, push_display_prop): Set up the bidi
1795 iterator for displaying display or overlay strings.
1796 (forward_to_next_line_start): Don't use the shortcut if
1798 (back_to_previous_visible_line_start): If handle_display_prop
1799 pushed the iterator stack, restore the internal state of the bidi
1800 iterator by calling bidi_pop_it same number of times.
1801 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1802 and we are bidi-iterating, don't decrement the iterator position;
1803 instead, set the first_elt flag in the bidi iterator, to produce
1805 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1806 (push_display_prop): xassert that we are iterating a buffer.
1807 (push_it, pop_it): Save and restore paragraph_embedding member.
1808 (handle_single_display_spec, next_overlay_string)
1809 (get_overlay_strings_1, reseat_1, reseat_to_string)
1810 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1811 correctly. Don't assume unibyte strings are not bidi-reordered.
1812 (compute_display_string_pos)
1813 (compute_display_string_end): Fix handling the case of C string.
1814 (push_it, pop_it): Save and restore from_disp_prop_p.
1815 (handle_single_display_spec, push_display_prop): Set the
1816 from_disp_prop_p flag.
1817 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1818 (pop_it): Call iterate_out_of_display_property only if we are
1819 popping after iteration over a string that came from a display
1820 property. Fix a typo in popping stretch info. Add an assertion
1821 for verifying that the iterator position is in sync with the bidi
1823 (handle_single_display_spec, get_overlay_strings_1)
1824 (push_display_prop): Fix initialization of paragraph direction for
1825 string when that of the parent object is not yet determined.
1826 (reseat_1): Call bidi_init_it to resync the bidi
1827 iterator with IT's position. (Bug#7616)
1828 (find_row_edges): If ROW->start.pos gives position
1829 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1830 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1831 Reset the from_disp_prop_p flag.
1832 (SAVE_IT, RESTORE_IT): New macros.
1833 (pos_visible_p, face_before_or_after_it_pos)
1834 (back_to_previous_visible_line_start)
1835 (move_it_in_display_line_to, move_it_in_display_line)
1836 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1837 (try_scrolling, redisplay_window, display_line): Use them when
1838 saving a temporary copy of the iterator and restoring it back.
1839 (back_to_previous_visible_line_start, reseat_1)
1840 (init_iterator): Empty the bidi cache "stack".
1841 (move_it_in_display_line_to): If iterator ended up at
1842 EOL, but we never saw any buffer positions smaller than
1843 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1844 motion in bidi-reordered lines.
1845 (move_it_in_display_line_to): Record prev_method and prev_pos
1846 immediately before the call to set_iterator_to_next. Fixes cursor
1847 motion in bidi-reordered lines with stretch glyphs and strings
1848 displayed in margins. (Bug#8133) (Bug#8867)
1849 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1851 (pos_visible_p): Support positions in bidi-reordered lines.
1852 Save and restore bidi cache.
1854 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1855 (bidi_paragraph_info): Delete unused struct.
1856 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1857 (bidi_cache_start): New variable.
1858 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1860 (bidi_cache_fetch_state, bidi_cache_search)
1861 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1862 (bidi_cache_find, bidi_peek_at_next_level)
1863 (bidi_level_of_next_char, bidi_find_other_level_edge)
1864 (bidi_move_to_visually_next): Compare cache index with
1865 bidi_cache_start rather than with zero.
1866 (bidi_fetch_char): Accept new argument STRING; all callers
1867 changed. Support iteration over a string. Support strings with
1868 display properties. Support unibyte strings. Fix the type of
1869 `len' according to what STRING_CHAR_AND_LENGTH expects.
1870 (bidi_paragraph_init, bidi_resolve_explicit_1)
1871 (bidi_resolve_explicit, bidi_resolve_weak)
1872 (bidi_level_of_next_char, bidi_move_to_visually_next):
1873 Support iteration over a string.
1874 (bidi_set_sor_type, bidi_resolve_explicit_1)
1875 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1876 can now be zero (for strings); special values 0 and -1 were
1877 changed to -1 and -2, respectively.
1878 (bidi_char_at_pos): New function.
1879 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1880 Call it instead of FETCH_MULTIBYTE_CHAR.
1881 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1882 initialized to valid values.
1883 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1885 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1886 the test for valid cached positions. Fix the logic for looking up
1887 the sentinel state in the cache. GCPRO the Lisp string we are
1889 (bidi_push_it, bidi_pop_it): New functions.
1890 (bidi_initialize): Initialize the bidi cache start stack pointer.
1891 (bidi_cache_ensure_space): New function, refactored from part of
1892 bidi_cache_iterator_state. Don't assume the required size is just
1893 one BIDI_CACHE_CHUNK away.
1894 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1895 (bidi_count_bytes, bidi_char_at_pos): New functions.
1896 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1897 always valid if bidi_cache_idx is valid.
1898 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1899 is valid if it's going to be used.
1900 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1901 (bidi_cache_fetch_state, bidi_cache_search)
1902 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1903 (bidi_cache_iterator_state, bidi_cache_find)
1904 (bidi_find_other_level_edge, bidi_cache_start_stack):
1905 All variables related to cache indices are now EMACS_INT.
1907 * dispextern.h (struct bidi_string_data): New structure.
1908 (struct bidi_it): New member `string'. Make flag members be 1-bit
1909 fields, and put them last in the struct.
1910 (compute_display_string_pos, compute_display_string_end):
1912 (bidi_push_it, bidi_pop_it): Add prototypes.
1913 (struct iterator_stack_entry): New members bidi_p,
1914 paragraph_embedding, and from_disp_prop_p.
1915 (struct it): Member bidi_p is now a bit field 1 bit wide.
1916 (bidi_shelve_cache, bidi_unshelve_cache):
1919 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1920 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1921 and vector-like objects.
1923 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1924 cache around display iteration.
1926 * window.c (Fwindow_end, window_scroll_pixel_based)
1927 (displayed_window_lines, Frecenter): Save and restore the bidi
1928 cache around display iteration.
1930 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1932 * editfns.c (Fdelete_region): Clarify the use of the named
1933 parameters (bug#6788).
1935 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1937 * indent.c (Fvertical_motion): Set and restore w->pointm when
1938 saving and restoring the window's buffer (Bug#9006).
1940 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1942 * editfns.c (Fstring_to_char): Clarify just what is returned
1943 (bug#6576). Text by Eli Zaretskii.
1945 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1947 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1949 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1951 * buffer.c (mmap_find): Fix a typo.
1953 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1955 Fix execution of x selection hooks.
1956 * xselect.c (Qx_lost_selection_functions)
1957 (Qx_sent_selection_functions): New vars.
1958 (syms_of_xselect): DEFSYM them.
1959 (x_handle_selection_request): Pass Qx_sent_selection_functions
1960 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1961 (x_handle_selection_clear,x_clear_frame_selections):
1962 Pass Qx_lost_selection_functions rather than
1963 Vx_lost_selection_functions to Frun_hook_with_args.
1965 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1967 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1968 The old code sometimes used this field without initializing it.
1970 * alloc.c (gc_sweep): Don't read past end of array.
1971 In theory, the old code could also have corrupted Emacs internals,
1972 though it'd be very unlikely.
1974 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1976 * character.c (Fcharacterp): Don't advertise optional ignored
1977 argument. (Bug#4026)
1979 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1981 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1984 * window.c (Fset_window_start): Doc fix (bug#4199).
1985 (Fset_window_hscroll): Ditto.
1987 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1989 Fix minor new problems caught by GCC 4.6.1.
1990 * term.c (init_tty): Remove unused local.
1991 * xsettings.c (store_monospaced_changed): Define this function only
1992 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1995 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1997 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1999 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2001 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2002 are the mini-buffer and the echo area (bug#3320).
2004 * term.c (init_tty): Remove support for supdup, c10 and perq
2005 terminals, which are no longer supported (bug#1482).
2007 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2009 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2011 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2013 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2014 for non-popups (Bug#3642).
2016 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2018 * alloc.c (reset_malloc_hooks): Protoize.
2019 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2020 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2021 * cm.c (losecursor): Likewise.
2022 * data.c (fmod): Likewise.
2023 * dispnew.c (swap_glyphs_in_rows): Likewise.
2024 * emacs.c (memory_warning_signal): Likewise.
2025 * floatfns.c (float_error): Likewise.
2026 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2027 (otf_open, font_otf_capability, generate_otf_features)
2028 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2030 * image.c (pbm_read_file): Likewise.
2031 * indent.c (string_display_width): Likewise.
2032 * intervals.c (check_for_interval, search_for_interval)
2033 (inc_interval_count, count_intervals, root_interval)
2034 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2035 * lread.c (defalias): Likewise.
2036 * ralloc.c (r_alloc_check): Likewise.
2037 * regex.c (set_image_of_range_1, set_image_of_range)
2038 (regex_grow_registers): Likewise.
2039 * sysdep.c (strerror): Likewise.
2040 * termcap.c (valid_filename_p, tprint, main): Likewise.
2041 * tparam.c (main): Likewise.
2042 * unexhp9k800.c (run_time_remap, save_data_space)
2043 (update_file_ptrs, read_header, write_header, calculate_checksum)
2044 (copy_file, copy_rest, display_header): Likewise.
2045 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2047 * xdisp.c (check_it): Likewise.
2048 * xfaces.c (register_color, unregister_color, unregister_colors):
2050 * xfns.c (print_fontset_result): Likewise.
2051 * xrdb.c (member, fatal, main): Likewise.
2053 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2055 Fix minor problems found by static checking (Bug#9031).
2056 * chartab.c (char_table_set_range, map_sub_char_table):
2057 Remove unused locals.
2058 (uniprop_table): Now static.
2059 * composite.c (_work_char): Remove unused static var.
2061 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2063 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2065 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2067 * gtkutil.c (qttip_cb): Remove code without function.
2069 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2071 * w32.c (pthread_sigmask): New stub.
2073 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2075 Use pthread_sigmask, not sigprocmask (Bug#9010).
2076 sigprocmask is portable only for single-threaded applications, and
2077 Emacs can be multi-threaded when it uses GTK.
2078 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2080 * callproc.c (Fcall_process):
2081 * process.c (create_process):
2082 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2083 Use pthread_sigmask, not sigprocmask.
2085 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2087 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2088 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2091 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2093 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2094 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2095 (xg_hide_tooltip): Fix comment.
2097 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2098 in registerServicesMenuSendTypes.
2099 (validRequestorForSendType): Don't check ns_return_types.
2101 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2104 2011-07-08 Jason Rumney <jasonr@gnu.org>
2106 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2107 frame struct members of non-existent frames (Bug#6284).
2109 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2111 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2112 variable firstTime not needed on OSX >= 10.6.
2113 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2114 >= 10.5. Use setKnobProportion, setDoubleValue.
2116 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2117 (MAC_OS_X_VERSION_10_5): Define if not defined.
2118 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2119 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2120 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2122 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2123 cString and lossyCString on OSX >= 10.4
2125 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2126 sizeToFit on OSX >= 10.2.
2128 * nsimage.m (allocInitFromFile): Don't use deprecated method
2129 bestRepresentationForDevice on OSX >= 10.6.
2131 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2134 * emacs.c: Declare unexec_init_emacs_zone.
2136 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2138 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2140 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2141 on svcsMenu (Bug#8842).
2143 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2145 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2147 * nsterm.m (QUTF8_STRING): Declare.
2148 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2149 (validRequestorForSendType): Return type is (id).
2150 Change indexOfObjectIdenticalTo to indexOfObject.
2151 Check if we have local selection before returning self (Bug#8842).
2152 (writeSelectionToPasteboard): Put local selection into paste board
2153 if we have a local selection (Bug#8842).
2154 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2156 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2157 (ns_get_local_selection): Declare.
2159 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2161 * keymap.c (describe_map_tree): Don't insert a double newline at
2162 the end of the buffer (bug#1169) and return whether we inserted
2165 * callint.c (Fcall_interactively): Change "reading args" to
2166 "providing args" to try to clarify what it does (bug#1010).
2168 2011-07-07 Kenichi Handa <handa@m17n.org>
2170 * composite.c (composition_compute_stop_pos): Ignore a static
2171 composition starting before CHARPOS (Bug#8915).
2173 * xdisp.c (handle_composition_prop): Likewise.
2175 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2177 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2180 2011-07-07 Kenichi Handa <handa@m17n.org>
2182 * character.h (unicode_category_t): New enum type.
2184 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2185 (Qchar_code_property_table): New variable.
2186 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2187 (UNIPROP_COMPRESSED_FORM_P): New macros.
2188 (char_table_ascii): Uncompress the compressed values.
2189 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2190 Uncompress the compressed values.
2191 (sub_char_table_ref_and_range): Likewise.
2192 (char_table_ref_and_range): Uncompress the compressed values.
2193 (sub_char_table_set): New arg is_uniprop. Callers changed.
2194 Uncompress the compressed values.
2195 (sub_char_table_set_range): Args changed. Callers changed.
2196 (char_table_set_range): Adjuted for the above change.
2197 (map_sub_char_table): Delete args default_val and parent. Add arg
2198 top. Give decoded values to a Lisp function.
2199 (map_char_table): Adjust for the above change. Give decoded
2200 values to a Lisp function. Gcpro more variables.
2201 (uniprop_table_uncompress)
2202 (uniprop_decode_value_run_length): New functions.
2203 (uniprop_decoder, uniprop_decoder_count): New variables.
2204 (uniprop_get_decoder, uniprop_encode_value_character)
2205 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2207 (uniprop_encoder, uniprop_encoder_count): New variables.
2208 (uniprop_get_encoder, uniprop_table)
2209 (Funicode_property_table_internal, Fget_unicode_property_internal)
2210 (Fput_unicode_property_internal): New functions.
2211 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2212 Sunicode_property_table_internal, Sget_unicode_property_internal,
2213 and Sput_unicode_property_internal. Defvar_lisp
2214 char-code-property-alist.
2216 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2217 Vunicode_category_table.
2219 * font.c (font_range): Adjust for the change of
2220 Vunicode_category_table.
2222 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2224 * m/iris4d.h: Remove file, move contents ...
2225 * s/irix6-5.h: ... here.
2227 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2229 Remove unportable assumption about struct layout (Bug#8884).
2230 * alloc.c (mark_buffer):
2231 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2232 (clone_per_buffer_values): Don't assume that
2233 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2234 This isn't true in general, and it's particularly not true
2235 if Emacs is configured with --with-wide-int.
2236 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2237 New macros, used in the buffer.c change.
2239 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2241 * xsettings.c: Use both GConf and GSettings if both are available.
2242 (store_config_changed_event): Add comment.
2243 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2244 (store_tool_bar_style_changed): New functions.
2245 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2246 (struct xsettings): Move font inside HAVE_XFT.
2247 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2248 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2249 Move inside HAVE_XFT.
2250 (something_changed_gsettingsCB): Rename from something_changedCB.
2251 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2253 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2254 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2255 (something_changed_gconfCB): Rename from something_changedCB.
2256 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2257 (parse_settings): Move check for font inside HAVE_XFT.
2258 (read_settings, apply_xft_settings): Add comment.
2259 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2260 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2261 call store_font_name_changed.
2262 (xft_settings_event): Add comment.
2263 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2264 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2265 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2266 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2267 (xsettings_initialize): Call init_gsettings last.
2268 (xsettings_get_system_font, xsettings_get_system_normal_font):
2271 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2273 Random fixes. E.g., (random) never returned negative values.
2274 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2275 subseconds part to the entropy, as that's a bit more random.
2276 Prefer signed to unsigned, since the signedness doesn't matter and
2277 in general we prefer signed. When given a limit, use a
2278 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2279 latter isn't right if USE_2_TAGS_FOR_INTS.
2280 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2281 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2283 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2285 * textprop.c (text_property_stickiness):
2286 Obey Vtext_property_default_nonsticky.
2287 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2288 * w32fns.c (syms_of_w32fns):
2289 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2291 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2293 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2294 This is more efficient than Ffile_directory_p and avoids a minor race.
2296 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2298 * buffer.c (Foverlay_put): Say what the return value is
2301 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2302 is a directory before asking whether to use the file name
2304 (barf_or_query_if_file_exists): Make the "File is a directory"
2305 error be more correct.
2307 * fns.c (Frequire): Remove the mention of the .gz files, since
2308 that's installation-specific, but keep the mention of
2309 `get-load-suffixes'.
2311 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2313 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2314 Report string overflow if the output is too long.
2316 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2318 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2319 (syms_of_gnutls): Remove duplicate DEFSYM for
2320 Qgnutls_bootprop_verify_hostname_error, an error for
2321 Qgnutls_bootprop_verify_error (which is no longer used).
2323 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2324 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2325 Also (re)move comments that are misplaced or no longer relevant.
2327 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2329 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2331 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2333 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2334 and background color parameters if they have been changed.
2336 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2338 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2340 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2342 * xsettings.c (SYSTEM_FONT): Define only when used.
2343 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2345 * keymap.c (access_keymap_1): Now static.
2347 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2349 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2350 leave any prefix arg for the up event (Bug#1586).
2352 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2354 * lread.c (syms_of_lread): Mention single symbols defined by
2355 `defvar' or `defconst' (bug#7154).
2357 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2358 (Frequire): Mention get-load-suffixes.
2360 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2362 * window.h (window): Remove clone_number slot.
2363 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2365 (make_parent_window, make_window, saved_window)
2366 (Fset_window_configuration, save_window_save): Don't deal with
2368 * buffer.c (Qclone_number): Remove declaration.
2369 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2371 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2373 Add multiple inheritance to keymaps.
2374 * keymap.c (Fmake_composed_keymap): New function.
2375 (Fset_keymap_parent): Simplify.
2376 (fix_submap_inheritance): Remove.
2377 (access_keymap_1): New function extracted from access_keymap to handle
2378 embedded parents and handle lists of maps.
2379 (access_keymap): Use it.
2380 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2381 (Fcopy_keymap): Handle embedded parents.
2382 (Fcommand_remapping, define_as_prefix): Simplify.
2383 (Fkey_binding): Simplify.
2384 (syms_of_keymap): Move minibuffer-local-completion-map,
2385 minibuffer-local-filename-completion-map,
2386 minibuffer-local-must-match-map, and
2387 minibuffer-local-filename-must-match-map to Elisp.
2388 (syms_of_keymap): Defsubr make-composed-keymap.
2389 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2390 (parse_menu_item): Trivial simplification.
2392 2011-07-01 Glenn Morris <rgm@gnu.org>
2394 * Makefile.in (SETTINGS_LIBS): Fix typo.
2396 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2398 * coding.c (Fencode_coding_string): Record the last coding system
2399 used, as the function doc string says (bug#8738).
2401 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2403 * xsettings.c (store_monospaced_changed): Take new font as arg and
2404 check for change against current_mono_font.
2405 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2406 (emacs_settings_constructor, emacs_settings_get_property)
2407 (emacs_settings_set_property, emacs_settings_class_init)
2408 (emacs_settings_init, gsettings_obj): Remove.
2409 (something_changedCB): New function for HAVE_GSETTINGS.
2410 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2411 with value as argument.
2412 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2413 g_settings_new (Bug#8967). Do not create gsettings_obj.
2414 Remove calls to g_settings_bind. Connect something_changedCB to
2417 * xgselect.c: Add defined (HAVE_GSETTINGS).
2418 (xgselect_initialize): Ditto.
2420 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2421 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2424 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2426 * eval.c (struct backtrace): Simplify and port the data structure.
2427 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2428 signed bit field, as this assumption is not portable and it makes
2429 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2430 "char debug_on_exit : 1" as this is not portable either; instead,
2431 use the portable "unsigned int debug_on_exit : 1". Remove unused
2432 member evalargs. Remove obsolete comments about cc bombing out.
2434 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2436 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2437 Let HAVE_GSETTINGS override HAVE_GCONF.
2438 (store_monospaced_changed): New function.
2439 (EMACS_SETTINGS): A new type derived from GObject to handle
2440 GSettings notifications.
2441 (emacs_settings_constructor, emacs_settings_get_property)
2442 (emacs_settings_set_property, emacs_settings_class_init):
2444 (gsettings_client, gsettings_obj): New variables.
2445 (GSETTINGS_SCHEMA): New define.
2446 (something_changedCB): Call store_monospaced_changed.
2447 (init_gsettings): New function.
2448 (xsettings_initialize): Call init_gsettings.
2449 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2452 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2455 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2457 * window.c (resize_root_window, grow_mini_window)
2458 (shrink_mini_window): Rename Qresize_root_window to
2459 Qwindow_resize_root_window and Qresize_root_window_vertically to
2460 Qwindow_resize_root_window_vertically.
2462 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2464 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2466 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2468 * makefile.w32-in: Redesign dependencies so they reflect more
2469 clearly which files are directly included by each source file,
2470 and not through other includes.
2472 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2474 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2475 (sort_overlays, overlay_strings): When an overlay's clone number
2476 matches the window's clone number process the overlay even if
2477 the overlay's window property doesn't match the current window.
2479 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2480 (Fwindow_hchild): Rename to Fwindow_left_child.
2481 (Fwindow_next): Rename to Fwindow_next_sibling.
2482 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2483 (resize_window_check): Rename to window_resize_check.
2484 (resize_window_apply): Rename to window_resize_apply.
2485 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2486 (Fdelete_other_windows_internal, resize_frame_windows)
2487 (Fsplit_window_internal, Fdelete_window_internal)
2488 (grow_mini_window, shrink_mini_window)
2489 (Fresize_mini_window_internal): Fix callers accordingly.
2491 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2493 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2494 (emacs_fixed_set_min_size): Remove.
2495 (emacs_fixed_new): Take frame as argument.
2497 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2498 (_EmacsFixedPrivate): Remove minwidth/height.
2499 Add struct frame *f.
2500 (emacs_fixed_init): Initialize priv->f.
2501 (get_parent_class, emacs_fixed_set_min_size): Remove.
2502 (emacs_fixed_new): Set priv->f to argument.
2503 (emacs_fixed_get_preferred_width)
2504 (emacs_fixed_get_preferred_height): Use min_width/height from
2505 frames size_hint to set minimum and natural (Bug#8919).
2506 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2507 and use min_width/height from frames size_hint to set
2508 min_width/height (Bug#8919).
2510 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2511 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2514 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2516 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2517 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2520 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2522 * process.c (wait_reading_process_output): Bypass select if
2523 waiting for a cell while ignoring keyboard input, and input is
2524 pending. Suggested by Jan Djärv (Bug#8869).
2526 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2528 Use gnulib's dup2 module instead of rolling our own.
2529 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2531 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2533 * dispnew.c (scrolling_window): Before scrolling, turn off a
2534 mouse-highlight in the window being scrolled.
2536 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2538 Move DEFSYM to lisp.h and use everywhere.
2540 * character.h (DEFSYM): Move declaration...
2541 * lisp.h (DEFSYM): ...here.
2547 * w32select.c: Don't include character.h.
2549 * alloc.c (syms_of_alloc):
2550 * buffer.c (syms_of_buffer):
2551 * bytecode.c (syms_of_bytecode):
2552 * callint.c (syms_of_callint):
2553 * casefiddle.c (syms_of_casefiddle):
2554 * casetab.c (init_casetab_once):
2555 * category.c (init_category_once, syms_of_category):
2556 * ccl.c (syms_of_ccl):
2557 * cmds.c (syms_of_cmds):
2558 * composite.c (syms_of_composite):
2559 * dbusbind.c (syms_of_dbusbind):
2560 * dired.c (syms_of_dired):
2561 * dispnew.c (syms_of_display):
2562 * doc.c (syms_of_doc):
2563 * editfns.c (syms_of_editfns):
2564 * emacs.c (syms_of_emacs):
2565 * eval.c (syms_of_eval):
2566 * fileio.c (syms_of_fileio):
2567 * fns.c (syms_of_fns):
2568 * frame.c (syms_of_frame):
2569 * fringe.c (syms_of_fringe):
2570 * insdel.c (syms_of_insdel):
2571 * keymap.c (syms_of_keymap):
2572 * lread.c (init_obarray, syms_of_lread):
2573 * macros.c (syms_of_macros):
2574 * msdos.c (syms_of_msdos):
2575 * print.c (syms_of_print):
2576 * process.c (syms_of_process):
2577 * search.c (syms_of_search):
2578 * sound.c (syms_of_sound):
2579 * syntax.c (init_syntax_once, syms_of_syntax):
2580 * terminal.c (syms_of_terminal):
2581 * textprop.c (syms_of_textprop):
2582 * undo.c (syms_of_undo):
2583 * w32.c (globals_of_w32):
2584 * window.c (syms_of_window):
2585 * xdisp.c (syms_of_xdisp):
2586 * xfaces.c (syms_of_xfaces):
2587 * xfns.c (syms_of_xfns):
2588 * xmenu.c (syms_of_xmenu):
2589 * xsettings.c (syms_of_xsettings):
2590 * xterm.c (syms_of_xterm): Use DEFSYM.
2592 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2594 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2596 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2598 Integer and buffer overflow fixes (Bug#8873).
2600 * print.c (printchar, strout): Check for string overflow.
2601 (PRINTPREPARE, printchar, strout):
2602 Don't set size unless allocation succeeds.
2604 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2605 for sizes. Check for string overflow more accurately.
2606 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2608 * macros.c: Integer and buffer overflow fixes.
2609 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2610 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2611 Use ptrdiff_t, not int, for sizes.
2612 Don't increment bufsize until after realloc succeeds.
2613 Check for size-calculation overflow.
2614 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2616 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2618 * lread.c: Integer overflow fixes.
2619 (read_integer): Radix is now EMACS_INT, not int,
2620 to improve quality of diagnostics for out-of-range radices.
2621 Calculate buffer size correctly for out-of-range radices.
2622 (read1): Check for integer overflow in radices, and in
2623 read-circle numbers.
2624 (read_escape): Avoid int overflow.
2625 (Fload, openp, read_buffer_size, read1)
2626 (substitute_object_recurse, read_vector, read_list, map_obarray):
2627 Use ptrdiff_t, not int, for sizes.
2628 (read1): Use EMACS_INT, not int, for sizes.
2629 Check for size overflow.
2631 * image.c (cache_image): Check for size arithmetic overflow.
2633 * lread.c: Integer overflow issues.
2634 (saved_doc_string_size, saved_doc_string_length)
2635 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2636 Now ptrdiff_t, not int.
2637 (read1): Don't assume doc string length fits in int. Check for
2638 out-of-range doc string lengths.
2639 (read_list): Don't assume file position fits in int.
2640 (read_escape): Check for hex character overflow.
2642 2011-06-22 Leo Liu <sdl.web@gmail.com>
2644 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2645 Move to minibuffer.el.
2647 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2649 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2650 The following patches are for when GLYPH_DEBUG && !XASSERT.
2651 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2652 * dispnew.c (flush_stdout):
2653 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2654 Mark as externally visible.
2655 * dispnew.c (check_window_matrix_pointers): Now static.
2656 * dispnew.c (window_to_frame_vpos):
2657 * xfns.c (unwind_create_frame):
2658 * xterm.c (x_check_font): Remove unused local.
2659 * scroll.c (CHECK_BOUNDS):
2660 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2661 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2662 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2663 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2664 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2666 (debug_method_add): Use va_list and vsprintf rather than relying
2667 on undefined behavior with wrong number of arguments.
2668 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2669 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2670 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2671 since we're not interested in debugging glyphs with old libraries.
2672 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2673 GCC 4.6.0's static checking.
2675 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2677 Integer overflow and signedness fixes (Bug#8873).
2678 A few related buffer overrun fixes, too.
2680 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2682 * dispextern.h (struct face.stipple):
2683 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2684 (x_bitmap_mask, x_allocate_bitmap_record)
2685 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2686 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2687 (x_create_bitmap_from_xpm_data):
2688 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2689 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2691 * xfaces.c (load_pixmap):
2692 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2693 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2694 (.bitmaps_last, struct x_output.icon_bitmap):
2695 Use ptrdiff_t, not int, for bitmap indexes.
2696 (x_allocate_bitmap_record): Check for size overflow.
2697 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2699 Use ptrdiff_t, not int, for overlay counts.
2700 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2701 * editfns.c (overlays_around, get_pos_property):
2702 * textprop.c (get_char_property_and_overlay):
2703 * xdisp.c (next_overlay_change, note_mouse_highlight):
2704 * xfaces.c (face_at_buffer_position):
2705 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2706 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2707 (Fnext_overlay_change, Fprevious_overlay_change)
2708 (mouse_face_overlay_overlaps, Foverlays_in):
2709 Use ptrdiff_t, not int, for sizes.
2710 (overlays_at, overlays_in): Check for size-calculation overflow.
2712 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2714 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2715 (x_session_initialize): Do not assume string length fits in int.
2717 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2718 This is unlikely, but can occur if DPI is outlandish.
2720 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2721 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2723 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2724 * xrdb.c (magic_file_p, search_magic_path):
2725 Omit last arg SUFFIX; it was always 0. All callers changed.
2726 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2728 * xfont.c (xfont_match): Avoid need for strlen.
2730 * xfns.c: Don't assume strlen fits in int.
2731 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2733 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2734 not unsigned long, as we prefer signed integers. All callers changed.
2735 Detect integer overflow in repeat count.
2736 (message_dolog): Don't assume print length fits in 39 bytes.
2737 (display_mode_element): Don't assume strlen fits in int.
2739 * termcap.c: Don't assume sizes fit in int and never overflow.
2740 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2741 (gobble_line): Check for size-calculation overflow.
2743 * minibuf.c (Fread_buffer):
2744 * lread.c (intern, intern_c_string):
2745 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2746 Don't assume string length fits in int.
2748 * keyboard.c (parse_tool_bar_item):
2749 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2751 * font.c: Don't assume string length fits in int.
2752 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2753 Use ptrdiff_t, not int.
2754 (font_intern_prop): Don't assume string length fits in int.
2755 Don't assume integer property fits in fixnum.
2756 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2758 * filelock.c: Fix some buffer overrun and integer overflow issues.
2759 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2760 Reformulate so as not to need the command string.
2761 Invoke gzip -cd rather than gunzip, as it's more portable.
2762 (lock_info_type, lock_file_1, lock_file):
2763 Don't assume pid_t and time_t fit in unsigned long.
2764 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2765 (current_lock_owner): Prefer signed type for sizes.
2766 Use memcpy, not strncpy, where memcpy is what is really wanted.
2767 Don't assume (via atoi) that time_t and pid_t fit in int.
2768 Check for time_t and/or pid_t out of range, e.g., via a network share.
2769 Don't alloca where an auto var works fine.
2771 * fileio.c: Fix some integer overflow issues.
2772 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2773 Don't assume string length fits in int.
2774 (directory_file_name): Don't assume string length fits in long.
2775 (make_temp_name): Don't assume pid fits in int, or that its print
2776 length is less than 20.
2778 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2780 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2782 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2784 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2785 We prefer signed integers, even for size calculations.
2787 * emacs.c: Don't assume string length fits in 'int'.
2788 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2789 (main): Don't invoke strlen when not needed.
2791 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2792 (XD_DEBUG_MESSAGE): Don't waste a byte.
2794 * callproc.c (getenv_internal_1, getenv_internal)
2796 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2798 * lread.c (invalid_syntax): Omit length argument.
2799 All uses changed. This doesn't fix a bug, but it simplifies the
2800 code away from its former Hollerith-constant appearance, and it's
2801 one less 'int' to worry about when looking at integer-overflow issues.
2802 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2804 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2805 This didn't break anything, but it didn't help either.
2806 It's confusing to put a bogus integer in a place where the actual
2807 value does not matter.
2808 (LIST_END_P): Remove unused macro and its bogus comment.
2809 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2811 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2812 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2814 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2815 We prefer signed types, and the value cannot exceed the EMACS_INT
2816 range anyway (because otherwise the length would not be representable).
2817 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2818 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2819 This avoids a GCC warning when WIDE_EMACS_INT.
2821 * indent.c (sane_tab_width): New function.
2822 (current_column, scan_for_column, Findent_to, position_indentation)
2823 (compute_motion): Use it. This is just for clarity.
2824 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2826 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2828 * lisp.h (lint_assume): New macro.
2829 * composite.c (composition_gstring_put_cache):
2830 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2832 * editfns.c, insdel.c:
2833 Omit unnecessary forward decls, to simplify future changes.
2835 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2837 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2839 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2840 Use much-faster test for byte-length change.
2841 Don't assume string byte-length fits in 'int'.
2842 Check that character arg fits in 'int'.
2843 (mapcar1): Declare byte as byte, for clarity.
2845 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2847 * fns.c (concat): Catch string overflow earlier.
2848 Do not rely on integer wraparound.
2850 * dispextern.h (struct it.overlay_strings_charpos)
2851 (struct it.selective): Now EMACS_INT, not int.
2852 * xdisp.c (forward_to_next_line_start)
2853 (back_to_previous_visible_line_start)
2854 (reseat_at_next_visible_line_start, next_element_from_buffer):
2855 Don't arbitrarily truncate the value of 'selective' to int.
2857 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2859 * composite.c: Don't truncate sizes to 'int'.
2860 (composition_gstring_p, composition_reseat_it)
2861 (composition_adjust_point): Use EMACS_INT, not int.
2862 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2863 not EMACS_UINT, for indexes.
2865 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2867 * buffer.c: Include <verify.h>.
2868 (struct sortvec.priority, struct sortstr.priority):
2869 Now EMACS_INT, not int.
2870 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2871 (struct sortstr.size, record_overlay_string)
2872 (struct sortstrlist.size, struct sortlist.used):
2873 Don't truncate size to int.
2874 (record_overlay_string): Check for size-calculation overflow.
2875 (init_buffer_once): Check at compile-time, not run-time.
2877 2011-06-22 Jim Meyering <meyering@redhat.com>
2879 Don't leak an XBM-image-sized buffer
2880 * image.c (xbm_load): Free the image buffer after using it.
2882 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2885 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2886 that Sun C diagnosed.
2887 * fns.c (secure_hash): Fix pointer signedness issue.
2888 * intervals.c (static_offset_intervals): New function.
2889 (offset_intervals): Use it.
2891 2011-06-21 Leo Liu <sdl.web@gmail.com>
2894 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2897 * fns.c (secure_hash): Rename from crypto_hash_function and change
2898 the first arg to accept symbols.
2899 (Fsecure_hash): New primitive.
2900 (syms_of_fns): New symbols.
2902 2011-06-20 Deniz Dogan <deniz@dogan.se>
2904 * process.c (Fset_process_buffer): Clarify return value in
2907 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2909 * dispnew.c (add_window_display_history): Use BVAR.
2911 * xdisp.c (debug_method_add): Use BVAR.
2912 (check_window_end, dump_glyph_matrix, dump_glyph)
2913 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2915 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2918 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2919 check till after the cache is created in init_frame_faces.
2921 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2923 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2925 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2927 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2928 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2929 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2931 Improve buffer-overflow checking (Bug#8873).
2932 * fileio.c (Finsert_file_contents):
2933 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2934 Remove the old (too-loose) buffer overflow checks.
2935 They weren't needed, since make_gap checks for buffer overflow.
2936 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2937 The old code merely checked for Emacs fixnum overflow, and relied
2938 on undefined (wraparound) behavior. The new code avoids undefined
2939 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2941 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2942 Tune. Don't use wider integers than needed. Don't use alloca.
2943 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2945 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2947 * insdel.c, lisp.h (buffer_overflow): New function.
2948 (insert_from_buffer_1, replace_range, replace_range_2):
2949 * insdel.c (make_gap_larger):
2950 * editfns.c (Finsert_char):
2951 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2953 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2955 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2957 Integer overflow and signedness fixes (Bug#8873).
2959 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2960 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2962 * fileio.c: Don't assume EMACS_INT fits in off_t.
2963 (emacs_lseek): New static function.
2964 (Finsert_file_contents, Fwrite_region): Use it.
2965 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2967 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2969 * fns.c: Don't overflow int when computing a list length.
2970 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2971 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2972 truncation on 64-bit hosts. Check for QUIT every
2973 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2974 faster and is responsive enough.
2975 (Flength): Report an error instead of overflowing an integer.
2976 (Fsafe_length): Return a float if the value is not representable
2977 as a fixnum. This shouldn't happen except in contrived situations.
2978 (Fnthcdr, Fsort): Don't assume list length fits in int.
2979 (Fcopy_sequence): Don't assume vector length fits in int.
2981 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2982 (header_size, word_size): New constants.
2983 (allocate_vectorlike): Don't check size overflow here.
2984 (allocate_vector): Check it here instead, since this is the only
2985 caller of allocate_vectorlike that could cause overflow.
2986 Check that the new vector's length is representable as a fixnum.
2988 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2989 The previous code was bogus. For example, next_almost_prime (32)
2990 returned 39, which is undesirable as it is a multiple of 3; and
2991 next_almost_prime (24) returned 25, which is a multiple of 5 so
2992 why was the code bothering to check for multiples of 7?
2994 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2996 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2998 Variadic C functions now count arguments with ptrdiff_t.
2999 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3000 Back then I didn't know that the Emacs coding style prefers signed int.
3001 Also, in the meantime I found a few more instances where arguments
3002 were being counted with int, which may truncate counts on 64-bit
3003 machines, or EMACS_INT, which may be unnecessarily wide.
3004 * lisp.h (struct Lisp_Subr.function.aMANY)
3005 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3006 Arg counts are now ptrdiff_t, not size_t.
3007 All variadic functions and their callers changed accordingly.
3008 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3009 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3010 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3011 * callint.c (Fcall_interactively): Check arg count for overflow,
3012 to avoid potential buffer overrun. Use signed char, not 'int',
3013 for 'varies' array, so that we needn't bother to check its size
3014 calculation for overflow.
3015 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3016 * eval.c (apply_lambda):
3017 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3018 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3019 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3021 * callint.c (Fcall_interactively): Don't use index var as event count.
3023 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3024 * mem-limits.h (SIZE): Remove; no longer used.
3026 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3028 Remove unnecessary casts.
3029 * xterm.c (x_term_init):
3030 * xfns.c (x_set_border_pixel):
3031 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3032 These aren't needed now that we assume ANSI C.
3034 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3035 It's more likely to cause problems (due to unsigned overflow)
3038 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3040 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3042 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3044 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3046 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3048 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3050 GLYPH_CODE_FACE returns EMACS_INT, not int.
3051 * dispextern.h (merge_faces):
3052 * xfaces.c (merge_faces):
3053 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3054 Don't assume EMACS_INT fits in int.
3056 * character.h (CHAR_VALID_P): Remove unused parameter.
3057 * fontset.c, lisp.h, xdisp.c: All uses changed.
3059 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3061 * fns.c (concat): Minor tuning based on overflow analysis.
3062 This doesn't fix any bugs. Use int to hold character, instead
3063 of constantly refetching from Emacs object. Use XFASTINT, not
3064 XINT, for value known to be a character. Don't bother comparing
3065 a single byte to 0400, as it's always less.
3067 * floatfns.c (Fexpt):
3068 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3070 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3073 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3075 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3076 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3077 incorrectly succeed when S was a string, because 4294967386 was
3078 truncated before it was used.
3080 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3081 Otherwise, an out-of-range integer could cause undefined behavior
3084 * composite.c: Use int, not EMACS_INT, for characters.
3085 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3086 EMACS_INT, for values that are known to be in character range.
3087 This doesn't fix any bugs but is the usual style inside Emacs and
3088 may generate better code on 32-bit machines.
3090 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3091 This is for reasons similar to the recent CHAR_STRING fix.
3092 * charset.c (Fencode_char): Check that character arg is actually
3093 a character. Pass an int to ENCODE_CHAR.
3094 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3095 wider than 'int', as a compile-time check to prevent future regressions
3098 * character.c (char_string): Remove unnecessary casts.
3100 Make sure a 64-bit char is never passed to CHAR_STRING.
3101 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3102 by silently ignoring the top 32 bits, allowing some values
3103 that were far too large to be valid characters.
3104 * character.h: Include <verify.h>.
3105 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3106 arguments are no wider than unsigned, as a compile-time check
3107 to prevent future regressions in this area.
3109 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3110 (Fsubst_char_in_region):
3112 * xdisp.c (decode_mode_spec_coding):
3113 Adjust to CHAR_STRING's new requirement.
3114 * editfns.c (Finsert_char, Fsubst_char_in_region):
3115 * fns.c (concat): Check that character args are actually
3116 characters. Without this test, these functions did the wrong
3117 thing with wildly out-of-range values on 64-bit hosts.
3119 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3120 These casts should not be needed on 32-bit hosts, either.
3121 * keyboard.c (read_char):
3122 * lread.c (Fload): Remove casts to unsigned.
3124 * lisp.h (UNSIGNED_CMP): New macro.
3125 This fixes comparison bugs on 64-bit hosts.
3126 (ASCII_CHAR_P): Use it.
3127 * casefiddle.c (casify_object):
3128 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3129 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3130 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3131 * dispextern.h (FACE_FROM_ID):
3132 * keyboard.c (read_char): Use UNSIGNED_CMP.
3134 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3135 not to EMACS_INT, to avoid GCC warning.
3137 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3139 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3140 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3141 isn't needed on 32-bit machines.
3143 * buffer.c (Fgenerate_new_buffer_name):
3144 Use EMACS_INT for count, not int.
3145 (advance_to_char_boundary): Return EMACS_INT, not int.
3147 * data.c (Qcompiled_function): Now static.
3149 * window.c (window_body_lines): Now static.
3151 * image.c (gif_load): Rename local to avoid shadowing.
3153 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3154 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3155 * alloc.c (make_save_value): Integer argument is now of type
3157 (mark_object): Use ptrdiff_t, not int.
3158 * lisp.h (pD): New macro.
3159 * print.c (print_object): Use it.
3161 * alloc.c: Use EMACS_INT, not int, to count objects.
3162 (total_conses, total_markers, total_symbols, total_vector_size)
3163 (total_free_conses, total_free_markers, total_free_symbols)
3164 (total_free_floats, total_floats, total_free_intervals)
3165 (total_intervals, total_strings, total_free_strings):
3166 Now EMACS_INT, not int. All uses changed.
3167 (Fgarbage_collect): Compute overall total using a double, so that
3168 integer overflow is less likely to be a problem. Check for overflow
3169 when converting back to an integer.
3170 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3171 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3172 These were 'int' variables that could overflow on 64-bit hosts;
3173 they were never used, so remove them instead of repairing them.
3174 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3175 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3176 Previously, this ceilinged at INT_MAX, but that doesn't work on
3178 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3180 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3181 (allocate_vectorlike): Check for ptrdiff_t overflow.
3182 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3183 when a (possibly-narrower) signed value would do just as well.
3184 We prefer using signed arithmetic, to avoid comparison confusion.
3186 * alloc.c: Catch some string size overflows that we were missing.
3187 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3188 for convenience in STRING_BYTES_MAX.
3189 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3190 The definition here is exact; the one in lisp.h was approximate.
3191 (allocate_string_data): Check for string overflow. This catches
3192 some instances we weren't catching before. Also, it catches
3193 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3194 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3195 and ptrdiff_t and EMACS_INT are both 64 bits.
3197 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3198 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3199 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3201 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3203 * alloc.c (Fmake_string): Check for out-of-range init.
3205 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3207 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3209 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3211 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3212 xg_get_default_scrollbar_width.
3214 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3215 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3216 (style_changed_cb): Call update_theme_scrollbar_width and call
3217 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3218 all frames (Bug#8505).
3219 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3220 Call gtk_window_set_resizable if HAVE_GTK3.
3221 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3222 and height if HAVE_GTK3 (Bug#8505).
3223 (scroll_bar_width_for_theme): New variable.
3224 (update_theme_scrollbar_width): New function.
3225 (xg_get_default_scrollbar_width): Move code to
3226 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3227 (xg_initialize): Call update_theme_scrollbar_width.
3229 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3231 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3233 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3235 * frame.c (make_frame): Call other_buffer_safely instead of
3238 * window.c (temp_output_buffer_show): Call display_buffer with
3239 second argument Vtemp_buffer_show_specifiers and reset latter
3240 immediately after the call.
3241 (Vtemp_buffer_show_specifiers): New variable.
3242 (auto_window_vscroll_p, next_screen_context_lines)
3243 (Vscroll_preserve_screen_position): Remove leading asterisks from
3246 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3248 Fix minor problems found by GCC 4.6.0 static checking.
3249 * buffer.c (Qclone_number): Remove for now, as it's unused.
3250 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3251 (record_buffer): Remove unused local.
3252 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3253 (set_frame_buffer_list): Remove; unused.
3254 * frame.h (other_visible_frames): Remove decl.
3255 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3256 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3257 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3259 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3260 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3261 Define only if HAVE_GPM.
3262 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3263 (update_hints_inhibit): Remove; never set. All uses removed.
3264 * widgetprv.h (emacsFrameClassRec): Remove decl.
3265 * window.c (delete_deletable_window): Now returns void, since it
3266 wasn't returning anything.
3267 (compare_window_configurations): Remove unused locals.
3268 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3269 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3270 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3271 the same widths as pointers. This follows up on the 2011-05-06 patch.
3272 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3273 * xterm.h: Likewise.
3274 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3276 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3278 * makefile.w32-in: Update dependencies.
3279 (LISP_H): Add lib/intprops.h.
3281 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3283 * image.c (gif_load): Add animation frame delay to the metadata.
3284 (syms_of_image): Use DEFSYM. New symbol `delay'.
3286 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3288 * window.c (delete_deletable_window): Re-add.
3289 (Fset_window_configuration): Rewrite to handle dead buffers and
3290 consequently deletable windows.
3291 (window_tree, Fwindow_tree): Remove. Supply functionality in
3293 (compare_window_configurations): Simplify code.
3295 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3297 * image.c (imagemagick_load_image): Fix type mismatch.
3298 (Fimagemagick_types): Likewise.
3300 * window.h (replace_buffer_in_windows): Declare.
3302 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3304 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3305 Qclone_number. Remove external declaration of Qdelete_window.
3306 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3308 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3309 Run Qbuffer_list_update_hook if allowed.
3310 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3311 buffer list implementation.
3312 (other_buffer_safely): New function.
3313 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3314 calls to replace_buffer_in_windows and
3315 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3317 (record_buffer): Inhibit quitting and rewrite using quittable
3318 functions. Run Qbuffer_list_update_hook if allowed.
3319 (Frecord_buffer, Funrecord_buffer): New functions.
3320 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3321 Move switch-to-buffer to window.el.
3322 (bury-buffer): Move to window.el.
3323 (Vbuffer_list_update_hook): New variable.
3325 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3328 * window.h (resize_frame_windows): Move up in code.
3329 (Fwindow_frame): Remove EXFUN.
3330 (replace_buffer_in_all_windows): Remove prototype.
3331 (replace_buffer_in_windows_safely): Add prototype.
3333 * window.c: Declare Qdelete_window static again. Move down
3334 declaration of select_count.
3335 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3336 (Fother_window): Move to window.el.
3337 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3338 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3339 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3341 (replace_buffer_in_windows): Implement by calling
3342 Qreplace_buffer_in_windows.
3343 (replace_buffer_in_all_windows): Remove with some functionality
3344 moved into replace_buffer_in_windows_safely.
3345 (replace_buffer_in_windows_safely): New function.
3346 (select_window_norecord, select_frame_norecord): Move in front
3347 of run_window_configuration_change_hook. Remove now obsolete
3349 (Fset_window_buffer): Rewrite doc-string.
3350 Call Qrecord_window_buffer.
3351 (keys_of_window): Move binding for other-window to window.el.
3353 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3355 * dispextern.h (struct image): Replace data member, whose int_val
3356 and ptr_val fields were not used by anything, with a single
3359 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3360 (gif_clear_image, gif_load, imagemagick_load_image)
3361 (gs_clear_image, gs_load): Callers changed.
3363 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3365 * buffer.h: Include <time.h>, for time_t.
3366 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3368 Fix minor problems found by static checking.
3370 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3372 Make identifiers static if they are not used in other modules.
3373 * data.c (Qcompiled_function, Qframe, Qvector):
3374 * image.c (QimageMagick, Qsvg):
3375 * minibuf.c (Qmetadata):
3376 * window.c (resize_window_check, resize_root_window): Now static.
3377 * window.h (resize_window_check, resize_root_window): Remove decls.
3379 * window.c (window_deletion_count, delete_deletable_window):
3381 (window_body_lines): Now static.
3382 (Fdelete_other_windows_internal): Mark vars as initialized.
3383 Make sure 'resize_failed' is initialized.
3384 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3385 (resize_window_apply): Remove unused local.
3386 * window.h (delete_deletable_window): Remove decl.
3388 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3389 (imagemagick_load_image): Fix pointer signedness problem by changing
3390 last arg from unsigned char * to char *. All uses changed.
3391 Also, fix a local for similar reasons.
3392 Remove unused locals. Remove locals to avoid shadowing.
3393 (fn_rsvg_handle_free): Remove; unused.
3394 (svg_load, svg_load_image): Fix pointer signedness problem.
3395 (imagemagick_load_image): Don't use garbage pointer image_wand.
3397 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3399 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3401 * image.c (gif_load): Fix omitted cast error introduced by
3404 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3406 * window.h (resize_proportionally, orig_total_lines)
3407 (orig_top_line): Remove from window structure.
3408 (set_window_height, set_window_width, change_window_heights)
3409 (Fdelete_window): Remove prototypes.
3410 (resize_frame_windows): Remove duplicate declaration.
3412 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3414 * window.h (resize_frame_windows, resize_window_check)
3415 (delete_deletable_window, resize_root_window)
3416 (resize_frame_windows): Declare prototypes.
3418 * window.c (resize_window_apply): Make definition be "static" to
3419 match the prototype.
3421 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3423 * window.c: Remove declarations of Qwindow_size_fixed,
3424 window_min_size_1, window_min_size_2, window_min_size,
3425 size_window, window_fixed_size_p, enlarge_window, delete_window.
3426 Remove static from declaration of Qdelete_window, it's
3427 temporarily needed by Fbury_buffer.
3428 (replace_window): Don't assign orig_top_line and
3430 (Fdelete_window, delete_window): Remove. Window deletion is
3431 handled by window.el.
3432 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3433 Replace Fdelete_window calls with calls to Qdelete_window.
3434 (Fdelete_other_windows): Remove. Deleting other windows is
3435 handled by window.el.
3436 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3437 handled in window.el.
3438 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3439 Window minimum sizes are handled in window.el.
3440 (shrink_windows, size_window, set_window_height)
3441 (set_window_width, change_window_heights, window_height)
3442 (window_width, CURBEG, CURSIZE, enlarge_window)
3443 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3444 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3445 handled in window.el.
3446 (make_dummy_parent): Rename to make_parent_window and give it a
3447 second argument horflag.
3448 (make_window): Don't set resize_proportionally any more.
3449 (Fsplit_window): Remove. Windows are split in window.el.
3450 (save_restore_action, save_restore_orig_size)
3451 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3452 Resize mini windows in window.el.
3453 (grow_mini_window, shrink_mini_window): Implement by calling
3454 Qresize_root_window_vertically, resize_window_check and
3455 resize_window_apply.
3456 (saved_window, Fset_window_configuration, save_window_save):
3457 Do not handle orig_top_line, orig_total_lines, and
3458 resize_proportionally.
3459 (window_min_height, window_min_width): Move to window.el.
3460 (keys_of_window): Move bindings for delete-other-windows,
3461 split-window, delete-window and enlarge-window to window.el.
3463 * buffer.c: Temporarily extern Qdelete_window.
3464 (Fbury_buffer): Temporarily call Qdelete_window instead of
3465 Fdelete_window (Fbury_buffer will move to window.el soon).
3467 * frame.c (set_menu_bar_lines_1): Remove code handling
3468 orig_top_line and orig_total_lines.
3470 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3471 set_window_height but set heights directly.
3472 (change_frame_size_1): Use resize_frame_windows.
3474 * xdisp.c (init_xdisp): Don't use set_window_height but set
3477 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3478 Use resize_frame_windows instead of change_window_heights and run
3479 run_window_configuration_change_hook.
3481 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3482 instead of change_window_heights and run
3483 run_window_configuration_change_hook.
3485 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3487 * window.c (replace_window): Rename second argument REPLACEMENT to
3488 NEW. New third argument SETFLAG. Rewrite.
3489 (delete_window, make_dummy_parent): Call replace_window with
3491 (window_list_1): Move down in code.
3492 (run_window_configuration_change_hook): Move set_buffer part
3493 before select_frame_norecord part in order to unwind correctly.
3494 Rename count1 to count.
3495 (recombine_windows, delete_deletable_window, resize_root_window)
3496 (Fdelete_other_windows_internal)
3497 (Frun_window_configuration_change_hook, make_parent_window)
3498 (resize_window_check, resize_window_apply, Fresize_window_apply)
3499 (resize_frame_windows, Fsplit_window_internal)
3500 (Fdelete_window_internal, Fresize_mini_window_internal):
3502 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3504 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3506 * window.h (window): Add some new members to window structure -
3507 normal_lines, normal_cols, new_total, new_normal, clone_number,
3508 splits, nest, prev_buffers, next_buffers.
3509 (WINDOW_TOTAL_SIZE): Move here from window.c.
3510 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3512 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3514 (make_dummy_parent): Set new members of windows structure.
3515 (make_window): Move down in code. Handle new members of window
3517 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3518 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3519 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3520 (Fset_window_prev_buffers, Fwindow_next_buffers)
3521 (Fset_window_next_buffers, Fset_window_clone_number):
3523 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3524 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3526 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3527 Argument WINDOW can be now internal window too.
3528 (Fwindow_use_time): Move up in code.
3529 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3531 (Fset_window_configuration, saved_window)
3532 (Fcurrent_window_configuration, save_window_save): Handle new
3533 members of window structure.
3534 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3535 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3536 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3537 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3538 Qget_mru_window, Qresize_root_window,
3539 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3540 Qauto_buffer_name; staticpro them.
3542 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3544 * window.c (Fwindow_total_size, Fwindow_left_column)
3545 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3546 (Fwindow_list_1): New functions.
3547 (window_box_text_cols): Replace with window_body_cols.
3548 (Fwindow_width, Fscroll_left, Fscroll_right):
3549 Use window_body_cols instead of window_box_text_cols.
3550 (delete_window, Fset_window_configuration):
3551 Call delete_all_subwindows with window as argument.
3552 (delete_all_subwindows): Take a window as argument and not a
3554 (window_loop): Remove handling of GET_LRU_WINDOW and
3556 (Fget_lru_window, Fget_largest_window): Move to window.el.
3558 * window.h: Extern window_body_cols instead of
3559 window_box_text_cols. delete_all_subwindows now takes a
3560 Lisp_Object as argument.
3562 * indent.c (compute_motion, Fcompute_motion):
3563 Use window_body_cols instead of window_box_text_cols.
3565 * frame.c (delete_frame): Call delete_all_subwindows with root
3568 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3570 * fns.c (Fputhash): Document return value.
3572 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3574 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3576 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3578 Cons<->int and similar integer overflow fixes (Bug#8794).
3580 Check for overflow when converting integer to cons and back.
3581 * charset.c (Fdefine_charset_internal, Fdecode_char):
3582 Use cons_to_unsigned to catch overflow.
3583 (Fencode_char): Use INTEGER_TO_CONS.
3584 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3585 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3586 * data.c (long_to_cons, cons_to_long): Remove.
3587 (cons_to_unsigned, cons_to_signed): New functions.
3588 These signal an error for invalid or out-of-range values.
3589 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3590 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3591 * font.c (Ffont_variation_glyphs):
3592 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3593 * lisp.h: Include <intprops.h>.
3594 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3595 (cons_to_signed, cons_to_unsigned): New decls.
3596 (long_to_cons, cons_to_long): Remove decls.
3597 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3598 (Fprimitive_undo): Use CONS_TO_INTEGER.
3599 * xfns.c (Fx_window_property): Likewise.
3600 * xselect.c: Include <limits.h>.
3601 (x_own_selection, selection_data_to_lisp_data):
3602 Use INTEGER_TO_CONS.
3603 (x_handle_selection_request, x_handle_selection_clear)
3604 (x_get_foreign_selection, Fx_disown_selection_internal)
3605 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3606 (lisp_data_to_selection_data): Use cons_to_unsigned.
3607 (x_fill_property_data): Use cons_to_signed.
3608 Report values out of range.
3610 Check for buffer and string overflow more precisely.
3611 * buffer.h (BUF_BYTES_MAX): New macro.
3612 * lisp.h (STRING_BYTES_MAX): New macro.
3613 * alloc.c (Fmake_string):
3614 * character.c (string_escape_byte8):
3615 * coding.c (coding_alloc_by_realloc):
3616 * doprnt.c (doprnt):
3617 * editfns.c (Fformat):
3619 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3620 since they may not be the same number.
3621 * editfns.c (Finsert_char):
3622 * fileio.c (Finsert_file_contents):
3623 Likewise for BUF_BYTES_MAX.
3625 * image.c: Use ptrdiff_t, not int, for sizes.
3626 (slurp_file): Switch from int to ptrdiff_t.
3628 (slurp_file): Check that file size fits in both size_t (for
3629 malloc) and ptrdiff_t (for sanity and safety).
3631 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3632 if b->modtime has its maximal value.
3634 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3636 Don't assume time_t can fit into int.
3637 * buffer.h (struct buffer.modtime): Now time_t, not int.
3638 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3639 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3641 Minor fixes for signed vs unsigned integers.
3642 * character.h (MAYBE_UNIFY_CHAR):
3643 * charset.c (maybe_unify_char):
3644 * keyboard.c (read_char, reorder_modifiers):
3645 XINT -> XFASTINT, since the integer must be nonnegative.
3646 * ftfont.c (ftfont_spec_pattern):
3647 * keymap.c (access_keymap, silly_event_symbol_error):
3648 XUINT -> XFASTINT, since the integer must be nonnegative.
3649 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3650 since it makes no difference and we prefer signed.
3651 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3652 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3655 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3657 * window.h (Fwindow_frame): Declare.
3659 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3661 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3662 (SPARE_MEMORY): Always define.
3663 (LARGE_REQUEST): Remove.
3664 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3666 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3668 * lisp.h: Move EXFUNS for Fframe_root_window,
3669 Fframe_first_window and Fset_frame_selected_window to window.h.
3671 * window.h: Move EXFUNS for Fframe_root_window,
3672 Fframe_first_window and Fset_frame_selected_window here from
3675 * frame.c (Fwindow_frame, Fframe_first_window)
3676 (Fframe_root_window, Fframe_selected_window)
3677 (Fset_frame_selected_window): Move to window.c.
3678 (Factive_minibuffer_window): Move to minibuf.c.
3679 (Fother_visible_frames_p): New function.
3681 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3683 * window.c (decode_window, decode_any_window): Move up in code.
3684 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3685 (inhibit_frame_unsplittable): Remove unused variable.
3686 (Fwindow_buffer): Move up and rewrite doc-string.
3687 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3688 (Fwindow_prev): New functions.
3689 (Fwindow_frame): Move here from frame.c. Accept any window as
3691 (Fframe_root_window, Fframe_first_window)
3692 (Fframe_selected_window): Move here from frame.c. Accept frame
3693 or arbitrary window as argument. Update doc-strings.
3694 (Fminibuffer_window): Move up in code.
3695 (Fwindow_minibuffer_p): Move up in code and simplify.
3696 (Fset_frame_selected_window): Move here from frame.c.
3698 (Fselected_window, select_window, Fselect_window): Move up in
3699 code. Minor doc-string fixes.
3701 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3703 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3704 Do not assume that spare memory exists; that assumption is valid
3705 only if SYSTEM_MALLOC.
3706 (LARGE_REQUEST): New macro, so that the issue of large requests
3707 is separated from the issue of spare memory.
3709 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3711 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3714 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3716 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3719 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3721 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3723 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3725 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3726 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3728 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3730 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3732 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3734 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3735 (x_clipboard_manager_save): Add return value.
3736 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3738 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3739 Obey Vx_select_enable_clipboard_manager. Catch errors in
3740 x_clipboard_manager_save (Bug#8779).
3741 (Vx_select_enable_clipboard_manager): New variable.
3742 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3744 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3746 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3748 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3750 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3751 in the current matrix if keep_current_p is non-zero.
3753 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3755 * bidi.c (bidi_level_of_next_char): Fix last change.
3757 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3759 Support bidi reordering of text covered by display properties.
3761 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3762 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3763 (bidi_cache_search, bidi_cache_iterator_state)
3764 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3765 (bidi_level_of_next_char, bidi_move_to_visually_next):
3766 Support character positions inside a run of characters covered by a
3768 (bidi_paragraph_init, bidi_resolve_explicit_1)
3769 (bidi_level_of_next_char): Call bidi_fetch_char and
3770 bidi_fetch_char_advance instead of FETCH_CHAR and
3772 (bidi_init_it): Initialize new members.
3773 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3775 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3776 instead of using explicit *_CHAR codes.
3777 (bidi_resolve_explicit, bidi_resolve_weak):
3778 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3779 bidirectional text is supported only in multibyte buffers.
3780 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3781 it to initialize the frame_window_p member of struct bidi_it.
3782 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3783 (bidi_resolve_explicit, bidi_resolve_weak)
3784 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3785 bidi_it->nchars is non-positive.
3786 (bidi_level_of_next_char): Don't try to lookup the cache for the
3787 next/previous character if nothing is cached there yet, or if we
3788 were just reseat()'ed to a new position.
3790 * xdisp.c (set_cursor_from_row): Set start and stop points
3791 according to the row's direction when priming the loop that looks
3792 for the glyph on which to display cursor.
3793 (single_display_spec_intangible_p): Function deleted.
3794 (display_prop_intangible_p): Reimplement to call
3795 handle_display_spec instead of single_display_spec_intangible_p.
3796 Accept 3 additional arguments needed by handle_display_spec.
3797 This fixes incorrect cursor motion across display property with complex
3798 values: lists, `(when COND...)' forms, etc.
3799 (single_display_spec_string_p): Support property values that are
3800 lists with the argument STRING its top-level element.
3801 (display_prop_string_p): Fix the condition for processing a
3802 property that is a list to be consistent with handle_display_spec.
3803 (handle_display_spec): New function, refactored from the
3804 last portion of handle_display_prop.
3805 (compute_display_string_pos): Accept additional argument
3806 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3807 value of a `display' property is a "replacing spec".
3808 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3809 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3810 the display property, but just return a value indicating whether
3811 the display property will replace the characters it covers.
3812 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3813 frame_window_p members of struct bidi_it.
3814 (compute_display_string_pos, compute_display_string_end):
3816 (push_it): Accept second argument POSITION, where pop_it should
3817 jump to continue iteration.
3818 (reseat_1): Initialize bidi_it.disp_pos.
3820 * keyboard.c (adjust_point_for_property): Adjust the call to
3821 display_prop_intangible_p to its new signature.
3823 * dispextern.h (struct bidi_it): New member frame_window_p.
3824 (bidi_init_it): Update prototypes.
3825 (display_prop_intangible_p): Update prototype.
3826 (compute_display_string_pos, compute_display_string_end):
3828 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3831 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3833 Malloc failure behavior now depends on size of allocation.
3834 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3835 * lisp.h: Change signatures accordingly.
3836 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3837 All callers changed. (Bug#8762)
3839 * gnutls.c: Use Emacs's memory allocators.
3840 Without this change, the gnutls library would invoke malloc etc.
3841 directly, which causes problems on non-SYNC_INPUT hosts, and which
3842 runs afoul of improving memory_full behavior. (Bug#8761)
3843 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3844 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3845 xfree instead of the default malloc, realloc, free.
3846 (Fgnutls_boot): No need to check for memory allocation failure,
3847 since xmalloc does that for us.
3849 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3850 * category.c (hash_get_category_set):
3851 * ccl.c (ccl_driver):
3852 * charset.c (Fdefine_charset_internal):
3853 * charset.h (struct charset.hash_index):
3854 * composite.c (get_composition_id, gstring_lookup_cache)
3855 (composition_gstring_put_cache):
3856 * composite.h (struct composition.hash_index):
3857 * dispextern.h (struct image.hash):
3858 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3859 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3860 (hashfn_equal, hashfn_user_defined, make_hash_table)
3861 (maybe_resize_hash_table, hash_lookup, hash_put)
3862 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3863 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3864 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3865 * image.c (make_image, search_image_cache, lookup_image)
3866 (xpm_put_color_table_h):
3867 * lisp.h (struct Lisp_Hash_Table):
3868 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3869 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3871 * alloc.c (allocate_vectorlike):
3872 Check for overflow in vector size calculations.
3873 * ccl.c (ccl_driver):
3874 Check for overflow when converting EMACS_INT to int.
3875 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3876 need to be updated by these changes.
3877 * fns.c (make_hash_table, maybe_resize_hash_table):
3878 Check for integer overflow with large hash tables.
3879 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3880 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3881 (SXHASH_REDUCE): New macro.
3882 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3883 Use it instead of discarding useful hash info with large hash values.
3884 (sxhash_float): New function.
3885 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3886 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3887 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3888 Rewrite to use FIXNUM_BITS, as this simplifies things.
3889 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3890 Adjust signatures to match updated version of code.
3891 (consing_since_gc): Now EMACS_INT, since a single hash table can
3892 use more than INT_MAX bytes.
3894 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3896 Make it possible to build with GCC-4.6+ -O2 -flto.
3898 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3900 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3902 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3903 Call minibuffer-inactive-mode.
3905 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3907 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3908 Update dependencies.
3910 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3912 * data.c (init_data): Remove code for UTS, this system is not
3915 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3917 Don't force ./temacs to start in terminal mode.
3919 * frame.c (make_initial_frame): Initialize faces in all cases, not
3920 only when CANNOT_DUMP is defined.
3921 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3923 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3925 * dispnew.c (add_window_display_history): Use const for the string
3926 pointer. Remove declaration, not needed.
3928 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3930 Use 'inline', not 'INLINE'.
3931 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3932 * alloc.c, fontset.c (INLINE): Remove.
3933 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3934 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3935 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3936 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3937 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3939 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3941 Make it possible to run ./temacs.
3943 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3944 syms_of_callproc does the same thing. Remove test for
3945 "initialized", do it in the caller.
3946 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3948 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3950 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3951 (read_minibuf): Use get_minibuffer.
3952 (syms_of_minibuf): Use DEFSYM.
3953 (Qmetadata): New var.
3954 * data.c (Qbuffer): Don't make it static.
3955 (syms_of_data): Use DEFSYM.
3957 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3959 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3960 (CCL_CODE_MIN): New macro.
3962 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3964 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3966 * eval.c (Qdebug): Now static.
3967 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3968 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3969 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3971 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3973 * image.c: Various fixes to ImageMagick code comments.
3974 (Fimagemagick_types): Doc fix.
3976 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3978 Minor fixes prompted by GCC 4.6.0 warnings.
3980 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3982 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3983 (x_clipboard_manager_save_all): Move extern decl to ...
3984 * xterm.h: ... here, so that it can be checked for consistency.
3986 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3988 * xselect.c (x_clipboard_manager_save_frame)
3989 (x_clipboard_manager_save_all): New functions.
3990 (Fx_clipboard_manager_save): Lisp function deleted.
3992 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3993 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3995 * xterm.h: Update prototype.
3997 2011-05-28 William Xu <william.xwl@gmail.com>
3999 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4002 2011-05-28 Jim Meyering <meyering@redhat.com>
4004 Avoid a sign-extension bug in crypto_hash_function.
4005 * fns.c (to_uchar): Define.
4006 (crypto_hash_function): Use it to convert some newly-signed
4007 variables to unsigned, to avoid sign-extension bugs. For example,
4008 without this change, (md5 "truc") would evaluate to
4009 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4010 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4011 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4013 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4015 Integer overflow fixes.
4017 * dbusbind.c: Serial number integer overflow fixes.
4018 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4019 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4020 to hold a serial number that is too large for a fixnum.
4021 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4022 Check for serial numbers out of range. Decode any serial number
4023 that was so large that it became a float. (Bug#8722)
4025 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4026 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4027 Use XFASTINT rather than XUINT when numbers are nonnegative.
4028 (xd_append_arg, Fdbus_method_return_internal):
4029 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4030 arguments, check that Lisp number is nonnegative, rather than
4031 silently wrapping negative numbers around. (Bug#8722)
4032 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4035 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4037 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4039 ccl: add integer overflow checks
4040 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4041 (IN_INT_RANGE): New macros.
4042 (ccl_driver): Use them to check for integer overflow when
4043 decoding a CCL program. Many of the new checks are whether XINT (x)
4044 fits in int; it doesn't always, on 64-bit hosts. The new version
4045 doesn't catch all possible integer overflows, but it's an
4046 improvement. (Bug#8719)
4048 * alloc.c (make_event_array): Use XINT, not XUINT.
4049 There's no need for unsigned here.
4051 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4052 This follows up to the 2011-05-06 change that substituted uintptr_t
4053 for EMACS_INT. This case wasn't caught back then.
4055 Rework Fformat to avoid integer overflow issues.
4056 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4057 now (part of C89). Include <verify.h>.
4058 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4059 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4060 (Fformat): Avoid the prepass trying to compute sizes; it was only
4061 approximate and thus did not catch overflow reliably. Instead, walk
4062 through the format just once, formatting and computing sizes as we go,
4063 checking for integer overflow at every step, and allocating a larger
4064 buffer as needed. Keep track separately whether the format is
4065 multibyte. Keep only the most-recently calculated precision, rather
4066 than them all. Record whether each argument has been converted to
4067 string. Use EMACS_INT, not int, for byte and char and arg counts.
4068 Support field widths and precisions larger than INT_MAX. Avoid
4069 sprintf's undefined behavior with conversion specifications such as %#d
4070 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4071 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4072 formatting out-of-range floating point numbers with int
4075 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4077 * data.c: Avoid integer truncation in expressions involving floats.
4078 * data.c: Include <intprops.h>.
4079 (arith_driver): When there's an integer overflow in an expression
4080 involving floating point, convert the integers to floating point
4081 so that the resulting value does not suffer from catastrophic
4082 integer truncation. For example, on a 64-bit host (* 4
4083 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4084 Do not rely on undefined behavior after integer overflow.
4086 merge count_size_as_multibyte, parse_str_to_multibyte
4087 * character.c, character.h (count_size_as_multibyte):
4088 Rename from parse_str_to_multibyte; all uses changed.
4089 Check for integer overflow.
4090 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4091 since it's now a duplicate of the other. This is more of
4092 a character than a buffer op, so better that it's in character.c.
4093 * fns.c, print.c: Adjust to above changes.
4095 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4097 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4099 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4101 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4102 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4103 (x_clipboard_manager_save): Now static.
4104 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4106 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4107 (crypto_hash_function): Now static.
4108 Fix pointer signedness problems. Avoid unnecessary initializations.
4110 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4112 * termhooks.h (Vselection_alist): Make it terminal-local.
4114 * terminal.c (create_terminal): Initialize it.
4116 * xselect.c: Support for clipboard managers.
4117 (Vselection_alist): Move to termhooks.h as terminal-local var.
4118 (LOCAL_SELECTION): New macro.
4119 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4120 (symbol_to_x_atom): Remove gratuitous arg.
4121 (x_handle_selection_request, lisp_data_to_selection_data)
4122 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4123 (x_own_selection, x_get_local_selection, x_convert_selection):
4124 New arg, specifying work frame. Use terminal-local Vselection_alist.
4125 (some_frame_on_display): Delete unused function.
4126 (Fx_own_selection_internal, Fx_get_selection_internal)
4127 (Fx_disown_selection_internal, Fx_selection_owner_p)
4128 (Fx_selection_exists_p): New optional frame arg.
4129 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4130 (x_handle_selection_clear): Don't treat other terminals with the
4131 same keyboard specially. Use the terminal-local Vselection_alist.
4132 (x_clear_frame_selections): Use Frun_hook_with_args.
4134 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4136 * xterm.h: Add support for those atoms.
4138 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4140 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4141 (converted_selections, conversion_fail_tag): New global variables.
4142 (x_selection_request_lisp_error): Free the above.
4143 (x_get_local_selection): Remove unnecessary code.
4144 (x_reply_selection_request): Args changed; handle arbitrary array
4145 of converted selections stored in converted_selections.
4146 Separate the XChangeProperty and SelectionNotify steps.
4147 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4148 (x_convert_selection): New function.
4149 (x_handle_selection_event): Simplify.
4150 (x_get_foreign_selection): Don't ignore incoming requests while
4151 waiting for an answer; this will fail when we implement
4152 SAVE_TARGETS, and seems unnecessary anyway.
4153 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4154 (Vx_sent_selection_functions): Doc fix.
4156 2011-05-26 Leo Liu <sdl.web@gmail.com>
4158 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4160 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4162 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4164 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4165 for fringe update if it has periodic bitmap.
4166 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4167 and fringe_bitmap_periodic_p.
4169 * fringe.c (get_fringe_bitmap_data): New function.
4170 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4171 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4172 row. Mark glyph row for fringe update if periodicity changed.
4174 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4175 for fringe update unless it has periodic bitmap.
4177 2011-05-25 Kenichi Handa <handa@m17n.org>
4179 * xdisp.c (get_next_display_element): Set correct it->face_id for
4180 a static composition.
4182 2011-05-24 Leo Liu <sdl.web@gmail.com>
4185 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4187 * fns.c (crypto_hash_function, Fsha1): New function.
4188 (Fmd5): Use crypto_hash_function.
4189 (syms_of_fns): Add Ssha1.
4191 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4193 * gnutls.c: Remove unused macros.
4194 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4195 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4196 Remove macros that are defined and never used.
4197 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4199 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4201 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4202 (Fx_get_selection_internal): Minor cleanup.
4203 (Fx_own_selection_internal): Rename arguments for consistency with
4206 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4208 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4210 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4212 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4214 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4216 * dispnew.c (scrolling_window): Don't exclude the case that the
4217 last enabled row in the desired matrix touches the bottom boundary.
4219 2011-05-21 Glenn Morris <rgm@gnu.org>
4221 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4222 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4223 and add some more files.
4225 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4227 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4228 report_file_error introduced by the change from 2011-05-07.
4230 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4232 * systime.h (Time): Define only if emacs is defined.
4233 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4234 where the include path doesn't have X11/X.h by default. See
4235 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4237 2011-05-20 Kenichi Handa <handa@m17n.org>
4239 * composite.c (find_automatic_composition): Fix previous change.
4241 2011-05-20 Glenn Morris <rgm@gnu.org>
4243 * lisp.mk: New file, split from Makefile.in.
4244 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4245 (shortlisp): Remove.
4246 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4248 2011-05-19 Glenn Morris <rgm@gnu.org>
4250 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4251 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4252 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4253 (lisp): Set the order to that of loadup.el.
4254 (shortlisp): Make it a copy of $lisp.
4255 (SOME_MACHINE_LISP): Remove.
4256 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4257 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4259 2011-05-18 Kenichi Handa <handa@m17n.org>
4261 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4262 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4263 (find_automatic_composition): Mostly rewrite for efficiency.
4265 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4267 * makefile.w32-in: Update dependencies.
4269 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4271 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4272 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4274 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4276 Fix some integer overflow issues, such as string length overflow.
4278 * insdel.c (count_size_as_multibyte): Check for string overflow.
4280 * character.c (lisp_string_width): Check for string overflow.
4281 Use EMACS_INT, not int, for string indexes and lengths; in
4282 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4283 the resulting string length overflows an EMACS_INT; instead,
4284 report a string overflow if no precision given. When checking for
4285 precision exhaustion, use a check that cannot possibly have
4286 integer overflow. (Bug#8675)
4287 * character.h (lisp_string_width): Adjust to new signature.
4289 * alloc.c (string_overflow): New function.
4290 (Fmake_string): Use it. This doesn't change behavior, but saves
4291 a few bytes and will simplify future changes.
4292 * character.c (string_escape_byte8): Likewise.
4293 * lisp.h (string_overflow): New decl.
4295 Fixups, following up to the user-interface timestamp change.
4296 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4297 for UI timestamps, instead of unsigned long.
4298 * msdos.c (mouse_get_pos): Likewise.
4299 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4300 * w32gui.h (Time): Define by including "systime.h" rather than by
4301 declaring it ourselves. (Bug#8664)
4303 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4304 * image.c (clear_image_cache): Likewise.
4306 * term.c (term_mouse_position): Don't assume time_t wraparound.
4308 Be more systematic about user-interface timestamps.
4309 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4310 and sometimes 'EMACS_UINT', to represent these timestamps.
4311 This change causes it to use 'Time' uniformly, as that's what X uses.
4312 This makes the code easier to follow, and makes it easier to catch
4313 integer overflow bugs such as Bug#8664.
4314 * frame.c (Fmouse_position, Fmouse_pixel_position):
4315 Use Time, not unsigned long, for user-interface timestamps.
4316 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4317 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4318 * keyboard.h (last_event_timestamp): Likewise.
4319 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4320 * menu.h (xmenu_show): Likewise.
4321 * term.c (term_mouse_position): Likewise.
4322 * termhooks.h (struct input_event.timestamp): Likewise.
4323 (struct terminal.mouse_position_hook): Likewise.
4324 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4325 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4326 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4327 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4329 * menu.h, termhooks.h: Include "systime.h", for Time.
4331 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4332 Don't assume that the difference between two unsigned long values
4333 can fit into an integer. At this point, we know button_down_time
4334 <= event->timestamp, so the difference must be nonnegative, so
4335 there's no need to cast the result if double-click-time is
4336 nonnegative, as it should be; check that it's nonnegative, just in
4337 case. This bug is triggered when events are more than 2**31 ms
4338 apart (about 25 days). (Bug#8664)
4340 * xselect.c (last_event_timestamp): Remove duplicate decl.
4341 (x_own_selection): Remove needless cast to unsigned long.
4343 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4344 that always fit in int. Use a sentinel instead of a counter, to
4345 avoid a temp and to allay GCC's concerns about possible int overflow.
4346 * frame.h (struct frame): Use int for menu_bar_items_used
4347 instead of EMACS_INT, since it always fits in int.
4349 * menu.c (grow_menu_items): Check for int overflow.
4351 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4353 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4354 Before, the code was not consistent. These values cannot exceed
4355 2**31 - 1 so there's no need to make them unsigned.
4356 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4357 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4358 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4360 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4362 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4363 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4364 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4365 presumably because the widths might not match.
4367 * window.c (size_window): Avoid needless test at loop start.
4369 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4371 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4373 2011-05-12 Drew Adams <drew.adams@oracle.com>
4375 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4377 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4379 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4380 `width' to `bar_area_x' and `bar_area_width', respectively.
4381 (x_scroll_run): Take account of fringe background extension.
4383 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4384 Rename local vars `left' and `width' to `bar_area_x' and
4385 `bar_area_width', respectively.
4386 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4387 background extension.
4389 2011-05-10 Jim Meyering <meyering@redhat.com>
4391 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4393 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4395 * image.c (Finit_image_library): Return t for built-in image types,
4396 like pbm and xbm. (Bug#8640)
4398 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4400 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4402 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4404 * w32console.c (Fset_screen_color): Doc fix.
4405 (Fget_screen_color): New function.
4406 (syms_of_ntterm): Defsubr it.
4408 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4409 unlink the temporary file if Fcall_process didn't create it in the
4411 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4412 child process will be redirected to a file specified with `:file'.
4413 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4414 cue to call_process_cleanup not to close that handle.
4416 2011-05-07 Ben Key <bkey76@gmail.com>
4418 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4419 one of two shell specific rules, either bootstrap-temacs-CMD or
4420 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4421 to the previous implementation of the bootstrap-temacs rule.
4422 The bootstrap-temacs-CMD rule is similar to the previous
4423 implementation of the bootstrap-temacs rule except that it
4424 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4427 These changes, along with some changes to nt/configure.bat,
4428 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4429 earlier fix to add support for --cflags and --ldflags options
4430 that include quotes so that it works whether make uses cmd or
4433 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4435 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4436 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4438 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4439 a string. Handle both cases.
4440 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4441 (Fdbus_register_method): Use Qinvalid_function.
4443 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4445 * makefile.w32-in: Update dependencies.
4446 (LISP_H): Add inttypes.h and stdin.h.
4447 (PROCESS_H): Add unistd.h.
4449 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4451 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4452 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4454 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4456 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4458 * term.c (vfatal): Remove stray call to va_end.
4459 It's not needed and the C Standard doesn't allow it here anyway.
4461 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4462 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4464 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4467 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4469 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4471 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4473 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4475 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4477 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4478 * charset.c (Fdefine_charset_internal): Don't initialize
4479 charset.code_space[15]. The value was garbage, on hosts with
4480 32-bit int (Bug#8600).
4482 * lread.c (read_integer): Be more consistent with string-to-number.
4483 Use string_to_number to do the actual conversion; this avoids
4484 rounding errors and fixes some other screwups. Without this fix,
4485 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4486 (digit_to_number): Move earlier, for benefit of read_integer.
4487 Return -1 if the digit is out of range for the base, -2 if it is
4488 not a digit in any supported base. (Bug#8602)
4490 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4492 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4493 to match comment at start of function. This also removes a
4494 GCC warning about overflow in a 32+64-bit port.
4496 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4498 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4499 Reported by Stefan Monnier in
4500 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4501 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4502 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4504 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4505 (EMACS_UINTPTR): Likewise, with uintptr_t.
4507 * lisp.h: Prefer 64-bit EMACS_INT if available.
4508 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4509 on 32-bit hosts that have 64-bit int, so that they can access
4511 However, temporarily disable this change unless the temporary
4512 symbol WIDE_EMACS_INT is defined.
4514 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4516 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4517 This removes an assumption that EMACS_INT and long are the same
4518 width as pointers. The assumption is true for Emacs porting targets
4519 now, but we want to make other targets possible.
4520 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4521 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4522 In the rest of the code, change types of integers that hold casted
4523 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4524 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4525 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4526 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4527 No need to cast type when ORing.
4528 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4529 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4530 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4531 assume EMACS_INT is the same width as char *.
4532 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4533 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4534 Remove no-longer-needed casts.
4535 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4536 (xg_tool_bar_help_callback, xg_make_tool_item):
4537 Use EMACS_INTPTR to hold an integer
4538 that will be cast to void *; this can avoid a GCC warning
4539 if EMACS_INT is not the same width as void *.
4540 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4541 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4542 (current_message_1, set_message_1):
4543 Use a local to convert to proper width without a cast.
4544 * xmenu.c (dialog_selection_callback): Likewise.
4546 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4547 Also, don't assume VALBITS / RAND_BITS is less than 5,
4548 and don't rely on undefined behavior when shifting a 1 left into
4550 * lisp.h (get_random): Change signature to match.
4552 * lread.c (hash_string): Use size_t, not int, for hash computation.
4553 Normally we prefer signed values; but hashing is special, because
4554 it's better to use unsigned division on hash table sizes so that
4555 the remainder is nonnegative. Also, size_t is the natural width
4556 for hashing into memory. The previous code used 'int', which doesn't
4557 retain enough info to hash well into very large tables.
4558 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4560 * dbusbind.c: Don't possibly lose pointer info when converting.
4561 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4562 Use XPNTR rather than XHASH, so that the high-order bits of
4563 the pointer aren't lost when converting through void *.
4565 * eval.c (Fautoload): Don't double-shift a pointer.
4567 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4569 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4571 * gnutls.c (DEF_GNUTLS_FN):
4572 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4574 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4576 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4579 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4581 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4582 New version that can reserve upto 2GB of heap space.
4584 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4586 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4588 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4590 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4591 `gnutls_certificate_set_x509_key_file'.
4593 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4595 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4596 Update dependencies.
4598 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4600 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4601 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4602 Remove unused parameter `fildes'.
4603 * process.c (read_process_output, send_process): Don't pass it.
4605 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4607 Fix previous change: the library cache is defined in w32.c.
4608 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4609 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4611 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4613 Implement dynamic loading of GnuTLS on Windows.
4615 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4616 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4617 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4620 * gnutls.c (Qgnutls_dll): Define.
4621 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4622 (gnutls_*): Declare function pointers.
4623 (init_gnutls_functions): New function to initialize function pointers.
4624 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4625 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4626 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4627 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4628 (emacs_gnutls_write, emacs_gnutls_read)
4629 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4630 (Fgnutls_available_p): New function.
4631 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4632 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4633 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4635 * image.c: Include w32.h.
4636 (Vimage_type_cache): Delete.
4637 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4638 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4639 (w32_delayed_load): Move to w32.c.
4641 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4643 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4644 (w32_delayed_load): Move from image.c. When loading a library, record
4645 its filename in the :loaded-from property of the library id.
4646 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4647 Initialize and staticpro them.
4648 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4650 * process.c: Include lisp.h before w32.h, not after.
4651 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4652 instead of gnutls_record_check_pending.
4654 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4656 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4658 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4659 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4662 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4664 * xterm.c (x_set_frame_alpha): Do not set property on anything
4665 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4667 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4669 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4671 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4673 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4674 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4675 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4676 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4677 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4678 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4679 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4680 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4681 (Qgnutls_bootprop_callbacks_verify): Make static.
4683 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4685 * callproc.c: Indentation fixup.
4687 * sysdep.c (wait_for_termination_1): Make static.
4688 (wait_for_termination, interruptible_wait_for_termination):
4689 Move after wait_for_termination_1.
4691 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4693 * sysdep.c (interruptible_wait_for_termination): New function
4694 which is like wait_for_termination, but allows keyboard
4697 * callproc.c (Fcall_process): Add (:file "file") as an option for
4699 (Fcall_process_region): Ditto.
4701 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4703 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4704 rather than `XVECTOR (FOO)->size'.
4706 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4707 inttypes.h, as a gnulib replacement is used if it not available in
4710 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4712 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4713 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4714 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4716 * coding.c (coding_alloc_by_realloc): Error out if destination
4717 will grow beyond MOST_POSITIVE_FIXNUM.
4718 (decode_coding_emacs_mule): Abort if there isn't enough place in
4719 charbuf for the composition carryover bytes. Reserve an extra
4720 space for up to 2 characters produced in a loop.
4721 (decode_coding_iso_2022): Abort if there isn't enough place in
4722 charbuf for the composition carryover bytes.
4724 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4726 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4727 aborting when %lld or %lll format is passed.
4728 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4729 %llo or %llx format is passed. (Bug#8545)
4731 * window.c (window_scroll_line_based): Use a marker instead of
4732 simple variables to record original value of point. (Bug#7952)
4734 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4735 produced by %s or %c overflows available buffer space. (Bug#8545)
4737 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4739 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4740 (SIZE_MAX): Move defn after all includes, as they might #define it.
4742 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4744 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4746 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4748 * keyboard.c (Qdelayed_warnings_hook): Define.
4749 (command_loop_1): Run `delayed-warnings-hook'
4750 if Vdelayed_warnings_list is non-nil.
4751 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4752 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4754 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4756 * doprnt.c (doprnt): Don't return value smaller than the buffer
4757 size if the message was truncated. (Bug#8545).
4759 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4761 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4762 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4764 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4766 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4768 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4770 * makefile.w32-in: Update dependencies.
4772 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4774 Improve `doprnt' and its usage. (Bug#8545)
4775 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4776 `format_end'. Remove support for %l as a conversion specifier.
4777 Don't use xrealloc. Improve diagnostics when the %l size modifier
4778 is used. Update the commentary.
4780 * eval.c (verror): Simplify calculation of size_t.
4782 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4785 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4787 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4790 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4792 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4793 This makes this file independent of the recent pseudovector change.
4795 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4797 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4799 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4800 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4801 Remove unused local.
4802 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4804 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4805 GCC 4.6.0 optimizes based on type-based alias analysis.
4806 For example, if b is of type struct buffer * and v of type struct
4807 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4808 != &v->size, and therefore "v->size = 1; b->size = 2; return
4809 v->size;" must therefore return 1. This assumption is incorrect
4810 for Emacs, since it type-puns struct Lisp_Vector * with many other
4811 types. To fix this problem, this patch adds a new type struct
4812 vectorlike_header that documents the constraints on layout of vectors
4813 and pseudovectors, and helps optimizing compilers not get fooled
4814 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4815 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4816 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4818 (XSETPVECTYPE): Rewrite in terms of new macro.
4819 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4820 This is a bit clearer, and further avoids the possibility of
4821 undesirable aliasing.
4822 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4823 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4824 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4825 since Lisp_Subr is a special case (no "next" field).
4826 (ASIZE): Now uses header.size rather than size.
4827 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4828 to avoid the hassle of writing XVECTOR (foo)->header.size.
4829 (struct vectorlike_header): New type.
4830 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4831 object, to help avoid aliasing.
4832 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4833 (SUBRP): Likewise, since Lisp_Subr is a special case.
4834 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4835 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4836 (struct Lisp_Hash_Table): Combine first two members into a single
4837 struct vectorlike_header member. All uses of "size" and "next" members
4838 changed to be "header.size" and "header.next".
4839 * buffer.h (struct buffer): Likewise.
4840 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4841 * frame.h (struct frame): Likewise.
4842 * process.h (struct Lisp_Process): Likewise.
4843 * termhooks.h (struct terminal): Likewise.
4844 * window.c (struct save_window_data, struct saved_window): Likewise.
4845 * window.h (struct window): Likewise.
4846 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4847 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4848 * buffer.c (init_buffer_once): Likewise.
4849 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4851 * process.c (Fformat_network_address): Use local var for size,
4854 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4856 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4857 * data.c (atof): Remove decl; no longer used or needed.
4858 (digit_to_number): Move to lread.c.
4859 (Fstring_to_number): Use new string_to_number function, to be
4860 consistent with how the Lisp reader treats infinities and NaNs.
4861 Do not assume that floating-point numbers represent EMACS_INT
4862 without losing information; this is not true on most 64-bit hosts.
4863 Avoid double-rounding errors, by insisting on integers when
4864 parsing non-base-10 numbers, as the documentation specifies.
4865 * lisp.h (string_to_number): New decl, replacing ...
4866 (isfloat_string): Remove.
4867 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4868 (read1): Do not accept +. and -. as integers; this
4869 appears to have been a coding error. Similarly, do not accept
4870 strings like +-1e0 as floating point numbers. Do not report
4871 overflow for integer overflows unless the base is not 10 which
4872 means we have no simple and reliable way to continue.
4873 Break out the floating-point parsing into a new
4874 function string_to_number, so that Fstring_to_number parses
4875 floating point numbers consistently with the Lisp reader.
4876 (digit_to_number): Move here from data.c. Make it static inline.
4877 (E_CHAR, EXP_INT): Remove, replacing with ...
4878 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4879 (string_to_number): New function, replacing isfloat_string.
4880 This function checks for valid syntax and produces the resulting
4881 Lisp float number too. Rework it so that string-to-number
4882 no longer mishandles examples like "1.0e+". Use strtoumax,
4883 so that overflow for non-base-10 numbers is reported only when
4884 there's no portable and simple way to convert to floating point.
4886 * textprop.c (set_text_properties_1): Rewrite for clarity,
4887 and to avoid GCC warning about integer overflow.
4889 * intervals.h (struct interval): Use EMACS_INT for members
4890 where EMACS_UINT might cause problems. See
4891 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4892 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4893 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4895 (offset_intervals): Tell GCC not to worry about length overflow
4896 when negating a negative length.
4898 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4899 (overrun_check_free): Likewise.
4901 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4902 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4905 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4906 (gnutls_make_error): Rename local to avoid shadowing.
4907 (gnutls_emacs_global_deinit): ifdef out; not used.
4908 (Fgnutls_boot): Use const for pointer to readonly storage.
4909 Comment out unused local. Fix pointer signedness problems.
4911 * lread.c (openp): Don't stuff size_t into an 'int'.
4912 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4913 about possible signed overflow.
4915 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4916 (GDK_KEY_g): Don't define if already defined.
4917 (xg_prepare_tooltip): Avoid pointer signedness problem.
4918 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4920 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4921 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4923 * xfns.c (Fx_window_property): Simplify a bit,
4924 to make a bit faster and to avoid GCC 4.6.0 warning.
4925 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4927 * fns.c (internal_equal): Don't assume size_t fits in int.
4929 * alloc.c (compact_small_strings): Tighten assertion a little.
4931 Replace pEd with more-general pI, and fix some printf arg casts.
4932 * lisp.h (pI): New macro, generalizing old pEd macro to other
4933 conversion specifiers. For example, use "...%"pI"d..." rather
4934 than "...%"pEd"...".
4935 (pEd): Remove. All uses replaced with similar uses of pI.
4936 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4937 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4938 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4939 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4940 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4941 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4942 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4944 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4945 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4946 * print.c (safe_debug_print, print_object): Likewise.
4947 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4949 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4950 avoiding the 0 flag, which is not portable.
4951 * process.c (Fmake_network_process): Use pI to avoid cast.
4952 * region-cache.c (pp_cache): Likewise.
4953 * xdisp.c (decode_mode_spec): Likewise.
4954 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4955 behavior on 64-bit hosts with printf arg.
4956 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4957 (x_stop_queuing_selection_requests): Likewise.
4958 (x_get_window_property): Don't truncate byte count to an 'int'
4961 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4962 here, since it parses constructs like leading '-' and spaces,
4963 which are not wanted; and it overflows with large numbers.
4964 Instead, simply match F[0-9]+, which is what is wanted anyway.
4966 * alloc.c: Remove unportable assumptions about struct layout.
4967 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4968 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4969 (allocate_vectorlike, make_pure_vector): Use the new macros,
4970 plus offsetof, to remove unportable assumptions about struct layout.
4971 These assumptions hold on all porting targets that I know of, but
4972 they are not guaranteed, they're easy to remove, and removing them
4973 makes further changes easier.
4975 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4976 This doesn't fix a bug but makes the code clearer.
4977 (string_overrun_cookie): Now const. Use initializers that
4978 don't formally overflow signed char, to avoid warnings.
4979 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4980 can cause Emacs to crash when string overrun checking is enabled.
4981 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4982 multiple of sizeof (EMACS_INT); it need not be, if
4983 alignof(EMACS_INT) < sizeof (EMACS_INT).
4984 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4986 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4988 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4990 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4992 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4993 supposed to be handshaking. (Bug#8556)
4994 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4996 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4998 * lisp.h (Qdebug): List symbol.
4999 * eval.c (Qdebug): Restore global linkage.
5000 * keyboard.c (debug-on-event): New variable.
5001 (handle_user_signal): Break into debugger when debug-on-event
5002 matches the current signal symbol.
5004 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5006 * alloc.c (check_sblock, check_string_bytes)
5007 (check_string_free_list): Convert to standard C.
5009 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5011 * w32.c (emacs_gnutls_push): Fix typo.
5013 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5015 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5016 "cast to pointer from integer of different size".
5018 Improve doprnt and its use in verror. (Bug#8545)
5019 * doprnt.c (doprnt): Document the set of format control sequences
5020 supported by the function. Use SAFE_ALLOCA instead of always
5023 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5024 is one byte too soon. Don't use xrealloc; instead xfree and
5027 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5029 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5032 * gnutls.c: Renamed global_initialized to
5033 gnutls_global_initialized. Added internals for the
5034 :verify-hostname-error, :verify-error, and :verify-flags
5035 parameters of `gnutls-boot' and documented those parameters in the
5036 docstring. Start callback support.
5037 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5038 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5039 on error. Return error code.
5040 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5041 (emacs_gnutls_read): Likewise.
5042 (Fgnutls_boot): Return handshake error code.
5043 (emacs_gnutls_handle_error): New function.
5044 (wsaerror_to_errno): Likewise.
5046 * w32.h (emacs_gnutls_pull): Add prototype.
5047 (emacs_gnutls_push): Likewise.
5049 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5050 (emacs_gnutls_push): Likewise.
5052 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5054 * process.c (wait_reading_process_output): Check if GnuTLS
5055 buffered some data internally if no FDs are set for TLS
5058 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5059 (LIBS): Link to USER_LIBS.
5060 ($(BLD)/gnutls.$(0)): New target.
5062 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5064 * xdisp.c (handle_single_display_spec): Rename the
5065 display_replaced_before_p argument into display_replaced_p, to
5066 make it consistent with the commentary. Fix typos in the
5069 * textprop.c (syms_of_textprop): Remove dead code.
5070 (copy_text_properties): Delete obsolete commentary about an
5071 interface that was deleted long ago. Fix typos in the description
5074 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5075 to changes in oldXMenu/XMenu.h from 2011-04-16.
5076 <menu_help_message, prev_menu_help_message>: Constify.
5077 (IT_menu_make_room): menu->help_text is now `const char **';
5080 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5081 to changes in oldXMenu/XMenu.h from 2011-04-16.
5082 (struct XMenu): Declare `help_text' `const char **'.
5084 * xfaces.c <Qunspecified>: Make extern again.
5086 * syntax.c: Include sys/types.h before including regex.h, as
5089 * doc.c (get_doc_string): Improve the format passed to `error'.
5091 * doprnt.c (doprnt): Improve commentary.
5093 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5095 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5098 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5099 changes in globals.h immediately force recompilation.
5100 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5101 $(CURDIR)/s/ms-w32.h.
5102 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5104 * character.c (Fchar_direction): Function deleted.
5105 (syms_of_character): Don't defsubr it.
5106 <char-direction-table>: Deleted.
5108 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5110 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5111 * doprnt.c: Include limits.h.
5112 (SIZE_MAX): New macro.
5113 (doprnt): Return a size_t value. 2nd arg is now size_t.
5114 Many local variables are now size_t instead of int or unsigned.
5115 Improve overflow protection. Support `l' modifier for integer
5116 conversions. Support %l conversion. Don't assume an EMACS_INT
5117 argument for integer conversions and for %c.
5119 * lisp.h (doprnt): Restore prototype.
5121 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5124 * Makefile.in (base_obj): Add back doprnt.o.
5126 * deps.mk (doprnt.o): Add back prerequisites.
5127 (callint.o): Depend on character.h.
5129 * eval.c (internal_lisp_condition_case): Include the handler
5130 representation in the error message.
5131 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5132 when breaking from the loop.
5134 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5136 * callint.c (Fcall_interactively): When displaying error message
5137 about invalid control letter, pass the character's codepoint, not
5138 a pointer to its multibyte form. Improve display of the character
5139 in octal and display also its hex code.
5141 * character.c (char_string): Use %x to display the (unsigned)
5142 codepoint of an invalid character, to avoid displaying a bogus
5145 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5146 `error', not SYMBOL_NAME itself.
5148 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5149 character arguments to `error'.
5151 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5152 to `error' in error message about FINAL_CHAR argument. Make sure
5153 FINAL_CHAR is a character, and use %c when it is passed as
5154 argument to `error'.
5156 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5158 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5160 * w32.c: Include <time.h>.
5161 (sys_localtime): New function.
5163 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5165 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5167 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5169 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5171 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5174 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5176 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5177 gl_state.e_property when gl_state.object is Qt.
5179 * insdel.c (make_gap_larger): Remove limitation of buffer size
5182 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5184 * xdisp.c (lookup_glyphless_char_display)
5185 (produce_glyphless_glyph): Handle cons cell entry in
5186 glyphless-char-display.
5187 (Vglyphless_char_display): Document it.
5189 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5190 glyphless-char-display.
5192 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5194 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5196 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5198 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5199 definition for no-X builds.
5201 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5203 Static checks with GCC 4.6.0 and non-default toolkits.
5205 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5207 * process.c (keyboard_bit_set): Define only if SIGIO.
5208 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5209 (send_process): Repair possible setjmp clobbering.
5211 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5213 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5215 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5217 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5218 Define only if needed.
5220 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5221 by pacifying GCC about it. Maybe it's time to retire it?
5222 * xfaces.c (USG, __TIMEVAL__): Likewise.
5224 * dispextern.h (struct redisplay_interface): Rename param
5226 * termhooks.h (struct terminal): Likewise.
5227 * xterm.c (xembed_send_message): Likewise.
5229 * insdel.c (make_gap_smaller): Define only if
5230 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5232 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5235 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5236 so that we aren't warned about unused symbols.
5238 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5240 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5242 * xfns.c (x_real_positions): Mark locals as initialized.
5244 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5246 * xterm.c: Fix problems found by static analysis with other toolkits.
5247 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5248 (x_dispatch_event): Declare static if USE_GTK, and
5249 define if USE_GTK || USE_X_TOOLKIT.
5250 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5251 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5252 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5253 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5255 * xmenu.c (menu_help_callback): Pointer type fixes.
5256 Use const pointers when pointing at readonly data. Avoid pointer
5258 (FALSE): Remove unused macro.
5259 (update_frame_menubar): Remove unused decl.
5261 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5263 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5264 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5265 (single_menu_item): Rename local to avoid shadowing.
5267 * keyboard.c (make_lispy_event): Remove unused local var.
5269 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5270 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5272 * bitmaps: Change bitmaps from unsigned char back to the X11
5273 compatible char. Avoid the old compiler warnings about
5274 out-of-range initializers by using, for example, '\xab' rather
5277 * xgselect.c (xgselect_initialize): Check vs interface
5278 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5280 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5282 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5283 to read-only memory.
5285 * fns.c (vector): Remove; this old hack is no longer needed.
5287 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5289 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5291 * xrdb.c (x_load_resources): Omit unused local.
5293 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5294 (x_window): Rename locals to avoid shadowing.
5295 (USG): Use the kludged USG macro, to pacify gcc.
5297 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5298 (x_term_init): Remove local to avoid shadowing.
5300 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5302 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5303 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5305 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5307 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5309 Fix regex.c, syntax.c and friends for buffers > 2GB.
5310 * syntax.h (struct gl_state_s): Declare character position members
5313 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5315 * textprop.c (verify_interval_modification, interval_of):
5316 Declare arguments EMACS_INT.
5318 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5321 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5323 * indent.c (Fvertical_motion): Local variable it_start is now
5326 * regex.c (re_match, re_match_2, re_match_2_internal)
5327 (bcmp_translate, regcomp, regexec, print_double_string)
5328 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5329 (re_compile_pattern, re_exec): Declare arguments and local
5330 variables `size_t' and `ssize_t' and return values `regoff_t', as
5332 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5333 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5334 <compile_stack_type>: `size' and `avail' are now `size_t'.
5336 * regex.h <regoff_t>: Use ssize_t, not int.
5337 (re_search, re_search_2, re_match, re_match_2): Arguments that
5338 specify buffer/string position and length are now ssize_t and
5339 size_t. Return type is regoff_t.
5341 2011-04-16 Ben Key <bkey76@gmail.com>
5343 * nsfont.m: Fixed bugs in ns_get_family and
5344 ns_descriptor_to_entity that were caused by using free to
5345 deallocate memory blocks that were allocated by xmalloc (via
5346 xstrdup). This caused Emacs to crash when compiled with
5347 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5348 --enable-checking=xmallocoverrun). xfree is now used to
5349 deallocate these memory blocks.
5351 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5353 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5355 emacs_write: Accept and return EMACS_INT for sizes.
5356 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5358 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5359 Accept and return EMACS_INT.
5360 (emacs_gnutls_write): Return the number of bytes written on
5362 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5363 (emacs_read, emacs_write): Remove check for negative size, as the
5364 Emacs source code has been audited now.
5365 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5366 (emacs_read, emacs_write): Use it.
5367 * process.c (send_process): Adjust to the new signatures of
5368 emacs_write and emacs_gnutls_write. Do not attempt to store
5369 a byte offset into an 'int'; it might overflow.
5370 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5372 * sound.c: Don't assume sizes fit in 'int'.
5373 (struct sound_device.period_size, alsa_period_size):
5374 Return EMACS_INT, not int.
5375 (struct sound_device.write, vox_write, alsa_write):
5376 Accept EMACS_INT, not int.
5377 (wav_play, au_play): Use EMACS_INT to store sizes and to
5378 record read return values.
5380 2011-04-15 Ben Key <bkey76@gmail.com>
5382 * keyboard.c (Qundefined): Don't declare static since it is used
5384 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5385 static since they are used in nsfont.m.
5387 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5389 * process.c (Qprocessp): Don't declare static.
5390 * lisp.h (Qprocessp): Declare again.
5392 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5394 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5396 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5398 Improve C-level modularity by making more things 'static'.
5400 Don't publish debugger-only interfaces to other modules.
5401 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5402 (verify_bytepos, count_markers): Move decls to the only modules
5404 * region-cache.h (pp_cache): Likewise.
5405 * window.h (check_all_windows): Likewise.
5406 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5408 * sysdep.c (croak): Now static, if
5409 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5410 * syssignal.h (croak): Declare only if not static.
5412 * alloc.c (refill_memory_reserve): Now static if
5413 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5414 * lisp.h (refill_memory_reserve): Declare only if not static.
5416 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5417 Define only if USE_LUCID.
5419 * xrdb.c (x_customization_string, x_rm_string): Now static.
5421 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5422 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5424 * xdisp.c (draw_row_with_mouse_face): Now static.
5425 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5427 * window.h (check_all_windows): Mark externally visible.
5429 * window.c (window_deletion_count): Now static.
5431 * undo.c: Make symbols static if they're not exported.
5432 (last_undo_buffer, last_boundary_position, pending_boundary):
5435 * textprop.c (interval_insert_behind_hooks): Now static.
5436 (interval_insert_in_front_hooks): Likewise.
5438 * term.c: Make symbols static if they're not exported.
5439 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5440 (max_frame_lines, tty_set_terminal_modes):
5441 (tty_reset_terminal_modes, tty_turn_off_highlight):
5442 (get_tty_terminal): Now static.
5443 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5444 * termhooks.h (term_mouse_moveto): Do not declare if
5446 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5447 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5449 * sysdep.c: Make symbols static if they're not exported.
5450 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5452 (sigprocmask_set, full_mask): Remove; unused.
5453 (wait_debugging): Mark as visible.
5454 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5455 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5457 * syntax.c (syntax_temp): Define only if !__GNUC__.
5459 * sound.c (current_sound_device, current_sound): Now static.
5461 * search.c (searchbufs, searchbuf_head): Now static.
5463 * scroll.c (scroll_cost): Remove; unused.
5464 * dispextern.h (scroll_cost): Remove decl.
5466 * region-cache.h (pp_cache): Mark as externally visible.
5468 * process.c: Make symbols static if they're not exported.
5469 (process_tick, update_tick, create_process, chan_process):
5470 (Vprocess_alist, proc_buffered_char, datagram_access):
5471 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5472 (deactivate_process): Mark defn as static, as well as decl.
5473 * lisp.h (create_process): Remove decl.
5474 * process.h (chan_process, Vprocess_alist): Remove decls.
5476 * print.c: Make symbols static if they're not exported.
5477 (print_depth, new_backquote_output, being_printed, print_buffer):
5478 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5479 (print_interval, print_number_index, initial_stderr_stream):
5481 * lisp.h (Fprinc): Remove decl.
5482 (debug_output_compilation_hack): Mark as externally visible.
5484 * sysdep.c (croak): Move decl from here to syssignal.h.
5485 * syssignal.h (croak): Put it here, so the API can be checked when
5486 'croak' is called from dissociate_if_controlling_tty.
5488 * minibuf.c: Make symbols static if they're not exported.
5489 (minibuf_save_list, choose_minibuf_frame): Now static.
5490 * lisp.h (choose_minibuf_frame): Remove decl.
5492 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5494 * lread.c: Make symbols static if they're not exported.
5495 (read_objects, initial_obarray, oblookup_last_bucket_number):
5497 (make_symbol): Remove; unused.
5498 * lisp.h (initial_obarray, make_symbol): Remove decls.
5500 * keyboard.c: Make symbols static if they're not exported.
5501 (single_kboard, recent_keys_index, total_keys, recent_keys):
5502 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5503 (this_single_command_key_start, echoing, last_auto_save):
5504 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5505 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5506 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5507 (Vlispy_mouse_stem, double_click_count):
5509 (force_auto_save_soon): Define only if SIGDANGER.
5510 (ignore_mouse_drag_p): Now static if
5511 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5512 (print_help): Remove; unused.
5513 (stop_character, last_timer_event): Mark as externally visible.
5514 * keyboard.h (ignore_mouse_drag_p): Declare only if
5515 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5516 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5517 * lisp.h (echoing): Remove decl.
5518 (force_auto_save_soon): Declare only if SIGDANGER.
5519 * xdisp.c (redisplay_window): Simplify code, to make it more
5520 obvious that ignore_mouse_drag_p is not accessed if !defined
5521 USE_GTK && !defined HAVE_NS.
5523 * intervals.c: Make symbols static if they're not exported.
5524 (merge_properties_sticky, merge_interval_right, delete_interval):
5526 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5528 * insdel.c: Make symbols static if they're not exported.
5529 However, leave prepare_to_modify_buffer alone. It's never
5530 called from outside this function, but that appears to be a bug.
5531 (combine_after_change_list, combine_after_change_buffer):
5532 (adjust_after_replace, signal_before_change): Now static.
5533 (adjust_after_replace_noundo): Remove; unused.
5534 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5535 (signal_before_change): Remove decls.
5537 * indent.c (val_compute_motion, val_vmotion): Now static.
5539 * image.c: Make symbols static if they're not exported.
5540 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5542 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5543 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5545 * fringe.c (standard_bitmaps): Now static.
5546 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5548 * frame.c: Make symbols static if they're not exported.
5549 (x_report_frame_params, make_terminal_frame): Now static.
5550 (get_frame_param): Now static, unless HAVE_NS.
5551 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5552 (x_get_resource_string): Remove; not used.
5553 * frame.h (make_terminal_frame, x_report_frame_params):
5554 (x_get_resource_string); Remove decls.
5555 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5556 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5558 * font.c, fontset.c: Make symbols static if they're not exported.
5559 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5560 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5561 * font.c (font_close_object): Now static.
5562 * font.h (font_close_object): Remove.
5563 * fontset.c (FONTSET_OBJLIST): Remove.
5564 (free_realized_fontset) #if-0 the body, which does nothing.
5565 (face_suitable_for_char_p): #if-0, as it's never called.
5566 * fontset.h (face_suitable_for_char_p): Remove decl.
5567 * xfaces.c (face_at_string_position):
5568 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5569 since 0 is always ASCII.
5571 * fns.c (weak_hash_tables): Now static.
5573 * fileio.c: Make symbols static if they're not exported.
5574 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5575 (Vwrite_region_annotation_buffers): Now static.
5577 * eval.c: Make symbols static if they're not exported.
5578 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5579 * lisp.h (backtrace_list): Remove decl.
5581 * emacs.c: Make symbols static if they're not exported.
5582 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5583 (fatal_error_code, fatal_error_signal_hook, standard_args):
5585 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5586 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5587 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5588 * lisp.h (fatal_error_signal_hook): Remove decl.
5589 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5591 * editfns.c: Move a (normally-unused) function to its only use.
5592 * editfns.c, lisp.h (get_operating_system_release): Remove.
5593 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5594 worth the hassle of breaking this out.
5596 * xterm.c: Make symbols static if they're not exported.
5597 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5598 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5599 (x_destroy_window, x_delete_display):
5601 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5602 (x_mouse_leave): Remove; unused.
5603 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5604 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5605 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5607 (x_mouse_leave): Declare only if WINDOWSNT.
5608 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5609 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5612 * ftxfont.c: Make symbols static if they're not exported.
5613 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5615 * font.h (ftxfont_driver): Likewise.
5617 * xfns.c: Make symbols static if they're not exported.
5618 (x_last_font_name, x_display_info_for_name):
5619 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5620 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5621 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5622 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5623 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5624 (last_show_tip_args): Now static.
5625 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5626 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5627 (x_screen_planes): Remove; unused.
5628 * dispextern.h (x_screen_planes): Remove decl.
5630 * dispnew.c: Make symbols static if they're not exported.
5631 * dispextern.h (redraw_garbaged_frames, scrolling):
5632 (increment_row_positions): Remove.
5633 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5634 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5636 (redraw_garbaged_frames): Remove; unused.
5638 * xfaces.c: Make symbols static if they're not exported.
5639 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5641 * xterm.h (defined_color): Remove decls.
5642 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5643 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5644 (menu_face_changed_default, defined_color, free_realized_face):
5645 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5646 (ascii_face_of_lisp_face): Remove; unused.
5648 * xdisp.c: Make symbols static if they're not exported.
5649 * dispextern.h (scratch_glyph_row, window_box_edges):
5650 (glyph_to_pixel_coords, set_cursor_from_row):
5651 (get_next_display_element, set_iterator_to_next):
5652 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5653 (show_mouse_face): Remove decls
5654 * frame.h (message_buf_print): Likewise.
5655 * lisp.h (pop_message, set_message, check_point_in_composition):
5657 * xterm.h (set_vertical_scroll_bar): Likewise.
5658 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5659 (message_buf_print, scratch_glyph_row, displayed_buffer):
5660 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5661 (get_next_display_element, show_mouse_face, window_box_edges):
5662 (frame_to_window_pixel_xy, check_point_in_composition):
5663 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5664 (glyph_to_pixel_coords): Remove; unused.
5666 * dired.c (file_name_completion): Now static.
5668 * dbusbind.c (xd_in_read_queued_messages): Now static.
5670 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5671 * data.c (circular_list_error): Remove.
5673 * commands.h (last_point_position, last_point_position_buffer):
5674 (last_point_position_window): Remove decls.
5675 * keyboard.c: Make these variables static.
5677 * coding.h (coding, code_convert_region, encode_coding_gap):
5679 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5680 (iso_code_class, detect_coding, code_convert_region): Now static.
5681 (encode_coding_gap): Remove; unused.
5683 * chartab.c (chartab_chars, chartab_bits): Now static.
5685 * charset.h (charset_iso_8859_1): Remove decl.
5686 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5689 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5690 * ccl.c (Vccl_program_table): Now static.
5691 (check_ccl_update): Remove; unused.
5693 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5694 * category.h: ... from here.
5695 * category.c (check_category_table, set_category_set): Now static.
5697 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5698 * lisp.h: Remove these decls.
5700 * buffer.c (buffer_count): Remove unused var.
5702 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5703 so that it's not optimized away.
5704 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5705 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5706 exported only to the debugger.
5708 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5709 * atimer.h (run_all_atimers): Remove; not exported.
5711 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5712 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5713 was inaccessible from Lisp.
5714 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5715 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5717 alloc.c: Import and export fewer symbols, and remove unused items.
5718 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5720 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5721 it's not optimized away by whole-program optimization.
5722 (message_enable_multibyte, free_misc): Remove.
5723 (catchlist, handlerlist, mark_backtrace):
5724 Declare only if BYTE_MARK_STACK.
5725 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5726 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5727 (message_enable_multibyte): Remove decl.
5728 (free_misc, interval_free_list, float_block, float_block_index):
5729 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5730 (cons_free_list, last_marked_index):
5732 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5733 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5734 (mark_backtrace): Define only if BYTE_MARK_STACK.
5735 * xdisp.c (message_enable_multibyte): Now static.
5737 Declare Lisp_Object Q* variables to be 'static' if not exported.
5738 This makes it easier for human readers (and static analyzers)
5739 to see whether these variables are used from other modules.
5740 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5741 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5742 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5743 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5744 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5745 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5746 * xmenu.c, xselect.c:
5747 Declare Q* vars static if they are not used in other modules.
5748 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5749 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5750 Remove decls of unexported vars.
5751 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5753 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5755 Make Emacs functions such as Fatom 'static' by default.
5756 This makes it easier for human readers (and static analyzers)
5757 to see whether these functions can be called from other modules.
5758 DEFUN now defines a static function. To make the function external
5759 so that it can be used in other C modules, use the new macro DEFUE.
5760 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5761 (Finit_image_library):
5762 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5763 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5764 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5765 Remove decls, since these functions are now static.
5766 (Funintern, Fget_internal_run_time): New decls, since these functions
5767 were already external.
5769 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5770 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5771 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5772 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5773 * keyboard.c, keymap.c, lread.c:
5774 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5775 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5776 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5777 Mark functions with DEFUE instead of DEFUN,
5778 if they are used in other modules.
5779 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5780 decls for now-static functions.
5781 * buffer.h (Fdelete_overlay): Remove decl.
5782 * callproc.c (Fgetenv_internal): Mark as internal.
5783 * composite.c (Fremove_list_of_text_properties): Remove decl.
5784 (Fcomposition_get_gstring): New forward static decl.
5785 * composite.h (Fcomposite_get_gstring): Remove decl.
5786 * dired.c (Ffile_attributes): New forward static decl.
5787 * doc.c (Fdocumntation_property): New forward static decl.
5788 * eval.c (Ffetch_bytecode): New forward static decl.
5789 (Funintern): Remove extern decl; now in .h file where it belongs.
5790 * fileio.c (Fmake_symbolic_link): New forward static decl.
5791 * image.c (Finit_image_library): New forward static decl.
5792 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5793 * intervals.h (Fprevious_property_change):
5794 (Fremove_list_of_text_properties): Remove decls.
5795 * keyboard.c (Fthis_command_keys): Remove decl.
5796 (Fcommand_execute): New forward static decl.
5797 * keymap.c (Flookup_key): New forward static decl.
5798 (Fcopy_keymap): Now static.
5799 * keymap.h (Flookup_key): Remove decl.
5800 * process.c (Fget_process): New forward static decl.
5801 (Fprocess_datagram_address): Mark as internal.
5802 * syntax.c (Fsyntax_table_p): New forward static decl.
5803 (skip_chars): Remove duplicate decl.
5804 * textprop.c (Fprevious_property_change): New forward static decl.
5805 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5807 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5808 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5810 * editfns.c (Fformat): Remove unreachable code.
5812 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5814 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5817 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5819 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5820 when at ZV. (Bug#8487)
5822 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5824 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5826 * keyboard.c (parse_tool_bar_item): Likewise.
5827 * sound.c (sound_cleanup, alsa_close): Likewise.
5828 * termcap.c (tgetent): Likewise.
5829 * xfns.c (x_default_font_parameter): Likewise.
5830 * xsettings.c (read_and_apply_settings): Likewise.
5832 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5833 (overrun_check_free): Protoize.
5835 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5837 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5838 since callers should never pass a negative size.
5839 Change the signature to match that of plain 'read' and 'write'; see
5840 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5841 * lisp.h: Update prototypes of emacs_write and emacs_read.
5843 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5845 * xdisp.c (redisplay_window): Don't try to determine the character
5846 position of the scroll margin if the window start point w->startp
5847 is outside the buffer's accessible region. (Bug#8468)
5849 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5851 Fix write-region and its subroutines for buffers > 2GB.
5852 * fileio.c (a_write, e_write): Modify declaration of arguments and
5853 local variables to support buffers larger than 2GB.
5854 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5856 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5857 argument, local variables, and return value.
5859 * lisp.h: Update prototypes of emacs_write and emacs_read.
5861 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5863 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5865 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5867 Fix more problems found by GCC 4.6.0's static checks.
5869 * xdisp.c (vmessage): Use a better test for character truncation.
5871 * charset.c (load_charset_map): <, not <=, for optimization,
5872 and to avoid potential problems with integer overflow.
5873 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5874 * casetab.c (set_identity, shuffle): Likewise.
5875 * editfns.c (Fformat): Likewise.
5876 * syntax.c (skip_chars): Likewise.
5878 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5879 This also lets GCC 4.6.0 generate slightly better loop code.
5881 * callint.c (Fcall_interactively): <, not <=, for optimization.
5882 (Fcall_interactively): Count the number of arguments produced,
5883 not the number of arguments given. This is simpler and lets GCC
5884 4.6.0 generate slightly better code.
5886 * ftfont.c: Distingish more carefully between FcChar8 and char.
5887 The previous code passed unsigned char * to a functions like
5888 strlen and xstrcasecmp that expect char *, which does not
5889 conform to the C standard.
5890 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5891 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5892 char * when the C standard requires it.
5894 * keyboard.c (read_char): Remove unused var.
5896 * eval.c: Port to Windows vsnprintf (Bug#8435).
5898 (SIZE_MAX): Define if the headers do not.
5899 (verror): Do not give up if vsnprintf returns a negative count.
5900 Instead, grow the buffer. This ports to Windows vsnprintf, which
5901 does not conform to C99. Problem reported by Eli Zaretskii.
5902 Also, simplify the allocation scheme, by avoiding the need for
5903 calling realloc, and removing the ALLOCATED variable.
5905 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5907 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5908 But keep the doprint source code for now, as we might revamp it
5909 and use it again (Bug#8435).
5910 * lisp.h (doprnt): Remove.
5911 * Makefile.in (base_obj): Remove doprnt.o.
5912 * deps.mk (doprnt.o): Remove.
5914 error: Print 32- and 64-bit integers portably (Bug#8435).
5915 Without this change, on typical 64-bit hosts error ("...%d...", N)
5916 was used to print both 32- and 64-bit integers N, which relied on
5918 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5920 * lisp.h (error, verror): Mark as printf-like functions.
5921 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5922 Report overflow in size calculations when allocating printf buffer.
5923 Do not truncate output string at its first null byte.
5924 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5925 Truncate the output at a character boundary, since vsnprintf does not
5927 * charset.c (check_iso_charset_parameter): Convert internal
5928 character to string before calling 'error', since %c now has the
5930 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5931 overflow when computing char to be passed to 'error'. Do not
5932 pass Lisp_Object to 'error'; pass the integer instead.
5933 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5934 formatted with plain %d.
5936 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5938 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5940 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5942 * xterm.c (x_catch_errors): Remove duplicate declaration.
5944 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5946 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5948 2011-04-10 Jim Meyering <meyering@redhat.com>
5950 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5951 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5952 return ssize_t not "int", and use size_t as the buffer length.
5953 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5954 * gnutls.h: Update declarations.
5955 * process.c (read_process_output): Use ssize_t, to match.
5956 (send_process): Likewise.
5958 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5960 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5962 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5964 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5965 Use unsigned char, to match FcChar8 type definition.
5967 * xterm.c (handle_one_xevent):
5968 * xmenu.c (create_and_show_popup_menu):
5969 * xselect.c (x_decline_selection_request)
5970 (x_reply_selection_request): Avoid type-punned deref of X events.
5972 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5974 Fix some uses of `int' instead of EMACS_INT.
5975 * search.c (string_match_1, fast_string_match)
5976 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5977 (scan_buffer, find_next_newline_no_quit)
5978 (find_before_next_newline, search_command, Freplace_match)
5979 (Fmatch_data): Make some `int' variables be EMACS_INT.
5981 * xdisp.c (display_count_lines): 3rd argument and return value now
5982 EMACS_INT. All callers changed.
5983 (pint2hrstr): Last argument is now EMACS_INT.
5985 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5986 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5987 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5988 (decode_coding_utf_16, decode_coding_emacs_mule)
5989 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5990 (decode_coding_ccl, decode_coding_charset)
5991 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5992 (decode_coding_iso_2022, decode_coding_emacs_mule)
5993 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5994 <char_offset, last_offset>: Declare EMACS_INT.
5995 (encode_coding_utf_8, encode_coding_utf_16)
5996 (encode_coding_emacs_mule, encode_invocation_designation)
5997 (encode_designation_at_bol, encode_coding_iso_2022)
5998 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5999 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6001 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6002 (encode_invocation_designation): Last argument P_NCHARS is now
6004 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6005 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6007 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6010 * ccl.c (Fccl_execute_on_string): Declare some variables
6013 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6015 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6017 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6019 * process.c (Fformat_network_address): Doc fix.
6021 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6023 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6025 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6027 * keyboard.c (read_char): Call Lisp function help-form-show,
6028 instead of using internal_with_output_to_temp_buffer.
6029 (Qhelp_form_show): New var.
6030 (syms_of_keyboard): Use DEFSYM macro.
6032 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6034 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6036 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6038 * process.c (Flist_processes): Remove to Lisp.
6039 (list_processes_1): Delete.
6041 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6043 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6045 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6047 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6049 Fix more problems found by GCC 4.6.0's static checks.
6051 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6053 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6055 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6057 * xdisp.c (vmessage): Mark as a printf-like function.
6059 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6061 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6063 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6064 printf-like functions.
6065 (tiff_load): Add casts to remove these marks before passing them
6066 to system-supplied API.
6068 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6070 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6071 This avoids several warnings with gcc -Wstrict-overflow.
6072 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6073 directly, rather than having caller test rule sign. This avoids
6074 some unnecessary tests.
6075 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6076 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6077 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6079 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6080 (xfont_open): Avoid unnecessary tests.
6082 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6084 * composite.h, composite.c (composition_gstring_put_cache):
6085 Use EMACS_INT, not int, for length.
6087 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6088 breaking out part of COMPOSITION_DECODE_RULE.
6089 (COMPOSITION_DECODE_RULE): Use it.
6090 * composite.c (get_composition_id): Remove unused local vars,
6091 by using the new macro.
6093 * textprop.c (set_text_properties_1): Change while to do-while,
6094 since the condition is always true at first.
6096 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6097 (interval_deletion_adjustment): Return unsigned value.
6100 * process.c (list_processes_1, create_pty, read_process_output):
6101 (exec_sentinel): Remove vars that were set but not used.
6102 (create_pty): Remove unnecessary "volatile"s.
6103 (Fnetwork_interface_info): Avoid possibility of int overflow.
6104 (read_process_output): Do adaptive read buffering even if carryover.
6105 (read_process_output): Simplify nbytes computation if buffered.
6107 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6109 * syntax.c (scan_words): Remove var that was set but not used.
6110 (update_syntax_table): Use unsigned instead of int.
6112 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6113 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6114 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6116 * print.c (print_error_message): Avoid int overflow.
6118 * font.c (font_list_entities): Redo for clarity,
6119 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6121 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6122 (font_score): Avoid potential overflow in diff calculation.
6124 * fns.c (substring_both): Remove var that is set but not used.
6125 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6127 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6129 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6130 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6131 can always succeed if overflow has undefined behavior.
6133 * search.c (boyer_moore, wordify): Remove vars set but not used.
6134 (wordify): Omit three unnecessary tests.
6136 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6137 All callers changed. This avoids the need for an unused var.
6139 * casefiddle.c (casify_region): Remove var that is set but not used.
6141 * dired.c (file_name_completion): Remove var that is set but not used.
6143 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6145 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6146 (Finsert_file_contents): Remove unnecessary code checking fd.
6148 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6149 Check for integer overflow on size calculations.
6151 * buffer.c (Fprevious_overlay_change): Remove var that is set
6154 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6155 Remove vars that are set but not used.
6156 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6157 (timer_check_2): Mark vars as initialized.
6159 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6161 * image.c (lookup_image): Remove var that is set but not used.
6162 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6164 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6165 that are set but not used.
6167 * xfns.c (make_invisible_cursor): Don't return garbage
6168 if XCreateBitmapFromData fails (Bug#8410).
6170 * xselect.c (x_get_local_selection, x_handle_property_notify):
6171 Remove vars that are set but not used.
6173 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6174 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6176 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6177 Remove var that is set but not used.
6178 (scroll_bar_windows_size): Now size_t, not int.
6179 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6182 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6183 (map_tty_color) [!defined MSDOS]: Likewise.
6185 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6187 * coding.c: Remove vars that are set but not used.
6188 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6189 All callers changed.
6190 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6191 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6192 (decode_coding_charset): Remove vars that are set but not used.
6194 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6195 that is set but not used.
6197 * print.c (print_object): Remove var that is set but not used.
6199 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6200 The gnulib version avoids calling malloc in the usual case,
6201 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6202 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6203 * filelock.c (current_lock_owner): Likewise.
6204 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6205 * sysdep.c: Include allocator.h, careadlinkat.h.
6206 (emacs_no_realloc_allocator): New static constant.
6207 (emacs_readlink): New function.
6208 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6209 ../lib/careadlinkat.h.
6211 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6213 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6214 first non-nil return value).
6216 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6218 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6219 if not defined (Bug#8403).
6221 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6223 * xdisp.c (display_count_lines): Remove parameter `start',
6224 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6225 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6226 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6227 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6228 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6229 and thereabouts. All callers changed.
6230 (get_per_char_metric): Remove parameter `f', unused since
6231 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6233 2011-04-02 Jim Meyering <meyering@redhat.com>
6235 do not dereference NULL upon failed strdup
6236 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6237 (ns_get_family): Likewise.
6239 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6241 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6243 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6245 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6248 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6250 Add lexical binding.
6252 * window.c (Ftemp_output_buffer_show): New fun.
6253 (Fsave_window_excursion):
6254 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6256 * lread.c (lisp_file_lexically_bound_p): New function.
6257 (Fload): Bind Qlexical_binding.
6258 (readevalloop): Remove `evalfun' arg.
6259 Bind Qinternal_interpreter_environment.
6260 (Feval_buffer): Bind Qlexical_binding.
6261 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6263 (syms_of_lread): Declare `lexical-binding'.
6265 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6267 * keyboard.c (eval_dyn): New fun.
6268 (menu_item_eval_property): Use it.
6270 * image.c (parse_image_spec): Use Ffunctionp.
6272 * fns.c (concat, mapcar1): Accept byte-code-functions.
6274 * eval.c (Fsetq): Handle lexical vars.
6275 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6276 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6277 (FletX, Flet): Obey lexical binding.
6278 (Fcommandp): Handle closures.
6279 (Feval): New `lexical' arg.
6280 (eval_sub): New function extracted from Feval. Use it almost
6281 everywhere where Feval was used. Look up vars in lexical env.
6283 (Ffunctionp): Move from subr.el.
6284 (Ffuncall): Handle closures.
6285 (apply_lambda): Remove `eval_flags'.
6286 (funcall_lambda): Handle closures and new byte-code-functions.
6287 (Fspecial_variable_p): New function.
6288 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6289 but without exporting it to Lisp.
6291 * doc.c (Fdocumentation, store_function_docstring):
6292 * data.c (Finteractive_form): Handle closures.
6294 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6297 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6299 (exec_byte_code): New function extracted from Fbyte_code to handle new
6300 calling convention for byte-code-functions. Add new byte-codes.
6302 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6304 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6306 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6308 * xdisp.c (redisplay_internal): Fix prototype.
6310 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6312 * xdisp.c (SCROLL_LIMIT): New macro.
6313 (try_scrolling): Use it when setting scroll_limit.
6314 Limit scrolling to 100 screen lines.
6315 (redisplay_window): Even when falling back on "recentering",
6316 position point in the window according to scroll-conservatively,
6317 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6319 (try_scrolling): When point is above the window, allow searching
6320 as far as scroll_max, or one screenful, to compute vertical
6321 distance from PT to the scroll margin position. This prevents
6322 try_scrolling from unnecessarily failing when
6323 scroll-conservatively is set to a value slightly larger than the
6324 window height. Clean up the case of PT below the margin at bottom
6325 of window: scroll_max can no longer be INT_MAX. When aggressive
6326 scrolling is in use, don't let point enter the opposite scroll
6327 margin as result of the scroll.
6328 (syms_of_xdisp) <scroll-conservatively>: Document the
6329 threshold of 100 lines for never-recentering scrolling.
6331 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6333 * dispextern.h (move_it_by_lines):
6334 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6335 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6336 (message_log_check_duplicate): Remove parameters `prev_bol' and
6337 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6338 (redisplay_internal): Remove parameter `preserve_echo_area',
6339 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6341 * indent.c (Fvertical_motion):
6342 * window.c (window_scroll_pixel_based, Frecenter):
6343 Don't pass `need_y_p' to `move_it_by_lines'.
6345 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6347 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6348 steal a few bits to be more compact.
6349 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6350 Remove unneeded casts.
6352 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6354 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6356 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6357 binding" message (bug#7967).
6359 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6361 Fix more problems found by GCC 4.6.0's static checks.
6363 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6364 Remove unused local var.
6366 * editfns.c (Fmessage_box): Remove unused local var.
6368 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6369 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6370 Omit unused local vars.
6371 * window.c (shrink_windows): Omit unused local var.
6372 * menu.c (digest_single_submenu): Omit unused local var.
6373 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6374 Omit unused local var.
6376 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6377 Don't assume string length fits in int.
6378 (keyremap_step, read_key_sequence): Use size_t for sizes.
6379 (read_key_sequence): Don't check last_real_key_start redundantly.
6381 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6382 instead of alloca (Bug#8344).
6384 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6385 (Fbacktrace_frame): Don't assume nframes fits in int.
6387 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6389 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6392 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6394 * cm.c (calccost): Turn while-do into do-while, for clarity.
6396 * keyboard.c (syms_of_keyboard): Use the same style as later
6397 in this function when indexing through an array. This also
6398 works around GCC bug 48267.
6400 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6402 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6404 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6405 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6407 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6408 This avoids undefined behavior on integer overflow, and is a bit
6409 more convenient anyway since it is compared to a size_t variable.
6411 Variadic C functions now count arguments with size_t, not int.
6412 This avoids an unnecessary limitation on 64-bit machines, which
6413 caused (substring ...) to crash on large vectors (Bug#8344).
6414 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6415 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6416 All variadic functions and their callers changed accordingly.
6417 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6418 * data.c (arith_driver, float_arith_driver): Likewise.
6419 * editfns.c (general_insert_function): Likewise.
6420 * eval.c (struct backtrace.nargs, interactive_p)
6421 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6422 (funcall_lambda, mark_backtrace): Likewise.
6423 * fns.c (concat): Likewise.
6424 * frame.c (x_set_frame_parameters): Likewise.
6425 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6426 0 if not found, not -1. All callers changed.
6428 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6429 (stack_copy_size): Now size_t, not int.
6430 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6432 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6434 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6435 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6436 All callers changed.
6438 * lisp.h (multibyte_char_to_unibyte):
6439 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6440 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6441 * character.h (CHAR_TO_BYTE8):
6442 * cmds.c (internal_self_insert):
6443 * editfns.c (general_insert_function):
6444 * keymap.c (push_key_description):
6445 * search.c (Freplace_match):
6446 * xdisp.c (message_dolog, set_message_1): All callers changed.
6448 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6450 * keyboard.c (safe_run_hook_funcall): New function.
6451 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6452 don't set the hook to nil, but remove the offending function instead.
6453 (Qcommand_hook_internal): Remove, unused.
6454 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6455 Vcommand_hook_internal.
6457 * eval.c (enum run_hooks_condition): Remove.
6458 (funcall_nil, funcall_not): New functions.
6459 (run_hook_with_args): Call each function through a `funcall' argument.
6460 Remove `cond' argument, now redundant.
6461 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6462 (Frun_hook_with_args_until_failure): Adjust accordingly.
6463 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6465 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6467 * dispextern.h (string_buffer_position): Remove declaration.
6469 * print.c (strout): Remove parameter `multibyte', unused since
6470 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6472 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6473 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6474 All callers changed.
6476 * w32.c (_wsa_errlist): Use braces for struct initializers.
6478 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6479 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6480 All callers changed.
6481 (string_buffer_position): Likewise. Also, make static (it's never
6482 used outside xdisp.c).
6483 (cursor_row_p): Remove parameter `w', unused since
6484 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6485 (decode_mode_spec): Remove parameter `precision', introduced during
6486 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6487 All callers changed.
6489 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6491 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6493 2011-03-27 Anders Lindgren <andlind@gmail.com>
6495 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6496 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6497 (ns_update_auto_hide_menu_bar): New functions.
6498 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6499 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6500 ns_constrain_all_frames.
6501 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6502 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6504 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6506 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6508 2011-03-27 Glenn Morris <rgm@gnu.org>
6510 * syssignal.h: Replace RETSIGTYPE with void.
6511 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6512 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6513 Replace SIGTYPE with void everywhere.
6514 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6515 * s/template.h (SIGTYPE): Remove commented out definition.
6517 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6519 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6520 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6522 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6524 * w32.c (read_unc_volume): Use parameter `henum', instead of
6525 global variable `wget_enum_handle'.
6527 * keymap.c (describe_vector): Remove parameters `indices' and
6528 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6529 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6531 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6533 * keyboard.c (timer_check): Remove parameter `do_it_now',
6534 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6535 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6536 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6538 * keyboard.c (read_char):
6539 * w32menu.c (w32_menu_display_help):
6540 * xmenu.c (show_help_event, menu_help_callback):
6541 Adjust calls to `show_help_echo'.
6543 * gtkutil.c (xg_maybe_add_timer):
6544 * keyboard.c (readable_events):
6545 * process.c (wait_reading_process_output):
6546 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6548 * insdel.c (adjust_markers_gap_motion):
6549 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6550 (gap_left, gap_right): Don't call it.
6552 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6554 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6555 incurred during fontification.
6557 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6559 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6560 (DEFVAR_PER_BUFFER): Don't pass it.
6562 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6563 (scrolling_window): Don't pass it.
6565 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6567 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6569 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6571 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6572 of variables specific to SELinux and computation of `encoded_absname'.
6574 * image.c (XPutPixel): Remove unused variable `height'.
6576 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6578 * unexw32.c (get_section_info): Remove unused variable `section'.
6580 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6581 (system_process_attributes): Remove unused variable `sess'.
6582 (sys_read): Remove unused variable `err'.
6584 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6585 (w32_wnd_proc): Remove unused variable `isdead'.
6586 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6587 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6588 (x_create_tip_frame): Remove unused variable `tem'.
6590 * w32inevt.c (w32_console_read_socket):
6591 Remove unused variable `no_events'.
6593 * w32term.c (x_draw_composite_glyph_string_foreground):
6594 Remove unused variable `width'.
6596 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6598 * w32term.c (x_set_glyph_string_clipping):
6599 Don't pass uninitialized region to CombineRgn.
6601 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6603 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6604 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6605 (Fx_close_connection): Remove unused variable `i'.
6607 * w32font.c (w32font_draw): Return number of glyphs.
6608 (w32font_open_internal): Remove unused variable `i'.
6609 (w32font_driver): Add missing initializer.
6611 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6612 (fill_in_menu): Remove unused variable `items_added'.
6614 * w32term.c (last_mouse_press_frame): Remove static global variable.
6615 (w32_clip_to_row): Remove unused variable `f'.
6616 (x_delete_terminal): Remove unused variable `i'.
6618 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6619 (NOTHING): Remove unused static global variable.
6620 (uniscribe_check_otf): Remove unused variable `table'.
6621 (uniscribe_font_driver): Add missing initializers.
6623 2011-03-23 Julien Danjou <julien@danjou.info>
6625 * term.c (Fsuspend_tty, Fresume_tty):
6626 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6627 * window.c (temp_output_buffer_show):
6628 * insdel.c (signal_before_change):
6629 * frame.c (Fhandle_switch_frame):
6630 * fileio.c (Fdo_auto_save):
6631 * emacs.c (Fkill_emacs):
6632 * editfns.c (save_excursion_restore):
6633 * cmds.c (internal_self_insert):
6634 * callint.c (Fcall_interactively):
6635 * buffer.c (Fkill_all_local_variables):
6636 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6638 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6639 unconditionnaly since it does the check itself.
6641 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6643 Fix more problems found by GCC 4.5.2's static checks.
6645 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6646 the first time through the loop, since we know p0 < p1 then.
6647 This also avoids a gcc -Wstrict-overflow warning.
6649 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6650 leading to a memory leak, possible in functions like
6651 load_charset_map_from_file that can allocate an unbounded number
6652 of objects (Bug#8318).
6654 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6655 that could (at least in theory) be that large.
6657 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6658 This is less likely to overflow, and avoids undefined behavior if
6659 overflow does occur. All callers changed. Use strtoul to scan
6660 for the unsigned long integer.
6661 (pint2hrstr): Simplify and tune code slightly.
6662 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6664 * scroll.c (do_scrolling): Work around GCC bug 48228.
6665 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6667 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6668 This also avoids a warning with gcc -Wstrict-overflow.
6669 (validate_x_resource_name): Simplify count usage.
6670 This also avoids a warning with gcc -Wstrict-overflow.
6672 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6675 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6677 * process.c (Fmake_network_process): Use socklen_t, not int,
6678 where POSIX says socklen_t is required in portable programs.
6679 This fixes a porting bug on hosts like 64-bit HP-UX, where
6680 socklen_t is wider than int (Bug#8277).
6681 (Fmake_network_process, server_accept_connection):
6682 (wait_reading_process_output, read_process_output):
6685 * process.c: Rename or move locals to avoid shadowing.
6686 (list_processes_1, Fmake_network_process):
6687 (read_process_output_error_handler, exec_sentinel_error_handler):
6688 Rename or move locals.
6689 (Fmake_network_process): Define label "retry_connect" only if needed.
6690 (Fnetwork_interface_info): Fix pointer signedness.
6691 (process_send_signal): Add cast to avoid pointer signedness problem.
6692 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6693 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6695 Make tparam.h and terminfo.c consistent.
6696 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6697 Include tparam.h instead, since it declares them.
6698 * cm.h (PC): Remove extern decl; tparam.h now does this.
6699 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6700 * terminfo.c: Include tparam.h, to check interfaces.
6701 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6702 (tparam): Adjust signature to match interface in tparam.h;
6703 this removes some undefined behavior. Check that outstring and len
6704 are zero, which they always are with Emacs.
6705 * tparam.h (PC, BC, UP): New extern decls.
6707 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6708 (xftfont_open): Rename locals to avoid shadowing.
6710 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6711 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6712 (OTF_TAG_SYM): Omit macro if not needed.
6713 (ftfont_list): Remove unused local.
6714 (get_adstyle_property, ftfont_pattern_entity):
6715 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6716 Rename locals to avoid shadowing.
6718 * xfont.c (xfont_list_family): Mark var as initialized.
6720 * xml.c (make_dom): Now static.
6722 * composite.c (composition_compute_stop_pos): Rename local to
6724 (composition_reseat_it): Remove unused locals.
6725 (find_automatic_composition, composition_adjust_point): Likewise.
6726 (composition_update_it): Mark var as initialized.
6727 (find_automatic_composition): Mark vars as initialized,
6728 with a FIXME (Bug#8290).
6730 character.h: Rename locals to avoid shadowing.
6731 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6732 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6733 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6734 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6737 * textprop.c (property_change_between_p): Remove; unused.
6739 * intervals.c (interval_start_pos): Now static.
6741 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6743 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6744 Rename locals to avoid shadowing.
6746 * sound.c (wav_play, au_play, Fplay_sound_internal):
6747 Fix pointer signedness.
6748 (alsa_choose_format): Remove unused local var.
6749 (wav_play): Initialize a variable to 0, to prevent undefined
6750 behavior (Bug#8278).
6752 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6754 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6756 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6757 clobbering (Bug#8298).
6758 * sysdep.c (sys_subshell): Likewise.
6759 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6761 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6762 This should get cleaned up, so that child_setup has the
6763 same signature on all platforms.
6765 * callproc.c (call_process_cleanup): Now static.
6766 (relocate_fd): Rename locals to avoid shadowing.
6768 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6770 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6771 not to be necessary, and produces flickering.
6773 2011-03-20 Glenn Morris <rgm@gnu.org>
6775 * config.in: Remove file.
6777 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6779 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6780 are now in src/globals.h.
6781 (syms_of_minibuf): Remove spurious & from previous change.
6783 2011-03-20 Leo <sdl.web@gmail.com>
6785 * minibuf.c (completing-read-function): New variable.
6786 (completing-read-default): Rename from completing-read.
6787 (completing-read): Call completing-read-function.
6789 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6791 * xfaces.c (Fx_load_color_file):
6792 Read color file from absolute filename (bug#8250).
6794 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6796 * makefile.w32-in: Update dependencies.
6798 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6800 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6802 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6804 Fix more problems found by GCC 4.5.2's static checks.
6806 * process.c (make_serial_process_unwind, send_process_trap):
6807 (sigchld_handler): Now static.
6809 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6810 That way, the code declares only the vars that it needs.
6811 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6812 * s/cygwin.h (PTY_ITERATION): Likewise.
6813 * s/darwin.h (PTY_ITERATION): Likewise.
6814 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6816 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6817 * process.c (allocate_pty): Don't declare stb unless it's needed.
6819 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6820 (CONSTANTLIM): Remove; unused.
6821 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6822 Define only if needed.
6824 * unexelf.c (unexec): Name an expression,
6825 to avoid gcc -Wbad-function-cast warning.
6826 Use a different way to cause a compilation error if anyone uses
6827 n rather than nn, a way that does not involve shadowing.
6828 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6830 * deps.mk (unexalpha.o): Remove; unused.
6832 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6833 * unexec.h: New file.
6834 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6835 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6837 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6838 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6839 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6840 Change as necessary to match prototype in unexec.h.
6842 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6844 (back_comment, skip_chars): Mark vars as initialized.
6846 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6847 Rename locals to avoid shadowing.
6849 * lread.c (read1): Rewrite so as not to use empty "else".
6850 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6852 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6854 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6855 warning when compiling print.c.
6857 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6858 instead of using an uninitialized var.
6859 (font_sort_entities): Mark var as initialized.
6861 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6863 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6864 pointers to constants.
6865 (font_parse_fcname): Remove unused vars.
6866 (font_delete_unmatched): Now static.
6867 (font_get_spec): Remove; unused.
6868 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6869 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6870 Rename or move locals to avoid shadowing.
6872 * fns.c (require_nesting_list, require_unwind): Now static.
6873 (Ffillarray): Rename locals to avoid shadowing.
6875 * floatfns.c (domain_error2): Define only if needed.
6876 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6878 * alloc.c (mark_backtrace): Move decl from here ...
6879 * lisp.h: ... to here, so that it can be checked.
6881 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6882 (Fdefvar): Rewrite so as not to use empty "else".
6883 (lisp_indirect_variable): Name an expression,
6884 to avoid gcc -Wbad-function-cast warning.
6885 (Fdefvar): Rename locals to avoid shadowing.
6887 * callint.c (quotify_arg, quotify_args): Now static.
6888 (Fcall_interactively): Rename locals to avoid shadowing.
6889 Use const pointer when appropriate.
6891 * lisp.h (get_system_name, get_operating_system_release):
6892 Move decls here, to check interfaces.
6893 * process.c (get_operating_system_release): Move decl to lisp.h.
6894 * xrdb.c (get_system_name): Likewise.
6895 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6896 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6897 some of which prompt warnings from gcc -Wbad-function-cast.
6898 (Fformat_time_string, Fencode_time, Finsert_char):
6899 (Ftranslate_region_internal, Fformat):
6900 Rename or remove local vars to avoid shadowing.
6901 (Ftranslate_region_internal): Mark var as initialized.
6903 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6906 * lisp.h (eassert): Check that the argument compiles, even if
6907 ENABLE_CHECKING is not defined.
6909 * data.c (Findirect_variable): Name an expression, to avoid
6910 gcc -Wbad-function-cast warning.
6911 (default_value, arithcompare, arith_driver, arith_error): Now static.
6912 (store_symval_forwarding): Rename local to avoid shadowing.
6913 (Fmake_variable_buffer_local, Fmake_local_variable):
6914 Mark variables as initialized.
6915 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6917 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6918 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6919 Rename locals to avoid shadowing.
6920 (mark_stack): Move local variables into the #ifdef region where
6922 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6923 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6925 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6926 (GC_STRING_CHARS): Remove; not used.
6927 (Fmemory_limit): Cast sbrk's returned value to char *.
6929 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6930 avoids undefined behavior in theory.
6932 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6934 Use functions, not macros, for up- and down-casing (Bug#8254).
6935 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6936 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6937 to use the following functions instead of these macros.
6938 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6939 EMACS_INT, since callers assume the returned value fits in int.
6940 (upcase1): Likewise, for UPCASE_TABLE.
6941 (uppercasep, lowercasep, upcase): New static inline functions.
6942 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6943 the race-condition problem in the old DOWNCASE.
6945 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6946 Rename locals to avoid shadowing.
6947 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6948 (regex_compile, re_search_2, re_match_2_internal):
6949 Remove unused local vars.
6950 (FREE_VAR): Rewrite so as not to use empty "else",
6951 which gcc can warn about.
6952 (regex_compile, re_match_2_internal): Mark locals as initialized.
6953 (RETALLOC_IF): Define only if needed.
6954 (WORDCHAR_P): Likewise. This one is never needed, but is used
6955 only in a comment talking about a compiler bug, so put inside
6956 the #if 0 of that comment.
6957 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6958 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6961 * search.c (boyer_moore): Rename locals to avoid shadowing.
6962 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6963 (PREV_CHAR_BOUNDARY): Likewise.
6965 * search.c (simple_search): Remove unused var.
6967 * dired.c (compile_pattern): Move decl from here ...
6968 * lisp.h: ... to here, so that it can be checked.
6969 (struct re_registers): New forward decl.
6971 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6973 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6975 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6976 Rename locals to avoid shadowing.
6977 (Fvertical_motion): Mark locals as initialized.
6979 * casefiddle.c (casify_object, casify_region): Now static.
6980 (casify_region): Mark local as initialized.
6982 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6984 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6985 New macros, so that the caller can use some names other than
6986 gcpro1, gcpro2, etc.
6987 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6989 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6990 argument, for consistency with GCPRO2_VAR, etc: it is now the
6991 prefix of the variable, not the variable itself. All uses
6993 * dired.c (directory_files_internal, file_name_completion):
6994 Rename locals to avoid shadowing.
6996 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6997 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6998 dired.c's scmp function, had undefined behavior.
6999 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7000 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7001 * buffer.h: ... to here, because these macros use current_buffer,
7002 and the new implementation with inline functions needs to have
7003 current_buffer in scope now, rather than later when the macros
7005 (downcase, upcase1): New static inline functions.
7006 (DOWNCASE, UPCASE1): Reimplement using these functions.
7007 This avoids undefined behavior in expressions like
7008 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7009 from race conditions in accessing the global variables
7010 case_temp1 and case_temp2.
7011 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7012 * lisp.h (case_temp1, case_temp2): Remove their decls.
7013 * character.h (ASCII_CHAR_P): Move from here ...
7014 * lisp.h: ... to here, so that the inline functions mentioned
7017 * dired.c (directory_files_internal_unwind): Now static.
7019 * fileio.c (file_name_as_directory, directory_file_name):
7020 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7022 (file_name_as_directory): Use const pointers when appropriate.
7023 (Fexpand_file_name): Likewise. In particular, newdir might
7024 point at constant storage, so make it a const pointer.
7025 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7026 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7028 (Fset_file_times, Finsert_file_contents, auto_save_error):
7029 Rename locals to avoid shadowing.
7031 * minibuf.c (choose_minibuf_frame_1): Now static.
7032 (Ftry_completion, Fall_completions): Rename or remove locals
7035 * marker.c (bytepos_to_charpos): Remove; unused.
7037 * lisp.h (verify_bytepos, count_markers): New decls,
7038 so that gcc does not warn that these functions aren't declared.
7040 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7041 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7042 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7043 (copy_text): Remove unused local var.
7045 * filelock.c (within_one_second): Now static.
7046 (lock_file_1): Rename local to avoid shadowing.
7048 * buffer.c (fix_overlays_before): Mark locals as initialized.
7049 (fix_start_end_in_overlays): Likewise. This function should be
7050 simplified by using pointers-to-pointers, but that's a different
7052 (switch_to_buffer_1): Now static.
7053 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7054 (report_overlay_modification): Rename locals to avoid shadowing.
7056 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7057 Fix pointer signedness issue.
7058 (sys_subshell): Mark local as volatile if checking for lint,
7059 to suppress a gcc -Wclobbered warning that does not seem to be right.
7060 (MAXPATHLEN): Define only if needed.
7062 * process.c (serial_open, serial_configure): Move decls from here ...
7063 * systty.h: ... to here, so that they can be checked.
7065 * fns.c (get_random, seed_random): Move extern decls from here ...
7066 * lisp.h: ... to here, so that they can be checked.
7068 * sysdep.c (reset_io): Now static.
7069 (wait_for_termination_signal): Remove; unused.
7071 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7072 (copy_keymap_item, append_key, push_text_char_description):
7074 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7075 (DENSE_TABLE_SIZE): Remove; unused.
7076 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7077 (describe_map_tree):
7078 Rename locals to avoid shadowing.
7080 * keyboard.c: Declare functions static if they are not used elsewhere.
7081 (echo_char, echo_dash, cmd_error, top_level_2):
7082 (poll_for_input, handle_async_input): Now static.
7083 (read_char, kbd_buffer_get_event, make_lispy_position):
7084 (make_lispy_event, make_lispy_movement, apply_modifiers):
7085 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7086 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7087 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7088 (read_key_sequence, read_char): Mark locals as initialized.
7089 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7091 * keyboard.h (make_ctrl_char): New decl.
7092 (mark_kboards): Move decl here ...
7093 * alloc.c (mark_kboards): ... from here.
7095 * lisp.h (force_auto_save_soon): New decl.
7097 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7098 (DEFINE_DUMMY_FUNCTION): New macro.
7099 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7101 (main): Add casts to avoid warnings
7102 if GCC considers string literals to be constants.
7104 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7106 * dbusbind.c: Pointer signedness fixes.
7107 (xd_signature, xd_append_arg, xd_initialize):
7108 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7109 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7110 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7111 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7113 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7114 if GCC considers string literals to be constants.
7115 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7117 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7119 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7120 (print_preprocess, print_object): New macro to fix last change.
7122 * print.c (print_preprocess): Don't forget font objects.
7124 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7126 * emacs.c (USAGE3): Doc fixes.
7128 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7130 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7133 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7135 * lisp.h (VWindow_system, Qfile_name_history):
7136 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7137 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7138 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7140 * w32select.c: Don't #include "keyboard.h".
7141 (run_protected): Add extern declaration for waiting_for_input.
7143 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7144 * w32console.c (detect_input_pending, read_input_pending)
7145 (encode_terminal_code):
7146 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7147 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7148 (w32_system_caret_y, Qfile_name_history):
7149 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7150 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7151 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7152 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7153 * w32proc.c (Qlocal, report_file_error):
7154 * w32term.c (Vwindow_system, updating_frame):
7155 * w32uniscribe.c (initialized, uniscribe_font_driver):
7156 Remove unneeded extern declarations.
7158 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7160 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7162 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7164 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7165 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7166 These macros can no longer be used for assignment.
7168 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7169 Assign struct members directly, instead of using BUF_BEGV etc.
7170 (record_buffer_markers, fetch_buffer_markers): New functions for
7171 recording and fetching special buffer markers.
7172 (set_buffer_internal_1, set_buffer_temp): Use them.
7174 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7176 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7178 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7179 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7181 * xdisp.c (hscroll_window_tree):
7182 (reconsider_clip_changes): Use PT instead of BUF_PT.
7184 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7186 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7187 $(EMACS_ROOT)/lib/intprops.h.
7189 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7191 Fix more problems found by GCC 4.5.2's static checks.
7193 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7194 to unsigned char * to avoid compiler diagnostic.
7195 (xg_free_frame_widgets): Make it clear that a local variable is
7196 needed only if USE_GTK_TOOLTIP.
7197 (gdk_window_get_screen): Make it clear that this macro is needed
7198 only if USE_GTK_TOOLTIP.
7199 (int_gtk_range_get_value): New function, which avoids a diagnostic
7200 from gcc -Wbad-function-cast.
7201 (xg_set_toolkit_scroll_bar_thumb): Use it.
7202 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7203 diagnostic from gcc -Wbad-function-cast.
7204 (get_utf8_string, xg_get_file_with_chooser):
7205 Rename locals to avoid shadowing.
7206 (create_dialog): Move locals to avoid shadowing.
7208 * xgselect.c (xg_select): Remove unused var.
7210 * image.c (four_corners_best): Mark locals as initialized.
7211 (gif_load): Initialize transparent_p to zero (Bug#8238).
7212 Mark another local as initialized.
7213 (my_png_error, my_error_exit): Mark with NO_RETURN.
7215 * image.c (clear_image_cache): Now static.
7216 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7217 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7218 (x_edge_detection): Remove unnecessary cast that
7219 gcc -Wbad-function-cast diagnoses.
7220 (gif_load): Fix pointer signedness.
7221 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7222 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7224 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7226 Improve quality of tests for time stamp overflow.
7227 For example, without this patch (encode-time 0 0 0 1 1
7228 1152921504606846976) returns the obviously-bogus value (-948597
7229 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7230 reports time overflow. See
7231 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7232 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7233 * editfns.c: Include limits.h and intprops.h.
7234 (TIME_T_MIN, TIME_T_MAX): New macros.
7235 (time_overflow): Move earlier, to before first use.
7236 (hi_time, lo_time): New functions, for an accurate test for
7238 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7239 (Fget_internal_run_time): Don't assume time_t fits in int.
7240 (make_time): Use list2 instead of Fcons twice.
7241 (Fdecode_time): More accurate test for out-of-range times.
7242 (check_tm_member): New function.
7243 (Fencode_time): Use it, to test for out-of-range times.
7244 (lisp_time_argument): Don't rely on undefined left-shift and
7245 right-shift behavior when checking for time stamp overflow.
7247 * editfns.c (time_overflow): New function, refactoring common code.
7248 (Fformat_time_string, Fdecode_time, Fencode_time):
7249 (Fcurrent_time_string): Use it.
7251 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7252 * dired.c (make_time): Move to ...
7253 * editfns.c (make_time): ... here.
7254 * systime.h: Note the move.
7256 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7258 * fringe.c (update_window_fringes): Remove unused variables.
7260 * unexmacosx.c (copy_data_segment): Also copy __got section.
7263 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7265 * termcap.c [MSDOS]: Include "msdos.h".
7266 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7267 Constify `char *' arguments and their references according to
7268 prototypes in tparam.h.
7270 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7272 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7273 Adapt all references accordingly.
7275 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7277 2011-03-11 Tom Tromey <tromey@redhat.com>
7279 * buffer.c (syms_of_buffer): Remove obsolete comment.
7281 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7283 * termhooks.h (encode_terminal_code): Declare prototype.
7285 * msdos.c (encode_terminal_code): Don't declare prototype.
7287 * term.c (encode_terminal_code): Now external again, used by
7288 w32console.c and msdos.c.
7290 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7291 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7293 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7295 Fix some minor problems found by GCC 4.5.2's static checks.
7297 * fringe.c (update_window_fringes): Mark locals as initialized
7299 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7301 * alloc.c (mark_fringe_data): Move decl from here ...
7302 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7303 to check its interface.
7304 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7306 * fontset.c (free_realized_fontset): Now static.
7307 (Fset_fontset_font): Rename local to avoid shadowing.
7308 (fontset_font): Mark local as initialized.
7309 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7311 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7313 * xselect.c (x_disown_buffer_selections): Remove; not used.
7314 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7315 (x_own_selection, Fx_disown_selection_internal): Rename locals
7317 (x_handle_dnd_message): Remove local to avoid shadowing.
7319 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7320 so that the caller can use some name other than gcpro1.
7321 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7322 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7323 (Fx_backspace_delete_keys_p):
7324 Use them to avoid shadowing, and rename vars to avoid shadowing.
7325 (x_decode_color, x_set_name, x_window): Now static.
7326 (Fx_create_frame): Add braces to silence GCC warning.
7327 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7328 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7329 Remove unused locals.
7330 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7331 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7332 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7335 * xterm.h (x_mouse_leave): New decl.
7337 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7338 Remove unused functions.
7339 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7340 (x_calc_absolute_position): Now static.
7341 (XTread_socket): Don't define label "out" unless it's used.
7342 Don't declare local "event" unless it's used.
7343 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7344 unless they are used.
7345 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7346 (x_fatal_error_signal): Remove; not used.
7347 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7348 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7349 (x_error_catcher, x_connection_closed, x_error_handler):
7350 (x_error_quitter, xembed_send_message, x_iconify_frame):
7351 (my_log_handler): Rename locals to avoid shadowing.
7352 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7353 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7355 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7356 Rename or move locals to avoid shadowing.
7357 (tty_defined_color, merge_face_heights): Now static.
7358 (free_realized_faces_for_fontset): Remove; not used.
7359 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7360 does not deduce is never used uninitialized.
7361 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7362 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7364 * terminal.c (store_terminal_param): Now static.
7366 * xmenu.c (menu_highlight_callback): Now static.
7367 (set_frame_menubar): Remove unused local.
7368 (xmenu_show): Rename parameter to avoid shadowing.
7369 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7370 since they might point to immutable storage.
7371 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7372 since it's unused otherwise.
7374 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7375 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7376 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7377 avoids a gcc -Wuninitialized diagnostic.
7378 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7379 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7380 does not deduce are never used uninitialized.
7382 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7384 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7385 * window.c (window_loop, size_window):
7386 (run_window_configuration_change_hook, enlarge_window): Likewise.
7388 * window.c (display_buffer): Now static.
7389 (size_window): Mark variables that gcc -Wuninitialized
7390 does not deduce are never used uninitialized.
7391 * window.h (check_all_windows): New decl, to forestall
7392 gcc -Wmissing-prototypes diagnostic.
7393 * dispextern.h (bidi_dump_cached_states): Likewise.
7395 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7397 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7399 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7400 and to avoid gcc -Wuninitialized warning.
7401 (load_charset_map): Mark variables that gcc -Wuninitialized
7402 does not deduce are never used uninitialized.
7403 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7405 * coding.c (coding_set_source, coding_set_destination):
7406 Use "else { /* comment */ }" rather than "else /* comment */;"
7407 for clarity, and to avoid gcc -Wempty-body warning.
7408 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7409 a block, when the outer 'i' will do.
7410 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7411 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7412 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7413 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7414 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7415 Rename locals to avoid shadowing.
7416 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7417 * coding.c (emacs_mule_char, encode_invocation_designation):
7418 Now static, since they're not used elsewhere.
7419 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7420 (decode_coding_object, encode_coding_object, detect_coding_system):
7421 (decode_coding_emacs_mule): Mark variables that gcc
7422 -Wuninitialized does not deduce are never used uninitialized.
7423 (detect_coding_iso_2022): Initialize a local variable that might
7424 be used uninitialized. Leave a FIXME because it's not clear that
7425 this initialization is needed. (Bug#8211)
7426 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7427 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7428 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7429 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7430 Remove unused macros.
7432 * category.c (hash_get_category_set): Remove unused local var.
7433 (copy_category_table): Now static, since it's not used elsewhere.
7434 * character.c (string_count_byte8): Likewise.
7436 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7437 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7439 * chartab.c (copy_sub_char_table): Now static, since it's not used
7441 (sub_char_table_ref_and_range, char_table_ref_and_range):
7442 Rename locals to avoid shadowing.
7443 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7445 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7446 (BIDI_BOB): Remove unused macro.
7448 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7449 deduce are never used uninitialized.
7450 * term.c (encode_terminal_code): Likewise.
7452 * term.c (encode_terminal_code): Now static. Remove unused local.
7454 * tparam.h: New file.
7455 * term.c, tparam.h: Include it.
7456 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7457 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7458 Move these decls to tparam.h, and make them agree with what
7459 is actually in tparam.c. The previous trick of using incompatible
7460 decls in different modules does not conform to the C standard.
7461 All callers of tparam changed to use tparam's actual API.
7462 * tparam.c (tparam1, tparam, tgoto):
7463 Use const pointers where appropriate.
7465 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7466 * cm.h (struct cm): Likewise.
7467 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7468 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7469 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7470 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7471 (turn_on_face, init_tty): Likewise.
7472 * termchar.h (struct tty_display_info): Likewise.
7474 * term.c (term_mouse_position): Rename local to avoid shadowing.
7476 * alloc.c (mark_ttys): Move decl from here ...
7477 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7479 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7481 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7483 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7485 * search.c (compile_pattern_1): Remove argument regp, unused since
7486 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7487 (compile_pattern): Don't pass it.
7489 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7491 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7492 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7494 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7496 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7498 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7499 gdk_window_get_screen, gdk_window_get_geometry,
7500 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7501 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7502 (xg_get_pixbuf_from_pixmap): New function.
7503 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7504 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7505 Call xg_get_pixbuf_from_pixmap instead of
7506 gdk_pixbuf_get_from_drawable.
7507 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7508 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7509 (xg_check_special_colors): Use GtkStyleContext and its functions
7511 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7512 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7513 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7514 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7515 Call gtk_widget_get_preferred_size.
7516 (xg_frame_resized): gdk_window_get_geometry only takes 5
7518 (xg_win_to_widget, xg_event_is_for_menubar):
7519 Call gdk_x11_window_lookup_for_display.
7520 (xg_set_widget_bg): New function.
7521 (delete_cb): New function.
7522 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7523 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7524 (xg_set_background_color): Call xg_set_widget_bg.
7525 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7526 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7527 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7528 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7530 (update_frame_tool_bar): Call gtk_widget_hide.
7531 (xg_initialize): Use GDK_KEY_g.
7533 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7535 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7537 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7538 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7539 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7541 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7543 * w32xfns.c (select_palette): Check success of RealizePalette against
7544 GDI_ERROR, not zero.
7546 See ChangeLog.11 for earlier changes.
7552 Copyright (C) 2011 Free Software Foundation, Inc.
7554 This file is part of GNU Emacs.
7556 GNU Emacs is free software: you can redistribute it and/or modify
7557 it under the terms of the GNU General Public License as published by
7558 the Free Software Foundation, either version 3 of the License, or
7559 (at your option) any later version.
7561 GNU Emacs is distributed in the hope that it will be useful,
7562 but WITHOUT ANY WARRANTY; without even the implied warranty of
7563 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7564 GNU General Public License for more details.
7566 You should have received a copy of the GNU General Public License
7567 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.