* alloc.c: Remove one incorrect comment and fix another.
[bpt/emacs.git] / src / ChangeLog
1 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix minor alloc.c problems found by static checking.
4 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5 New extern decls, to avoid calling undeclared functions.
6 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
9 (NEED_MEM_INSERT): New macro.
10 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
11 Remove one incorrect comment and fix another.
12
13 Fix minor ralloc.c problems found by static checking.
14 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
15 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
16 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
17 (r_alloc_sbrk): Now static.
18
19 Improve ralloc.c interface checking.
20 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
21 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
22 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
23 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
24 [REL_ALLOC]: ... to here, to check interface.
25 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
26 Remove decls. This fixes an "It stinks!".
27
28 * alloc.c (which_symbols): Fix alignment issue / type clash.
29
30 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
31
32 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
33 (struct Lisp_Misc_Any): Likewise.
34 (struct Lisp_Free): Likewise.
35 * alloc.c (union aligned_Lisp_Symbol): Define.
36 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
37 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
38 (union aligned_Lisp_Misc): Define.
39 (MARKER_BLOCK_SIZE, struct marker_block): Use union
40 aligned_Lisp_Misc instead of union Lisp_Misc.
41 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
42
43 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
44
45 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
46 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
47 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
48 * s/netbsd.h, s/sol2-6.h:
49 Remove definition of GC_MARK_STACK, since the default now works.
50 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
51 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
52 no longer the default.
53 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
54
55 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
56
57 * lread.c (lisp_file_lexically_bound_p):
58 Fix hang at ";-*-\n" (bug#11238).
59
60 2012-04-14 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
63 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
64
65 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
66
67 * nsterm.m (constrainFrameRect): Always constrain when there is only
68 one screen (Bug#10962).
69
70 2012-04-13 Ken Brown <kbrown@cornell.edu>
71
72 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
73
74 2012-04-13 Reuben Thomas <rrt@sc3d.org>
75
76 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
77
78 2012-04-11 Daniel Colascione <dancol@dancol.org>
79
80 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
81 against is gone. It's better to use vfork now so that when Cygwin
82 gains a new, working vfork, we use it automatically (bug#10398).
83
84 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
85
86 * window.c (save_window_save): Obey window-point-insertion-type.
87
88 2012-04-11 Glenn Morris <rgm@gnu.org>
89
90 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
91
92 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
93
94 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
95
96 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
97
98 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
99 (force_quit_count): New var.
100 (handle_interrupt): Use it.
101
102 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
103
104 * w32.c (w32_delayed_load): Record the full path of the library
105 being loaded (bug#10424).
106
107 2012-04-09 Glenn Morris <rgm@gnu.org>
108
109 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
110 not just in the obarray, before snarfing them. (Bug#11036)
111
112 * Makefile.in ($(leimdir)/leim-list.el):
113 Pass EMACS rather than BUILT_EMACS.
114
115 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
116
117 * process.c (make_process):
118 * process.h: Add integer `gnutls_handshakes_tried' member to
119 process struct.
120
121 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
122 Add convenience `GNUTLS_LOG2i' macro.
123
124 * gnutls.c (gnutls_log_function2i): Convenience log function.
125 (emacs_gnutls_read): Use new log functions,
126 `gnutls_handshakes_tried' process member, and
127 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
128 attempts per process (connection).
129
130 2012-04-09 Chong Yidong <cyd@gnu.org>
131
132 * eval.c (Fuser_variable_p, user_variable_p_eh)
133 (lisp_indirect_variable): Functions deleted.
134 (Fdefvar): Caller changed.
135
136 * callint.c (Finteractive, Fcall_interactively):
137 * minibuf.c (Fread_variable): Callers changed.
138
139 2012-04-09 Eli Zaretskii <eliz@gnu.org>
140
141 * xdisp.c (set_cursor_from_row): If the display string appears in
142 the buffer at position that is closer to point than the position
143 after the display string, display the cursor on the first glyph of
144 the display string. Fixes cursor display when a 'display' text
145 property immediately follows invisible text. (Bug#11094)
146
147 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
148
149 composite.c: use 'double' consistently
150 * composite.c (get_composition_id): Use 'double' consistently
151 instead of converting 'float' to 'double' and vice versa; this is
152 easier to understand and avoids a GCC warning.
153
154 2012-04-09 Glenn Morris <rgm@gnu.org>
155
156 * Makefile.in: Generate leim-list with bootstrap-emacs, in
157 preparation for dumping it with emacs. (Bug#4789)
158 (leimdir): New variable.
159 ($(leimdir)/leim-list.el): New rule.
160 (emacs$(EXEEXT)): Depend on leim-list.el.
161
162 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
163 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
164 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
165
166 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
167
168 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
169 proper alignment.
170
171 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
172
173 * xml.c (init_libxml2_functions) [WINDOWSNT]:
174 Remove unused local variable.
175
176 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
177
178 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
179 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
180 (mark_memory): Mark Lisp_Objects only if pointers might hide in
181 objects, as mark_maybe_pointer will catch them otherwise.
182 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
183 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
184
185 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
186
187 Fix typo that broke non-Windows builds.
188 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
189
190 2012-04-07 Eli Zaretskii <eliz@gnu.org>
191
192 Support building on MS-Windows with libxml2.
193
194 * makefile.w32-in (OBJ2): Add xml.$(O).
195 (GLOBAL_SOURCES): Add xml.c.
196 ($(BLD)/xml.$(O)): New dependency list.
197
198 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
199 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
200 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
201 [!WINDOWSNT]: New macros.
202 (init_libxml2_functions, libxml2_loaded_p): New functions.
203 (parse_region): Call fn_xmlCheckVersion instead of using the macro
204 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
205 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
206 Calls xmlCleanupParser only if libxml2 was loaded (or statically
207 linked in).
208 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
209 Call init_libxml2_functions before calling libxml2 functions.
210 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
211
212 * emacs.c: Don't include libxml/parser.h.
213 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
214 xmlCleanupParser directly.
215
216 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
217
218 2012-04-07 Eli Zaretskii <eliz@gnu.org>
219
220 * indent.c (Fvertical_motion): If there is a display string at
221 point, use it.vpos to compute how many lines to backtrack after
222 move_it_to point. (Bug#11133)
223
224 2012-04-06 Eli Zaretskii <eliz@gnu.org>
225
226 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
227 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
228 about subtle differences between FETCH_CHAR* and STRING_CHAR*
229 macros related to unification of CJK characters. For the details,
230 see the discussion following the message here:
231 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
232
233 2012-04-04 Chong Yidong <cyd@gnu.org>
234
235 * keyboard.c (Vdelayed_warnings_list): Doc fix.
236
237 2012-04-01 Eli Zaretskii <eliz@gnu.org>
238
239 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
240 instead of alloca. (Bug#11138)
241
242 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
243
244 * w32menu.c (is_simple_dialog): Properly check lisp types.
245 (Bug#11141)
246
247 2012-03-31 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
250 position we get to after a call to move_it_to fails the
251 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
252 only if we wind up in a string from display property. (Bug#11063)
253
254 * window.c (Fdelete_other_windows_internal): Invalidate the row
255 and column information about mouse highlight, so that redisplay
256 restores it after reallocating the glyph matrices. (Bug#7464)
257
258 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
259 string comes from a `display' text property, use the buffer
260 position of that property as if we actually saw that position in
261 the row's glyphs.
262 (move_it_by_lines): Remove the assertion that
263 "it->current_x == 0 && it->hpos == 0" which can be legitimately
264 violated when there's a before-string at the beginning of a line.
265 (Bug#11063)
266
267 2012-03-30 Eli Zaretskii <eliz@gnu.org>
268
269 * xdisp.c (append_space_for_newline): If the default face was
270 remapped, use the remapped face for the appended newline.
271 (extend_face_to_end_of_line): Use the remapped default face for
272 extending the face to the end of the line.
273 (display_line): Call extend_face_to_end_of_line when the default
274 face was remapped. (Bug#11068)
275
276 2012-03-29 Eli Zaretskii <eliz@gnu.org>
277
278 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
279
280 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
281
282 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
283
284 2012-03-27 Glenn Morris <rgm@gnu.org>
285
286 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
287 Doc fixes.
288
289 2012-03-26 Kenichi Handa <handa@m17n.org>
290
291 * dispextern.h (struct glyph): Fix previous change. Change the
292 bit length of glyphless.ch to 25 (Bug#11082).
293
294 2012-03-26 Chong Yidong <cyd@gnu.org>
295
296 * keyboard.c (Vselection_inhibit_update_commands): New variable.
297 (command_loop_1): Use it; inhibit selection update for
298 handle-select-window too (Bug#8996).
299
300 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
301
302 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
303
304 2012-03-25 Kenichi Handa <handa@m17n.org>
305
306 * dispextern.h (struct glyph): Change the bit length of
307 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
308
309 2012-03-24 Eli Zaretskii <eliz@gnu.org>
310
311 * s/ms-w32.h (tzname): Include time.h before redirecting to
312 _tzname. Fixes the MSVC build. (Bug#9960)
313
314 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
315
316 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
317 characters.
318
319 * xterm.c (XTread_socket): Only modify handling_signal if
320 !SYNC_INPUT. (Bug#11080)
321
322 2012-03-23 Eli Zaretskii <eliz@gnu.org>
323
324 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
325 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
326 when fetching a multibyte character consumes more bytes than
327 CHAR_BYTES returns, due to unification of CJK characters in
328 string_char. (Bug#11073)
329
330 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
331
332 * process.c (wait_reading_process_output): Handle pty disconnect
333 by refraining from sending oneself a SIGCHLD (bug#10933).
334
335 2012-03-22 Chong Yidong <cyd@gnu.org>
336
337 * dispextern.h (struct it): New member string_from_prefix_prop_p.
338
339 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
340 Mark string as coming from a prefix property.
341 (handle_face_prop): Use default face for prefix strings (Bug#4281).
342 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
343
344 2012-03-21 Chong Yidong <cyd@gnu.org>
345
346 * xfaces.c (Vface_remapping_alist): Doc fix.
347
348 2012-03-20 Eli Zaretskii <eliz@gnu.org>
349
350 * w32proc.c (Fw32_set_console_codepage)
351 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
352 Doc fixes.
353
354 2012-03-20 Chong Yidong <cyd@gnu.org>
355
356 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
357 to reflect default non-nil value of redisplay-dont-pause.
358
359 2012-03-19 Kenichi Handa <handa@m17n.org>
360
361 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
362 it fit in a valid range (Bug#11003).
363
364 2012-03-18 Eli Zaretskii <eliz@gnu.org>
365
366 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
367 that is not from display property, accept the row as a "cursor
368 row" if one of the string's character has a non-nil `cursor'
369 property. Fixes cursor positioning when there are newlines in
370 overlay strings, e.g. in icomplete.el. (Bug#11035)
371
372 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
373
374 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
375
376 2012-03-12 Chong Yidong <cyd@gnu.org>
377
378 * eval.c (inhibit_lisp_code): Rename from
379 inhibit_window_configuration_change_hook; move from window.c.
380
381 * xfns.c (unwind_create_frame_1, Fx_create_frame):
382 * window.c (run_window_configuration_change_hook)
383 (syms_of_window): Callers changed.
384
385 2012-03-11 Chong Yidong <cyd@gnu.org>
386
387 * keymap.c (Fkey_description): Doc fix (Bug#9700).
388
389 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
390
391 2012-03-10 Chong Yidong <cyd@gnu.org>
392
393 * frame.c (other_visible_frames): Don't assume the selected frame
394 is visible (Bug#10955).
395
396 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
397
398 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
399
400 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
401
402 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
403 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
404 zero (Bug#10954).
405
406 2012-03-03 Glenn Morris <rgm@gnu.org>
407
408 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
409
410 2012-03-02 Eli Zaretskii <eliz@gnu.org>
411
412 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
413 position past the first glyph_row that ends at ZV. (Bug#10902)
414 (redisplay_window, next_element_from_string): Fix typos in
415 comments.
416 (redisplay_window): Pass to move_it_vertically the margin in
417 pixels, not in screen lines.
418
419 2012-03-02 Glenn Morris <rgm@gnu.org>
420
421 * buffer.c (buffer-list-update-hook): Doc fix.
422
423 2012-02-29 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
426 push_it before setting up the iterator for the first overlay
427 string, even if we have an empty string loaded.
428 (next_overlay_string): If there's an empty string on the iterator
429 stack, pop the stack. (Bug#10903)
430
431 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
432
433 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
434 Suggested by Stefan Monnier in
435 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
436 * alloc.c (widen_to_Lisp_Object): New static function.
437 (mark_memory): Also mark Lisp_Objects by fetching pointer words
438 and widening them to Lisp_Objects. This would work even if
439 USE_LSB_TAG is defined and wide integers are used, which might
440 happen in a future version of Emacs.
441
442 2012-02-25 Chong Yidong <cyd@gnu.org>
443
444 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
445 Doc fix.
446
447 * xselect.c (Fx_selection_exists_p): Doc fix.
448 (x_clipboard_manager_save_all): Print an informative message
449 before saving to clipboard manager.
450
451 2012-02-24 Chong Yidong <cyd@gnu.org>
452
453 * keyboard.c (process_special_events): Handle all X selection
454 requests in kbd_buffer, not just the next one (Bug#8869).
455
456 2012-02-23 Chong Yidong <cyd@gnu.org>
457
458 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
459 call when setting menu-bar-lines and tool-bar-lines parameters.
460 (unwind_create_frame_1): New helper function.
461
462 * window.c (inhibit_window_configuration_change_hook): New var.
463 (run_window_configuration_change_hook): Obey it.
464 (syms_of_window): Initialize it.
465
466 2012-02-22 Chong Yidong <cyd@gnu.org>
467
468 * xterm.c (x_draw_image_relief): Add missing type check for
469 Vtool_bar_button_margin (Bug#10743).
470
471 2012-02-21 Chong Yidong <cyd@gnu.org>
472
473 * fileio.c (Vfile_name_handler_alist): Doc fix.
474
475 * buffer.c (Fget_file_buffer): Protect against invalid file
476 handler return value.
477
478 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
479
480 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
481 when computing $valmask.
482
483 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
484 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
485 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
486 It's useless in that case, and it can cause problems on hosts
487 that allocate halves of EMACS_INT values separately.
488 Reported by Dan Horák. Diagnosed by Andreas Schwab in
489 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
490 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
491 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
492 it avoids undefined behavior on hosts where shifting right by more
493 than the word width has undefined behavior.
494
495 2012-02-19 Chong Yidong <cyd@gnu.org>
496
497 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
498 (Funhandled_file_name_directory, Ffile_name_as_directory)
499 (Fdirectory_file_name, Fexpand_file_name)
500 (Fsubstitute_in_file_name): Protect against invalid file handler
501 return values (Bug#10845).
502
503 2012-02-18 Eli Zaretskii <eliz@gnu.org>
504
505 * .gdbinit (pitx): Fix incorrect references to fields of the
506 iterator stack.
507
508 2012-02-17 Chong Yidong <cyd@gnu.org>
509
510 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
511
512 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
513
514 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
515 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
516
517 2012-02-15 Chong Yidong <cyd@gnu.org>
518
519 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
520 marked as special. Also, starting docstrings with * is obsolete.
521
522 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
523
524 * gnutls.c (emacs_gnutls_write): Fix last change.
525
526 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
527
528 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
529 send_process.
530
531 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
532
533 * keymap.c (Fsingle_key_description): Handle char ranges.
534
535 2012-02-12 Chong Yidong <cyd@gnu.org>
536
537 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
538 as that creates a dangerous corner case.
539
540 * window.c (Fdelete_window_internal): Invalidate the mouse
541 highlight (Bug#9904).
542
543 2012-02-12 Glenn Morris <rgm@gnu.org>
544
545 * xselect.c (Fx_own_selection_internal)
546 (Fx_get_selection_internal, Fx_disown_selection_internal)
547 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
548 * nsselect.m (Fx_own_selection_internal)
549 (Fx_disown_selection_internal, Fx_selection_exists_p)
550 (Fx_selection_owner_p, Fx_get_selection_internal):
551 Sync docs and argument specs with the xselect.c versions.
552
553 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
554
555 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
556
557 2012-02-11 Eli Zaretskii <eliz@gnu.org>
558
559 * w32select.c (Fx_selection_exists_p): Sync doc string and
560 argument list with xselect.c. (Bug#10783)
561
562 * w16select.c (Fx_selection_exists_p): Sync doc string and
563 argument list with xselect.c. (Bug#10783)
564
565 2012-02-10 Glenn Morris <rgm@gnu.org>
566
567 * fns.c (Fsecure_hash): Doc fix.
568
569 2012-02-09 Kenichi Handa <handa@m17n.org>
570
571 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
572
573 2012-02-07 Chong Yidong <cyd@gnu.org>
574
575 * buffer.c (Fbuffer_local_variables)
576 (buffer_lisp_local_variables): Handle unbound vars correctly;
577 don't let Qunbound leak into Lisp.
578
579 2012-02-07 Glenn Morris <rgm@gnu.org>
580
581 * image.c (Fimagemagick_types): Doc fix.
582
583 * image.c (imagemagick-render-type): Change it from a lisp object
584 to an integer. Move the doc here from the lisp manual.
585 Treat all values not equal to 0 the same.
586
587 2012-02-06 Chong Yidong <cyd@gnu.org>
588
589 * doc.c (store_function_docstring): Avoid applying docstring of
590 alias to base function (Bug#2603).
591
592 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
593
594 * .gdbinit (pp1, pv1): Remove redundant defines.
595 (pr): Use pp.
596
597 2012-02-04 Chong Yidong <cyd@gnu.org>
598
599 * nsterm.m: Declare a global (Bug#10694).
600
601 2012-02-04 Eli Zaretskii <eliz@gnu.org>
602
603 * w32.c (get_emacs_configuration_options):
604 Include --enable-checking, if specified, in the return value.
605
606 2012-02-04 Martin Rudalics <rudalics@gmx.at>
607
608 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
609 after rounding frame sizes. (Bug#9723)
610
611 2012-02-04 Eli Zaretskii <eliz@gnu.org>
612
613 * keyboard.c (adjust_point_for_property): Don't position point
614 before BEGV. (Bug#10696)
615
616 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
617
618 Handle overflow when computing char display width (Bug#9496).
619 * character.c (char_width): Return EMACS_INT, not int.
620 (char_width, c_string_width): Check for overflow when
621 computing the width; this is possible now that individual
622 characters can have unbounded width. Problem introduced
623 by merge from Emacs 23 on 2012-01-19.
624
625 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
626
627 * dbusbind.c (Fdbus_register_method): Mention the return value
628 :ignore in the docstring.
629
630 2012-02-02 Glenn Morris <rgm@gnu.org>
631
632 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
633
634 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
635 Unconditionally set to t. (Bug#10673)
636 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
637 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
638 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
639
640 2012-02-02 Kenichi Handa <handa@m17n.org>
641
642 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
643 0, do not call append_composite_glyph.
644
645 2012-02-02 Kenichi Handa <handa@m17n.org>
646
647 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
648 NULL (Bug#6988).
649 (x_produce_glyphs): If the component of a composition is a null
650 string, set it->pixel_width to 1 to avoid zero-width glyph.
651
652 2012-02-01 Eli Zaretskii <eliz@gnu.org>
653
654 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
655 first 2 arguments are identical. This makes inserting large
656 output from a subprocess an order of magnitude faster on
657 MS-Windows, where all sbrk'ed memory is always contiguous.
658
659 2012-01-31 Glenn Morris <rgm@gnu.org>
660
661 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
662 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
663 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
664
665 2012-01-29 Glenn Morris <rgm@gnu.org>
666
667 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
668
669 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
670
671 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
672
673 2012-01-28 Chong Yidong <cyd@gnu.org>
674
675 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
676
677 2012-01-26 Chong Yidong <cyd@gnu.org>
678
679 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
680
681 * search.c (Fsearch_forward, Fsearch_backward): Document negative
682 repeat counts (Bug#10507).
683
684 2012-01-26 Glenn Morris <rgm@gnu.org>
685
686 * lread.c (syms_of_lread): Doc fix.
687
688 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
689
690 * coding.c (encode_designation_at_bol): Change return value to
691 EMACS_INT.
692
693 2012-01-25 Chong Yidong <cyd@gnu.org>
694
695 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
696
697 2012-01-21 Chong Yidong <cyd@gnu.org>
698
699 * floatfns.c (Fcopysign): Make the second argument non-optional,
700 since nil is not allowed anyway.
701
702 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
703
704 * process.c (read_process_output): Use p instead of XPROCESS (proc).
705 (send_process): Likewise.
706
707 2012-01-19 Martin Rudalics <rudalics@gmx.at>
708
709 * window.c (save_window_save, Fcurrent_window_configuration)
710 (Vwindow_persistent_parameters): Do not use Qstate.
711 Rewrite doc-strings.
712
713 2012-01-19 Kenichi Handa <handa@m17n.org>
714
715 * character.c (char_width): New function.
716 (Fchar_width, c_string_width, lisp_string_width):
717 Use char_width (Bug#9496).
718
719 2012-01-16 Martin Rudalics <rudalics@gmx.at>
720
721 * window.c (Vwindow_persistent_parameters): New variable.
722 (Fset_window_configuration, save_window_save): Handle persistent
723 window parameters.
724
725 2012-01-14 Eli Zaretskii <eliz@gnu.org>
726
727 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
728 thrashing the stack of the thread. (Bug#9087)
729
730 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
731
732 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
733
734 2012-01-11 Eli Zaretskii <eliz@gnu.org>
735
736 * xdisp.c (rows_from_pos_range): Handle the case where the
737 highlight ends on a newline. (Bug#10464)
738 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
739 he end column for display of highlight that ends on a newline
740 before a R2L line.
741
742 2012-01-11 Glenn Morris <rgm@gnu.org>
743
744 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
745 from load-path also when installation-directory is nil. (Bug#10208)
746
747 2012-01-10 Glenn Morris <rgm@gnu.org>
748
749 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
750
751 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
752 Update template values to be closer to their typical values these days.
753
754 2012-01-09 Eli Zaretskii <eliz@gnu.org>
755
756 * xdisp.c (rows_from_pos_range): Accept additional argument
757 DISP_STRING, and accept any glyph in a row whose object is that
758 string as eligible for mouse highlight. Fixes mouse highlight of
759 display strings from overlays. (Bug#10464)
760
761 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
762
763 emacs: fix an auto-save permissions race condition (Bug#10400)
764 * fileio.c (auto_saving_dir_umask): New static var.
765 (Fmake_directory_internal): Use it.
766 (do_auto_save_make_dir): Set it, instead of invoking chmod after
767 creating the directory. The old code temporarily assigns
768 too-generous permissions to the directory.
769 (do_auto_save_eh): Clear it.
770 (Fdo_auto_save): Catch all errors, not just file errors, so
771 that the var is always cleared.
772
773 2012-01-07 Eli Zaretskii <eliz@gnu.org>
774
775 * search.c (scan_buffer): Pass character positions to
776 know_region_cache, not byte positions. (Bug#6540)
777
778 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
779
780 * w32.c (sys_rename): Report EXDEV when rename of a directory
781 fails because the target is on another logical disk. (Bug#10284)
782
783 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
784
785 * xterm.c (x_embed_request_focus): New function.
786
787 * xterm.h: Add prototype.
788
789 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
790
791 2012-01-05 Glenn Morris <rgm@gnu.org>
792
793 * emacs.c (emacs_copyright): Update short copyright year to 2012.
794
795 2012-01-01 Eli Zaretskii <eliz@gnu.org>
796
797 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
798 Load gnutls_transport_set_lowat only if GnuTLS version is below
799 2.11.1.
800 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
801 GnuTLS versions below 2.11.1.
802
803 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
804
805 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
806 to the doc string advising against its use for altering the way
807 windows are scrolled.
808
809 2011-12-28 Kenichi Handa <handa@m17n.org>
810
811 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
812 coding-system ASCII compatible only when it does not produce BOM
813 on encoding (Bug#10383).
814
815 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
816
817 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
818 can scroll.
819 (create_and_show_popup_menu): Always use menu_position_func for
820 Gtk3 (Bug#10361).
821
822 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
823
824 * callint.c (Fcall_interactively): Don't truncate prompt string.
825
826 2011-12-23 Eli Zaretskii <eliz@gnu.org>
827
828 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
829 property that ends at ZV, so that the bidi iteration could be
830 resumed from there (after widening). (Bug#10360)
831
832 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
833
834 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
835
836 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
837
838 * nsterm.m (x_free_frame_resources):
839 Release f->output_data.ns->miniimage.
840 (ns_index_color): Fix indentation. Do not retain
841 color_table->colors[i].
842
843 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
844 before returning.
845
846 * nsfns.m (x_set_background_color): Assign return value from
847 ns_index_color to face-background instead of NSColor*.
848 (ns_implicitly_set_icon_type): Fix indentation.
849 Change assignment in for loop to comparison.
850
851 * emacs.c (ns_pool): New variable.
852 (main): Assign ns_pool.
853 (Fkill_emacs): Call ns_release_autorelease_pool.
854
855 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
856 autorelease fdesc, release fdAttrs and tdict.
857 (ns_get_covering_families): Release charset.
858 (ns_findfonts): Release NSFontDescriptor created with new.
859 (ns_uni_to_glyphs): Fix indentation.
860 (setString): Release attrStr before assigning new value.
861
862 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
863
864 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
865 and NS_IMPL_COCOA.
866 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
867 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
868
869 2011-12-18 David Reitter <reitter@cmu.edu>
870
871 * nsterm.m (ns_term_init): Subscribe for notifications
872 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
873 to method trackingNotification in EmacsMenu.
874
875 * nsmenu.m (trackingMenu): New variable.
876 (trackingNotification): New method (from Aquamacs).
877 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
878 from Aquamacs (Bug#7030).
879
880 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
881
882 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
883 (symbol_to_nsstring): Fix indentation.
884 (ns_symbol_to_pb): New function.
885 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
886 (Fns_rotate_cut_buffers_internal): Remove.
887 (Fns_store_selection_internal): Rename from
888 Fns_store_cut_buffer_internal.
889 (ns_get_foreign_selection, Fx_own_selection_internal)
890 (Fx_disown_selection_internal, Fx_selection_exists_p)
891 (Fns_get_selection_internal, Fns_store_selection_internal):
892 Use ns_symbol_to_pb and check if return value is nil.
893 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
894 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
895 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
896 renamed to Sns_store_selection_internal.
897 (ns_handle_selection_request): Move code to Fx_own_selection_internal
898 and remove this function.
899 (ns_handle_selection_clear): Remove, never used.
900 (Fx_own_selection_internal): Move code from ns_handle_selection_request
901 here.
902
903 2011-12-17 Ken Brown <kbrown@cornell.edu>
904
905 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
906 GID is unknown (Bug#10257).
907
908 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
909
910 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
911 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
912 which caused a build failure on GNU/Linux IA-64. This problem was
913 introduced by my 2011-10-07 patch.
914
915 2011-12-15 Juri Linkov <juri@jurta.org>
916
917 * image.c (imagemagick_error): New function. (Bug#10112)
918 (imagemagick_load_image): Comment out `MagickSetResolution' call.
919 Use `imagemagick_error' where ImageMagick functions return
920 `MagickFalse'.
921 (Fimagemagick_types): Add `Fnreverse' to return the list in the
922 proper order.
923
924 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
925
926 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
927 fill background (Bug#8992).
928
929 2011-12-13 Martin Rudalics <rudalics@gmx.at>
930
931 * window.c (Vwindow_combination_resize)
932 (Vwindow_combination_limit): Use t instead of non-nil in
933 doc-strings.
934 (Vrecenter_redisplay): Add first sentence of doc-string on
935 separate line.
936 (Frecenter): Fix doc-string typo.
937
938 2011-12-11 Kenichi Handa <handa@m17n.org>
939
940 * coding.c (Funencodable_char_position): Pay attention to the
941 buffer text relocation (Bug#9389).
942
943 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
944
945 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
946 gtk_init (Bug#10100).
947
948 2011-12-10 Eli Zaretskii <eliz@gnu.org>
949
950 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
951 IT->string is nil. (Bug#10263)
952
953 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
954
955 * nsterm.h (x_free_frame_resources): Declare.
956
957 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
958 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
959
960 * nsterm.h (ns_get_defaults_value): Declare.
961
962 * nsterm.m (ns_default): Call ns_get_defaults_value.
963
964 2011-12-09 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
967 (Bug#10170)
968
969 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
970
971 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
972 that where the value of an _OBJC_* symbol points to is in the .bss
973 section (Bug#10240).
974
975 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
976
977 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
978 after the loop to call ccl_driver at least once (Bug#8619).
979
980 2011-12-08 Kenichi Handa <handa@m17n.org>
981
982 * ftfont.c (get_adstyle_property): Fix previous change
983 (Bug#10233).
984
985 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
986
987 * w32.c (init_environment): If no_site_lisp, remove site-lisp
988 dirs from the default value of EMACSLOADPATH (bug#10208).
989
990 2011-12-07 Glenn Morris <rgm@gnu.org>
991
992 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
993 installation and source directories as well. (Bug#10208)
994
995 2011-12-06 Chong Yidong <cyd@gnu.org>
996
997 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
998
999 2011-12-06 Glenn Morris <rgm@gnu.org>
1000
1001 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1002 as an error, not just -1. (Bug#10217)
1003
1004 2011-12-05 Chong Yidong <cyd@gnu.org>
1005
1006 * keyboard.c (process_special_events): New function.
1007 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1008
1009 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 * coding.c (encode_designation_at_bol): Don't use uninitialized
1012 local variable (Bug#9318).
1013
1014 2011-12-05 Kenichi Handa <handa@m17n.org>
1015
1016 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1017 return Qnil (Bug#8046, Bug#10193).
1018
1019 2011-12-05 Kenichi Handa <handa@m17n.org>
1020
1021 * coding.c (encode_designation_at_bol): New args charbuf_end and
1022 dst. Return the number of produced bytes. Callers changed.
1023 (coding_set_source): Return how many bytes coding->source was
1024 relocated.
1025 (coding_set_destination): Return how many bytes
1026 coding->destination was relocated.
1027 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1028 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1029
1030 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1031
1032 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1033 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1034 macro (Bug#9318).
1035
1036 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1037
1038 The following changes are to fix Bug#9318.
1039
1040 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1041 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1042 (encode_coding_iso_2022, encode_coding_sjis)
1043 (encode_coding_big5, encode_coding_charset): Use the above macros.
1044
1045 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1046
1047 * lisp.h (process_quit_flag): Fix external declaration.
1048
1049 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1050
1051 Don't macro-inline non-performance-critical code.
1052 * eval.c (process_quit_flag): New function.
1053 * lisp.h (QUIT): Use it.
1054
1055 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1056
1057 * nsfns.m (get_geometry_from_preferences): New function.
1058 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1059
1060 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1061
1062 * emacs.c (Qkill_emacs): Define.
1063 (syms_of_emacs): Initialize it.
1064 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1065 Qquit_flag to `kill-emacs' instead.
1066 (quit_throw_to_read_char): Add parameter `from_signal'.
1067 All callers changed. Call Fkill_emacs if requested and safe.
1068 * lisp.h (QUIT): Call Fkill_emacs if requested.
1069
1070 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1071
1072 * widget.c (update_wm_hints): Return if wmshell is null.
1073 (widget_update_wm_size_hints): New function.
1074
1075 * widget.h (widget_update_wm_size_hints): Declare.
1076
1077 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1078 widget_update_wm_size_hints (Bug#10104).
1079
1080 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1081
1082 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1083 before a newline, prepare the bidi iterator for consuming the
1084 newline, and keep the current paragraph direction. (Bug#10183)
1085 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1086
1087 2011-12-02 Juri Linkov <juri@jurta.org>
1088
1089 * search.c (Fword_search_regexp): New Lisp function created from
1090 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1091 (Fword_search_backward, Fword_search_forward)
1092 (Fword_search_backward_lax, Fword_search_forward_lax):
1093 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1094 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1095
1096 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1097
1098 * fileio.c (Finsert_file_contents): Move after-change-function call
1099 to before the "handled:" label, since all "goto handled" appear in
1100 cases where the *-change-functions have already been properly called
1101 (bug#10117).
1102
1103 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1104
1105 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1106 waiting for input. (Bug#10169)
1107
1108 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1109
1110 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1111 verifies glyph row's hash code--we have just reallocated the
1112 glyphs, so their contents can be complete garbage. (Bug#10164)
1113
1114 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1115
1116 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1117
1118 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1119
1120 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1121 attributes are tested _before_ calling verify_row_hash, to protect
1122 against GCC re-ordering of the tests. (Bug#10164)
1123
1124 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1125
1126 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1127
1128 * xterm.c (handle_one_xevent): Only set async_visible and friends
1129 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1130 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1131 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1132
1133 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1136 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1137 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1138 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1139 All uses changed to use GCPRO1 etc.
1140 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1141 Revert to old implementation (i.e., before 2011-03-11).
1142
1143 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1144
1145 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1146 of scroll runs so as to avoid assigning disabled bogus rows and
1147 unnecessary graphics copy operations.
1148
1149 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1150
1151 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1152 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1153 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1154 (malloc, free, realloc, calloc): Redirect to e_* only when
1155 compiling Emacs.
1156
1157 * lisp.h (GCTYPEBITS): Move before first use.
1158 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1159 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1160 this macro definition.
1161
1162 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1163 _MSC_VER.
1164
1165 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1166
1167 * gtkutil.c (xg_create_frame_widgets):
1168 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1169 present with Gtk+ 2.0.
1170
1171 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 * fileio.c (Finsert_file_contents): Undo previous change; see
1174 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1175
1176 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Rename locals to avoid shadowing.
1179 * fileio.c (Finsert_file_contents):
1180 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1181 * process.c (wait_reading_process_output):
1182 Rename inner 'proc' to 'p' to avoid shadowing.
1183 Indent for consistency with usual Emacs style.
1184
1185 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1186
1187 * xdisp.c (redisplay_window): If cursor row is not fully visible
1188 after recentering, and scroll-conservatively is set to a large
1189 number, scroll window by a few more lines to make the cursor fully
1190 visible and out of scroll-margin. (Bug#10105)
1191 (start_display): Don't move to the next line if the display should
1192 start at a newline that is part of a display vector or an overlay
1193 string. (Bug#10119)
1194
1195 2011-11-24 Juri Linkov <juri@jurta.org>
1196
1197 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1198 after the `MagickPingImage' call. (Bug#10112)
1199
1200 2011-11-23 Chong Yidong <cyd@gnu.org>
1201
1202 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1203
1204 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1205
1206 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1207 making another buffer current. (Bug#10114)
1208
1209 2011-11-23 Glenn Morris <rgm@gnu.org>
1210
1211 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1212
1213 2011-11-23 Chong Yidong <cyd@gnu.org>
1214
1215 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1216 using it (Bug#5984).
1217
1218 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1219
1220 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1221 and header-lines, as they don't have one computed for them.
1222 (Bug#10098)
1223
1224 * .gdbinit (prow): Make displayed values more self-explaining.
1225 Add row's hash code.
1226
1227 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1228
1229 * process.c (wait_reading_process_output): Fix asynchrounous
1230 GnuTLS socket handling on some versions of the GnuTLS library.
1231 (wait_reading_process_output): Add comment and URL.
1232
1233 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1234
1235 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1236
1237 2011-11-21 Chong Yidong <cyd@gnu.org>
1238
1239 * window.c (Fnext_window, Fprevious_window): Doc fix.
1240
1241 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1242
1243 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1244
1245 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1248
1249 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1250
1251 * window.c (Fset_window_combination_limit): Rename argument
1252 STATUS to LIMIT.
1253 (Vwindow_combination_limit): Remove "status" from doc-string.
1254
1255 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1256
1257 * m/ibms390.h: Remove.
1258 * m/ibms390x.h: Don't include "ibms390.h".
1259
1260 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1261
1262 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1263 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1264
1265 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1266
1267 * casetab.c (Fset_case_table):
1268 * charset.c (Fcharset_after): Fix typos.
1269
1270 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1273 Otherwise, valgrind does not work on some platforms.
1274 Problem reported by Andreas Schwab in
1275 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1276 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1277 is set, removing the need for VIRT_ADDRESS_VARIES.
1278 (PURE_P): Use a more-efficient implementation that needs just one
1279 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1280 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1281 to 4 (xorl, subq, cmpq, setbe).
1282 * alloc.c (pure): Always extern now, since that's the
1283 VIRT_ADDR_VARIES behavior.
1284 (PURE_POINTER_P): Use a single comparison, not two, for
1285 consistency with the new puresize.h.
1286 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1287 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1288 Remove VIRT_ADDR_VARIES no longer needed.
1289
1290 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1291
1292 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1293 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1294 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1295 behave as if the cursor position were at the window margin.
1296
1297 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1298 and the cursor position is out of bounds, behave as if the cursor
1299 position were at the window margin. (Bug#10075)
1300
1301 2011-11-18 Chong Yidong <cyd@gnu.org>
1302
1303 * window.c (Fwindow_combination_limit): Make first argument
1304 non-optional, since it is meaningless for live windows like the
1305 selected window.
1306
1307 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1308
1309 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1310
1311 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1312
1313 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1314 (graft_intervals_into_buffer): Simplify.
1315
1316 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1317
1318 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1319 hash values of the two rows.
1320 (copy_row_except_pointers): Preserve the used[] arrays and the
1321 hash values of the two rows. (Bug#10035)
1322 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1323
1324 * xdisp.c (row_hash): New function, body extracted from
1325 compute_line_metrics.
1326 (compute_line_metrics): Call row_hash, instead of computing the
1327 hash code inline.
1328
1329 * dispnew.c (verify_row_hash): Call row_hash for computing the
1330 hash code of a row, instead of duplicating code from xdisp.c.
1331
1332 * dispextern.h (row_hash): Add prototype.
1333
1334 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1335
1336 * frame.c (delete_frame): Don't delete the terminal when the last
1337 X frame is closed if emacs is built with GTK toolkit.
1338
1339 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1340
1341 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1342
1343 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1344
1345 * window.c (Vwindow_splits): Rename to
1346 Vwindow_combination_resize. Suggested by Juri Linkov.
1347 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1348 of Vwindow_splits.
1349
1350 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1351
1352 * nsfns.m (Fns_font_name):
1353 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1354
1355 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1356
1357 * window.h (window): Rename slot "nest" to "combination_limit".
1358 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1359 (Fset_window_nest): Rename to Fset_window_combination_limit.
1360 (Vwindow_nest): Rename to Vwindow_combination_limit.
1361 (recombine_windows, make_parent_window, make_window)
1362 (Fsplit_window_internal, saved_window)
1363 (Fset_window_configuration, save_window_save): Rename all
1364 occurrences of window_nest to window_combination_limit.
1365
1366 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1367
1368 * image.c (imagemagick_load_image): Fix typo.
1369
1370 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1371
1372 * xdisp.c (display_line): Move the call to
1373 highlight_trailing_whitespace before the call to
1374 compute_line_metrics, since the latter needs to see the final
1375 faces of all the glyphs to compute ROW's hash value.
1376 Fixes assertion violations in row_equal_p. (Bug#10035)
1377
1378 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1381 just return (bug#10044).
1382
1383 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1384
1385 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1386 with user-defined heap size. Bump the default size of the temacs
1387 heap to 27MB, to avoid memory warning when running temacs.
1388 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1389
1390 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1391 current_matrix and desired_matrix. (Bug#9990)
1392 (verify_row_hash) [XASSERTS]: New function.
1393 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1394 that the hash value of glyph rows is correct.
1395
1396 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1397
1398 * window.h (window): Remove splits slot.
1399 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1400 (Fdelete_other_windows_internal, make_parent_window)
1401 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1402 (Fset_window_configuration, save_window_save): Don't deal with
1403 split status of windows.
1404 (saved_window): Remove splits slot.
1405 (Vwindow_splits): Rewrite doc-string.
1406
1407 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1408
1409 * xfns.c (unwind_create_frame):
1410 * nsfns.m (unwind_create_frame):
1411 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1412 Vframe_list (Bug#9999).
1413
1414 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1415
1416 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1417
1418 2011-11-11 Kenichi Handa <handa@m17n.org>
1419
1420 * callproc.c (Fcall_process): Set the member dst_multibyte of
1421 process_coding.
1422
1423 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1424
1425 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1426 avoid a crash (bug#9496).
1427
1428 2011-11-09 Chong Yidong <cyd@gnu.org>
1429
1430 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1431 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1432
1433 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1436
1437 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 Avoid some portability problems by eschewing 'extern inline' functions.
1440 The trivial performance wins aren't worth the portability hassles; see
1441 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1442 et seq.
1443 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1444 (window_box_width, window_box_left, window_box_left_offset)
1445 (window_box_right, window_box_right_offset): Undo previous change,
1446 by removing the "extern"s.
1447 * intervals.c (adjust_intervals_for_insertion)
1448 (adjust_intervals_for_deletion): Undo previous change,
1449 making these static again.
1450 (offset_intervals, temp_set_point_both, temp_set_point)
1451 (copy_intervals_to_string): No longer inline.
1452 * xdisp.c (window_text_bottom_y, window_box_width)
1453 (window_box_height, window_box_left_offset)
1454 (window_box_right_offset, window_box_left, window_box_right)
1455 (window_box): No longer inline.
1456
1457 2011-11-08 Chong Yidong <cyd@gnu.org>
1458
1459 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1460 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1461 Signal an error if not a live window.
1462 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1463 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1464
1465 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1466
1467 * lisp.h (syms_of_abbrev): Remove declaration.
1468 Reported by CHENG Gao <chenggao@royau.me>.
1469
1470 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1471
1472 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1473 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1474 of temacs in GUI mode.
1475
1476 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1477
1478 * window.h: Declare delete_all_child_windows instead of
1479 delete_all_subwindows.
1480 * window.c (Fwindow_nest, Fset_window_nest)
1481 (Fset_window_new_total, Fset_window_new_normal)
1482 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1483 (delete_all_subwindows): Rename to delete_all_child_windows.
1484 (Fdelete_other_windows_internal, Fset_window_configuration):
1485 Call delete_all_child_windows instead of delete_all_subwindows.
1486 * frame.c (delete_frame): Call delete_all_child_windows instead
1487 of delete_all_subwindows.
1488
1489 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1492 This is also needed for porting to any host where GC_MARK_STACK is
1493 not GC_MAKE_GCPROS_NOOPS.
1494 (which_symbols): Use it.
1495
1496 2011-11-07 Kenichi Handa <handa@m17n.org>
1497
1498 * coding.c (coding_set_destination): Check coding->src_pos only
1499 when coding->src_object is a buffer (bug#9910).
1500
1501 * process.c (send_process): Set the member src_multibyte of coding
1502 to 0 (bug#9911) when sending a unibyte text.
1503
1504 * callproc.c (Fcall_process): Set the member src_multibyte of
1505 process_coding to 0 (bug#9912).
1506
1507 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1508
1509 * xmenu.c (cleanup_widget_value_tree): New function.
1510 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1511 calling free_menubar_widget_value_tree directly (Bug#9830).
1512
1513 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1514
1515 Fix some portability problems with 'inline'.
1516 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1517 (window_box_width, window_box_left, window_box_left_offset)
1518 (window_box_right, window_box_right_offset): Declare extern.
1519 Otherwise, these inline functions do not conform to C99 and
1520 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1521 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1522 * intervals.c (adjust_intervals_for_insertion)
1523 (adjust_intervals_for_deletion): Now extern, because otherwise the
1524 extern inline functions 'offset_intervals' couldn't refer to it.
1525 (static_offset_intervals): Remove.
1526 (offset_intervals): Rewrite using the old contents of
1527 static_offset_intervals. The old version didn't conform to C99
1528 because an extern inline function contained a reference to an
1529 identifier with static linkage.
1530
1531 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1532
1533 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1534 GC.
1535
1536 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1539 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1540 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1541 return Qleft_to_right.
1542
1543 2011-11-06 Chong Yidong <cyd@gnu.org>
1544
1545 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1546 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1547 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1548 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1549 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1550 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1551 (Fwindow_vscroll): Doc fix.
1552 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1553 argument, since it makes no sense to pass a live window and for
1554 consistency with window-child.
1555
1556 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1557
1558 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1559 support MSVC.
1560
1561 2011-11-05 Jason Rumney <jasonr@gnu.org>
1562
1563 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1564 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1565 fonts (Bug#6029).
1566 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1567 bitwise arithmetic preventing use of unicode-sip and non-truetype
1568 opentype fonts.
1569
1570 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1571
1572 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1573 "emacs"-only part.
1574
1575 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1576 initialization code to keep similarity to xfns.c after changes
1577 from 2011-11-05.
1578
1579 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1580
1581 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1582 (unwind_create_frame): New function (Bug#9943).
1583 (Fx_create_frame): Restructure code to be more similar to the one in
1584 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1585 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1586 Move terminal->reference_count++ just before making the frame official
1587 (Bug#9943).
1588
1589 * nsterm.m (x_free_frame_resources): New function.
1590 (x_destroy_window): Move code to x_free_frame_resources.
1591
1592 * xfns.c (unwind_create_frame): Fix comment.
1593 (Fx_create_frame, x_create_tip_frame):
1594 Move terminal->reference_count++ just before making the frame
1595 official. Move initialization of image_cache_refcount and
1596 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1597
1598 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1599
1600 Support MSVC build with newer versions of Visual Studio.
1601 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1602 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1603 nt/gmake.defs.
1604
1605 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1606 which are not supported by MSVC.
1607 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1608 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1609 bitfields.
1610 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1611 types in bitfields.
1612 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1613
1614 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1615
1616 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1617
1618 Support MSVC build with newer versions of Visual Studio.
1619 * w32.c: Don't include w32api.h for MSVC.
1620 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1621
1622 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1623 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1624 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1625 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1626 e_* cousins.
1627 (alloca) [_MSC_VER]: Define to _alloca.
1628
1629 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1630
1631 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1632
1633 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1634
1635 * xdisp.c (note_mouse_highlight): If either of
1636 previous/next-single-property-change returns nil, treat that as
1637 the beginning or the end of the buffer. (Bug#9955)
1638
1639 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1640
1641 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1642 label is not null (Bug#9951).
1643 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1644 may be NULL.
1645
1646 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1647
1648 * window.c (Fwindow_body_size): Mention in the doc string that the
1649 return value is in frame's canonical units. (Bug#9949)
1650
1651 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1652
1653 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1654
1655 * w32fns.c (unwind_create_frame): If needed, free the glyph
1656 matrices of the partially constructed frame. (Bug#9943)
1657 * xfns.c (unwind_create_frame): Likewise.
1658
1659 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1660
1661 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1662 Don't stop backward scan on the continuation glyph, even though
1663 its CHARPOS is positive.
1664 (mouse_face_from_buffer_pos, note_mouse_highlight):
1665 Rename cover_string to disp_string.
1666
1667 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1668
1669 * window.c (temp_output_buffer_show): Don't use
1670 Vtemp_buffer_show_specifiers.
1671 (Vtemp_buffer_show_specifiers): Remove unused variable.
1672
1673 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1674
1675 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1676 past the beginning of the current glyph matrix.
1677
1678 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1679
1680 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1681 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1682 HAVE_GTK3 (Bug#9869).
1683
1684 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1685 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1686
1687 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1688
1689 * xterm.c: Declare x_handle_net_wm_state to return int.
1690 (handle_one_xevent): Check if we are iconified but don't have
1691 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1692 (get_current_wm_state): Return non-zero if not hidden,
1693 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1694 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1695 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1696 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1697
1698 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1701 so that this new function doesn't get optimized away by a
1702 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1703
1704 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1705
1706 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1707
1708 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1709
1710 Fix the `xbytecode' command.
1711 * .gdbinit (xprintbytestr): New command.
1712 (xwhichsymbols): Rename from `which'; all callers changed.
1713 (xbytecode): Print the byte-code string as well.
1714
1715 2011-10-29 Kim Storm <storm@cua.dk>
1716
1717 * alloc.c (which_symbols): New function.
1718
1719 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1720
1721 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1722 line. (Bug#9903)
1723
1724 2011-10-29 Glenn Morris <rgm@gnu.org>
1725
1726 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1727 Not clear what it was for, and it causes various bugs. (Bug#9839)
1728
1729 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1730
1731 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1732 possible random value that matches one of those tested as
1733 condition to clear the mouse face.
1734
1735 2011-10-28 Chong Yidong <cyd@gnu.org>
1736
1737 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1738
1739 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1740
1741 * window.c (make_window): Initialize phys_cursor_on_p.
1742
1743 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1744
1745 * lisp.h (struct Lisp_Symbol): Update comments.
1746
1747 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1750
1751 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1752
1753 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1754 <oslsachem@gmail.com> for helping to debug this.
1755
1756 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1757 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1758 (g_b_init_get_glyph_outline_w): New static variables.
1759 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1760 (GetGlyphOutlineW_Proc): New typedefs.
1761 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1762 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1763 New functions.
1764 (w32font_open_internal, compute_metrics):
1765 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1766 instead of calling the "wide" APIs directly.
1767
1768 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1769
1770 * w32.h (syms_of_w32font): Add prototype.
1771
1772 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1773
1774 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1775 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1776 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1777 (Fmove_to_window_line): Doc fix.
1778
1779 2011-10-27 Chong Yidong <cyd@gnu.org>
1780
1781 * process.c (make_process): Set gnutls_state to NULL.
1782
1783 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1784 non-NULL, regardless of GNUTLS_INITSTAGE.
1785 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1786 an error. Set process slots as soon as we allocate them.
1787
1788 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1789
1790 2011-10-27 Chong Yidong <cyd@gnu.org>
1791
1792 * gnutls.c (emacs_gnutls_deinit): New function.
1793 Deallocate credentials structures as well as calling gnutls_deinit.
1794 (Fgnutls_deinit, Fgnutls_boot): Use it.
1795
1796 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1797 (deactivate_process): Call emacs_gnutls_deinit.
1798
1799 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1800
1801 * image.c (x_create_x_image_and_pixmap):
1802 * w32.c (sys_rename, w32_delayed_load):
1803 * w32font.c (fill_in_logfont):
1804 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1805
1806 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1807
1808 * w32fns.c (w32_default_color_map): New function,
1809 extracted from Fw32_default_color_map.
1810 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1811
1812 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1813
1814 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1815
1816 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1817
1818 * keyboard.c (test_undefined): New function (bug#9751).
1819 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1820
1821 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1822
1823 * sysdep.c (init_sys_modes): Fix the check for the controlling
1824 terminal (Bug#6649).
1825
1826 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1827
1828 * dispextern.h (struct bidi_it): New member next_en_type.
1829
1830 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1831 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1832 current character, check also for next_en_type being WEAK_EN.
1833 (bidi_resolve_weak): Don't enter the expensive loop if the current
1834 position is before next_en_pos. Record the bidi type of the first
1835 non-ET, non-BN character we find, in addition to its position.
1836 (bidi_level_of_next_char): Invalidate next_en_type when
1837 next_en_pos is over-stepped.
1838
1839 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1842 * editfns.c: Rewrite current-time-zone so that it invokes
1843 the equivalent of (format-time-string "%Z") to get the time zone name.
1844 This fixes a bug when the time zone name contains characters that
1845 need converting from the system time locale to Emacs internal format.
1846 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1847 that patch fixed format-time-string to do the conversion, but
1848 I forgot to fix current-time-zone.
1849 (format_time_string): New function, containing most of
1850 what Fformat_time_string used to contain.
1851 (Fformat_time_string): Rewrite in terms of format_time_string.
1852 This doesn't change this function's behavior.
1853 (current-time-zone): Rewrite to use format_time_string.
1854 This fixes the bug reported by Michael Schierl in
1855 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1856 Jason Rumney's 2007-06-07 change worked around this bug, but
1857 didn't fix it.
1858 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1859
1860 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (start_display): If the character at POS is displayed
1863 via a display vector, reset IT->current.dpvec_index to zero.
1864 (try_window_reusing_current_matrix): If a line ends in a display
1865 vector or the next line starts in a display vector, continue
1866 redrawing the window even though the character position of
1867 start_row was reached.
1868 (Bug#9771, part 2)
1869
1870 2011-10-18 Chong Yidong <cyd@gnu.org>
1871
1872 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1873 with nobreak-char-display too.
1874
1875 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1876
1877 Fix part 3 of bug#9771.
1878 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1879 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1880 non-neutral characters if the current character is a paragraph
1881 separator (a.k.a. Newline). This avoids running the same
1882 expensive loop twice, once when we consume the preceding newline
1883 and the other time when the line actually needs to be displayed.
1884 Avoid the loop when we see neutrals on the base embedding level
1885 following a character whose directionality is the same as the
1886 paragraph's. This avoids running the expensive loop when a line
1887 ends in a long sequence of neutrals, like control characters.
1888 Add assertion against STRONG_AL type. Slightly rearrange code
1889 that determines the type of a neutral given the first non-neutral
1890 that follows it.
1891 (bidi_level_of_next_char): Set next_en_pos to zero when
1892 invalidating its info.
1893
1894 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1895
1896 * xdisp.c (push_display_prop): Determine whether to record string
1897 or buffer position by IT->string, not by IT->method. Allow
1898 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1899 (move_it_vertically_backward): Don't look for character position
1900 immediately after the newline when in a continuation line.
1901 (Bug#9771, part 1)
1902
1903 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1904
1905 * window.c (coordinates_in_window): Rewrite and delabelize
1906 vertical border check. (Bug#5357) (Bug#9618)
1907
1908 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1909
1910 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1911 errors in XSetWindowBorder (bug#9310).
1912
1913 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1914
1915 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1916 avoid crash when xmalloc overrun checking is enabled.
1917
1918 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1919
1920 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1921 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1922 cursor motion with <left> and <right> arrow keys.
1923
1924 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1925 some callers set that themselves.
1926
1927 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1928
1929 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1930 display string and the previous row comes from the same string and
1931 is empty. (Bug#9739) (Bug#9738)
1932
1933 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1934
1935 * doc.c (get_doc_string): Encode file name (bug#9735).
1936
1937 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1938
1939 * bidi.c (bidi_level_of_next_char):
1940 * xdisp.c (get_visually_first_element): Remove old incorrect
1941 comments regarding the Unicode Line Separator character.
1942
1943 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1944
1945 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1946
1947 * alloc.c (Fgc_status): Do not access beyond zombies array
1948 boundary if nzombies > MAX_ZOMBIES.
1949 * alloc.c (dump_zombies): Add missing format specifier.
1950
1951 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1954 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1955
1956 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1957 Some packages use them to denote characters with modifiers.
1958
1959 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1960
1961 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1962 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1963 matching a pp-number. Rename parameter var to var1.
1964
1965 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1966
1967 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1968
1969 2011-10-08 Glenn Morris <rgm@gnu.org>
1970
1971 * callint.c (Fcall_interactively): Give a more explicit error for the
1972 'c' case with a non-character input. (Bug#8479)
1973
1974 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1975
1976 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1977 lines.
1978 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1979 lines that are hscrolled on the left.
1980
1981 * dispnew.c (buffer_posn_from_coords): Account for a possible
1982 presence of header-line. (Bug#4426)
1983
1984 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1985
1986 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1987 Don't advertise functionality which we discourage or doesn't work.
1988
1989 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1992 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1993 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1994 this makes Emacs dump core during garbage collection on rare
1995 occasions. sizeof is obviously inferior to offsetof here, so
1996 stick with offsetof.
1997 (GC_POINTER_ALIGNMENT): New macro.
1998 (mark_memory): Omit 3rd (offset) arg; caller changed.
1999 Don't assume EMACS_INT alignment is the same as pointer alignment.
2000
2001 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2002
2003 * keyboard.c (read_key_sequence_remapped): New var.
2004 (read_key_sequence): Compute remapping in the right buffer.
2005 (command_loop_1): Use read_key_sequence's remapping directly.
2006
2007 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2008
2009 * dired.c (file_name_completion): Don't expand file name.
2010 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2011 before checking file name handler.
2012
2013 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2014 they've been requested explicitly (bug#9591).
2015
2016 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2017
2018 * keymap.c (Fsingle_key_description): Use make_specified_string
2019 instead of build_string to build string from push_key_description.
2020 (Bug#5193)
2021
2022 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2025 This fixes a Y2038 bug on 64-bit hosts.
2026 * buffer.c (reset_buffer):
2027 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2028 (Fclear_buffer_auto_save_failure):
2029 Use 0, not -1, to represent an unset failure time, since time_t
2030 might not be signed.
2031
2032 Remove dependency on glibc malloc internals.
2033 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2034 Move back here from lisp.h, but with their new implementations.
2035 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2036 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2037 * charset.c (charset_table_init): New static var.
2038 (syms_of_charset): Use it instead of xmalloc. This removes a
2039 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2040 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2041 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2042 Move back to alloc.c.
2043 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2044 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2045
2046 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2047
2048 * nsterm.m (windowDidResize): Call x_set_window_size only when
2049 ns_in_resize is true. Otherwise set pixelwidth/height and
2050 call change_frame_size (Bug#9628).
2051
2052 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 Port --enable-checking=all to Fedora 14 x86-64.
2055 * charset.c (syms_of_charset): Also account for glibc malloc's
2056 internal overhead when calculating the initial malloc maximum.
2057
2058 Port --enable-checking=all to Fedora 14 x86.
2059 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2060 Move to lisp.h.
2061 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2062 (overrun_check_realloc, overrun_check_free):
2063 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2064 That way, xmalloc returns a properly-aligned pointer even if
2065 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2066 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2067 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2068 into account when calculating the initial malloc maximum.
2069 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2070 Move here from alloc.c, so that charset.c can use it too.
2071 Properly align; the old code wasn't right for common 32-bit hosts
2072 when configured with --enable-checking=all.
2073 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2074 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2075
2076 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2077
2078 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2079 use EDOM.
2080
2081 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2082
2083 * xdisp.c (compute_display_string_end): If there's no display
2084 string at CHARPOS, return -1.
2085
2086 * bidi.c (bidi_fetch_char): When compute_display_string_end
2087 returns a negative value, treat the character as a normal
2088 character not covered by a display string. (Bug#9624)
2089
2090 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2091
2092 * lread.c (Fread_from_string): Fix typo in docstring.
2093
2094 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2095
2096 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2097 newline, reseat the iterator instead of bidi-iterating there one
2098 character at a time. (Bug#9610)
2099 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2100 TO_CHARPOS if the bidi iterator is at base embedding level.
2101
2102 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2103
2104 * lread.c (readevalloop): Use correct code for NBSP.
2105 (read1): Likewise. (Bug#9608)
2106
2107 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2108
2109 * dbusbind.c (Fdbus_register_signal): When service is not
2110 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2111
2112 2011-09-25 Glenn Morris <rgm@gnu.org>
2113
2114 * buffer.c (truncate-lines): Doc fix.
2115
2116 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2117
2118 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2119 (Fset_window_next_buffers): Doc fix.
2120
2121 2011-09-24 Glenn Morris <rgm@gnu.org>
2122
2123 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2124
2125 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 Fix minor problems found by static checking.
2128 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2129 * indent.c (Fvertical_motion): Fix == vs = typo.
2130
2131 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2132
2133 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2134 Default value is now t. Doc fix.
2135
2136 * indent.c (Fvertical_motion): Compute and apply the overshoot
2137 logic when moving up, not only when moving down. Fix the
2138 confusing name and values of the it_overshoot_expected variable;
2139 logic changes accordingly. (Bug#9254) (Bug#9549)
2140
2141 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2142 CHARPOS is covered by a display string which includes newlines.
2143 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2144 is covered by a display string with embedded newlines.
2145
2146 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2147
2148 * dbusbind.c (Fdbus_register_signal): Add match rule to
2149 Vdbus_registered_objects_table. (Bug#9581)
2150 (Fdbus_register_method, Vdbus_registered_objects_table):
2151 Fix docstring.
2152
2153 2011-09-24 Jim Meyering <meyering@redhat.com>
2154
2155 do not ignore write error for any output size
2156 The previous change was incomplete.
2157 While it makes emacs --batch detect the vast majority of stdout
2158 write failures, errors were still ignored whenever the output size is
2159 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2160 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2161 && echo FAIL: ignored write error
2162 FAIL: ignored write error
2163 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2164 && echo FAIL: ignored write error
2165 FAIL: ignored write error
2166 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2167
2168 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2169
2170 * emacs.c (Fkill_emacs): In noninteractive mode exit
2171 non-successfully if a write error occurred on stdout. (Bug#9574)
2172
2173 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2174
2175 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2176 the xassert test.
2177
2178 * dispextern.h (struct it): Update the comment documenting what
2179 can it->OBJECT be.
2180
2181 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2182
2183 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2184 a display string, extend search for cursor position to end of row.
2185 (find_row_edges): If the row ends in a newline from a display
2186 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2187 Handle the case of a display string with multiple newlines.
2188 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2189 non-empty line. Fixes confusing cursor motion with arrow keys at
2190 the beginning of a line that starts with whitespace.
2191
2192 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2193
2194 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2195 (bug#9493).
2196
2197 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2198
2199 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2200 boolean (Bug#9154).
2201
2202 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2203
2204 * xdisp.c (display_line): Record maximum and minimum buffer
2205 positions even if no glyphs were produced (e.g., by a zero-width
2206 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2207 buffer positions that will be removed from the glyph row because
2208 they don't fit.
2209 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2210 column is beyond frame width: don't subtract 1 "pixel" when
2211 computing width of the stretch.
2212 (reseat_at_next_visible_line_start): Undo the change made on
2213 2011-09-17 that saved paragraph information and restored it after
2214 the call to `reseat'. (Bug#9545)
2215
2216 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2217
2218 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2219 and turn window cursor on if cleared (Bug#9415).
2220
2221 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2222
2223 * search.c (boyer_moore): Take unibyte characters from pattern
2224 literally. (Bug#9458)
2225
2226 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2229
2230 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 Fix minor problem found by static checking.
2233 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2234 initialized, to pacify gcc -Wuninitialized.
2235
2236 * fileio.c: Report proper errno when syscall falls.
2237 (Finsert_file_contents): Save and restore errno,
2238 so that report_file_error outputs the correct diagnostic.
2239 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2240
2241 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2242
2243 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2244
2245 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2246
2247 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2248 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2249
2250 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2251
2252 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2253 about the current paragraph and restore it after the call to reseat.
2254
2255 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2256 (bidi_find_paragraph_start): Search back for paragraph beginning
2257 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2258 (bidi_move_to_visually_next): Only trigger paragraph-related
2259 computations when the last character is a newline or at EOB, not
2260 just any NEUTRAL_B. (Bug#9470)
2261
2262 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2263 truncated lines if point is covered by a display string. (Bug#9524)
2264
2265 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2268 (cons_to_x_long): New function.
2269 (lisp_data_to_selection_data): Use it. Correct the test for
2270 short-versus-long data; it was negated. Break out of vector
2271 loop, for efficiency, when a long datum is discovered.
2272
2273 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2274
2275 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2276
2277 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2278
2279 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2280 GCC PR/17406) by declaring this function with external scope.
2281
2282 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2285 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2286
2287 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2288
2289 * editfns.c (Fformat): Correctly handle text properties on "%%".
2290
2291 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2292
2293 * xterm.c (x_draw_composite_glyph_string_foreground):
2294 * w32term.c (x_draw_composite_glyph_string_foreground):
2295 * term.c (encode_terminal_code):
2296 * composite.c (composition_update_it, get_composition_id):
2297 * xdisp.c (get_next_display_element)
2298 (fill_composite_glyph_string): Add comments about special meaning
2299 of TAB characters in a composition.
2300
2301 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2304 This occurs when processing a multibyte format.
2305 Problem reported by Wolfgang Jenker.
2306
2307 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2308
2309 * xdisp.c (try_cursor_movement): Only check for exact match if
2310 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2311
2312 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2313
2314 Remove unused external symbols.
2315 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2316 * xdisp.c (calc_pixel_width_or_height): Now static.
2317 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2318 * indent.c (check_display_width):
2319 * w32term.c: Fix comment to match code.
2320 * xterm.c, xterm.h (x_catching_errors): Remove.
2321
2322 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2323
2324 * xselect.c: Use signed conversions more consistently (Bug#9498).
2325 (selection_data_to_lisp_data): Assume incoming selection data are
2326 signed integers, not unsigned. This is to be consistent with
2327 outgoing selection data, which was modified to use signed integers
2328 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2329 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2330 expects long, not unsigned long.
2331
2332 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2333
2334 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2335 computation of loop end. Reported by Johan Bockgård
2336 <bojohan@gnu.org>.
2337
2338 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2339
2340 * frame.c (Fother_visible_frames_p): Function deleted.
2341
2342 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2343
2344 * indent.c (compute_motion): Process display vector front to back
2345 rather than the other way around. (Bug#2496)
2346
2347 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2348
2349 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2350
2351 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2352
2353 * minibuf.c (Fread_from_minibuffer): Doc fix.
2354
2355 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2356
2357 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2358 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2359
2360 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2361
2362 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2363 value for non-existent files.
2364
2365 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2366
2367 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2368 set its "size" to -1. This will set the modtime_size field of
2369 the corresponding buffer to -1, which is what
2370 verify-visited-file-modtime expects for files that do not exist.
2371 (Bug#9139)
2372
2373 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2376 here ...
2377 * lisp.h: ... from here. push_key_description is no longer
2378 defined in keyboard.c, so its declaration should not be in
2379 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2380 logically belongs with push_key_description.
2381
2382 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * buffer.h: Include <sys/types.h> instead of <time.h>.
2385 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2386 Problem reported by Herbert J. Skuhra.
2387
2388 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2389
2390 * xml.c (parse_region): Make the parsing work for
2391 non-comment-starting XML files again (bug#9144).
2392
2393 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2394
2395 * image.c (gif_load): Fix calculation of bottom and right corner.
2396 (Bug#9468)
2397
2398 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2399
2400 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2401 redisplay in small windows.
2402
2403 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2404
2405 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2406
2407 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2408
2409 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2410 Operate on live windows only.
2411
2412 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2413
2414 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2415
2416 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2417
2418 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2419 only under bidi iteration.
2420
2421 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2422
2423 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2424
2425 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2428 Without this fix, the command to link temacs failed due to an
2429 undefined symbol __builtin_isnan. This is because
2430 /usr/include/iso/math_c99.h #defines isnan(x) to
2431 __builtin_isnan(x), but the bundled gcc, which identifies itself
2432 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2433 a __builtin_isnan.
2434 * floatfns.c (isnan): #undef, and then #define to a clone of
2435 what's in data.c.
2436 (Fisnan): Always define, since it's always available now.
2437 (syms_of_floatfns): Always define isnan at the Lisp level.
2438
2439 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2440
2441 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2442
2443 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2446 The previous code assumed that file offsets (off_t values) fit in
2447 EMACS_INT variables, which is not true on typical 32-bit hosts.
2448 The code messed up by falsely reporting buffer overflow in cases
2449 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2450 when "big" contains more than 2**29 bytes, even though this
2451 inserts just one byte and does not overflow the buffer.
2452 (Finsert_file_contents): Store file offsets as off_t
2453 values, not as EMACS_INT values. Check for overflow when
2454 converting between EMACS_INT and off_t. When checking for
2455 buffer overflow or for overlap, take the offsets into account.
2456 Don't use EMACS_INT for small values where int suffices.
2457 When checking for overlap, fix a typo: ZV was used where
2458 ZV_BYTE was intended.
2459 (Fwrite_region): Don't assume off_t fits into 'long'.
2460 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2461
2462 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2463
2464 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2465
2466 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 sprintf-related integer and memory overflow issues (Bug#9412).
2469
2470 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2471 (esprintf, exprintf, evxprintf): New functions.
2472 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2473 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2474 (modify_event_symbol): Do not assume that the length of
2475 name_alist_or_stem is safe to alloca and fits in int.
2476 (Fexecute_extended_command): Likewise for function name and binding.
2477 (Frecursion_depth): Wrap around reliably on integer overflow.
2478 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2479 since some callers pass EMACS_INT values.
2480 (Fsingle_key_description): Don't crash if symbol name contains more
2481 than MAX_ALLOCA bytes.
2482 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2483 (get_minibuffer): Arg is now EMACS_INT, not int.
2484 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2485 (esprintf, exprintf, evxprintf): New decls.
2486 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2487
2488 * dbusbind.c (signature_cat): New function.
2489 (xd_signature, Fdbus_register_signal):
2490 Do not overrun buffer; instead, report string overflow.
2491
2492 * dispnew.c (add_window_display_history): Don't overrun buffer.
2493 Truncate instead; this is OK since it's just a log.
2494
2495 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2496 even if the time zone offset is outlandishly large.
2497 Don't mishandle offset == INT_MIN.
2498
2499 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2500 when creating daemon; the previous buffer-overflow check was incorrect.
2501
2502 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2503 which has the guts of the old verror function.
2504
2505 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2506 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2507
2508 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2509 (font_unparse_xlfd): Don't blindly alloca long strings.
2510 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2511 fits in int, when using sprintf. Use single snprintf to count
2512 length of string rather than counting it via multiple sprintfs;
2513 that's simpler and more reliable.
2514 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2515 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2516 sprintf, in case result does not fit in int.
2517
2518 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2519 (fontset_from_font): Print it.
2520
2521 * frame.c (tty_frame_count): Now printmax_t, not int.
2522 (make_terminal_frame, set_term_frame_name): Print it.
2523 (x_report_frame_params): In X, window IDs are unsigned long,
2524 not signed long, so print them as unsigned.
2525 (validate_x_resource_name): Check for implausibly long names,
2526 and don't assume name length fits in 'int'.
2527 (x_get_resource_string): Don't blindly alloca invocation name;
2528 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2529 not fit in int.
2530
2531 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2532 (xg_check_special_colors, xg_set_geometry):
2533 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2534
2535 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2536 Use esprintf, not sprintf, in case result does not fit in int.
2537
2538 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2539 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2540 it as a large positive number.
2541 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2542 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2543
2544 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2545 in case result does not fit in int.
2546
2547 * print.c (float_to_string): Detect width overflow more reliably.
2548 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2549 buffer overrun. Don't assume list length fits in 'int'. Treat
2550 print length of 0 as 0, not as infinity; to be consistent with other
2551 uses of print length in this function. Don't overflow print length
2552 index. Don't assume hash table size fits in 'long', or that
2553 vectorlike size fits in 'unsigned long'.
2554
2555 * process.c (make_process): Use printmax_t, not int, to format
2556 process-name gensyms.
2557
2558 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2559
2560 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2561 to avoid potential buffer overrun.
2562
2563 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2564 if X resource line is longer than 512 bytes.
2565
2566 * xfns.c (x_window): Make sprintf buffer a bit bigger
2567 to avoid potential buffer overrun.
2568
2569 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2570
2571 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2572
2573 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 Integer overflow fixes for scrolling, etc.
2576 Without these, Emacs silently mishandles large integers sometimes.
2577 For example, "C-u 4294967297 M-x recenter" was treated as if
2578 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2579
2580 * xdisp.c (try_window_id): Check Emacs fixnum range before
2581 converting to 'int'.
2582
2583 * window.c (window_scroll_line_based, Frecenter):
2584 Check that an Emacs fixnum is in range before assigning it to 'int'.
2585 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2586 values converted from Emacs fixnums.
2587 (Frecenter): Don't wrap around a line count if it is out of 'int'
2588 range; instead, treat it as an extreme value.
2589 (Fset_window_configuration, compare_window_configurations):
2590 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2591
2592 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2593 that can exceed INT_MAX. Check that EMACS_INT value is in range
2594 before assigning it to the (possibly-narrower) index.
2595 (match_limit): Don't assume that a fixnum can fit in 'int'.
2596
2597 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2598 exceed INT_MAX.
2599
2600 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2601 (Fvertical_motion): Don't wrap around LINES values that don't fit
2602 in 'int'. Instead, treat them as extreme values. This is good
2603 enough for windows, which can't have more than INT_MAX lines anyway.
2604
2605 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2606
2607 * Require libxml/parser.h to avoid compilation warning.
2608
2609 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2610
2611 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2612 since this reportedly can destroy thread storage.
2613
2614 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2615
2616 * syntax.c (find_defun_start): Update all cache variables if
2617 exiting early (Bug#9401).
2618
2619 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2620
2621 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2622
2623 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2624 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2625 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2626
2627 * term.c (tty_append_glyph): New function.
2628 (produce_stretch_glyph): Static function and its prototype deleted.
2629
2630 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2631 Add prototypes.
2632
2633 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2634
2635 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2636 when checking :margin (Bug#9390).
2637 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2638 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2639 so that the name doesn't mislead. All uses changed.
2640
2641 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2642
2643 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2644 set_tty_hooks.
2645
2646 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2647
2648 * xdisp.c (move_it_to): Don't bail out early when reaching
2649 position beyond to_charpos, if we are scanning backwards.
2650 (move_it_vertically_backward): When DY == 0, make sure we get to
2651 the first character in the line after the newline.
2652
2653 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2656 (ccl_driver): Do not generate an out-of-range pointer.
2657 (Fccl_execute_on_string): Remove unnecessary check for
2658 integer overflow, noted by Stefan Monnier in
2659 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2660 Remove a FIXME that didn't need fixing.
2661 Simplify the newly-introduced buffer reallocation code.
2662
2663 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2664
2665 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2666
2667 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 Integer and memory overflow issues (Bug#9196).
2670
2671 * doc.c (get_doc_string): Rework so that
2672 get_doc_string_buffer_size is the actual buffer size, rather than
2673 being 1 less than the actual buffer size; this makes xpalloc more
2674 convenient.
2675
2676 * image.c (x_allocate_bitmap_record, cache_image):
2677 * xselect.c (Fx_register_dnd_atom):
2678 Simplify previous changes by using xpalloc.
2679
2680 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2681 since either will do and ptrdiff_t is convenient with xpalloc.
2682
2683 * charset.c (charset_table_size)
2684 (struct charset_sort_data.priority): Now ptrdiff_t.
2685 (charset_compare): Don't overflow if priorities differ greatly.
2686 (Fsort_charsets): Don't assume list length fits in int.
2687 Check for size-calculation overflow when allocating sort data.
2688 (syms_of_charset): Allocate an initial charset table that is
2689 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2690
2691 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2692
2693 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2694 The actual value is always <= INT_MAX, and leaving it unsigned made
2695 overflow checking harder.
2696
2697 * dispextern.h (struct glyph_matrix.rows_allocated)
2698 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2699 with xpalloc. The values are still always <= INT_MAX.
2700
2701 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2702
2703 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2704 (SAFE_NALLOCA): New macro.
2705
2706 * region-cache.c (struct boundary.pos, find_cache_boundary)
2707 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2708 (set_cache_region, invalidate_region_cache)
2709 (revalidate_region_cache, know_region_cache, region_cache_forward)
2710 (region_cache_backward, pp_cache):
2711 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2712 so that ptrdiff_t * can be passed to xpalloc.
2713 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2714 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2715 (pp_cache): Don't assume cache_len fits in int.
2716 * region-cache.h: Adjust extern decls to match.
2717
2718 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2719 EMACS_INT, since either will do, for xpalloc.
2720
2721 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2722 (xnmalloc, xnrealloc, xpalloc): New functions.
2723
2724 * bidi.c (bidi_shelve_header_size): New constant.
2725 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2726 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2727
2728 * bidi.c (bidi_cache_shrink):
2729 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2730 (overlay_strings):
2731 Don't update size of array until after memory allocation succeeds,
2732 because xmalloc/xrealloc may not return.
2733 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2734 now that we have proper integer overflow checking.
2735 (record_overlay_string, overlay_strings): Catch overflows when
2736 calculating size of overlay_str_buf.
2737
2738 * callproc.c (Fcall_process): Check for size overflow when
2739 calculating size of args2.
2740 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2741 Normally we prefer signed values, but sticking with ptrdiff_t would
2742 require adding more-complicated checks.
2743
2744 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2745 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2746 Redo buffer-overflow calculations to avoid integer overflow.
2747 Add a FIXME comment where memory seems to be over-allocated.
2748
2749 * character.c (Fstring): Check for size-calculation overflow.
2750
2751 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2752 unnecessary integer overflow. Check for size overflow.
2753 (encode_coding_object): Don't update size until xmalloc succeeds.
2754
2755 * composite.c (get_composition_id): Check for overflow in glyph
2756 length calculations.
2757
2758 Integer and memory overflow fixes for display code.
2759 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2760 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2761 (scrolling_window): Check for overflow in size calculations.
2762 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2763 Don't assume glyph table len fits in int.
2764 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2765 (row_table_size): Now ptrdiff_t, not int.
2766 (scrolling_window): Avoid overflow in size calculations.
2767 Don't update size until allocation succeeds.
2768 * fns.c (concat): Check for overflow in size calculations.
2769 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2770 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2771 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2772
2773 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2774 (get_doc_string): Check for size calculation overflow.
2775 Don't update size until allocation succeeds.
2776 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2777 EMACS_INT, where ptrdiff_t will do.
2778 (Fsubstitute_command_keys): Check for string overflow.
2779
2780 * editfns.c (set_time_zone_rule): Don't assume environment length
2781 fits in int.
2782 (message_length): Now ptrdiff_t, not int.
2783 (Fmessage_box): Don't update size until allocation succeeds.
2784 Don't assume message length fits in int.
2785 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2786
2787 * emacs.c (main): Do not reallocate argv, since there is a null at
2788 the end that can be overwritten, and this way there's no need to
2789 worry about size-calculation overflow.
2790 (sort_args): Check for size-calculation overflow.
2791
2792 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2793 alloc succeeds.
2794 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2795
2796 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2797 (x_set_scroll_bar_width, x_figure_window_size):
2798 Check for integer overflow.
2799 (x_set_alpha): Do not assume XINT fits in int.
2800
2801 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2802 This is for the members text_lines, text_cols, total_lines, total_cols,
2803 where the system imposes an 'int' limit.
2804
2805 * fringe.c (Fdefine_fringe_bitmap):
2806 Don't update size until alloc works.
2807
2808 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2809 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2810
2811 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2812 Check for size-calculation overflow.
2813 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2814 do, as we prefer signed integers.
2815 (id_to_widget.max_size, id_to_widget.used)
2816 (xg_store_widget_in_map, xg_remove_widget_from_map)
2817 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2818 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2819 Use and return ptrdiff_t, not int.
2820 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2821 * gtkutil.h: Change prototypes to match the above.
2822
2823 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2824 are duplicate now that they've been promoted to lisp.h.
2825 (x_allocate_bitmap_record, x_alloc_image_color)
2826 (make_image_cache, cache_image, xpm_load):
2827 Don't update size until alloc is done.
2828 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2829 (x_detect_edges):
2830 Check for size calculation overflow.
2831 (ct_colors_allocated_max): New constant.
2832 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2833 overflow.
2834
2835 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2836 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2837 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2838 Use ptrdiff_t, not int, to count maps.
2839 (read_char_minibuf_menu_prompt): Check for overflow in size
2840 calculations. Don't update size until allocation succeeds.
2841 Redo calculations to avoid overflow.
2842 * keyboard.h: Change prototypes to match the above.
2843
2844 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2845 to count maps.
2846 (current_minor_maps): Check for size calculation overflow.
2847 * keymap.h: Change prototypes to match the above.
2848
2849 * lread.c (read1, init_obarray): Don't update size until alloc done.
2850
2851 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2852 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2853
2854 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2855 Now ptrdiff_t, not int.
2856 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2857 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2858
2859 * process.c (Fnetwork_interface_list): Check for overflow
2860 in size calculation.
2861
2862 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2863
2864 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2865 overflow. Don't bother calling xmalloc when xrealloc will do.
2866
2867 * search.c (Freplace_match): Check for size calculation overflow.
2868 (Fset_match_data): Don't assume list lengths fit in 'int'.
2869
2870 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2871 for command line length. Do not attempt to address one before the
2872 beginning of an array, as that's not portable.
2873
2874 * term.c (max_frame_lines): Remove; unused.
2875 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2876 not int.
2877 (encode_terminal_code, calculate_costs): Check for size
2878 calculation overflow.
2879 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2880 table lengths and related sizes. Don't update size until alloc
2881 done. Redo calculations to avoid overflow.
2882 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2883
2884 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2885 subtracting pointers.
2886 (gobble_line): Check for overflow more carefully. Don't update size
2887 until alloc done.
2888
2889 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2890 Don't update size until alloc done.
2891 Redo size calculations to avoid overflow.
2892 Check for size calculation overflow.
2893 (main) [DEBUG]: Fix typo in invoking tparam1.
2894
2895 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2896 Use ptrdiff_t, not int, for sizes.
2897 (store_mode_line_noprop_char): Don't update size until alloc done.
2898
2899 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2900 Use ptrdiff_t, not int, for sizes.
2901 (Finternal_make_lisp_face, cache_face):
2902 Check for size calculation overflow.
2903 (cache_face): Treat size calculation overflows as if they were
2904 memory exhaustion (the usual treatment), rather than aborting.
2905
2906 * xfns.c (x_encode_text, x_set_name_internal)
2907 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2908 sizes, since they can exceed INT_MAX in size. Check for size
2909 calculation overflow.
2910
2911 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2912 (xg_select): Check for size calculation overflow.
2913 Don't update size until alloc done.
2914
2915 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2916 as sprintf is limited to int lengths.
2917
2918 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2919 (X_LONG_MIN): New macros.
2920 Use them to make the following changes clearer.
2921 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2922 This change doesn't affect the value now, but it may help remind
2923 future maintainers not to raise the value too much later.
2924 (SELECTION_QUANTUM): Remove, replacing with ...
2925 (selection_quantum): ... new function, which avoids overflow.
2926 All uses changed.
2927 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2928 assumption that selection length fits in 'int'.
2929 (x_reply_selection_request, x_handle_selection_request)
2930 (x_get_window_property, receive_incremental_selection)
2931 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2932 (lisp_data_to_selection_data, clean_local_selection_data):
2933 Use ptrdiff_t, not int, to record length of selection.
2934 (x_reply_selection_request, x_get_window_property)
2935 (receive_incremental_selection, x_property_data_to_lisp):
2936 Redo calculations to avoid overflow.
2937 (x_reply_selection_request): When sending hint, ceiling it at
2938 X_LONG_MAX rather than relying on wraparound overflow to send
2939 something.
2940 (x_get_window_property, receive_incremental_selection)
2941 (lisp_data_to_selection_data, x_property_data_to_lisp):
2942 Check for size-calculation overflow.
2943 (x_get_window_property, receive_incremental_selection)
2944 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2945 Don't store size until memory allocation succeeds.
2946 (x_get_window_property): Plug memory leak on memory exhaustion.
2947 Don't double-block input; malloc is safe here. Don't assume 2**34
2948 - 4 fits in unsigned long. Add an xassert to check
2949 XGetWindowProperty overflow. Be more careful about overflow
2950 calculations, and distinguish size from memory overflow better.
2951 (receive_incremental_selection): When tracing, don't assume
2952 unsigned int is less than INT_MAX.
2953 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2954 harmful) conversions of unsigned short to int.
2955 (lisp_data_to_selection_data): Don't assume that integers
2956 in the range -65535 through -1 fit in an X unsigned short.
2957 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2958 result parameters unless successful. Rely on cons_to_unsigned
2959 to report problems with elements; the old code wasn't right anyway.
2960 (x_check_property_data): Check for int overflow; we cannot use
2961 a wider type due to X limits.
2962 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2963
2964 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2965
2966 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2967 (x_term_init): Check for size calculation overflow.
2968 (x_color_cells): Don't store size until memory allocation succeeds.
2969 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2970 Don't assume alloca size is less than MAX_ALLOCA.
2971 (x_term_init): Don't assume length fits in int (sprintf is limited
2972 to int size).
2973
2974 Use ptrdiff_t for composition IDs.
2975 * character.c (lisp_string_width):
2976 * composite.c (composition_table_size, n_compositions)
2977 (get_composition_id, composition_gstring_from_id):
2978 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2979 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2980 * window.c (Frecenter):
2981 Use ptrdiff_t, not int, for composition IDs.
2982 * composite.c (get_composition_id): Check for integer overflow.
2983 * composite.h: Adjust prototypes to match the above changes.
2984
2985 Use ptrdiff_t for hash table indexes.
2986 * category.c (hash_get_category_set):
2987 * ccl.c (ccl_driver):
2988 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2989 * coding.c (coding_system_charset_list, detect_coding_system):
2990 * coding.h (struct coding_system.id):
2991 * composite.c (get_composition_id, gstring_lookup_cache):
2992 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2993 * image.c (xpm_get_color_table_h):
2994 * lisp.h (hash_lookup, hash_put):
2995 * minibuf.c (Ftest_completion):
2996 Use ptrdiff_t for hash table indexes, not int (which is too
2997 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2998 32-bit --with-wide-int hosts).
2999
3000 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3001 Add a FIXME comment about memory leaks.
3002 (syms_of_charset): Don't assume xmalloc returns.
3003
3004 Don't assume that stated character widths fit in int.
3005 * character.c (Fchar_width, c_string_width, lisp_string_width):
3006 * character.h (CHAR_WIDTH):
3007 * indent.c (MULTIBYTE_BYTES_WIDTH):
3008 Use sanitize_char_width to avoid undefined and/or bad behavior
3009 with outlandish widths.
3010 * character.h (sanitize_tab_width): Rename from sanitize_width,
3011 now that we have two such functions. All uses changed.
3012 (sanitize_char_width): New inline function.
3013
3014 Don't assume that tab-width fits in int.
3015 * character.h (sanitize_width): New inline function.
3016 (SANE_TAB_WIDTH): New macro.
3017 (ASCII_CHAR_WIDTH): Use it.
3018 * indent.c (sane_tab_width): Remove. All uses replaced by
3019 SANE_TAB_WIDTH (current_buffer).
3020 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3021
3022 * fileio.c: Integer overflow issues with file modes.
3023 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3024
3025 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3026 Remove unreachable code.
3027 (read_hex, load_charset_map_from_file): Check for integer overflow.
3028
3029 * xterm.c: Don't go over XClientMessageEvent limit.
3030 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3031 (x_send_scroll_bar_event): Likewise. Check that the size does not
3032 exceed limits imposed by XClientMessageEvent, as well as the usual
3033 ptrdiff_t and size_t limits.
3034
3035 * keyboard.c: Overflow, signedness and related fixes.
3036 (make_lispy_movement): Use same integer type in forward decl
3037 that is used in the definition.
3038 (read_key_sequence, keyremap_step):
3039 Change bufsize argument back to int, undoing my 2011-03-30 change.
3040 We prefer signed types, and int is wide enough here.
3041 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3042 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3043 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3044 length, not size_t. Use ptrdiff_t for index, not int.
3045 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3046 possibility of integer overflow.
3047
3048 Overflow, signedness and related fixes for images.
3049
3050 * dispextern.h (struct it.stack[0].u.image.image_id)
3051 (struct_it.image_id, struct image.id, struct image_cache.size)
3052 (struct image_cache.used, struct image_cache.ref_count):
3053 * gtkutil.c (update_frame_tool_bar):
3054 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3055 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3056 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3057 * nsmenu.m (update_frame_tool_bar):
3058 * xdisp.c (calc_pixel_width_or_height):
3059 * xfns.c (image_cache_refcount):
3060 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3061 on typical 64-bit hosts.
3062
3063 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3064 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3065 Omit unnecessary casts to int.
3066 (parse_image_spec): Check that integers fall into 'int' range
3067 when the callers expect that.
3068 (image_ascent): Redo ascent calculation to avoid int overflow.
3069 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3070 (lookup_image): Remove unnecessary tests.
3071 (xbm_image_p): Locals are now of int, not EMACS_INT,
3072 since parse_image_check makes sure they fit into int.
3073 (png_load, gif_load, svg_load_image):
3074 Prefer int to unsigned where either will do.
3075 (tiff_handler): New function, combining the cores of the
3076 old tiff_error_handler and tiff_warning_handler.
3077 This function is rewritten to use vsnprintf and thereby avoid
3078 stack buffer overflows. It uses only the features of vsnprintf
3079 that are common to both POSIX and native Microsoft.
3080 (tiff_error_handler, tiff_warning_handler): Use it.
3081 (tiff_load, gif_load, imagemagick_load_image):
3082 Don't assume :index value fits in 'int'.
3083 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3084 (imagemagick_load_image): Check that crop parameters fit into
3085 the integer types that MagickCropImage accepts. Don't assume
3086 Vimagemagick_render_type has a nonnegative value. Don't assume
3087 size_t fits in 'long'.
3088 (gs_load): Use printmax_t to print the widest integers possible.
3089 Check for integer overflow when computing image height and width.
3090
3091 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3092
3093 * xdisp.c (redisplay_window): Don't force window start if point
3094 will be invisible in the resulting window. (Bug#9324)
3095
3096 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3097
3098 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3099 the display spec is of the form `(space ...)'.
3100 (handle_display_spec): Return the value returned by
3101 handle_single_display_spec, not just 1 or zero.
3102 (handle_single_display_spec): If the display spec is of the form
3103 `(space ...)', and specifies display in the text area, return 2
3104 rather than 1.
3105 (try_cursor_movement): Check for the need to scroll more
3106 accurately, and prefer exact match for point under bidi.
3107 Don't advance `row' beyond the last row of the window.
3108
3109 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3110 into disp_prop; all users changed.
3111
3112 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3113 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3114 for the text covered by the display property.
3115
3116 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3117
3118 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3119 Change return value to nil.
3120 (Frecord_buffer): Delete unused function.
3121
3122 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3123
3124 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3125 buffers, return left-to-right.
3126 (set_cursor_from_row): Consider candidate row a win if its glyph
3127 represents a newline and point is on that newline. Fixes cursor
3128 positioning on the newline at EOL of R2L text within L2R
3129 paragraph, and vice versa.
3130 (try_cursor_movement): Check continued rows, in addition to
3131 continuation rows. Fixes unwarranted scroll when point enters a
3132 continued line of R2L text within an L2R paragraph, or vice versa.
3133 (cursor_row_p): Consider the case of point being equal to
3134 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3135 from the end of a short line to the beginning of a continued line
3136 of R2L text within L2R paragraph.
3137 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3138 composed characters.
3139
3140 * bidi.c (bidi_check_type): Use xassert.
3141 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3142 members.
3143
3144 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3145
3146 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3147 a character.
3148
3149 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3150
3151 * nsfont.m (ns_otf_to_script): Fix typo.
3152
3153 2011-08-22 Kenichi Handa <handa@m17n.org>
3154
3155 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3156 extra slot even if the purpose is char-code-property-table.
3157
3158 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3159
3160 * xdisp.c (redisplay_window): When computing centering_position,
3161 account for the height of the header line. (Bug#8874)
3162
3163 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3164 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3165 candidate is selected by the mouse, and that candidate has a
3166 composed character under the mouse.
3167
3168 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3169 coordinates reported by pos-visible-in-window-p for a composed
3170 character in column zero.
3171
3172 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3173
3174 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3175
3176 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3177
3178 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3179 consider it a hit if to_charpos is anywhere in the range of the
3180 composed buffer positions.
3181
3182 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3183
3184 * image.c (gif_load): Don't assume that each subimage has the same
3185 dimensions as the base image. Handle disposal method that is
3186 "undefined" by the gif spec (Bug#9335).
3187
3188 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3189
3190 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3191 (Fcondition_case): Document `debug' symbol in error handler.
3192
3193 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3194
3195 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3196 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3197 from an Org mode buffer to a Speedbar frame.
3198
3199 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3200 a composition, take its buffer position from IT->cmp_it.charpos.
3201 Fixes cursor positioning at the beginning of a line that begins
3202 with a composed character.
3203
3204 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3205
3206 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3207 character bidirectional type, use STRONG_L instead. Fixes crashes
3208 in a buffer produced by `describe-categories'.
3209
3210 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3211 members before the level stack, so they would be saved and
3212 restored when copying iterator state. Fixes incorrect reordering
3213 around TABs covered by display properties.
3214
3215 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3216
3217 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3218
3219 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * eval.c (internal_condition_case, internal_condition_case_1)
3222 (internal_condition_case_2, internal_condition_case_n):
3223 Remove unnecessary aborts (Bug#9081).
3224
3225 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3226
3227 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3228 has no `load' handler, try opening the file locally. (Bug#9311)
3229
3230 2011-08-16 Ken Brown <kbrown@cornell.edu>
3231
3232 * gmalloc.c: Expand comment.
3233
3234 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3235
3236 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3237 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3238
3239 2011-08-16 Ken Brown <kbrown@cornell.edu>
3240
3241 Fix memory allocation problems in Cygwin build (Bug#9273).
3242
3243 * unexcw.c ( __malloc_initialized): Declare external variable.
3244 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3245
3246 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3247 New variables.
3248 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3249 dumped emacs.
3250 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3251 in the static heap.
3252 [CYGWIN] (special_realloc): New function.
3253 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3254 requests to realloc storage in the static heap.
3255
3256 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 * bidi.c (bidi_initialize): Remove unused local.
3259
3260 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3261
3262 * bidimirror.h:
3263 * biditype.h: Remove file.
3264 * makefile.w32-in ($(BLD)/bidi.$(O)):
3265 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3266
3267 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3268
3269 * chartab.c: Improve commentary for the uniprop_table API.
3270
3271 * bidi.c (bidi_paragraph_init): Support zero value of
3272 bidi_ignore_explicit_marks_for_paragraph_level.
3273 (bidi_initialize): Use uniprop_table instead of including
3274 biditype.h and bidimirror.h.
3275
3276 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3277 coordinates of the iterator when restoring from ppos_it.
3278 (Bug#9296)
3279
3280 2011-08-14 Kenichi Handa <handa@m17n.org>
3281
3282 * process.c (create_process): Call setup_process_coding_systems
3283 after the pid of the process is set to -1 (Bug#8162).
3284
3285 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3286
3287 * xdisp.c (move_it_in_display_line_to): Don't invoke
3288 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3289 ppos_it. Fixes vertical cursor motion when line beginning is
3290 covered by an image. (Bug#9296)
3291
3292 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3293
3294 * nsterm.h (ns_run_ascript): Declare.
3295 (NSAPP_DATA2_RUNASSCRIPT): Define.
3296
3297 * nsfns.m (as_script, as_result, as_status): New static variables.
3298 (ns_run_ascript): New function.
3299 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3300 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3301 the event loop. Get status from as_status (Bug#7276).
3302
3303 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3304 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3305 the event loop (Bug#7276).
3306
3307 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3308
3309 * gnutls.c (QCgnutls_bootprop_priority)
3310 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3311 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3312 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3313 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3314 (QCgnutls_bootprop_verify_hostname_error)
3315 (QCgnutls_bootprop_callbacks_verify): Rename from
3316 Qgnutls_bootprop_..., all uses changed.
3317
3318 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3319 uses changed.
3320
3321 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3322
3323 * xfaces.c (Qframe_set_background_mode): Now static.
3324 * dispextern.h (Qframe_set_background_mode): Remove decl.
3325
3326 * process.c (Fnetwork_interface_info): Declare local only if needed.
3327
3328 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3329
3330 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3331 (Fnetwork_interface_list): Allocate in increments of bytes instead
3332 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3333 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3334 sockaddr.
3335 (struct ifflag_def): notrailers is smart on OSX.
3336 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3337 Get hardware address with getifaddrs if available.
3338
3339 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3340
3341 * xdisp.c (iterate_out_of_display_property): xassert that
3342 IT->position is set to within IT->object's boundaries. Break from
3343 the loop as soon as EOB is reached; avoids infloops in redisplay
3344 when IT->position is set up wrongly due to some bug.
3345 Set IT->current to match the bidi iterator unconditionally.
3346 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3347 entry. Force push_it to save on the stack the current
3348 buffer/string position, to be restored by pop_it. Fix flags in
3349 the iterator structure wrt the object coming from a display
3350 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3351 properties. (Bug#9284)
3352
3353 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3354
3355 * fontset.c (fontset_get_font_group): Add proper type checks.
3356 (Bug#9172)
3357
3358 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3359
3360 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3361 and LC_VERSION_MIN_MACOSX.
3362 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3363 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3364
3365 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3366
3367 * xdisp.c (forward_to_next_line_start): Allow to use the
3368 no-display-properties-and-no-overlays under bidi display.
3369 Set disp_pos in the bidi iterator to avoid searches for display
3370 properties and overlays.
3371
3372 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3373
3374 * editfns.c (Fset_time_zone_rule): Document relationship with the
3375 setenv function.
3376
3377 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3378 the font entity extracted from the cache (Bug#8109).
3379
3380 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3381
3382 * composite.c (autocmp_chars): Don't reset point. That is done by
3383 restore_point_unwind (Bug#5984).
3384
3385 2011-08-07 Juri Linkov <juri@jurta.org>
3386
3387 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3388 to show the arg `TIME' instead of `TIMEVAL'.
3389
3390 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3391
3392 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3393 display property strides EOL and includes a newline, as in
3394 longlines-mode. (Bug#9254)
3395 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3396 word-wrap under bidirectional display. (Bug#9224)
3397
3398 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3399 is non-zero, even if the data buffer is NULL. Fixes a crash in
3400 vertical-motion with longlines-mode. (Bug#9254)
3401
3402 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3403
3404 * bidi.c <bidi_cache_total_alloc>: Now static.
3405 (bidi_initialize): Initialize bidi_cache_total_alloc.
3406
3407 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3408 cache. (Bug#9221)
3409
3410 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3411 amount allocated this far in `bidi_cache_total_alloc'.
3412 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3413 non-zero, only free the data buffer without restoring the cache
3414 contents. All callers changed.
3415
3416 * dispextern.h (bidi_unshelve_cache): Update prototype.
3417
3418 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3419 (move_it_in_display_line, move_it_to)
3420 (move_it_vertically_backward, move_it_by_lines): Replace the call
3421 to xfree to an equivalent call to bidi_unshelve_cache.
3422 (move_it_in_display_line_to): Fix logic of returning
3423 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3424
3425 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3426
3427 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3428 came from a string character with a `cursor' property. (Bug#9229)
3429
3430 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3431
3432 * Makefile.in (LIB_PTHREAD): New variable.
3433 (LIBES): Add LIB_PTHREAD (Bug#9216).
3434
3435 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3436 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3437
3438 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3439
3440 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3441
3442 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3443
3444 * xterm.c (x_find_topmost_parent): New function.
3445 (x_set_frame_alpha): Find topmost parent window with
3446 x_find_topmost_parent and set the property there also (bug#9181).
3447 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3448
3449 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3450
3451 * callproc.c (Fcall_process): Avoid vfork clobbering
3452 the local vars buffer, coding_systems, current_dir.
3453
3454 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3455
3456 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3457
3458 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3461 so that it is not optimized away.
3462
3463 * xdisp.c (compute_display_string_pos): Remove unused local.
3464
3465 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3466
3467 Fix slow cursor motion and scrolling in large buffers with
3468 selective display, like Org Mode buffers. (Bug#9218)
3469
3470 * dispextern.h (struct bidi_it): New member disp_prop_p.
3471
3472 * xdisp.c: Remove one-slot cache of display string positions.
3473 (compute_display_string_pos): Accept an additional argument
3474 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3475 for a display string or property. If found, set DISP_PROP_P
3476 non-zero.
3477
3478 * bidi.c (bidi_fetch_char): Accept an additional argument
3479 DISP_PROP_P, and pass it to compute_display_string_pos.
3480 Only handle text covered by a display string if DISP_PROP_P is returned
3481 non-zero. All callers of bidi_fetch_char changed.
3482
3483 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3484
3485 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3486
3487 2010-12-03 Don March <don@ohspite.net>
3488
3489 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3490 last character M-[char] is translated to ESC [char] (bug#7541).
3491
3492 2011-08-02 Kenichi Handa <handa@m17n.org>
3493
3494 * lisp.h (uniprop_table): Extern it.
3495
3496 * chartab.c (uniprop_table): Make it non-static.
3497
3498 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3499
3500 * xdisp.c (forward_to_next_line_start): Accept additional argument
3501 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3502 on the newline.
3503 (reseat_at_next_visible_line_start): Use the bidi iterator state
3504 returned by forward_to_next_line_start to restore the state of
3505 it->bidi_it after backing up to previous newline. (Bug#9212)
3506
3507 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3508
3509 * regex.c (re_comp): Protoize.
3510 (re_exec): Fix return type.
3511 (regexec): Fix type of `ret'. (Bug#9203)
3512
3513 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3516 This is needed if max-image-size is a floating-point number.
3517
3518 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3519
3520 * print.c (print_object): Print empty symbol as ##.
3521
3522 * lread.c (read1): Read ## as empty symbol.
3523
3524 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3525
3526 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3527 setting frame foreground color (Bug#9175).
3528 (x_set_background_color): Likewise.
3529
3530 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3531 contents (Bug#9176).
3532 (EmacsTooltip -init): Remove bezels and add shadows to
3533 tooltip windows.
3534
3535 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3536 or scroll bar (Bug#8470).
3537
3538 * nsfont.m (nsfont_open): Remove assignment to voffset and
3539 unnecessary vars hshink, expand, hd, full_height, min_height.
3540 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3541
3542 * nsterm.h (nsfont_info): Remove voffset field.
3543
3544 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3545
3546 Implement strike-through and overline on NextStep (Bug#8863).
3547
3548 * nsfont.m (nsfont_open): Use underline position provided by font,
3549 instead of hard-coded value of 2.
3550 (nsfont_draw): Call ns_draw_text_decoration instead.
3551
3552 * nsterm.h: Add declaration for ns_draw_text_decoration.
3553
3554 * nsterm.m (ns_draw_text_decoration): New function for drawing
3555 underline, overline, and strike-through.
3556 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3557 ns_draw_text_decoration. Change treatment of cursor drawing to
3558 accommodate underlining, etc.
3559
3560 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3561
3562 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3563 default.
3564
3565 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3568 Without this fix, if a signal arrives just after memory fills up,
3569 'malloc' might be invoked reentrantly.
3570
3571 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3572 In other words, assume that every image size is allowed, on non-X
3573 hosts. This assumption is probably wrong, but it lets Emacs compile.
3574
3575 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3576
3577 * regex.c (re_iswctype): Convert return values to boolean.
3578
3579 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3580
3581 * xdisp.c (compute_display_string_pos): Don't use cached display
3582 string position if the buffer had its restriction changed.
3583 (Bug#9184)
3584
3585 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3588
3589 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 Integer signedness and overflow and related fixes. (Bug#9079)
3592
3593 * bidi.c: Integer size and overflow fixes.
3594 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3595 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3596 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3597 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3598 (bidi_find_other_level_edge):
3599 Use ptrdiff_t instead of EMACS_INT where either will do.
3600 This works better on 32-bit hosts configured --with-wide-int.
3601 (bidi_cache_ensure_space): Check for size-calculation overflow.
3602 Use % rather than repeated addition, for better worst-case speed.
3603 Don't set bidi_cache_size until after xrealloc returns, because it
3604 might not return.
3605 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3606 (bidi_cache_ensure_space): Also check that the bidi cache size
3607 does not exceed that of the largest Lisp string or buffer. See Eli
3608 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3609
3610 * alloc.c (__malloc_size_t): Remove.
3611 All uses replaced by size_t. See Andreas Schwab's note
3612 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3613
3614 * image.c: Improve checking for integer overflow.
3615 (check_image_size): Assume that f is nonnull, since
3616 it is always nonnull in practice. This is one less thing to
3617 worry about when checking for integer overflow later.
3618 (x_check_image_size): New function, which checks for integer
3619 overflow issues inside X.
3620 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3621 This removes the need for a memory_full check.
3622 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3623 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3624 (xbm_read_bitmap_data): Change locals back to 'int', since
3625 their values must fit in 'int'.
3626 (xpm_load_image, png_load, tiff_load):
3627 Invoke x_create_x_image_and_pixmap earlier,
3628 to avoid much needless work if the image is too large.
3629 (tiff_load): Treat overly large images as if
3630 x_create_x_image_and_pixmap failed, not as malloc failures.
3631 (gs_load): Use x_check_image_size.
3632
3633 * gtkutil.c: Omit integer casts.
3634 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3635 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3636
3637 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3638
3639 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3640 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3641 would wrongly return t on a 64-bit host.
3642
3643 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3644 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3645 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3646 and therefore cause GCC to emit a bogus diagnostic in some cases.
3647
3648 * image.c: Integer signedness and overflow and related fixes.
3649 This is not an exhaustive set of fixes, but it's time to
3650 record what I've got.
3651 (lookup_pixel_color, check_image_size): Remove redundant decls.
3652 (check_image_size): Don't assume that arbitrary EMACS_INT values
3653 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3654 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3655 (tiff_load, imagemagick_load_image):
3656 Check for overflow in size calculations.
3657 (x_create_x_image_and_pixmap): Remove unnecessary test for
3658 xmalloc returning NULL; that can't happen.
3659 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3660 (xpm_color_bucket): Use better integer hashing function.
3661 (xpm_cache_color): Don't possibly over-allocate memory.
3662 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3663 (gif_memory_source):
3664 Use ptrdiff_t, not int or size_t, to record sizes.
3665 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3666 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3667 either works, as we prefer signed integers.
3668 (tiff_read_from_memory, tiff_write_from_memory):
3669 Return tsize_t, not size_t, since that's what the TIFF API wants.
3670 (tiff_read_from_memory): Don't fail simply because the read would
3671 go past EOF; instead, return a short read.
3672 (tiff_load): Omit no-longer-needed casts.
3673 (Fimagemagick_types): Don't assume size fits into 'int'.
3674
3675 Improve hashing quality when configured --with-wide-int.
3676 * fns.c (hash_string): New function, taken from sxhash_string.
3677 Do not discard information about ASCII character case; this
3678 discarding is no longer needed.
3679 (sxhash-string): Use it. Change sig to match it. Caller changed.
3680 * lisp.h: Declare it.
3681 * lread.c (hash_string): Remove, since we now use fns.c's version.
3682 The fns.c version returns a wider integer if --with-wide-int is
3683 specified, so this should help the quality of the hashing a bit.
3684
3685 * emacs.c: Integer overflow minor fix.
3686 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3687 Define only if GNU_LINUX.
3688 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3689
3690 * dispnew.c: Integer signedness and overflow fixes.
3691 Remove unnecessary forward decls, that were a maintenance hassle.
3692 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3693 All uses changed.
3694 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3695 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3696 (prepare_desired_row, line_draw_cost):
3697 Use int, not unsigned, where either works.
3698 (save_current_matrix, restore_current_matrix):
3699 Use ptrdiff_t, not size_t, where either works.
3700 (init_display): Check for overflow more accurately, and without
3701 relying on undefined behavior.
3702
3703 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3704 Remove, replacing with the new symbols in lisp.h. All uses changed.
3705 * fileio.c (make_temp_name):
3706 * filelock.c (lock_file_1, lock_file):
3707 * xdisp.c (message_dolog):
3708 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3709 Use pMd etc. instead.
3710 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3711 replacing the pWIDE etc. symbols removed from editfns.c.
3712
3713 * keyboard.h (num_input_events): Now uintmax_t.
3714 This is (very slightly) less likely to mess up due to wraparound.
3715 All uses changed.
3716
3717 * buffer.c: Integer signedness fixes.
3718 (alloc_buffer_text, enlarge_buffer_text):
3719 Use ptrdiff_t rather than size_t when either will do, as we prefer
3720 signed integers.
3721
3722 * alloc.c: Integer signedness and overflow fixes.
3723 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3724 (__malloc_size_t): Default to size_t, not to int.
3725 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3726 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3727 Prefer ptrdiff_t to size_t when either would do, as we prefer
3728 signed integers.
3729 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3730 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3731 Now const. Initialize with values that are in range even if char
3732 is signed.
3733 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3734 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3735 These functions do the right thing with sizes > 2**32.
3736 (check_depth): Now ptrdiff_t, not int.
3737 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3738 Adjust to new way of storing sizes. Check for size overflow bugs
3739 in rest of code.
3740 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3741 slightly wrong anyway, as it missed one instance of
3742 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3743 (refill_memory_reserve): Omit needless cast to size_t.
3744 (mark_object_loop_halt): Mark as externally visible.
3745
3746 * xselect.c: Integer signedness and overflow fixes.
3747 (Fx_register_dnd_atom, x_handle_dnd_message):
3748 Use ptrdiff_t, not size_t, since we prefer signed.
3749 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3750 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3751 x_dnd_atoms_size and x_dnd_atoms_length.
3752
3753 * doprnt.c: Prefer signed to unsigned when either works.
3754 * eval.c (verror):
3755 * doprnt.c (doprnt):
3756 * lisp.h (doprnt):
3757 * xdisp.c (vmessage):
3758 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3759 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3760 prefer signed arithmetic to avoid comparison confusion.
3761 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3762 but is a bit tricky.
3763
3764 Assume freestanding C89 headers, string.h, stdlib.h.
3765 * data.c, doprnt.c, floatfns.c, print.c:
3766 Include float.h unconditionally.
3767 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3768 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3769 * regex.c: Likewise for stddef.h, string.h.
3770 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3771 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3772 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3773 (STDC_HEADERS): Remove obsolete defines.
3774 * sysdep.c: Include limits.h unconditionally.
3775
3776 Assume support for memcmp, memcpy, memmove, memset.
3777 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3778 * regex.c (memcmp, memcpy):
3779 Remove; we assume C89 now.
3780
3781 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3782 (__malloc_safe_bcopy): Remove; no longer needed.
3783
3784 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3785 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3786 well either way, and we prefer signed to unsigned.
3787
3788 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3789
3790 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3791 closes the connection while we're reading (bug#9182).
3792
3793 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3794
3795 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3796 are specified (Bug#9168).
3797
3798 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3801 Found by GCC static checking and --with-wide-int on a 32-bit host.
3802
3803 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3804
3805 * xdisp.c (compute_display_string_pos): Fix logic of caching
3806 previous display string position. Initialize cached_prev_pos to
3807 -1. Fixes slow-down at the beginning of a buffer.
3808
3809 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3810
3811 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3812 for attrs[LFACE_FONTSET_INDEX].
3813
3814 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 * xml.c (parse_region): Remove unused local
3817 that was recently introduced.
3818
3819 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3820
3821 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3822 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3823
3824 * xdisp.c (move_it_in_display_line_to): Record the best matching
3825 position for TO_CHARPOS while scanning the line, and restore it on
3826 exit if none of the characters scanned was an exact match.
3827 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3828 when exact match is impossible due to invisible text, and the
3829 lines are truncated.
3830
3831 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3832
3833 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3834 for OSX >= 10.7.
3835
3836 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3837
3838 Fix a significant slow-down of cursor motion with C-n, C-p,
3839 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3840 auto-repeat under bidi redisplay in fontified buffers.
3841 * xdisp.c (compute_stop_pos_backwards): New function.
3842 (next_element_from_buffer): Call compute_stop_pos_backwards to
3843 find a suitable prev_stop when we find ourselves before
3844 base_level_stop.
3845 (reseat): Don't look for prev_stop, as that could mean a very long
3846 run.
3847 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3848 <cached_disp_overlay_modiff>: Cache for last found display string
3849 position.
3850 (compute_display_string_pos): Return the cached position if asked
3851 about the same buffer in the same area of character positions, and
3852 the buffer wasn't changed since the time the display string
3853 position was cached.
3854
3855 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3856
3857 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3858 is an integer, which is important for empty lines. (Bug#9149)
3859
3860 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3861
3862 * frame.c (Fmodify_frame_parameters): In tty case, update the
3863 default face if necessary (Bug#4238).
3864
3865 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3866
3867 * editfns.c (Fstring_to_char): No need to explain what a character
3868 is in the docstring (Bug#6576).
3869
3870 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3871
3872 * xml.c (parse_region): Make sure we always return a tree.
3873
3874 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3875
3876 * xml.c (parse_region): If a document contains only comments,
3877 return that, too.
3878
3879 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3880
3881 * xml.c (make_dom): Return comments, too.
3882
3883 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3884
3885 Port to OpenBSD.
3886 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3887 and the surrounding thread.
3888 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3889 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3890 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3891 timer goes off.
3892 * s/openbsd.h (BROKEN_SIGIO): Define.
3893 * unexelf.c (unexec) [__OpenBSD__]:
3894 Don't update the .mdebug section of the Alpha COFF symbol table.
3895
3896 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3897
3898 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3899 (bug#8460).
3900
3901 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3904 This fixes some race conditions on the permissions of any newly
3905 created file.
3906
3907 * alloc.c (valid_pointer_p): Use pipe, not open.
3908 This fixes some permissions issues when debugging.
3909
3910 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3911 If fchown fails to set both uid and gid, try to set just gid,
3912 as that is sometimes allowed. Adjust the file's mode to eliminate
3913 setuid or setgid bits that are inappropriate if fchown fails.
3914
3915 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3916
3917 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3918 to compare Lisp_Objects.
3919 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3920 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3921 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3922
3923 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3924
3925 * lread.c (read_integer): Unread even EOF character.
3926 (read1): Likewise. Properly record start position of symbol.
3927
3928 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3929 symbol character follows.
3930
3931 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3934 This works around a problem with the previous change to Fcopy_file.
3935 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3936 and without this change, GCC might complain about discarding
3937 fchown's return value.
3938
3939 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3940
3941 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3942
3943 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3946
3947 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3948
3949 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3950 it's used from the C level.
3951
3952 * process.c: Use the same condition for POLL_FOR_INPUT in both
3953 keyboard.c and process.c (bug#1858).
3954
3955 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3956
3957 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3958 (Fgnutls_boot): Use it.
3959
3960 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3961
3962 * doc.c (Fsubstitute_command_keys): Revert last change.
3963
3964 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3965
3966 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3967 quotes the next character, and doesn't affect other longer
3968 sequences (bug#8935).
3969
3970 * lread.c (syms_of_lread): Clarify that is isn't only
3971 `eval-buffer' and `eval-defun' that's affected by
3972 `lexical-binding' (bug#8460).
3973
3974 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3975
3976 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3977 bidi redisplay when a line includes both an image and is truncated.
3978
3979 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3980
3981 Fix minor problems found by static checking.
3982 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3983 (elsz): Now a signed constant, not a size_t var. We prefer signed
3984 types to unsigned, to avoid integer comparison confusion. Without
3985 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3986 "cannot optimize loop, the loop counter may overflow", a symptom
3987 of the confusion.
3988 * indent.c (Fvertical_motion): Mark locals as initialized.
3989 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3990
3991 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3992
3993 * search.c (Fre_search_backward): Mention `case-fold-search' in
3994 all the re_search_* functions (bug#8138).
3995
3996 * keyboard.c (Fopen_dribble_file): Document when the file is
3997 closed (bug#8056).
3998
3999 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4000
4001 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4002 bidi_cache_idx.
4003
4004 Support bidi reordering of display and overlay strings.
4005 * xdisp.c (compute_display_string_pos)
4006 (compute_display_string_end): Accept additional argument STRING.
4007 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4008 (reseat_to_string): Initialize bidi_it->string.s and
4009 bidi_it->string.schars.
4010 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4011 NULL (avoids a crash in bidi_paragraph_init).
4012 Initialize itb.string.lstring.
4013 (init_iterator): Call bidi_init_it only of a valid
4014 buffer position was specified. Initialize paragraph_embedding to
4015 L2R.
4016 (reseat_to_string): Initialize the bidi iterator.
4017 (display_string): If we need to ignore text properties of
4018 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4019 original value of -1 will not work with bidi.)
4020 (compute_display_string_pos): First arg is now struct
4021 `text_pos *'; all callers changed. Support display properties on
4022 Lisp strings.
4023 (compute_display_string_end): Support display properties on Lisp
4024 strings.
4025 (init_iterator, reseat_1, reseat_to_string): Initialize the
4026 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4027 when iterating on a string not from display properties).
4028 (compute_display_string_pos, compute_display_string_end):
4029 Fix calculation of the object to scan. Fixes an error when using
4030 arrow keys.
4031 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4032 base_level_stop; instead, set base_level_stop to BEGV.
4033 Fixes crashes in vertical-motion.
4034 (next_element_from_buffer): Improve commentary for when
4035 the iterator is before prev_stop.
4036 (init_iterator): Initialize bidi_p from the default value of
4037 bidi-display-reordering, not from buffer-local value. Use the
4038 buffer-local value only if initializing for buffer iteration.
4039 (handle_invisible_prop): Support invisible properties on strings
4040 that are being bidi-reordered.
4041 (set_iterator_to_next): Support bidi reordering of C strings and
4042 Lisp strings.
4043 (next_element_from_string): Support bidi reordering of Lisp
4044 strings.
4045 (handle_stop_backwards): Support Lisp strings as well.
4046 (display_string): Support display of R2L glyph rows.
4047 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4048 (init_iterator): Don't initialize it->bidi_p for strings
4049 here.
4050 (reseat_to_string): Initialize it->bidi_p for strings here.
4051 (next_element_from_string, next_element_from_c_string)
4052 (next_element_from_buffer): Add xassert's for correspondence
4053 between IT's object being iterated and it->bidi_it.string
4054 structure.
4055 (face_before_or_after_it_pos): Support bidi iteration.
4056 (next_element_from_c_string): Handle the case of the first string
4057 character that is not the first one in the visual order.
4058 (get_visually_first_element): New function, refactored from common
4059 parts of next_element_from_buffer, next_element_from_string, and
4060 next_element_from_c_string.
4061 (tool_bar_lines_needed, redisplay_tool_bar)
4062 (display_menu_bar): Force left-to-right direction. Add a FIXME
4063 comment for making that be controlled by a user option.
4064 (push_it, pop_it): Save and restore the state of the
4065 bidi iterator. Save and restore the bidi_p flag.
4066 (pop_it): Iterate out of display property for string iteration as
4067 well.
4068 (iterate_out_of_display_property): Support iteration over strings.
4069 (handle_single_display_spec): Set up it->bidi_it for iteration
4070 over a display string, and call bidi_init_it.
4071 (handle_single_display_spec, next_overlay_string)
4072 (get_overlay_strings_1, push_display_prop): Set up the bidi
4073 iterator for displaying display or overlay strings.
4074 (forward_to_next_line_start): Don't use the shortcut if
4075 bidi-iterating.
4076 (back_to_previous_visible_line_start): If handle_display_prop
4077 pushed the iterator stack, restore the internal state of the bidi
4078 iterator by calling bidi_pop_it same number of times.
4079 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4080 and we are bidi-iterating, don't decrement the iterator position;
4081 instead, set the first_elt flag in the bidi iterator, to produce
4082 the same effect.
4083 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4084 (push_display_prop): xassert that we are iterating a buffer.
4085 (push_it, pop_it): Save and restore paragraph_embedding member.
4086 (handle_single_display_spec, next_overlay_string)
4087 (get_overlay_strings_1, reseat_1, reseat_to_string)
4088 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4089 correctly. Don't assume unibyte strings are not bidi-reordered.
4090 (compute_display_string_pos)
4091 (compute_display_string_end): Fix handling the case of C string.
4092 (push_it, pop_it): Save and restore from_disp_prop_p.
4093 (handle_single_display_spec, push_display_prop): Set the
4094 from_disp_prop_p flag.
4095 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4096 (pop_it): Call iterate_out_of_display_property only if we are
4097 popping after iteration over a string that came from a display
4098 property. Fix a typo in popping stretch info. Add an assertion
4099 for verifying that the iterator position is in sync with the bidi
4100 iterator.
4101 (handle_single_display_spec, get_overlay_strings_1)
4102 (push_display_prop): Fix initialization of paragraph direction for
4103 string when that of the parent object is not yet determined.
4104 (reseat_1): Call bidi_init_it to resync the bidi
4105 iterator with IT's position. (Bug#7616)
4106 (find_row_edges): If ROW->start.pos gives position
4107 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4108 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4109 Reset the from_disp_prop_p flag.
4110 (SAVE_IT, RESTORE_IT): New macros.
4111 (pos_visible_p, face_before_or_after_it_pos)
4112 (back_to_previous_visible_line_start)
4113 (move_it_in_display_line_to, move_it_in_display_line)
4114 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4115 (try_scrolling, redisplay_window, display_line): Use them when
4116 saving a temporary copy of the iterator and restoring it back.
4117 (back_to_previous_visible_line_start, reseat_1)
4118 (init_iterator): Empty the bidi cache "stack".
4119 (move_it_in_display_line_to): If iterator ended up at
4120 EOL, but we never saw any buffer positions smaller than
4121 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4122 motion in bidi-reordered lines.
4123 (move_it_in_display_line_to): Record prev_method and prev_pos
4124 immediately before the call to set_iterator_to_next. Fixes cursor
4125 motion in bidi-reordered lines with stretch glyphs and strings
4126 displayed in margins. (Bug#8133) (Bug#8867)
4127 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4128 TO_CHARPOS.
4129 (pos_visible_p): Support positions in bidi-reordered lines.
4130 Save and restore bidi cache.
4131
4132 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4133 (bidi_paragraph_info): Delete unused struct.
4134 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4135 (bidi_cache_start): New variable.
4136 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4137 to zero.
4138 (bidi_cache_fetch_state, bidi_cache_search)
4139 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4140 (bidi_cache_find, bidi_peek_at_next_level)
4141 (bidi_level_of_next_char, bidi_find_other_level_edge)
4142 (bidi_move_to_visually_next): Compare cache index with
4143 bidi_cache_start rather than with zero.
4144 (bidi_fetch_char): Accept new argument STRING; all callers
4145 changed. Support iteration over a string. Support strings with
4146 display properties. Support unibyte strings. Fix the type of
4147 `len' according to what STRING_CHAR_AND_LENGTH expects.
4148 (bidi_paragraph_init, bidi_resolve_explicit_1)
4149 (bidi_resolve_explicit, bidi_resolve_weak)
4150 (bidi_level_of_next_char, bidi_move_to_visually_next):
4151 Support iteration over a string.
4152 (bidi_set_sor_type, bidi_resolve_explicit_1)
4153 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4154 can now be zero (for strings); special values 0 and -1 were
4155 changed to -1 and -2, respectively.
4156 (bidi_char_at_pos): New function.
4157 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4158 Call it instead of FETCH_MULTIBYTE_CHAR.
4159 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4160 initialized to valid values.
4161 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4162 values.
4163 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4164 the test for valid cached positions. Fix the logic for looking up
4165 the sentinel state in the cache. GCPRO the Lisp string we are
4166 iterating.
4167 (bidi_push_it, bidi_pop_it): New functions.
4168 (bidi_initialize): Initialize the bidi cache start stack pointer.
4169 (bidi_cache_ensure_space): New function, refactored from part of
4170 bidi_cache_iterator_state. Don't assume the required size is just
4171 one BIDI_CACHE_CHUNK away.
4172 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4173 (bidi_count_bytes, bidi_char_at_pos): New functions.
4174 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4175 always valid if bidi_cache_idx is valid.
4176 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4177 is valid if it's going to be used.
4178 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4179 (bidi_cache_fetch_state, bidi_cache_search)
4180 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4181 (bidi_cache_iterator_state, bidi_cache_find)
4182 (bidi_find_other_level_edge, bidi_cache_start_stack):
4183 All variables related to cache indices are now EMACS_INT.
4184
4185 * dispextern.h (struct bidi_string_data): New structure.
4186 (struct bidi_it): New member `string'. Make flag members be 1-bit
4187 fields, and put them last in the struct.
4188 (compute_display_string_pos, compute_display_string_end):
4189 Update prototypes.
4190 (bidi_push_it, bidi_pop_it): Add prototypes.
4191 (struct iterator_stack_entry): New members bidi_p,
4192 paragraph_embedding, and from_disp_prop_p.
4193 (struct it): Member bidi_p is now a bit field 1 bit wide.
4194 (bidi_shelve_cache, bidi_unshelve_cache):
4195 Declare prototypes.
4196
4197 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4198 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4199 and vector-like objects.
4200
4201 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4202 cache around display iteration.
4203
4204 * window.c (Fwindow_end, window_scroll_pixel_based)
4205 (displayed_window_lines, Frecenter): Save and restore the bidi
4206 cache around display iteration.
4207
4208 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4209
4210 * editfns.c (Fdelete_region): Clarify the use of the named
4211 parameters (bug#6788).
4212
4213 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4214
4215 * indent.c (Fvertical_motion): Set and restore w->pointm when
4216 saving and restoring the window's buffer (Bug#9006).
4217
4218 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4219
4220 * editfns.c (Fstring_to_char): Clarify just what is returned
4221 (bug#6576). Text by Eli Zaretskii.
4222
4223 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4224
4225 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4226
4227 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4228
4229 * buffer.c (mmap_find): Fix a typo.
4230
4231 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4232
4233 Fix execution of x selection hooks.
4234 * xselect.c (Qx_lost_selection_functions)
4235 (Qx_sent_selection_functions): New vars.
4236 (syms_of_xselect): DEFSYM them.
4237 (x_handle_selection_request): Pass Qx_sent_selection_functions
4238 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4239 (x_handle_selection_clear,x_clear_frame_selections):
4240 Pass Qx_lost_selection_functions rather than
4241 Vx_lost_selection_functions to Frun_hook_with_args.
4242
4243 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4246 The old code sometimes used this field without initializing it.
4247
4248 * alloc.c (gc_sweep): Don't read past end of array.
4249 In theory, the old code could also have corrupted Emacs internals,
4250 though it'd be very unlikely.
4251
4252 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4253
4254 * character.c (Fcharacterp): Don't advertise optional ignored
4255 argument. (Bug#4026)
4256
4257 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4258
4259 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4260 key" (bug#4257).
4261
4262 * window.c (Fset_window_start): Doc fix (bug#4199).
4263 (Fset_window_hscroll): Ditto.
4264
4265 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 Fix minor new problems caught by GCC 4.6.1.
4268 * term.c (init_tty): Remove unused local.
4269 * xsettings.c (store_monospaced_changed): Define this function only
4270 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4271 not used otherwise.
4272
4273 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4274
4275 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4276
4277 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4278
4279 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4280 are the mini-buffer and the echo area (bug#3320).
4281
4282 * term.c (init_tty): Remove support for supdup, c10 and perq
4283 terminals, which are no longer supported (bug#1482).
4284
4285 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4286
4287 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4288
4289 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4290
4291 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4292 for non-popups (Bug#3642).
4293
4294 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4295
4296 * alloc.c (reset_malloc_hooks): Protoize.
4297 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4298 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4299 * cm.c (losecursor): Likewise.
4300 * data.c (fmod): Likewise.
4301 * dispnew.c (swap_glyphs_in_rows): Likewise.
4302 * emacs.c (memory_warning_signal): Likewise.
4303 * floatfns.c (float_error): Likewise.
4304 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4305 (otf_open, font_otf_capability, generate_otf_features)
4306 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4307 Likewise.
4308 * image.c (pbm_read_file): Likewise.
4309 * indent.c (string_display_width): Likewise.
4310 * intervals.c (check_for_interval, search_for_interval)
4311 (inc_interval_count, count_intervals, root_interval)
4312 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4313 * lread.c (defalias): Likewise.
4314 * ralloc.c (r_alloc_check): Likewise.
4315 * regex.c (set_image_of_range_1, set_image_of_range)
4316 (regex_grow_registers): Likewise.
4317 * sysdep.c (strerror): Likewise.
4318 * termcap.c (valid_filename_p, tprint, main): Likewise.
4319 * tparam.c (main): Likewise.
4320 * unexhp9k800.c (run_time_remap, save_data_space)
4321 (update_file_ptrs, read_header, write_header, calculate_checksum)
4322 (copy_file, copy_rest, display_header): Likewise.
4323 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4324 Likewise.
4325 * xdisp.c (check_it): Likewise.
4326 * xfaces.c (register_color, unregister_color, unregister_colors):
4327 Likewise.
4328 * xfns.c (print_fontset_result): Likewise.
4329 * xrdb.c (member, fatal, main): Likewise.
4330
4331 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4332
4333 Fix minor problems found by static checking (Bug#9031).
4334 * chartab.c (char_table_set_range, map_sub_char_table):
4335 Remove unused locals.
4336 (uniprop_table): Now static.
4337 * composite.c (_work_char): Remove unused static var.
4338
4339 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4340
4341 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4342
4343 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4344
4345 * gtkutil.c (qttip_cb): Remove code without function.
4346
4347 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4348
4349 * w32.c (pthread_sigmask): New stub.
4350
4351 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 Use pthread_sigmask, not sigprocmask (Bug#9010).
4354 sigprocmask is portable only for single-threaded applications, and
4355 Emacs can be multi-threaded when it uses GTK.
4356 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4357 (LIBES): Use it.
4358 * callproc.c (Fcall_process):
4359 * process.c (create_process):
4360 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4361 Use pthread_sigmask, not sigprocmask.
4362
4363 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4364
4365 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4366 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4367 wrong (Bug#8591).
4368
4369 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4370
4371 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4372 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4373 (xg_hide_tooltip): Fix comment.
4374
4375 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4376 in registerServicesMenuSendTypes.
4377 (validRequestorForSendType): Don't check ns_return_types.
4378
4379 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4380 ns_return_type.
4381
4382 2011-07-08 Jason Rumney <jasonr@gnu.org>
4383
4384 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4385 SH_SHOW for hidden windows (Bug#5482).
4386
4387 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4388 frame struct members of non-existent frames (Bug#6284).
4389
4390 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4391
4392 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4393 variable firstTime not needed on OSX >= 10.6.
4394 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4395 >= 10.5. Use setKnobProportion, setDoubleValue.
4396
4397 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4398 (MAC_OS_X_VERSION_10_5): Define if not defined.
4399 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4400 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4401 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4402
4403 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4404 cString and lossyCString on OSX >= 10.4
4405
4406 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4407 sizeToFit on OSX >= 10.2.
4408
4409 * nsimage.m (allocInitFromFile): Don't use deprecated method
4410 bestRepresentationForDevice on OSX >= 10.6.
4411
4412 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4413 to avoid warning.
4414
4415 * emacs.c: Declare unexec_init_emacs_zone.
4416
4417 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4418
4419 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4420
4421 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4422 on svcsMenu (Bug#8842).
4423
4424 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4425 ns_return_types.
4426 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4427
4428 * nsterm.m (QUTF8_STRING): Declare.
4429 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4430 (validRequestorForSendType): Return type is (id).
4431 Change indexOfObjectIdenticalTo to indexOfObject.
4432 Check if we have local selection before returning self (Bug#8842).
4433 (writeSelectionToPasteboard): Put local selection into paste board
4434 if we have a local selection (Bug#8842).
4435 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4436
4437 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4438 (ns_get_local_selection): Declare.
4439
4440 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4441
4442 * keymap.c (describe_map_tree): Don't insert a double newline at
4443 the end of the buffer (bug#1169) and return whether we inserted
4444 something.
4445
4446 * callint.c (Fcall_interactively): Change "reading args" to
4447 "providing args" to try to clarify what it does (bug#1010).
4448
4449 2011-07-07 Kenichi Handa <handa@m17n.org>
4450
4451 * composite.c (composition_compute_stop_pos): Ignore a static
4452 composition starting before CHARPOS (Bug#8915).
4453
4454 * xdisp.c (handle_composition_prop): Likewise.
4455
4456 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4457
4458 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4459 (Bug#9015)
4460
4461 2011-07-07 Kenichi Handa <handa@m17n.org>
4462
4463 * character.h (unicode_category_t): New enum type.
4464
4465 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4466 (Qchar_code_property_table): New variable.
4467 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4468 (UNIPROP_COMPRESSED_FORM_P): New macros.
4469 (char_table_ascii): Uncompress the compressed values.
4470 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4471 Uncompress the compressed values.
4472 (sub_char_table_ref_and_range): Likewise.
4473 (char_table_ref_and_range): Uncompress the compressed values.
4474 (sub_char_table_set): New arg is_uniprop. Callers changed.
4475 Uncompress the compressed values.
4476 (sub_char_table_set_range): Args changed. Callers changed.
4477 (char_table_set_range): Adjuted for the above change.
4478 (map_sub_char_table): Delete args default_val and parent. Add arg
4479 top. Give decoded values to a Lisp function.
4480 (map_char_table): Adjust for the above change. Give decoded
4481 values to a Lisp function. Gcpro more variables.
4482 (uniprop_table_uncompress)
4483 (uniprop_decode_value_run_length): New functions.
4484 (uniprop_decoder, uniprop_decoder_count): New variables.
4485 (uniprop_get_decoder, uniprop_encode_value_character)
4486 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4487 New functions.
4488 (uniprop_encoder, uniprop_encoder_count): New variables.
4489 (uniprop_get_encoder, uniprop_table)
4490 (Funicode_property_table_internal, Fget_unicode_property_internal)
4491 (Fput_unicode_property_internal): New functions.
4492 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4493 Sunicode_property_table_internal, Sget_unicode_property_internal,
4494 and Sput_unicode_property_internal. Defvar_lisp
4495 char-code-property-alist.
4496
4497 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4498 Vunicode_category_table.
4499
4500 * font.c (font_range): Adjust for the change of
4501 Vunicode_category_table.
4502
4503 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4504
4505 * m/iris4d.h: Remove file, move contents ...
4506 * s/irix6-5.h: ... here.
4507
4508 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4509
4510 Remove unportable assumption about struct layout (Bug#8884).
4511 * alloc.c (mark_buffer):
4512 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4513 (clone_per_buffer_values): Don't assume that
4514 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4515 This isn't true in general, and it's particularly not true
4516 if Emacs is configured with --with-wide-int.
4517 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4518 New macros, used in the buffer.c change.
4519
4520 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4521
4522 * xsettings.c: Use both GConf and GSettings if both are available.
4523 (store_config_changed_event): Add comment.
4524 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4525 (store_tool_bar_style_changed): New functions.
4526 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4527 (struct xsettings): Move font inside HAVE_XFT.
4528 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4529 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4530 Move inside HAVE_XFT.
4531 (something_changed_gsettingsCB): Rename from something_changedCB.
4532 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4533 also.
4534 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4535 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4536 (something_changed_gconfCB): Rename from something_changedCB.
4537 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4538 (parse_settings): Move check for font inside HAVE_XFT.
4539 (read_settings, apply_xft_settings): Add comment.
4540 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4541 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4542 call store_font_name_changed.
4543 (xft_settings_event): Add comment.
4544 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4545 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4546 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4547 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4548 (xsettings_initialize): Call init_gsettings last.
4549 (xsettings_get_system_font, xsettings_get_system_normal_font):
4550 Add comment.
4551
4552 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 Random fixes. E.g., (random) never returned negative values.
4555 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4556 subseconds part to the entropy, as that's a bit more random.
4557 Prefer signed to unsigned, since the signedness doesn't matter and
4558 in general we prefer signed. When given a limit, use a
4559 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4560 latter isn't right if USE_2_TAGS_FOR_INTS.
4561 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4562 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4563
4564 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4565
4566 * textprop.c (text_property_stickiness):
4567 Obey Vtext_property_default_nonsticky.
4568 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4569 * w32fns.c (syms_of_w32fns):
4570 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4571
4572 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4573
4574 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4575 This is more efficient than Ffile_directory_p and avoids a minor race.
4576
4577 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4578
4579 * buffer.c (Foverlay_put): Say what the return value is
4580 (bug#7835).
4581
4582 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4583 is a directory before asking whether to use the file name
4584 (bug#7564).
4585 (barf_or_query_if_file_exists): Make the "File is a directory"
4586 error be more correct.
4587
4588 * fns.c (Frequire): Remove the mention of the .gz files, since
4589 that's installation-specific, but keep the mention of
4590 `get-load-suffixes'.
4591
4592 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4593
4594 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4595 Report string overflow if the output is too long.
4596
4597 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4598
4599 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4600 (syms_of_gnutls): Remove duplicate DEFSYM for
4601 Qgnutls_bootprop_verify_hostname_error, an error for
4602 Qgnutls_bootprop_verify_error (which is no longer used).
4603
4604 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4605 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4606 Also (re)move comments that are misplaced or no longer relevant.
4607
4608 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4609
4610 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4611
4612 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4613
4614 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4615 and background color parameters if they have been changed.
4616
4617 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4618
4619 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4620
4621 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4622
4623 * xsettings.c (SYSTEM_FONT): Define only when used.
4624 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4625
4626 * keymap.c (access_keymap_1): Now static.
4627
4628 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4629
4630 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4631 leave any prefix arg for the up event (Bug#1586).
4632
4633 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4634
4635 * lread.c (syms_of_lread): Mention single symbols defined by
4636 `defvar' or `defconst' (bug#7154).
4637
4638 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4639 (Frequire): Mention get-load-suffixes.
4640
4641 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4642
4643 * window.h (window): Remove clone_number slot.
4644 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4645 Remove.
4646 (make_parent_window, make_window, saved_window)
4647 (Fset_window_configuration, save_window_save): Don't deal with
4648 clone numbers.
4649 * buffer.c (Qclone_number): Remove declaration.
4650 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4651
4652 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4653
4654 Add multiple inheritance to keymaps.
4655 * keymap.c (Fmake_composed_keymap): New function.
4656 (Fset_keymap_parent): Simplify.
4657 (fix_submap_inheritance): Remove.
4658 (access_keymap_1): New function extracted from access_keymap to handle
4659 embedded parents and handle lists of maps.
4660 (access_keymap): Use it.
4661 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4662 (Fcopy_keymap): Handle embedded parents.
4663 (Fcommand_remapping, define_as_prefix): Simplify.
4664 (Fkey_binding): Simplify.
4665 (syms_of_keymap): Move minibuffer-local-completion-map,
4666 minibuffer-local-filename-completion-map,
4667 minibuffer-local-must-match-map, and
4668 minibuffer-local-filename-must-match-map to Elisp.
4669 (syms_of_keymap): Defsubr make-composed-keymap.
4670 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4671 (parse_menu_item): Trivial simplification.
4672
4673 2011-07-01 Glenn Morris <rgm@gnu.org>
4674
4675 * Makefile.in (SETTINGS_LIBS): Fix typo.
4676
4677 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4678
4679 * coding.c (Fencode_coding_string): Record the last coding system
4680 used, as the function doc string says (bug#8738).
4681
4682 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4683
4684 * xsettings.c (store_monospaced_changed): Take new font as arg and
4685 check for change against current_mono_font.
4686 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4687 (emacs_settings_constructor, emacs_settings_get_property)
4688 (emacs_settings_set_property, emacs_settings_class_init)
4689 (emacs_settings_init, gsettings_obj): Remove.
4690 (something_changedCB): New function for HAVE_GSETTINGS.
4691 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4692 with value as argument.
4693 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4694 g_settings_new (Bug#8967). Do not create gsettings_obj.
4695 Remove calls to g_settings_bind. Connect something_changedCB to
4696 "changed".
4697
4698 * xgselect.c: Add defined (HAVE_GSETTINGS).
4699 (xgselect_initialize): Ditto.
4700
4701 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4702 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4703 xg_select.
4704
4705 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4706
4707 * eval.c (struct backtrace): Simplify and port the data structure.
4708 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4709 signed bit field, as this assumption is not portable and it makes
4710 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4711 "char debug_on_exit : 1" as this is not portable either; instead,
4712 use the portable "unsigned int debug_on_exit : 1". Remove unused
4713 member evalargs. Remove obsolete comments about cc bombing out.
4714
4715 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4716
4717 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4718 Let HAVE_GSETTINGS override HAVE_GCONF.
4719 (store_monospaced_changed): New function.
4720 (EMACS_SETTINGS): A new type derived from GObject to handle
4721 GSettings notifications.
4722 (emacs_settings_constructor, emacs_settings_get_property)
4723 (emacs_settings_set_property, emacs_settings_class_init):
4724 New functions.
4725 (gsettings_client, gsettings_obj): New variables.
4726 (GSETTINGS_SCHEMA): New define.
4727 (something_changedCB): Call store_monospaced_changed.
4728 (init_gsettings): New function.
4729 (xsettings_initialize): Call init_gsettings.
4730 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4731 to NULL.
4732
4733 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4734 GCONF_CFLAGS/LIBS.
4735
4736 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4737
4738 * window.c (resize_root_window, grow_mini_window)
4739 (shrink_mini_window): Rename Qresize_root_window to
4740 Qwindow_resize_root_window and Qresize_root_window_vertically to
4741 Qwindow_resize_root_window_vertically.
4742
4743 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4744
4745 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4746
4747 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4748
4749 * makefile.w32-in: Redesign dependencies so they reflect more
4750 clearly which files are directly included by each source file,
4751 and not through other includes.
4752
4753 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4754
4755 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4756 (sort_overlays, overlay_strings): When an overlay's clone number
4757 matches the window's clone number process the overlay even if
4758 the overlay's window property doesn't match the current window.
4759
4760 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4761 (Fwindow_hchild): Rename to Fwindow_left_child.
4762 (Fwindow_next): Rename to Fwindow_next_sibling.
4763 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4764 (resize_window_check): Rename to window_resize_check.
4765 (resize_window_apply): Rename to window_resize_apply.
4766 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4767 (Fdelete_other_windows_internal, resize_frame_windows)
4768 (Fsplit_window_internal, Fdelete_window_internal)
4769 (grow_mini_window, shrink_mini_window)
4770 (Fresize_mini_window_internal): Fix callers accordingly.
4771
4772 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4773
4774 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4775 (emacs_fixed_set_min_size): Remove.
4776 (emacs_fixed_new): Take frame as argument.
4777
4778 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4779 (_EmacsFixedPrivate): Remove minwidth/height.
4780 Add struct frame *f.
4781 (emacs_fixed_init): Initialize priv->f.
4782 (get_parent_class, emacs_fixed_set_min_size): Remove.
4783 (emacs_fixed_new): Set priv->f to argument.
4784 (emacs_fixed_get_preferred_width)
4785 (emacs_fixed_get_preferred_height): Use min_width/height from
4786 frames size_hint to set minimum and natural (Bug#8919).
4787 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4788 and use min_width/height from frames size_hint to set
4789 min_width/height (Bug#8919).
4790
4791 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4792 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4793 Fix indentation.
4794
4795 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4796
4797 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4798 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4799 called at ZV.
4800
4801 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4802
4803 * process.c (wait_reading_process_output): Bypass select if
4804 waiting for a cell while ignoring keyboard input, and input is
4805 pending. Suggested by Jan Djärv (Bug#8869).
4806
4807 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 Use gnulib's dup2 module instead of rolling our own.
4810 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4811
4812 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4813
4814 * dispnew.c (scrolling_window): Before scrolling, turn off a
4815 mouse-highlight in the window being scrolled.
4816
4817 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4818
4819 Move DEFSYM to lisp.h and use everywhere.
4820
4821 * character.h (DEFSYM): Move declaration...
4822 * lisp.h (DEFSYM): ...here.
4823
4824 * gnutls.c:
4825 * minibuf.c:
4826 * w32menu.c:
4827 * w32proc.c:
4828 * w32select.c: Don't include character.h.
4829
4830 * alloc.c (syms_of_alloc):
4831 * buffer.c (syms_of_buffer):
4832 * bytecode.c (syms_of_bytecode):
4833 * callint.c (syms_of_callint):
4834 * casefiddle.c (syms_of_casefiddle):
4835 * casetab.c (init_casetab_once):
4836 * category.c (init_category_once, syms_of_category):
4837 * ccl.c (syms_of_ccl):
4838 * cmds.c (syms_of_cmds):
4839 * composite.c (syms_of_composite):
4840 * dbusbind.c (syms_of_dbusbind):
4841 * dired.c (syms_of_dired):
4842 * dispnew.c (syms_of_display):
4843 * doc.c (syms_of_doc):
4844 * editfns.c (syms_of_editfns):
4845 * emacs.c (syms_of_emacs):
4846 * eval.c (syms_of_eval):
4847 * fileio.c (syms_of_fileio):
4848 * fns.c (syms_of_fns):
4849 * frame.c (syms_of_frame):
4850 * fringe.c (syms_of_fringe):
4851 * insdel.c (syms_of_insdel):
4852 * keymap.c (syms_of_keymap):
4853 * lread.c (init_obarray, syms_of_lread):
4854 * macros.c (syms_of_macros):
4855 * msdos.c (syms_of_msdos):
4856 * print.c (syms_of_print):
4857 * process.c (syms_of_process):
4858 * search.c (syms_of_search):
4859 * sound.c (syms_of_sound):
4860 * syntax.c (init_syntax_once, syms_of_syntax):
4861 * terminal.c (syms_of_terminal):
4862 * textprop.c (syms_of_textprop):
4863 * undo.c (syms_of_undo):
4864 * w32.c (globals_of_w32):
4865 * window.c (syms_of_window):
4866 * xdisp.c (syms_of_xdisp):
4867 * xfaces.c (syms_of_xfaces):
4868 * xfns.c (syms_of_xfns):
4869 * xmenu.c (syms_of_xmenu):
4870 * xsettings.c (syms_of_xsettings):
4871 * xterm.c (syms_of_xterm): Use DEFSYM.
4872
4873 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4874
4875 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4876
4877 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 Integer and buffer overflow fixes (Bug#8873).
4880
4881 * print.c (printchar, strout): Check for string overflow.
4882 (PRINTPREPARE, printchar, strout):
4883 Don't set size unless allocation succeeds.
4884
4885 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4886 for sizes. Check for string overflow more accurately.
4887 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4888
4889 * macros.c: Integer and buffer overflow fixes.
4890 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4891 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4892 Use ptrdiff_t, not int, for sizes.
4893 Don't increment bufsize until after realloc succeeds.
4894 Check for size-calculation overflow.
4895 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4896
4897 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4898
4899 * lread.c: Integer overflow fixes.
4900 (read_integer): Radix is now EMACS_INT, not int,
4901 to improve quality of diagnostics for out-of-range radices.
4902 Calculate buffer size correctly for out-of-range radices.
4903 (read1): Check for integer overflow in radices, and in
4904 read-circle numbers.
4905 (read_escape): Avoid int overflow.
4906 (Fload, openp, read_buffer_size, read1)
4907 (substitute_object_recurse, read_vector, read_list, map_obarray):
4908 Use ptrdiff_t, not int, for sizes.
4909 (read1): Use EMACS_INT, not int, for sizes.
4910 Check for size overflow.
4911
4912 * image.c (cache_image): Check for size arithmetic overflow.
4913
4914 * lread.c: Integer overflow issues.
4915 (saved_doc_string_size, saved_doc_string_length)
4916 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4917 Now ptrdiff_t, not int.
4918 (read1): Don't assume doc string length fits in int. Check for
4919 out-of-range doc string lengths.
4920 (read_list): Don't assume file position fits in int.
4921 (read_escape): Check for hex character overflow.
4922
4923 2011-06-22 Leo Liu <sdl.web@gmail.com>
4924
4925 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4926 Move to minibuffer.el.
4927
4928 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4929
4930 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4931 The following patches are for when GLYPH_DEBUG && !XASSERT.
4932 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4933 * dispnew.c (flush_stdout):
4934 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4935 Mark as externally visible.
4936 * dispnew.c (check_window_matrix_pointers): Now static.
4937 * dispnew.c (window_to_frame_vpos):
4938 * xfns.c (unwind_create_frame):
4939 * xterm.c (x_check_font): Remove unused local.
4940 * scroll.c (CHECK_BOUNDS):
4941 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4942 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4943 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4944 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4945 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4946 Now static.
4947 (debug_method_add): Use va_list and vsprintf rather than relying
4948 on undefined behavior with wrong number of arguments.
4949 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4950 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4951 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4952 since we're not interested in debugging glyphs with old libraries.
4953 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4954 GCC 4.6.0's static checking.
4955
4956 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 Integer overflow and signedness fixes (Bug#8873).
4959 A few related buffer overrun fixes, too.
4960
4961 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4962
4963 * dispextern.h (struct face.stipple):
4964 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4965 (x_bitmap_mask, x_allocate_bitmap_record)
4966 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4967 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4968 (x_create_bitmap_from_xpm_data):
4969 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4970 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4971 (.bitmaps_last):
4972 * xfaces.c (load_pixmap):
4973 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4974 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4975 (.bitmaps_last, struct x_output.icon_bitmap):
4976 Use ptrdiff_t, not int, for bitmap indexes.
4977 (x_allocate_bitmap_record): Check for size overflow.
4978 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4979
4980 Use ptrdiff_t, not int, for overlay counts.
4981 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4982 * editfns.c (overlays_around, get_pos_property):
4983 * textprop.c (get_char_property_and_overlay):
4984 * xdisp.c (next_overlay_change, note_mouse_highlight):
4985 * xfaces.c (face_at_buffer_position):
4986 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4987 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4988 (Fnext_overlay_change, Fprevious_overlay_change)
4989 (mouse_face_overlay_overlaps, Foverlays_in):
4990 Use ptrdiff_t, not int, for sizes.
4991 (overlays_at, overlays_in): Check for size-calculation overflow.
4992
4993 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4994
4995 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4996 (x_session_initialize): Do not assume string length fits in int.
4997
4998 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4999 This is unlikely, but can occur if DPI is outlandish.
5000
5001 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5002 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5003
5004 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5005 * xrdb.c (magic_file_p, search_magic_path):
5006 Omit last arg SUFFIX; it was always 0. All callers changed.
5007 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5008
5009 * xfont.c (xfont_match): Avoid need for strlen.
5010
5011 * xfns.c: Don't assume strlen fits in int.
5012 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5013
5014 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5015 not unsigned long, as we prefer signed integers. All callers changed.
5016 Detect integer overflow in repeat count.
5017 (message_dolog): Don't assume print length fits in 39 bytes.
5018 (display_mode_element): Don't assume strlen fits in int.
5019
5020 * termcap.c: Don't assume sizes fit in int and never overflow.
5021 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5022 (gobble_line): Check for size-calculation overflow.
5023
5024 * minibuf.c (Fread_buffer):
5025 * lread.c (intern, intern_c_string):
5026 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5027 Don't assume string length fits in int.
5028
5029 * keyboard.c (parse_tool_bar_item):
5030 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5031
5032 * font.c: Don't assume string length fits in int.
5033 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5034 Use ptrdiff_t, not int.
5035 (font_intern_prop): Don't assume string length fits in int.
5036 Don't assume integer property fits in fixnum.
5037 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5038
5039 * filelock.c: Fix some buffer overrun and integer overflow issues.
5040 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5041 Reformulate so as not to need the command string.
5042 Invoke gzip -cd rather than gunzip, as it's more portable.
5043 (lock_info_type, lock_file_1, lock_file):
5044 Don't assume pid_t and time_t fit in unsigned long.
5045 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5046 (current_lock_owner): Prefer signed type for sizes.
5047 Use memcpy, not strncpy, where memcpy is what is really wanted.
5048 Don't assume (via atoi) that time_t and pid_t fit in int.
5049 Check for time_t and/or pid_t out of range, e.g., via a network share.
5050 Don't alloca where an auto var works fine.
5051
5052 * fileio.c: Fix some integer overflow issues.
5053 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5054 Don't assume string length fits in int.
5055 (directory_file_name): Don't assume string length fits in long.
5056 (make_temp_name): Don't assume pid fits in int, or that its print
5057 length is less than 20.
5058
5059 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5060
5061 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5062
5063 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5064
5065 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5066 We prefer signed integers, even for size calculations.
5067
5068 * emacs.c: Don't assume string length fits in 'int'.
5069 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5070 (main): Don't invoke strlen when not needed.
5071
5072 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5073 (XD_DEBUG_MESSAGE): Don't waste a byte.
5074
5075 * callproc.c (getenv_internal_1, getenv_internal)
5076 (Fgetenv_internal):
5077 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5078
5079 * lread.c (invalid_syntax): Omit length argument.
5080 All uses changed. This doesn't fix a bug, but it simplifies the
5081 code away from its former Hollerith-constant appearance, and it's
5082 one less 'int' to worry about when looking at integer-overflow issues.
5083 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5084
5085 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5086 This didn't break anything, but it didn't help either.
5087 It's confusing to put a bogus integer in a place where the actual
5088 value does not matter.
5089 (LIST_END_P): Remove unused macro and its bogus comment.
5090 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5091
5092 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5093 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5094 implementation.
5095 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5096 We prefer signed types, and the value cannot exceed the EMACS_INT
5097 range anyway (because otherwise the length would not be representable).
5098 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5099 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5100 This avoids a GCC warning when WIDE_EMACS_INT.
5101
5102 * indent.c (sane_tab_width): New function.
5103 (current_column, scan_for_column, Findent_to, position_indentation)
5104 (compute_motion): Use it. This is just for clarity.
5105 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5106
5107 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5108
5109 * lisp.h (lint_assume): New macro.
5110 * composite.c (composition_gstring_put_cache):
5111 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5112
5113 * editfns.c, insdel.c:
5114 Omit unnecessary forward decls, to simplify future changes.
5115
5116 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5117
5118 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5119
5120 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5121 Use much-faster test for byte-length change.
5122 Don't assume string byte-length fits in 'int'.
5123 Check that character arg fits in 'int'.
5124 (mapcar1): Declare byte as byte, for clarity.
5125
5126 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5127
5128 * fns.c (concat): Catch string overflow earlier.
5129 Do not rely on integer wraparound.
5130
5131 * dispextern.h (struct it.overlay_strings_charpos)
5132 (struct it.selective): Now EMACS_INT, not int.
5133 * xdisp.c (forward_to_next_line_start)
5134 (back_to_previous_visible_line_start)
5135 (reseat_at_next_visible_line_start, next_element_from_buffer):
5136 Don't arbitrarily truncate the value of 'selective' to int.
5137
5138 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5139
5140 * composite.c: Don't truncate sizes to 'int'.
5141 (composition_gstring_p, composition_reseat_it)
5142 (composition_adjust_point): Use EMACS_INT, not int.
5143 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5144 not EMACS_UINT, for indexes.
5145
5146 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5147
5148 * buffer.c: Include <verify.h>.
5149 (struct sortvec.priority, struct sortstr.priority):
5150 Now EMACS_INT, not int.
5151 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5152 (struct sortstr.size, record_overlay_string)
5153 (struct sortstrlist.size, struct sortlist.used):
5154 Don't truncate size to int.
5155 (record_overlay_string): Check for size-calculation overflow.
5156 (init_buffer_once): Check at compile-time, not run-time.
5157
5158 2011-06-22 Jim Meyering <meyering@redhat.com>
5159
5160 Don't leak an XBM-image-sized buffer
5161 * image.c (xbm_load): Free the image buffer after using it.
5162
5163 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5164
5165 Port to Sun C.
5166 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5167 that Sun C diagnosed.
5168 * fns.c (secure_hash): Fix pointer signedness issue.
5169 * intervals.c (static_offset_intervals): New function.
5170 (offset_intervals): Use it.
5171
5172 2011-06-21 Leo Liu <sdl.web@gmail.com>
5173
5174 * deps.mk (fns.o):
5175 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5176 sha512.h.
5177
5178 * fns.c (secure_hash): Rename from crypto_hash_function and change
5179 the first arg to accept symbols.
5180 (Fsecure_hash): New primitive.
5181 (syms_of_fns): New symbols.
5182
5183 2011-06-20 Deniz Dogan <deniz@dogan.se>
5184
5185 * process.c (Fset_process_buffer): Clarify return value in
5186 docstring.
5187
5188 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5189
5190 * dispnew.c (add_window_display_history): Use BVAR.
5191
5192 * xdisp.c (debug_method_add): Use BVAR.
5193 (check_window_end, dump_glyph_matrix, dump_glyph)
5194 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5195
5196 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5197 Likewise.
5198
5199 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5200 check till after the cache is created in init_frame_faces.
5201
5202 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5203
5204 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5205
5206 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5207
5208 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5209 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5210 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5211
5212 Improve buffer-overflow checking (Bug#8873).
5213 * fileio.c (Finsert_file_contents):
5214 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5215 Remove the old (too-loose) buffer overflow checks.
5216 They weren't needed, since make_gap checks for buffer overflow.
5217 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5218 The old code merely checked for Emacs fixnum overflow, and relied
5219 on undefined (wraparound) behavior. The new code avoids undefined
5220 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5221
5222 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5223 Tune. Don't use wider integers than needed. Don't use alloca.
5224 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5225
5226 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5227
5228 * insdel.c, lisp.h (buffer_overflow): New function.
5229 (insert_from_buffer_1, replace_range, replace_range_2):
5230 * insdel.c (make_gap_larger):
5231 * editfns.c (Finsert_char):
5232 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5233
5234 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5235
5236 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5237
5238 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5239
5240 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5241 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5242
5243 * fileio.c: Don't assume EMACS_INT fits in off_t.
5244 (emacs_lseek): New static function.
5245 (Finsert_file_contents, Fwrite_region): Use it.
5246 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5247
5248 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5249
5250 * fns.c: Don't overflow int when computing a list length.
5251 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5252 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5253 truncation on 64-bit hosts. Check for QUIT every
5254 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5255 faster and is responsive enough.
5256 (Flength): Report an error instead of overflowing an integer.
5257 (Fsafe_length): Return a float if the value is not representable
5258 as a fixnum. This shouldn't happen except in contrived situations.
5259 (Fnthcdr, Fsort): Don't assume list length fits in int.
5260 (Fcopy_sequence): Don't assume vector length fits in int.
5261
5262 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5263 (header_size, word_size): New constants.
5264 (allocate_vectorlike): Don't check size overflow here.
5265 (allocate_vector): Check it here instead, since this is the only
5266 caller of allocate_vectorlike that could cause overflow.
5267 Check that the new vector's length is representable as a fixnum.
5268
5269 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5270 The previous code was bogus. For example, next_almost_prime (32)
5271 returned 39, which is undesirable as it is a multiple of 3; and
5272 next_almost_prime (24) returned 25, which is a multiple of 5 so
5273 why was the code bothering to check for multiples of 7?
5274
5275 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5276
5277 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5278
5279 Variadic C functions now count arguments with ptrdiff_t.
5280 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5281 Back then I didn't know that the Emacs coding style prefers signed int.
5282 Also, in the meantime I found a few more instances where arguments
5283 were being counted with int, which may truncate counts on 64-bit
5284 machines, or EMACS_INT, which may be unnecessarily wide.
5285 * lisp.h (struct Lisp_Subr.function.aMANY)
5286 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5287 Arg counts are now ptrdiff_t, not size_t.
5288 All variadic functions and their callers changed accordingly.
5289 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5290 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5291 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5292 * callint.c (Fcall_interactively): Check arg count for overflow,
5293 to avoid potential buffer overrun. Use signed char, not 'int',
5294 for 'varies' array, so that we needn't bother to check its size
5295 calculation for overflow.
5296 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5297 * eval.c (apply_lambda):
5298 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5299 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5300 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5301
5302 * callint.c (Fcall_interactively): Don't use index var as event count.
5303
5304 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5305 * mem-limits.h (SIZE): Remove; no longer used.
5306
5307 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5308
5309 Remove unnecessary casts.
5310 * xterm.c (x_term_init):
5311 * xfns.c (x_set_border_pixel):
5312 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5313 These aren't needed now that we assume ANSI C.
5314
5315 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5316 It's more likely to cause problems (due to unsigned overflow)
5317 than to cure them.
5318
5319 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5320
5321 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5322
5323 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5324
5325 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5326
5327 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5328
5329 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5330
5331 GLYPH_CODE_FACE returns EMACS_INT, not int.
5332 * dispextern.h (merge_faces):
5333 * xfaces.c (merge_faces):
5334 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5335 Don't assume EMACS_INT fits in int.
5336
5337 * character.h (CHAR_VALID_P): Remove unused parameter.
5338 * fontset.c, lisp.h, xdisp.c: All uses changed.
5339
5340 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5341
5342 * fns.c (concat): Minor tuning based on overflow analysis.
5343 This doesn't fix any bugs. Use int to hold character, instead
5344 of constantly refetching from Emacs object. Use XFASTINT, not
5345 XINT, for value known to be a character. Don't bother comparing
5346 a single byte to 0400, as it's always less.
5347
5348 * floatfns.c (Fexpt):
5349 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5350
5351 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5352 for characters.
5353
5354 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5355
5356 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5357 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5358 incorrectly succeed when S was a string, because 4294967386 was
5359 truncated before it was used.
5360
5361 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5362 Otherwise, an out-of-range integer could cause undefined behavior
5363 on a 64-bit host.
5364
5365 * composite.c: Use int, not EMACS_INT, for characters.
5366 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5367 EMACS_INT, for values that are known to be in character range.
5368 This doesn't fix any bugs but is the usual style inside Emacs and
5369 may generate better code on 32-bit machines.
5370
5371 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5372 This is for reasons similar to the recent CHAR_STRING fix.
5373 * charset.c (Fencode_char): Check that character arg is actually
5374 a character. Pass an int to ENCODE_CHAR.
5375 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5376 wider than 'int', as a compile-time check to prevent future regressions
5377 in this area.
5378
5379 * character.c (char_string): Remove unnecessary casts.
5380
5381 Make sure a 64-bit char is never passed to CHAR_STRING.
5382 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5383 by silently ignoring the top 32 bits, allowing some values
5384 that were far too large to be valid characters.
5385 * character.h: Include <verify.h>.
5386 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5387 arguments are no wider than unsigned, as a compile-time check
5388 to prevent future regressions in this area.
5389 * data.c (Faset):
5390 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5391 (Fsubst_char_in_region):
5392 * fns.c (concat):
5393 * xdisp.c (decode_mode_spec_coding):
5394 Adjust to CHAR_STRING's new requirement.
5395 * editfns.c (Finsert_char, Fsubst_char_in_region):
5396 * fns.c (concat): Check that character args are actually
5397 characters. Without this test, these functions did the wrong
5398 thing with wildly out-of-range values on 64-bit hosts.
5399
5400 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5401 These casts should not be needed on 32-bit hosts, either.
5402 * keyboard.c (read_char):
5403 * lread.c (Fload): Remove casts to unsigned.
5404
5405 * lisp.h (UNSIGNED_CMP): New macro.
5406 This fixes comparison bugs on 64-bit hosts.
5407 (ASCII_CHAR_P): Use it.
5408 * casefiddle.c (casify_object):
5409 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5410 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5411 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5412 * dispextern.h (FACE_FROM_ID):
5413 * keyboard.c (read_char): Use UNSIGNED_CMP.
5414
5415 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5416 not to EMACS_INT, to avoid GCC warning.
5417
5418 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5419
5420 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5421 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5422 isn't needed on 32-bit machines.
5423
5424 * buffer.c (Fgenerate_new_buffer_name):
5425 Use EMACS_INT for count, not int.
5426 (advance_to_char_boundary): Return EMACS_INT, not int.
5427
5428 * data.c (Qcompiled_function): Now static.
5429
5430 * window.c (window_body_lines): Now static.
5431
5432 * image.c (gif_load): Rename local to avoid shadowing.
5433
5434 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5435 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5436 * alloc.c (make_save_value): Integer argument is now of type
5437 ptrdiff_t, not int.
5438 (mark_object): Use ptrdiff_t, not int.
5439 * lisp.h (pD): New macro.
5440 * print.c (print_object): Use it.
5441
5442 * alloc.c: Use EMACS_INT, not int, to count objects.
5443 (total_conses, total_markers, total_symbols, total_vector_size)
5444 (total_free_conses, total_free_markers, total_free_symbols)
5445 (total_free_floats, total_floats, total_free_intervals)
5446 (total_intervals, total_strings, total_free_strings):
5447 Now EMACS_INT, not int. All uses changed.
5448 (Fgarbage_collect): Compute overall total using a double, so that
5449 integer overflow is less likely to be a problem. Check for overflow
5450 when converting back to an integer.
5451 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5452 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5453 These were 'int' variables that could overflow on 64-bit hosts;
5454 they were never used, so remove them instead of repairing them.
5455 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5456 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5457 Previously, this ceilinged at INT_MAX, but that doesn't work on
5458 64-bit machines.
5459 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5460
5461 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5462 (allocate_vectorlike): Check for ptrdiff_t overflow.
5463 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5464 when a (possibly-narrower) signed value would do just as well.
5465 We prefer using signed arithmetic, to avoid comparison confusion.
5466
5467 * alloc.c: Catch some string size overflows that we were missing.
5468 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5469 for convenience in STRING_BYTES_MAX.
5470 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5471 The definition here is exact; the one in lisp.h was approximate.
5472 (allocate_string_data): Check for string overflow. This catches
5473 some instances we weren't catching before. Also, it catches
5474 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5475 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5476 and ptrdiff_t and EMACS_INT are both 64 bits.
5477
5478 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5479 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5480 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5481
5482 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5483
5484 * alloc.c (Fmake_string): Check for out-of-range init.
5485
5486 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5487
5488 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5489
5490 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5491
5492 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5493 xg_get_default_scrollbar_width.
5494
5495 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5496 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5497 (style_changed_cb): Call update_theme_scrollbar_width and call
5498 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5499 all frames (Bug#8505).
5500 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5501 Call gtk_window_set_resizable if HAVE_GTK3.
5502 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5503 and height if HAVE_GTK3 (Bug#8505).
5504 (scroll_bar_width_for_theme): New variable.
5505 (update_theme_scrollbar_width): New function.
5506 (xg_get_default_scrollbar_width): Move code to
5507 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5508 (xg_initialize): Call update_theme_scrollbar_width.
5509
5510 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5511
5512 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5513
5514 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5515
5516 * frame.c (make_frame): Call other_buffer_safely instead of
5517 other_buffer.
5518
5519 * window.c (temp_output_buffer_show): Call display_buffer with
5520 second argument Vtemp_buffer_show_specifiers and reset latter
5521 immediately after the call.
5522 (Vtemp_buffer_show_specifiers): New variable.
5523 (auto_window_vscroll_p, next_screen_context_lines)
5524 (Vscroll_preserve_screen_position): Remove leading asterisks from
5525 doc-strings.
5526
5527 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5528
5529 Fix minor problems found by GCC 4.6.0 static checking.
5530 * buffer.c (Qclone_number): Remove for now, as it's unused.
5531 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5532 (record_buffer): Remove unused local.
5533 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5534 (set_frame_buffer_list): Remove; unused.
5535 * frame.h (other_visible_frames): Remove decl.
5536 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5537 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5538 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5539 if HAVE_GPM.
5540 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5541 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5542 Define only if HAVE_GPM.
5543 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5544 (update_hints_inhibit): Remove; never set. All uses removed.
5545 * widgetprv.h (emacsFrameClassRec): Remove decl.
5546 * window.c (delete_deletable_window): Now returns void, since it
5547 wasn't returning anything.
5548 (compare_window_configurations): Remove unused locals.
5549 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5550 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5551 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5552 the same widths as pointers. This follows up on the 2011-05-06 patch.
5553 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5554 * xterm.h: Likewise.
5555 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5556
5557 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5558
5559 * makefile.w32-in: Update dependencies.
5560 (LISP_H): Add lib/intprops.h.
5561
5562 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5563
5564 * image.c (gif_load): Add animation frame delay to the metadata.
5565 (syms_of_image): Use DEFSYM. New symbol `delay'.
5566
5567 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5568
5569 * window.c (delete_deletable_window): Re-add.
5570 (Fset_window_configuration): Rewrite to handle dead buffers and
5571 consequently deletable windows.
5572 (window_tree, Fwindow_tree): Remove. Supply functionality in
5573 window.el.
5574 (compare_window_configurations): Simplify code.
5575
5576 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5577
5578 * image.c (imagemagick_load_image): Fix type mismatch.
5579 (Fimagemagick_types): Likewise.
5580
5581 * window.h (replace_buffer_in_windows): Declare.
5582
5583 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5584
5585 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5586 Qclone_number. Remove external declaration of Qdelete_window.
5587 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5588 code.
5589 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5590 Run Qbuffer_list_update_hook if allowed.
5591 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5592 buffer list implementation.
5593 (other_buffer_safely): New function.
5594 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5595 calls to replace_buffer_in_windows and
5596 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5597 if allowed.
5598 (record_buffer): Inhibit quitting and rewrite using quittable
5599 functions. Run Qbuffer_list_update_hook if allowed.
5600 (Frecord_buffer, Funrecord_buffer): New functions.
5601 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5602 Move switch-to-buffer to window.el.
5603 (bury-buffer): Move to window.el.
5604 (Vbuffer_list_update_hook): New variable.
5605
5606 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5607 section.
5608
5609 * window.h (resize_frame_windows): Move up in code.
5610 (Fwindow_frame): Remove EXFUN.
5611 (replace_buffer_in_all_windows): Remove prototype.
5612 (replace_buffer_in_windows_safely): Add prototype.
5613
5614 * window.c: Declare Qdelete_window static again. Move down
5615 declaration of select_count.
5616 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5617 (Fother_window): Move to window.el.
5618 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5619 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5620 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5621 window.el.
5622 (replace_buffer_in_windows): Implement by calling
5623 Qreplace_buffer_in_windows.
5624 (replace_buffer_in_all_windows): Remove with some functionality
5625 moved into replace_buffer_in_windows_safely.
5626 (replace_buffer_in_windows_safely): New function.
5627 (select_window_norecord, select_frame_norecord): Move in front
5628 of run_window_configuration_change_hook. Remove now obsolete
5629 declarations.
5630 (Fset_window_buffer): Rewrite doc-string.
5631 Call Qrecord_window_buffer.
5632 (keys_of_window): Move binding for other-window to window.el.
5633
5634 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5635
5636 * dispextern.h (struct image): Replace data member, whose int_val
5637 and ptr_val fields were not used by anything, with a single
5638 lisp_val object.
5639
5640 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5641 (gif_clear_image, gif_load, imagemagick_load_image)
5642 (gs_clear_image, gs_load): Callers changed.
5643
5644 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 * buffer.h: Include <time.h>, for time_t.
5647 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5648
5649 Fix minor problems found by static checking.
5650
5651 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5652
5653 Make identifiers static if they are not used in other modules.
5654 * data.c (Qcompiled_function, Qframe, Qvector):
5655 * image.c (QimageMagick, Qsvg):
5656 * minibuf.c (Qmetadata):
5657 * window.c (resize_window_check, resize_root_window): Now static.
5658 * window.h (resize_window_check, resize_root_window): Remove decls.
5659
5660 * window.c (window_deletion_count, delete_deletable_window):
5661 Remove; unused.
5662 (window_body_lines): Now static.
5663 (Fdelete_other_windows_internal): Mark vars as initialized.
5664 Make sure 'resize_failed' is initialized.
5665 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5666 (resize_window_apply): Remove unused local.
5667 * window.h (delete_deletable_window): Remove decl.
5668
5669 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5670 (imagemagick_load_image): Fix pointer signedness problem by changing
5671 last arg from unsigned char * to char *. All uses changed.
5672 Also, fix a local for similar reasons.
5673 Remove unused locals. Remove locals to avoid shadowing.
5674 (fn_rsvg_handle_free): Remove; unused.
5675 (svg_load, svg_load_image): Fix pointer signedness problem.
5676 (imagemagick_load_image): Don't use garbage pointer image_wand.
5677
5678 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5679
5680 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5681
5682 * image.c (gif_load): Fix omitted cast error introduced by
5683 2011-06-06 change.
5684
5685 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5686
5687 * window.h (resize_proportionally, orig_total_lines)
5688 (orig_top_line): Remove from window structure.
5689 (set_window_height, set_window_width, change_window_heights)
5690 (Fdelete_window): Remove prototypes.
5691 (resize_frame_windows): Remove duplicate declaration.
5692
5693 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5694
5695 * window.h (resize_frame_windows, resize_window_check)
5696 (delete_deletable_window, resize_root_window)
5697 (resize_frame_windows): Declare prototypes.
5698
5699 * window.c (resize_window_apply): Make definition be "static" to
5700 match the prototype.
5701
5702 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5703
5704 * window.c: Remove declarations of Qwindow_size_fixed,
5705 window_min_size_1, window_min_size_2, window_min_size,
5706 size_window, window_fixed_size_p, enlarge_window, delete_window.
5707 Remove static from declaration of Qdelete_window, it's
5708 temporarily needed by Fbury_buffer.
5709 (replace_window): Don't assign orig_top_line and
5710 orig_total_lines.
5711 (Fdelete_window, delete_window): Remove. Window deletion is
5712 handled by window.el.
5713 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5714 Replace Fdelete_window calls with calls to Qdelete_window.
5715 (Fdelete_other_windows): Remove. Deleting other windows is
5716 handled by window.el.
5717 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5718 handled in window.el.
5719 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5720 Window minimum sizes are handled in window.el.
5721 (shrink_windows, size_window, set_window_height)
5722 (set_window_width, change_window_heights, window_height)
5723 (window_width, CURBEG, CURSIZE, enlarge_window)
5724 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5725 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5726 handled in window.el.
5727 (make_dummy_parent): Rename to make_parent_window and give it a
5728 second argument horflag.
5729 (make_window): Don't set resize_proportionally any more.
5730 (Fsplit_window): Remove. Windows are split in window.el.
5731 (save_restore_action, save_restore_orig_size)
5732 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5733 Resize mini windows in window.el.
5734 (grow_mini_window, shrink_mini_window): Implement by calling
5735 Qresize_root_window_vertically, resize_window_check and
5736 resize_window_apply.
5737 (saved_window, Fset_window_configuration, save_window_save):
5738 Do not handle orig_top_line, orig_total_lines, and
5739 resize_proportionally.
5740 (window_min_height, window_min_width): Move to window.el.
5741 (keys_of_window): Move bindings for delete-other-windows,
5742 split-window, delete-window and enlarge-window to window.el.
5743
5744 * buffer.c: Temporarily extern Qdelete_window.
5745 (Fbury_buffer): Temporarily call Qdelete_window instead of
5746 Fdelete_window (Fbury_buffer will move to window.el soon).
5747
5748 * frame.c (set_menu_bar_lines_1): Remove code handling
5749 orig_top_line and orig_total_lines.
5750
5751 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5752 set_window_height but set heights directly.
5753 (change_frame_size_1): Use resize_frame_windows.
5754
5755 * xdisp.c (init_xdisp): Don't use set_window_height but set
5756 heights directly.
5757
5758 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5759 Use resize_frame_windows instead of change_window_heights and run
5760 run_window_configuration_change_hook.
5761
5762 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5763 instead of change_window_heights and run
5764 run_window_configuration_change_hook.
5765
5766 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5767
5768 * window.c (replace_window): Rename second argument REPLACEMENT to
5769 NEW. New third argument SETFLAG. Rewrite.
5770 (delete_window, make_dummy_parent): Call replace_window with
5771 third argument 1.
5772 (window_list_1): Move down in code.
5773 (run_window_configuration_change_hook): Move set_buffer part
5774 before select_frame_norecord part in order to unwind correctly.
5775 Rename count1 to count.
5776 (recombine_windows, delete_deletable_window, resize_root_window)
5777 (Fdelete_other_windows_internal)
5778 (Frun_window_configuration_change_hook, make_parent_window)
5779 (resize_window_check, resize_window_apply, Fresize_window_apply)
5780 (resize_frame_windows, Fsplit_window_internal)
5781 (Fdelete_window_internal, Fresize_mini_window_internal):
5782 New functions.
5783 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5784
5785 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5786
5787 * window.h (window): Add some new members to window structure -
5788 normal_lines, normal_cols, new_total, new_normal, clone_number,
5789 splits, nest, prev_buffers, next_buffers.
5790 (WINDOW_TOTAL_SIZE): Move here from window.c.
5791 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5792
5793 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5794 Remove.
5795 (make_dummy_parent): Set new members of windows structure.
5796 (make_window): Move down in code. Handle new members of window
5797 structure.
5798 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5799 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5800 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5801 (Fset_window_prev_buffers, Fwindow_next_buffers)
5802 (Fset_window_next_buffers, Fset_window_clone_number):
5803 New functions.
5804 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5805 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5806 Doc-string fixes.
5807 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5808 Argument WINDOW can be now internal window too.
5809 (Fwindow_use_time): Move up in code.
5810 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5811 Rewrite doc-string.
5812 (Fset_window_configuration, saved_window)
5813 (Fcurrent_window_configuration, save_window_save): Handle new
5814 members of window structure.
5815 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5816 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5817 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5818 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5819 Qget_mru_window, Qresize_root_window,
5820 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5821 Qauto_buffer_name; staticpro them.
5822
5823 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5824
5825 * window.c (Fwindow_total_size, Fwindow_left_column)
5826 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5827 (Fwindow_list_1): New functions.
5828 (window_box_text_cols): Replace with window_body_cols.
5829 (Fwindow_width, Fscroll_left, Fscroll_right):
5830 Use window_body_cols instead of window_box_text_cols.
5831 (delete_window, Fset_window_configuration):
5832 Call delete_all_subwindows with window as argument.
5833 (delete_all_subwindows): Take a window as argument and not a
5834 structure. Rewrite.
5835 (window_loop): Remove handling of GET_LRU_WINDOW and
5836 GET_LARGEST_WINDOW.
5837 (Fget_lru_window, Fget_largest_window): Move to window.el.
5838
5839 * window.h: Extern window_body_cols instead of
5840 window_box_text_cols. delete_all_subwindows now takes a
5841 Lisp_Object as argument.
5842
5843 * indent.c (compute_motion, Fcompute_motion):
5844 Use window_body_cols instead of window_box_text_cols.
5845
5846 * frame.c (delete_frame): Call delete_all_subwindows with root
5847 window as argument.
5848
5849 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5850
5851 * fns.c (Fputhash): Document return value.
5852
5853 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5854
5855 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5856
5857 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5858
5859 Cons<->int and similar integer overflow fixes (Bug#8794).
5860
5861 Check for overflow when converting integer to cons and back.
5862 * charset.c (Fdefine_charset_internal, Fdecode_char):
5863 Use cons_to_unsigned to catch overflow.
5864 (Fencode_char): Use INTEGER_TO_CONS.
5865 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5866 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5867 * data.c (long_to_cons, cons_to_long): Remove.
5868 (cons_to_unsigned, cons_to_signed): New functions.
5869 These signal an error for invalid or out-of-range values.
5870 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5871 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5872 * font.c (Ffont_variation_glyphs):
5873 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5874 * lisp.h: Include <intprops.h>.
5875 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5876 (cons_to_signed, cons_to_unsigned): New decls.
5877 (long_to_cons, cons_to_long): Remove decls.
5878 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5879 (Fprimitive_undo): Use CONS_TO_INTEGER.
5880 * xfns.c (Fx_window_property): Likewise.
5881 * xselect.c: Include <limits.h>.
5882 (x_own_selection, selection_data_to_lisp_data):
5883 Use INTEGER_TO_CONS.
5884 (x_handle_selection_request, x_handle_selection_clear)
5885 (x_get_foreign_selection, Fx_disown_selection_internal)
5886 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5887 (lisp_data_to_selection_data): Use cons_to_unsigned.
5888 (x_fill_property_data): Use cons_to_signed.
5889 Report values out of range.
5890
5891 Check for buffer and string overflow more precisely.
5892 * buffer.h (BUF_BYTES_MAX): New macro.
5893 * lisp.h (STRING_BYTES_MAX): New macro.
5894 * alloc.c (Fmake_string):
5895 * character.c (string_escape_byte8):
5896 * coding.c (coding_alloc_by_realloc):
5897 * doprnt.c (doprnt):
5898 * editfns.c (Fformat):
5899 * eval.c (verror):
5900 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5901 since they may not be the same number.
5902 * editfns.c (Finsert_char):
5903 * fileio.c (Finsert_file_contents):
5904 Likewise for BUF_BYTES_MAX.
5905
5906 * image.c: Use ptrdiff_t, not int, for sizes.
5907 (slurp_file): Switch from int to ptrdiff_t.
5908 All uses changed.
5909 (slurp_file): Check that file size fits in both size_t (for
5910 malloc) and ptrdiff_t (for sanity and safety).
5911
5912 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5913 if b->modtime has its maximal value.
5914
5915 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5916
5917 Don't assume time_t can fit into int.
5918 * buffer.h (struct buffer.modtime): Now time_t, not int.
5919 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5920 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5921
5922 Minor fixes for signed vs unsigned integers.
5923 * character.h (MAYBE_UNIFY_CHAR):
5924 * charset.c (maybe_unify_char):
5925 * keyboard.c (read_char, reorder_modifiers):
5926 XINT -> XFASTINT, since the integer must be nonnegative.
5927 * ftfont.c (ftfont_spec_pattern):
5928 * keymap.c (access_keymap, silly_event_symbol_error):
5929 XUINT -> XFASTINT, since the integer must be nonnegative.
5930 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5931 since it makes no difference and we prefer signed.
5932 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5933 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5934 nonnegative.
5935
5936 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5937
5938 * window.h (Fwindow_frame): Declare.
5939
5940 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5941
5942 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5943 (SPARE_MEMORY): Always define.
5944 (LARGE_REQUEST): Remove.
5945 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5946
5947 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5948
5949 * lisp.h: Move EXFUNS for Fframe_root_window,
5950 Fframe_first_window and Fset_frame_selected_window to window.h.
5951
5952 * window.h: Move EXFUNS for Fframe_root_window,
5953 Fframe_first_window and Fset_frame_selected_window here from
5954 lisp.h.
5955
5956 * frame.c (Fwindow_frame, Fframe_first_window)
5957 (Fframe_root_window, Fframe_selected_window)
5958 (Fset_frame_selected_window): Move to window.c.
5959 (Factive_minibuffer_window): Move to minibuf.c.
5960 (Fother_visible_frames_p): New function.
5961
5962 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5963
5964 * window.c (decode_window, decode_any_window): Move up in code.
5965 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5966 (inhibit_frame_unsplittable): Remove unused variable.
5967 (Fwindow_buffer): Move up and rewrite doc-string.
5968 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5969 (Fwindow_prev): New functions.
5970 (Fwindow_frame): Move here from frame.c. Accept any window as
5971 argument.
5972 (Fframe_root_window, Fframe_first_window)
5973 (Fframe_selected_window): Move here from frame.c. Accept frame
5974 or arbitrary window as argument. Update doc-strings.
5975 (Fminibuffer_window): Move up in code.
5976 (Fwindow_minibuffer_p): Move up in code and simplify.
5977 (Fset_frame_selected_window): Move here from frame.c.
5978 Marginal rewrite.
5979 (Fselected_window, select_window, Fselect_window): Move up in
5980 code. Minor doc-string fixes.
5981
5982 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5983
5984 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5985 Do not assume that spare memory exists; that assumption is valid
5986 only if SYSTEM_MALLOC.
5987 (LARGE_REQUEST): New macro, so that the issue of large requests
5988 is separated from the issue of spare memory.
5989
5990 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5991
5992 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5993 format. (Bug#8806)
5994
5995 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5996
5997 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5998 before statements.
5999
6000 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6001
6002 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6003
6004 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6005
6006 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6007 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6008
6009 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6010
6011 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6012
6013 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6014
6015 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6016 (x_clipboard_manager_save): Add return value.
6017 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6018 New error handlers.
6019 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6020 Obey Vx_select_enable_clipboard_manager. Catch errors in
6021 x_clipboard_manager_save (Bug#8779).
6022 (Vx_select_enable_clipboard_manager): New variable.
6023 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6024
6025 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6026
6027 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6028
6029 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6030
6031 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6032 in the current matrix if keep_current_p is non-zero.
6033
6034 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6035
6036 * bidi.c (bidi_level_of_next_char): Fix last change.
6037
6038 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6039
6040 Support bidi reordering of text covered by display properties.
6041
6042 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6043 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6044 (bidi_cache_search, bidi_cache_iterator_state)
6045 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6046 (bidi_level_of_next_char, bidi_move_to_visually_next):
6047 Support character positions inside a run of characters covered by a
6048 display string.
6049 (bidi_paragraph_init, bidi_resolve_explicit_1)
6050 (bidi_level_of_next_char): Call bidi_fetch_char and
6051 bidi_fetch_char_advance instead of FETCH_CHAR and
6052 FETCH_CHAR_ADVANCE.
6053 (bidi_init_it): Initialize new members.
6054 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6055 definitions.
6056 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6057 instead of using explicit *_CHAR codes.
6058 (bidi_resolve_explicit, bidi_resolve_weak):
6059 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6060 bidirectional text is supported only in multibyte buffers.
6061 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6062 it to initialize the frame_window_p member of struct bidi_it.
6063 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6064 (bidi_resolve_explicit, bidi_resolve_weak)
6065 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6066 bidi_it->nchars is non-positive.
6067 (bidi_level_of_next_char): Don't try to lookup the cache for the
6068 next/previous character if nothing is cached there yet, or if we
6069 were just reseat()'ed to a new position.
6070
6071 * xdisp.c (set_cursor_from_row): Set start and stop points
6072 according to the row's direction when priming the loop that looks
6073 for the glyph on which to display cursor.
6074 (single_display_spec_intangible_p): Function deleted.
6075 (display_prop_intangible_p): Reimplement to call
6076 handle_display_spec instead of single_display_spec_intangible_p.
6077 Accept 3 additional arguments needed by handle_display_spec.
6078 This fixes incorrect cursor motion across display property with complex
6079 values: lists, `(when COND...)' forms, etc.
6080 (single_display_spec_string_p): Support property values that are
6081 lists with the argument STRING its top-level element.
6082 (display_prop_string_p): Fix the condition for processing a
6083 property that is a list to be consistent with handle_display_spec.
6084 (handle_display_spec): New function, refactored from the
6085 last portion of handle_display_prop.
6086 (compute_display_string_pos): Accept additional argument
6087 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6088 value of a `display' property is a "replacing spec".
6089 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6090 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6091 the display property, but just return a value indicating whether
6092 the display property will replace the characters it covers.
6093 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6094 frame_window_p members of struct bidi_it.
6095 (compute_display_string_pos, compute_display_string_end):
6096 New functions.
6097 (push_it): Accept second argument POSITION, where pop_it should
6098 jump to continue iteration.
6099 (reseat_1): Initialize bidi_it.disp_pos.
6100
6101 * keyboard.c (adjust_point_for_property): Adjust the call to
6102 display_prop_intangible_p to its new signature.
6103
6104 * dispextern.h (struct bidi_it): New member frame_window_p.
6105 (bidi_init_it): Update prototypes.
6106 (display_prop_intangible_p): Update prototype.
6107 (compute_display_string_pos, compute_display_string_end):
6108 Declare prototypes.
6109 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6110 EMACS_INT.
6111
6112 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 Malloc failure behavior now depends on size of allocation.
6115 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6116 * lisp.h: Change signatures accordingly.
6117 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6118 All callers changed. (Bug#8762)
6119
6120 * gnutls.c: Use Emacs's memory allocators.
6121 Without this change, the gnutls library would invoke malloc etc.
6122 directly, which causes problems on non-SYNC_INPUT hosts, and which
6123 runs afoul of improving memory_full behavior. (Bug#8761)
6124 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6125 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6126 xfree instead of the default malloc, realloc, free.
6127 (Fgnutls_boot): No need to check for memory allocation failure,
6128 since xmalloc does that for us.
6129
6130 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6131 * category.c (hash_get_category_set):
6132 * ccl.c (ccl_driver):
6133 * charset.c (Fdefine_charset_internal):
6134 * charset.h (struct charset.hash_index):
6135 * composite.c (get_composition_id, gstring_lookup_cache)
6136 (composition_gstring_put_cache):
6137 * composite.h (struct composition.hash_index):
6138 * dispextern.h (struct image.hash):
6139 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6140 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6141 (hashfn_equal, hashfn_user_defined, make_hash_table)
6142 (maybe_resize_hash_table, hash_lookup, hash_put)
6143 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6144 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6145 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6146 * image.c (make_image, search_image_cache, lookup_image)
6147 (xpm_put_color_table_h):
6148 * lisp.h (struct Lisp_Hash_Table):
6149 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6150 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6151 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6152 * alloc.c (allocate_vectorlike):
6153 Check for overflow in vector size calculations.
6154 * ccl.c (ccl_driver):
6155 Check for overflow when converting EMACS_INT to int.
6156 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6157 need to be updated by these changes.
6158 * fns.c (make_hash_table, maybe_resize_hash_table):
6159 Check for integer overflow with large hash tables.
6160 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6161 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6162 (SXHASH_REDUCE): New macro.
6163 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6164 Use it instead of discarding useful hash info with large hash values.
6165 (sxhash_float): New function.
6166 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6167 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6168 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6169 Rewrite to use FIXNUM_BITS, as this simplifies things.
6170 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6171 Adjust signatures to match updated version of code.
6172 (consing_since_gc): Now EMACS_INT, since a single hash table can
6173 use more than INT_MAX bytes.
6174
6175 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6176
6177 Make it possible to build with GCC-4.6+ -O2 -flto.
6178
6179 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6180
6181 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6182
6183 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6184 Call minibuffer-inactive-mode.
6185
6186 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6187
6188 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6189 Update dependencies.
6190
6191 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6192
6193 * data.c (init_data): Remove code for UTS, this system is not
6194 supported anymore.
6195
6196 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6197
6198 Don't force ./temacs to start in terminal mode.
6199
6200 * frame.c (make_initial_frame): Initialize faces in all cases, not
6201 only when CANNOT_DUMP is defined.
6202 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6203
6204 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6205
6206 * dispnew.c (add_window_display_history): Use const for the string
6207 pointer. Remove declaration, not needed.
6208
6209 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6210
6211 Use 'inline', not 'INLINE'.
6212 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6213 * alloc.c, fontset.c (INLINE): Remove.
6214 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6215 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6216 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6217 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6218 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6219
6220 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6221
6222 Make it possible to run ./temacs.
6223
6224 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6225 syms_of_callproc does the same thing. Remove test for
6226 "initialized", do it in the caller.
6227 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6228
6229 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6230
6231 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6232 (read_minibuf): Use get_minibuffer.
6233 (syms_of_minibuf): Use DEFSYM.
6234 (Qmetadata): New var.
6235 * data.c (Qbuffer): Don't make it static.
6236 (syms_of_data): Use DEFSYM.
6237
6238 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6239
6240 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6241 (CCL_CODE_MIN): New macro.
6242
6243 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6244
6245 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6246
6247 * eval.c (Qdebug): Now static.
6248 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6249 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6250 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6251
6252 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6253
6254 * image.c: Various fixes to ImageMagick code comments.
6255 (Fimagemagick_types): Doc fix.
6256
6257 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6258
6259 Minor fixes prompted by GCC 4.6.0 warnings.
6260
6261 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6262
6263 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6264 (x_clipboard_manager_save_all): Move extern decl to ...
6265 * xterm.h: ... here, so that it can be checked for consistency.
6266
6267 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6268
6269 * xselect.c (x_clipboard_manager_save_frame)
6270 (x_clipboard_manager_save_all): New functions.
6271 (Fx_clipboard_manager_save): Lisp function deleted.
6272
6273 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6274 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6275
6276 * xterm.h: Update prototype.
6277
6278 2011-05-28 William Xu <william.xwl@gmail.com>
6279
6280 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6281 exiting (Bug#8239).
6282
6283 2011-05-28 Jim Meyering <meyering@redhat.com>
6284
6285 Avoid a sign-extension bug in crypto_hash_function.
6286 * fns.c (to_uchar): Define.
6287 (crypto_hash_function): Use it to convert some newly-signed
6288 variables to unsigned, to avoid sign-extension bugs. For example,
6289 without this change, (md5 "truc") would evaluate to
6290 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6291 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6292 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6293
6294 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6295
6296 Integer overflow fixes.
6297
6298 * dbusbind.c: Serial number integer overflow fixes.
6299 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6300 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6301 to hold a serial number that is too large for a fixnum.
6302 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6303 Check for serial numbers out of range. Decode any serial number
6304 that was so large that it became a float. (Bug#8722)
6305
6306 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6307 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6308 Use XFASTINT rather than XUINT when numbers are nonnegative.
6309 (xd_append_arg, Fdbus_method_return_internal):
6310 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6311 arguments, check that Lisp number is nonnegative, rather than
6312 silently wrapping negative numbers around. (Bug#8722)
6313 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6314 (Bug#8722)
6315
6316 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6317
6318 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6319
6320 ccl: Add integer overflow checks.
6321 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6322 (IN_INT_RANGE): New macros.
6323 (ccl_driver): Use them to check for integer overflow when
6324 decoding a CCL program. Many of the new checks are whether XINT (x)
6325 fits in int; it doesn't always, on 64-bit hosts. The new version
6326 doesn't catch all possible integer overflows, but it's an
6327 improvement. (Bug#8719)
6328
6329 * alloc.c (make_event_array): Use XINT, not XUINT.
6330 There's no need for unsigned here.
6331
6332 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6333 This follows up to the 2011-05-06 change that substituted uintptr_t
6334 for EMACS_INT. This case wasn't caught back then.
6335
6336 Rework Fformat to avoid integer overflow issues.
6337 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6338 now (part of C89). Include <verify.h>.
6339 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6340 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6341 (Fformat): Avoid the prepass trying to compute sizes; it was only
6342 approximate and thus did not catch overflow reliably. Instead, walk
6343 through the format just once, formatting and computing sizes as we go,
6344 checking for integer overflow at every step, and allocating a larger
6345 buffer as needed. Keep track separately whether the format is
6346 multibyte. Keep only the most-recently calculated precision, rather
6347 than them all. Record whether each argument has been converted to
6348 string. Use EMACS_INT, not int, for byte and char and arg counts.
6349 Support field widths and precisions larger than INT_MAX. Avoid
6350 sprintf's undefined behavior with conversion specifications such as %#d
6351 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6352 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6353 formatting out-of-range floating point numbers with int
6354 formats. (Bug#8668)
6355
6356 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6357
6358 * data.c: Avoid integer truncation in expressions involving floats.
6359 * data.c: Include <intprops.h>.
6360 (arith_driver): When there's an integer overflow in an expression
6361 involving floating point, convert the integers to floating point
6362 so that the resulting value does not suffer from catastrophic
6363 integer truncation. For example, on a 64-bit host (* 4
6364 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6365 Do not rely on undefined behavior after integer overflow.
6366
6367 merge count_size_as_multibyte, parse_str_to_multibyte
6368 * character.c, character.h (count_size_as_multibyte):
6369 Rename from parse_str_to_multibyte; all uses changed.
6370 Check for integer overflow.
6371 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6372 since it's now a duplicate of the other. This is more of
6373 a character than a buffer op, so better that it's in character.c.
6374 * fns.c, print.c: Adjust to above changes.
6375
6376 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6377
6378 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6379
6380 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6381
6382 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6383 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6384 (x_clipboard_manager_save): Now static.
6385 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6386
6387 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6388 (crypto_hash_function): Now static.
6389 Fix pointer signedness problems. Avoid unnecessary initializations.
6390
6391 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6392
6393 * termhooks.h (Vselection_alist): Make it terminal-local.
6394
6395 * terminal.c (create_terminal): Initialize it.
6396
6397 * xselect.c: Support for clipboard managers.
6398 (Vselection_alist): Move to termhooks.h as terminal-local var.
6399 (LOCAL_SELECTION): New macro.
6400 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6401 (symbol_to_x_atom): Remove gratuitous arg.
6402 (x_handle_selection_request, lisp_data_to_selection_data)
6403 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6404 (x_own_selection, x_get_local_selection, x_convert_selection):
6405 New arg, specifying work frame. Use terminal-local Vselection_alist.
6406 (some_frame_on_display): Delete unused function.
6407 (Fx_own_selection_internal, Fx_get_selection_internal)
6408 (Fx_disown_selection_internal, Fx_selection_owner_p)
6409 (Fx_selection_exists_p): New optional frame arg.
6410 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6411 (x_handle_selection_clear): Don't treat other terminals with the
6412 same keyboard specially. Use the terminal-local Vselection_alist.
6413 (x_clear_frame_selections): Use Frun_hook_with_args.
6414
6415 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6416
6417 * xterm.h: Add support for those atoms.
6418
6419 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6420
6421 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6422 (converted_selections, conversion_fail_tag): New global variables.
6423 (x_selection_request_lisp_error): Free the above.
6424 (x_get_local_selection): Remove unnecessary code.
6425 (x_reply_selection_request): Args changed; handle arbitrary array
6426 of converted selections stored in converted_selections.
6427 Separate the XChangeProperty and SelectionNotify steps.
6428 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6429 (x_convert_selection): New function.
6430 (x_handle_selection_event): Simplify.
6431 (x_get_foreign_selection): Don't ignore incoming requests while
6432 waiting for an answer; this will fail when we implement
6433 SAVE_TARGETS, and seems unnecessary anyway.
6434 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6435 (Vx_sent_selection_functions): Doc fix.
6436
6437 2011-05-26 Leo Liu <sdl.web@gmail.com>
6438
6439 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6440
6441 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6442
6443 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6444
6445 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6446 for fringe update if it has periodic bitmap.
6447 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6448 and fringe_bitmap_periodic_p.
6449
6450 * fringe.c (get_fringe_bitmap_data): New function.
6451 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6452 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6453 row. Mark glyph row for fringe update if periodicity changed.
6454
6455 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6456 for fringe update unless it has periodic bitmap.
6457
6458 2011-05-25 Kenichi Handa <handa@m17n.org>
6459
6460 * xdisp.c (get_next_display_element): Set correct it->face_id for
6461 a static composition.
6462
6463 2011-05-24 Leo Liu <sdl.web@gmail.com>
6464
6465 * deps.mk (fns.o):
6466 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6467
6468 * fns.c (crypto_hash_function, Fsha1): New function.
6469 (Fmd5): Use crypto_hash_function.
6470 (syms_of_fns): Add Ssha1.
6471
6472 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6473
6474 * gnutls.c: Remove unused macros.
6475 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6476 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6477 Remove macros that are defined and never used.
6478 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6479
6480 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6481
6482 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6483 (Fx_get_selection_internal): Minor cleanup.
6484 (Fx_own_selection_internal): Rename arguments for consistency with
6485 select.el.
6486
6487 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6488
6489 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6490
6491 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6492
6493 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6494
6495 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6496
6497 * dispnew.c (scrolling_window): Don't exclude the case that the
6498 last enabled row in the desired matrix touches the bottom boundary.
6499
6500 2011-05-21 Glenn Morris <rgm@gnu.org>
6501
6502 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6503 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6504 and add some more files.
6505
6506 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6507
6508 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6509 report_file_error introduced by the change from 2011-05-07.
6510
6511 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6512
6513 * systime.h (Time): Define only if emacs is defined.
6514 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6515 where the include path doesn't have X11/X.h by default. See
6516 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6517
6518 2011-05-20 Kenichi Handa <handa@m17n.org>
6519
6520 * composite.c (find_automatic_composition): Fix previous change.
6521
6522 2011-05-20 Glenn Morris <rgm@gnu.org>
6523
6524 * lisp.mk: New file, split from Makefile.in.
6525 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6526 (shortlisp): Remove.
6527 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6528
6529 2011-05-19 Glenn Morris <rgm@gnu.org>
6530
6531 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6532 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6533 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6534 (lisp): Set the order to that of loadup.el.
6535 (shortlisp): Make it a copy of $lisp.
6536 (SOME_MACHINE_LISP): Remove.
6537 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6538 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6539
6540 2011-05-18 Kenichi Handa <handa@m17n.org>
6541
6542 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6543 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6544 (find_automatic_composition): Mostly rewrite for efficiency.
6545
6546 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6547
6548 * makefile.w32-in: Update dependencies.
6549
6550 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6551
6552 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6553 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6554
6555 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6556
6557 Fix some integer overflow issues, such as string length overflow.
6558
6559 * insdel.c (count_size_as_multibyte): Check for string overflow.
6560
6561 * character.c (lisp_string_width): Check for string overflow.
6562 Use EMACS_INT, not int, for string indexes and lengths; in
6563 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6564 the resulting string length overflows an EMACS_INT; instead,
6565 report a string overflow if no precision given. When checking for
6566 precision exhaustion, use a check that cannot possibly have
6567 integer overflow. (Bug#8675)
6568 * character.h (lisp_string_width): Adjust to new signature.
6569
6570 * alloc.c (string_overflow): New function.
6571 (Fmake_string): Use it. This doesn't change behavior, but saves
6572 a few bytes and will simplify future changes.
6573 * character.c (string_escape_byte8): Likewise.
6574 * lisp.h (string_overflow): New decl.
6575
6576 Fixups, following up to the user-interface timestamp change.
6577 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6578 for UI timestamps, instead of unsigned long.
6579 * msdos.c (mouse_get_pos): Likewise.
6580 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6581 * w32gui.h (Time): Define by including "systime.h" rather than by
6582 declaring it ourselves. (Bug#8664)
6583
6584 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6585 * image.c (clear_image_cache): Likewise.
6586
6587 * term.c (term_mouse_position): Don't assume time_t wraparound.
6588
6589 Be more systematic about user-interface timestamps.
6590 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6591 and sometimes 'EMACS_UINT', to represent these timestamps.
6592 This change causes it to use 'Time' uniformly, as that's what X uses.
6593 This makes the code easier to follow, and makes it easier to catch
6594 integer overflow bugs such as Bug#8664.
6595 * frame.c (Fmouse_position, Fmouse_pixel_position):
6596 Use Time, not unsigned long, for user-interface timestamps.
6597 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6598 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6599 * keyboard.h (last_event_timestamp): Likewise.
6600 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6601 * menu.h (xmenu_show): Likewise.
6602 * term.c (term_mouse_position): Likewise.
6603 * termhooks.h (struct input_event.timestamp): Likewise.
6604 (struct terminal.mouse_position_hook): Likewise.
6605 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6606 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6607 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6608 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6609 what it was before.
6610 * menu.h, termhooks.h: Include "systime.h", for Time.
6611
6612 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6613 Don't assume that the difference between two unsigned long values
6614 can fit into an integer. At this point, we know button_down_time
6615 <= event->timestamp, so the difference must be nonnegative, so
6616 there's no need to cast the result if double-click-time is
6617 nonnegative, as it should be; check that it's nonnegative, just in
6618 case. This bug is triggered when events are more than 2**31 ms
6619 apart (about 25 days). (Bug#8664)
6620
6621 * xselect.c (last_event_timestamp): Remove duplicate decl.
6622 (x_own_selection): Remove needless cast to unsigned long.
6623
6624 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6625 that always fit in int. Use a sentinel instead of a counter, to
6626 avoid a temp and to allay GCC's concerns about possible int overflow.
6627 * frame.h (struct frame): Use int for menu_bar_items_used
6628 instead of EMACS_INT, since it always fits in int.
6629
6630 * menu.c (grow_menu_items): Check for int overflow.
6631
6632 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6633
6634 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6635 Before, the code was not consistent. These values cannot exceed
6636 2**31 - 1 so there's no need to make them unsigned.
6637 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6638 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6639 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6640 as modifiers.
6641 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6642
6643 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6644 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6645 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6646 presumably because the widths might not match.
6647
6648 * window.c (size_window): Avoid needless test at loop start.
6649
6650 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6651
6652 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6653
6654 2011-05-12 Drew Adams <drew.adams@oracle.com>
6655
6656 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6657
6658 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6659
6660 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6661 `width' to `bar_area_x' and `bar_area_width', respectively.
6662 (x_scroll_run): Take account of fringe background extension.
6663
6664 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6665 Rename local vars `left' and `width' to `bar_area_x' and
6666 `bar_area_width', respectively.
6667 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6668 background extension.
6669
6670 2011-05-10 Jim Meyering <meyering@redhat.com>
6671
6672 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6673
6674 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6675
6676 * image.c (Finit_image_library): Return t for built-in image types,
6677 like pbm and xbm. (Bug#8640)
6678
6679 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6680
6681 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6682
6683 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6684
6685 * w32console.c (Fset_screen_color): Doc fix.
6686 (Fget_screen_color): New function.
6687 (syms_of_ntterm): Defsubr it.
6688
6689 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6690 unlink the temporary file if Fcall_process didn't create it in the
6691 first place.
6692 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6693 child process will be redirected to a file specified with `:file'.
6694 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6695 cue to call_process_cleanup not to close that handle.
6696
6697 2011-05-07 Ben Key <bkey76@gmail.com>
6698
6699 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6700 one of two shell specific rules, either bootstrap-temacs-CMD or
6701 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6702 to the previous implementation of the bootstrap-temacs rule.
6703 The bootstrap-temacs-CMD rule is similar to the previous
6704 implementation of the bootstrap-temacs rule except that it
6705 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6706 variable.
6707
6708 These changes, along with some changes to nt/configure.bat,
6709 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6710 earlier fix to add support for --cflags and --ldflags options
6711 that include quotes so that it works whether make uses cmd or
6712 sh as the shell.
6713
6714 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6715
6716 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6717 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6718 is a constant.
6719 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6720 a string. Handle both cases.
6721 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6722 (Fdbus_register_method): Use Qinvalid_function.
6723
6724 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6725
6726 * makefile.w32-in: Update dependencies.
6727 (LISP_H): Add inttypes.h and stdin.h.
6728 (PROCESS_H): Add unistd.h.
6729
6730 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6731
6732 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6733 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6734
6735 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6736
6737 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6738
6739 * term.c (vfatal): Remove stray call to va_end.
6740 It's not needed and the C Standard doesn't allow it here anyway.
6741
6742 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6743 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6744
6745 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6746 bytes.
6747
6748 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6749
6750 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6751
6752 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6753
6754 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6755
6756 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6757
6758 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6759 * charset.c (Fdefine_charset_internal): Don't initialize
6760 charset.code_space[15]. The value was garbage, on hosts with
6761 32-bit int (Bug#8600).
6762
6763 * lread.c (read_integer): Be more consistent with string-to-number.
6764 Use string_to_number to do the actual conversion; this avoids
6765 rounding errors and fixes some other screwups. Without this fix,
6766 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6767 (digit_to_number): Move earlier, for benefit of read_integer.
6768 Return -1 if the digit is out of range for the base, -2 if it is
6769 not a digit in any supported base. (Bug#8602)
6770
6771 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6772
6773 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6774 to match comment at start of function. This also removes a
6775 GCC warning about overflow in a 32+64-bit port.
6776
6777 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6778
6779 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6780 Reported by Stefan Monnier in
6781 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6782 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6783 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6784
6785 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6786 (EMACS_UINTPTR): Likewise, with uintptr_t.
6787
6788 * lisp.h: Prefer 64-bit EMACS_INT if available.
6789 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6790 on 32-bit hosts that have 64-bit int, so that they can access
6791 large files.
6792 However, temporarily disable this change unless the temporary
6793 symbol WIDE_EMACS_INT is defined.
6794
6795 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6796
6797 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6798 This removes an assumption that EMACS_INT and long are the same
6799 width as pointers. The assumption is true for Emacs porting targets
6800 now, but we want to make other targets possible.
6801 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6802 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6803 In the rest of the code, change types of integers that hold casted
6804 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6805 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6806 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6807 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6808 No need to cast type when ORing.
6809 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6810 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6811 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6812 assume EMACS_INT is the same width as char *.
6813 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6814 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6815 Remove no-longer-needed casts.
6816 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6817 (xg_tool_bar_help_callback, xg_make_tool_item):
6818 Use EMACS_INTPTR to hold an integer
6819 that will be cast to void *; this can avoid a GCC warning
6820 if EMACS_INT is not the same width as void *.
6821 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6822 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6823 (current_message_1, set_message_1):
6824 Use a local to convert to proper width without a cast.
6825 * xmenu.c (dialog_selection_callback): Likewise.
6826
6827 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6828 Also, don't assume VALBITS / RAND_BITS is less than 5,
6829 and don't rely on undefined behavior when shifting a 1 left into
6830 the sign bit.
6831 * lisp.h (get_random): Change signature to match.
6832
6833 * lread.c (hash_string): Use size_t, not int, for hash computation.
6834 Normally we prefer signed values; but hashing is special, because
6835 it's better to use unsigned division on hash table sizes so that
6836 the remainder is nonnegative. Also, size_t is the natural width
6837 for hashing into memory. The previous code used 'int', which doesn't
6838 retain enough info to hash well into very large tables.
6839 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6840
6841 * dbusbind.c: Don't possibly lose pointer info when converting.
6842 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6843 Use XPNTR rather than XHASH, so that the high-order bits of
6844 the pointer aren't lost when converting through void *.
6845
6846 * eval.c (Fautoload): Don't double-shift a pointer.
6847
6848 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6849
6850 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6851
6852 * gnutls.c (DEF_GNUTLS_FN):
6853 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6854
6855 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6856
6857 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6858 marker. (Bug#8610)
6859
6860 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6861
6862 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6863 New version that can reserve upto 2GB of heap space.
6864
6865 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6866
6867 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6868
6869 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6870
6871 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6872 `gnutls_certificate_set_x509_key_file'.
6873
6874 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6875
6876 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6877 Update dependencies.
6878
6879 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6880
6881 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6882 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6883 Remove unused parameter `fildes'.
6884 * process.c (read_process_output, send_process): Don't pass it.
6885
6886 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6887
6888 Fix previous change: the library cache is defined in w32.c.
6889 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6890 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6891
6892 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6893
6894 Implement dynamic loading of GnuTLS on Windows.
6895
6896 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6897 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6898 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6899 Declare.
6900
6901 * gnutls.c (Qgnutls_dll): Define.
6902 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6903 (gnutls_*): Declare function pointers.
6904 (init_gnutls_functions): New function to initialize function pointers.
6905 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6906 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6907 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6908 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6909 (emacs_gnutls_write, emacs_gnutls_read)
6910 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6911 (Fgnutls_available_p): New function.
6912 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6913 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6914 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6915
6916 * image.c: Include w32.h.
6917 (Vimage_type_cache): Delete.
6918 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6919 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6920 (w32_delayed_load): Move to w32.c.
6921
6922 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6923
6924 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6925 (w32_delayed_load): Move from image.c. When loading a library, record
6926 its filename in the :loaded-from property of the library id.
6927 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6928 Initialize and staticpro them.
6929 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6930
6931 * process.c: Include lisp.h before w32.h, not after.
6932 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6933 instead of gnutls_record_check_pending.
6934
6935 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6936
6937 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6938
6939 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6940 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6941 as passed in.
6942
6943 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6944
6945 * xterm.c (x_set_frame_alpha): Do not set property on anything
6946 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6947
6948 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6949
6950 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6951
6952 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6953
6954 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6955 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6956 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6957 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6958 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6959 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6960 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6961 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6962 (Qgnutls_bootprop_callbacks_verify): Make static.
6963
6964 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6965
6966 * callproc.c: Indentation fixup.
6967
6968 * sysdep.c (wait_for_termination_1): Make static.
6969 (wait_for_termination, interruptible_wait_for_termination):
6970 Move after wait_for_termination_1.
6971
6972 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6973
6974 * sysdep.c (interruptible_wait_for_termination): New function
6975 which is like wait_for_termination, but allows keyboard
6976 interruptions.
6977
6978 * callproc.c (Fcall_process): Add (:file "file") as an option for
6979 the STDOUT buffer.
6980 (Fcall_process_region): Ditto.
6981
6982 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6983
6984 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6985 rather than `XVECTOR (FOO)->size'.
6986
6987 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6988 inttypes.h, as a gnulib replacement is used if it not available in
6989 system headers.
6990
6991 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6992
6993 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6994 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6995 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6996
6997 * coding.c (coding_alloc_by_realloc): Error out if destination
6998 will grow beyond MOST_POSITIVE_FIXNUM.
6999 (decode_coding_emacs_mule): Abort if there isn't enough place in
7000 charbuf for the composition carryover bytes. Reserve an extra
7001 space for up to 2 characters produced in a loop.
7002 (decode_coding_iso_2022): Abort if there isn't enough place in
7003 charbuf for the composition carryover bytes.
7004
7005 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7006
7007 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7008 aborting when %lld or %lll format is passed.
7009 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7010 %llo or %llx format is passed. (Bug#8545)
7011
7012 * window.c (window_scroll_line_based): Use a marker instead of
7013 simple variables to record original value of point. (Bug#7952)
7014
7015 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7016 produced by %s or %c overflows available buffer space. (Bug#8545)
7017
7018 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7019
7020 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7021 (SIZE_MAX): Move defn after all includes, as they might #define it.
7022
7023 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7024
7025 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7026
7027 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7028
7029 * keyboard.c (Qdelayed_warnings_hook): Define.
7030 (command_loop_1): Run `delayed-warnings-hook'
7031 if Vdelayed_warnings_list is non-nil.
7032 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7033 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7034
7035 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7036
7037 * doprnt.c (doprnt): Don't return value smaller than the buffer
7038 size if the message was truncated. (Bug#8545).
7039
7040 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7041
7042 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7043 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7044
7045 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7046
7047 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7048
7049 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7050
7051 * makefile.w32-in: Update dependencies.
7052
7053 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7054
7055 Improve `doprnt' and its usage. (Bug#8545)
7056 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7057 `format_end'. Remove support for %l as a conversion specifier.
7058 Don't use xrealloc. Improve diagnostics when the %l size modifier
7059 is used. Update the commentary.
7060
7061 * eval.c (verror): Simplify calculation of size_t.
7062
7063 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7064 messages.
7065
7066 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7067
7068 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7069 change.
7070
7071 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7072
7073 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7074 This makes this file independent of the recent pseudovector change.
7075
7076 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7077
7078 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7079
7080 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7081 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7082 Remove unused local.
7083 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7084
7085 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7086 GCC 4.6.0 optimizes based on type-based alias analysis.
7087 For example, if b is of type struct buffer * and v of type struct
7088 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7089 != &v->size, and therefore "v->size = 1; b->size = 2; return
7090 v->size;" must therefore return 1. This assumption is incorrect
7091 for Emacs, since it type-puns struct Lisp_Vector * with many other
7092 types. To fix this problem, this patch adds a new type struct
7093 vectorlike_header that documents the constraints on layout of vectors
7094 and pseudovectors, and helps optimizing compilers not get fooled
7095 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7096 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7097 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7098 the size member.
7099 (XSETPVECTYPE): Rewrite in terms of new macro.
7100 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7101 This is a bit clearer, and further avoids the possibility of
7102 undesirable aliasing.
7103 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7104 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7105 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7106 since Lisp_Subr is a special case (no "next" field).
7107 (ASIZE): Now uses header.size rather than size.
7108 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7109 to avoid the hassle of writing XVECTOR (foo)->header.size.
7110 (struct vectorlike_header): New type.
7111 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7112 object, to help avoid aliasing.
7113 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7114 (SUBRP): Likewise, since Lisp_Subr is a special case.
7115 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7116 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7117 (struct Lisp_Hash_Table): Combine first two members into a single
7118 struct vectorlike_header member. All uses of "size" and "next" members
7119 changed to be "header.size" and "header.next".
7120 * buffer.h (struct buffer): Likewise.
7121 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7122 * frame.h (struct frame): Likewise.
7123 * process.h (struct Lisp_Process): Likewise.
7124 * termhooks.h (struct terminal): Likewise.
7125 * window.c (struct save_window_data, struct saved_window): Likewise.
7126 * window.h (struct window): Likewise.
7127 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7128 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7129 * buffer.c (init_buffer_once): Likewise.
7130 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7131 special case.
7132 * process.c (Fformat_network_address): Use local var for size,
7133 for brevity.
7134
7135 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7136
7137 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7138 * data.c (atof): Remove decl; no longer used or needed.
7139 (digit_to_number): Move to lread.c.
7140 (Fstring_to_number): Use new string_to_number function, to be
7141 consistent with how the Lisp reader treats infinities and NaNs.
7142 Do not assume that floating-point numbers represent EMACS_INT
7143 without losing information; this is not true on most 64-bit hosts.
7144 Avoid double-rounding errors, by insisting on integers when
7145 parsing non-base-10 numbers, as the documentation specifies.
7146 * lisp.h (string_to_number): New decl, replacing ...
7147 (isfloat_string): Remove.
7148 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7149 (read1): Do not accept +. and -. as integers; this
7150 appears to have been a coding error. Similarly, do not accept
7151 strings like +-1e0 as floating point numbers. Do not report
7152 overflow for integer overflows unless the base is not 10 which
7153 means we have no simple and reliable way to continue.
7154 Break out the floating-point parsing into a new
7155 function string_to_number, so that Fstring_to_number parses
7156 floating point numbers consistently with the Lisp reader.
7157 (digit_to_number): Move here from data.c. Make it static inline.
7158 (E_CHAR, EXP_INT): Remove, replacing with ...
7159 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7160 (string_to_number): New function, replacing isfloat_string.
7161 This function checks for valid syntax and produces the resulting
7162 Lisp float number too. Rework it so that string-to-number
7163 no longer mishandles examples like "1.0e+". Use strtoumax,
7164 so that overflow for non-base-10 numbers is reported only when
7165 there's no portable and simple way to convert to floating point.
7166
7167 * textprop.c (set_text_properties_1): Rewrite for clarity,
7168 and to avoid GCC warning about integer overflow.
7169
7170 * intervals.h (struct interval): Use EMACS_INT for members
7171 where EMACS_UINT might cause problems. See
7172 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7173 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7174 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7175 All uses changed.
7176 (offset_intervals): Tell GCC not to worry about length overflow
7177 when negating a negative length.
7178
7179 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7180 (overrun_check_free): Likewise.
7181
7182 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7183 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7184 word size.
7185
7186 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7187 (gnutls_make_error): Rename local to avoid shadowing.
7188 (gnutls_emacs_global_deinit): ifdef out; not used.
7189 (Fgnutls_boot): Use const for pointer to readonly storage.
7190 Comment out unused local. Fix pointer signedness problems.
7191
7192 * lread.c (openp): Don't stuff size_t into an 'int'.
7193 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7194 about possible signed overflow.
7195
7196 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7197 (GDK_KEY_g): Don't define if already defined.
7198 (xg_prepare_tooltip): Avoid pointer signedness problem.
7199 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7200
7201 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7202 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7203
7204 * xfns.c (Fx_window_property): Simplify a bit,
7205 to make a bit faster and to avoid GCC 4.6.0 warning.
7206 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7207
7208 * fns.c (internal_equal): Don't assume size_t fits in int.
7209
7210 * alloc.c (compact_small_strings): Tighten assertion a little.
7211
7212 Replace pEd with more-general pI, and fix some printf arg casts.
7213 * lisp.h (pI): New macro, generalizing old pEd macro to other
7214 conversion specifiers. For example, use "...%"pI"d..." rather
7215 than "...%"pEd"...".
7216 (pEd): Remove. All uses replaced with similar uses of pI.
7217 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7218 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7219 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7220 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7221 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7222 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7223 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7224 64-bit hosts.
7225 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7226 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7227 * print.c (safe_debug_print, print_object): Likewise.
7228 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7229 to int.
7230 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7231 avoiding the 0 flag, which is not portable.
7232 * process.c (Fmake_network_process): Use pI to avoid cast.
7233 * region-cache.c (pp_cache): Likewise.
7234 * xdisp.c (decode_mode_spec): Likewise.
7235 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7236 behavior on 64-bit hosts with printf arg.
7237 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7238 (x_stop_queuing_selection_requests): Likewise.
7239 (x_get_window_property): Don't truncate byte count to an 'int'
7240 when tracing.
7241
7242 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7243 here, since it parses constructs like leading '-' and spaces,
7244 which are not wanted; and it overflows with large numbers.
7245 Instead, simply match F[0-9]+, which is what is wanted anyway.
7246
7247 * alloc.c: Remove unportable assumptions about struct layout.
7248 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7249 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7250 (allocate_vectorlike, make_pure_vector): Use the new macros,
7251 plus offsetof, to remove unportable assumptions about struct layout.
7252 These assumptions hold on all porting targets that I know of, but
7253 they are not guaranteed, they're easy to remove, and removing them
7254 makes further changes easier.
7255
7256 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7257 This doesn't fix a bug but makes the code clearer.
7258 (string_overrun_cookie): Now const. Use initializers that
7259 don't formally overflow signed char, to avoid warnings.
7260 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7261 can cause Emacs to crash when string overrun checking is enabled.
7262 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7263 multiple of sizeof (EMACS_INT); it need not be, if
7264 alignof(EMACS_INT) < sizeof (EMACS_INT).
7265 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7266
7267 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7268
7269 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7270
7271 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7272
7273 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7274 supposed to be handshaking. (Bug#8556)
7275 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7276
7277 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7278
7279 * lisp.h (Qdebug): List symbol.
7280 * eval.c (Qdebug): Restore global linkage.
7281 * keyboard.c (debug-on-event): New variable.
7282 (handle_user_signal): Break into debugger when debug-on-event
7283 matches the current signal symbol.
7284
7285 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7286
7287 * alloc.c (check_sblock, check_string_bytes)
7288 (check_string_free_list): Convert to standard C.
7289
7290 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7291
7292 * w32.c (emacs_gnutls_push): Fix typo.
7293
7294 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7295
7296 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7297 "cast to pointer from integer of different size".
7298
7299 Improve doprnt and its use in verror. (Bug#8545)
7300 * doprnt.c (doprnt): Document the set of format control sequences
7301 supported by the function. Use SAFE_ALLOCA instead of always
7302 using `alloca'.
7303
7304 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7305 is one byte too soon. Don't use xrealloc; instead xfree and
7306 xmalloc anew.
7307
7308 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7309
7310 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7311 callbacks stage.
7312
7313 * gnutls.c: Renamed global_initialized to
7314 gnutls_global_initialized. Added internals for the
7315 :verify-hostname-error, :verify-error, and :verify-flags
7316 parameters of `gnutls-boot' and documented those parameters in the
7317 docstring. Start callback support.
7318 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7319 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7320 on error. Return error code.
7321 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7322 (emacs_gnutls_read): Likewise.
7323 (Fgnutls_boot): Return handshake error code.
7324 (emacs_gnutls_handle_error): New function.
7325 (wsaerror_to_errno): Likewise.
7326
7327 * w32.h (emacs_gnutls_pull): Add prototype.
7328 (emacs_gnutls_push): Likewise.
7329
7330 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7331 (emacs_gnutls_push): Likewise.
7332
7333 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7334
7335 * process.c (wait_reading_process_output): Check if GnuTLS
7336 buffered some data internally if no FDs are set for TLS
7337 connections.
7338
7339 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7340 (LIBS): Link to USER_LIBS.
7341 ($(BLD)/gnutls.$(0)): New target.
7342
7343 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7344
7345 * xdisp.c (handle_single_display_spec): Rename the
7346 display_replaced_before_p argument into display_replaced_p, to
7347 make it consistent with the commentary. Fix typos in the
7348 commentary.
7349
7350 * textprop.c (syms_of_textprop): Remove dead code.
7351 (copy_text_properties): Delete obsolete commentary about an
7352 interface that was deleted long ago. Fix typos in the description
7353 of arguments.
7354
7355 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7356 to changes in oldXMenu/XMenu.h from 2011-04-16.
7357 <menu_help_message, prev_menu_help_message>: Constify.
7358 (IT_menu_make_room): menu->help_text is now `const char **';
7359 adjust.
7360
7361 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7362 to changes in oldXMenu/XMenu.h from 2011-04-16.
7363 (struct XMenu): Declare `help_text' `const char **'.
7364
7365 * xfaces.c <Qunspecified>: Make extern again.
7366
7367 * syntax.c: Include sys/types.h before including regex.h, as
7368 required by POSIX.
7369
7370 * doc.c (get_doc_string): Improve the format passed to `error'.
7371
7372 * doprnt.c (doprnt): Improve commentary.
7373
7374 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7375
7376 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7377 them with etags.
7378
7379 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7380 changes in globals.h immediately force recompilation.
7381 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7382 $(CURDIR)/s/ms-w32.h.
7383 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7384
7385 * character.c (Fchar_direction): Function deleted.
7386 (syms_of_character): Don't defsubr it.
7387 <char-direction-table>: Deleted.
7388
7389 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7390
7391 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7392 * doprnt.c: Include limits.h.
7393 (SIZE_MAX): New macro.
7394 (doprnt): Return a size_t value. 2nd arg is now size_t.
7395 Many local variables are now size_t instead of int or unsigned.
7396 Improve overflow protection. Support `l' modifier for integer
7397 conversions. Support %l conversion. Don't assume an EMACS_INT
7398 argument for integer conversions and for %c.
7399
7400 * lisp.h (doprnt): Restore prototype.
7401
7402 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7403 $(SRC)/character.h.
7404
7405 * Makefile.in (base_obj): Add back doprnt.o.
7406
7407 * deps.mk (doprnt.o): Add back prerequisites.
7408 (callint.o): Depend on character.h.
7409
7410 * eval.c (internal_lisp_condition_case): Include the handler
7411 representation in the error message.
7412 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7413 when breaking from the loop.
7414
7415 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7416
7417 * callint.c (Fcall_interactively): When displaying error message
7418 about invalid control letter, pass the character's codepoint, not
7419 a pointer to its multibyte form. Improve display of the character
7420 in octal and display also its hex code.
7421
7422 * character.c (char_string): Use %x to display the (unsigned)
7423 codepoint of an invalid character, to avoid displaying a bogus
7424 negative value.
7425
7426 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7427 `error', not SYMBOL_NAME itself.
7428
7429 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7430 character arguments to `error'.
7431
7432 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7433 to `error' in error message about FINAL_CHAR argument. Make sure
7434 FINAL_CHAR is a character, and use %c when it is passed as
7435 argument to `error'.
7436
7437 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7438
7439 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7440
7441 * w32.c: Include <time.h>.
7442 (sys_localtime): New function.
7443
7444 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7445
7446 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7447
7448 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7449
7450 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7451
7452 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7453 zombies (Bug#8467).
7454
7455 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7456
7457 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7458 gl_state.e_property when gl_state.object is Qt.
7459
7460 * insdel.c (make_gap_larger): Remove limitation of buffer size
7461 to <= INT_MAX.
7462
7463 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7464
7465 * xdisp.c (lookup_glyphless_char_display)
7466 (produce_glyphless_glyph): Handle cons cell entry in
7467 glyphless-char-display.
7468 (Vglyphless_char_display): Document it.
7469
7470 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7471 glyphless-char-display.
7472
7473 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7474
7475 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7476
7477 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7478
7479 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7480 definition for no-X builds.
7481
7482 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7483
7484 Static checks with GCC 4.6.0 and non-default toolkits.
7485
7486 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7487
7488 * process.c (keyboard_bit_set): Define only if SIGIO.
7489 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7490 (send_process): Repair possible setjmp clobbering.
7491
7492 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7493
7494 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7495
7496 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7497
7498 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7499 Define only if needed.
7500
7501 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7502 by pacifying GCC about it. Maybe it's time to retire it?
7503 * xfaces.c (USG, __TIMEVAL__): Likewise.
7504
7505 * dispextern.h (struct redisplay_interface): Rename param
7506 to avoid shadowing.
7507 * termhooks.h (struct terminal): Likewise.
7508 * xterm.c (xembed_send_message): Likewise.
7509
7510 * insdel.c (make_gap_smaller): Define only if
7511 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7512
7513 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7514 it.
7515
7516 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7517 so that we aren't warned about unused symbols.
7518
7519 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7520
7521 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7522
7523 * xfns.c (x_real_positions): Mark locals as initialized.
7524
7525 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7526
7527 * xterm.c: Fix problems found by static analysis with other toolkits.
7528 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7529 (x_dispatch_event): Declare static if USE_GTK, and
7530 define if USE_GTK || USE_X_TOOLKIT.
7531 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7532 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7533 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7534 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7535
7536 * xmenu.c (menu_help_callback): Pointer type fixes.
7537 Use const pointers when pointing at readonly data. Avoid pointer
7538 signedness clashes.
7539 (FALSE): Remove unused macro.
7540 (update_frame_menubar): Remove unused decl.
7541
7542 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7543
7544 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7545 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7546 (single_menu_item): Rename local to avoid shadowing.
7547
7548 * keyboard.c (make_lispy_event): Remove unused local var.
7549
7550 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7551 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7552
7553 * bitmaps: Change bitmaps from unsigned char back to the X11
7554 compatible char. Avoid the old compiler warnings about
7555 out-of-range initializers by using, for example, '\xab' rather
7556 than 0xab.
7557
7558 * xgselect.c (xgselect_initialize): Check vs interface
7559 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7560
7561 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7562
7563 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7564 to read-only memory.
7565
7566 * fns.c (vector): Remove; this old hack is no longer needed.
7567
7568 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7569 Remove unused var.
7570 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7571
7572 * xrdb.c (x_load_resources): Omit unused local.
7573
7574 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7575 (x_window): Rename locals to avoid shadowing.
7576 (USG): Use the kludged USG macro, to pacify gcc.
7577
7578 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7579 (x_term_init): Remove local to avoid shadowing.
7580
7581 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7582
7583 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7584 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7585
7586 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7587
7588 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7589
7590 Fix regex.c, syntax.c and friends for buffers > 2GB.
7591 * syntax.h (struct gl_state_s): Declare character position members
7592 EMACS_INT.
7593
7594 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7595
7596 * textprop.c (verify_interval_modification, interval_of):
7597 Declare arguments EMACS_INT.
7598
7599 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7600 EMACS_INT.
7601
7602 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7603
7604 * indent.c (Fvertical_motion): Local variable it_start is now
7605 EMACS_INT.
7606
7607 * regex.c (re_match, re_match_2, re_match_2_internal)
7608 (bcmp_translate, regcomp, regexec, print_double_string)
7609 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7610 (re_compile_pattern, re_exec): Declare arguments and local
7611 variables `size_t' and `ssize_t' and return values `regoff_t', as
7612 appropriate.
7613 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7614 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7615 <compile_stack_type>: `size' and `avail' are now `size_t'.
7616
7617 * regex.h <regoff_t>: Use ssize_t, not int.
7618 (re_search, re_search_2, re_match, re_match_2): Arguments that
7619 specify buffer/string position and length are now ssize_t and
7620 size_t. Return type is regoff_t.
7621
7622 2011-04-16 Ben Key <bkey76@gmail.com>
7623
7624 * nsfont.m: Fixed bugs in ns_get_family and
7625 ns_descriptor_to_entity that were caused by using free to
7626 deallocate memory blocks that were allocated by xmalloc (via
7627 xstrdup). This caused Emacs to crash when compiled with
7628 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7629 --enable-checking=xmallocoverrun). xfree is now used to
7630 deallocate these memory blocks.
7631
7632 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7633
7634 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7635
7636 emacs_write: Accept and return EMACS_INT for sizes.
7637 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7638 et seq.
7639 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7640 Accept and return EMACS_INT.
7641 (emacs_gnutls_write): Return the number of bytes written on
7642 partial writes.
7643 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7644 (emacs_read, emacs_write): Remove check for negative size, as the
7645 Emacs source code has been audited now.
7646 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7647 (emacs_read, emacs_write): Use it.
7648 * process.c (send_process): Adjust to the new signatures of
7649 emacs_write and emacs_gnutls_write. Do not attempt to store
7650 a byte offset into an 'int'; it might overflow.
7651 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7652
7653 * sound.c: Don't assume sizes fit in 'int'.
7654 (struct sound_device.period_size, alsa_period_size):
7655 Return EMACS_INT, not int.
7656 (struct sound_device.write, vox_write, alsa_write):
7657 Accept EMACS_INT, not int.
7658 (wav_play, au_play): Use EMACS_INT to store sizes and to
7659 record read return values.
7660
7661 2011-04-15 Ben Key <bkey76@gmail.com>
7662
7663 * keyboard.c (Qundefined): Don't declare static since it is used
7664 in nsfns.m.
7665 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7666 static since they are used in nsfont.m.
7667
7668 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7669
7670 * process.c (Qprocessp): Don't declare static.
7671 * lisp.h (Qprocessp): Declare again.
7672
7673 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7674
7675 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7676
7677 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7678
7679 Improve C-level modularity by making more things 'static'.
7680
7681 Don't publish debugger-only interfaces to other modules.
7682 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7683 (verify_bytepos, count_markers): Move decls to the only modules
7684 that need them.
7685 * region-cache.h (pp_cache): Likewise.
7686 * window.h (check_all_windows): Likewise.
7687 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7688
7689 * sysdep.c (croak): Now static, if
7690 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7691 * syssignal.h (croak): Declare only if not static.
7692
7693 * alloc.c (refill_memory_reserve): Now static if
7694 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7695 * lisp.h (refill_memory_reserve): Declare only if not static.
7696
7697 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7698 Define only if USE_LUCID.
7699
7700 * xrdb.c (x_customization_string, x_rm_string): Now static.
7701
7702 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7703 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7704
7705 * xdisp.c (draw_row_with_mouse_face): Now static.
7706 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7707
7708 * window.h (check_all_windows): Mark externally visible.
7709
7710 * window.c (window_deletion_count): Now static.
7711
7712 * undo.c: Make symbols static if they're not exported.
7713 (last_undo_buffer, last_boundary_position, pending_boundary):
7714 Now static.
7715
7716 * textprop.c (interval_insert_behind_hooks): Now static.
7717 (interval_insert_in_front_hooks): Likewise.
7718
7719 * term.c: Make symbols static if they're not exported.
7720 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7721 (max_frame_lines, tty_set_terminal_modes):
7722 (tty_reset_terminal_modes, tty_turn_off_highlight):
7723 (get_tty_terminal): Now static.
7724 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7725 * termhooks.h (term_mouse_moveto): Do not declare if
7726 HAVE_WINDOW_SYSTEM.
7727 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7728 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7729
7730 * sysdep.c: Make symbols static if they're not exported.
7731 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7732 Now static.
7733 (sigprocmask_set, full_mask): Remove; unused.
7734 (wait_debugging): Mark as visible.
7735 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7736 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7737
7738 * syntax.c (syntax_temp): Define only if !__GNUC__.
7739
7740 * sound.c (current_sound_device, current_sound): Now static.
7741
7742 * search.c (searchbufs, searchbuf_head): Now static.
7743
7744 * scroll.c (scroll_cost): Remove; unused.
7745 * dispextern.h (scroll_cost): Remove decl.
7746
7747 * region-cache.h (pp_cache): Mark as externally visible.
7748
7749 * process.c: Make symbols static if they're not exported.
7750 (process_tick, update_tick, create_process, chan_process):
7751 (Vprocess_alist, proc_buffered_char, datagram_access):
7752 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7753 (deactivate_process): Mark defn as static, as well as decl.
7754 * lisp.h (create_process): Remove decl.
7755 * process.h (chan_process, Vprocess_alist): Remove decls.
7756
7757 * print.c: Make symbols static if they're not exported.
7758 (print_depth, new_backquote_output, being_printed, print_buffer):
7759 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7760 (print_interval, print_number_index, initial_stderr_stream):
7761 Now static.
7762 * lisp.h (Fprinc): Remove decl.
7763 (debug_output_compilation_hack): Mark as externally visible.
7764
7765 * sysdep.c (croak): Move decl from here to syssignal.h.
7766 * syssignal.h (croak): Put it here, so the API can be checked when
7767 'croak' is called from dissociate_if_controlling_tty.
7768
7769 * minibuf.c: Make symbols static if they're not exported.
7770 (minibuf_save_list, choose_minibuf_frame): Now static.
7771 * lisp.h (choose_minibuf_frame): Remove decl.
7772
7773 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7774
7775 * lread.c: Make symbols static if they're not exported.
7776 (read_objects, initial_obarray, oblookup_last_bucket_number):
7777 Now static.
7778 (make_symbol): Remove; unused.
7779 * lisp.h (initial_obarray, make_symbol): Remove decls.
7780
7781 * keyboard.c: Make symbols static if they're not exported.
7782 (single_kboard, recent_keys_index, total_keys, recent_keys):
7783 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7784 (this_single_command_key_start, echoing, last_auto_save):
7785 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7786 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7787 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7788 (Vlispy_mouse_stem, double_click_count):
7789 Now static.
7790 (force_auto_save_soon): Define only if SIGDANGER.
7791 (ignore_mouse_drag_p): Now static if
7792 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7793 (print_help): Remove; unused.
7794 (stop_character, last_timer_event): Mark as externally visible.
7795 * keyboard.h (ignore_mouse_drag_p): Declare only if
7796 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7797 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7798 * lisp.h (echoing): Remove decl.
7799 (force_auto_save_soon): Declare only if SIGDANGER.
7800 * xdisp.c (redisplay_window): Simplify code, to make it more
7801 obvious that ignore_mouse_drag_p is not accessed if !defined
7802 USE_GTK && !defined HAVE_NS.
7803
7804 * intervals.c: Make symbols static if they're not exported.
7805 (merge_properties_sticky, merge_interval_right, delete_interval):
7806 Now static.
7807 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7808
7809 * insdel.c: Make symbols static if they're not exported.
7810 However, leave prepare_to_modify_buffer alone. It's never
7811 called from outside this function, but that appears to be a bug.
7812 (combine_after_change_list, combine_after_change_buffer):
7813 (adjust_after_replace, signal_before_change): Now static.
7814 (adjust_after_replace_noundo): Remove; unused.
7815 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7816 (signal_before_change): Remove decls.
7817
7818 * indent.c (val_compute_motion, val_vmotion): Now static.
7819
7820 * image.c: Make symbols static if they're not exported.
7821 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7822 if USE_GTK.
7823 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7824 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7825
7826 * fringe.c (standard_bitmaps): Now static.
7827 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7828
7829 * frame.c: Make symbols static if they're not exported.
7830 (x_report_frame_params, make_terminal_frame): Now static.
7831 (get_frame_param): Now static, unless HAVE_NS.
7832 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7833 (x_get_resource_string): Remove; not used.
7834 * frame.h (make_terminal_frame, x_report_frame_params):
7835 (x_get_resource_string); Remove decls.
7836 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7837 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7838
7839 * font.c, fontset.c: Make symbols static if they're not exported.
7840 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7841 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7842 * font.c (font_close_object): Now static.
7843 * font.h (font_close_object): Remove.
7844 * fontset.c (FONTSET_OBJLIST): Remove.
7845 (free_realized_fontset) #if-0 the body, which does nothing.
7846 (face_suitable_for_char_p): #if-0, as it's never called.
7847 * fontset.h (face_suitable_for_char_p): Remove decl.
7848 * xfaces.c (face_at_string_position):
7849 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7850 since 0 is always ASCII.
7851
7852 * fns.c (weak_hash_tables): Now static.
7853
7854 * fileio.c: Make symbols static if they're not exported.
7855 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7856 (Vwrite_region_annotation_buffers): Now static.
7857
7858 * eval.c: Make symbols static if they're not exported.
7859 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7860 * lisp.h (backtrace_list): Remove decl.
7861
7862 * emacs.c: Make symbols static if they're not exported.
7863 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7864 (fatal_error_code, fatal_error_signal_hook, standard_args):
7865 Now static.
7866 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7867 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7868 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7869 * lisp.h (fatal_error_signal_hook): Remove decl.
7870 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7871
7872 * editfns.c: Move a (normally-unused) function to its only use.
7873 * editfns.c, lisp.h (get_operating_system_release): Remove.
7874 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7875 worth the hassle of breaking this out.
7876
7877 * xterm.c: Make symbols static if they're not exported.
7878 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7879 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7880 (x_destroy_window, x_delete_display):
7881 Now static.
7882 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7883 (x_mouse_leave): Remove; unused.
7884 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7885 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7886 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7887 Remove decls.
7888 (x_mouse_leave): Declare only if WINDOWSNT.
7889 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7890 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7891 USE_X_TOOLKIT.
7892
7893 * ftxfont.c: Make symbols static if they're not exported.
7894 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7895 HAVE_FREETYPE.
7896 * font.h (ftxfont_driver): Likewise.
7897
7898 * xfns.c: Make symbols static if they're not exported.
7899 (x_last_font_name, x_display_info_for_name):
7900 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7901 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7902 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7903 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7904 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7905 (last_show_tip_args): Now static.
7906 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7907 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7908 (x_screen_planes): Remove; unused.
7909 * dispextern.h (x_screen_planes): Remove decl.
7910
7911 * dispnew.c: Make symbols static if they're not exported.
7912 * dispextern.h (redraw_garbaged_frames, scrolling):
7913 (increment_row_positions): Remove.
7914 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7915 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7916 Now static.
7917 (redraw_garbaged_frames): Remove; unused.
7918
7919 * xfaces.c: Make symbols static if they're not exported.
7920 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7921 Remove decls.
7922 * xterm.h (defined_color): Remove decls.
7923 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7924 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7925 (menu_face_changed_default, defined_color, free_realized_face):
7926 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7927 (ascii_face_of_lisp_face): Remove; unused.
7928
7929 * xdisp.c: Make symbols static if they're not exported.
7930 * dispextern.h (scratch_glyph_row, window_box_edges):
7931 (glyph_to_pixel_coords, set_cursor_from_row):
7932 (get_next_display_element, set_iterator_to_next):
7933 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7934 (show_mouse_face): Remove decls
7935 * frame.h (message_buf_print): Likewise.
7936 * lisp.h (pop_message, set_message, check_point_in_composition):
7937 Likewise.
7938 * xterm.h (set_vertical_scroll_bar): Likewise.
7939 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7940 (message_buf_print, scratch_glyph_row, displayed_buffer):
7941 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7942 (get_next_display_element, show_mouse_face, window_box_edges):
7943 (frame_to_window_pixel_xy, check_point_in_composition):
7944 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7945 (glyph_to_pixel_coords): Remove; unused.
7946
7947 * dired.c (file_name_completion): Now static.
7948
7949 * dbusbind.c (xd_in_read_queued_messages): Now static.
7950
7951 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7952 * data.c (circular_list_error): Remove.
7953
7954 * commands.h (last_point_position, last_point_position_buffer):
7955 (last_point_position_window): Remove decls.
7956 * keyboard.c: Make these variables static.
7957
7958 * coding.h (coding, code_convert_region, encode_coding_gap):
7959 Remove decls.
7960 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7961 (iso_code_class, detect_coding, code_convert_region): Now static.
7962 (encode_coding_gap): Remove; unused.
7963
7964 * chartab.c (chartab_chars, chartab_bits): Now static.
7965
7966 * charset.h (charset_iso_8859_1): Remove decl.
7967 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7968 Now static.
7969
7970 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7971 * ccl.c (Vccl_program_table): Now static.
7972 (check_ccl_update): Remove; unused.
7973
7974 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7975 * category.h: ... from here.
7976 * category.c (check_category_table, set_category_set): Now static.
7977
7978 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7979 * lisp.h: Remove these decls.
7980
7981 * buffer.c (buffer_count): Remove unused var.
7982
7983 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7984 so that it's not optimized away.
7985 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7986 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7987 exported only to the debugger.
7988
7989 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7990 * atimer.h (run_all_atimers): Remove; not exported.
7991
7992 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7993 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7994 was inaccessible from Lisp.
7995 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7996 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7997
7998 alloc.c: Import and export fewer symbols, and remove unused items.
7999 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8000 is defined.
8001 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8002 it's not optimized away by whole-program optimization.
8003 (message_enable_multibyte, free_misc): Remove.
8004 (catchlist, handlerlist, mark_backtrace):
8005 Declare only if BYTE_MARK_STACK.
8006 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8007 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8008 (message_enable_multibyte): Remove decl.
8009 (free_misc, interval_free_list, float_block, float_block_index):
8010 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8011 (cons_free_list, last_marked_index):
8012 Now static.
8013 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8014 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8015 (mark_backtrace): Define only if BYTE_MARK_STACK.
8016 * xdisp.c (message_enable_multibyte): Now static.
8017
8018 Declare Lisp_Object Q* variables to be 'static' if not exported.
8019 This makes it easier for human readers (and static analyzers)
8020 to see whether these variables are used from other modules.
8021 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8022 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8023 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8024 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8025 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8026 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8027 * xmenu.c, xselect.c:
8028 Declare Q* vars static if they are not used in other modules.
8029 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8030 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8031 Remove decls of unexported vars.
8032 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8033
8034 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8035
8036 Make Emacs functions such as Fatom 'static' by default.
8037 This makes it easier for human readers (and static analyzers)
8038 to see whether these functions can be called from other modules.
8039 DEFUN now defines a static function. To make the function external
8040 so that it can be used in other C modules, use the new macro DEFUE.
8041 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8042 (Finit_image_library):
8043 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8044 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8045 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8046 Remove decls, since these functions are now static.
8047 (Funintern, Fget_internal_run_time): New decls, since these functions
8048 were already external.
8049
8050 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8051 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8052 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8053 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8054 * keyboard.c, keymap.c, lread.c:
8055 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8056 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8057 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8058 Mark functions with DEFUE instead of DEFUN,
8059 if they are used in other modules.
8060 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8061 decls for now-static functions.
8062 * buffer.h (Fdelete_overlay): Remove decl.
8063 * callproc.c (Fgetenv_internal): Mark as internal.
8064 * composite.c (Fremove_list_of_text_properties): Remove decl.
8065 (Fcomposition_get_gstring): New forward static decl.
8066 * composite.h (Fcomposite_get_gstring): Remove decl.
8067 * dired.c (Ffile_attributes): New forward static decl.
8068 * doc.c (Fdocumntation_property): New forward static decl.
8069 * eval.c (Ffetch_bytecode): New forward static decl.
8070 (Funintern): Remove extern decl; now in .h file where it belongs.
8071 * fileio.c (Fmake_symbolic_link): New forward static decl.
8072 * image.c (Finit_image_library): New forward static decl.
8073 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8074 * intervals.h (Fprevious_property_change):
8075 (Fremove_list_of_text_properties): Remove decls.
8076 * keyboard.c (Fthis_command_keys): Remove decl.
8077 (Fcommand_execute): New forward static decl.
8078 * keymap.c (Flookup_key): New forward static decl.
8079 (Fcopy_keymap): Now static.
8080 * keymap.h (Flookup_key): Remove decl.
8081 * process.c (Fget_process): New forward static decl.
8082 (Fprocess_datagram_address): Mark as internal.
8083 * syntax.c (Fsyntax_table_p): New forward static decl.
8084 (skip_chars): Remove duplicate decl.
8085 * textprop.c (Fprevious_property_change): New forward static decl.
8086 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8087 Now internal.
8088 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8089 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8090
8091 * editfns.c (Fformat): Remove unreachable code.
8092
8093 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8094
8095 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8096 change. (Bug#8496)
8097
8098 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8099
8100 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8101 when at ZV. (Bug#8487)
8102
8103 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8104
8105 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8106 (Bug#8437)
8107 * keyboard.c (parse_tool_bar_item): Likewise.
8108 * sound.c (sound_cleanup, alsa_close): Likewise.
8109 * termcap.c (tgetent): Likewise.
8110 * xfns.c (x_default_font_parameter): Likewise.
8111 * xsettings.c (read_and_apply_settings): Likewise.
8112
8113 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8114 (overrun_check_free): Protoize.
8115
8116 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8117
8118 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8119 since callers should never pass a negative size.
8120 Change the signature to match that of plain 'read' and 'write'; see
8121 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8122 * lisp.h: Update prototypes of emacs_write and emacs_read.
8123
8124 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8125
8126 * xdisp.c (redisplay_window): Don't try to determine the character
8127 position of the scroll margin if the window start point w->startp
8128 is outside the buffer's accessible region. (Bug#8468)
8129
8130 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8131
8132 Fix write-region and its subroutines for buffers > 2GB.
8133 * fileio.c (a_write, e_write): Modify declaration of arguments and
8134 local variables to support buffers larger than 2GB.
8135 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8136
8137 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8138 argument, local variables, and return value.
8139
8140 * lisp.h: Update prototypes of emacs_write and emacs_read.
8141
8142 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8143
8144 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8145
8146 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8147
8148 Fix more problems found by GCC 4.6.0's static checks.
8149
8150 * xdisp.c (vmessage): Use a better test for character truncation.
8151
8152 * charset.c (load_charset_map): <, not <=, for optimization,
8153 and to avoid potential problems with integer overflow.
8154 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8155 * casetab.c (set_identity, shuffle): Likewise.
8156 * editfns.c (Fformat): Likewise.
8157 * syntax.c (skip_chars): Likewise.
8158
8159 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8160 This also lets GCC 4.6.0 generate slightly better loop code.
8161
8162 * callint.c (Fcall_interactively): <, not <=, for optimization.
8163 (Fcall_interactively): Count the number of arguments produced,
8164 not the number of arguments given. This is simpler and lets GCC
8165 4.6.0 generate slightly better code.
8166
8167 * ftfont.c: Distingish more carefully between FcChar8 and char.
8168 The previous code passed unsigned char * to a functions like
8169 strlen and xstrcasecmp that expect char *, which does not
8170 conform to the C standard.
8171 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8172 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8173 char * when the C standard requires it.
8174
8175 * keyboard.c (read_char): Remove unused var.
8176
8177 * eval.c: Port to Windows vsnprintf (Bug#8435).
8178 Include <limits.h>.
8179 (SIZE_MAX): Define if the headers do not.
8180 (verror): Do not give up if vsnprintf returns a negative count.
8181 Instead, grow the buffer. This ports to Windows vsnprintf, which
8182 does not conform to C99. Problem reported by Eli Zaretskii.
8183 Also, simplify the allocation scheme, by avoiding the need for
8184 calling realloc, and removing the ALLOCATED variable.
8185
8186 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8187
8188 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8189 But keep the doprint source code for now, as we might revamp it
8190 and use it again (Bug#8435).
8191 * lisp.h (doprnt): Remove.
8192 * Makefile.in (base_obj): Remove doprnt.o.
8193 * deps.mk (doprnt.o): Remove.
8194
8195 error: Print 32- and 64-bit integers portably (Bug#8435).
8196 Without this change, on typical 64-bit hosts error ("...%d...", N)
8197 was used to print both 32- and 64-bit integers N, which relied on
8198 undefined behavior.
8199 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8200 * lisp.h (error, verror): Mark as printf-like functions.
8201 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8202 Report overflow in size calculations when allocating printf buffer.
8203 Do not truncate output string at its first null byte.
8204 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8205 Truncate the output at a character boundary, since vsnprintf does not
8206 do that.
8207 * charset.c (check_iso_charset_parameter): Convert internal
8208 character to string before calling 'error', since %c now has the
8209 printf meaning.
8210 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8211 overflow when computing char to be passed to 'error'. Do not
8212 pass Lisp_Object to 'error'; pass the integer instead.
8213 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8214 formatted with plain %d.
8215
8216 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8217
8218 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8219
8220 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8221
8222 * xterm.c (x_catch_errors): Remove duplicate declaration.
8223
8224 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8225
8226 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8227
8228 2011-04-10 Jim Meyering <meyering@redhat.com>
8229
8230 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8231 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8232 return ssize_t not "int", and use size_t as the buffer length.
8233 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8234 * gnutls.h: Update declarations.
8235 * process.c (read_process_output): Use ssize_t, to match.
8236 (send_process): Likewise.
8237
8238 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8239
8240 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8241
8242 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8243
8244 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8245 Use unsigned char, to match FcChar8 type definition.
8246
8247 * xterm.c (handle_one_xevent):
8248 * xmenu.c (create_and_show_popup_menu):
8249 * xselect.c (x_decline_selection_request)
8250 (x_reply_selection_request): Avoid type-punned deref of X events.
8251
8252 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8253
8254 Fix some uses of `int' instead of EMACS_INT.
8255 * search.c (string_match_1, fast_string_match)
8256 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8257 (scan_buffer, find_next_newline_no_quit)
8258 (find_before_next_newline, search_command, Freplace_match)
8259 (Fmatch_data): Make some `int' variables be EMACS_INT.
8260
8261 * xdisp.c (display_count_lines): 3rd argument and return value now
8262 EMACS_INT. All callers changed.
8263 (pint2hrstr): Last argument is now EMACS_INT.
8264
8265 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8266 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8267 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8268 (decode_coding_utf_16, decode_coding_emacs_mule)
8269 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8270 (decode_coding_ccl, decode_coding_charset)
8271 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8272 (decode_coding_iso_2022, decode_coding_emacs_mule)
8273 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8274 <char_offset, last_offset>: Declare EMACS_INT.
8275 (encode_coding_utf_8, encode_coding_utf_16)
8276 (encode_coding_emacs_mule, encode_invocation_designation)
8277 (encode_designation_at_bol, encode_coding_iso_2022)
8278 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8279 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8280 Declare EMACS_INT.
8281 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8282 (encode_invocation_designation): Last argument P_NCHARS is now
8283 EMACS_INT.
8284 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8285 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8286
8287 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8288 All users changed.
8289
8290 * ccl.c (Fccl_execute_on_string): Declare some variables
8291 EMACS_INT.
8292
8293 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8294
8295 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8296
8297 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8298
8299 * process.c (Fformat_network_address): Doc fix.
8300
8301 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8302
8303 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8304
8305 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8306
8307 * keyboard.c (read_char): Call Lisp function help-form-show,
8308 instead of using internal_with_output_to_temp_buffer.
8309 (Qhelp_form_show): New var.
8310 (syms_of_keyboard): Use DEFSYM macro.
8311
8312 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8313
8314 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8315
8316 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8317
8318 * process.c (Flist_processes): Remove to Lisp.
8319 (list_processes_1): Delete.
8320
8321 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8322
8323 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8324
8325 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8326
8327 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8328
8329 Fix more problems found by GCC 4.6.0's static checks.
8330
8331 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8332
8333 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8334
8335 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8336
8337 * xdisp.c (vmessage): Mark as a printf-like function.
8338
8339 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8340
8341 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8342
8343 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8344 printf-like functions.
8345 (tiff_load): Add casts to remove these marks before passing them
8346 to system-supplied API.
8347
8348 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8349
8350 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8351 This avoids several warnings with gcc -Wstrict-overflow.
8352 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8353 directly, rather than having caller test rule sign. This avoids
8354 some unnecessary tests.
8355 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8356 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8357 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8358
8359 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8360 (xfont_open): Avoid unnecessary tests.
8361
8362 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8363
8364 * composite.h, composite.c (composition_gstring_put_cache):
8365 Use EMACS_INT, not int, for length.
8366
8367 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8368 breaking out part of COMPOSITION_DECODE_RULE.
8369 (COMPOSITION_DECODE_RULE): Use it.
8370 * composite.c (get_composition_id): Remove unused local vars,
8371 by using the new macro.
8372
8373 * textprop.c (set_text_properties_1): Change while to do-while,
8374 since the condition is always true at first.
8375
8376 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8377 (interval_deletion_adjustment): Return unsigned value.
8378 All uses changed.
8379
8380 * process.c (list_processes_1, create_pty, read_process_output):
8381 (exec_sentinel): Remove vars that were set but not used.
8382 (create_pty): Remove unnecessary "volatile"s.
8383 (Fnetwork_interface_info): Avoid possibility of int overflow.
8384 (read_process_output): Do adaptive read buffering even if carryover.
8385 (read_process_output): Simplify nbytes computation if buffered.
8386
8387 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8388
8389 * syntax.c (scan_words): Remove var that was set but not used.
8390 (update_syntax_table): Use unsigned instead of int.
8391
8392 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8393 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8394 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8395
8396 * print.c (print_error_message): Avoid int overflow.
8397
8398 * font.c (font_list_entities): Redo for clarity,
8399 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8400
8401 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8402 (font_score): Avoid potential overflow in diff calculation.
8403
8404 * fns.c (substring_both): Remove var that is set but not used.
8405 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8406
8407 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8408
8409 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8410 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8411 can always succeed if overflow has undefined behavior.
8412
8413 * search.c (boyer_moore, wordify): Remove vars set but not used.
8414 (wordify): Omit three unnecessary tests.
8415
8416 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8417 All callers changed. This avoids the need for an unused var.
8418
8419 * casefiddle.c (casify_region): Remove var that is set but not used.
8420
8421 * dired.c (file_name_completion): Remove var that is set but not used.
8422
8423 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8424
8425 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8426 (Finsert_file_contents): Remove unnecessary code checking fd.
8427
8428 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8429 Check for integer overflow on size calculations.
8430
8431 * buffer.c (Fprevious_overlay_change): Remove var that is set
8432 but not used.
8433
8434 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8435 Remove vars that are set but not used.
8436 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8437 (timer_check_2): Mark vars as initialized.
8438
8439 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8440
8441 * image.c (lookup_image): Remove var that is set but not used.
8442 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8443
8444 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8445 that are set but not used.
8446
8447 * xfns.c (make_invisible_cursor): Don't return garbage
8448 if XCreateBitmapFromData fails (Bug#8410).
8449
8450 * xselect.c (x_get_local_selection, x_handle_property_notify):
8451 Remove vars that are set but not used.
8452
8453 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8454 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8455
8456 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8457 Remove var that is set but not used.
8458 (scroll_bar_windows_size): Now size_t, not int.
8459 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8460 Check for overflow.
8461
8462 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8463 (map_tty_color) [!defined MSDOS]: Likewise.
8464
8465 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8466
8467 * coding.c: Remove vars that are set but not used.
8468 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8469 All callers changed.
8470 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8471 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8472 (decode_coding_charset): Remove vars that are set but not used.
8473
8474 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8475 that is set but not used.
8476
8477 * print.c (print_object): Remove var that is set but not used.
8478
8479 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8480 The gnulib version avoids calling malloc in the usual case,
8481 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8482 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8483 * filelock.c (current_lock_owner): Likewise.
8484 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8485 * sysdep.c: Include allocator.h, careadlinkat.h.
8486 (emacs_no_realloc_allocator): New static constant.
8487 (emacs_readlink): New function.
8488 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8489 ../lib/careadlinkat.h.
8490
8491 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8492
8493 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8494 first non-nil return value).
8495
8496 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8497
8498 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8499 if not defined (Bug#8403).
8500
8501 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8502
8503 * xdisp.c (display_count_lines): Remove parameter `start',
8504 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8505 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8506 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8507 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8508 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8509 and thereabouts. All callers changed.
8510 (get_per_char_metric): Remove parameter `f', unused since
8511 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8512
8513 2011-04-02 Jim Meyering <meyering@redhat.com>
8514
8515 do not dereference NULL upon failed strdup
8516 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8517 (ns_get_family): Likewise.
8518
8519 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8520
8521 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8522
8523 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8524
8525 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8526 later (Bug#8403).
8527
8528 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8529
8530 Add lexical binding.
8531
8532 * window.c (Ftemp_output_buffer_show): New fun.
8533 (Fsave_window_excursion):
8534 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8535
8536 * lread.c (lisp_file_lexically_bound_p): New function.
8537 (Fload): Bind Qlexical_binding.
8538 (readevalloop): Remove `evalfun' arg.
8539 Bind Qinternal_interpreter_environment.
8540 (Feval_buffer): Bind Qlexical_binding.
8541 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8542 Mark as dynamic.
8543 (syms_of_lread): Declare `lexical-binding'.
8544
8545 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8546
8547 * keyboard.c (eval_dyn): New fun.
8548 (menu_item_eval_property): Use it.
8549
8550 * image.c (parse_image_spec): Use Ffunctionp.
8551
8552 * fns.c (concat, mapcar1): Accept byte-code-functions.
8553
8554 * eval.c (Fsetq): Handle lexical vars.
8555 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8556 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8557 (FletX, Flet): Obey lexical binding.
8558 (Fcommandp): Handle closures.
8559 (Feval): New `lexical' arg.
8560 (eval_sub): New function extracted from Feval. Use it almost
8561 everywhere where Feval was used. Look up vars in lexical env.
8562 Handle closures.
8563 (Ffunctionp): Move from subr.el.
8564 (Ffuncall): Handle closures.
8565 (apply_lambda): Remove `eval_flags'.
8566 (funcall_lambda): Handle closures and new byte-code-functions.
8567 (Fspecial_variable_p): New function.
8568 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8569 but without exporting it to Lisp.
8570
8571 * doc.c (Fdocumentation, store_function_docstring):
8572 * data.c (Finteractive_form): Handle closures.
8573
8574 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8575 interactive spec.
8576
8577 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8578 New byte-codes.
8579 (exec_byte_code): New function extracted from Fbyte_code to handle new
8580 calling convention for byte-code-functions. Add new byte-codes.
8581
8582 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8583
8584 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8585
8586 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8587
8588 * xdisp.c (redisplay_internal): Fix prototype.
8589
8590 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8591
8592 * xdisp.c (SCROLL_LIMIT): New macro.
8593 (try_scrolling): Use it when setting scroll_limit.
8594 Limit scrolling to 100 screen lines.
8595 (redisplay_window): Even when falling back on "recentering",
8596 position point in the window according to scroll-conservatively,
8597 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8598
8599 (try_scrolling): When point is above the window, allow searching
8600 as far as scroll_max, or one screenful, to compute vertical
8601 distance from PT to the scroll margin position. This prevents
8602 try_scrolling from unnecessarily failing when
8603 scroll-conservatively is set to a value slightly larger than the
8604 window height. Clean up the case of PT below the margin at bottom
8605 of window: scroll_max can no longer be INT_MAX. When aggressive
8606 scrolling is in use, don't let point enter the opposite scroll
8607 margin as result of the scroll.
8608 (syms_of_xdisp) <scroll-conservatively>: Document the
8609 threshold of 100 lines for never-recentering scrolling.
8610
8611 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8612
8613 * dispextern.h (move_it_by_lines):
8614 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8615 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8616 (message_log_check_duplicate): Remove parameters `prev_bol' and
8617 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8618 (redisplay_internal): Remove parameter `preserve_echo_area',
8619 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8620
8621 * indent.c (Fvertical_motion):
8622 * window.c (window_scroll_pixel_based, Frecenter):
8623 Don't pass `need_y_p' to `move_it_by_lines'.
8624
8625 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8626
8627 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8628 steal a few bits to be more compact.
8629 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8630 Remove unneeded casts.
8631
8632 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8633
8634 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8635
8636 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8637 binding" message (bug#7967).
8638
8639 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8640
8641 Fix more problems found by GCC 4.6.0's static checks.
8642
8643 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8644 Remove unused local var.
8645
8646 * editfns.c (Fmessage_box): Remove unused local var.
8647
8648 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8649 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8650 Omit unused local vars.
8651 * window.c (shrink_windows): Omit unused local var.
8652 * menu.c (digest_single_submenu): Omit unused local var.
8653 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8654 Omit unused local var.
8655
8656 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8657 Don't assume string length fits in int.
8658 (keyremap_step, read_key_sequence): Use size_t for sizes.
8659 (read_key_sequence): Don't check last_real_key_start redundantly.
8660
8661 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8662 instead of alloca (Bug#8344).
8663
8664 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8665 (Fbacktrace_frame): Don't assume nframes fits in int.
8666
8667 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8668
8669 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8670 concerns.
8671
8672 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8673
8674 * cm.c (calccost): Turn while-do into do-while, for clarity.
8675
8676 * keyboard.c (syms_of_keyboard): Use the same style as later
8677 in this function when indexing through an array. This also
8678 works around GCC bug 48267.
8679
8680 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8681
8682 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8683
8684 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8685 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8686
8687 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8688 This avoids undefined behavior on integer overflow, and is a bit
8689 more convenient anyway since it is compared to a size_t variable.
8690
8691 Variadic C functions now count arguments with size_t, not int.
8692 This avoids an unnecessary limitation on 64-bit machines, which
8693 caused (substring ...) to crash on large vectors (Bug#8344).
8694 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8695 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8696 All variadic functions and their callers changed accordingly.
8697 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8698 * data.c (arith_driver, float_arith_driver): Likewise.
8699 * editfns.c (general_insert_function): Likewise.
8700 * eval.c (struct backtrace.nargs, interactive_p)
8701 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8702 (funcall_lambda, mark_backtrace): Likewise.
8703 * fns.c (concat): Likewise.
8704 * frame.c (x_set_frame_parameters): Likewise.
8705 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8706 0 if not found, not -1. All callers changed.
8707
8708 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8709 (stack_copy_size): Now size_t, not int.
8710 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8711
8712 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8713
8714 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8715 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8716 All callers changed.
8717
8718 * lisp.h (multibyte_char_to_unibyte):
8719 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8720 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8721 * character.h (CHAR_TO_BYTE8):
8722 * cmds.c (internal_self_insert):
8723 * editfns.c (general_insert_function):
8724 * keymap.c (push_key_description):
8725 * search.c (Freplace_match):
8726 * xdisp.c (message_dolog, set_message_1): All callers changed.
8727
8728 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8729
8730 * keyboard.c (safe_run_hook_funcall): New function.
8731 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8732 don't set the hook to nil, but remove the offending function instead.
8733 (Qcommand_hook_internal): Remove, unused.
8734 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8735 Vcommand_hook_internal.
8736
8737 * eval.c (enum run_hooks_condition): Remove.
8738 (funcall_nil, funcall_not): New functions.
8739 (run_hook_with_args): Call each function through a `funcall' argument.
8740 Remove `cond' argument, now redundant.
8741 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8742 (Frun_hook_with_args_until_failure): Adjust accordingly.
8743 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8744
8745 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8746
8747 * dispextern.h (string_buffer_position): Remove declaration.
8748
8749 * print.c (strout): Remove parameter `multibyte', unused since
8750 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8751
8752 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8753 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8754 All callers changed.
8755
8756 * w32.c (_wsa_errlist): Use braces for struct initializers.
8757
8758 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8759 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8760 All callers changed.
8761 (string_buffer_position): Likewise. Also, make static (it's never
8762 used outside xdisp.c).
8763 (cursor_row_p): Remove parameter `w', unused since
8764 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8765 (decode_mode_spec): Remove parameter `precision', introduced during
8766 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8767 All callers changed.
8768
8769 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8770
8771 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8772
8773 2011-03-27 Anders Lindgren <andlind@gmail.com>
8774
8775 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8776 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8777 (ns_update_auto_hide_menu_bar): New functions.
8778 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8779 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8780 ns_constrain_all_frames.
8781 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8782 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8783
8784 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8785
8786 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8787
8788 2011-03-27 Glenn Morris <rgm@gnu.org>
8789
8790 * syssignal.h: Replace RETSIGTYPE with void.
8791 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8792 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8793 Replace SIGTYPE with void everywhere.
8794 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8795 * s/template.h (SIGTYPE): Remove commented out definition.
8796
8797 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8798
8799 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8800 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8801
8802 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8803
8804 * w32.c (read_unc_volume): Use parameter `henum', instead of
8805 global variable `wget_enum_handle'.
8806
8807 * keymap.c (describe_vector): Remove parameters `indices' and
8808 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8809 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8810
8811 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8812
8813 * keyboard.c (timer_check): Remove parameter `do_it_now',
8814 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8815 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8816 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8817
8818 * keyboard.c (read_char):
8819 * w32menu.c (w32_menu_display_help):
8820 * xmenu.c (show_help_event, menu_help_callback):
8821 Adjust calls to `show_help_echo'.
8822
8823 * gtkutil.c (xg_maybe_add_timer):
8824 * keyboard.c (readable_events):
8825 * process.c (wait_reading_process_output):
8826 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8827
8828 * insdel.c (adjust_markers_gap_motion):
8829 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8830 (gap_left, gap_right): Don't call it.
8831
8832 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8833
8834 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8835 incurred during fontification.
8836
8837 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8838
8839 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8840 (DEFVAR_PER_BUFFER): Don't pass it.
8841
8842 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8843 (scrolling_window): Don't pass it.
8844
8845 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8846
8847 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8848
8849 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8850 and `suffix'.
8851 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8852 of variables specific to SELinux and computation of `encoded_absname'.
8853
8854 * image.c (XPutPixel): Remove unused variable `height'.
8855
8856 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8857
8858 * unexw32.c (get_section_info): Remove unused variable `section'.
8859
8860 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8861 (system_process_attributes): Remove unused variable `sess'.
8862 (sys_read): Remove unused variable `err'.
8863
8864 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8865 (w32_wnd_proc): Remove unused variable `isdead'.
8866 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8867 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8868 (x_create_tip_frame): Remove unused variable `tem'.
8869
8870 * w32inevt.c (w32_console_read_socket):
8871 Remove unused variable `no_events'.
8872
8873 * w32term.c (x_draw_composite_glyph_string_foreground):
8874 Remove unused variable `width'.
8875
8876 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8877
8878 * w32term.c (x_set_glyph_string_clipping):
8879 Don't pass uninitialized region to CombineRgn.
8880
8881 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8882
8883 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8884 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8885 (Fx_close_connection): Remove unused variable `i'.
8886
8887 * w32font.c (w32font_draw): Return number of glyphs.
8888 (w32font_open_internal): Remove unused variable `i'.
8889 (w32font_driver): Add missing initializer.
8890
8891 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8892 (fill_in_menu): Remove unused variable `items_added'.
8893
8894 * w32term.c (last_mouse_press_frame): Remove static global variable.
8895 (w32_clip_to_row): Remove unused variable `f'.
8896 (x_delete_terminal): Remove unused variable `i'.
8897
8898 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8899 (NOTHING): Remove unused static global variable.
8900 (uniscribe_check_otf): Remove unused variable `table'.
8901 (uniscribe_font_driver): Add missing initializers.
8902
8903 2011-03-23 Julien Danjou <julien@danjou.info>
8904
8905 * term.c (Fsuspend_tty, Fresume_tty):
8906 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8907 * window.c (temp_output_buffer_show):
8908 * insdel.c (signal_before_change):
8909 * frame.c (Fhandle_switch_frame):
8910 * fileio.c (Fdo_auto_save):
8911 * emacs.c (Fkill_emacs):
8912 * editfns.c (save_excursion_restore):
8913 * cmds.c (internal_self_insert):
8914 * callint.c (Fcall_interactively):
8915 * buffer.c (Fkill_all_local_variables):
8916 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8917 Use Frun_hooks.
8918 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8919 unconditionally since it does the check itself.
8920
8921 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8922
8923 Fix more problems found by GCC 4.5.2's static checks.
8924
8925 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8926 the first time through the loop, since we know p0 < p1 then.
8927 This also avoids a gcc -Wstrict-overflow warning.
8928
8929 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8930 leading to a memory leak, possible in functions like
8931 load_charset_map_from_file that can allocate an unbounded number
8932 of objects (Bug#8318).
8933
8934 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8935 that could (at least in theory) be that large.
8936
8937 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8938 This is less likely to overflow, and avoids undefined behavior if
8939 overflow does occur. All callers changed. Use strtoul to scan
8940 for the unsigned long integer.
8941 (pint2hrstr): Simplify and tune code slightly.
8942 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8943
8944 * scroll.c (do_scrolling): Work around GCC bug 48228.
8945 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8946
8947 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8948 This also avoids a warning with gcc -Wstrict-overflow.
8949 (validate_x_resource_name): Simplify count usage.
8950 This also avoids a warning with gcc -Wstrict-overflow.
8951
8952 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8953 fail (Bug#8306).
8954
8955 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8956
8957 * process.c (Fmake_network_process): Use socklen_t, not int,
8958 where POSIX says socklen_t is required in portable programs.
8959 This fixes a porting bug on hosts like 64-bit HP-UX, where
8960 socklen_t is wider than int (Bug#8277).
8961 (Fmake_network_process, server_accept_connection):
8962 (wait_reading_process_output, read_process_output):
8963 Likewise.
8964
8965 * process.c: Rename or move locals to avoid shadowing.
8966 (list_processes_1, Fmake_network_process):
8967 (read_process_output_error_handler, exec_sentinel_error_handler):
8968 Rename or move locals.
8969 (Fmake_network_process): Define label "retry_connect" only if needed.
8970 (Fnetwork_interface_info): Fix pointer signedness.
8971 (process_send_signal): Add cast to avoid pointer signedness problem.
8972 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8973 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8974
8975 Make tparam.h and terminfo.c consistent.
8976 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8977 Include tparam.h instead, since it declares them.
8978 * cm.h (PC): Remove extern decl; tparam.h now does this.
8979 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8980 * terminfo.c: Include tparam.h, to check interfaces.
8981 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8982 (tparam): Adjust signature to match interface in tparam.h;
8983 this removes some undefined behavior. Check that outstring and len
8984 are zero, which they always are with Emacs.
8985 * tparam.h (PC, BC, UP): New extern decls.
8986
8987 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8988 (xftfont_open): Rename locals to avoid shadowing.
8989
8990 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8991 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8992 (OTF_TAG_SYM): Omit macro if not needed.
8993 (ftfont_list): Remove unused local.
8994 (get_adstyle_property, ftfont_pattern_entity):
8995 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8996 Rename locals to avoid shadowing.
8997
8998 * xfont.c (xfont_list_family): Mark var as initialized.
8999
9000 * xml.c (make_dom): Now static.
9001
9002 * composite.c (composition_compute_stop_pos): Rename local to
9003 avoid shadowing.
9004 (composition_reseat_it): Remove unused locals.
9005 (find_automatic_composition, composition_adjust_point): Likewise.
9006 (composition_update_it): Mark var as initialized.
9007 (find_automatic_composition): Mark vars as initialized,
9008 with a FIXME (Bug#8290).
9009
9010 character.h: Rename locals to avoid shadowing.
9011 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9012 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9013 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9014 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9015 to avoid shadowing.
9016
9017 * textprop.c (property_change_between_p): Remove; unused.
9018
9019 * intervals.c (interval_start_pos): Now static.
9020
9021 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9022
9023 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9024 Rename locals to avoid shadowing.
9025
9026 * sound.c (wav_play, au_play, Fplay_sound_internal):
9027 Fix pointer signedness.
9028 (alsa_choose_format): Remove unused local var.
9029 (wav_play): Initialize a variable to 0, to prevent undefined
9030 behavior (Bug#8278).
9031
9032 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9033
9034 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9035
9036 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9037 clobbering (Bug#8298).
9038 * sysdep.c (sys_subshell): Likewise.
9039 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9040
9041 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9042 This should get cleaned up, so that child_setup has the
9043 same signature on all platforms.
9044
9045 * callproc.c (call_process_cleanup): Now static.
9046 (relocate_fd): Rename locals to avoid shadowing.
9047
9048 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9049
9050 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9051 not to be necessary, and produces flickering.
9052
9053 2011-03-20 Glenn Morris <rgm@gnu.org>
9054
9055 * config.in: Remove file.
9056
9057 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9058
9059 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9060 are now in src/globals.h.
9061 (syms_of_minibuf): Remove spurious & from previous change.
9062
9063 2011-03-20 Leo Liu <sdl.web@gmail.com>
9064
9065 * minibuf.c (completing-read-function): New variable.
9066 (completing-read-default): Rename from completing-read.
9067 (completing-read): Call completing-read-function.
9068
9069 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9070
9071 * xfaces.c (Fx_load_color_file):
9072 Read color file from absolute filename (bug#8250).
9073
9074 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9075
9076 * makefile.w32-in: Update dependencies.
9077
9078 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9079
9080 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9081
9082 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9083
9084 Fix more problems found by GCC 4.5.2's static checks.
9085
9086 * process.c (make_serial_process_unwind, send_process_trap):
9087 (sigchld_handler): Now static.
9088
9089 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9090 That way, the code declares only the vars that it needs.
9091 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9092 * s/cygwin.h (PTY_ITERATION): Likewise.
9093 * s/darwin.h (PTY_ITERATION): Likewise.
9094 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9095
9096 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9097 * process.c (allocate_pty): Don't declare stb unless it's needed.
9098
9099 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9100 (CONSTANTLIM): Remove; unused.
9101 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9102 Define only if needed.
9103
9104 * unexelf.c (unexec): Name an expression,
9105 to avoid gcc -Wbad-function-cast warning.
9106 Use a different way to cause a compilation error if anyone uses
9107 n rather than nn, a way that does not involve shadowing.
9108 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9109
9110 * deps.mk (unexalpha.o): Remove; unused.
9111
9112 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9113 * unexec.h: New file.
9114 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9115 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9116 Depend on unexec.h.
9117 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9118 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9119 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9120 Change as necessary to match prototype in unexec.h.
9121
9122 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9123 shadowing.
9124 (back_comment, skip_chars): Mark vars as initialized.
9125
9126 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9127 Rename locals to avoid shadowing.
9128
9129 * lread.c (read1): Rewrite so as not to use empty "else".
9130 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9131
9132 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9133
9134 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9135 warning when compiling print.c.
9136
9137 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9138 instead of using an uninitialized var.
9139 (font_sort_entities): Mark var as initialized.
9140
9141 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9142
9143 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9144 pointers to constants.
9145 (font_parse_fcname): Remove unused vars.
9146 (font_delete_unmatched): Now static.
9147 (font_get_spec): Remove; unused.
9148 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9149 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9150 Rename or move locals to avoid shadowing.
9151
9152 * fns.c (require_nesting_list, require_unwind): Now static.
9153 (Ffillarray): Rename locals to avoid shadowing.
9154
9155 * floatfns.c (domain_error2): Define only if needed.
9156 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9157
9158 * alloc.c (mark_backtrace): Move decl from here ...
9159 * lisp.h: ... to here, so that it can be checked.
9160
9161 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9162 (Fdefvar): Rewrite so as not to use empty "else".
9163 (lisp_indirect_variable): Name an expression,
9164 to avoid gcc -Wbad-function-cast warning.
9165 (Fdefvar): Rename locals to avoid shadowing.
9166
9167 * callint.c (quotify_arg, quotify_args): Now static.
9168 (Fcall_interactively): Rename locals to avoid shadowing.
9169 Use const pointer when appropriate.
9170
9171 * lisp.h (get_system_name, get_operating_system_release):
9172 Move decls here, to check interfaces.
9173 * process.c (get_operating_system_release): Move decl to lisp.h.
9174 * xrdb.c (get_system_name): Likewise.
9175 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9176 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9177 some of which prompt warnings from gcc -Wbad-function-cast.
9178 (Fformat_time_string, Fencode_time, Finsert_char):
9179 (Ftranslate_region_internal, Fformat):
9180 Rename or remove local vars to avoid shadowing.
9181 (Ftranslate_region_internal): Mark var as initialized.
9182
9183 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9184 avoid shadowing.
9185
9186 * lisp.h (eassert): Check that the argument compiles, even if
9187 ENABLE_CHECKING is not defined.
9188
9189 * data.c (Findirect_variable): Name an expression, to avoid
9190 gcc -Wbad-function-cast warning.
9191 (default_value, arithcompare, arith_driver, arith_error): Now static.
9192 (store_symval_forwarding): Rename local to avoid shadowing.
9193 (Fmake_variable_buffer_local, Fmake_local_variable):
9194 Mark variables as initialized.
9195 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9196
9197 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9198 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9199 Rename locals to avoid shadowing.
9200 (mark_stack): Move local variables into the #ifdef region where
9201 they're used.
9202 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9203 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9204 needed otherwise.
9205 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9206 (GC_STRING_CHARS): Remove; not used.
9207 (Fmemory_limit): Cast sbrk's returned value to char *.
9208
9209 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9210 avoids undefined behavior in theory.
9211
9212 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9213
9214 Use functions, not macros, for up- and down-casing (Bug#8254).
9215 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9216 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9217 to use the following functions instead of these macros.
9218 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9219 EMACS_INT, since callers assume the returned value fits in int.
9220 (upcase1): Likewise, for UPCASE_TABLE.
9221 (uppercasep, lowercasep, upcase): New static inline functions.
9222 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9223 the race-condition problem in the old DOWNCASE.
9224
9225 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9226 Rename locals to avoid shadowing.
9227 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9228 (regex_compile, re_search_2, re_match_2_internal):
9229 Remove unused local vars.
9230 (FREE_VAR): Rewrite so as not to use empty "else",
9231 which gcc can warn about.
9232 (regex_compile, re_match_2_internal): Mark locals as initialized.
9233 (RETALLOC_IF): Define only if needed.
9234 (WORDCHAR_P): Likewise. This one is never needed, but is used
9235 only in a comment talking about a compiler bug, so put inside
9236 the #if 0 of that comment.
9237 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9238 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9239 Remove; unused.
9240
9241 * search.c (boyer_moore): Rename locals to avoid shadowing.
9242 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9243 (PREV_CHAR_BOUNDARY): Likewise.
9244
9245 * search.c (simple_search): Remove unused var.
9246
9247 * dired.c (compile_pattern): Move decl from here ...
9248 * lisp.h: ... to here, so that it can be checked.
9249 (struct re_registers): New forward decl.
9250
9251 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9252
9253 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9254 All uses changed.
9255 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9256 Rename locals to avoid shadowing.
9257 (Fvertical_motion): Mark locals as initialized.
9258
9259 * casefiddle.c (casify_object, casify_region): Now static.
9260 (casify_region): Mark local as initialized.
9261
9262 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9263
9264 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9265 New macros, so that the caller can use some names other than
9266 gcpro1, gcpro2, etc.
9267 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9268 of the new macros.
9269 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9270 argument, for consistency with GCPRO2_VAR, etc: it is now the
9271 prefix of the variable, not the variable itself. All uses
9272 changed.
9273 * dired.c (directory_files_internal, file_name_completion):
9274 Rename locals to avoid shadowing.
9275
9276 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9277 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9278 dired.c's scmp function, had undefined behavior.
9279 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9280 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9281 * buffer.h: ... to here, because these macros use current_buffer,
9282 and the new implementation with inline functions needs to have
9283 current_buffer in scope now, rather than later when the macros
9284 are used.
9285 (downcase, upcase1): New static inline functions.
9286 (DOWNCASE, UPCASE1): Reimplement using these functions.
9287 This avoids undefined behavior in expressions like
9288 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9289 from race conditions in accessing the global variables
9290 case_temp1 and case_temp2.
9291 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9292 * lisp.h (case_temp1, case_temp2): Remove their decls.
9293 * character.h (ASCII_CHAR_P): Move from here ...
9294 * lisp.h: ... to here, so that the inline functions mentioned
9295 above can use them.
9296
9297 * dired.c (directory_files_internal_unwind): Now static.
9298
9299 * fileio.c (file_name_as_directory, directory_file_name):
9300 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9301 Now static.
9302 (file_name_as_directory): Use const pointers when appropriate.
9303 (Fexpand_file_name): Likewise. In particular, newdir might
9304 point at constant storage, so make it a const pointer.
9305 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9306 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9307 signedness issues.
9308 (Fset_file_times, Finsert_file_contents, auto_save_error):
9309 Rename locals to avoid shadowing.
9310
9311 * minibuf.c (choose_minibuf_frame_1): Now static.
9312 (Ftry_completion, Fall_completions): Rename or remove locals
9313 to avoid shadowing.
9314
9315 * marker.c (bytepos_to_charpos): Remove; unused.
9316
9317 * lisp.h (verify_bytepos, count_markers): New decls,
9318 so that gcc does not warn that these functions aren't declared.
9319
9320 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9321 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9322 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9323 (copy_text): Remove unused local var.
9324
9325 * filelock.c (within_one_second): Now static.
9326 (lock_file_1): Rename local to avoid shadowing.
9327
9328 * buffer.c (fix_overlays_before): Mark locals as initialized.
9329 (fix_start_end_in_overlays): Likewise. This function should be
9330 simplified by using pointers-to-pointers, but that's a different
9331 matter.
9332 (switch_to_buffer_1): Now static.
9333 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9334 (report_overlay_modification): Rename locals to avoid shadowing.
9335
9336 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9337 Fix pointer signedness issue.
9338 (sys_subshell): Mark local as volatile if checking for lint,
9339 to suppress a gcc -Wclobbered warning that does not seem to be right.
9340 (MAXPATHLEN): Define only if needed.
9341
9342 * process.c (serial_open, serial_configure): Move decls from here ...
9343 * systty.h: ... to here, so that they can be checked.
9344
9345 * fns.c (get_random, seed_random): Move extern decls from here ...
9346 * lisp.h: ... to here, so that they can be checked.
9347
9348 * sysdep.c (reset_io): Now static.
9349 (wait_for_termination_signal): Remove; unused.
9350
9351 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9352 (copy_keymap_item, append_key, push_text_char_description):
9353 Now static.
9354 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9355 (DENSE_TABLE_SIZE): Remove; unused.
9356 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9357 (describe_map_tree):
9358 Rename locals to avoid shadowing.
9359
9360 * keyboard.c: Declare functions static if they are not used elsewhere.
9361 (echo_char, echo_dash, cmd_error, top_level_2):
9362 (poll_for_input, handle_async_input): Now static.
9363 (read_char, kbd_buffer_get_event, make_lispy_position):
9364 (make_lispy_event, make_lispy_movement, apply_modifiers):
9365 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9366 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9367 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9368 (read_key_sequence, read_char): Mark locals as initialized.
9369 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9370
9371 * keyboard.h (make_ctrl_char): New decl.
9372 (mark_kboards): Move decl here ...
9373 * alloc.c (mark_kboards): ... from here.
9374
9375 * lisp.h (force_auto_save_soon): New decl.
9376
9377 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9378 (DEFINE_DUMMY_FUNCTION): New macro.
9379 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9380 Use it.
9381 (main): Add casts to avoid warnings
9382 if GCC considers string literals to be constants.
9383
9384 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9385
9386 * dbusbind.c: Pointer signedness fixes.
9387 (xd_signature, xd_append_arg, xd_initialize):
9388 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9389 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9390 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9391 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9392
9393 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9394 if GCC considers string literals to be constants.
9395 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9396
9397 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9398
9399 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9400 (print_preprocess, print_object): New macro to fix last change.
9401
9402 * print.c (print_preprocess): Don't forget font objects.
9403
9404 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9405
9406 * emacs.c (USAGE3): Doc fixes.
9407
9408 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9409
9410 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9411 structure.
9412
9413 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9414
9415 * lisp.h (VWindow_system, Qfile_name_history):
9416 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9417 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9418 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9419
9420 * w32select.c: Don't #include "keyboard.h".
9421 (run_protected): Add extern declaration for waiting_for_input.
9422
9423 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9424 * w32console.c (detect_input_pending, read_input_pending)
9425 (encode_terminal_code):
9426 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9427 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9428 (w32_system_caret_y, Qfile_name_history):
9429 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9430 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9431 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9432 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9433 * w32proc.c (Qlocal, report_file_error):
9434 * w32term.c (Vwindow_system, updating_frame):
9435 * w32uniscribe.c (initialized, uniscribe_font_driver):
9436 Remove unneeded extern declarations.
9437
9438 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9439
9440 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9441
9442 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9443
9444 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9445 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9446 These macros can no longer be used for assignment.
9447
9448 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9449 Assign struct members directly, instead of using BUF_BEGV etc.
9450 (record_buffer_markers, fetch_buffer_markers): New functions for
9451 recording and fetching special buffer markers.
9452 (set_buffer_internal_1, set_buffer_temp): Use them.
9453
9454 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9455
9456 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9457
9458 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9459 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9460
9461 * xdisp.c (hscroll_window_tree):
9462 (reconsider_clip_changes): Use PT instead of BUF_PT.
9463
9464 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9465
9466 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9467 $(EMACS_ROOT)/lib/intprops.h.
9468
9469 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9470
9471 Fix more problems found by GCC 4.5.2's static checks.
9472
9473 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9474 to unsigned char * to avoid compiler diagnostic.
9475 (xg_free_frame_widgets): Make it clear that a local variable is
9476 needed only if USE_GTK_TOOLTIP.
9477 (gdk_window_get_screen): Make it clear that this macro is needed
9478 only if USE_GTK_TOOLTIP.
9479 (int_gtk_range_get_value): New function, which avoids a diagnostic
9480 from gcc -Wbad-function-cast.
9481 (xg_set_toolkit_scroll_bar_thumb): Use it.
9482 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9483 diagnostic from gcc -Wbad-function-cast.
9484 (get_utf8_string, xg_get_file_with_chooser):
9485 Rename locals to avoid shadowing.
9486 (create_dialog): Move locals to avoid shadowing.
9487
9488 * xgselect.c (xg_select): Remove unused var.
9489
9490 * image.c (four_corners_best): Mark locals as initialized.
9491 (gif_load): Initialize transparent_p to zero (Bug#8238).
9492 Mark another local as initialized.
9493 (my_png_error, my_error_exit): Mark with NO_RETURN.
9494
9495 * image.c (clear_image_cache): Now static.
9496 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9497 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9498 (x_edge_detection): Remove unnecessary cast that
9499 gcc -Wbad-function-cast diagnoses.
9500 (gif_load): Fix pointer signedness.
9501 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9502 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9503
9504 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9505
9506 Improve quality of tests for time stamp overflow.
9507 For example, without this patch (encode-time 0 0 0 1 1
9508 1152921504606846976) returns the obviously-bogus value (-948597
9509 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9510 reports time overflow. See
9511 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9512 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9513 * editfns.c: Include limits.h and intprops.h.
9514 (TIME_T_MIN, TIME_T_MAX): New macros.
9515 (time_overflow): Move earlier, to before first use.
9516 (hi_time, lo_time): New functions, for an accurate test for
9517 out-of-range times.
9518 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9519 (Fget_internal_run_time): Don't assume time_t fits in int.
9520 (make_time): Use list2 instead of Fcons twice.
9521 (Fdecode_time): More accurate test for out-of-range times.
9522 (check_tm_member): New function.
9523 (Fencode_time): Use it, to test for out-of-range times.
9524 (lisp_time_argument): Don't rely on undefined left-shift and
9525 right-shift behavior when checking for time stamp overflow.
9526
9527 * editfns.c (time_overflow): New function, refactoring common code.
9528 (Fformat_time_string, Fdecode_time, Fencode_time):
9529 (Fcurrent_time_string): Use it.
9530
9531 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9532 * dired.c (make_time): Move to ...
9533 * editfns.c (make_time): ... here.
9534 * systime.h: Note the move.
9535
9536 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9537
9538 * fringe.c (update_window_fringes): Remove unused variables.
9539
9540 * unexmacosx.c (copy_data_segment): Also copy __got section.
9541 (Bug#8223)
9542
9543 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9544
9545 * termcap.c [MSDOS]: Include "msdos.h".
9546 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9547 Constify `char *' arguments and their references according to
9548 prototypes in tparam.h.
9549
9550 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9551
9552 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9553 Adapt all references accordingly.
9554
9555 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9556
9557 2011-03-11 Tom Tromey <tromey@redhat.com>
9558
9559 * buffer.c (syms_of_buffer): Remove obsolete comment.
9560
9561 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9562
9563 * termhooks.h (encode_terminal_code): Declare prototype.
9564
9565 * msdos.c (encode_terminal_code): Don't declare prototype.
9566
9567 * term.c (encode_terminal_code): Now external again, used by
9568 w32console.c and msdos.c.
9569
9570 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9571 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9572
9573 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9574
9575 Fix some minor problems found by GCC 4.5.2's static checks.
9576
9577 * fringe.c (update_window_fringes): Mark locals as initialized
9578 (Bug#8227).
9579 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9580
9581 * alloc.c (mark_fringe_data): Move decl from here ...
9582 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9583 to check its interface.
9584 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9585
9586 * fontset.c (free_realized_fontset): Now static.
9587 (Fset_fontset_font): Rename local to avoid shadowing.
9588 (fontset_font): Mark local as initialized.
9589 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9590
9591 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9592
9593 * xselect.c (x_disown_buffer_selections): Remove; not used.
9594 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9595 (x_own_selection, Fx_disown_selection_internal): Rename locals
9596 to avoid shadowing.
9597 (x_handle_dnd_message): Remove local to avoid shadowing.
9598
9599 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9600 so that the caller can use some name other than gcpro1.
9601 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9602 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9603 (Fx_backspace_delete_keys_p):
9604 Use them to avoid shadowing, and rename vars to avoid shadowing.
9605 (x_decode_color, x_set_name, x_window): Now static.
9606 (Fx_create_frame): Add braces to silence GCC warning.
9607 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9608 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9609 Remove unused locals.
9610 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9611 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9612 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9613 macros.
9614
9615 * xterm.h (x_mouse_leave): New decl.
9616
9617 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9618 Remove unused functions.
9619 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9620 (x_calc_absolute_position): Now static.
9621 (XTread_socket): Don't define label "out" unless it's used.
9622 Don't declare local "event" unless it's used.
9623 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9624 unless they are used.
9625 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9626 (x_fatal_error_signal): Remove; not used.
9627 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9628 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9629 (x_error_catcher, x_connection_closed, x_error_handler):
9630 (x_error_quitter, xembed_send_message, x_iconify_frame):
9631 (my_log_handler): Rename locals to avoid shadowing.
9632 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9633 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9634
9635 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9636 Rename or move locals to avoid shadowing.
9637 (tty_defined_color, merge_face_heights): Now static.
9638 (free_realized_faces_for_fontset): Remove; not used.
9639 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9640 does not deduce is never used uninitialized.
9641 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9642 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9643
9644 * terminal.c (store_terminal_param): Now static.
9645
9646 * xmenu.c (menu_highlight_callback): Now static.
9647 (set_frame_menubar): Remove unused local.
9648 (xmenu_show): Rename parameter to avoid shadowing.
9649 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9650 since they might point to immutable storage.
9651 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9652 since it's unused otherwise.
9653
9654 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9655 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9656 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9657 avoids a gcc -Wuninitialized diagnostic.
9658 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9659 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9660 does not deduce are never used uninitialized.
9661
9662 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9663
9664 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9665 * window.c (window_loop, size_window):
9666 (run_window_configuration_change_hook, enlarge_window): Likewise.
9667
9668 * window.c (display_buffer): Now static.
9669 (size_window): Mark variables that gcc -Wuninitialized
9670 does not deduce are never used uninitialized.
9671 * window.h (check_all_windows): New decl, to forestall
9672 gcc -Wmissing-prototypes diagnostic.
9673 * dispextern.h (bidi_dump_cached_states): Likewise.
9674
9675 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9676 shadowing.
9677 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9678 Include <limits.h>.
9679 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9680 and to avoid gcc -Wuninitialized warning.
9681 (load_charset_map): Mark variables that gcc -Wuninitialized
9682 does not deduce are never used uninitialized.
9683 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9684
9685 * coding.c (coding_set_source, coding_set_destination):
9686 Use "else { /* comment */ }" rather than "else /* comment */;"
9687 for clarity, and to avoid gcc -Wempty-body warning.
9688 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9689 a block, when the outer 'i' will do.
9690 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9691 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9692 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9693 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9694 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9695 Rename locals to avoid shadowing.
9696 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9697 * coding.c (emacs_mule_char, encode_invocation_designation):
9698 Now static, since they're not used elsewhere.
9699 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9700 (decode_coding_object, encode_coding_object, detect_coding_system):
9701 (decode_coding_emacs_mule): Mark variables that gcc
9702 -Wuninitialized does not deduce are never used uninitialized.
9703 (detect_coding_iso_2022): Initialize a local variable that might
9704 be used uninitialized. Leave a FIXME because it's not clear that
9705 this initialization is needed. (Bug#8211)
9706 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9707 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9708 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9709 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9710 Remove unused macros.
9711
9712 * category.c (hash_get_category_set): Remove unused local var.
9713 (copy_category_table): Now static, since it's not used elsewhere.
9714 * character.c (string_count_byte8): Likewise.
9715
9716 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9717 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9718
9719 * chartab.c (copy_sub_char_table): Now static, since it's not used
9720 elsewhere.
9721 (sub_char_table_ref_and_range, char_table_ref_and_range):
9722 Rename locals to avoid shadowing.
9723 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9724
9725 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9726 (BIDI_BOB): Remove unused macro.
9727
9728 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9729 deduce are never used uninitialized.
9730 * term.c (encode_terminal_code): Likewise.
9731
9732 * term.c (encode_terminal_code): Now static. Remove unused local.
9733
9734 * tparam.h: New file.
9735 * term.c, tparam.h: Include it.
9736 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9737 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9738 Move these decls to tparam.h, and make them agree with what
9739 is actually in tparam.c. The previous trick of using incompatible
9740 decls in different modules does not conform to the C standard.
9741 All callers of tparam changed to use tparam's actual API.
9742 * tparam.c (tparam1, tparam, tgoto):
9743 Use const pointers where appropriate.
9744
9745 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9746 * cm.h (struct cm): Likewise.
9747 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9748 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9749 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9750 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9751 (turn_on_face, init_tty): Likewise.
9752 * termchar.h (struct tty_display_info): Likewise.
9753
9754 * term.c (term_mouse_position): Rename local to avoid shadowing.
9755
9756 * alloc.c (mark_ttys): Move decl from here ...
9757 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9758
9759 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9760
9761 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9762
9763 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9764
9765 * search.c (compile_pattern_1): Remove argument regp, unused since
9766 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9767 (compile_pattern): Don't pass it.
9768
9769 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9770
9771 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9772 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9773 for ! HAVE_GTK3.
9774 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9775
9776 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9777
9778 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9779 gdk_window_get_screen, gdk_window_get_geometry,
9780 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9781 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9782 (xg_get_pixbuf_from_pixmap): New function.
9783 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9784 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9785 Call xg_get_pixbuf_from_pixmap instead of
9786 gdk_pixbuf_get_from_drawable.
9787 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9788 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9789 (xg_check_special_colors): Use GtkStyleContext and its functions
9790 for HAVE_GTK3.
9791 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9792 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9793 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9794 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9795 Call gtk_widget_get_preferred_size.
9796 (xg_frame_resized): gdk_window_get_geometry only takes 5
9797 parameters.
9798 (xg_win_to_widget, xg_event_is_for_menubar):
9799 Call gdk_x11_window_lookup_for_display.
9800 (xg_set_widget_bg): New function.
9801 (delete_cb): New function.
9802 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9803 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9804 (xg_set_background_color): Call xg_set_widget_bg.
9805 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9806 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9807 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9808 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9809 if ! HAVE_GTK3.
9810 (update_frame_tool_bar): Call gtk_widget_hide.
9811 (xg_initialize): Use GDK_KEY_g.
9812
9813 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9814 if ! HAVE_GTK3
9815 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9816
9817 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9818 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9819 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9820
9821 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9822
9823 * w32xfns.c (select_palette): Check success of RealizePalette against
9824 GDI_ERROR, not zero.
9825
9826 See ChangeLog.11 for earlier changes.
9827
9828 ;; Local Variables:
9829 ;; coding: utf-8
9830 ;; End:
9831
9832 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9833
9834 This file is part of GNU Emacs.
9835
9836 GNU Emacs is free software: you can redistribute it and/or modify
9837 it under the terms of the GNU General Public License as published by
9838 the Free Software Foundation, either version 3 of the License, or
9839 (at your option) any later version.
9840
9841 GNU Emacs is distributed in the hope that it will be useful,
9842 but WITHOUT ANY WARRANTY; without even the implied warranty of
9843 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9844 GNU General Public License for more details.
9845
9846 You should have received a copy of the GNU General Public License
9847 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.