1 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3 * nsfont.m (ns_otf_to_script): Fix typo.
5 2011-08-22 Kenichi Handa <handa@m17n.org>
7 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8 extra slot even if the purpose is char-code-property-table.
10 2011-08-23 Eli Zaretskii <eliz@gnu.org>
12 * xdisp.c (redisplay_window): When computing centering_position,
13 account for the height of the header line. (Bug#8874)
15 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
16 instead of CHAR_TO_BYTE. Fixes a crash when a completion
17 candidate is selected by the mouse, and that candidate has a
18 composed character under the mouse.
20 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
21 coordinates reported by pos-visible-in-window-p for a composed
22 character in column zero.
24 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
26 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
28 2011-08-22 Eli Zaretskii <eliz@gnu.org>
30 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
31 consider it a hit if to_charpos is anywhere in the range of the
32 composed buffer positions.
34 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
36 * image.c (gif_load): Don't assume that each subimage has the same
37 dimensions as the base image. Handle disposal method that is
38 "undefined" by the gif spec (Bug#9335).
40 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
42 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
43 (Fcondition_case): Document `debug' symbol in error handler.
45 2011-08-19 Eli Zaretskii <eliz@gnu.org>
47 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
48 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
49 from an Org mode buffer to a Speedbar frame.
51 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
52 a composition, take its buffer position from IT->cmp_it.charpos.
53 Fixes cursor positioning at the beginning of a line that begins
54 with a composed character.
56 2011-08-18 Eli Zaretskii <eliz@gnu.org>
58 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
59 character bidirectional type, use STRONG_L instead. Fixes crashes
60 in a buffer produced by `describe-categories'.
62 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
63 members before the level stack, so they would be saved and
64 restored when copying iterator state. Fixes incorrect reordering
65 around TABs covered by display properties.
67 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
69 * process.c (Fnetwork_interface_list): Correctly determine buffer
72 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
74 * eval.c (internal_condition_case, internal_condition_case_1)
75 (internal_condition_case_2, internal_condition_case_n):
76 Remove unnecessary aborts (Bug#9081).
78 2011-08-17 Eli Zaretskii <eliz@gnu.org>
80 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
81 has no `load' handler, try opening the file locally. (Bug#9311)
83 2011-08-16 Ken Brown <kbrown@cornell.edu>
85 * gmalloc.c: Expand comment.
87 2011-08-16 Eli Zaretskii <eliz@gnu.org>
89 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
90 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
92 2011-08-16 Ken Brown <kbrown@cornell.edu>
94 Fix memory allocation problems in Cygwin build (Bug#9273).
96 * unexcw.c ( __malloc_initialized): Declare external variable.
97 (fixup_executable): Force the dumped emacs to reinitialize malloc.
99 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
101 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
103 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
105 [CYGWIN] (special_realloc): New function.
106 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
107 requests to realloc storage in the static heap.
109 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
111 * bidi.c (bidi_initialize): Remove unused local.
113 2011-08-15 Eli Zaretskii <eliz@gnu.org>
115 * biditype.h: File removed.
117 * bidimirror.h: File removed.
119 * deps.mk (bidi.o): Remove biditype.h and
122 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
125 * dispextern.h: Fix a typo in the comment to bidi_type_t.
127 * chartab.c: Improve commentary for the uniprop_table API.
129 * bidi.c (bidi_paragraph_init): Support zero value of
130 bidi_ignore_explicit_marks_for_paragraph_level.
131 (bidi_initialize): Use uniprop_table instead of including
132 biditype.h and bidimirror.h.
134 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
135 coordinates of the iterator when restoring from ppos_it.
138 2011-08-14 Kenichi Handa <handa@m17n.org>
140 * process.c (create_process): Call setup_process_coding_systems
141 after the pid of the process is set to -1 (Bug#8162).
143 2011-08-14 Eli Zaretskii <eliz@gnu.org>
145 * xdisp.c (move_it_in_display_line_to): Don't invoke
146 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
147 ppos_it. Fixes vertical cursor motion when line beginning is
148 covered by an image. (Bug#9296)
150 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
152 * nsterm.h (ns_run_ascript): Declare.
153 (NSAPP_DATA2_RUNASSCRIPT): Define.
155 * nsfns.m (as_script, as_result, as_status): New static variables.
156 (ns_run_ascript): New function.
157 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
158 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
159 the event loop. Get status from as_status (Bug#7276).
161 * nsterm.m (sendEvent): If event is NSApplicationDefined and
162 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
163 the event loop (Bug#7276).
165 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
167 * gnutls.c (QCgnutls_bootprop_priority)
168 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
169 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
170 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
171 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
172 (QCgnutls_bootprop_verify_hostname_error)
173 (QCgnutls_bootprop_callbacks_verify): Rename from
174 Qgnutls_bootprop_..., all uses changed.
176 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
179 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
181 * xfaces.c (Qframe_set_background_mode): Now static.
182 * dispextern.h (Qframe_set_background_mode): Remove decl.
184 * process.c (Fnetwork_interface_info): Declare local only if needed.
186 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
188 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
189 (Fnetwork_interface_list): Allocate in increments of bytes instead
190 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
191 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
193 (struct ifflag_def): notrailers is smart on OSX.
194 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
195 Get hardware address with getifaddrs if available.
197 2011-08-12 Eli Zaretskii <eliz@gnu.org>
199 * xdisp.c (iterate_out_of_display_property): xassert that
200 IT->position is set to within IT->object's boundaries. Break from
201 the loop as soon as EOB is reached; avoids infloops in redisplay
202 when IT->position is set up wrongly due to some bug.
203 Set IT->current to match the bidi iterator unconditionally.
204 (push_display_prop): Allow GET_FROM_STRING as IT->method on
205 entry. Force push_it to save on the stack the current
206 buffer/string position, to be restored by pop_it. Fix flags in
207 the iterator structure wrt the object coming from a display
208 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
209 properties. (Bug#9284)
211 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
213 * fontset.c (fontset_get_font_group): Add proper type checks.
216 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
218 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
219 and LC_VERSION_MIN_MACOSX.
220 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
221 (dump_it) [LC_FUNCTION_STARTS]: Use it.
223 2011-08-08 Eli Zaretskii <eliz@gnu.org>
225 * xdisp.c (forward_to_next_line_start): Allow to use the
226 no-display-properties-and-no-overlays under bidi display.
227 Set disp_pos in the bidi iterator to avoid searches for display
228 properties and overlays.
230 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
232 * editfns.c (Fset_time_zone_rule): Document relationship with the
235 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
236 the font entity extracted from the cache (Bug#8109).
238 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
240 * composite.c (autocmp_chars): Don't reset point. That is done by
241 restore_point_unwind (Bug#5984).
243 2011-08-07 Juri Linkov <juri@jurta.org>
245 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
246 to show the arg `TIME' instead of `TIMEVAL'.
248 2011-08-06 Eli Zaretskii <eliz@gnu.org>
250 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
251 display property strides EOL and includes a newline, as in
252 longlines-mode. (Bug#9254)
253 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
254 word-wrap under bidirectional display. (Bug#9224)
256 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
257 is non-zero, even if the data buffer is NULL. Fixes a crash in
258 vertical-motion with longlines-mode. (Bug#9254)
260 2011-08-05 Eli Zaretskii <eliz@gnu.org>
262 * bidi.c <bidi_cache_total_alloc>: Now static.
263 (bidi_initialize): Initialize bidi_cache_total_alloc.
265 * xdisp.c (display_line): Release buffer allocated for shelved bidi
268 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
269 amount allocated this far in `bidi_cache_total_alloc'.
270 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
271 non-zero, only free the data buffer without restoring the cache
272 contents. All callers changed.
274 * dispextern.h (bidi_unshelve_cache): Update prototype.
276 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
277 (move_it_in_display_line, move_it_to)
278 (move_it_vertically_backward, move_it_by_lines): Replace the call
279 to xfree to an equivalent call to bidi_unshelve_cache.
280 (move_it_in_display_line_to): Fix logic of returning
281 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
283 2011-08-05 Eli Zaretskii <eliz@gnu.org>
285 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
286 came from a string character with a `cursor' property. (Bug#9229)
288 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
290 * Makefile.in (LIB_PTHREAD): New variable.
291 (LIBES): Add LIB_PTHREAD (Bug#9216).
293 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
294 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
296 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
298 * regex.c (re_iswctype): Remove some redundant boolean
301 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
303 * xterm.c (x_find_topmost_parent): New function.
304 (x_set_frame_alpha): Find topmost parent window with
305 x_find_topmost_parent and set the property there also (bug#9181).
306 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
308 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
310 * callproc.c (Fcall_process): Avoid vfork clobbering
311 the local vars buffer, coding_systems, current_dir.
313 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
315 * keymap.c (Fmake_composed_keymap): Move to subr.el.
317 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
319 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
320 so that it is not optimized away.
322 * xdisp.c (compute_display_string_pos): Remove unused local.
324 2011-08-02 Eli Zaretskii <eliz@gnu.org>
326 Fix slow cursor motion and scrolling in large buffers with
327 selective display, like Org Mode buffers. (Bug#9218)
329 * dispextern.h (struct bidi_it): New member disp_prop_p.
331 * xdisp.c: Remove one-slot cache of display string positions.
332 (compute_display_string_pos): Accept an additional argument
333 DISP_PROP_P; callers changed. Scan at most 5K characters forward
334 for a display string or property. If found, set DISP_PROP_P
337 * bidi.c (bidi_fetch_char): Accept an additional argument
338 DISP_PROP_P, and pass it to compute_display_string_pos.
339 Only handle text covered by a display string if DISP_PROP_P is returned
340 non-zero. All callers of bidi_fetch_char changed.
342 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
344 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
346 2010-12-03 Don March <don@ohspite.net>
348 * keymap.c (Fdefine_key): Fix non-prefix key error message when
349 last character M-[char] is translated to ESC [char] (bug#7541).
351 2011-08-02 Kenichi Handa <handa@m17n.org>
353 * lisp.h (uniprop_table): Extern it.
355 * chartab.c (uniprop_table): Make it non-static.
357 2011-08-01 Eli Zaretskii <eliz@gnu.org>
359 * xdisp.c (forward_to_next_line_start): Accept additional argument
360 BIDI_IT_PREV, and store into it the state of the bidi iterator had
362 (reseat_at_next_visible_line_start): Use the bidi iterator state
363 returned by forward_to_next_line_start to restore the state of
364 it->bidi_it after backing up to previous newline. (Bug#9212)
366 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
368 * regex.c (re_comp): Protoize.
369 (re_exec): Fix return type.
370 (regexec): Fix type of `ret'. (Bug#9203)
372 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
374 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
375 This is needed if max-image-size is a floating-point number.
377 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
379 * print.c (print_object): Print empty symbol as ##.
381 * lread.c (read1): Read ## as empty symbol.
383 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
385 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
386 setting frame foreground color (Bug#9175).
387 (x_set_background_color): Likewise.
389 * nsmenu.m (-setText): Size tooltip dimensions precisely to
391 (EmacsTooltip -init): Remove bezels and add shadows to
394 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
395 or scroll bar (Bug#8470).
397 * nsfont.m (nsfont_open): Remove assignment to voffset and
398 unnecessary vars hshink, expand, hd, full_height, min_height.
399 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
401 * nsterm.h (nsfont_info): Remove voffset field.
403 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
405 Implement strike-through and overline on NextStep (Bug#8863).
407 * nsfont.m (nsfont_open): Use underline position provided by font,
408 instead of hard-coded value of 2.
409 (nsfont_draw): Call ns_draw_text_decoration instead.
411 * nsterm.h: Add declaration for ns_draw_text_decoration.
413 * nsterm.m (ns_draw_text_decoration): New function for drawing
414 underline, overline, and strike-through.
415 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
416 ns_draw_text_decoration. Change treatment of cursor drawing to
417 accomodate underlining, etc.
419 2011-07-28 Eli Zaretskii <eliz@gnu.org>
421 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
424 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
426 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
427 Without this fix, if a signal arrives just after memory fills up,
428 'malloc' might be invoked reentrantly.
430 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
431 In other words, assume that every image size is allowed, on non-X
432 hosts. This assumption is probably wrong, but it lets Emacs compile.
434 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
436 * regex.c (re_iswctype): Convert return values to boolean.
438 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
440 * xdisp.c (compute_display_string_pos): Don't use cached display
441 string position if the buffer had its restriction changed.
444 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
446 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
448 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
450 Integer signedness and overflow and related fixes. (Bug#9079)
452 * bidi.c: Integer size and overflow fixes.
453 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
454 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
455 (bidi_cache_find_level_change, bidi_cache_ensure_space)
456 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
457 (bidi_find_other_level_edge):
458 Use ptrdiff_t instead of EMACS_INT where either will do.
459 This works better on 32-bit hosts configured --with-wide-int.
460 (bidi_cache_ensure_space): Check for size-calculation overflow.
461 Use % rather than repeated addition, for better worst-case speed.
462 Don't set bidi_cache_size until after xrealloc returns, because it
464 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
465 (bidi_cache_ensure_space): Also check that the bidi cache size
466 does not exceed that of the largest Lisp string or buffer. See Eli
467 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
469 * alloc.c (__malloc_size_t): Remove.
470 All uses replaced by size_t. See Andreas Schwab's note
471 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
473 * image.c: Improve checking for integer overflow.
474 (check_image_size): Assume that f is nonnull, since
475 it is always nonnull in practice. This is one less thing to
476 worry about when checking for integer overflow later.
477 (x_check_image_size): New function, which checks for integer
478 overflow issues inside X.
479 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
480 This removes the need for a memory_full check.
481 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
482 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
483 (xbm_read_bitmap_data): Change locals back to 'int', since
484 their values must fit in 'int'.
485 (xpm_load_image, png_load, tiff_load):
486 Invoke x_create_x_image_and_pixmap earlier,
487 to avoid much needless work if the image is too large.
488 (tiff_load): Treat overly large images as if
489 x_create_x_image_and_pixmap failed, not as malloc failures.
490 (gs_load): Use x_check_image_size.
492 * gtkutil.c: Omit integer casts.
493 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
494 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
496 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
498 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
499 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
500 would wrongly return t on a 64-bit host.
502 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
503 The plain *_OVERFLOW macros run afoul of GCC bug 49705
504 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
505 and therefore cause GCC to emit a bogus diagnostic in some cases.
507 * image.c: Integer signedness and overflow and related fixes.
508 This is not an exhaustive set of fixes, but it's time to
509 record what I've got.
510 (lookup_pixel_color, check_image_size): Remove redundant decls.
511 (check_image_size): Don't assume that arbitrary EMACS_INT values
512 fit in 'int', or that arbitrary 'double' values fit in 'int'.
513 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
514 (tiff_load, imagemagick_load_image):
515 Check for overflow in size calculations.
516 (x_create_x_image_and_pixmap): Remove unnecessary test for
517 xmalloc returning NULL; that can't happen.
518 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
519 (xpm_color_bucket): Use better integer hashing function.
520 (xpm_cache_color): Don't possibly over-allocate memory.
521 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
523 Use ptrdiff_t, not int or size_t, to record sizes.
524 (png_load): Don't assume values greater than 2**31 fit in 'int'.
525 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
526 either works, as we prefer signed integers.
527 (tiff_read_from_memory, tiff_write_from_memory):
528 Return tsize_t, not size_t, since that's what the TIFF API wants.
529 (tiff_read_from_memory): Don't fail simply because the read would
530 go past EOF; instead, return a short read.
531 (tiff_load): Omit no-longer-needed casts.
532 (Fimagemagick_types): Don't assume size fits into 'int'.
534 Improve hashing quality when configured --with-wide-int.
535 * fns.c (hash_string): New function, taken from sxhash_string.
536 Do not discard information about ASCII character case; this
537 discarding is no longer needed.
538 (sxhash-string): Use it. Change sig to match it. Caller changed.
539 * lisp.h: Declare it.
540 * lread.c (hash_string): Remove, since we now use fns.c's version.
541 The fns.c version returns a wider integer if --with-wide-int is
542 specified, so this should help the quality of the hashing a bit.
544 * emacs.c: Integer overflow minor fix.
545 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
546 Define only if GNU_LINUX.
547 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
549 * dispnew.c: Integer signedness and overflow fixes.
550 Remove unnecessary forward decls, that were a maintenance hassle.
551 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
553 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
554 (scrolling_window): Use ptrdiff_t, not int, for byte count.
555 (prepare_desired_row, line_draw_cost):
556 Use int, not unsigned, where either works.
557 (save_current_matrix, restore_current_matrix):
558 Use ptrdiff_t, not size_t, where either works.
559 (init_display): Check for overflow more accurately, and without
560 relying on undefined behavior.
562 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
563 Remove, replacing with the new symbols in lisp.h. All uses changed.
564 * fileio.c (make_temp_name):
565 * filelock.c (lock_file_1, lock_file):
566 * xdisp.c (message_dolog):
567 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
568 Use pMd etc. instead.
569 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
570 replacing the pWIDE etc. symbols removed from editfns.c.
572 * keyboard.h (num_input_events): Now uintmax_t.
573 This is (very slightly) less likely to mess up due to wraparound.
576 * buffer.c: Integer signedness fixes.
577 (alloc_buffer_text, enlarge_buffer_text):
578 Use ptrdiff_t rather than size_t when either will do, as we prefer
581 * alloc.c: Integer signedness and overflow fixes.
582 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
583 (__malloc_size_t): Default to size_t, not to int.
584 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
585 (Fgarbage_collect, mark_object_loop_halt, mark_object):
586 Prefer ptrdiff_t to size_t when either would do, as we prefer
588 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
589 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
590 Now const. Initialize with values that are in range even if char
592 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
593 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
594 These functions do the right thing with sizes > 2**32.
595 (check_depth): Now ptrdiff_t, not int.
596 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
597 Adjust to new way of storing sizes. Check for size overflow bugs
599 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
600 slightly wrong anyway, as it missed one instance of
601 XMALLOC_OVERRUN_CHECK_OVERHEAD.
602 (refill_memory_reserve): Omit needless cast to size_t.
603 (mark_object_loop_halt): Mark as externally visible.
605 * xselect.c: Integer signedness and overflow fixes.
606 (Fx_register_dnd_atom, x_handle_dnd_message):
607 Use ptrdiff_t, not size_t, since we prefer signed.
608 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
609 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
610 x_dnd_atoms_size and x_dnd_atoms_length.
612 * doprnt.c: Prefer signed to unsigned when either works.
616 * xdisp.c (vmessage):
617 Use ptrdiff_t, not size_t, when using or implementing doprnt,
618 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
619 prefer signed arithmetic to avoid comparison confusion.
620 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
623 Assume freestanding C89 headers, string.h, stdlib.h.
624 * data.c, doprnt.c, floatfns.c, print.c:
625 Include float.h unconditionally.
626 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
627 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
628 * regex.c: Likewise for stddef.h, string.h.
629 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
630 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
631 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
632 (STDC_HEADERS): Remove obsolete defines.
633 * sysdep.c: Include limits.h unconditionally.
635 Assume support for memcmp, memcpy, memmove, memset.
636 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
637 * regex.c (memcmp, memcpy):
638 Remove; we assume C89 now.
640 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
641 (__malloc_safe_bcopy): Remove; no longer needed.
643 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
644 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
645 well either way, and we prefer signed to unsigned.
647 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
649 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
650 closes the connection while we're reading (bug#9182).
652 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
654 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
655 are specified (Bug#9168).
657 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
659 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
660 Found by GCC static checking and --with-wide-int on a 32-bit host.
662 2011-07-25 Eli Zaretskii <eliz@gnu.org>
664 * xdisp.c (compute_display_string_pos): Fix logic of caching
665 previous display string position. Initialize cached_prev_pos to
666 -1. Fixes slow-down at the beginning of a buffer.
668 2011-07-24 Eli Zaretskii <eliz@gnu.org>
670 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
671 for attrs[LFACE_FONTSET_INDEX].
673 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
675 * xml.c (parse_region): Remove unused local
676 that was recently introduced.
678 2011-07-23 Eli Zaretskii <eliz@gnu.org>
680 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
681 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
683 * xdisp.c (move_it_in_display_line_to): Record the best matching
684 position for TO_CHARPOS while scanning the line, and restore it on
685 exit if none of the characters scanned was an exact match.
686 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
687 when exact match is impossible due to invisible text, and the
690 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
692 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
695 2011-07-22 Eli Zaretskii <eliz@gnu.org>
697 Fix a significant slow-down of cursor motion with C-n, C-p,
698 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
699 auto-repeat under bidi redisplay in fontified buffers.
700 * xdisp.c (compute_stop_pos_backwards): New function.
701 (next_element_from_buffer): Call compute_stop_pos_backwards to
702 find a suitable prev_stop when we find ourselves before
704 (reseat): Don't look for prev_stop, as that could mean a very long
706 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
707 <cached_disp_overlay_modiff>: Cache for last found display string
709 (compute_display_string_pos): Return the cached position if asked
710 about the same buffer in the same area of character positions, and
711 the buffer wasn't changed since the time the display string
714 2011-07-22 Eli Zaretskii <eliz@gnu.org>
716 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
717 is an integer, which is important for empty lines. (Bug#9149)
719 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
721 * frame.c (Fmodify_frame_parameters): In tty case, update the
722 default face if necessary (Bug#4238).
724 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
726 * editfns.c (Fstring_to_char): No need to explain what a character
727 is in the docstring (Bug#6576).
729 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
731 * xml.c (parse_region): Make sure we always return a tree.
733 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
735 * xml.c (parse_region): If a document contains only comments,
738 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
740 * xml.c (make_dom): Return comments, too.
742 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
745 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
746 and the surrounding thread.
747 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
748 rather than fgets, and retry after EINTR. Otherwise, 'emacs
749 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
751 * s/openbsd.h (BROKEN_SIGIO): Define.
752 * unexelf.c (unexec) [__OpenBSD__]:
753 Don't update the .mdebug section of the Alpha COFF symbol table.
755 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
757 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
760 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
762 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
763 This fixes some race conditions on the permissions of any newly
766 * alloc.c (valid_pointer_p): Use pipe, not open.
767 This fixes some permissions issues when debugging.
769 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
770 If fchown fails to set both uid and gid, try to set just gid,
771 as that is sometimes allowed. Adjust the file's mode to eliminate
772 setuid or setgid bits that are inappropriate if fchown fails.
774 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
776 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
777 to compare Lisp_Objects.
778 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
779 global_gnutls_log_level, don't mistake it for a Lisp_Object.
780 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
782 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
784 * lread.c (read_integer): Unread even EOF character.
785 (read1): Likewise. Properly record start position of symbol.
787 * lread.c (read1): Read `#:' as empty uninterned symbol if no
788 symbol character follows.
790 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
792 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
793 This works around a problem with the previous change to Fcopy_file.
794 Recent glibc declares fchown with __attribute__((warn_unused_result)),
795 and without this change, GCC might complain about discarding
796 fchown's return value.
798 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
800 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
802 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
804 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
806 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
808 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
809 it's used from the C level.
811 * process.c: Use the same condition for POLL_FOR_INPUT in both
812 keyboard.c and process.c (bug#1858).
814 2011-07-09 Lawrence Mitchell <wence@gmx.li>
816 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
817 (Fgnutls_boot): Use it.
819 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
821 * doc.c (Fsubstitute_command_keys): Revert last change.
823 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
825 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
826 quotes the next character, and doesn't affect other longer
827 sequences (bug#8935).
829 * lread.c (syms_of_lread): Clarify that is isn't only
830 `eval-buffer' and `eval-defun' that's affected by
831 `lexical-binding' (bug#8460).
833 2011-07-15 Eli Zaretskii <eliz@gnu.org>
835 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
836 bidi redisplay when a line includes both an image and is
839 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
841 Fix minor problems found by static checking.
842 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
843 (elsz): Now a signed constant, not a size_t var. We prefer signed
844 types to unsigned, to avoid integer comparison confusion. Without
845 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
846 "cannot optimize loop, the loop counter may overflow", a symptom
848 * indent.c (Fvertical_motion): Mark locals as initialized.
849 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
851 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
853 * search.c (Fre_search_backward): Mention `case-fold-search' in
854 all the re_search_* functions (bug#8138).
856 * keyboard.c (Fopen_dribble_file): Document when the file is
859 2011-07-14 Eli Zaretskii <eliz@gnu.org>
861 * bidi.c (bidi_dump_cached_states): Fix format of displaying
864 Support bidi reordering of display and overlay strings.
865 * xdisp.c (compute_display_string_pos)
866 (compute_display_string_end): Accept additional argument STRING.
867 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
868 (reseat_to_string): Initialize bidi_it->string.s and
869 bidi_it->string.schars.
870 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
871 NULL (avoids a crash in bidi_paragraph_init).
872 Initialize itb.string.lstring.
873 (init_iterator): Call bidi_init_it only of a valid
874 buffer position was specified. Initialize paragraph_embedding to
876 (reseat_to_string): Initialize the bidi iterator.
877 (display_string): If we need to ignore text properties of
878 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
879 original value of -1 will not work with bidi.)
880 (compute_display_string_pos): First arg is now struct
881 `text_pos *'; all callers changed. Support display properties on
883 (compute_display_string_end): Support display properties on Lisp
885 (init_iterator, reseat_1, reseat_to_string): Initialize the
886 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
887 when iterating on a string not from display properties).
888 (compute_display_string_pos, compute_display_string_end):
889 Fix calculation of the object to scan. Fixes an error when using
891 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
892 base_level_stop; instead, set base_level_stop to BEGV.
893 Fixes crashes in vertical-motion.
894 (next_element_from_buffer): Improve commentary for when
895 the iterator is before prev_stop.
896 (init_iterator): Initialize bidi_p from the default value of
897 bidi-display-reordering, not from buffer-local value. Use the
898 buffer-local value only if initializing for buffer iteration.
899 (handle_invisible_prop): Support invisible properties on strings
900 that are being bidi-reordered.
901 (set_iterator_to_next): Support bidi reordering of C strings and
903 (next_element_from_string): Support bidi reordering of Lisp
905 (handle_stop_backwards): Support Lisp strings as well.
906 (display_string): Support display of R2L glyph rows.
907 Use IT_STRING_CHARPOS when displaying from a Lisp string.
908 (init_iterator): Don't initialize it->bidi_p for strings
910 (reseat_to_string): Initialize it->bidi_p for strings here.
911 (next_element_from_string, next_element_from_c_string)
912 (next_element_from_buffer): Add xassert's for correspondence
913 between IT's object being iterated and it->bidi_it.string
915 (face_before_or_after_it_pos): Support bidi iteration.
916 (next_element_from_c_string): Handle the case of the first string
917 character that is not the first one in the visual order.
918 (get_visually_first_element): New function, refactored from common
919 parts of next_element_from_buffer, next_element_from_string, and
920 next_element_from_c_string.
921 (tool_bar_lines_needed, redisplay_tool_bar)
922 (display_menu_bar): Force left-to-right direction. Add a FIXME
923 comment for making that be controlled by a user option.
924 (push_it, pop_it): Save and restore the state of the
925 bidi iterator. Save and restore the bidi_p flag.
926 (pop_it): Iterate out of display property for string iteration as
928 (iterate_out_of_display_property): Support iteration over strings.
929 (handle_single_display_spec): Set up it->bidi_it for iteration
930 over a display string, and call bidi_init_it.
931 (handle_single_display_spec, next_overlay_string)
932 (get_overlay_strings_1, push_display_prop): Set up the bidi
933 iterator for displaying display or overlay strings.
934 (forward_to_next_line_start): Don't use the shortcut if
936 (back_to_previous_visible_line_start): If handle_display_prop
937 pushed the iterator stack, restore the internal state of the bidi
938 iterator by calling bidi_pop_it same number of times.
939 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
940 and we are bidi-iterating, don't decrement the iterator position;
941 instead, set the first_elt flag in the bidi iterator, to produce
943 (reseat_1): Remove redundant setting of string_from_display_prop_p.
944 (push_display_prop): xassert that we are iterating a buffer.
945 (push_it, pop_it): Save and restore paragraph_embedding member.
946 (handle_single_display_spec, next_overlay_string)
947 (get_overlay_strings_1, reseat_1, reseat_to_string)
948 (push_display_prop): Set up the `unibyte' member of bidi_it.string
949 correctly. Don't assume unibyte strings are not bidi-reordered.
950 (compute_display_string_pos)
951 (compute_display_string_end): Fix handling the case of C string.
952 (push_it, pop_it): Save and restore from_disp_prop_p.
953 (handle_single_display_spec, push_display_prop): Set the
954 from_disp_prop_p flag.
955 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
956 (pop_it): Call iterate_out_of_display_property only if we are
957 popping after iteration over a string that came from a display
958 property. Fix a typo in popping stretch info. Add an assertion
959 for verifying that the iterator position is in sync with the bidi
961 (handle_single_display_spec, get_overlay_strings_1)
962 (push_display_prop): Fix initialization of paragraph direction for
963 string when that of the parent object is not yet determined.
964 (reseat_1): Call bidi_init_it to resync the bidi
965 iterator with IT's position. (Bug#7616)
966 (find_row_edges): If ROW->start.pos gives position
967 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
968 (handle_stop, back_to_previous_visible_line_start, reseat_1):
969 Reset the from_disp_prop_p flag.
970 (SAVE_IT, RESTORE_IT): New macros.
971 (pos_visible_p, face_before_or_after_it_pos)
972 (back_to_previous_visible_line_start)
973 (move_it_in_display_line_to, move_it_in_display_line)
974 (move_it_to, move_it_vertically_backward, move_it_by_lines)
975 (try_scrolling, redisplay_window, display_line): Use them when
976 saving a temporary copy of the iterator and restoring it back.
977 (back_to_previous_visible_line_start, reseat_1)
978 (init_iterator): Empty the bidi cache "stack".
979 (move_it_in_display_line_to): If iterator ended up at
980 EOL, but we never saw any buffer positions smaller than
981 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
982 motion in bidi-reordered lines.
983 (move_it_in_display_line_to): Record prev_method and prev_pos
984 immediately before the call to set_iterator_to_next. Fixes cursor
985 motion in bidi-reordered lines with stretch glyphs and strings
986 displayed in margins. (Bug#8133) (Bug#8867)
987 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
989 (pos_visible_p): Support positions in bidi-reordered lines.
990 Save and restore bidi cache.
992 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
993 (bidi_paragraph_info): Delete unused struct.
994 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
995 (bidi_cache_start): New variable.
996 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
998 (bidi_cache_fetch_state, bidi_cache_search)
999 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1000 (bidi_cache_find, bidi_peek_at_next_level)
1001 (bidi_level_of_next_char, bidi_find_other_level_edge)
1002 (bidi_move_to_visually_next): Compare cache index with
1003 bidi_cache_start rather than with zero.
1004 (bidi_fetch_char): Accept new argument STRING; all callers
1005 changed. Support iteration over a string. Support strings with
1006 display properties. Support unibyte strings. Fix the type of
1007 `len' according to what STRING_CHAR_AND_LENGTH expects.
1008 (bidi_paragraph_init, bidi_resolve_explicit_1)
1009 (bidi_resolve_explicit, bidi_resolve_weak)
1010 (bidi_level_of_next_char, bidi_move_to_visually_next):
1011 Support iteration over a string.
1012 (bidi_set_sor_type, bidi_resolve_explicit_1)
1013 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1014 can now be zero (for strings); special values 0 and -1 were
1015 changed to -1 and -2, respectively.
1016 (bidi_char_at_pos): New function.
1017 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1018 Call it instead of FETCH_MULTIBYTE_CHAR.
1019 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1020 initialized to valid values.
1021 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1023 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1024 the test for valid cached positions. Fix the logic for looking up
1025 the sentinel state in the cache. GCPRO the Lisp string we are
1027 (bidi_push_it, bidi_pop_it): New functions.
1028 (bidi_initialize): Initialize the bidi cache start stack pointer.
1029 (bidi_cache_ensure_space): New function, refactored from part of
1030 bidi_cache_iterator_state. Don't assume the required size is just
1031 one BIDI_CACHE_CHUNK away.
1032 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1033 (bidi_count_bytes, bidi_char_at_pos): New functions.
1034 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1035 always valid if bidi_cache_idx is valid.
1036 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1037 is valid if it's going to be used.
1038 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1039 (bidi_cache_fetch_state, bidi_cache_search)
1040 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1041 (bidi_cache_iterator_state, bidi_cache_find)
1042 (bidi_find_other_level_edge, bidi_cache_start_stack):
1043 All variables related to cache indices are now EMACS_INT.
1045 * dispextern.h (struct bidi_string_data): New structure.
1046 (struct bidi_it): New member `string'. Make flag members be 1-bit
1047 fields, and put them last in the struct.
1048 (compute_display_string_pos, compute_display_string_end):
1050 (bidi_push_it, bidi_pop_it): Add prototypes.
1051 (struct iterator_stack_entry): New members bidi_p,
1052 paragraph_embedding, and from_disp_prop_p.
1053 (struct it): Member bidi_p is now a bit field 1 bit wide.
1054 (bidi_shelve_cache, bidi_unshelve_cache):
1057 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1058 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1059 and vector-like objects.
1061 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1062 cache around display iteration.
1064 * window.c (Fwindow_end, window_scroll_pixel_based)
1065 (displayed_window_lines, Frecenter): Save and restore the bidi
1066 cache around display iteration.
1068 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1070 * editfns.c (Fdelete_region): Clarify the use of the named
1071 parameters (bug#6788).
1073 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1075 * indent.c (Fvertical_motion): Set and restore w->pointm when
1076 saving and restoring the window's buffer (Bug#9006).
1078 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1080 * editfns.c (Fstring_to_char): Clarify just what is returned
1081 (bug#6576). Text by Eli Zaretskii.
1083 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1085 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1087 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1089 * buffer.c (mmap_find): Fix a typo.
1091 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1093 Fix execution of x selection hooks.
1094 * xselect.c (Qx_lost_selection_functions)
1095 (Qx_sent_selection_functions): New vars.
1096 (syms_of_xselect): DEFSYM them.
1097 (x_handle_selection_request): Pass Qx_sent_selection_functions
1098 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1099 (x_handle_selection_clear,x_clear_frame_selections):
1100 Pass Qx_lost_selection_functions rather than
1101 Vx_lost_selection_functions to Frun_hook_with_args.
1103 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1105 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1106 The old code sometimes used this field without initializing it.
1108 * alloc.c (gc_sweep): Don't read past end of array.
1109 In theory, the old code could also have corrupted Emacs internals,
1110 though it'd be very unlikely.
1112 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1114 * character.c (Fcharacterp): Don't advertise optional ignored
1115 argument. (Bug#4026)
1117 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1119 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1122 * window.c (Fset_window_start): Doc fix (bug#4199).
1123 (Fset_window_hscroll): Ditto.
1125 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1127 Fix minor new problems caught by GCC 4.6.1.
1128 * term.c (init_tty): Remove unused local.
1129 * xsettings.c (store_monospaced_changed): Define this function only
1130 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1133 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1135 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1137 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1139 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1140 are the mini-buffer and the echo area (bug#3320).
1142 * term.c (init_tty): Remove support for supdup, c10 and perq
1143 terminals, which are no longer supported (bug#1482).
1145 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1147 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1149 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1151 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1152 for non-popups (Bug#3642).
1154 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1156 * alloc.c (reset_malloc_hooks): Protoize.
1157 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1158 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1159 * cm.c (losecursor): Likewise.
1160 * data.c (fmod): Likewise.
1161 * dispnew.c (swap_glyphs_in_rows): Likewise.
1162 * emacs.c (memory_warning_signal): Likewise.
1163 * floatfns.c (float_error): Likewise.
1164 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1165 (otf_open, font_otf_capability, generate_otf_features)
1166 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1168 * image.c (pbm_read_file): Likewise.
1169 * indent.c (string_display_width): Likewise.
1170 * intervals.c (check_for_interval, search_for_interval)
1171 (inc_interval_count, count_intervals, root_interval)
1172 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1173 * lread.c (defalias): Likewise.
1174 * ralloc.c (r_alloc_check): Likewise.
1175 * regex.c (set_image_of_range_1, set_image_of_range)
1176 (regex_grow_registers): Likewise.
1177 * sysdep.c (strerror): Likewise.
1178 * termcap.c (valid_filename_p, tprint, main): Likewise.
1179 * tparam.c (main): Likewise.
1180 * unexhp9k800.c (run_time_remap, save_data_space)
1181 (update_file_ptrs, read_header, write_header, calculate_checksum)
1182 (copy_file, copy_rest, display_header): Likewise.
1183 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1185 * xdisp.c (check_it): Likewise.
1186 * xfaces.c (register_color, unregister_color, unregister_colors):
1188 * xfns.c (print_fontset_result): Likewise.
1189 * xrdb.c (member, fatal, main): Likewise.
1191 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1193 Fix minor problems found by static checking (Bug#9031).
1194 * chartab.c (char_table_set_range, map_sub_char_table):
1195 Remove unused locals.
1196 (uniprop_table): Now static.
1197 * composite.c (_work_char): Remove unused static var.
1199 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1201 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1203 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1205 * gtkutil.c (qttip_cb): Remove code without function.
1207 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1209 * w32.c (pthread_sigmask): New stub.
1211 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1213 Use pthread_sigmask, not sigprocmask (Bug#9010).
1214 sigprocmask is portable only for single-threaded applications, and
1215 Emacs can be multi-threaded when it uses GTK.
1216 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1218 * callproc.c (Fcall_process):
1219 * process.c (create_process):
1220 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1221 Use pthread_sigmask, not sigprocmask.
1223 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1225 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1226 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1229 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1231 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1232 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1233 (xg_hide_tooltip): Fix comment.
1235 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1236 in registerServicesMenuSendTypes.
1237 (validRequestorForSendType): Don't check ns_return_types.
1239 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1242 2011-07-08 Jason Rumney <jasonr@gnu.org>
1244 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1245 frame struct members of non-existent frames (Bug#6284).
1247 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1249 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1250 variable firstTime not needed on OSX >= 10.6.
1251 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1252 >= 10.5. Use setKnobProportion, setDoubleValue.
1254 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1255 (MAC_OS_X_VERSION_10_5): Define if not defined.
1256 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1257 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1258 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1260 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1261 cString and lossyCString on OSX >= 10.4
1263 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1264 sizeToFit on OSX >= 10.2.
1266 * nsimage.m (allocInitFromFile): Don't use deprecated method
1267 bestRepresentationForDevice on OSX >= 10.6.
1269 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1272 * emacs.c: Declare unexec_init_emacs_zone.
1274 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1276 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1278 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1279 on svcsMenu (Bug#8842).
1281 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1283 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1285 * nsterm.m (QUTF8_STRING): Declare.
1286 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1287 (validRequestorForSendType): Return type is (id).
1288 Change indexOfObjectIdenticalTo to indexOfObject.
1289 Check if we have local selection before returning self (Bug#8842).
1290 (writeSelectionToPasteboard): Put local selection into paste board
1291 if we have a local selection (Bug#8842).
1292 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1294 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1295 (ns_get_local_selection): Declare.
1297 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1299 * keymap.c (describe_map_tree): Don't insert a double newline at
1300 the end of the buffer (bug#1169) and return whether we inserted
1303 * callint.c (Fcall_interactively): Change "reading args" to
1304 "providing args" to try to clarify what it does (bug#1010).
1306 2011-07-07 Kenichi Handa <handa@m17n.org>
1308 * composite.c (composition_compute_stop_pos): Ignore a static
1309 composition starting before CHARPOS (Bug#8915).
1311 * xdisp.c (handle_composition_prop): Likewise.
1313 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1315 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1318 2011-07-07 Kenichi Handa <handa@m17n.org>
1320 * character.h (unicode_category_t): New enum type.
1322 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1323 (Qchar_code_property_table): New variable.
1324 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1325 (UNIPROP_COMPRESSED_FORM_P): New macros.
1326 (char_table_ascii): Uncompress the compressed values.
1327 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1328 Uncompress the compressed values.
1329 (sub_char_table_ref_and_range): Likewise.
1330 (char_table_ref_and_range): Uncompress the compressed values.
1331 (sub_char_table_set): New arg is_uniprop. Callers changed.
1332 Uncompress the compressed values.
1333 (sub_char_table_set_range): Args changed. Callers changed.
1334 (char_table_set_range): Adjuted for the above change.
1335 (map_sub_char_table): Delete args default_val and parent. Add arg
1336 top. Give decoded values to a Lisp function.
1337 (map_char_table): Adjust for the above change. Give decoded
1338 values to a Lisp function. Gcpro more variables.
1339 (uniprop_table_uncompress)
1340 (uniprop_decode_value_run_length): New functions.
1341 (uniprop_decoder, uniprop_decoder_count): New variables.
1342 (uniprop_get_decoder, uniprop_encode_value_character)
1343 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1345 (uniprop_encoder, uniprop_encoder_count): New variables.
1346 (uniprop_get_encoder, uniprop_table)
1347 (Funicode_property_table_internal, Fget_unicode_property_internal)
1348 (Fput_unicode_property_internal): New functions.
1349 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1350 Sunicode_property_table_internal, Sget_unicode_property_internal,
1351 and Sput_unicode_property_internal. Defvar_lisp
1352 char-code-property-alist.
1354 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1355 Vunicode_category_table.
1357 * font.c (font_range): Adjust for the change of
1358 Vunicode_category_table.
1360 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1362 * m/iris4d.h: Remove file, move contents ...
1363 * s/irix6-5.h: ... here.
1365 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1367 Remove unportable assumption about struct layout (Bug#8884).
1368 * alloc.c (mark_buffer):
1369 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1370 (clone_per_buffer_values): Don't assume that
1371 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1372 This isn't true in general, and it's particularly not true
1373 if Emacs is configured with --with-wide-int.
1374 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1375 New macros, used in the buffer.c change.
1377 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1379 * xsettings.c: Use both GConf and GSettings if both are available.
1380 (store_config_changed_event): Add comment.
1381 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1382 (store_tool_bar_style_changed): New functions.
1383 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1384 (struct xsettings): Move font inside HAVE_XFT.
1385 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1386 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1387 Move inside HAVE_XFT.
1388 (something_changed_gsettingsCB): Rename from something_changedCB.
1389 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1391 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1392 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1393 (something_changed_gconfCB): Rename from something_changedCB.
1394 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1395 (parse_settings): Move check for font inside HAVE_XFT.
1396 (read_settings, apply_xft_settings): Add comment.
1397 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1398 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1399 call store_font_name_changed.
1400 (xft_settings_event): Add comment.
1401 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1402 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1403 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1404 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1405 (xsettings_initialize): Call init_gsettings last.
1406 (xsettings_get_system_font, xsettings_get_system_normal_font):
1409 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1411 Random fixes. E.g., (random) never returned negative values.
1412 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1413 subseconds part to the entropy, as that's a bit more random.
1414 Prefer signed to unsigned, since the signedness doesn't matter and
1415 in general we prefer signed. When given a limit, use a
1416 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1417 latter isn't right if USE_2_TAGS_FOR_INTS.
1418 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1419 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1421 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1423 * textprop.c (text_property_stickiness):
1424 Obey Vtext_property_default_nonsticky.
1425 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1426 * w32fns.c (syms_of_w32fns):
1427 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1429 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1431 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1432 This is more efficient than Ffile_directory_p and avoids a minor race.
1434 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1436 * buffer.c (Foverlay_put): Say what the return value is
1439 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1440 is a directory before asking whether to use the file name
1442 (barf_or_query_if_file_exists): Make the "File is a directory"
1443 error be more correct.
1445 * fns.c (Frequire): Remove the mention of the .gz files, since
1446 that's installation-specific, but keep the mention of
1447 `get-load-suffixes'.
1449 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1451 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1452 Report string overflow if the output is too long.
1454 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1456 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1457 (syms_of_gnutls): Remove duplicate DEFSYM for
1458 Qgnutls_bootprop_verify_hostname_error, an error for
1459 Qgnutls_bootprop_verify_error (which is no longer used).
1461 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1462 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1463 Also (re)move comments that are misplaced or no longer relevant.
1465 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1467 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1469 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1471 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1472 and background color parameters if they have been changed.
1474 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1476 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1478 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1480 * xsettings.c (SYSTEM_FONT): Define only when used.
1481 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1483 * keymap.c (access_keymap_1): Now static.
1485 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1487 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1488 leave any prefix arg for the up event (Bug#1586).
1490 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1492 * lread.c (syms_of_lread): Mention single symbols defined by
1493 `defvar' or `defconst' (bug#7154).
1495 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1496 (Frequire): Mention get-load-suffixes.
1498 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1500 * window.h (window): Remove clone_number slot.
1501 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1503 (make_parent_window, make_window, saved_window)
1504 (Fset_window_configuration, save_window_save): Don't deal with
1506 * buffer.c (Qclone_number): Remove declaration.
1507 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1509 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1511 Add multiple inheritance to keymaps.
1512 * keymap.c (Fmake_composed_keymap): New function.
1513 (Fset_keymap_parent): Simplify.
1514 (fix_submap_inheritance): Remove.
1515 (access_keymap_1): New function extracted from access_keymap to handle
1516 embedded parents and handle lists of maps.
1517 (access_keymap): Use it.
1518 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1519 (Fcopy_keymap): Handle embedded parents.
1520 (Fcommand_remapping, define_as_prefix): Simplify.
1521 (Fkey_binding): Simplify.
1522 (syms_of_keymap): Move minibuffer-local-completion-map,
1523 minibuffer-local-filename-completion-map,
1524 minibuffer-local-must-match-map, and
1525 minibuffer-local-filename-must-match-map to Elisp.
1526 (syms_of_keymap): Defsubr make-composed-keymap.
1527 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1528 (parse_menu_item): Trivial simplification.
1530 2011-07-01 Glenn Morris <rgm@gnu.org>
1532 * Makefile.in (SETTINGS_LIBS): Fix typo.
1534 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1536 * coding.c (Fencode_coding_string): Record the last coding system
1537 used, as the function doc string says (bug#8738).
1539 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1541 * xsettings.c (store_monospaced_changed): Take new font as arg and
1542 check for change against current_mono_font.
1543 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1544 (emacs_settings_constructor, emacs_settings_get_property)
1545 (emacs_settings_set_property, emacs_settings_class_init)
1546 (emacs_settings_init, gsettings_obj): Remove.
1547 (something_changedCB): New function for HAVE_GSETTINGS.
1548 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1549 with value as argument.
1550 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1551 g_settings_new (Bug#8967). Do not create gsettings_obj.
1552 Remove calls to g_settings_bind. Connect something_changedCB to
1555 * xgselect.c: Add defined (HAVE_GSETTINGS).
1556 (xgselect_initialize): Ditto.
1558 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1559 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1562 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1564 * eval.c (struct backtrace): Simplify and port the data structure.
1565 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1566 signed bit field, as this assumption is not portable and it makes
1567 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1568 "char debug_on_exit : 1" as this is not portable either; instead,
1569 use the portable "unsigned int debug_on_exit : 1". Remove unused
1570 member evalargs. Remove obsolete comments about cc bombing out.
1572 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1574 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1575 Let HAVE_GSETTINGS override HAVE_GCONF.
1576 (store_monospaced_changed): New function.
1577 (EMACS_SETTINGS): A new type derived from GObject to handle
1578 GSettings notifications.
1579 (emacs_settings_constructor, emacs_settings_get_property)
1580 (emacs_settings_set_property, emacs_settings_class_init):
1582 (gsettings_client, gsettings_obj): New variables.
1583 (GSETTINGS_SCHEMA): New define.
1584 (something_changedCB): Call store_monospaced_changed.
1585 (init_gsettings): New function.
1586 (xsettings_initialize): Call init_gsettings.
1587 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1590 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1593 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1595 * window.c (resize_root_window, grow_mini_window)
1596 (shrink_mini_window): Rename Qresize_root_window to
1597 Qwindow_resize_root_window and Qresize_root_window_vertically to
1598 Qwindow_resize_root_window_vertically.
1600 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1602 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1604 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1606 * makefile.w32-in: Redesign dependencies so they reflect more
1607 clearly which files are directly included by each source file,
1608 and not through other includes.
1610 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1612 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1613 (sort_overlays, overlay_strings): When an overlay's clone number
1614 matches the window's clone number process the overlay even if
1615 the overlay's window property doesn't match the current window.
1617 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1618 (Fwindow_hchild): Rename to Fwindow_left_child.
1619 (Fwindow_next): Rename to Fwindow_next_sibling.
1620 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1621 (resize_window_check): Rename to window_resize_check.
1622 (resize_window_apply): Rename to window_resize_apply.
1623 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1624 (Fdelete_other_windows_internal, resize_frame_windows)
1625 (Fsplit_window_internal, Fdelete_window_internal)
1626 (grow_mini_window, shrink_mini_window)
1627 (Fresize_mini_window_internal): Fix callers accordingly.
1629 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1631 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1632 (emacs_fixed_set_min_size): Remove.
1633 (emacs_fixed_new): Take frame as argument.
1635 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1636 (_EmacsFixedPrivate): Remove minwidth/height.
1637 Add struct frame *f.
1638 (emacs_fixed_init): Initialize priv->f.
1639 (get_parent_class, emacs_fixed_set_min_size): Remove.
1640 (emacs_fixed_new): Set priv->f to argument.
1641 (emacs_fixed_get_preferred_width)
1642 (emacs_fixed_get_preferred_height): Use min_width/height from
1643 frames size_hint to set minimum and natural (Bug#8919).
1644 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1645 and use min_width/height from frames size_hint to set
1646 min_width/height (Bug#8919).
1648 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1649 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1652 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1654 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1655 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1658 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1660 * process.c (wait_reading_process_output): Bypass select if
1661 waiting for a cell while ignoring keyboard input, and input is
1662 pending. Suggested by Jan Djärv (Bug#8869).
1664 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1666 Use gnulib's dup2 module instead of rolling our own.
1667 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1669 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1671 * dispnew.c (scrolling_window): Before scrolling, turn off a
1672 mouse-highlight in the window being scrolled.
1674 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1676 Move DEFSYM to lisp.h and use everywhere.
1678 * character.h (DEFSYM): Move declaration...
1679 * lisp.h (DEFSYM): ...here.
1685 * w32select.c: Don't include character.h.
1687 * alloc.c (syms_of_alloc):
1688 * buffer.c (syms_of_buffer):
1689 * bytecode.c (syms_of_bytecode):
1690 * callint.c (syms_of_callint):
1691 * casefiddle.c (syms_of_casefiddle):
1692 * casetab.c (init_casetab_once):
1693 * category.c (init_category_once, syms_of_category):
1694 * ccl.c (syms_of_ccl):
1695 * cmds.c (syms_of_cmds):
1696 * composite.c (syms_of_composite):
1697 * dbusbind.c (syms_of_dbusbind):
1698 * dired.c (syms_of_dired):
1699 * dispnew.c (syms_of_display):
1700 * doc.c (syms_of_doc):
1701 * editfns.c (syms_of_editfns):
1702 * emacs.c (syms_of_emacs):
1703 * eval.c (syms_of_eval):
1704 * fileio.c (syms_of_fileio):
1705 * fns.c (syms_of_fns):
1706 * frame.c (syms_of_frame):
1707 * fringe.c (syms_of_fringe):
1708 * insdel.c (syms_of_insdel):
1709 * keymap.c (syms_of_keymap):
1710 * lread.c (init_obarray, syms_of_lread):
1711 * macros.c (syms_of_macros):
1712 * msdos.c (syms_of_msdos):
1713 * print.c (syms_of_print):
1714 * process.c (syms_of_process):
1715 * search.c (syms_of_search):
1716 * sound.c (syms_of_sound):
1717 * syntax.c (init_syntax_once, syms_of_syntax):
1718 * terminal.c (syms_of_terminal):
1719 * textprop.c (syms_of_textprop):
1720 * undo.c (syms_of_undo):
1721 * w32.c (globals_of_w32):
1722 * window.c (syms_of_window):
1723 * xdisp.c (syms_of_xdisp):
1724 * xfaces.c (syms_of_xfaces):
1725 * xfns.c (syms_of_xfns):
1726 * xmenu.c (syms_of_xmenu):
1727 * xsettings.c (syms_of_xsettings):
1728 * xterm.c (syms_of_xterm): Use DEFSYM.
1730 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1732 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1734 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1736 Integer and buffer overflow fixes (Bug#8873).
1738 * print.c (printchar, strout): Check for string overflow.
1739 (PRINTPREPARE, printchar, strout):
1740 Don't set size unless allocation succeeds.
1742 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1743 for sizes. Check for string overflow more accurately.
1744 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1746 * macros.c: Integer and buffer overflow fixes.
1747 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1748 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1749 Use ptrdiff_t, not int, for sizes.
1750 Don't increment bufsize until after realloc succeeds.
1751 Check for size-calculation overflow.
1752 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1754 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1756 * lread.c: Integer overflow fixes.
1757 (read_integer): Radix is now EMACS_INT, not int,
1758 to improve quality of diagnostics for out-of-range radices.
1759 Calculate buffer size correctly for out-of-range radices.
1760 (read1): Check for integer overflow in radices, and in
1761 read-circle numbers.
1762 (read_escape): Avoid int overflow.
1763 (Fload, openp, read_buffer_size, read1)
1764 (substitute_object_recurse, read_vector, read_list, map_obarray):
1765 Use ptrdiff_t, not int, for sizes.
1766 (read1): Use EMACS_INT, not int, for sizes.
1767 Check for size overflow.
1769 * image.c (cache_image): Check for size arithmetic overflow.
1771 * lread.c: Integer overflow issues.
1772 (saved_doc_string_size, saved_doc_string_length)
1773 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1774 Now ptrdiff_t, not int.
1775 (read1): Don't assume doc string length fits in int. Check for
1776 out-of-range doc string lengths.
1777 (read_list): Don't assume file position fits in int.
1778 (read_escape): Check for hex character overflow.
1780 2011-06-22 Leo Liu <sdl.web@gmail.com>
1782 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1783 Move to minibuffer.el.
1785 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1787 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1788 The following patches are for when GLYPH_DEBUG && !XASSERT.
1789 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1790 * dispnew.c (flush_stdout):
1791 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1792 Mark as externally visible.
1793 * dispnew.c (check_window_matrix_pointers): Now static.
1794 * dispnew.c (window_to_frame_vpos):
1795 * xfns.c (unwind_create_frame):
1796 * xterm.c (x_check_font): Remove unused local.
1797 * scroll.c (CHECK_BOUNDS):
1798 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1799 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1800 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1801 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1802 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1804 (debug_method_add): Use va_list and vsprintf rather than relying
1805 on undefined behavior with wrong number of arguments.
1806 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1807 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1808 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1809 since we're not interested in debugging glyphs with old libraries.
1810 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1811 GCC 4.6.0's static checking.
1813 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1815 Integer overflow and signedness fixes (Bug#8873).
1816 A few related buffer overrun fixes, too.
1818 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1820 * dispextern.h (struct face.stipple):
1821 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1822 (x_bitmap_mask, x_allocate_bitmap_record)
1823 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1824 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1825 (x_create_bitmap_from_xpm_data):
1826 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1827 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1829 * xfaces.c (load_pixmap):
1830 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1831 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1832 (.bitmaps_last, struct x_output.icon_bitmap):
1833 Use ptrdiff_t, not int, for bitmap indexes.
1834 (x_allocate_bitmap_record): Check for size overflow.
1835 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1837 Use ptrdiff_t, not int, for overlay counts.
1838 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1839 * editfns.c (overlays_around, get_pos_property):
1840 * textprop.c (get_char_property_and_overlay):
1841 * xdisp.c (next_overlay_change, note_mouse_highlight):
1842 * xfaces.c (face_at_buffer_position):
1843 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1844 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1845 (Fnext_overlay_change, Fprevious_overlay_change)
1846 (mouse_face_overlay_overlaps, Foverlays_in):
1847 Use ptrdiff_t, not int, for sizes.
1848 (overlays_at, overlays_in): Check for size-calculation overflow.
1850 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1852 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1853 (x_session_initialize): Do not assume string length fits in int.
1855 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1856 This is unlikely, but can occur if DPI is outlandish.
1858 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1859 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1861 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1862 * xrdb.c (magic_file_p, search_magic_path):
1863 Omit last arg SUFFIX; it was always 0. All callers changed.
1864 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1866 * xfont.c (xfont_match): Avoid need for strlen.
1868 * xfns.c: Don't assume strlen fits in int.
1869 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1871 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1872 not unsigned long, as we prefer signed integers. All callers changed.
1873 Detect integer overflow in repeat count.
1874 (message_dolog): Don't assume print length fits in 39 bytes.
1875 (display_mode_element): Don't assume strlen fits in int.
1877 * termcap.c: Don't assume sizes fit in int and never overflow.
1878 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1879 (gobble_line): Check for size-calculation overflow.
1881 * minibuf.c (Fread_buffer):
1882 * lread.c (intern, intern_c_string):
1883 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1884 Don't assume string length fits in int.
1886 * keyboard.c (parse_tool_bar_item):
1887 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1889 * font.c: Don't assume string length fits in int.
1890 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1891 Use ptrdiff_t, not int.
1892 (font_intern_prop): Don't assume string length fits in int.
1893 Don't assume integer property fits in fixnum.
1894 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1896 * filelock.c: Fix some buffer overrun and integer overflow issues.
1897 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1898 Reformulate so as not to need the command string.
1899 Invoke gzip -cd rather than gunzip, as it's more portable.
1900 (lock_info_type, lock_file_1, lock_file):
1901 Don't assume pid_t and time_t fit in unsigned long.
1902 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1903 (current_lock_owner): Prefer signed type for sizes.
1904 Use memcpy, not strncpy, where memcpy is what is really wanted.
1905 Don't assume (via atoi) that time_t and pid_t fit in int.
1906 Check for time_t and/or pid_t out of range, e.g., via a network share.
1907 Don't alloca where an auto var works fine.
1909 * fileio.c: Fix some integer overflow issues.
1910 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1911 Don't assume string length fits in int.
1912 (directory_file_name): Don't assume string length fits in long.
1913 (make_temp_name): Don't assume pid fits in int, or that its print
1914 length is less than 20.
1916 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1918 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1920 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1922 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1923 We prefer signed integers, even for size calculations.
1925 * emacs.c: Don't assume string length fits in 'int'.
1926 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1927 (main): Don't invoke strlen when not needed.
1929 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1930 (XD_DEBUG_MESSAGE): Don't waste a byte.
1932 * callproc.c (getenv_internal_1, getenv_internal)
1934 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1936 * lread.c (invalid_syntax): Omit length argument.
1937 All uses changed. This doesn't fix a bug, but it simplifies the
1938 code away from its former Hollerith-constant appearance, and it's
1939 one less 'int' to worry about when looking at integer-overflow issues.
1940 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1942 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1943 This didn't break anything, but it didn't help either.
1944 It's confusing to put a bogus integer in a place where the actual
1945 value does not matter.
1946 (LIST_END_P): Remove unused macro and its bogus comment.
1947 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1949 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1950 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1952 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1953 We prefer signed types, and the value cannot exceed the EMACS_INT
1954 range anyway (because otherwise the length would not be representable).
1955 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1956 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1957 This avoids a GCC warning when WIDE_EMACS_INT.
1959 * indent.c (sane_tab_width): New function.
1960 (current_column, scan_for_column, Findent_to, position_indentation)
1961 (compute_motion): Use it. This is just for clarity.
1962 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1964 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1966 * lisp.h (lint_assume): New macro.
1967 * composite.c (composition_gstring_put_cache):
1968 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1970 * editfns.c, insdel.c:
1971 Omit unnecessary forward decls, to simplify future changes.
1973 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1975 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1977 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1978 Use much-faster test for byte-length change.
1979 Don't assume string byte-length fits in 'int'.
1980 Check that character arg fits in 'int'.
1981 (mapcar1): Declare byte as byte, for clarity.
1983 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1985 * fns.c (concat): Catch string overflow earlier.
1986 Do not rely on integer wraparound.
1988 * dispextern.h (struct it.overlay_strings_charpos)
1989 (struct it.selective): Now EMACS_INT, not int.
1990 * xdisp.c (forward_to_next_line_start)
1991 (back_to_previous_visible_line_start)
1992 (reseat_at_next_visible_line_start, next_element_from_buffer):
1993 Don't arbitrarily truncate the value of 'selective' to int.
1995 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1997 * composite.c: Don't truncate sizes to 'int'.
1998 (composition_gstring_p, composition_reseat_it)
1999 (composition_adjust_point): Use EMACS_INT, not int.
2000 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2001 not EMACS_UINT, for indexes.
2003 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2005 * buffer.c: Include <verify.h>.
2006 (struct sortvec.priority, struct sortstr.priority):
2007 Now EMACS_INT, not int.
2008 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2009 (struct sortstr.size, record_overlay_string)
2010 (struct sortstrlist.size, struct sortlist.used):
2011 Don't truncate size to int.
2012 (record_overlay_string): Check for size-calculation overflow.
2013 (init_buffer_once): Check at compile-time, not run-time.
2015 2011-06-22 Jim Meyering <meyering@redhat.com>
2017 Don't leak an XBM-image-sized buffer
2018 * image.c (xbm_load): Free the image buffer after using it.
2020 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2023 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2024 that Sun C diagnosed.
2025 * fns.c (secure_hash): Fix pointer signedness issue.
2026 * intervals.c (static_offset_intervals): New function.
2027 (offset_intervals): Use it.
2029 2011-06-21 Leo Liu <sdl.web@gmail.com>
2032 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2035 * fns.c (secure_hash): Rename from crypto_hash_function and change
2036 the first arg to accept symbols.
2037 (Fsecure_hash): New primitive.
2038 (syms_of_fns): New symbols.
2040 2011-06-20 Deniz Dogan <deniz@dogan.se>
2042 * process.c (Fset_process_buffer): Clarify return value in
2045 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2047 * dispnew.c (add_window_display_history): Use BVAR.
2049 * xdisp.c (debug_method_add): Use BVAR.
2050 (check_window_end, dump_glyph_matrix, dump_glyph)
2051 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2053 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2056 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2057 check till after the cache is created in init_frame_faces.
2059 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2061 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2063 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2065 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2066 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2067 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2069 Improve buffer-overflow checking (Bug#8873).
2070 * fileio.c (Finsert_file_contents):
2071 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2072 Remove the old (too-loose) buffer overflow checks.
2073 They weren't needed, since make_gap checks for buffer overflow.
2074 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2075 The old code merely checked for Emacs fixnum overflow, and relied
2076 on undefined (wraparound) behavior. The new code avoids undefined
2077 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2079 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2080 Tune. Don't use wider integers than needed. Don't use alloca.
2081 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2083 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2085 * insdel.c, lisp.h (buffer_overflow): New function.
2086 (insert_from_buffer_1, replace_range, replace_range_2):
2087 * insdel.c (make_gap_larger):
2088 * editfns.c (Finsert_char):
2089 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2091 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2093 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2095 Integer overflow and signedness fixes (Bug#8873).
2097 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2098 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2100 * fileio.c: Don't assume EMACS_INT fits in off_t.
2101 (emacs_lseek): New static function.
2102 (Finsert_file_contents, Fwrite_region): Use it.
2103 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2105 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2107 * fns.c: Don't overflow int when computing a list length.
2108 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2109 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2110 truncation on 64-bit hosts. Check for QUIT every
2111 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2112 faster and is responsive enough.
2113 (Flength): Report an error instead of overflowing an integer.
2114 (Fsafe_length): Return a float if the value is not representable
2115 as a fixnum. This shouldn't happen except in contrived situations.
2116 (Fnthcdr, Fsort): Don't assume list length fits in int.
2117 (Fcopy_sequence): Don't assume vector length fits in int.
2119 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2120 (header_size, word_size): New constants.
2121 (allocate_vectorlike): Don't check size overflow here.
2122 (allocate_vector): Check it here instead, since this is the only
2123 caller of allocate_vectorlike that could cause overflow.
2124 Check that the new vector's length is representable as a fixnum.
2126 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2127 The previous code was bogus. For example, next_almost_prime (32)
2128 returned 39, which is undesirable as it is a multiple of 3; and
2129 next_almost_prime (24) returned 25, which is a multiple of 5 so
2130 why was the code bothering to check for multiples of 7?
2132 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2134 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2136 Variadic C functions now count arguments with ptrdiff_t.
2137 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2138 Back then I didn't know that the Emacs coding style prefers signed int.
2139 Also, in the meantime I found a few more instances where arguments
2140 were being counted with int, which may truncate counts on 64-bit
2141 machines, or EMACS_INT, which may be unnecessarily wide.
2142 * lisp.h (struct Lisp_Subr.function.aMANY)
2143 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2144 Arg counts are now ptrdiff_t, not size_t.
2145 All variadic functions and their callers changed accordingly.
2146 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2147 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2148 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2149 * callint.c (Fcall_interactively): Check arg count for overflow,
2150 to avoid potential buffer overrun. Use signed char, not 'int',
2151 for 'varies' array, so that we needn't bother to check its size
2152 calculation for overflow.
2153 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2154 * eval.c (apply_lambda):
2155 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2156 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2157 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2159 * callint.c (Fcall_interactively): Don't use index var as event count.
2161 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2162 * mem-limits.h (SIZE): Remove; no longer used.
2164 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2166 Remove unnecessary casts.
2167 * xterm.c (x_term_init):
2168 * xfns.c (x_set_border_pixel):
2169 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2170 These aren't needed now that we assume ANSI C.
2172 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2173 It's more likely to cause problems (due to unsigned overflow)
2176 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2178 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2180 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2182 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2184 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2186 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2188 GLYPH_CODE_FACE returns EMACS_INT, not int.
2189 * dispextern.h (merge_faces):
2190 * xfaces.c (merge_faces):
2191 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2192 Don't assume EMACS_INT fits in int.
2194 * character.h (CHAR_VALID_P): Remove unused parameter.
2195 * fontset.c, lisp.h, xdisp.c: All uses changed.
2197 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2199 * fns.c (concat): Minor tuning based on overflow analysis.
2200 This doesn't fix any bugs. Use int to hold character, instead
2201 of constantly refetching from Emacs object. Use XFASTINT, not
2202 XINT, for value known to be a character. Don't bother comparing
2203 a single byte to 0400, as it's always less.
2205 * floatfns.c (Fexpt):
2206 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2208 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2211 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2213 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2214 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2215 incorrectly succeed when S was a string, because 4294967386 was
2216 truncated before it was used.
2218 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2219 Otherwise, an out-of-range integer could cause undefined behavior
2222 * composite.c: Use int, not EMACS_INT, for characters.
2223 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2224 EMACS_INT, for values that are known to be in character range.
2225 This doesn't fix any bugs but is the usual style inside Emacs and
2226 may generate better code on 32-bit machines.
2228 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2229 This is for reasons similar to the recent CHAR_STRING fix.
2230 * charset.c (Fencode_char): Check that character arg is actually
2231 a character. Pass an int to ENCODE_CHAR.
2232 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2233 wider than 'int', as a compile-time check to prevent future regressions
2236 * character.c (char_string): Remove unnecessary casts.
2238 Make sure a 64-bit char is never passed to CHAR_STRING.
2239 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2240 by silently ignoring the top 32 bits, allowing some values
2241 that were far too large to be valid characters.
2242 * character.h: Include <verify.h>.
2243 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2244 arguments are no wider than unsigned, as a compile-time check
2245 to prevent future regressions in this area.
2247 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2248 (Fsubst_char_in_region):
2250 * xdisp.c (decode_mode_spec_coding):
2251 Adjust to CHAR_STRING's new requirement.
2252 * editfns.c (Finsert_char, Fsubst_char_in_region):
2253 * fns.c (concat): Check that character args are actually
2254 characters. Without this test, these functions did the wrong
2255 thing with wildly out-of-range values on 64-bit hosts.
2257 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2258 These casts should not be needed on 32-bit hosts, either.
2259 * keyboard.c (read_char):
2260 * lread.c (Fload): Remove casts to unsigned.
2262 * lisp.h (UNSIGNED_CMP): New macro.
2263 This fixes comparison bugs on 64-bit hosts.
2264 (ASCII_CHAR_P): Use it.
2265 * casefiddle.c (casify_object):
2266 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2267 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2268 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2269 * dispextern.h (FACE_FROM_ID):
2270 * keyboard.c (read_char): Use UNSIGNED_CMP.
2272 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2273 not to EMACS_INT, to avoid GCC warning.
2275 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2277 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2278 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2279 isn't needed on 32-bit machines.
2281 * buffer.c (Fgenerate_new_buffer_name):
2282 Use EMACS_INT for count, not int.
2283 (advance_to_char_boundary): Return EMACS_INT, not int.
2285 * data.c (Qcompiled_function): Now static.
2287 * window.c (window_body_lines): Now static.
2289 * image.c (gif_load): Rename local to avoid shadowing.
2291 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2292 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2293 * alloc.c (make_save_value): Integer argument is now of type
2295 (mark_object): Use ptrdiff_t, not int.
2296 * lisp.h (pD): New macro.
2297 * print.c (print_object): Use it.
2299 * alloc.c: Use EMACS_INT, not int, to count objects.
2300 (total_conses, total_markers, total_symbols, total_vector_size)
2301 (total_free_conses, total_free_markers, total_free_symbols)
2302 (total_free_floats, total_floats, total_free_intervals)
2303 (total_intervals, total_strings, total_free_strings):
2304 Now EMACS_INT, not int. All uses changed.
2305 (Fgarbage_collect): Compute overall total using a double, so that
2306 integer overflow is less likely to be a problem. Check for overflow
2307 when converting back to an integer.
2308 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2309 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2310 These were 'int' variables that could overflow on 64-bit hosts;
2311 they were never used, so remove them instead of repairing them.
2312 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2313 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2314 Previously, this ceilinged at INT_MAX, but that doesn't work on
2316 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2318 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2319 (allocate_vectorlike): Check for ptrdiff_t overflow.
2320 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2321 when a (possibly-narrower) signed value would do just as well.
2322 We prefer using signed arithmetic, to avoid comparison confusion.
2324 * alloc.c: Catch some string size overflows that we were missing.
2325 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2326 for convenience in STRING_BYTES_MAX.
2327 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2328 The definition here is exact; the one in lisp.h was approximate.
2329 (allocate_string_data): Check for string overflow. This catches
2330 some instances we weren't catching before. Also, it catches
2331 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2332 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2333 and ptrdiff_t and EMACS_INT are both 64 bits.
2335 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2336 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2337 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2339 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2341 * alloc.c (Fmake_string): Check for out-of-range init.
2343 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2345 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2347 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2349 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2350 xg_get_default_scrollbar_width.
2352 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2353 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2354 (style_changed_cb): Call update_theme_scrollbar_width and call
2355 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2356 all frames (Bug#8505).
2357 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2358 Call gtk_window_set_resizable if HAVE_GTK3.
2359 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2360 and height if HAVE_GTK3 (Bug#8505).
2361 (scroll_bar_width_for_theme): New variable.
2362 (update_theme_scrollbar_width): New function.
2363 (xg_get_default_scrollbar_width): Move code to
2364 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2365 (xg_initialize): Call update_theme_scrollbar_width.
2367 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2369 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2371 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2373 * frame.c (make_frame): Call other_buffer_safely instead of
2376 * window.c (temp_output_buffer_show): Call display_buffer with
2377 second argument Vtemp_buffer_show_specifiers and reset latter
2378 immediately after the call.
2379 (Vtemp_buffer_show_specifiers): New variable.
2380 (auto_window_vscroll_p, next_screen_context_lines)
2381 (Vscroll_preserve_screen_position): Remove leading asterisks from
2384 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2386 Fix minor problems found by GCC 4.6.0 static checking.
2387 * buffer.c (Qclone_number): Remove for now, as it's unused.
2388 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2389 (record_buffer): Remove unused local.
2390 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2391 (set_frame_buffer_list): Remove; unused.
2392 * frame.h (other_visible_frames): Remove decl.
2393 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2394 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2395 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2397 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2398 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2399 Define only if HAVE_GPM.
2400 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2401 (update_hints_inhibit): Remove; never set. All uses removed.
2402 * widgetprv.h (emacsFrameClassRec): Remove decl.
2403 * window.c (delete_deletable_window): Now returns void, since it
2404 wasn't returning anything.
2405 (compare_window_configurations): Remove unused locals.
2406 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2407 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2408 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2409 the same widths as pointers. This follows up on the 2011-05-06 patch.
2410 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2411 * xterm.h: Likewise.
2412 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2414 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2416 * makefile.w32-in: Update dependencies.
2417 (LISP_H): Add lib/intprops.h.
2419 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2421 * image.c (gif_load): Add animation frame delay to the metadata.
2422 (syms_of_image): Use DEFSYM. New symbol `delay'.
2424 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2426 * window.c (delete_deletable_window): Re-add.
2427 (Fset_window_configuration): Rewrite to handle dead buffers and
2428 consequently deletable windows.
2429 (window_tree, Fwindow_tree): Remove. Supply functionality in
2431 (compare_window_configurations): Simplify code.
2433 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2435 * image.c (imagemagick_load_image): Fix type mismatch.
2436 (Fimagemagick_types): Likewise.
2438 * window.h (replace_buffer_in_windows): Declare.
2440 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2442 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2443 Qclone_number. Remove external declaration of Qdelete_window.
2444 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2446 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2447 Run Qbuffer_list_update_hook if allowed.
2448 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2449 buffer list implementation.
2450 (other_buffer_safely): New function.
2451 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2452 calls to replace_buffer_in_windows and
2453 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2455 (record_buffer): Inhibit quitting and rewrite using quittable
2456 functions. Run Qbuffer_list_update_hook if allowed.
2457 (Frecord_buffer, Funrecord_buffer): New functions.
2458 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2459 Move switch-to-buffer to window.el.
2460 (bury-buffer): Move to window.el.
2461 (Vbuffer_list_update_hook): New variable.
2463 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2466 * window.h (resize_frame_windows): Move up in code.
2467 (Fwindow_frame): Remove EXFUN.
2468 (replace_buffer_in_all_windows): Remove prototype.
2469 (replace_buffer_in_windows_safely): Add prototype.
2471 * window.c: Declare Qdelete_window static again. Move down
2472 declaration of select_count.
2473 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2474 (Fother_window): Move to window.el.
2475 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2476 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2477 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2479 (replace_buffer_in_windows): Implement by calling
2480 Qreplace_buffer_in_windows.
2481 (replace_buffer_in_all_windows): Remove with some functionality
2482 moved into replace_buffer_in_windows_safely.
2483 (replace_buffer_in_windows_safely): New function.
2484 (select_window_norecord, select_frame_norecord): Move in front
2485 of run_window_configuration_change_hook. Remove now obsolete
2487 (Fset_window_buffer): Rewrite doc-string.
2488 Call Qrecord_window_buffer.
2489 (keys_of_window): Move binding for other-window to window.el.
2491 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2493 * dispextern.h (struct image): Replace data member, whose int_val
2494 and ptr_val fields were not used by anything, with a single
2497 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2498 (gif_clear_image, gif_load, imagemagick_load_image)
2499 (gs_clear_image, gs_load): Callers changed.
2501 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2503 * buffer.h: Include <time.h>, for time_t.
2504 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2506 Fix minor problems found by static checking.
2508 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2510 Make identifiers static if they are not used in other modules.
2511 * data.c (Qcompiled_function, Qframe, Qvector):
2512 * image.c (QimageMagick, Qsvg):
2513 * minibuf.c (Qmetadata):
2514 * window.c (resize_window_check, resize_root_window): Now static.
2515 * window.h (resize_window_check, resize_root_window): Remove decls.
2517 * window.c (window_deletion_count, delete_deletable_window):
2519 (window_body_lines): Now static.
2520 (Fdelete_other_windows_internal): Mark vars as initialized.
2521 Make sure 'resize_failed' is initialized.
2522 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2523 (resize_window_apply): Remove unused local.
2524 * window.h (delete_deletable_window): Remove decl.
2526 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2527 (imagemagick_load_image): Fix pointer signedness problem by changing
2528 last arg from unsigned char * to char *. All uses changed.
2529 Also, fix a local for similar reasons.
2530 Remove unused locals. Remove locals to avoid shadowing.
2531 (fn_rsvg_handle_free): Remove; unused.
2532 (svg_load, svg_load_image): Fix pointer signedness problem.
2533 (imagemagick_load_image): Don't use garbage pointer image_wand.
2535 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2537 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2539 * image.c (gif_load): Fix omitted cast error introduced by
2542 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2544 * window.h (resize_proportionally, orig_total_lines)
2545 (orig_top_line): Remove from window structure.
2546 (set_window_height, set_window_width, change_window_heights)
2547 (Fdelete_window): Remove prototypes.
2548 (resize_frame_windows): Remove duplicate declaration.
2550 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2552 * window.h (resize_frame_windows, resize_window_check)
2553 (delete_deletable_window, resize_root_window)
2554 (resize_frame_windows): Declare prototypes.
2556 * window.c (resize_window_apply): Make definition be "static" to
2557 match the prototype.
2559 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2561 * window.c: Remove declarations of Qwindow_size_fixed,
2562 window_min_size_1, window_min_size_2, window_min_size,
2563 size_window, window_fixed_size_p, enlarge_window, delete_window.
2564 Remove static from declaration of Qdelete_window, it's
2565 temporarily needed by Fbury_buffer.
2566 (replace_window): Don't assign orig_top_line and
2568 (Fdelete_window, delete_window): Remove. Window deletion is
2569 handled by window.el.
2570 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2571 Replace Fdelete_window calls with calls to Qdelete_window.
2572 (Fdelete_other_windows): Remove. Deleting other windows is
2573 handled by window.el.
2574 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2575 handled in window.el.
2576 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2577 Window minimum sizes are handled in window.el.
2578 (shrink_windows, size_window, set_window_height)
2579 (set_window_width, change_window_heights, window_height)
2580 (window_width, CURBEG, CURSIZE, enlarge_window)
2581 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2582 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2583 handled in window.el.
2584 (make_dummy_parent): Rename to make_parent_window and give it a
2585 second argument horflag.
2586 (make_window): Don't set resize_proportionally any more.
2587 (Fsplit_window): Remove. Windows are split in window.el.
2588 (save_restore_action, save_restore_orig_size)
2589 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2590 Resize mini windows in window.el.
2591 (grow_mini_window, shrink_mini_window): Implement by calling
2592 Qresize_root_window_vertically, resize_window_check and
2593 resize_window_apply.
2594 (saved_window, Fset_window_configuration, save_window_save):
2595 Do not handle orig_top_line, orig_total_lines, and
2596 resize_proportionally.
2597 (window_min_height, window_min_width): Move to window.el.
2598 (keys_of_window): Move bindings for delete-other-windows,
2599 split-window, delete-window and enlarge-window to window.el.
2601 * buffer.c: Temporarily extern Qdelete_window.
2602 (Fbury_buffer): Temporarily call Qdelete_window instead of
2603 Fdelete_window (Fbury_buffer will move to window.el soon).
2605 * frame.c (set_menu_bar_lines_1): Remove code handling
2606 orig_top_line and orig_total_lines.
2608 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2609 set_window_height but set heights directly.
2610 (change_frame_size_1): Use resize_frame_windows.
2612 * xdisp.c (init_xdisp): Don't use set_window_height but set
2615 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2616 Use resize_frame_windows instead of change_window_heights and run
2617 run_window_configuration_change_hook.
2619 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2620 instead of change_window_heights and run
2621 run_window_configuration_change_hook.
2623 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2625 * window.c (replace_window): Rename second argument REPLACEMENT to
2626 NEW. New third argument SETFLAG. Rewrite.
2627 (delete_window, make_dummy_parent): Call replace_window with
2629 (window_list_1): Move down in code.
2630 (run_window_configuration_change_hook): Move set_buffer part
2631 before select_frame_norecord part in order to unwind correctly.
2632 Rename count1 to count.
2633 (recombine_windows, delete_deletable_window, resize_root_window)
2634 (Fdelete_other_windows_internal)
2635 (Frun_window_configuration_change_hook, make_parent_window)
2636 (resize_window_check, resize_window_apply, Fresize_window_apply)
2637 (resize_frame_windows, Fsplit_window_internal)
2638 (Fdelete_window_internal, Fresize_mini_window_internal):
2640 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2642 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2644 * window.h (window): Add some new members to window structure -
2645 normal_lines, normal_cols, new_total, new_normal, clone_number,
2646 splits, nest, prev_buffers, next_buffers.
2647 (WINDOW_TOTAL_SIZE): Move here from window.c.
2648 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2650 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2652 (make_dummy_parent): Set new members of windows structure.
2653 (make_window): Move down in code. Handle new members of window
2655 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2656 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2657 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2658 (Fset_window_prev_buffers, Fwindow_next_buffers)
2659 (Fset_window_next_buffers, Fset_window_clone_number):
2661 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2662 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2664 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2665 Argument WINDOW can be now internal window too.
2666 (Fwindow_use_time): Move up in code.
2667 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2669 (Fset_window_configuration, saved_window)
2670 (Fcurrent_window_configuration, save_window_save): Handle new
2671 members of window structure.
2672 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2673 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2674 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2675 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2676 Qget_mru_window, Qresize_root_window,
2677 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2678 Qauto_buffer_name; staticpro them.
2680 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2682 * window.c (Fwindow_total_size, Fwindow_left_column)
2683 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2684 (Fwindow_list_1): New functions.
2685 (window_box_text_cols): Replace with window_body_cols.
2686 (Fwindow_width, Fscroll_left, Fscroll_right):
2687 Use window_body_cols instead of window_box_text_cols.
2688 (delete_window, Fset_window_configuration):
2689 Call delete_all_subwindows with window as argument.
2690 (delete_all_subwindows): Take a window as argument and not a
2692 (window_loop): Remove handling of GET_LRU_WINDOW and
2694 (Fget_lru_window, Fget_largest_window): Move to window.el.
2696 * window.h: Extern window_body_cols instead of
2697 window_box_text_cols. delete_all_subwindows now takes a
2698 Lisp_Object as argument.
2700 * indent.c (compute_motion, Fcompute_motion):
2701 Use window_body_cols instead of window_box_text_cols.
2703 * frame.c (delete_frame): Call delete_all_subwindows with root
2706 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2708 * fns.c (Fputhash): Document return value.
2710 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2712 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2714 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2716 Cons<->int and similar integer overflow fixes (Bug#8794).
2718 Check for overflow when converting integer to cons and back.
2719 * charset.c (Fdefine_charset_internal, Fdecode_char):
2720 Use cons_to_unsigned to catch overflow.
2721 (Fencode_char): Use INTEGER_TO_CONS.
2722 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2723 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2724 * data.c (long_to_cons, cons_to_long): Remove.
2725 (cons_to_unsigned, cons_to_signed): New functions.
2726 These signal an error for invalid or out-of-range values.
2727 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2728 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2729 * font.c (Ffont_variation_glyphs):
2730 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2731 * lisp.h: Include <intprops.h>.
2732 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2733 (cons_to_signed, cons_to_unsigned): New decls.
2734 (long_to_cons, cons_to_long): Remove decls.
2735 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2736 (Fprimitive_undo): Use CONS_TO_INTEGER.
2737 * xfns.c (Fx_window_property): Likewise.
2738 * xselect.c: Include <limits.h>.
2739 (x_own_selection, selection_data_to_lisp_data):
2740 Use INTEGER_TO_CONS.
2741 (x_handle_selection_request, x_handle_selection_clear)
2742 (x_get_foreign_selection, Fx_disown_selection_internal)
2743 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2744 (lisp_data_to_selection_data): Use cons_to_unsigned.
2745 (x_fill_property_data): Use cons_to_signed.
2746 Report values out of range.
2748 Check for buffer and string overflow more precisely.
2749 * buffer.h (BUF_BYTES_MAX): New macro.
2750 * lisp.h (STRING_BYTES_MAX): New macro.
2751 * alloc.c (Fmake_string):
2752 * character.c (string_escape_byte8):
2753 * coding.c (coding_alloc_by_realloc):
2754 * doprnt.c (doprnt):
2755 * editfns.c (Fformat):
2757 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2758 since they may not be the same number.
2759 * editfns.c (Finsert_char):
2760 * fileio.c (Finsert_file_contents):
2761 Likewise for BUF_BYTES_MAX.
2763 * image.c: Use ptrdiff_t, not int, for sizes.
2764 (slurp_file): Switch from int to ptrdiff_t.
2766 (slurp_file): Check that file size fits in both size_t (for
2767 malloc) and ptrdiff_t (for sanity and safety).
2769 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2770 if b->modtime has its maximal value.
2772 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2774 Don't assume time_t can fit into int.
2775 * buffer.h (struct buffer.modtime): Now time_t, not int.
2776 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2777 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2779 Minor fixes for signed vs unsigned integers.
2780 * character.h (MAYBE_UNIFY_CHAR):
2781 * charset.c (maybe_unify_char):
2782 * keyboard.c (read_char, reorder_modifiers):
2783 XINT -> XFASTINT, since the integer must be nonnegative.
2784 * ftfont.c (ftfont_spec_pattern):
2785 * keymap.c (access_keymap, silly_event_symbol_error):
2786 XUINT -> XFASTINT, since the integer must be nonnegative.
2787 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2788 since it makes no difference and we prefer signed.
2789 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2790 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2793 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2795 * window.h (Fwindow_frame): Declare.
2797 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2799 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2800 (SPARE_MEMORY): Always define.
2801 (LARGE_REQUEST): Remove.
2802 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2804 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2806 * lisp.h: Move EXFUNS for Fframe_root_window,
2807 Fframe_first_window and Fset_frame_selected_window to window.h.
2809 * window.h: Move EXFUNS for Fframe_root_window,
2810 Fframe_first_window and Fset_frame_selected_window here from
2813 * frame.c (Fwindow_frame, Fframe_first_window)
2814 (Fframe_root_window, Fframe_selected_window)
2815 (Fset_frame_selected_window): Move to window.c.
2816 (Factive_minibuffer_window): Move to minibuf.c.
2817 (Fother_visible_frames_p): New function.
2819 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2821 * window.c (decode_window, decode_any_window): Move up in code.
2822 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2823 (inhibit_frame_unsplittable): Remove unused variable.
2824 (Fwindow_buffer): Move up and rewrite doc-string.
2825 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2826 (Fwindow_prev): New functions.
2827 (Fwindow_frame): Move here from frame.c. Accept any window as
2829 (Fframe_root_window, Fframe_first_window)
2830 (Fframe_selected_window): Move here from frame.c. Accept frame
2831 or arbitrary window as argument. Update doc-strings.
2832 (Fminibuffer_window): Move up in code.
2833 (Fwindow_minibuffer_p): Move up in code and simplify.
2834 (Fset_frame_selected_window): Move here from frame.c.
2836 (Fselected_window, select_window, Fselect_window): Move up in
2837 code. Minor doc-string fixes.
2839 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2841 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2842 Do not assume that spare memory exists; that assumption is valid
2843 only if SYSTEM_MALLOC.
2844 (LARGE_REQUEST): New macro, so that the issue of large requests
2845 is separated from the issue of spare memory.
2847 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2849 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2852 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2854 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2857 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2859 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2861 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2863 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2864 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2866 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2868 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2870 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2872 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2873 (x_clipboard_manager_save): Add return value.
2874 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2876 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2877 Obey Vx_select_enable_clipboard_manager. Catch errors in
2878 x_clipboard_manager_save (Bug#8779).
2879 (Vx_select_enable_clipboard_manager): New variable.
2880 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2882 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2884 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2886 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2888 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2889 in the current matrix if keep_current_p is non-zero.
2891 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2893 * bidi.c (bidi_level_of_next_char): Fix last change.
2895 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2897 Support bidi reordering of text covered by display properties.
2899 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2900 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2901 (bidi_cache_search, bidi_cache_iterator_state)
2902 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2903 (bidi_level_of_next_char, bidi_move_to_visually_next):
2904 Support character positions inside a run of characters covered by a
2906 (bidi_paragraph_init, bidi_resolve_explicit_1)
2907 (bidi_level_of_next_char): Call bidi_fetch_char and
2908 bidi_fetch_char_advance instead of FETCH_CHAR and
2910 (bidi_init_it): Initialize new members.
2911 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2913 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2914 instead of using explicit *_CHAR codes.
2915 (bidi_resolve_explicit, bidi_resolve_weak):
2916 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2917 bidirectional text is supported only in multibyte buffers.
2918 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2919 it to initialize the frame_window_p member of struct bidi_it.
2920 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2921 (bidi_resolve_explicit, bidi_resolve_weak)
2922 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2923 bidi_it->nchars is non-positive.
2924 (bidi_level_of_next_char): Don't try to lookup the cache for the
2925 next/previous character if nothing is cached there yet, or if we
2926 were just reseat()'ed to a new position.
2928 * xdisp.c (set_cursor_from_row): Set start and stop points
2929 according to the row's direction when priming the loop that looks
2930 for the glyph on which to display cursor.
2931 (single_display_spec_intangible_p): Function deleted.
2932 (display_prop_intangible_p): Reimplement to call
2933 handle_display_spec instead of single_display_spec_intangible_p.
2934 Accept 3 additional arguments needed by handle_display_spec.
2935 This fixes incorrect cursor motion across display property with complex
2936 values: lists, `(when COND...)' forms, etc.
2937 (single_display_spec_string_p): Support property values that are
2938 lists with the argument STRING its top-level element.
2939 (display_prop_string_p): Fix the condition for processing a
2940 property that is a list to be consistent with handle_display_spec.
2941 (handle_display_spec): New function, refactored from the
2942 last portion of handle_display_prop.
2943 (compute_display_string_pos): Accept additional argument
2944 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2945 value of a `display' property is a "replacing spec".
2946 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2947 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2948 the display property, but just return a value indicating whether
2949 the display property will replace the characters it covers.
2950 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2951 frame_window_p members of struct bidi_it.
2952 (compute_display_string_pos, compute_display_string_end):
2954 (push_it): Accept second argument POSITION, where pop_it should
2955 jump to continue iteration.
2956 (reseat_1): Initialize bidi_it.disp_pos.
2958 * keyboard.c (adjust_point_for_property): Adjust the call to
2959 display_prop_intangible_p to its new signature.
2961 * dispextern.h (struct bidi_it): New member frame_window_p.
2962 (bidi_init_it): Update prototypes.
2963 (display_prop_intangible_p): Update prototype.
2964 (compute_display_string_pos, compute_display_string_end):
2966 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2969 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2971 Malloc failure behavior now depends on size of allocation.
2972 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2973 * lisp.h: Change signatures accordingly.
2974 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2975 All callers changed. (Bug#8762)
2977 * gnutls.c: Use Emacs's memory allocators.
2978 Without this change, the gnutls library would invoke malloc etc.
2979 directly, which causes problems on non-SYNC_INPUT hosts, and which
2980 runs afoul of improving memory_full behavior. (Bug#8761)
2981 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2982 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2983 xfree instead of the default malloc, realloc, free.
2984 (Fgnutls_boot): No need to check for memory allocation failure,
2985 since xmalloc does that for us.
2987 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2988 * category.c (hash_get_category_set):
2989 * ccl.c (ccl_driver):
2990 * charset.c (Fdefine_charset_internal):
2991 * charset.h (struct charset.hash_index):
2992 * composite.c (get_composition_id, gstring_lookup_cache)
2993 (composition_gstring_put_cache):
2994 * composite.h (struct composition.hash_index):
2995 * dispextern.h (struct image.hash):
2996 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2997 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2998 (hashfn_equal, hashfn_user_defined, make_hash_table)
2999 (maybe_resize_hash_table, hash_lookup, hash_put)
3000 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3001 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3002 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3003 * image.c (make_image, search_image_cache, lookup_image)
3004 (xpm_put_color_table_h):
3005 * lisp.h (struct Lisp_Hash_Table):
3006 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3007 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3008 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3009 * alloc.c (allocate_vectorlike):
3010 Check for overflow in vector size calculations.
3011 * ccl.c (ccl_driver):
3012 Check for overflow when converting EMACS_INT to int.
3013 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3014 need to be updated by these changes.
3015 * fns.c (make_hash_table, maybe_resize_hash_table):
3016 Check for integer overflow with large hash tables.
3017 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3018 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3019 (SXHASH_REDUCE): New macro.
3020 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3021 Use it instead of discarding useful hash info with large hash values.
3022 (sxhash_float): New function.
3023 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3024 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3025 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3026 Rewrite to use FIXNUM_BITS, as this simplifies things.
3027 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3028 Adjust signatures to match updated version of code.
3029 (consing_since_gc): Now EMACS_INT, since a single hash table can
3030 use more than INT_MAX bytes.
3032 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3034 Make it possible to build with GCC-4.6+ -O2 -flto.
3036 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3038 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3040 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3041 Call minibuffer-inactive-mode.
3043 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3045 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3046 Update dependencies.
3048 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3050 * data.c (init_data): Remove code for UTS, this system is not
3053 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3055 Don't force ./temacs to start in terminal mode.
3057 * frame.c (make_initial_frame): Initialize faces in all cases, not
3058 only when CANNOT_DUMP is defined.
3059 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3061 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3063 * dispnew.c (add_window_display_history): Use const for the string
3064 pointer. Remove declaration, not needed.
3066 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3068 Use 'inline', not 'INLINE'.
3069 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3070 * alloc.c, fontset.c (INLINE): Remove.
3071 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3072 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3073 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3074 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3075 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3077 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3079 Make it possible to run ./temacs.
3081 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3082 syms_of_callproc does the same thing. Remove test for
3083 "initialized", do it in the caller.
3084 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3086 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3088 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3089 (read_minibuf): Use get_minibuffer.
3090 (syms_of_minibuf): Use DEFSYM.
3091 (Qmetadata): New var.
3092 * data.c (Qbuffer): Don't make it static.
3093 (syms_of_data): Use DEFSYM.
3095 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3097 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3098 (CCL_CODE_MIN): New macro.
3100 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3102 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3104 * eval.c (Qdebug): Now static.
3105 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3106 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3107 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3109 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3111 * image.c: Various fixes to ImageMagick code comments.
3112 (Fimagemagick_types): Doc fix.
3114 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3116 Minor fixes prompted by GCC 4.6.0 warnings.
3118 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3120 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3121 (x_clipboard_manager_save_all): Move extern decl to ...
3122 * xterm.h: ... here, so that it can be checked for consistency.
3124 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3126 * xselect.c (x_clipboard_manager_save_frame)
3127 (x_clipboard_manager_save_all): New functions.
3128 (Fx_clipboard_manager_save): Lisp function deleted.
3130 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3131 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3133 * xterm.h: Update prototype.
3135 2011-05-28 William Xu <william.xwl@gmail.com>
3137 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3140 2011-05-28 Jim Meyering <meyering@redhat.com>
3142 Avoid a sign-extension bug in crypto_hash_function.
3143 * fns.c (to_uchar): Define.
3144 (crypto_hash_function): Use it to convert some newly-signed
3145 variables to unsigned, to avoid sign-extension bugs. For example,
3146 without this change, (md5 "truc") would evaluate to
3147 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3148 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3149 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3151 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3153 Integer overflow fixes.
3155 * dbusbind.c: Serial number integer overflow fixes.
3156 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3157 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3158 to hold a serial number that is too large for a fixnum.
3159 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3160 Check for serial numbers out of range. Decode any serial number
3161 that was so large that it became a float. (Bug#8722)
3163 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3164 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3165 Use XFASTINT rather than XUINT when numbers are nonnegative.
3166 (xd_append_arg, Fdbus_method_return_internal):
3167 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3168 arguments, check that Lisp number is nonnegative, rather than
3169 silently wrapping negative numbers around. (Bug#8722)
3170 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3173 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3175 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3177 ccl: add integer overflow checks
3178 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3179 (IN_INT_RANGE): New macros.
3180 (ccl_driver): Use them to check for integer overflow when
3181 decoding a CCL program. Many of the new checks are whether XINT (x)
3182 fits in int; it doesn't always, on 64-bit hosts. The new version
3183 doesn't catch all possible integer overflows, but it's an
3184 improvement. (Bug#8719)
3186 * alloc.c (make_event_array): Use XINT, not XUINT.
3187 There's no need for unsigned here.
3189 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3190 This follows up to the 2011-05-06 change that substituted uintptr_t
3191 for EMACS_INT. This case wasn't caught back then.
3193 Rework Fformat to avoid integer overflow issues.
3194 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3195 now (part of C89). Include <verify.h>.
3196 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3197 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3198 (Fformat): Avoid the prepass trying to compute sizes; it was only
3199 approximate and thus did not catch overflow reliably. Instead, walk
3200 through the format just once, formatting and computing sizes as we go,
3201 checking for integer overflow at every step, and allocating a larger
3202 buffer as needed. Keep track separately whether the format is
3203 multibyte. Keep only the most-recently calculated precision, rather
3204 than them all. Record whether each argument has been converted to
3205 string. Use EMACS_INT, not int, for byte and char and arg counts.
3206 Support field widths and precisions larger than INT_MAX. Avoid
3207 sprintf's undefined behavior with conversion specifications such as %#d
3208 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3209 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3210 formatting out-of-range floating point numbers with int
3213 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3215 * data.c: Avoid integer truncation in expressions involving floats.
3216 * data.c: Include <intprops.h>.
3217 (arith_driver): When there's an integer overflow in an expression
3218 involving floating point, convert the integers to floating point
3219 so that the resulting value does not suffer from catastrophic
3220 integer truncation. For example, on a 64-bit host (* 4
3221 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3222 Do not rely on undefined behavior after integer overflow.
3224 merge count_size_as_multibyte, parse_str_to_multibyte
3225 * character.c, character.h (count_size_as_multibyte):
3226 Rename from parse_str_to_multibyte; all uses changed.
3227 Check for integer overflow.
3228 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3229 since it's now a duplicate of the other. This is more of
3230 a character than a buffer op, so better that it's in character.c.
3231 * fns.c, print.c: Adjust to above changes.
3233 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3235 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3237 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3239 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3240 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3241 (x_clipboard_manager_save): Now static.
3242 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3244 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3245 (crypto_hash_function): Now static.
3246 Fix pointer signedness problems. Avoid unnecessary initializations.
3248 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3250 * termhooks.h (Vselection_alist): Make it terminal-local.
3252 * terminal.c (create_terminal): Initialize it.
3254 * xselect.c: Support for clipboard managers.
3255 (Vselection_alist): Move to termhooks.h as terminal-local var.
3256 (LOCAL_SELECTION): New macro.
3257 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3258 (symbol_to_x_atom): Remove gratuitous arg.
3259 (x_handle_selection_request, lisp_data_to_selection_data)
3260 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3261 (x_own_selection, x_get_local_selection, x_convert_selection):
3262 New arg, specifying work frame. Use terminal-local Vselection_alist.
3263 (some_frame_on_display): Delete unused function.
3264 (Fx_own_selection_internal, Fx_get_selection_internal)
3265 (Fx_disown_selection_internal, Fx_selection_owner_p)
3266 (Fx_selection_exists_p): New optional frame arg.
3267 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3268 (x_handle_selection_clear): Don't treat other terminals with the
3269 same keyboard specially. Use the terminal-local Vselection_alist.
3270 (x_clear_frame_selections): Use Frun_hook_with_args.
3272 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3274 * xterm.h: Add support for those atoms.
3276 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3278 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3279 (converted_selections, conversion_fail_tag): New global variables.
3280 (x_selection_request_lisp_error): Free the above.
3281 (x_get_local_selection): Remove unnecessary code.
3282 (x_reply_selection_request): Args changed; handle arbitrary array
3283 of converted selections stored in converted_selections.
3284 Separate the XChangeProperty and SelectionNotify steps.
3285 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3286 (x_convert_selection): New function.
3287 (x_handle_selection_event): Simplify.
3288 (x_get_foreign_selection): Don't ignore incoming requests while
3289 waiting for an answer; this will fail when we implement
3290 SAVE_TARGETS, and seems unnecessary anyway.
3291 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3292 (Vx_sent_selection_functions): Doc fix.
3294 2011-05-26 Leo Liu <sdl.web@gmail.com>
3296 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3298 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3300 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3302 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3303 for fringe update if it has periodic bitmap.
3304 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3305 and fringe_bitmap_periodic_p.
3307 * fringe.c (get_fringe_bitmap_data): New function.
3308 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3309 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3310 row. Mark glyph row for fringe update if periodicity changed.
3312 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3313 for fringe update unless it has periodic bitmap.
3315 2011-05-25 Kenichi Handa <handa@m17n.org>
3317 * xdisp.c (get_next_display_element): Set correct it->face_id for
3318 a static composition.
3320 2011-05-24 Leo Liu <sdl.web@gmail.com>
3323 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3325 * fns.c (crypto_hash_function, Fsha1): New function.
3326 (Fmd5): Use crypto_hash_function.
3327 (syms_of_fns): Add Ssha1.
3329 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3331 * gnutls.c: Remove unused macros.
3332 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3333 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3334 Remove macros that are defined and never used.
3335 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3337 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3339 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3340 (Fx_get_selection_internal): Minor cleanup.
3341 (Fx_own_selection_internal): Rename arguments for consistency with
3344 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3346 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3348 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3350 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3352 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3354 * dispnew.c (scrolling_window): Don't exclude the case that the
3355 last enabled row in the desired matrix touches the bottom boundary.
3357 2011-05-21 Glenn Morris <rgm@gnu.org>
3359 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3360 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3361 and add some more files.
3363 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3365 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3366 report_file_error introduced by the change from 2011-05-07.
3368 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3370 * systime.h (Time): Define only if emacs is defined.
3371 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3372 where the include path doesn't have X11/X.h by default. See
3373 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3375 2011-05-20 Kenichi Handa <handa@m17n.org>
3377 * composite.c (find_automatic_composition): Fix previous change.
3379 2011-05-20 Glenn Morris <rgm@gnu.org>
3381 * lisp.mk: New file, split from Makefile.in.
3382 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3383 (shortlisp): Remove.
3384 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3386 2011-05-19 Glenn Morris <rgm@gnu.org>
3388 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3389 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3390 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3391 (lisp): Set the order to that of loadup.el.
3392 (shortlisp): Make it a copy of $lisp.
3393 (SOME_MACHINE_LISP): Remove.
3394 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3395 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3397 2011-05-18 Kenichi Handa <handa@m17n.org>
3399 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3400 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3401 (find_automatic_composition): Mostly rewrite for efficiency.
3403 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3405 * makefile.w32-in: Update dependencies.
3407 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3409 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3410 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3412 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3414 Fix some integer overflow issues, such as string length overflow.
3416 * insdel.c (count_size_as_multibyte): Check for string overflow.
3418 * character.c (lisp_string_width): Check for string overflow.
3419 Use EMACS_INT, not int, for string indexes and lengths; in
3420 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3421 the resulting string length overflows an EMACS_INT; instead,
3422 report a string overflow if no precision given. When checking for
3423 precision exhaustion, use a check that cannot possibly have
3424 integer overflow. (Bug#8675)
3425 * character.h (lisp_string_width): Adjust to new signature.
3427 * alloc.c (string_overflow): New function.
3428 (Fmake_string): Use it. This doesn't change behavior, but saves
3429 a few bytes and will simplify future changes.
3430 * character.c (string_escape_byte8): Likewise.
3431 * lisp.h (string_overflow): New decl.
3433 Fixups, following up to the user-interface timestamp change.
3434 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3435 for UI timestamps, instead of unsigned long.
3436 * msdos.c (mouse_get_pos): Likewise.
3437 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3438 * w32gui.h (Time): Define by including "systime.h" rather than by
3439 declaring it ourselves. (Bug#8664)
3441 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3442 * image.c (clear_image_cache): Likewise.
3444 * term.c (term_mouse_position): Don't assume time_t wraparound.
3446 Be more systematic about user-interface timestamps.
3447 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3448 and sometimes 'EMACS_UINT', to represent these timestamps.
3449 This change causes it to use 'Time' uniformly, as that's what X uses.
3450 This makes the code easier to follow, and makes it easier to catch
3451 integer overflow bugs such as Bug#8664.
3452 * frame.c (Fmouse_position, Fmouse_pixel_position):
3453 Use Time, not unsigned long, for user-interface timestamps.
3454 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3455 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3456 * keyboard.h (last_event_timestamp): Likewise.
3457 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3458 * menu.h (xmenu_show): Likewise.
3459 * term.c (term_mouse_position): Likewise.
3460 * termhooks.h (struct input_event.timestamp): Likewise.
3461 (struct terminal.mouse_position_hook): Likewise.
3462 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3463 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3464 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3465 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3467 * menu.h, termhooks.h: Include "systime.h", for Time.
3469 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3470 Don't assume that the difference between two unsigned long values
3471 can fit into an integer. At this point, we know button_down_time
3472 <= event->timestamp, so the difference must be nonnegative, so
3473 there's no need to cast the result if double-click-time is
3474 nonnegative, as it should be; check that it's nonnegative, just in
3475 case. This bug is triggered when events are more than 2**31 ms
3476 apart (about 25 days). (Bug#8664)
3478 * xselect.c (last_event_timestamp): Remove duplicate decl.
3479 (x_own_selection): Remove needless cast to unsigned long.
3481 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3482 that always fit in int. Use a sentinel instead of a counter, to
3483 avoid a temp and to allay GCC's concerns about possible int overflow.
3484 * frame.h (struct frame): Use int for menu_bar_items_used
3485 instead of EMACS_INT, since it always fits in int.
3487 * menu.c (grow_menu_items): Check for int overflow.
3489 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3491 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3492 Before, the code was not consistent. These values cannot exceed
3493 2**31 - 1 so there's no need to make them unsigned.
3494 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3495 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3496 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3498 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3500 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3501 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3502 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3503 presumably because the widths might not match.
3505 * window.c (size_window): Avoid needless test at loop start.
3507 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3509 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3511 2011-05-12 Drew Adams <drew.adams@oracle.com>
3513 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3515 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3517 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3518 `width' to `bar_area_x' and `bar_area_width', respectively.
3519 (x_scroll_run): Take account of fringe background extension.
3521 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3522 Rename local vars `left' and `width' to `bar_area_x' and
3523 `bar_area_width', respectively.
3524 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3525 background extension.
3527 2011-05-10 Jim Meyering <meyering@redhat.com>
3529 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3531 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3533 * image.c (Finit_image_library): Return t for built-in image types,
3534 like pbm and xbm. (Bug#8640)
3536 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3538 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3540 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3542 * w32console.c (Fset_screen_color): Doc fix.
3543 (Fget_screen_color): New function.
3544 (syms_of_ntterm): Defsubr it.
3546 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3547 unlink the temporary file if Fcall_process didn't create it in the
3549 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3550 child process will be redirected to a file specified with `:file'.
3551 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3552 cue to call_process_cleanup not to close that handle.
3554 2011-05-07 Ben Key <bkey76@gmail.com>
3556 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3557 one of two shell specific rules, either bootstrap-temacs-CMD or
3558 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3559 to the previous implementation of the bootstrap-temacs rule.
3560 The bootstrap-temacs-CMD rule is similar to the previous
3561 implementation of the bootstrap-temacs rule except that it
3562 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3565 These changes, along with some changes to nt/configure.bat,
3566 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3567 earlier fix to add support for --cflags and --ldflags options
3568 that include quotes so that it works whether make uses cmd or
3571 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3573 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3574 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3576 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3577 a string. Handle both cases.
3578 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3579 (Fdbus_register_method): Use Qinvalid_function.
3581 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3583 * makefile.w32-in: Update dependencies.
3584 (LISP_H): Add inttypes.h and stdin.h.
3585 (PROCESS_H): Add unistd.h.
3587 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3589 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3590 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3592 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3594 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3596 * term.c (vfatal): Remove stray call to va_end.
3597 It's not needed and the C Standard doesn't allow it here anyway.
3599 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3600 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3602 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3605 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3607 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3609 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3611 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3613 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3615 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3616 * charset.c (Fdefine_charset_internal): Don't initialize
3617 charset.code_space[15]. The value was garbage, on hosts with
3618 32-bit int (Bug#8600).
3620 * lread.c (read_integer): Be more consistent with string-to-number.
3621 Use string_to_number to do the actual conversion; this avoids
3622 rounding errors and fixes some other screwups. Without this fix,
3623 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3624 (digit_to_number): Move earlier, for benefit of read_integer.
3625 Return -1 if the digit is out of range for the base, -2 if it is
3626 not a digit in any supported base. (Bug#8602)
3628 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3630 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3631 to match comment at start of function. This also removes a
3632 GCC warning about overflow in a 32+64-bit port.
3634 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3636 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3637 Reported by Stefan Monnier in
3638 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3639 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3640 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3642 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3643 (EMACS_UINTPTR): Likewise, with uintptr_t.
3645 * lisp.h: Prefer 64-bit EMACS_INT if available.
3646 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3647 on 32-bit hosts that have 64-bit int, so that they can access
3649 However, temporarily disable this change unless the temporary
3650 symbol WIDE_EMACS_INT is defined.
3652 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3654 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3655 This removes an assumption that EMACS_INT and long are the same
3656 width as pointers. The assumption is true for Emacs porting targets
3657 now, but we want to make other targets possible.
3658 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3659 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3660 In the rest of the code, change types of integers that hold casted
3661 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3662 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3663 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3664 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3665 No need to cast type when ORing.
3666 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3667 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3668 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3669 assume EMACS_INT is the same width as char *.
3670 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3671 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3672 Remove no-longer-needed casts.
3673 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3674 (xg_tool_bar_help_callback, xg_make_tool_item):
3675 Use EMACS_INTPTR to hold an integer
3676 that will be cast to void *; this can avoid a GCC warning
3677 if EMACS_INT is not the same width as void *.
3678 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3679 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3680 (current_message_1, set_message_1):
3681 Use a local to convert to proper width without a cast.
3682 * xmenu.c (dialog_selection_callback): Likewise.
3684 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3685 Also, don't assume VALBITS / RAND_BITS is less than 5,
3686 and don't rely on undefined behavior when shifting a 1 left into
3688 * lisp.h (get_random): Change signature to match.
3690 * lread.c (hash_string): Use size_t, not int, for hash computation.
3691 Normally we prefer signed values; but hashing is special, because
3692 it's better to use unsigned division on hash table sizes so that
3693 the remainder is nonnegative. Also, size_t is the natural width
3694 for hashing into memory. The previous code used 'int', which doesn't
3695 retain enough info to hash well into very large tables.
3696 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3698 * dbusbind.c: Don't possibly lose pointer info when converting.
3699 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3700 Use XPNTR rather than XHASH, so that the high-order bits of
3701 the pointer aren't lost when converting through void *.
3703 * eval.c (Fautoload): Don't double-shift a pointer.
3705 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3707 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3709 * gnutls.c (DEF_GNUTLS_FN):
3710 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3712 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3714 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3717 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3719 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3720 New version that can reserve upto 2GB of heap space.
3722 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3724 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3726 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3728 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3729 `gnutls_certificate_set_x509_key_file'.
3731 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3733 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3734 Update dependencies.
3736 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3738 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3739 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3740 Remove unused parameter `fildes'.
3741 * process.c (read_process_output, send_process): Don't pass it.
3743 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3745 Fix previous change: the library cache is defined in w32.c.
3746 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3747 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3749 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3751 Implement dynamic loading of GnuTLS on Windows.
3753 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3754 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3755 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3758 * gnutls.c (Qgnutls_dll): Define.
3759 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3760 (gnutls_*): Declare function pointers.
3761 (init_gnutls_functions): New function to initialize function pointers.
3762 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3763 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3764 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3765 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3766 (emacs_gnutls_write, emacs_gnutls_read)
3767 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3768 (Fgnutls_available_p): New function.
3769 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3770 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3771 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3773 * image.c: Include w32.h.
3774 (Vimage_type_cache): Delete.
3775 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3776 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3777 (w32_delayed_load): Move to w32.c.
3779 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3781 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3782 (w32_delayed_load): Move from image.c. When loading a library, record
3783 its filename in the :loaded-from property of the library id.
3784 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3785 Initialize and staticpro them.
3786 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3788 * process.c: Include lisp.h before w32.h, not after.
3789 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3790 instead of gnutls_record_check_pending.
3792 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3794 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3796 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3797 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3800 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3802 * xterm.c (x_set_frame_alpha): Do not set property on anything
3803 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3805 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3807 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3809 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3811 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3812 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3813 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3814 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3815 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3816 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3817 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3818 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3819 (Qgnutls_bootprop_callbacks_verify): Make static.
3821 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3823 * callproc.c: Indentation fixup.
3825 * sysdep.c (wait_for_termination_1): Make static.
3826 (wait_for_termination, interruptible_wait_for_termination):
3827 Move after wait_for_termination_1.
3829 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3831 * sysdep.c (interruptible_wait_for_termination): New function
3832 which is like wait_for_termination, but allows keyboard
3835 * callproc.c (Fcall_process): Add (:file "file") as an option for
3837 (Fcall_process_region): Ditto.
3839 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3841 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3842 rather than `XVECTOR (FOO)->size'.
3844 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3845 inttypes.h, as a gnulib replacement is used if it not available in
3848 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3850 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3851 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3852 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3854 * coding.c (coding_alloc_by_realloc): Error out if destination
3855 will grow beyond MOST_POSITIVE_FIXNUM.
3856 (decode_coding_emacs_mule): Abort if there isn't enough place in
3857 charbuf for the composition carryover bytes. Reserve an extra
3858 space for up to 2 characters produced in a loop.
3859 (decode_coding_iso_2022): Abort if there isn't enough place in
3860 charbuf for the composition carryover bytes.
3862 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3864 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3865 aborting when %lld or %lll format is passed.
3866 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3867 %llo or %llx format is passed. (Bug#8545)
3869 * window.c (window_scroll_line_based): Use a marker instead of
3870 simple variables to record original value of point. (Bug#7952)
3872 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3873 produced by %s or %c overflows available buffer space. (Bug#8545)
3875 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3877 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3878 (SIZE_MAX): Move defn after all includes, as they might #define it.
3880 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3882 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3884 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3886 * keyboard.c (Qdelayed_warnings_hook): Define.
3887 (command_loop_1): Run `delayed-warnings-hook'
3888 if Vdelayed_warnings_list is non-nil.
3889 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3890 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3892 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3894 * doprnt.c (doprnt): Don't return value smaller than the buffer
3895 size if the message was truncated. (Bug#8545).
3897 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3899 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3900 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3902 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3904 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3906 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3908 * makefile.w32-in: Update dependencies.
3910 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3912 Improve `doprnt' and its usage. (Bug#8545)
3913 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3914 `format_end'. Remove support for %l as a conversion specifier.
3915 Don't use xrealloc. Improve diagnostics when the %l size modifier
3916 is used. Update the commentary.
3918 * eval.c (verror): Simplify calculation of size_t.
3920 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3923 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3925 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3928 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3930 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3931 This makes this file independent of the recent pseudovector change.
3933 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3935 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3937 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3938 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3939 Remove unused local.
3940 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3942 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3943 GCC 4.6.0 optimizes based on type-based alias analysis.
3944 For example, if b is of type struct buffer * and v of type struct
3945 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3946 != &v->size, and therefore "v->size = 1; b->size = 2; return
3947 v->size;" must therefore return 1. This assumption is incorrect
3948 for Emacs, since it type-puns struct Lisp_Vector * with many other
3949 types. To fix this problem, this patch adds a new type struct
3950 vectorlike_header that documents the constraints on layout of vectors
3951 and pseudovectors, and helps optimizing compilers not get fooled
3952 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3953 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3954 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3956 (XSETPVECTYPE): Rewrite in terms of new macro.
3957 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3958 This is a bit clearer, and further avoids the possibility of
3959 undesirable aliasing.
3960 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3961 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3962 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3963 since Lisp_Subr is a special case (no "next" field).
3964 (ASIZE): Now uses header.size rather than size.
3965 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3966 to avoid the hassle of writing XVECTOR (foo)->header.size.
3967 (struct vectorlike_header): New type.
3968 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3969 object, to help avoid aliasing.
3970 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3971 (SUBRP): Likewise, since Lisp_Subr is a special case.
3972 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3973 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3974 (struct Lisp_Hash_Table): Combine first two members into a single
3975 struct vectorlike_header member. All uses of "size" and "next" members
3976 changed to be "header.size" and "header.next".
3977 * buffer.h (struct buffer): Likewise.
3978 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3979 * frame.h (struct frame): Likewise.
3980 * process.h (struct Lisp_Process): Likewise.
3981 * termhooks.h (struct terminal): Likewise.
3982 * window.c (struct save_window_data, struct saved_window): Likewise.
3983 * window.h (struct window): Likewise.
3984 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3985 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3986 * buffer.c (init_buffer_once): Likewise.
3987 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3989 * process.c (Fformat_network_address): Use local var for size,
3992 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3994 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3995 * data.c (atof): Remove decl; no longer used or needed.
3996 (digit_to_number): Move to lread.c.
3997 (Fstring_to_number): Use new string_to_number function, to be
3998 consistent with how the Lisp reader treats infinities and NaNs.
3999 Do not assume that floating-point numbers represent EMACS_INT
4000 without losing information; this is not true on most 64-bit hosts.
4001 Avoid double-rounding errors, by insisting on integers when
4002 parsing non-base-10 numbers, as the documentation specifies.
4003 * lisp.h (string_to_number): New decl, replacing ...
4004 (isfloat_string): Remove.
4005 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4006 (read1): Do not accept +. and -. as integers; this
4007 appears to have been a coding error. Similarly, do not accept
4008 strings like +-1e0 as floating point numbers. Do not report
4009 overflow for integer overflows unless the base is not 10 which
4010 means we have no simple and reliable way to continue.
4011 Break out the floating-point parsing into a new
4012 function string_to_number, so that Fstring_to_number parses
4013 floating point numbers consistently with the Lisp reader.
4014 (digit_to_number): Move here from data.c. Make it static inline.
4015 (E_CHAR, EXP_INT): Remove, replacing with ...
4016 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4017 (string_to_number): New function, replacing isfloat_string.
4018 This function checks for valid syntax and produces the resulting
4019 Lisp float number too. Rework it so that string-to-number
4020 no longer mishandles examples like "1.0e+". Use strtoumax,
4021 so that overflow for non-base-10 numbers is reported only when
4022 there's no portable and simple way to convert to floating point.
4024 * textprop.c (set_text_properties_1): Rewrite for clarity,
4025 and to avoid GCC warning about integer overflow.
4027 * intervals.h (struct interval): Use EMACS_INT for members
4028 where EMACS_UINT might cause problems. See
4029 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4030 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4031 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4033 (offset_intervals): Tell GCC not to worry about length overflow
4034 when negating a negative length.
4036 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4037 (overrun_check_free): Likewise.
4039 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4040 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4043 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4044 (gnutls_make_error): Rename local to avoid shadowing.
4045 (gnutls_emacs_global_deinit): ifdef out; not used.
4046 (Fgnutls_boot): Use const for pointer to readonly storage.
4047 Comment out unused local. Fix pointer signedness problems.
4049 * lread.c (openp): Don't stuff size_t into an 'int'.
4050 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4051 about possible signed overflow.
4053 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4054 (GDK_KEY_g): Don't define if already defined.
4055 (xg_prepare_tooltip): Avoid pointer signedness problem.
4056 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4058 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4059 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4061 * xfns.c (Fx_window_property): Simplify a bit,
4062 to make a bit faster and to avoid GCC 4.6.0 warning.
4063 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4065 * fns.c (internal_equal): Don't assume size_t fits in int.
4067 * alloc.c (compact_small_strings): Tighten assertion a little.
4069 Replace pEd with more-general pI, and fix some printf arg casts.
4070 * lisp.h (pI): New macro, generalizing old pEd macro to other
4071 conversion specifiers. For example, use "...%"pI"d..." rather
4072 than "...%"pEd"...".
4073 (pEd): Remove. All uses replaced with similar uses of pI.
4074 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4075 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4076 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4077 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4078 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4079 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4080 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4082 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4083 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4084 * print.c (safe_debug_print, print_object): Likewise.
4085 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4087 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4088 avoiding the 0 flag, which is not portable.
4089 * process.c (Fmake_network_process): Use pI to avoid cast.
4090 * region-cache.c (pp_cache): Likewise.
4091 * xdisp.c (decode_mode_spec): Likewise.
4092 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4093 behavior on 64-bit hosts with printf arg.
4094 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4095 (x_stop_queuing_selection_requests): Likewise.
4096 (x_get_window_property): Don't truncate byte count to an 'int'
4099 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4100 here, since it parses constructs like leading '-' and spaces,
4101 which are not wanted; and it overflows with large numbers.
4102 Instead, simply match F[0-9]+, which is what is wanted anyway.
4104 * alloc.c: Remove unportable assumptions about struct layout.
4105 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4106 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4107 (allocate_vectorlike, make_pure_vector): Use the new macros,
4108 plus offsetof, to remove unportable assumptions about struct layout.
4109 These assumptions hold on all porting targets that I know of, but
4110 they are not guaranteed, they're easy to remove, and removing them
4111 makes further changes easier.
4113 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4114 This doesn't fix a bug but makes the code clearer.
4115 (string_overrun_cookie): Now const. Use initializers that
4116 don't formally overflow signed char, to avoid warnings.
4117 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4118 can cause Emacs to crash when string overrun checking is enabled.
4119 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4120 multiple of sizeof (EMACS_INT); it need not be, if
4121 alignof(EMACS_INT) < sizeof (EMACS_INT).
4122 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4124 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4126 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4128 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4130 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4131 supposed to be handshaking. (Bug#8556)
4132 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4134 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4136 * lisp.h (Qdebug): List symbol.
4137 * eval.c (Qdebug): Restore global linkage.
4138 * keyboard.c (debug-on-event): New variable.
4139 (handle_user_signal): Break into debugger when debug-on-event
4140 matches the current signal symbol.
4142 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4144 * alloc.c (check_sblock, check_string_bytes)
4145 (check_string_free_list): Convert to standard C.
4147 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4149 * w32.c (emacs_gnutls_push): Fix typo.
4151 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4153 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4154 "cast to pointer from integer of different size".
4156 Improve doprnt and its use in verror. (Bug#8545)
4157 * doprnt.c (doprnt): Document the set of format control sequences
4158 supported by the function. Use SAFE_ALLOCA instead of always
4161 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4162 is one byte too soon. Don't use xrealloc; instead xfree and
4165 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4167 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4170 * gnutls.c: Renamed global_initialized to
4171 gnutls_global_initialized. Added internals for the
4172 :verify-hostname-error, :verify-error, and :verify-flags
4173 parameters of `gnutls-boot' and documented those parameters in the
4174 docstring. Start callback support.
4175 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4176 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4177 on error. Return error code.
4178 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4179 (emacs_gnutls_read): Likewise.
4180 (Fgnutls_boot): Return handshake error code.
4181 (emacs_gnutls_handle_error): New function.
4182 (wsaerror_to_errno): Likewise.
4184 * w32.h (emacs_gnutls_pull): Add prototype.
4185 (emacs_gnutls_push): Likewise.
4187 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4188 (emacs_gnutls_push): Likewise.
4190 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4192 * process.c (wait_reading_process_output): Check if GnuTLS
4193 buffered some data internally if no FDs are set for TLS
4196 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4197 (LIBS): Link to USER_LIBS.
4198 ($(BLD)/gnutls.$(0)): New target.
4200 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4202 * xdisp.c (handle_single_display_spec): Rename the
4203 display_replaced_before_p argument into display_replaced_p, to
4204 make it consistent with the commentary. Fix typos in the
4207 * textprop.c (syms_of_textprop): Remove dead code.
4208 (copy_text_properties): Delete obsolete commentary about an
4209 interface that was deleted long ago. Fix typos in the description
4212 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4213 to changes in oldXMenu/XMenu.h from 2011-04-16.
4214 <menu_help_message, prev_menu_help_message>: Constify.
4215 (IT_menu_make_room): menu->help_text is now `const char **';
4218 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4219 to changes in oldXMenu/XMenu.h from 2011-04-16.
4220 (struct XMenu): Declare `help_text' `const char **'.
4222 * xfaces.c <Qunspecified>: Make extern again.
4224 * syntax.c: Include sys/types.h before including regex.h, as
4227 * doc.c (get_doc_string): Improve the format passed to `error'.
4229 * doprnt.c (doprnt): Improve commentary.
4231 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4233 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4236 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4237 changes in globals.h immediately force recompilation.
4238 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4239 $(CURDIR)/s/ms-w32.h.
4240 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4242 * character.c (Fchar_direction): Function deleted.
4243 (syms_of_character): Don't defsubr it.
4244 <char-direction-table>: Deleted.
4246 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4248 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4249 * doprnt.c: Include limits.h.
4250 (SIZE_MAX): New macro.
4251 (doprnt): Return a size_t value. 2nd arg is now size_t.
4252 Many local variables are now size_t instead of int or unsigned.
4253 Improve overflow protection. Support `l' modifier for integer
4254 conversions. Support %l conversion. Don't assume an EMACS_INT
4255 argument for integer conversions and for %c.
4257 * lisp.h (doprnt): Restore prototype.
4259 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4262 * Makefile.in (base_obj): Add back doprnt.o.
4264 * deps.mk (doprnt.o): Add back prerequisites.
4265 (callint.o): Depend on character.h.
4267 * eval.c (internal_lisp_condition_case): Include the handler
4268 representation in the error message.
4269 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4270 when breaking from the loop.
4272 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4274 * callint.c (Fcall_interactively): When displaying error message
4275 about invalid control letter, pass the character's codepoint, not
4276 a pointer to its multibyte form. Improve display of the character
4277 in octal and display also its hex code.
4279 * character.c (char_string): Use %x to display the (unsigned)
4280 codepoint of an invalid character, to avoid displaying a bogus
4283 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4284 `error', not SYMBOL_NAME itself.
4286 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4287 character arguments to `error'.
4289 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4290 to `error' in error message about FINAL_CHAR argument. Make sure
4291 FINAL_CHAR is a character, and use %c when it is passed as
4292 argument to `error'.
4294 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4296 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4298 * w32.c: Include <time.h>.
4299 (sys_localtime): New function.
4301 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4303 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4305 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4307 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4309 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4312 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4314 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4315 gl_state.e_property when gl_state.object is Qt.
4317 * insdel.c (make_gap_larger): Remove limitation of buffer size
4320 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4322 * xdisp.c (lookup_glyphless_char_display)
4323 (produce_glyphless_glyph): Handle cons cell entry in
4324 glyphless-char-display.
4325 (Vglyphless_char_display): Document it.
4327 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4328 glyphless-char-display.
4330 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4332 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4334 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4336 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4337 definition for no-X builds.
4339 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4341 Static checks with GCC 4.6.0 and non-default toolkits.
4343 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4345 * process.c (keyboard_bit_set): Define only if SIGIO.
4346 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4347 (send_process): Repair possible setjmp clobbering.
4349 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4351 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4353 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4355 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4356 Define only if needed.
4358 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4359 by pacifying GCC about it. Maybe it's time to retire it?
4360 * xfaces.c (USG, __TIMEVAL__): Likewise.
4362 * dispextern.h (struct redisplay_interface): Rename param
4364 * termhooks.h (struct terminal): Likewise.
4365 * xterm.c (xembed_send_message): Likewise.
4367 * insdel.c (make_gap_smaller): Define only if
4368 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4370 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4373 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4374 so that we aren't warned about unused symbols.
4376 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4378 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4380 * xfns.c (x_real_positions): Mark locals as initialized.
4382 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4384 * xterm.c: Fix problems found by static analysis with other toolkits.
4385 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4386 (x_dispatch_event): Declare static if USE_GTK, and
4387 define if USE_GTK || USE_X_TOOLKIT.
4388 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4389 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4390 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4391 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4393 * xmenu.c (menu_help_callback): Pointer type fixes.
4394 Use const pointers when pointing at readonly data. Avoid pointer
4396 (FALSE): Remove unused macro.
4397 (update_frame_menubar): Remove unused decl.
4399 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4401 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4402 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4403 (single_menu_item): Rename local to avoid shadowing.
4405 * keyboard.c (make_lispy_event): Remove unused local var.
4407 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4408 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4410 * bitmaps: Change bitmaps from unsigned char back to the X11
4411 compatible char. Avoid the old compiler warnings about
4412 out-of-range initializers by using, for example, '\xab' rather
4415 * xgselect.c (xgselect_initialize): Check vs interface
4416 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4418 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4420 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4421 to read-only memory.
4423 * fns.c (vector): Remove; this old hack is no longer needed.
4425 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4427 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4429 * xrdb.c (x_load_resources): Omit unused local.
4431 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4432 (x_window): Rename locals to avoid shadowing.
4433 (USG): Use the kludged USG macro, to pacify gcc.
4435 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4436 (x_term_init): Remove local to avoid shadowing.
4438 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4440 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4441 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4443 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4445 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4447 Fix regex.c, syntax.c and friends for buffers > 2GB.
4448 * syntax.h (struct gl_state_s): Declare character position members
4451 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4453 * textprop.c (verify_interval_modification, interval_of):
4454 Declare arguments EMACS_INT.
4456 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4459 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4461 * indent.c (Fvertical_motion): Local variable it_start is now
4464 * regex.c (re_match, re_match_2, re_match_2_internal)
4465 (bcmp_translate, regcomp, regexec, print_double_string)
4466 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4467 (re_compile_pattern, re_exec): Declare arguments and local
4468 variables `size_t' and `ssize_t' and return values `regoff_t', as
4470 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4471 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4472 <compile_stack_type>: `size' and `avail' are now `size_t'.
4474 * regex.h <regoff_t>: Use ssize_t, not int.
4475 (re_search, re_search_2, re_match, re_match_2): Arguments that
4476 specify buffer/string position and length are now ssize_t and
4477 size_t. Return type is regoff_t.
4479 2011-04-16 Ben Key <bkey76@gmail.com>
4481 * nsfont.m: Fixed bugs in ns_get_family and
4482 ns_descriptor_to_entity that were caused by using free to
4483 deallocate memory blocks that were allocated by xmalloc (via
4484 xstrdup). This caused Emacs to crash when compiled with
4485 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4486 --enable-checking=xmallocoverrun). xfree is now used to
4487 deallocate these memory blocks.
4489 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4491 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4493 emacs_write: Accept and return EMACS_INT for sizes.
4494 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4496 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4497 Accept and return EMACS_INT.
4498 (emacs_gnutls_write): Return the number of bytes written on
4500 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4501 (emacs_read, emacs_write): Remove check for negative size, as the
4502 Emacs source code has been audited now.
4503 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4504 (emacs_read, emacs_write): Use it.
4505 * process.c (send_process): Adjust to the new signatures of
4506 emacs_write and emacs_gnutls_write. Do not attempt to store
4507 a byte offset into an 'int'; it might overflow.
4508 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4510 * sound.c: Don't assume sizes fit in 'int'.
4511 (struct sound_device.period_size, alsa_period_size):
4512 Return EMACS_INT, not int.
4513 (struct sound_device.write, vox_write, alsa_write):
4514 Accept EMACS_INT, not int.
4515 (wav_play, au_play): Use EMACS_INT to store sizes and to
4516 record read return values.
4518 2011-04-15 Ben Key <bkey76@gmail.com>
4520 * keyboard.c (Qundefined): Don't declare static since it is used
4522 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4523 static since they are used in nsfont.m.
4525 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4527 * process.c (Qprocessp): Don't declare static.
4528 * lisp.h (Qprocessp): Declare again.
4530 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4532 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4534 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4536 Improve C-level modularity by making more things 'static'.
4538 Don't publish debugger-only interfaces to other modules.
4539 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4540 (verify_bytepos, count_markers): Move decls to the only modules
4542 * region-cache.h (pp_cache): Likewise.
4543 * window.h (check_all_windows): Likewise.
4544 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4546 * sysdep.c (croak): Now static, if
4547 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4548 * syssignal.h (croak): Declare only if not static.
4550 * alloc.c (refill_memory_reserve): Now static if
4551 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4552 * lisp.h (refill_memory_reserve): Declare only if not static.
4554 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4555 Define only if USE_LUCID.
4557 * xrdb.c (x_customization_string, x_rm_string): Now static.
4559 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4560 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4562 * xdisp.c (draw_row_with_mouse_face): Now static.
4563 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4565 * window.h (check_all_windows): Mark externally visible.
4567 * window.c (window_deletion_count): Now static.
4569 * undo.c: Make symbols static if they're not exported.
4570 (last_undo_buffer, last_boundary_position, pending_boundary):
4573 * textprop.c (interval_insert_behind_hooks): Now static.
4574 (interval_insert_in_front_hooks): Likewise.
4576 * term.c: Make symbols static if they're not exported.
4577 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4578 (max_frame_lines, tty_set_terminal_modes):
4579 (tty_reset_terminal_modes, tty_turn_off_highlight):
4580 (get_tty_terminal): Now static.
4581 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4582 * termhooks.h (term_mouse_moveto): Do not declare if
4584 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4585 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4587 * sysdep.c: Make symbols static if they're not exported.
4588 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4590 (sigprocmask_set, full_mask): Remove; unused.
4591 (wait_debugging): Mark as visible.
4592 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4593 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4595 * syntax.c (syntax_temp): Define only if !__GNUC__.
4597 * sound.c (current_sound_device, current_sound): Now static.
4599 * search.c (searchbufs, searchbuf_head): Now static.
4601 * scroll.c (scroll_cost): Remove; unused.
4602 * dispextern.h (scroll_cost): Remove decl.
4604 * region-cache.h (pp_cache): Mark as externally visible.
4606 * process.c: Make symbols static if they're not exported.
4607 (process_tick, update_tick, create_process, chan_process):
4608 (Vprocess_alist, proc_buffered_char, datagram_access):
4609 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4610 (deactivate_process): Mark defn as static, as well as decl.
4611 * lisp.h (create_process): Remove decl.
4612 * process.h (chan_process, Vprocess_alist): Remove decls.
4614 * print.c: Make symbols static if they're not exported.
4615 (print_depth, new_backquote_output, being_printed, print_buffer):
4616 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4617 (print_interval, print_number_index, initial_stderr_stream):
4619 * lisp.h (Fprinc): Remove decl.
4620 (debug_output_compilation_hack): Mark as externally visible.
4622 * sysdep.c (croak): Move decl from here to syssignal.h.
4623 * syssignal.h (croak): Put it here, so the API can be checked when
4624 'croak' is called from dissociate_if_controlling_tty.
4626 * minibuf.c: Make symbols static if they're not exported.
4627 (minibuf_save_list, choose_minibuf_frame): Now static.
4628 * lisp.h (choose_minibuf_frame): Remove decl.
4630 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4632 * lread.c: Make symbols static if they're not exported.
4633 (read_objects, initial_obarray, oblookup_last_bucket_number):
4635 (make_symbol): Remove; unused.
4636 * lisp.h (initial_obarray, make_symbol): Remove decls.
4638 * keyboard.c: Make symbols static if they're not exported.
4639 (single_kboard, recent_keys_index, total_keys, recent_keys):
4640 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4641 (this_single_command_key_start, echoing, last_auto_save):
4642 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4643 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4644 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4645 (Vlispy_mouse_stem, double_click_count):
4647 (force_auto_save_soon): Define only if SIGDANGER.
4648 (ignore_mouse_drag_p): Now static if
4649 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4650 (print_help): Remove; unused.
4651 (stop_character, last_timer_event): Mark as externally visible.
4652 * keyboard.h (ignore_mouse_drag_p): Declare only if
4653 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4654 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4655 * lisp.h (echoing): Remove decl.
4656 (force_auto_save_soon): Declare only if SIGDANGER.
4657 * xdisp.c (redisplay_window): Simplify code, to make it more
4658 obvious that ignore_mouse_drag_p is not accessed if !defined
4659 USE_GTK && !defined HAVE_NS.
4661 * intervals.c: Make symbols static if they're not exported.
4662 (merge_properties_sticky, merge_interval_right, delete_interval):
4664 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4666 * insdel.c: Make symbols static if they're not exported.
4667 However, leave prepare_to_modify_buffer alone. It's never
4668 called from outside this function, but that appears to be a bug.
4669 (combine_after_change_list, combine_after_change_buffer):
4670 (adjust_after_replace, signal_before_change): Now static.
4671 (adjust_after_replace_noundo): Remove; unused.
4672 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4673 (signal_before_change): Remove decls.
4675 * indent.c (val_compute_motion, val_vmotion): Now static.
4677 * image.c: Make symbols static if they're not exported.
4678 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4680 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4681 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4683 * fringe.c (standard_bitmaps): Now static.
4684 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4686 * frame.c: Make symbols static if they're not exported.
4687 (x_report_frame_params, make_terminal_frame): Now static.
4688 (get_frame_param): Now static, unless HAVE_NS.
4689 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4690 (x_get_resource_string): Remove; not used.
4691 * frame.h (make_terminal_frame, x_report_frame_params):
4692 (x_get_resource_string); Remove decls.
4693 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4694 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4696 * font.c, fontset.c: Make symbols static if they're not exported.
4697 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4698 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4699 * font.c (font_close_object): Now static.
4700 * font.h (font_close_object): Remove.
4701 * fontset.c (FONTSET_OBJLIST): Remove.
4702 (free_realized_fontset) #if-0 the body, which does nothing.
4703 (face_suitable_for_char_p): #if-0, as it's never called.
4704 * fontset.h (face_suitable_for_char_p): Remove decl.
4705 * xfaces.c (face_at_string_position):
4706 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4707 since 0 is always ASCII.
4709 * fns.c (weak_hash_tables): Now static.
4711 * fileio.c: Make symbols static if they're not exported.
4712 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4713 (Vwrite_region_annotation_buffers): Now static.
4715 * eval.c: Make symbols static if they're not exported.
4716 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4717 * lisp.h (backtrace_list): Remove decl.
4719 * emacs.c: Make symbols static if they're not exported.
4720 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4721 (fatal_error_code, fatal_error_signal_hook, standard_args):
4723 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4724 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4725 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4726 * lisp.h (fatal_error_signal_hook): Remove decl.
4727 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4729 * editfns.c: Move a (normally-unused) function to its only use.
4730 * editfns.c, lisp.h (get_operating_system_release): Remove.
4731 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4732 worth the hassle of breaking this out.
4734 * xterm.c: Make symbols static if they're not exported.
4735 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4736 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4737 (x_destroy_window, x_delete_display):
4739 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4740 (x_mouse_leave): Remove; unused.
4741 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4742 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4743 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4745 (x_mouse_leave): Declare only if WINDOWSNT.
4746 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4747 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4750 * ftxfont.c: Make symbols static if they're not exported.
4751 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4753 * font.h (ftxfont_driver): Likewise.
4755 * xfns.c: Make symbols static if they're not exported.
4756 (x_last_font_name, x_display_info_for_name):
4757 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4758 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4759 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4760 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4761 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4762 (last_show_tip_args): Now static.
4763 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4764 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4765 (x_screen_planes): Remove; unused.
4766 * dispextern.h (x_screen_planes): Remove decl.
4768 * dispnew.c: Make symbols static if they're not exported.
4769 * dispextern.h (redraw_garbaged_frames, scrolling):
4770 (increment_row_positions): Remove.
4771 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4772 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4774 (redraw_garbaged_frames): Remove; unused.
4776 * xfaces.c: Make symbols static if they're not exported.
4777 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4779 * xterm.h (defined_color): Remove decls.
4780 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4781 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4782 (menu_face_changed_default, defined_color, free_realized_face):
4783 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4784 (ascii_face_of_lisp_face): Remove; unused.
4786 * xdisp.c: Make symbols static if they're not exported.
4787 * dispextern.h (scratch_glyph_row, window_box_edges):
4788 (glyph_to_pixel_coords, set_cursor_from_row):
4789 (get_next_display_element, set_iterator_to_next):
4790 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4791 (show_mouse_face): Remove decls
4792 * frame.h (message_buf_print): Likewise.
4793 * lisp.h (pop_message, set_message, check_point_in_composition):
4795 * xterm.h (set_vertical_scroll_bar): Likewise.
4796 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4797 (message_buf_print, scratch_glyph_row, displayed_buffer):
4798 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4799 (get_next_display_element, show_mouse_face, window_box_edges):
4800 (frame_to_window_pixel_xy, check_point_in_composition):
4801 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4802 (glyph_to_pixel_coords): Remove; unused.
4804 * dired.c (file_name_completion): Now static.
4806 * dbusbind.c (xd_in_read_queued_messages): Now static.
4808 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4809 * data.c (circular_list_error): Remove.
4811 * commands.h (last_point_position, last_point_position_buffer):
4812 (last_point_position_window): Remove decls.
4813 * keyboard.c: Make these variables static.
4815 * coding.h (coding, code_convert_region, encode_coding_gap):
4817 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4818 (iso_code_class, detect_coding, code_convert_region): Now static.
4819 (encode_coding_gap): Remove; unused.
4821 * chartab.c (chartab_chars, chartab_bits): Now static.
4823 * charset.h (charset_iso_8859_1): Remove decl.
4824 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4827 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4828 * ccl.c (Vccl_program_table): Now static.
4829 (check_ccl_update): Remove; unused.
4831 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4832 * category.h: ... from here.
4833 * category.c (check_category_table, set_category_set): Now static.
4835 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4836 * lisp.h: Remove these decls.
4838 * buffer.c (buffer_count): Remove unused var.
4840 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4841 so that it's not optimized away.
4842 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4843 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4844 exported only to the debugger.
4846 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4847 * atimer.h (run_all_atimers): Remove; not exported.
4849 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4850 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4851 was inaccessible from Lisp.
4852 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4853 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4855 alloc.c: Import and export fewer symbols, and remove unused items.
4856 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4858 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4859 it's not optimized away by whole-program optimization.
4860 (message_enable_multibyte, free_misc): Remove.
4861 (catchlist, handlerlist, mark_backtrace):
4862 Declare only if BYTE_MARK_STACK.
4863 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4864 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4865 (message_enable_multibyte): Remove decl.
4866 (free_misc, interval_free_list, float_block, float_block_index):
4867 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4868 (cons_free_list, last_marked_index):
4870 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4871 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4872 (mark_backtrace): Define only if BYTE_MARK_STACK.
4873 * xdisp.c (message_enable_multibyte): Now static.
4875 Declare Lisp_Object Q* variables to be 'static' if not exported.
4876 This makes it easier for human readers (and static analyzers)
4877 to see whether these variables are used from other modules.
4878 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4879 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4880 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4881 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4882 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4883 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4884 * xmenu.c, xselect.c:
4885 Declare Q* vars static if they are not used in other modules.
4886 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4887 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4888 Remove decls of unexported vars.
4889 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4891 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4893 Make Emacs functions such as Fatom 'static' by default.
4894 This makes it easier for human readers (and static analyzers)
4895 to see whether these functions can be called from other modules.
4896 DEFUN now defines a static function. To make the function external
4897 so that it can be used in other C modules, use the new macro DEFUE.
4898 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4899 (Finit_image_library):
4900 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4901 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4902 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4903 Remove decls, since these functions are now static.
4904 (Funintern, Fget_internal_run_time): New decls, since these functions
4905 were already external.
4907 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4908 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4909 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4910 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4911 * keyboard.c, keymap.c, lread.c:
4912 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4913 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4914 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4915 Mark functions with DEFUE instead of DEFUN,
4916 if they are used in other modules.
4917 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4918 decls for now-static functions.
4919 * buffer.h (Fdelete_overlay): Remove decl.
4920 * callproc.c (Fgetenv_internal): Mark as internal.
4921 * composite.c (Fremove_list_of_text_properties): Remove decl.
4922 (Fcomposition_get_gstring): New forward static decl.
4923 * composite.h (Fcomposite_get_gstring): Remove decl.
4924 * dired.c (Ffile_attributes): New forward static decl.
4925 * doc.c (Fdocumntation_property): New forward static decl.
4926 * eval.c (Ffetch_bytecode): New forward static decl.
4927 (Funintern): Remove extern decl; now in .h file where it belongs.
4928 * fileio.c (Fmake_symbolic_link): New forward static decl.
4929 * image.c (Finit_image_library): New forward static decl.
4930 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4931 * intervals.h (Fprevious_property_change):
4932 (Fremove_list_of_text_properties): Remove decls.
4933 * keyboard.c (Fthis_command_keys): Remove decl.
4934 (Fcommand_execute): New forward static decl.
4935 * keymap.c (Flookup_key): New forward static decl.
4936 (Fcopy_keymap): Now static.
4937 * keymap.h (Flookup_key): Remove decl.
4938 * process.c (Fget_process): New forward static decl.
4939 (Fprocess_datagram_address): Mark as internal.
4940 * syntax.c (Fsyntax_table_p): New forward static decl.
4941 (skip_chars): Remove duplicate decl.
4942 * textprop.c (Fprevious_property_change): New forward static decl.
4943 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4945 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4946 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4948 * editfns.c (Fformat): Remove unreachable code.
4950 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4952 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4955 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4957 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4958 when at ZV. (Bug#8487)
4960 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4962 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4964 * keyboard.c (parse_tool_bar_item): Likewise.
4965 * sound.c (sound_cleanup, alsa_close): Likewise.
4966 * termcap.c (tgetent): Likewise.
4967 * xfns.c (x_default_font_parameter): Likewise.
4968 * xsettings.c (read_and_apply_settings): Likewise.
4970 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4971 (overrun_check_free): Protoize.
4973 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4975 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4976 since callers should never pass a negative size.
4977 Change the signature to match that of plain 'read' and 'write'; see
4978 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4979 * lisp.h: Update prototypes of emacs_write and emacs_read.
4981 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4983 * xdisp.c (redisplay_window): Don't try to determine the character
4984 position of the scroll margin if the window start point w->startp
4985 is outside the buffer's accessible region. (Bug#8468)
4987 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4989 Fix write-region and its subroutines for buffers > 2GB.
4990 * fileio.c (a_write, e_write): Modify declaration of arguments and
4991 local variables to support buffers larger than 2GB.
4992 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4994 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4995 argument, local variables, and return value.
4997 * lisp.h: Update prototypes of emacs_write and emacs_read.
4999 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5001 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5003 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5005 Fix more problems found by GCC 4.6.0's static checks.
5007 * xdisp.c (vmessage): Use a better test for character truncation.
5009 * charset.c (load_charset_map): <, not <=, for optimization,
5010 and to avoid potential problems with integer overflow.
5011 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5012 * casetab.c (set_identity, shuffle): Likewise.
5013 * editfns.c (Fformat): Likewise.
5014 * syntax.c (skip_chars): Likewise.
5016 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5017 This also lets GCC 4.6.0 generate slightly better loop code.
5019 * callint.c (Fcall_interactively): <, not <=, for optimization.
5020 (Fcall_interactively): Count the number of arguments produced,
5021 not the number of arguments given. This is simpler and lets GCC
5022 4.6.0 generate slightly better code.
5024 * ftfont.c: Distingish more carefully between FcChar8 and char.
5025 The previous code passed unsigned char * to a functions like
5026 strlen and xstrcasecmp that expect char *, which does not
5027 conform to the C standard.
5028 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5029 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5030 char * when the C standard requires it.
5032 * keyboard.c (read_char): Remove unused var.
5034 * eval.c: Port to Windows vsnprintf (Bug#8435).
5036 (SIZE_MAX): Define if the headers do not.
5037 (verror): Do not give up if vsnprintf returns a negative count.
5038 Instead, grow the buffer. This ports to Windows vsnprintf, which
5039 does not conform to C99. Problem reported by Eli Zaretskii.
5040 Also, simplify the allocation scheme, by avoiding the need for
5041 calling realloc, and removing the ALLOCATED variable.
5043 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5045 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5046 But keep the doprint source code for now, as we might revamp it
5047 and use it again (Bug#8435).
5048 * lisp.h (doprnt): Remove.
5049 * Makefile.in (base_obj): Remove doprnt.o.
5050 * deps.mk (doprnt.o): Remove.
5052 error: Print 32- and 64-bit integers portably (Bug#8435).
5053 Without this change, on typical 64-bit hosts error ("...%d...", N)
5054 was used to print both 32- and 64-bit integers N, which relied on
5056 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5058 * lisp.h (error, verror): Mark as printf-like functions.
5059 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5060 Report overflow in size calculations when allocating printf buffer.
5061 Do not truncate output string at its first null byte.
5062 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5063 Truncate the output at a character boundary, since vsnprintf does not
5065 * charset.c (check_iso_charset_parameter): Convert internal
5066 character to string before calling 'error', since %c now has the
5068 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5069 overflow when computing char to be passed to 'error'. Do not
5070 pass Lisp_Object to 'error'; pass the integer instead.
5071 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5072 formatted with plain %d.
5074 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5076 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5078 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5080 * xterm.c (x_catch_errors): Remove duplicate declaration.
5082 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5084 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5086 2011-04-10 Jim Meyering <meyering@redhat.com>
5088 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5089 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5090 return ssize_t not "int", and use size_t as the buffer length.
5091 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5092 * gnutls.h: Update declarations.
5093 * process.c (read_process_output): Use ssize_t, to match.
5094 (send_process): Likewise.
5096 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5098 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5100 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5102 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5103 Use unsigned char, to match FcChar8 type definition.
5105 * xterm.c (handle_one_xevent):
5106 * xmenu.c (create_and_show_popup_menu):
5107 * xselect.c (x_decline_selection_request)
5108 (x_reply_selection_request): Avoid type-punned deref of X events.
5110 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5112 Fix some uses of `int' instead of EMACS_INT.
5113 * search.c (string_match_1, fast_string_match)
5114 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5115 (scan_buffer, find_next_newline_no_quit)
5116 (find_before_next_newline, search_command, Freplace_match)
5117 (Fmatch_data): Make some `int' variables be EMACS_INT.
5119 * xdisp.c (display_count_lines): 3rd argument and return value now
5120 EMACS_INT. All callers changed.
5121 (pint2hrstr): Last argument is now EMACS_INT.
5123 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5124 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5125 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5126 (decode_coding_utf_16, decode_coding_emacs_mule)
5127 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5128 (decode_coding_ccl, decode_coding_charset)
5129 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5130 (decode_coding_iso_2022, decode_coding_emacs_mule)
5131 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5132 <char_offset, last_offset>: Declare EMACS_INT.
5133 (encode_coding_utf_8, encode_coding_utf_16)
5134 (encode_coding_emacs_mule, encode_invocation_designation)
5135 (encode_designation_at_bol, encode_coding_iso_2022)
5136 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5137 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5139 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5140 (encode_invocation_designation): Last argument P_NCHARS is now
5142 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5143 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5145 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5148 * ccl.c (Fccl_execute_on_string): Declare some variables
5151 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5153 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5155 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5157 * process.c (Fformat_network_address): Doc fix.
5159 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5161 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5163 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5165 * keyboard.c (read_char): Call Lisp function help-form-show,
5166 instead of using internal_with_output_to_temp_buffer.
5167 (Qhelp_form_show): New var.
5168 (syms_of_keyboard): Use DEFSYM macro.
5170 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5172 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5174 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5176 * process.c (Flist_processes): Remove to Lisp.
5177 (list_processes_1): Delete.
5179 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5181 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5183 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5185 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5187 Fix more problems found by GCC 4.6.0's static checks.
5189 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5191 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5193 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5195 * xdisp.c (vmessage): Mark as a printf-like function.
5197 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5199 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5201 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5202 printf-like functions.
5203 (tiff_load): Add casts to remove these marks before passing them
5204 to system-supplied API.
5206 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5208 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5209 This avoids several warnings with gcc -Wstrict-overflow.
5210 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5211 directly, rather than having caller test rule sign. This avoids
5212 some unnecessary tests.
5213 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5214 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5215 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5217 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5218 (xfont_open): Avoid unnecessary tests.
5220 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5222 * composite.h, composite.c (composition_gstring_put_cache):
5223 Use EMACS_INT, not int, for length.
5225 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5226 breaking out part of COMPOSITION_DECODE_RULE.
5227 (COMPOSITION_DECODE_RULE): Use it.
5228 * composite.c (get_composition_id): Remove unused local vars,
5229 by using the new macro.
5231 * textprop.c (set_text_properties_1): Change while to do-while,
5232 since the condition is always true at first.
5234 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5235 (interval_deletion_adjustment): Return unsigned value.
5238 * process.c (list_processes_1, create_pty, read_process_output):
5239 (exec_sentinel): Remove vars that were set but not used.
5240 (create_pty): Remove unnecessary "volatile"s.
5241 (Fnetwork_interface_info): Avoid possibility of int overflow.
5242 (read_process_output): Do adaptive read buffering even if carryover.
5243 (read_process_output): Simplify nbytes computation if buffered.
5245 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5247 * syntax.c (scan_words): Remove var that was set but not used.
5248 (update_syntax_table): Use unsigned instead of int.
5250 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5251 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5252 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5254 * print.c (print_error_message): Avoid int overflow.
5256 * font.c (font_list_entities): Redo for clarity,
5257 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5259 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5260 (font_score): Avoid potential overflow in diff calculation.
5262 * fns.c (substring_both): Remove var that is set but not used.
5263 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5265 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5267 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5268 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5269 can always succeed if overflow has undefined behavior.
5271 * search.c (boyer_moore, wordify): Remove vars set but not used.
5272 (wordify): Omit three unnecessary tests.
5274 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5275 All callers changed. This avoids the need for an unused var.
5277 * casefiddle.c (casify_region): Remove var that is set but not used.
5279 * dired.c (file_name_completion): Remove var that is set but not used.
5281 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5283 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5284 (Finsert_file_contents): Remove unnecessary code checking fd.
5286 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5287 Check for integer overflow on size calculations.
5289 * buffer.c (Fprevious_overlay_change): Remove var that is set
5292 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5293 Remove vars that are set but not used.
5294 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5295 (timer_check_2): Mark vars as initialized.
5297 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5299 * image.c (lookup_image): Remove var that is set but not used.
5300 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5302 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5303 that are set but not used.
5305 * xfns.c (make_invisible_cursor): Don't return garbage
5306 if XCreateBitmapFromData fails (Bug#8410).
5308 * xselect.c (x_get_local_selection, x_handle_property_notify):
5309 Remove vars that are set but not used.
5311 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5312 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5314 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5315 Remove var that is set but not used.
5316 (scroll_bar_windows_size): Now size_t, not int.
5317 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5320 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5321 (map_tty_color) [!defined MSDOS]: Likewise.
5323 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5325 * coding.c: Remove vars that are set but not used.
5326 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5327 All callers changed.
5328 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5329 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5330 (decode_coding_charset): Remove vars that are set but not used.
5332 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5333 that is set but not used.
5335 * print.c (print_object): Remove var that is set but not used.
5337 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5338 The gnulib version avoids calling malloc in the usual case,
5339 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5340 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5341 * filelock.c (current_lock_owner): Likewise.
5342 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5343 * sysdep.c: Include allocator.h, careadlinkat.h.
5344 (emacs_no_realloc_allocator): New static constant.
5345 (emacs_readlink): New function.
5346 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5347 ../lib/careadlinkat.h.
5349 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5351 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5352 first non-nil return value).
5354 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5356 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5357 if not defined (Bug#8403).
5359 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5361 * xdisp.c (display_count_lines): Remove parameter `start',
5362 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5363 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5364 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5365 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5366 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5367 and thereabouts. All callers changed.
5368 (get_per_char_metric): Remove parameter `f', unused since
5369 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5371 2011-04-02 Jim Meyering <meyering@redhat.com>
5373 do not dereference NULL upon failed strdup
5374 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5375 (ns_get_family): Likewise.
5377 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5379 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5381 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5383 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5386 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5388 Add lexical binding.
5390 * window.c (Ftemp_output_buffer_show): New fun.
5391 (Fsave_window_excursion):
5392 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5394 * lread.c (lisp_file_lexically_bound_p): New function.
5395 (Fload): Bind Qlexical_binding.
5396 (readevalloop): Remove `evalfun' arg.
5397 Bind Qinternal_interpreter_environment.
5398 (Feval_buffer): Bind Qlexical_binding.
5399 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5401 (syms_of_lread): Declare `lexical-binding'.
5403 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5405 * keyboard.c (eval_dyn): New fun.
5406 (menu_item_eval_property): Use it.
5408 * image.c (parse_image_spec): Use Ffunctionp.
5410 * fns.c (concat, mapcar1): Accept byte-code-functions.
5412 * eval.c (Fsetq): Handle lexical vars.
5413 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5414 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5415 (FletX, Flet): Obey lexical binding.
5416 (Fcommandp): Handle closures.
5417 (Feval): New `lexical' arg.
5418 (eval_sub): New function extracted from Feval. Use it almost
5419 everywhere where Feval was used. Look up vars in lexical env.
5421 (Ffunctionp): Move from subr.el.
5422 (Ffuncall): Handle closures.
5423 (apply_lambda): Remove `eval_flags'.
5424 (funcall_lambda): Handle closures and new byte-code-functions.
5425 (Fspecial_variable_p): New function.
5426 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5427 but without exporting it to Lisp.
5429 * doc.c (Fdocumentation, store_function_docstring):
5430 * data.c (Finteractive_form): Handle closures.
5432 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5435 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5437 (exec_byte_code): New function extracted from Fbyte_code to handle new
5438 calling convention for byte-code-functions. Add new byte-codes.
5440 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5442 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5444 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5446 * xdisp.c (redisplay_internal): Fix prototype.
5448 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5450 * xdisp.c (SCROLL_LIMIT): New macro.
5451 (try_scrolling): Use it when setting scroll_limit.
5452 Limit scrolling to 100 screen lines.
5453 (redisplay_window): Even when falling back on "recentering",
5454 position point in the window according to scroll-conservatively,
5455 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5457 (try_scrolling): When point is above the window, allow searching
5458 as far as scroll_max, or one screenful, to compute vertical
5459 distance from PT to the scroll margin position. This prevents
5460 try_scrolling from unnecessarily failing when
5461 scroll-conservatively is set to a value slightly larger than the
5462 window height. Clean up the case of PT below the margin at bottom
5463 of window: scroll_max can no longer be INT_MAX. When aggressive
5464 scrolling is in use, don't let point enter the opposite scroll
5465 margin as result of the scroll.
5466 (syms_of_xdisp) <scroll-conservatively>: Document the
5467 threshold of 100 lines for never-recentering scrolling.
5469 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5471 * dispextern.h (move_it_by_lines):
5472 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5473 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5474 (message_log_check_duplicate): Remove parameters `prev_bol' and
5475 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5476 (redisplay_internal): Remove parameter `preserve_echo_area',
5477 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5479 * indent.c (Fvertical_motion):
5480 * window.c (window_scroll_pixel_based, Frecenter):
5481 Don't pass `need_y_p' to `move_it_by_lines'.
5483 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5485 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5486 steal a few bits to be more compact.
5487 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5488 Remove unneeded casts.
5490 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5492 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5494 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5495 binding" message (bug#7967).
5497 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5499 Fix more problems found by GCC 4.6.0's static checks.
5501 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5502 Remove unused local var.
5504 * editfns.c (Fmessage_box): Remove unused local var.
5506 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5507 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5508 Omit unused local vars.
5509 * window.c (shrink_windows): Omit unused local var.
5510 * menu.c (digest_single_submenu): Omit unused local var.
5511 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5512 Omit unused local var.
5514 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5515 Don't assume string length fits in int.
5516 (keyremap_step, read_key_sequence): Use size_t for sizes.
5517 (read_key_sequence): Don't check last_real_key_start redundantly.
5519 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5520 instead of alloca (Bug#8344).
5522 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5523 (Fbacktrace_frame): Don't assume nframes fits in int.
5525 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5527 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5530 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5532 * cm.c (calccost): Turn while-do into do-while, for clarity.
5534 * keyboard.c (syms_of_keyboard): Use the same style as later
5535 in this function when indexing through an array. This also
5536 works around GCC bug 48267.
5538 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5540 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5542 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5543 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5545 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5546 This avoids undefined behavior on integer overflow, and is a bit
5547 more convenient anyway since it is compared to a size_t variable.
5549 Variadic C functions now count arguments with size_t, not int.
5550 This avoids an unnecessary limitation on 64-bit machines, which
5551 caused (substring ...) to crash on large vectors (Bug#8344).
5552 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5553 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5554 All variadic functions and their callers changed accordingly.
5555 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5556 * data.c (arith_driver, float_arith_driver): Likewise.
5557 * editfns.c (general_insert_function): Likewise.
5558 * eval.c (struct backtrace.nargs, interactive_p)
5559 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5560 (funcall_lambda, mark_backtrace): Likewise.
5561 * fns.c (concat): Likewise.
5562 * frame.c (x_set_frame_parameters): Likewise.
5563 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5564 0 if not found, not -1. All callers changed.
5566 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5567 (stack_copy_size): Now size_t, not int.
5568 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5570 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5572 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5573 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5574 All callers changed.
5576 * lisp.h (multibyte_char_to_unibyte):
5577 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5578 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5579 * character.h (CHAR_TO_BYTE8):
5580 * cmds.c (internal_self_insert):
5581 * editfns.c (general_insert_function):
5582 * keymap.c (push_key_description):
5583 * search.c (Freplace_match):
5584 * xdisp.c (message_dolog, set_message_1): All callers changed.
5586 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5588 * keyboard.c (safe_run_hook_funcall): New function.
5589 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5590 don't set the hook to nil, but remove the offending function instead.
5591 (Qcommand_hook_internal): Remove, unused.
5592 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5593 Vcommand_hook_internal.
5595 * eval.c (enum run_hooks_condition): Remove.
5596 (funcall_nil, funcall_not): New functions.
5597 (run_hook_with_args): Call each function through a `funcall' argument.
5598 Remove `cond' argument, now redundant.
5599 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5600 (Frun_hook_with_args_until_failure): Adjust accordingly.
5601 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5603 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5605 * dispextern.h (string_buffer_position): Remove declaration.
5607 * print.c (strout): Remove parameter `multibyte', unused since
5608 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5610 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5611 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5612 All callers changed.
5614 * w32.c (_wsa_errlist): Use braces for struct initializers.
5616 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5617 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5618 All callers changed.
5619 (string_buffer_position): Likewise. Also, make static (it's never
5620 used outside xdisp.c).
5621 (cursor_row_p): Remove parameter `w', unused since
5622 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5623 (decode_mode_spec): Remove parameter `precision', introduced during
5624 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5625 All callers changed.
5627 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5629 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5631 2011-03-27 Anders Lindgren <andlind@gmail.com>
5633 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5634 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5635 (ns_update_auto_hide_menu_bar): New functions.
5636 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5637 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5638 ns_constrain_all_frames.
5639 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5640 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5642 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5644 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5646 2011-03-27 Glenn Morris <rgm@gnu.org>
5648 * syssignal.h: Replace RETSIGTYPE with void.
5649 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5650 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5651 Replace SIGTYPE with void everywhere.
5652 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5653 * s/template.h (SIGTYPE): Remove commented out definition.
5655 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5657 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5658 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5660 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5662 * w32.c (read_unc_volume): Use parameter `henum', instead of
5663 global variable `wget_enum_handle'.
5665 * keymap.c (describe_vector): Remove parameters `indices' and
5666 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5667 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5669 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5671 * keyboard.c (timer_check): Remove parameter `do_it_now',
5672 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5673 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5674 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5676 * keyboard.c (read_char):
5677 * w32menu.c (w32_menu_display_help):
5678 * xmenu.c (show_help_event, menu_help_callback):
5679 Adjust calls to `show_help_echo'.
5681 * gtkutil.c (xg_maybe_add_timer):
5682 * keyboard.c (readable_events):
5683 * process.c (wait_reading_process_output):
5684 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5686 * insdel.c (adjust_markers_gap_motion):
5687 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5688 (gap_left, gap_right): Don't call it.
5690 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5692 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5693 incurred during fontification.
5695 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5697 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5698 (DEFVAR_PER_BUFFER): Don't pass it.
5700 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5701 (scrolling_window): Don't pass it.
5703 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5705 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5707 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5709 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5710 of variables specific to SELinux and computation of `encoded_absname'.
5712 * image.c (XPutPixel): Remove unused variable `height'.
5714 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5716 * unexw32.c (get_section_info): Remove unused variable `section'.
5718 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5719 (system_process_attributes): Remove unused variable `sess'.
5720 (sys_read): Remove unused variable `err'.
5722 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5723 (w32_wnd_proc): Remove unused variable `isdead'.
5724 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5725 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5726 (x_create_tip_frame): Remove unused variable `tem'.
5728 * w32inevt.c (w32_console_read_socket):
5729 Remove unused variable `no_events'.
5731 * w32term.c (x_draw_composite_glyph_string_foreground):
5732 Remove unused variable `width'.
5734 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5736 * w32term.c (x_set_glyph_string_clipping):
5737 Don't pass uninitialized region to CombineRgn.
5739 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5741 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5742 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5743 (Fx_close_connection): Remove unused variable `i'.
5745 * w32font.c (w32font_draw): Return number of glyphs.
5746 (w32font_open_internal): Remove unused variable `i'.
5747 (w32font_driver): Add missing initializer.
5749 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5750 (fill_in_menu): Remove unused variable `items_added'.
5752 * w32term.c (last_mouse_press_frame): Remove static global variable.
5753 (w32_clip_to_row): Remove unused variable `f'.
5754 (x_delete_terminal): Remove unused variable `i'.
5756 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5757 (NOTHING): Remove unused static global variable.
5758 (uniscribe_check_otf): Remove unused variable `table'.
5759 (uniscribe_font_driver): Add missing initializers.
5761 2011-03-23 Julien Danjou <julien@danjou.info>
5763 * term.c (Fsuspend_tty, Fresume_tty):
5764 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5765 * window.c (temp_output_buffer_show):
5766 * insdel.c (signal_before_change):
5767 * frame.c (Fhandle_switch_frame):
5768 * fileio.c (Fdo_auto_save):
5769 * emacs.c (Fkill_emacs):
5770 * editfns.c (save_excursion_restore):
5771 * cmds.c (internal_self_insert):
5772 * callint.c (Fcall_interactively):
5773 * buffer.c (Fkill_all_local_variables):
5774 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5776 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5777 unconditionnaly since it does the check itself.
5779 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5781 Fix more problems found by GCC 4.5.2's static checks.
5783 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5784 the first time through the loop, since we know p0 < p1 then.
5785 This also avoids a gcc -Wstrict-overflow warning.
5787 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5788 leading to a memory leak, possible in functions like
5789 load_charset_map_from_file that can allocate an unbounded number
5790 of objects (Bug#8318).
5792 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5793 that could (at least in theory) be that large.
5795 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5796 This is less likely to overflow, and avoids undefined behavior if
5797 overflow does occur. All callers changed. Use strtoul to scan
5798 for the unsigned long integer.
5799 (pint2hrstr): Simplify and tune code slightly.
5800 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5802 * scroll.c (do_scrolling): Work around GCC bug 48228.
5803 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5805 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5806 This also avoids a warning with gcc -Wstrict-overflow.
5807 (validate_x_resource_name): Simplify count usage.
5808 This also avoids a warning with gcc -Wstrict-overflow.
5810 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5813 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5815 * process.c (Fmake_network_process): Use socklen_t, not int,
5816 where POSIX says socklen_t is required in portable programs.
5817 This fixes a porting bug on hosts like 64-bit HP-UX, where
5818 socklen_t is wider than int (Bug#8277).
5819 (Fmake_network_process, server_accept_connection):
5820 (wait_reading_process_output, read_process_output):
5823 * process.c: Rename or move locals to avoid shadowing.
5824 (list_processes_1, Fmake_network_process):
5825 (read_process_output_error_handler, exec_sentinel_error_handler):
5826 Rename or move locals.
5827 (Fmake_network_process): Define label "retry_connect" only if needed.
5828 (Fnetwork_interface_info): Fix pointer signedness.
5829 (process_send_signal): Add cast to avoid pointer signedness problem.
5830 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5831 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5833 Make tparam.h and terminfo.c consistent.
5834 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5835 Include tparam.h instead, since it declares them.
5836 * cm.h (PC): Remove extern decl; tparam.h now does this.
5837 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5838 * terminfo.c: Include tparam.h, to check interfaces.
5839 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5840 (tparam): Adjust signature to match interface in tparam.h;
5841 this removes some undefined behavior. Check that outstring and len
5842 are zero, which they always are with Emacs.
5843 * tparam.h (PC, BC, UP): New extern decls.
5845 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5846 (xftfont_open): Rename locals to avoid shadowing.
5848 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5849 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5850 (OTF_TAG_SYM): Omit macro if not needed.
5851 (ftfont_list): Remove unused local.
5852 (get_adstyle_property, ftfont_pattern_entity):
5853 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5854 Rename locals to avoid shadowing.
5856 * xfont.c (xfont_list_family): Mark var as initialized.
5858 * xml.c (make_dom): Now static.
5860 * composite.c (composition_compute_stop_pos): Rename local to
5862 (composition_reseat_it): Remove unused locals.
5863 (find_automatic_composition, composition_adjust_point): Likewise.
5864 (composition_update_it): Mark var as initialized.
5865 (find_automatic_composition): Mark vars as initialized,
5866 with a FIXME (Bug#8290).
5868 character.h: Rename locals to avoid shadowing.
5869 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5870 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5871 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5872 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5875 * textprop.c (property_change_between_p): Remove; unused.
5877 * intervals.c (interval_start_pos): Now static.
5879 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5881 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5882 Rename locals to avoid shadowing.
5884 * sound.c (wav_play, au_play, Fplay_sound_internal):
5885 Fix pointer signedness.
5886 (alsa_choose_format): Remove unused local var.
5887 (wav_play): Initialize a variable to 0, to prevent undefined
5888 behavior (Bug#8278).
5890 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5892 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5894 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5895 clobbering (Bug#8298).
5896 * sysdep.c (sys_subshell): Likewise.
5897 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5899 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5900 This should get cleaned up, so that child_setup has the
5901 same signature on all platforms.
5903 * callproc.c (call_process_cleanup): Now static.
5904 (relocate_fd): Rename locals to avoid shadowing.
5906 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5908 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5909 not to be necessary, and produces flickering.
5911 2011-03-20 Glenn Morris <rgm@gnu.org>
5913 * config.in: Remove file.
5915 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5917 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5918 are now in src/globals.h.
5919 (syms_of_minibuf): Remove spurious & from previous change.
5921 2011-03-20 Leo <sdl.web@gmail.com>
5923 * minibuf.c (completing-read-function): New variable.
5924 (completing-read-default): Rename from completing-read.
5925 (completing-read): Call completing-read-function.
5927 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5929 * xfaces.c (Fx_load_color_file):
5930 Read color file from absolute filename (bug#8250).
5932 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5934 * makefile.w32-in: Update dependencies.
5936 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5938 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5940 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5942 Fix more problems found by GCC 4.5.2's static checks.
5944 * process.c (make_serial_process_unwind, send_process_trap):
5945 (sigchld_handler): Now static.
5947 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5948 That way, the code declares only the vars that it needs.
5949 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5950 * s/cygwin.h (PTY_ITERATION): Likewise.
5951 * s/darwin.h (PTY_ITERATION): Likewise.
5952 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5954 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5955 * process.c (allocate_pty): Don't declare stb unless it's needed.
5957 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5958 (CONSTANTLIM): Remove; unused.
5959 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5960 Define only if needed.
5962 * unexelf.c (unexec): Name an expression,
5963 to avoid gcc -Wbad-function-cast warning.
5964 Use a different way to cause a compilation error if anyone uses
5965 n rather than nn, a way that does not involve shadowing.
5966 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5968 * deps.mk (unexalpha.o): Remove; unused.
5970 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5971 * unexec.h: New file.
5972 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5973 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5975 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5976 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5977 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5978 Change as necessary to match prototype in unexec.h.
5980 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5982 (back_comment, skip_chars): Mark vars as initialized.
5984 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5985 Rename locals to avoid shadowing.
5987 * lread.c (read1): Rewrite so as not to use empty "else".
5988 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5990 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5992 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5993 warning when compiling print.c.
5995 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5996 instead of using an uninitialized var.
5997 (font_sort_entities): Mark var as initialized.
5999 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6001 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6002 pointers to constants.
6003 (font_parse_fcname): Remove unused vars.
6004 (font_delete_unmatched): Now static.
6005 (font_get_spec): Remove; unused.
6006 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6007 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6008 Rename or move locals to avoid shadowing.
6010 * fns.c (require_nesting_list, require_unwind): Now static.
6011 (Ffillarray): Rename locals to avoid shadowing.
6013 * floatfns.c (domain_error2): Define only if needed.
6014 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6016 * alloc.c (mark_backtrace): Move decl from here ...
6017 * lisp.h: ... to here, so that it can be checked.
6019 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6020 (Fdefvar): Rewrite so as not to use empty "else".
6021 (lisp_indirect_variable): Name an expression,
6022 to avoid gcc -Wbad-function-cast warning.
6023 (Fdefvar): Rename locals to avoid shadowing.
6025 * callint.c (quotify_arg, quotify_args): Now static.
6026 (Fcall_interactively): Rename locals to avoid shadowing.
6027 Use const pointer when appropriate.
6029 * lisp.h (get_system_name, get_operating_system_release):
6030 Move decls here, to check interfaces.
6031 * process.c (get_operating_system_release): Move decl to lisp.h.
6032 * xrdb.c (get_system_name): Likewise.
6033 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6034 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6035 some of which prompt warnings from gcc -Wbad-function-cast.
6036 (Fformat_time_string, Fencode_time, Finsert_char):
6037 (Ftranslate_region_internal, Fformat):
6038 Rename or remove local vars to avoid shadowing.
6039 (Ftranslate_region_internal): Mark var as initialized.
6041 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6044 * lisp.h (eassert): Check that the argument compiles, even if
6045 ENABLE_CHECKING is not defined.
6047 * data.c (Findirect_variable): Name an expression, to avoid
6048 gcc -Wbad-function-cast warning.
6049 (default_value, arithcompare, arith_driver, arith_error): Now static.
6050 (store_symval_forwarding): Rename local to avoid shadowing.
6051 (Fmake_variable_buffer_local, Fmake_local_variable):
6052 Mark variables as initialized.
6053 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6055 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6056 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6057 Rename locals to avoid shadowing.
6058 (mark_stack): Move local variables into the #ifdef region where
6060 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6061 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6063 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6064 (GC_STRING_CHARS): Remove; not used.
6065 (Fmemory_limit): Cast sbrk's returned value to char *.
6067 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6068 avoids undefined behavior in theory.
6070 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6072 Use functions, not macros, for up- and down-casing (Bug#8254).
6073 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6074 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6075 to use the following functions instead of these macros.
6076 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6077 EMACS_INT, since callers assume the returned value fits in int.
6078 (upcase1): Likewise, for UPCASE_TABLE.
6079 (uppercasep, lowercasep, upcase): New static inline functions.
6080 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6081 the race-condition problem in the old DOWNCASE.
6083 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6084 Rename locals to avoid shadowing.
6085 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6086 (regex_compile, re_search_2, re_match_2_internal):
6087 Remove unused local vars.
6088 (FREE_VAR): Rewrite so as not to use empty "else",
6089 which gcc can warn about.
6090 (regex_compile, re_match_2_internal): Mark locals as initialized.
6091 (RETALLOC_IF): Define only if needed.
6092 (WORDCHAR_P): Likewise. This one is never needed, but is used
6093 only in a comment talking about a compiler bug, so put inside
6094 the #if 0 of that comment.
6095 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6096 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6099 * search.c (boyer_moore): Rename locals to avoid shadowing.
6100 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6101 (PREV_CHAR_BOUNDARY): Likewise.
6103 * search.c (simple_search): Remove unused var.
6105 * dired.c (compile_pattern): Move decl from here ...
6106 * lisp.h: ... to here, so that it can be checked.
6107 (struct re_registers): New forward decl.
6109 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6111 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6113 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6114 Rename locals to avoid shadowing.
6115 (Fvertical_motion): Mark locals as initialized.
6117 * casefiddle.c (casify_object, casify_region): Now static.
6118 (casify_region): Mark local as initialized.
6120 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6122 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6123 New macros, so that the caller can use some names other than
6124 gcpro1, gcpro2, etc.
6125 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6127 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6128 argument, for consistency with GCPRO2_VAR, etc: it is now the
6129 prefix of the variable, not the variable itself. All uses
6131 * dired.c (directory_files_internal, file_name_completion):
6132 Rename locals to avoid shadowing.
6134 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6135 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6136 dired.c's scmp function, had undefined behavior.
6137 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6138 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6139 * buffer.h: ... to here, because these macros use current_buffer,
6140 and the new implementation with inline functions needs to have
6141 current_buffer in scope now, rather than later when the macros
6143 (downcase, upcase1): New static inline functions.
6144 (DOWNCASE, UPCASE1): Reimplement using these functions.
6145 This avoids undefined behavior in expressions like
6146 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6147 from race conditions in accessing the global variables
6148 case_temp1 and case_temp2.
6149 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6150 * lisp.h (case_temp1, case_temp2): Remove their decls.
6151 * character.h (ASCII_CHAR_P): Move from here ...
6152 * lisp.h: ... to here, so that the inline functions mentioned
6155 * dired.c (directory_files_internal_unwind): Now static.
6157 * fileio.c (file_name_as_directory, directory_file_name):
6158 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6160 (file_name_as_directory): Use const pointers when appropriate.
6161 (Fexpand_file_name): Likewise. In particular, newdir might
6162 point at constant storage, so make it a const pointer.
6163 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6164 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6166 (Fset_file_times, Finsert_file_contents, auto_save_error):
6167 Rename locals to avoid shadowing.
6169 * minibuf.c (choose_minibuf_frame_1): Now static.
6170 (Ftry_completion, Fall_completions): Rename or remove locals
6173 * marker.c (bytepos_to_charpos): Remove; unused.
6175 * lisp.h (verify_bytepos, count_markers): New decls,
6176 so that gcc does not warn that these functions aren't declared.
6178 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6179 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6180 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6181 (copy_text): Remove unused local var.
6183 * filelock.c (within_one_second): Now static.
6184 (lock_file_1): Rename local to avoid shadowing.
6186 * buffer.c (fix_overlays_before): Mark locals as initialized.
6187 (fix_start_end_in_overlays): Likewise. This function should be
6188 simplified by using pointers-to-pointers, but that's a different
6190 (switch_to_buffer_1): Now static.
6191 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6192 (report_overlay_modification): Rename locals to avoid shadowing.
6194 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6195 Fix pointer signedness issue.
6196 (sys_subshell): Mark local as volatile if checking for lint,
6197 to suppress a gcc -Wclobbered warning that does not seem to be right.
6198 (MAXPATHLEN): Define only if needed.
6200 * process.c (serial_open, serial_configure): Move decls from here ...
6201 * systty.h: ... to here, so that they can be checked.
6203 * fns.c (get_random, seed_random): Move extern decls from here ...
6204 * lisp.h: ... to here, so that they can be checked.
6206 * sysdep.c (reset_io): Now static.
6207 (wait_for_termination_signal): Remove; unused.
6209 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6210 (copy_keymap_item, append_key, push_text_char_description):
6212 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6213 (DENSE_TABLE_SIZE): Remove; unused.
6214 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6215 (describe_map_tree):
6216 Rename locals to avoid shadowing.
6218 * keyboard.c: Declare functions static if they are not used elsewhere.
6219 (echo_char, echo_dash, cmd_error, top_level_2):
6220 (poll_for_input, handle_async_input): Now static.
6221 (read_char, kbd_buffer_get_event, make_lispy_position):
6222 (make_lispy_event, make_lispy_movement, apply_modifiers):
6223 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6224 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6225 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6226 (read_key_sequence, read_char): Mark locals as initialized.
6227 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6229 * keyboard.h (make_ctrl_char): New decl.
6230 (mark_kboards): Move decl here ...
6231 * alloc.c (mark_kboards): ... from here.
6233 * lisp.h (force_auto_save_soon): New decl.
6235 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6236 (DEFINE_DUMMY_FUNCTION): New macro.
6237 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6239 (main): Add casts to avoid warnings
6240 if GCC considers string literals to be constants.
6242 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6244 * dbusbind.c: Pointer signedness fixes.
6245 (xd_signature, xd_append_arg, xd_initialize):
6246 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6247 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6248 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6249 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6251 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6252 if GCC considers string literals to be constants.
6253 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6255 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6257 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6258 (print_preprocess, print_object): New macro to fix last change.
6260 * print.c (print_preprocess): Don't forget font objects.
6262 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6264 * emacs.c (USAGE3): Doc fixes.
6266 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6268 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6271 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6273 * lisp.h (VWindow_system, Qfile_name_history):
6274 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6275 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6276 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6278 * w32select.c: Don't #include "keyboard.h".
6279 (run_protected): Add extern declaration for waiting_for_input.
6281 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6282 * w32console.c (detect_input_pending, read_input_pending)
6283 (encode_terminal_code):
6284 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6285 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6286 (w32_system_caret_y, Qfile_name_history):
6287 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6288 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6289 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6290 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6291 * w32proc.c (Qlocal, report_file_error):
6292 * w32term.c (Vwindow_system, updating_frame):
6293 * w32uniscribe.c (initialized, uniscribe_font_driver):
6294 Remove unneeded extern declarations.
6296 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6298 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6300 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6302 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6303 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6304 These macros can no longer be used for assignment.
6306 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6307 Assign struct members directly, instead of using BUF_BEGV etc.
6308 (record_buffer_markers, fetch_buffer_markers): New functions for
6309 recording and fetching special buffer markers.
6310 (set_buffer_internal_1, set_buffer_temp): Use them.
6312 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6314 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6316 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6317 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6319 * xdisp.c (hscroll_window_tree):
6320 (reconsider_clip_changes): Use PT instead of BUF_PT.
6322 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6324 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6325 $(EMACS_ROOT)/lib/intprops.h.
6327 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6329 Fix more problems found by GCC 4.5.2's static checks.
6331 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6332 to unsigned char * to avoid compiler diagnostic.
6333 (xg_free_frame_widgets): Make it clear that a local variable is
6334 needed only if USE_GTK_TOOLTIP.
6335 (gdk_window_get_screen): Make it clear that this macro is needed
6336 only if USE_GTK_TOOLTIP.
6337 (int_gtk_range_get_value): New function, which avoids a diagnostic
6338 from gcc -Wbad-function-cast.
6339 (xg_set_toolkit_scroll_bar_thumb): Use it.
6340 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6341 diagnostic from gcc -Wbad-function-cast.
6342 (get_utf8_string, xg_get_file_with_chooser):
6343 Rename locals to avoid shadowing.
6344 (create_dialog): Move locals to avoid shadowing.
6346 * xgselect.c (xg_select): Remove unused var.
6348 * image.c (four_corners_best): Mark locals as initialized.
6349 (gif_load): Initialize transparent_p to zero (Bug#8238).
6350 Mark another local as initialized.
6351 (my_png_error, my_error_exit): Mark with NO_RETURN.
6353 * image.c (clear_image_cache): Now static.
6354 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6355 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6356 (x_edge_detection): Remove unnecessary cast that
6357 gcc -Wbad-function-cast diagnoses.
6358 (gif_load): Fix pointer signedness.
6359 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6360 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6362 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6364 Improve quality of tests for time stamp overflow.
6365 For example, without this patch (encode-time 0 0 0 1 1
6366 1152921504606846976) returns the obviously-bogus value (-948597
6367 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6368 reports time overflow. See
6369 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6370 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6371 * editfns.c: Include limits.h and intprops.h.
6372 (TIME_T_MIN, TIME_T_MAX): New macros.
6373 (time_overflow): Move earlier, to before first use.
6374 (hi_time, lo_time): New functions, for an accurate test for
6376 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6377 (Fget_internal_run_time): Don't assume time_t fits in int.
6378 (make_time): Use list2 instead of Fcons twice.
6379 (Fdecode_time): More accurate test for out-of-range times.
6380 (check_tm_member): New function.
6381 (Fencode_time): Use it, to test for out-of-range times.
6382 (lisp_time_argument): Don't rely on undefined left-shift and
6383 right-shift behavior when checking for time stamp overflow.
6385 * editfns.c (time_overflow): New function, refactoring common code.
6386 (Fformat_time_string, Fdecode_time, Fencode_time):
6387 (Fcurrent_time_string): Use it.
6389 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6390 * dired.c (make_time): Move to ...
6391 * editfns.c (make_time): ... here.
6392 * systime.h: Note the move.
6394 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6396 * fringe.c (update_window_fringes): Remove unused variables.
6398 * unexmacosx.c (copy_data_segment): Also copy __got section.
6401 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6403 * termcap.c [MSDOS]: Include "msdos.h".
6404 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6405 Constify `char *' arguments and their references according to
6406 prototypes in tparam.h.
6408 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6410 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6411 Adapt all references accordingly.
6413 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6415 2011-03-11 Tom Tromey <tromey@redhat.com>
6417 * buffer.c (syms_of_buffer): Remove obsolete comment.
6419 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6421 * termhooks.h (encode_terminal_code): Declare prototype.
6423 * msdos.c (encode_terminal_code): Don't declare prototype.
6425 * term.c (encode_terminal_code): Now external again, used by
6426 w32console.c and msdos.c.
6428 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6429 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6431 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6433 Fix some minor problems found by GCC 4.5.2's static checks.
6435 * fringe.c (update_window_fringes): Mark locals as initialized
6437 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6439 * alloc.c (mark_fringe_data): Move decl from here ...
6440 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6441 to check its interface.
6442 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6444 * fontset.c (free_realized_fontset): Now static.
6445 (Fset_fontset_font): Rename local to avoid shadowing.
6446 (fontset_font): Mark local as initialized.
6447 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6449 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6451 * xselect.c (x_disown_buffer_selections): Remove; not used.
6452 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6453 (x_own_selection, Fx_disown_selection_internal): Rename locals
6455 (x_handle_dnd_message): Remove local to avoid shadowing.
6457 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6458 so that the caller can use some name other than gcpro1.
6459 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6460 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6461 (Fx_backspace_delete_keys_p):
6462 Use them to avoid shadowing, and rename vars to avoid shadowing.
6463 (x_decode_color, x_set_name, x_window): Now static.
6464 (Fx_create_frame): Add braces to silence GCC warning.
6465 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6466 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6467 Remove unused locals.
6468 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6469 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6470 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6473 * xterm.h (x_mouse_leave): New decl.
6475 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6476 Remove unused functions.
6477 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6478 (x_calc_absolute_position): Now static.
6479 (XTread_socket): Don't define label "out" unless it's used.
6480 Don't declare local "event" unless it's used.
6481 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6482 unless they are used.
6483 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6484 (x_fatal_error_signal): Remove; not used.
6485 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6486 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6487 (x_error_catcher, x_connection_closed, x_error_handler):
6488 (x_error_quitter, xembed_send_message, x_iconify_frame):
6489 (my_log_handler): Rename locals to avoid shadowing.
6490 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6491 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6493 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6494 Rename or move locals to avoid shadowing.
6495 (tty_defined_color, merge_face_heights): Now static.
6496 (free_realized_faces_for_fontset): Remove; not used.
6497 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6498 does not deduce is never used uninitialized.
6499 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6500 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6502 * terminal.c (store_terminal_param): Now static.
6504 * xmenu.c (menu_highlight_callback): Now static.
6505 (set_frame_menubar): Remove unused local.
6506 (xmenu_show): Rename parameter to avoid shadowing.
6507 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6508 since they might point to immutable storage.
6509 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6510 since it's unused otherwise.
6512 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6513 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6514 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6515 avoids a gcc -Wuninitialized diagnostic.
6516 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6517 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6518 does not deduce are never used uninitialized.
6520 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6522 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6523 * window.c (window_loop, size_window):
6524 (run_window_configuration_change_hook, enlarge_window): Likewise.
6526 * window.c (display_buffer): Now static.
6527 (size_window): Mark variables that gcc -Wuninitialized
6528 does not deduce are never used uninitialized.
6529 * window.h (check_all_windows): New decl, to forestall
6530 gcc -Wmissing-prototypes diagnostic.
6531 * dispextern.h (bidi_dump_cached_states): Likewise.
6533 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6535 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6537 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6538 and to avoid gcc -Wuninitialized warning.
6539 (load_charset_map): Mark variables that gcc -Wuninitialized
6540 does not deduce are never used uninitialized.
6541 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6543 * coding.c (coding_set_source, coding_set_destination):
6544 Use "else { /* comment */ }" rather than "else /* comment */;"
6545 for clarity, and to avoid gcc -Wempty-body warning.
6546 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6547 a block, when the outer 'i' will do.
6548 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6549 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6550 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6551 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6552 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6553 Rename locals to avoid shadowing.
6554 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6555 * coding.c (emacs_mule_char, encode_invocation_designation):
6556 Now static, since they're not used elsewhere.
6557 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6558 (decode_coding_object, encode_coding_object, detect_coding_system):
6559 (decode_coding_emacs_mule): Mark variables that gcc
6560 -Wuninitialized does not deduce are never used uninitialized.
6561 (detect_coding_iso_2022): Initialize a local variable that might
6562 be used uninitialized. Leave a FIXME because it's not clear that
6563 this initialization is needed. (Bug#8211)
6564 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6565 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6566 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6567 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6568 Remove unused macros.
6570 * category.c (hash_get_category_set): Remove unused local var.
6571 (copy_category_table): Now static, since it's not used elsewhere.
6572 * character.c (string_count_byte8): Likewise.
6574 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6575 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6577 * chartab.c (copy_sub_char_table): Now static, since it's not used
6579 (sub_char_table_ref_and_range, char_table_ref_and_range):
6580 Rename locals to avoid shadowing.
6581 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6583 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6584 (BIDI_BOB): Remove unused macro.
6586 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6587 deduce are never used uninitialized.
6588 * term.c (encode_terminal_code): Likewise.
6590 * term.c (encode_terminal_code): Now static. Remove unused local.
6592 * tparam.h: New file.
6593 * term.c, tparam.h: Include it.
6594 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6595 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6596 Move these decls to tparam.h, and make them agree with what
6597 is actually in tparam.c. The previous trick of using incompatible
6598 decls in different modules does not conform to the C standard.
6599 All callers of tparam changed to use tparam's actual API.
6600 * tparam.c (tparam1, tparam, tgoto):
6601 Use const pointers where appropriate.
6603 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6604 * cm.h (struct cm): Likewise.
6605 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6606 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6607 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6608 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6609 (turn_on_face, init_tty): Likewise.
6610 * termchar.h (struct tty_display_info): Likewise.
6612 * term.c (term_mouse_position): Rename local to avoid shadowing.
6614 * alloc.c (mark_ttys): Move decl from here ...
6615 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6617 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6619 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6621 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6623 * search.c (compile_pattern_1): Remove argument regp, unused since
6624 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6625 (compile_pattern): Don't pass it.
6627 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6629 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6630 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6632 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6634 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6636 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6637 gdk_window_get_screen, gdk_window_get_geometry,
6638 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6639 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6640 (xg_get_pixbuf_from_pixmap): New function.
6641 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6642 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6643 Call xg_get_pixbuf_from_pixmap instead of
6644 gdk_pixbuf_get_from_drawable.
6645 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6646 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6647 (xg_check_special_colors): Use GtkStyleContext and its functions
6649 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6650 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6651 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6652 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6653 Call gtk_widget_get_preferred_size.
6654 (xg_frame_resized): gdk_window_get_geometry only takes 5
6656 (xg_win_to_widget, xg_event_is_for_menubar):
6657 Call gdk_x11_window_lookup_for_display.
6658 (xg_set_widget_bg): New function.
6659 (delete_cb): New function.
6660 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6661 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6662 (xg_set_background_color): Call xg_set_widget_bg.
6663 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6664 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6665 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6666 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6668 (update_frame_tool_bar): Call gtk_widget_hide.
6669 (xg_initialize): Use GDK_KEY_g.
6671 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6673 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6675 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6676 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6677 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6679 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6681 * w32xfns.c (select_palette): Check success of RealizePalette against
6682 GDI_ERROR, not zero.
6684 See ChangeLog.11 for earlier changes.
6690 Copyright (C) 2011 Free Software Foundation, Inc.
6692 This file is part of GNU Emacs.
6694 GNU Emacs is free software: you can redistribute it and/or modify
6695 it under the terms of the GNU General Public License as published by
6696 the Free Software Foundation, either version 3 of the License, or
6697 (at your option) any later version.
6699 GNU Emacs is distributed in the hope that it will be useful,
6700 but WITHOUT ANY WARRANTY; without even the implied warranty of
6701 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6702 GNU General Public License for more details.
6704 You should have received a copy of the GNU General Public License
6705 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.