Mention `case-fold-search' in all the re_search_* functions
[bpt/emacs.git] / src / ChangeLog
1 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * search.c (Fre_search_backward): Mention `case-fold-search' in
4 all the re_search_* functions (bug#8138).
5
6 * keyboard.c (Fopen_dribble_file): Document when the file is
7 closed (bug#8056).
8
9 2011-07-14 Adam Sjøgren <asjo@koldfront.dk>
10
11 * data.c (car, cdr): add functionality hints to documentation.
12
13 2011-07-14 Eli Zaretskii <eliz@gnu.org>
14
15 * bidi.c (bidi_dump_cached_states): Fix format of displaying
16 bidi_cache_idx.
17
18 Support bidi reordering of display and overlay strings.
19 * xdisp.c (compute_display_string_pos)
20 (compute_display_string_end): Accept additional argument STRING.
21 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
22 (reseat_to_string): Initialize bidi_it->string.s and
23 bidi_it->string.schars.
24 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
25 NULL (avoids a crash in bidi_paragraph_init). Initialize
26 itb.string.lstring.
27 (init_iterator): Call bidi_init_it only of a valid
28 buffer position was specified. Initialize paragraph_embedding to
29 L2R.
30 (reseat_to_string): Initialize the bidi iterator.
31 (display_string): If we need to ignore text properties of
32 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
33 original value of -1 will not work with bidi.)
34 (compute_display_string_pos): First arg is now struct
35 `text_pos *'; all callers changed. Support display properties on
36 Lisp strings.
37 (compute_display_string_end): Support display properties on Lisp
38 strings.
39 (init_iterator, reseat_1, reseat_to_string): Initialize the
40 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
41 when iterating on a string not from display properties).
42 (compute_display_string_pos, compute_display_string_end): Fix
43 calculation of the object to scan. Fixes an error when using
44 arrow keys.
45 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
46 base_level_stop; instead, set base_level_stop to BEGV. Fixes
47 crashes in vertical-motion.
48 (next_element_from_buffer): Improve commentary for when
49 the iterator is before prev_stop.
50 (init_iterator): Initialize bidi_p from the default value of
51 bidi-display-reordering, not from buffer-local value. Use the
52 buffer-local value only if initializing for buffer iteration.
53 (handle_invisible_prop): Support invisible properties on strings
54 that are being bidi-reordered.
55 (set_iterator_to_next): Support bidi reordering of C strings and
56 Lisp strings.
57 (next_element_from_string): Support bidi reordering of Lisp
58 strings.
59 (handle_stop_backwards): Support Lisp strings as well.
60 (display_string): Support display of R2L glyph rows. Use
61 IT_STRING_CHARPOS when displaying from a Lisp string.
62 (init_iterator): Don't initialize it->bidi_p for strings
63 here.
64 (reseat_to_string): Initialize it->bidi_p for strings here.
65 (next_element_from_string, next_element_from_c_string)
66 (next_element_from_buffer): Add xassert's for correspondence
67 between IT's object being iterated and it->bidi_it.string
68 structure.
69 (face_before_or_after_it_pos): Support bidi iteration.
70 (next_element_from_c_string): Handle the case of the first string
71 character that is not the first one in the visual order.
72 (get_visually_first_element): New function, refactored from common
73 parts of next_element_from_buffer, next_element_from_string, and
74 next_element_from_c_string.
75 (tool_bar_lines_needed, redisplay_tool_bar)
76 (display_menu_bar): Force left-to-right direction. Add a FIXME
77 comment for making that be controlled by a user option.
78 (push_it, pop_it): Save and restore the state of the
79 bidi iterator. Save and restore the bidi_p flag.
80 (pop_it): Iterate out of display property for string iteration as
81 well.
82 (iterate_out_of_display_property): Support iteration over strings.
83 (handle_single_display_spec): Set up it->bidi_it for iteration
84 over a display string, and call bidi_init_it.
85 (handle_single_display_spec, next_overlay_string)
86 (get_overlay_strings_1, push_display_prop): Set up the bidi
87 iterator for displaying display or overlay strings.
88 (forward_to_next_line_start): Don't use the shortcut if
89 bidi-iterating.
90 (back_to_previous_visible_line_start): If handle_display_prop
91 pushed the iterator stack, restore the internal state of the bidi
92 iterator by calling bidi_pop_it same number of times.
93 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
94 and we are bidi-iterating, don't decrement the iterator position;
95 instead, set the first_elt flag in the bidi iterator, to produce
96 the same effect.
97 (reseat_1): Remove redundant setting of string_from_display_prop_p.
98 (push_display_prop): xassert that we are iterating a buffer.
99 (push_it, pop_it): Save and restore paragraph_embedding member.
100 (handle_single_display_spec, next_overlay_string)
101 (get_overlay_strings_1, reseat_1, reseat_to_string)
102 (push_display_prop): Set up the `unibyte' member of bidi_it.string
103 correctly. Don't assume unibyte strings are not bidi-reordered.
104 (compute_display_string_pos)
105 (compute_display_string_end): Fix handling the case of C string.
106 (push_it, pop_it): Save and restore from_disp_prop_p.
107 (handle_single_display_spec, push_display_prop): Set the
108 from_disp_prop_p flag.
109 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
110 (pop_it): Call iterate_out_of_display_property only if we are
111 popping after iteration over a string that came from a display
112 property. Fix a typo in popping stretch info. Add an assertion
113 for verifying that the iterator position is in sync with the bidi
114 iterator.
115 (handle_single_display_spec, get_overlay_strings_1)
116 (push_display_prop): Fix initialization of paragraph direction for
117 string when that of the parent object is not yet determined.
118 (reseat_1): Call bidi_init_it to resync the bidi
119 iterator with IT's position. (Bug#7616)
120 (find_row_edges): If ROW->start.pos gives position
121 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
122 (handle_stop, back_to_previous_visible_line_start, reseat_1):
123 Reset the from_disp_prop_p flag.
124 (SAVE_IT, RESTORE_IT): New macros.
125 (pos_visible_p, face_before_or_after_it_pos)
126 (back_to_previous_visible_line_start)
127 (move_it_in_display_line_to, move_it_in_display_line)
128 (move_it_to, move_it_vertically_backward, move_it_by_lines)
129 (try_scrolling, redisplay_window, display_line): Use them when
130 saving a temporary copy of the iterator and restoring it back.
131 (back_to_previous_visible_line_start, reseat_1)
132 (init_iterator): Empty the bidi cache "stack".
133 (move_it_in_display_line_to): If iterator ended up at
134 EOL, but we never saw any buffer positions smaller than
135 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
136 motion in bidi-reordered lines.
137 (move_it_in_display_line_to): Record prev_method and prev_pos
138 immediately before the call to set_iterator_to_next. Fixes cursor
139 motion in bidi-reordered lines with stretch glyphs and strings
140 displayed in margins. (Bug#8133) (Bug#8867)
141 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
142 TO_CHARPOS.
143 (pos_visible_p): Support positions in bidi-reordered lines. Save
144 and restore bidi cache.
145
146 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
147 (bidi_paragraph_info): Delete unused struct.
148 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
149 (bidi_cache_start): New variable.
150 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
151 to zero.
152 (bidi_cache_fetch_state, bidi_cache_search)
153 (bidi_cache_find_level_change, bidi_cache_iterator_state)
154 (bidi_cache_find, bidi_peek_at_next_level)
155 (bidi_level_of_next_char, bidi_find_other_level_edge)
156 (bidi_move_to_visually_next): Compare cache index with
157 bidi_cache_start rather than with zero.
158 (bidi_fetch_char): Accept new argument STRING; all callers
159 changed. Support iteration over a string. Support strings with
160 display properties. Support unibyte strings. Fix the type of
161 `len' according to what STRING_CHAR_AND_LENGTH expects.
162 (bidi_paragraph_init, bidi_resolve_explicit_1)
163 (bidi_resolve_explicit, bidi_resolve_weak)
164 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
165 iteration over a string.
166 (bidi_set_sor_type, bidi_resolve_explicit_1)
167 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
168 can now be zero (for strings); special values 0 and -1 were
169 changed to -1 and -2, respectively.
170 (bidi_char_at_pos): New function.
171 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
172 Call it instead of FETCH_MULTIBYTE_CHAR.
173 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
174 initialized to valid values.
175 (bidi_init_it): Don't initialize charpos and bytepos with invalid
176 values.
177 (bidi_level_of_next_char): Allow the sentinel "position" to pass
178 the test for valid cached positions. Fix the logic for looking up
179 the sentinel state in the cache. GCPRO the Lisp string we are
180 iterating.
181 (bidi_push_it, bidi_pop_it): New functions.
182 (bidi_initialize): Initialize the bidi cache start stack pointer.
183 (bidi_cache_ensure_space): New function, refactored from part of
184 bidi_cache_iterator_state. Don't assume the required size is just
185 one BIDI_CACHE_CHUNK away.
186 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
187 (bidi_count_bytes, bidi_char_at_pos): New functions.
188 (bidi_cache_search): Don't assume bidi_cache_last_idx is
189 always valid if bidi_cache_idx is valid.
190 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
191 is valid if it's going to be used.
192 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
193 (bidi_cache_fetch_state, bidi_cache_search)
194 (bidi_cache_find_level_change, bidi_cache_ensure_space)
195 (bidi_cache_iterator_state, bidi_cache_find)
196 (bidi_find_other_level_edge, bidi_cache_start_stack): All
197 variables related to cache indices are now EMACS_INT.
198
199 * dispextern.h (struct bidi_string_data): New structure.
200 (struct bidi_it): New member `string'. Make flag members be 1-bit
201 fields, and put them last in the struct.
202 (compute_display_string_pos, compute_display_string_end): Update
203 prototypes.
204 (bidi_push_it, bidi_pop_it): Add prototypes.
205 (struct iterator_stack_entry): New members bidi_p,
206 paragraph_embedding, and from_disp_prop_p.
207 (struct it): Member bidi_p is now a bit field 1 bit wide.
208 (bidi_shelve_cache, bidi_unshelve_cache): Declare
209 prototypes.
210
211 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
212 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
213 and vector-like objects.
214
215 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
216 cache around display iteration.
217
218 * window.c (Fwindow_end, window_scroll_pixel_based)
219 (displayed_window_lines, Frecenter): Save and restore the bidi
220 cache around display iteration.
221
222 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
223
224 * editfns.c (Fdelete_region): Clarify the use of the named
225 parameters (bug#6788).
226
227 2011-07-14 Martin Rudalics <rudalics@gmx.at>
228
229 * indent.c (Fvertical_motion): Set and restore w->pointm when
230 saving and restoring the window's buffer (Bug#9006).
231
232 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
233
234 * editfns.c (Fstring_to_char): Clarify just what is returned
235 (bug#6576). Text by Eli Zaretskii.
236
237 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
238
239 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
240
241 2011-07-13 Eli Zaretskii <eliz@gnu.org>
242
243 * buffer.c (mmap_find): Fix a typo.
244
245 2011-07-13 Johan Bockgård <bojohan@gnu.org>
246
247 Fix execution of x selection hooks.
248 * xselect.c (Qx_lost_selection_functions)
249 (Qx_sent_selection_functions): New vars.
250 (syms_of_xselect): DEFSYM them.
251 (x_handle_selection_request): Pass Qx_sent_selection_functions
252 rather than Vx_sent_selection_functions to Frun_hook_with_args.
253 (x_handle_selection_clear,x_clear_frame_selections):
254 Pass Qx_lost_selection_functions rather than
255 Vx_lost_selection_functions to Frun_hook_with_args.
256
257 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
258
259 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
260 The old code sometimes used this field without initializing it.
261
262 * alloc.c (gc_sweep): Don't read past end of array.
263 In theory, the old code could also have corrupted Emacs internals,
264 though it'd be very unlikely.
265
266 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
267
268 * character.c (Fcharacterp): Don't advertise optional ignored
269 argument. (Bug#4026)
270
271 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
272
273 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
274 key" (bug#4257).
275
276 * window.c (Fset_window_start): Doc fix (bug#4199).
277 (Fset_window_hscroll): Ditto.
278
279 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
280
281 Fix minor new problems caught by GCC 4.6.1.
282 * term.c (init_tty): Remove unused local.
283 * xsettings.c (store_monospaced_changed): Define this function only
284 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
285 not used otherwise.
286
287 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
288
289 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
290
291 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
292
293 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
294 are the mini-buffer and the echo area (bug#3320).
295
296 * term.c (init_tty): Remove support for supdup, c10 and perq
297 terminals, which are no longer supported (bug#1482).
298
299 2011-07-10 Johan Bockgård <bojohan@gnu.org>
300
301 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
302
303 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
304
305 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
306 for non-popups (Bug#3642).
307
308 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
309
310 * alloc.c (reset_malloc_hooks): Protoize.
311 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
312 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
313 * cm.c (losecursor): Likewise.
314 * data.c (fmod): Likewise.
315 * dispnew.c (swap_glyphs_in_rows): Likewise.
316 * emacs.c (memory_warning_signal): Likewise.
317 * floatfns.c (float_error): Likewise.
318 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
319 (otf_open, font_otf_capability, generate_otf_features)
320 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
321 Likewise.
322 * image.c (pbm_read_file): Likewise.
323 * indent.c (string_display_width): Likewise.
324 * intervals.c (check_for_interval, search_for_interval)
325 (inc_interval_count, count_intervals, root_interval)
326 (adjust_intervals_for_insertion, make_new_interval): Likewise.
327 * lread.c (defalias): Likewise.
328 * ralloc.c (r_alloc_check): Likewise.
329 * regex.c (set_image_of_range_1, set_image_of_range)
330 (regex_grow_registers): Likewise.
331 * sysdep.c (strerror): Likewise.
332 * termcap.c (valid_filename_p, tprint, main): Likewise.
333 * tparam.c (main): Likewise.
334 * unexhp9k800.c (run_time_remap, save_data_space)
335 (update_file_ptrs, read_header, write_header, calculate_checksum)
336 (copy_file, copy_rest, display_header): Likewise.
337 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
338 Likewise.
339 * xdisp.c (check_it): Likewise.
340 * xfaces.c (register_color, unregister_color, unregister_colors):
341 Likewise.
342 * xfns.c (print_fontset_result): Likewise.
343 * xrdb.c (member, fatal, main): Likewise.
344
345 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
346
347 Fix minor problems found by static checking (Bug#9031).
348 * chartab.c (char_table_set_range, map_sub_char_table):
349 Remove unused locals.
350 (uniprop_table): Now static.
351 * composite.c (_work_char): Remove unused static var.
352
353 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
354
355 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
356
357 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
358
359 * gtkutil.c (qttip_cb): Remove code without function.
360
361 2011-07-09 Eli Zaretskii <eliz@gnu.org>
362
363 * w32.c (pthread_sigmask): New stub.
364
365 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
366
367 Use pthread_sigmask, not sigprocmask (Bug#9010).
368 sigprocmask is portable only for single-threaded applications, and
369 Emacs can be multi-threaded when it uses GTK.
370 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
371 (LIBES): Use it.
372 * callproc.c (Fcall_process):
373 * process.c (create_process):
374 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
375 Use pthread_sigmask, not sigprocmask.
376
377 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
378
379 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
380 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
381 wrong (Bug#8591).
382
383 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
384
385 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
386 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
387 (xg_hide_tooltip): Fix comment.
388
389 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
390 in registerServicesMenuSendTypes.
391 (validRequestorForSendType): Don't check ns_return_types.
392
393 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
394 ns_return_type.
395
396 2011-07-08 Jason Rumney <jasonr@gnu.org>
397
398 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
399 frame struct members of non-existent frames (Bug#6284).
400
401 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
402
403 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
404 variable firstTime not needed on OSX >= 10.6.
405 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
406 >= 10.5. Use setKnobProportion, setDoubleValue.
407
408 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
409 (MAC_OS_X_VERSION_10_5): Define if not defined.
410 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
411 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
412 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
413
414 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
415 cString and lossyCString on OSX >= 10.4
416
417 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
418 sizeToFit on OSX >= 10.2.
419
420 * nsimage.m (allocInitFromFile): Don't use deprecated method
421 bestRepresentationForDevice on OSX >= 10.6.
422
423 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
424 to avoid warning.
425
426 * emacs.c: Declare unexec_init_emacs_zone.
427
428 * nsgui.h: Fix compiler warning about gnulib redefining verify.
429
430 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
431
432 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
433 on svcsMenu (Bug#8842).
434
435 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
436 ns_return_types.
437 (Fns_list_services): Just return Qnil on 10.6, code not working there.
438
439 * nsterm.m (QUTF8_STRING): Declare.
440 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
441 (validRequestorForSendType): Return type is (id).
442 Change indexOfObjectIdenticalTo to indexOfObject.
443 Check if we have local selection before returning self (Bug#8842).
444 (writeSelectionToPasteboard): Put local selection into paste board
445 if we have a local selection (Bug#8842).
446 (syms_of_nsterm): DEFSYM QUTF8_STRING.
447
448 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
449 (ns_get_local_selection): Declare.
450
451 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
452
453 * keymap.c (describe_map_tree): Don't insert a double newline at
454 the end of the buffer (bug#1169) and return whether we inserted
455 something.
456
457 * callint.c (Fcall_interactively): Change "reading args" to
458 "providing args" to try to clarify what it does (bug#1010).
459
460 2011-07-07 Kenichi Handa <handa@m17n.org>
461
462 * composite.c (composition_compute_stop_pos): Ignore a static
463 composition starting before CHARPOS (Bug#8915).
464
465 * xdisp.c (handle_composition_prop): Likewise.
466
467 2011-07-07 Eli Zaretskii <eliz@gnu.org>
468
469 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
470 (Bug#9015)
471
472 2011-07-07 Kenichi Handa <handa@m17n.org>
473
474 * character.h (unicode_category_t): New enum type.
475
476 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
477 (Qchar_code_property_table): New variable.
478 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
479 (UNIPROP_COMPRESSED_FORM_P): New macros.
480 (char_table_ascii): Uncompress the compressed values.
481 (sub_char_table_ref): New arg is_uniprop. Callers changed.
482 Uncompress the compressed values.
483 (sub_char_table_ref_and_range): Likewise.
484 (char_table_ref_and_range): Uncompress the compressed values.
485 (sub_char_table_set): New arg is_uniprop. Callers changed.
486 Uncompress the compressed values.
487 (sub_char_table_set_range): Args changed. Callers changed.
488 (char_table_set_range): Adjuted for the above change.
489 (map_sub_char_table): Delete args default_val and parent. Add arg
490 top. Give decoded values to a Lisp function.
491 (map_char_table): Adjusted for the above change. Give decoded
492 values to a Lisp function. Gcpro more variables.
493 (uniprop_table_uncompress)
494 (uniprop_decode_value_run_length): New functions.
495 (uniprop_decoder, uniprop_decoder_count): New variables.
496 (uniprop_get_decoder, uniprop_encode_value_character)
497 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
498 New functions.
499 (uniprop_encoder, uniprop_encoder_count): New variables.
500 (uniprop_get_encoder, uniprop_table)
501 (Funicode_property_table_internal, Fget_unicode_property_internal)
502 (Fput_unicode_property_internal): New functions.
503 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
504 Sunicode_property_table_internal, Sget_unicode_property_internal,
505 and Sput_unicode_property_internal. Defvar_lisp
506 char-code-property-alist.
507
508 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
509 Vunicode_category_table.
510
511 * font.c (font_range): Adjusted for the change of
512 Vunicode_category_table.
513
514 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
515
516 * m/iris4d.h: Remove file, move contents ...
517 * s/irix6-5.h: ... here.
518
519 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
520
521 Remove unportable assumption about struct layout (Bug#8884).
522 * alloc.c (mark_buffer):
523 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
524 (clone_per_buffer_values): Don't assume that
525 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
526 This isn't true in general, and it's particularly not true
527 if Emacs is configured with --with-wide-int.
528 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
529 New macros, used in the buffer.c change.
530
531 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
532
533 * xsettings.c: Use both GConf and GSettings if both are available.
534 (store_config_changed_event): Add comment.
535 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
536 (store_tool_bar_style_changed): New functions.
537 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
538 (struct xsettings): Move font inside HAVE_XFT.
539 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
540 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
541 Move inside HAVE_XFT.
542 (something_changed_gsettingsCB): Renamed from something_changedCB.
543 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
544 also.
545 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
546 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
547 (something_changed_gconfCB): Renamed from something_changedCB.
548 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
549 (parse_settings): Move check for font inside HAVE_XFT.
550 (read_settings, apply_xft_settings): Add comment.
551 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
552 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
553 call store_font_name_changed.
554 (xft_settings_event): Add comment.
555 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
556 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
557 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
558 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
559 (xsettings_initialize): Call init_gsettings last.
560 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
561 comment.
562
563 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
564
565 Random fixes. E.g., (random) never returned negative values.
566 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
567 subseconds part to the entropy, as that's a bit more random.
568 Prefer signed to unsigned, since the signedness doesn't matter and
569 in general we prefer signed. When given a limit, use a
570 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
571 latter isn't right if USE_2_TAGS_FOR_INTS.
572 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
573 not 0..VALMASK. Don't discard "excess" bits that random () returns.
574
575 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
576
577 * textprop.c (text_property_stickiness):
578 Obey Vtext_property_default_nonsticky.
579 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
580 * w32fns.c (syms_of_w32fns):
581 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
582
583 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
584
585 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
586 This is more efficient than Ffile_directory_p and avoids a minor race.
587
588 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
589
590 * buffer.c (Foverlay_put): Say what the return value is
591 (bug#7835).
592
593 * fileio.c (barf_or_query_if_file_exists): Check first if the file
594 is a directory before asking whether to use the file name
595 (bug#7564).
596 (barf_or_query_if_file_exists): Make the "File is a directory"
597 error be more correct.
598
599 * fns.c (Frequire): Remove the mention of the .gz files, since
600 that's installation-specific, but keep the mention of
601 `get-load-suffixes'.
602
603 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
604
605 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
606 Report string overflow if the output is too long.
607
608 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
609
610 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
611 (syms_of_gnutls): Remove duplicate DEFSYM for
612 Qgnutls_bootprop_verify_hostname_error, an error for
613 Qgnutls_bootprop_verify_error (which is no longer used).
614
615 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
616 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
617 Also (re)move comments that are misplaced or no longer relevant.
618
619 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
620
621 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
622
623 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
624
625 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
626 and background color parameters if they have been changed.
627
628 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
629
630 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
631
632 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
633
634 * xsettings.c (SYSTEM_FONT): Define only when used.
635 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
636
637 * keymap.c (access_keymap_1): Now static.
638
639 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
640
641 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
642 leave any prefix arg for the up event (Bug#1586).
643
644 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
645
646 * lread.c (syms_of_lread): Mention single symbols defined by
647 `defvar' or `defconst' (bug#7154).
648
649 * fns.c (Frequire): Mention .el.gz files (bug#7314).
650 (Frequire): Mention get-load-suffixes.
651
652 2011-07-02 Martin Rudalics <rudalics@gmx.at>
653
654 * window.h (window): Remove clone_number slot.
655 * window.c (Fwindow_clone_number, Fset_window_clone_number):
656 Remove.
657 (make_parent_window, make_window, saved_window)
658 (Fset_window_configuration, save_window_save): Don't deal with
659 clone numbers.
660 * buffer.c (Qclone_number): Remove declaration.
661 (sort_overlays, overlay_strings): Don't deal with clone numbers.
662
663 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
664
665 Add multiple inheritance to keymaps.
666 * keymap.c (Fmake_composed_keymap): New function.
667 (Fset_keymap_parent): Simplify.
668 (fix_submap_inheritance): Remove.
669 (access_keymap_1): New function extracted from access_keymap to handle
670 embedded parents and handle lists of maps.
671 (access_keymap): Use it.
672 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
673 (Fcopy_keymap): Handle embedded parents.
674 (Fcommand_remapping, define_as_prefix): Simplify.
675 (Fkey_binding): Simplify.
676 (syms_of_keymap): Move minibuffer-local-completion-map,
677 minibuffer-local-filename-completion-map,
678 minibuffer-local-must-match-map, and
679 minibuffer-local-filename-must-match-map to Elisp.
680 (syms_of_keymap): Defsubr make-composed-keymap.
681 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
682 (parse_menu_item): Trivial simplification.
683
684 2011-07-01 Glenn Morris <rgm@gnu.org>
685
686 * Makefile.in (SETTINGS_LIBS): Fix typo.
687
688 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
689
690 * coding.c (Fencode_coding_string): Record the last coding system
691 used, as the function doc string says (bug#8738).
692
693 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
694
695 * xsettings.c (store_monospaced_changed): Take new font as arg and
696 check for change against current_mono_font.
697 (EMACS_TYPE_SETTINGS): Remove this and related defines.
698 (emacs_settings_constructor, emacs_settings_get_property)
699 (emacs_settings_set_property, emacs_settings_class_init)
700 (emacs_settings_init, gsettings_obj): Remove.
701 (something_changedCB): New function for HAVE_GSETTINGS.
702 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
703 with value as argument.
704 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
705 g_settings_new (Bug#8967). Do not create gsettings_obj.
706 Remove calls to g_settings_bind. Connect something_changedCB to
707 "changed".
708
709 * xgselect.c: Add defined (HAVE_GSETTINGS).
710 (xgselect_initialize): Ditto.
711
712 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
713 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
714 xg_select.
715
716 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
717
718 * eval.c (struct backtrace): Simplify and port the data structure.
719 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
720 signed bit field, as this assumption is not portable and it makes
721 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
722 "char debug_on_exit : 1" as this is not portable either; instead,
723 use the portable "unsigned int debug_on_exit : 1". Remove unused
724 member evalargs. Remove obsolete comments about cc bombing out.
725
726 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
727
728 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
729 Let HAVE_GSETTINGS override HAVE_GCONF.
730 (store_monospaced_changed): New function.
731 (EMACS_SETTINGS): A new type derived from GObject to handle
732 GSettings notifications.
733 (emacs_settings_constructor, emacs_settings_get_property)
734 (emacs_settings_set_property, emacs_settings_class_init):
735 New functions.
736 (gsettings_client, gsettings_obj): New variables.
737 (GSETTINGS_SCHEMA): New define.
738 (something_changedCB): Call store_monospaced_changed.
739 (init_gsettings): New function.
740 (xsettings_initialize): Call init_gsettings.
741 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
742 to NULL.
743
744 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
745 GCONF_CFLAGS/LIBS.
746
747 2011-06-29 Martin Rudalics <rudalics@gmx.at>
748
749 * window.c (resize_root_window, grow_mini_window)
750 (shrink_mini_window): Rename Qresize_root_window to
751 Qwindow_resize_root_window and Qresize_root_window_vertically to
752 Qwindow_resize_root_window_vertically.
753
754 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
755
756 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
757
758 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
759
760 * makefile.w32-in: Redesign dependencies so they reflect more
761 clearly which files are directly included by each source file,
762 and not through other includes.
763
764 2011-06-27 Martin Rudalics <rudalics@gmx.at>
765
766 * buffer.c (Qclone_number): Declare static and DEFSYM it.
767 (sort_overlays, overlay_strings): When an overlay's clone number
768 matches the window's clone number process the overlay even if
769 the overlay's window property doesn't match the current window.
770
771 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
772 (Fwindow_hchild): Rename to Fwindow_left_child.
773 (Fwindow_next): Rename to Fwindow_next_sibling.
774 (Fwindow_prev): Rename to Fwindow_prev_sibling.
775 (resize_window_check): Rename to window_resize_check.
776 (resize_window_apply): Rename to window_resize_apply.
777 (Fresize_window_apply): Rename to Fwindow_resize_apply.
778 (Fdelete_other_windows_internal, resize_frame_windows)
779 (Fsplit_window_internal, Fdelete_window_internal)
780 (grow_mini_window, shrink_mini_window)
781 (Fresize_mini_window_internal): Fix callers accordingly.
782
783 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
784
785 * emacsgtkfixed.h: State that this is only used with Gtk+3.
786 (emacs_fixed_set_min_size): Remove.
787 (emacs_fixed_new): Take frame as argument.
788
789 * emacsgtkfixed.c: State that this is only used with Gtk+3.
790 (_EmacsFixedPrivate): Remove minwidth/height.
791 Add struct frame *f.
792 (emacs_fixed_init): Initialize priv->f.
793 (get_parent_class, emacs_fixed_set_min_size): Remove.
794 (emacs_fixed_new): Set priv->f to argument.
795 (emacs_fixed_get_preferred_width)
796 (emacs_fixed_get_preferred_height): Use min_width/height from
797 frames size_hint to set minimum and natural (Bug#8919).
798 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
799 and use min_width/height from frames size_hint to set
800 min_width/height (Bug#8919).
801
802 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
803 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
804 Fix indentation.
805
806 2011-06-26 Eli Zaretskii <eliz@gnu.org>
807
808 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
809 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
810 called at ZV.
811
812 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
813
814 * process.c (wait_reading_process_output): Bypass select if
815 waiting for a cell while ignoring keyboard input, and input is
816 pending. Suggested by Jan Djärv (Bug#8869).
817
818 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
819
820 Use gnulib's dup2 module instead of rolling our own.
821 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
822
823 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
824
825 * dispnew.c (scrolling_window): Before scrolling, turn off a
826 mouse-highlight in the window being scrolled.
827
828 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
829
830 Move DEFSYM to lisp.h and use everywhere.
831
832 * character.h (DEFSYM): Move declaration...
833 * lisp.h (DEFSYM): ...here.
834
835 * gnutls.c:
836 * minibuf.c:
837 * w32menu.c:
838 * w32proc.c:
839 * w32select.c: Don't include character.h.
840
841 * alloc.c (syms_of_alloc):
842 * buffer.c (syms_of_buffer):
843 * bytecode.c (syms_of_bytecode):
844 * callint.c (syms_of_callint):
845 * casefiddle.c (syms_of_casefiddle):
846 * casetab.c (init_casetab_once):
847 * category.c (init_category_once, syms_of_category):
848 * ccl.c (syms_of_ccl):
849 * cmds.c (syms_of_cmds):
850 * composite.c (syms_of_composite):
851 * dbusbind.c (syms_of_dbusbind):
852 * dired.c (syms_of_dired):
853 * dispnew.c (syms_of_display):
854 * doc.c (syms_of_doc):
855 * editfns.c (syms_of_editfns):
856 * emacs.c (syms_of_emacs):
857 * eval.c (syms_of_eval):
858 * fileio.c (syms_of_fileio):
859 * fns.c (syms_of_fns):
860 * frame.c (syms_of_frame):
861 * fringe.c (syms_of_fringe):
862 * insdel.c (syms_of_insdel):
863 * keymap.c (syms_of_keymap):
864 * lread.c (init_obarray, syms_of_lread):
865 * macros.c (syms_of_macros):
866 * msdos.c (syms_of_msdos):
867 * print.c (syms_of_print):
868 * process.c (syms_of_process):
869 * search.c (syms_of_search):
870 * sound.c (syms_of_sound):
871 * syntax.c (init_syntax_once, syms_of_syntax):
872 * terminal.c (syms_of_terminal):
873 * textprop.c (syms_of_textprop):
874 * undo.c (syms_of_undo):
875 * w32.c (globals_of_w32):
876 * window.c (syms_of_window):
877 * xdisp.c (syms_of_xdisp):
878 * xfaces.c (syms_of_xfaces):
879 * xfns.c (syms_of_xfns):
880 * xmenu.c (syms_of_xmenu):
881 * xsettings.c (syms_of_xsettings):
882 * xterm.c (syms_of_xterm): Use DEFSYM.
883
884 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
885
886 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
887
888 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
889
890 Integer and buffer overflow fixes (Bug#8873).
891
892 * print.c (printchar, strout): Check for string overflow.
893 (PRINTPREPARE, printchar, strout):
894 Don't set size unless allocation succeeds.
895
896 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
897 for sizes. Check for string overflow more accurately.
898 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
899
900 * macros.c: Integer and buffer overflow fixes.
901 * keyboard.h (struct keyboard.kbd_macro_bufsize):
902 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
903 Use ptrdiff_t, not int, for sizes.
904 Don't increment bufsize until after realloc succeeds.
905 Check for size-calculation overflow.
906 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
907
908 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
909
910 * lread.c: Integer overflow fixes.
911 (read_integer): Radix is now EMACS_INT, not int,
912 to improve quality of diagnostics for out-of-range radices.
913 Calculate buffer size correctly for out-of-range radices.
914 (read1): Check for integer overflow in radices, and in
915 read-circle numbers.
916 (read_escape): Avoid int overflow.
917 (Fload, openp, read_buffer_size, read1)
918 (substitute_object_recurse, read_vector, read_list, map_obarray):
919 Use ptrdiff_t, not int, for sizes.
920 (read1): Use EMACS_INT, not int, for sizes.
921 Check for size overflow.
922
923 * image.c (cache_image): Check for size arithmetic overflow.
924
925 * lread.c: Integer overflow issues.
926 (saved_doc_string_size, saved_doc_string_length)
927 (prev_saved_doc_string_size, prev_saved_doc_string_length):
928 Now ptrdiff_t, not int.
929 (read1): Don't assume doc string length fits in int. Check for
930 out-of-range doc string lengths.
931 (read_list): Don't assume file position fits in int.
932 (read_escape): Check for hex character overflow.
933
934 2011-06-22 Leo Liu <sdl.web@gmail.com>
935
936 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
937 Move to minibuffer.el.
938
939 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
940
941 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
942 The following patches are for when GLYPH_DEBUG && !XASSERT.
943 * dispextern.h (trace_redisplay_p, dump_glyph_string):
944 * dispnew.c (flush_stdout):
945 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
946 Mark as externally visible.
947 * dispnew.c (check_window_matrix_pointers): Now static.
948 * dispnew.c (window_to_frame_vpos):
949 * xfns.c (unwind_create_frame):
950 * xterm.c (x_check_font): Remove unused local.
951 * scroll.c (CHECK_BOUNDS):
952 * xfaces.c (cache_fache): Rename local to avoid shadowing.
953 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
954 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
955 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
956 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
957 Now static.
958 (debug_method_add): Use va_list and vsprintf rather than relying
959 on undefined behavior with wrong number of arguments.
960 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
961 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
962 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
963 since we're not interested in debugging glyphs with old libraries.
964 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
965 GCC 4.6.0's static checking.
966
967 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
968
969 Integer overflow and signedness fixes (Bug#8873).
970 A few related buffer overrun fixes, too.
971
972 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
973
974 * dispextern.h (struct face.stipple):
975 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
976 (x_bitmap_mask, x_allocate_bitmap_record)
977 (x_create_bitmap_from_data, x_create_bitmap_from_file)
978 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
979 (x_create_bitmap_from_xpm_data):
980 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
981 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
982 (.bitmaps_last):
983 * xfaces.c (load_pixmap):
984 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
985 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
986 (.bitmaps_last, struct x_output.icon_bitmap):
987 Use ptrdiff_t, not int, for bitmap indexes.
988 (x_allocate_bitmap_record): Check for size overflow.
989 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
990
991 Use ptrdiff_t, not int, for overlay counts.
992 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
993 * editfns.c (overlays_around, get_pos_property):
994 * textprop.c (get_char_property_and_overlay):
995 * xdisp.c (next_overlay_change, note_mouse_highlight):
996 * xfaces.c (face_at_buffer_position):
997 * buffer.c (OVERLAY_COUNT_MAX): New macro.
998 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
999 (Fnext_overlay_change, Fprevious_overlay_change)
1000 (mouse_face_overlay_overlaps, Foverlays_in):
1001 Use ptrdiff_t, not int, for sizes.
1002 (overlays_at, overlays_in): Check for size-calculation overflow.
1003
1004 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1005
1006 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1007 (x_session_initialize): Do not assume string length fits in int.
1008
1009 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1010 This is unlikely, but can occur if DPI is outlandish.
1011
1012 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1013 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1014
1015 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1016 * xrdb.c (magic_file_p, search_magic_path):
1017 Omit last arg SUFFIX; it was always 0. All callers changed.
1018 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1019
1020 * xfont.c (xfont_match): Avoid need for strlen.
1021
1022 * xfns.c: Don't assume strlen fits in int.
1023 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1024
1025 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1026 not unsigned long, as we prefer signed integers. All callers changed.
1027 Detect integer overflow in repeat count.
1028 (message_dolog): Don't assume print length fits in 39 bytes.
1029 (display_mode_element): Don't assume strlen fits in int.
1030
1031 * termcap.c: Don't assume sizes fit in int and never overflow.
1032 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1033 (gobble_line): Check for size-calculation overflow.
1034
1035 * minibuf.c (Fread_buffer):
1036 * lread.c (intern, intern_c_string):
1037 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1038 Don't assume string length fits in int.
1039
1040 * keyboard.c (parse_tool_bar_item):
1041 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1042
1043 * font.c: Don't assume string length fits in int.
1044 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1045 Use ptrdiff_t, not int.
1046 (font_intern_prop): Don't assume string length fits in int.
1047 Don't assume integer property fits in fixnum.
1048 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1049
1050 * filelock.c: Fix some buffer overrun and integer overflow issues.
1051 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1052 Reformulate so as not to need the command string.
1053 Invoke gzip -cd rather than gunzip, as it's more portable.
1054 (lock_info_type, lock_file_1, lock_file):
1055 Don't assume pid_t and time_t fit in unsigned long.
1056 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1057 (current_lock_owner): Prefer signed type for sizes.
1058 Use memcpy, not strncpy, where memcpy is what is really wanted.
1059 Don't assume (via atoi) that time_t and pid_t fit in int.
1060 Check for time_t and/or pid_t out of range, e.g., via a network share.
1061 Don't alloca where an auto var works fine.
1062
1063 * fileio.c: Fix some integer overflow issues.
1064 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1065 Don't assume string length fits in int.
1066 (directory_file_name): Don't assume string length fits in long.
1067 (make_temp_name): Don't assume pid fits in int, or that its print
1068 length is less than 20.
1069
1070 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1071
1072 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1073
1074 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1075
1076 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1077 We prefer signed integers, even for size calculations.
1078
1079 * emacs.c: Don't assume string length fits in 'int'.
1080 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1081 (main): Don't invoke strlen when not needed.
1082
1083 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1084 (XD_DEBUG_MESSAGE): Don't waste a byte.
1085
1086 * callproc.c (getenv_internal_1, getenv_internal)
1087 (Fgetenv_internal):
1088 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1089
1090 * lread.c (invalid_syntax): Omit length argument.
1091 All uses changed. This doesn't fix a bug, but it simplifies the
1092 code away from its former Hollerith-constant appearance, and it's
1093 one less 'int' to worry about when looking at integer-overflow issues.
1094 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1095
1096 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1097 This didn't break anything, but it didn't help either.
1098 It's confusing to put a bogus integer in a place where the actual
1099 value does not matter.
1100 (LIST_END_P): Remove unused macro and its bogus comment.
1101 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1102
1103 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1104 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1105 implementation.
1106 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1107 We prefer signed types, and the value cannot exceed the EMACS_INT
1108 range anyway (because otherwise the length would not be representable).
1109 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1110 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1111 This avoids a GCC warning when WIDE_EMACS_INT.
1112
1113 * indent.c (sane_tab_width): New function.
1114 (current_column, scan_for_column, Findent_to, position_indentation)
1115 (compute_motion): Use it. This is just for clarity.
1116 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1117
1118 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1119
1120 * lisp.h (lint_assume): New macro.
1121 * composite.c (composition_gstring_put_cache):
1122 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1123
1124 * editfns.c, insdel.c:
1125 Omit unnecessary forward decls, to simplify future changes.
1126
1127 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1128
1129 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1130
1131 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1132 Use much-faster test for byte-length change.
1133 Don't assume string byte-length fits in 'int'.
1134 Check that character arg fits in 'int'.
1135 (mapcar1): Declare byte as byte, for clarity.
1136
1137 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1138
1139 * fns.c (concat): Catch string overflow earlier.
1140 Do not rely on integer wraparound.
1141
1142 * dispextern.h (struct it.overlay_strings_charpos)
1143 (struct it.selective): Now EMACS_INT, not int.
1144 * xdisp.c (forward_to_next_line_start)
1145 (back_to_previous_visible_line_start)
1146 (reseat_at_next_visible_line_start, next_element_from_buffer):
1147 Don't arbitrarily truncate the value of 'selective' to int.
1148
1149 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1150
1151 * composite.c: Don't truncate sizes to 'int'.
1152 (composition_gstring_p, composition_reseat_it)
1153 (composition_adjust_point): Use EMACS_INT, not int.
1154 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1155 not EMACS_UINT, for indexes.
1156
1157 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1158
1159 * buffer.c: Include <verify.h>.
1160 (struct sortvec.priority, struct sortstr.priority):
1161 Now EMACS_INT, not int.
1162 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1163 (struct sortstr.size, record_overlay_string)
1164 (struct sortstrlist.size, struct sortlist.used):
1165 Don't truncate size to int.
1166 (record_overlay_string): Check for size-calculation overflow.
1167 (init_buffer_once): Check at compile-time, not run-time.
1168
1169 2011-06-22 Jim Meyering <meyering@redhat.com>
1170
1171 Don't leak an XBM-image-sized buffer
1172 * image.c (xbm_load): Free the image buffer after using it.
1173
1174 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 Port to Sun C.
1177 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1178 that Sun C diagnosed.
1179 * fns.c (secure_hash): Fix pointer signedness issue.
1180 * intervals.c (static_offset_intervals): New function.
1181 (offset_intervals): Use it.
1182
1183 2011-06-21 Leo Liu <sdl.web@gmail.com>
1184
1185 * deps.mk (fns.o):
1186 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1187 sha512.h.
1188
1189 * fns.c (secure_hash): Rename from crypto_hash_function and change
1190 the first arg to accept symbols.
1191 (Fsecure_hash): New primitive.
1192 (syms_of_fns): New symbols.
1193
1194 2011-06-20 Deniz Dogan <deniz@dogan.se>
1195
1196 * process.c (Fset_process_buffer): Clarify return value in
1197 docstring.
1198
1199 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1200
1201 * dispnew.c (add_window_display_history): Use BVAR.
1202
1203 * xdisp.c (debug_method_add): Use BVAR.
1204 (check_window_end, dump_glyph_matrix, dump_glyph)
1205 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1206
1207 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1208 Likewise.
1209
1210 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1211 check till after the cache is created in init_frame_faces.
1212
1213 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1214
1215 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1216
1217 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1220 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1221 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1222
1223 Improve buffer-overflow checking (Bug#8873).
1224 * fileio.c (Finsert_file_contents):
1225 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1226 Remove the old (too-loose) buffer overflow checks.
1227 They weren't needed, since make_gap checks for buffer overflow.
1228 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1229 The old code merely checked for Emacs fixnum overflow, and relied
1230 on undefined (wraparound) behavior. The new code avoids undefined
1231 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1232
1233 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1234 Tune. Don't use wider integers than needed. Don't use alloca.
1235 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1236
1237 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1238
1239 * insdel.c, lisp.h (buffer_overflow): New function.
1240 (insert_from_buffer_1, replace_range, replace_range_2):
1241 * insdel.c (make_gap_larger):
1242 * editfns.c (Finsert_char):
1243 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1244
1245 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1246
1247 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 Integer overflow and signedness fixes (Bug#8873).
1250
1251 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1252 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1253
1254 * fileio.c: Don't assume EMACS_INT fits in off_t.
1255 (emacs_lseek): New static function.
1256 (Finsert_file_contents, Fwrite_region): Use it.
1257 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1258
1259 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1260
1261 * fns.c: Don't overflow int when computing a list length.
1262 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1263 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1264 truncation on 64-bit hosts. Check for QUIT every
1265 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1266 faster and is responsive enough.
1267 (Flength): Report an error instead of overflowing an integer.
1268 (Fsafe_length): Return a float if the value is not representable
1269 as a fixnum. This shouldn't happen except in contrived situations.
1270 (Fnthcdr, Fsort): Don't assume list length fits in int.
1271 (Fcopy_sequence): Don't assume vector length fits in int.
1272
1273 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1274 (header_size, word_size): New constants.
1275 (allocate_vectorlike): Don't check size overflow here.
1276 (allocate_vector): Check it here instead, since this is the only
1277 caller of allocate_vectorlike that could cause overflow.
1278 Check that the new vector's length is representable as a fixnum.
1279
1280 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1281 The previous code was bogus. For example, next_almost_prime (32)
1282 returned 39, which is undesirable as it is a multiple of 3; and
1283 next_almost_prime (24) returned 25, which is a multiple of 5 so
1284 why was the code bothering to check for multiples of 7?
1285
1286 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1287
1288 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1289
1290 Variadic C functions now count arguments with ptrdiff_t.
1291 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1292 Back then I didn't know that the Emacs coding style prefers signed int.
1293 Also, in the meantime I found a few more instances where arguments
1294 were being counted with int, which may truncate counts on 64-bit
1295 machines, or EMACS_INT, which may be unnecessarily wide.
1296 * lisp.h (struct Lisp_Subr.function.aMANY)
1297 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1298 Arg counts are now ptrdiff_t, not size_t.
1299 All variadic functions and their callers changed accordingly.
1300 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1301 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1302 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1303 * callint.c (Fcall_interactively): Check arg count for overflow,
1304 to avoid potential buffer overrun. Use signed char, not 'int',
1305 for 'varies' array, so that we needn't bother to check its size
1306 calculation for overflow.
1307 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1308 * eval.c (apply_lambda):
1309 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1310 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1311 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1312
1313 * callint.c (Fcall_interactively): Don't use index var as event count.
1314
1315 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1316 * mem-limits.h (SIZE): Remove; no longer used.
1317
1318 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1319
1320 Remove unnecessary casts.
1321 * xterm.c (x_term_init):
1322 * xfns.c (x_set_border_pixel):
1323 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1324 These aren't needed now that we assume ANSI C.
1325
1326 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1327 It's more likely to cause problems (due to unsigned overflow)
1328 than to cure them.
1329
1330 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1331
1332 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1333
1334 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1335
1336 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1337
1338 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1339
1340 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1341
1342 GLYPH_CODE_FACE returns EMACS_INT, not int.
1343 * dispextern.h (merge_faces):
1344 * xfaces.c (merge_faces):
1345 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1346 Don't assume EMACS_INT fits in int.
1347
1348 * character.h (CHAR_VALID_P): Remove unused parameter.
1349 * fontset.c, lisp.h, xdisp.c: All uses changed.
1350
1351 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1352
1353 * fns.c (concat): Minor tuning based on overflow analysis.
1354 This doesn't fix any bugs. Use int to hold character, instead
1355 of constantly refetching from Emacs object. Use XFASTINT, not
1356 XINT, for value known to be a character. Don't bother comparing
1357 a single byte to 0400, as it's always less.
1358
1359 * floatfns.c (Fexpt):
1360 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1361
1362 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1363 for characters.
1364
1365 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1366
1367 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1368 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1369 incorrectly succeed when S was a string, because 4294967386 was
1370 truncated before it was used.
1371
1372 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1373 Otherwise, an out-of-range integer could cause undefined behavior
1374 on a 64-bit host.
1375
1376 * composite.c: Use int, not EMACS_INT, for characters.
1377 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1378 EMACS_INT, for values that are known to be in character range.
1379 This doesn't fix any bugs but is the usual style inside Emacs and
1380 may generate better code on 32-bit machines.
1381
1382 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1383 This is for reasons similar to the recent CHAR_STRING fix.
1384 * charset.c (Fencode_char): Check that character arg is actually
1385 a character. Pass an int to ENCODE_CHAR.
1386 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1387 wider than 'int', as a compile-time check to prevent future regressions
1388 in this area.
1389
1390 * character.c (char_string): Remove unnecessary casts.
1391
1392 Make sure a 64-bit char is never passed to CHAR_STRING.
1393 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1394 by silently ignoring the top 32 bits, allowing some values
1395 that were far too large to be valid characters.
1396 * character.h: Include <verify.h>.
1397 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1398 arguments are no wider than unsigned, as a compile-time check
1399 to prevent future regressions in this area.
1400 * data.c (Faset):
1401 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1402 (Fsubst_char_in_region):
1403 * fns.c (concat):
1404 * xdisp.c (decode_mode_spec_coding):
1405 Adjust to CHAR_STRING's new requirement.
1406 * editfns.c (Finsert_char, Fsubst_char_in_region):
1407 * fns.c (concat): Check that character args are actually
1408 characters. Without this test, these functions did the wrong
1409 thing with wildly out-of-range values on 64-bit hosts.
1410
1411 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1412 These casts should not be needed on 32-bit hosts, either.
1413 * keyboard.c (read_char):
1414 * lread.c (Fload): Remove casts to unsigned.
1415
1416 * lisp.h (UNSIGNED_CMP): New macro.
1417 This fixes comparison bugs on 64-bit hosts.
1418 (ASCII_CHAR_P): Use it.
1419 * casefiddle.c (casify_object):
1420 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1421 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1422 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1423 * dispextern.h (FACE_FROM_ID):
1424 * keyboard.c (read_char): Use UNSIGNED_CMP.
1425
1426 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1427 not to EMACS_INT, to avoid GCC warning.
1428
1429 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1430
1431 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1432 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1433 isn't needed on 32-bit machines.
1434
1435 * buffer.c (Fgenerate_new_buffer_name):
1436 Use EMACS_INT for count, not int.
1437 (advance_to_char_boundary): Return EMACS_INT, not int.
1438
1439 * data.c (Qcompiled_function): Now static.
1440
1441 * window.c (window_body_lines): Now static.
1442
1443 * image.c (gif_load): Rename local to avoid shadowing.
1444
1445 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1446 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1447 * alloc.c (make_save_value): Integer argument is now of type
1448 ptrdiff_t, not int.
1449 (mark_object): Use ptrdiff_t, not int.
1450 * lisp.h (pD): New macro.
1451 * print.c (print_object): Use it.
1452
1453 * alloc.c: Use EMACS_INT, not int, to count objects.
1454 (total_conses, total_markers, total_symbols, total_vector_size)
1455 (total_free_conses, total_free_markers, total_free_symbols)
1456 (total_free_floats, total_floats, total_free_intervals)
1457 (total_intervals, total_strings, total_free_strings):
1458 Now EMACS_INT, not int. All uses changed.
1459 (Fgarbage_collect): Compute overall total using a double, so that
1460 integer overflow is less likely to be a problem. Check for overflow
1461 when converting back to an integer.
1462 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1463 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1464 These were 'int' variables that could overflow on 64-bit hosts;
1465 they were never used, so remove them instead of repairing them.
1466 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1467 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1468 Previously, this ceilinged at INT_MAX, but that doesn't work on
1469 64-bit machines.
1470 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1471
1472 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1473 (allocate_vectorlike): Check for ptrdiff_t overflow.
1474 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1475 when a (possibly-narrower) signed value would do just as well.
1476 We prefer using signed arithmetic, to avoid comparison confusion.
1477
1478 * alloc.c: Catch some string size overflows that we were missing.
1479 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1480 for convenience in STRING_BYTES_MAX.
1481 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1482 The definition here is exact; the one in lisp.h was approximate.
1483 (allocate_string_data): Check for string overflow. This catches
1484 some instances we weren't catching before. Also, it catches
1485 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1486 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1487 and ptrdiff_t and EMACS_INT are both 64 bits.
1488
1489 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1490 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1491 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1492
1493 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1494
1495 * alloc.c (Fmake_string): Check for out-of-range init.
1496
1497 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1498
1499 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1500
1501 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1502
1503 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1504 xg_get_default_scrollbar_width.
1505
1506 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1507 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1508 (style_changed_cb): Call update_theme_scrollbar_width and call
1509 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1510 all frames (Bug#8505).
1511 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1512 Call gtk_window_set_resizable if HAVE_GTK3.
1513 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1514 and height if HAVE_GTK3 (Bug#8505).
1515 (scroll_bar_width_for_theme): New variable.
1516 (update_theme_scrollbar_width): New function.
1517 (xg_get_default_scrollbar_width): Move code to
1518 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1519 (xg_initialize): Call update_theme_scrollbar_width.
1520
1521 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1522
1523 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1524
1525 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1526
1527 * frame.c (make_frame): Call other_buffer_safely instead of
1528 other_buffer.
1529
1530 * window.c (temp_output_buffer_show): Call display_buffer with
1531 second argument Vtemp_buffer_show_specifiers and reset latter
1532 immediately after the call.
1533 (Vtemp_buffer_show_specifiers): New variable.
1534 (auto_window_vscroll_p, next_screen_context_lines)
1535 (Vscroll_preserve_screen_position): Remove leading asterisks from
1536 doc-strings.
1537
1538 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 Fix minor problems found by GCC 4.6.0 static checking.
1541 * buffer.c (Qclone_number): Remove for now, as it's unused.
1542 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1543 (record_buffer): Remove unused local.
1544 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1545 (set_frame_buffer_list): Remove; unused.
1546 * frame.h (other_visible_frames): Remove decl.
1547 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1548 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1549 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1550 if HAVE_GPM.
1551 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1552 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1553 Define only if HAVE_GPM.
1554 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1555 (update_hints_inhibit): Remove; never set. All uses removed.
1556 * widgetprv.h (emacsFrameClassRec): Remove decl.
1557 * window.c (delete_deletable_window): Now returns void, since it
1558 wasn't returning anything.
1559 (compare_window_configurations): Remove unused locals.
1560 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1561 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1562 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1563 the same widths as pointers. This follows up on the 2011-05-06 patch.
1564 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1565 * xterm.h: Likewise.
1566 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1567
1568 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1569
1570 * makefile.w32-in: Update dependencies.
1571 (LISP_H): Add lib/intprops.h.
1572
1573 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1574
1575 * image.c (gif_load): Add animation frame delay to the metadata.
1576 (syms_of_image): Use DEFSYM. New symbol `delay'.
1577
1578 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1579
1580 * window.c (delete_deletable_window): Re-add.
1581 (Fset_window_configuration): Rewrite to handle dead buffers and
1582 consequently deletable windows.
1583 (window_tree, Fwindow_tree): Remove. Supply functionality in
1584 window.el.
1585 (compare_window_configurations): Simplify code.
1586
1587 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1588
1589 * image.c (imagemagick_load_image): Fix type mismatch.
1590 (Fimagemagick_types): Likewise.
1591
1592 * window.h (replace_buffer_in_windows): Declare.
1593
1594 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1595
1596 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1597 Qclone_number. Remove external declaration of Qdelete_window.
1598 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1599 code.
1600 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1601 Qbuffer_list_update_hook if allowed.
1602 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1603 buffer list implementation.
1604 (other_buffer_safely): New function.
1605 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1606 calls to replace_buffer_in_windows and
1607 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1608 if allowed.
1609 (record_buffer): Inhibit quitting and rewrite using quittable
1610 functions. Run Qbuffer_list_update_hook if allowed.
1611 (Frecord_buffer, Funrecord_buffer): New functions.
1612 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1613 switch-to-buffer to window.el.
1614 (bury-buffer): Move to window.el.
1615 (Vbuffer_list_update_hook): New variable.
1616
1617 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1618 section.
1619
1620 * window.h (resize_frame_windows): Move up in code.
1621 (Fwindow_frame): Remove EXFUN.
1622 (replace_buffer_in_all_windows): Remove prototype.
1623 (replace_buffer_in_windows_safely): Add prototype.
1624
1625 * window.c: Declare Qdelete_window static again. Move down
1626 declaration of select_count.
1627 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1628 (Fother_window): Move to window.el.
1629 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1630 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1631 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1632 window.el.
1633 (replace_buffer_in_windows): Implement by calling
1634 Qreplace_buffer_in_windows.
1635 (replace_buffer_in_all_windows): Remove with some functionality
1636 moved into replace_buffer_in_windows_safely.
1637 (replace_buffer_in_windows_safely): New function.
1638 (select_window_norecord, select_frame_norecord): Move in front
1639 of run_window_configuration_change_hook. Remove now obsolete
1640 declarations.
1641 (Fset_window_buffer): Rewrite doc-string. Call
1642 Qrecord_window_buffer.
1643 (keys_of_window): Move binding for other-window to window.el.
1644
1645 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1646
1647 * dispextern.h (struct image): Replace data member, whose int_val
1648 and ptr_val fields were not used by anything, with a single
1649 lisp_val object.
1650
1651 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1652 (gif_clear_image, gif_load, imagemagick_load_image)
1653 (gs_clear_image, gs_load): Callers changed.
1654
1655 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 * buffer.h: Include <time.h>, for time_t.
1658 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1659
1660 Fix minor problems found by static checking.
1661
1662 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1663
1664 Make identifiers static if they are not used in other modules.
1665 * data.c (Qcompiled_function, Qframe, Qvector):
1666 * image.c (QimageMagick, Qsvg):
1667 * minibuf.c (Qmetadata):
1668 * window.c (resize_window_check, resize_root_window): Now static.
1669 * window.h (resize_window_check, resize_root_window): Remove decls.
1670
1671 * window.c (window_deletion_count, delete_deletable_window):
1672 Remove; unused.
1673 (window_body_lines): Now static.
1674 (Fdelete_other_windows_internal): Mark vars as initialized.
1675 Make sure 'resize_failed' is initialized.
1676 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1677 (resize_window_apply): Remove unused local.
1678 * window.h (delete_deletable_window): Remove decl.
1679
1680 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1681 (imagemagick_load_image): Fix pointer signedness problem by changing
1682 last arg from unsigned char * to char *. All uses changed.
1683 Also, fix a local for similar reasons.
1684 Remove unused locals. Remove locals to avoid shadowing.
1685 (fn_rsvg_handle_free): Remove; unused.
1686 (svg_load, svg_load_image): Fix pointer signedness problem.
1687 (imagemagick_load_image): Don't use garbage pointer image_wand.
1688
1689 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1690
1691 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1692
1693 * image.c (gif_load): Fix omitted cast error introduced by
1694 2011-06-06 change.
1695
1696 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1697
1698 * window.h (resize_proportionally, orig_total_lines)
1699 (orig_top_line): Remove from window structure.
1700 (set_window_height, set_window_width, change_window_heights)
1701 (Fdelete_window): Remove prototypes.
1702 (resize_frame_windows): Remove duplicate declaration.
1703
1704 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1705
1706 * window.h (resize_frame_windows, resize_window_check)
1707 (delete_deletable_window, resize_root_window)
1708 (resize_frame_windows): Declare prototypes.
1709
1710 * window.c (resize_window_apply): Make definition be "static" to
1711 match the prototype.
1712
1713 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1714
1715 * window.c: Remove declarations of Qwindow_size_fixed,
1716 window_min_size_1, window_min_size_2, window_min_size,
1717 size_window, window_fixed_size_p, enlarge_window, delete_window.
1718 Remove static from declaration of Qdelete_window, it's
1719 temporarily needed by Fbury_buffer.
1720 (replace_window): Don't assign orig_top_line and
1721 orig_total_lines.
1722 (Fdelete_window, delete_window): Remove. Window deletion is
1723 handled by window.el.
1724 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1725 Fdelete_window calls with calls to Qdelete_window.
1726 (Fdelete_other_windows): Remove. Deleting other windows is
1727 handled by window.el.
1728 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1729 handled in window.el.
1730 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1731 Window minimum sizes are handled in window.el.
1732 (shrink_windows, size_window, set_window_height)
1733 (set_window_width, change_window_heights, window_height)
1734 (window_width, CURBEG, CURSIZE, enlarge_window)
1735 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1736 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1737 handled in window.el.
1738 (make_dummy_parent): Rename to make_parent_window and give it a
1739 second argument horflag.
1740 (make_window): Don't set resize_proportionally any more.
1741 (Fsplit_window): Remove. Windows are split in window.el.
1742 (save_restore_action, save_restore_orig_size)
1743 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1744 Resize mini windows in window.el.
1745 (grow_mini_window, shrink_mini_window): Implement by calling
1746 Qresize_root_window_vertically, resize_window_check and
1747 resize_window_apply.
1748 (saved_window, Fset_window_configuration, save_window_save): Do
1749 not handle orig_top_line, orig_total_lines, and
1750 resize_proportionally.
1751 (window_min_height, window_min_width): Move to window.el.
1752 (keys_of_window): Move bindings for delete-other-windows,
1753 split-window, delete-window and enlarge-window to window.el.
1754
1755 * buffer.c: Temporarily extern Qdelete_window.
1756 (Fbury_buffer): Temporarily call Qdelete_window instead of
1757 Fdelete_window (Fbury_buffer will move to window.el soon).
1758
1759 * frame.c (set_menu_bar_lines_1): Remove code handling
1760 orig_top_line and orig_total_lines.
1761
1762 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1763 set_window_height but set heights directly.
1764 (change_frame_size_1): Use resize_frame_windows.
1765
1766 * xdisp.c (init_xdisp): Don't use set_window_height but set
1767 heights directly.
1768
1769 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1770 resize_frame_windows instead of change_window_heights and run
1771 run_window_configuration_change_hook.
1772
1773 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1774 instead of change_window_heights and run
1775 run_window_configuration_change_hook.
1776
1777 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1778
1779 * window.c (replace_window): Rename second argument REPLACEMENT to
1780 NEW. New third argument SETFLAG. Rewrite.
1781 (delete_window, make_dummy_parent): Call replace_window with
1782 third argument 1.
1783 (window_list_1): Move down in code.
1784 (run_window_configuration_change_hook): Move set_buffer part
1785 before select_frame_norecord part in order to unwind correctly.
1786 Rename count1 to count.
1787 (recombine_windows, delete_deletable_window, resize_root_window)
1788 (Fdelete_other_windows_internal)
1789 (Frun_window_configuration_change_hook, make_parent_window)
1790 (resize_window_check, resize_window_apply, Fresize_window_apply)
1791 (resize_frame_windows, Fsplit_window_internal)
1792 (Fdelete_window_internal, Fresize_mini_window_internal): New
1793 functions.
1794 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1795
1796 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1797
1798 * window.h (window): Add some new members to window structure -
1799 normal_lines, normal_cols, new_total, new_normal, clone_number,
1800 splits, nest, prev_buffers, next_buffers.
1801 (WINDOW_TOTAL_SIZE): Move here from window.c.
1802 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1803
1804 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1805 Remove.
1806 (make_dummy_parent): Set new members of windows structure.
1807 (make_window): Move down in code. Handle new members of window
1808 structure.
1809 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1810 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1811 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1812 (Fset_window_prev_buffers, Fwindow_next_buffers)
1813 (Fset_window_next_buffers, Fset_window_clone_number): New
1814 functions.
1815 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1816 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1817 Doc-string fixes.
1818 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1819 Argument WINDOW can be now internal window too.
1820 (Fwindow_use_time): Move up in code.
1821 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1822 Rewrite doc-string.
1823 (Fset_window_configuration, saved_window)
1824 (Fcurrent_window_configuration, save_window_save): Handle new
1825 members of window structure.
1826 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1827 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1828 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1829 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1830 Qget_mru_window, Qresize_root_window,
1831 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1832 Qauto_buffer_name; staticpro them.
1833
1834 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1835
1836 * window.c (Fwindow_total_size, Fwindow_left_column)
1837 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1838 (Fwindow_list_1): New functions.
1839 (window_box_text_cols): Replace with window_body_cols.
1840 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1841 window_body_cols instead of window_box_text_cols.
1842 (delete_window, Fset_window_configuration): Call
1843 delete_all_subwindows with window as argument.
1844 (delete_all_subwindows): Take a window as argument and not a
1845 structure. Rewrite.
1846 (window_loop): Remove handling of GET_LRU_WINDOW and
1847 GET_LARGEST_WINDOW.
1848 (Fget_lru_window, Fget_largest_window): Move to window.el.
1849
1850 * window.h: Extern window_body_cols instead of
1851 window_box_text_cols. delete_all_subwindows now takes a
1852 Lisp_Object as argument.
1853
1854 * indent.c (compute_motion, Fcompute_motion): Use
1855 window_body_cols instead of window_box_text_cols.
1856
1857 * frame.c (delete_frame): Call delete_all_subwindows with root
1858 window as argument.
1859
1860 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1861
1862 * fns.c (Fputhash): Document return value.
1863
1864 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1865
1866 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1867
1868 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Cons<->int and similar integer overflow fixes (Bug#8794).
1871
1872 Check for overflow when converting integer to cons and back.
1873 * charset.c (Fdefine_charset_internal, Fdecode_char):
1874 Use cons_to_unsigned to catch overflow.
1875 (Fencode_char): Use INTEGER_TO_CONS.
1876 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1877 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1878 * data.c (long_to_cons, cons_to_long): Remove.
1879 (cons_to_unsigned, cons_to_signed): New functions.
1880 These signal an error for invalid or out-of-range values.
1881 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1882 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1883 * font.c (Ffont_variation_glyphs):
1884 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1885 * lisp.h: Include <intprops.h>.
1886 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1887 (cons_to_signed, cons_to_unsigned): New decls.
1888 (long_to_cons, cons_to_long): Remove decls.
1889 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1890 (Fprimitive_undo): Use CONS_TO_INTEGER.
1891 * xfns.c (Fx_window_property): Likewise.
1892 * xselect.c: Include <limits.h>.
1893 (x_own_selection, selection_data_to_lisp_data):
1894 Use INTEGER_TO_CONS.
1895 (x_handle_selection_request, x_handle_selection_clear)
1896 (x_get_foreign_selection, Fx_disown_selection_internal)
1897 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1898 (lisp_data_to_selection_data): Use cons_to_unsigned.
1899 (x_fill_property_data): Use cons_to_signed.
1900 Report values out of range.
1901
1902 Check for buffer and string overflow more precisely.
1903 * buffer.h (BUF_BYTES_MAX): New macro.
1904 * lisp.h (STRING_BYTES_MAX): New macro.
1905 * alloc.c (Fmake_string):
1906 * character.c (string_escape_byte8):
1907 * coding.c (coding_alloc_by_realloc):
1908 * doprnt.c (doprnt):
1909 * editfns.c (Fformat):
1910 * eval.c (verror):
1911 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1912 since they may not be the same number.
1913 * editfns.c (Finsert_char):
1914 * fileio.c (Finsert_file_contents):
1915 Likewise for BUF_BYTES_MAX.
1916
1917 * image.c: Use ptrdiff_t, not int, for sizes.
1918 (slurp_file): Switch from int to ptrdiff_t.
1919 All uses changed.
1920 (slurp_file): Check that file size fits in both size_t (for
1921 malloc) and ptrdiff_t (for sanity and safety).
1922
1923 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1924 if b->modtime has its maximal value.
1925
1926 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1927
1928 Don't assume time_t can fit into int.
1929 * buffer.h (struct buffer.modtime): Now time_t, not int.
1930 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1931 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1932
1933 Minor fixes for signed vs unsigned integers.
1934 * character.h (MAYBE_UNIFY_CHAR):
1935 * charset.c (maybe_unify_char):
1936 * keyboard.c (read_char, reorder_modifiers):
1937 XINT -> XFASTINT, since the integer must be nonnegative.
1938 * ftfont.c (ftfont_spec_pattern):
1939 * keymap.c (access_keymap, silly_event_symbol_error):
1940 XUINT -> XFASTINT, since the integer must be nonnegative.
1941 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1942 since it makes no difference and we prefer signed.
1943 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1944 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1945 nonnegative.
1946
1947 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1948
1949 * window.h (Fwindow_frame): Declare.
1950
1951 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1954 (SPARE_MEMORY): Always define.
1955 (LARGE_REQUEST): Remove.
1956 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1957
1958 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1959
1960 * lisp.h: Move EXFUNS for Fframe_root_window,
1961 Fframe_first_window and Fset_frame_selected_window to window.h.
1962
1963 * window.h: Move EXFUNS for Fframe_root_window,
1964 Fframe_first_window and Fset_frame_selected_window here from
1965 lisp.h.
1966
1967 * frame.c (Fwindow_frame, Fframe_first_window)
1968 (Fframe_root_window, Fframe_selected_window)
1969 (Fset_frame_selected_window): Move to window.c.
1970 (Factive_minibuffer_window): Move to minibuf.c.
1971 (Fother_visible_frames_p): New function.
1972
1973 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1974
1975 * window.c (decode_window, decode_any_window): Move up in code.
1976 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1977 (inhibit_frame_unsplittable): Remove unused variable.
1978 (Fwindow_buffer): Move up and rewrite doc-string.
1979 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1980 (Fwindow_prev): New functions.
1981 (Fwindow_frame): Move here from frame.c. Accept any window as
1982 argument.
1983 (Fframe_root_window, Fframe_first_window)
1984 (Fframe_selected_window): Move here from frame.c. Accept frame
1985 or arbitrary window as argument. Update doc-strings.
1986 (Fminibuffer_window): Move up in code.
1987 (Fwindow_minibuffer_p): Move up in code and simplify.
1988 (Fset_frame_selected_window): Move here from frame.c.
1989 Marginal rewrite.
1990 (Fselected_window, select_window, Fselect_window): Move up in
1991 code. Minor doc-string fixes.
1992
1993 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1996 Do not assume that spare memory exists; that assumption is valid
1997 only if SYSTEM_MALLOC.
1998 (LARGE_REQUEST): New macro, so that the issue of large requests
1999 is separated from the issue of spare memory.
2000
2001 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2002
2003 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2004 format. (Bug#8806)
2005
2006 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2007
2008 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2009 before statements.
2010
2011 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2012
2013 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2014
2015 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2016
2017 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2018 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2019
2020 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2023
2024 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2025
2026 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2027 (x_clipboard_manager_save): Add return value.
2028 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2029 New error handlers.
2030 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2031 Obey Vx_select_enable_clipboard_manager. Catch errors in
2032 x_clipboard_manager_save (Bug#8779).
2033 (Vx_select_enable_clipboard_manager): New variable.
2034 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2035
2036 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2037
2038 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2039
2040 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2041
2042 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2043 in the current matrix if keep_current_p is non-zero.
2044
2045 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2046
2047 * bidi.c (bidi_level_of_next_char): Fix last change.
2048
2049 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2050
2051 Support bidi reordering of text covered by display properties.
2052
2053 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2054 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2055 (bidi_cache_search, bidi_cache_iterator_state)
2056 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2057 (bidi_level_of_next_char, bidi_move_to_visually_next):
2058 Support character positions inside a run of characters covered by a
2059 display string.
2060 (bidi_paragraph_init, bidi_resolve_explicit_1)
2061 (bidi_level_of_next_char): Call bidi_fetch_char and
2062 bidi_fetch_char_advance instead of FETCH_CHAR and
2063 FETCH_CHAR_ADVANCE.
2064 (bidi_init_it): Initialize new members.
2065 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2066 definitions.
2067 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2068 instead of using explicit *_CHAR codes.
2069 (bidi_resolve_explicit, bidi_resolve_weak):
2070 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2071 bidirectional text is supported only in multibyte buffers.
2072 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2073 it to initialize the frame_window_p member of struct bidi_it.
2074 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2075 (bidi_resolve_explicit, bidi_resolve_weak)
2076 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2077 bidi_it->nchars is non-positive.
2078 (bidi_level_of_next_char): Don't try to lookup the cache for the
2079 next/previous character if nothing is cached there yet, or if we
2080 were just reseat()'ed to a new position.
2081
2082 * xdisp.c (set_cursor_from_row): Set start and stop points
2083 according to the row's direction when priming the loop that looks
2084 for the glyph on which to display cursor.
2085 (single_display_spec_intangible_p): Function deleted.
2086 (display_prop_intangible_p): Reimplement to call
2087 handle_display_spec instead of single_display_spec_intangible_p.
2088 Accept 3 additional arguments needed by handle_display_spec.
2089 This fixes incorrect cursor motion across display property with complex
2090 values: lists, `(when COND...)' forms, etc.
2091 (single_display_spec_string_p): Support property values that are
2092 lists with the argument STRING its top-level element.
2093 (display_prop_string_p): Fix the condition for processing a
2094 property that is a list to be consistent with handle_display_spec.
2095 (handle_display_spec): New function, refactored from the
2096 last portion of handle_display_prop.
2097 (compute_display_string_pos): Accept additional argument
2098 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2099 value of a `display' property is a "replacing spec".
2100 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2101 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2102 the display property, but just return a value indicating whether
2103 the display property will replace the characters it covers.
2104 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2105 frame_window_p members of struct bidi_it.
2106 (compute_display_string_pos, compute_display_string_end):
2107 New functions.
2108 (push_it): Accept second argument POSITION, where pop_it should
2109 jump to continue iteration.
2110 (reseat_1): Initialize bidi_it.disp_pos.
2111
2112 * keyboard.c (adjust_point_for_property): Adjust the call to
2113 display_prop_intangible_p to its new signature.
2114
2115 * dispextern.h (struct bidi_it): New member frame_window_p.
2116 (bidi_init_it): Update prototypes.
2117 (display_prop_intangible_p): Update prototype.
2118 (compute_display_string_pos, compute_display_string_end):
2119 Declare prototypes.
2120 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2121 EMACS_INT.
2122
2123 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 Malloc failure behavior now depends on size of allocation.
2126 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2127 * lisp.h: Change signatures accordingly.
2128 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2129 All callers changed. (Bug#8762)
2130
2131 * gnutls.c: Use Emacs's memory allocators.
2132 Without this change, the gnutls library would invoke malloc etc.
2133 directly, which causes problems on non-SYNC_INPUT hosts, and which
2134 runs afoul of improving memory_full behavior. (Bug#8761)
2135 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2136 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2137 xfree instead of the default malloc, realloc, free.
2138 (Fgnutls_boot): No need to check for memory allocation failure,
2139 since xmalloc does that for us.
2140
2141 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2142 * category.c (hash_get_category_set):
2143 * ccl.c (ccl_driver):
2144 * charset.c (Fdefine_charset_internal):
2145 * charset.h (struct charset.hash_index):
2146 * composite.c (get_composition_id, gstring_lookup_cache)
2147 (composition_gstring_put_cache):
2148 * composite.h (struct composition.hash_index):
2149 * dispextern.h (struct image.hash):
2150 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2151 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2152 (hashfn_equal, hashfn_user_defined, make_hash_table)
2153 (maybe_resize_hash_table, hash_lookup, hash_put)
2154 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2155 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2156 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2157 * image.c (make_image, search_image_cache, lookup_image)
2158 (xpm_put_color_table_h):
2159 * lisp.h (struct Lisp_Hash_Table):
2160 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2161 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2162 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2163 * alloc.c (allocate_vectorlike):
2164 Check for overflow in vector size calculations.
2165 * ccl.c (ccl_driver):
2166 Check for overflow when converting EMACS_INT to int.
2167 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2168 need to be updated by these changes.
2169 * fns.c (make_hash_table, maybe_resize_hash_table):
2170 Check for integer overflow with large hash tables.
2171 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2172 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2173 (SXHASH_REDUCE): New macro.
2174 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2175 Use it instead of discarding useful hash info with large hash values.
2176 (sxhash_float): New function.
2177 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2178 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2179 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2180 Rewrite to use FIXNUM_BITS, as this simplifies things.
2181 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2182 Adjust signatures to match updated version of code.
2183 (consing_since_gc): Now EMACS_INT, since a single hash table can
2184 use more than INT_MAX bytes.
2185
2186 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2187
2188 Make it possible to build with GCC-4.6+ -O2 -flto.
2189
2190 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2191
2192 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2195 Call minibuffer-inactive-mode.
2196
2197 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2198
2199 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2200 Update dependencies.
2201
2202 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2203
2204 * data.c (init_data): Remove code for UTS, this system is not
2205 supported anymore.
2206
2207 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2208
2209 Don't force ./temacs to start in terminal mode.
2210
2211 * frame.c (make_initial_frame): Initialize faces in all cases, not
2212 only when CANNOT_DUMP is defined.
2213 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2214
2215 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2216
2217 * dispnew.c (add_window_display_history): Use const for the string
2218 pointer. Remove declaration, not needed.
2219
2220 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2221
2222 Use 'inline', not 'INLINE'.
2223 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2224 * alloc.c, fontset.c (INLINE): Remove.
2225 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2226 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2227 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2228 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2229 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2230
2231 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2232
2233 Make it possible to run ./temacs.
2234
2235 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2236 syms_of_callproc does the same thing. Remove test for
2237 "initialized", do it in the caller.
2238 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2239
2240 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2241
2242 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2243 (read_minibuf): Use get_minibuffer.
2244 (syms_of_minibuf): Use DEFSYM.
2245 (Qmetadata): New var.
2246 * data.c (Qbuffer): Don't make it static.
2247 (syms_of_data): Use DEFSYM.
2248
2249 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2252 (CCL_CODE_MIN): New macro.
2253
2254 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2257
2258 * eval.c (Qdebug): Now static.
2259 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2260 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2261 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2262
2263 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2264
2265 * image.c: Various fixes to ImageMagick code comments.
2266 (Fimagemagick_types): Doc fix.
2267
2268 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 Minor fixes prompted by GCC 4.6.0 warnings.
2271
2272 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2273
2274 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2275 (x_clipboard_manager_save_all): Move extern decl to ...
2276 * xterm.h: ... here, so that it can be checked for consistency.
2277
2278 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2279
2280 * xselect.c (x_clipboard_manager_save_frame)
2281 (x_clipboard_manager_save_all): New functions.
2282 (Fx_clipboard_manager_save): Lisp function deleted.
2283
2284 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2285 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2286
2287 * xterm.h: Update prototype.
2288
2289 2011-05-28 William Xu <william.xwl@gmail.com>
2290
2291 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2292 exiting (Bug#8239).
2293
2294 2011-05-28 Jim Meyering <meyering@redhat.com>
2295
2296 Avoid a sign-extension bug in crypto_hash_function.
2297 * fns.c (to_uchar): Define.
2298 (crypto_hash_function): Use it to convert some newly-signed
2299 variables to unsigned, to avoid sign-extension bugs. For example,
2300 without this change, (md5 "truc") would evaluate to
2301 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2302 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2303 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2304
2305 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 Integer overflow fixes.
2308
2309 * dbusbind.c: Serial number integer overflow fixes.
2310 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2311 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2312 to hold a serial number that is too large for a fixnum.
2313 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2314 Check for serial numbers out of range. Decode any serial number
2315 that was so large that it became a float. (Bug#8722)
2316
2317 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2318 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2319 Use XFASTINT rather than XUINT when numbers are nonnegative.
2320 (xd_append_arg, Fdbus_method_return_internal):
2321 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2322 arguments, check that Lisp number is nonnegative, rather than
2323 silently wrapping negative numbers around. (Bug#8722)
2324 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2325 (Bug#8722)
2326
2327 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2328
2329 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2330
2331 ccl: add integer overflow checks
2332 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2333 (IN_INT_RANGE): New macros.
2334 (ccl_driver): Use them to check for integer overflow when
2335 decoding a CCL program. Many of the new checks are whether XINT (x)
2336 fits in int; it doesn't always, on 64-bit hosts. The new version
2337 doesn't catch all possible integer overflows, but it's an
2338 improvement. (Bug#8719)
2339
2340 * alloc.c (make_event_array): Use XINT, not XUINT.
2341 There's no need for unsigned here.
2342
2343 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2344 This follows up to the 2011-05-06 change that substituted uintptr_t
2345 for EMACS_INT. This case wasn't caught back then.
2346
2347 Rework Fformat to avoid integer overflow issues.
2348 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2349 now (part of C89). Include <verify.h>.
2350 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2351 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2352 (Fformat): Avoid the prepass trying to compute sizes; it was only
2353 approximate and thus did not catch overflow reliably. Instead, walk
2354 through the format just once, formatting and computing sizes as we go,
2355 checking for integer overflow at every step, and allocating a larger
2356 buffer as needed. Keep track separately whether the format is
2357 multibyte. Keep only the most-recently calculated precision, rather
2358 than them all. Record whether each argument has been converted to
2359 string. Use EMACS_INT, not int, for byte and char and arg counts.
2360 Support field widths and precisions larger than INT_MAX. Avoid
2361 sprintf's undefined behavior with conversion specifications such as %#d
2362 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2363 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2364 formatting out-of-range floating point numbers with int
2365 formats. (Bug#8668)
2366
2367 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2368
2369 * data.c: Avoid integer truncation in expressions involving floats.
2370 * data.c: Include <intprops.h>.
2371 (arith_driver): When there's an integer overflow in an expression
2372 involving floating point, convert the integers to floating point
2373 so that the resulting value does not suffer from catastrophic
2374 integer truncation. For example, on a 64-bit host (* 4
2375 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2376 Do not rely on undefined behavior after integer overflow.
2377
2378 merge count_size_as_multibyte, parse_str_to_multibyte
2379 * character.c, character.h (count_size_as_multibyte):
2380 Rename from parse_str_to_multibyte; all uses changed.
2381 Check for integer overflow.
2382 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2383 since it's now a duplicate of the other. This is more of
2384 a character than a buffer op, so better that it's in character.c.
2385 * fns.c, print.c: Adjust to above changes.
2386
2387 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2388
2389 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2390
2391 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2394 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2395 (x_clipboard_manager_save): Now static.
2396 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2397
2398 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2399 (crypto_hash_function): Now static.
2400 Fix pointer signedness problems. Avoid unnecessary initializations.
2401
2402 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2403
2404 * termhooks.h (Vselection_alist): Make it terminal-local.
2405
2406 * terminal.c (create_terminal): Initialize it.
2407
2408 * xselect.c: Support for clipboard managers.
2409 (Vselection_alist): Move to termhooks.h as terminal-local var.
2410 (LOCAL_SELECTION): New macro.
2411 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2412 (symbol_to_x_atom): Remove gratuitous arg.
2413 (x_handle_selection_request, lisp_data_to_selection_data)
2414 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2415 (x_own_selection, x_get_local_selection, x_convert_selection):
2416 New arg, specifying work frame. Use terminal-local Vselection_alist.
2417 (some_frame_on_display): Delete unused function.
2418 (Fx_own_selection_internal, Fx_get_selection_internal)
2419 (Fx_disown_selection_internal, Fx_selection_owner_p)
2420 (Fx_selection_exists_p): New optional frame arg.
2421 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2422 (x_handle_selection_clear): Don't treat other terminals with the
2423 same keyboard specially. Use the terminal-local Vselection_alist.
2424 (x_clear_frame_selections): Use Frun_hook_with_args.
2425
2426 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2427
2428 * xterm.h: Add support for those atoms.
2429
2430 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2431
2432 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2433 (converted_selections, conversion_fail_tag): New global variables.
2434 (x_selection_request_lisp_error): Free the above.
2435 (x_get_local_selection): Remove unnecessary code.
2436 (x_reply_selection_request): Args changed; handle arbitrary array
2437 of converted selections stored in converted_selections.
2438 Separate the XChangeProperty and SelectionNotify steps.
2439 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2440 (x_convert_selection): New function.
2441 (x_handle_selection_event): Simplify.
2442 (x_get_foreign_selection): Don't ignore incoming requests while
2443 waiting for an answer; this will fail when we implement
2444 SAVE_TARGETS, and seems unnecessary anyway.
2445 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2446 (Vx_sent_selection_functions): Doc fix.
2447
2448 2011-05-26 Leo Liu <sdl.web@gmail.com>
2449
2450 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2451
2452 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2453
2454 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2455
2456 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2457 for fringe update if it has periodic bitmap.
2458 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2459 and fringe_bitmap_periodic_p.
2460
2461 * fringe.c (get_fringe_bitmap_data): New function.
2462 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2463 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2464 row. Mark glyph row for fringe update if periodicity changed.
2465
2466 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2467 for fringe update unless it has periodic bitmap.
2468
2469 2011-05-25 Kenichi Handa <handa@m17n.org>
2470
2471 * xdisp.c (get_next_display_element): Set correct it->face_id for
2472 a static composition.
2473
2474 2011-05-24 Leo Liu <sdl.web@gmail.com>
2475
2476 * deps.mk (fns.o):
2477 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2478
2479 * fns.c (crypto_hash_function, Fsha1): New function.
2480 (Fmd5): Use crypto_hash_function.
2481 (syms_of_fns): Add Ssha1.
2482
2483 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * gnutls.c: Remove unused macros.
2486 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2487 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2488 Remove macros that are defined and never used.
2489 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2490
2491 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2492
2493 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2494 (Fx_get_selection_internal): Minor cleanup.
2495 (Fx_own_selection_internal): Rename arguments for consistency with
2496 select.el.
2497
2498 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2501
2502 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2503
2504 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2505
2506 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2507
2508 * dispnew.c (scrolling_window): Don't exclude the case that the
2509 last enabled row in the desired matrix touches the bottom boundary.
2510
2511 2011-05-21 Glenn Morris <rgm@gnu.org>
2512
2513 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2514 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2515 and add some more files.
2516
2517 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2518
2519 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2520 report_file_error introduced by the change from 2011-05-07.
2521
2522 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2523
2524 * systime.h (Time): Define only if emacs is defined.
2525 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2526 where the include path doesn't have X11/X.h by default. See
2527 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2528
2529 2011-05-20 Kenichi Handa <handa@m17n.org>
2530
2531 * composite.c (find_automatic_composition): Fix previous change.
2532
2533 2011-05-20 Glenn Morris <rgm@gnu.org>
2534
2535 * lisp.mk: New file, split from Makefile.in.
2536 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2537 (shortlisp): Remove.
2538 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2539
2540 2011-05-19 Glenn Morris <rgm@gnu.org>
2541
2542 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2543 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2544 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2545 (lisp): Set the order to that of loadup.el.
2546 (shortlisp): Make it a copy of $lisp.
2547 (SOME_MACHINE_LISP): Remove.
2548 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2549 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2550
2551 2011-05-18 Kenichi Handa <handa@m17n.org>
2552
2553 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2554 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2555 (find_automatic_composition): Mostly rewrite for efficiency.
2556
2557 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2558
2559 * makefile.w32-in: Update dependencies.
2560
2561 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2562
2563 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2564 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2565
2566 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 Fix some integer overflow issues, such as string length overflow.
2569
2570 * insdel.c (count_size_as_multibyte): Check for string overflow.
2571
2572 * character.c (lisp_string_width): Check for string overflow.
2573 Use EMACS_INT, not int, for string indexes and lengths; in
2574 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2575 the resulting string length overflows an EMACS_INT; instead,
2576 report a string overflow if no precision given. When checking for
2577 precision exhaustion, use a check that cannot possibly have
2578 integer overflow. (Bug#8675)
2579 * character.h (lisp_string_width): Adjust to new signature.
2580
2581 * alloc.c (string_overflow): New function.
2582 (Fmake_string): Use it. This doesn't change behavior, but saves
2583 a few bytes and will simplify future changes.
2584 * character.c (string_escape_byte8): Likewise.
2585 * lisp.h (string_overflow): New decl.
2586
2587 Fixups, following up to the user-interface timestamp change.
2588 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2589 for UI timestamps, instead of unsigned long.
2590 * msdos.c (mouse_get_pos): Likewise.
2591 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2592 * w32gui.h (Time): Define by including "systime.h" rather than by
2593 declaring it ourselves. (Bug#8664)
2594
2595 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2596 * image.c (clear_image_cache): Likewise.
2597
2598 * term.c (term_mouse_position): Don't assume time_t wraparound.
2599
2600 Be more systematic about user-interface timestamps.
2601 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2602 and sometimes 'EMACS_UINT', to represent these timestamps.
2603 This change causes it to use 'Time' uniformly, as that's what X uses.
2604 This makes the code easier to follow, and makes it easier to catch
2605 integer overflow bugs such as Bug#8664.
2606 * frame.c (Fmouse_position, Fmouse_pixel_position):
2607 Use Time, not unsigned long, for user-interface timestamps.
2608 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2609 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2610 * keyboard.h (last_event_timestamp): Likewise.
2611 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2612 * menu.h (xmenu_show): Likewise.
2613 * term.c (term_mouse_position): Likewise.
2614 * termhooks.h (struct input_event.timestamp): Likewise.
2615 (struct terminal.mouse_position_hook): Likewise.
2616 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2617 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2618 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2619 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2620 what it was before.
2621 * menu.h, termhooks.h: Include "systime.h", for Time.
2622
2623 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2624 Don't assume that the difference between two unsigned long values
2625 can fit into an integer. At this point, we know button_down_time
2626 <= event->timestamp, so the difference must be nonnegative, so
2627 there's no need to cast the result if double-click-time is
2628 nonnegative, as it should be; check that it's nonnegative, just in
2629 case. This bug is triggered when events are more than 2**31 ms
2630 apart (about 25 days). (Bug#8664)
2631
2632 * xselect.c (last_event_timestamp): Remove duplicate decl.
2633 (x_own_selection): Remove needless cast to unsigned long.
2634
2635 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2636 that always fit in int. Use a sentinel instead of a counter, to
2637 avoid a temp and to allay GCC's concerns about possible int overflow.
2638 * frame.h (struct frame): Use int for menu_bar_items_used
2639 instead of EMACS_INT, since it always fits in int.
2640
2641 * menu.c (grow_menu_items): Check for int overflow.
2642
2643 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2644
2645 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2646 Before, the code was not consistent. These values cannot exceed
2647 2**31 - 1 so there's no need to make them unsigned.
2648 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2649 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2650 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2651 as modifiers.
2652 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2653
2654 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2655 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2656 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2657 presumably because the widths might not match.
2658
2659 * window.c (size_window): Avoid needless test at loop start.
2660
2661 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2662
2663 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2664
2665 2011-05-12 Drew Adams <drew.adams@oracle.com>
2666
2667 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2668
2669 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2670
2671 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2672 `width' to `bar_area_x' and `bar_area_width', respectively.
2673 (x_scroll_run): Take account of fringe background extension.
2674
2675 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2676 Rename local vars `left' and `width' to `bar_area_x' and
2677 `bar_area_width', respectively.
2678 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2679 background extension.
2680
2681 2011-05-10 Jim Meyering <meyering@redhat.com>
2682
2683 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2684
2685 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2686
2687 * image.c (Finit_image_library): Return t for built-in image types,
2688 like pbm and xbm. (Bug#8640)
2689
2690 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2691
2692 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2693
2694 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2695
2696 * w32console.c (Fset_screen_color): Doc fix.
2697 (Fget_screen_color): New function.
2698 (syms_of_ntterm): Defsubr it.
2699
2700 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2701 unlink the temporary file if Fcall_process didn't create it in the
2702 first place.
2703 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2704 child process will be redirected to a file specified with `:file'.
2705 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2706 cue to call_process_cleanup not to close that handle.
2707
2708 2011-05-07 Ben Key <bkey76@gmail.com>
2709
2710 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2711 one of two shell specific rules, either bootstrap-temacs-CMD or
2712 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2713 to the previous implementation of the bootstrap-temacs rule.
2714 The bootstrap-temacs-CMD rule is similar to the previous
2715 implementation of the bootstrap-temacs rule except that it
2716 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2717 variable.
2718
2719 These changes, along with some changes to nt/configure.bat,
2720 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2721 earlier fix to add support for --cflags and --ldflags options
2722 that include quotes so that it works whether make uses cmd or
2723 sh as the shell.
2724
2725 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2726
2727 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2728 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2729 is a constant.
2730 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2731 a string. Handle both cases.
2732 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2733 (Fdbus_register_method): Use Qinvalid_function.
2734
2735 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2736
2737 * makefile.w32-in: Update dependencies.
2738 (LISP_H): Add inttypes.h and stdin.h.
2739 (PROCESS_H): Add unistd.h.
2740
2741 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2742
2743 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2744 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2745
2746 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2747
2748 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2749
2750 * term.c (vfatal): Remove stray call to va_end.
2751 It's not needed and the C Standard doesn't allow it here anyway.
2752
2753 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2754 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2755
2756 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2757 bytes.
2758
2759 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2760
2761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2762
2763 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2764
2765 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2766
2767 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2768
2769 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2770 * charset.c (Fdefine_charset_internal): Don't initialize
2771 charset.code_space[15]. The value was garbage, on hosts with
2772 32-bit int (Bug#8600).
2773
2774 * lread.c (read_integer): Be more consistent with string-to-number.
2775 Use string_to_number to do the actual conversion; this avoids
2776 rounding errors and fixes some other screwups. Without this fix,
2777 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2778 (digit_to_number): Move earlier, for benefit of read_integer.
2779 Return -1 if the digit is out of range for the base, -2 if it is
2780 not a digit in any supported base. (Bug#8602)
2781
2782 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2783
2784 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2785 to match comment at start of function. This also removes a
2786 GCC warning about overflow in a 32+64-bit port.
2787
2788 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2789
2790 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2791 Reported by Stefan Monnier in
2792 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2793 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2794 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2795
2796 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2797 (EMACS_UINTPTR): Likewise, with uintptr_t.
2798
2799 * lisp.h: Prefer 64-bit EMACS_INT if available.
2800 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2801 on 32-bit hosts that have 64-bit int, so that they can access
2802 large files.
2803 However, temporarily disable this change unless the temporary
2804 symbol WIDE_EMACS_INT is defined.
2805
2806 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2807
2808 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2809 This removes an assumption that EMACS_INT and long are the same
2810 width as pointers. The assumption is true for Emacs porting targets
2811 now, but we want to make other targets possible.
2812 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2813 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2814 In the rest of the code, change types of integers that hold casted
2815 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2816 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2817 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2818 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2819 No need to cast type when ORing.
2820 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2821 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2822 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2823 assume EMACS_INT is the same width as char *.
2824 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2825 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2826 Remove no-longer-needed casts.
2827 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2828 (xg_tool_bar_help_callback, xg_make_tool_item):
2829 Use EMACS_INTPTR to hold an integer
2830 that will be cast to void *; this can avoid a GCC warning
2831 if EMACS_INT is not the same width as void *.
2832 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2833 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2834 (current_message_1, set_message_1):
2835 Use a local to convert to proper width without a cast.
2836 * xmenu.c (dialog_selection_callback): Likewise.
2837
2838 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2839 Also, don't assume VALBITS / RAND_BITS is less than 5,
2840 and don't rely on undefined behavior when shifting a 1 left into
2841 the sign bit.
2842 * lisp.h (get_random): Change signature to match.
2843
2844 * lread.c (hash_string): Use size_t, not int, for hash computation.
2845 Normally we prefer signed values; but hashing is special, because
2846 it's better to use unsigned division on hash table sizes so that
2847 the remainder is nonnegative. Also, size_t is the natural width
2848 for hashing into memory. The previous code used 'int', which doesn't
2849 retain enough info to hash well into very large tables.
2850 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2851
2852 * dbusbind.c: Don't possibly lose pointer info when converting.
2853 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2854 Use XPNTR rather than XHASH, so that the high-order bits of
2855 the pointer aren't lost when converting through void *.
2856
2857 * eval.c (Fautoload): Don't double-shift a pointer.
2858
2859 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2860
2861 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2862
2863 * gnutls.c (DEF_GNUTLS_FN):
2864 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2865
2866 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2867
2868 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2869 marker. (Bug#8610)
2870
2871 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2872
2873 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2874 New version that can reserve upto 2GB of heap space.
2875
2876 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2877
2878 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2879
2880 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2881
2882 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2883 `gnutls_certificate_set_x509_key_file'.
2884
2885 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2886
2887 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2888 Update dependencies.
2889
2890 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2891
2892 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2893 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2894 Remove unused parameter `fildes'.
2895 * process.c (read_process_output, send_process): Don't pass it.
2896
2897 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2898
2899 Fix previous change: the library cache is defined in w32.c.
2900 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2901 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2902
2903 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2904
2905 Implement dynamic loading of GnuTLS on Windows.
2906
2907 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2908 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2909 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2910 Declare.
2911
2912 * gnutls.c (Qgnutls_dll): Define.
2913 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2914 (gnutls_*): Declare function pointers.
2915 (init_gnutls_functions): New function to initialize function pointers.
2916 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2917 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2918 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2919 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2920 (emacs_gnutls_write, emacs_gnutls_read)
2921 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2922 (Fgnutls_available_p): New function.
2923 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2924 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2925 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2926
2927 * image.c: Include w32.h.
2928 (Vimage_type_cache): Delete.
2929 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2930 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2931 (w32_delayed_load): Move to w32.c.
2932
2933 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2934
2935 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2936 (w32_delayed_load): Move from image.c. When loading a library, record
2937 its filename in the :loaded-from property of the library id.
2938 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2939 Initialize and staticpro them.
2940 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2941
2942 * process.c: Include lisp.h before w32.h, not after.
2943 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2944 instead of gnutls_record_check_pending.
2945
2946 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2947
2948 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2949
2950 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2951 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2952 as passed in.
2953
2954 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2955
2956 * xterm.c (x_set_frame_alpha): Do not set property on anything
2957 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2958
2959 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2960
2961 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2962
2963 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2964
2965 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2966 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2967 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2968 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2969 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2970 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2971 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2972 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2973 (Qgnutls_bootprop_callbacks_verify): Make static.
2974
2975 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2976
2977 * callproc.c: Indentation fixup.
2978
2979 * sysdep.c (wait_for_termination_1): Make static.
2980 (wait_for_termination, interruptible_wait_for_termination):
2981 Move after wait_for_termination_1.
2982
2983 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2984
2985 * sysdep.c (interruptible_wait_for_termination): New function
2986 which is like wait_for_termination, but allows keyboard
2987 interruptions.
2988
2989 * callproc.c (Fcall_process): Add (:file "file") as an option for
2990 the STDOUT buffer.
2991 (Fcall_process_region): Ditto.
2992
2993 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2994
2995 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2996 rather than `XVECTOR (FOO)->size'.
2997
2998 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2999 inttypes.h, as a gnulib replacement is used if it not available in
3000 system headers.
3001
3002 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3003
3004 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3005 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3006 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3007
3008 * coding.c (coding_alloc_by_realloc): Error out if destination
3009 will grow beyond MOST_POSITIVE_FIXNUM.
3010 (decode_coding_emacs_mule): Abort if there isn't enough place in
3011 charbuf for the composition carryover bytes. Reserve an extra
3012 space for up to 2 characters produced in a loop.
3013 (decode_coding_iso_2022): Abort if there isn't enough place in
3014 charbuf for the composition carryover bytes.
3015
3016 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3017
3018 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3019 aborting when %lld or %lll format is passed.
3020 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3021 %llo or %llx format is passed. (Bug#8545)
3022
3023 * window.c (window_scroll_line_based): Use a marker instead of
3024 simple variables to record original value of point. (Bug#7952)
3025
3026 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3027 produced by %s or %c overflows available buffer space. (Bug#8545)
3028
3029 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3030
3031 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3032 (SIZE_MAX): Move defn after all includes, as they might #define it.
3033
3034 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3035
3036 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3037
3038 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * keyboard.c (Qdelayed_warnings_hook): Define.
3041 (command_loop_1): Run `delayed-warnings-hook'
3042 if Vdelayed_warnings_list is non-nil.
3043 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3044 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3045
3046 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3047
3048 * doprnt.c (doprnt): Don't return value smaller than the buffer
3049 size if the message was truncated. (Bug#8545).
3050
3051 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3052
3053 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3054 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3055
3056 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3059
3060 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * makefile.w32-in: Update dependencies.
3063
3064 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3065
3066 Improve `doprnt' and its usage. (Bug#8545)
3067 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3068 `format_end'. Remove support for %l as a conversion specifier.
3069 Don't use xrealloc. Improve diagnostics when the %l size modifier
3070 is used. Update the commentary.
3071
3072 * eval.c (verror): Simplify calculation of size_t.
3073
3074 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3075 messages.
3076
3077 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3078
3079 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3080 change.
3081
3082 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3085 This makes this file independent of the recent pseudovector change.
3086
3087 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3088
3089 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3090
3091 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3092 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3093 Remove unused local.
3094 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3095
3096 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3097 GCC 4.6.0 optimizes based on type-based alias analysis.
3098 For example, if b is of type struct buffer * and v of type struct
3099 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3100 != &v->size, and therefore "v->size = 1; b->size = 2; return
3101 v->size;" must therefore return 1. This assumption is incorrect
3102 for Emacs, since it type-puns struct Lisp_Vector * with many other
3103 types. To fix this problem, this patch adds a new type struct
3104 vectorlike_header that documents the constraints on layout of vectors
3105 and pseudovectors, and helps optimizing compilers not get fooled
3106 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3107 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3108 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3109 the size member.
3110 (XSETPVECTYPE): Rewrite in terms of new macro.
3111 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3112 This is a bit clearer, and further avoids the possibility of
3113 undesirable aliasing.
3114 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3115 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3116 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3117 since Lisp_Subr is a special case (no "next" field).
3118 (ASIZE): Now uses header.size rather than size.
3119 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3120 to avoid the hassle of writing XVECTOR (foo)->header.size.
3121 (struct vectorlike_header): New type.
3122 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3123 object, to help avoid aliasing.
3124 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3125 (SUBRP): Likewise, since Lisp_Subr is a special case.
3126 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3127 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3128 (struct Lisp_Hash_Table): Combine first two members into a single
3129 struct vectorlike_header member. All uses of "size" and "next" members
3130 changed to be "header.size" and "header.next".
3131 * buffer.h (struct buffer): Likewise.
3132 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3133 * frame.h (struct frame): Likewise.
3134 * process.h (struct Lisp_Process): Likewise.
3135 * termhooks.h (struct terminal): Likewise.
3136 * window.c (struct save_window_data, struct saved_window): Likewise.
3137 * window.h (struct window): Likewise.
3138 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3139 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3140 * buffer.c (init_buffer_once): Likewise.
3141 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3142 special case.
3143 * process.c (Fformat_network_address): Use local var for size,
3144 for brevity.
3145
3146 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3147
3148 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3149 * data.c (atof): Remove decl; no longer used or needed.
3150 (digit_to_number): Move to lread.c.
3151 (Fstring_to_number): Use new string_to_number function, to be
3152 consistent with how the Lisp reader treats infinities and NaNs.
3153 Do not assume that floating-point numbers represent EMACS_INT
3154 without losing information; this is not true on most 64-bit hosts.
3155 Avoid double-rounding errors, by insisting on integers when
3156 parsing non-base-10 numbers, as the documentation specifies.
3157 * lisp.h (string_to_number): New decl, replacing ...
3158 (isfloat_string): Remove.
3159 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3160 (read1): Do not accept +. and -. as integers; this
3161 appears to have been a coding error. Similarly, do not accept
3162 strings like +-1e0 as floating point numbers. Do not report
3163 overflow for integer overflows unless the base is not 10 which
3164 means we have no simple and reliable way to continue.
3165 Break out the floating-point parsing into a new
3166 function string_to_number, so that Fstring_to_number parses
3167 floating point numbers consistently with the Lisp reader.
3168 (digit_to_number): Move here from data.c. Make it static inline.
3169 (E_CHAR, EXP_INT): Remove, replacing with ...
3170 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3171 (string_to_number): New function, replacing isfloat_string.
3172 This function checks for valid syntax and produces the resulting
3173 Lisp float number too. Rework it so that string-to-number
3174 no longer mishandles examples like "1.0e+". Use strtoumax,
3175 so that overflow for non-base-10 numbers is reported only when
3176 there's no portable and simple way to convert to floating point.
3177
3178 * textprop.c (set_text_properties_1): Rewrite for clarity,
3179 and to avoid GCC warning about integer overflow.
3180
3181 * intervals.h (struct interval): Use EMACS_INT for members
3182 where EMACS_UINT might cause problems. See
3183 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3184 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3185 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3186 All uses changed.
3187 (offset_intervals): Tell GCC not to worry about length overflow
3188 when negating a negative length.
3189
3190 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3191 (overrun_check_free): Likewise.
3192
3193 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3194 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3195 word size.
3196
3197 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3198 (gnutls_make_error): Rename local to avoid shadowing.
3199 (gnutls_emacs_global_deinit): ifdef out; not used.
3200 (Fgnutls_boot): Use const for pointer to readonly storage.
3201 Comment out unused local. Fix pointer signedness problems.
3202
3203 * lread.c (openp): Don't stuff size_t into an 'int'.
3204 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3205 about possible signed overflow.
3206
3207 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3208 (GDK_KEY_g): Don't define if already defined.
3209 (xg_prepare_tooltip): Avoid pointer signedness problem.
3210 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3211
3212 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3213 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3214
3215 * xfns.c (Fx_window_property): Simplify a bit,
3216 to make a bit faster and to avoid GCC 4.6.0 warning.
3217 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3218
3219 * fns.c (internal_equal): Don't assume size_t fits in int.
3220
3221 * alloc.c (compact_small_strings): Tighten assertion a little.
3222
3223 Replace pEd with more-general pI, and fix some printf arg casts.
3224 * lisp.h (pI): New macro, generalizing old pEd macro to other
3225 conversion specifiers. For example, use "...%"pI"d..." rather
3226 than "...%"pEd"...".
3227 (pEd): Remove. All uses replaced with similar uses of pI.
3228 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3229 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3230 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3231 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3232 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3233 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3234 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3235 64-bit hosts.
3236 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3237 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3238 * print.c (safe_debug_print, print_object): Likewise.
3239 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3240 to int.
3241 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3242 avoiding the 0 flag, which is not portable.
3243 * process.c (Fmake_network_process): Use pI to avoid cast.
3244 * region-cache.c (pp_cache): Likewise.
3245 * xdisp.c (decode_mode_spec): Likewise.
3246 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3247 behavior on 64-bit hosts with printf arg.
3248 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3249 (x_stop_queuing_selection_requests): Likewise.
3250 (x_get_window_property): Don't truncate byte count to an 'int'
3251 when tracing.
3252
3253 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3254 here, since it parses constructs like leading '-' and spaces,
3255 which are not wanted; and it overflows with large numbers.
3256 Instead, simply match F[0-9]+, which is what is wanted anyway.
3257
3258 * alloc.c: Remove unportable assumptions about struct layout.
3259 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3260 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3261 (allocate_vectorlike, make_pure_vector): Use the new macros,
3262 plus offsetof, to remove unportable assumptions about struct layout.
3263 These assumptions hold on all porting targets that I know of, but
3264 they are not guaranteed, they're easy to remove, and removing them
3265 makes further changes easier.
3266
3267 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3268 This doesn't fix a bug but makes the code clearer.
3269 (string_overrun_cookie): Now const. Use initializers that
3270 don't formally overflow signed char, to avoid warnings.
3271 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3272 can cause Emacs to crash when string overrun checking is enabled.
3273 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3274 multiple of sizeof (EMACS_INT); it need not be, if
3275 alignof(EMACS_INT) < sizeof (EMACS_INT).
3276 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3277
3278 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3279
3280 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3281
3282 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3283
3284 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3285 supposed to be handshaking. (Bug#8556)
3286 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3287
3288 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3289
3290 * lisp.h (Qdebug): List symbol.
3291 * eval.c (Qdebug): Restore global linkage.
3292 * keyboard.c (debug-on-event): New variable.
3293 (handle_user_signal): Break into debugger when debug-on-event
3294 matches the current signal symbol.
3295
3296 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3297
3298 * alloc.c (check_sblock, check_string_bytes)
3299 (check_string_free_list): Convert to standard C.
3300
3301 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3302
3303 * w32.c (emacs_gnutls_push): Fix typo.
3304
3305 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3306
3307 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3308 "cast to pointer from integer of different size".
3309
3310 Improve doprnt and its use in verror. (Bug#8545)
3311 * doprnt.c (doprnt): Document the set of format control sequences
3312 supported by the function. Use SAFE_ALLOCA instead of always
3313 using `alloca'.
3314
3315 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3316 is one byte too soon. Don't use xrealloc; instead xfree and
3317 xmalloc anew.
3318
3319 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3320
3321 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3322 callbacks stage.
3323
3324 * gnutls.c: Renamed global_initialized to
3325 gnutls_global_initialized. Added internals for the
3326 :verify-hostname-error, :verify-error, and :verify-flags
3327 parameters of `gnutls-boot' and documented those parameters in the
3328 docstring. Start callback support.
3329 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3330 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3331 on error. Return error code.
3332 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3333 (emacs_gnutls_read): Likewise.
3334 (Fgnutls_boot): Return handshake error code.
3335 (emacs_gnutls_handle_error): New function.
3336 (wsaerror_to_errno): Likewise.
3337
3338 * w32.h (emacs_gnutls_pull): Add prototype.
3339 (emacs_gnutls_push): Likewise.
3340
3341 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3342 (emacs_gnutls_push): Likewise.
3343
3344 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3345
3346 * process.c (wait_reading_process_output): Check if GnuTLS
3347 buffered some data internally if no FDs are set for TLS
3348 connections.
3349
3350 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3351 (LIBS): Link to USER_LIBS.
3352 ($(BLD)/gnutls.$(0)): New target.
3353
3354 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3355
3356 * xdisp.c (handle_single_display_spec): Rename the
3357 display_replaced_before_p argument into display_replaced_p, to
3358 make it consistent with the commentary. Fix typos in the
3359 commentary.
3360
3361 * textprop.c (syms_of_textprop): Remove dead code.
3362 (copy_text_properties): Delete obsolete commentary about an
3363 interface that was deleted long ago. Fix typos in the description
3364 of arguments.
3365
3366 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3367 to changes in oldXMenu/XMenu.h from 2011-04-16.
3368 <menu_help_message, prev_menu_help_message>: Constify.
3369 (IT_menu_make_room): menu->help_text is now `const char **';
3370 adjust.
3371
3372 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3373 to changes in oldXMenu/XMenu.h from 2011-04-16.
3374 (struct XMenu): Declare `help_text' `const char **'.
3375
3376 * xfaces.c <Qunspecified>: Make extern again.
3377
3378 * syntax.c: Include sys/types.h before including regex.h, as
3379 required by Posix.
3380
3381 * doc.c (get_doc_string): Improve the format passed to `error'.
3382
3383 * doprnt.c (doprnt): Improve commentary.
3384
3385 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3386
3387 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3388 them with etags.
3389
3390 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3391 changes in globals.h immediately force recompilation.
3392 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3393 $(CURDIR)/s/ms-w32.h.
3394 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3395
3396 * character.c (Fchar_direction): Function deleted.
3397 (syms_of_character): Don't defsubr it.
3398 <char-direction-table>: Deleted.
3399
3400 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3401
3402 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3403 * doprnt.c: Include limits.h.
3404 (SIZE_MAX): New macro.
3405 (doprnt): Return a size_t value. 2nd arg is now size_t.
3406 Many local variables are now size_t instead of int or unsigned.
3407 Improve overflow protection. Support `l' modifier for integer
3408 conversions. Support %l conversion. Don't assume an EMACS_INT
3409 argument for integer conversions and for %c.
3410
3411 * lisp.h (doprnt): Restore prototype.
3412
3413 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3414 $(SRC)/character.h.
3415
3416 * Makefile.in (base_obj): Add back doprnt.o.
3417
3418 * deps.mk (doprnt.o): Add back prerequisites.
3419 (callint.o): Depend on character.h.
3420
3421 * eval.c (internal_lisp_condition_case): Include the handler
3422 representation in the error message.
3423 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3424 when breaking from the loop.
3425
3426 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3427
3428 * callint.c (Fcall_interactively): When displaying error message
3429 about invalid control letter, pass the character's codepoint, not
3430 a pointer to its multibyte form. Improve display of the character
3431 in octal and display also its hex code.
3432
3433 * character.c (char_string): Use %x to display the (unsigned)
3434 codepoint of an invalid character, to avoid displaying a bogus
3435 negative value.
3436
3437 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3438 `error', not SYMBOL_NAME itself.
3439
3440 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3441 character arguments to `error'.
3442
3443 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3444 to `error' in error message about FINAL_CHAR argument. Make sure
3445 FINAL_CHAR is a character, and use %c when it is passed as
3446 argument to `error'.
3447
3448 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3449
3450 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3451
3452 * w32.c: Include <time.h>.
3453 (sys_localtime): New function.
3454
3455 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3456
3457 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3458
3459 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3460
3461 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3462
3463 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3464 zombies (Bug#8467).
3465
3466 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3467
3468 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3469 gl_state.e_property when gl_state.object is Qt.
3470
3471 * insdel.c (make_gap_larger): Remove limitation of buffer size
3472 to <= INT_MAX.
3473
3474 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3475
3476 * xdisp.c (lookup_glyphless_char_display)
3477 (produce_glyphless_glyph): Handle cons cell entry in
3478 glyphless-char-display.
3479 (Vglyphless_char_display): Document it.
3480
3481 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3482 glyphless-char-display.
3483
3484 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3485
3486 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3487
3488 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3489
3490 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3491 definition for no-X builds.
3492
3493 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 Static checks with GCC 4.6.0 and non-default toolkits.
3496
3497 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3498
3499 * process.c (keyboard_bit_set): Define only if SIGIO.
3500 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3501 (send_process): Repair possible setjmp clobbering.
3502
3503 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3504
3505 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3506
3507 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3508
3509 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3510 Define only if needed.
3511
3512 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3513 by pacifying GCC about it. Maybe it's time to retire it?
3514 * xfaces.c (USG, __TIMEVAL__): Likewise.
3515
3516 * dispextern.h (struct redisplay_interface): Rename param
3517 to avoid shadowing.
3518 * termhooks.h (struct terminal): Likewise.
3519 * xterm.c (xembed_send_message): Likewise.
3520
3521 * insdel.c (make_gap_smaller): Define only if
3522 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3523
3524 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3525 it.
3526
3527 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3528 so that we aren't warned about unused symbols.
3529
3530 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3531
3532 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3533
3534 * xfns.c (x_real_positions): Mark locals as initialized.
3535
3536 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3537
3538 * xterm.c: Fix problems found by static analysis with other toolkits.
3539 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3540 (x_dispatch_event): Declare static if USE_GTK, and
3541 define if USE_GTK || USE_X_TOOLKIT.
3542 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3543 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3544 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3545 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3546
3547 * xmenu.c (menu_help_callback): Pointer type fixes.
3548 Use const pointers when pointing at readonly data. Avoid pointer
3549 signedness clashes.
3550 (FALSE): Remove unused macro.
3551 (update_frame_menubar): Remove unused decl.
3552
3553 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3554
3555 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3556 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3557 (single_menu_item): Rename local to avoid shadowing.
3558
3559 * keyboard.c (make_lispy_event): Remove unused local var.
3560
3561 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3562 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3563
3564 * bitmaps: Change bitmaps from unsigned char back to the X11
3565 compatible char. Avoid the old compiler warnings about
3566 out-of-range initializers by using, for example, '\xab' rather
3567 than 0xab.
3568
3569 * xgselect.c (xgselect_initialize): Check vs interface
3570 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3571
3572 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3573
3574 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3575 to read-only memory.
3576
3577 * fns.c (vector): Remove; this old hack is no longer needed.
3578
3579 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3580 Remove unused var.
3581 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3582
3583 * xrdb.c (x_load_resources): Omit unused local.
3584
3585 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3586 (x_window): Rename locals to avoid shadowing.
3587 (USG): Use the kludged USG macro, to pacify gcc.
3588
3589 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3590 (x_term_init): Remove local to avoid shadowing.
3591
3592 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3593
3594 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3595 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3596
3597 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3598
3599 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3600
3601 Fix regex.c, syntax.c and friends for buffers > 2GB.
3602 * syntax.h (struct gl_state_s): Declare character position members
3603 EMACS_INT.
3604
3605 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3606
3607 * textprop.c (verify_interval_modification, interval_of):
3608 Declare arguments EMACS_INT.
3609
3610 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3611 EMACS_INT.
3612
3613 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3614
3615 * indent.c (Fvertical_motion): Local variable it_start is now
3616 EMACS_INT.
3617
3618 * regex.c (re_match, re_match_2, re_match_2_internal)
3619 (bcmp_translate, regcomp, regexec, print_double_string)
3620 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3621 (re_compile_pattern, re_exec): Declare arguments and local
3622 variables `size_t' and `ssize_t' and return values `regoff_t', as
3623 appropriate.
3624 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3625 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3626 <compile_stack_type>: `size' and `avail' are now `size_t'.
3627
3628 * regex.h <regoff_t>: Use ssize_t, not int.
3629 (re_search, re_search_2, re_match, re_match_2): Arguments that
3630 specify buffer/string position and length are now ssize_t and
3631 size_t. Return type is regoff_t.
3632
3633 2011-04-16 Ben Key <bkey76@gmail.com>
3634
3635 * nsfont.m: Fixed bugs in ns_get_family and
3636 ns_descriptor_to_entity that were caused by using free to
3637 deallocate memory blocks that were allocated by xmalloc (via
3638 xstrdup). This caused Emacs to crash when compiled with
3639 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3640 --enable-checking=xmallocoverrun). xfree is now used to
3641 deallocate these memory blocks.
3642
3643 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3644
3645 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3646
3647 emacs_write: Accept and return EMACS_INT for sizes.
3648 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3649 et seq.
3650 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3651 Accept and return EMACS_INT.
3652 (emacs_gnutls_write): Return the number of bytes written on
3653 partial writes.
3654 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3655 (emacs_read, emacs_write): Remove check for negative size, as the
3656 Emacs source code has been audited now.
3657 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3658 (emacs_read, emacs_write): Use it.
3659 * process.c (send_process): Adjust to the new signatures of
3660 emacs_write and emacs_gnutls_write. Do not attempt to store
3661 a byte offset into an 'int'; it might overflow.
3662 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3663
3664 * sound.c: Don't assume sizes fit in 'int'.
3665 (struct sound_device.period_size, alsa_period_size):
3666 Return EMACS_INT, not int.
3667 (struct sound_device.write, vox_write, alsa_write):
3668 Accept EMACS_INT, not int.
3669 (wav_play, au_play): Use EMACS_INT to store sizes and to
3670 record read return values.
3671
3672 2011-04-15 Ben Key <bkey76@gmail.com>
3673
3674 * keyboard.c (Qundefined): Don't declare static since it is used
3675 in nsfns.m.
3676 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3677 static since they are used in nsfont.m.
3678
3679 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3680
3681 * process.c (Qprocessp): Don't declare static.
3682 * lisp.h (Qprocessp): Declare again.
3683
3684 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3685
3686 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3687
3688 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 Improve C-level modularity by making more things 'static'.
3691
3692 Don't publish debugger-only interfaces to other modules.
3693 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3694 (verify_bytepos, count_markers): Move decls to the only modules
3695 that need them.
3696 * region-cache.h (pp_cache): Likewise.
3697 * window.h (check_all_windows): Likewise.
3698 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3699
3700 * sysdep.c (croak): Now static, if
3701 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3702 * syssignal.h (croak): Declare only if not static.
3703
3704 * alloc.c (refill_memory_reserve): Now static if
3705 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3706 * lisp.h (refill_memory_reserve): Declare only if not static.
3707
3708 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3709 Define only if USE_LUCID.
3710
3711 * xrdb.c (x_customization_string, x_rm_string): Now static.
3712
3713 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3714 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3715
3716 * xdisp.c (draw_row_with_mouse_face): Now static.
3717 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3718
3719 * window.h (check_all_windows): Mark externally visible.
3720
3721 * window.c (window_deletion_count): Now static.
3722
3723 * undo.c: Make symbols static if they're not exported.
3724 (last_undo_buffer, last_boundary_position, pending_boundary):
3725 Now static.
3726
3727 * textprop.c (interval_insert_behind_hooks): Now static.
3728 (interval_insert_in_front_hooks): Likewise.
3729
3730 * term.c: Make symbols static if they're not exported.
3731 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3732 (max_frame_lines, tty_set_terminal_modes):
3733 (tty_reset_terminal_modes, tty_turn_off_highlight):
3734 (get_tty_terminal): Now static.
3735 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3736 * termhooks.h (term_mouse_moveto): Do not declare if
3737 HAVE_WINDOW_SYSTEM.
3738 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3739 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3740
3741 * sysdep.c: Make symbols static if they're not exported.
3742 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3743 Now static.
3744 (sigprocmask_set, full_mask): Remove; unused.
3745 (wait_debugging): Mark as visible.
3746 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3747 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3748
3749 * syntax.c (syntax_temp): Define only if !__GNUC__.
3750
3751 * sound.c (current_sound_device, current_sound): Now static.
3752
3753 * search.c (searchbufs, searchbuf_head): Now static.
3754
3755 * scroll.c (scroll_cost): Remove; unused.
3756 * dispextern.h (scroll_cost): Remove decl.
3757
3758 * region-cache.h (pp_cache): Mark as externally visible.
3759
3760 * process.c: Make symbols static if they're not exported.
3761 (process_tick, update_tick, create_process, chan_process):
3762 (Vprocess_alist, proc_buffered_char, datagram_access):
3763 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3764 (deactivate_process): Mark defn as static, as well as decl.
3765 * lisp.h (create_process): Remove decl.
3766 * process.h (chan_process, Vprocess_alist): Remove decls.
3767
3768 * print.c: Make symbols static if they're not exported.
3769 (print_depth, new_backquote_output, being_printed, print_buffer):
3770 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3771 (print_interval, print_number_index, initial_stderr_stream):
3772 Now static.
3773 * lisp.h (Fprinc): Remove decl.
3774 (debug_output_compilation_hack): Mark as externally visible.
3775
3776 * sysdep.c (croak): Move decl from here to syssignal.h.
3777 * syssignal.h (croak): Put it here, so the API can be checked when
3778 'croak' is called from dissociate_if_controlling_tty.
3779
3780 * minibuf.c: Make symbols static if they're not exported.
3781 (minibuf_save_list, choose_minibuf_frame): Now static.
3782 * lisp.h (choose_minibuf_frame): Remove decl.
3783
3784 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3785
3786 * lread.c: Make symbols static if they're not exported.
3787 (read_objects, initial_obarray, oblookup_last_bucket_number):
3788 Now static.
3789 (make_symbol): Remove; unused.
3790 * lisp.h (initial_obarray, make_symbol): Remove decls.
3791
3792 * keyboard.c: Make symbols static if they're not exported.
3793 (single_kboard, recent_keys_index, total_keys, recent_keys):
3794 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3795 (this_single_command_key_start, echoing, last_auto_save):
3796 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3797 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3798 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3799 (Vlispy_mouse_stem, double_click_count):
3800 Now static.
3801 (force_auto_save_soon): Define only if SIGDANGER.
3802 (ignore_mouse_drag_p): Now static if
3803 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3804 (print_help): Remove; unused.
3805 (stop_character, last_timer_event): Mark as externally visible.
3806 * keyboard.h (ignore_mouse_drag_p): Declare only if
3807 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3808 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3809 * lisp.h (echoing): Remove decl.
3810 (force_auto_save_soon): Declare only if SIGDANGER.
3811 * xdisp.c (redisplay_window): Simplify code, to make it more
3812 obvious that ignore_mouse_drag_p is not accessed if !defined
3813 USE_GTK && !defined HAVE_NS.
3814
3815 * intervals.c: Make symbols static if they're not exported.
3816 (merge_properties_sticky, merge_interval_right, delete_interval):
3817 Now static.
3818 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3819
3820 * insdel.c: Make symbols static if they're not exported.
3821 However, leave prepare_to_modify_buffer alone. It's never
3822 called from outside this function, but that appears to be a bug.
3823 (combine_after_change_list, combine_after_change_buffer):
3824 (adjust_after_replace, signal_before_change): Now static.
3825 (adjust_after_replace_noundo): Remove; unused.
3826 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3827 (signal_before_change): Remove decls.
3828
3829 * indent.c (val_compute_motion, val_vmotion): Now static.
3830
3831 * image.c: Make symbols static if they're not exported.
3832 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3833 if USE_GTK.
3834 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3835 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3836
3837 * fringe.c (standard_bitmaps): Now static.
3838 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3839
3840 * frame.c: Make symbols static if they're not exported.
3841 (x_report_frame_params, make_terminal_frame): Now static.
3842 (get_frame_param): Now static, unless HAVE_NS.
3843 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3844 (x_get_resource_string): Remove; not used.
3845 * frame.h (make_terminal_frame, x_report_frame_params):
3846 (x_get_resource_string); Remove decls.
3847 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3848 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3849
3850 * font.c, fontset.c: Make symbols static if they're not exported.
3851 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3852 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3853 * font.c (font_close_object): Now static.
3854 * font.h (font_close_object): Remove.
3855 * fontset.c (FONTSET_OBJLIST): Remove.
3856 (free_realized_fontset) #if-0 the body, which does nothing.
3857 (face_suitable_for_char_p): #if-0, as it's never called.
3858 * fontset.h (face_suitable_for_char_p): Remove decl.
3859 * xfaces.c (face_at_string_position):
3860 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3861 since 0 is always ASCII.
3862
3863 * fns.c (weak_hash_tables): Now static.
3864
3865 * fileio.c: Make symbols static if they're not exported.
3866 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3867 (Vwrite_region_annotation_buffers): Now static.
3868
3869 * eval.c: Make symbols static if they're not exported.
3870 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3871 * lisp.h (backtrace_list): Remove decl.
3872
3873 * emacs.c: Make symbols static if they're not exported.
3874 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3875 (fatal_error_code, fatal_error_signal_hook, standard_args):
3876 Now static.
3877 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3878 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3879 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3880 * lisp.h (fatal_error_signal_hook): Remove decl.
3881 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3882
3883 * editfns.c: Move a (normally-unused) function to its only use.
3884 * editfns.c, lisp.h (get_operating_system_release): Remove.
3885 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3886 worth the hassle of breaking this out.
3887
3888 * xterm.c: Make symbols static if they're not exported.
3889 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3890 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3891 (x_destroy_window, x_delete_display):
3892 Now static.
3893 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3894 (x_mouse_leave): Remove; unused.
3895 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3896 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3897 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3898 Remove decls.
3899 (x_mouse_leave): Declare only if WINDOWSNT.
3900 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3901 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3902 USE_X_TOOLKIT.
3903
3904 * ftxfont.c: Make symbols static if they're not exported.
3905 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3906 HAVE_FREETYPE.
3907 * font.h (ftxfont_driver): Likewise.
3908
3909 * xfns.c: Make symbols static if they're not exported.
3910 (x_last_font_name, x_display_info_for_name):
3911 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3912 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3913 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3914 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3915 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3916 (last_show_tip_args): Now static.
3917 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3918 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3919 (x_screen_planes): Remove; unused.
3920 * dispextern.h (x_screen_planes): Remove decl.
3921
3922 * dispnew.c: Make symbols static if they're not exported.
3923 * dispextern.h (redraw_garbaged_frames, scrolling):
3924 (increment_row_positions): Remove.
3925 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3926 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3927 Now static.
3928 (redraw_garbaged_frames): Remove; unused.
3929
3930 * xfaces.c: Make symbols static if they're not exported.
3931 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3932 Remove decls.
3933 * xterm.h (defined_color): Remove decls.
3934 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3935 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3936 (menu_face_changed_default, defined_color, free_realized_face):
3937 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3938 (ascii_face_of_lisp_face): Remove; unused.
3939
3940 * xdisp.c: Make symbols static if they're not exported.
3941 * dispextern.h (scratch_glyph_row, window_box_edges):
3942 (glyph_to_pixel_coords, set_cursor_from_row):
3943 (get_next_display_element, set_iterator_to_next):
3944 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3945 (show_mouse_face): Remove decls
3946 * frame.h (message_buf_print): Likewise.
3947 * lisp.h (pop_message, set_message, check_point_in_composition):
3948 Likewise.
3949 * xterm.h (set_vertical_scroll_bar): Likewise.
3950 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3951 (message_buf_print, scratch_glyph_row, displayed_buffer):
3952 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3953 (get_next_display_element, show_mouse_face, window_box_edges):
3954 (frame_to_window_pixel_xy, check_point_in_composition):
3955 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3956 (glyph_to_pixel_coords): Remove; unused.
3957
3958 * dired.c (file_name_completion): Now static.
3959
3960 * dbusbind.c (xd_in_read_queued_messages): Now static.
3961
3962 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3963 * data.c (circular_list_error): Remove.
3964
3965 * commands.h (last_point_position, last_point_position_buffer):
3966 (last_point_position_window): Remove decls.
3967 * keyboard.c: Make these variables static.
3968
3969 * coding.h (coding, code_convert_region, encode_coding_gap):
3970 Remove decls.
3971 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3972 (iso_code_class, detect_coding, code_convert_region): Now static.
3973 (encode_coding_gap): Remove; unused.
3974
3975 * chartab.c (chartab_chars, chartab_bits): Now static.
3976
3977 * charset.h (charset_iso_8859_1): Remove decl.
3978 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3979 Now static.
3980
3981 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3982 * ccl.c (Vccl_program_table): Now static.
3983 (check_ccl_update): Remove; unused.
3984
3985 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3986 * category.h: ... from here.
3987 * category.c (check_category_table, set_category_set): Now static.
3988
3989 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3990 * lisp.h: Remove these decls.
3991
3992 * buffer.c (buffer_count): Remove unused var.
3993
3994 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3995 so that it's not optimized away.
3996 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3997 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3998 exported only to the debugger.
3999
4000 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4001 * atimer.h (run_all_atimers): Remove; not exported.
4002
4003 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4004 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4005 was inaccessible from Lisp.
4006 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4007 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4008
4009 alloc.c: Import and export fewer symbols, and remove unused items.
4010 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4011 is defined.
4012 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4013 it's not optimized away by whole-program optimization.
4014 (message_enable_multibyte, free_misc): Remove.
4015 (catchlist, handlerlist, mark_backtrace):
4016 Declare only if BYTE_MARK_STACK.
4017 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4018 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4019 (message_enable_multibyte): Remove decl.
4020 (free_misc, interval_free_list, float_block, float_block_index):
4021 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4022 (cons_free_list, last_marked_index):
4023 Now static.
4024 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4025 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4026 (mark_backtrace): Define only if BYTE_MARK_STACK.
4027 * xdisp.c (message_enable_multibyte): Now static.
4028
4029 Declare Lisp_Object Q* variables to be 'static' if not exported.
4030 This makes it easier for human readers (and static analyzers)
4031 to see whether these variables are used from other modules.
4032 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4033 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4034 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4035 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4036 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4037 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4038 * xmenu.c, xselect.c:
4039 Declare Q* vars static if they are not used in other modules.
4040 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4041 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4042 Remove decls of unexported vars.
4043 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4044
4045 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4046
4047 Make Emacs functions such as Fatom 'static' by default.
4048 This makes it easier for human readers (and static analyzers)
4049 to see whether these functions can be called from other modules.
4050 DEFUN now defines a static function. To make the function external
4051 so that it can be used in other C modules, use the new macro DEFUE.
4052 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4053 (Finit_image_library):
4054 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4055 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4056 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4057 Remove decls, since these functions are now static.
4058 (Funintern, Fget_internal_run_time): New decls, since these functions
4059 were already external.
4060
4061 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4062 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4063 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4064 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4065 * keyboard.c, keymap.c, lread.c:
4066 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4067 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4068 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4069 Mark functions with DEFUE instead of DEFUN,
4070 if they are used in other modules.
4071 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4072 decls for now-static functions.
4073 * buffer.h (Fdelete_overlay): Remove decl.
4074 * callproc.c (Fgetenv_internal): Mark as internal.
4075 * composite.c (Fremove_list_of_text_properties): Remove decl.
4076 (Fcomposition_get_gstring): New forward static decl.
4077 * composite.h (Fcomposite_get_gstring): Remove decl.
4078 * dired.c (Ffile_attributes): New forward static decl.
4079 * doc.c (Fdocumntation_property): New forward static decl.
4080 * eval.c (Ffetch_bytecode): New forward static decl.
4081 (Funintern): Remove extern decl; now in .h file where it belongs.
4082 * fileio.c (Fmake_symbolic_link): New forward static decl.
4083 * image.c (Finit_image_library): New forward static decl.
4084 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4085 * intervals.h (Fprevious_property_change):
4086 (Fremove_list_of_text_properties): Remove decls.
4087 * keyboard.c (Fthis_command_keys): Remove decl.
4088 (Fcommand_execute): New forward static decl.
4089 * keymap.c (Flookup_key): New forward static decl.
4090 (Fcopy_keymap): Now static.
4091 * keymap.h (Flookup_key): Remove decl.
4092 * process.c (Fget_process): New forward static decl.
4093 (Fprocess_datagram_address): Mark as internal.
4094 * syntax.c (Fsyntax_table_p): New forward static decl.
4095 (skip_chars): Remove duplicate decl.
4096 * textprop.c (Fprevious_property_change): New forward static decl.
4097 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4098 Now internal.
4099 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4100 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4101
4102 * editfns.c (Fformat): Remove unreachable code.
4103
4104 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4105
4106 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4107 change. (Bug#8496)
4108
4109 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4110
4111 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4112 when at ZV. (Bug#8487)
4113
4114 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4117 (Bug#8437)
4118 * keyboard.c (parse_tool_bar_item): Likewise.
4119 * sound.c (sound_cleanup, alsa_close): Likewise.
4120 * termcap.c (tgetent): Likewise.
4121 * xfns.c (x_default_font_parameter): Likewise.
4122 * xsettings.c (read_and_apply_settings): Likewise.
4123
4124 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4125 (overrun_check_free): Protoize.
4126
4127 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4128
4129 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4130 since callers should never pass a negative size.
4131 Change the signature to match that of plain 'read' and 'write'; see
4132 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4133 * lisp.h: Update prototypes of emacs_write and emacs_read.
4134
4135 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4136
4137 * xdisp.c (redisplay_window): Don't try to determine the character
4138 position of the scroll margin if the window start point w->startp
4139 is outside the buffer's accessible region. (Bug#8468)
4140
4141 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4142
4143 Fix write-region and its subroutines for buffers > 2GB.
4144 * fileio.c (a_write, e_write): Modify declaration of arguments and
4145 local variables to support buffers larger than 2GB.
4146 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4147
4148 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4149 argument, local variables, and return value.
4150
4151 * lisp.h: Update prototypes of emacs_write and emacs_read.
4152
4153 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4154
4155 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4156
4157 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4158
4159 Fix more problems found by GCC 4.6.0's static checks.
4160
4161 * xdisp.c (vmessage): Use a better test for character truncation.
4162
4163 * charset.c (load_charset_map): <, not <=, for optimization,
4164 and to avoid potential problems with integer overflow.
4165 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4166 * casetab.c (set_identity, shuffle): Likewise.
4167 * editfns.c (Fformat): Likewise.
4168 * syntax.c (skip_chars): Likewise.
4169
4170 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4171 This also lets GCC 4.6.0 generate slightly better loop code.
4172
4173 * callint.c (Fcall_interactively): <, not <=, for optimization.
4174 (Fcall_interactively): Count the number of arguments produced,
4175 not the number of arguments given. This is simpler and lets GCC
4176 4.6.0 generate slightly better code.
4177
4178 * ftfont.c: Distingish more carefully between FcChar8 and char.
4179 The previous code passed unsigned char * to a functions like
4180 strlen and xstrcasecmp that expect char *, which does not
4181 conform to the C standard.
4182 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4183 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4184 char * when the C standard requires it.
4185
4186 * keyboard.c (read_char): Remove unused var.
4187
4188 * eval.c: Port to Windows vsnprintf (Bug#8435).
4189 Include <limits.h>.
4190 (SIZE_MAX): Define if the headers do not.
4191 (verror): Do not give up if vsnprintf returns a negative count.
4192 Instead, grow the buffer. This ports to Windows vsnprintf, which
4193 does not conform to C99. Problem reported by Eli Zaretskii.
4194 Also, simplify the allocation scheme, by avoiding the need for
4195 calling realloc, and removing the ALLOCATED variable.
4196
4197 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4198
4199 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4200 But keep the doprint source code for now, as we might revamp it
4201 and use it again (Bug#8435).
4202 * lisp.h (doprnt): Remove.
4203 * Makefile.in (base_obj): Remove doprnt.o.
4204 * deps.mk (doprnt.o): Remove.
4205
4206 error: Print 32- and 64-bit integers portably (Bug#8435).
4207 Without this change, on typical 64-bit hosts error ("...%d...", N)
4208 was used to print both 32- and 64-bit integers N, which relied on
4209 undefined behavior.
4210 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4211 New macro.
4212 * lisp.h (error, verror): Mark as printf-like functions.
4213 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4214 Report overflow in size calculations when allocating printf buffer.
4215 Do not truncate output string at its first null byte.
4216 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4217 Truncate the output at a character boundary, since vsnprintf does not
4218 do that.
4219 * charset.c (check_iso_charset_parameter): Convert internal
4220 character to string before calling 'error', since %c now has the
4221 printf meaning.
4222 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4223 overflow when computing char to be passed to 'error'. Do not
4224 pass Lisp_Object to 'error'; pass the integer instead.
4225 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4226 formatted with plain %d.
4227
4228 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4229
4230 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4231
4232 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4233
4234 * xterm.c (x_catch_errors): Remove duplicate declaration.
4235
4236 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4237
4238 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4239
4240 2011-04-10 Jim Meyering <meyering@redhat.com>
4241
4242 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4243 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4244 return ssize_t not "int", and use size_t as the buffer length.
4245 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4246 * gnutls.h: Update declarations.
4247 * process.c (read_process_output): Use ssize_t, to match.
4248 (send_process): Likewise.
4249
4250 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4251
4252 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4253
4254 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4255
4256 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4257 Use unsigned char, to match FcChar8 type definition.
4258
4259 * xterm.c (handle_one_xevent):
4260 * xmenu.c (create_and_show_popup_menu):
4261 * xselect.c (x_decline_selection_request)
4262 (x_reply_selection_request): Avoid type-punned deref of X events.
4263
4264 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4265
4266 Fix some uses of `int' instead of EMACS_INT.
4267 * search.c (string_match_1, fast_string_match)
4268 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4269 (scan_buffer, find_next_newline_no_quit)
4270 (find_before_next_newline, search_command, Freplace_match)
4271 (Fmatch_data): Make some `int' variables be EMACS_INT.
4272
4273 * xdisp.c (display_count_lines): 3rd argument and return value now
4274 EMACS_INT. All callers changed.
4275 (pint2hrstr): Last argument is now EMACS_INT.
4276
4277 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4278 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4279 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4280 (decode_coding_utf_16, decode_coding_emacs_mule)
4281 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4282 (decode_coding_ccl, decode_coding_charset)
4283 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4284 (decode_coding_iso_2022, decode_coding_emacs_mule)
4285 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4286 <char_offset, last_offset>: Declare EMACS_INT.
4287 (encode_coding_utf_8, encode_coding_utf_16)
4288 (encode_coding_emacs_mule, encode_invocation_designation)
4289 (encode_designation_at_bol, encode_coding_iso_2022)
4290 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4291 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4292 Declare EMACS_INT.
4293 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4294 (encode_invocation_designation): Last argument P_NCHARS is now
4295 EMACS_INT.
4296 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4297 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4298
4299 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4300 All users changed.
4301
4302 * ccl.c (Fccl_execute_on_string): Declare some variables
4303 EMACS_INT.
4304
4305 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4306
4307 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4308
4309 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4310
4311 * process.c (Fformat_network_address): Doc fix.
4312
4313 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4314
4315 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4316
4317 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4318
4319 * keyboard.c (read_char): Call Lisp function help-form-show,
4320 instead of using internal_with_output_to_temp_buffer.
4321 (Qhelp_form_show): New var.
4322 (syms_of_keyboard): Use DEFSYM macro.
4323
4324 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4325
4326 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4327
4328 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4329
4330 * process.c (Flist_processes): Remove to Lisp.
4331 (list_processes_1): Delete.
4332
4333 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4334
4335 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4336
4337 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4338
4339 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4340
4341 Fix more problems found by GCC 4.6.0's static checks.
4342
4343 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4344
4345 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4346
4347 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4348
4349 * xdisp.c (vmessage): Mark as a printf-like function.
4350
4351 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4352
4353 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4354
4355 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4356 printf-like functions.
4357 (tiff_load): Add casts to remove these marks before passing them
4358 to system-supplied API.
4359
4360 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4361
4362 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4363 This avoids several warnings with gcc -Wstrict-overflow.
4364 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4365 directly, rather than having caller test rule sign. This avoids
4366 some unnecessary tests.
4367 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4368 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4369 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4370
4371 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4372 (xfont_open): Avoid unnecessary tests.
4373
4374 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4375
4376 * composite.h, composite.c (composition_gstring_put_cache):
4377 Use EMACS_INT, not int, for length.
4378
4379 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4380 breaking out part of COMPOSITION_DECODE_RULE.
4381 (COMPOSITION_DECODE_RULE): Use it.
4382 * composite.c (get_composition_id): Remove unused local vars,
4383 by using the new macro.
4384
4385 * textprop.c (set_text_properties_1): Change while to do-while,
4386 since the condition is always true at first.
4387
4388 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4389 (interval_deletion_adjustment): Return unsigned value.
4390 All uses changed.
4391
4392 * process.c (list_processes_1, create_pty, read_process_output):
4393 (exec_sentinel): Remove vars that were set but not used.
4394 (create_pty): Remove unnecessary "volatile"s.
4395 (Fnetwork_interface_info): Avoid possibility of int overflow.
4396 (read_process_output): Do adaptive read buffering even if carryover.
4397 (read_process_output): Simplify nbytes computation if buffered.
4398
4399 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4400
4401 * syntax.c (scan_words): Remove var that was set but not used.
4402 (update_syntax_table): Use unsigned instead of int.
4403
4404 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4405 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4406 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4407
4408 * print.c (print_error_message): Avoid int overflow.
4409
4410 * font.c (font_list_entities): Redo for clarity,
4411 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4412
4413 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4414 (font_score): Avoid potential overflow in diff calculation.
4415
4416 * fns.c (substring_both): Remove var that is set but not used.
4417 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4418
4419 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4420
4421 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4422 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4423 can always succeed if overflow has undefined behavior.
4424
4425 * search.c (boyer_moore, wordify): Remove vars set but not used.
4426 (wordify): Omit three unnecessary tests.
4427
4428 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4429 All callers changed. This avoids the need for an unused var.
4430
4431 * casefiddle.c (casify_region): Remove var that is set but not used.
4432
4433 * dired.c (file_name_completion): Remove var that is set but not used.
4434
4435 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4436
4437 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4438 (Finsert_file_contents): Remove unnecessary code checking fd.
4439
4440 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4441 Check for integer overflow on size calculations.
4442
4443 * buffer.c (Fprevious_overlay_change): Remove var that is set
4444 but not used.
4445
4446 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4447 Remove vars that are set but not used.
4448 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4449 (timer_check_2): Mark vars as initialized.
4450
4451 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4452
4453 * image.c (lookup_image): Remove var that is set but not used.
4454 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4455
4456 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4457 that are set but not used.
4458
4459 * xfns.c (make_invisible_cursor): Don't return garbage
4460 if XCreateBitmapFromData fails (Bug#8410).
4461
4462 * xselect.c (x_get_local_selection, x_handle_property_notify):
4463 Remove vars that are set but not used.
4464
4465 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4466 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4467
4468 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4469 Remove var that is set but not used.
4470 (scroll_bar_windows_size): Now size_t, not int.
4471 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4472 Check for overflow.
4473
4474 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4475 (map_tty_color) [!defined MSDOS]: Likewise.
4476
4477 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4478
4479 * coding.c: Remove vars that are set but not used.
4480 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4481 All callers changed.
4482 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4483 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4484 (decode_coding_charset): Remove vars that are set but not used.
4485
4486 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4487 that is set but not used.
4488
4489 * print.c (print_object): Remove var that is set but not used.
4490
4491 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4492 The gnulib version avoids calling malloc in the usual case,
4493 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4494 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4495 * filelock.c (current_lock_owner): Likewise.
4496 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4497 * sysdep.c: Include allocator.h, careadlinkat.h.
4498 (emacs_no_realloc_allocator): New static constant.
4499 (emacs_readlink): New function.
4500 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4501 ../lib/careadlinkat.h.
4502
4503 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4504
4505 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4506 first non-nil return value).
4507
4508 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4509
4510 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4511 if not defined (Bug#8403).
4512
4513 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4514
4515 * xdisp.c (display_count_lines): Remove parameter `start',
4516 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4517 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4518 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4519 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4520 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4521 and thereabouts. All callers changed.
4522 (get_per_char_metric): Remove parameter `f', unused since
4523 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4524
4525 2011-04-02 Jim Meyering <meyering@redhat.com>
4526
4527 do not dereference NULL upon failed strdup
4528 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4529 (ns_get_family): Likewise.
4530
4531 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4532
4533 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4534
4535 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4536
4537 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4538 later (Bug#8403).
4539
4540 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4541
4542 Add lexical binding.
4543
4544 * window.c (Ftemp_output_buffer_show): New fun.
4545 (Fsave_window_excursion):
4546 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4547
4548 * lread.c (lisp_file_lexically_bound_p): New function.
4549 (Fload): Bind Qlexical_binding.
4550 (readevalloop): Remove `evalfun' arg.
4551 Bind Qinternal_interpreter_environment.
4552 (Feval_buffer): Bind Qlexical_binding.
4553 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4554 Mark as dynamic.
4555 (syms_of_lread): Declare `lexical-binding'.
4556
4557 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4558
4559 * keyboard.c (eval_dyn): New fun.
4560 (menu_item_eval_property): Use it.
4561
4562 * image.c (parse_image_spec): Use Ffunctionp.
4563
4564 * fns.c (concat, mapcar1): Accept byte-code-functions.
4565
4566 * eval.c (Fsetq): Handle lexical vars.
4567 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4568 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4569 (FletX, Flet): Obey lexical binding.
4570 (Fcommandp): Handle closures.
4571 (Feval): New `lexical' arg.
4572 (eval_sub): New function extracted from Feval. Use it almost
4573 everywhere where Feval was used. Look up vars in lexical env.
4574 Handle closures.
4575 (Ffunctionp): Move from subr.el.
4576 (Ffuncall): Handle closures.
4577 (apply_lambda): Remove `eval_flags'.
4578 (funcall_lambda): Handle closures and new byte-code-functions.
4579 (Fspecial_variable_p): New function.
4580 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4581 but without exporting it to Lisp.
4582
4583 * doc.c (Fdocumentation, store_function_docstring):
4584 * data.c (Finteractive_form): Handle closures.
4585
4586 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4587 interactive spec.
4588
4589 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4590 New byte-codes.
4591 (exec_byte_code): New function extracted from Fbyte_code to handle new
4592 calling convention for byte-code-functions. Add new byte-codes.
4593
4594 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4595
4596 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4597
4598 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4599
4600 * xdisp.c (redisplay_internal): Fix prototype.
4601
4602 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4603
4604 * xdisp.c (SCROLL_LIMIT): New macro.
4605 (try_scrolling): Use it when setting scroll_limit.
4606 Limit scrolling to 100 screen lines.
4607 (redisplay_window): Even when falling back on "recentering",
4608 position point in the window according to scroll-conservatively,
4609 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4610
4611 (try_scrolling): When point is above the window, allow searching
4612 as far as scroll_max, or one screenful, to compute vertical
4613 distance from PT to the scroll margin position. This prevents
4614 try_scrolling from unnecessarily failing when
4615 scroll-conservatively is set to a value slightly larger than the
4616 window height. Clean up the case of PT below the margin at bottom
4617 of window: scroll_max can no longer be INT_MAX. When aggressive
4618 scrolling is in use, don't let point enter the opposite scroll
4619 margin as result of the scroll.
4620 (syms_of_xdisp) <scroll-conservatively>: Document the
4621 threshold of 100 lines for never-recentering scrolling.
4622
4623 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4624
4625 * dispextern.h (move_it_by_lines):
4626 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4627 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4628 (message_log_check_duplicate): Remove parameters `prev_bol' and
4629 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4630 (redisplay_internal): Remove parameter `preserve_echo_area',
4631 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4632
4633 * indent.c (Fvertical_motion):
4634 * window.c (window_scroll_pixel_based, Frecenter):
4635 Don't pass `need_y_p' to `move_it_by_lines'.
4636
4637 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4638
4639 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4640 steal a few bits to be more compact.
4641 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4642 Remove unneeded casts.
4643
4644 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4645
4646 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4647
4648 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4649 binding" message (bug#7967).
4650
4651 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4652
4653 Fix more problems found by GCC 4.6.0's static checks.
4654
4655 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4656 Remove unused local var.
4657
4658 * editfns.c (Fmessage_box): Remove unused local var.
4659
4660 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4661 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4662 Omit unused local vars.
4663 * window.c (shrink_windows): Omit unused local var.
4664 * menu.c (digest_single_submenu): Omit unused local var.
4665 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4666 Omit unused local var.
4667
4668 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4669 Don't assume string length fits in int.
4670 (keyremap_step, read_key_sequence): Use size_t for sizes.
4671 (read_key_sequence): Don't check last_real_key_start redundantly.
4672
4673 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4674 instead of alloca (Bug#8344).
4675
4676 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4677 (Fbacktrace_frame): Don't assume nframes fits in int.
4678
4679 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4680
4681 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4682 concerns.
4683
4684 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4685
4686 * cm.c (calccost): Turn while-do into do-while, for clarity.
4687
4688 * keyboard.c (syms_of_keyboard): Use the same style as later
4689 in this function when indexing through an array. This also
4690 works around GCC bug 48267.
4691
4692 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4693
4694 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4695
4696 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4697 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4698
4699 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4700 This avoids undefined behavior on integer overflow, and is a bit
4701 more convenient anyway since it is compared to a size_t variable.
4702
4703 Variadic C functions now count arguments with size_t, not int.
4704 This avoids an unnecessary limitation on 64-bit machines, which
4705 caused (substring ...) to crash on large vectors (Bug#8344).
4706 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4707 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4708 All variadic functions and their callers changed accordingly.
4709 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4710 * data.c (arith_driver, float_arith_driver): Likewise.
4711 * editfns.c (general_insert_function): Likewise.
4712 * eval.c (struct backtrace.nargs, interactive_p)
4713 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4714 (funcall_lambda, mark_backtrace): Likewise.
4715 * fns.c (concat): Likewise.
4716 * frame.c (x_set_frame_parameters): Likewise.
4717 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4718 0 if not found, not -1. All callers changed.
4719
4720 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4721 (stack_copy_size): Now size_t, not int.
4722 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4723
4724 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4725
4726 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4727 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4728 All callers changed.
4729
4730 * lisp.h (multibyte_char_to_unibyte):
4731 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4732 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4733 * character.h (CHAR_TO_BYTE8):
4734 * cmds.c (internal_self_insert):
4735 * editfns.c (general_insert_function):
4736 * keymap.c (push_key_description):
4737 * search.c (Freplace_match):
4738 * xdisp.c (message_dolog, set_message_1): All callers changed.
4739
4740 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4741
4742 * keyboard.c (safe_run_hook_funcall): New function.
4743 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4744 don't set the hook to nil, but remove the offending function instead.
4745 (Qcommand_hook_internal): Remove, unused.
4746 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4747 Vcommand_hook_internal.
4748
4749 * eval.c (enum run_hooks_condition): Remove.
4750 (funcall_nil, funcall_not): New functions.
4751 (run_hook_with_args): Call each function through a `funcall' argument.
4752 Remove `cond' argument, now redundant.
4753 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4754 (Frun_hook_with_args_until_failure): Adjust accordingly.
4755 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4756
4757 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4758
4759 * dispextern.h (string_buffer_position): Remove declaration.
4760
4761 * print.c (strout): Remove parameter `multibyte', unused since
4762 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4763
4764 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4765 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4766 All callers changed.
4767
4768 * w32.c (_wsa_errlist): Use braces for struct initializers.
4769
4770 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4771 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4772 All callers changed.
4773 (string_buffer_position): Likewise. Also, make static (it's never
4774 used outside xdisp.c).
4775 (cursor_row_p): Remove parameter `w', unused since
4776 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4777 (decode_mode_spec): Remove parameter `precision', introduced during
4778 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4779 All callers changed.
4780
4781 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4782
4783 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4784
4785 2011-03-27 Anders Lindgren <andlind@gmail.com>
4786
4787 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4788 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4789 (ns_update_auto_hide_menu_bar): New functions.
4790 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4791 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4792 ns_constrain_all_frames.
4793 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4794 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4795
4796 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4797
4798 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4799
4800 2011-03-27 Glenn Morris <rgm@gnu.org>
4801
4802 * syssignal.h: Replace RETSIGTYPE with void.
4803 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4804 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4805 Replace SIGTYPE with void everywhere.
4806 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4807 * s/template.h (SIGTYPE): Remove commented out definition.
4808
4809 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4810
4811 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4812 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4813
4814 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4815
4816 * w32.c (read_unc_volume): Use parameter `henum', instead of
4817 global variable `wget_enum_handle'.
4818
4819 * keymap.c (describe_vector): Remove parameters `indices' and
4820 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4821 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4822
4823 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4824
4825 * keyboard.c (timer_check): Remove parameter `do_it_now',
4826 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4827 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4828 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4829
4830 * keyboard.c (read_char):
4831 * w32menu.c (w32_menu_display_help):
4832 * xmenu.c (show_help_event, menu_help_callback):
4833 Adjust calls to `show_help_echo'.
4834
4835 * gtkutil.c (xg_maybe_add_timer):
4836 * keyboard.c (readable_events):
4837 * process.c (wait_reading_process_output):
4838 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4839
4840 * insdel.c (adjust_markers_gap_motion):
4841 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4842 (gap_left, gap_right): Don't call it.
4843
4844 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4845
4846 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4847 incurred during fontification.
4848
4849 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4850
4851 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4852 (DEFVAR_PER_BUFFER): Don't pass it.
4853
4854 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4855 (scrolling_window): Don't pass it.
4856
4857 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4858
4859 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4860
4861 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4862 and `suffix'.
4863 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4864 of variables specific to SELinux and computation of `encoded_absname'.
4865
4866 * image.c (XPutPixel): Remove unused variable `height'.
4867
4868 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4869
4870 * unexw32.c (get_section_info): Remove unused variable `section'.
4871
4872 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4873 (system_process_attributes): Remove unused variable `sess'.
4874 (sys_read): Remove unused variable `err'.
4875
4876 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4877 (w32_wnd_proc): Remove unused variable `isdead'.
4878 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4879 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4880 (x_create_tip_frame): Remove unused variable `tem'.
4881
4882 * w32inevt.c (w32_console_read_socket):
4883 Remove unused variable `no_events'.
4884
4885 * w32term.c (x_draw_composite_glyph_string_foreground):
4886 Remove unused variable `width'.
4887
4888 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4889
4890 * w32term.c (x_set_glyph_string_clipping):
4891 Don't pass uninitialized region to CombineRgn.
4892
4893 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4896 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4897 (Fx_close_connection): Remove unused variable `i'.
4898
4899 * w32font.c (w32font_draw): Return number of glyphs.
4900 (w32font_open_internal): Remove unused variable `i'.
4901 (w32font_driver): Add missing initializer.
4902
4903 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4904 (fill_in_menu): Remove unused variable `items_added'.
4905
4906 * w32term.c (last_mouse_press_frame): Remove static global variable.
4907 (w32_clip_to_row): Remove unused variable `f'.
4908 (x_delete_terminal): Remove unused variable `i'.
4909
4910 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4911 (NOTHING): Remove unused static global variable.
4912 (uniscribe_check_otf): Remove unused variable `table'.
4913 (uniscribe_font_driver): Add missing initializers.
4914
4915 2011-03-23 Julien Danjou <julien@danjou.info>
4916
4917 * term.c (Fsuspend_tty, Fresume_tty):
4918 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4919 * window.c (temp_output_buffer_show):
4920 * insdel.c (signal_before_change):
4921 * frame.c (Fhandle_switch_frame):
4922 * fileio.c (Fdo_auto_save):
4923 * emacs.c (Fkill_emacs):
4924 * editfns.c (save_excursion_restore):
4925 * cmds.c (internal_self_insert):
4926 * callint.c (Fcall_interactively):
4927 * buffer.c (Fkill_all_local_variables):
4928 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4929 Use Frun_hooks.
4930 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4931 unconditionnaly since it does the check itself.
4932
4933 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 Fix more problems found by GCC 4.5.2's static checks.
4936
4937 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4938 the first time through the loop, since we know p0 < p1 then.
4939 This also avoids a gcc -Wstrict-overflow warning.
4940
4941 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4942 leading to a memory leak, possible in functions like
4943 load_charset_map_from_file that can allocate an unbounded number
4944 of objects (Bug#8318).
4945
4946 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4947 that could (at least in theory) be that large.
4948
4949 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4950 This is less likely to overflow, and avoids undefined behavior if
4951 overflow does occur. All callers changed. Use strtoul to scan
4952 for the unsigned long integer.
4953 (pint2hrstr): Simplify and tune code slightly.
4954 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4955
4956 * scroll.c (do_scrolling): Work around GCC bug 48228.
4957 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4958
4959 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4960 This also avoids a warning with gcc -Wstrict-overflow.
4961 (validate_x_resource_name): Simplify count usage.
4962 This also avoids a warning with gcc -Wstrict-overflow.
4963
4964 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4965 fail (Bug#8306).
4966
4967 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4968
4969 * process.c (Fmake_network_process): Use socklen_t, not int,
4970 where POSIX says socklen_t is required in portable programs.
4971 This fixes a porting bug on hosts like 64-bit HP-UX, where
4972 socklen_t is wider than int (Bug#8277).
4973 (Fmake_network_process, server_accept_connection):
4974 (wait_reading_process_output, read_process_output):
4975 Likewise.
4976
4977 * process.c: Rename or move locals to avoid shadowing.
4978 (list_processes_1, Fmake_network_process):
4979 (read_process_output_error_handler, exec_sentinel_error_handler):
4980 Rename or move locals.
4981 (Fmake_network_process): Define label "retry_connect" only if needed.
4982 (Fnetwork_interface_info): Fix pointer signedness.
4983 (process_send_signal): Add cast to avoid pointer signedness problem.
4984 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4985 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4986
4987 Make tparam.h and terminfo.c consistent.
4988 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4989 Include tparam.h instead, since it declares them.
4990 * cm.h (PC): Remove extern decl; tparam.h now does this.
4991 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4992 * terminfo.c: Include tparam.h, to check interfaces.
4993 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4994 (tparam): Adjust signature to match interface in tparam.h;
4995 this removes some undefined behavior. Check that outstring and len
4996 are zero, which they always are with Emacs.
4997 * tparam.h (PC, BC, UP): New extern decls.
4998
4999 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5000 (xftfont_open): Rename locals to avoid shadowing.
5001
5002 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5003 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5004 (OTF_TAG_SYM): Omit macro if not needed.
5005 (ftfont_list): Remove unused local.
5006 (get_adstyle_property, ftfont_pattern_entity):
5007 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5008 Rename locals to avoid shadowing.
5009
5010 * xfont.c (xfont_list_family): Mark var as initialized.
5011
5012 * xml.c (make_dom): Now static.
5013
5014 * composite.c (composition_compute_stop_pos): Rename local to
5015 avoid shadowing.
5016 (composition_reseat_it): Remove unused locals.
5017 (find_automatic_composition, composition_adjust_point): Likewise.
5018 (composition_update_it): Mark var as initialized.
5019 (find_automatic_composition): Mark vars as initialized,
5020 with a FIXME (Bug#8290).
5021
5022 character.h: Rename locals to avoid shadowing.
5023 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5024 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5025 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5026 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5027 to avoid shadowing.
5028
5029 * textprop.c (property_change_between_p): Remove; unused.
5030
5031 * intervals.c (interval_start_pos): Now static.
5032
5033 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5034
5035 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5036 Rename locals to avoid shadowing.
5037
5038 * sound.c (wav_play, au_play, Fplay_sound_internal):
5039 Fix pointer signedness.
5040 (alsa_choose_format): Remove unused local var.
5041 (wav_play): Initialize a variable to 0, to prevent undefined
5042 behavior (Bug#8278).
5043
5044 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5045
5046 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5047
5048 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5049 clobbering (Bug#8298).
5050 * sysdep.c (sys_subshell): Likewise.
5051 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5052
5053 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5054 This should get cleaned up, so that child_setup has the
5055 same signature on all platforms.
5056
5057 * callproc.c (call_process_cleanup): Now static.
5058 (relocate_fd): Rename locals to avoid shadowing.
5059
5060 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5061
5062 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5063 not to be necessary, and produces flickering.
5064
5065 2011-03-20 Glenn Morris <rgm@gnu.org>
5066
5067 * config.in: Remove file.
5068
5069 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5070
5071 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5072 are now in src/globals.h.
5073 (syms_of_minibuf): Remove spurious & from previous change.
5074
5075 2011-03-20 Leo <sdl.web@gmail.com>
5076
5077 * minibuf.c (completing-read-function): New variable.
5078 (completing-read-default): Rename from completing-read.
5079 (completing-read): Call completing-read-function.
5080
5081 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5082
5083 * xfaces.c (Fx_load_color_file):
5084 Read color file from absolute filename (bug#8250).
5085
5086 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5087
5088 * makefile.w32-in: Update dependencies.
5089
5090 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5091
5092 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5093
5094 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5095
5096 Fix more problems found by GCC 4.5.2's static checks.
5097
5098 * process.c (make_serial_process_unwind, send_process_trap):
5099 (sigchld_handler): Now static.
5100
5101 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5102 That way, the code declares only the vars that it needs.
5103 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5104 * s/cygwin.h (PTY_ITERATION): Likewise.
5105 * s/darwin.h (PTY_ITERATION): Likewise.
5106 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5107
5108 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5109 * process.c (allocate_pty): Don't declare stb unless it's needed.
5110
5111 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5112 (CONSTANTLIM): Remove; unused.
5113 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5114 Define only if needed.
5115
5116 * unexelf.c (unexec): Name an expression,
5117 to avoid gcc -Wbad-function-cast warning.
5118 Use a different way to cause a compilation error if anyone uses
5119 n rather than nn, a way that does not involve shadowing.
5120 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5121
5122 * deps.mk (unexalpha.o): Remove; unused.
5123
5124 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5125 * unexec.h: New file.
5126 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5127 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5128 Depend on unexec.h.
5129 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5130 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5131 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5132 Change as necessary to match prototype in unexec.h.
5133
5134 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5135 shadowing.
5136 (back_comment, skip_chars): Mark vars as initialized.
5137
5138 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5139 Rename locals to avoid shadowing.
5140
5141 * lread.c (read1): Rewrite so as not to use empty "else".
5142 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5143
5144 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5145
5146 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5147 warning when compiling print.c.
5148
5149 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5150 instead of using an uninitialized var.
5151 (font_sort_entities): Mark var as initialized.
5152
5153 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5154
5155 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5156 pointers to constants.
5157 (font_parse_fcname): Remove unused vars.
5158 (font_delete_unmatched): Now static.
5159 (font_get_spec): Remove; unused.
5160 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5161 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5162 Rename or move locals to avoid shadowing.
5163
5164 * fns.c (require_nesting_list, require_unwind): Now static.
5165 (Ffillarray): Rename locals to avoid shadowing.
5166
5167 * floatfns.c (domain_error2): Define only if needed.
5168 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5169
5170 * alloc.c (mark_backtrace): Move decl from here ...
5171 * lisp.h: ... to here, so that it can be checked.
5172
5173 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5174 (Fdefvar): Rewrite so as not to use empty "else".
5175 (lisp_indirect_variable): Name an expression,
5176 to avoid gcc -Wbad-function-cast warning.
5177 (Fdefvar): Rename locals to avoid shadowing.
5178
5179 * callint.c (quotify_arg, quotify_args): Now static.
5180 (Fcall_interactively): Rename locals to avoid shadowing.
5181 Use const pointer when appropriate.
5182
5183 * lisp.h (get_system_name, get_operating_system_release):
5184 Move decls here, to check interfaces.
5185 * process.c (get_operating_system_release): Move decl to lisp.h.
5186 * xrdb.c (get_system_name): Likewise.
5187 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5188 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5189 some of which prompt warnings from gcc -Wbad-function-cast.
5190 (Fformat_time_string, Fencode_time, Finsert_char):
5191 (Ftranslate_region_internal, Fformat):
5192 Rename or remove local vars to avoid shadowing.
5193 (Ftranslate_region_internal): Mark var as initialized.
5194
5195 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5196 avoid shadowing.
5197
5198 * lisp.h (eassert): Check that the argument compiles, even if
5199 ENABLE_CHECKING is not defined.
5200
5201 * data.c (Findirect_variable): Name an expression, to avoid
5202 gcc -Wbad-function-cast warning.
5203 (default_value, arithcompare, arith_driver, arith_error): Now static.
5204 (store_symval_forwarding): Rename local to avoid shadowing.
5205 (Fmake_variable_buffer_local, Fmake_local_variable):
5206 Mark variables as initialized.
5207 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5208
5209 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5210 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5211 Rename locals to avoid shadowing.
5212 (mark_stack): Move local variables into the #ifdef region where
5213 they're used.
5214 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5215 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5216 needed otherwise.
5217 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5218 (GC_STRING_CHARS): Remove; not used.
5219 (Fmemory_limit): Cast sbrk's returned value to char *.
5220
5221 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5222 avoids undefined behavior in theory.
5223
5224 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5225
5226 Use functions, not macros, for up- and down-casing (Bug#8254).
5227 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5228 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5229 to use the following functions instead of these macros.
5230 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5231 EMACS_INT, since callers assume the returned value fits in int.
5232 (upcase1): Likewise, for UPCASE_TABLE.
5233 (uppercasep, lowercasep, upcase): New static inline functions.
5234 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5235 the race-condition problem in the old DOWNCASE.
5236
5237 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5238 Rename locals to avoid shadowing.
5239 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5240 (regex_compile, re_search_2, re_match_2_internal):
5241 Remove unused local vars.
5242 (FREE_VAR): Rewrite so as not to use empty "else",
5243 which gcc can warn about.
5244 (regex_compile, re_match_2_internal): Mark locals as initialized.
5245 (RETALLOC_IF): Define only if needed.
5246 (WORDCHAR_P): Likewise. This one is never needed, but is used
5247 only in a comment talking about a compiler bug, so put inside
5248 the #if 0 of that comment.
5249 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5250 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5251 Remove; unused.
5252
5253 * search.c (boyer_moore): Rename locals to avoid shadowing.
5254 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5255 (PREV_CHAR_BOUNDARY): Likewise.
5256
5257 * search.c (simple_search): Remove unused var.
5258
5259 * dired.c (compile_pattern): Move decl from here ...
5260 * lisp.h: ... to here, so that it can be checked.
5261 (struct re_registers): New forward decl.
5262
5263 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5264
5265 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5266 All uses changed.
5267 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5268 Rename locals to avoid shadowing.
5269 (Fvertical_motion): Mark locals as initialized.
5270
5271 * casefiddle.c (casify_object, casify_region): Now static.
5272 (casify_region): Mark local as initialized.
5273
5274 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5275
5276 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5277 New macros, so that the caller can use some names other than
5278 gcpro1, gcpro2, etc.
5279 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5280 of the new macros.
5281 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5282 argument, for consistency with GCPRO2_VAR, etc: it is now the
5283 prefix of the variable, not the variable itself. All uses
5284 changed.
5285 * dired.c (directory_files_internal, file_name_completion):
5286 Rename locals to avoid shadowing.
5287
5288 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5289 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5290 dired.c's scmp function, had undefined behavior.
5291 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5292 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5293 * buffer.h: ... to here, because these macros use current_buffer,
5294 and the new implementation with inline functions needs to have
5295 current_buffer in scope now, rather than later when the macros
5296 are used.
5297 (downcase, upcase1): New static inline functions.
5298 (DOWNCASE, UPCASE1): Reimplement using these functions.
5299 This avoids undefined behavior in expressions like
5300 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5301 from race conditions in accessing the global variables
5302 case_temp1 and case_temp2.
5303 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5304 * lisp.h (case_temp1, case_temp2): Remove their decls.
5305 * character.h (ASCII_CHAR_P): Move from here ...
5306 * lisp.h: ... to here, so that the inline functions mentioned
5307 above can use them.
5308
5309 * dired.c (directory_files_internal_unwind): Now static.
5310
5311 * fileio.c (file_name_as_directory, directory_file_name):
5312 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5313 Now static.
5314 (file_name_as_directory): Use const pointers when appropriate.
5315 (Fexpand_file_name): Likewise. In particular, newdir might
5316 point at constant storage, so make it a const pointer.
5317 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5318 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5319 signedness issues.
5320 (Fset_file_times, Finsert_file_contents, auto_save_error):
5321 Rename locals to avoid shadowing.
5322
5323 * minibuf.c (choose_minibuf_frame_1): Now static.
5324 (Ftry_completion, Fall_completions): Rename or remove locals
5325 to avoid shadowing.
5326
5327 * marker.c (bytepos_to_charpos): Remove; unused.
5328
5329 * lisp.h (verify_bytepos, count_markers): New decls,
5330 so that gcc does not warn that these functions aren't declared.
5331
5332 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5333 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5334 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5335 (copy_text): Remove unused local var.
5336
5337 * filelock.c (within_one_second): Now static.
5338 (lock_file_1): Rename local to avoid shadowing.
5339
5340 * buffer.c (fix_overlays_before): Mark locals as initialized.
5341 (fix_start_end_in_overlays): Likewise. This function should be
5342 simplified by using pointers-to-pointers, but that's a different
5343 matter.
5344 (switch_to_buffer_1): Now static.
5345 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5346 (report_overlay_modification): Rename locals to avoid shadowing.
5347
5348 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5349 Fix pointer signedness issue.
5350 (sys_subshell): Mark local as volatile if checking for lint,
5351 to suppress a gcc -Wclobbered warning that does not seem to be right.
5352 (MAXPATHLEN): Define only if needed.
5353
5354 * process.c (serial_open, serial_configure): Move decls from here ...
5355 * systty.h: ... to here, so that they can be checked.
5356
5357 * fns.c (get_random, seed_random): Move extern decls from here ...
5358 * lisp.h: ... to here, so that they can be checked.
5359
5360 * sysdep.c (reset_io): Now static.
5361 (wait_for_termination_signal): Remove; unused.
5362
5363 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5364 (copy_keymap_item, append_key, push_text_char_description):
5365 Now static.
5366 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5367 (DENSE_TABLE_SIZE): Remove; unused.
5368 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5369 (describe_map_tree):
5370 Rename locals to avoid shadowing.
5371
5372 * keyboard.c: Declare functions static if they are not used elsewhere.
5373 (echo_char, echo_dash, cmd_error, top_level_2):
5374 (poll_for_input, handle_async_input): Now static.
5375 (read_char, kbd_buffer_get_event, make_lispy_position):
5376 (make_lispy_event, make_lispy_movement, apply_modifiers):
5377 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5378 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5379 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5380 (read_key_sequence, read_char): Mark locals as initialized.
5381 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5382
5383 * keyboard.h (make_ctrl_char): New decl.
5384 (mark_kboards): Move decl here ...
5385 * alloc.c (mark_kboards): ... from here.
5386
5387 * lisp.h (force_auto_save_soon): New decl.
5388
5389 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5390 (DEFINE_DUMMY_FUNCTION): New macro.
5391 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5392 Use it.
5393 (main): Add casts to avoid warnings
5394 if GCC considers string literals to be constants.
5395
5396 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5397
5398 * dbusbind.c: Pointer signedness fixes.
5399 (xd_signature, xd_append_arg, xd_initialize):
5400 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5401 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5402 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5403 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5404
5405 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5406 if GCC considers string literals to be constants.
5407 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5408
5409 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5410
5411 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5412 (print_preprocess, print_object): New macro to fix last change.
5413
5414 * print.c (print_preprocess): Don't forget font objects.
5415
5416 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5417
5418 * emacs.c (USAGE3): Doc fixes.
5419
5420 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5421
5422 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5423 structure.
5424
5425 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5426
5427 * lisp.h (VWindow_system, Qfile_name_history):
5428 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5429 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5430 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5431
5432 * w32select.c: Don't #include "keyboard.h".
5433 (run_protected): Add extern declaration for waiting_for_input.
5434
5435 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5436 * w32console.c (detect_input_pending, read_input_pending)
5437 (encode_terminal_code):
5438 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5439 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5440 (w32_system_caret_y, Qfile_name_history):
5441 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5442 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5443 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5444 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5445 * w32proc.c (Qlocal, report_file_error):
5446 * w32term.c (Vwindow_system, updating_frame):
5447 * w32uniscribe.c (initialized, uniscribe_font_driver):
5448 Remove unneeded extern declarations.
5449
5450 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5451
5452 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5453
5454 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5455
5456 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5457 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5458 These macros can no longer be used for assignment.
5459
5460 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5461 Assign struct members directly, instead of using BUF_BEGV etc.
5462 (record_buffer_markers, fetch_buffer_markers): New functions for
5463 recording and fetching special buffer markers.
5464 (set_buffer_internal_1, set_buffer_temp): Use them.
5465
5466 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5467
5468 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5469
5470 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5471 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5472
5473 * xdisp.c (hscroll_window_tree):
5474 (reconsider_clip_changes): Use PT instead of BUF_PT.
5475
5476 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5477
5478 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5479 $(EMACS_ROOT)/lib/intprops.h.
5480
5481 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5482
5483 Fix more problems found by GCC 4.5.2's static checks.
5484
5485 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5486 to unsigned char * to avoid compiler diagnostic.
5487 (xg_free_frame_widgets): Make it clear that a local variable is
5488 needed only if USE_GTK_TOOLTIP.
5489 (gdk_window_get_screen): Make it clear that this macro is needed
5490 only if USE_GTK_TOOLTIP.
5491 (int_gtk_range_get_value): New function, which avoids a diagnostic
5492 from gcc -Wbad-function-cast.
5493 (xg_set_toolkit_scroll_bar_thumb): Use it.
5494 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5495 diagnostic from gcc -Wbad-function-cast.
5496 (get_utf8_string, xg_get_file_with_chooser):
5497 Rename locals to avoid shadowing.
5498 (create_dialog): Move locals to avoid shadowing.
5499
5500 * xgselect.c (xg_select): Remove unused var.
5501
5502 * image.c (four_corners_best): Mark locals as initialized.
5503 (gif_load): Initialize transparent_p to zero (Bug#8238).
5504 Mark another local as initialized.
5505 (my_png_error, my_error_exit): Mark with NO_RETURN.
5506
5507 * image.c (clear_image_cache): Now static.
5508 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5509 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5510 (x_edge_detection): Remove unnecessary cast that
5511 gcc -Wbad-function-cast diagnoses.
5512 (gif_load): Fix pointer signedness.
5513 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5514 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5515
5516 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5517
5518 Improve quality of tests for time stamp overflow.
5519 For example, without this patch (encode-time 0 0 0 1 1
5520 1152921504606846976) returns the obviously-bogus value (-948597
5521 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5522 reports time overflow. See
5523 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5524 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5525 * editfns.c: Include limits.h and intprops.h.
5526 (TIME_T_MIN, TIME_T_MAX): New macros.
5527 (time_overflow): Move earlier, to before first use.
5528 (hi_time, lo_time): New functions, for an accurate test for
5529 out-of-range times.
5530 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5531 (Fget_internal_run_time): Don't assume time_t fits in int.
5532 (make_time): Use list2 instead of Fcons twice.
5533 (Fdecode_time): More accurate test for out-of-range times.
5534 (check_tm_member): New function.
5535 (Fencode_time): Use it, to test for out-of-range times.
5536 (lisp_time_argument): Don't rely on undefined left-shift and
5537 right-shift behavior when checking for time stamp overflow.
5538
5539 * editfns.c (time_overflow): New function, refactoring common code.
5540 (Fformat_time_string, Fdecode_time, Fencode_time):
5541 (Fcurrent_time_string): Use it.
5542
5543 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5544 * dired.c (make_time): Move to ...
5545 * editfns.c (make_time): ... here.
5546 * systime.h: Note the move.
5547
5548 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5549
5550 * fringe.c (update_window_fringes): Remove unused variables.
5551
5552 * unexmacosx.c (copy_data_segment): Also copy __got section.
5553 (Bug#8223)
5554
5555 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5556
5557 * termcap.c [MSDOS]: Include "msdos.h".
5558 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5559 Constify `char *' arguments and their references according to
5560 prototypes in tparam.h.
5561
5562 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5563
5564 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5565 Adapt all references accordingly.
5566
5567 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5568
5569 2011-03-11 Tom Tromey <tromey@redhat.com>
5570
5571 * buffer.c (syms_of_buffer): Remove obsolete comment.
5572
5573 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5574
5575 * termhooks.h (encode_terminal_code): Declare prototype.
5576
5577 * msdos.c (encode_terminal_code): Don't declare prototype.
5578
5579 * term.c (encode_terminal_code): Now external again, used by
5580 w32console.c and msdos.c.
5581
5582 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5583 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5584
5585 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5586
5587 Fix some minor problems found by GCC 4.5.2's static checks.
5588
5589 * fringe.c (update_window_fringes): Mark locals as initialized
5590 (Bug#8227).
5591 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5592
5593 * alloc.c (mark_fringe_data): Move decl from here ...
5594 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5595 to check its interface.
5596 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5597
5598 * fontset.c (free_realized_fontset): Now static.
5599 (Fset_fontset_font): Rename local to avoid shadowing.
5600 (fontset_font): Mark local as initialized.
5601 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5602
5603 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5604
5605 * xselect.c (x_disown_buffer_selections): Remove; not used.
5606 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5607 (x_own_selection, Fx_disown_selection_internal): Rename locals
5608 to avoid shadowing.
5609 (x_handle_dnd_message): Remove local to avoid shadowing.
5610
5611 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5612 so that the caller can use some name other than gcpro1.
5613 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5614 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5615 (Fx_backspace_delete_keys_p):
5616 Use them to avoid shadowing, and rename vars to avoid shadowing.
5617 (x_decode_color, x_set_name, x_window): Now static.
5618 (Fx_create_frame): Add braces to silence GCC warning.
5619 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5620 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5621 Remove unused locals.
5622 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5623 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5624 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5625 macros.
5626
5627 * xterm.h (x_mouse_leave): New decl.
5628
5629 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5630 Remove unused functions.
5631 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5632 (x_calc_absolute_position): Now static.
5633 (XTread_socket): Don't define label "out" unless it's used.
5634 Don't declare local "event" unless it's used.
5635 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5636 unless they are used.
5637 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5638 (x_fatal_error_signal): Remove; not used.
5639 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5640 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5641 (x_error_catcher, x_connection_closed, x_error_handler):
5642 (x_error_quitter, xembed_send_message, x_iconify_frame):
5643 (my_log_handler): Rename locals to avoid shadowing.
5644 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5645 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5646
5647 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5648 Rename or move locals to avoid shadowing.
5649 (tty_defined_color, merge_face_heights): Now static.
5650 (free_realized_faces_for_fontset): Remove; not used.
5651 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5652 does not deduce is never used uninitialized.
5653 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5654 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5655
5656 * terminal.c (store_terminal_param): Now static.
5657
5658 * xmenu.c (menu_highlight_callback): Now static.
5659 (set_frame_menubar): Remove unused local.
5660 (xmenu_show): Rename parameter to avoid shadowing.
5661 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5662 since they might point to immutable storage.
5663 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5664 since it's unused otherwise.
5665
5666 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5667 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5668 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5669 avoids a gcc -Wuninitialized diagnostic.
5670 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5671 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5672 does not deduce are never used uninitialized.
5673
5674 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5675
5676 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5677 * window.c (window_loop, size_window):
5678 (run_window_configuration_change_hook, enlarge_window): Likewise.
5679
5680 * window.c (display_buffer): Now static.
5681 (size_window): Mark variables that gcc -Wuninitialized
5682 does not deduce are never used uninitialized.
5683 * window.h (check_all_windows): New decl, to forestall
5684 gcc -Wmissing-prototypes diagnostic.
5685 * dispextern.h (bidi_dump_cached_states): Likewise.
5686
5687 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5688 shadowing.
5689 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5690 Include <limits.h>.
5691 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5692 and to avoid gcc -Wuninitialized warning.
5693 (load_charset_map): Mark variables that gcc -Wuninitialized
5694 does not deduce are never used uninitialized.
5695 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5696
5697 * coding.c (coding_set_source, coding_set_destination):
5698 Use "else { /* comment */ }" rather than "else /* comment */;"
5699 for clarity, and to avoid gcc -Wempty-body warning.
5700 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5701 a block, when the outer 'i' will do.
5702 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5703 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5705 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5706 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5707 Rename locals to avoid shadowing.
5708 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5709 * coding.c (emacs_mule_char, encode_invocation_designation):
5710 Now static, since they're not used elsewhere.
5711 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5712 (decode_coding_object, encode_coding_object, detect_coding_system):
5713 (decode_coding_emacs_mule): Mark variables that gcc
5714 -Wuninitialized does not deduce are never used uninitialized.
5715 (detect_coding_iso_2022): Initialize a local variable that might
5716 be used uninitialized. Leave a FIXME because it's not clear that
5717 this initialization is needed. (Bug#8211)
5718 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5719 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5720 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5721 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5722 Remove unused macros.
5723
5724 * category.c (hash_get_category_set): Remove unused local var.
5725 (copy_category_table): Now static, since it's not used elsewhere.
5726 * character.c (string_count_byte8): Likewise.
5727
5728 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5729 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5730
5731 * chartab.c (copy_sub_char_table): Now static, since it's not used
5732 elsewhere.
5733 (sub_char_table_ref_and_range, char_table_ref_and_range):
5734 Rename locals to avoid shadowing.
5735 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5736
5737 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5738 (BIDI_BOB): Remove unused macro.
5739
5740 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5741 deduce are never used uninitialized.
5742 * term.c (encode_terminal_code): Likewise.
5743
5744 * term.c (encode_terminal_code): Now static. Remove unused local.
5745
5746 * tparam.h: New file.
5747 * term.c, tparam.h: Include it.
5748 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5749 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5750 Move these decls to tparam.h, and make them agree with what
5751 is actually in tparam.c. The previous trick of using incompatible
5752 decls in different modules does not conform to the C standard.
5753 All callers of tparam changed to use tparam's actual API.
5754 * tparam.c (tparam1, tparam, tgoto):
5755 Use const pointers where appropriate.
5756
5757 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5758 * cm.h (struct cm): Likewise.
5759 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5760 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5761 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5762 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5763 (turn_on_face, init_tty): Likewise.
5764 * termchar.h (struct tty_display_info): Likewise.
5765
5766 * term.c (term_mouse_position): Rename local to avoid shadowing.
5767
5768 * alloc.c (mark_ttys): Move decl from here ...
5769 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5770
5771 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5772
5773 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5774
5775 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5776
5777 * search.c (compile_pattern_1): Remove argument regp, unused since
5778 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5779 (compile_pattern): Don't pass it.
5780
5781 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5782
5783 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5784 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5785 for ! HAVE_GTK3.
5786 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5787
5788 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5789
5790 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5791 gdk_window_get_screen, gdk_window_get_geometry,
5792 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5793 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5794 (xg_get_pixbuf_from_pixmap): New function.
5795 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5796 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5797 Call xg_get_pixbuf_from_pixmap instead of
5798 gdk_pixbuf_get_from_drawable.
5799 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5800 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5801 (xg_check_special_colors): Use GtkStyleContext and its functions
5802 for HAVE_GTK3.
5803 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5804 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5805 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5806 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5807 Call gtk_widget_get_preferred_size.
5808 (xg_frame_resized): gdk_window_get_geometry only takes 5
5809 parameters.
5810 (xg_win_to_widget, xg_event_is_for_menubar):
5811 Call gdk_x11_window_lookup_for_display.
5812 (xg_set_widget_bg): New function.
5813 (delete_cb): New function.
5814 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5815 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5816 (xg_set_background_color): Call xg_set_widget_bg.
5817 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5818 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5819 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5820 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5821 if ! HAVE_GTK3.
5822 (update_frame_tool_bar): Call gtk_widget_hide.
5823 (xg_initialize): Use GDK_KEY_g.
5824
5825 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5826 if ! HAVE_GTK3
5827 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5828
5829 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5830 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5831 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5832
5833 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5834
5835 * w32xfns.c (select_palette): Check success of RealizePalette against
5836 GDI_ERROR, not zero.
5837
5838 See ChangeLog.11 for earlier changes.
5839
5840 ;; Local Variables:
5841 ;; coding: utf-8
5842 ;; End:
5843
5844 Copyright (C) 2011 Free Software Foundation, Inc.
5845
5846 This file is part of GNU Emacs.
5847
5848 GNU Emacs is free software: you can redistribute it and/or modify
5849 it under the terms of the GNU General Public License as published by
5850 the Free Software Foundation, either version 3 of the License, or
5851 (at your option) any later version.
5852
5853 GNU Emacs is distributed in the hope that it will be useful,
5854 but WITHOUT ANY WARRANTY; without even the implied warranty of
5855 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5856 GNU General Public License for more details.
5857
5858 You should have received a copy of the GNU General Public License
5859 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.