1 2012-01-26 Glenn Morris <rgm@gnu.org>
3 * lread.c (syms_of_lread): Doc fix.
5 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7 * coding.c (encode_designation_at_bol): Change return value to
10 2012-01-25 Chong Yidong <cyd@gnu.org>
12 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
14 2012-01-21 Chong Yidong <cyd@gnu.org>
16 * floatfns.c (Fcopysign): Make the second argument non-optional,
17 since nil is not allowed anyway.
19 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
21 * process.c (read_process_output): Use p instead of XPROCESS (proc).
22 (send_process): Likewise.
24 2012-01-19 Martin Rudalics <rudalics@gmx.at>
26 * window.c (save_window_save, Fcurrent_window_configuration)
27 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
30 2012-01-19 Kenichi Handa <handa@m17n.org>
32 * character.c (char_width): New function.
33 (Fchar_width, c_string_width, lisp_string_width):
34 Use char_width (Bug#9496).
36 2012-01-16 Martin Rudalics <rudalics@gmx.at>
38 * window.c (Vwindow_persistent_parameters): New variable.
39 (Fset_window_configuration, save_window_save): Handle persistent
42 2012-01-14 Eli Zaretskii <eliz@gnu.org>
44 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
45 thrashing the stack of the thread. (Bug#9087)
47 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
49 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
51 2012-01-11 Eli Zaretskii <eliz@gnu.org>
53 * xdisp.c (rows_from_pos_range): Handle the case where the
54 highlight ends on a newline. (Bug#10464)
55 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
56 he end column for display of highlight that ends on a newline
59 2012-01-11 Glenn Morris <rgm@gnu.org>
61 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
62 from load-path also when installation-directory is nil. (Bug#10208)
64 2012-01-10 Glenn Morris <rgm@gnu.org>
66 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
68 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
69 Update template values to be closer to their typical values these days.
71 2012-01-09 Eli Zaretskii <eliz@gnu.org>
73 * xdisp.c (rows_from_pos_range): Accept additional argument
74 DISP_STRING, and accept any glyph in a row whose object is that
75 string as eligible for mouse highlight. Fixes mouse highlight of
76 display strings from overlays. (Bug#10464)
78 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
80 emacs: fix an auto-save permissions race condition (Bug#10400)
81 * fileio.c (auto_saving_dir_umask): New static var.
82 (Fmake_directory_internal): Use it.
83 (do_auto_save_make_dir): Set it, instead of invoking chmod after
84 creating the directory. The old code temporarily assigns
85 too-generous permissions to the directory.
86 (do_auto_save_eh): Clear it.
87 (Fdo_auto_save): Catch all errors, not just file errors, so
88 that the var is always cleared.
90 2012-01-07 Eli Zaretskii <eliz@gnu.org>
92 * search.c (scan_buffer): Pass character positions to
93 know_region_cache, not byte positions. (Bug#6540)
95 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
97 * w32.c (sys_rename): Report EXDEV when rename of a directory
98 fails because the target is on another logical disk. (Bug#10284)
100 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
102 * xterm.c (x_embed_request_focus): New function.
104 * xterm.h: Add prototype.
106 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
108 2012-01-05 Glenn Morris <rgm@gnu.org>
110 * emacs.c (emacs_copyright): Update short copyright year to 2012.
112 2012-01-01 Eli Zaretskii <eliz@gnu.org>
114 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
115 Load gnutls_transport_set_lowat only if GnuTLS version is below
117 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
118 GnuTLS versions below 2.11.1.
120 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
122 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
123 to the doc string advising against its use for altering the way
124 windows are scrolled.
126 2011-12-28 Kenichi Handa <handa@m17n.org>
128 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
129 coding-system ASCII compatible only when it does not produce BOM
130 on encoding (Bug#10383).
132 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
134 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
136 (create_and_show_popup_menu): Always use menu_position_func for
139 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
141 * callint.c (Fcall_interactively): Don't truncate prompt string.
143 2011-12-23 Eli Zaretskii <eliz@gnu.org>
145 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
146 property that ends at ZV, so that the bidi iteration could be
147 resumed from there (after widening). (Bug#10360)
149 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
151 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
153 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
155 * nsterm.m (x_free_frame_resources):
156 Release f->output_data.ns->miniimage.
157 (ns_index_color): Fix indentation. Do not retain
158 color_table->colors[i].
160 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
163 * nsfns.m (x_set_background_color): Assign return value from
164 ns_index_color to face-background instead of NSColor*.
165 (ns_implicitly_set_icon_type): Fix indentation.
166 Change assignment in for loop to comparison.
168 * emacs.c (ns_pool): New variable.
169 (main): Assign ns_pool.
170 (Fkill_emacs): Call ns_release_autorelease_pool.
172 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
173 autorelease fdesc, release fdAttrs and tdict.
174 (ns_get_covering_families): Release charset.
175 (ns_findfonts): Release NSFontDescriptor created with new.
176 (ns_uni_to_glyphs): Fix indentation.
177 (setString): Release attrStr before assigning new value.
179 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
181 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
183 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
184 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
186 2011-12-18 David Reitter <reitter@cmu.edu>
188 * nsterm.m (ns_term_init): Subscribe for notifications
189 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
190 to method trackingNotification in EmacsMenu.
192 * nsmenu.m (trackingMenu): New variable.
193 (trackingNotification): New method (from Aquamacs).
194 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
195 from Aquamacs (Bug#7030).
197 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
199 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
200 (symbol_to_nsstring): Fix indentation.
201 (ns_symbol_to_pb): New function.
202 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
203 (Fns_rotate_cut_buffers_internal): Removed.
204 (Fns_store_selection_internal): Renamed from
205 Fns_store_cut_buffer_internal.
206 (ns_get_foreign_selection, Fx_own_selection_internal)
207 (Fx_disown_selection_internal, Fx_selection_exists_p)
208 (Fns_get_selection_internal, Fns_store_selection_internal):
209 Use ns_symbol_to_pb and check if return value is nil.
210 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
211 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
212 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
213 renamed to Sns_store_selection_internal.
214 (ns_handle_selection_request): Move code to Fx_own_selection_internal
215 and remove this function.
216 (ns_handle_selection_clear): Remove, never used.
217 (Fx_own_selection_internal): Move code from ns_handle_selection_request
220 2011-12-17 Ken Brown <kbrown@cornell.edu>
222 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
223 GID is unknown (Bug#10257).
225 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
227 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
228 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
229 which caused a build failure on GNU/Linux IA-64. This problem was
230 introduced by my 2011-10-07 patch.
232 2011-12-15 Juri Linkov <juri@jurta.org>
234 * image.c (imagemagick_error): New function. (Bug#10112)
235 (imagemagick_load_image): Comment out `MagickSetResolution' call.
236 Use `imagemagick_error' where ImageMagick functions return
238 (Fimagemagick_types): Add `Fnreverse' to return the list in the
241 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
243 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
244 fill background (Bug#8992).
246 2011-12-13 Martin Rudalics <rudalics@gmx.at>
248 * window.c (Vwindow_combination_resize)
249 (Vwindow_combination_limit): Use t instead of non-nil in
251 (Vrecenter_redisplay): Add first sentence of doc-string on
253 (Frecenter): Fix doc-string typo.
255 2011-12-11 Kenichi Handa <handa@m17n.org>
257 * coding.c (Funencodable_char_position): Pay attention to the
258 buffer text relocation (Bug#9389).
260 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
262 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
263 gtk_init (Bug#10100).
265 2011-12-10 Eli Zaretskii <eliz@gnu.org>
267 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
268 IT->string is nil. (Bug#10263)
270 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
272 * nsterm.h (x_free_frame_resources): Declare.
274 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
275 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
277 * nsterm.h (ns_get_defaults_value): Declare.
279 * nsterm.m (ns_default): Call ns_get_defaults_value.
281 2011-12-09 Eli Zaretskii <eliz@gnu.org>
283 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
286 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
288 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
289 that where the value of an _OBJC_* symbol points to is in the .bss
292 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
294 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
295 after the loop to call ccl_driver at least once (Bug#8619).
297 2011-12-08 Kenichi Handa <handa@m17n.org>
299 * ftfont.c (get_adstyle_property): Fix previous change
302 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
304 * w32.c (init_environment): If no_site_lisp, remove site-lisp
305 dirs from the default value of EMACSLOADPATH (bug#10208).
307 2011-12-07 Glenn Morris <rgm@gnu.org>
309 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
310 installation and source directories as well. (Bug#10208)
312 2011-12-06 Chong Yidong <cyd@gnu.org>
314 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
316 2011-12-06 Glenn Morris <rgm@gnu.org>
318 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
319 as an error, not just -1. (Bug#10217)
321 2011-12-05 Chong Yidong <cyd@gnu.org>
323 * keyboard.c (process_special_events): New function.
324 (swallow_events, Finput_pending_p): Use it (Bug#10195).
326 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
328 * coding.c (encode_designation_at_bol): Don't use uninitialized
329 local variable (Bug#9318).
331 2011-12-05 Kenichi Handa <handa@m17n.org>
333 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
334 return Qnil (Bug#8046, Bug#10193).
336 2011-12-05 Kenichi Handa <handa@m17n.org>
338 * coding.c (encode_designation_at_bol): New args charbuf_end and
339 dst. Return the number of produced bytes. Callers changed.
340 (coding_set_source): Return how many bytes coding->source was
342 (coding_set_destination): Return how many bytes
343 coding->destination was relocated.
344 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
345 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
347 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
349 * coding.c (CODING_CHAR_CHARSET_P): New macro.
350 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
353 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
355 The following changes are to fix Bug#9318.
357 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
358 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
359 (encode_coding_iso_2022, encode_coding_sjis)
360 (encode_coding_big5, encode_coding_charset): Use the above macros.
362 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
364 * lisp.h (process_quit_flag): Fix external declaration.
366 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
368 Don't macro-inline non-performance-critical code.
369 * eval.c (process_quit_flag): New function.
370 * lisp.h (QUIT): Use it.
372 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
374 * nsfns.m (get_geometry_from_preferences): New function.
375 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
377 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
379 * emacs.c (Qkill_emacs): Define.
380 (syms_of_emacs): Initialize it.
381 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
382 Qquit_flag to `kill-emacs' instead.
383 (quit_throw_to_read_char): Add parameter `from_signal'.
384 All callers changed. Call Fkill_emacs if requested and safe.
385 * lisp.h (QUIT): Call Fkill_emacs if requested.
387 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
389 * widget.c (update_wm_hints): Return if wmshell is null.
390 (widget_update_wm_size_hints): New function.
392 * widget.h (widget_update_wm_size_hints): Declare.
394 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
395 widget_update_wm_size_hints (Bug#10104).
397 2011-12-03 Eli Zaretskii <eliz@gnu.org>
399 * xdisp.c (handle_invisible_prop): If the invisible text ends just
400 before a newline, prepare the bidi iterator for consuming the
401 newline, and keep the current paragraph direction. (Bug#10183)
402 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
404 2011-12-02 Juri Linkov <juri@jurta.org>
406 * search.c (Fword_search_regexp): New Lisp function created from
407 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
408 (Fword_search_backward, Fword_search_forward)
409 (Fword_search_backward_lax, Fword_search_forward_lax):
410 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
411 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
413 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
415 * fileio.c (Finsert_file_contents): Move after-change-function call
416 to before the "handled:" label, since all "goto handled" appear in
417 cases where the *-change-functions have already been properly called
420 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
422 * keyboard.c (interrupt_signal): Don't call kill-emacs when
423 waiting for input. (Bug#10169)
425 2011-11-30 Eli Zaretskii <eliz@gnu.org>
427 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
428 verifies glyph row's hash code--we have just reallocated the
429 glyphs, so their contents can be complete garbage. (Bug#10164)
431 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
433 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
435 2011-11-30 Eli Zaretskii <eliz@gnu.org>
437 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
438 attributes are tested _before_ calling verify_row_hash, to protect
439 against GCC re-ordering of the tests. (Bug#10164)
441 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
443 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
445 * xterm.c (handle_one_xevent): Only set async_visible and friends
446 if net_wm_state_hidden_seen is non-zero (Bug#10002)
447 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
448 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
450 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
452 Remove GCPRO-related macros that exist only to avoid shadowing locals.
453 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
454 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
455 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
456 All uses changed to use GCPRO1 etc.
457 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
458 Revert to old implementation (i.e., before 2011-03-11).
460 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
462 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
463 of scroll runs so as to avoid assigning disabled bogus rows and
464 unnecessary graphics copy operations.
466 2011-11-27 Eli Zaretskii <eliz@gnu.org>
468 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
469 (snprintf) [_MSC_VER]: Redirect to _snprintf.
470 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
471 (malloc, free, realloc, calloc): Redirect to e_* only when
474 * lisp.h (GCTYPEBITS): Move before first use.
475 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
476 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
477 this macro definition.
479 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
482 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
484 * gtkutil.c (xg_create_frame_widgets):
485 Call gtk_window_set_has_resize_grip (FALSE) if that function is
486 present with Gtk+ 2.0.
488 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
490 * fileio.c (Finsert_file_contents): Undo previous change; see
491 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
493 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
495 Rename locals to avoid shadowing.
496 * fileio.c (Finsert_file_contents):
497 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
498 * process.c (wait_reading_process_output):
499 Rename inner 'proc' to 'p' to avoid shadowing.
500 Indent for consistency with usual Emacs style.
502 2011-11-25 Eli Zaretskii <eliz@gnu.org>
504 * xdisp.c (redisplay_window): If cursor row is not fully visible
505 after recentering, and scroll-conservatively is set to a large
506 number, scroll window by a few more lines to make the cursor fully
507 visible and out of scroll-margin. (Bug#10105)
508 (start_display): Don't move to the next line if the display should
509 start at a newline that is part of a display vector or an overlay
512 2011-11-24 Juri Linkov <juri@jurta.org>
514 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
515 after the `MagickPingImage' call. (Bug#10112)
517 2011-11-23 Chong Yidong <cyd@gnu.org>
519 * window.c (Fcoordinates_in_window_p): Accept only live windows.
521 2011-11-23 Martin Rudalics <rudalics@gmx.at>
523 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
524 making another buffer current. (Bug#10114)
526 2011-11-23 Glenn Morris <rgm@gnu.org>
528 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
530 2011-11-23 Chong Yidong <cyd@gnu.org>
532 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
535 2011-11-22 Eli Zaretskii <eliz@gnu.org>
537 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
538 and header-lines, as they don't have one computed for them.
541 * .gdbinit (prow): Make displayed values more self-explaining.
544 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
546 * process.c (wait_reading_process_output): Fix asynchrounous
547 GnuTLS socket handling on some versions of the GnuTLS library.
548 (wait_reading_process_output): Add comment and URL.
550 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
552 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
554 2011-11-21 Chong Yidong <cyd@gnu.org>
556 * window.c (Fnext_window, Fprevious_window): Doc fix.
558 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
560 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
562 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
564 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
566 2011-11-20 Martin Rudalics <rudalics@gmx.at>
568 * window.c (Fset_window_combination_limit): Rename argument
570 (Vwindow_combination_limit): Remove "status" from doc-string.
572 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
574 * m/ibms390.h: Remove.
575 * m/ibms390x.h: Don't include "ibms390.h".
577 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
579 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
580 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
582 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
584 * casetab.c (Fset_case_table):
585 * charset.c (Fcharset_after): Fix typos.
587 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
589 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
590 Otherwise, valgrind does not work on some platforms.
591 Problem reported by Andreas Schwab in
592 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
593 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
594 is set, removing the need for VIRT_ADDRESS_VARIES.
595 (PURE_P): Use a more-efficient implementation that needs just one
596 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
597 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
598 to 4 (xorl, subq, cmpq, setbe).
599 * alloc.c (pure): Always extern now, since that's the
600 VIRT_ADDR_VARIES behavior.
601 (PURE_POINTER_P): Use a single comparison, not two, for
602 consistency with the new puresize.h.
603 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
604 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
605 Remove VIRT_ADDR_VARIES no longer needed.
607 2011-11-19 Eli Zaretskii <eliz@gnu.org>
609 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
610 (erase_phys_cursor, update_window_cursor, show_mouse_face)
611 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
612 behave as if the cursor position were at the window margin.
614 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
615 and the cursor position is out of bounds, behave as if the cursor
616 position were at the window margin. (Bug#10075)
618 2011-11-18 Chong Yidong <cyd@gnu.org>
620 * window.c (Fwindow_combination_limit): Make first argument
621 non-optional, since it is meaningless for live windows like the
624 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
626 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
628 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
630 * intervals.c: Fix grafting over the whole buffer (bug#10071).
631 (graft_intervals_into_buffer): Simplify.
633 2011-11-18 Eli Zaretskii <eliz@gnu.org>
635 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
636 hash values of the two rows.
637 (copy_row_except_pointers): Preserve the used[] arrays and the
638 hash values of the two rows. (Bug#10035)
639 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
641 * xdisp.c (row_hash): New function, body extracted from
642 compute_line_metrics.
643 (compute_line_metrics): Call row_hash, instead of computing the
646 * dispnew.c (verify_row_hash): Call row_hash for computing the
647 hash code of a row, instead of duplicating code from xdisp.c.
649 * dispextern.h (row_hash): Add prototype.
651 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
653 * frame.c (delete_frame): Don't delete the terminal when the last
654 X frame is closed if emacs is built with GTK toolkit.
656 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
658 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
660 2011-11-17 Martin Rudalics <rudalics@gmx.at>
662 * window.c (Vwindow_splits): Rename to
663 Vwindow_combination_resize. Suggested by Juri Linkov.
664 (Fsplit_window_internal): Use Vwindow_combination_resize instead
667 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
669 * nsfns.m (Fns_font_name):
670 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
672 2011-11-16 Martin Rudalics <rudalics@gmx.at>
674 * window.h (window): Rename slot "nest" to "combination_limit".
675 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
676 (Fset_window_nest): Rename to Fset_window_combination_limit.
677 (Vwindow_nest): Rename to Vwindow_combination_limit.
678 (recombine_windows, make_parent_window, make_window)
679 (Fsplit_window_internal, saved_window)
680 (Fset_window_configuration, save_window_save): Rename all
681 occurrences of window_nest to window_combination_limit.
683 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
685 * image.c (imagemagick_load_image): Fix typo.
687 2011-11-14 Eli Zaretskii <eliz@gnu.org>
689 * xdisp.c (display_line): Move the call to
690 highlight_trailing_whitespace before the call to
691 compute_line_metrics, since the latter needs to see the final
692 faces of all the glyphs to compute ROW's hash value.
693 Fixes assertion violations in row_equal_p. (Bug#10035)
695 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
697 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
698 just return (bug#10044).
700 2011-11-12 Eli Zaretskii <eliz@gnu.org>
702 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
703 with user-defined heap size. Bump the default size of the temacs
704 heap to 27MB, to avoid memory warning when running temacs.
705 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
707 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
708 current_matrix and desired_matrix. (Bug#9990)
709 (verify_row_hash) [XASSERTS]: New function.
710 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
711 that the hash value of glyph rows is correct.
713 2011-11-12 Martin Rudalics <rudalics@gmx.at>
715 * window.h (window): Remove splits slot.
716 * window.c (Fwindow_splits, Fset_window_splits): Remove.
717 (Fdelete_other_windows_internal, make_parent_window)
718 (make_window, Fsplit_window_internal, Fdelete_window_internal)
719 (Fset_window_configuration, save_window_save): Don't deal with
720 split status of windows.
721 (saved_window): Remove splits slot.
722 (Vwindow_splits): Rewrite doc-string.
724 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
726 * xfns.c (unwind_create_frame):
727 * nsfns.m (unwind_create_frame):
728 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
729 Vframe_list (Bug#9999).
731 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
733 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
735 2011-11-11 Kenichi Handa <handa@m17n.org>
737 * callproc.c (Fcall_process): Set the member dst_multibyte of
740 2011-11-11 Johan Bockgård <bojohan@gnu.org>
742 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
743 avoid a crash (bug#9496).
745 2011-11-09 Chong Yidong <cyd@gnu.org>
747 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
748 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
750 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
752 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
754 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
756 Avoid some portability problems by eschewing 'extern inline' functions.
757 The trivial performance wins aren't worth the portability hassles; see
758 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
760 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
761 (window_box_width, window_box_left, window_box_left_offset)
762 (window_box_right, window_box_right_offset): Undo previous change,
763 by removing the "extern"s.
764 * intervals.c (adjust_intervals_for_insertion)
765 (adjust_intervals_for_deletion): Undo previous change,
766 making these static again.
767 (offset_intervals, temp_set_point_both, temp_set_point)
768 (copy_intervals_to_string): No longer inline.
769 * xdisp.c (window_text_bottom_y, window_box_width)
770 (window_box_height, window_box_left_offset)
771 (window_box_right_offset, window_box_left, window_box_right)
772 (window_box): No longer inline.
774 2011-11-08 Chong Yidong <cyd@gnu.org>
776 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
777 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
778 Signal an error if not a live window.
779 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
780 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
782 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
784 * lisp.h (syms_of_abbrev): Remove declaration.
785 Reported by CHENG Gao <chenggao@royau.me>.
787 2011-11-07 Eli Zaretskii <eliz@gnu.org>
789 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
790 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
791 of temacs in GUI mode.
793 2011-11-07 Martin Rudalics <rudalics@gmx.at>
795 * window.h: Declare delete_all_child_windows instead of
796 delete_all_subwindows.
797 * window.c (Fwindow_nest, Fset_window_nest)
798 (Fset_window_new_total, Fset_window_new_normal)
799 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
800 (delete_all_subwindows): Rename to delete_all_child_windows.
801 (Fdelete_other_windows_internal, Fset_window_configuration):
802 Call delete_all_child_windows instead of delete_all_subwindows.
803 * frame.c (delete_frame): Call delete_all_child_windows instead
804 of delete_all_subwindows.
806 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
808 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
809 This is also needed for porting to any host where GC_MARK_STACK is
810 not GC_MAKE_GCPROS_NOOPS.
811 (which_symbols): Use it.
813 2011-11-07 Kenichi Handa <handa@m17n.org>
815 * coding.c (coding_set_destination): Check coding->src_pos only
816 when coding->src_object is a buffer (bug#9910).
818 * process.c (send_process): Set the member src_multibyte of coding
819 to 0 (bug#9911) when sending a unibyte text.
821 * callproc.c (Fcall_process): Set the member src_multibyte of
822 process_coding to 0 (bug#9912).
824 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
826 * xmenu.c (cleanup_widget_value_tree): New function.
827 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
828 calling free_menubar_widget_value_tree directly (Bug#9830).
830 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
832 Fix some portability problems with 'inline'.
833 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
834 (window_box_width, window_box_left, window_box_left_offset)
835 (window_box_right, window_box_right_offset): Declare extern.
836 Otherwise, these inline functions do not conform to C99 and
837 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
838 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
839 * intervals.c (adjust_intervals_for_insertion)
840 (adjust_intervals_for_deletion): Now extern, because otherwise the
841 extern inline functions 'offset_intervals' couldn't refer to it.
842 (static_offset_intervals): Remove.
843 (offset_intervals): Rewrite using the old contents of
844 static_offset_intervals. The old version didn't conform to C99
845 because an extern inline function contained a reference to an
846 identifier with static linkage.
848 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
850 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
853 2011-11-06 Eli Zaretskii <eliz@gnu.org>
855 * xdisp.c (init_iterator, reseat_to_string): Don't set the
856 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
857 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
858 return Qleft_to_right.
860 2011-11-06 Chong Yidong <cyd@gnu.org>
862 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
863 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
864 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
865 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
866 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
867 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
868 (Fwindow_vscroll): Doc fix.
869 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
870 argument, since it makes no sense to pass a live window and for
871 consistency with window-child.
873 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
875 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
878 2011-11-05 Jason Rumney <jasonr@gnu.org>
880 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
881 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
883 (add_font_entity_to_list): Fix logic errors in mixed boolean and
884 bitwise arithmetic preventing use of unicode-sip and non-truetype
887 2011-11-05 Eli Zaretskii <eliz@gnu.org>
889 * s/ms-w32.h (fstat, stat, utime): Move redirections to
892 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
893 initialization code to keep similarity to xfns.c after changes
896 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
898 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
899 (unwind_create_frame): New function (Bug#9943).
900 (Fx_create_frame): Restructure code to be more similar to the one in
901 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
902 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
903 Move terminal->reference_count++ just before making the frame official
906 * nsterm.m (x_free_frame_resources): New function.
907 (x_destroy_window): Move code to x_free_frame_resources.
909 * xfns.c (unwind_create_frame): Fix comment.
910 (Fx_create_frame, x_create_tip_frame):
911 Move terminal->reference_count++ just before making the frame
912 official. Move initialization of image_cache_refcount and
913 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
915 2011-11-05 Eli Zaretskii <eliz@gnu.org>
917 Support MSVC build with newer versions of Visual Studio.
918 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
919 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
922 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
923 which are not supported by MSVC.
924 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
925 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
927 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
929 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
931 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
933 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
935 Support MSVC build with newer versions of Visual Studio.
936 * w32.c: Don't include w32api.h for MSVC.
937 (init_environment) [_MSC_VER]: Call sys_access, not _access.
939 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
940 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
941 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
942 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
944 (alloca) [_MSC_VER]: Define to _alloca.
946 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
948 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
950 2011-11-04 Eli Zaretskii <eliz@gnu.org>
952 * xdisp.c (note_mouse_highlight): If either of
953 previous/next-single-property-change returns nil, treat that as
954 the beginning or the end of the buffer. (Bug#9955)
956 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
958 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
959 label is not null (Bug#9951).
960 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
963 2011-11-04 Eli Zaretskii <eliz@gnu.org>
965 * window.c (Fwindow_body_size): Mention in the doc string that the
966 return value is in frame's canonical units. (Bug#9949)
968 2011-11-03 Eli Zaretskii <eliz@gnu.org>
970 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
972 * w32fns.c (unwind_create_frame): If needed, free the glyph
973 matrices of the partially constructed frame. (Bug#9943)
974 * xfns.c (unwind_create_frame): Likewise.
976 2011-11-01 Eli Zaretskii <eliz@gnu.org>
978 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
979 Don't stop backward scan on the continuation glyph, even though
980 its CHARPOS is positive.
981 (mouse_face_from_buffer_pos, note_mouse_highlight):
982 Rename cover_string to disp_string.
984 2011-11-01 Martin Rudalics <rudalics@gmx.at>
986 * window.c (temp_output_buffer_show): Don't use
987 Vtemp_buffer_show_specifiers.
988 (Vtemp_buffer_show_specifiers): Remove unused variable.
990 2011-10-30 Eli Zaretskii <eliz@gnu.org>
992 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
993 past the beginning of the current glyph matrix.
995 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
997 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
998 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
999 HAVE_GTK3 (Bug#9869).
1001 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1002 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1004 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1006 * xterm.c: Declare x_handle_net_wm_state to return int.
1007 (handle_one_xevent): Check if we are iconified but don't have
1008 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1009 (get_current_wm_state): Return non-zero if not hidden,
1010 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1011 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1012 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1013 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1015 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1017 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1018 so that this new function doesn't get optimized away by a
1019 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1021 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1023 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1025 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1027 Fix the `xbytecode' command.
1028 * .gdbinit (xprintbytestr): New command.
1029 (xwhichsymbols): Rename from `which'; all callers changed.
1030 (xbytecode): Print the byte-code string as well.
1032 2011-10-29 Kim Storm <storm@cua.dk>
1034 * alloc.c (which_symbols): New function.
1036 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1038 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1041 2011-10-29 Glenn Morris <rgm@gnu.org>
1043 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1044 Not clear what it was for, and it causes various bugs. (Bug#9839)
1046 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1048 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1049 possible random value that matches one of those tested as
1050 condition to clear the mouse face.
1052 2011-10-28 Chong Yidong <cyd@gnu.org>
1054 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1056 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1058 * window.c (make_window): Initialize phys_cursor_on_p.
1060 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1062 * lisp.h (struct Lisp_Symbol): Update comments.
1064 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1066 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1068 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1070 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1071 <oslsachem@gmail.com> for helping to debug this.
1073 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1074 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1075 (g_b_init_get_glyph_outline_w): New static variables.
1076 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1077 (GetGlyphOutlineW_Proc): New typedefs.
1078 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1079 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1081 (w32font_open_internal, compute_metrics):
1082 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1083 instead of calling the "wide" APIs directly.
1085 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1087 * w32.h (syms_of_w32font): Add prototype.
1089 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1091 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1092 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1093 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1094 (Fmove_to_window_line): Doc fix.
1096 2011-10-27 Chong Yidong <cyd@gnu.org>
1098 * process.c (make_process): Set gnutls_state to NULL.
1100 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1101 non-NULL, regardless of GNUTLS_INITSTAGE.
1102 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1103 an error. Set process slots as soon as we allocate them.
1105 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1107 2011-10-27 Chong Yidong <cyd@gnu.org>
1109 * gnutls.c (emacs_gnutls_deinit): New function.
1110 Deallocate credentials structures as well as calling gnutls_deinit.
1111 (Fgnutls_deinit, Fgnutls_boot): Use it.
1113 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1114 (deactivate_process): Call emacs_gnutls_deinit.
1116 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1118 * image.c (x_create_x_image_and_pixmap):
1119 * w32.c (sys_rename, w32_delayed_load):
1120 * w32font.c (fill_in_logfont):
1121 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1123 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1125 * w32fns.c (w32_default_color_map): New function,
1126 extracted from Fw32_default_color_map.
1127 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1129 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1131 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1133 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1135 * keyboard.c (test_undefined): New function (bug#9751).
1136 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1138 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1140 * sysdep.c (init_sys_modes): Fix the check for the controlling
1141 terminal (Bug#6649).
1143 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1145 * dispextern.h (struct bidi_it): New member next_en_type.
1147 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1148 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1149 current character, check also for next_en_type being WEAK_EN.
1150 (bidi_resolve_weak): Don't enter the expensive loop if the current
1151 position is before next_en_pos. Record the bidi type of the first
1152 non-ET, non-BN character we find, in addition to its position.
1153 (bidi_level_of_next_char): Invalidate next_en_type when
1154 next_en_pos is over-stepped.
1156 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1158 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1159 * editfns.c: Rewrite current-time-zone so that it invokes
1160 the equivalent of (format-time-string "%Z") to get the time zone name.
1161 This fixes a bug when the time zone name contains characters that
1162 need converting from the system time locale to Emacs internal format.
1163 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1164 that patch fixed format-time-string to do the conversion, but
1165 I forgot to fix current-time-zone.
1166 (format_time_string): New function, containing most of
1167 what Fformat_time_string used to contain.
1168 (Fformat_time_string): Rewrite in terms of format_time_string.
1169 This doesn't change this function's behavior.
1170 (current-time-zone): Rewrite to use format_time_string.
1171 This fixes the bug reported by Michael Schierl in
1172 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1173 Jason Rumney's 2007-06-07 change worked around this bug, but
1175 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1177 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1179 * xdisp.c (start_display): If the character at POS is displayed
1180 via a display vector, reset IT->current.dpvec_index to zero.
1181 (try_window_reusing_current_matrix): If a line ends in a display
1182 vector or the next line starts in a display vector, continue
1183 redrawing the window even though the character position of
1184 start_row was reached.
1187 2011-10-18 Chong Yidong <cyd@gnu.org>
1189 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1190 with nobreak-char-display too.
1192 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1194 Fix part 3 of bug#9771.
1195 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1196 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1197 non-neutral characters if the current character is a paragraph
1198 separator (a.k.a. Newline). This avoids running the same
1199 expensive loop twice, once when we consume the preceding newline
1200 and the other time when the line actually needs to be displayed.
1201 Avoid the loop when we see neutrals on the base embedding level
1202 following a character whose directionality is the same as the
1203 paragraph's. This avoids running the expensive loop when a line
1204 ends in a long sequence of neutrals, like control characters.
1205 Add assertion against STRONG_AL type. Slightly rearrange code
1206 that determines the type of a neutral given the first non-neutral
1208 (bidi_level_of_next_char): Set next_en_pos to zero when
1209 invalidating its info.
1211 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1213 * xdisp.c (push_display_prop): Determine whether to record string
1214 or buffer position by IT->string, not by IT->method. Allow
1215 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1216 (move_it_vertically_backward): Don't look for character position
1217 immediately after the newline when in a continuation line.
1220 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1222 * window.c (coordinates_in_window): Rewrite and delabelize
1223 vertical border check. (Bug#5357) (Bug#9618)
1225 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1227 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1228 errors in XSetWindowBorder (bug#9310).
1230 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1232 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1233 avoid crash when xmalloc overrun checking is enabled.
1235 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1237 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1238 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1239 cursor motion with <left> and <right> arrow keys.
1241 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1242 some callers set that themselves.
1244 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1246 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1247 display string and the previous row comes from the same string and
1248 is empty. (Bug#9739) (Bug#9738)
1250 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1252 * doc.c (get_doc_string): Encode file name (bug#9735).
1254 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1256 * bidi.c (bidi_level_of_next_char):
1257 * xdisp.c (get_visually_first_element): Remove old incorrect
1258 comments regarding the Unicode Line Separator character.
1260 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1262 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1264 * alloc.c (Fgc_status): Do not access beyond zombies array
1265 boundary if nzombies > MAX_ZOMBIES.
1266 * alloc.c (dump_zombies): Add missing format specifier.
1268 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1270 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1271 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1273 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1274 Some packages use them to denote characters with modifiers.
1276 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1278 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1279 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1280 matching a pp-number. Rename parameter var to var1.
1282 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1284 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1286 2011-10-08 Glenn Morris <rgm@gnu.org>
1288 * callint.c (Fcall_interactively): Give a more explicit error for the
1289 'c' case with a non-character input. (Bug#8479)
1291 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1293 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1295 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1296 lines that are hscrolled on the left.
1298 * dispnew.c (buffer_posn_from_coords): Account for a possible
1299 presence of header-line. (Bug#4426)
1301 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1303 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1304 Don't advertise functionality which we discourage or doesn't work.
1306 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1308 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1309 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1310 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1311 this makes Emacs dump core during garbage collection on rare
1312 occasions. sizeof is obviously inferior to offsetof here, so
1313 stick with offsetof.
1314 (GC_POINTER_ALIGNMENT): New macro.
1315 (mark_memory): Omit 3rd (offset) arg; caller changed.
1316 Don't assume EMACS_INT alignment is the same as pointer alignment.
1318 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1320 * keyboard.c (read_key_sequence_remapped): New var.
1321 (read_key_sequence): Compute remapping in the right buffer.
1322 (command_loop_1): Use read_key_sequence's remapping directly.
1324 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1326 * dired.c (file_name_completion): Don't expand file name.
1327 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1328 before checking file name handler.
1330 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1331 they've been requested explicitly (bug#9591).
1333 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1335 * keymap.c (Fsingle_key_description): Use make_specified_string
1336 instead of build_string to build string from push_key_description.
1339 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1341 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1342 This fixes a Y2038 bug on 64-bit hosts.
1343 * buffer.c (reset_buffer):
1344 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1345 (Fclear_buffer_auto_save_failure):
1346 Use 0, not -1, to represent an unset failure time, since time_t
1347 might not be signed.
1349 Remove dependency on glibc malloc internals.
1350 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1351 Move back here from lisp.h, but with their new implementations.
1352 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1353 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1354 * charset.c (charset_table_init): New static var.
1355 (syms_of_charset): Use it instead of xmalloc. This removes a
1356 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1357 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1358 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1359 Move back to alloc.c.
1360 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1361 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1363 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1365 * nsterm.m (windowDidResize): Call x_set_window_size only when
1366 ns_in_resize is true. Otherwise set pixelwidth/height and
1367 call change_frame_size (Bug#9628).
1369 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1371 Port --enable-checking=all to Fedora 14 x86-64.
1372 * charset.c (syms_of_charset): Also account for glibc malloc's
1373 internal overhead when calculating the initial malloc maximum.
1375 Port --enable-checking=all to Fedora 14 x86.
1376 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1378 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1379 (overrun_check_realloc, overrun_check_free):
1380 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1381 That way, xmalloc returns a properly-aligned pointer even if
1382 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1383 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1384 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1385 into account when calculating the initial malloc maximum.
1386 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1387 Move here from alloc.c, so that charset.c can use it too.
1388 Properly align; the old code wasn't right for common 32-bit hosts
1389 when configured with --enable-checking=all.
1390 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1391 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1393 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1395 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1398 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1400 * xdisp.c (compute_display_string_end): If there's no display
1401 string at CHARPOS, return -1.
1403 * bidi.c (bidi_fetch_char): When compute_display_string_end
1404 returns a negative value, treat the character as a normal
1405 character not covered by a display string. (Bug#9624)
1407 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1409 * lread.c (Fread_from_string): Fix typo in docstring.
1411 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1413 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1414 newline, reseat the iterator instead of bidi-iterating there one
1415 character at a time. (Bug#9610)
1416 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1417 TO_CHARPOS if the bidi iterator is at base embedding level.
1419 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1421 * lread.c (readevalloop): Use correct code for NBSP.
1422 (read1): Likewise. (Bug#9608)
1424 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1426 * dbusbind.c (Fdbus_register_signal): When service is not
1427 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1429 2011-09-25 Glenn Morris <rgm@gnu.org>
1431 * buffer.c (truncate-lines): Doc fix.
1433 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1435 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1436 (Fset_window_next_buffers): Doc fix.
1438 2011-09-24 Glenn Morris <rgm@gnu.org>
1440 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1442 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1444 Fix minor problems found by static checking.
1445 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1446 * indent.c (Fvertical_motion): Fix == vs = typo.
1448 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1450 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1451 Default value is now t. Doc fix.
1453 * indent.c (Fvertical_motion): Compute and apply the overshoot
1454 logic when moving up, not only when moving down. Fix the
1455 confusing name and values of the it_overshoot_expected variable;
1456 logic changes accordingly. (Bug#9254) (Bug#9549)
1458 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1459 CHARPOS is covered by a display string which includes newlines.
1460 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1461 is covered by a display string with embedded newlines.
1463 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1465 * dbusbind.c (Fdbus_register_signal): Add match rule to
1466 Vdbus_registered_objects_table. (Bug#9581)
1467 (Fdbus_register_method, Vdbus_registered_objects_table):
1470 2011-09-24 Jim Meyering <meyering@redhat.com>
1472 do not ignore write error for any output size
1473 The previous change was incomplete.
1474 While it makes emacs --batch detect the vast majority of stdout
1475 write failures, errors were still ignored whenever the output size is
1476 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1477 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1478 && echo FAIL: ignored write error
1479 FAIL: ignored write error
1480 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1481 && echo FAIL: ignored write error
1482 FAIL: ignored write error
1483 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1485 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1487 * emacs.c (Fkill_emacs): In noninteractive mode exit
1488 non-successfully if a write error occurred on stdout. (Bug#9574)
1490 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1492 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1495 * dispextern.h (struct it): Update the comment documenting what
1498 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1500 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1501 a display string, extend search for cursor position to end of row.
1502 (find_row_edges): If the row ends in a newline from a display
1503 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1504 Handle the case of a display string with multiple newlines.
1505 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1506 non-empty line. Fixes confusing cursor motion with arrow keys at
1507 the beginning of a line that starts with whitespace.
1509 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1511 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1514 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1516 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1519 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1521 * xdisp.c (display_line): Record maximum and minimum buffer
1522 positions even if no glyphs were produced (e.g., by a zero-width
1523 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1524 buffer positions that will be removed from the glyph row because
1526 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1527 column is beyond frame width: don't subtract 1 "pixel" when
1528 computing width of the stretch.
1529 (reseat_at_next_visible_line_start): Undo the change made on
1530 2011-09-17 that saved paragraph information and restored it after
1531 the call to `reseat'. (Bug#9545)
1533 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1535 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1536 and turn window cursor on if cleared (Bug#9415).
1538 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1540 * search.c (boyer_moore): Take unibyte characters from pattern
1541 literally. (Bug#9458)
1543 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1545 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1547 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1549 Fix minor problem found by static checking.
1550 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1551 initialized, to pacify gcc -Wuninitialized.
1553 * fileio.c: Report proper errno when syscall falls.
1554 (Finsert_file_contents): Save and restore errno,
1555 so that report_file_error outputs the correct diagnostic.
1556 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1558 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1560 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1562 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1564 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1565 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1567 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1569 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1570 about the current paragraph and restore it after the call to reseat.
1572 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1573 (bidi_find_paragraph_start): Search back for paragraph beginning
1574 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1575 (bidi_move_to_visually_next): Only trigger paragraph-related
1576 computations when the last character is a newline or at EOB, not
1577 just any NEUTRAL_B. (Bug#9470)
1579 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1580 truncated lines if point is covered by a display string. (Bug#9524)
1582 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1584 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1585 (cons_to_x_long): New function.
1586 (lisp_data_to_selection_data): Use it. Correct the test for
1587 short-versus-long data; it was negated. Break out of vector
1588 loop, for efficiency, when a long datum is discovered.
1590 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1592 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1594 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1596 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1597 GCC PR/17406) by declaring this function with external scope.
1599 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1601 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1602 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1604 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1606 * editfns.c (Fformat): Correctly handle text properties on "%%".
1608 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1610 * xterm.c (x_draw_composite_glyph_string_foreground):
1611 * w32term.c (x_draw_composite_glyph_string_foreground):
1612 * term.c (encode_terminal_code):
1613 * composite.c (composition_update_it, get_composition_id):
1614 * xdisp.c (get_next_display_element)
1615 (fill_composite_glyph_string): Add comments about special meaning
1616 of TAB characters in a composition.
1618 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1620 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1621 This occurs when processing a multibyte format.
1622 Problem reported by Wolfgang Jenker.
1624 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1626 * xdisp.c (try_cursor_movement): Only check for exact match if
1627 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1629 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1631 Remove unused external symbols.
1632 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1633 * xdisp.c (calc_pixel_width_or_height): Now static.
1634 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1635 * indent.c (check_display_width):
1636 * w32term.c: Fix comment to match code.
1637 * xterm.c, xterm.h (x_catching_errors): Remove.
1639 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1641 * xselect.c: Use signed conversions more consistently (Bug#9498).
1642 (selection_data_to_lisp_data): Assume incoming selection data are
1643 signed integers, not unsigned. This is to be consistent with
1644 outgoing selection data, which was modified to use signed integers
1645 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1646 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1647 expects long, not unsigned long.
1649 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1651 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1652 computation of loop end. Reported by Johan Bockgård
1655 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1657 * frame.c (Fother_visible_frames_p): Function deleted.
1659 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1661 * indent.c (compute_motion): Process display vector front to back
1662 rather than the other way around. (Bug#2496)
1664 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1666 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1668 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1670 * minibuf.c (Fread_from_minibuffer): Doc fix.
1672 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1674 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1675 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1677 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1679 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1680 value for non-existent files.
1682 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1684 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1685 set its "size" to -1. This will set the modtime_size field of
1686 the corresponding buffer to -1, which is what
1687 verify-visited-file-modtime expects for files that do not exist.
1690 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1692 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1694 * lisp.h: ... from here. push_key_description is no longer
1695 defined in keyboard.c, so its declaration should not be in
1696 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1697 logically belongs with push_key_description.
1699 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1701 * buffer.h: Include <sys/types.h> instead of <time.h>.
1702 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1703 Problem reported by Herbert J. Skuhra.
1705 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1707 * xml.c (parse_region): Make the parsing work for
1708 non-comment-starting XML files again (bug#9144).
1710 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1712 * image.c (gif_load): Fix calculation of bottom and right corner.
1715 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1717 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1718 redisplay in small windows.
1720 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1722 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1724 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1726 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1727 Operate on live windows only.
1729 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1731 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1733 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1735 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1736 only under bidi iteration.
1738 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1740 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1742 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1744 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1745 Without this fix, the command to link temacs failed due to an
1746 undefined symbol __builtin_isnan. This is because
1747 /usr/include/iso/math_c99.h #defines isnan(x) to
1748 __builtin_isnan(x), but the bundled gcc, which identifies itself
1749 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1751 * floatfns.c (isnan): #undef, and then #define to a clone of
1753 (Fisnan): Always define, since it's always available now.
1754 (syms_of_floatfns): Always define isnan at the Lisp level.
1756 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1758 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1760 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1762 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1763 The previous code assumed that file offsets (off_t values) fit in
1764 EMACS_INT variables, which is not true on typical 32-bit hosts.
1765 The code messed up by falsely reporting buffer overflow in cases
1766 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1767 when "big" contains more than 2**29 bytes, even though this
1768 inserts just one byte and does not overflow the buffer.
1769 (Finsert_file_contents): Store file offsets as off_t
1770 values, not as EMACS_INT values. Check for overflow when
1771 converting between EMACS_INT and off_t. When checking for
1772 buffer overflow or for overlap, take the offsets into account.
1773 Don't use EMACS_INT for small values where int suffices.
1774 When checking for overlap, fix a typo: ZV was used where
1775 ZV_BYTE was intended.
1776 (Fwrite_region): Don't assume off_t fits into 'long'.
1777 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1779 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1781 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1783 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1785 sprintf-related integer and memory overflow issues (Bug#9412).
1787 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1788 (esprintf, exprintf, evxprintf): New functions.
1789 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1790 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1791 (modify_event_symbol): Do not assume that the length of
1792 name_alist_or_stem is safe to alloca and fits in int.
1793 (Fexecute_extended_command): Likewise for function name and binding.
1794 (Frecursion_depth): Wrap around reliably on integer overflow.
1795 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1796 since some callers pass EMACS_INT values.
1797 (Fsingle_key_description): Don't crash if symbol name contains more
1798 than MAX_ALLOCA bytes.
1799 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1800 (get_minibuffer): Arg is now EMACS_INT, not int.
1801 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1802 (esprintf, exprintf, evxprintf): New decls.
1803 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1805 * dbusbind.c (signature_cat): New function.
1806 (xd_signature, Fdbus_register_signal):
1807 Do not overrun buffer; instead, report string overflow.
1809 * dispnew.c (add_window_display_history): Don't overrun buffer.
1810 Truncate instead; this is OK since it's just a log.
1812 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1813 even if the time zone offset is outlandishly large.
1814 Don't mishandle offset == INT_MIN.
1816 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1817 when creating daemon; the previous buffer-overflow check was incorrect.
1819 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1820 which has the guts of the old verror function.
1822 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1823 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1825 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1826 (font_unparse_xlfd): Don't blindly alloca long strings.
1827 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1828 fits in int, when using sprintf. Use single snprintf to count
1829 length of string rather than counting it via multiple sprintfs;
1830 that's simpler and more reliable.
1831 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1832 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1833 sprintf, in case result does not fit in int.
1835 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1836 (fontset_from_font): Print it.
1838 * frame.c (tty_frame_count): Now printmax_t, not int.
1839 (make_terminal_frame, set_term_frame_name): Print it.
1840 (x_report_frame_params): In X, window IDs are unsigned long,
1841 not signed long, so print them as unsigned.
1842 (validate_x_resource_name): Check for implausibly long names,
1843 and don't assume name length fits in 'int'.
1844 (x_get_resource_string): Don't blindly alloca invocation name;
1845 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1848 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1849 (xg_check_special_colors, xg_set_geometry):
1850 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1852 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1853 Use esprintf, not sprintf, in case result does not fit in int.
1855 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1856 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1857 it as a large positive number.
1858 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1859 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1861 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1862 in case result does not fit in int.
1864 * print.c (float_to_string): Detect width overflow more reliably.
1865 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1866 buffer overrun. Don't assume list length fits in 'int'. Treat
1867 print length of 0 as 0, not as infinity; to be consistent with other
1868 uses of print length in this function. Don't overflow print length
1869 index. Don't assume hash table size fits in 'long', or that
1870 vectorlike size fits in 'unsigned long'.
1872 * process.c (make_process): Use printmax_t, not int, to format
1873 process-name gensyms.
1875 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1877 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1878 to avoid potential buffer overrun.
1880 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1881 if X resource line is longer than 512 bytes.
1883 * xfns.c (x_window): Make sprintf buffer a bit bigger
1884 to avoid potential buffer overrun.
1886 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1888 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1890 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1892 Integer overflow fixes for scrolling, etc.
1893 Without these, Emacs silently mishandles large integers sometimes.
1894 For example, "C-u 4294967297 M-x recenter" was treated as if
1895 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1897 * xdisp.c (try_window_id): Check Emacs fixnum range before
1898 converting to 'int'.
1900 * window.c (window_scroll_line_based, Frecenter):
1901 Check that an Emacs fixnum is in range before assigning it to 'int'.
1902 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1903 values converted from Emacs fixnums.
1904 (Frecenter): Don't wrap around a line count if it is out of 'int'
1905 range; instead, treat it as an extreme value.
1906 (Fset_window_configuration, compare_window_configurations):
1907 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1909 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1910 that can exceed INT_MAX. Check that EMACS_INT value is in range
1911 before assigning it to the (possibly-narrower) index.
1912 (match_limit): Don't assume that a fixnum can fit in 'int'.
1914 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1917 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1918 (Fvertical_motion): Don't wrap around LINES values that don't fit
1919 in 'int'. Instead, treat them as extreme values. This is good
1920 enough for windows, which can't have more than INT_MAX lines anyway.
1922 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1924 * Require libxml/parser.h to avoid compilation warning.
1926 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1928 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1929 since this reportedly can destroy thread storage.
1931 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1933 * syntax.c (find_defun_start): Update all cache variables if
1934 exiting early (Bug#9401).
1936 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1938 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1940 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1941 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1942 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1944 * term.c (tty_append_glyph): New function.
1945 (produce_stretch_glyph): Static function and its prototype deleted.
1947 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1950 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1952 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1953 when checking :margin (Bug#9390).
1954 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1955 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1956 so that the name doesn't mislead. All uses changed.
1958 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1960 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1963 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1965 * xdisp.c (move_it_to): Don't bail out early when reaching
1966 position beyond to_charpos, if we are scanning backwards.
1967 (move_it_vertically_backward): When DY == 0, make sure we get to
1968 the first character in the line after the newline.
1970 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1972 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1973 (ccl_driver): Do not generate an out-of-range pointer.
1974 (Fccl_execute_on_string): Remove unnecessary check for
1975 integer overflow, noted by Stefan Monnier in
1976 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1977 Remove a FIXME that didn't need fixing.
1978 Simplify the newly-introduced buffer reallocation code.
1980 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1982 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1984 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1986 Integer and memory overflow issues (Bug#9196).
1988 * doc.c (get_doc_string): Rework so that
1989 get_doc_string_buffer_size is the actual buffer size, rather than
1990 being 1 less than the actual buffer size; this makes xpalloc more
1993 * image.c (x_allocate_bitmap_record, cache_image):
1994 * xselect.c (Fx_register_dnd_atom):
1995 Simplify previous changes by using xpalloc.
1997 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1998 since either will do and ptrdiff_t is convenient with xpalloc.
2000 * charset.c (charset_table_size)
2001 (struct charset_sort_data.priority): Now ptrdiff_t.
2002 (charset_compare): Don't overflow if priorities differ greatly.
2003 (Fsort_charsets): Don't assume list length fits in int.
2004 Check for size-calculation overflow when allocating sort data.
2005 (syms_of_charset): Allocate an initial charset table that is
2006 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2008 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2010 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2011 The actual value is always <= INT_MAX, and leaving it unsigned made
2012 overflow checking harder.
2014 * dispextern.h (struct glyph_matrix.rows_allocated)
2015 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2016 with xpalloc. The values are still always <= INT_MAX.
2018 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2020 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2021 (SAFE_NALLOCA): New macro.
2023 * region-cache.c (struct boundary.pos, find_cache_boundary)
2024 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2025 (set_cache_region, invalidate_region_cache)
2026 (revalidate_region_cache, know_region_cache, region_cache_forward)
2027 (region_cache_backward, pp_cache):
2028 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2029 so that ptrdiff_t * can be passed to xpalloc.
2030 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2031 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2032 (pp_cache): Don't assume cache_len fits in int.
2033 * region-cache.h: Adjust extern decls to match.
2035 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2036 EMACS_INT, since either will do, for xpalloc.
2038 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2039 (xnmalloc, xnrealloc, xpalloc): New functions.
2041 * bidi.c (bidi_shelve_header_size): New constant.
2042 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2043 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2045 * bidi.c (bidi_cache_shrink):
2046 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2048 Don't update size of array until after memory allocation succeeds,
2049 because xmalloc/xrealloc may not return.
2050 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2051 now that we have proper integer overflow checking.
2052 (record_overlay_string, overlay_strings): Catch overflows when
2053 calculating size of overlay_str_buf.
2055 * callproc.c (Fcall_process): Check for size overflow when
2056 calculating size of args2.
2057 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2058 Normally we prefer signed values, but sticking with ptrdiff_t would
2059 require adding more-complicated checks.
2061 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2062 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2063 Redo buffer-overflow calculations to avoid integer overflow.
2064 Add a FIXME comment where memory seems to be over-allocated.
2066 * character.c (Fstring): Check for size-calculation overflow.
2068 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2069 unnecessary integer overflow. Check for size overflow.
2070 (encode_coding_object): Don't update size until xmalloc succeeds.
2072 * composite.c (get_composition_id): Check for overflow in glyph
2073 length calculations.
2075 Integer and memory overflow fixes for display code.
2076 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2077 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2078 (scrolling_window): Check for overflow in size calculations.
2079 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2080 Don't assume glyph table len fits in int.
2081 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2082 (row_table_size): Now ptrdiff_t, not int.
2083 (scrolling_window): Avoid overflow in size calculations.
2084 Don't update size until allocation succeeds.
2085 * fns.c (concat): Check for overflow in size calculations.
2086 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2087 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2088 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2090 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2091 (get_doc_string): Check for size calculation overflow.
2092 Don't update size until allocation succeeds.
2093 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2094 EMACS_INT, where ptrdiff_t will do.
2095 (Fsubstitute_command_keys): Check for string overflow.
2097 * editfns.c (set_time_zone_rule): Don't assume environment length
2099 (message_length): Now ptrdiff_t, not int.
2100 (Fmessage_box): Don't update size until allocation succeeds.
2101 Don't assume message length fits in int.
2102 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2104 * emacs.c (main): Do not reallocate argv, since there is a null at
2105 the end that can be overwritten, and this way there's no need to
2106 worry about size-calculation overflow.
2107 (sort_args): Check for size-calculation overflow.
2109 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2111 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2113 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2114 (x_set_scroll_bar_width, x_figure_window_size):
2115 Check for integer overflow.
2116 (x_set_alpha): Do not assume XINT fits in int.
2118 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2119 This is for the members text_lines, text_cols, total_lines, total_cols,
2120 where the system imposes an 'int' limit.
2122 * fringe.c (Fdefine_fringe_bitmap):
2123 Don't update size until alloc works.
2125 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2126 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2128 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2129 Check for size-calculation overflow.
2130 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2131 do, as we prefer signed integers.
2132 (id_to_widget.max_size, id_to_widget.used)
2133 (xg_store_widget_in_map, xg_remove_widget_from_map)
2134 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2135 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2136 Use and return ptrdiff_t, not int.
2137 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2138 * gtkutil.h: Change prototypes to match the above.
2140 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2141 are duplicate now that they've been promoted to lisp.h.
2142 (x_allocate_bitmap_record, x_alloc_image_color)
2143 (make_image_cache, cache_image, xpm_load):
2144 Don't update size until alloc is done.
2145 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2147 Check for size calculation overflow.
2148 (ct_colors_allocated_max): New constant.
2149 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2152 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2153 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2154 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2155 Use ptrdiff_t, not int, to count maps.
2156 (read_char_minibuf_menu_prompt): Check for overflow in size
2157 calculations. Don't update size until allocation succeeds.
2158 Redo calculations to avoid overflow.
2159 * keyboard.h: Change prototypes to match the above.
2161 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2163 (current_minor_maps): Check for size calculation overflow.
2164 * keymap.h: Change prototypes to match the above.
2166 * lread.c (read1, init_obarray): Don't update size until alloc done.
2168 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2169 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2171 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2172 Now ptrdiff_t, not int.
2173 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2174 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2176 * process.c (Fnetwork_interface_list): Check for overflow
2177 in size calculation.
2179 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2181 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2182 overflow. Don't bother calling xmalloc when xrealloc will do.
2184 * search.c (Freplace_match): Check for size calculation overflow.
2185 (Fset_match_data): Don't assume list lengths fit in 'int'.
2187 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2188 for command line length. Do not attempt to address one before the
2189 beginning of an array, as that's not portable.
2191 * term.c (max_frame_lines): Remove; unused.
2192 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2194 (encode_terminal_code, calculate_costs): Check for size
2195 calculation overflow.
2196 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2197 table lengths and related sizes. Don't update size until alloc
2198 done. Redo calculations to avoid overflow.
2199 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2201 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2202 subtracting pointers.
2203 (gobble_line): Check for overflow more carefully. Don't update size
2206 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2207 Don't update size until alloc done.
2208 Redo size calculations to avoid overflow.
2209 Check for size calculation overflow.
2210 (main) [DEBUG]: Fix typo in invoking tparam1.
2212 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2213 Use ptrdiff_t, not int, for sizes.
2214 (store_mode_line_noprop_char): Don't update size until alloc done.
2216 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2217 Use ptrdiff_t, not int, for sizes.
2218 (Finternal_make_lisp_face, cache_face):
2219 Check for size calculation overflow.
2220 (cache_face): Treat size calculation overflows as if they were
2221 memory exhaustion (the usual treatment), rather than aborting.
2223 * xfns.c (x_encode_text, x_set_name_internal)
2224 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2225 sizes, since they can exceed INT_MAX in size. Check for size
2226 calculation overflow.
2228 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2229 (xg_select): Check for size calculation overflow.
2230 Don't update size until alloc done.
2232 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2233 as sprintf is limited to int lengths.
2235 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2236 (X_LONG_MIN): New macros.
2237 Use them to make the following changes clearer.
2238 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2239 This change doesn't affect the value now, but it may help remind
2240 future maintainers not to raise the value too much later.
2241 (SELECTION_QUANTUM): Remove, replacing with ...
2242 (selection_quantum): ... new function, which avoids overflow.
2244 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2245 assumption that selection length fits in 'int'.
2246 (x_reply_selection_request, x_handle_selection_request)
2247 (x_get_window_property, receive_incremental_selection)
2248 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2249 (lisp_data_to_selection_data, clean_local_selection_data):
2250 Use ptrdiff_t, not int, to record length of selection.
2251 (x_reply_selection_request, x_get_window_property)
2252 (receive_incremental_selection, x_property_data_to_lisp):
2253 Redo calculations to avoid overflow.
2254 (x_reply_selection_request): When sending hint, ceiling it at
2255 X_LONG_MAX rather than relying on wraparound overflow to send
2257 (x_get_window_property, receive_incremental_selection)
2258 (lisp_data_to_selection_data, x_property_data_to_lisp):
2259 Check for size-calculation overflow.
2260 (x_get_window_property, receive_incremental_selection)
2261 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2262 Don't store size until memory allocation succeeds.
2263 (x_get_window_property): Plug memory leak on memory exhaustion.
2264 Don't double-block input; malloc is safe here. Don't assume 2**34
2265 - 4 fits in unsigned long. Add an xassert to check
2266 XGetWindowProperty overflow. Be more careful about overflow
2267 calculations, and distinguish size from memory overflow better.
2268 (receive_incremental_selection): When tracing, don't assume
2269 unsigned int is less than INT_MAX.
2270 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2271 harmful) conversions of unsigned short to int.
2272 (lisp_data_to_selection_data): Don't assume that integers
2273 in the range -65535 through -1 fit in an X unsigned short.
2274 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2275 result parameters unless successful. Rely on cons_to_unsigned
2276 to report problems with elements; the old code wasn't right anyway.
2277 (x_check_property_data): Check for int overflow; we cannot use
2278 a wider type due to X limits.
2279 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2281 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2283 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2284 (x_term_init): Check for size calculation overflow.
2285 (x_color_cells): Don't store size until memory allocation succeeds.
2286 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2287 Don't assume alloca size is less than MAX_ALLOCA.
2288 (x_term_init): Don't assume length fits in int (sprintf is limited
2291 Use ptrdiff_t for composition IDs.
2292 * character.c (lisp_string_width):
2293 * composite.c (composition_table_size, n_compositions)
2294 (get_composition_id, composition_gstring_from_id):
2295 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2296 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2297 * window.c (Frecenter):
2298 Use ptrdiff_t, not int, for composition IDs.
2299 * composite.c (get_composition_id): Check for integer overflow.
2300 * composite.h: Adjust prototypes to match the above changes.
2302 Use ptrdiff_t for hash table indexes.
2303 * category.c (hash_get_category_set):
2304 * ccl.c (ccl_driver):
2305 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2306 * coding.c (coding_system_charset_list, detect_coding_system):
2307 * coding.h (struct coding_system.id):
2308 * composite.c (get_composition_id, gstring_lookup_cache):
2309 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2310 * image.c (xpm_get_color_table_h):
2311 * lisp.h (hash_lookup, hash_put):
2312 * minibuf.c (Ftest_completion):
2313 Use ptrdiff_t for hash table indexes, not int (which is too
2314 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2315 32-bit --with-wide-int hosts).
2317 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2318 Add a FIXME comment about memory leaks.
2319 (syms_of_charset): Don't assume xmalloc returns.
2321 Don't assume that stated character widths fit in int.
2322 * character.c (Fchar_width, c_string_width, lisp_string_width):
2323 * character.h (CHAR_WIDTH):
2324 * indent.c (MULTIBYTE_BYTES_WIDTH):
2325 Use sanitize_char_width to avoid undefined and/or bad behavior
2326 with outlandish widths.
2327 * character.h (sanitize_tab_width): Rename from sanitize_width,
2328 now that we have two such functions. All uses changed.
2329 (sanitize_char_width): New inline function.
2331 Don't assume that tab-width fits in int.
2332 * character.h (sanitize_width): New inline function.
2333 (SANE_TAB_WIDTH): New macro.
2334 (ASCII_CHAR_WIDTH): Use it.
2335 * indent.c (sane_tab_width): Remove. All uses replaced by
2336 SANE_TAB_WIDTH (current_buffer).
2337 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2339 * fileio.c: Integer overflow issues with file modes.
2340 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2342 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2343 Remove unreachable code.
2344 (read_hex, load_charset_map_from_file): Check for integer overflow.
2346 * xterm.c: don't go over XClientMessageEvent limit
2347 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2348 (x_send_scroll_bar_event): Likewise. Check that the size does not
2349 exceed limits imposed by XClientMessageEvent, as well as the usual
2350 ptrdiff_t and size_t limits.
2352 * keyboard.c: Overflow, signedness and related fixes.
2353 (make_lispy_movement): Use same integer type in forward decl
2354 that is used in the definition.
2355 (read_key_sequence, keyremap_step):
2356 Change bufsize argument back to int, undoing my 2011-03-30 change.
2357 We prefer signed types, and int is wide enough here.
2358 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2359 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2360 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2361 length, not size_t. Use ptrdiff_t for index, not int.
2362 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2363 possibility of integer overflow.
2365 Overflow, signedness and related fixes for images.
2367 * dispextern.h (struct it.stack[0].u.image.image_id)
2368 (struct_it.image_id, struct image.id, struct image_cache.size)
2369 (struct image_cache.used, struct image_cache.ref_count):
2370 * gtkutil.c (update_frame_tool_bar):
2371 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2372 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2373 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2374 * nsmenu.m (update_frame_tool_bar):
2375 * xdisp.c (calc_pixel_width_or_height):
2376 * xfns.c (image_cache_refcount):
2377 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2378 on typical 64-bit hosts.
2380 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2381 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2382 Omit unnecessary casts to int.
2383 (parse_image_spec): Check that integers fall into 'int' range
2384 when the callers expect that.
2385 (image_ascent): Redo ascent calculation to avoid int overflow.
2386 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2387 (lookup_image): Remove unnecessary tests.
2388 (xbm_image_p): Locals are now of int, not EMACS_INT,
2389 since parse_image_check makes sure they fit into int.
2390 (png_load, gif_load, svg_load_image):
2391 Prefer int to unsigned where either will do.
2392 (tiff_handler): New function, combining the cores of the
2393 old tiff_error_handler and tiff_warning_handler.
2394 This function is rewritten to use vsnprintf and thereby avoid
2395 stack buffer overflows. It uses only the features of vsnprintf
2396 that are common to both POSIX and native Microsoft.
2397 (tiff_error_handler, tiff_warning_handler): Use it.
2398 (tiff_load, gif_load, imagemagick_load_image):
2399 Don't assume :index value fits in 'int'.
2400 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2401 (imagemagick_load_image): Check that crop parameters fit into
2402 the integer types that MagickCropImage accepts. Don't assume
2403 Vimagemagick_render_type has a nonnegative value. Don't assume
2404 size_t fits in 'long'.
2405 (gs_load): Use printmax_t to print the widest integers possible.
2406 Check for integer overflow when computing image height and width.
2408 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2410 * xdisp.c (redisplay_window): Don't force window start if point
2411 will be invisible in the resulting window. (Bug#9324)
2413 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2415 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2416 the display spec is of the form `(space ...)'.
2417 (handle_display_spec): Return the value returned by
2418 handle_single_display_spec, not just 1 or zero.
2419 (handle_single_display_spec): If the display spec is of the form
2420 `(space ...)', and specifies display in the text area, return 2
2422 (try_cursor_movement): Check for the need to scroll more
2423 accurately, and prefer exact match for point under bidi.
2424 Don't advance `row' beyond the last row of the window.
2426 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2427 into disp_prop; all users changed.
2429 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2430 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2431 for the text covered by the display property.
2433 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2435 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2436 Change return value to nil.
2437 (Frecord_buffer): Delete unused function.
2439 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2441 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2442 buffers, return left-to-right.
2443 (set_cursor_from_row): Consider candidate row a win if its glyph
2444 represents a newline and point is on that newline. Fixes cursor
2445 positioning on the newline at EOL of R2L text within L2R
2446 paragraph, and vice versa.
2447 (try_cursor_movement): Check continued rows, in addition to
2448 continuation rows. Fixes unwarranted scroll when point enters a
2449 continued line of R2L text within an L2R paragraph, or vice versa.
2450 (cursor_row_p): Consider the case of point being equal to
2451 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2452 from the end of a short line to the beginning of a continued line
2453 of R2L text within L2R paragraph.
2454 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2455 composed characters.
2457 * bidi.c (bidi_check_type): Use xassert.
2458 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2461 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2463 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2466 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2468 * nsfont.m (ns_otf_to_script): Fix typo.
2470 2011-08-22 Kenichi Handa <handa@m17n.org>
2472 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2473 extra slot even if the purpose is char-code-property-table.
2475 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2477 * xdisp.c (redisplay_window): When computing centering_position,
2478 account for the height of the header line. (Bug#8874)
2480 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2481 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2482 candidate is selected by the mouse, and that candidate has a
2483 composed character under the mouse.
2485 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2486 coordinates reported by pos-visible-in-window-p for a composed
2487 character in column zero.
2489 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2491 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2493 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2495 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2496 consider it a hit if to_charpos is anywhere in the range of the
2497 composed buffer positions.
2499 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2501 * image.c (gif_load): Don't assume that each subimage has the same
2502 dimensions as the base image. Handle disposal method that is
2503 "undefined" by the gif spec (Bug#9335).
2505 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2507 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2508 (Fcondition_case): Document `debug' symbol in error handler.
2510 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2512 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2513 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2514 from an Org mode buffer to a Speedbar frame.
2516 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2517 a composition, take its buffer position from IT->cmp_it.charpos.
2518 Fixes cursor positioning at the beginning of a line that begins
2519 with a composed character.
2521 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2523 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2524 character bidirectional type, use STRONG_L instead. Fixes crashes
2525 in a buffer produced by `describe-categories'.
2527 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2528 members before the level stack, so they would be saved and
2529 restored when copying iterator state. Fixes incorrect reordering
2530 around TABs covered by display properties.
2532 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2534 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2536 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2538 * eval.c (internal_condition_case, internal_condition_case_1)
2539 (internal_condition_case_2, internal_condition_case_n):
2540 Remove unnecessary aborts (Bug#9081).
2542 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2544 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2545 has no `load' handler, try opening the file locally. (Bug#9311)
2547 2011-08-16 Ken Brown <kbrown@cornell.edu>
2549 * gmalloc.c: Expand comment.
2551 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2553 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2554 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2556 2011-08-16 Ken Brown <kbrown@cornell.edu>
2558 Fix memory allocation problems in Cygwin build (Bug#9273).
2560 * unexcw.c ( __malloc_initialized): Declare external variable.
2561 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2563 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2565 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2567 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2569 [CYGWIN] (special_realloc): New function.
2570 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2571 requests to realloc storage in the static heap.
2573 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2575 * bidi.c (bidi_initialize): Remove unused local.
2577 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2580 * biditype.h: Remove file.
2581 * makefile.w32-in ($(BLD)/bidi.$(O)):
2582 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2584 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2586 * chartab.c: Improve commentary for the uniprop_table API.
2588 * bidi.c (bidi_paragraph_init): Support zero value of
2589 bidi_ignore_explicit_marks_for_paragraph_level.
2590 (bidi_initialize): Use uniprop_table instead of including
2591 biditype.h and bidimirror.h.
2593 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2594 coordinates of the iterator when restoring from ppos_it.
2597 2011-08-14 Kenichi Handa <handa@m17n.org>
2599 * process.c (create_process): Call setup_process_coding_systems
2600 after the pid of the process is set to -1 (Bug#8162).
2602 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2604 * xdisp.c (move_it_in_display_line_to): Don't invoke
2605 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2606 ppos_it. Fixes vertical cursor motion when line beginning is
2607 covered by an image. (Bug#9296)
2609 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2611 * nsterm.h (ns_run_ascript): Declare.
2612 (NSAPP_DATA2_RUNASSCRIPT): Define.
2614 * nsfns.m (as_script, as_result, as_status): New static variables.
2615 (ns_run_ascript): New function.
2616 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2617 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2618 the event loop. Get status from as_status (Bug#7276).
2620 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2621 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2622 the event loop (Bug#7276).
2624 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2626 * gnutls.c (QCgnutls_bootprop_priority)
2627 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2628 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2629 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2630 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2631 (QCgnutls_bootprop_verify_hostname_error)
2632 (QCgnutls_bootprop_callbacks_verify): Rename from
2633 Qgnutls_bootprop_..., all uses changed.
2635 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2638 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2640 * xfaces.c (Qframe_set_background_mode): Now static.
2641 * dispextern.h (Qframe_set_background_mode): Remove decl.
2643 * process.c (Fnetwork_interface_info): Declare local only if needed.
2645 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2647 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2648 (Fnetwork_interface_list): Allocate in increments of bytes instead
2649 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2650 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2652 (struct ifflag_def): notrailers is smart on OSX.
2653 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2654 Get hardware address with getifaddrs if available.
2656 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2658 * xdisp.c (iterate_out_of_display_property): xassert that
2659 IT->position is set to within IT->object's boundaries. Break from
2660 the loop as soon as EOB is reached; avoids infloops in redisplay
2661 when IT->position is set up wrongly due to some bug.
2662 Set IT->current to match the bidi iterator unconditionally.
2663 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2664 entry. Force push_it to save on the stack the current
2665 buffer/string position, to be restored by pop_it. Fix flags in
2666 the iterator structure wrt the object coming from a display
2667 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2668 properties. (Bug#9284)
2670 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2672 * fontset.c (fontset_get_font_group): Add proper type checks.
2675 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2677 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2678 and LC_VERSION_MIN_MACOSX.
2679 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2680 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2682 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2684 * xdisp.c (forward_to_next_line_start): Allow to use the
2685 no-display-properties-and-no-overlays under bidi display.
2686 Set disp_pos in the bidi iterator to avoid searches for display
2687 properties and overlays.
2689 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2691 * editfns.c (Fset_time_zone_rule): Document relationship with the
2694 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2695 the font entity extracted from the cache (Bug#8109).
2697 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2699 * composite.c (autocmp_chars): Don't reset point. That is done by
2700 restore_point_unwind (Bug#5984).
2702 2011-08-07 Juri Linkov <juri@jurta.org>
2704 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2705 to show the arg `TIME' instead of `TIMEVAL'.
2707 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2709 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2710 display property strides EOL and includes a newline, as in
2711 longlines-mode. (Bug#9254)
2712 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2713 word-wrap under bidirectional display. (Bug#9224)
2715 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2716 is non-zero, even if the data buffer is NULL. Fixes a crash in
2717 vertical-motion with longlines-mode. (Bug#9254)
2719 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2721 * bidi.c <bidi_cache_total_alloc>: Now static.
2722 (bidi_initialize): Initialize bidi_cache_total_alloc.
2724 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2727 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2728 amount allocated this far in `bidi_cache_total_alloc'.
2729 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2730 non-zero, only free the data buffer without restoring the cache
2731 contents. All callers changed.
2733 * dispextern.h (bidi_unshelve_cache): Update prototype.
2735 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2736 (move_it_in_display_line, move_it_to)
2737 (move_it_vertically_backward, move_it_by_lines): Replace the call
2738 to xfree to an equivalent call to bidi_unshelve_cache.
2739 (move_it_in_display_line_to): Fix logic of returning
2740 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2742 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2744 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2745 came from a string character with a `cursor' property. (Bug#9229)
2747 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2749 * Makefile.in (LIB_PTHREAD): New variable.
2750 (LIBES): Add LIB_PTHREAD (Bug#9216).
2752 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2753 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2755 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2757 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2759 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2761 * xterm.c (x_find_topmost_parent): New function.
2762 (x_set_frame_alpha): Find topmost parent window with
2763 x_find_topmost_parent and set the property there also (bug#9181).
2764 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2766 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2768 * callproc.c (Fcall_process): Avoid vfork clobbering
2769 the local vars buffer, coding_systems, current_dir.
2771 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2773 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2775 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2777 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2778 so that it is not optimized away.
2780 * xdisp.c (compute_display_string_pos): Remove unused local.
2782 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2784 Fix slow cursor motion and scrolling in large buffers with
2785 selective display, like Org Mode buffers. (Bug#9218)
2787 * dispextern.h (struct bidi_it): New member disp_prop_p.
2789 * xdisp.c: Remove one-slot cache of display string positions.
2790 (compute_display_string_pos): Accept an additional argument
2791 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2792 for a display string or property. If found, set DISP_PROP_P
2795 * bidi.c (bidi_fetch_char): Accept an additional argument
2796 DISP_PROP_P, and pass it to compute_display_string_pos.
2797 Only handle text covered by a display string if DISP_PROP_P is returned
2798 non-zero. All callers of bidi_fetch_char changed.
2800 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2802 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2804 2010-12-03 Don March <don@ohspite.net>
2806 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2807 last character M-[char] is translated to ESC [char] (bug#7541).
2809 2011-08-02 Kenichi Handa <handa@m17n.org>
2811 * lisp.h (uniprop_table): Extern it.
2813 * chartab.c (uniprop_table): Make it non-static.
2815 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2817 * xdisp.c (forward_to_next_line_start): Accept additional argument
2818 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2820 (reseat_at_next_visible_line_start): Use the bidi iterator state
2821 returned by forward_to_next_line_start to restore the state of
2822 it->bidi_it after backing up to previous newline. (Bug#9212)
2824 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2826 * regex.c (re_comp): Protoize.
2827 (re_exec): Fix return type.
2828 (regexec): Fix type of `ret'. (Bug#9203)
2830 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2832 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2833 This is needed if max-image-size is a floating-point number.
2835 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2837 * print.c (print_object): Print empty symbol as ##.
2839 * lread.c (read1): Read ## as empty symbol.
2841 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2843 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2844 setting frame foreground color (Bug#9175).
2845 (x_set_background_color): Likewise.
2847 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2848 contents (Bug#9176).
2849 (EmacsTooltip -init): Remove bezels and add shadows to
2852 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2853 or scroll bar (Bug#8470).
2855 * nsfont.m (nsfont_open): Remove assignment to voffset and
2856 unnecessary vars hshink, expand, hd, full_height, min_height.
2857 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2859 * nsterm.h (nsfont_info): Remove voffset field.
2861 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2863 Implement strike-through and overline on NextStep (Bug#8863).
2865 * nsfont.m (nsfont_open): Use underline position provided by font,
2866 instead of hard-coded value of 2.
2867 (nsfont_draw): Call ns_draw_text_decoration instead.
2869 * nsterm.h: Add declaration for ns_draw_text_decoration.
2871 * nsterm.m (ns_draw_text_decoration): New function for drawing
2872 underline, overline, and strike-through.
2873 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2874 ns_draw_text_decoration. Change treatment of cursor drawing to
2875 accommodate underlining, etc.
2877 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2879 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2882 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2884 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2885 Without this fix, if a signal arrives just after memory fills up,
2886 'malloc' might be invoked reentrantly.
2888 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2889 In other words, assume that every image size is allowed, on non-X
2890 hosts. This assumption is probably wrong, but it lets Emacs compile.
2892 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2894 * regex.c (re_iswctype): Convert return values to boolean.
2896 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2898 * xdisp.c (compute_display_string_pos): Don't use cached display
2899 string position if the buffer had its restriction changed.
2902 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2904 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2906 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2908 Integer signedness and overflow and related fixes. (Bug#9079)
2910 * bidi.c: Integer size and overflow fixes.
2911 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2912 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2913 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2914 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2915 (bidi_find_other_level_edge):
2916 Use ptrdiff_t instead of EMACS_INT where either will do.
2917 This works better on 32-bit hosts configured --with-wide-int.
2918 (bidi_cache_ensure_space): Check for size-calculation overflow.
2919 Use % rather than repeated addition, for better worst-case speed.
2920 Don't set bidi_cache_size until after xrealloc returns, because it
2922 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2923 (bidi_cache_ensure_space): Also check that the bidi cache size
2924 does not exceed that of the largest Lisp string or buffer. See Eli
2925 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2927 * alloc.c (__malloc_size_t): Remove.
2928 All uses replaced by size_t. See Andreas Schwab's note
2929 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2931 * image.c: Improve checking for integer overflow.
2932 (check_image_size): Assume that f is nonnull, since
2933 it is always nonnull in practice. This is one less thing to
2934 worry about when checking for integer overflow later.
2935 (x_check_image_size): New function, which checks for integer
2936 overflow issues inside X.
2937 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2938 This removes the need for a memory_full check.
2939 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2940 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2941 (xbm_read_bitmap_data): Change locals back to 'int', since
2942 their values must fit in 'int'.
2943 (xpm_load_image, png_load, tiff_load):
2944 Invoke x_create_x_image_and_pixmap earlier,
2945 to avoid much needless work if the image is too large.
2946 (tiff_load): Treat overly large images as if
2947 x_create_x_image_and_pixmap failed, not as malloc failures.
2948 (gs_load): Use x_check_image_size.
2950 * gtkutil.c: Omit integer casts.
2951 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2952 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2954 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2956 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2957 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2958 would wrongly return t on a 64-bit host.
2960 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2961 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2962 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2963 and therefore cause GCC to emit a bogus diagnostic in some cases.
2965 * image.c: Integer signedness and overflow and related fixes.
2966 This is not an exhaustive set of fixes, but it's time to
2967 record what I've got.
2968 (lookup_pixel_color, check_image_size): Remove redundant decls.
2969 (check_image_size): Don't assume that arbitrary EMACS_INT values
2970 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2971 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2972 (tiff_load, imagemagick_load_image):
2973 Check for overflow in size calculations.
2974 (x_create_x_image_and_pixmap): Remove unnecessary test for
2975 xmalloc returning NULL; that can't happen.
2976 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2977 (xpm_color_bucket): Use better integer hashing function.
2978 (xpm_cache_color): Don't possibly over-allocate memory.
2979 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2980 (gif_memory_source):
2981 Use ptrdiff_t, not int or size_t, to record sizes.
2982 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2983 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2984 either works, as we prefer signed integers.
2985 (tiff_read_from_memory, tiff_write_from_memory):
2986 Return tsize_t, not size_t, since that's what the TIFF API wants.
2987 (tiff_read_from_memory): Don't fail simply because the read would
2988 go past EOF; instead, return a short read.
2989 (tiff_load): Omit no-longer-needed casts.
2990 (Fimagemagick_types): Don't assume size fits into 'int'.
2992 Improve hashing quality when configured --with-wide-int.
2993 * fns.c (hash_string): New function, taken from sxhash_string.
2994 Do not discard information about ASCII character case; this
2995 discarding is no longer needed.
2996 (sxhash-string): Use it. Change sig to match it. Caller changed.
2997 * lisp.h: Declare it.
2998 * lread.c (hash_string): Remove, since we now use fns.c's version.
2999 The fns.c version returns a wider integer if --with-wide-int is
3000 specified, so this should help the quality of the hashing a bit.
3002 * emacs.c: Integer overflow minor fix.
3003 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3004 Define only if GNU_LINUX.
3005 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3007 * dispnew.c: Integer signedness and overflow fixes.
3008 Remove unnecessary forward decls, that were a maintenance hassle.
3009 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3011 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3012 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3013 (prepare_desired_row, line_draw_cost):
3014 Use int, not unsigned, where either works.
3015 (save_current_matrix, restore_current_matrix):
3016 Use ptrdiff_t, not size_t, where either works.
3017 (init_display): Check for overflow more accurately, and without
3018 relying on undefined behavior.
3020 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3021 Remove, replacing with the new symbols in lisp.h. All uses changed.
3022 * fileio.c (make_temp_name):
3023 * filelock.c (lock_file_1, lock_file):
3024 * xdisp.c (message_dolog):
3025 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3026 Use pMd etc. instead.
3027 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3028 replacing the pWIDE etc. symbols removed from editfns.c.
3030 * keyboard.h (num_input_events): Now uintmax_t.
3031 This is (very slightly) less likely to mess up due to wraparound.
3034 * buffer.c: Integer signedness fixes.
3035 (alloc_buffer_text, enlarge_buffer_text):
3036 Use ptrdiff_t rather than size_t when either will do, as we prefer
3039 * alloc.c: Integer signedness and overflow fixes.
3040 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3041 (__malloc_size_t): Default to size_t, not to int.
3042 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3043 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3044 Prefer ptrdiff_t to size_t when either would do, as we prefer
3046 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3047 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3048 Now const. Initialize with values that are in range even if char
3050 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3051 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3052 These functions do the right thing with sizes > 2**32.
3053 (check_depth): Now ptrdiff_t, not int.
3054 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3055 Adjust to new way of storing sizes. Check for size overflow bugs
3057 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3058 slightly wrong anyway, as it missed one instance of
3059 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3060 (refill_memory_reserve): Omit needless cast to size_t.
3061 (mark_object_loop_halt): Mark as externally visible.
3063 * xselect.c: Integer signedness and overflow fixes.
3064 (Fx_register_dnd_atom, x_handle_dnd_message):
3065 Use ptrdiff_t, not size_t, since we prefer signed.
3066 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3067 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3068 x_dnd_atoms_size and x_dnd_atoms_length.
3070 * doprnt.c: Prefer signed to unsigned when either works.
3072 * doprnt.c (doprnt):
3074 * xdisp.c (vmessage):
3075 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3076 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3077 prefer signed arithmetic to avoid comparison confusion.
3078 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3079 but is a bit tricky.
3081 Assume freestanding C89 headers, string.h, stdlib.h.
3082 * data.c, doprnt.c, floatfns.c, print.c:
3083 Include float.h unconditionally.
3084 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3085 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3086 * regex.c: Likewise for stddef.h, string.h.
3087 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3088 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3089 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3090 (STDC_HEADERS): Remove obsolete defines.
3091 * sysdep.c: Include limits.h unconditionally.
3093 Assume support for memcmp, memcpy, memmove, memset.
3094 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3095 * regex.c (memcmp, memcpy):
3096 Remove; we assume C89 now.
3098 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3099 (__malloc_safe_bcopy): Remove; no longer needed.
3101 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3102 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3103 well either way, and we prefer signed to unsigned.
3105 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3107 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3108 closes the connection while we're reading (bug#9182).
3110 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3112 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3113 are specified (Bug#9168).
3115 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3117 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3118 Found by GCC static checking and --with-wide-int on a 32-bit host.
3120 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3122 * xdisp.c (compute_display_string_pos): Fix logic of caching
3123 previous display string position. Initialize cached_prev_pos to
3124 -1. Fixes slow-down at the beginning of a buffer.
3126 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3128 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3129 for attrs[LFACE_FONTSET_INDEX].
3131 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3133 * xml.c (parse_region): Remove unused local
3134 that was recently introduced.
3136 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3138 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3139 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3141 * xdisp.c (move_it_in_display_line_to): Record the best matching
3142 position for TO_CHARPOS while scanning the line, and restore it on
3143 exit if none of the characters scanned was an exact match.
3144 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3145 when exact match is impossible due to invisible text, and the
3146 lines are truncated.
3148 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3150 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3153 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3155 Fix a significant slow-down of cursor motion with C-n, C-p,
3156 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3157 auto-repeat under bidi redisplay in fontified buffers.
3158 * xdisp.c (compute_stop_pos_backwards): New function.
3159 (next_element_from_buffer): Call compute_stop_pos_backwards to
3160 find a suitable prev_stop when we find ourselves before
3162 (reseat): Don't look for prev_stop, as that could mean a very long
3164 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3165 <cached_disp_overlay_modiff>: Cache for last found display string
3167 (compute_display_string_pos): Return the cached position if asked
3168 about the same buffer in the same area of character positions, and
3169 the buffer wasn't changed since the time the display string
3170 position was cached.
3172 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3174 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3175 is an integer, which is important for empty lines. (Bug#9149)
3177 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3179 * frame.c (Fmodify_frame_parameters): In tty case, update the
3180 default face if necessary (Bug#4238).
3182 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3184 * editfns.c (Fstring_to_char): No need to explain what a character
3185 is in the docstring (Bug#6576).
3187 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3189 * xml.c (parse_region): Make sure we always return a tree.
3191 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3193 * xml.c (parse_region): If a document contains only comments,
3196 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3198 * xml.c (make_dom): Return comments, too.
3200 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3203 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3204 and the surrounding thread.
3205 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3206 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3207 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3209 * s/openbsd.h (BROKEN_SIGIO): Define.
3210 * unexelf.c (unexec) [__OpenBSD__]:
3211 Don't update the .mdebug section of the Alpha COFF symbol table.
3213 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3215 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3218 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3220 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3221 This fixes some race conditions on the permissions of any newly
3224 * alloc.c (valid_pointer_p): Use pipe, not open.
3225 This fixes some permissions issues when debugging.
3227 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3228 If fchown fails to set both uid and gid, try to set just gid,
3229 as that is sometimes allowed. Adjust the file's mode to eliminate
3230 setuid or setgid bits that are inappropriate if fchown fails.
3232 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3234 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3235 to compare Lisp_Objects.
3236 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3237 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3238 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3240 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3242 * lread.c (read_integer): Unread even EOF character.
3243 (read1): Likewise. Properly record start position of symbol.
3245 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3246 symbol character follows.
3248 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3250 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3251 This works around a problem with the previous change to Fcopy_file.
3252 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3253 and without this change, GCC might complain about discarding
3254 fchown's return value.
3256 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3258 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3260 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3262 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3264 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3266 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3267 it's used from the C level.
3269 * process.c: Use the same condition for POLL_FOR_INPUT in both
3270 keyboard.c and process.c (bug#1858).
3272 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3274 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3275 (Fgnutls_boot): Use it.
3277 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3279 * doc.c (Fsubstitute_command_keys): Revert last change.
3281 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3283 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3284 quotes the next character, and doesn't affect other longer
3285 sequences (bug#8935).
3287 * lread.c (syms_of_lread): Clarify that is isn't only
3288 `eval-buffer' and `eval-defun' that's affected by
3289 `lexical-binding' (bug#8460).
3291 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3293 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3294 bidi redisplay when a line includes both an image and is truncated.
3296 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3298 Fix minor problems found by static checking.
3299 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3300 (elsz): Now a signed constant, not a size_t var. We prefer signed
3301 types to unsigned, to avoid integer comparison confusion. Without
3302 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3303 "cannot optimize loop, the loop counter may overflow", a symptom
3305 * indent.c (Fvertical_motion): Mark locals as initialized.
3306 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3308 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3310 * search.c (Fre_search_backward): Mention `case-fold-search' in
3311 all the re_search_* functions (bug#8138).
3313 * keyboard.c (Fopen_dribble_file): Document when the file is
3316 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3318 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3321 Support bidi reordering of display and overlay strings.
3322 * xdisp.c (compute_display_string_pos)
3323 (compute_display_string_end): Accept additional argument STRING.
3324 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3325 (reseat_to_string): Initialize bidi_it->string.s and
3326 bidi_it->string.schars.
3327 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3328 NULL (avoids a crash in bidi_paragraph_init).
3329 Initialize itb.string.lstring.
3330 (init_iterator): Call bidi_init_it only of a valid
3331 buffer position was specified. Initialize paragraph_embedding to
3333 (reseat_to_string): Initialize the bidi iterator.
3334 (display_string): If we need to ignore text properties of
3335 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3336 original value of -1 will not work with bidi.)
3337 (compute_display_string_pos): First arg is now struct
3338 `text_pos *'; all callers changed. Support display properties on
3340 (compute_display_string_end): Support display properties on Lisp
3342 (init_iterator, reseat_1, reseat_to_string): Initialize the
3343 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3344 when iterating on a string not from display properties).
3345 (compute_display_string_pos, compute_display_string_end):
3346 Fix calculation of the object to scan. Fixes an error when using
3348 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3349 base_level_stop; instead, set base_level_stop to BEGV.
3350 Fixes crashes in vertical-motion.
3351 (next_element_from_buffer): Improve commentary for when
3352 the iterator is before prev_stop.
3353 (init_iterator): Initialize bidi_p from the default value of
3354 bidi-display-reordering, not from buffer-local value. Use the
3355 buffer-local value only if initializing for buffer iteration.
3356 (handle_invisible_prop): Support invisible properties on strings
3357 that are being bidi-reordered.
3358 (set_iterator_to_next): Support bidi reordering of C strings and
3360 (next_element_from_string): Support bidi reordering of Lisp
3362 (handle_stop_backwards): Support Lisp strings as well.
3363 (display_string): Support display of R2L glyph rows.
3364 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3365 (init_iterator): Don't initialize it->bidi_p for strings
3367 (reseat_to_string): Initialize it->bidi_p for strings here.
3368 (next_element_from_string, next_element_from_c_string)
3369 (next_element_from_buffer): Add xassert's for correspondence
3370 between IT's object being iterated and it->bidi_it.string
3372 (face_before_or_after_it_pos): Support bidi iteration.
3373 (next_element_from_c_string): Handle the case of the first string
3374 character that is not the first one in the visual order.
3375 (get_visually_first_element): New function, refactored from common
3376 parts of next_element_from_buffer, next_element_from_string, and
3377 next_element_from_c_string.
3378 (tool_bar_lines_needed, redisplay_tool_bar)
3379 (display_menu_bar): Force left-to-right direction. Add a FIXME
3380 comment for making that be controlled by a user option.
3381 (push_it, pop_it): Save and restore the state of the
3382 bidi iterator. Save and restore the bidi_p flag.
3383 (pop_it): Iterate out of display property for string iteration as
3385 (iterate_out_of_display_property): Support iteration over strings.
3386 (handle_single_display_spec): Set up it->bidi_it for iteration
3387 over a display string, and call bidi_init_it.
3388 (handle_single_display_spec, next_overlay_string)
3389 (get_overlay_strings_1, push_display_prop): Set up the bidi
3390 iterator for displaying display or overlay strings.
3391 (forward_to_next_line_start): Don't use the shortcut if
3393 (back_to_previous_visible_line_start): If handle_display_prop
3394 pushed the iterator stack, restore the internal state of the bidi
3395 iterator by calling bidi_pop_it same number of times.
3396 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3397 and we are bidi-iterating, don't decrement the iterator position;
3398 instead, set the first_elt flag in the bidi iterator, to produce
3400 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3401 (push_display_prop): xassert that we are iterating a buffer.
3402 (push_it, pop_it): Save and restore paragraph_embedding member.
3403 (handle_single_display_spec, next_overlay_string)
3404 (get_overlay_strings_1, reseat_1, reseat_to_string)
3405 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3406 correctly. Don't assume unibyte strings are not bidi-reordered.
3407 (compute_display_string_pos)
3408 (compute_display_string_end): Fix handling the case of C string.
3409 (push_it, pop_it): Save and restore from_disp_prop_p.
3410 (handle_single_display_spec, push_display_prop): Set the
3411 from_disp_prop_p flag.
3412 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3413 (pop_it): Call iterate_out_of_display_property only if we are
3414 popping after iteration over a string that came from a display
3415 property. Fix a typo in popping stretch info. Add an assertion
3416 for verifying that the iterator position is in sync with the bidi
3418 (handle_single_display_spec, get_overlay_strings_1)
3419 (push_display_prop): Fix initialization of paragraph direction for
3420 string when that of the parent object is not yet determined.
3421 (reseat_1): Call bidi_init_it to resync the bidi
3422 iterator with IT's position. (Bug#7616)
3423 (find_row_edges): If ROW->start.pos gives position
3424 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3425 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3426 Reset the from_disp_prop_p flag.
3427 (SAVE_IT, RESTORE_IT): New macros.
3428 (pos_visible_p, face_before_or_after_it_pos)
3429 (back_to_previous_visible_line_start)
3430 (move_it_in_display_line_to, move_it_in_display_line)
3431 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3432 (try_scrolling, redisplay_window, display_line): Use them when
3433 saving a temporary copy of the iterator and restoring it back.
3434 (back_to_previous_visible_line_start, reseat_1)
3435 (init_iterator): Empty the bidi cache "stack".
3436 (move_it_in_display_line_to): If iterator ended up at
3437 EOL, but we never saw any buffer positions smaller than
3438 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3439 motion in bidi-reordered lines.
3440 (move_it_in_display_line_to): Record prev_method and prev_pos
3441 immediately before the call to set_iterator_to_next. Fixes cursor
3442 motion in bidi-reordered lines with stretch glyphs and strings
3443 displayed in margins. (Bug#8133) (Bug#8867)
3444 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3446 (pos_visible_p): Support positions in bidi-reordered lines.
3447 Save and restore bidi cache.
3449 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3450 (bidi_paragraph_info): Delete unused struct.
3451 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3452 (bidi_cache_start): New variable.
3453 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3455 (bidi_cache_fetch_state, bidi_cache_search)
3456 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3457 (bidi_cache_find, bidi_peek_at_next_level)
3458 (bidi_level_of_next_char, bidi_find_other_level_edge)
3459 (bidi_move_to_visually_next): Compare cache index with
3460 bidi_cache_start rather than with zero.
3461 (bidi_fetch_char): Accept new argument STRING; all callers
3462 changed. Support iteration over a string. Support strings with
3463 display properties. Support unibyte strings. Fix the type of
3464 `len' according to what STRING_CHAR_AND_LENGTH expects.
3465 (bidi_paragraph_init, bidi_resolve_explicit_1)
3466 (bidi_resolve_explicit, bidi_resolve_weak)
3467 (bidi_level_of_next_char, bidi_move_to_visually_next):
3468 Support iteration over a string.
3469 (bidi_set_sor_type, bidi_resolve_explicit_1)
3470 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3471 can now be zero (for strings); special values 0 and -1 were
3472 changed to -1 and -2, respectively.
3473 (bidi_char_at_pos): New function.
3474 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3475 Call it instead of FETCH_MULTIBYTE_CHAR.
3476 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3477 initialized to valid values.
3478 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3480 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3481 the test for valid cached positions. Fix the logic for looking up
3482 the sentinel state in the cache. GCPRO the Lisp string we are
3484 (bidi_push_it, bidi_pop_it): New functions.
3485 (bidi_initialize): Initialize the bidi cache start stack pointer.
3486 (bidi_cache_ensure_space): New function, refactored from part of
3487 bidi_cache_iterator_state. Don't assume the required size is just
3488 one BIDI_CACHE_CHUNK away.
3489 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3490 (bidi_count_bytes, bidi_char_at_pos): New functions.
3491 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3492 always valid if bidi_cache_idx is valid.
3493 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3494 is valid if it's going to be used.
3495 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3496 (bidi_cache_fetch_state, bidi_cache_search)
3497 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3498 (bidi_cache_iterator_state, bidi_cache_find)
3499 (bidi_find_other_level_edge, bidi_cache_start_stack):
3500 All variables related to cache indices are now EMACS_INT.
3502 * dispextern.h (struct bidi_string_data): New structure.
3503 (struct bidi_it): New member `string'. Make flag members be 1-bit
3504 fields, and put them last in the struct.
3505 (compute_display_string_pos, compute_display_string_end):
3507 (bidi_push_it, bidi_pop_it): Add prototypes.
3508 (struct iterator_stack_entry): New members bidi_p,
3509 paragraph_embedding, and from_disp_prop_p.
3510 (struct it): Member bidi_p is now a bit field 1 bit wide.
3511 (bidi_shelve_cache, bidi_unshelve_cache):
3514 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3515 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3516 and vector-like objects.
3518 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3519 cache around display iteration.
3521 * window.c (Fwindow_end, window_scroll_pixel_based)
3522 (displayed_window_lines, Frecenter): Save and restore the bidi
3523 cache around display iteration.
3525 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3527 * editfns.c (Fdelete_region): Clarify the use of the named
3528 parameters (bug#6788).
3530 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3532 * indent.c (Fvertical_motion): Set and restore w->pointm when
3533 saving and restoring the window's buffer (Bug#9006).
3535 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3537 * editfns.c (Fstring_to_char): Clarify just what is returned
3538 (bug#6576). Text by Eli Zaretskii.
3540 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3542 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3544 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3546 * buffer.c (mmap_find): Fix a typo.
3548 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3550 Fix execution of x selection hooks.
3551 * xselect.c (Qx_lost_selection_functions)
3552 (Qx_sent_selection_functions): New vars.
3553 (syms_of_xselect): DEFSYM them.
3554 (x_handle_selection_request): Pass Qx_sent_selection_functions
3555 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3556 (x_handle_selection_clear,x_clear_frame_selections):
3557 Pass Qx_lost_selection_functions rather than
3558 Vx_lost_selection_functions to Frun_hook_with_args.
3560 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3562 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3563 The old code sometimes used this field without initializing it.
3565 * alloc.c (gc_sweep): Don't read past end of array.
3566 In theory, the old code could also have corrupted Emacs internals,
3567 though it'd be very unlikely.
3569 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3571 * character.c (Fcharacterp): Don't advertise optional ignored
3572 argument. (Bug#4026)
3574 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3576 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3579 * window.c (Fset_window_start): Doc fix (bug#4199).
3580 (Fset_window_hscroll): Ditto.
3582 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3584 Fix minor new problems caught by GCC 4.6.1.
3585 * term.c (init_tty): Remove unused local.
3586 * xsettings.c (store_monospaced_changed): Define this function only
3587 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3590 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3592 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3594 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3596 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3597 are the mini-buffer and the echo area (bug#3320).
3599 * term.c (init_tty): Remove support for supdup, c10 and perq
3600 terminals, which are no longer supported (bug#1482).
3602 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3604 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3606 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3608 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3609 for non-popups (Bug#3642).
3611 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3613 * alloc.c (reset_malloc_hooks): Protoize.
3614 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3615 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3616 * cm.c (losecursor): Likewise.
3617 * data.c (fmod): Likewise.
3618 * dispnew.c (swap_glyphs_in_rows): Likewise.
3619 * emacs.c (memory_warning_signal): Likewise.
3620 * floatfns.c (float_error): Likewise.
3621 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3622 (otf_open, font_otf_capability, generate_otf_features)
3623 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3625 * image.c (pbm_read_file): Likewise.
3626 * indent.c (string_display_width): Likewise.
3627 * intervals.c (check_for_interval, search_for_interval)
3628 (inc_interval_count, count_intervals, root_interval)
3629 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3630 * lread.c (defalias): Likewise.
3631 * ralloc.c (r_alloc_check): Likewise.
3632 * regex.c (set_image_of_range_1, set_image_of_range)
3633 (regex_grow_registers): Likewise.
3634 * sysdep.c (strerror): Likewise.
3635 * termcap.c (valid_filename_p, tprint, main): Likewise.
3636 * tparam.c (main): Likewise.
3637 * unexhp9k800.c (run_time_remap, save_data_space)
3638 (update_file_ptrs, read_header, write_header, calculate_checksum)
3639 (copy_file, copy_rest, display_header): Likewise.
3640 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3642 * xdisp.c (check_it): Likewise.
3643 * xfaces.c (register_color, unregister_color, unregister_colors):
3645 * xfns.c (print_fontset_result): Likewise.
3646 * xrdb.c (member, fatal, main): Likewise.
3648 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3650 Fix minor problems found by static checking (Bug#9031).
3651 * chartab.c (char_table_set_range, map_sub_char_table):
3652 Remove unused locals.
3653 (uniprop_table): Now static.
3654 * composite.c (_work_char): Remove unused static var.
3656 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3658 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3660 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3662 * gtkutil.c (qttip_cb): Remove code without function.
3664 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3666 * w32.c (pthread_sigmask): New stub.
3668 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3670 Use pthread_sigmask, not sigprocmask (Bug#9010).
3671 sigprocmask is portable only for single-threaded applications, and
3672 Emacs can be multi-threaded when it uses GTK.
3673 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3675 * callproc.c (Fcall_process):
3676 * process.c (create_process):
3677 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3678 Use pthread_sigmask, not sigprocmask.
3680 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3682 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3683 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3686 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3688 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3689 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3690 (xg_hide_tooltip): Fix comment.
3692 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3693 in registerServicesMenuSendTypes.
3694 (validRequestorForSendType): Don't check ns_return_types.
3696 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3699 2011-07-08 Jason Rumney <jasonr@gnu.org>
3701 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3702 SH_SHOW for hidden windows (Bug#5482).
3704 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3705 frame struct members of non-existent frames (Bug#6284).
3707 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3709 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3710 variable firstTime not needed on OSX >= 10.6.
3711 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3712 >= 10.5. Use setKnobProportion, setDoubleValue.
3714 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3715 (MAC_OS_X_VERSION_10_5): Define if not defined.
3716 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3717 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3718 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3720 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3721 cString and lossyCString on OSX >= 10.4
3723 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3724 sizeToFit on OSX >= 10.2.
3726 * nsimage.m (allocInitFromFile): Don't use deprecated method
3727 bestRepresentationForDevice on OSX >= 10.6.
3729 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3732 * emacs.c: Declare unexec_init_emacs_zone.
3734 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3736 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3738 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3739 on svcsMenu (Bug#8842).
3741 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3743 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3745 * nsterm.m (QUTF8_STRING): Declare.
3746 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3747 (validRequestorForSendType): Return type is (id).
3748 Change indexOfObjectIdenticalTo to indexOfObject.
3749 Check if we have local selection before returning self (Bug#8842).
3750 (writeSelectionToPasteboard): Put local selection into paste board
3751 if we have a local selection (Bug#8842).
3752 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3754 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3755 (ns_get_local_selection): Declare.
3757 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3759 * keymap.c (describe_map_tree): Don't insert a double newline at
3760 the end of the buffer (bug#1169) and return whether we inserted
3763 * callint.c (Fcall_interactively): Change "reading args" to
3764 "providing args" to try to clarify what it does (bug#1010).
3766 2011-07-07 Kenichi Handa <handa@m17n.org>
3768 * composite.c (composition_compute_stop_pos): Ignore a static
3769 composition starting before CHARPOS (Bug#8915).
3771 * xdisp.c (handle_composition_prop): Likewise.
3773 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3775 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3778 2011-07-07 Kenichi Handa <handa@m17n.org>
3780 * character.h (unicode_category_t): New enum type.
3782 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3783 (Qchar_code_property_table): New variable.
3784 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3785 (UNIPROP_COMPRESSED_FORM_P): New macros.
3786 (char_table_ascii): Uncompress the compressed values.
3787 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3788 Uncompress the compressed values.
3789 (sub_char_table_ref_and_range): Likewise.
3790 (char_table_ref_and_range): Uncompress the compressed values.
3791 (sub_char_table_set): New arg is_uniprop. Callers changed.
3792 Uncompress the compressed values.
3793 (sub_char_table_set_range): Args changed. Callers changed.
3794 (char_table_set_range): Adjuted for the above change.
3795 (map_sub_char_table): Delete args default_val and parent. Add arg
3796 top. Give decoded values to a Lisp function.
3797 (map_char_table): Adjust for the above change. Give decoded
3798 values to a Lisp function. Gcpro more variables.
3799 (uniprop_table_uncompress)
3800 (uniprop_decode_value_run_length): New functions.
3801 (uniprop_decoder, uniprop_decoder_count): New variables.
3802 (uniprop_get_decoder, uniprop_encode_value_character)
3803 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3805 (uniprop_encoder, uniprop_encoder_count): New variables.
3806 (uniprop_get_encoder, uniprop_table)
3807 (Funicode_property_table_internal, Fget_unicode_property_internal)
3808 (Fput_unicode_property_internal): New functions.
3809 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3810 Sunicode_property_table_internal, Sget_unicode_property_internal,
3811 and Sput_unicode_property_internal. Defvar_lisp
3812 char-code-property-alist.
3814 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3815 Vunicode_category_table.
3817 * font.c (font_range): Adjust for the change of
3818 Vunicode_category_table.
3820 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3822 * m/iris4d.h: Remove file, move contents ...
3823 * s/irix6-5.h: ... here.
3825 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3827 Remove unportable assumption about struct layout (Bug#8884).
3828 * alloc.c (mark_buffer):
3829 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3830 (clone_per_buffer_values): Don't assume that
3831 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3832 This isn't true in general, and it's particularly not true
3833 if Emacs is configured with --with-wide-int.
3834 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3835 New macros, used in the buffer.c change.
3837 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3839 * xsettings.c: Use both GConf and GSettings if both are available.
3840 (store_config_changed_event): Add comment.
3841 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3842 (store_tool_bar_style_changed): New functions.
3843 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3844 (struct xsettings): Move font inside HAVE_XFT.
3845 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3846 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3847 Move inside HAVE_XFT.
3848 (something_changed_gsettingsCB): Rename from something_changedCB.
3849 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3851 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3852 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3853 (something_changed_gconfCB): Rename from something_changedCB.
3854 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3855 (parse_settings): Move check for font inside HAVE_XFT.
3856 (read_settings, apply_xft_settings): Add comment.
3857 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3858 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3859 call store_font_name_changed.
3860 (xft_settings_event): Add comment.
3861 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3862 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3863 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3864 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3865 (xsettings_initialize): Call init_gsettings last.
3866 (xsettings_get_system_font, xsettings_get_system_normal_font):
3869 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3871 Random fixes. E.g., (random) never returned negative values.
3872 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3873 subseconds part to the entropy, as that's a bit more random.
3874 Prefer signed to unsigned, since the signedness doesn't matter and
3875 in general we prefer signed. When given a limit, use a
3876 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3877 latter isn't right if USE_2_TAGS_FOR_INTS.
3878 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3879 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3881 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3883 * textprop.c (text_property_stickiness):
3884 Obey Vtext_property_default_nonsticky.
3885 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3886 * w32fns.c (syms_of_w32fns):
3887 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3889 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3891 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3892 This is more efficient than Ffile_directory_p and avoids a minor race.
3894 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3896 * buffer.c (Foverlay_put): Say what the return value is
3899 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3900 is a directory before asking whether to use the file name
3902 (barf_or_query_if_file_exists): Make the "File is a directory"
3903 error be more correct.
3905 * fns.c (Frequire): Remove the mention of the .gz files, since
3906 that's installation-specific, but keep the mention of
3907 `get-load-suffixes'.
3909 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3911 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3912 Report string overflow if the output is too long.
3914 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3916 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3917 (syms_of_gnutls): Remove duplicate DEFSYM for
3918 Qgnutls_bootprop_verify_hostname_error, an error for
3919 Qgnutls_bootprop_verify_error (which is no longer used).
3921 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3922 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3923 Also (re)move comments that are misplaced or no longer relevant.
3925 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3927 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3929 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3931 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3932 and background color parameters if they have been changed.
3934 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3936 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3938 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3940 * xsettings.c (SYSTEM_FONT): Define only when used.
3941 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3943 * keymap.c (access_keymap_1): Now static.
3945 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3947 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3948 leave any prefix arg for the up event (Bug#1586).
3950 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3952 * lread.c (syms_of_lread): Mention single symbols defined by
3953 `defvar' or `defconst' (bug#7154).
3955 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3956 (Frequire): Mention get-load-suffixes.
3958 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3960 * window.h (window): Remove clone_number slot.
3961 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3963 (make_parent_window, make_window, saved_window)
3964 (Fset_window_configuration, save_window_save): Don't deal with
3966 * buffer.c (Qclone_number): Remove declaration.
3967 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3969 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3971 Add multiple inheritance to keymaps.
3972 * keymap.c (Fmake_composed_keymap): New function.
3973 (Fset_keymap_parent): Simplify.
3974 (fix_submap_inheritance): Remove.
3975 (access_keymap_1): New function extracted from access_keymap to handle
3976 embedded parents and handle lists of maps.
3977 (access_keymap): Use it.
3978 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3979 (Fcopy_keymap): Handle embedded parents.
3980 (Fcommand_remapping, define_as_prefix): Simplify.
3981 (Fkey_binding): Simplify.
3982 (syms_of_keymap): Move minibuffer-local-completion-map,
3983 minibuffer-local-filename-completion-map,
3984 minibuffer-local-must-match-map, and
3985 minibuffer-local-filename-must-match-map to Elisp.
3986 (syms_of_keymap): Defsubr make-composed-keymap.
3987 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3988 (parse_menu_item): Trivial simplification.
3990 2011-07-01 Glenn Morris <rgm@gnu.org>
3992 * Makefile.in (SETTINGS_LIBS): Fix typo.
3994 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3996 * coding.c (Fencode_coding_string): Record the last coding system
3997 used, as the function doc string says (bug#8738).
3999 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4001 * xsettings.c (store_monospaced_changed): Take new font as arg and
4002 check for change against current_mono_font.
4003 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4004 (emacs_settings_constructor, emacs_settings_get_property)
4005 (emacs_settings_set_property, emacs_settings_class_init)
4006 (emacs_settings_init, gsettings_obj): Remove.
4007 (something_changedCB): New function for HAVE_GSETTINGS.
4008 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4009 with value as argument.
4010 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4011 g_settings_new (Bug#8967). Do not create gsettings_obj.
4012 Remove calls to g_settings_bind. Connect something_changedCB to
4015 * xgselect.c: Add defined (HAVE_GSETTINGS).
4016 (xgselect_initialize): Ditto.
4018 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4019 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4022 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4024 * eval.c (struct backtrace): Simplify and port the data structure.
4025 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4026 signed bit field, as this assumption is not portable and it makes
4027 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4028 "char debug_on_exit : 1" as this is not portable either; instead,
4029 use the portable "unsigned int debug_on_exit : 1". Remove unused
4030 member evalargs. Remove obsolete comments about cc bombing out.
4032 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4034 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4035 Let HAVE_GSETTINGS override HAVE_GCONF.
4036 (store_monospaced_changed): New function.
4037 (EMACS_SETTINGS): A new type derived from GObject to handle
4038 GSettings notifications.
4039 (emacs_settings_constructor, emacs_settings_get_property)
4040 (emacs_settings_set_property, emacs_settings_class_init):
4042 (gsettings_client, gsettings_obj): New variables.
4043 (GSETTINGS_SCHEMA): New define.
4044 (something_changedCB): Call store_monospaced_changed.
4045 (init_gsettings): New function.
4046 (xsettings_initialize): Call init_gsettings.
4047 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4050 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4053 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4055 * window.c (resize_root_window, grow_mini_window)
4056 (shrink_mini_window): Rename Qresize_root_window to
4057 Qwindow_resize_root_window and Qresize_root_window_vertically to
4058 Qwindow_resize_root_window_vertically.
4060 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4062 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4064 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4066 * makefile.w32-in: Redesign dependencies so they reflect more
4067 clearly which files are directly included by each source file,
4068 and not through other includes.
4070 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4072 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4073 (sort_overlays, overlay_strings): When an overlay's clone number
4074 matches the window's clone number process the overlay even if
4075 the overlay's window property doesn't match the current window.
4077 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4078 (Fwindow_hchild): Rename to Fwindow_left_child.
4079 (Fwindow_next): Rename to Fwindow_next_sibling.
4080 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4081 (resize_window_check): Rename to window_resize_check.
4082 (resize_window_apply): Rename to window_resize_apply.
4083 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4084 (Fdelete_other_windows_internal, resize_frame_windows)
4085 (Fsplit_window_internal, Fdelete_window_internal)
4086 (grow_mini_window, shrink_mini_window)
4087 (Fresize_mini_window_internal): Fix callers accordingly.
4089 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4091 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4092 (emacs_fixed_set_min_size): Remove.
4093 (emacs_fixed_new): Take frame as argument.
4095 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4096 (_EmacsFixedPrivate): Remove minwidth/height.
4097 Add struct frame *f.
4098 (emacs_fixed_init): Initialize priv->f.
4099 (get_parent_class, emacs_fixed_set_min_size): Remove.
4100 (emacs_fixed_new): Set priv->f to argument.
4101 (emacs_fixed_get_preferred_width)
4102 (emacs_fixed_get_preferred_height): Use min_width/height from
4103 frames size_hint to set minimum and natural (Bug#8919).
4104 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4105 and use min_width/height from frames size_hint to set
4106 min_width/height (Bug#8919).
4108 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4109 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4112 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4114 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4115 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4118 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4120 * process.c (wait_reading_process_output): Bypass select if
4121 waiting for a cell while ignoring keyboard input, and input is
4122 pending. Suggested by Jan Djärv (Bug#8869).
4124 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4126 Use gnulib's dup2 module instead of rolling our own.
4127 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4129 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4131 * dispnew.c (scrolling_window): Before scrolling, turn off a
4132 mouse-highlight in the window being scrolled.
4134 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4136 Move DEFSYM to lisp.h and use everywhere.
4138 * character.h (DEFSYM): Move declaration...
4139 * lisp.h (DEFSYM): ...here.
4145 * w32select.c: Don't include character.h.
4147 * alloc.c (syms_of_alloc):
4148 * buffer.c (syms_of_buffer):
4149 * bytecode.c (syms_of_bytecode):
4150 * callint.c (syms_of_callint):
4151 * casefiddle.c (syms_of_casefiddle):
4152 * casetab.c (init_casetab_once):
4153 * category.c (init_category_once, syms_of_category):
4154 * ccl.c (syms_of_ccl):
4155 * cmds.c (syms_of_cmds):
4156 * composite.c (syms_of_composite):
4157 * dbusbind.c (syms_of_dbusbind):
4158 * dired.c (syms_of_dired):
4159 * dispnew.c (syms_of_display):
4160 * doc.c (syms_of_doc):
4161 * editfns.c (syms_of_editfns):
4162 * emacs.c (syms_of_emacs):
4163 * eval.c (syms_of_eval):
4164 * fileio.c (syms_of_fileio):
4165 * fns.c (syms_of_fns):
4166 * frame.c (syms_of_frame):
4167 * fringe.c (syms_of_fringe):
4168 * insdel.c (syms_of_insdel):
4169 * keymap.c (syms_of_keymap):
4170 * lread.c (init_obarray, syms_of_lread):
4171 * macros.c (syms_of_macros):
4172 * msdos.c (syms_of_msdos):
4173 * print.c (syms_of_print):
4174 * process.c (syms_of_process):
4175 * search.c (syms_of_search):
4176 * sound.c (syms_of_sound):
4177 * syntax.c (init_syntax_once, syms_of_syntax):
4178 * terminal.c (syms_of_terminal):
4179 * textprop.c (syms_of_textprop):
4180 * undo.c (syms_of_undo):
4181 * w32.c (globals_of_w32):
4182 * window.c (syms_of_window):
4183 * xdisp.c (syms_of_xdisp):
4184 * xfaces.c (syms_of_xfaces):
4185 * xfns.c (syms_of_xfns):
4186 * xmenu.c (syms_of_xmenu):
4187 * xsettings.c (syms_of_xsettings):
4188 * xterm.c (syms_of_xterm): Use DEFSYM.
4190 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4192 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4194 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4196 Integer and buffer overflow fixes (Bug#8873).
4198 * print.c (printchar, strout): Check for string overflow.
4199 (PRINTPREPARE, printchar, strout):
4200 Don't set size unless allocation succeeds.
4202 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4203 for sizes. Check for string overflow more accurately.
4204 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4206 * macros.c: Integer and buffer overflow fixes.
4207 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4208 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4209 Use ptrdiff_t, not int, for sizes.
4210 Don't increment bufsize until after realloc succeeds.
4211 Check for size-calculation overflow.
4212 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4214 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4216 * lread.c: Integer overflow fixes.
4217 (read_integer): Radix is now EMACS_INT, not int,
4218 to improve quality of diagnostics for out-of-range radices.
4219 Calculate buffer size correctly for out-of-range radices.
4220 (read1): Check for integer overflow in radices, and in
4221 read-circle numbers.
4222 (read_escape): Avoid int overflow.
4223 (Fload, openp, read_buffer_size, read1)
4224 (substitute_object_recurse, read_vector, read_list, map_obarray):
4225 Use ptrdiff_t, not int, for sizes.
4226 (read1): Use EMACS_INT, not int, for sizes.
4227 Check for size overflow.
4229 * image.c (cache_image): Check for size arithmetic overflow.
4231 * lread.c: Integer overflow issues.
4232 (saved_doc_string_size, saved_doc_string_length)
4233 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4234 Now ptrdiff_t, not int.
4235 (read1): Don't assume doc string length fits in int. Check for
4236 out-of-range doc string lengths.
4237 (read_list): Don't assume file position fits in int.
4238 (read_escape): Check for hex character overflow.
4240 2011-06-22 Leo Liu <sdl.web@gmail.com>
4242 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4243 Move to minibuffer.el.
4245 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4247 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4248 The following patches are for when GLYPH_DEBUG && !XASSERT.
4249 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4250 * dispnew.c (flush_stdout):
4251 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4252 Mark as externally visible.
4253 * dispnew.c (check_window_matrix_pointers): Now static.
4254 * dispnew.c (window_to_frame_vpos):
4255 * xfns.c (unwind_create_frame):
4256 * xterm.c (x_check_font): Remove unused local.
4257 * scroll.c (CHECK_BOUNDS):
4258 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4259 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4260 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4261 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4262 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4264 (debug_method_add): Use va_list and vsprintf rather than relying
4265 on undefined behavior with wrong number of arguments.
4266 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4267 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4268 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4269 since we're not interested in debugging glyphs with old libraries.
4270 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4271 GCC 4.6.0's static checking.
4273 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4275 Integer overflow and signedness fixes (Bug#8873).
4276 A few related buffer overrun fixes, too.
4278 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4280 * dispextern.h (struct face.stipple):
4281 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4282 (x_bitmap_mask, x_allocate_bitmap_record)
4283 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4284 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4285 (x_create_bitmap_from_xpm_data):
4286 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4287 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4289 * xfaces.c (load_pixmap):
4290 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4291 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4292 (.bitmaps_last, struct x_output.icon_bitmap):
4293 Use ptrdiff_t, not int, for bitmap indexes.
4294 (x_allocate_bitmap_record): Check for size overflow.
4295 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4297 Use ptrdiff_t, not int, for overlay counts.
4298 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4299 * editfns.c (overlays_around, get_pos_property):
4300 * textprop.c (get_char_property_and_overlay):
4301 * xdisp.c (next_overlay_change, note_mouse_highlight):
4302 * xfaces.c (face_at_buffer_position):
4303 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4304 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4305 (Fnext_overlay_change, Fprevious_overlay_change)
4306 (mouse_face_overlay_overlaps, Foverlays_in):
4307 Use ptrdiff_t, not int, for sizes.
4308 (overlays_at, overlays_in): Check for size-calculation overflow.
4310 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4312 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4313 (x_session_initialize): Do not assume string length fits in int.
4315 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4316 This is unlikely, but can occur if DPI is outlandish.
4318 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4319 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4321 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4322 * xrdb.c (magic_file_p, search_magic_path):
4323 Omit last arg SUFFIX; it was always 0. All callers changed.
4324 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4326 * xfont.c (xfont_match): Avoid need for strlen.
4328 * xfns.c: Don't assume strlen fits in int.
4329 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4331 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4332 not unsigned long, as we prefer signed integers. All callers changed.
4333 Detect integer overflow in repeat count.
4334 (message_dolog): Don't assume print length fits in 39 bytes.
4335 (display_mode_element): Don't assume strlen fits in int.
4337 * termcap.c: Don't assume sizes fit in int and never overflow.
4338 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4339 (gobble_line): Check for size-calculation overflow.
4341 * minibuf.c (Fread_buffer):
4342 * lread.c (intern, intern_c_string):
4343 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4344 Don't assume string length fits in int.
4346 * keyboard.c (parse_tool_bar_item):
4347 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4349 * font.c: Don't assume string length fits in int.
4350 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4351 Use ptrdiff_t, not int.
4352 (font_intern_prop): Don't assume string length fits in int.
4353 Don't assume integer property fits in fixnum.
4354 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4356 * filelock.c: Fix some buffer overrun and integer overflow issues.
4357 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4358 Reformulate so as not to need the command string.
4359 Invoke gzip -cd rather than gunzip, as it's more portable.
4360 (lock_info_type, lock_file_1, lock_file):
4361 Don't assume pid_t and time_t fit in unsigned long.
4362 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4363 (current_lock_owner): Prefer signed type for sizes.
4364 Use memcpy, not strncpy, where memcpy is what is really wanted.
4365 Don't assume (via atoi) that time_t and pid_t fit in int.
4366 Check for time_t and/or pid_t out of range, e.g., via a network share.
4367 Don't alloca where an auto var works fine.
4369 * fileio.c: Fix some integer overflow issues.
4370 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4371 Don't assume string length fits in int.
4372 (directory_file_name): Don't assume string length fits in long.
4373 (make_temp_name): Don't assume pid fits in int, or that its print
4374 length is less than 20.
4376 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4378 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4380 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4382 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4383 We prefer signed integers, even for size calculations.
4385 * emacs.c: Don't assume string length fits in 'int'.
4386 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4387 (main): Don't invoke strlen when not needed.
4389 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4390 (XD_DEBUG_MESSAGE): Don't waste a byte.
4392 * callproc.c (getenv_internal_1, getenv_internal)
4394 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4396 * lread.c (invalid_syntax): Omit length argument.
4397 All uses changed. This doesn't fix a bug, but it simplifies the
4398 code away from its former Hollerith-constant appearance, and it's
4399 one less 'int' to worry about when looking at integer-overflow issues.
4400 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4402 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4403 This didn't break anything, but it didn't help either.
4404 It's confusing to put a bogus integer in a place where the actual
4405 value does not matter.
4406 (LIST_END_P): Remove unused macro and its bogus comment.
4407 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4409 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4410 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4412 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4413 We prefer signed types, and the value cannot exceed the EMACS_INT
4414 range anyway (because otherwise the length would not be representable).
4415 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4416 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4417 This avoids a GCC warning when WIDE_EMACS_INT.
4419 * indent.c (sane_tab_width): New function.
4420 (current_column, scan_for_column, Findent_to, position_indentation)
4421 (compute_motion): Use it. This is just for clarity.
4422 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4424 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4426 * lisp.h (lint_assume): New macro.
4427 * composite.c (composition_gstring_put_cache):
4428 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4430 * editfns.c, insdel.c:
4431 Omit unnecessary forward decls, to simplify future changes.
4433 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4435 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4437 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4438 Use much-faster test for byte-length change.
4439 Don't assume string byte-length fits in 'int'.
4440 Check that character arg fits in 'int'.
4441 (mapcar1): Declare byte as byte, for clarity.
4443 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4445 * fns.c (concat): Catch string overflow earlier.
4446 Do not rely on integer wraparound.
4448 * dispextern.h (struct it.overlay_strings_charpos)
4449 (struct it.selective): Now EMACS_INT, not int.
4450 * xdisp.c (forward_to_next_line_start)
4451 (back_to_previous_visible_line_start)
4452 (reseat_at_next_visible_line_start, next_element_from_buffer):
4453 Don't arbitrarily truncate the value of 'selective' to int.
4455 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4457 * composite.c: Don't truncate sizes to 'int'.
4458 (composition_gstring_p, composition_reseat_it)
4459 (composition_adjust_point): Use EMACS_INT, not int.
4460 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4461 not EMACS_UINT, for indexes.
4463 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4465 * buffer.c: Include <verify.h>.
4466 (struct sortvec.priority, struct sortstr.priority):
4467 Now EMACS_INT, not int.
4468 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4469 (struct sortstr.size, record_overlay_string)
4470 (struct sortstrlist.size, struct sortlist.used):
4471 Don't truncate size to int.
4472 (record_overlay_string): Check for size-calculation overflow.
4473 (init_buffer_once): Check at compile-time, not run-time.
4475 2011-06-22 Jim Meyering <meyering@redhat.com>
4477 Don't leak an XBM-image-sized buffer
4478 * image.c (xbm_load): Free the image buffer after using it.
4480 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4483 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4484 that Sun C diagnosed.
4485 * fns.c (secure_hash): Fix pointer signedness issue.
4486 * intervals.c (static_offset_intervals): New function.
4487 (offset_intervals): Use it.
4489 2011-06-21 Leo Liu <sdl.web@gmail.com>
4492 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4495 * fns.c (secure_hash): Rename from crypto_hash_function and change
4496 the first arg to accept symbols.
4497 (Fsecure_hash): New primitive.
4498 (syms_of_fns): New symbols.
4500 2011-06-20 Deniz Dogan <deniz@dogan.se>
4502 * process.c (Fset_process_buffer): Clarify return value in
4505 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4507 * dispnew.c (add_window_display_history): Use BVAR.
4509 * xdisp.c (debug_method_add): Use BVAR.
4510 (check_window_end, dump_glyph_matrix, dump_glyph)
4511 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4513 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4516 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4517 check till after the cache is created in init_frame_faces.
4519 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4521 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4523 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4525 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4526 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4527 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4529 Improve buffer-overflow checking (Bug#8873).
4530 * fileio.c (Finsert_file_contents):
4531 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4532 Remove the old (too-loose) buffer overflow checks.
4533 They weren't needed, since make_gap checks for buffer overflow.
4534 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4535 The old code merely checked for Emacs fixnum overflow, and relied
4536 on undefined (wraparound) behavior. The new code avoids undefined
4537 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4539 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4540 Tune. Don't use wider integers than needed. Don't use alloca.
4541 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4543 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4545 * insdel.c, lisp.h (buffer_overflow): New function.
4546 (insert_from_buffer_1, replace_range, replace_range_2):
4547 * insdel.c (make_gap_larger):
4548 * editfns.c (Finsert_char):
4549 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4551 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4553 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4555 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4557 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4558 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4560 * fileio.c: Don't assume EMACS_INT fits in off_t.
4561 (emacs_lseek): New static function.
4562 (Finsert_file_contents, Fwrite_region): Use it.
4563 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4565 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4567 * fns.c: Don't overflow int when computing a list length.
4568 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4569 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4570 truncation on 64-bit hosts. Check for QUIT every
4571 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4572 faster and is responsive enough.
4573 (Flength): Report an error instead of overflowing an integer.
4574 (Fsafe_length): Return a float if the value is not representable
4575 as a fixnum. This shouldn't happen except in contrived situations.
4576 (Fnthcdr, Fsort): Don't assume list length fits in int.
4577 (Fcopy_sequence): Don't assume vector length fits in int.
4579 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4580 (header_size, word_size): New constants.
4581 (allocate_vectorlike): Don't check size overflow here.
4582 (allocate_vector): Check it here instead, since this is the only
4583 caller of allocate_vectorlike that could cause overflow.
4584 Check that the new vector's length is representable as a fixnum.
4586 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4587 The previous code was bogus. For example, next_almost_prime (32)
4588 returned 39, which is undesirable as it is a multiple of 3; and
4589 next_almost_prime (24) returned 25, which is a multiple of 5 so
4590 why was the code bothering to check for multiples of 7?
4592 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4594 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4596 Variadic C functions now count arguments with ptrdiff_t.
4597 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4598 Back then I didn't know that the Emacs coding style prefers signed int.
4599 Also, in the meantime I found a few more instances where arguments
4600 were being counted with int, which may truncate counts on 64-bit
4601 machines, or EMACS_INT, which may be unnecessarily wide.
4602 * lisp.h (struct Lisp_Subr.function.aMANY)
4603 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4604 Arg counts are now ptrdiff_t, not size_t.
4605 All variadic functions and their callers changed accordingly.
4606 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4607 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4608 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4609 * callint.c (Fcall_interactively): Check arg count for overflow,
4610 to avoid potential buffer overrun. Use signed char, not 'int',
4611 for 'varies' array, so that we needn't bother to check its size
4612 calculation for overflow.
4613 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4614 * eval.c (apply_lambda):
4615 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4616 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4617 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4619 * callint.c (Fcall_interactively): Don't use index var as event count.
4621 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4622 * mem-limits.h (SIZE): Remove; no longer used.
4624 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4626 Remove unnecessary casts.
4627 * xterm.c (x_term_init):
4628 * xfns.c (x_set_border_pixel):
4629 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4630 These aren't needed now that we assume ANSI C.
4632 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4633 It's more likely to cause problems (due to unsigned overflow)
4636 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4638 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4640 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4642 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4644 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4646 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4648 GLYPH_CODE_FACE returns EMACS_INT, not int.
4649 * dispextern.h (merge_faces):
4650 * xfaces.c (merge_faces):
4651 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4652 Don't assume EMACS_INT fits in int.
4654 * character.h (CHAR_VALID_P): Remove unused parameter.
4655 * fontset.c, lisp.h, xdisp.c: All uses changed.
4657 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4659 * fns.c (concat): Minor tuning based on overflow analysis.
4660 This doesn't fix any bugs. Use int to hold character, instead
4661 of constantly refetching from Emacs object. Use XFASTINT, not
4662 XINT, for value known to be a character. Don't bother comparing
4663 a single byte to 0400, as it's always less.
4665 * floatfns.c (Fexpt):
4666 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4668 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4671 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4673 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4674 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4675 incorrectly succeed when S was a string, because 4294967386 was
4676 truncated before it was used.
4678 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4679 Otherwise, an out-of-range integer could cause undefined behavior
4682 * composite.c: Use int, not EMACS_INT, for characters.
4683 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4684 EMACS_INT, for values that are known to be in character range.
4685 This doesn't fix any bugs but is the usual style inside Emacs and
4686 may generate better code on 32-bit machines.
4688 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4689 This is for reasons similar to the recent CHAR_STRING fix.
4690 * charset.c (Fencode_char): Check that character arg is actually
4691 a character. Pass an int to ENCODE_CHAR.
4692 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4693 wider than 'int', as a compile-time check to prevent future regressions
4696 * character.c (char_string): Remove unnecessary casts.
4698 Make sure a 64-bit char is never passed to CHAR_STRING.
4699 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4700 by silently ignoring the top 32 bits, allowing some values
4701 that were far too large to be valid characters.
4702 * character.h: Include <verify.h>.
4703 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4704 arguments are no wider than unsigned, as a compile-time check
4705 to prevent future regressions in this area.
4707 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4708 (Fsubst_char_in_region):
4710 * xdisp.c (decode_mode_spec_coding):
4711 Adjust to CHAR_STRING's new requirement.
4712 * editfns.c (Finsert_char, Fsubst_char_in_region):
4713 * fns.c (concat): Check that character args are actually
4714 characters. Without this test, these functions did the wrong
4715 thing with wildly out-of-range values on 64-bit hosts.
4717 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4718 These casts should not be needed on 32-bit hosts, either.
4719 * keyboard.c (read_char):
4720 * lread.c (Fload): Remove casts to unsigned.
4722 * lisp.h (UNSIGNED_CMP): New macro.
4723 This fixes comparison bugs on 64-bit hosts.
4724 (ASCII_CHAR_P): Use it.
4725 * casefiddle.c (casify_object):
4726 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4727 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4728 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4729 * dispextern.h (FACE_FROM_ID):
4730 * keyboard.c (read_char): Use UNSIGNED_CMP.
4732 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4733 not to EMACS_INT, to avoid GCC warning.
4735 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4737 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4738 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4739 isn't needed on 32-bit machines.
4741 * buffer.c (Fgenerate_new_buffer_name):
4742 Use EMACS_INT for count, not int.
4743 (advance_to_char_boundary): Return EMACS_INT, not int.
4745 * data.c (Qcompiled_function): Now static.
4747 * window.c (window_body_lines): Now static.
4749 * image.c (gif_load): Rename local to avoid shadowing.
4751 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4752 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4753 * alloc.c (make_save_value): Integer argument is now of type
4755 (mark_object): Use ptrdiff_t, not int.
4756 * lisp.h (pD): New macro.
4757 * print.c (print_object): Use it.
4759 * alloc.c: Use EMACS_INT, not int, to count objects.
4760 (total_conses, total_markers, total_symbols, total_vector_size)
4761 (total_free_conses, total_free_markers, total_free_symbols)
4762 (total_free_floats, total_floats, total_free_intervals)
4763 (total_intervals, total_strings, total_free_strings):
4764 Now EMACS_INT, not int. All uses changed.
4765 (Fgarbage_collect): Compute overall total using a double, so that
4766 integer overflow is less likely to be a problem. Check for overflow
4767 when converting back to an integer.
4768 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4769 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4770 These were 'int' variables that could overflow on 64-bit hosts;
4771 they were never used, so remove them instead of repairing them.
4772 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4773 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4774 Previously, this ceilinged at INT_MAX, but that doesn't work on
4776 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4778 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4779 (allocate_vectorlike): Check for ptrdiff_t overflow.
4780 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4781 when a (possibly-narrower) signed value would do just as well.
4782 We prefer using signed arithmetic, to avoid comparison confusion.
4784 * alloc.c: Catch some string size overflows that we were missing.
4785 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4786 for convenience in STRING_BYTES_MAX.
4787 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4788 The definition here is exact; the one in lisp.h was approximate.
4789 (allocate_string_data): Check for string overflow. This catches
4790 some instances we weren't catching before. Also, it catches
4791 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4792 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4793 and ptrdiff_t and EMACS_INT are both 64 bits.
4795 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4796 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4797 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4799 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4801 * alloc.c (Fmake_string): Check for out-of-range init.
4803 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4805 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4807 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4809 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4810 xg_get_default_scrollbar_width.
4812 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4813 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4814 (style_changed_cb): Call update_theme_scrollbar_width and call
4815 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4816 all frames (Bug#8505).
4817 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4818 Call gtk_window_set_resizable if HAVE_GTK3.
4819 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4820 and height if HAVE_GTK3 (Bug#8505).
4821 (scroll_bar_width_for_theme): New variable.
4822 (update_theme_scrollbar_width): New function.
4823 (xg_get_default_scrollbar_width): Move code to
4824 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4825 (xg_initialize): Call update_theme_scrollbar_width.
4827 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4829 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4831 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4833 * frame.c (make_frame): Call other_buffer_safely instead of
4836 * window.c (temp_output_buffer_show): Call display_buffer with
4837 second argument Vtemp_buffer_show_specifiers and reset latter
4838 immediately after the call.
4839 (Vtemp_buffer_show_specifiers): New variable.
4840 (auto_window_vscroll_p, next_screen_context_lines)
4841 (Vscroll_preserve_screen_position): Remove leading asterisks from
4844 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4846 Fix minor problems found by GCC 4.6.0 static checking.
4847 * buffer.c (Qclone_number): Remove for now, as it's unused.
4848 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4849 (record_buffer): Remove unused local.
4850 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4851 (set_frame_buffer_list): Remove; unused.
4852 * frame.h (other_visible_frames): Remove decl.
4853 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4854 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4855 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4857 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4858 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4859 Define only if HAVE_GPM.
4860 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4861 (update_hints_inhibit): Remove; never set. All uses removed.
4862 * widgetprv.h (emacsFrameClassRec): Remove decl.
4863 * window.c (delete_deletable_window): Now returns void, since it
4864 wasn't returning anything.
4865 (compare_window_configurations): Remove unused locals.
4866 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4867 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4868 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4869 the same widths as pointers. This follows up on the 2011-05-06 patch.
4870 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4871 * xterm.h: Likewise.
4872 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4874 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4876 * makefile.w32-in: Update dependencies.
4877 (LISP_H): Add lib/intprops.h.
4879 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4881 * image.c (gif_load): Add animation frame delay to the metadata.
4882 (syms_of_image): Use DEFSYM. New symbol `delay'.
4884 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4886 * window.c (delete_deletable_window): Re-add.
4887 (Fset_window_configuration): Rewrite to handle dead buffers and
4888 consequently deletable windows.
4889 (window_tree, Fwindow_tree): Remove. Supply functionality in
4891 (compare_window_configurations): Simplify code.
4893 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4895 * image.c (imagemagick_load_image): Fix type mismatch.
4896 (Fimagemagick_types): Likewise.
4898 * window.h (replace_buffer_in_windows): Declare.
4900 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4902 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4903 Qclone_number. Remove external declaration of Qdelete_window.
4904 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4906 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4907 Run Qbuffer_list_update_hook if allowed.
4908 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4909 buffer list implementation.
4910 (other_buffer_safely): New function.
4911 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4912 calls to replace_buffer_in_windows and
4913 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4915 (record_buffer): Inhibit quitting and rewrite using quittable
4916 functions. Run Qbuffer_list_update_hook if allowed.
4917 (Frecord_buffer, Funrecord_buffer): New functions.
4918 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4919 Move switch-to-buffer to window.el.
4920 (bury-buffer): Move to window.el.
4921 (Vbuffer_list_update_hook): New variable.
4923 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4926 * window.h (resize_frame_windows): Move up in code.
4927 (Fwindow_frame): Remove EXFUN.
4928 (replace_buffer_in_all_windows): Remove prototype.
4929 (replace_buffer_in_windows_safely): Add prototype.
4931 * window.c: Declare Qdelete_window static again. Move down
4932 declaration of select_count.
4933 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4934 (Fother_window): Move to window.el.
4935 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4936 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4937 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4939 (replace_buffer_in_windows): Implement by calling
4940 Qreplace_buffer_in_windows.
4941 (replace_buffer_in_all_windows): Remove with some functionality
4942 moved into replace_buffer_in_windows_safely.
4943 (replace_buffer_in_windows_safely): New function.
4944 (select_window_norecord, select_frame_norecord): Move in front
4945 of run_window_configuration_change_hook. Remove now obsolete
4947 (Fset_window_buffer): Rewrite doc-string.
4948 Call Qrecord_window_buffer.
4949 (keys_of_window): Move binding for other-window to window.el.
4951 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4953 * dispextern.h (struct image): Replace data member, whose int_val
4954 and ptr_val fields were not used by anything, with a single
4957 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4958 (gif_clear_image, gif_load, imagemagick_load_image)
4959 (gs_clear_image, gs_load): Callers changed.
4961 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4963 * buffer.h: Include <time.h>, for time_t.
4964 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4966 Fix minor problems found by static checking.
4968 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4970 Make identifiers static if they are not used in other modules.
4971 * data.c (Qcompiled_function, Qframe, Qvector):
4972 * image.c (QimageMagick, Qsvg):
4973 * minibuf.c (Qmetadata):
4974 * window.c (resize_window_check, resize_root_window): Now static.
4975 * window.h (resize_window_check, resize_root_window): Remove decls.
4977 * window.c (window_deletion_count, delete_deletable_window):
4979 (window_body_lines): Now static.
4980 (Fdelete_other_windows_internal): Mark vars as initialized.
4981 Make sure 'resize_failed' is initialized.
4982 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4983 (resize_window_apply): Remove unused local.
4984 * window.h (delete_deletable_window): Remove decl.
4986 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4987 (imagemagick_load_image): Fix pointer signedness problem by changing
4988 last arg from unsigned char * to char *. All uses changed.
4989 Also, fix a local for similar reasons.
4990 Remove unused locals. Remove locals to avoid shadowing.
4991 (fn_rsvg_handle_free): Remove; unused.
4992 (svg_load, svg_load_image): Fix pointer signedness problem.
4993 (imagemagick_load_image): Don't use garbage pointer image_wand.
4995 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4997 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4999 * image.c (gif_load): Fix omitted cast error introduced by
5002 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5004 * window.h (resize_proportionally, orig_total_lines)
5005 (orig_top_line): Remove from window structure.
5006 (set_window_height, set_window_width, change_window_heights)
5007 (Fdelete_window): Remove prototypes.
5008 (resize_frame_windows): Remove duplicate declaration.
5010 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5012 * window.h (resize_frame_windows, resize_window_check)
5013 (delete_deletable_window, resize_root_window)
5014 (resize_frame_windows): Declare prototypes.
5016 * window.c (resize_window_apply): Make definition be "static" to
5017 match the prototype.
5019 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5021 * window.c: Remove declarations of Qwindow_size_fixed,
5022 window_min_size_1, window_min_size_2, window_min_size,
5023 size_window, window_fixed_size_p, enlarge_window, delete_window.
5024 Remove static from declaration of Qdelete_window, it's
5025 temporarily needed by Fbury_buffer.
5026 (replace_window): Don't assign orig_top_line and
5028 (Fdelete_window, delete_window): Remove. Window deletion is
5029 handled by window.el.
5030 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5031 Replace Fdelete_window calls with calls to Qdelete_window.
5032 (Fdelete_other_windows): Remove. Deleting other windows is
5033 handled by window.el.
5034 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5035 handled in window.el.
5036 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5037 Window minimum sizes are handled in window.el.
5038 (shrink_windows, size_window, set_window_height)
5039 (set_window_width, change_window_heights, window_height)
5040 (window_width, CURBEG, CURSIZE, enlarge_window)
5041 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5042 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5043 handled in window.el.
5044 (make_dummy_parent): Rename to make_parent_window and give it a
5045 second argument horflag.
5046 (make_window): Don't set resize_proportionally any more.
5047 (Fsplit_window): Remove. Windows are split in window.el.
5048 (save_restore_action, save_restore_orig_size)
5049 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5050 Resize mini windows in window.el.
5051 (grow_mini_window, shrink_mini_window): Implement by calling
5052 Qresize_root_window_vertically, resize_window_check and
5053 resize_window_apply.
5054 (saved_window, Fset_window_configuration, save_window_save):
5055 Do not handle orig_top_line, orig_total_lines, and
5056 resize_proportionally.
5057 (window_min_height, window_min_width): Move to window.el.
5058 (keys_of_window): Move bindings for delete-other-windows,
5059 split-window, delete-window and enlarge-window to window.el.
5061 * buffer.c: Temporarily extern Qdelete_window.
5062 (Fbury_buffer): Temporarily call Qdelete_window instead of
5063 Fdelete_window (Fbury_buffer will move to window.el soon).
5065 * frame.c (set_menu_bar_lines_1): Remove code handling
5066 orig_top_line and orig_total_lines.
5068 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5069 set_window_height but set heights directly.
5070 (change_frame_size_1): Use resize_frame_windows.
5072 * xdisp.c (init_xdisp): Don't use set_window_height but set
5075 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5076 Use resize_frame_windows instead of change_window_heights and run
5077 run_window_configuration_change_hook.
5079 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5080 instead of change_window_heights and run
5081 run_window_configuration_change_hook.
5083 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5085 * window.c (replace_window): Rename second argument REPLACEMENT to
5086 NEW. New third argument SETFLAG. Rewrite.
5087 (delete_window, make_dummy_parent): Call replace_window with
5089 (window_list_1): Move down in code.
5090 (run_window_configuration_change_hook): Move set_buffer part
5091 before select_frame_norecord part in order to unwind correctly.
5092 Rename count1 to count.
5093 (recombine_windows, delete_deletable_window, resize_root_window)
5094 (Fdelete_other_windows_internal)
5095 (Frun_window_configuration_change_hook, make_parent_window)
5096 (resize_window_check, resize_window_apply, Fresize_window_apply)
5097 (resize_frame_windows, Fsplit_window_internal)
5098 (Fdelete_window_internal, Fresize_mini_window_internal):
5100 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5102 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5104 * window.h (window): Add some new members to window structure -
5105 normal_lines, normal_cols, new_total, new_normal, clone_number,
5106 splits, nest, prev_buffers, next_buffers.
5107 (WINDOW_TOTAL_SIZE): Move here from window.c.
5108 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5110 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5112 (make_dummy_parent): Set new members of windows structure.
5113 (make_window): Move down in code. Handle new members of window
5115 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5116 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5117 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5118 (Fset_window_prev_buffers, Fwindow_next_buffers)
5119 (Fset_window_next_buffers, Fset_window_clone_number):
5121 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5122 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5124 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5125 Argument WINDOW can be now internal window too.
5126 (Fwindow_use_time): Move up in code.
5127 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5129 (Fset_window_configuration, saved_window)
5130 (Fcurrent_window_configuration, save_window_save): Handle new
5131 members of window structure.
5132 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5133 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5134 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5135 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5136 Qget_mru_window, Qresize_root_window,
5137 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5138 Qauto_buffer_name; staticpro them.
5140 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5142 * window.c (Fwindow_total_size, Fwindow_left_column)
5143 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5144 (Fwindow_list_1): New functions.
5145 (window_box_text_cols): Replace with window_body_cols.
5146 (Fwindow_width, Fscroll_left, Fscroll_right):
5147 Use window_body_cols instead of window_box_text_cols.
5148 (delete_window, Fset_window_configuration):
5149 Call delete_all_subwindows with window as argument.
5150 (delete_all_subwindows): Take a window as argument and not a
5152 (window_loop): Remove handling of GET_LRU_WINDOW and
5154 (Fget_lru_window, Fget_largest_window): Move to window.el.
5156 * window.h: Extern window_body_cols instead of
5157 window_box_text_cols. delete_all_subwindows now takes a
5158 Lisp_Object as argument.
5160 * indent.c (compute_motion, Fcompute_motion):
5161 Use window_body_cols instead of window_box_text_cols.
5163 * frame.c (delete_frame): Call delete_all_subwindows with root
5166 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5168 * fns.c (Fputhash): Document return value.
5170 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5172 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5174 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5176 Cons<->int and similar integer overflow fixes (Bug#8794).
5178 Check for overflow when converting integer to cons and back.
5179 * charset.c (Fdefine_charset_internal, Fdecode_char):
5180 Use cons_to_unsigned to catch overflow.
5181 (Fencode_char): Use INTEGER_TO_CONS.
5182 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5183 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5184 * data.c (long_to_cons, cons_to_long): Remove.
5185 (cons_to_unsigned, cons_to_signed): New functions.
5186 These signal an error for invalid or out-of-range values.
5187 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5188 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5189 * font.c (Ffont_variation_glyphs):
5190 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5191 * lisp.h: Include <intprops.h>.
5192 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5193 (cons_to_signed, cons_to_unsigned): New decls.
5194 (long_to_cons, cons_to_long): Remove decls.
5195 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5196 (Fprimitive_undo): Use CONS_TO_INTEGER.
5197 * xfns.c (Fx_window_property): Likewise.
5198 * xselect.c: Include <limits.h>.
5199 (x_own_selection, selection_data_to_lisp_data):
5200 Use INTEGER_TO_CONS.
5201 (x_handle_selection_request, x_handle_selection_clear)
5202 (x_get_foreign_selection, Fx_disown_selection_internal)
5203 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5204 (lisp_data_to_selection_data): Use cons_to_unsigned.
5205 (x_fill_property_data): Use cons_to_signed.
5206 Report values out of range.
5208 Check for buffer and string overflow more precisely.
5209 * buffer.h (BUF_BYTES_MAX): New macro.
5210 * lisp.h (STRING_BYTES_MAX): New macro.
5211 * alloc.c (Fmake_string):
5212 * character.c (string_escape_byte8):
5213 * coding.c (coding_alloc_by_realloc):
5214 * doprnt.c (doprnt):
5215 * editfns.c (Fformat):
5217 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5218 since they may not be the same number.
5219 * editfns.c (Finsert_char):
5220 * fileio.c (Finsert_file_contents):
5221 Likewise for BUF_BYTES_MAX.
5223 * image.c: Use ptrdiff_t, not int, for sizes.
5224 (slurp_file): Switch from int to ptrdiff_t.
5226 (slurp_file): Check that file size fits in both size_t (for
5227 malloc) and ptrdiff_t (for sanity and safety).
5229 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5230 if b->modtime has its maximal value.
5232 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5234 Don't assume time_t can fit into int.
5235 * buffer.h (struct buffer.modtime): Now time_t, not int.
5236 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5237 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5239 Minor fixes for signed vs unsigned integers.
5240 * character.h (MAYBE_UNIFY_CHAR):
5241 * charset.c (maybe_unify_char):
5242 * keyboard.c (read_char, reorder_modifiers):
5243 XINT -> XFASTINT, since the integer must be nonnegative.
5244 * ftfont.c (ftfont_spec_pattern):
5245 * keymap.c (access_keymap, silly_event_symbol_error):
5246 XUINT -> XFASTINT, since the integer must be nonnegative.
5247 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5248 since it makes no difference and we prefer signed.
5249 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5250 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5253 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5255 * window.h (Fwindow_frame): Declare.
5257 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5259 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5260 (SPARE_MEMORY): Always define.
5261 (LARGE_REQUEST): Remove.
5262 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5264 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5266 * lisp.h: Move EXFUNS for Fframe_root_window,
5267 Fframe_first_window and Fset_frame_selected_window to window.h.
5269 * window.h: Move EXFUNS for Fframe_root_window,
5270 Fframe_first_window and Fset_frame_selected_window here from
5273 * frame.c (Fwindow_frame, Fframe_first_window)
5274 (Fframe_root_window, Fframe_selected_window)
5275 (Fset_frame_selected_window): Move to window.c.
5276 (Factive_minibuffer_window): Move to minibuf.c.
5277 (Fother_visible_frames_p): New function.
5279 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5281 * window.c (decode_window, decode_any_window): Move up in code.
5282 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5283 (inhibit_frame_unsplittable): Remove unused variable.
5284 (Fwindow_buffer): Move up and rewrite doc-string.
5285 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5286 (Fwindow_prev): New functions.
5287 (Fwindow_frame): Move here from frame.c. Accept any window as
5289 (Fframe_root_window, Fframe_first_window)
5290 (Fframe_selected_window): Move here from frame.c. Accept frame
5291 or arbitrary window as argument. Update doc-strings.
5292 (Fminibuffer_window): Move up in code.
5293 (Fwindow_minibuffer_p): Move up in code and simplify.
5294 (Fset_frame_selected_window): Move here from frame.c.
5296 (Fselected_window, select_window, Fselect_window): Move up in
5297 code. Minor doc-string fixes.
5299 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5301 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5302 Do not assume that spare memory exists; that assumption is valid
5303 only if SYSTEM_MALLOC.
5304 (LARGE_REQUEST): New macro, so that the issue of large requests
5305 is separated from the issue of spare memory.
5307 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5309 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5312 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5314 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5317 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5319 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5321 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5323 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5324 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5326 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5328 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5330 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5332 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5333 (x_clipboard_manager_save): Add return value.
5334 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5336 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5337 Obey Vx_select_enable_clipboard_manager. Catch errors in
5338 x_clipboard_manager_save (Bug#8779).
5339 (Vx_select_enable_clipboard_manager): New variable.
5340 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5342 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5344 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5346 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5348 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5349 in the current matrix if keep_current_p is non-zero.
5351 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5353 * bidi.c (bidi_level_of_next_char): Fix last change.
5355 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5357 Support bidi reordering of text covered by display properties.
5359 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5360 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5361 (bidi_cache_search, bidi_cache_iterator_state)
5362 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5363 (bidi_level_of_next_char, bidi_move_to_visually_next):
5364 Support character positions inside a run of characters covered by a
5366 (bidi_paragraph_init, bidi_resolve_explicit_1)
5367 (bidi_level_of_next_char): Call bidi_fetch_char and
5368 bidi_fetch_char_advance instead of FETCH_CHAR and
5370 (bidi_init_it): Initialize new members.
5371 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5373 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5374 instead of using explicit *_CHAR codes.
5375 (bidi_resolve_explicit, bidi_resolve_weak):
5376 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5377 bidirectional text is supported only in multibyte buffers.
5378 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5379 it to initialize the frame_window_p member of struct bidi_it.
5380 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5381 (bidi_resolve_explicit, bidi_resolve_weak)
5382 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5383 bidi_it->nchars is non-positive.
5384 (bidi_level_of_next_char): Don't try to lookup the cache for the
5385 next/previous character if nothing is cached there yet, or if we
5386 were just reseat()'ed to a new position.
5388 * xdisp.c (set_cursor_from_row): Set start and stop points
5389 according to the row's direction when priming the loop that looks
5390 for the glyph on which to display cursor.
5391 (single_display_spec_intangible_p): Function deleted.
5392 (display_prop_intangible_p): Reimplement to call
5393 handle_display_spec instead of single_display_spec_intangible_p.
5394 Accept 3 additional arguments needed by handle_display_spec.
5395 This fixes incorrect cursor motion across display property with complex
5396 values: lists, `(when COND...)' forms, etc.
5397 (single_display_spec_string_p): Support property values that are
5398 lists with the argument STRING its top-level element.
5399 (display_prop_string_p): Fix the condition for processing a
5400 property that is a list to be consistent with handle_display_spec.
5401 (handle_display_spec): New function, refactored from the
5402 last portion of handle_display_prop.
5403 (compute_display_string_pos): Accept additional argument
5404 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5405 value of a `display' property is a "replacing spec".
5406 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5407 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5408 the display property, but just return a value indicating whether
5409 the display property will replace the characters it covers.
5410 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5411 frame_window_p members of struct bidi_it.
5412 (compute_display_string_pos, compute_display_string_end):
5414 (push_it): Accept second argument POSITION, where pop_it should
5415 jump to continue iteration.
5416 (reseat_1): Initialize bidi_it.disp_pos.
5418 * keyboard.c (adjust_point_for_property): Adjust the call to
5419 display_prop_intangible_p to its new signature.
5421 * dispextern.h (struct bidi_it): New member frame_window_p.
5422 (bidi_init_it): Update prototypes.
5423 (display_prop_intangible_p): Update prototype.
5424 (compute_display_string_pos, compute_display_string_end):
5426 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5429 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5431 Malloc failure behavior now depends on size of allocation.
5432 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5433 * lisp.h: Change signatures accordingly.
5434 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5435 All callers changed. (Bug#8762)
5437 * gnutls.c: Use Emacs's memory allocators.
5438 Without this change, the gnutls library would invoke malloc etc.
5439 directly, which causes problems on non-SYNC_INPUT hosts, and which
5440 runs afoul of improving memory_full behavior. (Bug#8761)
5441 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5442 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5443 xfree instead of the default malloc, realloc, free.
5444 (Fgnutls_boot): No need to check for memory allocation failure,
5445 since xmalloc does that for us.
5447 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5448 * category.c (hash_get_category_set):
5449 * ccl.c (ccl_driver):
5450 * charset.c (Fdefine_charset_internal):
5451 * charset.h (struct charset.hash_index):
5452 * composite.c (get_composition_id, gstring_lookup_cache)
5453 (composition_gstring_put_cache):
5454 * composite.h (struct composition.hash_index):
5455 * dispextern.h (struct image.hash):
5456 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5457 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5458 (hashfn_equal, hashfn_user_defined, make_hash_table)
5459 (maybe_resize_hash_table, hash_lookup, hash_put)
5460 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5461 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5462 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5463 * image.c (make_image, search_image_cache, lookup_image)
5464 (xpm_put_color_table_h):
5465 * lisp.h (struct Lisp_Hash_Table):
5466 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5467 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5468 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5469 * alloc.c (allocate_vectorlike):
5470 Check for overflow in vector size calculations.
5471 * ccl.c (ccl_driver):
5472 Check for overflow when converting EMACS_INT to int.
5473 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5474 need to be updated by these changes.
5475 * fns.c (make_hash_table, maybe_resize_hash_table):
5476 Check for integer overflow with large hash tables.
5477 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5478 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5479 (SXHASH_REDUCE): New macro.
5480 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5481 Use it instead of discarding useful hash info with large hash values.
5482 (sxhash_float): New function.
5483 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5484 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5485 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5486 Rewrite to use FIXNUM_BITS, as this simplifies things.
5487 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5488 Adjust signatures to match updated version of code.
5489 (consing_since_gc): Now EMACS_INT, since a single hash table can
5490 use more than INT_MAX bytes.
5492 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5494 Make it possible to build with GCC-4.6+ -O2 -flto.
5496 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5498 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5500 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5501 Call minibuffer-inactive-mode.
5503 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5505 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5506 Update dependencies.
5508 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5510 * data.c (init_data): Remove code for UTS, this system is not
5513 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5515 Don't force ./temacs to start in terminal mode.
5517 * frame.c (make_initial_frame): Initialize faces in all cases, not
5518 only when CANNOT_DUMP is defined.
5519 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5521 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5523 * dispnew.c (add_window_display_history): Use const for the string
5524 pointer. Remove declaration, not needed.
5526 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5528 Use 'inline', not 'INLINE'.
5529 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5530 * alloc.c, fontset.c (INLINE): Remove.
5531 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5532 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5533 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5534 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5535 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5537 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5539 Make it possible to run ./temacs.
5541 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5542 syms_of_callproc does the same thing. Remove test for
5543 "initialized", do it in the caller.
5544 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5546 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5548 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5549 (read_minibuf): Use get_minibuffer.
5550 (syms_of_minibuf): Use DEFSYM.
5551 (Qmetadata): New var.
5552 * data.c (Qbuffer): Don't make it static.
5553 (syms_of_data): Use DEFSYM.
5555 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5557 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5558 (CCL_CODE_MIN): New macro.
5560 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5562 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5564 * eval.c (Qdebug): Now static.
5565 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5566 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5567 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5569 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5571 * image.c: Various fixes to ImageMagick code comments.
5572 (Fimagemagick_types): Doc fix.
5574 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5576 Minor fixes prompted by GCC 4.6.0 warnings.
5578 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5580 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5581 (x_clipboard_manager_save_all): Move extern decl to ...
5582 * xterm.h: ... here, so that it can be checked for consistency.
5584 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5586 * xselect.c (x_clipboard_manager_save_frame)
5587 (x_clipboard_manager_save_all): New functions.
5588 (Fx_clipboard_manager_save): Lisp function deleted.
5590 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5591 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5593 * xterm.h: Update prototype.
5595 2011-05-28 William Xu <william.xwl@gmail.com>
5597 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5600 2011-05-28 Jim Meyering <meyering@redhat.com>
5602 Avoid a sign-extension bug in crypto_hash_function.
5603 * fns.c (to_uchar): Define.
5604 (crypto_hash_function): Use it to convert some newly-signed
5605 variables to unsigned, to avoid sign-extension bugs. For example,
5606 without this change, (md5 "truc") would evaluate to
5607 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5608 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5609 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5611 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5613 Integer overflow fixes.
5615 * dbusbind.c: Serial number integer overflow fixes.
5616 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5617 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5618 to hold a serial number that is too large for a fixnum.
5619 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5620 Check for serial numbers out of range. Decode any serial number
5621 that was so large that it became a float. (Bug#8722)
5623 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5624 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5625 Use XFASTINT rather than XUINT when numbers are nonnegative.
5626 (xd_append_arg, Fdbus_method_return_internal):
5627 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5628 arguments, check that Lisp number is nonnegative, rather than
5629 silently wrapping negative numbers around. (Bug#8722)
5630 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5633 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5635 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5637 ccl: add integer overflow checks
5638 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5639 (IN_INT_RANGE): New macros.
5640 (ccl_driver): Use them to check for integer overflow when
5641 decoding a CCL program. Many of the new checks are whether XINT (x)
5642 fits in int; it doesn't always, on 64-bit hosts. The new version
5643 doesn't catch all possible integer overflows, but it's an
5644 improvement. (Bug#8719)
5646 * alloc.c (make_event_array): Use XINT, not XUINT.
5647 There's no need for unsigned here.
5649 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5650 This follows up to the 2011-05-06 change that substituted uintptr_t
5651 for EMACS_INT. This case wasn't caught back then.
5653 Rework Fformat to avoid integer overflow issues.
5654 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5655 now (part of C89). Include <verify.h>.
5656 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5657 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5658 (Fformat): Avoid the prepass trying to compute sizes; it was only
5659 approximate and thus did not catch overflow reliably. Instead, walk
5660 through the format just once, formatting and computing sizes as we go,
5661 checking for integer overflow at every step, and allocating a larger
5662 buffer as needed. Keep track separately whether the format is
5663 multibyte. Keep only the most-recently calculated precision, rather
5664 than them all. Record whether each argument has been converted to
5665 string. Use EMACS_INT, not int, for byte and char and arg counts.
5666 Support field widths and precisions larger than INT_MAX. Avoid
5667 sprintf's undefined behavior with conversion specifications such as %#d
5668 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5669 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5670 formatting out-of-range floating point numbers with int
5673 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5675 * data.c: Avoid integer truncation in expressions involving floats.
5676 * data.c: Include <intprops.h>.
5677 (arith_driver): When there's an integer overflow in an expression
5678 involving floating point, convert the integers to floating point
5679 so that the resulting value does not suffer from catastrophic
5680 integer truncation. For example, on a 64-bit host (* 4
5681 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5682 Do not rely on undefined behavior after integer overflow.
5684 merge count_size_as_multibyte, parse_str_to_multibyte
5685 * character.c, character.h (count_size_as_multibyte):
5686 Rename from parse_str_to_multibyte; all uses changed.
5687 Check for integer overflow.
5688 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5689 since it's now a duplicate of the other. This is more of
5690 a character than a buffer op, so better that it's in character.c.
5691 * fns.c, print.c: Adjust to above changes.
5693 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5695 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5697 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5699 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5700 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5701 (x_clipboard_manager_save): Now static.
5702 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5704 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5705 (crypto_hash_function): Now static.
5706 Fix pointer signedness problems. Avoid unnecessary initializations.
5708 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5710 * termhooks.h (Vselection_alist): Make it terminal-local.
5712 * terminal.c (create_terminal): Initialize it.
5714 * xselect.c: Support for clipboard managers.
5715 (Vselection_alist): Move to termhooks.h as terminal-local var.
5716 (LOCAL_SELECTION): New macro.
5717 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5718 (symbol_to_x_atom): Remove gratuitous arg.
5719 (x_handle_selection_request, lisp_data_to_selection_data)
5720 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5721 (x_own_selection, x_get_local_selection, x_convert_selection):
5722 New arg, specifying work frame. Use terminal-local Vselection_alist.
5723 (some_frame_on_display): Delete unused function.
5724 (Fx_own_selection_internal, Fx_get_selection_internal)
5725 (Fx_disown_selection_internal, Fx_selection_owner_p)
5726 (Fx_selection_exists_p): New optional frame arg.
5727 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5728 (x_handle_selection_clear): Don't treat other terminals with the
5729 same keyboard specially. Use the terminal-local Vselection_alist.
5730 (x_clear_frame_selections): Use Frun_hook_with_args.
5732 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5734 * xterm.h: Add support for those atoms.
5736 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5738 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5739 (converted_selections, conversion_fail_tag): New global variables.
5740 (x_selection_request_lisp_error): Free the above.
5741 (x_get_local_selection): Remove unnecessary code.
5742 (x_reply_selection_request): Args changed; handle arbitrary array
5743 of converted selections stored in converted_selections.
5744 Separate the XChangeProperty and SelectionNotify steps.
5745 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5746 (x_convert_selection): New function.
5747 (x_handle_selection_event): Simplify.
5748 (x_get_foreign_selection): Don't ignore incoming requests while
5749 waiting for an answer; this will fail when we implement
5750 SAVE_TARGETS, and seems unnecessary anyway.
5751 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5752 (Vx_sent_selection_functions): Doc fix.
5754 2011-05-26 Leo Liu <sdl.web@gmail.com>
5756 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5758 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5760 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5762 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5763 for fringe update if it has periodic bitmap.
5764 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5765 and fringe_bitmap_periodic_p.
5767 * fringe.c (get_fringe_bitmap_data): New function.
5768 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5769 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5770 row. Mark glyph row for fringe update if periodicity changed.
5772 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5773 for fringe update unless it has periodic bitmap.
5775 2011-05-25 Kenichi Handa <handa@m17n.org>
5777 * xdisp.c (get_next_display_element): Set correct it->face_id for
5778 a static composition.
5780 2011-05-24 Leo Liu <sdl.web@gmail.com>
5783 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5785 * fns.c (crypto_hash_function, Fsha1): New function.
5786 (Fmd5): Use crypto_hash_function.
5787 (syms_of_fns): Add Ssha1.
5789 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5791 * gnutls.c: Remove unused macros.
5792 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5793 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5794 Remove macros that are defined and never used.
5795 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5797 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5799 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5800 (Fx_get_selection_internal): Minor cleanup.
5801 (Fx_own_selection_internal): Rename arguments for consistency with
5804 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5806 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5808 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5810 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5812 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5814 * dispnew.c (scrolling_window): Don't exclude the case that the
5815 last enabled row in the desired matrix touches the bottom boundary.
5817 2011-05-21 Glenn Morris <rgm@gnu.org>
5819 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5820 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5821 and add some more files.
5823 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5825 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5826 report_file_error introduced by the change from 2011-05-07.
5828 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5830 * systime.h (Time): Define only if emacs is defined.
5831 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5832 where the include path doesn't have X11/X.h by default. See
5833 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5835 2011-05-20 Kenichi Handa <handa@m17n.org>
5837 * composite.c (find_automatic_composition): Fix previous change.
5839 2011-05-20 Glenn Morris <rgm@gnu.org>
5841 * lisp.mk: New file, split from Makefile.in.
5842 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5843 (shortlisp): Remove.
5844 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5846 2011-05-19 Glenn Morris <rgm@gnu.org>
5848 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5849 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5850 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5851 (lisp): Set the order to that of loadup.el.
5852 (shortlisp): Make it a copy of $lisp.
5853 (SOME_MACHINE_LISP): Remove.
5854 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5855 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5857 2011-05-18 Kenichi Handa <handa@m17n.org>
5859 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5860 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5861 (find_automatic_composition): Mostly rewrite for efficiency.
5863 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5865 * makefile.w32-in: Update dependencies.
5867 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5869 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5870 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5872 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5874 Fix some integer overflow issues, such as string length overflow.
5876 * insdel.c (count_size_as_multibyte): Check for string overflow.
5878 * character.c (lisp_string_width): Check for string overflow.
5879 Use EMACS_INT, not int, for string indexes and lengths; in
5880 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5881 the resulting string length overflows an EMACS_INT; instead,
5882 report a string overflow if no precision given. When checking for
5883 precision exhaustion, use a check that cannot possibly have
5884 integer overflow. (Bug#8675)
5885 * character.h (lisp_string_width): Adjust to new signature.
5887 * alloc.c (string_overflow): New function.
5888 (Fmake_string): Use it. This doesn't change behavior, but saves
5889 a few bytes and will simplify future changes.
5890 * character.c (string_escape_byte8): Likewise.
5891 * lisp.h (string_overflow): New decl.
5893 Fixups, following up to the user-interface timestamp change.
5894 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5895 for UI timestamps, instead of unsigned long.
5896 * msdos.c (mouse_get_pos): Likewise.
5897 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5898 * w32gui.h (Time): Define by including "systime.h" rather than by
5899 declaring it ourselves. (Bug#8664)
5901 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5902 * image.c (clear_image_cache): Likewise.
5904 * term.c (term_mouse_position): Don't assume time_t wraparound.
5906 Be more systematic about user-interface timestamps.
5907 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5908 and sometimes 'EMACS_UINT', to represent these timestamps.
5909 This change causes it to use 'Time' uniformly, as that's what X uses.
5910 This makes the code easier to follow, and makes it easier to catch
5911 integer overflow bugs such as Bug#8664.
5912 * frame.c (Fmouse_position, Fmouse_pixel_position):
5913 Use Time, not unsigned long, for user-interface timestamps.
5914 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5915 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5916 * keyboard.h (last_event_timestamp): Likewise.
5917 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5918 * menu.h (xmenu_show): Likewise.
5919 * term.c (term_mouse_position): Likewise.
5920 * termhooks.h (struct input_event.timestamp): Likewise.
5921 (struct terminal.mouse_position_hook): Likewise.
5922 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5923 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5924 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5925 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5927 * menu.h, termhooks.h: Include "systime.h", for Time.
5929 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5930 Don't assume that the difference between two unsigned long values
5931 can fit into an integer. At this point, we know button_down_time
5932 <= event->timestamp, so the difference must be nonnegative, so
5933 there's no need to cast the result if double-click-time is
5934 nonnegative, as it should be; check that it's nonnegative, just in
5935 case. This bug is triggered when events are more than 2**31 ms
5936 apart (about 25 days). (Bug#8664)
5938 * xselect.c (last_event_timestamp): Remove duplicate decl.
5939 (x_own_selection): Remove needless cast to unsigned long.
5941 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5942 that always fit in int. Use a sentinel instead of a counter, to
5943 avoid a temp and to allay GCC's concerns about possible int overflow.
5944 * frame.h (struct frame): Use int for menu_bar_items_used
5945 instead of EMACS_INT, since it always fits in int.
5947 * menu.c (grow_menu_items): Check for int overflow.
5949 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5951 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5952 Before, the code was not consistent. These values cannot exceed
5953 2**31 - 1 so there's no need to make them unsigned.
5954 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5955 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5956 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5958 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5960 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5961 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5962 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5963 presumably because the widths might not match.
5965 * window.c (size_window): Avoid needless test at loop start.
5967 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5969 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5971 2011-05-12 Drew Adams <drew.adams@oracle.com>
5973 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5975 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5977 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5978 `width' to `bar_area_x' and `bar_area_width', respectively.
5979 (x_scroll_run): Take account of fringe background extension.
5981 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5982 Rename local vars `left' and `width' to `bar_area_x' and
5983 `bar_area_width', respectively.
5984 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5985 background extension.
5987 2011-05-10 Jim Meyering <meyering@redhat.com>
5989 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5991 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5993 * image.c (Finit_image_library): Return t for built-in image types,
5994 like pbm and xbm. (Bug#8640)
5996 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5998 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6000 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6002 * w32console.c (Fset_screen_color): Doc fix.
6003 (Fget_screen_color): New function.
6004 (syms_of_ntterm): Defsubr it.
6006 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6007 unlink the temporary file if Fcall_process didn't create it in the
6009 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6010 child process will be redirected to a file specified with `:file'.
6011 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6012 cue to call_process_cleanup not to close that handle.
6014 2011-05-07 Ben Key <bkey76@gmail.com>
6016 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6017 one of two shell specific rules, either bootstrap-temacs-CMD or
6018 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6019 to the previous implementation of the bootstrap-temacs rule.
6020 The bootstrap-temacs-CMD rule is similar to the previous
6021 implementation of the bootstrap-temacs rule except that it
6022 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6025 These changes, along with some changes to nt/configure.bat,
6026 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6027 earlier fix to add support for --cflags and --ldflags options
6028 that include quotes so that it works whether make uses cmd or
6031 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6033 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6034 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6036 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6037 a string. Handle both cases.
6038 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6039 (Fdbus_register_method): Use Qinvalid_function.
6041 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6043 * makefile.w32-in: Update dependencies.
6044 (LISP_H): Add inttypes.h and stdin.h.
6045 (PROCESS_H): Add unistd.h.
6047 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6049 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6050 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6052 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6054 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6056 * term.c (vfatal): Remove stray call to va_end.
6057 It's not needed and the C Standard doesn't allow it here anyway.
6059 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6060 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6062 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6065 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6067 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6069 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6071 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6073 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6075 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6076 * charset.c (Fdefine_charset_internal): Don't initialize
6077 charset.code_space[15]. The value was garbage, on hosts with
6078 32-bit int (Bug#8600).
6080 * lread.c (read_integer): Be more consistent with string-to-number.
6081 Use string_to_number to do the actual conversion; this avoids
6082 rounding errors and fixes some other screwups. Without this fix,
6083 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6084 (digit_to_number): Move earlier, for benefit of read_integer.
6085 Return -1 if the digit is out of range for the base, -2 if it is
6086 not a digit in any supported base. (Bug#8602)
6088 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6090 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6091 to match comment at start of function. This also removes a
6092 GCC warning about overflow in a 32+64-bit port.
6094 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6096 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6097 Reported by Stefan Monnier in
6098 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6099 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6100 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6102 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6103 (EMACS_UINTPTR): Likewise, with uintptr_t.
6105 * lisp.h: Prefer 64-bit EMACS_INT if available.
6106 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6107 on 32-bit hosts that have 64-bit int, so that they can access
6109 However, temporarily disable this change unless the temporary
6110 symbol WIDE_EMACS_INT is defined.
6112 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6114 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6115 This removes an assumption that EMACS_INT and long are the same
6116 width as pointers. The assumption is true for Emacs porting targets
6117 now, but we want to make other targets possible.
6118 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6119 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6120 In the rest of the code, change types of integers that hold casted
6121 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6122 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6123 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6124 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6125 No need to cast type when ORing.
6126 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6127 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6128 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6129 assume EMACS_INT is the same width as char *.
6130 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6131 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6132 Remove no-longer-needed casts.
6133 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6134 (xg_tool_bar_help_callback, xg_make_tool_item):
6135 Use EMACS_INTPTR to hold an integer
6136 that will be cast to void *; this can avoid a GCC warning
6137 if EMACS_INT is not the same width as void *.
6138 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6139 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6140 (current_message_1, set_message_1):
6141 Use a local to convert to proper width without a cast.
6142 * xmenu.c (dialog_selection_callback): Likewise.
6144 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6145 Also, don't assume VALBITS / RAND_BITS is less than 5,
6146 and don't rely on undefined behavior when shifting a 1 left into
6148 * lisp.h (get_random): Change signature to match.
6150 * lread.c (hash_string): Use size_t, not int, for hash computation.
6151 Normally we prefer signed values; but hashing is special, because
6152 it's better to use unsigned division on hash table sizes so that
6153 the remainder is nonnegative. Also, size_t is the natural width
6154 for hashing into memory. The previous code used 'int', which doesn't
6155 retain enough info to hash well into very large tables.
6156 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6158 * dbusbind.c: Don't possibly lose pointer info when converting.
6159 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6160 Use XPNTR rather than XHASH, so that the high-order bits of
6161 the pointer aren't lost when converting through void *.
6163 * eval.c (Fautoload): Don't double-shift a pointer.
6165 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6167 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6169 * gnutls.c (DEF_GNUTLS_FN):
6170 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6172 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6174 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6177 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6179 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6180 New version that can reserve upto 2GB of heap space.
6182 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6184 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6186 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6188 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6189 `gnutls_certificate_set_x509_key_file'.
6191 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6193 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6194 Update dependencies.
6196 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6198 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6199 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6200 Remove unused parameter `fildes'.
6201 * process.c (read_process_output, send_process): Don't pass it.
6203 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6205 Fix previous change: the library cache is defined in w32.c.
6206 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6207 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6209 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6211 Implement dynamic loading of GnuTLS on Windows.
6213 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6214 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6215 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6218 * gnutls.c (Qgnutls_dll): Define.
6219 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6220 (gnutls_*): Declare function pointers.
6221 (init_gnutls_functions): New function to initialize function pointers.
6222 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6223 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6224 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6225 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6226 (emacs_gnutls_write, emacs_gnutls_read)
6227 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6228 (Fgnutls_available_p): New function.
6229 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6230 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6231 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6233 * image.c: Include w32.h.
6234 (Vimage_type_cache): Delete.
6235 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6236 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6237 (w32_delayed_load): Move to w32.c.
6239 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6241 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6242 (w32_delayed_load): Move from image.c. When loading a library, record
6243 its filename in the :loaded-from property of the library id.
6244 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6245 Initialize and staticpro them.
6246 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6248 * process.c: Include lisp.h before w32.h, not after.
6249 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6250 instead of gnutls_record_check_pending.
6252 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6254 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6256 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6257 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6260 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6262 * xterm.c (x_set_frame_alpha): Do not set property on anything
6263 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6265 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6267 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6269 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6271 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6272 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6273 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6274 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6275 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6276 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6277 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6278 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6279 (Qgnutls_bootprop_callbacks_verify): Make static.
6281 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6283 * callproc.c: Indentation fixup.
6285 * sysdep.c (wait_for_termination_1): Make static.
6286 (wait_for_termination, interruptible_wait_for_termination):
6287 Move after wait_for_termination_1.
6289 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6291 * sysdep.c (interruptible_wait_for_termination): New function
6292 which is like wait_for_termination, but allows keyboard
6295 * callproc.c (Fcall_process): Add (:file "file") as an option for
6297 (Fcall_process_region): Ditto.
6299 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6301 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6302 rather than `XVECTOR (FOO)->size'.
6304 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6305 inttypes.h, as a gnulib replacement is used if it not available in
6308 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6310 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6311 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6312 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6314 * coding.c (coding_alloc_by_realloc): Error out if destination
6315 will grow beyond MOST_POSITIVE_FIXNUM.
6316 (decode_coding_emacs_mule): Abort if there isn't enough place in
6317 charbuf for the composition carryover bytes. Reserve an extra
6318 space for up to 2 characters produced in a loop.
6319 (decode_coding_iso_2022): Abort if there isn't enough place in
6320 charbuf for the composition carryover bytes.
6322 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6324 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6325 aborting when %lld or %lll format is passed.
6326 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6327 %llo or %llx format is passed. (Bug#8545)
6329 * window.c (window_scroll_line_based): Use a marker instead of
6330 simple variables to record original value of point. (Bug#7952)
6332 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6333 produced by %s or %c overflows available buffer space. (Bug#8545)
6335 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6337 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6338 (SIZE_MAX): Move defn after all includes, as they might #define it.
6340 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6342 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6344 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6346 * keyboard.c (Qdelayed_warnings_hook): Define.
6347 (command_loop_1): Run `delayed-warnings-hook'
6348 if Vdelayed_warnings_list is non-nil.
6349 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6350 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6352 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6354 * doprnt.c (doprnt): Don't return value smaller than the buffer
6355 size if the message was truncated. (Bug#8545).
6357 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6359 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6360 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6362 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6364 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6366 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6368 * makefile.w32-in: Update dependencies.
6370 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6372 Improve `doprnt' and its usage. (Bug#8545)
6373 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6374 `format_end'. Remove support for %l as a conversion specifier.
6375 Don't use xrealloc. Improve diagnostics when the %l size modifier
6376 is used. Update the commentary.
6378 * eval.c (verror): Simplify calculation of size_t.
6380 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6383 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6385 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6388 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6390 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6391 This makes this file independent of the recent pseudovector change.
6393 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6395 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6397 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6398 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6399 Remove unused local.
6400 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6402 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6403 GCC 4.6.0 optimizes based on type-based alias analysis.
6404 For example, if b is of type struct buffer * and v of type struct
6405 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6406 != &v->size, and therefore "v->size = 1; b->size = 2; return
6407 v->size;" must therefore return 1. This assumption is incorrect
6408 for Emacs, since it type-puns struct Lisp_Vector * with many other
6409 types. To fix this problem, this patch adds a new type struct
6410 vectorlike_header that documents the constraints on layout of vectors
6411 and pseudovectors, and helps optimizing compilers not get fooled
6412 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6413 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6414 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6416 (XSETPVECTYPE): Rewrite in terms of new macro.
6417 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6418 This is a bit clearer, and further avoids the possibility of
6419 undesirable aliasing.
6420 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6421 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6422 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6423 since Lisp_Subr is a special case (no "next" field).
6424 (ASIZE): Now uses header.size rather than size.
6425 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6426 to avoid the hassle of writing XVECTOR (foo)->header.size.
6427 (struct vectorlike_header): New type.
6428 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6429 object, to help avoid aliasing.
6430 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6431 (SUBRP): Likewise, since Lisp_Subr is a special case.
6432 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6433 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6434 (struct Lisp_Hash_Table): Combine first two members into a single
6435 struct vectorlike_header member. All uses of "size" and "next" members
6436 changed to be "header.size" and "header.next".
6437 * buffer.h (struct buffer): Likewise.
6438 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6439 * frame.h (struct frame): Likewise.
6440 * process.h (struct Lisp_Process): Likewise.
6441 * termhooks.h (struct terminal): Likewise.
6442 * window.c (struct save_window_data, struct saved_window): Likewise.
6443 * window.h (struct window): Likewise.
6444 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6445 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6446 * buffer.c (init_buffer_once): Likewise.
6447 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6449 * process.c (Fformat_network_address): Use local var for size,
6452 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6454 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6455 * data.c (atof): Remove decl; no longer used or needed.
6456 (digit_to_number): Move to lread.c.
6457 (Fstring_to_number): Use new string_to_number function, to be
6458 consistent with how the Lisp reader treats infinities and NaNs.
6459 Do not assume that floating-point numbers represent EMACS_INT
6460 without losing information; this is not true on most 64-bit hosts.
6461 Avoid double-rounding errors, by insisting on integers when
6462 parsing non-base-10 numbers, as the documentation specifies.
6463 * lisp.h (string_to_number): New decl, replacing ...
6464 (isfloat_string): Remove.
6465 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6466 (read1): Do not accept +. and -. as integers; this
6467 appears to have been a coding error. Similarly, do not accept
6468 strings like +-1e0 as floating point numbers. Do not report
6469 overflow for integer overflows unless the base is not 10 which
6470 means we have no simple and reliable way to continue.
6471 Break out the floating-point parsing into a new
6472 function string_to_number, so that Fstring_to_number parses
6473 floating point numbers consistently with the Lisp reader.
6474 (digit_to_number): Move here from data.c. Make it static inline.
6475 (E_CHAR, EXP_INT): Remove, replacing with ...
6476 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6477 (string_to_number): New function, replacing isfloat_string.
6478 This function checks for valid syntax and produces the resulting
6479 Lisp float number too. Rework it so that string-to-number
6480 no longer mishandles examples like "1.0e+". Use strtoumax,
6481 so that overflow for non-base-10 numbers is reported only when
6482 there's no portable and simple way to convert to floating point.
6484 * textprop.c (set_text_properties_1): Rewrite for clarity,
6485 and to avoid GCC warning about integer overflow.
6487 * intervals.h (struct interval): Use EMACS_INT for members
6488 where EMACS_UINT might cause problems. See
6489 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6490 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6491 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6493 (offset_intervals): Tell GCC not to worry about length overflow
6494 when negating a negative length.
6496 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6497 (overrun_check_free): Likewise.
6499 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6500 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6503 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6504 (gnutls_make_error): Rename local to avoid shadowing.
6505 (gnutls_emacs_global_deinit): ifdef out; not used.
6506 (Fgnutls_boot): Use const for pointer to readonly storage.
6507 Comment out unused local. Fix pointer signedness problems.
6509 * lread.c (openp): Don't stuff size_t into an 'int'.
6510 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6511 about possible signed overflow.
6513 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6514 (GDK_KEY_g): Don't define if already defined.
6515 (xg_prepare_tooltip): Avoid pointer signedness problem.
6516 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6518 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6519 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6521 * xfns.c (Fx_window_property): Simplify a bit,
6522 to make a bit faster and to avoid GCC 4.6.0 warning.
6523 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6525 * fns.c (internal_equal): Don't assume size_t fits in int.
6527 * alloc.c (compact_small_strings): Tighten assertion a little.
6529 Replace pEd with more-general pI, and fix some printf arg casts.
6530 * lisp.h (pI): New macro, generalizing old pEd macro to other
6531 conversion specifiers. For example, use "...%"pI"d..." rather
6532 than "...%"pEd"...".
6533 (pEd): Remove. All uses replaced with similar uses of pI.
6534 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6535 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6536 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6537 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6538 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6539 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6540 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6542 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6543 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6544 * print.c (safe_debug_print, print_object): Likewise.
6545 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6547 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6548 avoiding the 0 flag, which is not portable.
6549 * process.c (Fmake_network_process): Use pI to avoid cast.
6550 * region-cache.c (pp_cache): Likewise.
6551 * xdisp.c (decode_mode_spec): Likewise.
6552 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6553 behavior on 64-bit hosts with printf arg.
6554 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6555 (x_stop_queuing_selection_requests): Likewise.
6556 (x_get_window_property): Don't truncate byte count to an 'int'
6559 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6560 here, since it parses constructs like leading '-' and spaces,
6561 which are not wanted; and it overflows with large numbers.
6562 Instead, simply match F[0-9]+, which is what is wanted anyway.
6564 * alloc.c: Remove unportable assumptions about struct layout.
6565 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6566 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6567 (allocate_vectorlike, make_pure_vector): Use the new macros,
6568 plus offsetof, to remove unportable assumptions about struct layout.
6569 These assumptions hold on all porting targets that I know of, but
6570 they are not guaranteed, they're easy to remove, and removing them
6571 makes further changes easier.
6573 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6574 This doesn't fix a bug but makes the code clearer.
6575 (string_overrun_cookie): Now const. Use initializers that
6576 don't formally overflow signed char, to avoid warnings.
6577 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6578 can cause Emacs to crash when string overrun checking is enabled.
6579 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6580 multiple of sizeof (EMACS_INT); it need not be, if
6581 alignof(EMACS_INT) < sizeof (EMACS_INT).
6582 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6584 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6586 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6588 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6590 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6591 supposed to be handshaking. (Bug#8556)
6592 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6594 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6596 * lisp.h (Qdebug): List symbol.
6597 * eval.c (Qdebug): Restore global linkage.
6598 * keyboard.c (debug-on-event): New variable.
6599 (handle_user_signal): Break into debugger when debug-on-event
6600 matches the current signal symbol.
6602 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6604 * alloc.c (check_sblock, check_string_bytes)
6605 (check_string_free_list): Convert to standard C.
6607 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6609 * w32.c (emacs_gnutls_push): Fix typo.
6611 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6613 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6614 "cast to pointer from integer of different size".
6616 Improve doprnt and its use in verror. (Bug#8545)
6617 * doprnt.c (doprnt): Document the set of format control sequences
6618 supported by the function. Use SAFE_ALLOCA instead of always
6621 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6622 is one byte too soon. Don't use xrealloc; instead xfree and
6625 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6627 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6630 * gnutls.c: Renamed global_initialized to
6631 gnutls_global_initialized. Added internals for the
6632 :verify-hostname-error, :verify-error, and :verify-flags
6633 parameters of `gnutls-boot' and documented those parameters in the
6634 docstring. Start callback support.
6635 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6636 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6637 on error. Return error code.
6638 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6639 (emacs_gnutls_read): Likewise.
6640 (Fgnutls_boot): Return handshake error code.
6641 (emacs_gnutls_handle_error): New function.
6642 (wsaerror_to_errno): Likewise.
6644 * w32.h (emacs_gnutls_pull): Add prototype.
6645 (emacs_gnutls_push): Likewise.
6647 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6648 (emacs_gnutls_push): Likewise.
6650 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6652 * process.c (wait_reading_process_output): Check if GnuTLS
6653 buffered some data internally if no FDs are set for TLS
6656 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6657 (LIBS): Link to USER_LIBS.
6658 ($(BLD)/gnutls.$(0)): New target.
6660 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6662 * xdisp.c (handle_single_display_spec): Rename the
6663 display_replaced_before_p argument into display_replaced_p, to
6664 make it consistent with the commentary. Fix typos in the
6667 * textprop.c (syms_of_textprop): Remove dead code.
6668 (copy_text_properties): Delete obsolete commentary about an
6669 interface that was deleted long ago. Fix typos in the description
6672 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6673 to changes in oldXMenu/XMenu.h from 2011-04-16.
6674 <menu_help_message, prev_menu_help_message>: Constify.
6675 (IT_menu_make_room): menu->help_text is now `const char **';
6678 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6679 to changes in oldXMenu/XMenu.h from 2011-04-16.
6680 (struct XMenu): Declare `help_text' `const char **'.
6682 * xfaces.c <Qunspecified>: Make extern again.
6684 * syntax.c: Include sys/types.h before including regex.h, as
6687 * doc.c (get_doc_string): Improve the format passed to `error'.
6689 * doprnt.c (doprnt): Improve commentary.
6691 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6693 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6696 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6697 changes in globals.h immediately force recompilation.
6698 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6699 $(CURDIR)/s/ms-w32.h.
6700 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6702 * character.c (Fchar_direction): Function deleted.
6703 (syms_of_character): Don't defsubr it.
6704 <char-direction-table>: Deleted.
6706 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6708 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6709 * doprnt.c: Include limits.h.
6710 (SIZE_MAX): New macro.
6711 (doprnt): Return a size_t value. 2nd arg is now size_t.
6712 Many local variables are now size_t instead of int or unsigned.
6713 Improve overflow protection. Support `l' modifier for integer
6714 conversions. Support %l conversion. Don't assume an EMACS_INT
6715 argument for integer conversions and for %c.
6717 * lisp.h (doprnt): Restore prototype.
6719 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6722 * Makefile.in (base_obj): Add back doprnt.o.
6724 * deps.mk (doprnt.o): Add back prerequisites.
6725 (callint.o): Depend on character.h.
6727 * eval.c (internal_lisp_condition_case): Include the handler
6728 representation in the error message.
6729 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6730 when breaking from the loop.
6732 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6734 * callint.c (Fcall_interactively): When displaying error message
6735 about invalid control letter, pass the character's codepoint, not
6736 a pointer to its multibyte form. Improve display of the character
6737 in octal and display also its hex code.
6739 * character.c (char_string): Use %x to display the (unsigned)
6740 codepoint of an invalid character, to avoid displaying a bogus
6743 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6744 `error', not SYMBOL_NAME itself.
6746 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6747 character arguments to `error'.
6749 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6750 to `error' in error message about FINAL_CHAR argument. Make sure
6751 FINAL_CHAR is a character, and use %c when it is passed as
6752 argument to `error'.
6754 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6756 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6758 * w32.c: Include <time.h>.
6759 (sys_localtime): New function.
6761 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6763 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6765 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6767 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6769 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6772 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6774 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6775 gl_state.e_property when gl_state.object is Qt.
6777 * insdel.c (make_gap_larger): Remove limitation of buffer size
6780 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6782 * xdisp.c (lookup_glyphless_char_display)
6783 (produce_glyphless_glyph): Handle cons cell entry in
6784 glyphless-char-display.
6785 (Vglyphless_char_display): Document it.
6787 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6788 glyphless-char-display.
6790 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6792 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6794 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6796 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6797 definition for no-X builds.
6799 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6801 Static checks with GCC 4.6.0 and non-default toolkits.
6803 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6805 * process.c (keyboard_bit_set): Define only if SIGIO.
6806 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6807 (send_process): Repair possible setjmp clobbering.
6809 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6811 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6813 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6815 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6816 Define only if needed.
6818 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6819 by pacifying GCC about it. Maybe it's time to retire it?
6820 * xfaces.c (USG, __TIMEVAL__): Likewise.
6822 * dispextern.h (struct redisplay_interface): Rename param
6824 * termhooks.h (struct terminal): Likewise.
6825 * xterm.c (xembed_send_message): Likewise.
6827 * insdel.c (make_gap_smaller): Define only if
6828 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6830 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6833 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6834 so that we aren't warned about unused symbols.
6836 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6838 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6840 * xfns.c (x_real_positions): Mark locals as initialized.
6842 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6844 * xterm.c: Fix problems found by static analysis with other toolkits.
6845 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6846 (x_dispatch_event): Declare static if USE_GTK, and
6847 define if USE_GTK || USE_X_TOOLKIT.
6848 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6849 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6850 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6851 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6853 * xmenu.c (menu_help_callback): Pointer type fixes.
6854 Use const pointers when pointing at readonly data. Avoid pointer
6856 (FALSE): Remove unused macro.
6857 (update_frame_menubar): Remove unused decl.
6859 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6861 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6862 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6863 (single_menu_item): Rename local to avoid shadowing.
6865 * keyboard.c (make_lispy_event): Remove unused local var.
6867 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6868 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6870 * bitmaps: Change bitmaps from unsigned char back to the X11
6871 compatible char. Avoid the old compiler warnings about
6872 out-of-range initializers by using, for example, '\xab' rather
6875 * xgselect.c (xgselect_initialize): Check vs interface
6876 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6878 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6880 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6881 to read-only memory.
6883 * fns.c (vector): Remove; this old hack is no longer needed.
6885 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6887 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6889 * xrdb.c (x_load_resources): Omit unused local.
6891 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6892 (x_window): Rename locals to avoid shadowing.
6893 (USG): Use the kludged USG macro, to pacify gcc.
6895 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6896 (x_term_init): Remove local to avoid shadowing.
6898 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6900 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6901 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6903 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6905 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6907 Fix regex.c, syntax.c and friends for buffers > 2GB.
6908 * syntax.h (struct gl_state_s): Declare character position members
6911 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6913 * textprop.c (verify_interval_modification, interval_of):
6914 Declare arguments EMACS_INT.
6916 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6919 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6921 * indent.c (Fvertical_motion): Local variable it_start is now
6924 * regex.c (re_match, re_match_2, re_match_2_internal)
6925 (bcmp_translate, regcomp, regexec, print_double_string)
6926 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6927 (re_compile_pattern, re_exec): Declare arguments and local
6928 variables `size_t' and `ssize_t' and return values `regoff_t', as
6930 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6931 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6932 <compile_stack_type>: `size' and `avail' are now `size_t'.
6934 * regex.h <regoff_t>: Use ssize_t, not int.
6935 (re_search, re_search_2, re_match, re_match_2): Arguments that
6936 specify buffer/string position and length are now ssize_t and
6937 size_t. Return type is regoff_t.
6939 2011-04-16 Ben Key <bkey76@gmail.com>
6941 * nsfont.m: Fixed bugs in ns_get_family and
6942 ns_descriptor_to_entity that were caused by using free to
6943 deallocate memory blocks that were allocated by xmalloc (via
6944 xstrdup). This caused Emacs to crash when compiled with
6945 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6946 --enable-checking=xmallocoverrun). xfree is now used to
6947 deallocate these memory blocks.
6949 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6951 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6953 emacs_write: Accept and return EMACS_INT for sizes.
6954 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6956 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6957 Accept and return EMACS_INT.
6958 (emacs_gnutls_write): Return the number of bytes written on
6960 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6961 (emacs_read, emacs_write): Remove check for negative size, as the
6962 Emacs source code has been audited now.
6963 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6964 (emacs_read, emacs_write): Use it.
6965 * process.c (send_process): Adjust to the new signatures of
6966 emacs_write and emacs_gnutls_write. Do not attempt to store
6967 a byte offset into an 'int'; it might overflow.
6968 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6970 * sound.c: Don't assume sizes fit in 'int'.
6971 (struct sound_device.period_size, alsa_period_size):
6972 Return EMACS_INT, not int.
6973 (struct sound_device.write, vox_write, alsa_write):
6974 Accept EMACS_INT, not int.
6975 (wav_play, au_play): Use EMACS_INT to store sizes and to
6976 record read return values.
6978 2011-04-15 Ben Key <bkey76@gmail.com>
6980 * keyboard.c (Qundefined): Don't declare static since it is used
6982 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6983 static since they are used in nsfont.m.
6985 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6987 * process.c (Qprocessp): Don't declare static.
6988 * lisp.h (Qprocessp): Declare again.
6990 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6992 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6994 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6996 Improve C-level modularity by making more things 'static'.
6998 Don't publish debugger-only interfaces to other modules.
6999 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7000 (verify_bytepos, count_markers): Move decls to the only modules
7002 * region-cache.h (pp_cache): Likewise.
7003 * window.h (check_all_windows): Likewise.
7004 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7006 * sysdep.c (croak): Now static, if
7007 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7008 * syssignal.h (croak): Declare only if not static.
7010 * alloc.c (refill_memory_reserve): Now static if
7011 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7012 * lisp.h (refill_memory_reserve): Declare only if not static.
7014 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7015 Define only if USE_LUCID.
7017 * xrdb.c (x_customization_string, x_rm_string): Now static.
7019 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7020 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7022 * xdisp.c (draw_row_with_mouse_face): Now static.
7023 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7025 * window.h (check_all_windows): Mark externally visible.
7027 * window.c (window_deletion_count): Now static.
7029 * undo.c: Make symbols static if they're not exported.
7030 (last_undo_buffer, last_boundary_position, pending_boundary):
7033 * textprop.c (interval_insert_behind_hooks): Now static.
7034 (interval_insert_in_front_hooks): Likewise.
7036 * term.c: Make symbols static if they're not exported.
7037 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7038 (max_frame_lines, tty_set_terminal_modes):
7039 (tty_reset_terminal_modes, tty_turn_off_highlight):
7040 (get_tty_terminal): Now static.
7041 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7042 * termhooks.h (term_mouse_moveto): Do not declare if
7044 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7045 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7047 * sysdep.c: Make symbols static if they're not exported.
7048 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7050 (sigprocmask_set, full_mask): Remove; unused.
7051 (wait_debugging): Mark as visible.
7052 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7053 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7055 * syntax.c (syntax_temp): Define only if !__GNUC__.
7057 * sound.c (current_sound_device, current_sound): Now static.
7059 * search.c (searchbufs, searchbuf_head): Now static.
7061 * scroll.c (scroll_cost): Remove; unused.
7062 * dispextern.h (scroll_cost): Remove decl.
7064 * region-cache.h (pp_cache): Mark as externally visible.
7066 * process.c: Make symbols static if they're not exported.
7067 (process_tick, update_tick, create_process, chan_process):
7068 (Vprocess_alist, proc_buffered_char, datagram_access):
7069 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7070 (deactivate_process): Mark defn as static, as well as decl.
7071 * lisp.h (create_process): Remove decl.
7072 * process.h (chan_process, Vprocess_alist): Remove decls.
7074 * print.c: Make symbols static if they're not exported.
7075 (print_depth, new_backquote_output, being_printed, print_buffer):
7076 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7077 (print_interval, print_number_index, initial_stderr_stream):
7079 * lisp.h (Fprinc): Remove decl.
7080 (debug_output_compilation_hack): Mark as externally visible.
7082 * sysdep.c (croak): Move decl from here to syssignal.h.
7083 * syssignal.h (croak): Put it here, so the API can be checked when
7084 'croak' is called from dissociate_if_controlling_tty.
7086 * minibuf.c: Make symbols static if they're not exported.
7087 (minibuf_save_list, choose_minibuf_frame): Now static.
7088 * lisp.h (choose_minibuf_frame): Remove decl.
7090 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7092 * lread.c: Make symbols static if they're not exported.
7093 (read_objects, initial_obarray, oblookup_last_bucket_number):
7095 (make_symbol): Remove; unused.
7096 * lisp.h (initial_obarray, make_symbol): Remove decls.
7098 * keyboard.c: Make symbols static if they're not exported.
7099 (single_kboard, recent_keys_index, total_keys, recent_keys):
7100 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7101 (this_single_command_key_start, echoing, last_auto_save):
7102 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7103 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7104 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7105 (Vlispy_mouse_stem, double_click_count):
7107 (force_auto_save_soon): Define only if SIGDANGER.
7108 (ignore_mouse_drag_p): Now static if
7109 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7110 (print_help): Remove; unused.
7111 (stop_character, last_timer_event): Mark as externally visible.
7112 * keyboard.h (ignore_mouse_drag_p): Declare only if
7113 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7114 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7115 * lisp.h (echoing): Remove decl.
7116 (force_auto_save_soon): Declare only if SIGDANGER.
7117 * xdisp.c (redisplay_window): Simplify code, to make it more
7118 obvious that ignore_mouse_drag_p is not accessed if !defined
7119 USE_GTK && !defined HAVE_NS.
7121 * intervals.c: Make symbols static if they're not exported.
7122 (merge_properties_sticky, merge_interval_right, delete_interval):
7124 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7126 * insdel.c: Make symbols static if they're not exported.
7127 However, leave prepare_to_modify_buffer alone. It's never
7128 called from outside this function, but that appears to be a bug.
7129 (combine_after_change_list, combine_after_change_buffer):
7130 (adjust_after_replace, signal_before_change): Now static.
7131 (adjust_after_replace_noundo): Remove; unused.
7132 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7133 (signal_before_change): Remove decls.
7135 * indent.c (val_compute_motion, val_vmotion): Now static.
7137 * image.c: Make symbols static if they're not exported.
7138 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7140 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7141 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7143 * fringe.c (standard_bitmaps): Now static.
7144 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7146 * frame.c: Make symbols static if they're not exported.
7147 (x_report_frame_params, make_terminal_frame): Now static.
7148 (get_frame_param): Now static, unless HAVE_NS.
7149 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7150 (x_get_resource_string): Remove; not used.
7151 * frame.h (make_terminal_frame, x_report_frame_params):
7152 (x_get_resource_string); Remove decls.
7153 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7154 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7156 * font.c, fontset.c: Make symbols static if they're not exported.
7157 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7158 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7159 * font.c (font_close_object): Now static.
7160 * font.h (font_close_object): Remove.
7161 * fontset.c (FONTSET_OBJLIST): Remove.
7162 (free_realized_fontset) #if-0 the body, which does nothing.
7163 (face_suitable_for_char_p): #if-0, as it's never called.
7164 * fontset.h (face_suitable_for_char_p): Remove decl.
7165 * xfaces.c (face_at_string_position):
7166 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7167 since 0 is always ASCII.
7169 * fns.c (weak_hash_tables): Now static.
7171 * fileio.c: Make symbols static if they're not exported.
7172 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7173 (Vwrite_region_annotation_buffers): Now static.
7175 * eval.c: Make symbols static if they're not exported.
7176 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7177 * lisp.h (backtrace_list): Remove decl.
7179 * emacs.c: Make symbols static if they're not exported.
7180 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7181 (fatal_error_code, fatal_error_signal_hook, standard_args):
7183 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7184 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7185 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7186 * lisp.h (fatal_error_signal_hook): Remove decl.
7187 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7189 * editfns.c: Move a (normally-unused) function to its only use.
7190 * editfns.c, lisp.h (get_operating_system_release): Remove.
7191 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7192 worth the hassle of breaking this out.
7194 * xterm.c: Make symbols static if they're not exported.
7195 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7196 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7197 (x_destroy_window, x_delete_display):
7199 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7200 (x_mouse_leave): Remove; unused.
7201 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7202 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7203 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7205 (x_mouse_leave): Declare only if WINDOWSNT.
7206 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7207 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7210 * ftxfont.c: Make symbols static if they're not exported.
7211 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7213 * font.h (ftxfont_driver): Likewise.
7215 * xfns.c: Make symbols static if they're not exported.
7216 (x_last_font_name, x_display_info_for_name):
7217 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7218 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7219 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7220 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7221 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7222 (last_show_tip_args): Now static.
7223 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7224 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7225 (x_screen_planes): Remove; unused.
7226 * dispextern.h (x_screen_planes): Remove decl.
7228 * dispnew.c: Make symbols static if they're not exported.
7229 * dispextern.h (redraw_garbaged_frames, scrolling):
7230 (increment_row_positions): Remove.
7231 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7232 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7234 (redraw_garbaged_frames): Remove; unused.
7236 * xfaces.c: Make symbols static if they're not exported.
7237 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7239 * xterm.h (defined_color): Remove decls.
7240 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7241 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7242 (menu_face_changed_default, defined_color, free_realized_face):
7243 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7244 (ascii_face_of_lisp_face): Remove; unused.
7246 * xdisp.c: Make symbols static if they're not exported.
7247 * dispextern.h (scratch_glyph_row, window_box_edges):
7248 (glyph_to_pixel_coords, set_cursor_from_row):
7249 (get_next_display_element, set_iterator_to_next):
7250 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7251 (show_mouse_face): Remove decls
7252 * frame.h (message_buf_print): Likewise.
7253 * lisp.h (pop_message, set_message, check_point_in_composition):
7255 * xterm.h (set_vertical_scroll_bar): Likewise.
7256 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7257 (message_buf_print, scratch_glyph_row, displayed_buffer):
7258 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7259 (get_next_display_element, show_mouse_face, window_box_edges):
7260 (frame_to_window_pixel_xy, check_point_in_composition):
7261 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7262 (glyph_to_pixel_coords): Remove; unused.
7264 * dired.c (file_name_completion): Now static.
7266 * dbusbind.c (xd_in_read_queued_messages): Now static.
7268 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7269 * data.c (circular_list_error): Remove.
7271 * commands.h (last_point_position, last_point_position_buffer):
7272 (last_point_position_window): Remove decls.
7273 * keyboard.c: Make these variables static.
7275 * coding.h (coding, code_convert_region, encode_coding_gap):
7277 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7278 (iso_code_class, detect_coding, code_convert_region): Now static.
7279 (encode_coding_gap): Remove; unused.
7281 * chartab.c (chartab_chars, chartab_bits): Now static.
7283 * charset.h (charset_iso_8859_1): Remove decl.
7284 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7287 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7288 * ccl.c (Vccl_program_table): Now static.
7289 (check_ccl_update): Remove; unused.
7291 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7292 * category.h: ... from here.
7293 * category.c (check_category_table, set_category_set): Now static.
7295 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7296 * lisp.h: Remove these decls.
7298 * buffer.c (buffer_count): Remove unused var.
7300 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7301 so that it's not optimized away.
7302 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7303 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7304 exported only to the debugger.
7306 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7307 * atimer.h (run_all_atimers): Remove; not exported.
7309 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7310 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7311 was inaccessible from Lisp.
7312 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7313 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7315 alloc.c: Import and export fewer symbols, and remove unused items.
7316 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7318 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7319 it's not optimized away by whole-program optimization.
7320 (message_enable_multibyte, free_misc): Remove.
7321 (catchlist, handlerlist, mark_backtrace):
7322 Declare only if BYTE_MARK_STACK.
7323 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7324 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7325 (message_enable_multibyte): Remove decl.
7326 (free_misc, interval_free_list, float_block, float_block_index):
7327 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7328 (cons_free_list, last_marked_index):
7330 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7331 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7332 (mark_backtrace): Define only if BYTE_MARK_STACK.
7333 * xdisp.c (message_enable_multibyte): Now static.
7335 Declare Lisp_Object Q* variables to be 'static' if not exported.
7336 This makes it easier for human readers (and static analyzers)
7337 to see whether these variables are used from other modules.
7338 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7339 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7340 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7341 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7342 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7343 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7344 * xmenu.c, xselect.c:
7345 Declare Q* vars static if they are not used in other modules.
7346 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7347 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7348 Remove decls of unexported vars.
7349 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7351 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7353 Make Emacs functions such as Fatom 'static' by default.
7354 This makes it easier for human readers (and static analyzers)
7355 to see whether these functions can be called from other modules.
7356 DEFUN now defines a static function. To make the function external
7357 so that it can be used in other C modules, use the new macro DEFUE.
7358 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7359 (Finit_image_library):
7360 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7361 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7362 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7363 Remove decls, since these functions are now static.
7364 (Funintern, Fget_internal_run_time): New decls, since these functions
7365 were already external.
7367 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7368 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7369 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7370 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7371 * keyboard.c, keymap.c, lread.c:
7372 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7373 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7374 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7375 Mark functions with DEFUE instead of DEFUN,
7376 if they are used in other modules.
7377 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7378 decls for now-static functions.
7379 * buffer.h (Fdelete_overlay): Remove decl.
7380 * callproc.c (Fgetenv_internal): Mark as internal.
7381 * composite.c (Fremove_list_of_text_properties): Remove decl.
7382 (Fcomposition_get_gstring): New forward static decl.
7383 * composite.h (Fcomposite_get_gstring): Remove decl.
7384 * dired.c (Ffile_attributes): New forward static decl.
7385 * doc.c (Fdocumntation_property): New forward static decl.
7386 * eval.c (Ffetch_bytecode): New forward static decl.
7387 (Funintern): Remove extern decl; now in .h file where it belongs.
7388 * fileio.c (Fmake_symbolic_link): New forward static decl.
7389 * image.c (Finit_image_library): New forward static decl.
7390 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7391 * intervals.h (Fprevious_property_change):
7392 (Fremove_list_of_text_properties): Remove decls.
7393 * keyboard.c (Fthis_command_keys): Remove decl.
7394 (Fcommand_execute): New forward static decl.
7395 * keymap.c (Flookup_key): New forward static decl.
7396 (Fcopy_keymap): Now static.
7397 * keymap.h (Flookup_key): Remove decl.
7398 * process.c (Fget_process): New forward static decl.
7399 (Fprocess_datagram_address): Mark as internal.
7400 * syntax.c (Fsyntax_table_p): New forward static decl.
7401 (skip_chars): Remove duplicate decl.
7402 * textprop.c (Fprevious_property_change): New forward static decl.
7403 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7405 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7406 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7408 * editfns.c (Fformat): Remove unreachable code.
7410 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7412 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7415 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7417 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7418 when at ZV. (Bug#8487)
7420 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7422 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7424 * keyboard.c (parse_tool_bar_item): Likewise.
7425 * sound.c (sound_cleanup, alsa_close): Likewise.
7426 * termcap.c (tgetent): Likewise.
7427 * xfns.c (x_default_font_parameter): Likewise.
7428 * xsettings.c (read_and_apply_settings): Likewise.
7430 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7431 (overrun_check_free): Protoize.
7433 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7435 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7436 since callers should never pass a negative size.
7437 Change the signature to match that of plain 'read' and 'write'; see
7438 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7439 * lisp.h: Update prototypes of emacs_write and emacs_read.
7441 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7443 * xdisp.c (redisplay_window): Don't try to determine the character
7444 position of the scroll margin if the window start point w->startp
7445 is outside the buffer's accessible region. (Bug#8468)
7447 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7449 Fix write-region and its subroutines for buffers > 2GB.
7450 * fileio.c (a_write, e_write): Modify declaration of arguments and
7451 local variables to support buffers larger than 2GB.
7452 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7454 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7455 argument, local variables, and return value.
7457 * lisp.h: Update prototypes of emacs_write and emacs_read.
7459 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7461 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7463 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7465 Fix more problems found by GCC 4.6.0's static checks.
7467 * xdisp.c (vmessage): Use a better test for character truncation.
7469 * charset.c (load_charset_map): <, not <=, for optimization,
7470 and to avoid potential problems with integer overflow.
7471 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7472 * casetab.c (set_identity, shuffle): Likewise.
7473 * editfns.c (Fformat): Likewise.
7474 * syntax.c (skip_chars): Likewise.
7476 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7477 This also lets GCC 4.6.0 generate slightly better loop code.
7479 * callint.c (Fcall_interactively): <, not <=, for optimization.
7480 (Fcall_interactively): Count the number of arguments produced,
7481 not the number of arguments given. This is simpler and lets GCC
7482 4.6.0 generate slightly better code.
7484 * ftfont.c: Distingish more carefully between FcChar8 and char.
7485 The previous code passed unsigned char * to a functions like
7486 strlen and xstrcasecmp that expect char *, which does not
7487 conform to the C standard.
7488 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7489 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7490 char * when the C standard requires it.
7492 * keyboard.c (read_char): Remove unused var.
7494 * eval.c: Port to Windows vsnprintf (Bug#8435).
7496 (SIZE_MAX): Define if the headers do not.
7497 (verror): Do not give up if vsnprintf returns a negative count.
7498 Instead, grow the buffer. This ports to Windows vsnprintf, which
7499 does not conform to C99. Problem reported by Eli Zaretskii.
7500 Also, simplify the allocation scheme, by avoiding the need for
7501 calling realloc, and removing the ALLOCATED variable.
7503 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7505 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7506 But keep the doprint source code for now, as we might revamp it
7507 and use it again (Bug#8435).
7508 * lisp.h (doprnt): Remove.
7509 * Makefile.in (base_obj): Remove doprnt.o.
7510 * deps.mk (doprnt.o): Remove.
7512 error: Print 32- and 64-bit integers portably (Bug#8435).
7513 Without this change, on typical 64-bit hosts error ("...%d...", N)
7514 was used to print both 32- and 64-bit integers N, which relied on
7516 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7518 * lisp.h (error, verror): Mark as printf-like functions.
7519 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7520 Report overflow in size calculations when allocating printf buffer.
7521 Do not truncate output string at its first null byte.
7522 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7523 Truncate the output at a character boundary, since vsnprintf does not
7525 * charset.c (check_iso_charset_parameter): Convert internal
7526 character to string before calling 'error', since %c now has the
7528 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7529 overflow when computing char to be passed to 'error'. Do not
7530 pass Lisp_Object to 'error'; pass the integer instead.
7531 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7532 formatted with plain %d.
7534 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7536 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7538 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7540 * xterm.c (x_catch_errors): Remove duplicate declaration.
7542 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7544 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7546 2011-04-10 Jim Meyering <meyering@redhat.com>
7548 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7549 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7550 return ssize_t not "int", and use size_t as the buffer length.
7551 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7552 * gnutls.h: Update declarations.
7553 * process.c (read_process_output): Use ssize_t, to match.
7554 (send_process): Likewise.
7556 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7558 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7560 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7562 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7563 Use unsigned char, to match FcChar8 type definition.
7565 * xterm.c (handle_one_xevent):
7566 * xmenu.c (create_and_show_popup_menu):
7567 * xselect.c (x_decline_selection_request)
7568 (x_reply_selection_request): Avoid type-punned deref of X events.
7570 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7572 Fix some uses of `int' instead of EMACS_INT.
7573 * search.c (string_match_1, fast_string_match)
7574 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7575 (scan_buffer, find_next_newline_no_quit)
7576 (find_before_next_newline, search_command, Freplace_match)
7577 (Fmatch_data): Make some `int' variables be EMACS_INT.
7579 * xdisp.c (display_count_lines): 3rd argument and return value now
7580 EMACS_INT. All callers changed.
7581 (pint2hrstr): Last argument is now EMACS_INT.
7583 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7584 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7585 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7586 (decode_coding_utf_16, decode_coding_emacs_mule)
7587 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7588 (decode_coding_ccl, decode_coding_charset)
7589 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7590 (decode_coding_iso_2022, decode_coding_emacs_mule)
7591 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7592 <char_offset, last_offset>: Declare EMACS_INT.
7593 (encode_coding_utf_8, encode_coding_utf_16)
7594 (encode_coding_emacs_mule, encode_invocation_designation)
7595 (encode_designation_at_bol, encode_coding_iso_2022)
7596 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7597 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7599 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7600 (encode_invocation_designation): Last argument P_NCHARS is now
7602 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7603 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7605 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7608 * ccl.c (Fccl_execute_on_string): Declare some variables
7611 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7613 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7615 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7617 * process.c (Fformat_network_address): Doc fix.
7619 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7621 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7623 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7625 * keyboard.c (read_char): Call Lisp function help-form-show,
7626 instead of using internal_with_output_to_temp_buffer.
7627 (Qhelp_form_show): New var.
7628 (syms_of_keyboard): Use DEFSYM macro.
7630 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7632 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7634 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7636 * process.c (Flist_processes): Remove to Lisp.
7637 (list_processes_1): Delete.
7639 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7641 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7643 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7645 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7647 Fix more problems found by GCC 4.6.0's static checks.
7649 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7651 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7653 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7655 * xdisp.c (vmessage): Mark as a printf-like function.
7657 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7659 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7661 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7662 printf-like functions.
7663 (tiff_load): Add casts to remove these marks before passing them
7664 to system-supplied API.
7666 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7668 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7669 This avoids several warnings with gcc -Wstrict-overflow.
7670 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7671 directly, rather than having caller test rule sign. This avoids
7672 some unnecessary tests.
7673 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7674 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7675 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7677 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7678 (xfont_open): Avoid unnecessary tests.
7680 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7682 * composite.h, composite.c (composition_gstring_put_cache):
7683 Use EMACS_INT, not int, for length.
7685 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7686 breaking out part of COMPOSITION_DECODE_RULE.
7687 (COMPOSITION_DECODE_RULE): Use it.
7688 * composite.c (get_composition_id): Remove unused local vars,
7689 by using the new macro.
7691 * textprop.c (set_text_properties_1): Change while to do-while,
7692 since the condition is always true at first.
7694 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7695 (interval_deletion_adjustment): Return unsigned value.
7698 * process.c (list_processes_1, create_pty, read_process_output):
7699 (exec_sentinel): Remove vars that were set but not used.
7700 (create_pty): Remove unnecessary "volatile"s.
7701 (Fnetwork_interface_info): Avoid possibility of int overflow.
7702 (read_process_output): Do adaptive read buffering even if carryover.
7703 (read_process_output): Simplify nbytes computation if buffered.
7705 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7707 * syntax.c (scan_words): Remove var that was set but not used.
7708 (update_syntax_table): Use unsigned instead of int.
7710 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7711 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7712 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7714 * print.c (print_error_message): Avoid int overflow.
7716 * font.c (font_list_entities): Redo for clarity,
7717 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7719 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7720 (font_score): Avoid potential overflow in diff calculation.
7722 * fns.c (substring_both): Remove var that is set but not used.
7723 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7725 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7727 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7728 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7729 can always succeed if overflow has undefined behavior.
7731 * search.c (boyer_moore, wordify): Remove vars set but not used.
7732 (wordify): Omit three unnecessary tests.
7734 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7735 All callers changed. This avoids the need for an unused var.
7737 * casefiddle.c (casify_region): Remove var that is set but not used.
7739 * dired.c (file_name_completion): Remove var that is set but not used.
7741 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7743 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7744 (Finsert_file_contents): Remove unnecessary code checking fd.
7746 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7747 Check for integer overflow on size calculations.
7749 * buffer.c (Fprevious_overlay_change): Remove var that is set
7752 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7753 Remove vars that are set but not used.
7754 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7755 (timer_check_2): Mark vars as initialized.
7757 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7759 * image.c (lookup_image): Remove var that is set but not used.
7760 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7762 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7763 that are set but not used.
7765 * xfns.c (make_invisible_cursor): Don't return garbage
7766 if XCreateBitmapFromData fails (Bug#8410).
7768 * xselect.c (x_get_local_selection, x_handle_property_notify):
7769 Remove vars that are set but not used.
7771 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7772 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7774 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7775 Remove var that is set but not used.
7776 (scroll_bar_windows_size): Now size_t, not int.
7777 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7780 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7781 (map_tty_color) [!defined MSDOS]: Likewise.
7783 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7785 * coding.c: Remove vars that are set but not used.
7786 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7787 All callers changed.
7788 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7789 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7790 (decode_coding_charset): Remove vars that are set but not used.
7792 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7793 that is set but not used.
7795 * print.c (print_object): Remove var that is set but not used.
7797 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7798 The gnulib version avoids calling malloc in the usual case,
7799 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7800 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7801 * filelock.c (current_lock_owner): Likewise.
7802 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7803 * sysdep.c: Include allocator.h, careadlinkat.h.
7804 (emacs_no_realloc_allocator): New static constant.
7805 (emacs_readlink): New function.
7806 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7807 ../lib/careadlinkat.h.
7809 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7811 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7812 first non-nil return value).
7814 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7816 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7817 if not defined (Bug#8403).
7819 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7821 * xdisp.c (display_count_lines): Remove parameter `start',
7822 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7823 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7824 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7825 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7826 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7827 and thereabouts. All callers changed.
7828 (get_per_char_metric): Remove parameter `f', unused since
7829 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7831 2011-04-02 Jim Meyering <meyering@redhat.com>
7833 do not dereference NULL upon failed strdup
7834 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7835 (ns_get_family): Likewise.
7837 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7839 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7841 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7843 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7846 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7848 Add lexical binding.
7850 * window.c (Ftemp_output_buffer_show): New fun.
7851 (Fsave_window_excursion):
7852 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7854 * lread.c (lisp_file_lexically_bound_p): New function.
7855 (Fload): Bind Qlexical_binding.
7856 (readevalloop): Remove `evalfun' arg.
7857 Bind Qinternal_interpreter_environment.
7858 (Feval_buffer): Bind Qlexical_binding.
7859 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7861 (syms_of_lread): Declare `lexical-binding'.
7863 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7865 * keyboard.c (eval_dyn): New fun.
7866 (menu_item_eval_property): Use it.
7868 * image.c (parse_image_spec): Use Ffunctionp.
7870 * fns.c (concat, mapcar1): Accept byte-code-functions.
7872 * eval.c (Fsetq): Handle lexical vars.
7873 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7874 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7875 (FletX, Flet): Obey lexical binding.
7876 (Fcommandp): Handle closures.
7877 (Feval): New `lexical' arg.
7878 (eval_sub): New function extracted from Feval. Use it almost
7879 everywhere where Feval was used. Look up vars in lexical env.
7881 (Ffunctionp): Move from subr.el.
7882 (Ffuncall): Handle closures.
7883 (apply_lambda): Remove `eval_flags'.
7884 (funcall_lambda): Handle closures and new byte-code-functions.
7885 (Fspecial_variable_p): New function.
7886 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7887 but without exporting it to Lisp.
7889 * doc.c (Fdocumentation, store_function_docstring):
7890 * data.c (Finteractive_form): Handle closures.
7892 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7895 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7897 (exec_byte_code): New function extracted from Fbyte_code to handle new
7898 calling convention for byte-code-functions. Add new byte-codes.
7900 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7902 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7904 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7906 * xdisp.c (redisplay_internal): Fix prototype.
7908 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7910 * xdisp.c (SCROLL_LIMIT): New macro.
7911 (try_scrolling): Use it when setting scroll_limit.
7912 Limit scrolling to 100 screen lines.
7913 (redisplay_window): Even when falling back on "recentering",
7914 position point in the window according to scroll-conservatively,
7915 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7917 (try_scrolling): When point is above the window, allow searching
7918 as far as scroll_max, or one screenful, to compute vertical
7919 distance from PT to the scroll margin position. This prevents
7920 try_scrolling from unnecessarily failing when
7921 scroll-conservatively is set to a value slightly larger than the
7922 window height. Clean up the case of PT below the margin at bottom
7923 of window: scroll_max can no longer be INT_MAX. When aggressive
7924 scrolling is in use, don't let point enter the opposite scroll
7925 margin as result of the scroll.
7926 (syms_of_xdisp) <scroll-conservatively>: Document the
7927 threshold of 100 lines for never-recentering scrolling.
7929 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7931 * dispextern.h (move_it_by_lines):
7932 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7933 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7934 (message_log_check_duplicate): Remove parameters `prev_bol' and
7935 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7936 (redisplay_internal): Remove parameter `preserve_echo_area',
7937 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7939 * indent.c (Fvertical_motion):
7940 * window.c (window_scroll_pixel_based, Frecenter):
7941 Don't pass `need_y_p' to `move_it_by_lines'.
7943 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7945 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7946 steal a few bits to be more compact.
7947 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7948 Remove unneeded casts.
7950 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7952 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7954 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7955 binding" message (bug#7967).
7957 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7959 Fix more problems found by GCC 4.6.0's static checks.
7961 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7962 Remove unused local var.
7964 * editfns.c (Fmessage_box): Remove unused local var.
7966 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7967 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7968 Omit unused local vars.
7969 * window.c (shrink_windows): Omit unused local var.
7970 * menu.c (digest_single_submenu): Omit unused local var.
7971 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7972 Omit unused local var.
7974 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7975 Don't assume string length fits in int.
7976 (keyremap_step, read_key_sequence): Use size_t for sizes.
7977 (read_key_sequence): Don't check last_real_key_start redundantly.
7979 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7980 instead of alloca (Bug#8344).
7982 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7983 (Fbacktrace_frame): Don't assume nframes fits in int.
7985 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7987 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7990 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7992 * cm.c (calccost): Turn while-do into do-while, for clarity.
7994 * keyboard.c (syms_of_keyboard): Use the same style as later
7995 in this function when indexing through an array. This also
7996 works around GCC bug 48267.
7998 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8000 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8002 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8003 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8005 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8006 This avoids undefined behavior on integer overflow, and is a bit
8007 more convenient anyway since it is compared to a size_t variable.
8009 Variadic C functions now count arguments with size_t, not int.
8010 This avoids an unnecessary limitation on 64-bit machines, which
8011 caused (substring ...) to crash on large vectors (Bug#8344).
8012 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8013 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8014 All variadic functions and their callers changed accordingly.
8015 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8016 * data.c (arith_driver, float_arith_driver): Likewise.
8017 * editfns.c (general_insert_function): Likewise.
8018 * eval.c (struct backtrace.nargs, interactive_p)
8019 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8020 (funcall_lambda, mark_backtrace): Likewise.
8021 * fns.c (concat): Likewise.
8022 * frame.c (x_set_frame_parameters): Likewise.
8023 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8024 0 if not found, not -1. All callers changed.
8026 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8027 (stack_copy_size): Now size_t, not int.
8028 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8030 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8032 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8033 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8034 All callers changed.
8036 * lisp.h (multibyte_char_to_unibyte):
8037 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8038 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8039 * character.h (CHAR_TO_BYTE8):
8040 * cmds.c (internal_self_insert):
8041 * editfns.c (general_insert_function):
8042 * keymap.c (push_key_description):
8043 * search.c (Freplace_match):
8044 * xdisp.c (message_dolog, set_message_1): All callers changed.
8046 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8048 * keyboard.c (safe_run_hook_funcall): New function.
8049 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8050 don't set the hook to nil, but remove the offending function instead.
8051 (Qcommand_hook_internal): Remove, unused.
8052 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8053 Vcommand_hook_internal.
8055 * eval.c (enum run_hooks_condition): Remove.
8056 (funcall_nil, funcall_not): New functions.
8057 (run_hook_with_args): Call each function through a `funcall' argument.
8058 Remove `cond' argument, now redundant.
8059 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8060 (Frun_hook_with_args_until_failure): Adjust accordingly.
8061 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8063 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8065 * dispextern.h (string_buffer_position): Remove declaration.
8067 * print.c (strout): Remove parameter `multibyte', unused since
8068 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8070 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8071 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8072 All callers changed.
8074 * w32.c (_wsa_errlist): Use braces for struct initializers.
8076 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8077 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8078 All callers changed.
8079 (string_buffer_position): Likewise. Also, make static (it's never
8080 used outside xdisp.c).
8081 (cursor_row_p): Remove parameter `w', unused since
8082 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8083 (decode_mode_spec): Remove parameter `precision', introduced during
8084 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8085 All callers changed.
8087 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8089 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8091 2011-03-27 Anders Lindgren <andlind@gmail.com>
8093 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8094 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8095 (ns_update_auto_hide_menu_bar): New functions.
8096 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8097 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8098 ns_constrain_all_frames.
8099 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8100 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8102 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8104 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8106 2011-03-27 Glenn Morris <rgm@gnu.org>
8108 * syssignal.h: Replace RETSIGTYPE with void.
8109 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8110 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8111 Replace SIGTYPE with void everywhere.
8112 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8113 * s/template.h (SIGTYPE): Remove commented out definition.
8115 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8117 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8118 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8120 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8122 * w32.c (read_unc_volume): Use parameter `henum', instead of
8123 global variable `wget_enum_handle'.
8125 * keymap.c (describe_vector): Remove parameters `indices' and
8126 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8127 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8129 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8131 * keyboard.c (timer_check): Remove parameter `do_it_now',
8132 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8133 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8134 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8136 * keyboard.c (read_char):
8137 * w32menu.c (w32_menu_display_help):
8138 * xmenu.c (show_help_event, menu_help_callback):
8139 Adjust calls to `show_help_echo'.
8141 * gtkutil.c (xg_maybe_add_timer):
8142 * keyboard.c (readable_events):
8143 * process.c (wait_reading_process_output):
8144 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8146 * insdel.c (adjust_markers_gap_motion):
8147 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8148 (gap_left, gap_right): Don't call it.
8150 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8152 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8153 incurred during fontification.
8155 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8157 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8158 (DEFVAR_PER_BUFFER): Don't pass it.
8160 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8161 (scrolling_window): Don't pass it.
8163 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8165 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8167 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8169 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8170 of variables specific to SELinux and computation of `encoded_absname'.
8172 * image.c (XPutPixel): Remove unused variable `height'.
8174 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8176 * unexw32.c (get_section_info): Remove unused variable `section'.
8178 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8179 (system_process_attributes): Remove unused variable `sess'.
8180 (sys_read): Remove unused variable `err'.
8182 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8183 (w32_wnd_proc): Remove unused variable `isdead'.
8184 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8185 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8186 (x_create_tip_frame): Remove unused variable `tem'.
8188 * w32inevt.c (w32_console_read_socket):
8189 Remove unused variable `no_events'.
8191 * w32term.c (x_draw_composite_glyph_string_foreground):
8192 Remove unused variable `width'.
8194 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8196 * w32term.c (x_set_glyph_string_clipping):
8197 Don't pass uninitialized region to CombineRgn.
8199 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8201 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8202 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8203 (Fx_close_connection): Remove unused variable `i'.
8205 * w32font.c (w32font_draw): Return number of glyphs.
8206 (w32font_open_internal): Remove unused variable `i'.
8207 (w32font_driver): Add missing initializer.
8209 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8210 (fill_in_menu): Remove unused variable `items_added'.
8212 * w32term.c (last_mouse_press_frame): Remove static global variable.
8213 (w32_clip_to_row): Remove unused variable `f'.
8214 (x_delete_terminal): Remove unused variable `i'.
8216 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8217 (NOTHING): Remove unused static global variable.
8218 (uniscribe_check_otf): Remove unused variable `table'.
8219 (uniscribe_font_driver): Add missing initializers.
8221 2011-03-23 Julien Danjou <julien@danjou.info>
8223 * term.c (Fsuspend_tty, Fresume_tty):
8224 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8225 * window.c (temp_output_buffer_show):
8226 * insdel.c (signal_before_change):
8227 * frame.c (Fhandle_switch_frame):
8228 * fileio.c (Fdo_auto_save):
8229 * emacs.c (Fkill_emacs):
8230 * editfns.c (save_excursion_restore):
8231 * cmds.c (internal_self_insert):
8232 * callint.c (Fcall_interactively):
8233 * buffer.c (Fkill_all_local_variables):
8234 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8236 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8237 unconditionally since it does the check itself.
8239 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8241 Fix more problems found by GCC 4.5.2's static checks.
8243 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8244 the first time through the loop, since we know p0 < p1 then.
8245 This also avoids a gcc -Wstrict-overflow warning.
8247 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8248 leading to a memory leak, possible in functions like
8249 load_charset_map_from_file that can allocate an unbounded number
8250 of objects (Bug#8318).
8252 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8253 that could (at least in theory) be that large.
8255 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8256 This is less likely to overflow, and avoids undefined behavior if
8257 overflow does occur. All callers changed. Use strtoul to scan
8258 for the unsigned long integer.
8259 (pint2hrstr): Simplify and tune code slightly.
8260 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8262 * scroll.c (do_scrolling): Work around GCC bug 48228.
8263 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8265 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8266 This also avoids a warning with gcc -Wstrict-overflow.
8267 (validate_x_resource_name): Simplify count usage.
8268 This also avoids a warning with gcc -Wstrict-overflow.
8270 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8273 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8275 * process.c (Fmake_network_process): Use socklen_t, not int,
8276 where POSIX says socklen_t is required in portable programs.
8277 This fixes a porting bug on hosts like 64-bit HP-UX, where
8278 socklen_t is wider than int (Bug#8277).
8279 (Fmake_network_process, server_accept_connection):
8280 (wait_reading_process_output, read_process_output):
8283 * process.c: Rename or move locals to avoid shadowing.
8284 (list_processes_1, Fmake_network_process):
8285 (read_process_output_error_handler, exec_sentinel_error_handler):
8286 Rename or move locals.
8287 (Fmake_network_process): Define label "retry_connect" only if needed.
8288 (Fnetwork_interface_info): Fix pointer signedness.
8289 (process_send_signal): Add cast to avoid pointer signedness problem.
8290 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8291 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8293 Make tparam.h and terminfo.c consistent.
8294 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8295 Include tparam.h instead, since it declares them.
8296 * cm.h (PC): Remove extern decl; tparam.h now does this.
8297 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8298 * terminfo.c: Include tparam.h, to check interfaces.
8299 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8300 (tparam): Adjust signature to match interface in tparam.h;
8301 this removes some undefined behavior. Check that outstring and len
8302 are zero, which they always are with Emacs.
8303 * tparam.h (PC, BC, UP): New extern decls.
8305 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8306 (xftfont_open): Rename locals to avoid shadowing.
8308 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8309 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8310 (OTF_TAG_SYM): Omit macro if not needed.
8311 (ftfont_list): Remove unused local.
8312 (get_adstyle_property, ftfont_pattern_entity):
8313 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8314 Rename locals to avoid shadowing.
8316 * xfont.c (xfont_list_family): Mark var as initialized.
8318 * xml.c (make_dom): Now static.
8320 * composite.c (composition_compute_stop_pos): Rename local to
8322 (composition_reseat_it): Remove unused locals.
8323 (find_automatic_composition, composition_adjust_point): Likewise.
8324 (composition_update_it): Mark var as initialized.
8325 (find_automatic_composition): Mark vars as initialized,
8326 with a FIXME (Bug#8290).
8328 character.h: Rename locals to avoid shadowing.
8329 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8330 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8331 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8332 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8335 * textprop.c (property_change_between_p): Remove; unused.
8337 * intervals.c (interval_start_pos): Now static.
8339 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8341 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8342 Rename locals to avoid shadowing.
8344 * sound.c (wav_play, au_play, Fplay_sound_internal):
8345 Fix pointer signedness.
8346 (alsa_choose_format): Remove unused local var.
8347 (wav_play): Initialize a variable to 0, to prevent undefined
8348 behavior (Bug#8278).
8350 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8352 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8354 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8355 clobbering (Bug#8298).
8356 * sysdep.c (sys_subshell): Likewise.
8357 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8359 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8360 This should get cleaned up, so that child_setup has the
8361 same signature on all platforms.
8363 * callproc.c (call_process_cleanup): Now static.
8364 (relocate_fd): Rename locals to avoid shadowing.
8366 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8368 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8369 not to be necessary, and produces flickering.
8371 2011-03-20 Glenn Morris <rgm@gnu.org>
8373 * config.in: Remove file.
8375 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8377 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8378 are now in src/globals.h.
8379 (syms_of_minibuf): Remove spurious & from previous change.
8381 2011-03-20 Leo Liu <sdl.web@gmail.com>
8383 * minibuf.c (completing-read-function): New variable.
8384 (completing-read-default): Rename from completing-read.
8385 (completing-read): Call completing-read-function.
8387 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8389 * xfaces.c (Fx_load_color_file):
8390 Read color file from absolute filename (bug#8250).
8392 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8394 * makefile.w32-in: Update dependencies.
8396 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8398 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8400 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8402 Fix more problems found by GCC 4.5.2's static checks.
8404 * process.c (make_serial_process_unwind, send_process_trap):
8405 (sigchld_handler): Now static.
8407 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8408 That way, the code declares only the vars that it needs.
8409 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8410 * s/cygwin.h (PTY_ITERATION): Likewise.
8411 * s/darwin.h (PTY_ITERATION): Likewise.
8412 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8414 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8415 * process.c (allocate_pty): Don't declare stb unless it's needed.
8417 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8418 (CONSTANTLIM): Remove; unused.
8419 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8420 Define only if needed.
8422 * unexelf.c (unexec): Name an expression,
8423 to avoid gcc -Wbad-function-cast warning.
8424 Use a different way to cause a compilation error if anyone uses
8425 n rather than nn, a way that does not involve shadowing.
8426 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8428 * deps.mk (unexalpha.o): Remove; unused.
8430 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8431 * unexec.h: New file.
8432 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8433 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8435 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8436 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8437 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8438 Change as necessary to match prototype in unexec.h.
8440 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8442 (back_comment, skip_chars): Mark vars as initialized.
8444 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8445 Rename locals to avoid shadowing.
8447 * lread.c (read1): Rewrite so as not to use empty "else".
8448 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8450 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8452 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8453 warning when compiling print.c.
8455 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8456 instead of using an uninitialized var.
8457 (font_sort_entities): Mark var as initialized.
8459 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8461 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8462 pointers to constants.
8463 (font_parse_fcname): Remove unused vars.
8464 (font_delete_unmatched): Now static.
8465 (font_get_spec): Remove; unused.
8466 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8467 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8468 Rename or move locals to avoid shadowing.
8470 * fns.c (require_nesting_list, require_unwind): Now static.
8471 (Ffillarray): Rename locals to avoid shadowing.
8473 * floatfns.c (domain_error2): Define only if needed.
8474 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8476 * alloc.c (mark_backtrace): Move decl from here ...
8477 * lisp.h: ... to here, so that it can be checked.
8479 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8480 (Fdefvar): Rewrite so as not to use empty "else".
8481 (lisp_indirect_variable): Name an expression,
8482 to avoid gcc -Wbad-function-cast warning.
8483 (Fdefvar): Rename locals to avoid shadowing.
8485 * callint.c (quotify_arg, quotify_args): Now static.
8486 (Fcall_interactively): Rename locals to avoid shadowing.
8487 Use const pointer when appropriate.
8489 * lisp.h (get_system_name, get_operating_system_release):
8490 Move decls here, to check interfaces.
8491 * process.c (get_operating_system_release): Move decl to lisp.h.
8492 * xrdb.c (get_system_name): Likewise.
8493 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8494 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8495 some of which prompt warnings from gcc -Wbad-function-cast.
8496 (Fformat_time_string, Fencode_time, Finsert_char):
8497 (Ftranslate_region_internal, Fformat):
8498 Rename or remove local vars to avoid shadowing.
8499 (Ftranslate_region_internal): Mark var as initialized.
8501 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8504 * lisp.h (eassert): Check that the argument compiles, even if
8505 ENABLE_CHECKING is not defined.
8507 * data.c (Findirect_variable): Name an expression, to avoid
8508 gcc -Wbad-function-cast warning.
8509 (default_value, arithcompare, arith_driver, arith_error): Now static.
8510 (store_symval_forwarding): Rename local to avoid shadowing.
8511 (Fmake_variable_buffer_local, Fmake_local_variable):
8512 Mark variables as initialized.
8513 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8515 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8516 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8517 Rename locals to avoid shadowing.
8518 (mark_stack): Move local variables into the #ifdef region where
8520 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8521 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8523 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8524 (GC_STRING_CHARS): Remove; not used.
8525 (Fmemory_limit): Cast sbrk's returned value to char *.
8527 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8528 avoids undefined behavior in theory.
8530 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8532 Use functions, not macros, for up- and down-casing (Bug#8254).
8533 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8534 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8535 to use the following functions instead of these macros.
8536 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8537 EMACS_INT, since callers assume the returned value fits in int.
8538 (upcase1): Likewise, for UPCASE_TABLE.
8539 (uppercasep, lowercasep, upcase): New static inline functions.
8540 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8541 the race-condition problem in the old DOWNCASE.
8543 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8544 Rename locals to avoid shadowing.
8545 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8546 (regex_compile, re_search_2, re_match_2_internal):
8547 Remove unused local vars.
8548 (FREE_VAR): Rewrite so as not to use empty "else",
8549 which gcc can warn about.
8550 (regex_compile, re_match_2_internal): Mark locals as initialized.
8551 (RETALLOC_IF): Define only if needed.
8552 (WORDCHAR_P): Likewise. This one is never needed, but is used
8553 only in a comment talking about a compiler bug, so put inside
8554 the #if 0 of that comment.
8555 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8556 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8559 * search.c (boyer_moore): Rename locals to avoid shadowing.
8560 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8561 (PREV_CHAR_BOUNDARY): Likewise.
8563 * search.c (simple_search): Remove unused var.
8565 * dired.c (compile_pattern): Move decl from here ...
8566 * lisp.h: ... to here, so that it can be checked.
8567 (struct re_registers): New forward decl.
8569 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8571 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8573 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8574 Rename locals to avoid shadowing.
8575 (Fvertical_motion): Mark locals as initialized.
8577 * casefiddle.c (casify_object, casify_region): Now static.
8578 (casify_region): Mark local as initialized.
8580 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8582 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8583 New macros, so that the caller can use some names other than
8584 gcpro1, gcpro2, etc.
8585 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8587 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8588 argument, for consistency with GCPRO2_VAR, etc: it is now the
8589 prefix of the variable, not the variable itself. All uses
8591 * dired.c (directory_files_internal, file_name_completion):
8592 Rename locals to avoid shadowing.
8594 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8595 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8596 dired.c's scmp function, had undefined behavior.
8597 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8598 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8599 * buffer.h: ... to here, because these macros use current_buffer,
8600 and the new implementation with inline functions needs to have
8601 current_buffer in scope now, rather than later when the macros
8603 (downcase, upcase1): New static inline functions.
8604 (DOWNCASE, UPCASE1): Reimplement using these functions.
8605 This avoids undefined behavior in expressions like
8606 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8607 from race conditions in accessing the global variables
8608 case_temp1 and case_temp2.
8609 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8610 * lisp.h (case_temp1, case_temp2): Remove their decls.
8611 * character.h (ASCII_CHAR_P): Move from here ...
8612 * lisp.h: ... to here, so that the inline functions mentioned
8615 * dired.c (directory_files_internal_unwind): Now static.
8617 * fileio.c (file_name_as_directory, directory_file_name):
8618 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8620 (file_name_as_directory): Use const pointers when appropriate.
8621 (Fexpand_file_name): Likewise. In particular, newdir might
8622 point at constant storage, so make it a const pointer.
8623 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8624 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8626 (Fset_file_times, Finsert_file_contents, auto_save_error):
8627 Rename locals to avoid shadowing.
8629 * minibuf.c (choose_minibuf_frame_1): Now static.
8630 (Ftry_completion, Fall_completions): Rename or remove locals
8633 * marker.c (bytepos_to_charpos): Remove; unused.
8635 * lisp.h (verify_bytepos, count_markers): New decls,
8636 so that gcc does not warn that these functions aren't declared.
8638 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8639 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8640 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8641 (copy_text): Remove unused local var.
8643 * filelock.c (within_one_second): Now static.
8644 (lock_file_1): Rename local to avoid shadowing.
8646 * buffer.c (fix_overlays_before): Mark locals as initialized.
8647 (fix_start_end_in_overlays): Likewise. This function should be
8648 simplified by using pointers-to-pointers, but that's a different
8650 (switch_to_buffer_1): Now static.
8651 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8652 (report_overlay_modification): Rename locals to avoid shadowing.
8654 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8655 Fix pointer signedness issue.
8656 (sys_subshell): Mark local as volatile if checking for lint,
8657 to suppress a gcc -Wclobbered warning that does not seem to be right.
8658 (MAXPATHLEN): Define only if needed.
8660 * process.c (serial_open, serial_configure): Move decls from here ...
8661 * systty.h: ... to here, so that they can be checked.
8663 * fns.c (get_random, seed_random): Move extern decls from here ...
8664 * lisp.h: ... to here, so that they can be checked.
8666 * sysdep.c (reset_io): Now static.
8667 (wait_for_termination_signal): Remove; unused.
8669 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8670 (copy_keymap_item, append_key, push_text_char_description):
8672 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8673 (DENSE_TABLE_SIZE): Remove; unused.
8674 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8675 (describe_map_tree):
8676 Rename locals to avoid shadowing.
8678 * keyboard.c: Declare functions static if they are not used elsewhere.
8679 (echo_char, echo_dash, cmd_error, top_level_2):
8680 (poll_for_input, handle_async_input): Now static.
8681 (read_char, kbd_buffer_get_event, make_lispy_position):
8682 (make_lispy_event, make_lispy_movement, apply_modifiers):
8683 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8684 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8685 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8686 (read_key_sequence, read_char): Mark locals as initialized.
8687 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8689 * keyboard.h (make_ctrl_char): New decl.
8690 (mark_kboards): Move decl here ...
8691 * alloc.c (mark_kboards): ... from here.
8693 * lisp.h (force_auto_save_soon): New decl.
8695 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8696 (DEFINE_DUMMY_FUNCTION): New macro.
8697 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8699 (main): Add casts to avoid warnings
8700 if GCC considers string literals to be constants.
8702 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8704 * dbusbind.c: Pointer signedness fixes.
8705 (xd_signature, xd_append_arg, xd_initialize):
8706 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8707 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8708 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8709 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8711 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8712 if GCC considers string literals to be constants.
8713 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8715 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8717 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8718 (print_preprocess, print_object): New macro to fix last change.
8720 * print.c (print_preprocess): Don't forget font objects.
8722 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8724 * emacs.c (USAGE3): Doc fixes.
8726 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8728 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8731 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8733 * lisp.h (VWindow_system, Qfile_name_history):
8734 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8735 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8736 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8738 * w32select.c: Don't #include "keyboard.h".
8739 (run_protected): Add extern declaration for waiting_for_input.
8741 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8742 * w32console.c (detect_input_pending, read_input_pending)
8743 (encode_terminal_code):
8744 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8745 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8746 (w32_system_caret_y, Qfile_name_history):
8747 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8748 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8749 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8750 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8751 * w32proc.c (Qlocal, report_file_error):
8752 * w32term.c (Vwindow_system, updating_frame):
8753 * w32uniscribe.c (initialized, uniscribe_font_driver):
8754 Remove unneeded extern declarations.
8756 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8758 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8760 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8762 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8763 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8764 These macros can no longer be used for assignment.
8766 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8767 Assign struct members directly, instead of using BUF_BEGV etc.
8768 (record_buffer_markers, fetch_buffer_markers): New functions for
8769 recording and fetching special buffer markers.
8770 (set_buffer_internal_1, set_buffer_temp): Use them.
8772 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8774 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8776 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8777 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8779 * xdisp.c (hscroll_window_tree):
8780 (reconsider_clip_changes): Use PT instead of BUF_PT.
8782 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8784 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8785 $(EMACS_ROOT)/lib/intprops.h.
8787 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8789 Fix more problems found by GCC 4.5.2's static checks.
8791 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8792 to unsigned char * to avoid compiler diagnostic.
8793 (xg_free_frame_widgets): Make it clear that a local variable is
8794 needed only if USE_GTK_TOOLTIP.
8795 (gdk_window_get_screen): Make it clear that this macro is needed
8796 only if USE_GTK_TOOLTIP.
8797 (int_gtk_range_get_value): New function, which avoids a diagnostic
8798 from gcc -Wbad-function-cast.
8799 (xg_set_toolkit_scroll_bar_thumb): Use it.
8800 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8801 diagnostic from gcc -Wbad-function-cast.
8802 (get_utf8_string, xg_get_file_with_chooser):
8803 Rename locals to avoid shadowing.
8804 (create_dialog): Move locals to avoid shadowing.
8806 * xgselect.c (xg_select): Remove unused var.
8808 * image.c (four_corners_best): Mark locals as initialized.
8809 (gif_load): Initialize transparent_p to zero (Bug#8238).
8810 Mark another local as initialized.
8811 (my_png_error, my_error_exit): Mark with NO_RETURN.
8813 * image.c (clear_image_cache): Now static.
8814 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8815 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8816 (x_edge_detection): Remove unnecessary cast that
8817 gcc -Wbad-function-cast diagnoses.
8818 (gif_load): Fix pointer signedness.
8819 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8820 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8822 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8824 Improve quality of tests for time stamp overflow.
8825 For example, without this patch (encode-time 0 0 0 1 1
8826 1152921504606846976) returns the obviously-bogus value (-948597
8827 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8828 reports time overflow. See
8829 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8830 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8831 * editfns.c: Include limits.h and intprops.h.
8832 (TIME_T_MIN, TIME_T_MAX): New macros.
8833 (time_overflow): Move earlier, to before first use.
8834 (hi_time, lo_time): New functions, for an accurate test for
8836 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8837 (Fget_internal_run_time): Don't assume time_t fits in int.
8838 (make_time): Use list2 instead of Fcons twice.
8839 (Fdecode_time): More accurate test for out-of-range times.
8840 (check_tm_member): New function.
8841 (Fencode_time): Use it, to test for out-of-range times.
8842 (lisp_time_argument): Don't rely on undefined left-shift and
8843 right-shift behavior when checking for time stamp overflow.
8845 * editfns.c (time_overflow): New function, refactoring common code.
8846 (Fformat_time_string, Fdecode_time, Fencode_time):
8847 (Fcurrent_time_string): Use it.
8849 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8850 * dired.c (make_time): Move to ...
8851 * editfns.c (make_time): ... here.
8852 * systime.h: Note the move.
8854 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8856 * fringe.c (update_window_fringes): Remove unused variables.
8858 * unexmacosx.c (copy_data_segment): Also copy __got section.
8861 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8863 * termcap.c [MSDOS]: Include "msdos.h".
8864 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8865 Constify `char *' arguments and their references according to
8866 prototypes in tparam.h.
8868 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8870 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8871 Adapt all references accordingly.
8873 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8875 2011-03-11 Tom Tromey <tromey@redhat.com>
8877 * buffer.c (syms_of_buffer): Remove obsolete comment.
8879 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8881 * termhooks.h (encode_terminal_code): Declare prototype.
8883 * msdos.c (encode_terminal_code): Don't declare prototype.
8885 * term.c (encode_terminal_code): Now external again, used by
8886 w32console.c and msdos.c.
8888 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8889 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8891 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8893 Fix some minor problems found by GCC 4.5.2's static checks.
8895 * fringe.c (update_window_fringes): Mark locals as initialized
8897 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8899 * alloc.c (mark_fringe_data): Move decl from here ...
8900 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8901 to check its interface.
8902 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8904 * fontset.c (free_realized_fontset): Now static.
8905 (Fset_fontset_font): Rename local to avoid shadowing.
8906 (fontset_font): Mark local as initialized.
8907 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8909 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8911 * xselect.c (x_disown_buffer_selections): Remove; not used.
8912 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8913 (x_own_selection, Fx_disown_selection_internal): Rename locals
8915 (x_handle_dnd_message): Remove local to avoid shadowing.
8917 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8918 so that the caller can use some name other than gcpro1.
8919 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8920 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8921 (Fx_backspace_delete_keys_p):
8922 Use them to avoid shadowing, and rename vars to avoid shadowing.
8923 (x_decode_color, x_set_name, x_window): Now static.
8924 (Fx_create_frame): Add braces to silence GCC warning.
8925 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8926 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8927 Remove unused locals.
8928 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8929 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8930 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8933 * xterm.h (x_mouse_leave): New decl.
8935 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8936 Remove unused functions.
8937 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8938 (x_calc_absolute_position): Now static.
8939 (XTread_socket): Don't define label "out" unless it's used.
8940 Don't declare local "event" unless it's used.
8941 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8942 unless they are used.
8943 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8944 (x_fatal_error_signal): Remove; not used.
8945 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8946 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8947 (x_error_catcher, x_connection_closed, x_error_handler):
8948 (x_error_quitter, xembed_send_message, x_iconify_frame):
8949 (my_log_handler): Rename locals to avoid shadowing.
8950 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8951 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8953 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8954 Rename or move locals to avoid shadowing.
8955 (tty_defined_color, merge_face_heights): Now static.
8956 (free_realized_faces_for_fontset): Remove; not used.
8957 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8958 does not deduce is never used uninitialized.
8959 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8960 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8962 * terminal.c (store_terminal_param): Now static.
8964 * xmenu.c (menu_highlight_callback): Now static.
8965 (set_frame_menubar): Remove unused local.
8966 (xmenu_show): Rename parameter to avoid shadowing.
8967 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8968 since they might point to immutable storage.
8969 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8970 since it's unused otherwise.
8972 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8973 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8974 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8975 avoids a gcc -Wuninitialized diagnostic.
8976 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8977 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8978 does not deduce are never used uninitialized.
8980 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8982 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8983 * window.c (window_loop, size_window):
8984 (run_window_configuration_change_hook, enlarge_window): Likewise.
8986 * window.c (display_buffer): Now static.
8987 (size_window): Mark variables that gcc -Wuninitialized
8988 does not deduce are never used uninitialized.
8989 * window.h (check_all_windows): New decl, to forestall
8990 gcc -Wmissing-prototypes diagnostic.
8991 * dispextern.h (bidi_dump_cached_states): Likewise.
8993 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8995 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8997 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8998 and to avoid gcc -Wuninitialized warning.
8999 (load_charset_map): Mark variables that gcc -Wuninitialized
9000 does not deduce are never used uninitialized.
9001 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9003 * coding.c (coding_set_source, coding_set_destination):
9004 Use "else { /* comment */ }" rather than "else /* comment */;"
9005 for clarity, and to avoid gcc -Wempty-body warning.
9006 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9007 a block, when the outer 'i' will do.
9008 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9009 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9010 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9011 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9012 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9013 Rename locals to avoid shadowing.
9014 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9015 * coding.c (emacs_mule_char, encode_invocation_designation):
9016 Now static, since they're not used elsewhere.
9017 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9018 (decode_coding_object, encode_coding_object, detect_coding_system):
9019 (decode_coding_emacs_mule): Mark variables that gcc
9020 -Wuninitialized does not deduce are never used uninitialized.
9021 (detect_coding_iso_2022): Initialize a local variable that might
9022 be used uninitialized. Leave a FIXME because it's not clear that
9023 this initialization is needed. (Bug#8211)
9024 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9025 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9026 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9027 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9028 Remove unused macros.
9030 * category.c (hash_get_category_set): Remove unused local var.
9031 (copy_category_table): Now static, since it's not used elsewhere.
9032 * character.c (string_count_byte8): Likewise.
9034 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9035 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9037 * chartab.c (copy_sub_char_table): Now static, since it's not used
9039 (sub_char_table_ref_and_range, char_table_ref_and_range):
9040 Rename locals to avoid shadowing.
9041 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9043 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9044 (BIDI_BOB): Remove unused macro.
9046 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9047 deduce are never used uninitialized.
9048 * term.c (encode_terminal_code): Likewise.
9050 * term.c (encode_terminal_code): Now static. Remove unused local.
9052 * tparam.h: New file.
9053 * term.c, tparam.h: Include it.
9054 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9055 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9056 Move these decls to tparam.h, and make them agree with what
9057 is actually in tparam.c. The previous trick of using incompatible
9058 decls in different modules does not conform to the C standard.
9059 All callers of tparam changed to use tparam's actual API.
9060 * tparam.c (tparam1, tparam, tgoto):
9061 Use const pointers where appropriate.
9063 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9064 * cm.h (struct cm): Likewise.
9065 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9066 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9067 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9068 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9069 (turn_on_face, init_tty): Likewise.
9070 * termchar.h (struct tty_display_info): Likewise.
9072 * term.c (term_mouse_position): Rename local to avoid shadowing.
9074 * alloc.c (mark_ttys): Move decl from here ...
9075 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9077 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9079 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9081 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9083 * search.c (compile_pattern_1): Remove argument regp, unused since
9084 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9085 (compile_pattern): Don't pass it.
9087 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9089 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9090 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9092 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9094 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9096 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9097 gdk_window_get_screen, gdk_window_get_geometry,
9098 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9099 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9100 (xg_get_pixbuf_from_pixmap): New function.
9101 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9102 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9103 Call xg_get_pixbuf_from_pixmap instead of
9104 gdk_pixbuf_get_from_drawable.
9105 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9106 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9107 (xg_check_special_colors): Use GtkStyleContext and its functions
9109 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9110 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9111 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9112 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9113 Call gtk_widget_get_preferred_size.
9114 (xg_frame_resized): gdk_window_get_geometry only takes 5
9116 (xg_win_to_widget, xg_event_is_for_menubar):
9117 Call gdk_x11_window_lookup_for_display.
9118 (xg_set_widget_bg): New function.
9119 (delete_cb): New function.
9120 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9121 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9122 (xg_set_background_color): Call xg_set_widget_bg.
9123 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9124 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9125 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9126 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9128 (update_frame_tool_bar): Call gtk_widget_hide.
9129 (xg_initialize): Use GDK_KEY_g.
9131 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9133 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9135 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9136 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9137 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9139 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9141 * w32xfns.c (select_palette): Check success of RealizePalette against
9142 GDI_ERROR, not zero.
9144 See ChangeLog.11 for earlier changes.
9150 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9152 This file is part of GNU Emacs.
9154 GNU Emacs is free software: you can redistribute it and/or modify
9155 it under the terms of the GNU General Public License as published by
9156 the Free Software Foundation, either version 3 of the License, or
9157 (at your option) any later version.
9159 GNU Emacs is distributed in the hope that it will be useful,
9160 but WITHOUT ANY WARRANTY; without even the implied warranty of
9161 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9162 GNU General Public License for more details.
9164 You should have received a copy of the GNU General Public License
9165 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.