1 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5 2012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
7 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8 (force_quit_count): New var.
9 (handle_interrupt): Use it.
11 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
13 * w32.c (w32_delayed_load): Record the full path of the library
14 being loaded (bug#10424).
16 2012-04-09 Glenn Morris <rgm@gnu.org>
18 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
19 not just in the obarray, before snarfing them. (Bug#11036)
21 * Makefile.in ($(leimdir)/leim-list.el):
22 Pass EMACS rather than BUILT_EMACS.
24 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
26 * process.c (make_process):
27 * process.h: Add integer `gnutls_handshakes_tried' member to
30 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
31 Add convenience `GNUTLS_LOG2i' macro.
33 * gnutls.c (gnutls_log_function2i): Convenience log function.
34 (emacs_gnutls_read): Use new log functions,
35 `gnutls_handshakes_tried' process member, and
36 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
37 attempts per process (connection).
39 2012-04-09 Chong Yidong <cyd@gnu.org>
41 * eval.c (Fuser_variable_p, user_variable_p_eh)
42 (lisp_indirect_variable): Functions deleted.
43 (Fdefvar): Caller changed.
45 * callint.c (Finteractive, Fcall_interactively):
46 * minibuf.c (Fread_variable): Callers changed.
48 2012-04-09 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (set_cursor_from_row): If the display string appears in
51 the buffer at position that is closer to point than the position
52 after the display string, display the cursor on the first glyph of
53 the display string. Fixes cursor display when a 'display' text
54 property immediately follows invisible text. (Bug#11094)
56 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
58 composite.c: use 'double' consistently
59 * composite.c (get_composition_id): Use 'double' consistently
60 instead of converting 'float' to 'double' and vice versa; this is
61 easier to understand and avoids a GCC warning.
63 2012-04-09 Glenn Morris <rgm@gnu.org>
65 * Makefile.in: Generate leim-list with bootstrap-emacs, in
66 preparation for dumping it with emacs. (Bug#4789)
67 (leimdir): New variable.
68 ($(leimdir)/leim-list.el): New rule.
69 (emacs$(EXEEXT)): Depend on leim-list.el.
71 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
72 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
73 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
75 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
77 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
80 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
82 * xml.c (init_libxml2_functions) [WINDOWSNT]:
83 Remove unused local variable.
85 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
87 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
88 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
89 (mark_memory): Mark Lisp_Objects only if pointers might hide in
90 objects, as mark_maybe_pointer will catch them otherwise.
91 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
92 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
94 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
96 Fix typo that broke non-Windows builds.
97 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
99 2012-04-07 Eli Zaretskii <eliz@gnu.org>
101 Support building on MS-Windows with libxml2.
103 * makefile.w32-in (OBJ2): Add xml.$(O).
104 (GLOBAL_SOURCES): Add xml.c.
105 ($(BLD)/xml.$(O)): New dependency list.
107 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
108 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
109 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
110 [!WINDOWSNT]: New macros.
111 (init_libxml2_functions, libxml2_loaded_p): New functions.
112 (parse_region): Call fn_xmlCheckVersion instead of using the macro
113 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
114 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
115 Calls xmlCleanupParser only if libxml2 was loaded (or statically
117 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
118 Call init_libxml2_functions before calling libxml2 functions.
119 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
121 * emacs.c: Don't include libxml/parser.h.
122 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
123 xmlCleanupParser directly.
125 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
127 2012-04-07 Eli Zaretskii <eliz@gnu.org>
129 * indent.c (Fvertical_motion): If there is a display string at
130 point, use it.vpos to compute how many lines to backtrack after
131 move_it_to point. (Bug#11133)
133 2012-04-06 Eli Zaretskii <eliz@gnu.org>
135 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
136 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
137 about subtle differences between FETCH_CHAR* and STRING_CHAR*
138 macros related to unification of CJK characters. For the details,
139 see the discussion following the message here:
140 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
142 2012-04-04 Chong Yidong <cyd@gnu.org>
144 * keyboard.c (Vdelayed_warnings_list): Doc fix.
146 2012-04-01 Eli Zaretskii <eliz@gnu.org>
148 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
149 instead of alloca. (Bug#11138)
151 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
153 * w32menu.c (is_simple_dialog): Properly check lisp types.
156 2012-03-31 Eli Zaretskii <eliz@gnu.org>
158 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
159 position we get to after a call to move_it_to fails the
160 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
161 only if we wind up in a string from display property. (Bug#11063)
163 * window.c (Fdelete_other_windows_internal): Invalidate the row
164 and column information about mouse highlight, so that redisplay
165 restores it after reallocating the glyph matrices. (Bug#7464)
167 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
168 string comes from a `display' text property, use the buffer
169 position of that property as if we actually saw that position in
171 (move_it_by_lines): Remove the assertion that
172 "it->current_x == 0 && it->hpos == 0" which can be legitimately
173 violated when there's a before-string at the beginning of a line.
176 2012-03-30 Eli Zaretskii <eliz@gnu.org>
178 * xdisp.c (append_space_for_newline): If the default face was
179 remapped, use the remapped face for the appended newline.
180 (extend_face_to_end_of_line): Use the remapped default face for
181 extending the face to the end of the line.
182 (display_line): Call extend_face_to_end_of_line when the default
183 face was remapped. (Bug#11068)
185 2012-03-29 Eli Zaretskii <eliz@gnu.org>
187 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
189 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
191 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
193 2012-03-27 Glenn Morris <rgm@gnu.org>
195 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
198 2012-03-26 Kenichi Handa <handa@m17n.org>
200 * dispextern.h (struct glyph): Fix previous change. Change the
201 bit length of glyphless.ch to 25 (Bug#11082).
203 2012-03-26 Chong Yidong <cyd@gnu.org>
205 * keyboard.c (Vselection_inhibit_update_commands): New variable.
206 (command_loop_1): Use it; inhibit selection update for
207 handle-select-window too (Bug#8996).
209 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
211 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
213 2012-03-25 Kenichi Handa <handa@m17n.org>
215 * dispextern.h (struct glyph): Change the bit length of
216 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
218 2012-03-24 Eli Zaretskii <eliz@gnu.org>
220 * s/ms-w32.h (tzname): Include time.h before redirecting to
221 _tzname. Fixes the MSVC build. (Bug#9960)
223 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
225 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
228 * xterm.c (XTread_socket): Only modify handling_signal if
229 !SYNC_INPUT. (Bug#11080)
231 2012-03-23 Eli Zaretskii <eliz@gnu.org>
233 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
234 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
235 when fetching a multibyte character consumes more bytes than
236 CHAR_BYTES returns, due to unification of CJK characters in
237 string_char. (Bug#11073)
239 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
241 * process.c (wait_reading_process_output): Handle pty disconnect
242 by refraining from sending oneself a SIGCHLD (bug#10933).
244 2012-03-22 Chong Yidong <cyd@gnu.org>
246 * dispextern.h (struct it): New member string_from_prefix_prop_p.
248 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
249 Mark string as coming from a prefix property.
250 (handle_face_prop): Use default face for prefix strings (Bug#4281).
251 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
253 2012-03-21 Chong Yidong <cyd@gnu.org>
255 * xfaces.c (Vface_remapping_alist): Doc fix.
257 2012-03-20 Eli Zaretskii <eliz@gnu.org>
259 * w32proc.c (Fw32_set_console_codepage)
260 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
263 2012-03-20 Chong Yidong <cyd@gnu.org>
265 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
266 to reflect default non-nil value of redisplay-dont-pause.
268 2012-03-19 Kenichi Handa <handa@m17n.org>
270 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
271 it fit in a valid range (Bug#11003).
273 2012-03-18 Eli Zaretskii <eliz@gnu.org>
275 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
276 that is not from display property, accept the row as a "cursor
277 row" if one of the string's character has a non-nil `cursor'
278 property. Fixes cursor positioning when there are newlines in
279 overlay strings, e.g. in icomplete.el. (Bug#11035)
281 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
283 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
285 2012-03-12 Chong Yidong <cyd@gnu.org>
287 * eval.c (inhibit_lisp_code): Rename from
288 inhibit_window_configuration_change_hook; move from window.c.
290 * xfns.c (unwind_create_frame_1, Fx_create_frame):
291 * window.c (run_window_configuration_change_hook)
292 (syms_of_window): Callers changed.
294 2012-03-11 Chong Yidong <cyd@gnu.org>
296 * keymap.c (Fkey_description): Doc fix (Bug#9700).
298 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
300 2012-03-10 Chong Yidong <cyd@gnu.org>
302 * frame.c (other_visible_frames): Don't assume the selected frame
303 is visible (Bug#10955).
305 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
307 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
309 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
311 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
312 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
315 2012-03-03 Glenn Morris <rgm@gnu.org>
317 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
319 2012-03-02 Eli Zaretskii <eliz@gnu.org>
321 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
322 position past the first glyph_row that ends at ZV. (Bug#10902)
323 (redisplay_window, next_element_from_string): Fix typos in
325 (redisplay_window): Pass to move_it_vertically the margin in
326 pixels, not in screen lines.
328 2012-03-02 Glenn Morris <rgm@gnu.org>
330 * buffer.c (buffer-list-update-hook): Doc fix.
332 2012-02-29 Eli Zaretskii <eliz@gnu.org>
334 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
335 push_it before setting up the iterator for the first overlay
336 string, even if we have an empty string loaded.
337 (next_overlay_string): If there's an empty string on the iterator
338 stack, pop the stack. (Bug#10903)
340 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
342 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
343 Suggested by Stefan Monnier in
344 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
345 * alloc.c (widen_to_Lisp_Object): New static function.
346 (mark_memory): Also mark Lisp_Objects by fetching pointer words
347 and widening them to Lisp_Objects. This would work even if
348 USE_LSB_TAG is defined and wide integers are used, which might
349 happen in a future version of Emacs.
351 2012-02-25 Chong Yidong <cyd@gnu.org>
353 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
356 * xselect.c (Fx_selection_exists_p): Doc fix.
357 (x_clipboard_manager_save_all): Print an informative message
358 before saving to clipboard manager.
360 2012-02-24 Chong Yidong <cyd@gnu.org>
362 * keyboard.c (process_special_events): Handle all X selection
363 requests in kbd_buffer, not just the next one (Bug#8869).
365 2012-02-23 Chong Yidong <cyd@gnu.org>
367 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
368 call when setting menu-bar-lines and tool-bar-lines parameters.
369 (unwind_create_frame_1): New helper function.
371 * window.c (inhibit_window_configuration_change_hook): New var.
372 (run_window_configuration_change_hook): Obey it.
373 (syms_of_window): Initialize it.
375 2012-02-22 Chong Yidong <cyd@gnu.org>
377 * xterm.c (x_draw_image_relief): Add missing type check for
378 Vtool_bar_button_margin (Bug#10743).
380 2012-02-21 Chong Yidong <cyd@gnu.org>
382 * fileio.c (Vfile_name_handler_alist): Doc fix.
384 * buffer.c (Fget_file_buffer): Protect against invalid file
385 handler return value.
387 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
389 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
390 when computing $valmask.
392 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
393 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
394 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
395 It's useless in that case, and it can cause problems on hosts
396 that allocate halves of EMACS_INT values separately.
397 Reported by Dan Horák. Diagnosed by Andreas Schwab in
398 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
399 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
400 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
401 it avoids undefined behavior on hosts where shifting right by more
402 than the word width has undefined behavior.
404 2012-02-19 Chong Yidong <cyd@gnu.org>
406 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
407 (Funhandled_file_name_directory, Ffile_name_as_directory)
408 (Fdirectory_file_name, Fexpand_file_name)
409 (Fsubstitute_in_file_name): Protect against invalid file handler
410 return values (Bug#10845).
412 2012-02-18 Eli Zaretskii <eliz@gnu.org>
414 * .gdbinit (pitx): Fix incorrect references to fields of the
417 2012-02-17 Chong Yidong <cyd@gnu.org>
419 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
421 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
423 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
424 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
426 2012-02-15 Chong Yidong <cyd@gnu.org>
428 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
429 marked as special. Also, starting docstrings with * is obsolete.
431 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
433 * gnutls.c (emacs_gnutls_write): Fix last change.
435 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
437 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
440 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
442 * keymap.c (Fsingle_key_description): Handle char ranges.
444 2012-02-12 Chong Yidong <cyd@gnu.org>
446 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
447 as that creates a dangerous corner case.
449 * window.c (Fdelete_window_internal): Invalidate the mouse
450 highlight (Bug#9904).
452 2012-02-12 Glenn Morris <rgm@gnu.org>
454 * xselect.c (Fx_own_selection_internal)
455 (Fx_get_selection_internal, Fx_disown_selection_internal)
456 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
457 * nsselect.m (Fx_own_selection_internal)
458 (Fx_disown_selection_internal, Fx_selection_exists_p)
459 (Fx_selection_owner_p, Fx_get_selection_internal):
460 Sync docs and argument specs with the xselect.c versions.
462 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
464 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
466 2012-02-11 Eli Zaretskii <eliz@gnu.org>
468 * w32select.c (Fx_selection_exists_p): Sync doc string and
469 argument list with xselect.c. (Bug#10783)
471 * w16select.c (Fx_selection_exists_p): Sync doc string and
472 argument list with xselect.c. (Bug#10783)
474 2012-02-10 Glenn Morris <rgm@gnu.org>
476 * fns.c (Fsecure_hash): Doc fix.
478 2012-02-09 Kenichi Handa <handa@m17n.org>
480 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
482 2012-02-07 Chong Yidong <cyd@gnu.org>
484 * buffer.c (Fbuffer_local_variables)
485 (buffer_lisp_local_variables): Handle unbound vars correctly;
486 don't let Qunbound leak into Lisp.
488 2012-02-07 Glenn Morris <rgm@gnu.org>
490 * image.c (Fimagemagick_types): Doc fix.
492 * image.c (imagemagick-render-type): Change it from a lisp object
493 to an integer. Move the doc here from the lisp manual.
494 Treat all values not equal to 0 the same.
496 2012-02-06 Chong Yidong <cyd@gnu.org>
498 * doc.c (store_function_docstring): Avoid applying docstring of
499 alias to base function (Bug#2603).
501 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
503 * .gdbinit (pp1, pv1): Remove redundant defines.
506 2012-02-04 Chong Yidong <cyd@gnu.org>
508 * nsterm.m: Declare a global (Bug#10694).
510 2012-02-04 Eli Zaretskii <eliz@gnu.org>
512 * w32.c (get_emacs_configuration_options):
513 Include --enable-checking, if specified, in the return value.
515 2012-02-04 Martin Rudalics <rudalics@gmx.at>
517 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
518 after rounding frame sizes. (Bug#9723)
520 2012-02-04 Eli Zaretskii <eliz@gnu.org>
522 * keyboard.c (adjust_point_for_property): Don't position point
523 before BEGV. (Bug#10696)
525 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
527 Handle overflow when computing char display width (Bug#9496).
528 * character.c (char_width): Return EMACS_INT, not int.
529 (char_width, c_string_width): Check for overflow when
530 computing the width; this is possible now that individual
531 characters can have unbounded width. Problem introduced
532 by merge from Emacs 23 on 2012-01-19.
534 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
536 * dbusbind.c (Fdbus_register_method): Mention the return value
537 :ignore in the docstring.
539 2012-02-02 Glenn Morris <rgm@gnu.org>
541 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
543 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
544 Unconditionally set to t. (Bug#10673)
545 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
546 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
547 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
549 2012-02-02 Kenichi Handa <handa@m17n.org>
551 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
552 0, do not call append_composite_glyph.
554 2012-02-02 Kenichi Handa <handa@m17n.org>
556 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
558 (x_produce_glyphs): If the component of a composition is a null
559 string, set it->pixel_width to 1 to avoid zero-width glyph.
561 2012-02-01 Eli Zaretskii <eliz@gnu.org>
563 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
564 first 2 arguments are identical. This makes inserting large
565 output from a subprocess an order of magnitude faster on
566 MS-Windows, where all sbrk'ed memory is always contiguous.
568 2012-01-31 Glenn Morris <rgm@gnu.org>
570 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
571 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
572 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
574 2012-01-29 Glenn Morris <rgm@gnu.org>
576 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
578 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
580 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
582 2012-01-28 Chong Yidong <cyd@gnu.org>
584 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
586 2012-01-26 Chong Yidong <cyd@gnu.org>
588 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
590 * search.c (Fsearch_forward, Fsearch_backward): Document negative
591 repeat counts (Bug#10507).
593 2012-01-26 Glenn Morris <rgm@gnu.org>
595 * lread.c (syms_of_lread): Doc fix.
597 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
599 * coding.c (encode_designation_at_bol): Change return value to
602 2012-01-25 Chong Yidong <cyd@gnu.org>
604 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
606 2012-01-21 Chong Yidong <cyd@gnu.org>
608 * floatfns.c (Fcopysign): Make the second argument non-optional,
609 since nil is not allowed anyway.
611 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
613 * process.c (read_process_output): Use p instead of XPROCESS (proc).
614 (send_process): Likewise.
616 2012-01-19 Martin Rudalics <rudalics@gmx.at>
618 * window.c (save_window_save, Fcurrent_window_configuration)
619 (Vwindow_persistent_parameters): Do not use Qstate.
622 2012-01-19 Kenichi Handa <handa@m17n.org>
624 * character.c (char_width): New function.
625 (Fchar_width, c_string_width, lisp_string_width):
626 Use char_width (Bug#9496).
628 2012-01-16 Martin Rudalics <rudalics@gmx.at>
630 * window.c (Vwindow_persistent_parameters): New variable.
631 (Fset_window_configuration, save_window_save): Handle persistent
634 2012-01-14 Eli Zaretskii <eliz@gnu.org>
636 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
637 thrashing the stack of the thread. (Bug#9087)
639 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
641 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
643 2012-01-11 Eli Zaretskii <eliz@gnu.org>
645 * xdisp.c (rows_from_pos_range): Handle the case where the
646 highlight ends on a newline. (Bug#10464)
647 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
648 he end column for display of highlight that ends on a newline
651 2012-01-11 Glenn Morris <rgm@gnu.org>
653 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
654 from load-path also when installation-directory is nil. (Bug#10208)
656 2012-01-10 Glenn Morris <rgm@gnu.org>
658 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
660 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
661 Update template values to be closer to their typical values these days.
663 2012-01-09 Eli Zaretskii <eliz@gnu.org>
665 * xdisp.c (rows_from_pos_range): Accept additional argument
666 DISP_STRING, and accept any glyph in a row whose object is that
667 string as eligible for mouse highlight. Fixes mouse highlight of
668 display strings from overlays. (Bug#10464)
670 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
672 emacs: fix an auto-save permissions race condition (Bug#10400)
673 * fileio.c (auto_saving_dir_umask): New static var.
674 (Fmake_directory_internal): Use it.
675 (do_auto_save_make_dir): Set it, instead of invoking chmod after
676 creating the directory. The old code temporarily assigns
677 too-generous permissions to the directory.
678 (do_auto_save_eh): Clear it.
679 (Fdo_auto_save): Catch all errors, not just file errors, so
680 that the var is always cleared.
682 2012-01-07 Eli Zaretskii <eliz@gnu.org>
684 * search.c (scan_buffer): Pass character positions to
685 know_region_cache, not byte positions. (Bug#6540)
687 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
689 * w32.c (sys_rename): Report EXDEV when rename of a directory
690 fails because the target is on another logical disk. (Bug#10284)
692 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
694 * xterm.c (x_embed_request_focus): New function.
696 * xterm.h: Add prototype.
698 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
700 2012-01-05 Glenn Morris <rgm@gnu.org>
702 * emacs.c (emacs_copyright): Update short copyright year to 2012.
704 2012-01-01 Eli Zaretskii <eliz@gnu.org>
706 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
707 Load gnutls_transport_set_lowat only if GnuTLS version is below
709 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
710 GnuTLS versions below 2.11.1.
712 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
714 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
715 to the doc string advising against its use for altering the way
716 windows are scrolled.
718 2011-12-28 Kenichi Handa <handa@m17n.org>
720 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
721 coding-system ASCII compatible only when it does not produce BOM
722 on encoding (Bug#10383).
724 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
726 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
728 (create_and_show_popup_menu): Always use menu_position_func for
731 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
733 * callint.c (Fcall_interactively): Don't truncate prompt string.
735 2011-12-23 Eli Zaretskii <eliz@gnu.org>
737 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
738 property that ends at ZV, so that the bidi iteration could be
739 resumed from there (after widening). (Bug#10360)
741 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
743 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
745 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
747 * nsterm.m (x_free_frame_resources):
748 Release f->output_data.ns->miniimage.
749 (ns_index_color): Fix indentation. Do not retain
750 color_table->colors[i].
752 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
755 * nsfns.m (x_set_background_color): Assign return value from
756 ns_index_color to face-background instead of NSColor*.
757 (ns_implicitly_set_icon_type): Fix indentation.
758 Change assignment in for loop to comparison.
760 * emacs.c (ns_pool): New variable.
761 (main): Assign ns_pool.
762 (Fkill_emacs): Call ns_release_autorelease_pool.
764 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
765 autorelease fdesc, release fdAttrs and tdict.
766 (ns_get_covering_families): Release charset.
767 (ns_findfonts): Release NSFontDescriptor created with new.
768 (ns_uni_to_glyphs): Fix indentation.
769 (setString): Release attrStr before assigning new value.
771 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
773 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
775 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
776 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
778 2011-12-18 David Reitter <reitter@cmu.edu>
780 * nsterm.m (ns_term_init): Subscribe for notifications
781 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
782 to method trackingNotification in EmacsMenu.
784 * nsmenu.m (trackingMenu): New variable.
785 (trackingNotification): New method (from Aquamacs).
786 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
787 from Aquamacs (Bug#7030).
789 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
791 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
792 (symbol_to_nsstring): Fix indentation.
793 (ns_symbol_to_pb): New function.
794 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
795 (Fns_rotate_cut_buffers_internal): Remove.
796 (Fns_store_selection_internal): Rename from
797 Fns_store_cut_buffer_internal.
798 (ns_get_foreign_selection, Fx_own_selection_internal)
799 (Fx_disown_selection_internal, Fx_selection_exists_p)
800 (Fns_get_selection_internal, Fns_store_selection_internal):
801 Use ns_symbol_to_pb and check if return value is nil.
802 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
803 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
804 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
805 renamed to Sns_store_selection_internal.
806 (ns_handle_selection_request): Move code to Fx_own_selection_internal
807 and remove this function.
808 (ns_handle_selection_clear): Remove, never used.
809 (Fx_own_selection_internal): Move code from ns_handle_selection_request
812 2011-12-17 Ken Brown <kbrown@cornell.edu>
814 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
815 GID is unknown (Bug#10257).
817 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
819 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
820 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
821 which caused a build failure on GNU/Linux IA-64. This problem was
822 introduced by my 2011-10-07 patch.
824 2011-12-15 Juri Linkov <juri@jurta.org>
826 * image.c (imagemagick_error): New function. (Bug#10112)
827 (imagemagick_load_image): Comment out `MagickSetResolution' call.
828 Use `imagemagick_error' where ImageMagick functions return
830 (Fimagemagick_types): Add `Fnreverse' to return the list in the
833 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
835 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
836 fill background (Bug#8992).
838 2011-12-13 Martin Rudalics <rudalics@gmx.at>
840 * window.c (Vwindow_combination_resize)
841 (Vwindow_combination_limit): Use t instead of non-nil in
843 (Vrecenter_redisplay): Add first sentence of doc-string on
845 (Frecenter): Fix doc-string typo.
847 2011-12-11 Kenichi Handa <handa@m17n.org>
849 * coding.c (Funencodable_char_position): Pay attention to the
850 buffer text relocation (Bug#9389).
852 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
854 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
855 gtk_init (Bug#10100).
857 2011-12-10 Eli Zaretskii <eliz@gnu.org>
859 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
860 IT->string is nil. (Bug#10263)
862 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
864 * nsterm.h (x_free_frame_resources): Declare.
866 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
867 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
869 * nsterm.h (ns_get_defaults_value): Declare.
871 * nsterm.m (ns_default): Call ns_get_defaults_value.
873 2011-12-09 Eli Zaretskii <eliz@gnu.org>
875 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
878 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
880 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
881 that where the value of an _OBJC_* symbol points to is in the .bss
884 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
886 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
887 after the loop to call ccl_driver at least once (Bug#8619).
889 2011-12-08 Kenichi Handa <handa@m17n.org>
891 * ftfont.c (get_adstyle_property): Fix previous change
894 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
896 * w32.c (init_environment): If no_site_lisp, remove site-lisp
897 dirs from the default value of EMACSLOADPATH (bug#10208).
899 2011-12-07 Glenn Morris <rgm@gnu.org>
901 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
902 installation and source directories as well. (Bug#10208)
904 2011-12-06 Chong Yidong <cyd@gnu.org>
906 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
908 2011-12-06 Glenn Morris <rgm@gnu.org>
910 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
911 as an error, not just -1. (Bug#10217)
913 2011-12-05 Chong Yidong <cyd@gnu.org>
915 * keyboard.c (process_special_events): New function.
916 (swallow_events, Finput_pending_p): Use it (Bug#10195).
918 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
920 * coding.c (encode_designation_at_bol): Don't use uninitialized
921 local variable (Bug#9318).
923 2011-12-05 Kenichi Handa <handa@m17n.org>
925 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
926 return Qnil (Bug#8046, Bug#10193).
928 2011-12-05 Kenichi Handa <handa@m17n.org>
930 * coding.c (encode_designation_at_bol): New args charbuf_end and
931 dst. Return the number of produced bytes. Callers changed.
932 (coding_set_source): Return how many bytes coding->source was
934 (coding_set_destination): Return how many bytes
935 coding->destination was relocated.
936 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
937 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
939 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
941 * coding.c (CODING_CHAR_CHARSET_P): New macro.
942 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
945 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
947 The following changes are to fix Bug#9318.
949 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
950 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
951 (encode_coding_iso_2022, encode_coding_sjis)
952 (encode_coding_big5, encode_coding_charset): Use the above macros.
954 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
956 * lisp.h (process_quit_flag): Fix external declaration.
958 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
960 Don't macro-inline non-performance-critical code.
961 * eval.c (process_quit_flag): New function.
962 * lisp.h (QUIT): Use it.
964 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
966 * nsfns.m (get_geometry_from_preferences): New function.
967 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
969 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
971 * emacs.c (Qkill_emacs): Define.
972 (syms_of_emacs): Initialize it.
973 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
974 Qquit_flag to `kill-emacs' instead.
975 (quit_throw_to_read_char): Add parameter `from_signal'.
976 All callers changed. Call Fkill_emacs if requested and safe.
977 * lisp.h (QUIT): Call Fkill_emacs if requested.
979 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
981 * widget.c (update_wm_hints): Return if wmshell is null.
982 (widget_update_wm_size_hints): New function.
984 * widget.h (widget_update_wm_size_hints): Declare.
986 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
987 widget_update_wm_size_hints (Bug#10104).
989 2011-12-03 Eli Zaretskii <eliz@gnu.org>
991 * xdisp.c (handle_invisible_prop): If the invisible text ends just
992 before a newline, prepare the bidi iterator for consuming the
993 newline, and keep the current paragraph direction. (Bug#10183)
994 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
996 2011-12-02 Juri Linkov <juri@jurta.org>
998 * search.c (Fword_search_regexp): New Lisp function created from
999 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1000 (Fword_search_backward, Fword_search_forward)
1001 (Fword_search_backward_lax, Fword_search_forward_lax):
1002 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1003 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1005 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1007 * fileio.c (Finsert_file_contents): Move after-change-function call
1008 to before the "handled:" label, since all "goto handled" appear in
1009 cases where the *-change-functions have already been properly called
1012 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1014 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1015 waiting for input. (Bug#10169)
1017 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1019 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1020 verifies glyph row's hash code--we have just reallocated the
1021 glyphs, so their contents can be complete garbage. (Bug#10164)
1023 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1025 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1027 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1029 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1030 attributes are tested _before_ calling verify_row_hash, to protect
1031 against GCC re-ordering of the tests. (Bug#10164)
1033 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1035 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1037 * xterm.c (handle_one_xevent): Only set async_visible and friends
1038 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1039 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1040 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1042 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1044 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1045 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1046 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1047 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1048 All uses changed to use GCPRO1 etc.
1049 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1050 Revert to old implementation (i.e., before 2011-03-11).
1052 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1054 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1055 of scroll runs so as to avoid assigning disabled bogus rows and
1056 unnecessary graphics copy operations.
1058 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1060 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1061 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1062 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1063 (malloc, free, realloc, calloc): Redirect to e_* only when
1066 * lisp.h (GCTYPEBITS): Move before first use.
1067 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1068 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1069 this macro definition.
1071 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1074 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1076 * gtkutil.c (xg_create_frame_widgets):
1077 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1078 present with Gtk+ 2.0.
1080 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1082 * fileio.c (Finsert_file_contents): Undo previous change; see
1083 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1085 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1087 Rename locals to avoid shadowing.
1088 * fileio.c (Finsert_file_contents):
1089 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1090 * process.c (wait_reading_process_output):
1091 Rename inner 'proc' to 'p' to avoid shadowing.
1092 Indent for consistency with usual Emacs style.
1094 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1096 * xdisp.c (redisplay_window): If cursor row is not fully visible
1097 after recentering, and scroll-conservatively is set to a large
1098 number, scroll window by a few more lines to make the cursor fully
1099 visible and out of scroll-margin. (Bug#10105)
1100 (start_display): Don't move to the next line if the display should
1101 start at a newline that is part of a display vector or an overlay
1104 2011-11-24 Juri Linkov <juri@jurta.org>
1106 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1107 after the `MagickPingImage' call. (Bug#10112)
1109 2011-11-23 Chong Yidong <cyd@gnu.org>
1111 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1113 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1115 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1116 making another buffer current. (Bug#10114)
1118 2011-11-23 Glenn Morris <rgm@gnu.org>
1120 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1122 2011-11-23 Chong Yidong <cyd@gnu.org>
1124 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1125 using it (Bug#5984).
1127 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1129 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1130 and header-lines, as they don't have one computed for them.
1133 * .gdbinit (prow): Make displayed values more self-explaining.
1134 Add row's hash code.
1136 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1138 * process.c (wait_reading_process_output): Fix asynchrounous
1139 GnuTLS socket handling on some versions of the GnuTLS library.
1140 (wait_reading_process_output): Add comment and URL.
1142 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1144 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1146 2011-11-21 Chong Yidong <cyd@gnu.org>
1148 * window.c (Fnext_window, Fprevious_window): Doc fix.
1150 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1152 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1154 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1156 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1158 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1160 * window.c (Fset_window_combination_limit): Rename argument
1162 (Vwindow_combination_limit): Remove "status" from doc-string.
1164 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1166 * m/ibms390.h: Remove.
1167 * m/ibms390x.h: Don't include "ibms390.h".
1169 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1171 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1172 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1174 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1176 * casetab.c (Fset_case_table):
1177 * charset.c (Fcharset_after): Fix typos.
1179 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1181 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1182 Otherwise, valgrind does not work on some platforms.
1183 Problem reported by Andreas Schwab in
1184 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1185 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1186 is set, removing the need for VIRT_ADDRESS_VARIES.
1187 (PURE_P): Use a more-efficient implementation that needs just one
1188 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1189 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1190 to 4 (xorl, subq, cmpq, setbe).
1191 * alloc.c (pure): Always extern now, since that's the
1192 VIRT_ADDR_VARIES behavior.
1193 (PURE_POINTER_P): Use a single comparison, not two, for
1194 consistency with the new puresize.h.
1195 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1196 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1197 Remove VIRT_ADDR_VARIES no longer needed.
1199 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1201 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1202 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1203 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1204 behave as if the cursor position were at the window margin.
1206 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1207 and the cursor position is out of bounds, behave as if the cursor
1208 position were at the window margin. (Bug#10075)
1210 2011-11-18 Chong Yidong <cyd@gnu.org>
1212 * window.c (Fwindow_combination_limit): Make first argument
1213 non-optional, since it is meaningless for live windows like the
1216 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1218 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1220 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1222 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1223 (graft_intervals_into_buffer): Simplify.
1225 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1227 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1228 hash values of the two rows.
1229 (copy_row_except_pointers): Preserve the used[] arrays and the
1230 hash values of the two rows. (Bug#10035)
1231 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1233 * xdisp.c (row_hash): New function, body extracted from
1234 compute_line_metrics.
1235 (compute_line_metrics): Call row_hash, instead of computing the
1238 * dispnew.c (verify_row_hash): Call row_hash for computing the
1239 hash code of a row, instead of duplicating code from xdisp.c.
1241 * dispextern.h (row_hash): Add prototype.
1243 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1245 * frame.c (delete_frame): Don't delete the terminal when the last
1246 X frame is closed if emacs is built with GTK toolkit.
1248 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1250 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1252 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1254 * window.c (Vwindow_splits): Rename to
1255 Vwindow_combination_resize. Suggested by Juri Linkov.
1256 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1259 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1261 * nsfns.m (Fns_font_name):
1262 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1264 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1266 * window.h (window): Rename slot "nest" to "combination_limit".
1267 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1268 (Fset_window_nest): Rename to Fset_window_combination_limit.
1269 (Vwindow_nest): Rename to Vwindow_combination_limit.
1270 (recombine_windows, make_parent_window, make_window)
1271 (Fsplit_window_internal, saved_window)
1272 (Fset_window_configuration, save_window_save): Rename all
1273 occurrences of window_nest to window_combination_limit.
1275 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1277 * image.c (imagemagick_load_image): Fix typo.
1279 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1281 * xdisp.c (display_line): Move the call to
1282 highlight_trailing_whitespace before the call to
1283 compute_line_metrics, since the latter needs to see the final
1284 faces of all the glyphs to compute ROW's hash value.
1285 Fixes assertion violations in row_equal_p. (Bug#10035)
1287 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1289 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1290 just return (bug#10044).
1292 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1294 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1295 with user-defined heap size. Bump the default size of the temacs
1296 heap to 27MB, to avoid memory warning when running temacs.
1297 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1299 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1300 current_matrix and desired_matrix. (Bug#9990)
1301 (verify_row_hash) [XASSERTS]: New function.
1302 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1303 that the hash value of glyph rows is correct.
1305 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1307 * window.h (window): Remove splits slot.
1308 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1309 (Fdelete_other_windows_internal, make_parent_window)
1310 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1311 (Fset_window_configuration, save_window_save): Don't deal with
1312 split status of windows.
1313 (saved_window): Remove splits slot.
1314 (Vwindow_splits): Rewrite doc-string.
1316 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1318 * xfns.c (unwind_create_frame):
1319 * nsfns.m (unwind_create_frame):
1320 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1321 Vframe_list (Bug#9999).
1323 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1325 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1327 2011-11-11 Kenichi Handa <handa@m17n.org>
1329 * callproc.c (Fcall_process): Set the member dst_multibyte of
1332 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1334 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1335 avoid a crash (bug#9496).
1337 2011-11-09 Chong Yidong <cyd@gnu.org>
1339 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1340 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1342 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1344 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1346 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1348 Avoid some portability problems by eschewing 'extern inline' functions.
1349 The trivial performance wins aren't worth the portability hassles; see
1350 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1352 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1353 (window_box_width, window_box_left, window_box_left_offset)
1354 (window_box_right, window_box_right_offset): Undo previous change,
1355 by removing the "extern"s.
1356 * intervals.c (adjust_intervals_for_insertion)
1357 (adjust_intervals_for_deletion): Undo previous change,
1358 making these static again.
1359 (offset_intervals, temp_set_point_both, temp_set_point)
1360 (copy_intervals_to_string): No longer inline.
1361 * xdisp.c (window_text_bottom_y, window_box_width)
1362 (window_box_height, window_box_left_offset)
1363 (window_box_right_offset, window_box_left, window_box_right)
1364 (window_box): No longer inline.
1366 2011-11-08 Chong Yidong <cyd@gnu.org>
1368 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1369 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1370 Signal an error if not a live window.
1371 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1372 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1374 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1376 * lisp.h (syms_of_abbrev): Remove declaration.
1377 Reported by CHENG Gao <chenggao@royau.me>.
1379 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1381 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1382 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1383 of temacs in GUI mode.
1385 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1387 * window.h: Declare delete_all_child_windows instead of
1388 delete_all_subwindows.
1389 * window.c (Fwindow_nest, Fset_window_nest)
1390 (Fset_window_new_total, Fset_window_new_normal)
1391 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1392 (delete_all_subwindows): Rename to delete_all_child_windows.
1393 (Fdelete_other_windows_internal, Fset_window_configuration):
1394 Call delete_all_child_windows instead of delete_all_subwindows.
1395 * frame.c (delete_frame): Call delete_all_child_windows instead
1396 of delete_all_subwindows.
1398 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1400 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1401 This is also needed for porting to any host where GC_MARK_STACK is
1402 not GC_MAKE_GCPROS_NOOPS.
1403 (which_symbols): Use it.
1405 2011-11-07 Kenichi Handa <handa@m17n.org>
1407 * coding.c (coding_set_destination): Check coding->src_pos only
1408 when coding->src_object is a buffer (bug#9910).
1410 * process.c (send_process): Set the member src_multibyte of coding
1411 to 0 (bug#9911) when sending a unibyte text.
1413 * callproc.c (Fcall_process): Set the member src_multibyte of
1414 process_coding to 0 (bug#9912).
1416 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1418 * xmenu.c (cleanup_widget_value_tree): New function.
1419 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1420 calling free_menubar_widget_value_tree directly (Bug#9830).
1422 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1424 Fix some portability problems with 'inline'.
1425 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1426 (window_box_width, window_box_left, window_box_left_offset)
1427 (window_box_right, window_box_right_offset): Declare extern.
1428 Otherwise, these inline functions do not conform to C99 and
1429 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1430 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1431 * intervals.c (adjust_intervals_for_insertion)
1432 (adjust_intervals_for_deletion): Now extern, because otherwise the
1433 extern inline functions 'offset_intervals' couldn't refer to it.
1434 (static_offset_intervals): Remove.
1435 (offset_intervals): Rewrite using the old contents of
1436 static_offset_intervals. The old version didn't conform to C99
1437 because an extern inline function contained a reference to an
1438 identifier with static linkage.
1440 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1442 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1445 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1447 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1448 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1449 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1450 return Qleft_to_right.
1452 2011-11-06 Chong Yidong <cyd@gnu.org>
1454 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1455 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1456 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1457 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1458 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1459 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1460 (Fwindow_vscroll): Doc fix.
1461 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1462 argument, since it makes no sense to pass a live window and for
1463 consistency with window-child.
1465 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1467 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1470 2011-11-05 Jason Rumney <jasonr@gnu.org>
1472 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1473 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1475 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1476 bitwise arithmetic preventing use of unicode-sip and non-truetype
1479 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1481 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1484 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1485 initialization code to keep similarity to xfns.c after changes
1488 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1490 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1491 (unwind_create_frame): New function (Bug#9943).
1492 (Fx_create_frame): Restructure code to be more similar to the one in
1493 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1494 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1495 Move terminal->reference_count++ just before making the frame official
1498 * nsterm.m (x_free_frame_resources): New function.
1499 (x_destroy_window): Move code to x_free_frame_resources.
1501 * xfns.c (unwind_create_frame): Fix comment.
1502 (Fx_create_frame, x_create_tip_frame):
1503 Move terminal->reference_count++ just before making the frame
1504 official. Move initialization of image_cache_refcount and
1505 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1507 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1509 Support MSVC build with newer versions of Visual Studio.
1510 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1511 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1514 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1515 which are not supported by MSVC.
1516 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1517 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1519 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1521 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1523 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1525 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1527 Support MSVC build with newer versions of Visual Studio.
1528 * w32.c: Don't include w32api.h for MSVC.
1529 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1531 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1532 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1533 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1534 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1536 (alloca) [_MSC_VER]: Define to _alloca.
1538 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1540 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1542 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1544 * xdisp.c (note_mouse_highlight): If either of
1545 previous/next-single-property-change returns nil, treat that as
1546 the beginning or the end of the buffer. (Bug#9955)
1548 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1550 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1551 label is not null (Bug#9951).
1552 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1555 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1557 * window.c (Fwindow_body_size): Mention in the doc string that the
1558 return value is in frame's canonical units. (Bug#9949)
1560 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1562 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1564 * w32fns.c (unwind_create_frame): If needed, free the glyph
1565 matrices of the partially constructed frame. (Bug#9943)
1566 * xfns.c (unwind_create_frame): Likewise.
1568 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1570 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1571 Don't stop backward scan on the continuation glyph, even though
1572 its CHARPOS is positive.
1573 (mouse_face_from_buffer_pos, note_mouse_highlight):
1574 Rename cover_string to disp_string.
1576 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1578 * window.c (temp_output_buffer_show): Don't use
1579 Vtemp_buffer_show_specifiers.
1580 (Vtemp_buffer_show_specifiers): Remove unused variable.
1582 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1584 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1585 past the beginning of the current glyph matrix.
1587 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1589 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1590 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1591 HAVE_GTK3 (Bug#9869).
1593 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1594 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1596 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1598 * xterm.c: Declare x_handle_net_wm_state to return int.
1599 (handle_one_xevent): Check if we are iconified but don't have
1600 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1601 (get_current_wm_state): Return non-zero if not hidden,
1602 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1603 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1604 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1605 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1607 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1609 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1610 so that this new function doesn't get optimized away by a
1611 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1613 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1615 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1617 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1619 Fix the `xbytecode' command.
1620 * .gdbinit (xprintbytestr): New command.
1621 (xwhichsymbols): Rename from `which'; all callers changed.
1622 (xbytecode): Print the byte-code string as well.
1624 2011-10-29 Kim Storm <storm@cua.dk>
1626 * alloc.c (which_symbols): New function.
1628 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1630 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1633 2011-10-29 Glenn Morris <rgm@gnu.org>
1635 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1636 Not clear what it was for, and it causes various bugs. (Bug#9839)
1638 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1640 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1641 possible random value that matches one of those tested as
1642 condition to clear the mouse face.
1644 2011-10-28 Chong Yidong <cyd@gnu.org>
1646 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1648 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1650 * window.c (make_window): Initialize phys_cursor_on_p.
1652 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1654 * lisp.h (struct Lisp_Symbol): Update comments.
1656 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1658 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1660 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1662 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1663 <oslsachem@gmail.com> for helping to debug this.
1665 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1666 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1667 (g_b_init_get_glyph_outline_w): New static variables.
1668 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1669 (GetGlyphOutlineW_Proc): New typedefs.
1670 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1671 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1673 (w32font_open_internal, compute_metrics):
1674 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1675 instead of calling the "wide" APIs directly.
1677 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1679 * w32.h (syms_of_w32font): Add prototype.
1681 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1683 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1684 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1685 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1686 (Fmove_to_window_line): Doc fix.
1688 2011-10-27 Chong Yidong <cyd@gnu.org>
1690 * process.c (make_process): Set gnutls_state to NULL.
1692 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1693 non-NULL, regardless of GNUTLS_INITSTAGE.
1694 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1695 an error. Set process slots as soon as we allocate them.
1697 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1699 2011-10-27 Chong Yidong <cyd@gnu.org>
1701 * gnutls.c (emacs_gnutls_deinit): New function.
1702 Deallocate credentials structures as well as calling gnutls_deinit.
1703 (Fgnutls_deinit, Fgnutls_boot): Use it.
1705 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1706 (deactivate_process): Call emacs_gnutls_deinit.
1708 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1710 * image.c (x_create_x_image_and_pixmap):
1711 * w32.c (sys_rename, w32_delayed_load):
1712 * w32font.c (fill_in_logfont):
1713 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1715 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1717 * w32fns.c (w32_default_color_map): New function,
1718 extracted from Fw32_default_color_map.
1719 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1721 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1723 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1725 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1727 * keyboard.c (test_undefined): New function (bug#9751).
1728 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1730 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1732 * sysdep.c (init_sys_modes): Fix the check for the controlling
1733 terminal (Bug#6649).
1735 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1737 * dispextern.h (struct bidi_it): New member next_en_type.
1739 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1740 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1741 current character, check also for next_en_type being WEAK_EN.
1742 (bidi_resolve_weak): Don't enter the expensive loop if the current
1743 position is before next_en_pos. Record the bidi type of the first
1744 non-ET, non-BN character we find, in addition to its position.
1745 (bidi_level_of_next_char): Invalidate next_en_type when
1746 next_en_pos is over-stepped.
1748 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1750 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1751 * editfns.c: Rewrite current-time-zone so that it invokes
1752 the equivalent of (format-time-string "%Z") to get the time zone name.
1753 This fixes a bug when the time zone name contains characters that
1754 need converting from the system time locale to Emacs internal format.
1755 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1756 that patch fixed format-time-string to do the conversion, but
1757 I forgot to fix current-time-zone.
1758 (format_time_string): New function, containing most of
1759 what Fformat_time_string used to contain.
1760 (Fformat_time_string): Rewrite in terms of format_time_string.
1761 This doesn't change this function's behavior.
1762 (current-time-zone): Rewrite to use format_time_string.
1763 This fixes the bug reported by Michael Schierl in
1764 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1765 Jason Rumney's 2007-06-07 change worked around this bug, but
1767 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1769 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1771 * xdisp.c (start_display): If the character at POS is displayed
1772 via a display vector, reset IT->current.dpvec_index to zero.
1773 (try_window_reusing_current_matrix): If a line ends in a display
1774 vector or the next line starts in a display vector, continue
1775 redrawing the window even though the character position of
1776 start_row was reached.
1779 2011-10-18 Chong Yidong <cyd@gnu.org>
1781 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1782 with nobreak-char-display too.
1784 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1786 Fix part 3 of bug#9771.
1787 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1788 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1789 non-neutral characters if the current character is a paragraph
1790 separator (a.k.a. Newline). This avoids running the same
1791 expensive loop twice, once when we consume the preceding newline
1792 and the other time when the line actually needs to be displayed.
1793 Avoid the loop when we see neutrals on the base embedding level
1794 following a character whose directionality is the same as the
1795 paragraph's. This avoids running the expensive loop when a line
1796 ends in a long sequence of neutrals, like control characters.
1797 Add assertion against STRONG_AL type. Slightly rearrange code
1798 that determines the type of a neutral given the first non-neutral
1800 (bidi_level_of_next_char): Set next_en_pos to zero when
1801 invalidating its info.
1803 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1805 * xdisp.c (push_display_prop): Determine whether to record string
1806 or buffer position by IT->string, not by IT->method. Allow
1807 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1808 (move_it_vertically_backward): Don't look for character position
1809 immediately after the newline when in a continuation line.
1812 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1814 * window.c (coordinates_in_window): Rewrite and delabelize
1815 vertical border check. (Bug#5357) (Bug#9618)
1817 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1819 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1820 errors in XSetWindowBorder (bug#9310).
1822 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1824 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1825 avoid crash when xmalloc overrun checking is enabled.
1827 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1829 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1830 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1831 cursor motion with <left> and <right> arrow keys.
1833 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1834 some callers set that themselves.
1836 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1838 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1839 display string and the previous row comes from the same string and
1840 is empty. (Bug#9739) (Bug#9738)
1842 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1844 * doc.c (get_doc_string): Encode file name (bug#9735).
1846 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1848 * bidi.c (bidi_level_of_next_char):
1849 * xdisp.c (get_visually_first_element): Remove old incorrect
1850 comments regarding the Unicode Line Separator character.
1852 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1854 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1856 * alloc.c (Fgc_status): Do not access beyond zombies array
1857 boundary if nzombies > MAX_ZOMBIES.
1858 * alloc.c (dump_zombies): Add missing format specifier.
1860 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1862 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1863 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1865 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1866 Some packages use them to denote characters with modifiers.
1868 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1870 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1871 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1872 matching a pp-number. Rename parameter var to var1.
1874 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1876 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1878 2011-10-08 Glenn Morris <rgm@gnu.org>
1880 * callint.c (Fcall_interactively): Give a more explicit error for the
1881 'c' case with a non-character input. (Bug#8479)
1883 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1885 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1887 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1888 lines that are hscrolled on the left.
1890 * dispnew.c (buffer_posn_from_coords): Account for a possible
1891 presence of header-line. (Bug#4426)
1893 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1895 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1896 Don't advertise functionality which we discourage or doesn't work.
1898 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1900 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1901 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1902 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1903 this makes Emacs dump core during garbage collection on rare
1904 occasions. sizeof is obviously inferior to offsetof here, so
1905 stick with offsetof.
1906 (GC_POINTER_ALIGNMENT): New macro.
1907 (mark_memory): Omit 3rd (offset) arg; caller changed.
1908 Don't assume EMACS_INT alignment is the same as pointer alignment.
1910 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1912 * keyboard.c (read_key_sequence_remapped): New var.
1913 (read_key_sequence): Compute remapping in the right buffer.
1914 (command_loop_1): Use read_key_sequence's remapping directly.
1916 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1918 * dired.c (file_name_completion): Don't expand file name.
1919 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1920 before checking file name handler.
1922 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1923 they've been requested explicitly (bug#9591).
1925 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1927 * keymap.c (Fsingle_key_description): Use make_specified_string
1928 instead of build_string to build string from push_key_description.
1931 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1933 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1934 This fixes a Y2038 bug on 64-bit hosts.
1935 * buffer.c (reset_buffer):
1936 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1937 (Fclear_buffer_auto_save_failure):
1938 Use 0, not -1, to represent an unset failure time, since time_t
1939 might not be signed.
1941 Remove dependency on glibc malloc internals.
1942 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1943 Move back here from lisp.h, but with their new implementations.
1944 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1945 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1946 * charset.c (charset_table_init): New static var.
1947 (syms_of_charset): Use it instead of xmalloc. This removes a
1948 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1949 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1950 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1951 Move back to alloc.c.
1952 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1953 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1955 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1957 * nsterm.m (windowDidResize): Call x_set_window_size only when
1958 ns_in_resize is true. Otherwise set pixelwidth/height and
1959 call change_frame_size (Bug#9628).
1961 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1963 Port --enable-checking=all to Fedora 14 x86-64.
1964 * charset.c (syms_of_charset): Also account for glibc malloc's
1965 internal overhead when calculating the initial malloc maximum.
1967 Port --enable-checking=all to Fedora 14 x86.
1968 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1970 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1971 (overrun_check_realloc, overrun_check_free):
1972 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1973 That way, xmalloc returns a properly-aligned pointer even if
1974 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1975 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1976 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1977 into account when calculating the initial malloc maximum.
1978 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1979 Move here from alloc.c, so that charset.c can use it too.
1980 Properly align; the old code wasn't right for common 32-bit hosts
1981 when configured with --enable-checking=all.
1982 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1983 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1985 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1987 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1990 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1992 * xdisp.c (compute_display_string_end): If there's no display
1993 string at CHARPOS, return -1.
1995 * bidi.c (bidi_fetch_char): When compute_display_string_end
1996 returns a negative value, treat the character as a normal
1997 character not covered by a display string. (Bug#9624)
1999 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2001 * lread.c (Fread_from_string): Fix typo in docstring.
2003 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2005 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2006 newline, reseat the iterator instead of bidi-iterating there one
2007 character at a time. (Bug#9610)
2008 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2009 TO_CHARPOS if the bidi iterator is at base embedding level.
2011 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2013 * lread.c (readevalloop): Use correct code for NBSP.
2014 (read1): Likewise. (Bug#9608)
2016 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2018 * dbusbind.c (Fdbus_register_signal): When service is not
2019 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2021 2011-09-25 Glenn Morris <rgm@gnu.org>
2023 * buffer.c (truncate-lines): Doc fix.
2025 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2027 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2028 (Fset_window_next_buffers): Doc fix.
2030 2011-09-24 Glenn Morris <rgm@gnu.org>
2032 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2034 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2036 Fix minor problems found by static checking.
2037 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2038 * indent.c (Fvertical_motion): Fix == vs = typo.
2040 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2042 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2043 Default value is now t. Doc fix.
2045 * indent.c (Fvertical_motion): Compute and apply the overshoot
2046 logic when moving up, not only when moving down. Fix the
2047 confusing name and values of the it_overshoot_expected variable;
2048 logic changes accordingly. (Bug#9254) (Bug#9549)
2050 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2051 CHARPOS is covered by a display string which includes newlines.
2052 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2053 is covered by a display string with embedded newlines.
2055 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2057 * dbusbind.c (Fdbus_register_signal): Add match rule to
2058 Vdbus_registered_objects_table. (Bug#9581)
2059 (Fdbus_register_method, Vdbus_registered_objects_table):
2062 2011-09-24 Jim Meyering <meyering@redhat.com>
2064 do not ignore write error for any output size
2065 The previous change was incomplete.
2066 While it makes emacs --batch detect the vast majority of stdout
2067 write failures, errors were still ignored whenever the output size is
2068 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2069 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2070 && echo FAIL: ignored write error
2071 FAIL: ignored write error
2072 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2073 && echo FAIL: ignored write error
2074 FAIL: ignored write error
2075 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2077 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2079 * emacs.c (Fkill_emacs): In noninteractive mode exit
2080 non-successfully if a write error occurred on stdout. (Bug#9574)
2082 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2084 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2087 * dispextern.h (struct it): Update the comment documenting what
2090 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2092 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2093 a display string, extend search for cursor position to end of row.
2094 (find_row_edges): If the row ends in a newline from a display
2095 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2096 Handle the case of a display string with multiple newlines.
2097 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2098 non-empty line. Fixes confusing cursor motion with arrow keys at
2099 the beginning of a line that starts with whitespace.
2101 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2103 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2106 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2108 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2111 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2113 * xdisp.c (display_line): Record maximum and minimum buffer
2114 positions even if no glyphs were produced (e.g., by a zero-width
2115 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2116 buffer positions that will be removed from the glyph row because
2118 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2119 column is beyond frame width: don't subtract 1 "pixel" when
2120 computing width of the stretch.
2121 (reseat_at_next_visible_line_start): Undo the change made on
2122 2011-09-17 that saved paragraph information and restored it after
2123 the call to `reseat'. (Bug#9545)
2125 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2127 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2128 and turn window cursor on if cleared (Bug#9415).
2130 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2132 * search.c (boyer_moore): Take unibyte characters from pattern
2133 literally. (Bug#9458)
2135 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2137 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2139 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2141 Fix minor problem found by static checking.
2142 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2143 initialized, to pacify gcc -Wuninitialized.
2145 * fileio.c: Report proper errno when syscall falls.
2146 (Finsert_file_contents): Save and restore errno,
2147 so that report_file_error outputs the correct diagnostic.
2148 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2150 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2152 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2154 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2156 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2157 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2159 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2161 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2162 about the current paragraph and restore it after the call to reseat.
2164 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2165 (bidi_find_paragraph_start): Search back for paragraph beginning
2166 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2167 (bidi_move_to_visually_next): Only trigger paragraph-related
2168 computations when the last character is a newline or at EOB, not
2169 just any NEUTRAL_B. (Bug#9470)
2171 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2172 truncated lines if point is covered by a display string. (Bug#9524)
2174 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2176 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2177 (cons_to_x_long): New function.
2178 (lisp_data_to_selection_data): Use it. Correct the test for
2179 short-versus-long data; it was negated. Break out of vector
2180 loop, for efficiency, when a long datum is discovered.
2182 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2184 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2186 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2188 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2189 GCC PR/17406) by declaring this function with external scope.
2191 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2193 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2194 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2196 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2198 * editfns.c (Fformat): Correctly handle text properties on "%%".
2200 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2202 * xterm.c (x_draw_composite_glyph_string_foreground):
2203 * w32term.c (x_draw_composite_glyph_string_foreground):
2204 * term.c (encode_terminal_code):
2205 * composite.c (composition_update_it, get_composition_id):
2206 * xdisp.c (get_next_display_element)
2207 (fill_composite_glyph_string): Add comments about special meaning
2208 of TAB characters in a composition.
2210 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2212 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2213 This occurs when processing a multibyte format.
2214 Problem reported by Wolfgang Jenker.
2216 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2218 * xdisp.c (try_cursor_movement): Only check for exact match if
2219 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2221 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2223 Remove unused external symbols.
2224 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2225 * xdisp.c (calc_pixel_width_or_height): Now static.
2226 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2227 * indent.c (check_display_width):
2228 * w32term.c: Fix comment to match code.
2229 * xterm.c, xterm.h (x_catching_errors): Remove.
2231 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2233 * xselect.c: Use signed conversions more consistently (Bug#9498).
2234 (selection_data_to_lisp_data): Assume incoming selection data are
2235 signed integers, not unsigned. This is to be consistent with
2236 outgoing selection data, which was modified to use signed integers
2237 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2238 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2239 expects long, not unsigned long.
2241 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2243 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2244 computation of loop end. Reported by Johan Bockgård
2247 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2249 * frame.c (Fother_visible_frames_p): Function deleted.
2251 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2253 * indent.c (compute_motion): Process display vector front to back
2254 rather than the other way around. (Bug#2496)
2256 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2258 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2260 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2262 * minibuf.c (Fread_from_minibuffer): Doc fix.
2264 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2266 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2267 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2269 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2271 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2272 value for non-existent files.
2274 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2276 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2277 set its "size" to -1. This will set the modtime_size field of
2278 the corresponding buffer to -1, which is what
2279 verify-visited-file-modtime expects for files that do not exist.
2282 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2284 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2286 * lisp.h: ... from here. push_key_description is no longer
2287 defined in keyboard.c, so its declaration should not be in
2288 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2289 logically belongs with push_key_description.
2291 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2293 * buffer.h: Include <sys/types.h> instead of <time.h>.
2294 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2295 Problem reported by Herbert J. Skuhra.
2297 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2299 * xml.c (parse_region): Make the parsing work for
2300 non-comment-starting XML files again (bug#9144).
2302 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2304 * image.c (gif_load): Fix calculation of bottom and right corner.
2307 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2309 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2310 redisplay in small windows.
2312 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2314 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2316 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2318 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2319 Operate on live windows only.
2321 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2323 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2325 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2327 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2328 only under bidi iteration.
2330 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2332 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2334 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2336 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2337 Without this fix, the command to link temacs failed due to an
2338 undefined symbol __builtin_isnan. This is because
2339 /usr/include/iso/math_c99.h #defines isnan(x) to
2340 __builtin_isnan(x), but the bundled gcc, which identifies itself
2341 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2343 * floatfns.c (isnan): #undef, and then #define to a clone of
2345 (Fisnan): Always define, since it's always available now.
2346 (syms_of_floatfns): Always define isnan at the Lisp level.
2348 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2350 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2352 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2354 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2355 The previous code assumed that file offsets (off_t values) fit in
2356 EMACS_INT variables, which is not true on typical 32-bit hosts.
2357 The code messed up by falsely reporting buffer overflow in cases
2358 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2359 when "big" contains more than 2**29 bytes, even though this
2360 inserts just one byte and does not overflow the buffer.
2361 (Finsert_file_contents): Store file offsets as off_t
2362 values, not as EMACS_INT values. Check for overflow when
2363 converting between EMACS_INT and off_t. When checking for
2364 buffer overflow or for overlap, take the offsets into account.
2365 Don't use EMACS_INT for small values where int suffices.
2366 When checking for overlap, fix a typo: ZV was used where
2367 ZV_BYTE was intended.
2368 (Fwrite_region): Don't assume off_t fits into 'long'.
2369 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2371 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2373 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2375 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2377 sprintf-related integer and memory overflow issues (Bug#9412).
2379 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2380 (esprintf, exprintf, evxprintf): New functions.
2381 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2382 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2383 (modify_event_symbol): Do not assume that the length of
2384 name_alist_or_stem is safe to alloca and fits in int.
2385 (Fexecute_extended_command): Likewise for function name and binding.
2386 (Frecursion_depth): Wrap around reliably on integer overflow.
2387 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2388 since some callers pass EMACS_INT values.
2389 (Fsingle_key_description): Don't crash if symbol name contains more
2390 than MAX_ALLOCA bytes.
2391 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2392 (get_minibuffer): Arg is now EMACS_INT, not int.
2393 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2394 (esprintf, exprintf, evxprintf): New decls.
2395 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2397 * dbusbind.c (signature_cat): New function.
2398 (xd_signature, Fdbus_register_signal):
2399 Do not overrun buffer; instead, report string overflow.
2401 * dispnew.c (add_window_display_history): Don't overrun buffer.
2402 Truncate instead; this is OK since it's just a log.
2404 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2405 even if the time zone offset is outlandishly large.
2406 Don't mishandle offset == INT_MIN.
2408 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2409 when creating daemon; the previous buffer-overflow check was incorrect.
2411 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2412 which has the guts of the old verror function.
2414 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2415 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2417 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2418 (font_unparse_xlfd): Don't blindly alloca long strings.
2419 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2420 fits in int, when using sprintf. Use single snprintf to count
2421 length of string rather than counting it via multiple sprintfs;
2422 that's simpler and more reliable.
2423 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2424 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2425 sprintf, in case result does not fit in int.
2427 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2428 (fontset_from_font): Print it.
2430 * frame.c (tty_frame_count): Now printmax_t, not int.
2431 (make_terminal_frame, set_term_frame_name): Print it.
2432 (x_report_frame_params): In X, window IDs are unsigned long,
2433 not signed long, so print them as unsigned.
2434 (validate_x_resource_name): Check for implausibly long names,
2435 and don't assume name length fits in 'int'.
2436 (x_get_resource_string): Don't blindly alloca invocation name;
2437 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2440 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2441 (xg_check_special_colors, xg_set_geometry):
2442 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2444 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2445 Use esprintf, not sprintf, in case result does not fit in int.
2447 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2448 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2449 it as a large positive number.
2450 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2451 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2453 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2454 in case result does not fit in int.
2456 * print.c (float_to_string): Detect width overflow more reliably.
2457 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2458 buffer overrun. Don't assume list length fits in 'int'. Treat
2459 print length of 0 as 0, not as infinity; to be consistent with other
2460 uses of print length in this function. Don't overflow print length
2461 index. Don't assume hash table size fits in 'long', or that
2462 vectorlike size fits in 'unsigned long'.
2464 * process.c (make_process): Use printmax_t, not int, to format
2465 process-name gensyms.
2467 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2469 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2470 to avoid potential buffer overrun.
2472 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2473 if X resource line is longer than 512 bytes.
2475 * xfns.c (x_window): Make sprintf buffer a bit bigger
2476 to avoid potential buffer overrun.
2478 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2480 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2482 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2484 Integer overflow fixes for scrolling, etc.
2485 Without these, Emacs silently mishandles large integers sometimes.
2486 For example, "C-u 4294967297 M-x recenter" was treated as if
2487 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2489 * xdisp.c (try_window_id): Check Emacs fixnum range before
2490 converting to 'int'.
2492 * window.c (window_scroll_line_based, Frecenter):
2493 Check that an Emacs fixnum is in range before assigning it to 'int'.
2494 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2495 values converted from Emacs fixnums.
2496 (Frecenter): Don't wrap around a line count if it is out of 'int'
2497 range; instead, treat it as an extreme value.
2498 (Fset_window_configuration, compare_window_configurations):
2499 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2501 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2502 that can exceed INT_MAX. Check that EMACS_INT value is in range
2503 before assigning it to the (possibly-narrower) index.
2504 (match_limit): Don't assume that a fixnum can fit in 'int'.
2506 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2509 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2510 (Fvertical_motion): Don't wrap around LINES values that don't fit
2511 in 'int'. Instead, treat them as extreme values. This is good
2512 enough for windows, which can't have more than INT_MAX lines anyway.
2514 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2516 * Require libxml/parser.h to avoid compilation warning.
2518 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2520 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2521 since this reportedly can destroy thread storage.
2523 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2525 * syntax.c (find_defun_start): Update all cache variables if
2526 exiting early (Bug#9401).
2528 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2530 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2532 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2533 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2534 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2536 * term.c (tty_append_glyph): New function.
2537 (produce_stretch_glyph): Static function and its prototype deleted.
2539 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2542 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2544 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2545 when checking :margin (Bug#9390).
2546 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2547 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2548 so that the name doesn't mislead. All uses changed.
2550 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2552 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2555 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2557 * xdisp.c (move_it_to): Don't bail out early when reaching
2558 position beyond to_charpos, if we are scanning backwards.
2559 (move_it_vertically_backward): When DY == 0, make sure we get to
2560 the first character in the line after the newline.
2562 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2564 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2565 (ccl_driver): Do not generate an out-of-range pointer.
2566 (Fccl_execute_on_string): Remove unnecessary check for
2567 integer overflow, noted by Stefan Monnier in
2568 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2569 Remove a FIXME that didn't need fixing.
2570 Simplify the newly-introduced buffer reallocation code.
2572 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2574 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2576 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2578 Integer and memory overflow issues (Bug#9196).
2580 * doc.c (get_doc_string): Rework so that
2581 get_doc_string_buffer_size is the actual buffer size, rather than
2582 being 1 less than the actual buffer size; this makes xpalloc more
2585 * image.c (x_allocate_bitmap_record, cache_image):
2586 * xselect.c (Fx_register_dnd_atom):
2587 Simplify previous changes by using xpalloc.
2589 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2590 since either will do and ptrdiff_t is convenient with xpalloc.
2592 * charset.c (charset_table_size)
2593 (struct charset_sort_data.priority): Now ptrdiff_t.
2594 (charset_compare): Don't overflow if priorities differ greatly.
2595 (Fsort_charsets): Don't assume list length fits in int.
2596 Check for size-calculation overflow when allocating sort data.
2597 (syms_of_charset): Allocate an initial charset table that is
2598 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2600 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2602 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2603 The actual value is always <= INT_MAX, and leaving it unsigned made
2604 overflow checking harder.
2606 * dispextern.h (struct glyph_matrix.rows_allocated)
2607 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2608 with xpalloc. The values are still always <= INT_MAX.
2610 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2612 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2613 (SAFE_NALLOCA): New macro.
2615 * region-cache.c (struct boundary.pos, find_cache_boundary)
2616 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2617 (set_cache_region, invalidate_region_cache)
2618 (revalidate_region_cache, know_region_cache, region_cache_forward)
2619 (region_cache_backward, pp_cache):
2620 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2621 so that ptrdiff_t * can be passed to xpalloc.
2622 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2623 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2624 (pp_cache): Don't assume cache_len fits in int.
2625 * region-cache.h: Adjust extern decls to match.
2627 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2628 EMACS_INT, since either will do, for xpalloc.
2630 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2631 (xnmalloc, xnrealloc, xpalloc): New functions.
2633 * bidi.c (bidi_shelve_header_size): New constant.
2634 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2635 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2637 * bidi.c (bidi_cache_shrink):
2638 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2640 Don't update size of array until after memory allocation succeeds,
2641 because xmalloc/xrealloc may not return.
2642 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2643 now that we have proper integer overflow checking.
2644 (record_overlay_string, overlay_strings): Catch overflows when
2645 calculating size of overlay_str_buf.
2647 * callproc.c (Fcall_process): Check for size overflow when
2648 calculating size of args2.
2649 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2650 Normally we prefer signed values, but sticking with ptrdiff_t would
2651 require adding more-complicated checks.
2653 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2654 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2655 Redo buffer-overflow calculations to avoid integer overflow.
2656 Add a FIXME comment where memory seems to be over-allocated.
2658 * character.c (Fstring): Check for size-calculation overflow.
2660 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2661 unnecessary integer overflow. Check for size overflow.
2662 (encode_coding_object): Don't update size until xmalloc succeeds.
2664 * composite.c (get_composition_id): Check for overflow in glyph
2665 length calculations.
2667 Integer and memory overflow fixes for display code.
2668 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2669 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2670 (scrolling_window): Check for overflow in size calculations.
2671 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2672 Don't assume glyph table len fits in int.
2673 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2674 (row_table_size): Now ptrdiff_t, not int.
2675 (scrolling_window): Avoid overflow in size calculations.
2676 Don't update size until allocation succeeds.
2677 * fns.c (concat): Check for overflow in size calculations.
2678 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2679 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2680 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2682 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2683 (get_doc_string): Check for size calculation overflow.
2684 Don't update size until allocation succeeds.
2685 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2686 EMACS_INT, where ptrdiff_t will do.
2687 (Fsubstitute_command_keys): Check for string overflow.
2689 * editfns.c (set_time_zone_rule): Don't assume environment length
2691 (message_length): Now ptrdiff_t, not int.
2692 (Fmessage_box): Don't update size until allocation succeeds.
2693 Don't assume message length fits in int.
2694 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2696 * emacs.c (main): Do not reallocate argv, since there is a null at
2697 the end that can be overwritten, and this way there's no need to
2698 worry about size-calculation overflow.
2699 (sort_args): Check for size-calculation overflow.
2701 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2703 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2705 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2706 (x_set_scroll_bar_width, x_figure_window_size):
2707 Check for integer overflow.
2708 (x_set_alpha): Do not assume XINT fits in int.
2710 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2711 This is for the members text_lines, text_cols, total_lines, total_cols,
2712 where the system imposes an 'int' limit.
2714 * fringe.c (Fdefine_fringe_bitmap):
2715 Don't update size until alloc works.
2717 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2718 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2720 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2721 Check for size-calculation overflow.
2722 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2723 do, as we prefer signed integers.
2724 (id_to_widget.max_size, id_to_widget.used)
2725 (xg_store_widget_in_map, xg_remove_widget_from_map)
2726 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2727 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2728 Use and return ptrdiff_t, not int.
2729 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2730 * gtkutil.h: Change prototypes to match the above.
2732 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2733 are duplicate now that they've been promoted to lisp.h.
2734 (x_allocate_bitmap_record, x_alloc_image_color)
2735 (make_image_cache, cache_image, xpm_load):
2736 Don't update size until alloc is done.
2737 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2739 Check for size calculation overflow.
2740 (ct_colors_allocated_max): New constant.
2741 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2744 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2745 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2746 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2747 Use ptrdiff_t, not int, to count maps.
2748 (read_char_minibuf_menu_prompt): Check for overflow in size
2749 calculations. Don't update size until allocation succeeds.
2750 Redo calculations to avoid overflow.
2751 * keyboard.h: Change prototypes to match the above.
2753 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2755 (current_minor_maps): Check for size calculation overflow.
2756 * keymap.h: Change prototypes to match the above.
2758 * lread.c (read1, init_obarray): Don't update size until alloc done.
2760 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2761 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2763 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2764 Now ptrdiff_t, not int.
2765 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2766 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2768 * process.c (Fnetwork_interface_list): Check for overflow
2769 in size calculation.
2771 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2773 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2774 overflow. Don't bother calling xmalloc when xrealloc will do.
2776 * search.c (Freplace_match): Check for size calculation overflow.
2777 (Fset_match_data): Don't assume list lengths fit in 'int'.
2779 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2780 for command line length. Do not attempt to address one before the
2781 beginning of an array, as that's not portable.
2783 * term.c (max_frame_lines): Remove; unused.
2784 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2786 (encode_terminal_code, calculate_costs): Check for size
2787 calculation overflow.
2788 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2789 table lengths and related sizes. Don't update size until alloc
2790 done. Redo calculations to avoid overflow.
2791 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2793 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2794 subtracting pointers.
2795 (gobble_line): Check for overflow more carefully. Don't update size
2798 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2799 Don't update size until alloc done.
2800 Redo size calculations to avoid overflow.
2801 Check for size calculation overflow.
2802 (main) [DEBUG]: Fix typo in invoking tparam1.
2804 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2805 Use ptrdiff_t, not int, for sizes.
2806 (store_mode_line_noprop_char): Don't update size until alloc done.
2808 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2809 Use ptrdiff_t, not int, for sizes.
2810 (Finternal_make_lisp_face, cache_face):
2811 Check for size calculation overflow.
2812 (cache_face): Treat size calculation overflows as if they were
2813 memory exhaustion (the usual treatment), rather than aborting.
2815 * xfns.c (x_encode_text, x_set_name_internal)
2816 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2817 sizes, since they can exceed INT_MAX in size. Check for size
2818 calculation overflow.
2820 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2821 (xg_select): Check for size calculation overflow.
2822 Don't update size until alloc done.
2824 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2825 as sprintf is limited to int lengths.
2827 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2828 (X_LONG_MIN): New macros.
2829 Use them to make the following changes clearer.
2830 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2831 This change doesn't affect the value now, but it may help remind
2832 future maintainers not to raise the value too much later.
2833 (SELECTION_QUANTUM): Remove, replacing with ...
2834 (selection_quantum): ... new function, which avoids overflow.
2836 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2837 assumption that selection length fits in 'int'.
2838 (x_reply_selection_request, x_handle_selection_request)
2839 (x_get_window_property, receive_incremental_selection)
2840 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2841 (lisp_data_to_selection_data, clean_local_selection_data):
2842 Use ptrdiff_t, not int, to record length of selection.
2843 (x_reply_selection_request, x_get_window_property)
2844 (receive_incremental_selection, x_property_data_to_lisp):
2845 Redo calculations to avoid overflow.
2846 (x_reply_selection_request): When sending hint, ceiling it at
2847 X_LONG_MAX rather than relying on wraparound overflow to send
2849 (x_get_window_property, receive_incremental_selection)
2850 (lisp_data_to_selection_data, x_property_data_to_lisp):
2851 Check for size-calculation overflow.
2852 (x_get_window_property, receive_incremental_selection)
2853 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2854 Don't store size until memory allocation succeeds.
2855 (x_get_window_property): Plug memory leak on memory exhaustion.
2856 Don't double-block input; malloc is safe here. Don't assume 2**34
2857 - 4 fits in unsigned long. Add an xassert to check
2858 XGetWindowProperty overflow. Be more careful about overflow
2859 calculations, and distinguish size from memory overflow better.
2860 (receive_incremental_selection): When tracing, don't assume
2861 unsigned int is less than INT_MAX.
2862 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2863 harmful) conversions of unsigned short to int.
2864 (lisp_data_to_selection_data): Don't assume that integers
2865 in the range -65535 through -1 fit in an X unsigned short.
2866 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2867 result parameters unless successful. Rely on cons_to_unsigned
2868 to report problems with elements; the old code wasn't right anyway.
2869 (x_check_property_data): Check for int overflow; we cannot use
2870 a wider type due to X limits.
2871 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2873 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2875 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2876 (x_term_init): Check for size calculation overflow.
2877 (x_color_cells): Don't store size until memory allocation succeeds.
2878 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2879 Don't assume alloca size is less than MAX_ALLOCA.
2880 (x_term_init): Don't assume length fits in int (sprintf is limited
2883 Use ptrdiff_t for composition IDs.
2884 * character.c (lisp_string_width):
2885 * composite.c (composition_table_size, n_compositions)
2886 (get_composition_id, composition_gstring_from_id):
2887 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2888 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2889 * window.c (Frecenter):
2890 Use ptrdiff_t, not int, for composition IDs.
2891 * composite.c (get_composition_id): Check for integer overflow.
2892 * composite.h: Adjust prototypes to match the above changes.
2894 Use ptrdiff_t for hash table indexes.
2895 * category.c (hash_get_category_set):
2896 * ccl.c (ccl_driver):
2897 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2898 * coding.c (coding_system_charset_list, detect_coding_system):
2899 * coding.h (struct coding_system.id):
2900 * composite.c (get_composition_id, gstring_lookup_cache):
2901 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2902 * image.c (xpm_get_color_table_h):
2903 * lisp.h (hash_lookup, hash_put):
2904 * minibuf.c (Ftest_completion):
2905 Use ptrdiff_t for hash table indexes, not int (which is too
2906 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2907 32-bit --with-wide-int hosts).
2909 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2910 Add a FIXME comment about memory leaks.
2911 (syms_of_charset): Don't assume xmalloc returns.
2913 Don't assume that stated character widths fit in int.
2914 * character.c (Fchar_width, c_string_width, lisp_string_width):
2915 * character.h (CHAR_WIDTH):
2916 * indent.c (MULTIBYTE_BYTES_WIDTH):
2917 Use sanitize_char_width to avoid undefined and/or bad behavior
2918 with outlandish widths.
2919 * character.h (sanitize_tab_width): Rename from sanitize_width,
2920 now that we have two such functions. All uses changed.
2921 (sanitize_char_width): New inline function.
2923 Don't assume that tab-width fits in int.
2924 * character.h (sanitize_width): New inline function.
2925 (SANE_TAB_WIDTH): New macro.
2926 (ASCII_CHAR_WIDTH): Use it.
2927 * indent.c (sane_tab_width): Remove. All uses replaced by
2928 SANE_TAB_WIDTH (current_buffer).
2929 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2931 * fileio.c: Integer overflow issues with file modes.
2932 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2934 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2935 Remove unreachable code.
2936 (read_hex, load_charset_map_from_file): Check for integer overflow.
2938 * xterm.c: Don't go over XClientMessageEvent limit.
2939 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2940 (x_send_scroll_bar_event): Likewise. Check that the size does not
2941 exceed limits imposed by XClientMessageEvent, as well as the usual
2942 ptrdiff_t and size_t limits.
2944 * keyboard.c: Overflow, signedness and related fixes.
2945 (make_lispy_movement): Use same integer type in forward decl
2946 that is used in the definition.
2947 (read_key_sequence, keyremap_step):
2948 Change bufsize argument back to int, undoing my 2011-03-30 change.
2949 We prefer signed types, and int is wide enough here.
2950 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2951 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2952 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2953 length, not size_t. Use ptrdiff_t for index, not int.
2954 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2955 possibility of integer overflow.
2957 Overflow, signedness and related fixes for images.
2959 * dispextern.h (struct it.stack[0].u.image.image_id)
2960 (struct_it.image_id, struct image.id, struct image_cache.size)
2961 (struct image_cache.used, struct image_cache.ref_count):
2962 * gtkutil.c (update_frame_tool_bar):
2963 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2964 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2965 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2966 * nsmenu.m (update_frame_tool_bar):
2967 * xdisp.c (calc_pixel_width_or_height):
2968 * xfns.c (image_cache_refcount):
2969 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2970 on typical 64-bit hosts.
2972 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2973 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2974 Omit unnecessary casts to int.
2975 (parse_image_spec): Check that integers fall into 'int' range
2976 when the callers expect that.
2977 (image_ascent): Redo ascent calculation to avoid int overflow.
2978 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2979 (lookup_image): Remove unnecessary tests.
2980 (xbm_image_p): Locals are now of int, not EMACS_INT,
2981 since parse_image_check makes sure they fit into int.
2982 (png_load, gif_load, svg_load_image):
2983 Prefer int to unsigned where either will do.
2984 (tiff_handler): New function, combining the cores of the
2985 old tiff_error_handler and tiff_warning_handler.
2986 This function is rewritten to use vsnprintf and thereby avoid
2987 stack buffer overflows. It uses only the features of vsnprintf
2988 that are common to both POSIX and native Microsoft.
2989 (tiff_error_handler, tiff_warning_handler): Use it.
2990 (tiff_load, gif_load, imagemagick_load_image):
2991 Don't assume :index value fits in 'int'.
2992 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2993 (imagemagick_load_image): Check that crop parameters fit into
2994 the integer types that MagickCropImage accepts. Don't assume
2995 Vimagemagick_render_type has a nonnegative value. Don't assume
2996 size_t fits in 'long'.
2997 (gs_load): Use printmax_t to print the widest integers possible.
2998 Check for integer overflow when computing image height and width.
3000 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3002 * xdisp.c (redisplay_window): Don't force window start if point
3003 will be invisible in the resulting window. (Bug#9324)
3005 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3007 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3008 the display spec is of the form `(space ...)'.
3009 (handle_display_spec): Return the value returned by
3010 handle_single_display_spec, not just 1 or zero.
3011 (handle_single_display_spec): If the display spec is of the form
3012 `(space ...)', and specifies display in the text area, return 2
3014 (try_cursor_movement): Check for the need to scroll more
3015 accurately, and prefer exact match for point under bidi.
3016 Don't advance `row' beyond the last row of the window.
3018 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3019 into disp_prop; all users changed.
3021 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3022 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3023 for the text covered by the display property.
3025 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3027 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3028 Change return value to nil.
3029 (Frecord_buffer): Delete unused function.
3031 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3033 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3034 buffers, return left-to-right.
3035 (set_cursor_from_row): Consider candidate row a win if its glyph
3036 represents a newline and point is on that newline. Fixes cursor
3037 positioning on the newline at EOL of R2L text within L2R
3038 paragraph, and vice versa.
3039 (try_cursor_movement): Check continued rows, in addition to
3040 continuation rows. Fixes unwarranted scroll when point enters a
3041 continued line of R2L text within an L2R paragraph, or vice versa.
3042 (cursor_row_p): Consider the case of point being equal to
3043 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3044 from the end of a short line to the beginning of a continued line
3045 of R2L text within L2R paragraph.
3046 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3047 composed characters.
3049 * bidi.c (bidi_check_type): Use xassert.
3050 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3053 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3055 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3058 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3060 * nsfont.m (ns_otf_to_script): Fix typo.
3062 2011-08-22 Kenichi Handa <handa@m17n.org>
3064 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3065 extra slot even if the purpose is char-code-property-table.
3067 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3069 * xdisp.c (redisplay_window): When computing centering_position,
3070 account for the height of the header line. (Bug#8874)
3072 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3073 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3074 candidate is selected by the mouse, and that candidate has a
3075 composed character under the mouse.
3077 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3078 coordinates reported by pos-visible-in-window-p for a composed
3079 character in column zero.
3081 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3083 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3085 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3087 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3088 consider it a hit if to_charpos is anywhere in the range of the
3089 composed buffer positions.
3091 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3093 * image.c (gif_load): Don't assume that each subimage has the same
3094 dimensions as the base image. Handle disposal method that is
3095 "undefined" by the gif spec (Bug#9335).
3097 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3099 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3100 (Fcondition_case): Document `debug' symbol in error handler.
3102 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3104 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3105 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3106 from an Org mode buffer to a Speedbar frame.
3108 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3109 a composition, take its buffer position from IT->cmp_it.charpos.
3110 Fixes cursor positioning at the beginning of a line that begins
3111 with a composed character.
3113 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3115 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3116 character bidirectional type, use STRONG_L instead. Fixes crashes
3117 in a buffer produced by `describe-categories'.
3119 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3120 members before the level stack, so they would be saved and
3121 restored when copying iterator state. Fixes incorrect reordering
3122 around TABs covered by display properties.
3124 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3126 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3128 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3130 * eval.c (internal_condition_case, internal_condition_case_1)
3131 (internal_condition_case_2, internal_condition_case_n):
3132 Remove unnecessary aborts (Bug#9081).
3134 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3136 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3137 has no `load' handler, try opening the file locally. (Bug#9311)
3139 2011-08-16 Ken Brown <kbrown@cornell.edu>
3141 * gmalloc.c: Expand comment.
3143 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3145 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3146 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3148 2011-08-16 Ken Brown <kbrown@cornell.edu>
3150 Fix memory allocation problems in Cygwin build (Bug#9273).
3152 * unexcw.c ( __malloc_initialized): Declare external variable.
3153 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3155 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3157 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3159 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3161 [CYGWIN] (special_realloc): New function.
3162 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3163 requests to realloc storage in the static heap.
3165 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3167 * bidi.c (bidi_initialize): Remove unused local.
3169 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3172 * biditype.h: Remove file.
3173 * makefile.w32-in ($(BLD)/bidi.$(O)):
3174 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3176 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3178 * chartab.c: Improve commentary for the uniprop_table API.
3180 * bidi.c (bidi_paragraph_init): Support zero value of
3181 bidi_ignore_explicit_marks_for_paragraph_level.
3182 (bidi_initialize): Use uniprop_table instead of including
3183 biditype.h and bidimirror.h.
3185 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3186 coordinates of the iterator when restoring from ppos_it.
3189 2011-08-14 Kenichi Handa <handa@m17n.org>
3191 * process.c (create_process): Call setup_process_coding_systems
3192 after the pid of the process is set to -1 (Bug#8162).
3194 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3196 * xdisp.c (move_it_in_display_line_to): Don't invoke
3197 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3198 ppos_it. Fixes vertical cursor motion when line beginning is
3199 covered by an image. (Bug#9296)
3201 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3203 * nsterm.h (ns_run_ascript): Declare.
3204 (NSAPP_DATA2_RUNASSCRIPT): Define.
3206 * nsfns.m (as_script, as_result, as_status): New static variables.
3207 (ns_run_ascript): New function.
3208 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3209 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3210 the event loop. Get status from as_status (Bug#7276).
3212 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3213 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3214 the event loop (Bug#7276).
3216 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3218 * gnutls.c (QCgnutls_bootprop_priority)
3219 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3220 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3221 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3222 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3223 (QCgnutls_bootprop_verify_hostname_error)
3224 (QCgnutls_bootprop_callbacks_verify): Rename from
3225 Qgnutls_bootprop_..., all uses changed.
3227 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3230 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3232 * xfaces.c (Qframe_set_background_mode): Now static.
3233 * dispextern.h (Qframe_set_background_mode): Remove decl.
3235 * process.c (Fnetwork_interface_info): Declare local only if needed.
3237 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3239 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3240 (Fnetwork_interface_list): Allocate in increments of bytes instead
3241 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3242 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3244 (struct ifflag_def): notrailers is smart on OSX.
3245 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3246 Get hardware address with getifaddrs if available.
3248 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3250 * xdisp.c (iterate_out_of_display_property): xassert that
3251 IT->position is set to within IT->object's boundaries. Break from
3252 the loop as soon as EOB is reached; avoids infloops in redisplay
3253 when IT->position is set up wrongly due to some bug.
3254 Set IT->current to match the bidi iterator unconditionally.
3255 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3256 entry. Force push_it to save on the stack the current
3257 buffer/string position, to be restored by pop_it. Fix flags in
3258 the iterator structure wrt the object coming from a display
3259 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3260 properties. (Bug#9284)
3262 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3264 * fontset.c (fontset_get_font_group): Add proper type checks.
3267 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3269 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3270 and LC_VERSION_MIN_MACOSX.
3271 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3272 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3274 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3276 * xdisp.c (forward_to_next_line_start): Allow to use the
3277 no-display-properties-and-no-overlays under bidi display.
3278 Set disp_pos in the bidi iterator to avoid searches for display
3279 properties and overlays.
3281 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3283 * editfns.c (Fset_time_zone_rule): Document relationship with the
3286 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3287 the font entity extracted from the cache (Bug#8109).
3289 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3291 * composite.c (autocmp_chars): Don't reset point. That is done by
3292 restore_point_unwind (Bug#5984).
3294 2011-08-07 Juri Linkov <juri@jurta.org>
3296 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3297 to show the arg `TIME' instead of `TIMEVAL'.
3299 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3301 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3302 display property strides EOL and includes a newline, as in
3303 longlines-mode. (Bug#9254)
3304 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3305 word-wrap under bidirectional display. (Bug#9224)
3307 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3308 is non-zero, even if the data buffer is NULL. Fixes a crash in
3309 vertical-motion with longlines-mode. (Bug#9254)
3311 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3313 * bidi.c <bidi_cache_total_alloc>: Now static.
3314 (bidi_initialize): Initialize bidi_cache_total_alloc.
3316 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3319 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3320 amount allocated this far in `bidi_cache_total_alloc'.
3321 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3322 non-zero, only free the data buffer without restoring the cache
3323 contents. All callers changed.
3325 * dispextern.h (bidi_unshelve_cache): Update prototype.
3327 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3328 (move_it_in_display_line, move_it_to)
3329 (move_it_vertically_backward, move_it_by_lines): Replace the call
3330 to xfree to an equivalent call to bidi_unshelve_cache.
3331 (move_it_in_display_line_to): Fix logic of returning
3332 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3334 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3336 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3337 came from a string character with a `cursor' property. (Bug#9229)
3339 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3341 * Makefile.in (LIB_PTHREAD): New variable.
3342 (LIBES): Add LIB_PTHREAD (Bug#9216).
3344 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3345 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3347 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3349 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3351 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3353 * xterm.c (x_find_topmost_parent): New function.
3354 (x_set_frame_alpha): Find topmost parent window with
3355 x_find_topmost_parent and set the property there also (bug#9181).
3356 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3358 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3360 * callproc.c (Fcall_process): Avoid vfork clobbering
3361 the local vars buffer, coding_systems, current_dir.
3363 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3365 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3367 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3369 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3370 so that it is not optimized away.
3372 * xdisp.c (compute_display_string_pos): Remove unused local.
3374 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3376 Fix slow cursor motion and scrolling in large buffers with
3377 selective display, like Org Mode buffers. (Bug#9218)
3379 * dispextern.h (struct bidi_it): New member disp_prop_p.
3381 * xdisp.c: Remove one-slot cache of display string positions.
3382 (compute_display_string_pos): Accept an additional argument
3383 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3384 for a display string or property. If found, set DISP_PROP_P
3387 * bidi.c (bidi_fetch_char): Accept an additional argument
3388 DISP_PROP_P, and pass it to compute_display_string_pos.
3389 Only handle text covered by a display string if DISP_PROP_P is returned
3390 non-zero. All callers of bidi_fetch_char changed.
3392 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3394 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3396 2010-12-03 Don March <don@ohspite.net>
3398 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3399 last character M-[char] is translated to ESC [char] (bug#7541).
3401 2011-08-02 Kenichi Handa <handa@m17n.org>
3403 * lisp.h (uniprop_table): Extern it.
3405 * chartab.c (uniprop_table): Make it non-static.
3407 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3409 * xdisp.c (forward_to_next_line_start): Accept additional argument
3410 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3412 (reseat_at_next_visible_line_start): Use the bidi iterator state
3413 returned by forward_to_next_line_start to restore the state of
3414 it->bidi_it after backing up to previous newline. (Bug#9212)
3416 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3418 * regex.c (re_comp): Protoize.
3419 (re_exec): Fix return type.
3420 (regexec): Fix type of `ret'. (Bug#9203)
3422 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3424 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3425 This is needed if max-image-size is a floating-point number.
3427 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3429 * print.c (print_object): Print empty symbol as ##.
3431 * lread.c (read1): Read ## as empty symbol.
3433 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3435 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3436 setting frame foreground color (Bug#9175).
3437 (x_set_background_color): Likewise.
3439 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3440 contents (Bug#9176).
3441 (EmacsTooltip -init): Remove bezels and add shadows to
3444 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3445 or scroll bar (Bug#8470).
3447 * nsfont.m (nsfont_open): Remove assignment to voffset and
3448 unnecessary vars hshink, expand, hd, full_height, min_height.
3449 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3451 * nsterm.h (nsfont_info): Remove voffset field.
3453 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3455 Implement strike-through and overline on NextStep (Bug#8863).
3457 * nsfont.m (nsfont_open): Use underline position provided by font,
3458 instead of hard-coded value of 2.
3459 (nsfont_draw): Call ns_draw_text_decoration instead.
3461 * nsterm.h: Add declaration for ns_draw_text_decoration.
3463 * nsterm.m (ns_draw_text_decoration): New function for drawing
3464 underline, overline, and strike-through.
3465 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3466 ns_draw_text_decoration. Change treatment of cursor drawing to
3467 accommodate underlining, etc.
3469 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3471 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3474 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3476 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3477 Without this fix, if a signal arrives just after memory fills up,
3478 'malloc' might be invoked reentrantly.
3480 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3481 In other words, assume that every image size is allowed, on non-X
3482 hosts. This assumption is probably wrong, but it lets Emacs compile.
3484 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3486 * regex.c (re_iswctype): Convert return values to boolean.
3488 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3490 * xdisp.c (compute_display_string_pos): Don't use cached display
3491 string position if the buffer had its restriction changed.
3494 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3496 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3498 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3500 Integer signedness and overflow and related fixes. (Bug#9079)
3502 * bidi.c: Integer size and overflow fixes.
3503 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3504 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3505 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3506 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3507 (bidi_find_other_level_edge):
3508 Use ptrdiff_t instead of EMACS_INT where either will do.
3509 This works better on 32-bit hosts configured --with-wide-int.
3510 (bidi_cache_ensure_space): Check for size-calculation overflow.
3511 Use % rather than repeated addition, for better worst-case speed.
3512 Don't set bidi_cache_size until after xrealloc returns, because it
3514 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3515 (bidi_cache_ensure_space): Also check that the bidi cache size
3516 does not exceed that of the largest Lisp string or buffer. See Eli
3517 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3519 * alloc.c (__malloc_size_t): Remove.
3520 All uses replaced by size_t. See Andreas Schwab's note
3521 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3523 * image.c: Improve checking for integer overflow.
3524 (check_image_size): Assume that f is nonnull, since
3525 it is always nonnull in practice. This is one less thing to
3526 worry about when checking for integer overflow later.
3527 (x_check_image_size): New function, which checks for integer
3528 overflow issues inside X.
3529 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3530 This removes the need for a memory_full check.
3531 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3532 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3533 (xbm_read_bitmap_data): Change locals back to 'int', since
3534 their values must fit in 'int'.
3535 (xpm_load_image, png_load, tiff_load):
3536 Invoke x_create_x_image_and_pixmap earlier,
3537 to avoid much needless work if the image is too large.
3538 (tiff_load): Treat overly large images as if
3539 x_create_x_image_and_pixmap failed, not as malloc failures.
3540 (gs_load): Use x_check_image_size.
3542 * gtkutil.c: Omit integer casts.
3543 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3544 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3546 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3548 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3549 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3550 would wrongly return t on a 64-bit host.
3552 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3553 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3554 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3555 and therefore cause GCC to emit a bogus diagnostic in some cases.
3557 * image.c: Integer signedness and overflow and related fixes.
3558 This is not an exhaustive set of fixes, but it's time to
3559 record what I've got.
3560 (lookup_pixel_color, check_image_size): Remove redundant decls.
3561 (check_image_size): Don't assume that arbitrary EMACS_INT values
3562 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3563 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3564 (tiff_load, imagemagick_load_image):
3565 Check for overflow in size calculations.
3566 (x_create_x_image_and_pixmap): Remove unnecessary test for
3567 xmalloc returning NULL; that can't happen.
3568 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3569 (xpm_color_bucket): Use better integer hashing function.
3570 (xpm_cache_color): Don't possibly over-allocate memory.
3571 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3572 (gif_memory_source):
3573 Use ptrdiff_t, not int or size_t, to record sizes.
3574 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3575 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3576 either works, as we prefer signed integers.
3577 (tiff_read_from_memory, tiff_write_from_memory):
3578 Return tsize_t, not size_t, since that's what the TIFF API wants.
3579 (tiff_read_from_memory): Don't fail simply because the read would
3580 go past EOF; instead, return a short read.
3581 (tiff_load): Omit no-longer-needed casts.
3582 (Fimagemagick_types): Don't assume size fits into 'int'.
3584 Improve hashing quality when configured --with-wide-int.
3585 * fns.c (hash_string): New function, taken from sxhash_string.
3586 Do not discard information about ASCII character case; this
3587 discarding is no longer needed.
3588 (sxhash-string): Use it. Change sig to match it. Caller changed.
3589 * lisp.h: Declare it.
3590 * lread.c (hash_string): Remove, since we now use fns.c's version.
3591 The fns.c version returns a wider integer if --with-wide-int is
3592 specified, so this should help the quality of the hashing a bit.
3594 * emacs.c: Integer overflow minor fix.
3595 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3596 Define only if GNU_LINUX.
3597 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3599 * dispnew.c: Integer signedness and overflow fixes.
3600 Remove unnecessary forward decls, that were a maintenance hassle.
3601 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3603 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3604 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3605 (prepare_desired_row, line_draw_cost):
3606 Use int, not unsigned, where either works.
3607 (save_current_matrix, restore_current_matrix):
3608 Use ptrdiff_t, not size_t, where either works.
3609 (init_display): Check for overflow more accurately, and without
3610 relying on undefined behavior.
3612 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3613 Remove, replacing with the new symbols in lisp.h. All uses changed.
3614 * fileio.c (make_temp_name):
3615 * filelock.c (lock_file_1, lock_file):
3616 * xdisp.c (message_dolog):
3617 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3618 Use pMd etc. instead.
3619 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3620 replacing the pWIDE etc. symbols removed from editfns.c.
3622 * keyboard.h (num_input_events): Now uintmax_t.
3623 This is (very slightly) less likely to mess up due to wraparound.
3626 * buffer.c: Integer signedness fixes.
3627 (alloc_buffer_text, enlarge_buffer_text):
3628 Use ptrdiff_t rather than size_t when either will do, as we prefer
3631 * alloc.c: Integer signedness and overflow fixes.
3632 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3633 (__malloc_size_t): Default to size_t, not to int.
3634 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3635 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3636 Prefer ptrdiff_t to size_t when either would do, as we prefer
3638 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3639 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3640 Now const. Initialize with values that are in range even if char
3642 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3643 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3644 These functions do the right thing with sizes > 2**32.
3645 (check_depth): Now ptrdiff_t, not int.
3646 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3647 Adjust to new way of storing sizes. Check for size overflow bugs
3649 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3650 slightly wrong anyway, as it missed one instance of
3651 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3652 (refill_memory_reserve): Omit needless cast to size_t.
3653 (mark_object_loop_halt): Mark as externally visible.
3655 * xselect.c: Integer signedness and overflow fixes.
3656 (Fx_register_dnd_atom, x_handle_dnd_message):
3657 Use ptrdiff_t, not size_t, since we prefer signed.
3658 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3659 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3660 x_dnd_atoms_size and x_dnd_atoms_length.
3662 * doprnt.c: Prefer signed to unsigned when either works.
3664 * doprnt.c (doprnt):
3666 * xdisp.c (vmessage):
3667 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3668 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3669 prefer signed arithmetic to avoid comparison confusion.
3670 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3671 but is a bit tricky.
3673 Assume freestanding C89 headers, string.h, stdlib.h.
3674 * data.c, doprnt.c, floatfns.c, print.c:
3675 Include float.h unconditionally.
3676 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3677 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3678 * regex.c: Likewise for stddef.h, string.h.
3679 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3680 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3681 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3682 (STDC_HEADERS): Remove obsolete defines.
3683 * sysdep.c: Include limits.h unconditionally.
3685 Assume support for memcmp, memcpy, memmove, memset.
3686 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3687 * regex.c (memcmp, memcpy):
3688 Remove; we assume C89 now.
3690 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3691 (__malloc_safe_bcopy): Remove; no longer needed.
3693 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3694 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3695 well either way, and we prefer signed to unsigned.
3697 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3699 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3700 closes the connection while we're reading (bug#9182).
3702 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3704 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3705 are specified (Bug#9168).
3707 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3709 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3710 Found by GCC static checking and --with-wide-int on a 32-bit host.
3712 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3714 * xdisp.c (compute_display_string_pos): Fix logic of caching
3715 previous display string position. Initialize cached_prev_pos to
3716 -1. Fixes slow-down at the beginning of a buffer.
3718 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3720 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3721 for attrs[LFACE_FONTSET_INDEX].
3723 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3725 * xml.c (parse_region): Remove unused local
3726 that was recently introduced.
3728 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3730 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3731 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3733 * xdisp.c (move_it_in_display_line_to): Record the best matching
3734 position for TO_CHARPOS while scanning the line, and restore it on
3735 exit if none of the characters scanned was an exact match.
3736 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3737 when exact match is impossible due to invisible text, and the
3738 lines are truncated.
3740 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3742 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3745 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3747 Fix a significant slow-down of cursor motion with C-n, C-p,
3748 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3749 auto-repeat under bidi redisplay in fontified buffers.
3750 * xdisp.c (compute_stop_pos_backwards): New function.
3751 (next_element_from_buffer): Call compute_stop_pos_backwards to
3752 find a suitable prev_stop when we find ourselves before
3754 (reseat): Don't look for prev_stop, as that could mean a very long
3756 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3757 <cached_disp_overlay_modiff>: Cache for last found display string
3759 (compute_display_string_pos): Return the cached position if asked
3760 about the same buffer in the same area of character positions, and
3761 the buffer wasn't changed since the time the display string
3762 position was cached.
3764 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3766 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3767 is an integer, which is important for empty lines. (Bug#9149)
3769 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3771 * frame.c (Fmodify_frame_parameters): In tty case, update the
3772 default face if necessary (Bug#4238).
3774 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3776 * editfns.c (Fstring_to_char): No need to explain what a character
3777 is in the docstring (Bug#6576).
3779 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3781 * xml.c (parse_region): Make sure we always return a tree.
3783 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3785 * xml.c (parse_region): If a document contains only comments,
3788 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3790 * xml.c (make_dom): Return comments, too.
3792 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3795 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3796 and the surrounding thread.
3797 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3798 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3799 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3801 * s/openbsd.h (BROKEN_SIGIO): Define.
3802 * unexelf.c (unexec) [__OpenBSD__]:
3803 Don't update the .mdebug section of the Alpha COFF symbol table.
3805 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3807 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3810 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3812 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3813 This fixes some race conditions on the permissions of any newly
3816 * alloc.c (valid_pointer_p): Use pipe, not open.
3817 This fixes some permissions issues when debugging.
3819 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3820 If fchown fails to set both uid and gid, try to set just gid,
3821 as that is sometimes allowed. Adjust the file's mode to eliminate
3822 setuid or setgid bits that are inappropriate if fchown fails.
3824 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3826 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3827 to compare Lisp_Objects.
3828 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3829 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3830 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3832 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3834 * lread.c (read_integer): Unread even EOF character.
3835 (read1): Likewise. Properly record start position of symbol.
3837 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3838 symbol character follows.
3840 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3842 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3843 This works around a problem with the previous change to Fcopy_file.
3844 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3845 and without this change, GCC might complain about discarding
3846 fchown's return value.
3848 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3850 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3852 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3854 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3856 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3858 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3859 it's used from the C level.
3861 * process.c: Use the same condition for POLL_FOR_INPUT in both
3862 keyboard.c and process.c (bug#1858).
3864 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3866 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3867 (Fgnutls_boot): Use it.
3869 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3871 * doc.c (Fsubstitute_command_keys): Revert last change.
3873 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3875 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3876 quotes the next character, and doesn't affect other longer
3877 sequences (bug#8935).
3879 * lread.c (syms_of_lread): Clarify that is isn't only
3880 `eval-buffer' and `eval-defun' that's affected by
3881 `lexical-binding' (bug#8460).
3883 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3885 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3886 bidi redisplay when a line includes both an image and is truncated.
3888 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3890 Fix minor problems found by static checking.
3891 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3892 (elsz): Now a signed constant, not a size_t var. We prefer signed
3893 types to unsigned, to avoid integer comparison confusion. Without
3894 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3895 "cannot optimize loop, the loop counter may overflow", a symptom
3897 * indent.c (Fvertical_motion): Mark locals as initialized.
3898 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3900 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3902 * search.c (Fre_search_backward): Mention `case-fold-search' in
3903 all the re_search_* functions (bug#8138).
3905 * keyboard.c (Fopen_dribble_file): Document when the file is
3908 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3910 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3913 Support bidi reordering of display and overlay strings.
3914 * xdisp.c (compute_display_string_pos)
3915 (compute_display_string_end): Accept additional argument STRING.
3916 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3917 (reseat_to_string): Initialize bidi_it->string.s and
3918 bidi_it->string.schars.
3919 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3920 NULL (avoids a crash in bidi_paragraph_init).
3921 Initialize itb.string.lstring.
3922 (init_iterator): Call bidi_init_it only of a valid
3923 buffer position was specified. Initialize paragraph_embedding to
3925 (reseat_to_string): Initialize the bidi iterator.
3926 (display_string): If we need to ignore text properties of
3927 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3928 original value of -1 will not work with bidi.)
3929 (compute_display_string_pos): First arg is now struct
3930 `text_pos *'; all callers changed. Support display properties on
3932 (compute_display_string_end): Support display properties on Lisp
3934 (init_iterator, reseat_1, reseat_to_string): Initialize the
3935 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3936 when iterating on a string not from display properties).
3937 (compute_display_string_pos, compute_display_string_end):
3938 Fix calculation of the object to scan. Fixes an error when using
3940 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3941 base_level_stop; instead, set base_level_stop to BEGV.
3942 Fixes crashes in vertical-motion.
3943 (next_element_from_buffer): Improve commentary for when
3944 the iterator is before prev_stop.
3945 (init_iterator): Initialize bidi_p from the default value of
3946 bidi-display-reordering, not from buffer-local value. Use the
3947 buffer-local value only if initializing for buffer iteration.
3948 (handle_invisible_prop): Support invisible properties on strings
3949 that are being bidi-reordered.
3950 (set_iterator_to_next): Support bidi reordering of C strings and
3952 (next_element_from_string): Support bidi reordering of Lisp
3954 (handle_stop_backwards): Support Lisp strings as well.
3955 (display_string): Support display of R2L glyph rows.
3956 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3957 (init_iterator): Don't initialize it->bidi_p for strings
3959 (reseat_to_string): Initialize it->bidi_p for strings here.
3960 (next_element_from_string, next_element_from_c_string)
3961 (next_element_from_buffer): Add xassert's for correspondence
3962 between IT's object being iterated and it->bidi_it.string
3964 (face_before_or_after_it_pos): Support bidi iteration.
3965 (next_element_from_c_string): Handle the case of the first string
3966 character that is not the first one in the visual order.
3967 (get_visually_first_element): New function, refactored from common
3968 parts of next_element_from_buffer, next_element_from_string, and
3969 next_element_from_c_string.
3970 (tool_bar_lines_needed, redisplay_tool_bar)
3971 (display_menu_bar): Force left-to-right direction. Add a FIXME
3972 comment for making that be controlled by a user option.
3973 (push_it, pop_it): Save and restore the state of the
3974 bidi iterator. Save and restore the bidi_p flag.
3975 (pop_it): Iterate out of display property for string iteration as
3977 (iterate_out_of_display_property): Support iteration over strings.
3978 (handle_single_display_spec): Set up it->bidi_it for iteration
3979 over a display string, and call bidi_init_it.
3980 (handle_single_display_spec, next_overlay_string)
3981 (get_overlay_strings_1, push_display_prop): Set up the bidi
3982 iterator for displaying display or overlay strings.
3983 (forward_to_next_line_start): Don't use the shortcut if
3985 (back_to_previous_visible_line_start): If handle_display_prop
3986 pushed the iterator stack, restore the internal state of the bidi
3987 iterator by calling bidi_pop_it same number of times.
3988 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3989 and we are bidi-iterating, don't decrement the iterator position;
3990 instead, set the first_elt flag in the bidi iterator, to produce
3992 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3993 (push_display_prop): xassert that we are iterating a buffer.
3994 (push_it, pop_it): Save and restore paragraph_embedding member.
3995 (handle_single_display_spec, next_overlay_string)
3996 (get_overlay_strings_1, reseat_1, reseat_to_string)
3997 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3998 correctly. Don't assume unibyte strings are not bidi-reordered.
3999 (compute_display_string_pos)
4000 (compute_display_string_end): Fix handling the case of C string.
4001 (push_it, pop_it): Save and restore from_disp_prop_p.
4002 (handle_single_display_spec, push_display_prop): Set the
4003 from_disp_prop_p flag.
4004 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4005 (pop_it): Call iterate_out_of_display_property only if we are
4006 popping after iteration over a string that came from a display
4007 property. Fix a typo in popping stretch info. Add an assertion
4008 for verifying that the iterator position is in sync with the bidi
4010 (handle_single_display_spec, get_overlay_strings_1)
4011 (push_display_prop): Fix initialization of paragraph direction for
4012 string when that of the parent object is not yet determined.
4013 (reseat_1): Call bidi_init_it to resync the bidi
4014 iterator with IT's position. (Bug#7616)
4015 (find_row_edges): If ROW->start.pos gives position
4016 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4017 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4018 Reset the from_disp_prop_p flag.
4019 (SAVE_IT, RESTORE_IT): New macros.
4020 (pos_visible_p, face_before_or_after_it_pos)
4021 (back_to_previous_visible_line_start)
4022 (move_it_in_display_line_to, move_it_in_display_line)
4023 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4024 (try_scrolling, redisplay_window, display_line): Use them when
4025 saving a temporary copy of the iterator and restoring it back.
4026 (back_to_previous_visible_line_start, reseat_1)
4027 (init_iterator): Empty the bidi cache "stack".
4028 (move_it_in_display_line_to): If iterator ended up at
4029 EOL, but we never saw any buffer positions smaller than
4030 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4031 motion in bidi-reordered lines.
4032 (move_it_in_display_line_to): Record prev_method and prev_pos
4033 immediately before the call to set_iterator_to_next. Fixes cursor
4034 motion in bidi-reordered lines with stretch glyphs and strings
4035 displayed in margins. (Bug#8133) (Bug#8867)
4036 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4038 (pos_visible_p): Support positions in bidi-reordered lines.
4039 Save and restore bidi cache.
4041 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4042 (bidi_paragraph_info): Delete unused struct.
4043 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4044 (bidi_cache_start): New variable.
4045 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4047 (bidi_cache_fetch_state, bidi_cache_search)
4048 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4049 (bidi_cache_find, bidi_peek_at_next_level)
4050 (bidi_level_of_next_char, bidi_find_other_level_edge)
4051 (bidi_move_to_visually_next): Compare cache index with
4052 bidi_cache_start rather than with zero.
4053 (bidi_fetch_char): Accept new argument STRING; all callers
4054 changed. Support iteration over a string. Support strings with
4055 display properties. Support unibyte strings. Fix the type of
4056 `len' according to what STRING_CHAR_AND_LENGTH expects.
4057 (bidi_paragraph_init, bidi_resolve_explicit_1)
4058 (bidi_resolve_explicit, bidi_resolve_weak)
4059 (bidi_level_of_next_char, bidi_move_to_visually_next):
4060 Support iteration over a string.
4061 (bidi_set_sor_type, bidi_resolve_explicit_1)
4062 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4063 can now be zero (for strings); special values 0 and -1 were
4064 changed to -1 and -2, respectively.
4065 (bidi_char_at_pos): New function.
4066 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4067 Call it instead of FETCH_MULTIBYTE_CHAR.
4068 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4069 initialized to valid values.
4070 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4072 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4073 the test for valid cached positions. Fix the logic for looking up
4074 the sentinel state in the cache. GCPRO the Lisp string we are
4076 (bidi_push_it, bidi_pop_it): New functions.
4077 (bidi_initialize): Initialize the bidi cache start stack pointer.
4078 (bidi_cache_ensure_space): New function, refactored from part of
4079 bidi_cache_iterator_state. Don't assume the required size is just
4080 one BIDI_CACHE_CHUNK away.
4081 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4082 (bidi_count_bytes, bidi_char_at_pos): New functions.
4083 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4084 always valid if bidi_cache_idx is valid.
4085 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4086 is valid if it's going to be used.
4087 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4088 (bidi_cache_fetch_state, bidi_cache_search)
4089 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4090 (bidi_cache_iterator_state, bidi_cache_find)
4091 (bidi_find_other_level_edge, bidi_cache_start_stack):
4092 All variables related to cache indices are now EMACS_INT.
4094 * dispextern.h (struct bidi_string_data): New structure.
4095 (struct bidi_it): New member `string'. Make flag members be 1-bit
4096 fields, and put them last in the struct.
4097 (compute_display_string_pos, compute_display_string_end):
4099 (bidi_push_it, bidi_pop_it): Add prototypes.
4100 (struct iterator_stack_entry): New members bidi_p,
4101 paragraph_embedding, and from_disp_prop_p.
4102 (struct it): Member bidi_p is now a bit field 1 bit wide.
4103 (bidi_shelve_cache, bidi_unshelve_cache):
4106 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4107 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4108 and vector-like objects.
4110 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4111 cache around display iteration.
4113 * window.c (Fwindow_end, window_scroll_pixel_based)
4114 (displayed_window_lines, Frecenter): Save and restore the bidi
4115 cache around display iteration.
4117 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4119 * editfns.c (Fdelete_region): Clarify the use of the named
4120 parameters (bug#6788).
4122 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4124 * indent.c (Fvertical_motion): Set and restore w->pointm when
4125 saving and restoring the window's buffer (Bug#9006).
4127 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4129 * editfns.c (Fstring_to_char): Clarify just what is returned
4130 (bug#6576). Text by Eli Zaretskii.
4132 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4134 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4136 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4138 * buffer.c (mmap_find): Fix a typo.
4140 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4142 Fix execution of x selection hooks.
4143 * xselect.c (Qx_lost_selection_functions)
4144 (Qx_sent_selection_functions): New vars.
4145 (syms_of_xselect): DEFSYM them.
4146 (x_handle_selection_request): Pass Qx_sent_selection_functions
4147 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4148 (x_handle_selection_clear,x_clear_frame_selections):
4149 Pass Qx_lost_selection_functions rather than
4150 Vx_lost_selection_functions to Frun_hook_with_args.
4152 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4154 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4155 The old code sometimes used this field without initializing it.
4157 * alloc.c (gc_sweep): Don't read past end of array.
4158 In theory, the old code could also have corrupted Emacs internals,
4159 though it'd be very unlikely.
4161 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4163 * character.c (Fcharacterp): Don't advertise optional ignored
4164 argument. (Bug#4026)
4166 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4168 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4171 * window.c (Fset_window_start): Doc fix (bug#4199).
4172 (Fset_window_hscroll): Ditto.
4174 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4176 Fix minor new problems caught by GCC 4.6.1.
4177 * term.c (init_tty): Remove unused local.
4178 * xsettings.c (store_monospaced_changed): Define this function only
4179 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4182 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4184 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4186 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4188 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4189 are the mini-buffer and the echo area (bug#3320).
4191 * term.c (init_tty): Remove support for supdup, c10 and perq
4192 terminals, which are no longer supported (bug#1482).
4194 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4196 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4198 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4200 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4201 for non-popups (Bug#3642).
4203 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4205 * alloc.c (reset_malloc_hooks): Protoize.
4206 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4207 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4208 * cm.c (losecursor): Likewise.
4209 * data.c (fmod): Likewise.
4210 * dispnew.c (swap_glyphs_in_rows): Likewise.
4211 * emacs.c (memory_warning_signal): Likewise.
4212 * floatfns.c (float_error): Likewise.
4213 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4214 (otf_open, font_otf_capability, generate_otf_features)
4215 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4217 * image.c (pbm_read_file): Likewise.
4218 * indent.c (string_display_width): Likewise.
4219 * intervals.c (check_for_interval, search_for_interval)
4220 (inc_interval_count, count_intervals, root_interval)
4221 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4222 * lread.c (defalias): Likewise.
4223 * ralloc.c (r_alloc_check): Likewise.
4224 * regex.c (set_image_of_range_1, set_image_of_range)
4225 (regex_grow_registers): Likewise.
4226 * sysdep.c (strerror): Likewise.
4227 * termcap.c (valid_filename_p, tprint, main): Likewise.
4228 * tparam.c (main): Likewise.
4229 * unexhp9k800.c (run_time_remap, save_data_space)
4230 (update_file_ptrs, read_header, write_header, calculate_checksum)
4231 (copy_file, copy_rest, display_header): Likewise.
4232 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4234 * xdisp.c (check_it): Likewise.
4235 * xfaces.c (register_color, unregister_color, unregister_colors):
4237 * xfns.c (print_fontset_result): Likewise.
4238 * xrdb.c (member, fatal, main): Likewise.
4240 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4242 Fix minor problems found by static checking (Bug#9031).
4243 * chartab.c (char_table_set_range, map_sub_char_table):
4244 Remove unused locals.
4245 (uniprop_table): Now static.
4246 * composite.c (_work_char): Remove unused static var.
4248 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4250 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4252 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4254 * gtkutil.c (qttip_cb): Remove code without function.
4256 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4258 * w32.c (pthread_sigmask): New stub.
4260 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4262 Use pthread_sigmask, not sigprocmask (Bug#9010).
4263 sigprocmask is portable only for single-threaded applications, and
4264 Emacs can be multi-threaded when it uses GTK.
4265 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4267 * callproc.c (Fcall_process):
4268 * process.c (create_process):
4269 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4270 Use pthread_sigmask, not sigprocmask.
4272 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4274 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4275 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4278 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4280 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4281 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4282 (xg_hide_tooltip): Fix comment.
4284 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4285 in registerServicesMenuSendTypes.
4286 (validRequestorForSendType): Don't check ns_return_types.
4288 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4291 2011-07-08 Jason Rumney <jasonr@gnu.org>
4293 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4294 SH_SHOW for hidden windows (Bug#5482).
4296 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4297 frame struct members of non-existent frames (Bug#6284).
4299 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4301 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4302 variable firstTime not needed on OSX >= 10.6.
4303 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4304 >= 10.5. Use setKnobProportion, setDoubleValue.
4306 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4307 (MAC_OS_X_VERSION_10_5): Define if not defined.
4308 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4309 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4310 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4312 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4313 cString and lossyCString on OSX >= 10.4
4315 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4316 sizeToFit on OSX >= 10.2.
4318 * nsimage.m (allocInitFromFile): Don't use deprecated method
4319 bestRepresentationForDevice on OSX >= 10.6.
4321 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4324 * emacs.c: Declare unexec_init_emacs_zone.
4326 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4328 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4330 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4331 on svcsMenu (Bug#8842).
4333 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4335 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4337 * nsterm.m (QUTF8_STRING): Declare.
4338 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4339 (validRequestorForSendType): Return type is (id).
4340 Change indexOfObjectIdenticalTo to indexOfObject.
4341 Check if we have local selection before returning self (Bug#8842).
4342 (writeSelectionToPasteboard): Put local selection into paste board
4343 if we have a local selection (Bug#8842).
4344 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4346 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4347 (ns_get_local_selection): Declare.
4349 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4351 * keymap.c (describe_map_tree): Don't insert a double newline at
4352 the end of the buffer (bug#1169) and return whether we inserted
4355 * callint.c (Fcall_interactively): Change "reading args" to
4356 "providing args" to try to clarify what it does (bug#1010).
4358 2011-07-07 Kenichi Handa <handa@m17n.org>
4360 * composite.c (composition_compute_stop_pos): Ignore a static
4361 composition starting before CHARPOS (Bug#8915).
4363 * xdisp.c (handle_composition_prop): Likewise.
4365 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4367 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4370 2011-07-07 Kenichi Handa <handa@m17n.org>
4372 * character.h (unicode_category_t): New enum type.
4374 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4375 (Qchar_code_property_table): New variable.
4376 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4377 (UNIPROP_COMPRESSED_FORM_P): New macros.
4378 (char_table_ascii): Uncompress the compressed values.
4379 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4380 Uncompress the compressed values.
4381 (sub_char_table_ref_and_range): Likewise.
4382 (char_table_ref_and_range): Uncompress the compressed values.
4383 (sub_char_table_set): New arg is_uniprop. Callers changed.
4384 Uncompress the compressed values.
4385 (sub_char_table_set_range): Args changed. Callers changed.
4386 (char_table_set_range): Adjuted for the above change.
4387 (map_sub_char_table): Delete args default_val and parent. Add arg
4388 top. Give decoded values to a Lisp function.
4389 (map_char_table): Adjust for the above change. Give decoded
4390 values to a Lisp function. Gcpro more variables.
4391 (uniprop_table_uncompress)
4392 (uniprop_decode_value_run_length): New functions.
4393 (uniprop_decoder, uniprop_decoder_count): New variables.
4394 (uniprop_get_decoder, uniprop_encode_value_character)
4395 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4397 (uniprop_encoder, uniprop_encoder_count): New variables.
4398 (uniprop_get_encoder, uniprop_table)
4399 (Funicode_property_table_internal, Fget_unicode_property_internal)
4400 (Fput_unicode_property_internal): New functions.
4401 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4402 Sunicode_property_table_internal, Sget_unicode_property_internal,
4403 and Sput_unicode_property_internal. Defvar_lisp
4404 char-code-property-alist.
4406 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4407 Vunicode_category_table.
4409 * font.c (font_range): Adjust for the change of
4410 Vunicode_category_table.
4412 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4414 * m/iris4d.h: Remove file, move contents ...
4415 * s/irix6-5.h: ... here.
4417 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4419 Remove unportable assumption about struct layout (Bug#8884).
4420 * alloc.c (mark_buffer):
4421 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4422 (clone_per_buffer_values): Don't assume that
4423 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4424 This isn't true in general, and it's particularly not true
4425 if Emacs is configured with --with-wide-int.
4426 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4427 New macros, used in the buffer.c change.
4429 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4431 * xsettings.c: Use both GConf and GSettings if both are available.
4432 (store_config_changed_event): Add comment.
4433 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4434 (store_tool_bar_style_changed): New functions.
4435 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4436 (struct xsettings): Move font inside HAVE_XFT.
4437 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4438 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4439 Move inside HAVE_XFT.
4440 (something_changed_gsettingsCB): Rename from something_changedCB.
4441 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4443 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4444 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4445 (something_changed_gconfCB): Rename from something_changedCB.
4446 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4447 (parse_settings): Move check for font inside HAVE_XFT.
4448 (read_settings, apply_xft_settings): Add comment.
4449 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4450 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4451 call store_font_name_changed.
4452 (xft_settings_event): Add comment.
4453 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4454 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4455 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4456 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4457 (xsettings_initialize): Call init_gsettings last.
4458 (xsettings_get_system_font, xsettings_get_system_normal_font):
4461 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4463 Random fixes. E.g., (random) never returned negative values.
4464 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4465 subseconds part to the entropy, as that's a bit more random.
4466 Prefer signed to unsigned, since the signedness doesn't matter and
4467 in general we prefer signed. When given a limit, use a
4468 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4469 latter isn't right if USE_2_TAGS_FOR_INTS.
4470 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4471 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4473 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4475 * textprop.c (text_property_stickiness):
4476 Obey Vtext_property_default_nonsticky.
4477 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4478 * w32fns.c (syms_of_w32fns):
4479 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4481 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4483 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4484 This is more efficient than Ffile_directory_p and avoids a minor race.
4486 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4488 * buffer.c (Foverlay_put): Say what the return value is
4491 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4492 is a directory before asking whether to use the file name
4494 (barf_or_query_if_file_exists): Make the "File is a directory"
4495 error be more correct.
4497 * fns.c (Frequire): Remove the mention of the .gz files, since
4498 that's installation-specific, but keep the mention of
4499 `get-load-suffixes'.
4501 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4503 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4504 Report string overflow if the output is too long.
4506 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4508 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4509 (syms_of_gnutls): Remove duplicate DEFSYM for
4510 Qgnutls_bootprop_verify_hostname_error, an error for
4511 Qgnutls_bootprop_verify_error (which is no longer used).
4513 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4514 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4515 Also (re)move comments that are misplaced or no longer relevant.
4517 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4519 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4521 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4523 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4524 and background color parameters if they have been changed.
4526 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4528 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4530 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4532 * xsettings.c (SYSTEM_FONT): Define only when used.
4533 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4535 * keymap.c (access_keymap_1): Now static.
4537 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4539 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4540 leave any prefix arg for the up event (Bug#1586).
4542 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4544 * lread.c (syms_of_lread): Mention single symbols defined by
4545 `defvar' or `defconst' (bug#7154).
4547 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4548 (Frequire): Mention get-load-suffixes.
4550 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4552 * window.h (window): Remove clone_number slot.
4553 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4555 (make_parent_window, make_window, saved_window)
4556 (Fset_window_configuration, save_window_save): Don't deal with
4558 * buffer.c (Qclone_number): Remove declaration.
4559 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4561 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4563 Add multiple inheritance to keymaps.
4564 * keymap.c (Fmake_composed_keymap): New function.
4565 (Fset_keymap_parent): Simplify.
4566 (fix_submap_inheritance): Remove.
4567 (access_keymap_1): New function extracted from access_keymap to handle
4568 embedded parents and handle lists of maps.
4569 (access_keymap): Use it.
4570 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4571 (Fcopy_keymap): Handle embedded parents.
4572 (Fcommand_remapping, define_as_prefix): Simplify.
4573 (Fkey_binding): Simplify.
4574 (syms_of_keymap): Move minibuffer-local-completion-map,
4575 minibuffer-local-filename-completion-map,
4576 minibuffer-local-must-match-map, and
4577 minibuffer-local-filename-must-match-map to Elisp.
4578 (syms_of_keymap): Defsubr make-composed-keymap.
4579 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4580 (parse_menu_item): Trivial simplification.
4582 2011-07-01 Glenn Morris <rgm@gnu.org>
4584 * Makefile.in (SETTINGS_LIBS): Fix typo.
4586 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4588 * coding.c (Fencode_coding_string): Record the last coding system
4589 used, as the function doc string says (bug#8738).
4591 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4593 * xsettings.c (store_monospaced_changed): Take new font as arg and
4594 check for change against current_mono_font.
4595 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4596 (emacs_settings_constructor, emacs_settings_get_property)
4597 (emacs_settings_set_property, emacs_settings_class_init)
4598 (emacs_settings_init, gsettings_obj): Remove.
4599 (something_changedCB): New function for HAVE_GSETTINGS.
4600 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4601 with value as argument.
4602 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4603 g_settings_new (Bug#8967). Do not create gsettings_obj.
4604 Remove calls to g_settings_bind. Connect something_changedCB to
4607 * xgselect.c: Add defined (HAVE_GSETTINGS).
4608 (xgselect_initialize): Ditto.
4610 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4611 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4614 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4616 * eval.c (struct backtrace): Simplify and port the data structure.
4617 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4618 signed bit field, as this assumption is not portable and it makes
4619 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4620 "char debug_on_exit : 1" as this is not portable either; instead,
4621 use the portable "unsigned int debug_on_exit : 1". Remove unused
4622 member evalargs. Remove obsolete comments about cc bombing out.
4624 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4626 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4627 Let HAVE_GSETTINGS override HAVE_GCONF.
4628 (store_monospaced_changed): New function.
4629 (EMACS_SETTINGS): A new type derived from GObject to handle
4630 GSettings notifications.
4631 (emacs_settings_constructor, emacs_settings_get_property)
4632 (emacs_settings_set_property, emacs_settings_class_init):
4634 (gsettings_client, gsettings_obj): New variables.
4635 (GSETTINGS_SCHEMA): New define.
4636 (something_changedCB): Call store_monospaced_changed.
4637 (init_gsettings): New function.
4638 (xsettings_initialize): Call init_gsettings.
4639 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4642 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4645 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4647 * window.c (resize_root_window, grow_mini_window)
4648 (shrink_mini_window): Rename Qresize_root_window to
4649 Qwindow_resize_root_window and Qresize_root_window_vertically to
4650 Qwindow_resize_root_window_vertically.
4652 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4654 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4656 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4658 * makefile.w32-in: Redesign dependencies so they reflect more
4659 clearly which files are directly included by each source file,
4660 and not through other includes.
4662 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4664 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4665 (sort_overlays, overlay_strings): When an overlay's clone number
4666 matches the window's clone number process the overlay even if
4667 the overlay's window property doesn't match the current window.
4669 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4670 (Fwindow_hchild): Rename to Fwindow_left_child.
4671 (Fwindow_next): Rename to Fwindow_next_sibling.
4672 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4673 (resize_window_check): Rename to window_resize_check.
4674 (resize_window_apply): Rename to window_resize_apply.
4675 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4676 (Fdelete_other_windows_internal, resize_frame_windows)
4677 (Fsplit_window_internal, Fdelete_window_internal)
4678 (grow_mini_window, shrink_mini_window)
4679 (Fresize_mini_window_internal): Fix callers accordingly.
4681 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4683 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4684 (emacs_fixed_set_min_size): Remove.
4685 (emacs_fixed_new): Take frame as argument.
4687 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4688 (_EmacsFixedPrivate): Remove minwidth/height.
4689 Add struct frame *f.
4690 (emacs_fixed_init): Initialize priv->f.
4691 (get_parent_class, emacs_fixed_set_min_size): Remove.
4692 (emacs_fixed_new): Set priv->f to argument.
4693 (emacs_fixed_get_preferred_width)
4694 (emacs_fixed_get_preferred_height): Use min_width/height from
4695 frames size_hint to set minimum and natural (Bug#8919).
4696 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4697 and use min_width/height from frames size_hint to set
4698 min_width/height (Bug#8919).
4700 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4701 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4704 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4706 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4707 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4710 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4712 * process.c (wait_reading_process_output): Bypass select if
4713 waiting for a cell while ignoring keyboard input, and input is
4714 pending. Suggested by Jan Djärv (Bug#8869).
4716 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4718 Use gnulib's dup2 module instead of rolling our own.
4719 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4721 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4723 * dispnew.c (scrolling_window): Before scrolling, turn off a
4724 mouse-highlight in the window being scrolled.
4726 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4728 Move DEFSYM to lisp.h and use everywhere.
4730 * character.h (DEFSYM): Move declaration...
4731 * lisp.h (DEFSYM): ...here.
4737 * w32select.c: Don't include character.h.
4739 * alloc.c (syms_of_alloc):
4740 * buffer.c (syms_of_buffer):
4741 * bytecode.c (syms_of_bytecode):
4742 * callint.c (syms_of_callint):
4743 * casefiddle.c (syms_of_casefiddle):
4744 * casetab.c (init_casetab_once):
4745 * category.c (init_category_once, syms_of_category):
4746 * ccl.c (syms_of_ccl):
4747 * cmds.c (syms_of_cmds):
4748 * composite.c (syms_of_composite):
4749 * dbusbind.c (syms_of_dbusbind):
4750 * dired.c (syms_of_dired):
4751 * dispnew.c (syms_of_display):
4752 * doc.c (syms_of_doc):
4753 * editfns.c (syms_of_editfns):
4754 * emacs.c (syms_of_emacs):
4755 * eval.c (syms_of_eval):
4756 * fileio.c (syms_of_fileio):
4757 * fns.c (syms_of_fns):
4758 * frame.c (syms_of_frame):
4759 * fringe.c (syms_of_fringe):
4760 * insdel.c (syms_of_insdel):
4761 * keymap.c (syms_of_keymap):
4762 * lread.c (init_obarray, syms_of_lread):
4763 * macros.c (syms_of_macros):
4764 * msdos.c (syms_of_msdos):
4765 * print.c (syms_of_print):
4766 * process.c (syms_of_process):
4767 * search.c (syms_of_search):
4768 * sound.c (syms_of_sound):
4769 * syntax.c (init_syntax_once, syms_of_syntax):
4770 * terminal.c (syms_of_terminal):
4771 * textprop.c (syms_of_textprop):
4772 * undo.c (syms_of_undo):
4773 * w32.c (globals_of_w32):
4774 * window.c (syms_of_window):
4775 * xdisp.c (syms_of_xdisp):
4776 * xfaces.c (syms_of_xfaces):
4777 * xfns.c (syms_of_xfns):
4778 * xmenu.c (syms_of_xmenu):
4779 * xsettings.c (syms_of_xsettings):
4780 * xterm.c (syms_of_xterm): Use DEFSYM.
4782 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4784 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4786 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4788 Integer and buffer overflow fixes (Bug#8873).
4790 * print.c (printchar, strout): Check for string overflow.
4791 (PRINTPREPARE, printchar, strout):
4792 Don't set size unless allocation succeeds.
4794 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4795 for sizes. Check for string overflow more accurately.
4796 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4798 * macros.c: Integer and buffer overflow fixes.
4799 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4800 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4801 Use ptrdiff_t, not int, for sizes.
4802 Don't increment bufsize until after realloc succeeds.
4803 Check for size-calculation overflow.
4804 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4806 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4808 * lread.c: Integer overflow fixes.
4809 (read_integer): Radix is now EMACS_INT, not int,
4810 to improve quality of diagnostics for out-of-range radices.
4811 Calculate buffer size correctly for out-of-range radices.
4812 (read1): Check for integer overflow in radices, and in
4813 read-circle numbers.
4814 (read_escape): Avoid int overflow.
4815 (Fload, openp, read_buffer_size, read1)
4816 (substitute_object_recurse, read_vector, read_list, map_obarray):
4817 Use ptrdiff_t, not int, for sizes.
4818 (read1): Use EMACS_INT, not int, for sizes.
4819 Check for size overflow.
4821 * image.c (cache_image): Check for size arithmetic overflow.
4823 * lread.c: Integer overflow issues.
4824 (saved_doc_string_size, saved_doc_string_length)
4825 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4826 Now ptrdiff_t, not int.
4827 (read1): Don't assume doc string length fits in int. Check for
4828 out-of-range doc string lengths.
4829 (read_list): Don't assume file position fits in int.
4830 (read_escape): Check for hex character overflow.
4832 2011-06-22 Leo Liu <sdl.web@gmail.com>
4834 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4835 Move to minibuffer.el.
4837 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4839 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4840 The following patches are for when GLYPH_DEBUG && !XASSERT.
4841 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4842 * dispnew.c (flush_stdout):
4843 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4844 Mark as externally visible.
4845 * dispnew.c (check_window_matrix_pointers): Now static.
4846 * dispnew.c (window_to_frame_vpos):
4847 * xfns.c (unwind_create_frame):
4848 * xterm.c (x_check_font): Remove unused local.
4849 * scroll.c (CHECK_BOUNDS):
4850 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4851 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4852 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4853 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4854 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4856 (debug_method_add): Use va_list and vsprintf rather than relying
4857 on undefined behavior with wrong number of arguments.
4858 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4859 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4860 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4861 since we're not interested in debugging glyphs with old libraries.
4862 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4863 GCC 4.6.0's static checking.
4865 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4867 Integer overflow and signedness fixes (Bug#8873).
4868 A few related buffer overrun fixes, too.
4870 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4872 * dispextern.h (struct face.stipple):
4873 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4874 (x_bitmap_mask, x_allocate_bitmap_record)
4875 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4876 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4877 (x_create_bitmap_from_xpm_data):
4878 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4879 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4881 * xfaces.c (load_pixmap):
4882 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4883 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4884 (.bitmaps_last, struct x_output.icon_bitmap):
4885 Use ptrdiff_t, not int, for bitmap indexes.
4886 (x_allocate_bitmap_record): Check for size overflow.
4887 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4889 Use ptrdiff_t, not int, for overlay counts.
4890 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4891 * editfns.c (overlays_around, get_pos_property):
4892 * textprop.c (get_char_property_and_overlay):
4893 * xdisp.c (next_overlay_change, note_mouse_highlight):
4894 * xfaces.c (face_at_buffer_position):
4895 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4896 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4897 (Fnext_overlay_change, Fprevious_overlay_change)
4898 (mouse_face_overlay_overlaps, Foverlays_in):
4899 Use ptrdiff_t, not int, for sizes.
4900 (overlays_at, overlays_in): Check for size-calculation overflow.
4902 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4904 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4905 (x_session_initialize): Do not assume string length fits in int.
4907 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4908 This is unlikely, but can occur if DPI is outlandish.
4910 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4911 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4913 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4914 * xrdb.c (magic_file_p, search_magic_path):
4915 Omit last arg SUFFIX; it was always 0. All callers changed.
4916 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4918 * xfont.c (xfont_match): Avoid need for strlen.
4920 * xfns.c: Don't assume strlen fits in int.
4921 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4923 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4924 not unsigned long, as we prefer signed integers. All callers changed.
4925 Detect integer overflow in repeat count.
4926 (message_dolog): Don't assume print length fits in 39 bytes.
4927 (display_mode_element): Don't assume strlen fits in int.
4929 * termcap.c: Don't assume sizes fit in int and never overflow.
4930 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4931 (gobble_line): Check for size-calculation overflow.
4933 * minibuf.c (Fread_buffer):
4934 * lread.c (intern, intern_c_string):
4935 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4936 Don't assume string length fits in int.
4938 * keyboard.c (parse_tool_bar_item):
4939 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4941 * font.c: Don't assume string length fits in int.
4942 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4943 Use ptrdiff_t, not int.
4944 (font_intern_prop): Don't assume string length fits in int.
4945 Don't assume integer property fits in fixnum.
4946 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4948 * filelock.c: Fix some buffer overrun and integer overflow issues.
4949 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4950 Reformulate so as not to need the command string.
4951 Invoke gzip -cd rather than gunzip, as it's more portable.
4952 (lock_info_type, lock_file_1, lock_file):
4953 Don't assume pid_t and time_t fit in unsigned long.
4954 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4955 (current_lock_owner): Prefer signed type for sizes.
4956 Use memcpy, not strncpy, where memcpy is what is really wanted.
4957 Don't assume (via atoi) that time_t and pid_t fit in int.
4958 Check for time_t and/or pid_t out of range, e.g., via a network share.
4959 Don't alloca where an auto var works fine.
4961 * fileio.c: Fix some integer overflow issues.
4962 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4963 Don't assume string length fits in int.
4964 (directory_file_name): Don't assume string length fits in long.
4965 (make_temp_name): Don't assume pid fits in int, or that its print
4966 length is less than 20.
4968 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4970 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4972 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4974 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4975 We prefer signed integers, even for size calculations.
4977 * emacs.c: Don't assume string length fits in 'int'.
4978 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4979 (main): Don't invoke strlen when not needed.
4981 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4982 (XD_DEBUG_MESSAGE): Don't waste a byte.
4984 * callproc.c (getenv_internal_1, getenv_internal)
4986 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4988 * lread.c (invalid_syntax): Omit length argument.
4989 All uses changed. This doesn't fix a bug, but it simplifies the
4990 code away from its former Hollerith-constant appearance, and it's
4991 one less 'int' to worry about when looking at integer-overflow issues.
4992 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4994 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4995 This didn't break anything, but it didn't help either.
4996 It's confusing to put a bogus integer in a place where the actual
4997 value does not matter.
4998 (LIST_END_P): Remove unused macro and its bogus comment.
4999 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5001 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5002 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5004 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5005 We prefer signed types, and the value cannot exceed the EMACS_INT
5006 range anyway (because otherwise the length would not be representable).
5007 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5008 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5009 This avoids a GCC warning when WIDE_EMACS_INT.
5011 * indent.c (sane_tab_width): New function.
5012 (current_column, scan_for_column, Findent_to, position_indentation)
5013 (compute_motion): Use it. This is just for clarity.
5014 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5016 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5018 * lisp.h (lint_assume): New macro.
5019 * composite.c (composition_gstring_put_cache):
5020 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5022 * editfns.c, insdel.c:
5023 Omit unnecessary forward decls, to simplify future changes.
5025 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5027 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5029 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5030 Use much-faster test for byte-length change.
5031 Don't assume string byte-length fits in 'int'.
5032 Check that character arg fits in 'int'.
5033 (mapcar1): Declare byte as byte, for clarity.
5035 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5037 * fns.c (concat): Catch string overflow earlier.
5038 Do not rely on integer wraparound.
5040 * dispextern.h (struct it.overlay_strings_charpos)
5041 (struct it.selective): Now EMACS_INT, not int.
5042 * xdisp.c (forward_to_next_line_start)
5043 (back_to_previous_visible_line_start)
5044 (reseat_at_next_visible_line_start, next_element_from_buffer):
5045 Don't arbitrarily truncate the value of 'selective' to int.
5047 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5049 * composite.c: Don't truncate sizes to 'int'.
5050 (composition_gstring_p, composition_reseat_it)
5051 (composition_adjust_point): Use EMACS_INT, not int.
5052 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5053 not EMACS_UINT, for indexes.
5055 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5057 * buffer.c: Include <verify.h>.
5058 (struct sortvec.priority, struct sortstr.priority):
5059 Now EMACS_INT, not int.
5060 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5061 (struct sortstr.size, record_overlay_string)
5062 (struct sortstrlist.size, struct sortlist.used):
5063 Don't truncate size to int.
5064 (record_overlay_string): Check for size-calculation overflow.
5065 (init_buffer_once): Check at compile-time, not run-time.
5067 2011-06-22 Jim Meyering <meyering@redhat.com>
5069 Don't leak an XBM-image-sized buffer
5070 * image.c (xbm_load): Free the image buffer after using it.
5072 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5075 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5076 that Sun C diagnosed.
5077 * fns.c (secure_hash): Fix pointer signedness issue.
5078 * intervals.c (static_offset_intervals): New function.
5079 (offset_intervals): Use it.
5081 2011-06-21 Leo Liu <sdl.web@gmail.com>
5084 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5087 * fns.c (secure_hash): Rename from crypto_hash_function and change
5088 the first arg to accept symbols.
5089 (Fsecure_hash): New primitive.
5090 (syms_of_fns): New symbols.
5092 2011-06-20 Deniz Dogan <deniz@dogan.se>
5094 * process.c (Fset_process_buffer): Clarify return value in
5097 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5099 * dispnew.c (add_window_display_history): Use BVAR.
5101 * xdisp.c (debug_method_add): Use BVAR.
5102 (check_window_end, dump_glyph_matrix, dump_glyph)
5103 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5105 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5108 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5109 check till after the cache is created in init_frame_faces.
5111 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5113 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5115 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5117 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5118 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5119 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5121 Improve buffer-overflow checking (Bug#8873).
5122 * fileio.c (Finsert_file_contents):
5123 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5124 Remove the old (too-loose) buffer overflow checks.
5125 They weren't needed, since make_gap checks for buffer overflow.
5126 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5127 The old code merely checked for Emacs fixnum overflow, and relied
5128 on undefined (wraparound) behavior. The new code avoids undefined
5129 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5131 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5132 Tune. Don't use wider integers than needed. Don't use alloca.
5133 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5135 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5137 * insdel.c, lisp.h (buffer_overflow): New function.
5138 (insert_from_buffer_1, replace_range, replace_range_2):
5139 * insdel.c (make_gap_larger):
5140 * editfns.c (Finsert_char):
5141 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5143 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5145 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5147 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5149 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5150 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5152 * fileio.c: Don't assume EMACS_INT fits in off_t.
5153 (emacs_lseek): New static function.
5154 (Finsert_file_contents, Fwrite_region): Use it.
5155 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5157 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5159 * fns.c: Don't overflow int when computing a list length.
5160 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5161 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5162 truncation on 64-bit hosts. Check for QUIT every
5163 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5164 faster and is responsive enough.
5165 (Flength): Report an error instead of overflowing an integer.
5166 (Fsafe_length): Return a float if the value is not representable
5167 as a fixnum. This shouldn't happen except in contrived situations.
5168 (Fnthcdr, Fsort): Don't assume list length fits in int.
5169 (Fcopy_sequence): Don't assume vector length fits in int.
5171 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5172 (header_size, word_size): New constants.
5173 (allocate_vectorlike): Don't check size overflow here.
5174 (allocate_vector): Check it here instead, since this is the only
5175 caller of allocate_vectorlike that could cause overflow.
5176 Check that the new vector's length is representable as a fixnum.
5178 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5179 The previous code was bogus. For example, next_almost_prime (32)
5180 returned 39, which is undesirable as it is a multiple of 3; and
5181 next_almost_prime (24) returned 25, which is a multiple of 5 so
5182 why was the code bothering to check for multiples of 7?
5184 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5186 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5188 Variadic C functions now count arguments with ptrdiff_t.
5189 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5190 Back then I didn't know that the Emacs coding style prefers signed int.
5191 Also, in the meantime I found a few more instances where arguments
5192 were being counted with int, which may truncate counts on 64-bit
5193 machines, or EMACS_INT, which may be unnecessarily wide.
5194 * lisp.h (struct Lisp_Subr.function.aMANY)
5195 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5196 Arg counts are now ptrdiff_t, not size_t.
5197 All variadic functions and their callers changed accordingly.
5198 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5199 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5200 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5201 * callint.c (Fcall_interactively): Check arg count for overflow,
5202 to avoid potential buffer overrun. Use signed char, not 'int',
5203 for 'varies' array, so that we needn't bother to check its size
5204 calculation for overflow.
5205 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5206 * eval.c (apply_lambda):
5207 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5208 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5209 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5211 * callint.c (Fcall_interactively): Don't use index var as event count.
5213 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5214 * mem-limits.h (SIZE): Remove; no longer used.
5216 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5218 Remove unnecessary casts.
5219 * xterm.c (x_term_init):
5220 * xfns.c (x_set_border_pixel):
5221 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5222 These aren't needed now that we assume ANSI C.
5224 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5225 It's more likely to cause problems (due to unsigned overflow)
5228 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5230 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5232 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5234 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5236 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5238 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5240 GLYPH_CODE_FACE returns EMACS_INT, not int.
5241 * dispextern.h (merge_faces):
5242 * xfaces.c (merge_faces):
5243 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5244 Don't assume EMACS_INT fits in int.
5246 * character.h (CHAR_VALID_P): Remove unused parameter.
5247 * fontset.c, lisp.h, xdisp.c: All uses changed.
5249 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5251 * fns.c (concat): Minor tuning based on overflow analysis.
5252 This doesn't fix any bugs. Use int to hold character, instead
5253 of constantly refetching from Emacs object. Use XFASTINT, not
5254 XINT, for value known to be a character. Don't bother comparing
5255 a single byte to 0400, as it's always less.
5257 * floatfns.c (Fexpt):
5258 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5260 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5263 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5265 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5266 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5267 incorrectly succeed when S was a string, because 4294967386 was
5268 truncated before it was used.
5270 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5271 Otherwise, an out-of-range integer could cause undefined behavior
5274 * composite.c: Use int, not EMACS_INT, for characters.
5275 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5276 EMACS_INT, for values that are known to be in character range.
5277 This doesn't fix any bugs but is the usual style inside Emacs and
5278 may generate better code on 32-bit machines.
5280 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5281 This is for reasons similar to the recent CHAR_STRING fix.
5282 * charset.c (Fencode_char): Check that character arg is actually
5283 a character. Pass an int to ENCODE_CHAR.
5284 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5285 wider than 'int', as a compile-time check to prevent future regressions
5288 * character.c (char_string): Remove unnecessary casts.
5290 Make sure a 64-bit char is never passed to CHAR_STRING.
5291 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5292 by silently ignoring the top 32 bits, allowing some values
5293 that were far too large to be valid characters.
5294 * character.h: Include <verify.h>.
5295 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5296 arguments are no wider than unsigned, as a compile-time check
5297 to prevent future regressions in this area.
5299 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5300 (Fsubst_char_in_region):
5302 * xdisp.c (decode_mode_spec_coding):
5303 Adjust to CHAR_STRING's new requirement.
5304 * editfns.c (Finsert_char, Fsubst_char_in_region):
5305 * fns.c (concat): Check that character args are actually
5306 characters. Without this test, these functions did the wrong
5307 thing with wildly out-of-range values on 64-bit hosts.
5309 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5310 These casts should not be needed on 32-bit hosts, either.
5311 * keyboard.c (read_char):
5312 * lread.c (Fload): Remove casts to unsigned.
5314 * lisp.h (UNSIGNED_CMP): New macro.
5315 This fixes comparison bugs on 64-bit hosts.
5316 (ASCII_CHAR_P): Use it.
5317 * casefiddle.c (casify_object):
5318 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5319 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5320 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5321 * dispextern.h (FACE_FROM_ID):
5322 * keyboard.c (read_char): Use UNSIGNED_CMP.
5324 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5325 not to EMACS_INT, to avoid GCC warning.
5327 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5329 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5330 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5331 isn't needed on 32-bit machines.
5333 * buffer.c (Fgenerate_new_buffer_name):
5334 Use EMACS_INT for count, not int.
5335 (advance_to_char_boundary): Return EMACS_INT, not int.
5337 * data.c (Qcompiled_function): Now static.
5339 * window.c (window_body_lines): Now static.
5341 * image.c (gif_load): Rename local to avoid shadowing.
5343 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5344 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5345 * alloc.c (make_save_value): Integer argument is now of type
5347 (mark_object): Use ptrdiff_t, not int.
5348 * lisp.h (pD): New macro.
5349 * print.c (print_object): Use it.
5351 * alloc.c: Use EMACS_INT, not int, to count objects.
5352 (total_conses, total_markers, total_symbols, total_vector_size)
5353 (total_free_conses, total_free_markers, total_free_symbols)
5354 (total_free_floats, total_floats, total_free_intervals)
5355 (total_intervals, total_strings, total_free_strings):
5356 Now EMACS_INT, not int. All uses changed.
5357 (Fgarbage_collect): Compute overall total using a double, so that
5358 integer overflow is less likely to be a problem. Check for overflow
5359 when converting back to an integer.
5360 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5361 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5362 These were 'int' variables that could overflow on 64-bit hosts;
5363 they were never used, so remove them instead of repairing them.
5364 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5365 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5366 Previously, this ceilinged at INT_MAX, but that doesn't work on
5368 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5370 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5371 (allocate_vectorlike): Check for ptrdiff_t overflow.
5372 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5373 when a (possibly-narrower) signed value would do just as well.
5374 We prefer using signed arithmetic, to avoid comparison confusion.
5376 * alloc.c: Catch some string size overflows that we were missing.
5377 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5378 for convenience in STRING_BYTES_MAX.
5379 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5380 The definition here is exact; the one in lisp.h was approximate.
5381 (allocate_string_data): Check for string overflow. This catches
5382 some instances we weren't catching before. Also, it catches
5383 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5384 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5385 and ptrdiff_t and EMACS_INT are both 64 bits.
5387 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5388 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5389 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5391 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5393 * alloc.c (Fmake_string): Check for out-of-range init.
5395 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5397 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5399 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5401 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5402 xg_get_default_scrollbar_width.
5404 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5405 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5406 (style_changed_cb): Call update_theme_scrollbar_width and call
5407 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5408 all frames (Bug#8505).
5409 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5410 Call gtk_window_set_resizable if HAVE_GTK3.
5411 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5412 and height if HAVE_GTK3 (Bug#8505).
5413 (scroll_bar_width_for_theme): New variable.
5414 (update_theme_scrollbar_width): New function.
5415 (xg_get_default_scrollbar_width): Move code to
5416 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5417 (xg_initialize): Call update_theme_scrollbar_width.
5419 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5421 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5423 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5425 * frame.c (make_frame): Call other_buffer_safely instead of
5428 * window.c (temp_output_buffer_show): Call display_buffer with
5429 second argument Vtemp_buffer_show_specifiers and reset latter
5430 immediately after the call.
5431 (Vtemp_buffer_show_specifiers): New variable.
5432 (auto_window_vscroll_p, next_screen_context_lines)
5433 (Vscroll_preserve_screen_position): Remove leading asterisks from
5436 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5438 Fix minor problems found by GCC 4.6.0 static checking.
5439 * buffer.c (Qclone_number): Remove for now, as it's unused.
5440 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5441 (record_buffer): Remove unused local.
5442 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5443 (set_frame_buffer_list): Remove; unused.
5444 * frame.h (other_visible_frames): Remove decl.
5445 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5446 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5447 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5449 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5450 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5451 Define only if HAVE_GPM.
5452 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5453 (update_hints_inhibit): Remove; never set. All uses removed.
5454 * widgetprv.h (emacsFrameClassRec): Remove decl.
5455 * window.c (delete_deletable_window): Now returns void, since it
5456 wasn't returning anything.
5457 (compare_window_configurations): Remove unused locals.
5458 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5459 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5460 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5461 the same widths as pointers. This follows up on the 2011-05-06 patch.
5462 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5463 * xterm.h: Likewise.
5464 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5466 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5468 * makefile.w32-in: Update dependencies.
5469 (LISP_H): Add lib/intprops.h.
5471 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5473 * image.c (gif_load): Add animation frame delay to the metadata.
5474 (syms_of_image): Use DEFSYM. New symbol `delay'.
5476 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5478 * window.c (delete_deletable_window): Re-add.
5479 (Fset_window_configuration): Rewrite to handle dead buffers and
5480 consequently deletable windows.
5481 (window_tree, Fwindow_tree): Remove. Supply functionality in
5483 (compare_window_configurations): Simplify code.
5485 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5487 * image.c (imagemagick_load_image): Fix type mismatch.
5488 (Fimagemagick_types): Likewise.
5490 * window.h (replace_buffer_in_windows): Declare.
5492 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5494 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5495 Qclone_number. Remove external declaration of Qdelete_window.
5496 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5498 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5499 Run Qbuffer_list_update_hook if allowed.
5500 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5501 buffer list implementation.
5502 (other_buffer_safely): New function.
5503 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5504 calls to replace_buffer_in_windows and
5505 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5507 (record_buffer): Inhibit quitting and rewrite using quittable
5508 functions. Run Qbuffer_list_update_hook if allowed.
5509 (Frecord_buffer, Funrecord_buffer): New functions.
5510 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5511 Move switch-to-buffer to window.el.
5512 (bury-buffer): Move to window.el.
5513 (Vbuffer_list_update_hook): New variable.
5515 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5518 * window.h (resize_frame_windows): Move up in code.
5519 (Fwindow_frame): Remove EXFUN.
5520 (replace_buffer_in_all_windows): Remove prototype.
5521 (replace_buffer_in_windows_safely): Add prototype.
5523 * window.c: Declare Qdelete_window static again. Move down
5524 declaration of select_count.
5525 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5526 (Fother_window): Move to window.el.
5527 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5528 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5529 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5531 (replace_buffer_in_windows): Implement by calling
5532 Qreplace_buffer_in_windows.
5533 (replace_buffer_in_all_windows): Remove with some functionality
5534 moved into replace_buffer_in_windows_safely.
5535 (replace_buffer_in_windows_safely): New function.
5536 (select_window_norecord, select_frame_norecord): Move in front
5537 of run_window_configuration_change_hook. Remove now obsolete
5539 (Fset_window_buffer): Rewrite doc-string.
5540 Call Qrecord_window_buffer.
5541 (keys_of_window): Move binding for other-window to window.el.
5543 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5545 * dispextern.h (struct image): Replace data member, whose int_val
5546 and ptr_val fields were not used by anything, with a single
5549 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5550 (gif_clear_image, gif_load, imagemagick_load_image)
5551 (gs_clear_image, gs_load): Callers changed.
5553 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5555 * buffer.h: Include <time.h>, for time_t.
5556 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5558 Fix minor problems found by static checking.
5560 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5562 Make identifiers static if they are not used in other modules.
5563 * data.c (Qcompiled_function, Qframe, Qvector):
5564 * image.c (QimageMagick, Qsvg):
5565 * minibuf.c (Qmetadata):
5566 * window.c (resize_window_check, resize_root_window): Now static.
5567 * window.h (resize_window_check, resize_root_window): Remove decls.
5569 * window.c (window_deletion_count, delete_deletable_window):
5571 (window_body_lines): Now static.
5572 (Fdelete_other_windows_internal): Mark vars as initialized.
5573 Make sure 'resize_failed' is initialized.
5574 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5575 (resize_window_apply): Remove unused local.
5576 * window.h (delete_deletable_window): Remove decl.
5578 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5579 (imagemagick_load_image): Fix pointer signedness problem by changing
5580 last arg from unsigned char * to char *. All uses changed.
5581 Also, fix a local for similar reasons.
5582 Remove unused locals. Remove locals to avoid shadowing.
5583 (fn_rsvg_handle_free): Remove; unused.
5584 (svg_load, svg_load_image): Fix pointer signedness problem.
5585 (imagemagick_load_image): Don't use garbage pointer image_wand.
5587 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5589 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5591 * image.c (gif_load): Fix omitted cast error introduced by
5594 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5596 * window.h (resize_proportionally, orig_total_lines)
5597 (orig_top_line): Remove from window structure.
5598 (set_window_height, set_window_width, change_window_heights)
5599 (Fdelete_window): Remove prototypes.
5600 (resize_frame_windows): Remove duplicate declaration.
5602 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5604 * window.h (resize_frame_windows, resize_window_check)
5605 (delete_deletable_window, resize_root_window)
5606 (resize_frame_windows): Declare prototypes.
5608 * window.c (resize_window_apply): Make definition be "static" to
5609 match the prototype.
5611 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5613 * window.c: Remove declarations of Qwindow_size_fixed,
5614 window_min_size_1, window_min_size_2, window_min_size,
5615 size_window, window_fixed_size_p, enlarge_window, delete_window.
5616 Remove static from declaration of Qdelete_window, it's
5617 temporarily needed by Fbury_buffer.
5618 (replace_window): Don't assign orig_top_line and
5620 (Fdelete_window, delete_window): Remove. Window deletion is
5621 handled by window.el.
5622 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5623 Replace Fdelete_window calls with calls to Qdelete_window.
5624 (Fdelete_other_windows): Remove. Deleting other windows is
5625 handled by window.el.
5626 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5627 handled in window.el.
5628 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5629 Window minimum sizes are handled in window.el.
5630 (shrink_windows, size_window, set_window_height)
5631 (set_window_width, change_window_heights, window_height)
5632 (window_width, CURBEG, CURSIZE, enlarge_window)
5633 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5634 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5635 handled in window.el.
5636 (make_dummy_parent): Rename to make_parent_window and give it a
5637 second argument horflag.
5638 (make_window): Don't set resize_proportionally any more.
5639 (Fsplit_window): Remove. Windows are split in window.el.
5640 (save_restore_action, save_restore_orig_size)
5641 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5642 Resize mini windows in window.el.
5643 (grow_mini_window, shrink_mini_window): Implement by calling
5644 Qresize_root_window_vertically, resize_window_check and
5645 resize_window_apply.
5646 (saved_window, Fset_window_configuration, save_window_save):
5647 Do not handle orig_top_line, orig_total_lines, and
5648 resize_proportionally.
5649 (window_min_height, window_min_width): Move to window.el.
5650 (keys_of_window): Move bindings for delete-other-windows,
5651 split-window, delete-window and enlarge-window to window.el.
5653 * buffer.c: Temporarily extern Qdelete_window.
5654 (Fbury_buffer): Temporarily call Qdelete_window instead of
5655 Fdelete_window (Fbury_buffer will move to window.el soon).
5657 * frame.c (set_menu_bar_lines_1): Remove code handling
5658 orig_top_line and orig_total_lines.
5660 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5661 set_window_height but set heights directly.
5662 (change_frame_size_1): Use resize_frame_windows.
5664 * xdisp.c (init_xdisp): Don't use set_window_height but set
5667 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5668 Use resize_frame_windows instead of change_window_heights and run
5669 run_window_configuration_change_hook.
5671 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5672 instead of change_window_heights and run
5673 run_window_configuration_change_hook.
5675 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5677 * window.c (replace_window): Rename second argument REPLACEMENT to
5678 NEW. New third argument SETFLAG. Rewrite.
5679 (delete_window, make_dummy_parent): Call replace_window with
5681 (window_list_1): Move down in code.
5682 (run_window_configuration_change_hook): Move set_buffer part
5683 before select_frame_norecord part in order to unwind correctly.
5684 Rename count1 to count.
5685 (recombine_windows, delete_deletable_window, resize_root_window)
5686 (Fdelete_other_windows_internal)
5687 (Frun_window_configuration_change_hook, make_parent_window)
5688 (resize_window_check, resize_window_apply, Fresize_window_apply)
5689 (resize_frame_windows, Fsplit_window_internal)
5690 (Fdelete_window_internal, Fresize_mini_window_internal):
5692 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5694 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5696 * window.h (window): Add some new members to window structure -
5697 normal_lines, normal_cols, new_total, new_normal, clone_number,
5698 splits, nest, prev_buffers, next_buffers.
5699 (WINDOW_TOTAL_SIZE): Move here from window.c.
5700 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5702 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5704 (make_dummy_parent): Set new members of windows structure.
5705 (make_window): Move down in code. Handle new members of window
5707 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5708 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5709 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5710 (Fset_window_prev_buffers, Fwindow_next_buffers)
5711 (Fset_window_next_buffers, Fset_window_clone_number):
5713 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5714 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5716 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5717 Argument WINDOW can be now internal window too.
5718 (Fwindow_use_time): Move up in code.
5719 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5721 (Fset_window_configuration, saved_window)
5722 (Fcurrent_window_configuration, save_window_save): Handle new
5723 members of window structure.
5724 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5725 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5726 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5727 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5728 Qget_mru_window, Qresize_root_window,
5729 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5730 Qauto_buffer_name; staticpro them.
5732 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5734 * window.c (Fwindow_total_size, Fwindow_left_column)
5735 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5736 (Fwindow_list_1): New functions.
5737 (window_box_text_cols): Replace with window_body_cols.
5738 (Fwindow_width, Fscroll_left, Fscroll_right):
5739 Use window_body_cols instead of window_box_text_cols.
5740 (delete_window, Fset_window_configuration):
5741 Call delete_all_subwindows with window as argument.
5742 (delete_all_subwindows): Take a window as argument and not a
5744 (window_loop): Remove handling of GET_LRU_WINDOW and
5746 (Fget_lru_window, Fget_largest_window): Move to window.el.
5748 * window.h: Extern window_body_cols instead of
5749 window_box_text_cols. delete_all_subwindows now takes a
5750 Lisp_Object as argument.
5752 * indent.c (compute_motion, Fcompute_motion):
5753 Use window_body_cols instead of window_box_text_cols.
5755 * frame.c (delete_frame): Call delete_all_subwindows with root
5758 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5760 * fns.c (Fputhash): Document return value.
5762 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5764 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5766 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5768 Cons<->int and similar integer overflow fixes (Bug#8794).
5770 Check for overflow when converting integer to cons and back.
5771 * charset.c (Fdefine_charset_internal, Fdecode_char):
5772 Use cons_to_unsigned to catch overflow.
5773 (Fencode_char): Use INTEGER_TO_CONS.
5774 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5775 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5776 * data.c (long_to_cons, cons_to_long): Remove.
5777 (cons_to_unsigned, cons_to_signed): New functions.
5778 These signal an error for invalid or out-of-range values.
5779 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5780 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5781 * font.c (Ffont_variation_glyphs):
5782 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5783 * lisp.h: Include <intprops.h>.
5784 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5785 (cons_to_signed, cons_to_unsigned): New decls.
5786 (long_to_cons, cons_to_long): Remove decls.
5787 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5788 (Fprimitive_undo): Use CONS_TO_INTEGER.
5789 * xfns.c (Fx_window_property): Likewise.
5790 * xselect.c: Include <limits.h>.
5791 (x_own_selection, selection_data_to_lisp_data):
5792 Use INTEGER_TO_CONS.
5793 (x_handle_selection_request, x_handle_selection_clear)
5794 (x_get_foreign_selection, Fx_disown_selection_internal)
5795 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5796 (lisp_data_to_selection_data): Use cons_to_unsigned.
5797 (x_fill_property_data): Use cons_to_signed.
5798 Report values out of range.
5800 Check for buffer and string overflow more precisely.
5801 * buffer.h (BUF_BYTES_MAX): New macro.
5802 * lisp.h (STRING_BYTES_MAX): New macro.
5803 * alloc.c (Fmake_string):
5804 * character.c (string_escape_byte8):
5805 * coding.c (coding_alloc_by_realloc):
5806 * doprnt.c (doprnt):
5807 * editfns.c (Fformat):
5809 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5810 since they may not be the same number.
5811 * editfns.c (Finsert_char):
5812 * fileio.c (Finsert_file_contents):
5813 Likewise for BUF_BYTES_MAX.
5815 * image.c: Use ptrdiff_t, not int, for sizes.
5816 (slurp_file): Switch from int to ptrdiff_t.
5818 (slurp_file): Check that file size fits in both size_t (for
5819 malloc) and ptrdiff_t (for sanity and safety).
5821 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5822 if b->modtime has its maximal value.
5824 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5826 Don't assume time_t can fit into int.
5827 * buffer.h (struct buffer.modtime): Now time_t, not int.
5828 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5829 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5831 Minor fixes for signed vs unsigned integers.
5832 * character.h (MAYBE_UNIFY_CHAR):
5833 * charset.c (maybe_unify_char):
5834 * keyboard.c (read_char, reorder_modifiers):
5835 XINT -> XFASTINT, since the integer must be nonnegative.
5836 * ftfont.c (ftfont_spec_pattern):
5837 * keymap.c (access_keymap, silly_event_symbol_error):
5838 XUINT -> XFASTINT, since the integer must be nonnegative.
5839 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5840 since it makes no difference and we prefer signed.
5841 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5842 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5845 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5847 * window.h (Fwindow_frame): Declare.
5849 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5851 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5852 (SPARE_MEMORY): Always define.
5853 (LARGE_REQUEST): Remove.
5854 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5856 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5858 * lisp.h: Move EXFUNS for Fframe_root_window,
5859 Fframe_first_window and Fset_frame_selected_window to window.h.
5861 * window.h: Move EXFUNS for Fframe_root_window,
5862 Fframe_first_window and Fset_frame_selected_window here from
5865 * frame.c (Fwindow_frame, Fframe_first_window)
5866 (Fframe_root_window, Fframe_selected_window)
5867 (Fset_frame_selected_window): Move to window.c.
5868 (Factive_minibuffer_window): Move to minibuf.c.
5869 (Fother_visible_frames_p): New function.
5871 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5873 * window.c (decode_window, decode_any_window): Move up in code.
5874 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5875 (inhibit_frame_unsplittable): Remove unused variable.
5876 (Fwindow_buffer): Move up and rewrite doc-string.
5877 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5878 (Fwindow_prev): New functions.
5879 (Fwindow_frame): Move here from frame.c. Accept any window as
5881 (Fframe_root_window, Fframe_first_window)
5882 (Fframe_selected_window): Move here from frame.c. Accept frame
5883 or arbitrary window as argument. Update doc-strings.
5884 (Fminibuffer_window): Move up in code.
5885 (Fwindow_minibuffer_p): Move up in code and simplify.
5886 (Fset_frame_selected_window): Move here from frame.c.
5888 (Fselected_window, select_window, Fselect_window): Move up in
5889 code. Minor doc-string fixes.
5891 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5893 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5894 Do not assume that spare memory exists; that assumption is valid
5895 only if SYSTEM_MALLOC.
5896 (LARGE_REQUEST): New macro, so that the issue of large requests
5897 is separated from the issue of spare memory.
5899 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5901 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5904 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5906 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5909 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5911 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5913 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5915 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5916 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5918 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5920 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5922 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5924 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5925 (x_clipboard_manager_save): Add return value.
5926 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5928 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5929 Obey Vx_select_enable_clipboard_manager. Catch errors in
5930 x_clipboard_manager_save (Bug#8779).
5931 (Vx_select_enable_clipboard_manager): New variable.
5932 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5934 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5936 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5938 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5940 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5941 in the current matrix if keep_current_p is non-zero.
5943 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5945 * bidi.c (bidi_level_of_next_char): Fix last change.
5947 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5949 Support bidi reordering of text covered by display properties.
5951 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5952 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5953 (bidi_cache_search, bidi_cache_iterator_state)
5954 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5955 (bidi_level_of_next_char, bidi_move_to_visually_next):
5956 Support character positions inside a run of characters covered by a
5958 (bidi_paragraph_init, bidi_resolve_explicit_1)
5959 (bidi_level_of_next_char): Call bidi_fetch_char and
5960 bidi_fetch_char_advance instead of FETCH_CHAR and
5962 (bidi_init_it): Initialize new members.
5963 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5965 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5966 instead of using explicit *_CHAR codes.
5967 (bidi_resolve_explicit, bidi_resolve_weak):
5968 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5969 bidirectional text is supported only in multibyte buffers.
5970 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5971 it to initialize the frame_window_p member of struct bidi_it.
5972 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5973 (bidi_resolve_explicit, bidi_resolve_weak)
5974 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5975 bidi_it->nchars is non-positive.
5976 (bidi_level_of_next_char): Don't try to lookup the cache for the
5977 next/previous character if nothing is cached there yet, or if we
5978 were just reseat()'ed to a new position.
5980 * xdisp.c (set_cursor_from_row): Set start and stop points
5981 according to the row's direction when priming the loop that looks
5982 for the glyph on which to display cursor.
5983 (single_display_spec_intangible_p): Function deleted.
5984 (display_prop_intangible_p): Reimplement to call
5985 handle_display_spec instead of single_display_spec_intangible_p.
5986 Accept 3 additional arguments needed by handle_display_spec.
5987 This fixes incorrect cursor motion across display property with complex
5988 values: lists, `(when COND...)' forms, etc.
5989 (single_display_spec_string_p): Support property values that are
5990 lists with the argument STRING its top-level element.
5991 (display_prop_string_p): Fix the condition for processing a
5992 property that is a list to be consistent with handle_display_spec.
5993 (handle_display_spec): New function, refactored from the
5994 last portion of handle_display_prop.
5995 (compute_display_string_pos): Accept additional argument
5996 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5997 value of a `display' property is a "replacing spec".
5998 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5999 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6000 the display property, but just return a value indicating whether
6001 the display property will replace the characters it covers.
6002 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6003 frame_window_p members of struct bidi_it.
6004 (compute_display_string_pos, compute_display_string_end):
6006 (push_it): Accept second argument POSITION, where pop_it should
6007 jump to continue iteration.
6008 (reseat_1): Initialize bidi_it.disp_pos.
6010 * keyboard.c (adjust_point_for_property): Adjust the call to
6011 display_prop_intangible_p to its new signature.
6013 * dispextern.h (struct bidi_it): New member frame_window_p.
6014 (bidi_init_it): Update prototypes.
6015 (display_prop_intangible_p): Update prototype.
6016 (compute_display_string_pos, compute_display_string_end):
6018 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6021 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6023 Malloc failure behavior now depends on size of allocation.
6024 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6025 * lisp.h: Change signatures accordingly.
6026 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6027 All callers changed. (Bug#8762)
6029 * gnutls.c: Use Emacs's memory allocators.
6030 Without this change, the gnutls library would invoke malloc etc.
6031 directly, which causes problems on non-SYNC_INPUT hosts, and which
6032 runs afoul of improving memory_full behavior. (Bug#8761)
6033 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6034 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6035 xfree instead of the default malloc, realloc, free.
6036 (Fgnutls_boot): No need to check for memory allocation failure,
6037 since xmalloc does that for us.
6039 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6040 * category.c (hash_get_category_set):
6041 * ccl.c (ccl_driver):
6042 * charset.c (Fdefine_charset_internal):
6043 * charset.h (struct charset.hash_index):
6044 * composite.c (get_composition_id, gstring_lookup_cache)
6045 (composition_gstring_put_cache):
6046 * composite.h (struct composition.hash_index):
6047 * dispextern.h (struct image.hash):
6048 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6049 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6050 (hashfn_equal, hashfn_user_defined, make_hash_table)
6051 (maybe_resize_hash_table, hash_lookup, hash_put)
6052 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6053 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6054 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6055 * image.c (make_image, search_image_cache, lookup_image)
6056 (xpm_put_color_table_h):
6057 * lisp.h (struct Lisp_Hash_Table):
6058 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6059 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6060 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6061 * alloc.c (allocate_vectorlike):
6062 Check for overflow in vector size calculations.
6063 * ccl.c (ccl_driver):
6064 Check for overflow when converting EMACS_INT to int.
6065 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6066 need to be updated by these changes.
6067 * fns.c (make_hash_table, maybe_resize_hash_table):
6068 Check for integer overflow with large hash tables.
6069 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6070 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6071 (SXHASH_REDUCE): New macro.
6072 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6073 Use it instead of discarding useful hash info with large hash values.
6074 (sxhash_float): New function.
6075 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6076 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6077 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6078 Rewrite to use FIXNUM_BITS, as this simplifies things.
6079 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6080 Adjust signatures to match updated version of code.
6081 (consing_since_gc): Now EMACS_INT, since a single hash table can
6082 use more than INT_MAX bytes.
6084 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6086 Make it possible to build with GCC-4.6+ -O2 -flto.
6088 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6090 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6092 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6093 Call minibuffer-inactive-mode.
6095 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6097 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6098 Update dependencies.
6100 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6102 * data.c (init_data): Remove code for UTS, this system is not
6105 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6107 Don't force ./temacs to start in terminal mode.
6109 * frame.c (make_initial_frame): Initialize faces in all cases, not
6110 only when CANNOT_DUMP is defined.
6111 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6113 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6115 * dispnew.c (add_window_display_history): Use const for the string
6116 pointer. Remove declaration, not needed.
6118 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6120 Use 'inline', not 'INLINE'.
6121 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6122 * alloc.c, fontset.c (INLINE): Remove.
6123 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6124 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6125 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6126 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6127 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6129 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6131 Make it possible to run ./temacs.
6133 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6134 syms_of_callproc does the same thing. Remove test for
6135 "initialized", do it in the caller.
6136 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6138 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6140 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6141 (read_minibuf): Use get_minibuffer.
6142 (syms_of_minibuf): Use DEFSYM.
6143 (Qmetadata): New var.
6144 * data.c (Qbuffer): Don't make it static.
6145 (syms_of_data): Use DEFSYM.
6147 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6149 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6150 (CCL_CODE_MIN): New macro.
6152 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6154 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6156 * eval.c (Qdebug): Now static.
6157 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6158 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6159 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6161 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6163 * image.c: Various fixes to ImageMagick code comments.
6164 (Fimagemagick_types): Doc fix.
6166 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6168 Minor fixes prompted by GCC 4.6.0 warnings.
6170 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6172 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6173 (x_clipboard_manager_save_all): Move extern decl to ...
6174 * xterm.h: ... here, so that it can be checked for consistency.
6176 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6178 * xselect.c (x_clipboard_manager_save_frame)
6179 (x_clipboard_manager_save_all): New functions.
6180 (Fx_clipboard_manager_save): Lisp function deleted.
6182 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6183 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6185 * xterm.h: Update prototype.
6187 2011-05-28 William Xu <william.xwl@gmail.com>
6189 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6192 2011-05-28 Jim Meyering <meyering@redhat.com>
6194 Avoid a sign-extension bug in crypto_hash_function.
6195 * fns.c (to_uchar): Define.
6196 (crypto_hash_function): Use it to convert some newly-signed
6197 variables to unsigned, to avoid sign-extension bugs. For example,
6198 without this change, (md5 "truc") would evaluate to
6199 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6200 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6201 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6203 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6205 Integer overflow fixes.
6207 * dbusbind.c: Serial number integer overflow fixes.
6208 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6209 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6210 to hold a serial number that is too large for a fixnum.
6211 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6212 Check for serial numbers out of range. Decode any serial number
6213 that was so large that it became a float. (Bug#8722)
6215 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6216 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6217 Use XFASTINT rather than XUINT when numbers are nonnegative.
6218 (xd_append_arg, Fdbus_method_return_internal):
6219 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6220 arguments, check that Lisp number is nonnegative, rather than
6221 silently wrapping negative numbers around. (Bug#8722)
6222 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6225 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6227 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6229 ccl: Add integer overflow checks.
6230 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6231 (IN_INT_RANGE): New macros.
6232 (ccl_driver): Use them to check for integer overflow when
6233 decoding a CCL program. Many of the new checks are whether XINT (x)
6234 fits in int; it doesn't always, on 64-bit hosts. The new version
6235 doesn't catch all possible integer overflows, but it's an
6236 improvement. (Bug#8719)
6238 * alloc.c (make_event_array): Use XINT, not XUINT.
6239 There's no need for unsigned here.
6241 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6242 This follows up to the 2011-05-06 change that substituted uintptr_t
6243 for EMACS_INT. This case wasn't caught back then.
6245 Rework Fformat to avoid integer overflow issues.
6246 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6247 now (part of C89). Include <verify.h>.
6248 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6249 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6250 (Fformat): Avoid the prepass trying to compute sizes; it was only
6251 approximate and thus did not catch overflow reliably. Instead, walk
6252 through the format just once, formatting and computing sizes as we go,
6253 checking for integer overflow at every step, and allocating a larger
6254 buffer as needed. Keep track separately whether the format is
6255 multibyte. Keep only the most-recently calculated precision, rather
6256 than them all. Record whether each argument has been converted to
6257 string. Use EMACS_INT, not int, for byte and char and arg counts.
6258 Support field widths and precisions larger than INT_MAX. Avoid
6259 sprintf's undefined behavior with conversion specifications such as %#d
6260 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6261 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6262 formatting out-of-range floating point numbers with int
6265 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6267 * data.c: Avoid integer truncation in expressions involving floats.
6268 * data.c: Include <intprops.h>.
6269 (arith_driver): When there's an integer overflow in an expression
6270 involving floating point, convert the integers to floating point
6271 so that the resulting value does not suffer from catastrophic
6272 integer truncation. For example, on a 64-bit host (* 4
6273 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6274 Do not rely on undefined behavior after integer overflow.
6276 merge count_size_as_multibyte, parse_str_to_multibyte
6277 * character.c, character.h (count_size_as_multibyte):
6278 Rename from parse_str_to_multibyte; all uses changed.
6279 Check for integer overflow.
6280 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6281 since it's now a duplicate of the other. This is more of
6282 a character than a buffer op, so better that it's in character.c.
6283 * fns.c, print.c: Adjust to above changes.
6285 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6287 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6289 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6291 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6292 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6293 (x_clipboard_manager_save): Now static.
6294 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6296 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6297 (crypto_hash_function): Now static.
6298 Fix pointer signedness problems. Avoid unnecessary initializations.
6300 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6302 * termhooks.h (Vselection_alist): Make it terminal-local.
6304 * terminal.c (create_terminal): Initialize it.
6306 * xselect.c: Support for clipboard managers.
6307 (Vselection_alist): Move to termhooks.h as terminal-local var.
6308 (LOCAL_SELECTION): New macro.
6309 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6310 (symbol_to_x_atom): Remove gratuitous arg.
6311 (x_handle_selection_request, lisp_data_to_selection_data)
6312 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6313 (x_own_selection, x_get_local_selection, x_convert_selection):
6314 New arg, specifying work frame. Use terminal-local Vselection_alist.
6315 (some_frame_on_display): Delete unused function.
6316 (Fx_own_selection_internal, Fx_get_selection_internal)
6317 (Fx_disown_selection_internal, Fx_selection_owner_p)
6318 (Fx_selection_exists_p): New optional frame arg.
6319 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6320 (x_handle_selection_clear): Don't treat other terminals with the
6321 same keyboard specially. Use the terminal-local Vselection_alist.
6322 (x_clear_frame_selections): Use Frun_hook_with_args.
6324 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6326 * xterm.h: Add support for those atoms.
6328 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6330 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6331 (converted_selections, conversion_fail_tag): New global variables.
6332 (x_selection_request_lisp_error): Free the above.
6333 (x_get_local_selection): Remove unnecessary code.
6334 (x_reply_selection_request): Args changed; handle arbitrary array
6335 of converted selections stored in converted_selections.
6336 Separate the XChangeProperty and SelectionNotify steps.
6337 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6338 (x_convert_selection): New function.
6339 (x_handle_selection_event): Simplify.
6340 (x_get_foreign_selection): Don't ignore incoming requests while
6341 waiting for an answer; this will fail when we implement
6342 SAVE_TARGETS, and seems unnecessary anyway.
6343 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6344 (Vx_sent_selection_functions): Doc fix.
6346 2011-05-26 Leo Liu <sdl.web@gmail.com>
6348 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6350 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6352 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6354 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6355 for fringe update if it has periodic bitmap.
6356 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6357 and fringe_bitmap_periodic_p.
6359 * fringe.c (get_fringe_bitmap_data): New function.
6360 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6361 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6362 row. Mark glyph row for fringe update if periodicity changed.
6364 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6365 for fringe update unless it has periodic bitmap.
6367 2011-05-25 Kenichi Handa <handa@m17n.org>
6369 * xdisp.c (get_next_display_element): Set correct it->face_id for
6370 a static composition.
6372 2011-05-24 Leo Liu <sdl.web@gmail.com>
6375 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6377 * fns.c (crypto_hash_function, Fsha1): New function.
6378 (Fmd5): Use crypto_hash_function.
6379 (syms_of_fns): Add Ssha1.
6381 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6383 * gnutls.c: Remove unused macros.
6384 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6385 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6386 Remove macros that are defined and never used.
6387 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6389 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6391 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6392 (Fx_get_selection_internal): Minor cleanup.
6393 (Fx_own_selection_internal): Rename arguments for consistency with
6396 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6398 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6400 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6402 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6404 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6406 * dispnew.c (scrolling_window): Don't exclude the case that the
6407 last enabled row in the desired matrix touches the bottom boundary.
6409 2011-05-21 Glenn Morris <rgm@gnu.org>
6411 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6412 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6413 and add some more files.
6415 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6417 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6418 report_file_error introduced by the change from 2011-05-07.
6420 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6422 * systime.h (Time): Define only if emacs is defined.
6423 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6424 where the include path doesn't have X11/X.h by default. See
6425 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6427 2011-05-20 Kenichi Handa <handa@m17n.org>
6429 * composite.c (find_automatic_composition): Fix previous change.
6431 2011-05-20 Glenn Morris <rgm@gnu.org>
6433 * lisp.mk: New file, split from Makefile.in.
6434 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6435 (shortlisp): Remove.
6436 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6438 2011-05-19 Glenn Morris <rgm@gnu.org>
6440 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6441 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6442 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6443 (lisp): Set the order to that of loadup.el.
6444 (shortlisp): Make it a copy of $lisp.
6445 (SOME_MACHINE_LISP): Remove.
6446 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6447 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6449 2011-05-18 Kenichi Handa <handa@m17n.org>
6451 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6452 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6453 (find_automatic_composition): Mostly rewrite for efficiency.
6455 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6457 * makefile.w32-in: Update dependencies.
6459 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6461 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6462 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6464 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6466 Fix some integer overflow issues, such as string length overflow.
6468 * insdel.c (count_size_as_multibyte): Check for string overflow.
6470 * character.c (lisp_string_width): Check for string overflow.
6471 Use EMACS_INT, not int, for string indexes and lengths; in
6472 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6473 the resulting string length overflows an EMACS_INT; instead,
6474 report a string overflow if no precision given. When checking for
6475 precision exhaustion, use a check that cannot possibly have
6476 integer overflow. (Bug#8675)
6477 * character.h (lisp_string_width): Adjust to new signature.
6479 * alloc.c (string_overflow): New function.
6480 (Fmake_string): Use it. This doesn't change behavior, but saves
6481 a few bytes and will simplify future changes.
6482 * character.c (string_escape_byte8): Likewise.
6483 * lisp.h (string_overflow): New decl.
6485 Fixups, following up to the user-interface timestamp change.
6486 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6487 for UI timestamps, instead of unsigned long.
6488 * msdos.c (mouse_get_pos): Likewise.
6489 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6490 * w32gui.h (Time): Define by including "systime.h" rather than by
6491 declaring it ourselves. (Bug#8664)
6493 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6494 * image.c (clear_image_cache): Likewise.
6496 * term.c (term_mouse_position): Don't assume time_t wraparound.
6498 Be more systematic about user-interface timestamps.
6499 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6500 and sometimes 'EMACS_UINT', to represent these timestamps.
6501 This change causes it to use 'Time' uniformly, as that's what X uses.
6502 This makes the code easier to follow, and makes it easier to catch
6503 integer overflow bugs such as Bug#8664.
6504 * frame.c (Fmouse_position, Fmouse_pixel_position):
6505 Use Time, not unsigned long, for user-interface timestamps.
6506 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6507 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6508 * keyboard.h (last_event_timestamp): Likewise.
6509 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6510 * menu.h (xmenu_show): Likewise.
6511 * term.c (term_mouse_position): Likewise.
6512 * termhooks.h (struct input_event.timestamp): Likewise.
6513 (struct terminal.mouse_position_hook): Likewise.
6514 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6515 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6516 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6517 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6519 * menu.h, termhooks.h: Include "systime.h", for Time.
6521 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6522 Don't assume that the difference between two unsigned long values
6523 can fit into an integer. At this point, we know button_down_time
6524 <= event->timestamp, so the difference must be nonnegative, so
6525 there's no need to cast the result if double-click-time is
6526 nonnegative, as it should be; check that it's nonnegative, just in
6527 case. This bug is triggered when events are more than 2**31 ms
6528 apart (about 25 days). (Bug#8664)
6530 * xselect.c (last_event_timestamp): Remove duplicate decl.
6531 (x_own_selection): Remove needless cast to unsigned long.
6533 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6534 that always fit in int. Use a sentinel instead of a counter, to
6535 avoid a temp and to allay GCC's concerns about possible int overflow.
6536 * frame.h (struct frame): Use int for menu_bar_items_used
6537 instead of EMACS_INT, since it always fits in int.
6539 * menu.c (grow_menu_items): Check for int overflow.
6541 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6543 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6544 Before, the code was not consistent. These values cannot exceed
6545 2**31 - 1 so there's no need to make them unsigned.
6546 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6547 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6548 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6550 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6552 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6553 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6554 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6555 presumably because the widths might not match.
6557 * window.c (size_window): Avoid needless test at loop start.
6559 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6561 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6563 2011-05-12 Drew Adams <drew.adams@oracle.com>
6565 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6567 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6569 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6570 `width' to `bar_area_x' and `bar_area_width', respectively.
6571 (x_scroll_run): Take account of fringe background extension.
6573 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6574 Rename local vars `left' and `width' to `bar_area_x' and
6575 `bar_area_width', respectively.
6576 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6577 background extension.
6579 2011-05-10 Jim Meyering <meyering@redhat.com>
6581 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6583 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6585 * image.c (Finit_image_library): Return t for built-in image types,
6586 like pbm and xbm. (Bug#8640)
6588 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6590 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6592 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6594 * w32console.c (Fset_screen_color): Doc fix.
6595 (Fget_screen_color): New function.
6596 (syms_of_ntterm): Defsubr it.
6598 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6599 unlink the temporary file if Fcall_process didn't create it in the
6601 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6602 child process will be redirected to a file specified with `:file'.
6603 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6604 cue to call_process_cleanup not to close that handle.
6606 2011-05-07 Ben Key <bkey76@gmail.com>
6608 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6609 one of two shell specific rules, either bootstrap-temacs-CMD or
6610 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6611 to the previous implementation of the bootstrap-temacs rule.
6612 The bootstrap-temacs-CMD rule is similar to the previous
6613 implementation of the bootstrap-temacs rule except that it
6614 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6617 These changes, along with some changes to nt/configure.bat,
6618 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6619 earlier fix to add support for --cflags and --ldflags options
6620 that include quotes so that it works whether make uses cmd or
6623 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6625 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6626 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6628 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6629 a string. Handle both cases.
6630 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6631 (Fdbus_register_method): Use Qinvalid_function.
6633 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6635 * makefile.w32-in: Update dependencies.
6636 (LISP_H): Add inttypes.h and stdin.h.
6637 (PROCESS_H): Add unistd.h.
6639 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6641 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6642 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6644 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6646 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6648 * term.c (vfatal): Remove stray call to va_end.
6649 It's not needed and the C Standard doesn't allow it here anyway.
6651 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6652 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6654 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6657 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6659 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6661 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6663 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6665 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6667 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6668 * charset.c (Fdefine_charset_internal): Don't initialize
6669 charset.code_space[15]. The value was garbage, on hosts with
6670 32-bit int (Bug#8600).
6672 * lread.c (read_integer): Be more consistent with string-to-number.
6673 Use string_to_number to do the actual conversion; this avoids
6674 rounding errors and fixes some other screwups. Without this fix,
6675 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6676 (digit_to_number): Move earlier, for benefit of read_integer.
6677 Return -1 if the digit is out of range for the base, -2 if it is
6678 not a digit in any supported base. (Bug#8602)
6680 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6682 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6683 to match comment at start of function. This also removes a
6684 GCC warning about overflow in a 32+64-bit port.
6686 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6688 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6689 Reported by Stefan Monnier in
6690 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6691 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6692 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6694 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6695 (EMACS_UINTPTR): Likewise, with uintptr_t.
6697 * lisp.h: Prefer 64-bit EMACS_INT if available.
6698 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6699 on 32-bit hosts that have 64-bit int, so that they can access
6701 However, temporarily disable this change unless the temporary
6702 symbol WIDE_EMACS_INT is defined.
6704 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6706 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6707 This removes an assumption that EMACS_INT and long are the same
6708 width as pointers. The assumption is true for Emacs porting targets
6709 now, but we want to make other targets possible.
6710 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6711 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6712 In the rest of the code, change types of integers that hold casted
6713 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6714 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6715 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6716 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6717 No need to cast type when ORing.
6718 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6719 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6720 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6721 assume EMACS_INT is the same width as char *.
6722 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6723 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6724 Remove no-longer-needed casts.
6725 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6726 (xg_tool_bar_help_callback, xg_make_tool_item):
6727 Use EMACS_INTPTR to hold an integer
6728 that will be cast to void *; this can avoid a GCC warning
6729 if EMACS_INT is not the same width as void *.
6730 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6731 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6732 (current_message_1, set_message_1):
6733 Use a local to convert to proper width without a cast.
6734 * xmenu.c (dialog_selection_callback): Likewise.
6736 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6737 Also, don't assume VALBITS / RAND_BITS is less than 5,
6738 and don't rely on undefined behavior when shifting a 1 left into
6740 * lisp.h (get_random): Change signature to match.
6742 * lread.c (hash_string): Use size_t, not int, for hash computation.
6743 Normally we prefer signed values; but hashing is special, because
6744 it's better to use unsigned division on hash table sizes so that
6745 the remainder is nonnegative. Also, size_t is the natural width
6746 for hashing into memory. The previous code used 'int', which doesn't
6747 retain enough info to hash well into very large tables.
6748 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6750 * dbusbind.c: Don't possibly lose pointer info when converting.
6751 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6752 Use XPNTR rather than XHASH, so that the high-order bits of
6753 the pointer aren't lost when converting through void *.
6755 * eval.c (Fautoload): Don't double-shift a pointer.
6757 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6759 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6761 * gnutls.c (DEF_GNUTLS_FN):
6762 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6764 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6766 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6769 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6771 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6772 New version that can reserve upto 2GB of heap space.
6774 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6776 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6778 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6780 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6781 `gnutls_certificate_set_x509_key_file'.
6783 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6785 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6786 Update dependencies.
6788 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6790 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6791 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6792 Remove unused parameter `fildes'.
6793 * process.c (read_process_output, send_process): Don't pass it.
6795 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6797 Fix previous change: the library cache is defined in w32.c.
6798 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6799 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6801 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6803 Implement dynamic loading of GnuTLS on Windows.
6805 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6806 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6807 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6810 * gnutls.c (Qgnutls_dll): Define.
6811 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6812 (gnutls_*): Declare function pointers.
6813 (init_gnutls_functions): New function to initialize function pointers.
6814 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6815 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6816 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6817 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6818 (emacs_gnutls_write, emacs_gnutls_read)
6819 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6820 (Fgnutls_available_p): New function.
6821 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6822 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6823 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6825 * image.c: Include w32.h.
6826 (Vimage_type_cache): Delete.
6827 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6828 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6829 (w32_delayed_load): Move to w32.c.
6831 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6833 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6834 (w32_delayed_load): Move from image.c. When loading a library, record
6835 its filename in the :loaded-from property of the library id.
6836 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6837 Initialize and staticpro them.
6838 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6840 * process.c: Include lisp.h before w32.h, not after.
6841 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6842 instead of gnutls_record_check_pending.
6844 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6846 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6848 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6849 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6852 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6854 * xterm.c (x_set_frame_alpha): Do not set property on anything
6855 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6857 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6859 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6861 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6863 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6864 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6865 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6866 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6867 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6868 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6869 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6870 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6871 (Qgnutls_bootprop_callbacks_verify): Make static.
6873 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6875 * callproc.c: Indentation fixup.
6877 * sysdep.c (wait_for_termination_1): Make static.
6878 (wait_for_termination, interruptible_wait_for_termination):
6879 Move after wait_for_termination_1.
6881 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6883 * sysdep.c (interruptible_wait_for_termination): New function
6884 which is like wait_for_termination, but allows keyboard
6887 * callproc.c (Fcall_process): Add (:file "file") as an option for
6889 (Fcall_process_region): Ditto.
6891 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6893 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6894 rather than `XVECTOR (FOO)->size'.
6896 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6897 inttypes.h, as a gnulib replacement is used if it not available in
6900 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6902 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6903 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6904 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6906 * coding.c (coding_alloc_by_realloc): Error out if destination
6907 will grow beyond MOST_POSITIVE_FIXNUM.
6908 (decode_coding_emacs_mule): Abort if there isn't enough place in
6909 charbuf for the composition carryover bytes. Reserve an extra
6910 space for up to 2 characters produced in a loop.
6911 (decode_coding_iso_2022): Abort if there isn't enough place in
6912 charbuf for the composition carryover bytes.
6914 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6916 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6917 aborting when %lld or %lll format is passed.
6918 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6919 %llo or %llx format is passed. (Bug#8545)
6921 * window.c (window_scroll_line_based): Use a marker instead of
6922 simple variables to record original value of point. (Bug#7952)
6924 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6925 produced by %s or %c overflows available buffer space. (Bug#8545)
6927 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6929 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6930 (SIZE_MAX): Move defn after all includes, as they might #define it.
6932 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6934 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6936 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6938 * keyboard.c (Qdelayed_warnings_hook): Define.
6939 (command_loop_1): Run `delayed-warnings-hook'
6940 if Vdelayed_warnings_list is non-nil.
6941 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6942 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6944 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6946 * doprnt.c (doprnt): Don't return value smaller than the buffer
6947 size if the message was truncated. (Bug#8545).
6949 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6951 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6952 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6954 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6956 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6958 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6960 * makefile.w32-in: Update dependencies.
6962 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6964 Improve `doprnt' and its usage. (Bug#8545)
6965 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6966 `format_end'. Remove support for %l as a conversion specifier.
6967 Don't use xrealloc. Improve diagnostics when the %l size modifier
6968 is used. Update the commentary.
6970 * eval.c (verror): Simplify calculation of size_t.
6972 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6975 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6977 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6980 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6982 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6983 This makes this file independent of the recent pseudovector change.
6985 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6987 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6989 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6990 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6991 Remove unused local.
6992 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6994 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6995 GCC 4.6.0 optimizes based on type-based alias analysis.
6996 For example, if b is of type struct buffer * and v of type struct
6997 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6998 != &v->size, and therefore "v->size = 1; b->size = 2; return
6999 v->size;" must therefore return 1. This assumption is incorrect
7000 for Emacs, since it type-puns struct Lisp_Vector * with many other
7001 types. To fix this problem, this patch adds a new type struct
7002 vectorlike_header that documents the constraints on layout of vectors
7003 and pseudovectors, and helps optimizing compilers not get fooled
7004 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7005 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7006 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7008 (XSETPVECTYPE): Rewrite in terms of new macro.
7009 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7010 This is a bit clearer, and further avoids the possibility of
7011 undesirable aliasing.
7012 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7013 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7014 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7015 since Lisp_Subr is a special case (no "next" field).
7016 (ASIZE): Now uses header.size rather than size.
7017 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7018 to avoid the hassle of writing XVECTOR (foo)->header.size.
7019 (struct vectorlike_header): New type.
7020 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7021 object, to help avoid aliasing.
7022 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7023 (SUBRP): Likewise, since Lisp_Subr is a special case.
7024 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7025 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7026 (struct Lisp_Hash_Table): Combine first two members into a single
7027 struct vectorlike_header member. All uses of "size" and "next" members
7028 changed to be "header.size" and "header.next".
7029 * buffer.h (struct buffer): Likewise.
7030 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7031 * frame.h (struct frame): Likewise.
7032 * process.h (struct Lisp_Process): Likewise.
7033 * termhooks.h (struct terminal): Likewise.
7034 * window.c (struct save_window_data, struct saved_window): Likewise.
7035 * window.h (struct window): Likewise.
7036 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7037 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7038 * buffer.c (init_buffer_once): Likewise.
7039 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7041 * process.c (Fformat_network_address): Use local var for size,
7044 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7046 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7047 * data.c (atof): Remove decl; no longer used or needed.
7048 (digit_to_number): Move to lread.c.
7049 (Fstring_to_number): Use new string_to_number function, to be
7050 consistent with how the Lisp reader treats infinities and NaNs.
7051 Do not assume that floating-point numbers represent EMACS_INT
7052 without losing information; this is not true on most 64-bit hosts.
7053 Avoid double-rounding errors, by insisting on integers when
7054 parsing non-base-10 numbers, as the documentation specifies.
7055 * lisp.h (string_to_number): New decl, replacing ...
7056 (isfloat_string): Remove.
7057 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7058 (read1): Do not accept +. and -. as integers; this
7059 appears to have been a coding error. Similarly, do not accept
7060 strings like +-1e0 as floating point numbers. Do not report
7061 overflow for integer overflows unless the base is not 10 which
7062 means we have no simple and reliable way to continue.
7063 Break out the floating-point parsing into a new
7064 function string_to_number, so that Fstring_to_number parses
7065 floating point numbers consistently with the Lisp reader.
7066 (digit_to_number): Move here from data.c. Make it static inline.
7067 (E_CHAR, EXP_INT): Remove, replacing with ...
7068 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7069 (string_to_number): New function, replacing isfloat_string.
7070 This function checks for valid syntax and produces the resulting
7071 Lisp float number too. Rework it so that string-to-number
7072 no longer mishandles examples like "1.0e+". Use strtoumax,
7073 so that overflow for non-base-10 numbers is reported only when
7074 there's no portable and simple way to convert to floating point.
7076 * textprop.c (set_text_properties_1): Rewrite for clarity,
7077 and to avoid GCC warning about integer overflow.
7079 * intervals.h (struct interval): Use EMACS_INT for members
7080 where EMACS_UINT might cause problems. See
7081 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7082 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7083 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7085 (offset_intervals): Tell GCC not to worry about length overflow
7086 when negating a negative length.
7088 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7089 (overrun_check_free): Likewise.
7091 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7092 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7095 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7096 (gnutls_make_error): Rename local to avoid shadowing.
7097 (gnutls_emacs_global_deinit): ifdef out; not used.
7098 (Fgnutls_boot): Use const for pointer to readonly storage.
7099 Comment out unused local. Fix pointer signedness problems.
7101 * lread.c (openp): Don't stuff size_t into an 'int'.
7102 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7103 about possible signed overflow.
7105 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7106 (GDK_KEY_g): Don't define if already defined.
7107 (xg_prepare_tooltip): Avoid pointer signedness problem.
7108 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7110 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7111 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7113 * xfns.c (Fx_window_property): Simplify a bit,
7114 to make a bit faster and to avoid GCC 4.6.0 warning.
7115 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7117 * fns.c (internal_equal): Don't assume size_t fits in int.
7119 * alloc.c (compact_small_strings): Tighten assertion a little.
7121 Replace pEd with more-general pI, and fix some printf arg casts.
7122 * lisp.h (pI): New macro, generalizing old pEd macro to other
7123 conversion specifiers. For example, use "...%"pI"d..." rather
7124 than "...%"pEd"...".
7125 (pEd): Remove. All uses replaced with similar uses of pI.
7126 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7127 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7128 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7129 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7130 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7131 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7132 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7134 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7135 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7136 * print.c (safe_debug_print, print_object): Likewise.
7137 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7139 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7140 avoiding the 0 flag, which is not portable.
7141 * process.c (Fmake_network_process): Use pI to avoid cast.
7142 * region-cache.c (pp_cache): Likewise.
7143 * xdisp.c (decode_mode_spec): Likewise.
7144 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7145 behavior on 64-bit hosts with printf arg.
7146 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7147 (x_stop_queuing_selection_requests): Likewise.
7148 (x_get_window_property): Don't truncate byte count to an 'int'
7151 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7152 here, since it parses constructs like leading '-' and spaces,
7153 which are not wanted; and it overflows with large numbers.
7154 Instead, simply match F[0-9]+, which is what is wanted anyway.
7156 * alloc.c: Remove unportable assumptions about struct layout.
7157 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7158 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7159 (allocate_vectorlike, make_pure_vector): Use the new macros,
7160 plus offsetof, to remove unportable assumptions about struct layout.
7161 These assumptions hold on all porting targets that I know of, but
7162 they are not guaranteed, they're easy to remove, and removing them
7163 makes further changes easier.
7165 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7166 This doesn't fix a bug but makes the code clearer.
7167 (string_overrun_cookie): Now const. Use initializers that
7168 don't formally overflow signed char, to avoid warnings.
7169 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7170 can cause Emacs to crash when string overrun checking is enabled.
7171 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7172 multiple of sizeof (EMACS_INT); it need not be, if
7173 alignof(EMACS_INT) < sizeof (EMACS_INT).
7174 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7176 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7178 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7180 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7182 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7183 supposed to be handshaking. (Bug#8556)
7184 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7186 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7188 * lisp.h (Qdebug): List symbol.
7189 * eval.c (Qdebug): Restore global linkage.
7190 * keyboard.c (debug-on-event): New variable.
7191 (handle_user_signal): Break into debugger when debug-on-event
7192 matches the current signal symbol.
7194 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7196 * alloc.c (check_sblock, check_string_bytes)
7197 (check_string_free_list): Convert to standard C.
7199 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7201 * w32.c (emacs_gnutls_push): Fix typo.
7203 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7205 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7206 "cast to pointer from integer of different size".
7208 Improve doprnt and its use in verror. (Bug#8545)
7209 * doprnt.c (doprnt): Document the set of format control sequences
7210 supported by the function. Use SAFE_ALLOCA instead of always
7213 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7214 is one byte too soon. Don't use xrealloc; instead xfree and
7217 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7219 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7222 * gnutls.c: Renamed global_initialized to
7223 gnutls_global_initialized. Added internals for the
7224 :verify-hostname-error, :verify-error, and :verify-flags
7225 parameters of `gnutls-boot' and documented those parameters in the
7226 docstring. Start callback support.
7227 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7228 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7229 on error. Return error code.
7230 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7231 (emacs_gnutls_read): Likewise.
7232 (Fgnutls_boot): Return handshake error code.
7233 (emacs_gnutls_handle_error): New function.
7234 (wsaerror_to_errno): Likewise.
7236 * w32.h (emacs_gnutls_pull): Add prototype.
7237 (emacs_gnutls_push): Likewise.
7239 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7240 (emacs_gnutls_push): Likewise.
7242 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7244 * process.c (wait_reading_process_output): Check if GnuTLS
7245 buffered some data internally if no FDs are set for TLS
7248 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7249 (LIBS): Link to USER_LIBS.
7250 ($(BLD)/gnutls.$(0)): New target.
7252 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7254 * xdisp.c (handle_single_display_spec): Rename the
7255 display_replaced_before_p argument into display_replaced_p, to
7256 make it consistent with the commentary. Fix typos in the
7259 * textprop.c (syms_of_textprop): Remove dead code.
7260 (copy_text_properties): Delete obsolete commentary about an
7261 interface that was deleted long ago. Fix typos in the description
7264 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7265 to changes in oldXMenu/XMenu.h from 2011-04-16.
7266 <menu_help_message, prev_menu_help_message>: Constify.
7267 (IT_menu_make_room): menu->help_text is now `const char **';
7270 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7271 to changes in oldXMenu/XMenu.h from 2011-04-16.
7272 (struct XMenu): Declare `help_text' `const char **'.
7274 * xfaces.c <Qunspecified>: Make extern again.
7276 * syntax.c: Include sys/types.h before including regex.h, as
7279 * doc.c (get_doc_string): Improve the format passed to `error'.
7281 * doprnt.c (doprnt): Improve commentary.
7283 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7285 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7288 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7289 changes in globals.h immediately force recompilation.
7290 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7291 $(CURDIR)/s/ms-w32.h.
7292 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7294 * character.c (Fchar_direction): Function deleted.
7295 (syms_of_character): Don't defsubr it.
7296 <char-direction-table>: Deleted.
7298 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7300 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7301 * doprnt.c: Include limits.h.
7302 (SIZE_MAX): New macro.
7303 (doprnt): Return a size_t value. 2nd arg is now size_t.
7304 Many local variables are now size_t instead of int or unsigned.
7305 Improve overflow protection. Support `l' modifier for integer
7306 conversions. Support %l conversion. Don't assume an EMACS_INT
7307 argument for integer conversions and for %c.
7309 * lisp.h (doprnt): Restore prototype.
7311 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7314 * Makefile.in (base_obj): Add back doprnt.o.
7316 * deps.mk (doprnt.o): Add back prerequisites.
7317 (callint.o): Depend on character.h.
7319 * eval.c (internal_lisp_condition_case): Include the handler
7320 representation in the error message.
7321 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7322 when breaking from the loop.
7324 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7326 * callint.c (Fcall_interactively): When displaying error message
7327 about invalid control letter, pass the character's codepoint, not
7328 a pointer to its multibyte form. Improve display of the character
7329 in octal and display also its hex code.
7331 * character.c (char_string): Use %x to display the (unsigned)
7332 codepoint of an invalid character, to avoid displaying a bogus
7335 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7336 `error', not SYMBOL_NAME itself.
7338 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7339 character arguments to `error'.
7341 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7342 to `error' in error message about FINAL_CHAR argument. Make sure
7343 FINAL_CHAR is a character, and use %c when it is passed as
7344 argument to `error'.
7346 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7348 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7350 * w32.c: Include <time.h>.
7351 (sys_localtime): New function.
7353 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7355 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7357 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7359 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7361 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7364 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7366 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7367 gl_state.e_property when gl_state.object is Qt.
7369 * insdel.c (make_gap_larger): Remove limitation of buffer size
7372 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7374 * xdisp.c (lookup_glyphless_char_display)
7375 (produce_glyphless_glyph): Handle cons cell entry in
7376 glyphless-char-display.
7377 (Vglyphless_char_display): Document it.
7379 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7380 glyphless-char-display.
7382 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7384 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7386 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7388 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7389 definition for no-X builds.
7391 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7393 Static checks with GCC 4.6.0 and non-default toolkits.
7395 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7397 * process.c (keyboard_bit_set): Define only if SIGIO.
7398 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7399 (send_process): Repair possible setjmp clobbering.
7401 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7403 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7405 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7407 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7408 Define only if needed.
7410 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7411 by pacifying GCC about it. Maybe it's time to retire it?
7412 * xfaces.c (USG, __TIMEVAL__): Likewise.
7414 * dispextern.h (struct redisplay_interface): Rename param
7416 * termhooks.h (struct terminal): Likewise.
7417 * xterm.c (xembed_send_message): Likewise.
7419 * insdel.c (make_gap_smaller): Define only if
7420 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7422 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7425 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7426 so that we aren't warned about unused symbols.
7428 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7430 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7432 * xfns.c (x_real_positions): Mark locals as initialized.
7434 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7436 * xterm.c: Fix problems found by static analysis with other toolkits.
7437 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7438 (x_dispatch_event): Declare static if USE_GTK, and
7439 define if USE_GTK || USE_X_TOOLKIT.
7440 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7441 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7442 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7443 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7445 * xmenu.c (menu_help_callback): Pointer type fixes.
7446 Use const pointers when pointing at readonly data. Avoid pointer
7448 (FALSE): Remove unused macro.
7449 (update_frame_menubar): Remove unused decl.
7451 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7453 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7454 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7455 (single_menu_item): Rename local to avoid shadowing.
7457 * keyboard.c (make_lispy_event): Remove unused local var.
7459 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7460 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7462 * bitmaps: Change bitmaps from unsigned char back to the X11
7463 compatible char. Avoid the old compiler warnings about
7464 out-of-range initializers by using, for example, '\xab' rather
7467 * xgselect.c (xgselect_initialize): Check vs interface
7468 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7470 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7472 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7473 to read-only memory.
7475 * fns.c (vector): Remove; this old hack is no longer needed.
7477 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7479 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7481 * xrdb.c (x_load_resources): Omit unused local.
7483 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7484 (x_window): Rename locals to avoid shadowing.
7485 (USG): Use the kludged USG macro, to pacify gcc.
7487 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7488 (x_term_init): Remove local to avoid shadowing.
7490 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7492 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7493 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7495 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7497 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7499 Fix regex.c, syntax.c and friends for buffers > 2GB.
7500 * syntax.h (struct gl_state_s): Declare character position members
7503 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7505 * textprop.c (verify_interval_modification, interval_of):
7506 Declare arguments EMACS_INT.
7508 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7511 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7513 * indent.c (Fvertical_motion): Local variable it_start is now
7516 * regex.c (re_match, re_match_2, re_match_2_internal)
7517 (bcmp_translate, regcomp, regexec, print_double_string)
7518 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7519 (re_compile_pattern, re_exec): Declare arguments and local
7520 variables `size_t' and `ssize_t' and return values `regoff_t', as
7522 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7523 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7524 <compile_stack_type>: `size' and `avail' are now `size_t'.
7526 * regex.h <regoff_t>: Use ssize_t, not int.
7527 (re_search, re_search_2, re_match, re_match_2): Arguments that
7528 specify buffer/string position and length are now ssize_t and
7529 size_t. Return type is regoff_t.
7531 2011-04-16 Ben Key <bkey76@gmail.com>
7533 * nsfont.m: Fixed bugs in ns_get_family and
7534 ns_descriptor_to_entity that were caused by using free to
7535 deallocate memory blocks that were allocated by xmalloc (via
7536 xstrdup). This caused Emacs to crash when compiled with
7537 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7538 --enable-checking=xmallocoverrun). xfree is now used to
7539 deallocate these memory blocks.
7541 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7543 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7545 emacs_write: Accept and return EMACS_INT for sizes.
7546 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7548 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7549 Accept and return EMACS_INT.
7550 (emacs_gnutls_write): Return the number of bytes written on
7552 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7553 (emacs_read, emacs_write): Remove check for negative size, as the
7554 Emacs source code has been audited now.
7555 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7556 (emacs_read, emacs_write): Use it.
7557 * process.c (send_process): Adjust to the new signatures of
7558 emacs_write and emacs_gnutls_write. Do not attempt to store
7559 a byte offset into an 'int'; it might overflow.
7560 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7562 * sound.c: Don't assume sizes fit in 'int'.
7563 (struct sound_device.period_size, alsa_period_size):
7564 Return EMACS_INT, not int.
7565 (struct sound_device.write, vox_write, alsa_write):
7566 Accept EMACS_INT, not int.
7567 (wav_play, au_play): Use EMACS_INT to store sizes and to
7568 record read return values.
7570 2011-04-15 Ben Key <bkey76@gmail.com>
7572 * keyboard.c (Qundefined): Don't declare static since it is used
7574 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7575 static since they are used in nsfont.m.
7577 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7579 * process.c (Qprocessp): Don't declare static.
7580 * lisp.h (Qprocessp): Declare again.
7582 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7584 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7586 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7588 Improve C-level modularity by making more things 'static'.
7590 Don't publish debugger-only interfaces to other modules.
7591 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7592 (verify_bytepos, count_markers): Move decls to the only modules
7594 * region-cache.h (pp_cache): Likewise.
7595 * window.h (check_all_windows): Likewise.
7596 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7598 * sysdep.c (croak): Now static, if
7599 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7600 * syssignal.h (croak): Declare only if not static.
7602 * alloc.c (refill_memory_reserve): Now static if
7603 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7604 * lisp.h (refill_memory_reserve): Declare only if not static.
7606 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7607 Define only if USE_LUCID.
7609 * xrdb.c (x_customization_string, x_rm_string): Now static.
7611 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7612 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7614 * xdisp.c (draw_row_with_mouse_face): Now static.
7615 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7617 * window.h (check_all_windows): Mark externally visible.
7619 * window.c (window_deletion_count): Now static.
7621 * undo.c: Make symbols static if they're not exported.
7622 (last_undo_buffer, last_boundary_position, pending_boundary):
7625 * textprop.c (interval_insert_behind_hooks): Now static.
7626 (interval_insert_in_front_hooks): Likewise.
7628 * term.c: Make symbols static if they're not exported.
7629 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7630 (max_frame_lines, tty_set_terminal_modes):
7631 (tty_reset_terminal_modes, tty_turn_off_highlight):
7632 (get_tty_terminal): Now static.
7633 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7634 * termhooks.h (term_mouse_moveto): Do not declare if
7636 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7637 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7639 * sysdep.c: Make symbols static if they're not exported.
7640 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7642 (sigprocmask_set, full_mask): Remove; unused.
7643 (wait_debugging): Mark as visible.
7644 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7645 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7647 * syntax.c (syntax_temp): Define only if !__GNUC__.
7649 * sound.c (current_sound_device, current_sound): Now static.
7651 * search.c (searchbufs, searchbuf_head): Now static.
7653 * scroll.c (scroll_cost): Remove; unused.
7654 * dispextern.h (scroll_cost): Remove decl.
7656 * region-cache.h (pp_cache): Mark as externally visible.
7658 * process.c: Make symbols static if they're not exported.
7659 (process_tick, update_tick, create_process, chan_process):
7660 (Vprocess_alist, proc_buffered_char, datagram_access):
7661 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7662 (deactivate_process): Mark defn as static, as well as decl.
7663 * lisp.h (create_process): Remove decl.
7664 * process.h (chan_process, Vprocess_alist): Remove decls.
7666 * print.c: Make symbols static if they're not exported.
7667 (print_depth, new_backquote_output, being_printed, print_buffer):
7668 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7669 (print_interval, print_number_index, initial_stderr_stream):
7671 * lisp.h (Fprinc): Remove decl.
7672 (debug_output_compilation_hack): Mark as externally visible.
7674 * sysdep.c (croak): Move decl from here to syssignal.h.
7675 * syssignal.h (croak): Put it here, so the API can be checked when
7676 'croak' is called from dissociate_if_controlling_tty.
7678 * minibuf.c: Make symbols static if they're not exported.
7679 (minibuf_save_list, choose_minibuf_frame): Now static.
7680 * lisp.h (choose_minibuf_frame): Remove decl.
7682 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7684 * lread.c: Make symbols static if they're not exported.
7685 (read_objects, initial_obarray, oblookup_last_bucket_number):
7687 (make_symbol): Remove; unused.
7688 * lisp.h (initial_obarray, make_symbol): Remove decls.
7690 * keyboard.c: Make symbols static if they're not exported.
7691 (single_kboard, recent_keys_index, total_keys, recent_keys):
7692 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7693 (this_single_command_key_start, echoing, last_auto_save):
7694 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7695 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7696 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7697 (Vlispy_mouse_stem, double_click_count):
7699 (force_auto_save_soon): Define only if SIGDANGER.
7700 (ignore_mouse_drag_p): Now static if
7701 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7702 (print_help): Remove; unused.
7703 (stop_character, last_timer_event): Mark as externally visible.
7704 * keyboard.h (ignore_mouse_drag_p): Declare only if
7705 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7706 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7707 * lisp.h (echoing): Remove decl.
7708 (force_auto_save_soon): Declare only if SIGDANGER.
7709 * xdisp.c (redisplay_window): Simplify code, to make it more
7710 obvious that ignore_mouse_drag_p is not accessed if !defined
7711 USE_GTK && !defined HAVE_NS.
7713 * intervals.c: Make symbols static if they're not exported.
7714 (merge_properties_sticky, merge_interval_right, delete_interval):
7716 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7718 * insdel.c: Make symbols static if they're not exported.
7719 However, leave prepare_to_modify_buffer alone. It's never
7720 called from outside this function, but that appears to be a bug.
7721 (combine_after_change_list, combine_after_change_buffer):
7722 (adjust_after_replace, signal_before_change): Now static.
7723 (adjust_after_replace_noundo): Remove; unused.
7724 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7725 (signal_before_change): Remove decls.
7727 * indent.c (val_compute_motion, val_vmotion): Now static.
7729 * image.c: Make symbols static if they're not exported.
7730 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7732 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7733 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7735 * fringe.c (standard_bitmaps): Now static.
7736 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7738 * frame.c: Make symbols static if they're not exported.
7739 (x_report_frame_params, make_terminal_frame): Now static.
7740 (get_frame_param): Now static, unless HAVE_NS.
7741 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7742 (x_get_resource_string): Remove; not used.
7743 * frame.h (make_terminal_frame, x_report_frame_params):
7744 (x_get_resource_string); Remove decls.
7745 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7746 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7748 * font.c, fontset.c: Make symbols static if they're not exported.
7749 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7750 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7751 * font.c (font_close_object): Now static.
7752 * font.h (font_close_object): Remove.
7753 * fontset.c (FONTSET_OBJLIST): Remove.
7754 (free_realized_fontset) #if-0 the body, which does nothing.
7755 (face_suitable_for_char_p): #if-0, as it's never called.
7756 * fontset.h (face_suitable_for_char_p): Remove decl.
7757 * xfaces.c (face_at_string_position):
7758 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7759 since 0 is always ASCII.
7761 * fns.c (weak_hash_tables): Now static.
7763 * fileio.c: Make symbols static if they're not exported.
7764 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7765 (Vwrite_region_annotation_buffers): Now static.
7767 * eval.c: Make symbols static if they're not exported.
7768 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7769 * lisp.h (backtrace_list): Remove decl.
7771 * emacs.c: Make symbols static if they're not exported.
7772 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7773 (fatal_error_code, fatal_error_signal_hook, standard_args):
7775 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7776 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7777 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7778 * lisp.h (fatal_error_signal_hook): Remove decl.
7779 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7781 * editfns.c: Move a (normally-unused) function to its only use.
7782 * editfns.c, lisp.h (get_operating_system_release): Remove.
7783 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7784 worth the hassle of breaking this out.
7786 * xterm.c: Make symbols static if they're not exported.
7787 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7788 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7789 (x_destroy_window, x_delete_display):
7791 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7792 (x_mouse_leave): Remove; unused.
7793 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7794 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7795 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7797 (x_mouse_leave): Declare only if WINDOWSNT.
7798 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7799 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7802 * ftxfont.c: Make symbols static if they're not exported.
7803 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7805 * font.h (ftxfont_driver): Likewise.
7807 * xfns.c: Make symbols static if they're not exported.
7808 (x_last_font_name, x_display_info_for_name):
7809 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7810 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7811 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7812 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7813 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7814 (last_show_tip_args): Now static.
7815 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7816 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7817 (x_screen_planes): Remove; unused.
7818 * dispextern.h (x_screen_planes): Remove decl.
7820 * dispnew.c: Make symbols static if they're not exported.
7821 * dispextern.h (redraw_garbaged_frames, scrolling):
7822 (increment_row_positions): Remove.
7823 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7824 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7826 (redraw_garbaged_frames): Remove; unused.
7828 * xfaces.c: Make symbols static if they're not exported.
7829 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7831 * xterm.h (defined_color): Remove decls.
7832 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7833 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7834 (menu_face_changed_default, defined_color, free_realized_face):
7835 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7836 (ascii_face_of_lisp_face): Remove; unused.
7838 * xdisp.c: Make symbols static if they're not exported.
7839 * dispextern.h (scratch_glyph_row, window_box_edges):
7840 (glyph_to_pixel_coords, set_cursor_from_row):
7841 (get_next_display_element, set_iterator_to_next):
7842 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7843 (show_mouse_face): Remove decls
7844 * frame.h (message_buf_print): Likewise.
7845 * lisp.h (pop_message, set_message, check_point_in_composition):
7847 * xterm.h (set_vertical_scroll_bar): Likewise.
7848 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7849 (message_buf_print, scratch_glyph_row, displayed_buffer):
7850 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7851 (get_next_display_element, show_mouse_face, window_box_edges):
7852 (frame_to_window_pixel_xy, check_point_in_composition):
7853 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7854 (glyph_to_pixel_coords): Remove; unused.
7856 * dired.c (file_name_completion): Now static.
7858 * dbusbind.c (xd_in_read_queued_messages): Now static.
7860 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7861 * data.c (circular_list_error): Remove.
7863 * commands.h (last_point_position, last_point_position_buffer):
7864 (last_point_position_window): Remove decls.
7865 * keyboard.c: Make these variables static.
7867 * coding.h (coding, code_convert_region, encode_coding_gap):
7869 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7870 (iso_code_class, detect_coding, code_convert_region): Now static.
7871 (encode_coding_gap): Remove; unused.
7873 * chartab.c (chartab_chars, chartab_bits): Now static.
7875 * charset.h (charset_iso_8859_1): Remove decl.
7876 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7879 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7880 * ccl.c (Vccl_program_table): Now static.
7881 (check_ccl_update): Remove; unused.
7883 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7884 * category.h: ... from here.
7885 * category.c (check_category_table, set_category_set): Now static.
7887 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7888 * lisp.h: Remove these decls.
7890 * buffer.c (buffer_count): Remove unused var.
7892 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7893 so that it's not optimized away.
7894 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7895 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7896 exported only to the debugger.
7898 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7899 * atimer.h (run_all_atimers): Remove; not exported.
7901 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7902 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7903 was inaccessible from Lisp.
7904 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7905 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7907 alloc.c: Import and export fewer symbols, and remove unused items.
7908 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7910 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7911 it's not optimized away by whole-program optimization.
7912 (message_enable_multibyte, free_misc): Remove.
7913 (catchlist, handlerlist, mark_backtrace):
7914 Declare only if BYTE_MARK_STACK.
7915 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7916 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7917 (message_enable_multibyte): Remove decl.
7918 (free_misc, interval_free_list, float_block, float_block_index):
7919 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7920 (cons_free_list, last_marked_index):
7922 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7923 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7924 (mark_backtrace): Define only if BYTE_MARK_STACK.
7925 * xdisp.c (message_enable_multibyte): Now static.
7927 Declare Lisp_Object Q* variables to be 'static' if not exported.
7928 This makes it easier for human readers (and static analyzers)
7929 to see whether these variables are used from other modules.
7930 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7931 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7932 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7933 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7934 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7935 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7936 * xmenu.c, xselect.c:
7937 Declare Q* vars static if they are not used in other modules.
7938 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7939 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7940 Remove decls of unexported vars.
7941 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7943 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7945 Make Emacs functions such as Fatom 'static' by default.
7946 This makes it easier for human readers (and static analyzers)
7947 to see whether these functions can be called from other modules.
7948 DEFUN now defines a static function. To make the function external
7949 so that it can be used in other C modules, use the new macro DEFUE.
7950 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7951 (Finit_image_library):
7952 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7953 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7954 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7955 Remove decls, since these functions are now static.
7956 (Funintern, Fget_internal_run_time): New decls, since these functions
7957 were already external.
7959 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7960 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7961 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7962 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7963 * keyboard.c, keymap.c, lread.c:
7964 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7965 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7966 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7967 Mark functions with DEFUE instead of DEFUN,
7968 if they are used in other modules.
7969 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7970 decls for now-static functions.
7971 * buffer.h (Fdelete_overlay): Remove decl.
7972 * callproc.c (Fgetenv_internal): Mark as internal.
7973 * composite.c (Fremove_list_of_text_properties): Remove decl.
7974 (Fcomposition_get_gstring): New forward static decl.
7975 * composite.h (Fcomposite_get_gstring): Remove decl.
7976 * dired.c (Ffile_attributes): New forward static decl.
7977 * doc.c (Fdocumntation_property): New forward static decl.
7978 * eval.c (Ffetch_bytecode): New forward static decl.
7979 (Funintern): Remove extern decl; now in .h file where it belongs.
7980 * fileio.c (Fmake_symbolic_link): New forward static decl.
7981 * image.c (Finit_image_library): New forward static decl.
7982 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7983 * intervals.h (Fprevious_property_change):
7984 (Fremove_list_of_text_properties): Remove decls.
7985 * keyboard.c (Fthis_command_keys): Remove decl.
7986 (Fcommand_execute): New forward static decl.
7987 * keymap.c (Flookup_key): New forward static decl.
7988 (Fcopy_keymap): Now static.
7989 * keymap.h (Flookup_key): Remove decl.
7990 * process.c (Fget_process): New forward static decl.
7991 (Fprocess_datagram_address): Mark as internal.
7992 * syntax.c (Fsyntax_table_p): New forward static decl.
7993 (skip_chars): Remove duplicate decl.
7994 * textprop.c (Fprevious_property_change): New forward static decl.
7995 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7997 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7998 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8000 * editfns.c (Fformat): Remove unreachable code.
8002 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8004 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8007 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8009 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8010 when at ZV. (Bug#8487)
8012 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8014 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8016 * keyboard.c (parse_tool_bar_item): Likewise.
8017 * sound.c (sound_cleanup, alsa_close): Likewise.
8018 * termcap.c (tgetent): Likewise.
8019 * xfns.c (x_default_font_parameter): Likewise.
8020 * xsettings.c (read_and_apply_settings): Likewise.
8022 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8023 (overrun_check_free): Protoize.
8025 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8027 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8028 since callers should never pass a negative size.
8029 Change the signature to match that of plain 'read' and 'write'; see
8030 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8031 * lisp.h: Update prototypes of emacs_write and emacs_read.
8033 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8035 * xdisp.c (redisplay_window): Don't try to determine the character
8036 position of the scroll margin if the window start point w->startp
8037 is outside the buffer's accessible region. (Bug#8468)
8039 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8041 Fix write-region and its subroutines for buffers > 2GB.
8042 * fileio.c (a_write, e_write): Modify declaration of arguments and
8043 local variables to support buffers larger than 2GB.
8044 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8046 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8047 argument, local variables, and return value.
8049 * lisp.h: Update prototypes of emacs_write and emacs_read.
8051 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8053 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8055 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8057 Fix more problems found by GCC 4.6.0's static checks.
8059 * xdisp.c (vmessage): Use a better test for character truncation.
8061 * charset.c (load_charset_map): <, not <=, for optimization,
8062 and to avoid potential problems with integer overflow.
8063 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8064 * casetab.c (set_identity, shuffle): Likewise.
8065 * editfns.c (Fformat): Likewise.
8066 * syntax.c (skip_chars): Likewise.
8068 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8069 This also lets GCC 4.6.0 generate slightly better loop code.
8071 * callint.c (Fcall_interactively): <, not <=, for optimization.
8072 (Fcall_interactively): Count the number of arguments produced,
8073 not the number of arguments given. This is simpler and lets GCC
8074 4.6.0 generate slightly better code.
8076 * ftfont.c: Distingish more carefully between FcChar8 and char.
8077 The previous code passed unsigned char * to a functions like
8078 strlen and xstrcasecmp that expect char *, which does not
8079 conform to the C standard.
8080 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8081 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8082 char * when the C standard requires it.
8084 * keyboard.c (read_char): Remove unused var.
8086 * eval.c: Port to Windows vsnprintf (Bug#8435).
8088 (SIZE_MAX): Define if the headers do not.
8089 (verror): Do not give up if vsnprintf returns a negative count.
8090 Instead, grow the buffer. This ports to Windows vsnprintf, which
8091 does not conform to C99. Problem reported by Eli Zaretskii.
8092 Also, simplify the allocation scheme, by avoiding the need for
8093 calling realloc, and removing the ALLOCATED variable.
8095 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8097 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8098 But keep the doprint source code for now, as we might revamp it
8099 and use it again (Bug#8435).
8100 * lisp.h (doprnt): Remove.
8101 * Makefile.in (base_obj): Remove doprnt.o.
8102 * deps.mk (doprnt.o): Remove.
8104 error: Print 32- and 64-bit integers portably (Bug#8435).
8105 Without this change, on typical 64-bit hosts error ("...%d...", N)
8106 was used to print both 32- and 64-bit integers N, which relied on
8108 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8109 * lisp.h (error, verror): Mark as printf-like functions.
8110 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8111 Report overflow in size calculations when allocating printf buffer.
8112 Do not truncate output string at its first null byte.
8113 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8114 Truncate the output at a character boundary, since vsnprintf does not
8116 * charset.c (check_iso_charset_parameter): Convert internal
8117 character to string before calling 'error', since %c now has the
8119 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8120 overflow when computing char to be passed to 'error'. Do not
8121 pass Lisp_Object to 'error'; pass the integer instead.
8122 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8123 formatted with plain %d.
8125 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8127 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8129 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8131 * xterm.c (x_catch_errors): Remove duplicate declaration.
8133 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8135 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8137 2011-04-10 Jim Meyering <meyering@redhat.com>
8139 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8140 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8141 return ssize_t not "int", and use size_t as the buffer length.
8142 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8143 * gnutls.h: Update declarations.
8144 * process.c (read_process_output): Use ssize_t, to match.
8145 (send_process): Likewise.
8147 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8149 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8151 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8153 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8154 Use unsigned char, to match FcChar8 type definition.
8156 * xterm.c (handle_one_xevent):
8157 * xmenu.c (create_and_show_popup_menu):
8158 * xselect.c (x_decline_selection_request)
8159 (x_reply_selection_request): Avoid type-punned deref of X events.
8161 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8163 Fix some uses of `int' instead of EMACS_INT.
8164 * search.c (string_match_1, fast_string_match)
8165 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8166 (scan_buffer, find_next_newline_no_quit)
8167 (find_before_next_newline, search_command, Freplace_match)
8168 (Fmatch_data): Make some `int' variables be EMACS_INT.
8170 * xdisp.c (display_count_lines): 3rd argument and return value now
8171 EMACS_INT. All callers changed.
8172 (pint2hrstr): Last argument is now EMACS_INT.
8174 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8175 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8176 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8177 (decode_coding_utf_16, decode_coding_emacs_mule)
8178 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8179 (decode_coding_ccl, decode_coding_charset)
8180 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8181 (decode_coding_iso_2022, decode_coding_emacs_mule)
8182 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8183 <char_offset, last_offset>: Declare EMACS_INT.
8184 (encode_coding_utf_8, encode_coding_utf_16)
8185 (encode_coding_emacs_mule, encode_invocation_designation)
8186 (encode_designation_at_bol, encode_coding_iso_2022)
8187 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8188 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8190 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8191 (encode_invocation_designation): Last argument P_NCHARS is now
8193 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8194 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8196 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8199 * ccl.c (Fccl_execute_on_string): Declare some variables
8202 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8204 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8206 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8208 * process.c (Fformat_network_address): Doc fix.
8210 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8212 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8214 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8216 * keyboard.c (read_char): Call Lisp function help-form-show,
8217 instead of using internal_with_output_to_temp_buffer.
8218 (Qhelp_form_show): New var.
8219 (syms_of_keyboard): Use DEFSYM macro.
8221 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8223 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8225 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8227 * process.c (Flist_processes): Remove to Lisp.
8228 (list_processes_1): Delete.
8230 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8232 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8234 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8236 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8238 Fix more problems found by GCC 4.6.0's static checks.
8240 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8242 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8244 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8246 * xdisp.c (vmessage): Mark as a printf-like function.
8248 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8250 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8252 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8253 printf-like functions.
8254 (tiff_load): Add casts to remove these marks before passing them
8255 to system-supplied API.
8257 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8259 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8260 This avoids several warnings with gcc -Wstrict-overflow.
8261 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8262 directly, rather than having caller test rule sign. This avoids
8263 some unnecessary tests.
8264 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8265 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8266 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8268 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8269 (xfont_open): Avoid unnecessary tests.
8271 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8273 * composite.h, composite.c (composition_gstring_put_cache):
8274 Use EMACS_INT, not int, for length.
8276 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8277 breaking out part of COMPOSITION_DECODE_RULE.
8278 (COMPOSITION_DECODE_RULE): Use it.
8279 * composite.c (get_composition_id): Remove unused local vars,
8280 by using the new macro.
8282 * textprop.c (set_text_properties_1): Change while to do-while,
8283 since the condition is always true at first.
8285 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8286 (interval_deletion_adjustment): Return unsigned value.
8289 * process.c (list_processes_1, create_pty, read_process_output):
8290 (exec_sentinel): Remove vars that were set but not used.
8291 (create_pty): Remove unnecessary "volatile"s.
8292 (Fnetwork_interface_info): Avoid possibility of int overflow.
8293 (read_process_output): Do adaptive read buffering even if carryover.
8294 (read_process_output): Simplify nbytes computation if buffered.
8296 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8298 * syntax.c (scan_words): Remove var that was set but not used.
8299 (update_syntax_table): Use unsigned instead of int.
8301 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8302 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8303 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8305 * print.c (print_error_message): Avoid int overflow.
8307 * font.c (font_list_entities): Redo for clarity,
8308 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8310 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8311 (font_score): Avoid potential overflow in diff calculation.
8313 * fns.c (substring_both): Remove var that is set but not used.
8314 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8316 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8318 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8319 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8320 can always succeed if overflow has undefined behavior.
8322 * search.c (boyer_moore, wordify): Remove vars set but not used.
8323 (wordify): Omit three unnecessary tests.
8325 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8326 All callers changed. This avoids the need for an unused var.
8328 * casefiddle.c (casify_region): Remove var that is set but not used.
8330 * dired.c (file_name_completion): Remove var that is set but not used.
8332 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8334 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8335 (Finsert_file_contents): Remove unnecessary code checking fd.
8337 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8338 Check for integer overflow on size calculations.
8340 * buffer.c (Fprevious_overlay_change): Remove var that is set
8343 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8344 Remove vars that are set but not used.
8345 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8346 (timer_check_2): Mark vars as initialized.
8348 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8350 * image.c (lookup_image): Remove var that is set but not used.
8351 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8353 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8354 that are set but not used.
8356 * xfns.c (make_invisible_cursor): Don't return garbage
8357 if XCreateBitmapFromData fails (Bug#8410).
8359 * xselect.c (x_get_local_selection, x_handle_property_notify):
8360 Remove vars that are set but not used.
8362 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8363 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8365 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8366 Remove var that is set but not used.
8367 (scroll_bar_windows_size): Now size_t, not int.
8368 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8371 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8372 (map_tty_color) [!defined MSDOS]: Likewise.
8374 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8376 * coding.c: Remove vars that are set but not used.
8377 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8378 All callers changed.
8379 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8380 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8381 (decode_coding_charset): Remove vars that are set but not used.
8383 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8384 that is set but not used.
8386 * print.c (print_object): Remove var that is set but not used.
8388 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8389 The gnulib version avoids calling malloc in the usual case,
8390 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8391 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8392 * filelock.c (current_lock_owner): Likewise.
8393 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8394 * sysdep.c: Include allocator.h, careadlinkat.h.
8395 (emacs_no_realloc_allocator): New static constant.
8396 (emacs_readlink): New function.
8397 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8398 ../lib/careadlinkat.h.
8400 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8402 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8403 first non-nil return value).
8405 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8407 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8408 if not defined (Bug#8403).
8410 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8412 * xdisp.c (display_count_lines): Remove parameter `start',
8413 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8414 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8415 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8416 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8417 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8418 and thereabouts. All callers changed.
8419 (get_per_char_metric): Remove parameter `f', unused since
8420 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8422 2011-04-02 Jim Meyering <meyering@redhat.com>
8424 do not dereference NULL upon failed strdup
8425 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8426 (ns_get_family): Likewise.
8428 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8430 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8432 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8434 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8437 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8439 Add lexical binding.
8441 * window.c (Ftemp_output_buffer_show): New fun.
8442 (Fsave_window_excursion):
8443 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8445 * lread.c (lisp_file_lexically_bound_p): New function.
8446 (Fload): Bind Qlexical_binding.
8447 (readevalloop): Remove `evalfun' arg.
8448 Bind Qinternal_interpreter_environment.
8449 (Feval_buffer): Bind Qlexical_binding.
8450 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8452 (syms_of_lread): Declare `lexical-binding'.
8454 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8456 * keyboard.c (eval_dyn): New fun.
8457 (menu_item_eval_property): Use it.
8459 * image.c (parse_image_spec): Use Ffunctionp.
8461 * fns.c (concat, mapcar1): Accept byte-code-functions.
8463 * eval.c (Fsetq): Handle lexical vars.
8464 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8465 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8466 (FletX, Flet): Obey lexical binding.
8467 (Fcommandp): Handle closures.
8468 (Feval): New `lexical' arg.
8469 (eval_sub): New function extracted from Feval. Use it almost
8470 everywhere where Feval was used. Look up vars in lexical env.
8472 (Ffunctionp): Move from subr.el.
8473 (Ffuncall): Handle closures.
8474 (apply_lambda): Remove `eval_flags'.
8475 (funcall_lambda): Handle closures and new byte-code-functions.
8476 (Fspecial_variable_p): New function.
8477 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8478 but without exporting it to Lisp.
8480 * doc.c (Fdocumentation, store_function_docstring):
8481 * data.c (Finteractive_form): Handle closures.
8483 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8486 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8488 (exec_byte_code): New function extracted from Fbyte_code to handle new
8489 calling convention for byte-code-functions. Add new byte-codes.
8491 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8493 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8495 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8497 * xdisp.c (redisplay_internal): Fix prototype.
8499 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8501 * xdisp.c (SCROLL_LIMIT): New macro.
8502 (try_scrolling): Use it when setting scroll_limit.
8503 Limit scrolling to 100 screen lines.
8504 (redisplay_window): Even when falling back on "recentering",
8505 position point in the window according to scroll-conservatively,
8506 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8508 (try_scrolling): When point is above the window, allow searching
8509 as far as scroll_max, or one screenful, to compute vertical
8510 distance from PT to the scroll margin position. This prevents
8511 try_scrolling from unnecessarily failing when
8512 scroll-conservatively is set to a value slightly larger than the
8513 window height. Clean up the case of PT below the margin at bottom
8514 of window: scroll_max can no longer be INT_MAX. When aggressive
8515 scrolling is in use, don't let point enter the opposite scroll
8516 margin as result of the scroll.
8517 (syms_of_xdisp) <scroll-conservatively>: Document the
8518 threshold of 100 lines for never-recentering scrolling.
8520 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8522 * dispextern.h (move_it_by_lines):
8523 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8524 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8525 (message_log_check_duplicate): Remove parameters `prev_bol' and
8526 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8527 (redisplay_internal): Remove parameter `preserve_echo_area',
8528 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8530 * indent.c (Fvertical_motion):
8531 * window.c (window_scroll_pixel_based, Frecenter):
8532 Don't pass `need_y_p' to `move_it_by_lines'.
8534 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8536 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8537 steal a few bits to be more compact.
8538 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8539 Remove unneeded casts.
8541 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8543 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8545 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8546 binding" message (bug#7967).
8548 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8550 Fix more problems found by GCC 4.6.0's static checks.
8552 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8553 Remove unused local var.
8555 * editfns.c (Fmessage_box): Remove unused local var.
8557 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8558 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8559 Omit unused local vars.
8560 * window.c (shrink_windows): Omit unused local var.
8561 * menu.c (digest_single_submenu): Omit unused local var.
8562 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8563 Omit unused local var.
8565 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8566 Don't assume string length fits in int.
8567 (keyremap_step, read_key_sequence): Use size_t for sizes.
8568 (read_key_sequence): Don't check last_real_key_start redundantly.
8570 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8571 instead of alloca (Bug#8344).
8573 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8574 (Fbacktrace_frame): Don't assume nframes fits in int.
8576 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8578 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8581 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8583 * cm.c (calccost): Turn while-do into do-while, for clarity.
8585 * keyboard.c (syms_of_keyboard): Use the same style as later
8586 in this function when indexing through an array. This also
8587 works around GCC bug 48267.
8589 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8591 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8593 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8594 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8596 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8597 This avoids undefined behavior on integer overflow, and is a bit
8598 more convenient anyway since it is compared to a size_t variable.
8600 Variadic C functions now count arguments with size_t, not int.
8601 This avoids an unnecessary limitation on 64-bit machines, which
8602 caused (substring ...) to crash on large vectors (Bug#8344).
8603 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8604 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8605 All variadic functions and their callers changed accordingly.
8606 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8607 * data.c (arith_driver, float_arith_driver): Likewise.
8608 * editfns.c (general_insert_function): Likewise.
8609 * eval.c (struct backtrace.nargs, interactive_p)
8610 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8611 (funcall_lambda, mark_backtrace): Likewise.
8612 * fns.c (concat): Likewise.
8613 * frame.c (x_set_frame_parameters): Likewise.
8614 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8615 0 if not found, not -1. All callers changed.
8617 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8618 (stack_copy_size): Now size_t, not int.
8619 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8621 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8623 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8624 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8625 All callers changed.
8627 * lisp.h (multibyte_char_to_unibyte):
8628 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8629 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8630 * character.h (CHAR_TO_BYTE8):
8631 * cmds.c (internal_self_insert):
8632 * editfns.c (general_insert_function):
8633 * keymap.c (push_key_description):
8634 * search.c (Freplace_match):
8635 * xdisp.c (message_dolog, set_message_1): All callers changed.
8637 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8639 * keyboard.c (safe_run_hook_funcall): New function.
8640 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8641 don't set the hook to nil, but remove the offending function instead.
8642 (Qcommand_hook_internal): Remove, unused.
8643 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8644 Vcommand_hook_internal.
8646 * eval.c (enum run_hooks_condition): Remove.
8647 (funcall_nil, funcall_not): New functions.
8648 (run_hook_with_args): Call each function through a `funcall' argument.
8649 Remove `cond' argument, now redundant.
8650 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8651 (Frun_hook_with_args_until_failure): Adjust accordingly.
8652 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8654 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8656 * dispextern.h (string_buffer_position): Remove declaration.
8658 * print.c (strout): Remove parameter `multibyte', unused since
8659 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8661 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8662 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8663 All callers changed.
8665 * w32.c (_wsa_errlist): Use braces for struct initializers.
8667 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8668 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8669 All callers changed.
8670 (string_buffer_position): Likewise. Also, make static (it's never
8671 used outside xdisp.c).
8672 (cursor_row_p): Remove parameter `w', unused since
8673 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8674 (decode_mode_spec): Remove parameter `precision', introduced during
8675 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8676 All callers changed.
8678 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8680 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8682 2011-03-27 Anders Lindgren <andlind@gmail.com>
8684 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8685 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8686 (ns_update_auto_hide_menu_bar): New functions.
8687 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8688 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8689 ns_constrain_all_frames.
8690 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8691 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8693 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8695 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8697 2011-03-27 Glenn Morris <rgm@gnu.org>
8699 * syssignal.h: Replace RETSIGTYPE with void.
8700 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8701 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8702 Replace SIGTYPE with void everywhere.
8703 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8704 * s/template.h (SIGTYPE): Remove commented out definition.
8706 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8708 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8709 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8711 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8713 * w32.c (read_unc_volume): Use parameter `henum', instead of
8714 global variable `wget_enum_handle'.
8716 * keymap.c (describe_vector): Remove parameters `indices' and
8717 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8718 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8720 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8722 * keyboard.c (timer_check): Remove parameter `do_it_now',
8723 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8724 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8725 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8727 * keyboard.c (read_char):
8728 * w32menu.c (w32_menu_display_help):
8729 * xmenu.c (show_help_event, menu_help_callback):
8730 Adjust calls to `show_help_echo'.
8732 * gtkutil.c (xg_maybe_add_timer):
8733 * keyboard.c (readable_events):
8734 * process.c (wait_reading_process_output):
8735 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8737 * insdel.c (adjust_markers_gap_motion):
8738 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8739 (gap_left, gap_right): Don't call it.
8741 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8743 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8744 incurred during fontification.
8746 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8748 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8749 (DEFVAR_PER_BUFFER): Don't pass it.
8751 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8752 (scrolling_window): Don't pass it.
8754 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8756 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8758 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8760 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8761 of variables specific to SELinux and computation of `encoded_absname'.
8763 * image.c (XPutPixel): Remove unused variable `height'.
8765 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8767 * unexw32.c (get_section_info): Remove unused variable `section'.
8769 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8770 (system_process_attributes): Remove unused variable `sess'.
8771 (sys_read): Remove unused variable `err'.
8773 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8774 (w32_wnd_proc): Remove unused variable `isdead'.
8775 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8776 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8777 (x_create_tip_frame): Remove unused variable `tem'.
8779 * w32inevt.c (w32_console_read_socket):
8780 Remove unused variable `no_events'.
8782 * w32term.c (x_draw_composite_glyph_string_foreground):
8783 Remove unused variable `width'.
8785 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8787 * w32term.c (x_set_glyph_string_clipping):
8788 Don't pass uninitialized region to CombineRgn.
8790 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8792 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8793 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8794 (Fx_close_connection): Remove unused variable `i'.
8796 * w32font.c (w32font_draw): Return number of glyphs.
8797 (w32font_open_internal): Remove unused variable `i'.
8798 (w32font_driver): Add missing initializer.
8800 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8801 (fill_in_menu): Remove unused variable `items_added'.
8803 * w32term.c (last_mouse_press_frame): Remove static global variable.
8804 (w32_clip_to_row): Remove unused variable `f'.
8805 (x_delete_terminal): Remove unused variable `i'.
8807 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8808 (NOTHING): Remove unused static global variable.
8809 (uniscribe_check_otf): Remove unused variable `table'.
8810 (uniscribe_font_driver): Add missing initializers.
8812 2011-03-23 Julien Danjou <julien@danjou.info>
8814 * term.c (Fsuspend_tty, Fresume_tty):
8815 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8816 * window.c (temp_output_buffer_show):
8817 * insdel.c (signal_before_change):
8818 * frame.c (Fhandle_switch_frame):
8819 * fileio.c (Fdo_auto_save):
8820 * emacs.c (Fkill_emacs):
8821 * editfns.c (save_excursion_restore):
8822 * cmds.c (internal_self_insert):
8823 * callint.c (Fcall_interactively):
8824 * buffer.c (Fkill_all_local_variables):
8825 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8827 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8828 unconditionally since it does the check itself.
8830 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8832 Fix more problems found by GCC 4.5.2's static checks.
8834 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8835 the first time through the loop, since we know p0 < p1 then.
8836 This also avoids a gcc -Wstrict-overflow warning.
8838 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8839 leading to a memory leak, possible in functions like
8840 load_charset_map_from_file that can allocate an unbounded number
8841 of objects (Bug#8318).
8843 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8844 that could (at least in theory) be that large.
8846 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8847 This is less likely to overflow, and avoids undefined behavior if
8848 overflow does occur. All callers changed. Use strtoul to scan
8849 for the unsigned long integer.
8850 (pint2hrstr): Simplify and tune code slightly.
8851 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8853 * scroll.c (do_scrolling): Work around GCC bug 48228.
8854 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8856 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8857 This also avoids a warning with gcc -Wstrict-overflow.
8858 (validate_x_resource_name): Simplify count usage.
8859 This also avoids a warning with gcc -Wstrict-overflow.
8861 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8864 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8866 * process.c (Fmake_network_process): Use socklen_t, not int,
8867 where POSIX says socklen_t is required in portable programs.
8868 This fixes a porting bug on hosts like 64-bit HP-UX, where
8869 socklen_t is wider than int (Bug#8277).
8870 (Fmake_network_process, server_accept_connection):
8871 (wait_reading_process_output, read_process_output):
8874 * process.c: Rename or move locals to avoid shadowing.
8875 (list_processes_1, Fmake_network_process):
8876 (read_process_output_error_handler, exec_sentinel_error_handler):
8877 Rename or move locals.
8878 (Fmake_network_process): Define label "retry_connect" only if needed.
8879 (Fnetwork_interface_info): Fix pointer signedness.
8880 (process_send_signal): Add cast to avoid pointer signedness problem.
8881 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8882 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8884 Make tparam.h and terminfo.c consistent.
8885 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8886 Include tparam.h instead, since it declares them.
8887 * cm.h (PC): Remove extern decl; tparam.h now does this.
8888 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8889 * terminfo.c: Include tparam.h, to check interfaces.
8890 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8891 (tparam): Adjust signature to match interface in tparam.h;
8892 this removes some undefined behavior. Check that outstring and len
8893 are zero, which they always are with Emacs.
8894 * tparam.h (PC, BC, UP): New extern decls.
8896 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8897 (xftfont_open): Rename locals to avoid shadowing.
8899 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8900 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8901 (OTF_TAG_SYM): Omit macro if not needed.
8902 (ftfont_list): Remove unused local.
8903 (get_adstyle_property, ftfont_pattern_entity):
8904 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8905 Rename locals to avoid shadowing.
8907 * xfont.c (xfont_list_family): Mark var as initialized.
8909 * xml.c (make_dom): Now static.
8911 * composite.c (composition_compute_stop_pos): Rename local to
8913 (composition_reseat_it): Remove unused locals.
8914 (find_automatic_composition, composition_adjust_point): Likewise.
8915 (composition_update_it): Mark var as initialized.
8916 (find_automatic_composition): Mark vars as initialized,
8917 with a FIXME (Bug#8290).
8919 character.h: Rename locals to avoid shadowing.
8920 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8921 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8922 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8923 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8926 * textprop.c (property_change_between_p): Remove; unused.
8928 * intervals.c (interval_start_pos): Now static.
8930 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8932 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8933 Rename locals to avoid shadowing.
8935 * sound.c (wav_play, au_play, Fplay_sound_internal):
8936 Fix pointer signedness.
8937 (alsa_choose_format): Remove unused local var.
8938 (wav_play): Initialize a variable to 0, to prevent undefined
8939 behavior (Bug#8278).
8941 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8943 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8945 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8946 clobbering (Bug#8298).
8947 * sysdep.c (sys_subshell): Likewise.
8948 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8950 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8951 This should get cleaned up, so that child_setup has the
8952 same signature on all platforms.
8954 * callproc.c (call_process_cleanup): Now static.
8955 (relocate_fd): Rename locals to avoid shadowing.
8957 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8959 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8960 not to be necessary, and produces flickering.
8962 2011-03-20 Glenn Morris <rgm@gnu.org>
8964 * config.in: Remove file.
8966 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8968 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8969 are now in src/globals.h.
8970 (syms_of_minibuf): Remove spurious & from previous change.
8972 2011-03-20 Leo Liu <sdl.web@gmail.com>
8974 * minibuf.c (completing-read-function): New variable.
8975 (completing-read-default): Rename from completing-read.
8976 (completing-read): Call completing-read-function.
8978 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8980 * xfaces.c (Fx_load_color_file):
8981 Read color file from absolute filename (bug#8250).
8983 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8985 * makefile.w32-in: Update dependencies.
8987 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8989 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8991 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8993 Fix more problems found by GCC 4.5.2's static checks.
8995 * process.c (make_serial_process_unwind, send_process_trap):
8996 (sigchld_handler): Now static.
8998 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8999 That way, the code declares only the vars that it needs.
9000 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9001 * s/cygwin.h (PTY_ITERATION): Likewise.
9002 * s/darwin.h (PTY_ITERATION): Likewise.
9003 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9005 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9006 * process.c (allocate_pty): Don't declare stb unless it's needed.
9008 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9009 (CONSTANTLIM): Remove; unused.
9010 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9011 Define only if needed.
9013 * unexelf.c (unexec): Name an expression,
9014 to avoid gcc -Wbad-function-cast warning.
9015 Use a different way to cause a compilation error if anyone uses
9016 n rather than nn, a way that does not involve shadowing.
9017 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9019 * deps.mk (unexalpha.o): Remove; unused.
9021 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9022 * unexec.h: New file.
9023 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9024 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9026 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9027 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9028 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9029 Change as necessary to match prototype in unexec.h.
9031 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9033 (back_comment, skip_chars): Mark vars as initialized.
9035 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9036 Rename locals to avoid shadowing.
9038 * lread.c (read1): Rewrite so as not to use empty "else".
9039 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9041 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9043 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9044 warning when compiling print.c.
9046 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9047 instead of using an uninitialized var.
9048 (font_sort_entities): Mark var as initialized.
9050 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9052 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9053 pointers to constants.
9054 (font_parse_fcname): Remove unused vars.
9055 (font_delete_unmatched): Now static.
9056 (font_get_spec): Remove; unused.
9057 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9058 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9059 Rename or move locals to avoid shadowing.
9061 * fns.c (require_nesting_list, require_unwind): Now static.
9062 (Ffillarray): Rename locals to avoid shadowing.
9064 * floatfns.c (domain_error2): Define only if needed.
9065 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9067 * alloc.c (mark_backtrace): Move decl from here ...
9068 * lisp.h: ... to here, so that it can be checked.
9070 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9071 (Fdefvar): Rewrite so as not to use empty "else".
9072 (lisp_indirect_variable): Name an expression,
9073 to avoid gcc -Wbad-function-cast warning.
9074 (Fdefvar): Rename locals to avoid shadowing.
9076 * callint.c (quotify_arg, quotify_args): Now static.
9077 (Fcall_interactively): Rename locals to avoid shadowing.
9078 Use const pointer when appropriate.
9080 * lisp.h (get_system_name, get_operating_system_release):
9081 Move decls here, to check interfaces.
9082 * process.c (get_operating_system_release): Move decl to lisp.h.
9083 * xrdb.c (get_system_name): Likewise.
9084 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9085 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9086 some of which prompt warnings from gcc -Wbad-function-cast.
9087 (Fformat_time_string, Fencode_time, Finsert_char):
9088 (Ftranslate_region_internal, Fformat):
9089 Rename or remove local vars to avoid shadowing.
9090 (Ftranslate_region_internal): Mark var as initialized.
9092 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9095 * lisp.h (eassert): Check that the argument compiles, even if
9096 ENABLE_CHECKING is not defined.
9098 * data.c (Findirect_variable): Name an expression, to avoid
9099 gcc -Wbad-function-cast warning.
9100 (default_value, arithcompare, arith_driver, arith_error): Now static.
9101 (store_symval_forwarding): Rename local to avoid shadowing.
9102 (Fmake_variable_buffer_local, Fmake_local_variable):
9103 Mark variables as initialized.
9104 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9106 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9107 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9108 Rename locals to avoid shadowing.
9109 (mark_stack): Move local variables into the #ifdef region where
9111 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9112 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9114 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9115 (GC_STRING_CHARS): Remove; not used.
9116 (Fmemory_limit): Cast sbrk's returned value to char *.
9118 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9119 avoids undefined behavior in theory.
9121 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9123 Use functions, not macros, for up- and down-casing (Bug#8254).
9124 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9125 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9126 to use the following functions instead of these macros.
9127 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9128 EMACS_INT, since callers assume the returned value fits in int.
9129 (upcase1): Likewise, for UPCASE_TABLE.
9130 (uppercasep, lowercasep, upcase): New static inline functions.
9131 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9132 the race-condition problem in the old DOWNCASE.
9134 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9135 Rename locals to avoid shadowing.
9136 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9137 (regex_compile, re_search_2, re_match_2_internal):
9138 Remove unused local vars.
9139 (FREE_VAR): Rewrite so as not to use empty "else",
9140 which gcc can warn about.
9141 (regex_compile, re_match_2_internal): Mark locals as initialized.
9142 (RETALLOC_IF): Define only if needed.
9143 (WORDCHAR_P): Likewise. This one is never needed, but is used
9144 only in a comment talking about a compiler bug, so put inside
9145 the #if 0 of that comment.
9146 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9147 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9150 * search.c (boyer_moore): Rename locals to avoid shadowing.
9151 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9152 (PREV_CHAR_BOUNDARY): Likewise.
9154 * search.c (simple_search): Remove unused var.
9156 * dired.c (compile_pattern): Move decl from here ...
9157 * lisp.h: ... to here, so that it can be checked.
9158 (struct re_registers): New forward decl.
9160 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9162 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9164 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9165 Rename locals to avoid shadowing.
9166 (Fvertical_motion): Mark locals as initialized.
9168 * casefiddle.c (casify_object, casify_region): Now static.
9169 (casify_region): Mark local as initialized.
9171 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9173 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9174 New macros, so that the caller can use some names other than
9175 gcpro1, gcpro2, etc.
9176 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9178 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9179 argument, for consistency with GCPRO2_VAR, etc: it is now the
9180 prefix of the variable, not the variable itself. All uses
9182 * dired.c (directory_files_internal, file_name_completion):
9183 Rename locals to avoid shadowing.
9185 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9186 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9187 dired.c's scmp function, had undefined behavior.
9188 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9189 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9190 * buffer.h: ... to here, because these macros use current_buffer,
9191 and the new implementation with inline functions needs to have
9192 current_buffer in scope now, rather than later when the macros
9194 (downcase, upcase1): New static inline functions.
9195 (DOWNCASE, UPCASE1): Reimplement using these functions.
9196 This avoids undefined behavior in expressions like
9197 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9198 from race conditions in accessing the global variables
9199 case_temp1 and case_temp2.
9200 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9201 * lisp.h (case_temp1, case_temp2): Remove their decls.
9202 * character.h (ASCII_CHAR_P): Move from here ...
9203 * lisp.h: ... to here, so that the inline functions mentioned
9206 * dired.c (directory_files_internal_unwind): Now static.
9208 * fileio.c (file_name_as_directory, directory_file_name):
9209 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9211 (file_name_as_directory): Use const pointers when appropriate.
9212 (Fexpand_file_name): Likewise. In particular, newdir might
9213 point at constant storage, so make it a const pointer.
9214 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9215 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9217 (Fset_file_times, Finsert_file_contents, auto_save_error):
9218 Rename locals to avoid shadowing.
9220 * minibuf.c (choose_minibuf_frame_1): Now static.
9221 (Ftry_completion, Fall_completions): Rename or remove locals
9224 * marker.c (bytepos_to_charpos): Remove; unused.
9226 * lisp.h (verify_bytepos, count_markers): New decls,
9227 so that gcc does not warn that these functions aren't declared.
9229 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9230 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9231 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9232 (copy_text): Remove unused local var.
9234 * filelock.c (within_one_second): Now static.
9235 (lock_file_1): Rename local to avoid shadowing.
9237 * buffer.c (fix_overlays_before): Mark locals as initialized.
9238 (fix_start_end_in_overlays): Likewise. This function should be
9239 simplified by using pointers-to-pointers, but that's a different
9241 (switch_to_buffer_1): Now static.
9242 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9243 (report_overlay_modification): Rename locals to avoid shadowing.
9245 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9246 Fix pointer signedness issue.
9247 (sys_subshell): Mark local as volatile if checking for lint,
9248 to suppress a gcc -Wclobbered warning that does not seem to be right.
9249 (MAXPATHLEN): Define only if needed.
9251 * process.c (serial_open, serial_configure): Move decls from here ...
9252 * systty.h: ... to here, so that they can be checked.
9254 * fns.c (get_random, seed_random): Move extern decls from here ...
9255 * lisp.h: ... to here, so that they can be checked.
9257 * sysdep.c (reset_io): Now static.
9258 (wait_for_termination_signal): Remove; unused.
9260 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9261 (copy_keymap_item, append_key, push_text_char_description):
9263 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9264 (DENSE_TABLE_SIZE): Remove; unused.
9265 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9266 (describe_map_tree):
9267 Rename locals to avoid shadowing.
9269 * keyboard.c: Declare functions static if they are not used elsewhere.
9270 (echo_char, echo_dash, cmd_error, top_level_2):
9271 (poll_for_input, handle_async_input): Now static.
9272 (read_char, kbd_buffer_get_event, make_lispy_position):
9273 (make_lispy_event, make_lispy_movement, apply_modifiers):
9274 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9275 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9276 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9277 (read_key_sequence, read_char): Mark locals as initialized.
9278 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9280 * keyboard.h (make_ctrl_char): New decl.
9281 (mark_kboards): Move decl here ...
9282 * alloc.c (mark_kboards): ... from here.
9284 * lisp.h (force_auto_save_soon): New decl.
9286 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9287 (DEFINE_DUMMY_FUNCTION): New macro.
9288 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9290 (main): Add casts to avoid warnings
9291 if GCC considers string literals to be constants.
9293 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9295 * dbusbind.c: Pointer signedness fixes.
9296 (xd_signature, xd_append_arg, xd_initialize):
9297 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9298 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9299 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9300 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9302 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9303 if GCC considers string literals to be constants.
9304 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9306 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9308 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9309 (print_preprocess, print_object): New macro to fix last change.
9311 * print.c (print_preprocess): Don't forget font objects.
9313 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9315 * emacs.c (USAGE3): Doc fixes.
9317 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9319 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9322 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9324 * lisp.h (VWindow_system, Qfile_name_history):
9325 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9326 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9327 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9329 * w32select.c: Don't #include "keyboard.h".
9330 (run_protected): Add extern declaration for waiting_for_input.
9332 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9333 * w32console.c (detect_input_pending, read_input_pending)
9334 (encode_terminal_code):
9335 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9336 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9337 (w32_system_caret_y, Qfile_name_history):
9338 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9339 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9340 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9341 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9342 * w32proc.c (Qlocal, report_file_error):
9343 * w32term.c (Vwindow_system, updating_frame):
9344 * w32uniscribe.c (initialized, uniscribe_font_driver):
9345 Remove unneeded extern declarations.
9347 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9349 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9351 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9353 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9354 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9355 These macros can no longer be used for assignment.
9357 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9358 Assign struct members directly, instead of using BUF_BEGV etc.
9359 (record_buffer_markers, fetch_buffer_markers): New functions for
9360 recording and fetching special buffer markers.
9361 (set_buffer_internal_1, set_buffer_temp): Use them.
9363 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9365 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9367 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9368 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9370 * xdisp.c (hscroll_window_tree):
9371 (reconsider_clip_changes): Use PT instead of BUF_PT.
9373 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9375 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9376 $(EMACS_ROOT)/lib/intprops.h.
9378 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9380 Fix more problems found by GCC 4.5.2's static checks.
9382 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9383 to unsigned char * to avoid compiler diagnostic.
9384 (xg_free_frame_widgets): Make it clear that a local variable is
9385 needed only if USE_GTK_TOOLTIP.
9386 (gdk_window_get_screen): Make it clear that this macro is needed
9387 only if USE_GTK_TOOLTIP.
9388 (int_gtk_range_get_value): New function, which avoids a diagnostic
9389 from gcc -Wbad-function-cast.
9390 (xg_set_toolkit_scroll_bar_thumb): Use it.
9391 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9392 diagnostic from gcc -Wbad-function-cast.
9393 (get_utf8_string, xg_get_file_with_chooser):
9394 Rename locals to avoid shadowing.
9395 (create_dialog): Move locals to avoid shadowing.
9397 * xgselect.c (xg_select): Remove unused var.
9399 * image.c (four_corners_best): Mark locals as initialized.
9400 (gif_load): Initialize transparent_p to zero (Bug#8238).
9401 Mark another local as initialized.
9402 (my_png_error, my_error_exit): Mark with NO_RETURN.
9404 * image.c (clear_image_cache): Now static.
9405 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9406 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9407 (x_edge_detection): Remove unnecessary cast that
9408 gcc -Wbad-function-cast diagnoses.
9409 (gif_load): Fix pointer signedness.
9410 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9411 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9413 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9415 Improve quality of tests for time stamp overflow.
9416 For example, without this patch (encode-time 0 0 0 1 1
9417 1152921504606846976) returns the obviously-bogus value (-948597
9418 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9419 reports time overflow. See
9420 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9421 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9422 * editfns.c: Include limits.h and intprops.h.
9423 (TIME_T_MIN, TIME_T_MAX): New macros.
9424 (time_overflow): Move earlier, to before first use.
9425 (hi_time, lo_time): New functions, for an accurate test for
9427 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9428 (Fget_internal_run_time): Don't assume time_t fits in int.
9429 (make_time): Use list2 instead of Fcons twice.
9430 (Fdecode_time): More accurate test for out-of-range times.
9431 (check_tm_member): New function.
9432 (Fencode_time): Use it, to test for out-of-range times.
9433 (lisp_time_argument): Don't rely on undefined left-shift and
9434 right-shift behavior when checking for time stamp overflow.
9436 * editfns.c (time_overflow): New function, refactoring common code.
9437 (Fformat_time_string, Fdecode_time, Fencode_time):
9438 (Fcurrent_time_string): Use it.
9440 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9441 * dired.c (make_time): Move to ...
9442 * editfns.c (make_time): ... here.
9443 * systime.h: Note the move.
9445 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9447 * fringe.c (update_window_fringes): Remove unused variables.
9449 * unexmacosx.c (copy_data_segment): Also copy __got section.
9452 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9454 * termcap.c [MSDOS]: Include "msdos.h".
9455 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9456 Constify `char *' arguments and their references according to
9457 prototypes in tparam.h.
9459 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9461 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9462 Adapt all references accordingly.
9464 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9466 2011-03-11 Tom Tromey <tromey@redhat.com>
9468 * buffer.c (syms_of_buffer): Remove obsolete comment.
9470 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9472 * termhooks.h (encode_terminal_code): Declare prototype.
9474 * msdos.c (encode_terminal_code): Don't declare prototype.
9476 * term.c (encode_terminal_code): Now external again, used by
9477 w32console.c and msdos.c.
9479 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9480 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9482 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9484 Fix some minor problems found by GCC 4.5.2's static checks.
9486 * fringe.c (update_window_fringes): Mark locals as initialized
9488 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9490 * alloc.c (mark_fringe_data): Move decl from here ...
9491 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9492 to check its interface.
9493 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9495 * fontset.c (free_realized_fontset): Now static.
9496 (Fset_fontset_font): Rename local to avoid shadowing.
9497 (fontset_font): Mark local as initialized.
9498 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9500 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9502 * xselect.c (x_disown_buffer_selections): Remove; not used.
9503 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9504 (x_own_selection, Fx_disown_selection_internal): Rename locals
9506 (x_handle_dnd_message): Remove local to avoid shadowing.
9508 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9509 so that the caller can use some name other than gcpro1.
9510 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9511 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9512 (Fx_backspace_delete_keys_p):
9513 Use them to avoid shadowing, and rename vars to avoid shadowing.
9514 (x_decode_color, x_set_name, x_window): Now static.
9515 (Fx_create_frame): Add braces to silence GCC warning.
9516 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9517 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9518 Remove unused locals.
9519 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9520 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9521 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9524 * xterm.h (x_mouse_leave): New decl.
9526 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9527 Remove unused functions.
9528 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9529 (x_calc_absolute_position): Now static.
9530 (XTread_socket): Don't define label "out" unless it's used.
9531 Don't declare local "event" unless it's used.
9532 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9533 unless they are used.
9534 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9535 (x_fatal_error_signal): Remove; not used.
9536 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9537 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9538 (x_error_catcher, x_connection_closed, x_error_handler):
9539 (x_error_quitter, xembed_send_message, x_iconify_frame):
9540 (my_log_handler): Rename locals to avoid shadowing.
9541 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9542 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9544 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9545 Rename or move locals to avoid shadowing.
9546 (tty_defined_color, merge_face_heights): Now static.
9547 (free_realized_faces_for_fontset): Remove; not used.
9548 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9549 does not deduce is never used uninitialized.
9550 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9551 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9553 * terminal.c (store_terminal_param): Now static.
9555 * xmenu.c (menu_highlight_callback): Now static.
9556 (set_frame_menubar): Remove unused local.
9557 (xmenu_show): Rename parameter to avoid shadowing.
9558 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9559 since they might point to immutable storage.
9560 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9561 since it's unused otherwise.
9563 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9564 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9565 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9566 avoids a gcc -Wuninitialized diagnostic.
9567 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9568 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9569 does not deduce are never used uninitialized.
9571 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9573 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9574 * window.c (window_loop, size_window):
9575 (run_window_configuration_change_hook, enlarge_window): Likewise.
9577 * window.c (display_buffer): Now static.
9578 (size_window): Mark variables that gcc -Wuninitialized
9579 does not deduce are never used uninitialized.
9580 * window.h (check_all_windows): New decl, to forestall
9581 gcc -Wmissing-prototypes diagnostic.
9582 * dispextern.h (bidi_dump_cached_states): Likewise.
9584 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9586 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9588 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9589 and to avoid gcc -Wuninitialized warning.
9590 (load_charset_map): Mark variables that gcc -Wuninitialized
9591 does not deduce are never used uninitialized.
9592 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9594 * coding.c (coding_set_source, coding_set_destination):
9595 Use "else { /* comment */ }" rather than "else /* comment */;"
9596 for clarity, and to avoid gcc -Wempty-body warning.
9597 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9598 a block, when the outer 'i' will do.
9599 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9600 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9601 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9602 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9603 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9604 Rename locals to avoid shadowing.
9605 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9606 * coding.c (emacs_mule_char, encode_invocation_designation):
9607 Now static, since they're not used elsewhere.
9608 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9609 (decode_coding_object, encode_coding_object, detect_coding_system):
9610 (decode_coding_emacs_mule): Mark variables that gcc
9611 -Wuninitialized does not deduce are never used uninitialized.
9612 (detect_coding_iso_2022): Initialize a local variable that might
9613 be used uninitialized. Leave a FIXME because it's not clear that
9614 this initialization is needed. (Bug#8211)
9615 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9616 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9617 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9618 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9619 Remove unused macros.
9621 * category.c (hash_get_category_set): Remove unused local var.
9622 (copy_category_table): Now static, since it's not used elsewhere.
9623 * character.c (string_count_byte8): Likewise.
9625 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9626 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9628 * chartab.c (copy_sub_char_table): Now static, since it's not used
9630 (sub_char_table_ref_and_range, char_table_ref_and_range):
9631 Rename locals to avoid shadowing.
9632 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9634 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9635 (BIDI_BOB): Remove unused macro.
9637 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9638 deduce are never used uninitialized.
9639 * term.c (encode_terminal_code): Likewise.
9641 * term.c (encode_terminal_code): Now static. Remove unused local.
9643 * tparam.h: New file.
9644 * term.c, tparam.h: Include it.
9645 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9646 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9647 Move these decls to tparam.h, and make them agree with what
9648 is actually in tparam.c. The previous trick of using incompatible
9649 decls in different modules does not conform to the C standard.
9650 All callers of tparam changed to use tparam's actual API.
9651 * tparam.c (tparam1, tparam, tgoto):
9652 Use const pointers where appropriate.
9654 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9655 * cm.h (struct cm): Likewise.
9656 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9657 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9658 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9659 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9660 (turn_on_face, init_tty): Likewise.
9661 * termchar.h (struct tty_display_info): Likewise.
9663 * term.c (term_mouse_position): Rename local to avoid shadowing.
9665 * alloc.c (mark_ttys): Move decl from here ...
9666 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9668 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9670 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9672 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9674 * search.c (compile_pattern_1): Remove argument regp, unused since
9675 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9676 (compile_pattern): Don't pass it.
9678 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9680 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9681 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9683 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9685 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9687 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9688 gdk_window_get_screen, gdk_window_get_geometry,
9689 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9690 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9691 (xg_get_pixbuf_from_pixmap): New function.
9692 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9693 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9694 Call xg_get_pixbuf_from_pixmap instead of
9695 gdk_pixbuf_get_from_drawable.
9696 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9697 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9698 (xg_check_special_colors): Use GtkStyleContext and its functions
9700 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9701 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9702 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9703 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9704 Call gtk_widget_get_preferred_size.
9705 (xg_frame_resized): gdk_window_get_geometry only takes 5
9707 (xg_win_to_widget, xg_event_is_for_menubar):
9708 Call gdk_x11_window_lookup_for_display.
9709 (xg_set_widget_bg): New function.
9710 (delete_cb): New function.
9711 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9712 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9713 (xg_set_background_color): Call xg_set_widget_bg.
9714 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9715 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9716 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9717 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9719 (update_frame_tool_bar): Call gtk_widget_hide.
9720 (xg_initialize): Use GDK_KEY_g.
9722 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9724 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9726 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9727 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9728 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9730 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9732 * w32xfns.c (select_palette): Check success of RealizePalette against
9733 GDI_ERROR, not zero.
9735 See ChangeLog.11 for earlier changes.
9741 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9743 This file is part of GNU Emacs.
9745 GNU Emacs is free software: you can redistribute it and/or modify
9746 it under the terms of the GNU General Public License as published by
9747 the Free Software Foundation, either version 3 of the License, or
9748 (at your option) any later version.
9750 GNU Emacs is distributed in the hope that it will be useful,
9751 but WITHOUT ANY WARRANTY; without even the implied warranty of
9752 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9753 GNU General Public License for more details.
9755 You should have received a copy of the GNU General Public License
9756 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.