* buffer.c (Qclone_number): Remove for now, as it's unused.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-11 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.c (Qclone_number): Remove for now, as it's unused.
4 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5 (record_buffer): Remove unused local.
6 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7 (set_frame_buffer_list): Remove; unused.
8 * frame.h (other_visible_frames): Remove decl.
9 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12 if HAVE_GPM.
13 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
15 Define only if HAVE_GPM.
16 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
17 (update_hints_inhibit): Remove; never set. All uses removed.
18 * widgetprv.h (emacsFrameClassRec): Remove decl.
19 * window.c (delete_deletable_window): Now returns void, since it
20 wasn't returning anything.
21 (compare_window_configurations): Remove unused locals.
22 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
23 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
24 Omit no-longer-needed #ifdef USE_X_TOOLKIT, since USE_X_TOOLKIT is
25 implied by USE_GTK || USE_MOTIF.
26 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
27 the same widths as pointers. This follows up on the 2011-05-06 patch.
28 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
29 * xterm.h: Likewise.
30 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
31
32 2011-06-11 Martin Rudalics <rudalics@gmx.at>
33
34 * window.c (delete_deletable_window): Re-add.
35 (Fset_window_configuration): Rewrite to handle dead buffers and
36 consequently deletable windows.
37 (window_tree, Fwindow_tree): Remove. Supply functionality in
38 window.el.
39 (compare_window_configurations): Simplify code.
40
41 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
42
43 * image.c (imagemagick_load_image): Fix type mismatch.
44 (Fimagemagick_types): Likewise.
45
46 * window.h (replace_buffer_in_windows): Declare.
47
48 2011-06-11 Martin Rudalics <rudalics@gmx.at>
49
50 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
51 Qclone_number. Remove external declaration of Qdelete_window.
52 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
53 code.
54 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
55 Qbuffer_list_update_hook if allowed.
56 (Fother_buffer): Rewrite doc-string. Major rewrite for new
57 buffer list implementation.
58 (other_buffer_safely): New function.
59 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
60 calls to replace_buffer_in_windows and
61 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
62 if allowed.
63 (record_buffer): Inhibit quitting and rewrite using quittable
64 functions. Run Qbuffer_list_update_hook if allowed.
65 (Frecord_buffer, Funrecord_buffer): New functions.
66 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
67 switch-to-buffer to window.el.
68 (bury-buffer): Move to window.el.
69 (Vbuffer_list_update_hook): New variable.
70
71 * lisp.h (other_buffer_safely): Add prototype in buffer.c
72 section.
73
74 * window.h (resize_frame_windows): Move up in code.
75 (Fwindow_frame): Remove EXFUN.
76 (replace_buffer_in_all_windows): Remove prototype.
77 (replace_buffer_in_windows_safely): Add prototype.
78
79 * window.c: Declare Qdelete_window static again. Move down
80 declaration of select_count.
81 (Fnext_window, Fprevious_window): Rewrite doc-strings.
82 (Fother_window): Move to window.el.
83 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
84 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
85 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
86 window.el.
87 (replace_buffer_in_windows): Implement by calling
88 Qreplace_buffer_in_windows.
89 (replace_buffer_in_all_windows): Remove with some functionality
90 moved into replace_buffer_in_windows_safely.
91 (replace_buffer_in_windows_safely): New function.
92 (select_window_norecord, select_frame_norecord): Move in front
93 of run_window_configuration_change_hook. Remove now obsolete
94 declarations.
95 (Fset_window_buffer): Rewrite doc-string. Call
96 Qrecord_window_buffer.
97 (keys_of_window): Move binding for other-window to window.el.
98
99 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
100
101 * dispextern.h (struct image): Replace data member, whose int_val
102 and ptr_val fields were not used by anything, with a single
103 lisp_val object.
104
105 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
106 (gif_clear_image, gif_load, imagemagick_load_image)
107 (gs_clear_image, gs_load): Callers changed.
108
109 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
110
111 * buffer.h: Include <time.h>, for time_t.
112 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
113
114 Fix minor problems found by static checking.
115
116 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
117
118 Make identifiers static if they are not used in other modules.
119 * data.c (Qcompiled_function, Qframe, Qvector):
120 * image.c (QimageMagick, Qsvg):
121 * minibuf.c (Qmetadata):
122 * window.c (resize_window_check, resize_root_window): Now static.
123 * window.h (resize_window_check, resize_root_window): Remove decls.
124
125 * window.c (window_deletion_count, delete_deletable_window):
126 Remove; unused.
127 (window_body_lines): Now static.
128 (Fdelete_other_windows_internal): Mark vars as initialized.
129 Make sure 'resize_failed' is initialized.
130 (run_window_configuration_change_hook): Rename local to avoid shadowing.
131 (resize_window_apply): Remove unused local.
132 * window.h (delete_deletable_window): Remove decl.
133
134 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
135 (imagemagick_load_image): Fix pointer signedness problem by changing
136 last arg from unsigned char * to char *. All uses changed.
137 Also, fix a local for similar reasons.
138 Remove unused locals. Remove locals to avoid shadowing.
139 (fn_rsvg_handle_free): Remove; unused.
140 (svg_load, svg_load_image): Fix pointer signedness problem.
141 (imagemagick_load_image): Don't use garbage pointer image_wand.
142
143 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
144
145 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
146
147 * image.c (gif_load): Fix omitted cast error introduced by
148 2011-06-06 change.
149
150 2011-06-10 Martin Rudalics <rudalics@gmx.at>
151
152 * window.h (resize_proportionally, orig_total_lines)
153 (orig_top_line): Remove from window structure.
154 (set_window_height, set_window_width, change_window_heights)
155 (Fdelete_window): Remove prototypes.
156 (resize_frame_windows): Remove duplicate declaration.
157
158 2011-06-10 Eli Zaretskii <eliz@gnu.org>
159
160 * window.h (resize_frame_windows, resize_window_check)
161 (delete_deletable_window, resize_root_window)
162 (resize_frame_windows): Declare prototypes.
163
164 * window.c (resize_window_apply): Make definition be "static" to
165 match the prototype.
166
167 2011-06-10 Martin Rudalics <rudalics@gmx.at>
168
169 * window.c: Remove declarations of Qwindow_size_fixed,
170 window_min_size_1, window_min_size_2, window_min_size,
171 size_window, window_fixed_size_p, enlarge_window, delete_window.
172 Remove static from declaration of Qdelete_window, it's
173 temporarily needed by Fbury_buffer.
174 (replace_window): Don't assign orig_top_line and
175 orig_total_lines.
176 (Fdelete_window, delete_window): Remove. Window deletion is
177 handled by window.el.
178 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
179 Fdelete_window calls with calls to Qdelete_window.
180 (Fdelete_other_windows): Remove. Deleting other windows is
181 handled by window.el.
182 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
183 handled in window.el.
184 (window_min_size_2, window_min_size_1, window_min_size): Remove.
185 Window minimum sizes are handled in window.el.
186 (shrink_windows, size_window, set_window_height)
187 (set_window_width, change_window_heights, window_height)
188 (window_width, CURBEG, CURSIZE, enlarge_window)
189 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
190 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
191 handled in window.el.
192 (make_dummy_parent): Rename to make_parent_window and give it a
193 second argument horflag.
194 (make_window): Don't set resize_proportionally any more.
195 (Fsplit_window): Remove. Windows are split in window.el.
196 (save_restore_action, save_restore_orig_size)
197 (shrink_window_lowest_first, save_restore_orig_size): Remove.
198 Resize mini windows in window.el.
199 (grow_mini_window, shrink_mini_window): Implement by calling
200 Qresize_root_window_vertically, resize_window_check and
201 resize_window_apply.
202 (saved_window, Fset_window_configuration, save_window_save): Do
203 not handle orig_top_line, orig_total_lines, and
204 resize_proportionally.
205 (window_min_height, window_min_width): Move to window.el.
206 (keys_of_window): Move bindings for delete-other-windows,
207 split-window, delete-window and enlarge-window to window.el.
208
209 * buffer.c: Temporarily extern Qdelete_window.
210 (Fbury_buffer): Temporarily call Qdelete_window instead of
211 Fdelete_window (Fbury_buffer will move to window.el soon).
212
213 * frame.c (set_menu_bar_lines_1): Remove code handling
214 orig_top_line and orig_total_lines.
215
216 * dispnew.c (adjust_frame_glyphs_initially): Don't use
217 set_window_height but set heights directly.
218 (change_frame_size_1): Use resize_frame_windows.
219
220 * xdisp.c (init_xdisp): Don't use set_window_height but set
221 heights directly.
222
223 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
224 resize_frame_windows instead of change_window_heights and run
225 run_window_configuration_change_hook.
226
227 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
228 instead of change_window_heights and run
229 run_window_configuration_change_hook.
230
231 2011-06-09 Martin Rudalics <rudalics@gmx.at>
232
233 * window.c (replace_window): Rename second argument REPLACEMENT to
234 NEW. New third argument SETFLAG. Rewrite.
235 (delete_window, make_dummy_parent): Call replace_window with
236 third argument 1.
237 (window_list_1): Move down in code.
238 (run_window_configuration_change_hook): Move set_buffer part
239 before select_frame_norecord part in order to unwind correctly.
240 Rename count1 to count.
241 (recombine_windows, delete_deletable_window, resize_root_window)
242 (Fdelete_other_windows_internal)
243 (Frun_window_configuration_change_hook, make_parent_window)
244 (resize_window_check, resize_window_apply, Fresize_window_apply)
245 (resize_frame_windows, Fsplit_window_internal)
246 (Fdelete_window_internal, Fresize_mini_window_internal): New
247 functions.
248 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
249
250 2011-06-08 Martin Rudalics <rudalics@gmx.at>
251
252 * window.h (window): Add some new members to window structure -
253 normal_lines, normal_cols, new_total, new_normal, clone_number,
254 splits, nest, prev_buffers, next_buffers.
255 (WINDOW_TOTAL_SIZE): Move here from window.c.
256 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
257
258 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
259 Remove.
260 (make_dummy_parent): Set new members of windows structure.
261 (make_window): Move down in code. Handle new members of window
262 structure.
263 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
264 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
265 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
266 (Fset_window_prev_buffers, Fwindow_next_buffers)
267 (Fset_window_next_buffers, Fset_window_clone_number): New
268 functions.
269 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
270 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
271 Doc-string fixes.
272 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
273 Argument WINDOW can be now internal window too.
274 (Fwindow_use_time): Move up in code.
275 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
276 Rewrite doc-string.
277 (Fset_window_configuration, saved_window)
278 (Fcurrent_window_configuration, save_window_save): Handle new
279 members of window structure.
280 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
281 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
282 (syms_of_window): New Lisp objects Qrecord_window_buffer,
283 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
284 Qget_mru_window, Qresize_root_window,
285 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
286 Qauto_buffer_name; staticpro them.
287
288 2011-06-07 Martin Rudalics <rudalics@gmx.at>
289
290 * window.c (Fwindow_total_size, Fwindow_left_column)
291 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
292 (Fwindow_list_1): New functions.
293 (window_box_text_cols): Replace with window_body_cols.
294 (Fwindow_width, Fscroll_left, Fscroll_right): Use
295 window_body_cols instead of window_box_text_cols.
296 (delete_window, Fset_window_configuration): Call
297 delete_all_subwindows with window as argument.
298 (delete_all_subwindows): Take a window as argument and not a
299 structure. Rewrite.
300 (window_loop): Remove handling of GET_LRU_WINDOW and
301 GET_LARGEST_WINDOW.
302 (Fget_lru_window, Fget_largest_window): Move to window.el.
303
304 * window.h: Extern window_body_cols instead of
305 window_box_text_cols. delete_all_subwindows now takes a
306 Lisp_Object as argument.
307
308 * indent.c (compute_motion, Fcompute_motion): Use
309 window_body_cols instead of window_box_text_cols.
310
311 * frame.c (delete_frame): Call delete_all_subwindows with root
312 window as argument.
313
314 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
315
316 * fns.c (Fputhash): Document return value.
317
318 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
319
320 * image.c (gif_load): Implement gif89a spec "no disposal" method.
321
322 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
323
324 Cons<->int and similar integer overflow fixes (Bug#8794).
325
326 Check for overflow when converting integer to cons and back.
327 * charset.c (Fdefine_charset_internal, Fdecode_char):
328 Use cons_to_unsigned to catch overflow.
329 (Fencode_char): Use INTEGER_TO_CONS.
330 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
331 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
332 * data.c (long_to_cons, cons_to_long): Remove.
333 (cons_to_unsigned, cons_to_signed): New functions.
334 These signal an error for invalid or out-of-range values.
335 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
336 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
337 * font.c (Ffont_variation_glyphs):
338 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
339 * lisp.h: Include <intprops.h>.
340 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
341 (cons_to_signed, cons_to_unsigned): New decls.
342 (long_to_cons, cons_to_long): Remove decls.
343 * undo.c (record_first_change): Use INTEGER_TO_CONS.
344 (Fprimitive_undo): Use CONS_TO_INTEGER.
345 * xfns.c (Fx_window_property): Likewise.
346 * xselect.c: Include <limits.h>.
347 (x_own_selection, selection_data_to_lisp_data):
348 Use INTEGER_TO_CONS.
349 (x_handle_selection_request, x_handle_selection_clear)
350 (x_get_foreign_selection, Fx_disown_selection_internal)
351 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
352 (lisp_data_to_selection_data): Use cons_to_unsigned.
353 (x_fill_property_data): Use cons_to_signed.
354 Report values out of range.
355
356 Check for buffer and string overflow more precisely.
357 * buffer.h (BUF_BYTES_MAX): New macro.
358 * lisp.h (STRING_BYTES_MAX): New macro.
359 * alloc.c (Fmake_string):
360 * character.c (string_escape_byte8):
361 * coding.c (coding_alloc_by_realloc):
362 * doprnt.c (doprnt):
363 * editfns.c (Fformat):
364 * eval.c (verror):
365 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
366 since they may not be the same number.
367 * editfns.c (Finsert_char):
368 * fileio.c (Finsert_file_contents):
369 Likewise for BUF_BYTES_MAX.
370
371 * image.c: Use ptrdiff_t, not int, for sizes.
372 (slurp_file): Switch from int to ptrdiff_t.
373 All uses changed.
374 (slurp_file): Check that file size fits in both size_t (for
375 malloc) and ptrdiff_t (for sanity and safety).
376
377 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
378 if b->modtime has its maximal value.
379
380 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
381
382 Don't assume time_t can fit into int.
383 * buffer.h (struct buffer.modtime): Now time_t, not int.
384 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
385 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
386
387 Minor fixes for signed vs unsigned integers.
388 * character.h (MAYBE_UNIFY_CHAR):
389 * charset.c (maybe_unify_char):
390 * keyboard.c (read_char, reorder_modifiers):
391 XINT -> XFASTINT, since the integer must be nonnegative.
392 * ftfont.c (ftfont_spec_pattern):
393 * keymap.c (access_keymap, silly_event_symbol_error):
394 XUINT -> XFASTINT, since the integer must be nonnegative.
395 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
396 since it makes no difference and we prefer signed.
397 * keyboard.c (record_char): Use XUINT when all the neighbors do.
398 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
399 nonnegative.
400
401 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
402
403 * window.h (Fwindow_frame): Declare.
404
405 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
406
407 * alloc.c: Simplify handling of large-request failures (Bug#8800).
408 (SPARE_MEMORY): Always define.
409 (LARGE_REQUEST): Remove.
410 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
411
412 2011-06-06 Martin Rudalics <rudalics@gmx.at>
413
414 * lisp.h: Move EXFUNS for Fframe_root_window,
415 Fframe_first_window and Fset_frame_selected_window to window.h.
416
417 * window.h: Move EXFUNS for Fframe_root_window,
418 Fframe_first_window and Fset_frame_selected_window here from
419 lisp.h.
420
421 * frame.c (Fwindow_frame, Fframe_first_window)
422 (Fframe_root_window, Fframe_selected_window)
423 (Fset_frame_selected_window): Move to window.c.
424 (Factive_minibuffer_window): Move to minibuf.c.
425 (Fother_visible_frames_p): New function.
426
427 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
428
429 * window.c (decode_window, decode_any_window): Move up in code.
430 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
431 (inhibit_frame_unsplittable): Remove unused variable.
432 (Fwindow_buffer): Move up and rewrite doc-string.
433 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
434 (Fwindow_prev): New functions.
435 (Fwindow_frame): Move here from frame.c. Accept any window as
436 argument.
437 (Fframe_root_window, Fframe_first_window)
438 (Fframe_selected_window): Move here from frame.c. Accept frame
439 or arbitrary window as argument. Update doc-strings.
440 (Fminibuffer_window): Move up in code.
441 (Fwindow_minibuffer_p): Move up in code and simplify.
442 (Fset_frame_selected_window): Move here from frame.c.
443 Marginal rewrite.
444 (Fselected_window, select_window, Fselect_window): Move up in
445 code. Minor doc-string fixes.
446
447 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
448
449 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
450 Do not assume that spare memory exists; that assumption is valid
451 only if SYSTEM_MALLOC.
452 (LARGE_REQUEST): New macro, so that the issue of large requests
453 is separated from the issue of spare memory.
454
455 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
456
457 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
458 format. (Bug#8806)
459
460 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
461
462 * xfns.c (x_set_scroll_bar_default_width): Move declarations
463 before statements.
464
465 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
466
467 * gtkutil.c (xg_get_default_scrollbar_width): New function.
468
469 * gtkutil.h: Declare xg_get_default_scrollbar_width.
470
471 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
472 min width by calling x_set_scroll_bar_default_width (Bug#8505).
473
474 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
475
476 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
477
478 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
479
480 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
481 (x_clipboard_manager_save): Add return value.
482 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
483 New error handlers.
484 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
485 Obey Vx_select_enable_clipboard_manager. Catch errors in
486 x_clipboard_manager_save (Bug#8779).
487 (Vx_select_enable_clipboard_manager): New variable.
488 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
489
490 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
491
492 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
493
494 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
495
496 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
497 in the current matrix if keep_current_p is non-zero.
498
499 2011-06-04 Eli Zaretskii <eliz@gnu.org>
500
501 * bidi.c (bidi_level_of_next_char): Fix last change.
502
503 2011-06-03 Eli Zaretskii <eliz@gnu.org>
504
505 Support bidi reordering of text covered by display properties.
506
507 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
508 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
509 (bidi_cache_search, bidi_cache_iterator_state)
510 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
511 (bidi_level_of_next_char, bidi_move_to_visually_next):
512 Support character positions inside a run of characters covered by a
513 display string.
514 (bidi_paragraph_init, bidi_resolve_explicit_1)
515 (bidi_level_of_next_char): Call bidi_fetch_char and
516 bidi_fetch_char_advance instead of FETCH_CHAR and
517 FETCH_CHAR_ADVANCE.
518 (bidi_init_it): Initialize new members.
519 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
520 definitions.
521 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
522 instead of using explicit *_CHAR codes.
523 (bidi_resolve_explicit, bidi_resolve_weak):
524 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
525 bidirectional text is supported only in multibyte buffers.
526 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
527 it to initialize the frame_window_p member of struct bidi_it.
528 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
529 (bidi_resolve_explicit, bidi_resolve_weak)
530 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
531 bidi_it->nchars is non-positive.
532 (bidi_level_of_next_char): Don't try to lookup the cache for the
533 next/previous character if nothing is cached there yet, or if we
534 were just reseat()'ed to a new position.
535
536 * xdisp.c (set_cursor_from_row): Set start and stop points
537 according to the row's direction when priming the loop that looks
538 for the glyph on which to display cursor.
539 (single_display_spec_intangible_p): Function deleted.
540 (display_prop_intangible_p): Reimplement to call
541 handle_display_spec instead of single_display_spec_intangible_p.
542 Accept 3 additional arguments needed by handle_display_spec.
543 This fixes incorrect cursor motion across display property with complex
544 values: lists, `(when COND...)' forms, etc.
545 (single_display_spec_string_p): Support property values that are
546 lists with the argument STRING its top-level element.
547 (display_prop_string_p): Fix the condition for processing a
548 property that is a list to be consistent with handle_display_spec.
549 (handle_display_spec): New function, refactored from the
550 last portion of handle_display_prop.
551 (compute_display_string_pos): Accept additional argument
552 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
553 value of a `display' property is a "replacing spec".
554 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
555 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
556 the display property, but just return a value indicating whether
557 the display property will replace the characters it covers.
558 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
559 frame_window_p members of struct bidi_it.
560 (compute_display_string_pos, compute_display_string_end):
561 New functions.
562 (push_it): Accept second argument POSITION, where pop_it should
563 jump to continue iteration.
564 (reseat_1): Initialize bidi_it.disp_pos.
565
566 * keyboard.c (adjust_point_for_property): Adjust the call to
567 display_prop_intangible_p to its new signature.
568
569 * dispextern.h (struct bidi_it): New member frame_window_p.
570 (bidi_init_it): Update prototypes.
571 (display_prop_intangible_p): Update prototype.
572 (compute_display_string_pos, compute_display_string_end):
573 Declare prototypes.
574 (struct bidi_it): New members nchars and disp_pos. ch_len is now
575 EMACS_INT.
576
577 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
578
579 Malloc failure behavior now depends on size of allocation.
580 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
581 * lisp.h: Change signatures accordingly.
582 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
583 All callers changed. (Bug#8762)
584
585 * gnutls.c: Use Emacs's memory allocators.
586 Without this change, the gnutls library would invoke malloc etc.
587 directly, which causes problems on non-SYNC_INPUT hosts, and which
588 runs afoul of improving memory_full behavior. (Bug#8761)
589 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
590 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
591 xfree instead of the default malloc, realloc, free.
592 (Fgnutls_boot): No need to check for memory allocation failure,
593 since xmalloc does that for us.
594
595 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
596 * category.c (hash_get_category_set):
597 * ccl.c (ccl_driver):
598 * charset.c (Fdefine_charset_internal):
599 * charset.h (struct charset.hash_index):
600 * composite.c (get_composition_id, gstring_lookup_cache)
601 (composition_gstring_put_cache):
602 * composite.h (struct composition.hash_index):
603 * dispextern.h (struct image.hash):
604 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
605 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
606 (hashfn_equal, hashfn_user_defined, make_hash_table)
607 (maybe_resize_hash_table, hash_lookup, hash_put)
608 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
609 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
610 (Fsxhash, Fgethash, Fputhash, Fmaphash):
611 * image.c (make_image, search_image_cache, lookup_image)
612 (xpm_put_color_table_h):
613 * lisp.h (struct Lisp_Hash_Table):
614 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
615 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
616 for hashes and hash indexes, instead of 'unsigned' and 'int'.
617 * alloc.c (allocate_vectorlike):
618 Check for overflow in vector size calculations.
619 * ccl.c (ccl_driver):
620 Check for overflow when converting EMACS_INT to int.
621 * fns.c, image.c: Remove unnecessary static decls that would otherwise
622 need to be updated by these changes.
623 * fns.c (make_hash_table, maybe_resize_hash_table):
624 Check for integer overflow with large hash tables.
625 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
626 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
627 (SXHASH_REDUCE): New macro.
628 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
629 Use it instead of discarding useful hash info with large hash values.
630 (sxhash_float): New function.
631 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
632 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
633 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
634 Rewrite to use FIXNUM_BITS, as this simplifies things.
635 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
636 Adjust signatures to match updated version of code.
637 (consing_since_gc): Now EMACS_INT, since a single hash table can
638 use more than INT_MAX bytes.
639
640 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
641
642 Make it possible to build with GCC-4.6+ -O2 -flto.
643
644 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
645
646 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
647
648 * minibuf.c (get_minibuffer, read_minibuf_unwind):
649 Call minibuffer-inactive-mode.
650
651 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
652
653 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
654 Update dependencies.
655
656 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
657
658 * data.c (init_data): Remove code for UTS, this system is not
659 supported anymore.
660
661 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
662
663 Don't force ./temacs to start in terminal mode.
664
665 * frame.c (make_initial_frame): Initialize faces in all cases, not
666 only when CANNOT_DUMP is defined.
667 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
668
669 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
670
671 * dispnew.c (add_window_display_history): Use const for the string
672 pointer. Remove declaration, not needed.
673
674 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
675
676 Use 'inline', not 'INLINE'.
677 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
678 * alloc.c, fontset.c (INLINE): Remove.
679 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
680 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
681 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
682 * gmalloc.c (register_heapinfo): Use inline unconditionally.
683 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
684
685 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
686
687 Make it possible to run ./temacs.
688
689 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
690 syms_of_callproc does the same thing. Remove test for
691 "initialized", do it in the caller.
692 * emacs.c (main): Avoid calling set_initial_environment when dumping.
693
694 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
695
696 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
697 (read_minibuf): Use get_minibuffer.
698 (syms_of_minibuf): Use DEFSYM.
699 (Qmetadata): New var.
700 * data.c (Qbuffer): Don't make it static.
701 (syms_of_data): Use DEFSYM.
702
703 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
704
705 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
706 (CCL_CODE_MIN): New macro.
707
708 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
709
710 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
711
712 * eval.c (Qdebug): Now static.
713 * lisp.h (Qdebug): Remove decl. This reverts a part of the
714 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
715 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
716
717 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
718
719 * image.c: Various fixes to ImageMagick code comments.
720 (Fimagemagick_types): Doc fix.
721
722 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
723
724 Minor fixes prompted by GCC 4.6.0 warnings.
725
726 * xselect.c (converted_selections, conversion_fail_tag): Now static.
727
728 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
729 (x_clipboard_manager_save_all): Move extern decl to ...
730 * xterm.h: ... here, so that it can be checked for consistency.
731
732 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
733
734 * xselect.c (x_clipboard_manager_save_frame)
735 (x_clipboard_manager_save_all): New functions.
736 (Fx_clipboard_manager_save): Lisp function deleted.
737
738 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
739 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
740
741 * xterm.h: Update prototype.
742
743 2011-05-28 William Xu <william.xwl@gmail.com>
744
745 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
746 exiting (Bug#8239).
747
748 2011-05-28 Jim Meyering <meyering@redhat.com>
749
750 Avoid a sign-extension bug in crypto_hash_function.
751 * fns.c (to_uchar): Define.
752 (crypto_hash_function): Use it to convert some newly-signed
753 variables to unsigned, to avoid sign-extension bugs. For example,
754 without this change, (md5 "truc") would evaluate to
755 45723a2aff78ff4fff7fff1114760e62 rather than the expected
756 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
757 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
758
759 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
760
761 Integer overflow fixes.
762
763 * dbusbind.c: Serial number integer overflow fixes.
764 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
765 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
766 to hold a serial number that is too large for a fixnum.
767 (Fdbus_method_return_internal, Fdbus_method_error_internal):
768 Check for serial numbers out of range. Decode any serial number
769 that was so large that it became a float. (Bug#8722)
770
771 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
772 (Fdbus_call_method, Fdbus_call_method_asynchronously):
773 Use XFASTINT rather than XUINT when numbers are nonnegative.
774 (xd_append_arg, Fdbus_method_return_internal):
775 (Fdbus_method_error_internal): Likewise. Also, for unsigned
776 arguments, check that Lisp number is nonnegative, rather than
777 silently wrapping negative numbers around. (Bug#8722)
778 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
779 (Bug#8722)
780
781 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
782
783 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
784
785 ccl: add integer overflow checks
786 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
787 (IN_INT_RANGE): New macros.
788 (ccl_driver): Use them to check for integer overflow when
789 decoding a CCL program. Many of the new checks are whether XINT (x)
790 fits in int; it doesn't always, on 64-bit hosts. The new version
791 doesn't catch all possible integer overflows, but it's an
792 improvement. (Bug#8719)
793
794 * alloc.c (make_event_array): Use XINT, not XUINT.
795 There's no need for unsigned here.
796
797 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
798 This follows up to the 2011-05-06 change that substituted uintptr_t
799 for EMACS_INT. This case wasn't caught back then.
800
801 Rework Fformat to avoid integer overflow issues.
802 * editfns.c: Include <float.h> unconditionally, as it's everywhere
803 now (part of C89). Include <verify.h>.
804 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
805 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
806 (Fformat): Avoid the prepass trying to compute sizes; it was only
807 approximate and thus did not catch overflow reliably. Instead, walk
808 through the format just once, formatting and computing sizes as we go,
809 checking for integer overflow at every step, and allocating a larger
810 buffer as needed. Keep track separately whether the format is
811 multibyte. Keep only the most-recently calculated precision, rather
812 than them all. Record whether each argument has been converted to
813 string. Use EMACS_INT, not int, for byte and char and arg counts.
814 Support field widths and precisions larger than INT_MAX. Avoid
815 sprintf's undefined behavior with conversion specifications such as %#d
816 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
817 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
818 formatting out-of-range floating point numbers with int
819 formats. (Bug#8668)
820
821 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
822
823 * data.c: Avoid integer truncation in expressions involving floats.
824 * data.c: Include <intprops.h>.
825 (arith_driver): When there's an integer overflow in an expression
826 involving floating point, convert the integers to floating point
827 so that the resulting value does not suffer from catastrophic
828 integer truncation. For example, on a 64-bit host (* 4
829 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
830 Do not rely on undefined behavior after integer overflow.
831
832 merge count_size_as_multibyte, parse_str_to_multibyte
833 * character.c, character.h (count_size_as_multibyte):
834 Rename from parse_str_to_multibyte; all uses changed.
835 Check for integer overflow.
836 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
837 since it's now a duplicate of the other. This is more of
838 a character than a buffer op, so better that it's in character.c.
839 * fns.c, print.c: Adjust to above changes.
840
841 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
842
843 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
844
845 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
846
847 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
848 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
849 (x_clipboard_manager_save): Now static.
850 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
851
852 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
853 (crypto_hash_function): Now static.
854 Fix pointer signedness problems. Avoid unnecessary initializations.
855
856 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
857
858 * termhooks.h (Vselection_alist): Make it terminal-local.
859
860 * terminal.c (create_terminal): Initialize it.
861
862 * xselect.c: Support for clipboard managers.
863 (Vselection_alist): Move to termhooks.h as terminal-local var.
864 (LOCAL_SELECTION): New macro.
865 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
866 (symbol_to_x_atom): Remove gratuitous arg.
867 (x_handle_selection_request, lisp_data_to_selection_data)
868 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
869 (x_own_selection, x_get_local_selection, x_convert_selection):
870 New arg, specifying work frame. Use terminal-local Vselection_alist.
871 (some_frame_on_display): Delete unused function.
872 (Fx_own_selection_internal, Fx_get_selection_internal)
873 (Fx_disown_selection_internal, Fx_selection_owner_p)
874 (Fx_selection_exists_p): New optional frame arg.
875 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
876 (x_handle_selection_clear): Don't treat other terminals with the
877 same keyboard specially. Use the terminal-local Vselection_alist.
878 (x_clear_frame_selections): Use Frun_hook_with_args.
879
880 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
881
882 * xterm.h: Add support for those atoms.
883
884 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
885
886 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
887 (converted_selections, conversion_fail_tag): New global variables.
888 (x_selection_request_lisp_error): Free the above.
889 (x_get_local_selection): Remove unnecessary code.
890 (x_reply_selection_request): Args changed; handle arbitrary array
891 of converted selections stored in converted_selections.
892 Separate the XChangeProperty and SelectionNotify steps.
893 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
894 (x_convert_selection): New function.
895 (x_handle_selection_event): Simplify.
896 (x_get_foreign_selection): Don't ignore incoming requests while
897 waiting for an answer; this will fail when we implement
898 SAVE_TARGETS, and seems unnecessary anyway.
899 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
900 (Vx_sent_selection_functions): Doc fix.
901
902 2011-05-26 Leo Liu <sdl.web@gmail.com>
903
904 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
905
906 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
907
908 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
909
910 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
911 for fringe update if it has periodic bitmap.
912 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
913 and fringe_bitmap_periodic_p.
914
915 * fringe.c (get_fringe_bitmap_data): New function.
916 (draw_fringe_bitmap_1, update_window_fringes): Use it.
917 (update_window_fringes): Record periodicity of fringe bitmap in glyph
918 row. Mark glyph row for fringe update if periodicity changed.
919
920 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
921 for fringe update unless it has periodic bitmap.
922
923 2011-05-25 Kenichi Handa <handa@m17n.org>
924
925 * xdisp.c (get_next_display_element): Set correct it->face_id for
926 a static composition.
927
928 2011-05-24 Leo Liu <sdl.web@gmail.com>
929
930 * deps.mk (fns.o):
931 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
932
933 * fns.c (crypto_hash_function, Fsha1): New function.
934 (Fmd5): Use crypto_hash_function.
935 (syms_of_fns): Add Ssha1.
936
937 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
938
939 * gnutls.c: Remove unused macros.
940 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
941 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
942 Remove macros that are defined and never used.
943 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
944
945 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
946
947 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
948 (Fx_get_selection_internal): Minor cleanup.
949 (Fx_own_selection_internal): Rename arguments for consistency with
950 select.el.
951
952 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
953
954 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
955
956 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
957
958 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
959
960 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
961
962 * dispnew.c (scrolling_window): Don't exclude the case that the
963 last enabled row in the desired matrix touches the bottom boundary.
964
965 2011-05-21 Glenn Morris <rgm@gnu.org>
966
967 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
968 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
969 and add some more files.
970
971 2011-05-20 Eli Zaretskii <eliz@gnu.org>
972
973 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
974 report_file_error introduced by the change from 2011-05-07.
975
976 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
977
978 * systime.h (Time): Define only if emacs is defined.
979 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
980 where the include path doesn't have X11/X.h by default. See
981 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
982
983 2011-05-20 Kenichi Handa <handa@m17n.org>
984
985 * composite.c (find_automatic_composition): Fix previous change.
986
987 2011-05-20 Glenn Morris <rgm@gnu.org>
988
989 * lisp.mk: New file, split from Makefile.in.
990 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
991 (shortlisp): Remove.
992 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
993
994 2011-05-19 Glenn Morris <rgm@gnu.org>
995
996 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
997 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
998 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
999 (lisp): Set the order to that of loadup.el.
1000 (shortlisp): Make it a copy of $lisp.
1001 (SOME_MACHINE_LISP): Remove.
1002 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1003 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1004
1005 2011-05-18 Kenichi Handa <handa@m17n.org>
1006
1007 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1008 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1009 (find_automatic_composition): Mostly rewrite for efficiency.
1010
1011 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1012
1013 * makefile.w32-in: Update dependencies.
1014
1015 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1016
1017 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1018 revision 104625).
1019
1020 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1021
1022 Fix some integer overflow issues, such as string length overflow.
1023
1024 * insdel.c (count_size_as_multibyte): Check for string overflow.
1025
1026 * character.c (lisp_string_width): Check for string overflow.
1027 Use EMACS_INT, not int, for string indexes and lengths; in
1028 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1029 the resulting string length overflows an EMACS_INT; instead,
1030 report a string overflow if no precision given. When checking for
1031 precision exhaustion, use a check that cannot possibly have
1032 integer overflow. (Bug#8675)
1033 * character.h (lisp_string_width): Adjust to new signature.
1034
1035 * alloc.c (string_overflow): New function.
1036 (Fmake_string): Use it. This doesn't change behavior, but saves
1037 a few bytes and will simplify future changes.
1038 * character.c (string_escape_byte8): Likewise.
1039 * lisp.h (string_overflow): New decl.
1040
1041 Fixups, following up to the user-interface timestamp change.
1042 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1043 for UI timestamps, instead of unsigned long.
1044 * msdos.c (mouse_get_pos): Likewise.
1045 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1046 * w32gui.h (Time): Define by including "systime.h" rather than by
1047 declaring it ourselves. (Bug#8664)
1048
1049 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1050 * image.c (clear_image_cache): Likewise.
1051
1052 * term.c (term_mouse_position): Don't assume time_t wraparound.
1053
1054 Be more systematic about user-interface timestamps.
1055 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1056 and sometimes 'EMACS_UINT', to represent these timestamps.
1057 This change causes it to use 'Time' uniformly, as that's what X uses.
1058 This makes the code easier to follow, and makes it easier to catch
1059 integer overflow bugs such as Bug#8664.
1060 * frame.c (Fmouse_position, Fmouse_pixel_position):
1061 Use Time, not unsigned long, for user-interface timestamps.
1062 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1063 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1064 * keyboard.h (last_event_timestamp): Likewise.
1065 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1066 * menu.h (xmenu_show): Likewise.
1067 * term.c (term_mouse_position): Likewise.
1068 * termhooks.h (struct input_event.timestamp): Likewise.
1069 (struct terminal.mouse_position_hook): Likewise.
1070 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1071 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1072 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1073 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1074 what it was before.
1075 * menu.h, termhooks.h: Include "systime.h", for Time.
1076
1077 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1078 Don't assume that the difference between two unsigned long values
1079 can fit into an integer. At this point, we know button_down_time
1080 <= event->timestamp, so the difference must be nonnegative, so
1081 there's no need to cast the result if double-click-time is
1082 nonnegative, as it should be; check that it's nonnegative, just in
1083 case. This bug is triggered when events are more than 2**31 ms
1084 apart (about 25 days). (Bug#8664)
1085
1086 * xselect.c (last_event_timestamp): Remove duplicate decl.
1087 (x_own_selection): Remove needless cast to unsigned long.
1088
1089 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1090 that always fit in int. Use a sentinel instead of a counter, to
1091 avoid a temp and to allay GCC's concerns about possible int overflow.
1092 * frame.h (struct frame): Use int for menu_bar_items_used
1093 instead of EMACS_INT, since it always fits in int.
1094
1095 * menu.c (grow_menu_items): Check for int overflow.
1096
1097 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1098
1099 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1100 Before, the code was not consistent. These values cannot exceed
1101 2**31 - 1 so there's no need to make them unsigned.
1102 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1103 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1104 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1105 as modifiers.
1106 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1107
1108 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1109 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1110 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1111 presumably because the widths might not match.
1112
1113 * window.c (size_window): Avoid needless test at loop start.
1114
1115 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1116
1117 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1118
1119 2011-05-12 Drew Adams <drew.adams@oracle.com>
1120
1121 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1122
1123 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1124
1125 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1126 `width' to `bar_area_x' and `bar_area_width', respectively.
1127 (x_scroll_run): Take account of fringe background extension.
1128
1129 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1130 Rename local vars `left' and `width' to `bar_area_x' and
1131 `bar_area_width', respectively.
1132 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1133 background extension.
1134
1135 2011-05-10 Jim Meyering <meyering@redhat.com>
1136
1137 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1138
1139 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1140
1141 * image.c (Finit_image_library): Return t for built-in image types,
1142 like pbm and xbm. (Bug#8640)
1143
1144 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1145
1146 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1147
1148 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1149
1150 * w32console.c (Fset_screen_color): Doc fix.
1151 (Fget_screen_color): New function.
1152 (syms_of_ntterm): Defsubr it.
1153
1154 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1155 unlink the temporary file if Fcall_process didn't create it in the
1156 first place.
1157 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1158 child process will be redirected to a file specified with `:file'.
1159 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1160 cue to call_process_cleanup not to close that handle.
1161
1162 2011-05-07 Ben Key <bkey76@gmail.com>
1163
1164 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1165 one of two shell specific rules, either bootstrap-temacs-CMD or
1166 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1167 to the previous implementation of the bootstrap-temacs rule.
1168 The bootstrap-temacs-CMD rule is similar to the previous
1169 implementation of the bootstrap-temacs rule except that it
1170 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1171 variable.
1172
1173 These changes, along with some changes to nt/configure.bat,
1174 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1175 earlier fix to add support for --cflags and --ldflags options
1176 that include quotes so that it works whether make uses cmd or
1177 sh as the shell.
1178
1179 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1180
1181 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1182 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1183 is a constant.
1184 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1185 a string. Handle both cases.
1186 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1187 (Fdbus_register_method): Use Qinvalid_function.
1188
1189 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1190
1191 * makefile.w32-in: Update dependencies.
1192 (LISP_H): Add inttypes.h and stdin.h.
1193 (PROCESS_H): Add unistd.h.
1194
1195 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1196
1197 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1198 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1199
1200 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1203
1204 * term.c (vfatal): Remove stray call to va_end.
1205 It's not needed and the C Standard doesn't allow it here anyway.
1206
1207 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1208 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1209
1210 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1211 bytes.
1212
1213 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1214
1215 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1216
1217 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1218
1219 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1220
1221 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1222
1223 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1224 * charset.c (Fdefine_charset_internal): Don't initialize
1225 charset.code_space[15]. The value was garbage, on hosts with
1226 32-bit int (Bug#8600).
1227
1228 * lread.c (read_integer): Be more consistent with string-to-number.
1229 Use string_to_number to do the actual conversion; this avoids
1230 rounding errors and fixes some other screwups. Without this fix,
1231 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1232 (digit_to_number): Move earlier, for benefit of read_integer.
1233 Return -1 if the digit is out of range for the base, -2 if it is
1234 not a digit in any supported base. (Bug#8602)
1235
1236 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1237
1238 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1239 to match comment at start of function. This also removes a
1240 GCC warning about overflow in a 32+64-bit port.
1241
1242 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1243
1244 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1245 Reported by Stefan Monnier in
1246 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1247 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1248 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1249
1250 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1251 (EMACS_UINTPTR): Likewise, with uintptr_t.
1252
1253 * lisp.h: Prefer 64-bit EMACS_INT if available.
1254 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1255 on 32-bit hosts that have 64-bit int, so that they can access
1256 large files.
1257 However, temporarily disable this change unless the temporary
1258 symbol WIDE_EMACS_INT is defined.
1259
1260 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1261
1262 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1263 This removes an assumption that EMACS_INT and long are the same
1264 width as pointers. The assumption is true for Emacs porting targets
1265 now, but we want to make other targets possible.
1266 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1267 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1268 In the rest of the code, change types of integers that hold casted
1269 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1270 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1271 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1272 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1273 No need to cast type when ORing.
1274 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1275 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1276 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1277 assume EMACS_INT is the same width as char *.
1278 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1279 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1280 Remove no-longer-needed casts.
1281 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1282 (xg_tool_bar_help_callback, xg_make_tool_item):
1283 Use EMACS_INTPTR to hold an integer
1284 that will be cast to void *; this can avoid a GCC warning
1285 if EMACS_INT is not the same width as void *.
1286 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1287 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1288 (current_message_1, set_message_1):
1289 Use a local to convert to proper width without a cast.
1290 * xmenu.c (dialog_selection_callback): Likewise.
1291
1292 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1293 Also, don't assume VALBITS / RAND_BITS is less than 5,
1294 and don't rely on undefined behavior when shifting a 1 left into
1295 the sign bit.
1296 * lisp.h (get_random): Change signature to match.
1297
1298 * lread.c (hash_string): Use size_t, not int, for hash computation.
1299 Normally we prefer signed values; but hashing is special, because
1300 it's better to use unsigned division on hash table sizes so that
1301 the remainder is nonnegative. Also, size_t is the natural width
1302 for hashing into memory. The previous code used 'int', which doesn't
1303 retain enough info to hash well into very large tables.
1304 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1305
1306 * dbusbind.c: Don't possibly lose pointer info when converting.
1307 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1308 Use XPNTR rather than XHASH, so that the high-order bits of
1309 the pointer aren't lost when converting through void *.
1310
1311 * eval.c (Fautoload): Don't double-shift a pointer.
1312
1313 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1314
1315 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1316
1317 * gnutls.c (DEF_GNUTLS_FN):
1318 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1319
1320 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1321
1322 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1323 marker. (Bug#8610)
1324
1325 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1326
1327 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1328 New version that can reserve upto 2GB of heap space.
1329
1330 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1331
1332 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1333
1334 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1335
1336 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1337 `gnutls_certificate_set_x509_key_file'.
1338
1339 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1340
1341 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1342 Update dependencies.
1343
1344 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1347 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1348 Remove unused parameter `fildes'.
1349 * process.c (read_process_output, send_process): Don't pass it.
1350
1351 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1352
1353 Fix previous change: the library cache is defined in w32.c.
1354 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1355 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1356
1357 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1358
1359 Implement dynamic loading of GnuTLS on Windows.
1360
1361 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1362 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1363 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1364 Declare.
1365
1366 * gnutls.c (Qgnutls_dll): Define.
1367 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1368 (gnutls_*): Declare function pointers.
1369 (init_gnutls_functions): New function to initialize function pointers.
1370 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1371 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1372 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1373 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1374 (emacs_gnutls_write, emacs_gnutls_read)
1375 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1376 (Fgnutls_available_p): New function.
1377 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1378 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1379 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1380
1381 * image.c: Include w32.h.
1382 (Vimage_type_cache): Delete.
1383 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1384 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1385 (w32_delayed_load): Move to w32.c.
1386
1387 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1388
1389 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1390 (w32_delayed_load): Move from image.c. When loading a library, record
1391 its filename in the :loaded-from property of the library id.
1392 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1393 Initialize and staticpro them.
1394 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1395
1396 * process.c: Include lisp.h before w32.h, not after.
1397 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1398 instead of gnutls_record_check_pending.
1399
1400 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1401
1402 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1403
1404 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1405 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1406 as passed in.
1407
1408 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1409
1410 * xterm.c (x_set_frame_alpha): Do not set property on anything
1411 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1412
1413 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1414
1415 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1416
1417 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1418
1419 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1420 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1421 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1422 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1423 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1424 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1425 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1426 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1427 (Qgnutls_bootprop_callbacks_verify): Make static.
1428
1429 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1430
1431 * callproc.c: Indentation fixup.
1432
1433 * sysdep.c (wait_for_termination_1): Make static.
1434 (wait_for_termination, interruptible_wait_for_termination):
1435 Move after wait_for_termination_1.
1436
1437 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1438
1439 * sysdep.c (interruptible_wait_for_termination): New function
1440 which is like wait_for_termination, but allows keyboard
1441 interruptions.
1442
1443 * callproc.c (Fcall_process): Add (:file "file") as an option for
1444 the STDOUT buffer.
1445 (Fcall_process_region): Ditto.
1446
1447 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1448
1449 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1450 rather than `XVECTOR (FOO)->size'.
1451
1452 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1453 inttypes.h, as a gnulib replacement is used if it not available in
1454 system headers.
1455
1456 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1457
1458 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1459 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1460 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1461
1462 * coding.c (coding_alloc_by_realloc): Error out if destination
1463 will grow beyond MOST_POSITIVE_FIXNUM.
1464 (decode_coding_emacs_mule): Abort if there isn't enough place in
1465 charbuf for the composition carryover bytes. Reserve an extra
1466 space for up to 2 characters produced in a loop.
1467 (decode_coding_iso_2022): Abort if there isn't enough place in
1468 charbuf for the composition carryover bytes.
1469
1470 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1471
1472 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1473 aborting when %lld or %lll format is passed.
1474 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1475 %llo or %llx format is passed. (Bug#8545)
1476
1477 * window.c (window_scroll_line_based): Use a marker instead of
1478 simple variables to record original value of point. (Bug#7952)
1479
1480 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1481 produced by %s or %c overflows available buffer space. (Bug#8545)
1482
1483 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1486 (SIZE_MAX): Move defn after all includes, as they might #define it.
1487
1488 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1489
1490 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1491
1492 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1493
1494 * keyboard.c (Qdelayed_warnings_hook): Define.
1495 (command_loop_1): Run `delayed-warnings-hook'
1496 if Vdelayed_warnings_list is non-nil.
1497 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1498 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1499
1500 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1501
1502 * doprnt.c (doprnt): Don't return value smaller than the buffer
1503 size if the message was truncated. (Bug#8545).
1504
1505 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1506
1507 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1508 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1509
1510 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1513
1514 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1515
1516 * makefile.w32-in: Update dependencies.
1517
1518 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1519
1520 Improve `doprnt' and its usage. (Bug#8545)
1521 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1522 `format_end'. Remove support for %l as a conversion specifier.
1523 Don't use xrealloc. Improve diagnostics when the %l size modifier
1524 is used. Update the commentary.
1525
1526 * eval.c (verror): Simplify calculation of size_t.
1527
1528 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1529 messages.
1530
1531 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1532
1533 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1534 change.
1535
1536 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1539 This makes this file independent of the recent pseudovector change.
1540
1541 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1544
1545 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1546 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1547 Remove unused local.
1548 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1549
1550 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1551 GCC 4.6.0 optimizes based on type-based alias analysis.
1552 For example, if b is of type struct buffer * and v of type struct
1553 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1554 != &v->size, and therefore "v->size = 1; b->size = 2; return
1555 v->size;" must therefore return 1. This assumption is incorrect
1556 for Emacs, since it type-puns struct Lisp_Vector * with many other
1557 types. To fix this problem, this patch adds a new type struct
1558 vectorlike_header that documents the constraints on layout of vectors
1559 and pseudovectors, and helps optimizing compilers not get fooled
1560 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1561 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1562 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1563 the size member.
1564 (XSETPVECTYPE): Rewrite in terms of new macro.
1565 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1566 This is a bit clearer, and further avoids the possibility of
1567 undesirable aliasing.
1568 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1569 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1570 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1571 since Lisp_Subr is a special case (no "next" field).
1572 (ASIZE): Now uses header.size rather than size.
1573 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1574 to avoid the hassle of writing XVECTOR (foo)->header.size.
1575 (struct vectorlike_header): New type.
1576 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1577 object, to help avoid aliasing.
1578 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1579 (SUBRP): Likewise, since Lisp_Subr is a special case.
1580 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1581 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1582 (struct Lisp_Hash_Table): Combine first two members into a single
1583 struct vectorlike_header member. All uses of "size" and "next" members
1584 changed to be "header.size" and "header.next".
1585 * buffer.h (struct buffer): Likewise.
1586 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1587 * frame.h (struct frame): Likewise.
1588 * process.h (struct Lisp_Process): Likewise.
1589 * termhooks.h (struct terminal): Likewise.
1590 * window.c (struct save_window_data, struct saved_window): Likewise.
1591 * window.h (struct window): Likewise.
1592 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1593 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1594 * buffer.c (init_buffer_once): Likewise.
1595 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1596 special case.
1597 * process.c (Fformat_network_address): Use local var for size,
1598 for brevity.
1599
1600 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1601
1602 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1603 * data.c (atof): Remove decl; no longer used or needed.
1604 (digit_to_number): Move to lread.c.
1605 (Fstring_to_number): Use new string_to_number function, to be
1606 consistent with how the Lisp reader treats infinities and NaNs.
1607 Do not assume that floating-point numbers represent EMACS_INT
1608 without losing information; this is not true on most 64-bit hosts.
1609 Avoid double-rounding errors, by insisting on integers when
1610 parsing non-base-10 numbers, as the documentation specifies.
1611 * lisp.h (string_to_number): New decl, replacing ...
1612 (isfloat_string): Remove.
1613 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1614 (read1): Do not accept +. and -. as integers; this
1615 appears to have been a coding error. Similarly, do not accept
1616 strings like +-1e0 as floating point numbers. Do not report
1617 overflow for integer overflows unless the base is not 10 which
1618 means we have no simple and reliable way to continue.
1619 Break out the floating-point parsing into a new
1620 function string_to_number, so that Fstring_to_number parses
1621 floating point numbers consistently with the Lisp reader.
1622 (digit_to_number): Move here from data.c. Make it static inline.
1623 (E_CHAR, EXP_INT): Remove, replacing with ...
1624 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1625 (string_to_number): New function, replacing isfloat_string.
1626 This function checks for valid syntax and produces the resulting
1627 Lisp float number too. Rework it so that string-to-number
1628 no longer mishandles examples like "1.0e+". Use strtoumax,
1629 so that overflow for non-base-10 numbers is reported only when
1630 there's no portable and simple way to convert to floating point.
1631
1632 * textprop.c (set_text_properties_1): Rewrite for clarity,
1633 and to avoid GCC warning about integer overflow.
1634
1635 * intervals.h (struct interval): Use EMACS_INT for members
1636 where EMACS_UINT might cause problems. See
1637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1638 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1639 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1640 All uses changed.
1641 (offset_intervals): Tell GCC not to worry about length overflow
1642 when negating a negative length.
1643
1644 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1645 (overrun_check_free): Likewise.
1646
1647 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1648 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1649 word size.
1650
1651 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1652 (gnutls_make_error): Rename local to avoid shadowing.
1653 (gnutls_emacs_global_deinit): ifdef out; not used.
1654 (Fgnutls_boot): Use const for pointer to readonly storage.
1655 Comment out unused local. Fix pointer signedness problems.
1656
1657 * lread.c (openp): Don't stuff size_t into an 'int'.
1658 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1659 about possible signed overflow.
1660
1661 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1662 (GDK_KEY_g): Don't define if already defined.
1663 (xg_prepare_tooltip): Avoid pointer signedness problem.
1664 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1665
1666 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1667 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1668
1669 * xfns.c (Fx_window_property): Simplify a bit,
1670 to make a bit faster and to avoid GCC 4.6.0 warning.
1671 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1672
1673 * fns.c (internal_equal): Don't assume size_t fits in int.
1674
1675 * alloc.c (compact_small_strings): Tighten assertion a little.
1676
1677 Replace pEd with more-general pI, and fix some printf arg casts.
1678 * lisp.h (pI): New macro, generalizing old pEd macro to other
1679 conversion specifiers. For example, use "...%"pI"d..." rather
1680 than "...%"pEd"...".
1681 (pEd): Remove. All uses replaced with similar uses of pI.
1682 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1683 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1684 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1685 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1686 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1687 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1688 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1689 64-bit hosts.
1690 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1691 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1692 * print.c (safe_debug_print, print_object): Likewise.
1693 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1694 to int.
1695 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1696 avoiding the 0 flag, which is not portable.
1697 * process.c (Fmake_network_process): Use pI to avoid cast.
1698 * region-cache.c (pp_cache): Likewise.
1699 * xdisp.c (decode_mode_spec): Likewise.
1700 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1701 behavior on 64-bit hosts with printf arg.
1702 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1703 (x_stop_queuing_selection_requests): Likewise.
1704 (x_get_window_property): Don't truncate byte count to an 'int'
1705 when tracing.
1706
1707 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1708 here, since it parses constructs like leading '-' and spaces,
1709 which are not wanted; and it overflows with large numbers.
1710 Instead, simply match F[0-9]+, which is what is wanted anyway.
1711
1712 * alloc.c: Remove unportable assumptions about struct layout.
1713 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1714 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1715 (allocate_vectorlike, make_pure_vector): Use the new macros,
1716 plus offsetof, to remove unportable assumptions about struct layout.
1717 These assumptions hold on all porting targets that I know of, but
1718 they are not guaranteed, they're easy to remove, and removing them
1719 makes further changes easier.
1720
1721 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1722 This doesn't fix a bug but makes the code clearer.
1723 (string_overrun_cookie): Now const. Use initializers that
1724 don't formally overflow signed char, to avoid warnings.
1725 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1726 can cause Emacs to crash when string overrun checking is enabled.
1727 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1728 multiple of sizeof (EMACS_INT); it need not be, if
1729 alignof(EMACS_INT) < sizeof (EMACS_INT).
1730 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1731
1732 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1733
1734 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1735
1736 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1737
1738 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1739 supposed to be handshaking. (Bug#8556)
1740 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1741
1742 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1743
1744 * lisp.h (Qdebug): List symbol.
1745 * eval.c (Qdebug): Restore global linkage.
1746 * keyboard.c (debug-on-event): New variable.
1747 (handle_user_signal): Break into debugger when debug-on-event
1748 matches the current signal symbol.
1749
1750 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1751
1752 * alloc.c (check_sblock, check_string_bytes)
1753 (check_string_free_list): Convert to standard C.
1754
1755 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1756
1757 * w32.c (emacs_gnutls_push): Fix typo.
1758
1759 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1760
1761 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1762 "cast to pointer from integer of different size".
1763
1764 Improve doprnt and its use in verror. (Bug#8545)
1765 * doprnt.c (doprnt): Document the set of format control sequences
1766 supported by the function. Use SAFE_ALLOCA instead of always
1767 using `alloca'.
1768
1769 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1770 is one byte too soon. Don't use xrealloc; instead xfree and
1771 xmalloc anew.
1772
1773 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1774
1775 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1776 callbacks stage.
1777
1778 * gnutls.c: Renamed global_initialized to
1779 gnutls_global_initialized. Added internals for the
1780 :verify-hostname-error, :verify-error, and :verify-flags
1781 parameters of `gnutls-boot' and documented those parameters in the
1782 docstring. Start callback support.
1783 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1784 unless a fatal error occured. Call gnutls_alert_send_appropriate
1785 on error. Return error code.
1786 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1787 (emacs_gnutls_read): Likewise.
1788 (Fgnutls_boot): Return handshake error code.
1789 (emacs_gnutls_handle_error): New function.
1790 (wsaerror_to_errno): Likewise.
1791
1792 * w32.h (emacs_gnutls_pull): Add prototype.
1793 (emacs_gnutls_push): Likewise.
1794
1795 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1796 (emacs_gnutls_push): Likewise.
1797
1798 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1799
1800 * process.c (wait_reading_process_output): Check if GnuTLS
1801 buffered some data internally if no FDs are set for TLS
1802 connections.
1803
1804 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1805 (LIBS): Link to USER_LIBS.
1806 ($(BLD)/gnutls.$(0)): New target.
1807
1808 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1809
1810 * xdisp.c (handle_single_display_spec): Rename the
1811 display_replaced_before_p argument into display_replaced_p, to
1812 make it consistent with the commentary. Fix typos in the
1813 commentary.
1814
1815 * textprop.c (syms_of_textprop): Remove dead code.
1816 (copy_text_properties): Delete obsolete commentary about an
1817 interface that was deleted long ago. Fix typos in the description
1818 of arguments.
1819
1820 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1821 to changes in oldXMenu/XMenu.h from 2011-04-16.
1822 <menu_help_message, prev_menu_help_message>: Constify.
1823 (IT_menu_make_room): menu->help_text is now `const char **';
1824 adjust.
1825
1826 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1827 to changes in oldXMenu/XMenu.h from 2011-04-16.
1828 (struct XMenu): Declare `help_text' `const char **'.
1829
1830 * xfaces.c <Qunspecified>: Make extern again.
1831
1832 * syntax.c: Include sys/types.h before including regex.h, as
1833 required by Posix.
1834
1835 * doc.c (get_doc_string): Improve the format passed to `error'.
1836
1837 * doprnt.c (doprnt): Improve commentary.
1838
1839 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1840
1841 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1842 them with etags.
1843
1844 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1845 changes in globals.h immediately force recompilation.
1846 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1847 $(CURDIR)/s/ms-w32.h.
1848 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1849
1850 * character.c (Fchar_direction): Function deleted.
1851 (syms_of_character): Don't defsubr it.
1852 <char-direction-table>: Deleted.
1853
1854 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1855
1856 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1857 * doprnt.c: Include limits.h.
1858 (SIZE_MAX): New macro.
1859 (doprnt): Return a size_t value. 2nd arg is now size_t.
1860 Many local variables are now size_t instead of int or unsigned.
1861 Improve overflow protection. Support `l' modifier for integer
1862 conversions. Support %l conversion. Don't assume an EMACS_INT
1863 argument for integer conversions and for %c.
1864
1865 * lisp.h (doprnt): Restore prototype.
1866
1867 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1868 $(SRC)/character.h.
1869
1870 * Makefile.in (base_obj): Add back doprnt.o.
1871
1872 * deps.mk (doprnt.o): Add back prerequisites.
1873 (callint.o): Depend on character.h.
1874
1875 * eval.c (internal_lisp_condition_case): Include the handler
1876 representation in the error message.
1877 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1878 when breaking from the loop.
1879
1880 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1881
1882 * callint.c (Fcall_interactively): When displaying error message
1883 about invalid control letter, pass the character's codepoint, not
1884 a pointer to its multibyte form. Improve display of the character
1885 in octal and display also its hex code.
1886
1887 * character.c (char_string): Use %x to display the (unsigned)
1888 codepoint of an invalid character, to avoid displaying a bogus
1889 negative value.
1890
1891 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1892 `error', not SYMBOL_NAME itself.
1893
1894 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1895 character arguments to `error'.
1896
1897 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1898 to `error' in error message about FINAL_CHAR argument. Make sure
1899 FINAL_CHAR is a character, and use %c when it is passed as
1900 argument to `error'.
1901
1902 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1903
1904 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1905
1906 * w32.c: Include <time.h>.
1907 (sys_localtime): New function.
1908
1909 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1910
1911 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1912
1913 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1914
1915 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1916
1917 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1918 zombies (Bug#8467).
1919
1920 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1921
1922 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1923 gl_state.e_property when gl_state.object is Qt.
1924
1925 * insdel.c (make_gap_larger): Remove limitation of buffer size
1926 to <= INT_MAX.
1927
1928 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1929
1930 * xdisp.c (lookup_glyphless_char_display)
1931 (produce_glyphless_glyph): Handle cons cell entry in
1932 glyphless-char-display.
1933 (Vglyphless_char_display): Document it.
1934
1935 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1936 glyphless-char-display.
1937
1938 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1939
1940 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1941
1942 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1943
1944 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1945 definition for no-X builds.
1946
1947 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Static checks with GCC 4.6.0 and non-default toolkits.
1950
1951 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1952
1953 * process.c (keyboard_bit_set): Define only if SIGIO.
1954 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1955 (send_process): Repair possible setjmp clobbering.
1956
1957 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1958
1959 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1960
1961 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1962
1963 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1964 Define only if needed.
1965
1966 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1967 by pacifying GCC about it. Maybe it's time to retire it?
1968 * xfaces.c (USG, __TIMEVAL__): Likewise.
1969
1970 * dispextern.h (struct redisplay_interface): Rename param
1971 to avoid shadowing.
1972 * termhooks.h (struct terminal): Likewise.
1973 * xterm.c (xembed_send_message): Likewise.
1974
1975 * insdel.c (make_gap_smaller): Define only if
1976 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1977
1978 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1979 it.
1980
1981 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1982 so that we aren't warned about unused symbols.
1983
1984 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1985
1986 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1987
1988 * xfns.c (x_real_positions): Mark locals as initialized.
1989
1990 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1991
1992 * xterm.c: Fix problems found by static analysis with other toolkits.
1993 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1994 (x_dispatch_event): Declare static if USE_GTK, and
1995 define if USE_GTK || USE_X_TOOLKIT.
1996 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1997 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1998 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1999 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2000
2001 * xmenu.c (menu_help_callback): Pointer type fixes.
2002 Use const pointers when pointing at readonly data. Avoid pointer
2003 signedness clashes.
2004 (FALSE): Remove unused macro.
2005 (update_frame_menubar): Remove unused decl.
2006
2007 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2008
2009 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2010 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2011 (single_menu_item): Rename local to avoid shadowing.
2012
2013 * keyboard.c (make_lispy_event): Remove unused local var.
2014
2015 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2016 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2017
2018 * bitmaps: Change bitmaps from unsigned char back to the X11
2019 compatible char. Avoid the old compiler warnings about
2020 out-of-range initializers by using, for example, '\xab' rather
2021 than 0xab.
2022
2023 * xgselect.c (xgselect_initialize): Check vs interface
2024 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2025
2026 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2027
2028 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2029 to read-only memory.
2030
2031 * fns.c (vector): Remove; this old hack is no longer needed.
2032
2033 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2034 Remove unused var.
2035 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2036
2037 * xrdb.c (x_load_resources): Omit unused local.
2038
2039 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2040 (x_window): Rename locals to avoid shadowing.
2041 (USG): Use the kludged USG macro, to pacify gcc.
2042
2043 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2044 (x_term_init): Remove local to avoid shadowing.
2045
2046 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2047
2048 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2049 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2050
2051 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2052
2053 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2054
2055 Fix regex.c, syntax.c and friends for buffers > 2GB.
2056 * syntax.h (struct gl_state_s): Declare character position members
2057 EMACS_INT.
2058
2059 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2060
2061 * textprop.c (verify_interval_modification, interval_of):
2062 Declare arguments EMACS_INT.
2063
2064 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2065 EMACS_INT.
2066
2067 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2068
2069 * indent.c (Fvertical_motion): Local variable it_start is now
2070 EMACS_INT.
2071
2072 * regex.c (re_match, re_match_2, re_match_2_internal)
2073 (bcmp_translate, regcomp, regexec, print_double_string)
2074 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2075 (re_compile_pattern, re_exec): Declare arguments and local
2076 variables `size_t' and `ssize_t' and return values `regoff_t', as
2077 appropriate.
2078 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2079 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2080 <compile_stack_type>: `size' and `avail' are now `size_t'.
2081
2082 * regex.h <regoff_t>: Use ssize_t, not int.
2083 (re_search, re_search_2, re_match, re_match_2): Arguments that
2084 specify buffer/string position and length are now ssize_t and
2085 size_t. Return type is regoff_t.
2086
2087 2011-04-16 Ben Key <bkey76@gmail.com>
2088
2089 * nsfont.m: Fixed bugs in ns_get_family and
2090 ns_descriptor_to_entity that were caused by using free to
2091 deallocate memory blocks that were allocated by xmalloc (via
2092 xstrdup). This caused Emacs to crash when compiled with
2093 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2094 --enable-checking=xmallocoverrun). xfree is now used to
2095 deallocate these memory blocks.
2096
2097 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2100
2101 emacs_write: Accept and return EMACS_INT for sizes.
2102 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2103 et seq.
2104 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2105 Accept and return EMACS_INT.
2106 (emacs_gnutls_write): Return the number of bytes written on
2107 partial writes.
2108 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2109 (emacs_read, emacs_write): Remove check for negative size, as the
2110 Emacs source code has been audited now.
2111 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2112 (emacs_read, emacs_write): Use it.
2113 * process.c (send_process): Adjust to the new signatures of
2114 emacs_write and emacs_gnutls_write. Do not attempt to store
2115 a byte offset into an 'int'; it might overflow.
2116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2117
2118 * sound.c: Don't assume sizes fit in 'int'.
2119 (struct sound_device.period_size, alsa_period_size):
2120 Return EMACS_INT, not int.
2121 (struct sound_device.write, vox_write, alsa_write):
2122 Accept EMACS_INT, not int.
2123 (wav_play, au_play): Use EMACS_INT to store sizes and to
2124 record read return values.
2125
2126 2011-04-15 Ben Key <bkey76@gmail.com>
2127
2128 * keyboard.c (Qundefined): Don't declare static since it is used
2129 in nsfns.m.
2130 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2131 static since they are used in nsfont.m.
2132
2133 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2134
2135 * process.c (Qprocessp): Don't declare static.
2136 * lisp.h (Qprocessp): Declare again.
2137
2138 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2139
2140 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2141
2142 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 Improve C-level modularity by making more things 'static'.
2145
2146 Don't publish debugger-only interfaces to other modules.
2147 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2148 (verify_bytepos, count_markers): Move decls to the only modules
2149 that need them.
2150 * region-cache.h (pp_cache): Likewise.
2151 * window.h (check_all_windows): Likewise.
2152 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2153
2154 * sysdep.c (croak): Now static, if
2155 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2156 * syssignal.h (croak): Declare only if not static.
2157
2158 * alloc.c (refill_memory_reserve): Now static if
2159 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2160 * lisp.h (refill_memory_reserve): Declare only if not static.
2161
2162 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2163 Define only if USE_LUCID.
2164
2165 * xrdb.c (x_customization_string, x_rm_string): Now static.
2166
2167 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2168 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2169
2170 * xdisp.c (draw_row_with_mouse_face): Now static.
2171 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2172
2173 * window.h (check_all_windows): Mark externally visible.
2174
2175 * window.c (window_deletion_count): Now static.
2176
2177 * undo.c: Make symbols static if they're not exported.
2178 (last_undo_buffer, last_boundary_position, pending_boundary):
2179 Now static.
2180
2181 * textprop.c (interval_insert_behind_hooks): Now static.
2182 (interval_insert_in_front_hooks): Likewise.
2183
2184 * term.c: Make symbols static if they're not exported.
2185 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2186 (max_frame_lines, tty_set_terminal_modes):
2187 (tty_reset_terminal_modes, tty_turn_off_highlight):
2188 (get_tty_terminal): Now static.
2189 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2190 * termhooks.h (term_mouse_moveto): Do not declare if
2191 HAVE_WINDOW_SYSTEM.
2192 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2193 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2194
2195 * sysdep.c: Make symbols static if they're not exported.
2196 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2197 Now static.
2198 (sigprocmask_set, full_mask): Remove; unused.
2199 (wait_debugging): Mark as visible.
2200 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2201 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2202
2203 * syntax.c (syntax_temp): Define only if !__GNUC__.
2204
2205 * sound.c (current_sound_device, current_sound): Now static.
2206
2207 * search.c (searchbufs, searchbuf_head): Now static.
2208
2209 * scroll.c (scroll_cost): Remove; unused.
2210 * dispextern.h (scroll_cost): Remove decl.
2211
2212 * region-cache.h (pp_cache): Mark as externally visible.
2213
2214 * process.c: Make symbols static if they're not exported.
2215 (process_tick, update_tick, create_process, chan_process):
2216 (Vprocess_alist, proc_buffered_char, datagram_access):
2217 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2218 (deactivate_process): Mark defn as static, as well as decl.
2219 * lisp.h (create_process): Remove decl.
2220 * process.h (chan_process, Vprocess_alist): Remove decls.
2221
2222 * print.c: Make symbols static if they're not exported.
2223 (print_depth, new_backquote_output, being_printed, print_buffer):
2224 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2225 (print_interval, print_number_index, initial_stderr_stream):
2226 Now static.
2227 * lisp.h (Fprinc): Remove decl.
2228 (debug_output_compilation_hack): Mark as externally visible.
2229
2230 * sysdep.c (croak): Move decl from here to syssignal.h.
2231 * syssignal.h (croak): Put it here, so the API can be checked when
2232 'croak' is called from dissociate_if_controlling_tty.
2233
2234 * minibuf.c: Make symbols static if they're not exported.
2235 (minibuf_save_list, choose_minibuf_frame): Now static.
2236 * lisp.h (choose_minibuf_frame): Remove decl.
2237
2238 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2239
2240 * lread.c: Make symbols static if they're not exported.
2241 (read_objects, initial_obarray, oblookup_last_bucket_number):
2242 Now static.
2243 (make_symbol): Remove; unused.
2244 * lisp.h (initial_obarray, make_symbol): Remove decls.
2245
2246 * keyboard.c: Make symbols static if they're not exported.
2247 (single_kboard, recent_keys_index, total_keys, recent_keys):
2248 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2249 (this_single_command_key_start, echoing, last_auto_save):
2250 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2251 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2252 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2253 (Vlispy_mouse_stem, double_click_count):
2254 Now static.
2255 (force_auto_save_soon): Define only if SIGDANGER.
2256 (ignore_mouse_drag_p): Now static if
2257 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2258 (print_help): Remove; unused.
2259 (stop_character, last_timer_event): Mark as externally visible.
2260 * keyboard.h (ignore_mouse_drag_p): Declare only if
2261 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2262 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2263 * lisp.h (echoing): Remove decl.
2264 (force_auto_save_soon): Declare only if SIGDANGER.
2265 * xdisp.c (redisplay_window): Simplify code, to make it more
2266 obvious that ignore_mouse_drag_p is not accessed if !defined
2267 USE_GTK && !defined HAVE_NS.
2268
2269 * intervals.c: Make symbols static if they're not exported.
2270 (merge_properties_sticky, merge_interval_right, delete_interval):
2271 Now static.
2272 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2273
2274 * insdel.c: Make symbols static if they're not exported.
2275 However, leave prepare_to_modify_buffer alone. It's never
2276 called from outside this function, but that appears to be a bug.
2277 (combine_after_change_list, combine_after_change_buffer):
2278 (adjust_after_replace, signal_before_change): Now static.
2279 (adjust_after_replace_noundo): Remove; unused.
2280 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2281 (signal_before_change): Remove decls.
2282
2283 * indent.c (val_compute_motion, val_vmotion): Now static.
2284
2285 * image.c: Make symbols static if they're not exported.
2286 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2287 if USE_GTK.
2288 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2289 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2290
2291 * fringe.c (standard_bitmaps): Now static.
2292 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2293
2294 * frame.c: Make symbols static if they're not exported.
2295 (x_report_frame_params, make_terminal_frame): Now static.
2296 (get_frame_param): Now static, unless HAVE_NS.
2297 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2298 (x_get_resource_string): Remove; not used.
2299 * frame.h (make_terminal_frame, x_report_frame_params):
2300 (x_get_resource_string); Remove decls.
2301 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2302 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2303
2304 * font.c, fontset.c: Make symbols static if they're not exported.
2305 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2306 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2307 * font.c (font_close_object): Now static.
2308 * font.h (font_close_object): Remove.
2309 * fontset.c (FONTSET_OBJLIST): Remove.
2310 (free_realized_fontset) #if-0 the body, which does nothing.
2311 (face_suitable_for_char_p): #if-0, as it's never called.
2312 * fontset.h (face_suitable_for_char_p): Remove decl.
2313 * xfaces.c (face_at_string_position):
2314 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2315 since 0 is always ASCII.
2316
2317 * fns.c (weak_hash_tables): Now static.
2318
2319 * fileio.c: Make symbols static if they're not exported.
2320 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2321 (Vwrite_region_annotation_buffers): Now static.
2322
2323 * eval.c: Make symbols static if they're not exported.
2324 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2325 * lisp.h (backtrace_list): Remove decl.
2326
2327 * emacs.c: Make symbols static if they're not exported.
2328 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2329 (fatal_error_code, fatal_error_signal_hook, standard_args):
2330 Now static.
2331 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2332 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2333 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2334 * lisp.h (fatal_error_signal_hook): Remove decl.
2335 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2336
2337 * editfns.c: Move a (normally-unused) function to its only use.
2338 * editfns.c, lisp.h (get_operating_system_release): Remove.
2339 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2340 worth the hassle of breaking this out.
2341
2342 * xterm.c: Make symbols static if they're not exported.
2343 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2344 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2345 (x_destroy_window, x_delete_display):
2346 Now static.
2347 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2348 (x_mouse_leave): Remove; unused.
2349 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2350 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2351 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2352 Remove decls.
2353 (x_mouse_leave): Declare only if WINDOWSNT.
2354 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2355 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2356 USE_X_TOOLKIT.
2357
2358 * ftxfont.c: Make symbols static if they're not exported.
2359 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2360 HAVE_FREETYPE.
2361 * font.h (ftxfont_driver): Likewise.
2362
2363 * xfns.c: Make symbols static if they're not exported.
2364 (x_last_font_name, x_display_info_for_name):
2365 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2366 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2367 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2368 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2369 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2370 (last_show_tip_args): Now static.
2371 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2372 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2373 (x_screen_planes): Remove; unused.
2374 * dispextern.h (x_screen_planes): Remove decl.
2375
2376 * dispnew.c: Make symbols static if they're not exported.
2377 * dispextern.h (redraw_garbaged_frames, scrolling):
2378 (increment_row_positions): Remove.
2379 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2380 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2381 Now static.
2382 (redraw_garbaged_frames): Remove; unused.
2383
2384 * xfaces.c: Make symbols static if they're not exported.
2385 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2386 Remove decls.
2387 * xterm.h (defined_color): Remove decls.
2388 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2389 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2390 (menu_face_changed_default, defined_color, free_realized_face):
2391 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2392 (ascii_face_of_lisp_face): Remove; unused.
2393
2394 * xdisp.c: Make symbols static if they're not exported.
2395 * dispextern.h (scratch_glyph_row, window_box_edges):
2396 (glyph_to_pixel_coords, set_cursor_from_row):
2397 (get_next_display_element, set_iterator_to_next):
2398 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2399 (show_mouse_face): Remove decls
2400 * frame.h (message_buf_print): Likewise.
2401 * lisp.h (pop_message, set_message, check_point_in_composition):
2402 Likewise.
2403 * xterm.h (set_vertical_scroll_bar): Likewise.
2404 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2405 (message_buf_print, scratch_glyph_row, displayed_buffer):
2406 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2407 (get_next_display_element, show_mouse_face, window_box_edges):
2408 (frame_to_window_pixel_xy, check_point_in_composition):
2409 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2410 (glyph_to_pixel_coords): Remove; unused.
2411
2412 * dired.c (file_name_completion): Now static.
2413
2414 * dbusbind.c (xd_in_read_queued_messages): Now static.
2415
2416 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2417 * data.c (circular_list_error): Remove.
2418
2419 * commands.h (last_point_position, last_point_position_buffer):
2420 (last_point_position_window): Remove decls.
2421 * keyboard.c: Make these variables static.
2422
2423 * coding.h (coding, code_convert_region, encode_coding_gap):
2424 Remove decls.
2425 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2426 (iso_code_class, detect_coding, code_convert_region): Now static.
2427 (encode_coding_gap): Remove; unused.
2428
2429 * chartab.c (chartab_chars, chartab_bits): Now static.
2430
2431 * charset.h (charset_iso_8859_1): Remove decl.
2432 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2433 Now static.
2434
2435 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2436 * ccl.c (Vccl_program_table): Now static.
2437 (check_ccl_update): Remove; unused.
2438
2439 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2440 * category.h: ... from here.
2441 * category.c (check_category_table, set_category_set): Now static.
2442
2443 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2444 * lisp.h: Remove these decls.
2445
2446 * buffer.c (buffer_count): Remove unused var.
2447
2448 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2449 so that it's not optimized away.
2450 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2451 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2452 exported only to the debugger.
2453
2454 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2455 * atimer.h (run_all_atimers): Remove; not exported.
2456
2457 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2458 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2459 was inaccessible from Lisp.
2460 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2461 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2462
2463 alloc.c: Import and export fewer symbols, and remove unused items.
2464 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2465 is defined.
2466 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2467 it's not optimized away by whole-program optimization.
2468 (message_enable_multibyte, free_misc): Remove.
2469 (catchlist, handlerlist, mark_backtrace):
2470 Declare only if BYTE_MARK_STACK.
2471 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2472 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2473 (message_enable_multibyte): Remove decl.
2474 (free_misc, interval_free_list, float_block, float_block_index):
2475 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2476 (cons_free_list, last_marked_index):
2477 Now static.
2478 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2479 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2480 (mark_backtrace): Define only if BYTE_MARK_STACK.
2481 * xdisp.c (message_enable_multibyte): Now static.
2482
2483 Declare Lisp_Object Q* variables to be 'static' if not exported.
2484 This makes it easier for human readers (and static analyzers)
2485 to see whether these variables are used from other modules.
2486 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2487 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2488 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2489 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2490 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2491 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2492 * xmenu.c, xselect.c:
2493 Declare Q* vars static if they are not used in other modules.
2494 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2495 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2496 Remove decls of unexported vars.
2497 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2498
2499 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2500
2501 Make Emacs functions such as Fatom 'static' by default.
2502 This makes it easier for human readers (and static analyzers)
2503 to see whether these functions can be called from other modules.
2504 DEFUN now defines a static function. To make the function external
2505 so that it can be used in other C modules, use the new macro DEFUE.
2506 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2507 (Finit_image_library):
2508 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2509 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2510 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2511 Remove decls, since these functions are now static.
2512 (Funintern, Fget_internal_run_time): New decls, since these functions
2513 were already external.
2514
2515 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2516 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2517 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2518 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2519 * keyboard.c, keymap.c, lread.c:
2520 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2521 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2522 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2523 Mark functions with DEFUE instead of DEFUN,
2524 if they are used in other modules.
2525 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2526 decls for now-static functions.
2527 * buffer.h (Fdelete_overlay): Remove decl.
2528 * callproc.c (Fgetenv_internal): Mark as internal.
2529 * composite.c (Fremove_list_of_text_properties): Remove decl.
2530 (Fcomposition_get_gstring): New forward static decl.
2531 * composite.h (Fcomposite_get_gstring): Remove decl.
2532 * dired.c (Ffile_attributes): New forward static decl.
2533 * doc.c (Fdocumntation_property): New forward static decl.
2534 * eval.c (Ffetch_bytecode): New forward static decl.
2535 (Funintern): Remove extern decl; now in .h file where it belongs.
2536 * fileio.c (Fmake_symbolic_link): New forward static decl.
2537 * image.c (Finit_image_library): New forward static decl.
2538 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2539 * intervals.h (Fprevious_property_change):
2540 (Fremove_list_of_text_properties): Remove decls.
2541 * keyboard.c (Fthis_command_keys): Remove decl.
2542 (Fcommand_execute): New forward static decl.
2543 * keymap.c (Flookup_key): New forward static decl.
2544 (Fcopy_keymap): Now static.
2545 * keymap.h (Flookup_key): Remove decl.
2546 * process.c (Fget_process): New forward static decl.
2547 (Fprocess_datagram_address): Mark as internal.
2548 * syntax.c (Fsyntax_table_p): New forward static decl.
2549 (skip_chars): Remove duplicate decl.
2550 * textprop.c (Fprevious_property_change): New forward static decl.
2551 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2552 Now internal.
2553 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2554 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2555
2556 * editfns.c (Fformat): Remove unreachable code.
2557
2558 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2559
2560 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2561 change. (Bug#8496)
2562
2563 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2564
2565 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2566 when at ZV. (Bug#8487)
2567
2568 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2569
2570 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2571 (Bug#8437)
2572 * keyboard.c (parse_tool_bar_item): Likewise.
2573 * sound.c (sound_cleanup, alsa_close): Likewise.
2574 * termcap.c (tgetent): Likewise.
2575 * xfns.c (x_default_font_parameter): Likewise.
2576 * xsettings.c (read_and_apply_settings): Likewise.
2577
2578 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2579 (overrun_check_free): Protoize.
2580
2581 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2582
2583 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2584 since callers should never pass a negative size.
2585 Change the signature to match that of plain 'read' and 'write'; see
2586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2587 * lisp.h: Update prototypes of emacs_write and emacs_read.
2588
2589 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2590
2591 * xdisp.c (redisplay_window): Don't try to determine the character
2592 position of the scroll margin if the window start point w->startp
2593 is outside the buffer's accessible region. (Bug#8468)
2594
2595 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2596
2597 Fix write-region and its subroutines for buffers > 2GB.
2598 * fileio.c (a_write, e_write): Modify declaration of arguments and
2599 local variables to support buffers larger than 2GB.
2600 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2601
2602 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2603 argument, local variables, and return value.
2604
2605 * lisp.h: Update prototypes of emacs_write and emacs_read.
2606
2607 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2608
2609 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2612
2613 Fix more problems found by GCC 4.6.0's static checks.
2614
2615 * xdisp.c (vmessage): Use a better test for character truncation.
2616
2617 * charset.c (load_charset_map): <, not <=, for optimization,
2618 and to avoid potential problems with integer overflow.
2619 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2620 * casetab.c (set_identity, shuffle): Likewise.
2621 * editfns.c (Fformat): Likewise.
2622 * syntax.c (skip_chars): Likewise.
2623
2624 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2625 This also lets GCC 4.6.0 generate slightly better loop code.
2626
2627 * callint.c (Fcall_interactively): <, not <=, for optimization.
2628 (Fcall_interactively): Count the number of arguments produced,
2629 not the number of arguments given. This is simpler and lets GCC
2630 4.6.0 generate slightly better code.
2631
2632 * ftfont.c: Distingish more carefully between FcChar8 and char.
2633 The previous code passed unsigned char * to a functions like
2634 strlen and xstrcasecmp that expect char *, which does not
2635 conform to the C standard.
2636 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2637 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2638 char * when the C standard requires it.
2639
2640 * keyboard.c (read_char): Remove unused var.
2641
2642 * eval.c: Port to Windows vsnprintf (Bug#8435).
2643 Include <limits.h>.
2644 (SIZE_MAX): Define if the headers do not.
2645 (verror): Do not give up if vsnprintf returns a negative count.
2646 Instead, grow the buffer. This ports to Windows vsnprintf, which
2647 does not conform to C99. Problem reported by Eli Zaretskii.
2648 Also, simplify the allocation scheme, by avoiding the need for
2649 calling realloc, and removing the ALLOCATED variable.
2650
2651 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2652
2653 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2654 But keep the doprint source code for now, as we might revamp it
2655 and use it again (Bug#8435).
2656 * lisp.h (doprnt): Remove.
2657 * Makefile.in (base_obj): Remove doprnt.o.
2658 * deps.mk (doprnt.o): Remove.
2659
2660 error: Print 32- and 64-bit integers portably (Bug#8435).
2661 Without this change, on typical 64-bit hosts error ("...%d...", N)
2662 was used to print both 32- and 64-bit integers N, which relied on
2663 undefined behavior.
2664 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2665 New macro.
2666 * lisp.h (error, verror): Mark as printf-like functions.
2667 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2668 Report overflow in size calculations when allocating printf buffer.
2669 Do not truncate output string at its first null byte.
2670 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2671 Truncate the output at a character boundary, since vsnprintf does not
2672 do that.
2673 * charset.c (check_iso_charset_parameter): Convert internal
2674 character to string before calling 'error', since %c now has the
2675 printf meaning.
2676 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2677 overflow when computing char to be passed to 'error'. Do not
2678 pass Lisp_Object to 'error'; pass the integer instead.
2679 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2680 formatted with plain %d.
2681
2682 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2683
2684 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2685
2686 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2687
2688 * xterm.c (x_catch_errors): Remove duplicate declaration.
2689
2690 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2691
2692 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2693
2694 2011-04-10 Jim Meyering <meyering@redhat.com>
2695
2696 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2697 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2698 return ssize_t not "int", and use size_t as the buffer length.
2699 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2700 * gnutls.h: Update declarations.
2701 * process.c (read_process_output): Use ssize_t, to match.
2702 (send_process): Likewise.
2703
2704 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2705
2706 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2707
2708 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2709
2710 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2711 Use unsigned char, to match FcChar8 type definition.
2712
2713 * xterm.c (handle_one_xevent):
2714 * xmenu.c (create_and_show_popup_menu):
2715 * xselect.c (x_decline_selection_request)
2716 (x_reply_selection_request): Avoid type-punned deref of X events.
2717
2718 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2719
2720 Fix some uses of `int' instead of EMACS_INT.
2721 * search.c (string_match_1, fast_string_match)
2722 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2723 (scan_buffer, find_next_newline_no_quit)
2724 (find_before_next_newline, search_command, Freplace_match)
2725 (Fmatch_data): Make some `int' variables be EMACS_INT.
2726
2727 * xdisp.c (display_count_lines): 3rd argument and return value now
2728 EMACS_INT. All callers changed.
2729 (pint2hrstr): Last argument is now EMACS_INT.
2730
2731 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2732 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2733 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2734 (decode_coding_utf_16, decode_coding_emacs_mule)
2735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2736 (decode_coding_ccl, decode_coding_charset)
2737 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2738 (decode_coding_iso_2022, decode_coding_emacs_mule)
2739 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2740 <char_offset, last_offset>: Declare EMACS_INT.
2741 (encode_coding_utf_8, encode_coding_utf_16)
2742 (encode_coding_emacs_mule, encode_invocation_designation)
2743 (encode_designation_at_bol, encode_coding_iso_2022)
2744 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2745 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2746 Declare EMACS_INT.
2747 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2748 (encode_invocation_designation): Last argument P_NCHARS is now
2749 EMACS_INT.
2750 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2751 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2752
2753 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2754 All users changed.
2755
2756 * ccl.c (Fccl_execute_on_string): Declare some variables
2757 EMACS_INT.
2758
2759 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2760
2761 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2762
2763 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2764
2765 * process.c (Fformat_network_address): Doc fix.
2766
2767 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2768
2769 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2770
2771 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2772
2773 * keyboard.c (read_char): Call Lisp function help-form-show,
2774 instead of using internal_with_output_to_temp_buffer.
2775 (Qhelp_form_show): New var.
2776 (syms_of_keyboard): Use DEFSYM macro.
2777
2778 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2779
2780 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2781
2782 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2783
2784 * process.c (Flist_processes): Remove to Lisp.
2785 (list_processes_1): Delete.
2786
2787 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2788
2789 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2790
2791 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2792
2793 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2794
2795 Fix more problems found by GCC 4.6.0's static checks.
2796
2797 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2798
2799 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2800
2801 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2802
2803 * xdisp.c (vmessage): Mark as a printf-like function.
2804
2805 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2806
2807 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2808
2809 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2810 printf-like functions.
2811 (tiff_load): Add casts to remove these marks before passing them
2812 to system-supplied API.
2813
2814 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2815
2816 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2817 This avoids several warnings with gcc -Wstrict-overflow.
2818 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2819 directly, rather than having caller test rule sign. This avoids
2820 some unnecessary tests.
2821 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2822 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2823 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2824
2825 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2826 (xfont_open): Avoid unnecessary tests.
2827
2828 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2829
2830 * composite.h, composite.c (composition_gstring_put_cache):
2831 Use EMACS_INT, not int, for length.
2832
2833 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2834 breaking out part of COMPOSITION_DECODE_RULE.
2835 (COMPOSITION_DECODE_RULE): Use it.
2836 * composite.c (get_composition_id): Remove unused local vars,
2837 by using the new macro.
2838
2839 * textprop.c (set_text_properties_1): Change while to do-while,
2840 since the condition is always true at first.
2841
2842 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2843 (interval_deletion_adjustment): Return unsigned value.
2844 All uses changed.
2845
2846 * process.c (list_processes_1, create_pty, read_process_output):
2847 (exec_sentinel): Remove vars that were set but not used.
2848 (create_pty): Remove unnecessary "volatile"s.
2849 (Fnetwork_interface_info): Avoid possibility of int overflow.
2850 (read_process_output): Do adaptive read buffering even if carryover.
2851 (read_process_output): Simplify nbytes computation if buffered.
2852
2853 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2854
2855 * syntax.c (scan_words): Remove var that was set but not used.
2856 (update_syntax_table): Use unsigned instead of int.
2857
2858 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2859 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2860 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2861
2862 * print.c (print_error_message): Avoid int overflow.
2863
2864 * font.c (font_list_entities): Redo for clarity,
2865 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2866
2867 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2868 (font_score): Avoid potential overflow in diff calculation.
2869
2870 * fns.c (substring_both): Remove var that is set but not used.
2871 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2872
2873 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2874
2875 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2876 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2877 can always succeed if overflow has undefined behavior.
2878
2879 * search.c (boyer_moore, wordify): Remove vars set but not used.
2880 (wordify): Omit three unnecessary tests.
2881
2882 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2883 All callers changed. This avoids the need for an unused var.
2884
2885 * casefiddle.c (casify_region): Remove var that is set but not used.
2886
2887 * dired.c (file_name_completion): Remove var that is set but not used.
2888
2889 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2890
2891 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2892 (Finsert_file_contents): Remove unnecessary code checking fd.
2893
2894 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2895 Check for integer overflow on size calculations.
2896
2897 * buffer.c (Fprevious_overlay_change): Remove var that is set
2898 but not used.
2899
2900 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2901 Remove vars that are set but not used.
2902 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2903 (timer_check_2): Mark vars as initialized.
2904
2905 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2906
2907 * image.c (lookup_image): Remove var that is set but not used.
2908 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2909
2910 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2911 that are set but not used.
2912
2913 * xfns.c (make_invisible_cursor): Don't return garbage
2914 if XCreateBitmapFromData fails (Bug#8410).
2915
2916 * xselect.c (x_get_local_selection, x_handle_property_notify):
2917 Remove vars that are set but not used.
2918
2919 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2920 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2921
2922 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2923 Remove var that is set but not used.
2924 (scroll_bar_windows_size): Now size_t, not int.
2925 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2926 Check for overflow.
2927
2928 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2929 (map_tty_color) [!defined MSDOS]: Likewise.
2930
2931 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2932
2933 * coding.c: Remove vars that are set but not used.
2934 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2935 All callers changed.
2936 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2937 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2938 (decode_coding_charset): Remove vars that are set but not used.
2939
2940 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2941 that is set but not used.
2942
2943 * print.c (print_object): Remove var that is set but not used.
2944
2945 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2946 The gnulib version avoids calling malloc in the usual case,
2947 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2948 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2949 * filelock.c (current_lock_owner): Likewise.
2950 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2951 * sysdep.c: Include allocator.h, careadlinkat.h.
2952 (emacs_no_realloc_allocator): New static constant.
2953 (emacs_readlink): New function.
2954 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2955 ../lib/careadlinkat.h.
2956
2957 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2958
2959 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2960 first non-nil return value).
2961
2962 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2963
2964 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2965 if not defined (Bug#8403).
2966
2967 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2968
2969 * xdisp.c (display_count_lines): Remove parameter `start',
2970 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2971 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2972 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2973 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2974 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2975 and thereabouts. All callers changed.
2976 (get_per_char_metric): Remove parameter `f', unused since
2977 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2978
2979 2011-04-02 Jim Meyering <meyering@redhat.com>
2980
2981 do not dereference NULL upon failed strdup
2982 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2983 (ns_get_family): Likewise.
2984
2985 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2986
2987 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2988
2989 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2990
2991 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2992 later (Bug#8403).
2993
2994 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2995
2996 Add lexical binding.
2997
2998 * window.c (Ftemp_output_buffer_show): New fun.
2999 (Fsave_window_excursion):
3000 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3001
3002 * lread.c (lisp_file_lexically_bound_p): New function.
3003 (Fload): Bind Qlexical_binding.
3004 (readevalloop): Remove `evalfun' arg.
3005 Bind Qinternal_interpreter_environment.
3006 (Feval_buffer): Bind Qlexical_binding.
3007 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3008 Mark as dynamic.
3009 (syms_of_lread): Declare `lexical-binding'.
3010
3011 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3012
3013 * keyboard.c (eval_dyn): New fun.
3014 (menu_item_eval_property): Use it.
3015
3016 * image.c (parse_image_spec): Use Ffunctionp.
3017
3018 * fns.c (concat, mapcar1): Accept byte-code-functions.
3019
3020 * eval.c (Fsetq): Handle lexical vars.
3021 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3022 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3023 (FletX, Flet): Obey lexical binding.
3024 (Fcommandp): Handle closures.
3025 (Feval): New `lexical' arg.
3026 (eval_sub): New function extracted from Feval. Use it almost
3027 everywhere where Feval was used. Look up vars in lexical env.
3028 Handle closures.
3029 (Ffunctionp): Move from subr.el.
3030 (Ffuncall): Handle closures.
3031 (apply_lambda): Remove `eval_flags'.
3032 (funcall_lambda): Handle closures and new byte-code-functions.
3033 (Fspecial_variable_p): New function.
3034 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3035 but without exporting it to Lisp.
3036
3037 * doc.c (Fdocumentation, store_function_docstring):
3038 * data.c (Finteractive_form): Handle closures.
3039
3040 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3041 interactive spec.
3042
3043 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3044 New byte-codes.
3045 (exec_byte_code): New function extracted from Fbyte_code to handle new
3046 calling convention for byte-code-functions. Add new byte-codes.
3047
3048 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3049
3050 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3051
3052 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3053
3054 * xdisp.c (redisplay_internal): Fix prototype.
3055
3056 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3057
3058 * xdisp.c (SCROLL_LIMIT): New macro.
3059 (try_scrolling): Use it when setting scroll_limit.
3060 Limit scrolling to 100 screen lines.
3061 (redisplay_window): Even when falling back on "recentering",
3062 position point in the window according to scroll-conservatively,
3063 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3064
3065 (try_scrolling): When point is above the window, allow searching
3066 as far as scroll_max, or one screenful, to compute vertical
3067 distance from PT to the scroll margin position. This prevents
3068 try_scrolling from unnecessarily failing when
3069 scroll-conservatively is set to a value slightly larger than the
3070 window height. Clean up the case of PT below the margin at bottom
3071 of window: scroll_max can no longer be INT_MAX. When aggressive
3072 scrolling is in use, don't let point enter the opposite scroll
3073 margin as result of the scroll.
3074 (syms_of_xdisp) <scroll-conservatively>: Document the
3075 threshold of 100 lines for never-recentering scrolling.
3076
3077 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3078
3079 * dispextern.h (move_it_by_lines):
3080 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3081 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3082 (message_log_check_duplicate): Remove parameters `prev_bol' and
3083 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3084 (redisplay_internal): Remove parameter `preserve_echo_area',
3085 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3086
3087 * indent.c (Fvertical_motion):
3088 * window.c (window_scroll_pixel_based, Frecenter):
3089 Don't pass `need_y_p' to `move_it_by_lines'.
3090
3091 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3092
3093 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3094 steal a few bits to be more compact.
3095 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3096 Remove unneeded casts.
3097
3098 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3099
3100 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3101
3102 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3103 binding" message (bug#7967).
3104
3105 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3106
3107 Fix more problems found by GCC 4.6.0's static checks.
3108
3109 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3110 Remove unused local var.
3111
3112 * editfns.c (Fmessage_box): Remove unused local var.
3113
3114 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3115 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3116 Omit unused local vars.
3117 * window.c (shrink_windows): Omit unused local var.
3118 * menu.c (digest_single_submenu): Omit unused local var.
3119 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3120 Omit unused local var.
3121
3122 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3123 Don't assume string length fits in int.
3124 (keyremap_step, read_key_sequence): Use size_t for sizes.
3125 (read_key_sequence): Don't check last_real_key_start redundantly.
3126
3127 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3128 instead of alloca (Bug#8344).
3129
3130 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3131 (Fbacktrace_frame): Don't assume nframes fits in int.
3132
3133 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3134
3135 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3136 concerns.
3137
3138 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3139
3140 * cm.c (calccost): Turn while-do into do-while, for clarity.
3141
3142 * keyboard.c (syms_of_keyboard): Use the same style as later
3143 in this function when indexing through an array. This also
3144 works around GCC bug 48267.
3145
3146 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3147
3148 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3149
3150 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3151 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3152
3153 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3154 This avoids undefined behavior on integer overflow, and is a bit
3155 more convenient anyway since it is compared to a size_t variable.
3156
3157 Variadic C functions now count arguments with size_t, not int.
3158 This avoids an unnecessary limitation on 64-bit machines, which
3159 caused (substring ...) to crash on large vectors (Bug#8344).
3160 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3161 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3162 All variadic functions and their callers changed accordingly.
3163 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3164 * data.c (arith_driver, float_arith_driver): Likewise.
3165 * editfns.c (general_insert_function): Likewise.
3166 * eval.c (struct backtrace.nargs, interactive_p)
3167 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3168 (funcall_lambda, mark_backtrace): Likewise.
3169 * fns.c (concat): Likewise.
3170 * frame.c (x_set_frame_parameters): Likewise.
3171 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3172 0 if not found, not -1. All callers changed.
3173
3174 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3175 (stack_copy_size): Now size_t, not int.
3176 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3177
3178 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3179
3180 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3181 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3182 All callers changed.
3183
3184 * lisp.h (multibyte_char_to_unibyte):
3185 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3186 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3187 * character.h (CHAR_TO_BYTE8):
3188 * cmds.c (internal_self_insert):
3189 * editfns.c (general_insert_function):
3190 * keymap.c (push_key_description):
3191 * search.c (Freplace_match):
3192 * xdisp.c (message_dolog, set_message_1): All callers changed.
3193
3194 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3195
3196 * keyboard.c (safe_run_hook_funcall): New function.
3197 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3198 don't set the hook to nil, but remove the offending function instead.
3199 (Qcommand_hook_internal): Remove, unused.
3200 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3201 Vcommand_hook_internal.
3202
3203 * eval.c (enum run_hooks_condition): Remove.
3204 (funcall_nil, funcall_not): New functions.
3205 (run_hook_with_args): Call each function through a `funcall' argument.
3206 Remove `cond' argument, now redundant.
3207 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3208 (Frun_hook_with_args_until_failure): Adjust accordingly.
3209 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3210
3211 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3212
3213 * dispextern.h (string_buffer_position): Remove declaration.
3214
3215 * print.c (strout): Remove parameter `multibyte', unused since
3216 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3217
3218 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3219 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3220 All callers changed.
3221
3222 * w32.c (_wsa_errlist): Use braces for struct initializers.
3223
3224 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3225 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3226 All callers changed.
3227 (string_buffer_position): Likewise. Also, make static (it's never
3228 used outside xdisp.c).
3229 (cursor_row_p): Remove parameter `w', unused since
3230 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3231 (decode_mode_spec): Remove parameter `precision', introduced during
3232 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3233 All callers changed.
3234
3235 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3236
3237 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3238
3239 2011-03-27 Anders Lindgren <andlind@gmail.com>
3240
3241 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3242 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3243 (ns_update_auto_hide_menu_bar): New functions.
3244 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3245 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3246 ns_constrain_all_frames.
3247 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3248 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3249
3250 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3251
3252 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3253
3254 2011-03-27 Glenn Morris <rgm@gnu.org>
3255
3256 * syssignal.h: Replace RETSIGTYPE with void.
3257 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3258 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3259 Replace SIGTYPE with void everywhere.
3260 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3261 * s/template.h (SIGTYPE): Remove commented out definition.
3262
3263 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3264
3265 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3266 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3267
3268 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3269
3270 * w32.c (read_unc_volume): Use parameter `henum', instead of
3271 global variable `wget_enum_handle'.
3272
3273 * keymap.c (describe_vector): Remove parameters `indices' and
3274 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3275 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3276
3277 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3278
3279 * keyboard.c (timer_check): Remove parameter `do_it_now',
3280 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3281 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3282 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3283
3284 * keyboard.c (read_char):
3285 * w32menu.c (w32_menu_display_help):
3286 * xmenu.c (show_help_event, menu_help_callback):
3287 Adjust calls to `show_help_echo'.
3288
3289 * gtkutil.c (xg_maybe_add_timer):
3290 * keyboard.c (readable_events):
3291 * process.c (wait_reading_process_output):
3292 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3293
3294 * insdel.c (adjust_markers_gap_motion):
3295 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3296 (gap_left, gap_right): Don't call it.
3297
3298 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3299
3300 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3301 incurred during fontification.
3302
3303 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3306 (DEFVAR_PER_BUFFER): Don't pass it.
3307
3308 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3309 (scrolling_window): Don't pass it.
3310
3311 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3312
3313 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3314
3315 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3316 and `suffix'.
3317 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3318 of variables specific to SELinux and computation of `encoded_absname'.
3319
3320 * image.c (XPutPixel): Remove unused variable `height'.
3321
3322 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3323
3324 * unexw32.c (get_section_info): Remove unused variable `section'.
3325
3326 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3327 (system_process_attributes): Remove unused variable `sess'.
3328 (sys_read): Remove unused variable `err'.
3329
3330 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3331 (w32_wnd_proc): Remove unused variable `isdead'.
3332 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3333 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3334 (x_create_tip_frame): Remove unused variable `tem'.
3335
3336 * w32inevt.c (w32_console_read_socket):
3337 Remove unused variable `no_events'.
3338
3339 * w32term.c (x_draw_composite_glyph_string_foreground):
3340 Remove unused variable `width'.
3341
3342 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3343
3344 * w32term.c (x_set_glyph_string_clipping):
3345 Don't pass uninitialized region to CombineRgn.
3346
3347 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3348
3349 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3350 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3351 (Fx_close_connection): Remove unused variable `i'.
3352
3353 * w32font.c (w32font_draw): Return number of glyphs.
3354 (w32font_open_internal): Remove unused variable `i'.
3355 (w32font_driver): Add missing initializer.
3356
3357 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3358 (fill_in_menu): Remove unused variable `items_added'.
3359
3360 * w32term.c (last_mouse_press_frame): Remove static global variable.
3361 (w32_clip_to_row): Remove unused variable `f'.
3362 (x_delete_terminal): Remove unused variable `i'.
3363
3364 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3365 (NOTHING): Remove unused static global variable.
3366 (uniscribe_check_otf): Remove unused variable `table'.
3367 (uniscribe_font_driver): Add missing initializers.
3368
3369 2011-03-23 Julien Danjou <julien@danjou.info>
3370
3371 * term.c (Fsuspend_tty, Fresume_tty):
3372 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3373 * window.c (temp_output_buffer_show):
3374 * insdel.c (signal_before_change):
3375 * frame.c (Fhandle_switch_frame):
3376 * fileio.c (Fdo_auto_save):
3377 * emacs.c (Fkill_emacs):
3378 * editfns.c (save_excursion_restore):
3379 * cmds.c (internal_self_insert):
3380 * callint.c (Fcall_interactively):
3381 * buffer.c (Fkill_all_local_variables):
3382 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3383 Use Frun_hooks.
3384 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3385 unconditionnaly since it does the check itself.
3386
3387 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 Fix more problems found by GCC 4.5.2's static checks.
3390
3391 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3392 the first time through the loop, since we know p0 < p1 then.
3393 This also avoids a gcc -Wstrict-overflow warning.
3394
3395 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3396 leading to a memory leak, possible in functions like
3397 load_charset_map_from_file that can allocate an unbounded number
3398 of objects (Bug#8318).
3399
3400 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3401 that could (at least in theory) be that large.
3402
3403 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3404 This is less likely to overflow, and avoids undefined behavior if
3405 overflow does occur. All callers changed. Use strtoul to scan
3406 for the unsigned long integer.
3407 (pint2hrstr): Simplify and tune code slightly.
3408 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3409
3410 * scroll.c (do_scrolling): Work around GCC bug 48228.
3411 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3412
3413 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3414 This also avoids a warning with gcc -Wstrict-overflow.
3415 (validate_x_resource_name): Simplify count usage.
3416 This also avoids a warning with gcc -Wstrict-overflow.
3417
3418 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3419 fail (Bug#8306).
3420
3421 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3422
3423 * process.c (Fmake_network_process): Use socklen_t, not int,
3424 where POSIX says socklen_t is required in portable programs.
3425 This fixes a porting bug on hosts like 64-bit HP-UX, where
3426 socklen_t is wider than int (Bug#8277).
3427 (Fmake_network_process, server_accept_connection):
3428 (wait_reading_process_output, read_process_output):
3429 Likewise.
3430
3431 * process.c: Rename or move locals to avoid shadowing.
3432 (list_processes_1, Fmake_network_process):
3433 (read_process_output_error_handler, exec_sentinel_error_handler):
3434 Rename or move locals.
3435 (Fmake_network_process): Define label "retry_connect" only if needed.
3436 (Fnetwork_interface_info): Fix pointer signedness.
3437 (process_send_signal): Add cast to avoid pointer signedness problem.
3438 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3439 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3440
3441 Make tparam.h and terminfo.c consistent.
3442 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3443 Include tparam.h instead, since it declares them.
3444 * cm.h (PC): Remove extern decl; tparam.h now does this.
3445 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3446 * terminfo.c: Include tparam.h, to check interfaces.
3447 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3448 (tparam): Adjust signature to match interface in tparam.h;
3449 this removes some undefined behavior. Check that outstring and len
3450 are zero, which they always are with Emacs.
3451 * tparam.h (PC, BC, UP): New extern decls.
3452
3453 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3454 (xftfont_open): Rename locals to avoid shadowing.
3455
3456 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3457 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3458 (OTF_TAG_SYM): Omit macro if not needed.
3459 (ftfont_list): Remove unused local.
3460 (get_adstyle_property, ftfont_pattern_entity):
3461 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3462 Rename locals to avoid shadowing.
3463
3464 * xfont.c (xfont_list_family): Mark var as initialized.
3465
3466 * xml.c (make_dom): Now static.
3467
3468 * composite.c (composition_compute_stop_pos): Rename local to
3469 avoid shadowing.
3470 (composition_reseat_it): Remove unused locals.
3471 (find_automatic_composition, composition_adjust_point): Likewise.
3472 (composition_update_it): Mark var as initialized.
3473 (find_automatic_composition): Mark vars as initialized,
3474 with a FIXME (Bug#8290).
3475
3476 character.h: Rename locals to avoid shadowing.
3477 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3478 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3479 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3480 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3481 to avoid shadowing.
3482
3483 * textprop.c (property_change_between_p): Remove; unused.
3484
3485 * intervals.c (interval_start_pos): Now static.
3486
3487 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3488
3489 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3490 Rename locals to avoid shadowing.
3491
3492 * sound.c (wav_play, au_play, Fplay_sound_internal):
3493 Fix pointer signedness.
3494 (alsa_choose_format): Remove unused local var.
3495 (wav_play): Initialize a variable to 0, to prevent undefined
3496 behavior (Bug#8278).
3497
3498 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3499
3500 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3501
3502 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3503 clobbering (Bug#8298).
3504 * sysdep.c (sys_subshell): Likewise.
3505 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3506
3507 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3508 This should get cleaned up, so that child_setup has the
3509 same signature on all platforms.
3510
3511 * callproc.c (call_process_cleanup): Now static.
3512 (relocate_fd): Rename locals to avoid shadowing.
3513
3514 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3515
3516 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3517 not to be necessary, and produces flickering.
3518
3519 2011-03-20 Glenn Morris <rgm@gnu.org>
3520
3521 * config.in: Remove file.
3522
3523 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3524
3525 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3526 are now in src/globals.h.
3527 (syms_of_minibuf): Remove spurious & from previous change.
3528
3529 2011-03-20 Leo <sdl.web@gmail.com>
3530
3531 * minibuf.c (completing-read-function): New variable.
3532 (completing-read-default): Rename from completing-read.
3533 (completing-read): Call completing-read-function.
3534
3535 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3536
3537 * xfaces.c (Fx_load_color_file):
3538 Read color file from absolute filename (bug#8250).
3539
3540 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3541
3542 * makefile.w32-in: Update dependencies.
3543
3544 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3545
3546 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3547
3548 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3549
3550 Fix more problems found by GCC 4.5.2's static checks.
3551
3552 * process.c (make_serial_process_unwind, send_process_trap):
3553 (sigchld_handler): Now static.
3554
3555 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3556 That way, the code declares only the vars that it needs.
3557 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3558 * s/cygwin.h (PTY_ITERATION): Likewise.
3559 * s/darwin.h (PTY_ITERATION): Likewise.
3560 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3561
3562 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3563 * process.c (allocate_pty): Don't declare stb unless it's needed.
3564
3565 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3566 (CONSTANTLIM): Remove; unused.
3567 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3568 Define only if needed.
3569
3570 * unexelf.c (unexec): Name an expression,
3571 to avoid gcc -Wbad-function-cast warning.
3572 Use a different way to cause a compilation error if anyone uses
3573 n rather than nn, a way that does not involve shadowing.
3574 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3575
3576 * deps.mk (unexalpha.o): Remove; unused.
3577
3578 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3579 * unexec.h: New file.
3580 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3581 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3582 Depend on unexec.h.
3583 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3584 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3585 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3586 Change as necessary to match prototype in unexec.h.
3587
3588 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3589 shadowing.
3590 (back_comment, skip_chars): Mark vars as initialized.
3591
3592 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3593 Rename locals to avoid shadowing.
3594
3595 * lread.c (read1): Rewrite so as not to use empty "else".
3596 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3597
3598 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3599
3600 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3601 warning when compiling print.c.
3602
3603 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3604 instead of using an uninitialized var.
3605 (font_sort_entities): Mark var as initialized.
3606
3607 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3608
3609 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3610 pointers to constants.
3611 (font_parse_fcname): Remove unused vars.
3612 (font_delete_unmatched): Now static.
3613 (font_get_spec): Remove; unused.
3614 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3615 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3616 Rename or move locals to avoid shadowing.
3617
3618 * fns.c (require_nesting_list, require_unwind): Now static.
3619 (Ffillarray): Rename locals to avoid shadowing.
3620
3621 * floatfns.c (domain_error2): Define only if needed.
3622 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3623
3624 * alloc.c (mark_backtrace): Move decl from here ...
3625 * lisp.h: ... to here, so that it can be checked.
3626
3627 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3628 (Fdefvar): Rewrite so as not to use empty "else".
3629 (lisp_indirect_variable): Name an expression,
3630 to avoid gcc -Wbad-function-cast warning.
3631 (Fdefvar): Rename locals to avoid shadowing.
3632
3633 * callint.c (quotify_arg, quotify_args): Now static.
3634 (Fcall_interactively): Rename locals to avoid shadowing.
3635 Use const pointer when appropriate.
3636
3637 * lisp.h (get_system_name, get_operating_system_release):
3638 Move decls here, to check interfaces.
3639 * process.c (get_operating_system_release): Move decl to lisp.h.
3640 * xrdb.c (get_system_name): Likewise.
3641 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3642 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3643 some of which prompt warnings from gcc -Wbad-function-cast.
3644 (Fformat_time_string, Fencode_time, Finsert_char):
3645 (Ftranslate_region_internal, Fformat):
3646 Rename or remove local vars to avoid shadowing.
3647 (Ftranslate_region_internal): Mark var as initialized.
3648
3649 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3650 avoid shadowing.
3651
3652 * lisp.h (eassert): Check that the argument compiles, even if
3653 ENABLE_CHECKING is not defined.
3654
3655 * data.c (Findirect_variable): Name an expression, to avoid
3656 gcc -Wbad-function-cast warning.
3657 (default_value, arithcompare, arith_driver, arith_error): Now static.
3658 (store_symval_forwarding): Rename local to avoid shadowing.
3659 (Fmake_variable_buffer_local, Fmake_local_variable):
3660 Mark variables as initialized.
3661 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3662
3663 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3664 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3665 Rename locals to avoid shadowing.
3666 (mark_stack): Move local variables into the #ifdef region where
3667 they're used.
3668 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3669 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3670 needed otherwise.
3671 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3672 (GC_STRING_CHARS): Remove; not used.
3673 (Fmemory_limit): Cast sbrk's returned value to char *.
3674
3675 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3676 avoids undefined behavior in theory.
3677
3678 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3679
3680 Use functions, not macros, for up- and down-casing (Bug#8254).
3681 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3682 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3683 to use the following functions instead of these macros.
3684 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3685 EMACS_INT, since callers assume the returned value fits in int.
3686 (upcase1): Likewise, for UPCASE_TABLE.
3687 (uppercasep, lowercasep, upcase): New static inline functions.
3688 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3689 the race-condition problem in the old DOWNCASE.
3690
3691 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3692 Rename locals to avoid shadowing.
3693 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3694 (regex_compile, re_search_2, re_match_2_internal):
3695 Remove unused local vars.
3696 (FREE_VAR): Rewrite so as not to use empty "else",
3697 which gcc can warn about.
3698 (regex_compile, re_match_2_internal): Mark locals as initialized.
3699 (RETALLOC_IF): Define only if needed.
3700 (WORDCHAR_P): Likewise. This one is never needed, but is used
3701 only in a comment talking about a compiler bug, so put inside
3702 the #if 0 of that comment.
3703 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3704 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3705 Remove; unused.
3706
3707 * search.c (boyer_moore): Rename locals to avoid shadowing.
3708 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3709 (PREV_CHAR_BOUNDARY): Likewise.
3710
3711 * search.c (simple_search): Remove unused var.
3712
3713 * dired.c (compile_pattern): Move decl from here ...
3714 * lisp.h: ... to here, so that it can be checked.
3715 (struct re_registers): New forward decl.
3716
3717 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3718
3719 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3720 All uses changed.
3721 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3722 Rename locals to avoid shadowing.
3723 (Fvertical_motion): Mark locals as initialized.
3724
3725 * casefiddle.c (casify_object, casify_region): Now static.
3726 (casify_region): Mark local as initialized.
3727
3728 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3729
3730 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3731 New macros, so that the caller can use some names other than
3732 gcpro1, gcpro2, etc.
3733 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3734 of the new macros.
3735 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3736 argument, for consistency with GCPRO2_VAR, etc: it is now the
3737 prefix of the variable, not the variable itself. All uses
3738 changed.
3739 * dired.c (directory_files_internal, file_name_completion):
3740 Rename locals to avoid shadowing.
3741
3742 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3743 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3744 dired.c's scmp function, had undefined behavior.
3745 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3746 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3747 * buffer.h: ... to here, because these macros use current_buffer,
3748 and the new implementation with inline functions needs to have
3749 current_buffer in scope now, rather than later when the macros
3750 are used.
3751 (downcase, upcase1): New static inline functions.
3752 (DOWNCASE, UPCASE1): Reimplement using these functions.
3753 This avoids undefined behavior in expressions like
3754 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3755 from race conditions in accessing the global variables
3756 case_temp1 and case_temp2.
3757 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3758 * lisp.h (case_temp1, case_temp2): Remove their decls.
3759 * character.h (ASCII_CHAR_P): Move from here ...
3760 * lisp.h: ... to here, so that the inline functions mentioned
3761 above can use them.
3762
3763 * dired.c (directory_files_internal_unwind): Now static.
3764
3765 * fileio.c (file_name_as_directory, directory_file_name):
3766 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3767 Now static.
3768 (file_name_as_directory): Use const pointers when appropriate.
3769 (Fexpand_file_name): Likewise. In particular, newdir might
3770 point at constant storage, so make it a const pointer.
3771 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3772 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3773 signedness issues.
3774 (Fset_file_times, Finsert_file_contents, auto_save_error):
3775 Rename locals to avoid shadowing.
3776
3777 * minibuf.c (choose_minibuf_frame_1): Now static.
3778 (Ftry_completion, Fall_completions): Rename or remove locals
3779 to avoid shadowing.
3780
3781 * marker.c (bytepos_to_charpos): Remove; unused.
3782
3783 * lisp.h (verify_bytepos, count_markers): New decls,
3784 so that gcc does not warn that these functions aren't declared.
3785
3786 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3787 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3788 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3789 (copy_text): Remove unused local var.
3790
3791 * filelock.c (within_one_second): Now static.
3792 (lock_file_1): Rename local to avoid shadowing.
3793
3794 * buffer.c (fix_overlays_before): Mark locals as initialized.
3795 (fix_start_end_in_overlays): Likewise. This function should be
3796 simplified by using pointers-to-pointers, but that's a different
3797 matter.
3798 (switch_to_buffer_1): Now static.
3799 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3800 (report_overlay_modification): Rename locals to avoid shadowing.
3801
3802 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3803 Fix pointer signedness issue.
3804 (sys_subshell): Mark local as volatile if checking for lint,
3805 to suppress a gcc -Wclobbered warning that does not seem to be right.
3806 (MAXPATHLEN): Define only if needed.
3807
3808 * process.c (serial_open, serial_configure): Move decls from here ...
3809 * systty.h: ... to here, so that they can be checked.
3810
3811 * fns.c (get_random, seed_random): Move extern decls from here ...
3812 * lisp.h: ... to here, so that they can be checked.
3813
3814 * sysdep.c (reset_io): Now static.
3815 (wait_for_termination_signal): Remove; unused.
3816
3817 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3818 (copy_keymap_item, append_key, push_text_char_description):
3819 Now static.
3820 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3821 (DENSE_TABLE_SIZE): Remove; unused.
3822 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3823 (describe_map_tree):
3824 Rename locals to avoid shadowing.
3825
3826 * keyboard.c: Declare functions static if they are not used elsewhere.
3827 (echo_char, echo_dash, cmd_error, top_level_2):
3828 (poll_for_input, handle_async_input): Now static.
3829 (read_char, kbd_buffer_get_event, make_lispy_position):
3830 (make_lispy_event, make_lispy_movement, apply_modifiers):
3831 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3832 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3833 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3834 (read_key_sequence, read_char): Mark locals as initialized.
3835 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3836
3837 * keyboard.h (make_ctrl_char): New decl.
3838 (mark_kboards): Move decl here ...
3839 * alloc.c (mark_kboards): ... from here.
3840
3841 * lisp.h (force_auto_save_soon): New decl.
3842
3843 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3844 (DEFINE_DUMMY_FUNCTION): New macro.
3845 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3846 Use it.
3847 (main): Add casts to avoid warnings
3848 if GCC considers string literals to be constants.
3849
3850 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3851
3852 * dbusbind.c: Pointer signedness fixes.
3853 (xd_signature, xd_append_arg, xd_initialize):
3854 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3855 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3856 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3857 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3858
3859 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3860 if GCC considers string literals to be constants.
3861 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3862
3863 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3864
3865 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3866 (print_preprocess, print_object): New macro to fix last change.
3867
3868 * print.c (print_preprocess): Don't forget font objects.
3869
3870 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * emacs.c (USAGE3): Doc fixes.
3873
3874 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3875
3876 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3877 structure.
3878
3879 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3880
3881 * lisp.h (VWindow_system, Qfile_name_history):
3882 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3883 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3884 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3885
3886 * w32select.c: Don't #include "keyboard.h".
3887 (run_protected): Add extern declaration for waiting_for_input.
3888
3889 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3890 * w32console.c (detect_input_pending, read_input_pending)
3891 (encode_terminal_code):
3892 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3893 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3894 (w32_system_caret_y, Qfile_name_history):
3895 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3896 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3897 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3898 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3899 * w32proc.c (Qlocal, report_file_error):
3900 * w32term.c (Vwindow_system, updating_frame):
3901 * w32uniscribe.c (initialized, uniscribe_font_driver):
3902 Remove unneeded extern declarations.
3903
3904 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3905
3906 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3907
3908 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3909
3910 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3911 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3912 These macros can no longer be used for assignment.
3913
3914 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3915 Assign struct members directly, instead of using BUF_BEGV etc.
3916 (record_buffer_markers, fetch_buffer_markers): New functions for
3917 recording and fetching special buffer markers.
3918 (set_buffer_internal_1, set_buffer_temp): Use them.
3919
3920 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3921
3922 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3923
3924 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3925 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3926
3927 * xdisp.c (hscroll_window_tree):
3928 (reconsider_clip_changes): Use PT instead of BUF_PT.
3929
3930 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3931
3932 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3933 $(EMACS_ROOT)/lib/intprops.h.
3934
3935 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 Fix more problems found by GCC 4.5.2's static checks.
3938
3939 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3940 to unsigned char * to avoid compiler diagnostic.
3941 (xg_free_frame_widgets): Make it clear that a local variable is
3942 needed only if USE_GTK_TOOLTIP.
3943 (gdk_window_get_screen): Make it clear that this macro is needed
3944 only if USE_GTK_TOOLTIP.
3945 (int_gtk_range_get_value): New function, which avoids a diagnostic
3946 from gcc -Wbad-function-cast.
3947 (xg_set_toolkit_scroll_bar_thumb): Use it.
3948 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3949 diagnostic from gcc -Wbad-function-cast.
3950 (get_utf8_string, xg_get_file_with_chooser):
3951 Rename locals to avoid shadowing.
3952 (create_dialog): Move locals to avoid shadowing.
3953
3954 * xgselect.c (xg_select): Remove unused var.
3955
3956 * image.c (four_corners_best): Mark locals as initialized.
3957 (gif_load): Initialize transparent_p to zero (Bug#8238).
3958 Mark another local as initialized.
3959 (my_png_error, my_error_exit): Mark with NO_RETURN.
3960
3961 * image.c (clear_image_cache): Now static.
3962 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3963 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3964 (x_edge_detection): Remove unnecessary cast that
3965 gcc -Wbad-function-cast diagnoses.
3966 (gif_load): Fix pointer signedness.
3967 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3968 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3969
3970 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 Improve quality of tests for time stamp overflow.
3973 For example, without this patch (encode-time 0 0 0 1 1
3974 1152921504606846976) returns the obviously-bogus value (-948597
3975 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3976 reports time overflow. See
3977 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3978 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3979 * editfns.c: Include limits.h and intprops.h.
3980 (TIME_T_MIN, TIME_T_MAX): New macros.
3981 (time_overflow): Move earlier, to before first use.
3982 (hi_time, lo_time): New functions, for an accurate test for
3983 out-of-range times.
3984 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3985 (Fget_internal_run_time): Don't assume time_t fits in int.
3986 (make_time): Use list2 instead of Fcons twice.
3987 (Fdecode_time): More accurate test for out-of-range times.
3988 (check_tm_member): New function.
3989 (Fencode_time): Use it, to test for out-of-range times.
3990 (lisp_time_argument): Don't rely on undefined left-shift and
3991 right-shift behavior when checking for time stamp overflow.
3992
3993 * editfns.c (time_overflow): New function, refactoring common code.
3994 (Fformat_time_string, Fdecode_time, Fencode_time):
3995 (Fcurrent_time_string): Use it.
3996
3997 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3998 * dired.c (make_time): Move to ...
3999 * editfns.c (make_time): ... here.
4000 * systime.h: Note the move.
4001
4002 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4003
4004 * fringe.c (update_window_fringes): Remove unused variables.
4005
4006 * unexmacosx.c (copy_data_segment): Also copy __got section.
4007 (Bug#8223)
4008
4009 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4010
4011 * termcap.c [MSDOS]: Include "msdos.h".
4012 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4013 Constify `char *' arguments and their references according to
4014 prototypes in tparam.h.
4015
4016 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4017
4018 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4019 Adapt all references accordingly.
4020
4021 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4022
4023 2011-03-11 Tom Tromey <tromey@redhat.com>
4024
4025 * buffer.c (syms_of_buffer): Remove obsolete comment.
4026
4027 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4028
4029 * termhooks.h (encode_terminal_code): Declare prototype.
4030
4031 * msdos.c (encode_terminal_code): Don't declare prototype.
4032
4033 * term.c (encode_terminal_code): Now external again, used by
4034 w32console.c and msdos.c.
4035
4036 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4037 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4038
4039 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 Fix some minor problems found by GCC 4.5.2's static checks.
4042
4043 * fringe.c (update_window_fringes): Mark locals as initialized
4044 (Bug#8227).
4045 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4046
4047 * alloc.c (mark_fringe_data): Move decl from here ...
4048 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4049 to check its interface.
4050 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4051
4052 * fontset.c (free_realized_fontset): Now static.
4053 (Fset_fontset_font): Rename local to avoid shadowing.
4054 (fontset_font): Mark local as initialized.
4055 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4056
4057 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4058
4059 * xselect.c (x_disown_buffer_selections): Remove; not used.
4060 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4061 (x_own_selection, Fx_disown_selection_internal): Rename locals
4062 to avoid shadowing.
4063 (x_handle_dnd_message): Remove local to avoid shadowing.
4064
4065 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4066 so that the caller can use some name other than gcpro1.
4067 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4068 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4069 (Fx_backspace_delete_keys_p):
4070 Use them to avoid shadowing, and rename vars to avoid shadowing.
4071 (x_decode_color, x_set_name, x_window): Now static.
4072 (Fx_create_frame): Add braces to silence GCC warning.
4073 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4074 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4075 Remove unused locals.
4076 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4077 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4078 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4079 macros.
4080
4081 * xterm.h (x_mouse_leave): New decl.
4082
4083 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4084 Remove unused functions.
4085 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4086 (x_calc_absolute_position): Now static.
4087 (XTread_socket): Don't define label "out" unless it's used.
4088 Don't declare local "event" unless it's used.
4089 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4090 unless they are used.
4091 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4092 (x_fatal_error_signal): Remove; not used.
4093 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4094 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4095 (x_error_catcher, x_connection_closed, x_error_handler):
4096 (x_error_quitter, xembed_send_message, x_iconify_frame):
4097 (my_log_handler): Rename locals to avoid shadowing.
4098 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4099 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4100
4101 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4102 Rename or move locals to avoid shadowing.
4103 (tty_defined_color, merge_face_heights): Now static.
4104 (free_realized_faces_for_fontset): Remove; not used.
4105 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4106 does not deduce is never used uninitialized.
4107 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4108 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4109
4110 * terminal.c (store_terminal_param): Now static.
4111
4112 * xmenu.c (menu_highlight_callback): Now static.
4113 (set_frame_menubar): Remove unused local.
4114 (xmenu_show): Rename parameter to avoid shadowing.
4115 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4116 since they might point to immutable storage.
4117 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4118 since it's unused otherwise.
4119
4120 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4121 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4122 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4123 avoids a gcc -Wuninitialized diagnostic.
4124 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4125 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4126 does not deduce are never used uninitialized.
4127
4128 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4129
4130 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4131 * window.c (window_loop, size_window):
4132 (run_window_configuration_change_hook, enlarge_window): Likewise.
4133
4134 * window.c (display_buffer): Now static.
4135 (size_window): Mark variables that gcc -Wuninitialized
4136 does not deduce are never used uninitialized.
4137 * window.h (check_all_windows): New decl, to forestall
4138 gcc -Wmissing-prototypes diagnostic.
4139 * dispextern.h (bidi_dump_cached_states): Likewise.
4140
4141 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4142 shadowing.
4143 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4144 Include <limits.h>.
4145 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4146 and to avoid gcc -Wuninitialized warning.
4147 (load_charset_map): Mark variables that gcc -Wuninitialized
4148 does not deduce are never used uninitialized.
4149 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4150
4151 * coding.c (coding_set_source, coding_set_destination):
4152 Use "else { /* comment */ }" rather than "else /* comment */;"
4153 for clarity, and to avoid gcc -Wempty-body warning.
4154 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4155 a block, when the outer 'i' will do.
4156 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4157 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4158 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4159 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4160 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4161 Rename locals to avoid shadowing.
4162 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4163 * coding.c (emacs_mule_char, encode_invocation_designation):
4164 Now static, since they're not used elsewhere.
4165 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4166 (decode_coding_object, encode_coding_object, detect_coding_system):
4167 (decode_coding_emacs_mule): Mark variables that gcc
4168 -Wuninitialized does not deduce are never used uninitialized.
4169 (detect_coding_iso_2022): Initialize a local variable that might
4170 be used uninitialized. Leave a FIXME because it's not clear that
4171 this initialization is needed. (Bug#8211)
4172 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4173 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4174 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4175 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4176 Remove unused macros.
4177
4178 * category.c (hash_get_category_set): Remove unused local var.
4179 (copy_category_table): Now static, since it's not used elsewhere.
4180 * character.c (string_count_byte8): Likewise.
4181
4182 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4183 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4184
4185 * chartab.c (copy_sub_char_table): Now static, since it's not used
4186 elsewhere.
4187 (sub_char_table_ref_and_range, char_table_ref_and_range):
4188 Rename locals to avoid shadowing.
4189 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4190
4191 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4192 (BIDI_BOB): Remove unused macro.
4193
4194 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4195 deduce are never used uninitialized.
4196 * term.c (encode_terminal_code): Likewise.
4197
4198 * term.c (encode_terminal_code): Now static. Remove unused local.
4199
4200 * tparam.h: New file.
4201 * term.c, tparam.h: Include it.
4202 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4203 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4204 Move these decls to tparam.h, and make them agree with what
4205 is actually in tparam.c. The previous trick of using incompatible
4206 decls in different modules does not conform to the C standard.
4207 All callers of tparam changed to use tparam's actual API.
4208 * tparam.c (tparam1, tparam, tgoto):
4209 Use const pointers where appropriate.
4210
4211 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4212 * cm.h (struct cm): Likewise.
4213 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4214 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4215 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4216 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4217 (turn_on_face, init_tty): Likewise.
4218 * termchar.h (struct tty_display_info): Likewise.
4219
4220 * term.c (term_mouse_position): Rename local to avoid shadowing.
4221
4222 * alloc.c (mark_ttys): Move decl from here ...
4223 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4224
4225 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4226
4227 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4228
4229 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4230
4231 * search.c (compile_pattern_1): Remove argument regp, unused since
4232 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4233 (compile_pattern): Don't pass it.
4234
4235 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4236
4237 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4238 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4239 for ! HAVE_GTK3.
4240 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4241
4242 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4243
4244 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4245 gdk_window_get_screen, gdk_window_get_geometry,
4246 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4247 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4248 (xg_get_pixbuf_from_pixmap): New function.
4249 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4250 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4251 Call xg_get_pixbuf_from_pixmap instead of
4252 gdk_pixbuf_get_from_drawable.
4253 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4254 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4255 (xg_check_special_colors): Use GtkStyleContext and its functions
4256 for HAVE_GTK3.
4257 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4258 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4259 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4260 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4261 Call gtk_widget_get_preferred_size.
4262 (xg_frame_resized): gdk_window_get_geometry only takes 5
4263 parameters.
4264 (xg_win_to_widget, xg_event_is_for_menubar):
4265 Call gdk_x11_window_lookup_for_display.
4266 (xg_set_widget_bg): New function.
4267 (delete_cb): New function.
4268 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4269 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4270 (xg_set_background_color): Call xg_set_widget_bg.
4271 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4272 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4273 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4274 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4275 if ! HAVE_GTK3.
4276 (update_frame_tool_bar): Call gtk_widget_hide.
4277 (xg_initialize): Use GDK_KEY_g.
4278
4279 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4280 if ! HAVE_GTK3
4281 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4282
4283 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4284 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4285 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4286
4287 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * w32xfns.c (select_palette): Check success of RealizePalette against
4290 GDI_ERROR, not zero.
4291
4292 See ChangeLog.11 for earlier changes.
4293
4294 ;; Local Variables:
4295 ;; coding: utf-8
4296 ;; End:
4297
4298 Copyright (C) 2011 Free Software Foundation, Inc.
4299
4300 This file is part of GNU Emacs.
4301
4302 GNU Emacs is free software: you can redistribute it and/or modify
4303 it under the terms of the GNU General Public License as published by
4304 the Free Software Foundation, either version 3 of the License, or
4305 (at your option) any later version.
4306
4307 GNU Emacs is distributed in the hope that it will be useful,
4308 but WITHOUT ANY WARRANTY; without even the implied warranty of
4309 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4310 GNU General Public License for more details.
4311
4312 You should have received a copy of the GNU General Public License
4313 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.