1 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4 (xgetint): Add missing shift for LSB tags.
6 2012-04-24 Martin Rudalics <rudalics@gmx.at>
8 * keyboard.c (read_char): Don't wipe echo area for select window
9 events: These might get delayed via `mouse-autoselect-window'
12 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
14 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
15 manipulation of :loaded-from data.
17 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
19 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
20 now a cons (bug#11311).
22 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
24 Do not create empty overlays with the evaporate property (Bug#9642).
25 * buffer.c (Fmove_overlay): Delete an evaporating overlay
26 if it becomes empty after its bounds are adjusted to fit within
27 its buffer. Without this fix, in a nonempty buffer (let ((o
28 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
29 yields an empty overlay that has the evaporate property, which is
30 not supposed to happen.
32 Fix minor GTK3 problems found by static checking.
33 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
34 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
35 (struct _EmacsFixedClass, emacs_fixed_get_type):
36 Move decls here from emacsgtkfixed.h, since they needn't be public.
37 (emacs_fixed_get_type): Now static.
38 (emacs_fixed_class_init): Omit unused local.
39 (emacs_fixed_child_type): Remove; unused.
40 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
41 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
42 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
43 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
44 (EMACS_FIXED_GET_CLASS): Remove; unused.
45 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
47 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
48 Problem reported by Juanma Barranquero for Windows -Wunused-function.
50 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
52 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
53 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
54 (__malloc_size_t, __malloc_ptrdiff_t):
55 Remove. All uses removed, replaced by the definiens if needed,
56 since we can assume C89 or better now.
57 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
58 (protect_malloc_state, align, get_contiguous_space)
59 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
60 (malloc_atfork_handler_child, malloc_enable_thread)
61 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
62 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
63 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
64 (special_realloc, _realloc_internal_nolock, _realloc_internal)
65 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
66 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
67 Define using prototypes, not old style.
68 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
69 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
70 (align): Don't assume that signed integer overflow wraps around.
71 Omit unused local var.
72 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
73 (_free_internal_nolock, memalign, mallochook, reallochook):
74 Omit no-longer-needed casts.
75 (valloc): Use getpagesize, not __getpagesize.
76 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
77 (struct hdr): The 'magic' member is now size_t, not unsigned long.
79 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
81 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
83 Move functions from C to Lisp. Make non-blocking method calls
84 the default. Implement further D-Bus standard interfaces.
86 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
87 (QCdbus_request_name_allow_replacement)
88 (QCdbus_request_name_replace_existing)
89 (QCdbus_request_name_do_not_queue)
90 (QCdbus_request_name_reply_primary_owner)
91 (QCdbus_request_name_reply_in_queue)
92 (QCdbus_request_name_reply_exists)
93 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
94 (QCdbus_registered_serial, QCdbus_registered_method)
95 (QCdbus_registered_signal): New Lisp objects.
96 (XD_DEBUG_MESSAGE): Use sizeof.
97 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
98 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
99 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
100 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
101 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
102 (xd_signature, xd_append_arg): Allow float for integer types.
103 (xd_get_connection_references): New function.
104 (xd_get_connection_address): Rename from xd_initialize. Return
106 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
107 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
109 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
110 Return number of recounts.
111 (Fdbus_get_unique_name): Make stronger parameter check.
112 (Fdbus_message_internal): New defun.
113 (Fdbus_call_method, Fdbus_call_method_asynchronously)
114 (Fdbus_method_return_internal, Fdbus_method_error_internal)
115 (Fdbus_send_signal, Fdbus_register_service)
116 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
117 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
118 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
119 (Vdbus_compiled_version, Vdbus_runtime_version)
120 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
121 (Vdbus_message_type_method_return, Vdbus_message_type_error)
122 (Vdbus_message_type_signal): New defvars.
123 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
126 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
128 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
129 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
130 Do not assume ptrdiff_t is the same width as 'int'.
132 * alloc.c: Handle unusual debugging option combinations.
133 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
134 since the two debugging options are incompatible.
135 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
137 (mem_init, mem_insert, mem_insert_fixup):
138 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
139 (NEED_MEM_INSERT): Remove; no longer needed.
141 2012-04-22 Leo Liu <sdl.web@gmail.com>
143 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
145 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
147 * sysdep.c [__FreeBSD__]: Minor cleanups.
148 (list_system_processes, system_process_attributes) [__FreeBSD__]:
149 Use Emacs indenting style more consistently. Avoid some casts.
150 Use 'double' consistently rather than mixing 'float' and 'double'.
152 2012-04-21 Eduard Wiebe <usenet@pusto.de>
154 * sysdep.c (list_system_processes, system_process_attributes): Add
155 implementation for FreeBSD (Bug#5243).
157 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
159 * lisp.mk (lisp): Update.
161 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
163 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
164 It is never used otherwise.
166 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
168 * print.c (print_preprocess): Only check print_depth if print-circle
170 (print_object): Check for cycles even when print-circle is nil and
171 print-gensym is t, but only check print_depth if print-circle is nil.
173 2012-04-20 Chong Yidong <cyd@gnu.org>
175 * process.c (wait_reading_process_output): If EIO occurs on a pty,
176 set the status to "failed" and ensure that sentinel is run.
178 2012-04-20 Glenn Morris <rgm@gnu.org>
180 * process.c (Fset_process_inherit_coding_system_flag)
181 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
182 (Fmake_network_process, Fmake_serial_process): Doc fix.
184 2012-04-20 Eli Zaretskii <eliz@gnu.org>
186 * xdisp.c (string_buffer_position_lim): Limit starting position to
188 (set_cursor_from_row): If called for a mode-line or header-line
189 row, return zero immediately.
190 (try_cursor_movement): If inside continuation line, don't back up
191 farther than the first row after the header line, if any.
192 Don't consider the header-line row as "partially visible", even if
193 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
195 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
197 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
200 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
201 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
203 configure: new option --enable-gcc-warnings (Bug#11207)
204 * Makefile.in (C_WARNINGS_SWITCH): Remove.
205 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
206 (ALL_CFLAGS): Use new macros rather than old.
207 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
208 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
209 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
210 -Wunused-result, -Wunused-variable. This should go away once
211 the Emacs and Gnulib regex code is merged.
212 (xmalloc, xrealloc): Now static.
214 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
216 * dired.c (Fsystem_groups): Remove unused local.
218 2012-04-17 Glenn Morris <rgm@gnu.org>
220 * dired.c (Fsystem_users): Doc fix.
222 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
224 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
225 (syms_of_dired): Add them.
227 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
229 Fix minor alloc.c problems found by static checking.
230 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
231 New extern decls, to avoid calling undeclared functions.
232 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
233 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
234 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
235 (NEED_MEM_INSERT): New macro.
236 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
237 Remove one incorrect comment and fix another.
239 Fix minor ralloc.c problems found by static checking.
240 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
241 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
242 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
243 (r_alloc_sbrk): Now static.
245 Improve ralloc.c interface checking.
246 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
247 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
248 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
249 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
250 [REL_ALLOC]: ... to here, to check interface.
251 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
252 Remove decls. This fixes an "It stinks!".
254 * alloc.c (which_symbols): Fix alignment issue / type clash.
256 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
258 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
259 (struct Lisp_Misc_Any): Likewise.
260 (struct Lisp_Free): Likewise.
261 * alloc.c (union aligned_Lisp_Symbol): Define.
262 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
263 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
264 (union aligned_Lisp_Misc): Define.
265 (MARKER_BLOCK_SIZE, struct marker_block): Use union
266 aligned_Lisp_Misc instead of union Lisp_Misc.
267 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
269 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
271 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
272 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
273 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
274 * s/netbsd.h, s/sol2-6.h:
275 Remove definition of GC_MARK_STACK, since the default now works.
276 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
277 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
278 no longer the default.
279 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
281 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
283 * lread.c (lisp_file_lexically_bound_p):
284 Fix hang at ";-*-\n" (bug#11238).
286 2012-04-14 Eli Zaretskii <eliz@gnu.org>
288 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
289 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
291 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
293 * nsterm.m (constrainFrameRect): Always constrain when there is only
294 one screen (Bug#10962).
296 2012-04-13 Ken Brown <kbrown@cornell.edu>
298 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
300 2012-04-13 Reuben Thomas <rrt@sc3d.org>
302 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
304 2012-04-11 Daniel Colascione <dancol@dancol.org>
306 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
307 against is gone. It's better to use vfork now so that when Cygwin
308 gains a new, working vfork, we use it automatically (bug#10398).
310 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
312 * window.c (save_window_save): Obey window-point-insertion-type.
314 2012-04-11 Glenn Morris <rgm@gnu.org>
316 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
318 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
320 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
322 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
324 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
325 (force_quit_count): New var.
326 (handle_interrupt): Use it.
328 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
330 * w32.c (w32_delayed_load): Record the full path of the library
331 being loaded (bug#10424).
333 2012-04-09 Glenn Morris <rgm@gnu.org>
335 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
336 not just in the obarray, before snarfing them. (Bug#11036)
338 * Makefile.in ($(leimdir)/leim-list.el):
339 Pass EMACS rather than BUILT_EMACS.
341 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
343 * process.c (make_process):
344 * process.h: Add integer `gnutls_handshakes_tried' member to
347 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
348 Add convenience `GNUTLS_LOG2i' macro.
350 * gnutls.c (gnutls_log_function2i): Convenience log function.
351 (emacs_gnutls_read): Use new log functions,
352 `gnutls_handshakes_tried' process member, and
353 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
354 attempts per process (connection).
356 2012-04-09 Chong Yidong <cyd@gnu.org>
358 * eval.c (Fuser_variable_p, user_variable_p_eh)
359 (lisp_indirect_variable): Functions deleted.
360 (Fdefvar): Caller changed.
362 * callint.c (Finteractive, Fcall_interactively):
363 * minibuf.c (Fread_variable): Callers changed.
365 2012-04-09 Eli Zaretskii <eliz@gnu.org>
367 * xdisp.c (set_cursor_from_row): If the display string appears in
368 the buffer at position that is closer to point than the position
369 after the display string, display the cursor on the first glyph of
370 the display string. Fixes cursor display when a 'display' text
371 property immediately follows invisible text. (Bug#11094)
373 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
375 composite.c: use 'double' consistently
376 * composite.c (get_composition_id): Use 'double' consistently
377 instead of converting 'float' to 'double' and vice versa; this is
378 easier to understand and avoids a GCC warning.
380 2012-04-09 Glenn Morris <rgm@gnu.org>
382 * Makefile.in: Generate leim-list with bootstrap-emacs, in
383 preparation for dumping it with emacs. (Bug#4789)
384 (leimdir): New variable.
385 ($(leimdir)/leim-list.el): New rule.
386 (emacs$(EXEEXT)): Depend on leim-list.el.
388 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
389 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
390 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
392 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
394 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
397 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
399 * xml.c (init_libxml2_functions) [WINDOWSNT]:
400 Remove unused local variable.
402 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
404 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
405 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
406 (mark_memory): Mark Lisp_Objects only if pointers might hide in
407 objects, as mark_maybe_pointer will catch them otherwise.
408 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
409 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
411 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
413 Fix typo that broke non-Windows builds.
414 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
416 2012-04-07 Eli Zaretskii <eliz@gnu.org>
418 Support building on MS-Windows with libxml2.
420 * makefile.w32-in (OBJ2): Add xml.$(O).
421 (GLOBAL_SOURCES): Add xml.c.
422 ($(BLD)/xml.$(O)): New dependency list.
424 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
425 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
426 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
427 [!WINDOWSNT]: New macros.
428 (init_libxml2_functions, libxml2_loaded_p): New functions.
429 (parse_region): Call fn_xmlCheckVersion instead of using the macro
430 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
431 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
432 Calls xmlCleanupParser only if libxml2 was loaded (or statically
434 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
435 Call init_libxml2_functions before calling libxml2 functions.
436 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
438 * emacs.c: Don't include libxml/parser.h.
439 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
440 xmlCleanupParser directly.
442 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
444 2012-04-07 Eli Zaretskii <eliz@gnu.org>
446 * indent.c (Fvertical_motion): If there is a display string at
447 point, use it.vpos to compute how many lines to backtrack after
448 move_it_to point. (Bug#11133)
450 2012-04-06 Eli Zaretskii <eliz@gnu.org>
452 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
453 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
454 about subtle differences between FETCH_CHAR* and STRING_CHAR*
455 macros related to unification of CJK characters. For the details,
456 see the discussion following the message here:
457 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
459 2012-04-04 Chong Yidong <cyd@gnu.org>
461 * keyboard.c (Vdelayed_warnings_list): Doc fix.
463 2012-04-01 Eli Zaretskii <eliz@gnu.org>
465 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
466 instead of alloca. (Bug#11138)
468 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
470 * w32menu.c (is_simple_dialog): Properly check lisp types.
473 2012-03-31 Eli Zaretskii <eliz@gnu.org>
475 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
476 position we get to after a call to move_it_to fails the
477 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
478 only if we wind up in a string from display property. (Bug#11063)
480 * window.c (Fdelete_other_windows_internal): Invalidate the row
481 and column information about mouse highlight, so that redisplay
482 restores it after reallocating the glyph matrices. (Bug#7464)
484 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
485 string comes from a `display' text property, use the buffer
486 position of that property as if we actually saw that position in
488 (move_it_by_lines): Remove the assertion that
489 "it->current_x == 0 && it->hpos == 0" which can be legitimately
490 violated when there's a before-string at the beginning of a line.
493 2012-03-30 Eli Zaretskii <eliz@gnu.org>
495 * xdisp.c (append_space_for_newline): If the default face was
496 remapped, use the remapped face for the appended newline.
497 (extend_face_to_end_of_line): Use the remapped default face for
498 extending the face to the end of the line.
499 (display_line): Call extend_face_to_end_of_line when the default
500 face was remapped. (Bug#11068)
502 2012-03-29 Eli Zaretskii <eliz@gnu.org>
504 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
506 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
508 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
510 2012-03-27 Glenn Morris <rgm@gnu.org>
512 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
515 2012-03-26 Kenichi Handa <handa@m17n.org>
517 * dispextern.h (struct glyph): Fix previous change. Change the
518 bit length of glyphless.ch to 25 (Bug#11082).
520 2012-03-26 Chong Yidong <cyd@gnu.org>
522 * keyboard.c (Vselection_inhibit_update_commands): New variable.
523 (command_loop_1): Use it; inhibit selection update for
524 handle-select-window too (Bug#8996).
526 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
528 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
530 2012-03-25 Kenichi Handa <handa@m17n.org>
532 * dispextern.h (struct glyph): Change the bit length of
533 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
535 2012-03-24 Eli Zaretskii <eliz@gnu.org>
537 * s/ms-w32.h (tzname): Include time.h before redirecting to
538 _tzname. Fixes the MSVC build. (Bug#9960)
540 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
542 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
545 * xterm.c (XTread_socket): Only modify handling_signal if
546 !SYNC_INPUT. (Bug#11080)
548 2012-03-23 Eli Zaretskii <eliz@gnu.org>
550 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
551 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
552 when fetching a multibyte character consumes more bytes than
553 CHAR_BYTES returns, due to unification of CJK characters in
554 string_char. (Bug#11073)
556 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
558 * process.c (wait_reading_process_output): Handle pty disconnect
559 by refraining from sending oneself a SIGCHLD (bug#10933).
561 2012-03-22 Chong Yidong <cyd@gnu.org>
563 * dispextern.h (struct it): New member string_from_prefix_prop_p.
565 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
566 Mark string as coming from a prefix property.
567 (handle_face_prop): Use default face for prefix strings (Bug#4281).
568 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
570 2012-03-21 Chong Yidong <cyd@gnu.org>
572 * xfaces.c (Vface_remapping_alist): Doc fix.
574 2012-03-20 Eli Zaretskii <eliz@gnu.org>
576 * w32proc.c (Fw32_set_console_codepage)
577 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
580 2012-03-20 Chong Yidong <cyd@gnu.org>
582 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
583 to reflect default non-nil value of redisplay-dont-pause.
585 2012-03-19 Kenichi Handa <handa@m17n.org>
587 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
588 it fit in a valid range (Bug#11003).
590 2012-03-18 Eli Zaretskii <eliz@gnu.org>
592 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
593 that is not from display property, accept the row as a "cursor
594 row" if one of the string's character has a non-nil `cursor'
595 property. Fixes cursor positioning when there are newlines in
596 overlay strings, e.g. in icomplete.el. (Bug#11035)
598 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
600 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
602 2012-03-12 Chong Yidong <cyd@gnu.org>
604 * eval.c (inhibit_lisp_code): Rename from
605 inhibit_window_configuration_change_hook; move from window.c.
607 * xfns.c (unwind_create_frame_1, Fx_create_frame):
608 * window.c (run_window_configuration_change_hook)
609 (syms_of_window): Callers changed.
611 2012-03-11 Chong Yidong <cyd@gnu.org>
613 * keymap.c (Fkey_description): Doc fix (Bug#9700).
615 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
617 2012-03-10 Chong Yidong <cyd@gnu.org>
619 * frame.c (other_visible_frames): Don't assume the selected frame
620 is visible (Bug#10955).
622 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
624 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
626 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
628 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
629 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
632 2012-03-03 Glenn Morris <rgm@gnu.org>
634 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
636 2012-03-02 Eli Zaretskii <eliz@gnu.org>
638 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
639 position past the first glyph_row that ends at ZV. (Bug#10902)
640 (redisplay_window, next_element_from_string): Fix typos in
642 (redisplay_window): Pass to move_it_vertically the margin in
643 pixels, not in screen lines.
645 2012-03-02 Glenn Morris <rgm@gnu.org>
647 * buffer.c (buffer-list-update-hook): Doc fix.
649 2012-02-29 Eli Zaretskii <eliz@gnu.org>
651 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
652 push_it before setting up the iterator for the first overlay
653 string, even if we have an empty string loaded.
654 (next_overlay_string): If there's an empty string on the iterator
655 stack, pop the stack. (Bug#10903)
657 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
659 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
660 Suggested by Stefan Monnier in
661 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
662 * alloc.c (widen_to_Lisp_Object): New static function.
663 (mark_memory): Also mark Lisp_Objects by fetching pointer words
664 and widening them to Lisp_Objects. This would work even if
665 USE_LSB_TAG is defined and wide integers are used, which might
666 happen in a future version of Emacs.
668 2012-02-25 Chong Yidong <cyd@gnu.org>
670 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
673 * xselect.c (Fx_selection_exists_p): Doc fix.
674 (x_clipboard_manager_save_all): Print an informative message
675 before saving to clipboard manager.
677 2012-02-24 Chong Yidong <cyd@gnu.org>
679 * keyboard.c (process_special_events): Handle all X selection
680 requests in kbd_buffer, not just the next one (Bug#8869).
682 2012-02-23 Chong Yidong <cyd@gnu.org>
684 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
685 call when setting menu-bar-lines and tool-bar-lines parameters.
686 (unwind_create_frame_1): New helper function.
688 * window.c (inhibit_window_configuration_change_hook): New var.
689 (run_window_configuration_change_hook): Obey it.
690 (syms_of_window): Initialize it.
692 2012-02-22 Chong Yidong <cyd@gnu.org>
694 * xterm.c (x_draw_image_relief): Add missing type check for
695 Vtool_bar_button_margin (Bug#10743).
697 2012-02-21 Chong Yidong <cyd@gnu.org>
699 * fileio.c (Vfile_name_handler_alist): Doc fix.
701 * buffer.c (Fget_file_buffer): Protect against invalid file
702 handler return value.
704 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
706 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
707 when computing $valmask.
709 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
710 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
711 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
712 It's useless in that case, and it can cause problems on hosts
713 that allocate halves of EMACS_INT values separately.
714 Reported by Dan Horák. Diagnosed by Andreas Schwab in
715 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
716 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
717 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
718 it avoids undefined behavior on hosts where shifting right by more
719 than the word width has undefined behavior.
721 2012-02-19 Chong Yidong <cyd@gnu.org>
723 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
724 (Funhandled_file_name_directory, Ffile_name_as_directory)
725 (Fdirectory_file_name, Fexpand_file_name)
726 (Fsubstitute_in_file_name): Protect against invalid file handler
727 return values (Bug#10845).
729 2012-02-18 Eli Zaretskii <eliz@gnu.org>
731 * .gdbinit (pitx): Fix incorrect references to fields of the
734 2012-02-17 Chong Yidong <cyd@gnu.org>
736 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
738 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
740 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
741 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
743 2012-02-15 Chong Yidong <cyd@gnu.org>
745 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
746 marked as special. Also, starting docstrings with * is obsolete.
748 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
750 * gnutls.c (emacs_gnutls_write): Fix last change.
752 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
754 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
757 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
759 * keymap.c (Fsingle_key_description): Handle char ranges.
761 2012-02-12 Chong Yidong <cyd@gnu.org>
763 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
764 as that creates a dangerous corner case.
766 * window.c (Fdelete_window_internal): Invalidate the mouse
767 highlight (Bug#9904).
769 2012-02-12 Glenn Morris <rgm@gnu.org>
771 * xselect.c (Fx_own_selection_internal)
772 (Fx_get_selection_internal, Fx_disown_selection_internal)
773 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
774 * nsselect.m (Fx_own_selection_internal)
775 (Fx_disown_selection_internal, Fx_selection_exists_p)
776 (Fx_selection_owner_p, Fx_get_selection_internal):
777 Sync docs and argument specs with the xselect.c versions.
779 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
781 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
783 2012-02-11 Eli Zaretskii <eliz@gnu.org>
785 * w32select.c (Fx_selection_exists_p): Sync doc string and
786 argument list with xselect.c. (Bug#10783)
788 * w16select.c (Fx_selection_exists_p): Sync doc string and
789 argument list with xselect.c. (Bug#10783)
791 2012-02-10 Glenn Morris <rgm@gnu.org>
793 * fns.c (Fsecure_hash): Doc fix.
795 2012-02-09 Kenichi Handa <handa@m17n.org>
797 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
799 2012-02-07 Chong Yidong <cyd@gnu.org>
801 * buffer.c (Fbuffer_local_variables)
802 (buffer_lisp_local_variables): Handle unbound vars correctly;
803 don't let Qunbound leak into Lisp.
805 2012-02-07 Glenn Morris <rgm@gnu.org>
807 * image.c (Fimagemagick_types): Doc fix.
809 * image.c (imagemagick-render-type): Change it from a lisp object
810 to an integer. Move the doc here from the lisp manual.
811 Treat all values not equal to 0 the same.
813 2012-02-06 Chong Yidong <cyd@gnu.org>
815 * doc.c (store_function_docstring): Avoid applying docstring of
816 alias to base function (Bug#2603).
818 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
820 * .gdbinit (pp1, pv1): Remove redundant defines.
823 2012-02-04 Chong Yidong <cyd@gnu.org>
825 * nsterm.m: Declare a global (Bug#10694).
827 2012-02-04 Eli Zaretskii <eliz@gnu.org>
829 * w32.c (get_emacs_configuration_options):
830 Include --enable-checking, if specified, in the return value.
832 2012-02-04 Martin Rudalics <rudalics@gmx.at>
834 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
835 after rounding frame sizes. (Bug#9723)
837 2012-02-04 Eli Zaretskii <eliz@gnu.org>
839 * keyboard.c (adjust_point_for_property): Don't position point
840 before BEGV. (Bug#10696)
842 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
844 Handle overflow when computing char display width (Bug#9496).
845 * character.c (char_width): Return EMACS_INT, not int.
846 (char_width, c_string_width): Check for overflow when
847 computing the width; this is possible now that individual
848 characters can have unbounded width. Problem introduced
849 by merge from Emacs 23 on 2012-01-19.
851 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
853 * dbusbind.c (Fdbus_register_method): Mention the return value
854 :ignore in the docstring.
856 2012-02-02 Glenn Morris <rgm@gnu.org>
858 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
860 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
861 Unconditionally set to t. (Bug#10673)
862 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
863 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
864 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
866 2012-02-02 Kenichi Handa <handa@m17n.org>
868 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
869 0, do not call append_composite_glyph.
871 2012-02-02 Kenichi Handa <handa@m17n.org>
873 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
875 (x_produce_glyphs): If the component of a composition is a null
876 string, set it->pixel_width to 1 to avoid zero-width glyph.
878 2012-02-01 Eli Zaretskii <eliz@gnu.org>
880 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
881 first 2 arguments are identical. This makes inserting large
882 output from a subprocess an order of magnitude faster on
883 MS-Windows, where all sbrk'ed memory is always contiguous.
885 2012-01-31 Glenn Morris <rgm@gnu.org>
887 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
888 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
889 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
891 2012-01-29 Glenn Morris <rgm@gnu.org>
893 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
895 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
897 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
899 2012-01-28 Chong Yidong <cyd@gnu.org>
901 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
903 2012-01-26 Chong Yidong <cyd@gnu.org>
905 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
907 * search.c (Fsearch_forward, Fsearch_backward): Document negative
908 repeat counts (Bug#10507).
910 2012-01-26 Glenn Morris <rgm@gnu.org>
912 * lread.c (syms_of_lread): Doc fix.
914 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
916 * coding.c (encode_designation_at_bol): Change return value to
919 2012-01-25 Chong Yidong <cyd@gnu.org>
921 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
923 2012-01-21 Chong Yidong <cyd@gnu.org>
925 * floatfns.c (Fcopysign): Make the second argument non-optional,
926 since nil is not allowed anyway.
928 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
930 * process.c (read_process_output): Use p instead of XPROCESS (proc).
931 (send_process): Likewise.
933 2012-01-19 Martin Rudalics <rudalics@gmx.at>
935 * window.c (save_window_save, Fcurrent_window_configuration)
936 (Vwindow_persistent_parameters): Do not use Qstate.
939 2012-01-19 Kenichi Handa <handa@m17n.org>
941 * character.c (char_width): New function.
942 (Fchar_width, c_string_width, lisp_string_width):
943 Use char_width (Bug#9496).
945 2012-01-16 Martin Rudalics <rudalics@gmx.at>
947 * window.c (Vwindow_persistent_parameters): New variable.
948 (Fset_window_configuration, save_window_save): Handle persistent
951 2012-01-14 Eli Zaretskii <eliz@gnu.org>
953 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
954 thrashing the stack of the thread. (Bug#9087)
956 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
958 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
960 2012-01-11 Eli Zaretskii <eliz@gnu.org>
962 * xdisp.c (rows_from_pos_range): Handle the case where the
963 highlight ends on a newline. (Bug#10464)
964 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
965 he end column for display of highlight that ends on a newline
968 2012-01-11 Glenn Morris <rgm@gnu.org>
970 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
971 from load-path also when installation-directory is nil. (Bug#10208)
973 2012-01-10 Glenn Morris <rgm@gnu.org>
975 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
977 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
978 Update template values to be closer to their typical values these days.
980 2012-01-09 Eli Zaretskii <eliz@gnu.org>
982 * xdisp.c (rows_from_pos_range): Accept additional argument
983 DISP_STRING, and accept any glyph in a row whose object is that
984 string as eligible for mouse highlight. Fixes mouse highlight of
985 display strings from overlays. (Bug#10464)
987 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
989 emacs: fix an auto-save permissions race condition (Bug#10400)
990 * fileio.c (auto_saving_dir_umask): New static var.
991 (Fmake_directory_internal): Use it.
992 (do_auto_save_make_dir): Set it, instead of invoking chmod after
993 creating the directory. The old code temporarily assigns
994 too-generous permissions to the directory.
995 (do_auto_save_eh): Clear it.
996 (Fdo_auto_save): Catch all errors, not just file errors, so
997 that the var is always cleared.
999 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1001 * search.c (scan_buffer): Pass character positions to
1002 know_region_cache, not byte positions. (Bug#6540)
1004 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1006 * w32.c (sys_rename): Report EXDEV when rename of a directory
1007 fails because the target is on another logical disk. (Bug#10284)
1009 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1011 * xterm.c (x_embed_request_focus): New function.
1013 * xterm.h: Add prototype.
1015 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1017 2012-01-05 Glenn Morris <rgm@gnu.org>
1019 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1021 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1023 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1024 Load gnutls_transport_set_lowat only if GnuTLS version is below
1026 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1027 GnuTLS versions below 2.11.1.
1029 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1031 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1032 to the doc string advising against its use for altering the way
1033 windows are scrolled.
1035 2011-12-28 Kenichi Handa <handa@m17n.org>
1037 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1038 coding-system ASCII compatible only when it does not produce BOM
1039 on encoding (Bug#10383).
1041 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1043 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1045 (create_and_show_popup_menu): Always use menu_position_func for
1048 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1050 * callint.c (Fcall_interactively): Don't truncate prompt string.
1052 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1054 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1055 property that ends at ZV, so that the bidi iteration could be
1056 resumed from there (after widening). (Bug#10360)
1058 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1060 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1062 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1064 * nsterm.m (x_free_frame_resources):
1065 Release f->output_data.ns->miniimage.
1066 (ns_index_color): Fix indentation. Do not retain
1067 color_table->colors[i].
1069 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1072 * nsfns.m (x_set_background_color): Assign return value from
1073 ns_index_color to face-background instead of NSColor*.
1074 (ns_implicitly_set_icon_type): Fix indentation.
1075 Change assignment in for loop to comparison.
1077 * emacs.c (ns_pool): New variable.
1078 (main): Assign ns_pool.
1079 (Fkill_emacs): Call ns_release_autorelease_pool.
1081 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1082 autorelease fdesc, release fdAttrs and tdict.
1083 (ns_get_covering_families): Release charset.
1084 (ns_findfonts): Release NSFontDescriptor created with new.
1085 (ns_uni_to_glyphs): Fix indentation.
1086 (setString): Release attrStr before assigning new value.
1088 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1090 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1092 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1093 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1095 2011-12-18 David Reitter <reitter@cmu.edu>
1097 * nsterm.m (ns_term_init): Subscribe for notifications
1098 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1099 to method trackingNotification in EmacsMenu.
1101 * nsmenu.m (trackingMenu): New variable.
1102 (trackingNotification): New method (from Aquamacs).
1103 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1104 from Aquamacs (Bug#7030).
1106 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1108 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1109 (symbol_to_nsstring): Fix indentation.
1110 (ns_symbol_to_pb): New function.
1111 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1112 (Fns_rotate_cut_buffers_internal): Remove.
1113 (Fns_store_selection_internal): Rename from
1114 Fns_store_cut_buffer_internal.
1115 (ns_get_foreign_selection, Fx_own_selection_internal)
1116 (Fx_disown_selection_internal, Fx_selection_exists_p)
1117 (Fns_get_selection_internal, Fns_store_selection_internal):
1118 Use ns_symbol_to_pb and check if return value is nil.
1119 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1120 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1121 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1122 renamed to Sns_store_selection_internal.
1123 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1124 and remove this function.
1125 (ns_handle_selection_clear): Remove, never used.
1126 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1129 2011-12-17 Ken Brown <kbrown@cornell.edu>
1131 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1132 GID is unknown (Bug#10257).
1134 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1136 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1137 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1138 which caused a build failure on GNU/Linux IA-64. This problem was
1139 introduced by my 2011-10-07 patch.
1141 2011-12-15 Juri Linkov <juri@jurta.org>
1143 * image.c (imagemagick_error): New function. (Bug#10112)
1144 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1145 Use `imagemagick_error' where ImageMagick functions return
1147 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1150 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1152 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1153 fill background (Bug#8992).
1155 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1157 * window.c (Vwindow_combination_resize)
1158 (Vwindow_combination_limit): Use t instead of non-nil in
1160 (Vrecenter_redisplay): Add first sentence of doc-string on
1162 (Frecenter): Fix doc-string typo.
1164 2011-12-11 Kenichi Handa <handa@m17n.org>
1166 * coding.c (Funencodable_char_position): Pay attention to the
1167 buffer text relocation (Bug#9389).
1169 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1171 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1172 gtk_init (Bug#10100).
1174 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1176 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1177 IT->string is nil. (Bug#10263)
1179 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1181 * nsterm.h (x_free_frame_resources): Declare.
1183 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1184 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1186 * nsterm.h (ns_get_defaults_value): Declare.
1188 * nsterm.m (ns_default): Call ns_get_defaults_value.
1190 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1192 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1195 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1197 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1198 that where the value of an _OBJC_* symbol points to is in the .bss
1199 section (Bug#10240).
1201 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1203 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1204 after the loop to call ccl_driver at least once (Bug#8619).
1206 2011-12-08 Kenichi Handa <handa@m17n.org>
1208 * ftfont.c (get_adstyle_property): Fix previous change
1211 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1213 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1214 dirs from the default value of EMACSLOADPATH (bug#10208).
1216 2011-12-07 Glenn Morris <rgm@gnu.org>
1218 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1219 installation and source directories as well. (Bug#10208)
1221 2011-12-06 Chong Yidong <cyd@gnu.org>
1223 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1225 2011-12-06 Glenn Morris <rgm@gnu.org>
1227 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1228 as an error, not just -1. (Bug#10217)
1230 2011-12-05 Chong Yidong <cyd@gnu.org>
1232 * keyboard.c (process_special_events): New function.
1233 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1235 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1237 * coding.c (encode_designation_at_bol): Don't use uninitialized
1238 local variable (Bug#9318).
1240 2011-12-05 Kenichi Handa <handa@m17n.org>
1242 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1243 return Qnil (Bug#8046, Bug#10193).
1245 2011-12-05 Kenichi Handa <handa@m17n.org>
1247 * coding.c (encode_designation_at_bol): New args charbuf_end and
1248 dst. Return the number of produced bytes. Callers changed.
1249 (coding_set_source): Return how many bytes coding->source was
1251 (coding_set_destination): Return how many bytes
1252 coding->destination was relocated.
1253 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1254 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1256 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1258 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1259 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1262 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1264 The following changes are to fix Bug#9318.
1266 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1267 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1268 (encode_coding_iso_2022, encode_coding_sjis)
1269 (encode_coding_big5, encode_coding_charset): Use the above macros.
1271 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1273 * lisp.h (process_quit_flag): Fix external declaration.
1275 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1277 Don't macro-inline non-performance-critical code.
1278 * eval.c (process_quit_flag): New function.
1279 * lisp.h (QUIT): Use it.
1281 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1283 * nsfns.m (get_geometry_from_preferences): New function.
1284 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1286 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1288 * emacs.c (Qkill_emacs): Define.
1289 (syms_of_emacs): Initialize it.
1290 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1291 Qquit_flag to `kill-emacs' instead.
1292 (quit_throw_to_read_char): Add parameter `from_signal'.
1293 All callers changed. Call Fkill_emacs if requested and safe.
1294 * lisp.h (QUIT): Call Fkill_emacs if requested.
1296 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1298 * widget.c (update_wm_hints): Return if wmshell is null.
1299 (widget_update_wm_size_hints): New function.
1301 * widget.h (widget_update_wm_size_hints): Declare.
1303 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1304 widget_update_wm_size_hints (Bug#10104).
1306 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1308 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1309 before a newline, prepare the bidi iterator for consuming the
1310 newline, and keep the current paragraph direction. (Bug#10183)
1311 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1313 2011-12-02 Juri Linkov <juri@jurta.org>
1315 * search.c (Fword_search_regexp): New Lisp function created from
1316 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1317 (Fword_search_backward, Fword_search_forward)
1318 (Fword_search_backward_lax, Fword_search_forward_lax):
1319 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1320 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1322 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1324 * fileio.c (Finsert_file_contents): Move after-change-function call
1325 to before the "handled:" label, since all "goto handled" appear in
1326 cases where the *-change-functions have already been properly called
1329 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1331 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1332 waiting for input. (Bug#10169)
1334 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1336 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1337 verifies glyph row's hash code--we have just reallocated the
1338 glyphs, so their contents can be complete garbage. (Bug#10164)
1340 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1342 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1344 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1346 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1347 attributes are tested _before_ calling verify_row_hash, to protect
1348 against GCC re-ordering of the tests. (Bug#10164)
1350 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1352 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1354 * xterm.c (handle_one_xevent): Only set async_visible and friends
1355 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1356 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1357 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1359 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1361 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1362 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1363 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1364 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1365 All uses changed to use GCPRO1 etc.
1366 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1367 Revert to old implementation (i.e., before 2011-03-11).
1369 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1371 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1372 of scroll runs so as to avoid assigning disabled bogus rows and
1373 unnecessary graphics copy operations.
1375 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1377 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1378 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1379 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1380 (malloc, free, realloc, calloc): Redirect to e_* only when
1383 * lisp.h (GCTYPEBITS): Move before first use.
1384 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1385 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1386 this macro definition.
1388 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1391 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1393 * gtkutil.c (xg_create_frame_widgets):
1394 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1395 present with Gtk+ 2.0.
1397 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1399 * fileio.c (Finsert_file_contents): Undo previous change; see
1400 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1402 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1404 Rename locals to avoid shadowing.
1405 * fileio.c (Finsert_file_contents):
1406 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1407 * process.c (wait_reading_process_output):
1408 Rename inner 'proc' to 'p' to avoid shadowing.
1409 Indent for consistency with usual Emacs style.
1411 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1413 * xdisp.c (redisplay_window): If cursor row is not fully visible
1414 after recentering, and scroll-conservatively is set to a large
1415 number, scroll window by a few more lines to make the cursor fully
1416 visible and out of scroll-margin. (Bug#10105)
1417 (start_display): Don't move to the next line if the display should
1418 start at a newline that is part of a display vector or an overlay
1421 2011-11-24 Juri Linkov <juri@jurta.org>
1423 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1424 after the `MagickPingImage' call. (Bug#10112)
1426 2011-11-23 Chong Yidong <cyd@gnu.org>
1428 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1430 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1432 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1433 making another buffer current. (Bug#10114)
1435 2011-11-23 Glenn Morris <rgm@gnu.org>
1437 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1439 2011-11-23 Chong Yidong <cyd@gnu.org>
1441 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1442 using it (Bug#5984).
1444 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1446 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1447 and header-lines, as they don't have one computed for them.
1450 * .gdbinit (prow): Make displayed values more self-explaining.
1451 Add row's hash code.
1453 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1455 * process.c (wait_reading_process_output): Fix asynchrounous
1456 GnuTLS socket handling on some versions of the GnuTLS library.
1457 (wait_reading_process_output): Add comment and URL.
1459 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1461 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1463 2011-11-21 Chong Yidong <cyd@gnu.org>
1465 * window.c (Fnext_window, Fprevious_window): Doc fix.
1467 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1469 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1471 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1473 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1475 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1477 * window.c (Fset_window_combination_limit): Rename argument
1479 (Vwindow_combination_limit): Remove "status" from doc-string.
1481 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1483 * m/ibms390.h: Remove.
1484 * m/ibms390x.h: Don't include "ibms390.h".
1486 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1488 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1489 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1491 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1493 * casetab.c (Fset_case_table):
1494 * charset.c (Fcharset_after): Fix typos.
1496 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1498 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1499 Otherwise, valgrind does not work on some platforms.
1500 Problem reported by Andreas Schwab in
1501 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1502 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1503 is set, removing the need for VIRT_ADDRESS_VARIES.
1504 (PURE_P): Use a more-efficient implementation that needs just one
1505 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1506 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1507 to 4 (xorl, subq, cmpq, setbe).
1508 * alloc.c (pure): Always extern now, since that's the
1509 VIRT_ADDR_VARIES behavior.
1510 (PURE_POINTER_P): Use a single comparison, not two, for
1511 consistency with the new puresize.h.
1512 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1513 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1514 Remove VIRT_ADDR_VARIES no longer needed.
1516 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1518 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1519 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1520 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1521 behave as if the cursor position were at the window margin.
1523 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1524 and the cursor position is out of bounds, behave as if the cursor
1525 position were at the window margin. (Bug#10075)
1527 2011-11-18 Chong Yidong <cyd@gnu.org>
1529 * window.c (Fwindow_combination_limit): Make first argument
1530 non-optional, since it is meaningless for live windows like the
1533 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1535 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1537 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1539 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1540 (graft_intervals_into_buffer): Simplify.
1542 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1544 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1545 hash values of the two rows.
1546 (copy_row_except_pointers): Preserve the used[] arrays and the
1547 hash values of the two rows. (Bug#10035)
1548 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1550 * xdisp.c (row_hash): New function, body extracted from
1551 compute_line_metrics.
1552 (compute_line_metrics): Call row_hash, instead of computing the
1555 * dispnew.c (verify_row_hash): Call row_hash for computing the
1556 hash code of a row, instead of duplicating code from xdisp.c.
1558 * dispextern.h (row_hash): Add prototype.
1560 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1562 * frame.c (delete_frame): Don't delete the terminal when the last
1563 X frame is closed if emacs is built with GTK toolkit.
1565 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1567 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1569 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1571 * window.c (Vwindow_splits): Rename to
1572 Vwindow_combination_resize. Suggested by Juri Linkov.
1573 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1576 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1578 * nsfns.m (Fns_font_name):
1579 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1581 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1583 * window.h (window): Rename slot "nest" to "combination_limit".
1584 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1585 (Fset_window_nest): Rename to Fset_window_combination_limit.
1586 (Vwindow_nest): Rename to Vwindow_combination_limit.
1587 (recombine_windows, make_parent_window, make_window)
1588 (Fsplit_window_internal, saved_window)
1589 (Fset_window_configuration, save_window_save): Rename all
1590 occurrences of window_nest to window_combination_limit.
1592 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1594 * image.c (imagemagick_load_image): Fix typo.
1596 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1598 * xdisp.c (display_line): Move the call to
1599 highlight_trailing_whitespace before the call to
1600 compute_line_metrics, since the latter needs to see the final
1601 faces of all the glyphs to compute ROW's hash value.
1602 Fixes assertion violations in row_equal_p. (Bug#10035)
1604 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1606 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1607 just return (bug#10044).
1609 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1611 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1612 with user-defined heap size. Bump the default size of the temacs
1613 heap to 27MB, to avoid memory warning when running temacs.
1614 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1616 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1617 current_matrix and desired_matrix. (Bug#9990)
1618 (verify_row_hash) [XASSERTS]: New function.
1619 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1620 that the hash value of glyph rows is correct.
1622 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1624 * window.h (window): Remove splits slot.
1625 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1626 (Fdelete_other_windows_internal, make_parent_window)
1627 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1628 (Fset_window_configuration, save_window_save): Don't deal with
1629 split status of windows.
1630 (saved_window): Remove splits slot.
1631 (Vwindow_splits): Rewrite doc-string.
1633 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1635 * xfns.c (unwind_create_frame):
1636 * nsfns.m (unwind_create_frame):
1637 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1638 Vframe_list (Bug#9999).
1640 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1642 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1644 2011-11-11 Kenichi Handa <handa@m17n.org>
1646 * callproc.c (Fcall_process): Set the member dst_multibyte of
1649 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1651 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1652 avoid a crash (bug#9496).
1654 2011-11-09 Chong Yidong <cyd@gnu.org>
1656 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1657 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1659 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1661 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1663 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1665 Avoid some portability problems by eschewing 'extern inline' functions.
1666 The trivial performance wins aren't worth the portability hassles; see
1667 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1669 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1670 (window_box_width, window_box_left, window_box_left_offset)
1671 (window_box_right, window_box_right_offset): Undo previous change,
1672 by removing the "extern"s.
1673 * intervals.c (adjust_intervals_for_insertion)
1674 (adjust_intervals_for_deletion): Undo previous change,
1675 making these static again.
1676 (offset_intervals, temp_set_point_both, temp_set_point)
1677 (copy_intervals_to_string): No longer inline.
1678 * xdisp.c (window_text_bottom_y, window_box_width)
1679 (window_box_height, window_box_left_offset)
1680 (window_box_right_offset, window_box_left, window_box_right)
1681 (window_box): No longer inline.
1683 2011-11-08 Chong Yidong <cyd@gnu.org>
1685 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1686 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1687 Signal an error if not a live window.
1688 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1689 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1691 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1693 * lisp.h (syms_of_abbrev): Remove declaration.
1694 Reported by CHENG Gao <chenggao@royau.me>.
1696 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1698 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1699 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1700 of temacs in GUI mode.
1702 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1704 * window.h: Declare delete_all_child_windows instead of
1705 delete_all_subwindows.
1706 * window.c (Fwindow_nest, Fset_window_nest)
1707 (Fset_window_new_total, Fset_window_new_normal)
1708 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1709 (delete_all_subwindows): Rename to delete_all_child_windows.
1710 (Fdelete_other_windows_internal, Fset_window_configuration):
1711 Call delete_all_child_windows instead of delete_all_subwindows.
1712 * frame.c (delete_frame): Call delete_all_child_windows instead
1713 of delete_all_subwindows.
1715 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1717 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1718 This is also needed for porting to any host where GC_MARK_STACK is
1719 not GC_MAKE_GCPROS_NOOPS.
1720 (which_symbols): Use it.
1722 2011-11-07 Kenichi Handa <handa@m17n.org>
1724 * coding.c (coding_set_destination): Check coding->src_pos only
1725 when coding->src_object is a buffer (bug#9910).
1727 * process.c (send_process): Set the member src_multibyte of coding
1728 to 0 (bug#9911) when sending a unibyte text.
1730 * callproc.c (Fcall_process): Set the member src_multibyte of
1731 process_coding to 0 (bug#9912).
1733 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1735 * xmenu.c (cleanup_widget_value_tree): New function.
1736 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1737 calling free_menubar_widget_value_tree directly (Bug#9830).
1739 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1741 Fix some portability problems with 'inline'.
1742 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1743 (window_box_width, window_box_left, window_box_left_offset)
1744 (window_box_right, window_box_right_offset): Declare extern.
1745 Otherwise, these inline functions do not conform to C99 and
1746 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1747 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1748 * intervals.c (adjust_intervals_for_insertion)
1749 (adjust_intervals_for_deletion): Now extern, because otherwise the
1750 extern inline functions 'offset_intervals' couldn't refer to it.
1751 (static_offset_intervals): Remove.
1752 (offset_intervals): Rewrite using the old contents of
1753 static_offset_intervals. The old version didn't conform to C99
1754 because an extern inline function contained a reference to an
1755 identifier with static linkage.
1757 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1759 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1762 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1764 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1765 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1766 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1767 return Qleft_to_right.
1769 2011-11-06 Chong Yidong <cyd@gnu.org>
1771 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1772 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1773 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1774 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1775 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1776 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1777 (Fwindow_vscroll): Doc fix.
1778 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1779 argument, since it makes no sense to pass a live window and for
1780 consistency with window-child.
1782 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1784 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1787 2011-11-05 Jason Rumney <jasonr@gnu.org>
1789 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1790 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1792 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1793 bitwise arithmetic preventing use of unicode-sip and non-truetype
1796 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1798 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1801 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1802 initialization code to keep similarity to xfns.c after changes
1805 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1807 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1808 (unwind_create_frame): New function (Bug#9943).
1809 (Fx_create_frame): Restructure code to be more similar to the one in
1810 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1811 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1812 Move terminal->reference_count++ just before making the frame official
1815 * nsterm.m (x_free_frame_resources): New function.
1816 (x_destroy_window): Move code to x_free_frame_resources.
1818 * xfns.c (unwind_create_frame): Fix comment.
1819 (Fx_create_frame, x_create_tip_frame):
1820 Move terminal->reference_count++ just before making the frame
1821 official. Move initialization of image_cache_refcount and
1822 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1824 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1826 Support MSVC build with newer versions of Visual Studio.
1827 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1828 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1831 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1832 which are not supported by MSVC.
1833 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1834 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1836 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1838 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1840 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1842 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1844 Support MSVC build with newer versions of Visual Studio.
1845 * w32.c: Don't include w32api.h for MSVC.
1846 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1848 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1849 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1850 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1851 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1853 (alloca) [_MSC_VER]: Define to _alloca.
1855 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1857 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1859 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1861 * xdisp.c (note_mouse_highlight): If either of
1862 previous/next-single-property-change returns nil, treat that as
1863 the beginning or the end of the buffer. (Bug#9955)
1865 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1867 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1868 label is not null (Bug#9951).
1869 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1872 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1874 * window.c (Fwindow_body_size): Mention in the doc string that the
1875 return value is in frame's canonical units. (Bug#9949)
1877 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1879 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1881 * w32fns.c (unwind_create_frame): If needed, free the glyph
1882 matrices of the partially constructed frame. (Bug#9943)
1883 * xfns.c (unwind_create_frame): Likewise.
1885 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1887 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1888 Don't stop backward scan on the continuation glyph, even though
1889 its CHARPOS is positive.
1890 (mouse_face_from_buffer_pos, note_mouse_highlight):
1891 Rename cover_string to disp_string.
1893 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1895 * window.c (temp_output_buffer_show): Don't use
1896 Vtemp_buffer_show_specifiers.
1897 (Vtemp_buffer_show_specifiers): Remove unused variable.
1899 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1901 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1902 past the beginning of the current glyph matrix.
1904 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1906 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1907 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1908 HAVE_GTK3 (Bug#9869).
1910 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1911 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1913 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1915 * xterm.c: Declare x_handle_net_wm_state to return int.
1916 (handle_one_xevent): Check if we are iconified but don't have
1917 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1918 (get_current_wm_state): Return non-zero if not hidden,
1919 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1920 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1921 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1922 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1924 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1926 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1927 so that this new function doesn't get optimized away by a
1928 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1930 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1932 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1934 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1936 Fix the `xbytecode' command.
1937 * .gdbinit (xprintbytestr): New command.
1938 (xwhichsymbols): Rename from `which'; all callers changed.
1939 (xbytecode): Print the byte-code string as well.
1941 2011-10-29 Kim Storm <storm@cua.dk>
1943 * alloc.c (which_symbols): New function.
1945 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1947 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1950 2011-10-29 Glenn Morris <rgm@gnu.org>
1952 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1953 Not clear what it was for, and it causes various bugs. (Bug#9839)
1955 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1957 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1958 possible random value that matches one of those tested as
1959 condition to clear the mouse face.
1961 2011-10-28 Chong Yidong <cyd@gnu.org>
1963 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1965 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1967 * window.c (make_window): Initialize phys_cursor_on_p.
1969 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1971 * lisp.h (struct Lisp_Symbol): Update comments.
1973 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1975 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1977 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1979 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1980 <oslsachem@gmail.com> for helping to debug this.
1982 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1983 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1984 (g_b_init_get_glyph_outline_w): New static variables.
1985 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1986 (GetGlyphOutlineW_Proc): New typedefs.
1987 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1988 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1990 (w32font_open_internal, compute_metrics):
1991 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1992 instead of calling the "wide" APIs directly.
1994 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1996 * w32.h (syms_of_w32font): Add prototype.
1998 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2000 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2001 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2002 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2003 (Fmove_to_window_line): Doc fix.
2005 2011-10-27 Chong Yidong <cyd@gnu.org>
2007 * process.c (make_process): Set gnutls_state to NULL.
2009 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2010 non-NULL, regardless of GNUTLS_INITSTAGE.
2011 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2012 an error. Set process slots as soon as we allocate them.
2014 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2016 2011-10-27 Chong Yidong <cyd@gnu.org>
2018 * gnutls.c (emacs_gnutls_deinit): New function.
2019 Deallocate credentials structures as well as calling gnutls_deinit.
2020 (Fgnutls_deinit, Fgnutls_boot): Use it.
2022 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2023 (deactivate_process): Call emacs_gnutls_deinit.
2025 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2027 * image.c (x_create_x_image_and_pixmap):
2028 * w32.c (sys_rename, w32_delayed_load):
2029 * w32font.c (fill_in_logfont):
2030 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2032 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2034 * w32fns.c (w32_default_color_map): New function,
2035 extracted from Fw32_default_color_map.
2036 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2038 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2040 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2042 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2044 * keyboard.c (test_undefined): New function (bug#9751).
2045 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2047 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2049 * sysdep.c (init_sys_modes): Fix the check for the controlling
2050 terminal (Bug#6649).
2052 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2054 * dispextern.h (struct bidi_it): New member next_en_type.
2056 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2057 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2058 current character, check also for next_en_type being WEAK_EN.
2059 (bidi_resolve_weak): Don't enter the expensive loop if the current
2060 position is before next_en_pos. Record the bidi type of the first
2061 non-ET, non-BN character we find, in addition to its position.
2062 (bidi_level_of_next_char): Invalidate next_en_type when
2063 next_en_pos is over-stepped.
2065 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2067 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2068 * editfns.c: Rewrite current-time-zone so that it invokes
2069 the equivalent of (format-time-string "%Z") to get the time zone name.
2070 This fixes a bug when the time zone name contains characters that
2071 need converting from the system time locale to Emacs internal format.
2072 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2073 that patch fixed format-time-string to do the conversion, but
2074 I forgot to fix current-time-zone.
2075 (format_time_string): New function, containing most of
2076 what Fformat_time_string used to contain.
2077 (Fformat_time_string): Rewrite in terms of format_time_string.
2078 This doesn't change this function's behavior.
2079 (current-time-zone): Rewrite to use format_time_string.
2080 This fixes the bug reported by Michael Schierl in
2081 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2082 Jason Rumney's 2007-06-07 change worked around this bug, but
2084 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2086 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2088 * xdisp.c (start_display): If the character at POS is displayed
2089 via a display vector, reset IT->current.dpvec_index to zero.
2090 (try_window_reusing_current_matrix): If a line ends in a display
2091 vector or the next line starts in a display vector, continue
2092 redrawing the window even though the character position of
2093 start_row was reached.
2096 2011-10-18 Chong Yidong <cyd@gnu.org>
2098 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2099 with nobreak-char-display too.
2101 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2103 Fix part 3 of bug#9771.
2104 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2105 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2106 non-neutral characters if the current character is a paragraph
2107 separator (a.k.a. Newline). This avoids running the same
2108 expensive loop twice, once when we consume the preceding newline
2109 and the other time when the line actually needs to be displayed.
2110 Avoid the loop when we see neutrals on the base embedding level
2111 following a character whose directionality is the same as the
2112 paragraph's. This avoids running the expensive loop when a line
2113 ends in a long sequence of neutrals, like control characters.
2114 Add assertion against STRONG_AL type. Slightly rearrange code
2115 that determines the type of a neutral given the first non-neutral
2117 (bidi_level_of_next_char): Set next_en_pos to zero when
2118 invalidating its info.
2120 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2122 * xdisp.c (push_display_prop): Determine whether to record string
2123 or buffer position by IT->string, not by IT->method. Allow
2124 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2125 (move_it_vertically_backward): Don't look for character position
2126 immediately after the newline when in a continuation line.
2129 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2131 * window.c (coordinates_in_window): Rewrite and delabelize
2132 vertical border check. (Bug#5357) (Bug#9618)
2134 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2136 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2137 errors in XSetWindowBorder (bug#9310).
2139 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2141 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2142 avoid crash when xmalloc overrun checking is enabled.
2144 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2147 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2148 cursor motion with <left> and <right> arrow keys.
2150 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2151 some callers set that themselves.
2153 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2155 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2156 display string and the previous row comes from the same string and
2157 is empty. (Bug#9739) (Bug#9738)
2159 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2161 * doc.c (get_doc_string): Encode file name (bug#9735).
2163 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2165 * bidi.c (bidi_level_of_next_char):
2166 * xdisp.c (get_visually_first_element): Remove old incorrect
2167 comments regarding the Unicode Line Separator character.
2169 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2171 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2173 * alloc.c (Fgc_status): Do not access beyond zombies array
2174 boundary if nzombies > MAX_ZOMBIES.
2175 * alloc.c (dump_zombies): Add missing format specifier.
2177 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2179 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2180 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2182 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2183 Some packages use them to denote characters with modifiers.
2185 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2187 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2188 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2189 matching a pp-number. Rename parameter var to var1.
2191 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2193 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2195 2011-10-08 Glenn Morris <rgm@gnu.org>
2197 * callint.c (Fcall_interactively): Give a more explicit error for the
2198 'c' case with a non-character input. (Bug#8479)
2200 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2202 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2204 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2205 lines that are hscrolled on the left.
2207 * dispnew.c (buffer_posn_from_coords): Account for a possible
2208 presence of header-line. (Bug#4426)
2210 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2212 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2213 Don't advertise functionality which we discourage or doesn't work.
2215 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2217 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2218 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2219 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2220 this makes Emacs dump core during garbage collection on rare
2221 occasions. sizeof is obviously inferior to offsetof here, so
2222 stick with offsetof.
2223 (GC_POINTER_ALIGNMENT): New macro.
2224 (mark_memory): Omit 3rd (offset) arg; caller changed.
2225 Don't assume EMACS_INT alignment is the same as pointer alignment.
2227 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2229 * keyboard.c (read_key_sequence_remapped): New var.
2230 (read_key_sequence): Compute remapping in the right buffer.
2231 (command_loop_1): Use read_key_sequence's remapping directly.
2233 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2235 * dired.c (file_name_completion): Don't expand file name.
2236 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2237 before checking file name handler.
2239 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2240 they've been requested explicitly (bug#9591).
2242 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2244 * keymap.c (Fsingle_key_description): Use make_specified_string
2245 instead of build_string to build string from push_key_description.
2248 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2250 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2251 This fixes a Y2038 bug on 64-bit hosts.
2252 * buffer.c (reset_buffer):
2253 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2254 (Fclear_buffer_auto_save_failure):
2255 Use 0, not -1, to represent an unset failure time, since time_t
2256 might not be signed.
2258 Remove dependency on glibc malloc internals.
2259 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2260 Move back here from lisp.h, but with their new implementations.
2261 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2262 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2263 * charset.c (charset_table_init): New static var.
2264 (syms_of_charset): Use it instead of xmalloc. This removes a
2265 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2266 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2267 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2268 Move back to alloc.c.
2269 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2270 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2272 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2274 * nsterm.m (windowDidResize): Call x_set_window_size only when
2275 ns_in_resize is true. Otherwise set pixelwidth/height and
2276 call change_frame_size (Bug#9628).
2278 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2280 Port --enable-checking=all to Fedora 14 x86-64.
2281 * charset.c (syms_of_charset): Also account for glibc malloc's
2282 internal overhead when calculating the initial malloc maximum.
2284 Port --enable-checking=all to Fedora 14 x86.
2285 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2287 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2288 (overrun_check_realloc, overrun_check_free):
2289 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2290 That way, xmalloc returns a properly-aligned pointer even if
2291 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2292 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2293 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2294 into account when calculating the initial malloc maximum.
2295 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2296 Move here from alloc.c, so that charset.c can use it too.
2297 Properly align; the old code wasn't right for common 32-bit hosts
2298 when configured with --enable-checking=all.
2299 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2300 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2302 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2304 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2307 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2309 * xdisp.c (compute_display_string_end): If there's no display
2310 string at CHARPOS, return -1.
2312 * bidi.c (bidi_fetch_char): When compute_display_string_end
2313 returns a negative value, treat the character as a normal
2314 character not covered by a display string. (Bug#9624)
2316 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2318 * lread.c (Fread_from_string): Fix typo in docstring.
2320 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2322 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2323 newline, reseat the iterator instead of bidi-iterating there one
2324 character at a time. (Bug#9610)
2325 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2326 TO_CHARPOS if the bidi iterator is at base embedding level.
2328 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2330 * lread.c (readevalloop): Use correct code for NBSP.
2331 (read1): Likewise. (Bug#9608)
2333 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2335 * dbusbind.c (Fdbus_register_signal): When service is not
2336 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2338 2011-09-25 Glenn Morris <rgm@gnu.org>
2340 * buffer.c (truncate-lines): Doc fix.
2342 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2344 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2345 (Fset_window_next_buffers): Doc fix.
2347 2011-09-24 Glenn Morris <rgm@gnu.org>
2349 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2351 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2353 Fix minor problems found by static checking.
2354 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2355 * indent.c (Fvertical_motion): Fix == vs = typo.
2357 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2359 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2360 Default value is now t. Doc fix.
2362 * indent.c (Fvertical_motion): Compute and apply the overshoot
2363 logic when moving up, not only when moving down. Fix the
2364 confusing name and values of the it_overshoot_expected variable;
2365 logic changes accordingly. (Bug#9254) (Bug#9549)
2367 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2368 CHARPOS is covered by a display string which includes newlines.
2369 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2370 is covered by a display string with embedded newlines.
2372 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2374 * dbusbind.c (Fdbus_register_signal): Add match rule to
2375 Vdbus_registered_objects_table. (Bug#9581)
2376 (Fdbus_register_method, Vdbus_registered_objects_table):
2379 2011-09-24 Jim Meyering <meyering@redhat.com>
2381 do not ignore write error for any output size
2382 The previous change was incomplete.
2383 While it makes emacs --batch detect the vast majority of stdout
2384 write failures, errors were still ignored whenever the output size is
2385 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2386 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2387 && echo FAIL: ignored write error
2388 FAIL: ignored write error
2389 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2390 && echo FAIL: ignored write error
2391 FAIL: ignored write error
2392 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2394 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2396 * emacs.c (Fkill_emacs): In noninteractive mode exit
2397 non-successfully if a write error occurred on stdout. (Bug#9574)
2399 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2401 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2404 * dispextern.h (struct it): Update the comment documenting what
2407 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2409 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2410 a display string, extend search for cursor position to end of row.
2411 (find_row_edges): If the row ends in a newline from a display
2412 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2413 Handle the case of a display string with multiple newlines.
2414 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2415 non-empty line. Fixes confusing cursor motion with arrow keys at
2416 the beginning of a line that starts with whitespace.
2418 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2420 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2423 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2425 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2428 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2430 * xdisp.c (display_line): Record maximum and minimum buffer
2431 positions even if no glyphs were produced (e.g., by a zero-width
2432 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2433 buffer positions that will be removed from the glyph row because
2435 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2436 column is beyond frame width: don't subtract 1 "pixel" when
2437 computing width of the stretch.
2438 (reseat_at_next_visible_line_start): Undo the change made on
2439 2011-09-17 that saved paragraph information and restored it after
2440 the call to `reseat'. (Bug#9545)
2442 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2444 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2445 and turn window cursor on if cleared (Bug#9415).
2447 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2449 * search.c (boyer_moore): Take unibyte characters from pattern
2450 literally. (Bug#9458)
2452 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2454 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2456 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2458 Fix minor problem found by static checking.
2459 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2460 initialized, to pacify gcc -Wuninitialized.
2462 * fileio.c: Report proper errno when syscall falls.
2463 (Finsert_file_contents): Save and restore errno,
2464 so that report_file_error outputs the correct diagnostic.
2465 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2467 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2469 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2471 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2473 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2474 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2476 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2478 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2479 about the current paragraph and restore it after the call to reseat.
2481 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2482 (bidi_find_paragraph_start): Search back for paragraph beginning
2483 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2484 (bidi_move_to_visually_next): Only trigger paragraph-related
2485 computations when the last character is a newline or at EOB, not
2486 just any NEUTRAL_B. (Bug#9470)
2488 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2489 truncated lines if point is covered by a display string. (Bug#9524)
2491 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2493 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2494 (cons_to_x_long): New function.
2495 (lisp_data_to_selection_data): Use it. Correct the test for
2496 short-versus-long data; it was negated. Break out of vector
2497 loop, for efficiency, when a long datum is discovered.
2499 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2501 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2503 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2505 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2506 GCC PR/17406) by declaring this function with external scope.
2508 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2510 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2511 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2513 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2515 * editfns.c (Fformat): Correctly handle text properties on "%%".
2517 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2519 * xterm.c (x_draw_composite_glyph_string_foreground):
2520 * w32term.c (x_draw_composite_glyph_string_foreground):
2521 * term.c (encode_terminal_code):
2522 * composite.c (composition_update_it, get_composition_id):
2523 * xdisp.c (get_next_display_element)
2524 (fill_composite_glyph_string): Add comments about special meaning
2525 of TAB characters in a composition.
2527 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2529 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2530 This occurs when processing a multibyte format.
2531 Problem reported by Wolfgang Jenker.
2533 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2535 * xdisp.c (try_cursor_movement): Only check for exact match if
2536 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2538 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2540 Remove unused external symbols.
2541 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2542 * xdisp.c (calc_pixel_width_or_height): Now static.
2543 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2544 * indent.c (check_display_width):
2545 * w32term.c: Fix comment to match code.
2546 * xterm.c, xterm.h (x_catching_errors): Remove.
2548 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2550 * xselect.c: Use signed conversions more consistently (Bug#9498).
2551 (selection_data_to_lisp_data): Assume incoming selection data are
2552 signed integers, not unsigned. This is to be consistent with
2553 outgoing selection data, which was modified to use signed integers
2554 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2555 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2556 expects long, not unsigned long.
2558 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2560 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2561 computation of loop end. Reported by Johan Bockgård
2564 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2566 * frame.c (Fother_visible_frames_p): Function deleted.
2568 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2570 * indent.c (compute_motion): Process display vector front to back
2571 rather than the other way around. (Bug#2496)
2573 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2575 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2577 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2579 * minibuf.c (Fread_from_minibuffer): Doc fix.
2581 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2583 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2584 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2586 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2588 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2589 value for non-existent files.
2591 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2593 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2594 set its "size" to -1. This will set the modtime_size field of
2595 the corresponding buffer to -1, which is what
2596 verify-visited-file-modtime expects for files that do not exist.
2599 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2601 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2603 * lisp.h: ... from here. push_key_description is no longer
2604 defined in keyboard.c, so its declaration should not be in
2605 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2606 logically belongs with push_key_description.
2608 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2610 * buffer.h: Include <sys/types.h> instead of <time.h>.
2611 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2612 Problem reported by Herbert J. Skuhra.
2614 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2616 * xml.c (parse_region): Make the parsing work for
2617 non-comment-starting XML files again (bug#9144).
2619 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2621 * image.c (gif_load): Fix calculation of bottom and right corner.
2624 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2626 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2627 redisplay in small windows.
2629 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2631 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2633 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2635 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2636 Operate on live windows only.
2638 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2640 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2642 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2644 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2645 only under bidi iteration.
2647 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2649 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2651 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2653 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2654 Without this fix, the command to link temacs failed due to an
2655 undefined symbol __builtin_isnan. This is because
2656 /usr/include/iso/math_c99.h #defines isnan(x) to
2657 __builtin_isnan(x), but the bundled gcc, which identifies itself
2658 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2660 * floatfns.c (isnan): #undef, and then #define to a clone of
2662 (Fisnan): Always define, since it's always available now.
2663 (syms_of_floatfns): Always define isnan at the Lisp level.
2665 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2667 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2669 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2671 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2672 The previous code assumed that file offsets (off_t values) fit in
2673 EMACS_INT variables, which is not true on typical 32-bit hosts.
2674 The code messed up by falsely reporting buffer overflow in cases
2675 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2676 when "big" contains more than 2**29 bytes, even though this
2677 inserts just one byte and does not overflow the buffer.
2678 (Finsert_file_contents): Store file offsets as off_t
2679 values, not as EMACS_INT values. Check for overflow when
2680 converting between EMACS_INT and off_t. When checking for
2681 buffer overflow or for overlap, take the offsets into account.
2682 Don't use EMACS_INT for small values where int suffices.
2683 When checking for overlap, fix a typo: ZV was used where
2684 ZV_BYTE was intended.
2685 (Fwrite_region): Don't assume off_t fits into 'long'.
2686 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2688 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2690 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2692 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2694 sprintf-related integer and memory overflow issues (Bug#9412).
2696 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2697 (esprintf, exprintf, evxprintf): New functions.
2698 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2699 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2700 (modify_event_symbol): Do not assume that the length of
2701 name_alist_or_stem is safe to alloca and fits in int.
2702 (Fexecute_extended_command): Likewise for function name and binding.
2703 (Frecursion_depth): Wrap around reliably on integer overflow.
2704 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2705 since some callers pass EMACS_INT values.
2706 (Fsingle_key_description): Don't crash if symbol name contains more
2707 than MAX_ALLOCA bytes.
2708 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2709 (get_minibuffer): Arg is now EMACS_INT, not int.
2710 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2711 (esprintf, exprintf, evxprintf): New decls.
2712 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2714 * dbusbind.c (signature_cat): New function.
2715 (xd_signature, Fdbus_register_signal):
2716 Do not overrun buffer; instead, report string overflow.
2718 * dispnew.c (add_window_display_history): Don't overrun buffer.
2719 Truncate instead; this is OK since it's just a log.
2721 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2722 even if the time zone offset is outlandishly large.
2723 Don't mishandle offset == INT_MIN.
2725 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2726 when creating daemon; the previous buffer-overflow check was incorrect.
2728 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2729 which has the guts of the old verror function.
2731 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2732 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2734 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2735 (font_unparse_xlfd): Don't blindly alloca long strings.
2736 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2737 fits in int, when using sprintf. Use single snprintf to count
2738 length of string rather than counting it via multiple sprintfs;
2739 that's simpler and more reliable.
2740 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2741 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2742 sprintf, in case result does not fit in int.
2744 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2745 (fontset_from_font): Print it.
2747 * frame.c (tty_frame_count): Now printmax_t, not int.
2748 (make_terminal_frame, set_term_frame_name): Print it.
2749 (x_report_frame_params): In X, window IDs are unsigned long,
2750 not signed long, so print them as unsigned.
2751 (validate_x_resource_name): Check for implausibly long names,
2752 and don't assume name length fits in 'int'.
2753 (x_get_resource_string): Don't blindly alloca invocation name;
2754 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2757 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2758 (xg_check_special_colors, xg_set_geometry):
2759 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2761 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2762 Use esprintf, not sprintf, in case result does not fit in int.
2764 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2765 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2766 it as a large positive number.
2767 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2768 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2770 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2771 in case result does not fit in int.
2773 * print.c (float_to_string): Detect width overflow more reliably.
2774 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2775 buffer overrun. Don't assume list length fits in 'int'. Treat
2776 print length of 0 as 0, not as infinity; to be consistent with other
2777 uses of print length in this function. Don't overflow print length
2778 index. Don't assume hash table size fits in 'long', or that
2779 vectorlike size fits in 'unsigned long'.
2781 * process.c (make_process): Use printmax_t, not int, to format
2782 process-name gensyms.
2784 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2786 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2787 to avoid potential buffer overrun.
2789 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2790 if X resource line is longer than 512 bytes.
2792 * xfns.c (x_window): Make sprintf buffer a bit bigger
2793 to avoid potential buffer overrun.
2795 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2797 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2799 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2801 Integer overflow fixes for scrolling, etc.
2802 Without these, Emacs silently mishandles large integers sometimes.
2803 For example, "C-u 4294967297 M-x recenter" was treated as if
2804 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2806 * xdisp.c (try_window_id): Check Emacs fixnum range before
2807 converting to 'int'.
2809 * window.c (window_scroll_line_based, Frecenter):
2810 Check that an Emacs fixnum is in range before assigning it to 'int'.
2811 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2812 values converted from Emacs fixnums.
2813 (Frecenter): Don't wrap around a line count if it is out of 'int'
2814 range; instead, treat it as an extreme value.
2815 (Fset_window_configuration, compare_window_configurations):
2816 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2818 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2819 that can exceed INT_MAX. Check that EMACS_INT value is in range
2820 before assigning it to the (possibly-narrower) index.
2821 (match_limit): Don't assume that a fixnum can fit in 'int'.
2823 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2826 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2827 (Fvertical_motion): Don't wrap around LINES values that don't fit
2828 in 'int'. Instead, treat them as extreme values. This is good
2829 enough for windows, which can't have more than INT_MAX lines anyway.
2831 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2833 * Require libxml/parser.h to avoid compilation warning.
2835 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2837 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2838 since this reportedly can destroy thread storage.
2840 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2842 * syntax.c (find_defun_start): Update all cache variables if
2843 exiting early (Bug#9401).
2845 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2847 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2849 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2850 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2851 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2853 * term.c (tty_append_glyph): New function.
2854 (produce_stretch_glyph): Static function and its prototype deleted.
2856 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2859 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2861 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2862 when checking :margin (Bug#9390).
2863 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2864 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2865 so that the name doesn't mislead. All uses changed.
2867 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2869 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2872 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2874 * xdisp.c (move_it_to): Don't bail out early when reaching
2875 position beyond to_charpos, if we are scanning backwards.
2876 (move_it_vertically_backward): When DY == 0, make sure we get to
2877 the first character in the line after the newline.
2879 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2881 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2882 (ccl_driver): Do not generate an out-of-range pointer.
2883 (Fccl_execute_on_string): Remove unnecessary check for
2884 integer overflow, noted by Stefan Monnier in
2885 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2886 Remove a FIXME that didn't need fixing.
2887 Simplify the newly-introduced buffer reallocation code.
2889 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2891 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2893 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2895 Integer and memory overflow issues (Bug#9196).
2897 * doc.c (get_doc_string): Rework so that
2898 get_doc_string_buffer_size is the actual buffer size, rather than
2899 being 1 less than the actual buffer size; this makes xpalloc more
2902 * image.c (x_allocate_bitmap_record, cache_image):
2903 * xselect.c (Fx_register_dnd_atom):
2904 Simplify previous changes by using xpalloc.
2906 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2907 since either will do and ptrdiff_t is convenient with xpalloc.
2909 * charset.c (charset_table_size)
2910 (struct charset_sort_data.priority): Now ptrdiff_t.
2911 (charset_compare): Don't overflow if priorities differ greatly.
2912 (Fsort_charsets): Don't assume list length fits in int.
2913 Check for size-calculation overflow when allocating sort data.
2914 (syms_of_charset): Allocate an initial charset table that is
2915 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2917 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2919 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2920 The actual value is always <= INT_MAX, and leaving it unsigned made
2921 overflow checking harder.
2923 * dispextern.h (struct glyph_matrix.rows_allocated)
2924 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2925 with xpalloc. The values are still always <= INT_MAX.
2927 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2929 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2930 (SAFE_NALLOCA): New macro.
2932 * region-cache.c (struct boundary.pos, find_cache_boundary)
2933 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2934 (set_cache_region, invalidate_region_cache)
2935 (revalidate_region_cache, know_region_cache, region_cache_forward)
2936 (region_cache_backward, pp_cache):
2937 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2938 so that ptrdiff_t * can be passed to xpalloc.
2939 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2940 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2941 (pp_cache): Don't assume cache_len fits in int.
2942 * region-cache.h: Adjust extern decls to match.
2944 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2945 EMACS_INT, since either will do, for xpalloc.
2947 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2948 (xnmalloc, xnrealloc, xpalloc): New functions.
2950 * bidi.c (bidi_shelve_header_size): New constant.
2951 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2952 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2954 * bidi.c (bidi_cache_shrink):
2955 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2957 Don't update size of array until after memory allocation succeeds,
2958 because xmalloc/xrealloc may not return.
2959 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2960 now that we have proper integer overflow checking.
2961 (record_overlay_string, overlay_strings): Catch overflows when
2962 calculating size of overlay_str_buf.
2964 * callproc.c (Fcall_process): Check for size overflow when
2965 calculating size of args2.
2966 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2967 Normally we prefer signed values, but sticking with ptrdiff_t would
2968 require adding more-complicated checks.
2970 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2971 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2972 Redo buffer-overflow calculations to avoid integer overflow.
2973 Add a FIXME comment where memory seems to be over-allocated.
2975 * character.c (Fstring): Check for size-calculation overflow.
2977 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2978 unnecessary integer overflow. Check for size overflow.
2979 (encode_coding_object): Don't update size until xmalloc succeeds.
2981 * composite.c (get_composition_id): Check for overflow in glyph
2982 length calculations.
2984 Integer and memory overflow fixes for display code.
2985 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2986 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2987 (scrolling_window): Check for overflow in size calculations.
2988 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2989 Don't assume glyph table len fits in int.
2990 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2991 (row_table_size): Now ptrdiff_t, not int.
2992 (scrolling_window): Avoid overflow in size calculations.
2993 Don't update size until allocation succeeds.
2994 * fns.c (concat): Check for overflow in size calculations.
2995 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2996 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2997 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2999 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3000 (get_doc_string): Check for size calculation overflow.
3001 Don't update size until allocation succeeds.
3002 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3003 EMACS_INT, where ptrdiff_t will do.
3004 (Fsubstitute_command_keys): Check for string overflow.
3006 * editfns.c (set_time_zone_rule): Don't assume environment length
3008 (message_length): Now ptrdiff_t, not int.
3009 (Fmessage_box): Don't update size until allocation succeeds.
3010 Don't assume message length fits in int.
3011 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3013 * emacs.c (main): Do not reallocate argv, since there is a null at
3014 the end that can be overwritten, and this way there's no need to
3015 worry about size-calculation overflow.
3016 (sort_args): Check for size-calculation overflow.
3018 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3020 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3022 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3023 (x_set_scroll_bar_width, x_figure_window_size):
3024 Check for integer overflow.
3025 (x_set_alpha): Do not assume XINT fits in int.
3027 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3028 This is for the members text_lines, text_cols, total_lines, total_cols,
3029 where the system imposes an 'int' limit.
3031 * fringe.c (Fdefine_fringe_bitmap):
3032 Don't update size until alloc works.
3034 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3035 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3037 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3038 Check for size-calculation overflow.
3039 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3040 do, as we prefer signed integers.
3041 (id_to_widget.max_size, id_to_widget.used)
3042 (xg_store_widget_in_map, xg_remove_widget_from_map)
3043 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3044 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3045 Use and return ptrdiff_t, not int.
3046 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3047 * gtkutil.h: Change prototypes to match the above.
3049 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3050 are duplicate now that they've been promoted to lisp.h.
3051 (x_allocate_bitmap_record, x_alloc_image_color)
3052 (make_image_cache, cache_image, xpm_load):
3053 Don't update size until alloc is done.
3054 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3056 Check for size calculation overflow.
3057 (ct_colors_allocated_max): New constant.
3058 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3061 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3062 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3063 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3064 Use ptrdiff_t, not int, to count maps.
3065 (read_char_minibuf_menu_prompt): Check for overflow in size
3066 calculations. Don't update size until allocation succeeds.
3067 Redo calculations to avoid overflow.
3068 * keyboard.h: Change prototypes to match the above.
3070 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3072 (current_minor_maps): Check for size calculation overflow.
3073 * keymap.h: Change prototypes to match the above.
3075 * lread.c (read1, init_obarray): Don't update size until alloc done.
3077 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3078 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3080 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3081 Now ptrdiff_t, not int.
3082 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3083 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3085 * process.c (Fnetwork_interface_list): Check for overflow
3086 in size calculation.
3088 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3090 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3091 overflow. Don't bother calling xmalloc when xrealloc will do.
3093 * search.c (Freplace_match): Check for size calculation overflow.
3094 (Fset_match_data): Don't assume list lengths fit in 'int'.
3096 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3097 for command line length. Do not attempt to address one before the
3098 beginning of an array, as that's not portable.
3100 * term.c (max_frame_lines): Remove; unused.
3101 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3103 (encode_terminal_code, calculate_costs): Check for size
3104 calculation overflow.
3105 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3106 table lengths and related sizes. Don't update size until alloc
3107 done. Redo calculations to avoid overflow.
3108 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3110 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3111 subtracting pointers.
3112 (gobble_line): Check for overflow more carefully. Don't update size
3115 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3116 Don't update size until alloc done.
3117 Redo size calculations to avoid overflow.
3118 Check for size calculation overflow.
3119 (main) [DEBUG]: Fix typo in invoking tparam1.
3121 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3122 Use ptrdiff_t, not int, for sizes.
3123 (store_mode_line_noprop_char): Don't update size until alloc done.
3125 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3126 Use ptrdiff_t, not int, for sizes.
3127 (Finternal_make_lisp_face, cache_face):
3128 Check for size calculation overflow.
3129 (cache_face): Treat size calculation overflows as if they were
3130 memory exhaustion (the usual treatment), rather than aborting.
3132 * xfns.c (x_encode_text, x_set_name_internal)
3133 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3134 sizes, since they can exceed INT_MAX in size. Check for size
3135 calculation overflow.
3137 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3138 (xg_select): Check for size calculation overflow.
3139 Don't update size until alloc done.
3141 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3142 as sprintf is limited to int lengths.
3144 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3145 (X_LONG_MIN): New macros.
3146 Use them to make the following changes clearer.
3147 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3148 This change doesn't affect the value now, but it may help remind
3149 future maintainers not to raise the value too much later.
3150 (SELECTION_QUANTUM): Remove, replacing with ...
3151 (selection_quantum): ... new function, which avoids overflow.
3153 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3154 assumption that selection length fits in 'int'.
3155 (x_reply_selection_request, x_handle_selection_request)
3156 (x_get_window_property, receive_incremental_selection)
3157 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3158 (lisp_data_to_selection_data, clean_local_selection_data):
3159 Use ptrdiff_t, not int, to record length of selection.
3160 (x_reply_selection_request, x_get_window_property)
3161 (receive_incremental_selection, x_property_data_to_lisp):
3162 Redo calculations to avoid overflow.
3163 (x_reply_selection_request): When sending hint, ceiling it at
3164 X_LONG_MAX rather than relying on wraparound overflow to send
3166 (x_get_window_property, receive_incremental_selection)
3167 (lisp_data_to_selection_data, x_property_data_to_lisp):
3168 Check for size-calculation overflow.
3169 (x_get_window_property, receive_incremental_selection)
3170 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3171 Don't store size until memory allocation succeeds.
3172 (x_get_window_property): Plug memory leak on memory exhaustion.
3173 Don't double-block input; malloc is safe here. Don't assume 2**34
3174 - 4 fits in unsigned long. Add an xassert to check
3175 XGetWindowProperty overflow. Be more careful about overflow
3176 calculations, and distinguish size from memory overflow better.
3177 (receive_incremental_selection): When tracing, don't assume
3178 unsigned int is less than INT_MAX.
3179 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3180 harmful) conversions of unsigned short to int.
3181 (lisp_data_to_selection_data): Don't assume that integers
3182 in the range -65535 through -1 fit in an X unsigned short.
3183 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3184 result parameters unless successful. Rely on cons_to_unsigned
3185 to report problems with elements; the old code wasn't right anyway.
3186 (x_check_property_data): Check for int overflow; we cannot use
3187 a wider type due to X limits.
3188 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3190 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3192 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3193 (x_term_init): Check for size calculation overflow.
3194 (x_color_cells): Don't store size until memory allocation succeeds.
3195 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3196 Don't assume alloca size is less than MAX_ALLOCA.
3197 (x_term_init): Don't assume length fits in int (sprintf is limited
3200 Use ptrdiff_t for composition IDs.
3201 * character.c (lisp_string_width):
3202 * composite.c (composition_table_size, n_compositions)
3203 (get_composition_id, composition_gstring_from_id):
3204 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3205 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3206 * window.c (Frecenter):
3207 Use ptrdiff_t, not int, for composition IDs.
3208 * composite.c (get_composition_id): Check for integer overflow.
3209 * composite.h: Adjust prototypes to match the above changes.
3211 Use ptrdiff_t for hash table indexes.
3212 * category.c (hash_get_category_set):
3213 * ccl.c (ccl_driver):
3214 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3215 * coding.c (coding_system_charset_list, detect_coding_system):
3216 * coding.h (struct coding_system.id):
3217 * composite.c (get_composition_id, gstring_lookup_cache):
3218 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3219 * image.c (xpm_get_color_table_h):
3220 * lisp.h (hash_lookup, hash_put):
3221 * minibuf.c (Ftest_completion):
3222 Use ptrdiff_t for hash table indexes, not int (which is too
3223 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3224 32-bit --with-wide-int hosts).
3226 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3227 Add a FIXME comment about memory leaks.
3228 (syms_of_charset): Don't assume xmalloc returns.
3230 Don't assume that stated character widths fit in int.
3231 * character.c (Fchar_width, c_string_width, lisp_string_width):
3232 * character.h (CHAR_WIDTH):
3233 * indent.c (MULTIBYTE_BYTES_WIDTH):
3234 Use sanitize_char_width to avoid undefined and/or bad behavior
3235 with outlandish widths.
3236 * character.h (sanitize_tab_width): Rename from sanitize_width,
3237 now that we have two such functions. All uses changed.
3238 (sanitize_char_width): New inline function.
3240 Don't assume that tab-width fits in int.
3241 * character.h (sanitize_width): New inline function.
3242 (SANE_TAB_WIDTH): New macro.
3243 (ASCII_CHAR_WIDTH): Use it.
3244 * indent.c (sane_tab_width): Remove. All uses replaced by
3245 SANE_TAB_WIDTH (current_buffer).
3246 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3248 * fileio.c: Integer overflow issues with file modes.
3249 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3251 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3252 Remove unreachable code.
3253 (read_hex, load_charset_map_from_file): Check for integer overflow.
3255 * xterm.c: Don't go over XClientMessageEvent limit.
3256 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3257 (x_send_scroll_bar_event): Likewise. Check that the size does not
3258 exceed limits imposed by XClientMessageEvent, as well as the usual
3259 ptrdiff_t and size_t limits.
3261 * keyboard.c: Overflow, signedness and related fixes.
3262 (make_lispy_movement): Use same integer type in forward decl
3263 that is used in the definition.
3264 (read_key_sequence, keyremap_step):
3265 Change bufsize argument back to int, undoing my 2011-03-30 change.
3266 We prefer signed types, and int is wide enough here.
3267 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3268 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3269 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3270 length, not size_t. Use ptrdiff_t for index, not int.
3271 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3272 possibility of integer overflow.
3274 Overflow, signedness and related fixes for images.
3276 * dispextern.h (struct it.stack[0].u.image.image_id)
3277 (struct_it.image_id, struct image.id, struct image_cache.size)
3278 (struct image_cache.used, struct image_cache.ref_count):
3279 * gtkutil.c (update_frame_tool_bar):
3280 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3281 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3282 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3283 * nsmenu.m (update_frame_tool_bar):
3284 * xdisp.c (calc_pixel_width_or_height):
3285 * xfns.c (image_cache_refcount):
3286 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3287 on typical 64-bit hosts.
3289 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3290 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3291 Omit unnecessary casts to int.
3292 (parse_image_spec): Check that integers fall into 'int' range
3293 when the callers expect that.
3294 (image_ascent): Redo ascent calculation to avoid int overflow.
3295 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3296 (lookup_image): Remove unnecessary tests.
3297 (xbm_image_p): Locals are now of int, not EMACS_INT,
3298 since parse_image_check makes sure they fit into int.
3299 (png_load, gif_load, svg_load_image):
3300 Prefer int to unsigned where either will do.
3301 (tiff_handler): New function, combining the cores of the
3302 old tiff_error_handler and tiff_warning_handler.
3303 This function is rewritten to use vsnprintf and thereby avoid
3304 stack buffer overflows. It uses only the features of vsnprintf
3305 that are common to both POSIX and native Microsoft.
3306 (tiff_error_handler, tiff_warning_handler): Use it.
3307 (tiff_load, gif_load, imagemagick_load_image):
3308 Don't assume :index value fits in 'int'.
3309 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3310 (imagemagick_load_image): Check that crop parameters fit into
3311 the integer types that MagickCropImage accepts. Don't assume
3312 Vimagemagick_render_type has a nonnegative value. Don't assume
3313 size_t fits in 'long'.
3314 (gs_load): Use printmax_t to print the widest integers possible.
3315 Check for integer overflow when computing image height and width.
3317 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3319 * xdisp.c (redisplay_window): Don't force window start if point
3320 will be invisible in the resulting window. (Bug#9324)
3322 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3324 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3325 the display spec is of the form `(space ...)'.
3326 (handle_display_spec): Return the value returned by
3327 handle_single_display_spec, not just 1 or zero.
3328 (handle_single_display_spec): If the display spec is of the form
3329 `(space ...)', and specifies display in the text area, return 2
3331 (try_cursor_movement): Check for the need to scroll more
3332 accurately, and prefer exact match for point under bidi.
3333 Don't advance `row' beyond the last row of the window.
3335 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3336 into disp_prop; all users changed.
3338 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3339 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3340 for the text covered by the display property.
3342 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3344 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3345 Change return value to nil.
3346 (Frecord_buffer): Delete unused function.
3348 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3350 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3351 buffers, return left-to-right.
3352 (set_cursor_from_row): Consider candidate row a win if its glyph
3353 represents a newline and point is on that newline. Fixes cursor
3354 positioning on the newline at EOL of R2L text within L2R
3355 paragraph, and vice versa.
3356 (try_cursor_movement): Check continued rows, in addition to
3357 continuation rows. Fixes unwarranted scroll when point enters a
3358 continued line of R2L text within an L2R paragraph, or vice versa.
3359 (cursor_row_p): Consider the case of point being equal to
3360 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3361 from the end of a short line to the beginning of a continued line
3362 of R2L text within L2R paragraph.
3363 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3364 composed characters.
3366 * bidi.c (bidi_check_type): Use xassert.
3367 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3370 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3372 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3375 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3377 * nsfont.m (ns_otf_to_script): Fix typo.
3379 2011-08-22 Kenichi Handa <handa@m17n.org>
3381 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3382 extra slot even if the purpose is char-code-property-table.
3384 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3386 * xdisp.c (redisplay_window): When computing centering_position,
3387 account for the height of the header line. (Bug#8874)
3389 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3390 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3391 candidate is selected by the mouse, and that candidate has a
3392 composed character under the mouse.
3394 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3395 coordinates reported by pos-visible-in-window-p for a composed
3396 character in column zero.
3398 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3400 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3402 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3404 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3405 consider it a hit if to_charpos is anywhere in the range of the
3406 composed buffer positions.
3408 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3410 * image.c (gif_load): Don't assume that each subimage has the same
3411 dimensions as the base image. Handle disposal method that is
3412 "undefined" by the gif spec (Bug#9335).
3414 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3416 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3417 (Fcondition_case): Document `debug' symbol in error handler.
3419 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3421 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3422 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3423 from an Org mode buffer to a Speedbar frame.
3425 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3426 a composition, take its buffer position from IT->cmp_it.charpos.
3427 Fixes cursor positioning at the beginning of a line that begins
3428 with a composed character.
3430 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3432 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3433 character bidirectional type, use STRONG_L instead. Fixes crashes
3434 in a buffer produced by `describe-categories'.
3436 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3437 members before the level stack, so they would be saved and
3438 restored when copying iterator state. Fixes incorrect reordering
3439 around TABs covered by display properties.
3441 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3443 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3445 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3447 * eval.c (internal_condition_case, internal_condition_case_1)
3448 (internal_condition_case_2, internal_condition_case_n):
3449 Remove unnecessary aborts (Bug#9081).
3451 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3453 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3454 has no `load' handler, try opening the file locally. (Bug#9311)
3456 2011-08-16 Ken Brown <kbrown@cornell.edu>
3458 * gmalloc.c: Expand comment.
3460 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3462 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3463 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3465 2011-08-16 Ken Brown <kbrown@cornell.edu>
3467 Fix memory allocation problems in Cygwin build (Bug#9273).
3469 * unexcw.c ( __malloc_initialized): Declare external variable.
3470 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3472 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3474 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3476 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3478 [CYGWIN] (special_realloc): New function.
3479 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3480 requests to realloc storage in the static heap.
3482 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3484 * bidi.c (bidi_initialize): Remove unused local.
3486 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3489 * biditype.h: Remove file.
3490 * makefile.w32-in ($(BLD)/bidi.$(O)):
3491 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3493 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3495 * chartab.c: Improve commentary for the uniprop_table API.
3497 * bidi.c (bidi_paragraph_init): Support zero value of
3498 bidi_ignore_explicit_marks_for_paragraph_level.
3499 (bidi_initialize): Use uniprop_table instead of including
3500 biditype.h and bidimirror.h.
3502 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3503 coordinates of the iterator when restoring from ppos_it.
3506 2011-08-14 Kenichi Handa <handa@m17n.org>
3508 * process.c (create_process): Call setup_process_coding_systems
3509 after the pid of the process is set to -1 (Bug#8162).
3511 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3513 * xdisp.c (move_it_in_display_line_to): Don't invoke
3514 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3515 ppos_it. Fixes vertical cursor motion when line beginning is
3516 covered by an image. (Bug#9296)
3518 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3520 * nsterm.h (ns_run_ascript): Declare.
3521 (NSAPP_DATA2_RUNASSCRIPT): Define.
3523 * nsfns.m (as_script, as_result, as_status): New static variables.
3524 (ns_run_ascript): New function.
3525 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3526 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3527 the event loop. Get status from as_status (Bug#7276).
3529 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3530 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3531 the event loop (Bug#7276).
3533 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3535 * gnutls.c (QCgnutls_bootprop_priority)
3536 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3537 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3538 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3539 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3540 (QCgnutls_bootprop_verify_hostname_error)
3541 (QCgnutls_bootprop_callbacks_verify): Rename from
3542 Qgnutls_bootprop_..., all uses changed.
3544 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3547 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3549 * xfaces.c (Qframe_set_background_mode): Now static.
3550 * dispextern.h (Qframe_set_background_mode): Remove decl.
3552 * process.c (Fnetwork_interface_info): Declare local only if needed.
3554 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3556 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3557 (Fnetwork_interface_list): Allocate in increments of bytes instead
3558 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3559 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3561 (struct ifflag_def): notrailers is smart on OSX.
3562 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3563 Get hardware address with getifaddrs if available.
3565 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3567 * xdisp.c (iterate_out_of_display_property): xassert that
3568 IT->position is set to within IT->object's boundaries. Break from
3569 the loop as soon as EOB is reached; avoids infloops in redisplay
3570 when IT->position is set up wrongly due to some bug.
3571 Set IT->current to match the bidi iterator unconditionally.
3572 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3573 entry. Force push_it to save on the stack the current
3574 buffer/string position, to be restored by pop_it. Fix flags in
3575 the iterator structure wrt the object coming from a display
3576 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3577 properties. (Bug#9284)
3579 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3581 * fontset.c (fontset_get_font_group): Add proper type checks.
3584 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3586 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3587 and LC_VERSION_MIN_MACOSX.
3588 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3589 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3591 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3593 * xdisp.c (forward_to_next_line_start): Allow to use the
3594 no-display-properties-and-no-overlays under bidi display.
3595 Set disp_pos in the bidi iterator to avoid searches for display
3596 properties and overlays.
3598 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3600 * editfns.c (Fset_time_zone_rule): Document relationship with the
3603 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3604 the font entity extracted from the cache (Bug#8109).
3606 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3608 * composite.c (autocmp_chars): Don't reset point. That is done by
3609 restore_point_unwind (Bug#5984).
3611 2011-08-07 Juri Linkov <juri@jurta.org>
3613 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3614 to show the arg `TIME' instead of `TIMEVAL'.
3616 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3618 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3619 display property strides EOL and includes a newline, as in
3620 longlines-mode. (Bug#9254)
3621 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3622 word-wrap under bidirectional display. (Bug#9224)
3624 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3625 is non-zero, even if the data buffer is NULL. Fixes a crash in
3626 vertical-motion with longlines-mode. (Bug#9254)
3628 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3630 * bidi.c <bidi_cache_total_alloc>: Now static.
3631 (bidi_initialize): Initialize bidi_cache_total_alloc.
3633 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3636 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3637 amount allocated this far in `bidi_cache_total_alloc'.
3638 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3639 non-zero, only free the data buffer without restoring the cache
3640 contents. All callers changed.
3642 * dispextern.h (bidi_unshelve_cache): Update prototype.
3644 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3645 (move_it_in_display_line, move_it_to)
3646 (move_it_vertically_backward, move_it_by_lines): Replace the call
3647 to xfree to an equivalent call to bidi_unshelve_cache.
3648 (move_it_in_display_line_to): Fix logic of returning
3649 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3651 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3653 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3654 came from a string character with a `cursor' property. (Bug#9229)
3656 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3658 * Makefile.in (LIB_PTHREAD): New variable.
3659 (LIBES): Add LIB_PTHREAD (Bug#9216).
3661 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3662 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3664 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3666 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3668 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3670 * xterm.c (x_find_topmost_parent): New function.
3671 (x_set_frame_alpha): Find topmost parent window with
3672 x_find_topmost_parent and set the property there also (bug#9181).
3673 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3675 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3677 * callproc.c (Fcall_process): Avoid vfork clobbering
3678 the local vars buffer, coding_systems, current_dir.
3680 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3682 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3684 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3686 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3687 so that it is not optimized away.
3689 * xdisp.c (compute_display_string_pos): Remove unused local.
3691 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3693 Fix slow cursor motion and scrolling in large buffers with
3694 selective display, like Org Mode buffers. (Bug#9218)
3696 * dispextern.h (struct bidi_it): New member disp_prop_p.
3698 * xdisp.c: Remove one-slot cache of display string positions.
3699 (compute_display_string_pos): Accept an additional argument
3700 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3701 for a display string or property. If found, set DISP_PROP_P
3704 * bidi.c (bidi_fetch_char): Accept an additional argument
3705 DISP_PROP_P, and pass it to compute_display_string_pos.
3706 Only handle text covered by a display string if DISP_PROP_P is returned
3707 non-zero. All callers of bidi_fetch_char changed.
3709 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3711 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3713 2010-12-03 Don March <don@ohspite.net>
3715 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3716 last character M-[char] is translated to ESC [char] (bug#7541).
3718 2011-08-02 Kenichi Handa <handa@m17n.org>
3720 * lisp.h (uniprop_table): Extern it.
3722 * chartab.c (uniprop_table): Make it non-static.
3724 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3726 * xdisp.c (forward_to_next_line_start): Accept additional argument
3727 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3729 (reseat_at_next_visible_line_start): Use the bidi iterator state
3730 returned by forward_to_next_line_start to restore the state of
3731 it->bidi_it after backing up to previous newline. (Bug#9212)
3733 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3735 * regex.c (re_comp): Protoize.
3736 (re_exec): Fix return type.
3737 (regexec): Fix type of `ret'. (Bug#9203)
3739 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3741 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3742 This is needed if max-image-size is a floating-point number.
3744 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3746 * print.c (print_object): Print empty symbol as ##.
3748 * lread.c (read1): Read ## as empty symbol.
3750 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3752 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3753 setting frame foreground color (Bug#9175).
3754 (x_set_background_color): Likewise.
3756 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3757 contents (Bug#9176).
3758 (EmacsTooltip -init): Remove bezels and add shadows to
3761 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3762 or scroll bar (Bug#8470).
3764 * nsfont.m (nsfont_open): Remove assignment to voffset and
3765 unnecessary vars hshink, expand, hd, full_height, min_height.
3766 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3768 * nsterm.h (nsfont_info): Remove voffset field.
3770 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3772 Implement strike-through and overline on NextStep (Bug#8863).
3774 * nsfont.m (nsfont_open): Use underline position provided by font,
3775 instead of hard-coded value of 2.
3776 (nsfont_draw): Call ns_draw_text_decoration instead.
3778 * nsterm.h: Add declaration for ns_draw_text_decoration.
3780 * nsterm.m (ns_draw_text_decoration): New function for drawing
3781 underline, overline, and strike-through.
3782 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3783 ns_draw_text_decoration. Change treatment of cursor drawing to
3784 accommodate underlining, etc.
3786 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3788 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3791 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3793 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3794 Without this fix, if a signal arrives just after memory fills up,
3795 'malloc' might be invoked reentrantly.
3797 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3798 In other words, assume that every image size is allowed, on non-X
3799 hosts. This assumption is probably wrong, but it lets Emacs compile.
3801 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3803 * regex.c (re_iswctype): Convert return values to boolean.
3805 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3807 * xdisp.c (compute_display_string_pos): Don't use cached display
3808 string position if the buffer had its restriction changed.
3811 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3813 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3815 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3817 Integer signedness and overflow and related fixes. (Bug#9079)
3819 * bidi.c: Integer size and overflow fixes.
3820 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3821 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3822 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3823 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3824 (bidi_find_other_level_edge):
3825 Use ptrdiff_t instead of EMACS_INT where either will do.
3826 This works better on 32-bit hosts configured --with-wide-int.
3827 (bidi_cache_ensure_space): Check for size-calculation overflow.
3828 Use % rather than repeated addition, for better worst-case speed.
3829 Don't set bidi_cache_size until after xrealloc returns, because it
3831 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3832 (bidi_cache_ensure_space): Also check that the bidi cache size
3833 does not exceed that of the largest Lisp string or buffer. See Eli
3834 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3836 * alloc.c (__malloc_size_t): Remove.
3837 All uses replaced by size_t. See Andreas Schwab's note
3838 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3840 * image.c: Improve checking for integer overflow.
3841 (check_image_size): Assume that f is nonnull, since
3842 it is always nonnull in practice. This is one less thing to
3843 worry about when checking for integer overflow later.
3844 (x_check_image_size): New function, which checks for integer
3845 overflow issues inside X.
3846 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3847 This removes the need for a memory_full check.
3848 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3849 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3850 (xbm_read_bitmap_data): Change locals back to 'int', since
3851 their values must fit in 'int'.
3852 (xpm_load_image, png_load, tiff_load):
3853 Invoke x_create_x_image_and_pixmap earlier,
3854 to avoid much needless work if the image is too large.
3855 (tiff_load): Treat overly large images as if
3856 x_create_x_image_and_pixmap failed, not as malloc failures.
3857 (gs_load): Use x_check_image_size.
3859 * gtkutil.c: Omit integer casts.
3860 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3861 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3863 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3865 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3866 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3867 would wrongly return t on a 64-bit host.
3869 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3870 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3871 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3872 and therefore cause GCC to emit a bogus diagnostic in some cases.
3874 * image.c: Integer signedness and overflow and related fixes.
3875 This is not an exhaustive set of fixes, but it's time to
3876 record what I've got.
3877 (lookup_pixel_color, check_image_size): Remove redundant decls.
3878 (check_image_size): Don't assume that arbitrary EMACS_INT values
3879 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3880 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3881 (tiff_load, imagemagick_load_image):
3882 Check for overflow in size calculations.
3883 (x_create_x_image_and_pixmap): Remove unnecessary test for
3884 xmalloc returning NULL; that can't happen.
3885 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3886 (xpm_color_bucket): Use better integer hashing function.
3887 (xpm_cache_color): Don't possibly over-allocate memory.
3888 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3889 (gif_memory_source):
3890 Use ptrdiff_t, not int or size_t, to record sizes.
3891 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3892 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3893 either works, as we prefer signed integers.
3894 (tiff_read_from_memory, tiff_write_from_memory):
3895 Return tsize_t, not size_t, since that's what the TIFF API wants.
3896 (tiff_read_from_memory): Don't fail simply because the read would
3897 go past EOF; instead, return a short read.
3898 (tiff_load): Omit no-longer-needed casts.
3899 (Fimagemagick_types): Don't assume size fits into 'int'.
3901 Improve hashing quality when configured --with-wide-int.
3902 * fns.c (hash_string): New function, taken from sxhash_string.
3903 Do not discard information about ASCII character case; this
3904 discarding is no longer needed.
3905 (sxhash-string): Use it. Change sig to match it. Caller changed.
3906 * lisp.h: Declare it.
3907 * lread.c (hash_string): Remove, since we now use fns.c's version.
3908 The fns.c version returns a wider integer if --with-wide-int is
3909 specified, so this should help the quality of the hashing a bit.
3911 * emacs.c: Integer overflow minor fix.
3912 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3913 Define only if GNU_LINUX.
3914 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3916 * dispnew.c: Integer signedness and overflow fixes.
3917 Remove unnecessary forward decls, that were a maintenance hassle.
3918 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3920 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3921 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3922 (prepare_desired_row, line_draw_cost):
3923 Use int, not unsigned, where either works.
3924 (save_current_matrix, restore_current_matrix):
3925 Use ptrdiff_t, not size_t, where either works.
3926 (init_display): Check for overflow more accurately, and without
3927 relying on undefined behavior.
3929 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3930 Remove, replacing with the new symbols in lisp.h. All uses changed.
3931 * fileio.c (make_temp_name):
3932 * filelock.c (lock_file_1, lock_file):
3933 * xdisp.c (message_dolog):
3934 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3935 Use pMd etc. instead.
3936 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3937 replacing the pWIDE etc. symbols removed from editfns.c.
3939 * keyboard.h (num_input_events): Now uintmax_t.
3940 This is (very slightly) less likely to mess up due to wraparound.
3943 * buffer.c: Integer signedness fixes.
3944 (alloc_buffer_text, enlarge_buffer_text):
3945 Use ptrdiff_t rather than size_t when either will do, as we prefer
3948 * alloc.c: Integer signedness and overflow fixes.
3949 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3950 (__malloc_size_t): Default to size_t, not to int.
3951 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3952 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3953 Prefer ptrdiff_t to size_t when either would do, as we prefer
3955 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3956 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3957 Now const. Initialize with values that are in range even if char
3959 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3960 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3961 These functions do the right thing with sizes > 2**32.
3962 (check_depth): Now ptrdiff_t, not int.
3963 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3964 Adjust to new way of storing sizes. Check for size overflow bugs
3966 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3967 slightly wrong anyway, as it missed one instance of
3968 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3969 (refill_memory_reserve): Omit needless cast to size_t.
3970 (mark_object_loop_halt): Mark as externally visible.
3972 * xselect.c: Integer signedness and overflow fixes.
3973 (Fx_register_dnd_atom, x_handle_dnd_message):
3974 Use ptrdiff_t, not size_t, since we prefer signed.
3975 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3976 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3977 x_dnd_atoms_size and x_dnd_atoms_length.
3979 * doprnt.c: Prefer signed to unsigned when either works.
3981 * doprnt.c (doprnt):
3983 * xdisp.c (vmessage):
3984 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3985 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3986 prefer signed arithmetic to avoid comparison confusion.
3987 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3988 but is a bit tricky.
3990 Assume freestanding C89 headers, string.h, stdlib.h.
3991 * data.c, doprnt.c, floatfns.c, print.c:
3992 Include float.h unconditionally.
3993 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3994 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3995 * regex.c: Likewise for stddef.h, string.h.
3996 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3997 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3998 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3999 (STDC_HEADERS): Remove obsolete defines.
4000 * sysdep.c: Include limits.h unconditionally.
4002 Assume support for memcmp, memcpy, memmove, memset.
4003 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4004 * regex.c (memcmp, memcpy):
4005 Remove; we assume C89 now.
4007 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4008 (__malloc_safe_bcopy): Remove; no longer needed.
4010 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4011 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4012 well either way, and we prefer signed to unsigned.
4014 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4016 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4017 closes the connection while we're reading (bug#9182).
4019 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4021 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4022 are specified (Bug#9168).
4024 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4026 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4027 Found by GCC static checking and --with-wide-int on a 32-bit host.
4029 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4031 * xdisp.c (compute_display_string_pos): Fix logic of caching
4032 previous display string position. Initialize cached_prev_pos to
4033 -1. Fixes slow-down at the beginning of a buffer.
4035 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4037 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4038 for attrs[LFACE_FONTSET_INDEX].
4040 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4042 * xml.c (parse_region): Remove unused local
4043 that was recently introduced.
4045 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4047 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4048 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4050 * xdisp.c (move_it_in_display_line_to): Record the best matching
4051 position for TO_CHARPOS while scanning the line, and restore it on
4052 exit if none of the characters scanned was an exact match.
4053 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4054 when exact match is impossible due to invisible text, and the
4055 lines are truncated.
4057 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4059 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4062 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4064 Fix a significant slow-down of cursor motion with C-n, C-p,
4065 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4066 auto-repeat under bidi redisplay in fontified buffers.
4067 * xdisp.c (compute_stop_pos_backwards): New function.
4068 (next_element_from_buffer): Call compute_stop_pos_backwards to
4069 find a suitable prev_stop when we find ourselves before
4071 (reseat): Don't look for prev_stop, as that could mean a very long
4073 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4074 <cached_disp_overlay_modiff>: Cache for last found display string
4076 (compute_display_string_pos): Return the cached position if asked
4077 about the same buffer in the same area of character positions, and
4078 the buffer wasn't changed since the time the display string
4079 position was cached.
4081 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4083 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4084 is an integer, which is important for empty lines. (Bug#9149)
4086 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4088 * frame.c (Fmodify_frame_parameters): In tty case, update the
4089 default face if necessary (Bug#4238).
4091 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4093 * editfns.c (Fstring_to_char): No need to explain what a character
4094 is in the docstring (Bug#6576).
4096 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4098 * xml.c (parse_region): Make sure we always return a tree.
4100 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4102 * xml.c (parse_region): If a document contains only comments,
4105 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4107 * xml.c (make_dom): Return comments, too.
4109 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4112 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4113 and the surrounding thread.
4114 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4115 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4116 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4118 * s/openbsd.h (BROKEN_SIGIO): Define.
4119 * unexelf.c (unexec) [__OpenBSD__]:
4120 Don't update the .mdebug section of the Alpha COFF symbol table.
4122 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4124 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4127 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4129 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4130 This fixes some race conditions on the permissions of any newly
4133 * alloc.c (valid_pointer_p): Use pipe, not open.
4134 This fixes some permissions issues when debugging.
4136 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4137 If fchown fails to set both uid and gid, try to set just gid,
4138 as that is sometimes allowed. Adjust the file's mode to eliminate
4139 setuid or setgid bits that are inappropriate if fchown fails.
4141 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4143 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4144 to compare Lisp_Objects.
4145 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4146 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4147 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4149 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4151 * lread.c (read_integer): Unread even EOF character.
4152 (read1): Likewise. Properly record start position of symbol.
4154 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4155 symbol character follows.
4157 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4159 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4160 This works around a problem with the previous change to Fcopy_file.
4161 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4162 and without this change, GCC might complain about discarding
4163 fchown's return value.
4165 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4167 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4169 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4171 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4173 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4175 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4176 it's used from the C level.
4178 * process.c: Use the same condition for POLL_FOR_INPUT in both
4179 keyboard.c and process.c (bug#1858).
4181 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4183 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4184 (Fgnutls_boot): Use it.
4186 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4188 * doc.c (Fsubstitute_command_keys): Revert last change.
4190 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4192 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4193 quotes the next character, and doesn't affect other longer
4194 sequences (bug#8935).
4196 * lread.c (syms_of_lread): Clarify that is isn't only
4197 `eval-buffer' and `eval-defun' that's affected by
4198 `lexical-binding' (bug#8460).
4200 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4202 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4203 bidi redisplay when a line includes both an image and is truncated.
4205 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4207 Fix minor problems found by static checking.
4208 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4209 (elsz): Now a signed constant, not a size_t var. We prefer signed
4210 types to unsigned, to avoid integer comparison confusion. Without
4211 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4212 "cannot optimize loop, the loop counter may overflow", a symptom
4214 * indent.c (Fvertical_motion): Mark locals as initialized.
4215 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4217 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4219 * search.c (Fre_search_backward): Mention `case-fold-search' in
4220 all the re_search_* functions (bug#8138).
4222 * keyboard.c (Fopen_dribble_file): Document when the file is
4225 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4227 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4230 Support bidi reordering of display and overlay strings.
4231 * xdisp.c (compute_display_string_pos)
4232 (compute_display_string_end): Accept additional argument STRING.
4233 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4234 (reseat_to_string): Initialize bidi_it->string.s and
4235 bidi_it->string.schars.
4236 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4237 NULL (avoids a crash in bidi_paragraph_init).
4238 Initialize itb.string.lstring.
4239 (init_iterator): Call bidi_init_it only of a valid
4240 buffer position was specified. Initialize paragraph_embedding to
4242 (reseat_to_string): Initialize the bidi iterator.
4243 (display_string): If we need to ignore text properties of
4244 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4245 original value of -1 will not work with bidi.)
4246 (compute_display_string_pos): First arg is now struct
4247 `text_pos *'; all callers changed. Support display properties on
4249 (compute_display_string_end): Support display properties on Lisp
4251 (init_iterator, reseat_1, reseat_to_string): Initialize the
4252 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4253 when iterating on a string not from display properties).
4254 (compute_display_string_pos, compute_display_string_end):
4255 Fix calculation of the object to scan. Fixes an error when using
4257 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4258 base_level_stop; instead, set base_level_stop to BEGV.
4259 Fixes crashes in vertical-motion.
4260 (next_element_from_buffer): Improve commentary for when
4261 the iterator is before prev_stop.
4262 (init_iterator): Initialize bidi_p from the default value of
4263 bidi-display-reordering, not from buffer-local value. Use the
4264 buffer-local value only if initializing for buffer iteration.
4265 (handle_invisible_prop): Support invisible properties on strings
4266 that are being bidi-reordered.
4267 (set_iterator_to_next): Support bidi reordering of C strings and
4269 (next_element_from_string): Support bidi reordering of Lisp
4271 (handle_stop_backwards): Support Lisp strings as well.
4272 (display_string): Support display of R2L glyph rows.
4273 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4274 (init_iterator): Don't initialize it->bidi_p for strings
4276 (reseat_to_string): Initialize it->bidi_p for strings here.
4277 (next_element_from_string, next_element_from_c_string)
4278 (next_element_from_buffer): Add xassert's for correspondence
4279 between IT's object being iterated and it->bidi_it.string
4281 (face_before_or_after_it_pos): Support bidi iteration.
4282 (next_element_from_c_string): Handle the case of the first string
4283 character that is not the first one in the visual order.
4284 (get_visually_first_element): New function, refactored from common
4285 parts of next_element_from_buffer, next_element_from_string, and
4286 next_element_from_c_string.
4287 (tool_bar_lines_needed, redisplay_tool_bar)
4288 (display_menu_bar): Force left-to-right direction. Add a FIXME
4289 comment for making that be controlled by a user option.
4290 (push_it, pop_it): Save and restore the state of the
4291 bidi iterator. Save and restore the bidi_p flag.
4292 (pop_it): Iterate out of display property for string iteration as
4294 (iterate_out_of_display_property): Support iteration over strings.
4295 (handle_single_display_spec): Set up it->bidi_it for iteration
4296 over a display string, and call bidi_init_it.
4297 (handle_single_display_spec, next_overlay_string)
4298 (get_overlay_strings_1, push_display_prop): Set up the bidi
4299 iterator for displaying display or overlay strings.
4300 (forward_to_next_line_start): Don't use the shortcut if
4302 (back_to_previous_visible_line_start): If handle_display_prop
4303 pushed the iterator stack, restore the internal state of the bidi
4304 iterator by calling bidi_pop_it same number of times.
4305 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4306 and we are bidi-iterating, don't decrement the iterator position;
4307 instead, set the first_elt flag in the bidi iterator, to produce
4309 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4310 (push_display_prop): xassert that we are iterating a buffer.
4311 (push_it, pop_it): Save and restore paragraph_embedding member.
4312 (handle_single_display_spec, next_overlay_string)
4313 (get_overlay_strings_1, reseat_1, reseat_to_string)
4314 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4315 correctly. Don't assume unibyte strings are not bidi-reordered.
4316 (compute_display_string_pos)
4317 (compute_display_string_end): Fix handling the case of C string.
4318 (push_it, pop_it): Save and restore from_disp_prop_p.
4319 (handle_single_display_spec, push_display_prop): Set the
4320 from_disp_prop_p flag.
4321 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4322 (pop_it): Call iterate_out_of_display_property only if we are
4323 popping after iteration over a string that came from a display
4324 property. Fix a typo in popping stretch info. Add an assertion
4325 for verifying that the iterator position is in sync with the bidi
4327 (handle_single_display_spec, get_overlay_strings_1)
4328 (push_display_prop): Fix initialization of paragraph direction for
4329 string when that of the parent object is not yet determined.
4330 (reseat_1): Call bidi_init_it to resync the bidi
4331 iterator with IT's position. (Bug#7616)
4332 (find_row_edges): If ROW->start.pos gives position
4333 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4334 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4335 Reset the from_disp_prop_p flag.
4336 (SAVE_IT, RESTORE_IT): New macros.
4337 (pos_visible_p, face_before_or_after_it_pos)
4338 (back_to_previous_visible_line_start)
4339 (move_it_in_display_line_to, move_it_in_display_line)
4340 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4341 (try_scrolling, redisplay_window, display_line): Use them when
4342 saving a temporary copy of the iterator and restoring it back.
4343 (back_to_previous_visible_line_start, reseat_1)
4344 (init_iterator): Empty the bidi cache "stack".
4345 (move_it_in_display_line_to): If iterator ended up at
4346 EOL, but we never saw any buffer positions smaller than
4347 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4348 motion in bidi-reordered lines.
4349 (move_it_in_display_line_to): Record prev_method and prev_pos
4350 immediately before the call to set_iterator_to_next. Fixes cursor
4351 motion in bidi-reordered lines with stretch glyphs and strings
4352 displayed in margins. (Bug#8133) (Bug#8867)
4353 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4355 (pos_visible_p): Support positions in bidi-reordered lines.
4356 Save and restore bidi cache.
4358 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4359 (bidi_paragraph_info): Delete unused struct.
4360 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4361 (bidi_cache_start): New variable.
4362 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4364 (bidi_cache_fetch_state, bidi_cache_search)
4365 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4366 (bidi_cache_find, bidi_peek_at_next_level)
4367 (bidi_level_of_next_char, bidi_find_other_level_edge)
4368 (bidi_move_to_visually_next): Compare cache index with
4369 bidi_cache_start rather than with zero.
4370 (bidi_fetch_char): Accept new argument STRING; all callers
4371 changed. Support iteration over a string. Support strings with
4372 display properties. Support unibyte strings. Fix the type of
4373 `len' according to what STRING_CHAR_AND_LENGTH expects.
4374 (bidi_paragraph_init, bidi_resolve_explicit_1)
4375 (bidi_resolve_explicit, bidi_resolve_weak)
4376 (bidi_level_of_next_char, bidi_move_to_visually_next):
4377 Support iteration over a string.
4378 (bidi_set_sor_type, bidi_resolve_explicit_1)
4379 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4380 can now be zero (for strings); special values 0 and -1 were
4381 changed to -1 and -2, respectively.
4382 (bidi_char_at_pos): New function.
4383 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4384 Call it instead of FETCH_MULTIBYTE_CHAR.
4385 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4386 initialized to valid values.
4387 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4389 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4390 the test for valid cached positions. Fix the logic for looking up
4391 the sentinel state in the cache. GCPRO the Lisp string we are
4393 (bidi_push_it, bidi_pop_it): New functions.
4394 (bidi_initialize): Initialize the bidi cache start stack pointer.
4395 (bidi_cache_ensure_space): New function, refactored from part of
4396 bidi_cache_iterator_state. Don't assume the required size is just
4397 one BIDI_CACHE_CHUNK away.
4398 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4399 (bidi_count_bytes, bidi_char_at_pos): New functions.
4400 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4401 always valid if bidi_cache_idx is valid.
4402 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4403 is valid if it's going to be used.
4404 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4405 (bidi_cache_fetch_state, bidi_cache_search)
4406 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4407 (bidi_cache_iterator_state, bidi_cache_find)
4408 (bidi_find_other_level_edge, bidi_cache_start_stack):
4409 All variables related to cache indices are now EMACS_INT.
4411 * dispextern.h (struct bidi_string_data): New structure.
4412 (struct bidi_it): New member `string'. Make flag members be 1-bit
4413 fields, and put them last in the struct.
4414 (compute_display_string_pos, compute_display_string_end):
4416 (bidi_push_it, bidi_pop_it): Add prototypes.
4417 (struct iterator_stack_entry): New members bidi_p,
4418 paragraph_embedding, and from_disp_prop_p.
4419 (struct it): Member bidi_p is now a bit field 1 bit wide.
4420 (bidi_shelve_cache, bidi_unshelve_cache):
4423 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4424 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4425 and vector-like objects.
4427 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4428 cache around display iteration.
4430 * window.c (Fwindow_end, window_scroll_pixel_based)
4431 (displayed_window_lines, Frecenter): Save and restore the bidi
4432 cache around display iteration.
4434 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4436 * editfns.c (Fdelete_region): Clarify the use of the named
4437 parameters (bug#6788).
4439 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4441 * indent.c (Fvertical_motion): Set and restore w->pointm when
4442 saving and restoring the window's buffer (Bug#9006).
4444 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4446 * editfns.c (Fstring_to_char): Clarify just what is returned
4447 (bug#6576). Text by Eli Zaretskii.
4449 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4451 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4453 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4455 * buffer.c (mmap_find): Fix a typo.
4457 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4459 Fix execution of x selection hooks.
4460 * xselect.c (Qx_lost_selection_functions)
4461 (Qx_sent_selection_functions): New vars.
4462 (syms_of_xselect): DEFSYM them.
4463 (x_handle_selection_request): Pass Qx_sent_selection_functions
4464 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4465 (x_handle_selection_clear,x_clear_frame_selections):
4466 Pass Qx_lost_selection_functions rather than
4467 Vx_lost_selection_functions to Frun_hook_with_args.
4469 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4471 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4472 The old code sometimes used this field without initializing it.
4474 * alloc.c (gc_sweep): Don't read past end of array.
4475 In theory, the old code could also have corrupted Emacs internals,
4476 though it'd be very unlikely.
4478 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4480 * character.c (Fcharacterp): Don't advertise optional ignored
4481 argument. (Bug#4026)
4483 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4485 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4488 * window.c (Fset_window_start): Doc fix (bug#4199).
4489 (Fset_window_hscroll): Ditto.
4491 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4493 Fix minor new problems caught by GCC 4.6.1.
4494 * term.c (init_tty): Remove unused local.
4495 * xsettings.c (store_monospaced_changed): Define this function only
4496 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4499 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4501 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4503 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4505 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4506 are the mini-buffer and the echo area (bug#3320).
4508 * term.c (init_tty): Remove support for supdup, c10 and perq
4509 terminals, which are no longer supported (bug#1482).
4511 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4513 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4515 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4517 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4518 for non-popups (Bug#3642).
4520 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4522 * alloc.c (reset_malloc_hooks): Protoize.
4523 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4524 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4525 * cm.c (losecursor): Likewise.
4526 * data.c (fmod): Likewise.
4527 * dispnew.c (swap_glyphs_in_rows): Likewise.
4528 * emacs.c (memory_warning_signal): Likewise.
4529 * floatfns.c (float_error): Likewise.
4530 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4531 (otf_open, font_otf_capability, generate_otf_features)
4532 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4534 * image.c (pbm_read_file): Likewise.
4535 * indent.c (string_display_width): Likewise.
4536 * intervals.c (check_for_interval, search_for_interval)
4537 (inc_interval_count, count_intervals, root_interval)
4538 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4539 * lread.c (defalias): Likewise.
4540 * ralloc.c (r_alloc_check): Likewise.
4541 * regex.c (set_image_of_range_1, set_image_of_range)
4542 (regex_grow_registers): Likewise.
4543 * sysdep.c (strerror): Likewise.
4544 * termcap.c (valid_filename_p, tprint, main): Likewise.
4545 * tparam.c (main): Likewise.
4546 * unexhp9k800.c (run_time_remap, save_data_space)
4547 (update_file_ptrs, read_header, write_header, calculate_checksum)
4548 (copy_file, copy_rest, display_header): Likewise.
4549 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4551 * xdisp.c (check_it): Likewise.
4552 * xfaces.c (register_color, unregister_color, unregister_colors):
4554 * xfns.c (print_fontset_result): Likewise.
4555 * xrdb.c (member, fatal, main): Likewise.
4557 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4559 Fix minor problems found by static checking (Bug#9031).
4560 * chartab.c (char_table_set_range, map_sub_char_table):
4561 Remove unused locals.
4562 (uniprop_table): Now static.
4563 * composite.c (_work_char): Remove unused static var.
4565 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4567 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4569 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4571 * gtkutil.c (qttip_cb): Remove code without function.
4573 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4575 * w32.c (pthread_sigmask): New stub.
4577 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4579 Use pthread_sigmask, not sigprocmask (Bug#9010).
4580 sigprocmask is portable only for single-threaded applications, and
4581 Emacs can be multi-threaded when it uses GTK.
4582 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4584 * callproc.c (Fcall_process):
4585 * process.c (create_process):
4586 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4587 Use pthread_sigmask, not sigprocmask.
4589 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4591 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4592 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4595 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4597 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4598 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4599 (xg_hide_tooltip): Fix comment.
4601 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4602 in registerServicesMenuSendTypes.
4603 (validRequestorForSendType): Don't check ns_return_types.
4605 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4608 2011-07-08 Jason Rumney <jasonr@gnu.org>
4610 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4611 SH_SHOW for hidden windows (Bug#5482).
4613 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4614 frame struct members of non-existent frames (Bug#6284).
4616 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4618 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4619 variable firstTime not needed on OSX >= 10.6.
4620 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4621 >= 10.5. Use setKnobProportion, setDoubleValue.
4623 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4624 (MAC_OS_X_VERSION_10_5): Define if not defined.
4625 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4626 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4627 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4629 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4630 cString and lossyCString on OSX >= 10.4
4632 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4633 sizeToFit on OSX >= 10.2.
4635 * nsimage.m (allocInitFromFile): Don't use deprecated method
4636 bestRepresentationForDevice on OSX >= 10.6.
4638 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4641 * emacs.c: Declare unexec_init_emacs_zone.
4643 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4645 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4647 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4648 on svcsMenu (Bug#8842).
4650 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4652 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4654 * nsterm.m (QUTF8_STRING): Declare.
4655 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4656 (validRequestorForSendType): Return type is (id).
4657 Change indexOfObjectIdenticalTo to indexOfObject.
4658 Check if we have local selection before returning self (Bug#8842).
4659 (writeSelectionToPasteboard): Put local selection into paste board
4660 if we have a local selection (Bug#8842).
4661 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4663 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4664 (ns_get_local_selection): Declare.
4666 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4668 * keymap.c (describe_map_tree): Don't insert a double newline at
4669 the end of the buffer (bug#1169) and return whether we inserted
4672 * callint.c (Fcall_interactively): Change "reading args" to
4673 "providing args" to try to clarify what it does (bug#1010).
4675 2011-07-07 Kenichi Handa <handa@m17n.org>
4677 * composite.c (composition_compute_stop_pos): Ignore a static
4678 composition starting before CHARPOS (Bug#8915).
4680 * xdisp.c (handle_composition_prop): Likewise.
4682 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4684 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4687 2011-07-07 Kenichi Handa <handa@m17n.org>
4689 * character.h (unicode_category_t): New enum type.
4691 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4692 (Qchar_code_property_table): New variable.
4693 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4694 (UNIPROP_COMPRESSED_FORM_P): New macros.
4695 (char_table_ascii): Uncompress the compressed values.
4696 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4697 Uncompress the compressed values.
4698 (sub_char_table_ref_and_range): Likewise.
4699 (char_table_ref_and_range): Uncompress the compressed values.
4700 (sub_char_table_set): New arg is_uniprop. Callers changed.
4701 Uncompress the compressed values.
4702 (sub_char_table_set_range): Args changed. Callers changed.
4703 (char_table_set_range): Adjuted for the above change.
4704 (map_sub_char_table): Delete args default_val and parent. Add arg
4705 top. Give decoded values to a Lisp function.
4706 (map_char_table): Adjust for the above change. Give decoded
4707 values to a Lisp function. Gcpro more variables.
4708 (uniprop_table_uncompress)
4709 (uniprop_decode_value_run_length): New functions.
4710 (uniprop_decoder, uniprop_decoder_count): New variables.
4711 (uniprop_get_decoder, uniprop_encode_value_character)
4712 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4714 (uniprop_encoder, uniprop_encoder_count): New variables.
4715 (uniprop_get_encoder, uniprop_table)
4716 (Funicode_property_table_internal, Fget_unicode_property_internal)
4717 (Fput_unicode_property_internal): New functions.
4718 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4719 Sunicode_property_table_internal, Sget_unicode_property_internal,
4720 and Sput_unicode_property_internal. Defvar_lisp
4721 char-code-property-alist.
4723 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4724 Vunicode_category_table.
4726 * font.c (font_range): Adjust for the change of
4727 Vunicode_category_table.
4729 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4731 * m/iris4d.h: Remove file, move contents ...
4732 * s/irix6-5.h: ... here.
4734 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4736 Remove unportable assumption about struct layout (Bug#8884).
4737 * alloc.c (mark_buffer):
4738 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4739 (clone_per_buffer_values): Don't assume that
4740 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4741 This isn't true in general, and it's particularly not true
4742 if Emacs is configured with --with-wide-int.
4743 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4744 New macros, used in the buffer.c change.
4746 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4748 * xsettings.c: Use both GConf and GSettings if both are available.
4749 (store_config_changed_event): Add comment.
4750 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4751 (store_tool_bar_style_changed): New functions.
4752 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4753 (struct xsettings): Move font inside HAVE_XFT.
4754 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4755 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4756 Move inside HAVE_XFT.
4757 (something_changed_gsettingsCB): Rename from something_changedCB.
4758 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4760 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4761 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4762 (something_changed_gconfCB): Rename from something_changedCB.
4763 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4764 (parse_settings): Move check for font inside HAVE_XFT.
4765 (read_settings, apply_xft_settings): Add comment.
4766 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4767 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4768 call store_font_name_changed.
4769 (xft_settings_event): Add comment.
4770 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4771 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4772 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4773 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4774 (xsettings_initialize): Call init_gsettings last.
4775 (xsettings_get_system_font, xsettings_get_system_normal_font):
4778 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4780 Random fixes. E.g., (random) never returned negative values.
4781 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4782 subseconds part to the entropy, as that's a bit more random.
4783 Prefer signed to unsigned, since the signedness doesn't matter and
4784 in general we prefer signed. When given a limit, use a
4785 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4786 latter isn't right if USE_2_TAGS_FOR_INTS.
4787 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4788 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4790 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4792 * textprop.c (text_property_stickiness):
4793 Obey Vtext_property_default_nonsticky.
4794 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4795 * w32fns.c (syms_of_w32fns):
4796 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4798 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4800 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4801 This is more efficient than Ffile_directory_p and avoids a minor race.
4803 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4805 * buffer.c (Foverlay_put): Say what the return value is
4808 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4809 is a directory before asking whether to use the file name
4811 (barf_or_query_if_file_exists): Make the "File is a directory"
4812 error be more correct.
4814 * fns.c (Frequire): Remove the mention of the .gz files, since
4815 that's installation-specific, but keep the mention of
4816 `get-load-suffixes'.
4818 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4820 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4821 Report string overflow if the output is too long.
4823 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4825 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4826 (syms_of_gnutls): Remove duplicate DEFSYM for
4827 Qgnutls_bootprop_verify_hostname_error, an error for
4828 Qgnutls_bootprop_verify_error (which is no longer used).
4830 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4831 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4832 Also (re)move comments that are misplaced or no longer relevant.
4834 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4836 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4838 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4840 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4841 and background color parameters if they have been changed.
4843 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4845 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4847 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4849 * xsettings.c (SYSTEM_FONT): Define only when used.
4850 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4852 * keymap.c (access_keymap_1): Now static.
4854 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4856 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4857 leave any prefix arg for the up event (Bug#1586).
4859 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4861 * lread.c (syms_of_lread): Mention single symbols defined by
4862 `defvar' or `defconst' (bug#7154).
4864 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4865 (Frequire): Mention get-load-suffixes.
4867 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4869 * window.h (window): Remove clone_number slot.
4870 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4872 (make_parent_window, make_window, saved_window)
4873 (Fset_window_configuration, save_window_save): Don't deal with
4875 * buffer.c (Qclone_number): Remove declaration.
4876 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4878 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4880 Add multiple inheritance to keymaps.
4881 * keymap.c (Fmake_composed_keymap): New function.
4882 (Fset_keymap_parent): Simplify.
4883 (fix_submap_inheritance): Remove.
4884 (access_keymap_1): New function extracted from access_keymap to handle
4885 embedded parents and handle lists of maps.
4886 (access_keymap): Use it.
4887 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4888 (Fcopy_keymap): Handle embedded parents.
4889 (Fcommand_remapping, define_as_prefix): Simplify.
4890 (Fkey_binding): Simplify.
4891 (syms_of_keymap): Move minibuffer-local-completion-map,
4892 minibuffer-local-filename-completion-map,
4893 minibuffer-local-must-match-map, and
4894 minibuffer-local-filename-must-match-map to Elisp.
4895 (syms_of_keymap): Defsubr make-composed-keymap.
4896 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4897 (parse_menu_item): Trivial simplification.
4899 2011-07-01 Glenn Morris <rgm@gnu.org>
4901 * Makefile.in (SETTINGS_LIBS): Fix typo.
4903 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4905 * coding.c (Fencode_coding_string): Record the last coding system
4906 used, as the function doc string says (bug#8738).
4908 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4910 * xsettings.c (store_monospaced_changed): Take new font as arg and
4911 check for change against current_mono_font.
4912 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4913 (emacs_settings_constructor, emacs_settings_get_property)
4914 (emacs_settings_set_property, emacs_settings_class_init)
4915 (emacs_settings_init, gsettings_obj): Remove.
4916 (something_changedCB): New function for HAVE_GSETTINGS.
4917 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4918 with value as argument.
4919 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4920 g_settings_new (Bug#8967). Do not create gsettings_obj.
4921 Remove calls to g_settings_bind. Connect something_changedCB to
4924 * xgselect.c: Add defined (HAVE_GSETTINGS).
4925 (xgselect_initialize): Ditto.
4927 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4928 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4931 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4933 * eval.c (struct backtrace): Simplify and port the data structure.
4934 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4935 signed bit field, as this assumption is not portable and it makes
4936 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4937 "char debug_on_exit : 1" as this is not portable either; instead,
4938 use the portable "unsigned int debug_on_exit : 1". Remove unused
4939 member evalargs. Remove obsolete comments about cc bombing out.
4941 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4943 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4944 Let HAVE_GSETTINGS override HAVE_GCONF.
4945 (store_monospaced_changed): New function.
4946 (EMACS_SETTINGS): A new type derived from GObject to handle
4947 GSettings notifications.
4948 (emacs_settings_constructor, emacs_settings_get_property)
4949 (emacs_settings_set_property, emacs_settings_class_init):
4951 (gsettings_client, gsettings_obj): New variables.
4952 (GSETTINGS_SCHEMA): New define.
4953 (something_changedCB): Call store_monospaced_changed.
4954 (init_gsettings): New function.
4955 (xsettings_initialize): Call init_gsettings.
4956 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4959 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4962 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4964 * window.c (resize_root_window, grow_mini_window)
4965 (shrink_mini_window): Rename Qresize_root_window to
4966 Qwindow_resize_root_window and Qresize_root_window_vertically to
4967 Qwindow_resize_root_window_vertically.
4969 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4971 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4973 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4975 * makefile.w32-in: Redesign dependencies so they reflect more
4976 clearly which files are directly included by each source file,
4977 and not through other includes.
4979 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4981 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4982 (sort_overlays, overlay_strings): When an overlay's clone number
4983 matches the window's clone number process the overlay even if
4984 the overlay's window property doesn't match the current window.
4986 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4987 (Fwindow_hchild): Rename to Fwindow_left_child.
4988 (Fwindow_next): Rename to Fwindow_next_sibling.
4989 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4990 (resize_window_check): Rename to window_resize_check.
4991 (resize_window_apply): Rename to window_resize_apply.
4992 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4993 (Fdelete_other_windows_internal, resize_frame_windows)
4994 (Fsplit_window_internal, Fdelete_window_internal)
4995 (grow_mini_window, shrink_mini_window)
4996 (Fresize_mini_window_internal): Fix callers accordingly.
4998 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5000 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5001 (emacs_fixed_set_min_size): Remove.
5002 (emacs_fixed_new): Take frame as argument.
5004 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5005 (_EmacsFixedPrivate): Remove minwidth/height.
5006 Add struct frame *f.
5007 (emacs_fixed_init): Initialize priv->f.
5008 (get_parent_class, emacs_fixed_set_min_size): Remove.
5009 (emacs_fixed_new): Set priv->f to argument.
5010 (emacs_fixed_get_preferred_width)
5011 (emacs_fixed_get_preferred_height): Use min_width/height from
5012 frames size_hint to set minimum and natural (Bug#8919).
5013 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5014 and use min_width/height from frames size_hint to set
5015 min_width/height (Bug#8919).
5017 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5018 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5021 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5023 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5024 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5027 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5029 * process.c (wait_reading_process_output): Bypass select if
5030 waiting for a cell while ignoring keyboard input, and input is
5031 pending. Suggested by Jan Djärv (Bug#8869).
5033 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5035 Use gnulib's dup2 module instead of rolling our own.
5036 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5038 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5040 * dispnew.c (scrolling_window): Before scrolling, turn off a
5041 mouse-highlight in the window being scrolled.
5043 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5045 Move DEFSYM to lisp.h and use everywhere.
5047 * character.h (DEFSYM): Move declaration...
5048 * lisp.h (DEFSYM): ...here.
5054 * w32select.c: Don't include character.h.
5056 * alloc.c (syms_of_alloc):
5057 * buffer.c (syms_of_buffer):
5058 * bytecode.c (syms_of_bytecode):
5059 * callint.c (syms_of_callint):
5060 * casefiddle.c (syms_of_casefiddle):
5061 * casetab.c (init_casetab_once):
5062 * category.c (init_category_once, syms_of_category):
5063 * ccl.c (syms_of_ccl):
5064 * cmds.c (syms_of_cmds):
5065 * composite.c (syms_of_composite):
5066 * dbusbind.c (syms_of_dbusbind):
5067 * dired.c (syms_of_dired):
5068 * dispnew.c (syms_of_display):
5069 * doc.c (syms_of_doc):
5070 * editfns.c (syms_of_editfns):
5071 * emacs.c (syms_of_emacs):
5072 * eval.c (syms_of_eval):
5073 * fileio.c (syms_of_fileio):
5074 * fns.c (syms_of_fns):
5075 * frame.c (syms_of_frame):
5076 * fringe.c (syms_of_fringe):
5077 * insdel.c (syms_of_insdel):
5078 * keymap.c (syms_of_keymap):
5079 * lread.c (init_obarray, syms_of_lread):
5080 * macros.c (syms_of_macros):
5081 * msdos.c (syms_of_msdos):
5082 * print.c (syms_of_print):
5083 * process.c (syms_of_process):
5084 * search.c (syms_of_search):
5085 * sound.c (syms_of_sound):
5086 * syntax.c (init_syntax_once, syms_of_syntax):
5087 * terminal.c (syms_of_terminal):
5088 * textprop.c (syms_of_textprop):
5089 * undo.c (syms_of_undo):
5090 * w32.c (globals_of_w32):
5091 * window.c (syms_of_window):
5092 * xdisp.c (syms_of_xdisp):
5093 * xfaces.c (syms_of_xfaces):
5094 * xfns.c (syms_of_xfns):
5095 * xmenu.c (syms_of_xmenu):
5096 * xsettings.c (syms_of_xsettings):
5097 * xterm.c (syms_of_xterm): Use DEFSYM.
5099 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5101 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5103 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5105 Integer and buffer overflow fixes (Bug#8873).
5107 * print.c (printchar, strout): Check for string overflow.
5108 (PRINTPREPARE, printchar, strout):
5109 Don't set size unless allocation succeeds.
5111 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5112 for sizes. Check for string overflow more accurately.
5113 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5115 * macros.c: Integer and buffer overflow fixes.
5116 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5117 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5118 Use ptrdiff_t, not int, for sizes.
5119 Don't increment bufsize until after realloc succeeds.
5120 Check for size-calculation overflow.
5121 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5123 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5125 * lread.c: Integer overflow fixes.
5126 (read_integer): Radix is now EMACS_INT, not int,
5127 to improve quality of diagnostics for out-of-range radices.
5128 Calculate buffer size correctly for out-of-range radices.
5129 (read1): Check for integer overflow in radices, and in
5130 read-circle numbers.
5131 (read_escape): Avoid int overflow.
5132 (Fload, openp, read_buffer_size, read1)
5133 (substitute_object_recurse, read_vector, read_list, map_obarray):
5134 Use ptrdiff_t, not int, for sizes.
5135 (read1): Use EMACS_INT, not int, for sizes.
5136 Check for size overflow.
5138 * image.c (cache_image): Check for size arithmetic overflow.
5140 * lread.c: Integer overflow issues.
5141 (saved_doc_string_size, saved_doc_string_length)
5142 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5143 Now ptrdiff_t, not int.
5144 (read1): Don't assume doc string length fits in int. Check for
5145 out-of-range doc string lengths.
5146 (read_list): Don't assume file position fits in int.
5147 (read_escape): Check for hex character overflow.
5149 2011-06-22 Leo Liu <sdl.web@gmail.com>
5151 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5152 Move to minibuffer.el.
5154 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5156 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5157 The following patches are for when GLYPH_DEBUG && !XASSERT.
5158 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5159 * dispnew.c (flush_stdout):
5160 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5161 Mark as externally visible.
5162 * dispnew.c (check_window_matrix_pointers): Now static.
5163 * dispnew.c (window_to_frame_vpos):
5164 * xfns.c (unwind_create_frame):
5165 * xterm.c (x_check_font): Remove unused local.
5166 * scroll.c (CHECK_BOUNDS):
5167 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5168 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5169 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5170 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5171 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5173 (debug_method_add): Use va_list and vsprintf rather than relying
5174 on undefined behavior with wrong number of arguments.
5175 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5176 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5177 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5178 since we're not interested in debugging glyphs with old libraries.
5179 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5180 GCC 4.6.0's static checking.
5182 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5184 Integer overflow and signedness fixes (Bug#8873).
5185 A few related buffer overrun fixes, too.
5187 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5189 * dispextern.h (struct face.stipple):
5190 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5191 (x_bitmap_mask, x_allocate_bitmap_record)
5192 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5193 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5194 (x_create_bitmap_from_xpm_data):
5195 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5196 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5198 * xfaces.c (load_pixmap):
5199 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5200 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5201 (.bitmaps_last, struct x_output.icon_bitmap):
5202 Use ptrdiff_t, not int, for bitmap indexes.
5203 (x_allocate_bitmap_record): Check for size overflow.
5204 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5206 Use ptrdiff_t, not int, for overlay counts.
5207 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5208 * editfns.c (overlays_around, get_pos_property):
5209 * textprop.c (get_char_property_and_overlay):
5210 * xdisp.c (next_overlay_change, note_mouse_highlight):
5211 * xfaces.c (face_at_buffer_position):
5212 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5213 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5214 (Fnext_overlay_change, Fprevious_overlay_change)
5215 (mouse_face_overlay_overlaps, Foverlays_in):
5216 Use ptrdiff_t, not int, for sizes.
5217 (overlays_at, overlays_in): Check for size-calculation overflow.
5219 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5221 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5222 (x_session_initialize): Do not assume string length fits in int.
5224 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5225 This is unlikely, but can occur if DPI is outlandish.
5227 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5228 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5230 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5231 * xrdb.c (magic_file_p, search_magic_path):
5232 Omit last arg SUFFIX; it was always 0. All callers changed.
5233 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5235 * xfont.c (xfont_match): Avoid need for strlen.
5237 * xfns.c: Don't assume strlen fits in int.
5238 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5240 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5241 not unsigned long, as we prefer signed integers. All callers changed.
5242 Detect integer overflow in repeat count.
5243 (message_dolog): Don't assume print length fits in 39 bytes.
5244 (display_mode_element): Don't assume strlen fits in int.
5246 * termcap.c: Don't assume sizes fit in int and never overflow.
5247 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5248 (gobble_line): Check for size-calculation overflow.
5250 * minibuf.c (Fread_buffer):
5251 * lread.c (intern, intern_c_string):
5252 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5253 Don't assume string length fits in int.
5255 * keyboard.c (parse_tool_bar_item):
5256 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5258 * font.c: Don't assume string length fits in int.
5259 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5260 Use ptrdiff_t, not int.
5261 (font_intern_prop): Don't assume string length fits in int.
5262 Don't assume integer property fits in fixnum.
5263 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5265 * filelock.c: Fix some buffer overrun and integer overflow issues.
5266 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5267 Reformulate so as not to need the command string.
5268 Invoke gzip -cd rather than gunzip, as it's more portable.
5269 (lock_info_type, lock_file_1, lock_file):
5270 Don't assume pid_t and time_t fit in unsigned long.
5271 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5272 (current_lock_owner): Prefer signed type for sizes.
5273 Use memcpy, not strncpy, where memcpy is what is really wanted.
5274 Don't assume (via atoi) that time_t and pid_t fit in int.
5275 Check for time_t and/or pid_t out of range, e.g., via a network share.
5276 Don't alloca where an auto var works fine.
5278 * fileio.c: Fix some integer overflow issues.
5279 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5280 Don't assume string length fits in int.
5281 (directory_file_name): Don't assume string length fits in long.
5282 (make_temp_name): Don't assume pid fits in int, or that its print
5283 length is less than 20.
5285 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5287 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5289 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5291 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5292 We prefer signed integers, even for size calculations.
5294 * emacs.c: Don't assume string length fits in 'int'.
5295 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5296 (main): Don't invoke strlen when not needed.
5298 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5299 (XD_DEBUG_MESSAGE): Don't waste a byte.
5301 * callproc.c (getenv_internal_1, getenv_internal)
5303 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5305 * lread.c (invalid_syntax): Omit length argument.
5306 All uses changed. This doesn't fix a bug, but it simplifies the
5307 code away from its former Hollerith-constant appearance, and it's
5308 one less 'int' to worry about when looking at integer-overflow issues.
5309 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5311 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5312 This didn't break anything, but it didn't help either.
5313 It's confusing to put a bogus integer in a place where the actual
5314 value does not matter.
5315 (LIST_END_P): Remove unused macro and its bogus comment.
5316 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5318 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5319 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5321 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5322 We prefer signed types, and the value cannot exceed the EMACS_INT
5323 range anyway (because otherwise the length would not be representable).
5324 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5325 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5326 This avoids a GCC warning when WIDE_EMACS_INT.
5328 * indent.c (sane_tab_width): New function.
5329 (current_column, scan_for_column, Findent_to, position_indentation)
5330 (compute_motion): Use it. This is just for clarity.
5331 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5333 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5335 * lisp.h (lint_assume): New macro.
5336 * composite.c (composition_gstring_put_cache):
5337 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5339 * editfns.c, insdel.c:
5340 Omit unnecessary forward decls, to simplify future changes.
5342 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5344 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5346 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5347 Use much-faster test for byte-length change.
5348 Don't assume string byte-length fits in 'int'.
5349 Check that character arg fits in 'int'.
5350 (mapcar1): Declare byte as byte, for clarity.
5352 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5354 * fns.c (concat): Catch string overflow earlier.
5355 Do not rely on integer wraparound.
5357 * dispextern.h (struct it.overlay_strings_charpos)
5358 (struct it.selective): Now EMACS_INT, not int.
5359 * xdisp.c (forward_to_next_line_start)
5360 (back_to_previous_visible_line_start)
5361 (reseat_at_next_visible_line_start, next_element_from_buffer):
5362 Don't arbitrarily truncate the value of 'selective' to int.
5364 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5366 * composite.c: Don't truncate sizes to 'int'.
5367 (composition_gstring_p, composition_reseat_it)
5368 (composition_adjust_point): Use EMACS_INT, not int.
5369 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5370 not EMACS_UINT, for indexes.
5372 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5374 * buffer.c: Include <verify.h>.
5375 (struct sortvec.priority, struct sortstr.priority):
5376 Now EMACS_INT, not int.
5377 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5378 (struct sortstr.size, record_overlay_string)
5379 (struct sortstrlist.size, struct sortlist.used):
5380 Don't truncate size to int.
5381 (record_overlay_string): Check for size-calculation overflow.
5382 (init_buffer_once): Check at compile-time, not run-time.
5384 2011-06-22 Jim Meyering <meyering@redhat.com>
5386 Don't leak an XBM-image-sized buffer
5387 * image.c (xbm_load): Free the image buffer after using it.
5389 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5392 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5393 that Sun C diagnosed.
5394 * fns.c (secure_hash): Fix pointer signedness issue.
5395 * intervals.c (static_offset_intervals): New function.
5396 (offset_intervals): Use it.
5398 2011-06-21 Leo Liu <sdl.web@gmail.com>
5401 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5404 * fns.c (secure_hash): Rename from crypto_hash_function and change
5405 the first arg to accept symbols.
5406 (Fsecure_hash): New primitive.
5407 (syms_of_fns): New symbols.
5409 2011-06-20 Deniz Dogan <deniz@dogan.se>
5411 * process.c (Fset_process_buffer): Clarify return value in
5414 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5416 * dispnew.c (add_window_display_history): Use BVAR.
5418 * xdisp.c (debug_method_add): Use BVAR.
5419 (check_window_end, dump_glyph_matrix, dump_glyph)
5420 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5422 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5425 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5426 check till after the cache is created in init_frame_faces.
5428 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5430 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5432 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5434 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5435 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5436 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5438 Improve buffer-overflow checking (Bug#8873).
5439 * fileio.c (Finsert_file_contents):
5440 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5441 Remove the old (too-loose) buffer overflow checks.
5442 They weren't needed, since make_gap checks for buffer overflow.
5443 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5444 The old code merely checked for Emacs fixnum overflow, and relied
5445 on undefined (wraparound) behavior. The new code avoids undefined
5446 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5448 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5449 Tune. Don't use wider integers than needed. Don't use alloca.
5450 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5452 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5454 * insdel.c, lisp.h (buffer_overflow): New function.
5455 (insert_from_buffer_1, replace_range, replace_range_2):
5456 * insdel.c (make_gap_larger):
5457 * editfns.c (Finsert_char):
5458 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5460 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5462 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5464 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5466 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5467 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5469 * fileio.c: Don't assume EMACS_INT fits in off_t.
5470 (emacs_lseek): New static function.
5471 (Finsert_file_contents, Fwrite_region): Use it.
5472 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5474 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5476 * fns.c: Don't overflow int when computing a list length.
5477 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5478 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5479 truncation on 64-bit hosts. Check for QUIT every
5480 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5481 faster and is responsive enough.
5482 (Flength): Report an error instead of overflowing an integer.
5483 (Fsafe_length): Return a float if the value is not representable
5484 as a fixnum. This shouldn't happen except in contrived situations.
5485 (Fnthcdr, Fsort): Don't assume list length fits in int.
5486 (Fcopy_sequence): Don't assume vector length fits in int.
5488 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5489 (header_size, word_size): New constants.
5490 (allocate_vectorlike): Don't check size overflow here.
5491 (allocate_vector): Check it here instead, since this is the only
5492 caller of allocate_vectorlike that could cause overflow.
5493 Check that the new vector's length is representable as a fixnum.
5495 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5496 The previous code was bogus. For example, next_almost_prime (32)
5497 returned 39, which is undesirable as it is a multiple of 3; and
5498 next_almost_prime (24) returned 25, which is a multiple of 5 so
5499 why was the code bothering to check for multiples of 7?
5501 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5503 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5505 Variadic C functions now count arguments with ptrdiff_t.
5506 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5507 Back then I didn't know that the Emacs coding style prefers signed int.
5508 Also, in the meantime I found a few more instances where arguments
5509 were being counted with int, which may truncate counts on 64-bit
5510 machines, or EMACS_INT, which may be unnecessarily wide.
5511 * lisp.h (struct Lisp_Subr.function.aMANY)
5512 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5513 Arg counts are now ptrdiff_t, not size_t.
5514 All variadic functions and their callers changed accordingly.
5515 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5516 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5517 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5518 * callint.c (Fcall_interactively): Check arg count for overflow,
5519 to avoid potential buffer overrun. Use signed char, not 'int',
5520 for 'varies' array, so that we needn't bother to check its size
5521 calculation for overflow.
5522 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5523 * eval.c (apply_lambda):
5524 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5525 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5526 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5528 * callint.c (Fcall_interactively): Don't use index var as event count.
5530 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5531 * mem-limits.h (SIZE): Remove; no longer used.
5533 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5535 Remove unnecessary casts.
5536 * xterm.c (x_term_init):
5537 * xfns.c (x_set_border_pixel):
5538 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5539 These aren't needed now that we assume ANSI C.
5541 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5542 It's more likely to cause problems (due to unsigned overflow)
5545 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5547 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5549 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5551 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5553 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5555 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5557 GLYPH_CODE_FACE returns EMACS_INT, not int.
5558 * dispextern.h (merge_faces):
5559 * xfaces.c (merge_faces):
5560 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5561 Don't assume EMACS_INT fits in int.
5563 * character.h (CHAR_VALID_P): Remove unused parameter.
5564 * fontset.c, lisp.h, xdisp.c: All uses changed.
5566 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5568 * fns.c (concat): Minor tuning based on overflow analysis.
5569 This doesn't fix any bugs. Use int to hold character, instead
5570 of constantly refetching from Emacs object. Use XFASTINT, not
5571 XINT, for value known to be a character. Don't bother comparing
5572 a single byte to 0400, as it's always less.
5574 * floatfns.c (Fexpt):
5575 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5577 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5580 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5582 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5583 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5584 incorrectly succeed when S was a string, because 4294967386 was
5585 truncated before it was used.
5587 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5588 Otherwise, an out-of-range integer could cause undefined behavior
5591 * composite.c: Use int, not EMACS_INT, for characters.
5592 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5593 EMACS_INT, for values that are known to be in character range.
5594 This doesn't fix any bugs but is the usual style inside Emacs and
5595 may generate better code on 32-bit machines.
5597 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5598 This is for reasons similar to the recent CHAR_STRING fix.
5599 * charset.c (Fencode_char): Check that character arg is actually
5600 a character. Pass an int to ENCODE_CHAR.
5601 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5602 wider than 'int', as a compile-time check to prevent future regressions
5605 * character.c (char_string): Remove unnecessary casts.
5607 Make sure a 64-bit char is never passed to CHAR_STRING.
5608 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5609 by silently ignoring the top 32 bits, allowing some values
5610 that were far too large to be valid characters.
5611 * character.h: Include <verify.h>.
5612 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5613 arguments are no wider than unsigned, as a compile-time check
5614 to prevent future regressions in this area.
5616 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5617 (Fsubst_char_in_region):
5619 * xdisp.c (decode_mode_spec_coding):
5620 Adjust to CHAR_STRING's new requirement.
5621 * editfns.c (Finsert_char, Fsubst_char_in_region):
5622 * fns.c (concat): Check that character args are actually
5623 characters. Without this test, these functions did the wrong
5624 thing with wildly out-of-range values on 64-bit hosts.
5626 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5627 These casts should not be needed on 32-bit hosts, either.
5628 * keyboard.c (read_char):
5629 * lread.c (Fload): Remove casts to unsigned.
5631 * lisp.h (UNSIGNED_CMP): New macro.
5632 This fixes comparison bugs on 64-bit hosts.
5633 (ASCII_CHAR_P): Use it.
5634 * casefiddle.c (casify_object):
5635 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5636 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5637 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5638 * dispextern.h (FACE_FROM_ID):
5639 * keyboard.c (read_char): Use UNSIGNED_CMP.
5641 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5642 not to EMACS_INT, to avoid GCC warning.
5644 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5646 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5647 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5648 isn't needed on 32-bit machines.
5650 * buffer.c (Fgenerate_new_buffer_name):
5651 Use EMACS_INT for count, not int.
5652 (advance_to_char_boundary): Return EMACS_INT, not int.
5654 * data.c (Qcompiled_function): Now static.
5656 * window.c (window_body_lines): Now static.
5658 * image.c (gif_load): Rename local to avoid shadowing.
5660 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5661 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5662 * alloc.c (make_save_value): Integer argument is now of type
5664 (mark_object): Use ptrdiff_t, not int.
5665 * lisp.h (pD): New macro.
5666 * print.c (print_object): Use it.
5668 * alloc.c: Use EMACS_INT, not int, to count objects.
5669 (total_conses, total_markers, total_symbols, total_vector_size)
5670 (total_free_conses, total_free_markers, total_free_symbols)
5671 (total_free_floats, total_floats, total_free_intervals)
5672 (total_intervals, total_strings, total_free_strings):
5673 Now EMACS_INT, not int. All uses changed.
5674 (Fgarbage_collect): Compute overall total using a double, so that
5675 integer overflow is less likely to be a problem. Check for overflow
5676 when converting back to an integer.
5677 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5678 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5679 These were 'int' variables that could overflow on 64-bit hosts;
5680 they were never used, so remove them instead of repairing them.
5681 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5682 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5683 Previously, this ceilinged at INT_MAX, but that doesn't work on
5685 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5687 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5688 (allocate_vectorlike): Check for ptrdiff_t overflow.
5689 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5690 when a (possibly-narrower) signed value would do just as well.
5691 We prefer using signed arithmetic, to avoid comparison confusion.
5693 * alloc.c: Catch some string size overflows that we were missing.
5694 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5695 for convenience in STRING_BYTES_MAX.
5696 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5697 The definition here is exact; the one in lisp.h was approximate.
5698 (allocate_string_data): Check for string overflow. This catches
5699 some instances we weren't catching before. Also, it catches
5700 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5701 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5702 and ptrdiff_t and EMACS_INT are both 64 bits.
5704 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5705 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5706 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5708 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5710 * alloc.c (Fmake_string): Check for out-of-range init.
5712 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5714 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5716 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5718 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5719 xg_get_default_scrollbar_width.
5721 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5722 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5723 (style_changed_cb): Call update_theme_scrollbar_width and call
5724 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5725 all frames (Bug#8505).
5726 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5727 Call gtk_window_set_resizable if HAVE_GTK3.
5728 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5729 and height if HAVE_GTK3 (Bug#8505).
5730 (scroll_bar_width_for_theme): New variable.
5731 (update_theme_scrollbar_width): New function.
5732 (xg_get_default_scrollbar_width): Move code to
5733 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5734 (xg_initialize): Call update_theme_scrollbar_width.
5736 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5738 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5740 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5742 * frame.c (make_frame): Call other_buffer_safely instead of
5745 * window.c (temp_output_buffer_show): Call display_buffer with
5746 second argument Vtemp_buffer_show_specifiers and reset latter
5747 immediately after the call.
5748 (Vtemp_buffer_show_specifiers): New variable.
5749 (auto_window_vscroll_p, next_screen_context_lines)
5750 (Vscroll_preserve_screen_position): Remove leading asterisks from
5753 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5755 Fix minor problems found by GCC 4.6.0 static checking.
5756 * buffer.c (Qclone_number): Remove for now, as it's unused.
5757 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5758 (record_buffer): Remove unused local.
5759 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5760 (set_frame_buffer_list): Remove; unused.
5761 * frame.h (other_visible_frames): Remove decl.
5762 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5763 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5764 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5766 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5767 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5768 Define only if HAVE_GPM.
5769 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5770 (update_hints_inhibit): Remove; never set. All uses removed.
5771 * widgetprv.h (emacsFrameClassRec): Remove decl.
5772 * window.c (delete_deletable_window): Now returns void, since it
5773 wasn't returning anything.
5774 (compare_window_configurations): Remove unused locals.
5775 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5776 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5777 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5778 the same widths as pointers. This follows up on the 2011-05-06 patch.
5779 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5780 * xterm.h: Likewise.
5781 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5783 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5785 * makefile.w32-in: Update dependencies.
5786 (LISP_H): Add lib/intprops.h.
5788 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5790 * image.c (gif_load): Add animation frame delay to the metadata.
5791 (syms_of_image): Use DEFSYM. New symbol `delay'.
5793 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5795 * window.c (delete_deletable_window): Re-add.
5796 (Fset_window_configuration): Rewrite to handle dead buffers and
5797 consequently deletable windows.
5798 (window_tree, Fwindow_tree): Remove. Supply functionality in
5800 (compare_window_configurations): Simplify code.
5802 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5804 * image.c (imagemagick_load_image): Fix type mismatch.
5805 (Fimagemagick_types): Likewise.
5807 * window.h (replace_buffer_in_windows): Declare.
5809 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5811 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5812 Qclone_number. Remove external declaration of Qdelete_window.
5813 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5815 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5816 Run Qbuffer_list_update_hook if allowed.
5817 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5818 buffer list implementation.
5819 (other_buffer_safely): New function.
5820 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5821 calls to replace_buffer_in_windows and
5822 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5824 (record_buffer): Inhibit quitting and rewrite using quittable
5825 functions. Run Qbuffer_list_update_hook if allowed.
5826 (Frecord_buffer, Funrecord_buffer): New functions.
5827 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5828 Move switch-to-buffer to window.el.
5829 (bury-buffer): Move to window.el.
5830 (Vbuffer_list_update_hook): New variable.
5832 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5835 * window.h (resize_frame_windows): Move up in code.
5836 (Fwindow_frame): Remove EXFUN.
5837 (replace_buffer_in_all_windows): Remove prototype.
5838 (replace_buffer_in_windows_safely): Add prototype.
5840 * window.c: Declare Qdelete_window static again. Move down
5841 declaration of select_count.
5842 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5843 (Fother_window): Move to window.el.
5844 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5845 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5846 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5848 (replace_buffer_in_windows): Implement by calling
5849 Qreplace_buffer_in_windows.
5850 (replace_buffer_in_all_windows): Remove with some functionality
5851 moved into replace_buffer_in_windows_safely.
5852 (replace_buffer_in_windows_safely): New function.
5853 (select_window_norecord, select_frame_norecord): Move in front
5854 of run_window_configuration_change_hook. Remove now obsolete
5856 (Fset_window_buffer): Rewrite doc-string.
5857 Call Qrecord_window_buffer.
5858 (keys_of_window): Move binding for other-window to window.el.
5860 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5862 * dispextern.h (struct image): Replace data member, whose int_val
5863 and ptr_val fields were not used by anything, with a single
5866 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5867 (gif_clear_image, gif_load, imagemagick_load_image)
5868 (gs_clear_image, gs_load): Callers changed.
5870 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5872 * buffer.h: Include <time.h>, for time_t.
5873 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5875 Fix minor problems found by static checking.
5877 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5879 Make identifiers static if they are not used in other modules.
5880 * data.c (Qcompiled_function, Qframe, Qvector):
5881 * image.c (QimageMagick, Qsvg):
5882 * minibuf.c (Qmetadata):
5883 * window.c (resize_window_check, resize_root_window): Now static.
5884 * window.h (resize_window_check, resize_root_window): Remove decls.
5886 * window.c (window_deletion_count, delete_deletable_window):
5888 (window_body_lines): Now static.
5889 (Fdelete_other_windows_internal): Mark vars as initialized.
5890 Make sure 'resize_failed' is initialized.
5891 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5892 (resize_window_apply): Remove unused local.
5893 * window.h (delete_deletable_window): Remove decl.
5895 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5896 (imagemagick_load_image): Fix pointer signedness problem by changing
5897 last arg from unsigned char * to char *. All uses changed.
5898 Also, fix a local for similar reasons.
5899 Remove unused locals. Remove locals to avoid shadowing.
5900 (fn_rsvg_handle_free): Remove; unused.
5901 (svg_load, svg_load_image): Fix pointer signedness problem.
5902 (imagemagick_load_image): Don't use garbage pointer image_wand.
5904 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5906 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5908 * image.c (gif_load): Fix omitted cast error introduced by
5911 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5913 * window.h (resize_proportionally, orig_total_lines)
5914 (orig_top_line): Remove from window structure.
5915 (set_window_height, set_window_width, change_window_heights)
5916 (Fdelete_window): Remove prototypes.
5917 (resize_frame_windows): Remove duplicate declaration.
5919 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5921 * window.h (resize_frame_windows, resize_window_check)
5922 (delete_deletable_window, resize_root_window)
5923 (resize_frame_windows): Declare prototypes.
5925 * window.c (resize_window_apply): Make definition be "static" to
5926 match the prototype.
5928 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5930 * window.c: Remove declarations of Qwindow_size_fixed,
5931 window_min_size_1, window_min_size_2, window_min_size,
5932 size_window, window_fixed_size_p, enlarge_window, delete_window.
5933 Remove static from declaration of Qdelete_window, it's
5934 temporarily needed by Fbury_buffer.
5935 (replace_window): Don't assign orig_top_line and
5937 (Fdelete_window, delete_window): Remove. Window deletion is
5938 handled by window.el.
5939 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5940 Replace Fdelete_window calls with calls to Qdelete_window.
5941 (Fdelete_other_windows): Remove. Deleting other windows is
5942 handled by window.el.
5943 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5944 handled in window.el.
5945 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5946 Window minimum sizes are handled in window.el.
5947 (shrink_windows, size_window, set_window_height)
5948 (set_window_width, change_window_heights, window_height)
5949 (window_width, CURBEG, CURSIZE, enlarge_window)
5950 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5951 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5952 handled in window.el.
5953 (make_dummy_parent): Rename to make_parent_window and give it a
5954 second argument horflag.
5955 (make_window): Don't set resize_proportionally any more.
5956 (Fsplit_window): Remove. Windows are split in window.el.
5957 (save_restore_action, save_restore_orig_size)
5958 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5959 Resize mini windows in window.el.
5960 (grow_mini_window, shrink_mini_window): Implement by calling
5961 Qresize_root_window_vertically, resize_window_check and
5962 resize_window_apply.
5963 (saved_window, Fset_window_configuration, save_window_save):
5964 Do not handle orig_top_line, orig_total_lines, and
5965 resize_proportionally.
5966 (window_min_height, window_min_width): Move to window.el.
5967 (keys_of_window): Move bindings for delete-other-windows,
5968 split-window, delete-window and enlarge-window to window.el.
5970 * buffer.c: Temporarily extern Qdelete_window.
5971 (Fbury_buffer): Temporarily call Qdelete_window instead of
5972 Fdelete_window (Fbury_buffer will move to window.el soon).
5974 * frame.c (set_menu_bar_lines_1): Remove code handling
5975 orig_top_line and orig_total_lines.
5977 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5978 set_window_height but set heights directly.
5979 (change_frame_size_1): Use resize_frame_windows.
5981 * xdisp.c (init_xdisp): Don't use set_window_height but set
5984 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5985 Use resize_frame_windows instead of change_window_heights and run
5986 run_window_configuration_change_hook.
5988 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5989 instead of change_window_heights and run
5990 run_window_configuration_change_hook.
5992 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5994 * window.c (replace_window): Rename second argument REPLACEMENT to
5995 NEW. New third argument SETFLAG. Rewrite.
5996 (delete_window, make_dummy_parent): Call replace_window with
5998 (window_list_1): Move down in code.
5999 (run_window_configuration_change_hook): Move set_buffer part
6000 before select_frame_norecord part in order to unwind correctly.
6001 Rename count1 to count.
6002 (recombine_windows, delete_deletable_window, resize_root_window)
6003 (Fdelete_other_windows_internal)
6004 (Frun_window_configuration_change_hook, make_parent_window)
6005 (resize_window_check, resize_window_apply, Fresize_window_apply)
6006 (resize_frame_windows, Fsplit_window_internal)
6007 (Fdelete_window_internal, Fresize_mini_window_internal):
6009 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6011 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6013 * window.h (window): Add some new members to window structure -
6014 normal_lines, normal_cols, new_total, new_normal, clone_number,
6015 splits, nest, prev_buffers, next_buffers.
6016 (WINDOW_TOTAL_SIZE): Move here from window.c.
6017 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6019 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6021 (make_dummy_parent): Set new members of windows structure.
6022 (make_window): Move down in code. Handle new members of window
6024 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6025 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6026 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6027 (Fset_window_prev_buffers, Fwindow_next_buffers)
6028 (Fset_window_next_buffers, Fset_window_clone_number):
6030 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6031 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6033 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6034 Argument WINDOW can be now internal window too.
6035 (Fwindow_use_time): Move up in code.
6036 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6038 (Fset_window_configuration, saved_window)
6039 (Fcurrent_window_configuration, save_window_save): Handle new
6040 members of window structure.
6041 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6042 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6043 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6044 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6045 Qget_mru_window, Qresize_root_window,
6046 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6047 Qauto_buffer_name; staticpro them.
6049 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6051 * window.c (Fwindow_total_size, Fwindow_left_column)
6052 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6053 (Fwindow_list_1): New functions.
6054 (window_box_text_cols): Replace with window_body_cols.
6055 (Fwindow_width, Fscroll_left, Fscroll_right):
6056 Use window_body_cols instead of window_box_text_cols.
6057 (delete_window, Fset_window_configuration):
6058 Call delete_all_subwindows with window as argument.
6059 (delete_all_subwindows): Take a window as argument and not a
6061 (window_loop): Remove handling of GET_LRU_WINDOW and
6063 (Fget_lru_window, Fget_largest_window): Move to window.el.
6065 * window.h: Extern window_body_cols instead of
6066 window_box_text_cols. delete_all_subwindows now takes a
6067 Lisp_Object as argument.
6069 * indent.c (compute_motion, Fcompute_motion):
6070 Use window_body_cols instead of window_box_text_cols.
6072 * frame.c (delete_frame): Call delete_all_subwindows with root
6075 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6077 * fns.c (Fputhash): Document return value.
6079 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6081 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6083 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6085 Cons<->int and similar integer overflow fixes (Bug#8794).
6087 Check for overflow when converting integer to cons and back.
6088 * charset.c (Fdefine_charset_internal, Fdecode_char):
6089 Use cons_to_unsigned to catch overflow.
6090 (Fencode_char): Use INTEGER_TO_CONS.
6091 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6092 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6093 * data.c (long_to_cons, cons_to_long): Remove.
6094 (cons_to_unsigned, cons_to_signed): New functions.
6095 These signal an error for invalid or out-of-range values.
6096 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6097 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6098 * font.c (Ffont_variation_glyphs):
6099 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6100 * lisp.h: Include <intprops.h>.
6101 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6102 (cons_to_signed, cons_to_unsigned): New decls.
6103 (long_to_cons, cons_to_long): Remove decls.
6104 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6105 (Fprimitive_undo): Use CONS_TO_INTEGER.
6106 * xfns.c (Fx_window_property): Likewise.
6107 * xselect.c: Include <limits.h>.
6108 (x_own_selection, selection_data_to_lisp_data):
6109 Use INTEGER_TO_CONS.
6110 (x_handle_selection_request, x_handle_selection_clear)
6111 (x_get_foreign_selection, Fx_disown_selection_internal)
6112 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6113 (lisp_data_to_selection_data): Use cons_to_unsigned.
6114 (x_fill_property_data): Use cons_to_signed.
6115 Report values out of range.
6117 Check for buffer and string overflow more precisely.
6118 * buffer.h (BUF_BYTES_MAX): New macro.
6119 * lisp.h (STRING_BYTES_MAX): New macro.
6120 * alloc.c (Fmake_string):
6121 * character.c (string_escape_byte8):
6122 * coding.c (coding_alloc_by_realloc):
6123 * doprnt.c (doprnt):
6124 * editfns.c (Fformat):
6126 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6127 since they may not be the same number.
6128 * editfns.c (Finsert_char):
6129 * fileio.c (Finsert_file_contents):
6130 Likewise for BUF_BYTES_MAX.
6132 * image.c: Use ptrdiff_t, not int, for sizes.
6133 (slurp_file): Switch from int to ptrdiff_t.
6135 (slurp_file): Check that file size fits in both size_t (for
6136 malloc) and ptrdiff_t (for sanity and safety).
6138 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6139 if b->modtime has its maximal value.
6141 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6143 Don't assume time_t can fit into int.
6144 * buffer.h (struct buffer.modtime): Now time_t, not int.
6145 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6146 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6148 Minor fixes for signed vs unsigned integers.
6149 * character.h (MAYBE_UNIFY_CHAR):
6150 * charset.c (maybe_unify_char):
6151 * keyboard.c (read_char, reorder_modifiers):
6152 XINT -> XFASTINT, since the integer must be nonnegative.
6153 * ftfont.c (ftfont_spec_pattern):
6154 * keymap.c (access_keymap, silly_event_symbol_error):
6155 XUINT -> XFASTINT, since the integer must be nonnegative.
6156 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6157 since it makes no difference and we prefer signed.
6158 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6159 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6162 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6164 * window.h (Fwindow_frame): Declare.
6166 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6168 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6169 (SPARE_MEMORY): Always define.
6170 (LARGE_REQUEST): Remove.
6171 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6173 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6175 * lisp.h: Move EXFUNS for Fframe_root_window,
6176 Fframe_first_window and Fset_frame_selected_window to window.h.
6178 * window.h: Move EXFUNS for Fframe_root_window,
6179 Fframe_first_window and Fset_frame_selected_window here from
6182 * frame.c (Fwindow_frame, Fframe_first_window)
6183 (Fframe_root_window, Fframe_selected_window)
6184 (Fset_frame_selected_window): Move to window.c.
6185 (Factive_minibuffer_window): Move to minibuf.c.
6186 (Fother_visible_frames_p): New function.
6188 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6190 * window.c (decode_window, decode_any_window): Move up in code.
6191 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6192 (inhibit_frame_unsplittable): Remove unused variable.
6193 (Fwindow_buffer): Move up and rewrite doc-string.
6194 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6195 (Fwindow_prev): New functions.
6196 (Fwindow_frame): Move here from frame.c. Accept any window as
6198 (Fframe_root_window, Fframe_first_window)
6199 (Fframe_selected_window): Move here from frame.c. Accept frame
6200 or arbitrary window as argument. Update doc-strings.
6201 (Fminibuffer_window): Move up in code.
6202 (Fwindow_minibuffer_p): Move up in code and simplify.
6203 (Fset_frame_selected_window): Move here from frame.c.
6205 (Fselected_window, select_window, Fselect_window): Move up in
6206 code. Minor doc-string fixes.
6208 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6210 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6211 Do not assume that spare memory exists; that assumption is valid
6212 only if SYSTEM_MALLOC.
6213 (LARGE_REQUEST): New macro, so that the issue of large requests
6214 is separated from the issue of spare memory.
6216 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6218 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6221 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6223 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6226 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6228 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6230 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6232 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6233 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6235 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6237 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6239 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6241 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6242 (x_clipboard_manager_save): Add return value.
6243 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6245 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6246 Obey Vx_select_enable_clipboard_manager. Catch errors in
6247 x_clipboard_manager_save (Bug#8779).
6248 (Vx_select_enable_clipboard_manager): New variable.
6249 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6251 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6253 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6255 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6257 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6258 in the current matrix if keep_current_p is non-zero.
6260 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6262 * bidi.c (bidi_level_of_next_char): Fix last change.
6264 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6266 Support bidi reordering of text covered by display properties.
6268 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6269 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6270 (bidi_cache_search, bidi_cache_iterator_state)
6271 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6272 (bidi_level_of_next_char, bidi_move_to_visually_next):
6273 Support character positions inside a run of characters covered by a
6275 (bidi_paragraph_init, bidi_resolve_explicit_1)
6276 (bidi_level_of_next_char): Call bidi_fetch_char and
6277 bidi_fetch_char_advance instead of FETCH_CHAR and
6279 (bidi_init_it): Initialize new members.
6280 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6282 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6283 instead of using explicit *_CHAR codes.
6284 (bidi_resolve_explicit, bidi_resolve_weak):
6285 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6286 bidirectional text is supported only in multibyte buffers.
6287 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6288 it to initialize the frame_window_p member of struct bidi_it.
6289 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6290 (bidi_resolve_explicit, bidi_resolve_weak)
6291 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6292 bidi_it->nchars is non-positive.
6293 (bidi_level_of_next_char): Don't try to lookup the cache for the
6294 next/previous character if nothing is cached there yet, or if we
6295 were just reseat()'ed to a new position.
6297 * xdisp.c (set_cursor_from_row): Set start and stop points
6298 according to the row's direction when priming the loop that looks
6299 for the glyph on which to display cursor.
6300 (single_display_spec_intangible_p): Function deleted.
6301 (display_prop_intangible_p): Reimplement to call
6302 handle_display_spec instead of single_display_spec_intangible_p.
6303 Accept 3 additional arguments needed by handle_display_spec.
6304 This fixes incorrect cursor motion across display property with complex
6305 values: lists, `(when COND...)' forms, etc.
6306 (single_display_spec_string_p): Support property values that are
6307 lists with the argument STRING its top-level element.
6308 (display_prop_string_p): Fix the condition for processing a
6309 property that is a list to be consistent with handle_display_spec.
6310 (handle_display_spec): New function, refactored from the
6311 last portion of handle_display_prop.
6312 (compute_display_string_pos): Accept additional argument
6313 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6314 value of a `display' property is a "replacing spec".
6315 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6316 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6317 the display property, but just return a value indicating whether
6318 the display property will replace the characters it covers.
6319 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6320 frame_window_p members of struct bidi_it.
6321 (compute_display_string_pos, compute_display_string_end):
6323 (push_it): Accept second argument POSITION, where pop_it should
6324 jump to continue iteration.
6325 (reseat_1): Initialize bidi_it.disp_pos.
6327 * keyboard.c (adjust_point_for_property): Adjust the call to
6328 display_prop_intangible_p to its new signature.
6330 * dispextern.h (struct bidi_it): New member frame_window_p.
6331 (bidi_init_it): Update prototypes.
6332 (display_prop_intangible_p): Update prototype.
6333 (compute_display_string_pos, compute_display_string_end):
6335 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6338 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6340 Malloc failure behavior now depends on size of allocation.
6341 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6342 * lisp.h: Change signatures accordingly.
6343 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6344 All callers changed. (Bug#8762)
6346 * gnutls.c: Use Emacs's memory allocators.
6347 Without this change, the gnutls library would invoke malloc etc.
6348 directly, which causes problems on non-SYNC_INPUT hosts, and which
6349 runs afoul of improving memory_full behavior. (Bug#8761)
6350 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6351 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6352 xfree instead of the default malloc, realloc, free.
6353 (Fgnutls_boot): No need to check for memory allocation failure,
6354 since xmalloc does that for us.
6356 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6357 * category.c (hash_get_category_set):
6358 * ccl.c (ccl_driver):
6359 * charset.c (Fdefine_charset_internal):
6360 * charset.h (struct charset.hash_index):
6361 * composite.c (get_composition_id, gstring_lookup_cache)
6362 (composition_gstring_put_cache):
6363 * composite.h (struct composition.hash_index):
6364 * dispextern.h (struct image.hash):
6365 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6366 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6367 (hashfn_equal, hashfn_user_defined, make_hash_table)
6368 (maybe_resize_hash_table, hash_lookup, hash_put)
6369 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6370 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6371 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6372 * image.c (make_image, search_image_cache, lookup_image)
6373 (xpm_put_color_table_h):
6374 * lisp.h (struct Lisp_Hash_Table):
6375 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6376 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6377 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6378 * alloc.c (allocate_vectorlike):
6379 Check for overflow in vector size calculations.
6380 * ccl.c (ccl_driver):
6381 Check for overflow when converting EMACS_INT to int.
6382 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6383 need to be updated by these changes.
6384 * fns.c (make_hash_table, maybe_resize_hash_table):
6385 Check for integer overflow with large hash tables.
6386 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6387 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6388 (SXHASH_REDUCE): New macro.
6389 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6390 Use it instead of discarding useful hash info with large hash values.
6391 (sxhash_float): New function.
6392 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6393 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6394 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6395 Rewrite to use FIXNUM_BITS, as this simplifies things.
6396 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6397 Adjust signatures to match updated version of code.
6398 (consing_since_gc): Now EMACS_INT, since a single hash table can
6399 use more than INT_MAX bytes.
6401 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6403 Make it possible to build with GCC-4.6+ -O2 -flto.
6405 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6407 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6409 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6410 Call minibuffer-inactive-mode.
6412 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6414 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6415 Update dependencies.
6417 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6419 * data.c (init_data): Remove code for UTS, this system is not
6422 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6424 Don't force ./temacs to start in terminal mode.
6426 * frame.c (make_initial_frame): Initialize faces in all cases, not
6427 only when CANNOT_DUMP is defined.
6428 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6430 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6432 * dispnew.c (add_window_display_history): Use const for the string
6433 pointer. Remove declaration, not needed.
6435 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6437 Use 'inline', not 'INLINE'.
6438 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6439 * alloc.c, fontset.c (INLINE): Remove.
6440 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6441 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6442 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6443 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6444 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6446 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6448 Make it possible to run ./temacs.
6450 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6451 syms_of_callproc does the same thing. Remove test for
6452 "initialized", do it in the caller.
6453 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6455 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6457 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6458 (read_minibuf): Use get_minibuffer.
6459 (syms_of_minibuf): Use DEFSYM.
6460 (Qmetadata): New var.
6461 * data.c (Qbuffer): Don't make it static.
6462 (syms_of_data): Use DEFSYM.
6464 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6466 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6467 (CCL_CODE_MIN): New macro.
6469 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6471 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6473 * eval.c (Qdebug): Now static.
6474 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6475 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6476 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6478 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6480 * image.c: Various fixes to ImageMagick code comments.
6481 (Fimagemagick_types): Doc fix.
6483 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6485 Minor fixes prompted by GCC 4.6.0 warnings.
6487 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6489 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6490 (x_clipboard_manager_save_all): Move extern decl to ...
6491 * xterm.h: ... here, so that it can be checked for consistency.
6493 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6495 * xselect.c (x_clipboard_manager_save_frame)
6496 (x_clipboard_manager_save_all): New functions.
6497 (Fx_clipboard_manager_save): Lisp function deleted.
6499 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6500 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6502 * xterm.h: Update prototype.
6504 2011-05-28 William Xu <william.xwl@gmail.com>
6506 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6509 2011-05-28 Jim Meyering <meyering@redhat.com>
6511 Avoid a sign-extension bug in crypto_hash_function.
6512 * fns.c (to_uchar): Define.
6513 (crypto_hash_function): Use it to convert some newly-signed
6514 variables to unsigned, to avoid sign-extension bugs. For example,
6515 without this change, (md5 "truc") would evaluate to
6516 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6517 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6518 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6520 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6522 Integer overflow fixes.
6524 * dbusbind.c: Serial number integer overflow fixes.
6525 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6526 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6527 to hold a serial number that is too large for a fixnum.
6528 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6529 Check for serial numbers out of range. Decode any serial number
6530 that was so large that it became a float. (Bug#8722)
6532 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6533 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6534 Use XFASTINT rather than XUINT when numbers are nonnegative.
6535 (xd_append_arg, Fdbus_method_return_internal):
6536 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6537 arguments, check that Lisp number is nonnegative, rather than
6538 silently wrapping negative numbers around. (Bug#8722)
6539 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6542 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6544 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6546 ccl: Add integer overflow checks.
6547 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6548 (IN_INT_RANGE): New macros.
6549 (ccl_driver): Use them to check for integer overflow when
6550 decoding a CCL program. Many of the new checks are whether XINT (x)
6551 fits in int; it doesn't always, on 64-bit hosts. The new version
6552 doesn't catch all possible integer overflows, but it's an
6553 improvement. (Bug#8719)
6555 * alloc.c (make_event_array): Use XINT, not XUINT.
6556 There's no need for unsigned here.
6558 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6559 This follows up to the 2011-05-06 change that substituted uintptr_t
6560 for EMACS_INT. This case wasn't caught back then.
6562 Rework Fformat to avoid integer overflow issues.
6563 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6564 now (part of C89). Include <verify.h>.
6565 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6566 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6567 (Fformat): Avoid the prepass trying to compute sizes; it was only
6568 approximate and thus did not catch overflow reliably. Instead, walk
6569 through the format just once, formatting and computing sizes as we go,
6570 checking for integer overflow at every step, and allocating a larger
6571 buffer as needed. Keep track separately whether the format is
6572 multibyte. Keep only the most-recently calculated precision, rather
6573 than them all. Record whether each argument has been converted to
6574 string. Use EMACS_INT, not int, for byte and char and arg counts.
6575 Support field widths and precisions larger than INT_MAX. Avoid
6576 sprintf's undefined behavior with conversion specifications such as %#d
6577 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6578 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6579 formatting out-of-range floating point numbers with int
6582 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6584 * data.c: Avoid integer truncation in expressions involving floats.
6585 * data.c: Include <intprops.h>.
6586 (arith_driver): When there's an integer overflow in an expression
6587 involving floating point, convert the integers to floating point
6588 so that the resulting value does not suffer from catastrophic
6589 integer truncation. For example, on a 64-bit host (* 4
6590 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6591 Do not rely on undefined behavior after integer overflow.
6593 merge count_size_as_multibyte, parse_str_to_multibyte
6594 * character.c, character.h (count_size_as_multibyte):
6595 Rename from parse_str_to_multibyte; all uses changed.
6596 Check for integer overflow.
6597 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6598 since it's now a duplicate of the other. This is more of
6599 a character than a buffer op, so better that it's in character.c.
6600 * fns.c, print.c: Adjust to above changes.
6602 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6604 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6606 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6608 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6609 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6610 (x_clipboard_manager_save): Now static.
6611 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6613 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6614 (crypto_hash_function): Now static.
6615 Fix pointer signedness problems. Avoid unnecessary initializations.
6617 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6619 * termhooks.h (Vselection_alist): Make it terminal-local.
6621 * terminal.c (create_terminal): Initialize it.
6623 * xselect.c: Support for clipboard managers.
6624 (Vselection_alist): Move to termhooks.h as terminal-local var.
6625 (LOCAL_SELECTION): New macro.
6626 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6627 (symbol_to_x_atom): Remove gratuitous arg.
6628 (x_handle_selection_request, lisp_data_to_selection_data)
6629 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6630 (x_own_selection, x_get_local_selection, x_convert_selection):
6631 New arg, specifying work frame. Use terminal-local Vselection_alist.
6632 (some_frame_on_display): Delete unused function.
6633 (Fx_own_selection_internal, Fx_get_selection_internal)
6634 (Fx_disown_selection_internal, Fx_selection_owner_p)
6635 (Fx_selection_exists_p): New optional frame arg.
6636 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6637 (x_handle_selection_clear): Don't treat other terminals with the
6638 same keyboard specially. Use the terminal-local Vselection_alist.
6639 (x_clear_frame_selections): Use Frun_hook_with_args.
6641 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6643 * xterm.h: Add support for those atoms.
6645 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6647 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6648 (converted_selections, conversion_fail_tag): New global variables.
6649 (x_selection_request_lisp_error): Free the above.
6650 (x_get_local_selection): Remove unnecessary code.
6651 (x_reply_selection_request): Args changed; handle arbitrary array
6652 of converted selections stored in converted_selections.
6653 Separate the XChangeProperty and SelectionNotify steps.
6654 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6655 (x_convert_selection): New function.
6656 (x_handle_selection_event): Simplify.
6657 (x_get_foreign_selection): Don't ignore incoming requests while
6658 waiting for an answer; this will fail when we implement
6659 SAVE_TARGETS, and seems unnecessary anyway.
6660 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6661 (Vx_sent_selection_functions): Doc fix.
6663 2011-05-26 Leo Liu <sdl.web@gmail.com>
6665 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6667 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6669 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6671 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6672 for fringe update if it has periodic bitmap.
6673 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6674 and fringe_bitmap_periodic_p.
6676 * fringe.c (get_fringe_bitmap_data): New function.
6677 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6678 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6679 row. Mark glyph row for fringe update if periodicity changed.
6681 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6682 for fringe update unless it has periodic bitmap.
6684 2011-05-25 Kenichi Handa <handa@m17n.org>
6686 * xdisp.c (get_next_display_element): Set correct it->face_id for
6687 a static composition.
6689 2011-05-24 Leo Liu <sdl.web@gmail.com>
6692 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6694 * fns.c (crypto_hash_function, Fsha1): New function.
6695 (Fmd5): Use crypto_hash_function.
6696 (syms_of_fns): Add Ssha1.
6698 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6700 * gnutls.c: Remove unused macros.
6701 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6702 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6703 Remove macros that are defined and never used.
6704 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6706 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6708 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6709 (Fx_get_selection_internal): Minor cleanup.
6710 (Fx_own_selection_internal): Rename arguments for consistency with
6713 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6715 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6717 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6719 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6721 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6723 * dispnew.c (scrolling_window): Don't exclude the case that the
6724 last enabled row in the desired matrix touches the bottom boundary.
6726 2011-05-21 Glenn Morris <rgm@gnu.org>
6728 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6729 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6730 and add some more files.
6732 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6734 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6735 report_file_error introduced by the change from 2011-05-07.
6737 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6739 * systime.h (Time): Define only if emacs is defined.
6740 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6741 where the include path doesn't have X11/X.h by default. See
6742 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6744 2011-05-20 Kenichi Handa <handa@m17n.org>
6746 * composite.c (find_automatic_composition): Fix previous change.
6748 2011-05-20 Glenn Morris <rgm@gnu.org>
6750 * lisp.mk: New file, split from Makefile.in.
6751 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6752 (shortlisp): Remove.
6753 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6755 2011-05-19 Glenn Morris <rgm@gnu.org>
6757 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6758 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6759 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6760 (lisp): Set the order to that of loadup.el.
6761 (shortlisp): Make it a copy of $lisp.
6762 (SOME_MACHINE_LISP): Remove.
6763 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6764 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6766 2011-05-18 Kenichi Handa <handa@m17n.org>
6768 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6769 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6770 (find_automatic_composition): Mostly rewrite for efficiency.
6772 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6774 * makefile.w32-in: Update dependencies.
6776 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6778 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6779 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6781 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6783 Fix some integer overflow issues, such as string length overflow.
6785 * insdel.c (count_size_as_multibyte): Check for string overflow.
6787 * character.c (lisp_string_width): Check for string overflow.
6788 Use EMACS_INT, not int, for string indexes and lengths; in
6789 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6790 the resulting string length overflows an EMACS_INT; instead,
6791 report a string overflow if no precision given. When checking for
6792 precision exhaustion, use a check that cannot possibly have
6793 integer overflow. (Bug#8675)
6794 * character.h (lisp_string_width): Adjust to new signature.
6796 * alloc.c (string_overflow): New function.
6797 (Fmake_string): Use it. This doesn't change behavior, but saves
6798 a few bytes and will simplify future changes.
6799 * character.c (string_escape_byte8): Likewise.
6800 * lisp.h (string_overflow): New decl.
6802 Fixups, following up to the user-interface timestamp change.
6803 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6804 for UI timestamps, instead of unsigned long.
6805 * msdos.c (mouse_get_pos): Likewise.
6806 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6807 * w32gui.h (Time): Define by including "systime.h" rather than by
6808 declaring it ourselves. (Bug#8664)
6810 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6811 * image.c (clear_image_cache): Likewise.
6813 * term.c (term_mouse_position): Don't assume time_t wraparound.
6815 Be more systematic about user-interface timestamps.
6816 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6817 and sometimes 'EMACS_UINT', to represent these timestamps.
6818 This change causes it to use 'Time' uniformly, as that's what X uses.
6819 This makes the code easier to follow, and makes it easier to catch
6820 integer overflow bugs such as Bug#8664.
6821 * frame.c (Fmouse_position, Fmouse_pixel_position):
6822 Use Time, not unsigned long, for user-interface timestamps.
6823 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6824 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6825 * keyboard.h (last_event_timestamp): Likewise.
6826 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6827 * menu.h (xmenu_show): Likewise.
6828 * term.c (term_mouse_position): Likewise.
6829 * termhooks.h (struct input_event.timestamp): Likewise.
6830 (struct terminal.mouse_position_hook): Likewise.
6831 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6832 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6833 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6834 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6836 * menu.h, termhooks.h: Include "systime.h", for Time.
6838 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6839 Don't assume that the difference between two unsigned long values
6840 can fit into an integer. At this point, we know button_down_time
6841 <= event->timestamp, so the difference must be nonnegative, so
6842 there's no need to cast the result if double-click-time is
6843 nonnegative, as it should be; check that it's nonnegative, just in
6844 case. This bug is triggered when events are more than 2**31 ms
6845 apart (about 25 days). (Bug#8664)
6847 * xselect.c (last_event_timestamp): Remove duplicate decl.
6848 (x_own_selection): Remove needless cast to unsigned long.
6850 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6851 that always fit in int. Use a sentinel instead of a counter, to
6852 avoid a temp and to allay GCC's concerns about possible int overflow.
6853 * frame.h (struct frame): Use int for menu_bar_items_used
6854 instead of EMACS_INT, since it always fits in int.
6856 * menu.c (grow_menu_items): Check for int overflow.
6858 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6860 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6861 Before, the code was not consistent. These values cannot exceed
6862 2**31 - 1 so there's no need to make them unsigned.
6863 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6864 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6865 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6867 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6869 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6870 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6871 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6872 presumably because the widths might not match.
6874 * window.c (size_window): Avoid needless test at loop start.
6876 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6878 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6880 2011-05-12 Drew Adams <drew.adams@oracle.com>
6882 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6884 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6886 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6887 `width' to `bar_area_x' and `bar_area_width', respectively.
6888 (x_scroll_run): Take account of fringe background extension.
6890 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6891 Rename local vars `left' and `width' to `bar_area_x' and
6892 `bar_area_width', respectively.
6893 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6894 background extension.
6896 2011-05-10 Jim Meyering <meyering@redhat.com>
6898 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6900 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6902 * image.c (Finit_image_library): Return t for built-in image types,
6903 like pbm and xbm. (Bug#8640)
6905 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6907 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6909 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6911 * w32console.c (Fset_screen_color): Doc fix.
6912 (Fget_screen_color): New function.
6913 (syms_of_ntterm): Defsubr it.
6915 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6916 unlink the temporary file if Fcall_process didn't create it in the
6918 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6919 child process will be redirected to a file specified with `:file'.
6920 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6921 cue to call_process_cleanup not to close that handle.
6923 2011-05-07 Ben Key <bkey76@gmail.com>
6925 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6926 one of two shell specific rules, either bootstrap-temacs-CMD or
6927 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6928 to the previous implementation of the bootstrap-temacs rule.
6929 The bootstrap-temacs-CMD rule is similar to the previous
6930 implementation of the bootstrap-temacs rule except that it
6931 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6934 These changes, along with some changes to nt/configure.bat,
6935 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6936 earlier fix to add support for --cflags and --ldflags options
6937 that include quotes so that it works whether make uses cmd or
6940 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6942 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6943 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6945 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6946 a string. Handle both cases.
6947 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6948 (Fdbus_register_method): Use Qinvalid_function.
6950 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6952 * makefile.w32-in: Update dependencies.
6953 (LISP_H): Add inttypes.h and stdin.h.
6954 (PROCESS_H): Add unistd.h.
6956 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6958 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6959 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6961 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6963 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6965 * term.c (vfatal): Remove stray call to va_end.
6966 It's not needed and the C Standard doesn't allow it here anyway.
6968 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6969 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6971 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6974 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6976 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6978 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6980 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6982 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6984 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6985 * charset.c (Fdefine_charset_internal): Don't initialize
6986 charset.code_space[15]. The value was garbage, on hosts with
6987 32-bit int (Bug#8600).
6989 * lread.c (read_integer): Be more consistent with string-to-number.
6990 Use string_to_number to do the actual conversion; this avoids
6991 rounding errors and fixes some other screwups. Without this fix,
6992 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6993 (digit_to_number): Move earlier, for benefit of read_integer.
6994 Return -1 if the digit is out of range for the base, -2 if it is
6995 not a digit in any supported base. (Bug#8602)
6997 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6999 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7000 to match comment at start of function. This also removes a
7001 GCC warning about overflow in a 32+64-bit port.
7003 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7005 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7006 Reported by Stefan Monnier in
7007 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7008 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7009 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7011 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7012 (EMACS_UINTPTR): Likewise, with uintptr_t.
7014 * lisp.h: Prefer 64-bit EMACS_INT if available.
7015 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7016 on 32-bit hosts that have 64-bit int, so that they can access
7018 However, temporarily disable this change unless the temporary
7019 symbol WIDE_EMACS_INT is defined.
7021 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7023 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7024 This removes an assumption that EMACS_INT and long are the same
7025 width as pointers. The assumption is true for Emacs porting targets
7026 now, but we want to make other targets possible.
7027 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7028 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7029 In the rest of the code, change types of integers that hold casted
7030 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7031 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7032 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7033 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7034 No need to cast type when ORing.
7035 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7036 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7037 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7038 assume EMACS_INT is the same width as char *.
7039 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7040 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7041 Remove no-longer-needed casts.
7042 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7043 (xg_tool_bar_help_callback, xg_make_tool_item):
7044 Use EMACS_INTPTR to hold an integer
7045 that will be cast to void *; this can avoid a GCC warning
7046 if EMACS_INT is not the same width as void *.
7047 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7048 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7049 (current_message_1, set_message_1):
7050 Use a local to convert to proper width without a cast.
7051 * xmenu.c (dialog_selection_callback): Likewise.
7053 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7054 Also, don't assume VALBITS / RAND_BITS is less than 5,
7055 and don't rely on undefined behavior when shifting a 1 left into
7057 * lisp.h (get_random): Change signature to match.
7059 * lread.c (hash_string): Use size_t, not int, for hash computation.
7060 Normally we prefer signed values; but hashing is special, because
7061 it's better to use unsigned division on hash table sizes so that
7062 the remainder is nonnegative. Also, size_t is the natural width
7063 for hashing into memory. The previous code used 'int', which doesn't
7064 retain enough info to hash well into very large tables.
7065 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7067 * dbusbind.c: Don't possibly lose pointer info when converting.
7068 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7069 Use XPNTR rather than XHASH, so that the high-order bits of
7070 the pointer aren't lost when converting through void *.
7072 * eval.c (Fautoload): Don't double-shift a pointer.
7074 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7076 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7078 * gnutls.c (DEF_GNUTLS_FN):
7079 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7081 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7083 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7086 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7088 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7089 New version that can reserve upto 2GB of heap space.
7091 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7093 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7095 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7097 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7098 `gnutls_certificate_set_x509_key_file'.
7100 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7102 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7103 Update dependencies.
7105 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7107 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7108 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7109 Remove unused parameter `fildes'.
7110 * process.c (read_process_output, send_process): Don't pass it.
7112 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7114 Fix previous change: the library cache is defined in w32.c.
7115 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7116 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7118 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7120 Implement dynamic loading of GnuTLS on Windows.
7122 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7123 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7124 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7127 * gnutls.c (Qgnutls_dll): Define.
7128 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7129 (gnutls_*): Declare function pointers.
7130 (init_gnutls_functions): New function to initialize function pointers.
7131 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7132 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7133 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7134 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7135 (emacs_gnutls_write, emacs_gnutls_read)
7136 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7137 (Fgnutls_available_p): New function.
7138 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7139 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7140 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7142 * image.c: Include w32.h.
7143 (Vimage_type_cache): Delete.
7144 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7145 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7146 (w32_delayed_load): Move to w32.c.
7148 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7150 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7151 (w32_delayed_load): Move from image.c. When loading a library, record
7152 its filename in the :loaded-from property of the library id.
7153 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7154 Initialize and staticpro them.
7155 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7157 * process.c: Include lisp.h before w32.h, not after.
7158 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7159 instead of gnutls_record_check_pending.
7161 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7163 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7165 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7166 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7169 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7171 * xterm.c (x_set_frame_alpha): Do not set property on anything
7172 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7174 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7176 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7178 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7180 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7181 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7182 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7183 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7184 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7185 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7186 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7187 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7188 (Qgnutls_bootprop_callbacks_verify): Make static.
7190 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7192 * callproc.c: Indentation fixup.
7194 * sysdep.c (wait_for_termination_1): Make static.
7195 (wait_for_termination, interruptible_wait_for_termination):
7196 Move after wait_for_termination_1.
7198 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7200 * sysdep.c (interruptible_wait_for_termination): New function
7201 which is like wait_for_termination, but allows keyboard
7204 * callproc.c (Fcall_process): Add (:file "file") as an option for
7206 (Fcall_process_region): Ditto.
7208 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7210 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7211 rather than `XVECTOR (FOO)->size'.
7213 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7214 inttypes.h, as a gnulib replacement is used if it not available in
7217 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7219 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7220 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7221 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7223 * coding.c (coding_alloc_by_realloc): Error out if destination
7224 will grow beyond MOST_POSITIVE_FIXNUM.
7225 (decode_coding_emacs_mule): Abort if there isn't enough place in
7226 charbuf for the composition carryover bytes. Reserve an extra
7227 space for up to 2 characters produced in a loop.
7228 (decode_coding_iso_2022): Abort if there isn't enough place in
7229 charbuf for the composition carryover bytes.
7231 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7233 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7234 aborting when %lld or %lll format is passed.
7235 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7236 %llo or %llx format is passed. (Bug#8545)
7238 * window.c (window_scroll_line_based): Use a marker instead of
7239 simple variables to record original value of point. (Bug#7952)
7241 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7242 produced by %s or %c overflows available buffer space. (Bug#8545)
7244 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7246 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7247 (SIZE_MAX): Move defn after all includes, as they might #define it.
7249 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7251 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7253 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7255 * keyboard.c (Qdelayed_warnings_hook): Define.
7256 (command_loop_1): Run `delayed-warnings-hook'
7257 if Vdelayed_warnings_list is non-nil.
7258 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7259 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7261 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7263 * doprnt.c (doprnt): Don't return value smaller than the buffer
7264 size if the message was truncated. (Bug#8545).
7266 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7268 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7269 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7271 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7273 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7275 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7277 * makefile.w32-in: Update dependencies.
7279 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7281 Improve `doprnt' and its usage. (Bug#8545)
7282 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7283 `format_end'. Remove support for %l as a conversion specifier.
7284 Don't use xrealloc. Improve diagnostics when the %l size modifier
7285 is used. Update the commentary.
7287 * eval.c (verror): Simplify calculation of size_t.
7289 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7292 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7294 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7297 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7299 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7300 This makes this file independent of the recent pseudovector change.
7302 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7304 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7306 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7307 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7308 Remove unused local.
7309 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7311 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7312 GCC 4.6.0 optimizes based on type-based alias analysis.
7313 For example, if b is of type struct buffer * and v of type struct
7314 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7315 != &v->size, and therefore "v->size = 1; b->size = 2; return
7316 v->size;" must therefore return 1. This assumption is incorrect
7317 for Emacs, since it type-puns struct Lisp_Vector * with many other
7318 types. To fix this problem, this patch adds a new type struct
7319 vectorlike_header that documents the constraints on layout of vectors
7320 and pseudovectors, and helps optimizing compilers not get fooled
7321 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7322 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7323 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7325 (XSETPVECTYPE): Rewrite in terms of new macro.
7326 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7327 This is a bit clearer, and further avoids the possibility of
7328 undesirable aliasing.
7329 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7330 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7331 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7332 since Lisp_Subr is a special case (no "next" field).
7333 (ASIZE): Now uses header.size rather than size.
7334 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7335 to avoid the hassle of writing XVECTOR (foo)->header.size.
7336 (struct vectorlike_header): New type.
7337 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7338 object, to help avoid aliasing.
7339 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7340 (SUBRP): Likewise, since Lisp_Subr is a special case.
7341 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7342 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7343 (struct Lisp_Hash_Table): Combine first two members into a single
7344 struct vectorlike_header member. All uses of "size" and "next" members
7345 changed to be "header.size" and "header.next".
7346 * buffer.h (struct buffer): Likewise.
7347 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7348 * frame.h (struct frame): Likewise.
7349 * process.h (struct Lisp_Process): Likewise.
7350 * termhooks.h (struct terminal): Likewise.
7351 * window.c (struct save_window_data, struct saved_window): Likewise.
7352 * window.h (struct window): Likewise.
7353 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7354 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7355 * buffer.c (init_buffer_once): Likewise.
7356 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7358 * process.c (Fformat_network_address): Use local var for size,
7361 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7363 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7364 * data.c (atof): Remove decl; no longer used or needed.
7365 (digit_to_number): Move to lread.c.
7366 (Fstring_to_number): Use new string_to_number function, to be
7367 consistent with how the Lisp reader treats infinities and NaNs.
7368 Do not assume that floating-point numbers represent EMACS_INT
7369 without losing information; this is not true on most 64-bit hosts.
7370 Avoid double-rounding errors, by insisting on integers when
7371 parsing non-base-10 numbers, as the documentation specifies.
7372 * lisp.h (string_to_number): New decl, replacing ...
7373 (isfloat_string): Remove.
7374 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7375 (read1): Do not accept +. and -. as integers; this
7376 appears to have been a coding error. Similarly, do not accept
7377 strings like +-1e0 as floating point numbers. Do not report
7378 overflow for integer overflows unless the base is not 10 which
7379 means we have no simple and reliable way to continue.
7380 Break out the floating-point parsing into a new
7381 function string_to_number, so that Fstring_to_number parses
7382 floating point numbers consistently with the Lisp reader.
7383 (digit_to_number): Move here from data.c. Make it static inline.
7384 (E_CHAR, EXP_INT): Remove, replacing with ...
7385 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7386 (string_to_number): New function, replacing isfloat_string.
7387 This function checks for valid syntax and produces the resulting
7388 Lisp float number too. Rework it so that string-to-number
7389 no longer mishandles examples like "1.0e+". Use strtoumax,
7390 so that overflow for non-base-10 numbers is reported only when
7391 there's no portable and simple way to convert to floating point.
7393 * textprop.c (set_text_properties_1): Rewrite for clarity,
7394 and to avoid GCC warning about integer overflow.
7396 * intervals.h (struct interval): Use EMACS_INT for members
7397 where EMACS_UINT might cause problems. See
7398 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7399 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7400 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7402 (offset_intervals): Tell GCC not to worry about length overflow
7403 when negating a negative length.
7405 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7406 (overrun_check_free): Likewise.
7408 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7409 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7412 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7413 (gnutls_make_error): Rename local to avoid shadowing.
7414 (gnutls_emacs_global_deinit): ifdef out; not used.
7415 (Fgnutls_boot): Use const for pointer to readonly storage.
7416 Comment out unused local. Fix pointer signedness problems.
7418 * lread.c (openp): Don't stuff size_t into an 'int'.
7419 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7420 about possible signed overflow.
7422 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7423 (GDK_KEY_g): Don't define if already defined.
7424 (xg_prepare_tooltip): Avoid pointer signedness problem.
7425 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7427 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7428 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7430 * xfns.c (Fx_window_property): Simplify a bit,
7431 to make a bit faster and to avoid GCC 4.6.0 warning.
7432 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7434 * fns.c (internal_equal): Don't assume size_t fits in int.
7436 * alloc.c (compact_small_strings): Tighten assertion a little.
7438 Replace pEd with more-general pI, and fix some printf arg casts.
7439 * lisp.h (pI): New macro, generalizing old pEd macro to other
7440 conversion specifiers. For example, use "...%"pI"d..." rather
7441 than "...%"pEd"...".
7442 (pEd): Remove. All uses replaced with similar uses of pI.
7443 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7444 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7445 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7446 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7447 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7448 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7449 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7451 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7452 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7453 * print.c (safe_debug_print, print_object): Likewise.
7454 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7456 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7457 avoiding the 0 flag, which is not portable.
7458 * process.c (Fmake_network_process): Use pI to avoid cast.
7459 * region-cache.c (pp_cache): Likewise.
7460 * xdisp.c (decode_mode_spec): Likewise.
7461 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7462 behavior on 64-bit hosts with printf arg.
7463 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7464 (x_stop_queuing_selection_requests): Likewise.
7465 (x_get_window_property): Don't truncate byte count to an 'int'
7468 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7469 here, since it parses constructs like leading '-' and spaces,
7470 which are not wanted; and it overflows with large numbers.
7471 Instead, simply match F[0-9]+, which is what is wanted anyway.
7473 * alloc.c: Remove unportable assumptions about struct layout.
7474 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7475 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7476 (allocate_vectorlike, make_pure_vector): Use the new macros,
7477 plus offsetof, to remove unportable assumptions about struct layout.
7478 These assumptions hold on all porting targets that I know of, but
7479 they are not guaranteed, they're easy to remove, and removing them
7480 makes further changes easier.
7482 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7483 This doesn't fix a bug but makes the code clearer.
7484 (string_overrun_cookie): Now const. Use initializers that
7485 don't formally overflow signed char, to avoid warnings.
7486 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7487 can cause Emacs to crash when string overrun checking is enabled.
7488 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7489 multiple of sizeof (EMACS_INT); it need not be, if
7490 alignof(EMACS_INT) < sizeof (EMACS_INT).
7491 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7493 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7495 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7497 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7499 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7500 supposed to be handshaking. (Bug#8556)
7501 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7503 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7505 * lisp.h (Qdebug): List symbol.
7506 * eval.c (Qdebug): Restore global linkage.
7507 * keyboard.c (debug-on-event): New variable.
7508 (handle_user_signal): Break into debugger when debug-on-event
7509 matches the current signal symbol.
7511 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7513 * alloc.c (check_sblock, check_string_bytes)
7514 (check_string_free_list): Convert to standard C.
7516 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7518 * w32.c (emacs_gnutls_push): Fix typo.
7520 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7522 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7523 "cast to pointer from integer of different size".
7525 Improve doprnt and its use in verror. (Bug#8545)
7526 * doprnt.c (doprnt): Document the set of format control sequences
7527 supported by the function. Use SAFE_ALLOCA instead of always
7530 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7531 is one byte too soon. Don't use xrealloc; instead xfree and
7534 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7536 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7539 * gnutls.c: Renamed global_initialized to
7540 gnutls_global_initialized. Added internals for the
7541 :verify-hostname-error, :verify-error, and :verify-flags
7542 parameters of `gnutls-boot' and documented those parameters in the
7543 docstring. Start callback support.
7544 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7545 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7546 on error. Return error code.
7547 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7548 (emacs_gnutls_read): Likewise.
7549 (Fgnutls_boot): Return handshake error code.
7550 (emacs_gnutls_handle_error): New function.
7551 (wsaerror_to_errno): Likewise.
7553 * w32.h (emacs_gnutls_pull): Add prototype.
7554 (emacs_gnutls_push): Likewise.
7556 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7557 (emacs_gnutls_push): Likewise.
7559 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7561 * process.c (wait_reading_process_output): Check if GnuTLS
7562 buffered some data internally if no FDs are set for TLS
7565 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7566 (LIBS): Link to USER_LIBS.
7567 ($(BLD)/gnutls.$(0)): New target.
7569 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7571 * xdisp.c (handle_single_display_spec): Rename the
7572 display_replaced_before_p argument into display_replaced_p, to
7573 make it consistent with the commentary. Fix typos in the
7576 * textprop.c (syms_of_textprop): Remove dead code.
7577 (copy_text_properties): Delete obsolete commentary about an
7578 interface that was deleted long ago. Fix typos in the description
7581 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7582 to changes in oldXMenu/XMenu.h from 2011-04-16.
7583 <menu_help_message, prev_menu_help_message>: Constify.
7584 (IT_menu_make_room): menu->help_text is now `const char **';
7587 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7588 to changes in oldXMenu/XMenu.h from 2011-04-16.
7589 (struct XMenu): Declare `help_text' `const char **'.
7591 * xfaces.c <Qunspecified>: Make extern again.
7593 * syntax.c: Include sys/types.h before including regex.h, as
7596 * doc.c (get_doc_string): Improve the format passed to `error'.
7598 * doprnt.c (doprnt): Improve commentary.
7600 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7602 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7605 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7606 changes in globals.h immediately force recompilation.
7607 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7608 $(CURDIR)/s/ms-w32.h.
7609 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7611 * character.c (Fchar_direction): Function deleted.
7612 (syms_of_character): Don't defsubr it.
7613 <char-direction-table>: Deleted.
7615 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7617 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7618 * doprnt.c: Include limits.h.
7619 (SIZE_MAX): New macro.
7620 (doprnt): Return a size_t value. 2nd arg is now size_t.
7621 Many local variables are now size_t instead of int or unsigned.
7622 Improve overflow protection. Support `l' modifier for integer
7623 conversions. Support %l conversion. Don't assume an EMACS_INT
7624 argument for integer conversions and for %c.
7626 * lisp.h (doprnt): Restore prototype.
7628 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7631 * Makefile.in (base_obj): Add back doprnt.o.
7633 * deps.mk (doprnt.o): Add back prerequisites.
7634 (callint.o): Depend on character.h.
7636 * eval.c (internal_lisp_condition_case): Include the handler
7637 representation in the error message.
7638 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7639 when breaking from the loop.
7641 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7643 * callint.c (Fcall_interactively): When displaying error message
7644 about invalid control letter, pass the character's codepoint, not
7645 a pointer to its multibyte form. Improve display of the character
7646 in octal and display also its hex code.
7648 * character.c (char_string): Use %x to display the (unsigned)
7649 codepoint of an invalid character, to avoid displaying a bogus
7652 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7653 `error', not SYMBOL_NAME itself.
7655 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7656 character arguments to `error'.
7658 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7659 to `error' in error message about FINAL_CHAR argument. Make sure
7660 FINAL_CHAR is a character, and use %c when it is passed as
7661 argument to `error'.
7663 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7665 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7667 * w32.c: Include <time.h>.
7668 (sys_localtime): New function.
7670 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7672 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7674 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7676 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7678 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7681 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7683 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7684 gl_state.e_property when gl_state.object is Qt.
7686 * insdel.c (make_gap_larger): Remove limitation of buffer size
7689 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7691 * xdisp.c (lookup_glyphless_char_display)
7692 (produce_glyphless_glyph): Handle cons cell entry in
7693 glyphless-char-display.
7694 (Vglyphless_char_display): Document it.
7696 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7697 glyphless-char-display.
7699 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7701 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7703 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7705 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7706 definition for no-X builds.
7708 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7710 Static checks with GCC 4.6.0 and non-default toolkits.
7712 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7714 * process.c (keyboard_bit_set): Define only if SIGIO.
7715 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7716 (send_process): Repair possible setjmp clobbering.
7718 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7720 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7722 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7724 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7725 Define only if needed.
7727 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7728 by pacifying GCC about it. Maybe it's time to retire it?
7729 * xfaces.c (USG, __TIMEVAL__): Likewise.
7731 * dispextern.h (struct redisplay_interface): Rename param
7733 * termhooks.h (struct terminal): Likewise.
7734 * xterm.c (xembed_send_message): Likewise.
7736 * insdel.c (make_gap_smaller): Define only if
7737 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7739 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7742 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7743 so that we aren't warned about unused symbols.
7745 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7747 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7749 * xfns.c (x_real_positions): Mark locals as initialized.
7751 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7753 * xterm.c: Fix problems found by static analysis with other toolkits.
7754 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7755 (x_dispatch_event): Declare static if USE_GTK, and
7756 define if USE_GTK || USE_X_TOOLKIT.
7757 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7758 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7759 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7760 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7762 * xmenu.c (menu_help_callback): Pointer type fixes.
7763 Use const pointers when pointing at readonly data. Avoid pointer
7765 (FALSE): Remove unused macro.
7766 (update_frame_menubar): Remove unused decl.
7768 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7770 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7771 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7772 (single_menu_item): Rename local to avoid shadowing.
7774 * keyboard.c (make_lispy_event): Remove unused local var.
7776 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7777 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7779 * bitmaps: Change bitmaps from unsigned char back to the X11
7780 compatible char. Avoid the old compiler warnings about
7781 out-of-range initializers by using, for example, '\xab' rather
7784 * xgselect.c (xgselect_initialize): Check vs interface
7785 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7787 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7789 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7790 to read-only memory.
7792 * fns.c (vector): Remove; this old hack is no longer needed.
7794 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7796 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7798 * xrdb.c (x_load_resources): Omit unused local.
7800 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7801 (x_window): Rename locals to avoid shadowing.
7802 (USG): Use the kludged USG macro, to pacify gcc.
7804 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7805 (x_term_init): Remove local to avoid shadowing.
7807 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7809 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7810 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7812 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7814 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7816 Fix regex.c, syntax.c and friends for buffers > 2GB.
7817 * syntax.h (struct gl_state_s): Declare character position members
7820 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7822 * textprop.c (verify_interval_modification, interval_of):
7823 Declare arguments EMACS_INT.
7825 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7828 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7830 * indent.c (Fvertical_motion): Local variable it_start is now
7833 * regex.c (re_match, re_match_2, re_match_2_internal)
7834 (bcmp_translate, regcomp, regexec, print_double_string)
7835 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7836 (re_compile_pattern, re_exec): Declare arguments and local
7837 variables `size_t' and `ssize_t' and return values `regoff_t', as
7839 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7840 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7841 <compile_stack_type>: `size' and `avail' are now `size_t'.
7843 * regex.h <regoff_t>: Use ssize_t, not int.
7844 (re_search, re_search_2, re_match, re_match_2): Arguments that
7845 specify buffer/string position and length are now ssize_t and
7846 size_t. Return type is regoff_t.
7848 2011-04-16 Ben Key <bkey76@gmail.com>
7850 * nsfont.m: Fixed bugs in ns_get_family and
7851 ns_descriptor_to_entity that were caused by using free to
7852 deallocate memory blocks that were allocated by xmalloc (via
7853 xstrdup). This caused Emacs to crash when compiled with
7854 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7855 --enable-checking=xmallocoverrun). xfree is now used to
7856 deallocate these memory blocks.
7858 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7860 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7862 emacs_write: Accept and return EMACS_INT for sizes.
7863 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7865 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7866 Accept and return EMACS_INT.
7867 (emacs_gnutls_write): Return the number of bytes written on
7869 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7870 (emacs_read, emacs_write): Remove check for negative size, as the
7871 Emacs source code has been audited now.
7872 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7873 (emacs_read, emacs_write): Use it.
7874 * process.c (send_process): Adjust to the new signatures of
7875 emacs_write and emacs_gnutls_write. Do not attempt to store
7876 a byte offset into an 'int'; it might overflow.
7877 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7879 * sound.c: Don't assume sizes fit in 'int'.
7880 (struct sound_device.period_size, alsa_period_size):
7881 Return EMACS_INT, not int.
7882 (struct sound_device.write, vox_write, alsa_write):
7883 Accept EMACS_INT, not int.
7884 (wav_play, au_play): Use EMACS_INT to store sizes and to
7885 record read return values.
7887 2011-04-15 Ben Key <bkey76@gmail.com>
7889 * keyboard.c (Qundefined): Don't declare static since it is used
7891 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7892 static since they are used in nsfont.m.
7894 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7896 * process.c (Qprocessp): Don't declare static.
7897 * lisp.h (Qprocessp): Declare again.
7899 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7901 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7903 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7905 Improve C-level modularity by making more things 'static'.
7907 Don't publish debugger-only interfaces to other modules.
7908 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7909 (verify_bytepos, count_markers): Move decls to the only modules
7911 * region-cache.h (pp_cache): Likewise.
7912 * window.h (check_all_windows): Likewise.
7913 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7915 * sysdep.c (croak): Now static, if
7916 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7917 * syssignal.h (croak): Declare only if not static.
7919 * alloc.c (refill_memory_reserve): Now static if
7920 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7921 * lisp.h (refill_memory_reserve): Declare only if not static.
7923 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7924 Define only if USE_LUCID.
7926 * xrdb.c (x_customization_string, x_rm_string): Now static.
7928 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7929 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7931 * xdisp.c (draw_row_with_mouse_face): Now static.
7932 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7934 * window.h (check_all_windows): Mark externally visible.
7936 * window.c (window_deletion_count): Now static.
7938 * undo.c: Make symbols static if they're not exported.
7939 (last_undo_buffer, last_boundary_position, pending_boundary):
7942 * textprop.c (interval_insert_behind_hooks): Now static.
7943 (interval_insert_in_front_hooks): Likewise.
7945 * term.c: Make symbols static if they're not exported.
7946 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7947 (max_frame_lines, tty_set_terminal_modes):
7948 (tty_reset_terminal_modes, tty_turn_off_highlight):
7949 (get_tty_terminal): Now static.
7950 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7951 * termhooks.h (term_mouse_moveto): Do not declare if
7953 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7954 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7956 * sysdep.c: Make symbols static if they're not exported.
7957 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7959 (sigprocmask_set, full_mask): Remove; unused.
7960 (wait_debugging): Mark as visible.
7961 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7962 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7964 * syntax.c (syntax_temp): Define only if !__GNUC__.
7966 * sound.c (current_sound_device, current_sound): Now static.
7968 * search.c (searchbufs, searchbuf_head): Now static.
7970 * scroll.c (scroll_cost): Remove; unused.
7971 * dispextern.h (scroll_cost): Remove decl.
7973 * region-cache.h (pp_cache): Mark as externally visible.
7975 * process.c: Make symbols static if they're not exported.
7976 (process_tick, update_tick, create_process, chan_process):
7977 (Vprocess_alist, proc_buffered_char, datagram_access):
7978 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7979 (deactivate_process): Mark defn as static, as well as decl.
7980 * lisp.h (create_process): Remove decl.
7981 * process.h (chan_process, Vprocess_alist): Remove decls.
7983 * print.c: Make symbols static if they're not exported.
7984 (print_depth, new_backquote_output, being_printed, print_buffer):
7985 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7986 (print_interval, print_number_index, initial_stderr_stream):
7988 * lisp.h (Fprinc): Remove decl.
7989 (debug_output_compilation_hack): Mark as externally visible.
7991 * sysdep.c (croak): Move decl from here to syssignal.h.
7992 * syssignal.h (croak): Put it here, so the API can be checked when
7993 'croak' is called from dissociate_if_controlling_tty.
7995 * minibuf.c: Make symbols static if they're not exported.
7996 (minibuf_save_list, choose_minibuf_frame): Now static.
7997 * lisp.h (choose_minibuf_frame): Remove decl.
7999 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8001 * lread.c: Make symbols static if they're not exported.
8002 (read_objects, initial_obarray, oblookup_last_bucket_number):
8004 (make_symbol): Remove; unused.
8005 * lisp.h (initial_obarray, make_symbol): Remove decls.
8007 * keyboard.c: Make symbols static if they're not exported.
8008 (single_kboard, recent_keys_index, total_keys, recent_keys):
8009 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8010 (this_single_command_key_start, echoing, last_auto_save):
8011 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8012 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8013 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8014 (Vlispy_mouse_stem, double_click_count):
8016 (force_auto_save_soon): Define only if SIGDANGER.
8017 (ignore_mouse_drag_p): Now static if
8018 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8019 (print_help): Remove; unused.
8020 (stop_character, last_timer_event): Mark as externally visible.
8021 * keyboard.h (ignore_mouse_drag_p): Declare only if
8022 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8023 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8024 * lisp.h (echoing): Remove decl.
8025 (force_auto_save_soon): Declare only if SIGDANGER.
8026 * xdisp.c (redisplay_window): Simplify code, to make it more
8027 obvious that ignore_mouse_drag_p is not accessed if !defined
8028 USE_GTK && !defined HAVE_NS.
8030 * intervals.c: Make symbols static if they're not exported.
8031 (merge_properties_sticky, merge_interval_right, delete_interval):
8033 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8035 * insdel.c: Make symbols static if they're not exported.
8036 However, leave prepare_to_modify_buffer alone. It's never
8037 called from outside this function, but that appears to be a bug.
8038 (combine_after_change_list, combine_after_change_buffer):
8039 (adjust_after_replace, signal_before_change): Now static.
8040 (adjust_after_replace_noundo): Remove; unused.
8041 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8042 (signal_before_change): Remove decls.
8044 * indent.c (val_compute_motion, val_vmotion): Now static.
8046 * image.c: Make symbols static if they're not exported.
8047 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8049 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8050 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8052 * fringe.c (standard_bitmaps): Now static.
8053 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8055 * frame.c: Make symbols static if they're not exported.
8056 (x_report_frame_params, make_terminal_frame): Now static.
8057 (get_frame_param): Now static, unless HAVE_NS.
8058 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8059 (x_get_resource_string): Remove; not used.
8060 * frame.h (make_terminal_frame, x_report_frame_params):
8061 (x_get_resource_string); Remove decls.
8062 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8063 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8065 * font.c, fontset.c: Make symbols static if they're not exported.
8066 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8067 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8068 * font.c (font_close_object): Now static.
8069 * font.h (font_close_object): Remove.
8070 * fontset.c (FONTSET_OBJLIST): Remove.
8071 (free_realized_fontset) #if-0 the body, which does nothing.
8072 (face_suitable_for_char_p): #if-0, as it's never called.
8073 * fontset.h (face_suitable_for_char_p): Remove decl.
8074 * xfaces.c (face_at_string_position):
8075 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8076 since 0 is always ASCII.
8078 * fns.c (weak_hash_tables): Now static.
8080 * fileio.c: Make symbols static if they're not exported.
8081 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8082 (Vwrite_region_annotation_buffers): Now static.
8084 * eval.c: Make symbols static if they're not exported.
8085 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8086 * lisp.h (backtrace_list): Remove decl.
8088 * emacs.c: Make symbols static if they're not exported.
8089 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8090 (fatal_error_code, fatal_error_signal_hook, standard_args):
8092 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8093 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8094 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8095 * lisp.h (fatal_error_signal_hook): Remove decl.
8096 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8098 * editfns.c: Move a (normally-unused) function to its only use.
8099 * editfns.c, lisp.h (get_operating_system_release): Remove.
8100 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8101 worth the hassle of breaking this out.
8103 * xterm.c: Make symbols static if they're not exported.
8104 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8105 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8106 (x_destroy_window, x_delete_display):
8108 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8109 (x_mouse_leave): Remove; unused.
8110 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8111 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8112 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8114 (x_mouse_leave): Declare only if WINDOWSNT.
8115 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8116 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8119 * ftxfont.c: Make symbols static if they're not exported.
8120 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8122 * font.h (ftxfont_driver): Likewise.
8124 * xfns.c: Make symbols static if they're not exported.
8125 (x_last_font_name, x_display_info_for_name):
8126 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8127 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8128 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8129 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8130 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8131 (last_show_tip_args): Now static.
8132 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8133 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8134 (x_screen_planes): Remove; unused.
8135 * dispextern.h (x_screen_planes): Remove decl.
8137 * dispnew.c: Make symbols static if they're not exported.
8138 * dispextern.h (redraw_garbaged_frames, scrolling):
8139 (increment_row_positions): Remove.
8140 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8141 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8143 (redraw_garbaged_frames): Remove; unused.
8145 * xfaces.c: Make symbols static if they're not exported.
8146 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8148 * xterm.h (defined_color): Remove decls.
8149 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8150 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8151 (menu_face_changed_default, defined_color, free_realized_face):
8152 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8153 (ascii_face_of_lisp_face): Remove; unused.
8155 * xdisp.c: Make symbols static if they're not exported.
8156 * dispextern.h (scratch_glyph_row, window_box_edges):
8157 (glyph_to_pixel_coords, set_cursor_from_row):
8158 (get_next_display_element, set_iterator_to_next):
8159 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8160 (show_mouse_face): Remove decls
8161 * frame.h (message_buf_print): Likewise.
8162 * lisp.h (pop_message, set_message, check_point_in_composition):
8164 * xterm.h (set_vertical_scroll_bar): Likewise.
8165 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8166 (message_buf_print, scratch_glyph_row, displayed_buffer):
8167 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8168 (get_next_display_element, show_mouse_face, window_box_edges):
8169 (frame_to_window_pixel_xy, check_point_in_composition):
8170 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8171 (glyph_to_pixel_coords): Remove; unused.
8173 * dired.c (file_name_completion): Now static.
8175 * dbusbind.c (xd_in_read_queued_messages): Now static.
8177 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8178 * data.c (circular_list_error): Remove.
8180 * commands.h (last_point_position, last_point_position_buffer):
8181 (last_point_position_window): Remove decls.
8182 * keyboard.c: Make these variables static.
8184 * coding.h (coding, code_convert_region, encode_coding_gap):
8186 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8187 (iso_code_class, detect_coding, code_convert_region): Now static.
8188 (encode_coding_gap): Remove; unused.
8190 * chartab.c (chartab_chars, chartab_bits): Now static.
8192 * charset.h (charset_iso_8859_1): Remove decl.
8193 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8196 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8197 * ccl.c (Vccl_program_table): Now static.
8198 (check_ccl_update): Remove; unused.
8200 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8201 * category.h: ... from here.
8202 * category.c (check_category_table, set_category_set): Now static.
8204 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8205 * lisp.h: Remove these decls.
8207 * buffer.c (buffer_count): Remove unused var.
8209 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8210 so that it's not optimized away.
8211 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8212 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8213 exported only to the debugger.
8215 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8216 * atimer.h (run_all_atimers): Remove; not exported.
8218 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8219 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8220 was inaccessible from Lisp.
8221 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8222 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8224 alloc.c: Import and export fewer symbols, and remove unused items.
8225 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8227 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8228 it's not optimized away by whole-program optimization.
8229 (message_enable_multibyte, free_misc): Remove.
8230 (catchlist, handlerlist, mark_backtrace):
8231 Declare only if BYTE_MARK_STACK.
8232 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8233 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8234 (message_enable_multibyte): Remove decl.
8235 (free_misc, interval_free_list, float_block, float_block_index):
8236 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8237 (cons_free_list, last_marked_index):
8239 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8240 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8241 (mark_backtrace): Define only if BYTE_MARK_STACK.
8242 * xdisp.c (message_enable_multibyte): Now static.
8244 Declare Lisp_Object Q* variables to be 'static' if not exported.
8245 This makes it easier for human readers (and static analyzers)
8246 to see whether these variables are used from other modules.
8247 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8248 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8249 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8250 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8251 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8252 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8253 * xmenu.c, xselect.c:
8254 Declare Q* vars static if they are not used in other modules.
8255 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8256 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8257 Remove decls of unexported vars.
8258 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8260 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8262 Make Emacs functions such as Fatom 'static' by default.
8263 This makes it easier for human readers (and static analyzers)
8264 to see whether these functions can be called from other modules.
8265 DEFUN now defines a static function. To make the function external
8266 so that it can be used in other C modules, use the new macro DEFUE.
8267 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8268 (Finit_image_library):
8269 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8270 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8271 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8272 Remove decls, since these functions are now static.
8273 (Funintern, Fget_internal_run_time): New decls, since these functions
8274 were already external.
8276 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8277 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8278 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8279 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8280 * keyboard.c, keymap.c, lread.c:
8281 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8282 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8283 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8284 Mark functions with DEFUE instead of DEFUN,
8285 if they are used in other modules.
8286 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8287 decls for now-static functions.
8288 * buffer.h (Fdelete_overlay): Remove decl.
8289 * callproc.c (Fgetenv_internal): Mark as internal.
8290 * composite.c (Fremove_list_of_text_properties): Remove decl.
8291 (Fcomposition_get_gstring): New forward static decl.
8292 * composite.h (Fcomposite_get_gstring): Remove decl.
8293 * dired.c (Ffile_attributes): New forward static decl.
8294 * doc.c (Fdocumntation_property): New forward static decl.
8295 * eval.c (Ffetch_bytecode): New forward static decl.
8296 (Funintern): Remove extern decl; now in .h file where it belongs.
8297 * fileio.c (Fmake_symbolic_link): New forward static decl.
8298 * image.c (Finit_image_library): New forward static decl.
8299 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8300 * intervals.h (Fprevious_property_change):
8301 (Fremove_list_of_text_properties): Remove decls.
8302 * keyboard.c (Fthis_command_keys): Remove decl.
8303 (Fcommand_execute): New forward static decl.
8304 * keymap.c (Flookup_key): New forward static decl.
8305 (Fcopy_keymap): Now static.
8306 * keymap.h (Flookup_key): Remove decl.
8307 * process.c (Fget_process): New forward static decl.
8308 (Fprocess_datagram_address): Mark as internal.
8309 * syntax.c (Fsyntax_table_p): New forward static decl.
8310 (skip_chars): Remove duplicate decl.
8311 * textprop.c (Fprevious_property_change): New forward static decl.
8312 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8314 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8315 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8317 * editfns.c (Fformat): Remove unreachable code.
8319 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8321 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8324 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8326 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8327 when at ZV. (Bug#8487)
8329 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8331 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8333 * keyboard.c (parse_tool_bar_item): Likewise.
8334 * sound.c (sound_cleanup, alsa_close): Likewise.
8335 * termcap.c (tgetent): Likewise.
8336 * xfns.c (x_default_font_parameter): Likewise.
8337 * xsettings.c (read_and_apply_settings): Likewise.
8339 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8340 (overrun_check_free): Protoize.
8342 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8344 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8345 since callers should never pass a negative size.
8346 Change the signature to match that of plain 'read' and 'write'; see
8347 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8348 * lisp.h: Update prototypes of emacs_write and emacs_read.
8350 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8352 * xdisp.c (redisplay_window): Don't try to determine the character
8353 position of the scroll margin if the window start point w->startp
8354 is outside the buffer's accessible region. (Bug#8468)
8356 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8358 Fix write-region and its subroutines for buffers > 2GB.
8359 * fileio.c (a_write, e_write): Modify declaration of arguments and
8360 local variables to support buffers larger than 2GB.
8361 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8363 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8364 argument, local variables, and return value.
8366 * lisp.h: Update prototypes of emacs_write and emacs_read.
8368 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8370 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8372 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8374 Fix more problems found by GCC 4.6.0's static checks.
8376 * xdisp.c (vmessage): Use a better test for character truncation.
8378 * charset.c (load_charset_map): <, not <=, for optimization,
8379 and to avoid potential problems with integer overflow.
8380 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8381 * casetab.c (set_identity, shuffle): Likewise.
8382 * editfns.c (Fformat): Likewise.
8383 * syntax.c (skip_chars): Likewise.
8385 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8386 This also lets GCC 4.6.0 generate slightly better loop code.
8388 * callint.c (Fcall_interactively): <, not <=, for optimization.
8389 (Fcall_interactively): Count the number of arguments produced,
8390 not the number of arguments given. This is simpler and lets GCC
8391 4.6.0 generate slightly better code.
8393 * ftfont.c: Distingish more carefully between FcChar8 and char.
8394 The previous code passed unsigned char * to a functions like
8395 strlen and xstrcasecmp that expect char *, which does not
8396 conform to the C standard.
8397 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8398 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8399 char * when the C standard requires it.
8401 * keyboard.c (read_char): Remove unused var.
8403 * eval.c: Port to Windows vsnprintf (Bug#8435).
8405 (SIZE_MAX): Define if the headers do not.
8406 (verror): Do not give up if vsnprintf returns a negative count.
8407 Instead, grow the buffer. This ports to Windows vsnprintf, which
8408 does not conform to C99. Problem reported by Eli Zaretskii.
8409 Also, simplify the allocation scheme, by avoiding the need for
8410 calling realloc, and removing the ALLOCATED variable.
8412 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8414 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8415 But keep the doprint source code for now, as we might revamp it
8416 and use it again (Bug#8435).
8417 * lisp.h (doprnt): Remove.
8418 * Makefile.in (base_obj): Remove doprnt.o.
8419 * deps.mk (doprnt.o): Remove.
8421 error: Print 32- and 64-bit integers portably (Bug#8435).
8422 Without this change, on typical 64-bit hosts error ("...%d...", N)
8423 was used to print both 32- and 64-bit integers N, which relied on
8425 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8426 * lisp.h (error, verror): Mark as printf-like functions.
8427 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8428 Report overflow in size calculations when allocating printf buffer.
8429 Do not truncate output string at its first null byte.
8430 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8431 Truncate the output at a character boundary, since vsnprintf does not
8433 * charset.c (check_iso_charset_parameter): Convert internal
8434 character to string before calling 'error', since %c now has the
8436 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8437 overflow when computing char to be passed to 'error'. Do not
8438 pass Lisp_Object to 'error'; pass the integer instead.
8439 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8440 formatted with plain %d.
8442 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8444 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8446 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8448 * xterm.c (x_catch_errors): Remove duplicate declaration.
8450 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8452 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8454 2011-04-10 Jim Meyering <meyering@redhat.com>
8456 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8457 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8458 return ssize_t not "int", and use size_t as the buffer length.
8459 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8460 * gnutls.h: Update declarations.
8461 * process.c (read_process_output): Use ssize_t, to match.
8462 (send_process): Likewise.
8464 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8466 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8468 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8470 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8471 Use unsigned char, to match FcChar8 type definition.
8473 * xterm.c (handle_one_xevent):
8474 * xmenu.c (create_and_show_popup_menu):
8475 * xselect.c (x_decline_selection_request)
8476 (x_reply_selection_request): Avoid type-punned deref of X events.
8478 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8480 Fix some uses of `int' instead of EMACS_INT.
8481 * search.c (string_match_1, fast_string_match)
8482 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8483 (scan_buffer, find_next_newline_no_quit)
8484 (find_before_next_newline, search_command, Freplace_match)
8485 (Fmatch_data): Make some `int' variables be EMACS_INT.
8487 * xdisp.c (display_count_lines): 3rd argument and return value now
8488 EMACS_INT. All callers changed.
8489 (pint2hrstr): Last argument is now EMACS_INT.
8491 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8492 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8493 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8494 (decode_coding_utf_16, decode_coding_emacs_mule)
8495 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8496 (decode_coding_ccl, decode_coding_charset)
8497 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8498 (decode_coding_iso_2022, decode_coding_emacs_mule)
8499 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8500 <char_offset, last_offset>: Declare EMACS_INT.
8501 (encode_coding_utf_8, encode_coding_utf_16)
8502 (encode_coding_emacs_mule, encode_invocation_designation)
8503 (encode_designation_at_bol, encode_coding_iso_2022)
8504 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8505 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8507 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8508 (encode_invocation_designation): Last argument P_NCHARS is now
8510 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8511 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8513 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8516 * ccl.c (Fccl_execute_on_string): Declare some variables
8519 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8521 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8523 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8525 * process.c (Fformat_network_address): Doc fix.
8527 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8529 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8531 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8533 * keyboard.c (read_char): Call Lisp function help-form-show,
8534 instead of using internal_with_output_to_temp_buffer.
8535 (Qhelp_form_show): New var.
8536 (syms_of_keyboard): Use DEFSYM macro.
8538 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8540 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8542 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8544 * process.c (Flist_processes): Remove to Lisp.
8545 (list_processes_1): Delete.
8547 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8549 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8551 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8553 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8555 Fix more problems found by GCC 4.6.0's static checks.
8557 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8559 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8561 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8563 * xdisp.c (vmessage): Mark as a printf-like function.
8565 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8567 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8569 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8570 printf-like functions.
8571 (tiff_load): Add casts to remove these marks before passing them
8572 to system-supplied API.
8574 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8576 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8577 This avoids several warnings with gcc -Wstrict-overflow.
8578 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8579 directly, rather than having caller test rule sign. This avoids
8580 some unnecessary tests.
8581 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8582 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8583 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8585 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8586 (xfont_open): Avoid unnecessary tests.
8588 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8590 * composite.h, composite.c (composition_gstring_put_cache):
8591 Use EMACS_INT, not int, for length.
8593 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8594 breaking out part of COMPOSITION_DECODE_RULE.
8595 (COMPOSITION_DECODE_RULE): Use it.
8596 * composite.c (get_composition_id): Remove unused local vars,
8597 by using the new macro.
8599 * textprop.c (set_text_properties_1): Change while to do-while,
8600 since the condition is always true at first.
8602 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8603 (interval_deletion_adjustment): Return unsigned value.
8606 * process.c (list_processes_1, create_pty, read_process_output):
8607 (exec_sentinel): Remove vars that were set but not used.
8608 (create_pty): Remove unnecessary "volatile"s.
8609 (Fnetwork_interface_info): Avoid possibility of int overflow.
8610 (read_process_output): Do adaptive read buffering even if carryover.
8611 (read_process_output): Simplify nbytes computation if buffered.
8613 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8615 * syntax.c (scan_words): Remove var that was set but not used.
8616 (update_syntax_table): Use unsigned instead of int.
8618 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8619 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8620 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8622 * print.c (print_error_message): Avoid int overflow.
8624 * font.c (font_list_entities): Redo for clarity,
8625 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8627 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8628 (font_score): Avoid potential overflow in diff calculation.
8630 * fns.c (substring_both): Remove var that is set but not used.
8631 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8633 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8635 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8636 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8637 can always succeed if overflow has undefined behavior.
8639 * search.c (boyer_moore, wordify): Remove vars set but not used.
8640 (wordify): Omit three unnecessary tests.
8642 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8643 All callers changed. This avoids the need for an unused var.
8645 * casefiddle.c (casify_region): Remove var that is set but not used.
8647 * dired.c (file_name_completion): Remove var that is set but not used.
8649 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8651 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8652 (Finsert_file_contents): Remove unnecessary code checking fd.
8654 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8655 Check for integer overflow on size calculations.
8657 * buffer.c (Fprevious_overlay_change): Remove var that is set
8660 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8661 Remove vars that are set but not used.
8662 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8663 (timer_check_2): Mark vars as initialized.
8665 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8667 * image.c (lookup_image): Remove var that is set but not used.
8668 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8670 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8671 that are set but not used.
8673 * xfns.c (make_invisible_cursor): Don't return garbage
8674 if XCreateBitmapFromData fails (Bug#8410).
8676 * xselect.c (x_get_local_selection, x_handle_property_notify):
8677 Remove vars that are set but not used.
8679 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8680 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8682 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8683 Remove var that is set but not used.
8684 (scroll_bar_windows_size): Now size_t, not int.
8685 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8688 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8689 (map_tty_color) [!defined MSDOS]: Likewise.
8691 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8693 * coding.c: Remove vars that are set but not used.
8694 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8695 All callers changed.
8696 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8697 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8698 (decode_coding_charset): Remove vars that are set but not used.
8700 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8701 that is set but not used.
8703 * print.c (print_object): Remove var that is set but not used.
8705 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8706 The gnulib version avoids calling malloc in the usual case,
8707 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8708 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8709 * filelock.c (current_lock_owner): Likewise.
8710 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8711 * sysdep.c: Include allocator.h, careadlinkat.h.
8712 (emacs_no_realloc_allocator): New static constant.
8713 (emacs_readlink): New function.
8714 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8715 ../lib/careadlinkat.h.
8717 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8719 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8720 first non-nil return value).
8722 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8724 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8725 if not defined (Bug#8403).
8727 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8729 * xdisp.c (display_count_lines): Remove parameter `start',
8730 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8731 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8732 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8733 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8734 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8735 and thereabouts. All callers changed.
8736 (get_per_char_metric): Remove parameter `f', unused since
8737 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8739 2011-04-02 Jim Meyering <meyering@redhat.com>
8741 do not dereference NULL upon failed strdup
8742 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8743 (ns_get_family): Likewise.
8745 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8747 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8749 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8751 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8754 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8756 Add lexical binding.
8758 * window.c (Ftemp_output_buffer_show): New fun.
8759 (Fsave_window_excursion):
8760 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8762 * lread.c (lisp_file_lexically_bound_p): New function.
8763 (Fload): Bind Qlexical_binding.
8764 (readevalloop): Remove `evalfun' arg.
8765 Bind Qinternal_interpreter_environment.
8766 (Feval_buffer): Bind Qlexical_binding.
8767 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8769 (syms_of_lread): Declare `lexical-binding'.
8771 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8773 * keyboard.c (eval_dyn): New fun.
8774 (menu_item_eval_property): Use it.
8776 * image.c (parse_image_spec): Use Ffunctionp.
8778 * fns.c (concat, mapcar1): Accept byte-code-functions.
8780 * eval.c (Fsetq): Handle lexical vars.
8781 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8782 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8783 (FletX, Flet): Obey lexical binding.
8784 (Fcommandp): Handle closures.
8785 (Feval): New `lexical' arg.
8786 (eval_sub): New function extracted from Feval. Use it almost
8787 everywhere where Feval was used. Look up vars in lexical env.
8789 (Ffunctionp): Move from subr.el.
8790 (Ffuncall): Handle closures.
8791 (apply_lambda): Remove `eval_flags'.
8792 (funcall_lambda): Handle closures and new byte-code-functions.
8793 (Fspecial_variable_p): New function.
8794 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8795 but without exporting it to Lisp.
8797 * doc.c (Fdocumentation, store_function_docstring):
8798 * data.c (Finteractive_form): Handle closures.
8800 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8803 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8805 (exec_byte_code): New function extracted from Fbyte_code to handle new
8806 calling convention for byte-code-functions. Add new byte-codes.
8808 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8810 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8812 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8814 * xdisp.c (redisplay_internal): Fix prototype.
8816 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8818 * xdisp.c (SCROLL_LIMIT): New macro.
8819 (try_scrolling): Use it when setting scroll_limit.
8820 Limit scrolling to 100 screen lines.
8821 (redisplay_window): Even when falling back on "recentering",
8822 position point in the window according to scroll-conservatively,
8823 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8825 (try_scrolling): When point is above the window, allow searching
8826 as far as scroll_max, or one screenful, to compute vertical
8827 distance from PT to the scroll margin position. This prevents
8828 try_scrolling from unnecessarily failing when
8829 scroll-conservatively is set to a value slightly larger than the
8830 window height. Clean up the case of PT below the margin at bottom
8831 of window: scroll_max can no longer be INT_MAX. When aggressive
8832 scrolling is in use, don't let point enter the opposite scroll
8833 margin as result of the scroll.
8834 (syms_of_xdisp) <scroll-conservatively>: Document the
8835 threshold of 100 lines for never-recentering scrolling.
8837 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8839 * dispextern.h (move_it_by_lines):
8840 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8841 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8842 (message_log_check_duplicate): Remove parameters `prev_bol' and
8843 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8844 (redisplay_internal): Remove parameter `preserve_echo_area',
8845 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8847 * indent.c (Fvertical_motion):
8848 * window.c (window_scroll_pixel_based, Frecenter):
8849 Don't pass `need_y_p' to `move_it_by_lines'.
8851 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8853 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8854 steal a few bits to be more compact.
8855 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8856 Remove unneeded casts.
8858 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8860 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8862 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8863 binding" message (bug#7967).
8865 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8867 Fix more problems found by GCC 4.6.0's static checks.
8869 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8870 Remove unused local var.
8872 * editfns.c (Fmessage_box): Remove unused local var.
8874 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8875 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8876 Omit unused local vars.
8877 * window.c (shrink_windows): Omit unused local var.
8878 * menu.c (digest_single_submenu): Omit unused local var.
8879 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8880 Omit unused local var.
8882 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8883 Don't assume string length fits in int.
8884 (keyremap_step, read_key_sequence): Use size_t for sizes.
8885 (read_key_sequence): Don't check last_real_key_start redundantly.
8887 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8888 instead of alloca (Bug#8344).
8890 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8891 (Fbacktrace_frame): Don't assume nframes fits in int.
8893 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8895 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8898 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8900 * cm.c (calccost): Turn while-do into do-while, for clarity.
8902 * keyboard.c (syms_of_keyboard): Use the same style as later
8903 in this function when indexing through an array. This also
8904 works around GCC bug 48267.
8906 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8908 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8910 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8911 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8913 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8914 This avoids undefined behavior on integer overflow, and is a bit
8915 more convenient anyway since it is compared to a size_t variable.
8917 Variadic C functions now count arguments with size_t, not int.
8918 This avoids an unnecessary limitation on 64-bit machines, which
8919 caused (substring ...) to crash on large vectors (Bug#8344).
8920 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8921 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8922 All variadic functions and their callers changed accordingly.
8923 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8924 * data.c (arith_driver, float_arith_driver): Likewise.
8925 * editfns.c (general_insert_function): Likewise.
8926 * eval.c (struct backtrace.nargs, interactive_p)
8927 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8928 (funcall_lambda, mark_backtrace): Likewise.
8929 * fns.c (concat): Likewise.
8930 * frame.c (x_set_frame_parameters): Likewise.
8931 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8932 0 if not found, not -1. All callers changed.
8934 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8935 (stack_copy_size): Now size_t, not int.
8936 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8938 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8940 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8941 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8942 All callers changed.
8944 * lisp.h (multibyte_char_to_unibyte):
8945 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8946 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8947 * character.h (CHAR_TO_BYTE8):
8948 * cmds.c (internal_self_insert):
8949 * editfns.c (general_insert_function):
8950 * keymap.c (push_key_description):
8951 * search.c (Freplace_match):
8952 * xdisp.c (message_dolog, set_message_1): All callers changed.
8954 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8956 * keyboard.c (safe_run_hook_funcall): New function.
8957 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8958 don't set the hook to nil, but remove the offending function instead.
8959 (Qcommand_hook_internal): Remove, unused.
8960 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8961 Vcommand_hook_internal.
8963 * eval.c (enum run_hooks_condition): Remove.
8964 (funcall_nil, funcall_not): New functions.
8965 (run_hook_with_args): Call each function through a `funcall' argument.
8966 Remove `cond' argument, now redundant.
8967 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8968 (Frun_hook_with_args_until_failure): Adjust accordingly.
8969 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8971 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8973 * dispextern.h (string_buffer_position): Remove declaration.
8975 * print.c (strout): Remove parameter `multibyte', unused since
8976 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8978 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8979 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8980 All callers changed.
8982 * w32.c (_wsa_errlist): Use braces for struct initializers.
8984 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8985 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8986 All callers changed.
8987 (string_buffer_position): Likewise. Also, make static (it's never
8988 used outside xdisp.c).
8989 (cursor_row_p): Remove parameter `w', unused since
8990 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8991 (decode_mode_spec): Remove parameter `precision', introduced during
8992 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8993 All callers changed.
8995 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8997 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8999 2011-03-27 Anders Lindgren <andlind@gmail.com>
9001 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9002 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9003 (ns_update_auto_hide_menu_bar): New functions.
9004 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9005 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9006 ns_constrain_all_frames.
9007 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9008 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9010 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9012 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9014 2011-03-27 Glenn Morris <rgm@gnu.org>
9016 * syssignal.h: Replace RETSIGTYPE with void.
9017 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9018 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9019 Replace SIGTYPE with void everywhere.
9020 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9021 * s/template.h (SIGTYPE): Remove commented out definition.
9023 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9025 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9026 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9028 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9030 * w32.c (read_unc_volume): Use parameter `henum', instead of
9031 global variable `wget_enum_handle'.
9033 * keymap.c (describe_vector): Remove parameters `indices' and
9034 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9035 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9037 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9039 * keyboard.c (timer_check): Remove parameter `do_it_now',
9040 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9041 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9042 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9044 * keyboard.c (read_char):
9045 * w32menu.c (w32_menu_display_help):
9046 * xmenu.c (show_help_event, menu_help_callback):
9047 Adjust calls to `show_help_echo'.
9049 * gtkutil.c (xg_maybe_add_timer):
9050 * keyboard.c (readable_events):
9051 * process.c (wait_reading_process_output):
9052 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9054 * insdel.c (adjust_markers_gap_motion):
9055 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9056 (gap_left, gap_right): Don't call it.
9058 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9060 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9061 incurred during fontification.
9063 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9065 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9066 (DEFVAR_PER_BUFFER): Don't pass it.
9068 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9069 (scrolling_window): Don't pass it.
9071 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9073 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9075 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9077 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9078 of variables specific to SELinux and computation of `encoded_absname'.
9080 * image.c (XPutPixel): Remove unused variable `height'.
9082 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9084 * unexw32.c (get_section_info): Remove unused variable `section'.
9086 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9087 (system_process_attributes): Remove unused variable `sess'.
9088 (sys_read): Remove unused variable `err'.
9090 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9091 (w32_wnd_proc): Remove unused variable `isdead'.
9092 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9093 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9094 (x_create_tip_frame): Remove unused variable `tem'.
9096 * w32inevt.c (w32_console_read_socket):
9097 Remove unused variable `no_events'.
9099 * w32term.c (x_draw_composite_glyph_string_foreground):
9100 Remove unused variable `width'.
9102 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9104 * w32term.c (x_set_glyph_string_clipping):
9105 Don't pass uninitialized region to CombineRgn.
9107 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9109 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9110 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9111 (Fx_close_connection): Remove unused variable `i'.
9113 * w32font.c (w32font_draw): Return number of glyphs.
9114 (w32font_open_internal): Remove unused variable `i'.
9115 (w32font_driver): Add missing initializer.
9117 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9118 (fill_in_menu): Remove unused variable `items_added'.
9120 * w32term.c (last_mouse_press_frame): Remove static global variable.
9121 (w32_clip_to_row): Remove unused variable `f'.
9122 (x_delete_terminal): Remove unused variable `i'.
9124 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9125 (NOTHING): Remove unused static global variable.
9126 (uniscribe_check_otf): Remove unused variable `table'.
9127 (uniscribe_font_driver): Add missing initializers.
9129 2011-03-23 Julien Danjou <julien@danjou.info>
9131 * term.c (Fsuspend_tty, Fresume_tty):
9132 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9133 * window.c (temp_output_buffer_show):
9134 * insdel.c (signal_before_change):
9135 * frame.c (Fhandle_switch_frame):
9136 * fileio.c (Fdo_auto_save):
9137 * emacs.c (Fkill_emacs):
9138 * editfns.c (save_excursion_restore):
9139 * cmds.c (internal_self_insert):
9140 * callint.c (Fcall_interactively):
9141 * buffer.c (Fkill_all_local_variables):
9142 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9144 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9145 unconditionally since it does the check itself.
9147 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9149 Fix more problems found by GCC 4.5.2's static checks.
9151 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9152 the first time through the loop, since we know p0 < p1 then.
9153 This also avoids a gcc -Wstrict-overflow warning.
9155 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9156 leading to a memory leak, possible in functions like
9157 load_charset_map_from_file that can allocate an unbounded number
9158 of objects (Bug#8318).
9160 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9161 that could (at least in theory) be that large.
9163 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9164 This is less likely to overflow, and avoids undefined behavior if
9165 overflow does occur. All callers changed. Use strtoul to scan
9166 for the unsigned long integer.
9167 (pint2hrstr): Simplify and tune code slightly.
9168 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9170 * scroll.c (do_scrolling): Work around GCC bug 48228.
9171 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9173 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9174 This also avoids a warning with gcc -Wstrict-overflow.
9175 (validate_x_resource_name): Simplify count usage.
9176 This also avoids a warning with gcc -Wstrict-overflow.
9178 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9181 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9183 * process.c (Fmake_network_process): Use socklen_t, not int,
9184 where POSIX says socklen_t is required in portable programs.
9185 This fixes a porting bug on hosts like 64-bit HP-UX, where
9186 socklen_t is wider than int (Bug#8277).
9187 (Fmake_network_process, server_accept_connection):
9188 (wait_reading_process_output, read_process_output):
9191 * process.c: Rename or move locals to avoid shadowing.
9192 (list_processes_1, Fmake_network_process):
9193 (read_process_output_error_handler, exec_sentinel_error_handler):
9194 Rename or move locals.
9195 (Fmake_network_process): Define label "retry_connect" only if needed.
9196 (Fnetwork_interface_info): Fix pointer signedness.
9197 (process_send_signal): Add cast to avoid pointer signedness problem.
9198 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9199 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9201 Make tparam.h and terminfo.c consistent.
9202 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9203 Include tparam.h instead, since it declares them.
9204 * cm.h (PC): Remove extern decl; tparam.h now does this.
9205 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9206 * terminfo.c: Include tparam.h, to check interfaces.
9207 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9208 (tparam): Adjust signature to match interface in tparam.h;
9209 this removes some undefined behavior. Check that outstring and len
9210 are zero, which they always are with Emacs.
9211 * tparam.h (PC, BC, UP): New extern decls.
9213 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9214 (xftfont_open): Rename locals to avoid shadowing.
9216 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9217 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9218 (OTF_TAG_SYM): Omit macro if not needed.
9219 (ftfont_list): Remove unused local.
9220 (get_adstyle_property, ftfont_pattern_entity):
9221 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9222 Rename locals to avoid shadowing.
9224 * xfont.c (xfont_list_family): Mark var as initialized.
9226 * xml.c (make_dom): Now static.
9228 * composite.c (composition_compute_stop_pos): Rename local to
9230 (composition_reseat_it): Remove unused locals.
9231 (find_automatic_composition, composition_adjust_point): Likewise.
9232 (composition_update_it): Mark var as initialized.
9233 (find_automatic_composition): Mark vars as initialized,
9234 with a FIXME (Bug#8290).
9236 character.h: Rename locals to avoid shadowing.
9237 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9238 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9239 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9240 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9243 * textprop.c (property_change_between_p): Remove; unused.
9245 * intervals.c (interval_start_pos): Now static.
9247 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9249 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9250 Rename locals to avoid shadowing.
9252 * sound.c (wav_play, au_play, Fplay_sound_internal):
9253 Fix pointer signedness.
9254 (alsa_choose_format): Remove unused local var.
9255 (wav_play): Initialize a variable to 0, to prevent undefined
9256 behavior (Bug#8278).
9258 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9260 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9262 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9263 clobbering (Bug#8298).
9264 * sysdep.c (sys_subshell): Likewise.
9265 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9267 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9268 This should get cleaned up, so that child_setup has the
9269 same signature on all platforms.
9271 * callproc.c (call_process_cleanup): Now static.
9272 (relocate_fd): Rename locals to avoid shadowing.
9274 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9276 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9277 not to be necessary, and produces flickering.
9279 2011-03-20 Glenn Morris <rgm@gnu.org>
9281 * config.in: Remove file.
9283 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9285 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9286 are now in src/globals.h.
9287 (syms_of_minibuf): Remove spurious & from previous change.
9289 2011-03-20 Leo Liu <sdl.web@gmail.com>
9291 * minibuf.c (completing-read-function): New variable.
9292 (completing-read-default): Rename from completing-read.
9293 (completing-read): Call completing-read-function.
9295 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9297 * xfaces.c (Fx_load_color_file):
9298 Read color file from absolute filename (bug#8250).
9300 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9302 * makefile.w32-in: Update dependencies.
9304 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9306 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9308 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9310 Fix more problems found by GCC 4.5.2's static checks.
9312 * process.c (make_serial_process_unwind, send_process_trap):
9313 (sigchld_handler): Now static.
9315 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9316 That way, the code declares only the vars that it needs.
9317 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9318 * s/cygwin.h (PTY_ITERATION): Likewise.
9319 * s/darwin.h (PTY_ITERATION): Likewise.
9320 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9322 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9323 * process.c (allocate_pty): Don't declare stb unless it's needed.
9325 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9326 (CONSTANTLIM): Remove; unused.
9327 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9328 Define only if needed.
9330 * unexelf.c (unexec): Name an expression,
9331 to avoid gcc -Wbad-function-cast warning.
9332 Use a different way to cause a compilation error if anyone uses
9333 n rather than nn, a way that does not involve shadowing.
9334 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9336 * deps.mk (unexalpha.o): Remove; unused.
9338 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9339 * unexec.h: New file.
9340 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9341 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9343 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9344 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9345 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9346 Change as necessary to match prototype in unexec.h.
9348 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9350 (back_comment, skip_chars): Mark vars as initialized.
9352 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9353 Rename locals to avoid shadowing.
9355 * lread.c (read1): Rewrite so as not to use empty "else".
9356 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9358 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9360 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9361 warning when compiling print.c.
9363 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9364 instead of using an uninitialized var.
9365 (font_sort_entities): Mark var as initialized.
9367 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9369 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9370 pointers to constants.
9371 (font_parse_fcname): Remove unused vars.
9372 (font_delete_unmatched): Now static.
9373 (font_get_spec): Remove; unused.
9374 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9375 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9376 Rename or move locals to avoid shadowing.
9378 * fns.c (require_nesting_list, require_unwind): Now static.
9379 (Ffillarray): Rename locals to avoid shadowing.
9381 * floatfns.c (domain_error2): Define only if needed.
9382 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9384 * alloc.c (mark_backtrace): Move decl from here ...
9385 * lisp.h: ... to here, so that it can be checked.
9387 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9388 (Fdefvar): Rewrite so as not to use empty "else".
9389 (lisp_indirect_variable): Name an expression,
9390 to avoid gcc -Wbad-function-cast warning.
9391 (Fdefvar): Rename locals to avoid shadowing.
9393 * callint.c (quotify_arg, quotify_args): Now static.
9394 (Fcall_interactively): Rename locals to avoid shadowing.
9395 Use const pointer when appropriate.
9397 * lisp.h (get_system_name, get_operating_system_release):
9398 Move decls here, to check interfaces.
9399 * process.c (get_operating_system_release): Move decl to lisp.h.
9400 * xrdb.c (get_system_name): Likewise.
9401 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9402 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9403 some of which prompt warnings from gcc -Wbad-function-cast.
9404 (Fformat_time_string, Fencode_time, Finsert_char):
9405 (Ftranslate_region_internal, Fformat):
9406 Rename or remove local vars to avoid shadowing.
9407 (Ftranslate_region_internal): Mark var as initialized.
9409 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9412 * lisp.h (eassert): Check that the argument compiles, even if
9413 ENABLE_CHECKING is not defined.
9415 * data.c (Findirect_variable): Name an expression, to avoid
9416 gcc -Wbad-function-cast warning.
9417 (default_value, arithcompare, arith_driver, arith_error): Now static.
9418 (store_symval_forwarding): Rename local to avoid shadowing.
9419 (Fmake_variable_buffer_local, Fmake_local_variable):
9420 Mark variables as initialized.
9421 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9423 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9424 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9425 Rename locals to avoid shadowing.
9426 (mark_stack): Move local variables into the #ifdef region where
9428 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9429 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9431 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9432 (GC_STRING_CHARS): Remove; not used.
9433 (Fmemory_limit): Cast sbrk's returned value to char *.
9435 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9436 avoids undefined behavior in theory.
9438 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9440 Use functions, not macros, for up- and down-casing (Bug#8254).
9441 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9442 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9443 to use the following functions instead of these macros.
9444 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9445 EMACS_INT, since callers assume the returned value fits in int.
9446 (upcase1): Likewise, for UPCASE_TABLE.
9447 (uppercasep, lowercasep, upcase): New static inline functions.
9448 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9449 the race-condition problem in the old DOWNCASE.
9451 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9452 Rename locals to avoid shadowing.
9453 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9454 (regex_compile, re_search_2, re_match_2_internal):
9455 Remove unused local vars.
9456 (FREE_VAR): Rewrite so as not to use empty "else",
9457 which gcc can warn about.
9458 (regex_compile, re_match_2_internal): Mark locals as initialized.
9459 (RETALLOC_IF): Define only if needed.
9460 (WORDCHAR_P): Likewise. This one is never needed, but is used
9461 only in a comment talking about a compiler bug, so put inside
9462 the #if 0 of that comment.
9463 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9464 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9467 * search.c (boyer_moore): Rename locals to avoid shadowing.
9468 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9469 (PREV_CHAR_BOUNDARY): Likewise.
9471 * search.c (simple_search): Remove unused var.
9473 * dired.c (compile_pattern): Move decl from here ...
9474 * lisp.h: ... to here, so that it can be checked.
9475 (struct re_registers): New forward decl.
9477 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9479 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9481 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9482 Rename locals to avoid shadowing.
9483 (Fvertical_motion): Mark locals as initialized.
9485 * casefiddle.c (casify_object, casify_region): Now static.
9486 (casify_region): Mark local as initialized.
9488 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9490 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9491 New macros, so that the caller can use some names other than
9492 gcpro1, gcpro2, etc.
9493 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9495 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9496 argument, for consistency with GCPRO2_VAR, etc: it is now the
9497 prefix of the variable, not the variable itself. All uses
9499 * dired.c (directory_files_internal, file_name_completion):
9500 Rename locals to avoid shadowing.
9502 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9503 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9504 dired.c's scmp function, had undefined behavior.
9505 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9506 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9507 * buffer.h: ... to here, because these macros use current_buffer,
9508 and the new implementation with inline functions needs to have
9509 current_buffer in scope now, rather than later when the macros
9511 (downcase, upcase1): New static inline functions.
9512 (DOWNCASE, UPCASE1): Reimplement using these functions.
9513 This avoids undefined behavior in expressions like
9514 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9515 from race conditions in accessing the global variables
9516 case_temp1 and case_temp2.
9517 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9518 * lisp.h (case_temp1, case_temp2): Remove their decls.
9519 * character.h (ASCII_CHAR_P): Move from here ...
9520 * lisp.h: ... to here, so that the inline functions mentioned
9523 * dired.c (directory_files_internal_unwind): Now static.
9525 * fileio.c (file_name_as_directory, directory_file_name):
9526 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9528 (file_name_as_directory): Use const pointers when appropriate.
9529 (Fexpand_file_name): Likewise. In particular, newdir might
9530 point at constant storage, so make it a const pointer.
9531 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9532 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9534 (Fset_file_times, Finsert_file_contents, auto_save_error):
9535 Rename locals to avoid shadowing.
9537 * minibuf.c (choose_minibuf_frame_1): Now static.
9538 (Ftry_completion, Fall_completions): Rename or remove locals
9541 * marker.c (bytepos_to_charpos): Remove; unused.
9543 * lisp.h (verify_bytepos, count_markers): New decls,
9544 so that gcc does not warn that these functions aren't declared.
9546 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9547 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9548 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9549 (copy_text): Remove unused local var.
9551 * filelock.c (within_one_second): Now static.
9552 (lock_file_1): Rename local to avoid shadowing.
9554 * buffer.c (fix_overlays_before): Mark locals as initialized.
9555 (fix_start_end_in_overlays): Likewise. This function should be
9556 simplified by using pointers-to-pointers, but that's a different
9558 (switch_to_buffer_1): Now static.
9559 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9560 (report_overlay_modification): Rename locals to avoid shadowing.
9562 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9563 Fix pointer signedness issue.
9564 (sys_subshell): Mark local as volatile if checking for lint,
9565 to suppress a gcc -Wclobbered warning that does not seem to be right.
9566 (MAXPATHLEN): Define only if needed.
9568 * process.c (serial_open, serial_configure): Move decls from here ...
9569 * systty.h: ... to here, so that they can be checked.
9571 * fns.c (get_random, seed_random): Move extern decls from here ...
9572 * lisp.h: ... to here, so that they can be checked.
9574 * sysdep.c (reset_io): Now static.
9575 (wait_for_termination_signal): Remove; unused.
9577 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9578 (copy_keymap_item, append_key, push_text_char_description):
9580 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9581 (DENSE_TABLE_SIZE): Remove; unused.
9582 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9583 (describe_map_tree):
9584 Rename locals to avoid shadowing.
9586 * keyboard.c: Declare functions static if they are not used elsewhere.
9587 (echo_char, echo_dash, cmd_error, top_level_2):
9588 (poll_for_input, handle_async_input): Now static.
9589 (read_char, kbd_buffer_get_event, make_lispy_position):
9590 (make_lispy_event, make_lispy_movement, apply_modifiers):
9591 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9592 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9593 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9594 (read_key_sequence, read_char): Mark locals as initialized.
9595 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9597 * keyboard.h (make_ctrl_char): New decl.
9598 (mark_kboards): Move decl here ...
9599 * alloc.c (mark_kboards): ... from here.
9601 * lisp.h (force_auto_save_soon): New decl.
9603 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9604 (DEFINE_DUMMY_FUNCTION): New macro.
9605 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9607 (main): Add casts to avoid warnings
9608 if GCC considers string literals to be constants.
9610 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9612 * dbusbind.c: Pointer signedness fixes.
9613 (xd_signature, xd_append_arg, xd_initialize):
9614 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9615 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9616 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9617 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9619 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9620 if GCC considers string literals to be constants.
9621 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9623 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9625 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9626 (print_preprocess, print_object): New macro to fix last change.
9628 * print.c (print_preprocess): Don't forget font objects.
9630 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9632 * emacs.c (USAGE3): Doc fixes.
9634 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9636 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9639 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9641 * lisp.h (VWindow_system, Qfile_name_history):
9642 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9643 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9644 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9646 * w32select.c: Don't #include "keyboard.h".
9647 (run_protected): Add extern declaration for waiting_for_input.
9649 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9650 * w32console.c (detect_input_pending, read_input_pending)
9651 (encode_terminal_code):
9652 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9653 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9654 (w32_system_caret_y, Qfile_name_history):
9655 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9656 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9657 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9658 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9659 * w32proc.c (Qlocal, report_file_error):
9660 * w32term.c (Vwindow_system, updating_frame):
9661 * w32uniscribe.c (initialized, uniscribe_font_driver):
9662 Remove unneeded extern declarations.
9664 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9666 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9668 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9670 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9671 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9672 These macros can no longer be used for assignment.
9674 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9675 Assign struct members directly, instead of using BUF_BEGV etc.
9676 (record_buffer_markers, fetch_buffer_markers): New functions for
9677 recording and fetching special buffer markers.
9678 (set_buffer_internal_1, set_buffer_temp): Use them.
9680 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9682 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9684 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9685 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9687 * xdisp.c (hscroll_window_tree):
9688 (reconsider_clip_changes): Use PT instead of BUF_PT.
9690 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9692 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9693 $(EMACS_ROOT)/lib/intprops.h.
9695 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9697 Fix more problems found by GCC 4.5.2's static checks.
9699 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9700 to unsigned char * to avoid compiler diagnostic.
9701 (xg_free_frame_widgets): Make it clear that a local variable is
9702 needed only if USE_GTK_TOOLTIP.
9703 (gdk_window_get_screen): Make it clear that this macro is needed
9704 only if USE_GTK_TOOLTIP.
9705 (int_gtk_range_get_value): New function, which avoids a diagnostic
9706 from gcc -Wbad-function-cast.
9707 (xg_set_toolkit_scroll_bar_thumb): Use it.
9708 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9709 diagnostic from gcc -Wbad-function-cast.
9710 (get_utf8_string, xg_get_file_with_chooser):
9711 Rename locals to avoid shadowing.
9712 (create_dialog): Move locals to avoid shadowing.
9714 * xgselect.c (xg_select): Remove unused var.
9716 * image.c (four_corners_best): Mark locals as initialized.
9717 (gif_load): Initialize transparent_p to zero (Bug#8238).
9718 Mark another local as initialized.
9719 (my_png_error, my_error_exit): Mark with NO_RETURN.
9721 * image.c (clear_image_cache): Now static.
9722 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9723 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9724 (x_edge_detection): Remove unnecessary cast that
9725 gcc -Wbad-function-cast diagnoses.
9726 (gif_load): Fix pointer signedness.
9727 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9728 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9730 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9732 Improve quality of tests for time stamp overflow.
9733 For example, without this patch (encode-time 0 0 0 1 1
9734 1152921504606846976) returns the obviously-bogus value (-948597
9735 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9736 reports time overflow. See
9737 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9738 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9739 * editfns.c: Include limits.h and intprops.h.
9740 (TIME_T_MIN, TIME_T_MAX): New macros.
9741 (time_overflow): Move earlier, to before first use.
9742 (hi_time, lo_time): New functions, for an accurate test for
9744 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9745 (Fget_internal_run_time): Don't assume time_t fits in int.
9746 (make_time): Use list2 instead of Fcons twice.
9747 (Fdecode_time): More accurate test for out-of-range times.
9748 (check_tm_member): New function.
9749 (Fencode_time): Use it, to test for out-of-range times.
9750 (lisp_time_argument): Don't rely on undefined left-shift and
9751 right-shift behavior when checking for time stamp overflow.
9753 * editfns.c (time_overflow): New function, refactoring common code.
9754 (Fformat_time_string, Fdecode_time, Fencode_time):
9755 (Fcurrent_time_string): Use it.
9757 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9758 * dired.c (make_time): Move to ...
9759 * editfns.c (make_time): ... here.
9760 * systime.h: Note the move.
9762 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9764 * fringe.c (update_window_fringes): Remove unused variables.
9766 * unexmacosx.c (copy_data_segment): Also copy __got section.
9769 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9771 * termcap.c [MSDOS]: Include "msdos.h".
9772 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9773 Constify `char *' arguments and their references according to
9774 prototypes in tparam.h.
9776 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9778 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9779 Adapt all references accordingly.
9781 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9783 2011-03-11 Tom Tromey <tromey@redhat.com>
9785 * buffer.c (syms_of_buffer): Remove obsolete comment.
9787 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9789 * termhooks.h (encode_terminal_code): Declare prototype.
9791 * msdos.c (encode_terminal_code): Don't declare prototype.
9793 * term.c (encode_terminal_code): Now external again, used by
9794 w32console.c and msdos.c.
9796 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9797 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9799 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9801 Fix some minor problems found by GCC 4.5.2's static checks.
9803 * fringe.c (update_window_fringes): Mark locals as initialized
9805 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9807 * alloc.c (mark_fringe_data): Move decl from here ...
9808 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9809 to check its interface.
9810 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9812 * fontset.c (free_realized_fontset): Now static.
9813 (Fset_fontset_font): Rename local to avoid shadowing.
9814 (fontset_font): Mark local as initialized.
9815 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9817 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9819 * xselect.c (x_disown_buffer_selections): Remove; not used.
9820 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9821 (x_own_selection, Fx_disown_selection_internal): Rename locals
9823 (x_handle_dnd_message): Remove local to avoid shadowing.
9825 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9826 so that the caller can use some name other than gcpro1.
9827 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9828 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9829 (Fx_backspace_delete_keys_p):
9830 Use them to avoid shadowing, and rename vars to avoid shadowing.
9831 (x_decode_color, x_set_name, x_window): Now static.
9832 (Fx_create_frame): Add braces to silence GCC warning.
9833 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9834 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9835 Remove unused locals.
9836 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9837 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9838 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9841 * xterm.h (x_mouse_leave): New decl.
9843 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9844 Remove unused functions.
9845 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9846 (x_calc_absolute_position): Now static.
9847 (XTread_socket): Don't define label "out" unless it's used.
9848 Don't declare local "event" unless it's used.
9849 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9850 unless they are used.
9851 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9852 (x_fatal_error_signal): Remove; not used.
9853 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9854 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9855 (x_error_catcher, x_connection_closed, x_error_handler):
9856 (x_error_quitter, xembed_send_message, x_iconify_frame):
9857 (my_log_handler): Rename locals to avoid shadowing.
9858 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9859 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9861 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9862 Rename or move locals to avoid shadowing.
9863 (tty_defined_color, merge_face_heights): Now static.
9864 (free_realized_faces_for_fontset): Remove; not used.
9865 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9866 does not deduce is never used uninitialized.
9867 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9868 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9870 * terminal.c (store_terminal_param): Now static.
9872 * xmenu.c (menu_highlight_callback): Now static.
9873 (set_frame_menubar): Remove unused local.
9874 (xmenu_show): Rename parameter to avoid shadowing.
9875 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9876 since they might point to immutable storage.
9877 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9878 since it's unused otherwise.
9880 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9881 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9882 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9883 avoids a gcc -Wuninitialized diagnostic.
9884 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9885 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9886 does not deduce are never used uninitialized.
9888 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9890 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9891 * window.c (window_loop, size_window):
9892 (run_window_configuration_change_hook, enlarge_window): Likewise.
9894 * window.c (display_buffer): Now static.
9895 (size_window): Mark variables that gcc -Wuninitialized
9896 does not deduce are never used uninitialized.
9897 * window.h (check_all_windows): New decl, to forestall
9898 gcc -Wmissing-prototypes diagnostic.
9899 * dispextern.h (bidi_dump_cached_states): Likewise.
9901 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9903 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9905 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9906 and to avoid gcc -Wuninitialized warning.
9907 (load_charset_map): Mark variables that gcc -Wuninitialized
9908 does not deduce are never used uninitialized.
9909 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9911 * coding.c (coding_set_source, coding_set_destination):
9912 Use "else { /* comment */ }" rather than "else /* comment */;"
9913 for clarity, and to avoid gcc -Wempty-body warning.
9914 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9915 a block, when the outer 'i' will do.
9916 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9917 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9918 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9919 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9920 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9921 Rename locals to avoid shadowing.
9922 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9923 * coding.c (emacs_mule_char, encode_invocation_designation):
9924 Now static, since they're not used elsewhere.
9925 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9926 (decode_coding_object, encode_coding_object, detect_coding_system):
9927 (decode_coding_emacs_mule): Mark variables that gcc
9928 -Wuninitialized does not deduce are never used uninitialized.
9929 (detect_coding_iso_2022): Initialize a local variable that might
9930 be used uninitialized. Leave a FIXME because it's not clear that
9931 this initialization is needed. (Bug#8211)
9932 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9933 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9934 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9935 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9936 Remove unused macros.
9938 * category.c (hash_get_category_set): Remove unused local var.
9939 (copy_category_table): Now static, since it's not used elsewhere.
9940 * character.c (string_count_byte8): Likewise.
9942 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9943 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9945 * chartab.c (copy_sub_char_table): Now static, since it's not used
9947 (sub_char_table_ref_and_range, char_table_ref_and_range):
9948 Rename locals to avoid shadowing.
9949 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9951 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9952 (BIDI_BOB): Remove unused macro.
9954 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9955 deduce are never used uninitialized.
9956 * term.c (encode_terminal_code): Likewise.
9958 * term.c (encode_terminal_code): Now static. Remove unused local.
9960 * tparam.h: New file.
9961 * term.c, tparam.h: Include it.
9962 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9963 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9964 Move these decls to tparam.h, and make them agree with what
9965 is actually in tparam.c. The previous trick of using incompatible
9966 decls in different modules does not conform to the C standard.
9967 All callers of tparam changed to use tparam's actual API.
9968 * tparam.c (tparam1, tparam, tgoto):
9969 Use const pointers where appropriate.
9971 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9972 * cm.h (struct cm): Likewise.
9973 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9974 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9975 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9976 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9977 (turn_on_face, init_tty): Likewise.
9978 * termchar.h (struct tty_display_info): Likewise.
9980 * term.c (term_mouse_position): Rename local to avoid shadowing.
9982 * alloc.c (mark_ttys): Move decl from here ...
9983 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9985 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9987 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9989 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9991 * search.c (compile_pattern_1): Remove argument regp, unused since
9992 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9993 (compile_pattern): Don't pass it.
9995 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9997 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9998 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10000 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10002 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10004 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10005 gdk_window_get_screen, gdk_window_get_geometry,
10006 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10007 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10008 (xg_get_pixbuf_from_pixmap): New function.
10009 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10010 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10011 Call xg_get_pixbuf_from_pixmap instead of
10012 gdk_pixbuf_get_from_drawable.
10013 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10014 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10015 (xg_check_special_colors): Use GtkStyleContext and its functions
10017 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10018 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10019 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10020 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10021 Call gtk_widget_get_preferred_size.
10022 (xg_frame_resized): gdk_window_get_geometry only takes 5
10024 (xg_win_to_widget, xg_event_is_for_menubar):
10025 Call gdk_x11_window_lookup_for_display.
10026 (xg_set_widget_bg): New function.
10027 (delete_cb): New function.
10028 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10029 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10030 (xg_set_background_color): Call xg_set_widget_bg.
10031 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10032 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10033 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10034 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10036 (update_frame_tool_bar): Call gtk_widget_hide.
10037 (xg_initialize): Use GDK_KEY_g.
10039 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10041 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10043 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10044 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10045 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10047 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10049 * w32xfns.c (select_palette): Check success of RealizePalette against
10050 GDI_ERROR, not zero.
10052 See ChangeLog.11 for earlier changes.
10054 ;; Local Variables:
10058 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10060 This file is part of GNU Emacs.
10062 GNU Emacs is free software: you can redistribute it and/or modify
10063 it under the terms of the GNU General Public License as published by
10064 the Free Software Foundation, either version 3 of the License, or
10065 (at your option) any later version.
10067 GNU Emacs is distributed in the hope that it will be useful,
10068 but WITHOUT ANY WARRANTY; without even the implied warranty of
10069 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10070 GNU General Public License for more details.
10072 You should have received a copy of the GNU General Public License
10073 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.