Fixes: debbugs:11141
[bpt/emacs.git] / src / ChangeLog
1 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2
3 * w32menu.c (is_simple_dialog): Properly check lisp types.
4 (Bug#11141)
5
6 2012-03-31 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
9 position we get to after a call to move_it_to fails the
10 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
11 only if we wind up in a string from display property. (Bug#11063)
12
13 * window.c (Fdelete_other_windows_internal): Invalidate the row
14 and column information about mouse highlight, so that redisplay
15 restores it after reallocating the glyph matrices. (Bug#7464)
16
17 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
18 string comes from a `display' text property, use the buffer
19 position of that property as if we actually saw that position in
20 the row's glyphs.
21 (move_it_by_lines): Remove the assertion that
22 "it->current_x == 0 && it->hpos == 0" which can be legitimately
23 violated when there's a before-string at the beginning of a line.
24 (Bug#11063)
25
26 2012-03-30 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (append_space_for_newline): If the default face was
29 remapped, use the remapped face for the appended newline.
30 (extend_face_to_end_of_line): Use the remapped default face for
31 extending the face to the end of the line.
32 (display_line): Call extend_face_to_end_of_line when the default
33 face was remapped. (Bug#11068)
34
35 2012-03-29 Eli Zaretskii <eliz@gnu.org>
36
37 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
38
39 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
40
41 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
42
43 2012-03-27 Glenn Morris <rgm@gnu.org>
44
45 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
46 Doc fixes.
47
48 2012-03-26 Kenichi Handa <handa@m17n.org>
49
50 * dispextern.h (struct glyph): Fix previous change. Change the
51 bit length of glyphless.ch to 25 (Bug#11082).
52
53 2012-03-26 Chong Yidong <cyd@gnu.org>
54
55 * keyboard.c (Vselection_inhibit_update_commands): New variable.
56 (command_loop_1): Use it; inhibit selection update for
57 handle-select-window too (Bug#8996).
58
59 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
60
61 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
62
63 2012-03-25 Kenichi Handa <handa@m17n.org>
64
65 * dispextern.h (struct glyph): Change the bit length of
66 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
67
68 2012-03-24 Eli Zaretskii <eliz@gnu.org>
69
70 * s/ms-w32.h (tzname): Include time.h before redirecting to
71 _tzname. Fixes the MSVC build. (Bug#9960)
72
73 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
74
75 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
76 characters.
77
78 * xterm.c (XTread_socket): Only modify handling_signal if
79 !SYNC_INPUT. (Bug#11080)
80
81 2012-03-23 Eli Zaretskii <eliz@gnu.org>
82
83 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
84 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
85 when fetching a multibyte character consumes more bytes than
86 CHAR_BYTES returns, due to unification of CJK characters in
87 string_char. (Bug#11073)
88
89 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
90
91 * process.c (wait_reading_process_output): Handle pty disconnect
92 by refraining from sending oneself a SIGCHLD (bug#10933).
93
94 2012-03-22 Chong Yidong <cyd@gnu.org>
95
96 * dispextern.h (struct it): New member string_from_prefix_prop_p.
97
98 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
99 Mark string as coming from a prefix property.
100 (handle_face_prop): Use default face for prefix strings (Bug#4281).
101 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
102
103 2012-03-21 Chong Yidong <cyd@gnu.org>
104
105 * xfaces.c (Vface_remapping_alist): Doc fix.
106
107 2012-03-20 Eli Zaretskii <eliz@gnu.org>
108
109 * w32proc.c (Fw32_set_console_codepage)
110 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
111 Doc fixes.
112
113 2012-03-20 Chong Yidong <cyd@gnu.org>
114
115 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
116 to reflect default non-nil value of redisplay-dont-pause.
117
118 2012-03-19 Kenichi Handa <handa@m17n.org>
119
120 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
121 it fit in a valid range (Bug#11003).
122
123 2012-03-18 Eli Zaretskii <eliz@gnu.org>
124
125 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
126 that is not from display property, accept the row as a "cursor
127 row" if one of the string's character has a non-nil `cursor'
128 property. Fixes cursor positioning when there are newlines in
129 overlay strings, e.g. in icomplete.el. (Bug#11035)
130
131 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
132
133 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
134
135 2012-03-12 Chong Yidong <cyd@gnu.org>
136
137 * eval.c (inhibit_lisp_code): Rename from
138 inhibit_window_configuration_change_hook; move from window.c.
139
140 * xfns.c (unwind_create_frame_1, Fx_create_frame):
141 * window.c (run_window_configuration_change_hook)
142 (syms_of_window): Callers changed.
143
144 2012-03-11 Chong Yidong <cyd@gnu.org>
145
146 * keymap.c (Fkey_description): Doc fix (Bug#9700).
147
148 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
149
150 2012-03-10 Chong Yidong <cyd@gnu.org>
151
152 * frame.c (other_visible_frames): Don't assume the selected frame
153 is visible (Bug#10955).
154
155 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
156
157 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
158
159 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
160
161 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
162 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
163 zero (Bug#10954).
164
165 2012-03-03 Glenn Morris <rgm@gnu.org>
166
167 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
168
169 2012-03-02 Eli Zaretskii <eliz@gnu.org>
170
171 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
172 position past the first glyph_row that ends at ZV. (Bug#10902)
173 (redisplay_window, next_element_from_string): Fix typos in
174 comments.
175 (redisplay_window): Pass to move_it_vertically the margin in
176 pixels, not in screen lines.
177
178 2012-03-02 Glenn Morris <rgm@gnu.org>
179
180 * buffer.c (buffer-list-update-hook): Doc fix.
181
182 2012-02-29 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
185 push_it before setting up the iterator for the first overlay
186 string, even if we have an empty string loaded.
187 (next_overlay_string): If there's an empty string on the iterator
188 stack, pop the stack. (Bug#10903)
189
190 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
191
192 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
193 Suggested by Stefan Monnier in
194 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
195 * alloc.c (widen_to_Lisp_Object): New static function.
196 (mark_memory): Also mark Lisp_Objects by fetching pointer words
197 and widening them to Lisp_Objects. This would work even if
198 USE_LSB_TAG is defined and wide integers are used, which might
199 happen in a future version of Emacs.
200
201 2012-02-25 Chong Yidong <cyd@gnu.org>
202
203 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
204 Doc fix.
205
206 * xselect.c (Fx_selection_exists_p): Doc fix.
207 (x_clipboard_manager_save_all): Print an informative message
208 before saving to clipboard manager.
209
210 2012-02-24 Chong Yidong <cyd@gnu.org>
211
212 * keyboard.c (process_special_events): Handle all X selection
213 requests in kbd_buffer, not just the next one (Bug#8869).
214
215 2012-02-23 Chong Yidong <cyd@gnu.org>
216
217 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
218 call when setting menu-bar-lines and tool-bar-lines parameters.
219 (unwind_create_frame_1): New helper function.
220
221 * window.c (inhibit_window_configuration_change_hook): New var.
222 (run_window_configuration_change_hook): Obey it.
223 (syms_of_window): Initialize it.
224
225 2012-02-22 Chong Yidong <cyd@gnu.org>
226
227 * xterm.c (x_draw_image_relief): Add missing type check for
228 Vtool_bar_button_margin (Bug#10743).
229
230 2012-02-21 Chong Yidong <cyd@gnu.org>
231
232 * fileio.c (Vfile_name_handler_alist): Doc fix.
233
234 * buffer.c (Fget_file_buffer): Protect against invalid file
235 handler return value.
236
237 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
238
239 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
240 when computing $valmask.
241
242 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
243 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
244 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
245 It's useless in that case, and it can cause problems on hosts
246 that allocate halves of EMACS_INT values separately.
247 Reported by Dan Horák. Diagnosed by Andreas Schwab in
248 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
249 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
250 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
251 it avoids undefined behavior on hosts where shifting right by more
252 than the word width has undefined behavior.
253
254 2012-02-19 Chong Yidong <cyd@gnu.org>
255
256 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
257 (Funhandled_file_name_directory, Ffile_name_as_directory)
258 (Fdirectory_file_name, Fexpand_file_name)
259 (Fsubstitute_in_file_name): Protect against invalid file handler
260 return values (Bug#10845).
261
262 2012-02-18 Eli Zaretskii <eliz@gnu.org>
263
264 * .gdbinit (pitx): Fix incorrect references to fields of the
265 iterator stack.
266
267 2012-02-17 Chong Yidong <cyd@gnu.org>
268
269 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
270
271 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
272
273 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
274 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
275
276 2012-02-15 Chong Yidong <cyd@gnu.org>
277
278 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
279 marked as special. Also, starting docstrings with * is obsolete.
280
281 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
282
283 * gnutls.c (emacs_gnutls_write): Fix last change.
284
285 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
286
287 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
288 send_process.
289
290 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
291
292 * keymap.c (Fsingle_key_description): Handle char ranges.
293
294 2012-02-12 Chong Yidong <cyd@gnu.org>
295
296 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
297 as that creates a dangerous corner case.
298
299 * window.c (Fdelete_window_internal): Invalidate the mouse
300 highlight (Bug#9904).
301
302 2012-02-12 Glenn Morris <rgm@gnu.org>
303
304 * xselect.c (Fx_own_selection_internal)
305 (Fx_get_selection_internal, Fx_disown_selection_internal)
306 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
307 * nsselect.m (Fx_own_selection_internal)
308 (Fx_disown_selection_internal, Fx_selection_exists_p)
309 (Fx_selection_owner_p, Fx_get_selection_internal):
310 Sync docs and argument specs with the xselect.c versions.
311
312 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
313
314 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
315
316 2012-02-11 Eli Zaretskii <eliz@gnu.org>
317
318 * w32select.c (Fx_selection_exists_p): Sync doc string and
319 argument list with xselect.c. (Bug#10783)
320
321 * w16select.c (Fx_selection_exists_p): Sync doc string and
322 argument list with xselect.c. (Bug#10783)
323
324 2012-02-10 Glenn Morris <rgm@gnu.org>
325
326 * fns.c (Fsecure_hash): Doc fix.
327
328 2012-02-09 Kenichi Handa <handa@m17n.org>
329
330 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
331
332 2012-02-07 Chong Yidong <cyd@gnu.org>
333
334 * buffer.c (Fbuffer_local_variables)
335 (buffer_lisp_local_variables): Handle unbound vars correctly;
336 don't let Qunbound leak into Lisp.
337
338 2012-02-07 Glenn Morris <rgm@gnu.org>
339
340 * image.c (Fimagemagick_types): Doc fix.
341
342 * image.c (imagemagick-render-type): Change it from a lisp object
343 to an integer. Move the doc here from the lisp manual.
344 Treat all values not equal to 0 the same.
345
346 2012-02-06 Chong Yidong <cyd@gnu.org>
347
348 * doc.c (store_function_docstring): Avoid applying docstring of
349 alias to base function (Bug#2603).
350
351 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
352
353 * .gdbinit (pp1, pv1): Remove redundant defines.
354 (pr): Use pp.
355
356 2012-02-04 Chong Yidong <cyd@gnu.org>
357
358 * nsterm.m: Declare a global (Bug#10694).
359
360 2012-02-04 Eli Zaretskii <eliz@gnu.org>
361
362 * w32.c (get_emacs_configuration_options):
363 Include --enable-checking, if specified, in the return value.
364
365 2012-02-04 Martin Rudalics <rudalics@gmx.at>
366
367 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
368 after rounding frame sizes. (Bug#9723)
369
370 2012-02-04 Eli Zaretskii <eliz@gnu.org>
371
372 * keyboard.c (adjust_point_for_property): Don't position point
373 before BEGV. (Bug#10696)
374
375 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
376
377 Handle overflow when computing char display width (Bug#9496).
378 * character.c (char_width): Return EMACS_INT, not int.
379 (char_width, c_string_width): Check for overflow when
380 computing the width; this is possible now that individual
381 characters can have unbounded width. Problem introduced
382 by merge from Emacs 23 on 2012-01-19.
383
384 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
385
386 * dbusbind.c (Fdbus_register_method): Mention the return value
387 :ignore in the docstring.
388
389 2012-02-02 Glenn Morris <rgm@gnu.org>
390
391 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
392
393 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
394 Unconditionally set to t. (Bug#10673)
395 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
396 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
397 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
398
399 2012-02-02 Kenichi Handa <handa@m17n.org>
400
401 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
402 0, do not call append_composite_glyph.
403
404 2012-02-02 Kenichi Handa <handa@m17n.org>
405
406 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
407 NULL (Bug#6988).
408 (x_produce_glyphs): If the component of a composition is a null
409 string, set it->pixel_width to 1 to avoid zero-width glyph.
410
411 2012-02-01 Eli Zaretskii <eliz@gnu.org>
412
413 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
414 first 2 arguments are identical. This makes inserting large
415 output from a subprocess an order of magnitude faster on
416 MS-Windows, where all sbrk'ed memory is always contiguous.
417
418 2012-01-31 Glenn Morris <rgm@gnu.org>
419
420 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
421 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
422 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
423
424 2012-01-29 Glenn Morris <rgm@gnu.org>
425
426 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
427
428 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
429
430 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
431
432 2012-01-28 Chong Yidong <cyd@gnu.org>
433
434 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
435
436 2012-01-26 Chong Yidong <cyd@gnu.org>
437
438 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
439
440 * search.c (Fsearch_forward, Fsearch_backward): Document negative
441 repeat counts (Bug#10507).
442
443 2012-01-26 Glenn Morris <rgm@gnu.org>
444
445 * lread.c (syms_of_lread): Doc fix.
446
447 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
448
449 * coding.c (encode_designation_at_bol): Change return value to
450 EMACS_INT.
451
452 2012-01-25 Chong Yidong <cyd@gnu.org>
453
454 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
455
456 2012-01-21 Chong Yidong <cyd@gnu.org>
457
458 * floatfns.c (Fcopysign): Make the second argument non-optional,
459 since nil is not allowed anyway.
460
461 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
462
463 * process.c (read_process_output): Use p instead of XPROCESS (proc).
464 (send_process): Likewise.
465
466 2012-01-19 Martin Rudalics <rudalics@gmx.at>
467
468 * window.c (save_window_save, Fcurrent_window_configuration)
469 (Vwindow_persistent_parameters): Do not use Qstate.
470 Rewrite doc-strings.
471
472 2012-01-19 Kenichi Handa <handa@m17n.org>
473
474 * character.c (char_width): New function.
475 (Fchar_width, c_string_width, lisp_string_width):
476 Use char_width (Bug#9496).
477
478 2012-01-16 Martin Rudalics <rudalics@gmx.at>
479
480 * window.c (Vwindow_persistent_parameters): New variable.
481 (Fset_window_configuration, save_window_save): Handle persistent
482 window parameters.
483
484 2012-01-14 Eli Zaretskii <eliz@gnu.org>
485
486 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
487 thrashing the stack of the thread. (Bug#9087)
488
489 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
490
491 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
492
493 2012-01-11 Eli Zaretskii <eliz@gnu.org>
494
495 * xdisp.c (rows_from_pos_range): Handle the case where the
496 highlight ends on a newline. (Bug#10464)
497 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
498 he end column for display of highlight that ends on a newline
499 before a R2L line.
500
501 2012-01-11 Glenn Morris <rgm@gnu.org>
502
503 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
504 from load-path also when installation-directory is nil. (Bug#10208)
505
506 2012-01-10 Glenn Morris <rgm@gnu.org>
507
508 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
509
510 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
511 Update template values to be closer to their typical values these days.
512
513 2012-01-09 Eli Zaretskii <eliz@gnu.org>
514
515 * xdisp.c (rows_from_pos_range): Accept additional argument
516 DISP_STRING, and accept any glyph in a row whose object is that
517 string as eligible for mouse highlight. Fixes mouse highlight of
518 display strings from overlays. (Bug#10464)
519
520 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
521
522 emacs: fix an auto-save permissions race condition (Bug#10400)
523 * fileio.c (auto_saving_dir_umask): New static var.
524 (Fmake_directory_internal): Use it.
525 (do_auto_save_make_dir): Set it, instead of invoking chmod after
526 creating the directory. The old code temporarily assigns
527 too-generous permissions to the directory.
528 (do_auto_save_eh): Clear it.
529 (Fdo_auto_save): Catch all errors, not just file errors, so
530 that the var is always cleared.
531
532 2012-01-07 Eli Zaretskii <eliz@gnu.org>
533
534 * search.c (scan_buffer): Pass character positions to
535 know_region_cache, not byte positions. (Bug#6540)
536
537 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
538
539 * w32.c (sys_rename): Report EXDEV when rename of a directory
540 fails because the target is on another logical disk. (Bug#10284)
541
542 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
543
544 * xterm.c (x_embed_request_focus): New function.
545
546 * xterm.h: Add prototype.
547
548 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
549
550 2012-01-05 Glenn Morris <rgm@gnu.org>
551
552 * emacs.c (emacs_copyright): Update short copyright year to 2012.
553
554 2012-01-01 Eli Zaretskii <eliz@gnu.org>
555
556 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
557 Load gnutls_transport_set_lowat only if GnuTLS version is below
558 2.11.1.
559 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
560 GnuTLS versions below 2.11.1.
561
562 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
563
564 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
565 to the doc string advising against its use for altering the way
566 windows are scrolled.
567
568 2011-12-28 Kenichi Handa <handa@m17n.org>
569
570 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
571 coding-system ASCII compatible only when it does not produce BOM
572 on encoding (Bug#10383).
573
574 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
575
576 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
577 can scroll.
578 (create_and_show_popup_menu): Always use menu_position_func for
579 Gtk3 (Bug#10361).
580
581 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
582
583 * callint.c (Fcall_interactively): Don't truncate prompt string.
584
585 2011-12-23 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
588 property that ends at ZV, so that the bidi iteration could be
589 resumed from there (after widening). (Bug#10360)
590
591 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
592
593 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
594
595 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
596
597 * nsterm.m (x_free_frame_resources):
598 Release f->output_data.ns->miniimage.
599 (ns_index_color): Fix indentation. Do not retain
600 color_table->colors[i].
601
602 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
603 before returning.
604
605 * nsfns.m (x_set_background_color): Assign return value from
606 ns_index_color to face-background instead of NSColor*.
607 (ns_implicitly_set_icon_type): Fix indentation.
608 Change assignment in for loop to comparison.
609
610 * emacs.c (ns_pool): New variable.
611 (main): Assign ns_pool.
612 (Fkill_emacs): Call ns_release_autorelease_pool.
613
614 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
615 autorelease fdesc, release fdAttrs and tdict.
616 (ns_get_covering_families): Release charset.
617 (ns_findfonts): Release NSFontDescriptor created with new.
618 (ns_uni_to_glyphs): Fix indentation.
619 (setString): Release attrStr before assigning new value.
620
621 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
622
623 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
624 and NS_IMPL_COCOA.
625 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
626 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
627
628 2011-12-18 David Reitter <reitter@cmu.edu>
629
630 * nsterm.m (ns_term_init): Subscribe for notifications
631 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
632 to method trackingNotification in EmacsMenu.
633
634 * nsmenu.m (trackingMenu): New variable.
635 (trackingNotification): New method (from Aquamacs).
636 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
637 from Aquamacs (Bug#7030).
638
639 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
640
641 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
642 (symbol_to_nsstring): Fix indentation.
643 (ns_symbol_to_pb): New function.
644 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
645 (Fns_rotate_cut_buffers_internal): Remove.
646 (Fns_store_selection_internal): Rename from
647 Fns_store_cut_buffer_internal.
648 (ns_get_foreign_selection, Fx_own_selection_internal)
649 (Fx_disown_selection_internal, Fx_selection_exists_p)
650 (Fns_get_selection_internal, Fns_store_selection_internal):
651 Use ns_symbol_to_pb and check if return value is nil.
652 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
653 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
654 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
655 renamed to Sns_store_selection_internal.
656 (ns_handle_selection_request): Move code to Fx_own_selection_internal
657 and remove this function.
658 (ns_handle_selection_clear): Remove, never used.
659 (Fx_own_selection_internal): Move code from ns_handle_selection_request
660 here.
661
662 2011-12-17 Ken Brown <kbrown@cornell.edu>
663
664 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
665 GID is unknown (Bug#10257).
666
667 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
668
669 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
670 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
671 which caused a build failure on GNU/Linux IA-64. This problem was
672 introduced by my 2011-10-07 patch.
673
674 2011-12-15 Juri Linkov <juri@jurta.org>
675
676 * image.c (imagemagick_error): New function. (Bug#10112)
677 (imagemagick_load_image): Comment out `MagickSetResolution' call.
678 Use `imagemagick_error' where ImageMagick functions return
679 `MagickFalse'.
680 (Fimagemagick_types): Add `Fnreverse' to return the list in the
681 proper order.
682
683 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
684
685 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
686 fill background (Bug#8992).
687
688 2011-12-13 Martin Rudalics <rudalics@gmx.at>
689
690 * window.c (Vwindow_combination_resize)
691 (Vwindow_combination_limit): Use t instead of non-nil in
692 doc-strings.
693 (Vrecenter_redisplay): Add first sentence of doc-string on
694 separate line.
695 (Frecenter): Fix doc-string typo.
696
697 2011-12-11 Kenichi Handa <handa@m17n.org>
698
699 * coding.c (Funencodable_char_position): Pay attention to the
700 buffer text relocation (Bug#9389).
701
702 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
703
704 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
705 gtk_init (Bug#10100).
706
707 2011-12-10 Eli Zaretskii <eliz@gnu.org>
708
709 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
710 IT->string is nil. (Bug#10263)
711
712 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
713
714 * nsterm.h (x_free_frame_resources): Declare.
715
716 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
717 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
718
719 * nsterm.h (ns_get_defaults_value): Declare.
720
721 * nsterm.m (ns_default): Call ns_get_defaults_value.
722
723 2011-12-09 Eli Zaretskii <eliz@gnu.org>
724
725 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
726 (Bug#10170)
727
728 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
729
730 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
731 that where the value of an _OBJC_* symbol points to is in the .bss
732 section (Bug#10240).
733
734 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
735
736 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
737 after the loop to call ccl_driver at least once (Bug#8619).
738
739 2011-12-08 Kenichi Handa <handa@m17n.org>
740
741 * ftfont.c (get_adstyle_property): Fix previous change
742 (Bug#10233).
743
744 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
745
746 * w32.c (init_environment): If no_site_lisp, remove site-lisp
747 dirs from the default value of EMACSLOADPATH (bug#10208).
748
749 2011-12-07 Glenn Morris <rgm@gnu.org>
750
751 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
752 installation and source directories as well. (Bug#10208)
753
754 2011-12-06 Chong Yidong <cyd@gnu.org>
755
756 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
757
758 2011-12-06 Glenn Morris <rgm@gnu.org>
759
760 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
761 as an error, not just -1. (Bug#10217)
762
763 2011-12-05 Chong Yidong <cyd@gnu.org>
764
765 * keyboard.c (process_special_events): New function.
766 (swallow_events, Finput_pending_p): Use it (Bug#10195).
767
768 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
769
770 * coding.c (encode_designation_at_bol): Don't use uninitialized
771 local variable (Bug#9318).
772
773 2011-12-05 Kenichi Handa <handa@m17n.org>
774
775 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
776 return Qnil (Bug#8046, Bug#10193).
777
778 2011-12-05 Kenichi Handa <handa@m17n.org>
779
780 * coding.c (encode_designation_at_bol): New args charbuf_end and
781 dst. Return the number of produced bytes. Callers changed.
782 (coding_set_source): Return how many bytes coding->source was
783 relocated.
784 (coding_set_destination): Return how many bytes
785 coding->destination was relocated.
786 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
787 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
788
789 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
790
791 * coding.c (CODING_CHAR_CHARSET_P): New macro.
792 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
793 macro (Bug#9318).
794
795 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
796
797 The following changes are to fix Bug#9318.
798
799 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
800 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
801 (encode_coding_iso_2022, encode_coding_sjis)
802 (encode_coding_big5, encode_coding_charset): Use the above macros.
803
804 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
805
806 * lisp.h (process_quit_flag): Fix external declaration.
807
808 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
809
810 Don't macro-inline non-performance-critical code.
811 * eval.c (process_quit_flag): New function.
812 * lisp.h (QUIT): Use it.
813
814 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
815
816 * nsfns.m (get_geometry_from_preferences): New function.
817 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
818
819 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
820
821 * emacs.c (Qkill_emacs): Define.
822 (syms_of_emacs): Initialize it.
823 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
824 Qquit_flag to `kill-emacs' instead.
825 (quit_throw_to_read_char): Add parameter `from_signal'.
826 All callers changed. Call Fkill_emacs if requested and safe.
827 * lisp.h (QUIT): Call Fkill_emacs if requested.
828
829 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
830
831 * widget.c (update_wm_hints): Return if wmshell is null.
832 (widget_update_wm_size_hints): New function.
833
834 * widget.h (widget_update_wm_size_hints): Declare.
835
836 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
837 widget_update_wm_size_hints (Bug#10104).
838
839 2011-12-03 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (handle_invisible_prop): If the invisible text ends just
842 before a newline, prepare the bidi iterator for consuming the
843 newline, and keep the current paragraph direction. (Bug#10183)
844 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
845
846 2011-12-02 Juri Linkov <juri@jurta.org>
847
848 * search.c (Fword_search_regexp): New Lisp function created from
849 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
850 (Fword_search_backward, Fword_search_forward)
851 (Fword_search_backward_lax, Fword_search_forward_lax):
852 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
853 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
854
855 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
856
857 * fileio.c (Finsert_file_contents): Move after-change-function call
858 to before the "handled:" label, since all "goto handled" appear in
859 cases where the *-change-functions have already been properly called
860 (bug#10117).
861
862 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
863
864 * keyboard.c (interrupt_signal): Don't call kill-emacs when
865 waiting for input. (Bug#10169)
866
867 2011-11-30 Eli Zaretskii <eliz@gnu.org>
868
869 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
870 verifies glyph row's hash code--we have just reallocated the
871 glyphs, so their contents can be complete garbage. (Bug#10164)
872
873 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
874
875 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
876
877 2011-11-30 Eli Zaretskii <eliz@gnu.org>
878
879 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
880 attributes are tested _before_ calling verify_row_hash, to protect
881 against GCC re-ordering of the tests. (Bug#10164)
882
883 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
884
885 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
886
887 * xterm.c (handle_one_xevent): Only set async_visible and friends
888 if net_wm_state_hidden_seen is non-zero (Bug#10002)
889 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
890 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
891
892 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
893
894 Remove GCPRO-related macros that exist only to avoid shadowing locals.
895 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
896 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
897 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
898 All uses changed to use GCPRO1 etc.
899 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
900 Revert to old implementation (i.e., before 2011-03-11).
901
902 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
903
904 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
905 of scroll runs so as to avoid assigning disabled bogus rows and
906 unnecessary graphics copy operations.
907
908 2011-11-27 Eli Zaretskii <eliz@gnu.org>
909
910 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
911 (snprintf) [_MSC_VER]: Redirect to _snprintf.
912 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
913 (malloc, free, realloc, calloc): Redirect to e_* only when
914 compiling Emacs.
915
916 * lisp.h (GCTYPEBITS): Move before first use.
917 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
918 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
919 this macro definition.
920
921 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
922 _MSC_VER.
923
924 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
925
926 * gtkutil.c (xg_create_frame_widgets):
927 Call gtk_window_set_has_resize_grip (FALSE) if that function is
928 present with Gtk+ 2.0.
929
930 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
931
932 * fileio.c (Finsert_file_contents): Undo previous change; see
933 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
934
935 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
936
937 Rename locals to avoid shadowing.
938 * fileio.c (Finsert_file_contents):
939 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
940 * process.c (wait_reading_process_output):
941 Rename inner 'proc' to 'p' to avoid shadowing.
942 Indent for consistency with usual Emacs style.
943
944 2011-11-25 Eli Zaretskii <eliz@gnu.org>
945
946 * xdisp.c (redisplay_window): If cursor row is not fully visible
947 after recentering, and scroll-conservatively is set to a large
948 number, scroll window by a few more lines to make the cursor fully
949 visible and out of scroll-margin. (Bug#10105)
950 (start_display): Don't move to the next line if the display should
951 start at a newline that is part of a display vector or an overlay
952 string. (Bug#10119)
953
954 2011-11-24 Juri Linkov <juri@jurta.org>
955
956 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
957 after the `MagickPingImage' call. (Bug#10112)
958
959 2011-11-23 Chong Yidong <cyd@gnu.org>
960
961 * window.c (Fcoordinates_in_window_p): Accept only live windows.
962
963 2011-11-23 Martin Rudalics <rudalics@gmx.at>
964
965 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
966 making another buffer current. (Bug#10114)
967
968 2011-11-23 Glenn Morris <rgm@gnu.org>
969
970 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
971
972 2011-11-23 Chong Yidong <cyd@gnu.org>
973
974 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
975 using it (Bug#5984).
976
977 2011-11-22 Eli Zaretskii <eliz@gnu.org>
978
979 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
980 and header-lines, as they don't have one computed for them.
981 (Bug#10098)
982
983 * .gdbinit (prow): Make displayed values more self-explaining.
984 Add row's hash code.
985
986 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
987
988 * process.c (wait_reading_process_output): Fix asynchrounous
989 GnuTLS socket handling on some versions of the GnuTLS library.
990 (wait_reading_process_output): Add comment and URL.
991
992 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
993
994 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
995
996 2011-11-21 Chong Yidong <cyd@gnu.org>
997
998 * window.c (Fnext_window, Fprevious_window): Doc fix.
999
1000 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1001
1002 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1003
1004 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1005
1006 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1007
1008 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1009
1010 * window.c (Fset_window_combination_limit): Rename argument
1011 STATUS to LIMIT.
1012 (Vwindow_combination_limit): Remove "status" from doc-string.
1013
1014 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1015
1016 * m/ibms390.h: Remove.
1017 * m/ibms390x.h: Don't include "ibms390.h".
1018
1019 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1020
1021 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1022 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1023
1024 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * casetab.c (Fset_case_table):
1027 * charset.c (Fcharset_after): Fix typos.
1028
1029 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1030
1031 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1032 Otherwise, valgrind does not work on some platforms.
1033 Problem reported by Andreas Schwab in
1034 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1035 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1036 is set, removing the need for VIRT_ADDRESS_VARIES.
1037 (PURE_P): Use a more-efficient implementation that needs just one
1038 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1039 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1040 to 4 (xorl, subq, cmpq, setbe).
1041 * alloc.c (pure): Always extern now, since that's the
1042 VIRT_ADDR_VARIES behavior.
1043 (PURE_POINTER_P): Use a single comparison, not two, for
1044 consistency with the new puresize.h.
1045 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1046 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1047 Remove VIRT_ADDR_VARIES no longer needed.
1048
1049 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1050
1051 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1052 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1053 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1054 behave as if the cursor position were at the window margin.
1055
1056 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1057 and the cursor position is out of bounds, behave as if the cursor
1058 position were at the window margin. (Bug#10075)
1059
1060 2011-11-18 Chong Yidong <cyd@gnu.org>
1061
1062 * window.c (Fwindow_combination_limit): Make first argument
1063 non-optional, since it is meaningless for live windows like the
1064 selected window.
1065
1066 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1067
1068 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1069
1070 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1071
1072 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1073 (graft_intervals_into_buffer): Simplify.
1074
1075 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1076
1077 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1078 hash values of the two rows.
1079 (copy_row_except_pointers): Preserve the used[] arrays and the
1080 hash values of the two rows. (Bug#10035)
1081 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1082
1083 * xdisp.c (row_hash): New function, body extracted from
1084 compute_line_metrics.
1085 (compute_line_metrics): Call row_hash, instead of computing the
1086 hash code inline.
1087
1088 * dispnew.c (verify_row_hash): Call row_hash for computing the
1089 hash code of a row, instead of duplicating code from xdisp.c.
1090
1091 * dispextern.h (row_hash): Add prototype.
1092
1093 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1094
1095 * frame.c (delete_frame): Don't delete the terminal when the last
1096 X frame is closed if emacs is built with GTK toolkit.
1097
1098 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1099
1100 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1101
1102 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1103
1104 * window.c (Vwindow_splits): Rename to
1105 Vwindow_combination_resize. Suggested by Juri Linkov.
1106 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1107 of Vwindow_splits.
1108
1109 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1110
1111 * nsfns.m (Fns_font_name):
1112 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1113
1114 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1115
1116 * window.h (window): Rename slot "nest" to "combination_limit".
1117 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1118 (Fset_window_nest): Rename to Fset_window_combination_limit.
1119 (Vwindow_nest): Rename to Vwindow_combination_limit.
1120 (recombine_windows, make_parent_window, make_window)
1121 (Fsplit_window_internal, saved_window)
1122 (Fset_window_configuration, save_window_save): Rename all
1123 occurrences of window_nest to window_combination_limit.
1124
1125 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1126
1127 * image.c (imagemagick_load_image): Fix typo.
1128
1129 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1130
1131 * xdisp.c (display_line): Move the call to
1132 highlight_trailing_whitespace before the call to
1133 compute_line_metrics, since the latter needs to see the final
1134 faces of all the glyphs to compute ROW's hash value.
1135 Fixes assertion violations in row_equal_p. (Bug#10035)
1136
1137 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1138
1139 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1140 just return (bug#10044).
1141
1142 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1143
1144 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1145 with user-defined heap size. Bump the default size of the temacs
1146 heap to 27MB, to avoid memory warning when running temacs.
1147 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1148
1149 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1150 current_matrix and desired_matrix. (Bug#9990)
1151 (verify_row_hash) [XASSERTS]: New function.
1152 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1153 that the hash value of glyph rows is correct.
1154
1155 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1156
1157 * window.h (window): Remove splits slot.
1158 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1159 (Fdelete_other_windows_internal, make_parent_window)
1160 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1161 (Fset_window_configuration, save_window_save): Don't deal with
1162 split status of windows.
1163 (saved_window): Remove splits slot.
1164 (Vwindow_splits): Rewrite doc-string.
1165
1166 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1167
1168 * xfns.c (unwind_create_frame):
1169 * nsfns.m (unwind_create_frame):
1170 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1171 Vframe_list (Bug#9999).
1172
1173 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1174
1175 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1176
1177 2011-11-11 Kenichi Handa <handa@m17n.org>
1178
1179 * callproc.c (Fcall_process): Set the member dst_multibyte of
1180 process_coding.
1181
1182 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1183
1184 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1185 avoid a crash (bug#9496).
1186
1187 2011-11-09 Chong Yidong <cyd@gnu.org>
1188
1189 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1190 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1191
1192 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1193
1194 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1195
1196 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 Avoid some portability problems by eschewing 'extern inline' functions.
1199 The trivial performance wins aren't worth the portability hassles; see
1200 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1201 et seq.
1202 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1203 (window_box_width, window_box_left, window_box_left_offset)
1204 (window_box_right, window_box_right_offset): Undo previous change,
1205 by removing the "extern"s.
1206 * intervals.c (adjust_intervals_for_insertion)
1207 (adjust_intervals_for_deletion): Undo previous change,
1208 making these static again.
1209 (offset_intervals, temp_set_point_both, temp_set_point)
1210 (copy_intervals_to_string): No longer inline.
1211 * xdisp.c (window_text_bottom_y, window_box_width)
1212 (window_box_height, window_box_left_offset)
1213 (window_box_right_offset, window_box_left, window_box_right)
1214 (window_box): No longer inline.
1215
1216 2011-11-08 Chong Yidong <cyd@gnu.org>
1217
1218 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1219 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1220 Signal an error if not a live window.
1221 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1222 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1223
1224 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1225
1226 * lisp.h (syms_of_abbrev): Remove declaration.
1227 Reported by CHENG Gao <chenggao@royau.me>.
1228
1229 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1230
1231 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1232 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1233 of temacs in GUI mode.
1234
1235 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1236
1237 * window.h: Declare delete_all_child_windows instead of
1238 delete_all_subwindows.
1239 * window.c (Fwindow_nest, Fset_window_nest)
1240 (Fset_window_new_total, Fset_window_new_normal)
1241 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1242 (delete_all_subwindows): Rename to delete_all_child_windows.
1243 (Fdelete_other_windows_internal, Fset_window_configuration):
1244 Call delete_all_child_windows instead of delete_all_subwindows.
1245 * frame.c (delete_frame): Call delete_all_child_windows instead
1246 of delete_all_subwindows.
1247
1248 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1251 This is also needed for porting to any host where GC_MARK_STACK is
1252 not GC_MAKE_GCPROS_NOOPS.
1253 (which_symbols): Use it.
1254
1255 2011-11-07 Kenichi Handa <handa@m17n.org>
1256
1257 * coding.c (coding_set_destination): Check coding->src_pos only
1258 when coding->src_object is a buffer (bug#9910).
1259
1260 * process.c (send_process): Set the member src_multibyte of coding
1261 to 0 (bug#9911) when sending a unibyte text.
1262
1263 * callproc.c (Fcall_process): Set the member src_multibyte of
1264 process_coding to 0 (bug#9912).
1265
1266 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1267
1268 * xmenu.c (cleanup_widget_value_tree): New function.
1269 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1270 calling free_menubar_widget_value_tree directly (Bug#9830).
1271
1272 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 Fix some portability problems with 'inline'.
1275 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1276 (window_box_width, window_box_left, window_box_left_offset)
1277 (window_box_right, window_box_right_offset): Declare extern.
1278 Otherwise, these inline functions do not conform to C99 and
1279 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1280 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1281 * intervals.c (adjust_intervals_for_insertion)
1282 (adjust_intervals_for_deletion): Now extern, because otherwise the
1283 extern inline functions 'offset_intervals' couldn't refer to it.
1284 (static_offset_intervals): Remove.
1285 (offset_intervals): Rewrite using the old contents of
1286 static_offset_intervals. The old version didn't conform to C99
1287 because an extern inline function contained a reference to an
1288 identifier with static linkage.
1289
1290 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1291
1292 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1293 GC.
1294
1295 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1296
1297 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1298 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1299 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1300 return Qleft_to_right.
1301
1302 2011-11-06 Chong Yidong <cyd@gnu.org>
1303
1304 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1305 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1306 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1307 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1308 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1309 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1310 (Fwindow_vscroll): Doc fix.
1311 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1312 argument, since it makes no sense to pass a live window and for
1313 consistency with window-child.
1314
1315 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1316
1317 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1318 support MSVC.
1319
1320 2011-11-05 Jason Rumney <jasonr@gnu.org>
1321
1322 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1323 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1324 fonts (Bug#6029).
1325 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1326 bitwise arithmetic preventing use of unicode-sip and non-truetype
1327 opentype fonts.
1328
1329 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1330
1331 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1332 "emacs"-only part.
1333
1334 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1335 initialization code to keep similarity to xfns.c after changes
1336 from 2011-11-05.
1337
1338 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1339
1340 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1341 (unwind_create_frame): New function (Bug#9943).
1342 (Fx_create_frame): Restructure code to be more similar to the one in
1343 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1344 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1345 Move terminal->reference_count++ just before making the frame official
1346 (Bug#9943).
1347
1348 * nsterm.m (x_free_frame_resources): New function.
1349 (x_destroy_window): Move code to x_free_frame_resources.
1350
1351 * xfns.c (unwind_create_frame): Fix comment.
1352 (Fx_create_frame, x_create_tip_frame):
1353 Move terminal->reference_count++ just before making the frame
1354 official. Move initialization of image_cache_refcount and
1355 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1356
1357 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1358
1359 Support MSVC build with newer versions of Visual Studio.
1360 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1361 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1362 nt/gmake.defs.
1363
1364 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1365 which are not supported by MSVC.
1366 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1367 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1368 bitfields.
1369 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1370 types in bitfields.
1371 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1372
1373 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1374
1375 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1376
1377 Support MSVC build with newer versions of Visual Studio.
1378 * w32.c: Don't include w32api.h for MSVC.
1379 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1380
1381 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1382 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1383 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1384 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1385 e_* cousins.
1386 (alloca) [_MSC_VER]: Define to _alloca.
1387
1388 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1389
1390 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1391
1392 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1393
1394 * xdisp.c (note_mouse_highlight): If either of
1395 previous/next-single-property-change returns nil, treat that as
1396 the beginning or the end of the buffer. (Bug#9955)
1397
1398 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1399
1400 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1401 label is not null (Bug#9951).
1402 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1403 may be NULL.
1404
1405 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1406
1407 * window.c (Fwindow_body_size): Mention in the doc string that the
1408 return value is in frame's canonical units. (Bug#9949)
1409
1410 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1411
1412 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1413
1414 * w32fns.c (unwind_create_frame): If needed, free the glyph
1415 matrices of the partially constructed frame. (Bug#9943)
1416 * xfns.c (unwind_create_frame): Likewise.
1417
1418 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1419
1420 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1421 Don't stop backward scan on the continuation glyph, even though
1422 its CHARPOS is positive.
1423 (mouse_face_from_buffer_pos, note_mouse_highlight):
1424 Rename cover_string to disp_string.
1425
1426 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1427
1428 * window.c (temp_output_buffer_show): Don't use
1429 Vtemp_buffer_show_specifiers.
1430 (Vtemp_buffer_show_specifiers): Remove unused variable.
1431
1432 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1433
1434 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1435 past the beginning of the current glyph matrix.
1436
1437 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1438
1439 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1440 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1441 HAVE_GTK3 (Bug#9869).
1442
1443 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1444 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1445
1446 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1447
1448 * xterm.c: Declare x_handle_net_wm_state to return int.
1449 (handle_one_xevent): Check if we are iconified but don't have
1450 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1451 (get_current_wm_state): Return non-zero if not hidden,
1452 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1453 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1454 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1455 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1456
1457 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1460 so that this new function doesn't get optimized away by a
1461 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1462
1463 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1464
1465 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1466
1467 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1468
1469 Fix the `xbytecode' command.
1470 * .gdbinit (xprintbytestr): New command.
1471 (xwhichsymbols): Rename from `which'; all callers changed.
1472 (xbytecode): Print the byte-code string as well.
1473
1474 2011-10-29 Kim Storm <storm@cua.dk>
1475
1476 * alloc.c (which_symbols): New function.
1477
1478 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1479
1480 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1481 line. (Bug#9903)
1482
1483 2011-10-29 Glenn Morris <rgm@gnu.org>
1484
1485 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1486 Not clear what it was for, and it causes various bugs. (Bug#9839)
1487
1488 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1489
1490 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1491 possible random value that matches one of those tested as
1492 condition to clear the mouse face.
1493
1494 2011-10-28 Chong Yidong <cyd@gnu.org>
1495
1496 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1497
1498 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1499
1500 * window.c (make_window): Initialize phys_cursor_on_p.
1501
1502 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1503
1504 * lisp.h (struct Lisp_Symbol): Update comments.
1505
1506 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1509
1510 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1511
1512 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1513 <oslsachem@gmail.com> for helping to debug this.
1514
1515 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1516 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1517 (g_b_init_get_glyph_outline_w): New static variables.
1518 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1519 (GetGlyphOutlineW_Proc): New typedefs.
1520 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1521 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1522 New functions.
1523 (w32font_open_internal, compute_metrics):
1524 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1525 instead of calling the "wide" APIs directly.
1526
1527 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1528
1529 * w32.h (syms_of_w32font): Add prototype.
1530
1531 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1534 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1535 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1536 (Fmove_to_window_line): Doc fix.
1537
1538 2011-10-27 Chong Yidong <cyd@gnu.org>
1539
1540 * process.c (make_process): Set gnutls_state to NULL.
1541
1542 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1543 non-NULL, regardless of GNUTLS_INITSTAGE.
1544 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1545 an error. Set process slots as soon as we allocate them.
1546
1547 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1548
1549 2011-10-27 Chong Yidong <cyd@gnu.org>
1550
1551 * gnutls.c (emacs_gnutls_deinit): New function.
1552 Deallocate credentials structures as well as calling gnutls_deinit.
1553 (Fgnutls_deinit, Fgnutls_boot): Use it.
1554
1555 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1556 (deactivate_process): Call emacs_gnutls_deinit.
1557
1558 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1559
1560 * image.c (x_create_x_image_and_pixmap):
1561 * w32.c (sys_rename, w32_delayed_load):
1562 * w32font.c (fill_in_logfont):
1563 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1564
1565 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * w32fns.c (w32_default_color_map): New function,
1568 extracted from Fw32_default_color_map.
1569 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1570
1571 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1574
1575 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1576
1577 * keyboard.c (test_undefined): New function (bug#9751).
1578 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1579
1580 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1581
1582 * sysdep.c (init_sys_modes): Fix the check for the controlling
1583 terminal (Bug#6649).
1584
1585 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1586
1587 * dispextern.h (struct bidi_it): New member next_en_type.
1588
1589 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1590 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1591 current character, check also for next_en_type being WEAK_EN.
1592 (bidi_resolve_weak): Don't enter the expensive loop if the current
1593 position is before next_en_pos. Record the bidi type of the first
1594 non-ET, non-BN character we find, in addition to its position.
1595 (bidi_level_of_next_char): Invalidate next_en_type when
1596 next_en_pos is over-stepped.
1597
1598 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1601 * editfns.c: Rewrite current-time-zone so that it invokes
1602 the equivalent of (format-time-string "%Z") to get the time zone name.
1603 This fixes a bug when the time zone name contains characters that
1604 need converting from the system time locale to Emacs internal format.
1605 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1606 that patch fixed format-time-string to do the conversion, but
1607 I forgot to fix current-time-zone.
1608 (format_time_string): New function, containing most of
1609 what Fformat_time_string used to contain.
1610 (Fformat_time_string): Rewrite in terms of format_time_string.
1611 This doesn't change this function's behavior.
1612 (current-time-zone): Rewrite to use format_time_string.
1613 This fixes the bug reported by Michael Schierl in
1614 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1615 Jason Rumney's 2007-06-07 change worked around this bug, but
1616 didn't fix it.
1617 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1618
1619 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1620
1621 * xdisp.c (start_display): If the character at POS is displayed
1622 via a display vector, reset IT->current.dpvec_index to zero.
1623 (try_window_reusing_current_matrix): If a line ends in a display
1624 vector or the next line starts in a display vector, continue
1625 redrawing the window even though the character position of
1626 start_row was reached.
1627 (Bug#9771, part 2)
1628
1629 2011-10-18 Chong Yidong <cyd@gnu.org>
1630
1631 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1632 with nobreak-char-display too.
1633
1634 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1635
1636 Fix part 3 of bug#9771.
1637 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1638 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1639 non-neutral characters if the current character is a paragraph
1640 separator (a.k.a. Newline). This avoids running the same
1641 expensive loop twice, once when we consume the preceding newline
1642 and the other time when the line actually needs to be displayed.
1643 Avoid the loop when we see neutrals on the base embedding level
1644 following a character whose directionality is the same as the
1645 paragraph's. This avoids running the expensive loop when a line
1646 ends in a long sequence of neutrals, like control characters.
1647 Add assertion against STRONG_AL type. Slightly rearrange code
1648 that determines the type of a neutral given the first non-neutral
1649 that follows it.
1650 (bidi_level_of_next_char): Set next_en_pos to zero when
1651 invalidating its info.
1652
1653 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1654
1655 * xdisp.c (push_display_prop): Determine whether to record string
1656 or buffer position by IT->string, not by IT->method. Allow
1657 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1658 (move_it_vertically_backward): Don't look for character position
1659 immediately after the newline when in a continuation line.
1660 (Bug#9771, part 1)
1661
1662 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1663
1664 * window.c (coordinates_in_window): Rewrite and delabelize
1665 vertical border check. (Bug#5357) (Bug#9618)
1666
1667 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1668
1669 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1670 errors in XSetWindowBorder (bug#9310).
1671
1672 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1673
1674 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1675 avoid crash when xmalloc overrun checking is enabled.
1676
1677 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1680 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1681 cursor motion with <left> and <right> arrow keys.
1682
1683 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1684 some callers set that themselves.
1685
1686 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1687
1688 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1689 display string and the previous row comes from the same string and
1690 is empty. (Bug#9739) (Bug#9738)
1691
1692 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1693
1694 * doc.c (get_doc_string): Encode file name (bug#9735).
1695
1696 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1697
1698 * bidi.c (bidi_level_of_next_char):
1699 * xdisp.c (get_visually_first_element): Remove old incorrect
1700 comments regarding the Unicode Line Separator character.
1701
1702 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1703
1704 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1705
1706 * alloc.c (Fgc_status): Do not access beyond zombies array
1707 boundary if nzombies > MAX_ZOMBIES.
1708 * alloc.c (dump_zombies): Add missing format specifier.
1709
1710 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1713 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1714
1715 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1716 Some packages use them to denote characters with modifiers.
1717
1718 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1719
1720 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1721 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1722 matching a pp-number. Rename parameter var to var1.
1723
1724 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1725
1726 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1727
1728 2011-10-08 Glenn Morris <rgm@gnu.org>
1729
1730 * callint.c (Fcall_interactively): Give a more explicit error for the
1731 'c' case with a non-character input. (Bug#8479)
1732
1733 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1734
1735 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1736 lines.
1737 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1738 lines that are hscrolled on the left.
1739
1740 * dispnew.c (buffer_posn_from_coords): Account for a possible
1741 presence of header-line. (Bug#4426)
1742
1743 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1744
1745 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1746 Don't advertise functionality which we discourage or doesn't work.
1747
1748 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1751 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1752 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1753 this makes Emacs dump core during garbage collection on rare
1754 occasions. sizeof is obviously inferior to offsetof here, so
1755 stick with offsetof.
1756 (GC_POINTER_ALIGNMENT): New macro.
1757 (mark_memory): Omit 3rd (offset) arg; caller changed.
1758 Don't assume EMACS_INT alignment is the same as pointer alignment.
1759
1760 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1761
1762 * keyboard.c (read_key_sequence_remapped): New var.
1763 (read_key_sequence): Compute remapping in the right buffer.
1764 (command_loop_1): Use read_key_sequence's remapping directly.
1765
1766 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1767
1768 * dired.c (file_name_completion): Don't expand file name.
1769 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1770 before checking file name handler.
1771
1772 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1773 they've been requested explicitly (bug#9591).
1774
1775 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1776
1777 * keymap.c (Fsingle_key_description): Use make_specified_string
1778 instead of build_string to build string from push_key_description.
1779 (Bug#5193)
1780
1781 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1784 This fixes a Y2038 bug on 64-bit hosts.
1785 * buffer.c (reset_buffer):
1786 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1787 (Fclear_buffer_auto_save_failure):
1788 Use 0, not -1, to represent an unset failure time, since time_t
1789 might not be signed.
1790
1791 Remove dependency on glibc malloc internals.
1792 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1793 Move back here from lisp.h, but with their new implementations.
1794 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1795 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1796 * charset.c (charset_table_init): New static var.
1797 (syms_of_charset): Use it instead of xmalloc. This removes a
1798 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1799 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1800 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1801 Move back to alloc.c.
1802 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1803 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1804
1805 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1806
1807 * nsterm.m (windowDidResize): Call x_set_window_size only when
1808 ns_in_resize is true. Otherwise set pixelwidth/height and
1809 call change_frame_size (Bug#9628).
1810
1811 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 Port --enable-checking=all to Fedora 14 x86-64.
1814 * charset.c (syms_of_charset): Also account for glibc malloc's
1815 internal overhead when calculating the initial malloc maximum.
1816
1817 Port --enable-checking=all to Fedora 14 x86.
1818 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1819 Move to lisp.h.
1820 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1821 (overrun_check_realloc, overrun_check_free):
1822 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1823 That way, xmalloc returns a properly-aligned pointer even if
1824 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1825 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1826 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1827 into account when calculating the initial malloc maximum.
1828 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1829 Move here from alloc.c, so that charset.c can use it too.
1830 Properly align; the old code wasn't right for common 32-bit hosts
1831 when configured with --enable-checking=all.
1832 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1833 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1834
1835 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1836
1837 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1838 use EDOM.
1839
1840 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1841
1842 * xdisp.c (compute_display_string_end): If there's no display
1843 string at CHARPOS, return -1.
1844
1845 * bidi.c (bidi_fetch_char): When compute_display_string_end
1846 returns a negative value, treat the character as a normal
1847 character not covered by a display string. (Bug#9624)
1848
1849 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1850
1851 * lread.c (Fread_from_string): Fix typo in docstring.
1852
1853 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1854
1855 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1856 newline, reseat the iterator instead of bidi-iterating there one
1857 character at a time. (Bug#9610)
1858 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1859 TO_CHARPOS if the bidi iterator is at base embedding level.
1860
1861 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1862
1863 * lread.c (readevalloop): Use correct code for NBSP.
1864 (read1): Likewise. (Bug#9608)
1865
1866 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1867
1868 * dbusbind.c (Fdbus_register_signal): When service is not
1869 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1870
1871 2011-09-25 Glenn Morris <rgm@gnu.org>
1872
1873 * buffer.c (truncate-lines): Doc fix.
1874
1875 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1876
1877 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1878 (Fset_window_next_buffers): Doc fix.
1879
1880 2011-09-24 Glenn Morris <rgm@gnu.org>
1881
1882 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1883
1884 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1885
1886 Fix minor problems found by static checking.
1887 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1888 * indent.c (Fvertical_motion): Fix == vs = typo.
1889
1890 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1891
1892 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1893 Default value is now t. Doc fix.
1894
1895 * indent.c (Fvertical_motion): Compute and apply the overshoot
1896 logic when moving up, not only when moving down. Fix the
1897 confusing name and values of the it_overshoot_expected variable;
1898 logic changes accordingly. (Bug#9254) (Bug#9549)
1899
1900 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1901 CHARPOS is covered by a display string which includes newlines.
1902 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1903 is covered by a display string with embedded newlines.
1904
1905 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1906
1907 * dbusbind.c (Fdbus_register_signal): Add match rule to
1908 Vdbus_registered_objects_table. (Bug#9581)
1909 (Fdbus_register_method, Vdbus_registered_objects_table):
1910 Fix docstring.
1911
1912 2011-09-24 Jim Meyering <meyering@redhat.com>
1913
1914 do not ignore write error for any output size
1915 The previous change was incomplete.
1916 While it makes emacs --batch detect the vast majority of stdout
1917 write failures, errors were still ignored whenever the output size is
1918 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1919 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1920 && echo FAIL: ignored write error
1921 FAIL: ignored write error
1922 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1923 && echo FAIL: ignored write error
1924 FAIL: ignored write error
1925 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1926
1927 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1928
1929 * emacs.c (Fkill_emacs): In noninteractive mode exit
1930 non-successfully if a write error occurred on stdout. (Bug#9574)
1931
1932 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1933
1934 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1935 the xassert test.
1936
1937 * dispextern.h (struct it): Update the comment documenting what
1938 can it->OBJECT be.
1939
1940 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1941
1942 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1943 a display string, extend search for cursor position to end of row.
1944 (find_row_edges): If the row ends in a newline from a display
1945 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1946 Handle the case of a display string with multiple newlines.
1947 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1948 non-empty line. Fixes confusing cursor motion with arrow keys at
1949 the beginning of a line that starts with whitespace.
1950
1951 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1952
1953 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1954 (bug#9493).
1955
1956 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1959 boolean (Bug#9154).
1960
1961 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1962
1963 * xdisp.c (display_line): Record maximum and minimum buffer
1964 positions even if no glyphs were produced (e.g., by a zero-width
1965 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1966 buffer positions that will be removed from the glyph row because
1967 they don't fit.
1968 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1969 column is beyond frame width: don't subtract 1 "pixel" when
1970 computing width of the stretch.
1971 (reseat_at_next_visible_line_start): Undo the change made on
1972 2011-09-17 that saved paragraph information and restored it after
1973 the call to `reseat'. (Bug#9545)
1974
1975 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1976
1977 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1978 and turn window cursor on if cleared (Bug#9415).
1979
1980 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1981
1982 * search.c (boyer_moore): Take unibyte characters from pattern
1983 literally. (Bug#9458)
1984
1985 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1986
1987 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1988
1989 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 Fix minor problem found by static checking.
1992 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1993 initialized, to pacify gcc -Wuninitialized.
1994
1995 * fileio.c: Report proper errno when syscall falls.
1996 (Finsert_file_contents): Save and restore errno,
1997 so that report_file_error outputs the correct diagnostic.
1998 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1999
2000 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2001
2002 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2003
2004 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2007 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2008
2009 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2010
2011 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2012 about the current paragraph and restore it after the call to reseat.
2013
2014 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2015 (bidi_find_paragraph_start): Search back for paragraph beginning
2016 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2017 (bidi_move_to_visually_next): Only trigger paragraph-related
2018 computations when the last character is a newline or at EOB, not
2019 just any NEUTRAL_B. (Bug#9470)
2020
2021 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2022 truncated lines if point is covered by a display string. (Bug#9524)
2023
2024 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2027 (cons_to_x_long): New function.
2028 (lisp_data_to_selection_data): Use it. Correct the test for
2029 short-versus-long data; it was negated. Break out of vector
2030 loop, for efficiency, when a long datum is discovered.
2031
2032 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2033
2034 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2035
2036 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2037
2038 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2039 GCC PR/17406) by declaring this function with external scope.
2040
2041 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2044 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2045
2046 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2047
2048 * editfns.c (Fformat): Correctly handle text properties on "%%".
2049
2050 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2051
2052 * xterm.c (x_draw_composite_glyph_string_foreground):
2053 * w32term.c (x_draw_composite_glyph_string_foreground):
2054 * term.c (encode_terminal_code):
2055 * composite.c (composition_update_it, get_composition_id):
2056 * xdisp.c (get_next_display_element)
2057 (fill_composite_glyph_string): Add comments about special meaning
2058 of TAB characters in a composition.
2059
2060 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2061
2062 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2063 This occurs when processing a multibyte format.
2064 Problem reported by Wolfgang Jenker.
2065
2066 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2067
2068 * xdisp.c (try_cursor_movement): Only check for exact match if
2069 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2070
2071 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 Remove unused external symbols.
2074 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2075 * xdisp.c (calc_pixel_width_or_height): Now static.
2076 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2077 * indent.c (check_display_width):
2078 * w32term.c: Fix comment to match code.
2079 * xterm.c, xterm.h (x_catching_errors): Remove.
2080
2081 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * xselect.c: Use signed conversions more consistently (Bug#9498).
2084 (selection_data_to_lisp_data): Assume incoming selection data are
2085 signed integers, not unsigned. This is to be consistent with
2086 outgoing selection data, which was modified to use signed integers
2087 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2088 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2089 expects long, not unsigned long.
2090
2091 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2092
2093 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2094 computation of loop end. Reported by Johan Bockgård
2095 <bojohan@gnu.org>.
2096
2097 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2098
2099 * frame.c (Fother_visible_frames_p): Function deleted.
2100
2101 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2102
2103 * indent.c (compute_motion): Process display vector front to back
2104 rather than the other way around. (Bug#2496)
2105
2106 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2107
2108 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2109
2110 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2111
2112 * minibuf.c (Fread_from_minibuffer): Doc fix.
2113
2114 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2115
2116 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2117 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2118
2119 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2120
2121 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2122 value for non-existent files.
2123
2124 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2125
2126 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2127 set its "size" to -1. This will set the modtime_size field of
2128 the corresponding buffer to -1, which is what
2129 verify-visited-file-modtime expects for files that do not exist.
2130 (Bug#9139)
2131
2132 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2135 here ...
2136 * lisp.h: ... from here. push_key_description is no longer
2137 defined in keyboard.c, so its declaration should not be in
2138 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2139 logically belongs with push_key_description.
2140
2141 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2142
2143 * buffer.h: Include <sys/types.h> instead of <time.h>.
2144 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2145 Problem reported by Herbert J. Skuhra.
2146
2147 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2148
2149 * xml.c (parse_region): Make the parsing work for
2150 non-comment-starting XML files again (bug#9144).
2151
2152 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2153
2154 * image.c (gif_load): Fix calculation of bottom and right corner.
2155 (Bug#9468)
2156
2157 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2158
2159 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2160 redisplay in small windows.
2161
2162 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2163
2164 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2165
2166 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2167
2168 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2169 Operate on live windows only.
2170
2171 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2172
2173 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2174
2175 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2176
2177 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2178 only under bidi iteration.
2179
2180 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2181
2182 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2183
2184 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2187 Without this fix, the command to link temacs failed due to an
2188 undefined symbol __builtin_isnan. This is because
2189 /usr/include/iso/math_c99.h #defines isnan(x) to
2190 __builtin_isnan(x), but the bundled gcc, which identifies itself
2191 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2192 a __builtin_isnan.
2193 * floatfns.c (isnan): #undef, and then #define to a clone of
2194 what's in data.c.
2195 (Fisnan): Always define, since it's always available now.
2196 (syms_of_floatfns): Always define isnan at the Lisp level.
2197
2198 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2201
2202 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2205 The previous code assumed that file offsets (off_t values) fit in
2206 EMACS_INT variables, which is not true on typical 32-bit hosts.
2207 The code messed up by falsely reporting buffer overflow in cases
2208 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2209 when "big" contains more than 2**29 bytes, even though this
2210 inserts just one byte and does not overflow the buffer.
2211 (Finsert_file_contents): Store file offsets as off_t
2212 values, not as EMACS_INT values. Check for overflow when
2213 converting between EMACS_INT and off_t. When checking for
2214 buffer overflow or for overlap, take the offsets into account.
2215 Don't use EMACS_INT for small values where int suffices.
2216 When checking for overlap, fix a typo: ZV was used where
2217 ZV_BYTE was intended.
2218 (Fwrite_region): Don't assume off_t fits into 'long'.
2219 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2220
2221 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2222
2223 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2224
2225 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 sprintf-related integer and memory overflow issues (Bug#9412).
2228
2229 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2230 (esprintf, exprintf, evxprintf): New functions.
2231 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2232 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2233 (modify_event_symbol): Do not assume that the length of
2234 name_alist_or_stem is safe to alloca and fits in int.
2235 (Fexecute_extended_command): Likewise for function name and binding.
2236 (Frecursion_depth): Wrap around reliably on integer overflow.
2237 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2238 since some callers pass EMACS_INT values.
2239 (Fsingle_key_description): Don't crash if symbol name contains more
2240 than MAX_ALLOCA bytes.
2241 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2242 (get_minibuffer): Arg is now EMACS_INT, not int.
2243 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2244 (esprintf, exprintf, evxprintf): New decls.
2245 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2246
2247 * dbusbind.c (signature_cat): New function.
2248 (xd_signature, Fdbus_register_signal):
2249 Do not overrun buffer; instead, report string overflow.
2250
2251 * dispnew.c (add_window_display_history): Don't overrun buffer.
2252 Truncate instead; this is OK since it's just a log.
2253
2254 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2255 even if the time zone offset is outlandishly large.
2256 Don't mishandle offset == INT_MIN.
2257
2258 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2259 when creating daemon; the previous buffer-overflow check was incorrect.
2260
2261 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2262 which has the guts of the old verror function.
2263
2264 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2265 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2266
2267 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2268 (font_unparse_xlfd): Don't blindly alloca long strings.
2269 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2270 fits in int, when using sprintf. Use single snprintf to count
2271 length of string rather than counting it via multiple sprintfs;
2272 that's simpler and more reliable.
2273 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2274 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2275 sprintf, in case result does not fit in int.
2276
2277 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2278 (fontset_from_font): Print it.
2279
2280 * frame.c (tty_frame_count): Now printmax_t, not int.
2281 (make_terminal_frame, set_term_frame_name): Print it.
2282 (x_report_frame_params): In X, window IDs are unsigned long,
2283 not signed long, so print them as unsigned.
2284 (validate_x_resource_name): Check for implausibly long names,
2285 and don't assume name length fits in 'int'.
2286 (x_get_resource_string): Don't blindly alloca invocation name;
2287 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2288 not fit in int.
2289
2290 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2291 (xg_check_special_colors, xg_set_geometry):
2292 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2293
2294 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2295 Use esprintf, not sprintf, in case result does not fit in int.
2296
2297 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2298 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2299 it as a large positive number.
2300 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2301 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2302
2303 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2304 in case result does not fit in int.
2305
2306 * print.c (float_to_string): Detect width overflow more reliably.
2307 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2308 buffer overrun. Don't assume list length fits in 'int'. Treat
2309 print length of 0 as 0, not as infinity; to be consistent with other
2310 uses of print length in this function. Don't overflow print length
2311 index. Don't assume hash table size fits in 'long', or that
2312 vectorlike size fits in 'unsigned long'.
2313
2314 * process.c (make_process): Use printmax_t, not int, to format
2315 process-name gensyms.
2316
2317 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2318
2319 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2320 to avoid potential buffer overrun.
2321
2322 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2323 if X resource line is longer than 512 bytes.
2324
2325 * xfns.c (x_window): Make sprintf buffer a bit bigger
2326 to avoid potential buffer overrun.
2327
2328 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2329
2330 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2331
2332 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2333
2334 Integer overflow fixes for scrolling, etc.
2335 Without these, Emacs silently mishandles large integers sometimes.
2336 For example, "C-u 4294967297 M-x recenter" was treated as if
2337 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2338
2339 * xdisp.c (try_window_id): Check Emacs fixnum range before
2340 converting to 'int'.
2341
2342 * window.c (window_scroll_line_based, Frecenter):
2343 Check that an Emacs fixnum is in range before assigning it to 'int'.
2344 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2345 values converted from Emacs fixnums.
2346 (Frecenter): Don't wrap around a line count if it is out of 'int'
2347 range; instead, treat it as an extreme value.
2348 (Fset_window_configuration, compare_window_configurations):
2349 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2350
2351 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2352 that can exceed INT_MAX. Check that EMACS_INT value is in range
2353 before assigning it to the (possibly-narrower) index.
2354 (match_limit): Don't assume that a fixnum can fit in 'int'.
2355
2356 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2357 exceed INT_MAX.
2358
2359 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2360 (Fvertical_motion): Don't wrap around LINES values that don't fit
2361 in 'int'. Instead, treat them as extreme values. This is good
2362 enough for windows, which can't have more than INT_MAX lines anyway.
2363
2364 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2365
2366 * Require libxml/parser.h to avoid compilation warning.
2367
2368 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2369
2370 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2371 since this reportedly can destroy thread storage.
2372
2373 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2374
2375 * syntax.c (find_defun_start): Update all cache variables if
2376 exiting early (Bug#9401).
2377
2378 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2379
2380 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2381
2382 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2383 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2384 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2385
2386 * term.c (tty_append_glyph): New function.
2387 (produce_stretch_glyph): Static function and its prototype deleted.
2388
2389 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2390 Add prototypes.
2391
2392 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2395 when checking :margin (Bug#9390).
2396 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2397 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2398 so that the name doesn't mislead. All uses changed.
2399
2400 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2401
2402 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2403 set_tty_hooks.
2404
2405 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2406
2407 * xdisp.c (move_it_to): Don't bail out early when reaching
2408 position beyond to_charpos, if we are scanning backwards.
2409 (move_it_vertically_backward): When DY == 0, make sure we get to
2410 the first character in the line after the newline.
2411
2412 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2415 (ccl_driver): Do not generate an out-of-range pointer.
2416 (Fccl_execute_on_string): Remove unnecessary check for
2417 integer overflow, noted by Stefan Monnier in
2418 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2419 Remove a FIXME that didn't need fixing.
2420 Simplify the newly-introduced buffer reallocation code.
2421
2422 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2423
2424 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2425
2426 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2427
2428 Integer and memory overflow issues (Bug#9196).
2429
2430 * doc.c (get_doc_string): Rework so that
2431 get_doc_string_buffer_size is the actual buffer size, rather than
2432 being 1 less than the actual buffer size; this makes xpalloc more
2433 convenient.
2434
2435 * image.c (x_allocate_bitmap_record, cache_image):
2436 * xselect.c (Fx_register_dnd_atom):
2437 Simplify previous changes by using xpalloc.
2438
2439 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2440 since either will do and ptrdiff_t is convenient with xpalloc.
2441
2442 * charset.c (charset_table_size)
2443 (struct charset_sort_data.priority): Now ptrdiff_t.
2444 (charset_compare): Don't overflow if priorities differ greatly.
2445 (Fsort_charsets): Don't assume list length fits in int.
2446 Check for size-calculation overflow when allocating sort data.
2447 (syms_of_charset): Allocate an initial charset table that is
2448 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2449
2450 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2451
2452 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2453 The actual value is always <= INT_MAX, and leaving it unsigned made
2454 overflow checking harder.
2455
2456 * dispextern.h (struct glyph_matrix.rows_allocated)
2457 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2458 with xpalloc. The values are still always <= INT_MAX.
2459
2460 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2461
2462 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2463 (SAFE_NALLOCA): New macro.
2464
2465 * region-cache.c (struct boundary.pos, find_cache_boundary)
2466 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2467 (set_cache_region, invalidate_region_cache)
2468 (revalidate_region_cache, know_region_cache, region_cache_forward)
2469 (region_cache_backward, pp_cache):
2470 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2471 so that ptrdiff_t * can be passed to xpalloc.
2472 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2473 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2474 (pp_cache): Don't assume cache_len fits in int.
2475 * region-cache.h: Adjust extern decls to match.
2476
2477 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2478 EMACS_INT, since either will do, for xpalloc.
2479
2480 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2481 (xnmalloc, xnrealloc, xpalloc): New functions.
2482
2483 * bidi.c (bidi_shelve_header_size): New constant.
2484 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2485 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2486
2487 * bidi.c (bidi_cache_shrink):
2488 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2489 (overlay_strings):
2490 Don't update size of array until after memory allocation succeeds,
2491 because xmalloc/xrealloc may not return.
2492 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2493 now that we have proper integer overflow checking.
2494 (record_overlay_string, overlay_strings): Catch overflows when
2495 calculating size of overlay_str_buf.
2496
2497 * callproc.c (Fcall_process): Check for size overflow when
2498 calculating size of args2.
2499 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2500 Normally we prefer signed values, but sticking with ptrdiff_t would
2501 require adding more-complicated checks.
2502
2503 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2504 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2505 Redo buffer-overflow calculations to avoid integer overflow.
2506 Add a FIXME comment where memory seems to be over-allocated.
2507
2508 * character.c (Fstring): Check for size-calculation overflow.
2509
2510 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2511 unnecessary integer overflow. Check for size overflow.
2512 (encode_coding_object): Don't update size until xmalloc succeeds.
2513
2514 * composite.c (get_composition_id): Check for overflow in glyph
2515 length calculations.
2516
2517 Integer and memory overflow fixes for display code.
2518 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2519 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2520 (scrolling_window): Check for overflow in size calculations.
2521 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2522 Don't assume glyph table len fits in int.
2523 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2524 (row_table_size): Now ptrdiff_t, not int.
2525 (scrolling_window): Avoid overflow in size calculations.
2526 Don't update size until allocation succeeds.
2527 * fns.c (concat): Check for overflow in size calculations.
2528 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2529 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2530 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2531
2532 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2533 (get_doc_string): Check for size calculation overflow.
2534 Don't update size until allocation succeeds.
2535 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2536 EMACS_INT, where ptrdiff_t will do.
2537 (Fsubstitute_command_keys): Check for string overflow.
2538
2539 * editfns.c (set_time_zone_rule): Don't assume environment length
2540 fits in int.
2541 (message_length): Now ptrdiff_t, not int.
2542 (Fmessage_box): Don't update size until allocation succeeds.
2543 Don't assume message length fits in int.
2544 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2545
2546 * emacs.c (main): Do not reallocate argv, since there is a null at
2547 the end that can be overwritten, and this way there's no need to
2548 worry about size-calculation overflow.
2549 (sort_args): Check for size-calculation overflow.
2550
2551 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2552 alloc succeeds.
2553 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2554
2555 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2556 (x_set_scroll_bar_width, x_figure_window_size):
2557 Check for integer overflow.
2558 (x_set_alpha): Do not assume XINT fits in int.
2559
2560 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2561 This is for the members text_lines, text_cols, total_lines, total_cols,
2562 where the system imposes an 'int' limit.
2563
2564 * fringe.c (Fdefine_fringe_bitmap):
2565 Don't update size until alloc works.
2566
2567 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2568 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2569
2570 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2571 Check for size-calculation overflow.
2572 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2573 do, as we prefer signed integers.
2574 (id_to_widget.max_size, id_to_widget.used)
2575 (xg_store_widget_in_map, xg_remove_widget_from_map)
2576 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2577 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2578 Use and return ptrdiff_t, not int.
2579 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2580 * gtkutil.h: Change prototypes to match the above.
2581
2582 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2583 are duplicate now that they've been promoted to lisp.h.
2584 (x_allocate_bitmap_record, x_alloc_image_color)
2585 (make_image_cache, cache_image, xpm_load):
2586 Don't update size until alloc is done.
2587 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2588 (x_detect_edges):
2589 Check for size calculation overflow.
2590 (ct_colors_allocated_max): New constant.
2591 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2592 overflow.
2593
2594 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2595 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2596 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2597 Use ptrdiff_t, not int, to count maps.
2598 (read_char_minibuf_menu_prompt): Check for overflow in size
2599 calculations. Don't update size until allocation succeeds.
2600 Redo calculations to avoid overflow.
2601 * keyboard.h: Change prototypes to match the above.
2602
2603 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2604 to count maps.
2605 (current_minor_maps): Check for size calculation overflow.
2606 * keymap.h: Change prototypes to match the above.
2607
2608 * lread.c (read1, init_obarray): Don't update size until alloc done.
2609
2610 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2611 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2612
2613 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2614 Now ptrdiff_t, not int.
2615 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2616 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2617
2618 * process.c (Fnetwork_interface_list): Check for overflow
2619 in size calculation.
2620
2621 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2622
2623 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2624 overflow. Don't bother calling xmalloc when xrealloc will do.
2625
2626 * search.c (Freplace_match): Check for size calculation overflow.
2627 (Fset_match_data): Don't assume list lengths fit in 'int'.
2628
2629 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2630 for command line length. Do not attempt to address one before the
2631 beginning of an array, as that's not portable.
2632
2633 * term.c (max_frame_lines): Remove; unused.
2634 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2635 not int.
2636 (encode_terminal_code, calculate_costs): Check for size
2637 calculation overflow.
2638 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2639 table lengths and related sizes. Don't update size until alloc
2640 done. Redo calculations to avoid overflow.
2641 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2642
2643 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2644 subtracting pointers.
2645 (gobble_line): Check for overflow more carefully. Don't update size
2646 until alloc done.
2647
2648 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2649 Don't update size until alloc done.
2650 Redo size calculations to avoid overflow.
2651 Check for size calculation overflow.
2652 (main) [DEBUG]: Fix typo in invoking tparam1.
2653
2654 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2655 Use ptrdiff_t, not int, for sizes.
2656 (store_mode_line_noprop_char): Don't update size until alloc done.
2657
2658 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2659 Use ptrdiff_t, not int, for sizes.
2660 (Finternal_make_lisp_face, cache_face):
2661 Check for size calculation overflow.
2662 (cache_face): Treat size calculation overflows as if they were
2663 memory exhaustion (the usual treatment), rather than aborting.
2664
2665 * xfns.c (x_encode_text, x_set_name_internal)
2666 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2667 sizes, since they can exceed INT_MAX in size. Check for size
2668 calculation overflow.
2669
2670 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2671 (xg_select): Check for size calculation overflow.
2672 Don't update size until alloc done.
2673
2674 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2675 as sprintf is limited to int lengths.
2676
2677 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2678 (X_LONG_MIN): New macros.
2679 Use them to make the following changes clearer.
2680 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2681 This change doesn't affect the value now, but it may help remind
2682 future maintainers not to raise the value too much later.
2683 (SELECTION_QUANTUM): Remove, replacing with ...
2684 (selection_quantum): ... new function, which avoids overflow.
2685 All uses changed.
2686 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2687 assumption that selection length fits in 'int'.
2688 (x_reply_selection_request, x_handle_selection_request)
2689 (x_get_window_property, receive_incremental_selection)
2690 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2691 (lisp_data_to_selection_data, clean_local_selection_data):
2692 Use ptrdiff_t, not int, to record length of selection.
2693 (x_reply_selection_request, x_get_window_property)
2694 (receive_incremental_selection, x_property_data_to_lisp):
2695 Redo calculations to avoid overflow.
2696 (x_reply_selection_request): When sending hint, ceiling it at
2697 X_LONG_MAX rather than relying on wraparound overflow to send
2698 something.
2699 (x_get_window_property, receive_incremental_selection)
2700 (lisp_data_to_selection_data, x_property_data_to_lisp):
2701 Check for size-calculation overflow.
2702 (x_get_window_property, receive_incremental_selection)
2703 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2704 Don't store size until memory allocation succeeds.
2705 (x_get_window_property): Plug memory leak on memory exhaustion.
2706 Don't double-block input; malloc is safe here. Don't assume 2**34
2707 - 4 fits in unsigned long. Add an xassert to check
2708 XGetWindowProperty overflow. Be more careful about overflow
2709 calculations, and distinguish size from memory overflow better.
2710 (receive_incremental_selection): When tracing, don't assume
2711 unsigned int is less than INT_MAX.
2712 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2713 harmful) conversions of unsigned short to int.
2714 (lisp_data_to_selection_data): Don't assume that integers
2715 in the range -65535 through -1 fit in an X unsigned short.
2716 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2717 result parameters unless successful. Rely on cons_to_unsigned
2718 to report problems with elements; the old code wasn't right anyway.
2719 (x_check_property_data): Check for int overflow; we cannot use
2720 a wider type due to X limits.
2721 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2722
2723 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2724
2725 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2726 (x_term_init): Check for size calculation overflow.
2727 (x_color_cells): Don't store size until memory allocation succeeds.
2728 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2729 Don't assume alloca size is less than MAX_ALLOCA.
2730 (x_term_init): Don't assume length fits in int (sprintf is limited
2731 to int size).
2732
2733 Use ptrdiff_t for composition IDs.
2734 * character.c (lisp_string_width):
2735 * composite.c (composition_table_size, n_compositions)
2736 (get_composition_id, composition_gstring_from_id):
2737 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2738 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2739 * window.c (Frecenter):
2740 Use ptrdiff_t, not int, for composition IDs.
2741 * composite.c (get_composition_id): Check for integer overflow.
2742 * composite.h: Adjust prototypes to match the above changes.
2743
2744 Use ptrdiff_t for hash table indexes.
2745 * category.c (hash_get_category_set):
2746 * ccl.c (ccl_driver):
2747 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2748 * coding.c (coding_system_charset_list, detect_coding_system):
2749 * coding.h (struct coding_system.id):
2750 * composite.c (get_composition_id, gstring_lookup_cache):
2751 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2752 * image.c (xpm_get_color_table_h):
2753 * lisp.h (hash_lookup, hash_put):
2754 * minibuf.c (Ftest_completion):
2755 Use ptrdiff_t for hash table indexes, not int (which is too
2756 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2757 32-bit --with-wide-int hosts).
2758
2759 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2760 Add a FIXME comment about memory leaks.
2761 (syms_of_charset): Don't assume xmalloc returns.
2762
2763 Don't assume that stated character widths fit in int.
2764 * character.c (Fchar_width, c_string_width, lisp_string_width):
2765 * character.h (CHAR_WIDTH):
2766 * indent.c (MULTIBYTE_BYTES_WIDTH):
2767 Use sanitize_char_width to avoid undefined and/or bad behavior
2768 with outlandish widths.
2769 * character.h (sanitize_tab_width): Rename from sanitize_width,
2770 now that we have two such functions. All uses changed.
2771 (sanitize_char_width): New inline function.
2772
2773 Don't assume that tab-width fits in int.
2774 * character.h (sanitize_width): New inline function.
2775 (SANE_TAB_WIDTH): New macro.
2776 (ASCII_CHAR_WIDTH): Use it.
2777 * indent.c (sane_tab_width): Remove. All uses replaced by
2778 SANE_TAB_WIDTH (current_buffer).
2779 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2780
2781 * fileio.c: Integer overflow issues with file modes.
2782 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2783
2784 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2785 Remove unreachable code.
2786 (read_hex, load_charset_map_from_file): Check for integer overflow.
2787
2788 * xterm.c: Don't go over XClientMessageEvent limit.
2789 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2790 (x_send_scroll_bar_event): Likewise. Check that the size does not
2791 exceed limits imposed by XClientMessageEvent, as well as the usual
2792 ptrdiff_t and size_t limits.
2793
2794 * keyboard.c: Overflow, signedness and related fixes.
2795 (make_lispy_movement): Use same integer type in forward decl
2796 that is used in the definition.
2797 (read_key_sequence, keyremap_step):
2798 Change bufsize argument back to int, undoing my 2011-03-30 change.
2799 We prefer signed types, and int is wide enough here.
2800 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2801 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2802 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2803 length, not size_t. Use ptrdiff_t for index, not int.
2804 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2805 possibility of integer overflow.
2806
2807 Overflow, signedness and related fixes for images.
2808
2809 * dispextern.h (struct it.stack[0].u.image.image_id)
2810 (struct_it.image_id, struct image.id, struct image_cache.size)
2811 (struct image_cache.used, struct image_cache.ref_count):
2812 * gtkutil.c (update_frame_tool_bar):
2813 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2814 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2815 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2816 * nsmenu.m (update_frame_tool_bar):
2817 * xdisp.c (calc_pixel_width_or_height):
2818 * xfns.c (image_cache_refcount):
2819 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2820 on typical 64-bit hosts.
2821
2822 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2823 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2824 Omit unnecessary casts to int.
2825 (parse_image_spec): Check that integers fall into 'int' range
2826 when the callers expect that.
2827 (image_ascent): Redo ascent calculation to avoid int overflow.
2828 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2829 (lookup_image): Remove unnecessary tests.
2830 (xbm_image_p): Locals are now of int, not EMACS_INT,
2831 since parse_image_check makes sure they fit into int.
2832 (png_load, gif_load, svg_load_image):
2833 Prefer int to unsigned where either will do.
2834 (tiff_handler): New function, combining the cores of the
2835 old tiff_error_handler and tiff_warning_handler.
2836 This function is rewritten to use vsnprintf and thereby avoid
2837 stack buffer overflows. It uses only the features of vsnprintf
2838 that are common to both POSIX and native Microsoft.
2839 (tiff_error_handler, tiff_warning_handler): Use it.
2840 (tiff_load, gif_load, imagemagick_load_image):
2841 Don't assume :index value fits in 'int'.
2842 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2843 (imagemagick_load_image): Check that crop parameters fit into
2844 the integer types that MagickCropImage accepts. Don't assume
2845 Vimagemagick_render_type has a nonnegative value. Don't assume
2846 size_t fits in 'long'.
2847 (gs_load): Use printmax_t to print the widest integers possible.
2848 Check for integer overflow when computing image height and width.
2849
2850 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2851
2852 * xdisp.c (redisplay_window): Don't force window start if point
2853 will be invisible in the resulting window. (Bug#9324)
2854
2855 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2856
2857 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2858 the display spec is of the form `(space ...)'.
2859 (handle_display_spec): Return the value returned by
2860 handle_single_display_spec, not just 1 or zero.
2861 (handle_single_display_spec): If the display spec is of the form
2862 `(space ...)', and specifies display in the text area, return 2
2863 rather than 1.
2864 (try_cursor_movement): Check for the need to scroll more
2865 accurately, and prefer exact match for point under bidi.
2866 Don't advance `row' beyond the last row of the window.
2867
2868 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2869 into disp_prop; all users changed.
2870
2871 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2872 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2873 for the text covered by the display property.
2874
2875 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2876
2877 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2878 Change return value to nil.
2879 (Frecord_buffer): Delete unused function.
2880
2881 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2882
2883 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2884 buffers, return left-to-right.
2885 (set_cursor_from_row): Consider candidate row a win if its glyph
2886 represents a newline and point is on that newline. Fixes cursor
2887 positioning on the newline at EOL of R2L text within L2R
2888 paragraph, and vice versa.
2889 (try_cursor_movement): Check continued rows, in addition to
2890 continuation rows. Fixes unwarranted scroll when point enters a
2891 continued line of R2L text within an L2R paragraph, or vice versa.
2892 (cursor_row_p): Consider the case of point being equal to
2893 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2894 from the end of a short line to the beginning of a continued line
2895 of R2L text within L2R paragraph.
2896 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2897 composed characters.
2898
2899 * bidi.c (bidi_check_type): Use xassert.
2900 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2901 members.
2902
2903 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2904
2905 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2906 a character.
2907
2908 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2909
2910 * nsfont.m (ns_otf_to_script): Fix typo.
2911
2912 2011-08-22 Kenichi Handa <handa@m17n.org>
2913
2914 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2915 extra slot even if the purpose is char-code-property-table.
2916
2917 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2918
2919 * xdisp.c (redisplay_window): When computing centering_position,
2920 account for the height of the header line. (Bug#8874)
2921
2922 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2923 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2924 candidate is selected by the mouse, and that candidate has a
2925 composed character under the mouse.
2926
2927 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2928 coordinates reported by pos-visible-in-window-p for a composed
2929 character in column zero.
2930
2931 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2932
2933 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2934
2935 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2936
2937 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2938 consider it a hit if to_charpos is anywhere in the range of the
2939 composed buffer positions.
2940
2941 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2942
2943 * image.c (gif_load): Don't assume that each subimage has the same
2944 dimensions as the base image. Handle disposal method that is
2945 "undefined" by the gif spec (Bug#9335).
2946
2947 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2948
2949 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2950 (Fcondition_case): Document `debug' symbol in error handler.
2951
2952 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2953
2954 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2955 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2956 from an Org mode buffer to a Speedbar frame.
2957
2958 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2959 a composition, take its buffer position from IT->cmp_it.charpos.
2960 Fixes cursor positioning at the beginning of a line that begins
2961 with a composed character.
2962
2963 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2964
2965 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2966 character bidirectional type, use STRONG_L instead. Fixes crashes
2967 in a buffer produced by `describe-categories'.
2968
2969 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2970 members before the level stack, so they would be saved and
2971 restored when copying iterator state. Fixes incorrect reordering
2972 around TABs covered by display properties.
2973
2974 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2975
2976 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2977
2978 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2979
2980 * eval.c (internal_condition_case, internal_condition_case_1)
2981 (internal_condition_case_2, internal_condition_case_n):
2982 Remove unnecessary aborts (Bug#9081).
2983
2984 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2985
2986 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2987 has no `load' handler, try opening the file locally. (Bug#9311)
2988
2989 2011-08-16 Ken Brown <kbrown@cornell.edu>
2990
2991 * gmalloc.c: Expand comment.
2992
2993 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2994
2995 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2996 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2997
2998 2011-08-16 Ken Brown <kbrown@cornell.edu>
2999
3000 Fix memory allocation problems in Cygwin build (Bug#9273).
3001
3002 * unexcw.c ( __malloc_initialized): Declare external variable.
3003 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3004
3005 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3006 New variables.
3007 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3008 dumped emacs.
3009 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3010 in the static heap.
3011 [CYGWIN] (special_realloc): New function.
3012 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3013 requests to realloc storage in the static heap.
3014
3015 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3016
3017 * bidi.c (bidi_initialize): Remove unused local.
3018
3019 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3020
3021 * bidimirror.h:
3022 * biditype.h: Remove file.
3023 * makefile.w32-in ($(BLD)/bidi.$(O)):
3024 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3025
3026 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3027
3028 * chartab.c: Improve commentary for the uniprop_table API.
3029
3030 * bidi.c (bidi_paragraph_init): Support zero value of
3031 bidi_ignore_explicit_marks_for_paragraph_level.
3032 (bidi_initialize): Use uniprop_table instead of including
3033 biditype.h and bidimirror.h.
3034
3035 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3036 coordinates of the iterator when restoring from ppos_it.
3037 (Bug#9296)
3038
3039 2011-08-14 Kenichi Handa <handa@m17n.org>
3040
3041 * process.c (create_process): Call setup_process_coding_systems
3042 after the pid of the process is set to -1 (Bug#8162).
3043
3044 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3045
3046 * xdisp.c (move_it_in_display_line_to): Don't invoke
3047 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3048 ppos_it. Fixes vertical cursor motion when line beginning is
3049 covered by an image. (Bug#9296)
3050
3051 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3052
3053 * nsterm.h (ns_run_ascript): Declare.
3054 (NSAPP_DATA2_RUNASSCRIPT): Define.
3055
3056 * nsfns.m (as_script, as_result, as_status): New static variables.
3057 (ns_run_ascript): New function.
3058 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3059 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3060 the event loop. Get status from as_status (Bug#7276).
3061
3062 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3063 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3064 the event loop (Bug#7276).
3065
3066 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3067
3068 * gnutls.c (QCgnutls_bootprop_priority)
3069 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3070 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3071 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3072 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3073 (QCgnutls_bootprop_verify_hostname_error)
3074 (QCgnutls_bootprop_callbacks_verify): Rename from
3075 Qgnutls_bootprop_..., all uses changed.
3076
3077 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3078 uses changed.
3079
3080 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 * xfaces.c (Qframe_set_background_mode): Now static.
3083 * dispextern.h (Qframe_set_background_mode): Remove decl.
3084
3085 * process.c (Fnetwork_interface_info): Declare local only if needed.
3086
3087 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3088
3089 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3090 (Fnetwork_interface_list): Allocate in increments of bytes instead
3091 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3092 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3093 sockaddr.
3094 (struct ifflag_def): notrailers is smart on OSX.
3095 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3096 Get hardware address with getifaddrs if available.
3097
3098 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3099
3100 * xdisp.c (iterate_out_of_display_property): xassert that
3101 IT->position is set to within IT->object's boundaries. Break from
3102 the loop as soon as EOB is reached; avoids infloops in redisplay
3103 when IT->position is set up wrongly due to some bug.
3104 Set IT->current to match the bidi iterator unconditionally.
3105 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3106 entry. Force push_it to save on the stack the current
3107 buffer/string position, to be restored by pop_it. Fix flags in
3108 the iterator structure wrt the object coming from a display
3109 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3110 properties. (Bug#9284)
3111
3112 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3113
3114 * fontset.c (fontset_get_font_group): Add proper type checks.
3115 (Bug#9172)
3116
3117 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3118
3119 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3120 and LC_VERSION_MIN_MACOSX.
3121 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3122 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3123
3124 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3125
3126 * xdisp.c (forward_to_next_line_start): Allow to use the
3127 no-display-properties-and-no-overlays under bidi display.
3128 Set disp_pos in the bidi iterator to avoid searches for display
3129 properties and overlays.
3130
3131 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3132
3133 * editfns.c (Fset_time_zone_rule): Document relationship with the
3134 setenv function.
3135
3136 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3137 the font entity extracted from the cache (Bug#8109).
3138
3139 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3140
3141 * composite.c (autocmp_chars): Don't reset point. That is done by
3142 restore_point_unwind (Bug#5984).
3143
3144 2011-08-07 Juri Linkov <juri@jurta.org>
3145
3146 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3147 to show the arg `TIME' instead of `TIMEVAL'.
3148
3149 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3150
3151 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3152 display property strides EOL and includes a newline, as in
3153 longlines-mode. (Bug#9254)
3154 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3155 word-wrap under bidirectional display. (Bug#9224)
3156
3157 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3158 is non-zero, even if the data buffer is NULL. Fixes a crash in
3159 vertical-motion with longlines-mode. (Bug#9254)
3160
3161 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3162
3163 * bidi.c <bidi_cache_total_alloc>: Now static.
3164 (bidi_initialize): Initialize bidi_cache_total_alloc.
3165
3166 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3167 cache. (Bug#9221)
3168
3169 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3170 amount allocated this far in `bidi_cache_total_alloc'.
3171 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3172 non-zero, only free the data buffer without restoring the cache
3173 contents. All callers changed.
3174
3175 * dispextern.h (bidi_unshelve_cache): Update prototype.
3176
3177 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3178 (move_it_in_display_line, move_it_to)
3179 (move_it_vertically_backward, move_it_by_lines): Replace the call
3180 to xfree to an equivalent call to bidi_unshelve_cache.
3181 (move_it_in_display_line_to): Fix logic of returning
3182 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3183
3184 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3185
3186 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3187 came from a string character with a `cursor' property. (Bug#9229)
3188
3189 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3190
3191 * Makefile.in (LIB_PTHREAD): New variable.
3192 (LIBES): Add LIB_PTHREAD (Bug#9216).
3193
3194 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3195 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3196
3197 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3198
3199 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3200
3201 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3202
3203 * xterm.c (x_find_topmost_parent): New function.
3204 (x_set_frame_alpha): Find topmost parent window with
3205 x_find_topmost_parent and set the property there also (bug#9181).
3206 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3207
3208 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3209
3210 * callproc.c (Fcall_process): Avoid vfork clobbering
3211 the local vars buffer, coding_systems, current_dir.
3212
3213 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3214
3215 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3216
3217 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3220 so that it is not optimized away.
3221
3222 * xdisp.c (compute_display_string_pos): Remove unused local.
3223
3224 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3225
3226 Fix slow cursor motion and scrolling in large buffers with
3227 selective display, like Org Mode buffers. (Bug#9218)
3228
3229 * dispextern.h (struct bidi_it): New member disp_prop_p.
3230
3231 * xdisp.c: Remove one-slot cache of display string positions.
3232 (compute_display_string_pos): Accept an additional argument
3233 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3234 for a display string or property. If found, set DISP_PROP_P
3235 non-zero.
3236
3237 * bidi.c (bidi_fetch_char): Accept an additional argument
3238 DISP_PROP_P, and pass it to compute_display_string_pos.
3239 Only handle text covered by a display string if DISP_PROP_P is returned
3240 non-zero. All callers of bidi_fetch_char changed.
3241
3242 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3243
3244 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3245
3246 2010-12-03 Don March <don@ohspite.net>
3247
3248 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3249 last character M-[char] is translated to ESC [char] (bug#7541).
3250
3251 2011-08-02 Kenichi Handa <handa@m17n.org>
3252
3253 * lisp.h (uniprop_table): Extern it.
3254
3255 * chartab.c (uniprop_table): Make it non-static.
3256
3257 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3258
3259 * xdisp.c (forward_to_next_line_start): Accept additional argument
3260 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3261 on the newline.
3262 (reseat_at_next_visible_line_start): Use the bidi iterator state
3263 returned by forward_to_next_line_start to restore the state of
3264 it->bidi_it after backing up to previous newline. (Bug#9212)
3265
3266 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3267
3268 * regex.c (re_comp): Protoize.
3269 (re_exec): Fix return type.
3270 (regexec): Fix type of `ret'. (Bug#9203)
3271
3272 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3275 This is needed if max-image-size is a floating-point number.
3276
3277 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3278
3279 * print.c (print_object): Print empty symbol as ##.
3280
3281 * lread.c (read1): Read ## as empty symbol.
3282
3283 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3284
3285 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3286 setting frame foreground color (Bug#9175).
3287 (x_set_background_color): Likewise.
3288
3289 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3290 contents (Bug#9176).
3291 (EmacsTooltip -init): Remove bezels and add shadows to
3292 tooltip windows.
3293
3294 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3295 or scroll bar (Bug#8470).
3296
3297 * nsfont.m (nsfont_open): Remove assignment to voffset and
3298 unnecessary vars hshink, expand, hd, full_height, min_height.
3299 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3300
3301 * nsterm.h (nsfont_info): Remove voffset field.
3302
3303 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3304
3305 Implement strike-through and overline on NextStep (Bug#8863).
3306
3307 * nsfont.m (nsfont_open): Use underline position provided by font,
3308 instead of hard-coded value of 2.
3309 (nsfont_draw): Call ns_draw_text_decoration instead.
3310
3311 * nsterm.h: Add declaration for ns_draw_text_decoration.
3312
3313 * nsterm.m (ns_draw_text_decoration): New function for drawing
3314 underline, overline, and strike-through.
3315 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3316 ns_draw_text_decoration. Change treatment of cursor drawing to
3317 accommodate underlining, etc.
3318
3319 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3320
3321 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3322 default.
3323
3324 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3325
3326 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3327 Without this fix, if a signal arrives just after memory fills up,
3328 'malloc' might be invoked reentrantly.
3329
3330 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3331 In other words, assume that every image size is allowed, on non-X
3332 hosts. This assumption is probably wrong, but it lets Emacs compile.
3333
3334 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3335
3336 * regex.c (re_iswctype): Convert return values to boolean.
3337
3338 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3339
3340 * xdisp.c (compute_display_string_pos): Don't use cached display
3341 string position if the buffer had its restriction changed.
3342 (Bug#9184)
3343
3344 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3345
3346 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3347
3348 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 Integer signedness and overflow and related fixes. (Bug#9079)
3351
3352 * bidi.c: Integer size and overflow fixes.
3353 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3354 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3355 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3356 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3357 (bidi_find_other_level_edge):
3358 Use ptrdiff_t instead of EMACS_INT where either will do.
3359 This works better on 32-bit hosts configured --with-wide-int.
3360 (bidi_cache_ensure_space): Check for size-calculation overflow.
3361 Use % rather than repeated addition, for better worst-case speed.
3362 Don't set bidi_cache_size until after xrealloc returns, because it
3363 might not return.
3364 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3365 (bidi_cache_ensure_space): Also check that the bidi cache size
3366 does not exceed that of the largest Lisp string or buffer. See Eli
3367 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3368
3369 * alloc.c (__malloc_size_t): Remove.
3370 All uses replaced by size_t. See Andreas Schwab's note
3371 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3372
3373 * image.c: Improve checking for integer overflow.
3374 (check_image_size): Assume that f is nonnull, since
3375 it is always nonnull in practice. This is one less thing to
3376 worry about when checking for integer overflow later.
3377 (x_check_image_size): New function, which checks for integer
3378 overflow issues inside X.
3379 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3380 This removes the need for a memory_full check.
3381 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3382 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3383 (xbm_read_bitmap_data): Change locals back to 'int', since
3384 their values must fit in 'int'.
3385 (xpm_load_image, png_load, tiff_load):
3386 Invoke x_create_x_image_and_pixmap earlier,
3387 to avoid much needless work if the image is too large.
3388 (tiff_load): Treat overly large images as if
3389 x_create_x_image_and_pixmap failed, not as malloc failures.
3390 (gs_load): Use x_check_image_size.
3391
3392 * gtkutil.c: Omit integer casts.
3393 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3394 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3395
3396 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3397
3398 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3399 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3400 would wrongly return t on a 64-bit host.
3401
3402 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3403 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3404 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3405 and therefore cause GCC to emit a bogus diagnostic in some cases.
3406
3407 * image.c: Integer signedness and overflow and related fixes.
3408 This is not an exhaustive set of fixes, but it's time to
3409 record what I've got.
3410 (lookup_pixel_color, check_image_size): Remove redundant decls.
3411 (check_image_size): Don't assume that arbitrary EMACS_INT values
3412 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3413 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3414 (tiff_load, imagemagick_load_image):
3415 Check for overflow in size calculations.
3416 (x_create_x_image_and_pixmap): Remove unnecessary test for
3417 xmalloc returning NULL; that can't happen.
3418 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3419 (xpm_color_bucket): Use better integer hashing function.
3420 (xpm_cache_color): Don't possibly over-allocate memory.
3421 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3422 (gif_memory_source):
3423 Use ptrdiff_t, not int or size_t, to record sizes.
3424 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3425 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3426 either works, as we prefer signed integers.
3427 (tiff_read_from_memory, tiff_write_from_memory):
3428 Return tsize_t, not size_t, since that's what the TIFF API wants.
3429 (tiff_read_from_memory): Don't fail simply because the read would
3430 go past EOF; instead, return a short read.
3431 (tiff_load): Omit no-longer-needed casts.
3432 (Fimagemagick_types): Don't assume size fits into 'int'.
3433
3434 Improve hashing quality when configured --with-wide-int.
3435 * fns.c (hash_string): New function, taken from sxhash_string.
3436 Do not discard information about ASCII character case; this
3437 discarding is no longer needed.
3438 (sxhash-string): Use it. Change sig to match it. Caller changed.
3439 * lisp.h: Declare it.
3440 * lread.c (hash_string): Remove, since we now use fns.c's version.
3441 The fns.c version returns a wider integer if --with-wide-int is
3442 specified, so this should help the quality of the hashing a bit.
3443
3444 * emacs.c: Integer overflow minor fix.
3445 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3446 Define only if GNU_LINUX.
3447 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3448
3449 * dispnew.c: Integer signedness and overflow fixes.
3450 Remove unnecessary forward decls, that were a maintenance hassle.
3451 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3452 All uses changed.
3453 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3454 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3455 (prepare_desired_row, line_draw_cost):
3456 Use int, not unsigned, where either works.
3457 (save_current_matrix, restore_current_matrix):
3458 Use ptrdiff_t, not size_t, where either works.
3459 (init_display): Check for overflow more accurately, and without
3460 relying on undefined behavior.
3461
3462 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3463 Remove, replacing with the new symbols in lisp.h. All uses changed.
3464 * fileio.c (make_temp_name):
3465 * filelock.c (lock_file_1, lock_file):
3466 * xdisp.c (message_dolog):
3467 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3468 Use pMd etc. instead.
3469 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3470 replacing the pWIDE etc. symbols removed from editfns.c.
3471
3472 * keyboard.h (num_input_events): Now uintmax_t.
3473 This is (very slightly) less likely to mess up due to wraparound.
3474 All uses changed.
3475
3476 * buffer.c: Integer signedness fixes.
3477 (alloc_buffer_text, enlarge_buffer_text):
3478 Use ptrdiff_t rather than size_t when either will do, as we prefer
3479 signed integers.
3480
3481 * alloc.c: Integer signedness and overflow fixes.
3482 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3483 (__malloc_size_t): Default to size_t, not to int.
3484 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3485 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3486 Prefer ptrdiff_t to size_t when either would do, as we prefer
3487 signed integers.
3488 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3489 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3490 Now const. Initialize with values that are in range even if char
3491 is signed.
3492 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3493 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3494 These functions do the right thing with sizes > 2**32.
3495 (check_depth): Now ptrdiff_t, not int.
3496 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3497 Adjust to new way of storing sizes. Check for size overflow bugs
3498 in rest of code.
3499 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3500 slightly wrong anyway, as it missed one instance of
3501 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3502 (refill_memory_reserve): Omit needless cast to size_t.
3503 (mark_object_loop_halt): Mark as externally visible.
3504
3505 * xselect.c: Integer signedness and overflow fixes.
3506 (Fx_register_dnd_atom, x_handle_dnd_message):
3507 Use ptrdiff_t, not size_t, since we prefer signed.
3508 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3509 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3510 x_dnd_atoms_size and x_dnd_atoms_length.
3511
3512 * doprnt.c: Prefer signed to unsigned when either works.
3513 * eval.c (verror):
3514 * doprnt.c (doprnt):
3515 * lisp.h (doprnt):
3516 * xdisp.c (vmessage):
3517 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3518 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3519 prefer signed arithmetic to avoid comparison confusion.
3520 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3521 but is a bit tricky.
3522
3523 Assume freestanding C89 headers, string.h, stdlib.h.
3524 * data.c, doprnt.c, floatfns.c, print.c:
3525 Include float.h unconditionally.
3526 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3527 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3528 * regex.c: Likewise for stddef.h, string.h.
3529 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3530 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3531 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3532 (STDC_HEADERS): Remove obsolete defines.
3533 * sysdep.c: Include limits.h unconditionally.
3534
3535 Assume support for memcmp, memcpy, memmove, memset.
3536 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3537 * regex.c (memcmp, memcpy):
3538 Remove; we assume C89 now.
3539
3540 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3541 (__malloc_safe_bcopy): Remove; no longer needed.
3542
3543 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3544 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3545 well either way, and we prefer signed to unsigned.
3546
3547 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3548
3549 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3550 closes the connection while we're reading (bug#9182).
3551
3552 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3553
3554 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3555 are specified (Bug#9168).
3556
3557 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3558
3559 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3560 Found by GCC static checking and --with-wide-int on a 32-bit host.
3561
3562 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3563
3564 * xdisp.c (compute_display_string_pos): Fix logic of caching
3565 previous display string position. Initialize cached_prev_pos to
3566 -1. Fixes slow-down at the beginning of a buffer.
3567
3568 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3569
3570 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3571 for attrs[LFACE_FONTSET_INDEX].
3572
3573 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * xml.c (parse_region): Remove unused local
3576 that was recently introduced.
3577
3578 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3579
3580 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3581 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3582
3583 * xdisp.c (move_it_in_display_line_to): Record the best matching
3584 position for TO_CHARPOS while scanning the line, and restore it on
3585 exit if none of the characters scanned was an exact match.
3586 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3587 when exact match is impossible due to invisible text, and the
3588 lines are truncated.
3589
3590 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3591
3592 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3593 for OSX >= 10.7.
3594
3595 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3596
3597 Fix a significant slow-down of cursor motion with C-n, C-p,
3598 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3599 auto-repeat under bidi redisplay in fontified buffers.
3600 * xdisp.c (compute_stop_pos_backwards): New function.
3601 (next_element_from_buffer): Call compute_stop_pos_backwards to
3602 find a suitable prev_stop when we find ourselves before
3603 base_level_stop.
3604 (reseat): Don't look for prev_stop, as that could mean a very long
3605 run.
3606 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3607 <cached_disp_overlay_modiff>: Cache for last found display string
3608 position.
3609 (compute_display_string_pos): Return the cached position if asked
3610 about the same buffer in the same area of character positions, and
3611 the buffer wasn't changed since the time the display string
3612 position was cached.
3613
3614 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3615
3616 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3617 is an integer, which is important for empty lines. (Bug#9149)
3618
3619 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3620
3621 * frame.c (Fmodify_frame_parameters): In tty case, update the
3622 default face if necessary (Bug#4238).
3623
3624 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3625
3626 * editfns.c (Fstring_to_char): No need to explain what a character
3627 is in the docstring (Bug#6576).
3628
3629 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3630
3631 * xml.c (parse_region): Make sure we always return a tree.
3632
3633 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3634
3635 * xml.c (parse_region): If a document contains only comments,
3636 return that, too.
3637
3638 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3639
3640 * xml.c (make_dom): Return comments, too.
3641
3642 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 Port to OpenBSD.
3645 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3646 and the surrounding thread.
3647 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3648 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3649 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3650 timer goes off.
3651 * s/openbsd.h (BROKEN_SIGIO): Define.
3652 * unexelf.c (unexec) [__OpenBSD__]:
3653 Don't update the .mdebug section of the Alpha COFF symbol table.
3654
3655 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3656
3657 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3658 (bug#8460).
3659
3660 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3661
3662 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3663 This fixes some race conditions on the permissions of any newly
3664 created file.
3665
3666 * alloc.c (valid_pointer_p): Use pipe, not open.
3667 This fixes some permissions issues when debugging.
3668
3669 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3670 If fchown fails to set both uid and gid, try to set just gid,
3671 as that is sometimes allowed. Adjust the file's mode to eliminate
3672 setuid or setgid bits that are inappropriate if fchown fails.
3673
3674 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3675
3676 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3677 to compare Lisp_Objects.
3678 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3679 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3680 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3681
3682 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3683
3684 * lread.c (read_integer): Unread even EOF character.
3685 (read1): Likewise. Properly record start position of symbol.
3686
3687 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3688 symbol character follows.
3689
3690 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3691
3692 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3693 This works around a problem with the previous change to Fcopy_file.
3694 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3695 and without this change, GCC might complain about discarding
3696 fchown's return value.
3697
3698 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3699
3700 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3701
3702 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3705
3706 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3707
3708 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3709 it's used from the C level.
3710
3711 * process.c: Use the same condition for POLL_FOR_INPUT in both
3712 keyboard.c and process.c (bug#1858).
3713
3714 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3715
3716 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3717 (Fgnutls_boot): Use it.
3718
3719 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3720
3721 * doc.c (Fsubstitute_command_keys): Revert last change.
3722
3723 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3724
3725 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3726 quotes the next character, and doesn't affect other longer
3727 sequences (bug#8935).
3728
3729 * lread.c (syms_of_lread): Clarify that is isn't only
3730 `eval-buffer' and `eval-defun' that's affected by
3731 `lexical-binding' (bug#8460).
3732
3733 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3734
3735 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3736 bidi redisplay when a line includes both an image and is truncated.
3737
3738 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 Fix minor problems found by static checking.
3741 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3742 (elsz): Now a signed constant, not a size_t var. We prefer signed
3743 types to unsigned, to avoid integer comparison confusion. Without
3744 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3745 "cannot optimize loop, the loop counter may overflow", a symptom
3746 of the confusion.
3747 * indent.c (Fvertical_motion): Mark locals as initialized.
3748 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3749
3750 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3751
3752 * search.c (Fre_search_backward): Mention `case-fold-search' in
3753 all the re_search_* functions (bug#8138).
3754
3755 * keyboard.c (Fopen_dribble_file): Document when the file is
3756 closed (bug#8056).
3757
3758 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3759
3760 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3761 bidi_cache_idx.
3762
3763 Support bidi reordering of display and overlay strings.
3764 * xdisp.c (compute_display_string_pos)
3765 (compute_display_string_end): Accept additional argument STRING.
3766 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3767 (reseat_to_string): Initialize bidi_it->string.s and
3768 bidi_it->string.schars.
3769 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3770 NULL (avoids a crash in bidi_paragraph_init).
3771 Initialize itb.string.lstring.
3772 (init_iterator): Call bidi_init_it only of a valid
3773 buffer position was specified. Initialize paragraph_embedding to
3774 L2R.
3775 (reseat_to_string): Initialize the bidi iterator.
3776 (display_string): If we need to ignore text properties of
3777 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3778 original value of -1 will not work with bidi.)
3779 (compute_display_string_pos): First arg is now struct
3780 `text_pos *'; all callers changed. Support display properties on
3781 Lisp strings.
3782 (compute_display_string_end): Support display properties on Lisp
3783 strings.
3784 (init_iterator, reseat_1, reseat_to_string): Initialize the
3785 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3786 when iterating on a string not from display properties).
3787 (compute_display_string_pos, compute_display_string_end):
3788 Fix calculation of the object to scan. Fixes an error when using
3789 arrow keys.
3790 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3791 base_level_stop; instead, set base_level_stop to BEGV.
3792 Fixes crashes in vertical-motion.
3793 (next_element_from_buffer): Improve commentary for when
3794 the iterator is before prev_stop.
3795 (init_iterator): Initialize bidi_p from the default value of
3796 bidi-display-reordering, not from buffer-local value. Use the
3797 buffer-local value only if initializing for buffer iteration.
3798 (handle_invisible_prop): Support invisible properties on strings
3799 that are being bidi-reordered.
3800 (set_iterator_to_next): Support bidi reordering of C strings and
3801 Lisp strings.
3802 (next_element_from_string): Support bidi reordering of Lisp
3803 strings.
3804 (handle_stop_backwards): Support Lisp strings as well.
3805 (display_string): Support display of R2L glyph rows.
3806 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3807 (init_iterator): Don't initialize it->bidi_p for strings
3808 here.
3809 (reseat_to_string): Initialize it->bidi_p for strings here.
3810 (next_element_from_string, next_element_from_c_string)
3811 (next_element_from_buffer): Add xassert's for correspondence
3812 between IT's object being iterated and it->bidi_it.string
3813 structure.
3814 (face_before_or_after_it_pos): Support bidi iteration.
3815 (next_element_from_c_string): Handle the case of the first string
3816 character that is not the first one in the visual order.
3817 (get_visually_first_element): New function, refactored from common
3818 parts of next_element_from_buffer, next_element_from_string, and
3819 next_element_from_c_string.
3820 (tool_bar_lines_needed, redisplay_tool_bar)
3821 (display_menu_bar): Force left-to-right direction. Add a FIXME
3822 comment for making that be controlled by a user option.
3823 (push_it, pop_it): Save and restore the state of the
3824 bidi iterator. Save and restore the bidi_p flag.
3825 (pop_it): Iterate out of display property for string iteration as
3826 well.
3827 (iterate_out_of_display_property): Support iteration over strings.
3828 (handle_single_display_spec): Set up it->bidi_it for iteration
3829 over a display string, and call bidi_init_it.
3830 (handle_single_display_spec, next_overlay_string)
3831 (get_overlay_strings_1, push_display_prop): Set up the bidi
3832 iterator for displaying display or overlay strings.
3833 (forward_to_next_line_start): Don't use the shortcut if
3834 bidi-iterating.
3835 (back_to_previous_visible_line_start): If handle_display_prop
3836 pushed the iterator stack, restore the internal state of the bidi
3837 iterator by calling bidi_pop_it same number of times.
3838 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3839 and we are bidi-iterating, don't decrement the iterator position;
3840 instead, set the first_elt flag in the bidi iterator, to produce
3841 the same effect.
3842 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3843 (push_display_prop): xassert that we are iterating a buffer.
3844 (push_it, pop_it): Save and restore paragraph_embedding member.
3845 (handle_single_display_spec, next_overlay_string)
3846 (get_overlay_strings_1, reseat_1, reseat_to_string)
3847 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3848 correctly. Don't assume unibyte strings are not bidi-reordered.
3849 (compute_display_string_pos)
3850 (compute_display_string_end): Fix handling the case of C string.
3851 (push_it, pop_it): Save and restore from_disp_prop_p.
3852 (handle_single_display_spec, push_display_prop): Set the
3853 from_disp_prop_p flag.
3854 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3855 (pop_it): Call iterate_out_of_display_property only if we are
3856 popping after iteration over a string that came from a display
3857 property. Fix a typo in popping stretch info. Add an assertion
3858 for verifying that the iterator position is in sync with the bidi
3859 iterator.
3860 (handle_single_display_spec, get_overlay_strings_1)
3861 (push_display_prop): Fix initialization of paragraph direction for
3862 string when that of the parent object is not yet determined.
3863 (reseat_1): Call bidi_init_it to resync the bidi
3864 iterator with IT's position. (Bug#7616)
3865 (find_row_edges): If ROW->start.pos gives position
3866 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3867 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3868 Reset the from_disp_prop_p flag.
3869 (SAVE_IT, RESTORE_IT): New macros.
3870 (pos_visible_p, face_before_or_after_it_pos)
3871 (back_to_previous_visible_line_start)
3872 (move_it_in_display_line_to, move_it_in_display_line)
3873 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3874 (try_scrolling, redisplay_window, display_line): Use them when
3875 saving a temporary copy of the iterator and restoring it back.
3876 (back_to_previous_visible_line_start, reseat_1)
3877 (init_iterator): Empty the bidi cache "stack".
3878 (move_it_in_display_line_to): If iterator ended up at
3879 EOL, but we never saw any buffer positions smaller than
3880 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3881 motion in bidi-reordered lines.
3882 (move_it_in_display_line_to): Record prev_method and prev_pos
3883 immediately before the call to set_iterator_to_next. Fixes cursor
3884 motion in bidi-reordered lines with stretch glyphs and strings
3885 displayed in margins. (Bug#8133) (Bug#8867)
3886 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3887 TO_CHARPOS.
3888 (pos_visible_p): Support positions in bidi-reordered lines.
3889 Save and restore bidi cache.
3890
3891 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3892 (bidi_paragraph_info): Delete unused struct.
3893 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3894 (bidi_cache_start): New variable.
3895 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3896 to zero.
3897 (bidi_cache_fetch_state, bidi_cache_search)
3898 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3899 (bidi_cache_find, bidi_peek_at_next_level)
3900 (bidi_level_of_next_char, bidi_find_other_level_edge)
3901 (bidi_move_to_visually_next): Compare cache index with
3902 bidi_cache_start rather than with zero.
3903 (bidi_fetch_char): Accept new argument STRING; all callers
3904 changed. Support iteration over a string. Support strings with
3905 display properties. Support unibyte strings. Fix the type of
3906 `len' according to what STRING_CHAR_AND_LENGTH expects.
3907 (bidi_paragraph_init, bidi_resolve_explicit_1)
3908 (bidi_resolve_explicit, bidi_resolve_weak)
3909 (bidi_level_of_next_char, bidi_move_to_visually_next):
3910 Support iteration over a string.
3911 (bidi_set_sor_type, bidi_resolve_explicit_1)
3912 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3913 can now be zero (for strings); special values 0 and -1 were
3914 changed to -1 and -2, respectively.
3915 (bidi_char_at_pos): New function.
3916 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3917 Call it instead of FETCH_MULTIBYTE_CHAR.
3918 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3919 initialized to valid values.
3920 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3921 values.
3922 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3923 the test for valid cached positions. Fix the logic for looking up
3924 the sentinel state in the cache. GCPRO the Lisp string we are
3925 iterating.
3926 (bidi_push_it, bidi_pop_it): New functions.
3927 (bidi_initialize): Initialize the bidi cache start stack pointer.
3928 (bidi_cache_ensure_space): New function, refactored from part of
3929 bidi_cache_iterator_state. Don't assume the required size is just
3930 one BIDI_CACHE_CHUNK away.
3931 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3932 (bidi_count_bytes, bidi_char_at_pos): New functions.
3933 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3934 always valid if bidi_cache_idx is valid.
3935 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3936 is valid if it's going to be used.
3937 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3938 (bidi_cache_fetch_state, bidi_cache_search)
3939 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3940 (bidi_cache_iterator_state, bidi_cache_find)
3941 (bidi_find_other_level_edge, bidi_cache_start_stack):
3942 All variables related to cache indices are now EMACS_INT.
3943
3944 * dispextern.h (struct bidi_string_data): New structure.
3945 (struct bidi_it): New member `string'. Make flag members be 1-bit
3946 fields, and put them last in the struct.
3947 (compute_display_string_pos, compute_display_string_end):
3948 Update prototypes.
3949 (bidi_push_it, bidi_pop_it): Add prototypes.
3950 (struct iterator_stack_entry): New members bidi_p,
3951 paragraph_embedding, and from_disp_prop_p.
3952 (struct it): Member bidi_p is now a bit field 1 bit wide.
3953 (bidi_shelve_cache, bidi_unshelve_cache):
3954 Declare prototypes.
3955
3956 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3957 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3958 and vector-like objects.
3959
3960 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3961 cache around display iteration.
3962
3963 * window.c (Fwindow_end, window_scroll_pixel_based)
3964 (displayed_window_lines, Frecenter): Save and restore the bidi
3965 cache around display iteration.
3966
3967 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3968
3969 * editfns.c (Fdelete_region): Clarify the use of the named
3970 parameters (bug#6788).
3971
3972 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3973
3974 * indent.c (Fvertical_motion): Set and restore w->pointm when
3975 saving and restoring the window's buffer (Bug#9006).
3976
3977 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3978
3979 * editfns.c (Fstring_to_char): Clarify just what is returned
3980 (bug#6576). Text by Eli Zaretskii.
3981
3982 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3983
3984 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3985
3986 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3987
3988 * buffer.c (mmap_find): Fix a typo.
3989
3990 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3991
3992 Fix execution of x selection hooks.
3993 * xselect.c (Qx_lost_selection_functions)
3994 (Qx_sent_selection_functions): New vars.
3995 (syms_of_xselect): DEFSYM them.
3996 (x_handle_selection_request): Pass Qx_sent_selection_functions
3997 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3998 (x_handle_selection_clear,x_clear_frame_selections):
3999 Pass Qx_lost_selection_functions rather than
4000 Vx_lost_selection_functions to Frun_hook_with_args.
4001
4002 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4005 The old code sometimes used this field without initializing it.
4006
4007 * alloc.c (gc_sweep): Don't read past end of array.
4008 In theory, the old code could also have corrupted Emacs internals,
4009 though it'd be very unlikely.
4010
4011 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4012
4013 * character.c (Fcharacterp): Don't advertise optional ignored
4014 argument. (Bug#4026)
4015
4016 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4017
4018 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4019 key" (bug#4257).
4020
4021 * window.c (Fset_window_start): Doc fix (bug#4199).
4022 (Fset_window_hscroll): Ditto.
4023
4024 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 Fix minor new problems caught by GCC 4.6.1.
4027 * term.c (init_tty): Remove unused local.
4028 * xsettings.c (store_monospaced_changed): Define this function only
4029 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4030 not used otherwise.
4031
4032 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4033
4034 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4035
4036 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4037
4038 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4039 are the mini-buffer and the echo area (bug#3320).
4040
4041 * term.c (init_tty): Remove support for supdup, c10 and perq
4042 terminals, which are no longer supported (bug#1482).
4043
4044 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4045
4046 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4047
4048 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4049
4050 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4051 for non-popups (Bug#3642).
4052
4053 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4054
4055 * alloc.c (reset_malloc_hooks): Protoize.
4056 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4057 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4058 * cm.c (losecursor): Likewise.
4059 * data.c (fmod): Likewise.
4060 * dispnew.c (swap_glyphs_in_rows): Likewise.
4061 * emacs.c (memory_warning_signal): Likewise.
4062 * floatfns.c (float_error): Likewise.
4063 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4064 (otf_open, font_otf_capability, generate_otf_features)
4065 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4066 Likewise.
4067 * image.c (pbm_read_file): Likewise.
4068 * indent.c (string_display_width): Likewise.
4069 * intervals.c (check_for_interval, search_for_interval)
4070 (inc_interval_count, count_intervals, root_interval)
4071 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4072 * lread.c (defalias): Likewise.
4073 * ralloc.c (r_alloc_check): Likewise.
4074 * regex.c (set_image_of_range_1, set_image_of_range)
4075 (regex_grow_registers): Likewise.
4076 * sysdep.c (strerror): Likewise.
4077 * termcap.c (valid_filename_p, tprint, main): Likewise.
4078 * tparam.c (main): Likewise.
4079 * unexhp9k800.c (run_time_remap, save_data_space)
4080 (update_file_ptrs, read_header, write_header, calculate_checksum)
4081 (copy_file, copy_rest, display_header): Likewise.
4082 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4083 Likewise.
4084 * xdisp.c (check_it): Likewise.
4085 * xfaces.c (register_color, unregister_color, unregister_colors):
4086 Likewise.
4087 * xfns.c (print_fontset_result): Likewise.
4088 * xrdb.c (member, fatal, main): Likewise.
4089
4090 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4091
4092 Fix minor problems found by static checking (Bug#9031).
4093 * chartab.c (char_table_set_range, map_sub_char_table):
4094 Remove unused locals.
4095 (uniprop_table): Now static.
4096 * composite.c (_work_char): Remove unused static var.
4097
4098 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4099
4100 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4101
4102 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4103
4104 * gtkutil.c (qttip_cb): Remove code without function.
4105
4106 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4107
4108 * w32.c (pthread_sigmask): New stub.
4109
4110 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4111
4112 Use pthread_sigmask, not sigprocmask (Bug#9010).
4113 sigprocmask is portable only for single-threaded applications, and
4114 Emacs can be multi-threaded when it uses GTK.
4115 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4116 (LIBES): Use it.
4117 * callproc.c (Fcall_process):
4118 * process.c (create_process):
4119 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4120 Use pthread_sigmask, not sigprocmask.
4121
4122 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4123
4124 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4125 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4126 wrong (Bug#8591).
4127
4128 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4129
4130 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4131 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4132 (xg_hide_tooltip): Fix comment.
4133
4134 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4135 in registerServicesMenuSendTypes.
4136 (validRequestorForSendType): Don't check ns_return_types.
4137
4138 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4139 ns_return_type.
4140
4141 2011-07-08 Jason Rumney <jasonr@gnu.org>
4142
4143 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4144 SH_SHOW for hidden windows (Bug#5482).
4145
4146 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4147 frame struct members of non-existent frames (Bug#6284).
4148
4149 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4150
4151 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4152 variable firstTime not needed on OSX >= 10.6.
4153 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4154 >= 10.5. Use setKnobProportion, setDoubleValue.
4155
4156 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4157 (MAC_OS_X_VERSION_10_5): Define if not defined.
4158 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4159 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4160 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4161
4162 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4163 cString and lossyCString on OSX >= 10.4
4164
4165 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4166 sizeToFit on OSX >= 10.2.
4167
4168 * nsimage.m (allocInitFromFile): Don't use deprecated method
4169 bestRepresentationForDevice on OSX >= 10.6.
4170
4171 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4172 to avoid warning.
4173
4174 * emacs.c: Declare unexec_init_emacs_zone.
4175
4176 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4177
4178 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4179
4180 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4181 on svcsMenu (Bug#8842).
4182
4183 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4184 ns_return_types.
4185 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4186
4187 * nsterm.m (QUTF8_STRING): Declare.
4188 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4189 (validRequestorForSendType): Return type is (id).
4190 Change indexOfObjectIdenticalTo to indexOfObject.
4191 Check if we have local selection before returning self (Bug#8842).
4192 (writeSelectionToPasteboard): Put local selection into paste board
4193 if we have a local selection (Bug#8842).
4194 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4195
4196 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4197 (ns_get_local_selection): Declare.
4198
4199 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4200
4201 * keymap.c (describe_map_tree): Don't insert a double newline at
4202 the end of the buffer (bug#1169) and return whether we inserted
4203 something.
4204
4205 * callint.c (Fcall_interactively): Change "reading args" to
4206 "providing args" to try to clarify what it does (bug#1010).
4207
4208 2011-07-07 Kenichi Handa <handa@m17n.org>
4209
4210 * composite.c (composition_compute_stop_pos): Ignore a static
4211 composition starting before CHARPOS (Bug#8915).
4212
4213 * xdisp.c (handle_composition_prop): Likewise.
4214
4215 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4216
4217 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4218 (Bug#9015)
4219
4220 2011-07-07 Kenichi Handa <handa@m17n.org>
4221
4222 * character.h (unicode_category_t): New enum type.
4223
4224 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4225 (Qchar_code_property_table): New variable.
4226 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4227 (UNIPROP_COMPRESSED_FORM_P): New macros.
4228 (char_table_ascii): Uncompress the compressed values.
4229 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4230 Uncompress the compressed values.
4231 (sub_char_table_ref_and_range): Likewise.
4232 (char_table_ref_and_range): Uncompress the compressed values.
4233 (sub_char_table_set): New arg is_uniprop. Callers changed.
4234 Uncompress the compressed values.
4235 (sub_char_table_set_range): Args changed. Callers changed.
4236 (char_table_set_range): Adjuted for the above change.
4237 (map_sub_char_table): Delete args default_val and parent. Add arg
4238 top. Give decoded values to a Lisp function.
4239 (map_char_table): Adjust for the above change. Give decoded
4240 values to a Lisp function. Gcpro more variables.
4241 (uniprop_table_uncompress)
4242 (uniprop_decode_value_run_length): New functions.
4243 (uniprop_decoder, uniprop_decoder_count): New variables.
4244 (uniprop_get_decoder, uniprop_encode_value_character)
4245 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4246 New functions.
4247 (uniprop_encoder, uniprop_encoder_count): New variables.
4248 (uniprop_get_encoder, uniprop_table)
4249 (Funicode_property_table_internal, Fget_unicode_property_internal)
4250 (Fput_unicode_property_internal): New functions.
4251 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4252 Sunicode_property_table_internal, Sget_unicode_property_internal,
4253 and Sput_unicode_property_internal. Defvar_lisp
4254 char-code-property-alist.
4255
4256 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4257 Vunicode_category_table.
4258
4259 * font.c (font_range): Adjust for the change of
4260 Vunicode_category_table.
4261
4262 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4263
4264 * m/iris4d.h: Remove file, move contents ...
4265 * s/irix6-5.h: ... here.
4266
4267 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4268
4269 Remove unportable assumption about struct layout (Bug#8884).
4270 * alloc.c (mark_buffer):
4271 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4272 (clone_per_buffer_values): Don't assume that
4273 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4274 This isn't true in general, and it's particularly not true
4275 if Emacs is configured with --with-wide-int.
4276 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4277 New macros, used in the buffer.c change.
4278
4279 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4280
4281 * xsettings.c: Use both GConf and GSettings if both are available.
4282 (store_config_changed_event): Add comment.
4283 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4284 (store_tool_bar_style_changed): New functions.
4285 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4286 (struct xsettings): Move font inside HAVE_XFT.
4287 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4288 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4289 Move inside HAVE_XFT.
4290 (something_changed_gsettingsCB): Rename from something_changedCB.
4291 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4292 also.
4293 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4294 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4295 (something_changed_gconfCB): Rename from something_changedCB.
4296 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4297 (parse_settings): Move check for font inside HAVE_XFT.
4298 (read_settings, apply_xft_settings): Add comment.
4299 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4300 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4301 call store_font_name_changed.
4302 (xft_settings_event): Add comment.
4303 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4304 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4305 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4306 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4307 (xsettings_initialize): Call init_gsettings last.
4308 (xsettings_get_system_font, xsettings_get_system_normal_font):
4309 Add comment.
4310
4311 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4312
4313 Random fixes. E.g., (random) never returned negative values.
4314 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4315 subseconds part to the entropy, as that's a bit more random.
4316 Prefer signed to unsigned, since the signedness doesn't matter and
4317 in general we prefer signed. When given a limit, use a
4318 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4319 latter isn't right if USE_2_TAGS_FOR_INTS.
4320 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4321 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4322
4323 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4324
4325 * textprop.c (text_property_stickiness):
4326 Obey Vtext_property_default_nonsticky.
4327 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4328 * w32fns.c (syms_of_w32fns):
4329 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4330
4331 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4332
4333 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4334 This is more efficient than Ffile_directory_p and avoids a minor race.
4335
4336 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4337
4338 * buffer.c (Foverlay_put): Say what the return value is
4339 (bug#7835).
4340
4341 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4342 is a directory before asking whether to use the file name
4343 (bug#7564).
4344 (barf_or_query_if_file_exists): Make the "File is a directory"
4345 error be more correct.
4346
4347 * fns.c (Frequire): Remove the mention of the .gz files, since
4348 that's installation-specific, but keep the mention of
4349 `get-load-suffixes'.
4350
4351 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4354 Report string overflow if the output is too long.
4355
4356 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4357
4358 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4359 (syms_of_gnutls): Remove duplicate DEFSYM for
4360 Qgnutls_bootprop_verify_hostname_error, an error for
4361 Qgnutls_bootprop_verify_error (which is no longer used).
4362
4363 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4364 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4365 Also (re)move comments that are misplaced or no longer relevant.
4366
4367 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4368
4369 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4370
4371 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4372
4373 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4374 and background color parameters if they have been changed.
4375
4376 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4377
4378 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4379
4380 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4381
4382 * xsettings.c (SYSTEM_FONT): Define only when used.
4383 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4384
4385 * keymap.c (access_keymap_1): Now static.
4386
4387 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4388
4389 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4390 leave any prefix arg for the up event (Bug#1586).
4391
4392 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4393
4394 * lread.c (syms_of_lread): Mention single symbols defined by
4395 `defvar' or `defconst' (bug#7154).
4396
4397 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4398 (Frequire): Mention get-load-suffixes.
4399
4400 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4401
4402 * window.h (window): Remove clone_number slot.
4403 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4404 Remove.
4405 (make_parent_window, make_window, saved_window)
4406 (Fset_window_configuration, save_window_save): Don't deal with
4407 clone numbers.
4408 * buffer.c (Qclone_number): Remove declaration.
4409 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4410
4411 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4412
4413 Add multiple inheritance to keymaps.
4414 * keymap.c (Fmake_composed_keymap): New function.
4415 (Fset_keymap_parent): Simplify.
4416 (fix_submap_inheritance): Remove.
4417 (access_keymap_1): New function extracted from access_keymap to handle
4418 embedded parents and handle lists of maps.
4419 (access_keymap): Use it.
4420 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4421 (Fcopy_keymap): Handle embedded parents.
4422 (Fcommand_remapping, define_as_prefix): Simplify.
4423 (Fkey_binding): Simplify.
4424 (syms_of_keymap): Move minibuffer-local-completion-map,
4425 minibuffer-local-filename-completion-map,
4426 minibuffer-local-must-match-map, and
4427 minibuffer-local-filename-must-match-map to Elisp.
4428 (syms_of_keymap): Defsubr make-composed-keymap.
4429 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4430 (parse_menu_item): Trivial simplification.
4431
4432 2011-07-01 Glenn Morris <rgm@gnu.org>
4433
4434 * Makefile.in (SETTINGS_LIBS): Fix typo.
4435
4436 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4437
4438 * coding.c (Fencode_coding_string): Record the last coding system
4439 used, as the function doc string says (bug#8738).
4440
4441 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4442
4443 * xsettings.c (store_monospaced_changed): Take new font as arg and
4444 check for change against current_mono_font.
4445 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4446 (emacs_settings_constructor, emacs_settings_get_property)
4447 (emacs_settings_set_property, emacs_settings_class_init)
4448 (emacs_settings_init, gsettings_obj): Remove.
4449 (something_changedCB): New function for HAVE_GSETTINGS.
4450 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4451 with value as argument.
4452 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4453 g_settings_new (Bug#8967). Do not create gsettings_obj.
4454 Remove calls to g_settings_bind. Connect something_changedCB to
4455 "changed".
4456
4457 * xgselect.c: Add defined (HAVE_GSETTINGS).
4458 (xgselect_initialize): Ditto.
4459
4460 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4461 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4462 xg_select.
4463
4464 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4465
4466 * eval.c (struct backtrace): Simplify and port the data structure.
4467 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4468 signed bit field, as this assumption is not portable and it makes
4469 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4470 "char debug_on_exit : 1" as this is not portable either; instead,
4471 use the portable "unsigned int debug_on_exit : 1". Remove unused
4472 member evalargs. Remove obsolete comments about cc bombing out.
4473
4474 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4475
4476 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4477 Let HAVE_GSETTINGS override HAVE_GCONF.
4478 (store_monospaced_changed): New function.
4479 (EMACS_SETTINGS): A new type derived from GObject to handle
4480 GSettings notifications.
4481 (emacs_settings_constructor, emacs_settings_get_property)
4482 (emacs_settings_set_property, emacs_settings_class_init):
4483 New functions.
4484 (gsettings_client, gsettings_obj): New variables.
4485 (GSETTINGS_SCHEMA): New define.
4486 (something_changedCB): Call store_monospaced_changed.
4487 (init_gsettings): New function.
4488 (xsettings_initialize): Call init_gsettings.
4489 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4490 to NULL.
4491
4492 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4493 GCONF_CFLAGS/LIBS.
4494
4495 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4496
4497 * window.c (resize_root_window, grow_mini_window)
4498 (shrink_mini_window): Rename Qresize_root_window to
4499 Qwindow_resize_root_window and Qresize_root_window_vertically to
4500 Qwindow_resize_root_window_vertically.
4501
4502 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4503
4504 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4505
4506 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4507
4508 * makefile.w32-in: Redesign dependencies so they reflect more
4509 clearly which files are directly included by each source file,
4510 and not through other includes.
4511
4512 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4513
4514 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4515 (sort_overlays, overlay_strings): When an overlay's clone number
4516 matches the window's clone number process the overlay even if
4517 the overlay's window property doesn't match the current window.
4518
4519 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4520 (Fwindow_hchild): Rename to Fwindow_left_child.
4521 (Fwindow_next): Rename to Fwindow_next_sibling.
4522 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4523 (resize_window_check): Rename to window_resize_check.
4524 (resize_window_apply): Rename to window_resize_apply.
4525 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4526 (Fdelete_other_windows_internal, resize_frame_windows)
4527 (Fsplit_window_internal, Fdelete_window_internal)
4528 (grow_mini_window, shrink_mini_window)
4529 (Fresize_mini_window_internal): Fix callers accordingly.
4530
4531 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4532
4533 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4534 (emacs_fixed_set_min_size): Remove.
4535 (emacs_fixed_new): Take frame as argument.
4536
4537 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4538 (_EmacsFixedPrivate): Remove minwidth/height.
4539 Add struct frame *f.
4540 (emacs_fixed_init): Initialize priv->f.
4541 (get_parent_class, emacs_fixed_set_min_size): Remove.
4542 (emacs_fixed_new): Set priv->f to argument.
4543 (emacs_fixed_get_preferred_width)
4544 (emacs_fixed_get_preferred_height): Use min_width/height from
4545 frames size_hint to set minimum and natural (Bug#8919).
4546 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4547 and use min_width/height from frames size_hint to set
4548 min_width/height (Bug#8919).
4549
4550 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4551 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4552 Fix indentation.
4553
4554 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4555
4556 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4557 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4558 called at ZV.
4559
4560 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4561
4562 * process.c (wait_reading_process_output): Bypass select if
4563 waiting for a cell while ignoring keyboard input, and input is
4564 pending. Suggested by Jan Djärv (Bug#8869).
4565
4566 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4567
4568 Use gnulib's dup2 module instead of rolling our own.
4569 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4570
4571 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4572
4573 * dispnew.c (scrolling_window): Before scrolling, turn off a
4574 mouse-highlight in the window being scrolled.
4575
4576 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4577
4578 Move DEFSYM to lisp.h and use everywhere.
4579
4580 * character.h (DEFSYM): Move declaration...
4581 * lisp.h (DEFSYM): ...here.
4582
4583 * gnutls.c:
4584 * minibuf.c:
4585 * w32menu.c:
4586 * w32proc.c:
4587 * w32select.c: Don't include character.h.
4588
4589 * alloc.c (syms_of_alloc):
4590 * buffer.c (syms_of_buffer):
4591 * bytecode.c (syms_of_bytecode):
4592 * callint.c (syms_of_callint):
4593 * casefiddle.c (syms_of_casefiddle):
4594 * casetab.c (init_casetab_once):
4595 * category.c (init_category_once, syms_of_category):
4596 * ccl.c (syms_of_ccl):
4597 * cmds.c (syms_of_cmds):
4598 * composite.c (syms_of_composite):
4599 * dbusbind.c (syms_of_dbusbind):
4600 * dired.c (syms_of_dired):
4601 * dispnew.c (syms_of_display):
4602 * doc.c (syms_of_doc):
4603 * editfns.c (syms_of_editfns):
4604 * emacs.c (syms_of_emacs):
4605 * eval.c (syms_of_eval):
4606 * fileio.c (syms_of_fileio):
4607 * fns.c (syms_of_fns):
4608 * frame.c (syms_of_frame):
4609 * fringe.c (syms_of_fringe):
4610 * insdel.c (syms_of_insdel):
4611 * keymap.c (syms_of_keymap):
4612 * lread.c (init_obarray, syms_of_lread):
4613 * macros.c (syms_of_macros):
4614 * msdos.c (syms_of_msdos):
4615 * print.c (syms_of_print):
4616 * process.c (syms_of_process):
4617 * search.c (syms_of_search):
4618 * sound.c (syms_of_sound):
4619 * syntax.c (init_syntax_once, syms_of_syntax):
4620 * terminal.c (syms_of_terminal):
4621 * textprop.c (syms_of_textprop):
4622 * undo.c (syms_of_undo):
4623 * w32.c (globals_of_w32):
4624 * window.c (syms_of_window):
4625 * xdisp.c (syms_of_xdisp):
4626 * xfaces.c (syms_of_xfaces):
4627 * xfns.c (syms_of_xfns):
4628 * xmenu.c (syms_of_xmenu):
4629 * xsettings.c (syms_of_xsettings):
4630 * xterm.c (syms_of_xterm): Use DEFSYM.
4631
4632 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4633
4634 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4635
4636 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4637
4638 Integer and buffer overflow fixes (Bug#8873).
4639
4640 * print.c (printchar, strout): Check for string overflow.
4641 (PRINTPREPARE, printchar, strout):
4642 Don't set size unless allocation succeeds.
4643
4644 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4645 for sizes. Check for string overflow more accurately.
4646 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4647
4648 * macros.c: Integer and buffer overflow fixes.
4649 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4650 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4651 Use ptrdiff_t, not int, for sizes.
4652 Don't increment bufsize until after realloc succeeds.
4653 Check for size-calculation overflow.
4654 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4655
4656 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4657
4658 * lread.c: Integer overflow fixes.
4659 (read_integer): Radix is now EMACS_INT, not int,
4660 to improve quality of diagnostics for out-of-range radices.
4661 Calculate buffer size correctly for out-of-range radices.
4662 (read1): Check for integer overflow in radices, and in
4663 read-circle numbers.
4664 (read_escape): Avoid int overflow.
4665 (Fload, openp, read_buffer_size, read1)
4666 (substitute_object_recurse, read_vector, read_list, map_obarray):
4667 Use ptrdiff_t, not int, for sizes.
4668 (read1): Use EMACS_INT, not int, for sizes.
4669 Check for size overflow.
4670
4671 * image.c (cache_image): Check for size arithmetic overflow.
4672
4673 * lread.c: Integer overflow issues.
4674 (saved_doc_string_size, saved_doc_string_length)
4675 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4676 Now ptrdiff_t, not int.
4677 (read1): Don't assume doc string length fits in int. Check for
4678 out-of-range doc string lengths.
4679 (read_list): Don't assume file position fits in int.
4680 (read_escape): Check for hex character overflow.
4681
4682 2011-06-22 Leo Liu <sdl.web@gmail.com>
4683
4684 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4685 Move to minibuffer.el.
4686
4687 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4688
4689 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4690 The following patches are for when GLYPH_DEBUG && !XASSERT.
4691 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4692 * dispnew.c (flush_stdout):
4693 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4694 Mark as externally visible.
4695 * dispnew.c (check_window_matrix_pointers): Now static.
4696 * dispnew.c (window_to_frame_vpos):
4697 * xfns.c (unwind_create_frame):
4698 * xterm.c (x_check_font): Remove unused local.
4699 * scroll.c (CHECK_BOUNDS):
4700 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4701 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4702 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4703 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4704 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4705 Now static.
4706 (debug_method_add): Use va_list and vsprintf rather than relying
4707 on undefined behavior with wrong number of arguments.
4708 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4709 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4710 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4711 since we're not interested in debugging glyphs with old libraries.
4712 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4713 GCC 4.6.0's static checking.
4714
4715 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4716
4717 Integer overflow and signedness fixes (Bug#8873).
4718 A few related buffer overrun fixes, too.
4719
4720 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4721
4722 * dispextern.h (struct face.stipple):
4723 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4724 (x_bitmap_mask, x_allocate_bitmap_record)
4725 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4726 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4727 (x_create_bitmap_from_xpm_data):
4728 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4729 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4730 (.bitmaps_last):
4731 * xfaces.c (load_pixmap):
4732 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4733 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4734 (.bitmaps_last, struct x_output.icon_bitmap):
4735 Use ptrdiff_t, not int, for bitmap indexes.
4736 (x_allocate_bitmap_record): Check for size overflow.
4737 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4738
4739 Use ptrdiff_t, not int, for overlay counts.
4740 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4741 * editfns.c (overlays_around, get_pos_property):
4742 * textprop.c (get_char_property_and_overlay):
4743 * xdisp.c (next_overlay_change, note_mouse_highlight):
4744 * xfaces.c (face_at_buffer_position):
4745 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4746 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4747 (Fnext_overlay_change, Fprevious_overlay_change)
4748 (mouse_face_overlay_overlaps, Foverlays_in):
4749 Use ptrdiff_t, not int, for sizes.
4750 (overlays_at, overlays_in): Check for size-calculation overflow.
4751
4752 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4753
4754 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4755 (x_session_initialize): Do not assume string length fits in int.
4756
4757 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4758 This is unlikely, but can occur if DPI is outlandish.
4759
4760 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4761 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4762
4763 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4764 * xrdb.c (magic_file_p, search_magic_path):
4765 Omit last arg SUFFIX; it was always 0. All callers changed.
4766 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4767
4768 * xfont.c (xfont_match): Avoid need for strlen.
4769
4770 * xfns.c: Don't assume strlen fits in int.
4771 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4772
4773 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4774 not unsigned long, as we prefer signed integers. All callers changed.
4775 Detect integer overflow in repeat count.
4776 (message_dolog): Don't assume print length fits in 39 bytes.
4777 (display_mode_element): Don't assume strlen fits in int.
4778
4779 * termcap.c: Don't assume sizes fit in int and never overflow.
4780 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4781 (gobble_line): Check for size-calculation overflow.
4782
4783 * minibuf.c (Fread_buffer):
4784 * lread.c (intern, intern_c_string):
4785 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4786 Don't assume string length fits in int.
4787
4788 * keyboard.c (parse_tool_bar_item):
4789 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4790
4791 * font.c: Don't assume string length fits in int.
4792 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4793 Use ptrdiff_t, not int.
4794 (font_intern_prop): Don't assume string length fits in int.
4795 Don't assume integer property fits in fixnum.
4796 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4797
4798 * filelock.c: Fix some buffer overrun and integer overflow issues.
4799 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4800 Reformulate so as not to need the command string.
4801 Invoke gzip -cd rather than gunzip, as it's more portable.
4802 (lock_info_type, lock_file_1, lock_file):
4803 Don't assume pid_t and time_t fit in unsigned long.
4804 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4805 (current_lock_owner): Prefer signed type for sizes.
4806 Use memcpy, not strncpy, where memcpy is what is really wanted.
4807 Don't assume (via atoi) that time_t and pid_t fit in int.
4808 Check for time_t and/or pid_t out of range, e.g., via a network share.
4809 Don't alloca where an auto var works fine.
4810
4811 * fileio.c: Fix some integer overflow issues.
4812 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4813 Don't assume string length fits in int.
4814 (directory_file_name): Don't assume string length fits in long.
4815 (make_temp_name): Don't assume pid fits in int, or that its print
4816 length is less than 20.
4817
4818 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4819
4820 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4821
4822 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4823
4824 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4825 We prefer signed integers, even for size calculations.
4826
4827 * emacs.c: Don't assume string length fits in 'int'.
4828 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4829 (main): Don't invoke strlen when not needed.
4830
4831 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4832 (XD_DEBUG_MESSAGE): Don't waste a byte.
4833
4834 * callproc.c (getenv_internal_1, getenv_internal)
4835 (Fgetenv_internal):
4836 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4837
4838 * lread.c (invalid_syntax): Omit length argument.
4839 All uses changed. This doesn't fix a bug, but it simplifies the
4840 code away from its former Hollerith-constant appearance, and it's
4841 one less 'int' to worry about when looking at integer-overflow issues.
4842 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4843
4844 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4845 This didn't break anything, but it didn't help either.
4846 It's confusing to put a bogus integer in a place where the actual
4847 value does not matter.
4848 (LIST_END_P): Remove unused macro and its bogus comment.
4849 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4850
4851 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4852 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4853 implementation.
4854 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4855 We prefer signed types, and the value cannot exceed the EMACS_INT
4856 range anyway (because otherwise the length would not be representable).
4857 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4858 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4859 This avoids a GCC warning when WIDE_EMACS_INT.
4860
4861 * indent.c (sane_tab_width): New function.
4862 (current_column, scan_for_column, Findent_to, position_indentation)
4863 (compute_motion): Use it. This is just for clarity.
4864 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4865
4866 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4867
4868 * lisp.h (lint_assume): New macro.
4869 * composite.c (composition_gstring_put_cache):
4870 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4871
4872 * editfns.c, insdel.c:
4873 Omit unnecessary forward decls, to simplify future changes.
4874
4875 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4876
4877 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4878
4879 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4880 Use much-faster test for byte-length change.
4881 Don't assume string byte-length fits in 'int'.
4882 Check that character arg fits in 'int'.
4883 (mapcar1): Declare byte as byte, for clarity.
4884
4885 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4886
4887 * fns.c (concat): Catch string overflow earlier.
4888 Do not rely on integer wraparound.
4889
4890 * dispextern.h (struct it.overlay_strings_charpos)
4891 (struct it.selective): Now EMACS_INT, not int.
4892 * xdisp.c (forward_to_next_line_start)
4893 (back_to_previous_visible_line_start)
4894 (reseat_at_next_visible_line_start, next_element_from_buffer):
4895 Don't arbitrarily truncate the value of 'selective' to int.
4896
4897 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4898
4899 * composite.c: Don't truncate sizes to 'int'.
4900 (composition_gstring_p, composition_reseat_it)
4901 (composition_adjust_point): Use EMACS_INT, not int.
4902 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4903 not EMACS_UINT, for indexes.
4904
4905 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4906
4907 * buffer.c: Include <verify.h>.
4908 (struct sortvec.priority, struct sortstr.priority):
4909 Now EMACS_INT, not int.
4910 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4911 (struct sortstr.size, record_overlay_string)
4912 (struct sortstrlist.size, struct sortlist.used):
4913 Don't truncate size to int.
4914 (record_overlay_string): Check for size-calculation overflow.
4915 (init_buffer_once): Check at compile-time, not run-time.
4916
4917 2011-06-22 Jim Meyering <meyering@redhat.com>
4918
4919 Don't leak an XBM-image-sized buffer
4920 * image.c (xbm_load): Free the image buffer after using it.
4921
4922 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4923
4924 Port to Sun C.
4925 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4926 that Sun C diagnosed.
4927 * fns.c (secure_hash): Fix pointer signedness issue.
4928 * intervals.c (static_offset_intervals): New function.
4929 (offset_intervals): Use it.
4930
4931 2011-06-21 Leo Liu <sdl.web@gmail.com>
4932
4933 * deps.mk (fns.o):
4934 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4935 sha512.h.
4936
4937 * fns.c (secure_hash): Rename from crypto_hash_function and change
4938 the first arg to accept symbols.
4939 (Fsecure_hash): New primitive.
4940 (syms_of_fns): New symbols.
4941
4942 2011-06-20 Deniz Dogan <deniz@dogan.se>
4943
4944 * process.c (Fset_process_buffer): Clarify return value in
4945 docstring.
4946
4947 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4948
4949 * dispnew.c (add_window_display_history): Use BVAR.
4950
4951 * xdisp.c (debug_method_add): Use BVAR.
4952 (check_window_end, dump_glyph_matrix, dump_glyph)
4953 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4954
4955 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4956 Likewise.
4957
4958 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4959 check till after the cache is created in init_frame_faces.
4960
4961 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4962
4963 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4964
4965 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4966
4967 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4968 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4969 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4970
4971 Improve buffer-overflow checking (Bug#8873).
4972 * fileio.c (Finsert_file_contents):
4973 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4974 Remove the old (too-loose) buffer overflow checks.
4975 They weren't needed, since make_gap checks for buffer overflow.
4976 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4977 The old code merely checked for Emacs fixnum overflow, and relied
4978 on undefined (wraparound) behavior. The new code avoids undefined
4979 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4980
4981 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4982 Tune. Don't use wider integers than needed. Don't use alloca.
4983 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4984
4985 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4986
4987 * insdel.c, lisp.h (buffer_overflow): New function.
4988 (insert_from_buffer_1, replace_range, replace_range_2):
4989 * insdel.c (make_gap_larger):
4990 * editfns.c (Finsert_char):
4991 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4992
4993 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4994
4995 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4996
4997 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4998
4999 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5000 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5001
5002 * fileio.c: Don't assume EMACS_INT fits in off_t.
5003 (emacs_lseek): New static function.
5004 (Finsert_file_contents, Fwrite_region): Use it.
5005 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5006
5007 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5008
5009 * fns.c: Don't overflow int when computing a list length.
5010 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5011 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5012 truncation on 64-bit hosts. Check for QUIT every
5013 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5014 faster and is responsive enough.
5015 (Flength): Report an error instead of overflowing an integer.
5016 (Fsafe_length): Return a float if the value is not representable
5017 as a fixnum. This shouldn't happen except in contrived situations.
5018 (Fnthcdr, Fsort): Don't assume list length fits in int.
5019 (Fcopy_sequence): Don't assume vector length fits in int.
5020
5021 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5022 (header_size, word_size): New constants.
5023 (allocate_vectorlike): Don't check size overflow here.
5024 (allocate_vector): Check it here instead, since this is the only
5025 caller of allocate_vectorlike that could cause overflow.
5026 Check that the new vector's length is representable as a fixnum.
5027
5028 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5029 The previous code was bogus. For example, next_almost_prime (32)
5030 returned 39, which is undesirable as it is a multiple of 3; and
5031 next_almost_prime (24) returned 25, which is a multiple of 5 so
5032 why was the code bothering to check for multiples of 7?
5033
5034 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5035
5036 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5037
5038 Variadic C functions now count arguments with ptrdiff_t.
5039 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5040 Back then I didn't know that the Emacs coding style prefers signed int.
5041 Also, in the meantime I found a few more instances where arguments
5042 were being counted with int, which may truncate counts on 64-bit
5043 machines, or EMACS_INT, which may be unnecessarily wide.
5044 * lisp.h (struct Lisp_Subr.function.aMANY)
5045 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5046 Arg counts are now ptrdiff_t, not size_t.
5047 All variadic functions and their callers changed accordingly.
5048 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5049 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5050 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5051 * callint.c (Fcall_interactively): Check arg count for overflow,
5052 to avoid potential buffer overrun. Use signed char, not 'int',
5053 for 'varies' array, so that we needn't bother to check its size
5054 calculation for overflow.
5055 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5056 * eval.c (apply_lambda):
5057 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5058 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5059 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5060
5061 * callint.c (Fcall_interactively): Don't use index var as event count.
5062
5063 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5064 * mem-limits.h (SIZE): Remove; no longer used.
5065
5066 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5067
5068 Remove unnecessary casts.
5069 * xterm.c (x_term_init):
5070 * xfns.c (x_set_border_pixel):
5071 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5072 These aren't needed now that we assume ANSI C.
5073
5074 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5075 It's more likely to cause problems (due to unsigned overflow)
5076 than to cure them.
5077
5078 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5079
5080 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5081
5082 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5083
5084 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5085
5086 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5087
5088 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5089
5090 GLYPH_CODE_FACE returns EMACS_INT, not int.
5091 * dispextern.h (merge_faces):
5092 * xfaces.c (merge_faces):
5093 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5094 Don't assume EMACS_INT fits in int.
5095
5096 * character.h (CHAR_VALID_P): Remove unused parameter.
5097 * fontset.c, lisp.h, xdisp.c: All uses changed.
5098
5099 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5100
5101 * fns.c (concat): Minor tuning based on overflow analysis.
5102 This doesn't fix any bugs. Use int to hold character, instead
5103 of constantly refetching from Emacs object. Use XFASTINT, not
5104 XINT, for value known to be a character. Don't bother comparing
5105 a single byte to 0400, as it's always less.
5106
5107 * floatfns.c (Fexpt):
5108 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5109
5110 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5111 for characters.
5112
5113 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5114
5115 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5116 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5117 incorrectly succeed when S was a string, because 4294967386 was
5118 truncated before it was used.
5119
5120 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5121 Otherwise, an out-of-range integer could cause undefined behavior
5122 on a 64-bit host.
5123
5124 * composite.c: Use int, not EMACS_INT, for characters.
5125 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5126 EMACS_INT, for values that are known to be in character range.
5127 This doesn't fix any bugs but is the usual style inside Emacs and
5128 may generate better code on 32-bit machines.
5129
5130 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5131 This is for reasons similar to the recent CHAR_STRING fix.
5132 * charset.c (Fencode_char): Check that character arg is actually
5133 a character. Pass an int to ENCODE_CHAR.
5134 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5135 wider than 'int', as a compile-time check to prevent future regressions
5136 in this area.
5137
5138 * character.c (char_string): Remove unnecessary casts.
5139
5140 Make sure a 64-bit char is never passed to CHAR_STRING.
5141 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5142 by silently ignoring the top 32 bits, allowing some values
5143 that were far too large to be valid characters.
5144 * character.h: Include <verify.h>.
5145 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5146 arguments are no wider than unsigned, as a compile-time check
5147 to prevent future regressions in this area.
5148 * data.c (Faset):
5149 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5150 (Fsubst_char_in_region):
5151 * fns.c (concat):
5152 * xdisp.c (decode_mode_spec_coding):
5153 Adjust to CHAR_STRING's new requirement.
5154 * editfns.c (Finsert_char, Fsubst_char_in_region):
5155 * fns.c (concat): Check that character args are actually
5156 characters. Without this test, these functions did the wrong
5157 thing with wildly out-of-range values on 64-bit hosts.
5158
5159 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5160 These casts should not be needed on 32-bit hosts, either.
5161 * keyboard.c (read_char):
5162 * lread.c (Fload): Remove casts to unsigned.
5163
5164 * lisp.h (UNSIGNED_CMP): New macro.
5165 This fixes comparison bugs on 64-bit hosts.
5166 (ASCII_CHAR_P): Use it.
5167 * casefiddle.c (casify_object):
5168 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5169 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5170 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5171 * dispextern.h (FACE_FROM_ID):
5172 * keyboard.c (read_char): Use UNSIGNED_CMP.
5173
5174 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5175 not to EMACS_INT, to avoid GCC warning.
5176
5177 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5178
5179 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5180 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5181 isn't needed on 32-bit machines.
5182
5183 * buffer.c (Fgenerate_new_buffer_name):
5184 Use EMACS_INT for count, not int.
5185 (advance_to_char_boundary): Return EMACS_INT, not int.
5186
5187 * data.c (Qcompiled_function): Now static.
5188
5189 * window.c (window_body_lines): Now static.
5190
5191 * image.c (gif_load): Rename local to avoid shadowing.
5192
5193 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5194 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5195 * alloc.c (make_save_value): Integer argument is now of type
5196 ptrdiff_t, not int.
5197 (mark_object): Use ptrdiff_t, not int.
5198 * lisp.h (pD): New macro.
5199 * print.c (print_object): Use it.
5200
5201 * alloc.c: Use EMACS_INT, not int, to count objects.
5202 (total_conses, total_markers, total_symbols, total_vector_size)
5203 (total_free_conses, total_free_markers, total_free_symbols)
5204 (total_free_floats, total_floats, total_free_intervals)
5205 (total_intervals, total_strings, total_free_strings):
5206 Now EMACS_INT, not int. All uses changed.
5207 (Fgarbage_collect): Compute overall total using a double, so that
5208 integer overflow is less likely to be a problem. Check for overflow
5209 when converting back to an integer.
5210 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5211 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5212 These were 'int' variables that could overflow on 64-bit hosts;
5213 they were never used, so remove them instead of repairing them.
5214 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5215 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5216 Previously, this ceilinged at INT_MAX, but that doesn't work on
5217 64-bit machines.
5218 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5219
5220 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5221 (allocate_vectorlike): Check for ptrdiff_t overflow.
5222 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5223 when a (possibly-narrower) signed value would do just as well.
5224 We prefer using signed arithmetic, to avoid comparison confusion.
5225
5226 * alloc.c: Catch some string size overflows that we were missing.
5227 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5228 for convenience in STRING_BYTES_MAX.
5229 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5230 The definition here is exact; the one in lisp.h was approximate.
5231 (allocate_string_data): Check for string overflow. This catches
5232 some instances we weren't catching before. Also, it catches
5233 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5234 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5235 and ptrdiff_t and EMACS_INT are both 64 bits.
5236
5237 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5238 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5239 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5240
5241 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5242
5243 * alloc.c (Fmake_string): Check for out-of-range init.
5244
5245 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5246
5247 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5248
5249 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5250
5251 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5252 xg_get_default_scrollbar_width.
5253
5254 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5255 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5256 (style_changed_cb): Call update_theme_scrollbar_width and call
5257 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5258 all frames (Bug#8505).
5259 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5260 Call gtk_window_set_resizable if HAVE_GTK3.
5261 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5262 and height if HAVE_GTK3 (Bug#8505).
5263 (scroll_bar_width_for_theme): New variable.
5264 (update_theme_scrollbar_width): New function.
5265 (xg_get_default_scrollbar_width): Move code to
5266 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5267 (xg_initialize): Call update_theme_scrollbar_width.
5268
5269 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5270
5271 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5272
5273 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5274
5275 * frame.c (make_frame): Call other_buffer_safely instead of
5276 other_buffer.
5277
5278 * window.c (temp_output_buffer_show): Call display_buffer with
5279 second argument Vtemp_buffer_show_specifiers and reset latter
5280 immediately after the call.
5281 (Vtemp_buffer_show_specifiers): New variable.
5282 (auto_window_vscroll_p, next_screen_context_lines)
5283 (Vscroll_preserve_screen_position): Remove leading asterisks from
5284 doc-strings.
5285
5286 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 Fix minor problems found by GCC 4.6.0 static checking.
5289 * buffer.c (Qclone_number): Remove for now, as it's unused.
5290 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5291 (record_buffer): Remove unused local.
5292 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5293 (set_frame_buffer_list): Remove; unused.
5294 * frame.h (other_visible_frames): Remove decl.
5295 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5296 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5297 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5298 if HAVE_GPM.
5299 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5300 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5301 Define only if HAVE_GPM.
5302 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5303 (update_hints_inhibit): Remove; never set. All uses removed.
5304 * widgetprv.h (emacsFrameClassRec): Remove decl.
5305 * window.c (delete_deletable_window): Now returns void, since it
5306 wasn't returning anything.
5307 (compare_window_configurations): Remove unused locals.
5308 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5309 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5310 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5311 the same widths as pointers. This follows up on the 2011-05-06 patch.
5312 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5313 * xterm.h: Likewise.
5314 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5315
5316 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5317
5318 * makefile.w32-in: Update dependencies.
5319 (LISP_H): Add lib/intprops.h.
5320
5321 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5322
5323 * image.c (gif_load): Add animation frame delay to the metadata.
5324 (syms_of_image): Use DEFSYM. New symbol `delay'.
5325
5326 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5327
5328 * window.c (delete_deletable_window): Re-add.
5329 (Fset_window_configuration): Rewrite to handle dead buffers and
5330 consequently deletable windows.
5331 (window_tree, Fwindow_tree): Remove. Supply functionality in
5332 window.el.
5333 (compare_window_configurations): Simplify code.
5334
5335 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5336
5337 * image.c (imagemagick_load_image): Fix type mismatch.
5338 (Fimagemagick_types): Likewise.
5339
5340 * window.h (replace_buffer_in_windows): Declare.
5341
5342 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5343
5344 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5345 Qclone_number. Remove external declaration of Qdelete_window.
5346 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5347 code.
5348 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5349 Run Qbuffer_list_update_hook if allowed.
5350 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5351 buffer list implementation.
5352 (other_buffer_safely): New function.
5353 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5354 calls to replace_buffer_in_windows and
5355 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5356 if allowed.
5357 (record_buffer): Inhibit quitting and rewrite using quittable
5358 functions. Run Qbuffer_list_update_hook if allowed.
5359 (Frecord_buffer, Funrecord_buffer): New functions.
5360 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5361 Move switch-to-buffer to window.el.
5362 (bury-buffer): Move to window.el.
5363 (Vbuffer_list_update_hook): New variable.
5364
5365 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5366 section.
5367
5368 * window.h (resize_frame_windows): Move up in code.
5369 (Fwindow_frame): Remove EXFUN.
5370 (replace_buffer_in_all_windows): Remove prototype.
5371 (replace_buffer_in_windows_safely): Add prototype.
5372
5373 * window.c: Declare Qdelete_window static again. Move down
5374 declaration of select_count.
5375 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5376 (Fother_window): Move to window.el.
5377 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5378 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5379 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5380 window.el.
5381 (replace_buffer_in_windows): Implement by calling
5382 Qreplace_buffer_in_windows.
5383 (replace_buffer_in_all_windows): Remove with some functionality
5384 moved into replace_buffer_in_windows_safely.
5385 (replace_buffer_in_windows_safely): New function.
5386 (select_window_norecord, select_frame_norecord): Move in front
5387 of run_window_configuration_change_hook. Remove now obsolete
5388 declarations.
5389 (Fset_window_buffer): Rewrite doc-string.
5390 Call Qrecord_window_buffer.
5391 (keys_of_window): Move binding for other-window to window.el.
5392
5393 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5394
5395 * dispextern.h (struct image): Replace data member, whose int_val
5396 and ptr_val fields were not used by anything, with a single
5397 lisp_val object.
5398
5399 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5400 (gif_clear_image, gif_load, imagemagick_load_image)
5401 (gs_clear_image, gs_load): Callers changed.
5402
5403 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5404
5405 * buffer.h: Include <time.h>, for time_t.
5406 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5407
5408 Fix minor problems found by static checking.
5409
5410 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5411
5412 Make identifiers static if they are not used in other modules.
5413 * data.c (Qcompiled_function, Qframe, Qvector):
5414 * image.c (QimageMagick, Qsvg):
5415 * minibuf.c (Qmetadata):
5416 * window.c (resize_window_check, resize_root_window): Now static.
5417 * window.h (resize_window_check, resize_root_window): Remove decls.
5418
5419 * window.c (window_deletion_count, delete_deletable_window):
5420 Remove; unused.
5421 (window_body_lines): Now static.
5422 (Fdelete_other_windows_internal): Mark vars as initialized.
5423 Make sure 'resize_failed' is initialized.
5424 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5425 (resize_window_apply): Remove unused local.
5426 * window.h (delete_deletable_window): Remove decl.
5427
5428 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5429 (imagemagick_load_image): Fix pointer signedness problem by changing
5430 last arg from unsigned char * to char *. All uses changed.
5431 Also, fix a local for similar reasons.
5432 Remove unused locals. Remove locals to avoid shadowing.
5433 (fn_rsvg_handle_free): Remove; unused.
5434 (svg_load, svg_load_image): Fix pointer signedness problem.
5435 (imagemagick_load_image): Don't use garbage pointer image_wand.
5436
5437 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5438
5439 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5440
5441 * image.c (gif_load): Fix omitted cast error introduced by
5442 2011-06-06 change.
5443
5444 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5445
5446 * window.h (resize_proportionally, orig_total_lines)
5447 (orig_top_line): Remove from window structure.
5448 (set_window_height, set_window_width, change_window_heights)
5449 (Fdelete_window): Remove prototypes.
5450 (resize_frame_windows): Remove duplicate declaration.
5451
5452 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5453
5454 * window.h (resize_frame_windows, resize_window_check)
5455 (delete_deletable_window, resize_root_window)
5456 (resize_frame_windows): Declare prototypes.
5457
5458 * window.c (resize_window_apply): Make definition be "static" to
5459 match the prototype.
5460
5461 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5462
5463 * window.c: Remove declarations of Qwindow_size_fixed,
5464 window_min_size_1, window_min_size_2, window_min_size,
5465 size_window, window_fixed_size_p, enlarge_window, delete_window.
5466 Remove static from declaration of Qdelete_window, it's
5467 temporarily needed by Fbury_buffer.
5468 (replace_window): Don't assign orig_top_line and
5469 orig_total_lines.
5470 (Fdelete_window, delete_window): Remove. Window deletion is
5471 handled by window.el.
5472 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5473 Replace Fdelete_window calls with calls to Qdelete_window.
5474 (Fdelete_other_windows): Remove. Deleting other windows is
5475 handled by window.el.
5476 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5477 handled in window.el.
5478 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5479 Window minimum sizes are handled in window.el.
5480 (shrink_windows, size_window, set_window_height)
5481 (set_window_width, change_window_heights, window_height)
5482 (window_width, CURBEG, CURSIZE, enlarge_window)
5483 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5484 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5485 handled in window.el.
5486 (make_dummy_parent): Rename to make_parent_window and give it a
5487 second argument horflag.
5488 (make_window): Don't set resize_proportionally any more.
5489 (Fsplit_window): Remove. Windows are split in window.el.
5490 (save_restore_action, save_restore_orig_size)
5491 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5492 Resize mini windows in window.el.
5493 (grow_mini_window, shrink_mini_window): Implement by calling
5494 Qresize_root_window_vertically, resize_window_check and
5495 resize_window_apply.
5496 (saved_window, Fset_window_configuration, save_window_save):
5497 Do not handle orig_top_line, orig_total_lines, and
5498 resize_proportionally.
5499 (window_min_height, window_min_width): Move to window.el.
5500 (keys_of_window): Move bindings for delete-other-windows,
5501 split-window, delete-window and enlarge-window to window.el.
5502
5503 * buffer.c: Temporarily extern Qdelete_window.
5504 (Fbury_buffer): Temporarily call Qdelete_window instead of
5505 Fdelete_window (Fbury_buffer will move to window.el soon).
5506
5507 * frame.c (set_menu_bar_lines_1): Remove code handling
5508 orig_top_line and orig_total_lines.
5509
5510 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5511 set_window_height but set heights directly.
5512 (change_frame_size_1): Use resize_frame_windows.
5513
5514 * xdisp.c (init_xdisp): Don't use set_window_height but set
5515 heights directly.
5516
5517 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5518 Use resize_frame_windows instead of change_window_heights and run
5519 run_window_configuration_change_hook.
5520
5521 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5522 instead of change_window_heights and run
5523 run_window_configuration_change_hook.
5524
5525 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5526
5527 * window.c (replace_window): Rename second argument REPLACEMENT to
5528 NEW. New third argument SETFLAG. Rewrite.
5529 (delete_window, make_dummy_parent): Call replace_window with
5530 third argument 1.
5531 (window_list_1): Move down in code.
5532 (run_window_configuration_change_hook): Move set_buffer part
5533 before select_frame_norecord part in order to unwind correctly.
5534 Rename count1 to count.
5535 (recombine_windows, delete_deletable_window, resize_root_window)
5536 (Fdelete_other_windows_internal)
5537 (Frun_window_configuration_change_hook, make_parent_window)
5538 (resize_window_check, resize_window_apply, Fresize_window_apply)
5539 (resize_frame_windows, Fsplit_window_internal)
5540 (Fdelete_window_internal, Fresize_mini_window_internal):
5541 New functions.
5542 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5543
5544 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5545
5546 * window.h (window): Add some new members to window structure -
5547 normal_lines, normal_cols, new_total, new_normal, clone_number,
5548 splits, nest, prev_buffers, next_buffers.
5549 (WINDOW_TOTAL_SIZE): Move here from window.c.
5550 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5551
5552 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5553 Remove.
5554 (make_dummy_parent): Set new members of windows structure.
5555 (make_window): Move down in code. Handle new members of window
5556 structure.
5557 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5558 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5559 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5560 (Fset_window_prev_buffers, Fwindow_next_buffers)
5561 (Fset_window_next_buffers, Fset_window_clone_number):
5562 New functions.
5563 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5564 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5565 Doc-string fixes.
5566 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5567 Argument WINDOW can be now internal window too.
5568 (Fwindow_use_time): Move up in code.
5569 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5570 Rewrite doc-string.
5571 (Fset_window_configuration, saved_window)
5572 (Fcurrent_window_configuration, save_window_save): Handle new
5573 members of window structure.
5574 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5575 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5576 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5577 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5578 Qget_mru_window, Qresize_root_window,
5579 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5580 Qauto_buffer_name; staticpro them.
5581
5582 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5583
5584 * window.c (Fwindow_total_size, Fwindow_left_column)
5585 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5586 (Fwindow_list_1): New functions.
5587 (window_box_text_cols): Replace with window_body_cols.
5588 (Fwindow_width, Fscroll_left, Fscroll_right):
5589 Use window_body_cols instead of window_box_text_cols.
5590 (delete_window, Fset_window_configuration):
5591 Call delete_all_subwindows with window as argument.
5592 (delete_all_subwindows): Take a window as argument and not a
5593 structure. Rewrite.
5594 (window_loop): Remove handling of GET_LRU_WINDOW and
5595 GET_LARGEST_WINDOW.
5596 (Fget_lru_window, Fget_largest_window): Move to window.el.
5597
5598 * window.h: Extern window_body_cols instead of
5599 window_box_text_cols. delete_all_subwindows now takes a
5600 Lisp_Object as argument.
5601
5602 * indent.c (compute_motion, Fcompute_motion):
5603 Use window_body_cols instead of window_box_text_cols.
5604
5605 * frame.c (delete_frame): Call delete_all_subwindows with root
5606 window as argument.
5607
5608 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5609
5610 * fns.c (Fputhash): Document return value.
5611
5612 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5613
5614 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5615
5616 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5617
5618 Cons<->int and similar integer overflow fixes (Bug#8794).
5619
5620 Check for overflow when converting integer to cons and back.
5621 * charset.c (Fdefine_charset_internal, Fdecode_char):
5622 Use cons_to_unsigned to catch overflow.
5623 (Fencode_char): Use INTEGER_TO_CONS.
5624 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5625 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5626 * data.c (long_to_cons, cons_to_long): Remove.
5627 (cons_to_unsigned, cons_to_signed): New functions.
5628 These signal an error for invalid or out-of-range values.
5629 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5630 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5631 * font.c (Ffont_variation_glyphs):
5632 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5633 * lisp.h: Include <intprops.h>.
5634 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5635 (cons_to_signed, cons_to_unsigned): New decls.
5636 (long_to_cons, cons_to_long): Remove decls.
5637 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5638 (Fprimitive_undo): Use CONS_TO_INTEGER.
5639 * xfns.c (Fx_window_property): Likewise.
5640 * xselect.c: Include <limits.h>.
5641 (x_own_selection, selection_data_to_lisp_data):
5642 Use INTEGER_TO_CONS.
5643 (x_handle_selection_request, x_handle_selection_clear)
5644 (x_get_foreign_selection, Fx_disown_selection_internal)
5645 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5646 (lisp_data_to_selection_data): Use cons_to_unsigned.
5647 (x_fill_property_data): Use cons_to_signed.
5648 Report values out of range.
5649
5650 Check for buffer and string overflow more precisely.
5651 * buffer.h (BUF_BYTES_MAX): New macro.
5652 * lisp.h (STRING_BYTES_MAX): New macro.
5653 * alloc.c (Fmake_string):
5654 * character.c (string_escape_byte8):
5655 * coding.c (coding_alloc_by_realloc):
5656 * doprnt.c (doprnt):
5657 * editfns.c (Fformat):
5658 * eval.c (verror):
5659 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5660 since they may not be the same number.
5661 * editfns.c (Finsert_char):
5662 * fileio.c (Finsert_file_contents):
5663 Likewise for BUF_BYTES_MAX.
5664
5665 * image.c: Use ptrdiff_t, not int, for sizes.
5666 (slurp_file): Switch from int to ptrdiff_t.
5667 All uses changed.
5668 (slurp_file): Check that file size fits in both size_t (for
5669 malloc) and ptrdiff_t (for sanity and safety).
5670
5671 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5672 if b->modtime has its maximal value.
5673
5674 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5675
5676 Don't assume time_t can fit into int.
5677 * buffer.h (struct buffer.modtime): Now time_t, not int.
5678 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5679 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5680
5681 Minor fixes for signed vs unsigned integers.
5682 * character.h (MAYBE_UNIFY_CHAR):
5683 * charset.c (maybe_unify_char):
5684 * keyboard.c (read_char, reorder_modifiers):
5685 XINT -> XFASTINT, since the integer must be nonnegative.
5686 * ftfont.c (ftfont_spec_pattern):
5687 * keymap.c (access_keymap, silly_event_symbol_error):
5688 XUINT -> XFASTINT, since the integer must be nonnegative.
5689 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5690 since it makes no difference and we prefer signed.
5691 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5692 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5693 nonnegative.
5694
5695 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5696
5697 * window.h (Fwindow_frame): Declare.
5698
5699 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5700
5701 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5702 (SPARE_MEMORY): Always define.
5703 (LARGE_REQUEST): Remove.
5704 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5705
5706 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5707
5708 * lisp.h: Move EXFUNS for Fframe_root_window,
5709 Fframe_first_window and Fset_frame_selected_window to window.h.
5710
5711 * window.h: Move EXFUNS for Fframe_root_window,
5712 Fframe_first_window and Fset_frame_selected_window here from
5713 lisp.h.
5714
5715 * frame.c (Fwindow_frame, Fframe_first_window)
5716 (Fframe_root_window, Fframe_selected_window)
5717 (Fset_frame_selected_window): Move to window.c.
5718 (Factive_minibuffer_window): Move to minibuf.c.
5719 (Fother_visible_frames_p): New function.
5720
5721 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5722
5723 * window.c (decode_window, decode_any_window): Move up in code.
5724 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5725 (inhibit_frame_unsplittable): Remove unused variable.
5726 (Fwindow_buffer): Move up and rewrite doc-string.
5727 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5728 (Fwindow_prev): New functions.
5729 (Fwindow_frame): Move here from frame.c. Accept any window as
5730 argument.
5731 (Fframe_root_window, Fframe_first_window)
5732 (Fframe_selected_window): Move here from frame.c. Accept frame
5733 or arbitrary window as argument. Update doc-strings.
5734 (Fminibuffer_window): Move up in code.
5735 (Fwindow_minibuffer_p): Move up in code and simplify.
5736 (Fset_frame_selected_window): Move here from frame.c.
5737 Marginal rewrite.
5738 (Fselected_window, select_window, Fselect_window): Move up in
5739 code. Minor doc-string fixes.
5740
5741 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5742
5743 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5744 Do not assume that spare memory exists; that assumption is valid
5745 only if SYSTEM_MALLOC.
5746 (LARGE_REQUEST): New macro, so that the issue of large requests
5747 is separated from the issue of spare memory.
5748
5749 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5750
5751 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5752 format. (Bug#8806)
5753
5754 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5755
5756 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5757 before statements.
5758
5759 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5760
5761 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5762
5763 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5764
5765 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5766 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5767
5768 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5769
5770 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5771
5772 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5773
5774 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5775 (x_clipboard_manager_save): Add return value.
5776 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5777 New error handlers.
5778 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5779 Obey Vx_select_enable_clipboard_manager. Catch errors in
5780 x_clipboard_manager_save (Bug#8779).
5781 (Vx_select_enable_clipboard_manager): New variable.
5782 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5783
5784 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5785
5786 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5787
5788 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5789
5790 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5791 in the current matrix if keep_current_p is non-zero.
5792
5793 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5794
5795 * bidi.c (bidi_level_of_next_char): Fix last change.
5796
5797 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5798
5799 Support bidi reordering of text covered by display properties.
5800
5801 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5802 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5803 (bidi_cache_search, bidi_cache_iterator_state)
5804 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5805 (bidi_level_of_next_char, bidi_move_to_visually_next):
5806 Support character positions inside a run of characters covered by a
5807 display string.
5808 (bidi_paragraph_init, bidi_resolve_explicit_1)
5809 (bidi_level_of_next_char): Call bidi_fetch_char and
5810 bidi_fetch_char_advance instead of FETCH_CHAR and
5811 FETCH_CHAR_ADVANCE.
5812 (bidi_init_it): Initialize new members.
5813 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5814 definitions.
5815 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5816 instead of using explicit *_CHAR codes.
5817 (bidi_resolve_explicit, bidi_resolve_weak):
5818 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5819 bidirectional text is supported only in multibyte buffers.
5820 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5821 it to initialize the frame_window_p member of struct bidi_it.
5822 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5823 (bidi_resolve_explicit, bidi_resolve_weak)
5824 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5825 bidi_it->nchars is non-positive.
5826 (bidi_level_of_next_char): Don't try to lookup the cache for the
5827 next/previous character if nothing is cached there yet, or if we
5828 were just reseat()'ed to a new position.
5829
5830 * xdisp.c (set_cursor_from_row): Set start and stop points
5831 according to the row's direction when priming the loop that looks
5832 for the glyph on which to display cursor.
5833 (single_display_spec_intangible_p): Function deleted.
5834 (display_prop_intangible_p): Reimplement to call
5835 handle_display_spec instead of single_display_spec_intangible_p.
5836 Accept 3 additional arguments needed by handle_display_spec.
5837 This fixes incorrect cursor motion across display property with complex
5838 values: lists, `(when COND...)' forms, etc.
5839 (single_display_spec_string_p): Support property values that are
5840 lists with the argument STRING its top-level element.
5841 (display_prop_string_p): Fix the condition for processing a
5842 property that is a list to be consistent with handle_display_spec.
5843 (handle_display_spec): New function, refactored from the
5844 last portion of handle_display_prop.
5845 (compute_display_string_pos): Accept additional argument
5846 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5847 value of a `display' property is a "replacing spec".
5848 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5849 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5850 the display property, but just return a value indicating whether
5851 the display property will replace the characters it covers.
5852 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5853 frame_window_p members of struct bidi_it.
5854 (compute_display_string_pos, compute_display_string_end):
5855 New functions.
5856 (push_it): Accept second argument POSITION, where pop_it should
5857 jump to continue iteration.
5858 (reseat_1): Initialize bidi_it.disp_pos.
5859
5860 * keyboard.c (adjust_point_for_property): Adjust the call to
5861 display_prop_intangible_p to its new signature.
5862
5863 * dispextern.h (struct bidi_it): New member frame_window_p.
5864 (bidi_init_it): Update prototypes.
5865 (display_prop_intangible_p): Update prototype.
5866 (compute_display_string_pos, compute_display_string_end):
5867 Declare prototypes.
5868 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5869 EMACS_INT.
5870
5871 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5872
5873 Malloc failure behavior now depends on size of allocation.
5874 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5875 * lisp.h: Change signatures accordingly.
5876 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5877 All callers changed. (Bug#8762)
5878
5879 * gnutls.c: Use Emacs's memory allocators.
5880 Without this change, the gnutls library would invoke malloc etc.
5881 directly, which causes problems on non-SYNC_INPUT hosts, and which
5882 runs afoul of improving memory_full behavior. (Bug#8761)
5883 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5884 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5885 xfree instead of the default malloc, realloc, free.
5886 (Fgnutls_boot): No need to check for memory allocation failure,
5887 since xmalloc does that for us.
5888
5889 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5890 * category.c (hash_get_category_set):
5891 * ccl.c (ccl_driver):
5892 * charset.c (Fdefine_charset_internal):
5893 * charset.h (struct charset.hash_index):
5894 * composite.c (get_composition_id, gstring_lookup_cache)
5895 (composition_gstring_put_cache):
5896 * composite.h (struct composition.hash_index):
5897 * dispextern.h (struct image.hash):
5898 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5899 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5900 (hashfn_equal, hashfn_user_defined, make_hash_table)
5901 (maybe_resize_hash_table, hash_lookup, hash_put)
5902 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5903 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5904 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5905 * image.c (make_image, search_image_cache, lookup_image)
5906 (xpm_put_color_table_h):
5907 * lisp.h (struct Lisp_Hash_Table):
5908 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5909 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5910 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5911 * alloc.c (allocate_vectorlike):
5912 Check for overflow in vector size calculations.
5913 * ccl.c (ccl_driver):
5914 Check for overflow when converting EMACS_INT to int.
5915 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5916 need to be updated by these changes.
5917 * fns.c (make_hash_table, maybe_resize_hash_table):
5918 Check for integer overflow with large hash tables.
5919 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5920 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5921 (SXHASH_REDUCE): New macro.
5922 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5923 Use it instead of discarding useful hash info with large hash values.
5924 (sxhash_float): New function.
5925 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5926 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5927 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5928 Rewrite to use FIXNUM_BITS, as this simplifies things.
5929 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5930 Adjust signatures to match updated version of code.
5931 (consing_since_gc): Now EMACS_INT, since a single hash table can
5932 use more than INT_MAX bytes.
5933
5934 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5935
5936 Make it possible to build with GCC-4.6+ -O2 -flto.
5937
5938 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5939
5940 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5941
5942 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5943 Call minibuffer-inactive-mode.
5944
5945 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5946
5947 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5948 Update dependencies.
5949
5950 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5951
5952 * data.c (init_data): Remove code for UTS, this system is not
5953 supported anymore.
5954
5955 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5956
5957 Don't force ./temacs to start in terminal mode.
5958
5959 * frame.c (make_initial_frame): Initialize faces in all cases, not
5960 only when CANNOT_DUMP is defined.
5961 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5962
5963 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5964
5965 * dispnew.c (add_window_display_history): Use const for the string
5966 pointer. Remove declaration, not needed.
5967
5968 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5969
5970 Use 'inline', not 'INLINE'.
5971 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5972 * alloc.c, fontset.c (INLINE): Remove.
5973 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5974 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5975 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5976 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5977 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5978
5979 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5980
5981 Make it possible to run ./temacs.
5982
5983 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5984 syms_of_callproc does the same thing. Remove test for
5985 "initialized", do it in the caller.
5986 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5987
5988 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5989
5990 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5991 (read_minibuf): Use get_minibuffer.
5992 (syms_of_minibuf): Use DEFSYM.
5993 (Qmetadata): New var.
5994 * data.c (Qbuffer): Don't make it static.
5995 (syms_of_data): Use DEFSYM.
5996
5997 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5998
5999 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6000 (CCL_CODE_MIN): New macro.
6001
6002 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6003
6004 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6005
6006 * eval.c (Qdebug): Now static.
6007 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6008 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6009 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6010
6011 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6012
6013 * image.c: Various fixes to ImageMagick code comments.
6014 (Fimagemagick_types): Doc fix.
6015
6016 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6017
6018 Minor fixes prompted by GCC 4.6.0 warnings.
6019
6020 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6021
6022 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6023 (x_clipboard_manager_save_all): Move extern decl to ...
6024 * xterm.h: ... here, so that it can be checked for consistency.
6025
6026 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6027
6028 * xselect.c (x_clipboard_manager_save_frame)
6029 (x_clipboard_manager_save_all): New functions.
6030 (Fx_clipboard_manager_save): Lisp function deleted.
6031
6032 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6033 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6034
6035 * xterm.h: Update prototype.
6036
6037 2011-05-28 William Xu <william.xwl@gmail.com>
6038
6039 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6040 exiting (Bug#8239).
6041
6042 2011-05-28 Jim Meyering <meyering@redhat.com>
6043
6044 Avoid a sign-extension bug in crypto_hash_function.
6045 * fns.c (to_uchar): Define.
6046 (crypto_hash_function): Use it to convert some newly-signed
6047 variables to unsigned, to avoid sign-extension bugs. For example,
6048 without this change, (md5 "truc") would evaluate to
6049 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6050 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6051 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6052
6053 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6054
6055 Integer overflow fixes.
6056
6057 * dbusbind.c: Serial number integer overflow fixes.
6058 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6059 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6060 to hold a serial number that is too large for a fixnum.
6061 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6062 Check for serial numbers out of range. Decode any serial number
6063 that was so large that it became a float. (Bug#8722)
6064
6065 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6066 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6067 Use XFASTINT rather than XUINT when numbers are nonnegative.
6068 (xd_append_arg, Fdbus_method_return_internal):
6069 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6070 arguments, check that Lisp number is nonnegative, rather than
6071 silently wrapping negative numbers around. (Bug#8722)
6072 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6073 (Bug#8722)
6074
6075 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6076
6077 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6078
6079 ccl: Add integer overflow checks.
6080 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6081 (IN_INT_RANGE): New macros.
6082 (ccl_driver): Use them to check for integer overflow when
6083 decoding a CCL program. Many of the new checks are whether XINT (x)
6084 fits in int; it doesn't always, on 64-bit hosts. The new version
6085 doesn't catch all possible integer overflows, but it's an
6086 improvement. (Bug#8719)
6087
6088 * alloc.c (make_event_array): Use XINT, not XUINT.
6089 There's no need for unsigned here.
6090
6091 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6092 This follows up to the 2011-05-06 change that substituted uintptr_t
6093 for EMACS_INT. This case wasn't caught back then.
6094
6095 Rework Fformat to avoid integer overflow issues.
6096 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6097 now (part of C89). Include <verify.h>.
6098 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6099 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6100 (Fformat): Avoid the prepass trying to compute sizes; it was only
6101 approximate and thus did not catch overflow reliably. Instead, walk
6102 through the format just once, formatting and computing sizes as we go,
6103 checking for integer overflow at every step, and allocating a larger
6104 buffer as needed. Keep track separately whether the format is
6105 multibyte. Keep only the most-recently calculated precision, rather
6106 than them all. Record whether each argument has been converted to
6107 string. Use EMACS_INT, not int, for byte and char and arg counts.
6108 Support field widths and precisions larger than INT_MAX. Avoid
6109 sprintf's undefined behavior with conversion specifications such as %#d
6110 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6111 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6112 formatting out-of-range floating point numbers with int
6113 formats. (Bug#8668)
6114
6115 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6116
6117 * data.c: Avoid integer truncation in expressions involving floats.
6118 * data.c: Include <intprops.h>.
6119 (arith_driver): When there's an integer overflow in an expression
6120 involving floating point, convert the integers to floating point
6121 so that the resulting value does not suffer from catastrophic
6122 integer truncation. For example, on a 64-bit host (* 4
6123 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6124 Do not rely on undefined behavior after integer overflow.
6125
6126 merge count_size_as_multibyte, parse_str_to_multibyte
6127 * character.c, character.h (count_size_as_multibyte):
6128 Rename from parse_str_to_multibyte; all uses changed.
6129 Check for integer overflow.
6130 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6131 since it's now a duplicate of the other. This is more of
6132 a character than a buffer op, so better that it's in character.c.
6133 * fns.c, print.c: Adjust to above changes.
6134
6135 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6136
6137 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6138
6139 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6140
6141 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6142 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6143 (x_clipboard_manager_save): Now static.
6144 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6145
6146 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6147 (crypto_hash_function): Now static.
6148 Fix pointer signedness problems. Avoid unnecessary initializations.
6149
6150 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6151
6152 * termhooks.h (Vselection_alist): Make it terminal-local.
6153
6154 * terminal.c (create_terminal): Initialize it.
6155
6156 * xselect.c: Support for clipboard managers.
6157 (Vselection_alist): Move to termhooks.h as terminal-local var.
6158 (LOCAL_SELECTION): New macro.
6159 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6160 (symbol_to_x_atom): Remove gratuitous arg.
6161 (x_handle_selection_request, lisp_data_to_selection_data)
6162 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6163 (x_own_selection, x_get_local_selection, x_convert_selection):
6164 New arg, specifying work frame. Use terminal-local Vselection_alist.
6165 (some_frame_on_display): Delete unused function.
6166 (Fx_own_selection_internal, Fx_get_selection_internal)
6167 (Fx_disown_selection_internal, Fx_selection_owner_p)
6168 (Fx_selection_exists_p): New optional frame arg.
6169 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6170 (x_handle_selection_clear): Don't treat other terminals with the
6171 same keyboard specially. Use the terminal-local Vselection_alist.
6172 (x_clear_frame_selections): Use Frun_hook_with_args.
6173
6174 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6175
6176 * xterm.h: Add support for those atoms.
6177
6178 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6179
6180 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6181 (converted_selections, conversion_fail_tag): New global variables.
6182 (x_selection_request_lisp_error): Free the above.
6183 (x_get_local_selection): Remove unnecessary code.
6184 (x_reply_selection_request): Args changed; handle arbitrary array
6185 of converted selections stored in converted_selections.
6186 Separate the XChangeProperty and SelectionNotify steps.
6187 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6188 (x_convert_selection): New function.
6189 (x_handle_selection_event): Simplify.
6190 (x_get_foreign_selection): Don't ignore incoming requests while
6191 waiting for an answer; this will fail when we implement
6192 SAVE_TARGETS, and seems unnecessary anyway.
6193 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6194 (Vx_sent_selection_functions): Doc fix.
6195
6196 2011-05-26 Leo Liu <sdl.web@gmail.com>
6197
6198 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6199
6200 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6201
6202 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6203
6204 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6205 for fringe update if it has periodic bitmap.
6206 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6207 and fringe_bitmap_periodic_p.
6208
6209 * fringe.c (get_fringe_bitmap_data): New function.
6210 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6211 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6212 row. Mark glyph row for fringe update if periodicity changed.
6213
6214 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6215 for fringe update unless it has periodic bitmap.
6216
6217 2011-05-25 Kenichi Handa <handa@m17n.org>
6218
6219 * xdisp.c (get_next_display_element): Set correct it->face_id for
6220 a static composition.
6221
6222 2011-05-24 Leo Liu <sdl.web@gmail.com>
6223
6224 * deps.mk (fns.o):
6225 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6226
6227 * fns.c (crypto_hash_function, Fsha1): New function.
6228 (Fmd5): Use crypto_hash_function.
6229 (syms_of_fns): Add Ssha1.
6230
6231 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6232
6233 * gnutls.c: Remove unused macros.
6234 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6235 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6236 Remove macros that are defined and never used.
6237 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6238
6239 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6240
6241 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6242 (Fx_get_selection_internal): Minor cleanup.
6243 (Fx_own_selection_internal): Rename arguments for consistency with
6244 select.el.
6245
6246 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6247
6248 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6249
6250 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6251
6252 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6253
6254 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6255
6256 * dispnew.c (scrolling_window): Don't exclude the case that the
6257 last enabled row in the desired matrix touches the bottom boundary.
6258
6259 2011-05-21 Glenn Morris <rgm@gnu.org>
6260
6261 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6262 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6263 and add some more files.
6264
6265 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6266
6267 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6268 report_file_error introduced by the change from 2011-05-07.
6269
6270 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6271
6272 * systime.h (Time): Define only if emacs is defined.
6273 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6274 where the include path doesn't have X11/X.h by default. See
6275 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6276
6277 2011-05-20 Kenichi Handa <handa@m17n.org>
6278
6279 * composite.c (find_automatic_composition): Fix previous change.
6280
6281 2011-05-20 Glenn Morris <rgm@gnu.org>
6282
6283 * lisp.mk: New file, split from Makefile.in.
6284 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6285 (shortlisp): Remove.
6286 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6287
6288 2011-05-19 Glenn Morris <rgm@gnu.org>
6289
6290 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6291 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6292 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6293 (lisp): Set the order to that of loadup.el.
6294 (shortlisp): Make it a copy of $lisp.
6295 (SOME_MACHINE_LISP): Remove.
6296 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6297 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6298
6299 2011-05-18 Kenichi Handa <handa@m17n.org>
6300
6301 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6302 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6303 (find_automatic_composition): Mostly rewrite for efficiency.
6304
6305 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6306
6307 * makefile.w32-in: Update dependencies.
6308
6309 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6310
6311 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6312 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6313
6314 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6315
6316 Fix some integer overflow issues, such as string length overflow.
6317
6318 * insdel.c (count_size_as_multibyte): Check for string overflow.
6319
6320 * character.c (lisp_string_width): Check for string overflow.
6321 Use EMACS_INT, not int, for string indexes and lengths; in
6322 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6323 the resulting string length overflows an EMACS_INT; instead,
6324 report a string overflow if no precision given. When checking for
6325 precision exhaustion, use a check that cannot possibly have
6326 integer overflow. (Bug#8675)
6327 * character.h (lisp_string_width): Adjust to new signature.
6328
6329 * alloc.c (string_overflow): New function.
6330 (Fmake_string): Use it. This doesn't change behavior, but saves
6331 a few bytes and will simplify future changes.
6332 * character.c (string_escape_byte8): Likewise.
6333 * lisp.h (string_overflow): New decl.
6334
6335 Fixups, following up to the user-interface timestamp change.
6336 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6337 for UI timestamps, instead of unsigned long.
6338 * msdos.c (mouse_get_pos): Likewise.
6339 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6340 * w32gui.h (Time): Define by including "systime.h" rather than by
6341 declaring it ourselves. (Bug#8664)
6342
6343 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6344 * image.c (clear_image_cache): Likewise.
6345
6346 * term.c (term_mouse_position): Don't assume time_t wraparound.
6347
6348 Be more systematic about user-interface timestamps.
6349 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6350 and sometimes 'EMACS_UINT', to represent these timestamps.
6351 This change causes it to use 'Time' uniformly, as that's what X uses.
6352 This makes the code easier to follow, and makes it easier to catch
6353 integer overflow bugs such as Bug#8664.
6354 * frame.c (Fmouse_position, Fmouse_pixel_position):
6355 Use Time, not unsigned long, for user-interface timestamps.
6356 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6357 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6358 * keyboard.h (last_event_timestamp): Likewise.
6359 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6360 * menu.h (xmenu_show): Likewise.
6361 * term.c (term_mouse_position): Likewise.
6362 * termhooks.h (struct input_event.timestamp): Likewise.
6363 (struct terminal.mouse_position_hook): Likewise.
6364 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6365 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6366 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6367 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6368 what it was before.
6369 * menu.h, termhooks.h: Include "systime.h", for Time.
6370
6371 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6372 Don't assume that the difference between two unsigned long values
6373 can fit into an integer. At this point, we know button_down_time
6374 <= event->timestamp, so the difference must be nonnegative, so
6375 there's no need to cast the result if double-click-time is
6376 nonnegative, as it should be; check that it's nonnegative, just in
6377 case. This bug is triggered when events are more than 2**31 ms
6378 apart (about 25 days). (Bug#8664)
6379
6380 * xselect.c (last_event_timestamp): Remove duplicate decl.
6381 (x_own_selection): Remove needless cast to unsigned long.
6382
6383 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6384 that always fit in int. Use a sentinel instead of a counter, to
6385 avoid a temp and to allay GCC's concerns about possible int overflow.
6386 * frame.h (struct frame): Use int for menu_bar_items_used
6387 instead of EMACS_INT, since it always fits in int.
6388
6389 * menu.c (grow_menu_items): Check for int overflow.
6390
6391 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6392
6393 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6394 Before, the code was not consistent. These values cannot exceed
6395 2**31 - 1 so there's no need to make them unsigned.
6396 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6397 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6398 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6399 as modifiers.
6400 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6401
6402 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6403 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6404 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6405 presumably because the widths might not match.
6406
6407 * window.c (size_window): Avoid needless test at loop start.
6408
6409 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6410
6411 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6412
6413 2011-05-12 Drew Adams <drew.adams@oracle.com>
6414
6415 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6416
6417 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6418
6419 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6420 `width' to `bar_area_x' and `bar_area_width', respectively.
6421 (x_scroll_run): Take account of fringe background extension.
6422
6423 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6424 Rename local vars `left' and `width' to `bar_area_x' and
6425 `bar_area_width', respectively.
6426 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6427 background extension.
6428
6429 2011-05-10 Jim Meyering <meyering@redhat.com>
6430
6431 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6432
6433 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6434
6435 * image.c (Finit_image_library): Return t for built-in image types,
6436 like pbm and xbm. (Bug#8640)
6437
6438 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6439
6440 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6441
6442 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6443
6444 * w32console.c (Fset_screen_color): Doc fix.
6445 (Fget_screen_color): New function.
6446 (syms_of_ntterm): Defsubr it.
6447
6448 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6449 unlink the temporary file if Fcall_process didn't create it in the
6450 first place.
6451 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6452 child process will be redirected to a file specified with `:file'.
6453 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6454 cue to call_process_cleanup not to close that handle.
6455
6456 2011-05-07 Ben Key <bkey76@gmail.com>
6457
6458 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6459 one of two shell specific rules, either bootstrap-temacs-CMD or
6460 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6461 to the previous implementation of the bootstrap-temacs rule.
6462 The bootstrap-temacs-CMD rule is similar to the previous
6463 implementation of the bootstrap-temacs rule except that it
6464 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6465 variable.
6466
6467 These changes, along with some changes to nt/configure.bat,
6468 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6469 earlier fix to add support for --cflags and --ldflags options
6470 that include quotes so that it works whether make uses cmd or
6471 sh as the shell.
6472
6473 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6474
6475 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6476 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6477 is a constant.
6478 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6479 a string. Handle both cases.
6480 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6481 (Fdbus_register_method): Use Qinvalid_function.
6482
6483 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6484
6485 * makefile.w32-in: Update dependencies.
6486 (LISP_H): Add inttypes.h and stdin.h.
6487 (PROCESS_H): Add unistd.h.
6488
6489 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6490
6491 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6492 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6493
6494 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6495
6496 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6497
6498 * term.c (vfatal): Remove stray call to va_end.
6499 It's not needed and the C Standard doesn't allow it here anyway.
6500
6501 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6502 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6503
6504 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6505 bytes.
6506
6507 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6508
6509 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6510
6511 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6512
6513 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6514
6515 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6516
6517 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6518 * charset.c (Fdefine_charset_internal): Don't initialize
6519 charset.code_space[15]. The value was garbage, on hosts with
6520 32-bit int (Bug#8600).
6521
6522 * lread.c (read_integer): Be more consistent with string-to-number.
6523 Use string_to_number to do the actual conversion; this avoids
6524 rounding errors and fixes some other screwups. Without this fix,
6525 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6526 (digit_to_number): Move earlier, for benefit of read_integer.
6527 Return -1 if the digit is out of range for the base, -2 if it is
6528 not a digit in any supported base. (Bug#8602)
6529
6530 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6531
6532 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6533 to match comment at start of function. This also removes a
6534 GCC warning about overflow in a 32+64-bit port.
6535
6536 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6537
6538 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6539 Reported by Stefan Monnier in
6540 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6541 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6542 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6543
6544 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6545 (EMACS_UINTPTR): Likewise, with uintptr_t.
6546
6547 * lisp.h: Prefer 64-bit EMACS_INT if available.
6548 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6549 on 32-bit hosts that have 64-bit int, so that they can access
6550 large files.
6551 However, temporarily disable this change unless the temporary
6552 symbol WIDE_EMACS_INT is defined.
6553
6554 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6555
6556 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6557 This removes an assumption that EMACS_INT and long are the same
6558 width as pointers. The assumption is true for Emacs porting targets
6559 now, but we want to make other targets possible.
6560 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6561 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6562 In the rest of the code, change types of integers that hold casted
6563 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6564 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6565 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6566 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6567 No need to cast type when ORing.
6568 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6569 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6570 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6571 assume EMACS_INT is the same width as char *.
6572 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6573 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6574 Remove no-longer-needed casts.
6575 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6576 (xg_tool_bar_help_callback, xg_make_tool_item):
6577 Use EMACS_INTPTR to hold an integer
6578 that will be cast to void *; this can avoid a GCC warning
6579 if EMACS_INT is not the same width as void *.
6580 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6581 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6582 (current_message_1, set_message_1):
6583 Use a local to convert to proper width without a cast.
6584 * xmenu.c (dialog_selection_callback): Likewise.
6585
6586 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6587 Also, don't assume VALBITS / RAND_BITS is less than 5,
6588 and don't rely on undefined behavior when shifting a 1 left into
6589 the sign bit.
6590 * lisp.h (get_random): Change signature to match.
6591
6592 * lread.c (hash_string): Use size_t, not int, for hash computation.
6593 Normally we prefer signed values; but hashing is special, because
6594 it's better to use unsigned division on hash table sizes so that
6595 the remainder is nonnegative. Also, size_t is the natural width
6596 for hashing into memory. The previous code used 'int', which doesn't
6597 retain enough info to hash well into very large tables.
6598 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6599
6600 * dbusbind.c: Don't possibly lose pointer info when converting.
6601 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6602 Use XPNTR rather than XHASH, so that the high-order bits of
6603 the pointer aren't lost when converting through void *.
6604
6605 * eval.c (Fautoload): Don't double-shift a pointer.
6606
6607 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6608
6609 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6610
6611 * gnutls.c (DEF_GNUTLS_FN):
6612 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6613
6614 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6615
6616 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6617 marker. (Bug#8610)
6618
6619 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6620
6621 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6622 New version that can reserve upto 2GB of heap space.
6623
6624 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6625
6626 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6627
6628 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6629
6630 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6631 `gnutls_certificate_set_x509_key_file'.
6632
6633 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6634
6635 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6636 Update dependencies.
6637
6638 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6639
6640 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6641 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6642 Remove unused parameter `fildes'.
6643 * process.c (read_process_output, send_process): Don't pass it.
6644
6645 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6646
6647 Fix previous change: the library cache is defined in w32.c.
6648 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6649 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6650
6651 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6652
6653 Implement dynamic loading of GnuTLS on Windows.
6654
6655 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6656 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6657 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6658 Declare.
6659
6660 * gnutls.c (Qgnutls_dll): Define.
6661 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6662 (gnutls_*): Declare function pointers.
6663 (init_gnutls_functions): New function to initialize function pointers.
6664 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6665 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6666 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6667 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6668 (emacs_gnutls_write, emacs_gnutls_read)
6669 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6670 (Fgnutls_available_p): New function.
6671 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6672 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6673 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6674
6675 * image.c: Include w32.h.
6676 (Vimage_type_cache): Delete.
6677 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6678 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6679 (w32_delayed_load): Move to w32.c.
6680
6681 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6682
6683 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6684 (w32_delayed_load): Move from image.c. When loading a library, record
6685 its filename in the :loaded-from property of the library id.
6686 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6687 Initialize and staticpro them.
6688 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6689
6690 * process.c: Include lisp.h before w32.h, not after.
6691 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6692 instead of gnutls_record_check_pending.
6693
6694 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6695
6696 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6697
6698 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6699 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6700 as passed in.
6701
6702 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6703
6704 * xterm.c (x_set_frame_alpha): Do not set property on anything
6705 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6706
6707 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6708
6709 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6710
6711 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6712
6713 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6714 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6715 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6716 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6717 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6718 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6719 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6720 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6721 (Qgnutls_bootprop_callbacks_verify): Make static.
6722
6723 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6724
6725 * callproc.c: Indentation fixup.
6726
6727 * sysdep.c (wait_for_termination_1): Make static.
6728 (wait_for_termination, interruptible_wait_for_termination):
6729 Move after wait_for_termination_1.
6730
6731 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6732
6733 * sysdep.c (interruptible_wait_for_termination): New function
6734 which is like wait_for_termination, but allows keyboard
6735 interruptions.
6736
6737 * callproc.c (Fcall_process): Add (:file "file") as an option for
6738 the STDOUT buffer.
6739 (Fcall_process_region): Ditto.
6740
6741 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6742
6743 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6744 rather than `XVECTOR (FOO)->size'.
6745
6746 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6747 inttypes.h, as a gnulib replacement is used if it not available in
6748 system headers.
6749
6750 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6751
6752 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6753 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6754 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6755
6756 * coding.c (coding_alloc_by_realloc): Error out if destination
6757 will grow beyond MOST_POSITIVE_FIXNUM.
6758 (decode_coding_emacs_mule): Abort if there isn't enough place in
6759 charbuf for the composition carryover bytes. Reserve an extra
6760 space for up to 2 characters produced in a loop.
6761 (decode_coding_iso_2022): Abort if there isn't enough place in
6762 charbuf for the composition carryover bytes.
6763
6764 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6765
6766 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6767 aborting when %lld or %lll format is passed.
6768 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6769 %llo or %llx format is passed. (Bug#8545)
6770
6771 * window.c (window_scroll_line_based): Use a marker instead of
6772 simple variables to record original value of point. (Bug#7952)
6773
6774 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6775 produced by %s or %c overflows available buffer space. (Bug#8545)
6776
6777 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6780 (SIZE_MAX): Move defn after all includes, as they might #define it.
6781
6782 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6783
6784 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6785
6786 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6787
6788 * keyboard.c (Qdelayed_warnings_hook): Define.
6789 (command_loop_1): Run `delayed-warnings-hook'
6790 if Vdelayed_warnings_list is non-nil.
6791 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6792 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6793
6794 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6795
6796 * doprnt.c (doprnt): Don't return value smaller than the buffer
6797 size if the message was truncated. (Bug#8545).
6798
6799 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6800
6801 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6802 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6803
6804 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6805
6806 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6807
6808 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6809
6810 * makefile.w32-in: Update dependencies.
6811
6812 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6813
6814 Improve `doprnt' and its usage. (Bug#8545)
6815 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6816 `format_end'. Remove support for %l as a conversion specifier.
6817 Don't use xrealloc. Improve diagnostics when the %l size modifier
6818 is used. Update the commentary.
6819
6820 * eval.c (verror): Simplify calculation of size_t.
6821
6822 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6823 messages.
6824
6825 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6826
6827 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6828 change.
6829
6830 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6831
6832 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6833 This makes this file independent of the recent pseudovector change.
6834
6835 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6836
6837 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6838
6839 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6840 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6841 Remove unused local.
6842 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6843
6844 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6845 GCC 4.6.0 optimizes based on type-based alias analysis.
6846 For example, if b is of type struct buffer * and v of type struct
6847 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6848 != &v->size, and therefore "v->size = 1; b->size = 2; return
6849 v->size;" must therefore return 1. This assumption is incorrect
6850 for Emacs, since it type-puns struct Lisp_Vector * with many other
6851 types. To fix this problem, this patch adds a new type struct
6852 vectorlike_header that documents the constraints on layout of vectors
6853 and pseudovectors, and helps optimizing compilers not get fooled
6854 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6855 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6856 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6857 the size member.
6858 (XSETPVECTYPE): Rewrite in terms of new macro.
6859 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6860 This is a bit clearer, and further avoids the possibility of
6861 undesirable aliasing.
6862 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6863 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6864 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6865 since Lisp_Subr is a special case (no "next" field).
6866 (ASIZE): Now uses header.size rather than size.
6867 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6868 to avoid the hassle of writing XVECTOR (foo)->header.size.
6869 (struct vectorlike_header): New type.
6870 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6871 object, to help avoid aliasing.
6872 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6873 (SUBRP): Likewise, since Lisp_Subr is a special case.
6874 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6875 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6876 (struct Lisp_Hash_Table): Combine first two members into a single
6877 struct vectorlike_header member. All uses of "size" and "next" members
6878 changed to be "header.size" and "header.next".
6879 * buffer.h (struct buffer): Likewise.
6880 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6881 * frame.h (struct frame): Likewise.
6882 * process.h (struct Lisp_Process): Likewise.
6883 * termhooks.h (struct terminal): Likewise.
6884 * window.c (struct save_window_data, struct saved_window): Likewise.
6885 * window.h (struct window): Likewise.
6886 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6887 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6888 * buffer.c (init_buffer_once): Likewise.
6889 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6890 special case.
6891 * process.c (Fformat_network_address): Use local var for size,
6892 for brevity.
6893
6894 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6895
6896 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6897 * data.c (atof): Remove decl; no longer used or needed.
6898 (digit_to_number): Move to lread.c.
6899 (Fstring_to_number): Use new string_to_number function, to be
6900 consistent with how the Lisp reader treats infinities and NaNs.
6901 Do not assume that floating-point numbers represent EMACS_INT
6902 without losing information; this is not true on most 64-bit hosts.
6903 Avoid double-rounding errors, by insisting on integers when
6904 parsing non-base-10 numbers, as the documentation specifies.
6905 * lisp.h (string_to_number): New decl, replacing ...
6906 (isfloat_string): Remove.
6907 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6908 (read1): Do not accept +. and -. as integers; this
6909 appears to have been a coding error. Similarly, do not accept
6910 strings like +-1e0 as floating point numbers. Do not report
6911 overflow for integer overflows unless the base is not 10 which
6912 means we have no simple and reliable way to continue.
6913 Break out the floating-point parsing into a new
6914 function string_to_number, so that Fstring_to_number parses
6915 floating point numbers consistently with the Lisp reader.
6916 (digit_to_number): Move here from data.c. Make it static inline.
6917 (E_CHAR, EXP_INT): Remove, replacing with ...
6918 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6919 (string_to_number): New function, replacing isfloat_string.
6920 This function checks for valid syntax and produces the resulting
6921 Lisp float number too. Rework it so that string-to-number
6922 no longer mishandles examples like "1.0e+". Use strtoumax,
6923 so that overflow for non-base-10 numbers is reported only when
6924 there's no portable and simple way to convert to floating point.
6925
6926 * textprop.c (set_text_properties_1): Rewrite for clarity,
6927 and to avoid GCC warning about integer overflow.
6928
6929 * intervals.h (struct interval): Use EMACS_INT for members
6930 where EMACS_UINT might cause problems. See
6931 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6932 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6933 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6934 All uses changed.
6935 (offset_intervals): Tell GCC not to worry about length overflow
6936 when negating a negative length.
6937
6938 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6939 (overrun_check_free): Likewise.
6940
6941 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6942 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6943 word size.
6944
6945 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6946 (gnutls_make_error): Rename local to avoid shadowing.
6947 (gnutls_emacs_global_deinit): ifdef out; not used.
6948 (Fgnutls_boot): Use const for pointer to readonly storage.
6949 Comment out unused local. Fix pointer signedness problems.
6950
6951 * lread.c (openp): Don't stuff size_t into an 'int'.
6952 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6953 about possible signed overflow.
6954
6955 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6956 (GDK_KEY_g): Don't define if already defined.
6957 (xg_prepare_tooltip): Avoid pointer signedness problem.
6958 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6959
6960 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6961 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6962
6963 * xfns.c (Fx_window_property): Simplify a bit,
6964 to make a bit faster and to avoid GCC 4.6.0 warning.
6965 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6966
6967 * fns.c (internal_equal): Don't assume size_t fits in int.
6968
6969 * alloc.c (compact_small_strings): Tighten assertion a little.
6970
6971 Replace pEd with more-general pI, and fix some printf arg casts.
6972 * lisp.h (pI): New macro, generalizing old pEd macro to other
6973 conversion specifiers. For example, use "...%"pI"d..." rather
6974 than "...%"pEd"...".
6975 (pEd): Remove. All uses replaced with similar uses of pI.
6976 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6977 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6978 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6979 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6980 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6981 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6982 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6983 64-bit hosts.
6984 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6985 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6986 * print.c (safe_debug_print, print_object): Likewise.
6987 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6988 to int.
6989 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6990 avoiding the 0 flag, which is not portable.
6991 * process.c (Fmake_network_process): Use pI to avoid cast.
6992 * region-cache.c (pp_cache): Likewise.
6993 * xdisp.c (decode_mode_spec): Likewise.
6994 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6995 behavior on 64-bit hosts with printf arg.
6996 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6997 (x_stop_queuing_selection_requests): Likewise.
6998 (x_get_window_property): Don't truncate byte count to an 'int'
6999 when tracing.
7000
7001 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7002 here, since it parses constructs like leading '-' and spaces,
7003 which are not wanted; and it overflows with large numbers.
7004 Instead, simply match F[0-9]+, which is what is wanted anyway.
7005
7006 * alloc.c: Remove unportable assumptions about struct layout.
7007 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7008 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7009 (allocate_vectorlike, make_pure_vector): Use the new macros,
7010 plus offsetof, to remove unportable assumptions about struct layout.
7011 These assumptions hold on all porting targets that I know of, but
7012 they are not guaranteed, they're easy to remove, and removing them
7013 makes further changes easier.
7014
7015 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7016 This doesn't fix a bug but makes the code clearer.
7017 (string_overrun_cookie): Now const. Use initializers that
7018 don't formally overflow signed char, to avoid warnings.
7019 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7020 can cause Emacs to crash when string overrun checking is enabled.
7021 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7022 multiple of sizeof (EMACS_INT); it need not be, if
7023 alignof(EMACS_INT) < sizeof (EMACS_INT).
7024 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7025
7026 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7027
7028 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7029
7030 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7031
7032 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7033 supposed to be handshaking. (Bug#8556)
7034 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7035
7036 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7037
7038 * lisp.h (Qdebug): List symbol.
7039 * eval.c (Qdebug): Restore global linkage.
7040 * keyboard.c (debug-on-event): New variable.
7041 (handle_user_signal): Break into debugger when debug-on-event
7042 matches the current signal symbol.
7043
7044 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7045
7046 * alloc.c (check_sblock, check_string_bytes)
7047 (check_string_free_list): Convert to standard C.
7048
7049 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7050
7051 * w32.c (emacs_gnutls_push): Fix typo.
7052
7053 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7054
7055 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7056 "cast to pointer from integer of different size".
7057
7058 Improve doprnt and its use in verror. (Bug#8545)
7059 * doprnt.c (doprnt): Document the set of format control sequences
7060 supported by the function. Use SAFE_ALLOCA instead of always
7061 using `alloca'.
7062
7063 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7064 is one byte too soon. Don't use xrealloc; instead xfree and
7065 xmalloc anew.
7066
7067 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7068
7069 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7070 callbacks stage.
7071
7072 * gnutls.c: Renamed global_initialized to
7073 gnutls_global_initialized. Added internals for the
7074 :verify-hostname-error, :verify-error, and :verify-flags
7075 parameters of `gnutls-boot' and documented those parameters in the
7076 docstring. Start callback support.
7077 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7078 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7079 on error. Return error code.
7080 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7081 (emacs_gnutls_read): Likewise.
7082 (Fgnutls_boot): Return handshake error code.
7083 (emacs_gnutls_handle_error): New function.
7084 (wsaerror_to_errno): Likewise.
7085
7086 * w32.h (emacs_gnutls_pull): Add prototype.
7087 (emacs_gnutls_push): Likewise.
7088
7089 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7090 (emacs_gnutls_push): Likewise.
7091
7092 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7093
7094 * process.c (wait_reading_process_output): Check if GnuTLS
7095 buffered some data internally if no FDs are set for TLS
7096 connections.
7097
7098 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7099 (LIBS): Link to USER_LIBS.
7100 ($(BLD)/gnutls.$(0)): New target.
7101
7102 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7103
7104 * xdisp.c (handle_single_display_spec): Rename the
7105 display_replaced_before_p argument into display_replaced_p, to
7106 make it consistent with the commentary. Fix typos in the
7107 commentary.
7108
7109 * textprop.c (syms_of_textprop): Remove dead code.
7110 (copy_text_properties): Delete obsolete commentary about an
7111 interface that was deleted long ago. Fix typos in the description
7112 of arguments.
7113
7114 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7115 to changes in oldXMenu/XMenu.h from 2011-04-16.
7116 <menu_help_message, prev_menu_help_message>: Constify.
7117 (IT_menu_make_room): menu->help_text is now `const char **';
7118 adjust.
7119
7120 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7121 to changes in oldXMenu/XMenu.h from 2011-04-16.
7122 (struct XMenu): Declare `help_text' `const char **'.
7123
7124 * xfaces.c <Qunspecified>: Make extern again.
7125
7126 * syntax.c: Include sys/types.h before including regex.h, as
7127 required by Posix.
7128
7129 * doc.c (get_doc_string): Improve the format passed to `error'.
7130
7131 * doprnt.c (doprnt): Improve commentary.
7132
7133 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7134
7135 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7136 them with etags.
7137
7138 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7139 changes in globals.h immediately force recompilation.
7140 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7141 $(CURDIR)/s/ms-w32.h.
7142 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7143
7144 * character.c (Fchar_direction): Function deleted.
7145 (syms_of_character): Don't defsubr it.
7146 <char-direction-table>: Deleted.
7147
7148 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7149
7150 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7151 * doprnt.c: Include limits.h.
7152 (SIZE_MAX): New macro.
7153 (doprnt): Return a size_t value. 2nd arg is now size_t.
7154 Many local variables are now size_t instead of int or unsigned.
7155 Improve overflow protection. Support `l' modifier for integer
7156 conversions. Support %l conversion. Don't assume an EMACS_INT
7157 argument for integer conversions and for %c.
7158
7159 * lisp.h (doprnt): Restore prototype.
7160
7161 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7162 $(SRC)/character.h.
7163
7164 * Makefile.in (base_obj): Add back doprnt.o.
7165
7166 * deps.mk (doprnt.o): Add back prerequisites.
7167 (callint.o): Depend on character.h.
7168
7169 * eval.c (internal_lisp_condition_case): Include the handler
7170 representation in the error message.
7171 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7172 when breaking from the loop.
7173
7174 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7175
7176 * callint.c (Fcall_interactively): When displaying error message
7177 about invalid control letter, pass the character's codepoint, not
7178 a pointer to its multibyte form. Improve display of the character
7179 in octal and display also its hex code.
7180
7181 * character.c (char_string): Use %x to display the (unsigned)
7182 codepoint of an invalid character, to avoid displaying a bogus
7183 negative value.
7184
7185 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7186 `error', not SYMBOL_NAME itself.
7187
7188 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7189 character arguments to `error'.
7190
7191 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7192 to `error' in error message about FINAL_CHAR argument. Make sure
7193 FINAL_CHAR is a character, and use %c when it is passed as
7194 argument to `error'.
7195
7196 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7197
7198 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7199
7200 * w32.c: Include <time.h>.
7201 (sys_localtime): New function.
7202
7203 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7204
7205 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7206
7207 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7208
7209 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7210
7211 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7212 zombies (Bug#8467).
7213
7214 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7215
7216 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7217 gl_state.e_property when gl_state.object is Qt.
7218
7219 * insdel.c (make_gap_larger): Remove limitation of buffer size
7220 to <= INT_MAX.
7221
7222 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7223
7224 * xdisp.c (lookup_glyphless_char_display)
7225 (produce_glyphless_glyph): Handle cons cell entry in
7226 glyphless-char-display.
7227 (Vglyphless_char_display): Document it.
7228
7229 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7230 glyphless-char-display.
7231
7232 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7233
7234 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7235
7236 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7237
7238 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7239 definition for no-X builds.
7240
7241 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7242
7243 Static checks with GCC 4.6.0 and non-default toolkits.
7244
7245 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7246
7247 * process.c (keyboard_bit_set): Define only if SIGIO.
7248 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7249 (send_process): Repair possible setjmp clobbering.
7250
7251 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7252
7253 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7254
7255 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7256
7257 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7258 Define only if needed.
7259
7260 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7261 by pacifying GCC about it. Maybe it's time to retire it?
7262 * xfaces.c (USG, __TIMEVAL__): Likewise.
7263
7264 * dispextern.h (struct redisplay_interface): Rename param
7265 to avoid shadowing.
7266 * termhooks.h (struct terminal): Likewise.
7267 * xterm.c (xembed_send_message): Likewise.
7268
7269 * insdel.c (make_gap_smaller): Define only if
7270 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7271
7272 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7273 it.
7274
7275 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7276 so that we aren't warned about unused symbols.
7277
7278 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7279
7280 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7281
7282 * xfns.c (x_real_positions): Mark locals as initialized.
7283
7284 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7285
7286 * xterm.c: Fix problems found by static analysis with other toolkits.
7287 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7288 (x_dispatch_event): Declare static if USE_GTK, and
7289 define if USE_GTK || USE_X_TOOLKIT.
7290 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7291 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7292 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7293 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7294
7295 * xmenu.c (menu_help_callback): Pointer type fixes.
7296 Use const pointers when pointing at readonly data. Avoid pointer
7297 signedness clashes.
7298 (FALSE): Remove unused macro.
7299 (update_frame_menubar): Remove unused decl.
7300
7301 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7302
7303 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7304 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7305 (single_menu_item): Rename local to avoid shadowing.
7306
7307 * keyboard.c (make_lispy_event): Remove unused local var.
7308
7309 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7310 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7311
7312 * bitmaps: Change bitmaps from unsigned char back to the X11
7313 compatible char. Avoid the old compiler warnings about
7314 out-of-range initializers by using, for example, '\xab' rather
7315 than 0xab.
7316
7317 * xgselect.c (xgselect_initialize): Check vs interface
7318 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7319
7320 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7321
7322 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7323 to read-only memory.
7324
7325 * fns.c (vector): Remove; this old hack is no longer needed.
7326
7327 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7328 Remove unused var.
7329 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7330
7331 * xrdb.c (x_load_resources): Omit unused local.
7332
7333 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7334 (x_window): Rename locals to avoid shadowing.
7335 (USG): Use the kludged USG macro, to pacify gcc.
7336
7337 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7338 (x_term_init): Remove local to avoid shadowing.
7339
7340 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7341
7342 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7343 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7344
7345 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7346
7347 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7348
7349 Fix regex.c, syntax.c and friends for buffers > 2GB.
7350 * syntax.h (struct gl_state_s): Declare character position members
7351 EMACS_INT.
7352
7353 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7354
7355 * textprop.c (verify_interval_modification, interval_of):
7356 Declare arguments EMACS_INT.
7357
7358 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7359 EMACS_INT.
7360
7361 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7362
7363 * indent.c (Fvertical_motion): Local variable it_start is now
7364 EMACS_INT.
7365
7366 * regex.c (re_match, re_match_2, re_match_2_internal)
7367 (bcmp_translate, regcomp, regexec, print_double_string)
7368 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7369 (re_compile_pattern, re_exec): Declare arguments and local
7370 variables `size_t' and `ssize_t' and return values `regoff_t', as
7371 appropriate.
7372 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7373 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7374 <compile_stack_type>: `size' and `avail' are now `size_t'.
7375
7376 * regex.h <regoff_t>: Use ssize_t, not int.
7377 (re_search, re_search_2, re_match, re_match_2): Arguments that
7378 specify buffer/string position and length are now ssize_t and
7379 size_t. Return type is regoff_t.
7380
7381 2011-04-16 Ben Key <bkey76@gmail.com>
7382
7383 * nsfont.m: Fixed bugs in ns_get_family and
7384 ns_descriptor_to_entity that were caused by using free to
7385 deallocate memory blocks that were allocated by xmalloc (via
7386 xstrdup). This caused Emacs to crash when compiled with
7387 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7388 --enable-checking=xmallocoverrun). xfree is now used to
7389 deallocate these memory blocks.
7390
7391 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7392
7393 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7394
7395 emacs_write: Accept and return EMACS_INT for sizes.
7396 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7397 et seq.
7398 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7399 Accept and return EMACS_INT.
7400 (emacs_gnutls_write): Return the number of bytes written on
7401 partial writes.
7402 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7403 (emacs_read, emacs_write): Remove check for negative size, as the
7404 Emacs source code has been audited now.
7405 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7406 (emacs_read, emacs_write): Use it.
7407 * process.c (send_process): Adjust to the new signatures of
7408 emacs_write and emacs_gnutls_write. Do not attempt to store
7409 a byte offset into an 'int'; it might overflow.
7410 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7411
7412 * sound.c: Don't assume sizes fit in 'int'.
7413 (struct sound_device.period_size, alsa_period_size):
7414 Return EMACS_INT, not int.
7415 (struct sound_device.write, vox_write, alsa_write):
7416 Accept EMACS_INT, not int.
7417 (wav_play, au_play): Use EMACS_INT to store sizes and to
7418 record read return values.
7419
7420 2011-04-15 Ben Key <bkey76@gmail.com>
7421
7422 * keyboard.c (Qundefined): Don't declare static since it is used
7423 in nsfns.m.
7424 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7425 static since they are used in nsfont.m.
7426
7427 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7428
7429 * process.c (Qprocessp): Don't declare static.
7430 * lisp.h (Qprocessp): Declare again.
7431
7432 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7433
7434 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7435
7436 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7437
7438 Improve C-level modularity by making more things 'static'.
7439
7440 Don't publish debugger-only interfaces to other modules.
7441 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7442 (verify_bytepos, count_markers): Move decls to the only modules
7443 that need them.
7444 * region-cache.h (pp_cache): Likewise.
7445 * window.h (check_all_windows): Likewise.
7446 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7447
7448 * sysdep.c (croak): Now static, if
7449 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7450 * syssignal.h (croak): Declare only if not static.
7451
7452 * alloc.c (refill_memory_reserve): Now static if
7453 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7454 * lisp.h (refill_memory_reserve): Declare only if not static.
7455
7456 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7457 Define only if USE_LUCID.
7458
7459 * xrdb.c (x_customization_string, x_rm_string): Now static.
7460
7461 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7462 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7463
7464 * xdisp.c (draw_row_with_mouse_face): Now static.
7465 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7466
7467 * window.h (check_all_windows): Mark externally visible.
7468
7469 * window.c (window_deletion_count): Now static.
7470
7471 * undo.c: Make symbols static if they're not exported.
7472 (last_undo_buffer, last_boundary_position, pending_boundary):
7473 Now static.
7474
7475 * textprop.c (interval_insert_behind_hooks): Now static.
7476 (interval_insert_in_front_hooks): Likewise.
7477
7478 * term.c: Make symbols static if they're not exported.
7479 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7480 (max_frame_lines, tty_set_terminal_modes):
7481 (tty_reset_terminal_modes, tty_turn_off_highlight):
7482 (get_tty_terminal): Now static.
7483 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7484 * termhooks.h (term_mouse_moveto): Do not declare if
7485 HAVE_WINDOW_SYSTEM.
7486 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7487 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7488
7489 * sysdep.c: Make symbols static if they're not exported.
7490 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7491 Now static.
7492 (sigprocmask_set, full_mask): Remove; unused.
7493 (wait_debugging): Mark as visible.
7494 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7495 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7496
7497 * syntax.c (syntax_temp): Define only if !__GNUC__.
7498
7499 * sound.c (current_sound_device, current_sound): Now static.
7500
7501 * search.c (searchbufs, searchbuf_head): Now static.
7502
7503 * scroll.c (scroll_cost): Remove; unused.
7504 * dispextern.h (scroll_cost): Remove decl.
7505
7506 * region-cache.h (pp_cache): Mark as externally visible.
7507
7508 * process.c: Make symbols static if they're not exported.
7509 (process_tick, update_tick, create_process, chan_process):
7510 (Vprocess_alist, proc_buffered_char, datagram_access):
7511 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7512 (deactivate_process): Mark defn as static, as well as decl.
7513 * lisp.h (create_process): Remove decl.
7514 * process.h (chan_process, Vprocess_alist): Remove decls.
7515
7516 * print.c: Make symbols static if they're not exported.
7517 (print_depth, new_backquote_output, being_printed, print_buffer):
7518 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7519 (print_interval, print_number_index, initial_stderr_stream):
7520 Now static.
7521 * lisp.h (Fprinc): Remove decl.
7522 (debug_output_compilation_hack): Mark as externally visible.
7523
7524 * sysdep.c (croak): Move decl from here to syssignal.h.
7525 * syssignal.h (croak): Put it here, so the API can be checked when
7526 'croak' is called from dissociate_if_controlling_tty.
7527
7528 * minibuf.c: Make symbols static if they're not exported.
7529 (minibuf_save_list, choose_minibuf_frame): Now static.
7530 * lisp.h (choose_minibuf_frame): Remove decl.
7531
7532 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7533
7534 * lread.c: Make symbols static if they're not exported.
7535 (read_objects, initial_obarray, oblookup_last_bucket_number):
7536 Now static.
7537 (make_symbol): Remove; unused.
7538 * lisp.h (initial_obarray, make_symbol): Remove decls.
7539
7540 * keyboard.c: Make symbols static if they're not exported.
7541 (single_kboard, recent_keys_index, total_keys, recent_keys):
7542 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7543 (this_single_command_key_start, echoing, last_auto_save):
7544 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7545 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7546 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7547 (Vlispy_mouse_stem, double_click_count):
7548 Now static.
7549 (force_auto_save_soon): Define only if SIGDANGER.
7550 (ignore_mouse_drag_p): Now static if
7551 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7552 (print_help): Remove; unused.
7553 (stop_character, last_timer_event): Mark as externally visible.
7554 * keyboard.h (ignore_mouse_drag_p): Declare only if
7555 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7556 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7557 * lisp.h (echoing): Remove decl.
7558 (force_auto_save_soon): Declare only if SIGDANGER.
7559 * xdisp.c (redisplay_window): Simplify code, to make it more
7560 obvious that ignore_mouse_drag_p is not accessed if !defined
7561 USE_GTK && !defined HAVE_NS.
7562
7563 * intervals.c: Make symbols static if they're not exported.
7564 (merge_properties_sticky, merge_interval_right, delete_interval):
7565 Now static.
7566 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7567
7568 * insdel.c: Make symbols static if they're not exported.
7569 However, leave prepare_to_modify_buffer alone. It's never
7570 called from outside this function, but that appears to be a bug.
7571 (combine_after_change_list, combine_after_change_buffer):
7572 (adjust_after_replace, signal_before_change): Now static.
7573 (adjust_after_replace_noundo): Remove; unused.
7574 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7575 (signal_before_change): Remove decls.
7576
7577 * indent.c (val_compute_motion, val_vmotion): Now static.
7578
7579 * image.c: Make symbols static if they're not exported.
7580 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7581 if USE_GTK.
7582 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7583 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7584
7585 * fringe.c (standard_bitmaps): Now static.
7586 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7587
7588 * frame.c: Make symbols static if they're not exported.
7589 (x_report_frame_params, make_terminal_frame): Now static.
7590 (get_frame_param): Now static, unless HAVE_NS.
7591 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7592 (x_get_resource_string): Remove; not used.
7593 * frame.h (make_terminal_frame, x_report_frame_params):
7594 (x_get_resource_string); Remove decls.
7595 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7596 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7597
7598 * font.c, fontset.c: Make symbols static if they're not exported.
7599 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7600 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7601 * font.c (font_close_object): Now static.
7602 * font.h (font_close_object): Remove.
7603 * fontset.c (FONTSET_OBJLIST): Remove.
7604 (free_realized_fontset) #if-0 the body, which does nothing.
7605 (face_suitable_for_char_p): #if-0, as it's never called.
7606 * fontset.h (face_suitable_for_char_p): Remove decl.
7607 * xfaces.c (face_at_string_position):
7608 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7609 since 0 is always ASCII.
7610
7611 * fns.c (weak_hash_tables): Now static.
7612
7613 * fileio.c: Make symbols static if they're not exported.
7614 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7615 (Vwrite_region_annotation_buffers): Now static.
7616
7617 * eval.c: Make symbols static if they're not exported.
7618 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7619 * lisp.h (backtrace_list): Remove decl.
7620
7621 * emacs.c: Make symbols static if they're not exported.
7622 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7623 (fatal_error_code, fatal_error_signal_hook, standard_args):
7624 Now static.
7625 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7626 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7627 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7628 * lisp.h (fatal_error_signal_hook): Remove decl.
7629 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7630
7631 * editfns.c: Move a (normally-unused) function to its only use.
7632 * editfns.c, lisp.h (get_operating_system_release): Remove.
7633 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7634 worth the hassle of breaking this out.
7635
7636 * xterm.c: Make symbols static if they're not exported.
7637 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7638 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7639 (x_destroy_window, x_delete_display):
7640 Now static.
7641 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7642 (x_mouse_leave): Remove; unused.
7643 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7644 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7645 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7646 Remove decls.
7647 (x_mouse_leave): Declare only if WINDOWSNT.
7648 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7649 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7650 USE_X_TOOLKIT.
7651
7652 * ftxfont.c: Make symbols static if they're not exported.
7653 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7654 HAVE_FREETYPE.
7655 * font.h (ftxfont_driver): Likewise.
7656
7657 * xfns.c: Make symbols static if they're not exported.
7658 (x_last_font_name, x_display_info_for_name):
7659 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7660 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7661 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7662 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7663 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7664 (last_show_tip_args): Now static.
7665 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7666 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7667 (x_screen_planes): Remove; unused.
7668 * dispextern.h (x_screen_planes): Remove decl.
7669
7670 * dispnew.c: Make symbols static if they're not exported.
7671 * dispextern.h (redraw_garbaged_frames, scrolling):
7672 (increment_row_positions): Remove.
7673 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7674 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7675 Now static.
7676 (redraw_garbaged_frames): Remove; unused.
7677
7678 * xfaces.c: Make symbols static if they're not exported.
7679 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7680 Remove decls.
7681 * xterm.h (defined_color): Remove decls.
7682 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7683 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7684 (menu_face_changed_default, defined_color, free_realized_face):
7685 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7686 (ascii_face_of_lisp_face): Remove; unused.
7687
7688 * xdisp.c: Make symbols static if they're not exported.
7689 * dispextern.h (scratch_glyph_row, window_box_edges):
7690 (glyph_to_pixel_coords, set_cursor_from_row):
7691 (get_next_display_element, set_iterator_to_next):
7692 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7693 (show_mouse_face): Remove decls
7694 * frame.h (message_buf_print): Likewise.
7695 * lisp.h (pop_message, set_message, check_point_in_composition):
7696 Likewise.
7697 * xterm.h (set_vertical_scroll_bar): Likewise.
7698 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7699 (message_buf_print, scratch_glyph_row, displayed_buffer):
7700 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7701 (get_next_display_element, show_mouse_face, window_box_edges):
7702 (frame_to_window_pixel_xy, check_point_in_composition):
7703 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7704 (glyph_to_pixel_coords): Remove; unused.
7705
7706 * dired.c (file_name_completion): Now static.
7707
7708 * dbusbind.c (xd_in_read_queued_messages): Now static.
7709
7710 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7711 * data.c (circular_list_error): Remove.
7712
7713 * commands.h (last_point_position, last_point_position_buffer):
7714 (last_point_position_window): Remove decls.
7715 * keyboard.c: Make these variables static.
7716
7717 * coding.h (coding, code_convert_region, encode_coding_gap):
7718 Remove decls.
7719 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7720 (iso_code_class, detect_coding, code_convert_region): Now static.
7721 (encode_coding_gap): Remove; unused.
7722
7723 * chartab.c (chartab_chars, chartab_bits): Now static.
7724
7725 * charset.h (charset_iso_8859_1): Remove decl.
7726 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7727 Now static.
7728
7729 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7730 * ccl.c (Vccl_program_table): Now static.
7731 (check_ccl_update): Remove; unused.
7732
7733 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7734 * category.h: ... from here.
7735 * category.c (check_category_table, set_category_set): Now static.
7736
7737 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7738 * lisp.h: Remove these decls.
7739
7740 * buffer.c (buffer_count): Remove unused var.
7741
7742 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7743 so that it's not optimized away.
7744 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7745 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7746 exported only to the debugger.
7747
7748 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7749 * atimer.h (run_all_atimers): Remove; not exported.
7750
7751 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7752 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7753 was inaccessible from Lisp.
7754 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7755 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7756
7757 alloc.c: Import and export fewer symbols, and remove unused items.
7758 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7759 is defined.
7760 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7761 it's not optimized away by whole-program optimization.
7762 (message_enable_multibyte, free_misc): Remove.
7763 (catchlist, handlerlist, mark_backtrace):
7764 Declare only if BYTE_MARK_STACK.
7765 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7766 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7767 (message_enable_multibyte): Remove decl.
7768 (free_misc, interval_free_list, float_block, float_block_index):
7769 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7770 (cons_free_list, last_marked_index):
7771 Now static.
7772 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7773 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7774 (mark_backtrace): Define only if BYTE_MARK_STACK.
7775 * xdisp.c (message_enable_multibyte): Now static.
7776
7777 Declare Lisp_Object Q* variables to be 'static' if not exported.
7778 This makes it easier for human readers (and static analyzers)
7779 to see whether these variables are used from other modules.
7780 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7781 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7782 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7783 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7784 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7785 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7786 * xmenu.c, xselect.c:
7787 Declare Q* vars static if they are not used in other modules.
7788 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7789 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7790 Remove decls of unexported vars.
7791 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7792
7793 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7794
7795 Make Emacs functions such as Fatom 'static' by default.
7796 This makes it easier for human readers (and static analyzers)
7797 to see whether these functions can be called from other modules.
7798 DEFUN now defines a static function. To make the function external
7799 so that it can be used in other C modules, use the new macro DEFUE.
7800 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7801 (Finit_image_library):
7802 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7803 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7804 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7805 Remove decls, since these functions are now static.
7806 (Funintern, Fget_internal_run_time): New decls, since these functions
7807 were already external.
7808
7809 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7810 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7811 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7812 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7813 * keyboard.c, keymap.c, lread.c:
7814 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7815 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7816 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7817 Mark functions with DEFUE instead of DEFUN,
7818 if they are used in other modules.
7819 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7820 decls for now-static functions.
7821 * buffer.h (Fdelete_overlay): Remove decl.
7822 * callproc.c (Fgetenv_internal): Mark as internal.
7823 * composite.c (Fremove_list_of_text_properties): Remove decl.
7824 (Fcomposition_get_gstring): New forward static decl.
7825 * composite.h (Fcomposite_get_gstring): Remove decl.
7826 * dired.c (Ffile_attributes): New forward static decl.
7827 * doc.c (Fdocumntation_property): New forward static decl.
7828 * eval.c (Ffetch_bytecode): New forward static decl.
7829 (Funintern): Remove extern decl; now in .h file where it belongs.
7830 * fileio.c (Fmake_symbolic_link): New forward static decl.
7831 * image.c (Finit_image_library): New forward static decl.
7832 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7833 * intervals.h (Fprevious_property_change):
7834 (Fremove_list_of_text_properties): Remove decls.
7835 * keyboard.c (Fthis_command_keys): Remove decl.
7836 (Fcommand_execute): New forward static decl.
7837 * keymap.c (Flookup_key): New forward static decl.
7838 (Fcopy_keymap): Now static.
7839 * keymap.h (Flookup_key): Remove decl.
7840 * process.c (Fget_process): New forward static decl.
7841 (Fprocess_datagram_address): Mark as internal.
7842 * syntax.c (Fsyntax_table_p): New forward static decl.
7843 (skip_chars): Remove duplicate decl.
7844 * textprop.c (Fprevious_property_change): New forward static decl.
7845 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7846 Now internal.
7847 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7848 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7849
7850 * editfns.c (Fformat): Remove unreachable code.
7851
7852 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7853
7854 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7855 change. (Bug#8496)
7856
7857 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7858
7859 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7860 when at ZV. (Bug#8487)
7861
7862 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7863
7864 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7865 (Bug#8437)
7866 * keyboard.c (parse_tool_bar_item): Likewise.
7867 * sound.c (sound_cleanup, alsa_close): Likewise.
7868 * termcap.c (tgetent): Likewise.
7869 * xfns.c (x_default_font_parameter): Likewise.
7870 * xsettings.c (read_and_apply_settings): Likewise.
7871
7872 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7873 (overrun_check_free): Protoize.
7874
7875 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7876
7877 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7878 since callers should never pass a negative size.
7879 Change the signature to match that of plain 'read' and 'write'; see
7880 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7881 * lisp.h: Update prototypes of emacs_write and emacs_read.
7882
7883 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7884
7885 * xdisp.c (redisplay_window): Don't try to determine the character
7886 position of the scroll margin if the window start point w->startp
7887 is outside the buffer's accessible region. (Bug#8468)
7888
7889 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7890
7891 Fix write-region and its subroutines for buffers > 2GB.
7892 * fileio.c (a_write, e_write): Modify declaration of arguments and
7893 local variables to support buffers larger than 2GB.
7894 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7895
7896 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7897 argument, local variables, and return value.
7898
7899 * lisp.h: Update prototypes of emacs_write and emacs_read.
7900
7901 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7902
7903 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7904
7905 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7906
7907 Fix more problems found by GCC 4.6.0's static checks.
7908
7909 * xdisp.c (vmessage): Use a better test for character truncation.
7910
7911 * charset.c (load_charset_map): <, not <=, for optimization,
7912 and to avoid potential problems with integer overflow.
7913 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7914 * casetab.c (set_identity, shuffle): Likewise.
7915 * editfns.c (Fformat): Likewise.
7916 * syntax.c (skip_chars): Likewise.
7917
7918 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7919 This also lets GCC 4.6.0 generate slightly better loop code.
7920
7921 * callint.c (Fcall_interactively): <, not <=, for optimization.
7922 (Fcall_interactively): Count the number of arguments produced,
7923 not the number of arguments given. This is simpler and lets GCC
7924 4.6.0 generate slightly better code.
7925
7926 * ftfont.c: Distingish more carefully between FcChar8 and char.
7927 The previous code passed unsigned char * to a functions like
7928 strlen and xstrcasecmp that expect char *, which does not
7929 conform to the C standard.
7930 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7931 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7932 char * when the C standard requires it.
7933
7934 * keyboard.c (read_char): Remove unused var.
7935
7936 * eval.c: Port to Windows vsnprintf (Bug#8435).
7937 Include <limits.h>.
7938 (SIZE_MAX): Define if the headers do not.
7939 (verror): Do not give up if vsnprintf returns a negative count.
7940 Instead, grow the buffer. This ports to Windows vsnprintf, which
7941 does not conform to C99. Problem reported by Eli Zaretskii.
7942 Also, simplify the allocation scheme, by avoiding the need for
7943 calling realloc, and removing the ALLOCATED variable.
7944
7945 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7946
7947 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7948 But keep the doprint source code for now, as we might revamp it
7949 and use it again (Bug#8435).
7950 * lisp.h (doprnt): Remove.
7951 * Makefile.in (base_obj): Remove doprnt.o.
7952 * deps.mk (doprnt.o): Remove.
7953
7954 error: Print 32- and 64-bit integers portably (Bug#8435).
7955 Without this change, on typical 64-bit hosts error ("...%d...", N)
7956 was used to print both 32- and 64-bit integers N, which relied on
7957 undefined behavior.
7958 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7959 * lisp.h (error, verror): Mark as printf-like functions.
7960 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7961 Report overflow in size calculations when allocating printf buffer.
7962 Do not truncate output string at its first null byte.
7963 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7964 Truncate the output at a character boundary, since vsnprintf does not
7965 do that.
7966 * charset.c (check_iso_charset_parameter): Convert internal
7967 character to string before calling 'error', since %c now has the
7968 printf meaning.
7969 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7970 overflow when computing char to be passed to 'error'. Do not
7971 pass Lisp_Object to 'error'; pass the integer instead.
7972 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7973 formatted with plain %d.
7974
7975 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7976
7977 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7978
7979 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7980
7981 * xterm.c (x_catch_errors): Remove duplicate declaration.
7982
7983 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7984
7985 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7986
7987 2011-04-10 Jim Meyering <meyering@redhat.com>
7988
7989 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7990 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7991 return ssize_t not "int", and use size_t as the buffer length.
7992 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7993 * gnutls.h: Update declarations.
7994 * process.c (read_process_output): Use ssize_t, to match.
7995 (send_process): Likewise.
7996
7997 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7998
7999 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8000
8001 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8002
8003 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8004 Use unsigned char, to match FcChar8 type definition.
8005
8006 * xterm.c (handle_one_xevent):
8007 * xmenu.c (create_and_show_popup_menu):
8008 * xselect.c (x_decline_selection_request)
8009 (x_reply_selection_request): Avoid type-punned deref of X events.
8010
8011 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8012
8013 Fix some uses of `int' instead of EMACS_INT.
8014 * search.c (string_match_1, fast_string_match)
8015 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8016 (scan_buffer, find_next_newline_no_quit)
8017 (find_before_next_newline, search_command, Freplace_match)
8018 (Fmatch_data): Make some `int' variables be EMACS_INT.
8019
8020 * xdisp.c (display_count_lines): 3rd argument and return value now
8021 EMACS_INT. All callers changed.
8022 (pint2hrstr): Last argument is now EMACS_INT.
8023
8024 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8025 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8026 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8027 (decode_coding_utf_16, decode_coding_emacs_mule)
8028 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8029 (decode_coding_ccl, decode_coding_charset)
8030 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8031 (decode_coding_iso_2022, decode_coding_emacs_mule)
8032 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8033 <char_offset, last_offset>: Declare EMACS_INT.
8034 (encode_coding_utf_8, encode_coding_utf_16)
8035 (encode_coding_emacs_mule, encode_invocation_designation)
8036 (encode_designation_at_bol, encode_coding_iso_2022)
8037 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8038 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8039 Declare EMACS_INT.
8040 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8041 (encode_invocation_designation): Last argument P_NCHARS is now
8042 EMACS_INT.
8043 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8044 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8045
8046 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8047 All users changed.
8048
8049 * ccl.c (Fccl_execute_on_string): Declare some variables
8050 EMACS_INT.
8051
8052 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8053
8054 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8055
8056 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8057
8058 * process.c (Fformat_network_address): Doc fix.
8059
8060 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8061
8062 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8063
8064 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8065
8066 * keyboard.c (read_char): Call Lisp function help-form-show,
8067 instead of using internal_with_output_to_temp_buffer.
8068 (Qhelp_form_show): New var.
8069 (syms_of_keyboard): Use DEFSYM macro.
8070
8071 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8072
8073 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8074
8075 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8076
8077 * process.c (Flist_processes): Remove to Lisp.
8078 (list_processes_1): Delete.
8079
8080 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8081
8082 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8083
8084 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8085
8086 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8087
8088 Fix more problems found by GCC 4.6.0's static checks.
8089
8090 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8091
8092 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8093
8094 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8095
8096 * xdisp.c (vmessage): Mark as a printf-like function.
8097
8098 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8099
8100 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8101
8102 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8103 printf-like functions.
8104 (tiff_load): Add casts to remove these marks before passing them
8105 to system-supplied API.
8106
8107 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8108
8109 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8110 This avoids several warnings with gcc -Wstrict-overflow.
8111 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8112 directly, rather than having caller test rule sign. This avoids
8113 some unnecessary tests.
8114 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8115 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8116 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8117
8118 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8119 (xfont_open): Avoid unnecessary tests.
8120
8121 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8122
8123 * composite.h, composite.c (composition_gstring_put_cache):
8124 Use EMACS_INT, not int, for length.
8125
8126 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8127 breaking out part of COMPOSITION_DECODE_RULE.
8128 (COMPOSITION_DECODE_RULE): Use it.
8129 * composite.c (get_composition_id): Remove unused local vars,
8130 by using the new macro.
8131
8132 * textprop.c (set_text_properties_1): Change while to do-while,
8133 since the condition is always true at first.
8134
8135 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8136 (interval_deletion_adjustment): Return unsigned value.
8137 All uses changed.
8138
8139 * process.c (list_processes_1, create_pty, read_process_output):
8140 (exec_sentinel): Remove vars that were set but not used.
8141 (create_pty): Remove unnecessary "volatile"s.
8142 (Fnetwork_interface_info): Avoid possibility of int overflow.
8143 (read_process_output): Do adaptive read buffering even if carryover.
8144 (read_process_output): Simplify nbytes computation if buffered.
8145
8146 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8147
8148 * syntax.c (scan_words): Remove var that was set but not used.
8149 (update_syntax_table): Use unsigned instead of int.
8150
8151 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8152 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8153 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8154
8155 * print.c (print_error_message): Avoid int overflow.
8156
8157 * font.c (font_list_entities): Redo for clarity,
8158 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8159
8160 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8161 (font_score): Avoid potential overflow in diff calculation.
8162
8163 * fns.c (substring_both): Remove var that is set but not used.
8164 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8165
8166 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8167
8168 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8169 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8170 can always succeed if overflow has undefined behavior.
8171
8172 * search.c (boyer_moore, wordify): Remove vars set but not used.
8173 (wordify): Omit three unnecessary tests.
8174
8175 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8176 All callers changed. This avoids the need for an unused var.
8177
8178 * casefiddle.c (casify_region): Remove var that is set but not used.
8179
8180 * dired.c (file_name_completion): Remove var that is set but not used.
8181
8182 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8183
8184 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8185 (Finsert_file_contents): Remove unnecessary code checking fd.
8186
8187 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8188 Check for integer overflow on size calculations.
8189
8190 * buffer.c (Fprevious_overlay_change): Remove var that is set
8191 but not used.
8192
8193 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8194 Remove vars that are set but not used.
8195 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8196 (timer_check_2): Mark vars as initialized.
8197
8198 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8199
8200 * image.c (lookup_image): Remove var that is set but not used.
8201 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8202
8203 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8204 that are set but not used.
8205
8206 * xfns.c (make_invisible_cursor): Don't return garbage
8207 if XCreateBitmapFromData fails (Bug#8410).
8208
8209 * xselect.c (x_get_local_selection, x_handle_property_notify):
8210 Remove vars that are set but not used.
8211
8212 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8213 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8214
8215 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8216 Remove var that is set but not used.
8217 (scroll_bar_windows_size): Now size_t, not int.
8218 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8219 Check for overflow.
8220
8221 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8222 (map_tty_color) [!defined MSDOS]: Likewise.
8223
8224 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8225
8226 * coding.c: Remove vars that are set but not used.
8227 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8228 All callers changed.
8229 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8230 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8231 (decode_coding_charset): Remove vars that are set but not used.
8232
8233 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8234 that is set but not used.
8235
8236 * print.c (print_object): Remove var that is set but not used.
8237
8238 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8239 The gnulib version avoids calling malloc in the usual case,
8240 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8241 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8242 * filelock.c (current_lock_owner): Likewise.
8243 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8244 * sysdep.c: Include allocator.h, careadlinkat.h.
8245 (emacs_no_realloc_allocator): New static constant.
8246 (emacs_readlink): New function.
8247 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8248 ../lib/careadlinkat.h.
8249
8250 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8251
8252 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8253 first non-nil return value).
8254
8255 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8256
8257 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8258 if not defined (Bug#8403).
8259
8260 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8261
8262 * xdisp.c (display_count_lines): Remove parameter `start',
8263 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8264 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8265 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8266 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8267 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8268 and thereabouts. All callers changed.
8269 (get_per_char_metric): Remove parameter `f', unused since
8270 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8271
8272 2011-04-02 Jim Meyering <meyering@redhat.com>
8273
8274 do not dereference NULL upon failed strdup
8275 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8276 (ns_get_family): Likewise.
8277
8278 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8279
8280 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8281
8282 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8283
8284 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8285 later (Bug#8403).
8286
8287 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8288
8289 Add lexical binding.
8290
8291 * window.c (Ftemp_output_buffer_show): New fun.
8292 (Fsave_window_excursion):
8293 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8294
8295 * lread.c (lisp_file_lexically_bound_p): New function.
8296 (Fload): Bind Qlexical_binding.
8297 (readevalloop): Remove `evalfun' arg.
8298 Bind Qinternal_interpreter_environment.
8299 (Feval_buffer): Bind Qlexical_binding.
8300 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8301 Mark as dynamic.
8302 (syms_of_lread): Declare `lexical-binding'.
8303
8304 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8305
8306 * keyboard.c (eval_dyn): New fun.
8307 (menu_item_eval_property): Use it.
8308
8309 * image.c (parse_image_spec): Use Ffunctionp.
8310
8311 * fns.c (concat, mapcar1): Accept byte-code-functions.
8312
8313 * eval.c (Fsetq): Handle lexical vars.
8314 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8315 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8316 (FletX, Flet): Obey lexical binding.
8317 (Fcommandp): Handle closures.
8318 (Feval): New `lexical' arg.
8319 (eval_sub): New function extracted from Feval. Use it almost
8320 everywhere where Feval was used. Look up vars in lexical env.
8321 Handle closures.
8322 (Ffunctionp): Move from subr.el.
8323 (Ffuncall): Handle closures.
8324 (apply_lambda): Remove `eval_flags'.
8325 (funcall_lambda): Handle closures and new byte-code-functions.
8326 (Fspecial_variable_p): New function.
8327 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8328 but without exporting it to Lisp.
8329
8330 * doc.c (Fdocumentation, store_function_docstring):
8331 * data.c (Finteractive_form): Handle closures.
8332
8333 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8334 interactive spec.
8335
8336 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8337 New byte-codes.
8338 (exec_byte_code): New function extracted from Fbyte_code to handle new
8339 calling convention for byte-code-functions. Add new byte-codes.
8340
8341 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8342
8343 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8344
8345 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8346
8347 * xdisp.c (redisplay_internal): Fix prototype.
8348
8349 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8350
8351 * xdisp.c (SCROLL_LIMIT): New macro.
8352 (try_scrolling): Use it when setting scroll_limit.
8353 Limit scrolling to 100 screen lines.
8354 (redisplay_window): Even when falling back on "recentering",
8355 position point in the window according to scroll-conservatively,
8356 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8357
8358 (try_scrolling): When point is above the window, allow searching
8359 as far as scroll_max, or one screenful, to compute vertical
8360 distance from PT to the scroll margin position. This prevents
8361 try_scrolling from unnecessarily failing when
8362 scroll-conservatively is set to a value slightly larger than the
8363 window height. Clean up the case of PT below the margin at bottom
8364 of window: scroll_max can no longer be INT_MAX. When aggressive
8365 scrolling is in use, don't let point enter the opposite scroll
8366 margin as result of the scroll.
8367 (syms_of_xdisp) <scroll-conservatively>: Document the
8368 threshold of 100 lines for never-recentering scrolling.
8369
8370 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8371
8372 * dispextern.h (move_it_by_lines):
8373 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8374 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8375 (message_log_check_duplicate): Remove parameters `prev_bol' and
8376 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8377 (redisplay_internal): Remove parameter `preserve_echo_area',
8378 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8379
8380 * indent.c (Fvertical_motion):
8381 * window.c (window_scroll_pixel_based, Frecenter):
8382 Don't pass `need_y_p' to `move_it_by_lines'.
8383
8384 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8385
8386 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8387 steal a few bits to be more compact.
8388 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8389 Remove unneeded casts.
8390
8391 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8392
8393 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8394
8395 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8396 binding" message (bug#7967).
8397
8398 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8399
8400 Fix more problems found by GCC 4.6.0's static checks.
8401
8402 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8403 Remove unused local var.
8404
8405 * editfns.c (Fmessage_box): Remove unused local var.
8406
8407 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8408 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8409 Omit unused local vars.
8410 * window.c (shrink_windows): Omit unused local var.
8411 * menu.c (digest_single_submenu): Omit unused local var.
8412 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8413 Omit unused local var.
8414
8415 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8416 Don't assume string length fits in int.
8417 (keyremap_step, read_key_sequence): Use size_t for sizes.
8418 (read_key_sequence): Don't check last_real_key_start redundantly.
8419
8420 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8421 instead of alloca (Bug#8344).
8422
8423 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8424 (Fbacktrace_frame): Don't assume nframes fits in int.
8425
8426 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8427
8428 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8429 concerns.
8430
8431 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8432
8433 * cm.c (calccost): Turn while-do into do-while, for clarity.
8434
8435 * keyboard.c (syms_of_keyboard): Use the same style as later
8436 in this function when indexing through an array. This also
8437 works around GCC bug 48267.
8438
8439 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8440
8441 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8442
8443 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8444 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8445
8446 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8447 This avoids undefined behavior on integer overflow, and is a bit
8448 more convenient anyway since it is compared to a size_t variable.
8449
8450 Variadic C functions now count arguments with size_t, not int.
8451 This avoids an unnecessary limitation on 64-bit machines, which
8452 caused (substring ...) to crash on large vectors (Bug#8344).
8453 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8454 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8455 All variadic functions and their callers changed accordingly.
8456 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8457 * data.c (arith_driver, float_arith_driver): Likewise.
8458 * editfns.c (general_insert_function): Likewise.
8459 * eval.c (struct backtrace.nargs, interactive_p)
8460 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8461 (funcall_lambda, mark_backtrace): Likewise.
8462 * fns.c (concat): Likewise.
8463 * frame.c (x_set_frame_parameters): Likewise.
8464 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8465 0 if not found, not -1. All callers changed.
8466
8467 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8468 (stack_copy_size): Now size_t, not int.
8469 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8470
8471 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8472
8473 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8474 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8475 All callers changed.
8476
8477 * lisp.h (multibyte_char_to_unibyte):
8478 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8479 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8480 * character.h (CHAR_TO_BYTE8):
8481 * cmds.c (internal_self_insert):
8482 * editfns.c (general_insert_function):
8483 * keymap.c (push_key_description):
8484 * search.c (Freplace_match):
8485 * xdisp.c (message_dolog, set_message_1): All callers changed.
8486
8487 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8488
8489 * keyboard.c (safe_run_hook_funcall): New function.
8490 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8491 don't set the hook to nil, but remove the offending function instead.
8492 (Qcommand_hook_internal): Remove, unused.
8493 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8494 Vcommand_hook_internal.
8495
8496 * eval.c (enum run_hooks_condition): Remove.
8497 (funcall_nil, funcall_not): New functions.
8498 (run_hook_with_args): Call each function through a `funcall' argument.
8499 Remove `cond' argument, now redundant.
8500 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8501 (Frun_hook_with_args_until_failure): Adjust accordingly.
8502 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8503
8504 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8505
8506 * dispextern.h (string_buffer_position): Remove declaration.
8507
8508 * print.c (strout): Remove parameter `multibyte', unused since
8509 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8510
8511 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8512 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8513 All callers changed.
8514
8515 * w32.c (_wsa_errlist): Use braces for struct initializers.
8516
8517 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8518 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8519 All callers changed.
8520 (string_buffer_position): Likewise. Also, make static (it's never
8521 used outside xdisp.c).
8522 (cursor_row_p): Remove parameter `w', unused since
8523 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8524 (decode_mode_spec): Remove parameter `precision', introduced during
8525 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8526 All callers changed.
8527
8528 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8529
8530 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8531
8532 2011-03-27 Anders Lindgren <andlind@gmail.com>
8533
8534 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8535 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8536 (ns_update_auto_hide_menu_bar): New functions.
8537 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8538 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8539 ns_constrain_all_frames.
8540 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8541 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8542
8543 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8544
8545 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8546
8547 2011-03-27 Glenn Morris <rgm@gnu.org>
8548
8549 * syssignal.h: Replace RETSIGTYPE with void.
8550 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8551 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8552 Replace SIGTYPE with void everywhere.
8553 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8554 * s/template.h (SIGTYPE): Remove commented out definition.
8555
8556 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8557
8558 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8559 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8560
8561 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8562
8563 * w32.c (read_unc_volume): Use parameter `henum', instead of
8564 global variable `wget_enum_handle'.
8565
8566 * keymap.c (describe_vector): Remove parameters `indices' and
8567 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8568 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8569
8570 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8571
8572 * keyboard.c (timer_check): Remove parameter `do_it_now',
8573 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8574 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8575 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8576
8577 * keyboard.c (read_char):
8578 * w32menu.c (w32_menu_display_help):
8579 * xmenu.c (show_help_event, menu_help_callback):
8580 Adjust calls to `show_help_echo'.
8581
8582 * gtkutil.c (xg_maybe_add_timer):
8583 * keyboard.c (readable_events):
8584 * process.c (wait_reading_process_output):
8585 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8586
8587 * insdel.c (adjust_markers_gap_motion):
8588 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8589 (gap_left, gap_right): Don't call it.
8590
8591 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8592
8593 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8594 incurred during fontification.
8595
8596 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8597
8598 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8599 (DEFVAR_PER_BUFFER): Don't pass it.
8600
8601 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8602 (scrolling_window): Don't pass it.
8603
8604 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8605
8606 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8607
8608 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8609 and `suffix'.
8610 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8611 of variables specific to SELinux and computation of `encoded_absname'.
8612
8613 * image.c (XPutPixel): Remove unused variable `height'.
8614
8615 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8616
8617 * unexw32.c (get_section_info): Remove unused variable `section'.
8618
8619 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8620 (system_process_attributes): Remove unused variable `sess'.
8621 (sys_read): Remove unused variable `err'.
8622
8623 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8624 (w32_wnd_proc): Remove unused variable `isdead'.
8625 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8626 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8627 (x_create_tip_frame): Remove unused variable `tem'.
8628
8629 * w32inevt.c (w32_console_read_socket):
8630 Remove unused variable `no_events'.
8631
8632 * w32term.c (x_draw_composite_glyph_string_foreground):
8633 Remove unused variable `width'.
8634
8635 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8636
8637 * w32term.c (x_set_glyph_string_clipping):
8638 Don't pass uninitialized region to CombineRgn.
8639
8640 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8641
8642 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8643 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8644 (Fx_close_connection): Remove unused variable `i'.
8645
8646 * w32font.c (w32font_draw): Return number of glyphs.
8647 (w32font_open_internal): Remove unused variable `i'.
8648 (w32font_driver): Add missing initializer.
8649
8650 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8651 (fill_in_menu): Remove unused variable `items_added'.
8652
8653 * w32term.c (last_mouse_press_frame): Remove static global variable.
8654 (w32_clip_to_row): Remove unused variable `f'.
8655 (x_delete_terminal): Remove unused variable `i'.
8656
8657 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8658 (NOTHING): Remove unused static global variable.
8659 (uniscribe_check_otf): Remove unused variable `table'.
8660 (uniscribe_font_driver): Add missing initializers.
8661
8662 2011-03-23 Julien Danjou <julien@danjou.info>
8663
8664 * term.c (Fsuspend_tty, Fresume_tty):
8665 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8666 * window.c (temp_output_buffer_show):
8667 * insdel.c (signal_before_change):
8668 * frame.c (Fhandle_switch_frame):
8669 * fileio.c (Fdo_auto_save):
8670 * emacs.c (Fkill_emacs):
8671 * editfns.c (save_excursion_restore):
8672 * cmds.c (internal_self_insert):
8673 * callint.c (Fcall_interactively):
8674 * buffer.c (Fkill_all_local_variables):
8675 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8676 Use Frun_hooks.
8677 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8678 unconditionally since it does the check itself.
8679
8680 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8681
8682 Fix more problems found by GCC 4.5.2's static checks.
8683
8684 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8685 the first time through the loop, since we know p0 < p1 then.
8686 This also avoids a gcc -Wstrict-overflow warning.
8687
8688 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8689 leading to a memory leak, possible in functions like
8690 load_charset_map_from_file that can allocate an unbounded number
8691 of objects (Bug#8318).
8692
8693 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8694 that could (at least in theory) be that large.
8695
8696 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8697 This is less likely to overflow, and avoids undefined behavior if
8698 overflow does occur. All callers changed. Use strtoul to scan
8699 for the unsigned long integer.
8700 (pint2hrstr): Simplify and tune code slightly.
8701 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8702
8703 * scroll.c (do_scrolling): Work around GCC bug 48228.
8704 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8705
8706 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8707 This also avoids a warning with gcc -Wstrict-overflow.
8708 (validate_x_resource_name): Simplify count usage.
8709 This also avoids a warning with gcc -Wstrict-overflow.
8710
8711 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8712 fail (Bug#8306).
8713
8714 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8715
8716 * process.c (Fmake_network_process): Use socklen_t, not int,
8717 where POSIX says socklen_t is required in portable programs.
8718 This fixes a porting bug on hosts like 64-bit HP-UX, where
8719 socklen_t is wider than int (Bug#8277).
8720 (Fmake_network_process, server_accept_connection):
8721 (wait_reading_process_output, read_process_output):
8722 Likewise.
8723
8724 * process.c: Rename or move locals to avoid shadowing.
8725 (list_processes_1, Fmake_network_process):
8726 (read_process_output_error_handler, exec_sentinel_error_handler):
8727 Rename or move locals.
8728 (Fmake_network_process): Define label "retry_connect" only if needed.
8729 (Fnetwork_interface_info): Fix pointer signedness.
8730 (process_send_signal): Add cast to avoid pointer signedness problem.
8731 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8732 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8733
8734 Make tparam.h and terminfo.c consistent.
8735 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8736 Include tparam.h instead, since it declares them.
8737 * cm.h (PC): Remove extern decl; tparam.h now does this.
8738 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8739 * terminfo.c: Include tparam.h, to check interfaces.
8740 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8741 (tparam): Adjust signature to match interface in tparam.h;
8742 this removes some undefined behavior. Check that outstring and len
8743 are zero, which they always are with Emacs.
8744 * tparam.h (PC, BC, UP): New extern decls.
8745
8746 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8747 (xftfont_open): Rename locals to avoid shadowing.
8748
8749 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8750 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8751 (OTF_TAG_SYM): Omit macro if not needed.
8752 (ftfont_list): Remove unused local.
8753 (get_adstyle_property, ftfont_pattern_entity):
8754 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8755 Rename locals to avoid shadowing.
8756
8757 * xfont.c (xfont_list_family): Mark var as initialized.
8758
8759 * xml.c (make_dom): Now static.
8760
8761 * composite.c (composition_compute_stop_pos): Rename local to
8762 avoid shadowing.
8763 (composition_reseat_it): Remove unused locals.
8764 (find_automatic_composition, composition_adjust_point): Likewise.
8765 (composition_update_it): Mark var as initialized.
8766 (find_automatic_composition): Mark vars as initialized,
8767 with a FIXME (Bug#8290).
8768
8769 character.h: Rename locals to avoid shadowing.
8770 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8771 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8772 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8773 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8774 to avoid shadowing.
8775
8776 * textprop.c (property_change_between_p): Remove; unused.
8777
8778 * intervals.c (interval_start_pos): Now static.
8779
8780 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8781
8782 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8783 Rename locals to avoid shadowing.
8784
8785 * sound.c (wav_play, au_play, Fplay_sound_internal):
8786 Fix pointer signedness.
8787 (alsa_choose_format): Remove unused local var.
8788 (wav_play): Initialize a variable to 0, to prevent undefined
8789 behavior (Bug#8278).
8790
8791 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8792
8793 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8794
8795 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8796 clobbering (Bug#8298).
8797 * sysdep.c (sys_subshell): Likewise.
8798 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8799
8800 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8801 This should get cleaned up, so that child_setup has the
8802 same signature on all platforms.
8803
8804 * callproc.c (call_process_cleanup): Now static.
8805 (relocate_fd): Rename locals to avoid shadowing.
8806
8807 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8808
8809 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8810 not to be necessary, and produces flickering.
8811
8812 2011-03-20 Glenn Morris <rgm@gnu.org>
8813
8814 * config.in: Remove file.
8815
8816 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8817
8818 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8819 are now in src/globals.h.
8820 (syms_of_minibuf): Remove spurious & from previous change.
8821
8822 2011-03-20 Leo Liu <sdl.web@gmail.com>
8823
8824 * minibuf.c (completing-read-function): New variable.
8825 (completing-read-default): Rename from completing-read.
8826 (completing-read): Call completing-read-function.
8827
8828 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8829
8830 * xfaces.c (Fx_load_color_file):
8831 Read color file from absolute filename (bug#8250).
8832
8833 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8834
8835 * makefile.w32-in: Update dependencies.
8836
8837 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8838
8839 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8840
8841 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8842
8843 Fix more problems found by GCC 4.5.2's static checks.
8844
8845 * process.c (make_serial_process_unwind, send_process_trap):
8846 (sigchld_handler): Now static.
8847
8848 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8849 That way, the code declares only the vars that it needs.
8850 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8851 * s/cygwin.h (PTY_ITERATION): Likewise.
8852 * s/darwin.h (PTY_ITERATION): Likewise.
8853 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8854
8855 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8856 * process.c (allocate_pty): Don't declare stb unless it's needed.
8857
8858 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8859 (CONSTANTLIM): Remove; unused.
8860 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8861 Define only if needed.
8862
8863 * unexelf.c (unexec): Name an expression,
8864 to avoid gcc -Wbad-function-cast warning.
8865 Use a different way to cause a compilation error if anyone uses
8866 n rather than nn, a way that does not involve shadowing.
8867 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8868
8869 * deps.mk (unexalpha.o): Remove; unused.
8870
8871 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8872 * unexec.h: New file.
8873 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8874 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8875 Depend on unexec.h.
8876 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8877 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8878 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8879 Change as necessary to match prototype in unexec.h.
8880
8881 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8882 shadowing.
8883 (back_comment, skip_chars): Mark vars as initialized.
8884
8885 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8886 Rename locals to avoid shadowing.
8887
8888 * lread.c (read1): Rewrite so as not to use empty "else".
8889 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8890
8891 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8892
8893 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8894 warning when compiling print.c.
8895
8896 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8897 instead of using an uninitialized var.
8898 (font_sort_entities): Mark var as initialized.
8899
8900 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8901
8902 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8903 pointers to constants.
8904 (font_parse_fcname): Remove unused vars.
8905 (font_delete_unmatched): Now static.
8906 (font_get_spec): Remove; unused.
8907 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8908 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8909 Rename or move locals to avoid shadowing.
8910
8911 * fns.c (require_nesting_list, require_unwind): Now static.
8912 (Ffillarray): Rename locals to avoid shadowing.
8913
8914 * floatfns.c (domain_error2): Define only if needed.
8915 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8916
8917 * alloc.c (mark_backtrace): Move decl from here ...
8918 * lisp.h: ... to here, so that it can be checked.
8919
8920 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8921 (Fdefvar): Rewrite so as not to use empty "else".
8922 (lisp_indirect_variable): Name an expression,
8923 to avoid gcc -Wbad-function-cast warning.
8924 (Fdefvar): Rename locals to avoid shadowing.
8925
8926 * callint.c (quotify_arg, quotify_args): Now static.
8927 (Fcall_interactively): Rename locals to avoid shadowing.
8928 Use const pointer when appropriate.
8929
8930 * lisp.h (get_system_name, get_operating_system_release):
8931 Move decls here, to check interfaces.
8932 * process.c (get_operating_system_release): Move decl to lisp.h.
8933 * xrdb.c (get_system_name): Likewise.
8934 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8935 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8936 some of which prompt warnings from gcc -Wbad-function-cast.
8937 (Fformat_time_string, Fencode_time, Finsert_char):
8938 (Ftranslate_region_internal, Fformat):
8939 Rename or remove local vars to avoid shadowing.
8940 (Ftranslate_region_internal): Mark var as initialized.
8941
8942 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8943 avoid shadowing.
8944
8945 * lisp.h (eassert): Check that the argument compiles, even if
8946 ENABLE_CHECKING is not defined.
8947
8948 * data.c (Findirect_variable): Name an expression, to avoid
8949 gcc -Wbad-function-cast warning.
8950 (default_value, arithcompare, arith_driver, arith_error): Now static.
8951 (store_symval_forwarding): Rename local to avoid shadowing.
8952 (Fmake_variable_buffer_local, Fmake_local_variable):
8953 Mark variables as initialized.
8954 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8955
8956 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8957 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8958 Rename locals to avoid shadowing.
8959 (mark_stack): Move local variables into the #ifdef region where
8960 they're used.
8961 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8962 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8963 needed otherwise.
8964 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8965 (GC_STRING_CHARS): Remove; not used.
8966 (Fmemory_limit): Cast sbrk's returned value to char *.
8967
8968 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8969 avoids undefined behavior in theory.
8970
8971 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8972
8973 Use functions, not macros, for up- and down-casing (Bug#8254).
8974 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8975 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8976 to use the following functions instead of these macros.
8977 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8978 EMACS_INT, since callers assume the returned value fits in int.
8979 (upcase1): Likewise, for UPCASE_TABLE.
8980 (uppercasep, lowercasep, upcase): New static inline functions.
8981 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8982 the race-condition problem in the old DOWNCASE.
8983
8984 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8985 Rename locals to avoid shadowing.
8986 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8987 (regex_compile, re_search_2, re_match_2_internal):
8988 Remove unused local vars.
8989 (FREE_VAR): Rewrite so as not to use empty "else",
8990 which gcc can warn about.
8991 (regex_compile, re_match_2_internal): Mark locals as initialized.
8992 (RETALLOC_IF): Define only if needed.
8993 (WORDCHAR_P): Likewise. This one is never needed, but is used
8994 only in a comment talking about a compiler bug, so put inside
8995 the #if 0 of that comment.
8996 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8997 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8998 Remove; unused.
8999
9000 * search.c (boyer_moore): Rename locals to avoid shadowing.
9001 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9002 (PREV_CHAR_BOUNDARY): Likewise.
9003
9004 * search.c (simple_search): Remove unused var.
9005
9006 * dired.c (compile_pattern): Move decl from here ...
9007 * lisp.h: ... to here, so that it can be checked.
9008 (struct re_registers): New forward decl.
9009
9010 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9011
9012 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9013 All uses changed.
9014 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9015 Rename locals to avoid shadowing.
9016 (Fvertical_motion): Mark locals as initialized.
9017
9018 * casefiddle.c (casify_object, casify_region): Now static.
9019 (casify_region): Mark local as initialized.
9020
9021 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9022
9023 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9024 New macros, so that the caller can use some names other than
9025 gcpro1, gcpro2, etc.
9026 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9027 of the new macros.
9028 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9029 argument, for consistency with GCPRO2_VAR, etc: it is now the
9030 prefix of the variable, not the variable itself. All uses
9031 changed.
9032 * dired.c (directory_files_internal, file_name_completion):
9033 Rename locals to avoid shadowing.
9034
9035 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9036 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9037 dired.c's scmp function, had undefined behavior.
9038 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9039 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9040 * buffer.h: ... to here, because these macros use current_buffer,
9041 and the new implementation with inline functions needs to have
9042 current_buffer in scope now, rather than later when the macros
9043 are used.
9044 (downcase, upcase1): New static inline functions.
9045 (DOWNCASE, UPCASE1): Reimplement using these functions.
9046 This avoids undefined behavior in expressions like
9047 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9048 from race conditions in accessing the global variables
9049 case_temp1 and case_temp2.
9050 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9051 * lisp.h (case_temp1, case_temp2): Remove their decls.
9052 * character.h (ASCII_CHAR_P): Move from here ...
9053 * lisp.h: ... to here, so that the inline functions mentioned
9054 above can use them.
9055
9056 * dired.c (directory_files_internal_unwind): Now static.
9057
9058 * fileio.c (file_name_as_directory, directory_file_name):
9059 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9060 Now static.
9061 (file_name_as_directory): Use const pointers when appropriate.
9062 (Fexpand_file_name): Likewise. In particular, newdir might
9063 point at constant storage, so make it a const pointer.
9064 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9065 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9066 signedness issues.
9067 (Fset_file_times, Finsert_file_contents, auto_save_error):
9068 Rename locals to avoid shadowing.
9069
9070 * minibuf.c (choose_minibuf_frame_1): Now static.
9071 (Ftry_completion, Fall_completions): Rename or remove locals
9072 to avoid shadowing.
9073
9074 * marker.c (bytepos_to_charpos): Remove; unused.
9075
9076 * lisp.h (verify_bytepos, count_markers): New decls,
9077 so that gcc does not warn that these functions aren't declared.
9078
9079 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9080 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9081 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9082 (copy_text): Remove unused local var.
9083
9084 * filelock.c (within_one_second): Now static.
9085 (lock_file_1): Rename local to avoid shadowing.
9086
9087 * buffer.c (fix_overlays_before): Mark locals as initialized.
9088 (fix_start_end_in_overlays): Likewise. This function should be
9089 simplified by using pointers-to-pointers, but that's a different
9090 matter.
9091 (switch_to_buffer_1): Now static.
9092 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9093 (report_overlay_modification): Rename locals to avoid shadowing.
9094
9095 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9096 Fix pointer signedness issue.
9097 (sys_subshell): Mark local as volatile if checking for lint,
9098 to suppress a gcc -Wclobbered warning that does not seem to be right.
9099 (MAXPATHLEN): Define only if needed.
9100
9101 * process.c (serial_open, serial_configure): Move decls from here ...
9102 * systty.h: ... to here, so that they can be checked.
9103
9104 * fns.c (get_random, seed_random): Move extern decls from here ...
9105 * lisp.h: ... to here, so that they can be checked.
9106
9107 * sysdep.c (reset_io): Now static.
9108 (wait_for_termination_signal): Remove; unused.
9109
9110 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9111 (copy_keymap_item, append_key, push_text_char_description):
9112 Now static.
9113 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9114 (DENSE_TABLE_SIZE): Remove; unused.
9115 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9116 (describe_map_tree):
9117 Rename locals to avoid shadowing.
9118
9119 * keyboard.c: Declare functions static if they are not used elsewhere.
9120 (echo_char, echo_dash, cmd_error, top_level_2):
9121 (poll_for_input, handle_async_input): Now static.
9122 (read_char, kbd_buffer_get_event, make_lispy_position):
9123 (make_lispy_event, make_lispy_movement, apply_modifiers):
9124 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9125 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9126 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9127 (read_key_sequence, read_char): Mark locals as initialized.
9128 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9129
9130 * keyboard.h (make_ctrl_char): New decl.
9131 (mark_kboards): Move decl here ...
9132 * alloc.c (mark_kboards): ... from here.
9133
9134 * lisp.h (force_auto_save_soon): New decl.
9135
9136 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9137 (DEFINE_DUMMY_FUNCTION): New macro.
9138 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9139 Use it.
9140 (main): Add casts to avoid warnings
9141 if GCC considers string literals to be constants.
9142
9143 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9144
9145 * dbusbind.c: Pointer signedness fixes.
9146 (xd_signature, xd_append_arg, xd_initialize):
9147 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9148 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9149 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9150 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9151
9152 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9153 if GCC considers string literals to be constants.
9154 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9155
9156 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9157
9158 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9159 (print_preprocess, print_object): New macro to fix last change.
9160
9161 * print.c (print_preprocess): Don't forget font objects.
9162
9163 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9164
9165 * emacs.c (USAGE3): Doc fixes.
9166
9167 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9168
9169 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9170 structure.
9171
9172 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9173
9174 * lisp.h (VWindow_system, Qfile_name_history):
9175 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9176 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9177 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9178
9179 * w32select.c: Don't #include "keyboard.h".
9180 (run_protected): Add extern declaration for waiting_for_input.
9181
9182 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9183 * w32console.c (detect_input_pending, read_input_pending)
9184 (encode_terminal_code):
9185 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9186 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9187 (w32_system_caret_y, Qfile_name_history):
9188 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9189 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9190 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9191 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9192 * w32proc.c (Qlocal, report_file_error):
9193 * w32term.c (Vwindow_system, updating_frame):
9194 * w32uniscribe.c (initialized, uniscribe_font_driver):
9195 Remove unneeded extern declarations.
9196
9197 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9198
9199 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9200
9201 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9202
9203 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9204 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9205 These macros can no longer be used for assignment.
9206
9207 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9208 Assign struct members directly, instead of using BUF_BEGV etc.
9209 (record_buffer_markers, fetch_buffer_markers): New functions for
9210 recording and fetching special buffer markers.
9211 (set_buffer_internal_1, set_buffer_temp): Use them.
9212
9213 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9214
9215 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9216
9217 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9218 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9219
9220 * xdisp.c (hscroll_window_tree):
9221 (reconsider_clip_changes): Use PT instead of BUF_PT.
9222
9223 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9224
9225 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9226 $(EMACS_ROOT)/lib/intprops.h.
9227
9228 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9229
9230 Fix more problems found by GCC 4.5.2's static checks.
9231
9232 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9233 to unsigned char * to avoid compiler diagnostic.
9234 (xg_free_frame_widgets): Make it clear that a local variable is
9235 needed only if USE_GTK_TOOLTIP.
9236 (gdk_window_get_screen): Make it clear that this macro is needed
9237 only if USE_GTK_TOOLTIP.
9238 (int_gtk_range_get_value): New function, which avoids a diagnostic
9239 from gcc -Wbad-function-cast.
9240 (xg_set_toolkit_scroll_bar_thumb): Use it.
9241 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9242 diagnostic from gcc -Wbad-function-cast.
9243 (get_utf8_string, xg_get_file_with_chooser):
9244 Rename locals to avoid shadowing.
9245 (create_dialog): Move locals to avoid shadowing.
9246
9247 * xgselect.c (xg_select): Remove unused var.
9248
9249 * image.c (four_corners_best): Mark locals as initialized.
9250 (gif_load): Initialize transparent_p to zero (Bug#8238).
9251 Mark another local as initialized.
9252 (my_png_error, my_error_exit): Mark with NO_RETURN.
9253
9254 * image.c (clear_image_cache): Now static.
9255 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9256 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9257 (x_edge_detection): Remove unnecessary cast that
9258 gcc -Wbad-function-cast diagnoses.
9259 (gif_load): Fix pointer signedness.
9260 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9261 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9262
9263 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9264
9265 Improve quality of tests for time stamp overflow.
9266 For example, without this patch (encode-time 0 0 0 1 1
9267 1152921504606846976) returns the obviously-bogus value (-948597
9268 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9269 reports time overflow. See
9270 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9271 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9272 * editfns.c: Include limits.h and intprops.h.
9273 (TIME_T_MIN, TIME_T_MAX): New macros.
9274 (time_overflow): Move earlier, to before first use.
9275 (hi_time, lo_time): New functions, for an accurate test for
9276 out-of-range times.
9277 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9278 (Fget_internal_run_time): Don't assume time_t fits in int.
9279 (make_time): Use list2 instead of Fcons twice.
9280 (Fdecode_time): More accurate test for out-of-range times.
9281 (check_tm_member): New function.
9282 (Fencode_time): Use it, to test for out-of-range times.
9283 (lisp_time_argument): Don't rely on undefined left-shift and
9284 right-shift behavior when checking for time stamp overflow.
9285
9286 * editfns.c (time_overflow): New function, refactoring common code.
9287 (Fformat_time_string, Fdecode_time, Fencode_time):
9288 (Fcurrent_time_string): Use it.
9289
9290 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9291 * dired.c (make_time): Move to ...
9292 * editfns.c (make_time): ... here.
9293 * systime.h: Note the move.
9294
9295 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9296
9297 * fringe.c (update_window_fringes): Remove unused variables.
9298
9299 * unexmacosx.c (copy_data_segment): Also copy __got section.
9300 (Bug#8223)
9301
9302 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9303
9304 * termcap.c [MSDOS]: Include "msdos.h".
9305 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9306 Constify `char *' arguments and their references according to
9307 prototypes in tparam.h.
9308
9309 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9310
9311 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9312 Adapt all references accordingly.
9313
9314 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9315
9316 2011-03-11 Tom Tromey <tromey@redhat.com>
9317
9318 * buffer.c (syms_of_buffer): Remove obsolete comment.
9319
9320 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9321
9322 * termhooks.h (encode_terminal_code): Declare prototype.
9323
9324 * msdos.c (encode_terminal_code): Don't declare prototype.
9325
9326 * term.c (encode_terminal_code): Now external again, used by
9327 w32console.c and msdos.c.
9328
9329 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9330 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9331
9332 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9333
9334 Fix some minor problems found by GCC 4.5.2's static checks.
9335
9336 * fringe.c (update_window_fringes): Mark locals as initialized
9337 (Bug#8227).
9338 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9339
9340 * alloc.c (mark_fringe_data): Move decl from here ...
9341 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9342 to check its interface.
9343 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9344
9345 * fontset.c (free_realized_fontset): Now static.
9346 (Fset_fontset_font): Rename local to avoid shadowing.
9347 (fontset_font): Mark local as initialized.
9348 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9349
9350 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9351
9352 * xselect.c (x_disown_buffer_selections): Remove; not used.
9353 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9354 (x_own_selection, Fx_disown_selection_internal): Rename locals
9355 to avoid shadowing.
9356 (x_handle_dnd_message): Remove local to avoid shadowing.
9357
9358 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9359 so that the caller can use some name other than gcpro1.
9360 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9361 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9362 (Fx_backspace_delete_keys_p):
9363 Use them to avoid shadowing, and rename vars to avoid shadowing.
9364 (x_decode_color, x_set_name, x_window): Now static.
9365 (Fx_create_frame): Add braces to silence GCC warning.
9366 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9367 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9368 Remove unused locals.
9369 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9370 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9371 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9372 macros.
9373
9374 * xterm.h (x_mouse_leave): New decl.
9375
9376 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9377 Remove unused functions.
9378 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9379 (x_calc_absolute_position): Now static.
9380 (XTread_socket): Don't define label "out" unless it's used.
9381 Don't declare local "event" unless it's used.
9382 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9383 unless they are used.
9384 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9385 (x_fatal_error_signal): Remove; not used.
9386 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9387 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9388 (x_error_catcher, x_connection_closed, x_error_handler):
9389 (x_error_quitter, xembed_send_message, x_iconify_frame):
9390 (my_log_handler): Rename locals to avoid shadowing.
9391 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9392 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9393
9394 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9395 Rename or move locals to avoid shadowing.
9396 (tty_defined_color, merge_face_heights): Now static.
9397 (free_realized_faces_for_fontset): Remove; not used.
9398 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9399 does not deduce is never used uninitialized.
9400 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9401 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9402
9403 * terminal.c (store_terminal_param): Now static.
9404
9405 * xmenu.c (menu_highlight_callback): Now static.
9406 (set_frame_menubar): Remove unused local.
9407 (xmenu_show): Rename parameter to avoid shadowing.
9408 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9409 since they might point to immutable storage.
9410 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9411 since it's unused otherwise.
9412
9413 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9414 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9415 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9416 avoids a gcc -Wuninitialized diagnostic.
9417 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9418 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9419 does not deduce are never used uninitialized.
9420
9421 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9422
9423 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9424 * window.c (window_loop, size_window):
9425 (run_window_configuration_change_hook, enlarge_window): Likewise.
9426
9427 * window.c (display_buffer): Now static.
9428 (size_window): Mark variables that gcc -Wuninitialized
9429 does not deduce are never used uninitialized.
9430 * window.h (check_all_windows): New decl, to forestall
9431 gcc -Wmissing-prototypes diagnostic.
9432 * dispextern.h (bidi_dump_cached_states): Likewise.
9433
9434 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9435 shadowing.
9436 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9437 Include <limits.h>.
9438 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9439 and to avoid gcc -Wuninitialized warning.
9440 (load_charset_map): Mark variables that gcc -Wuninitialized
9441 does not deduce are never used uninitialized.
9442 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9443
9444 * coding.c (coding_set_source, coding_set_destination):
9445 Use "else { /* comment */ }" rather than "else /* comment */;"
9446 for clarity, and to avoid gcc -Wempty-body warning.
9447 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9448 a block, when the outer 'i' will do.
9449 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9450 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9451 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9452 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9453 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9454 Rename locals to avoid shadowing.
9455 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9456 * coding.c (emacs_mule_char, encode_invocation_designation):
9457 Now static, since they're not used elsewhere.
9458 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9459 (decode_coding_object, encode_coding_object, detect_coding_system):
9460 (decode_coding_emacs_mule): Mark variables that gcc
9461 -Wuninitialized does not deduce are never used uninitialized.
9462 (detect_coding_iso_2022): Initialize a local variable that might
9463 be used uninitialized. Leave a FIXME because it's not clear that
9464 this initialization is needed. (Bug#8211)
9465 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9466 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9467 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9468 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9469 Remove unused macros.
9470
9471 * category.c (hash_get_category_set): Remove unused local var.
9472 (copy_category_table): Now static, since it's not used elsewhere.
9473 * character.c (string_count_byte8): Likewise.
9474
9475 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9476 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9477
9478 * chartab.c (copy_sub_char_table): Now static, since it's not used
9479 elsewhere.
9480 (sub_char_table_ref_and_range, char_table_ref_and_range):
9481 Rename locals to avoid shadowing.
9482 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9483
9484 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9485 (BIDI_BOB): Remove unused macro.
9486
9487 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9488 deduce are never used uninitialized.
9489 * term.c (encode_terminal_code): Likewise.
9490
9491 * term.c (encode_terminal_code): Now static. Remove unused local.
9492
9493 * tparam.h: New file.
9494 * term.c, tparam.h: Include it.
9495 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9496 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9497 Move these decls to tparam.h, and make them agree with what
9498 is actually in tparam.c. The previous trick of using incompatible
9499 decls in different modules does not conform to the C standard.
9500 All callers of tparam changed to use tparam's actual API.
9501 * tparam.c (tparam1, tparam, tgoto):
9502 Use const pointers where appropriate.
9503
9504 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9505 * cm.h (struct cm): Likewise.
9506 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9507 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9508 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9509 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9510 (turn_on_face, init_tty): Likewise.
9511 * termchar.h (struct tty_display_info): Likewise.
9512
9513 * term.c (term_mouse_position): Rename local to avoid shadowing.
9514
9515 * alloc.c (mark_ttys): Move decl from here ...
9516 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9517
9518 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9519
9520 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9521
9522 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9523
9524 * search.c (compile_pattern_1): Remove argument regp, unused since
9525 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9526 (compile_pattern): Don't pass it.
9527
9528 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9529
9530 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9531 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9532 for ! HAVE_GTK3.
9533 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9534
9535 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9536
9537 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9538 gdk_window_get_screen, gdk_window_get_geometry,
9539 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9540 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9541 (xg_get_pixbuf_from_pixmap): New function.
9542 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9543 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9544 Call xg_get_pixbuf_from_pixmap instead of
9545 gdk_pixbuf_get_from_drawable.
9546 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9547 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9548 (xg_check_special_colors): Use GtkStyleContext and its functions
9549 for HAVE_GTK3.
9550 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9551 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9552 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9553 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9554 Call gtk_widget_get_preferred_size.
9555 (xg_frame_resized): gdk_window_get_geometry only takes 5
9556 parameters.
9557 (xg_win_to_widget, xg_event_is_for_menubar):
9558 Call gdk_x11_window_lookup_for_display.
9559 (xg_set_widget_bg): New function.
9560 (delete_cb): New function.
9561 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9562 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9563 (xg_set_background_color): Call xg_set_widget_bg.
9564 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9565 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9566 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9567 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9568 if ! HAVE_GTK3.
9569 (update_frame_tool_bar): Call gtk_widget_hide.
9570 (xg_initialize): Use GDK_KEY_g.
9571
9572 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9573 if ! HAVE_GTK3
9574 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9575
9576 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9577 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9578 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9579
9580 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9581
9582 * w32xfns.c (select_palette): Check success of RealizePalette against
9583 GDI_ERROR, not zero.
9584
9585 See ChangeLog.11 for earlier changes.
9586
9587 ;; Local Variables:
9588 ;; coding: utf-8
9589 ;; End:
9590
9591 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9592
9593 This file is part of GNU Emacs.
9594
9595 GNU Emacs is free software: you can redistribute it and/or modify
9596 it under the terms of the GNU General Public License as published by
9597 the Free Software Foundation, either version 3 of the License, or
9598 (at your option) any later version.
9599
9600 GNU Emacs is distributed in the hope that it will be useful,
9601 but WITHOUT ANY WARRANTY; without even the implied warranty of
9602 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9603 GNU General Public License for more details.
9604
9605 You should have received a copy of the GNU General Public License
9606 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.