Fix bugs in file timestamp newness comparisons.
[bpt/emacs.git] / src / ChangeLog
1 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix bugs in file timestamp newness comparisons.
4 * fileio.c (Ffile_newer_than_file_p):
5 * lread.c (Fload): Use full timestamp resolution of files,
6 not just the 1-second resolution, so that files that are only
7 slightly newer still count as newer.
8 * fileio.c (Ffile_newer_than_file_p): Don't assume file
9 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
10
11 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
12
13
14 * fileio.c: Improve handling of file time marker. (Bug#11852)
15 (special_mtime): New function.
16 (Finsert_file_contents, Fverify_visited_file_modtime):
17 Use it to set special mtime values consistently.
18
19 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
20
21 * fileio.c (Finsert_file_contents): Properly handle st_mtime
22 marker for non-existing file. (Bug#11852)
23
24 2012-07-03 Glenn Morris <rgm@gnu.org>
25
26 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
27 and did not make it into globals.h).
28
29 2012-07-03 Tom Tromey <tromey@redhat.com>
30
31 * window.c (Fset_window_margins, Fset_window_fringes)
32 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
33 * textprop.c (Fprevious_property_change): No longer static.
34 * syntax.c (Fsyntax_table_p): No longer static.
35 * process.c (Fget_process, Fprocess_datagram_address): No longer
36 static.
37 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
38 * keyboard.c (Fcommand_execute): No longer static.
39 Remove EXFUN.
40 * insdel.c (Fcombine_after_change_execute): No longer static.
41 * image.c (Finit_image_library): No longer static.
42 * fileio.c (Fmake_symbolic_link): No longer static.
43 * eval.c (Ffetch_bytecode): No longer static.
44 * editfns.c (Fuser_full_name): No longer static.
45 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
46 longer static.
47 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
48 static.
49 * dired.c (Ffile_attributes): No longer static.
50 * composite.c (Fcomposition_get_gstring): No longer static.
51 * callproc.c (Fgetenv_internal): No longer static.
52
53 * ccl.h: Remove EXFUNs.
54 * buffer.h: Remove EXFUNs.
55 * dispextern.h: Remove EXFUNs.
56 * intervals.h: Remove EXFUNs.
57 * fontset.h: Remove EXFUN.
58 * font.h: Remove EXFUNs.
59 * dosfns.c (system_process_attributes): Remove EXFUN.
60 * keymap.h: Remove EXFUNs.
61 * lisp.h: Remove EXFUNs.
62 * w32term.h: Remove EXFUNs.
63 * window.h: Remove EXFUNs.
64 * xsettings.h: Remove EXFUN.
65 * xterm.h: Remove EXFUN.
66
67 2012-07-03 Glenn Morris <rgm@gnu.org>
68
69 * lisp.h (Frandom): Make it visible to C.
70 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
71 buffer for invisible buffers. (Bug#1229)
72
73 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
76 values which aren't power of 2.
77 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
78 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
79 accordingly.
80
81 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
82
83 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
84
85 * alloc.c (mark_object): Revert part of last patch to use `switch'.
86
87 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
88
89 * alloc.c (allocate_vector_block): Remove redundant
90 calls to mallopt if DOUG_LEA_MALLOC is defined.
91 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
92 avoid calls to mallopt if zero_vector is returned.
93
94 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
95
96 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
97 is enabled, avoid dereferencing NULL current_sblock if
98 running undumped.
99
100 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
101
102 Cleanup basic buffer management.
103 * buffer.h (struct buffer): Change layout to use generic vector
104 marking code. Fix some comments. Change type of 'clip_changed'
105 to bitfield. Remove unused #ifndef old.
106 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
107 (GET_OVERLAYS_AT): Fix indentation.
108 (for_each_per_buffer_object_at): New macro.
109 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
110 (Fbuffer_local_variables): Use it.
111 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
112 * alloc.c (allocate_buffer): Adjust to match new layout of
113 struct buffer. Fix comment.
114 (mark_overlay): New function.
115 (mark_buffer): Use it. Use mark_vectorlike to mark normal
116 Lisp area of struct buffer.
117 (mark_object): Use it. Adjust marking of misc objects
118 and related comments.
119
120 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
121
122 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
123 wrapper that is not needed because the wrapped code is a no-op (zero
124 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
125 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
126
127 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
128
129 * alloc.c (mark_buffer): Simplify. Remove prototype.
130 (mark_object): Add comment. Reorganize marking of vector-like
131 objects. Use CHECK_LIVE for all vector-like objects except buffers
132 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
133 redundant calls to mark_vectorlike for bool vectors.
134
135 2012-06-30 Glenn Morris <rgm@gnu.org>
136
137 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
138
139 * epaths.in (PATH_SITELOADSEARCH): New.
140 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
141 This is rather than relying on --enable-locallisppath elements
142 having "site-lisp" in their names. (Bug#10208#25, 11658)
143
144 2012-06-30 Eli Zaretskii <eliz@gnu.org>
145
146 * w32proc.c (sys_select): Accept and ignore one more argument.
147
148 * w32.c (emacs_gnutls_pull): Call select with one more argument.
149
150 * sysselect.h [DOS_NT]: Don't include sys/select.h.
151 (pselect) [!MS_DOS]: Redirect to sys_select.
152
153 * sysdep.c: Don't include dos.h and dosfns.h.
154
155 * process.c (sys_select):
156 * msdos.c (sys_select): Accept one more argument and ignore it.
157
158 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
159 adapt data types and code to that.
160
161 * dosfns.c:
162 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
163 which clashes with the gnulib function of the same name.
164
165 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
166
167 * font.c (font_style_to_value, font_style_symbolic)
168 (font_prop_validate_style): Add type checks for values in
169 font_style_table.
170
171 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
172 argument.
173 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
174 uses.
175
176 2012-06-29 Eli Zaretskii <eliz@gnu.org>
177
178 * xdisp.c (try_window_id): Undo last change.
179
180 * w32.c (getwd): Adjust commentary about startup_dir.
181 (init_environment): Always call sys_access, even in non-MSVC
182 builds. Don't chdir to the directory of the Emacs executable.
183 This undoes code from 1997 which was justified by the need to
184 "avoid conflicts when removing and renaming directories". But its
185 downside was that every relative file name was being interpreted
186 relative to the directory of the Emacs executable, which can never
187 be TRT. In particular, it broke sys_access when called with
188 relative file names.
189 (sys_access): Map GetLastError to errno.
190
191 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
192
193 * window.h (struct window): Change type of 'fringes_outside_margins'
194 to bitfield. Fix comment. Adjust users accordingly.
195 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
196 Adjust comment.
197 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
198 to ptrdiff_t.
199
200 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
201
202 * gnutls.c (emacs_gnutls_handshake):
203 Add QUIT to make the loop interruptible.
204
205 2012-06-29 Glenn Morris <rgm@gnu.org>
206
207 * charset.c (init_charset): Make lack of etc/charsets fatal.
208
209 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
210
211 * editfns.c (region_limit): Fix type mismatch.
212
213 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
214
215 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
216 undefined. Convert from xassert to eassert.
217 * nsmenu.m: Convert from xassert to eassert.
218 * nsterm.m: Likewise.
219
220 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
221
222 * editfns.c (region_limit): Clip to narrowing (bug#11770).
223
224 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
225
226 Avoid integer overflow on scroll-left and scroll-right.
227 * window.c (HSCROLL_MAX): New macro.
228 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
229 overflow when requested scroll falls outside ptrdiff_t range.
230
231 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
232
233 * window.h (struct window): Change type of 'hscroll',
234 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
235 'last_modified' and 'last_overlay_modified' to EMACS_INT.
236 Adjust users accordingly.
237 * xdisp.c (try_cursor_movement): Replace type check with eassert.
238 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
239 from EMACS_INT to ptrdiff_t.
240 (make_window): Omit redundant initialization.
241
242 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
243
244 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
245
246 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
247
248 * window.h (struct window): Change type of 'use_time' and
249 'sequence_number' from Lisp_Object to int.
250 * frame.c (make_frame): Adjust users accordingly.
251 * print.c (print_object): Likewise.
252 * window.c (select_window, Fwindow_use_time, make_parent_window)
253 (make_window): Likewise.
254
255 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
256
257 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
258 enabled with --enable-checking=[all,glyphs] configure option.
259 Fix GLYPH_DEBUG usage assuming that it may be undefined,
260 adjust comments accordingly.
261 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
262 undefined, adjust comments accordingly.
263 * image.c: Likewise.
264 * scroll.c: Likewise.
265 * w32fns.c: Likewise.
266 * w32term.c: Likewise.
267 * xdisp.c: Likewise.
268 * xfaces.c: Likewise.
269 * xfns.c: Likewise.
270 * xterm.c: Likewise.
271
272 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
273
274 Generalize run-time debugging checks.
275 * dispextern.h (XASSERTS): Remove.
276 * fontset.c (xassert): Remove.
277 Convert from xassert to eassert.
278 * alloc.c: Convert from xassert to eassert.
279 * bidi.c: Likewise.
280 * dispnew.c: Likewise.
281 * fns.c: Likewise.
282 * fringe.c: Likewise.
283 * ftfont.c: Likewise.
284 * gtkutil.c: Likewise.
285 * image.c: Likewise.
286 * keyboard.c: Likewise.
287 * menu.c: Likewise.
288 * process.c: Likewise.
289 * scroll.c: Likewise.
290 * sound.c: Likewise.
291 * term.c: Likewise.
292 * w32console.c: Likewise.
293 * w32fns.c: Likewise.
294 * w32term.c: Likewise.
295 * window.c: Likewise.
296 * xdisp.c: Likewise.
297 * xfaces.c: Likewise.
298 * xfns.c: Likewise.
299 * xselect.c: Likewise.
300 * xterm.c: Likewise.
301
302 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
303
304 * fns.c (maybe_resize_hash_table): Output message when growing the
305 purify-hashtable.
306
307 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
308
309 * alloc.c (allocate_string_data): Remove dead code.
310 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
311 avoid GCC warning about unused macro.
312
313 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
314
315 * alloc.c (allocate_string): Omit intervals initialization.
316 * alloc.c (make_uninit_multibyte_string): Initialize intervals
317 as in make_pure_string and make_pure_c_string.
318
319 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
320
321 * alloc.c (allocate_string): Fix last change.
322
323 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
324
325 * alloc.c (allocate_string): Remove two redundant calls
326 to memset, add explicit initialization where appropriate.
327
328 2012-06-27 Glenn Morris <rgm@gnu.org>
329
330 * lisp.mk (lisp): Remove paths.elc.
331
332 2012-06-27 Chong Yidong <cyd@gnu.org>
333
334 * doc.c (Fsubstitute_command_keys): Fix punctuation.
335
336 2012-06-26 John Wiegley <johnw@newartisans.com>
337
338 * unexmacosx.c (copy_data_segment): Add two section names used
339 on Mac OS X Lion: __mod_init_func and __mod_term_func.
340
341 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
342 when building with Clang.
343
344 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
345
346 * eval.c (Fapply): Allow calling it with a single argument.
347
348 2012-06-26 Eli Zaretskii <eliz@gnu.org>
349
350 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
351 _stricmp and _strnicmp.
352 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
353
354 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
355
356 * alloc.c (allocate_window): Zero out non-Lisp part of newly
357 allocated window.
358 (allocate_process): Likewise for new process.
359 (allocate_terminal): Change to use offsetof.
360 (allocate_frame): Likewise.
361 * frame.c (make_frame): Omit redundant initialization.
362 * window.c (make_parent_window): Use memset.
363 (make_window): Omit redundant initialization.
364 * process.c (make_process): Omit redundant initialization.
365 * terminal.c (create_terminal): Likewise.
366
367 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
368
369 * term.c (delete_tty): Remove redundant call to memset.
370
371 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
372
373 * alloc.c: Remove build_string.
374 * lisp.h: Define build_string as static inline. This provides
375 a better opportunity to optimize away calls to strlen when the
376 function is called with compile-time constant argument.
377 * image.c (imagemagick_error): Convert to build_string.
378 * w32proc.c (sys_spawnve): Likewise.
379 * xterm.c (x_term_init): Likewise.
380
381 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
382
383 Use sprintf return value instead of invoking strlen on result.
384 In the old days this wasn't portable, since some sprintf
385 implementations returned char *. But they died out years ago and
386 Emacs already assumes sprintf returns int.
387 Similarly for float_to_string.
388 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
389 * ccl.c (ccl_driver):
390 * character.c (string_escape_byte8):
391 * data.c (Fnumber_to_string):
392 * doprnt.c (doprnt):
393 * print.c (print_object):
394 * xdisp.c (message_dolog):
395 * xfns.c (syms_of_xfns):
396 Use sprintf or float_to_string result to avoid need to call strlen.
397 * data.c (Fnumber_to_string):
398 Use make_unibyte_string, since the string must be ASCII.
399 * lisp.h, print.c (float_to_string): Now returns int length.
400 * term.c (produce_glyphless_glyph):
401 Use sprintf result rather than recomputing it.
402
403 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
404 * Makefile.in (ALL_CFLAGS):
405 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
406 * gmalloc.c, regex.c: Include <config.h> unconditionally.
407
408 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
409
410 * dispextern.h (xstrcasecmp): Define to library function
411 strcasecmp if available.
412 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
413
414 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
415
416 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
417 Avoid comma operator.
418 * menu.c (push_submenu_start, push_submenu_end)
419 (push_left_right_boundary, push_menu_pane): Likewise.
420 * msdos.c (dos_rawgetc): Likewise.
421
422 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
423
424 * xfns.c (xic_create_fontsetname): Remove redundant calls
425 to memset.
426
427 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
428
429 * gtkutil.c (get_utf8_string): Remove redundant assignment.
430 sprintf already null-terminates its output.
431
432 * xfns.c (x_window): Remove redundant cast.
433
434 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
435
436 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
437 `const char *' to `char *' to avoid compiler warning.
438
439 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
440
441 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
442 instead of truncating it to 63 (admittedly a generous limit).
443
444 * process.c: Fix spelling and caps in comments.
445
446 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
447
448 * emacs.c (setpgrp): Remove definition, unused.
449 * sysdep.c (setpgrp): Remove definition, not used in this file.
450
451 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
452
453 * makefile.w32-in: Update dependencies.
454
455 2012-06-24 Eli Zaretskii <eliz@gnu.org>
456
457 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
458 (SYSTIME_H): Add nt/inc/sys/time.h.
459
460 * systime.h [WINDOWSNT]: Include sys/time.h.
461
462 * s/ms-w32.h (struct timespec): Definition moved from
463 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
464
465 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
466
467 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
468 * buffer.h (buffer_slot_type_mismatch):
469 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
470 * eval.c (unwind_to_catch):
471 * image.c (my_png_error, my_error_exit):
472 * keyboard.c (quit_throw_to_read_char, user_error)
473 (Fexit_recursive_edit, Fabort_recursive_edit):
474 * lisp.h (die, args_out_of_range, args_out_of_range_3)
475 (wrong_type_argument, buffer_overflow, __executable_start)
476 (memory_full, buffer_memory_full, string_overflow, Fthrow)
477 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
478 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
479 (fatal):
480 (child_setup) [!DOS_NT]:
481 * lread.c (end_of_file_error, invalid_syntax):
482 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
483 * puresize.h (pure_write_error):
484 * search.c (matcher_overflow):
485 * sound.c (sound_perror, alsa_sound_perror):
486 * sysdep.c, syssignal.h (croak):
487 * term.c (maybe_fatal, vfatal):
488 * textprop.c (text_read_only):
489 * undo.c (user_error):
490 * unexmacosx.c (unexec_error):
491 * xterm.c (x_ins_del_lines, x_delete_glyphs):
492 Use _Noreturn rather than NO_RETURN.
493 No need for separate decl merely because of _Noreturn.
494 * sound.c (sound_warning, parse_sound):
495 Remove unnecessary forward decls.
496
497 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
498
499 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
500 * lisp.h (WAIT_READING_MAX): New macro.
501 * dispnew.c (Fsleep_for, sit_for):
502 * keyboard.c (kbd_buffer_get_event):
503 * process.c (Faccept_process_output):
504 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
505 This improves on the previous patch, which introduced a bug
506 when time_t is unsigned and as wide as intmax_t.
507 See <http://bugs.gnu.org/9000#51>.
508
509 2012-06-23 Eli Zaretskii <eliz@gnu.org>
510
511 * dispnew.c (sit_for, Fsleep_for):
512 * keyboard.c (kbd_buffer_get_event):
513 * process.c (Faccept_process_output): Avoid compiler warnings when
514 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
515
516 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
517
518 * makefile.w32-in: Update dependencies.
519
520 * w32.c (ltime): Add return type and declare static.
521 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
522
523 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
524
525 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
526 Privately reported by Herbert J. Skuhra.
527 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
528 All uses changed.
529 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
530 not make_lisp_timeval, when the argument is of type EMACS_TIME.
531
532 2012-06-23 Eli Zaretskii <eliz@gnu.org>
533
534 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
535 last argument of make_unibyte_string.
536
537 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
538 language ID in the event parameters.
539
540 * w32term.c (w32_read_socket): Put the new keyboard codepage into
541 event.code, not the obscure "character set ID".
542
543 2012-06-23 Chong Yidong <cyd@gnu.org>
544
545 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
546
547 2012-06-23 Eli Zaretskii <eliz@gnu.org>
548
549 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
550 * w32.c (fdutimens): New function.
551
552 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
553
554 * s/ms-w32.h (pselect): Redirect to sys_select.
555
556 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
557
558 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
559 in the logic of incrementing and decrementing the value of
560 use_relocatable_buffers.
561
562 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
563
564 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
565 Privately reported by Herbert J. Skuhra.
566 [__FreeBSD__]: Remove "*/" typo after "#include".
567 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
568 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
569 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
570 Don't assume EMACS_TIME and struct timeval are the same type.
571
572 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
573
574 Support higher-resolution time stamps (Bug#9000).
575 The time stamps are only nanosecond-resolution at the C level,
576 since that's the best that any real-world system supports now.
577 But they are picosecond-resolution at the Lisp level, as that's
578 easy, and leaves room for future OS improvements.
579
580 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
581 (LIBES): Use it.
582
583 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
584 Don't get current time unless it's needed.
585
586 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
587 now provides it if it's absent.
588 (start_atimer): Port to higher-res time stamps.
589 Check for time stamp overflow. Don't get current time more
590 often than is needed.
591
592 * buffer.h (struct buffer): Buffer modtime now has high resolution.
593 Include systime.h, not time.h.
594 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
595
596 * dired.c: Include stat-time.h.
597 (Ffile-attributes): File times now have higher resolution.
598
599 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
600 (struct image): Timestamp now has higher resolution.
601
602 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
603 has at least microseconds now. All uses removed.
604 (update_frame, update_single_window, update_window, update_frame_1)
605 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
606
607 * editfns.c (time_overflow): Now extern.
608 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
609 (float-time, Fformat_time_string, Fcurrent_time_string)
610 (Fcurrent_time_zone): Accept and generate higher-resolution
611 time stamps.
612 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
613 (decode_time_components, lisp_seconds_argument): New functions.
614 (make_time): Now static.
615 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
616 Report an error if the time is invalid, rather than having the caller
617 do that.
618
619 * fileio.c: Include <stat-time.h>
620 (Fcopy_file): Copy higher-resolution time stamps.
621 Prefer to set the time stamp via a file descriptor if that works.
622 (Fset_file_times, Finsert_file_contents, Fwrite_region)
623 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
624 (Fvisited_file_modtime, Fset_visited_file_modtime):
625 Support higher-resolution time stamps.
626
627 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
628
629 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
630
631 * image.c (prepare_image_for_display, clear_image_cache)
632 (lookup_image): Port to higer-resolution time stamps.
633
634 * keyboard.c (start_polling, bind_polling_period):
635 Check for time stamp overflow.
636 (read_char, kbd_buffer_get_event, timer_start_idle)
637 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
638 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
639 Port to higher-resolution time stamps. Do not assume time_t is signed.
640 (decode_timer): New function. Timers are now vectors of length 9,
641 not 8, to accommodate the picosecond component.
642 (timer_check_2): Use it.
643
644 * nsterm.m (select_timeout, timeval_subtract): Remove.
645 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
646 as they're a bit more accurate and handle overflow better.
647 (ns_select): Change prototype to be compatible with pselect.
648 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
649 * nsterm.h (ns_select): Adjust prototype.
650
651 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
652 us-resolution time stamps.
653 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
654
655 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
656
657 * lisp.h (time_overflow): New decl.
658 (wait_reading_process_output): First arg is now intmax_t, not int,
659 to accommodate larger waits.
660
661 * process.h (struct Lisp_Process.read_output_delay):
662 Now counts nanoseconds, not microseconds.
663 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
664 EMACS_HAS_USECS.
665 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
666 (wait_reading_process_output):
667 Port to ns-resolution time stamps.
668 (Faccept_process_output, wait_reading_process_output):
669 Check for time stamp overflow. Do not assume time_t is signed.
670 (select_wrapper): Remove; we now use pselect.
671 (Fprocess_attributes): Now generates ns-resolution time stamps.
672
673 * sysdep.c: Include utimens.h. Don't include utime.h
674 or worry about struct utimbuf; gnulib does that for us now.
675 (gettimeofday): Remove; gnulib provides a substitute.
676 (make_timeval): New function.
677 (set_file_times): Now sets ns-resolution time stamps.
678 New arg FD; all uses changed.
679 (time_from_jiffies, ltime_from_jiffies, get_up_time)
680 (system_process_attributes):
681 Now returns ns-resolution time stamp. All uses changed.
682 Check for time stamp overflow.
683
684 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
685 provides a substitute now.
686
687 * systime.h: Include timespec.h rather than sys/time.h and time.h,
688 since it guarantees struct timespec.
689 (EMACS_TIME): Now struct timespec, so that we can support
690 ns-resolution time stamps.
691 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
692 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
693 (EMACS_USECS): Remove.
694 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
695 so multiply the arg by 1000 before storing it.
696 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
697 New macros.
698 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
699 Port to ns-resolution time stamps.
700 (EMACS_TIME_NEG_P): Remove; replaced by....
701 (EMACS_TIME_SIGN): New macro.
702 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
703 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
704 (set_file_times, make_time, lisp_time_argument): Adjust signature.
705 (make_timeval, make_lisp_time, decode_time_components): New decls.
706 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
707 that it mishandled time_t overflow. You can't compare by subtracting!
708 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
709 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
710
711 * term.c: Include <sys/time.h>.
712 (timeval_to_Time): New function, for proper overflow wraparound.
713 (term_mouse_position, term_mouse_click): Use it.
714
715 * undo.c (record_first_change): Support higher-resolution time stamps
716 in the undo buffer.
717 (Fprimitive_undo): Use them when restoring time stamps.
718
719 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
720 (w32_get_internal_run_time):
721 Port to higher-resolution Emacs time stamps.
722 (ltime): Now accepts single 64-bit integer, as that's more convenient
723 for callers.
724
725 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
726
727 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
728 for compatibility with pselect. Support ns-resolution time stamps.
729
730 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
731
732 * xselect.c (wait_for_property_change, x_get_foreign_selection):
733 Check for time stamp overflow, and support ns-resolution time stamps.
734
735 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
736 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
737 (timeval_subtract): Remove; no longer needed.
738 (XTflash, XTring_bell, x_wait_for_event):
739 Port to ns-resolution time stamps. Don't assume time_t is signed.
740
741 2012-06-22 Chong Yidong <cyd@gnu.org>
742
743 * xdisp.c (x_consider_frame_title): Revert last change.
744
745 2012-06-22 Eli Zaretskii <eliz@gnu.org>
746
747 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
748 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
749 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
750 staticidx goes up to 1597 out of 1600 = 0x640.)
751
752 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
753
754 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
755 Otherwise, the umask might be mistakenly 0 while handling input signals.
756
757 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
758
759 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
760
761 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
762
763 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
764 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
765 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
766 access to `contents' member of Lisp_Vector objects with AREF and ASET
767 where appropriate.
768
769 2012-06-19 Chong Yidong <cyd@gnu.org>
770
771 * frame.c (delete_frame): When selecting a frame on a different
772 text terminal, do not alter the terminal's top-frame.
773
774 * xdisp.c (format_mode_line_unwind_data): Record the target
775 frame's selected window and its terminal's top-frame.
776 (unwind_format_mode_line): Restore them.
777 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
778 Callers changed.
779 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
780 since tty frames can be explicitly named.
781 (prepare_menu_bars): Likewise.
782
783 * term.c (Ftty_top_frame): New function.
784
785 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
786
787 Port byte-code-meter to modern targets.
788 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
789 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
790 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
791 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
792 (METER_1, METER_2): Simplify.
793
794 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
795
796 * data.c (Fdefalias): Return `symbol' (bug#11686).
797
798 2012-06-18 Martin Rudalics <rudalics@gmx.at>
799
800 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
801 gets killed during executing of this function (Bug#11665).
802 Try to always return Qt when the buffer has been actually killed.
803 (Vkill_buffer_query_functions): In doc-string say that functions
804 run by this hook should not change the current buffer.
805
806 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
807
808 Fix recently-introduced process.c problems found by static checking.
809 * process.c (write_queue_push, write_queue_pop, send_process):
810 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
811 (write_queue_pop): Fix pointer signedness problem.
812 (send_process): Remove unused local.
813
814 2012-06-17 Chong Yidong <cyd@gnu.org>
815
816 * xdisp.c (redisplay_internal): No need to redisplay terminal
817 frames that are not on top.
818
819 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
820
821 * process.c (make_process): Initialize write_queue.
822 (write_queue_push, write_queue_pop): New functions.
823 (send_process): Use them to maintain correct ordering of process
824 writes (Bug#10815).
825
826 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
827
828 * lisp.h (eassert): Assume C89 or later.
829 This removes the need for CHECK.
830 (CHECK): Remove. Its comments about always evaluating its
831 argument were confusing, as 'eassert' typically does not evaluate
832 its argument.
833
834 * coding.c (produce_chars): Use ptrdiff_t, not int.
835
836 * xterm.c (x_draw_underwave): Check for integer overflow.
837 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
838
839 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
840
841 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
842 referenced (Bug#11583).
843
844 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
845
846 Implement wave-style variant of underlining.
847 * dispextern.h (face_underline_type): New enum.
848 (face): Add field for underline type.
849 * nsterm.m (ns_draw_underwave): New function.
850 (ns_draw_text_decoration): Use it.
851 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
852 New functions.
853 (x_draw_glyph_string): Use them.
854 * xfaces.c (Qline, Qwave): New Lisp objects.
855 (check_lface_attrs, merge_face_ref)
856 (Finternal_set_lisp_face_attribute, realize_x_face):
857 Handle wave-style underline face attributes.
858 * xterm.c (x_draw_underwave): New function.
859 (x_draw_glyph_string): Use it.
860
861 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
862
863 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
864 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
865 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
866 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
867 ($(BLD)/w32select.$(O)): Update dependencies.
868
869 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
870
871 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
872 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
873 * character.c (_fetch_multibyte_char_p): Remove.
874 * alloc.c: Include "character.h" before "buffer.h".
875 * bidi.c: Likewise.
876 * buffer.c: Likewise.
877 * bytecode.c: Likewise.
878 * callint.c: Likewise.
879 * callproc.c: Likewise.
880 * casefiddle.c: Likewise.
881 * casetab.c: Likewise.
882 * category.c: Likewise.
883 * cmds.c: Likewise.
884 * coding.c: Likewise.
885 * composite.c: Likewise.
886 * dired.c: Likewise.
887 * dispnew.c: Likewise.
888 * doc.c: Likewise.
889 * dosfns.c: Likewise.
890 * editfns.c: Likewise.
891 * emacs.c: Likewise.
892 * fileio.c: Likewise.
893 * filelock.c: Likewise.
894 * font.c: Likewise.
895 * fontset.c: Likewise.
896 * fringe.c: Likewise.
897 * indent.c: Likewise.
898 * insdel.c: Likewise.
899 * intervals.c: Likewise.
900 * keyboard.c: Likewise.
901 * keymap.c: Likewise.
902 * lread.c: Likewise.
903 * macros.c: Likewise.
904 * marker.c: Likewise.
905 * minibuf.c: Likewise.
906 * nsfns.m: Likewise.
907 * nsmenu.m: Likewise.
908 * print.c: Likewise.
909 * process.c: Likewise.
910 * regex.c: Likewise.
911 * region-cache.c: Likewise.
912 * search.c: Likewise.
913 * syntax.c: Likewise.
914 * term.c: Likewise.
915 * textprop.c: Likewise.
916 * undo.c: Likewise.
917 * unexsol.c: Likewise.
918 * w16select.c: Likewise.
919 * w32fns.c: Likewise.
920 * w32menu.c: Likewise.
921 * window.c: Likewise.
922 * xdisp.c: Likewise.
923 * xfns.c: Likewise.
924 * xmenu.c: Likewise.
925 * xml.c: Likewise.
926 * xselect.c: Likewise.
927
928 2012-06-16 Eli Zaretskii <eliz@gnu.org>
929
930 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
931 If all the glyphs of the glyph row came from strings, and we have no
932 cursor positioning clues, put the cursor on the first glyph of the
933 row.
934 (handle_face_prop): Use chunk-relative overlay string index when
935 indexing into it->string_overlays array. (Bug#11653)
936 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
937 the rightmost. (Bug#11720)
938
939 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
940
941 * category.h (CHAR_HAS_CATEGORY): Define as inline.
942 (CATEGORY_MEMBER): Enforce 1/0 value.
943 * category.c (_temp_category_set): Remove.
944
945 2012-06-16 Eli Zaretskii <eliz@gnu.org>
946
947 * window.c (Fdelete_other_windows_internal)
948 (Fdelete_window_internal): Don't access frame's mouse highlight
949 info of the initial frame. (Bug#11677)
950
951 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
952
953 * .gdbinit (xgetint): Fix recently-introduced paren typo.
954 Assume USE_2_TAGS_FOR_INTS.
955 (xreload): Adjust $tagmask width to match recent lisp.h change.
956
957 Simplify lisp.h in minor ways that should not affect code.
958 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
959 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
960 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
961 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
962 (INTTYPEBITS): New macro, for clarity.
963 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
964 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
965 Simplify now that USE_LSB_TAG is always defined.
966 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
967 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
968
969 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
970
971 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
972
973 2012-06-13 Glenn Morris <rgm@gnu.org>
974
975 * s/bsd-common.h (BSD4_3):
976 * s/usg5-4-common.h (USG5_4): No longer define; unused.
977
978 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
979
980 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
981 instead of union.
982 (XLI, XIL): Define.
983 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
984 Use them.
985 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
986 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
987 * alloc.c (widen_to_Lisp_Object): Remove.
988 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
989 * frame.c (delete_frame): Remove outdated comment.
990 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
991 USE_LISP_UNION_TYPE.
992 (Fw32_unregister_hot_key): Likewise.
993 (Fw32_toggle_lock_key): Likewise.
994 * w32menu.c (add_menu_item): Likewise.
995 (w32_menu_display_help): Use XIL instead of checking
996 USE_LISP_UNION_TYPE.
997 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
998 (init_heap): Likewise.
999 * w32term.c (w32_read_socket): Update comment.
1000
1001 2012-06-13 Glenn Morris <rgm@gnu.org>
1002
1003 * s/usg5-4-common.h, src/s/unixware.h:
1004 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1005
1006 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1007
1008 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1011 * alloc.c (make_number) [!defined make_number]:
1012 Remove, as lisp.h always defines this now.
1013 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1014 (roundup_size): Verify that it is a power of 2.
1015 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1016 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1017 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1018 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1019 USE_LSB_TAG now is always defined to be either 0 or 1.
1020 All uses changed.
1021 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1022 code works fine either way, and efficiency is not a concern here,
1023 as the union type is for debugging, not for production.
1024 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1025 Use an inline function on all platforms when using the union type,
1026 since this is simpler and 'static inline' can be used portably
1027 within Emacs now.
1028 (LISP_INITIALLY_ZERO): New macro.
1029 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1030 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1031
1032 2012-06-12 Glenn Morris <rgm@gnu.org>
1033
1034 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1035
1036 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1037
1038 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1039 Move BROKEN_SIGIO to configure.
1040
1041 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1042 Move NO_TERMIO to configure.
1043
1044 2012-06-12 Chong Yidong <cyd@gnu.org>
1045
1046 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1047 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1048 MagickExportImagePixels is undefined.
1049
1050 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 * image.c (imagemagick_load_image): Remove unused label.
1053
1054 2012-06-11 Glenn Morris <rgm@gnu.org>
1055
1056 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1057 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1058 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1059 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1060
1061 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1062
1063 * alloc.c (make_byte_code): New function.
1064 (Fmake_byte_code): Use it. Don't purify here.
1065 * lread.c (read1): Use it as well to avoid extra allocation.
1066
1067 2012-06-11 Chong Yidong <cyd@gnu.org>
1068
1069 * image.c (imagemagick_load_image): Implement transparency.
1070
1071 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1072
1073 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1074 account for preceding backslashes. (Bug#11663)
1075
1076 2012-06-09 Chong Yidong <cyd@gnu.org>
1077
1078 * term.c: Support italics in capable terminals (Bug#9652).
1079 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1080 (turn_on_face): Output using TS_enter_italic_mode if available.
1081 Don't handle unused blinking and alt-charset cases.
1082 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1083 and tty_alt_charset_p cases.
1084 (tty_capable_p, init_tty): Support italics.
1085
1086 * termchar.h (struct tty_display_info): Add field for italics.
1087 Remove unused blink field.
1088
1089 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1090 Handle slant.
1091
1092 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1093 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1094 tty_alt_charset_p. Add tty_italic_p.
1095
1096 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1097
1098 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1099 dbus_type_is_basic if available.
1100 (xd_extract_signed, xd_extract_unsigned): Rename from
1101 extract_signed and extract_unsigned, respectively. Adapt callers.
1102
1103 2012-06-09 Chong Yidong <cyd@gnu.org>
1104
1105 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1106
1107 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1108 case (Bug#9752).
1109
1110 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1111
1112 * xdisp.c (vmessage): Treat frame message as multibyte.
1113 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1114 would generate the diagnostic "Making \302\247 buffer-local while
1115 let-bound!".
1116
1117 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1118
1119 * dispnew.c (showing_window_margins_p): Undo last change, which
1120 was done due to an inadvertent commit.
1121 (adjust_frame_glyphs_for_frame_redisplay): Do call
1122 showing_window_margins_p.
1123
1124 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1125
1126 * eval.c (Fmake_var_non_special): New primitive.
1127 (syms_of_eval): Defsubr it.
1128 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1129
1130 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1131
1132 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1133 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1134
1135 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1136
1137 * alloc.c (allocate_vectorlike): Fix last change.
1138
1139 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 Block-based vector allocation of small vectors.
1142 * lisp.h (struct vectorlike_header): New field `nbytes',
1143 adjust comment accordingly.
1144 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1145 to denote vector blocks. Adjust users (live_vector_p,
1146 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1147 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1148 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1149 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1150 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1151 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1152 (roundup_size): New constant.
1153 (struct vector_block): New data type.
1154 (vector_blocks, vector_free_lists, zero_vector): New variables.
1155 (all_vectors): Rename to `large_vectors'.
1156 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1157 (sweep_vectors): New functions.
1158 (allocate_vectorlike): Return `zero_vector' as the only vector of
1159 0 items. Allocate new vector from block if vector size is less than
1160 or equal to VBLOCK_BYTES_MAX.
1161 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1162 (init_alloc_once): Add call to init_vectors.
1163
1164 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1165
1166 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1167
1168 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * doprnt.c (doprnt): Truncate multibyte char correctly.
1171 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1172 would mishandle a string argument "Xc" if X was a multibyte
1173 character of length 2: it would truncate after X's first byte
1174 rather than including all of X.
1175
1176 2012-06-06 Chong Yidong <cyd@gnu.org>
1177
1178 * buffer.c (word_wrap): Doc fix.
1179
1180 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1183
1184 2012-06-03 Glenn Morris <rgm@gnu.org>
1185
1186 * xdisp.c (tool-bar-style): Doc fix.
1187
1188 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1189
1190 * Makefile.in (PAXCTL): Define.
1191 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1192 binary via PaX flags if the paxctl utility is available.
1193 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1194 Restore PaX flags to their default. (Bug#11398)
1195
1196 2012-06-03 Chong Yidong <cyd@gnu.org>
1197
1198 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1199 buffer (Bug#11226).
1200
1201 2012-06-03 Chong Yidong <cyd@gnu.org>
1202
1203 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1204 (note_mode_line_or_margin_highlight): If there is no help echo,
1205 use mode-line-default-help-echo. Handle the case where the mouse
1206 position is past the end of the mode line string.
1207
1208 * buffer.c (buffer_local_value_1): New function, split from
1209 Fbuffer_local_value; can return Qunbound.
1210 (Fbuffer_local_value): Use it.
1211 (Vmode_line_format): Docstring tweaks.
1212
1213 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1214
1215 * sysdep.c (system_process_attributes): Improve comment.
1216
1217 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1218
1219 * keyboard.c: Export real-this-command to Elisp.
1220 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1221 and DEFVAR it. Update all users.
1222
1223 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1226
1227 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1228 Convert pctcpu and pctmem to Lisp float properly.
1229 Let the compiler fold better, as 100.0/0x8000 is exact.
1230
1231 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1232
1233 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1234 cons_block.
1235
1236 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1239
1240 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1241
1242 For a 'struct window', replace some Lisp_Object fields to
1243 bitfields where appropriate, remove unused fields.
1244 * window.h (struct window): Remove unused 'last_mark_x' and
1245 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1246 change it's type from Lisp_Object to bitfield.
1247 Change type of 'force_start', 'optional_new_start',
1248 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1249 fields from Lisp_Object to bitfield. Adjust users accordingly.
1250
1251 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 Pacify gcc -Wdouble-precision when using Xaw.
1254 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1255 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1256 Use 'float' consistently, rather than 'float' in most places
1257 and 'double' in a couple of places.
1258
1259 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1260
1261 * xdisp.c (handle_stop): Detect whether we have overlay strings
1262 loaded by testing it->current.overlay_string_index to be
1263 non-negative, instead of checking whether n_overlay_strings is
1264 positive. (Bug#11587)
1265
1266 2012-05-31 Chong Yidong <cyd@gnu.org>
1267
1268 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1269
1270 * doc.c (Fsubstitute_command_keys): Doc fix.
1271
1272 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1273
1274 * search.c (search_buffer): Remove calls to
1275 r_alloc_inhibit_buffer_relocation, as it is now called by
1276 maybe_unify_char, which was the cause of relocation of buffer text
1277 in bug#11519.
1278
1279 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1280
1281 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1282 for the duration of call to load_charset, to avoid problems with
1283 callers of maybe_unify_char that access buffer text through C
1284 pointers.
1285
1286 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1287 decrement the inhibition flag, instead of just setting or
1288 resetting it.
1289
1290 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 Remove obsolete '#define static' cruft.
1293 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1294 This #undef was "temporary" in 2000; it is no longer needed
1295 now that '#define static' has gone away.
1296 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1297 (gray_bitmap_bits): Remove; no longer needed.
1298 All uses replaced with definiens.
1299 * xterm.c: Include "bitmaps/gray.xbm".
1300
1301 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 Clean up __executable_start, monstartup when --enable-profiling.
1304 The following changes affect the code only when profiling.
1305 * dispnew.c (__executable_start): Rename from safe_bcopy.
1306 Define only on platforms that need it.
1307 * emacs.c: Include <sys/gmon.h> when profiling.
1308 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1309 (__executable_start): Remove decl, since lisp.h does it now.
1310 (safe_bcopy): Remove decl; no longer has that name.
1311 (main): Coalesce #if into single bit of code, for simplicity.
1312 Cast pointers to uintptr_t, since standard libraries want integers
1313 and not pointers.
1314 * lisp.h (__executable_start): New decl.
1315
1316 2012-05-31 Glenn Morris <rgm@gnu.org>
1317
1318 * image.c (Fimagemagick_types): Doc fix.
1319
1320 2012-05-30 Jim Meyering <meyering@redhat.com>
1321
1322 * callproc.c (Fcall_process_region): Include directory component
1323 in mkstemp error message (Bug#11586).
1324
1325 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 * alloc.c, lisp.h (make_pure_vector): Now static.
1328
1329 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1332 Move to byte-run.el.
1333 (Fautoload): Do the hash-doc more carefully.
1334 * data.c (Fdefalias): Purify definition, except for keymaps.
1335 (Qdefun): Move from eval.c.
1336 * lisp.h (Qdefun): Remove.
1337 * lread.c (read1): Tiny simplification.
1338
1339 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1340
1341 Do not create empty overlays with the evaporate property (Bug#9642).
1342 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1343 Bug#9642, but explicitly check that the buffer the overlay would
1344 be moved to is live and rearrange lines to make sure that errors
1345 will not put the overlay in an inconsistent state.
1346 (Fdelete_overlay): Cosmetics.
1347
1348 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1349
1350 * w32term.c (my_bring_window_to_top): New function.
1351 (x_raise_frame): Use handle returned by DeferWindowPos, which
1352 could be different from the original one.
1353 Call my_bring_window_to_top instead of my_set_foreground_window.
1354 (Bug#11513)
1355
1356 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1357 by calling BringWindowToTop.
1358
1359 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1360 (WM_EMACS_END): Increase by one.
1361
1362 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1365 This avoids undefined behavior that might cause the eassert
1366 to not catch an out-of-range value.
1367
1368 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1369
1370 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1371 Update dependencies.
1372
1373 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1374
1375 * bidi.c (bidi_mirror_char): Fix last change.
1376
1377 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1378
1379 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1380 when referring to sectname field in printf format.
1381
1382 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1385 Only r_alloc_inhibit_buffer_relocation needed to be added;
1386 the others were already declared.
1387
1388 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1389 before checking whether it's out of range. Put the check inside
1390 eassert. See
1391 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1392
1393 2012-05-27 Ken Brown <kbrown@cornell.edu>
1394
1395 * callproc.c (Fcall_process): Restore a line that was accidentally
1396 commented out in the 2011-02-13 change (bug#11547).
1397
1398 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1399
1400 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1401 defined on ralloc.c.
1402
1403 * buffer.c [REL_ALLOC]: Remove prototypes of
1404 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1405 they are now on lisp.h.
1406
1407 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1408
1409 * search.c (search_buffer): Use it to inhibit relocation of buffer
1410 text while re_search_2 is doing its job, because re_search_2 is
1411 passed C pointers to buffer text. (Bug#11519)
1412
1413 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1414 Update value to 24.
1415
1416 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1417 state after an additional call to move_it_in_display_line_to, keep
1418 the values of it->max_ascent and it->max_descent found for the
1419 entire line.
1420 (pos_visible_p): Revert the comparison against bottom_y to what it
1421 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1422 (Bug#11464)
1423
1424 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 Fix coding-related core dumps with gcc -ftrapv.
1427 The code was computing A - B, where A and B are pointers, and B is
1428 random garbage. This can lead to core dumps on platforms that
1429 have special pointer registers, and it also leads to core dumps on
1430 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1431 A - B only when B is initialized properly.
1432 * coding.c (coding_set_source, coding_set_destination): Return void.
1433 (coding_change_source, coding_change_destinations): New functions,
1434 with the old behaviors of coding_set_source and coding_set_destination.
1435 All callers that need an offset changed to use these new functions.
1436
1437 2012-05-26 Glenn Morris <rgm@gnu.org>
1438
1439 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1440
1441 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1442
1443 Extend mouse support on W32 text-mode console.
1444 * xdisp.c (draw_row_with_mouse_face):
1445 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1446
1447 * w32console.c: Include window.h.
1448 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1449 New functions.
1450 (initialize_w32_display): Initialize mouse-highlight data.
1451
1452 * w32inevt.c: Include termchar.h and window.h.
1453 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1454 moves, call note_mouse_highlight. If help_echo changed, call
1455 gen_help_event to produce help-echo message in the echo area.
1456 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1457 highlight info.
1458
1459 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 * lread.c (read1): Simplify slightly to avoid an overflow warning
1462 with GCC 4.7.0 on x86-64.
1463
1464 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1465
1466 * bidi.c (bidi_mirror_char): Revert last change: an int is
1467 definitely wide enough here.
1468
1469 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 Fix integer width and related bugs (Bug#9874).
1472 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1473 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1474 (string_bytes, check_sblock, allocate_string_data):
1475 (compact_small_strings, Fmake_bool_vector, make_string)
1476 (make_unibyte_string, make_multibyte_string)
1477 (make_string_from_bytes, make_specified_string)
1478 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1479 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1480 (mark_vectorlike):
1481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1482 (allocate_pseudovector):
1483 Use int, not EMACS_INT, where int is wide enough.
1484 (inhibit_garbage_collection, Fgarbage_collect):
1485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1486 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1487 int might not be wide enough.
1488 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1489 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1490 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1491 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1492 (bidi_level_of_next_char, bidi_move_to_visually_next):
1493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1494 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1495 (Fkill_buffer, Fset_buffer_major_mode)
1496 (advance_to_char_boundary, Fbuffer_swap_text)
1497 (Fset_buffer_multibyte, overlays_at, overlays_in)
1498 (overlay_touches_p, struct sortvec, record_overlay_string)
1499 (overlay_strings, recenter_overlay_lists)
1500 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1501 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1502 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1503 (Foverlay_recenter, last_overlay_modification_hooks_used)
1504 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1506 (validate_region): Omit unnecessary test for b <= e,
1507 since that's guaranteed by the previous test.
1508 (adjust_overlays_for_delete): Avoid pos + length overflow.
1509 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1510 (report_overlay_modification):
1511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1512 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1513 Omit pointer cast, which isn't needed anyway, and doesn't work
1514 after the EMACS_INT -> ptrdiff_t change.
1515 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1516 * buffer.h: Adjust decls to match defn changes elsewhere.
1517 (struct buffer_text, struct buffer):
1518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1519 Use EMACS_INT, not int, where int might not be wide enough.
1520 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1521 not int, to avoid needless 32-bit limit on 64-bit hosts.
1522 (exec_byte_code): Use tighter memory-full test, one that checks
1523 for alloca overflow. Don't compute the address of the object just
1524 before an array, as that's not portable. Use EMACS_INT, not
1525 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1526 * callint.c (Fcall_interactively):
1527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1528 * callproc.c (call_process_kill, Fcall_process):
1529 Don't assume pid_t fits into an Emacs fixnum.
1530 (call_process_cleanup, Fcall_process, child_setup):
1531 Don't assume pid_t fits into int.
1532 (call_process_cleanup, Fcall_process, delete_temp_file)
1533 (Fcall_process_region):
1534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1535 (Fcall_process): Simplify handling of volatile integers.
1536 Use int, not EMACS_INT, where int will do.
1537 * casefiddle.c (casify_object, casify_region, operate_on_word)
1538 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1540 (casify_object): Avoid integer overflow when overallocating buffer.
1541 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1542 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1543 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1544 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1545 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1546 integers are now checked earlier. All uses replaced with XINT.
1547 (ccl_driver):
1548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1549 For CCL_MapSingle, check that content and value are in int range.
1550 (ccl_driver, Fregister_code_conversion_map):
1551 Check that Vcode_version_map_vector is a vector.
1552 (resolve_symbol_ccl_program): Check that vector header is in range.
1553 Always copy the vector, so that we can check its contents reliably
1554 now rather than having to recheck each instruction as it's being
1555 executed. Check that vector words fit in 'int'.
1556 (ccl_get_compiled_code, Fregister_ccl_program)
1557 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1558 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1559 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1560 contents are in range.
1561 (Fccl_execute_on_string): Check that status is in range.
1562 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1563 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1564 Accept and return EMACS_INT, not int, because callers can pass values
1565 out of 'int' range.
1566 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1567 (multibyte_chars_in_text, parse_str_as_multibyte)
1568 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1569 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1570 (string_escape_byte8, Fget_byte):
1571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1572 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1573 avoid mishandling large integers.
1574 * character.h: Adjust decls to match defn changes elsewhere.
1575 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1576 (Ffind_charset_region):
1577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1578 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1579 (load_charset_map_from_vector, Fdefine_charset_internal):
1580 Don't assume fixnum fits in int.
1581 (load_charset_map_from_vector, Fmap_charset_chars):
1582 Remove now-unnecessary CHECK_NATNUMs.
1583 (Fdefine_charset_internal): Check ranges here, more carefully.
1584 Don't rely on undefined behavior with signed left shift overflow.
1585 Don't assume unsigned int fits into fixnum, or that fixnum fits
1586 into unsigned int. Don't require max_code to be a valid fixnum;
1587 that's not true for gb10830 4-byte on a 32-bit host. Allow
1588 invalid_code to be a cons, for the same reason. Require code_offset
1589 to be a character. Avoid int overflow if max_char is close
1590 to INT_MAX.
1591 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1592 this is intended anyway and avoids some undefined behavior.
1593 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1594 INDEX_TO_CODE_POINT, as that's what it expects.
1595 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1596 * charset.h (DECODE_CHAR): Return int, not unsigned;
1597 this is what was intended anyway, and it avoids undefined behavior.
1598 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1599 integer-overflow issues.
1600 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1601 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1602 where the argument is EMACS_INT, and this behavior is not intended.
1603 * chartab.c (Fmake_char_table, Fset_char_table_range)
1604 (uniprop_get_decoder, uniprop_get_encoder):
1605 Don't assume fixnum fits in int.
1606 * cmds.c (move_point): New function, that does the gist of
1607 Fforward_char and Fbackward_char, but does so while checking
1608 for integer overflow more accurately.
1609 (Fforward_char, Fbackward_char): Use it.
1610 (Fforward_line, Fend_of_line, internal_self_insert)
1611 (internal_self_insert):
1612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1613 Fix a FIXME, by checking for integer overflow when calculating
1614 target_clm and actual_clm.
1615 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1616 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1617 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1618 (coding_alloc_by_making_gap, alloc_destination)
1619 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1620 (encode_coding_utf_16, detect_coding_emacs_mule)
1621 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1622 (detect_coding_iso_2022, decode_coding_iso_2022)
1623 (encode_invocation_designation, encode_designation_at_bol)
1624 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1625 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1626 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1627 (encode_coding_ccl, encode_coding_raw_text)
1628 (detect_coding_charset, decode_coding_charset)
1629 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1630 (produce_composition, produce_charset, produce_annotation)
1631 (decode_coding, handle_composition_annotation)
1632 (handle_charset_annotation, consume_chars, decode_coding_gap)
1633 (decode_coding_object, encode_coding_object, detect_coding_system)
1634 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1635 (code_convert_region, code_convert_string)
1636 (Fdefine_coding_system_internal)
1637 (coding_set_source, coding_set_destination):
1638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1639 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1640 (Fdefine_coding_system_internal):
1641 Don't assume fixnums fit in int.
1642 (decode_coding_gap, decode_coding_object, encode_coding_object)
1643 (Fread_coding_system, Fdetect_coding_region)
1644 (Funencodable_char_position, Fcheck_coding_systems_region)
1645 (get_translation, handle_composition_annotation, consume_chars):
1646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1647 (consume_chars): Rewrite to not calculate an address outside buffer.
1648 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1649 Don't access memory outside of the args array.
1650 (Fdefine_coding_system_internal): Check for charset-id overflow.
1651 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1652 result of ENCODE_CHAR.
1653 * coding.h: Adjust decls to match defn changes elsewhere.
1654 (struct coding_system):
1655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1656 * composite.c (get_composition_id, find_composition)
1657 (run_composition_function, update_compositions)
1658 (compose_text, composition_gstring_put_cache)
1659 (composition_gstring_p, composition_gstring_width)
1660 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1661 (composition_compute_stop_pos, composition_reseat_it)
1662 (composition_update_it, struct position_record)
1663 (find_automatic_composition, composition_adjust_point)
1664 (Fcomposition_get_gstring, Ffind_composition_internal):
1665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1666 (update_compositions):
1667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1668 * composite.h: Adjust decls to match defn changes elsewhere.
1669 (struct composition):
1670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1671 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1672 Do not attempt to compute the address of the object just before a
1673 buffer; this is not portable.
1674 (Faref, Faset):
1675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1676 (Faset): Use int, not EMACS_INT, where int is wide enough.
1677 (Fstring_to_number): Don't assume fixnums fit in int.
1678 (Frem): Don't assume arg is nonnegative.
1679 * dbusbind.c (xd_append_arg): Check for integers out of range.
1680 (Fdbus_call_method): Don't overflow the timeout int.
1681 (extract_signed, extract_unsigned): New functions.
1682 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1683 (xd_get_connection_references): Return ptrdiff_t, not int.
1684 All uses changed.
1685 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1686 (xd_read_message_1):
1687 Use int, not unsigned, where the dbus API uses int.
1688 (Fdbus_message_internal): Don't overflow mtype.
1689 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1690 * dired.c (directory_files_internal, file_name_completion, scmp)
1691 (file_name_completion_stat):
1692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1693 (file_name_completion): Don't overflow matchcount.
1694 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1695 * dispextern.h: Adjust decls to match defn changes elsewhere.
1696 (struct text_pos, struct glyph, struct bidi_saved_info)
1697 (struct bidi_string_data, struct bidi_it, struct composition_it)
1698 (struct it):
1699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1700 (struct display_pos, struct composition_it, struct it):
1701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1702 * dispnew.c (increment_matrix_positions)
1703 (increment_row_positions, mode_line_string)
1704 (marginal_area_string):
1705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1706 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1708 (duration_to_sec_usec): New function, to check for overflow better.
1709 (Fsleep_for, sit_for): Use it.
1710 * doc.c (get_doc_string, store_function_docstring):
1711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1712 (get_doc_string, Fsnarf_documentation):
1713 Use int, not EMACS_INT, where int is wide enough.
1714 (get_doc_string):
1715 Use SAFE_ALLOCA, not alloca.
1716 Check for overflow when converting EMACS_INT to off_t.
1717 * doprnt.c (doprnt):
1718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1719 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1720 Don't assume uid_t fits into fixnum.
1721 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1722 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1723 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1724 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1725 (general_insert_function)
1726 (Finsert_char, make_buffer_string, make_buffer_string_both)
1727 (update_buffer_properties, Fbuffer_substring)
1728 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1729 (Fsubst_char_in_region, check_translation)
1730 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1731 (transpose_markers, Ftranspose_regions):
1732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1733 (clip_to_bounds): Move to lisp.h as an inline function).
1734 (Fconstrain_to_field): Don't assume integers are nonnegative.
1735 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1736 (Fsubst_char_in_region, Fsave_restriction):
1737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1738 (Femacs_pid): Don't assume pid_t fits into fixnum.
1739 (lo_time): Use int, not EMACS_INT, when int suffices.
1740 (lisp_time_argument): Check for usec out of range.
1741 (Fencode_time): Don't assume fixnum fits in int.
1742 (Fuser_login_name, Fuser_full_name): Signal an error
1743 if a uid argument is out of range, rather than relying on
1744 undefined behavior.
1745 (Fformat_time_string): Remove now-unnecessary check.
1746 lisp_time_argument checks for out-of-range usec now.
1747 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1748 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1749 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1750 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1751 (init_cmdargs, Fdump_emacs):
1752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1753 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1754 the bottom (typically) 32 bits of the fixnum.
1755 * eval.c (specpdl_size, call_debugger):
1756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1757 (when_entered_debugger, Fbacktrace_debug):
1758 Don't assume fixnum can fit in int.
1759 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1760 the object just before a buffer; this is not portable.
1761 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1762 (grow_specpdl, unbind_to):
1763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1764 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1765 (grow_specpdl): Simplify allocation by using xpalloc.
1766 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1767 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1768 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1770 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1771 (a_write, e_write):
1772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1773 (Fcopy_file, non_regular_nbytes, read_non_regular)
1774 (Finsert_file_contents):
1775 Use int, not EMACS_INT, where int is wide enough.
1776 (READ_BUF_SIZE): Verify that it fits in int.
1777 (Finsert_file_contents): Check that counts are in proper range,
1778 rather than assuming fixnums fit into ptrdiff_t etc.
1779 Don't assume fixnums fit into int.
1780 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1781 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1782 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1783 (string_char_to_byte, string_byte_to_char)
1784 (string_make_multibyte, string_to_multibyte)
1785 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1786 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1787 (substring_both, Fdelete, internal_equal, Ffillarray)
1788 (Fclear_string, mapcar1)
1789 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1790 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1791 (larger_vector, make_hash_table, maybe_resize_hash_table)
1792 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1793 (Fmaphash, secure_hash):
1794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1795 (concat): Check for string index and length overflow.
1796 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1797 (Frequire):
1798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1799 (larger_vector): New API (vec, incr_min, size_max) replaces old
1800 one (vec, new_size, init). This catches size overflow.
1801 INIT was removed because it was always Qnil.
1802 All callers changed.
1803 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1804 the upper bound on a hash table index size.
1805 (make_hash_table, maybe_resize_hash_table): Use it.
1806 (secure_hash): Computer start_byte and end_byte only after
1807 they're known to be in ptrdiff_t range.
1808 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1809 (Ffont_get_glyphs, Ffont_at):
1810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1811 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1812 (Flist_fonts, Fopen_font):
1813 Don't assume fixnum can fit in int.
1814 (check_gstring): Don't assume index can fit in int.
1815 (font_match_p): Check that fixnum is a character, not a nonnegative
1816 fixnum, since the later code needs to stuff it into an int.
1817 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1818 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1819 conversion overflow issues.
1820 (Fopen_font): Check for integer out of range.
1821 (Ffont_get_glyphs): Don't assume index can fit in int.
1822 * font.h: Adjust decls to match defn changes elsewhere.
1823 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1824 integer overflow.
1825 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1826 printmax_t, where ptrdiff_t is wide enough.
1827 (Finternal_char_font):
1828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1829 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1830 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1831 (Fset_frame_position, x_set_frame_parameters)
1832 (x_set_line_spacing, x_set_border_width)
1833 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1834 Check that fixnums are in proper range for system types.
1835 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1837 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1838 Use SAFE_ALLOCA_LISP, not alloca.
1839 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1840 intptr_t is wide enough.
1841 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1842 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1843 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1844 Check for fixnum out of range.
1845 * ftfont.c (ftfont_list): Don't assume index fits in int.
1846 Check that fixnums are in proper range for system types.
1847 (ftfont_shape_by_flt):
1848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1849 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1851 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1852 Check that fixnums are in proper range for system types.
1853 * gnutls.h: Adjust decls to match defn changes elsewhere.
1854 * gtkutil.c (xg_dialog_run):
1855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1856 (update_frame_tool_bar):
1857 Check that fixnums are in proper range for system types.
1858 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1859 (lookup_image): Check that fixnums are in range for system types.
1860 * indent.c (last_known_column, last_known_column_point):
1861 (current_column_bol_cache):
1862 (skip_invisible, current_column, check_display_width):
1863 (check_display_width, scan_for_column, current_column_1)
1864 (Findent_to, Fcurrent_indentation, position_indentation)
1865 (indented_beyond_p, Fmove_to_column, compute_motion):
1866 (Fcompute_motion, Fvertical_motion):
1867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1868 (last_known_column_modified): Use EMACS_INT, not int.
1869 (check_display_width):
1870 (Fcompute_motion):
1871 Check that fixnums and floats are in proper range for system types.
1872 (compute_motion): Don't assume index or fixnum fits in int.
1873 (compute_motion, Fcompute_motion):
1874 Use int, not EMACS_INT, when it is wide enough.
1875 (vmotion): Omit local var start_hpos that is always 0; that way
1876 we don't need to worry about overflow in expressions involving it.
1877 * indent.h: Adjust decls to match defn changes elsewhere.
1878 (struct position):
1879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1880 Use int, not EMACS_INT, where int is wide enough.
1881 Remove unused members ovstring_chars_done and tab_offset;
1882 all uses removed.
1883 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1884 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1885 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1886 (make_gap, copy_text, insert, insert_and_inherit)
1887 (insert_before_markers, insert_before_markers_and_inherit)
1888 (insert_1, count_combining_before, count_combining_after)
1889 (insert_1_both, insert_from_string)
1890 (insert_from_string_before_markers, insert_from_string_1)
1891 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1892 (adjust_after_replace, adjust_after_insert, replace_range)
1893 (replace_range_2, del_range, del_range_1, del_range_byte)
1894 (del_range_both, del_range_2, modify_region)
1895 (prepare_to_modify_buffer, signal_before_change)
1896 (signal_after_change, Fcombine_after_change_execute):
1897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1898 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1899 (balance_an_interval, split_interval_right, split_interval_left)
1900 (find_interval, next_interval, update_interval)
1901 (adjust_intervals_for_insertion, delete_node, delete_interval)
1902 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1903 (static_offset_intervals, offset_intervals)
1904 (merge_interval_right, merge_interval_left, make_new_interval)
1905 (graft_intervals_into_buffer, temp_set_point_both)
1906 (temp_set_point, set_point, adjust_for_invis_intang)
1907 (set_point_both, move_if_not_intangible, get_property_and_range)
1908 (get_local_map, copy_intervals, copy_intervals_to_string)
1909 (compare_string_intervals, set_intervals_multibyte_1):
1910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1911 * intervals.h: Adjust decls to match defn changes elsewhere.
1912 (struct interval):
1913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1914 * keyboard.c (this_command_key_count, this_single_command_key_start)
1915 (before_command_key_count, before_command_echo_length, echo_now)
1916 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1917 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1918 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1919 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1921 (last_non_minibuf_size, last_point_position, echo_truncate)
1922 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1923 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1924 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1925 (stuff_buffered_input):
1926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1927 (last_auto_save, command_loop_1, read_char):
1928 Use EMACS_INT, not int, to avoid integer overflow.
1929 (record_char): Avoid overflow in total_keys computation.
1930 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1931 * keyboard.h: Adjust decls to match defn changes elsewhere.
1932 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1933 (Fkey_description, Fdescribe_vector, Flookup_key):
1934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1935 (click_position): New function, to check that positions are in range.
1936 (Fcurrent_active_maps):
1937 (describe_command):
1938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1939 (Faccessible_keymaps, Fkey_description):
1940 (preferred_sequence_p):
1941 Don't assume fixnum can fit into int.
1942 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1943 Check for integer overflow in size calculations.
1944 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1945 avoid mishandling large integers.
1946 * lisp.h: Adjust decls to match defn changes elsewhere.
1947 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1948 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1949 (struct Lisp_Marker):
1950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1951 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1952 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1953 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1954 All callers changed.
1955 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1956 Assume the arg has valid form, since it always does.
1957 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1958 unsigned integer system type.
1959 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1960 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1962 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1963 (duration_to_sec_usec): New decl.
1964 * lread.c (read_from_string_index, read_from_string_index_byte)
1965 (read_from_string_limit, readchar, unreadchar, openp)
1966 (read_internal_start, read1, oblookup):
1967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1968 (Fload, readevalloop, Feval_buffer, Feval_region):
1969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1970 (openp): Check for out-of-range argument to 'access'.
1971 (read1): Use int, not EMACS_INT, where int is wide enough.
1972 Don't assume fixnum fits into int.
1973 Fix off-by-one error that can read outside a buffer.
1974 (read_filtered_event): Use duration_to_sec_usec
1975 to do proper overflow checking on durations.
1976 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1977 in size calculation.
1978 (Fexecute_kbd_macro):
1979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1980 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1981 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1982 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1983 (set_marker_both, set_marker_restricted_both, marker_position)
1984 (marker_byte_position, Fbuffer_has_markers_at):
1985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1986 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1987 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1988 It now merely ensures that the menu is large enough, without
1989 necessarily growing it, as this avoids some integer overflow issues.
1990 All callers changed.
1991 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1993 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1994 Use SAFE_ALLOCA_LISP, not alloca.
1995 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1996 to EMACS_INT. Check that fixnums are in proper range for system types.
1997 * minibuf.c (minibuf_prompt_width, string_to_object)
1998 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1999 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2001 (get_minibuffer, read_minibuf_unwind):
2002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2003 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2004 this simplifies overflow checking. All callers changed.
2005 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2006 (Ftest_completion):
2007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2008 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2009 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2010 Check that fixnums are in proper range for system types.
2011 (Fx_create_frame, Fx_show_tip):
2012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2013 * nsfont.m (ns_findfonts, nsfont_list_family):
2014 Don't assume fixnum fits in long.
2015 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2017 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2018 wide enough.
2019 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2021 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2022 (PRINTDECLARE, PRINTPREPARE):
2023 (strout, print_string):
2024 (print, print_preprocess, print_check_string_charset_prop)
2025 (print_object):
2026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2027 (PRINTDECLARE):
2028 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2030 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2031 (printchar, strout): Use xpalloc to catch size calculation overflow.
2032 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2033 (print_error_message): Use SAFE_ALLOCA, not alloca.
2034 (print_object): Use int, not EMACS_INT, where int is wide enough.
2035 (print_depth, new_backquote_output, print_number_index):
2036 Use ptrdiff_t, not int, where int might not be wide enough.
2037 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2038 (Fset_process_window_size, Fformat_network_address)
2039 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2040 (sigchld_handler):
2041 Check that fixnums are in proper range for system types.
2042 (Fsignal_process): Simplify by avoiding a goto.
2043 Check for process-ids out of pid_t range rather than relying on
2044 undefined behavior.
2045 (process_tick, update_tick): Use EMACS_INT, not int.
2046 (Fformat_network_address, read_process_output, send_process)
2047 (Fprocess_send_region, status_notify):
2048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2049 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2050 (wait_reading_process_output, read_process_output, exec_sentinel):
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2053 (Faccept_process_output): Use duration_to_sec_usec to do proper
2054 overflow checking on durations.
2055 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2056 Don't assume pid_t fits in int.
2057 * process.h (struct Lisp_Process): Members tick and update_tick
2058 are now of type EMACS_INT, not int.
2059 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2060 configured --with-wide-int.
2061 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2062 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2063 * search.c (looking_at_1, string_match_1):
2064 (fast_string_match, fast_c_string_match_ignore_case)
2065 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2066 (scan_newline, find_before_next_newline, search_command)
2067 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2068 (set_search_regs, wordify):
2069 (Freplace_match):
2070 (Fmatch_data):
2071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2072 (string_match_1, search_buffer, set_search_regs):
2073 (Fmatch_data):
2074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2075 (wordify): Check for overflow in size calculation.
2076 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2077 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2078 Check that fixnums are in proper range for system types.
2079 * sound.c (struct sound_device)
2080 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2082 (Fplay_sound_internal):
2083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2084 * syntax.c (struct lisp_parse_state, find_start_modiff)
2085 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2086 (Fparse_partial_sexp):
2087 Don't assume fixnums can fit in int.
2088 (struct lisp_parse_state, find_start_pos, find_start_value)
2089 (find_start_value_byte, find_start_begv)
2090 (update_syntax_table, char_quoted, dec_bytepos)
2091 (find_defun_start, prev_char_comend_first, back_comment):
2092 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2093 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2095 (Finternal_describe_syntax_value): Check that match_lisp is a
2096 character, not an integer, since the code stuffs it into int.
2097 (scan_words, scan_sexps_forward):
2098 Check that fixnums are in proper range for system types.
2099 (Fforward_word):
2100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2101 (scan_sexps_forward):
2102 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2103 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2104 * syntax.h: Adjust decls to match defn changes elsewhere.
2105 (struct gl_state_s):
2106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2107 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2108 MOST_POSITIVE_FIXNUM.
2109 * sysdep.c (wait_for_termination_1, wait_for_termination)
2110 (interruptible_wait_for_termination, mkdir):
2111 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2112 (emacs_read, emacs_write):
2113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2114 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2115 and double all fit in int.
2116 * term.c (set_tty_color_mode):
2117 Check that fixnums are in proper range for system types.
2118 * termhooks.h (struct input_event):
2119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2120 * textprop.c (validate_interval_range, interval_of)
2121 (Fadd_text_properties, set_text_properties_1)
2122 (Fremove_text_properties, Fremove_list_of_text_properties)
2123 (Ftext_property_any, Ftext_property_not_all)
2124 (copy_text_properties, text_property_list, extend_property_ranges)
2125 (verify_interval_modification):
2126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2127 (Fnext_single_char_property_change)
2128 (Fprevious_single_char_property_change):
2129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2130 (copy_text_properties):
2131 Check for integer overflow in index calculation.
2132 * undo.c (last_boundary_position, record_point, record_insert)
2133 (record_delete, record_marker_adjustment, record_change)
2134 (record_property_change):
2135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2136 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2138 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2139 (Fx_hide_tip, Fx_file_dialog):
2140 * w32menu.c (set_frame_menubar):
2141 Use ptrdiff_t, not int, for consistency with rest of code.
2142 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2143 (select_window, Fdelete_other_windows_internal)
2144 (window_scroll_pixel_based, window_scroll_line_based)
2145 (Frecenter, Fset_window_configuration):
2146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2147 (Fset_window_hscroll, run_window_configuration_change_hook)
2148 (set_window_buffer, temp_output_buffer_show, scroll_command)
2149 (Fscroll_other_window, Frecenter):
2150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2151 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2152 Don't assume fixnum fits in int.
2153 (Fset_window_scroll_bars):
2154 Check that fixnums are in proper range for system types.
2155 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2156 (string_pos, c_string_pos, number_of_chars, init_iterator)
2157 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2158 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2159 (compute_display_string_end, handle_face_prop)
2160 (face_before_or_after_it_pos, handle_invisible_prop)
2161 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2162 (display_prop_intangible_p, string_buffer_position_lim)
2163 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2164 (get_overlay_strings_1, get_overlay_strings)
2165 (iterate_out_of_display_property, forward_to_next_line_start)
2166 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2167 (get_next_display_element, set_iterator_to_next)
2168 (get_visually_first_element, compute_stop_pos_backwards)
2169 (handle_stop_backwards, next_element_from_buffer)
2170 (move_it_in_display_line_to, move_it_in_display_line)
2171 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2172 (add_to_log, message_dolog, message_log_check_duplicate)
2173 (message2, message2_nolog, message3, message3_nolog
2174 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2175 (current_message_1, truncate_echo_area, truncate_message_1)
2176 (set_message, set_message_1, store_mode_line_noprop)
2177 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2178 (text_outside_line_unchanged_p, check_point_in_composition)
2179 (reconsider_clip_changes)
2180 (redisplay_internal, set_cursor_from_row, try_scrolling)
2181 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2182 (redisplay_window, find_last_unchanged_at_beg_row)
2183 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2184 (trailing_whitespace_p, find_row_edges, display_line)
2185 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2186 (display_mode_element, store_mode_line_string)
2187 (pint2str, pint2hrstr, decode_mode_spec)
2188 (display_count_lines, display_string, draw_glyphs)
2189 (x_produce_glyphs, x_insert_glyphs)
2190 (rows_from_pos_range, mouse_face_from_buffer_pos)
2191 (fast_find_string_pos, mouse_face_from_string_pos)
2192 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2194 (safe_call, init_from_display_pos, handle_fontified_prop)
2195 (handle_single_display_spec, load_overlay_strings)
2196 (with_echo_area_buffer, setup_echo_area_for_printing)
2197 (display_echo_area, echo_area_display)
2198 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2199 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2200 (redisplay_window, dump_glyph_row, display_mode_line)
2201 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2202 (handle_display_spec, display_prop_string_p):
2203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2204 (handle_single_display_spec, build_desired_tool_bar_string)
2205 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2206 (get_specified_cursor_type):
2207 Check that fixnums are in proper range for system types.
2208 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2209 (Flookup_image_map):
2210 Don't assume fixnums fit in int.
2211 (compare_overlay_entries):
2212 Avoid mishandling comparisons due to subtraction overflow.
2213 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2214 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2215 (handle_tool_bar_click):
2216 Use int, not unsigned, since we prefer signed and the signedness
2217 doesn't matter here.
2218 (get_next_display_element, next_element_from_display_vector):
2219 Use int, not EMACS_INT, when int is wide enough.
2220 (start_hourglass): Use duration_to_sec_usec to do proper
2221 overflow checking on durations.
2222 * xfaces.c (Fbitmap_spec_p):
2223 Check that fixnums are in proper range for system types.
2224 (compare_fonts_by_sort_order):
2225 Avoid mishandling comparisons due to subtraction overflow.
2226 (Fx_family_fonts, realize_basic_faces):
2227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2228 (Fx_family_fonts):
2229 Don't assume fixnum fits in int.
2230 Use SAFE_ALLOCA_LISP, not alloca.
2231 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2232 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2233 (face_at_buffer_position, face_for_overlay_string)
2234 (face_at_string_position):
2235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2236 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2237 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2238 (Fx_show_tip):
2239 Check that fixnums are in proper range for system types.
2240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2241 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2243 (Fx_change_window_property): Don't assume fixnums fit in int.
2244 * xfont.c (xfont_chars_supported):
2245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2246 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2247 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2249 * xml.c (parse_region):
2250 * xrdb.c (magic_file_p):
2251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2252 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2253 (x_get_local_selection, x_reply_selection_request)
2254 (x_handle_selection_request, wait_for_property_change):
2255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2256 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2257 short is wide enough.
2258 (x_send_client_event): Don't assume fixnum fits in int.
2259 * xterm.c (x_x_to_emacs_modifiers):
2260 Don't assume EMACS_INT overflows nicely into int.
2261 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2262 may come from Lisp.
2263 (handle_one_xevent): NATNUMP can eval its arg twice.
2264 (x_connection_closed):
2265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2266 * xterm.h: Adjust decls to match defn changes elsewhere.
2267 (struct scroll_bar): Use struct vectorlike_header
2268 rather than rolling our own approximation.
2269 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2270
2271 2012-05-25 Glenn Morris <rgm@gnu.org>
2272
2273 * lisp.mk (lisp): Update for more files being compiled now.
2274
2275 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2276
2277 * lread.c: Remove `read_pure' which makes no difference.
2278 (read_pure): Remove var.
2279 (unreadpure): Remove function.
2280 (readevalloop): Don't call read_list with -1 flag.
2281 (read1, read_vector): Don't test read_pure any more.
2282 (read_list): Simplify.
2283
2284 * fileio.c, character.h: Minor style tweaks.
2285
2286 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2287
2288 * window.h (clip_changed): Remove useless declaration.
2289
2290 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2291
2292 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2293 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2294
2295 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2296
2297 Remove src/m/*.
2298 This directory predates autoconf and is no longer needed nowadays.
2299 Move its few remaining bits of functionality to where they're needed.
2300 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2301 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2302 * m/template.h: Remove.
2303 * Makefile.in (M_FILE): Remove. All uses removed.
2304 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2305 * lisp.h (USE_LSB_TAG):
2306 * mem-limits.h (EXCEEDS_LISP_PTR):
2307 Use VAL_MAX, not VALBITS, in #if.
2308 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2309 (EMACS_UINT): Define unconditionally now.
2310 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2311 (BITS_PER_EMACS_INT): New constants, replacing
2312 what used to be in config.h, but not useful in #if.
2313 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2314 define them any more.
2315 (VAL_MAX): New macro.
2316 (VALMASK): Use it.
2317 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2318 BITS_PER_EMACS_INT, in #if.
2319 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2320 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2321 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2322 * s/ms-w32.h (DATA_START):
2323 Move here from removed file m/intel386.h.
2324 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2325 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2326
2327 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 Assume C89 or later.
2330 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2331 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2332 (xrealloc):
2333 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2334 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2335 * textprop.c, tparam.c (NULL): Remove.
2336 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2337 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2338 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2339 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2340 * xterm.c (input_signal_count): Assume volatile works.
2341
2342 2012-05-21 Ken Brown <kbrown@cornell.edu>
2343
2344 * xgselect.c (xg_select): Fix first argument in call to 'select'
2345 (bug#11508).
2346
2347 2012-05-20 Ken Brown <kbrown@cornell.edu>
2348
2349 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2350 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2351
2352 2012-05-19 Ken Brown <kbrown@cornell.edu>
2353
2354 * xfns.c (x_in_use): Remove `static' qualifier.
2355 * xterm.h (x_in_use): Declare.
2356 * xgselect.c: Include xterm.h.
2357 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2358 and `display_arg' (bug#9754).
2359
2360 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2361
2362 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2363
2364 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2365 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2366
2367 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2368
2369 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2370
2371 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2372 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2373
2374 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2375 reference to image_cache->refcount.
2376 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2377
2378 2012-05-17 Juri Linkov <juri@jurta.org>
2379
2380 * search.c (Fword_search_regexp, Fword_search_backward)
2381 (Fword_search_forward, Fword_search_backward_lax)
2382 (Fword_search_forward_lax): Move functions to isearch.el
2383 (bug#10145, bug#11381).
2384
2385 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2386
2387 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2388
2389 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2390
2391 * lread.c (init_obarray): Declare Qt and Qnil as special.
2392
2393 2012-05-14 Glenn Morris <rgm@gnu.org>
2394
2395 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2396 Put "libexec" before "bin", for the sake of init_callproc_1.
2397
2398 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2401
2402 * unexaix.c: Port to more-recent AIX compilers.
2403 (report_error, report_error_1, make_hdr, copy_sym)
2404 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2405 Make arguments const char *, not char *, to avoid violations of C
2406 standard and to fix some AIX warnings reported by Gilles Pion.
2407
2408 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2409
2410 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2411 already have overlays loaded.
2412 (handle_single_display_spec): Before returning without displaying
2413 fringe bitmap, synchronize the bidi iterator with the main display
2414 iterator, by calling iterate_out_of_display_property.
2415 (iterate_out_of_display_property): Detect buffer iteration by
2416 testing that it->string is a Lisp string.
2417 (get_next_display_element): When the current object is exhausted,
2418 and there's something on it->stack, call set_iterator_to_next to
2419 proceed with what's on the stack, instead of returning zero.
2420 (set_iterator_to_next): If called at the end of a Lisp string,
2421 proceed to consider_string_end without incrementing string
2422 position. Don't increment display vector index past the end of
2423 the display vector. (Bug#11417)
2424 (pos_visible_p): Don't report a position visible when move_it_to
2425 stopped at the last line of window, which happens to be scanned
2426 backwards by the bidi iteration. (Bug#11464)
2427
2428 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2429
2430 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2431 and right-margin display specs even if the spec is invalid or we
2432 are on a TTY, and thus unable to display on the fringes.
2433 That's because the text with the property will not be displayed anyway,
2434 so we need to signal to the caller that this is a "replacing"
2435 display spec. This fixes display when the spec is invalid or we
2436 are on a TTY.
2437
2438 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 * unexaix.c (make_hdr): Fix typo in prototype.
2441 This bug broke the build on AIX. Problem reported by Gilles Pion.
2442
2443 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2444
2445 * keyboard.c (kbd_buffer_get_event): Read special events also in
2446 batch mode. (Bug#11415)
2447
2448 2012-05-12 Glenn Morris <rgm@gnu.org>
2449
2450 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2451
2452 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2453
2454 * lisp.mk (lisp): Add newcomment.elc.
2455
2456 2012-05-12 Glenn Morris <rgm@gnu.org>
2457
2458 * Makefile.in (MKDIR_P): New, set by configure.
2459 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2460
2461 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2462
2463 Remove unused function hourglass_started.
2464 * dispextern.h (hourglass_started):
2465 * w32fns.c (hourglass_started):
2466 * xdisp.c (hourglass_started): Remove.
2467
2468 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2469
2470 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2471 Update dependencies.
2472
2473 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 * xgselect.c (xg_select): Put maxfds+1 into a var.
2476 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2477
2478 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2479
2480 2012-05-10 Dave Abrahams <dave@boostpro.com>
2481
2482 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2483 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2484
2485 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2486
2487 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2488 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2489 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2490 Initialize xd_registered_buses.
2491
2492 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 Untag more efficiently if USE_LSB_TAG.
2495 This is based on a proposal by YAMAMOTO Mitsuharu in
2496 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2497 For an admittedly artificial (nth 8000 longlist) benchmark on
2498 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2499 Emacs's overall text size by 1%.
2500 * lisp.h (XUNTAG): New macro.
2501 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2502 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2503 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2504 * eval.c (Fautoload):
2505 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2506 * frame.h (XFRAME): Use XUNTAG.
2507
2508 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2509 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2510 Remove unportable assumptions about print widths of types like
2511 dbus_uint32_t.
2512 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2513 intptr_t when converting between pointer and integer, to avoid GCC
2514 warnings about wrong width.
2515
2516 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2517
2518 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2519 stack for each reader_thread, instead of defaulting to 8MB
2520 determined by the linker. This avoids failures in creating
2521 subprocesses on Windows 7, see the discussion in this thread:
2522 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2523
2524 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2525
2526 Fix up display of the *Minibuf-0* buffer in the mini window.
2527 * keyboard.c (read_char): Don't clear the echo area if there's no
2528 message to clear.
2529 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2530 contents of *Minibuf-0*) if there's no message displayed in its stead.
2531
2532 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2533
2534 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2535 batch mode.
2536
2537 2012-05-06 Chong Yidong <cyd@gnu.org>
2538
2539 * lisp.mk (lisp): Update.
2540
2541 2012-05-05 Jim Meyering <meyering@redhat.com>
2542
2543 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2544
2545 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2546
2547 * data.c (PUT_ERROR): New macro.
2548 (syms_of_data): Use it. Add new error type `user-error'.
2549 * undo.c (user_error): New function.
2550 (Fprimitive_undo): Use it.
2551 * print.c (print_error_message): Adjust print style for `user-error'.
2552 * keyboard.c (user_error): New function.
2553 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2554
2555 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 Do not limit current-time-string to years 1000..9999.
2558 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2559 (Fcurrent_time_string): Support any year that is supported by the
2560 underlying localtime representation. Don't use asctime, as it
2561 has undefined behavior for years outside the range -999..9999.
2562
2563 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 Fix race conditions involving setenv, gmtime, localtime, asctime.
2566 Without this fix, interrupts could mess up code that uses these
2567 nonreentrant functions, since setting TZ invalidates existing
2568 tm_zone or tzname values, and since most of these functions return
2569 pointers to static storage.
2570 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2571 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2572 Grow the critical sections to include not just invoking
2573 localtime/gmtime, but also accessing these functions' results
2574 including their tm_zone values if any, and any related TZ setting.
2575 (format_time_string): Last arg is now struct tm *, not struct tm **,
2576 so that the struct tm is saved in the critical section.
2577 All callers changed. Simplify allocation of initial buffer, partly
2578 motivated by the fact that memory allocation needs to be outside
2579 the critical section.
2580
2581 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2582
2583 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2584 with RESET_INTERVAL.
2585
2586 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2587 Remove duplicated buffer name initialization.
2588
2589 2012-05-02 Jim Meyering <jim@meyering.net>
2590
2591 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2592
2593 * xfns.c (x_window): Use xstrdup (Bug#11375).
2594
2595 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2596
2597 * xdisp.c (pos_visible_p): If already at a newline from the
2598 display string before the 'while' loop, don't walk back the glyphs
2599 from it3.glyph_row. Solves assertion violation when the display
2600 string begins with a newline (egg.el). (Bug#11367)
2601
2602 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2603
2604 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2605 Move to simple.el.
2606
2607 2012-05-01 Glenn Morris <rgm@gnu.org>
2608
2609 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2610 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2611 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2612 All were removed before 23.1.
2613
2614 * dispnew.c: Remove HAVE_LIBNCURSES test;
2615 it is always true on relevant platforms.
2616
2617 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2618 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2619
2620 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2621
2622 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2623
2624 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2625 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2626 Remove.
2627
2628 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 Do not avoid creating empty evaporating overlays (Bug#9642).
2631 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2632 That is, do not delete an evaporating overlay if it becomes
2633 empty after its bounds are adjusted to fit within its buffer.
2634 This fix caused other problems, and I'm reverting it until we get
2635 to the bottom of them.
2636
2637 2012-04-27 Chong Yidong <cyd@gnu.org>
2638
2639 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2640
2641 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (pos_visible_p): If the window start position is beyond
2644 ZV, start the display from buffer beginning. Prevents assertion
2645 violation in init_iterator when the minibuffer window is scrolled
2646 via the scroll bar.
2647
2648 * window.c (window_scroll_pixel_based): Likewise.
2649
2650 2012-04-27 Chong Yidong <cyd@gnu.org>
2651
2652 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2653
2654 2012-04-27 Glenn Morris <rgm@gnu.org>
2655
2656 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2657 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2658
2659 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2660
2661 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2662 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2663
2664 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2665
2666 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2667 display element, check also the underlying string or buffer
2668 character. (Bug#11341)
2669
2670 * w32menu.c: Include w32heap.h.
2671 (add_menu_item): If the call to AppendMenuW (via
2672 unicode_append_menu) fails, disable Unicode menus only if we are
2673 running on Windows 9X/Me.
2674
2675 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2676
2677 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2678 (xgetint): Add missing shift for LSB tags.
2679
2680 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2681
2682 * keyboard.c (read_char): Don't wipe echo area for select window
2683 events: These might get delayed via `mouse-autoselect-window'
2684 (Bug#11304).
2685
2686 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2687
2688 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2689 manipulation of :loaded-from data.
2690
2691 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2692
2693 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2694 now a cons (bug#11311).
2695
2696 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 Do not create empty overlays with the evaporate property (Bug#9642).
2699 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2700 if it becomes empty after its bounds are adjusted to fit within
2701 its buffer. Without this fix, in a nonempty buffer (let ((o
2702 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2703 yields an empty overlay that has the evaporate property, which is
2704 not supposed to happen.
2705
2706 Fix minor GTK3 problems found by static checking.
2707 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2708 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2709 (struct _EmacsFixedClass, emacs_fixed_get_type):
2710 Move decls here from emacsgtkfixed.h, since they needn't be public.
2711 (emacs_fixed_get_type): Now static.
2712 (emacs_fixed_class_init): Omit unused local.
2713 (emacs_fixed_child_type): Remove; unused.
2714 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2715 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2716 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2717 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2718 (EMACS_FIXED_GET_CLASS): Remove; unused.
2719 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2720
2721 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2722 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2723
2724 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2727 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2728 (__malloc_size_t, __malloc_ptrdiff_t):
2729 Remove. All uses removed, replaced by the definiens if needed,
2730 since we can assume C89 or better now.
2731 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2732 (protect_malloc_state, align, get_contiguous_space)
2733 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2734 (malloc_atfork_handler_child, malloc_enable_thread)
2735 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2736 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2737 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2738 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2739 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2740 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2741 Define using prototypes, not old style.
2742 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2743 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2744 (align): Don't assume that signed integer overflow wraps around.
2745 Omit unused local var.
2746 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2747 (_free_internal_nolock, memalign, mallochook, reallochook):
2748 Omit no-longer-needed casts.
2749 (valloc): Use getpagesize, not __getpagesize.
2750 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2751 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2752
2753 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2754
2755 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2756
2757 Move functions from C to Lisp. Make non-blocking method calls
2758 the default. Implement further D-Bus standard interfaces.
2759
2760 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2761 (QCdbus_request_name_allow_replacement)
2762 (QCdbus_request_name_replace_existing)
2763 (QCdbus_request_name_do_not_queue)
2764 (QCdbus_request_name_reply_primary_owner)
2765 (QCdbus_request_name_reply_in_queue)
2766 (QCdbus_request_name_reply_exists)
2767 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2768 (QCdbus_registered_serial, QCdbus_registered_method)
2769 (QCdbus_registered_signal): New Lisp objects.
2770 (XD_DEBUG_MESSAGE): Use sizeof.
2771 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2772 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2773 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2774 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2775 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2776 (xd_signature, xd_append_arg): Allow float for integer types.
2777 (xd_get_connection_references): New function.
2778 (xd_get_connection_address): Rename from xd_initialize.
2779 Return cached address.
2780 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2781 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2782 level.
2783 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2784 Return number of refcounts.
2785 (Fdbus_get_unique_name): Make stronger parameter check.
2786 (Fdbus_message_internal): New defun.
2787 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2788 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2789 (Fdbus_send_signal, Fdbus_register_service)
2790 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2791 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2792 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2793 (Vdbus_compiled_version, Vdbus_runtime_version)
2794 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2795 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2796 (Vdbus_message_type_signal): New defvars.
2797 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2798 Adapt docstring.
2799
2800 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2803 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2804 Do not assume ptrdiff_t is the same width as 'int'.
2805
2806 * alloc.c: Handle unusual debugging option combinations.
2807 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2808 since the two debugging options are incompatible.
2809 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2810 is defined.
2811 (mem_init, mem_insert, mem_insert_fixup):
2812 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2813 (NEED_MEM_INSERT): Remove; no longer needed.
2814
2815 2012-04-22 Leo Liu <sdl.web@gmail.com>
2816
2817 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2818
2819 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2820
2821 * sysdep.c [__FreeBSD__]: Minor cleanups.
2822 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2823 Use Emacs indenting style more consistently. Avoid some casts.
2824 Use 'double' consistently rather than mixing 'float' and 'double'.
2825
2826 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2827
2828 * sysdep.c (list_system_processes, system_process_attributes):
2829 Add implementation for FreeBSD (Bug#5243).
2830
2831 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2832
2833 * lisp.mk (lisp): Update.
2834
2835 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2838 It is never used otherwise.
2839
2840 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2841
2842 * print.c (print_preprocess): Only check print_depth if print-circle
2843 is nil.
2844 (print_object): Check for cycles even when print-circle is nil and
2845 print-gensym is t, but only check print_depth if print-circle is nil.
2846
2847 2012-04-20 Chong Yidong <cyd@gnu.org>
2848
2849 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2850 set the status to "failed" and ensure that sentinel is run.
2851
2852 2012-04-20 Glenn Morris <rgm@gnu.org>
2853
2854 * process.c (Fset_process_inherit_coding_system_flag)
2855 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2856 (Fmake_network_process, Fmake_serial_process): Doc fix.
2857
2858 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2859
2860 * xdisp.c (string_buffer_position_lim): Limit starting position to
2861 BEGV.
2862 (set_cursor_from_row): If called for a mode-line or header-line
2863 row, return zero immediately.
2864 (try_cursor_movement): If inside continuation line, don't back up
2865 farther than the first row after the header line, if any.
2866 Don't consider the header-line row as "partially visible", even if
2867 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2868
2869 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2870
2871 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2872 (bug#11238).
2873
2874 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2875 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2876
2877 configure: new option --enable-gcc-warnings (Bug#11207)
2878 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2879 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2880 (ALL_CFLAGS): Use new macros rather than old.
2881 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2882 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2883 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2884 -Wunused-result, -Wunused-variable. This should go away once
2885 the Emacs and Gnulib regex code is merged.
2886 (xmalloc, xrealloc): Now static.
2887
2888 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2889
2890 * dired.c (Fsystem_groups): Remove unused local.
2891
2892 2012-04-17 Glenn Morris <rgm@gnu.org>
2893
2894 * dired.c (Fsystem_users): Doc fix.
2895
2896 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2897
2898 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2899 (syms_of_dired): Add them.
2900
2901 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2902
2903 Fix minor alloc.c problems found by static checking.
2904 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2905 New extern decls, to avoid calling undeclared functions.
2906 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2907 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2908 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2909 (NEED_MEM_INSERT): New macro.
2910 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2911 Remove one incorrect comment and fix another.
2912
2913 Fix minor ralloc.c problems found by static checking.
2914 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2915 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2916 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2917 (r_alloc_sbrk): Now static.
2918
2919 Improve ralloc.c interface checking.
2920 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2921 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2922 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2923 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2924 [REL_ALLOC]: ... to here, to check interface.
2925 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2926 Remove decls. This fixes an "It stinks!".
2927
2928 * alloc.c (which_symbols): Fix alignment issue / type clash.
2929
2930 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2931
2932 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2933 (struct Lisp_Misc_Any): Likewise.
2934 (struct Lisp_Free): Likewise.
2935 * alloc.c (union aligned_Lisp_Symbol): Define.
2936 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2937 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2938 (union aligned_Lisp_Misc): Define.
2939 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2940 aligned_Lisp_Misc instead of union Lisp_Misc.
2941 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2942
2943 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2944
2945 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2946 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2947 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2948 * s/netbsd.h, s/sol2-6.h:
2949 Remove definition of GC_MARK_STACK, since the default now works.
2950 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2951 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2952 no longer the default.
2953 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2954
2955 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2956
2957 * lread.c (lisp_file_lexically_bound_p):
2958 Fix hang at ";-*-\n" (bug#11238).
2959
2960 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2961
2962 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2963 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2964
2965 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2966
2967 * nsterm.m (constrainFrameRect): Always constrain when there is only
2968 one screen (Bug#10962).
2969
2970 2012-04-13 Ken Brown <kbrown@cornell.edu>
2971
2972 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2973
2974 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2975
2976 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2977
2978 2012-04-11 Daniel Colascione <dancol@dancol.org>
2979
2980 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2981 against is gone. It's better to use vfork now so that when Cygwin
2982 gains a new, working vfork, we use it automatically (bug#10398).
2983
2984 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2985
2986 * window.c (save_window_save): Obey window-point-insertion-type.
2987
2988 2012-04-11 Glenn Morris <rgm@gnu.org>
2989
2990 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2991
2992 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2993
2994 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2995
2996 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2997
2998 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2999 (force_quit_count): New var.
3000 (handle_interrupt): Use it.
3001
3002 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3003
3004 * w32.c (w32_delayed_load): Record the full path of the library
3005 being loaded (bug#10424).
3006
3007 2012-04-09 Glenn Morris <rgm@gnu.org>
3008
3009 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3010 not just in the obarray, before snarfing them. (Bug#11036)
3011
3012 * Makefile.in ($(leimdir)/leim-list.el):
3013 Pass EMACS rather than BUILT_EMACS.
3014
3015 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3016
3017 * process.c (make_process):
3018 * process.h: Add integer `gnutls_handshakes_tried' member to
3019 process struct.
3020
3021 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3022 Add convenience `GNUTLS_LOG2i' macro.
3023
3024 * gnutls.c (gnutls_log_function2i): Convenience log function.
3025 (emacs_gnutls_read): Use new log functions,
3026 `gnutls_handshakes_tried' process member, and
3027 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3028 attempts per process (connection).
3029
3030 2012-04-09 Chong Yidong <cyd@gnu.org>
3031
3032 * eval.c (Fuser_variable_p, user_variable_p_eh)
3033 (lisp_indirect_variable): Functions deleted.
3034 (Fdefvar): Caller changed.
3035
3036 * callint.c (Finteractive, Fcall_interactively):
3037 * minibuf.c (Fread_variable): Callers changed.
3038
3039 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3040
3041 * xdisp.c (set_cursor_from_row): If the display string appears in
3042 the buffer at position that is closer to point than the position
3043 after the display string, display the cursor on the first glyph of
3044 the display string. Fixes cursor display when a 'display' text
3045 property immediately follows invisible text. (Bug#11094)
3046
3047 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3048
3049 composite.c: use 'double' consistently
3050 * composite.c (get_composition_id): Use 'double' consistently
3051 instead of converting 'float' to 'double' and vice versa; this is
3052 easier to understand and avoids a GCC warning.
3053
3054 2012-04-09 Glenn Morris <rgm@gnu.org>
3055
3056 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3057 preparation for dumping it with emacs. (Bug#4789)
3058 (leimdir): New variable.
3059 ($(leimdir)/leim-list.el): New rule.
3060 (emacs$(EXEEXT)): Depend on leim-list.el.
3061
3062 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3063 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3064 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3065
3066 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3067
3068 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3069 proper alignment.
3070
3071 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3072
3073 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3074 Remove unused local variable.
3075
3076 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3079 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3080 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3081 objects, as mark_maybe_pointer will catch them otherwise.
3082 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3083 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3084
3085 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3086
3087 Fix typo that broke non-Windows builds.
3088 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3089
3090 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3091
3092 Support building on MS-Windows with libxml2.
3093
3094 * makefile.w32-in (OBJ2): Add xml.$(O).
3095 (GLOBAL_SOURCES): Add xml.c.
3096 ($(BLD)/xml.$(O)): New dependency list.
3097
3098 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3099 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3100 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3101 [!WINDOWSNT]: New macros.
3102 (init_libxml2_functions, libxml2_loaded_p): New functions.
3103 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3104 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3105 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3106 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3107 linked in).
3108 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3109 Call init_libxml2_functions before calling libxml2 functions.
3110 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3111
3112 * emacs.c: Don't include libxml/parser.h.
3113 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3114 xmlCleanupParser directly.
3115
3116 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3117
3118 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3119
3120 * indent.c (Fvertical_motion): If there is a display string at
3121 point, use it.vpos to compute how many lines to backtrack after
3122 move_it_to point. (Bug#11133)
3123
3124 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3125
3126 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3127 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3128 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3129 macros related to unification of CJK characters. For the details,
3130 see the discussion following the message here:
3131 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3132
3133 2012-04-04 Chong Yidong <cyd@gnu.org>
3134
3135 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3136
3137 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3138
3139 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3140 instead of alloca. (Bug#11138)
3141
3142 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3143
3144 * w32menu.c (is_simple_dialog): Properly check lisp types.
3145 (Bug#11141)
3146
3147 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3148
3149 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3150 position we get to after a call to move_it_to fails the
3151 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3152 only if we wind up in a string from display property. (Bug#11063)
3153
3154 * window.c (Fdelete_other_windows_internal): Invalidate the row
3155 and column information about mouse highlight, so that redisplay
3156 restores it after reallocating the glyph matrices. (Bug#7464)
3157
3158 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3159 string comes from a `display' text property, use the buffer
3160 position of that property as if we actually saw that position in
3161 the row's glyphs.
3162 (move_it_by_lines): Remove the assertion that
3163 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3164 violated when there's a before-string at the beginning of a line.
3165 (Bug#11063)
3166
3167 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3168
3169 * xdisp.c (append_space_for_newline): If the default face was
3170 remapped, use the remapped face for the appended newline.
3171 (extend_face_to_end_of_line): Use the remapped default face for
3172 extending the face to the end of the line.
3173 (display_line): Call extend_face_to_end_of_line when the default
3174 face was remapped. (Bug#11068)
3175
3176 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3177
3178 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3179
3180 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3181
3182 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3183
3184 2012-03-27 Glenn Morris <rgm@gnu.org>
3185
3186 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3187 Doc fixes.
3188
3189 2012-03-26 Kenichi Handa <handa@m17n.org>
3190
3191 * dispextern.h (struct glyph): Fix previous change. Change the
3192 bit length of glyphless.ch to 25 (Bug#11082).
3193
3194 2012-03-26 Chong Yidong <cyd@gnu.org>
3195
3196 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3197 (command_loop_1): Use it; inhibit selection update for
3198 handle-select-window too (Bug#8996).
3199
3200 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3201
3202 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3203
3204 2012-03-25 Kenichi Handa <handa@m17n.org>
3205
3206 * dispextern.h (struct glyph): Change the bit length of
3207 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3208
3209 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3210
3211 * s/ms-w32.h (tzname): Include time.h before redirecting to
3212 _tzname. Fixes the MSVC build. (Bug#9960)
3213
3214 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3215
3216 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3217 characters.
3218
3219 * xterm.c (XTread_socket): Only modify handling_signal if
3220 !SYNC_INPUT. (Bug#11080)
3221
3222 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3223
3224 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3225 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3226 when fetching a multibyte character consumes more bytes than
3227 CHAR_BYTES returns, due to unification of CJK characters in
3228 string_char. (Bug#11073)
3229
3230 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3231
3232 * process.c (wait_reading_process_output): Handle pty disconnect
3233 by refraining from sending oneself a SIGCHLD (bug#10933).
3234
3235 2012-03-22 Chong Yidong <cyd@gnu.org>
3236
3237 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3238
3239 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3240 Mark string as coming from a prefix property.
3241 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3242 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3243
3244 2012-03-21 Chong Yidong <cyd@gnu.org>
3245
3246 * xfaces.c (Vface_remapping_alist): Doc fix.
3247
3248 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3249
3250 * w32proc.c (Fw32_set_console_codepage)
3251 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3252 Doc fixes.
3253
3254 2012-03-20 Chong Yidong <cyd@gnu.org>
3255
3256 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3257 to reflect default non-nil value of redisplay-dont-pause.
3258
3259 2012-03-19 Kenichi Handa <handa@m17n.org>
3260
3261 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3262 it fit in a valid range (Bug#11003).
3263
3264 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3265
3266 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3267 that is not from display property, accept the row as a "cursor
3268 row" if one of the string's character has a non-nil `cursor'
3269 property. Fixes cursor positioning when there are newlines in
3270 overlay strings, e.g. in icomplete.el. (Bug#11035)
3271
3272 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3275
3276 2012-03-12 Chong Yidong <cyd@gnu.org>
3277
3278 * eval.c (inhibit_lisp_code): Rename from
3279 inhibit_window_configuration_change_hook; move from window.c.
3280
3281 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3282 * window.c (run_window_configuration_change_hook)
3283 (syms_of_window): Callers changed.
3284
3285 2012-03-11 Chong Yidong <cyd@gnu.org>
3286
3287 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3288
3289 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3290
3291 2012-03-10 Chong Yidong <cyd@gnu.org>
3292
3293 * frame.c (other_visible_frames): Don't assume the selected frame
3294 is visible (Bug#10955).
3295
3296 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3297
3298 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3299
3300 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3301
3302 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3303 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3304 zero (Bug#10954).
3305
3306 2012-03-03 Glenn Morris <rgm@gnu.org>
3307
3308 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3309
3310 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3311
3312 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3313 position past the first glyph_row that ends at ZV. (Bug#10902)
3314 (redisplay_window, next_element_from_string): Fix typos in
3315 comments.
3316 (redisplay_window): Pass to move_it_vertically the margin in
3317 pixels, not in screen lines.
3318
3319 2012-03-02 Glenn Morris <rgm@gnu.org>
3320
3321 * buffer.c (buffer-list-update-hook): Doc fix.
3322
3323 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3324
3325 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3326 push_it before setting up the iterator for the first overlay
3327 string, even if we have an empty string loaded.
3328 (next_overlay_string): If there's an empty string on the iterator
3329 stack, pop the stack. (Bug#10903)
3330
3331 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3332
3333 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3334 Suggested by Stefan Monnier in
3335 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3336 * alloc.c (widen_to_Lisp_Object): New static function.
3337 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3338 and widening them to Lisp_Objects. This would work even if
3339 USE_LSB_TAG is defined and wide integers are used, which might
3340 happen in a future version of Emacs.
3341
3342 2012-02-25 Chong Yidong <cyd@gnu.org>
3343
3344 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3345 Doc fix.
3346
3347 * xselect.c (Fx_selection_exists_p): Doc fix.
3348 (x_clipboard_manager_save_all): Print an informative message
3349 before saving to clipboard manager.
3350
3351 2012-02-24 Chong Yidong <cyd@gnu.org>
3352
3353 * keyboard.c (process_special_events): Handle all X selection
3354 requests in kbd_buffer, not just the next one (Bug#8869).
3355
3356 2012-02-23 Chong Yidong <cyd@gnu.org>
3357
3358 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3359 call when setting menu-bar-lines and tool-bar-lines parameters.
3360 (unwind_create_frame_1): New helper function.
3361
3362 * window.c (inhibit_window_configuration_change_hook): New var.
3363 (run_window_configuration_change_hook): Obey it.
3364 (syms_of_window): Initialize it.
3365
3366 2012-02-22 Chong Yidong <cyd@gnu.org>
3367
3368 * xterm.c (x_draw_image_relief): Add missing type check for
3369 Vtool_bar_button_margin (Bug#10743).
3370
3371 2012-02-21 Chong Yidong <cyd@gnu.org>
3372
3373 * fileio.c (Vfile_name_handler_alist): Doc fix.
3374
3375 * buffer.c (Fget_file_buffer): Protect against invalid file
3376 handler return value.
3377
3378 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3381 when computing $valmask.
3382
3383 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3384 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3385 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3386 It's useless in that case, and it can cause problems on hosts
3387 that allocate halves of EMACS_INT values separately.
3388 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3389 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3390 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3391 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3392 it avoids undefined behavior on hosts where shifting right by more
3393 than the word width has undefined behavior.
3394
3395 2012-02-19 Chong Yidong <cyd@gnu.org>
3396
3397 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3398 (Funhandled_file_name_directory, Ffile_name_as_directory)
3399 (Fdirectory_file_name, Fexpand_file_name)
3400 (Fsubstitute_in_file_name): Protect against invalid file handler
3401 return values (Bug#10845).
3402
3403 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3404
3405 * .gdbinit (pitx): Fix incorrect references to fields of the
3406 iterator stack.
3407
3408 2012-02-17 Chong Yidong <cyd@gnu.org>
3409
3410 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3411
3412 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3413
3414 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3415 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3416
3417 2012-02-15 Chong Yidong <cyd@gnu.org>
3418
3419 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3420 marked as special. Also, starting docstrings with * is obsolete.
3421
3422 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3423
3424 * gnutls.c (emacs_gnutls_write): Fix last change.
3425
3426 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3427
3428 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3429 send_process.
3430
3431 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3432
3433 * keymap.c (Fsingle_key_description): Handle char ranges.
3434
3435 2012-02-12 Chong Yidong <cyd@gnu.org>
3436
3437 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3438 as that creates a dangerous corner case.
3439
3440 * window.c (Fdelete_window_internal): Invalidate the mouse
3441 highlight (Bug#9904).
3442
3443 2012-02-12 Glenn Morris <rgm@gnu.org>
3444
3445 * xselect.c (Fx_own_selection_internal)
3446 (Fx_get_selection_internal, Fx_disown_selection_internal)
3447 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3448 * nsselect.m (Fx_own_selection_internal)
3449 (Fx_disown_selection_internal, Fx_selection_exists_p)
3450 (Fx_selection_owner_p, Fx_get_selection_internal):
3451 Sync docs and argument specs with the xselect.c versions.
3452
3453 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3454
3455 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3456
3457 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3458
3459 * w32select.c (Fx_selection_exists_p): Sync doc string and
3460 argument list with xselect.c. (Bug#10783)
3461
3462 * w16select.c (Fx_selection_exists_p): Sync doc string and
3463 argument list with xselect.c. (Bug#10783)
3464
3465 2012-02-10 Glenn Morris <rgm@gnu.org>
3466
3467 * fns.c (Fsecure_hash): Doc fix.
3468
3469 2012-02-09 Kenichi Handa <handa@m17n.org>
3470
3471 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3472
3473 2012-02-07 Chong Yidong <cyd@gnu.org>
3474
3475 * buffer.c (Fbuffer_local_variables)
3476 (buffer_lisp_local_variables): Handle unbound vars correctly;
3477 don't let Qunbound leak into Lisp.
3478
3479 2012-02-07 Glenn Morris <rgm@gnu.org>
3480
3481 * image.c (Fimagemagick_types): Doc fix.
3482
3483 * image.c (imagemagick-render-type): Change it from a lisp object
3484 to an integer. Move the doc here from the lisp manual.
3485 Treat all values not equal to 0 the same.
3486
3487 2012-02-06 Chong Yidong <cyd@gnu.org>
3488
3489 * doc.c (store_function_docstring): Avoid applying docstring of
3490 alias to base function (Bug#2603).
3491
3492 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3493
3494 * .gdbinit (pp1, pv1): Remove redundant defines.
3495 (pr): Use pp.
3496
3497 2012-02-04 Chong Yidong <cyd@gnu.org>
3498
3499 * nsterm.m: Declare a global (Bug#10694).
3500
3501 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3502
3503 * w32.c (get_emacs_configuration_options):
3504 Include --enable-checking, if specified, in the return value.
3505
3506 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3507
3508 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3509 after rounding frame sizes. (Bug#9723)
3510
3511 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3512
3513 * keyboard.c (adjust_point_for_property): Don't position point
3514 before BEGV. (Bug#10696)
3515
3516 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3517
3518 Handle overflow when computing char display width (Bug#9496).
3519 * character.c (char_width): Return EMACS_INT, not int.
3520 (char_width, c_string_width): Check for overflow when
3521 computing the width; this is possible now that individual
3522 characters can have unbounded width. Problem introduced
3523 by merge from Emacs 23 on 2012-01-19.
3524
3525 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3526
3527 * dbusbind.c (Fdbus_register_method): Mention the return value
3528 :ignore in the docstring.
3529
3530 2012-02-02 Glenn Morris <rgm@gnu.org>
3531
3532 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3533
3534 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3535 Unconditionally set to t. (Bug#10673)
3536 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3537 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3538 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3539
3540 2012-02-02 Kenichi Handa <handa@m17n.org>
3541
3542 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3543 0, do not call append_composite_glyph.
3544
3545 2012-02-02 Kenichi Handa <handa@m17n.org>
3546
3547 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3548 NULL (Bug#6988).
3549 (x_produce_glyphs): If the component of a composition is a null
3550 string, set it->pixel_width to 1 to avoid zero-width glyph.
3551
3552 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3553
3554 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3555 first 2 arguments are identical. This makes inserting large
3556 output from a subprocess an order of magnitude faster on
3557 MS-Windows, where all sbrk'ed memory is always contiguous.
3558
3559 2012-01-31 Glenn Morris <rgm@gnu.org>
3560
3561 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3562 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3563 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3564
3565 2012-01-29 Glenn Morris <rgm@gnu.org>
3566
3567 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3568
3569 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3570
3571 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3572
3573 2012-01-28 Chong Yidong <cyd@gnu.org>
3574
3575 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3576
3577 2012-01-26 Chong Yidong <cyd@gnu.org>
3578
3579 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3580
3581 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3582 repeat counts (Bug#10507).
3583
3584 2012-01-26 Glenn Morris <rgm@gnu.org>
3585
3586 * lread.c (syms_of_lread): Doc fix.
3587
3588 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3589
3590 * coding.c (encode_designation_at_bol): Change return value to
3591 EMACS_INT.
3592
3593 2012-01-25 Chong Yidong <cyd@gnu.org>
3594
3595 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3596
3597 2012-01-21 Chong Yidong <cyd@gnu.org>
3598
3599 * floatfns.c (Fcopysign): Make the second argument non-optional,
3600 since nil is not allowed anyway.
3601
3602 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3603
3604 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3605 (send_process): Likewise.
3606
3607 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3608
3609 * window.c (save_window_save, Fcurrent_window_configuration)
3610 (Vwindow_persistent_parameters): Do not use Qstate.
3611 Rewrite doc-strings.
3612
3613 2012-01-19 Kenichi Handa <handa@m17n.org>
3614
3615 * character.c (char_width): New function.
3616 (Fchar_width, c_string_width, lisp_string_width):
3617 Use char_width (Bug#9496).
3618
3619 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3620
3621 * window.c (Vwindow_persistent_parameters): New variable.
3622 (Fset_window_configuration, save_window_save): Handle persistent
3623 window parameters.
3624
3625 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3626
3627 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3628 thrashing the stack of the thread. (Bug#9087)
3629
3630 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3633
3634 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3635
3636 * xdisp.c (rows_from_pos_range): Handle the case where the
3637 highlight ends on a newline. (Bug#10464)
3638 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3639 he end column for display of highlight that ends on a newline
3640 before a R2L line.
3641
3642 2012-01-11 Glenn Morris <rgm@gnu.org>
3643
3644 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3645 from load-path also when installation-directory is nil. (Bug#10208)
3646
3647 2012-01-10 Glenn Morris <rgm@gnu.org>
3648
3649 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3650
3651 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3652 Update template values to be closer to their typical values these days.
3653
3654 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3655
3656 * xdisp.c (rows_from_pos_range): Accept additional argument
3657 DISP_STRING, and accept any glyph in a row whose object is that
3658 string as eligible for mouse highlight. Fixes mouse highlight of
3659 display strings from overlays. (Bug#10464)
3660
3661 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 emacs: fix an auto-save permissions race condition (Bug#10400)
3664 * fileio.c (auto_saving_dir_umask): New static var.
3665 (Fmake_directory_internal): Use it.
3666 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3667 creating the directory. The old code temporarily assigns
3668 too-generous permissions to the directory.
3669 (do_auto_save_eh): Clear it.
3670 (Fdo_auto_save): Catch all errors, not just file errors, so
3671 that the var is always cleared.
3672
3673 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3674
3675 * search.c (scan_buffer): Pass character positions to
3676 know_region_cache, not byte positions. (Bug#6540)
3677
3678 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3679
3680 * w32.c (sys_rename): Report EXDEV when rename of a directory
3681 fails because the target is on another logical disk. (Bug#10284)
3682
3683 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3684
3685 * xterm.c (x_embed_request_focus): New function.
3686
3687 * xterm.h: Add prototype.
3688
3689 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3690
3691 2012-01-05 Glenn Morris <rgm@gnu.org>
3692
3693 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3694
3695 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3696
3697 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3698 Load gnutls_transport_set_lowat only if GnuTLS version is below
3699 2.11.1.
3700 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3701 GnuTLS versions below 2.11.1.
3702
3703 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3704
3705 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3706 to the doc string advising against its use for altering the way
3707 windows are scrolled.
3708
3709 2011-12-28 Kenichi Handa <handa@m17n.org>
3710
3711 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3712 coding-system ASCII compatible only when it does not produce BOM
3713 on encoding (Bug#10383).
3714
3715 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3716
3717 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3718 can scroll.
3719 (create_and_show_popup_menu): Always use menu_position_func for
3720 Gtk3 (Bug#10361).
3721
3722 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3723
3724 * callint.c (Fcall_interactively): Don't truncate prompt string.
3725
3726 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3727
3728 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3729 property that ends at ZV, so that the bidi iteration could be
3730 resumed from there (after widening). (Bug#10360)
3731
3732 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3733
3734 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3735
3736 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3737
3738 * nsterm.m (x_free_frame_resources):
3739 Release f->output_data.ns->miniimage.
3740 (ns_index_color): Fix indentation. Do not retain
3741 color_table->colors[i].
3742
3743 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3744 before returning.
3745
3746 * nsfns.m (x_set_background_color): Assign return value from
3747 ns_index_color to face-background instead of NSColor*.
3748 (ns_implicitly_set_icon_type): Fix indentation.
3749 Change assignment in for loop to comparison.
3750
3751 * emacs.c (ns_pool): New variable.
3752 (main): Assign ns_pool.
3753 (Fkill_emacs): Call ns_release_autorelease_pool.
3754
3755 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3756 autorelease fdesc, release fdAttrs and tdict.
3757 (ns_get_covering_families): Release charset.
3758 (ns_findfonts): Release NSFontDescriptor created with new.
3759 (ns_uni_to_glyphs): Fix indentation.
3760 (setString): Release attrStr before assigning new value.
3761
3762 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3763
3764 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3765 and NS_IMPL_COCOA.
3766 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3767 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3768
3769 2011-12-18 David Reitter <reitter@cmu.edu>
3770
3771 * nsterm.m (ns_term_init): Subscribe for notifications
3772 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3773 to method trackingNotification in EmacsMenu.
3774
3775 * nsmenu.m (trackingMenu): New variable.
3776 (trackingNotification): New method (from Aquamacs).
3777 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3778 from Aquamacs (Bug#7030).
3779
3780 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3781
3782 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3783 (symbol_to_nsstring): Fix indentation.
3784 (ns_symbol_to_pb): New function.
3785 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3786 (Fns_rotate_cut_buffers_internal): Remove.
3787 (Fns_store_selection_internal): Rename from
3788 Fns_store_cut_buffer_internal.
3789 (ns_get_foreign_selection, Fx_own_selection_internal)
3790 (Fx_disown_selection_internal, Fx_selection_exists_p)
3791 (Fns_get_selection_internal, Fns_store_selection_internal):
3792 Use ns_symbol_to_pb and check if return value is nil.
3793 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3794 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3795 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3796 renamed to Sns_store_selection_internal.
3797 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3798 and remove this function.
3799 (ns_handle_selection_clear): Remove, never used.
3800 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3801 here.
3802
3803 2011-12-17 Ken Brown <kbrown@cornell.edu>
3804
3805 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3806 GID is unknown (Bug#10257).
3807
3808 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3809
3810 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3811 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3812 which caused a build failure on GNU/Linux IA-64. This problem was
3813 introduced by my 2011-10-07 patch.
3814
3815 2011-12-15 Juri Linkov <juri@jurta.org>
3816
3817 * image.c (imagemagick_error): New function. (Bug#10112)
3818 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3819 Use `imagemagick_error' where ImageMagick functions return
3820 `MagickFalse'.
3821 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3822 proper order.
3823
3824 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3825
3826 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3827 fill background (Bug#8992).
3828
3829 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3830
3831 * window.c (Vwindow_combination_resize)
3832 (Vwindow_combination_limit): Use t instead of non-nil in
3833 doc-strings.
3834 (Vrecenter_redisplay): Add first sentence of doc-string on
3835 separate line.
3836 (Frecenter): Fix doc-string typo.
3837
3838 2011-12-11 Kenichi Handa <handa@m17n.org>
3839
3840 * coding.c (Funencodable_char_position): Pay attention to the
3841 buffer text relocation (Bug#9389).
3842
3843 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3844
3845 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3846 gtk_init (Bug#10100).
3847
3848 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3849
3850 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3851 IT->string is nil. (Bug#10263)
3852
3853 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3854
3855 * nsterm.h (x_free_frame_resources): Declare.
3856
3857 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3858 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3859
3860 * nsterm.h (ns_get_defaults_value): Declare.
3861
3862 * nsterm.m (ns_default): Call ns_get_defaults_value.
3863
3864 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3865
3866 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3867 (Bug#10170)
3868
3869 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3870
3871 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3872 that where the value of an _OBJC_* symbol points to is in the .bss
3873 section (Bug#10240).
3874
3875 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3876
3877 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3878 after the loop to call ccl_driver at least once (Bug#8619).
3879
3880 2011-12-08 Kenichi Handa <handa@m17n.org>
3881
3882 * ftfont.c (get_adstyle_property): Fix previous change
3883 (Bug#10233).
3884
3885 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3886
3887 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3888 dirs from the default value of EMACSLOADPATH (bug#10208).
3889
3890 2011-12-07 Glenn Morris <rgm@gnu.org>
3891
3892 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3893 installation and source directories as well. (Bug#10208)
3894
3895 2011-12-06 Chong Yidong <cyd@gnu.org>
3896
3897 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3898
3899 2011-12-06 Glenn Morris <rgm@gnu.org>
3900
3901 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3902 as an error, not just -1. (Bug#10217)
3903
3904 2011-12-05 Chong Yidong <cyd@gnu.org>
3905
3906 * keyboard.c (process_special_events): New function.
3907 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3908
3909 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 * coding.c (encode_designation_at_bol): Don't use uninitialized
3912 local variable (Bug#9318).
3913
3914 2011-12-05 Kenichi Handa <handa@m17n.org>
3915
3916 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3917 return Qnil (Bug#8046, Bug#10193).
3918
3919 2011-12-05 Kenichi Handa <handa@m17n.org>
3920
3921 * coding.c (encode_designation_at_bol): New args charbuf_end and
3922 dst. Return the number of produced bytes. Callers changed.
3923 (coding_set_source): Return how many bytes coding->source was
3924 relocated.
3925 (coding_set_destination): Return how many bytes
3926 coding->destination was relocated.
3927 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3928 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3929
3930 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3931
3932 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3933 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3934 macro (Bug#9318).
3935
3936 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3937
3938 The following changes are to fix Bug#9318.
3939
3940 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3941 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3942 (encode_coding_iso_2022, encode_coding_sjis)
3943 (encode_coding_big5, encode_coding_charset): Use the above macros.
3944
3945 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3946
3947 * lisp.h (process_quit_flag): Fix external declaration.
3948
3949 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3950
3951 Don't macro-inline non-performance-critical code.
3952 * eval.c (process_quit_flag): New function.
3953 * lisp.h (QUIT): Use it.
3954
3955 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3956
3957 * nsfns.m (get_geometry_from_preferences): New function.
3958 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3959
3960 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3961
3962 * emacs.c (Qkill_emacs): Define.
3963 (syms_of_emacs): Initialize it.
3964 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3965 Qquit_flag to `kill-emacs' instead.
3966 (quit_throw_to_read_char): Add parameter `from_signal'.
3967 All callers changed. Call Fkill_emacs if requested and safe.
3968 * lisp.h (QUIT): Call Fkill_emacs if requested.
3969
3970 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3971
3972 * widget.c (update_wm_hints): Return if wmshell is null.
3973 (widget_update_wm_size_hints): New function.
3974
3975 * widget.h (widget_update_wm_size_hints): Declare.
3976
3977 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3978 widget_update_wm_size_hints (Bug#10104).
3979
3980 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3981
3982 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3983 before a newline, prepare the bidi iterator for consuming the
3984 newline, and keep the current paragraph direction. (Bug#10183)
3985 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3986
3987 2011-12-02 Juri Linkov <juri@jurta.org>
3988
3989 * search.c (Fword_search_regexp): New Lisp function created from
3990 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3991 (Fword_search_backward, Fword_search_forward)
3992 (Fword_search_backward_lax, Fword_search_forward_lax):
3993 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3994 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3995
3996 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3997
3998 * fileio.c (Finsert_file_contents): Move after-change-function call
3999 to before the "handled:" label, since all "goto handled" appear in
4000 cases where the *-change-functions have already been properly called
4001 (bug#10117).
4002
4003 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4004
4005 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4006 waiting for input. (Bug#10169)
4007
4008 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4009
4010 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4011 verifies glyph row's hash code--we have just reallocated the
4012 glyphs, so their contents can be complete garbage. (Bug#10164)
4013
4014 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4015
4016 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4017
4018 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4019
4020 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4021 attributes are tested _before_ calling verify_row_hash, to protect
4022 against GCC re-ordering of the tests. (Bug#10164)
4023
4024 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4025
4026 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4027
4028 * xterm.c (handle_one_xevent): Only set async_visible and friends
4029 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4030 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4031 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4032
4033 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4034
4035 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4036 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4037 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4038 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4039 All uses changed to use GCPRO1 etc.
4040 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4041 Revert to old implementation (i.e., before 2011-03-11).
4042
4043 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4044
4045 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4046 of scroll runs so as to avoid assigning disabled bogus rows and
4047 unnecessary graphics copy operations.
4048
4049 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4050
4051 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4052 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4053 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4054 (malloc, free, realloc, calloc): Redirect to e_* only when
4055 compiling Emacs.
4056
4057 * lisp.h (GCTYPEBITS): Move before first use.
4058 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4059 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4060 this macro definition.
4061
4062 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4063 _MSC_VER.
4064
4065 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4066
4067 * gtkutil.c (xg_create_frame_widgets):
4068 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4069 present with Gtk+ 2.0.
4070
4071 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 * fileio.c (Finsert_file_contents): Undo previous change; see
4074 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4075
4076 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 Rename locals to avoid shadowing.
4079 * fileio.c (Finsert_file_contents):
4080 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4081 * process.c (wait_reading_process_output):
4082 Rename inner 'proc' to 'p' to avoid shadowing.
4083 Indent for consistency with usual Emacs style.
4084
4085 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4086
4087 * xdisp.c (redisplay_window): If cursor row is not fully visible
4088 after recentering, and scroll-conservatively is set to a large
4089 number, scroll window by a few more lines to make the cursor fully
4090 visible and out of scroll-margin. (Bug#10105)
4091 (start_display): Don't move to the next line if the display should
4092 start at a newline that is part of a display vector or an overlay
4093 string. (Bug#10119)
4094
4095 2011-11-24 Juri Linkov <juri@jurta.org>
4096
4097 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4098 after the `MagickPingImage' call. (Bug#10112)
4099
4100 2011-11-23 Chong Yidong <cyd@gnu.org>
4101
4102 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4103
4104 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4105
4106 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4107 making another buffer current. (Bug#10114)
4108
4109 2011-11-23 Glenn Morris <rgm@gnu.org>
4110
4111 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4112
4113 2011-11-23 Chong Yidong <cyd@gnu.org>
4114
4115 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4116 using it (Bug#5984).
4117
4118 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4119
4120 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4121 and header-lines, as they don't have one computed for them.
4122 (Bug#10098)
4123
4124 * .gdbinit (prow): Make displayed values more self-explaining.
4125 Add row's hash code.
4126
4127 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4128
4129 * process.c (wait_reading_process_output): Fix asynchrounous
4130 GnuTLS socket handling on some versions of the GnuTLS library.
4131 (wait_reading_process_output): Add comment and URL.
4132
4133 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4134
4135 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4136
4137 2011-11-21 Chong Yidong <cyd@gnu.org>
4138
4139 * window.c (Fnext_window, Fprevious_window): Doc fix.
4140
4141 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4142
4143 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4144
4145 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4146
4147 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4148
4149 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4150
4151 * window.c (Fset_window_combination_limit): Rename argument
4152 STATUS to LIMIT.
4153 (Vwindow_combination_limit): Remove "status" from doc-string.
4154
4155 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4156
4157 * m/ibms390.h: Remove.
4158 * m/ibms390x.h: Don't include "ibms390.h".
4159
4160 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4161
4162 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4163 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4164
4165 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4166
4167 * casetab.c (Fset_case_table):
4168 * charset.c (Fcharset_after): Fix typos.
4169
4170 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4173 Otherwise, valgrind does not work on some platforms.
4174 Problem reported by Andreas Schwab in
4175 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4176 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4177 is set, removing the need for VIRT_ADDRESS_VARIES.
4178 (PURE_P): Use a more-efficient implementation that needs just one
4179 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4180 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4181 to 4 (xorl, subq, cmpq, setbe).
4182 * alloc.c (pure): Always extern now, since that's the
4183 VIRT_ADDR_VARIES behavior.
4184 (PURE_POINTER_P): Use a single comparison, not two, for
4185 consistency with the new puresize.h.
4186 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4187 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4188 Remove VIRT_ADDR_VARIES no longer needed.
4189
4190 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4191
4192 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4193 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4194 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4195 behave as if the cursor position were at the window margin.
4196
4197 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4198 and the cursor position is out of bounds, behave as if the cursor
4199 position were at the window margin. (Bug#10075)
4200
4201 2011-11-18 Chong Yidong <cyd@gnu.org>
4202
4203 * window.c (Fwindow_combination_limit): Make first argument
4204 non-optional, since it is meaningless for live windows like the
4205 selected window.
4206
4207 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4208
4209 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4210
4211 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4212
4213 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4214 (graft_intervals_into_buffer): Simplify.
4215
4216 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4217
4218 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4219 hash values of the two rows.
4220 (copy_row_except_pointers): Preserve the used[] arrays and the
4221 hash values of the two rows. (Bug#10035)
4222 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4223
4224 * xdisp.c (row_hash): New function, body extracted from
4225 compute_line_metrics.
4226 (compute_line_metrics): Call row_hash, instead of computing the
4227 hash code inline.
4228
4229 * dispnew.c (verify_row_hash): Call row_hash for computing the
4230 hash code of a row, instead of duplicating code from xdisp.c.
4231
4232 * dispextern.h (row_hash): Add prototype.
4233
4234 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4235
4236 * frame.c (delete_frame): Don't delete the terminal when the last
4237 X frame is closed if emacs is built with GTK toolkit.
4238
4239 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4242
4243 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4244
4245 * window.c (Vwindow_splits): Rename to
4246 Vwindow_combination_resize. Suggested by Juri Linkov.
4247 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4248 of Vwindow_splits.
4249
4250 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * nsfns.m (Fns_font_name):
4253 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4254
4255 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4256
4257 * window.h (window): Rename slot "nest" to "combination_limit".
4258 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4259 (Fset_window_nest): Rename to Fset_window_combination_limit.
4260 (Vwindow_nest): Rename to Vwindow_combination_limit.
4261 (recombine_windows, make_parent_window, make_window)
4262 (Fsplit_window_internal, saved_window)
4263 (Fset_window_configuration, save_window_save): Rename all
4264 occurrences of window_nest to window_combination_limit.
4265
4266 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * image.c (imagemagick_load_image): Fix typo.
4269
4270 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4271
4272 * xdisp.c (display_line): Move the call to
4273 highlight_trailing_whitespace before the call to
4274 compute_line_metrics, since the latter needs to see the final
4275 faces of all the glyphs to compute ROW's hash value.
4276 Fixes assertion violations in row_equal_p. (Bug#10035)
4277
4278 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4281 just return (bug#10044).
4282
4283 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4284
4285 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4286 with user-defined heap size. Bump the default size of the temacs
4287 heap to 27MB, to avoid memory warning when running temacs.
4288 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4289
4290 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4291 current_matrix and desired_matrix. (Bug#9990)
4292 (verify_row_hash) [XASSERTS]: New function.
4293 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4294 that the hash value of glyph rows is correct.
4295
4296 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4297
4298 * window.h (window): Remove splits slot.
4299 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4300 (Fdelete_other_windows_internal, make_parent_window)
4301 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4302 (Fset_window_configuration, save_window_save): Don't deal with
4303 split status of windows.
4304 (saved_window): Remove splits slot.
4305 (Vwindow_splits): Rewrite doc-string.
4306
4307 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4308
4309 * xfns.c (unwind_create_frame):
4310 * nsfns.m (unwind_create_frame):
4311 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4312 Vframe_list (Bug#9999).
4313
4314 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4315
4316 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4317
4318 2011-11-11 Kenichi Handa <handa@m17n.org>
4319
4320 * callproc.c (Fcall_process): Set the member dst_multibyte of
4321 process_coding.
4322
4323 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4324
4325 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4326 avoid a crash (bug#9496).
4327
4328 2011-11-09 Chong Yidong <cyd@gnu.org>
4329
4330 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4331 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4332
4333 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4334
4335 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4336
4337 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 Avoid some portability problems by eschewing 'extern inline' functions.
4340 The trivial performance wins aren't worth the portability hassles; see
4341 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4342 et seq.
4343 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4344 (window_box_width, window_box_left, window_box_left_offset)
4345 (window_box_right, window_box_right_offset): Undo previous change,
4346 by removing the "extern"s.
4347 * intervals.c (adjust_intervals_for_insertion)
4348 (adjust_intervals_for_deletion): Undo previous change,
4349 making these static again.
4350 (offset_intervals, temp_set_point_both, temp_set_point)
4351 (copy_intervals_to_string): No longer inline.
4352 * xdisp.c (window_text_bottom_y, window_box_width)
4353 (window_box_height, window_box_left_offset)
4354 (window_box_right_offset, window_box_left, window_box_right)
4355 (window_box): No longer inline.
4356
4357 2011-11-08 Chong Yidong <cyd@gnu.org>
4358
4359 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4360 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4361 Signal an error if not a live window.
4362 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4363 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4364
4365 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4366
4367 * lisp.h (syms_of_abbrev): Remove declaration.
4368 Reported by CHENG Gao <chenggao@royau.me>.
4369
4370 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4371
4372 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4373 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4374 of temacs in GUI mode.
4375
4376 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4377
4378 * window.h: Declare delete_all_child_windows instead of
4379 delete_all_subwindows.
4380 * window.c (Fwindow_nest, Fset_window_nest)
4381 (Fset_window_new_total, Fset_window_new_normal)
4382 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4383 (delete_all_subwindows): Rename to delete_all_child_windows.
4384 (Fdelete_other_windows_internal, Fset_window_configuration):
4385 Call delete_all_child_windows instead of delete_all_subwindows.
4386 * frame.c (delete_frame): Call delete_all_child_windows instead
4387 of delete_all_subwindows.
4388
4389 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4392 This is also needed for porting to any host where GC_MARK_STACK is
4393 not GC_MAKE_GCPROS_NOOPS.
4394 (which_symbols): Use it.
4395
4396 2011-11-07 Kenichi Handa <handa@m17n.org>
4397
4398 * coding.c (coding_set_destination): Check coding->src_pos only
4399 when coding->src_object is a buffer (bug#9910).
4400
4401 * process.c (send_process): Set the member src_multibyte of coding
4402 to 0 (bug#9911) when sending a unibyte text.
4403
4404 * callproc.c (Fcall_process): Set the member src_multibyte of
4405 process_coding to 0 (bug#9912).
4406
4407 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4408
4409 * xmenu.c (cleanup_widget_value_tree): New function.
4410 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4411 calling free_menubar_widget_value_tree directly (Bug#9830).
4412
4413 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 Fix some portability problems with 'inline'.
4416 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4417 (window_box_width, window_box_left, window_box_left_offset)
4418 (window_box_right, window_box_right_offset): Declare extern.
4419 Otherwise, these inline functions do not conform to C99 and
4420 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4421 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4422 * intervals.c (adjust_intervals_for_insertion)
4423 (adjust_intervals_for_deletion): Now extern, because otherwise the
4424 extern inline functions 'offset_intervals' couldn't refer to it.
4425 (static_offset_intervals): Remove.
4426 (offset_intervals): Rewrite using the old contents of
4427 static_offset_intervals. The old version didn't conform to C99
4428 because an extern inline function contained a reference to an
4429 identifier with static linkage.
4430
4431 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4432
4433 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4434 GC.
4435
4436 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4437
4438 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4439 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4440 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4441 return Qleft_to_right.
4442
4443 2011-11-06 Chong Yidong <cyd@gnu.org>
4444
4445 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4446 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4447 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4448 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4449 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4450 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4451 (Fwindow_vscroll): Doc fix.
4452 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4453 argument, since it makes no sense to pass a live window and for
4454 consistency with window-child.
4455
4456 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4457
4458 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4459 support MSVC.
4460
4461 2011-11-05 Jason Rumney <jasonr@gnu.org>
4462
4463 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4464 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4465 fonts (Bug#6029).
4466 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4467 bitwise arithmetic preventing use of unicode-sip and non-truetype
4468 opentype fonts.
4469
4470 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4471
4472 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4473 "emacs"-only part.
4474
4475 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4476 initialization code to keep similarity to xfns.c after changes
4477 from 2011-11-05.
4478
4479 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4480
4481 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4482 (unwind_create_frame): New function (Bug#9943).
4483 (Fx_create_frame): Restructure code to be more similar to the one in
4484 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4485 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4486 Move terminal->reference_count++ just before making the frame official
4487 (Bug#9943).
4488
4489 * nsterm.m (x_free_frame_resources): New function.
4490 (x_destroy_window): Move code to x_free_frame_resources.
4491
4492 * xfns.c (unwind_create_frame): Fix comment.
4493 (Fx_create_frame, x_create_tip_frame):
4494 Move terminal->reference_count++ just before making the frame
4495 official. Move initialization of image_cache_refcount and
4496 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4497
4498 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4499
4500 Support MSVC build with newer versions of Visual Studio.
4501 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4502 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4503 nt/gmake.defs.
4504
4505 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4506 which are not supported by MSVC.
4507 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4508 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4509 bitfields.
4510 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4511 types in bitfields.
4512 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4513
4514 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4515
4516 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4517
4518 Support MSVC build with newer versions of Visual Studio.
4519 * w32.c: Don't include w32api.h for MSVC.
4520 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4521
4522 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4523 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4524 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4525 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4526 e_* cousins.
4527 (alloca) [_MSC_VER]: Define to _alloca.
4528
4529 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4530
4531 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4532
4533 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4534
4535 * xdisp.c (note_mouse_highlight): If either of
4536 previous/next-single-property-change returns nil, treat that as
4537 the beginning or the end of the buffer. (Bug#9955)
4538
4539 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4540
4541 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4542 label is not null (Bug#9951).
4543 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4544 may be NULL.
4545
4546 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4547
4548 * window.c (Fwindow_body_size): Mention in the doc string that the
4549 return value is in frame's canonical units. (Bug#9949)
4550
4551 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4552
4553 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4554
4555 * w32fns.c (unwind_create_frame): If needed, free the glyph
4556 matrices of the partially constructed frame. (Bug#9943)
4557 * xfns.c (unwind_create_frame): Likewise.
4558
4559 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4560
4561 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4562 Don't stop backward scan on the continuation glyph, even though
4563 its CHARPOS is positive.
4564 (mouse_face_from_buffer_pos, note_mouse_highlight):
4565 Rename cover_string to disp_string.
4566
4567 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4568
4569 * window.c (temp_output_buffer_show): Don't use
4570 Vtemp_buffer_show_specifiers.
4571 (Vtemp_buffer_show_specifiers): Remove unused variable.
4572
4573 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4574
4575 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4576 past the beginning of the current glyph matrix.
4577
4578 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4579
4580 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4581 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4582 HAVE_GTK3 (Bug#9869).
4583
4584 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4585 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4586
4587 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4588
4589 * xterm.c: Declare x_handle_net_wm_state to return int.
4590 (handle_one_xevent): Check if we are iconified but don't have
4591 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4592 (get_current_wm_state): Return non-zero if not hidden,
4593 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4594 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4595 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4596 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4597
4598 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4601 so that this new function doesn't get optimized away by a
4602 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4603
4604 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4605
4606 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4607
4608 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4609
4610 Fix the `xbytecode' command.
4611 * .gdbinit (xprintbytestr): New command.
4612 (xwhichsymbols): Rename from `which'; all callers changed.
4613 (xbytecode): Print the byte-code string as well.
4614
4615 2011-10-29 Kim Storm <storm@cua.dk>
4616
4617 * alloc.c (which_symbols): New function.
4618
4619 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4620
4621 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4622 line. (Bug#9903)
4623
4624 2011-10-29 Glenn Morris <rgm@gnu.org>
4625
4626 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4627 Not clear what it was for, and it causes various bugs. (Bug#9839)
4628
4629 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4630
4631 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4632 possible random value that matches one of those tested as
4633 condition to clear the mouse face.
4634
4635 2011-10-28 Chong Yidong <cyd@gnu.org>
4636
4637 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4638
4639 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4640
4641 * window.c (make_window): Initialize phys_cursor_on_p.
4642
4643 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4644
4645 * lisp.h (struct Lisp_Symbol): Update comments.
4646
4647 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4648
4649 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4650
4651 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4652
4653 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4654 <oslsachem@gmail.com> for helping to debug this.
4655
4656 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4657 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4658 (g_b_init_get_glyph_outline_w): New static variables.
4659 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4660 (GetGlyphOutlineW_Proc): New typedefs.
4661 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4662 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4663 New functions.
4664 (w32font_open_internal, compute_metrics):
4665 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4666 instead of calling the "wide" APIs directly.
4667
4668 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4669
4670 * w32.h (syms_of_w32font): Add prototype.
4671
4672 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4673
4674 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4675 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4676 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4677 (Fmove_to_window_line): Doc fix.
4678
4679 2011-10-27 Chong Yidong <cyd@gnu.org>
4680
4681 * process.c (make_process): Set gnutls_state to NULL.
4682
4683 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4684 non-NULL, regardless of GNUTLS_INITSTAGE.
4685 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4686 an error. Set process slots as soon as we allocate them.
4687
4688 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4689
4690 2011-10-27 Chong Yidong <cyd@gnu.org>
4691
4692 * gnutls.c (emacs_gnutls_deinit): New function.
4693 Deallocate credentials structures as well as calling gnutls_deinit.
4694 (Fgnutls_deinit, Fgnutls_boot): Use it.
4695
4696 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4697 (deactivate_process): Call emacs_gnutls_deinit.
4698
4699 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4700
4701 * image.c (x_create_x_image_and_pixmap):
4702 * w32.c (sys_rename, w32_delayed_load):
4703 * w32font.c (fill_in_logfont):
4704 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4705
4706 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4707
4708 * w32fns.c (w32_default_color_map): New function,
4709 extracted from Fw32_default_color_map.
4710 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4711
4712 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4713
4714 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4715
4716 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4717
4718 * keyboard.c (test_undefined): New function (bug#9751).
4719 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4720
4721 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4722
4723 * sysdep.c (init_sys_modes): Fix the check for the controlling
4724 terminal (Bug#6649).
4725
4726 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4727
4728 * dispextern.h (struct bidi_it): New member next_en_type.
4729
4730 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4731 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4732 current character, check also for next_en_type being WEAK_EN.
4733 (bidi_resolve_weak): Don't enter the expensive loop if the current
4734 position is before next_en_pos. Record the bidi type of the first
4735 non-ET, non-BN character we find, in addition to its position.
4736 (bidi_level_of_next_char): Invalidate next_en_type when
4737 next_en_pos is over-stepped.
4738
4739 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4740
4741 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4742 * editfns.c: Rewrite current-time-zone so that it invokes
4743 the equivalent of (format-time-string "%Z") to get the time zone name.
4744 This fixes a bug when the time zone name contains characters that
4745 need converting from the system time locale to Emacs internal format.
4746 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4747 that patch fixed format-time-string to do the conversion, but
4748 I forgot to fix current-time-zone.
4749 (format_time_string): New function, containing most of
4750 what Fformat_time_string used to contain.
4751 (Fformat_time_string): Rewrite in terms of format_time_string.
4752 This doesn't change this function's behavior.
4753 (current-time-zone): Rewrite to use format_time_string.
4754 This fixes the bug reported by Michael Schierl in
4755 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4756 Jason Rumney's 2007-06-07 change worked around this bug, but
4757 didn't fix it.
4758 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4759
4760 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4761
4762 * xdisp.c (start_display): If the character at POS is displayed
4763 via a display vector, reset IT->current.dpvec_index to zero.
4764 (try_window_reusing_current_matrix): If a line ends in a display
4765 vector or the next line starts in a display vector, continue
4766 redrawing the window even though the character position of
4767 start_row was reached.
4768 (Bug#9771, part 2)
4769
4770 2011-10-18 Chong Yidong <cyd@gnu.org>
4771
4772 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4773 with nobreak-char-display too.
4774
4775 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4776
4777 Fix part 3 of bug#9771.
4778 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4779 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4780 non-neutral characters if the current character is a paragraph
4781 separator (a.k.a. Newline). This avoids running the same
4782 expensive loop twice, once when we consume the preceding newline
4783 and the other time when the line actually needs to be displayed.
4784 Avoid the loop when we see neutrals on the base embedding level
4785 following a character whose directionality is the same as the
4786 paragraph's. This avoids running the expensive loop when a line
4787 ends in a long sequence of neutrals, like control characters.
4788 Add assertion against STRONG_AL type. Slightly rearrange code
4789 that determines the type of a neutral given the first non-neutral
4790 that follows it.
4791 (bidi_level_of_next_char): Set next_en_pos to zero when
4792 invalidating its info.
4793
4794 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4795
4796 * xdisp.c (push_display_prop): Determine whether to record string
4797 or buffer position by IT->string, not by IT->method. Allow
4798 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4799 (move_it_vertically_backward): Don't look for character position
4800 immediately after the newline when in a continuation line.
4801 (Bug#9771, part 1)
4802
4803 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4804
4805 * window.c (coordinates_in_window): Rewrite and delabelize
4806 vertical border check. (Bug#5357) (Bug#9618)
4807
4808 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4809
4810 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4811 errors in XSetWindowBorder (bug#9310).
4812
4813 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4814
4815 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4816 avoid crash when xmalloc overrun checking is enabled.
4817
4818 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4819
4820 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4821 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4822 cursor motion with <left> and <right> arrow keys.
4823
4824 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4825 some callers set that themselves.
4826
4827 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4828
4829 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4830 display string and the previous row comes from the same string and
4831 is empty. (Bug#9739) (Bug#9738)
4832
4833 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4834
4835 * doc.c (get_doc_string): Encode file name (bug#9735).
4836
4837 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4838
4839 * bidi.c (bidi_level_of_next_char):
4840 * xdisp.c (get_visually_first_element): Remove old incorrect
4841 comments regarding the Unicode Line Separator character.
4842
4843 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4844
4845 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4846
4847 * alloc.c (Fgc_status): Do not access beyond zombies array
4848 boundary if nzombies > MAX_ZOMBIES.
4849 * alloc.c (dump_zombies): Add missing format specifier.
4850
4851 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4852
4853 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4854 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4855
4856 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4857 Some packages use them to denote characters with modifiers.
4858
4859 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4860
4861 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4862 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4863 matching a pp-number. Rename parameter var to var1.
4864
4865 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4866
4867 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4868
4869 2011-10-08 Glenn Morris <rgm@gnu.org>
4870
4871 * callint.c (Fcall_interactively): Give a more explicit error for the
4872 'c' case with a non-character input. (Bug#8479)
4873
4874 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4875
4876 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4877 lines.
4878 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4879 lines that are hscrolled on the left.
4880
4881 * dispnew.c (buffer_posn_from_coords): Account for a possible
4882 presence of header-line. (Bug#4426)
4883
4884 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4885
4886 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4887 Don't advertise functionality which we discourage or doesn't work.
4888
4889 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4892 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4893 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4894 this makes Emacs dump core during garbage collection on rare
4895 occasions. sizeof is obviously inferior to offsetof here, so
4896 stick with offsetof.
4897 (GC_POINTER_ALIGNMENT): New macro.
4898 (mark_memory): Omit 3rd (offset) arg; caller changed.
4899 Don't assume EMACS_INT alignment is the same as pointer alignment.
4900
4901 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4902
4903 * keyboard.c (read_key_sequence_remapped): New var.
4904 (read_key_sequence): Compute remapping in the right buffer.
4905 (command_loop_1): Use read_key_sequence's remapping directly.
4906
4907 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4908
4909 * dired.c (file_name_completion): Don't expand file name.
4910 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4911 before checking file name handler.
4912
4913 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4914 they've been requested explicitly (bug#9591).
4915
4916 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4917
4918 * keymap.c (Fsingle_key_description): Use make_specified_string
4919 instead of build_string to build string from push_key_description.
4920 (Bug#5193)
4921
4922 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4923
4924 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4925 This fixes a Y2038 bug on 64-bit hosts.
4926 * buffer.c (reset_buffer):
4927 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4928 (Fclear_buffer_auto_save_failure):
4929 Use 0, not -1, to represent an unset failure time, since time_t
4930 might not be signed.
4931
4932 Remove dependency on glibc malloc internals.
4933 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4934 Move back here from lisp.h, but with their new implementations.
4935 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4936 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4937 * charset.c (charset_table_init): New static var.
4938 (syms_of_charset): Use it instead of xmalloc. This removes a
4939 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4940 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4941 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4942 Move back to alloc.c.
4943 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4944 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4945
4946 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4947
4948 * nsterm.m (windowDidResize): Call x_set_window_size only when
4949 ns_in_resize is true. Otherwise set pixelwidth/height and
4950 call change_frame_size (Bug#9628).
4951
4952 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4953
4954 Port --enable-checking=all to Fedora 14 x86-64.
4955 * charset.c (syms_of_charset): Also account for glibc malloc's
4956 internal overhead when calculating the initial malloc maximum.
4957
4958 Port --enable-checking=all to Fedora 14 x86.
4959 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4960 Move to lisp.h.
4961 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4962 (overrun_check_realloc, overrun_check_free):
4963 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4964 That way, xmalloc returns a properly-aligned pointer even if
4965 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4966 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4967 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4968 into account when calculating the initial malloc maximum.
4969 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4970 Move here from alloc.c, so that charset.c can use it too.
4971 Properly align; the old code wasn't right for common 32-bit hosts
4972 when configured with --enable-checking=all.
4973 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4974 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4975
4976 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4977
4978 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4979 use EDOM.
4980
4981 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4982
4983 * xdisp.c (compute_display_string_end): If there's no display
4984 string at CHARPOS, return -1.
4985
4986 * bidi.c (bidi_fetch_char): When compute_display_string_end
4987 returns a negative value, treat the character as a normal
4988 character not covered by a display string. (Bug#9624)
4989
4990 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4991
4992 * lread.c (Fread_from_string): Fix typo in docstring.
4993
4994 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4995
4996 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4997 newline, reseat the iterator instead of bidi-iterating there one
4998 character at a time. (Bug#9610)
4999 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5000 TO_CHARPOS if the bidi iterator is at base embedding level.
5001
5002 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5003
5004 * lread.c (readevalloop): Use correct code for NBSP.
5005 (read1): Likewise. (Bug#9608)
5006
5007 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5008
5009 * dbusbind.c (Fdbus_register_signal): When service is not
5010 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5011
5012 2011-09-25 Glenn Morris <rgm@gnu.org>
5013
5014 * buffer.c (truncate-lines): Doc fix.
5015
5016 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5017
5018 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5019 (Fset_window_next_buffers): Doc fix.
5020
5021 2011-09-24 Glenn Morris <rgm@gnu.org>
5022
5023 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5024
5025 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5026
5027 Fix minor problems found by static checking.
5028 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5029 * indent.c (Fvertical_motion): Fix == vs = typo.
5030
5031 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5032
5033 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5034 Default value is now t. Doc fix.
5035
5036 * indent.c (Fvertical_motion): Compute and apply the overshoot
5037 logic when moving up, not only when moving down. Fix the
5038 confusing name and values of the it_overshoot_expected variable;
5039 logic changes accordingly. (Bug#9254) (Bug#9549)
5040
5041 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5042 CHARPOS is covered by a display string which includes newlines.
5043 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5044 is covered by a display string with embedded newlines.
5045
5046 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5047
5048 * dbusbind.c (Fdbus_register_signal): Add match rule to
5049 Vdbus_registered_objects_table. (Bug#9581)
5050 (Fdbus_register_method, Vdbus_registered_objects_table):
5051 Fix docstring.
5052
5053 2011-09-24 Jim Meyering <meyering@redhat.com>
5054
5055 do not ignore write error for any output size
5056 The previous change was incomplete.
5057 While it makes emacs --batch detect the vast majority of stdout
5058 write failures, errors were still ignored whenever the output size is
5059 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5060 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5061 && echo FAIL: ignored write error
5062 FAIL: ignored write error
5063 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5064 && echo FAIL: ignored write error
5065 FAIL: ignored write error
5066 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5067
5068 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5069
5070 * emacs.c (Fkill_emacs): In noninteractive mode exit
5071 non-successfully if a write error occurred on stdout. (Bug#9574)
5072
5073 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5074
5075 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5076 the xassert test.
5077
5078 * dispextern.h (struct it): Update the comment documenting what
5079 can it->OBJECT be.
5080
5081 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5082
5083 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5084 a display string, extend search for cursor position to end of row.
5085 (find_row_edges): If the row ends in a newline from a display
5086 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5087 Handle the case of a display string with multiple newlines.
5088 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5089 non-empty line. Fixes confusing cursor motion with arrow keys at
5090 the beginning of a line that starts with whitespace.
5091
5092 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5093
5094 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5095 (bug#9493).
5096
5097 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5098
5099 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5100 boolean (Bug#9154).
5101
5102 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5103
5104 * xdisp.c (display_line): Record maximum and minimum buffer
5105 positions even if no glyphs were produced (e.g., by a zero-width
5106 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5107 buffer positions that will be removed from the glyph row because
5108 they don't fit.
5109 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5110 column is beyond frame width: don't subtract 1 "pixel" when
5111 computing width of the stretch.
5112 (reseat_at_next_visible_line_start): Undo the change made on
5113 2011-09-17 that saved paragraph information and restored it after
5114 the call to `reseat'. (Bug#9545)
5115
5116 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5117
5118 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5119 and turn window cursor on if cleared (Bug#9415).
5120
5121 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5122
5123 * search.c (boyer_moore): Take unibyte characters from pattern
5124 literally. (Bug#9458)
5125
5126 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5127
5128 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5129
5130 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5131
5132 Fix minor problem found by static checking.
5133 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5134 initialized, to pacify gcc -Wuninitialized.
5135
5136 * fileio.c: Report proper errno when syscall falls.
5137 (Finsert_file_contents): Save and restore errno,
5138 so that report_file_error outputs the correct diagnostic.
5139 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5140
5141 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5142
5143 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5144
5145 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5146
5147 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5148 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5149
5150 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5151
5152 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5153 about the current paragraph and restore it after the call to reseat.
5154
5155 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5156 (bidi_find_paragraph_start): Search back for paragraph beginning
5157 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5158 (bidi_move_to_visually_next): Only trigger paragraph-related
5159 computations when the last character is a newline or at EOB, not
5160 just any NEUTRAL_B. (Bug#9470)
5161
5162 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5163 truncated lines if point is covered by a display string. (Bug#9524)
5164
5165 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5166
5167 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5168 (cons_to_x_long): New function.
5169 (lisp_data_to_selection_data): Use it. Correct the test for
5170 short-versus-long data; it was negated. Break out of vector
5171 loop, for efficiency, when a long datum is discovered.
5172
5173 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5174
5175 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5176
5177 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5178
5179 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5180 GCC PR/17406) by declaring this function with external scope.
5181
5182 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5183
5184 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5185 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5186
5187 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5188
5189 * editfns.c (Fformat): Correctly handle text properties on "%%".
5190
5191 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5192
5193 * xterm.c (x_draw_composite_glyph_string_foreground):
5194 * w32term.c (x_draw_composite_glyph_string_foreground):
5195 * term.c (encode_terminal_code):
5196 * composite.c (composition_update_it, get_composition_id):
5197 * xdisp.c (get_next_display_element)
5198 (fill_composite_glyph_string): Add comments about special meaning
5199 of TAB characters in a composition.
5200
5201 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5202
5203 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5204 This occurs when processing a multibyte format.
5205 Problem reported by Wolfgang Jenker.
5206
5207 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5208
5209 * xdisp.c (try_cursor_movement): Only check for exact match if
5210 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5211
5212 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5213
5214 Remove unused external symbols.
5215 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5216 * xdisp.c (calc_pixel_width_or_height): Now static.
5217 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5218 * indent.c (check_display_width):
5219 * w32term.c: Fix comment to match code.
5220 * xterm.c, xterm.h (x_catching_errors): Remove.
5221
5222 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5223
5224 * xselect.c: Use signed conversions more consistently (Bug#9498).
5225 (selection_data_to_lisp_data): Assume incoming selection data are
5226 signed integers, not unsigned. This is to be consistent with
5227 outgoing selection data, which was modified to use signed integers
5228 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5229 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5230 expects long, not unsigned long.
5231
5232 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5233
5234 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5235 computation of loop end. Reported by Johan Bockgård
5236 <bojohan@gnu.org>.
5237
5238 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5239
5240 * frame.c (Fother_visible_frames_p): Function deleted.
5241
5242 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5243
5244 * indent.c (compute_motion): Process display vector front to back
5245 rather than the other way around. (Bug#2496)
5246
5247 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5248
5249 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5250
5251 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5252
5253 * minibuf.c (Fread_from_minibuffer): Doc fix.
5254
5255 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5256
5257 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5258 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5259
5260 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5261
5262 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5263 value for non-existent files.
5264
5265 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5266
5267 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5268 set its "size" to -1. This will set the modtime_size field of
5269 the corresponding buffer to -1, which is what
5270 verify-visited-file-modtime expects for files that do not exist.
5271 (Bug#9139)
5272
5273 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5274
5275 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5276 here ...
5277 * lisp.h: ... from here. push_key_description is no longer
5278 defined in keyboard.c, so its declaration should not be in
5279 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5280 logically belongs with push_key_description.
5281
5282 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5283
5284 * buffer.h: Include <sys/types.h> instead of <time.h>.
5285 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5286 Problem reported by Herbert J. Skuhra.
5287
5288 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5289
5290 * xml.c (parse_region): Make the parsing work for
5291 non-comment-starting XML files again (bug#9144).
5292
5293 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5294
5295 * image.c (gif_load): Fix calculation of bottom and right corner.
5296 (Bug#9468)
5297
5298 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5299
5300 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5301 redisplay in small windows.
5302
5303 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5304
5305 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5306
5307 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5308
5309 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5310 Operate on live windows only.
5311
5312 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5313
5314 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5315
5316 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5317
5318 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5319 only under bidi iteration.
5320
5321 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5322
5323 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5324
5325 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5326
5327 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5328 Without this fix, the command to link temacs failed due to an
5329 undefined symbol __builtin_isnan. This is because
5330 /usr/include/iso/math_c99.h #defines isnan(x) to
5331 __builtin_isnan(x), but the bundled gcc, which identifies itself
5332 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5333 a __builtin_isnan.
5334 * floatfns.c (isnan): #undef, and then #define to a clone of
5335 what's in data.c.
5336 (Fisnan): Always define, since it's always available now.
5337 (syms_of_floatfns): Always define isnan at the Lisp level.
5338
5339 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5340
5341 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5342
5343 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5346 The previous code assumed that file offsets (off_t values) fit in
5347 EMACS_INT variables, which is not true on typical 32-bit hosts.
5348 The code messed up by falsely reporting buffer overflow in cases
5349 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5350 when "big" contains more than 2**29 bytes, even though this
5351 inserts just one byte and does not overflow the buffer.
5352 (Finsert_file_contents): Store file offsets as off_t
5353 values, not as EMACS_INT values. Check for overflow when
5354 converting between EMACS_INT and off_t. When checking for
5355 buffer overflow or for overlap, take the offsets into account.
5356 Don't use EMACS_INT for small values where int suffices.
5357 When checking for overlap, fix a typo: ZV was used where
5358 ZV_BYTE was intended.
5359 (Fwrite_region): Don't assume off_t fits into 'long'.
5360 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5361
5362 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5363
5364 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5365
5366 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5367
5368 sprintf-related integer and memory overflow issues (Bug#9412).
5369
5370 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5371 (esprintf, exprintf, evxprintf): New functions.
5372 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5373 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5374 (modify_event_symbol): Do not assume that the length of
5375 name_alist_or_stem is safe to alloca and fits in int.
5376 (Fexecute_extended_command): Likewise for function name and binding.
5377 (Frecursion_depth): Wrap around reliably on integer overflow.
5378 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5379 since some callers pass EMACS_INT values.
5380 (Fsingle_key_description): Don't crash if symbol name contains more
5381 than MAX_ALLOCA bytes.
5382 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5383 (get_minibuffer): Arg is now EMACS_INT, not int.
5384 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5385 (esprintf, exprintf, evxprintf): New decls.
5386 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5387
5388 * dbusbind.c (signature_cat): New function.
5389 (xd_signature, Fdbus_register_signal):
5390 Do not overrun buffer; instead, report string overflow.
5391
5392 * dispnew.c (add_window_display_history): Don't overrun buffer.
5393 Truncate instead; this is OK since it's just a log.
5394
5395 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5396 even if the time zone offset is outlandishly large.
5397 Don't mishandle offset == INT_MIN.
5398
5399 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5400 when creating daemon; the previous buffer-overflow check was incorrect.
5401
5402 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5403 which has the guts of the old verror function.
5404
5405 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5406 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5407
5408 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5409 (font_unparse_xlfd): Don't blindly alloca long strings.
5410 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5411 fits in int, when using sprintf. Use single snprintf to count
5412 length of string rather than counting it via multiple sprintfs;
5413 that's simpler and more reliable.
5414 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5415 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5416 sprintf, in case result does not fit in int.
5417
5418 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5419 (fontset_from_font): Print it.
5420
5421 * frame.c (tty_frame_count): Now printmax_t, not int.
5422 (make_terminal_frame, set_term_frame_name): Print it.
5423 (x_report_frame_params): In X, window IDs are unsigned long,
5424 not signed long, so print them as unsigned.
5425 (validate_x_resource_name): Check for implausibly long names,
5426 and don't assume name length fits in 'int'.
5427 (x_get_resource_string): Don't blindly alloca invocation name;
5428 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5429 not fit in int.
5430
5431 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5432 (xg_check_special_colors, xg_set_geometry):
5433 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5434
5435 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5436 Use esprintf, not sprintf, in case result does not fit in int.
5437
5438 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5439 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5440 it as a large positive number.
5441 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5442 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5443
5444 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5445 in case result does not fit in int.
5446
5447 * print.c (float_to_string): Detect width overflow more reliably.
5448 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5449 buffer overrun. Don't assume list length fits in 'int'. Treat
5450 print length of 0 as 0, not as infinity; to be consistent with other
5451 uses of print length in this function. Don't overflow print length
5452 index. Don't assume hash table size fits in 'long', or that
5453 vectorlike size fits in 'unsigned long'.
5454
5455 * process.c (make_process): Use printmax_t, not int, to format
5456 process-name gensyms.
5457
5458 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5459
5460 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5461 to avoid potential buffer overrun.
5462
5463 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5464 if X resource line is longer than 512 bytes.
5465
5466 * xfns.c (x_window): Make sprintf buffer a bit bigger
5467 to avoid potential buffer overrun.
5468
5469 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5470
5471 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5472
5473 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 Integer overflow fixes for scrolling, etc.
5476 Without these, Emacs silently mishandles large integers sometimes.
5477 For example, "C-u 4294967297 M-x recenter" was treated as if
5478 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5479
5480 * xdisp.c (try_window_id): Check Emacs fixnum range before
5481 converting to 'int'.
5482
5483 * window.c (window_scroll_line_based, Frecenter):
5484 Check that an Emacs fixnum is in range before assigning it to 'int'.
5485 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5486 values converted from Emacs fixnums.
5487 (Frecenter): Don't wrap around a line count if it is out of 'int'
5488 range; instead, treat it as an extreme value.
5489 (Fset_window_configuration, compare_window_configurations):
5490 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5491
5492 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5493 that can exceed INT_MAX. Check that EMACS_INT value is in range
5494 before assigning it to the (possibly-narrower) index.
5495 (match_limit): Don't assume that a fixnum can fit in 'int'.
5496
5497 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5498 exceed INT_MAX.
5499
5500 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5501 (Fvertical_motion): Don't wrap around LINES values that don't fit
5502 in 'int'. Instead, treat them as extreme values. This is good
5503 enough for windows, which can't have more than INT_MAX lines anyway.
5504
5505 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5506
5507 * Require libxml/parser.h to avoid compilation warning.
5508
5509 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5510
5511 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5512 since this reportedly can destroy thread storage.
5513
5514 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5515
5516 * syntax.c (find_defun_start): Update all cache variables if
5517 exiting early (Bug#9401).
5518
5519 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5520
5521 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5522
5523 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5524 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5525 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5526
5527 * term.c (tty_append_glyph): New function.
5528 (produce_stretch_glyph): Static function and its prototype deleted.
5529
5530 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5531 Add prototypes.
5532
5533 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5534
5535 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5536 when checking :margin (Bug#9390).
5537 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5538 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5539 so that the name doesn't mislead. All uses changed.
5540
5541 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5542
5543 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5544 set_tty_hooks.
5545
5546 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5547
5548 * xdisp.c (move_it_to): Don't bail out early when reaching
5549 position beyond to_charpos, if we are scanning backwards.
5550 (move_it_vertically_backward): When DY == 0, make sure we get to
5551 the first character in the line after the newline.
5552
5553 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5554
5555 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5556 (ccl_driver): Do not generate an out-of-range pointer.
5557 (Fccl_execute_on_string): Remove unnecessary check for
5558 integer overflow, noted by Stefan Monnier in
5559 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5560 Remove a FIXME that didn't need fixing.
5561 Simplify the newly-introduced buffer reallocation code.
5562
5563 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5564
5565 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5566
5567 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5568
5569 Integer and memory overflow issues (Bug#9196).
5570
5571 * doc.c (get_doc_string): Rework so that
5572 get_doc_string_buffer_size is the actual buffer size, rather than
5573 being 1 less than the actual buffer size; this makes xpalloc more
5574 convenient.
5575
5576 * image.c (x_allocate_bitmap_record, cache_image):
5577 * xselect.c (Fx_register_dnd_atom):
5578 Simplify previous changes by using xpalloc.
5579
5580 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5581 since either will do and ptrdiff_t is convenient with xpalloc.
5582
5583 * charset.c (charset_table_size)
5584 (struct charset_sort_data.priority): Now ptrdiff_t.
5585 (charset_compare): Don't overflow if priorities differ greatly.
5586 (Fsort_charsets): Don't assume list length fits in int.
5587 Check for size-calculation overflow when allocating sort data.
5588 (syms_of_charset): Allocate an initial charset table that is
5589 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5590
5591 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5592
5593 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5594 The actual value is always <= INT_MAX, and leaving it unsigned made
5595 overflow checking harder.
5596
5597 * dispextern.h (struct glyph_matrix.rows_allocated)
5598 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5599 with xpalloc. The values are still always <= INT_MAX.
5600
5601 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5602
5603 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5604 (SAFE_NALLOCA): New macro.
5605
5606 * region-cache.c (struct boundary.pos, find_cache_boundary)
5607 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5608 (set_cache_region, invalidate_region_cache)
5609 (revalidate_region_cache, know_region_cache, region_cache_forward)
5610 (region_cache_backward, pp_cache):
5611 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5612 so that ptrdiff_t * can be passed to xpalloc.
5613 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5614 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5615 (pp_cache): Don't assume cache_len fits in int.
5616 * region-cache.h: Adjust extern decls to match.
5617
5618 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5619 EMACS_INT, since either will do, for xpalloc.
5620
5621 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5622 (xnmalloc, xnrealloc, xpalloc): New functions.
5623
5624 * bidi.c (bidi_shelve_header_size): New constant.
5625 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5626 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5627
5628 * bidi.c (bidi_cache_shrink):
5629 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5630 (overlay_strings):
5631 Don't update size of array until after memory allocation succeeds,
5632 because xmalloc/xrealloc may not return.
5633 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5634 now that we have proper integer overflow checking.
5635 (record_overlay_string, overlay_strings): Catch overflows when
5636 calculating size of overlay_str_buf.
5637
5638 * callproc.c (Fcall_process): Check for size overflow when
5639 calculating size of args2.
5640 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5641 Normally we prefer signed values, but sticking with ptrdiff_t would
5642 require adding more-complicated checks.
5643
5644 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5645 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5646 Redo buffer-overflow calculations to avoid integer overflow.
5647 Add a FIXME comment where memory seems to be over-allocated.
5648
5649 * character.c (Fstring): Check for size-calculation overflow.
5650
5651 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5652 unnecessary integer overflow. Check for size overflow.
5653 (encode_coding_object): Don't update size until xmalloc succeeds.
5654
5655 * composite.c (get_composition_id): Check for overflow in glyph
5656 length calculations.
5657
5658 Integer and memory overflow fixes for display code.
5659 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5660 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5661 (scrolling_window): Check for overflow in size calculations.
5662 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5663 Don't assume glyph table len fits in int.
5664 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5665 (row_table_size): Now ptrdiff_t, not int.
5666 (scrolling_window): Avoid overflow in size calculations.
5667 Don't update size until allocation succeeds.
5668 * fns.c (concat): Check for overflow in size calculations.
5669 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5670 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5671 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5672
5673 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5674 (get_doc_string): Check for size calculation overflow.
5675 Don't update size until allocation succeeds.
5676 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5677 EMACS_INT, where ptrdiff_t will do.
5678 (Fsubstitute_command_keys): Check for string overflow.
5679
5680 * editfns.c (set_time_zone_rule): Don't assume environment length
5681 fits in int.
5682 (message_length): Now ptrdiff_t, not int.
5683 (Fmessage_box): Don't update size until allocation succeeds.
5684 Don't assume message length fits in int.
5685 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5686
5687 * emacs.c (main): Do not reallocate argv, since there is a null at
5688 the end that can be overwritten, and this way there's no need to
5689 worry about size-calculation overflow.
5690 (sort_args): Check for size-calculation overflow.
5691
5692 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5693 alloc succeeds.
5694 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5695
5696 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5697 (x_set_scroll_bar_width, x_figure_window_size):
5698 Check for integer overflow.
5699 (x_set_alpha): Do not assume XINT fits in int.
5700
5701 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5702 This is for the members text_lines, text_cols, total_lines, total_cols,
5703 where the system imposes an 'int' limit.
5704
5705 * fringe.c (Fdefine_fringe_bitmap):
5706 Don't update size until alloc works.
5707
5708 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5709 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5710
5711 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5712 Check for size-calculation overflow.
5713 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5714 do, as we prefer signed integers.
5715 (id_to_widget.max_size, id_to_widget.used)
5716 (xg_store_widget_in_map, xg_remove_widget_from_map)
5717 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5718 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5719 Use and return ptrdiff_t, not int.
5720 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5721 * gtkutil.h: Change prototypes to match the above.
5722
5723 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5724 are duplicate now that they've been promoted to lisp.h.
5725 (x_allocate_bitmap_record, x_alloc_image_color)
5726 (make_image_cache, cache_image, xpm_load):
5727 Don't update size until alloc is done.
5728 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5729 (x_detect_edges):
5730 Check for size calculation overflow.
5731 (ct_colors_allocated_max): New constant.
5732 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5733 overflow.
5734
5735 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5736 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5737 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5738 Use ptrdiff_t, not int, to count maps.
5739 (read_char_minibuf_menu_prompt): Check for overflow in size
5740 calculations. Don't update size until allocation succeeds.
5741 Redo calculations to avoid overflow.
5742 * keyboard.h: Change prototypes to match the above.
5743
5744 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5745 to count maps.
5746 (current_minor_maps): Check for size calculation overflow.
5747 * keymap.h: Change prototypes to match the above.
5748
5749 * lread.c (read1, init_obarray): Don't update size until alloc done.
5750
5751 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5752 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5753
5754 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5755 Now ptrdiff_t, not int.
5756 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5757 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5758
5759 * process.c (Fnetwork_interface_list): Check for overflow
5760 in size calculation.
5761
5762 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5763
5764 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5765 overflow. Don't bother calling xmalloc when xrealloc will do.
5766
5767 * search.c (Freplace_match): Check for size calculation overflow.
5768 (Fset_match_data): Don't assume list lengths fit in 'int'.
5769
5770 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5771 for command line length. Do not attempt to address one before the
5772 beginning of an array, as that's not portable.
5773
5774 * term.c (max_frame_lines): Remove; unused.
5775 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5776 not int.
5777 (encode_terminal_code, calculate_costs): Check for size
5778 calculation overflow.
5779 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5780 table lengths and related sizes. Don't update size until alloc
5781 done. Redo calculations to avoid overflow.
5782 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5783
5784 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5785 subtracting pointers.
5786 (gobble_line): Check for overflow more carefully. Don't update size
5787 until alloc done.
5788
5789 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5790 Don't update size until alloc done.
5791 Redo size calculations to avoid overflow.
5792 Check for size calculation overflow.
5793 (main) [DEBUG]: Fix typo in invoking tparam1.
5794
5795 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5796 Use ptrdiff_t, not int, for sizes.
5797 (store_mode_line_noprop_char): Don't update size until alloc done.
5798
5799 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5800 Use ptrdiff_t, not int, for sizes.
5801 (Finternal_make_lisp_face, cache_face):
5802 Check for size calculation overflow.
5803 (cache_face): Treat size calculation overflows as if they were
5804 memory exhaustion (the usual treatment), rather than aborting.
5805
5806 * xfns.c (x_encode_text, x_set_name_internal)
5807 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5808 sizes, since they can exceed INT_MAX in size. Check for size
5809 calculation overflow.
5810
5811 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5812 (xg_select): Check for size calculation overflow.
5813 Don't update size until alloc done.
5814
5815 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5816 as sprintf is limited to int lengths.
5817
5818 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5819 (X_LONG_MIN): New macros.
5820 Use them to make the following changes clearer.
5821 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5822 This change doesn't affect the value now, but it may help remind
5823 future maintainers not to raise the value too much later.
5824 (SELECTION_QUANTUM): Remove, replacing with ...
5825 (selection_quantum): ... new function, which avoids overflow.
5826 All uses changed.
5827 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5828 assumption that selection length fits in 'int'.
5829 (x_reply_selection_request, x_handle_selection_request)
5830 (x_get_window_property, receive_incremental_selection)
5831 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5832 (lisp_data_to_selection_data, clean_local_selection_data):
5833 Use ptrdiff_t, not int, to record length of selection.
5834 (x_reply_selection_request, x_get_window_property)
5835 (receive_incremental_selection, x_property_data_to_lisp):
5836 Redo calculations to avoid overflow.
5837 (x_reply_selection_request): When sending hint, ceiling it at
5838 X_LONG_MAX rather than relying on wraparound overflow to send
5839 something.
5840 (x_get_window_property, receive_incremental_selection)
5841 (lisp_data_to_selection_data, x_property_data_to_lisp):
5842 Check for size-calculation overflow.
5843 (x_get_window_property, receive_incremental_selection)
5844 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5845 Don't store size until memory allocation succeeds.
5846 (x_get_window_property): Plug memory leak on memory exhaustion.
5847 Don't double-block input; malloc is safe here. Don't assume 2**34
5848 - 4 fits in unsigned long. Add an xassert to check
5849 XGetWindowProperty overflow. Be more careful about overflow
5850 calculations, and distinguish size from memory overflow better.
5851 (receive_incremental_selection): When tracing, don't assume
5852 unsigned int is less than INT_MAX.
5853 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5854 harmful) conversions of unsigned short to int.
5855 (lisp_data_to_selection_data): Don't assume that integers
5856 in the range -65535 through -1 fit in an X unsigned short.
5857 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5858 result parameters unless successful. Rely on cons_to_unsigned
5859 to report problems with elements; the old code wasn't right anyway.
5860 (x_check_property_data): Check for int overflow; we cannot use
5861 a wider type due to X limits.
5862 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5863
5864 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5865
5866 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5867 (x_term_init): Check for size calculation overflow.
5868 (x_color_cells): Don't store size until memory allocation succeeds.
5869 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5870 Don't assume alloca size is less than MAX_ALLOCA.
5871 (x_term_init): Don't assume length fits in int (sprintf is limited
5872 to int size).
5873
5874 Use ptrdiff_t for composition IDs.
5875 * character.c (lisp_string_width):
5876 * composite.c (composition_table_size, n_compositions)
5877 (get_composition_id, composition_gstring_from_id):
5878 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5879 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5880 * window.c (Frecenter):
5881 Use ptrdiff_t, not int, for composition IDs.
5882 * composite.c (get_composition_id): Check for integer overflow.
5883 * composite.h: Adjust prototypes to match the above changes.
5884
5885 Use ptrdiff_t for hash table indexes.
5886 * category.c (hash_get_category_set):
5887 * ccl.c (ccl_driver):
5888 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5889 * coding.c (coding_system_charset_list, detect_coding_system):
5890 * coding.h (struct coding_system.id):
5891 * composite.c (get_composition_id, gstring_lookup_cache):
5892 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5893 * image.c (xpm_get_color_table_h):
5894 * lisp.h (hash_lookup, hash_put):
5895 * minibuf.c (Ftest_completion):
5896 Use ptrdiff_t for hash table indexes, not int (which is too
5897 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5898 32-bit --with-wide-int hosts).
5899
5900 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5901 Add a FIXME comment about memory leaks.
5902 (syms_of_charset): Don't assume xmalloc returns.
5903
5904 Don't assume that stated character widths fit in int.
5905 * character.c (Fchar_width, c_string_width, lisp_string_width):
5906 * character.h (CHAR_WIDTH):
5907 * indent.c (MULTIBYTE_BYTES_WIDTH):
5908 Use sanitize_char_width to avoid undefined and/or bad behavior
5909 with outlandish widths.
5910 * character.h (sanitize_tab_width): Rename from sanitize_width,
5911 now that we have two such functions. All uses changed.
5912 (sanitize_char_width): New inline function.
5913
5914 Don't assume that tab-width fits in int.
5915 * character.h (sanitize_width): New inline function.
5916 (SANE_TAB_WIDTH): New macro.
5917 (ASCII_CHAR_WIDTH): Use it.
5918 * indent.c (sane_tab_width): Remove. All uses replaced by
5919 SANE_TAB_WIDTH (current_buffer).
5920 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5921
5922 * fileio.c: Integer overflow issues with file modes.
5923 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5924
5925 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5926 Remove unreachable code.
5927 (read_hex, load_charset_map_from_file): Check for integer overflow.
5928
5929 * xterm.c: Don't go over XClientMessageEvent limit.
5930 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5931 (x_send_scroll_bar_event): Likewise. Check that the size does not
5932 exceed limits imposed by XClientMessageEvent, as well as the usual
5933 ptrdiff_t and size_t limits.
5934
5935 * keyboard.c: Overflow, signedness and related fixes.
5936 (make_lispy_movement): Use same integer type in forward decl
5937 that is used in the definition.
5938 (read_key_sequence, keyremap_step):
5939 Change bufsize argument back to int, undoing my 2011-03-30 change.
5940 We prefer signed types, and int is wide enough here.
5941 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5942 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5943 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5944 length, not size_t. Use ptrdiff_t for index, not int.
5945 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5946 possibility of integer overflow.
5947
5948 Overflow, signedness and related fixes for images.
5949
5950 * dispextern.h (struct it.stack[0].u.image.image_id)
5951 (struct_it.image_id, struct image.id, struct image_cache.size)
5952 (struct image_cache.used, struct image_cache.ref_count):
5953 * gtkutil.c (update_frame_tool_bar):
5954 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5955 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5956 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5957 * nsmenu.m (update_frame_tool_bar):
5958 * xdisp.c (calc_pixel_width_or_height):
5959 * xfns.c (image_cache_refcount):
5960 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5961 on typical 64-bit hosts.
5962
5963 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5964 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5965 Omit unnecessary casts to int.
5966 (parse_image_spec): Check that integers fall into 'int' range
5967 when the callers expect that.
5968 (image_ascent): Redo ascent calculation to avoid int overflow.
5969 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5970 (lookup_image): Remove unnecessary tests.
5971 (xbm_image_p): Locals are now of int, not EMACS_INT,
5972 since parse_image_check makes sure they fit into int.
5973 (png_load, gif_load, svg_load_image):
5974 Prefer int to unsigned where either will do.
5975 (tiff_handler): New function, combining the cores of the
5976 old tiff_error_handler and tiff_warning_handler.
5977 This function is rewritten to use vsnprintf and thereby avoid
5978 stack buffer overflows. It uses only the features of vsnprintf
5979 that are common to both POSIX and native Microsoft.
5980 (tiff_error_handler, tiff_warning_handler): Use it.
5981 (tiff_load, gif_load, imagemagick_load_image):
5982 Don't assume :index value fits in 'int'.
5983 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5984 (imagemagick_load_image): Check that crop parameters fit into
5985 the integer types that MagickCropImage accepts. Don't assume
5986 Vimagemagick_render_type has a nonnegative value. Don't assume
5987 size_t fits in 'long'.
5988 (gs_load): Use printmax_t to print the widest integers possible.
5989 Check for integer overflow when computing image height and width.
5990
5991 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5992
5993 * xdisp.c (redisplay_window): Don't force window start if point
5994 will be invisible in the resulting window. (Bug#9324)
5995
5996 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5997
5998 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5999 the display spec is of the form `(space ...)'.
6000 (handle_display_spec): Return the value returned by
6001 handle_single_display_spec, not just 1 or zero.
6002 (handle_single_display_spec): If the display spec is of the form
6003 `(space ...)', and specifies display in the text area, return 2
6004 rather than 1.
6005 (try_cursor_movement): Check for the need to scroll more
6006 accurately, and prefer exact match for point under bidi.
6007 Don't advance `row' beyond the last row of the window.
6008
6009 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6010 into disp_prop; all users changed.
6011
6012 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6013 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6014 for the text covered by the display property.
6015
6016 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6017
6018 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6019 Change return value to nil.
6020 (Frecord_buffer): Delete unused function.
6021
6022 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6023
6024 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6025 buffers, return left-to-right.
6026 (set_cursor_from_row): Consider candidate row a win if its glyph
6027 represents a newline and point is on that newline. Fixes cursor
6028 positioning on the newline at EOL of R2L text within L2R
6029 paragraph, and vice versa.
6030 (try_cursor_movement): Check continued rows, in addition to
6031 continuation rows. Fixes unwarranted scroll when point enters a
6032 continued line of R2L text within an L2R paragraph, or vice versa.
6033 (cursor_row_p): Consider the case of point being equal to
6034 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6035 from the end of a short line to the beginning of a continued line
6036 of R2L text within L2R paragraph.
6037 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6038 composed characters.
6039
6040 * bidi.c (bidi_check_type): Use xassert.
6041 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6042 members.
6043
6044 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6045
6046 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6047 a character.
6048
6049 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6050
6051 * nsfont.m (ns_otf_to_script): Fix typo.
6052
6053 2011-08-22 Kenichi Handa <handa@m17n.org>
6054
6055 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6056 extra slot even if the purpose is char-code-property-table.
6057
6058 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6059
6060 * xdisp.c (redisplay_window): When computing centering_position,
6061 account for the height of the header line. (Bug#8874)
6062
6063 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6064 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6065 candidate is selected by the mouse, and that candidate has a
6066 composed character under the mouse.
6067
6068 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6069 coordinates reported by pos-visible-in-window-p for a composed
6070 character in column zero.
6071
6072 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6073
6074 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6075
6076 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6077
6078 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6079 consider it a hit if to_charpos is anywhere in the range of the
6080 composed buffer positions.
6081
6082 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6083
6084 * image.c (gif_load): Don't assume that each subimage has the same
6085 dimensions as the base image. Handle disposal method that is
6086 "undefined" by the gif spec (Bug#9335).
6087
6088 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6089
6090 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6091 (Fcondition_case): Document `debug' symbol in error handler.
6092
6093 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6094
6095 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6096 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6097 from an Org mode buffer to a Speedbar frame.
6098
6099 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6100 a composition, take its buffer position from IT->cmp_it.charpos.
6101 Fixes cursor positioning at the beginning of a line that begins
6102 with a composed character.
6103
6104 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6105
6106 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6107 character bidirectional type, use STRONG_L instead. Fixes crashes
6108 in a buffer produced by `describe-categories'.
6109
6110 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6111 members before the level stack, so they would be saved and
6112 restored when copying iterator state. Fixes incorrect reordering
6113 around TABs covered by display properties.
6114
6115 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6116
6117 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6118
6119 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6120
6121 * eval.c (internal_condition_case, internal_condition_case_1)
6122 (internal_condition_case_2, internal_condition_case_n):
6123 Remove unnecessary aborts (Bug#9081).
6124
6125 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6126
6127 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6128 has no `load' handler, try opening the file locally. (Bug#9311)
6129
6130 2011-08-16 Ken Brown <kbrown@cornell.edu>
6131
6132 * gmalloc.c: Expand comment.
6133
6134 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6135
6136 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6137 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6138
6139 2011-08-16 Ken Brown <kbrown@cornell.edu>
6140
6141 Fix memory allocation problems in Cygwin build (Bug#9273).
6142
6143 * unexcw.c ( __malloc_initialized): Declare external variable.
6144 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6145
6146 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6147 New variables.
6148 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6149 dumped emacs.
6150 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6151 in the static heap.
6152 [CYGWIN] (special_realloc): New function.
6153 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6154 requests to realloc storage in the static heap.
6155
6156 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6157
6158 * bidi.c (bidi_initialize): Remove unused local.
6159
6160 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6161
6162 * bidimirror.h:
6163 * biditype.h: Remove file.
6164 * makefile.w32-in ($(BLD)/bidi.$(O)):
6165 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6166
6167 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6168
6169 * chartab.c: Improve commentary for the uniprop_table API.
6170
6171 * bidi.c (bidi_paragraph_init): Support zero value of
6172 bidi_ignore_explicit_marks_for_paragraph_level.
6173 (bidi_initialize): Use uniprop_table instead of including
6174 biditype.h and bidimirror.h.
6175
6176 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6177 coordinates of the iterator when restoring from ppos_it.
6178 (Bug#9296)
6179
6180 2011-08-14 Kenichi Handa <handa@m17n.org>
6181
6182 * process.c (create_process): Call setup_process_coding_systems
6183 after the pid of the process is set to -1 (Bug#8162).
6184
6185 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6186
6187 * xdisp.c (move_it_in_display_line_to): Don't invoke
6188 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6189 ppos_it. Fixes vertical cursor motion when line beginning is
6190 covered by an image. (Bug#9296)
6191
6192 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6193
6194 * nsterm.h (ns_run_ascript): Declare.
6195 (NSAPP_DATA2_RUNASSCRIPT): Define.
6196
6197 * nsfns.m (as_script, as_result, as_status): New static variables.
6198 (ns_run_ascript): New function.
6199 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6200 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6201 the event loop. Get status from as_status (Bug#7276).
6202
6203 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6204 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6205 the event loop (Bug#7276).
6206
6207 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6208
6209 * gnutls.c (QCgnutls_bootprop_priority)
6210 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6211 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6212 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6213 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6214 (QCgnutls_bootprop_verify_hostname_error)
6215 (QCgnutls_bootprop_callbacks_verify): Rename from
6216 Qgnutls_bootprop_..., all uses changed.
6217
6218 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6219 uses changed.
6220
6221 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6222
6223 * xfaces.c (Qframe_set_background_mode): Now static.
6224 * dispextern.h (Qframe_set_background_mode): Remove decl.
6225
6226 * process.c (Fnetwork_interface_info): Declare local only if needed.
6227
6228 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6229
6230 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6231 (Fnetwork_interface_list): Allocate in increments of bytes instead
6232 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6233 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6234 sockaddr.
6235 (struct ifflag_def): notrailers is smart on OSX.
6236 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6237 Get hardware address with getifaddrs if available.
6238
6239 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6240
6241 * xdisp.c (iterate_out_of_display_property): xassert that
6242 IT->position is set to within IT->object's boundaries. Break from
6243 the loop as soon as EOB is reached; avoids infloops in redisplay
6244 when IT->position is set up wrongly due to some bug.
6245 Set IT->current to match the bidi iterator unconditionally.
6246 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6247 entry. Force push_it to save on the stack the current
6248 buffer/string position, to be restored by pop_it. Fix flags in
6249 the iterator structure wrt the object coming from a display
6250 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6251 properties. (Bug#9284)
6252
6253 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6254
6255 * fontset.c (fontset_get_font_group): Add proper type checks.
6256 (Bug#9172)
6257
6258 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6259
6260 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6261 and LC_VERSION_MIN_MACOSX.
6262 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6263 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6264
6265 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6266
6267 * xdisp.c (forward_to_next_line_start): Allow to use the
6268 no-display-properties-and-no-overlays under bidi display.
6269 Set disp_pos in the bidi iterator to avoid searches for display
6270 properties and overlays.
6271
6272 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6273
6274 * editfns.c (Fset_time_zone_rule): Document relationship with the
6275 setenv function.
6276
6277 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6278 the font entity extracted from the cache (Bug#8109).
6279
6280 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6281
6282 * composite.c (autocmp_chars): Don't reset point. That is done by
6283 restore_point_unwind (Bug#5984).
6284
6285 2011-08-07 Juri Linkov <juri@jurta.org>
6286
6287 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6288 to show the arg `TIME' instead of `TIMEVAL'.
6289
6290 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6291
6292 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6293 display property strides EOL and includes a newline, as in
6294 longlines-mode. (Bug#9254)
6295 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6296 word-wrap under bidirectional display. (Bug#9224)
6297
6298 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6299 is non-zero, even if the data buffer is NULL. Fixes a crash in
6300 vertical-motion with longlines-mode. (Bug#9254)
6301
6302 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6303
6304 * bidi.c <bidi_cache_total_alloc>: Now static.
6305 (bidi_initialize): Initialize bidi_cache_total_alloc.
6306
6307 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6308 cache. (Bug#9221)
6309
6310 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6311 amount allocated this far in `bidi_cache_total_alloc'.
6312 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6313 non-zero, only free the data buffer without restoring the cache
6314 contents. All callers changed.
6315
6316 * dispextern.h (bidi_unshelve_cache): Update prototype.
6317
6318 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6319 (move_it_in_display_line, move_it_to)
6320 (move_it_vertically_backward, move_it_by_lines): Replace the call
6321 to xfree to an equivalent call to bidi_unshelve_cache.
6322 (move_it_in_display_line_to): Fix logic of returning
6323 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6324
6325 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6326
6327 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6328 came from a string character with a `cursor' property. (Bug#9229)
6329
6330 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6331
6332 * Makefile.in (LIB_PTHREAD): New variable.
6333 (LIBES): Add LIB_PTHREAD (Bug#9216).
6334
6335 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6336 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6337
6338 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6339
6340 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6341
6342 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6343
6344 * xterm.c (x_find_topmost_parent): New function.
6345 (x_set_frame_alpha): Find topmost parent window with
6346 x_find_topmost_parent and set the property there also (bug#9181).
6347 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6348
6349 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6350
6351 * callproc.c (Fcall_process): Avoid vfork clobbering
6352 the local vars buffer, coding_systems, current_dir.
6353
6354 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6355
6356 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6357
6358 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6359
6360 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6361 so that it is not optimized away.
6362
6363 * xdisp.c (compute_display_string_pos): Remove unused local.
6364
6365 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6366
6367 Fix slow cursor motion and scrolling in large buffers with
6368 selective display, like Org Mode buffers. (Bug#9218)
6369
6370 * dispextern.h (struct bidi_it): New member disp_prop_p.
6371
6372 * xdisp.c: Remove one-slot cache of display string positions.
6373 (compute_display_string_pos): Accept an additional argument
6374 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6375 for a display string or property. If found, set DISP_PROP_P
6376 non-zero.
6377
6378 * bidi.c (bidi_fetch_char): Accept an additional argument
6379 DISP_PROP_P, and pass it to compute_display_string_pos.
6380 Only handle text covered by a display string if DISP_PROP_P is returned
6381 non-zero. All callers of bidi_fetch_char changed.
6382
6383 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6384
6385 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6386
6387 2010-12-03 Don March <don@ohspite.net>
6388
6389 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6390 last character M-[char] is translated to ESC [char] (bug#7541).
6391
6392 2011-08-02 Kenichi Handa <handa@m17n.org>
6393
6394 * lisp.h (uniprop_table): Extern it.
6395
6396 * chartab.c (uniprop_table): Make it non-static.
6397
6398 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6399
6400 * xdisp.c (forward_to_next_line_start): Accept additional argument
6401 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6402 on the newline.
6403 (reseat_at_next_visible_line_start): Use the bidi iterator state
6404 returned by forward_to_next_line_start to restore the state of
6405 it->bidi_it after backing up to previous newline. (Bug#9212)
6406
6407 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6408
6409 * regex.c (re_comp): Protoize.
6410 (re_exec): Fix return type.
6411 (regexec): Fix type of `ret'. (Bug#9203)
6412
6413 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6414
6415 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6416 This is needed if max-image-size is a floating-point number.
6417
6418 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6419
6420 * print.c (print_object): Print empty symbol as ##.
6421
6422 * lread.c (read1): Read ## as empty symbol.
6423
6424 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6425
6426 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6427 setting frame foreground color (Bug#9175).
6428 (x_set_background_color): Likewise.
6429
6430 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6431 contents (Bug#9176).
6432 (EmacsTooltip -init): Remove bezels and add shadows to
6433 tooltip windows.
6434
6435 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6436 or scroll bar (Bug#8470).
6437
6438 * nsfont.m (nsfont_open): Remove assignment to voffset and
6439 unnecessary vars hshink, expand, hd, full_height, min_height.
6440 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6441
6442 * nsterm.h (nsfont_info): Remove voffset field.
6443
6444 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6445
6446 Implement strike-through and overline on NextStep (Bug#8863).
6447
6448 * nsfont.m (nsfont_open): Use underline position provided by font,
6449 instead of hard-coded value of 2.
6450 (nsfont_draw): Call ns_draw_text_decoration instead.
6451
6452 * nsterm.h: Add declaration for ns_draw_text_decoration.
6453
6454 * nsterm.m (ns_draw_text_decoration): New function for drawing
6455 underline, overline, and strike-through.
6456 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6457 ns_draw_text_decoration. Change treatment of cursor drawing to
6458 accommodate underlining, etc.
6459
6460 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6461
6462 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6463 default.
6464
6465 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6466
6467 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6468 Without this fix, if a signal arrives just after memory fills up,
6469 'malloc' might be invoked reentrantly.
6470
6471 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6472 In other words, assume that every image size is allowed, on non-X
6473 hosts. This assumption is probably wrong, but it lets Emacs compile.
6474
6475 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6476
6477 * regex.c (re_iswctype): Convert return values to boolean.
6478
6479 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6480
6481 * xdisp.c (compute_display_string_pos): Don't use cached display
6482 string position if the buffer had its restriction changed.
6483 (Bug#9184)
6484
6485 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6486
6487 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6488
6489 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6490
6491 Integer signedness and overflow and related fixes. (Bug#9079)
6492
6493 * bidi.c: Integer size and overflow fixes.
6494 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6495 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6496 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6497 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6498 (bidi_find_other_level_edge):
6499 Use ptrdiff_t instead of EMACS_INT where either will do.
6500 This works better on 32-bit hosts configured --with-wide-int.
6501 (bidi_cache_ensure_space): Check for size-calculation overflow.
6502 Use % rather than repeated addition, for better worst-case speed.
6503 Don't set bidi_cache_size until after xrealloc returns, because it
6504 might not return.
6505 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6506 (bidi_cache_ensure_space): Also check that the bidi cache size
6507 does not exceed that of the largest Lisp string or buffer. See Eli
6508 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6509
6510 * alloc.c (__malloc_size_t): Remove.
6511 All uses replaced by size_t. See Andreas Schwab's note
6512 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6513
6514 * image.c: Improve checking for integer overflow.
6515 (check_image_size): Assume that f is nonnull, since
6516 it is always nonnull in practice. This is one less thing to
6517 worry about when checking for integer overflow later.
6518 (x_check_image_size): New function, which checks for integer
6519 overflow issues inside X.
6520 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6521 This removes the need for a memory_full check.
6522 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6523 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6524 (xbm_read_bitmap_data): Change locals back to 'int', since
6525 their values must fit in 'int'.
6526 (xpm_load_image, png_load, tiff_load):
6527 Invoke x_create_x_image_and_pixmap earlier,
6528 to avoid much needless work if the image is too large.
6529 (tiff_load): Treat overly large images as if
6530 x_create_x_image_and_pixmap failed, not as malloc failures.
6531 (gs_load): Use x_check_image_size.
6532
6533 * gtkutil.c: Omit integer casts.
6534 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6535 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6536
6537 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6538
6539 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6540 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6541 would wrongly return t on a 64-bit host.
6542
6543 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6544 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6545 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6546 and therefore cause GCC to emit a bogus diagnostic in some cases.
6547
6548 * image.c: Integer signedness and overflow and related fixes.
6549 This is not an exhaustive set of fixes, but it's time to
6550 record what I've got.
6551 (lookup_pixel_color, check_image_size): Remove redundant decls.
6552 (check_image_size): Don't assume that arbitrary EMACS_INT values
6553 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6554 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6555 (tiff_load, imagemagick_load_image):
6556 Check for overflow in size calculations.
6557 (x_create_x_image_and_pixmap): Remove unnecessary test for
6558 xmalloc returning NULL; that can't happen.
6559 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6560 (xpm_color_bucket): Use better integer hashing function.
6561 (xpm_cache_color): Don't possibly over-allocate memory.
6562 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6563 (gif_memory_source):
6564 Use ptrdiff_t, not int or size_t, to record sizes.
6565 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6566 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6567 either works, as we prefer signed integers.
6568 (tiff_read_from_memory, tiff_write_from_memory):
6569 Return tsize_t, not size_t, since that's what the TIFF API wants.
6570 (tiff_read_from_memory): Don't fail simply because the read would
6571 go past EOF; instead, return a short read.
6572 (tiff_load): Omit no-longer-needed casts.
6573 (Fimagemagick_types): Don't assume size fits into 'int'.
6574
6575 Improve hashing quality when configured --with-wide-int.
6576 * fns.c (hash_string): New function, taken from sxhash_string.
6577 Do not discard information about ASCII character case; this
6578 discarding is no longer needed.
6579 (sxhash-string): Use it. Change sig to match it. Caller changed.
6580 * lisp.h: Declare it.
6581 * lread.c (hash_string): Remove, since we now use fns.c's version.
6582 The fns.c version returns a wider integer if --with-wide-int is
6583 specified, so this should help the quality of the hashing a bit.
6584
6585 * emacs.c: Integer overflow minor fix.
6586 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6587 Define only if GNU_LINUX.
6588 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6589
6590 * dispnew.c: Integer signedness and overflow fixes.
6591 Remove unnecessary forward decls, that were a maintenance hassle.
6592 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6593 All uses changed.
6594 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6595 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6596 (prepare_desired_row, line_draw_cost):
6597 Use int, not unsigned, where either works.
6598 (save_current_matrix, restore_current_matrix):
6599 Use ptrdiff_t, not size_t, where either works.
6600 (init_display): Check for overflow more accurately, and without
6601 relying on undefined behavior.
6602
6603 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6604 Remove, replacing with the new symbols in lisp.h. All uses changed.
6605 * fileio.c (make_temp_name):
6606 * filelock.c (lock_file_1, lock_file):
6607 * xdisp.c (message_dolog):
6608 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6609 Use pMd etc. instead.
6610 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6611 replacing the pWIDE etc. symbols removed from editfns.c.
6612
6613 * keyboard.h (num_input_events): Now uintmax_t.
6614 This is (very slightly) less likely to mess up due to wraparound.
6615 All uses changed.
6616
6617 * buffer.c: Integer signedness fixes.
6618 (alloc_buffer_text, enlarge_buffer_text):
6619 Use ptrdiff_t rather than size_t when either will do, as we prefer
6620 signed integers.
6621
6622 * alloc.c: Integer signedness and overflow fixes.
6623 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6624 (__malloc_size_t): Default to size_t, not to int.
6625 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6626 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6627 Prefer ptrdiff_t to size_t when either would do, as we prefer
6628 signed integers.
6629 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6630 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6631 Now const. Initialize with values that are in range even if char
6632 is signed.
6633 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6634 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6635 These functions do the right thing with sizes > 2**32.
6636 (check_depth): Now ptrdiff_t, not int.
6637 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6638 Adjust to new way of storing sizes. Check for size overflow bugs
6639 in rest of code.
6640 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6641 slightly wrong anyway, as it missed one instance of
6642 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6643 (refill_memory_reserve): Omit needless cast to size_t.
6644 (mark_object_loop_halt): Mark as externally visible.
6645
6646 * xselect.c: Integer signedness and overflow fixes.
6647 (Fx_register_dnd_atom, x_handle_dnd_message):
6648 Use ptrdiff_t, not size_t, since we prefer signed.
6649 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6650 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6651 x_dnd_atoms_size and x_dnd_atoms_length.
6652
6653 * doprnt.c: Prefer signed to unsigned when either works.
6654 * eval.c (verror):
6655 * doprnt.c (doprnt):
6656 * lisp.h (doprnt):
6657 * xdisp.c (vmessage):
6658 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6659 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6660 prefer signed arithmetic to avoid comparison confusion.
6661 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6662 but is a bit tricky.
6663
6664 Assume freestanding C89 headers, string.h, stdlib.h.
6665 * data.c, doprnt.c, floatfns.c, print.c:
6666 Include float.h unconditionally.
6667 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6668 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6669 * regex.c: Likewise for stddef.h, string.h.
6670 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6671 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6672 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6673 (STDC_HEADERS): Remove obsolete defines.
6674 * sysdep.c: Include limits.h unconditionally.
6675
6676 Assume support for memcmp, memcpy, memmove, memset.
6677 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6678 * regex.c (memcmp, memcpy):
6679 Remove; we assume C89 now.
6680
6681 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6682 (__malloc_safe_bcopy): Remove; no longer needed.
6683
6684 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6685 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6686 well either way, and we prefer signed to unsigned.
6687
6688 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6689
6690 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6691 closes the connection while we're reading (bug#9182).
6692
6693 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6694
6695 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6696 are specified (Bug#9168).
6697
6698 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6699
6700 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6701 Found by GCC static checking and --with-wide-int on a 32-bit host.
6702
6703 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6704
6705 * xdisp.c (compute_display_string_pos): Fix logic of caching
6706 previous display string position. Initialize cached_prev_pos to
6707 -1. Fixes slow-down at the beginning of a buffer.
6708
6709 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6710
6711 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6712 for attrs[LFACE_FONTSET_INDEX].
6713
6714 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6715
6716 * xml.c (parse_region): Remove unused local
6717 that was recently introduced.
6718
6719 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6720
6721 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6722 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6723
6724 * xdisp.c (move_it_in_display_line_to): Record the best matching
6725 position for TO_CHARPOS while scanning the line, and restore it on
6726 exit if none of the characters scanned was an exact match.
6727 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6728 when exact match is impossible due to invisible text, and the
6729 lines are truncated.
6730
6731 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6732
6733 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6734 for OSX >= 10.7.
6735
6736 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6737
6738 Fix a significant slow-down of cursor motion with C-n, C-p,
6739 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6740 auto-repeat under bidi redisplay in fontified buffers.
6741 * xdisp.c (compute_stop_pos_backwards): New function.
6742 (next_element_from_buffer): Call compute_stop_pos_backwards to
6743 find a suitable prev_stop when we find ourselves before
6744 base_level_stop.
6745 (reseat): Don't look for prev_stop, as that could mean a very long
6746 run.
6747 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6748 <cached_disp_overlay_modiff>: Cache for last found display string
6749 position.
6750 (compute_display_string_pos): Return the cached position if asked
6751 about the same buffer in the same area of character positions, and
6752 the buffer wasn't changed since the time the display string
6753 position was cached.
6754
6755 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6756
6757 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6758 is an integer, which is important for empty lines. (Bug#9149)
6759
6760 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6761
6762 * frame.c (Fmodify_frame_parameters): In tty case, update the
6763 default face if necessary (Bug#4238).
6764
6765 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6766
6767 * editfns.c (Fstring_to_char): No need to explain what a character
6768 is in the docstring (Bug#6576).
6769
6770 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6771
6772 * xml.c (parse_region): Make sure we always return a tree.
6773
6774 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6775
6776 * xml.c (parse_region): If a document contains only comments,
6777 return that, too.
6778
6779 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6780
6781 * xml.c (make_dom): Return comments, too.
6782
6783 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6784
6785 Port to OpenBSD.
6786 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6787 and the surrounding thread.
6788 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6789 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6790 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6791 timer goes off.
6792 * s/openbsd.h (BROKEN_SIGIO): Define.
6793 * unexelf.c (unexec) [__OpenBSD__]:
6794 Don't update the .mdebug section of the Alpha COFF symbol table.
6795
6796 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6797
6798 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6799 (bug#8460).
6800
6801 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6802
6803 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6804 This fixes some race conditions on the permissions of any newly
6805 created file.
6806
6807 * alloc.c (valid_pointer_p): Use pipe, not open.
6808 This fixes some permissions issues when debugging.
6809
6810 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6811 If fchown fails to set both uid and gid, try to set just gid,
6812 as that is sometimes allowed. Adjust the file's mode to eliminate
6813 setuid or setgid bits that are inappropriate if fchown fails.
6814
6815 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6816
6817 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6818 to compare Lisp_Objects.
6819 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6820 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6821 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6822
6823 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6824
6825 * lread.c (read_integer): Unread even EOF character.
6826 (read1): Likewise. Properly record start position of symbol.
6827
6828 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6829 symbol character follows.
6830
6831 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6832
6833 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6834 This works around a problem with the previous change to Fcopy_file.
6835 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6836 and without this change, GCC might complain about discarding
6837 fchown's return value.
6838
6839 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6840
6841 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6842
6843 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6844
6845 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6846
6847 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6848
6849 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6850 it's used from the C level.
6851
6852 * process.c: Use the same condition for POLL_FOR_INPUT in both
6853 keyboard.c and process.c (bug#1858).
6854
6855 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6856
6857 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6858 (Fgnutls_boot): Use it.
6859
6860 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6861
6862 * doc.c (Fsubstitute_command_keys): Revert last change.
6863
6864 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6865
6866 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6867 quotes the next character, and doesn't affect other longer
6868 sequences (bug#8935).
6869
6870 * lread.c (syms_of_lread): Clarify that is isn't only
6871 `eval-buffer' and `eval-defun' that's affected by
6872 `lexical-binding' (bug#8460).
6873
6874 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6875
6876 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6877 bidi redisplay when a line includes both an image and is truncated.
6878
6879 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6880
6881 Fix minor problems found by static checking.
6882 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6883 (elsz): Now a signed constant, not a size_t var. We prefer signed
6884 types to unsigned, to avoid integer comparison confusion. Without
6885 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6886 "cannot optimize loop, the loop counter may overflow", a symptom
6887 of the confusion.
6888 * indent.c (Fvertical_motion): Mark locals as initialized.
6889 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6890
6891 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6892
6893 * search.c (Fre_search_backward): Mention `case-fold-search' in
6894 all the re_search_* functions (bug#8138).
6895
6896 * keyboard.c (Fopen_dribble_file): Document when the file is
6897 closed (bug#8056).
6898
6899 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6900
6901 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6902 bidi_cache_idx.
6903
6904 Support bidi reordering of display and overlay strings.
6905 * xdisp.c (compute_display_string_pos)
6906 (compute_display_string_end): Accept additional argument STRING.
6907 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6908 (reseat_to_string): Initialize bidi_it->string.s and
6909 bidi_it->string.schars.
6910 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6911 NULL (avoids a crash in bidi_paragraph_init).
6912 Initialize itb.string.lstring.
6913 (init_iterator): Call bidi_init_it only of a valid
6914 buffer position was specified. Initialize paragraph_embedding to
6915 L2R.
6916 (reseat_to_string): Initialize the bidi iterator.
6917 (display_string): If we need to ignore text properties of
6918 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6919 original value of -1 will not work with bidi.)
6920 (compute_display_string_pos): First arg is now struct
6921 `text_pos *'; all callers changed. Support display properties on
6922 Lisp strings.
6923 (compute_display_string_end): Support display properties on Lisp
6924 strings.
6925 (init_iterator, reseat_1, reseat_to_string): Initialize the
6926 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6927 when iterating on a string not from display properties).
6928 (compute_display_string_pos, compute_display_string_end):
6929 Fix calculation of the object to scan. Fixes an error when using
6930 arrow keys.
6931 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6932 base_level_stop; instead, set base_level_stop to BEGV.
6933 Fixes crashes in vertical-motion.
6934 (next_element_from_buffer): Improve commentary for when
6935 the iterator is before prev_stop.
6936 (init_iterator): Initialize bidi_p from the default value of
6937 bidi-display-reordering, not from buffer-local value. Use the
6938 buffer-local value only if initializing for buffer iteration.
6939 (handle_invisible_prop): Support invisible properties on strings
6940 that are being bidi-reordered.
6941 (set_iterator_to_next): Support bidi reordering of C strings and
6942 Lisp strings.
6943 (next_element_from_string): Support bidi reordering of Lisp
6944 strings.
6945 (handle_stop_backwards): Support Lisp strings as well.
6946 (display_string): Support display of R2L glyph rows.
6947 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6948 (init_iterator): Don't initialize it->bidi_p for strings
6949 here.
6950 (reseat_to_string): Initialize it->bidi_p for strings here.
6951 (next_element_from_string, next_element_from_c_string)
6952 (next_element_from_buffer): Add xassert's for correspondence
6953 between IT's object being iterated and it->bidi_it.string
6954 structure.
6955 (face_before_or_after_it_pos): Support bidi iteration.
6956 (next_element_from_c_string): Handle the case of the first string
6957 character that is not the first one in the visual order.
6958 (get_visually_first_element): New function, refactored from common
6959 parts of next_element_from_buffer, next_element_from_string, and
6960 next_element_from_c_string.
6961 (tool_bar_lines_needed, redisplay_tool_bar)
6962 (display_menu_bar): Force left-to-right direction. Add a FIXME
6963 comment for making that be controlled by a user option.
6964 (push_it, pop_it): Save and restore the state of the
6965 bidi iterator. Save and restore the bidi_p flag.
6966 (pop_it): Iterate out of display property for string iteration as
6967 well.
6968 (iterate_out_of_display_property): Support iteration over strings.
6969 (handle_single_display_spec): Set up it->bidi_it for iteration
6970 over a display string, and call bidi_init_it.
6971 (handle_single_display_spec, next_overlay_string)
6972 (get_overlay_strings_1, push_display_prop): Set up the bidi
6973 iterator for displaying display or overlay strings.
6974 (forward_to_next_line_start): Don't use the shortcut if
6975 bidi-iterating.
6976 (back_to_previous_visible_line_start): If handle_display_prop
6977 pushed the iterator stack, restore the internal state of the bidi
6978 iterator by calling bidi_pop_it same number of times.
6979 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6980 and we are bidi-iterating, don't decrement the iterator position;
6981 instead, set the first_elt flag in the bidi iterator, to produce
6982 the same effect.
6983 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6984 (push_display_prop): xassert that we are iterating a buffer.
6985 (push_it, pop_it): Save and restore paragraph_embedding member.
6986 (handle_single_display_spec, next_overlay_string)
6987 (get_overlay_strings_1, reseat_1, reseat_to_string)
6988 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6989 correctly. Don't assume unibyte strings are not bidi-reordered.
6990 (compute_display_string_pos)
6991 (compute_display_string_end): Fix handling the case of C string.
6992 (push_it, pop_it): Save and restore from_disp_prop_p.
6993 (handle_single_display_spec, push_display_prop): Set the
6994 from_disp_prop_p flag.
6995 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6996 (pop_it): Call iterate_out_of_display_property only if we are
6997 popping after iteration over a string that came from a display
6998 property. Fix a typo in popping stretch info. Add an assertion
6999 for verifying that the iterator position is in sync with the bidi
7000 iterator.
7001 (handle_single_display_spec, get_overlay_strings_1)
7002 (push_display_prop): Fix initialization of paragraph direction for
7003 string when that of the parent object is not yet determined.
7004 (reseat_1): Call bidi_init_it to resync the bidi
7005 iterator with IT's position. (Bug#7616)
7006 (find_row_edges): If ROW->start.pos gives position
7007 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7008 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7009 Reset the from_disp_prop_p flag.
7010 (SAVE_IT, RESTORE_IT): New macros.
7011 (pos_visible_p, face_before_or_after_it_pos)
7012 (back_to_previous_visible_line_start)
7013 (move_it_in_display_line_to, move_it_in_display_line)
7014 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7015 (try_scrolling, redisplay_window, display_line): Use them when
7016 saving a temporary copy of the iterator and restoring it back.
7017 (back_to_previous_visible_line_start, reseat_1)
7018 (init_iterator): Empty the bidi cache "stack".
7019 (move_it_in_display_line_to): If iterator ended up at
7020 EOL, but we never saw any buffer positions smaller than
7021 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7022 motion in bidi-reordered lines.
7023 (move_it_in_display_line_to): Record prev_method and prev_pos
7024 immediately before the call to set_iterator_to_next. Fixes cursor
7025 motion in bidi-reordered lines with stretch glyphs and strings
7026 displayed in margins. (Bug#8133) (Bug#8867)
7027 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7028 TO_CHARPOS.
7029 (pos_visible_p): Support positions in bidi-reordered lines.
7030 Save and restore bidi cache.
7031
7032 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7033 (bidi_paragraph_info): Delete unused struct.
7034 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7035 (bidi_cache_start): New variable.
7036 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7037 to zero.
7038 (bidi_cache_fetch_state, bidi_cache_search)
7039 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7040 (bidi_cache_find, bidi_peek_at_next_level)
7041 (bidi_level_of_next_char, bidi_find_other_level_edge)
7042 (bidi_move_to_visually_next): Compare cache index with
7043 bidi_cache_start rather than with zero.
7044 (bidi_fetch_char): Accept new argument STRING; all callers
7045 changed. Support iteration over a string. Support strings with
7046 display properties. Support unibyte strings. Fix the type of
7047 `len' according to what STRING_CHAR_AND_LENGTH expects.
7048 (bidi_paragraph_init, bidi_resolve_explicit_1)
7049 (bidi_resolve_explicit, bidi_resolve_weak)
7050 (bidi_level_of_next_char, bidi_move_to_visually_next):
7051 Support iteration over a string.
7052 (bidi_set_sor_type, bidi_resolve_explicit_1)
7053 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7054 can now be zero (for strings); special values 0 and -1 were
7055 changed to -1 and -2, respectively.
7056 (bidi_char_at_pos): New function.
7057 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7058 Call it instead of FETCH_MULTIBYTE_CHAR.
7059 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7060 initialized to valid values.
7061 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7062 values.
7063 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7064 the test for valid cached positions. Fix the logic for looking up
7065 the sentinel state in the cache. GCPRO the Lisp string we are
7066 iterating.
7067 (bidi_push_it, bidi_pop_it): New functions.
7068 (bidi_initialize): Initialize the bidi cache start stack pointer.
7069 (bidi_cache_ensure_space): New function, refactored from part of
7070 bidi_cache_iterator_state. Don't assume the required size is just
7071 one BIDI_CACHE_CHUNK away.
7072 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7073 (bidi_count_bytes, bidi_char_at_pos): New functions.
7074 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7075 always valid if bidi_cache_idx is valid.
7076 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7077 is valid if it's going to be used.
7078 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7079 (bidi_cache_fetch_state, bidi_cache_search)
7080 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7081 (bidi_cache_iterator_state, bidi_cache_find)
7082 (bidi_find_other_level_edge, bidi_cache_start_stack):
7083 All variables related to cache indices are now EMACS_INT.
7084
7085 * dispextern.h (struct bidi_string_data): New structure.
7086 (struct bidi_it): New member `string'. Make flag members be 1-bit
7087 fields, and put them last in the struct.
7088 (compute_display_string_pos, compute_display_string_end):
7089 Update prototypes.
7090 (bidi_push_it, bidi_pop_it): Add prototypes.
7091 (struct iterator_stack_entry): New members bidi_p,
7092 paragraph_embedding, and from_disp_prop_p.
7093 (struct it): Member bidi_p is now a bit field 1 bit wide.
7094 (bidi_shelve_cache, bidi_unshelve_cache):
7095 Declare prototypes.
7096
7097 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7098 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7099 and vector-like objects.
7100
7101 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7102 cache around display iteration.
7103
7104 * window.c (Fwindow_end, window_scroll_pixel_based)
7105 (displayed_window_lines, Frecenter): Save and restore the bidi
7106 cache around display iteration.
7107
7108 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7109
7110 * editfns.c (Fdelete_region): Clarify the use of the named
7111 parameters (bug#6788).
7112
7113 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7114
7115 * indent.c (Fvertical_motion): Set and restore w->pointm when
7116 saving and restoring the window's buffer (Bug#9006).
7117
7118 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7119
7120 * editfns.c (Fstring_to_char): Clarify just what is returned
7121 (bug#6576). Text by Eli Zaretskii.
7122
7123 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7124
7125 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7126
7127 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7128
7129 * buffer.c (mmap_find): Fix a typo.
7130
7131 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7132
7133 Fix execution of x selection hooks.
7134 * xselect.c (Qx_lost_selection_functions)
7135 (Qx_sent_selection_functions): New vars.
7136 (syms_of_xselect): DEFSYM them.
7137 (x_handle_selection_request): Pass Qx_sent_selection_functions
7138 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7139 (x_handle_selection_clear,x_clear_frame_selections):
7140 Pass Qx_lost_selection_functions rather than
7141 Vx_lost_selection_functions to Frun_hook_with_args.
7142
7143 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7144
7145 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7146 The old code sometimes used this field without initializing it.
7147
7148 * alloc.c (gc_sweep): Don't read past end of array.
7149 In theory, the old code could also have corrupted Emacs internals,
7150 though it'd be very unlikely.
7151
7152 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7153
7154 * character.c (Fcharacterp): Don't advertise optional ignored
7155 argument. (Bug#4026)
7156
7157 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7158
7159 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7160 key" (bug#4257).
7161
7162 * window.c (Fset_window_start): Doc fix (bug#4199).
7163 (Fset_window_hscroll): Ditto.
7164
7165 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7166
7167 Fix minor new problems caught by GCC 4.6.1.
7168 * term.c (init_tty): Remove unused local.
7169 * xsettings.c (store_monospaced_changed): Define this function only
7170 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7171 not used otherwise.
7172
7173 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7174
7175 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7176
7177 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7178
7179 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7180 are the mini-buffer and the echo area (bug#3320).
7181
7182 * term.c (init_tty): Remove support for supdup, c10 and perq
7183 terminals, which are no longer supported (bug#1482).
7184
7185 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7186
7187 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7188
7189 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7190
7191 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7192 for non-popups (Bug#3642).
7193
7194 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7195
7196 * alloc.c (reset_malloc_hooks): Protoize.
7197 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7198 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7199 * cm.c (losecursor): Likewise.
7200 * data.c (fmod): Likewise.
7201 * dispnew.c (swap_glyphs_in_rows): Likewise.
7202 * emacs.c (memory_warning_signal): Likewise.
7203 * floatfns.c (float_error): Likewise.
7204 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7205 (otf_open, font_otf_capability, generate_otf_features)
7206 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7207 Likewise.
7208 * image.c (pbm_read_file): Likewise.
7209 * indent.c (string_display_width): Likewise.
7210 * intervals.c (check_for_interval, search_for_interval)
7211 (inc_interval_count, count_intervals, root_interval)
7212 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7213 * lread.c (defalias): Likewise.
7214 * ralloc.c (r_alloc_check): Likewise.
7215 * regex.c (set_image_of_range_1, set_image_of_range)
7216 (regex_grow_registers): Likewise.
7217 * sysdep.c (strerror): Likewise.
7218 * termcap.c (valid_filename_p, tprint, main): Likewise.
7219 * tparam.c (main): Likewise.
7220 * unexhp9k800.c (run_time_remap, save_data_space)
7221 (update_file_ptrs, read_header, write_header, calculate_checksum)
7222 (copy_file, copy_rest, display_header): Likewise.
7223 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7224 Likewise.
7225 * xdisp.c (check_it): Likewise.
7226 * xfaces.c (register_color, unregister_color, unregister_colors):
7227 Likewise.
7228 * xfns.c (print_fontset_result): Likewise.
7229 * xrdb.c (member, fatal, main): Likewise.
7230
7231 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7232
7233 Fix minor problems found by static checking (Bug#9031).
7234 * chartab.c (char_table_set_range, map_sub_char_table):
7235 Remove unused locals.
7236 (uniprop_table): Now static.
7237 * composite.c (_work_char): Remove unused static var.
7238
7239 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7240
7241 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7242
7243 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7244
7245 * gtkutil.c (qttip_cb): Remove code without function.
7246
7247 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7248
7249 * w32.c (pthread_sigmask): New stub.
7250
7251 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7252
7253 Use pthread_sigmask, not sigprocmask (Bug#9010).
7254 sigprocmask is portable only for single-threaded applications, and
7255 Emacs can be multi-threaded when it uses GTK.
7256 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7257 (LIBES): Use it.
7258 * callproc.c (Fcall_process):
7259 * process.c (create_process):
7260 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7261 Use pthread_sigmask, not sigprocmask.
7262
7263 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7264
7265 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7266 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7267 wrong (Bug#8591).
7268
7269 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7270
7271 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7272 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7273 (xg_hide_tooltip): Fix comment.
7274
7275 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7276 in registerServicesMenuSendTypes.
7277 (validRequestorForSendType): Don't check ns_return_types.
7278
7279 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7280 ns_return_type.
7281
7282 2011-07-08 Jason Rumney <jasonr@gnu.org>
7283
7284 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7285 SH_SHOW for hidden windows (Bug#5482).
7286
7287 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7288 frame struct members of non-existent frames (Bug#6284).
7289
7290 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7291
7292 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7293 variable firstTime not needed on OSX >= 10.6.
7294 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7295 >= 10.5. Use setKnobProportion, setDoubleValue.
7296
7297 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7298 (MAC_OS_X_VERSION_10_5): Define if not defined.
7299 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7300 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7301 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7302
7303 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7304 cString and lossyCString on OSX >= 10.4
7305
7306 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7307 sizeToFit on OSX >= 10.2.
7308
7309 * nsimage.m (allocInitFromFile): Don't use deprecated method
7310 bestRepresentationForDevice on OSX >= 10.6.
7311
7312 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7313 to avoid warning.
7314
7315 * emacs.c: Declare unexec_init_emacs_zone.
7316
7317 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7318
7319 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7320
7321 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7322 on svcsMenu (Bug#8842).
7323
7324 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7325 ns_return_types.
7326 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7327
7328 * nsterm.m (QUTF8_STRING): Declare.
7329 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7330 (validRequestorForSendType): Return type is (id).
7331 Change indexOfObjectIdenticalTo to indexOfObject.
7332 Check if we have local selection before returning self (Bug#8842).
7333 (writeSelectionToPasteboard): Put local selection into paste board
7334 if we have a local selection (Bug#8842).
7335 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7336
7337 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7338 (ns_get_local_selection): Declare.
7339
7340 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7341
7342 * keymap.c (describe_map_tree): Don't insert a double newline at
7343 the end of the buffer (bug#1169) and return whether we inserted
7344 something.
7345
7346 * callint.c (Fcall_interactively): Change "reading args" to
7347 "providing args" to try to clarify what it does (bug#1010).
7348
7349 2011-07-07 Kenichi Handa <handa@m17n.org>
7350
7351 * composite.c (composition_compute_stop_pos): Ignore a static
7352 composition starting before CHARPOS (Bug#8915).
7353
7354 * xdisp.c (handle_composition_prop): Likewise.
7355
7356 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7357
7358 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7359 (Bug#9015)
7360
7361 2011-07-07 Kenichi Handa <handa@m17n.org>
7362
7363 * character.h (unicode_category_t): New enum type.
7364
7365 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7366 (Qchar_code_property_table): New variable.
7367 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7368 (UNIPROP_COMPRESSED_FORM_P): New macros.
7369 (char_table_ascii): Uncompress the compressed values.
7370 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7371 Uncompress the compressed values.
7372 (sub_char_table_ref_and_range): Likewise.
7373 (char_table_ref_and_range): Uncompress the compressed values.
7374 (sub_char_table_set): New arg is_uniprop. Callers changed.
7375 Uncompress the compressed values.
7376 (sub_char_table_set_range): Args changed. Callers changed.
7377 (char_table_set_range): Adjuted for the above change.
7378 (map_sub_char_table): Delete args default_val and parent. Add arg
7379 top. Give decoded values to a Lisp function.
7380 (map_char_table): Adjust for the above change. Give decoded
7381 values to a Lisp function. Gcpro more variables.
7382 (uniprop_table_uncompress)
7383 (uniprop_decode_value_run_length): New functions.
7384 (uniprop_decoder, uniprop_decoder_count): New variables.
7385 (uniprop_get_decoder, uniprop_encode_value_character)
7386 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7387 New functions.
7388 (uniprop_encoder, uniprop_encoder_count): New variables.
7389 (uniprop_get_encoder, uniprop_table)
7390 (Funicode_property_table_internal, Fget_unicode_property_internal)
7391 (Fput_unicode_property_internal): New functions.
7392 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7393 Sunicode_property_table_internal, Sget_unicode_property_internal,
7394 and Sput_unicode_property_internal. Defvar_lisp
7395 char-code-property-alist.
7396
7397 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7398 Vunicode_category_table.
7399
7400 * font.c (font_range): Adjust for the change of
7401 Vunicode_category_table.
7402
7403 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7404
7405 * m/iris4d.h: Remove file, move contents ...
7406 * s/irix6-5.h: ... here.
7407
7408 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7409
7410 Remove unportable assumption about struct layout (Bug#8884).
7411 * alloc.c (mark_buffer):
7412 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7413 (clone_per_buffer_values): Don't assume that
7414 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7415 This isn't true in general, and it's particularly not true
7416 if Emacs is configured with --with-wide-int.
7417 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7418 New macros, used in the buffer.c change.
7419
7420 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7421
7422 * xsettings.c: Use both GConf and GSettings if both are available.
7423 (store_config_changed_event): Add comment.
7424 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7425 (store_tool_bar_style_changed): New functions.
7426 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7427 (struct xsettings): Move font inside HAVE_XFT.
7428 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7429 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7430 Move inside HAVE_XFT.
7431 (something_changed_gsettingsCB): Rename from something_changedCB.
7432 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7433 also.
7434 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7435 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7436 (something_changed_gconfCB): Rename from something_changedCB.
7437 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7438 (parse_settings): Move check for font inside HAVE_XFT.
7439 (read_settings, apply_xft_settings): Add comment.
7440 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7441 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7442 call store_font_name_changed.
7443 (xft_settings_event): Add comment.
7444 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7445 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7446 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7447 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7448 (xsettings_initialize): Call init_gsettings last.
7449 (xsettings_get_system_font, xsettings_get_system_normal_font):
7450 Add comment.
7451
7452 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7453
7454 Random fixes. E.g., (random) never returned negative values.
7455 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7456 subseconds part to the entropy, as that's a bit more random.
7457 Prefer signed to unsigned, since the signedness doesn't matter and
7458 in general we prefer signed. When given a limit, use a
7459 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7460 latter isn't right if USE_2_TAGS_FOR_INTS.
7461 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7462 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7463
7464 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7465
7466 * textprop.c (text_property_stickiness):
7467 Obey Vtext_property_default_nonsticky.
7468 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7469 * w32fns.c (syms_of_w32fns):
7470 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7471
7472 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7473
7474 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7475 This is more efficient than Ffile_directory_p and avoids a minor race.
7476
7477 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7478
7479 * buffer.c (Foverlay_put): Say what the return value is
7480 (bug#7835).
7481
7482 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7483 is a directory before asking whether to use the file name
7484 (bug#7564).
7485 (barf_or_query_if_file_exists): Make the "File is a directory"
7486 error be more correct.
7487
7488 * fns.c (Frequire): Remove the mention of the .gz files, since
7489 that's installation-specific, but keep the mention of
7490 `get-load-suffixes'.
7491
7492 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7493
7494 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7495 Report string overflow if the output is too long.
7496
7497 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7498
7499 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7500 (syms_of_gnutls): Remove duplicate DEFSYM for
7501 Qgnutls_bootprop_verify_hostname_error, an error for
7502 Qgnutls_bootprop_verify_error (which is no longer used).
7503
7504 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7505 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7506 Also (re)move comments that are misplaced or no longer relevant.
7507
7508 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7509
7510 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7511
7512 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7513
7514 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7515 and background color parameters if they have been changed.
7516
7517 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7518
7519 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7520
7521 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7522
7523 * xsettings.c (SYSTEM_FONT): Define only when used.
7524 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7525
7526 * keymap.c (access_keymap_1): Now static.
7527
7528 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7529
7530 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7531 leave any prefix arg for the up event (Bug#1586).
7532
7533 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7534
7535 * lread.c (syms_of_lread): Mention single symbols defined by
7536 `defvar' or `defconst' (bug#7154).
7537
7538 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7539 (Frequire): Mention get-load-suffixes.
7540
7541 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7542
7543 * window.h (window): Remove clone_number slot.
7544 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7545 Remove.
7546 (make_parent_window, make_window, saved_window)
7547 (Fset_window_configuration, save_window_save): Don't deal with
7548 clone numbers.
7549 * buffer.c (Qclone_number): Remove declaration.
7550 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7551
7552 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7553
7554 Add multiple inheritance to keymaps.
7555 * keymap.c (Fmake_composed_keymap): New function.
7556 (Fset_keymap_parent): Simplify.
7557 (fix_submap_inheritance): Remove.
7558 (access_keymap_1): New function extracted from access_keymap to handle
7559 embedded parents and handle lists of maps.
7560 (access_keymap): Use it.
7561 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7562 (Fcopy_keymap): Handle embedded parents.
7563 (Fcommand_remapping, define_as_prefix): Simplify.
7564 (Fkey_binding): Simplify.
7565 (syms_of_keymap): Move minibuffer-local-completion-map,
7566 minibuffer-local-filename-completion-map,
7567 minibuffer-local-must-match-map, and
7568 minibuffer-local-filename-must-match-map to Elisp.
7569 (syms_of_keymap): Defsubr make-composed-keymap.
7570 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7571 (parse_menu_item): Trivial simplification.
7572
7573 2011-07-01 Glenn Morris <rgm@gnu.org>
7574
7575 * Makefile.in (SETTINGS_LIBS): Fix typo.
7576
7577 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7578
7579 * coding.c (Fencode_coding_string): Record the last coding system
7580 used, as the function doc string says (bug#8738).
7581
7582 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7583
7584 * xsettings.c (store_monospaced_changed): Take new font as arg and
7585 check for change against current_mono_font.
7586 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7587 (emacs_settings_constructor, emacs_settings_get_property)
7588 (emacs_settings_set_property, emacs_settings_class_init)
7589 (emacs_settings_init, gsettings_obj): Remove.
7590 (something_changedCB): New function for HAVE_GSETTINGS.
7591 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7592 with value as argument.
7593 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7594 g_settings_new (Bug#8967). Do not create gsettings_obj.
7595 Remove calls to g_settings_bind. Connect something_changedCB to
7596 "changed".
7597
7598 * xgselect.c: Add defined (HAVE_GSETTINGS).
7599 (xgselect_initialize): Ditto.
7600
7601 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7602 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7603 xg_select.
7604
7605 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7606
7607 * eval.c (struct backtrace): Simplify and port the data structure.
7608 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7609 signed bit field, as this assumption is not portable and it makes
7610 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7611 "char debug_on_exit : 1" as this is not portable either; instead,
7612 use the portable "unsigned int debug_on_exit : 1". Remove unused
7613 member evalargs. Remove obsolete comments about cc bombing out.
7614
7615 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7616
7617 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7618 Let HAVE_GSETTINGS override HAVE_GCONF.
7619 (store_monospaced_changed): New function.
7620 (EMACS_SETTINGS): A new type derived from GObject to handle
7621 GSettings notifications.
7622 (emacs_settings_constructor, emacs_settings_get_property)
7623 (emacs_settings_set_property, emacs_settings_class_init):
7624 New functions.
7625 (gsettings_client, gsettings_obj): New variables.
7626 (GSETTINGS_SCHEMA): New define.
7627 (something_changedCB): Call store_monospaced_changed.
7628 (init_gsettings): New function.
7629 (xsettings_initialize): Call init_gsettings.
7630 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7631 to NULL.
7632
7633 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7634 GCONF_CFLAGS/LIBS.
7635
7636 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7637
7638 * window.c (resize_root_window, grow_mini_window)
7639 (shrink_mini_window): Rename Qresize_root_window to
7640 Qwindow_resize_root_window and Qresize_root_window_vertically to
7641 Qwindow_resize_root_window_vertically.
7642
7643 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7644
7645 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7646
7647 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7648
7649 * makefile.w32-in: Redesign dependencies so they reflect more
7650 clearly which files are directly included by each source file,
7651 and not through other includes.
7652
7653 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7654
7655 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7656 (sort_overlays, overlay_strings): When an overlay's clone number
7657 matches the window's clone number process the overlay even if
7658 the overlay's window property doesn't match the current window.
7659
7660 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7661 (Fwindow_hchild): Rename to Fwindow_left_child.
7662 (Fwindow_next): Rename to Fwindow_next_sibling.
7663 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7664 (resize_window_check): Rename to window_resize_check.
7665 (resize_window_apply): Rename to window_resize_apply.
7666 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7667 (Fdelete_other_windows_internal, resize_frame_windows)
7668 (Fsplit_window_internal, Fdelete_window_internal)
7669 (grow_mini_window, shrink_mini_window)
7670 (Fresize_mini_window_internal): Fix callers accordingly.
7671
7672 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7673
7674 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7675 (emacs_fixed_set_min_size): Remove.
7676 (emacs_fixed_new): Take frame as argument.
7677
7678 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7679 (_EmacsFixedPrivate): Remove minwidth/height.
7680 Add struct frame *f.
7681 (emacs_fixed_init): Initialize priv->f.
7682 (get_parent_class, emacs_fixed_set_min_size): Remove.
7683 (emacs_fixed_new): Set priv->f to argument.
7684 (emacs_fixed_get_preferred_width)
7685 (emacs_fixed_get_preferred_height): Use min_width/height from
7686 frames size_hint to set minimum and natural (Bug#8919).
7687 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7688 and use min_width/height from frames size_hint to set
7689 min_width/height (Bug#8919).
7690
7691 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7692 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7693 Fix indentation.
7694
7695 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7696
7697 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7698 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7699 called at ZV.
7700
7701 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7702
7703 * process.c (wait_reading_process_output): Bypass select if
7704 waiting for a cell while ignoring keyboard input, and input is
7705 pending. Suggested by Jan Djärv (Bug#8869).
7706
7707 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7708
7709 Use gnulib's dup2 module instead of rolling our own.
7710 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7711
7712 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7713
7714 * dispnew.c (scrolling_window): Before scrolling, turn off a
7715 mouse-highlight in the window being scrolled.
7716
7717 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7718
7719 Move DEFSYM to lisp.h and use everywhere.
7720
7721 * character.h (DEFSYM): Move declaration...
7722 * lisp.h (DEFSYM): ...here.
7723
7724 * gnutls.c:
7725 * minibuf.c:
7726 * w32menu.c:
7727 * w32proc.c:
7728 * w32select.c: Don't include character.h.
7729
7730 * alloc.c (syms_of_alloc):
7731 * buffer.c (syms_of_buffer):
7732 * bytecode.c (syms_of_bytecode):
7733 * callint.c (syms_of_callint):
7734 * casefiddle.c (syms_of_casefiddle):
7735 * casetab.c (init_casetab_once):
7736 * category.c (init_category_once, syms_of_category):
7737 * ccl.c (syms_of_ccl):
7738 * cmds.c (syms_of_cmds):
7739 * composite.c (syms_of_composite):
7740 * dbusbind.c (syms_of_dbusbind):
7741 * dired.c (syms_of_dired):
7742 * dispnew.c (syms_of_display):
7743 * doc.c (syms_of_doc):
7744 * editfns.c (syms_of_editfns):
7745 * emacs.c (syms_of_emacs):
7746 * eval.c (syms_of_eval):
7747 * fileio.c (syms_of_fileio):
7748 * fns.c (syms_of_fns):
7749 * frame.c (syms_of_frame):
7750 * fringe.c (syms_of_fringe):
7751 * insdel.c (syms_of_insdel):
7752 * keymap.c (syms_of_keymap):
7753 * lread.c (init_obarray, syms_of_lread):
7754 * macros.c (syms_of_macros):
7755 * msdos.c (syms_of_msdos):
7756 * print.c (syms_of_print):
7757 * process.c (syms_of_process):
7758 * search.c (syms_of_search):
7759 * sound.c (syms_of_sound):
7760 * syntax.c (init_syntax_once, syms_of_syntax):
7761 * terminal.c (syms_of_terminal):
7762 * textprop.c (syms_of_textprop):
7763 * undo.c (syms_of_undo):
7764 * w32.c (globals_of_w32):
7765 * window.c (syms_of_window):
7766 * xdisp.c (syms_of_xdisp):
7767 * xfaces.c (syms_of_xfaces):
7768 * xfns.c (syms_of_xfns):
7769 * xmenu.c (syms_of_xmenu):
7770 * xsettings.c (syms_of_xsettings):
7771 * xterm.c (syms_of_xterm): Use DEFSYM.
7772
7773 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7774
7775 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7776
7777 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7778
7779 Integer and buffer overflow fixes (Bug#8873).
7780
7781 * print.c (printchar, strout): Check for string overflow.
7782 (PRINTPREPARE, printchar, strout):
7783 Don't set size unless allocation succeeds.
7784
7785 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7786 for sizes. Check for string overflow more accurately.
7787 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7788
7789 * macros.c: Integer and buffer overflow fixes.
7790 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7791 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7792 Use ptrdiff_t, not int, for sizes.
7793 Don't increment bufsize until after realloc succeeds.
7794 Check for size-calculation overflow.
7795 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7796
7797 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7798
7799 * lread.c: Integer overflow fixes.
7800 (read_integer): Radix is now EMACS_INT, not int,
7801 to improve quality of diagnostics for out-of-range radices.
7802 Calculate buffer size correctly for out-of-range radices.
7803 (read1): Check for integer overflow in radices, and in
7804 read-circle numbers.
7805 (read_escape): Avoid int overflow.
7806 (Fload, openp, read_buffer_size, read1)
7807 (substitute_object_recurse, read_vector, read_list, map_obarray):
7808 Use ptrdiff_t, not int, for sizes.
7809 (read1): Use EMACS_INT, not int, for sizes.
7810 Check for size overflow.
7811
7812 * image.c (cache_image): Check for size arithmetic overflow.
7813
7814 * lread.c: Integer overflow issues.
7815 (saved_doc_string_size, saved_doc_string_length)
7816 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7817 Now ptrdiff_t, not int.
7818 (read1): Don't assume doc string length fits in int. Check for
7819 out-of-range doc string lengths.
7820 (read_list): Don't assume file position fits in int.
7821 (read_escape): Check for hex character overflow.
7822
7823 2011-06-22 Leo Liu <sdl.web@gmail.com>
7824
7825 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7826 Move to minibuffer.el.
7827
7828 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7829
7830 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7831 The following patches are for when GLYPH_DEBUG && !XASSERT.
7832 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7833 * dispnew.c (flush_stdout):
7834 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7835 Mark as externally visible.
7836 * dispnew.c (check_window_matrix_pointers): Now static.
7837 * dispnew.c (window_to_frame_vpos):
7838 * xfns.c (unwind_create_frame):
7839 * xterm.c (x_check_font): Remove unused local.
7840 * scroll.c (CHECK_BOUNDS):
7841 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7842 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7843 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7844 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7845 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7846 Now static.
7847 (debug_method_add): Use va_list and vsprintf rather than relying
7848 on undefined behavior with wrong number of arguments.
7849 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7850 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7851 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7852 since we're not interested in debugging glyphs with old libraries.
7853 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7854 GCC 4.6.0's static checking.
7855
7856 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7857
7858 Integer overflow and signedness fixes (Bug#8873).
7859 A few related buffer overrun fixes, too.
7860
7861 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7862
7863 * dispextern.h (struct face.stipple):
7864 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7865 (x_bitmap_mask, x_allocate_bitmap_record)
7866 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7867 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7868 (x_create_bitmap_from_xpm_data):
7869 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7870 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7871 (.bitmaps_last):
7872 * xfaces.c (load_pixmap):
7873 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7874 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7875 (.bitmaps_last, struct x_output.icon_bitmap):
7876 Use ptrdiff_t, not int, for bitmap indexes.
7877 (x_allocate_bitmap_record): Check for size overflow.
7878 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7879
7880 Use ptrdiff_t, not int, for overlay counts.
7881 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7882 * editfns.c (overlays_around, get_pos_property):
7883 * textprop.c (get_char_property_and_overlay):
7884 * xdisp.c (next_overlay_change, note_mouse_highlight):
7885 * xfaces.c (face_at_buffer_position):
7886 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7887 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7888 (Fnext_overlay_change, Fprevious_overlay_change)
7889 (mouse_face_overlay_overlaps, Foverlays_in):
7890 Use ptrdiff_t, not int, for sizes.
7891 (overlays_at, overlays_in): Check for size-calculation overflow.
7892
7893 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7894
7895 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7896 (x_session_initialize): Do not assume string length fits in int.
7897
7898 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7899 This is unlikely, but can occur if DPI is outlandish.
7900
7901 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7902 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7903
7904 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7905 * xrdb.c (magic_file_p, search_magic_path):
7906 Omit last arg SUFFIX; it was always 0. All callers changed.
7907 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7908
7909 * xfont.c (xfont_match): Avoid need for strlen.
7910
7911 * xfns.c: Don't assume strlen fits in int.
7912 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7913
7914 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7915 not unsigned long, as we prefer signed integers. All callers changed.
7916 Detect integer overflow in repeat count.
7917 (message_dolog): Don't assume print length fits in 39 bytes.
7918 (display_mode_element): Don't assume strlen fits in int.
7919
7920 * termcap.c: Don't assume sizes fit in int and never overflow.
7921 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7922 (gobble_line): Check for size-calculation overflow.
7923
7924 * minibuf.c (Fread_buffer):
7925 * lread.c (intern, intern_c_string):
7926 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7927 Don't assume string length fits in int.
7928
7929 * keyboard.c (parse_tool_bar_item):
7930 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7931
7932 * font.c: Don't assume string length fits in int.
7933 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7934 Use ptrdiff_t, not int.
7935 (font_intern_prop): Don't assume string length fits in int.
7936 Don't assume integer property fits in fixnum.
7937 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7938
7939 * filelock.c: Fix some buffer overrun and integer overflow issues.
7940 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7941 Reformulate so as not to need the command string.
7942 Invoke gzip -cd rather than gunzip, as it's more portable.
7943 (lock_info_type, lock_file_1, lock_file):
7944 Don't assume pid_t and time_t fit in unsigned long.
7945 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7946 (current_lock_owner): Prefer signed type for sizes.
7947 Use memcpy, not strncpy, where memcpy is what is really wanted.
7948 Don't assume (via atoi) that time_t and pid_t fit in int.
7949 Check for time_t and/or pid_t out of range, e.g., via a network share.
7950 Don't alloca where an auto var works fine.
7951
7952 * fileio.c: Fix some integer overflow issues.
7953 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7954 Don't assume string length fits in int.
7955 (directory_file_name): Don't assume string length fits in long.
7956 (make_temp_name): Don't assume pid fits in int, or that its print
7957 length is less than 20.
7958
7959 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7960
7961 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7962
7963 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7964
7965 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7966 We prefer signed integers, even for size calculations.
7967
7968 * emacs.c: Don't assume string length fits in 'int'.
7969 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7970 (main): Don't invoke strlen when not needed.
7971
7972 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7973 (XD_DEBUG_MESSAGE): Don't waste a byte.
7974
7975 * callproc.c (getenv_internal_1, getenv_internal)
7976 (Fgetenv_internal):
7977 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7978
7979 * lread.c (invalid_syntax): Omit length argument.
7980 All uses changed. This doesn't fix a bug, but it simplifies the
7981 code away from its former Hollerith-constant appearance, and it's
7982 one less 'int' to worry about when looking at integer-overflow issues.
7983 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7984
7985 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7986 This didn't break anything, but it didn't help either.
7987 It's confusing to put a bogus integer in a place where the actual
7988 value does not matter.
7989 (LIST_END_P): Remove unused macro and its bogus comment.
7990 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7991
7992 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7993 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7994 implementation.
7995 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7996 We prefer signed types, and the value cannot exceed the EMACS_INT
7997 range anyway (because otherwise the length would not be representable).
7998 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7999 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8000 This avoids a GCC warning when WIDE_EMACS_INT.
8001
8002 * indent.c (sane_tab_width): New function.
8003 (current_column, scan_for_column, Findent_to, position_indentation)
8004 (compute_motion): Use it. This is just for clarity.
8005 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8006
8007 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8008
8009 * lisp.h (lint_assume): New macro.
8010 * composite.c (composition_gstring_put_cache):
8011 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8012
8013 * editfns.c, insdel.c:
8014 Omit unnecessary forward decls, to simplify future changes.
8015
8016 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8017
8018 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8019
8020 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8021 Use much-faster test for byte-length change.
8022 Don't assume string byte-length fits in 'int'.
8023 Check that character arg fits in 'int'.
8024 (mapcar1): Declare byte as byte, for clarity.
8025
8026 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8027
8028 * fns.c (concat): Catch string overflow earlier.
8029 Do not rely on integer wraparound.
8030
8031 * dispextern.h (struct it.overlay_strings_charpos)
8032 (struct it.selective): Now EMACS_INT, not int.
8033 * xdisp.c (forward_to_next_line_start)
8034 (back_to_previous_visible_line_start)
8035 (reseat_at_next_visible_line_start, next_element_from_buffer):
8036 Don't arbitrarily truncate the value of 'selective' to int.
8037
8038 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8039
8040 * composite.c: Don't truncate sizes to 'int'.
8041 (composition_gstring_p, composition_reseat_it)
8042 (composition_adjust_point): Use EMACS_INT, not int.
8043 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8044 not EMACS_UINT, for indexes.
8045
8046 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8047
8048 * buffer.c: Include <verify.h>.
8049 (struct sortvec.priority, struct sortstr.priority):
8050 Now EMACS_INT, not int.
8051 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8052 (struct sortstr.size, record_overlay_string)
8053 (struct sortstrlist.size, struct sortlist.used):
8054 Don't truncate size to int.
8055 (record_overlay_string): Check for size-calculation overflow.
8056 (init_buffer_once): Check at compile-time, not run-time.
8057
8058 2011-06-22 Jim Meyering <meyering@redhat.com>
8059
8060 Don't leak an XBM-image-sized buffer
8061 * image.c (xbm_load): Free the image buffer after using it.
8062
8063 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8064
8065 Port to Sun C.
8066 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8067 that Sun C diagnosed.
8068 * fns.c (secure_hash): Fix pointer signedness issue.
8069 * intervals.c (static_offset_intervals): New function.
8070 (offset_intervals): Use it.
8071
8072 2011-06-21 Leo Liu <sdl.web@gmail.com>
8073
8074 * deps.mk (fns.o):
8075 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8076 sha512.h.
8077
8078 * fns.c (secure_hash): Rename from crypto_hash_function and change
8079 the first arg to accept symbols.
8080 (Fsecure_hash): New primitive.
8081 (syms_of_fns): New symbols.
8082
8083 2011-06-20 Deniz Dogan <deniz@dogan.se>
8084
8085 * process.c (Fset_process_buffer): Clarify return value in
8086 docstring.
8087
8088 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8089
8090 * dispnew.c (add_window_display_history): Use BVAR.
8091
8092 * xdisp.c (debug_method_add): Use BVAR.
8093 (check_window_end, dump_glyph_matrix, dump_glyph)
8094 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8095
8096 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8097 Likewise.
8098
8099 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8100 check till after the cache is created in init_frame_faces.
8101
8102 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8103
8104 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8105
8106 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8107
8108 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8109 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8110 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8111
8112 Improve buffer-overflow checking (Bug#8873).
8113 * fileio.c (Finsert_file_contents):
8114 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8115 Remove the old (too-loose) buffer overflow checks.
8116 They weren't needed, since make_gap checks for buffer overflow.
8117 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8118 The old code merely checked for Emacs fixnum overflow, and relied
8119 on undefined (wraparound) behavior. The new code avoids undefined
8120 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8121
8122 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8123 Tune. Don't use wider integers than needed. Don't use alloca.
8124 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8125
8126 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8127
8128 * insdel.c, lisp.h (buffer_overflow): New function.
8129 (insert_from_buffer_1, replace_range, replace_range_2):
8130 * insdel.c (make_gap_larger):
8131 * editfns.c (Finsert_char):
8132 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8133
8134 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8135
8136 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8137
8138 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8139
8140 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8141 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8142
8143 * fileio.c: Don't assume EMACS_INT fits in off_t.
8144 (emacs_lseek): New static function.
8145 (Finsert_file_contents, Fwrite_region): Use it.
8146 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8147
8148 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8149
8150 * fns.c: Don't overflow int when computing a list length.
8151 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8152 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8153 truncation on 64-bit hosts. Check for QUIT every
8154 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8155 faster and is responsive enough.
8156 (Flength): Report an error instead of overflowing an integer.
8157 (Fsafe_length): Return a float if the value is not representable
8158 as a fixnum. This shouldn't happen except in contrived situations.
8159 (Fnthcdr, Fsort): Don't assume list length fits in int.
8160 (Fcopy_sequence): Don't assume vector length fits in int.
8161
8162 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8163 (header_size, word_size): New constants.
8164 (allocate_vectorlike): Don't check size overflow here.
8165 (allocate_vector): Check it here instead, since this is the only
8166 caller of allocate_vectorlike that could cause overflow.
8167 Check that the new vector's length is representable as a fixnum.
8168
8169 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8170 The previous code was bogus. For example, next_almost_prime (32)
8171 returned 39, which is undesirable as it is a multiple of 3; and
8172 next_almost_prime (24) returned 25, which is a multiple of 5 so
8173 why was the code bothering to check for multiples of 7?
8174
8175 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8176
8177 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8178
8179 Variadic C functions now count arguments with ptrdiff_t.
8180 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8181 Back then I didn't know that the Emacs coding style prefers signed int.
8182 Also, in the meantime I found a few more instances where arguments
8183 were being counted with int, which may truncate counts on 64-bit
8184 machines, or EMACS_INT, which may be unnecessarily wide.
8185 * lisp.h (struct Lisp_Subr.function.aMANY)
8186 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8187 Arg counts are now ptrdiff_t, not size_t.
8188 All variadic functions and their callers changed accordingly.
8189 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8190 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8191 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8192 * callint.c (Fcall_interactively): Check arg count for overflow,
8193 to avoid potential buffer overrun. Use signed char, not 'int',
8194 for 'varies' array, so that we needn't bother to check its size
8195 calculation for overflow.
8196 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8197 * eval.c (apply_lambda):
8198 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8199 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8200 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8201
8202 * callint.c (Fcall_interactively): Don't use index var as event count.
8203
8204 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8205 * mem-limits.h (SIZE): Remove; no longer used.
8206
8207 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8208
8209 Remove unnecessary casts.
8210 * xterm.c (x_term_init):
8211 * xfns.c (x_set_border_pixel):
8212 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8213 These aren't needed now that we assume ANSI C.
8214
8215 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8216 It's more likely to cause problems (due to unsigned overflow)
8217 than to cure them.
8218
8219 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8220
8221 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8222
8223 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8224
8225 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8226
8227 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8228
8229 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8230
8231 GLYPH_CODE_FACE returns EMACS_INT, not int.
8232 * dispextern.h (merge_faces):
8233 * xfaces.c (merge_faces):
8234 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8235 Don't assume EMACS_INT fits in int.
8236
8237 * character.h (CHAR_VALID_P): Remove unused parameter.
8238 * fontset.c, lisp.h, xdisp.c: All uses changed.
8239
8240 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8241
8242 * fns.c (concat): Minor tuning based on overflow analysis.
8243 This doesn't fix any bugs. Use int to hold character, instead
8244 of constantly refetching from Emacs object. Use XFASTINT, not
8245 XINT, for value known to be a character. Don't bother comparing
8246 a single byte to 0400, as it's always less.
8247
8248 * floatfns.c (Fexpt):
8249 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8250
8251 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8252 for characters.
8253
8254 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8255
8256 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8257 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8258 incorrectly succeed when S was a string, because 4294967386 was
8259 truncated before it was used.
8260
8261 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8262 Otherwise, an out-of-range integer could cause undefined behavior
8263 on a 64-bit host.
8264
8265 * composite.c: Use int, not EMACS_INT, for characters.
8266 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8267 EMACS_INT, for values that are known to be in character range.
8268 This doesn't fix any bugs but is the usual style inside Emacs and
8269 may generate better code on 32-bit machines.
8270
8271 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8272 This is for reasons similar to the recent CHAR_STRING fix.
8273 * charset.c (Fencode_char): Check that character arg is actually
8274 a character. Pass an int to ENCODE_CHAR.
8275 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8276 wider than 'int', as a compile-time check to prevent future regressions
8277 in this area.
8278
8279 * character.c (char_string): Remove unnecessary casts.
8280
8281 Make sure a 64-bit char is never passed to CHAR_STRING.
8282 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8283 by silently ignoring the top 32 bits, allowing some values
8284 that were far too large to be valid characters.
8285 * character.h: Include <verify.h>.
8286 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8287 arguments are no wider than unsigned, as a compile-time check
8288 to prevent future regressions in this area.
8289 * data.c (Faset):
8290 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8291 (Fsubst_char_in_region):
8292 * fns.c (concat):
8293 * xdisp.c (decode_mode_spec_coding):
8294 Adjust to CHAR_STRING's new requirement.
8295 * editfns.c (Finsert_char, Fsubst_char_in_region):
8296 * fns.c (concat): Check that character args are actually
8297 characters. Without this test, these functions did the wrong
8298 thing with wildly out-of-range values on 64-bit hosts.
8299
8300 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8301 These casts should not be needed on 32-bit hosts, either.
8302 * keyboard.c (read_char):
8303 * lread.c (Fload): Remove casts to unsigned.
8304
8305 * lisp.h (UNSIGNED_CMP): New macro.
8306 This fixes comparison bugs on 64-bit hosts.
8307 (ASCII_CHAR_P): Use it.
8308 * casefiddle.c (casify_object):
8309 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8310 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8311 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8312 * dispextern.h (FACE_FROM_ID):
8313 * keyboard.c (read_char): Use UNSIGNED_CMP.
8314
8315 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8316 not to EMACS_INT, to avoid GCC warning.
8317
8318 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8319
8320 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8321 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8322 isn't needed on 32-bit machines.
8323
8324 * buffer.c (Fgenerate_new_buffer_name):
8325 Use EMACS_INT for count, not int.
8326 (advance_to_char_boundary): Return EMACS_INT, not int.
8327
8328 * data.c (Qcompiled_function): Now static.
8329
8330 * window.c (window_body_lines): Now static.
8331
8332 * image.c (gif_load): Rename local to avoid shadowing.
8333
8334 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8335 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8336 * alloc.c (make_save_value): Integer argument is now of type
8337 ptrdiff_t, not int.
8338 (mark_object): Use ptrdiff_t, not int.
8339 * lisp.h (pD): New macro.
8340 * print.c (print_object): Use it.
8341
8342 * alloc.c: Use EMACS_INT, not int, to count objects.
8343 (total_conses, total_markers, total_symbols, total_vector_size)
8344 (total_free_conses, total_free_markers, total_free_symbols)
8345 (total_free_floats, total_floats, total_free_intervals)
8346 (total_intervals, total_strings, total_free_strings):
8347 Now EMACS_INT, not int. All uses changed.
8348 (Fgarbage_collect): Compute overall total using a double, so that
8349 integer overflow is less likely to be a problem. Check for overflow
8350 when converting back to an integer.
8351 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8352 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8353 These were 'int' variables that could overflow on 64-bit hosts;
8354 they were never used, so remove them instead of repairing them.
8355 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8356 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8357 Previously, this ceilinged at INT_MAX, but that doesn't work on
8358 64-bit machines.
8359 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8360
8361 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8362 (allocate_vectorlike): Check for ptrdiff_t overflow.
8363 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8364 when a (possibly-narrower) signed value would do just as well.
8365 We prefer using signed arithmetic, to avoid comparison confusion.
8366
8367 * alloc.c: Catch some string size overflows that we were missing.
8368 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8369 for convenience in STRING_BYTES_MAX.
8370 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8371 The definition here is exact; the one in lisp.h was approximate.
8372 (allocate_string_data): Check for string overflow. This catches
8373 some instances we weren't catching before. Also, it catches
8374 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8375 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8376 and ptrdiff_t and EMACS_INT are both 64 bits.
8377
8378 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8379 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8380 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8381
8382 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8383
8384 * alloc.c (Fmake_string): Check for out-of-range init.
8385
8386 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8387
8388 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8389
8390 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8391
8392 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8393 xg_get_default_scrollbar_width.
8394
8395 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8396 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8397 (style_changed_cb): Call update_theme_scrollbar_width and call
8398 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8399 all frames (Bug#8505).
8400 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8401 Call gtk_window_set_resizable if HAVE_GTK3.
8402 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8403 and height if HAVE_GTK3 (Bug#8505).
8404 (scroll_bar_width_for_theme): New variable.
8405 (update_theme_scrollbar_width): New function.
8406 (xg_get_default_scrollbar_width): Move code to
8407 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8408 (xg_initialize): Call update_theme_scrollbar_width.
8409
8410 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8411
8412 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8413
8414 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8415
8416 * frame.c (make_frame): Call other_buffer_safely instead of
8417 other_buffer.
8418
8419 * window.c (temp_output_buffer_show): Call display_buffer with
8420 second argument Vtemp_buffer_show_specifiers and reset latter
8421 immediately after the call.
8422 (Vtemp_buffer_show_specifiers): New variable.
8423 (auto_window_vscroll_p, next_screen_context_lines)
8424 (Vscroll_preserve_screen_position): Remove leading asterisks from
8425 doc-strings.
8426
8427 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8428
8429 Fix minor problems found by GCC 4.6.0 static checking.
8430 * buffer.c (Qclone_number): Remove for now, as it's unused.
8431 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8432 (record_buffer): Remove unused local.
8433 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8434 (set_frame_buffer_list): Remove; unused.
8435 * frame.h (other_visible_frames): Remove decl.
8436 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8437 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8438 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8439 if HAVE_GPM.
8440 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8441 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8442 Define only if HAVE_GPM.
8443 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8444 (update_hints_inhibit): Remove; never set. All uses removed.
8445 * widgetprv.h (emacsFrameClassRec): Remove decl.
8446 * window.c (delete_deletable_window): Now returns void, since it
8447 wasn't returning anything.
8448 (compare_window_configurations): Remove unused locals.
8449 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8450 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8451 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8452 the same widths as pointers. This follows up on the 2011-05-06 patch.
8453 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8454 * xterm.h: Likewise.
8455 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8456
8457 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8458
8459 * makefile.w32-in: Update dependencies.
8460 (LISP_H): Add lib/intprops.h.
8461
8462 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8463
8464 * image.c (gif_load): Add animation frame delay to the metadata.
8465 (syms_of_image): Use DEFSYM. New symbol `delay'.
8466
8467 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8468
8469 * window.c (delete_deletable_window): Re-add.
8470 (Fset_window_configuration): Rewrite to handle dead buffers and
8471 consequently deletable windows.
8472 (window_tree, Fwindow_tree): Remove. Supply functionality in
8473 window.el.
8474 (compare_window_configurations): Simplify code.
8475
8476 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8477
8478 * image.c (imagemagick_load_image): Fix type mismatch.
8479 (Fimagemagick_types): Likewise.
8480
8481 * window.h (replace_buffer_in_windows): Declare.
8482
8483 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8484
8485 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8486 Qclone_number. Remove external declaration of Qdelete_window.
8487 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8488 code.
8489 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8490 Run Qbuffer_list_update_hook if allowed.
8491 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8492 buffer list implementation.
8493 (other_buffer_safely): New function.
8494 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8495 calls to replace_buffer_in_windows and
8496 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8497 if allowed.
8498 (record_buffer): Inhibit quitting and rewrite using quittable
8499 functions. Run Qbuffer_list_update_hook if allowed.
8500 (Frecord_buffer, Funrecord_buffer): New functions.
8501 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8502 Move switch-to-buffer to window.el.
8503 (bury-buffer): Move to window.el.
8504 (Vbuffer_list_update_hook): New variable.
8505
8506 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8507 section.
8508
8509 * window.h (resize_frame_windows): Move up in code.
8510 (Fwindow_frame): Remove EXFUN.
8511 (replace_buffer_in_all_windows): Remove prototype.
8512 (replace_buffer_in_windows_safely): Add prototype.
8513
8514 * window.c: Declare Qdelete_window static again. Move down
8515 declaration of select_count.
8516 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8517 (Fother_window): Move to window.el.
8518 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8519 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8520 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8521 window.el.
8522 (replace_buffer_in_windows): Implement by calling
8523 Qreplace_buffer_in_windows.
8524 (replace_buffer_in_all_windows): Remove with some functionality
8525 moved into replace_buffer_in_windows_safely.
8526 (replace_buffer_in_windows_safely): New function.
8527 (select_window_norecord, select_frame_norecord): Move in front
8528 of run_window_configuration_change_hook. Remove now obsolete
8529 declarations.
8530 (Fset_window_buffer): Rewrite doc-string.
8531 Call Qrecord_window_buffer.
8532 (keys_of_window): Move binding for other-window to window.el.
8533
8534 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8535
8536 * dispextern.h (struct image): Replace data member, whose int_val
8537 and ptr_val fields were not used by anything, with a single
8538 lisp_val object.
8539
8540 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8541 (gif_clear_image, gif_load, imagemagick_load_image)
8542 (gs_clear_image, gs_load): Callers changed.
8543
8544 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8545
8546 * buffer.h: Include <time.h>, for time_t.
8547 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8548
8549 Fix minor problems found by static checking.
8550
8551 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8552
8553 Make identifiers static if they are not used in other modules.
8554 * data.c (Qcompiled_function, Qframe, Qvector):
8555 * image.c (QimageMagick, Qsvg):
8556 * minibuf.c (Qmetadata):
8557 * window.c (resize_window_check, resize_root_window): Now static.
8558 * window.h (resize_window_check, resize_root_window): Remove decls.
8559
8560 * window.c (window_deletion_count, delete_deletable_window):
8561 Remove; unused.
8562 (window_body_lines): Now static.
8563 (Fdelete_other_windows_internal): Mark vars as initialized.
8564 Make sure 'resize_failed' is initialized.
8565 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8566 (resize_window_apply): Remove unused local.
8567 * window.h (delete_deletable_window): Remove decl.
8568
8569 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8570 (imagemagick_load_image): Fix pointer signedness problem by changing
8571 last arg from unsigned char * to char *. All uses changed.
8572 Also, fix a local for similar reasons.
8573 Remove unused locals. Remove locals to avoid shadowing.
8574 (fn_rsvg_handle_free): Remove; unused.
8575 (svg_load, svg_load_image): Fix pointer signedness problem.
8576 (imagemagick_load_image): Don't use garbage pointer image_wand.
8577
8578 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8579
8580 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8581
8582 * image.c (gif_load): Fix omitted cast error introduced by
8583 2011-06-06 change.
8584
8585 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8586
8587 * window.h (resize_proportionally, orig_total_lines)
8588 (orig_top_line): Remove from window structure.
8589 (set_window_height, set_window_width, change_window_heights)
8590 (Fdelete_window): Remove prototypes.
8591 (resize_frame_windows): Remove duplicate declaration.
8592
8593 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8594
8595 * window.h (resize_frame_windows, resize_window_check)
8596 (delete_deletable_window, resize_root_window)
8597 (resize_frame_windows): Declare prototypes.
8598
8599 * window.c (resize_window_apply): Make definition be "static" to
8600 match the prototype.
8601
8602 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8603
8604 * window.c: Remove declarations of Qwindow_size_fixed,
8605 window_min_size_1, window_min_size_2, window_min_size,
8606 size_window, window_fixed_size_p, enlarge_window, delete_window.
8607 Remove static from declaration of Qdelete_window, it's
8608 temporarily needed by Fbury_buffer.
8609 (replace_window): Don't assign orig_top_line and
8610 orig_total_lines.
8611 (Fdelete_window, delete_window): Remove. Window deletion is
8612 handled by window.el.
8613 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8614 Replace Fdelete_window calls with calls to Qdelete_window.
8615 (Fdelete_other_windows): Remove. Deleting other windows is
8616 handled by window.el.
8617 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8618 handled in window.el.
8619 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8620 Window minimum sizes are handled in window.el.
8621 (shrink_windows, size_window, set_window_height)
8622 (set_window_width, change_window_heights, window_height)
8623 (window_width, CURBEG, CURSIZE, enlarge_window)
8624 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8625 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8626 handled in window.el.
8627 (make_dummy_parent): Rename to make_parent_window and give it a
8628 second argument horflag.
8629 (make_window): Don't set resize_proportionally any more.
8630 (Fsplit_window): Remove. Windows are split in window.el.
8631 (save_restore_action, save_restore_orig_size)
8632 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8633 Resize mini windows in window.el.
8634 (grow_mini_window, shrink_mini_window): Implement by calling
8635 Qresize_root_window_vertically, resize_window_check and
8636 resize_window_apply.
8637 (saved_window, Fset_window_configuration, save_window_save):
8638 Do not handle orig_top_line, orig_total_lines, and
8639 resize_proportionally.
8640 (window_min_height, window_min_width): Move to window.el.
8641 (keys_of_window): Move bindings for delete-other-windows,
8642 split-window, delete-window and enlarge-window to window.el.
8643
8644 * buffer.c: Temporarily extern Qdelete_window.
8645 (Fbury_buffer): Temporarily call Qdelete_window instead of
8646 Fdelete_window (Fbury_buffer will move to window.el soon).
8647
8648 * frame.c (set_menu_bar_lines_1): Remove code handling
8649 orig_top_line and orig_total_lines.
8650
8651 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8652 set_window_height but set heights directly.
8653 (change_frame_size_1): Use resize_frame_windows.
8654
8655 * xdisp.c (init_xdisp): Don't use set_window_height but set
8656 heights directly.
8657
8658 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8659 Use resize_frame_windows instead of change_window_heights and run
8660 run_window_configuration_change_hook.
8661
8662 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8663 instead of change_window_heights and run
8664 run_window_configuration_change_hook.
8665
8666 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8667
8668 * window.c (replace_window): Rename second argument REPLACEMENT to
8669 NEW. New third argument SETFLAG. Rewrite.
8670 (delete_window, make_dummy_parent): Call replace_window with
8671 third argument 1.
8672 (window_list_1): Move down in code.
8673 (run_window_configuration_change_hook): Move set_buffer part
8674 before select_frame_norecord part in order to unwind correctly.
8675 Rename count1 to count.
8676 (recombine_windows, delete_deletable_window, resize_root_window)
8677 (Fdelete_other_windows_internal)
8678 (Frun_window_configuration_change_hook, make_parent_window)
8679 (resize_window_check, resize_window_apply, Fresize_window_apply)
8680 (resize_frame_windows, Fsplit_window_internal)
8681 (Fdelete_window_internal, Fresize_mini_window_internal):
8682 New functions.
8683 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8684
8685 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8686
8687 * window.h (window): Add some new members to window structure -
8688 normal_lines, normal_cols, new_total, new_normal, clone_number,
8689 splits, nest, prev_buffers, next_buffers.
8690 (WINDOW_TOTAL_SIZE): Move here from window.c.
8691 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8692
8693 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8694 Remove.
8695 (make_dummy_parent): Set new members of windows structure.
8696 (make_window): Move down in code. Handle new members of window
8697 structure.
8698 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8699 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8700 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8701 (Fset_window_prev_buffers, Fwindow_next_buffers)
8702 (Fset_window_next_buffers, Fset_window_clone_number):
8703 New functions.
8704 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8705 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8706 Doc-string fixes.
8707 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8708 Argument WINDOW can be now internal window too.
8709 (Fwindow_use_time): Move up in code.
8710 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8711 Rewrite doc-string.
8712 (Fset_window_configuration, saved_window)
8713 (Fcurrent_window_configuration, save_window_save): Handle new
8714 members of window structure.
8715 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8716 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8717 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8718 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8719 Qget_mru_window, Qresize_root_window,
8720 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8721 Qauto_buffer_name; staticpro them.
8722
8723 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8724
8725 * window.c (Fwindow_total_size, Fwindow_left_column)
8726 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8727 (Fwindow_list_1): New functions.
8728 (window_box_text_cols): Replace with window_body_cols.
8729 (Fwindow_width, Fscroll_left, Fscroll_right):
8730 Use window_body_cols instead of window_box_text_cols.
8731 (delete_window, Fset_window_configuration):
8732 Call delete_all_subwindows with window as argument.
8733 (delete_all_subwindows): Take a window as argument and not a
8734 structure. Rewrite.
8735 (window_loop): Remove handling of GET_LRU_WINDOW and
8736 GET_LARGEST_WINDOW.
8737 (Fget_lru_window, Fget_largest_window): Move to window.el.
8738
8739 * window.h: Extern window_body_cols instead of
8740 window_box_text_cols. delete_all_subwindows now takes a
8741 Lisp_Object as argument.
8742
8743 * indent.c (compute_motion, Fcompute_motion):
8744 Use window_body_cols instead of window_box_text_cols.
8745
8746 * frame.c (delete_frame): Call delete_all_subwindows with root
8747 window as argument.
8748
8749 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8750
8751 * fns.c (Fputhash): Document return value.
8752
8753 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8754
8755 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8756
8757 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8758
8759 Cons<->int and similar integer overflow fixes (Bug#8794).
8760
8761 Check for overflow when converting integer to cons and back.
8762 * charset.c (Fdefine_charset_internal, Fdecode_char):
8763 Use cons_to_unsigned to catch overflow.
8764 (Fencode_char): Use INTEGER_TO_CONS.
8765 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8766 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8767 * data.c (long_to_cons, cons_to_long): Remove.
8768 (cons_to_unsigned, cons_to_signed): New functions.
8769 These signal an error for invalid or out-of-range values.
8770 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8771 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8772 * font.c (Ffont_variation_glyphs):
8773 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8774 * lisp.h: Include <intprops.h>.
8775 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8776 (cons_to_signed, cons_to_unsigned): New decls.
8777 (long_to_cons, cons_to_long): Remove decls.
8778 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8779 (Fprimitive_undo): Use CONS_TO_INTEGER.
8780 * xfns.c (Fx_window_property): Likewise.
8781 * xselect.c: Include <limits.h>.
8782 (x_own_selection, selection_data_to_lisp_data):
8783 Use INTEGER_TO_CONS.
8784 (x_handle_selection_request, x_handle_selection_clear)
8785 (x_get_foreign_selection, Fx_disown_selection_internal)
8786 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8787 (lisp_data_to_selection_data): Use cons_to_unsigned.
8788 (x_fill_property_data): Use cons_to_signed.
8789 Report values out of range.
8790
8791 Check for buffer and string overflow more precisely.
8792 * buffer.h (BUF_BYTES_MAX): New macro.
8793 * lisp.h (STRING_BYTES_MAX): New macro.
8794 * alloc.c (Fmake_string):
8795 * character.c (string_escape_byte8):
8796 * coding.c (coding_alloc_by_realloc):
8797 * doprnt.c (doprnt):
8798 * editfns.c (Fformat):
8799 * eval.c (verror):
8800 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8801 since they may not be the same number.
8802 * editfns.c (Finsert_char):
8803 * fileio.c (Finsert_file_contents):
8804 Likewise for BUF_BYTES_MAX.
8805
8806 * image.c: Use ptrdiff_t, not int, for sizes.
8807 (slurp_file): Switch from int to ptrdiff_t.
8808 All uses changed.
8809 (slurp_file): Check that file size fits in both size_t (for
8810 malloc) and ptrdiff_t (for sanity and safety).
8811
8812 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8813 if b->modtime has its maximal value.
8814
8815 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8816
8817 Don't assume time_t can fit into int.
8818 * buffer.h (struct buffer.modtime): Now time_t, not int.
8819 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8820 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8821
8822 Minor fixes for signed vs unsigned integers.
8823 * character.h (MAYBE_UNIFY_CHAR):
8824 * charset.c (maybe_unify_char):
8825 * keyboard.c (read_char, reorder_modifiers):
8826 XINT -> XFASTINT, since the integer must be nonnegative.
8827 * ftfont.c (ftfont_spec_pattern):
8828 * keymap.c (access_keymap, silly_event_symbol_error):
8829 XUINT -> XFASTINT, since the integer must be nonnegative.
8830 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8831 since it makes no difference and we prefer signed.
8832 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8833 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8834 nonnegative.
8835
8836 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8837
8838 * window.h (Fwindow_frame): Declare.
8839
8840 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8841
8842 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8843 (SPARE_MEMORY): Always define.
8844 (LARGE_REQUEST): Remove.
8845 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8846
8847 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8848
8849 * lisp.h: Move EXFUNS for Fframe_root_window,
8850 Fframe_first_window and Fset_frame_selected_window to window.h.
8851
8852 * window.h: Move EXFUNS for Fframe_root_window,
8853 Fframe_first_window and Fset_frame_selected_window here from
8854 lisp.h.
8855
8856 * frame.c (Fwindow_frame, Fframe_first_window)
8857 (Fframe_root_window, Fframe_selected_window)
8858 (Fset_frame_selected_window): Move to window.c.
8859 (Factive_minibuffer_window): Move to minibuf.c.
8860 (Fother_visible_frames_p): New function.
8861
8862 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8863
8864 * window.c (decode_window, decode_any_window): Move up in code.
8865 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8866 (inhibit_frame_unsplittable): Remove unused variable.
8867 (Fwindow_buffer): Move up and rewrite doc-string.
8868 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8869 (Fwindow_prev): New functions.
8870 (Fwindow_frame): Move here from frame.c. Accept any window as
8871 argument.
8872 (Fframe_root_window, Fframe_first_window)
8873 (Fframe_selected_window): Move here from frame.c. Accept frame
8874 or arbitrary window as argument. Update doc-strings.
8875 (Fminibuffer_window): Move up in code.
8876 (Fwindow_minibuffer_p): Move up in code and simplify.
8877 (Fset_frame_selected_window): Move here from frame.c.
8878 Marginal rewrite.
8879 (Fselected_window, select_window, Fselect_window): Move up in
8880 code. Minor doc-string fixes.
8881
8882 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8883
8884 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8885 Do not assume that spare memory exists; that assumption is valid
8886 only if SYSTEM_MALLOC.
8887 (LARGE_REQUEST): New macro, so that the issue of large requests
8888 is separated from the issue of spare memory.
8889
8890 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8891
8892 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8893 format. (Bug#8806)
8894
8895 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8896
8897 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8898 before statements.
8899
8900 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8901
8902 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8903
8904 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8905
8906 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8907 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8908
8909 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8910
8911 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8912
8913 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8914
8915 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8916 (x_clipboard_manager_save): Add return value.
8917 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8918 New error handlers.
8919 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8920 Obey Vx_select_enable_clipboard_manager. Catch errors in
8921 x_clipboard_manager_save (Bug#8779).
8922 (Vx_select_enable_clipboard_manager): New variable.
8923 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8924
8925 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8926
8927 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8928
8929 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8930
8931 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8932 in the current matrix if keep_current_p is non-zero.
8933
8934 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8935
8936 * bidi.c (bidi_level_of_next_char): Fix last change.
8937
8938 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8939
8940 Support bidi reordering of text covered by display properties.
8941
8942 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8943 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8944 (bidi_cache_search, bidi_cache_iterator_state)
8945 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8946 (bidi_level_of_next_char, bidi_move_to_visually_next):
8947 Support character positions inside a run of characters covered by a
8948 display string.
8949 (bidi_paragraph_init, bidi_resolve_explicit_1)
8950 (bidi_level_of_next_char): Call bidi_fetch_char and
8951 bidi_fetch_char_advance instead of FETCH_CHAR and
8952 FETCH_CHAR_ADVANCE.
8953 (bidi_init_it): Initialize new members.
8954 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8955 definitions.
8956 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8957 instead of using explicit *_CHAR codes.
8958 (bidi_resolve_explicit, bidi_resolve_weak):
8959 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8960 bidirectional text is supported only in multibyte buffers.
8961 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8962 it to initialize the frame_window_p member of struct bidi_it.
8963 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8964 (bidi_resolve_explicit, bidi_resolve_weak)
8965 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8966 bidi_it->nchars is non-positive.
8967 (bidi_level_of_next_char): Don't try to lookup the cache for the
8968 next/previous character if nothing is cached there yet, or if we
8969 were just reseat()'ed to a new position.
8970
8971 * xdisp.c (set_cursor_from_row): Set start and stop points
8972 according to the row's direction when priming the loop that looks
8973 for the glyph on which to display cursor.
8974 (single_display_spec_intangible_p): Function deleted.
8975 (display_prop_intangible_p): Reimplement to call
8976 handle_display_spec instead of single_display_spec_intangible_p.
8977 Accept 3 additional arguments needed by handle_display_spec.
8978 This fixes incorrect cursor motion across display property with complex
8979 values: lists, `(when COND...)' forms, etc.
8980 (single_display_spec_string_p): Support property values that are
8981 lists with the argument STRING its top-level element.
8982 (display_prop_string_p): Fix the condition for processing a
8983 property that is a list to be consistent with handle_display_spec.
8984 (handle_display_spec): New function, refactored from the
8985 last portion of handle_display_prop.
8986 (compute_display_string_pos): Accept additional argument
8987 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8988 value of a `display' property is a "replacing spec".
8989 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8990 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8991 the display property, but just return a value indicating whether
8992 the display property will replace the characters it covers.
8993 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8994 frame_window_p members of struct bidi_it.
8995 (compute_display_string_pos, compute_display_string_end):
8996 New functions.
8997 (push_it): Accept second argument POSITION, where pop_it should
8998 jump to continue iteration.
8999 (reseat_1): Initialize bidi_it.disp_pos.
9000
9001 * keyboard.c (adjust_point_for_property): Adjust the call to
9002 display_prop_intangible_p to its new signature.
9003
9004 * dispextern.h (struct bidi_it): New member frame_window_p.
9005 (bidi_init_it): Update prototypes.
9006 (display_prop_intangible_p): Update prototype.
9007 (compute_display_string_pos, compute_display_string_end):
9008 Declare prototypes.
9009 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9010 EMACS_INT.
9011
9012 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9013
9014 Malloc failure behavior now depends on size of allocation.
9015 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9016 * lisp.h: Change signatures accordingly.
9017 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9018 All callers changed. (Bug#8762)
9019
9020 * gnutls.c: Use Emacs's memory allocators.
9021 Without this change, the gnutls library would invoke malloc etc.
9022 directly, which causes problems on non-SYNC_INPUT hosts, and which
9023 runs afoul of improving memory_full behavior. (Bug#8761)
9024 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9025 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9026 xfree instead of the default malloc, realloc, free.
9027 (Fgnutls_boot): No need to check for memory allocation failure,
9028 since xmalloc does that for us.
9029
9030 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9031 * category.c (hash_get_category_set):
9032 * ccl.c (ccl_driver):
9033 * charset.c (Fdefine_charset_internal):
9034 * charset.h (struct charset.hash_index):
9035 * composite.c (get_composition_id, gstring_lookup_cache)
9036 (composition_gstring_put_cache):
9037 * composite.h (struct composition.hash_index):
9038 * dispextern.h (struct image.hash):
9039 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9040 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9041 (hashfn_equal, hashfn_user_defined, make_hash_table)
9042 (maybe_resize_hash_table, hash_lookup, hash_put)
9043 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9044 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9045 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9046 * image.c (make_image, search_image_cache, lookup_image)
9047 (xpm_put_color_table_h):
9048 * lisp.h (struct Lisp_Hash_Table):
9049 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9050 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9051 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9052 * alloc.c (allocate_vectorlike):
9053 Check for overflow in vector size calculations.
9054 * ccl.c (ccl_driver):
9055 Check for overflow when converting EMACS_INT to int.
9056 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9057 need to be updated by these changes.
9058 * fns.c (make_hash_table, maybe_resize_hash_table):
9059 Check for integer overflow with large hash tables.
9060 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9061 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9062 (SXHASH_REDUCE): New macro.
9063 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9064 Use it instead of discarding useful hash info with large hash values.
9065 (sxhash_float): New function.
9066 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9067 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9068 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9069 Rewrite to use FIXNUM_BITS, as this simplifies things.
9070 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9071 Adjust signatures to match updated version of code.
9072 (consing_since_gc): Now EMACS_INT, since a single hash table can
9073 use more than INT_MAX bytes.
9074
9075 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9076
9077 Make it possible to build with GCC-4.6+ -O2 -flto.
9078
9079 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9080
9081 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9082
9083 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9084 Call minibuffer-inactive-mode.
9085
9086 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9087
9088 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9089 Update dependencies.
9090
9091 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9092
9093 * data.c (init_data): Remove code for UTS, this system is not
9094 supported anymore.
9095
9096 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9097
9098 Don't force ./temacs to start in terminal mode.
9099
9100 * frame.c (make_initial_frame): Initialize faces in all cases, not
9101 only when CANNOT_DUMP is defined.
9102 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9103
9104 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9105
9106 * dispnew.c (add_window_display_history): Use const for the string
9107 pointer. Remove declaration, not needed.
9108
9109 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9110
9111 Use 'inline', not 'INLINE'.
9112 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9113 * alloc.c, fontset.c (INLINE): Remove.
9114 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9115 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9116 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9117 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9118 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9119
9120 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9121
9122 Make it possible to run ./temacs.
9123
9124 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9125 syms_of_callproc does the same thing. Remove test for
9126 "initialized", do it in the caller.
9127 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9128
9129 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9130
9131 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9132 (read_minibuf): Use get_minibuffer.
9133 (syms_of_minibuf): Use DEFSYM.
9134 (Qmetadata): New var.
9135 * data.c (Qbuffer): Don't make it static.
9136 (syms_of_data): Use DEFSYM.
9137
9138 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9139
9140 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9141 (CCL_CODE_MIN): New macro.
9142
9143 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9144
9145 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9146
9147 * eval.c (Qdebug): Now static.
9148 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9149 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9150 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9151
9152 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9153
9154 * image.c: Various fixes to ImageMagick code comments.
9155 (Fimagemagick_types): Doc fix.
9156
9157 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9158
9159 Minor fixes prompted by GCC 4.6.0 warnings.
9160
9161 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9162
9163 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9164 (x_clipboard_manager_save_all): Move extern decl to ...
9165 * xterm.h: ... here, so that it can be checked for consistency.
9166
9167 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9168
9169 * xselect.c (x_clipboard_manager_save_frame)
9170 (x_clipboard_manager_save_all): New functions.
9171 (Fx_clipboard_manager_save): Lisp function deleted.
9172
9173 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9174 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9175
9176 * xterm.h: Update prototype.
9177
9178 2011-05-28 William Xu <william.xwl@gmail.com>
9179
9180 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9181 exiting (Bug#8239).
9182
9183 2011-05-28 Jim Meyering <meyering@redhat.com>
9184
9185 Avoid a sign-extension bug in crypto_hash_function.
9186 * fns.c (to_uchar): Define.
9187 (crypto_hash_function): Use it to convert some newly-signed
9188 variables to unsigned, to avoid sign-extension bugs. For example,
9189 without this change, (md5 "truc") would evaluate to
9190 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9191 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9192 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9193
9194 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9195
9196 Integer overflow fixes.
9197
9198 * dbusbind.c: Serial number integer overflow fixes.
9199 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9200 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9201 to hold a serial number that is too large for a fixnum.
9202 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9203 Check for serial numbers out of range. Decode any serial number
9204 that was so large that it became a float. (Bug#8722)
9205
9206 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9207 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9208 Use XFASTINT rather than XUINT when numbers are nonnegative.
9209 (xd_append_arg, Fdbus_method_return_internal):
9210 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9211 arguments, check that Lisp number is nonnegative, rather than
9212 silently wrapping negative numbers around. (Bug#8722)
9213 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9214 (Bug#8722)
9215
9216 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9217
9218 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9219
9220 ccl: Add integer overflow checks.
9221 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9222 (IN_INT_RANGE): New macros.
9223 (ccl_driver): Use them to check for integer overflow when
9224 decoding a CCL program. Many of the new checks are whether XINT (x)
9225 fits in int; it doesn't always, on 64-bit hosts. The new version
9226 doesn't catch all possible integer overflows, but it's an
9227 improvement. (Bug#8719)
9228
9229 * alloc.c (make_event_array): Use XINT, not XUINT.
9230 There's no need for unsigned here.
9231
9232 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9233 This follows up to the 2011-05-06 change that substituted uintptr_t
9234 for EMACS_INT. This case wasn't caught back then.
9235
9236 Rework Fformat to avoid integer overflow issues.
9237 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9238 now (part of C89). Include <verify.h>.
9239 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9240 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9241 (Fformat): Avoid the prepass trying to compute sizes; it was only
9242 approximate and thus did not catch overflow reliably. Instead, walk
9243 through the format just once, formatting and computing sizes as we go,
9244 checking for integer overflow at every step, and allocating a larger
9245 buffer as needed. Keep track separately whether the format is
9246 multibyte. Keep only the most-recently calculated precision, rather
9247 than them all. Record whether each argument has been converted to
9248 string. Use EMACS_INT, not int, for byte and char and arg counts.
9249 Support field widths and precisions larger than INT_MAX. Avoid
9250 sprintf's undefined behavior with conversion specifications such as %#d
9251 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9252 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9253 formatting out-of-range floating point numbers with int
9254 formats. (Bug#8668)
9255
9256 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9257
9258 * data.c: Avoid integer truncation in expressions involving floats.
9259 * data.c: Include <intprops.h>.
9260 (arith_driver): When there's an integer overflow in an expression
9261 involving floating point, convert the integers to floating point
9262 so that the resulting value does not suffer from catastrophic
9263 integer truncation. For example, on a 64-bit host (* 4
9264 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9265 Do not rely on undefined behavior after integer overflow.
9266
9267 merge count_size_as_multibyte, parse_str_to_multibyte
9268 * character.c, character.h (count_size_as_multibyte):
9269 Rename from parse_str_to_multibyte; all uses changed.
9270 Check for integer overflow.
9271 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9272 since it's now a duplicate of the other. This is more of
9273 a character than a buffer op, so better that it's in character.c.
9274 * fns.c, print.c: Adjust to above changes.
9275
9276 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9277
9278 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9279
9280 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9281
9282 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9283 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9284 (x_clipboard_manager_save): Now static.
9285 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9286
9287 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9288 (crypto_hash_function): Now static.
9289 Fix pointer signedness problems. Avoid unnecessary initializations.
9290
9291 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9292
9293 * termhooks.h (Vselection_alist): Make it terminal-local.
9294
9295 * terminal.c (create_terminal): Initialize it.
9296
9297 * xselect.c: Support for clipboard managers.
9298 (Vselection_alist): Move to termhooks.h as terminal-local var.
9299 (LOCAL_SELECTION): New macro.
9300 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9301 (symbol_to_x_atom): Remove gratuitous arg.
9302 (x_handle_selection_request, lisp_data_to_selection_data)
9303 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9304 (x_own_selection, x_get_local_selection, x_convert_selection):
9305 New arg, specifying work frame. Use terminal-local Vselection_alist.
9306 (some_frame_on_display): Delete unused function.
9307 (Fx_own_selection_internal, Fx_get_selection_internal)
9308 (Fx_disown_selection_internal, Fx_selection_owner_p)
9309 (Fx_selection_exists_p): New optional frame arg.
9310 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9311 (x_handle_selection_clear): Don't treat other terminals with the
9312 same keyboard specially. Use the terminal-local Vselection_alist.
9313 (x_clear_frame_selections): Use Frun_hook_with_args.
9314
9315 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9316
9317 * xterm.h: Add support for those atoms.
9318
9319 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9320
9321 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9322 (converted_selections, conversion_fail_tag): New global variables.
9323 (x_selection_request_lisp_error): Free the above.
9324 (x_get_local_selection): Remove unnecessary code.
9325 (x_reply_selection_request): Args changed; handle arbitrary array
9326 of converted selections stored in converted_selections.
9327 Separate the XChangeProperty and SelectionNotify steps.
9328 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9329 (x_convert_selection): New function.
9330 (x_handle_selection_event): Simplify.
9331 (x_get_foreign_selection): Don't ignore incoming requests while
9332 waiting for an answer; this will fail when we implement
9333 SAVE_TARGETS, and seems unnecessary anyway.
9334 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9335 (Vx_sent_selection_functions): Doc fix.
9336
9337 2011-05-26 Leo Liu <sdl.web@gmail.com>
9338
9339 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9340
9341 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9342
9343 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9344
9345 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9346 for fringe update if it has periodic bitmap.
9347 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9348 and fringe_bitmap_periodic_p.
9349
9350 * fringe.c (get_fringe_bitmap_data): New function.
9351 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9352 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9353 row. Mark glyph row for fringe update if periodicity changed.
9354
9355 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9356 for fringe update unless it has periodic bitmap.
9357
9358 2011-05-25 Kenichi Handa <handa@m17n.org>
9359
9360 * xdisp.c (get_next_display_element): Set correct it->face_id for
9361 a static composition.
9362
9363 2011-05-24 Leo Liu <sdl.web@gmail.com>
9364
9365 * deps.mk (fns.o):
9366 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9367
9368 * fns.c (crypto_hash_function, Fsha1): New function.
9369 (Fmd5): Use crypto_hash_function.
9370 (syms_of_fns): Add Ssha1.
9371
9372 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9373
9374 * gnutls.c: Remove unused macros.
9375 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9376 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9377 Remove macros that are defined and never used.
9378 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9379
9380 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9381
9382 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9383 (Fx_get_selection_internal): Minor cleanup.
9384 (Fx_own_selection_internal): Rename arguments for consistency with
9385 select.el.
9386
9387 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9388
9389 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9390
9391 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9392
9393 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9394
9395 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9396
9397 * dispnew.c (scrolling_window): Don't exclude the case that the
9398 last enabled row in the desired matrix touches the bottom boundary.
9399
9400 2011-05-21 Glenn Morris <rgm@gnu.org>
9401
9402 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9403 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9404 and add some more files.
9405
9406 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9407
9408 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9409 report_file_error introduced by the change from 2011-05-07.
9410
9411 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9412
9413 * systime.h (Time): Define only if emacs is defined.
9414 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9415 where the include path doesn't have X11/X.h by default. See
9416 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9417
9418 2011-05-20 Kenichi Handa <handa@m17n.org>
9419
9420 * composite.c (find_automatic_composition): Fix previous change.
9421
9422 2011-05-20 Glenn Morris <rgm@gnu.org>
9423
9424 * lisp.mk: New file, split from Makefile.in.
9425 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9426 (shortlisp): Remove.
9427 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9428
9429 2011-05-19 Glenn Morris <rgm@gnu.org>
9430
9431 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9432 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9433 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9434 (lisp): Set the order to that of loadup.el.
9435 (shortlisp): Make it a copy of $lisp.
9436 (SOME_MACHINE_LISP): Remove.
9437 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9438 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9439
9440 2011-05-18 Kenichi Handa <handa@m17n.org>
9441
9442 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9443 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9444 (find_automatic_composition): Mostly rewrite for efficiency.
9445
9446 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9447
9448 * makefile.w32-in: Update dependencies.
9449
9450 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9451
9452 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9453 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9454
9455 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9456
9457 Fix some integer overflow issues, such as string length overflow.
9458
9459 * insdel.c (count_size_as_multibyte): Check for string overflow.
9460
9461 * character.c (lisp_string_width): Check for string overflow.
9462 Use EMACS_INT, not int, for string indexes and lengths; in
9463 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9464 the resulting string length overflows an EMACS_INT; instead,
9465 report a string overflow if no precision given. When checking for
9466 precision exhaustion, use a check that cannot possibly have
9467 integer overflow. (Bug#8675)
9468 * character.h (lisp_string_width): Adjust to new signature.
9469
9470 * alloc.c (string_overflow): New function.
9471 (Fmake_string): Use it. This doesn't change behavior, but saves
9472 a few bytes and will simplify future changes.
9473 * character.c (string_escape_byte8): Likewise.
9474 * lisp.h (string_overflow): New decl.
9475
9476 Fixups, following up to the user-interface timestamp change.
9477 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9478 for UI timestamps, instead of unsigned long.
9479 * msdos.c (mouse_get_pos): Likewise.
9480 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9481 * w32gui.h (Time): Define by including "systime.h" rather than by
9482 declaring it ourselves. (Bug#8664)
9483
9484 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9485 * image.c (clear_image_cache): Likewise.
9486
9487 * term.c (term_mouse_position): Don't assume time_t wraparound.
9488
9489 Be more systematic about user-interface timestamps.
9490 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9491 and sometimes 'EMACS_UINT', to represent these timestamps.
9492 This change causes it to use 'Time' uniformly, as that's what X uses.
9493 This makes the code easier to follow, and makes it easier to catch
9494 integer overflow bugs such as Bug#8664.
9495 * frame.c (Fmouse_position, Fmouse_pixel_position):
9496 Use Time, not unsigned long, for user-interface timestamps.
9497 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9498 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9499 * keyboard.h (last_event_timestamp): Likewise.
9500 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9501 * menu.h (xmenu_show): Likewise.
9502 * term.c (term_mouse_position): Likewise.
9503 * termhooks.h (struct input_event.timestamp): Likewise.
9504 (struct terminal.mouse_position_hook): Likewise.
9505 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9506 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9507 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9508 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9509 what it was before.
9510 * menu.h, termhooks.h: Include "systime.h", for Time.
9511
9512 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9513 Don't assume that the difference between two unsigned long values
9514 can fit into an integer. At this point, we know button_down_time
9515 <= event->timestamp, so the difference must be nonnegative, so
9516 there's no need to cast the result if double-click-time is
9517 nonnegative, as it should be; check that it's nonnegative, just in
9518 case. This bug is triggered when events are more than 2**31 ms
9519 apart (about 25 days). (Bug#8664)
9520
9521 * xselect.c (last_event_timestamp): Remove duplicate decl.
9522 (x_own_selection): Remove needless cast to unsigned long.
9523
9524 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9525 that always fit in int. Use a sentinel instead of a counter, to
9526 avoid a temp and to allay GCC's concerns about possible int overflow.
9527 * frame.h (struct frame): Use int for menu_bar_items_used
9528 instead of EMACS_INT, since it always fits in int.
9529
9530 * menu.c (grow_menu_items): Check for int overflow.
9531
9532 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9533
9534 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9535 Before, the code was not consistent. These values cannot exceed
9536 2**31 - 1 so there's no need to make them unsigned.
9537 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9538 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9539 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9540 as modifiers.
9541 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9542
9543 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9544 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9545 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9546 presumably because the widths might not match.
9547
9548 * window.c (size_window): Avoid needless test at loop start.
9549
9550 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9551
9552 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9553
9554 2011-05-12 Drew Adams <drew.adams@oracle.com>
9555
9556 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9557
9558 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9559
9560 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9561 `width' to `bar_area_x' and `bar_area_width', respectively.
9562 (x_scroll_run): Take account of fringe background extension.
9563
9564 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9565 Rename local vars `left' and `width' to `bar_area_x' and
9566 `bar_area_width', respectively.
9567 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9568 background extension.
9569
9570 2011-05-10 Jim Meyering <meyering@redhat.com>
9571
9572 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9573
9574 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9575
9576 * image.c (Finit_image_library): Return t for built-in image types,
9577 like pbm and xbm. (Bug#8640)
9578
9579 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9580
9581 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9582
9583 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9584
9585 * w32console.c (Fset_screen_color): Doc fix.
9586 (Fget_screen_color): New function.
9587 (syms_of_ntterm): Defsubr it.
9588
9589 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9590 unlink the temporary file if Fcall_process didn't create it in the
9591 first place.
9592 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9593 child process will be redirected to a file specified with `:file'.
9594 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9595 cue to call_process_cleanup not to close that handle.
9596
9597 2011-05-07 Ben Key <bkey76@gmail.com>
9598
9599 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9600 one of two shell specific rules, either bootstrap-temacs-CMD or
9601 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9602 to the previous implementation of the bootstrap-temacs rule.
9603 The bootstrap-temacs-CMD rule is similar to the previous
9604 implementation of the bootstrap-temacs rule except that it
9605 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9606 variable.
9607
9608 These changes, along with some changes to nt/configure.bat,
9609 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9610 earlier fix to add support for --cflags and --ldflags options
9611 that include quotes so that it works whether make uses cmd or
9612 sh as the shell.
9613
9614 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9615
9616 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9617 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9618 is a constant.
9619 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9620 a string. Handle both cases.
9621 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9622 (Fdbus_register_method): Use Qinvalid_function.
9623
9624 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9625
9626 * makefile.w32-in: Update dependencies.
9627 (LISP_H): Add inttypes.h and stdin.h.
9628 (PROCESS_H): Add unistd.h.
9629
9630 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9631
9632 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9633 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9634
9635 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9636
9637 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9638
9639 * term.c (vfatal): Remove stray call to va_end.
9640 It's not needed and the C Standard doesn't allow it here anyway.
9641
9642 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9643 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9644
9645 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9646 bytes.
9647
9648 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9649
9650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9651
9652 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9653
9654 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9655
9656 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9657
9658 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9659 * charset.c (Fdefine_charset_internal): Don't initialize
9660 charset.code_space[15]. The value was garbage, on hosts with
9661 32-bit int (Bug#8600).
9662
9663 * lread.c (read_integer): Be more consistent with string-to-number.
9664 Use string_to_number to do the actual conversion; this avoids
9665 rounding errors and fixes some other screwups. Without this fix,
9666 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9667 (digit_to_number): Move earlier, for benefit of read_integer.
9668 Return -1 if the digit is out of range for the base, -2 if it is
9669 not a digit in any supported base. (Bug#8602)
9670
9671 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9672
9673 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9674 to match comment at start of function. This also removes a
9675 GCC warning about overflow in a 32+64-bit port.
9676
9677 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9678
9679 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9680 Reported by Stefan Monnier in
9681 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9682 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9683 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9684
9685 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9686 (EMACS_UINTPTR): Likewise, with uintptr_t.
9687
9688 * lisp.h: Prefer 64-bit EMACS_INT if available.
9689 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9690 on 32-bit hosts that have 64-bit int, so that they can access
9691 large files.
9692 However, temporarily disable this change unless the temporary
9693 symbol WIDE_EMACS_INT is defined.
9694
9695 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9696
9697 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9698 This removes an assumption that EMACS_INT and long are the same
9699 width as pointers. The assumption is true for Emacs porting targets
9700 now, but we want to make other targets possible.
9701 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9702 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9703 In the rest of the code, change types of integers that hold casted
9704 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9705 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9706 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9707 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9708 No need to cast type when ORing.
9709 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9710 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9711 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9712 assume EMACS_INT is the same width as char *.
9713 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9714 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9715 Remove no-longer-needed casts.
9716 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9717 (xg_tool_bar_help_callback, xg_make_tool_item):
9718 Use EMACS_INTPTR to hold an integer
9719 that will be cast to void *; this can avoid a GCC warning
9720 if EMACS_INT is not the same width as void *.
9721 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9722 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9723 (current_message_1, set_message_1):
9724 Use a local to convert to proper width without a cast.
9725 * xmenu.c (dialog_selection_callback): Likewise.
9726
9727 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9728 Also, don't assume VALBITS / RAND_BITS is less than 5,
9729 and don't rely on undefined behavior when shifting a 1 left into
9730 the sign bit.
9731 * lisp.h (get_random): Change signature to match.
9732
9733 * lread.c (hash_string): Use size_t, not int, for hash computation.
9734 Normally we prefer signed values; but hashing is special, because
9735 it's better to use unsigned division on hash table sizes so that
9736 the remainder is nonnegative. Also, size_t is the natural width
9737 for hashing into memory. The previous code used 'int', which doesn't
9738 retain enough info to hash well into very large tables.
9739 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9740
9741 * dbusbind.c: Don't possibly lose pointer info when converting.
9742 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9743 Use XPNTR rather than XHASH, so that the high-order bits of
9744 the pointer aren't lost when converting through void *.
9745
9746 * eval.c (Fautoload): Don't double-shift a pointer.
9747
9748 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9749
9750 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9751
9752 * gnutls.c (DEF_GNUTLS_FN):
9753 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9754
9755 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9756
9757 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9758 marker. (Bug#8610)
9759
9760 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9761
9762 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9763 New version that can reserve upto 2GB of heap space.
9764
9765 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9766
9767 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9768
9769 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9770
9771 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9772 `gnutls_certificate_set_x509_key_file'.
9773
9774 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9775
9776 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9777 Update dependencies.
9778
9779 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9780
9781 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9782 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9783 Remove unused parameter `fildes'.
9784 * process.c (read_process_output, send_process): Don't pass it.
9785
9786 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9787
9788 Fix previous change: the library cache is defined in w32.c.
9789 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9790 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9791
9792 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9793
9794 Implement dynamic loading of GnuTLS on Windows.
9795
9796 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9797 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9798 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9799 Declare.
9800
9801 * gnutls.c (Qgnutls_dll): Define.
9802 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9803 (gnutls_*): Declare function pointers.
9804 (init_gnutls_functions): New function to initialize function pointers.
9805 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9806 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9807 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9808 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9809 (emacs_gnutls_write, emacs_gnutls_read)
9810 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9811 (Fgnutls_available_p): New function.
9812 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9813 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9814 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9815
9816 * image.c: Include w32.h.
9817 (Vimage_type_cache): Delete.
9818 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9819 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9820 (w32_delayed_load): Move to w32.c.
9821
9822 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9823
9824 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9825 (w32_delayed_load): Move from image.c. When loading a library, record
9826 its filename in the :loaded-from property of the library id.
9827 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9828 Initialize and staticpro them.
9829 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9830
9831 * process.c: Include lisp.h before w32.h, not after.
9832 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9833 instead of gnutls_record_check_pending.
9834
9835 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9836
9837 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9838
9839 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9840 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9841 as passed in.
9842
9843 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9844
9845 * xterm.c (x_set_frame_alpha): Do not set property on anything
9846 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9847
9848 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9849
9850 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9851
9852 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9853
9854 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9855 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9856 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9857 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9858 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9859 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9860 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9861 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9862 (Qgnutls_bootprop_callbacks_verify): Make static.
9863
9864 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9865
9866 * callproc.c: Indentation fixup.
9867
9868 * sysdep.c (wait_for_termination_1): Make static.
9869 (wait_for_termination, interruptible_wait_for_termination):
9870 Move after wait_for_termination_1.
9871
9872 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9873
9874 * sysdep.c (interruptible_wait_for_termination): New function
9875 which is like wait_for_termination, but allows keyboard
9876 interruptions.
9877
9878 * callproc.c (Fcall_process): Add (:file "file") as an option for
9879 the STDOUT buffer.
9880 (Fcall_process_region): Ditto.
9881
9882 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9883
9884 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9885 rather than `XVECTOR (FOO)->size'.
9886
9887 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9888 inttypes.h, as a gnulib replacement is used if it not available in
9889 system headers.
9890
9891 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9892
9893 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9894 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9895 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9896
9897 * coding.c (coding_alloc_by_realloc): Error out if destination
9898 will grow beyond MOST_POSITIVE_FIXNUM.
9899 (decode_coding_emacs_mule): Abort if there isn't enough place in
9900 charbuf for the composition carryover bytes. Reserve an extra
9901 space for up to 2 characters produced in a loop.
9902 (decode_coding_iso_2022): Abort if there isn't enough place in
9903 charbuf for the composition carryover bytes.
9904
9905 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9906
9907 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9908 aborting when %lld or %lll format is passed.
9909 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9910 %llo or %llx format is passed. (Bug#8545)
9911
9912 * window.c (window_scroll_line_based): Use a marker instead of
9913 simple variables to record original value of point. (Bug#7952)
9914
9915 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9916 produced by %s or %c overflows available buffer space. (Bug#8545)
9917
9918 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9919
9920 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9921 (SIZE_MAX): Move defn after all includes, as they might #define it.
9922
9923 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9924
9925 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9926
9927 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9928
9929 * keyboard.c (Qdelayed_warnings_hook): Define.
9930 (command_loop_1): Run `delayed-warnings-hook'
9931 if Vdelayed_warnings_list is non-nil.
9932 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9933 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9934
9935 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9936
9937 * doprnt.c (doprnt): Don't return value smaller than the buffer
9938 size if the message was truncated. (Bug#8545).
9939
9940 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9941
9942 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9943 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9944
9945 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9946
9947 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9948
9949 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9950
9951 * makefile.w32-in: Update dependencies.
9952
9953 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9954
9955 Improve `doprnt' and its usage. (Bug#8545)
9956 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9957 `format_end'. Remove support for %l as a conversion specifier.
9958 Don't use xrealloc. Improve diagnostics when the %l size modifier
9959 is used. Update the commentary.
9960
9961 * eval.c (verror): Simplify calculation of size_t.
9962
9963 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9964 messages.
9965
9966 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9967
9968 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9969 change.
9970
9971 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9972
9973 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9974 This makes this file independent of the recent pseudovector change.
9975
9976 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9977
9978 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9979
9980 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9981 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9982 Remove unused local.
9983 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9984
9985 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9986 GCC 4.6.0 optimizes based on type-based alias analysis.
9987 For example, if b is of type struct buffer * and v of type struct
9988 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9989 != &v->size, and therefore "v->size = 1; b->size = 2; return
9990 v->size;" must therefore return 1. This assumption is incorrect
9991 for Emacs, since it type-puns struct Lisp_Vector * with many other
9992 types. To fix this problem, this patch adds a new type struct
9993 vectorlike_header that documents the constraints on layout of vectors
9994 and pseudovectors, and helps optimizing compilers not get fooled
9995 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9996 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9997 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9998 the size member.
9999 (XSETPVECTYPE): Rewrite in terms of new macro.
10000 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10001 This is a bit clearer, and further avoids the possibility of
10002 undesirable aliasing.
10003 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10004 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10005 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10006 since Lisp_Subr is a special case (no "next" field).
10007 (ASIZE): Now uses header.size rather than size.
10008 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10009 to avoid the hassle of writing XVECTOR (foo)->header.size.
10010 (struct vectorlike_header): New type.
10011 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10012 object, to help avoid aliasing.
10013 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10014 (SUBRP): Likewise, since Lisp_Subr is a special case.
10015 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10016 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10017 (struct Lisp_Hash_Table): Combine first two members into a single
10018 struct vectorlike_header member. All uses of "size" and "next" members
10019 changed to be "header.size" and "header.next".
10020 * buffer.h (struct buffer): Likewise.
10021 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10022 * frame.h (struct frame): Likewise.
10023 * process.h (struct Lisp_Process): Likewise.
10024 * termhooks.h (struct terminal): Likewise.
10025 * window.c (struct save_window_data, struct saved_window): Likewise.
10026 * window.h (struct window): Likewise.
10027 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10028 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10029 * buffer.c (init_buffer_once): Likewise.
10030 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10031 special case.
10032 * process.c (Fformat_network_address): Use local var for size,
10033 for brevity.
10034
10035 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10036
10037 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10038 * data.c (atof): Remove decl; no longer used or needed.
10039 (digit_to_number): Move to lread.c.
10040 (Fstring_to_number): Use new string_to_number function, to be
10041 consistent with how the Lisp reader treats infinities and NaNs.
10042 Do not assume that floating-point numbers represent EMACS_INT
10043 without losing information; this is not true on most 64-bit hosts.
10044 Avoid double-rounding errors, by insisting on integers when
10045 parsing non-base-10 numbers, as the documentation specifies.
10046 * lisp.h (string_to_number): New decl, replacing ...
10047 (isfloat_string): Remove.
10048 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10049 (read1): Do not accept +. and -. as integers; this
10050 appears to have been a coding error. Similarly, do not accept
10051 strings like +-1e0 as floating point numbers. Do not report
10052 overflow for integer overflows unless the base is not 10 which
10053 means we have no simple and reliable way to continue.
10054 Break out the floating-point parsing into a new
10055 function string_to_number, so that Fstring_to_number parses
10056 floating point numbers consistently with the Lisp reader.
10057 (digit_to_number): Move here from data.c. Make it static inline.
10058 (E_CHAR, EXP_INT): Remove, replacing with ...
10059 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10060 (string_to_number): New function, replacing isfloat_string.
10061 This function checks for valid syntax and produces the resulting
10062 Lisp float number too. Rework it so that string-to-number
10063 no longer mishandles examples like "1.0e+". Use strtoumax,
10064 so that overflow for non-base-10 numbers is reported only when
10065 there's no portable and simple way to convert to floating point.
10066
10067 * textprop.c (set_text_properties_1): Rewrite for clarity,
10068 and to avoid GCC warning about integer overflow.
10069
10070 * intervals.h (struct interval): Use EMACS_INT for members
10071 where EMACS_UINT might cause problems. See
10072 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10073 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10074 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10075 All uses changed.
10076 (offset_intervals): Tell GCC not to worry about length overflow
10077 when negating a negative length.
10078
10079 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10080 (overrun_check_free): Likewise.
10081
10082 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10083 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10084 word size.
10085
10086 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10087 (gnutls_make_error): Rename local to avoid shadowing.
10088 (gnutls_emacs_global_deinit): ifdef out; not used.
10089 (Fgnutls_boot): Use const for pointer to readonly storage.
10090 Comment out unused local. Fix pointer signedness problems.
10091
10092 * lread.c (openp): Don't stuff size_t into an 'int'.
10093 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10094 about possible signed overflow.
10095
10096 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10097 (GDK_KEY_g): Don't define if already defined.
10098 (xg_prepare_tooltip): Avoid pointer signedness problem.
10099 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10100
10101 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10102 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10103
10104 * xfns.c (Fx_window_property): Simplify a bit,
10105 to make a bit faster and to avoid GCC 4.6.0 warning.
10106 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10107
10108 * fns.c (internal_equal): Don't assume size_t fits in int.
10109
10110 * alloc.c (compact_small_strings): Tighten assertion a little.
10111
10112 Replace pEd with more-general pI, and fix some printf arg casts.
10113 * lisp.h (pI): New macro, generalizing old pEd macro to other
10114 conversion specifiers. For example, use "...%"pI"d..." rather
10115 than "...%"pEd"...".
10116 (pEd): Remove. All uses replaced with similar uses of pI.
10117 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10118 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10119 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10120 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10121 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10122 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10123 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10124 64-bit hosts.
10125 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10126 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10127 * print.c (safe_debug_print, print_object): Likewise.
10128 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10129 to int.
10130 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10131 avoiding the 0 flag, which is not portable.
10132 * process.c (Fmake_network_process): Use pI to avoid cast.
10133 * region-cache.c (pp_cache): Likewise.
10134 * xdisp.c (decode_mode_spec): Likewise.
10135 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10136 behavior on 64-bit hosts with printf arg.
10137 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10138 (x_stop_queuing_selection_requests): Likewise.
10139 (x_get_window_property): Don't truncate byte count to an 'int'
10140 when tracing.
10141
10142 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10143 here, since it parses constructs like leading '-' and spaces,
10144 which are not wanted; and it overflows with large numbers.
10145 Instead, simply match F[0-9]+, which is what is wanted anyway.
10146
10147 * alloc.c: Remove unportable assumptions about struct layout.
10148 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10149 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10150 (allocate_vectorlike, make_pure_vector): Use the new macros,
10151 plus offsetof, to remove unportable assumptions about struct layout.
10152 These assumptions hold on all porting targets that I know of, but
10153 they are not guaranteed, they're easy to remove, and removing them
10154 makes further changes easier.
10155
10156 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10157 This doesn't fix a bug but makes the code clearer.
10158 (string_overrun_cookie): Now const. Use initializers that
10159 don't formally overflow signed char, to avoid warnings.
10160 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10161 can cause Emacs to crash when string overrun checking is enabled.
10162 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10163 multiple of sizeof (EMACS_INT); it need not be, if
10164 alignof(EMACS_INT) < sizeof (EMACS_INT).
10165 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10166
10167 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10168
10169 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10170
10171 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10172
10173 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10174 supposed to be handshaking. (Bug#8556)
10175 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10176
10177 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10178
10179 * lisp.h (Qdebug): List symbol.
10180 * eval.c (Qdebug): Restore global linkage.
10181 * keyboard.c (debug-on-event): New variable.
10182 (handle_user_signal): Break into debugger when debug-on-event
10183 matches the current signal symbol.
10184
10185 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10186
10187 * alloc.c (check_sblock, check_string_bytes)
10188 (check_string_free_list): Convert to standard C.
10189
10190 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10191
10192 * w32.c (emacs_gnutls_push): Fix typo.
10193
10194 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10195
10196 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10197 "cast to pointer from integer of different size".
10198
10199 Improve doprnt and its use in verror. (Bug#8545)
10200 * doprnt.c (doprnt): Document the set of format control sequences
10201 supported by the function. Use SAFE_ALLOCA instead of always
10202 using `alloca'.
10203
10204 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10205 is one byte too soon. Don't use xrealloc; instead xfree and
10206 xmalloc anew.
10207
10208 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10209
10210 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10211 callbacks stage.
10212
10213 * gnutls.c: Renamed global_initialized to
10214 gnutls_global_initialized. Added internals for the
10215 :verify-hostname-error, :verify-error, and :verify-flags
10216 parameters of `gnutls-boot' and documented those parameters in the
10217 docstring. Start callback support.
10218 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10219 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10220 on error. Return error code.
10221 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10222 (emacs_gnutls_read): Likewise.
10223 (Fgnutls_boot): Return handshake error code.
10224 (emacs_gnutls_handle_error): New function.
10225 (wsaerror_to_errno): Likewise.
10226
10227 * w32.h (emacs_gnutls_pull): Add prototype.
10228 (emacs_gnutls_push): Likewise.
10229
10230 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10231 (emacs_gnutls_push): Likewise.
10232
10233 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10234
10235 * process.c (wait_reading_process_output): Check if GnuTLS
10236 buffered some data internally if no FDs are set for TLS
10237 connections.
10238
10239 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10240 (LIBS): Link to USER_LIBS.
10241 ($(BLD)/gnutls.$(0)): New target.
10242
10243 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10244
10245 * xdisp.c (handle_single_display_spec): Rename the
10246 display_replaced_before_p argument into display_replaced_p, to
10247 make it consistent with the commentary. Fix typos in the
10248 commentary.
10249
10250 * textprop.c (syms_of_textprop): Remove dead code.
10251 (copy_text_properties): Delete obsolete commentary about an
10252 interface that was deleted long ago. Fix typos in the description
10253 of arguments.
10254
10255 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10256 to changes in oldXMenu/XMenu.h from 2011-04-16.
10257 <menu_help_message, prev_menu_help_message>: Constify.
10258 (IT_menu_make_room): menu->help_text is now `const char **';
10259 adjust.
10260
10261 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10262 to changes in oldXMenu/XMenu.h from 2011-04-16.
10263 (struct XMenu): Declare `help_text' `const char **'.
10264
10265 * xfaces.c <Qunspecified>: Make extern again.
10266
10267 * syntax.c: Include sys/types.h before including regex.h, as
10268 required by POSIX.
10269
10270 * doc.c (get_doc_string): Improve the format passed to `error'.
10271
10272 * doprnt.c (doprnt): Improve commentary.
10273
10274 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10275
10276 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10277 them with etags.
10278
10279 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10280 changes in globals.h immediately force recompilation.
10281 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10282 $(CURDIR)/s/ms-w32.h.
10283 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10284
10285 * character.c (Fchar_direction): Function deleted.
10286 (syms_of_character): Don't defsubr it.
10287 <char-direction-table>: Deleted.
10288
10289 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10290
10291 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10292 * doprnt.c: Include limits.h.
10293 (SIZE_MAX): New macro.
10294 (doprnt): Return a size_t value. 2nd arg is now size_t.
10295 Many local variables are now size_t instead of int or unsigned.
10296 Improve overflow protection. Support `l' modifier for integer
10297 conversions. Support %l conversion. Don't assume an EMACS_INT
10298 argument for integer conversions and for %c.
10299
10300 * lisp.h (doprnt): Restore prototype.
10301
10302 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10303 $(SRC)/character.h.
10304
10305 * Makefile.in (base_obj): Add back doprnt.o.
10306
10307 * deps.mk (doprnt.o): Add back prerequisites.
10308 (callint.o): Depend on character.h.
10309
10310 * eval.c (internal_lisp_condition_case): Include the handler
10311 representation in the error message.
10312 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10313 when breaking from the loop.
10314
10315 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10316
10317 * callint.c (Fcall_interactively): When displaying error message
10318 about invalid control letter, pass the character's codepoint, not
10319 a pointer to its multibyte form. Improve display of the character
10320 in octal and display also its hex code.
10321
10322 * character.c (char_string): Use %x to display the (unsigned)
10323 codepoint of an invalid character, to avoid displaying a bogus
10324 negative value.
10325
10326 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10327 `error', not SYMBOL_NAME itself.
10328
10329 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10330 character arguments to `error'.
10331
10332 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10333 to `error' in error message about FINAL_CHAR argument. Make sure
10334 FINAL_CHAR is a character, and use %c when it is passed as
10335 argument to `error'.
10336
10337 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10338
10339 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10340
10341 * w32.c: Include <time.h>.
10342 (sys_localtime): New function.
10343
10344 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10345
10346 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10347
10348 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10349
10350 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10351
10352 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10353 zombies (Bug#8467).
10354
10355 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10356
10357 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10358 gl_state.e_property when gl_state.object is Qt.
10359
10360 * insdel.c (make_gap_larger): Remove limitation of buffer size
10361 to <= INT_MAX.
10362
10363 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10364
10365 * xdisp.c (lookup_glyphless_char_display)
10366 (produce_glyphless_glyph): Handle cons cell entry in
10367 glyphless-char-display.
10368 (Vglyphless_char_display): Document it.
10369
10370 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10371 glyphless-char-display.
10372
10373 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10374
10375 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10376
10377 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10378
10379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10380 definition for no-X builds.
10381
10382 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10383
10384 Static checks with GCC 4.6.0 and non-default toolkits.
10385
10386 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10387
10388 * process.c (keyboard_bit_set): Define only if SIGIO.
10389 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10390 (send_process): Repair possible setjmp clobbering.
10391
10392 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10393
10394 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10395
10396 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10397
10398 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10399 Define only if needed.
10400
10401 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10402 by pacifying GCC about it. Maybe it's time to retire it?
10403 * xfaces.c (USG, __TIMEVAL__): Likewise.
10404
10405 * dispextern.h (struct redisplay_interface): Rename param
10406 to avoid shadowing.
10407 * termhooks.h (struct terminal): Likewise.
10408 * xterm.c (xembed_send_message): Likewise.
10409
10410 * insdel.c (make_gap_smaller): Define only if
10411 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10412
10413 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10414 it.
10415
10416 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10417 so that we aren't warned about unused symbols.
10418
10419 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10420
10421 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10422
10423 * xfns.c (x_real_positions): Mark locals as initialized.
10424
10425 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10426
10427 * xterm.c: Fix problems found by static analysis with other toolkits.
10428 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10429 (x_dispatch_event): Declare static if USE_GTK, and
10430 define if USE_GTK || USE_X_TOOLKIT.
10431 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10432 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10433 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10434 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10435
10436 * xmenu.c (menu_help_callback): Pointer type fixes.
10437 Use const pointers when pointing at readonly data. Avoid pointer
10438 signedness clashes.
10439 (FALSE): Remove unused macro.
10440 (update_frame_menubar): Remove unused decl.
10441
10442 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10443
10444 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10445 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10446 (single_menu_item): Rename local to avoid shadowing.
10447
10448 * keyboard.c (make_lispy_event): Remove unused local var.
10449
10450 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10451 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10452
10453 * bitmaps: Change bitmaps from unsigned char back to the X11
10454 compatible char. Avoid the old compiler warnings about
10455 out-of-range initializers by using, for example, '\xab' rather
10456 than 0xab.
10457
10458 * xgselect.c (xgselect_initialize): Check vs interface
10459 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10460
10461 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10462
10463 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10464 to read-only memory.
10465
10466 * fns.c (vector): Remove; this old hack is no longer needed.
10467
10468 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10469 Remove unused var.
10470 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10471
10472 * xrdb.c (x_load_resources): Omit unused local.
10473
10474 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10475 (x_window): Rename locals to avoid shadowing.
10476 (USG): Use the kludged USG macro, to pacify gcc.
10477
10478 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10479 (x_term_init): Remove local to avoid shadowing.
10480
10481 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10482
10483 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10484 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10485
10486 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10487
10488 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10489
10490 Fix regex.c, syntax.c and friends for buffers > 2GB.
10491 * syntax.h (struct gl_state_s): Declare character position members
10492 EMACS_INT.
10493
10494 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10495
10496 * textprop.c (verify_interval_modification, interval_of):
10497 Declare arguments EMACS_INT.
10498
10499 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10500 EMACS_INT.
10501
10502 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10503
10504 * indent.c (Fvertical_motion): Local variable it_start is now
10505 EMACS_INT.
10506
10507 * regex.c (re_match, re_match_2, re_match_2_internal)
10508 (bcmp_translate, regcomp, regexec, print_double_string)
10509 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10510 (re_compile_pattern, re_exec): Declare arguments and local
10511 variables `size_t' and `ssize_t' and return values `regoff_t', as
10512 appropriate.
10513 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10514 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10515 <compile_stack_type>: `size' and `avail' are now `size_t'.
10516
10517 * regex.h <regoff_t>: Use ssize_t, not int.
10518 (re_search, re_search_2, re_match, re_match_2): Arguments that
10519 specify buffer/string position and length are now ssize_t and
10520 size_t. Return type is regoff_t.
10521
10522 2011-04-16 Ben Key <bkey76@gmail.com>
10523
10524 * nsfont.m: Fixed bugs in ns_get_family and
10525 ns_descriptor_to_entity that were caused by using free to
10526 deallocate memory blocks that were allocated by xmalloc (via
10527 xstrdup). This caused Emacs to crash when compiled with
10528 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10529 --enable-checking=xmallocoverrun). xfree is now used to
10530 deallocate these memory blocks.
10531
10532 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10533
10534 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10535
10536 emacs_write: Accept and return EMACS_INT for sizes.
10537 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10538 et seq.
10539 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10540 Accept and return EMACS_INT.
10541 (emacs_gnutls_write): Return the number of bytes written on
10542 partial writes.
10543 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10544 (emacs_read, emacs_write): Remove check for negative size, as the
10545 Emacs source code has been audited now.
10546 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10547 (emacs_read, emacs_write): Use it.
10548 * process.c (send_process): Adjust to the new signatures of
10549 emacs_write and emacs_gnutls_write. Do not attempt to store
10550 a byte offset into an 'int'; it might overflow.
10551 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10552
10553 * sound.c: Don't assume sizes fit in 'int'.
10554 (struct sound_device.period_size, alsa_period_size):
10555 Return EMACS_INT, not int.
10556 (struct sound_device.write, vox_write, alsa_write):
10557 Accept EMACS_INT, not int.
10558 (wav_play, au_play): Use EMACS_INT to store sizes and to
10559 record read return values.
10560
10561 2011-04-15 Ben Key <bkey76@gmail.com>
10562
10563 * keyboard.c (Qundefined): Don't declare static since it is used
10564 in nsfns.m.
10565 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10566 static since they are used in nsfont.m.
10567
10568 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10569
10570 * process.c (Qprocessp): Don't declare static.
10571 * lisp.h (Qprocessp): Declare again.
10572
10573 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10574
10575 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10576
10577 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10578
10579 Improve C-level modularity by making more things 'static'.
10580
10581 Don't publish debugger-only interfaces to other modules.
10582 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10583 (verify_bytepos, count_markers): Move decls to the only modules
10584 that need them.
10585 * region-cache.h (pp_cache): Likewise.
10586 * window.h (check_all_windows): Likewise.
10587 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10588
10589 * sysdep.c (croak): Now static, if
10590 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10591 * syssignal.h (croak): Declare only if not static.
10592
10593 * alloc.c (refill_memory_reserve): Now static if
10594 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10595 * lisp.h (refill_memory_reserve): Declare only if not static.
10596
10597 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10598 Define only if USE_LUCID.
10599
10600 * xrdb.c (x_customization_string, x_rm_string): Now static.
10601
10602 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10603 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10604
10605 * xdisp.c (draw_row_with_mouse_face): Now static.
10606 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10607
10608 * window.h (check_all_windows): Mark externally visible.
10609
10610 * window.c (window_deletion_count): Now static.
10611
10612 * undo.c: Make symbols static if they're not exported.
10613 (last_undo_buffer, last_boundary_position, pending_boundary):
10614 Now static.
10615
10616 * textprop.c (interval_insert_behind_hooks): Now static.
10617 (interval_insert_in_front_hooks): Likewise.
10618
10619 * term.c: Make symbols static if they're not exported.
10620 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10621 (max_frame_lines, tty_set_terminal_modes):
10622 (tty_reset_terminal_modes, tty_turn_off_highlight):
10623 (get_tty_terminal): Now static.
10624 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10625 * termhooks.h (term_mouse_moveto): Do not declare if
10626 HAVE_WINDOW_SYSTEM.
10627 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10628 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10629
10630 * sysdep.c: Make symbols static if they're not exported.
10631 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10632 Now static.
10633 (sigprocmask_set, full_mask): Remove; unused.
10634 (wait_debugging): Mark as visible.
10635 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10636 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10637
10638 * syntax.c (syntax_temp): Define only if !__GNUC__.
10639
10640 * sound.c (current_sound_device, current_sound): Now static.
10641
10642 * search.c (searchbufs, searchbuf_head): Now static.
10643
10644 * scroll.c (scroll_cost): Remove; unused.
10645 * dispextern.h (scroll_cost): Remove decl.
10646
10647 * region-cache.h (pp_cache): Mark as externally visible.
10648
10649 * process.c: Make symbols static if they're not exported.
10650 (process_tick, update_tick, create_process, chan_process):
10651 (Vprocess_alist, proc_buffered_char, datagram_access):
10652 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10653 (deactivate_process): Mark defn as static, as well as decl.
10654 * lisp.h (create_process): Remove decl.
10655 * process.h (chan_process, Vprocess_alist): Remove decls.
10656
10657 * print.c: Make symbols static if they're not exported.
10658 (print_depth, new_backquote_output, being_printed, print_buffer):
10659 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10660 (print_interval, print_number_index, initial_stderr_stream):
10661 Now static.
10662 * lisp.h (Fprinc): Remove decl.
10663 (debug_output_compilation_hack): Mark as externally visible.
10664
10665 * sysdep.c (croak): Move decl from here to syssignal.h.
10666 * syssignal.h (croak): Put it here, so the API can be checked when
10667 'croak' is called from dissociate_if_controlling_tty.
10668
10669 * minibuf.c: Make symbols static if they're not exported.
10670 (minibuf_save_list, choose_minibuf_frame): Now static.
10671 * lisp.h (choose_minibuf_frame): Remove decl.
10672
10673 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10674
10675 * lread.c: Make symbols static if they're not exported.
10676 (read_objects, initial_obarray, oblookup_last_bucket_number):
10677 Now static.
10678 (make_symbol): Remove; unused.
10679 * lisp.h (initial_obarray, make_symbol): Remove decls.
10680
10681 * keyboard.c: Make symbols static if they're not exported.
10682 (single_kboard, recent_keys_index, total_keys, recent_keys):
10683 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10684 (this_single_command_key_start, echoing, last_auto_save):
10685 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10686 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10687 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10688 (Vlispy_mouse_stem, double_click_count):
10689 Now static.
10690 (force_auto_save_soon): Define only if SIGDANGER.
10691 (ignore_mouse_drag_p): Now static if
10692 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10693 (print_help): Remove; unused.
10694 (stop_character, last_timer_event): Mark as externally visible.
10695 * keyboard.h (ignore_mouse_drag_p): Declare only if
10696 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10697 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10698 * lisp.h (echoing): Remove decl.
10699 (force_auto_save_soon): Declare only if SIGDANGER.
10700 * xdisp.c (redisplay_window): Simplify code, to make it more
10701 obvious that ignore_mouse_drag_p is not accessed if !defined
10702 USE_GTK && !defined HAVE_NS.
10703
10704 * intervals.c: Make symbols static if they're not exported.
10705 (merge_properties_sticky, merge_interval_right, delete_interval):
10706 Now static.
10707 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10708
10709 * insdel.c: Make symbols static if they're not exported.
10710 However, leave prepare_to_modify_buffer alone. It's never
10711 called from outside this function, but that appears to be a bug.
10712 (combine_after_change_list, combine_after_change_buffer):
10713 (adjust_after_replace, signal_before_change): Now static.
10714 (adjust_after_replace_noundo): Remove; unused.
10715 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10716 (signal_before_change): Remove decls.
10717
10718 * indent.c (val_compute_motion, val_vmotion): Now static.
10719
10720 * image.c: Make symbols static if they're not exported.
10721 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10722 if USE_GTK.
10723 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10724 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10725
10726 * fringe.c (standard_bitmaps): Now static.
10727 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10728
10729 * frame.c: Make symbols static if they're not exported.
10730 (x_report_frame_params, make_terminal_frame): Now static.
10731 (get_frame_param): Now static, unless HAVE_NS.
10732 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10733 (x_get_resource_string): Remove; not used.
10734 * frame.h (make_terminal_frame, x_report_frame_params):
10735 (x_get_resource_string); Remove decls.
10736 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10737 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10738
10739 * font.c, fontset.c: Make symbols static if they're not exported.
10740 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10741 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10742 * font.c (font_close_object): Now static.
10743 * font.h (font_close_object): Remove.
10744 * fontset.c (FONTSET_OBJLIST): Remove.
10745 (free_realized_fontset) #if-0 the body, which does nothing.
10746 (face_suitable_for_char_p): #if-0, as it's never called.
10747 * fontset.h (face_suitable_for_char_p): Remove decl.
10748 * xfaces.c (face_at_string_position):
10749 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10750 since 0 is always ASCII.
10751
10752 * fns.c (weak_hash_tables): Now static.
10753
10754 * fileio.c: Make symbols static if they're not exported.
10755 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10756 (Vwrite_region_annotation_buffers): Now static.
10757
10758 * eval.c: Make symbols static if they're not exported.
10759 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10760 * lisp.h (backtrace_list): Remove decl.
10761
10762 * emacs.c: Make symbols static if they're not exported.
10763 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10764 (fatal_error_code, fatal_error_signal_hook, standard_args):
10765 Now static.
10766 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10767 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10768 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10769 * lisp.h (fatal_error_signal_hook): Remove decl.
10770 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10771
10772 * editfns.c: Move a (normally-unused) function to its only use.
10773 * editfns.c, lisp.h (get_operating_system_release): Remove.
10774 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10775 worth the hassle of breaking this out.
10776
10777 * xterm.c: Make symbols static if they're not exported.
10778 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10779 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10780 (x_destroy_window, x_delete_display):
10781 Now static.
10782 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10783 (x_mouse_leave): Remove; unused.
10784 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10785 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10786 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10787 Remove decls.
10788 (x_mouse_leave): Declare only if WINDOWSNT.
10789 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10790 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10791 USE_X_TOOLKIT.
10792
10793 * ftxfont.c: Make symbols static if they're not exported.
10794 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10795 HAVE_FREETYPE.
10796 * font.h (ftxfont_driver): Likewise.
10797
10798 * xfns.c: Make symbols static if they're not exported.
10799 (x_last_font_name, x_display_info_for_name):
10800 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10801 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10802 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10803 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10804 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10805 (last_show_tip_args): Now static.
10806 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10807 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10808 (x_screen_planes): Remove; unused.
10809 * dispextern.h (x_screen_planes): Remove decl.
10810
10811 * dispnew.c: Make symbols static if they're not exported.
10812 * dispextern.h (redraw_garbaged_frames, scrolling):
10813 (increment_row_positions): Remove.
10814 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10815 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10816 Now static.
10817 (redraw_garbaged_frames): Remove; unused.
10818
10819 * xfaces.c: Make symbols static if they're not exported.
10820 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10821 Remove decls.
10822 * xterm.h (defined_color): Remove decls.
10823 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10824 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10825 (menu_face_changed_default, defined_color, free_realized_face):
10826 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10827 (ascii_face_of_lisp_face): Remove; unused.
10828
10829 * xdisp.c: Make symbols static if they're not exported.
10830 * dispextern.h (scratch_glyph_row, window_box_edges):
10831 (glyph_to_pixel_coords, set_cursor_from_row):
10832 (get_next_display_element, set_iterator_to_next):
10833 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10834 (show_mouse_face): Remove decls
10835 * frame.h (message_buf_print): Likewise.
10836 * lisp.h (pop_message, set_message, check_point_in_composition):
10837 Likewise.
10838 * xterm.h (set_vertical_scroll_bar): Likewise.
10839 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10840 (message_buf_print, scratch_glyph_row, displayed_buffer):
10841 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10842 (get_next_display_element, show_mouse_face, window_box_edges):
10843 (frame_to_window_pixel_xy, check_point_in_composition):
10844 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10845 (glyph_to_pixel_coords): Remove; unused.
10846
10847 * dired.c (file_name_completion): Now static.
10848
10849 * dbusbind.c (xd_in_read_queued_messages): Now static.
10850
10851 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10852 * data.c (circular_list_error): Remove.
10853
10854 * commands.h (last_point_position, last_point_position_buffer):
10855 (last_point_position_window): Remove decls.
10856 * keyboard.c: Make these variables static.
10857
10858 * coding.h (coding, code_convert_region, encode_coding_gap):
10859 Remove decls.
10860 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10861 (iso_code_class, detect_coding, code_convert_region): Now static.
10862 (encode_coding_gap): Remove; unused.
10863
10864 * chartab.c (chartab_chars, chartab_bits): Now static.
10865
10866 * charset.h (charset_iso_8859_1): Remove decl.
10867 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10868 Now static.
10869
10870 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10871 * ccl.c (Vccl_program_table): Now static.
10872 (check_ccl_update): Remove; unused.
10873
10874 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10875 * category.h: ... from here.
10876 * category.c (check_category_table, set_category_set): Now static.
10877
10878 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10879 * lisp.h: Remove these decls.
10880
10881 * buffer.c (buffer_count): Remove unused var.
10882
10883 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10884 so that it's not optimized away.
10885 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10886 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10887 exported only to the debugger.
10888
10889 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10890 * atimer.h (run_all_atimers): Remove; not exported.
10891
10892 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10893 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10894 was inaccessible from Lisp.
10895 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10896 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10897
10898 alloc.c: Import and export fewer symbols, and remove unused items.
10899 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10900 is defined.
10901 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10902 it's not optimized away by whole-program optimization.
10903 (message_enable_multibyte, free_misc): Remove.
10904 (catchlist, handlerlist, mark_backtrace):
10905 Declare only if BYTE_MARK_STACK.
10906 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10907 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10908 (message_enable_multibyte): Remove decl.
10909 (free_misc, interval_free_list, float_block, float_block_index):
10910 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10911 (cons_free_list, last_marked_index):
10912 Now static.
10913 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10914 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10915 (mark_backtrace): Define only if BYTE_MARK_STACK.
10916 * xdisp.c (message_enable_multibyte): Now static.
10917
10918 Declare Lisp_Object Q* variables to be 'static' if not exported.
10919 This makes it easier for human readers (and static analyzers)
10920 to see whether these variables are used from other modules.
10921 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10922 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10923 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10924 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10925 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10926 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10927 * xmenu.c, xselect.c:
10928 Declare Q* vars static if they are not used in other modules.
10929 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10930 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10931 Remove decls of unexported vars.
10932 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10933
10934 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10935
10936 Make Emacs functions such as Fatom 'static' by default.
10937 This makes it easier for human readers (and static analyzers)
10938 to see whether these functions can be called from other modules.
10939 DEFUN now defines a static function. To make the function external
10940 so that it can be used in other C modules, use the new macro DEFUE.
10941 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10942 (Finit_image_library):
10943 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10944 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10945 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10946 Remove decls, since these functions are now static.
10947 (Funintern, Fget_internal_run_time): New decls, since these functions
10948 were already external.
10949
10950 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10951 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10952 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10953 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10954 * keyboard.c, keymap.c, lread.c:
10955 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10956 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10957 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10958 Mark functions with DEFUE instead of DEFUN,
10959 if they are used in other modules.
10960 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10961 decls for now-static functions.
10962 * buffer.h (Fdelete_overlay): Remove decl.
10963 * callproc.c (Fgetenv_internal): Mark as internal.
10964 * composite.c (Fremove_list_of_text_properties): Remove decl.
10965 (Fcomposition_get_gstring): New forward static decl.
10966 * composite.h (Fcomposite_get_gstring): Remove decl.
10967 * dired.c (Ffile_attributes): New forward static decl.
10968 * doc.c (Fdocumntation_property): New forward static decl.
10969 * eval.c (Ffetch_bytecode): New forward static decl.
10970 (Funintern): Remove extern decl; now in .h file where it belongs.
10971 * fileio.c (Fmake_symbolic_link): New forward static decl.
10972 * image.c (Finit_image_library): New forward static decl.
10973 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10974 * intervals.h (Fprevious_property_change):
10975 (Fremove_list_of_text_properties): Remove decls.
10976 * keyboard.c (Fthis_command_keys): Remove decl.
10977 (Fcommand_execute): New forward static decl.
10978 * keymap.c (Flookup_key): New forward static decl.
10979 (Fcopy_keymap): Now static.
10980 * keymap.h (Flookup_key): Remove decl.
10981 * process.c (Fget_process): New forward static decl.
10982 (Fprocess_datagram_address): Mark as internal.
10983 * syntax.c (Fsyntax_table_p): New forward static decl.
10984 (skip_chars): Remove duplicate decl.
10985 * textprop.c (Fprevious_property_change): New forward static decl.
10986 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10987 Now internal.
10988 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10989 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10990
10991 * editfns.c (Fformat): Remove unreachable code.
10992
10993 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10994
10995 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10996 change. (Bug#8496)
10997
10998 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10999
11000 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11001 when at ZV. (Bug#8487)
11002
11003 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11004
11005 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11006 (Bug#8437)
11007 * keyboard.c (parse_tool_bar_item): Likewise.
11008 * sound.c (sound_cleanup, alsa_close): Likewise.
11009 * termcap.c (tgetent): Likewise.
11010 * xfns.c (x_default_font_parameter): Likewise.
11011 * xsettings.c (read_and_apply_settings): Likewise.
11012
11013 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11014 (overrun_check_free): Protoize.
11015
11016 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11017
11018 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11019 since callers should never pass a negative size.
11020 Change the signature to match that of plain 'read' and 'write'; see
11021 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11022 * lisp.h: Update prototypes of emacs_write and emacs_read.
11023
11024 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11025
11026 * xdisp.c (redisplay_window): Don't try to determine the character
11027 position of the scroll margin if the window start point w->startp
11028 is outside the buffer's accessible region. (Bug#8468)
11029
11030 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11031
11032 Fix write-region and its subroutines for buffers > 2GB.
11033 * fileio.c (a_write, e_write): Modify declaration of arguments and
11034 local variables to support buffers larger than 2GB.
11035 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11036
11037 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11038 argument, local variables, and return value.
11039
11040 * lisp.h: Update prototypes of emacs_write and emacs_read.
11041
11042 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11043
11044 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11045
11046 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11047
11048 Fix more problems found by GCC 4.6.0's static checks.
11049
11050 * xdisp.c (vmessage): Use a better test for character truncation.
11051
11052 * charset.c (load_charset_map): <, not <=, for optimization,
11053 and to avoid potential problems with integer overflow.
11054 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11055 * casetab.c (set_identity, shuffle): Likewise.
11056 * editfns.c (Fformat): Likewise.
11057 * syntax.c (skip_chars): Likewise.
11058
11059 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11060 This also lets GCC 4.6.0 generate slightly better loop code.
11061
11062 * callint.c (Fcall_interactively): <, not <=, for optimization.
11063 (Fcall_interactively): Count the number of arguments produced,
11064 not the number of arguments given. This is simpler and lets GCC
11065 4.6.0 generate slightly better code.
11066
11067 * ftfont.c: Distingish more carefully between FcChar8 and char.
11068 The previous code passed unsigned char * to a functions like
11069 strlen and xstrcasecmp that expect char *, which does not
11070 conform to the C standard.
11071 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11072 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11073 char * when the C standard requires it.
11074
11075 * keyboard.c (read_char): Remove unused var.
11076
11077 * eval.c: Port to Windows vsnprintf (Bug#8435).
11078 Include <limits.h>.
11079 (SIZE_MAX): Define if the headers do not.
11080 (verror): Do not give up if vsnprintf returns a negative count.
11081 Instead, grow the buffer. This ports to Windows vsnprintf, which
11082 does not conform to C99. Problem reported by Eli Zaretskii.
11083 Also, simplify the allocation scheme, by avoiding the need for
11084 calling realloc, and removing the ALLOCATED variable.
11085
11086 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11087
11088 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11089 But keep the doprint source code for now, as we might revamp it
11090 and use it again (Bug#8435).
11091 * lisp.h (doprnt): Remove.
11092 * Makefile.in (base_obj): Remove doprnt.o.
11093 * deps.mk (doprnt.o): Remove.
11094
11095 error: Print 32- and 64-bit integers portably (Bug#8435).
11096 Without this change, on typical 64-bit hosts error ("...%d...", N)
11097 was used to print both 32- and 64-bit integers N, which relied on
11098 undefined behavior.
11099 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11100 * lisp.h (error, verror): Mark as printf-like functions.
11101 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11102 Report overflow in size calculations when allocating printf buffer.
11103 Do not truncate output string at its first null byte.
11104 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11105 Truncate the output at a character boundary, since vsnprintf does not
11106 do that.
11107 * charset.c (check_iso_charset_parameter): Convert internal
11108 character to string before calling 'error', since %c now has the
11109 printf meaning.
11110 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11111 overflow when computing char to be passed to 'error'. Do not
11112 pass Lisp_Object to 'error'; pass the integer instead.
11113 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11114 formatted with plain %d.
11115
11116 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11117
11118 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11119
11120 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11121
11122 * xterm.c (x_catch_errors): Remove duplicate declaration.
11123
11124 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11125
11126 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11127
11128 2011-04-10 Jim Meyering <meyering@redhat.com>
11129
11130 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11131 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11132 return ssize_t not "int", and use size_t as the buffer length.
11133 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11134 * gnutls.h: Update declarations.
11135 * process.c (read_process_output): Use ssize_t, to match.
11136 (send_process): Likewise.
11137
11138 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11139
11140 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11141
11142 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11143
11144 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11145 Use unsigned char, to match FcChar8 type definition.
11146
11147 * xterm.c (handle_one_xevent):
11148 * xmenu.c (create_and_show_popup_menu):
11149 * xselect.c (x_decline_selection_request)
11150 (x_reply_selection_request): Avoid type-punned deref of X events.
11151
11152 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11153
11154 Fix some uses of `int' instead of EMACS_INT.
11155 * search.c (string_match_1, fast_string_match)
11156 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11157 (scan_buffer, find_next_newline_no_quit)
11158 (find_before_next_newline, search_command, Freplace_match)
11159 (Fmatch_data): Make some `int' variables be EMACS_INT.
11160
11161 * xdisp.c (display_count_lines): 3rd argument and return value now
11162 EMACS_INT. All callers changed.
11163 (pint2hrstr): Last argument is now EMACS_INT.
11164
11165 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11166 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11167 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11168 (decode_coding_utf_16, decode_coding_emacs_mule)
11169 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11170 (decode_coding_ccl, decode_coding_charset)
11171 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11172 (decode_coding_iso_2022, decode_coding_emacs_mule)
11173 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11174 <char_offset, last_offset>: Declare EMACS_INT.
11175 (encode_coding_utf_8, encode_coding_utf_16)
11176 (encode_coding_emacs_mule, encode_invocation_designation)
11177 (encode_designation_at_bol, encode_coding_iso_2022)
11178 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11179 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11180 Declare EMACS_INT.
11181 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11182 (encode_invocation_designation): Last argument P_NCHARS is now
11183 EMACS_INT.
11184 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11185 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11186
11187 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11188 All users changed.
11189
11190 * ccl.c (Fccl_execute_on_string): Declare some variables
11191 EMACS_INT.
11192
11193 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11194
11195 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11196
11197 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11198
11199 * process.c (Fformat_network_address): Doc fix.
11200
11201 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11202
11203 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11204
11205 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11206
11207 * keyboard.c (read_char): Call Lisp function help-form-show,
11208 instead of using internal_with_output_to_temp_buffer.
11209 (Qhelp_form_show): New var.
11210 (syms_of_keyboard): Use DEFSYM macro.
11211
11212 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11213
11214 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11215
11216 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11217
11218 * process.c (Flist_processes): Remove to Lisp.
11219 (list_processes_1): Delete.
11220
11221 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11222
11223 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11224
11225 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11226
11227 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11228
11229 Fix more problems found by GCC 4.6.0's static checks.
11230
11231 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11232
11233 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11234
11235 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11236
11237 * xdisp.c (vmessage): Mark as a printf-like function.
11238
11239 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11240
11241 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11242
11243 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11244 printf-like functions.
11245 (tiff_load): Add casts to remove these marks before passing them
11246 to system-supplied API.
11247
11248 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11249
11250 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11251 This avoids several warnings with gcc -Wstrict-overflow.
11252 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11253 directly, rather than having caller test rule sign. This avoids
11254 some unnecessary tests.
11255 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11256 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11257 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11258
11259 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11260 (xfont_open): Avoid unnecessary tests.
11261
11262 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11263
11264 * composite.h, composite.c (composition_gstring_put_cache):
11265 Use EMACS_INT, not int, for length.
11266
11267 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11268 breaking out part of COMPOSITION_DECODE_RULE.
11269 (COMPOSITION_DECODE_RULE): Use it.
11270 * composite.c (get_composition_id): Remove unused local vars,
11271 by using the new macro.
11272
11273 * textprop.c (set_text_properties_1): Change while to do-while,
11274 since the condition is always true at first.
11275
11276 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11277 (interval_deletion_adjustment): Return unsigned value.
11278 All uses changed.
11279
11280 * process.c (list_processes_1, create_pty, read_process_output):
11281 (exec_sentinel): Remove vars that were set but not used.
11282 (create_pty): Remove unnecessary "volatile"s.
11283 (Fnetwork_interface_info): Avoid possibility of int overflow.
11284 (read_process_output): Do adaptive read buffering even if carryover.
11285 (read_process_output): Simplify nbytes computation if buffered.
11286
11287 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11288
11289 * syntax.c (scan_words): Remove var that was set but not used.
11290 (update_syntax_table): Use unsigned instead of int.
11291
11292 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11293 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11294 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11295
11296 * print.c (print_error_message): Avoid int overflow.
11297
11298 * font.c (font_list_entities): Redo for clarity,
11299 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11300
11301 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11302 (font_score): Avoid potential overflow in diff calculation.
11303
11304 * fns.c (substring_both): Remove var that is set but not used.
11305 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11306
11307 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11308
11309 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11310 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11311 can always succeed if overflow has undefined behavior.
11312
11313 * search.c (boyer_moore, wordify): Remove vars set but not used.
11314 (wordify): Omit three unnecessary tests.
11315
11316 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11317 All callers changed. This avoids the need for an unused var.
11318
11319 * casefiddle.c (casify_region): Remove var that is set but not used.
11320
11321 * dired.c (file_name_completion): Remove var that is set but not used.
11322
11323 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11324
11325 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11326 (Finsert_file_contents): Remove unnecessary code checking fd.
11327
11328 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11329 Check for integer overflow on size calculations.
11330
11331 * buffer.c (Fprevious_overlay_change): Remove var that is set
11332 but not used.
11333
11334 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11335 Remove vars that are set but not used.
11336 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11337 (timer_check_2): Mark vars as initialized.
11338
11339 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11340
11341 * image.c (lookup_image): Remove var that is set but not used.
11342 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11343
11344 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11345 that are set but not used.
11346
11347 * xfns.c (make_invisible_cursor): Don't return garbage
11348 if XCreateBitmapFromData fails (Bug#8410).
11349
11350 * xselect.c (x_get_local_selection, x_handle_property_notify):
11351 Remove vars that are set but not used.
11352
11353 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11354 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11355
11356 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11357 Remove var that is set but not used.
11358 (scroll_bar_windows_size): Now size_t, not int.
11359 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11360 Check for overflow.
11361
11362 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11363 (map_tty_color) [!defined MSDOS]: Likewise.
11364
11365 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11366
11367 * coding.c: Remove vars that are set but not used.
11368 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11369 All callers changed.
11370 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11371 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11372 (decode_coding_charset): Remove vars that are set but not used.
11373
11374 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11375 that is set but not used.
11376
11377 * print.c (print_object): Remove var that is set but not used.
11378
11379 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11380 The gnulib version avoids calling malloc in the usual case,
11381 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11382 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11383 * filelock.c (current_lock_owner): Likewise.
11384 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11385 * sysdep.c: Include allocator.h, careadlinkat.h.
11386 (emacs_no_realloc_allocator): New static constant.
11387 (emacs_readlink): New function.
11388 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11389 ../lib/careadlinkat.h.
11390
11391 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11392
11393 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11394 first non-nil return value).
11395
11396 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11397
11398 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11399 if not defined (Bug#8403).
11400
11401 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11402
11403 * xdisp.c (display_count_lines): Remove parameter `start',
11404 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11405 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11406 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11407 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11408 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11409 and thereabouts. All callers changed.
11410 (get_per_char_metric): Remove parameter `f', unused since
11411 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11412
11413 2011-04-02 Jim Meyering <meyering@redhat.com>
11414
11415 do not dereference NULL upon failed strdup
11416 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11417 (ns_get_family): Likewise.
11418
11419 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11420
11421 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11422
11423 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11424
11425 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11426 later (Bug#8403).
11427
11428 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11429
11430 Add lexical binding.
11431
11432 * window.c (Ftemp_output_buffer_show): New fun.
11433 (Fsave_window_excursion):
11434 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11435
11436 * lread.c (lisp_file_lexically_bound_p): New function.
11437 (Fload): Bind Qlexical_binding.
11438 (readevalloop): Remove `evalfun' arg.
11439 Bind Qinternal_interpreter_environment.
11440 (Feval_buffer): Bind Qlexical_binding.
11441 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11442 Mark as dynamic.
11443 (syms_of_lread): Declare `lexical-binding'.
11444
11445 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11446
11447 * keyboard.c (eval_dyn): New fun.
11448 (menu_item_eval_property): Use it.
11449
11450 * image.c (parse_image_spec): Use Ffunctionp.
11451
11452 * fns.c (concat, mapcar1): Accept byte-code-functions.
11453
11454 * eval.c (Fsetq): Handle lexical vars.
11455 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11456 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11457 (FletX, Flet): Obey lexical binding.
11458 (Fcommandp): Handle closures.
11459 (Feval): New `lexical' arg.
11460 (eval_sub): New function extracted from Feval. Use it almost
11461 everywhere where Feval was used. Look up vars in lexical env.
11462 Handle closures.
11463 (Ffunctionp): Move from subr.el.
11464 (Ffuncall): Handle closures.
11465 (apply_lambda): Remove `eval_flags'.
11466 (funcall_lambda): Handle closures and new byte-code-functions.
11467 (Fspecial_variable_p): New function.
11468 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11469 but without exporting it to Lisp.
11470
11471 * doc.c (Fdocumentation, store_function_docstring):
11472 * data.c (Finteractive_form): Handle closures.
11473
11474 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11475 interactive spec.
11476
11477 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11478 New byte-codes.
11479 (exec_byte_code): New function extracted from Fbyte_code to handle new
11480 calling convention for byte-code-functions. Add new byte-codes.
11481
11482 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11483
11484 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11485
11486 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11487
11488 * xdisp.c (redisplay_internal): Fix prototype.
11489
11490 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11491
11492 * xdisp.c (SCROLL_LIMIT): New macro.
11493 (try_scrolling): Use it when setting scroll_limit.
11494 Limit scrolling to 100 screen lines.
11495 (redisplay_window): Even when falling back on "recentering",
11496 position point in the window according to scroll-conservatively,
11497 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11498
11499 (try_scrolling): When point is above the window, allow searching
11500 as far as scroll_max, or one screenful, to compute vertical
11501 distance from PT to the scroll margin position. This prevents
11502 try_scrolling from unnecessarily failing when
11503 scroll-conservatively is set to a value slightly larger than the
11504 window height. Clean up the case of PT below the margin at bottom
11505 of window: scroll_max can no longer be INT_MAX. When aggressive
11506 scrolling is in use, don't let point enter the opposite scroll
11507 margin as result of the scroll.
11508 (syms_of_xdisp) <scroll-conservatively>: Document the
11509 threshold of 100 lines for never-recentering scrolling.
11510
11511 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11512
11513 * dispextern.h (move_it_by_lines):
11514 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11515 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11516 (message_log_check_duplicate): Remove parameters `prev_bol' and
11517 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11518 (redisplay_internal): Remove parameter `preserve_echo_area',
11519 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11520
11521 * indent.c (Fvertical_motion):
11522 * window.c (window_scroll_pixel_based, Frecenter):
11523 Don't pass `need_y_p' to `move_it_by_lines'.
11524
11525 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11526
11527 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11528 steal a few bits to be more compact.
11529 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11530 Remove unneeded casts.
11531
11532 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11533
11534 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11535
11536 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11537 binding" message (bug#7967).
11538
11539 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11540
11541 Fix more problems found by GCC 4.6.0's static checks.
11542
11543 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11544 Remove unused local var.
11545
11546 * editfns.c (Fmessage_box): Remove unused local var.
11547
11548 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11549 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11550 Omit unused local vars.
11551 * window.c (shrink_windows): Omit unused local var.
11552 * menu.c (digest_single_submenu): Omit unused local var.
11553 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11554 Omit unused local var.
11555
11556 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11557 Don't assume string length fits in int.
11558 (keyremap_step, read_key_sequence): Use size_t for sizes.
11559 (read_key_sequence): Don't check last_real_key_start redundantly.
11560
11561 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11562 instead of alloca (Bug#8344).
11563
11564 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11565 (Fbacktrace_frame): Don't assume nframes fits in int.
11566
11567 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11568
11569 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11570 concerns.
11571
11572 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11573
11574 * cm.c (calccost): Turn while-do into do-while, for clarity.
11575
11576 * keyboard.c (syms_of_keyboard): Use the same style as later
11577 in this function when indexing through an array. This also
11578 works around GCC bug 48267.
11579
11580 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11581
11582 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11583
11584 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11585 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11586
11587 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11588 This avoids undefined behavior on integer overflow, and is a bit
11589 more convenient anyway since it is compared to a size_t variable.
11590
11591 Variadic C functions now count arguments with size_t, not int.
11592 This avoids an unnecessary limitation on 64-bit machines, which
11593 caused (substring ...) to crash on large vectors (Bug#8344).
11594 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11595 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11596 All variadic functions and their callers changed accordingly.
11597 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11598 * data.c (arith_driver, float_arith_driver): Likewise.
11599 * editfns.c (general_insert_function): Likewise.
11600 * eval.c (struct backtrace.nargs, interactive_p)
11601 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11602 (funcall_lambda, mark_backtrace): Likewise.
11603 * fns.c (concat): Likewise.
11604 * frame.c (x_set_frame_parameters): Likewise.
11605 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11606 0 if not found, not -1. All callers changed.
11607
11608 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11609 (stack_copy_size): Now size_t, not int.
11610 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11611
11612 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11613
11614 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11615 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11616 All callers changed.
11617
11618 * lisp.h (multibyte_char_to_unibyte):
11619 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11620 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11621 * character.h (CHAR_TO_BYTE8):
11622 * cmds.c (internal_self_insert):
11623 * editfns.c (general_insert_function):
11624 * keymap.c (push_key_description):
11625 * search.c (Freplace_match):
11626 * xdisp.c (message_dolog, set_message_1): All callers changed.
11627
11628 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11629
11630 * keyboard.c (safe_run_hook_funcall): New function.
11631 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11632 don't set the hook to nil, but remove the offending function instead.
11633 (Qcommand_hook_internal): Remove, unused.
11634 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11635 Vcommand_hook_internal.
11636
11637 * eval.c (enum run_hooks_condition): Remove.
11638 (funcall_nil, funcall_not): New functions.
11639 (run_hook_with_args): Call each function through a `funcall' argument.
11640 Remove `cond' argument, now redundant.
11641 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11642 (Frun_hook_with_args_until_failure): Adjust accordingly.
11643 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11644
11645 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11646
11647 * dispextern.h (string_buffer_position): Remove declaration.
11648
11649 * print.c (strout): Remove parameter `multibyte', unused since
11650 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11651
11652 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11653 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11654 All callers changed.
11655
11656 * w32.c (_wsa_errlist): Use braces for struct initializers.
11657
11658 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11659 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11660 All callers changed.
11661 (string_buffer_position): Likewise. Also, make static (it's never
11662 used outside xdisp.c).
11663 (cursor_row_p): Remove parameter `w', unused since
11664 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11665 (decode_mode_spec): Remove parameter `precision', introduced during
11666 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11667 All callers changed.
11668
11669 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11670
11671 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11672
11673 2011-03-27 Anders Lindgren <andlind@gmail.com>
11674
11675 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11676 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11677 (ns_update_auto_hide_menu_bar): New functions.
11678 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11679 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11680 ns_constrain_all_frames.
11681 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11682 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11683
11684 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11685
11686 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11687
11688 2011-03-27 Glenn Morris <rgm@gnu.org>
11689
11690 * syssignal.h: Replace RETSIGTYPE with void.
11691 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11692 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11693 Replace SIGTYPE with void everywhere.
11694 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11695 * s/template.h (SIGTYPE): Remove commented out definition.
11696
11697 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11698
11699 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11700 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11701
11702 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11703
11704 * w32.c (read_unc_volume): Use parameter `henum', instead of
11705 global variable `wget_enum_handle'.
11706
11707 * keymap.c (describe_vector): Remove parameters `indices' and
11708 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11709 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11710
11711 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11712
11713 * keyboard.c (timer_check): Remove parameter `do_it_now',
11714 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11715 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11716 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11717
11718 * keyboard.c (read_char):
11719 * w32menu.c (w32_menu_display_help):
11720 * xmenu.c (show_help_event, menu_help_callback):
11721 Adjust calls to `show_help_echo'.
11722
11723 * gtkutil.c (xg_maybe_add_timer):
11724 * keyboard.c (readable_events):
11725 * process.c (wait_reading_process_output):
11726 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11727
11728 * insdel.c (adjust_markers_gap_motion):
11729 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11730 (gap_left, gap_right): Don't call it.
11731
11732 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11733
11734 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11735 incurred during fontification.
11736
11737 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11738
11739 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11740 (DEFVAR_PER_BUFFER): Don't pass it.
11741
11742 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11743 (scrolling_window): Don't pass it.
11744
11745 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11746
11747 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11748
11749 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11750 and `suffix'.
11751 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11752 of variables specific to SELinux and computation of `encoded_absname'.
11753
11754 * image.c (XPutPixel): Remove unused variable `height'.
11755
11756 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11757
11758 * unexw32.c (get_section_info): Remove unused variable `section'.
11759
11760 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11761 (system_process_attributes): Remove unused variable `sess'.
11762 (sys_read): Remove unused variable `err'.
11763
11764 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11765 (w32_wnd_proc): Remove unused variable `isdead'.
11766 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11767 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11768 (x_create_tip_frame): Remove unused variable `tem'.
11769
11770 * w32inevt.c (w32_console_read_socket):
11771 Remove unused variable `no_events'.
11772
11773 * w32term.c (x_draw_composite_glyph_string_foreground):
11774 Remove unused variable `width'.
11775
11776 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11777
11778 * w32term.c (x_set_glyph_string_clipping):
11779 Don't pass uninitialized region to CombineRgn.
11780
11781 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11782
11783 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11784 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11785 (Fx_close_connection): Remove unused variable `i'.
11786
11787 * w32font.c (w32font_draw): Return number of glyphs.
11788 (w32font_open_internal): Remove unused variable `i'.
11789 (w32font_driver): Add missing initializer.
11790
11791 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11792 (fill_in_menu): Remove unused variable `items_added'.
11793
11794 * w32term.c (last_mouse_press_frame): Remove static global variable.
11795 (w32_clip_to_row): Remove unused variable `f'.
11796 (x_delete_terminal): Remove unused variable `i'.
11797
11798 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11799 (NOTHING): Remove unused static global variable.
11800 (uniscribe_check_otf): Remove unused variable `table'.
11801 (uniscribe_font_driver): Add missing initializers.
11802
11803 2011-03-23 Julien Danjou <julien@danjou.info>
11804
11805 * term.c (Fsuspend_tty, Fresume_tty):
11806 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11807 * window.c (temp_output_buffer_show):
11808 * insdel.c (signal_before_change):
11809 * frame.c (Fhandle_switch_frame):
11810 * fileio.c (Fdo_auto_save):
11811 * emacs.c (Fkill_emacs):
11812 * editfns.c (save_excursion_restore):
11813 * cmds.c (internal_self_insert):
11814 * callint.c (Fcall_interactively):
11815 * buffer.c (Fkill_all_local_variables):
11816 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11817 Use Frun_hooks.
11818 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11819 unconditionally since it does the check itself.
11820
11821 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11822
11823 Fix more problems found by GCC 4.5.2's static checks.
11824
11825 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11826 the first time through the loop, since we know p0 < p1 then.
11827 This also avoids a gcc -Wstrict-overflow warning.
11828
11829 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11830 leading to a memory leak, possible in functions like
11831 load_charset_map_from_file that can allocate an unbounded number
11832 of objects (Bug#8318).
11833
11834 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11835 that could (at least in theory) be that large.
11836
11837 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11838 This is less likely to overflow, and avoids undefined behavior if
11839 overflow does occur. All callers changed. Use strtoul to scan
11840 for the unsigned long integer.
11841 (pint2hrstr): Simplify and tune code slightly.
11842 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11843
11844 * scroll.c (do_scrolling): Work around GCC bug 48228.
11845 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11846
11847 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11848 This also avoids a warning with gcc -Wstrict-overflow.
11849 (validate_x_resource_name): Simplify count usage.
11850 This also avoids a warning with gcc -Wstrict-overflow.
11851
11852 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11853 fail (Bug#8306).
11854
11855 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11856
11857 * process.c (Fmake_network_process): Use socklen_t, not int,
11858 where POSIX says socklen_t is required in portable programs.
11859 This fixes a porting bug on hosts like 64-bit HP-UX, where
11860 socklen_t is wider than int (Bug#8277).
11861 (Fmake_network_process, server_accept_connection):
11862 (wait_reading_process_output, read_process_output):
11863 Likewise.
11864
11865 * process.c: Rename or move locals to avoid shadowing.
11866 (list_processes_1, Fmake_network_process):
11867 (read_process_output_error_handler, exec_sentinel_error_handler):
11868 Rename or move locals.
11869 (Fmake_network_process): Define label "retry_connect" only if needed.
11870 (Fnetwork_interface_info): Fix pointer signedness.
11871 (process_send_signal): Add cast to avoid pointer signedness problem.
11872 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11873 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11874
11875 Make tparam.h and terminfo.c consistent.
11876 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11877 Include tparam.h instead, since it declares them.
11878 * cm.h (PC): Remove extern decl; tparam.h now does this.
11879 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11880 * terminfo.c: Include tparam.h, to check interfaces.
11881 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11882 (tparam): Adjust signature to match interface in tparam.h;
11883 this removes some undefined behavior. Check that outstring and len
11884 are zero, which they always are with Emacs.
11885 * tparam.h (PC, BC, UP): New extern decls.
11886
11887 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11888 (xftfont_open): Rename locals to avoid shadowing.
11889
11890 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11891 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11892 (OTF_TAG_SYM): Omit macro if not needed.
11893 (ftfont_list): Remove unused local.
11894 (get_adstyle_property, ftfont_pattern_entity):
11895 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11896 Rename locals to avoid shadowing.
11897
11898 * xfont.c (xfont_list_family): Mark var as initialized.
11899
11900 * xml.c (make_dom): Now static.
11901
11902 * composite.c (composition_compute_stop_pos): Rename local to
11903 avoid shadowing.
11904 (composition_reseat_it): Remove unused locals.
11905 (find_automatic_composition, composition_adjust_point): Likewise.
11906 (composition_update_it): Mark var as initialized.
11907 (find_automatic_composition): Mark vars as initialized,
11908 with a FIXME (Bug#8290).
11909
11910 character.h: Rename locals to avoid shadowing.
11911 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11912 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11913 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11914 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11915 to avoid shadowing.
11916
11917 * textprop.c (property_change_between_p): Remove; unused.
11918
11919 * intervals.c (interval_start_pos): Now static.
11920
11921 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11922
11923 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11924 Rename locals to avoid shadowing.
11925
11926 * sound.c (wav_play, au_play, Fplay_sound_internal):
11927 Fix pointer signedness.
11928 (alsa_choose_format): Remove unused local var.
11929 (wav_play): Initialize a variable to 0, to prevent undefined
11930 behavior (Bug#8278).
11931
11932 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11933
11934 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11935
11936 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11937 clobbering (Bug#8298).
11938 * sysdep.c (sys_subshell): Likewise.
11939 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11940
11941 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11942 This should get cleaned up, so that child_setup has the
11943 same signature on all platforms.
11944
11945 * callproc.c (call_process_cleanup): Now static.
11946 (relocate_fd): Rename locals to avoid shadowing.
11947
11948 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11949
11950 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11951 not to be necessary, and produces flickering.
11952
11953 2011-03-20 Glenn Morris <rgm@gnu.org>
11954
11955 * config.in: Remove file.
11956
11957 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11958
11959 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11960 are now in src/globals.h.
11961 (syms_of_minibuf): Remove spurious & from previous change.
11962
11963 2011-03-20 Leo Liu <sdl.web@gmail.com>
11964
11965 * minibuf.c (completing-read-function): New variable.
11966 (completing-read-default): Rename from completing-read.
11967 (completing-read): Call completing-read-function.
11968
11969 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11970
11971 * xfaces.c (Fx_load_color_file):
11972 Read color file from absolute filename (bug#8250).
11973
11974 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11975
11976 * makefile.w32-in: Update dependencies.
11977
11978 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11979
11980 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11981
11982 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11983
11984 Fix more problems found by GCC 4.5.2's static checks.
11985
11986 * process.c (make_serial_process_unwind, send_process_trap):
11987 (sigchld_handler): Now static.
11988
11989 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11990 That way, the code declares only the vars that it needs.
11991 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11992 * s/cygwin.h (PTY_ITERATION): Likewise.
11993 * s/darwin.h (PTY_ITERATION): Likewise.
11994 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11995
11996 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11997 * process.c (allocate_pty): Don't declare stb unless it's needed.
11998
11999 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12000 (CONSTANTLIM): Remove; unused.
12001 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12002 Define only if needed.
12003
12004 * unexelf.c (unexec): Name an expression,
12005 to avoid gcc -Wbad-function-cast warning.
12006 Use a different way to cause a compilation error if anyone uses
12007 n rather than nn, a way that does not involve shadowing.
12008 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12009
12010 * deps.mk (unexalpha.o): Remove; unused.
12011
12012 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12013 * unexec.h: New file.
12014 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12015 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12016 Depend on unexec.h.
12017 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12018 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12019 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12020 Change as necessary to match prototype in unexec.h.
12021
12022 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12023 shadowing.
12024 (back_comment, skip_chars): Mark vars as initialized.
12025
12026 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12027 Rename locals to avoid shadowing.
12028
12029 * lread.c (read1): Rewrite so as not to use empty "else".
12030 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12031
12032 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12033
12034 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12035 warning when compiling print.c.
12036
12037 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12038 instead of using an uninitialized var.
12039 (font_sort_entities): Mark var as initialized.
12040
12041 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12042
12043 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12044 pointers to constants.
12045 (font_parse_fcname): Remove unused vars.
12046 (font_delete_unmatched): Now static.
12047 (font_get_spec): Remove; unused.
12048 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12049 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12050 Rename or move locals to avoid shadowing.
12051
12052 * fns.c (require_nesting_list, require_unwind): Now static.
12053 (Ffillarray): Rename locals to avoid shadowing.
12054
12055 * floatfns.c (domain_error2): Define only if needed.
12056 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12057
12058 * alloc.c (mark_backtrace): Move decl from here ...
12059 * lisp.h: ... to here, so that it can be checked.
12060
12061 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12062 (Fdefvar): Rewrite so as not to use empty "else".
12063 (lisp_indirect_variable): Name an expression,
12064 to avoid gcc -Wbad-function-cast warning.
12065 (Fdefvar): Rename locals to avoid shadowing.
12066
12067 * callint.c (quotify_arg, quotify_args): Now static.
12068 (Fcall_interactively): Rename locals to avoid shadowing.
12069 Use const pointer when appropriate.
12070
12071 * lisp.h (get_system_name, get_operating_system_release):
12072 Move decls here, to check interfaces.
12073 * process.c (get_operating_system_release): Move decl to lisp.h.
12074 * xrdb.c (get_system_name): Likewise.
12075 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12076 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12077 some of which prompt warnings from gcc -Wbad-function-cast.
12078 (Fformat_time_string, Fencode_time, Finsert_char):
12079 (Ftranslate_region_internal, Fformat):
12080 Rename or remove local vars to avoid shadowing.
12081 (Ftranslate_region_internal): Mark var as initialized.
12082
12083 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12084 avoid shadowing.
12085
12086 * lisp.h (eassert): Check that the argument compiles, even if
12087 ENABLE_CHECKING is not defined.
12088
12089 * data.c (Findirect_variable): Name an expression, to avoid
12090 gcc -Wbad-function-cast warning.
12091 (default_value, arithcompare, arith_driver, arith_error): Now static.
12092 (store_symval_forwarding): Rename local to avoid shadowing.
12093 (Fmake_variable_buffer_local, Fmake_local_variable):
12094 Mark variables as initialized.
12095 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12096
12097 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12098 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12099 Rename locals to avoid shadowing.
12100 (mark_stack): Move local variables into the #ifdef region where
12101 they're used.
12102 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12103 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12104 needed otherwise.
12105 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12106 (GC_STRING_CHARS): Remove; not used.
12107 (Fmemory_limit): Cast sbrk's returned value to char *.
12108
12109 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12110 avoids undefined behavior in theory.
12111
12112 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12113
12114 Use functions, not macros, for up- and down-casing (Bug#8254).
12115 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12116 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12117 to use the following functions instead of these macros.
12118 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12119 EMACS_INT, since callers assume the returned value fits in int.
12120 (upcase1): Likewise, for UPCASE_TABLE.
12121 (uppercasep, lowercasep, upcase): New static inline functions.
12122 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12123 the race-condition problem in the old DOWNCASE.
12124
12125 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12126 Rename locals to avoid shadowing.
12127 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12128 (regex_compile, re_search_2, re_match_2_internal):
12129 Remove unused local vars.
12130 (FREE_VAR): Rewrite so as not to use empty "else",
12131 which gcc can warn about.
12132 (regex_compile, re_match_2_internal): Mark locals as initialized.
12133 (RETALLOC_IF): Define only if needed.
12134 (WORDCHAR_P): Likewise. This one is never needed, but is used
12135 only in a comment talking about a compiler bug, so put inside
12136 the #if 0 of that comment.
12137 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12138 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12139 Remove; unused.
12140
12141 * search.c (boyer_moore): Rename locals to avoid shadowing.
12142 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12143 (PREV_CHAR_BOUNDARY): Likewise.
12144
12145 * search.c (simple_search): Remove unused var.
12146
12147 * dired.c (compile_pattern): Move decl from here ...
12148 * lisp.h: ... to here, so that it can be checked.
12149 (struct re_registers): New forward decl.
12150
12151 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12152
12153 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12154 All uses changed.
12155 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12156 Rename locals to avoid shadowing.
12157 (Fvertical_motion): Mark locals as initialized.
12158
12159 * casefiddle.c (casify_object, casify_region): Now static.
12160 (casify_region): Mark local as initialized.
12161
12162 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12163
12164 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12165 New macros, so that the caller can use some names other than
12166 gcpro1, gcpro2, etc.
12167 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12168 of the new macros.
12169 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12170 argument, for consistency with GCPRO2_VAR, etc: it is now the
12171 prefix of the variable, not the variable itself. All uses
12172 changed.
12173 * dired.c (directory_files_internal, file_name_completion):
12174 Rename locals to avoid shadowing.
12175
12176 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12177 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12178 dired.c's scmp function, had undefined behavior.
12179 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12180 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12181 * buffer.h: ... to here, because these macros use current_buffer,
12182 and the new implementation with inline functions needs to have
12183 current_buffer in scope now, rather than later when the macros
12184 are used.
12185 (downcase, upcase1): New static inline functions.
12186 (DOWNCASE, UPCASE1): Reimplement using these functions.
12187 This avoids undefined behavior in expressions like
12188 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12189 from race conditions in accessing the global variables
12190 case_temp1 and case_temp2.
12191 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12192 * lisp.h (case_temp1, case_temp2): Remove their decls.
12193 * character.h (ASCII_CHAR_P): Move from here ...
12194 * lisp.h: ... to here, so that the inline functions mentioned
12195 above can use them.
12196
12197 * dired.c (directory_files_internal_unwind): Now static.
12198
12199 * fileio.c (file_name_as_directory, directory_file_name):
12200 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12201 Now static.
12202 (file_name_as_directory): Use const pointers when appropriate.
12203 (Fexpand_file_name): Likewise. In particular, newdir might
12204 point at constant storage, so make it a const pointer.
12205 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12206 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12207 signedness issues.
12208 (Fset_file_times, Finsert_file_contents, auto_save_error):
12209 Rename locals to avoid shadowing.
12210
12211 * minibuf.c (choose_minibuf_frame_1): Now static.
12212 (Ftry_completion, Fall_completions): Rename or remove locals
12213 to avoid shadowing.
12214
12215 * marker.c (bytepos_to_charpos): Remove; unused.
12216
12217 * lisp.h (verify_bytepos, count_markers): New decls,
12218 so that gcc does not warn that these functions aren't declared.
12219
12220 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12221 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12222 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12223 (copy_text): Remove unused local var.
12224
12225 * filelock.c (within_one_second): Now static.
12226 (lock_file_1): Rename local to avoid shadowing.
12227
12228 * buffer.c (fix_overlays_before): Mark locals as initialized.
12229 (fix_start_end_in_overlays): Likewise. This function should be
12230 simplified by using pointers-to-pointers, but that's a different
12231 matter.
12232 (switch_to_buffer_1): Now static.
12233 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12234 (report_overlay_modification): Rename locals to avoid shadowing.
12235
12236 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12237 Fix pointer signedness issue.
12238 (sys_subshell): Mark local as volatile if checking for lint,
12239 to suppress a gcc -Wclobbered warning that does not seem to be right.
12240 (MAXPATHLEN): Define only if needed.
12241
12242 * process.c (serial_open, serial_configure): Move decls from here ...
12243 * systty.h: ... to here, so that they can be checked.
12244
12245 * fns.c (get_random, seed_random): Move extern decls from here ...
12246 * lisp.h: ... to here, so that they can be checked.
12247
12248 * sysdep.c (reset_io): Now static.
12249 (wait_for_termination_signal): Remove; unused.
12250
12251 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12252 (copy_keymap_item, append_key, push_text_char_description):
12253 Now static.
12254 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12255 (DENSE_TABLE_SIZE): Remove; unused.
12256 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12257 (describe_map_tree):
12258 Rename locals to avoid shadowing.
12259
12260 * keyboard.c: Declare functions static if they are not used elsewhere.
12261 (echo_char, echo_dash, cmd_error, top_level_2):
12262 (poll_for_input, handle_async_input): Now static.
12263 (read_char, kbd_buffer_get_event, make_lispy_position):
12264 (make_lispy_event, make_lispy_movement, apply_modifiers):
12265 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12266 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12267 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12268 (read_key_sequence, read_char): Mark locals as initialized.
12269 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12270
12271 * keyboard.h (make_ctrl_char): New decl.
12272 (mark_kboards): Move decl here ...
12273 * alloc.c (mark_kboards): ... from here.
12274
12275 * lisp.h (force_auto_save_soon): New decl.
12276
12277 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12278 (DEFINE_DUMMY_FUNCTION): New macro.
12279 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12280 Use it.
12281 (main): Add casts to avoid warnings
12282 if GCC considers string literals to be constants.
12283
12284 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12285
12286 * dbusbind.c: Pointer signedness fixes.
12287 (xd_signature, xd_append_arg, xd_initialize):
12288 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12289 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12290 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12291 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12292
12293 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12294 if GCC considers string literals to be constants.
12295 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12296
12297 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12298
12299 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12300 (print_preprocess, print_object): New macro to fix last change.
12301
12302 * print.c (print_preprocess): Don't forget font objects.
12303
12304 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12305
12306 * emacs.c (USAGE3): Doc fixes.
12307
12308 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12309
12310 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12311 structure.
12312
12313 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12314
12315 * lisp.h (VWindow_system, Qfile_name_history):
12316 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12317 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12318 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12319
12320 * w32select.c: Don't #include "keyboard.h".
12321 (run_protected): Add extern declaration for waiting_for_input.
12322
12323 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12324 * w32console.c (detect_input_pending, read_input_pending)
12325 (encode_terminal_code):
12326 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12327 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12328 (w32_system_caret_y, Qfile_name_history):
12329 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12330 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12331 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12332 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12333 * w32proc.c (Qlocal, report_file_error):
12334 * w32term.c (Vwindow_system, updating_frame):
12335 * w32uniscribe.c (initialized, uniscribe_font_driver):
12336 Remove unneeded extern declarations.
12337
12338 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12339
12340 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12341
12342 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12343
12344 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12345 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12346 These macros can no longer be used for assignment.
12347
12348 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12349 Assign struct members directly, instead of using BUF_BEGV etc.
12350 (record_buffer_markers, fetch_buffer_markers): New functions for
12351 recording and fetching special buffer markers.
12352 (set_buffer_internal_1, set_buffer_temp): Use them.
12353
12354 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12355
12356 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12357
12358 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12359 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12360
12361 * xdisp.c (hscroll_window_tree):
12362 (reconsider_clip_changes): Use PT instead of BUF_PT.
12363
12364 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12365
12366 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12367 $(EMACS_ROOT)/lib/intprops.h.
12368
12369 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12370
12371 Fix more problems found by GCC 4.5.2's static checks.
12372
12373 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12374 to unsigned char * to avoid compiler diagnostic.
12375 (xg_free_frame_widgets): Make it clear that a local variable is
12376 needed only if USE_GTK_TOOLTIP.
12377 (gdk_window_get_screen): Make it clear that this macro is needed
12378 only if USE_GTK_TOOLTIP.
12379 (int_gtk_range_get_value): New function, which avoids a diagnostic
12380 from gcc -Wbad-function-cast.
12381 (xg_set_toolkit_scroll_bar_thumb): Use it.
12382 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12383 diagnostic from gcc -Wbad-function-cast.
12384 (get_utf8_string, xg_get_file_with_chooser):
12385 Rename locals to avoid shadowing.
12386 (create_dialog): Move locals to avoid shadowing.
12387
12388 * xgselect.c (xg_select): Remove unused var.
12389
12390 * image.c (four_corners_best): Mark locals as initialized.
12391 (gif_load): Initialize transparent_p to zero (Bug#8238).
12392 Mark another local as initialized.
12393 (my_png_error, my_error_exit): Mark with NO_RETURN.
12394
12395 * image.c (clear_image_cache): Now static.
12396 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12397 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12398 (x_edge_detection): Remove unnecessary cast that
12399 gcc -Wbad-function-cast diagnoses.
12400 (gif_load): Fix pointer signedness.
12401 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12402 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12403
12404 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12405
12406 Improve quality of tests for time stamp overflow.
12407 For example, without this patch (encode-time 0 0 0 1 1
12408 1152921504606846976) returns the obviously-bogus value (-948597
12409 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12410 reports time overflow. See
12411 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12412 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12413 * editfns.c: Include limits.h and intprops.h.
12414 (TIME_T_MIN, TIME_T_MAX): New macros.
12415 (time_overflow): Move earlier, to before first use.
12416 (hi_time, lo_time): New functions, for an accurate test for
12417 out-of-range times.
12418 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12419 (Fget_internal_run_time): Don't assume time_t fits in int.
12420 (make_time): Use list2 instead of Fcons twice.
12421 (Fdecode_time): More accurate test for out-of-range times.
12422 (check_tm_member): New function.
12423 (Fencode_time): Use it, to test for out-of-range times.
12424 (lisp_time_argument): Don't rely on undefined left-shift and
12425 right-shift behavior when checking for time stamp overflow.
12426
12427 * editfns.c (time_overflow): New function, refactoring common code.
12428 (Fformat_time_string, Fdecode_time, Fencode_time):
12429 (Fcurrent_time_string): Use it.
12430
12431 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12432 * dired.c (make_time): Move to ...
12433 * editfns.c (make_time): ... here.
12434 * systime.h: Note the move.
12435
12436 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12437
12438 * fringe.c (update_window_fringes): Remove unused variables.
12439
12440 * unexmacosx.c (copy_data_segment): Also copy __got section.
12441 (Bug#8223)
12442
12443 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12444
12445 * termcap.c [MSDOS]: Include "msdos.h".
12446 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12447 Constify `char *' arguments and their references according to
12448 prototypes in tparam.h.
12449
12450 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12451
12452 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12453 Adapt all references accordingly.
12454
12455 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12456
12457 2011-03-11 Tom Tromey <tromey@redhat.com>
12458
12459 * buffer.c (syms_of_buffer): Remove obsolete comment.
12460
12461 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12462
12463 * termhooks.h (encode_terminal_code): Declare prototype.
12464
12465 * msdos.c (encode_terminal_code): Don't declare prototype.
12466
12467 * term.c (encode_terminal_code): Now external again, used by
12468 w32console.c and msdos.c.
12469
12470 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12471 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12472
12473 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12474
12475 Fix some minor problems found by GCC 4.5.2's static checks.
12476
12477 * fringe.c (update_window_fringes): Mark locals as initialized
12478 (Bug#8227).
12479 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12480
12481 * alloc.c (mark_fringe_data): Move decl from here ...
12482 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12483 to check its interface.
12484 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12485
12486 * fontset.c (free_realized_fontset): Now static.
12487 (Fset_fontset_font): Rename local to avoid shadowing.
12488 (fontset_font): Mark local as initialized.
12489 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12490
12491 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12492
12493 * xselect.c (x_disown_buffer_selections): Remove; not used.
12494 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12495 (x_own_selection, Fx_disown_selection_internal): Rename locals
12496 to avoid shadowing.
12497 (x_handle_dnd_message): Remove local to avoid shadowing.
12498
12499 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12500 so that the caller can use some name other than gcpro1.
12501 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12502 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12503 (Fx_backspace_delete_keys_p):
12504 Use them to avoid shadowing, and rename vars to avoid shadowing.
12505 (x_decode_color, x_set_name, x_window): Now static.
12506 (Fx_create_frame): Add braces to silence GCC warning.
12507 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12508 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12509 Remove unused locals.
12510 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12511 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12512 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12513 macros.
12514
12515 * xterm.h (x_mouse_leave): New decl.
12516
12517 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12518 Remove unused functions.
12519 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12520 (x_calc_absolute_position): Now static.
12521 (XTread_socket): Don't define label "out" unless it's used.
12522 Don't declare local "event" unless it's used.
12523 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12524 unless they are used.
12525 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12526 (x_fatal_error_signal): Remove; not used.
12527 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12528 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12529 (x_error_catcher, x_connection_closed, x_error_handler):
12530 (x_error_quitter, xembed_send_message, x_iconify_frame):
12531 (my_log_handler): Rename locals to avoid shadowing.
12532 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12533 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12534
12535 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12536 Rename or move locals to avoid shadowing.
12537 (tty_defined_color, merge_face_heights): Now static.
12538 (free_realized_faces_for_fontset): Remove; not used.
12539 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12540 does not deduce is never used uninitialized.
12541 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12542 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12543
12544 * terminal.c (store_terminal_param): Now static.
12545
12546 * xmenu.c (menu_highlight_callback): Now static.
12547 (set_frame_menubar): Remove unused local.
12548 (xmenu_show): Rename parameter to avoid shadowing.
12549 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12550 since they might point to immutable storage.
12551 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12552 since it's unused otherwise.
12553
12554 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12555 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12556 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12557 avoids a gcc -Wuninitialized diagnostic.
12558 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12559 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12560 does not deduce are never used uninitialized.
12561
12562 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12563
12564 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12565 * window.c (window_loop, size_window):
12566 (run_window_configuration_change_hook, enlarge_window): Likewise.
12567
12568 * window.c (display_buffer): Now static.
12569 (size_window): Mark variables that gcc -Wuninitialized
12570 does not deduce are never used uninitialized.
12571 * window.h (check_all_windows): New decl, to forestall
12572 gcc -Wmissing-prototypes diagnostic.
12573 * dispextern.h (bidi_dump_cached_states): Likewise.
12574
12575 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12576 shadowing.
12577 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12578 Include <limits.h>.
12579 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12580 and to avoid gcc -Wuninitialized warning.
12581 (load_charset_map): Mark variables that gcc -Wuninitialized
12582 does not deduce are never used uninitialized.
12583 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12584
12585 * coding.c (coding_set_source, coding_set_destination):
12586 Use "else { /* comment */ }" rather than "else /* comment */;"
12587 for clarity, and to avoid gcc -Wempty-body warning.
12588 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12589 a block, when the outer 'i' will do.
12590 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12591 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12592 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12593 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12594 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12595 Rename locals to avoid shadowing.
12596 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12597 * coding.c (emacs_mule_char, encode_invocation_designation):
12598 Now static, since they're not used elsewhere.
12599 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12600 (decode_coding_object, encode_coding_object, detect_coding_system):
12601 (decode_coding_emacs_mule): Mark variables that gcc
12602 -Wuninitialized does not deduce are never used uninitialized.
12603 (detect_coding_iso_2022): Initialize a local variable that might
12604 be used uninitialized. Leave a FIXME because it's not clear that
12605 this initialization is needed. (Bug#8211)
12606 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12607 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12608 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12609 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12610 Remove unused macros.
12611
12612 * category.c (hash_get_category_set): Remove unused local var.
12613 (copy_category_table): Now static, since it's not used elsewhere.
12614 * character.c (string_count_byte8): Likewise.
12615
12616 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12617 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12618
12619 * chartab.c (copy_sub_char_table): Now static, since it's not used
12620 elsewhere.
12621 (sub_char_table_ref_and_range, char_table_ref_and_range):
12622 Rename locals to avoid shadowing.
12623 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12624
12625 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12626 (BIDI_BOB): Remove unused macro.
12627
12628 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12629 deduce are never used uninitialized.
12630 * term.c (encode_terminal_code): Likewise.
12631
12632 * term.c (encode_terminal_code): Now static. Remove unused local.
12633
12634 * tparam.h: New file.
12635 * term.c, tparam.h: Include it.
12636 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12637 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12638 Move these decls to tparam.h, and make them agree with what
12639 is actually in tparam.c. The previous trick of using incompatible
12640 decls in different modules does not conform to the C standard.
12641 All callers of tparam changed to use tparam's actual API.
12642 * tparam.c (tparam1, tparam, tgoto):
12643 Use const pointers where appropriate.
12644
12645 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12646 * cm.h (struct cm): Likewise.
12647 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12648 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12649 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12650 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12651 (turn_on_face, init_tty): Likewise.
12652 * termchar.h (struct tty_display_info): Likewise.
12653
12654 * term.c (term_mouse_position): Rename local to avoid shadowing.
12655
12656 * alloc.c (mark_ttys): Move decl from here ...
12657 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12658
12659 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12660
12661 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12662
12663 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12664
12665 * search.c (compile_pattern_1): Remove argument regp, unused since
12666 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12667 (compile_pattern): Don't pass it.
12668
12669 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12670
12671 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12672 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12673 for ! HAVE_GTK3.
12674 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12675
12676 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12677
12678 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12679 gdk_window_get_screen, gdk_window_get_geometry,
12680 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12681 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12682 (xg_get_pixbuf_from_pixmap): New function.
12683 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12684 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12685 Call xg_get_pixbuf_from_pixmap instead of
12686 gdk_pixbuf_get_from_drawable.
12687 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12688 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12689 (xg_check_special_colors): Use GtkStyleContext and its functions
12690 for HAVE_GTK3.
12691 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12692 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12693 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12694 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12695 Call gtk_widget_get_preferred_size.
12696 (xg_frame_resized): gdk_window_get_geometry only takes 5
12697 parameters.
12698 (xg_win_to_widget, xg_event_is_for_menubar):
12699 Call gdk_x11_window_lookup_for_display.
12700 (xg_set_widget_bg): New function.
12701 (delete_cb): New function.
12702 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12703 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12704 (xg_set_background_color): Call xg_set_widget_bg.
12705 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12706 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12707 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12708 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12709 if ! HAVE_GTK3.
12710 (update_frame_tool_bar): Call gtk_widget_hide.
12711 (xg_initialize): Use GDK_KEY_g.
12712
12713 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12714 if ! HAVE_GTK3
12715 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12716
12717 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12718 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12719 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12720
12721 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12722
12723 * w32xfns.c (select_palette): Check success of RealizePalette against
12724 GDI_ERROR, not zero.
12725
12726 See ChangeLog.11 for earlier changes.
12727
12728 ;; Local Variables:
12729 ;; coding: utf-8
12730 ;; End:
12731
12732 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12733
12734 This file is part of GNU Emacs.
12735
12736 GNU Emacs is free software: you can redistribute it and/or modify
12737 it under the terms of the GNU General Public License as published by
12738 the Free Software Foundation, either version 3 of the License, or
12739 (at your option) any later version.
12740
12741 GNU Emacs is distributed in the hope that it will be useful,
12742 but WITHOUT ANY WARRANTY; without even the implied warranty of
12743 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12744 GNU General Public License for more details.
12745
12746 You should have received a copy of the GNU General Public License
12747 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.