Fix network-interface-list|info on newer BSD derived OS:es.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2
3 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4 (Fnetwork_interface_list): Allocate in increments of bytes instead
5 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7 sockaddr.
8 (struct ifflag_def): notrailers is smart on OSX.
9 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10 Get hardware address with getifaddrs if available.
11
12 2011-08-12 Eli Zaretskii <eliz@gnu.org>
13
14 * xdisp.c (iterate_out_of_display_property): xassert that
15 IT->position is set to within IT->object's boundaries. Break from
16 the loop as soon as EOB is reached; avoids infloops in redisplay
17 when IT->position is set up wrongly due to some bug. Set
18 IT->current to match the bidi iterator unconditionally.
19 (push_display_prop): Allow GET_FROM_STRING as IT->method on
20 entry. Force push_it to save on the stack the current
21 buffer/string position, to be restored by pop_it. Fix flags in
22 the iterator structure wrt the object coming from a display
23 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
24 properties. (Bug#9284)
25
26 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
27
28 * fontset.c (fontset_get_font_group): Add proper type checks.
29 (Bug#9172)
30
31 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
32
33 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
34 and LC_VERSION_MIN_MACOSX.
35 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
36 (dump_it) [LC_FUNCTION_STARTS]: Use it.
37
38 2011-08-08 Eli Zaretskii <eliz@gnu.org>
39
40 * xdisp.c (forward_to_next_line_start): Allow to use the
41 no-display-properties-and-no-overlays under bidi display. Set
42 disp_pos in the bidi iterator to avoid searches for display
43 properties and overlays.
44
45 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
46
47 * editfns.c (Fset_time_zone_rule): Document relationship with the
48 setenv function.
49
50 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
51 the font entity extracted from the cache (Bug#8109).
52
53 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
54
55 * composite.c (autocmp_chars): Don't reset point. That is done by
56 restore_point_unwind (Bug#5984).
57
58 2011-08-07 Juri Linkov <juri@jurta.org>
59
60 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
61 to show the arg `TIME' instead of `TIMEVAL'.
62
63 2011-08-06 Eli Zaretskii <eliz@gnu.org>
64
65 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
66 display property strides EOL and includes a newline, as in
67 longlines-mode. (Bug#9254)
68 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
69 word-wrap under bidirectional display. (Bug#9224)
70
71 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
72 is non-zero, even if the data buffer is NULL. Fixes a crash in
73 vertical-motion with longlines-mode. (Bug#9254)
74
75 2011-08-05 Eli Zaretskii <eliz@gnu.org>
76
77 * bidi.c <bidi_cache_total_alloc>: Now static.
78 (bidi_initialize): Initialize bidi_cache_total_alloc.
79
80 *xdisp.c (display_line): Release buffer allocated for shelved bidi
81 cache. (Bug#9221)
82
83 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
84 amount allocated this far in `bidi_cache_total_alloc'.
85 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
86 non-zero, only free the data buffer without restoring the cache
87 contents. All callers changed.
88
89 * dispextern.h (bidi_unshelve_cache): Update prototype.
90
91 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
92 (move_it_in_display_line, move_it_to)
93 (move_it_vertically_backward, move_it_by_lines): Replace the call
94 to xfree to an equivalent call to bidi_unshelve_cache.
95 (move_it_in_display_line_to): Fix logic of returning
96 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
97
98 2011-08-05 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
101 came from a string character with a `cursor' property. (Bug#9229)
102
103 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
104
105 * Makefile.in (LIB_PTHREAD): New variable.
106 (LIBES): Add LIB_PTHREAD (Bug#9216).
107
108 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
109 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
110
111 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
112
113 * regex.c (re_iswctype): Remove some redundant boolean
114 conversions.
115
116 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
117
118 * xterm.c (x_find_topmost_parent): New function.
119 (x_set_frame_alpha): Find topmost parent window with
120 x_find_topmost_parent and set the property there also (bug#9181).
121 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
122
123 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
124
125 * callproc.c (Fcall_process): Avoid vfork clobbering
126 the local vars buffer, coding_systems, current_dir.
127
128 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
129
130 * keymap.c (Fmake_composed_keymap): Move to subr.el.
131
132 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
133
134 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
135 so that it is not optimized away.
136
137 * xdisp.c (compute_display_string_pos): Remove unused local.
138
139 2011-08-02 Eli Zaretskii <eliz@gnu.org>
140
141 Fix slow cursor motion and scrolling in large buffers with
142 selective display, like Org Mode buffers. (Bug#9218)
143
144 * dispextern.h (struct bidi_it): New member disp_prop_p.
145
146 * xdisp.c: Remove one-slot cache of display string positions.
147 (compute_display_string_pos): Accept an additional argument
148 DISP_PROP_P; callers changed. Scan at most 5K characters forward
149 for a display string or property. If found, set DISP_PROP_P
150 non-zero.
151
152 * bidi.c (bidi_fetch_char): Accept an additional argument
153 DISP_PROP_P, and pass it to compute_display_string_pos.
154 Only handle text covered by a display string if DISP_PROP_P is returned
155 non-zero. All callers of bidi_fetch_char changed.
156
157 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
158
159 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
160
161 2010-12-03 Don March <don@ohspite.net>
162
163 * keymap.c (Fdefine_key): Fix non-prefix key error message when
164 last character M-[char] is translated to ESC [char] (bug#7541).
165
166 2011-08-02 Kenichi Handa <handa@m17n.org>
167
168 * lisp.h (uniprop_table): Extern it.
169
170 * chartab.c (uniprop_table): Make it non-static.
171
172 2011-08-01 Eli Zaretskii <eliz@gnu.org>
173
174 * xdisp.c (forward_to_next_line_start): Accept additional argument
175 BIDI_IT_PREV, and store into it the state of the bidi iterator had
176 on the newline.
177 (reseat_at_next_visible_line_start): Use the bidi iterator state
178 returned by forward_to_next_line_start to restore the state of
179 it->bidi_it after backing up to previous newline. (Bug#9212)
180
181 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
182
183 * regex.c (re_comp): Protoize.
184 (re_exec): Fix return type.
185 (regexec): Fix type of `ret'. (Bug#9203)
186
187 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
188
189 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
190 This is needed if max-image-size is a floating-point number.
191
192 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
193
194 * print.c (print_object): Print empty symbol as ##.
195
196 * lread.c (read1): Read ## as empty symbol.
197
198 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
199
200 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
201 setting frame foreground color (Bug#9175).
202 (x_set_background_color): Likewise.
203
204 * nsmenu.m (-setText): Size tooltip dimensions precisely to
205 contents (Bug#9176).
206 (EmacsTooltip -init): Remove bezels and add shadows to
207 tooltip windows.
208
209 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
210 or scroll bar (Bug#8470).
211
212 * nsfont.m (nsfont_open): Remove assignment to voffset and
213 unnecessary vars hshink, expand, hd, full_height, min_height.
214 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
215
216 * nsterm.h (nsfont_info): Remove voffset field.
217
218 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
219
220 Implement strike-through and overline on NextStep (Bug#8863).
221
222 * nsfont.m (nsfont_open): Use underline position provided by font,
223 instead of hard-coded value of 2.
224 (nsfont_draw): Call ns_draw_text_decoration instead.
225
226 * nsterm.h: Add declaration for ns_draw_text_decoration.
227
228 * nsterm.m (ns_draw_text_decoration): New function for drawing
229 underline, overline, and strike-through.
230 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
231 ns_draw_text_decoration. Change treatment of cursor drawing to
232 accomodate underlining, etc.
233
234 2011-07-28 Eli Zaretskii <eliz@gnu.org>
235
236 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
237 default.
238
239 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
240
241 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
242 Without this fix, if a signal arrives just after memory fills up,
243 'malloc' might be invoked reentrantly.
244
245 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
246 In other words, assume that every image size is allowed, on non-X
247 hosts. This assumption is probably wrong, but it lets Emacs compile.
248
249 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
250
251 * regex.c (re_iswctype): Convert return values to boolean.
252
253 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
254
255 * xdisp.c (compute_display_string_pos): Don't use cached display
256 string position if the buffer had its restriction changed.
257 (Bug#9184)
258
259 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
260
261 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
262
263 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
264
265 Integer signedness and overflow and related fixes. (Bug#9079)
266
267 * bidi.c: Integer size and overflow fixes.
268 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
269 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
270 (bidi_cache_find_level_change, bidi_cache_ensure_space)
271 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
272 (bidi_find_other_level_edge):
273 Use ptrdiff_t instead of EMACS_INT where either will do.
274 This works better on 32-bit hosts configured --with-wide-int.
275 (bidi_cache_ensure_space): Check for size-calculation overflow.
276 Use % rather than repeated addition, for better worst-case speed.
277 Don't set bidi_cache_size until after xrealloc returns, because it
278 might not return.
279 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
280 (bidi_cache_ensure_space): Also check that the bidi cache size
281 does not exceed that of the largest Lisp string or buffer. See Eli
282 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
283
284 * alloc.c (__malloc_size_t): Remove.
285 All uses replaced by size_t. See Andreas Schwab's note
286 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
287
288 * image.c: Improve checking for integer overflow.
289 (check_image_size): Assume that f is nonnull, since
290 it is always nonnull in practice. This is one less thing to
291 worry about when checking for integer overflow later.
292 (x_check_image_size): New function, which checks for integer
293 overflow issues inside X.
294 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
295 This removes the need for a memory_full check.
296 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
297 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
298 (xbm_read_bitmap_data): Change locals back to 'int', since
299 their values must fit in 'int'.
300 (xpm_load_image, png_load, tiff_load):
301 Invoke x_create_x_image_and_pixmap earlier,
302 to avoid much needless work if the image is too large.
303 (tiff_load): Treat overly large images as if
304 x_create_x_image_and_pixmap failed, not as malloc failures.
305 (gs_load): Use x_check_image_size.
306
307 * gtkutil.c: Omit integer casts.
308 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
309 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
310
311 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
312
313 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
314 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
315 would wrongly return t on a 64-bit host.
316
317 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
318 The plain *_OVERFLOW macros run afoul of GCC bug 49705
319 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
320 and therefore cause GCC to emit a bogus diagnostic in some cases.
321
322 * image.c: Integer signedness and overflow and related fixes.
323 This is not an exhaustive set of fixes, but it's time to
324 record what I've got.
325 (lookup_pixel_color, check_image_size): Remove redundant decls.
326 (check_image_size): Don't assume that arbitrary EMACS_INT values
327 fit in 'int', or that arbitrary 'double' values fit in 'int'.
328 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
329 (tiff_load, imagemagick_load_image):
330 Check for overflow in size calculations.
331 (x_create_x_image_and_pixmap): Remove unnecessary test for
332 xmalloc returning NULL; that can't happen.
333 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
334 (xpm_color_bucket): Use better integer hashing function.
335 (xpm_cache_color): Don't possibly over-allocate memory.
336 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
337 (gif_memory_source):
338 Use ptrdiff_t, not int or size_t, to record sizes.
339 (png_load): Don't assume values greater than 2**31 fit in 'int'.
340 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
341 either works, as we prefer signed integers.
342 (tiff_read_from_memory, tiff_write_from_memory):
343 Return tsize_t, not size_t, since that's what the TIFF API wants.
344 (tiff_read_from_memory): Don't fail simply because the read would
345 go past EOF; instead, return a short read.
346 (tiff_load): Omit no-longer-needed casts.
347 (Fimagemagick_types): Don't assume size fits into 'int'.
348
349 Improve hashing quality when configured --with-wide-int.
350 * fns.c (hash_string): New function, taken from sxhash_string.
351 Do not discard information about ASCII character case; this
352 discarding is no longer needed.
353 (sxhash-string): Use it. Change sig to match it. Caller changed.
354 * lisp.h: Declare it.
355 * lread.c (hash_string): Remove, since we now use fns.c's version.
356 The fns.c version returns a wider integer if --with-wide-int is
357 specified, so this should help the quality of the hashing a bit.
358
359 * emacs.c: Integer overflow minor fix.
360 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
361 Define only if GNU_LINUX.
362 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
363
364 * dispnew.c: Integer signedness and overflow fixes.
365 Remove unnecessary forward decls, that were a maintenance hassle.
366 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
367 All uses changed.
368 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
369 (scrolling_window): Use ptrdiff_t, not int, for byte count.
370 (prepare_desired_row, line_draw_cost):
371 Use int, not unsigned, where either works.
372 (save_current_matrix, restore_current_matrix):
373 Use ptrdiff_t, not size_t, where either works.
374 (init_display): Check for overflow more accurately, and without
375 relying on undefined behavior.
376
377 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
378 Remove, replacing with the new symbols in lisp.h. All uses changed.
379 * fileio.c (make_temp_name):
380 * filelock.c (lock_file_1, lock_file):
381 * xdisp.c (message_dolog):
382 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
383 Use pMd etc. instead.
384 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
385 replacing the pWIDE etc. symbols removed from editfns.c.
386
387 * keyboard.h (num_input_events): Now uintmax_t.
388 This is (very slightly) less likely to mess up due to wraparound.
389 All uses changed.
390
391 * buffer.c: Integer signedness fixes.
392 (alloc_buffer_text, enlarge_buffer_text):
393 Use ptrdiff_t rather than size_t when either will do, as we prefer
394 signed integers.
395
396 * alloc.c: Integer signedness and overflow fixes.
397 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
398 (__malloc_size_t): Default to size_t, not to int.
399 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
400 (Fgarbage_collect, mark_object_loop_halt, mark_object):
401 Prefer ptrdiff_t to size_t when either would do, as we prefer
402 signed integers.
403 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
404 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
405 Now const. Initialize with values that are in range even if char
406 is signed.
407 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
408 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
409 These functions do the right thing with sizes > 2**32.
410 (check_depth): Now ptrdiff_t, not int.
411 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
412 Adjust to new way of storing sizes. Check for size overflow bugs
413 in rest of code.
414 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
415 slightly wrong anyway, as it missed one instance of
416 XMALLOC_OVERRUN_CHECK_OVERHEAD.
417 (refill_memory_reserve): Omit needless cast to size_t.
418 (mark_object_loop_halt): Mark as externally visible.
419
420 * xselect.c: Integer signedness and overflow fixes.
421 (Fx_register_dnd_atom, x_handle_dnd_message):
422 Use ptrdiff_t, not size_t, since we prefer signed.
423 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
424 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
425 x_dnd_atoms_size and x_dnd_atoms_length.
426
427 * doprnt.c: Prefer signed to unsigned when either works.
428 * eval.c (verror):
429 * doprnt.c (doprnt):
430 * lisp.h (doprnt):
431 * xdisp.c (vmessage):
432 Use ptrdiff_t, not size_t, when using or implementing doprnt,
433 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
434 prefer signed arithmetic to avoid comparison confusion.
435 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
436 but is a bit tricky.
437
438 Assume freestanding C89 headers, string.h, stdlib.h.
439 * data.c, doprnt.c, floatfns.c, print.c:
440 Include float.h unconditionally.
441 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
442 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
443 * regex.c: Likewise for stddef.h, string.h.
444 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
445 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
446 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
447 (STDC_HEADERS): Remove obsolete defines.
448 * sysdep.c: Include limits.h unconditionally.
449
450 Assume support for memcmp, memcpy, memmove, memset.
451 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
452 * regex.c (memcmp, memcpy):
453 Remove; we assume C89 now.
454
455 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
456 (__malloc_safe_bcopy): Remove; no longer needed.
457
458 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
459 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
460 well either way, and we prefer signed to unsigned.
461
462 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
463
464 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
465 closes the connection while we're reading (bug#9182).
466
467 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
468
469 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
470 are specified (Bug#9168).
471
472 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
473
474 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
475 Found by GCC static checking and --with-wide-int on a 32-bit host.
476
477 2011-07-25 Eli Zaretskii <eliz@gnu.org>
478
479 * xdisp.c (compute_display_string_pos): Fix logic of caching
480 previous display string position. Initialize cached_prev_pos to
481 -1. Fixes slow-down at the beginning of a buffer.
482
483 2011-07-24 Eli Zaretskii <eliz@gnu.org>
484
485 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
486 for attrs[LFACE_FONTSET_INDEX].
487
488 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
489
490 * xml.c (parse_region): Remove unused local
491 that was recently introduced.
492
493 2011-07-23 Eli Zaretskii <eliz@gnu.org>
494
495 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
496 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
497
498 * xdisp.c (move_it_in_display_line_to): Record the best matching
499 position for TO_CHARPOS while scanning the line, and restore it on
500 exit if none of the characters scanned was an exact match.
501 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
502 when exact match is impossible due to invisible text, and the
503 lines are truncated.
504
505 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
506
507 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
508 for OSX >= 10.7.
509
510 2011-07-22 Eli Zaretskii <eliz@gnu.org>
511
512 Fix a significant slow-down of cursor motion with C-n, C-p,
513 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
514 auto-repeat under bidi redisplay in fontified buffers.
515 * xdisp.c (compute_stop_pos_backwards): New function.
516 (next_element_from_buffer): Call compute_stop_pos_backwards to
517 find a suitable prev_stop when we find ourselves before
518 base_level_stop.
519 (reseat): Don't look for prev_stop, as that could mean a very long
520 run.
521 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
522 <cached_disp_overlay_modiff>: Cache for last found display string
523 position.
524 (compute_display_string_pos): Return the cached position if asked
525 about the same buffer in the same area of character positions, and
526 the buffer wasn't changed since the time the display string
527 position was cached.
528
529 2011-07-22 Eli Zaretskii <eliz@gnu.org>
530
531 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
532 is an integer, which is important for empty lines. (Bug#9149)
533
534 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
535
536 * frame.c (Fmodify_frame_parameters): In tty case, update the
537 default face if necessary (Bug#4238).
538
539 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
540
541 * editfns.c (Fstring_to_char): No need to explain what a character
542 is in the docstring (Bug#6576).
543
544 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
545
546 * xml.c (parse_region): Make sure we always return a tree.
547
548 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
549
550 * xml.c (parse_region): If a document contains only comments,
551 return that, too.
552
553 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
554
555 * xml.c (make_dom): Return comments, too.
556
557 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
558
559 Port to OpenBSD.
560 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
561 and the surrounding thread.
562 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
563 rather than fgets, and retry after EINTR. Otherwise, 'emacs
564 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
565 timer goes off.
566 * s/openbsd.h (BROKEN_SIGIO): Define.
567 * unexelf.c (unexec) [__OpenBSD__]:
568 Don't update the .mdebug section of the Alpha COFF symbol table.
569
570 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
571
572 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
573 (bug#8460).
574
575 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
576
577 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
578 This fixes some race conditions on the permissions of any newly
579 created file.
580
581 * alloc.c (valid_pointer_p): Use pipe, not open.
582 This fixes some permissions issues when debugging.
583
584 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
585 If fchown fails to set both uid and gid, try to set just gid,
586 as that is sometimes allowed. Adjust the file's mode to eliminate
587 setuid or setgid bits that are inappropriate if fchown fails.
588
589 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
590
591 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
592 to compare Lisp_Objects.
593 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
594 global_gnutls_log_level, don't mistake it for a Lisp_Object.
595 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
596
597 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
598
599 * lread.c (read_integer): Unread even EOF character.
600 (read1): Likewise. Properly record start position of symbol.
601
602 * lread.c (read1): Read `#:' as empty uninterned symbol if no
603 symbol character follows.
604
605 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
606
607 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
608 This works around a problem with the previous change to Fcopy_file.
609 Recent glibc declares fchown with __attribute__((warn_unused_result)),
610 and without this change, GCC might complain about discarding
611 fchown's return value.
612
613 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
614
615 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
616
617 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
618
619 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
620
621 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
622
623 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
624 it's used from the C level.
625
626 * process.c: Use the same condition for POLL_FOR_INPUT in both
627 keyboard.c and process.c (bug#1858).
628
629 2011-07-09 Lawrence Mitchell <wence@gmx.li>
630
631 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
632 (Fgnutls_boot): Use it.
633
634 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
635
636 * doc.c (Fsubstitute_command_keys): Revert last change.
637
638 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
639
640 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
641 quotes the next character, and doesn't affect other longer
642 sequences (bug#8935).
643
644 * lread.c (syms_of_lread): Clarify that is isn't only
645 `eval-buffer' and `eval-defun' that's affected by
646 `lexical-binding' (bug#8460).
647
648 2011-07-15 Eli Zaretskii <eliz@gnu.org>
649
650 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
651 bidi redisplay when a line includes both an image and is
652 truncated.
653
654 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
655
656 Fix minor problems found by static checking.
657 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
658 (elsz): Now a signed constant, not a size_t var. We prefer signed
659 types to unsigned, to avoid integer comparison confusion. Without
660 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
661 "cannot optimize loop, the loop counter may overflow", a symptom
662 of the confusion.
663 * indent.c (Fvertical_motion): Mark locals as initialized.
664 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
665
666 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
667
668 * search.c (Fre_search_backward): Mention `case-fold-search' in
669 all the re_search_* functions (bug#8138).
670
671 * keyboard.c (Fopen_dribble_file): Document when the file is
672 closed (bug#8056).
673
674 2011-07-14 Eli Zaretskii <eliz@gnu.org>
675
676 * bidi.c (bidi_dump_cached_states): Fix format of displaying
677 bidi_cache_idx.
678
679 Support bidi reordering of display and overlay strings.
680 * xdisp.c (compute_display_string_pos)
681 (compute_display_string_end): Accept additional argument STRING.
682 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
683 (reseat_to_string): Initialize bidi_it->string.s and
684 bidi_it->string.schars.
685 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
686 NULL (avoids a crash in bidi_paragraph_init).
687 Initialize itb.string.lstring.
688 (init_iterator): Call bidi_init_it only of a valid
689 buffer position was specified. Initialize paragraph_embedding to
690 L2R.
691 (reseat_to_string): Initialize the bidi iterator.
692 (display_string): If we need to ignore text properties of
693 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
694 original value of -1 will not work with bidi.)
695 (compute_display_string_pos): First arg is now struct
696 `text_pos *'; all callers changed. Support display properties on
697 Lisp strings.
698 (compute_display_string_end): Support display properties on Lisp
699 strings.
700 (init_iterator, reseat_1, reseat_to_string): Initialize the
701 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
702 when iterating on a string not from display properties).
703 (compute_display_string_pos, compute_display_string_end):
704 Fix calculation of the object to scan. Fixes an error when using
705 arrow keys.
706 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
707 base_level_stop; instead, set base_level_stop to BEGV.
708 Fixes crashes in vertical-motion.
709 (next_element_from_buffer): Improve commentary for when
710 the iterator is before prev_stop.
711 (init_iterator): Initialize bidi_p from the default value of
712 bidi-display-reordering, not from buffer-local value. Use the
713 buffer-local value only if initializing for buffer iteration.
714 (handle_invisible_prop): Support invisible properties on strings
715 that are being bidi-reordered.
716 (set_iterator_to_next): Support bidi reordering of C strings and
717 Lisp strings.
718 (next_element_from_string): Support bidi reordering of Lisp
719 strings.
720 (handle_stop_backwards): Support Lisp strings as well.
721 (display_string): Support display of R2L glyph rows.
722 Use IT_STRING_CHARPOS when displaying from a Lisp string.
723 (init_iterator): Don't initialize it->bidi_p for strings
724 here.
725 (reseat_to_string): Initialize it->bidi_p for strings here.
726 (next_element_from_string, next_element_from_c_string)
727 (next_element_from_buffer): Add xassert's for correspondence
728 between IT's object being iterated and it->bidi_it.string
729 structure.
730 (face_before_or_after_it_pos): Support bidi iteration.
731 (next_element_from_c_string): Handle the case of the first string
732 character that is not the first one in the visual order.
733 (get_visually_first_element): New function, refactored from common
734 parts of next_element_from_buffer, next_element_from_string, and
735 next_element_from_c_string.
736 (tool_bar_lines_needed, redisplay_tool_bar)
737 (display_menu_bar): Force left-to-right direction. Add a FIXME
738 comment for making that be controlled by a user option.
739 (push_it, pop_it): Save and restore the state of the
740 bidi iterator. Save and restore the bidi_p flag.
741 (pop_it): Iterate out of display property for string iteration as
742 well.
743 (iterate_out_of_display_property): Support iteration over strings.
744 (handle_single_display_spec): Set up it->bidi_it for iteration
745 over a display string, and call bidi_init_it.
746 (handle_single_display_spec, next_overlay_string)
747 (get_overlay_strings_1, push_display_prop): Set up the bidi
748 iterator for displaying display or overlay strings.
749 (forward_to_next_line_start): Don't use the shortcut if
750 bidi-iterating.
751 (back_to_previous_visible_line_start): If handle_display_prop
752 pushed the iterator stack, restore the internal state of the bidi
753 iterator by calling bidi_pop_it same number of times.
754 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
755 and we are bidi-iterating, don't decrement the iterator position;
756 instead, set the first_elt flag in the bidi iterator, to produce
757 the same effect.
758 (reseat_1): Remove redundant setting of string_from_display_prop_p.
759 (push_display_prop): xassert that we are iterating a buffer.
760 (push_it, pop_it): Save and restore paragraph_embedding member.
761 (handle_single_display_spec, next_overlay_string)
762 (get_overlay_strings_1, reseat_1, reseat_to_string)
763 (push_display_prop): Set up the `unibyte' member of bidi_it.string
764 correctly. Don't assume unibyte strings are not bidi-reordered.
765 (compute_display_string_pos)
766 (compute_display_string_end): Fix handling the case of C string.
767 (push_it, pop_it): Save and restore from_disp_prop_p.
768 (handle_single_display_spec, push_display_prop): Set the
769 from_disp_prop_p flag.
770 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
771 (pop_it): Call iterate_out_of_display_property only if we are
772 popping after iteration over a string that came from a display
773 property. Fix a typo in popping stretch info. Add an assertion
774 for verifying that the iterator position is in sync with the bidi
775 iterator.
776 (handle_single_display_spec, get_overlay_strings_1)
777 (push_display_prop): Fix initialization of paragraph direction for
778 string when that of the parent object is not yet determined.
779 (reseat_1): Call bidi_init_it to resync the bidi
780 iterator with IT's position. (Bug#7616)
781 (find_row_edges): If ROW->start.pos gives position
782 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
783 (handle_stop, back_to_previous_visible_line_start, reseat_1):
784 Reset the from_disp_prop_p flag.
785 (SAVE_IT, RESTORE_IT): New macros.
786 (pos_visible_p, face_before_or_after_it_pos)
787 (back_to_previous_visible_line_start)
788 (move_it_in_display_line_to, move_it_in_display_line)
789 (move_it_to, move_it_vertically_backward, move_it_by_lines)
790 (try_scrolling, redisplay_window, display_line): Use them when
791 saving a temporary copy of the iterator and restoring it back.
792 (back_to_previous_visible_line_start, reseat_1)
793 (init_iterator): Empty the bidi cache "stack".
794 (move_it_in_display_line_to): If iterator ended up at
795 EOL, but we never saw any buffer positions smaller than
796 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
797 motion in bidi-reordered lines.
798 (move_it_in_display_line_to): Record prev_method and prev_pos
799 immediately before the call to set_iterator_to_next. Fixes cursor
800 motion in bidi-reordered lines with stretch glyphs and strings
801 displayed in margins. (Bug#8133) (Bug#8867)
802 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
803 TO_CHARPOS.
804 (pos_visible_p): Support positions in bidi-reordered lines.
805 Save and restore bidi cache.
806
807 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
808 (bidi_paragraph_info): Delete unused struct.
809 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
810 (bidi_cache_start): New variable.
811 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
812 to zero.
813 (bidi_cache_fetch_state, bidi_cache_search)
814 (bidi_cache_find_level_change, bidi_cache_iterator_state)
815 (bidi_cache_find, bidi_peek_at_next_level)
816 (bidi_level_of_next_char, bidi_find_other_level_edge)
817 (bidi_move_to_visually_next): Compare cache index with
818 bidi_cache_start rather than with zero.
819 (bidi_fetch_char): Accept new argument STRING; all callers
820 changed. Support iteration over a string. Support strings with
821 display properties. Support unibyte strings. Fix the type of
822 `len' according to what STRING_CHAR_AND_LENGTH expects.
823 (bidi_paragraph_init, bidi_resolve_explicit_1)
824 (bidi_resolve_explicit, bidi_resolve_weak)
825 (bidi_level_of_next_char, bidi_move_to_visually_next):
826 Support iteration over a string.
827 (bidi_set_sor_type, bidi_resolve_explicit_1)
828 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
829 can now be zero (for strings); special values 0 and -1 were
830 changed to -1 and -2, respectively.
831 (bidi_char_at_pos): New function.
832 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
833 Call it instead of FETCH_MULTIBYTE_CHAR.
834 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
835 initialized to valid values.
836 (bidi_init_it): Don't initialize charpos and bytepos with invalid
837 values.
838 (bidi_level_of_next_char): Allow the sentinel "position" to pass
839 the test for valid cached positions. Fix the logic for looking up
840 the sentinel state in the cache. GCPRO the Lisp string we are
841 iterating.
842 (bidi_push_it, bidi_pop_it): New functions.
843 (bidi_initialize): Initialize the bidi cache start stack pointer.
844 (bidi_cache_ensure_space): New function, refactored from part of
845 bidi_cache_iterator_state. Don't assume the required size is just
846 one BIDI_CACHE_CHUNK away.
847 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
848 (bidi_count_bytes, bidi_char_at_pos): New functions.
849 (bidi_cache_search): Don't assume bidi_cache_last_idx is
850 always valid if bidi_cache_idx is valid.
851 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
852 is valid if it's going to be used.
853 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
854 (bidi_cache_fetch_state, bidi_cache_search)
855 (bidi_cache_find_level_change, bidi_cache_ensure_space)
856 (bidi_cache_iterator_state, bidi_cache_find)
857 (bidi_find_other_level_edge, bidi_cache_start_stack):
858 All variables related to cache indices are now EMACS_INT.
859
860 * dispextern.h (struct bidi_string_data): New structure.
861 (struct bidi_it): New member `string'. Make flag members be 1-bit
862 fields, and put them last in the struct.
863 (compute_display_string_pos, compute_display_string_end):
864 Update prototypes.
865 (bidi_push_it, bidi_pop_it): Add prototypes.
866 (struct iterator_stack_entry): New members bidi_p,
867 paragraph_embedding, and from_disp_prop_p.
868 (struct it): Member bidi_p is now a bit field 1 bit wide.
869 (bidi_shelve_cache, bidi_unshelve_cache):
870 Declare prototypes.
871
872 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
873 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
874 and vector-like objects.
875
876 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
877 cache around display iteration.
878
879 * window.c (Fwindow_end, window_scroll_pixel_based)
880 (displayed_window_lines, Frecenter): Save and restore the bidi
881 cache around display iteration.
882
883 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
884
885 * editfns.c (Fdelete_region): Clarify the use of the named
886 parameters (bug#6788).
887
888 2011-07-14 Martin Rudalics <rudalics@gmx.at>
889
890 * indent.c (Fvertical_motion): Set and restore w->pointm when
891 saving and restoring the window's buffer (Bug#9006).
892
893 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
894
895 * editfns.c (Fstring_to_char): Clarify just what is returned
896 (bug#6576). Text by Eli Zaretskii.
897
898 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
899
900 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
901
902 2011-07-13 Eli Zaretskii <eliz@gnu.org>
903
904 * buffer.c (mmap_find): Fix a typo.
905
906 2011-07-13 Johan Bockgård <bojohan@gnu.org>
907
908 Fix execution of x selection hooks.
909 * xselect.c (Qx_lost_selection_functions)
910 (Qx_sent_selection_functions): New vars.
911 (syms_of_xselect): DEFSYM them.
912 (x_handle_selection_request): Pass Qx_sent_selection_functions
913 rather than Vx_sent_selection_functions to Frun_hook_with_args.
914 (x_handle_selection_clear,x_clear_frame_selections):
915 Pass Qx_lost_selection_functions rather than
916 Vx_lost_selection_functions to Frun_hook_with_args.
917
918 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
919
920 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
921 The old code sometimes used this field without initializing it.
922
923 * alloc.c (gc_sweep): Don't read past end of array.
924 In theory, the old code could also have corrupted Emacs internals,
925 though it'd be very unlikely.
926
927 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
928
929 * character.c (Fcharacterp): Don't advertise optional ignored
930 argument. (Bug#4026)
931
932 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
933
934 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
935 key" (bug#4257).
936
937 * window.c (Fset_window_start): Doc fix (bug#4199).
938 (Fset_window_hscroll): Ditto.
939
940 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
941
942 Fix minor new problems caught by GCC 4.6.1.
943 * term.c (init_tty): Remove unused local.
944 * xsettings.c (store_monospaced_changed): Define this function only
945 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
946 not used otherwise.
947
948 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
949
950 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
951
952 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
953
954 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
955 are the mini-buffer and the echo area (bug#3320).
956
957 * term.c (init_tty): Remove support for supdup, c10 and perq
958 terminals, which are no longer supported (bug#1482).
959
960 2011-07-10 Johan Bockgård <bojohan@gnu.org>
961
962 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
963
964 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
965
966 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
967 for non-popups (Bug#3642).
968
969 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
970
971 * alloc.c (reset_malloc_hooks): Protoize.
972 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
973 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
974 * cm.c (losecursor): Likewise.
975 * data.c (fmod): Likewise.
976 * dispnew.c (swap_glyphs_in_rows): Likewise.
977 * emacs.c (memory_warning_signal): Likewise.
978 * floatfns.c (float_error): Likewise.
979 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
980 (otf_open, font_otf_capability, generate_otf_features)
981 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
982 Likewise.
983 * image.c (pbm_read_file): Likewise.
984 * indent.c (string_display_width): Likewise.
985 * intervals.c (check_for_interval, search_for_interval)
986 (inc_interval_count, count_intervals, root_interval)
987 (adjust_intervals_for_insertion, make_new_interval): Likewise.
988 * lread.c (defalias): Likewise.
989 * ralloc.c (r_alloc_check): Likewise.
990 * regex.c (set_image_of_range_1, set_image_of_range)
991 (regex_grow_registers): Likewise.
992 * sysdep.c (strerror): Likewise.
993 * termcap.c (valid_filename_p, tprint, main): Likewise.
994 * tparam.c (main): Likewise.
995 * unexhp9k800.c (run_time_remap, save_data_space)
996 (update_file_ptrs, read_header, write_header, calculate_checksum)
997 (copy_file, copy_rest, display_header): Likewise.
998 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
999 Likewise.
1000 * xdisp.c (check_it): Likewise.
1001 * xfaces.c (register_color, unregister_color, unregister_colors):
1002 Likewise.
1003 * xfns.c (print_fontset_result): Likewise.
1004 * xrdb.c (member, fatal, main): Likewise.
1005
1006 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 Fix minor problems found by static checking (Bug#9031).
1009 * chartab.c (char_table_set_range, map_sub_char_table):
1010 Remove unused locals.
1011 (uniprop_table): Now static.
1012 * composite.c (_work_char): Remove unused static var.
1013
1014 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1015
1016 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1017
1018 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1019
1020 * gtkutil.c (qttip_cb): Remove code without function.
1021
1022 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1023
1024 * w32.c (pthread_sigmask): New stub.
1025
1026 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 Use pthread_sigmask, not sigprocmask (Bug#9010).
1029 sigprocmask is portable only for single-threaded applications, and
1030 Emacs can be multi-threaded when it uses GTK.
1031 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1032 (LIBES): Use it.
1033 * callproc.c (Fcall_process):
1034 * process.c (create_process):
1035 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1036 Use pthread_sigmask, not sigprocmask.
1037
1038 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1039
1040 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1041 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1042 wrong (Bug#8591).
1043
1044 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1045
1046 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1047 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1048 (xg_hide_tooltip): Fix comment.
1049
1050 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1051 in registerServicesMenuSendTypes.
1052 (validRequestorForSendType): Don't check ns_return_types.
1053
1054 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1055 ns_return_type.
1056
1057 2011-07-08 Jason Rumney <jasonr@gnu.org>
1058
1059 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1060 frame struct members of non-existent frames (Bug#6284).
1061
1062 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1063
1064 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1065 variable firstTime not needed on OSX >= 10.6.
1066 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1067 >= 10.5. Use setKnobProportion, setDoubleValue.
1068
1069 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1070 (MAC_OS_X_VERSION_10_5): Define if not defined.
1071 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1072 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1073 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1074
1075 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1076 cString and lossyCString on OSX >= 10.4
1077
1078 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1079 sizeToFit on OSX >= 10.2.
1080
1081 * nsimage.m (allocInitFromFile): Don't use deprecated method
1082 bestRepresentationForDevice on OSX >= 10.6.
1083
1084 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1085 to avoid warning.
1086
1087 * emacs.c: Declare unexec_init_emacs_zone.
1088
1089 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1090
1091 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1092
1093 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1094 on svcsMenu (Bug#8842).
1095
1096 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1097 ns_return_types.
1098 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1099
1100 * nsterm.m (QUTF8_STRING): Declare.
1101 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1102 (validRequestorForSendType): Return type is (id).
1103 Change indexOfObjectIdenticalTo to indexOfObject.
1104 Check if we have local selection before returning self (Bug#8842).
1105 (writeSelectionToPasteboard): Put local selection into paste board
1106 if we have a local selection (Bug#8842).
1107 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1108
1109 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1110 (ns_get_local_selection): Declare.
1111
1112 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1113
1114 * keymap.c (describe_map_tree): Don't insert a double newline at
1115 the end of the buffer (bug#1169) and return whether we inserted
1116 something.
1117
1118 * callint.c (Fcall_interactively): Change "reading args" to
1119 "providing args" to try to clarify what it does (bug#1010).
1120
1121 2011-07-07 Kenichi Handa <handa@m17n.org>
1122
1123 * composite.c (composition_compute_stop_pos): Ignore a static
1124 composition starting before CHARPOS (Bug#8915).
1125
1126 * xdisp.c (handle_composition_prop): Likewise.
1127
1128 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1129
1130 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1131 (Bug#9015)
1132
1133 2011-07-07 Kenichi Handa <handa@m17n.org>
1134
1135 * character.h (unicode_category_t): New enum type.
1136
1137 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1138 (Qchar_code_property_table): New variable.
1139 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1140 (UNIPROP_COMPRESSED_FORM_P): New macros.
1141 (char_table_ascii): Uncompress the compressed values.
1142 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1143 Uncompress the compressed values.
1144 (sub_char_table_ref_and_range): Likewise.
1145 (char_table_ref_and_range): Uncompress the compressed values.
1146 (sub_char_table_set): New arg is_uniprop. Callers changed.
1147 Uncompress the compressed values.
1148 (sub_char_table_set_range): Args changed. Callers changed.
1149 (char_table_set_range): Adjuted for the above change.
1150 (map_sub_char_table): Delete args default_val and parent. Add arg
1151 top. Give decoded values to a Lisp function.
1152 (map_char_table): Adjust for the above change. Give decoded
1153 values to a Lisp function. Gcpro more variables.
1154 (uniprop_table_uncompress)
1155 (uniprop_decode_value_run_length): New functions.
1156 (uniprop_decoder, uniprop_decoder_count): New variables.
1157 (uniprop_get_decoder, uniprop_encode_value_character)
1158 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1159 New functions.
1160 (uniprop_encoder, uniprop_encoder_count): New variables.
1161 (uniprop_get_encoder, uniprop_table)
1162 (Funicode_property_table_internal, Fget_unicode_property_internal)
1163 (Fput_unicode_property_internal): New functions.
1164 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1165 Sunicode_property_table_internal, Sget_unicode_property_internal,
1166 and Sput_unicode_property_internal. Defvar_lisp
1167 char-code-property-alist.
1168
1169 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1170 Vunicode_category_table.
1171
1172 * font.c (font_range): Adjust for the change of
1173 Vunicode_category_table.
1174
1175 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1176
1177 * m/iris4d.h: Remove file, move contents ...
1178 * s/irix6-5.h: ... here.
1179
1180 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 Remove unportable assumption about struct layout (Bug#8884).
1183 * alloc.c (mark_buffer):
1184 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1185 (clone_per_buffer_values): Don't assume that
1186 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1187 This isn't true in general, and it's particularly not true
1188 if Emacs is configured with --with-wide-int.
1189 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1190 New macros, used in the buffer.c change.
1191
1192 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1193
1194 * xsettings.c: Use both GConf and GSettings if both are available.
1195 (store_config_changed_event): Add comment.
1196 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1197 (store_tool_bar_style_changed): New functions.
1198 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1199 (struct xsettings): Move font inside HAVE_XFT.
1200 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1201 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1202 Move inside HAVE_XFT.
1203 (something_changed_gsettingsCB): Rename from something_changedCB.
1204 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1205 also.
1206 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1207 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1208 (something_changed_gconfCB): Rename from something_changedCB.
1209 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1210 (parse_settings): Move check for font inside HAVE_XFT.
1211 (read_settings, apply_xft_settings): Add comment.
1212 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1213 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1214 call store_font_name_changed.
1215 (xft_settings_event): Add comment.
1216 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1217 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1218 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1219 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1220 (xsettings_initialize): Call init_gsettings last.
1221 (xsettings_get_system_font, xsettings_get_system_normal_font):
1222 Add comment.
1223
1224 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Random fixes. E.g., (random) never returned negative values.
1227 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1228 subseconds part to the entropy, as that's a bit more random.
1229 Prefer signed to unsigned, since the signedness doesn't matter and
1230 in general we prefer signed. When given a limit, use a
1231 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1232 latter isn't right if USE_2_TAGS_FOR_INTS.
1233 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1234 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1235
1236 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1237
1238 * textprop.c (text_property_stickiness):
1239 Obey Vtext_property_default_nonsticky.
1240 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1241 * w32fns.c (syms_of_w32fns):
1242 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1243
1244 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1247 This is more efficient than Ffile_directory_p and avoids a minor race.
1248
1249 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1250
1251 * buffer.c (Foverlay_put): Say what the return value is
1252 (bug#7835).
1253
1254 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1255 is a directory before asking whether to use the file name
1256 (bug#7564).
1257 (barf_or_query_if_file_exists): Make the "File is a directory"
1258 error be more correct.
1259
1260 * fns.c (Frequire): Remove the mention of the .gz files, since
1261 that's installation-specific, but keep the mention of
1262 `get-load-suffixes'.
1263
1264 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1267 Report string overflow if the output is too long.
1268
1269 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1270
1271 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1272 (syms_of_gnutls): Remove duplicate DEFSYM for
1273 Qgnutls_bootprop_verify_hostname_error, an error for
1274 Qgnutls_bootprop_verify_error (which is no longer used).
1275
1276 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1277 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1278 Also (re)move comments that are misplaced or no longer relevant.
1279
1280 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1281
1282 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1283
1284 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1285
1286 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1287 and background color parameters if they have been changed.
1288
1289 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1290
1291 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1292
1293 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * xsettings.c (SYSTEM_FONT): Define only when used.
1296 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1297
1298 * keymap.c (access_keymap_1): Now static.
1299
1300 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1301
1302 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1303 leave any prefix arg for the up event (Bug#1586).
1304
1305 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1306
1307 * lread.c (syms_of_lread): Mention single symbols defined by
1308 `defvar' or `defconst' (bug#7154).
1309
1310 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1311 (Frequire): Mention get-load-suffixes.
1312
1313 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1314
1315 * window.h (window): Remove clone_number slot.
1316 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1317 Remove.
1318 (make_parent_window, make_window, saved_window)
1319 (Fset_window_configuration, save_window_save): Don't deal with
1320 clone numbers.
1321 * buffer.c (Qclone_number): Remove declaration.
1322 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1323
1324 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1325
1326 Add multiple inheritance to keymaps.
1327 * keymap.c (Fmake_composed_keymap): New function.
1328 (Fset_keymap_parent): Simplify.
1329 (fix_submap_inheritance): Remove.
1330 (access_keymap_1): New function extracted from access_keymap to handle
1331 embedded parents and handle lists of maps.
1332 (access_keymap): Use it.
1333 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1334 (Fcopy_keymap): Handle embedded parents.
1335 (Fcommand_remapping, define_as_prefix): Simplify.
1336 (Fkey_binding): Simplify.
1337 (syms_of_keymap): Move minibuffer-local-completion-map,
1338 minibuffer-local-filename-completion-map,
1339 minibuffer-local-must-match-map, and
1340 minibuffer-local-filename-must-match-map to Elisp.
1341 (syms_of_keymap): Defsubr make-composed-keymap.
1342 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1343 (parse_menu_item): Trivial simplification.
1344
1345 2011-07-01 Glenn Morris <rgm@gnu.org>
1346
1347 * Makefile.in (SETTINGS_LIBS): Fix typo.
1348
1349 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1350
1351 * coding.c (Fencode_coding_string): Record the last coding system
1352 used, as the function doc string says (bug#8738).
1353
1354 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1355
1356 * xsettings.c (store_monospaced_changed): Take new font as arg and
1357 check for change against current_mono_font.
1358 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1359 (emacs_settings_constructor, emacs_settings_get_property)
1360 (emacs_settings_set_property, emacs_settings_class_init)
1361 (emacs_settings_init, gsettings_obj): Remove.
1362 (something_changedCB): New function for HAVE_GSETTINGS.
1363 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1364 with value as argument.
1365 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1366 g_settings_new (Bug#8967). Do not create gsettings_obj.
1367 Remove calls to g_settings_bind. Connect something_changedCB to
1368 "changed".
1369
1370 * xgselect.c: Add defined (HAVE_GSETTINGS).
1371 (xgselect_initialize): Ditto.
1372
1373 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1374 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1375 xg_select.
1376
1377 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 * eval.c (struct backtrace): Simplify and port the data structure.
1380 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1381 signed bit field, as this assumption is not portable and it makes
1382 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1383 "char debug_on_exit : 1" as this is not portable either; instead,
1384 use the portable "unsigned int debug_on_exit : 1". Remove unused
1385 member evalargs. Remove obsolete comments about cc bombing out.
1386
1387 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1388
1389 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1390 Let HAVE_GSETTINGS override HAVE_GCONF.
1391 (store_monospaced_changed): New function.
1392 (EMACS_SETTINGS): A new type derived from GObject to handle
1393 GSettings notifications.
1394 (emacs_settings_constructor, emacs_settings_get_property)
1395 (emacs_settings_set_property, emacs_settings_class_init):
1396 New functions.
1397 (gsettings_client, gsettings_obj): New variables.
1398 (GSETTINGS_SCHEMA): New define.
1399 (something_changedCB): Call store_monospaced_changed.
1400 (init_gsettings): New function.
1401 (xsettings_initialize): Call init_gsettings.
1402 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1403 to NULL.
1404
1405 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1406 GCONF_CFLAGS/LIBS.
1407
1408 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1409
1410 * window.c (resize_root_window, grow_mini_window)
1411 (shrink_mini_window): Rename Qresize_root_window to
1412 Qwindow_resize_root_window and Qresize_root_window_vertically to
1413 Qwindow_resize_root_window_vertically.
1414
1415 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1418
1419 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1420
1421 * makefile.w32-in: Redesign dependencies so they reflect more
1422 clearly which files are directly included by each source file,
1423 and not through other includes.
1424
1425 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1426
1427 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1428 (sort_overlays, overlay_strings): When an overlay's clone number
1429 matches the window's clone number process the overlay even if
1430 the overlay's window property doesn't match the current window.
1431
1432 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1433 (Fwindow_hchild): Rename to Fwindow_left_child.
1434 (Fwindow_next): Rename to Fwindow_next_sibling.
1435 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1436 (resize_window_check): Rename to window_resize_check.
1437 (resize_window_apply): Rename to window_resize_apply.
1438 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1439 (Fdelete_other_windows_internal, resize_frame_windows)
1440 (Fsplit_window_internal, Fdelete_window_internal)
1441 (grow_mini_window, shrink_mini_window)
1442 (Fresize_mini_window_internal): Fix callers accordingly.
1443
1444 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1445
1446 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1447 (emacs_fixed_set_min_size): Remove.
1448 (emacs_fixed_new): Take frame as argument.
1449
1450 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1451 (_EmacsFixedPrivate): Remove minwidth/height.
1452 Add struct frame *f.
1453 (emacs_fixed_init): Initialize priv->f.
1454 (get_parent_class, emacs_fixed_set_min_size): Remove.
1455 (emacs_fixed_new): Set priv->f to argument.
1456 (emacs_fixed_get_preferred_width)
1457 (emacs_fixed_get_preferred_height): Use min_width/height from
1458 frames size_hint to set minimum and natural (Bug#8919).
1459 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1460 and use min_width/height from frames size_hint to set
1461 min_width/height (Bug#8919).
1462
1463 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1464 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1465 Fix indentation.
1466
1467 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1468
1469 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1470 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1471 called at ZV.
1472
1473 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1474
1475 * process.c (wait_reading_process_output): Bypass select if
1476 waiting for a cell while ignoring keyboard input, and input is
1477 pending. Suggested by Jan Djärv (Bug#8869).
1478
1479 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 Use gnulib's dup2 module instead of rolling our own.
1482 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1483
1484 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1485
1486 * dispnew.c (scrolling_window): Before scrolling, turn off a
1487 mouse-highlight in the window being scrolled.
1488
1489 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1490
1491 Move DEFSYM to lisp.h and use everywhere.
1492
1493 * character.h (DEFSYM): Move declaration...
1494 * lisp.h (DEFSYM): ...here.
1495
1496 * gnutls.c:
1497 * minibuf.c:
1498 * w32menu.c:
1499 * w32proc.c:
1500 * w32select.c: Don't include character.h.
1501
1502 * alloc.c (syms_of_alloc):
1503 * buffer.c (syms_of_buffer):
1504 * bytecode.c (syms_of_bytecode):
1505 * callint.c (syms_of_callint):
1506 * casefiddle.c (syms_of_casefiddle):
1507 * casetab.c (init_casetab_once):
1508 * category.c (init_category_once, syms_of_category):
1509 * ccl.c (syms_of_ccl):
1510 * cmds.c (syms_of_cmds):
1511 * composite.c (syms_of_composite):
1512 * dbusbind.c (syms_of_dbusbind):
1513 * dired.c (syms_of_dired):
1514 * dispnew.c (syms_of_display):
1515 * doc.c (syms_of_doc):
1516 * editfns.c (syms_of_editfns):
1517 * emacs.c (syms_of_emacs):
1518 * eval.c (syms_of_eval):
1519 * fileio.c (syms_of_fileio):
1520 * fns.c (syms_of_fns):
1521 * frame.c (syms_of_frame):
1522 * fringe.c (syms_of_fringe):
1523 * insdel.c (syms_of_insdel):
1524 * keymap.c (syms_of_keymap):
1525 * lread.c (init_obarray, syms_of_lread):
1526 * macros.c (syms_of_macros):
1527 * msdos.c (syms_of_msdos):
1528 * print.c (syms_of_print):
1529 * process.c (syms_of_process):
1530 * search.c (syms_of_search):
1531 * sound.c (syms_of_sound):
1532 * syntax.c (init_syntax_once, syms_of_syntax):
1533 * terminal.c (syms_of_terminal):
1534 * textprop.c (syms_of_textprop):
1535 * undo.c (syms_of_undo):
1536 * w32.c (globals_of_w32):
1537 * window.c (syms_of_window):
1538 * xdisp.c (syms_of_xdisp):
1539 * xfaces.c (syms_of_xfaces):
1540 * xfns.c (syms_of_xfns):
1541 * xmenu.c (syms_of_xmenu):
1542 * xsettings.c (syms_of_xsettings):
1543 * xterm.c (syms_of_xterm): Use DEFSYM.
1544
1545 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1546
1547 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1548
1549 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 Integer and buffer overflow fixes (Bug#8873).
1552
1553 * print.c (printchar, strout): Check for string overflow.
1554 (PRINTPREPARE, printchar, strout):
1555 Don't set size unless allocation succeeds.
1556
1557 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1558 for sizes. Check for string overflow more accurately.
1559 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1560
1561 * macros.c: Integer and buffer overflow fixes.
1562 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1563 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1564 Use ptrdiff_t, not int, for sizes.
1565 Don't increment bufsize until after realloc succeeds.
1566 Check for size-calculation overflow.
1567 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1568
1569 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1570
1571 * lread.c: Integer overflow fixes.
1572 (read_integer): Radix is now EMACS_INT, not int,
1573 to improve quality of diagnostics for out-of-range radices.
1574 Calculate buffer size correctly for out-of-range radices.
1575 (read1): Check for integer overflow in radices, and in
1576 read-circle numbers.
1577 (read_escape): Avoid int overflow.
1578 (Fload, openp, read_buffer_size, read1)
1579 (substitute_object_recurse, read_vector, read_list, map_obarray):
1580 Use ptrdiff_t, not int, for sizes.
1581 (read1): Use EMACS_INT, not int, for sizes.
1582 Check for size overflow.
1583
1584 * image.c (cache_image): Check for size arithmetic overflow.
1585
1586 * lread.c: Integer overflow issues.
1587 (saved_doc_string_size, saved_doc_string_length)
1588 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1589 Now ptrdiff_t, not int.
1590 (read1): Don't assume doc string length fits in int. Check for
1591 out-of-range doc string lengths.
1592 (read_list): Don't assume file position fits in int.
1593 (read_escape): Check for hex character overflow.
1594
1595 2011-06-22 Leo Liu <sdl.web@gmail.com>
1596
1597 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1598 Move to minibuffer.el.
1599
1600 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1603 The following patches are for when GLYPH_DEBUG && !XASSERT.
1604 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1605 * dispnew.c (flush_stdout):
1606 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1607 Mark as externally visible.
1608 * dispnew.c (check_window_matrix_pointers): Now static.
1609 * dispnew.c (window_to_frame_vpos):
1610 * xfns.c (unwind_create_frame):
1611 * xterm.c (x_check_font): Remove unused local.
1612 * scroll.c (CHECK_BOUNDS):
1613 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1614 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1615 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1616 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1617 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1618 Now static.
1619 (debug_method_add): Use va_list and vsprintf rather than relying
1620 on undefined behavior with wrong number of arguments.
1621 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1622 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1623 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1624 since we're not interested in debugging glyphs with old libraries.
1625 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1626 GCC 4.6.0's static checking.
1627
1628 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 Integer overflow and signedness fixes (Bug#8873).
1631 A few related buffer overrun fixes, too.
1632
1633 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1634
1635 * dispextern.h (struct face.stipple):
1636 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1637 (x_bitmap_mask, x_allocate_bitmap_record)
1638 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1639 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1640 (x_create_bitmap_from_xpm_data):
1641 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1642 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1643 (.bitmaps_last):
1644 * xfaces.c (load_pixmap):
1645 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1646 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1647 (.bitmaps_last, struct x_output.icon_bitmap):
1648 Use ptrdiff_t, not int, for bitmap indexes.
1649 (x_allocate_bitmap_record): Check for size overflow.
1650 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1651
1652 Use ptrdiff_t, not int, for overlay counts.
1653 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1654 * editfns.c (overlays_around, get_pos_property):
1655 * textprop.c (get_char_property_and_overlay):
1656 * xdisp.c (next_overlay_change, note_mouse_highlight):
1657 * xfaces.c (face_at_buffer_position):
1658 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1659 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1660 (Fnext_overlay_change, Fprevious_overlay_change)
1661 (mouse_face_overlay_overlaps, Foverlays_in):
1662 Use ptrdiff_t, not int, for sizes.
1663 (overlays_at, overlays_in): Check for size-calculation overflow.
1664
1665 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1666
1667 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1668 (x_session_initialize): Do not assume string length fits in int.
1669
1670 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1671 This is unlikely, but can occur if DPI is outlandish.
1672
1673 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1674 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1675
1676 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1677 * xrdb.c (magic_file_p, search_magic_path):
1678 Omit last arg SUFFIX; it was always 0. All callers changed.
1679 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1680
1681 * xfont.c (xfont_match): Avoid need for strlen.
1682
1683 * xfns.c: Don't assume strlen fits in int.
1684 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1685
1686 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1687 not unsigned long, as we prefer signed integers. All callers changed.
1688 Detect integer overflow in repeat count.
1689 (message_dolog): Don't assume print length fits in 39 bytes.
1690 (display_mode_element): Don't assume strlen fits in int.
1691
1692 * termcap.c: Don't assume sizes fit in int and never overflow.
1693 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1694 (gobble_line): Check for size-calculation overflow.
1695
1696 * minibuf.c (Fread_buffer):
1697 * lread.c (intern, intern_c_string):
1698 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1699 Don't assume string length fits in int.
1700
1701 * keyboard.c (parse_tool_bar_item):
1702 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1703
1704 * font.c: Don't assume string length fits in int.
1705 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1706 Use ptrdiff_t, not int.
1707 (font_intern_prop): Don't assume string length fits in int.
1708 Don't assume integer property fits in fixnum.
1709 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1710
1711 * filelock.c: Fix some buffer overrun and integer overflow issues.
1712 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1713 Reformulate so as not to need the command string.
1714 Invoke gzip -cd rather than gunzip, as it's more portable.
1715 (lock_info_type, lock_file_1, lock_file):
1716 Don't assume pid_t and time_t fit in unsigned long.
1717 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1718 (current_lock_owner): Prefer signed type for sizes.
1719 Use memcpy, not strncpy, where memcpy is what is really wanted.
1720 Don't assume (via atoi) that time_t and pid_t fit in int.
1721 Check for time_t and/or pid_t out of range, e.g., via a network share.
1722 Don't alloca where an auto var works fine.
1723
1724 * fileio.c: Fix some integer overflow issues.
1725 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1726 Don't assume string length fits in int.
1727 (directory_file_name): Don't assume string length fits in long.
1728 (make_temp_name): Don't assume pid fits in int, or that its print
1729 length is less than 20.
1730
1731 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1732
1733 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1734
1735 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1736
1737 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1738 We prefer signed integers, even for size calculations.
1739
1740 * emacs.c: Don't assume string length fits in 'int'.
1741 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1742 (main): Don't invoke strlen when not needed.
1743
1744 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1745 (XD_DEBUG_MESSAGE): Don't waste a byte.
1746
1747 * callproc.c (getenv_internal_1, getenv_internal)
1748 (Fgetenv_internal):
1749 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1750
1751 * lread.c (invalid_syntax): Omit length argument.
1752 All uses changed. This doesn't fix a bug, but it simplifies the
1753 code away from its former Hollerith-constant appearance, and it's
1754 one less 'int' to worry about when looking at integer-overflow issues.
1755 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1756
1757 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1758 This didn't break anything, but it didn't help either.
1759 It's confusing to put a bogus integer in a place where the actual
1760 value does not matter.
1761 (LIST_END_P): Remove unused macro and its bogus comment.
1762 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1763
1764 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1765 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1766 implementation.
1767 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1768 We prefer signed types, and the value cannot exceed the EMACS_INT
1769 range anyway (because otherwise the length would not be representable).
1770 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1771 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1772 This avoids a GCC warning when WIDE_EMACS_INT.
1773
1774 * indent.c (sane_tab_width): New function.
1775 (current_column, scan_for_column, Findent_to, position_indentation)
1776 (compute_motion): Use it. This is just for clarity.
1777 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1778
1779 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1780
1781 * lisp.h (lint_assume): New macro.
1782 * composite.c (composition_gstring_put_cache):
1783 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1784
1785 * editfns.c, insdel.c:
1786 Omit unnecessary forward decls, to simplify future changes.
1787
1788 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1789
1790 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1791
1792 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1793 Use much-faster test for byte-length change.
1794 Don't assume string byte-length fits in 'int'.
1795 Check that character arg fits in 'int'.
1796 (mapcar1): Declare byte as byte, for clarity.
1797
1798 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1799
1800 * fns.c (concat): Catch string overflow earlier.
1801 Do not rely on integer wraparound.
1802
1803 * dispextern.h (struct it.overlay_strings_charpos)
1804 (struct it.selective): Now EMACS_INT, not int.
1805 * xdisp.c (forward_to_next_line_start)
1806 (back_to_previous_visible_line_start)
1807 (reseat_at_next_visible_line_start, next_element_from_buffer):
1808 Don't arbitrarily truncate the value of 'selective' to int.
1809
1810 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1811
1812 * composite.c: Don't truncate sizes to 'int'.
1813 (composition_gstring_p, composition_reseat_it)
1814 (composition_adjust_point): Use EMACS_INT, not int.
1815 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1816 not EMACS_UINT, for indexes.
1817
1818 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1819
1820 * buffer.c: Include <verify.h>.
1821 (struct sortvec.priority, struct sortstr.priority):
1822 Now EMACS_INT, not int.
1823 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1824 (struct sortstr.size, record_overlay_string)
1825 (struct sortstrlist.size, struct sortlist.used):
1826 Don't truncate size to int.
1827 (record_overlay_string): Check for size-calculation overflow.
1828 (init_buffer_once): Check at compile-time, not run-time.
1829
1830 2011-06-22 Jim Meyering <meyering@redhat.com>
1831
1832 Don't leak an XBM-image-sized buffer
1833 * image.c (xbm_load): Free the image buffer after using it.
1834
1835 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 Port to Sun C.
1838 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1839 that Sun C diagnosed.
1840 * fns.c (secure_hash): Fix pointer signedness issue.
1841 * intervals.c (static_offset_intervals): New function.
1842 (offset_intervals): Use it.
1843
1844 2011-06-21 Leo Liu <sdl.web@gmail.com>
1845
1846 * deps.mk (fns.o):
1847 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1848 sha512.h.
1849
1850 * fns.c (secure_hash): Rename from crypto_hash_function and change
1851 the first arg to accept symbols.
1852 (Fsecure_hash): New primitive.
1853 (syms_of_fns): New symbols.
1854
1855 2011-06-20 Deniz Dogan <deniz@dogan.se>
1856
1857 * process.c (Fset_process_buffer): Clarify return value in
1858 docstring.
1859
1860 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1861
1862 * dispnew.c (add_window_display_history): Use BVAR.
1863
1864 * xdisp.c (debug_method_add): Use BVAR.
1865 (check_window_end, dump_glyph_matrix, dump_glyph)
1866 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1867
1868 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1869 Likewise.
1870
1871 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1872 check till after the cache is created in init_frame_faces.
1873
1874 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1875
1876 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1877
1878 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1881 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1882 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1883
1884 Improve buffer-overflow checking (Bug#8873).
1885 * fileio.c (Finsert_file_contents):
1886 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1887 Remove the old (too-loose) buffer overflow checks.
1888 They weren't needed, since make_gap checks for buffer overflow.
1889 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1890 The old code merely checked for Emacs fixnum overflow, and relied
1891 on undefined (wraparound) behavior. The new code avoids undefined
1892 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1893
1894 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1895 Tune. Don't use wider integers than needed. Don't use alloca.
1896 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1897
1898 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1899
1900 * insdel.c, lisp.h (buffer_overflow): New function.
1901 (insert_from_buffer_1, replace_range, replace_range_2):
1902 * insdel.c (make_gap_larger):
1903 * editfns.c (Finsert_char):
1904 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1905
1906 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1907
1908 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 Integer overflow and signedness fixes (Bug#8873).
1911
1912 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1913 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1914
1915 * fileio.c: Don't assume EMACS_INT fits in off_t.
1916 (emacs_lseek): New static function.
1917 (Finsert_file_contents, Fwrite_region): Use it.
1918 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1919
1920 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1921
1922 * fns.c: Don't overflow int when computing a list length.
1923 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1924 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1925 truncation on 64-bit hosts. Check for QUIT every
1926 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1927 faster and is responsive enough.
1928 (Flength): Report an error instead of overflowing an integer.
1929 (Fsafe_length): Return a float if the value is not representable
1930 as a fixnum. This shouldn't happen except in contrived situations.
1931 (Fnthcdr, Fsort): Don't assume list length fits in int.
1932 (Fcopy_sequence): Don't assume vector length fits in int.
1933
1934 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1935 (header_size, word_size): New constants.
1936 (allocate_vectorlike): Don't check size overflow here.
1937 (allocate_vector): Check it here instead, since this is the only
1938 caller of allocate_vectorlike that could cause overflow.
1939 Check that the new vector's length is representable as a fixnum.
1940
1941 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1942 The previous code was bogus. For example, next_almost_prime (32)
1943 returned 39, which is undesirable as it is a multiple of 3; and
1944 next_almost_prime (24) returned 25, which is a multiple of 5 so
1945 why was the code bothering to check for multiples of 7?
1946
1947 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1948
1949 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1950
1951 Variadic C functions now count arguments with ptrdiff_t.
1952 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1953 Back then I didn't know that the Emacs coding style prefers signed int.
1954 Also, in the meantime I found a few more instances where arguments
1955 were being counted with int, which may truncate counts on 64-bit
1956 machines, or EMACS_INT, which may be unnecessarily wide.
1957 * lisp.h (struct Lisp_Subr.function.aMANY)
1958 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1959 Arg counts are now ptrdiff_t, not size_t.
1960 All variadic functions and their callers changed accordingly.
1961 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1962 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1963 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1964 * callint.c (Fcall_interactively): Check arg count for overflow,
1965 to avoid potential buffer overrun. Use signed char, not 'int',
1966 for 'varies' array, so that we needn't bother to check its size
1967 calculation for overflow.
1968 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1969 * eval.c (apply_lambda):
1970 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1971 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1972 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1973
1974 * callint.c (Fcall_interactively): Don't use index var as event count.
1975
1976 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1977 * mem-limits.h (SIZE): Remove; no longer used.
1978
1979 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1980
1981 Remove unnecessary casts.
1982 * xterm.c (x_term_init):
1983 * xfns.c (x_set_border_pixel):
1984 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1985 These aren't needed now that we assume ANSI C.
1986
1987 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1988 It's more likely to cause problems (due to unsigned overflow)
1989 than to cure them.
1990
1991 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1992
1993 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1994
1995 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1996
1997 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1998
1999 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2000
2001 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2002
2003 GLYPH_CODE_FACE returns EMACS_INT, not int.
2004 * dispextern.h (merge_faces):
2005 * xfaces.c (merge_faces):
2006 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2007 Don't assume EMACS_INT fits in int.
2008
2009 * character.h (CHAR_VALID_P): Remove unused parameter.
2010 * fontset.c, lisp.h, xdisp.c: All uses changed.
2011
2012 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2013
2014 * fns.c (concat): Minor tuning based on overflow analysis.
2015 This doesn't fix any bugs. Use int to hold character, instead
2016 of constantly refetching from Emacs object. Use XFASTINT, not
2017 XINT, for value known to be a character. Don't bother comparing
2018 a single byte to 0400, as it's always less.
2019
2020 * floatfns.c (Fexpt):
2021 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2022
2023 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2024 for characters.
2025
2026 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2027
2028 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2029 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2030 incorrectly succeed when S was a string, because 4294967386 was
2031 truncated before it was used.
2032
2033 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2034 Otherwise, an out-of-range integer could cause undefined behavior
2035 on a 64-bit host.
2036
2037 * composite.c: Use int, not EMACS_INT, for characters.
2038 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2039 EMACS_INT, for values that are known to be in character range.
2040 This doesn't fix any bugs but is the usual style inside Emacs and
2041 may generate better code on 32-bit machines.
2042
2043 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2044 This is for reasons similar to the recent CHAR_STRING fix.
2045 * charset.c (Fencode_char): Check that character arg is actually
2046 a character. Pass an int to ENCODE_CHAR.
2047 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2048 wider than 'int', as a compile-time check to prevent future regressions
2049 in this area.
2050
2051 * character.c (char_string): Remove unnecessary casts.
2052
2053 Make sure a 64-bit char is never passed to CHAR_STRING.
2054 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2055 by silently ignoring the top 32 bits, allowing some values
2056 that were far too large to be valid characters.
2057 * character.h: Include <verify.h>.
2058 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2059 arguments are no wider than unsigned, as a compile-time check
2060 to prevent future regressions in this area.
2061 * data.c (Faset):
2062 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2063 (Fsubst_char_in_region):
2064 * fns.c (concat):
2065 * xdisp.c (decode_mode_spec_coding):
2066 Adjust to CHAR_STRING's new requirement.
2067 * editfns.c (Finsert_char, Fsubst_char_in_region):
2068 * fns.c (concat): Check that character args are actually
2069 characters. Without this test, these functions did the wrong
2070 thing with wildly out-of-range values on 64-bit hosts.
2071
2072 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2073 These casts should not be needed on 32-bit hosts, either.
2074 * keyboard.c (read_char):
2075 * lread.c (Fload): Remove casts to unsigned.
2076
2077 * lisp.h (UNSIGNED_CMP): New macro.
2078 This fixes comparison bugs on 64-bit hosts.
2079 (ASCII_CHAR_P): Use it.
2080 * casefiddle.c (casify_object):
2081 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2082 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2083 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2084 * dispextern.h (FACE_FROM_ID):
2085 * keyboard.c (read_char): Use UNSIGNED_CMP.
2086
2087 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2088 not to EMACS_INT, to avoid GCC warning.
2089
2090 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2091
2092 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2093 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2094 isn't needed on 32-bit machines.
2095
2096 * buffer.c (Fgenerate_new_buffer_name):
2097 Use EMACS_INT for count, not int.
2098 (advance_to_char_boundary): Return EMACS_INT, not int.
2099
2100 * data.c (Qcompiled_function): Now static.
2101
2102 * window.c (window_body_lines): Now static.
2103
2104 * image.c (gif_load): Rename local to avoid shadowing.
2105
2106 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2107 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2108 * alloc.c (make_save_value): Integer argument is now of type
2109 ptrdiff_t, not int.
2110 (mark_object): Use ptrdiff_t, not int.
2111 * lisp.h (pD): New macro.
2112 * print.c (print_object): Use it.
2113
2114 * alloc.c: Use EMACS_INT, not int, to count objects.
2115 (total_conses, total_markers, total_symbols, total_vector_size)
2116 (total_free_conses, total_free_markers, total_free_symbols)
2117 (total_free_floats, total_floats, total_free_intervals)
2118 (total_intervals, total_strings, total_free_strings):
2119 Now EMACS_INT, not int. All uses changed.
2120 (Fgarbage_collect): Compute overall total using a double, so that
2121 integer overflow is less likely to be a problem. Check for overflow
2122 when converting back to an integer.
2123 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2124 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2125 These were 'int' variables that could overflow on 64-bit hosts;
2126 they were never used, so remove them instead of repairing them.
2127 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2128 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2129 Previously, this ceilinged at INT_MAX, but that doesn't work on
2130 64-bit machines.
2131 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2132
2133 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2134 (allocate_vectorlike): Check for ptrdiff_t overflow.
2135 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2136 when a (possibly-narrower) signed value would do just as well.
2137 We prefer using signed arithmetic, to avoid comparison confusion.
2138
2139 * alloc.c: Catch some string size overflows that we were missing.
2140 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2141 for convenience in STRING_BYTES_MAX.
2142 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2143 The definition here is exact; the one in lisp.h was approximate.
2144 (allocate_string_data): Check for string overflow. This catches
2145 some instances we weren't catching before. Also, it catches
2146 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2147 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2148 and ptrdiff_t and EMACS_INT are both 64 bits.
2149
2150 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2151 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2152 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2153
2154 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2155
2156 * alloc.c (Fmake_string): Check for out-of-range init.
2157
2158 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2159
2160 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2161
2162 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2163
2164 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2165 xg_get_default_scrollbar_width.
2166
2167 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2168 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2169 (style_changed_cb): Call update_theme_scrollbar_width and call
2170 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2171 all frames (Bug#8505).
2172 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2173 Call gtk_window_set_resizable if HAVE_GTK3.
2174 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2175 and height if HAVE_GTK3 (Bug#8505).
2176 (scroll_bar_width_for_theme): New variable.
2177 (update_theme_scrollbar_width): New function.
2178 (xg_get_default_scrollbar_width): Move code to
2179 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2180 (xg_initialize): Call update_theme_scrollbar_width.
2181
2182 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2183
2184 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2185
2186 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2187
2188 * frame.c (make_frame): Call other_buffer_safely instead of
2189 other_buffer.
2190
2191 * window.c (temp_output_buffer_show): Call display_buffer with
2192 second argument Vtemp_buffer_show_specifiers and reset latter
2193 immediately after the call.
2194 (Vtemp_buffer_show_specifiers): New variable.
2195 (auto_window_vscroll_p, next_screen_context_lines)
2196 (Vscroll_preserve_screen_position): Remove leading asterisks from
2197 doc-strings.
2198
2199 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 Fix minor problems found by GCC 4.6.0 static checking.
2202 * buffer.c (Qclone_number): Remove for now, as it's unused.
2203 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2204 (record_buffer): Remove unused local.
2205 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2206 (set_frame_buffer_list): Remove; unused.
2207 * frame.h (other_visible_frames): Remove decl.
2208 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2209 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2210 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2211 if HAVE_GPM.
2212 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2213 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2214 Define only if HAVE_GPM.
2215 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2216 (update_hints_inhibit): Remove; never set. All uses removed.
2217 * widgetprv.h (emacsFrameClassRec): Remove decl.
2218 * window.c (delete_deletable_window): Now returns void, since it
2219 wasn't returning anything.
2220 (compare_window_configurations): Remove unused locals.
2221 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2222 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2223 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2224 the same widths as pointers. This follows up on the 2011-05-06 patch.
2225 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2226 * xterm.h: Likewise.
2227 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2228
2229 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2230
2231 * makefile.w32-in: Update dependencies.
2232 (LISP_H): Add lib/intprops.h.
2233
2234 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2235
2236 * image.c (gif_load): Add animation frame delay to the metadata.
2237 (syms_of_image): Use DEFSYM. New symbol `delay'.
2238
2239 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2240
2241 * window.c (delete_deletable_window): Re-add.
2242 (Fset_window_configuration): Rewrite to handle dead buffers and
2243 consequently deletable windows.
2244 (window_tree, Fwindow_tree): Remove. Supply functionality in
2245 window.el.
2246 (compare_window_configurations): Simplify code.
2247
2248 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * image.c (imagemagick_load_image): Fix type mismatch.
2251 (Fimagemagick_types): Likewise.
2252
2253 * window.h (replace_buffer_in_windows): Declare.
2254
2255 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2256
2257 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2258 Qclone_number. Remove external declaration of Qdelete_window.
2259 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2260 code.
2261 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2262 Run Qbuffer_list_update_hook if allowed.
2263 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2264 buffer list implementation.
2265 (other_buffer_safely): New function.
2266 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2267 calls to replace_buffer_in_windows and
2268 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2269 if allowed.
2270 (record_buffer): Inhibit quitting and rewrite using quittable
2271 functions. Run Qbuffer_list_update_hook if allowed.
2272 (Frecord_buffer, Funrecord_buffer): New functions.
2273 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2274 Move switch-to-buffer to window.el.
2275 (bury-buffer): Move to window.el.
2276 (Vbuffer_list_update_hook): New variable.
2277
2278 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2279 section.
2280
2281 * window.h (resize_frame_windows): Move up in code.
2282 (Fwindow_frame): Remove EXFUN.
2283 (replace_buffer_in_all_windows): Remove prototype.
2284 (replace_buffer_in_windows_safely): Add prototype.
2285
2286 * window.c: Declare Qdelete_window static again. Move down
2287 declaration of select_count.
2288 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2289 (Fother_window): Move to window.el.
2290 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2291 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2292 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2293 window.el.
2294 (replace_buffer_in_windows): Implement by calling
2295 Qreplace_buffer_in_windows.
2296 (replace_buffer_in_all_windows): Remove with some functionality
2297 moved into replace_buffer_in_windows_safely.
2298 (replace_buffer_in_windows_safely): New function.
2299 (select_window_norecord, select_frame_norecord): Move in front
2300 of run_window_configuration_change_hook. Remove now obsolete
2301 declarations.
2302 (Fset_window_buffer): Rewrite doc-string.
2303 Call Qrecord_window_buffer.
2304 (keys_of_window): Move binding for other-window to window.el.
2305
2306 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2307
2308 * dispextern.h (struct image): Replace data member, whose int_val
2309 and ptr_val fields were not used by anything, with a single
2310 lisp_val object.
2311
2312 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2313 (gif_clear_image, gif_load, imagemagick_load_image)
2314 (gs_clear_image, gs_load): Callers changed.
2315
2316 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 * buffer.h: Include <time.h>, for time_t.
2319 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2320
2321 Fix minor problems found by static checking.
2322
2323 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2324
2325 Make identifiers static if they are not used in other modules.
2326 * data.c (Qcompiled_function, Qframe, Qvector):
2327 * image.c (QimageMagick, Qsvg):
2328 * minibuf.c (Qmetadata):
2329 * window.c (resize_window_check, resize_root_window): Now static.
2330 * window.h (resize_window_check, resize_root_window): Remove decls.
2331
2332 * window.c (window_deletion_count, delete_deletable_window):
2333 Remove; unused.
2334 (window_body_lines): Now static.
2335 (Fdelete_other_windows_internal): Mark vars as initialized.
2336 Make sure 'resize_failed' is initialized.
2337 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2338 (resize_window_apply): Remove unused local.
2339 * window.h (delete_deletable_window): Remove decl.
2340
2341 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2342 (imagemagick_load_image): Fix pointer signedness problem by changing
2343 last arg from unsigned char * to char *. All uses changed.
2344 Also, fix a local for similar reasons.
2345 Remove unused locals. Remove locals to avoid shadowing.
2346 (fn_rsvg_handle_free): Remove; unused.
2347 (svg_load, svg_load_image): Fix pointer signedness problem.
2348 (imagemagick_load_image): Don't use garbage pointer image_wand.
2349
2350 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2351
2352 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2353
2354 * image.c (gif_load): Fix omitted cast error introduced by
2355 2011-06-06 change.
2356
2357 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2358
2359 * window.h (resize_proportionally, orig_total_lines)
2360 (orig_top_line): Remove from window structure.
2361 (set_window_height, set_window_width, change_window_heights)
2362 (Fdelete_window): Remove prototypes.
2363 (resize_frame_windows): Remove duplicate declaration.
2364
2365 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2366
2367 * window.h (resize_frame_windows, resize_window_check)
2368 (delete_deletable_window, resize_root_window)
2369 (resize_frame_windows): Declare prototypes.
2370
2371 * window.c (resize_window_apply): Make definition be "static" to
2372 match the prototype.
2373
2374 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2375
2376 * window.c: Remove declarations of Qwindow_size_fixed,
2377 window_min_size_1, window_min_size_2, window_min_size,
2378 size_window, window_fixed_size_p, enlarge_window, delete_window.
2379 Remove static from declaration of Qdelete_window, it's
2380 temporarily needed by Fbury_buffer.
2381 (replace_window): Don't assign orig_top_line and
2382 orig_total_lines.
2383 (Fdelete_window, delete_window): Remove. Window deletion is
2384 handled by window.el.
2385 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2386 Replace Fdelete_window calls with calls to Qdelete_window.
2387 (Fdelete_other_windows): Remove. Deleting other windows is
2388 handled by window.el.
2389 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2390 handled in window.el.
2391 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2392 Window minimum sizes are handled in window.el.
2393 (shrink_windows, size_window, set_window_height)
2394 (set_window_width, change_window_heights, window_height)
2395 (window_width, CURBEG, CURSIZE, enlarge_window)
2396 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2397 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2398 handled in window.el.
2399 (make_dummy_parent): Rename to make_parent_window and give it a
2400 second argument horflag.
2401 (make_window): Don't set resize_proportionally any more.
2402 (Fsplit_window): Remove. Windows are split in window.el.
2403 (save_restore_action, save_restore_orig_size)
2404 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2405 Resize mini windows in window.el.
2406 (grow_mini_window, shrink_mini_window): Implement by calling
2407 Qresize_root_window_vertically, resize_window_check and
2408 resize_window_apply.
2409 (saved_window, Fset_window_configuration, save_window_save):
2410 Do not handle orig_top_line, orig_total_lines, and
2411 resize_proportionally.
2412 (window_min_height, window_min_width): Move to window.el.
2413 (keys_of_window): Move bindings for delete-other-windows,
2414 split-window, delete-window and enlarge-window to window.el.
2415
2416 * buffer.c: Temporarily extern Qdelete_window.
2417 (Fbury_buffer): Temporarily call Qdelete_window instead of
2418 Fdelete_window (Fbury_buffer will move to window.el soon).
2419
2420 * frame.c (set_menu_bar_lines_1): Remove code handling
2421 orig_top_line and orig_total_lines.
2422
2423 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2424 set_window_height but set heights directly.
2425 (change_frame_size_1): Use resize_frame_windows.
2426
2427 * xdisp.c (init_xdisp): Don't use set_window_height but set
2428 heights directly.
2429
2430 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2431 Use resize_frame_windows instead of change_window_heights and run
2432 run_window_configuration_change_hook.
2433
2434 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2435 instead of change_window_heights and run
2436 run_window_configuration_change_hook.
2437
2438 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2439
2440 * window.c (replace_window): Rename second argument REPLACEMENT to
2441 NEW. New third argument SETFLAG. Rewrite.
2442 (delete_window, make_dummy_parent): Call replace_window with
2443 third argument 1.
2444 (window_list_1): Move down in code.
2445 (run_window_configuration_change_hook): Move set_buffer part
2446 before select_frame_norecord part in order to unwind correctly.
2447 Rename count1 to count.
2448 (recombine_windows, delete_deletable_window, resize_root_window)
2449 (Fdelete_other_windows_internal)
2450 (Frun_window_configuration_change_hook, make_parent_window)
2451 (resize_window_check, resize_window_apply, Fresize_window_apply)
2452 (resize_frame_windows, Fsplit_window_internal)
2453 (Fdelete_window_internal, Fresize_mini_window_internal):
2454 New functions.
2455 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2456
2457 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2458
2459 * window.h (window): Add some new members to window structure -
2460 normal_lines, normal_cols, new_total, new_normal, clone_number,
2461 splits, nest, prev_buffers, next_buffers.
2462 (WINDOW_TOTAL_SIZE): Move here from window.c.
2463 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2464
2465 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2466 Remove.
2467 (make_dummy_parent): Set new members of windows structure.
2468 (make_window): Move down in code. Handle new members of window
2469 structure.
2470 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2471 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2472 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2473 (Fset_window_prev_buffers, Fwindow_next_buffers)
2474 (Fset_window_next_buffers, Fset_window_clone_number):
2475 New functions.
2476 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2477 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2478 Doc-string fixes.
2479 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2480 Argument WINDOW can be now internal window too.
2481 (Fwindow_use_time): Move up in code.
2482 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2483 Rewrite doc-string.
2484 (Fset_window_configuration, saved_window)
2485 (Fcurrent_window_configuration, save_window_save): Handle new
2486 members of window structure.
2487 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2488 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2489 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2490 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2491 Qget_mru_window, Qresize_root_window,
2492 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2493 Qauto_buffer_name; staticpro them.
2494
2495 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2496
2497 * window.c (Fwindow_total_size, Fwindow_left_column)
2498 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2499 (Fwindow_list_1): New functions.
2500 (window_box_text_cols): Replace with window_body_cols.
2501 (Fwindow_width, Fscroll_left, Fscroll_right):
2502 Use window_body_cols instead of window_box_text_cols.
2503 (delete_window, Fset_window_configuration):
2504 Call delete_all_subwindows with window as argument.
2505 (delete_all_subwindows): Take a window as argument and not a
2506 structure. Rewrite.
2507 (window_loop): Remove handling of GET_LRU_WINDOW and
2508 GET_LARGEST_WINDOW.
2509 (Fget_lru_window, Fget_largest_window): Move to window.el.
2510
2511 * window.h: Extern window_body_cols instead of
2512 window_box_text_cols. delete_all_subwindows now takes a
2513 Lisp_Object as argument.
2514
2515 * indent.c (compute_motion, Fcompute_motion):
2516 Use window_body_cols instead of window_box_text_cols.
2517
2518 * frame.c (delete_frame): Call delete_all_subwindows with root
2519 window as argument.
2520
2521 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2522
2523 * fns.c (Fputhash): Document return value.
2524
2525 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2526
2527 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2528
2529 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 Cons<->int and similar integer overflow fixes (Bug#8794).
2532
2533 Check for overflow when converting integer to cons and back.
2534 * charset.c (Fdefine_charset_internal, Fdecode_char):
2535 Use cons_to_unsigned to catch overflow.
2536 (Fencode_char): Use INTEGER_TO_CONS.
2537 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2538 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2539 * data.c (long_to_cons, cons_to_long): Remove.
2540 (cons_to_unsigned, cons_to_signed): New functions.
2541 These signal an error for invalid or out-of-range values.
2542 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2543 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2544 * font.c (Ffont_variation_glyphs):
2545 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2546 * lisp.h: Include <intprops.h>.
2547 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2548 (cons_to_signed, cons_to_unsigned): New decls.
2549 (long_to_cons, cons_to_long): Remove decls.
2550 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2551 (Fprimitive_undo): Use CONS_TO_INTEGER.
2552 * xfns.c (Fx_window_property): Likewise.
2553 * xselect.c: Include <limits.h>.
2554 (x_own_selection, selection_data_to_lisp_data):
2555 Use INTEGER_TO_CONS.
2556 (x_handle_selection_request, x_handle_selection_clear)
2557 (x_get_foreign_selection, Fx_disown_selection_internal)
2558 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2559 (lisp_data_to_selection_data): Use cons_to_unsigned.
2560 (x_fill_property_data): Use cons_to_signed.
2561 Report values out of range.
2562
2563 Check for buffer and string overflow more precisely.
2564 * buffer.h (BUF_BYTES_MAX): New macro.
2565 * lisp.h (STRING_BYTES_MAX): New macro.
2566 * alloc.c (Fmake_string):
2567 * character.c (string_escape_byte8):
2568 * coding.c (coding_alloc_by_realloc):
2569 * doprnt.c (doprnt):
2570 * editfns.c (Fformat):
2571 * eval.c (verror):
2572 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2573 since they may not be the same number.
2574 * editfns.c (Finsert_char):
2575 * fileio.c (Finsert_file_contents):
2576 Likewise for BUF_BYTES_MAX.
2577
2578 * image.c: Use ptrdiff_t, not int, for sizes.
2579 (slurp_file): Switch from int to ptrdiff_t.
2580 All uses changed.
2581 (slurp_file): Check that file size fits in both size_t (for
2582 malloc) and ptrdiff_t (for sanity and safety).
2583
2584 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2585 if b->modtime has its maximal value.
2586
2587 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2588
2589 Don't assume time_t can fit into int.
2590 * buffer.h (struct buffer.modtime): Now time_t, not int.
2591 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2592 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2593
2594 Minor fixes for signed vs unsigned integers.
2595 * character.h (MAYBE_UNIFY_CHAR):
2596 * charset.c (maybe_unify_char):
2597 * keyboard.c (read_char, reorder_modifiers):
2598 XINT -> XFASTINT, since the integer must be nonnegative.
2599 * ftfont.c (ftfont_spec_pattern):
2600 * keymap.c (access_keymap, silly_event_symbol_error):
2601 XUINT -> XFASTINT, since the integer must be nonnegative.
2602 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2603 since it makes no difference and we prefer signed.
2604 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2605 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2606 nonnegative.
2607
2608 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2609
2610 * window.h (Fwindow_frame): Declare.
2611
2612 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2615 (SPARE_MEMORY): Always define.
2616 (LARGE_REQUEST): Remove.
2617 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2618
2619 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2620
2621 * lisp.h: Move EXFUNS for Fframe_root_window,
2622 Fframe_first_window and Fset_frame_selected_window to window.h.
2623
2624 * window.h: Move EXFUNS for Fframe_root_window,
2625 Fframe_first_window and Fset_frame_selected_window here from
2626 lisp.h.
2627
2628 * frame.c (Fwindow_frame, Fframe_first_window)
2629 (Fframe_root_window, Fframe_selected_window)
2630 (Fset_frame_selected_window): Move to window.c.
2631 (Factive_minibuffer_window): Move to minibuf.c.
2632 (Fother_visible_frames_p): New function.
2633
2634 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2635
2636 * window.c (decode_window, decode_any_window): Move up in code.
2637 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2638 (inhibit_frame_unsplittable): Remove unused variable.
2639 (Fwindow_buffer): Move up and rewrite doc-string.
2640 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2641 (Fwindow_prev): New functions.
2642 (Fwindow_frame): Move here from frame.c. Accept any window as
2643 argument.
2644 (Fframe_root_window, Fframe_first_window)
2645 (Fframe_selected_window): Move here from frame.c. Accept frame
2646 or arbitrary window as argument. Update doc-strings.
2647 (Fminibuffer_window): Move up in code.
2648 (Fwindow_minibuffer_p): Move up in code and simplify.
2649 (Fset_frame_selected_window): Move here from frame.c.
2650 Marginal rewrite.
2651 (Fselected_window, select_window, Fselect_window): Move up in
2652 code. Minor doc-string fixes.
2653
2654 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2657 Do not assume that spare memory exists; that assumption is valid
2658 only if SYSTEM_MALLOC.
2659 (LARGE_REQUEST): New macro, so that the issue of large requests
2660 is separated from the issue of spare memory.
2661
2662 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2663
2664 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2665 format. (Bug#8806)
2666
2667 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2668
2669 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2670 before statements.
2671
2672 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2673
2674 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2675
2676 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2677
2678 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2679 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2680
2681 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2682
2683 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2684
2685 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2686
2687 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2688 (x_clipboard_manager_save): Add return value.
2689 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2690 New error handlers.
2691 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2692 Obey Vx_select_enable_clipboard_manager. Catch errors in
2693 x_clipboard_manager_save (Bug#8779).
2694 (Vx_select_enable_clipboard_manager): New variable.
2695 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2696
2697 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2698
2699 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2700
2701 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2702
2703 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2704 in the current matrix if keep_current_p is non-zero.
2705
2706 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2707
2708 * bidi.c (bidi_level_of_next_char): Fix last change.
2709
2710 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2711
2712 Support bidi reordering of text covered by display properties.
2713
2714 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2715 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2716 (bidi_cache_search, bidi_cache_iterator_state)
2717 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2718 (bidi_level_of_next_char, bidi_move_to_visually_next):
2719 Support character positions inside a run of characters covered by a
2720 display string.
2721 (bidi_paragraph_init, bidi_resolve_explicit_1)
2722 (bidi_level_of_next_char): Call bidi_fetch_char and
2723 bidi_fetch_char_advance instead of FETCH_CHAR and
2724 FETCH_CHAR_ADVANCE.
2725 (bidi_init_it): Initialize new members.
2726 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2727 definitions.
2728 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2729 instead of using explicit *_CHAR codes.
2730 (bidi_resolve_explicit, bidi_resolve_weak):
2731 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2732 bidirectional text is supported only in multibyte buffers.
2733 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2734 it to initialize the frame_window_p member of struct bidi_it.
2735 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2736 (bidi_resolve_explicit, bidi_resolve_weak)
2737 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2738 bidi_it->nchars is non-positive.
2739 (bidi_level_of_next_char): Don't try to lookup the cache for the
2740 next/previous character if nothing is cached there yet, or if we
2741 were just reseat()'ed to a new position.
2742
2743 * xdisp.c (set_cursor_from_row): Set start and stop points
2744 according to the row's direction when priming the loop that looks
2745 for the glyph on which to display cursor.
2746 (single_display_spec_intangible_p): Function deleted.
2747 (display_prop_intangible_p): Reimplement to call
2748 handle_display_spec instead of single_display_spec_intangible_p.
2749 Accept 3 additional arguments needed by handle_display_spec.
2750 This fixes incorrect cursor motion across display property with complex
2751 values: lists, `(when COND...)' forms, etc.
2752 (single_display_spec_string_p): Support property values that are
2753 lists with the argument STRING its top-level element.
2754 (display_prop_string_p): Fix the condition for processing a
2755 property that is a list to be consistent with handle_display_spec.
2756 (handle_display_spec): New function, refactored from the
2757 last portion of handle_display_prop.
2758 (compute_display_string_pos): Accept additional argument
2759 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2760 value of a `display' property is a "replacing spec".
2761 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2762 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2763 the display property, but just return a value indicating whether
2764 the display property will replace the characters it covers.
2765 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2766 frame_window_p members of struct bidi_it.
2767 (compute_display_string_pos, compute_display_string_end):
2768 New functions.
2769 (push_it): Accept second argument POSITION, where pop_it should
2770 jump to continue iteration.
2771 (reseat_1): Initialize bidi_it.disp_pos.
2772
2773 * keyboard.c (adjust_point_for_property): Adjust the call to
2774 display_prop_intangible_p to its new signature.
2775
2776 * dispextern.h (struct bidi_it): New member frame_window_p.
2777 (bidi_init_it): Update prototypes.
2778 (display_prop_intangible_p): Update prototype.
2779 (compute_display_string_pos, compute_display_string_end):
2780 Declare prototypes.
2781 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2782 EMACS_INT.
2783
2784 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 Malloc failure behavior now depends on size of allocation.
2787 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2788 * lisp.h: Change signatures accordingly.
2789 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2790 All callers changed. (Bug#8762)
2791
2792 * gnutls.c: Use Emacs's memory allocators.
2793 Without this change, the gnutls library would invoke malloc etc.
2794 directly, which causes problems on non-SYNC_INPUT hosts, and which
2795 runs afoul of improving memory_full behavior. (Bug#8761)
2796 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2797 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2798 xfree instead of the default malloc, realloc, free.
2799 (Fgnutls_boot): No need to check for memory allocation failure,
2800 since xmalloc does that for us.
2801
2802 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2803 * category.c (hash_get_category_set):
2804 * ccl.c (ccl_driver):
2805 * charset.c (Fdefine_charset_internal):
2806 * charset.h (struct charset.hash_index):
2807 * composite.c (get_composition_id, gstring_lookup_cache)
2808 (composition_gstring_put_cache):
2809 * composite.h (struct composition.hash_index):
2810 * dispextern.h (struct image.hash):
2811 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2812 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2813 (hashfn_equal, hashfn_user_defined, make_hash_table)
2814 (maybe_resize_hash_table, hash_lookup, hash_put)
2815 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2816 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2817 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2818 * image.c (make_image, search_image_cache, lookup_image)
2819 (xpm_put_color_table_h):
2820 * lisp.h (struct Lisp_Hash_Table):
2821 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2822 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2823 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2824 * alloc.c (allocate_vectorlike):
2825 Check for overflow in vector size calculations.
2826 * ccl.c (ccl_driver):
2827 Check for overflow when converting EMACS_INT to int.
2828 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2829 need to be updated by these changes.
2830 * fns.c (make_hash_table, maybe_resize_hash_table):
2831 Check for integer overflow with large hash tables.
2832 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2833 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2834 (SXHASH_REDUCE): New macro.
2835 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2836 Use it instead of discarding useful hash info with large hash values.
2837 (sxhash_float): New function.
2838 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2839 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2840 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2841 Rewrite to use FIXNUM_BITS, as this simplifies things.
2842 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2843 Adjust signatures to match updated version of code.
2844 (consing_since_gc): Now EMACS_INT, since a single hash table can
2845 use more than INT_MAX bytes.
2846
2847 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2848
2849 Make it possible to build with GCC-4.6+ -O2 -flto.
2850
2851 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2852
2853 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2854
2855 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2856 Call minibuffer-inactive-mode.
2857
2858 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2859
2860 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2861 Update dependencies.
2862
2863 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2864
2865 * data.c (init_data): Remove code for UTS, this system is not
2866 supported anymore.
2867
2868 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2869
2870 Don't force ./temacs to start in terminal mode.
2871
2872 * frame.c (make_initial_frame): Initialize faces in all cases, not
2873 only when CANNOT_DUMP is defined.
2874 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2875
2876 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2877
2878 * dispnew.c (add_window_display_history): Use const for the string
2879 pointer. Remove declaration, not needed.
2880
2881 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 Use 'inline', not 'INLINE'.
2884 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2885 * alloc.c, fontset.c (INLINE): Remove.
2886 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2887 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2888 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2889 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2890 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2891
2892 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2893
2894 Make it possible to run ./temacs.
2895
2896 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2897 syms_of_callproc does the same thing. Remove test for
2898 "initialized", do it in the caller.
2899 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2900
2901 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2902
2903 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2904 (read_minibuf): Use get_minibuffer.
2905 (syms_of_minibuf): Use DEFSYM.
2906 (Qmetadata): New var.
2907 * data.c (Qbuffer): Don't make it static.
2908 (syms_of_data): Use DEFSYM.
2909
2910 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2913 (CCL_CODE_MIN): New macro.
2914
2915 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2918
2919 * eval.c (Qdebug): Now static.
2920 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2921 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2922 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2923
2924 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2925
2926 * image.c: Various fixes to ImageMagick code comments.
2927 (Fimagemagick_types): Doc fix.
2928
2929 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 Minor fixes prompted by GCC 4.6.0 warnings.
2932
2933 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2934
2935 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2936 (x_clipboard_manager_save_all): Move extern decl to ...
2937 * xterm.h: ... here, so that it can be checked for consistency.
2938
2939 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2940
2941 * xselect.c (x_clipboard_manager_save_frame)
2942 (x_clipboard_manager_save_all): New functions.
2943 (Fx_clipboard_manager_save): Lisp function deleted.
2944
2945 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2946 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2947
2948 * xterm.h: Update prototype.
2949
2950 2011-05-28 William Xu <william.xwl@gmail.com>
2951
2952 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2953 exiting (Bug#8239).
2954
2955 2011-05-28 Jim Meyering <meyering@redhat.com>
2956
2957 Avoid a sign-extension bug in crypto_hash_function.
2958 * fns.c (to_uchar): Define.
2959 (crypto_hash_function): Use it to convert some newly-signed
2960 variables to unsigned, to avoid sign-extension bugs. For example,
2961 without this change, (md5 "truc") would evaluate to
2962 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2963 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2964 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2965
2966 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Integer overflow fixes.
2969
2970 * dbusbind.c: Serial number integer overflow fixes.
2971 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2972 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2973 to hold a serial number that is too large for a fixnum.
2974 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2975 Check for serial numbers out of range. Decode any serial number
2976 that was so large that it became a float. (Bug#8722)
2977
2978 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2979 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2980 Use XFASTINT rather than XUINT when numbers are nonnegative.
2981 (xd_append_arg, Fdbus_method_return_internal):
2982 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2983 arguments, check that Lisp number is nonnegative, rather than
2984 silently wrapping negative numbers around. (Bug#8722)
2985 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2986 (Bug#8722)
2987
2988 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2989
2990 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2991
2992 ccl: add integer overflow checks
2993 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2994 (IN_INT_RANGE): New macros.
2995 (ccl_driver): Use them to check for integer overflow when
2996 decoding a CCL program. Many of the new checks are whether XINT (x)
2997 fits in int; it doesn't always, on 64-bit hosts. The new version
2998 doesn't catch all possible integer overflows, but it's an
2999 improvement. (Bug#8719)
3000
3001 * alloc.c (make_event_array): Use XINT, not XUINT.
3002 There's no need for unsigned here.
3003
3004 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3005 This follows up to the 2011-05-06 change that substituted uintptr_t
3006 for EMACS_INT. This case wasn't caught back then.
3007
3008 Rework Fformat to avoid integer overflow issues.
3009 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3010 now (part of C89). Include <verify.h>.
3011 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3012 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3013 (Fformat): Avoid the prepass trying to compute sizes; it was only
3014 approximate and thus did not catch overflow reliably. Instead, walk
3015 through the format just once, formatting and computing sizes as we go,
3016 checking for integer overflow at every step, and allocating a larger
3017 buffer as needed. Keep track separately whether the format is
3018 multibyte. Keep only the most-recently calculated precision, rather
3019 than them all. Record whether each argument has been converted to
3020 string. Use EMACS_INT, not int, for byte and char and arg counts.
3021 Support field widths and precisions larger than INT_MAX. Avoid
3022 sprintf's undefined behavior with conversion specifications such as %#d
3023 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3024 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3025 formatting out-of-range floating point numbers with int
3026 formats. (Bug#8668)
3027
3028 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3029
3030 * data.c: Avoid integer truncation in expressions involving floats.
3031 * data.c: Include <intprops.h>.
3032 (arith_driver): When there's an integer overflow in an expression
3033 involving floating point, convert the integers to floating point
3034 so that the resulting value does not suffer from catastrophic
3035 integer truncation. For example, on a 64-bit host (* 4
3036 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3037 Do not rely on undefined behavior after integer overflow.
3038
3039 merge count_size_as_multibyte, parse_str_to_multibyte
3040 * character.c, character.h (count_size_as_multibyte):
3041 Rename from parse_str_to_multibyte; all uses changed.
3042 Check for integer overflow.
3043 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3044 since it's now a duplicate of the other. This is more of
3045 a character than a buffer op, so better that it's in character.c.
3046 * fns.c, print.c: Adjust to above changes.
3047
3048 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3049
3050 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3051
3052 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3055 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3056 (x_clipboard_manager_save): Now static.
3057 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3058
3059 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3060 (crypto_hash_function): Now static.
3061 Fix pointer signedness problems. Avoid unnecessary initializations.
3062
3063 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3064
3065 * termhooks.h (Vselection_alist): Make it terminal-local.
3066
3067 * terminal.c (create_terminal): Initialize it.
3068
3069 * xselect.c: Support for clipboard managers.
3070 (Vselection_alist): Move to termhooks.h as terminal-local var.
3071 (LOCAL_SELECTION): New macro.
3072 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3073 (symbol_to_x_atom): Remove gratuitous arg.
3074 (x_handle_selection_request, lisp_data_to_selection_data)
3075 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3076 (x_own_selection, x_get_local_selection, x_convert_selection):
3077 New arg, specifying work frame. Use terminal-local Vselection_alist.
3078 (some_frame_on_display): Delete unused function.
3079 (Fx_own_selection_internal, Fx_get_selection_internal)
3080 (Fx_disown_selection_internal, Fx_selection_owner_p)
3081 (Fx_selection_exists_p): New optional frame arg.
3082 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3083 (x_handle_selection_clear): Don't treat other terminals with the
3084 same keyboard specially. Use the terminal-local Vselection_alist.
3085 (x_clear_frame_selections): Use Frun_hook_with_args.
3086
3087 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3088
3089 * xterm.h: Add support for those atoms.
3090
3091 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3092
3093 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3094 (converted_selections, conversion_fail_tag): New global variables.
3095 (x_selection_request_lisp_error): Free the above.
3096 (x_get_local_selection): Remove unnecessary code.
3097 (x_reply_selection_request): Args changed; handle arbitrary array
3098 of converted selections stored in converted_selections.
3099 Separate the XChangeProperty and SelectionNotify steps.
3100 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3101 (x_convert_selection): New function.
3102 (x_handle_selection_event): Simplify.
3103 (x_get_foreign_selection): Don't ignore incoming requests while
3104 waiting for an answer; this will fail when we implement
3105 SAVE_TARGETS, and seems unnecessary anyway.
3106 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3107 (Vx_sent_selection_functions): Doc fix.
3108
3109 2011-05-26 Leo Liu <sdl.web@gmail.com>
3110
3111 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3112
3113 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3114
3115 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3116
3117 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3118 for fringe update if it has periodic bitmap.
3119 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3120 and fringe_bitmap_periodic_p.
3121
3122 * fringe.c (get_fringe_bitmap_data): New function.
3123 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3124 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3125 row. Mark glyph row for fringe update if periodicity changed.
3126
3127 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3128 for fringe update unless it has periodic bitmap.
3129
3130 2011-05-25 Kenichi Handa <handa@m17n.org>
3131
3132 * xdisp.c (get_next_display_element): Set correct it->face_id for
3133 a static composition.
3134
3135 2011-05-24 Leo Liu <sdl.web@gmail.com>
3136
3137 * deps.mk (fns.o):
3138 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3139
3140 * fns.c (crypto_hash_function, Fsha1): New function.
3141 (Fmd5): Use crypto_hash_function.
3142 (syms_of_fns): Add Ssha1.
3143
3144 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 * gnutls.c: Remove unused macros.
3147 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3148 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3149 Remove macros that are defined and never used.
3150 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3151
3152 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3153
3154 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3155 (Fx_get_selection_internal): Minor cleanup.
3156 (Fx_own_selection_internal): Rename arguments for consistency with
3157 select.el.
3158
3159 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3162
3163 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3164
3165 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3166
3167 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3168
3169 * dispnew.c (scrolling_window): Don't exclude the case that the
3170 last enabled row in the desired matrix touches the bottom boundary.
3171
3172 2011-05-21 Glenn Morris <rgm@gnu.org>
3173
3174 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3175 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3176 and add some more files.
3177
3178 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3179
3180 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3181 report_file_error introduced by the change from 2011-05-07.
3182
3183 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * systime.h (Time): Define only if emacs is defined.
3186 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3187 where the include path doesn't have X11/X.h by default. See
3188 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3189
3190 2011-05-20 Kenichi Handa <handa@m17n.org>
3191
3192 * composite.c (find_automatic_composition): Fix previous change.
3193
3194 2011-05-20 Glenn Morris <rgm@gnu.org>
3195
3196 * lisp.mk: New file, split from Makefile.in.
3197 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3198 (shortlisp): Remove.
3199 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3200
3201 2011-05-19 Glenn Morris <rgm@gnu.org>
3202
3203 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3204 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3205 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3206 (lisp): Set the order to that of loadup.el.
3207 (shortlisp): Make it a copy of $lisp.
3208 (SOME_MACHINE_LISP): Remove.
3209 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3210 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3211
3212 2011-05-18 Kenichi Handa <handa@m17n.org>
3213
3214 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3215 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3216 (find_automatic_composition): Mostly rewrite for efficiency.
3217
3218 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3219
3220 * makefile.w32-in: Update dependencies.
3221
3222 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3223
3224 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3225 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3226
3227 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 Fix some integer overflow issues, such as string length overflow.
3230
3231 * insdel.c (count_size_as_multibyte): Check for string overflow.
3232
3233 * character.c (lisp_string_width): Check for string overflow.
3234 Use EMACS_INT, not int, for string indexes and lengths; in
3235 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3236 the resulting string length overflows an EMACS_INT; instead,
3237 report a string overflow if no precision given. When checking for
3238 precision exhaustion, use a check that cannot possibly have
3239 integer overflow. (Bug#8675)
3240 * character.h (lisp_string_width): Adjust to new signature.
3241
3242 * alloc.c (string_overflow): New function.
3243 (Fmake_string): Use it. This doesn't change behavior, but saves
3244 a few bytes and will simplify future changes.
3245 * character.c (string_escape_byte8): Likewise.
3246 * lisp.h (string_overflow): New decl.
3247
3248 Fixups, following up to the user-interface timestamp change.
3249 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3250 for UI timestamps, instead of unsigned long.
3251 * msdos.c (mouse_get_pos): Likewise.
3252 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3253 * w32gui.h (Time): Define by including "systime.h" rather than by
3254 declaring it ourselves. (Bug#8664)
3255
3256 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3257 * image.c (clear_image_cache): Likewise.
3258
3259 * term.c (term_mouse_position): Don't assume time_t wraparound.
3260
3261 Be more systematic about user-interface timestamps.
3262 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3263 and sometimes 'EMACS_UINT', to represent these timestamps.
3264 This change causes it to use 'Time' uniformly, as that's what X uses.
3265 This makes the code easier to follow, and makes it easier to catch
3266 integer overflow bugs such as Bug#8664.
3267 * frame.c (Fmouse_position, Fmouse_pixel_position):
3268 Use Time, not unsigned long, for user-interface timestamps.
3269 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3270 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3271 * keyboard.h (last_event_timestamp): Likewise.
3272 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3273 * menu.h (xmenu_show): Likewise.
3274 * term.c (term_mouse_position): Likewise.
3275 * termhooks.h (struct input_event.timestamp): Likewise.
3276 (struct terminal.mouse_position_hook): Likewise.
3277 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3278 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3279 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3280 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3281 what it was before.
3282 * menu.h, termhooks.h: Include "systime.h", for Time.
3283
3284 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3285 Don't assume that the difference between two unsigned long values
3286 can fit into an integer. At this point, we know button_down_time
3287 <= event->timestamp, so the difference must be nonnegative, so
3288 there's no need to cast the result if double-click-time is
3289 nonnegative, as it should be; check that it's nonnegative, just in
3290 case. This bug is triggered when events are more than 2**31 ms
3291 apart (about 25 days). (Bug#8664)
3292
3293 * xselect.c (last_event_timestamp): Remove duplicate decl.
3294 (x_own_selection): Remove needless cast to unsigned long.
3295
3296 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3297 that always fit in int. Use a sentinel instead of a counter, to
3298 avoid a temp and to allay GCC's concerns about possible int overflow.
3299 * frame.h (struct frame): Use int for menu_bar_items_used
3300 instead of EMACS_INT, since it always fits in int.
3301
3302 * menu.c (grow_menu_items): Check for int overflow.
3303
3304 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3305
3306 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3307 Before, the code was not consistent. These values cannot exceed
3308 2**31 - 1 so there's no need to make them unsigned.
3309 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3310 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3311 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3312 as modifiers.
3313 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3314
3315 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3316 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3317 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3318 presumably because the widths might not match.
3319
3320 * window.c (size_window): Avoid needless test at loop start.
3321
3322 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3323
3324 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3325
3326 2011-05-12 Drew Adams <drew.adams@oracle.com>
3327
3328 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3329
3330 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3331
3332 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3333 `width' to `bar_area_x' and `bar_area_width', respectively.
3334 (x_scroll_run): Take account of fringe background extension.
3335
3336 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3337 Rename local vars `left' and `width' to `bar_area_x' and
3338 `bar_area_width', respectively.
3339 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3340 background extension.
3341
3342 2011-05-10 Jim Meyering <meyering@redhat.com>
3343
3344 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3345
3346 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3347
3348 * image.c (Finit_image_library): Return t for built-in image types,
3349 like pbm and xbm. (Bug#8640)
3350
3351 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3352
3353 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3354
3355 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3356
3357 * w32console.c (Fset_screen_color): Doc fix.
3358 (Fget_screen_color): New function.
3359 (syms_of_ntterm): Defsubr it.
3360
3361 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3362 unlink the temporary file if Fcall_process didn't create it in the
3363 first place.
3364 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3365 child process will be redirected to a file specified with `:file'.
3366 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3367 cue to call_process_cleanup not to close that handle.
3368
3369 2011-05-07 Ben Key <bkey76@gmail.com>
3370
3371 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3372 one of two shell specific rules, either bootstrap-temacs-CMD or
3373 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3374 to the previous implementation of the bootstrap-temacs rule.
3375 The bootstrap-temacs-CMD rule is similar to the previous
3376 implementation of the bootstrap-temacs rule except that it
3377 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3378 variable.
3379
3380 These changes, along with some changes to nt/configure.bat,
3381 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3382 earlier fix to add support for --cflags and --ldflags options
3383 that include quotes so that it works whether make uses cmd or
3384 sh as the shell.
3385
3386 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3387
3388 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3389 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3390 is a constant.
3391 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3392 a string. Handle both cases.
3393 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3394 (Fdbus_register_method): Use Qinvalid_function.
3395
3396 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3397
3398 * makefile.w32-in: Update dependencies.
3399 (LISP_H): Add inttypes.h and stdin.h.
3400 (PROCESS_H): Add unistd.h.
3401
3402 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3403
3404 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3405 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3406
3407 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3408
3409 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3410
3411 * term.c (vfatal): Remove stray call to va_end.
3412 It's not needed and the C Standard doesn't allow it here anyway.
3413
3414 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3415 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3416
3417 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3418 bytes.
3419
3420 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3421
3422 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3423
3424 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3425
3426 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3427
3428 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3429
3430 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3431 * charset.c (Fdefine_charset_internal): Don't initialize
3432 charset.code_space[15]. The value was garbage, on hosts with
3433 32-bit int (Bug#8600).
3434
3435 * lread.c (read_integer): Be more consistent with string-to-number.
3436 Use string_to_number to do the actual conversion; this avoids
3437 rounding errors and fixes some other screwups. Without this fix,
3438 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3439 (digit_to_number): Move earlier, for benefit of read_integer.
3440 Return -1 if the digit is out of range for the base, -2 if it is
3441 not a digit in any supported base. (Bug#8602)
3442
3443 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3444
3445 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3446 to match comment at start of function. This also removes a
3447 GCC warning about overflow in a 32+64-bit port.
3448
3449 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3450
3451 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3452 Reported by Stefan Monnier in
3453 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3454 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3455 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3456
3457 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3458 (EMACS_UINTPTR): Likewise, with uintptr_t.
3459
3460 * lisp.h: Prefer 64-bit EMACS_INT if available.
3461 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3462 on 32-bit hosts that have 64-bit int, so that they can access
3463 large files.
3464 However, temporarily disable this change unless the temporary
3465 symbol WIDE_EMACS_INT is defined.
3466
3467 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3468
3469 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3470 This removes an assumption that EMACS_INT and long are the same
3471 width as pointers. The assumption is true for Emacs porting targets
3472 now, but we want to make other targets possible.
3473 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3474 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3475 In the rest of the code, change types of integers that hold casted
3476 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3477 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3478 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3479 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3480 No need to cast type when ORing.
3481 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3482 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3483 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3484 assume EMACS_INT is the same width as char *.
3485 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3486 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3487 Remove no-longer-needed casts.
3488 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3489 (xg_tool_bar_help_callback, xg_make_tool_item):
3490 Use EMACS_INTPTR to hold an integer
3491 that will be cast to void *; this can avoid a GCC warning
3492 if EMACS_INT is not the same width as void *.
3493 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3494 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3495 (current_message_1, set_message_1):
3496 Use a local to convert to proper width without a cast.
3497 * xmenu.c (dialog_selection_callback): Likewise.
3498
3499 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3500 Also, don't assume VALBITS / RAND_BITS is less than 5,
3501 and don't rely on undefined behavior when shifting a 1 left into
3502 the sign bit.
3503 * lisp.h (get_random): Change signature to match.
3504
3505 * lread.c (hash_string): Use size_t, not int, for hash computation.
3506 Normally we prefer signed values; but hashing is special, because
3507 it's better to use unsigned division on hash table sizes so that
3508 the remainder is nonnegative. Also, size_t is the natural width
3509 for hashing into memory. The previous code used 'int', which doesn't
3510 retain enough info to hash well into very large tables.
3511 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3512
3513 * dbusbind.c: Don't possibly lose pointer info when converting.
3514 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3515 Use XPNTR rather than XHASH, so that the high-order bits of
3516 the pointer aren't lost when converting through void *.
3517
3518 * eval.c (Fautoload): Don't double-shift a pointer.
3519
3520 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3521
3522 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3523
3524 * gnutls.c (DEF_GNUTLS_FN):
3525 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3526
3527 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3528
3529 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3530 marker. (Bug#8610)
3531
3532 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3533
3534 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3535 New version that can reserve upto 2GB of heap space.
3536
3537 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3538
3539 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3540
3541 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3542
3543 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3544 `gnutls_certificate_set_x509_key_file'.
3545
3546 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3547
3548 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3549 Update dependencies.
3550
3551 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3552
3553 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3554 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3555 Remove unused parameter `fildes'.
3556 * process.c (read_process_output, send_process): Don't pass it.
3557
3558 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3559
3560 Fix previous change: the library cache is defined in w32.c.
3561 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3562 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3563
3564 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3565
3566 Implement dynamic loading of GnuTLS on Windows.
3567
3568 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3569 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3570 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3571 Declare.
3572
3573 * gnutls.c (Qgnutls_dll): Define.
3574 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3575 (gnutls_*): Declare function pointers.
3576 (init_gnutls_functions): New function to initialize function pointers.
3577 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3578 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3579 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3580 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3581 (emacs_gnutls_write, emacs_gnutls_read)
3582 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3583 (Fgnutls_available_p): New function.
3584 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3585 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3586 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3587
3588 * image.c: Include w32.h.
3589 (Vimage_type_cache): Delete.
3590 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3591 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3592 (w32_delayed_load): Move to w32.c.
3593
3594 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3595
3596 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3597 (w32_delayed_load): Move from image.c. When loading a library, record
3598 its filename in the :loaded-from property of the library id.
3599 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3600 Initialize and staticpro them.
3601 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3602
3603 * process.c: Include lisp.h before w32.h, not after.
3604 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3605 instead of gnutls_record_check_pending.
3606
3607 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3608
3609 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3610
3611 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3612 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3613 as passed in.
3614
3615 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3616
3617 * xterm.c (x_set_frame_alpha): Do not set property on anything
3618 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3619
3620 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3621
3622 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3623
3624 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3625
3626 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3627 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3628 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3629 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3630 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3631 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3632 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3633 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3634 (Qgnutls_bootprop_callbacks_verify): Make static.
3635
3636 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3637
3638 * callproc.c: Indentation fixup.
3639
3640 * sysdep.c (wait_for_termination_1): Make static.
3641 (wait_for_termination, interruptible_wait_for_termination):
3642 Move after wait_for_termination_1.
3643
3644 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3645
3646 * sysdep.c (interruptible_wait_for_termination): New function
3647 which is like wait_for_termination, but allows keyboard
3648 interruptions.
3649
3650 * callproc.c (Fcall_process): Add (:file "file") as an option for
3651 the STDOUT buffer.
3652 (Fcall_process_region): Ditto.
3653
3654 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3655
3656 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3657 rather than `XVECTOR (FOO)->size'.
3658
3659 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3660 inttypes.h, as a gnulib replacement is used if it not available in
3661 system headers.
3662
3663 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3664
3665 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3666 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3667 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3668
3669 * coding.c (coding_alloc_by_realloc): Error out if destination
3670 will grow beyond MOST_POSITIVE_FIXNUM.
3671 (decode_coding_emacs_mule): Abort if there isn't enough place in
3672 charbuf for the composition carryover bytes. Reserve an extra
3673 space for up to 2 characters produced in a loop.
3674 (decode_coding_iso_2022): Abort if there isn't enough place in
3675 charbuf for the composition carryover bytes.
3676
3677 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3678
3679 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3680 aborting when %lld or %lll format is passed.
3681 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3682 %llo or %llx format is passed. (Bug#8545)
3683
3684 * window.c (window_scroll_line_based): Use a marker instead of
3685 simple variables to record original value of point. (Bug#7952)
3686
3687 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3688 produced by %s or %c overflows available buffer space. (Bug#8545)
3689
3690 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3691
3692 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3693 (SIZE_MAX): Move defn after all includes, as they might #define it.
3694
3695 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3696
3697 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3698
3699 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3700
3701 * keyboard.c (Qdelayed_warnings_hook): Define.
3702 (command_loop_1): Run `delayed-warnings-hook'
3703 if Vdelayed_warnings_list is non-nil.
3704 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3705 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3706
3707 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3708
3709 * doprnt.c (doprnt): Don't return value smaller than the buffer
3710 size if the message was truncated. (Bug#8545).
3711
3712 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3713
3714 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3715 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3716
3717 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3718
3719 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3720
3721 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * makefile.w32-in: Update dependencies.
3724
3725 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3726
3727 Improve `doprnt' and its usage. (Bug#8545)
3728 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3729 `format_end'. Remove support for %l as a conversion specifier.
3730 Don't use xrealloc. Improve diagnostics when the %l size modifier
3731 is used. Update the commentary.
3732
3733 * eval.c (verror): Simplify calculation of size_t.
3734
3735 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3736 messages.
3737
3738 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3739
3740 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3741 change.
3742
3743 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3744
3745 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3746 This makes this file independent of the recent pseudovector change.
3747
3748 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3749
3750 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3751
3752 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3753 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3754 Remove unused local.
3755 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3756
3757 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3758 GCC 4.6.0 optimizes based on type-based alias analysis.
3759 For example, if b is of type struct buffer * and v of type struct
3760 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3761 != &v->size, and therefore "v->size = 1; b->size = 2; return
3762 v->size;" must therefore return 1. This assumption is incorrect
3763 for Emacs, since it type-puns struct Lisp_Vector * with many other
3764 types. To fix this problem, this patch adds a new type struct
3765 vectorlike_header that documents the constraints on layout of vectors
3766 and pseudovectors, and helps optimizing compilers not get fooled
3767 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3768 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3769 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3770 the size member.
3771 (XSETPVECTYPE): Rewrite in terms of new macro.
3772 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3773 This is a bit clearer, and further avoids the possibility of
3774 undesirable aliasing.
3775 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3776 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3777 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3778 since Lisp_Subr is a special case (no "next" field).
3779 (ASIZE): Now uses header.size rather than size.
3780 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3781 to avoid the hassle of writing XVECTOR (foo)->header.size.
3782 (struct vectorlike_header): New type.
3783 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3784 object, to help avoid aliasing.
3785 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3786 (SUBRP): Likewise, since Lisp_Subr is a special case.
3787 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3788 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3789 (struct Lisp_Hash_Table): Combine first two members into a single
3790 struct vectorlike_header member. All uses of "size" and "next" members
3791 changed to be "header.size" and "header.next".
3792 * buffer.h (struct buffer): Likewise.
3793 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3794 * frame.h (struct frame): Likewise.
3795 * process.h (struct Lisp_Process): Likewise.
3796 * termhooks.h (struct terminal): Likewise.
3797 * window.c (struct save_window_data, struct saved_window): Likewise.
3798 * window.h (struct window): Likewise.
3799 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3800 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3801 * buffer.c (init_buffer_once): Likewise.
3802 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3803 special case.
3804 * process.c (Fformat_network_address): Use local var for size,
3805 for brevity.
3806
3807 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3808
3809 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3810 * data.c (atof): Remove decl; no longer used or needed.
3811 (digit_to_number): Move to lread.c.
3812 (Fstring_to_number): Use new string_to_number function, to be
3813 consistent with how the Lisp reader treats infinities and NaNs.
3814 Do not assume that floating-point numbers represent EMACS_INT
3815 without losing information; this is not true on most 64-bit hosts.
3816 Avoid double-rounding errors, by insisting on integers when
3817 parsing non-base-10 numbers, as the documentation specifies.
3818 * lisp.h (string_to_number): New decl, replacing ...
3819 (isfloat_string): Remove.
3820 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3821 (read1): Do not accept +. and -. as integers; this
3822 appears to have been a coding error. Similarly, do not accept
3823 strings like +-1e0 as floating point numbers. Do not report
3824 overflow for integer overflows unless the base is not 10 which
3825 means we have no simple and reliable way to continue.
3826 Break out the floating-point parsing into a new
3827 function string_to_number, so that Fstring_to_number parses
3828 floating point numbers consistently with the Lisp reader.
3829 (digit_to_number): Move here from data.c. Make it static inline.
3830 (E_CHAR, EXP_INT): Remove, replacing with ...
3831 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3832 (string_to_number): New function, replacing isfloat_string.
3833 This function checks for valid syntax and produces the resulting
3834 Lisp float number too. Rework it so that string-to-number
3835 no longer mishandles examples like "1.0e+". Use strtoumax,
3836 so that overflow for non-base-10 numbers is reported only when
3837 there's no portable and simple way to convert to floating point.
3838
3839 * textprop.c (set_text_properties_1): Rewrite for clarity,
3840 and to avoid GCC warning about integer overflow.
3841
3842 * intervals.h (struct interval): Use EMACS_INT for members
3843 where EMACS_UINT might cause problems. See
3844 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3845 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3846 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3847 All uses changed.
3848 (offset_intervals): Tell GCC not to worry about length overflow
3849 when negating a negative length.
3850
3851 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3852 (overrun_check_free): Likewise.
3853
3854 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3855 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3856 word size.
3857
3858 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3859 (gnutls_make_error): Rename local to avoid shadowing.
3860 (gnutls_emacs_global_deinit): ifdef out; not used.
3861 (Fgnutls_boot): Use const for pointer to readonly storage.
3862 Comment out unused local. Fix pointer signedness problems.
3863
3864 * lread.c (openp): Don't stuff size_t into an 'int'.
3865 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3866 about possible signed overflow.
3867
3868 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3869 (GDK_KEY_g): Don't define if already defined.
3870 (xg_prepare_tooltip): Avoid pointer signedness problem.
3871 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3872
3873 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3874 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3875
3876 * xfns.c (Fx_window_property): Simplify a bit,
3877 to make a bit faster and to avoid GCC 4.6.0 warning.
3878 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3879
3880 * fns.c (internal_equal): Don't assume size_t fits in int.
3881
3882 * alloc.c (compact_small_strings): Tighten assertion a little.
3883
3884 Replace pEd with more-general pI, and fix some printf arg casts.
3885 * lisp.h (pI): New macro, generalizing old pEd macro to other
3886 conversion specifiers. For example, use "...%"pI"d..." rather
3887 than "...%"pEd"...".
3888 (pEd): Remove. All uses replaced with similar uses of pI.
3889 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3890 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3891 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3892 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3893 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3894 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3895 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3896 64-bit hosts.
3897 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3898 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3899 * print.c (safe_debug_print, print_object): Likewise.
3900 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3901 to int.
3902 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3903 avoiding the 0 flag, which is not portable.
3904 * process.c (Fmake_network_process): Use pI to avoid cast.
3905 * region-cache.c (pp_cache): Likewise.
3906 * xdisp.c (decode_mode_spec): Likewise.
3907 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3908 behavior on 64-bit hosts with printf arg.
3909 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3910 (x_stop_queuing_selection_requests): Likewise.
3911 (x_get_window_property): Don't truncate byte count to an 'int'
3912 when tracing.
3913
3914 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3915 here, since it parses constructs like leading '-' and spaces,
3916 which are not wanted; and it overflows with large numbers.
3917 Instead, simply match F[0-9]+, which is what is wanted anyway.
3918
3919 * alloc.c: Remove unportable assumptions about struct layout.
3920 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3921 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3922 (allocate_vectorlike, make_pure_vector): Use the new macros,
3923 plus offsetof, to remove unportable assumptions about struct layout.
3924 These assumptions hold on all porting targets that I know of, but
3925 they are not guaranteed, they're easy to remove, and removing them
3926 makes further changes easier.
3927
3928 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3929 This doesn't fix a bug but makes the code clearer.
3930 (string_overrun_cookie): Now const. Use initializers that
3931 don't formally overflow signed char, to avoid warnings.
3932 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3933 can cause Emacs to crash when string overrun checking is enabled.
3934 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3935 multiple of sizeof (EMACS_INT); it need not be, if
3936 alignof(EMACS_INT) < sizeof (EMACS_INT).
3937 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3938
3939 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3940
3941 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3942
3943 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3944
3945 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3946 supposed to be handshaking. (Bug#8556)
3947 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3948
3949 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3950
3951 * lisp.h (Qdebug): List symbol.
3952 * eval.c (Qdebug): Restore global linkage.
3953 * keyboard.c (debug-on-event): New variable.
3954 (handle_user_signal): Break into debugger when debug-on-event
3955 matches the current signal symbol.
3956
3957 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3958
3959 * alloc.c (check_sblock, check_string_bytes)
3960 (check_string_free_list): Convert to standard C.
3961
3962 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3963
3964 * w32.c (emacs_gnutls_push): Fix typo.
3965
3966 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3967
3968 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3969 "cast to pointer from integer of different size".
3970
3971 Improve doprnt and its use in verror. (Bug#8545)
3972 * doprnt.c (doprnt): Document the set of format control sequences
3973 supported by the function. Use SAFE_ALLOCA instead of always
3974 using `alloca'.
3975
3976 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3977 is one byte too soon. Don't use xrealloc; instead xfree and
3978 xmalloc anew.
3979
3980 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3981
3982 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3983 callbacks stage.
3984
3985 * gnutls.c: Renamed global_initialized to
3986 gnutls_global_initialized. Added internals for the
3987 :verify-hostname-error, :verify-error, and :verify-flags
3988 parameters of `gnutls-boot' and documented those parameters in the
3989 docstring. Start callback support.
3990 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3991 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3992 on error. Return error code.
3993 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3994 (emacs_gnutls_read): Likewise.
3995 (Fgnutls_boot): Return handshake error code.
3996 (emacs_gnutls_handle_error): New function.
3997 (wsaerror_to_errno): Likewise.
3998
3999 * w32.h (emacs_gnutls_pull): Add prototype.
4000 (emacs_gnutls_push): Likewise.
4001
4002 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4003 (emacs_gnutls_push): Likewise.
4004
4005 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4006
4007 * process.c (wait_reading_process_output): Check if GnuTLS
4008 buffered some data internally if no FDs are set for TLS
4009 connections.
4010
4011 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4012 (LIBS): Link to USER_LIBS.
4013 ($(BLD)/gnutls.$(0)): New target.
4014
4015 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4016
4017 * xdisp.c (handle_single_display_spec): Rename the
4018 display_replaced_before_p argument into display_replaced_p, to
4019 make it consistent with the commentary. Fix typos in the
4020 commentary.
4021
4022 * textprop.c (syms_of_textprop): Remove dead code.
4023 (copy_text_properties): Delete obsolete commentary about an
4024 interface that was deleted long ago. Fix typos in the description
4025 of arguments.
4026
4027 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4028 to changes in oldXMenu/XMenu.h from 2011-04-16.
4029 <menu_help_message, prev_menu_help_message>: Constify.
4030 (IT_menu_make_room): menu->help_text is now `const char **';
4031 adjust.
4032
4033 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4034 to changes in oldXMenu/XMenu.h from 2011-04-16.
4035 (struct XMenu): Declare `help_text' `const char **'.
4036
4037 * xfaces.c <Qunspecified>: Make extern again.
4038
4039 * syntax.c: Include sys/types.h before including regex.h, as
4040 required by Posix.
4041
4042 * doc.c (get_doc_string): Improve the format passed to `error'.
4043
4044 * doprnt.c (doprnt): Improve commentary.
4045
4046 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4047
4048 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4049 them with etags.
4050
4051 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4052 changes in globals.h immediately force recompilation.
4053 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4054 $(CURDIR)/s/ms-w32.h.
4055 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4056
4057 * character.c (Fchar_direction): Function deleted.
4058 (syms_of_character): Don't defsubr it.
4059 <char-direction-table>: Deleted.
4060
4061 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4062
4063 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4064 * doprnt.c: Include limits.h.
4065 (SIZE_MAX): New macro.
4066 (doprnt): Return a size_t value. 2nd arg is now size_t.
4067 Many local variables are now size_t instead of int or unsigned.
4068 Improve overflow protection. Support `l' modifier for integer
4069 conversions. Support %l conversion. Don't assume an EMACS_INT
4070 argument for integer conversions and for %c.
4071
4072 * lisp.h (doprnt): Restore prototype.
4073
4074 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4075 $(SRC)/character.h.
4076
4077 * Makefile.in (base_obj): Add back doprnt.o.
4078
4079 * deps.mk (doprnt.o): Add back prerequisites.
4080 (callint.o): Depend on character.h.
4081
4082 * eval.c (internal_lisp_condition_case): Include the handler
4083 representation in the error message.
4084 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4085 when breaking from the loop.
4086
4087 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4088
4089 * callint.c (Fcall_interactively): When displaying error message
4090 about invalid control letter, pass the character's codepoint, not
4091 a pointer to its multibyte form. Improve display of the character
4092 in octal and display also its hex code.
4093
4094 * character.c (char_string): Use %x to display the (unsigned)
4095 codepoint of an invalid character, to avoid displaying a bogus
4096 negative value.
4097
4098 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4099 `error', not SYMBOL_NAME itself.
4100
4101 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4102 character arguments to `error'.
4103
4104 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4105 to `error' in error message about FINAL_CHAR argument. Make sure
4106 FINAL_CHAR is a character, and use %c when it is passed as
4107 argument to `error'.
4108
4109 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4110
4111 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4112
4113 * w32.c: Include <time.h>.
4114 (sys_localtime): New function.
4115
4116 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4117
4118 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4119
4120 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4121
4122 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4123
4124 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4125 zombies (Bug#8467).
4126
4127 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4128
4129 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4130 gl_state.e_property when gl_state.object is Qt.
4131
4132 * insdel.c (make_gap_larger): Remove limitation of buffer size
4133 to <= INT_MAX.
4134
4135 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4136
4137 * xdisp.c (lookup_glyphless_char_display)
4138 (produce_glyphless_glyph): Handle cons cell entry in
4139 glyphless-char-display.
4140 (Vglyphless_char_display): Document it.
4141
4142 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4143 glyphless-char-display.
4144
4145 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4146
4147 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4148
4149 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4150
4151 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4152 definition for no-X builds.
4153
4154 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 Static checks with GCC 4.6.0 and non-default toolkits.
4157
4158 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4159
4160 * process.c (keyboard_bit_set): Define only if SIGIO.
4161 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4162 (send_process): Repair possible setjmp clobbering.
4163
4164 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4165
4166 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4167
4168 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4169
4170 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4171 Define only if needed.
4172
4173 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4174 by pacifying GCC about it. Maybe it's time to retire it?
4175 * xfaces.c (USG, __TIMEVAL__): Likewise.
4176
4177 * dispextern.h (struct redisplay_interface): Rename param
4178 to avoid shadowing.
4179 * termhooks.h (struct terminal): Likewise.
4180 * xterm.c (xembed_send_message): Likewise.
4181
4182 * insdel.c (make_gap_smaller): Define only if
4183 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4184
4185 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4186 it.
4187
4188 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4189 so that we aren't warned about unused symbols.
4190
4191 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4192
4193 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4194
4195 * xfns.c (x_real_positions): Mark locals as initialized.
4196
4197 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4198
4199 * xterm.c: Fix problems found by static analysis with other toolkits.
4200 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4201 (x_dispatch_event): Declare static if USE_GTK, and
4202 define if USE_GTK || USE_X_TOOLKIT.
4203 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4204 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4205 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4206 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4207
4208 * xmenu.c (menu_help_callback): Pointer type fixes.
4209 Use const pointers when pointing at readonly data. Avoid pointer
4210 signedness clashes.
4211 (FALSE): Remove unused macro.
4212 (update_frame_menubar): Remove unused decl.
4213
4214 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4215
4216 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4217 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4218 (single_menu_item): Rename local to avoid shadowing.
4219
4220 * keyboard.c (make_lispy_event): Remove unused local var.
4221
4222 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4223 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4224
4225 * bitmaps: Change bitmaps from unsigned char back to the X11
4226 compatible char. Avoid the old compiler warnings about
4227 out-of-range initializers by using, for example, '\xab' rather
4228 than 0xab.
4229
4230 * xgselect.c (xgselect_initialize): Check vs interface
4231 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4232
4233 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4234
4235 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4236 to read-only memory.
4237
4238 * fns.c (vector): Remove; this old hack is no longer needed.
4239
4240 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4241 Remove unused var.
4242 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4243
4244 * xrdb.c (x_load_resources): Omit unused local.
4245
4246 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4247 (x_window): Rename locals to avoid shadowing.
4248 (USG): Use the kludged USG macro, to pacify gcc.
4249
4250 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4251 (x_term_init): Remove local to avoid shadowing.
4252
4253 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4254
4255 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4256 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4257
4258 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4259
4260 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4261
4262 Fix regex.c, syntax.c and friends for buffers > 2GB.
4263 * syntax.h (struct gl_state_s): Declare character position members
4264 EMACS_INT.
4265
4266 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4267
4268 * textprop.c (verify_interval_modification, interval_of):
4269 Declare arguments EMACS_INT.
4270
4271 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4272 EMACS_INT.
4273
4274 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4275
4276 * indent.c (Fvertical_motion): Local variable it_start is now
4277 EMACS_INT.
4278
4279 * regex.c (re_match, re_match_2, re_match_2_internal)
4280 (bcmp_translate, regcomp, regexec, print_double_string)
4281 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4282 (re_compile_pattern, re_exec): Declare arguments and local
4283 variables `size_t' and `ssize_t' and return values `regoff_t', as
4284 appropriate.
4285 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4286 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4287 <compile_stack_type>: `size' and `avail' are now `size_t'.
4288
4289 * regex.h <regoff_t>: Use ssize_t, not int.
4290 (re_search, re_search_2, re_match, re_match_2): Arguments that
4291 specify buffer/string position and length are now ssize_t and
4292 size_t. Return type is regoff_t.
4293
4294 2011-04-16 Ben Key <bkey76@gmail.com>
4295
4296 * nsfont.m: Fixed bugs in ns_get_family and
4297 ns_descriptor_to_entity that were caused by using free to
4298 deallocate memory blocks that were allocated by xmalloc (via
4299 xstrdup). This caused Emacs to crash when compiled with
4300 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4301 --enable-checking=xmallocoverrun). xfree is now used to
4302 deallocate these memory blocks.
4303
4304 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4307
4308 emacs_write: Accept and return EMACS_INT for sizes.
4309 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4310 et seq.
4311 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4312 Accept and return EMACS_INT.
4313 (emacs_gnutls_write): Return the number of bytes written on
4314 partial writes.
4315 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4316 (emacs_read, emacs_write): Remove check for negative size, as the
4317 Emacs source code has been audited now.
4318 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4319 (emacs_read, emacs_write): Use it.
4320 * process.c (send_process): Adjust to the new signatures of
4321 emacs_write and emacs_gnutls_write. Do not attempt to store
4322 a byte offset into an 'int'; it might overflow.
4323 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4324
4325 * sound.c: Don't assume sizes fit in 'int'.
4326 (struct sound_device.period_size, alsa_period_size):
4327 Return EMACS_INT, not int.
4328 (struct sound_device.write, vox_write, alsa_write):
4329 Accept EMACS_INT, not int.
4330 (wav_play, au_play): Use EMACS_INT to store sizes and to
4331 record read return values.
4332
4333 2011-04-15 Ben Key <bkey76@gmail.com>
4334
4335 * keyboard.c (Qundefined): Don't declare static since it is used
4336 in nsfns.m.
4337 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4338 static since they are used in nsfont.m.
4339
4340 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4341
4342 * process.c (Qprocessp): Don't declare static.
4343 * lisp.h (Qprocessp): Declare again.
4344
4345 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4346
4347 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4348
4349 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4350
4351 Improve C-level modularity by making more things 'static'.
4352
4353 Don't publish debugger-only interfaces to other modules.
4354 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4355 (verify_bytepos, count_markers): Move decls to the only modules
4356 that need them.
4357 * region-cache.h (pp_cache): Likewise.
4358 * window.h (check_all_windows): Likewise.
4359 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4360
4361 * sysdep.c (croak): Now static, if
4362 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4363 * syssignal.h (croak): Declare only if not static.
4364
4365 * alloc.c (refill_memory_reserve): Now static if
4366 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4367 * lisp.h (refill_memory_reserve): Declare only if not static.
4368
4369 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4370 Define only if USE_LUCID.
4371
4372 * xrdb.c (x_customization_string, x_rm_string): Now static.
4373
4374 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4375 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4376
4377 * xdisp.c (draw_row_with_mouse_face): Now static.
4378 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4379
4380 * window.h (check_all_windows): Mark externally visible.
4381
4382 * window.c (window_deletion_count): Now static.
4383
4384 * undo.c: Make symbols static if they're not exported.
4385 (last_undo_buffer, last_boundary_position, pending_boundary):
4386 Now static.
4387
4388 * textprop.c (interval_insert_behind_hooks): Now static.
4389 (interval_insert_in_front_hooks): Likewise.
4390
4391 * term.c: Make symbols static if they're not exported.
4392 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4393 (max_frame_lines, tty_set_terminal_modes):
4394 (tty_reset_terminal_modes, tty_turn_off_highlight):
4395 (get_tty_terminal): Now static.
4396 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4397 * termhooks.h (term_mouse_moveto): Do not declare if
4398 HAVE_WINDOW_SYSTEM.
4399 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4400 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4401
4402 * sysdep.c: Make symbols static if they're not exported.
4403 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4404 Now static.
4405 (sigprocmask_set, full_mask): Remove; unused.
4406 (wait_debugging): Mark as visible.
4407 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4408 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4409
4410 * syntax.c (syntax_temp): Define only if !__GNUC__.
4411
4412 * sound.c (current_sound_device, current_sound): Now static.
4413
4414 * search.c (searchbufs, searchbuf_head): Now static.
4415
4416 * scroll.c (scroll_cost): Remove; unused.
4417 * dispextern.h (scroll_cost): Remove decl.
4418
4419 * region-cache.h (pp_cache): Mark as externally visible.
4420
4421 * process.c: Make symbols static if they're not exported.
4422 (process_tick, update_tick, create_process, chan_process):
4423 (Vprocess_alist, proc_buffered_char, datagram_access):
4424 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4425 (deactivate_process): Mark defn as static, as well as decl.
4426 * lisp.h (create_process): Remove decl.
4427 * process.h (chan_process, Vprocess_alist): Remove decls.
4428
4429 * print.c: Make symbols static if they're not exported.
4430 (print_depth, new_backquote_output, being_printed, print_buffer):
4431 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4432 (print_interval, print_number_index, initial_stderr_stream):
4433 Now static.
4434 * lisp.h (Fprinc): Remove decl.
4435 (debug_output_compilation_hack): Mark as externally visible.
4436
4437 * sysdep.c (croak): Move decl from here to syssignal.h.
4438 * syssignal.h (croak): Put it here, so the API can be checked when
4439 'croak' is called from dissociate_if_controlling_tty.
4440
4441 * minibuf.c: Make symbols static if they're not exported.
4442 (minibuf_save_list, choose_minibuf_frame): Now static.
4443 * lisp.h (choose_minibuf_frame): Remove decl.
4444
4445 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4446
4447 * lread.c: Make symbols static if they're not exported.
4448 (read_objects, initial_obarray, oblookup_last_bucket_number):
4449 Now static.
4450 (make_symbol): Remove; unused.
4451 * lisp.h (initial_obarray, make_symbol): Remove decls.
4452
4453 * keyboard.c: Make symbols static if they're not exported.
4454 (single_kboard, recent_keys_index, total_keys, recent_keys):
4455 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4456 (this_single_command_key_start, echoing, last_auto_save):
4457 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4458 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4459 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4460 (Vlispy_mouse_stem, double_click_count):
4461 Now static.
4462 (force_auto_save_soon): Define only if SIGDANGER.
4463 (ignore_mouse_drag_p): Now static if
4464 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4465 (print_help): Remove; unused.
4466 (stop_character, last_timer_event): Mark as externally visible.
4467 * keyboard.h (ignore_mouse_drag_p): Declare only if
4468 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4469 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4470 * lisp.h (echoing): Remove decl.
4471 (force_auto_save_soon): Declare only if SIGDANGER.
4472 * xdisp.c (redisplay_window): Simplify code, to make it more
4473 obvious that ignore_mouse_drag_p is not accessed if !defined
4474 USE_GTK && !defined HAVE_NS.
4475
4476 * intervals.c: Make symbols static if they're not exported.
4477 (merge_properties_sticky, merge_interval_right, delete_interval):
4478 Now static.
4479 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4480
4481 * insdel.c: Make symbols static if they're not exported.
4482 However, leave prepare_to_modify_buffer alone. It's never
4483 called from outside this function, but that appears to be a bug.
4484 (combine_after_change_list, combine_after_change_buffer):
4485 (adjust_after_replace, signal_before_change): Now static.
4486 (adjust_after_replace_noundo): Remove; unused.
4487 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4488 (signal_before_change): Remove decls.
4489
4490 * indent.c (val_compute_motion, val_vmotion): Now static.
4491
4492 * image.c: Make symbols static if they're not exported.
4493 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4494 if USE_GTK.
4495 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4496 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4497
4498 * fringe.c (standard_bitmaps): Now static.
4499 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4500
4501 * frame.c: Make symbols static if they're not exported.
4502 (x_report_frame_params, make_terminal_frame): Now static.
4503 (get_frame_param): Now static, unless HAVE_NS.
4504 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4505 (x_get_resource_string): Remove; not used.
4506 * frame.h (make_terminal_frame, x_report_frame_params):
4507 (x_get_resource_string); Remove decls.
4508 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4509 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4510
4511 * font.c, fontset.c: Make symbols static if they're not exported.
4512 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4513 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4514 * font.c (font_close_object): Now static.
4515 * font.h (font_close_object): Remove.
4516 * fontset.c (FONTSET_OBJLIST): Remove.
4517 (free_realized_fontset) #if-0 the body, which does nothing.
4518 (face_suitable_for_char_p): #if-0, as it's never called.
4519 * fontset.h (face_suitable_for_char_p): Remove decl.
4520 * xfaces.c (face_at_string_position):
4521 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4522 since 0 is always ASCII.
4523
4524 * fns.c (weak_hash_tables): Now static.
4525
4526 * fileio.c: Make symbols static if they're not exported.
4527 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4528 (Vwrite_region_annotation_buffers): Now static.
4529
4530 * eval.c: Make symbols static if they're not exported.
4531 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4532 * lisp.h (backtrace_list): Remove decl.
4533
4534 * emacs.c: Make symbols static if they're not exported.
4535 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4536 (fatal_error_code, fatal_error_signal_hook, standard_args):
4537 Now static.
4538 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4539 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4540 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4541 * lisp.h (fatal_error_signal_hook): Remove decl.
4542 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4543
4544 * editfns.c: Move a (normally-unused) function to its only use.
4545 * editfns.c, lisp.h (get_operating_system_release): Remove.
4546 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4547 worth the hassle of breaking this out.
4548
4549 * xterm.c: Make symbols static if they're not exported.
4550 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4551 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4552 (x_destroy_window, x_delete_display):
4553 Now static.
4554 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4555 (x_mouse_leave): Remove; unused.
4556 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4557 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4558 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4559 Remove decls.
4560 (x_mouse_leave): Declare only if WINDOWSNT.
4561 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4562 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4563 USE_X_TOOLKIT.
4564
4565 * ftxfont.c: Make symbols static if they're not exported.
4566 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4567 HAVE_FREETYPE.
4568 * font.h (ftxfont_driver): Likewise.
4569
4570 * xfns.c: Make symbols static if they're not exported.
4571 (x_last_font_name, x_display_info_for_name):
4572 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4573 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4574 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4575 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4576 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4577 (last_show_tip_args): Now static.
4578 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4579 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4580 (x_screen_planes): Remove; unused.
4581 * dispextern.h (x_screen_planes): Remove decl.
4582
4583 * dispnew.c: Make symbols static if they're not exported.
4584 * dispextern.h (redraw_garbaged_frames, scrolling):
4585 (increment_row_positions): Remove.
4586 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4587 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4588 Now static.
4589 (redraw_garbaged_frames): Remove; unused.
4590
4591 * xfaces.c: Make symbols static if they're not exported.
4592 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4593 Remove decls.
4594 * xterm.h (defined_color): Remove decls.
4595 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4596 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4597 (menu_face_changed_default, defined_color, free_realized_face):
4598 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4599 (ascii_face_of_lisp_face): Remove; unused.
4600
4601 * xdisp.c: Make symbols static if they're not exported.
4602 * dispextern.h (scratch_glyph_row, window_box_edges):
4603 (glyph_to_pixel_coords, set_cursor_from_row):
4604 (get_next_display_element, set_iterator_to_next):
4605 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4606 (show_mouse_face): Remove decls
4607 * frame.h (message_buf_print): Likewise.
4608 * lisp.h (pop_message, set_message, check_point_in_composition):
4609 Likewise.
4610 * xterm.h (set_vertical_scroll_bar): Likewise.
4611 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4612 (message_buf_print, scratch_glyph_row, displayed_buffer):
4613 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4614 (get_next_display_element, show_mouse_face, window_box_edges):
4615 (frame_to_window_pixel_xy, check_point_in_composition):
4616 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4617 (glyph_to_pixel_coords): Remove; unused.
4618
4619 * dired.c (file_name_completion): Now static.
4620
4621 * dbusbind.c (xd_in_read_queued_messages): Now static.
4622
4623 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4624 * data.c (circular_list_error): Remove.
4625
4626 * commands.h (last_point_position, last_point_position_buffer):
4627 (last_point_position_window): Remove decls.
4628 * keyboard.c: Make these variables static.
4629
4630 * coding.h (coding, code_convert_region, encode_coding_gap):
4631 Remove decls.
4632 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4633 (iso_code_class, detect_coding, code_convert_region): Now static.
4634 (encode_coding_gap): Remove; unused.
4635
4636 * chartab.c (chartab_chars, chartab_bits): Now static.
4637
4638 * charset.h (charset_iso_8859_1): Remove decl.
4639 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4640 Now static.
4641
4642 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4643 * ccl.c (Vccl_program_table): Now static.
4644 (check_ccl_update): Remove; unused.
4645
4646 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4647 * category.h: ... from here.
4648 * category.c (check_category_table, set_category_set): Now static.
4649
4650 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4651 * lisp.h: Remove these decls.
4652
4653 * buffer.c (buffer_count): Remove unused var.
4654
4655 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4656 so that it's not optimized away.
4657 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4658 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4659 exported only to the debugger.
4660
4661 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4662 * atimer.h (run_all_atimers): Remove; not exported.
4663
4664 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4665 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4666 was inaccessible from Lisp.
4667 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4668 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4669
4670 alloc.c: Import and export fewer symbols, and remove unused items.
4671 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4672 is defined.
4673 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4674 it's not optimized away by whole-program optimization.
4675 (message_enable_multibyte, free_misc): Remove.
4676 (catchlist, handlerlist, mark_backtrace):
4677 Declare only if BYTE_MARK_STACK.
4678 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4679 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4680 (message_enable_multibyte): Remove decl.
4681 (free_misc, interval_free_list, float_block, float_block_index):
4682 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4683 (cons_free_list, last_marked_index):
4684 Now static.
4685 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4686 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4687 (mark_backtrace): Define only if BYTE_MARK_STACK.
4688 * xdisp.c (message_enable_multibyte): Now static.
4689
4690 Declare Lisp_Object Q* variables to be 'static' if not exported.
4691 This makes it easier for human readers (and static analyzers)
4692 to see whether these variables are used from other modules.
4693 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4694 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4695 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4696 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4697 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4698 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4699 * xmenu.c, xselect.c:
4700 Declare Q* vars static if they are not used in other modules.
4701 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4702 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4703 Remove decls of unexported vars.
4704 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4705
4706 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4707
4708 Make Emacs functions such as Fatom 'static' by default.
4709 This makes it easier for human readers (and static analyzers)
4710 to see whether these functions can be called from other modules.
4711 DEFUN now defines a static function. To make the function external
4712 so that it can be used in other C modules, use the new macro DEFUE.
4713 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4714 (Finit_image_library):
4715 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4716 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4717 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4718 Remove decls, since these functions are now static.
4719 (Funintern, Fget_internal_run_time): New decls, since these functions
4720 were already external.
4721
4722 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4723 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4724 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4725 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4726 * keyboard.c, keymap.c, lread.c:
4727 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4728 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4729 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4730 Mark functions with DEFUE instead of DEFUN,
4731 if they are used in other modules.
4732 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4733 decls for now-static functions.
4734 * buffer.h (Fdelete_overlay): Remove decl.
4735 * callproc.c (Fgetenv_internal): Mark as internal.
4736 * composite.c (Fremove_list_of_text_properties): Remove decl.
4737 (Fcomposition_get_gstring): New forward static decl.
4738 * composite.h (Fcomposite_get_gstring): Remove decl.
4739 * dired.c (Ffile_attributes): New forward static decl.
4740 * doc.c (Fdocumntation_property): New forward static decl.
4741 * eval.c (Ffetch_bytecode): New forward static decl.
4742 (Funintern): Remove extern decl; now in .h file where it belongs.
4743 * fileio.c (Fmake_symbolic_link): New forward static decl.
4744 * image.c (Finit_image_library): New forward static decl.
4745 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4746 * intervals.h (Fprevious_property_change):
4747 (Fremove_list_of_text_properties): Remove decls.
4748 * keyboard.c (Fthis_command_keys): Remove decl.
4749 (Fcommand_execute): New forward static decl.
4750 * keymap.c (Flookup_key): New forward static decl.
4751 (Fcopy_keymap): Now static.
4752 * keymap.h (Flookup_key): Remove decl.
4753 * process.c (Fget_process): New forward static decl.
4754 (Fprocess_datagram_address): Mark as internal.
4755 * syntax.c (Fsyntax_table_p): New forward static decl.
4756 (skip_chars): Remove duplicate decl.
4757 * textprop.c (Fprevious_property_change): New forward static decl.
4758 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4759 Now internal.
4760 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4761 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4762
4763 * editfns.c (Fformat): Remove unreachable code.
4764
4765 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4766
4767 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4768 change. (Bug#8496)
4769
4770 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4771
4772 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4773 when at ZV. (Bug#8487)
4774
4775 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4776
4777 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4778 (Bug#8437)
4779 * keyboard.c (parse_tool_bar_item): Likewise.
4780 * sound.c (sound_cleanup, alsa_close): Likewise.
4781 * termcap.c (tgetent): Likewise.
4782 * xfns.c (x_default_font_parameter): Likewise.
4783 * xsettings.c (read_and_apply_settings): Likewise.
4784
4785 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4786 (overrun_check_free): Protoize.
4787
4788 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4791 since callers should never pass a negative size.
4792 Change the signature to match that of plain 'read' and 'write'; see
4793 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4794 * lisp.h: Update prototypes of emacs_write and emacs_read.
4795
4796 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4797
4798 * xdisp.c (redisplay_window): Don't try to determine the character
4799 position of the scroll margin if the window start point w->startp
4800 is outside the buffer's accessible region. (Bug#8468)
4801
4802 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4803
4804 Fix write-region and its subroutines for buffers > 2GB.
4805 * fileio.c (a_write, e_write): Modify declaration of arguments and
4806 local variables to support buffers larger than 2GB.
4807 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4808
4809 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4810 argument, local variables, and return value.
4811
4812 * lisp.h: Update prototypes of emacs_write and emacs_read.
4813
4814 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4815
4816 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4817
4818 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4819
4820 Fix more problems found by GCC 4.6.0's static checks.
4821
4822 * xdisp.c (vmessage): Use a better test for character truncation.
4823
4824 * charset.c (load_charset_map): <, not <=, for optimization,
4825 and to avoid potential problems with integer overflow.
4826 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4827 * casetab.c (set_identity, shuffle): Likewise.
4828 * editfns.c (Fformat): Likewise.
4829 * syntax.c (skip_chars): Likewise.
4830
4831 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4832 This also lets GCC 4.6.0 generate slightly better loop code.
4833
4834 * callint.c (Fcall_interactively): <, not <=, for optimization.
4835 (Fcall_interactively): Count the number of arguments produced,
4836 not the number of arguments given. This is simpler and lets GCC
4837 4.6.0 generate slightly better code.
4838
4839 * ftfont.c: Distingish more carefully between FcChar8 and char.
4840 The previous code passed unsigned char * to a functions like
4841 strlen and xstrcasecmp that expect char *, which does not
4842 conform to the C standard.
4843 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4844 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4845 char * when the C standard requires it.
4846
4847 * keyboard.c (read_char): Remove unused var.
4848
4849 * eval.c: Port to Windows vsnprintf (Bug#8435).
4850 Include <limits.h>.
4851 (SIZE_MAX): Define if the headers do not.
4852 (verror): Do not give up if vsnprintf returns a negative count.
4853 Instead, grow the buffer. This ports to Windows vsnprintf, which
4854 does not conform to C99. Problem reported by Eli Zaretskii.
4855 Also, simplify the allocation scheme, by avoiding the need for
4856 calling realloc, and removing the ALLOCATED variable.
4857
4858 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4859
4860 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4861 But keep the doprint source code for now, as we might revamp it
4862 and use it again (Bug#8435).
4863 * lisp.h (doprnt): Remove.
4864 * Makefile.in (base_obj): Remove doprnt.o.
4865 * deps.mk (doprnt.o): Remove.
4866
4867 error: Print 32- and 64-bit integers portably (Bug#8435).
4868 Without this change, on typical 64-bit hosts error ("...%d...", N)
4869 was used to print both 32- and 64-bit integers N, which relied on
4870 undefined behavior.
4871 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4872 New macro.
4873 * lisp.h (error, verror): Mark as printf-like functions.
4874 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4875 Report overflow in size calculations when allocating printf buffer.
4876 Do not truncate output string at its first null byte.
4877 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4878 Truncate the output at a character boundary, since vsnprintf does not
4879 do that.
4880 * charset.c (check_iso_charset_parameter): Convert internal
4881 character to string before calling 'error', since %c now has the
4882 printf meaning.
4883 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4884 overflow when computing char to be passed to 'error'. Do not
4885 pass Lisp_Object to 'error'; pass the integer instead.
4886 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4887 formatted with plain %d.
4888
4889 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4890
4891 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4892
4893 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4894
4895 * xterm.c (x_catch_errors): Remove duplicate declaration.
4896
4897 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4898
4899 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4900
4901 2011-04-10 Jim Meyering <meyering@redhat.com>
4902
4903 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4904 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4905 return ssize_t not "int", and use size_t as the buffer length.
4906 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4907 * gnutls.h: Update declarations.
4908 * process.c (read_process_output): Use ssize_t, to match.
4909 (send_process): Likewise.
4910
4911 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4912
4913 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4914
4915 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4916
4917 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4918 Use unsigned char, to match FcChar8 type definition.
4919
4920 * xterm.c (handle_one_xevent):
4921 * xmenu.c (create_and_show_popup_menu):
4922 * xselect.c (x_decline_selection_request)
4923 (x_reply_selection_request): Avoid type-punned deref of X events.
4924
4925 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4926
4927 Fix some uses of `int' instead of EMACS_INT.
4928 * search.c (string_match_1, fast_string_match)
4929 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4930 (scan_buffer, find_next_newline_no_quit)
4931 (find_before_next_newline, search_command, Freplace_match)
4932 (Fmatch_data): Make some `int' variables be EMACS_INT.
4933
4934 * xdisp.c (display_count_lines): 3rd argument and return value now
4935 EMACS_INT. All callers changed.
4936 (pint2hrstr): Last argument is now EMACS_INT.
4937
4938 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4939 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4940 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4941 (decode_coding_utf_16, decode_coding_emacs_mule)
4942 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4943 (decode_coding_ccl, decode_coding_charset)
4944 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4945 (decode_coding_iso_2022, decode_coding_emacs_mule)
4946 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4947 <char_offset, last_offset>: Declare EMACS_INT.
4948 (encode_coding_utf_8, encode_coding_utf_16)
4949 (encode_coding_emacs_mule, encode_invocation_designation)
4950 (encode_designation_at_bol, encode_coding_iso_2022)
4951 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4952 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4953 Declare EMACS_INT.
4954 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4955 (encode_invocation_designation): Last argument P_NCHARS is now
4956 EMACS_INT.
4957 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4958 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4959
4960 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4961 All users changed.
4962
4963 * ccl.c (Fccl_execute_on_string): Declare some variables
4964 EMACS_INT.
4965
4966 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4967
4968 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4969
4970 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4971
4972 * process.c (Fformat_network_address): Doc fix.
4973
4974 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4975
4976 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4977
4978 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4979
4980 * keyboard.c (read_char): Call Lisp function help-form-show,
4981 instead of using internal_with_output_to_temp_buffer.
4982 (Qhelp_form_show): New var.
4983 (syms_of_keyboard): Use DEFSYM macro.
4984
4985 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4986
4987 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4988
4989 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4990
4991 * process.c (Flist_processes): Remove to Lisp.
4992 (list_processes_1): Delete.
4993
4994 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4995
4996 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4997
4998 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4999
5000 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5001
5002 Fix more problems found by GCC 4.6.0's static checks.
5003
5004 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5005
5006 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5007
5008 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5009
5010 * xdisp.c (vmessage): Mark as a printf-like function.
5011
5012 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5013
5014 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5015
5016 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5017 printf-like functions.
5018 (tiff_load): Add casts to remove these marks before passing them
5019 to system-supplied API.
5020
5021 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5022
5023 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5024 This avoids several warnings with gcc -Wstrict-overflow.
5025 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5026 directly, rather than having caller test rule sign. This avoids
5027 some unnecessary tests.
5028 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5029 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5030 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5031
5032 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5033 (xfont_open): Avoid unnecessary tests.
5034
5035 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5036
5037 * composite.h, composite.c (composition_gstring_put_cache):
5038 Use EMACS_INT, not int, for length.
5039
5040 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5041 breaking out part of COMPOSITION_DECODE_RULE.
5042 (COMPOSITION_DECODE_RULE): Use it.
5043 * composite.c (get_composition_id): Remove unused local vars,
5044 by using the new macro.
5045
5046 * textprop.c (set_text_properties_1): Change while to do-while,
5047 since the condition is always true at first.
5048
5049 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5050 (interval_deletion_adjustment): Return unsigned value.
5051 All uses changed.
5052
5053 * process.c (list_processes_1, create_pty, read_process_output):
5054 (exec_sentinel): Remove vars that were set but not used.
5055 (create_pty): Remove unnecessary "volatile"s.
5056 (Fnetwork_interface_info): Avoid possibility of int overflow.
5057 (read_process_output): Do adaptive read buffering even if carryover.
5058 (read_process_output): Simplify nbytes computation if buffered.
5059
5060 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5061
5062 * syntax.c (scan_words): Remove var that was set but not used.
5063 (update_syntax_table): Use unsigned instead of int.
5064
5065 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5066 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5067 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5068
5069 * print.c (print_error_message): Avoid int overflow.
5070
5071 * font.c (font_list_entities): Redo for clarity,
5072 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5073
5074 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5075 (font_score): Avoid potential overflow in diff calculation.
5076
5077 * fns.c (substring_both): Remove var that is set but not used.
5078 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5079
5080 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5081
5082 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5083 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5084 can always succeed if overflow has undefined behavior.
5085
5086 * search.c (boyer_moore, wordify): Remove vars set but not used.
5087 (wordify): Omit three unnecessary tests.
5088
5089 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5090 All callers changed. This avoids the need for an unused var.
5091
5092 * casefiddle.c (casify_region): Remove var that is set but not used.
5093
5094 * dired.c (file_name_completion): Remove var that is set but not used.
5095
5096 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5097
5098 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5099 (Finsert_file_contents): Remove unnecessary code checking fd.
5100
5101 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5102 Check for integer overflow on size calculations.
5103
5104 * buffer.c (Fprevious_overlay_change): Remove var that is set
5105 but not used.
5106
5107 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5108 Remove vars that are set but not used.
5109 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5110 (timer_check_2): Mark vars as initialized.
5111
5112 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5113
5114 * image.c (lookup_image): Remove var that is set but not used.
5115 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5116
5117 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5118 that are set but not used.
5119
5120 * xfns.c (make_invisible_cursor): Don't return garbage
5121 if XCreateBitmapFromData fails (Bug#8410).
5122
5123 * xselect.c (x_get_local_selection, x_handle_property_notify):
5124 Remove vars that are set but not used.
5125
5126 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5127 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5128
5129 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5130 Remove var that is set but not used.
5131 (scroll_bar_windows_size): Now size_t, not int.
5132 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5133 Check for overflow.
5134
5135 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5136 (map_tty_color) [!defined MSDOS]: Likewise.
5137
5138 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5139
5140 * coding.c: Remove vars that are set but not used.
5141 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5142 All callers changed.
5143 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5144 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5145 (decode_coding_charset): Remove vars that are set but not used.
5146
5147 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5148 that is set but not used.
5149
5150 * print.c (print_object): Remove var that is set but not used.
5151
5152 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5153 The gnulib version avoids calling malloc in the usual case,
5154 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5155 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5156 * filelock.c (current_lock_owner): Likewise.
5157 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5158 * sysdep.c: Include allocator.h, careadlinkat.h.
5159 (emacs_no_realloc_allocator): New static constant.
5160 (emacs_readlink): New function.
5161 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5162 ../lib/careadlinkat.h.
5163
5164 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5165
5166 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5167 first non-nil return value).
5168
5169 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5170
5171 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5172 if not defined (Bug#8403).
5173
5174 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5175
5176 * xdisp.c (display_count_lines): Remove parameter `start',
5177 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5178 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5179 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5180 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5181 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5182 and thereabouts. All callers changed.
5183 (get_per_char_metric): Remove parameter `f', unused since
5184 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5185
5186 2011-04-02 Jim Meyering <meyering@redhat.com>
5187
5188 do not dereference NULL upon failed strdup
5189 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5190 (ns_get_family): Likewise.
5191
5192 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5193
5194 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5195
5196 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5197
5198 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5199 later (Bug#8403).
5200
5201 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5202
5203 Add lexical binding.
5204
5205 * window.c (Ftemp_output_buffer_show): New fun.
5206 (Fsave_window_excursion):
5207 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5208
5209 * lread.c (lisp_file_lexically_bound_p): New function.
5210 (Fload): Bind Qlexical_binding.
5211 (readevalloop): Remove `evalfun' arg.
5212 Bind Qinternal_interpreter_environment.
5213 (Feval_buffer): Bind Qlexical_binding.
5214 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5215 Mark as dynamic.
5216 (syms_of_lread): Declare `lexical-binding'.
5217
5218 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5219
5220 * keyboard.c (eval_dyn): New fun.
5221 (menu_item_eval_property): Use it.
5222
5223 * image.c (parse_image_spec): Use Ffunctionp.
5224
5225 * fns.c (concat, mapcar1): Accept byte-code-functions.
5226
5227 * eval.c (Fsetq): Handle lexical vars.
5228 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5229 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5230 (FletX, Flet): Obey lexical binding.
5231 (Fcommandp): Handle closures.
5232 (Feval): New `lexical' arg.
5233 (eval_sub): New function extracted from Feval. Use it almost
5234 everywhere where Feval was used. Look up vars in lexical env.
5235 Handle closures.
5236 (Ffunctionp): Move from subr.el.
5237 (Ffuncall): Handle closures.
5238 (apply_lambda): Remove `eval_flags'.
5239 (funcall_lambda): Handle closures and new byte-code-functions.
5240 (Fspecial_variable_p): New function.
5241 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5242 but without exporting it to Lisp.
5243
5244 * doc.c (Fdocumentation, store_function_docstring):
5245 * data.c (Finteractive_form): Handle closures.
5246
5247 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5248 interactive spec.
5249
5250 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5251 New byte-codes.
5252 (exec_byte_code): New function extracted from Fbyte_code to handle new
5253 calling convention for byte-code-functions. Add new byte-codes.
5254
5255 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5256
5257 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5258
5259 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5260
5261 * xdisp.c (redisplay_internal): Fix prototype.
5262
5263 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5264
5265 * xdisp.c (SCROLL_LIMIT): New macro.
5266 (try_scrolling): Use it when setting scroll_limit.
5267 Limit scrolling to 100 screen lines.
5268 (redisplay_window): Even when falling back on "recentering",
5269 position point in the window according to scroll-conservatively,
5270 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5271
5272 (try_scrolling): When point is above the window, allow searching
5273 as far as scroll_max, or one screenful, to compute vertical
5274 distance from PT to the scroll margin position. This prevents
5275 try_scrolling from unnecessarily failing when
5276 scroll-conservatively is set to a value slightly larger than the
5277 window height. Clean up the case of PT below the margin at bottom
5278 of window: scroll_max can no longer be INT_MAX. When aggressive
5279 scrolling is in use, don't let point enter the opposite scroll
5280 margin as result of the scroll.
5281 (syms_of_xdisp) <scroll-conservatively>: Document the
5282 threshold of 100 lines for never-recentering scrolling.
5283
5284 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5285
5286 * dispextern.h (move_it_by_lines):
5287 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5288 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5289 (message_log_check_duplicate): Remove parameters `prev_bol' and
5290 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5291 (redisplay_internal): Remove parameter `preserve_echo_area',
5292 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5293
5294 * indent.c (Fvertical_motion):
5295 * window.c (window_scroll_pixel_based, Frecenter):
5296 Don't pass `need_y_p' to `move_it_by_lines'.
5297
5298 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5299
5300 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5301 steal a few bits to be more compact.
5302 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5303 Remove unneeded casts.
5304
5305 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5306
5307 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5308
5309 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5310 binding" message (bug#7967).
5311
5312 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5313
5314 Fix more problems found by GCC 4.6.0's static checks.
5315
5316 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5317 Remove unused local var.
5318
5319 * editfns.c (Fmessage_box): Remove unused local var.
5320
5321 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5322 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5323 Omit unused local vars.
5324 * window.c (shrink_windows): Omit unused local var.
5325 * menu.c (digest_single_submenu): Omit unused local var.
5326 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5327 Omit unused local var.
5328
5329 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5330 Don't assume string length fits in int.
5331 (keyremap_step, read_key_sequence): Use size_t for sizes.
5332 (read_key_sequence): Don't check last_real_key_start redundantly.
5333
5334 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5335 instead of alloca (Bug#8344).
5336
5337 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5338 (Fbacktrace_frame): Don't assume nframes fits in int.
5339
5340 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5341
5342 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5343 concerns.
5344
5345 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5346
5347 * cm.c (calccost): Turn while-do into do-while, for clarity.
5348
5349 * keyboard.c (syms_of_keyboard): Use the same style as later
5350 in this function when indexing through an array. This also
5351 works around GCC bug 48267.
5352
5353 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5354
5355 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5356
5357 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5358 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5359
5360 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5361 This avoids undefined behavior on integer overflow, and is a bit
5362 more convenient anyway since it is compared to a size_t variable.
5363
5364 Variadic C functions now count arguments with size_t, not int.
5365 This avoids an unnecessary limitation on 64-bit machines, which
5366 caused (substring ...) to crash on large vectors (Bug#8344).
5367 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5368 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5369 All variadic functions and their callers changed accordingly.
5370 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5371 * data.c (arith_driver, float_arith_driver): Likewise.
5372 * editfns.c (general_insert_function): Likewise.
5373 * eval.c (struct backtrace.nargs, interactive_p)
5374 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5375 (funcall_lambda, mark_backtrace): Likewise.
5376 * fns.c (concat): Likewise.
5377 * frame.c (x_set_frame_parameters): Likewise.
5378 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5379 0 if not found, not -1. All callers changed.
5380
5381 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5382 (stack_copy_size): Now size_t, not int.
5383 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5384
5385 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5386
5387 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5388 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5389 All callers changed.
5390
5391 * lisp.h (multibyte_char_to_unibyte):
5392 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5393 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5394 * character.h (CHAR_TO_BYTE8):
5395 * cmds.c (internal_self_insert):
5396 * editfns.c (general_insert_function):
5397 * keymap.c (push_key_description):
5398 * search.c (Freplace_match):
5399 * xdisp.c (message_dolog, set_message_1): All callers changed.
5400
5401 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5402
5403 * keyboard.c (safe_run_hook_funcall): New function.
5404 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5405 don't set the hook to nil, but remove the offending function instead.
5406 (Qcommand_hook_internal): Remove, unused.
5407 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5408 Vcommand_hook_internal.
5409
5410 * eval.c (enum run_hooks_condition): Remove.
5411 (funcall_nil, funcall_not): New functions.
5412 (run_hook_with_args): Call each function through a `funcall' argument.
5413 Remove `cond' argument, now redundant.
5414 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5415 (Frun_hook_with_args_until_failure): Adjust accordingly.
5416 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5417
5418 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5419
5420 * dispextern.h (string_buffer_position): Remove declaration.
5421
5422 * print.c (strout): Remove parameter `multibyte', unused since
5423 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5424
5425 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5426 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5427 All callers changed.
5428
5429 * w32.c (_wsa_errlist): Use braces for struct initializers.
5430
5431 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5432 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5433 All callers changed.
5434 (string_buffer_position): Likewise. Also, make static (it's never
5435 used outside xdisp.c).
5436 (cursor_row_p): Remove parameter `w', unused since
5437 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5438 (decode_mode_spec): Remove parameter `precision', introduced during
5439 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5440 All callers changed.
5441
5442 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5443
5444 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5445
5446 2011-03-27 Anders Lindgren <andlind@gmail.com>
5447
5448 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5449 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5450 (ns_update_auto_hide_menu_bar): New functions.
5451 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5452 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5453 ns_constrain_all_frames.
5454 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5455 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5456
5457 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5458
5459 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5460
5461 2011-03-27 Glenn Morris <rgm@gnu.org>
5462
5463 * syssignal.h: Replace RETSIGTYPE with void.
5464 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5465 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5466 Replace SIGTYPE with void everywhere.
5467 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5468 * s/template.h (SIGTYPE): Remove commented out definition.
5469
5470 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5471
5472 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5473 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5474
5475 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5476
5477 * w32.c (read_unc_volume): Use parameter `henum', instead of
5478 global variable `wget_enum_handle'.
5479
5480 * keymap.c (describe_vector): Remove parameters `indices' and
5481 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5482 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5483
5484 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5485
5486 * keyboard.c (timer_check): Remove parameter `do_it_now',
5487 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5488 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5489 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5490
5491 * keyboard.c (read_char):
5492 * w32menu.c (w32_menu_display_help):
5493 * xmenu.c (show_help_event, menu_help_callback):
5494 Adjust calls to `show_help_echo'.
5495
5496 * gtkutil.c (xg_maybe_add_timer):
5497 * keyboard.c (readable_events):
5498 * process.c (wait_reading_process_output):
5499 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5500
5501 * insdel.c (adjust_markers_gap_motion):
5502 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5503 (gap_left, gap_right): Don't call it.
5504
5505 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5506
5507 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5508 incurred during fontification.
5509
5510 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5511
5512 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5513 (DEFVAR_PER_BUFFER): Don't pass it.
5514
5515 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5516 (scrolling_window): Don't pass it.
5517
5518 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5519
5520 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5521
5522 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5523 and `suffix'.
5524 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5525 of variables specific to SELinux and computation of `encoded_absname'.
5526
5527 * image.c (XPutPixel): Remove unused variable `height'.
5528
5529 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5530
5531 * unexw32.c (get_section_info): Remove unused variable `section'.
5532
5533 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5534 (system_process_attributes): Remove unused variable `sess'.
5535 (sys_read): Remove unused variable `err'.
5536
5537 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5538 (w32_wnd_proc): Remove unused variable `isdead'.
5539 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5540 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5541 (x_create_tip_frame): Remove unused variable `tem'.
5542
5543 * w32inevt.c (w32_console_read_socket):
5544 Remove unused variable `no_events'.
5545
5546 * w32term.c (x_draw_composite_glyph_string_foreground):
5547 Remove unused variable `width'.
5548
5549 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5550
5551 * w32term.c (x_set_glyph_string_clipping):
5552 Don't pass uninitialized region to CombineRgn.
5553
5554 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5555
5556 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5557 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5558 (Fx_close_connection): Remove unused variable `i'.
5559
5560 * w32font.c (w32font_draw): Return number of glyphs.
5561 (w32font_open_internal): Remove unused variable `i'.
5562 (w32font_driver): Add missing initializer.
5563
5564 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5565 (fill_in_menu): Remove unused variable `items_added'.
5566
5567 * w32term.c (last_mouse_press_frame): Remove static global variable.
5568 (w32_clip_to_row): Remove unused variable `f'.
5569 (x_delete_terminal): Remove unused variable `i'.
5570
5571 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5572 (NOTHING): Remove unused static global variable.
5573 (uniscribe_check_otf): Remove unused variable `table'.
5574 (uniscribe_font_driver): Add missing initializers.
5575
5576 2011-03-23 Julien Danjou <julien@danjou.info>
5577
5578 * term.c (Fsuspend_tty, Fresume_tty):
5579 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5580 * window.c (temp_output_buffer_show):
5581 * insdel.c (signal_before_change):
5582 * frame.c (Fhandle_switch_frame):
5583 * fileio.c (Fdo_auto_save):
5584 * emacs.c (Fkill_emacs):
5585 * editfns.c (save_excursion_restore):
5586 * cmds.c (internal_self_insert):
5587 * callint.c (Fcall_interactively):
5588 * buffer.c (Fkill_all_local_variables):
5589 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5590 Use Frun_hooks.
5591 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5592 unconditionnaly since it does the check itself.
5593
5594 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5595
5596 Fix more problems found by GCC 4.5.2's static checks.
5597
5598 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5599 the first time through the loop, since we know p0 < p1 then.
5600 This also avoids a gcc -Wstrict-overflow warning.
5601
5602 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5603 leading to a memory leak, possible in functions like
5604 load_charset_map_from_file that can allocate an unbounded number
5605 of objects (Bug#8318).
5606
5607 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5608 that could (at least in theory) be that large.
5609
5610 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5611 This is less likely to overflow, and avoids undefined behavior if
5612 overflow does occur. All callers changed. Use strtoul to scan
5613 for the unsigned long integer.
5614 (pint2hrstr): Simplify and tune code slightly.
5615 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5616
5617 * scroll.c (do_scrolling): Work around GCC bug 48228.
5618 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5619
5620 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5621 This also avoids a warning with gcc -Wstrict-overflow.
5622 (validate_x_resource_name): Simplify count usage.
5623 This also avoids a warning with gcc -Wstrict-overflow.
5624
5625 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5626 fail (Bug#8306).
5627
5628 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5629
5630 * process.c (Fmake_network_process): Use socklen_t, not int,
5631 where POSIX says socklen_t is required in portable programs.
5632 This fixes a porting bug on hosts like 64-bit HP-UX, where
5633 socklen_t is wider than int (Bug#8277).
5634 (Fmake_network_process, server_accept_connection):
5635 (wait_reading_process_output, read_process_output):
5636 Likewise.
5637
5638 * process.c: Rename or move locals to avoid shadowing.
5639 (list_processes_1, Fmake_network_process):
5640 (read_process_output_error_handler, exec_sentinel_error_handler):
5641 Rename or move locals.
5642 (Fmake_network_process): Define label "retry_connect" only if needed.
5643 (Fnetwork_interface_info): Fix pointer signedness.
5644 (process_send_signal): Add cast to avoid pointer signedness problem.
5645 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5646 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5647
5648 Make tparam.h and terminfo.c consistent.
5649 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5650 Include tparam.h instead, since it declares them.
5651 * cm.h (PC): Remove extern decl; tparam.h now does this.
5652 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5653 * terminfo.c: Include tparam.h, to check interfaces.
5654 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5655 (tparam): Adjust signature to match interface in tparam.h;
5656 this removes some undefined behavior. Check that outstring and len
5657 are zero, which they always are with Emacs.
5658 * tparam.h (PC, BC, UP): New extern decls.
5659
5660 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5661 (xftfont_open): Rename locals to avoid shadowing.
5662
5663 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5664 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5665 (OTF_TAG_SYM): Omit macro if not needed.
5666 (ftfont_list): Remove unused local.
5667 (get_adstyle_property, ftfont_pattern_entity):
5668 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5669 Rename locals to avoid shadowing.
5670
5671 * xfont.c (xfont_list_family): Mark var as initialized.
5672
5673 * xml.c (make_dom): Now static.
5674
5675 * composite.c (composition_compute_stop_pos): Rename local to
5676 avoid shadowing.
5677 (composition_reseat_it): Remove unused locals.
5678 (find_automatic_composition, composition_adjust_point): Likewise.
5679 (composition_update_it): Mark var as initialized.
5680 (find_automatic_composition): Mark vars as initialized,
5681 with a FIXME (Bug#8290).
5682
5683 character.h: Rename locals to avoid shadowing.
5684 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5685 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5686 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5687 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5688 to avoid shadowing.
5689
5690 * textprop.c (property_change_between_p): Remove; unused.
5691
5692 * intervals.c (interval_start_pos): Now static.
5693
5694 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5695
5696 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5697 Rename locals to avoid shadowing.
5698
5699 * sound.c (wav_play, au_play, Fplay_sound_internal):
5700 Fix pointer signedness.
5701 (alsa_choose_format): Remove unused local var.
5702 (wav_play): Initialize a variable to 0, to prevent undefined
5703 behavior (Bug#8278).
5704
5705 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5706
5707 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5708
5709 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5710 clobbering (Bug#8298).
5711 * sysdep.c (sys_subshell): Likewise.
5712 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5713
5714 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5715 This should get cleaned up, so that child_setup has the
5716 same signature on all platforms.
5717
5718 * callproc.c (call_process_cleanup): Now static.
5719 (relocate_fd): Rename locals to avoid shadowing.
5720
5721 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5722
5723 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5724 not to be necessary, and produces flickering.
5725
5726 2011-03-20 Glenn Morris <rgm@gnu.org>
5727
5728 * config.in: Remove file.
5729
5730 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5731
5732 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5733 are now in src/globals.h.
5734 (syms_of_minibuf): Remove spurious & from previous change.
5735
5736 2011-03-20 Leo <sdl.web@gmail.com>
5737
5738 * minibuf.c (completing-read-function): New variable.
5739 (completing-read-default): Rename from completing-read.
5740 (completing-read): Call completing-read-function.
5741
5742 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5743
5744 * xfaces.c (Fx_load_color_file):
5745 Read color file from absolute filename (bug#8250).
5746
5747 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5748
5749 * makefile.w32-in: Update dependencies.
5750
5751 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5752
5753 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5754
5755 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5756
5757 Fix more problems found by GCC 4.5.2's static checks.
5758
5759 * process.c (make_serial_process_unwind, send_process_trap):
5760 (sigchld_handler): Now static.
5761
5762 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5763 That way, the code declares only the vars that it needs.
5764 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5765 * s/cygwin.h (PTY_ITERATION): Likewise.
5766 * s/darwin.h (PTY_ITERATION): Likewise.
5767 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5768
5769 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5770 * process.c (allocate_pty): Don't declare stb unless it's needed.
5771
5772 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5773 (CONSTANTLIM): Remove; unused.
5774 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5775 Define only if needed.
5776
5777 * unexelf.c (unexec): Name an expression,
5778 to avoid gcc -Wbad-function-cast warning.
5779 Use a different way to cause a compilation error if anyone uses
5780 n rather than nn, a way that does not involve shadowing.
5781 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5782
5783 * deps.mk (unexalpha.o): Remove; unused.
5784
5785 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5786 * unexec.h: New file.
5787 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5788 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5789 Depend on unexec.h.
5790 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5791 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5792 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5793 Change as necessary to match prototype in unexec.h.
5794
5795 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5796 shadowing.
5797 (back_comment, skip_chars): Mark vars as initialized.
5798
5799 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5800 Rename locals to avoid shadowing.
5801
5802 * lread.c (read1): Rewrite so as not to use empty "else".
5803 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5804
5805 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5806
5807 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5808 warning when compiling print.c.
5809
5810 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5811 instead of using an uninitialized var.
5812 (font_sort_entities): Mark var as initialized.
5813
5814 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5815
5816 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5817 pointers to constants.
5818 (font_parse_fcname): Remove unused vars.
5819 (font_delete_unmatched): Now static.
5820 (font_get_spec): Remove; unused.
5821 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5822 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5823 Rename or move locals to avoid shadowing.
5824
5825 * fns.c (require_nesting_list, require_unwind): Now static.
5826 (Ffillarray): Rename locals to avoid shadowing.
5827
5828 * floatfns.c (domain_error2): Define only if needed.
5829 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5830
5831 * alloc.c (mark_backtrace): Move decl from here ...
5832 * lisp.h: ... to here, so that it can be checked.
5833
5834 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5835 (Fdefvar): Rewrite so as not to use empty "else".
5836 (lisp_indirect_variable): Name an expression,
5837 to avoid gcc -Wbad-function-cast warning.
5838 (Fdefvar): Rename locals to avoid shadowing.
5839
5840 * callint.c (quotify_arg, quotify_args): Now static.
5841 (Fcall_interactively): Rename locals to avoid shadowing.
5842 Use const pointer when appropriate.
5843
5844 * lisp.h (get_system_name, get_operating_system_release):
5845 Move decls here, to check interfaces.
5846 * process.c (get_operating_system_release): Move decl to lisp.h.
5847 * xrdb.c (get_system_name): Likewise.
5848 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5849 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5850 some of which prompt warnings from gcc -Wbad-function-cast.
5851 (Fformat_time_string, Fencode_time, Finsert_char):
5852 (Ftranslate_region_internal, Fformat):
5853 Rename or remove local vars to avoid shadowing.
5854 (Ftranslate_region_internal): Mark var as initialized.
5855
5856 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5857 avoid shadowing.
5858
5859 * lisp.h (eassert): Check that the argument compiles, even if
5860 ENABLE_CHECKING is not defined.
5861
5862 * data.c (Findirect_variable): Name an expression, to avoid
5863 gcc -Wbad-function-cast warning.
5864 (default_value, arithcompare, arith_driver, arith_error): Now static.
5865 (store_symval_forwarding): Rename local to avoid shadowing.
5866 (Fmake_variable_buffer_local, Fmake_local_variable):
5867 Mark variables as initialized.
5868 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5869
5870 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5871 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5872 Rename locals to avoid shadowing.
5873 (mark_stack): Move local variables into the #ifdef region where
5874 they're used.
5875 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5876 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5877 needed otherwise.
5878 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5879 (GC_STRING_CHARS): Remove; not used.
5880 (Fmemory_limit): Cast sbrk's returned value to char *.
5881
5882 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5883 avoids undefined behavior in theory.
5884
5885 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5886
5887 Use functions, not macros, for up- and down-casing (Bug#8254).
5888 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5889 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5890 to use the following functions instead of these macros.
5891 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5892 EMACS_INT, since callers assume the returned value fits in int.
5893 (upcase1): Likewise, for UPCASE_TABLE.
5894 (uppercasep, lowercasep, upcase): New static inline functions.
5895 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5896 the race-condition problem in the old DOWNCASE.
5897
5898 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5899 Rename locals to avoid shadowing.
5900 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5901 (regex_compile, re_search_2, re_match_2_internal):
5902 Remove unused local vars.
5903 (FREE_VAR): Rewrite so as not to use empty "else",
5904 which gcc can warn about.
5905 (regex_compile, re_match_2_internal): Mark locals as initialized.
5906 (RETALLOC_IF): Define only if needed.
5907 (WORDCHAR_P): Likewise. This one is never needed, but is used
5908 only in a comment talking about a compiler bug, so put inside
5909 the #if 0 of that comment.
5910 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5911 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5912 Remove; unused.
5913
5914 * search.c (boyer_moore): Rename locals to avoid shadowing.
5915 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5916 (PREV_CHAR_BOUNDARY): Likewise.
5917
5918 * search.c (simple_search): Remove unused var.
5919
5920 * dired.c (compile_pattern): Move decl from here ...
5921 * lisp.h: ... to here, so that it can be checked.
5922 (struct re_registers): New forward decl.
5923
5924 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5925
5926 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5927 All uses changed.
5928 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5929 Rename locals to avoid shadowing.
5930 (Fvertical_motion): Mark locals as initialized.
5931
5932 * casefiddle.c (casify_object, casify_region): Now static.
5933 (casify_region): Mark local as initialized.
5934
5935 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5936
5937 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5938 New macros, so that the caller can use some names other than
5939 gcpro1, gcpro2, etc.
5940 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5941 of the new macros.
5942 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5943 argument, for consistency with GCPRO2_VAR, etc: it is now the
5944 prefix of the variable, not the variable itself. All uses
5945 changed.
5946 * dired.c (directory_files_internal, file_name_completion):
5947 Rename locals to avoid shadowing.
5948
5949 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5950 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5951 dired.c's scmp function, had undefined behavior.
5952 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5953 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5954 * buffer.h: ... to here, because these macros use current_buffer,
5955 and the new implementation with inline functions needs to have
5956 current_buffer in scope now, rather than later when the macros
5957 are used.
5958 (downcase, upcase1): New static inline functions.
5959 (DOWNCASE, UPCASE1): Reimplement using these functions.
5960 This avoids undefined behavior in expressions like
5961 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5962 from race conditions in accessing the global variables
5963 case_temp1 and case_temp2.
5964 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5965 * lisp.h (case_temp1, case_temp2): Remove their decls.
5966 * character.h (ASCII_CHAR_P): Move from here ...
5967 * lisp.h: ... to here, so that the inline functions mentioned
5968 above can use them.
5969
5970 * dired.c (directory_files_internal_unwind): Now static.
5971
5972 * fileio.c (file_name_as_directory, directory_file_name):
5973 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5974 Now static.
5975 (file_name_as_directory): Use const pointers when appropriate.
5976 (Fexpand_file_name): Likewise. In particular, newdir might
5977 point at constant storage, so make it a const pointer.
5978 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5979 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5980 signedness issues.
5981 (Fset_file_times, Finsert_file_contents, auto_save_error):
5982 Rename locals to avoid shadowing.
5983
5984 * minibuf.c (choose_minibuf_frame_1): Now static.
5985 (Ftry_completion, Fall_completions): Rename or remove locals
5986 to avoid shadowing.
5987
5988 * marker.c (bytepos_to_charpos): Remove; unused.
5989
5990 * lisp.h (verify_bytepos, count_markers): New decls,
5991 so that gcc does not warn that these functions aren't declared.
5992
5993 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5994 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5995 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5996 (copy_text): Remove unused local var.
5997
5998 * filelock.c (within_one_second): Now static.
5999 (lock_file_1): Rename local to avoid shadowing.
6000
6001 * buffer.c (fix_overlays_before): Mark locals as initialized.
6002 (fix_start_end_in_overlays): Likewise. This function should be
6003 simplified by using pointers-to-pointers, but that's a different
6004 matter.
6005 (switch_to_buffer_1): Now static.
6006 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6007 (report_overlay_modification): Rename locals to avoid shadowing.
6008
6009 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6010 Fix pointer signedness issue.
6011 (sys_subshell): Mark local as volatile if checking for lint,
6012 to suppress a gcc -Wclobbered warning that does not seem to be right.
6013 (MAXPATHLEN): Define only if needed.
6014
6015 * process.c (serial_open, serial_configure): Move decls from here ...
6016 * systty.h: ... to here, so that they can be checked.
6017
6018 * fns.c (get_random, seed_random): Move extern decls from here ...
6019 * lisp.h: ... to here, so that they can be checked.
6020
6021 * sysdep.c (reset_io): Now static.
6022 (wait_for_termination_signal): Remove; unused.
6023
6024 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6025 (copy_keymap_item, append_key, push_text_char_description):
6026 Now static.
6027 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6028 (DENSE_TABLE_SIZE): Remove; unused.
6029 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6030 (describe_map_tree):
6031 Rename locals to avoid shadowing.
6032
6033 * keyboard.c: Declare functions static if they are not used elsewhere.
6034 (echo_char, echo_dash, cmd_error, top_level_2):
6035 (poll_for_input, handle_async_input): Now static.
6036 (read_char, kbd_buffer_get_event, make_lispy_position):
6037 (make_lispy_event, make_lispy_movement, apply_modifiers):
6038 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6039 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6040 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6041 (read_key_sequence, read_char): Mark locals as initialized.
6042 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6043
6044 * keyboard.h (make_ctrl_char): New decl.
6045 (mark_kboards): Move decl here ...
6046 * alloc.c (mark_kboards): ... from here.
6047
6048 * lisp.h (force_auto_save_soon): New decl.
6049
6050 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6051 (DEFINE_DUMMY_FUNCTION): New macro.
6052 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6053 Use it.
6054 (main): Add casts to avoid warnings
6055 if GCC considers string literals to be constants.
6056
6057 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6058
6059 * dbusbind.c: Pointer signedness fixes.
6060 (xd_signature, xd_append_arg, xd_initialize):
6061 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6062 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6063 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6064 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6065
6066 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6067 if GCC considers string literals to be constants.
6068 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6069
6070 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6071
6072 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6073 (print_preprocess, print_object): New macro to fix last change.
6074
6075 * print.c (print_preprocess): Don't forget font objects.
6076
6077 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6078
6079 * emacs.c (USAGE3): Doc fixes.
6080
6081 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6082
6083 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6084 structure.
6085
6086 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6087
6088 * lisp.h (VWindow_system, Qfile_name_history):
6089 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6090 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6091 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6092
6093 * w32select.c: Don't #include "keyboard.h".
6094 (run_protected): Add extern declaration for waiting_for_input.
6095
6096 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6097 * w32console.c (detect_input_pending, read_input_pending)
6098 (encode_terminal_code):
6099 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6100 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6101 (w32_system_caret_y, Qfile_name_history):
6102 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6103 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6104 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6105 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6106 * w32proc.c (Qlocal, report_file_error):
6107 * w32term.c (Vwindow_system, updating_frame):
6108 * w32uniscribe.c (initialized, uniscribe_font_driver):
6109 Remove unneeded extern declarations.
6110
6111 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6112
6113 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6114
6115 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6116
6117 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6118 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6119 These macros can no longer be used for assignment.
6120
6121 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6122 Assign struct members directly, instead of using BUF_BEGV etc.
6123 (record_buffer_markers, fetch_buffer_markers): New functions for
6124 recording and fetching special buffer markers.
6125 (set_buffer_internal_1, set_buffer_temp): Use them.
6126
6127 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6128
6129 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6130
6131 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6132 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6133
6134 * xdisp.c (hscroll_window_tree):
6135 (reconsider_clip_changes): Use PT instead of BUF_PT.
6136
6137 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6138
6139 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6140 $(EMACS_ROOT)/lib/intprops.h.
6141
6142 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6143
6144 Fix more problems found by GCC 4.5.2's static checks.
6145
6146 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6147 to unsigned char * to avoid compiler diagnostic.
6148 (xg_free_frame_widgets): Make it clear that a local variable is
6149 needed only if USE_GTK_TOOLTIP.
6150 (gdk_window_get_screen): Make it clear that this macro is needed
6151 only if USE_GTK_TOOLTIP.
6152 (int_gtk_range_get_value): New function, which avoids a diagnostic
6153 from gcc -Wbad-function-cast.
6154 (xg_set_toolkit_scroll_bar_thumb): Use it.
6155 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6156 diagnostic from gcc -Wbad-function-cast.
6157 (get_utf8_string, xg_get_file_with_chooser):
6158 Rename locals to avoid shadowing.
6159 (create_dialog): Move locals to avoid shadowing.
6160
6161 * xgselect.c (xg_select): Remove unused var.
6162
6163 * image.c (four_corners_best): Mark locals as initialized.
6164 (gif_load): Initialize transparent_p to zero (Bug#8238).
6165 Mark another local as initialized.
6166 (my_png_error, my_error_exit): Mark with NO_RETURN.
6167
6168 * image.c (clear_image_cache): Now static.
6169 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6170 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6171 (x_edge_detection): Remove unnecessary cast that
6172 gcc -Wbad-function-cast diagnoses.
6173 (gif_load): Fix pointer signedness.
6174 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6175 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6176
6177 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6178
6179 Improve quality of tests for time stamp overflow.
6180 For example, without this patch (encode-time 0 0 0 1 1
6181 1152921504606846976) returns the obviously-bogus value (-948597
6182 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6183 reports time overflow. See
6184 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6185 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6186 * editfns.c: Include limits.h and intprops.h.
6187 (TIME_T_MIN, TIME_T_MAX): New macros.
6188 (time_overflow): Move earlier, to before first use.
6189 (hi_time, lo_time): New functions, for an accurate test for
6190 out-of-range times.
6191 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6192 (Fget_internal_run_time): Don't assume time_t fits in int.
6193 (make_time): Use list2 instead of Fcons twice.
6194 (Fdecode_time): More accurate test for out-of-range times.
6195 (check_tm_member): New function.
6196 (Fencode_time): Use it, to test for out-of-range times.
6197 (lisp_time_argument): Don't rely on undefined left-shift and
6198 right-shift behavior when checking for time stamp overflow.
6199
6200 * editfns.c (time_overflow): New function, refactoring common code.
6201 (Fformat_time_string, Fdecode_time, Fencode_time):
6202 (Fcurrent_time_string): Use it.
6203
6204 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6205 * dired.c (make_time): Move to ...
6206 * editfns.c (make_time): ... here.
6207 * systime.h: Note the move.
6208
6209 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6210
6211 * fringe.c (update_window_fringes): Remove unused variables.
6212
6213 * unexmacosx.c (copy_data_segment): Also copy __got section.
6214 (Bug#8223)
6215
6216 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6217
6218 * termcap.c [MSDOS]: Include "msdos.h".
6219 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6220 Constify `char *' arguments and their references according to
6221 prototypes in tparam.h.
6222
6223 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6224
6225 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6226 Adapt all references accordingly.
6227
6228 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6229
6230 2011-03-11 Tom Tromey <tromey@redhat.com>
6231
6232 * buffer.c (syms_of_buffer): Remove obsolete comment.
6233
6234 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6235
6236 * termhooks.h (encode_terminal_code): Declare prototype.
6237
6238 * msdos.c (encode_terminal_code): Don't declare prototype.
6239
6240 * term.c (encode_terminal_code): Now external again, used by
6241 w32console.c and msdos.c.
6242
6243 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6244 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6245
6246 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6247
6248 Fix some minor problems found by GCC 4.5.2's static checks.
6249
6250 * fringe.c (update_window_fringes): Mark locals as initialized
6251 (Bug#8227).
6252 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6253
6254 * alloc.c (mark_fringe_data): Move decl from here ...
6255 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6256 to check its interface.
6257 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6258
6259 * fontset.c (free_realized_fontset): Now static.
6260 (Fset_fontset_font): Rename local to avoid shadowing.
6261 (fontset_font): Mark local as initialized.
6262 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6263
6264 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6265
6266 * xselect.c (x_disown_buffer_selections): Remove; not used.
6267 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6268 (x_own_selection, Fx_disown_selection_internal): Rename locals
6269 to avoid shadowing.
6270 (x_handle_dnd_message): Remove local to avoid shadowing.
6271
6272 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6273 so that the caller can use some name other than gcpro1.
6274 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6275 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6276 (Fx_backspace_delete_keys_p):
6277 Use them to avoid shadowing, and rename vars to avoid shadowing.
6278 (x_decode_color, x_set_name, x_window): Now static.
6279 (Fx_create_frame): Add braces to silence GCC warning.
6280 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6281 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6282 Remove unused locals.
6283 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6284 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6285 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6286 macros.
6287
6288 * xterm.h (x_mouse_leave): New decl.
6289
6290 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6291 Remove unused functions.
6292 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6293 (x_calc_absolute_position): Now static.
6294 (XTread_socket): Don't define label "out" unless it's used.
6295 Don't declare local "event" unless it's used.
6296 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6297 unless they are used.
6298 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6299 (x_fatal_error_signal): Remove; not used.
6300 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6301 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6302 (x_error_catcher, x_connection_closed, x_error_handler):
6303 (x_error_quitter, xembed_send_message, x_iconify_frame):
6304 (my_log_handler): Rename locals to avoid shadowing.
6305 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6306 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6307
6308 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6309 Rename or move locals to avoid shadowing.
6310 (tty_defined_color, merge_face_heights): Now static.
6311 (free_realized_faces_for_fontset): Remove; not used.
6312 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6313 does not deduce is never used uninitialized.
6314 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6315 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6316
6317 * terminal.c (store_terminal_param): Now static.
6318
6319 * xmenu.c (menu_highlight_callback): Now static.
6320 (set_frame_menubar): Remove unused local.
6321 (xmenu_show): Rename parameter to avoid shadowing.
6322 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6323 since they might point to immutable storage.
6324 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6325 since it's unused otherwise.
6326
6327 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6328 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6329 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6330 avoids a gcc -Wuninitialized diagnostic.
6331 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6332 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6333 does not deduce are never used uninitialized.
6334
6335 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6336
6337 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6338 * window.c (window_loop, size_window):
6339 (run_window_configuration_change_hook, enlarge_window): Likewise.
6340
6341 * window.c (display_buffer): Now static.
6342 (size_window): Mark variables that gcc -Wuninitialized
6343 does not deduce are never used uninitialized.
6344 * window.h (check_all_windows): New decl, to forestall
6345 gcc -Wmissing-prototypes diagnostic.
6346 * dispextern.h (bidi_dump_cached_states): Likewise.
6347
6348 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6349 shadowing.
6350 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6351 Include <limits.h>.
6352 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6353 and to avoid gcc -Wuninitialized warning.
6354 (load_charset_map): Mark variables that gcc -Wuninitialized
6355 does not deduce are never used uninitialized.
6356 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6357
6358 * coding.c (coding_set_source, coding_set_destination):
6359 Use "else { /* comment */ }" rather than "else /* comment */;"
6360 for clarity, and to avoid gcc -Wempty-body warning.
6361 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6362 a block, when the outer 'i' will do.
6363 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6364 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6365 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6366 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6367 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6368 Rename locals to avoid shadowing.
6369 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6370 * coding.c (emacs_mule_char, encode_invocation_designation):
6371 Now static, since they're not used elsewhere.
6372 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6373 (decode_coding_object, encode_coding_object, detect_coding_system):
6374 (decode_coding_emacs_mule): Mark variables that gcc
6375 -Wuninitialized does not deduce are never used uninitialized.
6376 (detect_coding_iso_2022): Initialize a local variable that might
6377 be used uninitialized. Leave a FIXME because it's not clear that
6378 this initialization is needed. (Bug#8211)
6379 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6380 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6381 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6382 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6383 Remove unused macros.
6384
6385 * category.c (hash_get_category_set): Remove unused local var.
6386 (copy_category_table): Now static, since it's not used elsewhere.
6387 * character.c (string_count_byte8): Likewise.
6388
6389 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6390 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6391
6392 * chartab.c (copy_sub_char_table): Now static, since it's not used
6393 elsewhere.
6394 (sub_char_table_ref_and_range, char_table_ref_and_range):
6395 Rename locals to avoid shadowing.
6396 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6397
6398 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6399 (BIDI_BOB): Remove unused macro.
6400
6401 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6402 deduce are never used uninitialized.
6403 * term.c (encode_terminal_code): Likewise.
6404
6405 * term.c (encode_terminal_code): Now static. Remove unused local.
6406
6407 * tparam.h: New file.
6408 * term.c, tparam.h: Include it.
6409 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6410 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6411 Move these decls to tparam.h, and make them agree with what
6412 is actually in tparam.c. The previous trick of using incompatible
6413 decls in different modules does not conform to the C standard.
6414 All callers of tparam changed to use tparam's actual API.
6415 * tparam.c (tparam1, tparam, tgoto):
6416 Use const pointers where appropriate.
6417
6418 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6419 * cm.h (struct cm): Likewise.
6420 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6421 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6422 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6423 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6424 (turn_on_face, init_tty): Likewise.
6425 * termchar.h (struct tty_display_info): Likewise.
6426
6427 * term.c (term_mouse_position): Rename local to avoid shadowing.
6428
6429 * alloc.c (mark_ttys): Move decl from here ...
6430 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6431
6432 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6433
6434 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6435
6436 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6437
6438 * search.c (compile_pattern_1): Remove argument regp, unused since
6439 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6440 (compile_pattern): Don't pass it.
6441
6442 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6443
6444 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6445 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6446 for ! HAVE_GTK3.
6447 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6448
6449 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6450
6451 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6452 gdk_window_get_screen, gdk_window_get_geometry,
6453 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6454 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6455 (xg_get_pixbuf_from_pixmap): New function.
6456 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6457 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6458 Call xg_get_pixbuf_from_pixmap instead of
6459 gdk_pixbuf_get_from_drawable.
6460 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6461 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6462 (xg_check_special_colors): Use GtkStyleContext and its functions
6463 for HAVE_GTK3.
6464 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6465 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6466 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6467 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6468 Call gtk_widget_get_preferred_size.
6469 (xg_frame_resized): gdk_window_get_geometry only takes 5
6470 parameters.
6471 (xg_win_to_widget, xg_event_is_for_menubar):
6472 Call gdk_x11_window_lookup_for_display.
6473 (xg_set_widget_bg): New function.
6474 (delete_cb): New function.
6475 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6476 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6477 (xg_set_background_color): Call xg_set_widget_bg.
6478 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6479 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6480 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6481 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6482 if ! HAVE_GTK3.
6483 (update_frame_tool_bar): Call gtk_widget_hide.
6484 (xg_initialize): Use GDK_KEY_g.
6485
6486 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6487 if ! HAVE_GTK3
6488 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6489
6490 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6491 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6492 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6493
6494 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6495
6496 * w32xfns.c (select_palette): Check success of RealizePalette against
6497 GDI_ERROR, not zero.
6498
6499 See ChangeLog.11 for earlier changes.
6500
6501 ;; Local Variables:
6502 ;; coding: utf-8
6503 ;; End:
6504
6505 Copyright (C) 2011 Free Software Foundation, Inc.
6506
6507 This file is part of GNU Emacs.
6508
6509 GNU Emacs is free software: you can redistribute it and/or modify
6510 it under the terms of the GNU General Public License as published by
6511 the Free Software Foundation, either version 3 of the License, or
6512 (at your option) any later version.
6513
6514 GNU Emacs is distributed in the hope that it will be useful,
6515 but WITHOUT ANY WARRANTY; without even the implied warranty of
6516 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6517 GNU General Public License for more details.
6518
6519 You should have received a copy of the GNU General Public License
6520 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.