Port recent dbusbind.c changes to 32-bit --with-wide-int.
[bpt/emacs.git] / src / ChangeLog
1 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5 Remove unportable assumptions about print widths of types like
6 dbus_uint32_t.
7 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
8 intptr_t when converting between pointer and integer, to avoid GCC
9 warnings about wrong width.
10
11 2012-05-09 Eli Zaretskii <eliz@gnu.org>
12
13 * w32proc.c (new_child): Force Windows to reserve only 64KB of
14 stack for each reader_thread, instead of defaulting to 8MB
15 determined by the linker. This avoids failures in creating
16 subprocesses on Windows 7, see the discussion in this thread:
17 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
18
19 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
20
21 Fix up display of the *Minibuf-0* buffer in the mini window.
22 * keyboard.c (read_char): Don't clear the echo area if there's no
23 message to clear.
24 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
25 contents of *Minibuf-0*) if there's no message displayed in its stead.
26
27 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
28
29 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
30 batch mode.
31
32 2012-05-06 Chong Yidong <cyd@gnu.org>
33
34 * lisp.mk (lisp): Update.
35
36 2012-05-05 Jim Meyering <meyering@redhat.com>
37
38 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
39
40 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
41
42 * data.c (PUT_ERROR): New macro.
43 (syms_of_data): Use it. Add new error type `user-error'.
44 * undo.c (user_error): New function.
45 (Fprimitive_undo): Use it.
46 * print.c (print_error_message): Adjust print style for `user-error'.
47 * keyboard.c (user_error): New function.
48 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
49
50 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
51
52 Do not limit current-time-string to years 1000..9999.
53 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
54 (Fcurrent_time_string): Support any year that is supported by the
55 underlying localtime representation. Don't use asctime, as it
56 has undefined behavior for years outside the range -999..9999.
57
58 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
59
60 Fix race conditions involving setenv, gmtime, localtime, asctime.
61 Without this fix, interrupts could mess up code that uses these
62 nonreentrant functions, since setting TZ invalidates existing
63 tm_zone or tzname values, and since most of these functions return
64 pointers to static storage.
65 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
66 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
67 Grow the critical sections to include not just invoking
68 localtime/gmtime, but also accessing these functions' results
69 including their tm_zone values if any, and any related TZ setting.
70 (format_time_string): Last arg is now struct tm *, not struct tm **,
71 so that the struct tm is saved in the critical section.
72 All callers changed. Simplify allocation of initial buffer, partly
73 motivated by the fact that memory allocation needs to be outside
74 the critical section.
75
76 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
77
78 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
79 with RESET_INTERVAL.
80
81 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
82 Remove duplicated buffer name initialization.
83
84 2012-05-02 Jim Meyering <jim@meyering.net>
85
86 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
87
88 * xfns.c (x_window): Use xstrdup (Bug#11375).
89
90 2012-05-02 Eli Zaretskii <eliz@gnu.org>
91
92 * xdisp.c (pos_visible_p): If already at a newline from the
93 display string before the 'while' loop, don't walk back the glyphs
94 from it3.glyph_row. Solves assertion violation when the display
95 string begins with a newline (egg.el). (Bug#11367)
96
97 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
98
99 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
100 Move to simple.el.
101
102 2012-05-01 Glenn Morris <rgm@gnu.org>
103
104 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
105 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
106 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
107 All were removed before 23.1.
108
109 * dispnew.c: Remove HAVE_LIBNCURSES test;
110 it is always true on relevant platforms.
111
112 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
113 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
114
115 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
116
117 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
118
119 * .gdbinit (xpr): Remove checks for no longer existing misc types.
120 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
121 Remove.
122
123 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
124
125 Do not avoid creating empty evaporating overlays (Bug#9642).
126 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
127 That is, do not delete an evaporating overlay if it becomes
128 empty after its bounds are adjusted to fit within its buffer.
129 This fix caused other problems, and I'm reverting it until we get
130 to the bottom of them.
131
132 2012-04-27 Chong Yidong <cyd@gnu.org>
133
134 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
135
136 2012-04-27 Eli Zaretskii <eliz@gnu.org>
137
138 * xdisp.c (pos_visible_p): If the window start position is beyond
139 ZV, start the display from buffer beginning. Prevents assertion
140 violation in init_iterator when the minibuffer window is scrolled
141 via the scroll bar.
142
143 * window.c (window_scroll_pixel_based): Likewise.
144
145 2012-04-27 Chong Yidong <cyd@gnu.org>
146
147 * keymap.c (where_is_internal): Doc fix (Bug#10872).
148
149 2012-04-27 Glenn Morris <rgm@gnu.org>
150
151 * fileio.c (Fcopy_file, Fset_file_selinux_context):
152 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
153
154 2012-04-27 Eli Zaretskii <eliz@gnu.org>
155
156 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
157 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
158
159 2012-04-26 Eli Zaretskii <eliz@gnu.org>
160
161 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
162 display element, check also the underlying string or buffer
163 character. (Bug#11341)
164
165 * w32menu.c: Include w32heap.h.
166 (add_menu_item): If the call to AppendMenuW (via
167 unicode_append_menu) fails, disable Unicode menus only if we are
168 running on Windows 9X/Me.
169
170 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
171
172 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
173 (xgetint): Add missing shift for LSB tags.
174
175 2012-04-24 Martin Rudalics <rudalics@gmx.at>
176
177 * keyboard.c (read_char): Don't wipe echo area for select window
178 events: These might get delayed via `mouse-autoselect-window'
179 (Bug#11304).
180
181 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
182
183 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
184 manipulation of :loaded-from data.
185
186 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
187
188 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
189 now a cons (bug#11311).
190
191 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
192
193 Do not create empty overlays with the evaporate property (Bug#9642).
194 * buffer.c (Fmove_overlay): Delete an evaporating overlay
195 if it becomes empty after its bounds are adjusted to fit within
196 its buffer. Without this fix, in a nonempty buffer (let ((o
197 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
198 yields an empty overlay that has the evaporate property, which is
199 not supposed to happen.
200
201 Fix minor GTK3 problems found by static checking.
202 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
203 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
204 (struct _EmacsFixedClass, emacs_fixed_get_type):
205 Move decls here from emacsgtkfixed.h, since they needn't be public.
206 (emacs_fixed_get_type): Now static.
207 (emacs_fixed_class_init): Omit unused local.
208 (emacs_fixed_child_type): Remove; unused.
209 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
210 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
211 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
212 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
213 (EMACS_FIXED_GET_CLASS): Remove; unused.
214 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
215
216 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
217 Problem reported by Juanma Barranquero for Windows -Wunused-function.
218
219 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
220
221 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
222 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
223 (__malloc_size_t, __malloc_ptrdiff_t):
224 Remove. All uses removed, replaced by the definiens if needed,
225 since we can assume C89 or better now.
226 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
227 (protect_malloc_state, align, get_contiguous_space)
228 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
229 (malloc_atfork_handler_child, malloc_enable_thread)
230 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
231 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
232 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
233 (special_realloc, _realloc_internal_nolock, _realloc_internal)
234 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
235 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
236 Define using prototypes, not old style.
237 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
238 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
239 (align): Don't assume that signed integer overflow wraps around.
240 Omit unused local var.
241 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
242 (_free_internal_nolock, memalign, mallochook, reallochook):
243 Omit no-longer-needed casts.
244 (valloc): Use getpagesize, not __getpagesize.
245 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
246 (struct hdr): The 'magic' member is now size_t, not unsigned long.
247
248 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
249
250 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
251
252 Move functions from C to Lisp. Make non-blocking method calls
253 the default. Implement further D-Bus standard interfaces.
254
255 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
256 (QCdbus_request_name_allow_replacement)
257 (QCdbus_request_name_replace_existing)
258 (QCdbus_request_name_do_not_queue)
259 (QCdbus_request_name_reply_primary_owner)
260 (QCdbus_request_name_reply_in_queue)
261 (QCdbus_request_name_reply_exists)
262 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
263 (QCdbus_registered_serial, QCdbus_registered_method)
264 (QCdbus_registered_signal): New Lisp objects.
265 (XD_DEBUG_MESSAGE): Use sizeof.
266 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
267 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
268 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
269 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
270 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
271 (xd_signature, xd_append_arg): Allow float for integer types.
272 (xd_get_connection_references): New function.
273 (xd_get_connection_address): Rename from xd_initialize.
274 Return cached address.
275 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
276 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
277 level.
278 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
279 Return number of refcounts.
280 (Fdbus_get_unique_name): Make stronger parameter check.
281 (Fdbus_message_internal): New defun.
282 (Fdbus_call_method, Fdbus_call_method_asynchronously)
283 (Fdbus_method_return_internal, Fdbus_method_error_internal)
284 (Fdbus_send_signal, Fdbus_register_service)
285 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
286 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
287 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
288 (Vdbus_compiled_version, Vdbus_runtime_version)
289 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
290 (Vdbus_message_type_method_return, Vdbus_message_type_error)
291 (Vdbus_message_type_signal): New defvars.
292 (Vdbus_registered_buses, Vdbus_registered_objects_table):
293 Adapt docstring.
294
295 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
296
297 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
298 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
299 Do not assume ptrdiff_t is the same width as 'int'.
300
301 * alloc.c: Handle unusual debugging option combinations.
302 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
303 since the two debugging options are incompatible.
304 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
305 is defined.
306 (mem_init, mem_insert, mem_insert_fixup):
307 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
308 (NEED_MEM_INSERT): Remove; no longer needed.
309
310 2012-04-22 Leo Liu <sdl.web@gmail.com>
311
312 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
313
314 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
315
316 * sysdep.c [__FreeBSD__]: Minor cleanups.
317 (list_system_processes, system_process_attributes) [__FreeBSD__]:
318 Use Emacs indenting style more consistently. Avoid some casts.
319 Use 'double' consistently rather than mixing 'float' and 'double'.
320
321 2012-04-21 Eduard Wiebe <usenet@pusto.de>
322
323 * sysdep.c (list_system_processes, system_process_attributes):
324 Add implementation for FreeBSD (Bug#5243).
325
326 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
327
328 * lisp.mk (lisp): Update.
329
330 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
331
332 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
333 It is never used otherwise.
334
335 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
336
337 * print.c (print_preprocess): Only check print_depth if print-circle
338 is nil.
339 (print_object): Check for cycles even when print-circle is nil and
340 print-gensym is t, but only check print_depth if print-circle is nil.
341
342 2012-04-20 Chong Yidong <cyd@gnu.org>
343
344 * process.c (wait_reading_process_output): If EIO occurs on a pty,
345 set the status to "failed" and ensure that sentinel is run.
346
347 2012-04-20 Glenn Morris <rgm@gnu.org>
348
349 * process.c (Fset_process_inherit_coding_system_flag)
350 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
351 (Fmake_network_process, Fmake_serial_process): Doc fix.
352
353 2012-04-20 Eli Zaretskii <eliz@gnu.org>
354
355 * xdisp.c (string_buffer_position_lim): Limit starting position to
356 BEGV.
357 (set_cursor_from_row): If called for a mode-line or header-line
358 row, return zero immediately.
359 (try_cursor_movement): If inside continuation line, don't back up
360 farther than the first row after the header line, if any.
361 Don't consider the header-line row as "partially visible", even if
362 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
363
364 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
365
366 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
367 (bug#11238).
368
369 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
370 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
371
372 configure: new option --enable-gcc-warnings (Bug#11207)
373 * Makefile.in (C_WARNINGS_SWITCH): Remove.
374 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
375 (ALL_CFLAGS): Use new macros rather than old.
376 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
377 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
378 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
379 -Wunused-result, -Wunused-variable. This should go away once
380 the Emacs and Gnulib regex code is merged.
381 (xmalloc, xrealloc): Now static.
382
383 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
384
385 * dired.c (Fsystem_groups): Remove unused local.
386
387 2012-04-17 Glenn Morris <rgm@gnu.org>
388
389 * dired.c (Fsystem_users): Doc fix.
390
391 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
392
393 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
394 (syms_of_dired): Add them.
395
396 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
397
398 Fix minor alloc.c problems found by static checking.
399 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
400 New extern decls, to avoid calling undeclared functions.
401 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
402 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
403 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
404 (NEED_MEM_INSERT): New macro.
405 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
406 Remove one incorrect comment and fix another.
407
408 Fix minor ralloc.c problems found by static checking.
409 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
410 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
411 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
412 (r_alloc_sbrk): Now static.
413
414 Improve ralloc.c interface checking.
415 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
416 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
417 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
418 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
419 [REL_ALLOC]: ... to here, to check interface.
420 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
421 Remove decls. This fixes an "It stinks!".
422
423 * alloc.c (which_symbols): Fix alignment issue / type clash.
424
425 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
426
427 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
428 (struct Lisp_Misc_Any): Likewise.
429 (struct Lisp_Free): Likewise.
430 * alloc.c (union aligned_Lisp_Symbol): Define.
431 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
432 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
433 (union aligned_Lisp_Misc): Define.
434 (MARKER_BLOCK_SIZE, struct marker_block): Use union
435 aligned_Lisp_Misc instead of union Lisp_Misc.
436 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
437
438 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
439
440 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
441 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
442 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
443 * s/netbsd.h, s/sol2-6.h:
444 Remove definition of GC_MARK_STACK, since the default now works.
445 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
446 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
447 no longer the default.
448 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
449
450 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
451
452 * lread.c (lisp_file_lexically_bound_p):
453 Fix hang at ";-*-\n" (bug#11238).
454
455 2012-04-14 Eli Zaretskii <eliz@gnu.org>
456
457 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
458 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
459
460 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
461
462 * nsterm.m (constrainFrameRect): Always constrain when there is only
463 one screen (Bug#10962).
464
465 2012-04-13 Ken Brown <kbrown@cornell.edu>
466
467 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
468
469 2012-04-13 Reuben Thomas <rrt@sc3d.org>
470
471 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
472
473 2012-04-11 Daniel Colascione <dancol@dancol.org>
474
475 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
476 against is gone. It's better to use vfork now so that when Cygwin
477 gains a new, working vfork, we use it automatically (bug#10398).
478
479 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
480
481 * window.c (save_window_save): Obey window-point-insertion-type.
482
483 2012-04-11 Glenn Morris <rgm@gnu.org>
484
485 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
486
487 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
488
489 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
490
491 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
492
493 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
494 (force_quit_count): New var.
495 (handle_interrupt): Use it.
496
497 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
498
499 * w32.c (w32_delayed_load): Record the full path of the library
500 being loaded (bug#10424).
501
502 2012-04-09 Glenn Morris <rgm@gnu.org>
503
504 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
505 not just in the obarray, before snarfing them. (Bug#11036)
506
507 * Makefile.in ($(leimdir)/leim-list.el):
508 Pass EMACS rather than BUILT_EMACS.
509
510 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
511
512 * process.c (make_process):
513 * process.h: Add integer `gnutls_handshakes_tried' member to
514 process struct.
515
516 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
517 Add convenience `GNUTLS_LOG2i' macro.
518
519 * gnutls.c (gnutls_log_function2i): Convenience log function.
520 (emacs_gnutls_read): Use new log functions,
521 `gnutls_handshakes_tried' process member, and
522 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
523 attempts per process (connection).
524
525 2012-04-09 Chong Yidong <cyd@gnu.org>
526
527 * eval.c (Fuser_variable_p, user_variable_p_eh)
528 (lisp_indirect_variable): Functions deleted.
529 (Fdefvar): Caller changed.
530
531 * callint.c (Finteractive, Fcall_interactively):
532 * minibuf.c (Fread_variable): Callers changed.
533
534 2012-04-09 Eli Zaretskii <eliz@gnu.org>
535
536 * xdisp.c (set_cursor_from_row): If the display string appears in
537 the buffer at position that is closer to point than the position
538 after the display string, display the cursor on the first glyph of
539 the display string. Fixes cursor display when a 'display' text
540 property immediately follows invisible text. (Bug#11094)
541
542 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
543
544 composite.c: use 'double' consistently
545 * composite.c (get_composition_id): Use 'double' consistently
546 instead of converting 'float' to 'double' and vice versa; this is
547 easier to understand and avoids a GCC warning.
548
549 2012-04-09 Glenn Morris <rgm@gnu.org>
550
551 * Makefile.in: Generate leim-list with bootstrap-emacs, in
552 preparation for dumping it with emacs. (Bug#4789)
553 (leimdir): New variable.
554 ($(leimdir)/leim-list.el): New rule.
555 (emacs$(EXEEXT)): Depend on leim-list.el.
556
557 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
558 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
559 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
560
561 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
562
563 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
564 proper alignment.
565
566 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
567
568 * xml.c (init_libxml2_functions) [WINDOWSNT]:
569 Remove unused local variable.
570
571 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
572
573 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
574 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
575 (mark_memory): Mark Lisp_Objects only if pointers might hide in
576 objects, as mark_maybe_pointer will catch them otherwise.
577 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
578 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
579
580 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
581
582 Fix typo that broke non-Windows builds.
583 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
584
585 2012-04-07 Eli Zaretskii <eliz@gnu.org>
586
587 Support building on MS-Windows with libxml2.
588
589 * makefile.w32-in (OBJ2): Add xml.$(O).
590 (GLOBAL_SOURCES): Add xml.c.
591 ($(BLD)/xml.$(O)): New dependency list.
592
593 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
594 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
595 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
596 [!WINDOWSNT]: New macros.
597 (init_libxml2_functions, libxml2_loaded_p): New functions.
598 (parse_region): Call fn_xmlCheckVersion instead of using the macro
599 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
600 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
601 Calls xmlCleanupParser only if libxml2 was loaded (or statically
602 linked in).
603 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
604 Call init_libxml2_functions before calling libxml2 functions.
605 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
606
607 * emacs.c: Don't include libxml/parser.h.
608 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
609 xmlCleanupParser directly.
610
611 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
612
613 2012-04-07 Eli Zaretskii <eliz@gnu.org>
614
615 * indent.c (Fvertical_motion): If there is a display string at
616 point, use it.vpos to compute how many lines to backtrack after
617 move_it_to point. (Bug#11133)
618
619 2012-04-06 Eli Zaretskii <eliz@gnu.org>
620
621 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
622 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
623 about subtle differences between FETCH_CHAR* and STRING_CHAR*
624 macros related to unification of CJK characters. For the details,
625 see the discussion following the message here:
626 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
627
628 2012-04-04 Chong Yidong <cyd@gnu.org>
629
630 * keyboard.c (Vdelayed_warnings_list): Doc fix.
631
632 2012-04-01 Eli Zaretskii <eliz@gnu.org>
633
634 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
635 instead of alloca. (Bug#11138)
636
637 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
638
639 * w32menu.c (is_simple_dialog): Properly check lisp types.
640 (Bug#11141)
641
642 2012-03-31 Eli Zaretskii <eliz@gnu.org>
643
644 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
645 position we get to after a call to move_it_to fails the
646 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
647 only if we wind up in a string from display property. (Bug#11063)
648
649 * window.c (Fdelete_other_windows_internal): Invalidate the row
650 and column information about mouse highlight, so that redisplay
651 restores it after reallocating the glyph matrices. (Bug#7464)
652
653 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
654 string comes from a `display' text property, use the buffer
655 position of that property as if we actually saw that position in
656 the row's glyphs.
657 (move_it_by_lines): Remove the assertion that
658 "it->current_x == 0 && it->hpos == 0" which can be legitimately
659 violated when there's a before-string at the beginning of a line.
660 (Bug#11063)
661
662 2012-03-30 Eli Zaretskii <eliz@gnu.org>
663
664 * xdisp.c (append_space_for_newline): If the default face was
665 remapped, use the remapped face for the appended newline.
666 (extend_face_to_end_of_line): Use the remapped default face for
667 extending the face to the end of the line.
668 (display_line): Call extend_face_to_end_of_line when the default
669 face was remapped. (Bug#11068)
670
671 2012-03-29 Eli Zaretskii <eliz@gnu.org>
672
673 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
674
675 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
676
677 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
678
679 2012-03-27 Glenn Morris <rgm@gnu.org>
680
681 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
682 Doc fixes.
683
684 2012-03-26 Kenichi Handa <handa@m17n.org>
685
686 * dispextern.h (struct glyph): Fix previous change. Change the
687 bit length of glyphless.ch to 25 (Bug#11082).
688
689 2012-03-26 Chong Yidong <cyd@gnu.org>
690
691 * keyboard.c (Vselection_inhibit_update_commands): New variable.
692 (command_loop_1): Use it; inhibit selection update for
693 handle-select-window too (Bug#8996).
694
695 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
696
697 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
698
699 2012-03-25 Kenichi Handa <handa@m17n.org>
700
701 * dispextern.h (struct glyph): Change the bit length of
702 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
703
704 2012-03-24 Eli Zaretskii <eliz@gnu.org>
705
706 * s/ms-w32.h (tzname): Include time.h before redirecting to
707 _tzname. Fixes the MSVC build. (Bug#9960)
708
709 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
710
711 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
712 characters.
713
714 * xterm.c (XTread_socket): Only modify handling_signal if
715 !SYNC_INPUT. (Bug#11080)
716
717 2012-03-23 Eli Zaretskii <eliz@gnu.org>
718
719 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
720 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
721 when fetching a multibyte character consumes more bytes than
722 CHAR_BYTES returns, due to unification of CJK characters in
723 string_char. (Bug#11073)
724
725 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
726
727 * process.c (wait_reading_process_output): Handle pty disconnect
728 by refraining from sending oneself a SIGCHLD (bug#10933).
729
730 2012-03-22 Chong Yidong <cyd@gnu.org>
731
732 * dispextern.h (struct it): New member string_from_prefix_prop_p.
733
734 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
735 Mark string as coming from a prefix property.
736 (handle_face_prop): Use default face for prefix strings (Bug#4281).
737 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
738
739 2012-03-21 Chong Yidong <cyd@gnu.org>
740
741 * xfaces.c (Vface_remapping_alist): Doc fix.
742
743 2012-03-20 Eli Zaretskii <eliz@gnu.org>
744
745 * w32proc.c (Fw32_set_console_codepage)
746 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
747 Doc fixes.
748
749 2012-03-20 Chong Yidong <cyd@gnu.org>
750
751 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
752 to reflect default non-nil value of redisplay-dont-pause.
753
754 2012-03-19 Kenichi Handa <handa@m17n.org>
755
756 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
757 it fit in a valid range (Bug#11003).
758
759 2012-03-18 Eli Zaretskii <eliz@gnu.org>
760
761 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
762 that is not from display property, accept the row as a "cursor
763 row" if one of the string's character has a non-nil `cursor'
764 property. Fixes cursor positioning when there are newlines in
765 overlay strings, e.g. in icomplete.el. (Bug#11035)
766
767 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
768
769 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
770
771 2012-03-12 Chong Yidong <cyd@gnu.org>
772
773 * eval.c (inhibit_lisp_code): Rename from
774 inhibit_window_configuration_change_hook; move from window.c.
775
776 * xfns.c (unwind_create_frame_1, Fx_create_frame):
777 * window.c (run_window_configuration_change_hook)
778 (syms_of_window): Callers changed.
779
780 2012-03-11 Chong Yidong <cyd@gnu.org>
781
782 * keymap.c (Fkey_description): Doc fix (Bug#9700).
783
784 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
785
786 2012-03-10 Chong Yidong <cyd@gnu.org>
787
788 * frame.c (other_visible_frames): Don't assume the selected frame
789 is visible (Bug#10955).
790
791 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
794
795 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
796
797 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
798 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
799 zero (Bug#10954).
800
801 2012-03-03 Glenn Morris <rgm@gnu.org>
802
803 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
804
805 2012-03-02 Eli Zaretskii <eliz@gnu.org>
806
807 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
808 position past the first glyph_row that ends at ZV. (Bug#10902)
809 (redisplay_window, next_element_from_string): Fix typos in
810 comments.
811 (redisplay_window): Pass to move_it_vertically the margin in
812 pixels, not in screen lines.
813
814 2012-03-02 Glenn Morris <rgm@gnu.org>
815
816 * buffer.c (buffer-list-update-hook): Doc fix.
817
818 2012-02-29 Eli Zaretskii <eliz@gnu.org>
819
820 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
821 push_it before setting up the iterator for the first overlay
822 string, even if we have an empty string loaded.
823 (next_overlay_string): If there's an empty string on the iterator
824 stack, pop the stack. (Bug#10903)
825
826 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
827
828 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
829 Suggested by Stefan Monnier in
830 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
831 * alloc.c (widen_to_Lisp_Object): New static function.
832 (mark_memory): Also mark Lisp_Objects by fetching pointer words
833 and widening them to Lisp_Objects. This would work even if
834 USE_LSB_TAG is defined and wide integers are used, which might
835 happen in a future version of Emacs.
836
837 2012-02-25 Chong Yidong <cyd@gnu.org>
838
839 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
840 Doc fix.
841
842 * xselect.c (Fx_selection_exists_p): Doc fix.
843 (x_clipboard_manager_save_all): Print an informative message
844 before saving to clipboard manager.
845
846 2012-02-24 Chong Yidong <cyd@gnu.org>
847
848 * keyboard.c (process_special_events): Handle all X selection
849 requests in kbd_buffer, not just the next one (Bug#8869).
850
851 2012-02-23 Chong Yidong <cyd@gnu.org>
852
853 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
854 call when setting menu-bar-lines and tool-bar-lines parameters.
855 (unwind_create_frame_1): New helper function.
856
857 * window.c (inhibit_window_configuration_change_hook): New var.
858 (run_window_configuration_change_hook): Obey it.
859 (syms_of_window): Initialize it.
860
861 2012-02-22 Chong Yidong <cyd@gnu.org>
862
863 * xterm.c (x_draw_image_relief): Add missing type check for
864 Vtool_bar_button_margin (Bug#10743).
865
866 2012-02-21 Chong Yidong <cyd@gnu.org>
867
868 * fileio.c (Vfile_name_handler_alist): Doc fix.
869
870 * buffer.c (Fget_file_buffer): Protect against invalid file
871 handler return value.
872
873 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
874
875 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
876 when computing $valmask.
877
878 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
879 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
880 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
881 It's useless in that case, and it can cause problems on hosts
882 that allocate halves of EMACS_INT values separately.
883 Reported by Dan Horák. Diagnosed by Andreas Schwab in
884 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
885 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
886 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
887 it avoids undefined behavior on hosts where shifting right by more
888 than the word width has undefined behavior.
889
890 2012-02-19 Chong Yidong <cyd@gnu.org>
891
892 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
893 (Funhandled_file_name_directory, Ffile_name_as_directory)
894 (Fdirectory_file_name, Fexpand_file_name)
895 (Fsubstitute_in_file_name): Protect against invalid file handler
896 return values (Bug#10845).
897
898 2012-02-18 Eli Zaretskii <eliz@gnu.org>
899
900 * .gdbinit (pitx): Fix incorrect references to fields of the
901 iterator stack.
902
903 2012-02-17 Chong Yidong <cyd@gnu.org>
904
905 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
906
907 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
908
909 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
910 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
911
912 2012-02-15 Chong Yidong <cyd@gnu.org>
913
914 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
915 marked as special. Also, starting docstrings with * is obsolete.
916
917 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
918
919 * gnutls.c (emacs_gnutls_write): Fix last change.
920
921 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
922
923 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
924 send_process.
925
926 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
927
928 * keymap.c (Fsingle_key_description): Handle char ranges.
929
930 2012-02-12 Chong Yidong <cyd@gnu.org>
931
932 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
933 as that creates a dangerous corner case.
934
935 * window.c (Fdelete_window_internal): Invalidate the mouse
936 highlight (Bug#9904).
937
938 2012-02-12 Glenn Morris <rgm@gnu.org>
939
940 * xselect.c (Fx_own_selection_internal)
941 (Fx_get_selection_internal, Fx_disown_selection_internal)
942 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
943 * nsselect.m (Fx_own_selection_internal)
944 (Fx_disown_selection_internal, Fx_selection_exists_p)
945 (Fx_selection_owner_p, Fx_get_selection_internal):
946 Sync docs and argument specs with the xselect.c versions.
947
948 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
949
950 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
951
952 2012-02-11 Eli Zaretskii <eliz@gnu.org>
953
954 * w32select.c (Fx_selection_exists_p): Sync doc string and
955 argument list with xselect.c. (Bug#10783)
956
957 * w16select.c (Fx_selection_exists_p): Sync doc string and
958 argument list with xselect.c. (Bug#10783)
959
960 2012-02-10 Glenn Morris <rgm@gnu.org>
961
962 * fns.c (Fsecure_hash): Doc fix.
963
964 2012-02-09 Kenichi Handa <handa@m17n.org>
965
966 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
967
968 2012-02-07 Chong Yidong <cyd@gnu.org>
969
970 * buffer.c (Fbuffer_local_variables)
971 (buffer_lisp_local_variables): Handle unbound vars correctly;
972 don't let Qunbound leak into Lisp.
973
974 2012-02-07 Glenn Morris <rgm@gnu.org>
975
976 * image.c (Fimagemagick_types): Doc fix.
977
978 * image.c (imagemagick-render-type): Change it from a lisp object
979 to an integer. Move the doc here from the lisp manual.
980 Treat all values not equal to 0 the same.
981
982 2012-02-06 Chong Yidong <cyd@gnu.org>
983
984 * doc.c (store_function_docstring): Avoid applying docstring of
985 alias to base function (Bug#2603).
986
987 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
988
989 * .gdbinit (pp1, pv1): Remove redundant defines.
990 (pr): Use pp.
991
992 2012-02-04 Chong Yidong <cyd@gnu.org>
993
994 * nsterm.m: Declare a global (Bug#10694).
995
996 2012-02-04 Eli Zaretskii <eliz@gnu.org>
997
998 * w32.c (get_emacs_configuration_options):
999 Include --enable-checking, if specified, in the return value.
1000
1001 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1002
1003 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1004 after rounding frame sizes. (Bug#9723)
1005
1006 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1007
1008 * keyboard.c (adjust_point_for_property): Don't position point
1009 before BEGV. (Bug#10696)
1010
1011 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 Handle overflow when computing char display width (Bug#9496).
1014 * character.c (char_width): Return EMACS_INT, not int.
1015 (char_width, c_string_width): Check for overflow when
1016 computing the width; this is possible now that individual
1017 characters can have unbounded width. Problem introduced
1018 by merge from Emacs 23 on 2012-01-19.
1019
1020 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1021
1022 * dbusbind.c (Fdbus_register_method): Mention the return value
1023 :ignore in the docstring.
1024
1025 2012-02-02 Glenn Morris <rgm@gnu.org>
1026
1027 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1028
1029 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1030 Unconditionally set to t. (Bug#10673)
1031 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1032 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1033 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1034
1035 2012-02-02 Kenichi Handa <handa@m17n.org>
1036
1037 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1038 0, do not call append_composite_glyph.
1039
1040 2012-02-02 Kenichi Handa <handa@m17n.org>
1041
1042 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1043 NULL (Bug#6988).
1044 (x_produce_glyphs): If the component of a composition is a null
1045 string, set it->pixel_width to 1 to avoid zero-width glyph.
1046
1047 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1048
1049 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1050 first 2 arguments are identical. This makes inserting large
1051 output from a subprocess an order of magnitude faster on
1052 MS-Windows, where all sbrk'ed memory is always contiguous.
1053
1054 2012-01-31 Glenn Morris <rgm@gnu.org>
1055
1056 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1057 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1058 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1059
1060 2012-01-29 Glenn Morris <rgm@gnu.org>
1061
1062 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1063
1064 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1065
1066 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1067
1068 2012-01-28 Chong Yidong <cyd@gnu.org>
1069
1070 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1071
1072 2012-01-26 Chong Yidong <cyd@gnu.org>
1073
1074 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1075
1076 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1077 repeat counts (Bug#10507).
1078
1079 2012-01-26 Glenn Morris <rgm@gnu.org>
1080
1081 * lread.c (syms_of_lread): Doc fix.
1082
1083 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1084
1085 * coding.c (encode_designation_at_bol): Change return value to
1086 EMACS_INT.
1087
1088 2012-01-25 Chong Yidong <cyd@gnu.org>
1089
1090 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1091
1092 2012-01-21 Chong Yidong <cyd@gnu.org>
1093
1094 * floatfns.c (Fcopysign): Make the second argument non-optional,
1095 since nil is not allowed anyway.
1096
1097 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1098
1099 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1100 (send_process): Likewise.
1101
1102 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1103
1104 * window.c (save_window_save, Fcurrent_window_configuration)
1105 (Vwindow_persistent_parameters): Do not use Qstate.
1106 Rewrite doc-strings.
1107
1108 2012-01-19 Kenichi Handa <handa@m17n.org>
1109
1110 * character.c (char_width): New function.
1111 (Fchar_width, c_string_width, lisp_string_width):
1112 Use char_width (Bug#9496).
1113
1114 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1115
1116 * window.c (Vwindow_persistent_parameters): New variable.
1117 (Fset_window_configuration, save_window_save): Handle persistent
1118 window parameters.
1119
1120 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1121
1122 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1123 thrashing the stack of the thread. (Bug#9087)
1124
1125 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1128
1129 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1130
1131 * xdisp.c (rows_from_pos_range): Handle the case where the
1132 highlight ends on a newline. (Bug#10464)
1133 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1134 he end column for display of highlight that ends on a newline
1135 before a R2L line.
1136
1137 2012-01-11 Glenn Morris <rgm@gnu.org>
1138
1139 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1140 from load-path also when installation-directory is nil. (Bug#10208)
1141
1142 2012-01-10 Glenn Morris <rgm@gnu.org>
1143
1144 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1145
1146 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1147 Update template values to be closer to their typical values these days.
1148
1149 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1150
1151 * xdisp.c (rows_from_pos_range): Accept additional argument
1152 DISP_STRING, and accept any glyph in a row whose object is that
1153 string as eligible for mouse highlight. Fixes mouse highlight of
1154 display strings from overlays. (Bug#10464)
1155
1156 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 emacs: fix an auto-save permissions race condition (Bug#10400)
1159 * fileio.c (auto_saving_dir_umask): New static var.
1160 (Fmake_directory_internal): Use it.
1161 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1162 creating the directory. The old code temporarily assigns
1163 too-generous permissions to the directory.
1164 (do_auto_save_eh): Clear it.
1165 (Fdo_auto_save): Catch all errors, not just file errors, so
1166 that the var is always cleared.
1167
1168 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1169
1170 * search.c (scan_buffer): Pass character positions to
1171 know_region_cache, not byte positions. (Bug#6540)
1172
1173 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1174
1175 * w32.c (sys_rename): Report EXDEV when rename of a directory
1176 fails because the target is on another logical disk. (Bug#10284)
1177
1178 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1179
1180 * xterm.c (x_embed_request_focus): New function.
1181
1182 * xterm.h: Add prototype.
1183
1184 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1185
1186 2012-01-05 Glenn Morris <rgm@gnu.org>
1187
1188 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1189
1190 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1191
1192 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1193 Load gnutls_transport_set_lowat only if GnuTLS version is below
1194 2.11.1.
1195 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1196 GnuTLS versions below 2.11.1.
1197
1198 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1199
1200 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1201 to the doc string advising against its use for altering the way
1202 windows are scrolled.
1203
1204 2011-12-28 Kenichi Handa <handa@m17n.org>
1205
1206 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1207 coding-system ASCII compatible only when it does not produce BOM
1208 on encoding (Bug#10383).
1209
1210 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1211
1212 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1213 can scroll.
1214 (create_and_show_popup_menu): Always use menu_position_func for
1215 Gtk3 (Bug#10361).
1216
1217 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1218
1219 * callint.c (Fcall_interactively): Don't truncate prompt string.
1220
1221 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1222
1223 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1224 property that ends at ZV, so that the bidi iteration could be
1225 resumed from there (after widening). (Bug#10360)
1226
1227 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1228
1229 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1230
1231 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1232
1233 * nsterm.m (x_free_frame_resources):
1234 Release f->output_data.ns->miniimage.
1235 (ns_index_color): Fix indentation. Do not retain
1236 color_table->colors[i].
1237
1238 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1239 before returning.
1240
1241 * nsfns.m (x_set_background_color): Assign return value from
1242 ns_index_color to face-background instead of NSColor*.
1243 (ns_implicitly_set_icon_type): Fix indentation.
1244 Change assignment in for loop to comparison.
1245
1246 * emacs.c (ns_pool): New variable.
1247 (main): Assign ns_pool.
1248 (Fkill_emacs): Call ns_release_autorelease_pool.
1249
1250 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1251 autorelease fdesc, release fdAttrs and tdict.
1252 (ns_get_covering_families): Release charset.
1253 (ns_findfonts): Release NSFontDescriptor created with new.
1254 (ns_uni_to_glyphs): Fix indentation.
1255 (setString): Release attrStr before assigning new value.
1256
1257 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1258
1259 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1260 and NS_IMPL_COCOA.
1261 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1262 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1263
1264 2011-12-18 David Reitter <reitter@cmu.edu>
1265
1266 * nsterm.m (ns_term_init): Subscribe for notifications
1267 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1268 to method trackingNotification in EmacsMenu.
1269
1270 * nsmenu.m (trackingMenu): New variable.
1271 (trackingNotification): New method (from Aquamacs).
1272 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1273 from Aquamacs (Bug#7030).
1274
1275 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1276
1277 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1278 (symbol_to_nsstring): Fix indentation.
1279 (ns_symbol_to_pb): New function.
1280 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1281 (Fns_rotate_cut_buffers_internal): Remove.
1282 (Fns_store_selection_internal): Rename from
1283 Fns_store_cut_buffer_internal.
1284 (ns_get_foreign_selection, Fx_own_selection_internal)
1285 (Fx_disown_selection_internal, Fx_selection_exists_p)
1286 (Fns_get_selection_internal, Fns_store_selection_internal):
1287 Use ns_symbol_to_pb and check if return value is nil.
1288 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1289 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1290 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1291 renamed to Sns_store_selection_internal.
1292 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1293 and remove this function.
1294 (ns_handle_selection_clear): Remove, never used.
1295 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1296 here.
1297
1298 2011-12-17 Ken Brown <kbrown@cornell.edu>
1299
1300 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1301 GID is unknown (Bug#10257).
1302
1303 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1306 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1307 which caused a build failure on GNU/Linux IA-64. This problem was
1308 introduced by my 2011-10-07 patch.
1309
1310 2011-12-15 Juri Linkov <juri@jurta.org>
1311
1312 * image.c (imagemagick_error): New function. (Bug#10112)
1313 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1314 Use `imagemagick_error' where ImageMagick functions return
1315 `MagickFalse'.
1316 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1317 proper order.
1318
1319 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1320
1321 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1322 fill background (Bug#8992).
1323
1324 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1325
1326 * window.c (Vwindow_combination_resize)
1327 (Vwindow_combination_limit): Use t instead of non-nil in
1328 doc-strings.
1329 (Vrecenter_redisplay): Add first sentence of doc-string on
1330 separate line.
1331 (Frecenter): Fix doc-string typo.
1332
1333 2011-12-11 Kenichi Handa <handa@m17n.org>
1334
1335 * coding.c (Funencodable_char_position): Pay attention to the
1336 buffer text relocation (Bug#9389).
1337
1338 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1339
1340 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1341 gtk_init (Bug#10100).
1342
1343 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1344
1345 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1346 IT->string is nil. (Bug#10263)
1347
1348 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1349
1350 * nsterm.h (x_free_frame_resources): Declare.
1351
1352 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1353 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1354
1355 * nsterm.h (ns_get_defaults_value): Declare.
1356
1357 * nsterm.m (ns_default): Call ns_get_defaults_value.
1358
1359 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1360
1361 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1362 (Bug#10170)
1363
1364 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1365
1366 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1367 that where the value of an _OBJC_* symbol points to is in the .bss
1368 section (Bug#10240).
1369
1370 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1371
1372 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1373 after the loop to call ccl_driver at least once (Bug#8619).
1374
1375 2011-12-08 Kenichi Handa <handa@m17n.org>
1376
1377 * ftfont.c (get_adstyle_property): Fix previous change
1378 (Bug#10233).
1379
1380 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1381
1382 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1383 dirs from the default value of EMACSLOADPATH (bug#10208).
1384
1385 2011-12-07 Glenn Morris <rgm@gnu.org>
1386
1387 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1388 installation and source directories as well. (Bug#10208)
1389
1390 2011-12-06 Chong Yidong <cyd@gnu.org>
1391
1392 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1393
1394 2011-12-06 Glenn Morris <rgm@gnu.org>
1395
1396 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1397 as an error, not just -1. (Bug#10217)
1398
1399 2011-12-05 Chong Yidong <cyd@gnu.org>
1400
1401 * keyboard.c (process_special_events): New function.
1402 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1403
1404 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1405
1406 * coding.c (encode_designation_at_bol): Don't use uninitialized
1407 local variable (Bug#9318).
1408
1409 2011-12-05 Kenichi Handa <handa@m17n.org>
1410
1411 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1412 return Qnil (Bug#8046, Bug#10193).
1413
1414 2011-12-05 Kenichi Handa <handa@m17n.org>
1415
1416 * coding.c (encode_designation_at_bol): New args charbuf_end and
1417 dst. Return the number of produced bytes. Callers changed.
1418 (coding_set_source): Return how many bytes coding->source was
1419 relocated.
1420 (coding_set_destination): Return how many bytes
1421 coding->destination was relocated.
1422 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1423 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1424
1425 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1426
1427 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1428 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1429 macro (Bug#9318).
1430
1431 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1432
1433 The following changes are to fix Bug#9318.
1434
1435 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1436 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1437 (encode_coding_iso_2022, encode_coding_sjis)
1438 (encode_coding_big5, encode_coding_charset): Use the above macros.
1439
1440 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1441
1442 * lisp.h (process_quit_flag): Fix external declaration.
1443
1444 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1445
1446 Don't macro-inline non-performance-critical code.
1447 * eval.c (process_quit_flag): New function.
1448 * lisp.h (QUIT): Use it.
1449
1450 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1451
1452 * nsfns.m (get_geometry_from_preferences): New function.
1453 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1454
1455 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1456
1457 * emacs.c (Qkill_emacs): Define.
1458 (syms_of_emacs): Initialize it.
1459 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1460 Qquit_flag to `kill-emacs' instead.
1461 (quit_throw_to_read_char): Add parameter `from_signal'.
1462 All callers changed. Call Fkill_emacs if requested and safe.
1463 * lisp.h (QUIT): Call Fkill_emacs if requested.
1464
1465 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1466
1467 * widget.c (update_wm_hints): Return if wmshell is null.
1468 (widget_update_wm_size_hints): New function.
1469
1470 * widget.h (widget_update_wm_size_hints): Declare.
1471
1472 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1473 widget_update_wm_size_hints (Bug#10104).
1474
1475 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1476
1477 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1478 before a newline, prepare the bidi iterator for consuming the
1479 newline, and keep the current paragraph direction. (Bug#10183)
1480 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1481
1482 2011-12-02 Juri Linkov <juri@jurta.org>
1483
1484 * search.c (Fword_search_regexp): New Lisp function created from
1485 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1486 (Fword_search_backward, Fword_search_forward)
1487 (Fword_search_backward_lax, Fword_search_forward_lax):
1488 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1489 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1490
1491 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1492
1493 * fileio.c (Finsert_file_contents): Move after-change-function call
1494 to before the "handled:" label, since all "goto handled" appear in
1495 cases where the *-change-functions have already been properly called
1496 (bug#10117).
1497
1498 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1499
1500 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1501 waiting for input. (Bug#10169)
1502
1503 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1504
1505 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1506 verifies glyph row's hash code--we have just reallocated the
1507 glyphs, so their contents can be complete garbage. (Bug#10164)
1508
1509 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1512
1513 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1514
1515 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1516 attributes are tested _before_ calling verify_row_hash, to protect
1517 against GCC re-ordering of the tests. (Bug#10164)
1518
1519 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1520
1521 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1522
1523 * xterm.c (handle_one_xevent): Only set async_visible and friends
1524 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1525 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1526 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1527
1528 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1529
1530 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1531 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1532 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1533 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1534 All uses changed to use GCPRO1 etc.
1535 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1536 Revert to old implementation (i.e., before 2011-03-11).
1537
1538 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1539
1540 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1541 of scroll runs so as to avoid assigning disabled bogus rows and
1542 unnecessary graphics copy operations.
1543
1544 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1545
1546 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1547 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1548 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1549 (malloc, free, realloc, calloc): Redirect to e_* only when
1550 compiling Emacs.
1551
1552 * lisp.h (GCTYPEBITS): Move before first use.
1553 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1554 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1555 this macro definition.
1556
1557 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1558 _MSC_VER.
1559
1560 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1561
1562 * gtkutil.c (xg_create_frame_widgets):
1563 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1564 present with Gtk+ 2.0.
1565
1566 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1567
1568 * fileio.c (Finsert_file_contents): Undo previous change; see
1569 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1570
1571 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 Rename locals to avoid shadowing.
1574 * fileio.c (Finsert_file_contents):
1575 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1576 * process.c (wait_reading_process_output):
1577 Rename inner 'proc' to 'p' to avoid shadowing.
1578 Indent for consistency with usual Emacs style.
1579
1580 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1581
1582 * xdisp.c (redisplay_window): If cursor row is not fully visible
1583 after recentering, and scroll-conservatively is set to a large
1584 number, scroll window by a few more lines to make the cursor fully
1585 visible and out of scroll-margin. (Bug#10105)
1586 (start_display): Don't move to the next line if the display should
1587 start at a newline that is part of a display vector or an overlay
1588 string. (Bug#10119)
1589
1590 2011-11-24 Juri Linkov <juri@jurta.org>
1591
1592 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1593 after the `MagickPingImage' call. (Bug#10112)
1594
1595 2011-11-23 Chong Yidong <cyd@gnu.org>
1596
1597 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1598
1599 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1600
1601 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1602 making another buffer current. (Bug#10114)
1603
1604 2011-11-23 Glenn Morris <rgm@gnu.org>
1605
1606 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1607
1608 2011-11-23 Chong Yidong <cyd@gnu.org>
1609
1610 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1611 using it (Bug#5984).
1612
1613 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1614
1615 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1616 and header-lines, as they don't have one computed for them.
1617 (Bug#10098)
1618
1619 * .gdbinit (prow): Make displayed values more self-explaining.
1620 Add row's hash code.
1621
1622 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1623
1624 * process.c (wait_reading_process_output): Fix asynchrounous
1625 GnuTLS socket handling on some versions of the GnuTLS library.
1626 (wait_reading_process_output): Add comment and URL.
1627
1628 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1629
1630 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1631
1632 2011-11-21 Chong Yidong <cyd@gnu.org>
1633
1634 * window.c (Fnext_window, Fprevious_window): Doc fix.
1635
1636 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1637
1638 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1639
1640 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1641
1642 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1643
1644 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1645
1646 * window.c (Fset_window_combination_limit): Rename argument
1647 STATUS to LIMIT.
1648 (Vwindow_combination_limit): Remove "status" from doc-string.
1649
1650 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1651
1652 * m/ibms390.h: Remove.
1653 * m/ibms390x.h: Don't include "ibms390.h".
1654
1655 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1656
1657 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1658 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1659
1660 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * casetab.c (Fset_case_table):
1663 * charset.c (Fcharset_after): Fix typos.
1664
1665 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1668 Otherwise, valgrind does not work on some platforms.
1669 Problem reported by Andreas Schwab in
1670 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1671 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1672 is set, removing the need for VIRT_ADDRESS_VARIES.
1673 (PURE_P): Use a more-efficient implementation that needs just one
1674 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1675 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1676 to 4 (xorl, subq, cmpq, setbe).
1677 * alloc.c (pure): Always extern now, since that's the
1678 VIRT_ADDR_VARIES behavior.
1679 (PURE_POINTER_P): Use a single comparison, not two, for
1680 consistency with the new puresize.h.
1681 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1682 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1683 Remove VIRT_ADDR_VARIES no longer needed.
1684
1685 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1686
1687 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1688 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1689 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1690 behave as if the cursor position were at the window margin.
1691
1692 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1693 and the cursor position is out of bounds, behave as if the cursor
1694 position were at the window margin. (Bug#10075)
1695
1696 2011-11-18 Chong Yidong <cyd@gnu.org>
1697
1698 * window.c (Fwindow_combination_limit): Make first argument
1699 non-optional, since it is meaningless for live windows like the
1700 selected window.
1701
1702 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1703
1704 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1705
1706 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1707
1708 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1709 (graft_intervals_into_buffer): Simplify.
1710
1711 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1712
1713 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1714 hash values of the two rows.
1715 (copy_row_except_pointers): Preserve the used[] arrays and the
1716 hash values of the two rows. (Bug#10035)
1717 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1718
1719 * xdisp.c (row_hash): New function, body extracted from
1720 compute_line_metrics.
1721 (compute_line_metrics): Call row_hash, instead of computing the
1722 hash code inline.
1723
1724 * dispnew.c (verify_row_hash): Call row_hash for computing the
1725 hash code of a row, instead of duplicating code from xdisp.c.
1726
1727 * dispextern.h (row_hash): Add prototype.
1728
1729 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1730
1731 * frame.c (delete_frame): Don't delete the terminal when the last
1732 X frame is closed if emacs is built with GTK toolkit.
1733
1734 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1737
1738 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1739
1740 * window.c (Vwindow_splits): Rename to
1741 Vwindow_combination_resize. Suggested by Juri Linkov.
1742 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1743 of Vwindow_splits.
1744
1745 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1746
1747 * nsfns.m (Fns_font_name):
1748 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1749
1750 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1751
1752 * window.h (window): Rename slot "nest" to "combination_limit".
1753 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1754 (Fset_window_nest): Rename to Fset_window_combination_limit.
1755 (Vwindow_nest): Rename to Vwindow_combination_limit.
1756 (recombine_windows, make_parent_window, make_window)
1757 (Fsplit_window_internal, saved_window)
1758 (Fset_window_configuration, save_window_save): Rename all
1759 occurrences of window_nest to window_combination_limit.
1760
1761 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1762
1763 * image.c (imagemagick_load_image): Fix typo.
1764
1765 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1766
1767 * xdisp.c (display_line): Move the call to
1768 highlight_trailing_whitespace before the call to
1769 compute_line_metrics, since the latter needs to see the final
1770 faces of all the glyphs to compute ROW's hash value.
1771 Fixes assertion violations in row_equal_p. (Bug#10035)
1772
1773 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1774
1775 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1776 just return (bug#10044).
1777
1778 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1779
1780 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1781 with user-defined heap size. Bump the default size of the temacs
1782 heap to 27MB, to avoid memory warning when running temacs.
1783 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1784
1785 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1786 current_matrix and desired_matrix. (Bug#9990)
1787 (verify_row_hash) [XASSERTS]: New function.
1788 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1789 that the hash value of glyph rows is correct.
1790
1791 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1792
1793 * window.h (window): Remove splits slot.
1794 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1795 (Fdelete_other_windows_internal, make_parent_window)
1796 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1797 (Fset_window_configuration, save_window_save): Don't deal with
1798 split status of windows.
1799 (saved_window): Remove splits slot.
1800 (Vwindow_splits): Rewrite doc-string.
1801
1802 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1803
1804 * xfns.c (unwind_create_frame):
1805 * nsfns.m (unwind_create_frame):
1806 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1807 Vframe_list (Bug#9999).
1808
1809 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1810
1811 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1812
1813 2011-11-11 Kenichi Handa <handa@m17n.org>
1814
1815 * callproc.c (Fcall_process): Set the member dst_multibyte of
1816 process_coding.
1817
1818 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1819
1820 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1821 avoid a crash (bug#9496).
1822
1823 2011-11-09 Chong Yidong <cyd@gnu.org>
1824
1825 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1826 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1827
1828 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1831
1832 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1833
1834 Avoid some portability problems by eschewing 'extern inline' functions.
1835 The trivial performance wins aren't worth the portability hassles; see
1836 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1837 et seq.
1838 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1839 (window_box_width, window_box_left, window_box_left_offset)
1840 (window_box_right, window_box_right_offset): Undo previous change,
1841 by removing the "extern"s.
1842 * intervals.c (adjust_intervals_for_insertion)
1843 (adjust_intervals_for_deletion): Undo previous change,
1844 making these static again.
1845 (offset_intervals, temp_set_point_both, temp_set_point)
1846 (copy_intervals_to_string): No longer inline.
1847 * xdisp.c (window_text_bottom_y, window_box_width)
1848 (window_box_height, window_box_left_offset)
1849 (window_box_right_offset, window_box_left, window_box_right)
1850 (window_box): No longer inline.
1851
1852 2011-11-08 Chong Yidong <cyd@gnu.org>
1853
1854 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1855 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1856 Signal an error if not a live window.
1857 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1858 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1859
1860 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * lisp.h (syms_of_abbrev): Remove declaration.
1863 Reported by CHENG Gao <chenggao@royau.me>.
1864
1865 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1866
1867 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1868 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1869 of temacs in GUI mode.
1870
1871 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1872
1873 * window.h: Declare delete_all_child_windows instead of
1874 delete_all_subwindows.
1875 * window.c (Fwindow_nest, Fset_window_nest)
1876 (Fset_window_new_total, Fset_window_new_normal)
1877 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1878 (delete_all_subwindows): Rename to delete_all_child_windows.
1879 (Fdelete_other_windows_internal, Fset_window_configuration):
1880 Call delete_all_child_windows instead of delete_all_subwindows.
1881 * frame.c (delete_frame): Call delete_all_child_windows instead
1882 of delete_all_subwindows.
1883
1884 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1885
1886 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1887 This is also needed for porting to any host where GC_MARK_STACK is
1888 not GC_MAKE_GCPROS_NOOPS.
1889 (which_symbols): Use it.
1890
1891 2011-11-07 Kenichi Handa <handa@m17n.org>
1892
1893 * coding.c (coding_set_destination): Check coding->src_pos only
1894 when coding->src_object is a buffer (bug#9910).
1895
1896 * process.c (send_process): Set the member src_multibyte of coding
1897 to 0 (bug#9911) when sending a unibyte text.
1898
1899 * callproc.c (Fcall_process): Set the member src_multibyte of
1900 process_coding to 0 (bug#9912).
1901
1902 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1903
1904 * xmenu.c (cleanup_widget_value_tree): New function.
1905 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1906 calling free_menubar_widget_value_tree directly (Bug#9830).
1907
1908 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 Fix some portability problems with 'inline'.
1911 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1912 (window_box_width, window_box_left, window_box_left_offset)
1913 (window_box_right, window_box_right_offset): Declare extern.
1914 Otherwise, these inline functions do not conform to C99 and
1915 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1916 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1917 * intervals.c (adjust_intervals_for_insertion)
1918 (adjust_intervals_for_deletion): Now extern, because otherwise the
1919 extern inline functions 'offset_intervals' couldn't refer to it.
1920 (static_offset_intervals): Remove.
1921 (offset_intervals): Rewrite using the old contents of
1922 static_offset_intervals. The old version didn't conform to C99
1923 because an extern inline function contained a reference to an
1924 identifier with static linkage.
1925
1926 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1927
1928 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1929 GC.
1930
1931 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1932
1933 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1934 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1935 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1936 return Qleft_to_right.
1937
1938 2011-11-06 Chong Yidong <cyd@gnu.org>
1939
1940 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1941 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1942 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1943 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1944 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1945 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1946 (Fwindow_vscroll): Doc fix.
1947 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1948 argument, since it makes no sense to pass a live window and for
1949 consistency with window-child.
1950
1951 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1952
1953 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1954 support MSVC.
1955
1956 2011-11-05 Jason Rumney <jasonr@gnu.org>
1957
1958 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1959 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1960 fonts (Bug#6029).
1961 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1962 bitwise arithmetic preventing use of unicode-sip and non-truetype
1963 opentype fonts.
1964
1965 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1966
1967 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1968 "emacs"-only part.
1969
1970 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1971 initialization code to keep similarity to xfns.c after changes
1972 from 2011-11-05.
1973
1974 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1975
1976 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1977 (unwind_create_frame): New function (Bug#9943).
1978 (Fx_create_frame): Restructure code to be more similar to the one in
1979 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1980 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1981 Move terminal->reference_count++ just before making the frame official
1982 (Bug#9943).
1983
1984 * nsterm.m (x_free_frame_resources): New function.
1985 (x_destroy_window): Move code to x_free_frame_resources.
1986
1987 * xfns.c (unwind_create_frame): Fix comment.
1988 (Fx_create_frame, x_create_tip_frame):
1989 Move terminal->reference_count++ just before making the frame
1990 official. Move initialization of image_cache_refcount and
1991 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1992
1993 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1994
1995 Support MSVC build with newer versions of Visual Studio.
1996 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1997 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1998 nt/gmake.defs.
1999
2000 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2001 which are not supported by MSVC.
2002 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2003 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2004 bitfields.
2005 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2006 types in bitfields.
2007 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2008
2009 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2010
2011 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2012
2013 Support MSVC build with newer versions of Visual Studio.
2014 * w32.c: Don't include w32api.h for MSVC.
2015 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2016
2017 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2018 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2019 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2020 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2021 e_* cousins.
2022 (alloca) [_MSC_VER]: Define to _alloca.
2023
2024 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2025
2026 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2027
2028 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2029
2030 * xdisp.c (note_mouse_highlight): If either of
2031 previous/next-single-property-change returns nil, treat that as
2032 the beginning or the end of the buffer. (Bug#9955)
2033
2034 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2035
2036 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2037 label is not null (Bug#9951).
2038 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2039 may be NULL.
2040
2041 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2042
2043 * window.c (Fwindow_body_size): Mention in the doc string that the
2044 return value is in frame's canonical units. (Bug#9949)
2045
2046 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2047
2048 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2049
2050 * w32fns.c (unwind_create_frame): If needed, free the glyph
2051 matrices of the partially constructed frame. (Bug#9943)
2052 * xfns.c (unwind_create_frame): Likewise.
2053
2054 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2055
2056 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2057 Don't stop backward scan on the continuation glyph, even though
2058 its CHARPOS is positive.
2059 (mouse_face_from_buffer_pos, note_mouse_highlight):
2060 Rename cover_string to disp_string.
2061
2062 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2063
2064 * window.c (temp_output_buffer_show): Don't use
2065 Vtemp_buffer_show_specifiers.
2066 (Vtemp_buffer_show_specifiers): Remove unused variable.
2067
2068 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2069
2070 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2071 past the beginning of the current glyph matrix.
2072
2073 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2074
2075 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2076 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2077 HAVE_GTK3 (Bug#9869).
2078
2079 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2080 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2081
2082 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2083
2084 * xterm.c: Declare x_handle_net_wm_state to return int.
2085 (handle_one_xevent): Check if we are iconified but don't have
2086 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2087 (get_current_wm_state): Return non-zero if not hidden,
2088 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2089 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2090 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2091 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2092
2093 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2094
2095 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2096 so that this new function doesn't get optimized away by a
2097 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2098
2099 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2100
2101 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2102
2103 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2104
2105 Fix the `xbytecode' command.
2106 * .gdbinit (xprintbytestr): New command.
2107 (xwhichsymbols): Rename from `which'; all callers changed.
2108 (xbytecode): Print the byte-code string as well.
2109
2110 2011-10-29 Kim Storm <storm@cua.dk>
2111
2112 * alloc.c (which_symbols): New function.
2113
2114 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2115
2116 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2117 line. (Bug#9903)
2118
2119 2011-10-29 Glenn Morris <rgm@gnu.org>
2120
2121 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2122 Not clear what it was for, and it causes various bugs. (Bug#9839)
2123
2124 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2125
2126 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2127 possible random value that matches one of those tested as
2128 condition to clear the mouse face.
2129
2130 2011-10-28 Chong Yidong <cyd@gnu.org>
2131
2132 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2133
2134 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2135
2136 * window.c (make_window): Initialize phys_cursor_on_p.
2137
2138 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2139
2140 * lisp.h (struct Lisp_Symbol): Update comments.
2141
2142 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2145
2146 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2147
2148 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2149 <oslsachem@gmail.com> for helping to debug this.
2150
2151 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2152 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2153 (g_b_init_get_glyph_outline_w): New static variables.
2154 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2155 (GetGlyphOutlineW_Proc): New typedefs.
2156 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2157 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2158 New functions.
2159 (w32font_open_internal, compute_metrics):
2160 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2161 instead of calling the "wide" APIs directly.
2162
2163 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2164
2165 * w32.h (syms_of_w32font): Add prototype.
2166
2167 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2168
2169 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2170 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2171 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2172 (Fmove_to_window_line): Doc fix.
2173
2174 2011-10-27 Chong Yidong <cyd@gnu.org>
2175
2176 * process.c (make_process): Set gnutls_state to NULL.
2177
2178 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2179 non-NULL, regardless of GNUTLS_INITSTAGE.
2180 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2181 an error. Set process slots as soon as we allocate them.
2182
2183 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2184
2185 2011-10-27 Chong Yidong <cyd@gnu.org>
2186
2187 * gnutls.c (emacs_gnutls_deinit): New function.
2188 Deallocate credentials structures as well as calling gnutls_deinit.
2189 (Fgnutls_deinit, Fgnutls_boot): Use it.
2190
2191 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2192 (deactivate_process): Call emacs_gnutls_deinit.
2193
2194 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2195
2196 * image.c (x_create_x_image_and_pixmap):
2197 * w32.c (sys_rename, w32_delayed_load):
2198 * w32font.c (fill_in_logfont):
2199 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2200
2201 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2202
2203 * w32fns.c (w32_default_color_map): New function,
2204 extracted from Fw32_default_color_map.
2205 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2206
2207 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2210
2211 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2212
2213 * keyboard.c (test_undefined): New function (bug#9751).
2214 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2215
2216 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2217
2218 * sysdep.c (init_sys_modes): Fix the check for the controlling
2219 terminal (Bug#6649).
2220
2221 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2222
2223 * dispextern.h (struct bidi_it): New member next_en_type.
2224
2225 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2226 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2227 current character, check also for next_en_type being WEAK_EN.
2228 (bidi_resolve_weak): Don't enter the expensive loop if the current
2229 position is before next_en_pos. Record the bidi type of the first
2230 non-ET, non-BN character we find, in addition to its position.
2231 (bidi_level_of_next_char): Invalidate next_en_type when
2232 next_en_pos is over-stepped.
2233
2234 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2237 * editfns.c: Rewrite current-time-zone so that it invokes
2238 the equivalent of (format-time-string "%Z") to get the time zone name.
2239 This fixes a bug when the time zone name contains characters that
2240 need converting from the system time locale to Emacs internal format.
2241 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2242 that patch fixed format-time-string to do the conversion, but
2243 I forgot to fix current-time-zone.
2244 (format_time_string): New function, containing most of
2245 what Fformat_time_string used to contain.
2246 (Fformat_time_string): Rewrite in terms of format_time_string.
2247 This doesn't change this function's behavior.
2248 (current-time-zone): Rewrite to use format_time_string.
2249 This fixes the bug reported by Michael Schierl in
2250 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2251 Jason Rumney's 2007-06-07 change worked around this bug, but
2252 didn't fix it.
2253 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2254
2255 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2256
2257 * xdisp.c (start_display): If the character at POS is displayed
2258 via a display vector, reset IT->current.dpvec_index to zero.
2259 (try_window_reusing_current_matrix): If a line ends in a display
2260 vector or the next line starts in a display vector, continue
2261 redrawing the window even though the character position of
2262 start_row was reached.
2263 (Bug#9771, part 2)
2264
2265 2011-10-18 Chong Yidong <cyd@gnu.org>
2266
2267 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2268 with nobreak-char-display too.
2269
2270 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2271
2272 Fix part 3 of bug#9771.
2273 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2274 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2275 non-neutral characters if the current character is a paragraph
2276 separator (a.k.a. Newline). This avoids running the same
2277 expensive loop twice, once when we consume the preceding newline
2278 and the other time when the line actually needs to be displayed.
2279 Avoid the loop when we see neutrals on the base embedding level
2280 following a character whose directionality is the same as the
2281 paragraph's. This avoids running the expensive loop when a line
2282 ends in a long sequence of neutrals, like control characters.
2283 Add assertion against STRONG_AL type. Slightly rearrange code
2284 that determines the type of a neutral given the first non-neutral
2285 that follows it.
2286 (bidi_level_of_next_char): Set next_en_pos to zero when
2287 invalidating its info.
2288
2289 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2290
2291 * xdisp.c (push_display_prop): Determine whether to record string
2292 or buffer position by IT->string, not by IT->method. Allow
2293 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2294 (move_it_vertically_backward): Don't look for character position
2295 immediately after the newline when in a continuation line.
2296 (Bug#9771, part 1)
2297
2298 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2299
2300 * window.c (coordinates_in_window): Rewrite and delabelize
2301 vertical border check. (Bug#5357) (Bug#9618)
2302
2303 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2304
2305 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2306 errors in XSetWindowBorder (bug#9310).
2307
2308 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2309
2310 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2311 avoid crash when xmalloc overrun checking is enabled.
2312
2313 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2314
2315 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2316 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2317 cursor motion with <left> and <right> arrow keys.
2318
2319 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2320 some callers set that themselves.
2321
2322 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2323
2324 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2325 display string and the previous row comes from the same string and
2326 is empty. (Bug#9739) (Bug#9738)
2327
2328 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2329
2330 * doc.c (get_doc_string): Encode file name (bug#9735).
2331
2332 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2333
2334 * bidi.c (bidi_level_of_next_char):
2335 * xdisp.c (get_visually_first_element): Remove old incorrect
2336 comments regarding the Unicode Line Separator character.
2337
2338 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2339
2340 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2341
2342 * alloc.c (Fgc_status): Do not access beyond zombies array
2343 boundary if nzombies > MAX_ZOMBIES.
2344 * alloc.c (dump_zombies): Add missing format specifier.
2345
2346 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2347
2348 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2349 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2350
2351 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2352 Some packages use them to denote characters with modifiers.
2353
2354 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2355
2356 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2357 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2358 matching a pp-number. Rename parameter var to var1.
2359
2360 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2361
2362 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2363
2364 2011-10-08 Glenn Morris <rgm@gnu.org>
2365
2366 * callint.c (Fcall_interactively): Give a more explicit error for the
2367 'c' case with a non-character input. (Bug#8479)
2368
2369 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2370
2371 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2372 lines.
2373 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2374 lines that are hscrolled on the left.
2375
2376 * dispnew.c (buffer_posn_from_coords): Account for a possible
2377 presence of header-line. (Bug#4426)
2378
2379 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2380
2381 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2382 Don't advertise functionality which we discourage or doesn't work.
2383
2384 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2385
2386 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2387 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2388 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2389 this makes Emacs dump core during garbage collection on rare
2390 occasions. sizeof is obviously inferior to offsetof here, so
2391 stick with offsetof.
2392 (GC_POINTER_ALIGNMENT): New macro.
2393 (mark_memory): Omit 3rd (offset) arg; caller changed.
2394 Don't assume EMACS_INT alignment is the same as pointer alignment.
2395
2396 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2397
2398 * keyboard.c (read_key_sequence_remapped): New var.
2399 (read_key_sequence): Compute remapping in the right buffer.
2400 (command_loop_1): Use read_key_sequence's remapping directly.
2401
2402 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2403
2404 * dired.c (file_name_completion): Don't expand file name.
2405 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2406 before checking file name handler.
2407
2408 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2409 they've been requested explicitly (bug#9591).
2410
2411 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2412
2413 * keymap.c (Fsingle_key_description): Use make_specified_string
2414 instead of build_string to build string from push_key_description.
2415 (Bug#5193)
2416
2417 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2418
2419 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2420 This fixes a Y2038 bug on 64-bit hosts.
2421 * buffer.c (reset_buffer):
2422 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2423 (Fclear_buffer_auto_save_failure):
2424 Use 0, not -1, to represent an unset failure time, since time_t
2425 might not be signed.
2426
2427 Remove dependency on glibc malloc internals.
2428 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2429 Move back here from lisp.h, but with their new implementations.
2430 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2431 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2432 * charset.c (charset_table_init): New static var.
2433 (syms_of_charset): Use it instead of xmalloc. This removes a
2434 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2435 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2436 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2437 Move back to alloc.c.
2438 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2439 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2440
2441 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2442
2443 * nsterm.m (windowDidResize): Call x_set_window_size only when
2444 ns_in_resize is true. Otherwise set pixelwidth/height and
2445 call change_frame_size (Bug#9628).
2446
2447 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 Port --enable-checking=all to Fedora 14 x86-64.
2450 * charset.c (syms_of_charset): Also account for glibc malloc's
2451 internal overhead when calculating the initial malloc maximum.
2452
2453 Port --enable-checking=all to Fedora 14 x86.
2454 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2455 Move to lisp.h.
2456 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2457 (overrun_check_realloc, overrun_check_free):
2458 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2459 That way, xmalloc returns a properly-aligned pointer even if
2460 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2461 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2462 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2463 into account when calculating the initial malloc maximum.
2464 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2465 Move here from alloc.c, so that charset.c can use it too.
2466 Properly align; the old code wasn't right for common 32-bit hosts
2467 when configured with --enable-checking=all.
2468 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2469 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2470
2471 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2472
2473 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2474 use EDOM.
2475
2476 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2477
2478 * xdisp.c (compute_display_string_end): If there's no display
2479 string at CHARPOS, return -1.
2480
2481 * bidi.c (bidi_fetch_char): When compute_display_string_end
2482 returns a negative value, treat the character as a normal
2483 character not covered by a display string. (Bug#9624)
2484
2485 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2486
2487 * lread.c (Fread_from_string): Fix typo in docstring.
2488
2489 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2490
2491 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2492 newline, reseat the iterator instead of bidi-iterating there one
2493 character at a time. (Bug#9610)
2494 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2495 TO_CHARPOS if the bidi iterator is at base embedding level.
2496
2497 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2498
2499 * lread.c (readevalloop): Use correct code for NBSP.
2500 (read1): Likewise. (Bug#9608)
2501
2502 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2503
2504 * dbusbind.c (Fdbus_register_signal): When service is not
2505 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2506
2507 2011-09-25 Glenn Morris <rgm@gnu.org>
2508
2509 * buffer.c (truncate-lines): Doc fix.
2510
2511 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2512
2513 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2514 (Fset_window_next_buffers): Doc fix.
2515
2516 2011-09-24 Glenn Morris <rgm@gnu.org>
2517
2518 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2519
2520 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 Fix minor problems found by static checking.
2523 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2524 * indent.c (Fvertical_motion): Fix == vs = typo.
2525
2526 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2527
2528 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2529 Default value is now t. Doc fix.
2530
2531 * indent.c (Fvertical_motion): Compute and apply the overshoot
2532 logic when moving up, not only when moving down. Fix the
2533 confusing name and values of the it_overshoot_expected variable;
2534 logic changes accordingly. (Bug#9254) (Bug#9549)
2535
2536 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2537 CHARPOS is covered by a display string which includes newlines.
2538 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2539 is covered by a display string with embedded newlines.
2540
2541 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2542
2543 * dbusbind.c (Fdbus_register_signal): Add match rule to
2544 Vdbus_registered_objects_table. (Bug#9581)
2545 (Fdbus_register_method, Vdbus_registered_objects_table):
2546 Fix docstring.
2547
2548 2011-09-24 Jim Meyering <meyering@redhat.com>
2549
2550 do not ignore write error for any output size
2551 The previous change was incomplete.
2552 While it makes emacs --batch detect the vast majority of stdout
2553 write failures, errors were still ignored whenever the output size is
2554 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2555 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2556 && echo FAIL: ignored write error
2557 FAIL: ignored write error
2558 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2559 && echo FAIL: ignored write error
2560 FAIL: ignored write error
2561 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2562
2563 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2564
2565 * emacs.c (Fkill_emacs): In noninteractive mode exit
2566 non-successfully if a write error occurred on stdout. (Bug#9574)
2567
2568 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2569
2570 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2571 the xassert test.
2572
2573 * dispextern.h (struct it): Update the comment documenting what
2574 can it->OBJECT be.
2575
2576 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2577
2578 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2579 a display string, extend search for cursor position to end of row.
2580 (find_row_edges): If the row ends in a newline from a display
2581 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2582 Handle the case of a display string with multiple newlines.
2583 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2584 non-empty line. Fixes confusing cursor motion with arrow keys at
2585 the beginning of a line that starts with whitespace.
2586
2587 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2588
2589 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2590 (bug#9493).
2591
2592 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2593
2594 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2595 boolean (Bug#9154).
2596
2597 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2598
2599 * xdisp.c (display_line): Record maximum and minimum buffer
2600 positions even if no glyphs were produced (e.g., by a zero-width
2601 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2602 buffer positions that will be removed from the glyph row because
2603 they don't fit.
2604 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2605 column is beyond frame width: don't subtract 1 "pixel" when
2606 computing width of the stretch.
2607 (reseat_at_next_visible_line_start): Undo the change made on
2608 2011-09-17 that saved paragraph information and restored it after
2609 the call to `reseat'. (Bug#9545)
2610
2611 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2612
2613 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2614 and turn window cursor on if cleared (Bug#9415).
2615
2616 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2617
2618 * search.c (boyer_moore): Take unibyte characters from pattern
2619 literally. (Bug#9458)
2620
2621 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2624
2625 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 Fix minor problem found by static checking.
2628 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2629 initialized, to pacify gcc -Wuninitialized.
2630
2631 * fileio.c: Report proper errno when syscall falls.
2632 (Finsert_file_contents): Save and restore errno,
2633 so that report_file_error outputs the correct diagnostic.
2634 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2635
2636 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2637
2638 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2639
2640 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2641
2642 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2643 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2644
2645 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2646
2647 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2648 about the current paragraph and restore it after the call to reseat.
2649
2650 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2651 (bidi_find_paragraph_start): Search back for paragraph beginning
2652 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2653 (bidi_move_to_visually_next): Only trigger paragraph-related
2654 computations when the last character is a newline or at EOB, not
2655 just any NEUTRAL_B. (Bug#9470)
2656
2657 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2658 truncated lines if point is covered by a display string. (Bug#9524)
2659
2660 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2661
2662 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2663 (cons_to_x_long): New function.
2664 (lisp_data_to_selection_data): Use it. Correct the test for
2665 short-versus-long data; it was negated. Break out of vector
2666 loop, for efficiency, when a long datum is discovered.
2667
2668 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2669
2670 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2671
2672 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2673
2674 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2675 GCC PR/17406) by declaring this function with external scope.
2676
2677 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2678
2679 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2680 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2681
2682 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2683
2684 * editfns.c (Fformat): Correctly handle text properties on "%%".
2685
2686 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2687
2688 * xterm.c (x_draw_composite_glyph_string_foreground):
2689 * w32term.c (x_draw_composite_glyph_string_foreground):
2690 * term.c (encode_terminal_code):
2691 * composite.c (composition_update_it, get_composition_id):
2692 * xdisp.c (get_next_display_element)
2693 (fill_composite_glyph_string): Add comments about special meaning
2694 of TAB characters in a composition.
2695
2696 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2699 This occurs when processing a multibyte format.
2700 Problem reported by Wolfgang Jenker.
2701
2702 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2703
2704 * xdisp.c (try_cursor_movement): Only check for exact match if
2705 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2706
2707 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2708
2709 Remove unused external symbols.
2710 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2711 * xdisp.c (calc_pixel_width_or_height): Now static.
2712 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2713 * indent.c (check_display_width):
2714 * w32term.c: Fix comment to match code.
2715 * xterm.c, xterm.h (x_catching_errors): Remove.
2716
2717 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 * xselect.c: Use signed conversions more consistently (Bug#9498).
2720 (selection_data_to_lisp_data): Assume incoming selection data are
2721 signed integers, not unsigned. This is to be consistent with
2722 outgoing selection data, which was modified to use signed integers
2723 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2724 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2725 expects long, not unsigned long.
2726
2727 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2728
2729 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2730 computation of loop end. Reported by Johan Bockgård
2731 <bojohan@gnu.org>.
2732
2733 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2734
2735 * frame.c (Fother_visible_frames_p): Function deleted.
2736
2737 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2738
2739 * indent.c (compute_motion): Process display vector front to back
2740 rather than the other way around. (Bug#2496)
2741
2742 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2743
2744 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2745
2746 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2747
2748 * minibuf.c (Fread_from_minibuffer): Doc fix.
2749
2750 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2751
2752 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2753 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2754
2755 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2756
2757 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2758 value for non-existent files.
2759
2760 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2761
2762 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2763 set its "size" to -1. This will set the modtime_size field of
2764 the corresponding buffer to -1, which is what
2765 verify-visited-file-modtime expects for files that do not exist.
2766 (Bug#9139)
2767
2768 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2769
2770 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2771 here ...
2772 * lisp.h: ... from here. push_key_description is no longer
2773 defined in keyboard.c, so its declaration should not be in
2774 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2775 logically belongs with push_key_description.
2776
2777 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 * buffer.h: Include <sys/types.h> instead of <time.h>.
2780 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2781 Problem reported by Herbert J. Skuhra.
2782
2783 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2784
2785 * xml.c (parse_region): Make the parsing work for
2786 non-comment-starting XML files again (bug#9144).
2787
2788 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2789
2790 * image.c (gif_load): Fix calculation of bottom and right corner.
2791 (Bug#9468)
2792
2793 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2794
2795 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2796 redisplay in small windows.
2797
2798 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2799
2800 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2801
2802 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2803
2804 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2805 Operate on live windows only.
2806
2807 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2808
2809 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2810
2811 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2812
2813 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2814 only under bidi iteration.
2815
2816 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2817
2818 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2819
2820 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2823 Without this fix, the command to link temacs failed due to an
2824 undefined symbol __builtin_isnan. This is because
2825 /usr/include/iso/math_c99.h #defines isnan(x) to
2826 __builtin_isnan(x), but the bundled gcc, which identifies itself
2827 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2828 a __builtin_isnan.
2829 * floatfns.c (isnan): #undef, and then #define to a clone of
2830 what's in data.c.
2831 (Fisnan): Always define, since it's always available now.
2832 (syms_of_floatfns): Always define isnan at the Lisp level.
2833
2834 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2837
2838 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2841 The previous code assumed that file offsets (off_t values) fit in
2842 EMACS_INT variables, which is not true on typical 32-bit hosts.
2843 The code messed up by falsely reporting buffer overflow in cases
2844 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2845 when "big" contains more than 2**29 bytes, even though this
2846 inserts just one byte and does not overflow the buffer.
2847 (Finsert_file_contents): Store file offsets as off_t
2848 values, not as EMACS_INT values. Check for overflow when
2849 converting between EMACS_INT and off_t. When checking for
2850 buffer overflow or for overlap, take the offsets into account.
2851 Don't use EMACS_INT for small values where int suffices.
2852 When checking for overlap, fix a typo: ZV was used where
2853 ZV_BYTE was intended.
2854 (Fwrite_region): Don't assume off_t fits into 'long'.
2855 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2856
2857 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2858
2859 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2860
2861 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 sprintf-related integer and memory overflow issues (Bug#9412).
2864
2865 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2866 (esprintf, exprintf, evxprintf): New functions.
2867 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2868 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2869 (modify_event_symbol): Do not assume that the length of
2870 name_alist_or_stem is safe to alloca and fits in int.
2871 (Fexecute_extended_command): Likewise for function name and binding.
2872 (Frecursion_depth): Wrap around reliably on integer overflow.
2873 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2874 since some callers pass EMACS_INT values.
2875 (Fsingle_key_description): Don't crash if symbol name contains more
2876 than MAX_ALLOCA bytes.
2877 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2878 (get_minibuffer): Arg is now EMACS_INT, not int.
2879 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2880 (esprintf, exprintf, evxprintf): New decls.
2881 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2882
2883 * dbusbind.c (signature_cat): New function.
2884 (xd_signature, Fdbus_register_signal):
2885 Do not overrun buffer; instead, report string overflow.
2886
2887 * dispnew.c (add_window_display_history): Don't overrun buffer.
2888 Truncate instead; this is OK since it's just a log.
2889
2890 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2891 even if the time zone offset is outlandishly large.
2892 Don't mishandle offset == INT_MIN.
2893
2894 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2895 when creating daemon; the previous buffer-overflow check was incorrect.
2896
2897 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2898 which has the guts of the old verror function.
2899
2900 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2901 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2902
2903 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2904 (font_unparse_xlfd): Don't blindly alloca long strings.
2905 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2906 fits in int, when using sprintf. Use single snprintf to count
2907 length of string rather than counting it via multiple sprintfs;
2908 that's simpler and more reliable.
2909 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2910 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2911 sprintf, in case result does not fit in int.
2912
2913 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2914 (fontset_from_font): Print it.
2915
2916 * frame.c (tty_frame_count): Now printmax_t, not int.
2917 (make_terminal_frame, set_term_frame_name): Print it.
2918 (x_report_frame_params): In X, window IDs are unsigned long,
2919 not signed long, so print them as unsigned.
2920 (validate_x_resource_name): Check for implausibly long names,
2921 and don't assume name length fits in 'int'.
2922 (x_get_resource_string): Don't blindly alloca invocation name;
2923 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2924 not fit in int.
2925
2926 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2927 (xg_check_special_colors, xg_set_geometry):
2928 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2929
2930 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2931 Use esprintf, not sprintf, in case result does not fit in int.
2932
2933 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2934 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2935 it as a large positive number.
2936 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2937 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2938
2939 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2940 in case result does not fit in int.
2941
2942 * print.c (float_to_string): Detect width overflow more reliably.
2943 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2944 buffer overrun. Don't assume list length fits in 'int'. Treat
2945 print length of 0 as 0, not as infinity; to be consistent with other
2946 uses of print length in this function. Don't overflow print length
2947 index. Don't assume hash table size fits in 'long', or that
2948 vectorlike size fits in 'unsigned long'.
2949
2950 * process.c (make_process): Use printmax_t, not int, to format
2951 process-name gensyms.
2952
2953 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2954
2955 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2956 to avoid potential buffer overrun.
2957
2958 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2959 if X resource line is longer than 512 bytes.
2960
2961 * xfns.c (x_window): Make sprintf buffer a bit bigger
2962 to avoid potential buffer overrun.
2963
2964 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2965
2966 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2967
2968 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 Integer overflow fixes for scrolling, etc.
2971 Without these, Emacs silently mishandles large integers sometimes.
2972 For example, "C-u 4294967297 M-x recenter" was treated as if
2973 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2974
2975 * xdisp.c (try_window_id): Check Emacs fixnum range before
2976 converting to 'int'.
2977
2978 * window.c (window_scroll_line_based, Frecenter):
2979 Check that an Emacs fixnum is in range before assigning it to 'int'.
2980 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2981 values converted from Emacs fixnums.
2982 (Frecenter): Don't wrap around a line count if it is out of 'int'
2983 range; instead, treat it as an extreme value.
2984 (Fset_window_configuration, compare_window_configurations):
2985 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2986
2987 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2988 that can exceed INT_MAX. Check that EMACS_INT value is in range
2989 before assigning it to the (possibly-narrower) index.
2990 (match_limit): Don't assume that a fixnum can fit in 'int'.
2991
2992 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2993 exceed INT_MAX.
2994
2995 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2996 (Fvertical_motion): Don't wrap around LINES values that don't fit
2997 in 'int'. Instead, treat them as extreme values. This is good
2998 enough for windows, which can't have more than INT_MAX lines anyway.
2999
3000 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3001
3002 * Require libxml/parser.h to avoid compilation warning.
3003
3004 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3005
3006 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3007 since this reportedly can destroy thread storage.
3008
3009 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3010
3011 * syntax.c (find_defun_start): Update all cache variables if
3012 exiting early (Bug#9401).
3013
3014 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3015
3016 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3017
3018 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3019 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3020 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3021
3022 * term.c (tty_append_glyph): New function.
3023 (produce_stretch_glyph): Static function and its prototype deleted.
3024
3025 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3026 Add prototypes.
3027
3028 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3031 when checking :margin (Bug#9390).
3032 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3033 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3034 so that the name doesn't mislead. All uses changed.
3035
3036 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3037
3038 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3039 set_tty_hooks.
3040
3041 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3042
3043 * xdisp.c (move_it_to): Don't bail out early when reaching
3044 position beyond to_charpos, if we are scanning backwards.
3045 (move_it_vertically_backward): When DY == 0, make sure we get to
3046 the first character in the line after the newline.
3047
3048 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3049
3050 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3051 (ccl_driver): Do not generate an out-of-range pointer.
3052 (Fccl_execute_on_string): Remove unnecessary check for
3053 integer overflow, noted by Stefan Monnier in
3054 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3055 Remove a FIXME that didn't need fixing.
3056 Simplify the newly-introduced buffer reallocation code.
3057
3058 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3059
3060 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3061
3062 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 Integer and memory overflow issues (Bug#9196).
3065
3066 * doc.c (get_doc_string): Rework so that
3067 get_doc_string_buffer_size is the actual buffer size, rather than
3068 being 1 less than the actual buffer size; this makes xpalloc more
3069 convenient.
3070
3071 * image.c (x_allocate_bitmap_record, cache_image):
3072 * xselect.c (Fx_register_dnd_atom):
3073 Simplify previous changes by using xpalloc.
3074
3075 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3076 since either will do and ptrdiff_t is convenient with xpalloc.
3077
3078 * charset.c (charset_table_size)
3079 (struct charset_sort_data.priority): Now ptrdiff_t.
3080 (charset_compare): Don't overflow if priorities differ greatly.
3081 (Fsort_charsets): Don't assume list length fits in int.
3082 Check for size-calculation overflow when allocating sort data.
3083 (syms_of_charset): Allocate an initial charset table that is
3084 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3085
3086 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3087
3088 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3089 The actual value is always <= INT_MAX, and leaving it unsigned made
3090 overflow checking harder.
3091
3092 * dispextern.h (struct glyph_matrix.rows_allocated)
3093 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3094 with xpalloc. The values are still always <= INT_MAX.
3095
3096 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3097
3098 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3099 (SAFE_NALLOCA): New macro.
3100
3101 * region-cache.c (struct boundary.pos, find_cache_boundary)
3102 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3103 (set_cache_region, invalidate_region_cache)
3104 (revalidate_region_cache, know_region_cache, region_cache_forward)
3105 (region_cache_backward, pp_cache):
3106 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3107 so that ptrdiff_t * can be passed to xpalloc.
3108 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3109 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3110 (pp_cache): Don't assume cache_len fits in int.
3111 * region-cache.h: Adjust extern decls to match.
3112
3113 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3114 EMACS_INT, since either will do, for xpalloc.
3115
3116 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3117 (xnmalloc, xnrealloc, xpalloc): New functions.
3118
3119 * bidi.c (bidi_shelve_header_size): New constant.
3120 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3121 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3122
3123 * bidi.c (bidi_cache_shrink):
3124 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3125 (overlay_strings):
3126 Don't update size of array until after memory allocation succeeds,
3127 because xmalloc/xrealloc may not return.
3128 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3129 now that we have proper integer overflow checking.
3130 (record_overlay_string, overlay_strings): Catch overflows when
3131 calculating size of overlay_str_buf.
3132
3133 * callproc.c (Fcall_process): Check for size overflow when
3134 calculating size of args2.
3135 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3136 Normally we prefer signed values, but sticking with ptrdiff_t would
3137 require adding more-complicated checks.
3138
3139 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3140 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3141 Redo buffer-overflow calculations to avoid integer overflow.
3142 Add a FIXME comment where memory seems to be over-allocated.
3143
3144 * character.c (Fstring): Check for size-calculation overflow.
3145
3146 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3147 unnecessary integer overflow. Check for size overflow.
3148 (encode_coding_object): Don't update size until xmalloc succeeds.
3149
3150 * composite.c (get_composition_id): Check for overflow in glyph
3151 length calculations.
3152
3153 Integer and memory overflow fixes for display code.
3154 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3155 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3156 (scrolling_window): Check for overflow in size calculations.
3157 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3158 Don't assume glyph table len fits in int.
3159 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3160 (row_table_size): Now ptrdiff_t, not int.
3161 (scrolling_window): Avoid overflow in size calculations.
3162 Don't update size until allocation succeeds.
3163 * fns.c (concat): Check for overflow in size calculations.
3164 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3165 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3166 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3167
3168 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3169 (get_doc_string): Check for size calculation overflow.
3170 Don't update size until allocation succeeds.
3171 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3172 EMACS_INT, where ptrdiff_t will do.
3173 (Fsubstitute_command_keys): Check for string overflow.
3174
3175 * editfns.c (set_time_zone_rule): Don't assume environment length
3176 fits in int.
3177 (message_length): Now ptrdiff_t, not int.
3178 (Fmessage_box): Don't update size until allocation succeeds.
3179 Don't assume message length fits in int.
3180 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3181
3182 * emacs.c (main): Do not reallocate argv, since there is a null at
3183 the end that can be overwritten, and this way there's no need to
3184 worry about size-calculation overflow.
3185 (sort_args): Check for size-calculation overflow.
3186
3187 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3188 alloc succeeds.
3189 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3190
3191 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3192 (x_set_scroll_bar_width, x_figure_window_size):
3193 Check for integer overflow.
3194 (x_set_alpha): Do not assume XINT fits in int.
3195
3196 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3197 This is for the members text_lines, text_cols, total_lines, total_cols,
3198 where the system imposes an 'int' limit.
3199
3200 * fringe.c (Fdefine_fringe_bitmap):
3201 Don't update size until alloc works.
3202
3203 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3204 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3205
3206 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3207 Check for size-calculation overflow.
3208 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3209 do, as we prefer signed integers.
3210 (id_to_widget.max_size, id_to_widget.used)
3211 (xg_store_widget_in_map, xg_remove_widget_from_map)
3212 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3213 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3214 Use and return ptrdiff_t, not int.
3215 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3216 * gtkutil.h: Change prototypes to match the above.
3217
3218 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3219 are duplicate now that they've been promoted to lisp.h.
3220 (x_allocate_bitmap_record, x_alloc_image_color)
3221 (make_image_cache, cache_image, xpm_load):
3222 Don't update size until alloc is done.
3223 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3224 (x_detect_edges):
3225 Check for size calculation overflow.
3226 (ct_colors_allocated_max): New constant.
3227 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3228 overflow.
3229
3230 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3231 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3232 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3233 Use ptrdiff_t, not int, to count maps.
3234 (read_char_minibuf_menu_prompt): Check for overflow in size
3235 calculations. Don't update size until allocation succeeds.
3236 Redo calculations to avoid overflow.
3237 * keyboard.h: Change prototypes to match the above.
3238
3239 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3240 to count maps.
3241 (current_minor_maps): Check for size calculation overflow.
3242 * keymap.h: Change prototypes to match the above.
3243
3244 * lread.c (read1, init_obarray): Don't update size until alloc done.
3245
3246 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3247 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3248
3249 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3250 Now ptrdiff_t, not int.
3251 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3252 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3253
3254 * process.c (Fnetwork_interface_list): Check for overflow
3255 in size calculation.
3256
3257 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3258
3259 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3260 overflow. Don't bother calling xmalloc when xrealloc will do.
3261
3262 * search.c (Freplace_match): Check for size calculation overflow.
3263 (Fset_match_data): Don't assume list lengths fit in 'int'.
3264
3265 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3266 for command line length. Do not attempt to address one before the
3267 beginning of an array, as that's not portable.
3268
3269 * term.c (max_frame_lines): Remove; unused.
3270 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3271 not int.
3272 (encode_terminal_code, calculate_costs): Check for size
3273 calculation overflow.
3274 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3275 table lengths and related sizes. Don't update size until alloc
3276 done. Redo calculations to avoid overflow.
3277 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3278
3279 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3280 subtracting pointers.
3281 (gobble_line): Check for overflow more carefully. Don't update size
3282 until alloc done.
3283
3284 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3285 Don't update size until alloc done.
3286 Redo size calculations to avoid overflow.
3287 Check for size calculation overflow.
3288 (main) [DEBUG]: Fix typo in invoking tparam1.
3289
3290 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3291 Use ptrdiff_t, not int, for sizes.
3292 (store_mode_line_noprop_char): Don't update size until alloc done.
3293
3294 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3295 Use ptrdiff_t, not int, for sizes.
3296 (Finternal_make_lisp_face, cache_face):
3297 Check for size calculation overflow.
3298 (cache_face): Treat size calculation overflows as if they were
3299 memory exhaustion (the usual treatment), rather than aborting.
3300
3301 * xfns.c (x_encode_text, x_set_name_internal)
3302 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3303 sizes, since they can exceed INT_MAX in size. Check for size
3304 calculation overflow.
3305
3306 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3307 (xg_select): Check for size calculation overflow.
3308 Don't update size until alloc done.
3309
3310 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3311 as sprintf is limited to int lengths.
3312
3313 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3314 (X_LONG_MIN): New macros.
3315 Use them to make the following changes clearer.
3316 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3317 This change doesn't affect the value now, but it may help remind
3318 future maintainers not to raise the value too much later.
3319 (SELECTION_QUANTUM): Remove, replacing with ...
3320 (selection_quantum): ... new function, which avoids overflow.
3321 All uses changed.
3322 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3323 assumption that selection length fits in 'int'.
3324 (x_reply_selection_request, x_handle_selection_request)
3325 (x_get_window_property, receive_incremental_selection)
3326 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3327 (lisp_data_to_selection_data, clean_local_selection_data):
3328 Use ptrdiff_t, not int, to record length of selection.
3329 (x_reply_selection_request, x_get_window_property)
3330 (receive_incremental_selection, x_property_data_to_lisp):
3331 Redo calculations to avoid overflow.
3332 (x_reply_selection_request): When sending hint, ceiling it at
3333 X_LONG_MAX rather than relying on wraparound overflow to send
3334 something.
3335 (x_get_window_property, receive_incremental_selection)
3336 (lisp_data_to_selection_data, x_property_data_to_lisp):
3337 Check for size-calculation overflow.
3338 (x_get_window_property, receive_incremental_selection)
3339 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3340 Don't store size until memory allocation succeeds.
3341 (x_get_window_property): Plug memory leak on memory exhaustion.
3342 Don't double-block input; malloc is safe here. Don't assume 2**34
3343 - 4 fits in unsigned long. Add an xassert to check
3344 XGetWindowProperty overflow. Be more careful about overflow
3345 calculations, and distinguish size from memory overflow better.
3346 (receive_incremental_selection): When tracing, don't assume
3347 unsigned int is less than INT_MAX.
3348 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3349 harmful) conversions of unsigned short to int.
3350 (lisp_data_to_selection_data): Don't assume that integers
3351 in the range -65535 through -1 fit in an X unsigned short.
3352 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3353 result parameters unless successful. Rely on cons_to_unsigned
3354 to report problems with elements; the old code wasn't right anyway.
3355 (x_check_property_data): Check for int overflow; we cannot use
3356 a wider type due to X limits.
3357 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3358
3359 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3360
3361 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3362 (x_term_init): Check for size calculation overflow.
3363 (x_color_cells): Don't store size until memory allocation succeeds.
3364 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3365 Don't assume alloca size is less than MAX_ALLOCA.
3366 (x_term_init): Don't assume length fits in int (sprintf is limited
3367 to int size).
3368
3369 Use ptrdiff_t for composition IDs.
3370 * character.c (lisp_string_width):
3371 * composite.c (composition_table_size, n_compositions)
3372 (get_composition_id, composition_gstring_from_id):
3373 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3374 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3375 * window.c (Frecenter):
3376 Use ptrdiff_t, not int, for composition IDs.
3377 * composite.c (get_composition_id): Check for integer overflow.
3378 * composite.h: Adjust prototypes to match the above changes.
3379
3380 Use ptrdiff_t for hash table indexes.
3381 * category.c (hash_get_category_set):
3382 * ccl.c (ccl_driver):
3383 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3384 * coding.c (coding_system_charset_list, detect_coding_system):
3385 * coding.h (struct coding_system.id):
3386 * composite.c (get_composition_id, gstring_lookup_cache):
3387 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3388 * image.c (xpm_get_color_table_h):
3389 * lisp.h (hash_lookup, hash_put):
3390 * minibuf.c (Ftest_completion):
3391 Use ptrdiff_t for hash table indexes, not int (which is too
3392 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3393 32-bit --with-wide-int hosts).
3394
3395 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3396 Add a FIXME comment about memory leaks.
3397 (syms_of_charset): Don't assume xmalloc returns.
3398
3399 Don't assume that stated character widths fit in int.
3400 * character.c (Fchar_width, c_string_width, lisp_string_width):
3401 * character.h (CHAR_WIDTH):
3402 * indent.c (MULTIBYTE_BYTES_WIDTH):
3403 Use sanitize_char_width to avoid undefined and/or bad behavior
3404 with outlandish widths.
3405 * character.h (sanitize_tab_width): Rename from sanitize_width,
3406 now that we have two such functions. All uses changed.
3407 (sanitize_char_width): New inline function.
3408
3409 Don't assume that tab-width fits in int.
3410 * character.h (sanitize_width): New inline function.
3411 (SANE_TAB_WIDTH): New macro.
3412 (ASCII_CHAR_WIDTH): Use it.
3413 * indent.c (sane_tab_width): Remove. All uses replaced by
3414 SANE_TAB_WIDTH (current_buffer).
3415 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3416
3417 * fileio.c: Integer overflow issues with file modes.
3418 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3419
3420 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3421 Remove unreachable code.
3422 (read_hex, load_charset_map_from_file): Check for integer overflow.
3423
3424 * xterm.c: Don't go over XClientMessageEvent limit.
3425 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3426 (x_send_scroll_bar_event): Likewise. Check that the size does not
3427 exceed limits imposed by XClientMessageEvent, as well as the usual
3428 ptrdiff_t and size_t limits.
3429
3430 * keyboard.c: Overflow, signedness and related fixes.
3431 (make_lispy_movement): Use same integer type in forward decl
3432 that is used in the definition.
3433 (read_key_sequence, keyremap_step):
3434 Change bufsize argument back to int, undoing my 2011-03-30 change.
3435 We prefer signed types, and int is wide enough here.
3436 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3437 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3438 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3439 length, not size_t. Use ptrdiff_t for index, not int.
3440 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3441 possibility of integer overflow.
3442
3443 Overflow, signedness and related fixes for images.
3444
3445 * dispextern.h (struct it.stack[0].u.image.image_id)
3446 (struct_it.image_id, struct image.id, struct image_cache.size)
3447 (struct image_cache.used, struct image_cache.ref_count):
3448 * gtkutil.c (update_frame_tool_bar):
3449 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3450 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3451 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3452 * nsmenu.m (update_frame_tool_bar):
3453 * xdisp.c (calc_pixel_width_or_height):
3454 * xfns.c (image_cache_refcount):
3455 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3456 on typical 64-bit hosts.
3457
3458 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3459 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3460 Omit unnecessary casts to int.
3461 (parse_image_spec): Check that integers fall into 'int' range
3462 when the callers expect that.
3463 (image_ascent): Redo ascent calculation to avoid int overflow.
3464 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3465 (lookup_image): Remove unnecessary tests.
3466 (xbm_image_p): Locals are now of int, not EMACS_INT,
3467 since parse_image_check makes sure they fit into int.
3468 (png_load, gif_load, svg_load_image):
3469 Prefer int to unsigned where either will do.
3470 (tiff_handler): New function, combining the cores of the
3471 old tiff_error_handler and tiff_warning_handler.
3472 This function is rewritten to use vsnprintf and thereby avoid
3473 stack buffer overflows. It uses only the features of vsnprintf
3474 that are common to both POSIX and native Microsoft.
3475 (tiff_error_handler, tiff_warning_handler): Use it.
3476 (tiff_load, gif_load, imagemagick_load_image):
3477 Don't assume :index value fits in 'int'.
3478 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3479 (imagemagick_load_image): Check that crop parameters fit into
3480 the integer types that MagickCropImage accepts. Don't assume
3481 Vimagemagick_render_type has a nonnegative value. Don't assume
3482 size_t fits in 'long'.
3483 (gs_load): Use printmax_t to print the widest integers possible.
3484 Check for integer overflow when computing image height and width.
3485
3486 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3487
3488 * xdisp.c (redisplay_window): Don't force window start if point
3489 will be invisible in the resulting window. (Bug#9324)
3490
3491 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3492
3493 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3494 the display spec is of the form `(space ...)'.
3495 (handle_display_spec): Return the value returned by
3496 handle_single_display_spec, not just 1 or zero.
3497 (handle_single_display_spec): If the display spec is of the form
3498 `(space ...)', and specifies display in the text area, return 2
3499 rather than 1.
3500 (try_cursor_movement): Check for the need to scroll more
3501 accurately, and prefer exact match for point under bidi.
3502 Don't advance `row' beyond the last row of the window.
3503
3504 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3505 into disp_prop; all users changed.
3506
3507 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3508 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3509 for the text covered by the display property.
3510
3511 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3512
3513 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3514 Change return value to nil.
3515 (Frecord_buffer): Delete unused function.
3516
3517 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3518
3519 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3520 buffers, return left-to-right.
3521 (set_cursor_from_row): Consider candidate row a win if its glyph
3522 represents a newline and point is on that newline. Fixes cursor
3523 positioning on the newline at EOL of R2L text within L2R
3524 paragraph, and vice versa.
3525 (try_cursor_movement): Check continued rows, in addition to
3526 continuation rows. Fixes unwarranted scroll when point enters a
3527 continued line of R2L text within an L2R paragraph, or vice versa.
3528 (cursor_row_p): Consider the case of point being equal to
3529 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3530 from the end of a short line to the beginning of a continued line
3531 of R2L text within L2R paragraph.
3532 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3533 composed characters.
3534
3535 * bidi.c (bidi_check_type): Use xassert.
3536 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3537 members.
3538
3539 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3540
3541 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3542 a character.
3543
3544 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3545
3546 * nsfont.m (ns_otf_to_script): Fix typo.
3547
3548 2011-08-22 Kenichi Handa <handa@m17n.org>
3549
3550 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3551 extra slot even if the purpose is char-code-property-table.
3552
3553 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3554
3555 * xdisp.c (redisplay_window): When computing centering_position,
3556 account for the height of the header line. (Bug#8874)
3557
3558 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3559 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3560 candidate is selected by the mouse, and that candidate has a
3561 composed character under the mouse.
3562
3563 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3564 coordinates reported by pos-visible-in-window-p for a composed
3565 character in column zero.
3566
3567 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3568
3569 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3570
3571 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3572
3573 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3574 consider it a hit if to_charpos is anywhere in the range of the
3575 composed buffer positions.
3576
3577 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3578
3579 * image.c (gif_load): Don't assume that each subimage has the same
3580 dimensions as the base image. Handle disposal method that is
3581 "undefined" by the gif spec (Bug#9335).
3582
3583 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3584
3585 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3586 (Fcondition_case): Document `debug' symbol in error handler.
3587
3588 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3589
3590 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3591 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3592 from an Org mode buffer to a Speedbar frame.
3593
3594 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3595 a composition, take its buffer position from IT->cmp_it.charpos.
3596 Fixes cursor positioning at the beginning of a line that begins
3597 with a composed character.
3598
3599 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3600
3601 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3602 character bidirectional type, use STRONG_L instead. Fixes crashes
3603 in a buffer produced by `describe-categories'.
3604
3605 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3606 members before the level stack, so they would be saved and
3607 restored when copying iterator state. Fixes incorrect reordering
3608 around TABs covered by display properties.
3609
3610 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3611
3612 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3613
3614 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3615
3616 * eval.c (internal_condition_case, internal_condition_case_1)
3617 (internal_condition_case_2, internal_condition_case_n):
3618 Remove unnecessary aborts (Bug#9081).
3619
3620 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3621
3622 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3623 has no `load' handler, try opening the file locally. (Bug#9311)
3624
3625 2011-08-16 Ken Brown <kbrown@cornell.edu>
3626
3627 * gmalloc.c: Expand comment.
3628
3629 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3630
3631 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3632 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3633
3634 2011-08-16 Ken Brown <kbrown@cornell.edu>
3635
3636 Fix memory allocation problems in Cygwin build (Bug#9273).
3637
3638 * unexcw.c ( __malloc_initialized): Declare external variable.
3639 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3640
3641 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3642 New variables.
3643 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3644 dumped emacs.
3645 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3646 in the static heap.
3647 [CYGWIN] (special_realloc): New function.
3648 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3649 requests to realloc storage in the static heap.
3650
3651 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 * bidi.c (bidi_initialize): Remove unused local.
3654
3655 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3656
3657 * bidimirror.h:
3658 * biditype.h: Remove file.
3659 * makefile.w32-in ($(BLD)/bidi.$(O)):
3660 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3661
3662 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3663
3664 * chartab.c: Improve commentary for the uniprop_table API.
3665
3666 * bidi.c (bidi_paragraph_init): Support zero value of
3667 bidi_ignore_explicit_marks_for_paragraph_level.
3668 (bidi_initialize): Use uniprop_table instead of including
3669 biditype.h and bidimirror.h.
3670
3671 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3672 coordinates of the iterator when restoring from ppos_it.
3673 (Bug#9296)
3674
3675 2011-08-14 Kenichi Handa <handa@m17n.org>
3676
3677 * process.c (create_process): Call setup_process_coding_systems
3678 after the pid of the process is set to -1 (Bug#8162).
3679
3680 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3681
3682 * xdisp.c (move_it_in_display_line_to): Don't invoke
3683 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3684 ppos_it. Fixes vertical cursor motion when line beginning is
3685 covered by an image. (Bug#9296)
3686
3687 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3688
3689 * nsterm.h (ns_run_ascript): Declare.
3690 (NSAPP_DATA2_RUNASSCRIPT): Define.
3691
3692 * nsfns.m (as_script, as_result, as_status): New static variables.
3693 (ns_run_ascript): New function.
3694 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3695 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3696 the event loop. Get status from as_status (Bug#7276).
3697
3698 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3699 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3700 the event loop (Bug#7276).
3701
3702 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3703
3704 * gnutls.c (QCgnutls_bootprop_priority)
3705 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3706 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3707 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3708 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3709 (QCgnutls_bootprop_verify_hostname_error)
3710 (QCgnutls_bootprop_callbacks_verify): Rename from
3711 Qgnutls_bootprop_..., all uses changed.
3712
3713 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3714 uses changed.
3715
3716 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3717
3718 * xfaces.c (Qframe_set_background_mode): Now static.
3719 * dispextern.h (Qframe_set_background_mode): Remove decl.
3720
3721 * process.c (Fnetwork_interface_info): Declare local only if needed.
3722
3723 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3724
3725 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3726 (Fnetwork_interface_list): Allocate in increments of bytes instead
3727 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3728 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3729 sockaddr.
3730 (struct ifflag_def): notrailers is smart on OSX.
3731 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3732 Get hardware address with getifaddrs if available.
3733
3734 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3735
3736 * xdisp.c (iterate_out_of_display_property): xassert that
3737 IT->position is set to within IT->object's boundaries. Break from
3738 the loop as soon as EOB is reached; avoids infloops in redisplay
3739 when IT->position is set up wrongly due to some bug.
3740 Set IT->current to match the bidi iterator unconditionally.
3741 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3742 entry. Force push_it to save on the stack the current
3743 buffer/string position, to be restored by pop_it. Fix flags in
3744 the iterator structure wrt the object coming from a display
3745 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3746 properties. (Bug#9284)
3747
3748 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3749
3750 * fontset.c (fontset_get_font_group): Add proper type checks.
3751 (Bug#9172)
3752
3753 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3754
3755 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3756 and LC_VERSION_MIN_MACOSX.
3757 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3758 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3759
3760 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3761
3762 * xdisp.c (forward_to_next_line_start): Allow to use the
3763 no-display-properties-and-no-overlays under bidi display.
3764 Set disp_pos in the bidi iterator to avoid searches for display
3765 properties and overlays.
3766
3767 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3768
3769 * editfns.c (Fset_time_zone_rule): Document relationship with the
3770 setenv function.
3771
3772 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3773 the font entity extracted from the cache (Bug#8109).
3774
3775 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3776
3777 * composite.c (autocmp_chars): Don't reset point. That is done by
3778 restore_point_unwind (Bug#5984).
3779
3780 2011-08-07 Juri Linkov <juri@jurta.org>
3781
3782 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3783 to show the arg `TIME' instead of `TIMEVAL'.
3784
3785 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3786
3787 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3788 display property strides EOL and includes a newline, as in
3789 longlines-mode. (Bug#9254)
3790 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3791 word-wrap under bidirectional display. (Bug#9224)
3792
3793 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3794 is non-zero, even if the data buffer is NULL. Fixes a crash in
3795 vertical-motion with longlines-mode. (Bug#9254)
3796
3797 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3798
3799 * bidi.c <bidi_cache_total_alloc>: Now static.
3800 (bidi_initialize): Initialize bidi_cache_total_alloc.
3801
3802 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3803 cache. (Bug#9221)
3804
3805 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3806 amount allocated this far in `bidi_cache_total_alloc'.
3807 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3808 non-zero, only free the data buffer without restoring the cache
3809 contents. All callers changed.
3810
3811 * dispextern.h (bidi_unshelve_cache): Update prototype.
3812
3813 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3814 (move_it_in_display_line, move_it_to)
3815 (move_it_vertically_backward, move_it_by_lines): Replace the call
3816 to xfree to an equivalent call to bidi_unshelve_cache.
3817 (move_it_in_display_line_to): Fix logic of returning
3818 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3819
3820 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3821
3822 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3823 came from a string character with a `cursor' property. (Bug#9229)
3824
3825 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3826
3827 * Makefile.in (LIB_PTHREAD): New variable.
3828 (LIBES): Add LIB_PTHREAD (Bug#9216).
3829
3830 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3831 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3832
3833 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3834
3835 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3836
3837 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3838
3839 * xterm.c (x_find_topmost_parent): New function.
3840 (x_set_frame_alpha): Find topmost parent window with
3841 x_find_topmost_parent and set the property there also (bug#9181).
3842 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3843
3844 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 * callproc.c (Fcall_process): Avoid vfork clobbering
3847 the local vars buffer, coding_systems, current_dir.
3848
3849 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3850
3851 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3852
3853 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3854
3855 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3856 so that it is not optimized away.
3857
3858 * xdisp.c (compute_display_string_pos): Remove unused local.
3859
3860 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3861
3862 Fix slow cursor motion and scrolling in large buffers with
3863 selective display, like Org Mode buffers. (Bug#9218)
3864
3865 * dispextern.h (struct bidi_it): New member disp_prop_p.
3866
3867 * xdisp.c: Remove one-slot cache of display string positions.
3868 (compute_display_string_pos): Accept an additional argument
3869 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3870 for a display string or property. If found, set DISP_PROP_P
3871 non-zero.
3872
3873 * bidi.c (bidi_fetch_char): Accept an additional argument
3874 DISP_PROP_P, and pass it to compute_display_string_pos.
3875 Only handle text covered by a display string if DISP_PROP_P is returned
3876 non-zero. All callers of bidi_fetch_char changed.
3877
3878 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3879
3880 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3881
3882 2010-12-03 Don March <don@ohspite.net>
3883
3884 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3885 last character M-[char] is translated to ESC [char] (bug#7541).
3886
3887 2011-08-02 Kenichi Handa <handa@m17n.org>
3888
3889 * lisp.h (uniprop_table): Extern it.
3890
3891 * chartab.c (uniprop_table): Make it non-static.
3892
3893 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3894
3895 * xdisp.c (forward_to_next_line_start): Accept additional argument
3896 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3897 on the newline.
3898 (reseat_at_next_visible_line_start): Use the bidi iterator state
3899 returned by forward_to_next_line_start to restore the state of
3900 it->bidi_it after backing up to previous newline. (Bug#9212)
3901
3902 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3903
3904 * regex.c (re_comp): Protoize.
3905 (re_exec): Fix return type.
3906 (regexec): Fix type of `ret'. (Bug#9203)
3907
3908 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3911 This is needed if max-image-size is a floating-point number.
3912
3913 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3914
3915 * print.c (print_object): Print empty symbol as ##.
3916
3917 * lread.c (read1): Read ## as empty symbol.
3918
3919 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3920
3921 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3922 setting frame foreground color (Bug#9175).
3923 (x_set_background_color): Likewise.
3924
3925 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3926 contents (Bug#9176).
3927 (EmacsTooltip -init): Remove bezels and add shadows to
3928 tooltip windows.
3929
3930 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3931 or scroll bar (Bug#8470).
3932
3933 * nsfont.m (nsfont_open): Remove assignment to voffset and
3934 unnecessary vars hshink, expand, hd, full_height, min_height.
3935 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3936
3937 * nsterm.h (nsfont_info): Remove voffset field.
3938
3939 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3940
3941 Implement strike-through and overline on NextStep (Bug#8863).
3942
3943 * nsfont.m (nsfont_open): Use underline position provided by font,
3944 instead of hard-coded value of 2.
3945 (nsfont_draw): Call ns_draw_text_decoration instead.
3946
3947 * nsterm.h: Add declaration for ns_draw_text_decoration.
3948
3949 * nsterm.m (ns_draw_text_decoration): New function for drawing
3950 underline, overline, and strike-through.
3951 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3952 ns_draw_text_decoration. Change treatment of cursor drawing to
3953 accommodate underlining, etc.
3954
3955 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3956
3957 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3958 default.
3959
3960 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3963 Without this fix, if a signal arrives just after memory fills up,
3964 'malloc' might be invoked reentrantly.
3965
3966 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3967 In other words, assume that every image size is allowed, on non-X
3968 hosts. This assumption is probably wrong, but it lets Emacs compile.
3969
3970 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3971
3972 * regex.c (re_iswctype): Convert return values to boolean.
3973
3974 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3975
3976 * xdisp.c (compute_display_string_pos): Don't use cached display
3977 string position if the buffer had its restriction changed.
3978 (Bug#9184)
3979
3980 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3983
3984 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3985
3986 Integer signedness and overflow and related fixes. (Bug#9079)
3987
3988 * bidi.c: Integer size and overflow fixes.
3989 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3990 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3991 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3992 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3993 (bidi_find_other_level_edge):
3994 Use ptrdiff_t instead of EMACS_INT where either will do.
3995 This works better on 32-bit hosts configured --with-wide-int.
3996 (bidi_cache_ensure_space): Check for size-calculation overflow.
3997 Use % rather than repeated addition, for better worst-case speed.
3998 Don't set bidi_cache_size until after xrealloc returns, because it
3999 might not return.
4000 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4001 (bidi_cache_ensure_space): Also check that the bidi cache size
4002 does not exceed that of the largest Lisp string or buffer. See Eli
4003 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4004
4005 * alloc.c (__malloc_size_t): Remove.
4006 All uses replaced by size_t. See Andreas Schwab's note
4007 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4008
4009 * image.c: Improve checking for integer overflow.
4010 (check_image_size): Assume that f is nonnull, since
4011 it is always nonnull in practice. This is one less thing to
4012 worry about when checking for integer overflow later.
4013 (x_check_image_size): New function, which checks for integer
4014 overflow issues inside X.
4015 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4016 This removes the need for a memory_full check.
4017 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4018 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4019 (xbm_read_bitmap_data): Change locals back to 'int', since
4020 their values must fit in 'int'.
4021 (xpm_load_image, png_load, tiff_load):
4022 Invoke x_create_x_image_and_pixmap earlier,
4023 to avoid much needless work if the image is too large.
4024 (tiff_load): Treat overly large images as if
4025 x_create_x_image_and_pixmap failed, not as malloc failures.
4026 (gs_load): Use x_check_image_size.
4027
4028 * gtkutil.c: Omit integer casts.
4029 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4030 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4031
4032 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4033
4034 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4035 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4036 would wrongly return t on a 64-bit host.
4037
4038 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4039 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4040 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4041 and therefore cause GCC to emit a bogus diagnostic in some cases.
4042
4043 * image.c: Integer signedness and overflow and related fixes.
4044 This is not an exhaustive set of fixes, but it's time to
4045 record what I've got.
4046 (lookup_pixel_color, check_image_size): Remove redundant decls.
4047 (check_image_size): Don't assume that arbitrary EMACS_INT values
4048 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4049 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4050 (tiff_load, imagemagick_load_image):
4051 Check for overflow in size calculations.
4052 (x_create_x_image_and_pixmap): Remove unnecessary test for
4053 xmalloc returning NULL; that can't happen.
4054 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4055 (xpm_color_bucket): Use better integer hashing function.
4056 (xpm_cache_color): Don't possibly over-allocate memory.
4057 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4058 (gif_memory_source):
4059 Use ptrdiff_t, not int or size_t, to record sizes.
4060 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4061 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4062 either works, as we prefer signed integers.
4063 (tiff_read_from_memory, tiff_write_from_memory):
4064 Return tsize_t, not size_t, since that's what the TIFF API wants.
4065 (tiff_read_from_memory): Don't fail simply because the read would
4066 go past EOF; instead, return a short read.
4067 (tiff_load): Omit no-longer-needed casts.
4068 (Fimagemagick_types): Don't assume size fits into 'int'.
4069
4070 Improve hashing quality when configured --with-wide-int.
4071 * fns.c (hash_string): New function, taken from sxhash_string.
4072 Do not discard information about ASCII character case; this
4073 discarding is no longer needed.
4074 (sxhash-string): Use it. Change sig to match it. Caller changed.
4075 * lisp.h: Declare it.
4076 * lread.c (hash_string): Remove, since we now use fns.c's version.
4077 The fns.c version returns a wider integer if --with-wide-int is
4078 specified, so this should help the quality of the hashing a bit.
4079
4080 * emacs.c: Integer overflow minor fix.
4081 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4082 Define only if GNU_LINUX.
4083 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4084
4085 * dispnew.c: Integer signedness and overflow fixes.
4086 Remove unnecessary forward decls, that were a maintenance hassle.
4087 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4088 All uses changed.
4089 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4090 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4091 (prepare_desired_row, line_draw_cost):
4092 Use int, not unsigned, where either works.
4093 (save_current_matrix, restore_current_matrix):
4094 Use ptrdiff_t, not size_t, where either works.
4095 (init_display): Check for overflow more accurately, and without
4096 relying on undefined behavior.
4097
4098 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4099 Remove, replacing with the new symbols in lisp.h. All uses changed.
4100 * fileio.c (make_temp_name):
4101 * filelock.c (lock_file_1, lock_file):
4102 * xdisp.c (message_dolog):
4103 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4104 Use pMd etc. instead.
4105 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4106 replacing the pWIDE etc. symbols removed from editfns.c.
4107
4108 * keyboard.h (num_input_events): Now uintmax_t.
4109 This is (very slightly) less likely to mess up due to wraparound.
4110 All uses changed.
4111
4112 * buffer.c: Integer signedness fixes.
4113 (alloc_buffer_text, enlarge_buffer_text):
4114 Use ptrdiff_t rather than size_t when either will do, as we prefer
4115 signed integers.
4116
4117 * alloc.c: Integer signedness and overflow fixes.
4118 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4119 (__malloc_size_t): Default to size_t, not to int.
4120 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4121 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4122 Prefer ptrdiff_t to size_t when either would do, as we prefer
4123 signed integers.
4124 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4125 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4126 Now const. Initialize with values that are in range even if char
4127 is signed.
4128 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4129 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4130 These functions do the right thing with sizes > 2**32.
4131 (check_depth): Now ptrdiff_t, not int.
4132 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4133 Adjust to new way of storing sizes. Check for size overflow bugs
4134 in rest of code.
4135 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4136 slightly wrong anyway, as it missed one instance of
4137 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4138 (refill_memory_reserve): Omit needless cast to size_t.
4139 (mark_object_loop_halt): Mark as externally visible.
4140
4141 * xselect.c: Integer signedness and overflow fixes.
4142 (Fx_register_dnd_atom, x_handle_dnd_message):
4143 Use ptrdiff_t, not size_t, since we prefer signed.
4144 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4145 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4146 x_dnd_atoms_size and x_dnd_atoms_length.
4147
4148 * doprnt.c: Prefer signed to unsigned when either works.
4149 * eval.c (verror):
4150 * doprnt.c (doprnt):
4151 * lisp.h (doprnt):
4152 * xdisp.c (vmessage):
4153 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4154 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4155 prefer signed arithmetic to avoid comparison confusion.
4156 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4157 but is a bit tricky.
4158
4159 Assume freestanding C89 headers, string.h, stdlib.h.
4160 * data.c, doprnt.c, floatfns.c, print.c:
4161 Include float.h unconditionally.
4162 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4163 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4164 * regex.c: Likewise for stddef.h, string.h.
4165 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4166 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4167 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4168 (STDC_HEADERS): Remove obsolete defines.
4169 * sysdep.c: Include limits.h unconditionally.
4170
4171 Assume support for memcmp, memcpy, memmove, memset.
4172 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4173 * regex.c (memcmp, memcpy):
4174 Remove; we assume C89 now.
4175
4176 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4177 (__malloc_safe_bcopy): Remove; no longer needed.
4178
4179 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4180 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4181 well either way, and we prefer signed to unsigned.
4182
4183 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4184
4185 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4186 closes the connection while we're reading (bug#9182).
4187
4188 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4189
4190 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4191 are specified (Bug#9168).
4192
4193 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4194
4195 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4196 Found by GCC static checking and --with-wide-int on a 32-bit host.
4197
4198 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4199
4200 * xdisp.c (compute_display_string_pos): Fix logic of caching
4201 previous display string position. Initialize cached_prev_pos to
4202 -1. Fixes slow-down at the beginning of a buffer.
4203
4204 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4205
4206 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4207 for attrs[LFACE_FONTSET_INDEX].
4208
4209 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4210
4211 * xml.c (parse_region): Remove unused local
4212 that was recently introduced.
4213
4214 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4215
4216 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4217 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4218
4219 * xdisp.c (move_it_in_display_line_to): Record the best matching
4220 position for TO_CHARPOS while scanning the line, and restore it on
4221 exit if none of the characters scanned was an exact match.
4222 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4223 when exact match is impossible due to invisible text, and the
4224 lines are truncated.
4225
4226 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4227
4228 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4229 for OSX >= 10.7.
4230
4231 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4232
4233 Fix a significant slow-down of cursor motion with C-n, C-p,
4234 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4235 auto-repeat under bidi redisplay in fontified buffers.
4236 * xdisp.c (compute_stop_pos_backwards): New function.
4237 (next_element_from_buffer): Call compute_stop_pos_backwards to
4238 find a suitable prev_stop when we find ourselves before
4239 base_level_stop.
4240 (reseat): Don't look for prev_stop, as that could mean a very long
4241 run.
4242 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4243 <cached_disp_overlay_modiff>: Cache for last found display string
4244 position.
4245 (compute_display_string_pos): Return the cached position if asked
4246 about the same buffer in the same area of character positions, and
4247 the buffer wasn't changed since the time the display string
4248 position was cached.
4249
4250 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4251
4252 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4253 is an integer, which is important for empty lines. (Bug#9149)
4254
4255 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4256
4257 * frame.c (Fmodify_frame_parameters): In tty case, update the
4258 default face if necessary (Bug#4238).
4259
4260 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4261
4262 * editfns.c (Fstring_to_char): No need to explain what a character
4263 is in the docstring (Bug#6576).
4264
4265 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4266
4267 * xml.c (parse_region): Make sure we always return a tree.
4268
4269 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4270
4271 * xml.c (parse_region): If a document contains only comments,
4272 return that, too.
4273
4274 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4275
4276 * xml.c (make_dom): Return comments, too.
4277
4278 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4279
4280 Port to OpenBSD.
4281 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4282 and the surrounding thread.
4283 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4284 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4285 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4286 timer goes off.
4287 * s/openbsd.h (BROKEN_SIGIO): Define.
4288 * unexelf.c (unexec) [__OpenBSD__]:
4289 Don't update the .mdebug section of the Alpha COFF symbol table.
4290
4291 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4292
4293 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4294 (bug#8460).
4295
4296 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4299 This fixes some race conditions on the permissions of any newly
4300 created file.
4301
4302 * alloc.c (valid_pointer_p): Use pipe, not open.
4303 This fixes some permissions issues when debugging.
4304
4305 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4306 If fchown fails to set both uid and gid, try to set just gid,
4307 as that is sometimes allowed. Adjust the file's mode to eliminate
4308 setuid or setgid bits that are inappropriate if fchown fails.
4309
4310 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4311
4312 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4313 to compare Lisp_Objects.
4314 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4315 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4316 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4317
4318 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4319
4320 * lread.c (read_integer): Unread even EOF character.
4321 (read1): Likewise. Properly record start position of symbol.
4322
4323 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4324 symbol character follows.
4325
4326 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4329 This works around a problem with the previous change to Fcopy_file.
4330 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4331 and without this change, GCC might complain about discarding
4332 fchown's return value.
4333
4334 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4335
4336 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4337
4338 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4339
4340 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4341
4342 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343
4344 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4345 it's used from the C level.
4346
4347 * process.c: Use the same condition for POLL_FOR_INPUT in both
4348 keyboard.c and process.c (bug#1858).
4349
4350 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4351
4352 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4353 (Fgnutls_boot): Use it.
4354
4355 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4356
4357 * doc.c (Fsubstitute_command_keys): Revert last change.
4358
4359 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4360
4361 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4362 quotes the next character, and doesn't affect other longer
4363 sequences (bug#8935).
4364
4365 * lread.c (syms_of_lread): Clarify that is isn't only
4366 `eval-buffer' and `eval-defun' that's affected by
4367 `lexical-binding' (bug#8460).
4368
4369 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4370
4371 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4372 bidi redisplay when a line includes both an image and is truncated.
4373
4374 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4375
4376 Fix minor problems found by static checking.
4377 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4378 (elsz): Now a signed constant, not a size_t var. We prefer signed
4379 types to unsigned, to avoid integer comparison confusion. Without
4380 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4381 "cannot optimize loop, the loop counter may overflow", a symptom
4382 of the confusion.
4383 * indent.c (Fvertical_motion): Mark locals as initialized.
4384 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4385
4386 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4387
4388 * search.c (Fre_search_backward): Mention `case-fold-search' in
4389 all the re_search_* functions (bug#8138).
4390
4391 * keyboard.c (Fopen_dribble_file): Document when the file is
4392 closed (bug#8056).
4393
4394 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4395
4396 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4397 bidi_cache_idx.
4398
4399 Support bidi reordering of display and overlay strings.
4400 * xdisp.c (compute_display_string_pos)
4401 (compute_display_string_end): Accept additional argument STRING.
4402 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4403 (reseat_to_string): Initialize bidi_it->string.s and
4404 bidi_it->string.schars.
4405 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4406 NULL (avoids a crash in bidi_paragraph_init).
4407 Initialize itb.string.lstring.
4408 (init_iterator): Call bidi_init_it only of a valid
4409 buffer position was specified. Initialize paragraph_embedding to
4410 L2R.
4411 (reseat_to_string): Initialize the bidi iterator.
4412 (display_string): If we need to ignore text properties of
4413 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4414 original value of -1 will not work with bidi.)
4415 (compute_display_string_pos): First arg is now struct
4416 `text_pos *'; all callers changed. Support display properties on
4417 Lisp strings.
4418 (compute_display_string_end): Support display properties on Lisp
4419 strings.
4420 (init_iterator, reseat_1, reseat_to_string): Initialize the
4421 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4422 when iterating on a string not from display properties).
4423 (compute_display_string_pos, compute_display_string_end):
4424 Fix calculation of the object to scan. Fixes an error when using
4425 arrow keys.
4426 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4427 base_level_stop; instead, set base_level_stop to BEGV.
4428 Fixes crashes in vertical-motion.
4429 (next_element_from_buffer): Improve commentary for when
4430 the iterator is before prev_stop.
4431 (init_iterator): Initialize bidi_p from the default value of
4432 bidi-display-reordering, not from buffer-local value. Use the
4433 buffer-local value only if initializing for buffer iteration.
4434 (handle_invisible_prop): Support invisible properties on strings
4435 that are being bidi-reordered.
4436 (set_iterator_to_next): Support bidi reordering of C strings and
4437 Lisp strings.
4438 (next_element_from_string): Support bidi reordering of Lisp
4439 strings.
4440 (handle_stop_backwards): Support Lisp strings as well.
4441 (display_string): Support display of R2L glyph rows.
4442 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4443 (init_iterator): Don't initialize it->bidi_p for strings
4444 here.
4445 (reseat_to_string): Initialize it->bidi_p for strings here.
4446 (next_element_from_string, next_element_from_c_string)
4447 (next_element_from_buffer): Add xassert's for correspondence
4448 between IT's object being iterated and it->bidi_it.string
4449 structure.
4450 (face_before_or_after_it_pos): Support bidi iteration.
4451 (next_element_from_c_string): Handle the case of the first string
4452 character that is not the first one in the visual order.
4453 (get_visually_first_element): New function, refactored from common
4454 parts of next_element_from_buffer, next_element_from_string, and
4455 next_element_from_c_string.
4456 (tool_bar_lines_needed, redisplay_tool_bar)
4457 (display_menu_bar): Force left-to-right direction. Add a FIXME
4458 comment for making that be controlled by a user option.
4459 (push_it, pop_it): Save and restore the state of the
4460 bidi iterator. Save and restore the bidi_p flag.
4461 (pop_it): Iterate out of display property for string iteration as
4462 well.
4463 (iterate_out_of_display_property): Support iteration over strings.
4464 (handle_single_display_spec): Set up it->bidi_it for iteration
4465 over a display string, and call bidi_init_it.
4466 (handle_single_display_spec, next_overlay_string)
4467 (get_overlay_strings_1, push_display_prop): Set up the bidi
4468 iterator for displaying display or overlay strings.
4469 (forward_to_next_line_start): Don't use the shortcut if
4470 bidi-iterating.
4471 (back_to_previous_visible_line_start): If handle_display_prop
4472 pushed the iterator stack, restore the internal state of the bidi
4473 iterator by calling bidi_pop_it same number of times.
4474 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4475 and we are bidi-iterating, don't decrement the iterator position;
4476 instead, set the first_elt flag in the bidi iterator, to produce
4477 the same effect.
4478 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4479 (push_display_prop): xassert that we are iterating a buffer.
4480 (push_it, pop_it): Save and restore paragraph_embedding member.
4481 (handle_single_display_spec, next_overlay_string)
4482 (get_overlay_strings_1, reseat_1, reseat_to_string)
4483 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4484 correctly. Don't assume unibyte strings are not bidi-reordered.
4485 (compute_display_string_pos)
4486 (compute_display_string_end): Fix handling the case of C string.
4487 (push_it, pop_it): Save and restore from_disp_prop_p.
4488 (handle_single_display_spec, push_display_prop): Set the
4489 from_disp_prop_p flag.
4490 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4491 (pop_it): Call iterate_out_of_display_property only if we are
4492 popping after iteration over a string that came from a display
4493 property. Fix a typo in popping stretch info. Add an assertion
4494 for verifying that the iterator position is in sync with the bidi
4495 iterator.
4496 (handle_single_display_spec, get_overlay_strings_1)
4497 (push_display_prop): Fix initialization of paragraph direction for
4498 string when that of the parent object is not yet determined.
4499 (reseat_1): Call bidi_init_it to resync the bidi
4500 iterator with IT's position. (Bug#7616)
4501 (find_row_edges): If ROW->start.pos gives position
4502 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4503 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4504 Reset the from_disp_prop_p flag.
4505 (SAVE_IT, RESTORE_IT): New macros.
4506 (pos_visible_p, face_before_or_after_it_pos)
4507 (back_to_previous_visible_line_start)
4508 (move_it_in_display_line_to, move_it_in_display_line)
4509 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4510 (try_scrolling, redisplay_window, display_line): Use them when
4511 saving a temporary copy of the iterator and restoring it back.
4512 (back_to_previous_visible_line_start, reseat_1)
4513 (init_iterator): Empty the bidi cache "stack".
4514 (move_it_in_display_line_to): If iterator ended up at
4515 EOL, but we never saw any buffer positions smaller than
4516 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4517 motion in bidi-reordered lines.
4518 (move_it_in_display_line_to): Record prev_method and prev_pos
4519 immediately before the call to set_iterator_to_next. Fixes cursor
4520 motion in bidi-reordered lines with stretch glyphs and strings
4521 displayed in margins. (Bug#8133) (Bug#8867)
4522 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4523 TO_CHARPOS.
4524 (pos_visible_p): Support positions in bidi-reordered lines.
4525 Save and restore bidi cache.
4526
4527 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4528 (bidi_paragraph_info): Delete unused struct.
4529 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4530 (bidi_cache_start): New variable.
4531 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4532 to zero.
4533 (bidi_cache_fetch_state, bidi_cache_search)
4534 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4535 (bidi_cache_find, bidi_peek_at_next_level)
4536 (bidi_level_of_next_char, bidi_find_other_level_edge)
4537 (bidi_move_to_visually_next): Compare cache index with
4538 bidi_cache_start rather than with zero.
4539 (bidi_fetch_char): Accept new argument STRING; all callers
4540 changed. Support iteration over a string. Support strings with
4541 display properties. Support unibyte strings. Fix the type of
4542 `len' according to what STRING_CHAR_AND_LENGTH expects.
4543 (bidi_paragraph_init, bidi_resolve_explicit_1)
4544 (bidi_resolve_explicit, bidi_resolve_weak)
4545 (bidi_level_of_next_char, bidi_move_to_visually_next):
4546 Support iteration over a string.
4547 (bidi_set_sor_type, bidi_resolve_explicit_1)
4548 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4549 can now be zero (for strings); special values 0 and -1 were
4550 changed to -1 and -2, respectively.
4551 (bidi_char_at_pos): New function.
4552 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4553 Call it instead of FETCH_MULTIBYTE_CHAR.
4554 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4555 initialized to valid values.
4556 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4557 values.
4558 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4559 the test for valid cached positions. Fix the logic for looking up
4560 the sentinel state in the cache. GCPRO the Lisp string we are
4561 iterating.
4562 (bidi_push_it, bidi_pop_it): New functions.
4563 (bidi_initialize): Initialize the bidi cache start stack pointer.
4564 (bidi_cache_ensure_space): New function, refactored from part of
4565 bidi_cache_iterator_state. Don't assume the required size is just
4566 one BIDI_CACHE_CHUNK away.
4567 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4568 (bidi_count_bytes, bidi_char_at_pos): New functions.
4569 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4570 always valid if bidi_cache_idx is valid.
4571 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4572 is valid if it's going to be used.
4573 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4574 (bidi_cache_fetch_state, bidi_cache_search)
4575 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4576 (bidi_cache_iterator_state, bidi_cache_find)
4577 (bidi_find_other_level_edge, bidi_cache_start_stack):
4578 All variables related to cache indices are now EMACS_INT.
4579
4580 * dispextern.h (struct bidi_string_data): New structure.
4581 (struct bidi_it): New member `string'. Make flag members be 1-bit
4582 fields, and put them last in the struct.
4583 (compute_display_string_pos, compute_display_string_end):
4584 Update prototypes.
4585 (bidi_push_it, bidi_pop_it): Add prototypes.
4586 (struct iterator_stack_entry): New members bidi_p,
4587 paragraph_embedding, and from_disp_prop_p.
4588 (struct it): Member bidi_p is now a bit field 1 bit wide.
4589 (bidi_shelve_cache, bidi_unshelve_cache):
4590 Declare prototypes.
4591
4592 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4593 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4594 and vector-like objects.
4595
4596 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4597 cache around display iteration.
4598
4599 * window.c (Fwindow_end, window_scroll_pixel_based)
4600 (displayed_window_lines, Frecenter): Save and restore the bidi
4601 cache around display iteration.
4602
4603 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4604
4605 * editfns.c (Fdelete_region): Clarify the use of the named
4606 parameters (bug#6788).
4607
4608 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4609
4610 * indent.c (Fvertical_motion): Set and restore w->pointm when
4611 saving and restoring the window's buffer (Bug#9006).
4612
4613 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4614
4615 * editfns.c (Fstring_to_char): Clarify just what is returned
4616 (bug#6576). Text by Eli Zaretskii.
4617
4618 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4619
4620 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4621
4622 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4623
4624 * buffer.c (mmap_find): Fix a typo.
4625
4626 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4627
4628 Fix execution of x selection hooks.
4629 * xselect.c (Qx_lost_selection_functions)
4630 (Qx_sent_selection_functions): New vars.
4631 (syms_of_xselect): DEFSYM them.
4632 (x_handle_selection_request): Pass Qx_sent_selection_functions
4633 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4634 (x_handle_selection_clear,x_clear_frame_selections):
4635 Pass Qx_lost_selection_functions rather than
4636 Vx_lost_selection_functions to Frun_hook_with_args.
4637
4638 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4639
4640 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4641 The old code sometimes used this field without initializing it.
4642
4643 * alloc.c (gc_sweep): Don't read past end of array.
4644 In theory, the old code could also have corrupted Emacs internals,
4645 though it'd be very unlikely.
4646
4647 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4648
4649 * character.c (Fcharacterp): Don't advertise optional ignored
4650 argument. (Bug#4026)
4651
4652 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4653
4654 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4655 key" (bug#4257).
4656
4657 * window.c (Fset_window_start): Doc fix (bug#4199).
4658 (Fset_window_hscroll): Ditto.
4659
4660 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4661
4662 Fix minor new problems caught by GCC 4.6.1.
4663 * term.c (init_tty): Remove unused local.
4664 * xsettings.c (store_monospaced_changed): Define this function only
4665 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4666 not used otherwise.
4667
4668 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4669
4670 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4671
4672 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4673
4674 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4675 are the mini-buffer and the echo area (bug#3320).
4676
4677 * term.c (init_tty): Remove support for supdup, c10 and perq
4678 terminals, which are no longer supported (bug#1482).
4679
4680 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4681
4682 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4683
4684 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4685
4686 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4687 for non-popups (Bug#3642).
4688
4689 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4690
4691 * alloc.c (reset_malloc_hooks): Protoize.
4692 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4693 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4694 * cm.c (losecursor): Likewise.
4695 * data.c (fmod): Likewise.
4696 * dispnew.c (swap_glyphs_in_rows): Likewise.
4697 * emacs.c (memory_warning_signal): Likewise.
4698 * floatfns.c (float_error): Likewise.
4699 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4700 (otf_open, font_otf_capability, generate_otf_features)
4701 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4702 Likewise.
4703 * image.c (pbm_read_file): Likewise.
4704 * indent.c (string_display_width): Likewise.
4705 * intervals.c (check_for_interval, search_for_interval)
4706 (inc_interval_count, count_intervals, root_interval)
4707 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4708 * lread.c (defalias): Likewise.
4709 * ralloc.c (r_alloc_check): Likewise.
4710 * regex.c (set_image_of_range_1, set_image_of_range)
4711 (regex_grow_registers): Likewise.
4712 * sysdep.c (strerror): Likewise.
4713 * termcap.c (valid_filename_p, tprint, main): Likewise.
4714 * tparam.c (main): Likewise.
4715 * unexhp9k800.c (run_time_remap, save_data_space)
4716 (update_file_ptrs, read_header, write_header, calculate_checksum)
4717 (copy_file, copy_rest, display_header): Likewise.
4718 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4719 Likewise.
4720 * xdisp.c (check_it): Likewise.
4721 * xfaces.c (register_color, unregister_color, unregister_colors):
4722 Likewise.
4723 * xfns.c (print_fontset_result): Likewise.
4724 * xrdb.c (member, fatal, main): Likewise.
4725
4726 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 Fix minor problems found by static checking (Bug#9031).
4729 * chartab.c (char_table_set_range, map_sub_char_table):
4730 Remove unused locals.
4731 (uniprop_table): Now static.
4732 * composite.c (_work_char): Remove unused static var.
4733
4734 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4735
4736 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4737
4738 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4739
4740 * gtkutil.c (qttip_cb): Remove code without function.
4741
4742 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4743
4744 * w32.c (pthread_sigmask): New stub.
4745
4746 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4747
4748 Use pthread_sigmask, not sigprocmask (Bug#9010).
4749 sigprocmask is portable only for single-threaded applications, and
4750 Emacs can be multi-threaded when it uses GTK.
4751 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4752 (LIBES): Use it.
4753 * callproc.c (Fcall_process):
4754 * process.c (create_process):
4755 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4756 Use pthread_sigmask, not sigprocmask.
4757
4758 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4759
4760 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4761 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4762 wrong (Bug#8591).
4763
4764 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4765
4766 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4767 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4768 (xg_hide_tooltip): Fix comment.
4769
4770 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4771 in registerServicesMenuSendTypes.
4772 (validRequestorForSendType): Don't check ns_return_types.
4773
4774 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4775 ns_return_type.
4776
4777 2011-07-08 Jason Rumney <jasonr@gnu.org>
4778
4779 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4780 SH_SHOW for hidden windows (Bug#5482).
4781
4782 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4783 frame struct members of non-existent frames (Bug#6284).
4784
4785 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4786
4787 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4788 variable firstTime not needed on OSX >= 10.6.
4789 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4790 >= 10.5. Use setKnobProportion, setDoubleValue.
4791
4792 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4793 (MAC_OS_X_VERSION_10_5): Define if not defined.
4794 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4795 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4796 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4797
4798 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4799 cString and lossyCString on OSX >= 10.4
4800
4801 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4802 sizeToFit on OSX >= 10.2.
4803
4804 * nsimage.m (allocInitFromFile): Don't use deprecated method
4805 bestRepresentationForDevice on OSX >= 10.6.
4806
4807 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4808 to avoid warning.
4809
4810 * emacs.c: Declare unexec_init_emacs_zone.
4811
4812 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4813
4814 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4815
4816 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4817 on svcsMenu (Bug#8842).
4818
4819 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4820 ns_return_types.
4821 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4822
4823 * nsterm.m (QUTF8_STRING): Declare.
4824 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4825 (validRequestorForSendType): Return type is (id).
4826 Change indexOfObjectIdenticalTo to indexOfObject.
4827 Check if we have local selection before returning self (Bug#8842).
4828 (writeSelectionToPasteboard): Put local selection into paste board
4829 if we have a local selection (Bug#8842).
4830 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4831
4832 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4833 (ns_get_local_selection): Declare.
4834
4835 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4836
4837 * keymap.c (describe_map_tree): Don't insert a double newline at
4838 the end of the buffer (bug#1169) and return whether we inserted
4839 something.
4840
4841 * callint.c (Fcall_interactively): Change "reading args" to
4842 "providing args" to try to clarify what it does (bug#1010).
4843
4844 2011-07-07 Kenichi Handa <handa@m17n.org>
4845
4846 * composite.c (composition_compute_stop_pos): Ignore a static
4847 composition starting before CHARPOS (Bug#8915).
4848
4849 * xdisp.c (handle_composition_prop): Likewise.
4850
4851 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4852
4853 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4854 (Bug#9015)
4855
4856 2011-07-07 Kenichi Handa <handa@m17n.org>
4857
4858 * character.h (unicode_category_t): New enum type.
4859
4860 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4861 (Qchar_code_property_table): New variable.
4862 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4863 (UNIPROP_COMPRESSED_FORM_P): New macros.
4864 (char_table_ascii): Uncompress the compressed values.
4865 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4866 Uncompress the compressed values.
4867 (sub_char_table_ref_and_range): Likewise.
4868 (char_table_ref_and_range): Uncompress the compressed values.
4869 (sub_char_table_set): New arg is_uniprop. Callers changed.
4870 Uncompress the compressed values.
4871 (sub_char_table_set_range): Args changed. Callers changed.
4872 (char_table_set_range): Adjuted for the above change.
4873 (map_sub_char_table): Delete args default_val and parent. Add arg
4874 top. Give decoded values to a Lisp function.
4875 (map_char_table): Adjust for the above change. Give decoded
4876 values to a Lisp function. Gcpro more variables.
4877 (uniprop_table_uncompress)
4878 (uniprop_decode_value_run_length): New functions.
4879 (uniprop_decoder, uniprop_decoder_count): New variables.
4880 (uniprop_get_decoder, uniprop_encode_value_character)
4881 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4882 New functions.
4883 (uniprop_encoder, uniprop_encoder_count): New variables.
4884 (uniprop_get_encoder, uniprop_table)
4885 (Funicode_property_table_internal, Fget_unicode_property_internal)
4886 (Fput_unicode_property_internal): New functions.
4887 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4888 Sunicode_property_table_internal, Sget_unicode_property_internal,
4889 and Sput_unicode_property_internal. Defvar_lisp
4890 char-code-property-alist.
4891
4892 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4893 Vunicode_category_table.
4894
4895 * font.c (font_range): Adjust for the change of
4896 Vunicode_category_table.
4897
4898 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4899
4900 * m/iris4d.h: Remove file, move contents ...
4901 * s/irix6-5.h: ... here.
4902
4903 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 Remove unportable assumption about struct layout (Bug#8884).
4906 * alloc.c (mark_buffer):
4907 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4908 (clone_per_buffer_values): Don't assume that
4909 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4910 This isn't true in general, and it's particularly not true
4911 if Emacs is configured with --with-wide-int.
4912 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4913 New macros, used in the buffer.c change.
4914
4915 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4916
4917 * xsettings.c: Use both GConf and GSettings if both are available.
4918 (store_config_changed_event): Add comment.
4919 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4920 (store_tool_bar_style_changed): New functions.
4921 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4922 (struct xsettings): Move font inside HAVE_XFT.
4923 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4924 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4925 Move inside HAVE_XFT.
4926 (something_changed_gsettingsCB): Rename from something_changedCB.
4927 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4928 also.
4929 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4930 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4931 (something_changed_gconfCB): Rename from something_changedCB.
4932 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4933 (parse_settings): Move check for font inside HAVE_XFT.
4934 (read_settings, apply_xft_settings): Add comment.
4935 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4936 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4937 call store_font_name_changed.
4938 (xft_settings_event): Add comment.
4939 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4940 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4941 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4942 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4943 (xsettings_initialize): Call init_gsettings last.
4944 (xsettings_get_system_font, xsettings_get_system_normal_font):
4945 Add comment.
4946
4947 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4948
4949 Random fixes. E.g., (random) never returned negative values.
4950 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4951 subseconds part to the entropy, as that's a bit more random.
4952 Prefer signed to unsigned, since the signedness doesn't matter and
4953 in general we prefer signed. When given a limit, use a
4954 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4955 latter isn't right if USE_2_TAGS_FOR_INTS.
4956 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4957 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4958
4959 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4960
4961 * textprop.c (text_property_stickiness):
4962 Obey Vtext_property_default_nonsticky.
4963 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4964 * w32fns.c (syms_of_w32fns):
4965 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4966
4967 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4968
4969 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4970 This is more efficient than Ffile_directory_p and avoids a minor race.
4971
4972 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4973
4974 * buffer.c (Foverlay_put): Say what the return value is
4975 (bug#7835).
4976
4977 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4978 is a directory before asking whether to use the file name
4979 (bug#7564).
4980 (barf_or_query_if_file_exists): Make the "File is a directory"
4981 error be more correct.
4982
4983 * fns.c (Frequire): Remove the mention of the .gz files, since
4984 that's installation-specific, but keep the mention of
4985 `get-load-suffixes'.
4986
4987 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4988
4989 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4990 Report string overflow if the output is too long.
4991
4992 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4993
4994 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4995 (syms_of_gnutls): Remove duplicate DEFSYM for
4996 Qgnutls_bootprop_verify_hostname_error, an error for
4997 Qgnutls_bootprop_verify_error (which is no longer used).
4998
4999 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5000 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5001 Also (re)move comments that are misplaced or no longer relevant.
5002
5003 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5004
5005 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5006
5007 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5008
5009 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5010 and background color parameters if they have been changed.
5011
5012 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5013
5014 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5015
5016 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5017
5018 * xsettings.c (SYSTEM_FONT): Define only when used.
5019 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5020
5021 * keymap.c (access_keymap_1): Now static.
5022
5023 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5024
5025 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5026 leave any prefix arg for the up event (Bug#1586).
5027
5028 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5029
5030 * lread.c (syms_of_lread): Mention single symbols defined by
5031 `defvar' or `defconst' (bug#7154).
5032
5033 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5034 (Frequire): Mention get-load-suffixes.
5035
5036 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5037
5038 * window.h (window): Remove clone_number slot.
5039 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5040 Remove.
5041 (make_parent_window, make_window, saved_window)
5042 (Fset_window_configuration, save_window_save): Don't deal with
5043 clone numbers.
5044 * buffer.c (Qclone_number): Remove declaration.
5045 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5046
5047 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5048
5049 Add multiple inheritance to keymaps.
5050 * keymap.c (Fmake_composed_keymap): New function.
5051 (Fset_keymap_parent): Simplify.
5052 (fix_submap_inheritance): Remove.
5053 (access_keymap_1): New function extracted from access_keymap to handle
5054 embedded parents and handle lists of maps.
5055 (access_keymap): Use it.
5056 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5057 (Fcopy_keymap): Handle embedded parents.
5058 (Fcommand_remapping, define_as_prefix): Simplify.
5059 (Fkey_binding): Simplify.
5060 (syms_of_keymap): Move minibuffer-local-completion-map,
5061 minibuffer-local-filename-completion-map,
5062 minibuffer-local-must-match-map, and
5063 minibuffer-local-filename-must-match-map to Elisp.
5064 (syms_of_keymap): Defsubr make-composed-keymap.
5065 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5066 (parse_menu_item): Trivial simplification.
5067
5068 2011-07-01 Glenn Morris <rgm@gnu.org>
5069
5070 * Makefile.in (SETTINGS_LIBS): Fix typo.
5071
5072 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5073
5074 * coding.c (Fencode_coding_string): Record the last coding system
5075 used, as the function doc string says (bug#8738).
5076
5077 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5078
5079 * xsettings.c (store_monospaced_changed): Take new font as arg and
5080 check for change against current_mono_font.
5081 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5082 (emacs_settings_constructor, emacs_settings_get_property)
5083 (emacs_settings_set_property, emacs_settings_class_init)
5084 (emacs_settings_init, gsettings_obj): Remove.
5085 (something_changedCB): New function for HAVE_GSETTINGS.
5086 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5087 with value as argument.
5088 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5089 g_settings_new (Bug#8967). Do not create gsettings_obj.
5090 Remove calls to g_settings_bind. Connect something_changedCB to
5091 "changed".
5092
5093 * xgselect.c: Add defined (HAVE_GSETTINGS).
5094 (xgselect_initialize): Ditto.
5095
5096 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5097 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5098 xg_select.
5099
5100 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5101
5102 * eval.c (struct backtrace): Simplify and port the data structure.
5103 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5104 signed bit field, as this assumption is not portable and it makes
5105 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5106 "char debug_on_exit : 1" as this is not portable either; instead,
5107 use the portable "unsigned int debug_on_exit : 1". Remove unused
5108 member evalargs. Remove obsolete comments about cc bombing out.
5109
5110 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5111
5112 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5113 Let HAVE_GSETTINGS override HAVE_GCONF.
5114 (store_monospaced_changed): New function.
5115 (EMACS_SETTINGS): A new type derived from GObject to handle
5116 GSettings notifications.
5117 (emacs_settings_constructor, emacs_settings_get_property)
5118 (emacs_settings_set_property, emacs_settings_class_init):
5119 New functions.
5120 (gsettings_client, gsettings_obj): New variables.
5121 (GSETTINGS_SCHEMA): New define.
5122 (something_changedCB): Call store_monospaced_changed.
5123 (init_gsettings): New function.
5124 (xsettings_initialize): Call init_gsettings.
5125 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5126 to NULL.
5127
5128 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5129 GCONF_CFLAGS/LIBS.
5130
5131 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5132
5133 * window.c (resize_root_window, grow_mini_window)
5134 (shrink_mini_window): Rename Qresize_root_window to
5135 Qwindow_resize_root_window and Qresize_root_window_vertically to
5136 Qwindow_resize_root_window_vertically.
5137
5138 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5139
5140 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5141
5142 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5143
5144 * makefile.w32-in: Redesign dependencies so they reflect more
5145 clearly which files are directly included by each source file,
5146 and not through other includes.
5147
5148 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5149
5150 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5151 (sort_overlays, overlay_strings): When an overlay's clone number
5152 matches the window's clone number process the overlay even if
5153 the overlay's window property doesn't match the current window.
5154
5155 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5156 (Fwindow_hchild): Rename to Fwindow_left_child.
5157 (Fwindow_next): Rename to Fwindow_next_sibling.
5158 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5159 (resize_window_check): Rename to window_resize_check.
5160 (resize_window_apply): Rename to window_resize_apply.
5161 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5162 (Fdelete_other_windows_internal, resize_frame_windows)
5163 (Fsplit_window_internal, Fdelete_window_internal)
5164 (grow_mini_window, shrink_mini_window)
5165 (Fresize_mini_window_internal): Fix callers accordingly.
5166
5167 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5168
5169 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5170 (emacs_fixed_set_min_size): Remove.
5171 (emacs_fixed_new): Take frame as argument.
5172
5173 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5174 (_EmacsFixedPrivate): Remove minwidth/height.
5175 Add struct frame *f.
5176 (emacs_fixed_init): Initialize priv->f.
5177 (get_parent_class, emacs_fixed_set_min_size): Remove.
5178 (emacs_fixed_new): Set priv->f to argument.
5179 (emacs_fixed_get_preferred_width)
5180 (emacs_fixed_get_preferred_height): Use min_width/height from
5181 frames size_hint to set minimum and natural (Bug#8919).
5182 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5183 and use min_width/height from frames size_hint to set
5184 min_width/height (Bug#8919).
5185
5186 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5187 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5188 Fix indentation.
5189
5190 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5191
5192 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5193 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5194 called at ZV.
5195
5196 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5197
5198 * process.c (wait_reading_process_output): Bypass select if
5199 waiting for a cell while ignoring keyboard input, and input is
5200 pending. Suggested by Jan Djärv (Bug#8869).
5201
5202 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5203
5204 Use gnulib's dup2 module instead of rolling our own.
5205 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5206
5207 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5208
5209 * dispnew.c (scrolling_window): Before scrolling, turn off a
5210 mouse-highlight in the window being scrolled.
5211
5212 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5213
5214 Move DEFSYM to lisp.h and use everywhere.
5215
5216 * character.h (DEFSYM): Move declaration...
5217 * lisp.h (DEFSYM): ...here.
5218
5219 * gnutls.c:
5220 * minibuf.c:
5221 * w32menu.c:
5222 * w32proc.c:
5223 * w32select.c: Don't include character.h.
5224
5225 * alloc.c (syms_of_alloc):
5226 * buffer.c (syms_of_buffer):
5227 * bytecode.c (syms_of_bytecode):
5228 * callint.c (syms_of_callint):
5229 * casefiddle.c (syms_of_casefiddle):
5230 * casetab.c (init_casetab_once):
5231 * category.c (init_category_once, syms_of_category):
5232 * ccl.c (syms_of_ccl):
5233 * cmds.c (syms_of_cmds):
5234 * composite.c (syms_of_composite):
5235 * dbusbind.c (syms_of_dbusbind):
5236 * dired.c (syms_of_dired):
5237 * dispnew.c (syms_of_display):
5238 * doc.c (syms_of_doc):
5239 * editfns.c (syms_of_editfns):
5240 * emacs.c (syms_of_emacs):
5241 * eval.c (syms_of_eval):
5242 * fileio.c (syms_of_fileio):
5243 * fns.c (syms_of_fns):
5244 * frame.c (syms_of_frame):
5245 * fringe.c (syms_of_fringe):
5246 * insdel.c (syms_of_insdel):
5247 * keymap.c (syms_of_keymap):
5248 * lread.c (init_obarray, syms_of_lread):
5249 * macros.c (syms_of_macros):
5250 * msdos.c (syms_of_msdos):
5251 * print.c (syms_of_print):
5252 * process.c (syms_of_process):
5253 * search.c (syms_of_search):
5254 * sound.c (syms_of_sound):
5255 * syntax.c (init_syntax_once, syms_of_syntax):
5256 * terminal.c (syms_of_terminal):
5257 * textprop.c (syms_of_textprop):
5258 * undo.c (syms_of_undo):
5259 * w32.c (globals_of_w32):
5260 * window.c (syms_of_window):
5261 * xdisp.c (syms_of_xdisp):
5262 * xfaces.c (syms_of_xfaces):
5263 * xfns.c (syms_of_xfns):
5264 * xmenu.c (syms_of_xmenu):
5265 * xsettings.c (syms_of_xsettings):
5266 * xterm.c (syms_of_xterm): Use DEFSYM.
5267
5268 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5269
5270 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5271
5272 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5273
5274 Integer and buffer overflow fixes (Bug#8873).
5275
5276 * print.c (printchar, strout): Check for string overflow.
5277 (PRINTPREPARE, printchar, strout):
5278 Don't set size unless allocation succeeds.
5279
5280 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5281 for sizes. Check for string overflow more accurately.
5282 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5283
5284 * macros.c: Integer and buffer overflow fixes.
5285 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5286 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5287 Use ptrdiff_t, not int, for sizes.
5288 Don't increment bufsize until after realloc succeeds.
5289 Check for size-calculation overflow.
5290 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5291
5292 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5293
5294 * lread.c: Integer overflow fixes.
5295 (read_integer): Radix is now EMACS_INT, not int,
5296 to improve quality of diagnostics for out-of-range radices.
5297 Calculate buffer size correctly for out-of-range radices.
5298 (read1): Check for integer overflow in radices, and in
5299 read-circle numbers.
5300 (read_escape): Avoid int overflow.
5301 (Fload, openp, read_buffer_size, read1)
5302 (substitute_object_recurse, read_vector, read_list, map_obarray):
5303 Use ptrdiff_t, not int, for sizes.
5304 (read1): Use EMACS_INT, not int, for sizes.
5305 Check for size overflow.
5306
5307 * image.c (cache_image): Check for size arithmetic overflow.
5308
5309 * lread.c: Integer overflow issues.
5310 (saved_doc_string_size, saved_doc_string_length)
5311 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5312 Now ptrdiff_t, not int.
5313 (read1): Don't assume doc string length fits in int. Check for
5314 out-of-range doc string lengths.
5315 (read_list): Don't assume file position fits in int.
5316 (read_escape): Check for hex character overflow.
5317
5318 2011-06-22 Leo Liu <sdl.web@gmail.com>
5319
5320 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5321 Move to minibuffer.el.
5322
5323 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5324
5325 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5326 The following patches are for when GLYPH_DEBUG && !XASSERT.
5327 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5328 * dispnew.c (flush_stdout):
5329 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5330 Mark as externally visible.
5331 * dispnew.c (check_window_matrix_pointers): Now static.
5332 * dispnew.c (window_to_frame_vpos):
5333 * xfns.c (unwind_create_frame):
5334 * xterm.c (x_check_font): Remove unused local.
5335 * scroll.c (CHECK_BOUNDS):
5336 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5337 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5338 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5339 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5340 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5341 Now static.
5342 (debug_method_add): Use va_list and vsprintf rather than relying
5343 on undefined behavior with wrong number of arguments.
5344 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5345 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5346 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5347 since we're not interested in debugging glyphs with old libraries.
5348 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5349 GCC 4.6.0's static checking.
5350
5351 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5352
5353 Integer overflow and signedness fixes (Bug#8873).
5354 A few related buffer overrun fixes, too.
5355
5356 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5357
5358 * dispextern.h (struct face.stipple):
5359 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5360 (x_bitmap_mask, x_allocate_bitmap_record)
5361 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5362 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5363 (x_create_bitmap_from_xpm_data):
5364 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5365 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5366 (.bitmaps_last):
5367 * xfaces.c (load_pixmap):
5368 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5369 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5370 (.bitmaps_last, struct x_output.icon_bitmap):
5371 Use ptrdiff_t, not int, for bitmap indexes.
5372 (x_allocate_bitmap_record): Check for size overflow.
5373 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5374
5375 Use ptrdiff_t, not int, for overlay counts.
5376 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5377 * editfns.c (overlays_around, get_pos_property):
5378 * textprop.c (get_char_property_and_overlay):
5379 * xdisp.c (next_overlay_change, note_mouse_highlight):
5380 * xfaces.c (face_at_buffer_position):
5381 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5382 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5383 (Fnext_overlay_change, Fprevious_overlay_change)
5384 (mouse_face_overlay_overlaps, Foverlays_in):
5385 Use ptrdiff_t, not int, for sizes.
5386 (overlays_at, overlays_in): Check for size-calculation overflow.
5387
5388 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5389
5390 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5391 (x_session_initialize): Do not assume string length fits in int.
5392
5393 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5394 This is unlikely, but can occur if DPI is outlandish.
5395
5396 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5397 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5398
5399 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5400 * xrdb.c (magic_file_p, search_magic_path):
5401 Omit last arg SUFFIX; it was always 0. All callers changed.
5402 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5403
5404 * xfont.c (xfont_match): Avoid need for strlen.
5405
5406 * xfns.c: Don't assume strlen fits in int.
5407 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5408
5409 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5410 not unsigned long, as we prefer signed integers. All callers changed.
5411 Detect integer overflow in repeat count.
5412 (message_dolog): Don't assume print length fits in 39 bytes.
5413 (display_mode_element): Don't assume strlen fits in int.
5414
5415 * termcap.c: Don't assume sizes fit in int and never overflow.
5416 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5417 (gobble_line): Check for size-calculation overflow.
5418
5419 * minibuf.c (Fread_buffer):
5420 * lread.c (intern, intern_c_string):
5421 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5422 Don't assume string length fits in int.
5423
5424 * keyboard.c (parse_tool_bar_item):
5425 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5426
5427 * font.c: Don't assume string length fits in int.
5428 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5429 Use ptrdiff_t, not int.
5430 (font_intern_prop): Don't assume string length fits in int.
5431 Don't assume integer property fits in fixnum.
5432 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5433
5434 * filelock.c: Fix some buffer overrun and integer overflow issues.
5435 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5436 Reformulate so as not to need the command string.
5437 Invoke gzip -cd rather than gunzip, as it's more portable.
5438 (lock_info_type, lock_file_1, lock_file):
5439 Don't assume pid_t and time_t fit in unsigned long.
5440 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5441 (current_lock_owner): Prefer signed type for sizes.
5442 Use memcpy, not strncpy, where memcpy is what is really wanted.
5443 Don't assume (via atoi) that time_t and pid_t fit in int.
5444 Check for time_t and/or pid_t out of range, e.g., via a network share.
5445 Don't alloca where an auto var works fine.
5446
5447 * fileio.c: Fix some integer overflow issues.
5448 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5449 Don't assume string length fits in int.
5450 (directory_file_name): Don't assume string length fits in long.
5451 (make_temp_name): Don't assume pid fits in int, or that its print
5452 length is less than 20.
5453
5454 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5455
5456 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5457
5458 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5459
5460 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5461 We prefer signed integers, even for size calculations.
5462
5463 * emacs.c: Don't assume string length fits in 'int'.
5464 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5465 (main): Don't invoke strlen when not needed.
5466
5467 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5468 (XD_DEBUG_MESSAGE): Don't waste a byte.
5469
5470 * callproc.c (getenv_internal_1, getenv_internal)
5471 (Fgetenv_internal):
5472 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5473
5474 * lread.c (invalid_syntax): Omit length argument.
5475 All uses changed. This doesn't fix a bug, but it simplifies the
5476 code away from its former Hollerith-constant appearance, and it's
5477 one less 'int' to worry about when looking at integer-overflow issues.
5478 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5479
5480 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5481 This didn't break anything, but it didn't help either.
5482 It's confusing to put a bogus integer in a place where the actual
5483 value does not matter.
5484 (LIST_END_P): Remove unused macro and its bogus comment.
5485 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5486
5487 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5488 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5489 implementation.
5490 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5491 We prefer signed types, and the value cannot exceed the EMACS_INT
5492 range anyway (because otherwise the length would not be representable).
5493 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5494 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5495 This avoids a GCC warning when WIDE_EMACS_INT.
5496
5497 * indent.c (sane_tab_width): New function.
5498 (current_column, scan_for_column, Findent_to, position_indentation)
5499 (compute_motion): Use it. This is just for clarity.
5500 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5501
5502 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5503
5504 * lisp.h (lint_assume): New macro.
5505 * composite.c (composition_gstring_put_cache):
5506 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5507
5508 * editfns.c, insdel.c:
5509 Omit unnecessary forward decls, to simplify future changes.
5510
5511 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5512
5513 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5514
5515 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5516 Use much-faster test for byte-length change.
5517 Don't assume string byte-length fits in 'int'.
5518 Check that character arg fits in 'int'.
5519 (mapcar1): Declare byte as byte, for clarity.
5520
5521 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5522
5523 * fns.c (concat): Catch string overflow earlier.
5524 Do not rely on integer wraparound.
5525
5526 * dispextern.h (struct it.overlay_strings_charpos)
5527 (struct it.selective): Now EMACS_INT, not int.
5528 * xdisp.c (forward_to_next_line_start)
5529 (back_to_previous_visible_line_start)
5530 (reseat_at_next_visible_line_start, next_element_from_buffer):
5531 Don't arbitrarily truncate the value of 'selective' to int.
5532
5533 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5534
5535 * composite.c: Don't truncate sizes to 'int'.
5536 (composition_gstring_p, composition_reseat_it)
5537 (composition_adjust_point): Use EMACS_INT, not int.
5538 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5539 not EMACS_UINT, for indexes.
5540
5541 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5542
5543 * buffer.c: Include <verify.h>.
5544 (struct sortvec.priority, struct sortstr.priority):
5545 Now EMACS_INT, not int.
5546 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5547 (struct sortstr.size, record_overlay_string)
5548 (struct sortstrlist.size, struct sortlist.used):
5549 Don't truncate size to int.
5550 (record_overlay_string): Check for size-calculation overflow.
5551 (init_buffer_once): Check at compile-time, not run-time.
5552
5553 2011-06-22 Jim Meyering <meyering@redhat.com>
5554
5555 Don't leak an XBM-image-sized buffer
5556 * image.c (xbm_load): Free the image buffer after using it.
5557
5558 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5559
5560 Port to Sun C.
5561 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5562 that Sun C diagnosed.
5563 * fns.c (secure_hash): Fix pointer signedness issue.
5564 * intervals.c (static_offset_intervals): New function.
5565 (offset_intervals): Use it.
5566
5567 2011-06-21 Leo Liu <sdl.web@gmail.com>
5568
5569 * deps.mk (fns.o):
5570 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5571 sha512.h.
5572
5573 * fns.c (secure_hash): Rename from crypto_hash_function and change
5574 the first arg to accept symbols.
5575 (Fsecure_hash): New primitive.
5576 (syms_of_fns): New symbols.
5577
5578 2011-06-20 Deniz Dogan <deniz@dogan.se>
5579
5580 * process.c (Fset_process_buffer): Clarify return value in
5581 docstring.
5582
5583 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5584
5585 * dispnew.c (add_window_display_history): Use BVAR.
5586
5587 * xdisp.c (debug_method_add): Use BVAR.
5588 (check_window_end, dump_glyph_matrix, dump_glyph)
5589 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5590
5591 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5592 Likewise.
5593
5594 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5595 check till after the cache is created in init_frame_faces.
5596
5597 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5598
5599 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5600
5601 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5602
5603 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5604 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5605 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5606
5607 Improve buffer-overflow checking (Bug#8873).
5608 * fileio.c (Finsert_file_contents):
5609 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5610 Remove the old (too-loose) buffer overflow checks.
5611 They weren't needed, since make_gap checks for buffer overflow.
5612 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5613 The old code merely checked for Emacs fixnum overflow, and relied
5614 on undefined (wraparound) behavior. The new code avoids undefined
5615 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5616
5617 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5618 Tune. Don't use wider integers than needed. Don't use alloca.
5619 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5620
5621 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5622
5623 * insdel.c, lisp.h (buffer_overflow): New function.
5624 (insert_from_buffer_1, replace_range, replace_range_2):
5625 * insdel.c (make_gap_larger):
5626 * editfns.c (Finsert_char):
5627 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5628
5629 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5630
5631 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5632
5633 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5634
5635 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5636 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5637
5638 * fileio.c: Don't assume EMACS_INT fits in off_t.
5639 (emacs_lseek): New static function.
5640 (Finsert_file_contents, Fwrite_region): Use it.
5641 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5642
5643 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5644
5645 * fns.c: Don't overflow int when computing a list length.
5646 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5647 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5648 truncation on 64-bit hosts. Check for QUIT every
5649 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5650 faster and is responsive enough.
5651 (Flength): Report an error instead of overflowing an integer.
5652 (Fsafe_length): Return a float if the value is not representable
5653 as a fixnum. This shouldn't happen except in contrived situations.
5654 (Fnthcdr, Fsort): Don't assume list length fits in int.
5655 (Fcopy_sequence): Don't assume vector length fits in int.
5656
5657 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5658 (header_size, word_size): New constants.
5659 (allocate_vectorlike): Don't check size overflow here.
5660 (allocate_vector): Check it here instead, since this is the only
5661 caller of allocate_vectorlike that could cause overflow.
5662 Check that the new vector's length is representable as a fixnum.
5663
5664 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5665 The previous code was bogus. For example, next_almost_prime (32)
5666 returned 39, which is undesirable as it is a multiple of 3; and
5667 next_almost_prime (24) returned 25, which is a multiple of 5 so
5668 why was the code bothering to check for multiples of 7?
5669
5670 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5671
5672 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5673
5674 Variadic C functions now count arguments with ptrdiff_t.
5675 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5676 Back then I didn't know that the Emacs coding style prefers signed int.
5677 Also, in the meantime I found a few more instances where arguments
5678 were being counted with int, which may truncate counts on 64-bit
5679 machines, or EMACS_INT, which may be unnecessarily wide.
5680 * lisp.h (struct Lisp_Subr.function.aMANY)
5681 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5682 Arg counts are now ptrdiff_t, not size_t.
5683 All variadic functions and their callers changed accordingly.
5684 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5685 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5686 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5687 * callint.c (Fcall_interactively): Check arg count for overflow,
5688 to avoid potential buffer overrun. Use signed char, not 'int',
5689 for 'varies' array, so that we needn't bother to check its size
5690 calculation for overflow.
5691 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5692 * eval.c (apply_lambda):
5693 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5694 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5695 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5696
5697 * callint.c (Fcall_interactively): Don't use index var as event count.
5698
5699 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5700 * mem-limits.h (SIZE): Remove; no longer used.
5701
5702 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5703
5704 Remove unnecessary casts.
5705 * xterm.c (x_term_init):
5706 * xfns.c (x_set_border_pixel):
5707 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5708 These aren't needed now that we assume ANSI C.
5709
5710 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5711 It's more likely to cause problems (due to unsigned overflow)
5712 than to cure them.
5713
5714 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5715
5716 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5717
5718 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5719
5720 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5721
5722 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5723
5724 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5725
5726 GLYPH_CODE_FACE returns EMACS_INT, not int.
5727 * dispextern.h (merge_faces):
5728 * xfaces.c (merge_faces):
5729 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5730 Don't assume EMACS_INT fits in int.
5731
5732 * character.h (CHAR_VALID_P): Remove unused parameter.
5733 * fontset.c, lisp.h, xdisp.c: All uses changed.
5734
5735 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5736
5737 * fns.c (concat): Minor tuning based on overflow analysis.
5738 This doesn't fix any bugs. Use int to hold character, instead
5739 of constantly refetching from Emacs object. Use XFASTINT, not
5740 XINT, for value known to be a character. Don't bother comparing
5741 a single byte to 0400, as it's always less.
5742
5743 * floatfns.c (Fexpt):
5744 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5745
5746 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5747 for characters.
5748
5749 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5750
5751 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5752 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5753 incorrectly succeed when S was a string, because 4294967386 was
5754 truncated before it was used.
5755
5756 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5757 Otherwise, an out-of-range integer could cause undefined behavior
5758 on a 64-bit host.
5759
5760 * composite.c: Use int, not EMACS_INT, for characters.
5761 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5762 EMACS_INT, for values that are known to be in character range.
5763 This doesn't fix any bugs but is the usual style inside Emacs and
5764 may generate better code on 32-bit machines.
5765
5766 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5767 This is for reasons similar to the recent CHAR_STRING fix.
5768 * charset.c (Fencode_char): Check that character arg is actually
5769 a character. Pass an int to ENCODE_CHAR.
5770 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5771 wider than 'int', as a compile-time check to prevent future regressions
5772 in this area.
5773
5774 * character.c (char_string): Remove unnecessary casts.
5775
5776 Make sure a 64-bit char is never passed to CHAR_STRING.
5777 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5778 by silently ignoring the top 32 bits, allowing some values
5779 that were far too large to be valid characters.
5780 * character.h: Include <verify.h>.
5781 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5782 arguments are no wider than unsigned, as a compile-time check
5783 to prevent future regressions in this area.
5784 * data.c (Faset):
5785 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5786 (Fsubst_char_in_region):
5787 * fns.c (concat):
5788 * xdisp.c (decode_mode_spec_coding):
5789 Adjust to CHAR_STRING's new requirement.
5790 * editfns.c (Finsert_char, Fsubst_char_in_region):
5791 * fns.c (concat): Check that character args are actually
5792 characters. Without this test, these functions did the wrong
5793 thing with wildly out-of-range values on 64-bit hosts.
5794
5795 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5796 These casts should not be needed on 32-bit hosts, either.
5797 * keyboard.c (read_char):
5798 * lread.c (Fload): Remove casts to unsigned.
5799
5800 * lisp.h (UNSIGNED_CMP): New macro.
5801 This fixes comparison bugs on 64-bit hosts.
5802 (ASCII_CHAR_P): Use it.
5803 * casefiddle.c (casify_object):
5804 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5805 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5806 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5807 * dispextern.h (FACE_FROM_ID):
5808 * keyboard.c (read_char): Use UNSIGNED_CMP.
5809
5810 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5811 not to EMACS_INT, to avoid GCC warning.
5812
5813 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5814
5815 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5816 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5817 isn't needed on 32-bit machines.
5818
5819 * buffer.c (Fgenerate_new_buffer_name):
5820 Use EMACS_INT for count, not int.
5821 (advance_to_char_boundary): Return EMACS_INT, not int.
5822
5823 * data.c (Qcompiled_function): Now static.
5824
5825 * window.c (window_body_lines): Now static.
5826
5827 * image.c (gif_load): Rename local to avoid shadowing.
5828
5829 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5830 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5831 * alloc.c (make_save_value): Integer argument is now of type
5832 ptrdiff_t, not int.
5833 (mark_object): Use ptrdiff_t, not int.
5834 * lisp.h (pD): New macro.
5835 * print.c (print_object): Use it.
5836
5837 * alloc.c: Use EMACS_INT, not int, to count objects.
5838 (total_conses, total_markers, total_symbols, total_vector_size)
5839 (total_free_conses, total_free_markers, total_free_symbols)
5840 (total_free_floats, total_floats, total_free_intervals)
5841 (total_intervals, total_strings, total_free_strings):
5842 Now EMACS_INT, not int. All uses changed.
5843 (Fgarbage_collect): Compute overall total using a double, so that
5844 integer overflow is less likely to be a problem. Check for overflow
5845 when converting back to an integer.
5846 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5847 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5848 These were 'int' variables that could overflow on 64-bit hosts;
5849 they were never used, so remove them instead of repairing them.
5850 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5851 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5852 Previously, this ceilinged at INT_MAX, but that doesn't work on
5853 64-bit machines.
5854 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5855
5856 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5857 (allocate_vectorlike): Check for ptrdiff_t overflow.
5858 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5859 when a (possibly-narrower) signed value would do just as well.
5860 We prefer using signed arithmetic, to avoid comparison confusion.
5861
5862 * alloc.c: Catch some string size overflows that we were missing.
5863 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5864 for convenience in STRING_BYTES_MAX.
5865 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5866 The definition here is exact; the one in lisp.h was approximate.
5867 (allocate_string_data): Check for string overflow. This catches
5868 some instances we weren't catching before. Also, it catches
5869 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5870 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5871 and ptrdiff_t and EMACS_INT are both 64 bits.
5872
5873 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5874 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5875 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5876
5877 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5878
5879 * alloc.c (Fmake_string): Check for out-of-range init.
5880
5881 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5882
5883 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5884
5885 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5886
5887 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5888 xg_get_default_scrollbar_width.
5889
5890 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5891 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5892 (style_changed_cb): Call update_theme_scrollbar_width and call
5893 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5894 all frames (Bug#8505).
5895 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5896 Call gtk_window_set_resizable if HAVE_GTK3.
5897 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5898 and height if HAVE_GTK3 (Bug#8505).
5899 (scroll_bar_width_for_theme): New variable.
5900 (update_theme_scrollbar_width): New function.
5901 (xg_get_default_scrollbar_width): Move code to
5902 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5903 (xg_initialize): Call update_theme_scrollbar_width.
5904
5905 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5906
5907 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5908
5909 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5910
5911 * frame.c (make_frame): Call other_buffer_safely instead of
5912 other_buffer.
5913
5914 * window.c (temp_output_buffer_show): Call display_buffer with
5915 second argument Vtemp_buffer_show_specifiers and reset latter
5916 immediately after the call.
5917 (Vtemp_buffer_show_specifiers): New variable.
5918 (auto_window_vscroll_p, next_screen_context_lines)
5919 (Vscroll_preserve_screen_position): Remove leading asterisks from
5920 doc-strings.
5921
5922 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5923
5924 Fix minor problems found by GCC 4.6.0 static checking.
5925 * buffer.c (Qclone_number): Remove for now, as it's unused.
5926 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5927 (record_buffer): Remove unused local.
5928 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5929 (set_frame_buffer_list): Remove; unused.
5930 * frame.h (other_visible_frames): Remove decl.
5931 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5932 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5933 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5934 if HAVE_GPM.
5935 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5936 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5937 Define only if HAVE_GPM.
5938 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5939 (update_hints_inhibit): Remove; never set. All uses removed.
5940 * widgetprv.h (emacsFrameClassRec): Remove decl.
5941 * window.c (delete_deletable_window): Now returns void, since it
5942 wasn't returning anything.
5943 (compare_window_configurations): Remove unused locals.
5944 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5945 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5946 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5947 the same widths as pointers. This follows up on the 2011-05-06 patch.
5948 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5949 * xterm.h: Likewise.
5950 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5951
5952 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5953
5954 * makefile.w32-in: Update dependencies.
5955 (LISP_H): Add lib/intprops.h.
5956
5957 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5958
5959 * image.c (gif_load): Add animation frame delay to the metadata.
5960 (syms_of_image): Use DEFSYM. New symbol `delay'.
5961
5962 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5963
5964 * window.c (delete_deletable_window): Re-add.
5965 (Fset_window_configuration): Rewrite to handle dead buffers and
5966 consequently deletable windows.
5967 (window_tree, Fwindow_tree): Remove. Supply functionality in
5968 window.el.
5969 (compare_window_configurations): Simplify code.
5970
5971 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5972
5973 * image.c (imagemagick_load_image): Fix type mismatch.
5974 (Fimagemagick_types): Likewise.
5975
5976 * window.h (replace_buffer_in_windows): Declare.
5977
5978 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5979
5980 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5981 Qclone_number. Remove external declaration of Qdelete_window.
5982 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5983 code.
5984 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5985 Run Qbuffer_list_update_hook if allowed.
5986 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5987 buffer list implementation.
5988 (other_buffer_safely): New function.
5989 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5990 calls to replace_buffer_in_windows and
5991 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5992 if allowed.
5993 (record_buffer): Inhibit quitting and rewrite using quittable
5994 functions. Run Qbuffer_list_update_hook if allowed.
5995 (Frecord_buffer, Funrecord_buffer): New functions.
5996 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5997 Move switch-to-buffer to window.el.
5998 (bury-buffer): Move to window.el.
5999 (Vbuffer_list_update_hook): New variable.
6000
6001 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6002 section.
6003
6004 * window.h (resize_frame_windows): Move up in code.
6005 (Fwindow_frame): Remove EXFUN.
6006 (replace_buffer_in_all_windows): Remove prototype.
6007 (replace_buffer_in_windows_safely): Add prototype.
6008
6009 * window.c: Declare Qdelete_window static again. Move down
6010 declaration of select_count.
6011 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6012 (Fother_window): Move to window.el.
6013 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6014 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6015 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6016 window.el.
6017 (replace_buffer_in_windows): Implement by calling
6018 Qreplace_buffer_in_windows.
6019 (replace_buffer_in_all_windows): Remove with some functionality
6020 moved into replace_buffer_in_windows_safely.
6021 (replace_buffer_in_windows_safely): New function.
6022 (select_window_norecord, select_frame_norecord): Move in front
6023 of run_window_configuration_change_hook. Remove now obsolete
6024 declarations.
6025 (Fset_window_buffer): Rewrite doc-string.
6026 Call Qrecord_window_buffer.
6027 (keys_of_window): Move binding for other-window to window.el.
6028
6029 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6030
6031 * dispextern.h (struct image): Replace data member, whose int_val
6032 and ptr_val fields were not used by anything, with a single
6033 lisp_val object.
6034
6035 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6036 (gif_clear_image, gif_load, imagemagick_load_image)
6037 (gs_clear_image, gs_load): Callers changed.
6038
6039 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 * buffer.h: Include <time.h>, for time_t.
6042 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6043
6044 Fix minor problems found by static checking.
6045
6046 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6047
6048 Make identifiers static if they are not used in other modules.
6049 * data.c (Qcompiled_function, Qframe, Qvector):
6050 * image.c (QimageMagick, Qsvg):
6051 * minibuf.c (Qmetadata):
6052 * window.c (resize_window_check, resize_root_window): Now static.
6053 * window.h (resize_window_check, resize_root_window): Remove decls.
6054
6055 * window.c (window_deletion_count, delete_deletable_window):
6056 Remove; unused.
6057 (window_body_lines): Now static.
6058 (Fdelete_other_windows_internal): Mark vars as initialized.
6059 Make sure 'resize_failed' is initialized.
6060 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6061 (resize_window_apply): Remove unused local.
6062 * window.h (delete_deletable_window): Remove decl.
6063
6064 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6065 (imagemagick_load_image): Fix pointer signedness problem by changing
6066 last arg from unsigned char * to char *. All uses changed.
6067 Also, fix a local for similar reasons.
6068 Remove unused locals. Remove locals to avoid shadowing.
6069 (fn_rsvg_handle_free): Remove; unused.
6070 (svg_load, svg_load_image): Fix pointer signedness problem.
6071 (imagemagick_load_image): Don't use garbage pointer image_wand.
6072
6073 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6074
6075 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6076
6077 * image.c (gif_load): Fix omitted cast error introduced by
6078 2011-06-06 change.
6079
6080 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6081
6082 * window.h (resize_proportionally, orig_total_lines)
6083 (orig_top_line): Remove from window structure.
6084 (set_window_height, set_window_width, change_window_heights)
6085 (Fdelete_window): Remove prototypes.
6086 (resize_frame_windows): Remove duplicate declaration.
6087
6088 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6089
6090 * window.h (resize_frame_windows, resize_window_check)
6091 (delete_deletable_window, resize_root_window)
6092 (resize_frame_windows): Declare prototypes.
6093
6094 * window.c (resize_window_apply): Make definition be "static" to
6095 match the prototype.
6096
6097 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6098
6099 * window.c: Remove declarations of Qwindow_size_fixed,
6100 window_min_size_1, window_min_size_2, window_min_size,
6101 size_window, window_fixed_size_p, enlarge_window, delete_window.
6102 Remove static from declaration of Qdelete_window, it's
6103 temporarily needed by Fbury_buffer.
6104 (replace_window): Don't assign orig_top_line and
6105 orig_total_lines.
6106 (Fdelete_window, delete_window): Remove. Window deletion is
6107 handled by window.el.
6108 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6109 Replace Fdelete_window calls with calls to Qdelete_window.
6110 (Fdelete_other_windows): Remove. Deleting other windows is
6111 handled by window.el.
6112 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6113 handled in window.el.
6114 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6115 Window minimum sizes are handled in window.el.
6116 (shrink_windows, size_window, set_window_height)
6117 (set_window_width, change_window_heights, window_height)
6118 (window_width, CURBEG, CURSIZE, enlarge_window)
6119 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6120 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6121 handled in window.el.
6122 (make_dummy_parent): Rename to make_parent_window and give it a
6123 second argument horflag.
6124 (make_window): Don't set resize_proportionally any more.
6125 (Fsplit_window): Remove. Windows are split in window.el.
6126 (save_restore_action, save_restore_orig_size)
6127 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6128 Resize mini windows in window.el.
6129 (grow_mini_window, shrink_mini_window): Implement by calling
6130 Qresize_root_window_vertically, resize_window_check and
6131 resize_window_apply.
6132 (saved_window, Fset_window_configuration, save_window_save):
6133 Do not handle orig_top_line, orig_total_lines, and
6134 resize_proportionally.
6135 (window_min_height, window_min_width): Move to window.el.
6136 (keys_of_window): Move bindings for delete-other-windows,
6137 split-window, delete-window and enlarge-window to window.el.
6138
6139 * buffer.c: Temporarily extern Qdelete_window.
6140 (Fbury_buffer): Temporarily call Qdelete_window instead of
6141 Fdelete_window (Fbury_buffer will move to window.el soon).
6142
6143 * frame.c (set_menu_bar_lines_1): Remove code handling
6144 orig_top_line and orig_total_lines.
6145
6146 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6147 set_window_height but set heights directly.
6148 (change_frame_size_1): Use resize_frame_windows.
6149
6150 * xdisp.c (init_xdisp): Don't use set_window_height but set
6151 heights directly.
6152
6153 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6154 Use resize_frame_windows instead of change_window_heights and run
6155 run_window_configuration_change_hook.
6156
6157 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6158 instead of change_window_heights and run
6159 run_window_configuration_change_hook.
6160
6161 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6162
6163 * window.c (replace_window): Rename second argument REPLACEMENT to
6164 NEW. New third argument SETFLAG. Rewrite.
6165 (delete_window, make_dummy_parent): Call replace_window with
6166 third argument 1.
6167 (window_list_1): Move down in code.
6168 (run_window_configuration_change_hook): Move set_buffer part
6169 before select_frame_norecord part in order to unwind correctly.
6170 Rename count1 to count.
6171 (recombine_windows, delete_deletable_window, resize_root_window)
6172 (Fdelete_other_windows_internal)
6173 (Frun_window_configuration_change_hook, make_parent_window)
6174 (resize_window_check, resize_window_apply, Fresize_window_apply)
6175 (resize_frame_windows, Fsplit_window_internal)
6176 (Fdelete_window_internal, Fresize_mini_window_internal):
6177 New functions.
6178 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6179
6180 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6181
6182 * window.h (window): Add some new members to window structure -
6183 normal_lines, normal_cols, new_total, new_normal, clone_number,
6184 splits, nest, prev_buffers, next_buffers.
6185 (WINDOW_TOTAL_SIZE): Move here from window.c.
6186 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6187
6188 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6189 Remove.
6190 (make_dummy_parent): Set new members of windows structure.
6191 (make_window): Move down in code. Handle new members of window
6192 structure.
6193 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6194 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6195 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6196 (Fset_window_prev_buffers, Fwindow_next_buffers)
6197 (Fset_window_next_buffers, Fset_window_clone_number):
6198 New functions.
6199 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6200 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6201 Doc-string fixes.
6202 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6203 Argument WINDOW can be now internal window too.
6204 (Fwindow_use_time): Move up in code.
6205 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6206 Rewrite doc-string.
6207 (Fset_window_configuration, saved_window)
6208 (Fcurrent_window_configuration, save_window_save): Handle new
6209 members of window structure.
6210 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6211 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6212 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6213 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6214 Qget_mru_window, Qresize_root_window,
6215 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6216 Qauto_buffer_name; staticpro them.
6217
6218 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6219
6220 * window.c (Fwindow_total_size, Fwindow_left_column)
6221 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6222 (Fwindow_list_1): New functions.
6223 (window_box_text_cols): Replace with window_body_cols.
6224 (Fwindow_width, Fscroll_left, Fscroll_right):
6225 Use window_body_cols instead of window_box_text_cols.
6226 (delete_window, Fset_window_configuration):
6227 Call delete_all_subwindows with window as argument.
6228 (delete_all_subwindows): Take a window as argument and not a
6229 structure. Rewrite.
6230 (window_loop): Remove handling of GET_LRU_WINDOW and
6231 GET_LARGEST_WINDOW.
6232 (Fget_lru_window, Fget_largest_window): Move to window.el.
6233
6234 * window.h: Extern window_body_cols instead of
6235 window_box_text_cols. delete_all_subwindows now takes a
6236 Lisp_Object as argument.
6237
6238 * indent.c (compute_motion, Fcompute_motion):
6239 Use window_body_cols instead of window_box_text_cols.
6240
6241 * frame.c (delete_frame): Call delete_all_subwindows with root
6242 window as argument.
6243
6244 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6245
6246 * fns.c (Fputhash): Document return value.
6247
6248 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6249
6250 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6251
6252 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6253
6254 Cons<->int and similar integer overflow fixes (Bug#8794).
6255
6256 Check for overflow when converting integer to cons and back.
6257 * charset.c (Fdefine_charset_internal, Fdecode_char):
6258 Use cons_to_unsigned to catch overflow.
6259 (Fencode_char): Use INTEGER_TO_CONS.
6260 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6261 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6262 * data.c (long_to_cons, cons_to_long): Remove.
6263 (cons_to_unsigned, cons_to_signed): New functions.
6264 These signal an error for invalid or out-of-range values.
6265 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6266 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6267 * font.c (Ffont_variation_glyphs):
6268 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6269 * lisp.h: Include <intprops.h>.
6270 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6271 (cons_to_signed, cons_to_unsigned): New decls.
6272 (long_to_cons, cons_to_long): Remove decls.
6273 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6274 (Fprimitive_undo): Use CONS_TO_INTEGER.
6275 * xfns.c (Fx_window_property): Likewise.
6276 * xselect.c: Include <limits.h>.
6277 (x_own_selection, selection_data_to_lisp_data):
6278 Use INTEGER_TO_CONS.
6279 (x_handle_selection_request, x_handle_selection_clear)
6280 (x_get_foreign_selection, Fx_disown_selection_internal)
6281 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6282 (lisp_data_to_selection_data): Use cons_to_unsigned.
6283 (x_fill_property_data): Use cons_to_signed.
6284 Report values out of range.
6285
6286 Check for buffer and string overflow more precisely.
6287 * buffer.h (BUF_BYTES_MAX): New macro.
6288 * lisp.h (STRING_BYTES_MAX): New macro.
6289 * alloc.c (Fmake_string):
6290 * character.c (string_escape_byte8):
6291 * coding.c (coding_alloc_by_realloc):
6292 * doprnt.c (doprnt):
6293 * editfns.c (Fformat):
6294 * eval.c (verror):
6295 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6296 since they may not be the same number.
6297 * editfns.c (Finsert_char):
6298 * fileio.c (Finsert_file_contents):
6299 Likewise for BUF_BYTES_MAX.
6300
6301 * image.c: Use ptrdiff_t, not int, for sizes.
6302 (slurp_file): Switch from int to ptrdiff_t.
6303 All uses changed.
6304 (slurp_file): Check that file size fits in both size_t (for
6305 malloc) and ptrdiff_t (for sanity and safety).
6306
6307 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6308 if b->modtime has its maximal value.
6309
6310 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6311
6312 Don't assume time_t can fit into int.
6313 * buffer.h (struct buffer.modtime): Now time_t, not int.
6314 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6315 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6316
6317 Minor fixes for signed vs unsigned integers.
6318 * character.h (MAYBE_UNIFY_CHAR):
6319 * charset.c (maybe_unify_char):
6320 * keyboard.c (read_char, reorder_modifiers):
6321 XINT -> XFASTINT, since the integer must be nonnegative.
6322 * ftfont.c (ftfont_spec_pattern):
6323 * keymap.c (access_keymap, silly_event_symbol_error):
6324 XUINT -> XFASTINT, since the integer must be nonnegative.
6325 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6326 since it makes no difference and we prefer signed.
6327 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6328 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6329 nonnegative.
6330
6331 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6332
6333 * window.h (Fwindow_frame): Declare.
6334
6335 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6336
6337 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6338 (SPARE_MEMORY): Always define.
6339 (LARGE_REQUEST): Remove.
6340 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6341
6342 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6343
6344 * lisp.h: Move EXFUNS for Fframe_root_window,
6345 Fframe_first_window and Fset_frame_selected_window to window.h.
6346
6347 * window.h: Move EXFUNS for Fframe_root_window,
6348 Fframe_first_window and Fset_frame_selected_window here from
6349 lisp.h.
6350
6351 * frame.c (Fwindow_frame, Fframe_first_window)
6352 (Fframe_root_window, Fframe_selected_window)
6353 (Fset_frame_selected_window): Move to window.c.
6354 (Factive_minibuffer_window): Move to minibuf.c.
6355 (Fother_visible_frames_p): New function.
6356
6357 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6358
6359 * window.c (decode_window, decode_any_window): Move up in code.
6360 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6361 (inhibit_frame_unsplittable): Remove unused variable.
6362 (Fwindow_buffer): Move up and rewrite doc-string.
6363 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6364 (Fwindow_prev): New functions.
6365 (Fwindow_frame): Move here from frame.c. Accept any window as
6366 argument.
6367 (Fframe_root_window, Fframe_first_window)
6368 (Fframe_selected_window): Move here from frame.c. Accept frame
6369 or arbitrary window as argument. Update doc-strings.
6370 (Fminibuffer_window): Move up in code.
6371 (Fwindow_minibuffer_p): Move up in code and simplify.
6372 (Fset_frame_selected_window): Move here from frame.c.
6373 Marginal rewrite.
6374 (Fselected_window, select_window, Fselect_window): Move up in
6375 code. Minor doc-string fixes.
6376
6377 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6378
6379 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6380 Do not assume that spare memory exists; that assumption is valid
6381 only if SYSTEM_MALLOC.
6382 (LARGE_REQUEST): New macro, so that the issue of large requests
6383 is separated from the issue of spare memory.
6384
6385 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6386
6387 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6388 format. (Bug#8806)
6389
6390 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6391
6392 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6393 before statements.
6394
6395 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6396
6397 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6398
6399 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6400
6401 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6402 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6403
6404 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6405
6406 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6407
6408 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6409
6410 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6411 (x_clipboard_manager_save): Add return value.
6412 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6413 New error handlers.
6414 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6415 Obey Vx_select_enable_clipboard_manager. Catch errors in
6416 x_clipboard_manager_save (Bug#8779).
6417 (Vx_select_enable_clipboard_manager): New variable.
6418 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6419
6420 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6421
6422 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6423
6424 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6425
6426 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6427 in the current matrix if keep_current_p is non-zero.
6428
6429 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6430
6431 * bidi.c (bidi_level_of_next_char): Fix last change.
6432
6433 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6434
6435 Support bidi reordering of text covered by display properties.
6436
6437 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6438 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6439 (bidi_cache_search, bidi_cache_iterator_state)
6440 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6441 (bidi_level_of_next_char, bidi_move_to_visually_next):
6442 Support character positions inside a run of characters covered by a
6443 display string.
6444 (bidi_paragraph_init, bidi_resolve_explicit_1)
6445 (bidi_level_of_next_char): Call bidi_fetch_char and
6446 bidi_fetch_char_advance instead of FETCH_CHAR and
6447 FETCH_CHAR_ADVANCE.
6448 (bidi_init_it): Initialize new members.
6449 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6450 definitions.
6451 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6452 instead of using explicit *_CHAR codes.
6453 (bidi_resolve_explicit, bidi_resolve_weak):
6454 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6455 bidirectional text is supported only in multibyte buffers.
6456 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6457 it to initialize the frame_window_p member of struct bidi_it.
6458 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6459 (bidi_resolve_explicit, bidi_resolve_weak)
6460 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6461 bidi_it->nchars is non-positive.
6462 (bidi_level_of_next_char): Don't try to lookup the cache for the
6463 next/previous character if nothing is cached there yet, or if we
6464 were just reseat()'ed to a new position.
6465
6466 * xdisp.c (set_cursor_from_row): Set start and stop points
6467 according to the row's direction when priming the loop that looks
6468 for the glyph on which to display cursor.
6469 (single_display_spec_intangible_p): Function deleted.
6470 (display_prop_intangible_p): Reimplement to call
6471 handle_display_spec instead of single_display_spec_intangible_p.
6472 Accept 3 additional arguments needed by handle_display_spec.
6473 This fixes incorrect cursor motion across display property with complex
6474 values: lists, `(when COND...)' forms, etc.
6475 (single_display_spec_string_p): Support property values that are
6476 lists with the argument STRING its top-level element.
6477 (display_prop_string_p): Fix the condition for processing a
6478 property that is a list to be consistent with handle_display_spec.
6479 (handle_display_spec): New function, refactored from the
6480 last portion of handle_display_prop.
6481 (compute_display_string_pos): Accept additional argument
6482 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6483 value of a `display' property is a "replacing spec".
6484 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6485 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6486 the display property, but just return a value indicating whether
6487 the display property will replace the characters it covers.
6488 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6489 frame_window_p members of struct bidi_it.
6490 (compute_display_string_pos, compute_display_string_end):
6491 New functions.
6492 (push_it): Accept second argument POSITION, where pop_it should
6493 jump to continue iteration.
6494 (reseat_1): Initialize bidi_it.disp_pos.
6495
6496 * keyboard.c (adjust_point_for_property): Adjust the call to
6497 display_prop_intangible_p to its new signature.
6498
6499 * dispextern.h (struct bidi_it): New member frame_window_p.
6500 (bidi_init_it): Update prototypes.
6501 (display_prop_intangible_p): Update prototype.
6502 (compute_display_string_pos, compute_display_string_end):
6503 Declare prototypes.
6504 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6505 EMACS_INT.
6506
6507 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6508
6509 Malloc failure behavior now depends on size of allocation.
6510 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6511 * lisp.h: Change signatures accordingly.
6512 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6513 All callers changed. (Bug#8762)
6514
6515 * gnutls.c: Use Emacs's memory allocators.
6516 Without this change, the gnutls library would invoke malloc etc.
6517 directly, which causes problems on non-SYNC_INPUT hosts, and which
6518 runs afoul of improving memory_full behavior. (Bug#8761)
6519 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6520 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6521 xfree instead of the default malloc, realloc, free.
6522 (Fgnutls_boot): No need to check for memory allocation failure,
6523 since xmalloc does that for us.
6524
6525 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6526 * category.c (hash_get_category_set):
6527 * ccl.c (ccl_driver):
6528 * charset.c (Fdefine_charset_internal):
6529 * charset.h (struct charset.hash_index):
6530 * composite.c (get_composition_id, gstring_lookup_cache)
6531 (composition_gstring_put_cache):
6532 * composite.h (struct composition.hash_index):
6533 * dispextern.h (struct image.hash):
6534 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6535 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6536 (hashfn_equal, hashfn_user_defined, make_hash_table)
6537 (maybe_resize_hash_table, hash_lookup, hash_put)
6538 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6539 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6540 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6541 * image.c (make_image, search_image_cache, lookup_image)
6542 (xpm_put_color_table_h):
6543 * lisp.h (struct Lisp_Hash_Table):
6544 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6545 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6546 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6547 * alloc.c (allocate_vectorlike):
6548 Check for overflow in vector size calculations.
6549 * ccl.c (ccl_driver):
6550 Check for overflow when converting EMACS_INT to int.
6551 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6552 need to be updated by these changes.
6553 * fns.c (make_hash_table, maybe_resize_hash_table):
6554 Check for integer overflow with large hash tables.
6555 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6556 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6557 (SXHASH_REDUCE): New macro.
6558 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6559 Use it instead of discarding useful hash info with large hash values.
6560 (sxhash_float): New function.
6561 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6562 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6563 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6564 Rewrite to use FIXNUM_BITS, as this simplifies things.
6565 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6566 Adjust signatures to match updated version of code.
6567 (consing_since_gc): Now EMACS_INT, since a single hash table can
6568 use more than INT_MAX bytes.
6569
6570 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6571
6572 Make it possible to build with GCC-4.6+ -O2 -flto.
6573
6574 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6575
6576 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6577
6578 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6579 Call minibuffer-inactive-mode.
6580
6581 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6582
6583 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6584 Update dependencies.
6585
6586 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6587
6588 * data.c (init_data): Remove code for UTS, this system is not
6589 supported anymore.
6590
6591 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6592
6593 Don't force ./temacs to start in terminal mode.
6594
6595 * frame.c (make_initial_frame): Initialize faces in all cases, not
6596 only when CANNOT_DUMP is defined.
6597 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6598
6599 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6600
6601 * dispnew.c (add_window_display_history): Use const for the string
6602 pointer. Remove declaration, not needed.
6603
6604 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6605
6606 Use 'inline', not 'INLINE'.
6607 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6608 * alloc.c, fontset.c (INLINE): Remove.
6609 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6610 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6611 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6612 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6613 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6614
6615 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6616
6617 Make it possible to run ./temacs.
6618
6619 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6620 syms_of_callproc does the same thing. Remove test for
6621 "initialized", do it in the caller.
6622 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6623
6624 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6625
6626 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6627 (read_minibuf): Use get_minibuffer.
6628 (syms_of_minibuf): Use DEFSYM.
6629 (Qmetadata): New var.
6630 * data.c (Qbuffer): Don't make it static.
6631 (syms_of_data): Use DEFSYM.
6632
6633 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6634
6635 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6636 (CCL_CODE_MIN): New macro.
6637
6638 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6639
6640 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6641
6642 * eval.c (Qdebug): Now static.
6643 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6644 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6645 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6646
6647 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6648
6649 * image.c: Various fixes to ImageMagick code comments.
6650 (Fimagemagick_types): Doc fix.
6651
6652 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6653
6654 Minor fixes prompted by GCC 4.6.0 warnings.
6655
6656 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6657
6658 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6659 (x_clipboard_manager_save_all): Move extern decl to ...
6660 * xterm.h: ... here, so that it can be checked for consistency.
6661
6662 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6663
6664 * xselect.c (x_clipboard_manager_save_frame)
6665 (x_clipboard_manager_save_all): New functions.
6666 (Fx_clipboard_manager_save): Lisp function deleted.
6667
6668 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6669 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6670
6671 * xterm.h: Update prototype.
6672
6673 2011-05-28 William Xu <william.xwl@gmail.com>
6674
6675 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6676 exiting (Bug#8239).
6677
6678 2011-05-28 Jim Meyering <meyering@redhat.com>
6679
6680 Avoid a sign-extension bug in crypto_hash_function.
6681 * fns.c (to_uchar): Define.
6682 (crypto_hash_function): Use it to convert some newly-signed
6683 variables to unsigned, to avoid sign-extension bugs. For example,
6684 without this change, (md5 "truc") would evaluate to
6685 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6686 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6687 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6688
6689 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6690
6691 Integer overflow fixes.
6692
6693 * dbusbind.c: Serial number integer overflow fixes.
6694 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6695 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6696 to hold a serial number that is too large for a fixnum.
6697 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6698 Check for serial numbers out of range. Decode any serial number
6699 that was so large that it became a float. (Bug#8722)
6700
6701 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6702 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6703 Use XFASTINT rather than XUINT when numbers are nonnegative.
6704 (xd_append_arg, Fdbus_method_return_internal):
6705 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6706 arguments, check that Lisp number is nonnegative, rather than
6707 silently wrapping negative numbers around. (Bug#8722)
6708 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6709 (Bug#8722)
6710
6711 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6712
6713 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6714
6715 ccl: Add integer overflow checks.
6716 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6717 (IN_INT_RANGE): New macros.
6718 (ccl_driver): Use them to check for integer overflow when
6719 decoding a CCL program. Many of the new checks are whether XINT (x)
6720 fits in int; it doesn't always, on 64-bit hosts. The new version
6721 doesn't catch all possible integer overflows, but it's an
6722 improvement. (Bug#8719)
6723
6724 * alloc.c (make_event_array): Use XINT, not XUINT.
6725 There's no need for unsigned here.
6726
6727 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6728 This follows up to the 2011-05-06 change that substituted uintptr_t
6729 for EMACS_INT. This case wasn't caught back then.
6730
6731 Rework Fformat to avoid integer overflow issues.
6732 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6733 now (part of C89). Include <verify.h>.
6734 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6735 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6736 (Fformat): Avoid the prepass trying to compute sizes; it was only
6737 approximate and thus did not catch overflow reliably. Instead, walk
6738 through the format just once, formatting and computing sizes as we go,
6739 checking for integer overflow at every step, and allocating a larger
6740 buffer as needed. Keep track separately whether the format is
6741 multibyte. Keep only the most-recently calculated precision, rather
6742 than them all. Record whether each argument has been converted to
6743 string. Use EMACS_INT, not int, for byte and char and arg counts.
6744 Support field widths and precisions larger than INT_MAX. Avoid
6745 sprintf's undefined behavior with conversion specifications such as %#d
6746 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6747 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6748 formatting out-of-range floating point numbers with int
6749 formats. (Bug#8668)
6750
6751 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6752
6753 * data.c: Avoid integer truncation in expressions involving floats.
6754 * data.c: Include <intprops.h>.
6755 (arith_driver): When there's an integer overflow in an expression
6756 involving floating point, convert the integers to floating point
6757 so that the resulting value does not suffer from catastrophic
6758 integer truncation. For example, on a 64-bit host (* 4
6759 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6760 Do not rely on undefined behavior after integer overflow.
6761
6762 merge count_size_as_multibyte, parse_str_to_multibyte
6763 * character.c, character.h (count_size_as_multibyte):
6764 Rename from parse_str_to_multibyte; all uses changed.
6765 Check for integer overflow.
6766 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6767 since it's now a duplicate of the other. This is more of
6768 a character than a buffer op, so better that it's in character.c.
6769 * fns.c, print.c: Adjust to above changes.
6770
6771 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6772
6773 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6774
6775 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6776
6777 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6778 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6779 (x_clipboard_manager_save): Now static.
6780 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6781
6782 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6783 (crypto_hash_function): Now static.
6784 Fix pointer signedness problems. Avoid unnecessary initializations.
6785
6786 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6787
6788 * termhooks.h (Vselection_alist): Make it terminal-local.
6789
6790 * terminal.c (create_terminal): Initialize it.
6791
6792 * xselect.c: Support for clipboard managers.
6793 (Vselection_alist): Move to termhooks.h as terminal-local var.
6794 (LOCAL_SELECTION): New macro.
6795 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6796 (symbol_to_x_atom): Remove gratuitous arg.
6797 (x_handle_selection_request, lisp_data_to_selection_data)
6798 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6799 (x_own_selection, x_get_local_selection, x_convert_selection):
6800 New arg, specifying work frame. Use terminal-local Vselection_alist.
6801 (some_frame_on_display): Delete unused function.
6802 (Fx_own_selection_internal, Fx_get_selection_internal)
6803 (Fx_disown_selection_internal, Fx_selection_owner_p)
6804 (Fx_selection_exists_p): New optional frame arg.
6805 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6806 (x_handle_selection_clear): Don't treat other terminals with the
6807 same keyboard specially. Use the terminal-local Vselection_alist.
6808 (x_clear_frame_selections): Use Frun_hook_with_args.
6809
6810 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6811
6812 * xterm.h: Add support for those atoms.
6813
6814 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6815
6816 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6817 (converted_selections, conversion_fail_tag): New global variables.
6818 (x_selection_request_lisp_error): Free the above.
6819 (x_get_local_selection): Remove unnecessary code.
6820 (x_reply_selection_request): Args changed; handle arbitrary array
6821 of converted selections stored in converted_selections.
6822 Separate the XChangeProperty and SelectionNotify steps.
6823 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6824 (x_convert_selection): New function.
6825 (x_handle_selection_event): Simplify.
6826 (x_get_foreign_selection): Don't ignore incoming requests while
6827 waiting for an answer; this will fail when we implement
6828 SAVE_TARGETS, and seems unnecessary anyway.
6829 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6830 (Vx_sent_selection_functions): Doc fix.
6831
6832 2011-05-26 Leo Liu <sdl.web@gmail.com>
6833
6834 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6835
6836 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6837
6838 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6839
6840 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6841 for fringe update if it has periodic bitmap.
6842 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6843 and fringe_bitmap_periodic_p.
6844
6845 * fringe.c (get_fringe_bitmap_data): New function.
6846 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6847 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6848 row. Mark glyph row for fringe update if periodicity changed.
6849
6850 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6851 for fringe update unless it has periodic bitmap.
6852
6853 2011-05-25 Kenichi Handa <handa@m17n.org>
6854
6855 * xdisp.c (get_next_display_element): Set correct it->face_id for
6856 a static composition.
6857
6858 2011-05-24 Leo Liu <sdl.web@gmail.com>
6859
6860 * deps.mk (fns.o):
6861 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6862
6863 * fns.c (crypto_hash_function, Fsha1): New function.
6864 (Fmd5): Use crypto_hash_function.
6865 (syms_of_fns): Add Ssha1.
6866
6867 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6868
6869 * gnutls.c: Remove unused macros.
6870 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6871 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6872 Remove macros that are defined and never used.
6873 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6874
6875 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6876
6877 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6878 (Fx_get_selection_internal): Minor cleanup.
6879 (Fx_own_selection_internal): Rename arguments for consistency with
6880 select.el.
6881
6882 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6883
6884 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6885
6886 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6887
6888 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6889
6890 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6891
6892 * dispnew.c (scrolling_window): Don't exclude the case that the
6893 last enabled row in the desired matrix touches the bottom boundary.
6894
6895 2011-05-21 Glenn Morris <rgm@gnu.org>
6896
6897 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6898 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6899 and add some more files.
6900
6901 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6902
6903 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6904 report_file_error introduced by the change from 2011-05-07.
6905
6906 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6907
6908 * systime.h (Time): Define only if emacs is defined.
6909 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6910 where the include path doesn't have X11/X.h by default. See
6911 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6912
6913 2011-05-20 Kenichi Handa <handa@m17n.org>
6914
6915 * composite.c (find_automatic_composition): Fix previous change.
6916
6917 2011-05-20 Glenn Morris <rgm@gnu.org>
6918
6919 * lisp.mk: New file, split from Makefile.in.
6920 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6921 (shortlisp): Remove.
6922 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6923
6924 2011-05-19 Glenn Morris <rgm@gnu.org>
6925
6926 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6927 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6928 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6929 (lisp): Set the order to that of loadup.el.
6930 (shortlisp): Make it a copy of $lisp.
6931 (SOME_MACHINE_LISP): Remove.
6932 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6933 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6934
6935 2011-05-18 Kenichi Handa <handa@m17n.org>
6936
6937 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6938 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6939 (find_automatic_composition): Mostly rewrite for efficiency.
6940
6941 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6942
6943 * makefile.w32-in: Update dependencies.
6944
6945 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6946
6947 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6948 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6949
6950 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6951
6952 Fix some integer overflow issues, such as string length overflow.
6953
6954 * insdel.c (count_size_as_multibyte): Check for string overflow.
6955
6956 * character.c (lisp_string_width): Check for string overflow.
6957 Use EMACS_INT, not int, for string indexes and lengths; in
6958 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6959 the resulting string length overflows an EMACS_INT; instead,
6960 report a string overflow if no precision given. When checking for
6961 precision exhaustion, use a check that cannot possibly have
6962 integer overflow. (Bug#8675)
6963 * character.h (lisp_string_width): Adjust to new signature.
6964
6965 * alloc.c (string_overflow): New function.
6966 (Fmake_string): Use it. This doesn't change behavior, but saves
6967 a few bytes and will simplify future changes.
6968 * character.c (string_escape_byte8): Likewise.
6969 * lisp.h (string_overflow): New decl.
6970
6971 Fixups, following up to the user-interface timestamp change.
6972 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6973 for UI timestamps, instead of unsigned long.
6974 * msdos.c (mouse_get_pos): Likewise.
6975 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6976 * w32gui.h (Time): Define by including "systime.h" rather than by
6977 declaring it ourselves. (Bug#8664)
6978
6979 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6980 * image.c (clear_image_cache): Likewise.
6981
6982 * term.c (term_mouse_position): Don't assume time_t wraparound.
6983
6984 Be more systematic about user-interface timestamps.
6985 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6986 and sometimes 'EMACS_UINT', to represent these timestamps.
6987 This change causes it to use 'Time' uniformly, as that's what X uses.
6988 This makes the code easier to follow, and makes it easier to catch
6989 integer overflow bugs such as Bug#8664.
6990 * frame.c (Fmouse_position, Fmouse_pixel_position):
6991 Use Time, not unsigned long, for user-interface timestamps.
6992 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6993 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6994 * keyboard.h (last_event_timestamp): Likewise.
6995 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6996 * menu.h (xmenu_show): Likewise.
6997 * term.c (term_mouse_position): Likewise.
6998 * termhooks.h (struct input_event.timestamp): Likewise.
6999 (struct terminal.mouse_position_hook): Likewise.
7000 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7001 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7002 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7003 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7004 what it was before.
7005 * menu.h, termhooks.h: Include "systime.h", for Time.
7006
7007 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7008 Don't assume that the difference between two unsigned long values
7009 can fit into an integer. At this point, we know button_down_time
7010 <= event->timestamp, so the difference must be nonnegative, so
7011 there's no need to cast the result if double-click-time is
7012 nonnegative, as it should be; check that it's nonnegative, just in
7013 case. This bug is triggered when events are more than 2**31 ms
7014 apart (about 25 days). (Bug#8664)
7015
7016 * xselect.c (last_event_timestamp): Remove duplicate decl.
7017 (x_own_selection): Remove needless cast to unsigned long.
7018
7019 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7020 that always fit in int. Use a sentinel instead of a counter, to
7021 avoid a temp and to allay GCC's concerns about possible int overflow.
7022 * frame.h (struct frame): Use int for menu_bar_items_used
7023 instead of EMACS_INT, since it always fits in int.
7024
7025 * menu.c (grow_menu_items): Check for int overflow.
7026
7027 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7028
7029 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7030 Before, the code was not consistent. These values cannot exceed
7031 2**31 - 1 so there's no need to make them unsigned.
7032 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7033 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7034 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7035 as modifiers.
7036 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7037
7038 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7039 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7040 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7041 presumably because the widths might not match.
7042
7043 * window.c (size_window): Avoid needless test at loop start.
7044
7045 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7046
7047 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7048
7049 2011-05-12 Drew Adams <drew.adams@oracle.com>
7050
7051 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7052
7053 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7054
7055 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7056 `width' to `bar_area_x' and `bar_area_width', respectively.
7057 (x_scroll_run): Take account of fringe background extension.
7058
7059 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7060 Rename local vars `left' and `width' to `bar_area_x' and
7061 `bar_area_width', respectively.
7062 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7063 background extension.
7064
7065 2011-05-10 Jim Meyering <meyering@redhat.com>
7066
7067 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7068
7069 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7070
7071 * image.c (Finit_image_library): Return t for built-in image types,
7072 like pbm and xbm. (Bug#8640)
7073
7074 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7075
7076 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7077
7078 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7079
7080 * w32console.c (Fset_screen_color): Doc fix.
7081 (Fget_screen_color): New function.
7082 (syms_of_ntterm): Defsubr it.
7083
7084 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7085 unlink the temporary file if Fcall_process didn't create it in the
7086 first place.
7087 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7088 child process will be redirected to a file specified with `:file'.
7089 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7090 cue to call_process_cleanup not to close that handle.
7091
7092 2011-05-07 Ben Key <bkey76@gmail.com>
7093
7094 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7095 one of two shell specific rules, either bootstrap-temacs-CMD or
7096 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7097 to the previous implementation of the bootstrap-temacs rule.
7098 The bootstrap-temacs-CMD rule is similar to the previous
7099 implementation of the bootstrap-temacs rule except that it
7100 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7101 variable.
7102
7103 These changes, along with some changes to nt/configure.bat,
7104 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7105 earlier fix to add support for --cflags and --ldflags options
7106 that include quotes so that it works whether make uses cmd or
7107 sh as the shell.
7108
7109 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7110
7111 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7112 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7113 is a constant.
7114 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7115 a string. Handle both cases.
7116 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7117 (Fdbus_register_method): Use Qinvalid_function.
7118
7119 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7120
7121 * makefile.w32-in: Update dependencies.
7122 (LISP_H): Add inttypes.h and stdin.h.
7123 (PROCESS_H): Add unistd.h.
7124
7125 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7126
7127 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7128 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7129
7130 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7131
7132 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7133
7134 * term.c (vfatal): Remove stray call to va_end.
7135 It's not needed and the C Standard doesn't allow it here anyway.
7136
7137 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7138 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7139
7140 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7141 bytes.
7142
7143 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7144
7145 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7146
7147 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7148
7149 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7150
7151 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7152
7153 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7154 * charset.c (Fdefine_charset_internal): Don't initialize
7155 charset.code_space[15]. The value was garbage, on hosts with
7156 32-bit int (Bug#8600).
7157
7158 * lread.c (read_integer): Be more consistent with string-to-number.
7159 Use string_to_number to do the actual conversion; this avoids
7160 rounding errors and fixes some other screwups. Without this fix,
7161 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7162 (digit_to_number): Move earlier, for benefit of read_integer.
7163 Return -1 if the digit is out of range for the base, -2 if it is
7164 not a digit in any supported base. (Bug#8602)
7165
7166 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7167
7168 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7169 to match comment at start of function. This also removes a
7170 GCC warning about overflow in a 32+64-bit port.
7171
7172 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7173
7174 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7175 Reported by Stefan Monnier in
7176 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7177 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7178 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7179
7180 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7181 (EMACS_UINTPTR): Likewise, with uintptr_t.
7182
7183 * lisp.h: Prefer 64-bit EMACS_INT if available.
7184 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7185 on 32-bit hosts that have 64-bit int, so that they can access
7186 large files.
7187 However, temporarily disable this change unless the temporary
7188 symbol WIDE_EMACS_INT is defined.
7189
7190 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7191
7192 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7193 This removes an assumption that EMACS_INT and long are the same
7194 width as pointers. The assumption is true for Emacs porting targets
7195 now, but we want to make other targets possible.
7196 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7197 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7198 In the rest of the code, change types of integers that hold casted
7199 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7200 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7201 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7202 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7203 No need to cast type when ORing.
7204 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7205 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7206 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7207 assume EMACS_INT is the same width as char *.
7208 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7209 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7210 Remove no-longer-needed casts.
7211 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7212 (xg_tool_bar_help_callback, xg_make_tool_item):
7213 Use EMACS_INTPTR to hold an integer
7214 that will be cast to void *; this can avoid a GCC warning
7215 if EMACS_INT is not the same width as void *.
7216 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7217 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7218 (current_message_1, set_message_1):
7219 Use a local to convert to proper width without a cast.
7220 * xmenu.c (dialog_selection_callback): Likewise.
7221
7222 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7223 Also, don't assume VALBITS / RAND_BITS is less than 5,
7224 and don't rely on undefined behavior when shifting a 1 left into
7225 the sign bit.
7226 * lisp.h (get_random): Change signature to match.
7227
7228 * lread.c (hash_string): Use size_t, not int, for hash computation.
7229 Normally we prefer signed values; but hashing is special, because
7230 it's better to use unsigned division on hash table sizes so that
7231 the remainder is nonnegative. Also, size_t is the natural width
7232 for hashing into memory. The previous code used 'int', which doesn't
7233 retain enough info to hash well into very large tables.
7234 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7235
7236 * dbusbind.c: Don't possibly lose pointer info when converting.
7237 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7238 Use XPNTR rather than XHASH, so that the high-order bits of
7239 the pointer aren't lost when converting through void *.
7240
7241 * eval.c (Fautoload): Don't double-shift a pointer.
7242
7243 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7244
7245 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7246
7247 * gnutls.c (DEF_GNUTLS_FN):
7248 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7249
7250 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7251
7252 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7253 marker. (Bug#8610)
7254
7255 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7256
7257 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7258 New version that can reserve upto 2GB of heap space.
7259
7260 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7261
7262 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7263
7264 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7265
7266 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7267 `gnutls_certificate_set_x509_key_file'.
7268
7269 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7270
7271 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7272 Update dependencies.
7273
7274 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7275
7276 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7277 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7278 Remove unused parameter `fildes'.
7279 * process.c (read_process_output, send_process): Don't pass it.
7280
7281 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7282
7283 Fix previous change: the library cache is defined in w32.c.
7284 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7285 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7286
7287 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7288
7289 Implement dynamic loading of GnuTLS on Windows.
7290
7291 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7292 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7293 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7294 Declare.
7295
7296 * gnutls.c (Qgnutls_dll): Define.
7297 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7298 (gnutls_*): Declare function pointers.
7299 (init_gnutls_functions): New function to initialize function pointers.
7300 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7301 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7302 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7303 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7304 (emacs_gnutls_write, emacs_gnutls_read)
7305 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7306 (Fgnutls_available_p): New function.
7307 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7308 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7309 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7310
7311 * image.c: Include w32.h.
7312 (Vimage_type_cache): Delete.
7313 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7314 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7315 (w32_delayed_load): Move to w32.c.
7316
7317 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7318
7319 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7320 (w32_delayed_load): Move from image.c. When loading a library, record
7321 its filename in the :loaded-from property of the library id.
7322 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7323 Initialize and staticpro them.
7324 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7325
7326 * process.c: Include lisp.h before w32.h, not after.
7327 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7328 instead of gnutls_record_check_pending.
7329
7330 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7331
7332 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7333
7334 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7335 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7336 as passed in.
7337
7338 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7339
7340 * xterm.c (x_set_frame_alpha): Do not set property on anything
7341 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7342
7343 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7344
7345 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7346
7347 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7348
7349 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7350 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7351 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7352 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7353 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7354 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7355 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7356 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7357 (Qgnutls_bootprop_callbacks_verify): Make static.
7358
7359 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7360
7361 * callproc.c: Indentation fixup.
7362
7363 * sysdep.c (wait_for_termination_1): Make static.
7364 (wait_for_termination, interruptible_wait_for_termination):
7365 Move after wait_for_termination_1.
7366
7367 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7368
7369 * sysdep.c (interruptible_wait_for_termination): New function
7370 which is like wait_for_termination, but allows keyboard
7371 interruptions.
7372
7373 * callproc.c (Fcall_process): Add (:file "file") as an option for
7374 the STDOUT buffer.
7375 (Fcall_process_region): Ditto.
7376
7377 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7378
7379 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7380 rather than `XVECTOR (FOO)->size'.
7381
7382 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7383 inttypes.h, as a gnulib replacement is used if it not available in
7384 system headers.
7385
7386 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7387
7388 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7389 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7390 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7391
7392 * coding.c (coding_alloc_by_realloc): Error out if destination
7393 will grow beyond MOST_POSITIVE_FIXNUM.
7394 (decode_coding_emacs_mule): Abort if there isn't enough place in
7395 charbuf for the composition carryover bytes. Reserve an extra
7396 space for up to 2 characters produced in a loop.
7397 (decode_coding_iso_2022): Abort if there isn't enough place in
7398 charbuf for the composition carryover bytes.
7399
7400 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7401
7402 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7403 aborting when %lld or %lll format is passed.
7404 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7405 %llo or %llx format is passed. (Bug#8545)
7406
7407 * window.c (window_scroll_line_based): Use a marker instead of
7408 simple variables to record original value of point. (Bug#7952)
7409
7410 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7411 produced by %s or %c overflows available buffer space. (Bug#8545)
7412
7413 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7414
7415 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7416 (SIZE_MAX): Move defn after all includes, as they might #define it.
7417
7418 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7419
7420 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7421
7422 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7423
7424 * keyboard.c (Qdelayed_warnings_hook): Define.
7425 (command_loop_1): Run `delayed-warnings-hook'
7426 if Vdelayed_warnings_list is non-nil.
7427 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7428 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7429
7430 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7431
7432 * doprnt.c (doprnt): Don't return value smaller than the buffer
7433 size if the message was truncated. (Bug#8545).
7434
7435 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7436
7437 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7438 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7439
7440 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7441
7442 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7443
7444 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7445
7446 * makefile.w32-in: Update dependencies.
7447
7448 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7449
7450 Improve `doprnt' and its usage. (Bug#8545)
7451 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7452 `format_end'. Remove support for %l as a conversion specifier.
7453 Don't use xrealloc. Improve diagnostics when the %l size modifier
7454 is used. Update the commentary.
7455
7456 * eval.c (verror): Simplify calculation of size_t.
7457
7458 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7459 messages.
7460
7461 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7462
7463 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7464 change.
7465
7466 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7467
7468 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7469 This makes this file independent of the recent pseudovector change.
7470
7471 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7472
7473 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7474
7475 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7476 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7477 Remove unused local.
7478 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7479
7480 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7481 GCC 4.6.0 optimizes based on type-based alias analysis.
7482 For example, if b is of type struct buffer * and v of type struct
7483 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7484 != &v->size, and therefore "v->size = 1; b->size = 2; return
7485 v->size;" must therefore return 1. This assumption is incorrect
7486 for Emacs, since it type-puns struct Lisp_Vector * with many other
7487 types. To fix this problem, this patch adds a new type struct
7488 vectorlike_header that documents the constraints on layout of vectors
7489 and pseudovectors, and helps optimizing compilers not get fooled
7490 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7491 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7492 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7493 the size member.
7494 (XSETPVECTYPE): Rewrite in terms of new macro.
7495 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7496 This is a bit clearer, and further avoids the possibility of
7497 undesirable aliasing.
7498 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7499 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7500 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7501 since Lisp_Subr is a special case (no "next" field).
7502 (ASIZE): Now uses header.size rather than size.
7503 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7504 to avoid the hassle of writing XVECTOR (foo)->header.size.
7505 (struct vectorlike_header): New type.
7506 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7507 object, to help avoid aliasing.
7508 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7509 (SUBRP): Likewise, since Lisp_Subr is a special case.
7510 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7511 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7512 (struct Lisp_Hash_Table): Combine first two members into a single
7513 struct vectorlike_header member. All uses of "size" and "next" members
7514 changed to be "header.size" and "header.next".
7515 * buffer.h (struct buffer): Likewise.
7516 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7517 * frame.h (struct frame): Likewise.
7518 * process.h (struct Lisp_Process): Likewise.
7519 * termhooks.h (struct terminal): Likewise.
7520 * window.c (struct save_window_data, struct saved_window): Likewise.
7521 * window.h (struct window): Likewise.
7522 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7523 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7524 * buffer.c (init_buffer_once): Likewise.
7525 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7526 special case.
7527 * process.c (Fformat_network_address): Use local var for size,
7528 for brevity.
7529
7530 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7531
7532 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7533 * data.c (atof): Remove decl; no longer used or needed.
7534 (digit_to_number): Move to lread.c.
7535 (Fstring_to_number): Use new string_to_number function, to be
7536 consistent with how the Lisp reader treats infinities and NaNs.
7537 Do not assume that floating-point numbers represent EMACS_INT
7538 without losing information; this is not true on most 64-bit hosts.
7539 Avoid double-rounding errors, by insisting on integers when
7540 parsing non-base-10 numbers, as the documentation specifies.
7541 * lisp.h (string_to_number): New decl, replacing ...
7542 (isfloat_string): Remove.
7543 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7544 (read1): Do not accept +. and -. as integers; this
7545 appears to have been a coding error. Similarly, do not accept
7546 strings like +-1e0 as floating point numbers. Do not report
7547 overflow for integer overflows unless the base is not 10 which
7548 means we have no simple and reliable way to continue.
7549 Break out the floating-point parsing into a new
7550 function string_to_number, so that Fstring_to_number parses
7551 floating point numbers consistently with the Lisp reader.
7552 (digit_to_number): Move here from data.c. Make it static inline.
7553 (E_CHAR, EXP_INT): Remove, replacing with ...
7554 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7555 (string_to_number): New function, replacing isfloat_string.
7556 This function checks for valid syntax and produces the resulting
7557 Lisp float number too. Rework it so that string-to-number
7558 no longer mishandles examples like "1.0e+". Use strtoumax,
7559 so that overflow for non-base-10 numbers is reported only when
7560 there's no portable and simple way to convert to floating point.
7561
7562 * textprop.c (set_text_properties_1): Rewrite for clarity,
7563 and to avoid GCC warning about integer overflow.
7564
7565 * intervals.h (struct interval): Use EMACS_INT for members
7566 where EMACS_UINT might cause problems. See
7567 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7568 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7569 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7570 All uses changed.
7571 (offset_intervals): Tell GCC not to worry about length overflow
7572 when negating a negative length.
7573
7574 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7575 (overrun_check_free): Likewise.
7576
7577 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7578 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7579 word size.
7580
7581 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7582 (gnutls_make_error): Rename local to avoid shadowing.
7583 (gnutls_emacs_global_deinit): ifdef out; not used.
7584 (Fgnutls_boot): Use const for pointer to readonly storage.
7585 Comment out unused local. Fix pointer signedness problems.
7586
7587 * lread.c (openp): Don't stuff size_t into an 'int'.
7588 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7589 about possible signed overflow.
7590
7591 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7592 (GDK_KEY_g): Don't define if already defined.
7593 (xg_prepare_tooltip): Avoid pointer signedness problem.
7594 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7595
7596 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7597 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7598
7599 * xfns.c (Fx_window_property): Simplify a bit,
7600 to make a bit faster and to avoid GCC 4.6.0 warning.
7601 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7602
7603 * fns.c (internal_equal): Don't assume size_t fits in int.
7604
7605 * alloc.c (compact_small_strings): Tighten assertion a little.
7606
7607 Replace pEd with more-general pI, and fix some printf arg casts.
7608 * lisp.h (pI): New macro, generalizing old pEd macro to other
7609 conversion specifiers. For example, use "...%"pI"d..." rather
7610 than "...%"pEd"...".
7611 (pEd): Remove. All uses replaced with similar uses of pI.
7612 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7613 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7614 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7615 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7616 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7617 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7618 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7619 64-bit hosts.
7620 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7621 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7622 * print.c (safe_debug_print, print_object): Likewise.
7623 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7624 to int.
7625 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7626 avoiding the 0 flag, which is not portable.
7627 * process.c (Fmake_network_process): Use pI to avoid cast.
7628 * region-cache.c (pp_cache): Likewise.
7629 * xdisp.c (decode_mode_spec): Likewise.
7630 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7631 behavior on 64-bit hosts with printf arg.
7632 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7633 (x_stop_queuing_selection_requests): Likewise.
7634 (x_get_window_property): Don't truncate byte count to an 'int'
7635 when tracing.
7636
7637 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7638 here, since it parses constructs like leading '-' and spaces,
7639 which are not wanted; and it overflows with large numbers.
7640 Instead, simply match F[0-9]+, which is what is wanted anyway.
7641
7642 * alloc.c: Remove unportable assumptions about struct layout.
7643 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7644 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7645 (allocate_vectorlike, make_pure_vector): Use the new macros,
7646 plus offsetof, to remove unportable assumptions about struct layout.
7647 These assumptions hold on all porting targets that I know of, but
7648 they are not guaranteed, they're easy to remove, and removing them
7649 makes further changes easier.
7650
7651 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7652 This doesn't fix a bug but makes the code clearer.
7653 (string_overrun_cookie): Now const. Use initializers that
7654 don't formally overflow signed char, to avoid warnings.
7655 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7656 can cause Emacs to crash when string overrun checking is enabled.
7657 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7658 multiple of sizeof (EMACS_INT); it need not be, if
7659 alignof(EMACS_INT) < sizeof (EMACS_INT).
7660 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7661
7662 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7663
7664 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7665
7666 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7667
7668 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7669 supposed to be handshaking. (Bug#8556)
7670 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7671
7672 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7673
7674 * lisp.h (Qdebug): List symbol.
7675 * eval.c (Qdebug): Restore global linkage.
7676 * keyboard.c (debug-on-event): New variable.
7677 (handle_user_signal): Break into debugger when debug-on-event
7678 matches the current signal symbol.
7679
7680 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7681
7682 * alloc.c (check_sblock, check_string_bytes)
7683 (check_string_free_list): Convert to standard C.
7684
7685 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7686
7687 * w32.c (emacs_gnutls_push): Fix typo.
7688
7689 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7690
7691 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7692 "cast to pointer from integer of different size".
7693
7694 Improve doprnt and its use in verror. (Bug#8545)
7695 * doprnt.c (doprnt): Document the set of format control sequences
7696 supported by the function. Use SAFE_ALLOCA instead of always
7697 using `alloca'.
7698
7699 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7700 is one byte too soon. Don't use xrealloc; instead xfree and
7701 xmalloc anew.
7702
7703 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7704
7705 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7706 callbacks stage.
7707
7708 * gnutls.c: Renamed global_initialized to
7709 gnutls_global_initialized. Added internals for the
7710 :verify-hostname-error, :verify-error, and :verify-flags
7711 parameters of `gnutls-boot' and documented those parameters in the
7712 docstring. Start callback support.
7713 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7714 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7715 on error. Return error code.
7716 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7717 (emacs_gnutls_read): Likewise.
7718 (Fgnutls_boot): Return handshake error code.
7719 (emacs_gnutls_handle_error): New function.
7720 (wsaerror_to_errno): Likewise.
7721
7722 * w32.h (emacs_gnutls_pull): Add prototype.
7723 (emacs_gnutls_push): Likewise.
7724
7725 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7726 (emacs_gnutls_push): Likewise.
7727
7728 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7729
7730 * process.c (wait_reading_process_output): Check if GnuTLS
7731 buffered some data internally if no FDs are set for TLS
7732 connections.
7733
7734 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7735 (LIBS): Link to USER_LIBS.
7736 ($(BLD)/gnutls.$(0)): New target.
7737
7738 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7739
7740 * xdisp.c (handle_single_display_spec): Rename the
7741 display_replaced_before_p argument into display_replaced_p, to
7742 make it consistent with the commentary. Fix typos in the
7743 commentary.
7744
7745 * textprop.c (syms_of_textprop): Remove dead code.
7746 (copy_text_properties): Delete obsolete commentary about an
7747 interface that was deleted long ago. Fix typos in the description
7748 of arguments.
7749
7750 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7751 to changes in oldXMenu/XMenu.h from 2011-04-16.
7752 <menu_help_message, prev_menu_help_message>: Constify.
7753 (IT_menu_make_room): menu->help_text is now `const char **';
7754 adjust.
7755
7756 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7757 to changes in oldXMenu/XMenu.h from 2011-04-16.
7758 (struct XMenu): Declare `help_text' `const char **'.
7759
7760 * xfaces.c <Qunspecified>: Make extern again.
7761
7762 * syntax.c: Include sys/types.h before including regex.h, as
7763 required by POSIX.
7764
7765 * doc.c (get_doc_string): Improve the format passed to `error'.
7766
7767 * doprnt.c (doprnt): Improve commentary.
7768
7769 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7770
7771 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7772 them with etags.
7773
7774 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7775 changes in globals.h immediately force recompilation.
7776 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7777 $(CURDIR)/s/ms-w32.h.
7778 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7779
7780 * character.c (Fchar_direction): Function deleted.
7781 (syms_of_character): Don't defsubr it.
7782 <char-direction-table>: Deleted.
7783
7784 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7785
7786 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7787 * doprnt.c: Include limits.h.
7788 (SIZE_MAX): New macro.
7789 (doprnt): Return a size_t value. 2nd arg is now size_t.
7790 Many local variables are now size_t instead of int or unsigned.
7791 Improve overflow protection. Support `l' modifier for integer
7792 conversions. Support %l conversion. Don't assume an EMACS_INT
7793 argument for integer conversions and for %c.
7794
7795 * lisp.h (doprnt): Restore prototype.
7796
7797 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7798 $(SRC)/character.h.
7799
7800 * Makefile.in (base_obj): Add back doprnt.o.
7801
7802 * deps.mk (doprnt.o): Add back prerequisites.
7803 (callint.o): Depend on character.h.
7804
7805 * eval.c (internal_lisp_condition_case): Include the handler
7806 representation in the error message.
7807 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7808 when breaking from the loop.
7809
7810 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7811
7812 * callint.c (Fcall_interactively): When displaying error message
7813 about invalid control letter, pass the character's codepoint, not
7814 a pointer to its multibyte form. Improve display of the character
7815 in octal and display also its hex code.
7816
7817 * character.c (char_string): Use %x to display the (unsigned)
7818 codepoint of an invalid character, to avoid displaying a bogus
7819 negative value.
7820
7821 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7822 `error', not SYMBOL_NAME itself.
7823
7824 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7825 character arguments to `error'.
7826
7827 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7828 to `error' in error message about FINAL_CHAR argument. Make sure
7829 FINAL_CHAR is a character, and use %c when it is passed as
7830 argument to `error'.
7831
7832 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7833
7834 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7835
7836 * w32.c: Include <time.h>.
7837 (sys_localtime): New function.
7838
7839 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7840
7841 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7842
7843 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7844
7845 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7846
7847 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7848 zombies (Bug#8467).
7849
7850 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7851
7852 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7853 gl_state.e_property when gl_state.object is Qt.
7854
7855 * insdel.c (make_gap_larger): Remove limitation of buffer size
7856 to <= INT_MAX.
7857
7858 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7859
7860 * xdisp.c (lookup_glyphless_char_display)
7861 (produce_glyphless_glyph): Handle cons cell entry in
7862 glyphless-char-display.
7863 (Vglyphless_char_display): Document it.
7864
7865 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7866 glyphless-char-display.
7867
7868 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7869
7870 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7871
7872 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7873
7874 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7875 definition for no-X builds.
7876
7877 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7878
7879 Static checks with GCC 4.6.0 and non-default toolkits.
7880
7881 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7882
7883 * process.c (keyboard_bit_set): Define only if SIGIO.
7884 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7885 (send_process): Repair possible setjmp clobbering.
7886
7887 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7888
7889 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7890
7891 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7892
7893 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7894 Define only if needed.
7895
7896 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7897 by pacifying GCC about it. Maybe it's time to retire it?
7898 * xfaces.c (USG, __TIMEVAL__): Likewise.
7899
7900 * dispextern.h (struct redisplay_interface): Rename param
7901 to avoid shadowing.
7902 * termhooks.h (struct terminal): Likewise.
7903 * xterm.c (xembed_send_message): Likewise.
7904
7905 * insdel.c (make_gap_smaller): Define only if
7906 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7907
7908 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7909 it.
7910
7911 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7912 so that we aren't warned about unused symbols.
7913
7914 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7915
7916 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7917
7918 * xfns.c (x_real_positions): Mark locals as initialized.
7919
7920 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7921
7922 * xterm.c: Fix problems found by static analysis with other toolkits.
7923 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7924 (x_dispatch_event): Declare static if USE_GTK, and
7925 define if USE_GTK || USE_X_TOOLKIT.
7926 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7927 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7928 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7929 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7930
7931 * xmenu.c (menu_help_callback): Pointer type fixes.
7932 Use const pointers when pointing at readonly data. Avoid pointer
7933 signedness clashes.
7934 (FALSE): Remove unused macro.
7935 (update_frame_menubar): Remove unused decl.
7936
7937 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7938
7939 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7940 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7941 (single_menu_item): Rename local to avoid shadowing.
7942
7943 * keyboard.c (make_lispy_event): Remove unused local var.
7944
7945 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7946 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7947
7948 * bitmaps: Change bitmaps from unsigned char back to the X11
7949 compatible char. Avoid the old compiler warnings about
7950 out-of-range initializers by using, for example, '\xab' rather
7951 than 0xab.
7952
7953 * xgselect.c (xgselect_initialize): Check vs interface
7954 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7955
7956 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7957
7958 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7959 to read-only memory.
7960
7961 * fns.c (vector): Remove; this old hack is no longer needed.
7962
7963 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7964 Remove unused var.
7965 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7966
7967 * xrdb.c (x_load_resources): Omit unused local.
7968
7969 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7970 (x_window): Rename locals to avoid shadowing.
7971 (USG): Use the kludged USG macro, to pacify gcc.
7972
7973 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7974 (x_term_init): Remove local to avoid shadowing.
7975
7976 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7977
7978 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7979 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7980
7981 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7982
7983 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7984
7985 Fix regex.c, syntax.c and friends for buffers > 2GB.
7986 * syntax.h (struct gl_state_s): Declare character position members
7987 EMACS_INT.
7988
7989 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7990
7991 * textprop.c (verify_interval_modification, interval_of):
7992 Declare arguments EMACS_INT.
7993
7994 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7995 EMACS_INT.
7996
7997 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7998
7999 * indent.c (Fvertical_motion): Local variable it_start is now
8000 EMACS_INT.
8001
8002 * regex.c (re_match, re_match_2, re_match_2_internal)
8003 (bcmp_translate, regcomp, regexec, print_double_string)
8004 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8005 (re_compile_pattern, re_exec): Declare arguments and local
8006 variables `size_t' and `ssize_t' and return values `regoff_t', as
8007 appropriate.
8008 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8009 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8010 <compile_stack_type>: `size' and `avail' are now `size_t'.
8011
8012 * regex.h <regoff_t>: Use ssize_t, not int.
8013 (re_search, re_search_2, re_match, re_match_2): Arguments that
8014 specify buffer/string position and length are now ssize_t and
8015 size_t. Return type is regoff_t.
8016
8017 2011-04-16 Ben Key <bkey76@gmail.com>
8018
8019 * nsfont.m: Fixed bugs in ns_get_family and
8020 ns_descriptor_to_entity that were caused by using free to
8021 deallocate memory blocks that were allocated by xmalloc (via
8022 xstrdup). This caused Emacs to crash when compiled with
8023 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8024 --enable-checking=xmallocoverrun). xfree is now used to
8025 deallocate these memory blocks.
8026
8027 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8028
8029 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8030
8031 emacs_write: Accept and return EMACS_INT for sizes.
8032 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8033 et seq.
8034 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8035 Accept and return EMACS_INT.
8036 (emacs_gnutls_write): Return the number of bytes written on
8037 partial writes.
8038 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8039 (emacs_read, emacs_write): Remove check for negative size, as the
8040 Emacs source code has been audited now.
8041 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8042 (emacs_read, emacs_write): Use it.
8043 * process.c (send_process): Adjust to the new signatures of
8044 emacs_write and emacs_gnutls_write. Do not attempt to store
8045 a byte offset into an 'int'; it might overflow.
8046 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8047
8048 * sound.c: Don't assume sizes fit in 'int'.
8049 (struct sound_device.period_size, alsa_period_size):
8050 Return EMACS_INT, not int.
8051 (struct sound_device.write, vox_write, alsa_write):
8052 Accept EMACS_INT, not int.
8053 (wav_play, au_play): Use EMACS_INT to store sizes and to
8054 record read return values.
8055
8056 2011-04-15 Ben Key <bkey76@gmail.com>
8057
8058 * keyboard.c (Qundefined): Don't declare static since it is used
8059 in nsfns.m.
8060 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8061 static since they are used in nsfont.m.
8062
8063 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8064
8065 * process.c (Qprocessp): Don't declare static.
8066 * lisp.h (Qprocessp): Declare again.
8067
8068 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8069
8070 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8071
8072 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8073
8074 Improve C-level modularity by making more things 'static'.
8075
8076 Don't publish debugger-only interfaces to other modules.
8077 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8078 (verify_bytepos, count_markers): Move decls to the only modules
8079 that need them.
8080 * region-cache.h (pp_cache): Likewise.
8081 * window.h (check_all_windows): Likewise.
8082 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8083
8084 * sysdep.c (croak): Now static, if
8085 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8086 * syssignal.h (croak): Declare only if not static.
8087
8088 * alloc.c (refill_memory_reserve): Now static if
8089 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8090 * lisp.h (refill_memory_reserve): Declare only if not static.
8091
8092 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8093 Define only if USE_LUCID.
8094
8095 * xrdb.c (x_customization_string, x_rm_string): Now static.
8096
8097 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8098 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8099
8100 * xdisp.c (draw_row_with_mouse_face): Now static.
8101 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8102
8103 * window.h (check_all_windows): Mark externally visible.
8104
8105 * window.c (window_deletion_count): Now static.
8106
8107 * undo.c: Make symbols static if they're not exported.
8108 (last_undo_buffer, last_boundary_position, pending_boundary):
8109 Now static.
8110
8111 * textprop.c (interval_insert_behind_hooks): Now static.
8112 (interval_insert_in_front_hooks): Likewise.
8113
8114 * term.c: Make symbols static if they're not exported.
8115 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8116 (max_frame_lines, tty_set_terminal_modes):
8117 (tty_reset_terminal_modes, tty_turn_off_highlight):
8118 (get_tty_terminal): Now static.
8119 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8120 * termhooks.h (term_mouse_moveto): Do not declare if
8121 HAVE_WINDOW_SYSTEM.
8122 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8123 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8124
8125 * sysdep.c: Make symbols static if they're not exported.
8126 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8127 Now static.
8128 (sigprocmask_set, full_mask): Remove; unused.
8129 (wait_debugging): Mark as visible.
8130 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8131 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8132
8133 * syntax.c (syntax_temp): Define only if !__GNUC__.
8134
8135 * sound.c (current_sound_device, current_sound): Now static.
8136
8137 * search.c (searchbufs, searchbuf_head): Now static.
8138
8139 * scroll.c (scroll_cost): Remove; unused.
8140 * dispextern.h (scroll_cost): Remove decl.
8141
8142 * region-cache.h (pp_cache): Mark as externally visible.
8143
8144 * process.c: Make symbols static if they're not exported.
8145 (process_tick, update_tick, create_process, chan_process):
8146 (Vprocess_alist, proc_buffered_char, datagram_access):
8147 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8148 (deactivate_process): Mark defn as static, as well as decl.
8149 * lisp.h (create_process): Remove decl.
8150 * process.h (chan_process, Vprocess_alist): Remove decls.
8151
8152 * print.c: Make symbols static if they're not exported.
8153 (print_depth, new_backquote_output, being_printed, print_buffer):
8154 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8155 (print_interval, print_number_index, initial_stderr_stream):
8156 Now static.
8157 * lisp.h (Fprinc): Remove decl.
8158 (debug_output_compilation_hack): Mark as externally visible.
8159
8160 * sysdep.c (croak): Move decl from here to syssignal.h.
8161 * syssignal.h (croak): Put it here, so the API can be checked when
8162 'croak' is called from dissociate_if_controlling_tty.
8163
8164 * minibuf.c: Make symbols static if they're not exported.
8165 (minibuf_save_list, choose_minibuf_frame): Now static.
8166 * lisp.h (choose_minibuf_frame): Remove decl.
8167
8168 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8169
8170 * lread.c: Make symbols static if they're not exported.
8171 (read_objects, initial_obarray, oblookup_last_bucket_number):
8172 Now static.
8173 (make_symbol): Remove; unused.
8174 * lisp.h (initial_obarray, make_symbol): Remove decls.
8175
8176 * keyboard.c: Make symbols static if they're not exported.
8177 (single_kboard, recent_keys_index, total_keys, recent_keys):
8178 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8179 (this_single_command_key_start, echoing, last_auto_save):
8180 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8181 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8182 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8183 (Vlispy_mouse_stem, double_click_count):
8184 Now static.
8185 (force_auto_save_soon): Define only if SIGDANGER.
8186 (ignore_mouse_drag_p): Now static if
8187 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8188 (print_help): Remove; unused.
8189 (stop_character, last_timer_event): Mark as externally visible.
8190 * keyboard.h (ignore_mouse_drag_p): Declare only if
8191 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8192 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8193 * lisp.h (echoing): Remove decl.
8194 (force_auto_save_soon): Declare only if SIGDANGER.
8195 * xdisp.c (redisplay_window): Simplify code, to make it more
8196 obvious that ignore_mouse_drag_p is not accessed if !defined
8197 USE_GTK && !defined HAVE_NS.
8198
8199 * intervals.c: Make symbols static if they're not exported.
8200 (merge_properties_sticky, merge_interval_right, delete_interval):
8201 Now static.
8202 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8203
8204 * insdel.c: Make symbols static if they're not exported.
8205 However, leave prepare_to_modify_buffer alone. It's never
8206 called from outside this function, but that appears to be a bug.
8207 (combine_after_change_list, combine_after_change_buffer):
8208 (adjust_after_replace, signal_before_change): Now static.
8209 (adjust_after_replace_noundo): Remove; unused.
8210 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8211 (signal_before_change): Remove decls.
8212
8213 * indent.c (val_compute_motion, val_vmotion): Now static.
8214
8215 * image.c: Make symbols static if they're not exported.
8216 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8217 if USE_GTK.
8218 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8219 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8220
8221 * fringe.c (standard_bitmaps): Now static.
8222 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8223
8224 * frame.c: Make symbols static if they're not exported.
8225 (x_report_frame_params, make_terminal_frame): Now static.
8226 (get_frame_param): Now static, unless HAVE_NS.
8227 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8228 (x_get_resource_string): Remove; not used.
8229 * frame.h (make_terminal_frame, x_report_frame_params):
8230 (x_get_resource_string); Remove decls.
8231 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8232 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8233
8234 * font.c, fontset.c: Make symbols static if they're not exported.
8235 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8236 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8237 * font.c (font_close_object): Now static.
8238 * font.h (font_close_object): Remove.
8239 * fontset.c (FONTSET_OBJLIST): Remove.
8240 (free_realized_fontset) #if-0 the body, which does nothing.
8241 (face_suitable_for_char_p): #if-0, as it's never called.
8242 * fontset.h (face_suitable_for_char_p): Remove decl.
8243 * xfaces.c (face_at_string_position):
8244 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8245 since 0 is always ASCII.
8246
8247 * fns.c (weak_hash_tables): Now static.
8248
8249 * fileio.c: Make symbols static if they're not exported.
8250 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8251 (Vwrite_region_annotation_buffers): Now static.
8252
8253 * eval.c: Make symbols static if they're not exported.
8254 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8255 * lisp.h (backtrace_list): Remove decl.
8256
8257 * emacs.c: Make symbols static if they're not exported.
8258 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8259 (fatal_error_code, fatal_error_signal_hook, standard_args):
8260 Now static.
8261 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8262 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8263 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8264 * lisp.h (fatal_error_signal_hook): Remove decl.
8265 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8266
8267 * editfns.c: Move a (normally-unused) function to its only use.
8268 * editfns.c, lisp.h (get_operating_system_release): Remove.
8269 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8270 worth the hassle of breaking this out.
8271
8272 * xterm.c: Make symbols static if they're not exported.
8273 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8274 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8275 (x_destroy_window, x_delete_display):
8276 Now static.
8277 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8278 (x_mouse_leave): Remove; unused.
8279 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8280 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8281 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8282 Remove decls.
8283 (x_mouse_leave): Declare only if WINDOWSNT.
8284 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8285 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8286 USE_X_TOOLKIT.
8287
8288 * ftxfont.c: Make symbols static if they're not exported.
8289 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8290 HAVE_FREETYPE.
8291 * font.h (ftxfont_driver): Likewise.
8292
8293 * xfns.c: Make symbols static if they're not exported.
8294 (x_last_font_name, x_display_info_for_name):
8295 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8296 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8297 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8298 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8299 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8300 (last_show_tip_args): Now static.
8301 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8302 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8303 (x_screen_planes): Remove; unused.
8304 * dispextern.h (x_screen_planes): Remove decl.
8305
8306 * dispnew.c: Make symbols static if they're not exported.
8307 * dispextern.h (redraw_garbaged_frames, scrolling):
8308 (increment_row_positions): Remove.
8309 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8310 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8311 Now static.
8312 (redraw_garbaged_frames): Remove; unused.
8313
8314 * xfaces.c: Make symbols static if they're not exported.
8315 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8316 Remove decls.
8317 * xterm.h (defined_color): Remove decls.
8318 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8319 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8320 (menu_face_changed_default, defined_color, free_realized_face):
8321 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8322 (ascii_face_of_lisp_face): Remove; unused.
8323
8324 * xdisp.c: Make symbols static if they're not exported.
8325 * dispextern.h (scratch_glyph_row, window_box_edges):
8326 (glyph_to_pixel_coords, set_cursor_from_row):
8327 (get_next_display_element, set_iterator_to_next):
8328 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8329 (show_mouse_face): Remove decls
8330 * frame.h (message_buf_print): Likewise.
8331 * lisp.h (pop_message, set_message, check_point_in_composition):
8332 Likewise.
8333 * xterm.h (set_vertical_scroll_bar): Likewise.
8334 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8335 (message_buf_print, scratch_glyph_row, displayed_buffer):
8336 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8337 (get_next_display_element, show_mouse_face, window_box_edges):
8338 (frame_to_window_pixel_xy, check_point_in_composition):
8339 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8340 (glyph_to_pixel_coords): Remove; unused.
8341
8342 * dired.c (file_name_completion): Now static.
8343
8344 * dbusbind.c (xd_in_read_queued_messages): Now static.
8345
8346 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8347 * data.c (circular_list_error): Remove.
8348
8349 * commands.h (last_point_position, last_point_position_buffer):
8350 (last_point_position_window): Remove decls.
8351 * keyboard.c: Make these variables static.
8352
8353 * coding.h (coding, code_convert_region, encode_coding_gap):
8354 Remove decls.
8355 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8356 (iso_code_class, detect_coding, code_convert_region): Now static.
8357 (encode_coding_gap): Remove; unused.
8358
8359 * chartab.c (chartab_chars, chartab_bits): Now static.
8360
8361 * charset.h (charset_iso_8859_1): Remove decl.
8362 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8363 Now static.
8364
8365 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8366 * ccl.c (Vccl_program_table): Now static.
8367 (check_ccl_update): Remove; unused.
8368
8369 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8370 * category.h: ... from here.
8371 * category.c (check_category_table, set_category_set): Now static.
8372
8373 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8374 * lisp.h: Remove these decls.
8375
8376 * buffer.c (buffer_count): Remove unused var.
8377
8378 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8379 so that it's not optimized away.
8380 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8381 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8382 exported only to the debugger.
8383
8384 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8385 * atimer.h (run_all_atimers): Remove; not exported.
8386
8387 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8388 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8389 was inaccessible from Lisp.
8390 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8391 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8392
8393 alloc.c: Import and export fewer symbols, and remove unused items.
8394 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8395 is defined.
8396 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8397 it's not optimized away by whole-program optimization.
8398 (message_enable_multibyte, free_misc): Remove.
8399 (catchlist, handlerlist, mark_backtrace):
8400 Declare only if BYTE_MARK_STACK.
8401 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8402 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8403 (message_enable_multibyte): Remove decl.
8404 (free_misc, interval_free_list, float_block, float_block_index):
8405 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8406 (cons_free_list, last_marked_index):
8407 Now static.
8408 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8409 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8410 (mark_backtrace): Define only if BYTE_MARK_STACK.
8411 * xdisp.c (message_enable_multibyte): Now static.
8412
8413 Declare Lisp_Object Q* variables to be 'static' if not exported.
8414 This makes it easier for human readers (and static analyzers)
8415 to see whether these variables are used from other modules.
8416 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8417 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8418 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8419 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8420 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8421 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8422 * xmenu.c, xselect.c:
8423 Declare Q* vars static if they are not used in other modules.
8424 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8425 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8426 Remove decls of unexported vars.
8427 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8428
8429 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8430
8431 Make Emacs functions such as Fatom 'static' by default.
8432 This makes it easier for human readers (and static analyzers)
8433 to see whether these functions can be called from other modules.
8434 DEFUN now defines a static function. To make the function external
8435 so that it can be used in other C modules, use the new macro DEFUE.
8436 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8437 (Finit_image_library):
8438 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8439 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8440 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8441 Remove decls, since these functions are now static.
8442 (Funintern, Fget_internal_run_time): New decls, since these functions
8443 were already external.
8444
8445 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8446 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8447 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8448 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8449 * keyboard.c, keymap.c, lread.c:
8450 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8451 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8452 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8453 Mark functions with DEFUE instead of DEFUN,
8454 if they are used in other modules.
8455 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8456 decls for now-static functions.
8457 * buffer.h (Fdelete_overlay): Remove decl.
8458 * callproc.c (Fgetenv_internal): Mark as internal.
8459 * composite.c (Fremove_list_of_text_properties): Remove decl.
8460 (Fcomposition_get_gstring): New forward static decl.
8461 * composite.h (Fcomposite_get_gstring): Remove decl.
8462 * dired.c (Ffile_attributes): New forward static decl.
8463 * doc.c (Fdocumntation_property): New forward static decl.
8464 * eval.c (Ffetch_bytecode): New forward static decl.
8465 (Funintern): Remove extern decl; now in .h file where it belongs.
8466 * fileio.c (Fmake_symbolic_link): New forward static decl.
8467 * image.c (Finit_image_library): New forward static decl.
8468 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8469 * intervals.h (Fprevious_property_change):
8470 (Fremove_list_of_text_properties): Remove decls.
8471 * keyboard.c (Fthis_command_keys): Remove decl.
8472 (Fcommand_execute): New forward static decl.
8473 * keymap.c (Flookup_key): New forward static decl.
8474 (Fcopy_keymap): Now static.
8475 * keymap.h (Flookup_key): Remove decl.
8476 * process.c (Fget_process): New forward static decl.
8477 (Fprocess_datagram_address): Mark as internal.
8478 * syntax.c (Fsyntax_table_p): New forward static decl.
8479 (skip_chars): Remove duplicate decl.
8480 * textprop.c (Fprevious_property_change): New forward static decl.
8481 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8482 Now internal.
8483 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8484 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8485
8486 * editfns.c (Fformat): Remove unreachable code.
8487
8488 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8489
8490 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8491 change. (Bug#8496)
8492
8493 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8494
8495 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8496 when at ZV. (Bug#8487)
8497
8498 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8499
8500 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8501 (Bug#8437)
8502 * keyboard.c (parse_tool_bar_item): Likewise.
8503 * sound.c (sound_cleanup, alsa_close): Likewise.
8504 * termcap.c (tgetent): Likewise.
8505 * xfns.c (x_default_font_parameter): Likewise.
8506 * xsettings.c (read_and_apply_settings): Likewise.
8507
8508 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8509 (overrun_check_free): Protoize.
8510
8511 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8512
8513 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8514 since callers should never pass a negative size.
8515 Change the signature to match that of plain 'read' and 'write'; see
8516 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8517 * lisp.h: Update prototypes of emacs_write and emacs_read.
8518
8519 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8520
8521 * xdisp.c (redisplay_window): Don't try to determine the character
8522 position of the scroll margin if the window start point w->startp
8523 is outside the buffer's accessible region. (Bug#8468)
8524
8525 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8526
8527 Fix write-region and its subroutines for buffers > 2GB.
8528 * fileio.c (a_write, e_write): Modify declaration of arguments and
8529 local variables to support buffers larger than 2GB.
8530 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8531
8532 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8533 argument, local variables, and return value.
8534
8535 * lisp.h: Update prototypes of emacs_write and emacs_read.
8536
8537 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8538
8539 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8540
8541 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8542
8543 Fix more problems found by GCC 4.6.0's static checks.
8544
8545 * xdisp.c (vmessage): Use a better test for character truncation.
8546
8547 * charset.c (load_charset_map): <, not <=, for optimization,
8548 and to avoid potential problems with integer overflow.
8549 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8550 * casetab.c (set_identity, shuffle): Likewise.
8551 * editfns.c (Fformat): Likewise.
8552 * syntax.c (skip_chars): Likewise.
8553
8554 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8555 This also lets GCC 4.6.0 generate slightly better loop code.
8556
8557 * callint.c (Fcall_interactively): <, not <=, for optimization.
8558 (Fcall_interactively): Count the number of arguments produced,
8559 not the number of arguments given. This is simpler and lets GCC
8560 4.6.0 generate slightly better code.
8561
8562 * ftfont.c: Distingish more carefully between FcChar8 and char.
8563 The previous code passed unsigned char * to a functions like
8564 strlen and xstrcasecmp that expect char *, which does not
8565 conform to the C standard.
8566 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8567 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8568 char * when the C standard requires it.
8569
8570 * keyboard.c (read_char): Remove unused var.
8571
8572 * eval.c: Port to Windows vsnprintf (Bug#8435).
8573 Include <limits.h>.
8574 (SIZE_MAX): Define if the headers do not.
8575 (verror): Do not give up if vsnprintf returns a negative count.
8576 Instead, grow the buffer. This ports to Windows vsnprintf, which
8577 does not conform to C99. Problem reported by Eli Zaretskii.
8578 Also, simplify the allocation scheme, by avoiding the need for
8579 calling realloc, and removing the ALLOCATED variable.
8580
8581 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8582
8583 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8584 But keep the doprint source code for now, as we might revamp it
8585 and use it again (Bug#8435).
8586 * lisp.h (doprnt): Remove.
8587 * Makefile.in (base_obj): Remove doprnt.o.
8588 * deps.mk (doprnt.o): Remove.
8589
8590 error: Print 32- and 64-bit integers portably (Bug#8435).
8591 Without this change, on typical 64-bit hosts error ("...%d...", N)
8592 was used to print both 32- and 64-bit integers N, which relied on
8593 undefined behavior.
8594 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8595 * lisp.h (error, verror): Mark as printf-like functions.
8596 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8597 Report overflow in size calculations when allocating printf buffer.
8598 Do not truncate output string at its first null byte.
8599 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8600 Truncate the output at a character boundary, since vsnprintf does not
8601 do that.
8602 * charset.c (check_iso_charset_parameter): Convert internal
8603 character to string before calling 'error', since %c now has the
8604 printf meaning.
8605 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8606 overflow when computing char to be passed to 'error'. Do not
8607 pass Lisp_Object to 'error'; pass the integer instead.
8608 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8609 formatted with plain %d.
8610
8611 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8612
8613 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8614
8615 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8616
8617 * xterm.c (x_catch_errors): Remove duplicate declaration.
8618
8619 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8620
8621 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8622
8623 2011-04-10 Jim Meyering <meyering@redhat.com>
8624
8625 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8626 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8627 return ssize_t not "int", and use size_t as the buffer length.
8628 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8629 * gnutls.h: Update declarations.
8630 * process.c (read_process_output): Use ssize_t, to match.
8631 (send_process): Likewise.
8632
8633 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8634
8635 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8636
8637 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8638
8639 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8640 Use unsigned char, to match FcChar8 type definition.
8641
8642 * xterm.c (handle_one_xevent):
8643 * xmenu.c (create_and_show_popup_menu):
8644 * xselect.c (x_decline_selection_request)
8645 (x_reply_selection_request): Avoid type-punned deref of X events.
8646
8647 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8648
8649 Fix some uses of `int' instead of EMACS_INT.
8650 * search.c (string_match_1, fast_string_match)
8651 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8652 (scan_buffer, find_next_newline_no_quit)
8653 (find_before_next_newline, search_command, Freplace_match)
8654 (Fmatch_data): Make some `int' variables be EMACS_INT.
8655
8656 * xdisp.c (display_count_lines): 3rd argument and return value now
8657 EMACS_INT. All callers changed.
8658 (pint2hrstr): Last argument is now EMACS_INT.
8659
8660 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8661 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8662 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8663 (decode_coding_utf_16, decode_coding_emacs_mule)
8664 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8665 (decode_coding_ccl, decode_coding_charset)
8666 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8667 (decode_coding_iso_2022, decode_coding_emacs_mule)
8668 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8669 <char_offset, last_offset>: Declare EMACS_INT.
8670 (encode_coding_utf_8, encode_coding_utf_16)
8671 (encode_coding_emacs_mule, encode_invocation_designation)
8672 (encode_designation_at_bol, encode_coding_iso_2022)
8673 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8674 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8675 Declare EMACS_INT.
8676 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8677 (encode_invocation_designation): Last argument P_NCHARS is now
8678 EMACS_INT.
8679 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8680 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8681
8682 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8683 All users changed.
8684
8685 * ccl.c (Fccl_execute_on_string): Declare some variables
8686 EMACS_INT.
8687
8688 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8689
8690 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8691
8692 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8693
8694 * process.c (Fformat_network_address): Doc fix.
8695
8696 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8697
8698 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8699
8700 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8701
8702 * keyboard.c (read_char): Call Lisp function help-form-show,
8703 instead of using internal_with_output_to_temp_buffer.
8704 (Qhelp_form_show): New var.
8705 (syms_of_keyboard): Use DEFSYM macro.
8706
8707 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8708
8709 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8710
8711 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8712
8713 * process.c (Flist_processes): Remove to Lisp.
8714 (list_processes_1): Delete.
8715
8716 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8717
8718 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8719
8720 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8721
8722 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8723
8724 Fix more problems found by GCC 4.6.0's static checks.
8725
8726 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8727
8728 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8729
8730 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8731
8732 * xdisp.c (vmessage): Mark as a printf-like function.
8733
8734 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8735
8736 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8737
8738 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8739 printf-like functions.
8740 (tiff_load): Add casts to remove these marks before passing them
8741 to system-supplied API.
8742
8743 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8744
8745 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8746 This avoids several warnings with gcc -Wstrict-overflow.
8747 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8748 directly, rather than having caller test rule sign. This avoids
8749 some unnecessary tests.
8750 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8751 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8752 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8753
8754 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8755 (xfont_open): Avoid unnecessary tests.
8756
8757 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8758
8759 * composite.h, composite.c (composition_gstring_put_cache):
8760 Use EMACS_INT, not int, for length.
8761
8762 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8763 breaking out part of COMPOSITION_DECODE_RULE.
8764 (COMPOSITION_DECODE_RULE): Use it.
8765 * composite.c (get_composition_id): Remove unused local vars,
8766 by using the new macro.
8767
8768 * textprop.c (set_text_properties_1): Change while to do-while,
8769 since the condition is always true at first.
8770
8771 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8772 (interval_deletion_adjustment): Return unsigned value.
8773 All uses changed.
8774
8775 * process.c (list_processes_1, create_pty, read_process_output):
8776 (exec_sentinel): Remove vars that were set but not used.
8777 (create_pty): Remove unnecessary "volatile"s.
8778 (Fnetwork_interface_info): Avoid possibility of int overflow.
8779 (read_process_output): Do adaptive read buffering even if carryover.
8780 (read_process_output): Simplify nbytes computation if buffered.
8781
8782 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8783
8784 * syntax.c (scan_words): Remove var that was set but not used.
8785 (update_syntax_table): Use unsigned instead of int.
8786
8787 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8788 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8789 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8790
8791 * print.c (print_error_message): Avoid int overflow.
8792
8793 * font.c (font_list_entities): Redo for clarity,
8794 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8795
8796 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8797 (font_score): Avoid potential overflow in diff calculation.
8798
8799 * fns.c (substring_both): Remove var that is set but not used.
8800 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8801
8802 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8803
8804 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8805 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8806 can always succeed if overflow has undefined behavior.
8807
8808 * search.c (boyer_moore, wordify): Remove vars set but not used.
8809 (wordify): Omit three unnecessary tests.
8810
8811 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8812 All callers changed. This avoids the need for an unused var.
8813
8814 * casefiddle.c (casify_region): Remove var that is set but not used.
8815
8816 * dired.c (file_name_completion): Remove var that is set but not used.
8817
8818 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8819
8820 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8821 (Finsert_file_contents): Remove unnecessary code checking fd.
8822
8823 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8824 Check for integer overflow on size calculations.
8825
8826 * buffer.c (Fprevious_overlay_change): Remove var that is set
8827 but not used.
8828
8829 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8830 Remove vars that are set but not used.
8831 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8832 (timer_check_2): Mark vars as initialized.
8833
8834 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8835
8836 * image.c (lookup_image): Remove var that is set but not used.
8837 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8838
8839 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8840 that are set but not used.
8841
8842 * xfns.c (make_invisible_cursor): Don't return garbage
8843 if XCreateBitmapFromData fails (Bug#8410).
8844
8845 * xselect.c (x_get_local_selection, x_handle_property_notify):
8846 Remove vars that are set but not used.
8847
8848 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8849 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8850
8851 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8852 Remove var that is set but not used.
8853 (scroll_bar_windows_size): Now size_t, not int.
8854 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8855 Check for overflow.
8856
8857 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8858 (map_tty_color) [!defined MSDOS]: Likewise.
8859
8860 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8861
8862 * coding.c: Remove vars that are set but not used.
8863 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8864 All callers changed.
8865 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8866 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8867 (decode_coding_charset): Remove vars that are set but not used.
8868
8869 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8870 that is set but not used.
8871
8872 * print.c (print_object): Remove var that is set but not used.
8873
8874 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8875 The gnulib version avoids calling malloc in the usual case,
8876 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8877 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8878 * filelock.c (current_lock_owner): Likewise.
8879 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8880 * sysdep.c: Include allocator.h, careadlinkat.h.
8881 (emacs_no_realloc_allocator): New static constant.
8882 (emacs_readlink): New function.
8883 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8884 ../lib/careadlinkat.h.
8885
8886 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8887
8888 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8889 first non-nil return value).
8890
8891 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8892
8893 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8894 if not defined (Bug#8403).
8895
8896 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8897
8898 * xdisp.c (display_count_lines): Remove parameter `start',
8899 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8900 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8901 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8902 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8903 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8904 and thereabouts. All callers changed.
8905 (get_per_char_metric): Remove parameter `f', unused since
8906 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8907
8908 2011-04-02 Jim Meyering <meyering@redhat.com>
8909
8910 do not dereference NULL upon failed strdup
8911 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8912 (ns_get_family): Likewise.
8913
8914 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8915
8916 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8917
8918 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8919
8920 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8921 later (Bug#8403).
8922
8923 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8924
8925 Add lexical binding.
8926
8927 * window.c (Ftemp_output_buffer_show): New fun.
8928 (Fsave_window_excursion):
8929 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8930
8931 * lread.c (lisp_file_lexically_bound_p): New function.
8932 (Fload): Bind Qlexical_binding.
8933 (readevalloop): Remove `evalfun' arg.
8934 Bind Qinternal_interpreter_environment.
8935 (Feval_buffer): Bind Qlexical_binding.
8936 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8937 Mark as dynamic.
8938 (syms_of_lread): Declare `lexical-binding'.
8939
8940 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8941
8942 * keyboard.c (eval_dyn): New fun.
8943 (menu_item_eval_property): Use it.
8944
8945 * image.c (parse_image_spec): Use Ffunctionp.
8946
8947 * fns.c (concat, mapcar1): Accept byte-code-functions.
8948
8949 * eval.c (Fsetq): Handle lexical vars.
8950 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8951 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8952 (FletX, Flet): Obey lexical binding.
8953 (Fcommandp): Handle closures.
8954 (Feval): New `lexical' arg.
8955 (eval_sub): New function extracted from Feval. Use it almost
8956 everywhere where Feval was used. Look up vars in lexical env.
8957 Handle closures.
8958 (Ffunctionp): Move from subr.el.
8959 (Ffuncall): Handle closures.
8960 (apply_lambda): Remove `eval_flags'.
8961 (funcall_lambda): Handle closures and new byte-code-functions.
8962 (Fspecial_variable_p): New function.
8963 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8964 but without exporting it to Lisp.
8965
8966 * doc.c (Fdocumentation, store_function_docstring):
8967 * data.c (Finteractive_form): Handle closures.
8968
8969 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8970 interactive spec.
8971
8972 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8973 New byte-codes.
8974 (exec_byte_code): New function extracted from Fbyte_code to handle new
8975 calling convention for byte-code-functions. Add new byte-codes.
8976
8977 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8978
8979 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8980
8981 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8982
8983 * xdisp.c (redisplay_internal): Fix prototype.
8984
8985 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8986
8987 * xdisp.c (SCROLL_LIMIT): New macro.
8988 (try_scrolling): Use it when setting scroll_limit.
8989 Limit scrolling to 100 screen lines.
8990 (redisplay_window): Even when falling back on "recentering",
8991 position point in the window according to scroll-conservatively,
8992 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8993
8994 (try_scrolling): When point is above the window, allow searching
8995 as far as scroll_max, or one screenful, to compute vertical
8996 distance from PT to the scroll margin position. This prevents
8997 try_scrolling from unnecessarily failing when
8998 scroll-conservatively is set to a value slightly larger than the
8999 window height. Clean up the case of PT below the margin at bottom
9000 of window: scroll_max can no longer be INT_MAX. When aggressive
9001 scrolling is in use, don't let point enter the opposite scroll
9002 margin as result of the scroll.
9003 (syms_of_xdisp) <scroll-conservatively>: Document the
9004 threshold of 100 lines for never-recentering scrolling.
9005
9006 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9007
9008 * dispextern.h (move_it_by_lines):
9009 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9010 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9011 (message_log_check_duplicate): Remove parameters `prev_bol' and
9012 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9013 (redisplay_internal): Remove parameter `preserve_echo_area',
9014 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9015
9016 * indent.c (Fvertical_motion):
9017 * window.c (window_scroll_pixel_based, Frecenter):
9018 Don't pass `need_y_p' to `move_it_by_lines'.
9019
9020 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9021
9022 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9023 steal a few bits to be more compact.
9024 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9025 Remove unneeded casts.
9026
9027 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9028
9029 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9030
9031 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9032 binding" message (bug#7967).
9033
9034 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9035
9036 Fix more problems found by GCC 4.6.0's static checks.
9037
9038 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9039 Remove unused local var.
9040
9041 * editfns.c (Fmessage_box): Remove unused local var.
9042
9043 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9044 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9045 Omit unused local vars.
9046 * window.c (shrink_windows): Omit unused local var.
9047 * menu.c (digest_single_submenu): Omit unused local var.
9048 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9049 Omit unused local var.
9050
9051 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9052 Don't assume string length fits in int.
9053 (keyremap_step, read_key_sequence): Use size_t for sizes.
9054 (read_key_sequence): Don't check last_real_key_start redundantly.
9055
9056 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9057 instead of alloca (Bug#8344).
9058
9059 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9060 (Fbacktrace_frame): Don't assume nframes fits in int.
9061
9062 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9063
9064 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9065 concerns.
9066
9067 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9068
9069 * cm.c (calccost): Turn while-do into do-while, for clarity.
9070
9071 * keyboard.c (syms_of_keyboard): Use the same style as later
9072 in this function when indexing through an array. This also
9073 works around GCC bug 48267.
9074
9075 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9076
9077 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9078
9079 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9080 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9081
9082 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9083 This avoids undefined behavior on integer overflow, and is a bit
9084 more convenient anyway since it is compared to a size_t variable.
9085
9086 Variadic C functions now count arguments with size_t, not int.
9087 This avoids an unnecessary limitation on 64-bit machines, which
9088 caused (substring ...) to crash on large vectors (Bug#8344).
9089 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9090 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9091 All variadic functions and their callers changed accordingly.
9092 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9093 * data.c (arith_driver, float_arith_driver): Likewise.
9094 * editfns.c (general_insert_function): Likewise.
9095 * eval.c (struct backtrace.nargs, interactive_p)
9096 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9097 (funcall_lambda, mark_backtrace): Likewise.
9098 * fns.c (concat): Likewise.
9099 * frame.c (x_set_frame_parameters): Likewise.
9100 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9101 0 if not found, not -1. All callers changed.
9102
9103 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9104 (stack_copy_size): Now size_t, not int.
9105 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9106
9107 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9108
9109 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9110 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9111 All callers changed.
9112
9113 * lisp.h (multibyte_char_to_unibyte):
9114 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9115 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9116 * character.h (CHAR_TO_BYTE8):
9117 * cmds.c (internal_self_insert):
9118 * editfns.c (general_insert_function):
9119 * keymap.c (push_key_description):
9120 * search.c (Freplace_match):
9121 * xdisp.c (message_dolog, set_message_1): All callers changed.
9122
9123 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9124
9125 * keyboard.c (safe_run_hook_funcall): New function.
9126 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9127 don't set the hook to nil, but remove the offending function instead.
9128 (Qcommand_hook_internal): Remove, unused.
9129 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9130 Vcommand_hook_internal.
9131
9132 * eval.c (enum run_hooks_condition): Remove.
9133 (funcall_nil, funcall_not): New functions.
9134 (run_hook_with_args): Call each function through a `funcall' argument.
9135 Remove `cond' argument, now redundant.
9136 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9137 (Frun_hook_with_args_until_failure): Adjust accordingly.
9138 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9139
9140 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * dispextern.h (string_buffer_position): Remove declaration.
9143
9144 * print.c (strout): Remove parameter `multibyte', unused since
9145 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9146
9147 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9148 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9149 All callers changed.
9150
9151 * w32.c (_wsa_errlist): Use braces for struct initializers.
9152
9153 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9154 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9155 All callers changed.
9156 (string_buffer_position): Likewise. Also, make static (it's never
9157 used outside xdisp.c).
9158 (cursor_row_p): Remove parameter `w', unused since
9159 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9160 (decode_mode_spec): Remove parameter `precision', introduced during
9161 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9162 All callers changed.
9163
9164 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9165
9166 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9167
9168 2011-03-27 Anders Lindgren <andlind@gmail.com>
9169
9170 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9171 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9172 (ns_update_auto_hide_menu_bar): New functions.
9173 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9174 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9175 ns_constrain_all_frames.
9176 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9177 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9178
9179 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9180
9181 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9182
9183 2011-03-27 Glenn Morris <rgm@gnu.org>
9184
9185 * syssignal.h: Replace RETSIGTYPE with void.
9186 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9187 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9188 Replace SIGTYPE with void everywhere.
9189 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9190 * s/template.h (SIGTYPE): Remove commented out definition.
9191
9192 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9193
9194 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9195 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9196
9197 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9198
9199 * w32.c (read_unc_volume): Use parameter `henum', instead of
9200 global variable `wget_enum_handle'.
9201
9202 * keymap.c (describe_vector): Remove parameters `indices' and
9203 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9204 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9205
9206 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9207
9208 * keyboard.c (timer_check): Remove parameter `do_it_now',
9209 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9210 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9211 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9212
9213 * keyboard.c (read_char):
9214 * w32menu.c (w32_menu_display_help):
9215 * xmenu.c (show_help_event, menu_help_callback):
9216 Adjust calls to `show_help_echo'.
9217
9218 * gtkutil.c (xg_maybe_add_timer):
9219 * keyboard.c (readable_events):
9220 * process.c (wait_reading_process_output):
9221 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9222
9223 * insdel.c (adjust_markers_gap_motion):
9224 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9225 (gap_left, gap_right): Don't call it.
9226
9227 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9228
9229 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9230 incurred during fontification.
9231
9232 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9233
9234 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9235 (DEFVAR_PER_BUFFER): Don't pass it.
9236
9237 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9238 (scrolling_window): Don't pass it.
9239
9240 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9241
9242 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9243
9244 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9245 and `suffix'.
9246 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9247 of variables specific to SELinux and computation of `encoded_absname'.
9248
9249 * image.c (XPutPixel): Remove unused variable `height'.
9250
9251 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9252
9253 * unexw32.c (get_section_info): Remove unused variable `section'.
9254
9255 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9256 (system_process_attributes): Remove unused variable `sess'.
9257 (sys_read): Remove unused variable `err'.
9258
9259 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9260 (w32_wnd_proc): Remove unused variable `isdead'.
9261 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9262 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9263 (x_create_tip_frame): Remove unused variable `tem'.
9264
9265 * w32inevt.c (w32_console_read_socket):
9266 Remove unused variable `no_events'.
9267
9268 * w32term.c (x_draw_composite_glyph_string_foreground):
9269 Remove unused variable `width'.
9270
9271 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9272
9273 * w32term.c (x_set_glyph_string_clipping):
9274 Don't pass uninitialized region to CombineRgn.
9275
9276 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9277
9278 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9279 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9280 (Fx_close_connection): Remove unused variable `i'.
9281
9282 * w32font.c (w32font_draw): Return number of glyphs.
9283 (w32font_open_internal): Remove unused variable `i'.
9284 (w32font_driver): Add missing initializer.
9285
9286 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9287 (fill_in_menu): Remove unused variable `items_added'.
9288
9289 * w32term.c (last_mouse_press_frame): Remove static global variable.
9290 (w32_clip_to_row): Remove unused variable `f'.
9291 (x_delete_terminal): Remove unused variable `i'.
9292
9293 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9294 (NOTHING): Remove unused static global variable.
9295 (uniscribe_check_otf): Remove unused variable `table'.
9296 (uniscribe_font_driver): Add missing initializers.
9297
9298 2011-03-23 Julien Danjou <julien@danjou.info>
9299
9300 * term.c (Fsuspend_tty, Fresume_tty):
9301 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9302 * window.c (temp_output_buffer_show):
9303 * insdel.c (signal_before_change):
9304 * frame.c (Fhandle_switch_frame):
9305 * fileio.c (Fdo_auto_save):
9306 * emacs.c (Fkill_emacs):
9307 * editfns.c (save_excursion_restore):
9308 * cmds.c (internal_self_insert):
9309 * callint.c (Fcall_interactively):
9310 * buffer.c (Fkill_all_local_variables):
9311 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9312 Use Frun_hooks.
9313 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9314 unconditionally since it does the check itself.
9315
9316 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9317
9318 Fix more problems found by GCC 4.5.2's static checks.
9319
9320 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9321 the first time through the loop, since we know p0 < p1 then.
9322 This also avoids a gcc -Wstrict-overflow warning.
9323
9324 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9325 leading to a memory leak, possible in functions like
9326 load_charset_map_from_file that can allocate an unbounded number
9327 of objects (Bug#8318).
9328
9329 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9330 that could (at least in theory) be that large.
9331
9332 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9333 This is less likely to overflow, and avoids undefined behavior if
9334 overflow does occur. All callers changed. Use strtoul to scan
9335 for the unsigned long integer.
9336 (pint2hrstr): Simplify and tune code slightly.
9337 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9338
9339 * scroll.c (do_scrolling): Work around GCC bug 48228.
9340 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9341
9342 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9343 This also avoids a warning with gcc -Wstrict-overflow.
9344 (validate_x_resource_name): Simplify count usage.
9345 This also avoids a warning with gcc -Wstrict-overflow.
9346
9347 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9348 fail (Bug#8306).
9349
9350 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9351
9352 * process.c (Fmake_network_process): Use socklen_t, not int,
9353 where POSIX says socklen_t is required in portable programs.
9354 This fixes a porting bug on hosts like 64-bit HP-UX, where
9355 socklen_t is wider than int (Bug#8277).
9356 (Fmake_network_process, server_accept_connection):
9357 (wait_reading_process_output, read_process_output):
9358 Likewise.
9359
9360 * process.c: Rename or move locals to avoid shadowing.
9361 (list_processes_1, Fmake_network_process):
9362 (read_process_output_error_handler, exec_sentinel_error_handler):
9363 Rename or move locals.
9364 (Fmake_network_process): Define label "retry_connect" only if needed.
9365 (Fnetwork_interface_info): Fix pointer signedness.
9366 (process_send_signal): Add cast to avoid pointer signedness problem.
9367 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9368 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9369
9370 Make tparam.h and terminfo.c consistent.
9371 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9372 Include tparam.h instead, since it declares them.
9373 * cm.h (PC): Remove extern decl; tparam.h now does this.
9374 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9375 * terminfo.c: Include tparam.h, to check interfaces.
9376 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9377 (tparam): Adjust signature to match interface in tparam.h;
9378 this removes some undefined behavior. Check that outstring and len
9379 are zero, which they always are with Emacs.
9380 * tparam.h (PC, BC, UP): New extern decls.
9381
9382 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9383 (xftfont_open): Rename locals to avoid shadowing.
9384
9385 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9386 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9387 (OTF_TAG_SYM): Omit macro if not needed.
9388 (ftfont_list): Remove unused local.
9389 (get_adstyle_property, ftfont_pattern_entity):
9390 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9391 Rename locals to avoid shadowing.
9392
9393 * xfont.c (xfont_list_family): Mark var as initialized.
9394
9395 * xml.c (make_dom): Now static.
9396
9397 * composite.c (composition_compute_stop_pos): Rename local to
9398 avoid shadowing.
9399 (composition_reseat_it): Remove unused locals.
9400 (find_automatic_composition, composition_adjust_point): Likewise.
9401 (composition_update_it): Mark var as initialized.
9402 (find_automatic_composition): Mark vars as initialized,
9403 with a FIXME (Bug#8290).
9404
9405 character.h: Rename locals to avoid shadowing.
9406 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9407 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9408 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9409 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9410 to avoid shadowing.
9411
9412 * textprop.c (property_change_between_p): Remove; unused.
9413
9414 * intervals.c (interval_start_pos): Now static.
9415
9416 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9417
9418 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9419 Rename locals to avoid shadowing.
9420
9421 * sound.c (wav_play, au_play, Fplay_sound_internal):
9422 Fix pointer signedness.
9423 (alsa_choose_format): Remove unused local var.
9424 (wav_play): Initialize a variable to 0, to prevent undefined
9425 behavior (Bug#8278).
9426
9427 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9428
9429 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9430
9431 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9432 clobbering (Bug#8298).
9433 * sysdep.c (sys_subshell): Likewise.
9434 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9435
9436 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9437 This should get cleaned up, so that child_setup has the
9438 same signature on all platforms.
9439
9440 * callproc.c (call_process_cleanup): Now static.
9441 (relocate_fd): Rename locals to avoid shadowing.
9442
9443 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9444
9445 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9446 not to be necessary, and produces flickering.
9447
9448 2011-03-20 Glenn Morris <rgm@gnu.org>
9449
9450 * config.in: Remove file.
9451
9452 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9455 are now in src/globals.h.
9456 (syms_of_minibuf): Remove spurious & from previous change.
9457
9458 2011-03-20 Leo Liu <sdl.web@gmail.com>
9459
9460 * minibuf.c (completing-read-function): New variable.
9461 (completing-read-default): Rename from completing-read.
9462 (completing-read): Call completing-read-function.
9463
9464 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9465
9466 * xfaces.c (Fx_load_color_file):
9467 Read color file from absolute filename (bug#8250).
9468
9469 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9470
9471 * makefile.w32-in: Update dependencies.
9472
9473 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9474
9475 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9476
9477 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9478
9479 Fix more problems found by GCC 4.5.2's static checks.
9480
9481 * process.c (make_serial_process_unwind, send_process_trap):
9482 (sigchld_handler): Now static.
9483
9484 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9485 That way, the code declares only the vars that it needs.
9486 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9487 * s/cygwin.h (PTY_ITERATION): Likewise.
9488 * s/darwin.h (PTY_ITERATION): Likewise.
9489 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9490
9491 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9492 * process.c (allocate_pty): Don't declare stb unless it's needed.
9493
9494 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9495 (CONSTANTLIM): Remove; unused.
9496 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9497 Define only if needed.
9498
9499 * unexelf.c (unexec): Name an expression,
9500 to avoid gcc -Wbad-function-cast warning.
9501 Use a different way to cause a compilation error if anyone uses
9502 n rather than nn, a way that does not involve shadowing.
9503 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9504
9505 * deps.mk (unexalpha.o): Remove; unused.
9506
9507 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9508 * unexec.h: New file.
9509 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9510 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9511 Depend on unexec.h.
9512 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9513 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9514 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9515 Change as necessary to match prototype in unexec.h.
9516
9517 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9518 shadowing.
9519 (back_comment, skip_chars): Mark vars as initialized.
9520
9521 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9522 Rename locals to avoid shadowing.
9523
9524 * lread.c (read1): Rewrite so as not to use empty "else".
9525 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9526
9527 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9528
9529 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9530 warning when compiling print.c.
9531
9532 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9533 instead of using an uninitialized var.
9534 (font_sort_entities): Mark var as initialized.
9535
9536 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9537
9538 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9539 pointers to constants.
9540 (font_parse_fcname): Remove unused vars.
9541 (font_delete_unmatched): Now static.
9542 (font_get_spec): Remove; unused.
9543 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9544 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9545 Rename or move locals to avoid shadowing.
9546
9547 * fns.c (require_nesting_list, require_unwind): Now static.
9548 (Ffillarray): Rename locals to avoid shadowing.
9549
9550 * floatfns.c (domain_error2): Define only if needed.
9551 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9552
9553 * alloc.c (mark_backtrace): Move decl from here ...
9554 * lisp.h: ... to here, so that it can be checked.
9555
9556 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9557 (Fdefvar): Rewrite so as not to use empty "else".
9558 (lisp_indirect_variable): Name an expression,
9559 to avoid gcc -Wbad-function-cast warning.
9560 (Fdefvar): Rename locals to avoid shadowing.
9561
9562 * callint.c (quotify_arg, quotify_args): Now static.
9563 (Fcall_interactively): Rename locals to avoid shadowing.
9564 Use const pointer when appropriate.
9565
9566 * lisp.h (get_system_name, get_operating_system_release):
9567 Move decls here, to check interfaces.
9568 * process.c (get_operating_system_release): Move decl to lisp.h.
9569 * xrdb.c (get_system_name): Likewise.
9570 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9571 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9572 some of which prompt warnings from gcc -Wbad-function-cast.
9573 (Fformat_time_string, Fencode_time, Finsert_char):
9574 (Ftranslate_region_internal, Fformat):
9575 Rename or remove local vars to avoid shadowing.
9576 (Ftranslate_region_internal): Mark var as initialized.
9577
9578 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9579 avoid shadowing.
9580
9581 * lisp.h (eassert): Check that the argument compiles, even if
9582 ENABLE_CHECKING is not defined.
9583
9584 * data.c (Findirect_variable): Name an expression, to avoid
9585 gcc -Wbad-function-cast warning.
9586 (default_value, arithcompare, arith_driver, arith_error): Now static.
9587 (store_symval_forwarding): Rename local to avoid shadowing.
9588 (Fmake_variable_buffer_local, Fmake_local_variable):
9589 Mark variables as initialized.
9590 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9591
9592 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9593 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9594 Rename locals to avoid shadowing.
9595 (mark_stack): Move local variables into the #ifdef region where
9596 they're used.
9597 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9598 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9599 needed otherwise.
9600 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9601 (GC_STRING_CHARS): Remove; not used.
9602 (Fmemory_limit): Cast sbrk's returned value to char *.
9603
9604 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9605 avoids undefined behavior in theory.
9606
9607 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9608
9609 Use functions, not macros, for up- and down-casing (Bug#8254).
9610 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9611 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9612 to use the following functions instead of these macros.
9613 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9614 EMACS_INT, since callers assume the returned value fits in int.
9615 (upcase1): Likewise, for UPCASE_TABLE.
9616 (uppercasep, lowercasep, upcase): New static inline functions.
9617 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9618 the race-condition problem in the old DOWNCASE.
9619
9620 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9621 Rename locals to avoid shadowing.
9622 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9623 (regex_compile, re_search_2, re_match_2_internal):
9624 Remove unused local vars.
9625 (FREE_VAR): Rewrite so as not to use empty "else",
9626 which gcc can warn about.
9627 (regex_compile, re_match_2_internal): Mark locals as initialized.
9628 (RETALLOC_IF): Define only if needed.
9629 (WORDCHAR_P): Likewise. This one is never needed, but is used
9630 only in a comment talking about a compiler bug, so put inside
9631 the #if 0 of that comment.
9632 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9633 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9634 Remove; unused.
9635
9636 * search.c (boyer_moore): Rename locals to avoid shadowing.
9637 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9638 (PREV_CHAR_BOUNDARY): Likewise.
9639
9640 * search.c (simple_search): Remove unused var.
9641
9642 * dired.c (compile_pattern): Move decl from here ...
9643 * lisp.h: ... to here, so that it can be checked.
9644 (struct re_registers): New forward decl.
9645
9646 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9647
9648 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9649 All uses changed.
9650 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9651 Rename locals to avoid shadowing.
9652 (Fvertical_motion): Mark locals as initialized.
9653
9654 * casefiddle.c (casify_object, casify_region): Now static.
9655 (casify_region): Mark local as initialized.
9656
9657 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9658
9659 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9660 New macros, so that the caller can use some names other than
9661 gcpro1, gcpro2, etc.
9662 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9663 of the new macros.
9664 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9665 argument, for consistency with GCPRO2_VAR, etc: it is now the
9666 prefix of the variable, not the variable itself. All uses
9667 changed.
9668 * dired.c (directory_files_internal, file_name_completion):
9669 Rename locals to avoid shadowing.
9670
9671 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9672 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9673 dired.c's scmp function, had undefined behavior.
9674 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9675 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9676 * buffer.h: ... to here, because these macros use current_buffer,
9677 and the new implementation with inline functions needs to have
9678 current_buffer in scope now, rather than later when the macros
9679 are used.
9680 (downcase, upcase1): New static inline functions.
9681 (DOWNCASE, UPCASE1): Reimplement using these functions.
9682 This avoids undefined behavior in expressions like
9683 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9684 from race conditions in accessing the global variables
9685 case_temp1 and case_temp2.
9686 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9687 * lisp.h (case_temp1, case_temp2): Remove their decls.
9688 * character.h (ASCII_CHAR_P): Move from here ...
9689 * lisp.h: ... to here, so that the inline functions mentioned
9690 above can use them.
9691
9692 * dired.c (directory_files_internal_unwind): Now static.
9693
9694 * fileio.c (file_name_as_directory, directory_file_name):
9695 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9696 Now static.
9697 (file_name_as_directory): Use const pointers when appropriate.
9698 (Fexpand_file_name): Likewise. In particular, newdir might
9699 point at constant storage, so make it a const pointer.
9700 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9701 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9702 signedness issues.
9703 (Fset_file_times, Finsert_file_contents, auto_save_error):
9704 Rename locals to avoid shadowing.
9705
9706 * minibuf.c (choose_minibuf_frame_1): Now static.
9707 (Ftry_completion, Fall_completions): Rename or remove locals
9708 to avoid shadowing.
9709
9710 * marker.c (bytepos_to_charpos): Remove; unused.
9711
9712 * lisp.h (verify_bytepos, count_markers): New decls,
9713 so that gcc does not warn that these functions aren't declared.
9714
9715 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9716 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9717 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9718 (copy_text): Remove unused local var.
9719
9720 * filelock.c (within_one_second): Now static.
9721 (lock_file_1): Rename local to avoid shadowing.
9722
9723 * buffer.c (fix_overlays_before): Mark locals as initialized.
9724 (fix_start_end_in_overlays): Likewise. This function should be
9725 simplified by using pointers-to-pointers, but that's a different
9726 matter.
9727 (switch_to_buffer_1): Now static.
9728 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9729 (report_overlay_modification): Rename locals to avoid shadowing.
9730
9731 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9732 Fix pointer signedness issue.
9733 (sys_subshell): Mark local as volatile if checking for lint,
9734 to suppress a gcc -Wclobbered warning that does not seem to be right.
9735 (MAXPATHLEN): Define only if needed.
9736
9737 * process.c (serial_open, serial_configure): Move decls from here ...
9738 * systty.h: ... to here, so that they can be checked.
9739
9740 * fns.c (get_random, seed_random): Move extern decls from here ...
9741 * lisp.h: ... to here, so that they can be checked.
9742
9743 * sysdep.c (reset_io): Now static.
9744 (wait_for_termination_signal): Remove; unused.
9745
9746 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9747 (copy_keymap_item, append_key, push_text_char_description):
9748 Now static.
9749 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9750 (DENSE_TABLE_SIZE): Remove; unused.
9751 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9752 (describe_map_tree):
9753 Rename locals to avoid shadowing.
9754
9755 * keyboard.c: Declare functions static if they are not used elsewhere.
9756 (echo_char, echo_dash, cmd_error, top_level_2):
9757 (poll_for_input, handle_async_input): Now static.
9758 (read_char, kbd_buffer_get_event, make_lispy_position):
9759 (make_lispy_event, make_lispy_movement, apply_modifiers):
9760 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9761 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9762 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9763 (read_key_sequence, read_char): Mark locals as initialized.
9764 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9765
9766 * keyboard.h (make_ctrl_char): New decl.
9767 (mark_kboards): Move decl here ...
9768 * alloc.c (mark_kboards): ... from here.
9769
9770 * lisp.h (force_auto_save_soon): New decl.
9771
9772 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9773 (DEFINE_DUMMY_FUNCTION): New macro.
9774 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9775 Use it.
9776 (main): Add casts to avoid warnings
9777 if GCC considers string literals to be constants.
9778
9779 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9780
9781 * dbusbind.c: Pointer signedness fixes.
9782 (xd_signature, xd_append_arg, xd_initialize):
9783 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9784 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9785 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9786 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9787
9788 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9789 if GCC considers string literals to be constants.
9790 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9791
9792 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9793
9794 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9795 (print_preprocess, print_object): New macro to fix last change.
9796
9797 * print.c (print_preprocess): Don't forget font objects.
9798
9799 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9800
9801 * emacs.c (USAGE3): Doc fixes.
9802
9803 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9804
9805 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9806 structure.
9807
9808 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9809
9810 * lisp.h (VWindow_system, Qfile_name_history):
9811 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9812 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9813 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9814
9815 * w32select.c: Don't #include "keyboard.h".
9816 (run_protected): Add extern declaration for waiting_for_input.
9817
9818 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9819 * w32console.c (detect_input_pending, read_input_pending)
9820 (encode_terminal_code):
9821 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9822 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9823 (w32_system_caret_y, Qfile_name_history):
9824 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9825 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9826 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9827 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9828 * w32proc.c (Qlocal, report_file_error):
9829 * w32term.c (Vwindow_system, updating_frame):
9830 * w32uniscribe.c (initialized, uniscribe_font_driver):
9831 Remove unneeded extern declarations.
9832
9833 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9834
9835 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9836
9837 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9838
9839 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9840 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9841 These macros can no longer be used for assignment.
9842
9843 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9844 Assign struct members directly, instead of using BUF_BEGV etc.
9845 (record_buffer_markers, fetch_buffer_markers): New functions for
9846 recording and fetching special buffer markers.
9847 (set_buffer_internal_1, set_buffer_temp): Use them.
9848
9849 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9850
9851 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9852
9853 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9854 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9855
9856 * xdisp.c (hscroll_window_tree):
9857 (reconsider_clip_changes): Use PT instead of BUF_PT.
9858
9859 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9860
9861 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9862 $(EMACS_ROOT)/lib/intprops.h.
9863
9864 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9865
9866 Fix more problems found by GCC 4.5.2's static checks.
9867
9868 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9869 to unsigned char * to avoid compiler diagnostic.
9870 (xg_free_frame_widgets): Make it clear that a local variable is
9871 needed only if USE_GTK_TOOLTIP.
9872 (gdk_window_get_screen): Make it clear that this macro is needed
9873 only if USE_GTK_TOOLTIP.
9874 (int_gtk_range_get_value): New function, which avoids a diagnostic
9875 from gcc -Wbad-function-cast.
9876 (xg_set_toolkit_scroll_bar_thumb): Use it.
9877 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9878 diagnostic from gcc -Wbad-function-cast.
9879 (get_utf8_string, xg_get_file_with_chooser):
9880 Rename locals to avoid shadowing.
9881 (create_dialog): Move locals to avoid shadowing.
9882
9883 * xgselect.c (xg_select): Remove unused var.
9884
9885 * image.c (four_corners_best): Mark locals as initialized.
9886 (gif_load): Initialize transparent_p to zero (Bug#8238).
9887 Mark another local as initialized.
9888 (my_png_error, my_error_exit): Mark with NO_RETURN.
9889
9890 * image.c (clear_image_cache): Now static.
9891 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9892 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9893 (x_edge_detection): Remove unnecessary cast that
9894 gcc -Wbad-function-cast diagnoses.
9895 (gif_load): Fix pointer signedness.
9896 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9897 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9898
9899 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9900
9901 Improve quality of tests for time stamp overflow.
9902 For example, without this patch (encode-time 0 0 0 1 1
9903 1152921504606846976) returns the obviously-bogus value (-948597
9904 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9905 reports time overflow. See
9906 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9907 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9908 * editfns.c: Include limits.h and intprops.h.
9909 (TIME_T_MIN, TIME_T_MAX): New macros.
9910 (time_overflow): Move earlier, to before first use.
9911 (hi_time, lo_time): New functions, for an accurate test for
9912 out-of-range times.
9913 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9914 (Fget_internal_run_time): Don't assume time_t fits in int.
9915 (make_time): Use list2 instead of Fcons twice.
9916 (Fdecode_time): More accurate test for out-of-range times.
9917 (check_tm_member): New function.
9918 (Fencode_time): Use it, to test for out-of-range times.
9919 (lisp_time_argument): Don't rely on undefined left-shift and
9920 right-shift behavior when checking for time stamp overflow.
9921
9922 * editfns.c (time_overflow): New function, refactoring common code.
9923 (Fformat_time_string, Fdecode_time, Fencode_time):
9924 (Fcurrent_time_string): Use it.
9925
9926 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9927 * dired.c (make_time): Move to ...
9928 * editfns.c (make_time): ... here.
9929 * systime.h: Note the move.
9930
9931 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9932
9933 * fringe.c (update_window_fringes): Remove unused variables.
9934
9935 * unexmacosx.c (copy_data_segment): Also copy __got section.
9936 (Bug#8223)
9937
9938 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9939
9940 * termcap.c [MSDOS]: Include "msdos.h".
9941 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9942 Constify `char *' arguments and their references according to
9943 prototypes in tparam.h.
9944
9945 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9946
9947 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9948 Adapt all references accordingly.
9949
9950 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9951
9952 2011-03-11 Tom Tromey <tromey@redhat.com>
9953
9954 * buffer.c (syms_of_buffer): Remove obsolete comment.
9955
9956 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9957
9958 * termhooks.h (encode_terminal_code): Declare prototype.
9959
9960 * msdos.c (encode_terminal_code): Don't declare prototype.
9961
9962 * term.c (encode_terminal_code): Now external again, used by
9963 w32console.c and msdos.c.
9964
9965 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9966 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9967
9968 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9969
9970 Fix some minor problems found by GCC 4.5.2's static checks.
9971
9972 * fringe.c (update_window_fringes): Mark locals as initialized
9973 (Bug#8227).
9974 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9975
9976 * alloc.c (mark_fringe_data): Move decl from here ...
9977 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9978 to check its interface.
9979 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9980
9981 * fontset.c (free_realized_fontset): Now static.
9982 (Fset_fontset_font): Rename local to avoid shadowing.
9983 (fontset_font): Mark local as initialized.
9984 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9985
9986 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9987
9988 * xselect.c (x_disown_buffer_selections): Remove; not used.
9989 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9990 (x_own_selection, Fx_disown_selection_internal): Rename locals
9991 to avoid shadowing.
9992 (x_handle_dnd_message): Remove local to avoid shadowing.
9993
9994 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9995 so that the caller can use some name other than gcpro1.
9996 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9997 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9998 (Fx_backspace_delete_keys_p):
9999 Use them to avoid shadowing, and rename vars to avoid shadowing.
10000 (x_decode_color, x_set_name, x_window): Now static.
10001 (Fx_create_frame): Add braces to silence GCC warning.
10002 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10003 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10004 Remove unused locals.
10005 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10006 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10007 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10008 macros.
10009
10010 * xterm.h (x_mouse_leave): New decl.
10011
10012 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10013 Remove unused functions.
10014 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10015 (x_calc_absolute_position): Now static.
10016 (XTread_socket): Don't define label "out" unless it's used.
10017 Don't declare local "event" unless it's used.
10018 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10019 unless they are used.
10020 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10021 (x_fatal_error_signal): Remove; not used.
10022 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10023 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10024 (x_error_catcher, x_connection_closed, x_error_handler):
10025 (x_error_quitter, xembed_send_message, x_iconify_frame):
10026 (my_log_handler): Rename locals to avoid shadowing.
10027 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10028 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10029
10030 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10031 Rename or move locals to avoid shadowing.
10032 (tty_defined_color, merge_face_heights): Now static.
10033 (free_realized_faces_for_fontset): Remove; not used.
10034 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10035 does not deduce is never used uninitialized.
10036 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10037 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10038
10039 * terminal.c (store_terminal_param): Now static.
10040
10041 * xmenu.c (menu_highlight_callback): Now static.
10042 (set_frame_menubar): Remove unused local.
10043 (xmenu_show): Rename parameter to avoid shadowing.
10044 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10045 since they might point to immutable storage.
10046 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10047 since it's unused otherwise.
10048
10049 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10050 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10051 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10052 avoids a gcc -Wuninitialized diagnostic.
10053 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10054 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10055 does not deduce are never used uninitialized.
10056
10057 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10058
10059 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10060 * window.c (window_loop, size_window):
10061 (run_window_configuration_change_hook, enlarge_window): Likewise.
10062
10063 * window.c (display_buffer): Now static.
10064 (size_window): Mark variables that gcc -Wuninitialized
10065 does not deduce are never used uninitialized.
10066 * window.h (check_all_windows): New decl, to forestall
10067 gcc -Wmissing-prototypes diagnostic.
10068 * dispextern.h (bidi_dump_cached_states): Likewise.
10069
10070 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10071 shadowing.
10072 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10073 Include <limits.h>.
10074 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10075 and to avoid gcc -Wuninitialized warning.
10076 (load_charset_map): Mark variables that gcc -Wuninitialized
10077 does not deduce are never used uninitialized.
10078 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10079
10080 * coding.c (coding_set_source, coding_set_destination):
10081 Use "else { /* comment */ }" rather than "else /* comment */;"
10082 for clarity, and to avoid gcc -Wempty-body warning.
10083 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10084 a block, when the outer 'i' will do.
10085 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10086 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10087 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10088 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10089 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10090 Rename locals to avoid shadowing.
10091 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10092 * coding.c (emacs_mule_char, encode_invocation_designation):
10093 Now static, since they're not used elsewhere.
10094 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10095 (decode_coding_object, encode_coding_object, detect_coding_system):
10096 (decode_coding_emacs_mule): Mark variables that gcc
10097 -Wuninitialized does not deduce are never used uninitialized.
10098 (detect_coding_iso_2022): Initialize a local variable that might
10099 be used uninitialized. Leave a FIXME because it's not clear that
10100 this initialization is needed. (Bug#8211)
10101 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10102 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10103 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10104 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10105 Remove unused macros.
10106
10107 * category.c (hash_get_category_set): Remove unused local var.
10108 (copy_category_table): Now static, since it's not used elsewhere.
10109 * character.c (string_count_byte8): Likewise.
10110
10111 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10112 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10113
10114 * chartab.c (copy_sub_char_table): Now static, since it's not used
10115 elsewhere.
10116 (sub_char_table_ref_and_range, char_table_ref_and_range):
10117 Rename locals to avoid shadowing.
10118 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10119
10120 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10121 (BIDI_BOB): Remove unused macro.
10122
10123 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10124 deduce are never used uninitialized.
10125 * term.c (encode_terminal_code): Likewise.
10126
10127 * term.c (encode_terminal_code): Now static. Remove unused local.
10128
10129 * tparam.h: New file.
10130 * term.c, tparam.h: Include it.
10131 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10132 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10133 Move these decls to tparam.h, and make them agree with what
10134 is actually in tparam.c. The previous trick of using incompatible
10135 decls in different modules does not conform to the C standard.
10136 All callers of tparam changed to use tparam's actual API.
10137 * tparam.c (tparam1, tparam, tgoto):
10138 Use const pointers where appropriate.
10139
10140 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10141 * cm.h (struct cm): Likewise.
10142 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10143 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10144 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10145 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10146 (turn_on_face, init_tty): Likewise.
10147 * termchar.h (struct tty_display_info): Likewise.
10148
10149 * term.c (term_mouse_position): Rename local to avoid shadowing.
10150
10151 * alloc.c (mark_ttys): Move decl from here ...
10152 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10153
10154 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10155
10156 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10157
10158 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10159
10160 * search.c (compile_pattern_1): Remove argument regp, unused since
10161 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10162 (compile_pattern): Don't pass it.
10163
10164 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10165
10166 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10167 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10168 for ! HAVE_GTK3.
10169 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10170
10171 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10172
10173 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10174 gdk_window_get_screen, gdk_window_get_geometry,
10175 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10176 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10177 (xg_get_pixbuf_from_pixmap): New function.
10178 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10179 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10180 Call xg_get_pixbuf_from_pixmap instead of
10181 gdk_pixbuf_get_from_drawable.
10182 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10183 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10184 (xg_check_special_colors): Use GtkStyleContext and its functions
10185 for HAVE_GTK3.
10186 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10187 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10188 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10189 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10190 Call gtk_widget_get_preferred_size.
10191 (xg_frame_resized): gdk_window_get_geometry only takes 5
10192 parameters.
10193 (xg_win_to_widget, xg_event_is_for_menubar):
10194 Call gdk_x11_window_lookup_for_display.
10195 (xg_set_widget_bg): New function.
10196 (delete_cb): New function.
10197 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10198 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10199 (xg_set_background_color): Call xg_set_widget_bg.
10200 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10201 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10202 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10203 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10204 if ! HAVE_GTK3.
10205 (update_frame_tool_bar): Call gtk_widget_hide.
10206 (xg_initialize): Use GDK_KEY_g.
10207
10208 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10209 if ! HAVE_GTK3
10210 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10211
10212 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10213 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10214 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10215
10216 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10217
10218 * w32xfns.c (select_palette): Check success of RealizePalette against
10219 GDI_ERROR, not zero.
10220
10221 See ChangeLog.11 for earlier changes.
10222
10223 ;; Local Variables:
10224 ;; coding: utf-8
10225 ;; End:
10226
10227 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10228
10229 This file is part of GNU Emacs.
10230
10231 GNU Emacs is free software: you can redistribute it and/or modify
10232 it under the terms of the GNU General Public License as published by
10233 the Free Software Foundation, either version 3 of the License, or
10234 (at your option) any later version.
10235
10236 GNU Emacs is distributed in the hope that it will be useful,
10237 but WITHOUT ANY WARRANTY; without even the implied warranty of
10238 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10239 GNU General Public License for more details.
10240
10241 You should have received a copy of the GNU General Public License
10242 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.