Fix typos that break xsettings.c compilation.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-01 Glenn Morris <rgm@gnu.org>
2
3 * Makefile.in (SETTINGS_LIBS): Fix typo.
4
5 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6
7 * coding.c (Fencode_coding_string): Record the last coding system
8 used, as the function doc string says (bug#8738).
9
10 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11
12 * xsettings.c (store_monospaced_changed): Take new font as arg and
13 check for change against current_mono_font.
14 (EMACS_TYPE_SETTINGS): Remove this and related defines.
15 (emacs_settings_constructor, emacs_settings_get_property)
16 (emacs_settings_set_property, emacs_settings_class_init)
17 (emacs_settings_init, gsettings_obj): Remove.
18 (something_changedCB): New function for HAVE_GSETTINGS.
19 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
20 with value as argument.
21 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
22 g_settings_new (Bug#8967). Do not create gsettings_obj.
23 Remove calls to g_settings_bind. Connect something_changedCB to
24 "changed".
25
26 * xgselect.c: Add defined (HAVE_GSETTINGS).
27 (xgselect_initialize): Ditto.
28
29 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
30 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
31 xg_select.
32
33 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
34
35 * eval.c (struct backtrace): Simplify and port the data structure.
36 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
37 signed bit field, as this assumption is not portable and it makes
38 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
39 "char debug_on_exit : 1" as this is not portable either; instead,
40 use the portable "unsigned int debug_on_exit : 1". Remove unused
41 member evalargs. Remove obsolete comments about cc bombing out.
42
43 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
44
45 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
46 Let HAVE_GSETTINGS override HAVE_GCONF.
47 (store_monospaced_changed): New function.
48 (EMACS_SETTINGS): A new type derived from GObject to handle
49 GSettings notifications.
50 (emacs_settings_constructor, emacs_settings_get_property)
51 (emacs_settings_set_property, emacs_settings_class_init):
52 New functions.
53 (gsettings_client, gsettings_obj): New variables.
54 (GSETTINGS_SCHEMA): New define.
55 (something_changedCB): Call store_monospaced_changed.
56 (init_gsettings): New function.
57 (xsettings_initialize): Call init_gsettings.
58 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
59 to NULL.
60
61 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
62 GCONF_CFLAGS/LIBS.
63
64 2011-06-29 Martin Rudalics <rudalics@gmx.at>
65
66 * window.c (resize_root_window, grow_mini_window)
67 (shrink_mini_window): Rename Qresize_root_window to
68 Qwindow_resize_root_window and Qresize_root_window_vertically to
69 Qwindow_resize_root_window_vertically.
70
71 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
72
73 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
74
75 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
76
77 * makefile.w32-in: Redesign dependencies so they reflect more
78 clearly which files are directly included by each source file,
79 and not through other includes.
80
81 2011-06-27 Martin Rudalics <rudalics@gmx.at>
82
83 * buffer.c (Qclone_number): Declare static and DEFSYM it.
84 (sort_overlays, overlay_strings): When an overlay's clone number
85 matches the window's clone number process the overlay even if
86 the overlay's window property doesn't match the current window.
87
88 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
89 (Fwindow_hchild): Rename to Fwindow_left_child.
90 (Fwindow_next): Rename to Fwindow_next_sibling.
91 (Fwindow_prev): Rename to Fwindow_prev_sibling.
92 (resize_window_check): Rename to window_resize_check.
93 (resize_window_apply): Rename to window_resize_apply.
94 (Fresize_window_apply): Rename to Fwindow_resize_apply.
95 (Fdelete_other_windows_internal, resize_frame_windows)
96 (Fsplit_window_internal, Fdelete_window_internal)
97 (grow_mini_window, shrink_mini_window)
98 (Fresize_mini_window_internal): Fix callers accordingly.
99
100 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
101
102 * emacsgtkfixed.h: State that this is only used with Gtk+3.
103 (emacs_fixed_set_min_size): Remove.
104 (emacs_fixed_new): Take frame as argument.
105
106 * emacsgtkfixed.c: State that this is only used with Gtk+3.
107 (_EmacsFixedPrivate): Remove minwidth/height.
108 Add struct frame *f.
109 (emacs_fixed_init): Initialize priv->f.
110 (get_parent_class, emacs_fixed_set_min_size): Remove.
111 (emacs_fixed_new): Set priv->f to argument.
112 (emacs_fixed_get_preferred_width)
113 (emacs_fixed_get_preferred_height): Use min_width/height from
114 frames size_hint to set minimum and natural (Bug#8919).
115 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
116 and use min_width/height from frames size_hint to set
117 min_width/height (Bug#8919).
118
119 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
120 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
121 indentation.
122
123 2011-06-26 Eli Zaretskii <eliz@gnu.org>
124
125 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
126 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
127 called at ZV.
128
129 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
130
131 * process.c (wait_reading_process_output): Bypass select if
132 waiting for a cell while ignoring keyboard input, and input is
133 pending. Suggested by Jan Djärv (Bug#8869).
134
135 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
136
137 Use gnulib's dup2 module instead of rolling our own.
138 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
139
140 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
141
142 * dispnew.c (scrolling_window): Before scrolling, turn off a
143 mouse-highlight in the window being scrolled.
144
145 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
146
147 Move DEFSYM to lisp.h and use everywhere.
148
149 * character.h (DEFSYM): Move declaration...
150 * lisp.h (DEFSYM): ...here.
151
152 * gnutls.c:
153 * minibuf.c:
154 * w32menu.c:
155 * w32proc.c:
156 * w32select.c: Don't include character.h.
157
158 * alloc.c (syms_of_alloc):
159 * buffer.c (syms_of_buffer):
160 * bytecode.c (syms_of_bytecode):
161 * callint.c (syms_of_callint):
162 * casefiddle.c (syms_of_casefiddle):
163 * casetab.c (init_casetab_once):
164 * category.c (init_category_once, syms_of_category):
165 * ccl.c (syms_of_ccl):
166 * cmds.c (syms_of_cmds):
167 * composite.c (syms_of_composite):
168 * dbusbind.c (syms_of_dbusbind):
169 * dired.c (syms_of_dired):
170 * dispnew.c (syms_of_display):
171 * doc.c (syms_of_doc):
172 * editfns.c (syms_of_editfns):
173 * emacs.c (syms_of_emacs):
174 * eval.c (syms_of_eval):
175 * fileio.c (syms_of_fileio):
176 * fns.c (syms_of_fns):
177 * frame.c (syms_of_frame):
178 * fringe.c (syms_of_fringe):
179 * insdel.c (syms_of_insdel):
180 * keymap.c (syms_of_keymap):
181 * lread.c (init_obarray, syms_of_lread):
182 * macros.c (syms_of_macros):
183 * msdos.c (syms_of_msdos):
184 * print.c (syms_of_print):
185 * process.c (syms_of_process):
186 * search.c (syms_of_search):
187 * sound.c (syms_of_sound):
188 * syntax.c (init_syntax_once, syms_of_syntax):
189 * terminal.c (syms_of_terminal):
190 * textprop.c (syms_of_textprop):
191 * undo.c (syms_of_undo):
192 * w32.c (globals_of_w32):
193 * window.c (syms_of_window):
194 * xdisp.c (syms_of_xdisp):
195 * xfaces.c (syms_of_xfaces):
196 * xfns.c (syms_of_xfns):
197 * xmenu.c (syms_of_xmenu):
198 * xsettings.c (syms_of_xsettings):
199 * xterm.c (syms_of_xterm): Use DEFSYM.
200
201 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
202
203 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
204
205 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
206
207 Integer and buffer overflow fixes (Bug#8873).
208
209 * print.c (printchar, strout): Check for string overflow.
210 (PRINTPREPARE, printchar, strout):
211 Don't set size unless allocation succeeds.
212
213 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
214 for sizes. Check for string overflow more accurately.
215 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
216
217 * macros.c: Integer and buffer overflow fixes.
218 * keyboard.h (struct keyboard.kbd_macro_bufsize):
219 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
220 Use ptrdiff_t, not int, for sizes.
221 Don't increment bufsize until after realloc succeeds.
222 Check for size-calculation overflow.
223 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
224
225 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
226
227 * lread.c: Integer overflow fixes.
228 (read_integer): Radix is now EMACS_INT, not int,
229 to improve quality of diagnostics for out-of-range radices.
230 Calculate buffer size correctly for out-of-range radices.
231 (read1): Check for integer overflow in radices, and in
232 read-circle numbers.
233 (read_escape): Avoid int overflow.
234 (Fload, openp, read_buffer_size, read1)
235 (substitute_object_recurse, read_vector, read_list, map_obarray):
236 Use ptrdiff_t, not int, for sizes.
237 (read1): Use EMACS_INT, not int, for sizes.
238 Check for size overflow.
239
240 * image.c (cache_image): Check for size arithmetic overflow.
241
242 * lread.c: Integer overflow issues.
243 (saved_doc_string_size, saved_doc_string_length)
244 (prev_saved_doc_string_size, prev_saved_doc_string_length):
245 Now ptrdiff_t, not int.
246 (read1): Don't assume doc string length fits in int. Check for
247 out-of-range doc string lengths.
248 (read_list): Don't assume file position fits in int.
249 (read_escape): Check for hex character overflow.
250
251 2011-06-22 Leo Liu <sdl.web@gmail.com>
252
253 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
254 Move to minibuffer.el.
255
256 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
257
258 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
259 The following patches are for when GLYPH_DEBUG && !XASSERT.
260 * dispextern.h (trace_redisplay_p, dump_glyph_string):
261 * dispnew.c (flush_stdout):
262 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
263 Mark as externally visible.
264 * dispnew.c (check_window_matrix_pointers): Now static.
265 * dispnew.c (window_to_frame_vpos):
266 * xfns.c (unwind_create_frame):
267 * xterm.c (x_check_font): Remove unused local.
268 * scroll.c (CHECK_BOUNDS):
269 * xfaces.c (cache_fache): Rename local to avoid shadowing.
270 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
271 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
272 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
273 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
274 Now static.
275 (debug_method_add): Use va_list and vsprintf rather than relying
276 on undefined behavior with wrong number of arguments.
277 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
278 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
279 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
280 since we're not interested in debugging glyphs with old libraries.
281 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
282 GCC 4.6.0's static checking.
283
284 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
285
286 Integer overflow and signedness fixes (Bug#8873).
287 A few related buffer overrun fixes, too.
288
289 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
290
291 * dispextern.h (struct face.stipple):
292 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
293 (x_bitmap_mask, x_allocate_bitmap_record)
294 (x_create_bitmap_from_data, x_create_bitmap_from_file)
295 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
296 (x_create_bitmap_from_xpm_data):
297 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
298 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
299 (.bitmaps_last):
300 * xfaces.c (load_pixmap):
301 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
302 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
303 (.bitmaps_last, struct x_output.icon_bitmap):
304 Use ptrdiff_t, not int, for bitmap indexes.
305 (x_allocate_bitmap_record): Check for size overflow.
306 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
307
308 Use ptrdiff_t, not int, for overlay counts.
309 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
310 * editfns.c (overlays_around, get_pos_property):
311 * textprop.c (get_char_property_and_overlay):
312 * xdisp.c (next_overlay_change, note_mouse_highlight):
313 * xfaces.c (face_at_buffer_position):
314 * buffer.c (OVERLAY_COUNT_MAX): New macro.
315 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
316 (Fnext_overlay_change, Fprevious_overlay_change)
317 (mouse_face_overlay_overlaps, Foverlays_in):
318 Use ptrdiff_t, not int, for sizes.
319 (overlays_at, overlays_in): Check for size-calculation overflow.
320
321 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
322
323 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
324 (x_session_initialize): Do not assume string length fits in int.
325
326 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
327 This is unlikely, but can occur if DPI is outlandish.
328
329 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
330 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
331
332 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
333 * xrdb.c (magic_file_p, search_magic_path):
334 Omit last arg SUFFIX; it was always 0. All callers changed.
335 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
336
337 * xfont.c (xfont_match): Avoid need for strlen.
338
339 * xfns.c: Don't assume strlen fits in int.
340 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
341
342 * xdisp.c (message_log_check_duplicate): Return intmax_t,
343 not unsigned long, as we prefer signed integers. All callers changed.
344 Detect integer overflow in repeat count.
345 (message_dolog): Don't assume print length fits in 39 bytes.
346 (display_mode_element): Don't assume strlen fits in int.
347
348 * termcap.c: Don't assume sizes fit in int and never overflow.
349 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
350 (gobble_line): Check for size-calculation overflow.
351
352 * minibuf.c (Fread_buffer):
353 * lread.c (intern, intern_c_string):
354 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
355 Don't assume string length fits in int.
356
357 * keyboard.c (parse_tool_bar_item):
358 * gtkutil.c (style_changed_cb): Avoid need for strlen.
359
360 * font.c: Don't assume string length fits in int.
361 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
362 Use ptrdiff_t, not int.
363 (font_intern_prop): Don't assume string length fits in int.
364 Don't assume integer property fits in fixnum.
365 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
366
367 * filelock.c: Fix some buffer overrun and integer overflow issues.
368 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
369 Reformulate so as not to need the command string.
370 Invoke gzip -cd rather than gunzip, as it's more portable.
371 (lock_info_type, lock_file_1, lock_file):
372 Don't assume pid_t and time_t fit in unsigned long.
373 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
374 (current_lock_owner): Prefer signed type for sizes.
375 Use memcpy, not strncpy, where memcpy is what is really wanted.
376 Don't assume (via atoi) that time_t and pid_t fit in int.
377 Check for time_t and/or pid_t out of range, e.g., via a network share.
378 Don't alloca where an auto var works fine.
379
380 * fileio.c: Fix some integer overflow issues.
381 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
382 Don't assume string length fits in int.
383 (directory_file_name): Don't assume string length fits in long.
384 (make_temp_name): Don't assume pid fits in int, or that its print
385 length is less than 20.
386
387 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
388
389 * coding.c (make_subsidiaries): Don't assume string length fits in int.
390
391 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
392
393 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
394 We prefer signed integers, even for size calculations.
395
396 * emacs.c: Don't assume string length fits in 'int'.
397 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
398 (main): Don't invoke strlen when not needed.
399
400 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
401 (XD_DEBUG_MESSAGE): Don't waste a byte.
402
403 * callproc.c (getenv_internal_1, getenv_internal)
404 (Fgetenv_internal):
405 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
406
407 * lread.c (invalid_syntax): Omit length argument.
408 All uses changed. This doesn't fix a bug, but it simplifies the
409 code away from its former Hollerith-constant appearance, and it's
410 one less 'int' to worry about when looking at integer-overflow issues.
411 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
412
413 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
414 This didn't break anything, but it didn't help either.
415 It's confusing to put a bogus integer in a place where the actual
416 value does not matter.
417 (LIST_END_P): Remove unused macro and its bogus comment.
418 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
419
420 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
421 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
422 implementation.
423 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
424 We prefer signed types, and the value cannot exceed the EMACS_INT
425 range anyway (because otherwise the length would not be representable).
426 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
427 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
428 This avoids a GCC warning when WIDE_EMACS_INT.
429
430 * indent.c (sane_tab_width): New function.
431 (current_column, scan_for_column, Findent_to, position_indentation)
432 (compute_motion): Use it. This is just for clarity.
433 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
434
435 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
436
437 * lisp.h (lint_assume): New macro.
438 * composite.c (composition_gstring_put_cache):
439 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
440
441 * editfns.c, insdel.c:
442 Omit unnecessary forward decls, to simplify future changes.
443
444 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
445
446 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
447
448 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
449 Use much-faster test for byte-length change.
450 Don't assume string byte-length fits in 'int'.
451 Check that character arg fits in 'int'.
452 (mapcar1): Declare byte as byte, for clarity.
453
454 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
455
456 * fns.c (concat): Catch string overflow earlier.
457 Do not rely on integer wraparound.
458
459 * dispextern.h (struct it.overlay_strings_charpos)
460 (struct it.selective): Now EMACS_INT, not int.
461 * xdisp.c (forward_to_next_line_start)
462 (back_to_previous_visible_line_start)
463 (reseat_at_next_visible_line_start, next_element_from_buffer):
464 Don't arbitrarily truncate the value of 'selective' to int.
465
466 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
467
468 * composite.c: Don't truncate sizes to 'int'.
469 (composition_gstring_p, composition_reseat_it)
470 (composition_adjust_point): Use EMACS_INT, not int.
471 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
472 not EMACS_UINT, for indexes.
473
474 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
475
476 * buffer.c: Include <verify.h>.
477 (struct sortvec.priority, struct sortstr.priority):
478 Now EMACS_INT, not int.
479 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
480 (struct sortstr.size, record_overlay_string)
481 (struct sortstrlist.size, struct sortlist.used):
482 Don't truncate size to int.
483 (record_overlay_string): Check for size-calculation overflow.
484 (init_buffer_once): Check at compile-time, not run-time.
485
486 2011-06-22 Jim Meyering <meyering@redhat.com>
487
488 Don't leak an XBM-image-sized buffer
489 * image.c (xbm_load): Free the image buffer after using it.
490
491 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
492
493 Port to Sun C.
494 * composite.c (find_automatic_composition): Omit needless 'return 0;'
495 that Sun C diagnosed.
496 * fns.c (secure_hash): Fix pointer signedness issue.
497 * intervals.c (static_offset_intervals): New function.
498 (offset_intervals): Use it.
499
500 2011-06-21 Leo Liu <sdl.web@gmail.com>
501
502 * deps.mk (fns.o):
503 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
504 sha512.h.
505
506 * fns.c (secure_hash): Rename from crypto_hash_function and change
507 the first arg to accept symbols.
508 (Fsecure_hash): New primitive.
509 (syms_of_fns): New symbols.
510
511 2011-06-20 Deniz Dogan <deniz@dogan.se>
512
513 * process.c (Fset_process_buffer): Clarify return value in
514 docstring.
515
516 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
517
518 * dispnew.c (add_window_display_history): Use BVAR.
519
520 * xdisp.c (debug_method_add): Use BVAR.
521 (check_window_end, dump_glyph_matrix, dump_glyph)
522 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
523
524 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
525 Likewise.
526
527 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
528 check till after the cache is created in init_frame_faces.
529
530 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
531
532 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
533
534 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
535
536 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
537 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
538 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
539
540 Improve buffer-overflow checking (Bug#8873).
541 * fileio.c (Finsert_file_contents):
542 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
543 Remove the old (too-loose) buffer overflow checks.
544 They weren't needed, since make_gap checks for buffer overflow.
545 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
546 The old code merely checked for Emacs fixnum overflow, and relied
547 on undefined (wraparound) behavior. The new code avoids undefined
548 behavior, and also checks for ptrdiff_t and/or size_t overflow.
549
550 * editfns.c (Finsert_char): Don't dump core with very negative counts.
551 Tune. Don't use wider integers than needed. Don't use alloca.
552 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
553
554 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
555
556 * insdel.c, lisp.h (buffer_overflow): New function.
557 (insert_from_buffer_1, replace_range, replace_range_2):
558 * insdel.c (make_gap_larger):
559 * editfns.c (Finsert_char):
560 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
561
562 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
563
564 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
565
566 Integer overflow and signedness fixes (Bug#8873).
567
568 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
569 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
570
571 * fileio.c: Don't assume EMACS_INT fits in off_t.
572 (emacs_lseek): New static function.
573 (Finsert_file_contents, Fwrite_region): Use it.
574 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
575
576 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
577
578 * fns.c: Don't overflow int when computing a list length.
579 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
580 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
581 truncation on 64-bit hosts. Check for QUIT every
582 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
583 faster and is responsive enough.
584 (Flength): Report an error instead of overflowing an integer.
585 (Fsafe_length): Return a float if the value is not representable
586 as a fixnum. This shouldn't happen except in contrived situations.
587 (Fnthcdr, Fsort): Don't assume list length fits in int.
588 (Fcopy_sequence): Don't assume vector length fits in int.
589
590 * alloc.c: Check that resized vectors' lengths fit in fixnums.
591 (header_size, word_size): New constants.
592 (allocate_vectorlike): Don't check size overflow here.
593 (allocate_vector): Check it here instead, since this is the only
594 caller of allocate_vectorlike that could cause overflow.
595 Check that the new vector's length is representable as a fixnum.
596
597 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
598 The previous code was bogus. For example, next_almost_prime (32)
599 returned 39, which is undesirable as it is a multiple of 3; and
600 next_almost_prime (24) returned 25, which is a multiple of 5 so
601 why was the code bothering to check for multiples of 7?
602
603 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
604
605 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
606
607 Variadic C functions now count arguments with ptrdiff_t.
608 This partly undoes my 2011-03-30 change, which replaced int with size_t.
609 Back then I didn't know that the Emacs coding style prefers signed int.
610 Also, in the meantime I found a few more instances where arguments
611 were being counted with int, which may truncate counts on 64-bit
612 machines, or EMACS_INT, which may be unnecessarily wide.
613 * lisp.h (struct Lisp_Subr.function.aMANY)
614 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
615 Arg counts are now ptrdiff_t, not size_t.
616 All variadic functions and their callers changed accordingly.
617 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
618 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
619 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
620 * callint.c (Fcall_interactively): Check arg count for overflow,
621 to avoid potential buffer overrun. Use signed char, not 'int',
622 for 'varies' array, so that we needn't bother to check its size
623 calculation for overflow.
624 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
625 * eval.c (apply_lambda):
626 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
627 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
628 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
629
630 * callint.c (Fcall_interactively): Don't use index var as event count.
631
632 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
633 * mem-limits.h (SIZE): Remove; no longer used.
634
635 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
636
637 Remove unnecessary casts.
638 * xterm.c (x_term_init):
639 * xfns.c (x_set_border_pixel):
640 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
641 These aren't needed now that we assume ANSI C.
642
643 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
644 It's more likely to cause problems (due to unsigned overflow)
645 than to cure them.
646
647 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
648
649 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
650
651 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
652
653 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
654
655 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
656
657 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
658
659 GLYPH_CODE_FACE returns EMACS_INT, not int.
660 * dispextern.h (merge_faces):
661 * xfaces.c (merge_faces):
662 * xdisp.c (get_next_display_element, next_element_from_display_vector):
663 Don't assume EMACS_INT fits in int.
664
665 * character.h (CHAR_VALID_P): Remove unused parameter.
666 * fontset.c, lisp.h, xdisp.c: All uses changed.
667
668 * editfns.c (Ftranslate_region_internal): Omit redundant test.
669
670 * fns.c (concat): Minor tuning based on overflow analysis.
671 This doesn't fix any bugs. Use int to hold character, instead
672 of constantly refetching from Emacs object. Use XFASTINT, not
673 XINT, for value known to be a character. Don't bother comparing
674 a single byte to 0400, as it's always less.
675
676 * floatfns.c (Fexpt):
677 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
678
679 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
680 for characters.
681
682 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
683
684 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
685 Without this fix, on a 64-bit host (aset S 0 4294967386) would
686 incorrectly succeed when S was a string, because 4294967386 was
687 truncated before it was used.
688
689 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
690 Otherwise, an out-of-range integer could cause undefined behavior
691 on a 64-bit host.
692
693 * composite.c: Use int, not EMACS_INT, for characters.
694 (fill_gstring_body, composition_compute_stop_pos): Use int, not
695 EMACS_INT, for values that are known to be in character range.
696 This doesn't fix any bugs but is the usual style inside Emacs and
697 may generate better code on 32-bit machines.
698
699 Make sure a 64-bit char is never passed to ENCODE_CHAR.
700 This is for reasons similar to the recent CHAR_STRING fix.
701 * charset.c (Fencode_char): Check that character arg is actually
702 a character. Pass an int to ENCODE_CHAR.
703 * charset.h (ENCODE_CHAR): Verify that the character argument is no
704 wider than 'int', as a compile-time check to prevent future regressions
705 in this area.
706
707 * character.c (char_string): Remove unnecessary casts.
708
709 Make sure a 64-bit char is never passed to CHAR_STRING.
710 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
711 by silently ignoring the top 32 bits, allowing some values
712 that were far too large to be valid characters.
713 * character.h: Include <verify.h>.
714 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
715 arguments are no wider than unsigned, as a compile-time check
716 to prevent future regressions in this area.
717 * data.c (Faset):
718 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
719 (Fsubst_char_in_region):
720 * fns.c (concat):
721 * xdisp.c (decode_mode_spec_coding):
722 Adjust to CHAR_STRING's new requirement.
723 * editfns.c (Finsert_char, Fsubst_char_in_region):
724 * fns.c (concat): Check that character args are actually
725 characters. Without this test, these functions did the wrong
726 thing with wildly out-of-range values on 64-bit hosts.
727
728 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
729 These casts should not be needed on 32-bit hosts, either.
730 * keyboard.c (read_char):
731 * lread.c (Fload): Remove casts to unsigned.
732
733 * lisp.h (UNSIGNED_CMP): New macro.
734 This fixes comparison bugs on 64-bit hosts.
735 (ASCII_CHAR_P): Use it.
736 * casefiddle.c (casify_object):
737 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
738 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
739 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
740 * dispextern.h (FACE_FROM_ID):
741 * keyboard.c (read_char): Use UNSIGNED_CMP.
742
743 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
744 not to EMACS_INT, to avoid GCC warning.
745
746 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
747
748 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
749 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
750 isn't needed on 32-bit machines.
751
752 * buffer.c (Fgenerate_new_buffer_name):
753 Use EMACS_INT for count, not int.
754 (advance_to_char_boundary): Return EMACS_INT, not int.
755
756 * data.c (Qcompiled_function): Now static.
757
758 * window.c (window_body_lines): Now static.
759
760 * image.c (gif_load): Rename local to avoid shadowing.
761
762 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
763 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
764 * alloc.c (make_save_value): Integer argument is now of type
765 ptrdiff_t, not int.
766 (mark_object): Use ptrdiff_t, not int.
767 * lisp.h (pD): New macro.
768 * print.c (print_object): Use it.
769
770 * alloc.c: Use EMACS_INT, not int, to count objects.
771 (total_conses, total_markers, total_symbols, total_vector_size)
772 (total_free_conses, total_free_markers, total_free_symbols)
773 (total_free_floats, total_floats, total_free_intervals)
774 (total_intervals, total_strings, total_free_strings):
775 Now EMACS_INT, not int. All uses changed.
776 (Fgarbage_collect): Compute overall total using a double, so that
777 integer overflow is less likely to be a problem. Check for overflow
778 when converting back to an integer.
779 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
780 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
781 These were 'int' variables that could overflow on 64-bit hosts;
782 they were never used, so remove them instead of repairing them.
783 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
784 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
785 Previously, this ceilinged at INT_MAX, but that doesn't work on
786 64-bit machines.
787 (allocate_pseudovector): Don't use EMACS_INT when int would do.
788
789 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
790 (allocate_vectorlike): Check for ptrdiff_t overflow.
791 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
792 when a (possibly-narrower) signed value would do just as well.
793 We prefer using signed arithmetic, to avoid comparison confusion.
794
795 * alloc.c: Catch some string size overflows that we were missing.
796 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
797 for convenience in STRING_BYTES_MAX.
798 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
799 The definition here is exact; the one in lisp.h was approximate.
800 (allocate_string_data): Check for string overflow. This catches
801 some instances we weren't catching before. Also, it catches
802 size_t overflow on (unusual) hosts where SIZE_MAX <= min
803 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
804 and ptrdiff_t and EMACS_INT are both 64 bits.
805
806 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
807 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
808 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
809
810 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
811
812 * alloc.c (Fmake_string): Check for out-of-range init.
813
814 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
815
816 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
817
818 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
819
820 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
821 xg_get_default_scrollbar_width.
822
823 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
824 (int_gtk_range_get_value): Move to the scroll bar part of the file.
825 (style_changed_cb): Call update_theme_scrollbar_width and call
826 x_set_scroll_bar_default_width and xg_frame_set_char_size for
827 all frames (Bug#8505).
828 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
829 Call gtk_window_set_resizable if HAVE_GTK3.
830 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
831 and height if HAVE_GTK3 (Bug#8505).
832 (scroll_bar_width_for_theme): New variable.
833 (update_theme_scrollbar_width): New function.
834 (xg_get_default_scrollbar_width): Move code to
835 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
836 (xg_initialize): Call update_theme_scrollbar_width.
837
838 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
839
840 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
841
842 2011-06-12 Martin Rudalics <rudalics@gmx.at>
843
844 * frame.c (make_frame): Call other_buffer_safely instead of
845 other_buffer.
846
847 * window.c (temp_output_buffer_show): Call display_buffer with
848 second argument Vtemp_buffer_show_specifiers and reset latter
849 immediately after the call.
850 (Vtemp_buffer_show_specifiers): New variable.
851 (auto_window_vscroll_p, next_screen_context_lines)
852 (Vscroll_preserve_screen_position): Remove leading asterisks from
853 doc-strings.
854
855 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
856
857 Fix minor problems found by GCC 4.6.0 static checking.
858 * buffer.c (Qclone_number): Remove for now, as it's unused.
859 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
860 (record_buffer): Remove unused local.
861 * frame.c (other_visible_frames, frame_buffer_list): Now static.
862 (set_frame_buffer_list): Remove; unused.
863 * frame.h (other_visible_frames): Remove decl.
864 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
865 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
866 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
867 if HAVE_GPM.
868 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
869 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
870 Define only if HAVE_GPM.
871 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
872 (update_hints_inhibit): Remove; never set. All uses removed.
873 * widgetprv.h (emacsFrameClassRec): Remove decl.
874 * window.c (delete_deletable_window): Now returns void, since it
875 wasn't returning anything.
876 (compare_window_configurations): Remove unused locals.
877 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
878 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
879 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
880 the same widths as pointers. This follows up on the 2011-05-06 patch.
881 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
882 * xterm.h: Likewise.
883 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
884
885 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
886
887 * makefile.w32-in: Update dependencies.
888 (LISP_H): Add lib/intprops.h.
889
890 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
891
892 * image.c (gif_load): Add animation frame delay to the metadata.
893 (syms_of_image): Use DEFSYM. New symbol `delay'.
894
895 2011-06-11 Martin Rudalics <rudalics@gmx.at>
896
897 * window.c (delete_deletable_window): Re-add.
898 (Fset_window_configuration): Rewrite to handle dead buffers and
899 consequently deletable windows.
900 (window_tree, Fwindow_tree): Remove. Supply functionality in
901 window.el.
902 (compare_window_configurations): Simplify code.
903
904 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
905
906 * image.c (imagemagick_load_image): Fix type mismatch.
907 (Fimagemagick_types): Likewise.
908
909 * window.h (replace_buffer_in_windows): Declare.
910
911 2011-06-11 Martin Rudalics <rudalics@gmx.at>
912
913 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
914 Qclone_number. Remove external declaration of Qdelete_window.
915 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
916 code.
917 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
918 Qbuffer_list_update_hook if allowed.
919 (Fother_buffer): Rewrite doc-string. Major rewrite for new
920 buffer list implementation.
921 (other_buffer_safely): New function.
922 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
923 calls to replace_buffer_in_windows and
924 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
925 if allowed.
926 (record_buffer): Inhibit quitting and rewrite using quittable
927 functions. Run Qbuffer_list_update_hook if allowed.
928 (Frecord_buffer, Funrecord_buffer): New functions.
929 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
930 switch-to-buffer to window.el.
931 (bury-buffer): Move to window.el.
932 (Vbuffer_list_update_hook): New variable.
933
934 * lisp.h (other_buffer_safely): Add prototype in buffer.c
935 section.
936
937 * window.h (resize_frame_windows): Move up in code.
938 (Fwindow_frame): Remove EXFUN.
939 (replace_buffer_in_all_windows): Remove prototype.
940 (replace_buffer_in_windows_safely): Add prototype.
941
942 * window.c: Declare Qdelete_window static again. Move down
943 declaration of select_count.
944 (Fnext_window, Fprevious_window): Rewrite doc-strings.
945 (Fother_window): Move to window.el.
946 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
947 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
948 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
949 window.el.
950 (replace_buffer_in_windows): Implement by calling
951 Qreplace_buffer_in_windows.
952 (replace_buffer_in_all_windows): Remove with some functionality
953 moved into replace_buffer_in_windows_safely.
954 (replace_buffer_in_windows_safely): New function.
955 (select_window_norecord, select_frame_norecord): Move in front
956 of run_window_configuration_change_hook. Remove now obsolete
957 declarations.
958 (Fset_window_buffer): Rewrite doc-string. Call
959 Qrecord_window_buffer.
960 (keys_of_window): Move binding for other-window to window.el.
961
962 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
963
964 * dispextern.h (struct image): Replace data member, whose int_val
965 and ptr_val fields were not used by anything, with a single
966 lisp_val object.
967
968 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
969 (gif_clear_image, gif_load, imagemagick_load_image)
970 (gs_clear_image, gs_load): Callers changed.
971
972 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
973
974 * buffer.h: Include <time.h>, for time_t.
975 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
976
977 Fix minor problems found by static checking.
978
979 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
980
981 Make identifiers static if they are not used in other modules.
982 * data.c (Qcompiled_function, Qframe, Qvector):
983 * image.c (QimageMagick, Qsvg):
984 * minibuf.c (Qmetadata):
985 * window.c (resize_window_check, resize_root_window): Now static.
986 * window.h (resize_window_check, resize_root_window): Remove decls.
987
988 * window.c (window_deletion_count, delete_deletable_window):
989 Remove; unused.
990 (window_body_lines): Now static.
991 (Fdelete_other_windows_internal): Mark vars as initialized.
992 Make sure 'resize_failed' is initialized.
993 (run_window_configuration_change_hook): Rename local to avoid shadowing.
994 (resize_window_apply): Remove unused local.
995 * window.h (delete_deletable_window): Remove decl.
996
997 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
998 (imagemagick_load_image): Fix pointer signedness problem by changing
999 last arg from unsigned char * to char *. All uses changed.
1000 Also, fix a local for similar reasons.
1001 Remove unused locals. Remove locals to avoid shadowing.
1002 (fn_rsvg_handle_free): Remove; unused.
1003 (svg_load, svg_load_image): Fix pointer signedness problem.
1004 (imagemagick_load_image): Don't use garbage pointer image_wand.
1005
1006 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1007
1008 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1009
1010 * image.c (gif_load): Fix omitted cast error introduced by
1011 2011-06-06 change.
1012
1013 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1014
1015 * window.h (resize_proportionally, orig_total_lines)
1016 (orig_top_line): Remove from window structure.
1017 (set_window_height, set_window_width, change_window_heights)
1018 (Fdelete_window): Remove prototypes.
1019 (resize_frame_windows): Remove duplicate declaration.
1020
1021 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1022
1023 * window.h (resize_frame_windows, resize_window_check)
1024 (delete_deletable_window, resize_root_window)
1025 (resize_frame_windows): Declare prototypes.
1026
1027 * window.c (resize_window_apply): Make definition be "static" to
1028 match the prototype.
1029
1030 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1031
1032 * window.c: Remove declarations of Qwindow_size_fixed,
1033 window_min_size_1, window_min_size_2, window_min_size,
1034 size_window, window_fixed_size_p, enlarge_window, delete_window.
1035 Remove static from declaration of Qdelete_window, it's
1036 temporarily needed by Fbury_buffer.
1037 (replace_window): Don't assign orig_top_line and
1038 orig_total_lines.
1039 (Fdelete_window, delete_window): Remove. Window deletion is
1040 handled by window.el.
1041 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1042 Fdelete_window calls with calls to Qdelete_window.
1043 (Fdelete_other_windows): Remove. Deleting other windows is
1044 handled by window.el.
1045 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1046 handled in window.el.
1047 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1048 Window minimum sizes are handled in window.el.
1049 (shrink_windows, size_window, set_window_height)
1050 (set_window_width, change_window_heights, window_height)
1051 (window_width, CURBEG, CURSIZE, enlarge_window)
1052 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1053 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1054 handled in window.el.
1055 (make_dummy_parent): Rename to make_parent_window and give it a
1056 second argument horflag.
1057 (make_window): Don't set resize_proportionally any more.
1058 (Fsplit_window): Remove. Windows are split in window.el.
1059 (save_restore_action, save_restore_orig_size)
1060 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1061 Resize mini windows in window.el.
1062 (grow_mini_window, shrink_mini_window): Implement by calling
1063 Qresize_root_window_vertically, resize_window_check and
1064 resize_window_apply.
1065 (saved_window, Fset_window_configuration, save_window_save): Do
1066 not handle orig_top_line, orig_total_lines, and
1067 resize_proportionally.
1068 (window_min_height, window_min_width): Move to window.el.
1069 (keys_of_window): Move bindings for delete-other-windows,
1070 split-window, delete-window and enlarge-window to window.el.
1071
1072 * buffer.c: Temporarily extern Qdelete_window.
1073 (Fbury_buffer): Temporarily call Qdelete_window instead of
1074 Fdelete_window (Fbury_buffer will move to window.el soon).
1075
1076 * frame.c (set_menu_bar_lines_1): Remove code handling
1077 orig_top_line and orig_total_lines.
1078
1079 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1080 set_window_height but set heights directly.
1081 (change_frame_size_1): Use resize_frame_windows.
1082
1083 * xdisp.c (init_xdisp): Don't use set_window_height but set
1084 heights directly.
1085
1086 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1087 resize_frame_windows instead of change_window_heights and run
1088 run_window_configuration_change_hook.
1089
1090 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1091 instead of change_window_heights and run
1092 run_window_configuration_change_hook.
1093
1094 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1095
1096 * window.c (replace_window): Rename second argument REPLACEMENT to
1097 NEW. New third argument SETFLAG. Rewrite.
1098 (delete_window, make_dummy_parent): Call replace_window with
1099 third argument 1.
1100 (window_list_1): Move down in code.
1101 (run_window_configuration_change_hook): Move set_buffer part
1102 before select_frame_norecord part in order to unwind correctly.
1103 Rename count1 to count.
1104 (recombine_windows, delete_deletable_window, resize_root_window)
1105 (Fdelete_other_windows_internal)
1106 (Frun_window_configuration_change_hook, make_parent_window)
1107 (resize_window_check, resize_window_apply, Fresize_window_apply)
1108 (resize_frame_windows, Fsplit_window_internal)
1109 (Fdelete_window_internal, Fresize_mini_window_internal): New
1110 functions.
1111 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1112
1113 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1114
1115 * window.h (window): Add some new members to window structure -
1116 normal_lines, normal_cols, new_total, new_normal, clone_number,
1117 splits, nest, prev_buffers, next_buffers.
1118 (WINDOW_TOTAL_SIZE): Move here from window.c.
1119 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1120
1121 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1122 Remove.
1123 (make_dummy_parent): Set new members of windows structure.
1124 (make_window): Move down in code. Handle new members of window
1125 structure.
1126 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1127 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1128 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1129 (Fset_window_prev_buffers, Fwindow_next_buffers)
1130 (Fset_window_next_buffers, Fset_window_clone_number): New
1131 functions.
1132 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1133 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1134 Doc-string fixes.
1135 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1136 Argument WINDOW can be now internal window too.
1137 (Fwindow_use_time): Move up in code.
1138 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1139 Rewrite doc-string.
1140 (Fset_window_configuration, saved_window)
1141 (Fcurrent_window_configuration, save_window_save): Handle new
1142 members of window structure.
1143 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1144 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1145 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1146 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1147 Qget_mru_window, Qresize_root_window,
1148 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1149 Qauto_buffer_name; staticpro them.
1150
1151 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1152
1153 * window.c (Fwindow_total_size, Fwindow_left_column)
1154 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1155 (Fwindow_list_1): New functions.
1156 (window_box_text_cols): Replace with window_body_cols.
1157 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1158 window_body_cols instead of window_box_text_cols.
1159 (delete_window, Fset_window_configuration): Call
1160 delete_all_subwindows with window as argument.
1161 (delete_all_subwindows): Take a window as argument and not a
1162 structure. Rewrite.
1163 (window_loop): Remove handling of GET_LRU_WINDOW and
1164 GET_LARGEST_WINDOW.
1165 (Fget_lru_window, Fget_largest_window): Move to window.el.
1166
1167 * window.h: Extern window_body_cols instead of
1168 window_box_text_cols. delete_all_subwindows now takes a
1169 Lisp_Object as argument.
1170
1171 * indent.c (compute_motion, Fcompute_motion): Use
1172 window_body_cols instead of window_box_text_cols.
1173
1174 * frame.c (delete_frame): Call delete_all_subwindows with root
1175 window as argument.
1176
1177 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1178
1179 * fns.c (Fputhash): Document return value.
1180
1181 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1182
1183 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1184
1185 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 Cons<->int and similar integer overflow fixes (Bug#8794).
1188
1189 Check for overflow when converting integer to cons and back.
1190 * charset.c (Fdefine_charset_internal, Fdecode_char):
1191 Use cons_to_unsigned to catch overflow.
1192 (Fencode_char): Use INTEGER_TO_CONS.
1193 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1194 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1195 * data.c (long_to_cons, cons_to_long): Remove.
1196 (cons_to_unsigned, cons_to_signed): New functions.
1197 These signal an error for invalid or out-of-range values.
1198 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1199 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1200 * font.c (Ffont_variation_glyphs):
1201 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1202 * lisp.h: Include <intprops.h>.
1203 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1204 (cons_to_signed, cons_to_unsigned): New decls.
1205 (long_to_cons, cons_to_long): Remove decls.
1206 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1207 (Fprimitive_undo): Use CONS_TO_INTEGER.
1208 * xfns.c (Fx_window_property): Likewise.
1209 * xselect.c: Include <limits.h>.
1210 (x_own_selection, selection_data_to_lisp_data):
1211 Use INTEGER_TO_CONS.
1212 (x_handle_selection_request, x_handle_selection_clear)
1213 (x_get_foreign_selection, Fx_disown_selection_internal)
1214 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1215 (lisp_data_to_selection_data): Use cons_to_unsigned.
1216 (x_fill_property_data): Use cons_to_signed.
1217 Report values out of range.
1218
1219 Check for buffer and string overflow more precisely.
1220 * buffer.h (BUF_BYTES_MAX): New macro.
1221 * lisp.h (STRING_BYTES_MAX): New macro.
1222 * alloc.c (Fmake_string):
1223 * character.c (string_escape_byte8):
1224 * coding.c (coding_alloc_by_realloc):
1225 * doprnt.c (doprnt):
1226 * editfns.c (Fformat):
1227 * eval.c (verror):
1228 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1229 since they may not be the same number.
1230 * editfns.c (Finsert_char):
1231 * fileio.c (Finsert_file_contents):
1232 Likewise for BUF_BYTES_MAX.
1233
1234 * image.c: Use ptrdiff_t, not int, for sizes.
1235 (slurp_file): Switch from int to ptrdiff_t.
1236 All uses changed.
1237 (slurp_file): Check that file size fits in both size_t (for
1238 malloc) and ptrdiff_t (for sanity and safety).
1239
1240 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1241 if b->modtime has its maximal value.
1242
1243 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1244
1245 Don't assume time_t can fit into int.
1246 * buffer.h (struct buffer.modtime): Now time_t, not int.
1247 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1248 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1249
1250 Minor fixes for signed vs unsigned integers.
1251 * character.h (MAYBE_UNIFY_CHAR):
1252 * charset.c (maybe_unify_char):
1253 * keyboard.c (read_char, reorder_modifiers):
1254 XINT -> XFASTINT, since the integer must be nonnegative.
1255 * ftfont.c (ftfont_spec_pattern):
1256 * keymap.c (access_keymap, silly_event_symbol_error):
1257 XUINT -> XFASTINT, since the integer must be nonnegative.
1258 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1259 since it makes no difference and we prefer signed.
1260 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1261 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1262 nonnegative.
1263
1264 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1265
1266 * window.h (Fwindow_frame): Declare.
1267
1268 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1271 (SPARE_MEMORY): Always define.
1272 (LARGE_REQUEST): Remove.
1273 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1274
1275 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1276
1277 * lisp.h: Move EXFUNS for Fframe_root_window,
1278 Fframe_first_window and Fset_frame_selected_window to window.h.
1279
1280 * window.h: Move EXFUNS for Fframe_root_window,
1281 Fframe_first_window and Fset_frame_selected_window here from
1282 lisp.h.
1283
1284 * frame.c (Fwindow_frame, Fframe_first_window)
1285 (Fframe_root_window, Fframe_selected_window)
1286 (Fset_frame_selected_window): Move to window.c.
1287 (Factive_minibuffer_window): Move to minibuf.c.
1288 (Fother_visible_frames_p): New function.
1289
1290 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1291
1292 * window.c (decode_window, decode_any_window): Move up in code.
1293 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1294 (inhibit_frame_unsplittable): Remove unused variable.
1295 (Fwindow_buffer): Move up and rewrite doc-string.
1296 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1297 (Fwindow_prev): New functions.
1298 (Fwindow_frame): Move here from frame.c. Accept any window as
1299 argument.
1300 (Fframe_root_window, Fframe_first_window)
1301 (Fframe_selected_window): Move here from frame.c. Accept frame
1302 or arbitrary window as argument. Update doc-strings.
1303 (Fminibuffer_window): Move up in code.
1304 (Fwindow_minibuffer_p): Move up in code and simplify.
1305 (Fset_frame_selected_window): Move here from frame.c.
1306 Marginal rewrite.
1307 (Fselected_window, select_window, Fselect_window): Move up in
1308 code. Minor doc-string fixes.
1309
1310 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1313 Do not assume that spare memory exists; that assumption is valid
1314 only if SYSTEM_MALLOC.
1315 (LARGE_REQUEST): New macro, so that the issue of large requests
1316 is separated from the issue of spare memory.
1317
1318 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1321 format. (Bug#8806)
1322
1323 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1324
1325 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1326 before statements.
1327
1328 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1329
1330 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1331
1332 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1333
1334 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1335 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1336
1337 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1340
1341 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1342
1343 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1344 (x_clipboard_manager_save): Add return value.
1345 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1346 New error handlers.
1347 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1348 Obey Vx_select_enable_clipboard_manager. Catch errors in
1349 x_clipboard_manager_save (Bug#8779).
1350 (Vx_select_enable_clipboard_manager): New variable.
1351 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1352
1353 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1354
1355 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1356
1357 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1358
1359 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1360 in the current matrix if keep_current_p is non-zero.
1361
1362 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1363
1364 * bidi.c (bidi_level_of_next_char): Fix last change.
1365
1366 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1367
1368 Support bidi reordering of text covered by display properties.
1369
1370 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1371 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1372 (bidi_cache_search, bidi_cache_iterator_state)
1373 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1374 (bidi_level_of_next_char, bidi_move_to_visually_next):
1375 Support character positions inside a run of characters covered by a
1376 display string.
1377 (bidi_paragraph_init, bidi_resolve_explicit_1)
1378 (bidi_level_of_next_char): Call bidi_fetch_char and
1379 bidi_fetch_char_advance instead of FETCH_CHAR and
1380 FETCH_CHAR_ADVANCE.
1381 (bidi_init_it): Initialize new members.
1382 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1383 definitions.
1384 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1385 instead of using explicit *_CHAR codes.
1386 (bidi_resolve_explicit, bidi_resolve_weak):
1387 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1388 bidirectional text is supported only in multibyte buffers.
1389 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1390 it to initialize the frame_window_p member of struct bidi_it.
1391 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1392 (bidi_resolve_explicit, bidi_resolve_weak)
1393 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1394 bidi_it->nchars is non-positive.
1395 (bidi_level_of_next_char): Don't try to lookup the cache for the
1396 next/previous character if nothing is cached there yet, or if we
1397 were just reseat()'ed to a new position.
1398
1399 * xdisp.c (set_cursor_from_row): Set start and stop points
1400 according to the row's direction when priming the loop that looks
1401 for the glyph on which to display cursor.
1402 (single_display_spec_intangible_p): Function deleted.
1403 (display_prop_intangible_p): Reimplement to call
1404 handle_display_spec instead of single_display_spec_intangible_p.
1405 Accept 3 additional arguments needed by handle_display_spec.
1406 This fixes incorrect cursor motion across display property with complex
1407 values: lists, `(when COND...)' forms, etc.
1408 (single_display_spec_string_p): Support property values that are
1409 lists with the argument STRING its top-level element.
1410 (display_prop_string_p): Fix the condition for processing a
1411 property that is a list to be consistent with handle_display_spec.
1412 (handle_display_spec): New function, refactored from the
1413 last portion of handle_display_prop.
1414 (compute_display_string_pos): Accept additional argument
1415 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1416 value of a `display' property is a "replacing spec".
1417 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1418 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1419 the display property, but just return a value indicating whether
1420 the display property will replace the characters it covers.
1421 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1422 frame_window_p members of struct bidi_it.
1423 (compute_display_string_pos, compute_display_string_end):
1424 New functions.
1425 (push_it): Accept second argument POSITION, where pop_it should
1426 jump to continue iteration.
1427 (reseat_1): Initialize bidi_it.disp_pos.
1428
1429 * keyboard.c (adjust_point_for_property): Adjust the call to
1430 display_prop_intangible_p to its new signature.
1431
1432 * dispextern.h (struct bidi_it): New member frame_window_p.
1433 (bidi_init_it): Update prototypes.
1434 (display_prop_intangible_p): Update prototype.
1435 (compute_display_string_pos, compute_display_string_end):
1436 Declare prototypes.
1437 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1438 EMACS_INT.
1439
1440 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 Malloc failure behavior now depends on size of allocation.
1443 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1444 * lisp.h: Change signatures accordingly.
1445 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1446 All callers changed. (Bug#8762)
1447
1448 * gnutls.c: Use Emacs's memory allocators.
1449 Without this change, the gnutls library would invoke malloc etc.
1450 directly, which causes problems on non-SYNC_INPUT hosts, and which
1451 runs afoul of improving memory_full behavior. (Bug#8761)
1452 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1453 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1454 xfree instead of the default malloc, realloc, free.
1455 (Fgnutls_boot): No need to check for memory allocation failure,
1456 since xmalloc does that for us.
1457
1458 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1459 * category.c (hash_get_category_set):
1460 * ccl.c (ccl_driver):
1461 * charset.c (Fdefine_charset_internal):
1462 * charset.h (struct charset.hash_index):
1463 * composite.c (get_composition_id, gstring_lookup_cache)
1464 (composition_gstring_put_cache):
1465 * composite.h (struct composition.hash_index):
1466 * dispextern.h (struct image.hash):
1467 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1468 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1469 (hashfn_equal, hashfn_user_defined, make_hash_table)
1470 (maybe_resize_hash_table, hash_lookup, hash_put)
1471 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1472 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1473 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1474 * image.c (make_image, search_image_cache, lookup_image)
1475 (xpm_put_color_table_h):
1476 * lisp.h (struct Lisp_Hash_Table):
1477 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1478 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1479 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1480 * alloc.c (allocate_vectorlike):
1481 Check for overflow in vector size calculations.
1482 * ccl.c (ccl_driver):
1483 Check for overflow when converting EMACS_INT to int.
1484 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1485 need to be updated by these changes.
1486 * fns.c (make_hash_table, maybe_resize_hash_table):
1487 Check for integer overflow with large hash tables.
1488 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1489 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1490 (SXHASH_REDUCE): New macro.
1491 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1492 Use it instead of discarding useful hash info with large hash values.
1493 (sxhash_float): New function.
1494 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1495 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1496 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1497 Rewrite to use FIXNUM_BITS, as this simplifies things.
1498 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1499 Adjust signatures to match updated version of code.
1500 (consing_since_gc): Now EMACS_INT, since a single hash table can
1501 use more than INT_MAX bytes.
1502
1503 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1504
1505 Make it possible to build with GCC-4.6+ -O2 -flto.
1506
1507 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1508
1509 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1510
1511 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1512 Call minibuffer-inactive-mode.
1513
1514 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1515
1516 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1517 Update dependencies.
1518
1519 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1520
1521 * data.c (init_data): Remove code for UTS, this system is not
1522 supported anymore.
1523
1524 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1525
1526 Don't force ./temacs to start in terminal mode.
1527
1528 * frame.c (make_initial_frame): Initialize faces in all cases, not
1529 only when CANNOT_DUMP is defined.
1530 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1531
1532 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1533
1534 * dispnew.c (add_window_display_history): Use const for the string
1535 pointer. Remove declaration, not needed.
1536
1537 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1538
1539 Use 'inline', not 'INLINE'.
1540 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1541 * alloc.c, fontset.c (INLINE): Remove.
1542 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1543 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1544 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1545 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1546 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1547
1548 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1549
1550 Make it possible to run ./temacs.
1551
1552 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1553 syms_of_callproc does the same thing. Remove test for
1554 "initialized", do it in the caller.
1555 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1556
1557 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1558
1559 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1560 (read_minibuf): Use get_minibuffer.
1561 (syms_of_minibuf): Use DEFSYM.
1562 (Qmetadata): New var.
1563 * data.c (Qbuffer): Don't make it static.
1564 (syms_of_data): Use DEFSYM.
1565
1566 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1567
1568 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1569 (CCL_CODE_MIN): New macro.
1570
1571 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1574
1575 * eval.c (Qdebug): Now static.
1576 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1577 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1578 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1579
1580 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1581
1582 * image.c: Various fixes to ImageMagick code comments.
1583 (Fimagemagick_types): Doc fix.
1584
1585 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 Minor fixes prompted by GCC 4.6.0 warnings.
1588
1589 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1590
1591 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1592 (x_clipboard_manager_save_all): Move extern decl to ...
1593 * xterm.h: ... here, so that it can be checked for consistency.
1594
1595 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1596
1597 * xselect.c (x_clipboard_manager_save_frame)
1598 (x_clipboard_manager_save_all): New functions.
1599 (Fx_clipboard_manager_save): Lisp function deleted.
1600
1601 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1602 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1603
1604 * xterm.h: Update prototype.
1605
1606 2011-05-28 William Xu <william.xwl@gmail.com>
1607
1608 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1609 exiting (Bug#8239).
1610
1611 2011-05-28 Jim Meyering <meyering@redhat.com>
1612
1613 Avoid a sign-extension bug in crypto_hash_function.
1614 * fns.c (to_uchar): Define.
1615 (crypto_hash_function): Use it to convert some newly-signed
1616 variables to unsigned, to avoid sign-extension bugs. For example,
1617 without this change, (md5 "truc") would evaluate to
1618 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1619 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1620 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1621
1622 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1623
1624 Integer overflow fixes.
1625
1626 * dbusbind.c: Serial number integer overflow fixes.
1627 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1628 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1629 to hold a serial number that is too large for a fixnum.
1630 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1631 Check for serial numbers out of range. Decode any serial number
1632 that was so large that it became a float. (Bug#8722)
1633
1634 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1635 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1636 Use XFASTINT rather than XUINT when numbers are nonnegative.
1637 (xd_append_arg, Fdbus_method_return_internal):
1638 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1639 arguments, check that Lisp number is nonnegative, rather than
1640 silently wrapping negative numbers around. (Bug#8722)
1641 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1642 (Bug#8722)
1643
1644 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1645
1646 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1647
1648 ccl: add integer overflow checks
1649 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1650 (IN_INT_RANGE): New macros.
1651 (ccl_driver): Use them to check for integer overflow when
1652 decoding a CCL program. Many of the new checks are whether XINT (x)
1653 fits in int; it doesn't always, on 64-bit hosts. The new version
1654 doesn't catch all possible integer overflows, but it's an
1655 improvement. (Bug#8719)
1656
1657 * alloc.c (make_event_array): Use XINT, not XUINT.
1658 There's no need for unsigned here.
1659
1660 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1661 This follows up to the 2011-05-06 change that substituted uintptr_t
1662 for EMACS_INT. This case wasn't caught back then.
1663
1664 Rework Fformat to avoid integer overflow issues.
1665 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1666 now (part of C89). Include <verify.h>.
1667 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1668 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1669 (Fformat): Avoid the prepass trying to compute sizes; it was only
1670 approximate and thus did not catch overflow reliably. Instead, walk
1671 through the format just once, formatting and computing sizes as we go,
1672 checking for integer overflow at every step, and allocating a larger
1673 buffer as needed. Keep track separately whether the format is
1674 multibyte. Keep only the most-recently calculated precision, rather
1675 than them all. Record whether each argument has been converted to
1676 string. Use EMACS_INT, not int, for byte and char and arg counts.
1677 Support field widths and precisions larger than INT_MAX. Avoid
1678 sprintf's undefined behavior with conversion specifications such as %#d
1679 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1680 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1681 formatting out-of-range floating point numbers with int
1682 formats. (Bug#8668)
1683
1684 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1685
1686 * data.c: Avoid integer truncation in expressions involving floats.
1687 * data.c: Include <intprops.h>.
1688 (arith_driver): When there's an integer overflow in an expression
1689 involving floating point, convert the integers to floating point
1690 so that the resulting value does not suffer from catastrophic
1691 integer truncation. For example, on a 64-bit host (* 4
1692 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1693 Do not rely on undefined behavior after integer overflow.
1694
1695 merge count_size_as_multibyte, parse_str_to_multibyte
1696 * character.c, character.h (count_size_as_multibyte):
1697 Rename from parse_str_to_multibyte; all uses changed.
1698 Check for integer overflow.
1699 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1700 since it's now a duplicate of the other. This is more of
1701 a character than a buffer op, so better that it's in character.c.
1702 * fns.c, print.c: Adjust to above changes.
1703
1704 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1705
1706 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1707
1708 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1711 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1712 (x_clipboard_manager_save): Now static.
1713 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1714
1715 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1716 (crypto_hash_function): Now static.
1717 Fix pointer signedness problems. Avoid unnecessary initializations.
1718
1719 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1720
1721 * termhooks.h (Vselection_alist): Make it terminal-local.
1722
1723 * terminal.c (create_terminal): Initialize it.
1724
1725 * xselect.c: Support for clipboard managers.
1726 (Vselection_alist): Move to termhooks.h as terminal-local var.
1727 (LOCAL_SELECTION): New macro.
1728 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1729 (symbol_to_x_atom): Remove gratuitous arg.
1730 (x_handle_selection_request, lisp_data_to_selection_data)
1731 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1732 (x_own_selection, x_get_local_selection, x_convert_selection):
1733 New arg, specifying work frame. Use terminal-local Vselection_alist.
1734 (some_frame_on_display): Delete unused function.
1735 (Fx_own_selection_internal, Fx_get_selection_internal)
1736 (Fx_disown_selection_internal, Fx_selection_owner_p)
1737 (Fx_selection_exists_p): New optional frame arg.
1738 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1739 (x_handle_selection_clear): Don't treat other terminals with the
1740 same keyboard specially. Use the terminal-local Vselection_alist.
1741 (x_clear_frame_selections): Use Frun_hook_with_args.
1742
1743 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1744
1745 * xterm.h: Add support for those atoms.
1746
1747 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1748
1749 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1750 (converted_selections, conversion_fail_tag): New global variables.
1751 (x_selection_request_lisp_error): Free the above.
1752 (x_get_local_selection): Remove unnecessary code.
1753 (x_reply_selection_request): Args changed; handle arbitrary array
1754 of converted selections stored in converted_selections.
1755 Separate the XChangeProperty and SelectionNotify steps.
1756 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1757 (x_convert_selection): New function.
1758 (x_handle_selection_event): Simplify.
1759 (x_get_foreign_selection): Don't ignore incoming requests while
1760 waiting for an answer; this will fail when we implement
1761 SAVE_TARGETS, and seems unnecessary anyway.
1762 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1763 (Vx_sent_selection_functions): Doc fix.
1764
1765 2011-05-26 Leo Liu <sdl.web@gmail.com>
1766
1767 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1768
1769 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1770
1771 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1772
1773 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1774 for fringe update if it has periodic bitmap.
1775 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1776 and fringe_bitmap_periodic_p.
1777
1778 * fringe.c (get_fringe_bitmap_data): New function.
1779 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1780 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1781 row. Mark glyph row for fringe update if periodicity changed.
1782
1783 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1784 for fringe update unless it has periodic bitmap.
1785
1786 2011-05-25 Kenichi Handa <handa@m17n.org>
1787
1788 * xdisp.c (get_next_display_element): Set correct it->face_id for
1789 a static composition.
1790
1791 2011-05-24 Leo Liu <sdl.web@gmail.com>
1792
1793 * deps.mk (fns.o):
1794 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1795
1796 * fns.c (crypto_hash_function, Fsha1): New function.
1797 (Fmd5): Use crypto_hash_function.
1798 (syms_of_fns): Add Ssha1.
1799
1800 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 * gnutls.c: Remove unused macros.
1803 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1804 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1805 Remove macros that are defined and never used.
1806 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1807
1808 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1809
1810 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1811 (Fx_get_selection_internal): Minor cleanup.
1812 (Fx_own_selection_internal): Rename arguments for consistency with
1813 select.el.
1814
1815 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1818
1819 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1820
1821 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1822
1823 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1824
1825 * dispnew.c (scrolling_window): Don't exclude the case that the
1826 last enabled row in the desired matrix touches the bottom boundary.
1827
1828 2011-05-21 Glenn Morris <rgm@gnu.org>
1829
1830 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1831 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1832 and add some more files.
1833
1834 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1835
1836 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1837 report_file_error introduced by the change from 2011-05-07.
1838
1839 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * systime.h (Time): Define only if emacs is defined.
1842 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1843 where the include path doesn't have X11/X.h by default. See
1844 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1845
1846 2011-05-20 Kenichi Handa <handa@m17n.org>
1847
1848 * composite.c (find_automatic_composition): Fix previous change.
1849
1850 2011-05-20 Glenn Morris <rgm@gnu.org>
1851
1852 * lisp.mk: New file, split from Makefile.in.
1853 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1854 (shortlisp): Remove.
1855 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1856
1857 2011-05-19 Glenn Morris <rgm@gnu.org>
1858
1859 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1860 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1861 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1862 (lisp): Set the order to that of loadup.el.
1863 (shortlisp): Make it a copy of $lisp.
1864 (SOME_MACHINE_LISP): Remove.
1865 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1866 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1867
1868 2011-05-18 Kenichi Handa <handa@m17n.org>
1869
1870 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1871 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1872 (find_automatic_composition): Mostly rewrite for efficiency.
1873
1874 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1875
1876 * makefile.w32-in: Update dependencies.
1877
1878 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1879
1880 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1881 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1882
1883 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 Fix some integer overflow issues, such as string length overflow.
1886
1887 * insdel.c (count_size_as_multibyte): Check for string overflow.
1888
1889 * character.c (lisp_string_width): Check for string overflow.
1890 Use EMACS_INT, not int, for string indexes and lengths; in
1891 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1892 the resulting string length overflows an EMACS_INT; instead,
1893 report a string overflow if no precision given. When checking for
1894 precision exhaustion, use a check that cannot possibly have
1895 integer overflow. (Bug#8675)
1896 * character.h (lisp_string_width): Adjust to new signature.
1897
1898 * alloc.c (string_overflow): New function.
1899 (Fmake_string): Use it. This doesn't change behavior, but saves
1900 a few bytes and will simplify future changes.
1901 * character.c (string_escape_byte8): Likewise.
1902 * lisp.h (string_overflow): New decl.
1903
1904 Fixups, following up to the user-interface timestamp change.
1905 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1906 for UI timestamps, instead of unsigned long.
1907 * msdos.c (mouse_get_pos): Likewise.
1908 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1909 * w32gui.h (Time): Define by including "systime.h" rather than by
1910 declaring it ourselves. (Bug#8664)
1911
1912 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1913 * image.c (clear_image_cache): Likewise.
1914
1915 * term.c (term_mouse_position): Don't assume time_t wraparound.
1916
1917 Be more systematic about user-interface timestamps.
1918 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1919 and sometimes 'EMACS_UINT', to represent these timestamps.
1920 This change causes it to use 'Time' uniformly, as that's what X uses.
1921 This makes the code easier to follow, and makes it easier to catch
1922 integer overflow bugs such as Bug#8664.
1923 * frame.c (Fmouse_position, Fmouse_pixel_position):
1924 Use Time, not unsigned long, for user-interface timestamps.
1925 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1926 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1927 * keyboard.h (last_event_timestamp): Likewise.
1928 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1929 * menu.h (xmenu_show): Likewise.
1930 * term.c (term_mouse_position): Likewise.
1931 * termhooks.h (struct input_event.timestamp): Likewise.
1932 (struct terminal.mouse_position_hook): Likewise.
1933 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1934 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1935 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1936 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1937 what it was before.
1938 * menu.h, termhooks.h: Include "systime.h", for Time.
1939
1940 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1941 Don't assume that the difference between two unsigned long values
1942 can fit into an integer. At this point, we know button_down_time
1943 <= event->timestamp, so the difference must be nonnegative, so
1944 there's no need to cast the result if double-click-time is
1945 nonnegative, as it should be; check that it's nonnegative, just in
1946 case. This bug is triggered when events are more than 2**31 ms
1947 apart (about 25 days). (Bug#8664)
1948
1949 * xselect.c (last_event_timestamp): Remove duplicate decl.
1950 (x_own_selection): Remove needless cast to unsigned long.
1951
1952 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1953 that always fit in int. Use a sentinel instead of a counter, to
1954 avoid a temp and to allay GCC's concerns about possible int overflow.
1955 * frame.h (struct frame): Use int for menu_bar_items_used
1956 instead of EMACS_INT, since it always fits in int.
1957
1958 * menu.c (grow_menu_items): Check for int overflow.
1959
1960 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1961
1962 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1963 Before, the code was not consistent. These values cannot exceed
1964 2**31 - 1 so there's no need to make them unsigned.
1965 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1966 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1967 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1968 as modifiers.
1969 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1970
1971 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1972 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1973 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1974 presumably because the widths might not match.
1975
1976 * window.c (size_window): Avoid needless test at loop start.
1977
1978 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1979
1980 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1981
1982 2011-05-12 Drew Adams <drew.adams@oracle.com>
1983
1984 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1985
1986 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1987
1988 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1989 `width' to `bar_area_x' and `bar_area_width', respectively.
1990 (x_scroll_run): Take account of fringe background extension.
1991
1992 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1993 Rename local vars `left' and `width' to `bar_area_x' and
1994 `bar_area_width', respectively.
1995 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1996 background extension.
1997
1998 2011-05-10 Jim Meyering <meyering@redhat.com>
1999
2000 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2001
2002 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2003
2004 * image.c (Finit_image_library): Return t for built-in image types,
2005 like pbm and xbm. (Bug#8640)
2006
2007 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2008
2009 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2010
2011 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2012
2013 * w32console.c (Fset_screen_color): Doc fix.
2014 (Fget_screen_color): New function.
2015 (syms_of_ntterm): Defsubr it.
2016
2017 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2018 unlink the temporary file if Fcall_process didn't create it in the
2019 first place.
2020 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2021 child process will be redirected to a file specified with `:file'.
2022 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2023 cue to call_process_cleanup not to close that handle.
2024
2025 2011-05-07 Ben Key <bkey76@gmail.com>
2026
2027 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2028 one of two shell specific rules, either bootstrap-temacs-CMD or
2029 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2030 to the previous implementation of the bootstrap-temacs rule.
2031 The bootstrap-temacs-CMD rule is similar to the previous
2032 implementation of the bootstrap-temacs rule except that it
2033 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2034 variable.
2035
2036 These changes, along with some changes to nt/configure.bat,
2037 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2038 earlier fix to add support for --cflags and --ldflags options
2039 that include quotes so that it works whether make uses cmd or
2040 sh as the shell.
2041
2042 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2043
2044 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2045 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2046 is a constant.
2047 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2048 a string. Handle both cases.
2049 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2050 (Fdbus_register_method): Use Qinvalid_function.
2051
2052 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2053
2054 * makefile.w32-in: Update dependencies.
2055 (LISP_H): Add inttypes.h and stdin.h.
2056 (PROCESS_H): Add unistd.h.
2057
2058 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2059
2060 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2061 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2062
2063 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2066
2067 * term.c (vfatal): Remove stray call to va_end.
2068 It's not needed and the C Standard doesn't allow it here anyway.
2069
2070 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2071 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2072
2073 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2074 bytes.
2075
2076 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2077
2078 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2079
2080 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2081
2082 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2083
2084 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2085
2086 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2087 * charset.c (Fdefine_charset_internal): Don't initialize
2088 charset.code_space[15]. The value was garbage, on hosts with
2089 32-bit int (Bug#8600).
2090
2091 * lread.c (read_integer): Be more consistent with string-to-number.
2092 Use string_to_number to do the actual conversion; this avoids
2093 rounding errors and fixes some other screwups. Without this fix,
2094 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2095 (digit_to_number): Move earlier, for benefit of read_integer.
2096 Return -1 if the digit is out of range for the base, -2 if it is
2097 not a digit in any supported base. (Bug#8602)
2098
2099 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2100
2101 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2102 to match comment at start of function. This also removes a
2103 GCC warning about overflow in a 32+64-bit port.
2104
2105 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2106
2107 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2108 Reported by Stefan Monnier in
2109 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2110 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2111 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2112
2113 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2114 (EMACS_UINTPTR): Likewise, with uintptr_t.
2115
2116 * lisp.h: Prefer 64-bit EMACS_INT if available.
2117 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2118 on 32-bit hosts that have 64-bit int, so that they can access
2119 large files.
2120 However, temporarily disable this change unless the temporary
2121 symbol WIDE_EMACS_INT is defined.
2122
2123 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2124
2125 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2126 This removes an assumption that EMACS_INT and long are the same
2127 width as pointers. The assumption is true for Emacs porting targets
2128 now, but we want to make other targets possible.
2129 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2130 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2131 In the rest of the code, change types of integers that hold casted
2132 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2133 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2134 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2135 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2136 No need to cast type when ORing.
2137 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2138 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2139 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2140 assume EMACS_INT is the same width as char *.
2141 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2142 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2143 Remove no-longer-needed casts.
2144 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2145 (xg_tool_bar_help_callback, xg_make_tool_item):
2146 Use EMACS_INTPTR to hold an integer
2147 that will be cast to void *; this can avoid a GCC warning
2148 if EMACS_INT is not the same width as void *.
2149 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2150 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2151 (current_message_1, set_message_1):
2152 Use a local to convert to proper width without a cast.
2153 * xmenu.c (dialog_selection_callback): Likewise.
2154
2155 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2156 Also, don't assume VALBITS / RAND_BITS is less than 5,
2157 and don't rely on undefined behavior when shifting a 1 left into
2158 the sign bit.
2159 * lisp.h (get_random): Change signature to match.
2160
2161 * lread.c (hash_string): Use size_t, not int, for hash computation.
2162 Normally we prefer signed values; but hashing is special, because
2163 it's better to use unsigned division on hash table sizes so that
2164 the remainder is nonnegative. Also, size_t is the natural width
2165 for hashing into memory. The previous code used 'int', which doesn't
2166 retain enough info to hash well into very large tables.
2167 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2168
2169 * dbusbind.c: Don't possibly lose pointer info when converting.
2170 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2171 Use XPNTR rather than XHASH, so that the high-order bits of
2172 the pointer aren't lost when converting through void *.
2173
2174 * eval.c (Fautoload): Don't double-shift a pointer.
2175
2176 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2177
2178 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2179
2180 * gnutls.c (DEF_GNUTLS_FN):
2181 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2182
2183 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2184
2185 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2186 marker. (Bug#8610)
2187
2188 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2189
2190 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2191 New version that can reserve upto 2GB of heap space.
2192
2193 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2196
2197 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2198
2199 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2200 `gnutls_certificate_set_x509_key_file'.
2201
2202 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2203
2204 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2205 Update dependencies.
2206
2207 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2210 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2211 Remove unused parameter `fildes'.
2212 * process.c (read_process_output, send_process): Don't pass it.
2213
2214 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2215
2216 Fix previous change: the library cache is defined in w32.c.
2217 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2218 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2219
2220 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2221
2222 Implement dynamic loading of GnuTLS on Windows.
2223
2224 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2225 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2226 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2227 Declare.
2228
2229 * gnutls.c (Qgnutls_dll): Define.
2230 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2231 (gnutls_*): Declare function pointers.
2232 (init_gnutls_functions): New function to initialize function pointers.
2233 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2234 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2235 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2236 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2237 (emacs_gnutls_write, emacs_gnutls_read)
2238 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2239 (Fgnutls_available_p): New function.
2240 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2241 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2242 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2243
2244 * image.c: Include w32.h.
2245 (Vimage_type_cache): Delete.
2246 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2247 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2248 (w32_delayed_load): Move to w32.c.
2249
2250 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2251
2252 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2253 (w32_delayed_load): Move from image.c. When loading a library, record
2254 its filename in the :loaded-from property of the library id.
2255 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2256 Initialize and staticpro them.
2257 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2258
2259 * process.c: Include lisp.h before w32.h, not after.
2260 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2261 instead of gnutls_record_check_pending.
2262
2263 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2264
2265 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2266
2267 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2268 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2269 as passed in.
2270
2271 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2272
2273 * xterm.c (x_set_frame_alpha): Do not set property on anything
2274 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2275
2276 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2277
2278 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2279
2280 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2281
2282 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2283 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2284 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2285 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2286 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2287 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2288 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2289 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2290 (Qgnutls_bootprop_callbacks_verify): Make static.
2291
2292 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2293
2294 * callproc.c: Indentation fixup.
2295
2296 * sysdep.c (wait_for_termination_1): Make static.
2297 (wait_for_termination, interruptible_wait_for_termination):
2298 Move after wait_for_termination_1.
2299
2300 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2301
2302 * sysdep.c (interruptible_wait_for_termination): New function
2303 which is like wait_for_termination, but allows keyboard
2304 interruptions.
2305
2306 * callproc.c (Fcall_process): Add (:file "file") as an option for
2307 the STDOUT buffer.
2308 (Fcall_process_region): Ditto.
2309
2310 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2311
2312 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2313 rather than `XVECTOR (FOO)->size'.
2314
2315 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2316 inttypes.h, as a gnulib replacement is used if it not available in
2317 system headers.
2318
2319 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2320
2321 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2322 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2323 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2324
2325 * coding.c (coding_alloc_by_realloc): Error out if destination
2326 will grow beyond MOST_POSITIVE_FIXNUM.
2327 (decode_coding_emacs_mule): Abort if there isn't enough place in
2328 charbuf for the composition carryover bytes. Reserve an extra
2329 space for up to 2 characters produced in a loop.
2330 (decode_coding_iso_2022): Abort if there isn't enough place in
2331 charbuf for the composition carryover bytes.
2332
2333 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2334
2335 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2336 aborting when %lld or %lll format is passed.
2337 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2338 %llo or %llx format is passed. (Bug#8545)
2339
2340 * window.c (window_scroll_line_based): Use a marker instead of
2341 simple variables to record original value of point. (Bug#7952)
2342
2343 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2344 produced by %s or %c overflows available buffer space. (Bug#8545)
2345
2346 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2347
2348 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2349 (SIZE_MAX): Move defn after all includes, as they might #define it.
2350
2351 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2352
2353 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2354
2355 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2356
2357 * keyboard.c (Qdelayed_warnings_hook): Define.
2358 (command_loop_1): Run `delayed-warnings-hook'
2359 if Vdelayed_warnings_list is non-nil.
2360 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2361 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2362
2363 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2364
2365 * doprnt.c (doprnt): Don't return value smaller than the buffer
2366 size if the message was truncated. (Bug#8545).
2367
2368 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2369
2370 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2371 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2372
2373 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2376
2377 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2378
2379 * makefile.w32-in: Update dependencies.
2380
2381 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2382
2383 Improve `doprnt' and its usage. (Bug#8545)
2384 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2385 `format_end'. Remove support for %l as a conversion specifier.
2386 Don't use xrealloc. Improve diagnostics when the %l size modifier
2387 is used. Update the commentary.
2388
2389 * eval.c (verror): Simplify calculation of size_t.
2390
2391 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2392 messages.
2393
2394 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2395
2396 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2397 change.
2398
2399 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2402 This makes this file independent of the recent pseudovector change.
2403
2404 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2407
2408 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2409 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2410 Remove unused local.
2411 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2412
2413 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2414 GCC 4.6.0 optimizes based on type-based alias analysis.
2415 For example, if b is of type struct buffer * and v of type struct
2416 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2417 != &v->size, and therefore "v->size = 1; b->size = 2; return
2418 v->size;" must therefore return 1. This assumption is incorrect
2419 for Emacs, since it type-puns struct Lisp_Vector * with many other
2420 types. To fix this problem, this patch adds a new type struct
2421 vectorlike_header that documents the constraints on layout of vectors
2422 and pseudovectors, and helps optimizing compilers not get fooled
2423 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2424 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2425 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2426 the size member.
2427 (XSETPVECTYPE): Rewrite in terms of new macro.
2428 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2429 This is a bit clearer, and further avoids the possibility of
2430 undesirable aliasing.
2431 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2432 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2433 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2434 since Lisp_Subr is a special case (no "next" field).
2435 (ASIZE): Now uses header.size rather than size.
2436 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2437 to avoid the hassle of writing XVECTOR (foo)->header.size.
2438 (struct vectorlike_header): New type.
2439 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2440 object, to help avoid aliasing.
2441 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2442 (SUBRP): Likewise, since Lisp_Subr is a special case.
2443 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2444 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2445 (struct Lisp_Hash_Table): Combine first two members into a single
2446 struct vectorlike_header member. All uses of "size" and "next" members
2447 changed to be "header.size" and "header.next".
2448 * buffer.h (struct buffer): Likewise.
2449 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2450 * frame.h (struct frame): Likewise.
2451 * process.h (struct Lisp_Process): Likewise.
2452 * termhooks.h (struct terminal): Likewise.
2453 * window.c (struct save_window_data, struct saved_window): Likewise.
2454 * window.h (struct window): Likewise.
2455 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2456 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2457 * buffer.c (init_buffer_once): Likewise.
2458 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2459 special case.
2460 * process.c (Fformat_network_address): Use local var for size,
2461 for brevity.
2462
2463 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2464
2465 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2466 * data.c (atof): Remove decl; no longer used or needed.
2467 (digit_to_number): Move to lread.c.
2468 (Fstring_to_number): Use new string_to_number function, to be
2469 consistent with how the Lisp reader treats infinities and NaNs.
2470 Do not assume that floating-point numbers represent EMACS_INT
2471 without losing information; this is not true on most 64-bit hosts.
2472 Avoid double-rounding errors, by insisting on integers when
2473 parsing non-base-10 numbers, as the documentation specifies.
2474 * lisp.h (string_to_number): New decl, replacing ...
2475 (isfloat_string): Remove.
2476 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2477 (read1): Do not accept +. and -. as integers; this
2478 appears to have been a coding error. Similarly, do not accept
2479 strings like +-1e0 as floating point numbers. Do not report
2480 overflow for integer overflows unless the base is not 10 which
2481 means we have no simple and reliable way to continue.
2482 Break out the floating-point parsing into a new
2483 function string_to_number, so that Fstring_to_number parses
2484 floating point numbers consistently with the Lisp reader.
2485 (digit_to_number): Move here from data.c. Make it static inline.
2486 (E_CHAR, EXP_INT): Remove, replacing with ...
2487 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2488 (string_to_number): New function, replacing isfloat_string.
2489 This function checks for valid syntax and produces the resulting
2490 Lisp float number too. Rework it so that string-to-number
2491 no longer mishandles examples like "1.0e+". Use strtoumax,
2492 so that overflow for non-base-10 numbers is reported only when
2493 there's no portable and simple way to convert to floating point.
2494
2495 * textprop.c (set_text_properties_1): Rewrite for clarity,
2496 and to avoid GCC warning about integer overflow.
2497
2498 * intervals.h (struct interval): Use EMACS_INT for members
2499 where EMACS_UINT might cause problems. See
2500 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2501 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2502 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2503 All uses changed.
2504 (offset_intervals): Tell GCC not to worry about length overflow
2505 when negating a negative length.
2506
2507 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2508 (overrun_check_free): Likewise.
2509
2510 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2511 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2512 word size.
2513
2514 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2515 (gnutls_make_error): Rename local to avoid shadowing.
2516 (gnutls_emacs_global_deinit): ifdef out; not used.
2517 (Fgnutls_boot): Use const for pointer to readonly storage.
2518 Comment out unused local. Fix pointer signedness problems.
2519
2520 * lread.c (openp): Don't stuff size_t into an 'int'.
2521 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2522 about possible signed overflow.
2523
2524 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2525 (GDK_KEY_g): Don't define if already defined.
2526 (xg_prepare_tooltip): Avoid pointer signedness problem.
2527 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2528
2529 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2530 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2531
2532 * xfns.c (Fx_window_property): Simplify a bit,
2533 to make a bit faster and to avoid GCC 4.6.0 warning.
2534 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2535
2536 * fns.c (internal_equal): Don't assume size_t fits in int.
2537
2538 * alloc.c (compact_small_strings): Tighten assertion a little.
2539
2540 Replace pEd with more-general pI, and fix some printf arg casts.
2541 * lisp.h (pI): New macro, generalizing old pEd macro to other
2542 conversion specifiers. For example, use "...%"pI"d..." rather
2543 than "...%"pEd"...".
2544 (pEd): Remove. All uses replaced with similar uses of pI.
2545 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2546 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2547 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2548 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2549 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2550 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2551 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2552 64-bit hosts.
2553 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2554 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2555 * print.c (safe_debug_print, print_object): Likewise.
2556 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2557 to int.
2558 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2559 avoiding the 0 flag, which is not portable.
2560 * process.c (Fmake_network_process): Use pI to avoid cast.
2561 * region-cache.c (pp_cache): Likewise.
2562 * xdisp.c (decode_mode_spec): Likewise.
2563 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2564 behavior on 64-bit hosts with printf arg.
2565 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2566 (x_stop_queuing_selection_requests): Likewise.
2567 (x_get_window_property): Don't truncate byte count to an 'int'
2568 when tracing.
2569
2570 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2571 here, since it parses constructs like leading '-' and spaces,
2572 which are not wanted; and it overflows with large numbers.
2573 Instead, simply match F[0-9]+, which is what is wanted anyway.
2574
2575 * alloc.c: Remove unportable assumptions about struct layout.
2576 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2577 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2578 (allocate_vectorlike, make_pure_vector): Use the new macros,
2579 plus offsetof, to remove unportable assumptions about struct layout.
2580 These assumptions hold on all porting targets that I know of, but
2581 they are not guaranteed, they're easy to remove, and removing them
2582 makes further changes easier.
2583
2584 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2585 This doesn't fix a bug but makes the code clearer.
2586 (string_overrun_cookie): Now const. Use initializers that
2587 don't formally overflow signed char, to avoid warnings.
2588 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2589 can cause Emacs to crash when string overrun checking is enabled.
2590 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2591 multiple of sizeof (EMACS_INT); it need not be, if
2592 alignof(EMACS_INT) < sizeof (EMACS_INT).
2593 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2594
2595 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2598
2599 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2600
2601 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2602 supposed to be handshaking. (Bug#8556)
2603 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2604
2605 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2606
2607 * lisp.h (Qdebug): List symbol.
2608 * eval.c (Qdebug): Restore global linkage.
2609 * keyboard.c (debug-on-event): New variable.
2610 (handle_user_signal): Break into debugger when debug-on-event
2611 matches the current signal symbol.
2612
2613 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2614
2615 * alloc.c (check_sblock, check_string_bytes)
2616 (check_string_free_list): Convert to standard C.
2617
2618 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2619
2620 * w32.c (emacs_gnutls_push): Fix typo.
2621
2622 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2623
2624 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2625 "cast to pointer from integer of different size".
2626
2627 Improve doprnt and its use in verror. (Bug#8545)
2628 * doprnt.c (doprnt): Document the set of format control sequences
2629 supported by the function. Use SAFE_ALLOCA instead of always
2630 using `alloca'.
2631
2632 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2633 is one byte too soon. Don't use xrealloc; instead xfree and
2634 xmalloc anew.
2635
2636 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2637
2638 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2639 callbacks stage.
2640
2641 * gnutls.c: Renamed global_initialized to
2642 gnutls_global_initialized. Added internals for the
2643 :verify-hostname-error, :verify-error, and :verify-flags
2644 parameters of `gnutls-boot' and documented those parameters in the
2645 docstring. Start callback support.
2646 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2647 unless a fatal error occured. Call gnutls_alert_send_appropriate
2648 on error. Return error code.
2649 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2650 (emacs_gnutls_read): Likewise.
2651 (Fgnutls_boot): Return handshake error code.
2652 (emacs_gnutls_handle_error): New function.
2653 (wsaerror_to_errno): Likewise.
2654
2655 * w32.h (emacs_gnutls_pull): Add prototype.
2656 (emacs_gnutls_push): Likewise.
2657
2658 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2659 (emacs_gnutls_push): Likewise.
2660
2661 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2662
2663 * process.c (wait_reading_process_output): Check if GnuTLS
2664 buffered some data internally if no FDs are set for TLS
2665 connections.
2666
2667 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2668 (LIBS): Link to USER_LIBS.
2669 ($(BLD)/gnutls.$(0)): New target.
2670
2671 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2672
2673 * xdisp.c (handle_single_display_spec): Rename the
2674 display_replaced_before_p argument into display_replaced_p, to
2675 make it consistent with the commentary. Fix typos in the
2676 commentary.
2677
2678 * textprop.c (syms_of_textprop): Remove dead code.
2679 (copy_text_properties): Delete obsolete commentary about an
2680 interface that was deleted long ago. Fix typos in the description
2681 of arguments.
2682
2683 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2684 to changes in oldXMenu/XMenu.h from 2011-04-16.
2685 <menu_help_message, prev_menu_help_message>: Constify.
2686 (IT_menu_make_room): menu->help_text is now `const char **';
2687 adjust.
2688
2689 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2690 to changes in oldXMenu/XMenu.h from 2011-04-16.
2691 (struct XMenu): Declare `help_text' `const char **'.
2692
2693 * xfaces.c <Qunspecified>: Make extern again.
2694
2695 * syntax.c: Include sys/types.h before including regex.h, as
2696 required by Posix.
2697
2698 * doc.c (get_doc_string): Improve the format passed to `error'.
2699
2700 * doprnt.c (doprnt): Improve commentary.
2701
2702 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2703
2704 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2705 them with etags.
2706
2707 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2708 changes in globals.h immediately force recompilation.
2709 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2710 $(CURDIR)/s/ms-w32.h.
2711 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2712
2713 * character.c (Fchar_direction): Function deleted.
2714 (syms_of_character): Don't defsubr it.
2715 <char-direction-table>: Deleted.
2716
2717 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2718
2719 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2720 * doprnt.c: Include limits.h.
2721 (SIZE_MAX): New macro.
2722 (doprnt): Return a size_t value. 2nd arg is now size_t.
2723 Many local variables are now size_t instead of int or unsigned.
2724 Improve overflow protection. Support `l' modifier for integer
2725 conversions. Support %l conversion. Don't assume an EMACS_INT
2726 argument for integer conversions and for %c.
2727
2728 * lisp.h (doprnt): Restore prototype.
2729
2730 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2731 $(SRC)/character.h.
2732
2733 * Makefile.in (base_obj): Add back doprnt.o.
2734
2735 * deps.mk (doprnt.o): Add back prerequisites.
2736 (callint.o): Depend on character.h.
2737
2738 * eval.c (internal_lisp_condition_case): Include the handler
2739 representation in the error message.
2740 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2741 when breaking from the loop.
2742
2743 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2744
2745 * callint.c (Fcall_interactively): When displaying error message
2746 about invalid control letter, pass the character's codepoint, not
2747 a pointer to its multibyte form. Improve display of the character
2748 in octal and display also its hex code.
2749
2750 * character.c (char_string): Use %x to display the (unsigned)
2751 codepoint of an invalid character, to avoid displaying a bogus
2752 negative value.
2753
2754 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2755 `error', not SYMBOL_NAME itself.
2756
2757 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2758 character arguments to `error'.
2759
2760 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2761 to `error' in error message about FINAL_CHAR argument. Make sure
2762 FINAL_CHAR is a character, and use %c when it is passed as
2763 argument to `error'.
2764
2765 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2766
2767 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2768
2769 * w32.c: Include <time.h>.
2770 (sys_localtime): New function.
2771
2772 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2773
2774 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2775
2776 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2777
2778 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2779
2780 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2781 zombies (Bug#8467).
2782
2783 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2784
2785 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2786 gl_state.e_property when gl_state.object is Qt.
2787
2788 * insdel.c (make_gap_larger): Remove limitation of buffer size
2789 to <= INT_MAX.
2790
2791 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2792
2793 * xdisp.c (lookup_glyphless_char_display)
2794 (produce_glyphless_glyph): Handle cons cell entry in
2795 glyphless-char-display.
2796 (Vglyphless_char_display): Document it.
2797
2798 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2799 glyphless-char-display.
2800
2801 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2802
2803 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2804
2805 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2806
2807 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2808 definition for no-X builds.
2809
2810 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2811
2812 Static checks with GCC 4.6.0 and non-default toolkits.
2813
2814 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2815
2816 * process.c (keyboard_bit_set): Define only if SIGIO.
2817 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2818 (send_process): Repair possible setjmp clobbering.
2819
2820 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2821
2822 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2823
2824 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2825
2826 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2827 Define only if needed.
2828
2829 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2830 by pacifying GCC about it. Maybe it's time to retire it?
2831 * xfaces.c (USG, __TIMEVAL__): Likewise.
2832
2833 * dispextern.h (struct redisplay_interface): Rename param
2834 to avoid shadowing.
2835 * termhooks.h (struct terminal): Likewise.
2836 * xterm.c (xembed_send_message): Likewise.
2837
2838 * insdel.c (make_gap_smaller): Define only if
2839 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2840
2841 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2842 it.
2843
2844 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2845 so that we aren't warned about unused symbols.
2846
2847 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2848
2849 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2850
2851 * xfns.c (x_real_positions): Mark locals as initialized.
2852
2853 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2854
2855 * xterm.c: Fix problems found by static analysis with other toolkits.
2856 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2857 (x_dispatch_event): Declare static if USE_GTK, and
2858 define if USE_GTK || USE_X_TOOLKIT.
2859 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2860 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2861 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2862 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2863
2864 * xmenu.c (menu_help_callback): Pointer type fixes.
2865 Use const pointers when pointing at readonly data. Avoid pointer
2866 signedness clashes.
2867 (FALSE): Remove unused macro.
2868 (update_frame_menubar): Remove unused decl.
2869
2870 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2871
2872 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2873 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2874 (single_menu_item): Rename local to avoid shadowing.
2875
2876 * keyboard.c (make_lispy_event): Remove unused local var.
2877
2878 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2879 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2880
2881 * bitmaps: Change bitmaps from unsigned char back to the X11
2882 compatible char. Avoid the old compiler warnings about
2883 out-of-range initializers by using, for example, '\xab' rather
2884 than 0xab.
2885
2886 * xgselect.c (xgselect_initialize): Check vs interface
2887 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2888
2889 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2890
2891 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2892 to read-only memory.
2893
2894 * fns.c (vector): Remove; this old hack is no longer needed.
2895
2896 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2897 Remove unused var.
2898 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2899
2900 * xrdb.c (x_load_resources): Omit unused local.
2901
2902 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2903 (x_window): Rename locals to avoid shadowing.
2904 (USG): Use the kludged USG macro, to pacify gcc.
2905
2906 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2907 (x_term_init): Remove local to avoid shadowing.
2908
2909 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2910
2911 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2912 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2913
2914 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2915
2916 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2917
2918 Fix regex.c, syntax.c and friends for buffers > 2GB.
2919 * syntax.h (struct gl_state_s): Declare character position members
2920 EMACS_INT.
2921
2922 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2923
2924 * textprop.c (verify_interval_modification, interval_of):
2925 Declare arguments EMACS_INT.
2926
2927 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2928 EMACS_INT.
2929
2930 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2931
2932 * indent.c (Fvertical_motion): Local variable it_start is now
2933 EMACS_INT.
2934
2935 * regex.c (re_match, re_match_2, re_match_2_internal)
2936 (bcmp_translate, regcomp, regexec, print_double_string)
2937 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2938 (re_compile_pattern, re_exec): Declare arguments and local
2939 variables `size_t' and `ssize_t' and return values `regoff_t', as
2940 appropriate.
2941 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2942 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2943 <compile_stack_type>: `size' and `avail' are now `size_t'.
2944
2945 * regex.h <regoff_t>: Use ssize_t, not int.
2946 (re_search, re_search_2, re_match, re_match_2): Arguments that
2947 specify buffer/string position and length are now ssize_t and
2948 size_t. Return type is regoff_t.
2949
2950 2011-04-16 Ben Key <bkey76@gmail.com>
2951
2952 * nsfont.m: Fixed bugs in ns_get_family and
2953 ns_descriptor_to_entity that were caused by using free to
2954 deallocate memory blocks that were allocated by xmalloc (via
2955 xstrdup). This caused Emacs to crash when compiled with
2956 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2957 --enable-checking=xmallocoverrun). xfree is now used to
2958 deallocate these memory blocks.
2959
2960 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2963
2964 emacs_write: Accept and return EMACS_INT for sizes.
2965 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2966 et seq.
2967 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2968 Accept and return EMACS_INT.
2969 (emacs_gnutls_write): Return the number of bytes written on
2970 partial writes.
2971 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2972 (emacs_read, emacs_write): Remove check for negative size, as the
2973 Emacs source code has been audited now.
2974 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2975 (emacs_read, emacs_write): Use it.
2976 * process.c (send_process): Adjust to the new signatures of
2977 emacs_write and emacs_gnutls_write. Do not attempt to store
2978 a byte offset into an 'int'; it might overflow.
2979 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2980
2981 * sound.c: Don't assume sizes fit in 'int'.
2982 (struct sound_device.period_size, alsa_period_size):
2983 Return EMACS_INT, not int.
2984 (struct sound_device.write, vox_write, alsa_write):
2985 Accept EMACS_INT, not int.
2986 (wav_play, au_play): Use EMACS_INT to store sizes and to
2987 record read return values.
2988
2989 2011-04-15 Ben Key <bkey76@gmail.com>
2990
2991 * keyboard.c (Qundefined): Don't declare static since it is used
2992 in nsfns.m.
2993 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2994 static since they are used in nsfont.m.
2995
2996 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2997
2998 * process.c (Qprocessp): Don't declare static.
2999 * lisp.h (Qprocessp): Declare again.
3000
3001 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3002
3003 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3004
3005 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 Improve C-level modularity by making more things 'static'.
3008
3009 Don't publish debugger-only interfaces to other modules.
3010 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3011 (verify_bytepos, count_markers): Move decls to the only modules
3012 that need them.
3013 * region-cache.h (pp_cache): Likewise.
3014 * window.h (check_all_windows): Likewise.
3015 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3016
3017 * sysdep.c (croak): Now static, if
3018 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3019 * syssignal.h (croak): Declare only if not static.
3020
3021 * alloc.c (refill_memory_reserve): Now static if
3022 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3023 * lisp.h (refill_memory_reserve): Declare only if not static.
3024
3025 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3026 Define only if USE_LUCID.
3027
3028 * xrdb.c (x_customization_string, x_rm_string): Now static.
3029
3030 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3031 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3032
3033 * xdisp.c (draw_row_with_mouse_face): Now static.
3034 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3035
3036 * window.h (check_all_windows): Mark externally visible.
3037
3038 * window.c (window_deletion_count): Now static.
3039
3040 * undo.c: Make symbols static if they're not exported.
3041 (last_undo_buffer, last_boundary_position, pending_boundary):
3042 Now static.
3043
3044 * textprop.c (interval_insert_behind_hooks): Now static.
3045 (interval_insert_in_front_hooks): Likewise.
3046
3047 * term.c: Make symbols static if they're not exported.
3048 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3049 (max_frame_lines, tty_set_terminal_modes):
3050 (tty_reset_terminal_modes, tty_turn_off_highlight):
3051 (get_tty_terminal): Now static.
3052 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3053 * termhooks.h (term_mouse_moveto): Do not declare if
3054 HAVE_WINDOW_SYSTEM.
3055 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3056 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3057
3058 * sysdep.c: Make symbols static if they're not exported.
3059 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3060 Now static.
3061 (sigprocmask_set, full_mask): Remove; unused.
3062 (wait_debugging): Mark as visible.
3063 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3064 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3065
3066 * syntax.c (syntax_temp): Define only if !__GNUC__.
3067
3068 * sound.c (current_sound_device, current_sound): Now static.
3069
3070 * search.c (searchbufs, searchbuf_head): Now static.
3071
3072 * scroll.c (scroll_cost): Remove; unused.
3073 * dispextern.h (scroll_cost): Remove decl.
3074
3075 * region-cache.h (pp_cache): Mark as externally visible.
3076
3077 * process.c: Make symbols static if they're not exported.
3078 (process_tick, update_tick, create_process, chan_process):
3079 (Vprocess_alist, proc_buffered_char, datagram_access):
3080 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3081 (deactivate_process): Mark defn as static, as well as decl.
3082 * lisp.h (create_process): Remove decl.
3083 * process.h (chan_process, Vprocess_alist): Remove decls.
3084
3085 * print.c: Make symbols static if they're not exported.
3086 (print_depth, new_backquote_output, being_printed, print_buffer):
3087 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3088 (print_interval, print_number_index, initial_stderr_stream):
3089 Now static.
3090 * lisp.h (Fprinc): Remove decl.
3091 (debug_output_compilation_hack): Mark as externally visible.
3092
3093 * sysdep.c (croak): Move decl from here to syssignal.h.
3094 * syssignal.h (croak): Put it here, so the API can be checked when
3095 'croak' is called from dissociate_if_controlling_tty.
3096
3097 * minibuf.c: Make symbols static if they're not exported.
3098 (minibuf_save_list, choose_minibuf_frame): Now static.
3099 * lisp.h (choose_minibuf_frame): Remove decl.
3100
3101 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3102
3103 * lread.c: Make symbols static if they're not exported.
3104 (read_objects, initial_obarray, oblookup_last_bucket_number):
3105 Now static.
3106 (make_symbol): Remove; unused.
3107 * lisp.h (initial_obarray, make_symbol): Remove decls.
3108
3109 * keyboard.c: Make symbols static if they're not exported.
3110 (single_kboard, recent_keys_index, total_keys, recent_keys):
3111 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3112 (this_single_command_key_start, echoing, last_auto_save):
3113 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3114 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3115 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3116 (Vlispy_mouse_stem, double_click_count):
3117 Now static.
3118 (force_auto_save_soon): Define only if SIGDANGER.
3119 (ignore_mouse_drag_p): Now static if
3120 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3121 (print_help): Remove; unused.
3122 (stop_character, last_timer_event): Mark as externally visible.
3123 * keyboard.h (ignore_mouse_drag_p): Declare only if
3124 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3125 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3126 * lisp.h (echoing): Remove decl.
3127 (force_auto_save_soon): Declare only if SIGDANGER.
3128 * xdisp.c (redisplay_window): Simplify code, to make it more
3129 obvious that ignore_mouse_drag_p is not accessed if !defined
3130 USE_GTK && !defined HAVE_NS.
3131
3132 * intervals.c: Make symbols static if they're not exported.
3133 (merge_properties_sticky, merge_interval_right, delete_interval):
3134 Now static.
3135 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3136
3137 * insdel.c: Make symbols static if they're not exported.
3138 However, leave prepare_to_modify_buffer alone. It's never
3139 called from outside this function, but that appears to be a bug.
3140 (combine_after_change_list, combine_after_change_buffer):
3141 (adjust_after_replace, signal_before_change): Now static.
3142 (adjust_after_replace_noundo): Remove; unused.
3143 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3144 (signal_before_change): Remove decls.
3145
3146 * indent.c (val_compute_motion, val_vmotion): Now static.
3147
3148 * image.c: Make symbols static if they're not exported.
3149 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3150 if USE_GTK.
3151 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3152 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3153
3154 * fringe.c (standard_bitmaps): Now static.
3155 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3156
3157 * frame.c: Make symbols static if they're not exported.
3158 (x_report_frame_params, make_terminal_frame): Now static.
3159 (get_frame_param): Now static, unless HAVE_NS.
3160 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3161 (x_get_resource_string): Remove; not used.
3162 * frame.h (make_terminal_frame, x_report_frame_params):
3163 (x_get_resource_string); Remove decls.
3164 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3165 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3166
3167 * font.c, fontset.c: Make symbols static if they're not exported.
3168 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3169 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3170 * font.c (font_close_object): Now static.
3171 * font.h (font_close_object): Remove.
3172 * fontset.c (FONTSET_OBJLIST): Remove.
3173 (free_realized_fontset) #if-0 the body, which does nothing.
3174 (face_suitable_for_char_p): #if-0, as it's never called.
3175 * fontset.h (face_suitable_for_char_p): Remove decl.
3176 * xfaces.c (face_at_string_position):
3177 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3178 since 0 is always ASCII.
3179
3180 * fns.c (weak_hash_tables): Now static.
3181
3182 * fileio.c: Make symbols static if they're not exported.
3183 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3184 (Vwrite_region_annotation_buffers): Now static.
3185
3186 * eval.c: Make symbols static if they're not exported.
3187 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3188 * lisp.h (backtrace_list): Remove decl.
3189
3190 * emacs.c: Make symbols static if they're not exported.
3191 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3192 (fatal_error_code, fatal_error_signal_hook, standard_args):
3193 Now static.
3194 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3195 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3196 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3197 * lisp.h (fatal_error_signal_hook): Remove decl.
3198 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3199
3200 * editfns.c: Move a (normally-unused) function to its only use.
3201 * editfns.c, lisp.h (get_operating_system_release): Remove.
3202 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3203 worth the hassle of breaking this out.
3204
3205 * xterm.c: Make symbols static if they're not exported.
3206 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3207 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3208 (x_destroy_window, x_delete_display):
3209 Now static.
3210 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3211 (x_mouse_leave): Remove; unused.
3212 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3213 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3214 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3215 Remove decls.
3216 (x_mouse_leave): Declare only if WINDOWSNT.
3217 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3218 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3219 USE_X_TOOLKIT.
3220
3221 * ftxfont.c: Make symbols static if they're not exported.
3222 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3223 HAVE_FREETYPE.
3224 * font.h (ftxfont_driver): Likewise.
3225
3226 * xfns.c: Make symbols static if they're not exported.
3227 (x_last_font_name, x_display_info_for_name):
3228 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3229 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3230 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3231 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3232 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3233 (last_show_tip_args): Now static.
3234 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3235 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3236 (x_screen_planes): Remove; unused.
3237 * dispextern.h (x_screen_planes): Remove decl.
3238
3239 * dispnew.c: Make symbols static if they're not exported.
3240 * dispextern.h (redraw_garbaged_frames, scrolling):
3241 (increment_row_positions): Remove.
3242 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3243 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3244 Now static.
3245 (redraw_garbaged_frames): Remove; unused.
3246
3247 * xfaces.c: Make symbols static if they're not exported.
3248 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3249 Remove decls.
3250 * xterm.h (defined_color): Remove decls.
3251 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3252 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3253 (menu_face_changed_default, defined_color, free_realized_face):
3254 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3255 (ascii_face_of_lisp_face): Remove; unused.
3256
3257 * xdisp.c: Make symbols static if they're not exported.
3258 * dispextern.h (scratch_glyph_row, window_box_edges):
3259 (glyph_to_pixel_coords, set_cursor_from_row):
3260 (get_next_display_element, set_iterator_to_next):
3261 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3262 (show_mouse_face): Remove decls
3263 * frame.h (message_buf_print): Likewise.
3264 * lisp.h (pop_message, set_message, check_point_in_composition):
3265 Likewise.
3266 * xterm.h (set_vertical_scroll_bar): Likewise.
3267 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3268 (message_buf_print, scratch_glyph_row, displayed_buffer):
3269 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3270 (get_next_display_element, show_mouse_face, window_box_edges):
3271 (frame_to_window_pixel_xy, check_point_in_composition):
3272 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3273 (glyph_to_pixel_coords): Remove; unused.
3274
3275 * dired.c (file_name_completion): Now static.
3276
3277 * dbusbind.c (xd_in_read_queued_messages): Now static.
3278
3279 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3280 * data.c (circular_list_error): Remove.
3281
3282 * commands.h (last_point_position, last_point_position_buffer):
3283 (last_point_position_window): Remove decls.
3284 * keyboard.c: Make these variables static.
3285
3286 * coding.h (coding, code_convert_region, encode_coding_gap):
3287 Remove decls.
3288 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3289 (iso_code_class, detect_coding, code_convert_region): Now static.
3290 (encode_coding_gap): Remove; unused.
3291
3292 * chartab.c (chartab_chars, chartab_bits): Now static.
3293
3294 * charset.h (charset_iso_8859_1): Remove decl.
3295 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3296 Now static.
3297
3298 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3299 * ccl.c (Vccl_program_table): Now static.
3300 (check_ccl_update): Remove; unused.
3301
3302 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3303 * category.h: ... from here.
3304 * category.c (check_category_table, set_category_set): Now static.
3305
3306 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3307 * lisp.h: Remove these decls.
3308
3309 * buffer.c (buffer_count): Remove unused var.
3310
3311 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3312 so that it's not optimized away.
3313 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3314 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3315 exported only to the debugger.
3316
3317 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3318 * atimer.h (run_all_atimers): Remove; not exported.
3319
3320 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3321 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3322 was inaccessible from Lisp.
3323 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3324 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3325
3326 alloc.c: Import and export fewer symbols, and remove unused items.
3327 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3328 is defined.
3329 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3330 it's not optimized away by whole-program optimization.
3331 (message_enable_multibyte, free_misc): Remove.
3332 (catchlist, handlerlist, mark_backtrace):
3333 Declare only if BYTE_MARK_STACK.
3334 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3335 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3336 (message_enable_multibyte): Remove decl.
3337 (free_misc, interval_free_list, float_block, float_block_index):
3338 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3339 (cons_free_list, last_marked_index):
3340 Now static.
3341 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3342 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3343 (mark_backtrace): Define only if BYTE_MARK_STACK.
3344 * xdisp.c (message_enable_multibyte): Now static.
3345
3346 Declare Lisp_Object Q* variables to be 'static' if not exported.
3347 This makes it easier for human readers (and static analyzers)
3348 to see whether these variables are used from other modules.
3349 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3350 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3351 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3352 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3353 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3354 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3355 * xmenu.c, xselect.c:
3356 Declare Q* vars static if they are not used in other modules.
3357 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3358 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3359 Remove decls of unexported vars.
3360 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3361
3362 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3363
3364 Make Emacs functions such as Fatom 'static' by default.
3365 This makes it easier for human readers (and static analyzers)
3366 to see whether these functions can be called from other modules.
3367 DEFUN now defines a static function. To make the function external
3368 so that it can be used in other C modules, use the new macro DEFUE.
3369 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3370 (Finit_image_library):
3371 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3372 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3373 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3374 Remove decls, since these functions are now static.
3375 (Funintern, Fget_internal_run_time): New decls, since these functions
3376 were already external.
3377
3378 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3379 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3380 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3381 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3382 * keyboard.c, keymap.c, lread.c:
3383 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3384 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3385 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3386 Mark functions with DEFUE instead of DEFUN,
3387 if they are used in other modules.
3388 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3389 decls for now-static functions.
3390 * buffer.h (Fdelete_overlay): Remove decl.
3391 * callproc.c (Fgetenv_internal): Mark as internal.
3392 * composite.c (Fremove_list_of_text_properties): Remove decl.
3393 (Fcomposition_get_gstring): New forward static decl.
3394 * composite.h (Fcomposite_get_gstring): Remove decl.
3395 * dired.c (Ffile_attributes): New forward static decl.
3396 * doc.c (Fdocumntation_property): New forward static decl.
3397 * eval.c (Ffetch_bytecode): New forward static decl.
3398 (Funintern): Remove extern decl; now in .h file where it belongs.
3399 * fileio.c (Fmake_symbolic_link): New forward static decl.
3400 * image.c (Finit_image_library): New forward static decl.
3401 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3402 * intervals.h (Fprevious_property_change):
3403 (Fremove_list_of_text_properties): Remove decls.
3404 * keyboard.c (Fthis_command_keys): Remove decl.
3405 (Fcommand_execute): New forward static decl.
3406 * keymap.c (Flookup_key): New forward static decl.
3407 (Fcopy_keymap): Now static.
3408 * keymap.h (Flookup_key): Remove decl.
3409 * process.c (Fget_process): New forward static decl.
3410 (Fprocess_datagram_address): Mark as internal.
3411 * syntax.c (Fsyntax_table_p): New forward static decl.
3412 (skip_chars): Remove duplicate decl.
3413 * textprop.c (Fprevious_property_change): New forward static decl.
3414 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3415 Now internal.
3416 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3417 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3418
3419 * editfns.c (Fformat): Remove unreachable code.
3420
3421 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3422
3423 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3424 change. (Bug#8496)
3425
3426 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3427
3428 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3429 when at ZV. (Bug#8487)
3430
3431 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3432
3433 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3434 (Bug#8437)
3435 * keyboard.c (parse_tool_bar_item): Likewise.
3436 * sound.c (sound_cleanup, alsa_close): Likewise.
3437 * termcap.c (tgetent): Likewise.
3438 * xfns.c (x_default_font_parameter): Likewise.
3439 * xsettings.c (read_and_apply_settings): Likewise.
3440
3441 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3442 (overrun_check_free): Protoize.
3443
3444 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3445
3446 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3447 since callers should never pass a negative size.
3448 Change the signature to match that of plain 'read' and 'write'; see
3449 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3450 * lisp.h: Update prototypes of emacs_write and emacs_read.
3451
3452 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3453
3454 * xdisp.c (redisplay_window): Don't try to determine the character
3455 position of the scroll margin if the window start point w->startp
3456 is outside the buffer's accessible region. (Bug#8468)
3457
3458 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3459
3460 Fix write-region and its subroutines for buffers > 2GB.
3461 * fileio.c (a_write, e_write): Modify declaration of arguments and
3462 local variables to support buffers larger than 2GB.
3463 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3464
3465 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3466 argument, local variables, and return value.
3467
3468 * lisp.h: Update prototypes of emacs_write and emacs_read.
3469
3470 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3471
3472 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3473
3474 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3475
3476 Fix more problems found by GCC 4.6.0's static checks.
3477
3478 * xdisp.c (vmessage): Use a better test for character truncation.
3479
3480 * charset.c (load_charset_map): <, not <=, for optimization,
3481 and to avoid potential problems with integer overflow.
3482 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3483 * casetab.c (set_identity, shuffle): Likewise.
3484 * editfns.c (Fformat): Likewise.
3485 * syntax.c (skip_chars): Likewise.
3486
3487 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3488 This also lets GCC 4.6.0 generate slightly better loop code.
3489
3490 * callint.c (Fcall_interactively): <, not <=, for optimization.
3491 (Fcall_interactively): Count the number of arguments produced,
3492 not the number of arguments given. This is simpler and lets GCC
3493 4.6.0 generate slightly better code.
3494
3495 * ftfont.c: Distingish more carefully between FcChar8 and char.
3496 The previous code passed unsigned char * to a functions like
3497 strlen and xstrcasecmp that expect char *, which does not
3498 conform to the C standard.
3499 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3500 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3501 char * when the C standard requires it.
3502
3503 * keyboard.c (read_char): Remove unused var.
3504
3505 * eval.c: Port to Windows vsnprintf (Bug#8435).
3506 Include <limits.h>.
3507 (SIZE_MAX): Define if the headers do not.
3508 (verror): Do not give up if vsnprintf returns a negative count.
3509 Instead, grow the buffer. This ports to Windows vsnprintf, which
3510 does not conform to C99. Problem reported by Eli Zaretskii.
3511 Also, simplify the allocation scheme, by avoiding the need for
3512 calling realloc, and removing the ALLOCATED variable.
3513
3514 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3515
3516 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3517 But keep the doprint source code for now, as we might revamp it
3518 and use it again (Bug#8435).
3519 * lisp.h (doprnt): Remove.
3520 * Makefile.in (base_obj): Remove doprnt.o.
3521 * deps.mk (doprnt.o): Remove.
3522
3523 error: Print 32- and 64-bit integers portably (Bug#8435).
3524 Without this change, on typical 64-bit hosts error ("...%d...", N)
3525 was used to print both 32- and 64-bit integers N, which relied on
3526 undefined behavior.
3527 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3528 New macro.
3529 * lisp.h (error, verror): Mark as printf-like functions.
3530 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3531 Report overflow in size calculations when allocating printf buffer.
3532 Do not truncate output string at its first null byte.
3533 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3534 Truncate the output at a character boundary, since vsnprintf does not
3535 do that.
3536 * charset.c (check_iso_charset_parameter): Convert internal
3537 character to string before calling 'error', since %c now has the
3538 printf meaning.
3539 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3540 overflow when computing char to be passed to 'error'. Do not
3541 pass Lisp_Object to 'error'; pass the integer instead.
3542 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3543 formatted with plain %d.
3544
3545 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3546
3547 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3548
3549 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3550
3551 * xterm.c (x_catch_errors): Remove duplicate declaration.
3552
3553 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3554
3555 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3556
3557 2011-04-10 Jim Meyering <meyering@redhat.com>
3558
3559 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3560 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3561 return ssize_t not "int", and use size_t as the buffer length.
3562 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3563 * gnutls.h: Update declarations.
3564 * process.c (read_process_output): Use ssize_t, to match.
3565 (send_process): Likewise.
3566
3567 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3568
3569 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3570
3571 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3572
3573 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3574 Use unsigned char, to match FcChar8 type definition.
3575
3576 * xterm.c (handle_one_xevent):
3577 * xmenu.c (create_and_show_popup_menu):
3578 * xselect.c (x_decline_selection_request)
3579 (x_reply_selection_request): Avoid type-punned deref of X events.
3580
3581 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3582
3583 Fix some uses of `int' instead of EMACS_INT.
3584 * search.c (string_match_1, fast_string_match)
3585 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3586 (scan_buffer, find_next_newline_no_quit)
3587 (find_before_next_newline, search_command, Freplace_match)
3588 (Fmatch_data): Make some `int' variables be EMACS_INT.
3589
3590 * xdisp.c (display_count_lines): 3rd argument and return value now
3591 EMACS_INT. All callers changed.
3592 (pint2hrstr): Last argument is now EMACS_INT.
3593
3594 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3595 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3596 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3597 (decode_coding_utf_16, decode_coding_emacs_mule)
3598 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3599 (decode_coding_ccl, decode_coding_charset)
3600 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3601 (decode_coding_iso_2022, decode_coding_emacs_mule)
3602 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3603 <char_offset, last_offset>: Declare EMACS_INT.
3604 (encode_coding_utf_8, encode_coding_utf_16)
3605 (encode_coding_emacs_mule, encode_invocation_designation)
3606 (encode_designation_at_bol, encode_coding_iso_2022)
3607 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3608 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3609 Declare EMACS_INT.
3610 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3611 (encode_invocation_designation): Last argument P_NCHARS is now
3612 EMACS_INT.
3613 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3614 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3615
3616 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3617 All users changed.
3618
3619 * ccl.c (Fccl_execute_on_string): Declare some variables
3620 EMACS_INT.
3621
3622 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3623
3624 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3625
3626 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3627
3628 * process.c (Fformat_network_address): Doc fix.
3629
3630 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3631
3632 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3633
3634 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3635
3636 * keyboard.c (read_char): Call Lisp function help-form-show,
3637 instead of using internal_with_output_to_temp_buffer.
3638 (Qhelp_form_show): New var.
3639 (syms_of_keyboard): Use DEFSYM macro.
3640
3641 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3642
3643 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3644
3645 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3646
3647 * process.c (Flist_processes): Remove to Lisp.
3648 (list_processes_1): Delete.
3649
3650 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3651
3652 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3653
3654 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3655
3656 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 Fix more problems found by GCC 4.6.0's static checks.
3659
3660 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3661
3662 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3663
3664 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3665
3666 * xdisp.c (vmessage): Mark as a printf-like function.
3667
3668 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3669
3670 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3671
3672 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3673 printf-like functions.
3674 (tiff_load): Add casts to remove these marks before passing them
3675 to system-supplied API.
3676
3677 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3678
3679 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3680 This avoids several warnings with gcc -Wstrict-overflow.
3681 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3682 directly, rather than having caller test rule sign. This avoids
3683 some unnecessary tests.
3684 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3685 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3686 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3687
3688 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3689 (xfont_open): Avoid unnecessary tests.
3690
3691 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3692
3693 * composite.h, composite.c (composition_gstring_put_cache):
3694 Use EMACS_INT, not int, for length.
3695
3696 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3697 breaking out part of COMPOSITION_DECODE_RULE.
3698 (COMPOSITION_DECODE_RULE): Use it.
3699 * composite.c (get_composition_id): Remove unused local vars,
3700 by using the new macro.
3701
3702 * textprop.c (set_text_properties_1): Change while to do-while,
3703 since the condition is always true at first.
3704
3705 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3706 (interval_deletion_adjustment): Return unsigned value.
3707 All uses changed.
3708
3709 * process.c (list_processes_1, create_pty, read_process_output):
3710 (exec_sentinel): Remove vars that were set but not used.
3711 (create_pty): Remove unnecessary "volatile"s.
3712 (Fnetwork_interface_info): Avoid possibility of int overflow.
3713 (read_process_output): Do adaptive read buffering even if carryover.
3714 (read_process_output): Simplify nbytes computation if buffered.
3715
3716 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3717
3718 * syntax.c (scan_words): Remove var that was set but not used.
3719 (update_syntax_table): Use unsigned instead of int.
3720
3721 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3722 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3723 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3724
3725 * print.c (print_error_message): Avoid int overflow.
3726
3727 * font.c (font_list_entities): Redo for clarity,
3728 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3729
3730 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3731 (font_score): Avoid potential overflow in diff calculation.
3732
3733 * fns.c (substring_both): Remove var that is set but not used.
3734 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3735
3736 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3737
3738 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3739 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3740 can always succeed if overflow has undefined behavior.
3741
3742 * search.c (boyer_moore, wordify): Remove vars set but not used.
3743 (wordify): Omit three unnecessary tests.
3744
3745 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3746 All callers changed. This avoids the need for an unused var.
3747
3748 * casefiddle.c (casify_region): Remove var that is set but not used.
3749
3750 * dired.c (file_name_completion): Remove var that is set but not used.
3751
3752 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3753
3754 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3755 (Finsert_file_contents): Remove unnecessary code checking fd.
3756
3757 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3758 Check for integer overflow on size calculations.
3759
3760 * buffer.c (Fprevious_overlay_change): Remove var that is set
3761 but not used.
3762
3763 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3764 Remove vars that are set but not used.
3765 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3766 (timer_check_2): Mark vars as initialized.
3767
3768 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3769
3770 * image.c (lookup_image): Remove var that is set but not used.
3771 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3772
3773 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3774 that are set but not used.
3775
3776 * xfns.c (make_invisible_cursor): Don't return garbage
3777 if XCreateBitmapFromData fails (Bug#8410).
3778
3779 * xselect.c (x_get_local_selection, x_handle_property_notify):
3780 Remove vars that are set but not used.
3781
3782 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3783 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3784
3785 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3786 Remove var that is set but not used.
3787 (scroll_bar_windows_size): Now size_t, not int.
3788 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3789 Check for overflow.
3790
3791 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3792 (map_tty_color) [!defined MSDOS]: Likewise.
3793
3794 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3795
3796 * coding.c: Remove vars that are set but not used.
3797 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3798 All callers changed.
3799 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3800 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3801 (decode_coding_charset): Remove vars that are set but not used.
3802
3803 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3804 that is set but not used.
3805
3806 * print.c (print_object): Remove var that is set but not used.
3807
3808 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3809 The gnulib version avoids calling malloc in the usual case,
3810 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3811 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3812 * filelock.c (current_lock_owner): Likewise.
3813 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3814 * sysdep.c: Include allocator.h, careadlinkat.h.
3815 (emacs_no_realloc_allocator): New static constant.
3816 (emacs_readlink): New function.
3817 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3818 ../lib/careadlinkat.h.
3819
3820 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3821
3822 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3823 first non-nil return value).
3824
3825 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3826
3827 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3828 if not defined (Bug#8403).
3829
3830 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3831
3832 * xdisp.c (display_count_lines): Remove parameter `start',
3833 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3834 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3835 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3836 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3837 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3838 and thereabouts. All callers changed.
3839 (get_per_char_metric): Remove parameter `f', unused since
3840 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3841
3842 2011-04-02 Jim Meyering <meyering@redhat.com>
3843
3844 do not dereference NULL upon failed strdup
3845 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3846 (ns_get_family): Likewise.
3847
3848 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3849
3850 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3851
3852 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3853
3854 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3855 later (Bug#8403).
3856
3857 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3858
3859 Add lexical binding.
3860
3861 * window.c (Ftemp_output_buffer_show): New fun.
3862 (Fsave_window_excursion):
3863 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3864
3865 * lread.c (lisp_file_lexically_bound_p): New function.
3866 (Fload): Bind Qlexical_binding.
3867 (readevalloop): Remove `evalfun' arg.
3868 Bind Qinternal_interpreter_environment.
3869 (Feval_buffer): Bind Qlexical_binding.
3870 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3871 Mark as dynamic.
3872 (syms_of_lread): Declare `lexical-binding'.
3873
3874 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3875
3876 * keyboard.c (eval_dyn): New fun.
3877 (menu_item_eval_property): Use it.
3878
3879 * image.c (parse_image_spec): Use Ffunctionp.
3880
3881 * fns.c (concat, mapcar1): Accept byte-code-functions.
3882
3883 * eval.c (Fsetq): Handle lexical vars.
3884 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3885 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3886 (FletX, Flet): Obey lexical binding.
3887 (Fcommandp): Handle closures.
3888 (Feval): New `lexical' arg.
3889 (eval_sub): New function extracted from Feval. Use it almost
3890 everywhere where Feval was used. Look up vars in lexical env.
3891 Handle closures.
3892 (Ffunctionp): Move from subr.el.
3893 (Ffuncall): Handle closures.
3894 (apply_lambda): Remove `eval_flags'.
3895 (funcall_lambda): Handle closures and new byte-code-functions.
3896 (Fspecial_variable_p): New function.
3897 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3898 but without exporting it to Lisp.
3899
3900 * doc.c (Fdocumentation, store_function_docstring):
3901 * data.c (Finteractive_form): Handle closures.
3902
3903 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3904 interactive spec.
3905
3906 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3907 New byte-codes.
3908 (exec_byte_code): New function extracted from Fbyte_code to handle new
3909 calling convention for byte-code-functions. Add new byte-codes.
3910
3911 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3912
3913 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3914
3915 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3916
3917 * xdisp.c (redisplay_internal): Fix prototype.
3918
3919 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3920
3921 * xdisp.c (SCROLL_LIMIT): New macro.
3922 (try_scrolling): Use it when setting scroll_limit.
3923 Limit scrolling to 100 screen lines.
3924 (redisplay_window): Even when falling back on "recentering",
3925 position point in the window according to scroll-conservatively,
3926 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3927
3928 (try_scrolling): When point is above the window, allow searching
3929 as far as scroll_max, or one screenful, to compute vertical
3930 distance from PT to the scroll margin position. This prevents
3931 try_scrolling from unnecessarily failing when
3932 scroll-conservatively is set to a value slightly larger than the
3933 window height. Clean up the case of PT below the margin at bottom
3934 of window: scroll_max can no longer be INT_MAX. When aggressive
3935 scrolling is in use, don't let point enter the opposite scroll
3936 margin as result of the scroll.
3937 (syms_of_xdisp) <scroll-conservatively>: Document the
3938 threshold of 100 lines for never-recentering scrolling.
3939
3940 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3941
3942 * dispextern.h (move_it_by_lines):
3943 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3944 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3945 (message_log_check_duplicate): Remove parameters `prev_bol' and
3946 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3947 (redisplay_internal): Remove parameter `preserve_echo_area',
3948 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3949
3950 * indent.c (Fvertical_motion):
3951 * window.c (window_scroll_pixel_based, Frecenter):
3952 Don't pass `need_y_p' to `move_it_by_lines'.
3953
3954 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3955
3956 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3957 steal a few bits to be more compact.
3958 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3959 Remove unneeded casts.
3960
3961 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3962
3963 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3964
3965 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3966 binding" message (bug#7967).
3967
3968 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Fix more problems found by GCC 4.6.0's static checks.
3971
3972 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3973 Remove unused local var.
3974
3975 * editfns.c (Fmessage_box): Remove unused local var.
3976
3977 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3978 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3979 Omit unused local vars.
3980 * window.c (shrink_windows): Omit unused local var.
3981 * menu.c (digest_single_submenu): Omit unused local var.
3982 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3983 Omit unused local var.
3984
3985 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3986 Don't assume string length fits in int.
3987 (keyremap_step, read_key_sequence): Use size_t for sizes.
3988 (read_key_sequence): Don't check last_real_key_start redundantly.
3989
3990 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3991 instead of alloca (Bug#8344).
3992
3993 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3994 (Fbacktrace_frame): Don't assume nframes fits in int.
3995
3996 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3997
3998 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3999 concerns.
4000
4001 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4002
4003 * cm.c (calccost): Turn while-do into do-while, for clarity.
4004
4005 * keyboard.c (syms_of_keyboard): Use the same style as later
4006 in this function when indexing through an array. This also
4007 works around GCC bug 48267.
4008
4009 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4010
4011 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4012
4013 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4014 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4015
4016 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4017 This avoids undefined behavior on integer overflow, and is a bit
4018 more convenient anyway since it is compared to a size_t variable.
4019
4020 Variadic C functions now count arguments with size_t, not int.
4021 This avoids an unnecessary limitation on 64-bit machines, which
4022 caused (substring ...) to crash on large vectors (Bug#8344).
4023 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4024 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4025 All variadic functions and their callers changed accordingly.
4026 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4027 * data.c (arith_driver, float_arith_driver): Likewise.
4028 * editfns.c (general_insert_function): Likewise.
4029 * eval.c (struct backtrace.nargs, interactive_p)
4030 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4031 (funcall_lambda, mark_backtrace): Likewise.
4032 * fns.c (concat): Likewise.
4033 * frame.c (x_set_frame_parameters): Likewise.
4034 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4035 0 if not found, not -1. All callers changed.
4036
4037 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4038 (stack_copy_size): Now size_t, not int.
4039 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4040
4041 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4042
4043 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4044 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4045 All callers changed.
4046
4047 * lisp.h (multibyte_char_to_unibyte):
4048 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4049 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4050 * character.h (CHAR_TO_BYTE8):
4051 * cmds.c (internal_self_insert):
4052 * editfns.c (general_insert_function):
4053 * keymap.c (push_key_description):
4054 * search.c (Freplace_match):
4055 * xdisp.c (message_dolog, set_message_1): All callers changed.
4056
4057 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4058
4059 * keyboard.c (safe_run_hook_funcall): New function.
4060 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4061 don't set the hook to nil, but remove the offending function instead.
4062 (Qcommand_hook_internal): Remove, unused.
4063 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4064 Vcommand_hook_internal.
4065
4066 * eval.c (enum run_hooks_condition): Remove.
4067 (funcall_nil, funcall_not): New functions.
4068 (run_hook_with_args): Call each function through a `funcall' argument.
4069 Remove `cond' argument, now redundant.
4070 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4071 (Frun_hook_with_args_until_failure): Adjust accordingly.
4072 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4073
4074 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4075
4076 * dispextern.h (string_buffer_position): Remove declaration.
4077
4078 * print.c (strout): Remove parameter `multibyte', unused since
4079 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4080
4081 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4082 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4083 All callers changed.
4084
4085 * w32.c (_wsa_errlist): Use braces for struct initializers.
4086
4087 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4088 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4089 All callers changed.
4090 (string_buffer_position): Likewise. Also, make static (it's never
4091 used outside xdisp.c).
4092 (cursor_row_p): Remove parameter `w', unused since
4093 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4094 (decode_mode_spec): Remove parameter `precision', introduced during
4095 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4096 All callers changed.
4097
4098 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4099
4100 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4101
4102 2011-03-27 Anders Lindgren <andlind@gmail.com>
4103
4104 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4105 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4106 (ns_update_auto_hide_menu_bar): New functions.
4107 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4108 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4109 ns_constrain_all_frames.
4110 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4111 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4112
4113 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4114
4115 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4116
4117 2011-03-27 Glenn Morris <rgm@gnu.org>
4118
4119 * syssignal.h: Replace RETSIGTYPE with void.
4120 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4121 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4122 Replace SIGTYPE with void everywhere.
4123 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4124 * s/template.h (SIGTYPE): Remove commented out definition.
4125
4126 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4127
4128 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4129 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4130
4131 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4132
4133 * w32.c (read_unc_volume): Use parameter `henum', instead of
4134 global variable `wget_enum_handle'.
4135
4136 * keymap.c (describe_vector): Remove parameters `indices' and
4137 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4138 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4139
4140 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4141
4142 * keyboard.c (timer_check): Remove parameter `do_it_now',
4143 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4144 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4145 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4146
4147 * keyboard.c (read_char):
4148 * w32menu.c (w32_menu_display_help):
4149 * xmenu.c (show_help_event, menu_help_callback):
4150 Adjust calls to `show_help_echo'.
4151
4152 * gtkutil.c (xg_maybe_add_timer):
4153 * keyboard.c (readable_events):
4154 * process.c (wait_reading_process_output):
4155 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4156
4157 * insdel.c (adjust_markers_gap_motion):
4158 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4159 (gap_left, gap_right): Don't call it.
4160
4161 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4162
4163 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4164 incurred during fontification.
4165
4166 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4167
4168 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4169 (DEFVAR_PER_BUFFER): Don't pass it.
4170
4171 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4172 (scrolling_window): Don't pass it.
4173
4174 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4175
4176 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4177
4178 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4179 and `suffix'.
4180 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4181 of variables specific to SELinux and computation of `encoded_absname'.
4182
4183 * image.c (XPutPixel): Remove unused variable `height'.
4184
4185 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4186
4187 * unexw32.c (get_section_info): Remove unused variable `section'.
4188
4189 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4190 (system_process_attributes): Remove unused variable `sess'.
4191 (sys_read): Remove unused variable `err'.
4192
4193 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4194 (w32_wnd_proc): Remove unused variable `isdead'.
4195 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4196 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4197 (x_create_tip_frame): Remove unused variable `tem'.
4198
4199 * w32inevt.c (w32_console_read_socket):
4200 Remove unused variable `no_events'.
4201
4202 * w32term.c (x_draw_composite_glyph_string_foreground):
4203 Remove unused variable `width'.
4204
4205 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4206
4207 * w32term.c (x_set_glyph_string_clipping):
4208 Don't pass uninitialized region to CombineRgn.
4209
4210 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4211
4212 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4213 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4214 (Fx_close_connection): Remove unused variable `i'.
4215
4216 * w32font.c (w32font_draw): Return number of glyphs.
4217 (w32font_open_internal): Remove unused variable `i'.
4218 (w32font_driver): Add missing initializer.
4219
4220 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4221 (fill_in_menu): Remove unused variable `items_added'.
4222
4223 * w32term.c (last_mouse_press_frame): Remove static global variable.
4224 (w32_clip_to_row): Remove unused variable `f'.
4225 (x_delete_terminal): Remove unused variable `i'.
4226
4227 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4228 (NOTHING): Remove unused static global variable.
4229 (uniscribe_check_otf): Remove unused variable `table'.
4230 (uniscribe_font_driver): Add missing initializers.
4231
4232 2011-03-23 Julien Danjou <julien@danjou.info>
4233
4234 * term.c (Fsuspend_tty, Fresume_tty):
4235 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4236 * window.c (temp_output_buffer_show):
4237 * insdel.c (signal_before_change):
4238 * frame.c (Fhandle_switch_frame):
4239 * fileio.c (Fdo_auto_save):
4240 * emacs.c (Fkill_emacs):
4241 * editfns.c (save_excursion_restore):
4242 * cmds.c (internal_self_insert):
4243 * callint.c (Fcall_interactively):
4244 * buffer.c (Fkill_all_local_variables):
4245 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4246 Use Frun_hooks.
4247 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4248 unconditionnaly since it does the check itself.
4249
4250 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 Fix more problems found by GCC 4.5.2's static checks.
4253
4254 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4255 the first time through the loop, since we know p0 < p1 then.
4256 This also avoids a gcc -Wstrict-overflow warning.
4257
4258 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4259 leading to a memory leak, possible in functions like
4260 load_charset_map_from_file that can allocate an unbounded number
4261 of objects (Bug#8318).
4262
4263 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4264 that could (at least in theory) be that large.
4265
4266 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4267 This is less likely to overflow, and avoids undefined behavior if
4268 overflow does occur. All callers changed. Use strtoul to scan
4269 for the unsigned long integer.
4270 (pint2hrstr): Simplify and tune code slightly.
4271 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4272
4273 * scroll.c (do_scrolling): Work around GCC bug 48228.
4274 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4275
4276 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4277 This also avoids a warning with gcc -Wstrict-overflow.
4278 (validate_x_resource_name): Simplify count usage.
4279 This also avoids a warning with gcc -Wstrict-overflow.
4280
4281 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4282 fail (Bug#8306).
4283
4284 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4285
4286 * process.c (Fmake_network_process): Use socklen_t, not int,
4287 where POSIX says socklen_t is required in portable programs.
4288 This fixes a porting bug on hosts like 64-bit HP-UX, where
4289 socklen_t is wider than int (Bug#8277).
4290 (Fmake_network_process, server_accept_connection):
4291 (wait_reading_process_output, read_process_output):
4292 Likewise.
4293
4294 * process.c: Rename or move locals to avoid shadowing.
4295 (list_processes_1, Fmake_network_process):
4296 (read_process_output_error_handler, exec_sentinel_error_handler):
4297 Rename or move locals.
4298 (Fmake_network_process): Define label "retry_connect" only if needed.
4299 (Fnetwork_interface_info): Fix pointer signedness.
4300 (process_send_signal): Add cast to avoid pointer signedness problem.
4301 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4302 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4303
4304 Make tparam.h and terminfo.c consistent.
4305 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4306 Include tparam.h instead, since it declares them.
4307 * cm.h (PC): Remove extern decl; tparam.h now does this.
4308 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4309 * terminfo.c: Include tparam.h, to check interfaces.
4310 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4311 (tparam): Adjust signature to match interface in tparam.h;
4312 this removes some undefined behavior. Check that outstring and len
4313 are zero, which they always are with Emacs.
4314 * tparam.h (PC, BC, UP): New extern decls.
4315
4316 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4317 (xftfont_open): Rename locals to avoid shadowing.
4318
4319 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4320 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4321 (OTF_TAG_SYM): Omit macro if not needed.
4322 (ftfont_list): Remove unused local.
4323 (get_adstyle_property, ftfont_pattern_entity):
4324 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4325 Rename locals to avoid shadowing.
4326
4327 * xfont.c (xfont_list_family): Mark var as initialized.
4328
4329 * xml.c (make_dom): Now static.
4330
4331 * composite.c (composition_compute_stop_pos): Rename local to
4332 avoid shadowing.
4333 (composition_reseat_it): Remove unused locals.
4334 (find_automatic_composition, composition_adjust_point): Likewise.
4335 (composition_update_it): Mark var as initialized.
4336 (find_automatic_composition): Mark vars as initialized,
4337 with a FIXME (Bug#8290).
4338
4339 character.h: Rename locals to avoid shadowing.
4340 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4341 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4342 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4343 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4344 to avoid shadowing.
4345
4346 * textprop.c (property_change_between_p): Remove; unused.
4347
4348 * intervals.c (interval_start_pos): Now static.
4349
4350 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4351
4352 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4353 Rename locals to avoid shadowing.
4354
4355 * sound.c (wav_play, au_play, Fplay_sound_internal):
4356 Fix pointer signedness.
4357 (alsa_choose_format): Remove unused local var.
4358 (wav_play): Initialize a variable to 0, to prevent undefined
4359 behavior (Bug#8278).
4360
4361 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4362
4363 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4364
4365 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4366 clobbering (Bug#8298).
4367 * sysdep.c (sys_subshell): Likewise.
4368 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4369
4370 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4371 This should get cleaned up, so that child_setup has the
4372 same signature on all platforms.
4373
4374 * callproc.c (call_process_cleanup): Now static.
4375 (relocate_fd): Rename locals to avoid shadowing.
4376
4377 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4378
4379 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4380 not to be necessary, and produces flickering.
4381
4382 2011-03-20 Glenn Morris <rgm@gnu.org>
4383
4384 * config.in: Remove file.
4385
4386 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4387
4388 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4389 are now in src/globals.h.
4390 (syms_of_minibuf): Remove spurious & from previous change.
4391
4392 2011-03-20 Leo <sdl.web@gmail.com>
4393
4394 * minibuf.c (completing-read-function): New variable.
4395 (completing-read-default): Rename from completing-read.
4396 (completing-read): Call completing-read-function.
4397
4398 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4399
4400 * xfaces.c (Fx_load_color_file):
4401 Read color file from absolute filename (bug#8250).
4402
4403 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4404
4405 * makefile.w32-in: Update dependencies.
4406
4407 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4408
4409 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4410
4411 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 Fix more problems found by GCC 4.5.2's static checks.
4414
4415 * process.c (make_serial_process_unwind, send_process_trap):
4416 (sigchld_handler): Now static.
4417
4418 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4419 That way, the code declares only the vars that it needs.
4420 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4421 * s/cygwin.h (PTY_ITERATION): Likewise.
4422 * s/darwin.h (PTY_ITERATION): Likewise.
4423 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4424
4425 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4426 * process.c (allocate_pty): Don't declare stb unless it's needed.
4427
4428 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4429 (CONSTANTLIM): Remove; unused.
4430 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4431 Define only if needed.
4432
4433 * unexelf.c (unexec): Name an expression,
4434 to avoid gcc -Wbad-function-cast warning.
4435 Use a different way to cause a compilation error if anyone uses
4436 n rather than nn, a way that does not involve shadowing.
4437 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4438
4439 * deps.mk (unexalpha.o): Remove; unused.
4440
4441 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4442 * unexec.h: New file.
4443 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4444 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4445 Depend on unexec.h.
4446 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4447 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4448 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4449 Change as necessary to match prototype in unexec.h.
4450
4451 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4452 shadowing.
4453 (back_comment, skip_chars): Mark vars as initialized.
4454
4455 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4456 Rename locals to avoid shadowing.
4457
4458 * lread.c (read1): Rewrite so as not to use empty "else".
4459 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4460
4461 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4462
4463 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4464 warning when compiling print.c.
4465
4466 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4467 instead of using an uninitialized var.
4468 (font_sort_entities): Mark var as initialized.
4469
4470 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4471
4472 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4473 pointers to constants.
4474 (font_parse_fcname): Remove unused vars.
4475 (font_delete_unmatched): Now static.
4476 (font_get_spec): Remove; unused.
4477 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4478 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4479 Rename or move locals to avoid shadowing.
4480
4481 * fns.c (require_nesting_list, require_unwind): Now static.
4482 (Ffillarray): Rename locals to avoid shadowing.
4483
4484 * floatfns.c (domain_error2): Define only if needed.
4485 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4486
4487 * alloc.c (mark_backtrace): Move decl from here ...
4488 * lisp.h: ... to here, so that it can be checked.
4489
4490 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4491 (Fdefvar): Rewrite so as not to use empty "else".
4492 (lisp_indirect_variable): Name an expression,
4493 to avoid gcc -Wbad-function-cast warning.
4494 (Fdefvar): Rename locals to avoid shadowing.
4495
4496 * callint.c (quotify_arg, quotify_args): Now static.
4497 (Fcall_interactively): Rename locals to avoid shadowing.
4498 Use const pointer when appropriate.
4499
4500 * lisp.h (get_system_name, get_operating_system_release):
4501 Move decls here, to check interfaces.
4502 * process.c (get_operating_system_release): Move decl to lisp.h.
4503 * xrdb.c (get_system_name): Likewise.
4504 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4505 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4506 some of which prompt warnings from gcc -Wbad-function-cast.
4507 (Fformat_time_string, Fencode_time, Finsert_char):
4508 (Ftranslate_region_internal, Fformat):
4509 Rename or remove local vars to avoid shadowing.
4510 (Ftranslate_region_internal): Mark var as initialized.
4511
4512 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4513 avoid shadowing.
4514
4515 * lisp.h (eassert): Check that the argument compiles, even if
4516 ENABLE_CHECKING is not defined.
4517
4518 * data.c (Findirect_variable): Name an expression, to avoid
4519 gcc -Wbad-function-cast warning.
4520 (default_value, arithcompare, arith_driver, arith_error): Now static.
4521 (store_symval_forwarding): Rename local to avoid shadowing.
4522 (Fmake_variable_buffer_local, Fmake_local_variable):
4523 Mark variables as initialized.
4524 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4525
4526 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4527 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4528 Rename locals to avoid shadowing.
4529 (mark_stack): Move local variables into the #ifdef region where
4530 they're used.
4531 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4532 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4533 needed otherwise.
4534 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4535 (GC_STRING_CHARS): Remove; not used.
4536 (Fmemory_limit): Cast sbrk's returned value to char *.
4537
4538 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4539 avoids undefined behavior in theory.
4540
4541 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4542
4543 Use functions, not macros, for up- and down-casing (Bug#8254).
4544 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4545 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4546 to use the following functions instead of these macros.
4547 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4548 EMACS_INT, since callers assume the returned value fits in int.
4549 (upcase1): Likewise, for UPCASE_TABLE.
4550 (uppercasep, lowercasep, upcase): New static inline functions.
4551 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4552 the race-condition problem in the old DOWNCASE.
4553
4554 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4555 Rename locals to avoid shadowing.
4556 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4557 (regex_compile, re_search_2, re_match_2_internal):
4558 Remove unused local vars.
4559 (FREE_VAR): Rewrite so as not to use empty "else",
4560 which gcc can warn about.
4561 (regex_compile, re_match_2_internal): Mark locals as initialized.
4562 (RETALLOC_IF): Define only if needed.
4563 (WORDCHAR_P): Likewise. This one is never needed, but is used
4564 only in a comment talking about a compiler bug, so put inside
4565 the #if 0 of that comment.
4566 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4567 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4568 Remove; unused.
4569
4570 * search.c (boyer_moore): Rename locals to avoid shadowing.
4571 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4572 (PREV_CHAR_BOUNDARY): Likewise.
4573
4574 * search.c (simple_search): Remove unused var.
4575
4576 * dired.c (compile_pattern): Move decl from here ...
4577 * lisp.h: ... to here, so that it can be checked.
4578 (struct re_registers): New forward decl.
4579
4580 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4581
4582 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4583 All uses changed.
4584 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4585 Rename locals to avoid shadowing.
4586 (Fvertical_motion): Mark locals as initialized.
4587
4588 * casefiddle.c (casify_object, casify_region): Now static.
4589 (casify_region): Mark local as initialized.
4590
4591 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4592
4593 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4594 New macros, so that the caller can use some names other than
4595 gcpro1, gcpro2, etc.
4596 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4597 of the new macros.
4598 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4599 argument, for consistency with GCPRO2_VAR, etc: it is now the
4600 prefix of the variable, not the variable itself. All uses
4601 changed.
4602 * dired.c (directory_files_internal, file_name_completion):
4603 Rename locals to avoid shadowing.
4604
4605 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4606 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4607 dired.c's scmp function, had undefined behavior.
4608 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4609 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4610 * buffer.h: ... to here, because these macros use current_buffer,
4611 and the new implementation with inline functions needs to have
4612 current_buffer in scope now, rather than later when the macros
4613 are used.
4614 (downcase, upcase1): New static inline functions.
4615 (DOWNCASE, UPCASE1): Reimplement using these functions.
4616 This avoids undefined behavior in expressions like
4617 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4618 from race conditions in accessing the global variables
4619 case_temp1 and case_temp2.
4620 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4621 * lisp.h (case_temp1, case_temp2): Remove their decls.
4622 * character.h (ASCII_CHAR_P): Move from here ...
4623 * lisp.h: ... to here, so that the inline functions mentioned
4624 above can use them.
4625
4626 * dired.c (directory_files_internal_unwind): Now static.
4627
4628 * fileio.c (file_name_as_directory, directory_file_name):
4629 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4630 Now static.
4631 (file_name_as_directory): Use const pointers when appropriate.
4632 (Fexpand_file_name): Likewise. In particular, newdir might
4633 point at constant storage, so make it a const pointer.
4634 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4635 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4636 signedness issues.
4637 (Fset_file_times, Finsert_file_contents, auto_save_error):
4638 Rename locals to avoid shadowing.
4639
4640 * minibuf.c (choose_minibuf_frame_1): Now static.
4641 (Ftry_completion, Fall_completions): Rename or remove locals
4642 to avoid shadowing.
4643
4644 * marker.c (bytepos_to_charpos): Remove; unused.
4645
4646 * lisp.h (verify_bytepos, count_markers): New decls,
4647 so that gcc does not warn that these functions aren't declared.
4648
4649 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4650 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4651 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4652 (copy_text): Remove unused local var.
4653
4654 * filelock.c (within_one_second): Now static.
4655 (lock_file_1): Rename local to avoid shadowing.
4656
4657 * buffer.c (fix_overlays_before): Mark locals as initialized.
4658 (fix_start_end_in_overlays): Likewise. This function should be
4659 simplified by using pointers-to-pointers, but that's a different
4660 matter.
4661 (switch_to_buffer_1): Now static.
4662 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4663 (report_overlay_modification): Rename locals to avoid shadowing.
4664
4665 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4666 Fix pointer signedness issue.
4667 (sys_subshell): Mark local as volatile if checking for lint,
4668 to suppress a gcc -Wclobbered warning that does not seem to be right.
4669 (MAXPATHLEN): Define only if needed.
4670
4671 * process.c (serial_open, serial_configure): Move decls from here ...
4672 * systty.h: ... to here, so that they can be checked.
4673
4674 * fns.c (get_random, seed_random): Move extern decls from here ...
4675 * lisp.h: ... to here, so that they can be checked.
4676
4677 * sysdep.c (reset_io): Now static.
4678 (wait_for_termination_signal): Remove; unused.
4679
4680 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4681 (copy_keymap_item, append_key, push_text_char_description):
4682 Now static.
4683 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4684 (DENSE_TABLE_SIZE): Remove; unused.
4685 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4686 (describe_map_tree):
4687 Rename locals to avoid shadowing.
4688
4689 * keyboard.c: Declare functions static if they are not used elsewhere.
4690 (echo_char, echo_dash, cmd_error, top_level_2):
4691 (poll_for_input, handle_async_input): Now static.
4692 (read_char, kbd_buffer_get_event, make_lispy_position):
4693 (make_lispy_event, make_lispy_movement, apply_modifiers):
4694 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4695 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4696 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4697 (read_key_sequence, read_char): Mark locals as initialized.
4698 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4699
4700 * keyboard.h (make_ctrl_char): New decl.
4701 (mark_kboards): Move decl here ...
4702 * alloc.c (mark_kboards): ... from here.
4703
4704 * lisp.h (force_auto_save_soon): New decl.
4705
4706 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4707 (DEFINE_DUMMY_FUNCTION): New macro.
4708 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4709 Use it.
4710 (main): Add casts to avoid warnings
4711 if GCC considers string literals to be constants.
4712
4713 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4714
4715 * dbusbind.c: Pointer signedness fixes.
4716 (xd_signature, xd_append_arg, xd_initialize):
4717 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4718 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4719 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4720 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4721
4722 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4723 if GCC considers string literals to be constants.
4724 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4725
4726 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4727
4728 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4729 (print_preprocess, print_object): New macro to fix last change.
4730
4731 * print.c (print_preprocess): Don't forget font objects.
4732
4733 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4734
4735 * emacs.c (USAGE3): Doc fixes.
4736
4737 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4738
4739 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4740 structure.
4741
4742 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4743
4744 * lisp.h (VWindow_system, Qfile_name_history):
4745 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4746 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4747 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4748
4749 * w32select.c: Don't #include "keyboard.h".
4750 (run_protected): Add extern declaration for waiting_for_input.
4751
4752 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4753 * w32console.c (detect_input_pending, read_input_pending)
4754 (encode_terminal_code):
4755 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4756 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4757 (w32_system_caret_y, Qfile_name_history):
4758 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4759 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4760 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4761 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4762 * w32proc.c (Qlocal, report_file_error):
4763 * w32term.c (Vwindow_system, updating_frame):
4764 * w32uniscribe.c (initialized, uniscribe_font_driver):
4765 Remove unneeded extern declarations.
4766
4767 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4768
4769 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4770
4771 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4772
4773 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4774 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4775 These macros can no longer be used for assignment.
4776
4777 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4778 Assign struct members directly, instead of using BUF_BEGV etc.
4779 (record_buffer_markers, fetch_buffer_markers): New functions for
4780 recording and fetching special buffer markers.
4781 (set_buffer_internal_1, set_buffer_temp): Use them.
4782
4783 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4784
4785 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4786
4787 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4788 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4789
4790 * xdisp.c (hscroll_window_tree):
4791 (reconsider_clip_changes): Use PT instead of BUF_PT.
4792
4793 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4794
4795 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4796 $(EMACS_ROOT)/lib/intprops.h.
4797
4798 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4799
4800 Fix more problems found by GCC 4.5.2's static checks.
4801
4802 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4803 to unsigned char * to avoid compiler diagnostic.
4804 (xg_free_frame_widgets): Make it clear that a local variable is
4805 needed only if USE_GTK_TOOLTIP.
4806 (gdk_window_get_screen): Make it clear that this macro is needed
4807 only if USE_GTK_TOOLTIP.
4808 (int_gtk_range_get_value): New function, which avoids a diagnostic
4809 from gcc -Wbad-function-cast.
4810 (xg_set_toolkit_scroll_bar_thumb): Use it.
4811 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4812 diagnostic from gcc -Wbad-function-cast.
4813 (get_utf8_string, xg_get_file_with_chooser):
4814 Rename locals to avoid shadowing.
4815 (create_dialog): Move locals to avoid shadowing.
4816
4817 * xgselect.c (xg_select): Remove unused var.
4818
4819 * image.c (four_corners_best): Mark locals as initialized.
4820 (gif_load): Initialize transparent_p to zero (Bug#8238).
4821 Mark another local as initialized.
4822 (my_png_error, my_error_exit): Mark with NO_RETURN.
4823
4824 * image.c (clear_image_cache): Now static.
4825 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4826 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4827 (x_edge_detection): Remove unnecessary cast that
4828 gcc -Wbad-function-cast diagnoses.
4829 (gif_load): Fix pointer signedness.
4830 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4831 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4832
4833 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4834
4835 Improve quality of tests for time stamp overflow.
4836 For example, without this patch (encode-time 0 0 0 1 1
4837 1152921504606846976) returns the obviously-bogus value (-948597
4838 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4839 reports time overflow. See
4840 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4841 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4842 * editfns.c: Include limits.h and intprops.h.
4843 (TIME_T_MIN, TIME_T_MAX): New macros.
4844 (time_overflow): Move earlier, to before first use.
4845 (hi_time, lo_time): New functions, for an accurate test for
4846 out-of-range times.
4847 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4848 (Fget_internal_run_time): Don't assume time_t fits in int.
4849 (make_time): Use list2 instead of Fcons twice.
4850 (Fdecode_time): More accurate test for out-of-range times.
4851 (check_tm_member): New function.
4852 (Fencode_time): Use it, to test for out-of-range times.
4853 (lisp_time_argument): Don't rely on undefined left-shift and
4854 right-shift behavior when checking for time stamp overflow.
4855
4856 * editfns.c (time_overflow): New function, refactoring common code.
4857 (Fformat_time_string, Fdecode_time, Fencode_time):
4858 (Fcurrent_time_string): Use it.
4859
4860 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4861 * dired.c (make_time): Move to ...
4862 * editfns.c (make_time): ... here.
4863 * systime.h: Note the move.
4864
4865 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4866
4867 * fringe.c (update_window_fringes): Remove unused variables.
4868
4869 * unexmacosx.c (copy_data_segment): Also copy __got section.
4870 (Bug#8223)
4871
4872 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4873
4874 * termcap.c [MSDOS]: Include "msdos.h".
4875 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4876 Constify `char *' arguments and their references according to
4877 prototypes in tparam.h.
4878
4879 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4880
4881 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4882 Adapt all references accordingly.
4883
4884 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4885
4886 2011-03-11 Tom Tromey <tromey@redhat.com>
4887
4888 * buffer.c (syms_of_buffer): Remove obsolete comment.
4889
4890 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4891
4892 * termhooks.h (encode_terminal_code): Declare prototype.
4893
4894 * msdos.c (encode_terminal_code): Don't declare prototype.
4895
4896 * term.c (encode_terminal_code): Now external again, used by
4897 w32console.c and msdos.c.
4898
4899 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4900 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4901
4902 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 Fix some minor problems found by GCC 4.5.2's static checks.
4905
4906 * fringe.c (update_window_fringes): Mark locals as initialized
4907 (Bug#8227).
4908 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4909
4910 * alloc.c (mark_fringe_data): Move decl from here ...
4911 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4912 to check its interface.
4913 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4914
4915 * fontset.c (free_realized_fontset): Now static.
4916 (Fset_fontset_font): Rename local to avoid shadowing.
4917 (fontset_font): Mark local as initialized.
4918 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4919
4920 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4921
4922 * xselect.c (x_disown_buffer_selections): Remove; not used.
4923 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4924 (x_own_selection, Fx_disown_selection_internal): Rename locals
4925 to avoid shadowing.
4926 (x_handle_dnd_message): Remove local to avoid shadowing.
4927
4928 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4929 so that the caller can use some name other than gcpro1.
4930 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4931 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4932 (Fx_backspace_delete_keys_p):
4933 Use them to avoid shadowing, and rename vars to avoid shadowing.
4934 (x_decode_color, x_set_name, x_window): Now static.
4935 (Fx_create_frame): Add braces to silence GCC warning.
4936 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4937 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4938 Remove unused locals.
4939 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4940 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4941 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4942 macros.
4943
4944 * xterm.h (x_mouse_leave): New decl.
4945
4946 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4947 Remove unused functions.
4948 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4949 (x_calc_absolute_position): Now static.
4950 (XTread_socket): Don't define label "out" unless it's used.
4951 Don't declare local "event" unless it's used.
4952 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4953 unless they are used.
4954 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4955 (x_fatal_error_signal): Remove; not used.
4956 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4957 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4958 (x_error_catcher, x_connection_closed, x_error_handler):
4959 (x_error_quitter, xembed_send_message, x_iconify_frame):
4960 (my_log_handler): Rename locals to avoid shadowing.
4961 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4962 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4963
4964 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4965 Rename or move locals to avoid shadowing.
4966 (tty_defined_color, merge_face_heights): Now static.
4967 (free_realized_faces_for_fontset): Remove; not used.
4968 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4969 does not deduce is never used uninitialized.
4970 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4971 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4972
4973 * terminal.c (store_terminal_param): Now static.
4974
4975 * xmenu.c (menu_highlight_callback): Now static.
4976 (set_frame_menubar): Remove unused local.
4977 (xmenu_show): Rename parameter to avoid shadowing.
4978 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4979 since they might point to immutable storage.
4980 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4981 since it's unused otherwise.
4982
4983 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4984 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4985 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4986 avoids a gcc -Wuninitialized diagnostic.
4987 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4988 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4989 does not deduce are never used uninitialized.
4990
4991 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4992
4993 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4994 * window.c (window_loop, size_window):
4995 (run_window_configuration_change_hook, enlarge_window): Likewise.
4996
4997 * window.c (display_buffer): Now static.
4998 (size_window): Mark variables that gcc -Wuninitialized
4999 does not deduce are never used uninitialized.
5000 * window.h (check_all_windows): New decl, to forestall
5001 gcc -Wmissing-prototypes diagnostic.
5002 * dispextern.h (bidi_dump_cached_states): Likewise.
5003
5004 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5005 shadowing.
5006 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5007 Include <limits.h>.
5008 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5009 and to avoid gcc -Wuninitialized warning.
5010 (load_charset_map): Mark variables that gcc -Wuninitialized
5011 does not deduce are never used uninitialized.
5012 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5013
5014 * coding.c (coding_set_source, coding_set_destination):
5015 Use "else { /* comment */ }" rather than "else /* comment */;"
5016 for clarity, and to avoid gcc -Wempty-body warning.
5017 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5018 a block, when the outer 'i' will do.
5019 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5020 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5021 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5022 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5023 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5024 Rename locals to avoid shadowing.
5025 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5026 * coding.c (emacs_mule_char, encode_invocation_designation):
5027 Now static, since they're not used elsewhere.
5028 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5029 (decode_coding_object, encode_coding_object, detect_coding_system):
5030 (decode_coding_emacs_mule): Mark variables that gcc
5031 -Wuninitialized does not deduce are never used uninitialized.
5032 (detect_coding_iso_2022): Initialize a local variable that might
5033 be used uninitialized. Leave a FIXME because it's not clear that
5034 this initialization is needed. (Bug#8211)
5035 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5036 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5037 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5038 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5039 Remove unused macros.
5040
5041 * category.c (hash_get_category_set): Remove unused local var.
5042 (copy_category_table): Now static, since it's not used elsewhere.
5043 * character.c (string_count_byte8): Likewise.
5044
5045 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5046 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5047
5048 * chartab.c (copy_sub_char_table): Now static, since it's not used
5049 elsewhere.
5050 (sub_char_table_ref_and_range, char_table_ref_and_range):
5051 Rename locals to avoid shadowing.
5052 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5053
5054 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5055 (BIDI_BOB): Remove unused macro.
5056
5057 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5058 deduce are never used uninitialized.
5059 * term.c (encode_terminal_code): Likewise.
5060
5061 * term.c (encode_terminal_code): Now static. Remove unused local.
5062
5063 * tparam.h: New file.
5064 * term.c, tparam.h: Include it.
5065 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5066 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5067 Move these decls to tparam.h, and make them agree with what
5068 is actually in tparam.c. The previous trick of using incompatible
5069 decls in different modules does not conform to the C standard.
5070 All callers of tparam changed to use tparam's actual API.
5071 * tparam.c (tparam1, tparam, tgoto):
5072 Use const pointers where appropriate.
5073
5074 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5075 * cm.h (struct cm): Likewise.
5076 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5077 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5078 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5079 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5080 (turn_on_face, init_tty): Likewise.
5081 * termchar.h (struct tty_display_info): Likewise.
5082
5083 * term.c (term_mouse_position): Rename local to avoid shadowing.
5084
5085 * alloc.c (mark_ttys): Move decl from here ...
5086 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5087
5088 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5089
5090 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5091
5092 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5093
5094 * search.c (compile_pattern_1): Remove argument regp, unused since
5095 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5096 (compile_pattern): Don't pass it.
5097
5098 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5099
5100 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5101 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5102 for ! HAVE_GTK3.
5103 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5104
5105 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5106
5107 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5108 gdk_window_get_screen, gdk_window_get_geometry,
5109 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5110 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5111 (xg_get_pixbuf_from_pixmap): New function.
5112 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5113 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5114 Call xg_get_pixbuf_from_pixmap instead of
5115 gdk_pixbuf_get_from_drawable.
5116 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5117 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5118 (xg_check_special_colors): Use GtkStyleContext and its functions
5119 for HAVE_GTK3.
5120 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5121 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5122 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5123 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5124 Call gtk_widget_get_preferred_size.
5125 (xg_frame_resized): gdk_window_get_geometry only takes 5
5126 parameters.
5127 (xg_win_to_widget, xg_event_is_for_menubar):
5128 Call gdk_x11_window_lookup_for_display.
5129 (xg_set_widget_bg): New function.
5130 (delete_cb): New function.
5131 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5132 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5133 (xg_set_background_color): Call xg_set_widget_bg.
5134 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5135 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5136 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5137 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5138 if ! HAVE_GTK3.
5139 (update_frame_tool_bar): Call gtk_widget_hide.
5140 (xg_initialize): Use GDK_KEY_g.
5141
5142 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5143 if ! HAVE_GTK3
5144 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5145
5146 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5147 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5148 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5149
5150 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * w32xfns.c (select_palette): Check success of RealizePalette against
5153 GDI_ERROR, not zero.
5154
5155 See ChangeLog.11 for earlier changes.
5156
5157 ;; Local Variables:
5158 ;; coding: utf-8
5159 ;; End:
5160
5161 Copyright (C) 2011 Free Software Foundation, Inc.
5162
5163 This file is part of GNU Emacs.
5164
5165 GNU Emacs is free software: you can redistribute it and/or modify
5166 it under the terms of the GNU General Public License as published by
5167 the Free Software Foundation, either version 3 of the License, or
5168 (at your option) any later version.
5169
5170 GNU Emacs is distributed in the hope that it will be useful,
5171 but WITHOUT ANY WARRANTY; without even the implied warranty of
5172 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5173 GNU General Public License for more details.
5174
5175 You should have received a copy of the GNU General Public License
5176 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.