1 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3 configure: new option --enable-gcc-warnings (Bug#11207)
4 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6 (ALL_CFLAGS): Use new macros rather than old.
7 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
9 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
10 -Wunused-result, -Wunused-variable. This should go away once
11 the Emacs and Gnulib regex code is merged.
12 (xmalloc, xrealloc): Now static.
14 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
16 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
17 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
18 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
19 * s/netbsd.h, s/sol2-6.h:
20 Remove definition of GC_MARK_STACK, since the default now works.
21 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
22 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
23 no longer the default.
24 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
26 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
28 * lread.c (lisp_file_lexically_bound_p):
29 Fix hang at ";-*-\n" (bug#11238).
31 2012-04-14 Eli Zaretskii <eliz@gnu.org>
33 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
34 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
36 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
38 * nsterm.m (constrainFrameRect): Always constrain when there is only
39 one screen (Bug#10962).
41 2012-04-13 Ken Brown <kbrown@cornell.edu>
43 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
45 2012-04-13 Reuben Thomas <rrt@sc3d.org>
47 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
49 2012-04-11 Daniel Colascione <dancol@dancol.org>
51 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
52 against is gone. It's better to use vfork now so that when Cygwin
53 gains a new, working vfork, we use it automatically (bug#10398).
55 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
57 * window.c (save_window_save): Obey window-point-insertion-type.
59 2012-04-11 Glenn Morris <rgm@gnu.org>
61 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
63 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
65 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
67 2012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
69 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
70 (force_quit_count): New var.
71 (handle_interrupt): Use it.
73 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
75 * w32.c (w32_delayed_load): Record the full path of the library
76 being loaded (bug#10424).
78 2012-04-09 Glenn Morris <rgm@gnu.org>
80 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
81 not just in the obarray, before snarfing them. (Bug#11036)
83 * Makefile.in ($(leimdir)/leim-list.el):
84 Pass EMACS rather than BUILT_EMACS.
86 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
88 * process.c (make_process):
89 * process.h: Add integer `gnutls_handshakes_tried' member to
92 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
93 Add convenience `GNUTLS_LOG2i' macro.
95 * gnutls.c (gnutls_log_function2i): Convenience log function.
96 (emacs_gnutls_read): Use new log functions,
97 `gnutls_handshakes_tried' process member, and
98 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
99 attempts per process (connection).
101 2012-04-09 Chong Yidong <cyd@gnu.org>
103 * eval.c (Fuser_variable_p, user_variable_p_eh)
104 (lisp_indirect_variable): Functions deleted.
105 (Fdefvar): Caller changed.
107 * callint.c (Finteractive, Fcall_interactively):
108 * minibuf.c (Fread_variable): Callers changed.
110 2012-04-09 Eli Zaretskii <eliz@gnu.org>
112 * xdisp.c (set_cursor_from_row): If the display string appears in
113 the buffer at position that is closer to point than the position
114 after the display string, display the cursor on the first glyph of
115 the display string. Fixes cursor display when a 'display' text
116 property immediately follows invisible text. (Bug#11094)
118 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
120 composite.c: use 'double' consistently
121 * composite.c (get_composition_id): Use 'double' consistently
122 instead of converting 'float' to 'double' and vice versa; this is
123 easier to understand and avoids a GCC warning.
125 2012-04-09 Glenn Morris <rgm@gnu.org>
127 * Makefile.in: Generate leim-list with bootstrap-emacs, in
128 preparation for dumping it with emacs. (Bug#4789)
129 (leimdir): New variable.
130 ($(leimdir)/leim-list.el): New rule.
131 (emacs$(EXEEXT)): Depend on leim-list.el.
133 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
134 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
135 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
137 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
139 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
142 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
144 * xml.c (init_libxml2_functions) [WINDOWSNT]:
145 Remove unused local variable.
147 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
149 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
150 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
151 (mark_memory): Mark Lisp_Objects only if pointers might hide in
152 objects, as mark_maybe_pointer will catch them otherwise.
153 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
154 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
156 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
158 Fix typo that broke non-Windows builds.
159 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
161 2012-04-07 Eli Zaretskii <eliz@gnu.org>
163 Support building on MS-Windows with libxml2.
165 * makefile.w32-in (OBJ2): Add xml.$(O).
166 (GLOBAL_SOURCES): Add xml.c.
167 ($(BLD)/xml.$(O)): New dependency list.
169 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
170 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
171 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
172 [!WINDOWSNT]: New macros.
173 (init_libxml2_functions, libxml2_loaded_p): New functions.
174 (parse_region): Call fn_xmlCheckVersion instead of using the macro
175 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
176 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
177 Calls xmlCleanupParser only if libxml2 was loaded (or statically
179 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
180 Call init_libxml2_functions before calling libxml2 functions.
181 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
183 * emacs.c: Don't include libxml/parser.h.
184 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
185 xmlCleanupParser directly.
187 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
189 2012-04-07 Eli Zaretskii <eliz@gnu.org>
191 * indent.c (Fvertical_motion): If there is a display string at
192 point, use it.vpos to compute how many lines to backtrack after
193 move_it_to point. (Bug#11133)
195 2012-04-06 Eli Zaretskii <eliz@gnu.org>
197 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
198 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
199 about subtle differences between FETCH_CHAR* and STRING_CHAR*
200 macros related to unification of CJK characters. For the details,
201 see the discussion following the message here:
202 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
204 2012-04-04 Chong Yidong <cyd@gnu.org>
206 * keyboard.c (Vdelayed_warnings_list): Doc fix.
208 2012-04-01 Eli Zaretskii <eliz@gnu.org>
210 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
211 instead of alloca. (Bug#11138)
213 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
215 * w32menu.c (is_simple_dialog): Properly check lisp types.
218 2012-03-31 Eli Zaretskii <eliz@gnu.org>
220 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
221 position we get to after a call to move_it_to fails the
222 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
223 only if we wind up in a string from display property. (Bug#11063)
225 * window.c (Fdelete_other_windows_internal): Invalidate the row
226 and column information about mouse highlight, so that redisplay
227 restores it after reallocating the glyph matrices. (Bug#7464)
229 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
230 string comes from a `display' text property, use the buffer
231 position of that property as if we actually saw that position in
233 (move_it_by_lines): Remove the assertion that
234 "it->current_x == 0 && it->hpos == 0" which can be legitimately
235 violated when there's a before-string at the beginning of a line.
238 2012-03-30 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (append_space_for_newline): If the default face was
241 remapped, use the remapped face for the appended newline.
242 (extend_face_to_end_of_line): Use the remapped default face for
243 extending the face to the end of the line.
244 (display_line): Call extend_face_to_end_of_line when the default
245 face was remapped. (Bug#11068)
247 2012-03-29 Eli Zaretskii <eliz@gnu.org>
249 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
251 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
253 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
255 2012-03-27 Glenn Morris <rgm@gnu.org>
257 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
260 2012-03-26 Kenichi Handa <handa@m17n.org>
262 * dispextern.h (struct glyph): Fix previous change. Change the
263 bit length of glyphless.ch to 25 (Bug#11082).
265 2012-03-26 Chong Yidong <cyd@gnu.org>
267 * keyboard.c (Vselection_inhibit_update_commands): New variable.
268 (command_loop_1): Use it; inhibit selection update for
269 handle-select-window too (Bug#8996).
271 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
273 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
275 2012-03-25 Kenichi Handa <handa@m17n.org>
277 * dispextern.h (struct glyph): Change the bit length of
278 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
280 2012-03-24 Eli Zaretskii <eliz@gnu.org>
282 * s/ms-w32.h (tzname): Include time.h before redirecting to
283 _tzname. Fixes the MSVC build. (Bug#9960)
285 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
287 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
290 * xterm.c (XTread_socket): Only modify handling_signal if
291 !SYNC_INPUT. (Bug#11080)
293 2012-03-23 Eli Zaretskii <eliz@gnu.org>
295 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
296 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
297 when fetching a multibyte character consumes more bytes than
298 CHAR_BYTES returns, due to unification of CJK characters in
299 string_char. (Bug#11073)
301 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
303 * process.c (wait_reading_process_output): Handle pty disconnect
304 by refraining from sending oneself a SIGCHLD (bug#10933).
306 2012-03-22 Chong Yidong <cyd@gnu.org>
308 * dispextern.h (struct it): New member string_from_prefix_prop_p.
310 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
311 Mark string as coming from a prefix property.
312 (handle_face_prop): Use default face for prefix strings (Bug#4281).
313 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
315 2012-03-21 Chong Yidong <cyd@gnu.org>
317 * xfaces.c (Vface_remapping_alist): Doc fix.
319 2012-03-20 Eli Zaretskii <eliz@gnu.org>
321 * w32proc.c (Fw32_set_console_codepage)
322 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
325 2012-03-20 Chong Yidong <cyd@gnu.org>
327 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
328 to reflect default non-nil value of redisplay-dont-pause.
330 2012-03-19 Kenichi Handa <handa@m17n.org>
332 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
333 it fit in a valid range (Bug#11003).
335 2012-03-18 Eli Zaretskii <eliz@gnu.org>
337 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
338 that is not from display property, accept the row as a "cursor
339 row" if one of the string's character has a non-nil `cursor'
340 property. Fixes cursor positioning when there are newlines in
341 overlay strings, e.g. in icomplete.el. (Bug#11035)
343 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
345 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
347 2012-03-12 Chong Yidong <cyd@gnu.org>
349 * eval.c (inhibit_lisp_code): Rename from
350 inhibit_window_configuration_change_hook; move from window.c.
352 * xfns.c (unwind_create_frame_1, Fx_create_frame):
353 * window.c (run_window_configuration_change_hook)
354 (syms_of_window): Callers changed.
356 2012-03-11 Chong Yidong <cyd@gnu.org>
358 * keymap.c (Fkey_description): Doc fix (Bug#9700).
360 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
362 2012-03-10 Chong Yidong <cyd@gnu.org>
364 * frame.c (other_visible_frames): Don't assume the selected frame
365 is visible (Bug#10955).
367 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
369 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
371 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
373 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
374 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
377 2012-03-03 Glenn Morris <rgm@gnu.org>
379 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
381 2012-03-02 Eli Zaretskii <eliz@gnu.org>
383 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
384 position past the first glyph_row that ends at ZV. (Bug#10902)
385 (redisplay_window, next_element_from_string): Fix typos in
387 (redisplay_window): Pass to move_it_vertically the margin in
388 pixels, not in screen lines.
390 2012-03-02 Glenn Morris <rgm@gnu.org>
392 * buffer.c (buffer-list-update-hook): Doc fix.
394 2012-02-29 Eli Zaretskii <eliz@gnu.org>
396 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
397 push_it before setting up the iterator for the first overlay
398 string, even if we have an empty string loaded.
399 (next_overlay_string): If there's an empty string on the iterator
400 stack, pop the stack. (Bug#10903)
402 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
404 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
405 Suggested by Stefan Monnier in
406 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
407 * alloc.c (widen_to_Lisp_Object): New static function.
408 (mark_memory): Also mark Lisp_Objects by fetching pointer words
409 and widening them to Lisp_Objects. This would work even if
410 USE_LSB_TAG is defined and wide integers are used, which might
411 happen in a future version of Emacs.
413 2012-02-25 Chong Yidong <cyd@gnu.org>
415 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
418 * xselect.c (Fx_selection_exists_p): Doc fix.
419 (x_clipboard_manager_save_all): Print an informative message
420 before saving to clipboard manager.
422 2012-02-24 Chong Yidong <cyd@gnu.org>
424 * keyboard.c (process_special_events): Handle all X selection
425 requests in kbd_buffer, not just the next one (Bug#8869).
427 2012-02-23 Chong Yidong <cyd@gnu.org>
429 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
430 call when setting menu-bar-lines and tool-bar-lines parameters.
431 (unwind_create_frame_1): New helper function.
433 * window.c (inhibit_window_configuration_change_hook): New var.
434 (run_window_configuration_change_hook): Obey it.
435 (syms_of_window): Initialize it.
437 2012-02-22 Chong Yidong <cyd@gnu.org>
439 * xterm.c (x_draw_image_relief): Add missing type check for
440 Vtool_bar_button_margin (Bug#10743).
442 2012-02-21 Chong Yidong <cyd@gnu.org>
444 * fileio.c (Vfile_name_handler_alist): Doc fix.
446 * buffer.c (Fget_file_buffer): Protect against invalid file
447 handler return value.
449 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
451 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
452 when computing $valmask.
454 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
455 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
456 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
457 It's useless in that case, and it can cause problems on hosts
458 that allocate halves of EMACS_INT values separately.
459 Reported by Dan Horák. Diagnosed by Andreas Schwab in
460 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
461 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
462 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
463 it avoids undefined behavior on hosts where shifting right by more
464 than the word width has undefined behavior.
466 2012-02-19 Chong Yidong <cyd@gnu.org>
468 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
469 (Funhandled_file_name_directory, Ffile_name_as_directory)
470 (Fdirectory_file_name, Fexpand_file_name)
471 (Fsubstitute_in_file_name): Protect against invalid file handler
472 return values (Bug#10845).
474 2012-02-18 Eli Zaretskii <eliz@gnu.org>
476 * .gdbinit (pitx): Fix incorrect references to fields of the
479 2012-02-17 Chong Yidong <cyd@gnu.org>
481 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
483 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
485 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
486 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
488 2012-02-15 Chong Yidong <cyd@gnu.org>
490 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
491 marked as special. Also, starting docstrings with * is obsolete.
493 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
495 * gnutls.c (emacs_gnutls_write): Fix last change.
497 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
499 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
502 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
504 * keymap.c (Fsingle_key_description): Handle char ranges.
506 2012-02-12 Chong Yidong <cyd@gnu.org>
508 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
509 as that creates a dangerous corner case.
511 * window.c (Fdelete_window_internal): Invalidate the mouse
512 highlight (Bug#9904).
514 2012-02-12 Glenn Morris <rgm@gnu.org>
516 * xselect.c (Fx_own_selection_internal)
517 (Fx_get_selection_internal, Fx_disown_selection_internal)
518 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
519 * nsselect.m (Fx_own_selection_internal)
520 (Fx_disown_selection_internal, Fx_selection_exists_p)
521 (Fx_selection_owner_p, Fx_get_selection_internal):
522 Sync docs and argument specs with the xselect.c versions.
524 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
526 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
528 2012-02-11 Eli Zaretskii <eliz@gnu.org>
530 * w32select.c (Fx_selection_exists_p): Sync doc string and
531 argument list with xselect.c. (Bug#10783)
533 * w16select.c (Fx_selection_exists_p): Sync doc string and
534 argument list with xselect.c. (Bug#10783)
536 2012-02-10 Glenn Morris <rgm@gnu.org>
538 * fns.c (Fsecure_hash): Doc fix.
540 2012-02-09 Kenichi Handa <handa@m17n.org>
542 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
544 2012-02-07 Chong Yidong <cyd@gnu.org>
546 * buffer.c (Fbuffer_local_variables)
547 (buffer_lisp_local_variables): Handle unbound vars correctly;
548 don't let Qunbound leak into Lisp.
550 2012-02-07 Glenn Morris <rgm@gnu.org>
552 * image.c (Fimagemagick_types): Doc fix.
554 * image.c (imagemagick-render-type): Change it from a lisp object
555 to an integer. Move the doc here from the lisp manual.
556 Treat all values not equal to 0 the same.
558 2012-02-06 Chong Yidong <cyd@gnu.org>
560 * doc.c (store_function_docstring): Avoid applying docstring of
561 alias to base function (Bug#2603).
563 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
565 * .gdbinit (pp1, pv1): Remove redundant defines.
568 2012-02-04 Chong Yidong <cyd@gnu.org>
570 * nsterm.m: Declare a global (Bug#10694).
572 2012-02-04 Eli Zaretskii <eliz@gnu.org>
574 * w32.c (get_emacs_configuration_options):
575 Include --enable-checking, if specified, in the return value.
577 2012-02-04 Martin Rudalics <rudalics@gmx.at>
579 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
580 after rounding frame sizes. (Bug#9723)
582 2012-02-04 Eli Zaretskii <eliz@gnu.org>
584 * keyboard.c (adjust_point_for_property): Don't position point
585 before BEGV. (Bug#10696)
587 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
589 Handle overflow when computing char display width (Bug#9496).
590 * character.c (char_width): Return EMACS_INT, not int.
591 (char_width, c_string_width): Check for overflow when
592 computing the width; this is possible now that individual
593 characters can have unbounded width. Problem introduced
594 by merge from Emacs 23 on 2012-01-19.
596 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
598 * dbusbind.c (Fdbus_register_method): Mention the return value
599 :ignore in the docstring.
601 2012-02-02 Glenn Morris <rgm@gnu.org>
603 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
605 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
606 Unconditionally set to t. (Bug#10673)
607 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
608 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
609 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
611 2012-02-02 Kenichi Handa <handa@m17n.org>
613 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
614 0, do not call append_composite_glyph.
616 2012-02-02 Kenichi Handa <handa@m17n.org>
618 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
620 (x_produce_glyphs): If the component of a composition is a null
621 string, set it->pixel_width to 1 to avoid zero-width glyph.
623 2012-02-01 Eli Zaretskii <eliz@gnu.org>
625 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
626 first 2 arguments are identical. This makes inserting large
627 output from a subprocess an order of magnitude faster on
628 MS-Windows, where all sbrk'ed memory is always contiguous.
630 2012-01-31 Glenn Morris <rgm@gnu.org>
632 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
633 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
634 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
636 2012-01-29 Glenn Morris <rgm@gnu.org>
638 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
640 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
642 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
644 2012-01-28 Chong Yidong <cyd@gnu.org>
646 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
648 2012-01-26 Chong Yidong <cyd@gnu.org>
650 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
652 * search.c (Fsearch_forward, Fsearch_backward): Document negative
653 repeat counts (Bug#10507).
655 2012-01-26 Glenn Morris <rgm@gnu.org>
657 * lread.c (syms_of_lread): Doc fix.
659 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
661 * coding.c (encode_designation_at_bol): Change return value to
664 2012-01-25 Chong Yidong <cyd@gnu.org>
666 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
668 2012-01-21 Chong Yidong <cyd@gnu.org>
670 * floatfns.c (Fcopysign): Make the second argument non-optional,
671 since nil is not allowed anyway.
673 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
675 * process.c (read_process_output): Use p instead of XPROCESS (proc).
676 (send_process): Likewise.
678 2012-01-19 Martin Rudalics <rudalics@gmx.at>
680 * window.c (save_window_save, Fcurrent_window_configuration)
681 (Vwindow_persistent_parameters): Do not use Qstate.
684 2012-01-19 Kenichi Handa <handa@m17n.org>
686 * character.c (char_width): New function.
687 (Fchar_width, c_string_width, lisp_string_width):
688 Use char_width (Bug#9496).
690 2012-01-16 Martin Rudalics <rudalics@gmx.at>
692 * window.c (Vwindow_persistent_parameters): New variable.
693 (Fset_window_configuration, save_window_save): Handle persistent
696 2012-01-14 Eli Zaretskii <eliz@gnu.org>
698 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
699 thrashing the stack of the thread. (Bug#9087)
701 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
703 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
705 2012-01-11 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (rows_from_pos_range): Handle the case where the
708 highlight ends on a newline. (Bug#10464)
709 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
710 he end column for display of highlight that ends on a newline
713 2012-01-11 Glenn Morris <rgm@gnu.org>
715 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
716 from load-path also when installation-directory is nil. (Bug#10208)
718 2012-01-10 Glenn Morris <rgm@gnu.org>
720 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
722 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
723 Update template values to be closer to their typical values these days.
725 2012-01-09 Eli Zaretskii <eliz@gnu.org>
727 * xdisp.c (rows_from_pos_range): Accept additional argument
728 DISP_STRING, and accept any glyph in a row whose object is that
729 string as eligible for mouse highlight. Fixes mouse highlight of
730 display strings from overlays. (Bug#10464)
732 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
734 emacs: fix an auto-save permissions race condition (Bug#10400)
735 * fileio.c (auto_saving_dir_umask): New static var.
736 (Fmake_directory_internal): Use it.
737 (do_auto_save_make_dir): Set it, instead of invoking chmod after
738 creating the directory. The old code temporarily assigns
739 too-generous permissions to the directory.
740 (do_auto_save_eh): Clear it.
741 (Fdo_auto_save): Catch all errors, not just file errors, so
742 that the var is always cleared.
744 2012-01-07 Eli Zaretskii <eliz@gnu.org>
746 * search.c (scan_buffer): Pass character positions to
747 know_region_cache, not byte positions. (Bug#6540)
749 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
751 * w32.c (sys_rename): Report EXDEV when rename of a directory
752 fails because the target is on another logical disk. (Bug#10284)
754 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
756 * xterm.c (x_embed_request_focus): New function.
758 * xterm.h: Add prototype.
760 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
762 2012-01-05 Glenn Morris <rgm@gnu.org>
764 * emacs.c (emacs_copyright): Update short copyright year to 2012.
766 2012-01-01 Eli Zaretskii <eliz@gnu.org>
768 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
769 Load gnutls_transport_set_lowat only if GnuTLS version is below
771 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
772 GnuTLS versions below 2.11.1.
774 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
776 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
777 to the doc string advising against its use for altering the way
778 windows are scrolled.
780 2011-12-28 Kenichi Handa <handa@m17n.org>
782 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
783 coding-system ASCII compatible only when it does not produce BOM
784 on encoding (Bug#10383).
786 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
788 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
790 (create_and_show_popup_menu): Always use menu_position_func for
793 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
795 * callint.c (Fcall_interactively): Don't truncate prompt string.
797 2011-12-23 Eli Zaretskii <eliz@gnu.org>
799 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
800 property that ends at ZV, so that the bidi iteration could be
801 resumed from there (after widening). (Bug#10360)
803 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
805 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
807 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
809 * nsterm.m (x_free_frame_resources):
810 Release f->output_data.ns->miniimage.
811 (ns_index_color): Fix indentation. Do not retain
812 color_table->colors[i].
814 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
817 * nsfns.m (x_set_background_color): Assign return value from
818 ns_index_color to face-background instead of NSColor*.
819 (ns_implicitly_set_icon_type): Fix indentation.
820 Change assignment in for loop to comparison.
822 * emacs.c (ns_pool): New variable.
823 (main): Assign ns_pool.
824 (Fkill_emacs): Call ns_release_autorelease_pool.
826 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
827 autorelease fdesc, release fdAttrs and tdict.
828 (ns_get_covering_families): Release charset.
829 (ns_findfonts): Release NSFontDescriptor created with new.
830 (ns_uni_to_glyphs): Fix indentation.
831 (setString): Release attrStr before assigning new value.
833 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
835 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
837 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
838 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
840 2011-12-18 David Reitter <reitter@cmu.edu>
842 * nsterm.m (ns_term_init): Subscribe for notifications
843 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
844 to method trackingNotification in EmacsMenu.
846 * nsmenu.m (trackingMenu): New variable.
847 (trackingNotification): New method (from Aquamacs).
848 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
849 from Aquamacs (Bug#7030).
851 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
853 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
854 (symbol_to_nsstring): Fix indentation.
855 (ns_symbol_to_pb): New function.
856 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
857 (Fns_rotate_cut_buffers_internal): Remove.
858 (Fns_store_selection_internal): Rename from
859 Fns_store_cut_buffer_internal.
860 (ns_get_foreign_selection, Fx_own_selection_internal)
861 (Fx_disown_selection_internal, Fx_selection_exists_p)
862 (Fns_get_selection_internal, Fns_store_selection_internal):
863 Use ns_symbol_to_pb and check if return value is nil.
864 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
865 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
866 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
867 renamed to Sns_store_selection_internal.
868 (ns_handle_selection_request): Move code to Fx_own_selection_internal
869 and remove this function.
870 (ns_handle_selection_clear): Remove, never used.
871 (Fx_own_selection_internal): Move code from ns_handle_selection_request
874 2011-12-17 Ken Brown <kbrown@cornell.edu>
876 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
877 GID is unknown (Bug#10257).
879 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
881 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
882 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
883 which caused a build failure on GNU/Linux IA-64. This problem was
884 introduced by my 2011-10-07 patch.
886 2011-12-15 Juri Linkov <juri@jurta.org>
888 * image.c (imagemagick_error): New function. (Bug#10112)
889 (imagemagick_load_image): Comment out `MagickSetResolution' call.
890 Use `imagemagick_error' where ImageMagick functions return
892 (Fimagemagick_types): Add `Fnreverse' to return the list in the
895 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
897 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
898 fill background (Bug#8992).
900 2011-12-13 Martin Rudalics <rudalics@gmx.at>
902 * window.c (Vwindow_combination_resize)
903 (Vwindow_combination_limit): Use t instead of non-nil in
905 (Vrecenter_redisplay): Add first sentence of doc-string on
907 (Frecenter): Fix doc-string typo.
909 2011-12-11 Kenichi Handa <handa@m17n.org>
911 * coding.c (Funencodable_char_position): Pay attention to the
912 buffer text relocation (Bug#9389).
914 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
916 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
917 gtk_init (Bug#10100).
919 2011-12-10 Eli Zaretskii <eliz@gnu.org>
921 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
922 IT->string is nil. (Bug#10263)
924 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
926 * nsterm.h (x_free_frame_resources): Declare.
928 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
929 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
931 * nsterm.h (ns_get_defaults_value): Declare.
933 * nsterm.m (ns_default): Call ns_get_defaults_value.
935 2011-12-09 Eli Zaretskii <eliz@gnu.org>
937 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
940 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
942 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
943 that where the value of an _OBJC_* symbol points to is in the .bss
946 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
948 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
949 after the loop to call ccl_driver at least once (Bug#8619).
951 2011-12-08 Kenichi Handa <handa@m17n.org>
953 * ftfont.c (get_adstyle_property): Fix previous change
956 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
958 * w32.c (init_environment): If no_site_lisp, remove site-lisp
959 dirs from the default value of EMACSLOADPATH (bug#10208).
961 2011-12-07 Glenn Morris <rgm@gnu.org>
963 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
964 installation and source directories as well. (Bug#10208)
966 2011-12-06 Chong Yidong <cyd@gnu.org>
968 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
970 2011-12-06 Glenn Morris <rgm@gnu.org>
972 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
973 as an error, not just -1. (Bug#10217)
975 2011-12-05 Chong Yidong <cyd@gnu.org>
977 * keyboard.c (process_special_events): New function.
978 (swallow_events, Finput_pending_p): Use it (Bug#10195).
980 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
982 * coding.c (encode_designation_at_bol): Don't use uninitialized
983 local variable (Bug#9318).
985 2011-12-05 Kenichi Handa <handa@m17n.org>
987 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
988 return Qnil (Bug#8046, Bug#10193).
990 2011-12-05 Kenichi Handa <handa@m17n.org>
992 * coding.c (encode_designation_at_bol): New args charbuf_end and
993 dst. Return the number of produced bytes. Callers changed.
994 (coding_set_source): Return how many bytes coding->source was
996 (coding_set_destination): Return how many bytes
997 coding->destination was relocated.
998 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
999 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1001 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1003 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1004 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1007 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1009 The following changes are to fix Bug#9318.
1011 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1012 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1013 (encode_coding_iso_2022, encode_coding_sjis)
1014 (encode_coding_big5, encode_coding_charset): Use the above macros.
1016 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1018 * lisp.h (process_quit_flag): Fix external declaration.
1020 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1022 Don't macro-inline non-performance-critical code.
1023 * eval.c (process_quit_flag): New function.
1024 * lisp.h (QUIT): Use it.
1026 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1028 * nsfns.m (get_geometry_from_preferences): New function.
1029 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1031 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1033 * emacs.c (Qkill_emacs): Define.
1034 (syms_of_emacs): Initialize it.
1035 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1036 Qquit_flag to `kill-emacs' instead.
1037 (quit_throw_to_read_char): Add parameter `from_signal'.
1038 All callers changed. Call Fkill_emacs if requested and safe.
1039 * lisp.h (QUIT): Call Fkill_emacs if requested.
1041 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1043 * widget.c (update_wm_hints): Return if wmshell is null.
1044 (widget_update_wm_size_hints): New function.
1046 * widget.h (widget_update_wm_size_hints): Declare.
1048 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1049 widget_update_wm_size_hints (Bug#10104).
1051 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1053 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1054 before a newline, prepare the bidi iterator for consuming the
1055 newline, and keep the current paragraph direction. (Bug#10183)
1056 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1058 2011-12-02 Juri Linkov <juri@jurta.org>
1060 * search.c (Fword_search_regexp): New Lisp function created from
1061 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1062 (Fword_search_backward, Fword_search_forward)
1063 (Fword_search_backward_lax, Fword_search_forward_lax):
1064 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1065 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1067 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1069 * fileio.c (Finsert_file_contents): Move after-change-function call
1070 to before the "handled:" label, since all "goto handled" appear in
1071 cases where the *-change-functions have already been properly called
1074 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1076 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1077 waiting for input. (Bug#10169)
1079 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1081 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1082 verifies glyph row's hash code--we have just reallocated the
1083 glyphs, so their contents can be complete garbage. (Bug#10164)
1085 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1087 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1089 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1091 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1092 attributes are tested _before_ calling verify_row_hash, to protect
1093 against GCC re-ordering of the tests. (Bug#10164)
1095 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1097 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1099 * xterm.c (handle_one_xevent): Only set async_visible and friends
1100 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1101 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1102 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1104 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1106 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1107 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1108 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1109 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1110 All uses changed to use GCPRO1 etc.
1111 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1112 Revert to old implementation (i.e., before 2011-03-11).
1114 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1116 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1117 of scroll runs so as to avoid assigning disabled bogus rows and
1118 unnecessary graphics copy operations.
1120 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1122 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1123 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1124 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1125 (malloc, free, realloc, calloc): Redirect to e_* only when
1128 * lisp.h (GCTYPEBITS): Move before first use.
1129 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1130 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1131 this macro definition.
1133 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1136 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1138 * gtkutil.c (xg_create_frame_widgets):
1139 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1140 present with Gtk+ 2.0.
1142 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1144 * fileio.c (Finsert_file_contents): Undo previous change; see
1145 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1147 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1149 Rename locals to avoid shadowing.
1150 * fileio.c (Finsert_file_contents):
1151 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1152 * process.c (wait_reading_process_output):
1153 Rename inner 'proc' to 'p' to avoid shadowing.
1154 Indent for consistency with usual Emacs style.
1156 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1158 * xdisp.c (redisplay_window): If cursor row is not fully visible
1159 after recentering, and scroll-conservatively is set to a large
1160 number, scroll window by a few more lines to make the cursor fully
1161 visible and out of scroll-margin. (Bug#10105)
1162 (start_display): Don't move to the next line if the display should
1163 start at a newline that is part of a display vector or an overlay
1166 2011-11-24 Juri Linkov <juri@jurta.org>
1168 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1169 after the `MagickPingImage' call. (Bug#10112)
1171 2011-11-23 Chong Yidong <cyd@gnu.org>
1173 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1175 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1177 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1178 making another buffer current. (Bug#10114)
1180 2011-11-23 Glenn Morris <rgm@gnu.org>
1182 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1184 2011-11-23 Chong Yidong <cyd@gnu.org>
1186 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1187 using it (Bug#5984).
1189 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1191 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1192 and header-lines, as they don't have one computed for them.
1195 * .gdbinit (prow): Make displayed values more self-explaining.
1196 Add row's hash code.
1198 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1200 * process.c (wait_reading_process_output): Fix asynchrounous
1201 GnuTLS socket handling on some versions of the GnuTLS library.
1202 (wait_reading_process_output): Add comment and URL.
1204 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1206 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1208 2011-11-21 Chong Yidong <cyd@gnu.org>
1210 * window.c (Fnext_window, Fprevious_window): Doc fix.
1212 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1214 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1216 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1218 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1220 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1222 * window.c (Fset_window_combination_limit): Rename argument
1224 (Vwindow_combination_limit): Remove "status" from doc-string.
1226 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1228 * m/ibms390.h: Remove.
1229 * m/ibms390x.h: Don't include "ibms390.h".
1231 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1233 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1234 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1236 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1238 * casetab.c (Fset_case_table):
1239 * charset.c (Fcharset_after): Fix typos.
1241 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1243 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1244 Otherwise, valgrind does not work on some platforms.
1245 Problem reported by Andreas Schwab in
1246 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1247 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1248 is set, removing the need for VIRT_ADDRESS_VARIES.
1249 (PURE_P): Use a more-efficient implementation that needs just one
1250 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1251 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1252 to 4 (xorl, subq, cmpq, setbe).
1253 * alloc.c (pure): Always extern now, since that's the
1254 VIRT_ADDR_VARIES behavior.
1255 (PURE_POINTER_P): Use a single comparison, not two, for
1256 consistency with the new puresize.h.
1257 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1258 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1259 Remove VIRT_ADDR_VARIES no longer needed.
1261 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1263 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1264 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1265 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1266 behave as if the cursor position were at the window margin.
1268 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1269 and the cursor position is out of bounds, behave as if the cursor
1270 position were at the window margin. (Bug#10075)
1272 2011-11-18 Chong Yidong <cyd@gnu.org>
1274 * window.c (Fwindow_combination_limit): Make first argument
1275 non-optional, since it is meaningless for live windows like the
1278 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1280 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1282 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1284 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1285 (graft_intervals_into_buffer): Simplify.
1287 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1289 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1290 hash values of the two rows.
1291 (copy_row_except_pointers): Preserve the used[] arrays and the
1292 hash values of the two rows. (Bug#10035)
1293 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1295 * xdisp.c (row_hash): New function, body extracted from
1296 compute_line_metrics.
1297 (compute_line_metrics): Call row_hash, instead of computing the
1300 * dispnew.c (verify_row_hash): Call row_hash for computing the
1301 hash code of a row, instead of duplicating code from xdisp.c.
1303 * dispextern.h (row_hash): Add prototype.
1305 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1307 * frame.c (delete_frame): Don't delete the terminal when the last
1308 X frame is closed if emacs is built with GTK toolkit.
1310 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1312 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1314 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1316 * window.c (Vwindow_splits): Rename to
1317 Vwindow_combination_resize. Suggested by Juri Linkov.
1318 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1321 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1323 * nsfns.m (Fns_font_name):
1324 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1326 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1328 * window.h (window): Rename slot "nest" to "combination_limit".
1329 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1330 (Fset_window_nest): Rename to Fset_window_combination_limit.
1331 (Vwindow_nest): Rename to Vwindow_combination_limit.
1332 (recombine_windows, make_parent_window, make_window)
1333 (Fsplit_window_internal, saved_window)
1334 (Fset_window_configuration, save_window_save): Rename all
1335 occurrences of window_nest to window_combination_limit.
1337 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1339 * image.c (imagemagick_load_image): Fix typo.
1341 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1343 * xdisp.c (display_line): Move the call to
1344 highlight_trailing_whitespace before the call to
1345 compute_line_metrics, since the latter needs to see the final
1346 faces of all the glyphs to compute ROW's hash value.
1347 Fixes assertion violations in row_equal_p. (Bug#10035)
1349 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1351 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1352 just return (bug#10044).
1354 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1356 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1357 with user-defined heap size. Bump the default size of the temacs
1358 heap to 27MB, to avoid memory warning when running temacs.
1359 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1361 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1362 current_matrix and desired_matrix. (Bug#9990)
1363 (verify_row_hash) [XASSERTS]: New function.
1364 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1365 that the hash value of glyph rows is correct.
1367 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1369 * window.h (window): Remove splits slot.
1370 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1371 (Fdelete_other_windows_internal, make_parent_window)
1372 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1373 (Fset_window_configuration, save_window_save): Don't deal with
1374 split status of windows.
1375 (saved_window): Remove splits slot.
1376 (Vwindow_splits): Rewrite doc-string.
1378 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1380 * xfns.c (unwind_create_frame):
1381 * nsfns.m (unwind_create_frame):
1382 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1383 Vframe_list (Bug#9999).
1385 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1387 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1389 2011-11-11 Kenichi Handa <handa@m17n.org>
1391 * callproc.c (Fcall_process): Set the member dst_multibyte of
1394 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1396 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1397 avoid a crash (bug#9496).
1399 2011-11-09 Chong Yidong <cyd@gnu.org>
1401 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1402 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1404 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1406 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1408 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1410 Avoid some portability problems by eschewing 'extern inline' functions.
1411 The trivial performance wins aren't worth the portability hassles; see
1412 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1414 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1415 (window_box_width, window_box_left, window_box_left_offset)
1416 (window_box_right, window_box_right_offset): Undo previous change,
1417 by removing the "extern"s.
1418 * intervals.c (adjust_intervals_for_insertion)
1419 (adjust_intervals_for_deletion): Undo previous change,
1420 making these static again.
1421 (offset_intervals, temp_set_point_both, temp_set_point)
1422 (copy_intervals_to_string): No longer inline.
1423 * xdisp.c (window_text_bottom_y, window_box_width)
1424 (window_box_height, window_box_left_offset)
1425 (window_box_right_offset, window_box_left, window_box_right)
1426 (window_box): No longer inline.
1428 2011-11-08 Chong Yidong <cyd@gnu.org>
1430 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1431 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1432 Signal an error if not a live window.
1433 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1434 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1436 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1438 * lisp.h (syms_of_abbrev): Remove declaration.
1439 Reported by CHENG Gao <chenggao@royau.me>.
1441 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1443 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1444 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1445 of temacs in GUI mode.
1447 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1449 * window.h: Declare delete_all_child_windows instead of
1450 delete_all_subwindows.
1451 * window.c (Fwindow_nest, Fset_window_nest)
1452 (Fset_window_new_total, Fset_window_new_normal)
1453 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1454 (delete_all_subwindows): Rename to delete_all_child_windows.
1455 (Fdelete_other_windows_internal, Fset_window_configuration):
1456 Call delete_all_child_windows instead of delete_all_subwindows.
1457 * frame.c (delete_frame): Call delete_all_child_windows instead
1458 of delete_all_subwindows.
1460 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1462 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1463 This is also needed for porting to any host where GC_MARK_STACK is
1464 not GC_MAKE_GCPROS_NOOPS.
1465 (which_symbols): Use it.
1467 2011-11-07 Kenichi Handa <handa@m17n.org>
1469 * coding.c (coding_set_destination): Check coding->src_pos only
1470 when coding->src_object is a buffer (bug#9910).
1472 * process.c (send_process): Set the member src_multibyte of coding
1473 to 0 (bug#9911) when sending a unibyte text.
1475 * callproc.c (Fcall_process): Set the member src_multibyte of
1476 process_coding to 0 (bug#9912).
1478 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1480 * xmenu.c (cleanup_widget_value_tree): New function.
1481 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1482 calling free_menubar_widget_value_tree directly (Bug#9830).
1484 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1486 Fix some portability problems with 'inline'.
1487 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1488 (window_box_width, window_box_left, window_box_left_offset)
1489 (window_box_right, window_box_right_offset): Declare extern.
1490 Otherwise, these inline functions do not conform to C99 and
1491 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1492 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1493 * intervals.c (adjust_intervals_for_insertion)
1494 (adjust_intervals_for_deletion): Now extern, because otherwise the
1495 extern inline functions 'offset_intervals' couldn't refer to it.
1496 (static_offset_intervals): Remove.
1497 (offset_intervals): Rewrite using the old contents of
1498 static_offset_intervals. The old version didn't conform to C99
1499 because an extern inline function contained a reference to an
1500 identifier with static linkage.
1502 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1504 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1507 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1509 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1510 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1511 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1512 return Qleft_to_right.
1514 2011-11-06 Chong Yidong <cyd@gnu.org>
1516 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1517 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1518 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1519 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1520 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1521 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1522 (Fwindow_vscroll): Doc fix.
1523 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1524 argument, since it makes no sense to pass a live window and for
1525 consistency with window-child.
1527 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1529 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1532 2011-11-05 Jason Rumney <jasonr@gnu.org>
1534 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1535 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1537 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1538 bitwise arithmetic preventing use of unicode-sip and non-truetype
1541 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1543 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1546 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1547 initialization code to keep similarity to xfns.c after changes
1550 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1552 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1553 (unwind_create_frame): New function (Bug#9943).
1554 (Fx_create_frame): Restructure code to be more similar to the one in
1555 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1556 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1557 Move terminal->reference_count++ just before making the frame official
1560 * nsterm.m (x_free_frame_resources): New function.
1561 (x_destroy_window): Move code to x_free_frame_resources.
1563 * xfns.c (unwind_create_frame): Fix comment.
1564 (Fx_create_frame, x_create_tip_frame):
1565 Move terminal->reference_count++ just before making the frame
1566 official. Move initialization of image_cache_refcount and
1567 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1569 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1571 Support MSVC build with newer versions of Visual Studio.
1572 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1573 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1576 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1577 which are not supported by MSVC.
1578 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1579 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1581 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1583 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1585 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1587 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1589 Support MSVC build with newer versions of Visual Studio.
1590 * w32.c: Don't include w32api.h for MSVC.
1591 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1593 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1594 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1595 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1596 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1598 (alloca) [_MSC_VER]: Define to _alloca.
1600 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1602 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1604 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1606 * xdisp.c (note_mouse_highlight): If either of
1607 previous/next-single-property-change returns nil, treat that as
1608 the beginning or the end of the buffer. (Bug#9955)
1610 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1612 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1613 label is not null (Bug#9951).
1614 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1617 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1619 * window.c (Fwindow_body_size): Mention in the doc string that the
1620 return value is in frame's canonical units. (Bug#9949)
1622 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1624 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1626 * w32fns.c (unwind_create_frame): If needed, free the glyph
1627 matrices of the partially constructed frame. (Bug#9943)
1628 * xfns.c (unwind_create_frame): Likewise.
1630 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1632 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1633 Don't stop backward scan on the continuation glyph, even though
1634 its CHARPOS is positive.
1635 (mouse_face_from_buffer_pos, note_mouse_highlight):
1636 Rename cover_string to disp_string.
1638 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1640 * window.c (temp_output_buffer_show): Don't use
1641 Vtemp_buffer_show_specifiers.
1642 (Vtemp_buffer_show_specifiers): Remove unused variable.
1644 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1646 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1647 past the beginning of the current glyph matrix.
1649 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1651 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1652 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1653 HAVE_GTK3 (Bug#9869).
1655 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1656 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1658 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1660 * xterm.c: Declare x_handle_net_wm_state to return int.
1661 (handle_one_xevent): Check if we are iconified but don't have
1662 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1663 (get_current_wm_state): Return non-zero if not hidden,
1664 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1665 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1666 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1667 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1669 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1671 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1672 so that this new function doesn't get optimized away by a
1673 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1675 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1677 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1679 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1681 Fix the `xbytecode' command.
1682 * .gdbinit (xprintbytestr): New command.
1683 (xwhichsymbols): Rename from `which'; all callers changed.
1684 (xbytecode): Print the byte-code string as well.
1686 2011-10-29 Kim Storm <storm@cua.dk>
1688 * alloc.c (which_symbols): New function.
1690 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1692 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1695 2011-10-29 Glenn Morris <rgm@gnu.org>
1697 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1698 Not clear what it was for, and it causes various bugs. (Bug#9839)
1700 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1702 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1703 possible random value that matches one of those tested as
1704 condition to clear the mouse face.
1706 2011-10-28 Chong Yidong <cyd@gnu.org>
1708 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1710 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1712 * window.c (make_window): Initialize phys_cursor_on_p.
1714 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1716 * lisp.h (struct Lisp_Symbol): Update comments.
1718 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1720 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1722 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1724 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1725 <oslsachem@gmail.com> for helping to debug this.
1727 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1728 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1729 (g_b_init_get_glyph_outline_w): New static variables.
1730 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1731 (GetGlyphOutlineW_Proc): New typedefs.
1732 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1733 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1735 (w32font_open_internal, compute_metrics):
1736 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1737 instead of calling the "wide" APIs directly.
1739 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1741 * w32.h (syms_of_w32font): Add prototype.
1743 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1745 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1746 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1747 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1748 (Fmove_to_window_line): Doc fix.
1750 2011-10-27 Chong Yidong <cyd@gnu.org>
1752 * process.c (make_process): Set gnutls_state to NULL.
1754 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1755 non-NULL, regardless of GNUTLS_INITSTAGE.
1756 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1757 an error. Set process slots as soon as we allocate them.
1759 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1761 2011-10-27 Chong Yidong <cyd@gnu.org>
1763 * gnutls.c (emacs_gnutls_deinit): New function.
1764 Deallocate credentials structures as well as calling gnutls_deinit.
1765 (Fgnutls_deinit, Fgnutls_boot): Use it.
1767 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1768 (deactivate_process): Call emacs_gnutls_deinit.
1770 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1772 * image.c (x_create_x_image_and_pixmap):
1773 * w32.c (sys_rename, w32_delayed_load):
1774 * w32font.c (fill_in_logfont):
1775 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1777 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1779 * w32fns.c (w32_default_color_map): New function,
1780 extracted from Fw32_default_color_map.
1781 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1783 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1785 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1787 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1789 * keyboard.c (test_undefined): New function (bug#9751).
1790 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1792 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1794 * sysdep.c (init_sys_modes): Fix the check for the controlling
1795 terminal (Bug#6649).
1797 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1799 * dispextern.h (struct bidi_it): New member next_en_type.
1801 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1802 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1803 current character, check also for next_en_type being WEAK_EN.
1804 (bidi_resolve_weak): Don't enter the expensive loop if the current
1805 position is before next_en_pos. Record the bidi type of the first
1806 non-ET, non-BN character we find, in addition to its position.
1807 (bidi_level_of_next_char): Invalidate next_en_type when
1808 next_en_pos is over-stepped.
1810 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1812 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1813 * editfns.c: Rewrite current-time-zone so that it invokes
1814 the equivalent of (format-time-string "%Z") to get the time zone name.
1815 This fixes a bug when the time zone name contains characters that
1816 need converting from the system time locale to Emacs internal format.
1817 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1818 that patch fixed format-time-string to do the conversion, but
1819 I forgot to fix current-time-zone.
1820 (format_time_string): New function, containing most of
1821 what Fformat_time_string used to contain.
1822 (Fformat_time_string): Rewrite in terms of format_time_string.
1823 This doesn't change this function's behavior.
1824 (current-time-zone): Rewrite to use format_time_string.
1825 This fixes the bug reported by Michael Schierl in
1826 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1827 Jason Rumney's 2007-06-07 change worked around this bug, but
1829 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1831 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1833 * xdisp.c (start_display): If the character at POS is displayed
1834 via a display vector, reset IT->current.dpvec_index to zero.
1835 (try_window_reusing_current_matrix): If a line ends in a display
1836 vector or the next line starts in a display vector, continue
1837 redrawing the window even though the character position of
1838 start_row was reached.
1841 2011-10-18 Chong Yidong <cyd@gnu.org>
1843 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1844 with nobreak-char-display too.
1846 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1848 Fix part 3 of bug#9771.
1849 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1850 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1851 non-neutral characters if the current character is a paragraph
1852 separator (a.k.a. Newline). This avoids running the same
1853 expensive loop twice, once when we consume the preceding newline
1854 and the other time when the line actually needs to be displayed.
1855 Avoid the loop when we see neutrals on the base embedding level
1856 following a character whose directionality is the same as the
1857 paragraph's. This avoids running the expensive loop when a line
1858 ends in a long sequence of neutrals, like control characters.
1859 Add assertion against STRONG_AL type. Slightly rearrange code
1860 that determines the type of a neutral given the first non-neutral
1862 (bidi_level_of_next_char): Set next_en_pos to zero when
1863 invalidating its info.
1865 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1867 * xdisp.c (push_display_prop): Determine whether to record string
1868 or buffer position by IT->string, not by IT->method. Allow
1869 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1870 (move_it_vertically_backward): Don't look for character position
1871 immediately after the newline when in a continuation line.
1874 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1876 * window.c (coordinates_in_window): Rewrite and delabelize
1877 vertical border check. (Bug#5357) (Bug#9618)
1879 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1881 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1882 errors in XSetWindowBorder (bug#9310).
1884 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1886 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1887 avoid crash when xmalloc overrun checking is enabled.
1889 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1891 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1892 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1893 cursor motion with <left> and <right> arrow keys.
1895 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1896 some callers set that themselves.
1898 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1900 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1901 display string and the previous row comes from the same string and
1902 is empty. (Bug#9739) (Bug#9738)
1904 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1906 * doc.c (get_doc_string): Encode file name (bug#9735).
1908 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1910 * bidi.c (bidi_level_of_next_char):
1911 * xdisp.c (get_visually_first_element): Remove old incorrect
1912 comments regarding the Unicode Line Separator character.
1914 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1916 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1918 * alloc.c (Fgc_status): Do not access beyond zombies array
1919 boundary if nzombies > MAX_ZOMBIES.
1920 * alloc.c (dump_zombies): Add missing format specifier.
1922 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1924 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1925 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1927 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1928 Some packages use them to denote characters with modifiers.
1930 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1932 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1933 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1934 matching a pp-number. Rename parameter var to var1.
1936 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1938 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1940 2011-10-08 Glenn Morris <rgm@gnu.org>
1942 * callint.c (Fcall_interactively): Give a more explicit error for the
1943 'c' case with a non-character input. (Bug#8479)
1945 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1949 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1950 lines that are hscrolled on the left.
1952 * dispnew.c (buffer_posn_from_coords): Account for a possible
1953 presence of header-line. (Bug#4426)
1955 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1957 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1958 Don't advertise functionality which we discourage or doesn't work.
1960 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1962 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1963 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1964 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1965 this makes Emacs dump core during garbage collection on rare
1966 occasions. sizeof is obviously inferior to offsetof here, so
1967 stick with offsetof.
1968 (GC_POINTER_ALIGNMENT): New macro.
1969 (mark_memory): Omit 3rd (offset) arg; caller changed.
1970 Don't assume EMACS_INT alignment is the same as pointer alignment.
1972 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1974 * keyboard.c (read_key_sequence_remapped): New var.
1975 (read_key_sequence): Compute remapping in the right buffer.
1976 (command_loop_1): Use read_key_sequence's remapping directly.
1978 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1980 * dired.c (file_name_completion): Don't expand file name.
1981 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1982 before checking file name handler.
1984 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1985 they've been requested explicitly (bug#9591).
1987 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1989 * keymap.c (Fsingle_key_description): Use make_specified_string
1990 instead of build_string to build string from push_key_description.
1993 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1995 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1996 This fixes a Y2038 bug on 64-bit hosts.
1997 * buffer.c (reset_buffer):
1998 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1999 (Fclear_buffer_auto_save_failure):
2000 Use 0, not -1, to represent an unset failure time, since time_t
2001 might not be signed.
2003 Remove dependency on glibc malloc internals.
2004 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2005 Move back here from lisp.h, but with their new implementations.
2006 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2007 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2008 * charset.c (charset_table_init): New static var.
2009 (syms_of_charset): Use it instead of xmalloc. This removes a
2010 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2011 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2012 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2013 Move back to alloc.c.
2014 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2015 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2017 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2019 * nsterm.m (windowDidResize): Call x_set_window_size only when
2020 ns_in_resize is true. Otherwise set pixelwidth/height and
2021 call change_frame_size (Bug#9628).
2023 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2025 Port --enable-checking=all to Fedora 14 x86-64.
2026 * charset.c (syms_of_charset): Also account for glibc malloc's
2027 internal overhead when calculating the initial malloc maximum.
2029 Port --enable-checking=all to Fedora 14 x86.
2030 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2032 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2033 (overrun_check_realloc, overrun_check_free):
2034 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2035 That way, xmalloc returns a properly-aligned pointer even if
2036 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2037 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2038 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2039 into account when calculating the initial malloc maximum.
2040 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2041 Move here from alloc.c, so that charset.c can use it too.
2042 Properly align; the old code wasn't right for common 32-bit hosts
2043 when configured with --enable-checking=all.
2044 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2045 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2047 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2049 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2052 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2054 * xdisp.c (compute_display_string_end): If there's no display
2055 string at CHARPOS, return -1.
2057 * bidi.c (bidi_fetch_char): When compute_display_string_end
2058 returns a negative value, treat the character as a normal
2059 character not covered by a display string. (Bug#9624)
2061 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2063 * lread.c (Fread_from_string): Fix typo in docstring.
2065 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2067 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2068 newline, reseat the iterator instead of bidi-iterating there one
2069 character at a time. (Bug#9610)
2070 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2071 TO_CHARPOS if the bidi iterator is at base embedding level.
2073 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2075 * lread.c (readevalloop): Use correct code for NBSP.
2076 (read1): Likewise. (Bug#9608)
2078 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2080 * dbusbind.c (Fdbus_register_signal): When service is not
2081 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2083 2011-09-25 Glenn Morris <rgm@gnu.org>
2085 * buffer.c (truncate-lines): Doc fix.
2087 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2089 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2090 (Fset_window_next_buffers): Doc fix.
2092 2011-09-24 Glenn Morris <rgm@gnu.org>
2094 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2096 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2098 Fix minor problems found by static checking.
2099 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2100 * indent.c (Fvertical_motion): Fix == vs = typo.
2102 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2104 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2105 Default value is now t. Doc fix.
2107 * indent.c (Fvertical_motion): Compute and apply the overshoot
2108 logic when moving up, not only when moving down. Fix the
2109 confusing name and values of the it_overshoot_expected variable;
2110 logic changes accordingly. (Bug#9254) (Bug#9549)
2112 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2113 CHARPOS is covered by a display string which includes newlines.
2114 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2115 is covered by a display string with embedded newlines.
2117 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2119 * dbusbind.c (Fdbus_register_signal): Add match rule to
2120 Vdbus_registered_objects_table. (Bug#9581)
2121 (Fdbus_register_method, Vdbus_registered_objects_table):
2124 2011-09-24 Jim Meyering <meyering@redhat.com>
2126 do not ignore write error for any output size
2127 The previous change was incomplete.
2128 While it makes emacs --batch detect the vast majority of stdout
2129 write failures, errors were still ignored whenever the output size is
2130 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2131 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2132 && echo FAIL: ignored write error
2133 FAIL: ignored write error
2134 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2135 && echo FAIL: ignored write error
2136 FAIL: ignored write error
2137 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2139 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2141 * emacs.c (Fkill_emacs): In noninteractive mode exit
2142 non-successfully if a write error occurred on stdout. (Bug#9574)
2144 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2149 * dispextern.h (struct it): Update the comment documenting what
2152 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2154 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2155 a display string, extend search for cursor position to end of row.
2156 (find_row_edges): If the row ends in a newline from a display
2157 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2158 Handle the case of a display string with multiple newlines.
2159 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2160 non-empty line. Fixes confusing cursor motion with arrow keys at
2161 the beginning of a line that starts with whitespace.
2163 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2165 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2168 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2170 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2173 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2175 * xdisp.c (display_line): Record maximum and minimum buffer
2176 positions even if no glyphs were produced (e.g., by a zero-width
2177 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2178 buffer positions that will be removed from the glyph row because
2180 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2181 column is beyond frame width: don't subtract 1 "pixel" when
2182 computing width of the stretch.
2183 (reseat_at_next_visible_line_start): Undo the change made on
2184 2011-09-17 that saved paragraph information and restored it after
2185 the call to `reseat'. (Bug#9545)
2187 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2189 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2190 and turn window cursor on if cleared (Bug#9415).
2192 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2194 * search.c (boyer_moore): Take unibyte characters from pattern
2195 literally. (Bug#9458)
2197 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2199 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2201 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2203 Fix minor problem found by static checking.
2204 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2205 initialized, to pacify gcc -Wuninitialized.
2207 * fileio.c: Report proper errno when syscall falls.
2208 (Finsert_file_contents): Save and restore errno,
2209 so that report_file_error outputs the correct diagnostic.
2210 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2212 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2214 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2216 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2218 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2219 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2221 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2223 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2224 about the current paragraph and restore it after the call to reseat.
2226 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2227 (bidi_find_paragraph_start): Search back for paragraph beginning
2228 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2229 (bidi_move_to_visually_next): Only trigger paragraph-related
2230 computations when the last character is a newline or at EOB, not
2231 just any NEUTRAL_B. (Bug#9470)
2233 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2234 truncated lines if point is covered by a display string. (Bug#9524)
2236 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2238 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2239 (cons_to_x_long): New function.
2240 (lisp_data_to_selection_data): Use it. Correct the test for
2241 short-versus-long data; it was negated. Break out of vector
2242 loop, for efficiency, when a long datum is discovered.
2244 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2246 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2248 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2250 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2251 GCC PR/17406) by declaring this function with external scope.
2253 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2255 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2256 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2258 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2260 * editfns.c (Fformat): Correctly handle text properties on "%%".
2262 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2264 * xterm.c (x_draw_composite_glyph_string_foreground):
2265 * w32term.c (x_draw_composite_glyph_string_foreground):
2266 * term.c (encode_terminal_code):
2267 * composite.c (composition_update_it, get_composition_id):
2268 * xdisp.c (get_next_display_element)
2269 (fill_composite_glyph_string): Add comments about special meaning
2270 of TAB characters in a composition.
2272 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2274 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2275 This occurs when processing a multibyte format.
2276 Problem reported by Wolfgang Jenker.
2278 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2280 * xdisp.c (try_cursor_movement): Only check for exact match if
2281 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2283 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2285 Remove unused external symbols.
2286 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2287 * xdisp.c (calc_pixel_width_or_height): Now static.
2288 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2289 * indent.c (check_display_width):
2290 * w32term.c: Fix comment to match code.
2291 * xterm.c, xterm.h (x_catching_errors): Remove.
2293 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2295 * xselect.c: Use signed conversions more consistently (Bug#9498).
2296 (selection_data_to_lisp_data): Assume incoming selection data are
2297 signed integers, not unsigned. This is to be consistent with
2298 outgoing selection data, which was modified to use signed integers
2299 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2300 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2301 expects long, not unsigned long.
2303 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2305 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2306 computation of loop end. Reported by Johan Bockgård
2309 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2311 * frame.c (Fother_visible_frames_p): Function deleted.
2313 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2315 * indent.c (compute_motion): Process display vector front to back
2316 rather than the other way around. (Bug#2496)
2318 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2320 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2322 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2324 * minibuf.c (Fread_from_minibuffer): Doc fix.
2326 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2328 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2329 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2331 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2333 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2334 value for non-existent files.
2336 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2338 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2339 set its "size" to -1. This will set the modtime_size field of
2340 the corresponding buffer to -1, which is what
2341 verify-visited-file-modtime expects for files that do not exist.
2344 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2346 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2348 * lisp.h: ... from here. push_key_description is no longer
2349 defined in keyboard.c, so its declaration should not be in
2350 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2351 logically belongs with push_key_description.
2353 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2355 * buffer.h: Include <sys/types.h> instead of <time.h>.
2356 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2357 Problem reported by Herbert J. Skuhra.
2359 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2361 * xml.c (parse_region): Make the parsing work for
2362 non-comment-starting XML files again (bug#9144).
2364 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2366 * image.c (gif_load): Fix calculation of bottom and right corner.
2369 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2371 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2372 redisplay in small windows.
2374 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2376 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2378 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2380 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2381 Operate on live windows only.
2383 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2385 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2387 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2389 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2390 only under bidi iteration.
2392 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2394 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2396 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2398 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2399 Without this fix, the command to link temacs failed due to an
2400 undefined symbol __builtin_isnan. This is because
2401 /usr/include/iso/math_c99.h #defines isnan(x) to
2402 __builtin_isnan(x), but the bundled gcc, which identifies itself
2403 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2405 * floatfns.c (isnan): #undef, and then #define to a clone of
2407 (Fisnan): Always define, since it's always available now.
2408 (syms_of_floatfns): Always define isnan at the Lisp level.
2410 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2412 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2414 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2416 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2417 The previous code assumed that file offsets (off_t values) fit in
2418 EMACS_INT variables, which is not true on typical 32-bit hosts.
2419 The code messed up by falsely reporting buffer overflow in cases
2420 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2421 when "big" contains more than 2**29 bytes, even though this
2422 inserts just one byte and does not overflow the buffer.
2423 (Finsert_file_contents): Store file offsets as off_t
2424 values, not as EMACS_INT values. Check for overflow when
2425 converting between EMACS_INT and off_t. When checking for
2426 buffer overflow or for overlap, take the offsets into account.
2427 Don't use EMACS_INT for small values where int suffices.
2428 When checking for overlap, fix a typo: ZV was used where
2429 ZV_BYTE was intended.
2430 (Fwrite_region): Don't assume off_t fits into 'long'.
2431 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2433 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2435 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2437 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2439 sprintf-related integer and memory overflow issues (Bug#9412).
2441 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2442 (esprintf, exprintf, evxprintf): New functions.
2443 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2444 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2445 (modify_event_symbol): Do not assume that the length of
2446 name_alist_or_stem is safe to alloca and fits in int.
2447 (Fexecute_extended_command): Likewise for function name and binding.
2448 (Frecursion_depth): Wrap around reliably on integer overflow.
2449 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2450 since some callers pass EMACS_INT values.
2451 (Fsingle_key_description): Don't crash if symbol name contains more
2452 than MAX_ALLOCA bytes.
2453 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2454 (get_minibuffer): Arg is now EMACS_INT, not int.
2455 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2456 (esprintf, exprintf, evxprintf): New decls.
2457 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2459 * dbusbind.c (signature_cat): New function.
2460 (xd_signature, Fdbus_register_signal):
2461 Do not overrun buffer; instead, report string overflow.
2463 * dispnew.c (add_window_display_history): Don't overrun buffer.
2464 Truncate instead; this is OK since it's just a log.
2466 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2467 even if the time zone offset is outlandishly large.
2468 Don't mishandle offset == INT_MIN.
2470 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2471 when creating daemon; the previous buffer-overflow check was incorrect.
2473 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2474 which has the guts of the old verror function.
2476 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2477 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2479 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2480 (font_unparse_xlfd): Don't blindly alloca long strings.
2481 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2482 fits in int, when using sprintf. Use single snprintf to count
2483 length of string rather than counting it via multiple sprintfs;
2484 that's simpler and more reliable.
2485 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2486 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2487 sprintf, in case result does not fit in int.
2489 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2490 (fontset_from_font): Print it.
2492 * frame.c (tty_frame_count): Now printmax_t, not int.
2493 (make_terminal_frame, set_term_frame_name): Print it.
2494 (x_report_frame_params): In X, window IDs are unsigned long,
2495 not signed long, so print them as unsigned.
2496 (validate_x_resource_name): Check for implausibly long names,
2497 and don't assume name length fits in 'int'.
2498 (x_get_resource_string): Don't blindly alloca invocation name;
2499 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2502 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2503 (xg_check_special_colors, xg_set_geometry):
2504 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2506 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2507 Use esprintf, not sprintf, in case result does not fit in int.
2509 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2510 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2511 it as a large positive number.
2512 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2513 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2515 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2516 in case result does not fit in int.
2518 * print.c (float_to_string): Detect width overflow more reliably.
2519 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2520 buffer overrun. Don't assume list length fits in 'int'. Treat
2521 print length of 0 as 0, not as infinity; to be consistent with other
2522 uses of print length in this function. Don't overflow print length
2523 index. Don't assume hash table size fits in 'long', or that
2524 vectorlike size fits in 'unsigned long'.
2526 * process.c (make_process): Use printmax_t, not int, to format
2527 process-name gensyms.
2529 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2531 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2532 to avoid potential buffer overrun.
2534 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2535 if X resource line is longer than 512 bytes.
2537 * xfns.c (x_window): Make sprintf buffer a bit bigger
2538 to avoid potential buffer overrun.
2540 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2542 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2544 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2546 Integer overflow fixes for scrolling, etc.
2547 Without these, Emacs silently mishandles large integers sometimes.
2548 For example, "C-u 4294967297 M-x recenter" was treated as if
2549 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2551 * xdisp.c (try_window_id): Check Emacs fixnum range before
2552 converting to 'int'.
2554 * window.c (window_scroll_line_based, Frecenter):
2555 Check that an Emacs fixnum is in range before assigning it to 'int'.
2556 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2557 values converted from Emacs fixnums.
2558 (Frecenter): Don't wrap around a line count if it is out of 'int'
2559 range; instead, treat it as an extreme value.
2560 (Fset_window_configuration, compare_window_configurations):
2561 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2563 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2564 that can exceed INT_MAX. Check that EMACS_INT value is in range
2565 before assigning it to the (possibly-narrower) index.
2566 (match_limit): Don't assume that a fixnum can fit in 'int'.
2568 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2571 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2572 (Fvertical_motion): Don't wrap around LINES values that don't fit
2573 in 'int'. Instead, treat them as extreme values. This is good
2574 enough for windows, which can't have more than INT_MAX lines anyway.
2576 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2578 * Require libxml/parser.h to avoid compilation warning.
2580 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2582 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2583 since this reportedly can destroy thread storage.
2585 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2587 * syntax.c (find_defun_start): Update all cache variables if
2588 exiting early (Bug#9401).
2590 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2592 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2594 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2595 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2596 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2598 * term.c (tty_append_glyph): New function.
2599 (produce_stretch_glyph): Static function and its prototype deleted.
2601 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2604 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2606 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2607 when checking :margin (Bug#9390).
2608 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2609 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2610 so that the name doesn't mislead. All uses changed.
2612 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2614 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2617 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2619 * xdisp.c (move_it_to): Don't bail out early when reaching
2620 position beyond to_charpos, if we are scanning backwards.
2621 (move_it_vertically_backward): When DY == 0, make sure we get to
2622 the first character in the line after the newline.
2624 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2626 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2627 (ccl_driver): Do not generate an out-of-range pointer.
2628 (Fccl_execute_on_string): Remove unnecessary check for
2629 integer overflow, noted by Stefan Monnier in
2630 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2631 Remove a FIXME that didn't need fixing.
2632 Simplify the newly-introduced buffer reallocation code.
2634 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2636 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2638 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2640 Integer and memory overflow issues (Bug#9196).
2642 * doc.c (get_doc_string): Rework so that
2643 get_doc_string_buffer_size is the actual buffer size, rather than
2644 being 1 less than the actual buffer size; this makes xpalloc more
2647 * image.c (x_allocate_bitmap_record, cache_image):
2648 * xselect.c (Fx_register_dnd_atom):
2649 Simplify previous changes by using xpalloc.
2651 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2652 since either will do and ptrdiff_t is convenient with xpalloc.
2654 * charset.c (charset_table_size)
2655 (struct charset_sort_data.priority): Now ptrdiff_t.
2656 (charset_compare): Don't overflow if priorities differ greatly.
2657 (Fsort_charsets): Don't assume list length fits in int.
2658 Check for size-calculation overflow when allocating sort data.
2659 (syms_of_charset): Allocate an initial charset table that is
2660 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2662 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2664 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2665 The actual value is always <= INT_MAX, and leaving it unsigned made
2666 overflow checking harder.
2668 * dispextern.h (struct glyph_matrix.rows_allocated)
2669 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2670 with xpalloc. The values are still always <= INT_MAX.
2672 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2674 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2675 (SAFE_NALLOCA): New macro.
2677 * region-cache.c (struct boundary.pos, find_cache_boundary)
2678 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2679 (set_cache_region, invalidate_region_cache)
2680 (revalidate_region_cache, know_region_cache, region_cache_forward)
2681 (region_cache_backward, pp_cache):
2682 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2683 so that ptrdiff_t * can be passed to xpalloc.
2684 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2685 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2686 (pp_cache): Don't assume cache_len fits in int.
2687 * region-cache.h: Adjust extern decls to match.
2689 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2690 EMACS_INT, since either will do, for xpalloc.
2692 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2693 (xnmalloc, xnrealloc, xpalloc): New functions.
2695 * bidi.c (bidi_shelve_header_size): New constant.
2696 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2697 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2699 * bidi.c (bidi_cache_shrink):
2700 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2702 Don't update size of array until after memory allocation succeeds,
2703 because xmalloc/xrealloc may not return.
2704 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2705 now that we have proper integer overflow checking.
2706 (record_overlay_string, overlay_strings): Catch overflows when
2707 calculating size of overlay_str_buf.
2709 * callproc.c (Fcall_process): Check for size overflow when
2710 calculating size of args2.
2711 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2712 Normally we prefer signed values, but sticking with ptrdiff_t would
2713 require adding more-complicated checks.
2715 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2716 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2717 Redo buffer-overflow calculations to avoid integer overflow.
2718 Add a FIXME comment where memory seems to be over-allocated.
2720 * character.c (Fstring): Check for size-calculation overflow.
2722 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2723 unnecessary integer overflow. Check for size overflow.
2724 (encode_coding_object): Don't update size until xmalloc succeeds.
2726 * composite.c (get_composition_id): Check for overflow in glyph
2727 length calculations.
2729 Integer and memory overflow fixes for display code.
2730 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2731 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2732 (scrolling_window): Check for overflow in size calculations.
2733 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2734 Don't assume glyph table len fits in int.
2735 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2736 (row_table_size): Now ptrdiff_t, not int.
2737 (scrolling_window): Avoid overflow in size calculations.
2738 Don't update size until allocation succeeds.
2739 * fns.c (concat): Check for overflow in size calculations.
2740 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2741 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2742 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2744 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2745 (get_doc_string): Check for size calculation overflow.
2746 Don't update size until allocation succeeds.
2747 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2748 EMACS_INT, where ptrdiff_t will do.
2749 (Fsubstitute_command_keys): Check for string overflow.
2751 * editfns.c (set_time_zone_rule): Don't assume environment length
2753 (message_length): Now ptrdiff_t, not int.
2754 (Fmessage_box): Don't update size until allocation succeeds.
2755 Don't assume message length fits in int.
2756 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2758 * emacs.c (main): Do not reallocate argv, since there is a null at
2759 the end that can be overwritten, and this way there's no need to
2760 worry about size-calculation overflow.
2761 (sort_args): Check for size-calculation overflow.
2763 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2765 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2767 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2768 (x_set_scroll_bar_width, x_figure_window_size):
2769 Check for integer overflow.
2770 (x_set_alpha): Do not assume XINT fits in int.
2772 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2773 This is for the members text_lines, text_cols, total_lines, total_cols,
2774 where the system imposes an 'int' limit.
2776 * fringe.c (Fdefine_fringe_bitmap):
2777 Don't update size until alloc works.
2779 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2780 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2782 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2783 Check for size-calculation overflow.
2784 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2785 do, as we prefer signed integers.
2786 (id_to_widget.max_size, id_to_widget.used)
2787 (xg_store_widget_in_map, xg_remove_widget_from_map)
2788 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2789 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2790 Use and return ptrdiff_t, not int.
2791 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2792 * gtkutil.h: Change prototypes to match the above.
2794 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2795 are duplicate now that they've been promoted to lisp.h.
2796 (x_allocate_bitmap_record, x_alloc_image_color)
2797 (make_image_cache, cache_image, xpm_load):
2798 Don't update size until alloc is done.
2799 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2801 Check for size calculation overflow.
2802 (ct_colors_allocated_max): New constant.
2803 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2806 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2807 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2808 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2809 Use ptrdiff_t, not int, to count maps.
2810 (read_char_minibuf_menu_prompt): Check for overflow in size
2811 calculations. Don't update size until allocation succeeds.
2812 Redo calculations to avoid overflow.
2813 * keyboard.h: Change prototypes to match the above.
2815 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2817 (current_minor_maps): Check for size calculation overflow.
2818 * keymap.h: Change prototypes to match the above.
2820 * lread.c (read1, init_obarray): Don't update size until alloc done.
2822 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2823 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2825 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2826 Now ptrdiff_t, not int.
2827 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2828 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2830 * process.c (Fnetwork_interface_list): Check for overflow
2831 in size calculation.
2833 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2835 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2836 overflow. Don't bother calling xmalloc when xrealloc will do.
2838 * search.c (Freplace_match): Check for size calculation overflow.
2839 (Fset_match_data): Don't assume list lengths fit in 'int'.
2841 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2842 for command line length. Do not attempt to address one before the
2843 beginning of an array, as that's not portable.
2845 * term.c (max_frame_lines): Remove; unused.
2846 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2848 (encode_terminal_code, calculate_costs): Check for size
2849 calculation overflow.
2850 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2851 table lengths and related sizes. Don't update size until alloc
2852 done. Redo calculations to avoid overflow.
2853 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2855 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2856 subtracting pointers.
2857 (gobble_line): Check for overflow more carefully. Don't update size
2860 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2861 Don't update size until alloc done.
2862 Redo size calculations to avoid overflow.
2863 Check for size calculation overflow.
2864 (main) [DEBUG]: Fix typo in invoking tparam1.
2866 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2867 Use ptrdiff_t, not int, for sizes.
2868 (store_mode_line_noprop_char): Don't update size until alloc done.
2870 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2871 Use ptrdiff_t, not int, for sizes.
2872 (Finternal_make_lisp_face, cache_face):
2873 Check for size calculation overflow.
2874 (cache_face): Treat size calculation overflows as if they were
2875 memory exhaustion (the usual treatment), rather than aborting.
2877 * xfns.c (x_encode_text, x_set_name_internal)
2878 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2879 sizes, since they can exceed INT_MAX in size. Check for size
2880 calculation overflow.
2882 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2883 (xg_select): Check for size calculation overflow.
2884 Don't update size until alloc done.
2886 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2887 as sprintf is limited to int lengths.
2889 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2890 (X_LONG_MIN): New macros.
2891 Use them to make the following changes clearer.
2892 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2893 This change doesn't affect the value now, but it may help remind
2894 future maintainers not to raise the value too much later.
2895 (SELECTION_QUANTUM): Remove, replacing with ...
2896 (selection_quantum): ... new function, which avoids overflow.
2898 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2899 assumption that selection length fits in 'int'.
2900 (x_reply_selection_request, x_handle_selection_request)
2901 (x_get_window_property, receive_incremental_selection)
2902 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2903 (lisp_data_to_selection_data, clean_local_selection_data):
2904 Use ptrdiff_t, not int, to record length of selection.
2905 (x_reply_selection_request, x_get_window_property)
2906 (receive_incremental_selection, x_property_data_to_lisp):
2907 Redo calculations to avoid overflow.
2908 (x_reply_selection_request): When sending hint, ceiling it at
2909 X_LONG_MAX rather than relying on wraparound overflow to send
2911 (x_get_window_property, receive_incremental_selection)
2912 (lisp_data_to_selection_data, x_property_data_to_lisp):
2913 Check for size-calculation overflow.
2914 (x_get_window_property, receive_incremental_selection)
2915 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2916 Don't store size until memory allocation succeeds.
2917 (x_get_window_property): Plug memory leak on memory exhaustion.
2918 Don't double-block input; malloc is safe here. Don't assume 2**34
2919 - 4 fits in unsigned long. Add an xassert to check
2920 XGetWindowProperty overflow. Be more careful about overflow
2921 calculations, and distinguish size from memory overflow better.
2922 (receive_incremental_selection): When tracing, don't assume
2923 unsigned int is less than INT_MAX.
2924 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2925 harmful) conversions of unsigned short to int.
2926 (lisp_data_to_selection_data): Don't assume that integers
2927 in the range -65535 through -1 fit in an X unsigned short.
2928 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2929 result parameters unless successful. Rely on cons_to_unsigned
2930 to report problems with elements; the old code wasn't right anyway.
2931 (x_check_property_data): Check for int overflow; we cannot use
2932 a wider type due to X limits.
2933 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2935 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2937 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2938 (x_term_init): Check for size calculation overflow.
2939 (x_color_cells): Don't store size until memory allocation succeeds.
2940 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2941 Don't assume alloca size is less than MAX_ALLOCA.
2942 (x_term_init): Don't assume length fits in int (sprintf is limited
2945 Use ptrdiff_t for composition IDs.
2946 * character.c (lisp_string_width):
2947 * composite.c (composition_table_size, n_compositions)
2948 (get_composition_id, composition_gstring_from_id):
2949 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2950 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2951 * window.c (Frecenter):
2952 Use ptrdiff_t, not int, for composition IDs.
2953 * composite.c (get_composition_id): Check for integer overflow.
2954 * composite.h: Adjust prototypes to match the above changes.
2956 Use ptrdiff_t for hash table indexes.
2957 * category.c (hash_get_category_set):
2958 * ccl.c (ccl_driver):
2959 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2960 * coding.c (coding_system_charset_list, detect_coding_system):
2961 * coding.h (struct coding_system.id):
2962 * composite.c (get_composition_id, gstring_lookup_cache):
2963 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2964 * image.c (xpm_get_color_table_h):
2965 * lisp.h (hash_lookup, hash_put):
2966 * minibuf.c (Ftest_completion):
2967 Use ptrdiff_t for hash table indexes, not int (which is too
2968 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2969 32-bit --with-wide-int hosts).
2971 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2972 Add a FIXME comment about memory leaks.
2973 (syms_of_charset): Don't assume xmalloc returns.
2975 Don't assume that stated character widths fit in int.
2976 * character.c (Fchar_width, c_string_width, lisp_string_width):
2977 * character.h (CHAR_WIDTH):
2978 * indent.c (MULTIBYTE_BYTES_WIDTH):
2979 Use sanitize_char_width to avoid undefined and/or bad behavior
2980 with outlandish widths.
2981 * character.h (sanitize_tab_width): Rename from sanitize_width,
2982 now that we have two such functions. All uses changed.
2983 (sanitize_char_width): New inline function.
2985 Don't assume that tab-width fits in int.
2986 * character.h (sanitize_width): New inline function.
2987 (SANE_TAB_WIDTH): New macro.
2988 (ASCII_CHAR_WIDTH): Use it.
2989 * indent.c (sane_tab_width): Remove. All uses replaced by
2990 SANE_TAB_WIDTH (current_buffer).
2991 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2993 * fileio.c: Integer overflow issues with file modes.
2994 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2996 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2997 Remove unreachable code.
2998 (read_hex, load_charset_map_from_file): Check for integer overflow.
3000 * xterm.c: Don't go over XClientMessageEvent limit.
3001 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3002 (x_send_scroll_bar_event): Likewise. Check that the size does not
3003 exceed limits imposed by XClientMessageEvent, as well as the usual
3004 ptrdiff_t and size_t limits.
3006 * keyboard.c: Overflow, signedness and related fixes.
3007 (make_lispy_movement): Use same integer type in forward decl
3008 that is used in the definition.
3009 (read_key_sequence, keyremap_step):
3010 Change bufsize argument back to int, undoing my 2011-03-30 change.
3011 We prefer signed types, and int is wide enough here.
3012 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3013 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3014 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3015 length, not size_t. Use ptrdiff_t for index, not int.
3016 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3017 possibility of integer overflow.
3019 Overflow, signedness and related fixes for images.
3021 * dispextern.h (struct it.stack[0].u.image.image_id)
3022 (struct_it.image_id, struct image.id, struct image_cache.size)
3023 (struct image_cache.used, struct image_cache.ref_count):
3024 * gtkutil.c (update_frame_tool_bar):
3025 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3026 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3027 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3028 * nsmenu.m (update_frame_tool_bar):
3029 * xdisp.c (calc_pixel_width_or_height):
3030 * xfns.c (image_cache_refcount):
3031 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3032 on typical 64-bit hosts.
3034 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3035 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3036 Omit unnecessary casts to int.
3037 (parse_image_spec): Check that integers fall into 'int' range
3038 when the callers expect that.
3039 (image_ascent): Redo ascent calculation to avoid int overflow.
3040 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3041 (lookup_image): Remove unnecessary tests.
3042 (xbm_image_p): Locals are now of int, not EMACS_INT,
3043 since parse_image_check makes sure they fit into int.
3044 (png_load, gif_load, svg_load_image):
3045 Prefer int to unsigned where either will do.
3046 (tiff_handler): New function, combining the cores of the
3047 old tiff_error_handler and tiff_warning_handler.
3048 This function is rewritten to use vsnprintf and thereby avoid
3049 stack buffer overflows. It uses only the features of vsnprintf
3050 that are common to both POSIX and native Microsoft.
3051 (tiff_error_handler, tiff_warning_handler): Use it.
3052 (tiff_load, gif_load, imagemagick_load_image):
3053 Don't assume :index value fits in 'int'.
3054 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3055 (imagemagick_load_image): Check that crop parameters fit into
3056 the integer types that MagickCropImage accepts. Don't assume
3057 Vimagemagick_render_type has a nonnegative value. Don't assume
3058 size_t fits in 'long'.
3059 (gs_load): Use printmax_t to print the widest integers possible.
3060 Check for integer overflow when computing image height and width.
3062 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3064 * xdisp.c (redisplay_window): Don't force window start if point
3065 will be invisible in the resulting window. (Bug#9324)
3067 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3069 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3070 the display spec is of the form `(space ...)'.
3071 (handle_display_spec): Return the value returned by
3072 handle_single_display_spec, not just 1 or zero.
3073 (handle_single_display_spec): If the display spec is of the form
3074 `(space ...)', and specifies display in the text area, return 2
3076 (try_cursor_movement): Check for the need to scroll more
3077 accurately, and prefer exact match for point under bidi.
3078 Don't advance `row' beyond the last row of the window.
3080 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3081 into disp_prop; all users changed.
3083 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3084 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3085 for the text covered by the display property.
3087 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3089 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3090 Change return value to nil.
3091 (Frecord_buffer): Delete unused function.
3093 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3095 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3096 buffers, return left-to-right.
3097 (set_cursor_from_row): Consider candidate row a win if its glyph
3098 represents a newline and point is on that newline. Fixes cursor
3099 positioning on the newline at EOL of R2L text within L2R
3100 paragraph, and vice versa.
3101 (try_cursor_movement): Check continued rows, in addition to
3102 continuation rows. Fixes unwarranted scroll when point enters a
3103 continued line of R2L text within an L2R paragraph, or vice versa.
3104 (cursor_row_p): Consider the case of point being equal to
3105 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3106 from the end of a short line to the beginning of a continued line
3107 of R2L text within L2R paragraph.
3108 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3109 composed characters.
3111 * bidi.c (bidi_check_type): Use xassert.
3112 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3115 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3117 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3120 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3122 * nsfont.m (ns_otf_to_script): Fix typo.
3124 2011-08-22 Kenichi Handa <handa@m17n.org>
3126 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3127 extra slot even if the purpose is char-code-property-table.
3129 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3131 * xdisp.c (redisplay_window): When computing centering_position,
3132 account for the height of the header line. (Bug#8874)
3134 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3135 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3136 candidate is selected by the mouse, and that candidate has a
3137 composed character under the mouse.
3139 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3140 coordinates reported by pos-visible-in-window-p for a composed
3141 character in column zero.
3143 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3145 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3147 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3149 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3150 consider it a hit if to_charpos is anywhere in the range of the
3151 composed buffer positions.
3153 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3155 * image.c (gif_load): Don't assume that each subimage has the same
3156 dimensions as the base image. Handle disposal method that is
3157 "undefined" by the gif spec (Bug#9335).
3159 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3161 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3162 (Fcondition_case): Document `debug' symbol in error handler.
3164 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3166 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3167 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3168 from an Org mode buffer to a Speedbar frame.
3170 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3171 a composition, take its buffer position from IT->cmp_it.charpos.
3172 Fixes cursor positioning at the beginning of a line that begins
3173 with a composed character.
3175 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3177 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3178 character bidirectional type, use STRONG_L instead. Fixes crashes
3179 in a buffer produced by `describe-categories'.
3181 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3182 members before the level stack, so they would be saved and
3183 restored when copying iterator state. Fixes incorrect reordering
3184 around TABs covered by display properties.
3186 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3188 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3190 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3192 * eval.c (internal_condition_case, internal_condition_case_1)
3193 (internal_condition_case_2, internal_condition_case_n):
3194 Remove unnecessary aborts (Bug#9081).
3196 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3198 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3199 has no `load' handler, try opening the file locally. (Bug#9311)
3201 2011-08-16 Ken Brown <kbrown@cornell.edu>
3203 * gmalloc.c: Expand comment.
3205 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3207 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3208 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3210 2011-08-16 Ken Brown <kbrown@cornell.edu>
3212 Fix memory allocation problems in Cygwin build (Bug#9273).
3214 * unexcw.c ( __malloc_initialized): Declare external variable.
3215 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3217 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3219 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3221 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3223 [CYGWIN] (special_realloc): New function.
3224 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3225 requests to realloc storage in the static heap.
3227 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3229 * bidi.c (bidi_initialize): Remove unused local.
3231 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3234 * biditype.h: Remove file.
3235 * makefile.w32-in ($(BLD)/bidi.$(O)):
3236 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3238 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3240 * chartab.c: Improve commentary for the uniprop_table API.
3242 * bidi.c (bidi_paragraph_init): Support zero value of
3243 bidi_ignore_explicit_marks_for_paragraph_level.
3244 (bidi_initialize): Use uniprop_table instead of including
3245 biditype.h and bidimirror.h.
3247 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3248 coordinates of the iterator when restoring from ppos_it.
3251 2011-08-14 Kenichi Handa <handa@m17n.org>
3253 * process.c (create_process): Call setup_process_coding_systems
3254 after the pid of the process is set to -1 (Bug#8162).
3256 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3258 * xdisp.c (move_it_in_display_line_to): Don't invoke
3259 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3260 ppos_it. Fixes vertical cursor motion when line beginning is
3261 covered by an image. (Bug#9296)
3263 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3265 * nsterm.h (ns_run_ascript): Declare.
3266 (NSAPP_DATA2_RUNASSCRIPT): Define.
3268 * nsfns.m (as_script, as_result, as_status): New static variables.
3269 (ns_run_ascript): New function.
3270 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3271 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3272 the event loop. Get status from as_status (Bug#7276).
3274 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3275 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3276 the event loop (Bug#7276).
3278 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3280 * gnutls.c (QCgnutls_bootprop_priority)
3281 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3282 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3283 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3284 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3285 (QCgnutls_bootprop_verify_hostname_error)
3286 (QCgnutls_bootprop_callbacks_verify): Rename from
3287 Qgnutls_bootprop_..., all uses changed.
3289 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3292 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3294 * xfaces.c (Qframe_set_background_mode): Now static.
3295 * dispextern.h (Qframe_set_background_mode): Remove decl.
3297 * process.c (Fnetwork_interface_info): Declare local only if needed.
3299 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3301 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3302 (Fnetwork_interface_list): Allocate in increments of bytes instead
3303 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3304 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3306 (struct ifflag_def): notrailers is smart on OSX.
3307 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3308 Get hardware address with getifaddrs if available.
3310 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3312 * xdisp.c (iterate_out_of_display_property): xassert that
3313 IT->position is set to within IT->object's boundaries. Break from
3314 the loop as soon as EOB is reached; avoids infloops in redisplay
3315 when IT->position is set up wrongly due to some bug.
3316 Set IT->current to match the bidi iterator unconditionally.
3317 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3318 entry. Force push_it to save on the stack the current
3319 buffer/string position, to be restored by pop_it. Fix flags in
3320 the iterator structure wrt the object coming from a display
3321 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3322 properties. (Bug#9284)
3324 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3326 * fontset.c (fontset_get_font_group): Add proper type checks.
3329 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3331 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3332 and LC_VERSION_MIN_MACOSX.
3333 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3334 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3336 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3338 * xdisp.c (forward_to_next_line_start): Allow to use the
3339 no-display-properties-and-no-overlays under bidi display.
3340 Set disp_pos in the bidi iterator to avoid searches for display
3341 properties and overlays.
3343 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3345 * editfns.c (Fset_time_zone_rule): Document relationship with the
3348 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3349 the font entity extracted from the cache (Bug#8109).
3351 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3353 * composite.c (autocmp_chars): Don't reset point. That is done by
3354 restore_point_unwind (Bug#5984).
3356 2011-08-07 Juri Linkov <juri@jurta.org>
3358 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3359 to show the arg `TIME' instead of `TIMEVAL'.
3361 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3363 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3364 display property strides EOL and includes a newline, as in
3365 longlines-mode. (Bug#9254)
3366 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3367 word-wrap under bidirectional display. (Bug#9224)
3369 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3370 is non-zero, even if the data buffer is NULL. Fixes a crash in
3371 vertical-motion with longlines-mode. (Bug#9254)
3373 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3375 * bidi.c <bidi_cache_total_alloc>: Now static.
3376 (bidi_initialize): Initialize bidi_cache_total_alloc.
3378 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3381 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3382 amount allocated this far in `bidi_cache_total_alloc'.
3383 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3384 non-zero, only free the data buffer without restoring the cache
3385 contents. All callers changed.
3387 * dispextern.h (bidi_unshelve_cache): Update prototype.
3389 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3390 (move_it_in_display_line, move_it_to)
3391 (move_it_vertically_backward, move_it_by_lines): Replace the call
3392 to xfree to an equivalent call to bidi_unshelve_cache.
3393 (move_it_in_display_line_to): Fix logic of returning
3394 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3396 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3398 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3399 came from a string character with a `cursor' property. (Bug#9229)
3401 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3403 * Makefile.in (LIB_PTHREAD): New variable.
3404 (LIBES): Add LIB_PTHREAD (Bug#9216).
3406 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3407 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3409 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3411 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3413 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3415 * xterm.c (x_find_topmost_parent): New function.
3416 (x_set_frame_alpha): Find topmost parent window with
3417 x_find_topmost_parent and set the property there also (bug#9181).
3418 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3420 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3422 * callproc.c (Fcall_process): Avoid vfork clobbering
3423 the local vars buffer, coding_systems, current_dir.
3425 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3427 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3429 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3431 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3432 so that it is not optimized away.
3434 * xdisp.c (compute_display_string_pos): Remove unused local.
3436 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3438 Fix slow cursor motion and scrolling in large buffers with
3439 selective display, like Org Mode buffers. (Bug#9218)
3441 * dispextern.h (struct bidi_it): New member disp_prop_p.
3443 * xdisp.c: Remove one-slot cache of display string positions.
3444 (compute_display_string_pos): Accept an additional argument
3445 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3446 for a display string or property. If found, set DISP_PROP_P
3449 * bidi.c (bidi_fetch_char): Accept an additional argument
3450 DISP_PROP_P, and pass it to compute_display_string_pos.
3451 Only handle text covered by a display string if DISP_PROP_P is returned
3452 non-zero. All callers of bidi_fetch_char changed.
3454 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3456 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3458 2010-12-03 Don March <don@ohspite.net>
3460 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3461 last character M-[char] is translated to ESC [char] (bug#7541).
3463 2011-08-02 Kenichi Handa <handa@m17n.org>
3465 * lisp.h (uniprop_table): Extern it.
3467 * chartab.c (uniprop_table): Make it non-static.
3469 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3471 * xdisp.c (forward_to_next_line_start): Accept additional argument
3472 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3474 (reseat_at_next_visible_line_start): Use the bidi iterator state
3475 returned by forward_to_next_line_start to restore the state of
3476 it->bidi_it after backing up to previous newline. (Bug#9212)
3478 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3480 * regex.c (re_comp): Protoize.
3481 (re_exec): Fix return type.
3482 (regexec): Fix type of `ret'. (Bug#9203)
3484 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3486 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3487 This is needed if max-image-size is a floating-point number.
3489 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3491 * print.c (print_object): Print empty symbol as ##.
3493 * lread.c (read1): Read ## as empty symbol.
3495 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3497 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3498 setting frame foreground color (Bug#9175).
3499 (x_set_background_color): Likewise.
3501 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3502 contents (Bug#9176).
3503 (EmacsTooltip -init): Remove bezels and add shadows to
3506 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3507 or scroll bar (Bug#8470).
3509 * nsfont.m (nsfont_open): Remove assignment to voffset and
3510 unnecessary vars hshink, expand, hd, full_height, min_height.
3511 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3513 * nsterm.h (nsfont_info): Remove voffset field.
3515 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3517 Implement strike-through and overline on NextStep (Bug#8863).
3519 * nsfont.m (nsfont_open): Use underline position provided by font,
3520 instead of hard-coded value of 2.
3521 (nsfont_draw): Call ns_draw_text_decoration instead.
3523 * nsterm.h: Add declaration for ns_draw_text_decoration.
3525 * nsterm.m (ns_draw_text_decoration): New function for drawing
3526 underline, overline, and strike-through.
3527 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3528 ns_draw_text_decoration. Change treatment of cursor drawing to
3529 accommodate underlining, etc.
3531 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3533 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3536 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3538 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3539 Without this fix, if a signal arrives just after memory fills up,
3540 'malloc' might be invoked reentrantly.
3542 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3543 In other words, assume that every image size is allowed, on non-X
3544 hosts. This assumption is probably wrong, but it lets Emacs compile.
3546 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3548 * regex.c (re_iswctype): Convert return values to boolean.
3550 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3552 * xdisp.c (compute_display_string_pos): Don't use cached display
3553 string position if the buffer had its restriction changed.
3556 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3558 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3560 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3562 Integer signedness and overflow and related fixes. (Bug#9079)
3564 * bidi.c: Integer size and overflow fixes.
3565 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3566 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3567 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3568 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3569 (bidi_find_other_level_edge):
3570 Use ptrdiff_t instead of EMACS_INT where either will do.
3571 This works better on 32-bit hosts configured --with-wide-int.
3572 (bidi_cache_ensure_space): Check for size-calculation overflow.
3573 Use % rather than repeated addition, for better worst-case speed.
3574 Don't set bidi_cache_size until after xrealloc returns, because it
3576 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3577 (bidi_cache_ensure_space): Also check that the bidi cache size
3578 does not exceed that of the largest Lisp string or buffer. See Eli
3579 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3581 * alloc.c (__malloc_size_t): Remove.
3582 All uses replaced by size_t. See Andreas Schwab's note
3583 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3585 * image.c: Improve checking for integer overflow.
3586 (check_image_size): Assume that f is nonnull, since
3587 it is always nonnull in practice. This is one less thing to
3588 worry about when checking for integer overflow later.
3589 (x_check_image_size): New function, which checks for integer
3590 overflow issues inside X.
3591 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3592 This removes the need for a memory_full check.
3593 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3594 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3595 (xbm_read_bitmap_data): Change locals back to 'int', since
3596 their values must fit in 'int'.
3597 (xpm_load_image, png_load, tiff_load):
3598 Invoke x_create_x_image_and_pixmap earlier,
3599 to avoid much needless work if the image is too large.
3600 (tiff_load): Treat overly large images as if
3601 x_create_x_image_and_pixmap failed, not as malloc failures.
3602 (gs_load): Use x_check_image_size.
3604 * gtkutil.c: Omit integer casts.
3605 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3606 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3608 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3610 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3611 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3612 would wrongly return t on a 64-bit host.
3614 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3615 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3616 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3617 and therefore cause GCC to emit a bogus diagnostic in some cases.
3619 * image.c: Integer signedness and overflow and related fixes.
3620 This is not an exhaustive set of fixes, but it's time to
3621 record what I've got.
3622 (lookup_pixel_color, check_image_size): Remove redundant decls.
3623 (check_image_size): Don't assume that arbitrary EMACS_INT values
3624 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3625 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3626 (tiff_load, imagemagick_load_image):
3627 Check for overflow in size calculations.
3628 (x_create_x_image_and_pixmap): Remove unnecessary test for
3629 xmalloc returning NULL; that can't happen.
3630 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3631 (xpm_color_bucket): Use better integer hashing function.
3632 (xpm_cache_color): Don't possibly over-allocate memory.
3633 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3634 (gif_memory_source):
3635 Use ptrdiff_t, not int or size_t, to record sizes.
3636 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3637 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3638 either works, as we prefer signed integers.
3639 (tiff_read_from_memory, tiff_write_from_memory):
3640 Return tsize_t, not size_t, since that's what the TIFF API wants.
3641 (tiff_read_from_memory): Don't fail simply because the read would
3642 go past EOF; instead, return a short read.
3643 (tiff_load): Omit no-longer-needed casts.
3644 (Fimagemagick_types): Don't assume size fits into 'int'.
3646 Improve hashing quality when configured --with-wide-int.
3647 * fns.c (hash_string): New function, taken from sxhash_string.
3648 Do not discard information about ASCII character case; this
3649 discarding is no longer needed.
3650 (sxhash-string): Use it. Change sig to match it. Caller changed.
3651 * lisp.h: Declare it.
3652 * lread.c (hash_string): Remove, since we now use fns.c's version.
3653 The fns.c version returns a wider integer if --with-wide-int is
3654 specified, so this should help the quality of the hashing a bit.
3656 * emacs.c: Integer overflow minor fix.
3657 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3658 Define only if GNU_LINUX.
3659 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3661 * dispnew.c: Integer signedness and overflow fixes.
3662 Remove unnecessary forward decls, that were a maintenance hassle.
3663 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3665 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3666 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3667 (prepare_desired_row, line_draw_cost):
3668 Use int, not unsigned, where either works.
3669 (save_current_matrix, restore_current_matrix):
3670 Use ptrdiff_t, not size_t, where either works.
3671 (init_display): Check for overflow more accurately, and without
3672 relying on undefined behavior.
3674 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3675 Remove, replacing with the new symbols in lisp.h. All uses changed.
3676 * fileio.c (make_temp_name):
3677 * filelock.c (lock_file_1, lock_file):
3678 * xdisp.c (message_dolog):
3679 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3680 Use pMd etc. instead.
3681 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3682 replacing the pWIDE etc. symbols removed from editfns.c.
3684 * keyboard.h (num_input_events): Now uintmax_t.
3685 This is (very slightly) less likely to mess up due to wraparound.
3688 * buffer.c: Integer signedness fixes.
3689 (alloc_buffer_text, enlarge_buffer_text):
3690 Use ptrdiff_t rather than size_t when either will do, as we prefer
3693 * alloc.c: Integer signedness and overflow fixes.
3694 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3695 (__malloc_size_t): Default to size_t, not to int.
3696 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3697 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3698 Prefer ptrdiff_t to size_t when either would do, as we prefer
3700 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3701 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3702 Now const. Initialize with values that are in range even if char
3704 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3705 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3706 These functions do the right thing with sizes > 2**32.
3707 (check_depth): Now ptrdiff_t, not int.
3708 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3709 Adjust to new way of storing sizes. Check for size overflow bugs
3711 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3712 slightly wrong anyway, as it missed one instance of
3713 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3714 (refill_memory_reserve): Omit needless cast to size_t.
3715 (mark_object_loop_halt): Mark as externally visible.
3717 * xselect.c: Integer signedness and overflow fixes.
3718 (Fx_register_dnd_atom, x_handle_dnd_message):
3719 Use ptrdiff_t, not size_t, since we prefer signed.
3720 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3721 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3722 x_dnd_atoms_size and x_dnd_atoms_length.
3724 * doprnt.c: Prefer signed to unsigned when either works.
3726 * doprnt.c (doprnt):
3728 * xdisp.c (vmessage):
3729 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3730 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3731 prefer signed arithmetic to avoid comparison confusion.
3732 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3733 but is a bit tricky.
3735 Assume freestanding C89 headers, string.h, stdlib.h.
3736 * data.c, doprnt.c, floatfns.c, print.c:
3737 Include float.h unconditionally.
3738 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3739 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3740 * regex.c: Likewise for stddef.h, string.h.
3741 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3742 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3743 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3744 (STDC_HEADERS): Remove obsolete defines.
3745 * sysdep.c: Include limits.h unconditionally.
3747 Assume support for memcmp, memcpy, memmove, memset.
3748 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3749 * regex.c (memcmp, memcpy):
3750 Remove; we assume C89 now.
3752 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3753 (__malloc_safe_bcopy): Remove; no longer needed.
3755 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3756 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3757 well either way, and we prefer signed to unsigned.
3759 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3761 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3762 closes the connection while we're reading (bug#9182).
3764 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3766 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3767 are specified (Bug#9168).
3769 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3771 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3772 Found by GCC static checking and --with-wide-int on a 32-bit host.
3774 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3776 * xdisp.c (compute_display_string_pos): Fix logic of caching
3777 previous display string position. Initialize cached_prev_pos to
3778 -1. Fixes slow-down at the beginning of a buffer.
3780 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3782 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3783 for attrs[LFACE_FONTSET_INDEX].
3785 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3787 * xml.c (parse_region): Remove unused local
3788 that was recently introduced.
3790 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3792 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3793 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3795 * xdisp.c (move_it_in_display_line_to): Record the best matching
3796 position for TO_CHARPOS while scanning the line, and restore it on
3797 exit if none of the characters scanned was an exact match.
3798 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3799 when exact match is impossible due to invisible text, and the
3800 lines are truncated.
3802 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3804 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3807 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3809 Fix a significant slow-down of cursor motion with C-n, C-p,
3810 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3811 auto-repeat under bidi redisplay in fontified buffers.
3812 * xdisp.c (compute_stop_pos_backwards): New function.
3813 (next_element_from_buffer): Call compute_stop_pos_backwards to
3814 find a suitable prev_stop when we find ourselves before
3816 (reseat): Don't look for prev_stop, as that could mean a very long
3818 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3819 <cached_disp_overlay_modiff>: Cache for last found display string
3821 (compute_display_string_pos): Return the cached position if asked
3822 about the same buffer in the same area of character positions, and
3823 the buffer wasn't changed since the time the display string
3824 position was cached.
3826 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3828 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3829 is an integer, which is important for empty lines. (Bug#9149)
3831 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3833 * frame.c (Fmodify_frame_parameters): In tty case, update the
3834 default face if necessary (Bug#4238).
3836 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3838 * editfns.c (Fstring_to_char): No need to explain what a character
3839 is in the docstring (Bug#6576).
3841 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3843 * xml.c (parse_region): Make sure we always return a tree.
3845 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3847 * xml.c (parse_region): If a document contains only comments,
3850 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3852 * xml.c (make_dom): Return comments, too.
3854 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3857 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3858 and the surrounding thread.
3859 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3860 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3861 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3863 * s/openbsd.h (BROKEN_SIGIO): Define.
3864 * unexelf.c (unexec) [__OpenBSD__]:
3865 Don't update the .mdebug section of the Alpha COFF symbol table.
3867 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3872 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3874 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3875 This fixes some race conditions on the permissions of any newly
3878 * alloc.c (valid_pointer_p): Use pipe, not open.
3879 This fixes some permissions issues when debugging.
3881 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3882 If fchown fails to set both uid and gid, try to set just gid,
3883 as that is sometimes allowed. Adjust the file's mode to eliminate
3884 setuid or setgid bits that are inappropriate if fchown fails.
3886 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3888 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3889 to compare Lisp_Objects.
3890 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3891 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3892 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3894 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3896 * lread.c (read_integer): Unread even EOF character.
3897 (read1): Likewise. Properly record start position of symbol.
3899 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3900 symbol character follows.
3902 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3904 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3905 This works around a problem with the previous change to Fcopy_file.
3906 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3907 and without this change, GCC might complain about discarding
3908 fchown's return value.
3910 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3912 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3914 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3916 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3918 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3920 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3921 it's used from the C level.
3923 * process.c: Use the same condition for POLL_FOR_INPUT in both
3924 keyboard.c and process.c (bug#1858).
3926 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3928 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3929 (Fgnutls_boot): Use it.
3931 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3933 * doc.c (Fsubstitute_command_keys): Revert last change.
3935 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3937 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3938 quotes the next character, and doesn't affect other longer
3939 sequences (bug#8935).
3941 * lread.c (syms_of_lread): Clarify that is isn't only
3942 `eval-buffer' and `eval-defun' that's affected by
3943 `lexical-binding' (bug#8460).
3945 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3947 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3948 bidi redisplay when a line includes both an image and is truncated.
3950 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3952 Fix minor problems found by static checking.
3953 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3954 (elsz): Now a signed constant, not a size_t var. We prefer signed
3955 types to unsigned, to avoid integer comparison confusion. Without
3956 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3957 "cannot optimize loop, the loop counter may overflow", a symptom
3959 * indent.c (Fvertical_motion): Mark locals as initialized.
3960 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3962 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3964 * search.c (Fre_search_backward): Mention `case-fold-search' in
3965 all the re_search_* functions (bug#8138).
3967 * keyboard.c (Fopen_dribble_file): Document when the file is
3970 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3972 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3975 Support bidi reordering of display and overlay strings.
3976 * xdisp.c (compute_display_string_pos)
3977 (compute_display_string_end): Accept additional argument STRING.
3978 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3979 (reseat_to_string): Initialize bidi_it->string.s and
3980 bidi_it->string.schars.
3981 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3982 NULL (avoids a crash in bidi_paragraph_init).
3983 Initialize itb.string.lstring.
3984 (init_iterator): Call bidi_init_it only of a valid
3985 buffer position was specified. Initialize paragraph_embedding to
3987 (reseat_to_string): Initialize the bidi iterator.
3988 (display_string): If we need to ignore text properties of
3989 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3990 original value of -1 will not work with bidi.)
3991 (compute_display_string_pos): First arg is now struct
3992 `text_pos *'; all callers changed. Support display properties on
3994 (compute_display_string_end): Support display properties on Lisp
3996 (init_iterator, reseat_1, reseat_to_string): Initialize the
3997 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3998 when iterating on a string not from display properties).
3999 (compute_display_string_pos, compute_display_string_end):
4000 Fix calculation of the object to scan. Fixes an error when using
4002 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4003 base_level_stop; instead, set base_level_stop to BEGV.
4004 Fixes crashes in vertical-motion.
4005 (next_element_from_buffer): Improve commentary for when
4006 the iterator is before prev_stop.
4007 (init_iterator): Initialize bidi_p from the default value of
4008 bidi-display-reordering, not from buffer-local value. Use the
4009 buffer-local value only if initializing for buffer iteration.
4010 (handle_invisible_prop): Support invisible properties on strings
4011 that are being bidi-reordered.
4012 (set_iterator_to_next): Support bidi reordering of C strings and
4014 (next_element_from_string): Support bidi reordering of Lisp
4016 (handle_stop_backwards): Support Lisp strings as well.
4017 (display_string): Support display of R2L glyph rows.
4018 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4019 (init_iterator): Don't initialize it->bidi_p for strings
4021 (reseat_to_string): Initialize it->bidi_p for strings here.
4022 (next_element_from_string, next_element_from_c_string)
4023 (next_element_from_buffer): Add xassert's for correspondence
4024 between IT's object being iterated and it->bidi_it.string
4026 (face_before_or_after_it_pos): Support bidi iteration.
4027 (next_element_from_c_string): Handle the case of the first string
4028 character that is not the first one in the visual order.
4029 (get_visually_first_element): New function, refactored from common
4030 parts of next_element_from_buffer, next_element_from_string, and
4031 next_element_from_c_string.
4032 (tool_bar_lines_needed, redisplay_tool_bar)
4033 (display_menu_bar): Force left-to-right direction. Add a FIXME
4034 comment for making that be controlled by a user option.
4035 (push_it, pop_it): Save and restore the state of the
4036 bidi iterator. Save and restore the bidi_p flag.
4037 (pop_it): Iterate out of display property for string iteration as
4039 (iterate_out_of_display_property): Support iteration over strings.
4040 (handle_single_display_spec): Set up it->bidi_it for iteration
4041 over a display string, and call bidi_init_it.
4042 (handle_single_display_spec, next_overlay_string)
4043 (get_overlay_strings_1, push_display_prop): Set up the bidi
4044 iterator for displaying display or overlay strings.
4045 (forward_to_next_line_start): Don't use the shortcut if
4047 (back_to_previous_visible_line_start): If handle_display_prop
4048 pushed the iterator stack, restore the internal state of the bidi
4049 iterator by calling bidi_pop_it same number of times.
4050 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4051 and we are bidi-iterating, don't decrement the iterator position;
4052 instead, set the first_elt flag in the bidi iterator, to produce
4054 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4055 (push_display_prop): xassert that we are iterating a buffer.
4056 (push_it, pop_it): Save and restore paragraph_embedding member.
4057 (handle_single_display_spec, next_overlay_string)
4058 (get_overlay_strings_1, reseat_1, reseat_to_string)
4059 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4060 correctly. Don't assume unibyte strings are not bidi-reordered.
4061 (compute_display_string_pos)
4062 (compute_display_string_end): Fix handling the case of C string.
4063 (push_it, pop_it): Save and restore from_disp_prop_p.
4064 (handle_single_display_spec, push_display_prop): Set the
4065 from_disp_prop_p flag.
4066 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4067 (pop_it): Call iterate_out_of_display_property only if we are
4068 popping after iteration over a string that came from a display
4069 property. Fix a typo in popping stretch info. Add an assertion
4070 for verifying that the iterator position is in sync with the bidi
4072 (handle_single_display_spec, get_overlay_strings_1)
4073 (push_display_prop): Fix initialization of paragraph direction for
4074 string when that of the parent object is not yet determined.
4075 (reseat_1): Call bidi_init_it to resync the bidi
4076 iterator with IT's position. (Bug#7616)
4077 (find_row_edges): If ROW->start.pos gives position
4078 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4079 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4080 Reset the from_disp_prop_p flag.
4081 (SAVE_IT, RESTORE_IT): New macros.
4082 (pos_visible_p, face_before_or_after_it_pos)
4083 (back_to_previous_visible_line_start)
4084 (move_it_in_display_line_to, move_it_in_display_line)
4085 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4086 (try_scrolling, redisplay_window, display_line): Use them when
4087 saving a temporary copy of the iterator and restoring it back.
4088 (back_to_previous_visible_line_start, reseat_1)
4089 (init_iterator): Empty the bidi cache "stack".
4090 (move_it_in_display_line_to): If iterator ended up at
4091 EOL, but we never saw any buffer positions smaller than
4092 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4093 motion in bidi-reordered lines.
4094 (move_it_in_display_line_to): Record prev_method and prev_pos
4095 immediately before the call to set_iterator_to_next. Fixes cursor
4096 motion in bidi-reordered lines with stretch glyphs and strings
4097 displayed in margins. (Bug#8133) (Bug#8867)
4098 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4100 (pos_visible_p): Support positions in bidi-reordered lines.
4101 Save and restore bidi cache.
4103 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4104 (bidi_paragraph_info): Delete unused struct.
4105 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4106 (bidi_cache_start): New variable.
4107 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4109 (bidi_cache_fetch_state, bidi_cache_search)
4110 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4111 (bidi_cache_find, bidi_peek_at_next_level)
4112 (bidi_level_of_next_char, bidi_find_other_level_edge)
4113 (bidi_move_to_visually_next): Compare cache index with
4114 bidi_cache_start rather than with zero.
4115 (bidi_fetch_char): Accept new argument STRING; all callers
4116 changed. Support iteration over a string. Support strings with
4117 display properties. Support unibyte strings. Fix the type of
4118 `len' according to what STRING_CHAR_AND_LENGTH expects.
4119 (bidi_paragraph_init, bidi_resolve_explicit_1)
4120 (bidi_resolve_explicit, bidi_resolve_weak)
4121 (bidi_level_of_next_char, bidi_move_to_visually_next):
4122 Support iteration over a string.
4123 (bidi_set_sor_type, bidi_resolve_explicit_1)
4124 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4125 can now be zero (for strings); special values 0 and -1 were
4126 changed to -1 and -2, respectively.
4127 (bidi_char_at_pos): New function.
4128 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4129 Call it instead of FETCH_MULTIBYTE_CHAR.
4130 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4131 initialized to valid values.
4132 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4134 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4135 the test for valid cached positions. Fix the logic for looking up
4136 the sentinel state in the cache. GCPRO the Lisp string we are
4138 (bidi_push_it, bidi_pop_it): New functions.
4139 (bidi_initialize): Initialize the bidi cache start stack pointer.
4140 (bidi_cache_ensure_space): New function, refactored from part of
4141 bidi_cache_iterator_state. Don't assume the required size is just
4142 one BIDI_CACHE_CHUNK away.
4143 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4144 (bidi_count_bytes, bidi_char_at_pos): New functions.
4145 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4146 always valid if bidi_cache_idx is valid.
4147 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4148 is valid if it's going to be used.
4149 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4150 (bidi_cache_fetch_state, bidi_cache_search)
4151 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4152 (bidi_cache_iterator_state, bidi_cache_find)
4153 (bidi_find_other_level_edge, bidi_cache_start_stack):
4154 All variables related to cache indices are now EMACS_INT.
4156 * dispextern.h (struct bidi_string_data): New structure.
4157 (struct bidi_it): New member `string'. Make flag members be 1-bit
4158 fields, and put them last in the struct.
4159 (compute_display_string_pos, compute_display_string_end):
4161 (bidi_push_it, bidi_pop_it): Add prototypes.
4162 (struct iterator_stack_entry): New members bidi_p,
4163 paragraph_embedding, and from_disp_prop_p.
4164 (struct it): Member bidi_p is now a bit field 1 bit wide.
4165 (bidi_shelve_cache, bidi_unshelve_cache):
4168 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4169 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4170 and vector-like objects.
4172 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4173 cache around display iteration.
4175 * window.c (Fwindow_end, window_scroll_pixel_based)
4176 (displayed_window_lines, Frecenter): Save and restore the bidi
4177 cache around display iteration.
4179 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4181 * editfns.c (Fdelete_region): Clarify the use of the named
4182 parameters (bug#6788).
4184 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4186 * indent.c (Fvertical_motion): Set and restore w->pointm when
4187 saving and restoring the window's buffer (Bug#9006).
4189 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4191 * editfns.c (Fstring_to_char): Clarify just what is returned
4192 (bug#6576). Text by Eli Zaretskii.
4194 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4196 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4198 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4200 * buffer.c (mmap_find): Fix a typo.
4202 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4204 Fix execution of x selection hooks.
4205 * xselect.c (Qx_lost_selection_functions)
4206 (Qx_sent_selection_functions): New vars.
4207 (syms_of_xselect): DEFSYM them.
4208 (x_handle_selection_request): Pass Qx_sent_selection_functions
4209 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4210 (x_handle_selection_clear,x_clear_frame_selections):
4211 Pass Qx_lost_selection_functions rather than
4212 Vx_lost_selection_functions to Frun_hook_with_args.
4214 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4216 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4217 The old code sometimes used this field without initializing it.
4219 * alloc.c (gc_sweep): Don't read past end of array.
4220 In theory, the old code could also have corrupted Emacs internals,
4221 though it'd be very unlikely.
4223 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4225 * character.c (Fcharacterp): Don't advertise optional ignored
4226 argument. (Bug#4026)
4228 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4230 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4233 * window.c (Fset_window_start): Doc fix (bug#4199).
4234 (Fset_window_hscroll): Ditto.
4236 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4238 Fix minor new problems caught by GCC 4.6.1.
4239 * term.c (init_tty): Remove unused local.
4240 * xsettings.c (store_monospaced_changed): Define this function only
4241 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4244 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4246 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4248 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4250 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4251 are the mini-buffer and the echo area (bug#3320).
4253 * term.c (init_tty): Remove support for supdup, c10 and perq
4254 terminals, which are no longer supported (bug#1482).
4256 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4258 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4260 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4262 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4263 for non-popups (Bug#3642).
4265 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4267 * alloc.c (reset_malloc_hooks): Protoize.
4268 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4269 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4270 * cm.c (losecursor): Likewise.
4271 * data.c (fmod): Likewise.
4272 * dispnew.c (swap_glyphs_in_rows): Likewise.
4273 * emacs.c (memory_warning_signal): Likewise.
4274 * floatfns.c (float_error): Likewise.
4275 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4276 (otf_open, font_otf_capability, generate_otf_features)
4277 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4279 * image.c (pbm_read_file): Likewise.
4280 * indent.c (string_display_width): Likewise.
4281 * intervals.c (check_for_interval, search_for_interval)
4282 (inc_interval_count, count_intervals, root_interval)
4283 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4284 * lread.c (defalias): Likewise.
4285 * ralloc.c (r_alloc_check): Likewise.
4286 * regex.c (set_image_of_range_1, set_image_of_range)
4287 (regex_grow_registers): Likewise.
4288 * sysdep.c (strerror): Likewise.
4289 * termcap.c (valid_filename_p, tprint, main): Likewise.
4290 * tparam.c (main): Likewise.
4291 * unexhp9k800.c (run_time_remap, save_data_space)
4292 (update_file_ptrs, read_header, write_header, calculate_checksum)
4293 (copy_file, copy_rest, display_header): Likewise.
4294 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4296 * xdisp.c (check_it): Likewise.
4297 * xfaces.c (register_color, unregister_color, unregister_colors):
4299 * xfns.c (print_fontset_result): Likewise.
4300 * xrdb.c (member, fatal, main): Likewise.
4302 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4304 Fix minor problems found by static checking (Bug#9031).
4305 * chartab.c (char_table_set_range, map_sub_char_table):
4306 Remove unused locals.
4307 (uniprop_table): Now static.
4308 * composite.c (_work_char): Remove unused static var.
4310 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4312 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4314 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4316 * gtkutil.c (qttip_cb): Remove code without function.
4318 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4320 * w32.c (pthread_sigmask): New stub.
4322 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4324 Use pthread_sigmask, not sigprocmask (Bug#9010).
4325 sigprocmask is portable only for single-threaded applications, and
4326 Emacs can be multi-threaded when it uses GTK.
4327 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4329 * callproc.c (Fcall_process):
4330 * process.c (create_process):
4331 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4332 Use pthread_sigmask, not sigprocmask.
4334 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4336 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4337 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4340 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4342 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4343 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4344 (xg_hide_tooltip): Fix comment.
4346 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4347 in registerServicesMenuSendTypes.
4348 (validRequestorForSendType): Don't check ns_return_types.
4350 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4353 2011-07-08 Jason Rumney <jasonr@gnu.org>
4355 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4356 SH_SHOW for hidden windows (Bug#5482).
4358 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4359 frame struct members of non-existent frames (Bug#6284).
4361 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4363 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4364 variable firstTime not needed on OSX >= 10.6.
4365 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4366 >= 10.5. Use setKnobProportion, setDoubleValue.
4368 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4369 (MAC_OS_X_VERSION_10_5): Define if not defined.
4370 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4371 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4372 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4374 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4375 cString and lossyCString on OSX >= 10.4
4377 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4378 sizeToFit on OSX >= 10.2.
4380 * nsimage.m (allocInitFromFile): Don't use deprecated method
4381 bestRepresentationForDevice on OSX >= 10.6.
4383 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4386 * emacs.c: Declare unexec_init_emacs_zone.
4388 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4390 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4392 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4393 on svcsMenu (Bug#8842).
4395 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4397 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4399 * nsterm.m (QUTF8_STRING): Declare.
4400 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4401 (validRequestorForSendType): Return type is (id).
4402 Change indexOfObjectIdenticalTo to indexOfObject.
4403 Check if we have local selection before returning self (Bug#8842).
4404 (writeSelectionToPasteboard): Put local selection into paste board
4405 if we have a local selection (Bug#8842).
4406 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4408 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4409 (ns_get_local_selection): Declare.
4411 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4413 * keymap.c (describe_map_tree): Don't insert a double newline at
4414 the end of the buffer (bug#1169) and return whether we inserted
4417 * callint.c (Fcall_interactively): Change "reading args" to
4418 "providing args" to try to clarify what it does (bug#1010).
4420 2011-07-07 Kenichi Handa <handa@m17n.org>
4422 * composite.c (composition_compute_stop_pos): Ignore a static
4423 composition starting before CHARPOS (Bug#8915).
4425 * xdisp.c (handle_composition_prop): Likewise.
4427 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4429 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4432 2011-07-07 Kenichi Handa <handa@m17n.org>
4434 * character.h (unicode_category_t): New enum type.
4436 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4437 (Qchar_code_property_table): New variable.
4438 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4439 (UNIPROP_COMPRESSED_FORM_P): New macros.
4440 (char_table_ascii): Uncompress the compressed values.
4441 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4442 Uncompress the compressed values.
4443 (sub_char_table_ref_and_range): Likewise.
4444 (char_table_ref_and_range): Uncompress the compressed values.
4445 (sub_char_table_set): New arg is_uniprop. Callers changed.
4446 Uncompress the compressed values.
4447 (sub_char_table_set_range): Args changed. Callers changed.
4448 (char_table_set_range): Adjuted for the above change.
4449 (map_sub_char_table): Delete args default_val and parent. Add arg
4450 top. Give decoded values to a Lisp function.
4451 (map_char_table): Adjust for the above change. Give decoded
4452 values to a Lisp function. Gcpro more variables.
4453 (uniprop_table_uncompress)
4454 (uniprop_decode_value_run_length): New functions.
4455 (uniprop_decoder, uniprop_decoder_count): New variables.
4456 (uniprop_get_decoder, uniprop_encode_value_character)
4457 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4459 (uniprop_encoder, uniprop_encoder_count): New variables.
4460 (uniprop_get_encoder, uniprop_table)
4461 (Funicode_property_table_internal, Fget_unicode_property_internal)
4462 (Fput_unicode_property_internal): New functions.
4463 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4464 Sunicode_property_table_internal, Sget_unicode_property_internal,
4465 and Sput_unicode_property_internal. Defvar_lisp
4466 char-code-property-alist.
4468 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4469 Vunicode_category_table.
4471 * font.c (font_range): Adjust for the change of
4472 Vunicode_category_table.
4474 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4476 * m/iris4d.h: Remove file, move contents ...
4477 * s/irix6-5.h: ... here.
4479 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4481 Remove unportable assumption about struct layout (Bug#8884).
4482 * alloc.c (mark_buffer):
4483 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4484 (clone_per_buffer_values): Don't assume that
4485 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4486 This isn't true in general, and it's particularly not true
4487 if Emacs is configured with --with-wide-int.
4488 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4489 New macros, used in the buffer.c change.
4491 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4493 * xsettings.c: Use both GConf and GSettings if both are available.
4494 (store_config_changed_event): Add comment.
4495 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4496 (store_tool_bar_style_changed): New functions.
4497 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4498 (struct xsettings): Move font inside HAVE_XFT.
4499 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4500 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4501 Move inside HAVE_XFT.
4502 (something_changed_gsettingsCB): Rename from something_changedCB.
4503 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4505 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4506 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4507 (something_changed_gconfCB): Rename from something_changedCB.
4508 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4509 (parse_settings): Move check for font inside HAVE_XFT.
4510 (read_settings, apply_xft_settings): Add comment.
4511 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4512 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4513 call store_font_name_changed.
4514 (xft_settings_event): Add comment.
4515 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4516 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4517 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4518 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4519 (xsettings_initialize): Call init_gsettings last.
4520 (xsettings_get_system_font, xsettings_get_system_normal_font):
4523 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4525 Random fixes. E.g., (random) never returned negative values.
4526 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4527 subseconds part to the entropy, as that's a bit more random.
4528 Prefer signed to unsigned, since the signedness doesn't matter and
4529 in general we prefer signed. When given a limit, use a
4530 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4531 latter isn't right if USE_2_TAGS_FOR_INTS.
4532 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4533 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4535 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4537 * textprop.c (text_property_stickiness):
4538 Obey Vtext_property_default_nonsticky.
4539 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4540 * w32fns.c (syms_of_w32fns):
4541 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4543 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4545 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4546 This is more efficient than Ffile_directory_p and avoids a minor race.
4548 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4550 * buffer.c (Foverlay_put): Say what the return value is
4553 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4554 is a directory before asking whether to use the file name
4556 (barf_or_query_if_file_exists): Make the "File is a directory"
4557 error be more correct.
4559 * fns.c (Frequire): Remove the mention of the .gz files, since
4560 that's installation-specific, but keep the mention of
4561 `get-load-suffixes'.
4563 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4565 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4566 Report string overflow if the output is too long.
4568 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4570 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4571 (syms_of_gnutls): Remove duplicate DEFSYM for
4572 Qgnutls_bootprop_verify_hostname_error, an error for
4573 Qgnutls_bootprop_verify_error (which is no longer used).
4575 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4576 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4577 Also (re)move comments that are misplaced or no longer relevant.
4579 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4581 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4583 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4585 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4586 and background color parameters if they have been changed.
4588 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4590 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4592 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4594 * xsettings.c (SYSTEM_FONT): Define only when used.
4595 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4597 * keymap.c (access_keymap_1): Now static.
4599 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4601 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4602 leave any prefix arg for the up event (Bug#1586).
4604 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4606 * lread.c (syms_of_lread): Mention single symbols defined by
4607 `defvar' or `defconst' (bug#7154).
4609 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4610 (Frequire): Mention get-load-suffixes.
4612 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4614 * window.h (window): Remove clone_number slot.
4615 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4617 (make_parent_window, make_window, saved_window)
4618 (Fset_window_configuration, save_window_save): Don't deal with
4620 * buffer.c (Qclone_number): Remove declaration.
4621 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4623 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4625 Add multiple inheritance to keymaps.
4626 * keymap.c (Fmake_composed_keymap): New function.
4627 (Fset_keymap_parent): Simplify.
4628 (fix_submap_inheritance): Remove.
4629 (access_keymap_1): New function extracted from access_keymap to handle
4630 embedded parents and handle lists of maps.
4631 (access_keymap): Use it.
4632 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4633 (Fcopy_keymap): Handle embedded parents.
4634 (Fcommand_remapping, define_as_prefix): Simplify.
4635 (Fkey_binding): Simplify.
4636 (syms_of_keymap): Move minibuffer-local-completion-map,
4637 minibuffer-local-filename-completion-map,
4638 minibuffer-local-must-match-map, and
4639 minibuffer-local-filename-must-match-map to Elisp.
4640 (syms_of_keymap): Defsubr make-composed-keymap.
4641 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4642 (parse_menu_item): Trivial simplification.
4644 2011-07-01 Glenn Morris <rgm@gnu.org>
4646 * Makefile.in (SETTINGS_LIBS): Fix typo.
4648 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4650 * coding.c (Fencode_coding_string): Record the last coding system
4651 used, as the function doc string says (bug#8738).
4653 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4655 * xsettings.c (store_monospaced_changed): Take new font as arg and
4656 check for change against current_mono_font.
4657 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4658 (emacs_settings_constructor, emacs_settings_get_property)
4659 (emacs_settings_set_property, emacs_settings_class_init)
4660 (emacs_settings_init, gsettings_obj): Remove.
4661 (something_changedCB): New function for HAVE_GSETTINGS.
4662 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4663 with value as argument.
4664 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4665 g_settings_new (Bug#8967). Do not create gsettings_obj.
4666 Remove calls to g_settings_bind. Connect something_changedCB to
4669 * xgselect.c: Add defined (HAVE_GSETTINGS).
4670 (xgselect_initialize): Ditto.
4672 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4673 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4676 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4678 * eval.c (struct backtrace): Simplify and port the data structure.
4679 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4680 signed bit field, as this assumption is not portable and it makes
4681 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4682 "char debug_on_exit : 1" as this is not portable either; instead,
4683 use the portable "unsigned int debug_on_exit : 1". Remove unused
4684 member evalargs. Remove obsolete comments about cc bombing out.
4686 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4688 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4689 Let HAVE_GSETTINGS override HAVE_GCONF.
4690 (store_monospaced_changed): New function.
4691 (EMACS_SETTINGS): A new type derived from GObject to handle
4692 GSettings notifications.
4693 (emacs_settings_constructor, emacs_settings_get_property)
4694 (emacs_settings_set_property, emacs_settings_class_init):
4696 (gsettings_client, gsettings_obj): New variables.
4697 (GSETTINGS_SCHEMA): New define.
4698 (something_changedCB): Call store_monospaced_changed.
4699 (init_gsettings): New function.
4700 (xsettings_initialize): Call init_gsettings.
4701 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4704 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4707 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4709 * window.c (resize_root_window, grow_mini_window)
4710 (shrink_mini_window): Rename Qresize_root_window to
4711 Qwindow_resize_root_window and Qresize_root_window_vertically to
4712 Qwindow_resize_root_window_vertically.
4714 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4716 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4718 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4720 * makefile.w32-in: Redesign dependencies so they reflect more
4721 clearly which files are directly included by each source file,
4722 and not through other includes.
4724 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4726 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4727 (sort_overlays, overlay_strings): When an overlay's clone number
4728 matches the window's clone number process the overlay even if
4729 the overlay's window property doesn't match the current window.
4731 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4732 (Fwindow_hchild): Rename to Fwindow_left_child.
4733 (Fwindow_next): Rename to Fwindow_next_sibling.
4734 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4735 (resize_window_check): Rename to window_resize_check.
4736 (resize_window_apply): Rename to window_resize_apply.
4737 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4738 (Fdelete_other_windows_internal, resize_frame_windows)
4739 (Fsplit_window_internal, Fdelete_window_internal)
4740 (grow_mini_window, shrink_mini_window)
4741 (Fresize_mini_window_internal): Fix callers accordingly.
4743 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4745 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4746 (emacs_fixed_set_min_size): Remove.
4747 (emacs_fixed_new): Take frame as argument.
4749 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4750 (_EmacsFixedPrivate): Remove minwidth/height.
4751 Add struct frame *f.
4752 (emacs_fixed_init): Initialize priv->f.
4753 (get_parent_class, emacs_fixed_set_min_size): Remove.
4754 (emacs_fixed_new): Set priv->f to argument.
4755 (emacs_fixed_get_preferred_width)
4756 (emacs_fixed_get_preferred_height): Use min_width/height from
4757 frames size_hint to set minimum and natural (Bug#8919).
4758 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4759 and use min_width/height from frames size_hint to set
4760 min_width/height (Bug#8919).
4762 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4763 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4766 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4768 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4769 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4772 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4774 * process.c (wait_reading_process_output): Bypass select if
4775 waiting for a cell while ignoring keyboard input, and input is
4776 pending. Suggested by Jan Djärv (Bug#8869).
4778 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4780 Use gnulib's dup2 module instead of rolling our own.
4781 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4783 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4785 * dispnew.c (scrolling_window): Before scrolling, turn off a
4786 mouse-highlight in the window being scrolled.
4788 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4790 Move DEFSYM to lisp.h and use everywhere.
4792 * character.h (DEFSYM): Move declaration...
4793 * lisp.h (DEFSYM): ...here.
4799 * w32select.c: Don't include character.h.
4801 * alloc.c (syms_of_alloc):
4802 * buffer.c (syms_of_buffer):
4803 * bytecode.c (syms_of_bytecode):
4804 * callint.c (syms_of_callint):
4805 * casefiddle.c (syms_of_casefiddle):
4806 * casetab.c (init_casetab_once):
4807 * category.c (init_category_once, syms_of_category):
4808 * ccl.c (syms_of_ccl):
4809 * cmds.c (syms_of_cmds):
4810 * composite.c (syms_of_composite):
4811 * dbusbind.c (syms_of_dbusbind):
4812 * dired.c (syms_of_dired):
4813 * dispnew.c (syms_of_display):
4814 * doc.c (syms_of_doc):
4815 * editfns.c (syms_of_editfns):
4816 * emacs.c (syms_of_emacs):
4817 * eval.c (syms_of_eval):
4818 * fileio.c (syms_of_fileio):
4819 * fns.c (syms_of_fns):
4820 * frame.c (syms_of_frame):
4821 * fringe.c (syms_of_fringe):
4822 * insdel.c (syms_of_insdel):
4823 * keymap.c (syms_of_keymap):
4824 * lread.c (init_obarray, syms_of_lread):
4825 * macros.c (syms_of_macros):
4826 * msdos.c (syms_of_msdos):
4827 * print.c (syms_of_print):
4828 * process.c (syms_of_process):
4829 * search.c (syms_of_search):
4830 * sound.c (syms_of_sound):
4831 * syntax.c (init_syntax_once, syms_of_syntax):
4832 * terminal.c (syms_of_terminal):
4833 * textprop.c (syms_of_textprop):
4834 * undo.c (syms_of_undo):
4835 * w32.c (globals_of_w32):
4836 * window.c (syms_of_window):
4837 * xdisp.c (syms_of_xdisp):
4838 * xfaces.c (syms_of_xfaces):
4839 * xfns.c (syms_of_xfns):
4840 * xmenu.c (syms_of_xmenu):
4841 * xsettings.c (syms_of_xsettings):
4842 * xterm.c (syms_of_xterm): Use DEFSYM.
4844 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4846 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4848 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4850 Integer and buffer overflow fixes (Bug#8873).
4852 * print.c (printchar, strout): Check for string overflow.
4853 (PRINTPREPARE, printchar, strout):
4854 Don't set size unless allocation succeeds.
4856 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4857 for sizes. Check for string overflow more accurately.
4858 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4860 * macros.c: Integer and buffer overflow fixes.
4861 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4862 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4863 Use ptrdiff_t, not int, for sizes.
4864 Don't increment bufsize until after realloc succeeds.
4865 Check for size-calculation overflow.
4866 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4868 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4870 * lread.c: Integer overflow fixes.
4871 (read_integer): Radix is now EMACS_INT, not int,
4872 to improve quality of diagnostics for out-of-range radices.
4873 Calculate buffer size correctly for out-of-range radices.
4874 (read1): Check for integer overflow in radices, and in
4875 read-circle numbers.
4876 (read_escape): Avoid int overflow.
4877 (Fload, openp, read_buffer_size, read1)
4878 (substitute_object_recurse, read_vector, read_list, map_obarray):
4879 Use ptrdiff_t, not int, for sizes.
4880 (read1): Use EMACS_INT, not int, for sizes.
4881 Check for size overflow.
4883 * image.c (cache_image): Check for size arithmetic overflow.
4885 * lread.c: Integer overflow issues.
4886 (saved_doc_string_size, saved_doc_string_length)
4887 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4888 Now ptrdiff_t, not int.
4889 (read1): Don't assume doc string length fits in int. Check for
4890 out-of-range doc string lengths.
4891 (read_list): Don't assume file position fits in int.
4892 (read_escape): Check for hex character overflow.
4894 2011-06-22 Leo Liu <sdl.web@gmail.com>
4896 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4897 Move to minibuffer.el.
4899 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4901 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4902 The following patches are for when GLYPH_DEBUG && !XASSERT.
4903 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4904 * dispnew.c (flush_stdout):
4905 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4906 Mark as externally visible.
4907 * dispnew.c (check_window_matrix_pointers): Now static.
4908 * dispnew.c (window_to_frame_vpos):
4909 * xfns.c (unwind_create_frame):
4910 * xterm.c (x_check_font): Remove unused local.
4911 * scroll.c (CHECK_BOUNDS):
4912 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4913 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4914 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4915 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4916 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4918 (debug_method_add): Use va_list and vsprintf rather than relying
4919 on undefined behavior with wrong number of arguments.
4920 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4921 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4922 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4923 since we're not interested in debugging glyphs with old libraries.
4924 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4925 GCC 4.6.0's static checking.
4927 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4929 Integer overflow and signedness fixes (Bug#8873).
4930 A few related buffer overrun fixes, too.
4932 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4934 * dispextern.h (struct face.stipple):
4935 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4936 (x_bitmap_mask, x_allocate_bitmap_record)
4937 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4938 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4939 (x_create_bitmap_from_xpm_data):
4940 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4941 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4943 * xfaces.c (load_pixmap):
4944 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4945 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4946 (.bitmaps_last, struct x_output.icon_bitmap):
4947 Use ptrdiff_t, not int, for bitmap indexes.
4948 (x_allocate_bitmap_record): Check for size overflow.
4949 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4951 Use ptrdiff_t, not int, for overlay counts.
4952 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4953 * editfns.c (overlays_around, get_pos_property):
4954 * textprop.c (get_char_property_and_overlay):
4955 * xdisp.c (next_overlay_change, note_mouse_highlight):
4956 * xfaces.c (face_at_buffer_position):
4957 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4958 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4959 (Fnext_overlay_change, Fprevious_overlay_change)
4960 (mouse_face_overlay_overlaps, Foverlays_in):
4961 Use ptrdiff_t, not int, for sizes.
4962 (overlays_at, overlays_in): Check for size-calculation overflow.
4964 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4966 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4967 (x_session_initialize): Do not assume string length fits in int.
4969 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4970 This is unlikely, but can occur if DPI is outlandish.
4972 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4973 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4975 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4976 * xrdb.c (magic_file_p, search_magic_path):
4977 Omit last arg SUFFIX; it was always 0. All callers changed.
4978 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4980 * xfont.c (xfont_match): Avoid need for strlen.
4982 * xfns.c: Don't assume strlen fits in int.
4983 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4985 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4986 not unsigned long, as we prefer signed integers. All callers changed.
4987 Detect integer overflow in repeat count.
4988 (message_dolog): Don't assume print length fits in 39 bytes.
4989 (display_mode_element): Don't assume strlen fits in int.
4991 * termcap.c: Don't assume sizes fit in int and never overflow.
4992 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4993 (gobble_line): Check for size-calculation overflow.
4995 * minibuf.c (Fread_buffer):
4996 * lread.c (intern, intern_c_string):
4997 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4998 Don't assume string length fits in int.
5000 * keyboard.c (parse_tool_bar_item):
5001 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5003 * font.c: Don't assume string length fits in int.
5004 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5005 Use ptrdiff_t, not int.
5006 (font_intern_prop): Don't assume string length fits in int.
5007 Don't assume integer property fits in fixnum.
5008 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5010 * filelock.c: Fix some buffer overrun and integer overflow issues.
5011 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5012 Reformulate so as not to need the command string.
5013 Invoke gzip -cd rather than gunzip, as it's more portable.
5014 (lock_info_type, lock_file_1, lock_file):
5015 Don't assume pid_t and time_t fit in unsigned long.
5016 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5017 (current_lock_owner): Prefer signed type for sizes.
5018 Use memcpy, not strncpy, where memcpy is what is really wanted.
5019 Don't assume (via atoi) that time_t and pid_t fit in int.
5020 Check for time_t and/or pid_t out of range, e.g., via a network share.
5021 Don't alloca where an auto var works fine.
5023 * fileio.c: Fix some integer overflow issues.
5024 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5025 Don't assume string length fits in int.
5026 (directory_file_name): Don't assume string length fits in long.
5027 (make_temp_name): Don't assume pid fits in int, or that its print
5028 length is less than 20.
5030 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5032 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5034 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5036 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5037 We prefer signed integers, even for size calculations.
5039 * emacs.c: Don't assume string length fits in 'int'.
5040 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5041 (main): Don't invoke strlen when not needed.
5043 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5044 (XD_DEBUG_MESSAGE): Don't waste a byte.
5046 * callproc.c (getenv_internal_1, getenv_internal)
5048 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5050 * lread.c (invalid_syntax): Omit length argument.
5051 All uses changed. This doesn't fix a bug, but it simplifies the
5052 code away from its former Hollerith-constant appearance, and it's
5053 one less 'int' to worry about when looking at integer-overflow issues.
5054 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5056 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5057 This didn't break anything, but it didn't help either.
5058 It's confusing to put a bogus integer in a place where the actual
5059 value does not matter.
5060 (LIST_END_P): Remove unused macro and its bogus comment.
5061 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5063 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5064 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5066 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5067 We prefer signed types, and the value cannot exceed the EMACS_INT
5068 range anyway (because otherwise the length would not be representable).
5069 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5070 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5071 This avoids a GCC warning when WIDE_EMACS_INT.
5073 * indent.c (sane_tab_width): New function.
5074 (current_column, scan_for_column, Findent_to, position_indentation)
5075 (compute_motion): Use it. This is just for clarity.
5076 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5078 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5080 * lisp.h (lint_assume): New macro.
5081 * composite.c (composition_gstring_put_cache):
5082 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5084 * editfns.c, insdel.c:
5085 Omit unnecessary forward decls, to simplify future changes.
5087 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5089 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5091 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5092 Use much-faster test for byte-length change.
5093 Don't assume string byte-length fits in 'int'.
5094 Check that character arg fits in 'int'.
5095 (mapcar1): Declare byte as byte, for clarity.
5097 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5099 * fns.c (concat): Catch string overflow earlier.
5100 Do not rely on integer wraparound.
5102 * dispextern.h (struct it.overlay_strings_charpos)
5103 (struct it.selective): Now EMACS_INT, not int.
5104 * xdisp.c (forward_to_next_line_start)
5105 (back_to_previous_visible_line_start)
5106 (reseat_at_next_visible_line_start, next_element_from_buffer):
5107 Don't arbitrarily truncate the value of 'selective' to int.
5109 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5111 * composite.c: Don't truncate sizes to 'int'.
5112 (composition_gstring_p, composition_reseat_it)
5113 (composition_adjust_point): Use EMACS_INT, not int.
5114 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5115 not EMACS_UINT, for indexes.
5117 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5119 * buffer.c: Include <verify.h>.
5120 (struct sortvec.priority, struct sortstr.priority):
5121 Now EMACS_INT, not int.
5122 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5123 (struct sortstr.size, record_overlay_string)
5124 (struct sortstrlist.size, struct sortlist.used):
5125 Don't truncate size to int.
5126 (record_overlay_string): Check for size-calculation overflow.
5127 (init_buffer_once): Check at compile-time, not run-time.
5129 2011-06-22 Jim Meyering <meyering@redhat.com>
5131 Don't leak an XBM-image-sized buffer
5132 * image.c (xbm_load): Free the image buffer after using it.
5134 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5137 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5138 that Sun C diagnosed.
5139 * fns.c (secure_hash): Fix pointer signedness issue.
5140 * intervals.c (static_offset_intervals): New function.
5141 (offset_intervals): Use it.
5143 2011-06-21 Leo Liu <sdl.web@gmail.com>
5146 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5149 * fns.c (secure_hash): Rename from crypto_hash_function and change
5150 the first arg to accept symbols.
5151 (Fsecure_hash): New primitive.
5152 (syms_of_fns): New symbols.
5154 2011-06-20 Deniz Dogan <deniz@dogan.se>
5156 * process.c (Fset_process_buffer): Clarify return value in
5159 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5161 * dispnew.c (add_window_display_history): Use BVAR.
5163 * xdisp.c (debug_method_add): Use BVAR.
5164 (check_window_end, dump_glyph_matrix, dump_glyph)
5165 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5167 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5170 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5171 check till after the cache is created in init_frame_faces.
5173 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5175 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5177 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5179 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5180 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5181 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5183 Improve buffer-overflow checking (Bug#8873).
5184 * fileio.c (Finsert_file_contents):
5185 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5186 Remove the old (too-loose) buffer overflow checks.
5187 They weren't needed, since make_gap checks for buffer overflow.
5188 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5189 The old code merely checked for Emacs fixnum overflow, and relied
5190 on undefined (wraparound) behavior. The new code avoids undefined
5191 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5193 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5194 Tune. Don't use wider integers than needed. Don't use alloca.
5195 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5197 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5199 * insdel.c, lisp.h (buffer_overflow): New function.
5200 (insert_from_buffer_1, replace_range, replace_range_2):
5201 * insdel.c (make_gap_larger):
5202 * editfns.c (Finsert_char):
5203 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5205 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5207 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5209 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5211 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5212 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5214 * fileio.c: Don't assume EMACS_INT fits in off_t.
5215 (emacs_lseek): New static function.
5216 (Finsert_file_contents, Fwrite_region): Use it.
5217 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5219 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5221 * fns.c: Don't overflow int when computing a list length.
5222 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5223 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5224 truncation on 64-bit hosts. Check for QUIT every
5225 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5226 faster and is responsive enough.
5227 (Flength): Report an error instead of overflowing an integer.
5228 (Fsafe_length): Return a float if the value is not representable
5229 as a fixnum. This shouldn't happen except in contrived situations.
5230 (Fnthcdr, Fsort): Don't assume list length fits in int.
5231 (Fcopy_sequence): Don't assume vector length fits in int.
5233 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5234 (header_size, word_size): New constants.
5235 (allocate_vectorlike): Don't check size overflow here.
5236 (allocate_vector): Check it here instead, since this is the only
5237 caller of allocate_vectorlike that could cause overflow.
5238 Check that the new vector's length is representable as a fixnum.
5240 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5241 The previous code was bogus. For example, next_almost_prime (32)
5242 returned 39, which is undesirable as it is a multiple of 3; and
5243 next_almost_prime (24) returned 25, which is a multiple of 5 so
5244 why was the code bothering to check for multiples of 7?
5246 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5248 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5250 Variadic C functions now count arguments with ptrdiff_t.
5251 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5252 Back then I didn't know that the Emacs coding style prefers signed int.
5253 Also, in the meantime I found a few more instances where arguments
5254 were being counted with int, which may truncate counts on 64-bit
5255 machines, or EMACS_INT, which may be unnecessarily wide.
5256 * lisp.h (struct Lisp_Subr.function.aMANY)
5257 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5258 Arg counts are now ptrdiff_t, not size_t.
5259 All variadic functions and their callers changed accordingly.
5260 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5261 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5262 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5263 * callint.c (Fcall_interactively): Check arg count for overflow,
5264 to avoid potential buffer overrun. Use signed char, not 'int',
5265 for 'varies' array, so that we needn't bother to check its size
5266 calculation for overflow.
5267 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5268 * eval.c (apply_lambda):
5269 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5270 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5271 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5273 * callint.c (Fcall_interactively): Don't use index var as event count.
5275 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5276 * mem-limits.h (SIZE): Remove; no longer used.
5278 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5280 Remove unnecessary casts.
5281 * xterm.c (x_term_init):
5282 * xfns.c (x_set_border_pixel):
5283 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5284 These aren't needed now that we assume ANSI C.
5286 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5287 It's more likely to cause problems (due to unsigned overflow)
5290 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5292 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5294 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5296 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5298 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5300 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5302 GLYPH_CODE_FACE returns EMACS_INT, not int.
5303 * dispextern.h (merge_faces):
5304 * xfaces.c (merge_faces):
5305 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5306 Don't assume EMACS_INT fits in int.
5308 * character.h (CHAR_VALID_P): Remove unused parameter.
5309 * fontset.c, lisp.h, xdisp.c: All uses changed.
5311 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5313 * fns.c (concat): Minor tuning based on overflow analysis.
5314 This doesn't fix any bugs. Use int to hold character, instead
5315 of constantly refetching from Emacs object. Use XFASTINT, not
5316 XINT, for value known to be a character. Don't bother comparing
5317 a single byte to 0400, as it's always less.
5319 * floatfns.c (Fexpt):
5320 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5322 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5325 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5327 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5328 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5329 incorrectly succeed when S was a string, because 4294967386 was
5330 truncated before it was used.
5332 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5333 Otherwise, an out-of-range integer could cause undefined behavior
5336 * composite.c: Use int, not EMACS_INT, for characters.
5337 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5338 EMACS_INT, for values that are known to be in character range.
5339 This doesn't fix any bugs but is the usual style inside Emacs and
5340 may generate better code on 32-bit machines.
5342 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5343 This is for reasons similar to the recent CHAR_STRING fix.
5344 * charset.c (Fencode_char): Check that character arg is actually
5345 a character. Pass an int to ENCODE_CHAR.
5346 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5347 wider than 'int', as a compile-time check to prevent future regressions
5350 * character.c (char_string): Remove unnecessary casts.
5352 Make sure a 64-bit char is never passed to CHAR_STRING.
5353 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5354 by silently ignoring the top 32 bits, allowing some values
5355 that were far too large to be valid characters.
5356 * character.h: Include <verify.h>.
5357 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5358 arguments are no wider than unsigned, as a compile-time check
5359 to prevent future regressions in this area.
5361 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5362 (Fsubst_char_in_region):
5364 * xdisp.c (decode_mode_spec_coding):
5365 Adjust to CHAR_STRING's new requirement.
5366 * editfns.c (Finsert_char, Fsubst_char_in_region):
5367 * fns.c (concat): Check that character args are actually
5368 characters. Without this test, these functions did the wrong
5369 thing with wildly out-of-range values on 64-bit hosts.
5371 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5372 These casts should not be needed on 32-bit hosts, either.
5373 * keyboard.c (read_char):
5374 * lread.c (Fload): Remove casts to unsigned.
5376 * lisp.h (UNSIGNED_CMP): New macro.
5377 This fixes comparison bugs on 64-bit hosts.
5378 (ASCII_CHAR_P): Use it.
5379 * casefiddle.c (casify_object):
5380 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5381 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5382 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5383 * dispextern.h (FACE_FROM_ID):
5384 * keyboard.c (read_char): Use UNSIGNED_CMP.
5386 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5387 not to EMACS_INT, to avoid GCC warning.
5389 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5391 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5392 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5393 isn't needed on 32-bit machines.
5395 * buffer.c (Fgenerate_new_buffer_name):
5396 Use EMACS_INT for count, not int.
5397 (advance_to_char_boundary): Return EMACS_INT, not int.
5399 * data.c (Qcompiled_function): Now static.
5401 * window.c (window_body_lines): Now static.
5403 * image.c (gif_load): Rename local to avoid shadowing.
5405 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5406 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5407 * alloc.c (make_save_value): Integer argument is now of type
5409 (mark_object): Use ptrdiff_t, not int.
5410 * lisp.h (pD): New macro.
5411 * print.c (print_object): Use it.
5413 * alloc.c: Use EMACS_INT, not int, to count objects.
5414 (total_conses, total_markers, total_symbols, total_vector_size)
5415 (total_free_conses, total_free_markers, total_free_symbols)
5416 (total_free_floats, total_floats, total_free_intervals)
5417 (total_intervals, total_strings, total_free_strings):
5418 Now EMACS_INT, not int. All uses changed.
5419 (Fgarbage_collect): Compute overall total using a double, so that
5420 integer overflow is less likely to be a problem. Check for overflow
5421 when converting back to an integer.
5422 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5423 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5424 These were 'int' variables that could overflow on 64-bit hosts;
5425 they were never used, so remove them instead of repairing them.
5426 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5427 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5428 Previously, this ceilinged at INT_MAX, but that doesn't work on
5430 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5432 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5433 (allocate_vectorlike): Check for ptrdiff_t overflow.
5434 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5435 when a (possibly-narrower) signed value would do just as well.
5436 We prefer using signed arithmetic, to avoid comparison confusion.
5438 * alloc.c: Catch some string size overflows that we were missing.
5439 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5440 for convenience in STRING_BYTES_MAX.
5441 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5442 The definition here is exact; the one in lisp.h was approximate.
5443 (allocate_string_data): Check for string overflow. This catches
5444 some instances we weren't catching before. Also, it catches
5445 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5446 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5447 and ptrdiff_t and EMACS_INT are both 64 bits.
5449 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5450 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5451 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5453 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5455 * alloc.c (Fmake_string): Check for out-of-range init.
5457 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5459 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5461 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5463 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5464 xg_get_default_scrollbar_width.
5466 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5467 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5468 (style_changed_cb): Call update_theme_scrollbar_width and call
5469 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5470 all frames (Bug#8505).
5471 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5472 Call gtk_window_set_resizable if HAVE_GTK3.
5473 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5474 and height if HAVE_GTK3 (Bug#8505).
5475 (scroll_bar_width_for_theme): New variable.
5476 (update_theme_scrollbar_width): New function.
5477 (xg_get_default_scrollbar_width): Move code to
5478 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5479 (xg_initialize): Call update_theme_scrollbar_width.
5481 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5483 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5485 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5487 * frame.c (make_frame): Call other_buffer_safely instead of
5490 * window.c (temp_output_buffer_show): Call display_buffer with
5491 second argument Vtemp_buffer_show_specifiers and reset latter
5492 immediately after the call.
5493 (Vtemp_buffer_show_specifiers): New variable.
5494 (auto_window_vscroll_p, next_screen_context_lines)
5495 (Vscroll_preserve_screen_position): Remove leading asterisks from
5498 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5500 Fix minor problems found by GCC 4.6.0 static checking.
5501 * buffer.c (Qclone_number): Remove for now, as it's unused.
5502 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5503 (record_buffer): Remove unused local.
5504 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5505 (set_frame_buffer_list): Remove; unused.
5506 * frame.h (other_visible_frames): Remove decl.
5507 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5508 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5509 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5511 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5512 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5513 Define only if HAVE_GPM.
5514 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5515 (update_hints_inhibit): Remove; never set. All uses removed.
5516 * widgetprv.h (emacsFrameClassRec): Remove decl.
5517 * window.c (delete_deletable_window): Now returns void, since it
5518 wasn't returning anything.
5519 (compare_window_configurations): Remove unused locals.
5520 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5521 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5522 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5523 the same widths as pointers. This follows up on the 2011-05-06 patch.
5524 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5525 * xterm.h: Likewise.
5526 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5528 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5530 * makefile.w32-in: Update dependencies.
5531 (LISP_H): Add lib/intprops.h.
5533 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5535 * image.c (gif_load): Add animation frame delay to the metadata.
5536 (syms_of_image): Use DEFSYM. New symbol `delay'.
5538 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5540 * window.c (delete_deletable_window): Re-add.
5541 (Fset_window_configuration): Rewrite to handle dead buffers and
5542 consequently deletable windows.
5543 (window_tree, Fwindow_tree): Remove. Supply functionality in
5545 (compare_window_configurations): Simplify code.
5547 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5549 * image.c (imagemagick_load_image): Fix type mismatch.
5550 (Fimagemagick_types): Likewise.
5552 * window.h (replace_buffer_in_windows): Declare.
5554 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5556 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5557 Qclone_number. Remove external declaration of Qdelete_window.
5558 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5560 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5561 Run Qbuffer_list_update_hook if allowed.
5562 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5563 buffer list implementation.
5564 (other_buffer_safely): New function.
5565 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5566 calls to replace_buffer_in_windows and
5567 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5569 (record_buffer): Inhibit quitting and rewrite using quittable
5570 functions. Run Qbuffer_list_update_hook if allowed.
5571 (Frecord_buffer, Funrecord_buffer): New functions.
5572 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5573 Move switch-to-buffer to window.el.
5574 (bury-buffer): Move to window.el.
5575 (Vbuffer_list_update_hook): New variable.
5577 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5580 * window.h (resize_frame_windows): Move up in code.
5581 (Fwindow_frame): Remove EXFUN.
5582 (replace_buffer_in_all_windows): Remove prototype.
5583 (replace_buffer_in_windows_safely): Add prototype.
5585 * window.c: Declare Qdelete_window static again. Move down
5586 declaration of select_count.
5587 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5588 (Fother_window): Move to window.el.
5589 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5590 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5591 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5593 (replace_buffer_in_windows): Implement by calling
5594 Qreplace_buffer_in_windows.
5595 (replace_buffer_in_all_windows): Remove with some functionality
5596 moved into replace_buffer_in_windows_safely.
5597 (replace_buffer_in_windows_safely): New function.
5598 (select_window_norecord, select_frame_norecord): Move in front
5599 of run_window_configuration_change_hook. Remove now obsolete
5601 (Fset_window_buffer): Rewrite doc-string.
5602 Call Qrecord_window_buffer.
5603 (keys_of_window): Move binding for other-window to window.el.
5605 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5607 * dispextern.h (struct image): Replace data member, whose int_val
5608 and ptr_val fields were not used by anything, with a single
5611 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5612 (gif_clear_image, gif_load, imagemagick_load_image)
5613 (gs_clear_image, gs_load): Callers changed.
5615 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5617 * buffer.h: Include <time.h>, for time_t.
5618 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5620 Fix minor problems found by static checking.
5622 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5624 Make identifiers static if they are not used in other modules.
5625 * data.c (Qcompiled_function, Qframe, Qvector):
5626 * image.c (QimageMagick, Qsvg):
5627 * minibuf.c (Qmetadata):
5628 * window.c (resize_window_check, resize_root_window): Now static.
5629 * window.h (resize_window_check, resize_root_window): Remove decls.
5631 * window.c (window_deletion_count, delete_deletable_window):
5633 (window_body_lines): Now static.
5634 (Fdelete_other_windows_internal): Mark vars as initialized.
5635 Make sure 'resize_failed' is initialized.
5636 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5637 (resize_window_apply): Remove unused local.
5638 * window.h (delete_deletable_window): Remove decl.
5640 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5641 (imagemagick_load_image): Fix pointer signedness problem by changing
5642 last arg from unsigned char * to char *. All uses changed.
5643 Also, fix a local for similar reasons.
5644 Remove unused locals. Remove locals to avoid shadowing.
5645 (fn_rsvg_handle_free): Remove; unused.
5646 (svg_load, svg_load_image): Fix pointer signedness problem.
5647 (imagemagick_load_image): Don't use garbage pointer image_wand.
5649 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5651 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5653 * image.c (gif_load): Fix omitted cast error introduced by
5656 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5658 * window.h (resize_proportionally, orig_total_lines)
5659 (orig_top_line): Remove from window structure.
5660 (set_window_height, set_window_width, change_window_heights)
5661 (Fdelete_window): Remove prototypes.
5662 (resize_frame_windows): Remove duplicate declaration.
5664 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5666 * window.h (resize_frame_windows, resize_window_check)
5667 (delete_deletable_window, resize_root_window)
5668 (resize_frame_windows): Declare prototypes.
5670 * window.c (resize_window_apply): Make definition be "static" to
5671 match the prototype.
5673 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5675 * window.c: Remove declarations of Qwindow_size_fixed,
5676 window_min_size_1, window_min_size_2, window_min_size,
5677 size_window, window_fixed_size_p, enlarge_window, delete_window.
5678 Remove static from declaration of Qdelete_window, it's
5679 temporarily needed by Fbury_buffer.
5680 (replace_window): Don't assign orig_top_line and
5682 (Fdelete_window, delete_window): Remove. Window deletion is
5683 handled by window.el.
5684 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5685 Replace Fdelete_window calls with calls to Qdelete_window.
5686 (Fdelete_other_windows): Remove. Deleting other windows is
5687 handled by window.el.
5688 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5689 handled in window.el.
5690 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5691 Window minimum sizes are handled in window.el.
5692 (shrink_windows, size_window, set_window_height)
5693 (set_window_width, change_window_heights, window_height)
5694 (window_width, CURBEG, CURSIZE, enlarge_window)
5695 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5696 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5697 handled in window.el.
5698 (make_dummy_parent): Rename to make_parent_window and give it a
5699 second argument horflag.
5700 (make_window): Don't set resize_proportionally any more.
5701 (Fsplit_window): Remove. Windows are split in window.el.
5702 (save_restore_action, save_restore_orig_size)
5703 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5704 Resize mini windows in window.el.
5705 (grow_mini_window, shrink_mini_window): Implement by calling
5706 Qresize_root_window_vertically, resize_window_check and
5707 resize_window_apply.
5708 (saved_window, Fset_window_configuration, save_window_save):
5709 Do not handle orig_top_line, orig_total_lines, and
5710 resize_proportionally.
5711 (window_min_height, window_min_width): Move to window.el.
5712 (keys_of_window): Move bindings for delete-other-windows,
5713 split-window, delete-window and enlarge-window to window.el.
5715 * buffer.c: Temporarily extern Qdelete_window.
5716 (Fbury_buffer): Temporarily call Qdelete_window instead of
5717 Fdelete_window (Fbury_buffer will move to window.el soon).
5719 * frame.c (set_menu_bar_lines_1): Remove code handling
5720 orig_top_line and orig_total_lines.
5722 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5723 set_window_height but set heights directly.
5724 (change_frame_size_1): Use resize_frame_windows.
5726 * xdisp.c (init_xdisp): Don't use set_window_height but set
5729 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5730 Use resize_frame_windows instead of change_window_heights and run
5731 run_window_configuration_change_hook.
5733 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5734 instead of change_window_heights and run
5735 run_window_configuration_change_hook.
5737 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5739 * window.c (replace_window): Rename second argument REPLACEMENT to
5740 NEW. New third argument SETFLAG. Rewrite.
5741 (delete_window, make_dummy_parent): Call replace_window with
5743 (window_list_1): Move down in code.
5744 (run_window_configuration_change_hook): Move set_buffer part
5745 before select_frame_norecord part in order to unwind correctly.
5746 Rename count1 to count.
5747 (recombine_windows, delete_deletable_window, resize_root_window)
5748 (Fdelete_other_windows_internal)
5749 (Frun_window_configuration_change_hook, make_parent_window)
5750 (resize_window_check, resize_window_apply, Fresize_window_apply)
5751 (resize_frame_windows, Fsplit_window_internal)
5752 (Fdelete_window_internal, Fresize_mini_window_internal):
5754 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5756 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5758 * window.h (window): Add some new members to window structure -
5759 normal_lines, normal_cols, new_total, new_normal, clone_number,
5760 splits, nest, prev_buffers, next_buffers.
5761 (WINDOW_TOTAL_SIZE): Move here from window.c.
5762 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5764 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5766 (make_dummy_parent): Set new members of windows structure.
5767 (make_window): Move down in code. Handle new members of window
5769 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5770 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5771 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5772 (Fset_window_prev_buffers, Fwindow_next_buffers)
5773 (Fset_window_next_buffers, Fset_window_clone_number):
5775 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5776 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5778 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5779 Argument WINDOW can be now internal window too.
5780 (Fwindow_use_time): Move up in code.
5781 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5783 (Fset_window_configuration, saved_window)
5784 (Fcurrent_window_configuration, save_window_save): Handle new
5785 members of window structure.
5786 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5787 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5788 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5789 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5790 Qget_mru_window, Qresize_root_window,
5791 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5792 Qauto_buffer_name; staticpro them.
5794 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5796 * window.c (Fwindow_total_size, Fwindow_left_column)
5797 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5798 (Fwindow_list_1): New functions.
5799 (window_box_text_cols): Replace with window_body_cols.
5800 (Fwindow_width, Fscroll_left, Fscroll_right):
5801 Use window_body_cols instead of window_box_text_cols.
5802 (delete_window, Fset_window_configuration):
5803 Call delete_all_subwindows with window as argument.
5804 (delete_all_subwindows): Take a window as argument and not a
5806 (window_loop): Remove handling of GET_LRU_WINDOW and
5808 (Fget_lru_window, Fget_largest_window): Move to window.el.
5810 * window.h: Extern window_body_cols instead of
5811 window_box_text_cols. delete_all_subwindows now takes a
5812 Lisp_Object as argument.
5814 * indent.c (compute_motion, Fcompute_motion):
5815 Use window_body_cols instead of window_box_text_cols.
5817 * frame.c (delete_frame): Call delete_all_subwindows with root
5820 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5822 * fns.c (Fputhash): Document return value.
5824 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5826 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5828 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5830 Cons<->int and similar integer overflow fixes (Bug#8794).
5832 Check for overflow when converting integer to cons and back.
5833 * charset.c (Fdefine_charset_internal, Fdecode_char):
5834 Use cons_to_unsigned to catch overflow.
5835 (Fencode_char): Use INTEGER_TO_CONS.
5836 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5837 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5838 * data.c (long_to_cons, cons_to_long): Remove.
5839 (cons_to_unsigned, cons_to_signed): New functions.
5840 These signal an error for invalid or out-of-range values.
5841 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5842 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5843 * font.c (Ffont_variation_glyphs):
5844 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5845 * lisp.h: Include <intprops.h>.
5846 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5847 (cons_to_signed, cons_to_unsigned): New decls.
5848 (long_to_cons, cons_to_long): Remove decls.
5849 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5850 (Fprimitive_undo): Use CONS_TO_INTEGER.
5851 * xfns.c (Fx_window_property): Likewise.
5852 * xselect.c: Include <limits.h>.
5853 (x_own_selection, selection_data_to_lisp_data):
5854 Use INTEGER_TO_CONS.
5855 (x_handle_selection_request, x_handle_selection_clear)
5856 (x_get_foreign_selection, Fx_disown_selection_internal)
5857 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5858 (lisp_data_to_selection_data): Use cons_to_unsigned.
5859 (x_fill_property_data): Use cons_to_signed.
5860 Report values out of range.
5862 Check for buffer and string overflow more precisely.
5863 * buffer.h (BUF_BYTES_MAX): New macro.
5864 * lisp.h (STRING_BYTES_MAX): New macro.
5865 * alloc.c (Fmake_string):
5866 * character.c (string_escape_byte8):
5867 * coding.c (coding_alloc_by_realloc):
5868 * doprnt.c (doprnt):
5869 * editfns.c (Fformat):
5871 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5872 since they may not be the same number.
5873 * editfns.c (Finsert_char):
5874 * fileio.c (Finsert_file_contents):
5875 Likewise for BUF_BYTES_MAX.
5877 * image.c: Use ptrdiff_t, not int, for sizes.
5878 (slurp_file): Switch from int to ptrdiff_t.
5880 (slurp_file): Check that file size fits in both size_t (for
5881 malloc) and ptrdiff_t (for sanity and safety).
5883 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5884 if b->modtime has its maximal value.
5886 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5888 Don't assume time_t can fit into int.
5889 * buffer.h (struct buffer.modtime): Now time_t, not int.
5890 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5891 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5893 Minor fixes for signed vs unsigned integers.
5894 * character.h (MAYBE_UNIFY_CHAR):
5895 * charset.c (maybe_unify_char):
5896 * keyboard.c (read_char, reorder_modifiers):
5897 XINT -> XFASTINT, since the integer must be nonnegative.
5898 * ftfont.c (ftfont_spec_pattern):
5899 * keymap.c (access_keymap, silly_event_symbol_error):
5900 XUINT -> XFASTINT, since the integer must be nonnegative.
5901 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5902 since it makes no difference and we prefer signed.
5903 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5904 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5907 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5909 * window.h (Fwindow_frame): Declare.
5911 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5913 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5914 (SPARE_MEMORY): Always define.
5915 (LARGE_REQUEST): Remove.
5916 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5918 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5920 * lisp.h: Move EXFUNS for Fframe_root_window,
5921 Fframe_first_window and Fset_frame_selected_window to window.h.
5923 * window.h: Move EXFUNS for Fframe_root_window,
5924 Fframe_first_window and Fset_frame_selected_window here from
5927 * frame.c (Fwindow_frame, Fframe_first_window)
5928 (Fframe_root_window, Fframe_selected_window)
5929 (Fset_frame_selected_window): Move to window.c.
5930 (Factive_minibuffer_window): Move to minibuf.c.
5931 (Fother_visible_frames_p): New function.
5933 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5935 * window.c (decode_window, decode_any_window): Move up in code.
5936 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5937 (inhibit_frame_unsplittable): Remove unused variable.
5938 (Fwindow_buffer): Move up and rewrite doc-string.
5939 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5940 (Fwindow_prev): New functions.
5941 (Fwindow_frame): Move here from frame.c. Accept any window as
5943 (Fframe_root_window, Fframe_first_window)
5944 (Fframe_selected_window): Move here from frame.c. Accept frame
5945 or arbitrary window as argument. Update doc-strings.
5946 (Fminibuffer_window): Move up in code.
5947 (Fwindow_minibuffer_p): Move up in code and simplify.
5948 (Fset_frame_selected_window): Move here from frame.c.
5950 (Fselected_window, select_window, Fselect_window): Move up in
5951 code. Minor doc-string fixes.
5953 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5955 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5956 Do not assume that spare memory exists; that assumption is valid
5957 only if SYSTEM_MALLOC.
5958 (LARGE_REQUEST): New macro, so that the issue of large requests
5959 is separated from the issue of spare memory.
5961 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5963 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5966 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5968 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5971 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5973 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5975 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5977 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5978 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5980 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5982 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5984 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5986 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5987 (x_clipboard_manager_save): Add return value.
5988 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5990 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5991 Obey Vx_select_enable_clipboard_manager. Catch errors in
5992 x_clipboard_manager_save (Bug#8779).
5993 (Vx_select_enable_clipboard_manager): New variable.
5994 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5996 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5998 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6000 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6002 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6003 in the current matrix if keep_current_p is non-zero.
6005 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6007 * bidi.c (bidi_level_of_next_char): Fix last change.
6009 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6011 Support bidi reordering of text covered by display properties.
6013 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6014 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6015 (bidi_cache_search, bidi_cache_iterator_state)
6016 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6017 (bidi_level_of_next_char, bidi_move_to_visually_next):
6018 Support character positions inside a run of characters covered by a
6020 (bidi_paragraph_init, bidi_resolve_explicit_1)
6021 (bidi_level_of_next_char): Call bidi_fetch_char and
6022 bidi_fetch_char_advance instead of FETCH_CHAR and
6024 (bidi_init_it): Initialize new members.
6025 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6027 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6028 instead of using explicit *_CHAR codes.
6029 (bidi_resolve_explicit, bidi_resolve_weak):
6030 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6031 bidirectional text is supported only in multibyte buffers.
6032 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6033 it to initialize the frame_window_p member of struct bidi_it.
6034 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6035 (bidi_resolve_explicit, bidi_resolve_weak)
6036 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6037 bidi_it->nchars is non-positive.
6038 (bidi_level_of_next_char): Don't try to lookup the cache for the
6039 next/previous character if nothing is cached there yet, or if we
6040 were just reseat()'ed to a new position.
6042 * xdisp.c (set_cursor_from_row): Set start and stop points
6043 according to the row's direction when priming the loop that looks
6044 for the glyph on which to display cursor.
6045 (single_display_spec_intangible_p): Function deleted.
6046 (display_prop_intangible_p): Reimplement to call
6047 handle_display_spec instead of single_display_spec_intangible_p.
6048 Accept 3 additional arguments needed by handle_display_spec.
6049 This fixes incorrect cursor motion across display property with complex
6050 values: lists, `(when COND...)' forms, etc.
6051 (single_display_spec_string_p): Support property values that are
6052 lists with the argument STRING its top-level element.
6053 (display_prop_string_p): Fix the condition for processing a
6054 property that is a list to be consistent with handle_display_spec.
6055 (handle_display_spec): New function, refactored from the
6056 last portion of handle_display_prop.
6057 (compute_display_string_pos): Accept additional argument
6058 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6059 value of a `display' property is a "replacing spec".
6060 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6061 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6062 the display property, but just return a value indicating whether
6063 the display property will replace the characters it covers.
6064 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6065 frame_window_p members of struct bidi_it.
6066 (compute_display_string_pos, compute_display_string_end):
6068 (push_it): Accept second argument POSITION, where pop_it should
6069 jump to continue iteration.
6070 (reseat_1): Initialize bidi_it.disp_pos.
6072 * keyboard.c (adjust_point_for_property): Adjust the call to
6073 display_prop_intangible_p to its new signature.
6075 * dispextern.h (struct bidi_it): New member frame_window_p.
6076 (bidi_init_it): Update prototypes.
6077 (display_prop_intangible_p): Update prototype.
6078 (compute_display_string_pos, compute_display_string_end):
6080 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6083 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6085 Malloc failure behavior now depends on size of allocation.
6086 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6087 * lisp.h: Change signatures accordingly.
6088 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6089 All callers changed. (Bug#8762)
6091 * gnutls.c: Use Emacs's memory allocators.
6092 Without this change, the gnutls library would invoke malloc etc.
6093 directly, which causes problems on non-SYNC_INPUT hosts, and which
6094 runs afoul of improving memory_full behavior. (Bug#8761)
6095 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6096 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6097 xfree instead of the default malloc, realloc, free.
6098 (Fgnutls_boot): No need to check for memory allocation failure,
6099 since xmalloc does that for us.
6101 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6102 * category.c (hash_get_category_set):
6103 * ccl.c (ccl_driver):
6104 * charset.c (Fdefine_charset_internal):
6105 * charset.h (struct charset.hash_index):
6106 * composite.c (get_composition_id, gstring_lookup_cache)
6107 (composition_gstring_put_cache):
6108 * composite.h (struct composition.hash_index):
6109 * dispextern.h (struct image.hash):
6110 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6111 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6112 (hashfn_equal, hashfn_user_defined, make_hash_table)
6113 (maybe_resize_hash_table, hash_lookup, hash_put)
6114 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6115 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6116 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6117 * image.c (make_image, search_image_cache, lookup_image)
6118 (xpm_put_color_table_h):
6119 * lisp.h (struct Lisp_Hash_Table):
6120 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6121 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6122 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6123 * alloc.c (allocate_vectorlike):
6124 Check for overflow in vector size calculations.
6125 * ccl.c (ccl_driver):
6126 Check for overflow when converting EMACS_INT to int.
6127 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6128 need to be updated by these changes.
6129 * fns.c (make_hash_table, maybe_resize_hash_table):
6130 Check for integer overflow with large hash tables.
6131 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6132 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6133 (SXHASH_REDUCE): New macro.
6134 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6135 Use it instead of discarding useful hash info with large hash values.
6136 (sxhash_float): New function.
6137 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6138 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6139 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6140 Rewrite to use FIXNUM_BITS, as this simplifies things.
6141 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6142 Adjust signatures to match updated version of code.
6143 (consing_since_gc): Now EMACS_INT, since a single hash table can
6144 use more than INT_MAX bytes.
6146 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6148 Make it possible to build with GCC-4.6+ -O2 -flto.
6150 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6152 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6154 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6155 Call minibuffer-inactive-mode.
6157 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6159 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6160 Update dependencies.
6162 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6164 * data.c (init_data): Remove code for UTS, this system is not
6167 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6169 Don't force ./temacs to start in terminal mode.
6171 * frame.c (make_initial_frame): Initialize faces in all cases, not
6172 only when CANNOT_DUMP is defined.
6173 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6175 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6177 * dispnew.c (add_window_display_history): Use const for the string
6178 pointer. Remove declaration, not needed.
6180 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6182 Use 'inline', not 'INLINE'.
6183 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6184 * alloc.c, fontset.c (INLINE): Remove.
6185 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6186 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6187 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6188 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6189 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6191 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6193 Make it possible to run ./temacs.
6195 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6196 syms_of_callproc does the same thing. Remove test for
6197 "initialized", do it in the caller.
6198 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6200 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6202 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6203 (read_minibuf): Use get_minibuffer.
6204 (syms_of_minibuf): Use DEFSYM.
6205 (Qmetadata): New var.
6206 * data.c (Qbuffer): Don't make it static.
6207 (syms_of_data): Use DEFSYM.
6209 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6211 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6212 (CCL_CODE_MIN): New macro.
6214 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6216 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6218 * eval.c (Qdebug): Now static.
6219 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6220 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6221 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6223 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6225 * image.c: Various fixes to ImageMagick code comments.
6226 (Fimagemagick_types): Doc fix.
6228 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6230 Minor fixes prompted by GCC 4.6.0 warnings.
6232 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6234 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6235 (x_clipboard_manager_save_all): Move extern decl to ...
6236 * xterm.h: ... here, so that it can be checked for consistency.
6238 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6240 * xselect.c (x_clipboard_manager_save_frame)
6241 (x_clipboard_manager_save_all): New functions.
6242 (Fx_clipboard_manager_save): Lisp function deleted.
6244 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6245 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6247 * xterm.h: Update prototype.
6249 2011-05-28 William Xu <william.xwl@gmail.com>
6251 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6254 2011-05-28 Jim Meyering <meyering@redhat.com>
6256 Avoid a sign-extension bug in crypto_hash_function.
6257 * fns.c (to_uchar): Define.
6258 (crypto_hash_function): Use it to convert some newly-signed
6259 variables to unsigned, to avoid sign-extension bugs. For example,
6260 without this change, (md5 "truc") would evaluate to
6261 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6262 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6263 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6265 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6267 Integer overflow fixes.
6269 * dbusbind.c: Serial number integer overflow fixes.
6270 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6271 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6272 to hold a serial number that is too large for a fixnum.
6273 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6274 Check for serial numbers out of range. Decode any serial number
6275 that was so large that it became a float. (Bug#8722)
6277 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6278 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6279 Use XFASTINT rather than XUINT when numbers are nonnegative.
6280 (xd_append_arg, Fdbus_method_return_internal):
6281 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6282 arguments, check that Lisp number is nonnegative, rather than
6283 silently wrapping negative numbers around. (Bug#8722)
6284 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6287 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6289 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6291 ccl: Add integer overflow checks.
6292 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6293 (IN_INT_RANGE): New macros.
6294 (ccl_driver): Use them to check for integer overflow when
6295 decoding a CCL program. Many of the new checks are whether XINT (x)
6296 fits in int; it doesn't always, on 64-bit hosts. The new version
6297 doesn't catch all possible integer overflows, but it's an
6298 improvement. (Bug#8719)
6300 * alloc.c (make_event_array): Use XINT, not XUINT.
6301 There's no need for unsigned here.
6303 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6304 This follows up to the 2011-05-06 change that substituted uintptr_t
6305 for EMACS_INT. This case wasn't caught back then.
6307 Rework Fformat to avoid integer overflow issues.
6308 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6309 now (part of C89). Include <verify.h>.
6310 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6311 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6312 (Fformat): Avoid the prepass trying to compute sizes; it was only
6313 approximate and thus did not catch overflow reliably. Instead, walk
6314 through the format just once, formatting and computing sizes as we go,
6315 checking for integer overflow at every step, and allocating a larger
6316 buffer as needed. Keep track separately whether the format is
6317 multibyte. Keep only the most-recently calculated precision, rather
6318 than them all. Record whether each argument has been converted to
6319 string. Use EMACS_INT, not int, for byte and char and arg counts.
6320 Support field widths and precisions larger than INT_MAX. Avoid
6321 sprintf's undefined behavior with conversion specifications such as %#d
6322 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6323 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6324 formatting out-of-range floating point numbers with int
6327 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6329 * data.c: Avoid integer truncation in expressions involving floats.
6330 * data.c: Include <intprops.h>.
6331 (arith_driver): When there's an integer overflow in an expression
6332 involving floating point, convert the integers to floating point
6333 so that the resulting value does not suffer from catastrophic
6334 integer truncation. For example, on a 64-bit host (* 4
6335 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6336 Do not rely on undefined behavior after integer overflow.
6338 merge count_size_as_multibyte, parse_str_to_multibyte
6339 * character.c, character.h (count_size_as_multibyte):
6340 Rename from parse_str_to_multibyte; all uses changed.
6341 Check for integer overflow.
6342 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6343 since it's now a duplicate of the other. This is more of
6344 a character than a buffer op, so better that it's in character.c.
6345 * fns.c, print.c: Adjust to above changes.
6347 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6349 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6351 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6353 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6354 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6355 (x_clipboard_manager_save): Now static.
6356 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6358 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6359 (crypto_hash_function): Now static.
6360 Fix pointer signedness problems. Avoid unnecessary initializations.
6362 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6364 * termhooks.h (Vselection_alist): Make it terminal-local.
6366 * terminal.c (create_terminal): Initialize it.
6368 * xselect.c: Support for clipboard managers.
6369 (Vselection_alist): Move to termhooks.h as terminal-local var.
6370 (LOCAL_SELECTION): New macro.
6371 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6372 (symbol_to_x_atom): Remove gratuitous arg.
6373 (x_handle_selection_request, lisp_data_to_selection_data)
6374 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6375 (x_own_selection, x_get_local_selection, x_convert_selection):
6376 New arg, specifying work frame. Use terminal-local Vselection_alist.
6377 (some_frame_on_display): Delete unused function.
6378 (Fx_own_selection_internal, Fx_get_selection_internal)
6379 (Fx_disown_selection_internal, Fx_selection_owner_p)
6380 (Fx_selection_exists_p): New optional frame arg.
6381 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6382 (x_handle_selection_clear): Don't treat other terminals with the
6383 same keyboard specially. Use the terminal-local Vselection_alist.
6384 (x_clear_frame_selections): Use Frun_hook_with_args.
6386 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6388 * xterm.h: Add support for those atoms.
6390 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6392 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6393 (converted_selections, conversion_fail_tag): New global variables.
6394 (x_selection_request_lisp_error): Free the above.
6395 (x_get_local_selection): Remove unnecessary code.
6396 (x_reply_selection_request): Args changed; handle arbitrary array
6397 of converted selections stored in converted_selections.
6398 Separate the XChangeProperty and SelectionNotify steps.
6399 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6400 (x_convert_selection): New function.
6401 (x_handle_selection_event): Simplify.
6402 (x_get_foreign_selection): Don't ignore incoming requests while
6403 waiting for an answer; this will fail when we implement
6404 SAVE_TARGETS, and seems unnecessary anyway.
6405 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6406 (Vx_sent_selection_functions): Doc fix.
6408 2011-05-26 Leo Liu <sdl.web@gmail.com>
6410 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6412 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6414 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6416 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6417 for fringe update if it has periodic bitmap.
6418 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6419 and fringe_bitmap_periodic_p.
6421 * fringe.c (get_fringe_bitmap_data): New function.
6422 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6423 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6424 row. Mark glyph row for fringe update if periodicity changed.
6426 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6427 for fringe update unless it has periodic bitmap.
6429 2011-05-25 Kenichi Handa <handa@m17n.org>
6431 * xdisp.c (get_next_display_element): Set correct it->face_id for
6432 a static composition.
6434 2011-05-24 Leo Liu <sdl.web@gmail.com>
6437 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6439 * fns.c (crypto_hash_function, Fsha1): New function.
6440 (Fmd5): Use crypto_hash_function.
6441 (syms_of_fns): Add Ssha1.
6443 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6445 * gnutls.c: Remove unused macros.
6446 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6447 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6448 Remove macros that are defined and never used.
6449 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6451 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6453 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6454 (Fx_get_selection_internal): Minor cleanup.
6455 (Fx_own_selection_internal): Rename arguments for consistency with
6458 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6460 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6462 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6464 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6466 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6468 * dispnew.c (scrolling_window): Don't exclude the case that the
6469 last enabled row in the desired matrix touches the bottom boundary.
6471 2011-05-21 Glenn Morris <rgm@gnu.org>
6473 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6474 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6475 and add some more files.
6477 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6479 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6480 report_file_error introduced by the change from 2011-05-07.
6482 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6484 * systime.h (Time): Define only if emacs is defined.
6485 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6486 where the include path doesn't have X11/X.h by default. See
6487 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6489 2011-05-20 Kenichi Handa <handa@m17n.org>
6491 * composite.c (find_automatic_composition): Fix previous change.
6493 2011-05-20 Glenn Morris <rgm@gnu.org>
6495 * lisp.mk: New file, split from Makefile.in.
6496 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6497 (shortlisp): Remove.
6498 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6500 2011-05-19 Glenn Morris <rgm@gnu.org>
6502 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6503 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6504 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6505 (lisp): Set the order to that of loadup.el.
6506 (shortlisp): Make it a copy of $lisp.
6507 (SOME_MACHINE_LISP): Remove.
6508 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6509 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6511 2011-05-18 Kenichi Handa <handa@m17n.org>
6513 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6514 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6515 (find_automatic_composition): Mostly rewrite for efficiency.
6517 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6519 * makefile.w32-in: Update dependencies.
6521 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6523 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6524 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6526 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6528 Fix some integer overflow issues, such as string length overflow.
6530 * insdel.c (count_size_as_multibyte): Check for string overflow.
6532 * character.c (lisp_string_width): Check for string overflow.
6533 Use EMACS_INT, not int, for string indexes and lengths; in
6534 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6535 the resulting string length overflows an EMACS_INT; instead,
6536 report a string overflow if no precision given. When checking for
6537 precision exhaustion, use a check that cannot possibly have
6538 integer overflow. (Bug#8675)
6539 * character.h (lisp_string_width): Adjust to new signature.
6541 * alloc.c (string_overflow): New function.
6542 (Fmake_string): Use it. This doesn't change behavior, but saves
6543 a few bytes and will simplify future changes.
6544 * character.c (string_escape_byte8): Likewise.
6545 * lisp.h (string_overflow): New decl.
6547 Fixups, following up to the user-interface timestamp change.
6548 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6549 for UI timestamps, instead of unsigned long.
6550 * msdos.c (mouse_get_pos): Likewise.
6551 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6552 * w32gui.h (Time): Define by including "systime.h" rather than by
6553 declaring it ourselves. (Bug#8664)
6555 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6556 * image.c (clear_image_cache): Likewise.
6558 * term.c (term_mouse_position): Don't assume time_t wraparound.
6560 Be more systematic about user-interface timestamps.
6561 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6562 and sometimes 'EMACS_UINT', to represent these timestamps.
6563 This change causes it to use 'Time' uniformly, as that's what X uses.
6564 This makes the code easier to follow, and makes it easier to catch
6565 integer overflow bugs such as Bug#8664.
6566 * frame.c (Fmouse_position, Fmouse_pixel_position):
6567 Use Time, not unsigned long, for user-interface timestamps.
6568 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6569 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6570 * keyboard.h (last_event_timestamp): Likewise.
6571 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6572 * menu.h (xmenu_show): Likewise.
6573 * term.c (term_mouse_position): Likewise.
6574 * termhooks.h (struct input_event.timestamp): Likewise.
6575 (struct terminal.mouse_position_hook): Likewise.
6576 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6577 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6578 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6579 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6581 * menu.h, termhooks.h: Include "systime.h", for Time.
6583 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6584 Don't assume that the difference between two unsigned long values
6585 can fit into an integer. At this point, we know button_down_time
6586 <= event->timestamp, so the difference must be nonnegative, so
6587 there's no need to cast the result if double-click-time is
6588 nonnegative, as it should be; check that it's nonnegative, just in
6589 case. This bug is triggered when events are more than 2**31 ms
6590 apart (about 25 days). (Bug#8664)
6592 * xselect.c (last_event_timestamp): Remove duplicate decl.
6593 (x_own_selection): Remove needless cast to unsigned long.
6595 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6596 that always fit in int. Use a sentinel instead of a counter, to
6597 avoid a temp and to allay GCC's concerns about possible int overflow.
6598 * frame.h (struct frame): Use int for menu_bar_items_used
6599 instead of EMACS_INT, since it always fits in int.
6601 * menu.c (grow_menu_items): Check for int overflow.
6603 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6605 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6606 Before, the code was not consistent. These values cannot exceed
6607 2**31 - 1 so there's no need to make them unsigned.
6608 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6609 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6610 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6612 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6614 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6615 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6616 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6617 presumably because the widths might not match.
6619 * window.c (size_window): Avoid needless test at loop start.
6621 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6623 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6625 2011-05-12 Drew Adams <drew.adams@oracle.com>
6627 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6629 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6631 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6632 `width' to `bar_area_x' and `bar_area_width', respectively.
6633 (x_scroll_run): Take account of fringe background extension.
6635 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6636 Rename local vars `left' and `width' to `bar_area_x' and
6637 `bar_area_width', respectively.
6638 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6639 background extension.
6641 2011-05-10 Jim Meyering <meyering@redhat.com>
6643 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6645 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6647 * image.c (Finit_image_library): Return t for built-in image types,
6648 like pbm and xbm. (Bug#8640)
6650 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6652 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6654 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6656 * w32console.c (Fset_screen_color): Doc fix.
6657 (Fget_screen_color): New function.
6658 (syms_of_ntterm): Defsubr it.
6660 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6661 unlink the temporary file if Fcall_process didn't create it in the
6663 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6664 child process will be redirected to a file specified with `:file'.
6665 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6666 cue to call_process_cleanup not to close that handle.
6668 2011-05-07 Ben Key <bkey76@gmail.com>
6670 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6671 one of two shell specific rules, either bootstrap-temacs-CMD or
6672 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6673 to the previous implementation of the bootstrap-temacs rule.
6674 The bootstrap-temacs-CMD rule is similar to the previous
6675 implementation of the bootstrap-temacs rule except that it
6676 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6679 These changes, along with some changes to nt/configure.bat,
6680 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6681 earlier fix to add support for --cflags and --ldflags options
6682 that include quotes so that it works whether make uses cmd or
6685 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6687 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6688 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6690 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6691 a string. Handle both cases.
6692 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6693 (Fdbus_register_method): Use Qinvalid_function.
6695 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6697 * makefile.w32-in: Update dependencies.
6698 (LISP_H): Add inttypes.h and stdin.h.
6699 (PROCESS_H): Add unistd.h.
6701 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6703 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6704 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6706 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6708 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6710 * term.c (vfatal): Remove stray call to va_end.
6711 It's not needed and the C Standard doesn't allow it here anyway.
6713 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6714 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6716 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6719 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6721 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6723 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6725 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6727 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6729 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6730 * charset.c (Fdefine_charset_internal): Don't initialize
6731 charset.code_space[15]. The value was garbage, on hosts with
6732 32-bit int (Bug#8600).
6734 * lread.c (read_integer): Be more consistent with string-to-number.
6735 Use string_to_number to do the actual conversion; this avoids
6736 rounding errors and fixes some other screwups. Without this fix,
6737 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6738 (digit_to_number): Move earlier, for benefit of read_integer.
6739 Return -1 if the digit is out of range for the base, -2 if it is
6740 not a digit in any supported base. (Bug#8602)
6742 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6744 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6745 to match comment at start of function. This also removes a
6746 GCC warning about overflow in a 32+64-bit port.
6748 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6750 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6751 Reported by Stefan Monnier in
6752 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6753 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6754 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6756 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6757 (EMACS_UINTPTR): Likewise, with uintptr_t.
6759 * lisp.h: Prefer 64-bit EMACS_INT if available.
6760 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6761 on 32-bit hosts that have 64-bit int, so that they can access
6763 However, temporarily disable this change unless the temporary
6764 symbol WIDE_EMACS_INT is defined.
6766 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6768 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6769 This removes an assumption that EMACS_INT and long are the same
6770 width as pointers. The assumption is true for Emacs porting targets
6771 now, but we want to make other targets possible.
6772 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6773 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6774 In the rest of the code, change types of integers that hold casted
6775 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6776 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6777 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6778 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6779 No need to cast type when ORing.
6780 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6781 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6782 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6783 assume EMACS_INT is the same width as char *.
6784 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6785 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6786 Remove no-longer-needed casts.
6787 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6788 (xg_tool_bar_help_callback, xg_make_tool_item):
6789 Use EMACS_INTPTR to hold an integer
6790 that will be cast to void *; this can avoid a GCC warning
6791 if EMACS_INT is not the same width as void *.
6792 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6793 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6794 (current_message_1, set_message_1):
6795 Use a local to convert to proper width without a cast.
6796 * xmenu.c (dialog_selection_callback): Likewise.
6798 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6799 Also, don't assume VALBITS / RAND_BITS is less than 5,
6800 and don't rely on undefined behavior when shifting a 1 left into
6802 * lisp.h (get_random): Change signature to match.
6804 * lread.c (hash_string): Use size_t, not int, for hash computation.
6805 Normally we prefer signed values; but hashing is special, because
6806 it's better to use unsigned division on hash table sizes so that
6807 the remainder is nonnegative. Also, size_t is the natural width
6808 for hashing into memory. The previous code used 'int', which doesn't
6809 retain enough info to hash well into very large tables.
6810 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6812 * dbusbind.c: Don't possibly lose pointer info when converting.
6813 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6814 Use XPNTR rather than XHASH, so that the high-order bits of
6815 the pointer aren't lost when converting through void *.
6817 * eval.c (Fautoload): Don't double-shift a pointer.
6819 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6821 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6823 * gnutls.c (DEF_GNUTLS_FN):
6824 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6826 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6828 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6831 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6833 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6834 New version that can reserve upto 2GB of heap space.
6836 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6838 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6840 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6842 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6843 `gnutls_certificate_set_x509_key_file'.
6845 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6847 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6848 Update dependencies.
6850 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6852 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6853 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6854 Remove unused parameter `fildes'.
6855 * process.c (read_process_output, send_process): Don't pass it.
6857 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6859 Fix previous change: the library cache is defined in w32.c.
6860 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6861 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6863 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6865 Implement dynamic loading of GnuTLS on Windows.
6867 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6868 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6869 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6872 * gnutls.c (Qgnutls_dll): Define.
6873 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6874 (gnutls_*): Declare function pointers.
6875 (init_gnutls_functions): New function to initialize function pointers.
6876 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6877 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6878 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6879 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6880 (emacs_gnutls_write, emacs_gnutls_read)
6881 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6882 (Fgnutls_available_p): New function.
6883 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6884 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6885 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6887 * image.c: Include w32.h.
6888 (Vimage_type_cache): Delete.
6889 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6890 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6891 (w32_delayed_load): Move to w32.c.
6893 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6895 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6896 (w32_delayed_load): Move from image.c. When loading a library, record
6897 its filename in the :loaded-from property of the library id.
6898 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6899 Initialize and staticpro them.
6900 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6902 * process.c: Include lisp.h before w32.h, not after.
6903 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6904 instead of gnutls_record_check_pending.
6906 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6908 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6910 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6911 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6914 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6916 * xterm.c (x_set_frame_alpha): Do not set property on anything
6917 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6919 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6921 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6923 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6925 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6926 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6927 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6928 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6929 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6930 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6931 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6932 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6933 (Qgnutls_bootprop_callbacks_verify): Make static.
6935 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6937 * callproc.c: Indentation fixup.
6939 * sysdep.c (wait_for_termination_1): Make static.
6940 (wait_for_termination, interruptible_wait_for_termination):
6941 Move after wait_for_termination_1.
6943 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6945 * sysdep.c (interruptible_wait_for_termination): New function
6946 which is like wait_for_termination, but allows keyboard
6949 * callproc.c (Fcall_process): Add (:file "file") as an option for
6951 (Fcall_process_region): Ditto.
6953 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6955 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6956 rather than `XVECTOR (FOO)->size'.
6958 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6959 inttypes.h, as a gnulib replacement is used if it not available in
6962 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6964 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6965 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6966 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6968 * coding.c (coding_alloc_by_realloc): Error out if destination
6969 will grow beyond MOST_POSITIVE_FIXNUM.
6970 (decode_coding_emacs_mule): Abort if there isn't enough place in
6971 charbuf for the composition carryover bytes. Reserve an extra
6972 space for up to 2 characters produced in a loop.
6973 (decode_coding_iso_2022): Abort if there isn't enough place in
6974 charbuf for the composition carryover bytes.
6976 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6978 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6979 aborting when %lld or %lll format is passed.
6980 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6981 %llo or %llx format is passed. (Bug#8545)
6983 * window.c (window_scroll_line_based): Use a marker instead of
6984 simple variables to record original value of point. (Bug#7952)
6986 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6987 produced by %s or %c overflows available buffer space. (Bug#8545)
6989 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6991 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6992 (SIZE_MAX): Move defn after all includes, as they might #define it.
6994 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6996 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6998 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7000 * keyboard.c (Qdelayed_warnings_hook): Define.
7001 (command_loop_1): Run `delayed-warnings-hook'
7002 if Vdelayed_warnings_list is non-nil.
7003 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7004 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7006 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7008 * doprnt.c (doprnt): Don't return value smaller than the buffer
7009 size if the message was truncated. (Bug#8545).
7011 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7013 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7014 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7016 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7018 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7020 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7022 * makefile.w32-in: Update dependencies.
7024 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7026 Improve `doprnt' and its usage. (Bug#8545)
7027 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7028 `format_end'. Remove support for %l as a conversion specifier.
7029 Don't use xrealloc. Improve diagnostics when the %l size modifier
7030 is used. Update the commentary.
7032 * eval.c (verror): Simplify calculation of size_t.
7034 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7037 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7039 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7042 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7044 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7045 This makes this file independent of the recent pseudovector change.
7047 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7049 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7051 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7052 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7053 Remove unused local.
7054 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7056 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7057 GCC 4.6.0 optimizes based on type-based alias analysis.
7058 For example, if b is of type struct buffer * and v of type struct
7059 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7060 != &v->size, and therefore "v->size = 1; b->size = 2; return
7061 v->size;" must therefore return 1. This assumption is incorrect
7062 for Emacs, since it type-puns struct Lisp_Vector * with many other
7063 types. To fix this problem, this patch adds a new type struct
7064 vectorlike_header that documents the constraints on layout of vectors
7065 and pseudovectors, and helps optimizing compilers not get fooled
7066 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7067 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7068 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7070 (XSETPVECTYPE): Rewrite in terms of new macro.
7071 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7072 This is a bit clearer, and further avoids the possibility of
7073 undesirable aliasing.
7074 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7075 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7076 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7077 since Lisp_Subr is a special case (no "next" field).
7078 (ASIZE): Now uses header.size rather than size.
7079 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7080 to avoid the hassle of writing XVECTOR (foo)->header.size.
7081 (struct vectorlike_header): New type.
7082 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7083 object, to help avoid aliasing.
7084 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7085 (SUBRP): Likewise, since Lisp_Subr is a special case.
7086 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7087 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7088 (struct Lisp_Hash_Table): Combine first two members into a single
7089 struct vectorlike_header member. All uses of "size" and "next" members
7090 changed to be "header.size" and "header.next".
7091 * buffer.h (struct buffer): Likewise.
7092 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7093 * frame.h (struct frame): Likewise.
7094 * process.h (struct Lisp_Process): Likewise.
7095 * termhooks.h (struct terminal): Likewise.
7096 * window.c (struct save_window_data, struct saved_window): Likewise.
7097 * window.h (struct window): Likewise.
7098 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7099 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7100 * buffer.c (init_buffer_once): Likewise.
7101 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7103 * process.c (Fformat_network_address): Use local var for size,
7106 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7108 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7109 * data.c (atof): Remove decl; no longer used or needed.
7110 (digit_to_number): Move to lread.c.
7111 (Fstring_to_number): Use new string_to_number function, to be
7112 consistent with how the Lisp reader treats infinities and NaNs.
7113 Do not assume that floating-point numbers represent EMACS_INT
7114 without losing information; this is not true on most 64-bit hosts.
7115 Avoid double-rounding errors, by insisting on integers when
7116 parsing non-base-10 numbers, as the documentation specifies.
7117 * lisp.h (string_to_number): New decl, replacing ...
7118 (isfloat_string): Remove.
7119 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7120 (read1): Do not accept +. and -. as integers; this
7121 appears to have been a coding error. Similarly, do not accept
7122 strings like +-1e0 as floating point numbers. Do not report
7123 overflow for integer overflows unless the base is not 10 which
7124 means we have no simple and reliable way to continue.
7125 Break out the floating-point parsing into a new
7126 function string_to_number, so that Fstring_to_number parses
7127 floating point numbers consistently with the Lisp reader.
7128 (digit_to_number): Move here from data.c. Make it static inline.
7129 (E_CHAR, EXP_INT): Remove, replacing with ...
7130 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7131 (string_to_number): New function, replacing isfloat_string.
7132 This function checks for valid syntax and produces the resulting
7133 Lisp float number too. Rework it so that string-to-number
7134 no longer mishandles examples like "1.0e+". Use strtoumax,
7135 so that overflow for non-base-10 numbers is reported only when
7136 there's no portable and simple way to convert to floating point.
7138 * textprop.c (set_text_properties_1): Rewrite for clarity,
7139 and to avoid GCC warning about integer overflow.
7141 * intervals.h (struct interval): Use EMACS_INT for members
7142 where EMACS_UINT might cause problems. See
7143 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7144 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7145 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7147 (offset_intervals): Tell GCC not to worry about length overflow
7148 when negating a negative length.
7150 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7151 (overrun_check_free): Likewise.
7153 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7154 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7157 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7158 (gnutls_make_error): Rename local to avoid shadowing.
7159 (gnutls_emacs_global_deinit): ifdef out; not used.
7160 (Fgnutls_boot): Use const for pointer to readonly storage.
7161 Comment out unused local. Fix pointer signedness problems.
7163 * lread.c (openp): Don't stuff size_t into an 'int'.
7164 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7165 about possible signed overflow.
7167 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7168 (GDK_KEY_g): Don't define if already defined.
7169 (xg_prepare_tooltip): Avoid pointer signedness problem.
7170 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7172 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7173 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7175 * xfns.c (Fx_window_property): Simplify a bit,
7176 to make a bit faster and to avoid GCC 4.6.0 warning.
7177 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7179 * fns.c (internal_equal): Don't assume size_t fits in int.
7181 * alloc.c (compact_small_strings): Tighten assertion a little.
7183 Replace pEd with more-general pI, and fix some printf arg casts.
7184 * lisp.h (pI): New macro, generalizing old pEd macro to other
7185 conversion specifiers. For example, use "...%"pI"d..." rather
7186 than "...%"pEd"...".
7187 (pEd): Remove. All uses replaced with similar uses of pI.
7188 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7189 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7190 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7191 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7192 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7193 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7194 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7196 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7197 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7198 * print.c (safe_debug_print, print_object): Likewise.
7199 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7201 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7202 avoiding the 0 flag, which is not portable.
7203 * process.c (Fmake_network_process): Use pI to avoid cast.
7204 * region-cache.c (pp_cache): Likewise.
7205 * xdisp.c (decode_mode_spec): Likewise.
7206 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7207 behavior on 64-bit hosts with printf arg.
7208 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7209 (x_stop_queuing_selection_requests): Likewise.
7210 (x_get_window_property): Don't truncate byte count to an 'int'
7213 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7214 here, since it parses constructs like leading '-' and spaces,
7215 which are not wanted; and it overflows with large numbers.
7216 Instead, simply match F[0-9]+, which is what is wanted anyway.
7218 * alloc.c: Remove unportable assumptions about struct layout.
7219 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7220 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7221 (allocate_vectorlike, make_pure_vector): Use the new macros,
7222 plus offsetof, to remove unportable assumptions about struct layout.
7223 These assumptions hold on all porting targets that I know of, but
7224 they are not guaranteed, they're easy to remove, and removing them
7225 makes further changes easier.
7227 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7228 This doesn't fix a bug but makes the code clearer.
7229 (string_overrun_cookie): Now const. Use initializers that
7230 don't formally overflow signed char, to avoid warnings.
7231 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7232 can cause Emacs to crash when string overrun checking is enabled.
7233 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7234 multiple of sizeof (EMACS_INT); it need not be, if
7235 alignof(EMACS_INT) < sizeof (EMACS_INT).
7236 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7238 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7240 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7242 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7244 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7245 supposed to be handshaking. (Bug#8556)
7246 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7248 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7250 * lisp.h (Qdebug): List symbol.
7251 * eval.c (Qdebug): Restore global linkage.
7252 * keyboard.c (debug-on-event): New variable.
7253 (handle_user_signal): Break into debugger when debug-on-event
7254 matches the current signal symbol.
7256 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7258 * alloc.c (check_sblock, check_string_bytes)
7259 (check_string_free_list): Convert to standard C.
7261 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7263 * w32.c (emacs_gnutls_push): Fix typo.
7265 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7267 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7268 "cast to pointer from integer of different size".
7270 Improve doprnt and its use in verror. (Bug#8545)
7271 * doprnt.c (doprnt): Document the set of format control sequences
7272 supported by the function. Use SAFE_ALLOCA instead of always
7275 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7276 is one byte too soon. Don't use xrealloc; instead xfree and
7279 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7281 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7284 * gnutls.c: Renamed global_initialized to
7285 gnutls_global_initialized. Added internals for the
7286 :verify-hostname-error, :verify-error, and :verify-flags
7287 parameters of `gnutls-boot' and documented those parameters in the
7288 docstring. Start callback support.
7289 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7290 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7291 on error. Return error code.
7292 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7293 (emacs_gnutls_read): Likewise.
7294 (Fgnutls_boot): Return handshake error code.
7295 (emacs_gnutls_handle_error): New function.
7296 (wsaerror_to_errno): Likewise.
7298 * w32.h (emacs_gnutls_pull): Add prototype.
7299 (emacs_gnutls_push): Likewise.
7301 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7302 (emacs_gnutls_push): Likewise.
7304 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7306 * process.c (wait_reading_process_output): Check if GnuTLS
7307 buffered some data internally if no FDs are set for TLS
7310 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7311 (LIBS): Link to USER_LIBS.
7312 ($(BLD)/gnutls.$(0)): New target.
7314 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7316 * xdisp.c (handle_single_display_spec): Rename the
7317 display_replaced_before_p argument into display_replaced_p, to
7318 make it consistent with the commentary. Fix typos in the
7321 * textprop.c (syms_of_textprop): Remove dead code.
7322 (copy_text_properties): Delete obsolete commentary about an
7323 interface that was deleted long ago. Fix typos in the description
7326 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7327 to changes in oldXMenu/XMenu.h from 2011-04-16.
7328 <menu_help_message, prev_menu_help_message>: Constify.
7329 (IT_menu_make_room): menu->help_text is now `const char **';
7332 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7333 to changes in oldXMenu/XMenu.h from 2011-04-16.
7334 (struct XMenu): Declare `help_text' `const char **'.
7336 * xfaces.c <Qunspecified>: Make extern again.
7338 * syntax.c: Include sys/types.h before including regex.h, as
7341 * doc.c (get_doc_string): Improve the format passed to `error'.
7343 * doprnt.c (doprnt): Improve commentary.
7345 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7347 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7350 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7351 changes in globals.h immediately force recompilation.
7352 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7353 $(CURDIR)/s/ms-w32.h.
7354 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7356 * character.c (Fchar_direction): Function deleted.
7357 (syms_of_character): Don't defsubr it.
7358 <char-direction-table>: Deleted.
7360 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7362 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7363 * doprnt.c: Include limits.h.
7364 (SIZE_MAX): New macro.
7365 (doprnt): Return a size_t value. 2nd arg is now size_t.
7366 Many local variables are now size_t instead of int or unsigned.
7367 Improve overflow protection. Support `l' modifier for integer
7368 conversions. Support %l conversion. Don't assume an EMACS_INT
7369 argument for integer conversions and for %c.
7371 * lisp.h (doprnt): Restore prototype.
7373 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7376 * Makefile.in (base_obj): Add back doprnt.o.
7378 * deps.mk (doprnt.o): Add back prerequisites.
7379 (callint.o): Depend on character.h.
7381 * eval.c (internal_lisp_condition_case): Include the handler
7382 representation in the error message.
7383 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7384 when breaking from the loop.
7386 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7388 * callint.c (Fcall_interactively): When displaying error message
7389 about invalid control letter, pass the character's codepoint, not
7390 a pointer to its multibyte form. Improve display of the character
7391 in octal and display also its hex code.
7393 * character.c (char_string): Use %x to display the (unsigned)
7394 codepoint of an invalid character, to avoid displaying a bogus
7397 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7398 `error', not SYMBOL_NAME itself.
7400 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7401 character arguments to `error'.
7403 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7404 to `error' in error message about FINAL_CHAR argument. Make sure
7405 FINAL_CHAR is a character, and use %c when it is passed as
7406 argument to `error'.
7408 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7410 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7412 * w32.c: Include <time.h>.
7413 (sys_localtime): New function.
7415 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7417 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7419 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7421 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7423 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7426 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7428 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7429 gl_state.e_property when gl_state.object is Qt.
7431 * insdel.c (make_gap_larger): Remove limitation of buffer size
7434 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7436 * xdisp.c (lookup_glyphless_char_display)
7437 (produce_glyphless_glyph): Handle cons cell entry in
7438 glyphless-char-display.
7439 (Vglyphless_char_display): Document it.
7441 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7442 glyphless-char-display.
7444 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7446 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7448 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7450 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7451 definition for no-X builds.
7453 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7455 Static checks with GCC 4.6.0 and non-default toolkits.
7457 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7459 * process.c (keyboard_bit_set): Define only if SIGIO.
7460 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7461 (send_process): Repair possible setjmp clobbering.
7463 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7465 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7467 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7469 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7470 Define only if needed.
7472 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7473 by pacifying GCC about it. Maybe it's time to retire it?
7474 * xfaces.c (USG, __TIMEVAL__): Likewise.
7476 * dispextern.h (struct redisplay_interface): Rename param
7478 * termhooks.h (struct terminal): Likewise.
7479 * xterm.c (xembed_send_message): Likewise.
7481 * insdel.c (make_gap_smaller): Define only if
7482 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7484 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7487 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7488 so that we aren't warned about unused symbols.
7490 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7492 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7494 * xfns.c (x_real_positions): Mark locals as initialized.
7496 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7498 * xterm.c: Fix problems found by static analysis with other toolkits.
7499 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7500 (x_dispatch_event): Declare static if USE_GTK, and
7501 define if USE_GTK || USE_X_TOOLKIT.
7502 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7503 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7504 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7505 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7507 * xmenu.c (menu_help_callback): Pointer type fixes.
7508 Use const pointers when pointing at readonly data. Avoid pointer
7510 (FALSE): Remove unused macro.
7511 (update_frame_menubar): Remove unused decl.
7513 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7515 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7516 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7517 (single_menu_item): Rename local to avoid shadowing.
7519 * keyboard.c (make_lispy_event): Remove unused local var.
7521 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7522 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7524 * bitmaps: Change bitmaps from unsigned char back to the X11
7525 compatible char. Avoid the old compiler warnings about
7526 out-of-range initializers by using, for example, '\xab' rather
7529 * xgselect.c (xgselect_initialize): Check vs interface
7530 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7532 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7534 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7535 to read-only memory.
7537 * fns.c (vector): Remove; this old hack is no longer needed.
7539 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7541 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7543 * xrdb.c (x_load_resources): Omit unused local.
7545 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7546 (x_window): Rename locals to avoid shadowing.
7547 (USG): Use the kludged USG macro, to pacify gcc.
7549 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7550 (x_term_init): Remove local to avoid shadowing.
7552 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7554 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7555 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7557 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7559 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7561 Fix regex.c, syntax.c and friends for buffers > 2GB.
7562 * syntax.h (struct gl_state_s): Declare character position members
7565 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7567 * textprop.c (verify_interval_modification, interval_of):
7568 Declare arguments EMACS_INT.
7570 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7573 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7575 * indent.c (Fvertical_motion): Local variable it_start is now
7578 * regex.c (re_match, re_match_2, re_match_2_internal)
7579 (bcmp_translate, regcomp, regexec, print_double_string)
7580 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7581 (re_compile_pattern, re_exec): Declare arguments and local
7582 variables `size_t' and `ssize_t' and return values `regoff_t', as
7584 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7585 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7586 <compile_stack_type>: `size' and `avail' are now `size_t'.
7588 * regex.h <regoff_t>: Use ssize_t, not int.
7589 (re_search, re_search_2, re_match, re_match_2): Arguments that
7590 specify buffer/string position and length are now ssize_t and
7591 size_t. Return type is regoff_t.
7593 2011-04-16 Ben Key <bkey76@gmail.com>
7595 * nsfont.m: Fixed bugs in ns_get_family and
7596 ns_descriptor_to_entity that were caused by using free to
7597 deallocate memory blocks that were allocated by xmalloc (via
7598 xstrdup). This caused Emacs to crash when compiled with
7599 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7600 --enable-checking=xmallocoverrun). xfree is now used to
7601 deallocate these memory blocks.
7603 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7605 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7607 emacs_write: Accept and return EMACS_INT for sizes.
7608 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7610 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7611 Accept and return EMACS_INT.
7612 (emacs_gnutls_write): Return the number of bytes written on
7614 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7615 (emacs_read, emacs_write): Remove check for negative size, as the
7616 Emacs source code has been audited now.
7617 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7618 (emacs_read, emacs_write): Use it.
7619 * process.c (send_process): Adjust to the new signatures of
7620 emacs_write and emacs_gnutls_write. Do not attempt to store
7621 a byte offset into an 'int'; it might overflow.
7622 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7624 * sound.c: Don't assume sizes fit in 'int'.
7625 (struct sound_device.period_size, alsa_period_size):
7626 Return EMACS_INT, not int.
7627 (struct sound_device.write, vox_write, alsa_write):
7628 Accept EMACS_INT, not int.
7629 (wav_play, au_play): Use EMACS_INT to store sizes and to
7630 record read return values.
7632 2011-04-15 Ben Key <bkey76@gmail.com>
7634 * keyboard.c (Qundefined): Don't declare static since it is used
7636 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7637 static since they are used in nsfont.m.
7639 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7641 * process.c (Qprocessp): Don't declare static.
7642 * lisp.h (Qprocessp): Declare again.
7644 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7646 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7648 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7650 Improve C-level modularity by making more things 'static'.
7652 Don't publish debugger-only interfaces to other modules.
7653 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7654 (verify_bytepos, count_markers): Move decls to the only modules
7656 * region-cache.h (pp_cache): Likewise.
7657 * window.h (check_all_windows): Likewise.
7658 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7660 * sysdep.c (croak): Now static, if
7661 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7662 * syssignal.h (croak): Declare only if not static.
7664 * alloc.c (refill_memory_reserve): Now static if
7665 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7666 * lisp.h (refill_memory_reserve): Declare only if not static.
7668 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7669 Define only if USE_LUCID.
7671 * xrdb.c (x_customization_string, x_rm_string): Now static.
7673 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7674 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7676 * xdisp.c (draw_row_with_mouse_face): Now static.
7677 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7679 * window.h (check_all_windows): Mark externally visible.
7681 * window.c (window_deletion_count): Now static.
7683 * undo.c: Make symbols static if they're not exported.
7684 (last_undo_buffer, last_boundary_position, pending_boundary):
7687 * textprop.c (interval_insert_behind_hooks): Now static.
7688 (interval_insert_in_front_hooks): Likewise.
7690 * term.c: Make symbols static if they're not exported.
7691 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7692 (max_frame_lines, tty_set_terminal_modes):
7693 (tty_reset_terminal_modes, tty_turn_off_highlight):
7694 (get_tty_terminal): Now static.
7695 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7696 * termhooks.h (term_mouse_moveto): Do not declare if
7698 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7699 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7701 * sysdep.c: Make symbols static if they're not exported.
7702 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7704 (sigprocmask_set, full_mask): Remove; unused.
7705 (wait_debugging): Mark as visible.
7706 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7707 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7709 * syntax.c (syntax_temp): Define only if !__GNUC__.
7711 * sound.c (current_sound_device, current_sound): Now static.
7713 * search.c (searchbufs, searchbuf_head): Now static.
7715 * scroll.c (scroll_cost): Remove; unused.
7716 * dispextern.h (scroll_cost): Remove decl.
7718 * region-cache.h (pp_cache): Mark as externally visible.
7720 * process.c: Make symbols static if they're not exported.
7721 (process_tick, update_tick, create_process, chan_process):
7722 (Vprocess_alist, proc_buffered_char, datagram_access):
7723 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7724 (deactivate_process): Mark defn as static, as well as decl.
7725 * lisp.h (create_process): Remove decl.
7726 * process.h (chan_process, Vprocess_alist): Remove decls.
7728 * print.c: Make symbols static if they're not exported.
7729 (print_depth, new_backquote_output, being_printed, print_buffer):
7730 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7731 (print_interval, print_number_index, initial_stderr_stream):
7733 * lisp.h (Fprinc): Remove decl.
7734 (debug_output_compilation_hack): Mark as externally visible.
7736 * sysdep.c (croak): Move decl from here to syssignal.h.
7737 * syssignal.h (croak): Put it here, so the API can be checked when
7738 'croak' is called from dissociate_if_controlling_tty.
7740 * minibuf.c: Make symbols static if they're not exported.
7741 (minibuf_save_list, choose_minibuf_frame): Now static.
7742 * lisp.h (choose_minibuf_frame): Remove decl.
7744 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7746 * lread.c: Make symbols static if they're not exported.
7747 (read_objects, initial_obarray, oblookup_last_bucket_number):
7749 (make_symbol): Remove; unused.
7750 * lisp.h (initial_obarray, make_symbol): Remove decls.
7752 * keyboard.c: Make symbols static if they're not exported.
7753 (single_kboard, recent_keys_index, total_keys, recent_keys):
7754 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7755 (this_single_command_key_start, echoing, last_auto_save):
7756 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7757 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7758 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7759 (Vlispy_mouse_stem, double_click_count):
7761 (force_auto_save_soon): Define only if SIGDANGER.
7762 (ignore_mouse_drag_p): Now static if
7763 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7764 (print_help): Remove; unused.
7765 (stop_character, last_timer_event): Mark as externally visible.
7766 * keyboard.h (ignore_mouse_drag_p): Declare only if
7767 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7768 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7769 * lisp.h (echoing): Remove decl.
7770 (force_auto_save_soon): Declare only if SIGDANGER.
7771 * xdisp.c (redisplay_window): Simplify code, to make it more
7772 obvious that ignore_mouse_drag_p is not accessed if !defined
7773 USE_GTK && !defined HAVE_NS.
7775 * intervals.c: Make symbols static if they're not exported.
7776 (merge_properties_sticky, merge_interval_right, delete_interval):
7778 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7780 * insdel.c: Make symbols static if they're not exported.
7781 However, leave prepare_to_modify_buffer alone. It's never
7782 called from outside this function, but that appears to be a bug.
7783 (combine_after_change_list, combine_after_change_buffer):
7784 (adjust_after_replace, signal_before_change): Now static.
7785 (adjust_after_replace_noundo): Remove; unused.
7786 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7787 (signal_before_change): Remove decls.
7789 * indent.c (val_compute_motion, val_vmotion): Now static.
7791 * image.c: Make symbols static if they're not exported.
7792 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7794 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7795 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7797 * fringe.c (standard_bitmaps): Now static.
7798 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7800 * frame.c: Make symbols static if they're not exported.
7801 (x_report_frame_params, make_terminal_frame): Now static.
7802 (get_frame_param): Now static, unless HAVE_NS.
7803 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7804 (x_get_resource_string): Remove; not used.
7805 * frame.h (make_terminal_frame, x_report_frame_params):
7806 (x_get_resource_string); Remove decls.
7807 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7808 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7810 * font.c, fontset.c: Make symbols static if they're not exported.
7811 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7812 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7813 * font.c (font_close_object): Now static.
7814 * font.h (font_close_object): Remove.
7815 * fontset.c (FONTSET_OBJLIST): Remove.
7816 (free_realized_fontset) #if-0 the body, which does nothing.
7817 (face_suitable_for_char_p): #if-0, as it's never called.
7818 * fontset.h (face_suitable_for_char_p): Remove decl.
7819 * xfaces.c (face_at_string_position):
7820 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7821 since 0 is always ASCII.
7823 * fns.c (weak_hash_tables): Now static.
7825 * fileio.c: Make symbols static if they're not exported.
7826 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7827 (Vwrite_region_annotation_buffers): Now static.
7829 * eval.c: Make symbols static if they're not exported.
7830 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7831 * lisp.h (backtrace_list): Remove decl.
7833 * emacs.c: Make symbols static if they're not exported.
7834 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7835 (fatal_error_code, fatal_error_signal_hook, standard_args):
7837 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7838 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7839 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7840 * lisp.h (fatal_error_signal_hook): Remove decl.
7841 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7843 * editfns.c: Move a (normally-unused) function to its only use.
7844 * editfns.c, lisp.h (get_operating_system_release): Remove.
7845 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7846 worth the hassle of breaking this out.
7848 * xterm.c: Make symbols static if they're not exported.
7849 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7850 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7851 (x_destroy_window, x_delete_display):
7853 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7854 (x_mouse_leave): Remove; unused.
7855 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7856 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7857 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7859 (x_mouse_leave): Declare only if WINDOWSNT.
7860 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7861 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7864 * ftxfont.c: Make symbols static if they're not exported.
7865 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7867 * font.h (ftxfont_driver): Likewise.
7869 * xfns.c: Make symbols static if they're not exported.
7870 (x_last_font_name, x_display_info_for_name):
7871 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7872 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7873 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7874 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7875 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7876 (last_show_tip_args): Now static.
7877 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7878 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7879 (x_screen_planes): Remove; unused.
7880 * dispextern.h (x_screen_planes): Remove decl.
7882 * dispnew.c: Make symbols static if they're not exported.
7883 * dispextern.h (redraw_garbaged_frames, scrolling):
7884 (increment_row_positions): Remove.
7885 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7886 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7888 (redraw_garbaged_frames): Remove; unused.
7890 * xfaces.c: Make symbols static if they're not exported.
7891 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7893 * xterm.h (defined_color): Remove decls.
7894 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7895 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7896 (menu_face_changed_default, defined_color, free_realized_face):
7897 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7898 (ascii_face_of_lisp_face): Remove; unused.
7900 * xdisp.c: Make symbols static if they're not exported.
7901 * dispextern.h (scratch_glyph_row, window_box_edges):
7902 (glyph_to_pixel_coords, set_cursor_from_row):
7903 (get_next_display_element, set_iterator_to_next):
7904 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7905 (show_mouse_face): Remove decls
7906 * frame.h (message_buf_print): Likewise.
7907 * lisp.h (pop_message, set_message, check_point_in_composition):
7909 * xterm.h (set_vertical_scroll_bar): Likewise.
7910 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7911 (message_buf_print, scratch_glyph_row, displayed_buffer):
7912 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7913 (get_next_display_element, show_mouse_face, window_box_edges):
7914 (frame_to_window_pixel_xy, check_point_in_composition):
7915 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7916 (glyph_to_pixel_coords): Remove; unused.
7918 * dired.c (file_name_completion): Now static.
7920 * dbusbind.c (xd_in_read_queued_messages): Now static.
7922 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7923 * data.c (circular_list_error): Remove.
7925 * commands.h (last_point_position, last_point_position_buffer):
7926 (last_point_position_window): Remove decls.
7927 * keyboard.c: Make these variables static.
7929 * coding.h (coding, code_convert_region, encode_coding_gap):
7931 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7932 (iso_code_class, detect_coding, code_convert_region): Now static.
7933 (encode_coding_gap): Remove; unused.
7935 * chartab.c (chartab_chars, chartab_bits): Now static.
7937 * charset.h (charset_iso_8859_1): Remove decl.
7938 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7941 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7942 * ccl.c (Vccl_program_table): Now static.
7943 (check_ccl_update): Remove; unused.
7945 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7946 * category.h: ... from here.
7947 * category.c (check_category_table, set_category_set): Now static.
7949 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7950 * lisp.h: Remove these decls.
7952 * buffer.c (buffer_count): Remove unused var.
7954 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7955 so that it's not optimized away.
7956 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7957 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7958 exported only to the debugger.
7960 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7961 * atimer.h (run_all_atimers): Remove; not exported.
7963 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7964 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7965 was inaccessible from Lisp.
7966 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7967 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7969 alloc.c: Import and export fewer symbols, and remove unused items.
7970 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7972 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7973 it's not optimized away by whole-program optimization.
7974 (message_enable_multibyte, free_misc): Remove.
7975 (catchlist, handlerlist, mark_backtrace):
7976 Declare only if BYTE_MARK_STACK.
7977 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7978 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7979 (message_enable_multibyte): Remove decl.
7980 (free_misc, interval_free_list, float_block, float_block_index):
7981 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7982 (cons_free_list, last_marked_index):
7984 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7985 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7986 (mark_backtrace): Define only if BYTE_MARK_STACK.
7987 * xdisp.c (message_enable_multibyte): Now static.
7989 Declare Lisp_Object Q* variables to be 'static' if not exported.
7990 This makes it easier for human readers (and static analyzers)
7991 to see whether these variables are used from other modules.
7992 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7993 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7994 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7995 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7996 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7997 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7998 * xmenu.c, xselect.c:
7999 Declare Q* vars static if they are not used in other modules.
8000 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8001 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8002 Remove decls of unexported vars.
8003 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8005 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8007 Make Emacs functions such as Fatom 'static' by default.
8008 This makes it easier for human readers (and static analyzers)
8009 to see whether these functions can be called from other modules.
8010 DEFUN now defines a static function. To make the function external
8011 so that it can be used in other C modules, use the new macro DEFUE.
8012 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8013 (Finit_image_library):
8014 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8015 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8016 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8017 Remove decls, since these functions are now static.
8018 (Funintern, Fget_internal_run_time): New decls, since these functions
8019 were already external.
8021 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8022 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8023 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8024 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8025 * keyboard.c, keymap.c, lread.c:
8026 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8027 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8028 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8029 Mark functions with DEFUE instead of DEFUN,
8030 if they are used in other modules.
8031 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8032 decls for now-static functions.
8033 * buffer.h (Fdelete_overlay): Remove decl.
8034 * callproc.c (Fgetenv_internal): Mark as internal.
8035 * composite.c (Fremove_list_of_text_properties): Remove decl.
8036 (Fcomposition_get_gstring): New forward static decl.
8037 * composite.h (Fcomposite_get_gstring): Remove decl.
8038 * dired.c (Ffile_attributes): New forward static decl.
8039 * doc.c (Fdocumntation_property): New forward static decl.
8040 * eval.c (Ffetch_bytecode): New forward static decl.
8041 (Funintern): Remove extern decl; now in .h file where it belongs.
8042 * fileio.c (Fmake_symbolic_link): New forward static decl.
8043 * image.c (Finit_image_library): New forward static decl.
8044 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8045 * intervals.h (Fprevious_property_change):
8046 (Fremove_list_of_text_properties): Remove decls.
8047 * keyboard.c (Fthis_command_keys): Remove decl.
8048 (Fcommand_execute): New forward static decl.
8049 * keymap.c (Flookup_key): New forward static decl.
8050 (Fcopy_keymap): Now static.
8051 * keymap.h (Flookup_key): Remove decl.
8052 * process.c (Fget_process): New forward static decl.
8053 (Fprocess_datagram_address): Mark as internal.
8054 * syntax.c (Fsyntax_table_p): New forward static decl.
8055 (skip_chars): Remove duplicate decl.
8056 * textprop.c (Fprevious_property_change): New forward static decl.
8057 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8059 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8060 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8062 * editfns.c (Fformat): Remove unreachable code.
8064 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8066 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8069 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8071 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8072 when at ZV. (Bug#8487)
8074 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8076 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8078 * keyboard.c (parse_tool_bar_item): Likewise.
8079 * sound.c (sound_cleanup, alsa_close): Likewise.
8080 * termcap.c (tgetent): Likewise.
8081 * xfns.c (x_default_font_parameter): Likewise.
8082 * xsettings.c (read_and_apply_settings): Likewise.
8084 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8085 (overrun_check_free): Protoize.
8087 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8089 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8090 since callers should never pass a negative size.
8091 Change the signature to match that of plain 'read' and 'write'; see
8092 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8093 * lisp.h: Update prototypes of emacs_write and emacs_read.
8095 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8097 * xdisp.c (redisplay_window): Don't try to determine the character
8098 position of the scroll margin if the window start point w->startp
8099 is outside the buffer's accessible region. (Bug#8468)
8101 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8103 Fix write-region and its subroutines for buffers > 2GB.
8104 * fileio.c (a_write, e_write): Modify declaration of arguments and
8105 local variables to support buffers larger than 2GB.
8106 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8108 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8109 argument, local variables, and return value.
8111 * lisp.h: Update prototypes of emacs_write and emacs_read.
8113 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8115 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8117 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8119 Fix more problems found by GCC 4.6.0's static checks.
8121 * xdisp.c (vmessage): Use a better test for character truncation.
8123 * charset.c (load_charset_map): <, not <=, for optimization,
8124 and to avoid potential problems with integer overflow.
8125 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8126 * casetab.c (set_identity, shuffle): Likewise.
8127 * editfns.c (Fformat): Likewise.
8128 * syntax.c (skip_chars): Likewise.
8130 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8131 This also lets GCC 4.6.0 generate slightly better loop code.
8133 * callint.c (Fcall_interactively): <, not <=, for optimization.
8134 (Fcall_interactively): Count the number of arguments produced,
8135 not the number of arguments given. This is simpler and lets GCC
8136 4.6.0 generate slightly better code.
8138 * ftfont.c: Distingish more carefully between FcChar8 and char.
8139 The previous code passed unsigned char * to a functions like
8140 strlen and xstrcasecmp that expect char *, which does not
8141 conform to the C standard.
8142 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8143 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8144 char * when the C standard requires it.
8146 * keyboard.c (read_char): Remove unused var.
8148 * eval.c: Port to Windows vsnprintf (Bug#8435).
8150 (SIZE_MAX): Define if the headers do not.
8151 (verror): Do not give up if vsnprintf returns a negative count.
8152 Instead, grow the buffer. This ports to Windows vsnprintf, which
8153 does not conform to C99. Problem reported by Eli Zaretskii.
8154 Also, simplify the allocation scheme, by avoiding the need for
8155 calling realloc, and removing the ALLOCATED variable.
8157 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8159 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8160 But keep the doprint source code for now, as we might revamp it
8161 and use it again (Bug#8435).
8162 * lisp.h (doprnt): Remove.
8163 * Makefile.in (base_obj): Remove doprnt.o.
8164 * deps.mk (doprnt.o): Remove.
8166 error: Print 32- and 64-bit integers portably (Bug#8435).
8167 Without this change, on typical 64-bit hosts error ("...%d...", N)
8168 was used to print both 32- and 64-bit integers N, which relied on
8170 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8171 * lisp.h (error, verror): Mark as printf-like functions.
8172 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8173 Report overflow in size calculations when allocating printf buffer.
8174 Do not truncate output string at its first null byte.
8175 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8176 Truncate the output at a character boundary, since vsnprintf does not
8178 * charset.c (check_iso_charset_parameter): Convert internal
8179 character to string before calling 'error', since %c now has the
8181 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8182 overflow when computing char to be passed to 'error'. Do not
8183 pass Lisp_Object to 'error'; pass the integer instead.
8184 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8185 formatted with plain %d.
8187 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8189 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8191 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8193 * xterm.c (x_catch_errors): Remove duplicate declaration.
8195 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8197 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8199 2011-04-10 Jim Meyering <meyering@redhat.com>
8201 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8202 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8203 return ssize_t not "int", and use size_t as the buffer length.
8204 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8205 * gnutls.h: Update declarations.
8206 * process.c (read_process_output): Use ssize_t, to match.
8207 (send_process): Likewise.
8209 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8211 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8213 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8215 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8216 Use unsigned char, to match FcChar8 type definition.
8218 * xterm.c (handle_one_xevent):
8219 * xmenu.c (create_and_show_popup_menu):
8220 * xselect.c (x_decline_selection_request)
8221 (x_reply_selection_request): Avoid type-punned deref of X events.
8223 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8225 Fix some uses of `int' instead of EMACS_INT.
8226 * search.c (string_match_1, fast_string_match)
8227 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8228 (scan_buffer, find_next_newline_no_quit)
8229 (find_before_next_newline, search_command, Freplace_match)
8230 (Fmatch_data): Make some `int' variables be EMACS_INT.
8232 * xdisp.c (display_count_lines): 3rd argument and return value now
8233 EMACS_INT. All callers changed.
8234 (pint2hrstr): Last argument is now EMACS_INT.
8236 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8237 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8238 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8239 (decode_coding_utf_16, decode_coding_emacs_mule)
8240 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8241 (decode_coding_ccl, decode_coding_charset)
8242 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8243 (decode_coding_iso_2022, decode_coding_emacs_mule)
8244 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8245 <char_offset, last_offset>: Declare EMACS_INT.
8246 (encode_coding_utf_8, encode_coding_utf_16)
8247 (encode_coding_emacs_mule, encode_invocation_designation)
8248 (encode_designation_at_bol, encode_coding_iso_2022)
8249 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8250 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8252 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8253 (encode_invocation_designation): Last argument P_NCHARS is now
8255 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8256 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8258 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8261 * ccl.c (Fccl_execute_on_string): Declare some variables
8264 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8266 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8268 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8270 * process.c (Fformat_network_address): Doc fix.
8272 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8274 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8276 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8278 * keyboard.c (read_char): Call Lisp function help-form-show,
8279 instead of using internal_with_output_to_temp_buffer.
8280 (Qhelp_form_show): New var.
8281 (syms_of_keyboard): Use DEFSYM macro.
8283 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8285 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8287 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8289 * process.c (Flist_processes): Remove to Lisp.
8290 (list_processes_1): Delete.
8292 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8294 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8296 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8298 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8300 Fix more problems found by GCC 4.6.0's static checks.
8302 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8304 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8306 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8308 * xdisp.c (vmessage): Mark as a printf-like function.
8310 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8312 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8314 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8315 printf-like functions.
8316 (tiff_load): Add casts to remove these marks before passing them
8317 to system-supplied API.
8319 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8321 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8322 This avoids several warnings with gcc -Wstrict-overflow.
8323 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8324 directly, rather than having caller test rule sign. This avoids
8325 some unnecessary tests.
8326 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8327 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8328 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8330 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8331 (xfont_open): Avoid unnecessary tests.
8333 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8335 * composite.h, composite.c (composition_gstring_put_cache):
8336 Use EMACS_INT, not int, for length.
8338 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8339 breaking out part of COMPOSITION_DECODE_RULE.
8340 (COMPOSITION_DECODE_RULE): Use it.
8341 * composite.c (get_composition_id): Remove unused local vars,
8342 by using the new macro.
8344 * textprop.c (set_text_properties_1): Change while to do-while,
8345 since the condition is always true at first.
8347 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8348 (interval_deletion_adjustment): Return unsigned value.
8351 * process.c (list_processes_1, create_pty, read_process_output):
8352 (exec_sentinel): Remove vars that were set but not used.
8353 (create_pty): Remove unnecessary "volatile"s.
8354 (Fnetwork_interface_info): Avoid possibility of int overflow.
8355 (read_process_output): Do adaptive read buffering even if carryover.
8356 (read_process_output): Simplify nbytes computation if buffered.
8358 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8360 * syntax.c (scan_words): Remove var that was set but not used.
8361 (update_syntax_table): Use unsigned instead of int.
8363 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8364 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8365 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8367 * print.c (print_error_message): Avoid int overflow.
8369 * font.c (font_list_entities): Redo for clarity,
8370 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8372 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8373 (font_score): Avoid potential overflow in diff calculation.
8375 * fns.c (substring_both): Remove var that is set but not used.
8376 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8378 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8380 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8381 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8382 can always succeed if overflow has undefined behavior.
8384 * search.c (boyer_moore, wordify): Remove vars set but not used.
8385 (wordify): Omit three unnecessary tests.
8387 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8388 All callers changed. This avoids the need for an unused var.
8390 * casefiddle.c (casify_region): Remove var that is set but not used.
8392 * dired.c (file_name_completion): Remove var that is set but not used.
8394 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8396 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8397 (Finsert_file_contents): Remove unnecessary code checking fd.
8399 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8400 Check for integer overflow on size calculations.
8402 * buffer.c (Fprevious_overlay_change): Remove var that is set
8405 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8406 Remove vars that are set but not used.
8407 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8408 (timer_check_2): Mark vars as initialized.
8410 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8412 * image.c (lookup_image): Remove var that is set but not used.
8413 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8415 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8416 that are set but not used.
8418 * xfns.c (make_invisible_cursor): Don't return garbage
8419 if XCreateBitmapFromData fails (Bug#8410).
8421 * xselect.c (x_get_local_selection, x_handle_property_notify):
8422 Remove vars that are set but not used.
8424 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8425 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8427 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8428 Remove var that is set but not used.
8429 (scroll_bar_windows_size): Now size_t, not int.
8430 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8433 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8434 (map_tty_color) [!defined MSDOS]: Likewise.
8436 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8438 * coding.c: Remove vars that are set but not used.
8439 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8440 All callers changed.
8441 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8442 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8443 (decode_coding_charset): Remove vars that are set but not used.
8445 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8446 that is set but not used.
8448 * print.c (print_object): Remove var that is set but not used.
8450 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8451 The gnulib version avoids calling malloc in the usual case,
8452 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8453 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8454 * filelock.c (current_lock_owner): Likewise.
8455 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8456 * sysdep.c: Include allocator.h, careadlinkat.h.
8457 (emacs_no_realloc_allocator): New static constant.
8458 (emacs_readlink): New function.
8459 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8460 ../lib/careadlinkat.h.
8462 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8464 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8465 first non-nil return value).
8467 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8469 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8470 if not defined (Bug#8403).
8472 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8474 * xdisp.c (display_count_lines): Remove parameter `start',
8475 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8476 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8477 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8478 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8479 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8480 and thereabouts. All callers changed.
8481 (get_per_char_metric): Remove parameter `f', unused since
8482 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8484 2011-04-02 Jim Meyering <meyering@redhat.com>
8486 do not dereference NULL upon failed strdup
8487 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8488 (ns_get_family): Likewise.
8490 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8492 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8494 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8496 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8499 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8501 Add lexical binding.
8503 * window.c (Ftemp_output_buffer_show): New fun.
8504 (Fsave_window_excursion):
8505 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8507 * lread.c (lisp_file_lexically_bound_p): New function.
8508 (Fload): Bind Qlexical_binding.
8509 (readevalloop): Remove `evalfun' arg.
8510 Bind Qinternal_interpreter_environment.
8511 (Feval_buffer): Bind Qlexical_binding.
8512 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8514 (syms_of_lread): Declare `lexical-binding'.
8516 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8518 * keyboard.c (eval_dyn): New fun.
8519 (menu_item_eval_property): Use it.
8521 * image.c (parse_image_spec): Use Ffunctionp.
8523 * fns.c (concat, mapcar1): Accept byte-code-functions.
8525 * eval.c (Fsetq): Handle lexical vars.
8526 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8527 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8528 (FletX, Flet): Obey lexical binding.
8529 (Fcommandp): Handle closures.
8530 (Feval): New `lexical' arg.
8531 (eval_sub): New function extracted from Feval. Use it almost
8532 everywhere where Feval was used. Look up vars in lexical env.
8534 (Ffunctionp): Move from subr.el.
8535 (Ffuncall): Handle closures.
8536 (apply_lambda): Remove `eval_flags'.
8537 (funcall_lambda): Handle closures and new byte-code-functions.
8538 (Fspecial_variable_p): New function.
8539 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8540 but without exporting it to Lisp.
8542 * doc.c (Fdocumentation, store_function_docstring):
8543 * data.c (Finteractive_form): Handle closures.
8545 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8548 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8550 (exec_byte_code): New function extracted from Fbyte_code to handle new
8551 calling convention for byte-code-functions. Add new byte-codes.
8553 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8555 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8557 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8559 * xdisp.c (redisplay_internal): Fix prototype.
8561 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8563 * xdisp.c (SCROLL_LIMIT): New macro.
8564 (try_scrolling): Use it when setting scroll_limit.
8565 Limit scrolling to 100 screen lines.
8566 (redisplay_window): Even when falling back on "recentering",
8567 position point in the window according to scroll-conservatively,
8568 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8570 (try_scrolling): When point is above the window, allow searching
8571 as far as scroll_max, or one screenful, to compute vertical
8572 distance from PT to the scroll margin position. This prevents
8573 try_scrolling from unnecessarily failing when
8574 scroll-conservatively is set to a value slightly larger than the
8575 window height. Clean up the case of PT below the margin at bottom
8576 of window: scroll_max can no longer be INT_MAX. When aggressive
8577 scrolling is in use, don't let point enter the opposite scroll
8578 margin as result of the scroll.
8579 (syms_of_xdisp) <scroll-conservatively>: Document the
8580 threshold of 100 lines for never-recentering scrolling.
8582 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8584 * dispextern.h (move_it_by_lines):
8585 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8586 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8587 (message_log_check_duplicate): Remove parameters `prev_bol' and
8588 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8589 (redisplay_internal): Remove parameter `preserve_echo_area',
8590 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8592 * indent.c (Fvertical_motion):
8593 * window.c (window_scroll_pixel_based, Frecenter):
8594 Don't pass `need_y_p' to `move_it_by_lines'.
8596 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8598 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8599 steal a few bits to be more compact.
8600 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8601 Remove unneeded casts.
8603 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8605 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8607 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8608 binding" message (bug#7967).
8610 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8612 Fix more problems found by GCC 4.6.0's static checks.
8614 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8615 Remove unused local var.
8617 * editfns.c (Fmessage_box): Remove unused local var.
8619 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8620 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8621 Omit unused local vars.
8622 * window.c (shrink_windows): Omit unused local var.
8623 * menu.c (digest_single_submenu): Omit unused local var.
8624 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8625 Omit unused local var.
8627 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8628 Don't assume string length fits in int.
8629 (keyremap_step, read_key_sequence): Use size_t for sizes.
8630 (read_key_sequence): Don't check last_real_key_start redundantly.
8632 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8633 instead of alloca (Bug#8344).
8635 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8636 (Fbacktrace_frame): Don't assume nframes fits in int.
8638 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8640 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8643 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8645 * cm.c (calccost): Turn while-do into do-while, for clarity.
8647 * keyboard.c (syms_of_keyboard): Use the same style as later
8648 in this function when indexing through an array. This also
8649 works around GCC bug 48267.
8651 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8653 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8655 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8656 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8658 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8659 This avoids undefined behavior on integer overflow, and is a bit
8660 more convenient anyway since it is compared to a size_t variable.
8662 Variadic C functions now count arguments with size_t, not int.
8663 This avoids an unnecessary limitation on 64-bit machines, which
8664 caused (substring ...) to crash on large vectors (Bug#8344).
8665 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8666 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8667 All variadic functions and their callers changed accordingly.
8668 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8669 * data.c (arith_driver, float_arith_driver): Likewise.
8670 * editfns.c (general_insert_function): Likewise.
8671 * eval.c (struct backtrace.nargs, interactive_p)
8672 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8673 (funcall_lambda, mark_backtrace): Likewise.
8674 * fns.c (concat): Likewise.
8675 * frame.c (x_set_frame_parameters): Likewise.
8676 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8677 0 if not found, not -1. All callers changed.
8679 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8680 (stack_copy_size): Now size_t, not int.
8681 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8683 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8685 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8686 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8687 All callers changed.
8689 * lisp.h (multibyte_char_to_unibyte):
8690 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8691 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8692 * character.h (CHAR_TO_BYTE8):
8693 * cmds.c (internal_self_insert):
8694 * editfns.c (general_insert_function):
8695 * keymap.c (push_key_description):
8696 * search.c (Freplace_match):
8697 * xdisp.c (message_dolog, set_message_1): All callers changed.
8699 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8701 * keyboard.c (safe_run_hook_funcall): New function.
8702 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8703 don't set the hook to nil, but remove the offending function instead.
8704 (Qcommand_hook_internal): Remove, unused.
8705 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8706 Vcommand_hook_internal.
8708 * eval.c (enum run_hooks_condition): Remove.
8709 (funcall_nil, funcall_not): New functions.
8710 (run_hook_with_args): Call each function through a `funcall' argument.
8711 Remove `cond' argument, now redundant.
8712 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8713 (Frun_hook_with_args_until_failure): Adjust accordingly.
8714 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8716 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8718 * dispextern.h (string_buffer_position): Remove declaration.
8720 * print.c (strout): Remove parameter `multibyte', unused since
8721 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8723 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8724 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8725 All callers changed.
8727 * w32.c (_wsa_errlist): Use braces for struct initializers.
8729 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8730 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8731 All callers changed.
8732 (string_buffer_position): Likewise. Also, make static (it's never
8733 used outside xdisp.c).
8734 (cursor_row_p): Remove parameter `w', unused since
8735 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8736 (decode_mode_spec): Remove parameter `precision', introduced during
8737 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8738 All callers changed.
8740 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8742 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8744 2011-03-27 Anders Lindgren <andlind@gmail.com>
8746 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8747 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8748 (ns_update_auto_hide_menu_bar): New functions.
8749 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8750 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8751 ns_constrain_all_frames.
8752 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8753 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8755 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8757 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8759 2011-03-27 Glenn Morris <rgm@gnu.org>
8761 * syssignal.h: Replace RETSIGTYPE with void.
8762 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8763 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8764 Replace SIGTYPE with void everywhere.
8765 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8766 * s/template.h (SIGTYPE): Remove commented out definition.
8768 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8770 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8771 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8773 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8775 * w32.c (read_unc_volume): Use parameter `henum', instead of
8776 global variable `wget_enum_handle'.
8778 * keymap.c (describe_vector): Remove parameters `indices' and
8779 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8780 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8782 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8784 * keyboard.c (timer_check): Remove parameter `do_it_now',
8785 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8786 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8787 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8789 * keyboard.c (read_char):
8790 * w32menu.c (w32_menu_display_help):
8791 * xmenu.c (show_help_event, menu_help_callback):
8792 Adjust calls to `show_help_echo'.
8794 * gtkutil.c (xg_maybe_add_timer):
8795 * keyboard.c (readable_events):
8796 * process.c (wait_reading_process_output):
8797 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8799 * insdel.c (adjust_markers_gap_motion):
8800 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8801 (gap_left, gap_right): Don't call it.
8803 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8805 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8806 incurred during fontification.
8808 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8810 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8811 (DEFVAR_PER_BUFFER): Don't pass it.
8813 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8814 (scrolling_window): Don't pass it.
8816 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8818 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8820 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8822 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8823 of variables specific to SELinux and computation of `encoded_absname'.
8825 * image.c (XPutPixel): Remove unused variable `height'.
8827 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8829 * unexw32.c (get_section_info): Remove unused variable `section'.
8831 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8832 (system_process_attributes): Remove unused variable `sess'.
8833 (sys_read): Remove unused variable `err'.
8835 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8836 (w32_wnd_proc): Remove unused variable `isdead'.
8837 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8838 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8839 (x_create_tip_frame): Remove unused variable `tem'.
8841 * w32inevt.c (w32_console_read_socket):
8842 Remove unused variable `no_events'.
8844 * w32term.c (x_draw_composite_glyph_string_foreground):
8845 Remove unused variable `width'.
8847 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8849 * w32term.c (x_set_glyph_string_clipping):
8850 Don't pass uninitialized region to CombineRgn.
8852 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8854 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8855 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8856 (Fx_close_connection): Remove unused variable `i'.
8858 * w32font.c (w32font_draw): Return number of glyphs.
8859 (w32font_open_internal): Remove unused variable `i'.
8860 (w32font_driver): Add missing initializer.
8862 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8863 (fill_in_menu): Remove unused variable `items_added'.
8865 * w32term.c (last_mouse_press_frame): Remove static global variable.
8866 (w32_clip_to_row): Remove unused variable `f'.
8867 (x_delete_terminal): Remove unused variable `i'.
8869 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8870 (NOTHING): Remove unused static global variable.
8871 (uniscribe_check_otf): Remove unused variable `table'.
8872 (uniscribe_font_driver): Add missing initializers.
8874 2011-03-23 Julien Danjou <julien@danjou.info>
8876 * term.c (Fsuspend_tty, Fresume_tty):
8877 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8878 * window.c (temp_output_buffer_show):
8879 * insdel.c (signal_before_change):
8880 * frame.c (Fhandle_switch_frame):
8881 * fileio.c (Fdo_auto_save):
8882 * emacs.c (Fkill_emacs):
8883 * editfns.c (save_excursion_restore):
8884 * cmds.c (internal_self_insert):
8885 * callint.c (Fcall_interactively):
8886 * buffer.c (Fkill_all_local_variables):
8887 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8889 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8890 unconditionally since it does the check itself.
8892 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8894 Fix more problems found by GCC 4.5.2's static checks.
8896 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8897 the first time through the loop, since we know p0 < p1 then.
8898 This also avoids a gcc -Wstrict-overflow warning.
8900 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8901 leading to a memory leak, possible in functions like
8902 load_charset_map_from_file that can allocate an unbounded number
8903 of objects (Bug#8318).
8905 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8906 that could (at least in theory) be that large.
8908 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8909 This is less likely to overflow, and avoids undefined behavior if
8910 overflow does occur. All callers changed. Use strtoul to scan
8911 for the unsigned long integer.
8912 (pint2hrstr): Simplify and tune code slightly.
8913 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8915 * scroll.c (do_scrolling): Work around GCC bug 48228.
8916 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8918 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8919 This also avoids a warning with gcc -Wstrict-overflow.
8920 (validate_x_resource_name): Simplify count usage.
8921 This also avoids a warning with gcc -Wstrict-overflow.
8923 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8926 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8928 * process.c (Fmake_network_process): Use socklen_t, not int,
8929 where POSIX says socklen_t is required in portable programs.
8930 This fixes a porting bug on hosts like 64-bit HP-UX, where
8931 socklen_t is wider than int (Bug#8277).
8932 (Fmake_network_process, server_accept_connection):
8933 (wait_reading_process_output, read_process_output):
8936 * process.c: Rename or move locals to avoid shadowing.
8937 (list_processes_1, Fmake_network_process):
8938 (read_process_output_error_handler, exec_sentinel_error_handler):
8939 Rename or move locals.
8940 (Fmake_network_process): Define label "retry_connect" only if needed.
8941 (Fnetwork_interface_info): Fix pointer signedness.
8942 (process_send_signal): Add cast to avoid pointer signedness problem.
8943 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8944 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8946 Make tparam.h and terminfo.c consistent.
8947 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8948 Include tparam.h instead, since it declares them.
8949 * cm.h (PC): Remove extern decl; tparam.h now does this.
8950 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8951 * terminfo.c: Include tparam.h, to check interfaces.
8952 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8953 (tparam): Adjust signature to match interface in tparam.h;
8954 this removes some undefined behavior. Check that outstring and len
8955 are zero, which they always are with Emacs.
8956 * tparam.h (PC, BC, UP): New extern decls.
8958 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8959 (xftfont_open): Rename locals to avoid shadowing.
8961 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8962 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8963 (OTF_TAG_SYM): Omit macro if not needed.
8964 (ftfont_list): Remove unused local.
8965 (get_adstyle_property, ftfont_pattern_entity):
8966 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8967 Rename locals to avoid shadowing.
8969 * xfont.c (xfont_list_family): Mark var as initialized.
8971 * xml.c (make_dom): Now static.
8973 * composite.c (composition_compute_stop_pos): Rename local to
8975 (composition_reseat_it): Remove unused locals.
8976 (find_automatic_composition, composition_adjust_point): Likewise.
8977 (composition_update_it): Mark var as initialized.
8978 (find_automatic_composition): Mark vars as initialized,
8979 with a FIXME (Bug#8290).
8981 character.h: Rename locals to avoid shadowing.
8982 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8983 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8984 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8985 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8988 * textprop.c (property_change_between_p): Remove; unused.
8990 * intervals.c (interval_start_pos): Now static.
8992 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8994 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8995 Rename locals to avoid shadowing.
8997 * sound.c (wav_play, au_play, Fplay_sound_internal):
8998 Fix pointer signedness.
8999 (alsa_choose_format): Remove unused local var.
9000 (wav_play): Initialize a variable to 0, to prevent undefined
9001 behavior (Bug#8278).
9003 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9005 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9007 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9008 clobbering (Bug#8298).
9009 * sysdep.c (sys_subshell): Likewise.
9010 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9012 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9013 This should get cleaned up, so that child_setup has the
9014 same signature on all platforms.
9016 * callproc.c (call_process_cleanup): Now static.
9017 (relocate_fd): Rename locals to avoid shadowing.
9019 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9021 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9022 not to be necessary, and produces flickering.
9024 2011-03-20 Glenn Morris <rgm@gnu.org>
9026 * config.in: Remove file.
9028 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9030 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9031 are now in src/globals.h.
9032 (syms_of_minibuf): Remove spurious & from previous change.
9034 2011-03-20 Leo Liu <sdl.web@gmail.com>
9036 * minibuf.c (completing-read-function): New variable.
9037 (completing-read-default): Rename from completing-read.
9038 (completing-read): Call completing-read-function.
9040 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9042 * xfaces.c (Fx_load_color_file):
9043 Read color file from absolute filename (bug#8250).
9045 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9047 * makefile.w32-in: Update dependencies.
9049 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9051 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9053 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9055 Fix more problems found by GCC 4.5.2's static checks.
9057 * process.c (make_serial_process_unwind, send_process_trap):
9058 (sigchld_handler): Now static.
9060 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9061 That way, the code declares only the vars that it needs.
9062 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9063 * s/cygwin.h (PTY_ITERATION): Likewise.
9064 * s/darwin.h (PTY_ITERATION): Likewise.
9065 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9067 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9068 * process.c (allocate_pty): Don't declare stb unless it's needed.
9070 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9071 (CONSTANTLIM): Remove; unused.
9072 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9073 Define only if needed.
9075 * unexelf.c (unexec): Name an expression,
9076 to avoid gcc -Wbad-function-cast warning.
9077 Use a different way to cause a compilation error if anyone uses
9078 n rather than nn, a way that does not involve shadowing.
9079 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9081 * deps.mk (unexalpha.o): Remove; unused.
9083 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9084 * unexec.h: New file.
9085 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9086 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9088 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9089 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9090 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9091 Change as necessary to match prototype in unexec.h.
9093 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9095 (back_comment, skip_chars): Mark vars as initialized.
9097 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9098 Rename locals to avoid shadowing.
9100 * lread.c (read1): Rewrite so as not to use empty "else".
9101 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9103 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9105 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9106 warning when compiling print.c.
9108 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9109 instead of using an uninitialized var.
9110 (font_sort_entities): Mark var as initialized.
9112 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9114 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9115 pointers to constants.
9116 (font_parse_fcname): Remove unused vars.
9117 (font_delete_unmatched): Now static.
9118 (font_get_spec): Remove; unused.
9119 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9120 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9121 Rename or move locals to avoid shadowing.
9123 * fns.c (require_nesting_list, require_unwind): Now static.
9124 (Ffillarray): Rename locals to avoid shadowing.
9126 * floatfns.c (domain_error2): Define only if needed.
9127 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9129 * alloc.c (mark_backtrace): Move decl from here ...
9130 * lisp.h: ... to here, so that it can be checked.
9132 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9133 (Fdefvar): Rewrite so as not to use empty "else".
9134 (lisp_indirect_variable): Name an expression,
9135 to avoid gcc -Wbad-function-cast warning.
9136 (Fdefvar): Rename locals to avoid shadowing.
9138 * callint.c (quotify_arg, quotify_args): Now static.
9139 (Fcall_interactively): Rename locals to avoid shadowing.
9140 Use const pointer when appropriate.
9142 * lisp.h (get_system_name, get_operating_system_release):
9143 Move decls here, to check interfaces.
9144 * process.c (get_operating_system_release): Move decl to lisp.h.
9145 * xrdb.c (get_system_name): Likewise.
9146 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9147 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9148 some of which prompt warnings from gcc -Wbad-function-cast.
9149 (Fformat_time_string, Fencode_time, Finsert_char):
9150 (Ftranslate_region_internal, Fformat):
9151 Rename or remove local vars to avoid shadowing.
9152 (Ftranslate_region_internal): Mark var as initialized.
9154 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9157 * lisp.h (eassert): Check that the argument compiles, even if
9158 ENABLE_CHECKING is not defined.
9160 * data.c (Findirect_variable): Name an expression, to avoid
9161 gcc -Wbad-function-cast warning.
9162 (default_value, arithcompare, arith_driver, arith_error): Now static.
9163 (store_symval_forwarding): Rename local to avoid shadowing.
9164 (Fmake_variable_buffer_local, Fmake_local_variable):
9165 Mark variables as initialized.
9166 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9168 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9169 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9170 Rename locals to avoid shadowing.
9171 (mark_stack): Move local variables into the #ifdef region where
9173 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9174 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9176 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9177 (GC_STRING_CHARS): Remove; not used.
9178 (Fmemory_limit): Cast sbrk's returned value to char *.
9180 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9181 avoids undefined behavior in theory.
9183 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9185 Use functions, not macros, for up- and down-casing (Bug#8254).
9186 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9187 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9188 to use the following functions instead of these macros.
9189 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9190 EMACS_INT, since callers assume the returned value fits in int.
9191 (upcase1): Likewise, for UPCASE_TABLE.
9192 (uppercasep, lowercasep, upcase): New static inline functions.
9193 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9194 the race-condition problem in the old DOWNCASE.
9196 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9197 Rename locals to avoid shadowing.
9198 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9199 (regex_compile, re_search_2, re_match_2_internal):
9200 Remove unused local vars.
9201 (FREE_VAR): Rewrite so as not to use empty "else",
9202 which gcc can warn about.
9203 (regex_compile, re_match_2_internal): Mark locals as initialized.
9204 (RETALLOC_IF): Define only if needed.
9205 (WORDCHAR_P): Likewise. This one is never needed, but is used
9206 only in a comment talking about a compiler bug, so put inside
9207 the #if 0 of that comment.
9208 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9209 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9212 * search.c (boyer_moore): Rename locals to avoid shadowing.
9213 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9214 (PREV_CHAR_BOUNDARY): Likewise.
9216 * search.c (simple_search): Remove unused var.
9218 * dired.c (compile_pattern): Move decl from here ...
9219 * lisp.h: ... to here, so that it can be checked.
9220 (struct re_registers): New forward decl.
9222 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9224 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9226 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9227 Rename locals to avoid shadowing.
9228 (Fvertical_motion): Mark locals as initialized.
9230 * casefiddle.c (casify_object, casify_region): Now static.
9231 (casify_region): Mark local as initialized.
9233 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9235 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9236 New macros, so that the caller can use some names other than
9237 gcpro1, gcpro2, etc.
9238 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9240 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9241 argument, for consistency with GCPRO2_VAR, etc: it is now the
9242 prefix of the variable, not the variable itself. All uses
9244 * dired.c (directory_files_internal, file_name_completion):
9245 Rename locals to avoid shadowing.
9247 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9248 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9249 dired.c's scmp function, had undefined behavior.
9250 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9251 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9252 * buffer.h: ... to here, because these macros use current_buffer,
9253 and the new implementation with inline functions needs to have
9254 current_buffer in scope now, rather than later when the macros
9256 (downcase, upcase1): New static inline functions.
9257 (DOWNCASE, UPCASE1): Reimplement using these functions.
9258 This avoids undefined behavior in expressions like
9259 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9260 from race conditions in accessing the global variables
9261 case_temp1 and case_temp2.
9262 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9263 * lisp.h (case_temp1, case_temp2): Remove their decls.
9264 * character.h (ASCII_CHAR_P): Move from here ...
9265 * lisp.h: ... to here, so that the inline functions mentioned
9268 * dired.c (directory_files_internal_unwind): Now static.
9270 * fileio.c (file_name_as_directory, directory_file_name):
9271 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9273 (file_name_as_directory): Use const pointers when appropriate.
9274 (Fexpand_file_name): Likewise. In particular, newdir might
9275 point at constant storage, so make it a const pointer.
9276 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9277 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9279 (Fset_file_times, Finsert_file_contents, auto_save_error):
9280 Rename locals to avoid shadowing.
9282 * minibuf.c (choose_minibuf_frame_1): Now static.
9283 (Ftry_completion, Fall_completions): Rename or remove locals
9286 * marker.c (bytepos_to_charpos): Remove; unused.
9288 * lisp.h (verify_bytepos, count_markers): New decls,
9289 so that gcc does not warn that these functions aren't declared.
9291 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9292 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9293 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9294 (copy_text): Remove unused local var.
9296 * filelock.c (within_one_second): Now static.
9297 (lock_file_1): Rename local to avoid shadowing.
9299 * buffer.c (fix_overlays_before): Mark locals as initialized.
9300 (fix_start_end_in_overlays): Likewise. This function should be
9301 simplified by using pointers-to-pointers, but that's a different
9303 (switch_to_buffer_1): Now static.
9304 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9305 (report_overlay_modification): Rename locals to avoid shadowing.
9307 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9308 Fix pointer signedness issue.
9309 (sys_subshell): Mark local as volatile if checking for lint,
9310 to suppress a gcc -Wclobbered warning that does not seem to be right.
9311 (MAXPATHLEN): Define only if needed.
9313 * process.c (serial_open, serial_configure): Move decls from here ...
9314 * systty.h: ... to here, so that they can be checked.
9316 * fns.c (get_random, seed_random): Move extern decls from here ...
9317 * lisp.h: ... to here, so that they can be checked.
9319 * sysdep.c (reset_io): Now static.
9320 (wait_for_termination_signal): Remove; unused.
9322 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9323 (copy_keymap_item, append_key, push_text_char_description):
9325 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9326 (DENSE_TABLE_SIZE): Remove; unused.
9327 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9328 (describe_map_tree):
9329 Rename locals to avoid shadowing.
9331 * keyboard.c: Declare functions static if they are not used elsewhere.
9332 (echo_char, echo_dash, cmd_error, top_level_2):
9333 (poll_for_input, handle_async_input): Now static.
9334 (read_char, kbd_buffer_get_event, make_lispy_position):
9335 (make_lispy_event, make_lispy_movement, apply_modifiers):
9336 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9337 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9338 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9339 (read_key_sequence, read_char): Mark locals as initialized.
9340 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9342 * keyboard.h (make_ctrl_char): New decl.
9343 (mark_kboards): Move decl here ...
9344 * alloc.c (mark_kboards): ... from here.
9346 * lisp.h (force_auto_save_soon): New decl.
9348 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9349 (DEFINE_DUMMY_FUNCTION): New macro.
9350 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9352 (main): Add casts to avoid warnings
9353 if GCC considers string literals to be constants.
9355 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9357 * dbusbind.c: Pointer signedness fixes.
9358 (xd_signature, xd_append_arg, xd_initialize):
9359 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9360 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9361 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9362 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9364 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9365 if GCC considers string literals to be constants.
9366 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9368 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9370 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9371 (print_preprocess, print_object): New macro to fix last change.
9373 * print.c (print_preprocess): Don't forget font objects.
9375 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9377 * emacs.c (USAGE3): Doc fixes.
9379 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9381 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9384 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9386 * lisp.h (VWindow_system, Qfile_name_history):
9387 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9388 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9389 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9391 * w32select.c: Don't #include "keyboard.h".
9392 (run_protected): Add extern declaration for waiting_for_input.
9394 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9395 * w32console.c (detect_input_pending, read_input_pending)
9396 (encode_terminal_code):
9397 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9398 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9399 (w32_system_caret_y, Qfile_name_history):
9400 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9401 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9402 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9403 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9404 * w32proc.c (Qlocal, report_file_error):
9405 * w32term.c (Vwindow_system, updating_frame):
9406 * w32uniscribe.c (initialized, uniscribe_font_driver):
9407 Remove unneeded extern declarations.
9409 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9411 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9413 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9415 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9416 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9417 These macros can no longer be used for assignment.
9419 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9420 Assign struct members directly, instead of using BUF_BEGV etc.
9421 (record_buffer_markers, fetch_buffer_markers): New functions for
9422 recording and fetching special buffer markers.
9423 (set_buffer_internal_1, set_buffer_temp): Use them.
9425 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9427 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9429 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9430 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9432 * xdisp.c (hscroll_window_tree):
9433 (reconsider_clip_changes): Use PT instead of BUF_PT.
9435 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9437 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9438 $(EMACS_ROOT)/lib/intprops.h.
9440 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9442 Fix more problems found by GCC 4.5.2's static checks.
9444 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9445 to unsigned char * to avoid compiler diagnostic.
9446 (xg_free_frame_widgets): Make it clear that a local variable is
9447 needed only if USE_GTK_TOOLTIP.
9448 (gdk_window_get_screen): Make it clear that this macro is needed
9449 only if USE_GTK_TOOLTIP.
9450 (int_gtk_range_get_value): New function, which avoids a diagnostic
9451 from gcc -Wbad-function-cast.
9452 (xg_set_toolkit_scroll_bar_thumb): Use it.
9453 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9454 diagnostic from gcc -Wbad-function-cast.
9455 (get_utf8_string, xg_get_file_with_chooser):
9456 Rename locals to avoid shadowing.
9457 (create_dialog): Move locals to avoid shadowing.
9459 * xgselect.c (xg_select): Remove unused var.
9461 * image.c (four_corners_best): Mark locals as initialized.
9462 (gif_load): Initialize transparent_p to zero (Bug#8238).
9463 Mark another local as initialized.
9464 (my_png_error, my_error_exit): Mark with NO_RETURN.
9466 * image.c (clear_image_cache): Now static.
9467 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9468 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9469 (x_edge_detection): Remove unnecessary cast that
9470 gcc -Wbad-function-cast diagnoses.
9471 (gif_load): Fix pointer signedness.
9472 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9473 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9475 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9477 Improve quality of tests for time stamp overflow.
9478 For example, without this patch (encode-time 0 0 0 1 1
9479 1152921504606846976) returns the obviously-bogus value (-948597
9480 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9481 reports time overflow. See
9482 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9483 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9484 * editfns.c: Include limits.h and intprops.h.
9485 (TIME_T_MIN, TIME_T_MAX): New macros.
9486 (time_overflow): Move earlier, to before first use.
9487 (hi_time, lo_time): New functions, for an accurate test for
9489 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9490 (Fget_internal_run_time): Don't assume time_t fits in int.
9491 (make_time): Use list2 instead of Fcons twice.
9492 (Fdecode_time): More accurate test for out-of-range times.
9493 (check_tm_member): New function.
9494 (Fencode_time): Use it, to test for out-of-range times.
9495 (lisp_time_argument): Don't rely on undefined left-shift and
9496 right-shift behavior when checking for time stamp overflow.
9498 * editfns.c (time_overflow): New function, refactoring common code.
9499 (Fformat_time_string, Fdecode_time, Fencode_time):
9500 (Fcurrent_time_string): Use it.
9502 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9503 * dired.c (make_time): Move to ...
9504 * editfns.c (make_time): ... here.
9505 * systime.h: Note the move.
9507 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9509 * fringe.c (update_window_fringes): Remove unused variables.
9511 * unexmacosx.c (copy_data_segment): Also copy __got section.
9514 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9516 * termcap.c [MSDOS]: Include "msdos.h".
9517 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9518 Constify `char *' arguments and their references according to
9519 prototypes in tparam.h.
9521 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9523 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9524 Adapt all references accordingly.
9526 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9528 2011-03-11 Tom Tromey <tromey@redhat.com>
9530 * buffer.c (syms_of_buffer): Remove obsolete comment.
9532 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9534 * termhooks.h (encode_terminal_code): Declare prototype.
9536 * msdos.c (encode_terminal_code): Don't declare prototype.
9538 * term.c (encode_terminal_code): Now external again, used by
9539 w32console.c and msdos.c.
9541 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9542 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9544 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9546 Fix some minor problems found by GCC 4.5.2's static checks.
9548 * fringe.c (update_window_fringes): Mark locals as initialized
9550 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9552 * alloc.c (mark_fringe_data): Move decl from here ...
9553 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9554 to check its interface.
9555 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9557 * fontset.c (free_realized_fontset): Now static.
9558 (Fset_fontset_font): Rename local to avoid shadowing.
9559 (fontset_font): Mark local as initialized.
9560 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9562 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9564 * xselect.c (x_disown_buffer_selections): Remove; not used.
9565 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9566 (x_own_selection, Fx_disown_selection_internal): Rename locals
9568 (x_handle_dnd_message): Remove local to avoid shadowing.
9570 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9571 so that the caller can use some name other than gcpro1.
9572 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9573 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9574 (Fx_backspace_delete_keys_p):
9575 Use them to avoid shadowing, and rename vars to avoid shadowing.
9576 (x_decode_color, x_set_name, x_window): Now static.
9577 (Fx_create_frame): Add braces to silence GCC warning.
9578 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9579 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9580 Remove unused locals.
9581 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9582 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9583 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9586 * xterm.h (x_mouse_leave): New decl.
9588 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9589 Remove unused functions.
9590 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9591 (x_calc_absolute_position): Now static.
9592 (XTread_socket): Don't define label "out" unless it's used.
9593 Don't declare local "event" unless it's used.
9594 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9595 unless they are used.
9596 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9597 (x_fatal_error_signal): Remove; not used.
9598 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9599 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9600 (x_error_catcher, x_connection_closed, x_error_handler):
9601 (x_error_quitter, xembed_send_message, x_iconify_frame):
9602 (my_log_handler): Rename locals to avoid shadowing.
9603 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9604 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9606 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9607 Rename or move locals to avoid shadowing.
9608 (tty_defined_color, merge_face_heights): Now static.
9609 (free_realized_faces_for_fontset): Remove; not used.
9610 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9611 does not deduce is never used uninitialized.
9612 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9613 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9615 * terminal.c (store_terminal_param): Now static.
9617 * xmenu.c (menu_highlight_callback): Now static.
9618 (set_frame_menubar): Remove unused local.
9619 (xmenu_show): Rename parameter to avoid shadowing.
9620 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9621 since they might point to immutable storage.
9622 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9623 since it's unused otherwise.
9625 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9626 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9627 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9628 avoids a gcc -Wuninitialized diagnostic.
9629 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9630 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9631 does not deduce are never used uninitialized.
9633 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9635 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9636 * window.c (window_loop, size_window):
9637 (run_window_configuration_change_hook, enlarge_window): Likewise.
9639 * window.c (display_buffer): Now static.
9640 (size_window): Mark variables that gcc -Wuninitialized
9641 does not deduce are never used uninitialized.
9642 * window.h (check_all_windows): New decl, to forestall
9643 gcc -Wmissing-prototypes diagnostic.
9644 * dispextern.h (bidi_dump_cached_states): Likewise.
9646 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9648 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9650 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9651 and to avoid gcc -Wuninitialized warning.
9652 (load_charset_map): Mark variables that gcc -Wuninitialized
9653 does not deduce are never used uninitialized.
9654 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9656 * coding.c (coding_set_source, coding_set_destination):
9657 Use "else { /* comment */ }" rather than "else /* comment */;"
9658 for clarity, and to avoid gcc -Wempty-body warning.
9659 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9660 a block, when the outer 'i' will do.
9661 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9662 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9663 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9664 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9665 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9666 Rename locals to avoid shadowing.
9667 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9668 * coding.c (emacs_mule_char, encode_invocation_designation):
9669 Now static, since they're not used elsewhere.
9670 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9671 (decode_coding_object, encode_coding_object, detect_coding_system):
9672 (decode_coding_emacs_mule): Mark variables that gcc
9673 -Wuninitialized does not deduce are never used uninitialized.
9674 (detect_coding_iso_2022): Initialize a local variable that might
9675 be used uninitialized. Leave a FIXME because it's not clear that
9676 this initialization is needed. (Bug#8211)
9677 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9678 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9679 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9680 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9681 Remove unused macros.
9683 * category.c (hash_get_category_set): Remove unused local var.
9684 (copy_category_table): Now static, since it's not used elsewhere.
9685 * character.c (string_count_byte8): Likewise.
9687 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9688 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9690 * chartab.c (copy_sub_char_table): Now static, since it's not used
9692 (sub_char_table_ref_and_range, char_table_ref_and_range):
9693 Rename locals to avoid shadowing.
9694 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9696 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9697 (BIDI_BOB): Remove unused macro.
9699 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9700 deduce are never used uninitialized.
9701 * term.c (encode_terminal_code): Likewise.
9703 * term.c (encode_terminal_code): Now static. Remove unused local.
9705 * tparam.h: New file.
9706 * term.c, tparam.h: Include it.
9707 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9708 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9709 Move these decls to tparam.h, and make them agree with what
9710 is actually in tparam.c. The previous trick of using incompatible
9711 decls in different modules does not conform to the C standard.
9712 All callers of tparam changed to use tparam's actual API.
9713 * tparam.c (tparam1, tparam, tgoto):
9714 Use const pointers where appropriate.
9716 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9717 * cm.h (struct cm): Likewise.
9718 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9719 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9720 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9721 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9722 (turn_on_face, init_tty): Likewise.
9723 * termchar.h (struct tty_display_info): Likewise.
9725 * term.c (term_mouse_position): Rename local to avoid shadowing.
9727 * alloc.c (mark_ttys): Move decl from here ...
9728 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9730 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9732 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9734 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9736 * search.c (compile_pattern_1): Remove argument regp, unused since
9737 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9738 (compile_pattern): Don't pass it.
9740 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9742 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9743 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9745 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9747 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9749 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9750 gdk_window_get_screen, gdk_window_get_geometry,
9751 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9752 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9753 (xg_get_pixbuf_from_pixmap): New function.
9754 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9755 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9756 Call xg_get_pixbuf_from_pixmap instead of
9757 gdk_pixbuf_get_from_drawable.
9758 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9759 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9760 (xg_check_special_colors): Use GtkStyleContext and its functions
9762 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9763 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9764 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9765 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9766 Call gtk_widget_get_preferred_size.
9767 (xg_frame_resized): gdk_window_get_geometry only takes 5
9769 (xg_win_to_widget, xg_event_is_for_menubar):
9770 Call gdk_x11_window_lookup_for_display.
9771 (xg_set_widget_bg): New function.
9772 (delete_cb): New function.
9773 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9774 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9775 (xg_set_background_color): Call xg_set_widget_bg.
9776 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9777 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9778 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9779 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9781 (update_frame_tool_bar): Call gtk_widget_hide.
9782 (xg_initialize): Use GDK_KEY_g.
9784 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9786 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9788 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9789 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9790 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9792 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9794 * w32xfns.c (select_palette): Check success of RealizePalette against
9795 GDI_ERROR, not zero.
9797 See ChangeLog.11 for earlier changes.
9803 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9805 This file is part of GNU Emacs.
9807 GNU Emacs is free software: you can redistribute it and/or modify
9808 it under the terms of the GNU General Public License as published by
9809 the Free Software Foundation, either version 3 of the License, or
9810 (at your option) any later version.
9812 GNU Emacs is distributed in the hope that it will be useful,
9813 but WITHOUT ANY WARRANTY; without even the implied warranty of
9814 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9815 GNU General Public License for more details.
9817 You should have received a copy of the GNU General Public License
9818 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.