1 2012-04-11 Glenn Morris <rgm@gnu.org>
3 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
9 2012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
11 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
12 (force_quit_count): New var.
13 (handle_interrupt): Use it.
15 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
17 * w32.c (w32_delayed_load): Record the full path of the library
18 being loaded (bug#10424).
20 2012-04-09 Glenn Morris <rgm@gnu.org>
22 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
23 not just in the obarray, before snarfing them. (Bug#11036)
25 * Makefile.in ($(leimdir)/leim-list.el):
26 Pass EMACS rather than BUILT_EMACS.
28 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
30 * process.c (make_process):
31 * process.h: Add integer `gnutls_handshakes_tried' member to
34 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
35 Add convenience `GNUTLS_LOG2i' macro.
37 * gnutls.c (gnutls_log_function2i): Convenience log function.
38 (emacs_gnutls_read): Use new log functions,
39 `gnutls_handshakes_tried' process member, and
40 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
41 attempts per process (connection).
43 2012-04-09 Chong Yidong <cyd@gnu.org>
45 * eval.c (Fuser_variable_p, user_variable_p_eh)
46 (lisp_indirect_variable): Functions deleted.
47 (Fdefvar): Caller changed.
49 * callint.c (Finteractive, Fcall_interactively):
50 * minibuf.c (Fread_variable): Callers changed.
52 2012-04-09 Eli Zaretskii <eliz@gnu.org>
54 * xdisp.c (set_cursor_from_row): If the display string appears in
55 the buffer at position that is closer to point than the position
56 after the display string, display the cursor on the first glyph of
57 the display string. Fixes cursor display when a 'display' text
58 property immediately follows invisible text. (Bug#11094)
60 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
62 composite.c: use 'double' consistently
63 * composite.c (get_composition_id): Use 'double' consistently
64 instead of converting 'float' to 'double' and vice versa; this is
65 easier to understand and avoids a GCC warning.
67 2012-04-09 Glenn Morris <rgm@gnu.org>
69 * Makefile.in: Generate leim-list with bootstrap-emacs, in
70 preparation for dumping it with emacs. (Bug#4789)
71 (leimdir): New variable.
72 ($(leimdir)/leim-list.el): New rule.
73 (emacs$(EXEEXT)): Depend on leim-list.el.
75 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
76 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
77 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
79 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
81 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
84 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
86 * xml.c (init_libxml2_functions) [WINDOWSNT]:
87 Remove unused local variable.
89 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
91 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
92 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
93 (mark_memory): Mark Lisp_Objects only if pointers might hide in
94 objects, as mark_maybe_pointer will catch them otherwise.
95 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
96 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
98 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
100 Fix typo that broke non-Windows builds.
101 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
103 2012-04-07 Eli Zaretskii <eliz@gnu.org>
105 Support building on MS-Windows with libxml2.
107 * makefile.w32-in (OBJ2): Add xml.$(O).
108 (GLOBAL_SOURCES): Add xml.c.
109 ($(BLD)/xml.$(O)): New dependency list.
111 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
112 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
113 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
114 [!WINDOWSNT]: New macros.
115 (init_libxml2_functions, libxml2_loaded_p): New functions.
116 (parse_region): Call fn_xmlCheckVersion instead of using the macro
117 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
118 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
119 Calls xmlCleanupParser only if libxml2 was loaded (or statically
121 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
122 Call init_libxml2_functions before calling libxml2 functions.
123 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
125 * emacs.c: Don't include libxml/parser.h.
126 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
127 xmlCleanupParser directly.
129 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
131 2012-04-07 Eli Zaretskii <eliz@gnu.org>
133 * indent.c (Fvertical_motion): If there is a display string at
134 point, use it.vpos to compute how many lines to backtrack after
135 move_it_to point. (Bug#11133)
137 2012-04-06 Eli Zaretskii <eliz@gnu.org>
139 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
140 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
141 about subtle differences between FETCH_CHAR* and STRING_CHAR*
142 macros related to unification of CJK characters. For the details,
143 see the discussion following the message here:
144 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
146 2012-04-04 Chong Yidong <cyd@gnu.org>
148 * keyboard.c (Vdelayed_warnings_list): Doc fix.
150 2012-04-01 Eli Zaretskii <eliz@gnu.org>
152 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
153 instead of alloca. (Bug#11138)
155 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
157 * w32menu.c (is_simple_dialog): Properly check lisp types.
160 2012-03-31 Eli Zaretskii <eliz@gnu.org>
162 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
163 position we get to after a call to move_it_to fails the
164 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
165 only if we wind up in a string from display property. (Bug#11063)
167 * window.c (Fdelete_other_windows_internal): Invalidate the row
168 and column information about mouse highlight, so that redisplay
169 restores it after reallocating the glyph matrices. (Bug#7464)
171 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
172 string comes from a `display' text property, use the buffer
173 position of that property as if we actually saw that position in
175 (move_it_by_lines): Remove the assertion that
176 "it->current_x == 0 && it->hpos == 0" which can be legitimately
177 violated when there's a before-string at the beginning of a line.
180 2012-03-30 Eli Zaretskii <eliz@gnu.org>
182 * xdisp.c (append_space_for_newline): If the default face was
183 remapped, use the remapped face for the appended newline.
184 (extend_face_to_end_of_line): Use the remapped default face for
185 extending the face to the end of the line.
186 (display_line): Call extend_face_to_end_of_line when the default
187 face was remapped. (Bug#11068)
189 2012-03-29 Eli Zaretskii <eliz@gnu.org>
191 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
193 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
195 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
197 2012-03-27 Glenn Morris <rgm@gnu.org>
199 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
202 2012-03-26 Kenichi Handa <handa@m17n.org>
204 * dispextern.h (struct glyph): Fix previous change. Change the
205 bit length of glyphless.ch to 25 (Bug#11082).
207 2012-03-26 Chong Yidong <cyd@gnu.org>
209 * keyboard.c (Vselection_inhibit_update_commands): New variable.
210 (command_loop_1): Use it; inhibit selection update for
211 handle-select-window too (Bug#8996).
213 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
215 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
217 2012-03-25 Kenichi Handa <handa@m17n.org>
219 * dispextern.h (struct glyph): Change the bit length of
220 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
222 2012-03-24 Eli Zaretskii <eliz@gnu.org>
224 * s/ms-w32.h (tzname): Include time.h before redirecting to
225 _tzname. Fixes the MSVC build. (Bug#9960)
227 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
229 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
232 * xterm.c (XTread_socket): Only modify handling_signal if
233 !SYNC_INPUT. (Bug#11080)
235 2012-03-23 Eli Zaretskii <eliz@gnu.org>
237 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
238 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
239 when fetching a multibyte character consumes more bytes than
240 CHAR_BYTES returns, due to unification of CJK characters in
241 string_char. (Bug#11073)
243 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
245 * process.c (wait_reading_process_output): Handle pty disconnect
246 by refraining from sending oneself a SIGCHLD (bug#10933).
248 2012-03-22 Chong Yidong <cyd@gnu.org>
250 * dispextern.h (struct it): New member string_from_prefix_prop_p.
252 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
253 Mark string as coming from a prefix property.
254 (handle_face_prop): Use default face for prefix strings (Bug#4281).
255 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
257 2012-03-21 Chong Yidong <cyd@gnu.org>
259 * xfaces.c (Vface_remapping_alist): Doc fix.
261 2012-03-20 Eli Zaretskii <eliz@gnu.org>
263 * w32proc.c (Fw32_set_console_codepage)
264 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
267 2012-03-20 Chong Yidong <cyd@gnu.org>
269 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
270 to reflect default non-nil value of redisplay-dont-pause.
272 2012-03-19 Kenichi Handa <handa@m17n.org>
274 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
275 it fit in a valid range (Bug#11003).
277 2012-03-18 Eli Zaretskii <eliz@gnu.org>
279 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
280 that is not from display property, accept the row as a "cursor
281 row" if one of the string's character has a non-nil `cursor'
282 property. Fixes cursor positioning when there are newlines in
283 overlay strings, e.g. in icomplete.el. (Bug#11035)
285 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
287 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
289 2012-03-12 Chong Yidong <cyd@gnu.org>
291 * eval.c (inhibit_lisp_code): Rename from
292 inhibit_window_configuration_change_hook; move from window.c.
294 * xfns.c (unwind_create_frame_1, Fx_create_frame):
295 * window.c (run_window_configuration_change_hook)
296 (syms_of_window): Callers changed.
298 2012-03-11 Chong Yidong <cyd@gnu.org>
300 * keymap.c (Fkey_description): Doc fix (Bug#9700).
302 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
304 2012-03-10 Chong Yidong <cyd@gnu.org>
306 * frame.c (other_visible_frames): Don't assume the selected frame
307 is visible (Bug#10955).
309 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
311 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
313 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
315 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
316 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
319 2012-03-03 Glenn Morris <rgm@gnu.org>
321 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
323 2012-03-02 Eli Zaretskii <eliz@gnu.org>
325 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
326 position past the first glyph_row that ends at ZV. (Bug#10902)
327 (redisplay_window, next_element_from_string): Fix typos in
329 (redisplay_window): Pass to move_it_vertically the margin in
330 pixels, not in screen lines.
332 2012-03-02 Glenn Morris <rgm@gnu.org>
334 * buffer.c (buffer-list-update-hook): Doc fix.
336 2012-02-29 Eli Zaretskii <eliz@gnu.org>
338 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
339 push_it before setting up the iterator for the first overlay
340 string, even if we have an empty string loaded.
341 (next_overlay_string): If there's an empty string on the iterator
342 stack, pop the stack. (Bug#10903)
344 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
346 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
347 Suggested by Stefan Monnier in
348 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
349 * alloc.c (widen_to_Lisp_Object): New static function.
350 (mark_memory): Also mark Lisp_Objects by fetching pointer words
351 and widening them to Lisp_Objects. This would work even if
352 USE_LSB_TAG is defined and wide integers are used, which might
353 happen in a future version of Emacs.
355 2012-02-25 Chong Yidong <cyd@gnu.org>
357 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
360 * xselect.c (Fx_selection_exists_p): Doc fix.
361 (x_clipboard_manager_save_all): Print an informative message
362 before saving to clipboard manager.
364 2012-02-24 Chong Yidong <cyd@gnu.org>
366 * keyboard.c (process_special_events): Handle all X selection
367 requests in kbd_buffer, not just the next one (Bug#8869).
369 2012-02-23 Chong Yidong <cyd@gnu.org>
371 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
372 call when setting menu-bar-lines and tool-bar-lines parameters.
373 (unwind_create_frame_1): New helper function.
375 * window.c (inhibit_window_configuration_change_hook): New var.
376 (run_window_configuration_change_hook): Obey it.
377 (syms_of_window): Initialize it.
379 2012-02-22 Chong Yidong <cyd@gnu.org>
381 * xterm.c (x_draw_image_relief): Add missing type check for
382 Vtool_bar_button_margin (Bug#10743).
384 2012-02-21 Chong Yidong <cyd@gnu.org>
386 * fileio.c (Vfile_name_handler_alist): Doc fix.
388 * buffer.c (Fget_file_buffer): Protect against invalid file
389 handler return value.
391 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
393 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
394 when computing $valmask.
396 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
397 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
398 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
399 It's useless in that case, and it can cause problems on hosts
400 that allocate halves of EMACS_INT values separately.
401 Reported by Dan Horák. Diagnosed by Andreas Schwab in
402 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
403 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
404 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
405 it avoids undefined behavior on hosts where shifting right by more
406 than the word width has undefined behavior.
408 2012-02-19 Chong Yidong <cyd@gnu.org>
410 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
411 (Funhandled_file_name_directory, Ffile_name_as_directory)
412 (Fdirectory_file_name, Fexpand_file_name)
413 (Fsubstitute_in_file_name): Protect against invalid file handler
414 return values (Bug#10845).
416 2012-02-18 Eli Zaretskii <eliz@gnu.org>
418 * .gdbinit (pitx): Fix incorrect references to fields of the
421 2012-02-17 Chong Yidong <cyd@gnu.org>
423 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
425 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
427 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
428 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
430 2012-02-15 Chong Yidong <cyd@gnu.org>
432 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
433 marked as special. Also, starting docstrings with * is obsolete.
435 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
437 * gnutls.c (emacs_gnutls_write): Fix last change.
439 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
441 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
444 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
446 * keymap.c (Fsingle_key_description): Handle char ranges.
448 2012-02-12 Chong Yidong <cyd@gnu.org>
450 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
451 as that creates a dangerous corner case.
453 * window.c (Fdelete_window_internal): Invalidate the mouse
454 highlight (Bug#9904).
456 2012-02-12 Glenn Morris <rgm@gnu.org>
458 * xselect.c (Fx_own_selection_internal)
459 (Fx_get_selection_internal, Fx_disown_selection_internal)
460 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
461 * nsselect.m (Fx_own_selection_internal)
462 (Fx_disown_selection_internal, Fx_selection_exists_p)
463 (Fx_selection_owner_p, Fx_get_selection_internal):
464 Sync docs and argument specs with the xselect.c versions.
466 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
468 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
470 2012-02-11 Eli Zaretskii <eliz@gnu.org>
472 * w32select.c (Fx_selection_exists_p): Sync doc string and
473 argument list with xselect.c. (Bug#10783)
475 * w16select.c (Fx_selection_exists_p): Sync doc string and
476 argument list with xselect.c. (Bug#10783)
478 2012-02-10 Glenn Morris <rgm@gnu.org>
480 * fns.c (Fsecure_hash): Doc fix.
482 2012-02-09 Kenichi Handa <handa@m17n.org>
484 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
486 2012-02-07 Chong Yidong <cyd@gnu.org>
488 * buffer.c (Fbuffer_local_variables)
489 (buffer_lisp_local_variables): Handle unbound vars correctly;
490 don't let Qunbound leak into Lisp.
492 2012-02-07 Glenn Morris <rgm@gnu.org>
494 * image.c (Fimagemagick_types): Doc fix.
496 * image.c (imagemagick-render-type): Change it from a lisp object
497 to an integer. Move the doc here from the lisp manual.
498 Treat all values not equal to 0 the same.
500 2012-02-06 Chong Yidong <cyd@gnu.org>
502 * doc.c (store_function_docstring): Avoid applying docstring of
503 alias to base function (Bug#2603).
505 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
507 * .gdbinit (pp1, pv1): Remove redundant defines.
510 2012-02-04 Chong Yidong <cyd@gnu.org>
512 * nsterm.m: Declare a global (Bug#10694).
514 2012-02-04 Eli Zaretskii <eliz@gnu.org>
516 * w32.c (get_emacs_configuration_options):
517 Include --enable-checking, if specified, in the return value.
519 2012-02-04 Martin Rudalics <rudalics@gmx.at>
521 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
522 after rounding frame sizes. (Bug#9723)
524 2012-02-04 Eli Zaretskii <eliz@gnu.org>
526 * keyboard.c (adjust_point_for_property): Don't position point
527 before BEGV. (Bug#10696)
529 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
531 Handle overflow when computing char display width (Bug#9496).
532 * character.c (char_width): Return EMACS_INT, not int.
533 (char_width, c_string_width): Check for overflow when
534 computing the width; this is possible now that individual
535 characters can have unbounded width. Problem introduced
536 by merge from Emacs 23 on 2012-01-19.
538 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
540 * dbusbind.c (Fdbus_register_method): Mention the return value
541 :ignore in the docstring.
543 2012-02-02 Glenn Morris <rgm@gnu.org>
545 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
547 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
548 Unconditionally set to t. (Bug#10673)
549 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
550 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
551 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
553 2012-02-02 Kenichi Handa <handa@m17n.org>
555 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
556 0, do not call append_composite_glyph.
558 2012-02-02 Kenichi Handa <handa@m17n.org>
560 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
562 (x_produce_glyphs): If the component of a composition is a null
563 string, set it->pixel_width to 1 to avoid zero-width glyph.
565 2012-02-01 Eli Zaretskii <eliz@gnu.org>
567 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
568 first 2 arguments are identical. This makes inserting large
569 output from a subprocess an order of magnitude faster on
570 MS-Windows, where all sbrk'ed memory is always contiguous.
572 2012-01-31 Glenn Morris <rgm@gnu.org>
574 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
575 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
576 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
578 2012-01-29 Glenn Morris <rgm@gnu.org>
580 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
582 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
584 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
586 2012-01-28 Chong Yidong <cyd@gnu.org>
588 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
590 2012-01-26 Chong Yidong <cyd@gnu.org>
592 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
594 * search.c (Fsearch_forward, Fsearch_backward): Document negative
595 repeat counts (Bug#10507).
597 2012-01-26 Glenn Morris <rgm@gnu.org>
599 * lread.c (syms_of_lread): Doc fix.
601 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
603 * coding.c (encode_designation_at_bol): Change return value to
606 2012-01-25 Chong Yidong <cyd@gnu.org>
608 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
610 2012-01-21 Chong Yidong <cyd@gnu.org>
612 * floatfns.c (Fcopysign): Make the second argument non-optional,
613 since nil is not allowed anyway.
615 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
617 * process.c (read_process_output): Use p instead of XPROCESS (proc).
618 (send_process): Likewise.
620 2012-01-19 Martin Rudalics <rudalics@gmx.at>
622 * window.c (save_window_save, Fcurrent_window_configuration)
623 (Vwindow_persistent_parameters): Do not use Qstate.
626 2012-01-19 Kenichi Handa <handa@m17n.org>
628 * character.c (char_width): New function.
629 (Fchar_width, c_string_width, lisp_string_width):
630 Use char_width (Bug#9496).
632 2012-01-16 Martin Rudalics <rudalics@gmx.at>
634 * window.c (Vwindow_persistent_parameters): New variable.
635 (Fset_window_configuration, save_window_save): Handle persistent
638 2012-01-14 Eli Zaretskii <eliz@gnu.org>
640 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
641 thrashing the stack of the thread. (Bug#9087)
643 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
645 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
647 2012-01-11 Eli Zaretskii <eliz@gnu.org>
649 * xdisp.c (rows_from_pos_range): Handle the case where the
650 highlight ends on a newline. (Bug#10464)
651 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
652 he end column for display of highlight that ends on a newline
655 2012-01-11 Glenn Morris <rgm@gnu.org>
657 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
658 from load-path also when installation-directory is nil. (Bug#10208)
660 2012-01-10 Glenn Morris <rgm@gnu.org>
662 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
664 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
665 Update template values to be closer to their typical values these days.
667 2012-01-09 Eli Zaretskii <eliz@gnu.org>
669 * xdisp.c (rows_from_pos_range): Accept additional argument
670 DISP_STRING, and accept any glyph in a row whose object is that
671 string as eligible for mouse highlight. Fixes mouse highlight of
672 display strings from overlays. (Bug#10464)
674 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
676 emacs: fix an auto-save permissions race condition (Bug#10400)
677 * fileio.c (auto_saving_dir_umask): New static var.
678 (Fmake_directory_internal): Use it.
679 (do_auto_save_make_dir): Set it, instead of invoking chmod after
680 creating the directory. The old code temporarily assigns
681 too-generous permissions to the directory.
682 (do_auto_save_eh): Clear it.
683 (Fdo_auto_save): Catch all errors, not just file errors, so
684 that the var is always cleared.
686 2012-01-07 Eli Zaretskii <eliz@gnu.org>
688 * search.c (scan_buffer): Pass character positions to
689 know_region_cache, not byte positions. (Bug#6540)
691 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
693 * w32.c (sys_rename): Report EXDEV when rename of a directory
694 fails because the target is on another logical disk. (Bug#10284)
696 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
698 * xterm.c (x_embed_request_focus): New function.
700 * xterm.h: Add prototype.
702 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
704 2012-01-05 Glenn Morris <rgm@gnu.org>
706 * emacs.c (emacs_copyright): Update short copyright year to 2012.
708 2012-01-01 Eli Zaretskii <eliz@gnu.org>
710 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
711 Load gnutls_transport_set_lowat only if GnuTLS version is below
713 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
714 GnuTLS versions below 2.11.1.
716 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
718 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
719 to the doc string advising against its use for altering the way
720 windows are scrolled.
722 2011-12-28 Kenichi Handa <handa@m17n.org>
724 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
725 coding-system ASCII compatible only when it does not produce BOM
726 on encoding (Bug#10383).
728 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
730 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
732 (create_and_show_popup_menu): Always use menu_position_func for
735 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
737 * callint.c (Fcall_interactively): Don't truncate prompt string.
739 2011-12-23 Eli Zaretskii <eliz@gnu.org>
741 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
742 property that ends at ZV, so that the bidi iteration could be
743 resumed from there (after widening). (Bug#10360)
745 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
747 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
749 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
751 * nsterm.m (x_free_frame_resources):
752 Release f->output_data.ns->miniimage.
753 (ns_index_color): Fix indentation. Do not retain
754 color_table->colors[i].
756 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
759 * nsfns.m (x_set_background_color): Assign return value from
760 ns_index_color to face-background instead of NSColor*.
761 (ns_implicitly_set_icon_type): Fix indentation.
762 Change assignment in for loop to comparison.
764 * emacs.c (ns_pool): New variable.
765 (main): Assign ns_pool.
766 (Fkill_emacs): Call ns_release_autorelease_pool.
768 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
769 autorelease fdesc, release fdAttrs and tdict.
770 (ns_get_covering_families): Release charset.
771 (ns_findfonts): Release NSFontDescriptor created with new.
772 (ns_uni_to_glyphs): Fix indentation.
773 (setString): Release attrStr before assigning new value.
775 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
777 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
779 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
780 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
782 2011-12-18 David Reitter <reitter@cmu.edu>
784 * nsterm.m (ns_term_init): Subscribe for notifications
785 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
786 to method trackingNotification in EmacsMenu.
788 * nsmenu.m (trackingMenu): New variable.
789 (trackingNotification): New method (from Aquamacs).
790 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
791 from Aquamacs (Bug#7030).
793 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
795 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
796 (symbol_to_nsstring): Fix indentation.
797 (ns_symbol_to_pb): New function.
798 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
799 (Fns_rotate_cut_buffers_internal): Remove.
800 (Fns_store_selection_internal): Rename from
801 Fns_store_cut_buffer_internal.
802 (ns_get_foreign_selection, Fx_own_selection_internal)
803 (Fx_disown_selection_internal, Fx_selection_exists_p)
804 (Fns_get_selection_internal, Fns_store_selection_internal):
805 Use ns_symbol_to_pb and check if return value is nil.
806 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
807 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
808 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
809 renamed to Sns_store_selection_internal.
810 (ns_handle_selection_request): Move code to Fx_own_selection_internal
811 and remove this function.
812 (ns_handle_selection_clear): Remove, never used.
813 (Fx_own_selection_internal): Move code from ns_handle_selection_request
816 2011-12-17 Ken Brown <kbrown@cornell.edu>
818 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
819 GID is unknown (Bug#10257).
821 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
823 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
824 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
825 which caused a build failure on GNU/Linux IA-64. This problem was
826 introduced by my 2011-10-07 patch.
828 2011-12-15 Juri Linkov <juri@jurta.org>
830 * image.c (imagemagick_error): New function. (Bug#10112)
831 (imagemagick_load_image): Comment out `MagickSetResolution' call.
832 Use `imagemagick_error' where ImageMagick functions return
834 (Fimagemagick_types): Add `Fnreverse' to return the list in the
837 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
839 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
840 fill background (Bug#8992).
842 2011-12-13 Martin Rudalics <rudalics@gmx.at>
844 * window.c (Vwindow_combination_resize)
845 (Vwindow_combination_limit): Use t instead of non-nil in
847 (Vrecenter_redisplay): Add first sentence of doc-string on
849 (Frecenter): Fix doc-string typo.
851 2011-12-11 Kenichi Handa <handa@m17n.org>
853 * coding.c (Funencodable_char_position): Pay attention to the
854 buffer text relocation (Bug#9389).
856 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
858 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
859 gtk_init (Bug#10100).
861 2011-12-10 Eli Zaretskii <eliz@gnu.org>
863 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
864 IT->string is nil. (Bug#10263)
866 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
868 * nsterm.h (x_free_frame_resources): Declare.
870 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
871 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
873 * nsterm.h (ns_get_defaults_value): Declare.
875 * nsterm.m (ns_default): Call ns_get_defaults_value.
877 2011-12-09 Eli Zaretskii <eliz@gnu.org>
879 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
882 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
884 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
885 that where the value of an _OBJC_* symbol points to is in the .bss
888 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
890 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
891 after the loop to call ccl_driver at least once (Bug#8619).
893 2011-12-08 Kenichi Handa <handa@m17n.org>
895 * ftfont.c (get_adstyle_property): Fix previous change
898 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
900 * w32.c (init_environment): If no_site_lisp, remove site-lisp
901 dirs from the default value of EMACSLOADPATH (bug#10208).
903 2011-12-07 Glenn Morris <rgm@gnu.org>
905 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
906 installation and source directories as well. (Bug#10208)
908 2011-12-06 Chong Yidong <cyd@gnu.org>
910 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
912 2011-12-06 Glenn Morris <rgm@gnu.org>
914 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
915 as an error, not just -1. (Bug#10217)
917 2011-12-05 Chong Yidong <cyd@gnu.org>
919 * keyboard.c (process_special_events): New function.
920 (swallow_events, Finput_pending_p): Use it (Bug#10195).
922 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
924 * coding.c (encode_designation_at_bol): Don't use uninitialized
925 local variable (Bug#9318).
927 2011-12-05 Kenichi Handa <handa@m17n.org>
929 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
930 return Qnil (Bug#8046, Bug#10193).
932 2011-12-05 Kenichi Handa <handa@m17n.org>
934 * coding.c (encode_designation_at_bol): New args charbuf_end and
935 dst. Return the number of produced bytes. Callers changed.
936 (coding_set_source): Return how many bytes coding->source was
938 (coding_set_destination): Return how many bytes
939 coding->destination was relocated.
940 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
941 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
943 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
945 * coding.c (CODING_CHAR_CHARSET_P): New macro.
946 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
949 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
951 The following changes are to fix Bug#9318.
953 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
954 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
955 (encode_coding_iso_2022, encode_coding_sjis)
956 (encode_coding_big5, encode_coding_charset): Use the above macros.
958 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
960 * lisp.h (process_quit_flag): Fix external declaration.
962 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
964 Don't macro-inline non-performance-critical code.
965 * eval.c (process_quit_flag): New function.
966 * lisp.h (QUIT): Use it.
968 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
970 * nsfns.m (get_geometry_from_preferences): New function.
971 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
973 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
975 * emacs.c (Qkill_emacs): Define.
976 (syms_of_emacs): Initialize it.
977 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
978 Qquit_flag to `kill-emacs' instead.
979 (quit_throw_to_read_char): Add parameter `from_signal'.
980 All callers changed. Call Fkill_emacs if requested and safe.
981 * lisp.h (QUIT): Call Fkill_emacs if requested.
983 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
985 * widget.c (update_wm_hints): Return if wmshell is null.
986 (widget_update_wm_size_hints): New function.
988 * widget.h (widget_update_wm_size_hints): Declare.
990 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
991 widget_update_wm_size_hints (Bug#10104).
993 2011-12-03 Eli Zaretskii <eliz@gnu.org>
995 * xdisp.c (handle_invisible_prop): If the invisible text ends just
996 before a newline, prepare the bidi iterator for consuming the
997 newline, and keep the current paragraph direction. (Bug#10183)
998 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1000 2011-12-02 Juri Linkov <juri@jurta.org>
1002 * search.c (Fword_search_regexp): New Lisp function created from
1003 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1004 (Fword_search_backward, Fword_search_forward)
1005 (Fword_search_backward_lax, Fword_search_forward_lax):
1006 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1007 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1009 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1011 * fileio.c (Finsert_file_contents): Move after-change-function call
1012 to before the "handled:" label, since all "goto handled" appear in
1013 cases where the *-change-functions have already been properly called
1016 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1018 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1019 waiting for input. (Bug#10169)
1021 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1023 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1024 verifies glyph row's hash code--we have just reallocated the
1025 glyphs, so their contents can be complete garbage. (Bug#10164)
1027 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1029 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1031 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1033 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1034 attributes are tested _before_ calling verify_row_hash, to protect
1035 against GCC re-ordering of the tests. (Bug#10164)
1037 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1039 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1041 * xterm.c (handle_one_xevent): Only set async_visible and friends
1042 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1043 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1044 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1046 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1048 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1049 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1050 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1051 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1052 All uses changed to use GCPRO1 etc.
1053 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1054 Revert to old implementation (i.e., before 2011-03-11).
1056 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1058 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1059 of scroll runs so as to avoid assigning disabled bogus rows and
1060 unnecessary graphics copy operations.
1062 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1064 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1065 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1066 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1067 (malloc, free, realloc, calloc): Redirect to e_* only when
1070 * lisp.h (GCTYPEBITS): Move before first use.
1071 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1072 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1073 this macro definition.
1075 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1078 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1080 * gtkutil.c (xg_create_frame_widgets):
1081 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1082 present with Gtk+ 2.0.
1084 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1086 * fileio.c (Finsert_file_contents): Undo previous change; see
1087 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1089 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1091 Rename locals to avoid shadowing.
1092 * fileio.c (Finsert_file_contents):
1093 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1094 * process.c (wait_reading_process_output):
1095 Rename inner 'proc' to 'p' to avoid shadowing.
1096 Indent for consistency with usual Emacs style.
1098 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1100 * xdisp.c (redisplay_window): If cursor row is not fully visible
1101 after recentering, and scroll-conservatively is set to a large
1102 number, scroll window by a few more lines to make the cursor fully
1103 visible and out of scroll-margin. (Bug#10105)
1104 (start_display): Don't move to the next line if the display should
1105 start at a newline that is part of a display vector or an overlay
1108 2011-11-24 Juri Linkov <juri@jurta.org>
1110 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1111 after the `MagickPingImage' call. (Bug#10112)
1113 2011-11-23 Chong Yidong <cyd@gnu.org>
1115 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1117 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1119 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1120 making another buffer current. (Bug#10114)
1122 2011-11-23 Glenn Morris <rgm@gnu.org>
1124 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1126 2011-11-23 Chong Yidong <cyd@gnu.org>
1128 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1129 using it (Bug#5984).
1131 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1133 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1134 and header-lines, as they don't have one computed for them.
1137 * .gdbinit (prow): Make displayed values more self-explaining.
1138 Add row's hash code.
1140 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1142 * process.c (wait_reading_process_output): Fix asynchrounous
1143 GnuTLS socket handling on some versions of the GnuTLS library.
1144 (wait_reading_process_output): Add comment and URL.
1146 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1148 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1150 2011-11-21 Chong Yidong <cyd@gnu.org>
1152 * window.c (Fnext_window, Fprevious_window): Doc fix.
1154 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1156 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1158 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1160 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1162 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1164 * window.c (Fset_window_combination_limit): Rename argument
1166 (Vwindow_combination_limit): Remove "status" from doc-string.
1168 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1170 * m/ibms390.h: Remove.
1171 * m/ibms390x.h: Don't include "ibms390.h".
1173 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1175 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1176 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1178 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1180 * casetab.c (Fset_case_table):
1181 * charset.c (Fcharset_after): Fix typos.
1183 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1185 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1186 Otherwise, valgrind does not work on some platforms.
1187 Problem reported by Andreas Schwab in
1188 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1189 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1190 is set, removing the need for VIRT_ADDRESS_VARIES.
1191 (PURE_P): Use a more-efficient implementation that needs just one
1192 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1193 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1194 to 4 (xorl, subq, cmpq, setbe).
1195 * alloc.c (pure): Always extern now, since that's the
1196 VIRT_ADDR_VARIES behavior.
1197 (PURE_POINTER_P): Use a single comparison, not two, for
1198 consistency with the new puresize.h.
1199 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1200 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1201 Remove VIRT_ADDR_VARIES no longer needed.
1203 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1205 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1206 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1207 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1208 behave as if the cursor position were at the window margin.
1210 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1211 and the cursor position is out of bounds, behave as if the cursor
1212 position were at the window margin. (Bug#10075)
1214 2011-11-18 Chong Yidong <cyd@gnu.org>
1216 * window.c (Fwindow_combination_limit): Make first argument
1217 non-optional, since it is meaningless for live windows like the
1220 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1222 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1224 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1226 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1227 (graft_intervals_into_buffer): Simplify.
1229 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1231 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1232 hash values of the two rows.
1233 (copy_row_except_pointers): Preserve the used[] arrays and the
1234 hash values of the two rows. (Bug#10035)
1235 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1237 * xdisp.c (row_hash): New function, body extracted from
1238 compute_line_metrics.
1239 (compute_line_metrics): Call row_hash, instead of computing the
1242 * dispnew.c (verify_row_hash): Call row_hash for computing the
1243 hash code of a row, instead of duplicating code from xdisp.c.
1245 * dispextern.h (row_hash): Add prototype.
1247 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1249 * frame.c (delete_frame): Don't delete the terminal when the last
1250 X frame is closed if emacs is built with GTK toolkit.
1252 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1254 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1256 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1258 * window.c (Vwindow_splits): Rename to
1259 Vwindow_combination_resize. Suggested by Juri Linkov.
1260 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1263 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1265 * nsfns.m (Fns_font_name):
1266 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1268 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1270 * window.h (window): Rename slot "nest" to "combination_limit".
1271 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1272 (Fset_window_nest): Rename to Fset_window_combination_limit.
1273 (Vwindow_nest): Rename to Vwindow_combination_limit.
1274 (recombine_windows, make_parent_window, make_window)
1275 (Fsplit_window_internal, saved_window)
1276 (Fset_window_configuration, save_window_save): Rename all
1277 occurrences of window_nest to window_combination_limit.
1279 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1281 * image.c (imagemagick_load_image): Fix typo.
1283 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1285 * xdisp.c (display_line): Move the call to
1286 highlight_trailing_whitespace before the call to
1287 compute_line_metrics, since the latter needs to see the final
1288 faces of all the glyphs to compute ROW's hash value.
1289 Fixes assertion violations in row_equal_p. (Bug#10035)
1291 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1293 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1294 just return (bug#10044).
1296 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1298 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1299 with user-defined heap size. Bump the default size of the temacs
1300 heap to 27MB, to avoid memory warning when running temacs.
1301 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1303 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1304 current_matrix and desired_matrix. (Bug#9990)
1305 (verify_row_hash) [XASSERTS]: New function.
1306 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1307 that the hash value of glyph rows is correct.
1309 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1311 * window.h (window): Remove splits slot.
1312 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1313 (Fdelete_other_windows_internal, make_parent_window)
1314 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1315 (Fset_window_configuration, save_window_save): Don't deal with
1316 split status of windows.
1317 (saved_window): Remove splits slot.
1318 (Vwindow_splits): Rewrite doc-string.
1320 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1322 * xfns.c (unwind_create_frame):
1323 * nsfns.m (unwind_create_frame):
1324 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1325 Vframe_list (Bug#9999).
1327 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1329 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1331 2011-11-11 Kenichi Handa <handa@m17n.org>
1333 * callproc.c (Fcall_process): Set the member dst_multibyte of
1336 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1338 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1339 avoid a crash (bug#9496).
1341 2011-11-09 Chong Yidong <cyd@gnu.org>
1343 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1344 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1346 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1348 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1350 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1352 Avoid some portability problems by eschewing 'extern inline' functions.
1353 The trivial performance wins aren't worth the portability hassles; see
1354 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1356 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1357 (window_box_width, window_box_left, window_box_left_offset)
1358 (window_box_right, window_box_right_offset): Undo previous change,
1359 by removing the "extern"s.
1360 * intervals.c (adjust_intervals_for_insertion)
1361 (adjust_intervals_for_deletion): Undo previous change,
1362 making these static again.
1363 (offset_intervals, temp_set_point_both, temp_set_point)
1364 (copy_intervals_to_string): No longer inline.
1365 * xdisp.c (window_text_bottom_y, window_box_width)
1366 (window_box_height, window_box_left_offset)
1367 (window_box_right_offset, window_box_left, window_box_right)
1368 (window_box): No longer inline.
1370 2011-11-08 Chong Yidong <cyd@gnu.org>
1372 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1373 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1374 Signal an error if not a live window.
1375 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1376 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1378 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1380 * lisp.h (syms_of_abbrev): Remove declaration.
1381 Reported by CHENG Gao <chenggao@royau.me>.
1383 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1385 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1386 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1387 of temacs in GUI mode.
1389 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1391 * window.h: Declare delete_all_child_windows instead of
1392 delete_all_subwindows.
1393 * window.c (Fwindow_nest, Fset_window_nest)
1394 (Fset_window_new_total, Fset_window_new_normal)
1395 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1396 (delete_all_subwindows): Rename to delete_all_child_windows.
1397 (Fdelete_other_windows_internal, Fset_window_configuration):
1398 Call delete_all_child_windows instead of delete_all_subwindows.
1399 * frame.c (delete_frame): Call delete_all_child_windows instead
1400 of delete_all_subwindows.
1402 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1404 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1405 This is also needed for porting to any host where GC_MARK_STACK is
1406 not GC_MAKE_GCPROS_NOOPS.
1407 (which_symbols): Use it.
1409 2011-11-07 Kenichi Handa <handa@m17n.org>
1411 * coding.c (coding_set_destination): Check coding->src_pos only
1412 when coding->src_object is a buffer (bug#9910).
1414 * process.c (send_process): Set the member src_multibyte of coding
1415 to 0 (bug#9911) when sending a unibyte text.
1417 * callproc.c (Fcall_process): Set the member src_multibyte of
1418 process_coding to 0 (bug#9912).
1420 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1422 * xmenu.c (cleanup_widget_value_tree): New function.
1423 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1424 calling free_menubar_widget_value_tree directly (Bug#9830).
1426 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1428 Fix some portability problems with 'inline'.
1429 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1430 (window_box_width, window_box_left, window_box_left_offset)
1431 (window_box_right, window_box_right_offset): Declare extern.
1432 Otherwise, these inline functions do not conform to C99 and
1433 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1434 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1435 * intervals.c (adjust_intervals_for_insertion)
1436 (adjust_intervals_for_deletion): Now extern, because otherwise the
1437 extern inline functions 'offset_intervals' couldn't refer to it.
1438 (static_offset_intervals): Remove.
1439 (offset_intervals): Rewrite using the old contents of
1440 static_offset_intervals. The old version didn't conform to C99
1441 because an extern inline function contained a reference to an
1442 identifier with static linkage.
1444 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1446 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1449 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1451 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1452 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1453 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1454 return Qleft_to_right.
1456 2011-11-06 Chong Yidong <cyd@gnu.org>
1458 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1459 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1460 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1461 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1462 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1463 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1464 (Fwindow_vscroll): Doc fix.
1465 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1466 argument, since it makes no sense to pass a live window and for
1467 consistency with window-child.
1469 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1471 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1474 2011-11-05 Jason Rumney <jasonr@gnu.org>
1476 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1477 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1479 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1480 bitwise arithmetic preventing use of unicode-sip and non-truetype
1483 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1485 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1488 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1489 initialization code to keep similarity to xfns.c after changes
1492 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1494 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1495 (unwind_create_frame): New function (Bug#9943).
1496 (Fx_create_frame): Restructure code to be more similar to the one in
1497 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1498 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1499 Move terminal->reference_count++ just before making the frame official
1502 * nsterm.m (x_free_frame_resources): New function.
1503 (x_destroy_window): Move code to x_free_frame_resources.
1505 * xfns.c (unwind_create_frame): Fix comment.
1506 (Fx_create_frame, x_create_tip_frame):
1507 Move terminal->reference_count++ just before making the frame
1508 official. Move initialization of image_cache_refcount and
1509 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1511 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1513 Support MSVC build with newer versions of Visual Studio.
1514 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1515 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1518 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1519 which are not supported by MSVC.
1520 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1521 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1523 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1525 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1527 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1529 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1531 Support MSVC build with newer versions of Visual Studio.
1532 * w32.c: Don't include w32api.h for MSVC.
1533 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1535 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1536 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1537 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1538 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1540 (alloca) [_MSC_VER]: Define to _alloca.
1542 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1544 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1546 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1548 * xdisp.c (note_mouse_highlight): If either of
1549 previous/next-single-property-change returns nil, treat that as
1550 the beginning or the end of the buffer. (Bug#9955)
1552 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1554 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1555 label is not null (Bug#9951).
1556 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1559 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1561 * window.c (Fwindow_body_size): Mention in the doc string that the
1562 return value is in frame's canonical units. (Bug#9949)
1564 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1566 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1568 * w32fns.c (unwind_create_frame): If needed, free the glyph
1569 matrices of the partially constructed frame. (Bug#9943)
1570 * xfns.c (unwind_create_frame): Likewise.
1572 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1574 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1575 Don't stop backward scan on the continuation glyph, even though
1576 its CHARPOS is positive.
1577 (mouse_face_from_buffer_pos, note_mouse_highlight):
1578 Rename cover_string to disp_string.
1580 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1582 * window.c (temp_output_buffer_show): Don't use
1583 Vtemp_buffer_show_specifiers.
1584 (Vtemp_buffer_show_specifiers): Remove unused variable.
1586 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1588 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1589 past the beginning of the current glyph matrix.
1591 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1593 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1594 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1595 HAVE_GTK3 (Bug#9869).
1597 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1598 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1600 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1602 * xterm.c: Declare x_handle_net_wm_state to return int.
1603 (handle_one_xevent): Check if we are iconified but don't have
1604 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1605 (get_current_wm_state): Return non-zero if not hidden,
1606 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1607 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1608 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1609 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1611 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1613 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1614 so that this new function doesn't get optimized away by a
1615 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1617 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1619 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1621 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1623 Fix the `xbytecode' command.
1624 * .gdbinit (xprintbytestr): New command.
1625 (xwhichsymbols): Rename from `which'; all callers changed.
1626 (xbytecode): Print the byte-code string as well.
1628 2011-10-29 Kim Storm <storm@cua.dk>
1630 * alloc.c (which_symbols): New function.
1632 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1634 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1637 2011-10-29 Glenn Morris <rgm@gnu.org>
1639 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1640 Not clear what it was for, and it causes various bugs. (Bug#9839)
1642 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1644 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1645 possible random value that matches one of those tested as
1646 condition to clear the mouse face.
1648 2011-10-28 Chong Yidong <cyd@gnu.org>
1650 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1652 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1654 * window.c (make_window): Initialize phys_cursor_on_p.
1656 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1658 * lisp.h (struct Lisp_Symbol): Update comments.
1660 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1662 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1664 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1666 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1667 <oslsachem@gmail.com> for helping to debug this.
1669 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1670 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1671 (g_b_init_get_glyph_outline_w): New static variables.
1672 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1673 (GetGlyphOutlineW_Proc): New typedefs.
1674 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1675 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1677 (w32font_open_internal, compute_metrics):
1678 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1679 instead of calling the "wide" APIs directly.
1681 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1683 * w32.h (syms_of_w32font): Add prototype.
1685 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1687 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1688 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1689 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1690 (Fmove_to_window_line): Doc fix.
1692 2011-10-27 Chong Yidong <cyd@gnu.org>
1694 * process.c (make_process): Set gnutls_state to NULL.
1696 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1697 non-NULL, regardless of GNUTLS_INITSTAGE.
1698 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1699 an error. Set process slots as soon as we allocate them.
1701 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1703 2011-10-27 Chong Yidong <cyd@gnu.org>
1705 * gnutls.c (emacs_gnutls_deinit): New function.
1706 Deallocate credentials structures as well as calling gnutls_deinit.
1707 (Fgnutls_deinit, Fgnutls_boot): Use it.
1709 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1710 (deactivate_process): Call emacs_gnutls_deinit.
1712 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1714 * image.c (x_create_x_image_and_pixmap):
1715 * w32.c (sys_rename, w32_delayed_load):
1716 * w32font.c (fill_in_logfont):
1717 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1719 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1721 * w32fns.c (w32_default_color_map): New function,
1722 extracted from Fw32_default_color_map.
1723 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1725 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1727 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1729 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1731 * keyboard.c (test_undefined): New function (bug#9751).
1732 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1734 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1736 * sysdep.c (init_sys_modes): Fix the check for the controlling
1737 terminal (Bug#6649).
1739 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1741 * dispextern.h (struct bidi_it): New member next_en_type.
1743 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1744 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1745 current character, check also for next_en_type being WEAK_EN.
1746 (bidi_resolve_weak): Don't enter the expensive loop if the current
1747 position is before next_en_pos. Record the bidi type of the first
1748 non-ET, non-BN character we find, in addition to its position.
1749 (bidi_level_of_next_char): Invalidate next_en_type when
1750 next_en_pos is over-stepped.
1752 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1754 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1755 * editfns.c: Rewrite current-time-zone so that it invokes
1756 the equivalent of (format-time-string "%Z") to get the time zone name.
1757 This fixes a bug when the time zone name contains characters that
1758 need converting from the system time locale to Emacs internal format.
1759 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1760 that patch fixed format-time-string to do the conversion, but
1761 I forgot to fix current-time-zone.
1762 (format_time_string): New function, containing most of
1763 what Fformat_time_string used to contain.
1764 (Fformat_time_string): Rewrite in terms of format_time_string.
1765 This doesn't change this function's behavior.
1766 (current-time-zone): Rewrite to use format_time_string.
1767 This fixes the bug reported by Michael Schierl in
1768 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1769 Jason Rumney's 2007-06-07 change worked around this bug, but
1771 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1773 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1775 * xdisp.c (start_display): If the character at POS is displayed
1776 via a display vector, reset IT->current.dpvec_index to zero.
1777 (try_window_reusing_current_matrix): If a line ends in a display
1778 vector or the next line starts in a display vector, continue
1779 redrawing the window even though the character position of
1780 start_row was reached.
1783 2011-10-18 Chong Yidong <cyd@gnu.org>
1785 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1786 with nobreak-char-display too.
1788 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1790 Fix part 3 of bug#9771.
1791 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1792 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1793 non-neutral characters if the current character is a paragraph
1794 separator (a.k.a. Newline). This avoids running the same
1795 expensive loop twice, once when we consume the preceding newline
1796 and the other time when the line actually needs to be displayed.
1797 Avoid the loop when we see neutrals on the base embedding level
1798 following a character whose directionality is the same as the
1799 paragraph's. This avoids running the expensive loop when a line
1800 ends in a long sequence of neutrals, like control characters.
1801 Add assertion against STRONG_AL type. Slightly rearrange code
1802 that determines the type of a neutral given the first non-neutral
1804 (bidi_level_of_next_char): Set next_en_pos to zero when
1805 invalidating its info.
1807 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1809 * xdisp.c (push_display_prop): Determine whether to record string
1810 or buffer position by IT->string, not by IT->method. Allow
1811 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1812 (move_it_vertically_backward): Don't look for character position
1813 immediately after the newline when in a continuation line.
1816 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1818 * window.c (coordinates_in_window): Rewrite and delabelize
1819 vertical border check. (Bug#5357) (Bug#9618)
1821 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1823 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1824 errors in XSetWindowBorder (bug#9310).
1826 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1828 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1829 avoid crash when xmalloc overrun checking is enabled.
1831 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1833 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1834 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1835 cursor motion with <left> and <right> arrow keys.
1837 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1838 some callers set that themselves.
1840 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1842 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1843 display string and the previous row comes from the same string and
1844 is empty. (Bug#9739) (Bug#9738)
1846 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1848 * doc.c (get_doc_string): Encode file name (bug#9735).
1850 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1852 * bidi.c (bidi_level_of_next_char):
1853 * xdisp.c (get_visually_first_element): Remove old incorrect
1854 comments regarding the Unicode Line Separator character.
1856 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1858 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1860 * alloc.c (Fgc_status): Do not access beyond zombies array
1861 boundary if nzombies > MAX_ZOMBIES.
1862 * alloc.c (dump_zombies): Add missing format specifier.
1864 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1866 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1867 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1869 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1870 Some packages use them to denote characters with modifiers.
1872 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1874 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1875 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1876 matching a pp-number. Rename parameter var to var1.
1878 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1880 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1882 2011-10-08 Glenn Morris <rgm@gnu.org>
1884 * callint.c (Fcall_interactively): Give a more explicit error for the
1885 'c' case with a non-character input. (Bug#8479)
1887 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1889 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1891 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1892 lines that are hscrolled on the left.
1894 * dispnew.c (buffer_posn_from_coords): Account for a possible
1895 presence of header-line. (Bug#4426)
1897 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1899 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1900 Don't advertise functionality which we discourage or doesn't work.
1902 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1904 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1905 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1906 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1907 this makes Emacs dump core during garbage collection on rare
1908 occasions. sizeof is obviously inferior to offsetof here, so
1909 stick with offsetof.
1910 (GC_POINTER_ALIGNMENT): New macro.
1911 (mark_memory): Omit 3rd (offset) arg; caller changed.
1912 Don't assume EMACS_INT alignment is the same as pointer alignment.
1914 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1916 * keyboard.c (read_key_sequence_remapped): New var.
1917 (read_key_sequence): Compute remapping in the right buffer.
1918 (command_loop_1): Use read_key_sequence's remapping directly.
1920 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1922 * dired.c (file_name_completion): Don't expand file name.
1923 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1924 before checking file name handler.
1926 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1927 they've been requested explicitly (bug#9591).
1929 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1931 * keymap.c (Fsingle_key_description): Use make_specified_string
1932 instead of build_string to build string from push_key_description.
1935 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1937 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1938 This fixes a Y2038 bug on 64-bit hosts.
1939 * buffer.c (reset_buffer):
1940 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1941 (Fclear_buffer_auto_save_failure):
1942 Use 0, not -1, to represent an unset failure time, since time_t
1943 might not be signed.
1945 Remove dependency on glibc malloc internals.
1946 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1947 Move back here from lisp.h, but with their new implementations.
1948 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1949 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1950 * charset.c (charset_table_init): New static var.
1951 (syms_of_charset): Use it instead of xmalloc. This removes a
1952 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1953 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1954 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1955 Move back to alloc.c.
1956 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1957 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1959 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1961 * nsterm.m (windowDidResize): Call x_set_window_size only when
1962 ns_in_resize is true. Otherwise set pixelwidth/height and
1963 call change_frame_size (Bug#9628).
1965 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1967 Port --enable-checking=all to Fedora 14 x86-64.
1968 * charset.c (syms_of_charset): Also account for glibc malloc's
1969 internal overhead when calculating the initial malloc maximum.
1971 Port --enable-checking=all to Fedora 14 x86.
1972 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1974 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1975 (overrun_check_realloc, overrun_check_free):
1976 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1977 That way, xmalloc returns a properly-aligned pointer even if
1978 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1979 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1980 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1981 into account when calculating the initial malloc maximum.
1982 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1983 Move here from alloc.c, so that charset.c can use it too.
1984 Properly align; the old code wasn't right for common 32-bit hosts
1985 when configured with --enable-checking=all.
1986 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1987 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1989 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1991 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1994 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1996 * xdisp.c (compute_display_string_end): If there's no display
1997 string at CHARPOS, return -1.
1999 * bidi.c (bidi_fetch_char): When compute_display_string_end
2000 returns a negative value, treat the character as a normal
2001 character not covered by a display string. (Bug#9624)
2003 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2005 * lread.c (Fread_from_string): Fix typo in docstring.
2007 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2009 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2010 newline, reseat the iterator instead of bidi-iterating there one
2011 character at a time. (Bug#9610)
2012 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2013 TO_CHARPOS if the bidi iterator is at base embedding level.
2015 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2017 * lread.c (readevalloop): Use correct code for NBSP.
2018 (read1): Likewise. (Bug#9608)
2020 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2022 * dbusbind.c (Fdbus_register_signal): When service is not
2023 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2025 2011-09-25 Glenn Morris <rgm@gnu.org>
2027 * buffer.c (truncate-lines): Doc fix.
2029 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2031 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2032 (Fset_window_next_buffers): Doc fix.
2034 2011-09-24 Glenn Morris <rgm@gnu.org>
2036 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2038 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2040 Fix minor problems found by static checking.
2041 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2042 * indent.c (Fvertical_motion): Fix == vs = typo.
2044 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2046 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2047 Default value is now t. Doc fix.
2049 * indent.c (Fvertical_motion): Compute and apply the overshoot
2050 logic when moving up, not only when moving down. Fix the
2051 confusing name and values of the it_overshoot_expected variable;
2052 logic changes accordingly. (Bug#9254) (Bug#9549)
2054 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2055 CHARPOS is covered by a display string which includes newlines.
2056 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2057 is covered by a display string with embedded newlines.
2059 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2061 * dbusbind.c (Fdbus_register_signal): Add match rule to
2062 Vdbus_registered_objects_table. (Bug#9581)
2063 (Fdbus_register_method, Vdbus_registered_objects_table):
2066 2011-09-24 Jim Meyering <meyering@redhat.com>
2068 do not ignore write error for any output size
2069 The previous change was incomplete.
2070 While it makes emacs --batch detect the vast majority of stdout
2071 write failures, errors were still ignored whenever the output size is
2072 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2073 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2074 && echo FAIL: ignored write error
2075 FAIL: ignored write error
2076 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2077 && echo FAIL: ignored write error
2078 FAIL: ignored write error
2079 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2081 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2083 * emacs.c (Fkill_emacs): In noninteractive mode exit
2084 non-successfully if a write error occurred on stdout. (Bug#9574)
2086 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2088 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2091 * dispextern.h (struct it): Update the comment documenting what
2094 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2096 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2097 a display string, extend search for cursor position to end of row.
2098 (find_row_edges): If the row ends in a newline from a display
2099 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2100 Handle the case of a display string with multiple newlines.
2101 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2102 non-empty line. Fixes confusing cursor motion with arrow keys at
2103 the beginning of a line that starts with whitespace.
2105 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2107 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2110 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2112 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2115 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2117 * xdisp.c (display_line): Record maximum and minimum buffer
2118 positions even if no glyphs were produced (e.g., by a zero-width
2119 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2120 buffer positions that will be removed from the glyph row because
2122 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2123 column is beyond frame width: don't subtract 1 "pixel" when
2124 computing width of the stretch.
2125 (reseat_at_next_visible_line_start): Undo the change made on
2126 2011-09-17 that saved paragraph information and restored it after
2127 the call to `reseat'. (Bug#9545)
2129 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2131 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2132 and turn window cursor on if cleared (Bug#9415).
2134 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2136 * search.c (boyer_moore): Take unibyte characters from pattern
2137 literally. (Bug#9458)
2139 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2141 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2143 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2145 Fix minor problem found by static checking.
2146 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2147 initialized, to pacify gcc -Wuninitialized.
2149 * fileio.c: Report proper errno when syscall falls.
2150 (Finsert_file_contents): Save and restore errno,
2151 so that report_file_error outputs the correct diagnostic.
2152 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2154 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2156 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2158 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2160 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2161 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2163 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2165 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2166 about the current paragraph and restore it after the call to reseat.
2168 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2169 (bidi_find_paragraph_start): Search back for paragraph beginning
2170 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2171 (bidi_move_to_visually_next): Only trigger paragraph-related
2172 computations when the last character is a newline or at EOB, not
2173 just any NEUTRAL_B. (Bug#9470)
2175 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2176 truncated lines if point is covered by a display string. (Bug#9524)
2178 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2180 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2181 (cons_to_x_long): New function.
2182 (lisp_data_to_selection_data): Use it. Correct the test for
2183 short-versus-long data; it was negated. Break out of vector
2184 loop, for efficiency, when a long datum is discovered.
2186 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2188 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2190 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2192 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2193 GCC PR/17406) by declaring this function with external scope.
2195 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2197 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2198 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2200 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2202 * editfns.c (Fformat): Correctly handle text properties on "%%".
2204 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2206 * xterm.c (x_draw_composite_glyph_string_foreground):
2207 * w32term.c (x_draw_composite_glyph_string_foreground):
2208 * term.c (encode_terminal_code):
2209 * composite.c (composition_update_it, get_composition_id):
2210 * xdisp.c (get_next_display_element)
2211 (fill_composite_glyph_string): Add comments about special meaning
2212 of TAB characters in a composition.
2214 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2216 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2217 This occurs when processing a multibyte format.
2218 Problem reported by Wolfgang Jenker.
2220 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2222 * xdisp.c (try_cursor_movement): Only check for exact match if
2223 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2225 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2227 Remove unused external symbols.
2228 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2229 * xdisp.c (calc_pixel_width_or_height): Now static.
2230 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2231 * indent.c (check_display_width):
2232 * w32term.c: Fix comment to match code.
2233 * xterm.c, xterm.h (x_catching_errors): Remove.
2235 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2237 * xselect.c: Use signed conversions more consistently (Bug#9498).
2238 (selection_data_to_lisp_data): Assume incoming selection data are
2239 signed integers, not unsigned. This is to be consistent with
2240 outgoing selection data, which was modified to use signed integers
2241 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2242 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2243 expects long, not unsigned long.
2245 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2247 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2248 computation of loop end. Reported by Johan Bockgård
2251 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2253 * frame.c (Fother_visible_frames_p): Function deleted.
2255 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2257 * indent.c (compute_motion): Process display vector front to back
2258 rather than the other way around. (Bug#2496)
2260 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2262 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2264 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2266 * minibuf.c (Fread_from_minibuffer): Doc fix.
2268 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2270 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2271 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2273 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2275 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2276 value for non-existent files.
2278 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2280 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2281 set its "size" to -1. This will set the modtime_size field of
2282 the corresponding buffer to -1, which is what
2283 verify-visited-file-modtime expects for files that do not exist.
2286 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2288 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2290 * lisp.h: ... from here. push_key_description is no longer
2291 defined in keyboard.c, so its declaration should not be in
2292 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2293 logically belongs with push_key_description.
2295 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2297 * buffer.h: Include <sys/types.h> instead of <time.h>.
2298 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2299 Problem reported by Herbert J. Skuhra.
2301 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2303 * xml.c (parse_region): Make the parsing work for
2304 non-comment-starting XML files again (bug#9144).
2306 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2308 * image.c (gif_load): Fix calculation of bottom and right corner.
2311 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2313 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2314 redisplay in small windows.
2316 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2318 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2320 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2322 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2323 Operate on live windows only.
2325 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2327 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2329 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2331 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2332 only under bidi iteration.
2334 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2336 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2338 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2340 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2341 Without this fix, the command to link temacs failed due to an
2342 undefined symbol __builtin_isnan. This is because
2343 /usr/include/iso/math_c99.h #defines isnan(x) to
2344 __builtin_isnan(x), but the bundled gcc, which identifies itself
2345 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2347 * floatfns.c (isnan): #undef, and then #define to a clone of
2349 (Fisnan): Always define, since it's always available now.
2350 (syms_of_floatfns): Always define isnan at the Lisp level.
2352 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2354 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2356 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2358 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2359 The previous code assumed that file offsets (off_t values) fit in
2360 EMACS_INT variables, which is not true on typical 32-bit hosts.
2361 The code messed up by falsely reporting buffer overflow in cases
2362 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2363 when "big" contains more than 2**29 bytes, even though this
2364 inserts just one byte and does not overflow the buffer.
2365 (Finsert_file_contents): Store file offsets as off_t
2366 values, not as EMACS_INT values. Check for overflow when
2367 converting between EMACS_INT and off_t. When checking for
2368 buffer overflow or for overlap, take the offsets into account.
2369 Don't use EMACS_INT for small values where int suffices.
2370 When checking for overlap, fix a typo: ZV was used where
2371 ZV_BYTE was intended.
2372 (Fwrite_region): Don't assume off_t fits into 'long'.
2373 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2375 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2377 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2379 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2381 sprintf-related integer and memory overflow issues (Bug#9412).
2383 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2384 (esprintf, exprintf, evxprintf): New functions.
2385 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2386 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2387 (modify_event_symbol): Do not assume that the length of
2388 name_alist_or_stem is safe to alloca and fits in int.
2389 (Fexecute_extended_command): Likewise for function name and binding.
2390 (Frecursion_depth): Wrap around reliably on integer overflow.
2391 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2392 since some callers pass EMACS_INT values.
2393 (Fsingle_key_description): Don't crash if symbol name contains more
2394 than MAX_ALLOCA bytes.
2395 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2396 (get_minibuffer): Arg is now EMACS_INT, not int.
2397 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2398 (esprintf, exprintf, evxprintf): New decls.
2399 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2401 * dbusbind.c (signature_cat): New function.
2402 (xd_signature, Fdbus_register_signal):
2403 Do not overrun buffer; instead, report string overflow.
2405 * dispnew.c (add_window_display_history): Don't overrun buffer.
2406 Truncate instead; this is OK since it's just a log.
2408 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2409 even if the time zone offset is outlandishly large.
2410 Don't mishandle offset == INT_MIN.
2412 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2413 when creating daemon; the previous buffer-overflow check was incorrect.
2415 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2416 which has the guts of the old verror function.
2418 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2419 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2421 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2422 (font_unparse_xlfd): Don't blindly alloca long strings.
2423 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2424 fits in int, when using sprintf. Use single snprintf to count
2425 length of string rather than counting it via multiple sprintfs;
2426 that's simpler and more reliable.
2427 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2428 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2429 sprintf, in case result does not fit in int.
2431 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2432 (fontset_from_font): Print it.
2434 * frame.c (tty_frame_count): Now printmax_t, not int.
2435 (make_terminal_frame, set_term_frame_name): Print it.
2436 (x_report_frame_params): In X, window IDs are unsigned long,
2437 not signed long, so print them as unsigned.
2438 (validate_x_resource_name): Check for implausibly long names,
2439 and don't assume name length fits in 'int'.
2440 (x_get_resource_string): Don't blindly alloca invocation name;
2441 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2444 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2445 (xg_check_special_colors, xg_set_geometry):
2446 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2448 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2449 Use esprintf, not sprintf, in case result does not fit in int.
2451 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2452 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2453 it as a large positive number.
2454 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2455 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2457 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2458 in case result does not fit in int.
2460 * print.c (float_to_string): Detect width overflow more reliably.
2461 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2462 buffer overrun. Don't assume list length fits in 'int'. Treat
2463 print length of 0 as 0, not as infinity; to be consistent with other
2464 uses of print length in this function. Don't overflow print length
2465 index. Don't assume hash table size fits in 'long', or that
2466 vectorlike size fits in 'unsigned long'.
2468 * process.c (make_process): Use printmax_t, not int, to format
2469 process-name gensyms.
2471 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2473 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2474 to avoid potential buffer overrun.
2476 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2477 if X resource line is longer than 512 bytes.
2479 * xfns.c (x_window): Make sprintf buffer a bit bigger
2480 to avoid potential buffer overrun.
2482 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2484 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2486 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2488 Integer overflow fixes for scrolling, etc.
2489 Without these, Emacs silently mishandles large integers sometimes.
2490 For example, "C-u 4294967297 M-x recenter" was treated as if
2491 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2493 * xdisp.c (try_window_id): Check Emacs fixnum range before
2494 converting to 'int'.
2496 * window.c (window_scroll_line_based, Frecenter):
2497 Check that an Emacs fixnum is in range before assigning it to 'int'.
2498 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2499 values converted from Emacs fixnums.
2500 (Frecenter): Don't wrap around a line count if it is out of 'int'
2501 range; instead, treat it as an extreme value.
2502 (Fset_window_configuration, compare_window_configurations):
2503 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2505 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2506 that can exceed INT_MAX. Check that EMACS_INT value is in range
2507 before assigning it to the (possibly-narrower) index.
2508 (match_limit): Don't assume that a fixnum can fit in 'int'.
2510 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2513 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2514 (Fvertical_motion): Don't wrap around LINES values that don't fit
2515 in 'int'. Instead, treat them as extreme values. This is good
2516 enough for windows, which can't have more than INT_MAX lines anyway.
2518 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2520 * Require libxml/parser.h to avoid compilation warning.
2522 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2524 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2525 since this reportedly can destroy thread storage.
2527 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2529 * syntax.c (find_defun_start): Update all cache variables if
2530 exiting early (Bug#9401).
2532 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2534 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2536 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2537 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2538 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2540 * term.c (tty_append_glyph): New function.
2541 (produce_stretch_glyph): Static function and its prototype deleted.
2543 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2546 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2548 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2549 when checking :margin (Bug#9390).
2550 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2551 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2552 so that the name doesn't mislead. All uses changed.
2554 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2556 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2559 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2561 * xdisp.c (move_it_to): Don't bail out early when reaching
2562 position beyond to_charpos, if we are scanning backwards.
2563 (move_it_vertically_backward): When DY == 0, make sure we get to
2564 the first character in the line after the newline.
2566 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2568 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2569 (ccl_driver): Do not generate an out-of-range pointer.
2570 (Fccl_execute_on_string): Remove unnecessary check for
2571 integer overflow, noted by Stefan Monnier in
2572 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2573 Remove a FIXME that didn't need fixing.
2574 Simplify the newly-introduced buffer reallocation code.
2576 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2578 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2580 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2582 Integer and memory overflow issues (Bug#9196).
2584 * doc.c (get_doc_string): Rework so that
2585 get_doc_string_buffer_size is the actual buffer size, rather than
2586 being 1 less than the actual buffer size; this makes xpalloc more
2589 * image.c (x_allocate_bitmap_record, cache_image):
2590 * xselect.c (Fx_register_dnd_atom):
2591 Simplify previous changes by using xpalloc.
2593 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2594 since either will do and ptrdiff_t is convenient with xpalloc.
2596 * charset.c (charset_table_size)
2597 (struct charset_sort_data.priority): Now ptrdiff_t.
2598 (charset_compare): Don't overflow if priorities differ greatly.
2599 (Fsort_charsets): Don't assume list length fits in int.
2600 Check for size-calculation overflow when allocating sort data.
2601 (syms_of_charset): Allocate an initial charset table that is
2602 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2604 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2606 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2607 The actual value is always <= INT_MAX, and leaving it unsigned made
2608 overflow checking harder.
2610 * dispextern.h (struct glyph_matrix.rows_allocated)
2611 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2612 with xpalloc. The values are still always <= INT_MAX.
2614 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2616 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2617 (SAFE_NALLOCA): New macro.
2619 * region-cache.c (struct boundary.pos, find_cache_boundary)
2620 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2621 (set_cache_region, invalidate_region_cache)
2622 (revalidate_region_cache, know_region_cache, region_cache_forward)
2623 (region_cache_backward, pp_cache):
2624 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2625 so that ptrdiff_t * can be passed to xpalloc.
2626 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2627 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2628 (pp_cache): Don't assume cache_len fits in int.
2629 * region-cache.h: Adjust extern decls to match.
2631 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2632 EMACS_INT, since either will do, for xpalloc.
2634 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2635 (xnmalloc, xnrealloc, xpalloc): New functions.
2637 * bidi.c (bidi_shelve_header_size): New constant.
2638 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2639 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2641 * bidi.c (bidi_cache_shrink):
2642 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2644 Don't update size of array until after memory allocation succeeds,
2645 because xmalloc/xrealloc may not return.
2646 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2647 now that we have proper integer overflow checking.
2648 (record_overlay_string, overlay_strings): Catch overflows when
2649 calculating size of overlay_str_buf.
2651 * callproc.c (Fcall_process): Check for size overflow when
2652 calculating size of args2.
2653 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2654 Normally we prefer signed values, but sticking with ptrdiff_t would
2655 require adding more-complicated checks.
2657 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2658 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2659 Redo buffer-overflow calculations to avoid integer overflow.
2660 Add a FIXME comment where memory seems to be over-allocated.
2662 * character.c (Fstring): Check for size-calculation overflow.
2664 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2665 unnecessary integer overflow. Check for size overflow.
2666 (encode_coding_object): Don't update size until xmalloc succeeds.
2668 * composite.c (get_composition_id): Check for overflow in glyph
2669 length calculations.
2671 Integer and memory overflow fixes for display code.
2672 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2673 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2674 (scrolling_window): Check for overflow in size calculations.
2675 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2676 Don't assume glyph table len fits in int.
2677 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2678 (row_table_size): Now ptrdiff_t, not int.
2679 (scrolling_window): Avoid overflow in size calculations.
2680 Don't update size until allocation succeeds.
2681 * fns.c (concat): Check for overflow in size calculations.
2682 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2683 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2684 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2686 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2687 (get_doc_string): Check for size calculation overflow.
2688 Don't update size until allocation succeeds.
2689 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2690 EMACS_INT, where ptrdiff_t will do.
2691 (Fsubstitute_command_keys): Check for string overflow.
2693 * editfns.c (set_time_zone_rule): Don't assume environment length
2695 (message_length): Now ptrdiff_t, not int.
2696 (Fmessage_box): Don't update size until allocation succeeds.
2697 Don't assume message length fits in int.
2698 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2700 * emacs.c (main): Do not reallocate argv, since there is a null at
2701 the end that can be overwritten, and this way there's no need to
2702 worry about size-calculation overflow.
2703 (sort_args): Check for size-calculation overflow.
2705 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2707 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2709 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2710 (x_set_scroll_bar_width, x_figure_window_size):
2711 Check for integer overflow.
2712 (x_set_alpha): Do not assume XINT fits in int.
2714 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2715 This is for the members text_lines, text_cols, total_lines, total_cols,
2716 where the system imposes an 'int' limit.
2718 * fringe.c (Fdefine_fringe_bitmap):
2719 Don't update size until alloc works.
2721 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2722 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2724 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2725 Check for size-calculation overflow.
2726 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2727 do, as we prefer signed integers.
2728 (id_to_widget.max_size, id_to_widget.used)
2729 (xg_store_widget_in_map, xg_remove_widget_from_map)
2730 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2731 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2732 Use and return ptrdiff_t, not int.
2733 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2734 * gtkutil.h: Change prototypes to match the above.
2736 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2737 are duplicate now that they've been promoted to lisp.h.
2738 (x_allocate_bitmap_record, x_alloc_image_color)
2739 (make_image_cache, cache_image, xpm_load):
2740 Don't update size until alloc is done.
2741 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2743 Check for size calculation overflow.
2744 (ct_colors_allocated_max): New constant.
2745 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2748 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2749 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2750 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2751 Use ptrdiff_t, not int, to count maps.
2752 (read_char_minibuf_menu_prompt): Check for overflow in size
2753 calculations. Don't update size until allocation succeeds.
2754 Redo calculations to avoid overflow.
2755 * keyboard.h: Change prototypes to match the above.
2757 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2759 (current_minor_maps): Check for size calculation overflow.
2760 * keymap.h: Change prototypes to match the above.
2762 * lread.c (read1, init_obarray): Don't update size until alloc done.
2764 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2765 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2767 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2768 Now ptrdiff_t, not int.
2769 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2770 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2772 * process.c (Fnetwork_interface_list): Check for overflow
2773 in size calculation.
2775 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2777 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2778 overflow. Don't bother calling xmalloc when xrealloc will do.
2780 * search.c (Freplace_match): Check for size calculation overflow.
2781 (Fset_match_data): Don't assume list lengths fit in 'int'.
2783 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2784 for command line length. Do not attempt to address one before the
2785 beginning of an array, as that's not portable.
2787 * term.c (max_frame_lines): Remove; unused.
2788 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2790 (encode_terminal_code, calculate_costs): Check for size
2791 calculation overflow.
2792 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2793 table lengths and related sizes. Don't update size until alloc
2794 done. Redo calculations to avoid overflow.
2795 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2797 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2798 subtracting pointers.
2799 (gobble_line): Check for overflow more carefully. Don't update size
2802 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2803 Don't update size until alloc done.
2804 Redo size calculations to avoid overflow.
2805 Check for size calculation overflow.
2806 (main) [DEBUG]: Fix typo in invoking tparam1.
2808 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2809 Use ptrdiff_t, not int, for sizes.
2810 (store_mode_line_noprop_char): Don't update size until alloc done.
2812 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2813 Use ptrdiff_t, not int, for sizes.
2814 (Finternal_make_lisp_face, cache_face):
2815 Check for size calculation overflow.
2816 (cache_face): Treat size calculation overflows as if they were
2817 memory exhaustion (the usual treatment), rather than aborting.
2819 * xfns.c (x_encode_text, x_set_name_internal)
2820 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2821 sizes, since they can exceed INT_MAX in size. Check for size
2822 calculation overflow.
2824 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2825 (xg_select): Check for size calculation overflow.
2826 Don't update size until alloc done.
2828 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2829 as sprintf is limited to int lengths.
2831 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2832 (X_LONG_MIN): New macros.
2833 Use them to make the following changes clearer.
2834 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2835 This change doesn't affect the value now, but it may help remind
2836 future maintainers not to raise the value too much later.
2837 (SELECTION_QUANTUM): Remove, replacing with ...
2838 (selection_quantum): ... new function, which avoids overflow.
2840 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2841 assumption that selection length fits in 'int'.
2842 (x_reply_selection_request, x_handle_selection_request)
2843 (x_get_window_property, receive_incremental_selection)
2844 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2845 (lisp_data_to_selection_data, clean_local_selection_data):
2846 Use ptrdiff_t, not int, to record length of selection.
2847 (x_reply_selection_request, x_get_window_property)
2848 (receive_incremental_selection, x_property_data_to_lisp):
2849 Redo calculations to avoid overflow.
2850 (x_reply_selection_request): When sending hint, ceiling it at
2851 X_LONG_MAX rather than relying on wraparound overflow to send
2853 (x_get_window_property, receive_incremental_selection)
2854 (lisp_data_to_selection_data, x_property_data_to_lisp):
2855 Check for size-calculation overflow.
2856 (x_get_window_property, receive_incremental_selection)
2857 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2858 Don't store size until memory allocation succeeds.
2859 (x_get_window_property): Plug memory leak on memory exhaustion.
2860 Don't double-block input; malloc is safe here. Don't assume 2**34
2861 - 4 fits in unsigned long. Add an xassert to check
2862 XGetWindowProperty overflow. Be more careful about overflow
2863 calculations, and distinguish size from memory overflow better.
2864 (receive_incremental_selection): When tracing, don't assume
2865 unsigned int is less than INT_MAX.
2866 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2867 harmful) conversions of unsigned short to int.
2868 (lisp_data_to_selection_data): Don't assume that integers
2869 in the range -65535 through -1 fit in an X unsigned short.
2870 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2871 result parameters unless successful. Rely on cons_to_unsigned
2872 to report problems with elements; the old code wasn't right anyway.
2873 (x_check_property_data): Check for int overflow; we cannot use
2874 a wider type due to X limits.
2875 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2877 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2879 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2880 (x_term_init): Check for size calculation overflow.
2881 (x_color_cells): Don't store size until memory allocation succeeds.
2882 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2883 Don't assume alloca size is less than MAX_ALLOCA.
2884 (x_term_init): Don't assume length fits in int (sprintf is limited
2887 Use ptrdiff_t for composition IDs.
2888 * character.c (lisp_string_width):
2889 * composite.c (composition_table_size, n_compositions)
2890 (get_composition_id, composition_gstring_from_id):
2891 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2892 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2893 * window.c (Frecenter):
2894 Use ptrdiff_t, not int, for composition IDs.
2895 * composite.c (get_composition_id): Check for integer overflow.
2896 * composite.h: Adjust prototypes to match the above changes.
2898 Use ptrdiff_t for hash table indexes.
2899 * category.c (hash_get_category_set):
2900 * ccl.c (ccl_driver):
2901 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2902 * coding.c (coding_system_charset_list, detect_coding_system):
2903 * coding.h (struct coding_system.id):
2904 * composite.c (get_composition_id, gstring_lookup_cache):
2905 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2906 * image.c (xpm_get_color_table_h):
2907 * lisp.h (hash_lookup, hash_put):
2908 * minibuf.c (Ftest_completion):
2909 Use ptrdiff_t for hash table indexes, not int (which is too
2910 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2911 32-bit --with-wide-int hosts).
2913 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2914 Add a FIXME comment about memory leaks.
2915 (syms_of_charset): Don't assume xmalloc returns.
2917 Don't assume that stated character widths fit in int.
2918 * character.c (Fchar_width, c_string_width, lisp_string_width):
2919 * character.h (CHAR_WIDTH):
2920 * indent.c (MULTIBYTE_BYTES_WIDTH):
2921 Use sanitize_char_width to avoid undefined and/or bad behavior
2922 with outlandish widths.
2923 * character.h (sanitize_tab_width): Rename from sanitize_width,
2924 now that we have two such functions. All uses changed.
2925 (sanitize_char_width): New inline function.
2927 Don't assume that tab-width fits in int.
2928 * character.h (sanitize_width): New inline function.
2929 (SANE_TAB_WIDTH): New macro.
2930 (ASCII_CHAR_WIDTH): Use it.
2931 * indent.c (sane_tab_width): Remove. All uses replaced by
2932 SANE_TAB_WIDTH (current_buffer).
2933 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2935 * fileio.c: Integer overflow issues with file modes.
2936 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2938 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2939 Remove unreachable code.
2940 (read_hex, load_charset_map_from_file): Check for integer overflow.
2942 * xterm.c: Don't go over XClientMessageEvent limit.
2943 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2944 (x_send_scroll_bar_event): Likewise. Check that the size does not
2945 exceed limits imposed by XClientMessageEvent, as well as the usual
2946 ptrdiff_t and size_t limits.
2948 * keyboard.c: Overflow, signedness and related fixes.
2949 (make_lispy_movement): Use same integer type in forward decl
2950 that is used in the definition.
2951 (read_key_sequence, keyremap_step):
2952 Change bufsize argument back to int, undoing my 2011-03-30 change.
2953 We prefer signed types, and int is wide enough here.
2954 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2955 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2956 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2957 length, not size_t. Use ptrdiff_t for index, not int.
2958 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2959 possibility of integer overflow.
2961 Overflow, signedness and related fixes for images.
2963 * dispextern.h (struct it.stack[0].u.image.image_id)
2964 (struct_it.image_id, struct image.id, struct image_cache.size)
2965 (struct image_cache.used, struct image_cache.ref_count):
2966 * gtkutil.c (update_frame_tool_bar):
2967 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2968 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2969 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2970 * nsmenu.m (update_frame_tool_bar):
2971 * xdisp.c (calc_pixel_width_or_height):
2972 * xfns.c (image_cache_refcount):
2973 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2974 on typical 64-bit hosts.
2976 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2977 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2978 Omit unnecessary casts to int.
2979 (parse_image_spec): Check that integers fall into 'int' range
2980 when the callers expect that.
2981 (image_ascent): Redo ascent calculation to avoid int overflow.
2982 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2983 (lookup_image): Remove unnecessary tests.
2984 (xbm_image_p): Locals are now of int, not EMACS_INT,
2985 since parse_image_check makes sure they fit into int.
2986 (png_load, gif_load, svg_load_image):
2987 Prefer int to unsigned where either will do.
2988 (tiff_handler): New function, combining the cores of the
2989 old tiff_error_handler and tiff_warning_handler.
2990 This function is rewritten to use vsnprintf and thereby avoid
2991 stack buffer overflows. It uses only the features of vsnprintf
2992 that are common to both POSIX and native Microsoft.
2993 (tiff_error_handler, tiff_warning_handler): Use it.
2994 (tiff_load, gif_load, imagemagick_load_image):
2995 Don't assume :index value fits in 'int'.
2996 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2997 (imagemagick_load_image): Check that crop parameters fit into
2998 the integer types that MagickCropImage accepts. Don't assume
2999 Vimagemagick_render_type has a nonnegative value. Don't assume
3000 size_t fits in 'long'.
3001 (gs_load): Use printmax_t to print the widest integers possible.
3002 Check for integer overflow when computing image height and width.
3004 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3006 * xdisp.c (redisplay_window): Don't force window start if point
3007 will be invisible in the resulting window. (Bug#9324)
3009 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3011 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3012 the display spec is of the form `(space ...)'.
3013 (handle_display_spec): Return the value returned by
3014 handle_single_display_spec, not just 1 or zero.
3015 (handle_single_display_spec): If the display spec is of the form
3016 `(space ...)', and specifies display in the text area, return 2
3018 (try_cursor_movement): Check for the need to scroll more
3019 accurately, and prefer exact match for point under bidi.
3020 Don't advance `row' beyond the last row of the window.
3022 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3023 into disp_prop; all users changed.
3025 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3026 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3027 for the text covered by the display property.
3029 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3031 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3032 Change return value to nil.
3033 (Frecord_buffer): Delete unused function.
3035 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3037 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3038 buffers, return left-to-right.
3039 (set_cursor_from_row): Consider candidate row a win if its glyph
3040 represents a newline and point is on that newline. Fixes cursor
3041 positioning on the newline at EOL of R2L text within L2R
3042 paragraph, and vice versa.
3043 (try_cursor_movement): Check continued rows, in addition to
3044 continuation rows. Fixes unwarranted scroll when point enters a
3045 continued line of R2L text within an L2R paragraph, or vice versa.
3046 (cursor_row_p): Consider the case of point being equal to
3047 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3048 from the end of a short line to the beginning of a continued line
3049 of R2L text within L2R paragraph.
3050 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3051 composed characters.
3053 * bidi.c (bidi_check_type): Use xassert.
3054 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3057 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3059 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3062 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3064 * nsfont.m (ns_otf_to_script): Fix typo.
3066 2011-08-22 Kenichi Handa <handa@m17n.org>
3068 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3069 extra slot even if the purpose is char-code-property-table.
3071 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3073 * xdisp.c (redisplay_window): When computing centering_position,
3074 account for the height of the header line. (Bug#8874)
3076 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3077 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3078 candidate is selected by the mouse, and that candidate has a
3079 composed character under the mouse.
3081 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3082 coordinates reported by pos-visible-in-window-p for a composed
3083 character in column zero.
3085 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3087 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3089 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3091 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3092 consider it a hit if to_charpos is anywhere in the range of the
3093 composed buffer positions.
3095 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3097 * image.c (gif_load): Don't assume that each subimage has the same
3098 dimensions as the base image. Handle disposal method that is
3099 "undefined" by the gif spec (Bug#9335).
3101 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3103 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3104 (Fcondition_case): Document `debug' symbol in error handler.
3106 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3108 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3109 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3110 from an Org mode buffer to a Speedbar frame.
3112 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3113 a composition, take its buffer position from IT->cmp_it.charpos.
3114 Fixes cursor positioning at the beginning of a line that begins
3115 with a composed character.
3117 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3119 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3120 character bidirectional type, use STRONG_L instead. Fixes crashes
3121 in a buffer produced by `describe-categories'.
3123 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3124 members before the level stack, so they would be saved and
3125 restored when copying iterator state. Fixes incorrect reordering
3126 around TABs covered by display properties.
3128 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3130 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3132 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3134 * eval.c (internal_condition_case, internal_condition_case_1)
3135 (internal_condition_case_2, internal_condition_case_n):
3136 Remove unnecessary aborts (Bug#9081).
3138 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3140 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3141 has no `load' handler, try opening the file locally. (Bug#9311)
3143 2011-08-16 Ken Brown <kbrown@cornell.edu>
3145 * gmalloc.c: Expand comment.
3147 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3149 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3150 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3152 2011-08-16 Ken Brown <kbrown@cornell.edu>
3154 Fix memory allocation problems in Cygwin build (Bug#9273).
3156 * unexcw.c ( __malloc_initialized): Declare external variable.
3157 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3159 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3161 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3163 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3165 [CYGWIN] (special_realloc): New function.
3166 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3167 requests to realloc storage in the static heap.
3169 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3171 * bidi.c (bidi_initialize): Remove unused local.
3173 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3176 * biditype.h: Remove file.
3177 * makefile.w32-in ($(BLD)/bidi.$(O)):
3178 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3180 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3182 * chartab.c: Improve commentary for the uniprop_table API.
3184 * bidi.c (bidi_paragraph_init): Support zero value of
3185 bidi_ignore_explicit_marks_for_paragraph_level.
3186 (bidi_initialize): Use uniprop_table instead of including
3187 biditype.h and bidimirror.h.
3189 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3190 coordinates of the iterator when restoring from ppos_it.
3193 2011-08-14 Kenichi Handa <handa@m17n.org>
3195 * process.c (create_process): Call setup_process_coding_systems
3196 after the pid of the process is set to -1 (Bug#8162).
3198 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3200 * xdisp.c (move_it_in_display_line_to): Don't invoke
3201 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3202 ppos_it. Fixes vertical cursor motion when line beginning is
3203 covered by an image. (Bug#9296)
3205 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3207 * nsterm.h (ns_run_ascript): Declare.
3208 (NSAPP_DATA2_RUNASSCRIPT): Define.
3210 * nsfns.m (as_script, as_result, as_status): New static variables.
3211 (ns_run_ascript): New function.
3212 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3213 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3214 the event loop. Get status from as_status (Bug#7276).
3216 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3217 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3218 the event loop (Bug#7276).
3220 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3222 * gnutls.c (QCgnutls_bootprop_priority)
3223 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3224 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3225 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3226 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3227 (QCgnutls_bootprop_verify_hostname_error)
3228 (QCgnutls_bootprop_callbacks_verify): Rename from
3229 Qgnutls_bootprop_..., all uses changed.
3231 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3234 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3236 * xfaces.c (Qframe_set_background_mode): Now static.
3237 * dispextern.h (Qframe_set_background_mode): Remove decl.
3239 * process.c (Fnetwork_interface_info): Declare local only if needed.
3241 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3243 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3244 (Fnetwork_interface_list): Allocate in increments of bytes instead
3245 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3246 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3248 (struct ifflag_def): notrailers is smart on OSX.
3249 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3250 Get hardware address with getifaddrs if available.
3252 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3254 * xdisp.c (iterate_out_of_display_property): xassert that
3255 IT->position is set to within IT->object's boundaries. Break from
3256 the loop as soon as EOB is reached; avoids infloops in redisplay
3257 when IT->position is set up wrongly due to some bug.
3258 Set IT->current to match the bidi iterator unconditionally.
3259 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3260 entry. Force push_it to save on the stack the current
3261 buffer/string position, to be restored by pop_it. Fix flags in
3262 the iterator structure wrt the object coming from a display
3263 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3264 properties. (Bug#9284)
3266 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3268 * fontset.c (fontset_get_font_group): Add proper type checks.
3271 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3273 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3274 and LC_VERSION_MIN_MACOSX.
3275 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3276 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3278 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3280 * xdisp.c (forward_to_next_line_start): Allow to use the
3281 no-display-properties-and-no-overlays under bidi display.
3282 Set disp_pos in the bidi iterator to avoid searches for display
3283 properties and overlays.
3285 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3287 * editfns.c (Fset_time_zone_rule): Document relationship with the
3290 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3291 the font entity extracted from the cache (Bug#8109).
3293 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3295 * composite.c (autocmp_chars): Don't reset point. That is done by
3296 restore_point_unwind (Bug#5984).
3298 2011-08-07 Juri Linkov <juri@jurta.org>
3300 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3301 to show the arg `TIME' instead of `TIMEVAL'.
3303 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3305 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3306 display property strides EOL and includes a newline, as in
3307 longlines-mode. (Bug#9254)
3308 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3309 word-wrap under bidirectional display. (Bug#9224)
3311 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3312 is non-zero, even if the data buffer is NULL. Fixes a crash in
3313 vertical-motion with longlines-mode. (Bug#9254)
3315 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3317 * bidi.c <bidi_cache_total_alloc>: Now static.
3318 (bidi_initialize): Initialize bidi_cache_total_alloc.
3320 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3323 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3324 amount allocated this far in `bidi_cache_total_alloc'.
3325 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3326 non-zero, only free the data buffer without restoring the cache
3327 contents. All callers changed.
3329 * dispextern.h (bidi_unshelve_cache): Update prototype.
3331 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3332 (move_it_in_display_line, move_it_to)
3333 (move_it_vertically_backward, move_it_by_lines): Replace the call
3334 to xfree to an equivalent call to bidi_unshelve_cache.
3335 (move_it_in_display_line_to): Fix logic of returning
3336 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3338 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3340 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3341 came from a string character with a `cursor' property. (Bug#9229)
3343 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3345 * Makefile.in (LIB_PTHREAD): New variable.
3346 (LIBES): Add LIB_PTHREAD (Bug#9216).
3348 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3349 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3351 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3353 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3355 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3357 * xterm.c (x_find_topmost_parent): New function.
3358 (x_set_frame_alpha): Find topmost parent window with
3359 x_find_topmost_parent and set the property there also (bug#9181).
3360 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3362 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3364 * callproc.c (Fcall_process): Avoid vfork clobbering
3365 the local vars buffer, coding_systems, current_dir.
3367 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3369 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3371 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3373 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3374 so that it is not optimized away.
3376 * xdisp.c (compute_display_string_pos): Remove unused local.
3378 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3380 Fix slow cursor motion and scrolling in large buffers with
3381 selective display, like Org Mode buffers. (Bug#9218)
3383 * dispextern.h (struct bidi_it): New member disp_prop_p.
3385 * xdisp.c: Remove one-slot cache of display string positions.
3386 (compute_display_string_pos): Accept an additional argument
3387 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3388 for a display string or property. If found, set DISP_PROP_P
3391 * bidi.c (bidi_fetch_char): Accept an additional argument
3392 DISP_PROP_P, and pass it to compute_display_string_pos.
3393 Only handle text covered by a display string if DISP_PROP_P is returned
3394 non-zero. All callers of bidi_fetch_char changed.
3396 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3398 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3400 2010-12-03 Don March <don@ohspite.net>
3402 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3403 last character M-[char] is translated to ESC [char] (bug#7541).
3405 2011-08-02 Kenichi Handa <handa@m17n.org>
3407 * lisp.h (uniprop_table): Extern it.
3409 * chartab.c (uniprop_table): Make it non-static.
3411 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3413 * xdisp.c (forward_to_next_line_start): Accept additional argument
3414 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3416 (reseat_at_next_visible_line_start): Use the bidi iterator state
3417 returned by forward_to_next_line_start to restore the state of
3418 it->bidi_it after backing up to previous newline. (Bug#9212)
3420 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3422 * regex.c (re_comp): Protoize.
3423 (re_exec): Fix return type.
3424 (regexec): Fix type of `ret'. (Bug#9203)
3426 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3428 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3429 This is needed if max-image-size is a floating-point number.
3431 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3433 * print.c (print_object): Print empty symbol as ##.
3435 * lread.c (read1): Read ## as empty symbol.
3437 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3439 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3440 setting frame foreground color (Bug#9175).
3441 (x_set_background_color): Likewise.
3443 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3444 contents (Bug#9176).
3445 (EmacsTooltip -init): Remove bezels and add shadows to
3448 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3449 or scroll bar (Bug#8470).
3451 * nsfont.m (nsfont_open): Remove assignment to voffset and
3452 unnecessary vars hshink, expand, hd, full_height, min_height.
3453 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3455 * nsterm.h (nsfont_info): Remove voffset field.
3457 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3459 Implement strike-through and overline on NextStep (Bug#8863).
3461 * nsfont.m (nsfont_open): Use underline position provided by font,
3462 instead of hard-coded value of 2.
3463 (nsfont_draw): Call ns_draw_text_decoration instead.
3465 * nsterm.h: Add declaration for ns_draw_text_decoration.
3467 * nsterm.m (ns_draw_text_decoration): New function for drawing
3468 underline, overline, and strike-through.
3469 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3470 ns_draw_text_decoration. Change treatment of cursor drawing to
3471 accommodate underlining, etc.
3473 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3475 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3478 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3480 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3481 Without this fix, if a signal arrives just after memory fills up,
3482 'malloc' might be invoked reentrantly.
3484 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3485 In other words, assume that every image size is allowed, on non-X
3486 hosts. This assumption is probably wrong, but it lets Emacs compile.
3488 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3490 * regex.c (re_iswctype): Convert return values to boolean.
3492 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3494 * xdisp.c (compute_display_string_pos): Don't use cached display
3495 string position if the buffer had its restriction changed.
3498 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3502 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3504 Integer signedness and overflow and related fixes. (Bug#9079)
3506 * bidi.c: Integer size and overflow fixes.
3507 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3508 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3509 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3510 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3511 (bidi_find_other_level_edge):
3512 Use ptrdiff_t instead of EMACS_INT where either will do.
3513 This works better on 32-bit hosts configured --with-wide-int.
3514 (bidi_cache_ensure_space): Check for size-calculation overflow.
3515 Use % rather than repeated addition, for better worst-case speed.
3516 Don't set bidi_cache_size until after xrealloc returns, because it
3518 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3519 (bidi_cache_ensure_space): Also check that the bidi cache size
3520 does not exceed that of the largest Lisp string or buffer. See Eli
3521 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3523 * alloc.c (__malloc_size_t): Remove.
3524 All uses replaced by size_t. See Andreas Schwab's note
3525 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3527 * image.c: Improve checking for integer overflow.
3528 (check_image_size): Assume that f is nonnull, since
3529 it is always nonnull in practice. This is one less thing to
3530 worry about when checking for integer overflow later.
3531 (x_check_image_size): New function, which checks for integer
3532 overflow issues inside X.
3533 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3534 This removes the need for a memory_full check.
3535 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3536 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3537 (xbm_read_bitmap_data): Change locals back to 'int', since
3538 their values must fit in 'int'.
3539 (xpm_load_image, png_load, tiff_load):
3540 Invoke x_create_x_image_and_pixmap earlier,
3541 to avoid much needless work if the image is too large.
3542 (tiff_load): Treat overly large images as if
3543 x_create_x_image_and_pixmap failed, not as malloc failures.
3544 (gs_load): Use x_check_image_size.
3546 * gtkutil.c: Omit integer casts.
3547 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3548 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3550 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3552 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3553 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3554 would wrongly return t on a 64-bit host.
3556 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3557 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3558 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3559 and therefore cause GCC to emit a bogus diagnostic in some cases.
3561 * image.c: Integer signedness and overflow and related fixes.
3562 This is not an exhaustive set of fixes, but it's time to
3563 record what I've got.
3564 (lookup_pixel_color, check_image_size): Remove redundant decls.
3565 (check_image_size): Don't assume that arbitrary EMACS_INT values
3566 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3567 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3568 (tiff_load, imagemagick_load_image):
3569 Check for overflow in size calculations.
3570 (x_create_x_image_and_pixmap): Remove unnecessary test for
3571 xmalloc returning NULL; that can't happen.
3572 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3573 (xpm_color_bucket): Use better integer hashing function.
3574 (xpm_cache_color): Don't possibly over-allocate memory.
3575 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3576 (gif_memory_source):
3577 Use ptrdiff_t, not int or size_t, to record sizes.
3578 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3579 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3580 either works, as we prefer signed integers.
3581 (tiff_read_from_memory, tiff_write_from_memory):
3582 Return tsize_t, not size_t, since that's what the TIFF API wants.
3583 (tiff_read_from_memory): Don't fail simply because the read would
3584 go past EOF; instead, return a short read.
3585 (tiff_load): Omit no-longer-needed casts.
3586 (Fimagemagick_types): Don't assume size fits into 'int'.
3588 Improve hashing quality when configured --with-wide-int.
3589 * fns.c (hash_string): New function, taken from sxhash_string.
3590 Do not discard information about ASCII character case; this
3591 discarding is no longer needed.
3592 (sxhash-string): Use it. Change sig to match it. Caller changed.
3593 * lisp.h: Declare it.
3594 * lread.c (hash_string): Remove, since we now use fns.c's version.
3595 The fns.c version returns a wider integer if --with-wide-int is
3596 specified, so this should help the quality of the hashing a bit.
3598 * emacs.c: Integer overflow minor fix.
3599 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3600 Define only if GNU_LINUX.
3601 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3603 * dispnew.c: Integer signedness and overflow fixes.
3604 Remove unnecessary forward decls, that were a maintenance hassle.
3605 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3607 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3608 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3609 (prepare_desired_row, line_draw_cost):
3610 Use int, not unsigned, where either works.
3611 (save_current_matrix, restore_current_matrix):
3612 Use ptrdiff_t, not size_t, where either works.
3613 (init_display): Check for overflow more accurately, and without
3614 relying on undefined behavior.
3616 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3617 Remove, replacing with the new symbols in lisp.h. All uses changed.
3618 * fileio.c (make_temp_name):
3619 * filelock.c (lock_file_1, lock_file):
3620 * xdisp.c (message_dolog):
3621 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3622 Use pMd etc. instead.
3623 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3624 replacing the pWIDE etc. symbols removed from editfns.c.
3626 * keyboard.h (num_input_events): Now uintmax_t.
3627 This is (very slightly) less likely to mess up due to wraparound.
3630 * buffer.c: Integer signedness fixes.
3631 (alloc_buffer_text, enlarge_buffer_text):
3632 Use ptrdiff_t rather than size_t when either will do, as we prefer
3635 * alloc.c: Integer signedness and overflow fixes.
3636 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3637 (__malloc_size_t): Default to size_t, not to int.
3638 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3639 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3640 Prefer ptrdiff_t to size_t when either would do, as we prefer
3642 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3643 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3644 Now const. Initialize with values that are in range even if char
3646 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3647 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3648 These functions do the right thing with sizes > 2**32.
3649 (check_depth): Now ptrdiff_t, not int.
3650 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3651 Adjust to new way of storing sizes. Check for size overflow bugs
3653 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3654 slightly wrong anyway, as it missed one instance of
3655 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3656 (refill_memory_reserve): Omit needless cast to size_t.
3657 (mark_object_loop_halt): Mark as externally visible.
3659 * xselect.c: Integer signedness and overflow fixes.
3660 (Fx_register_dnd_atom, x_handle_dnd_message):
3661 Use ptrdiff_t, not size_t, since we prefer signed.
3662 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3663 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3664 x_dnd_atoms_size and x_dnd_atoms_length.
3666 * doprnt.c: Prefer signed to unsigned when either works.
3668 * doprnt.c (doprnt):
3670 * xdisp.c (vmessage):
3671 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3672 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3673 prefer signed arithmetic to avoid comparison confusion.
3674 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3675 but is a bit tricky.
3677 Assume freestanding C89 headers, string.h, stdlib.h.
3678 * data.c, doprnt.c, floatfns.c, print.c:
3679 Include float.h unconditionally.
3680 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3681 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3682 * regex.c: Likewise for stddef.h, string.h.
3683 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3684 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3685 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3686 (STDC_HEADERS): Remove obsolete defines.
3687 * sysdep.c: Include limits.h unconditionally.
3689 Assume support for memcmp, memcpy, memmove, memset.
3690 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3691 * regex.c (memcmp, memcpy):
3692 Remove; we assume C89 now.
3694 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3695 (__malloc_safe_bcopy): Remove; no longer needed.
3697 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3698 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3699 well either way, and we prefer signed to unsigned.
3701 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3703 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3704 closes the connection while we're reading (bug#9182).
3706 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3708 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3709 are specified (Bug#9168).
3711 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3713 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3714 Found by GCC static checking and --with-wide-int on a 32-bit host.
3716 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3718 * xdisp.c (compute_display_string_pos): Fix logic of caching
3719 previous display string position. Initialize cached_prev_pos to
3720 -1. Fixes slow-down at the beginning of a buffer.
3722 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3724 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3725 for attrs[LFACE_FONTSET_INDEX].
3727 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3729 * xml.c (parse_region): Remove unused local
3730 that was recently introduced.
3732 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3734 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3735 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3737 * xdisp.c (move_it_in_display_line_to): Record the best matching
3738 position for TO_CHARPOS while scanning the line, and restore it on
3739 exit if none of the characters scanned was an exact match.
3740 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3741 when exact match is impossible due to invisible text, and the
3742 lines are truncated.
3744 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3746 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3749 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3751 Fix a significant slow-down of cursor motion with C-n, C-p,
3752 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3753 auto-repeat under bidi redisplay in fontified buffers.
3754 * xdisp.c (compute_stop_pos_backwards): New function.
3755 (next_element_from_buffer): Call compute_stop_pos_backwards to
3756 find a suitable prev_stop when we find ourselves before
3758 (reseat): Don't look for prev_stop, as that could mean a very long
3760 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3761 <cached_disp_overlay_modiff>: Cache for last found display string
3763 (compute_display_string_pos): Return the cached position if asked
3764 about the same buffer in the same area of character positions, and
3765 the buffer wasn't changed since the time the display string
3766 position was cached.
3768 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3770 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3771 is an integer, which is important for empty lines. (Bug#9149)
3773 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3775 * frame.c (Fmodify_frame_parameters): In tty case, update the
3776 default face if necessary (Bug#4238).
3778 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3780 * editfns.c (Fstring_to_char): No need to explain what a character
3781 is in the docstring (Bug#6576).
3783 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3785 * xml.c (parse_region): Make sure we always return a tree.
3787 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3789 * xml.c (parse_region): If a document contains only comments,
3792 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3794 * xml.c (make_dom): Return comments, too.
3796 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3799 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3800 and the surrounding thread.
3801 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3802 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3803 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3805 * s/openbsd.h (BROKEN_SIGIO): Define.
3806 * unexelf.c (unexec) [__OpenBSD__]:
3807 Don't update the .mdebug section of the Alpha COFF symbol table.
3809 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3811 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3814 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3816 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3817 This fixes some race conditions on the permissions of any newly
3820 * alloc.c (valid_pointer_p): Use pipe, not open.
3821 This fixes some permissions issues when debugging.
3823 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3824 If fchown fails to set both uid and gid, try to set just gid,
3825 as that is sometimes allowed. Adjust the file's mode to eliminate
3826 setuid or setgid bits that are inappropriate if fchown fails.
3828 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3830 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3831 to compare Lisp_Objects.
3832 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3833 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3834 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3836 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3838 * lread.c (read_integer): Unread even EOF character.
3839 (read1): Likewise. Properly record start position of symbol.
3841 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3842 symbol character follows.
3844 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3846 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3847 This works around a problem with the previous change to Fcopy_file.
3848 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3849 and without this change, GCC might complain about discarding
3850 fchown's return value.
3852 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3854 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3856 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3858 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3860 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3862 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3863 it's used from the C level.
3865 * process.c: Use the same condition for POLL_FOR_INPUT in both
3866 keyboard.c and process.c (bug#1858).
3868 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3870 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3871 (Fgnutls_boot): Use it.
3873 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3875 * doc.c (Fsubstitute_command_keys): Revert last change.
3877 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3879 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3880 quotes the next character, and doesn't affect other longer
3881 sequences (bug#8935).
3883 * lread.c (syms_of_lread): Clarify that is isn't only
3884 `eval-buffer' and `eval-defun' that's affected by
3885 `lexical-binding' (bug#8460).
3887 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3889 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3890 bidi redisplay when a line includes both an image and is truncated.
3892 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3894 Fix minor problems found by static checking.
3895 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3896 (elsz): Now a signed constant, not a size_t var. We prefer signed
3897 types to unsigned, to avoid integer comparison confusion. Without
3898 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3899 "cannot optimize loop, the loop counter may overflow", a symptom
3901 * indent.c (Fvertical_motion): Mark locals as initialized.
3902 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3904 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906 * search.c (Fre_search_backward): Mention `case-fold-search' in
3907 all the re_search_* functions (bug#8138).
3909 * keyboard.c (Fopen_dribble_file): Document when the file is
3912 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3914 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3917 Support bidi reordering of display and overlay strings.
3918 * xdisp.c (compute_display_string_pos)
3919 (compute_display_string_end): Accept additional argument STRING.
3920 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3921 (reseat_to_string): Initialize bidi_it->string.s and
3922 bidi_it->string.schars.
3923 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3924 NULL (avoids a crash in bidi_paragraph_init).
3925 Initialize itb.string.lstring.
3926 (init_iterator): Call bidi_init_it only of a valid
3927 buffer position was specified. Initialize paragraph_embedding to
3929 (reseat_to_string): Initialize the bidi iterator.
3930 (display_string): If we need to ignore text properties of
3931 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3932 original value of -1 will not work with bidi.)
3933 (compute_display_string_pos): First arg is now struct
3934 `text_pos *'; all callers changed. Support display properties on
3936 (compute_display_string_end): Support display properties on Lisp
3938 (init_iterator, reseat_1, reseat_to_string): Initialize the
3939 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3940 when iterating on a string not from display properties).
3941 (compute_display_string_pos, compute_display_string_end):
3942 Fix calculation of the object to scan. Fixes an error when using
3944 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3945 base_level_stop; instead, set base_level_stop to BEGV.
3946 Fixes crashes in vertical-motion.
3947 (next_element_from_buffer): Improve commentary for when
3948 the iterator is before prev_stop.
3949 (init_iterator): Initialize bidi_p from the default value of
3950 bidi-display-reordering, not from buffer-local value. Use the
3951 buffer-local value only if initializing for buffer iteration.
3952 (handle_invisible_prop): Support invisible properties on strings
3953 that are being bidi-reordered.
3954 (set_iterator_to_next): Support bidi reordering of C strings and
3956 (next_element_from_string): Support bidi reordering of Lisp
3958 (handle_stop_backwards): Support Lisp strings as well.
3959 (display_string): Support display of R2L glyph rows.
3960 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3961 (init_iterator): Don't initialize it->bidi_p for strings
3963 (reseat_to_string): Initialize it->bidi_p for strings here.
3964 (next_element_from_string, next_element_from_c_string)
3965 (next_element_from_buffer): Add xassert's for correspondence
3966 between IT's object being iterated and it->bidi_it.string
3968 (face_before_or_after_it_pos): Support bidi iteration.
3969 (next_element_from_c_string): Handle the case of the first string
3970 character that is not the first one in the visual order.
3971 (get_visually_first_element): New function, refactored from common
3972 parts of next_element_from_buffer, next_element_from_string, and
3973 next_element_from_c_string.
3974 (tool_bar_lines_needed, redisplay_tool_bar)
3975 (display_menu_bar): Force left-to-right direction. Add a FIXME
3976 comment for making that be controlled by a user option.
3977 (push_it, pop_it): Save and restore the state of the
3978 bidi iterator. Save and restore the bidi_p flag.
3979 (pop_it): Iterate out of display property for string iteration as
3981 (iterate_out_of_display_property): Support iteration over strings.
3982 (handle_single_display_spec): Set up it->bidi_it for iteration
3983 over a display string, and call bidi_init_it.
3984 (handle_single_display_spec, next_overlay_string)
3985 (get_overlay_strings_1, push_display_prop): Set up the bidi
3986 iterator for displaying display or overlay strings.
3987 (forward_to_next_line_start): Don't use the shortcut if
3989 (back_to_previous_visible_line_start): If handle_display_prop
3990 pushed the iterator stack, restore the internal state of the bidi
3991 iterator by calling bidi_pop_it same number of times.
3992 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3993 and we are bidi-iterating, don't decrement the iterator position;
3994 instead, set the first_elt flag in the bidi iterator, to produce
3996 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3997 (push_display_prop): xassert that we are iterating a buffer.
3998 (push_it, pop_it): Save and restore paragraph_embedding member.
3999 (handle_single_display_spec, next_overlay_string)
4000 (get_overlay_strings_1, reseat_1, reseat_to_string)
4001 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4002 correctly. Don't assume unibyte strings are not bidi-reordered.
4003 (compute_display_string_pos)
4004 (compute_display_string_end): Fix handling the case of C string.
4005 (push_it, pop_it): Save and restore from_disp_prop_p.
4006 (handle_single_display_spec, push_display_prop): Set the
4007 from_disp_prop_p flag.
4008 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4009 (pop_it): Call iterate_out_of_display_property only if we are
4010 popping after iteration over a string that came from a display
4011 property. Fix a typo in popping stretch info. Add an assertion
4012 for verifying that the iterator position is in sync with the bidi
4014 (handle_single_display_spec, get_overlay_strings_1)
4015 (push_display_prop): Fix initialization of paragraph direction for
4016 string when that of the parent object is not yet determined.
4017 (reseat_1): Call bidi_init_it to resync the bidi
4018 iterator with IT's position. (Bug#7616)
4019 (find_row_edges): If ROW->start.pos gives position
4020 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4021 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4022 Reset the from_disp_prop_p flag.
4023 (SAVE_IT, RESTORE_IT): New macros.
4024 (pos_visible_p, face_before_or_after_it_pos)
4025 (back_to_previous_visible_line_start)
4026 (move_it_in_display_line_to, move_it_in_display_line)
4027 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4028 (try_scrolling, redisplay_window, display_line): Use them when
4029 saving a temporary copy of the iterator and restoring it back.
4030 (back_to_previous_visible_line_start, reseat_1)
4031 (init_iterator): Empty the bidi cache "stack".
4032 (move_it_in_display_line_to): If iterator ended up at
4033 EOL, but we never saw any buffer positions smaller than
4034 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4035 motion in bidi-reordered lines.
4036 (move_it_in_display_line_to): Record prev_method and prev_pos
4037 immediately before the call to set_iterator_to_next. Fixes cursor
4038 motion in bidi-reordered lines with stretch glyphs and strings
4039 displayed in margins. (Bug#8133) (Bug#8867)
4040 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4042 (pos_visible_p): Support positions in bidi-reordered lines.
4043 Save and restore bidi cache.
4045 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4046 (bidi_paragraph_info): Delete unused struct.
4047 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4048 (bidi_cache_start): New variable.
4049 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4051 (bidi_cache_fetch_state, bidi_cache_search)
4052 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4053 (bidi_cache_find, bidi_peek_at_next_level)
4054 (bidi_level_of_next_char, bidi_find_other_level_edge)
4055 (bidi_move_to_visually_next): Compare cache index with
4056 bidi_cache_start rather than with zero.
4057 (bidi_fetch_char): Accept new argument STRING; all callers
4058 changed. Support iteration over a string. Support strings with
4059 display properties. Support unibyte strings. Fix the type of
4060 `len' according to what STRING_CHAR_AND_LENGTH expects.
4061 (bidi_paragraph_init, bidi_resolve_explicit_1)
4062 (bidi_resolve_explicit, bidi_resolve_weak)
4063 (bidi_level_of_next_char, bidi_move_to_visually_next):
4064 Support iteration over a string.
4065 (bidi_set_sor_type, bidi_resolve_explicit_1)
4066 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4067 can now be zero (for strings); special values 0 and -1 were
4068 changed to -1 and -2, respectively.
4069 (bidi_char_at_pos): New function.
4070 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4071 Call it instead of FETCH_MULTIBYTE_CHAR.
4072 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4073 initialized to valid values.
4074 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4076 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4077 the test for valid cached positions. Fix the logic for looking up
4078 the sentinel state in the cache. GCPRO the Lisp string we are
4080 (bidi_push_it, bidi_pop_it): New functions.
4081 (bidi_initialize): Initialize the bidi cache start stack pointer.
4082 (bidi_cache_ensure_space): New function, refactored from part of
4083 bidi_cache_iterator_state. Don't assume the required size is just
4084 one BIDI_CACHE_CHUNK away.
4085 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4086 (bidi_count_bytes, bidi_char_at_pos): New functions.
4087 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4088 always valid if bidi_cache_idx is valid.
4089 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4090 is valid if it's going to be used.
4091 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4092 (bidi_cache_fetch_state, bidi_cache_search)
4093 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4094 (bidi_cache_iterator_state, bidi_cache_find)
4095 (bidi_find_other_level_edge, bidi_cache_start_stack):
4096 All variables related to cache indices are now EMACS_INT.
4098 * dispextern.h (struct bidi_string_data): New structure.
4099 (struct bidi_it): New member `string'. Make flag members be 1-bit
4100 fields, and put them last in the struct.
4101 (compute_display_string_pos, compute_display_string_end):
4103 (bidi_push_it, bidi_pop_it): Add prototypes.
4104 (struct iterator_stack_entry): New members bidi_p,
4105 paragraph_embedding, and from_disp_prop_p.
4106 (struct it): Member bidi_p is now a bit field 1 bit wide.
4107 (bidi_shelve_cache, bidi_unshelve_cache):
4110 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4111 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4112 and vector-like objects.
4114 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4115 cache around display iteration.
4117 * window.c (Fwindow_end, window_scroll_pixel_based)
4118 (displayed_window_lines, Frecenter): Save and restore the bidi
4119 cache around display iteration.
4121 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4123 * editfns.c (Fdelete_region): Clarify the use of the named
4124 parameters (bug#6788).
4126 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4128 * indent.c (Fvertical_motion): Set and restore w->pointm when
4129 saving and restoring the window's buffer (Bug#9006).
4131 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4133 * editfns.c (Fstring_to_char): Clarify just what is returned
4134 (bug#6576). Text by Eli Zaretskii.
4136 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4138 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4140 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4142 * buffer.c (mmap_find): Fix a typo.
4144 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4146 Fix execution of x selection hooks.
4147 * xselect.c (Qx_lost_selection_functions)
4148 (Qx_sent_selection_functions): New vars.
4149 (syms_of_xselect): DEFSYM them.
4150 (x_handle_selection_request): Pass Qx_sent_selection_functions
4151 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4152 (x_handle_selection_clear,x_clear_frame_selections):
4153 Pass Qx_lost_selection_functions rather than
4154 Vx_lost_selection_functions to Frun_hook_with_args.
4156 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4158 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4159 The old code sometimes used this field without initializing it.
4161 * alloc.c (gc_sweep): Don't read past end of array.
4162 In theory, the old code could also have corrupted Emacs internals,
4163 though it'd be very unlikely.
4165 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4167 * character.c (Fcharacterp): Don't advertise optional ignored
4168 argument. (Bug#4026)
4170 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4172 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4175 * window.c (Fset_window_start): Doc fix (bug#4199).
4176 (Fset_window_hscroll): Ditto.
4178 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4180 Fix minor new problems caught by GCC 4.6.1.
4181 * term.c (init_tty): Remove unused local.
4182 * xsettings.c (store_monospaced_changed): Define this function only
4183 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4186 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4188 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4190 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4192 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4193 are the mini-buffer and the echo area (bug#3320).
4195 * term.c (init_tty): Remove support for supdup, c10 and perq
4196 terminals, which are no longer supported (bug#1482).
4198 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4200 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4202 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4204 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4205 for non-popups (Bug#3642).
4207 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4209 * alloc.c (reset_malloc_hooks): Protoize.
4210 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4211 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4212 * cm.c (losecursor): Likewise.
4213 * data.c (fmod): Likewise.
4214 * dispnew.c (swap_glyphs_in_rows): Likewise.
4215 * emacs.c (memory_warning_signal): Likewise.
4216 * floatfns.c (float_error): Likewise.
4217 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4218 (otf_open, font_otf_capability, generate_otf_features)
4219 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4221 * image.c (pbm_read_file): Likewise.
4222 * indent.c (string_display_width): Likewise.
4223 * intervals.c (check_for_interval, search_for_interval)
4224 (inc_interval_count, count_intervals, root_interval)
4225 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4226 * lread.c (defalias): Likewise.
4227 * ralloc.c (r_alloc_check): Likewise.
4228 * regex.c (set_image_of_range_1, set_image_of_range)
4229 (regex_grow_registers): Likewise.
4230 * sysdep.c (strerror): Likewise.
4231 * termcap.c (valid_filename_p, tprint, main): Likewise.
4232 * tparam.c (main): Likewise.
4233 * unexhp9k800.c (run_time_remap, save_data_space)
4234 (update_file_ptrs, read_header, write_header, calculate_checksum)
4235 (copy_file, copy_rest, display_header): Likewise.
4236 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4238 * xdisp.c (check_it): Likewise.
4239 * xfaces.c (register_color, unregister_color, unregister_colors):
4241 * xfns.c (print_fontset_result): Likewise.
4242 * xrdb.c (member, fatal, main): Likewise.
4244 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4246 Fix minor problems found by static checking (Bug#9031).
4247 * chartab.c (char_table_set_range, map_sub_char_table):
4248 Remove unused locals.
4249 (uniprop_table): Now static.
4250 * composite.c (_work_char): Remove unused static var.
4252 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4254 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4256 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4258 * gtkutil.c (qttip_cb): Remove code without function.
4260 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4262 * w32.c (pthread_sigmask): New stub.
4264 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4266 Use pthread_sigmask, not sigprocmask (Bug#9010).
4267 sigprocmask is portable only for single-threaded applications, and
4268 Emacs can be multi-threaded when it uses GTK.
4269 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4271 * callproc.c (Fcall_process):
4272 * process.c (create_process):
4273 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4274 Use pthread_sigmask, not sigprocmask.
4276 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4278 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4279 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4282 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4284 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4285 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4286 (xg_hide_tooltip): Fix comment.
4288 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4289 in registerServicesMenuSendTypes.
4290 (validRequestorForSendType): Don't check ns_return_types.
4292 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4295 2011-07-08 Jason Rumney <jasonr@gnu.org>
4297 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4298 SH_SHOW for hidden windows (Bug#5482).
4300 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4301 frame struct members of non-existent frames (Bug#6284).
4303 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4305 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4306 variable firstTime not needed on OSX >= 10.6.
4307 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4308 >= 10.5. Use setKnobProportion, setDoubleValue.
4310 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4311 (MAC_OS_X_VERSION_10_5): Define if not defined.
4312 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4313 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4314 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4316 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4317 cString and lossyCString on OSX >= 10.4
4319 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4320 sizeToFit on OSX >= 10.2.
4322 * nsimage.m (allocInitFromFile): Don't use deprecated method
4323 bestRepresentationForDevice on OSX >= 10.6.
4325 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4328 * emacs.c: Declare unexec_init_emacs_zone.
4330 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4332 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4334 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4335 on svcsMenu (Bug#8842).
4337 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4339 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4341 * nsterm.m (QUTF8_STRING): Declare.
4342 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4343 (validRequestorForSendType): Return type is (id).
4344 Change indexOfObjectIdenticalTo to indexOfObject.
4345 Check if we have local selection before returning self (Bug#8842).
4346 (writeSelectionToPasteboard): Put local selection into paste board
4347 if we have a local selection (Bug#8842).
4348 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4350 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4351 (ns_get_local_selection): Declare.
4353 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4355 * keymap.c (describe_map_tree): Don't insert a double newline at
4356 the end of the buffer (bug#1169) and return whether we inserted
4359 * callint.c (Fcall_interactively): Change "reading args" to
4360 "providing args" to try to clarify what it does (bug#1010).
4362 2011-07-07 Kenichi Handa <handa@m17n.org>
4364 * composite.c (composition_compute_stop_pos): Ignore a static
4365 composition starting before CHARPOS (Bug#8915).
4367 * xdisp.c (handle_composition_prop): Likewise.
4369 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4371 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4374 2011-07-07 Kenichi Handa <handa@m17n.org>
4376 * character.h (unicode_category_t): New enum type.
4378 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4379 (Qchar_code_property_table): New variable.
4380 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4381 (UNIPROP_COMPRESSED_FORM_P): New macros.
4382 (char_table_ascii): Uncompress the compressed values.
4383 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4384 Uncompress the compressed values.
4385 (sub_char_table_ref_and_range): Likewise.
4386 (char_table_ref_and_range): Uncompress the compressed values.
4387 (sub_char_table_set): New arg is_uniprop. Callers changed.
4388 Uncompress the compressed values.
4389 (sub_char_table_set_range): Args changed. Callers changed.
4390 (char_table_set_range): Adjuted for the above change.
4391 (map_sub_char_table): Delete args default_val and parent. Add arg
4392 top. Give decoded values to a Lisp function.
4393 (map_char_table): Adjust for the above change. Give decoded
4394 values to a Lisp function. Gcpro more variables.
4395 (uniprop_table_uncompress)
4396 (uniprop_decode_value_run_length): New functions.
4397 (uniprop_decoder, uniprop_decoder_count): New variables.
4398 (uniprop_get_decoder, uniprop_encode_value_character)
4399 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4401 (uniprop_encoder, uniprop_encoder_count): New variables.
4402 (uniprop_get_encoder, uniprop_table)
4403 (Funicode_property_table_internal, Fget_unicode_property_internal)
4404 (Fput_unicode_property_internal): New functions.
4405 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4406 Sunicode_property_table_internal, Sget_unicode_property_internal,
4407 and Sput_unicode_property_internal. Defvar_lisp
4408 char-code-property-alist.
4410 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4411 Vunicode_category_table.
4413 * font.c (font_range): Adjust for the change of
4414 Vunicode_category_table.
4416 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4418 * m/iris4d.h: Remove file, move contents ...
4419 * s/irix6-5.h: ... here.
4421 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4423 Remove unportable assumption about struct layout (Bug#8884).
4424 * alloc.c (mark_buffer):
4425 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4426 (clone_per_buffer_values): Don't assume that
4427 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4428 This isn't true in general, and it's particularly not true
4429 if Emacs is configured with --with-wide-int.
4430 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4431 New macros, used in the buffer.c change.
4433 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4435 * xsettings.c: Use both GConf and GSettings if both are available.
4436 (store_config_changed_event): Add comment.
4437 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4438 (store_tool_bar_style_changed): New functions.
4439 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4440 (struct xsettings): Move font inside HAVE_XFT.
4441 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4442 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4443 Move inside HAVE_XFT.
4444 (something_changed_gsettingsCB): Rename from something_changedCB.
4445 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4447 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4448 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4449 (something_changed_gconfCB): Rename from something_changedCB.
4450 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4451 (parse_settings): Move check for font inside HAVE_XFT.
4452 (read_settings, apply_xft_settings): Add comment.
4453 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4454 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4455 call store_font_name_changed.
4456 (xft_settings_event): Add comment.
4457 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4458 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4459 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4460 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4461 (xsettings_initialize): Call init_gsettings last.
4462 (xsettings_get_system_font, xsettings_get_system_normal_font):
4465 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4467 Random fixes. E.g., (random) never returned negative values.
4468 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4469 subseconds part to the entropy, as that's a bit more random.
4470 Prefer signed to unsigned, since the signedness doesn't matter and
4471 in general we prefer signed. When given a limit, use a
4472 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4473 latter isn't right if USE_2_TAGS_FOR_INTS.
4474 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4475 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4477 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4479 * textprop.c (text_property_stickiness):
4480 Obey Vtext_property_default_nonsticky.
4481 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4482 * w32fns.c (syms_of_w32fns):
4483 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4485 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4487 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4488 This is more efficient than Ffile_directory_p and avoids a minor race.
4490 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4492 * buffer.c (Foverlay_put): Say what the return value is
4495 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4496 is a directory before asking whether to use the file name
4498 (barf_or_query_if_file_exists): Make the "File is a directory"
4499 error be more correct.
4501 * fns.c (Frequire): Remove the mention of the .gz files, since
4502 that's installation-specific, but keep the mention of
4503 `get-load-suffixes'.
4505 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4507 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4508 Report string overflow if the output is too long.
4510 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4512 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4513 (syms_of_gnutls): Remove duplicate DEFSYM for
4514 Qgnutls_bootprop_verify_hostname_error, an error for
4515 Qgnutls_bootprop_verify_error (which is no longer used).
4517 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4518 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4519 Also (re)move comments that are misplaced or no longer relevant.
4521 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4523 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4525 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4527 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4528 and background color parameters if they have been changed.
4530 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4532 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4534 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4536 * xsettings.c (SYSTEM_FONT): Define only when used.
4537 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4539 * keymap.c (access_keymap_1): Now static.
4541 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4543 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4544 leave any prefix arg for the up event (Bug#1586).
4546 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4548 * lread.c (syms_of_lread): Mention single symbols defined by
4549 `defvar' or `defconst' (bug#7154).
4551 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4552 (Frequire): Mention get-load-suffixes.
4554 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4556 * window.h (window): Remove clone_number slot.
4557 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4559 (make_parent_window, make_window, saved_window)
4560 (Fset_window_configuration, save_window_save): Don't deal with
4562 * buffer.c (Qclone_number): Remove declaration.
4563 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4565 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4567 Add multiple inheritance to keymaps.
4568 * keymap.c (Fmake_composed_keymap): New function.
4569 (Fset_keymap_parent): Simplify.
4570 (fix_submap_inheritance): Remove.
4571 (access_keymap_1): New function extracted from access_keymap to handle
4572 embedded parents and handle lists of maps.
4573 (access_keymap): Use it.
4574 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4575 (Fcopy_keymap): Handle embedded parents.
4576 (Fcommand_remapping, define_as_prefix): Simplify.
4577 (Fkey_binding): Simplify.
4578 (syms_of_keymap): Move minibuffer-local-completion-map,
4579 minibuffer-local-filename-completion-map,
4580 minibuffer-local-must-match-map, and
4581 minibuffer-local-filename-must-match-map to Elisp.
4582 (syms_of_keymap): Defsubr make-composed-keymap.
4583 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4584 (parse_menu_item): Trivial simplification.
4586 2011-07-01 Glenn Morris <rgm@gnu.org>
4588 * Makefile.in (SETTINGS_LIBS): Fix typo.
4590 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4592 * coding.c (Fencode_coding_string): Record the last coding system
4593 used, as the function doc string says (bug#8738).
4595 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4597 * xsettings.c (store_monospaced_changed): Take new font as arg and
4598 check for change against current_mono_font.
4599 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4600 (emacs_settings_constructor, emacs_settings_get_property)
4601 (emacs_settings_set_property, emacs_settings_class_init)
4602 (emacs_settings_init, gsettings_obj): Remove.
4603 (something_changedCB): New function for HAVE_GSETTINGS.
4604 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4605 with value as argument.
4606 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4607 g_settings_new (Bug#8967). Do not create gsettings_obj.
4608 Remove calls to g_settings_bind. Connect something_changedCB to
4611 * xgselect.c: Add defined (HAVE_GSETTINGS).
4612 (xgselect_initialize): Ditto.
4614 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4615 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4618 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4620 * eval.c (struct backtrace): Simplify and port the data structure.
4621 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4622 signed bit field, as this assumption is not portable and it makes
4623 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4624 "char debug_on_exit : 1" as this is not portable either; instead,
4625 use the portable "unsigned int debug_on_exit : 1". Remove unused
4626 member evalargs. Remove obsolete comments about cc bombing out.
4628 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4630 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4631 Let HAVE_GSETTINGS override HAVE_GCONF.
4632 (store_monospaced_changed): New function.
4633 (EMACS_SETTINGS): A new type derived from GObject to handle
4634 GSettings notifications.
4635 (emacs_settings_constructor, emacs_settings_get_property)
4636 (emacs_settings_set_property, emacs_settings_class_init):
4638 (gsettings_client, gsettings_obj): New variables.
4639 (GSETTINGS_SCHEMA): New define.
4640 (something_changedCB): Call store_monospaced_changed.
4641 (init_gsettings): New function.
4642 (xsettings_initialize): Call init_gsettings.
4643 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4646 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4649 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4651 * window.c (resize_root_window, grow_mini_window)
4652 (shrink_mini_window): Rename Qresize_root_window to
4653 Qwindow_resize_root_window and Qresize_root_window_vertically to
4654 Qwindow_resize_root_window_vertically.
4656 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4658 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4660 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4662 * makefile.w32-in: Redesign dependencies so they reflect more
4663 clearly which files are directly included by each source file,
4664 and not through other includes.
4666 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4668 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4669 (sort_overlays, overlay_strings): When an overlay's clone number
4670 matches the window's clone number process the overlay even if
4671 the overlay's window property doesn't match the current window.
4673 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4674 (Fwindow_hchild): Rename to Fwindow_left_child.
4675 (Fwindow_next): Rename to Fwindow_next_sibling.
4676 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4677 (resize_window_check): Rename to window_resize_check.
4678 (resize_window_apply): Rename to window_resize_apply.
4679 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4680 (Fdelete_other_windows_internal, resize_frame_windows)
4681 (Fsplit_window_internal, Fdelete_window_internal)
4682 (grow_mini_window, shrink_mini_window)
4683 (Fresize_mini_window_internal): Fix callers accordingly.
4685 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4687 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4688 (emacs_fixed_set_min_size): Remove.
4689 (emacs_fixed_new): Take frame as argument.
4691 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4692 (_EmacsFixedPrivate): Remove minwidth/height.
4693 Add struct frame *f.
4694 (emacs_fixed_init): Initialize priv->f.
4695 (get_parent_class, emacs_fixed_set_min_size): Remove.
4696 (emacs_fixed_new): Set priv->f to argument.
4697 (emacs_fixed_get_preferred_width)
4698 (emacs_fixed_get_preferred_height): Use min_width/height from
4699 frames size_hint to set minimum and natural (Bug#8919).
4700 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4701 and use min_width/height from frames size_hint to set
4702 min_width/height (Bug#8919).
4704 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4705 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4708 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4710 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4711 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4714 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4716 * process.c (wait_reading_process_output): Bypass select if
4717 waiting for a cell while ignoring keyboard input, and input is
4718 pending. Suggested by Jan Djärv (Bug#8869).
4720 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4722 Use gnulib's dup2 module instead of rolling our own.
4723 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4725 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4727 * dispnew.c (scrolling_window): Before scrolling, turn off a
4728 mouse-highlight in the window being scrolled.
4730 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4732 Move DEFSYM to lisp.h and use everywhere.
4734 * character.h (DEFSYM): Move declaration...
4735 * lisp.h (DEFSYM): ...here.
4741 * w32select.c: Don't include character.h.
4743 * alloc.c (syms_of_alloc):
4744 * buffer.c (syms_of_buffer):
4745 * bytecode.c (syms_of_bytecode):
4746 * callint.c (syms_of_callint):
4747 * casefiddle.c (syms_of_casefiddle):
4748 * casetab.c (init_casetab_once):
4749 * category.c (init_category_once, syms_of_category):
4750 * ccl.c (syms_of_ccl):
4751 * cmds.c (syms_of_cmds):
4752 * composite.c (syms_of_composite):
4753 * dbusbind.c (syms_of_dbusbind):
4754 * dired.c (syms_of_dired):
4755 * dispnew.c (syms_of_display):
4756 * doc.c (syms_of_doc):
4757 * editfns.c (syms_of_editfns):
4758 * emacs.c (syms_of_emacs):
4759 * eval.c (syms_of_eval):
4760 * fileio.c (syms_of_fileio):
4761 * fns.c (syms_of_fns):
4762 * frame.c (syms_of_frame):
4763 * fringe.c (syms_of_fringe):
4764 * insdel.c (syms_of_insdel):
4765 * keymap.c (syms_of_keymap):
4766 * lread.c (init_obarray, syms_of_lread):
4767 * macros.c (syms_of_macros):
4768 * msdos.c (syms_of_msdos):
4769 * print.c (syms_of_print):
4770 * process.c (syms_of_process):
4771 * search.c (syms_of_search):
4772 * sound.c (syms_of_sound):
4773 * syntax.c (init_syntax_once, syms_of_syntax):
4774 * terminal.c (syms_of_terminal):
4775 * textprop.c (syms_of_textprop):
4776 * undo.c (syms_of_undo):
4777 * w32.c (globals_of_w32):
4778 * window.c (syms_of_window):
4779 * xdisp.c (syms_of_xdisp):
4780 * xfaces.c (syms_of_xfaces):
4781 * xfns.c (syms_of_xfns):
4782 * xmenu.c (syms_of_xmenu):
4783 * xsettings.c (syms_of_xsettings):
4784 * xterm.c (syms_of_xterm): Use DEFSYM.
4786 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4788 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4790 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4792 Integer and buffer overflow fixes (Bug#8873).
4794 * print.c (printchar, strout): Check for string overflow.
4795 (PRINTPREPARE, printchar, strout):
4796 Don't set size unless allocation succeeds.
4798 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4799 for sizes. Check for string overflow more accurately.
4800 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4802 * macros.c: Integer and buffer overflow fixes.
4803 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4804 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4805 Use ptrdiff_t, not int, for sizes.
4806 Don't increment bufsize until after realloc succeeds.
4807 Check for size-calculation overflow.
4808 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4810 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4812 * lread.c: Integer overflow fixes.
4813 (read_integer): Radix is now EMACS_INT, not int,
4814 to improve quality of diagnostics for out-of-range radices.
4815 Calculate buffer size correctly for out-of-range radices.
4816 (read1): Check for integer overflow in radices, and in
4817 read-circle numbers.
4818 (read_escape): Avoid int overflow.
4819 (Fload, openp, read_buffer_size, read1)
4820 (substitute_object_recurse, read_vector, read_list, map_obarray):
4821 Use ptrdiff_t, not int, for sizes.
4822 (read1): Use EMACS_INT, not int, for sizes.
4823 Check for size overflow.
4825 * image.c (cache_image): Check for size arithmetic overflow.
4827 * lread.c: Integer overflow issues.
4828 (saved_doc_string_size, saved_doc_string_length)
4829 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4830 Now ptrdiff_t, not int.
4831 (read1): Don't assume doc string length fits in int. Check for
4832 out-of-range doc string lengths.
4833 (read_list): Don't assume file position fits in int.
4834 (read_escape): Check for hex character overflow.
4836 2011-06-22 Leo Liu <sdl.web@gmail.com>
4838 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4839 Move to minibuffer.el.
4841 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4843 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4844 The following patches are for when GLYPH_DEBUG && !XASSERT.
4845 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4846 * dispnew.c (flush_stdout):
4847 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4848 Mark as externally visible.
4849 * dispnew.c (check_window_matrix_pointers): Now static.
4850 * dispnew.c (window_to_frame_vpos):
4851 * xfns.c (unwind_create_frame):
4852 * xterm.c (x_check_font): Remove unused local.
4853 * scroll.c (CHECK_BOUNDS):
4854 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4855 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4856 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4857 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4858 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4860 (debug_method_add): Use va_list and vsprintf rather than relying
4861 on undefined behavior with wrong number of arguments.
4862 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4863 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4864 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4865 since we're not interested in debugging glyphs with old libraries.
4866 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4867 GCC 4.6.0's static checking.
4869 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4871 Integer overflow and signedness fixes (Bug#8873).
4872 A few related buffer overrun fixes, too.
4874 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4876 * dispextern.h (struct face.stipple):
4877 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4878 (x_bitmap_mask, x_allocate_bitmap_record)
4879 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4880 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4881 (x_create_bitmap_from_xpm_data):
4882 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4883 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4885 * xfaces.c (load_pixmap):
4886 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4887 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4888 (.bitmaps_last, struct x_output.icon_bitmap):
4889 Use ptrdiff_t, not int, for bitmap indexes.
4890 (x_allocate_bitmap_record): Check for size overflow.
4891 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4893 Use ptrdiff_t, not int, for overlay counts.
4894 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4895 * editfns.c (overlays_around, get_pos_property):
4896 * textprop.c (get_char_property_and_overlay):
4897 * xdisp.c (next_overlay_change, note_mouse_highlight):
4898 * xfaces.c (face_at_buffer_position):
4899 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4900 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4901 (Fnext_overlay_change, Fprevious_overlay_change)
4902 (mouse_face_overlay_overlaps, Foverlays_in):
4903 Use ptrdiff_t, not int, for sizes.
4904 (overlays_at, overlays_in): Check for size-calculation overflow.
4906 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4908 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4909 (x_session_initialize): Do not assume string length fits in int.
4911 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4912 This is unlikely, but can occur if DPI is outlandish.
4914 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4915 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4917 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4918 * xrdb.c (magic_file_p, search_magic_path):
4919 Omit last arg SUFFIX; it was always 0. All callers changed.
4920 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4922 * xfont.c (xfont_match): Avoid need for strlen.
4924 * xfns.c: Don't assume strlen fits in int.
4925 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4927 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4928 not unsigned long, as we prefer signed integers. All callers changed.
4929 Detect integer overflow in repeat count.
4930 (message_dolog): Don't assume print length fits in 39 bytes.
4931 (display_mode_element): Don't assume strlen fits in int.
4933 * termcap.c: Don't assume sizes fit in int and never overflow.
4934 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4935 (gobble_line): Check for size-calculation overflow.
4937 * minibuf.c (Fread_buffer):
4938 * lread.c (intern, intern_c_string):
4939 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4940 Don't assume string length fits in int.
4942 * keyboard.c (parse_tool_bar_item):
4943 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4945 * font.c: Don't assume string length fits in int.
4946 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4947 Use ptrdiff_t, not int.
4948 (font_intern_prop): Don't assume string length fits in int.
4949 Don't assume integer property fits in fixnum.
4950 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4952 * filelock.c: Fix some buffer overrun and integer overflow issues.
4953 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4954 Reformulate so as not to need the command string.
4955 Invoke gzip -cd rather than gunzip, as it's more portable.
4956 (lock_info_type, lock_file_1, lock_file):
4957 Don't assume pid_t and time_t fit in unsigned long.
4958 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4959 (current_lock_owner): Prefer signed type for sizes.
4960 Use memcpy, not strncpy, where memcpy is what is really wanted.
4961 Don't assume (via atoi) that time_t and pid_t fit in int.
4962 Check for time_t and/or pid_t out of range, e.g., via a network share.
4963 Don't alloca where an auto var works fine.
4965 * fileio.c: Fix some integer overflow issues.
4966 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4967 Don't assume string length fits in int.
4968 (directory_file_name): Don't assume string length fits in long.
4969 (make_temp_name): Don't assume pid fits in int, or that its print
4970 length is less than 20.
4972 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4974 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4976 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4978 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4979 We prefer signed integers, even for size calculations.
4981 * emacs.c: Don't assume string length fits in 'int'.
4982 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4983 (main): Don't invoke strlen when not needed.
4985 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4986 (XD_DEBUG_MESSAGE): Don't waste a byte.
4988 * callproc.c (getenv_internal_1, getenv_internal)
4990 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4992 * lread.c (invalid_syntax): Omit length argument.
4993 All uses changed. This doesn't fix a bug, but it simplifies the
4994 code away from its former Hollerith-constant appearance, and it's
4995 one less 'int' to worry about when looking at integer-overflow issues.
4996 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4998 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4999 This didn't break anything, but it didn't help either.
5000 It's confusing to put a bogus integer in a place where the actual
5001 value does not matter.
5002 (LIST_END_P): Remove unused macro and its bogus comment.
5003 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5005 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5006 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5008 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5009 We prefer signed types, and the value cannot exceed the EMACS_INT
5010 range anyway (because otherwise the length would not be representable).
5011 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5012 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5013 This avoids a GCC warning when WIDE_EMACS_INT.
5015 * indent.c (sane_tab_width): New function.
5016 (current_column, scan_for_column, Findent_to, position_indentation)
5017 (compute_motion): Use it. This is just for clarity.
5018 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5020 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5022 * lisp.h (lint_assume): New macro.
5023 * composite.c (composition_gstring_put_cache):
5024 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5026 * editfns.c, insdel.c:
5027 Omit unnecessary forward decls, to simplify future changes.
5029 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5031 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5033 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5034 Use much-faster test for byte-length change.
5035 Don't assume string byte-length fits in 'int'.
5036 Check that character arg fits in 'int'.
5037 (mapcar1): Declare byte as byte, for clarity.
5039 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5041 * fns.c (concat): Catch string overflow earlier.
5042 Do not rely on integer wraparound.
5044 * dispextern.h (struct it.overlay_strings_charpos)
5045 (struct it.selective): Now EMACS_INT, not int.
5046 * xdisp.c (forward_to_next_line_start)
5047 (back_to_previous_visible_line_start)
5048 (reseat_at_next_visible_line_start, next_element_from_buffer):
5049 Don't arbitrarily truncate the value of 'selective' to int.
5051 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5053 * composite.c: Don't truncate sizes to 'int'.
5054 (composition_gstring_p, composition_reseat_it)
5055 (composition_adjust_point): Use EMACS_INT, not int.
5056 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5057 not EMACS_UINT, for indexes.
5059 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5061 * buffer.c: Include <verify.h>.
5062 (struct sortvec.priority, struct sortstr.priority):
5063 Now EMACS_INT, not int.
5064 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5065 (struct sortstr.size, record_overlay_string)
5066 (struct sortstrlist.size, struct sortlist.used):
5067 Don't truncate size to int.
5068 (record_overlay_string): Check for size-calculation overflow.
5069 (init_buffer_once): Check at compile-time, not run-time.
5071 2011-06-22 Jim Meyering <meyering@redhat.com>
5073 Don't leak an XBM-image-sized buffer
5074 * image.c (xbm_load): Free the image buffer after using it.
5076 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5079 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5080 that Sun C diagnosed.
5081 * fns.c (secure_hash): Fix pointer signedness issue.
5082 * intervals.c (static_offset_intervals): New function.
5083 (offset_intervals): Use it.
5085 2011-06-21 Leo Liu <sdl.web@gmail.com>
5088 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5091 * fns.c (secure_hash): Rename from crypto_hash_function and change
5092 the first arg to accept symbols.
5093 (Fsecure_hash): New primitive.
5094 (syms_of_fns): New symbols.
5096 2011-06-20 Deniz Dogan <deniz@dogan.se>
5098 * process.c (Fset_process_buffer): Clarify return value in
5101 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5103 * dispnew.c (add_window_display_history): Use BVAR.
5105 * xdisp.c (debug_method_add): Use BVAR.
5106 (check_window_end, dump_glyph_matrix, dump_glyph)
5107 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5109 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5112 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5113 check till after the cache is created in init_frame_faces.
5115 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5117 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5119 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5121 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5122 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5123 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5125 Improve buffer-overflow checking (Bug#8873).
5126 * fileio.c (Finsert_file_contents):
5127 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5128 Remove the old (too-loose) buffer overflow checks.
5129 They weren't needed, since make_gap checks for buffer overflow.
5130 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5131 The old code merely checked for Emacs fixnum overflow, and relied
5132 on undefined (wraparound) behavior. The new code avoids undefined
5133 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5135 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5136 Tune. Don't use wider integers than needed. Don't use alloca.
5137 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5139 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5141 * insdel.c, lisp.h (buffer_overflow): New function.
5142 (insert_from_buffer_1, replace_range, replace_range_2):
5143 * insdel.c (make_gap_larger):
5144 * editfns.c (Finsert_char):
5145 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5147 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5149 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5151 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5153 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5154 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5156 * fileio.c: Don't assume EMACS_INT fits in off_t.
5157 (emacs_lseek): New static function.
5158 (Finsert_file_contents, Fwrite_region): Use it.
5159 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5161 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5163 * fns.c: Don't overflow int when computing a list length.
5164 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5165 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5166 truncation on 64-bit hosts. Check for QUIT every
5167 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5168 faster and is responsive enough.
5169 (Flength): Report an error instead of overflowing an integer.
5170 (Fsafe_length): Return a float if the value is not representable
5171 as a fixnum. This shouldn't happen except in contrived situations.
5172 (Fnthcdr, Fsort): Don't assume list length fits in int.
5173 (Fcopy_sequence): Don't assume vector length fits in int.
5175 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5176 (header_size, word_size): New constants.
5177 (allocate_vectorlike): Don't check size overflow here.
5178 (allocate_vector): Check it here instead, since this is the only
5179 caller of allocate_vectorlike that could cause overflow.
5180 Check that the new vector's length is representable as a fixnum.
5182 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5183 The previous code was bogus. For example, next_almost_prime (32)
5184 returned 39, which is undesirable as it is a multiple of 3; and
5185 next_almost_prime (24) returned 25, which is a multiple of 5 so
5186 why was the code bothering to check for multiples of 7?
5188 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5190 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5192 Variadic C functions now count arguments with ptrdiff_t.
5193 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5194 Back then I didn't know that the Emacs coding style prefers signed int.
5195 Also, in the meantime I found a few more instances where arguments
5196 were being counted with int, which may truncate counts on 64-bit
5197 machines, or EMACS_INT, which may be unnecessarily wide.
5198 * lisp.h (struct Lisp_Subr.function.aMANY)
5199 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5200 Arg counts are now ptrdiff_t, not size_t.
5201 All variadic functions and their callers changed accordingly.
5202 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5203 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5204 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5205 * callint.c (Fcall_interactively): Check arg count for overflow,
5206 to avoid potential buffer overrun. Use signed char, not 'int',
5207 for 'varies' array, so that we needn't bother to check its size
5208 calculation for overflow.
5209 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5210 * eval.c (apply_lambda):
5211 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5212 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5213 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5215 * callint.c (Fcall_interactively): Don't use index var as event count.
5217 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5218 * mem-limits.h (SIZE): Remove; no longer used.
5220 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5222 Remove unnecessary casts.
5223 * xterm.c (x_term_init):
5224 * xfns.c (x_set_border_pixel):
5225 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5226 These aren't needed now that we assume ANSI C.
5228 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5229 It's more likely to cause problems (due to unsigned overflow)
5232 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5234 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5236 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5238 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5240 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5242 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5244 GLYPH_CODE_FACE returns EMACS_INT, not int.
5245 * dispextern.h (merge_faces):
5246 * xfaces.c (merge_faces):
5247 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5248 Don't assume EMACS_INT fits in int.
5250 * character.h (CHAR_VALID_P): Remove unused parameter.
5251 * fontset.c, lisp.h, xdisp.c: All uses changed.
5253 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5255 * fns.c (concat): Minor tuning based on overflow analysis.
5256 This doesn't fix any bugs. Use int to hold character, instead
5257 of constantly refetching from Emacs object. Use XFASTINT, not
5258 XINT, for value known to be a character. Don't bother comparing
5259 a single byte to 0400, as it's always less.
5261 * floatfns.c (Fexpt):
5262 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5264 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5267 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5269 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5270 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5271 incorrectly succeed when S was a string, because 4294967386 was
5272 truncated before it was used.
5274 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5275 Otherwise, an out-of-range integer could cause undefined behavior
5278 * composite.c: Use int, not EMACS_INT, for characters.
5279 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5280 EMACS_INT, for values that are known to be in character range.
5281 This doesn't fix any bugs but is the usual style inside Emacs and
5282 may generate better code on 32-bit machines.
5284 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5285 This is for reasons similar to the recent CHAR_STRING fix.
5286 * charset.c (Fencode_char): Check that character arg is actually
5287 a character. Pass an int to ENCODE_CHAR.
5288 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5289 wider than 'int', as a compile-time check to prevent future regressions
5292 * character.c (char_string): Remove unnecessary casts.
5294 Make sure a 64-bit char is never passed to CHAR_STRING.
5295 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5296 by silently ignoring the top 32 bits, allowing some values
5297 that were far too large to be valid characters.
5298 * character.h: Include <verify.h>.
5299 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5300 arguments are no wider than unsigned, as a compile-time check
5301 to prevent future regressions in this area.
5303 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5304 (Fsubst_char_in_region):
5306 * xdisp.c (decode_mode_spec_coding):
5307 Adjust to CHAR_STRING's new requirement.
5308 * editfns.c (Finsert_char, Fsubst_char_in_region):
5309 * fns.c (concat): Check that character args are actually
5310 characters. Without this test, these functions did the wrong
5311 thing with wildly out-of-range values on 64-bit hosts.
5313 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5314 These casts should not be needed on 32-bit hosts, either.
5315 * keyboard.c (read_char):
5316 * lread.c (Fload): Remove casts to unsigned.
5318 * lisp.h (UNSIGNED_CMP): New macro.
5319 This fixes comparison bugs on 64-bit hosts.
5320 (ASCII_CHAR_P): Use it.
5321 * casefiddle.c (casify_object):
5322 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5323 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5324 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5325 * dispextern.h (FACE_FROM_ID):
5326 * keyboard.c (read_char): Use UNSIGNED_CMP.
5328 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5329 not to EMACS_INT, to avoid GCC warning.
5331 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5333 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5334 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5335 isn't needed on 32-bit machines.
5337 * buffer.c (Fgenerate_new_buffer_name):
5338 Use EMACS_INT for count, not int.
5339 (advance_to_char_boundary): Return EMACS_INT, not int.
5341 * data.c (Qcompiled_function): Now static.
5343 * window.c (window_body_lines): Now static.
5345 * image.c (gif_load): Rename local to avoid shadowing.
5347 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5348 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5349 * alloc.c (make_save_value): Integer argument is now of type
5351 (mark_object): Use ptrdiff_t, not int.
5352 * lisp.h (pD): New macro.
5353 * print.c (print_object): Use it.
5355 * alloc.c: Use EMACS_INT, not int, to count objects.
5356 (total_conses, total_markers, total_symbols, total_vector_size)
5357 (total_free_conses, total_free_markers, total_free_symbols)
5358 (total_free_floats, total_floats, total_free_intervals)
5359 (total_intervals, total_strings, total_free_strings):
5360 Now EMACS_INT, not int. All uses changed.
5361 (Fgarbage_collect): Compute overall total using a double, so that
5362 integer overflow is less likely to be a problem. Check for overflow
5363 when converting back to an integer.
5364 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5365 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5366 These were 'int' variables that could overflow on 64-bit hosts;
5367 they were never used, so remove them instead of repairing them.
5368 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5369 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5370 Previously, this ceilinged at INT_MAX, but that doesn't work on
5372 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5374 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5375 (allocate_vectorlike): Check for ptrdiff_t overflow.
5376 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5377 when a (possibly-narrower) signed value would do just as well.
5378 We prefer using signed arithmetic, to avoid comparison confusion.
5380 * alloc.c: Catch some string size overflows that we were missing.
5381 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5382 for convenience in STRING_BYTES_MAX.
5383 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5384 The definition here is exact; the one in lisp.h was approximate.
5385 (allocate_string_data): Check for string overflow. This catches
5386 some instances we weren't catching before. Also, it catches
5387 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5388 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5389 and ptrdiff_t and EMACS_INT are both 64 bits.
5391 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5392 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5393 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5395 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5397 * alloc.c (Fmake_string): Check for out-of-range init.
5399 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5401 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5403 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5405 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5406 xg_get_default_scrollbar_width.
5408 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5409 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5410 (style_changed_cb): Call update_theme_scrollbar_width and call
5411 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5412 all frames (Bug#8505).
5413 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5414 Call gtk_window_set_resizable if HAVE_GTK3.
5415 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5416 and height if HAVE_GTK3 (Bug#8505).
5417 (scroll_bar_width_for_theme): New variable.
5418 (update_theme_scrollbar_width): New function.
5419 (xg_get_default_scrollbar_width): Move code to
5420 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5421 (xg_initialize): Call update_theme_scrollbar_width.
5423 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5425 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5427 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5429 * frame.c (make_frame): Call other_buffer_safely instead of
5432 * window.c (temp_output_buffer_show): Call display_buffer with
5433 second argument Vtemp_buffer_show_specifiers and reset latter
5434 immediately after the call.
5435 (Vtemp_buffer_show_specifiers): New variable.
5436 (auto_window_vscroll_p, next_screen_context_lines)
5437 (Vscroll_preserve_screen_position): Remove leading asterisks from
5440 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5442 Fix minor problems found by GCC 4.6.0 static checking.
5443 * buffer.c (Qclone_number): Remove for now, as it's unused.
5444 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5445 (record_buffer): Remove unused local.
5446 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5447 (set_frame_buffer_list): Remove; unused.
5448 * frame.h (other_visible_frames): Remove decl.
5449 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5450 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5451 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5453 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5454 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5455 Define only if HAVE_GPM.
5456 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5457 (update_hints_inhibit): Remove; never set. All uses removed.
5458 * widgetprv.h (emacsFrameClassRec): Remove decl.
5459 * window.c (delete_deletable_window): Now returns void, since it
5460 wasn't returning anything.
5461 (compare_window_configurations): Remove unused locals.
5462 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5463 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5464 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5465 the same widths as pointers. This follows up on the 2011-05-06 patch.
5466 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5467 * xterm.h: Likewise.
5468 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5470 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5472 * makefile.w32-in: Update dependencies.
5473 (LISP_H): Add lib/intprops.h.
5475 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5477 * image.c (gif_load): Add animation frame delay to the metadata.
5478 (syms_of_image): Use DEFSYM. New symbol `delay'.
5480 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5482 * window.c (delete_deletable_window): Re-add.
5483 (Fset_window_configuration): Rewrite to handle dead buffers and
5484 consequently deletable windows.
5485 (window_tree, Fwindow_tree): Remove. Supply functionality in
5487 (compare_window_configurations): Simplify code.
5489 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5491 * image.c (imagemagick_load_image): Fix type mismatch.
5492 (Fimagemagick_types): Likewise.
5494 * window.h (replace_buffer_in_windows): Declare.
5496 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5498 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5499 Qclone_number. Remove external declaration of Qdelete_window.
5500 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5502 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5503 Run Qbuffer_list_update_hook if allowed.
5504 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5505 buffer list implementation.
5506 (other_buffer_safely): New function.
5507 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5508 calls to replace_buffer_in_windows and
5509 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5511 (record_buffer): Inhibit quitting and rewrite using quittable
5512 functions. Run Qbuffer_list_update_hook if allowed.
5513 (Frecord_buffer, Funrecord_buffer): New functions.
5514 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5515 Move switch-to-buffer to window.el.
5516 (bury-buffer): Move to window.el.
5517 (Vbuffer_list_update_hook): New variable.
5519 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5522 * window.h (resize_frame_windows): Move up in code.
5523 (Fwindow_frame): Remove EXFUN.
5524 (replace_buffer_in_all_windows): Remove prototype.
5525 (replace_buffer_in_windows_safely): Add prototype.
5527 * window.c: Declare Qdelete_window static again. Move down
5528 declaration of select_count.
5529 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5530 (Fother_window): Move to window.el.
5531 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5532 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5533 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5535 (replace_buffer_in_windows): Implement by calling
5536 Qreplace_buffer_in_windows.
5537 (replace_buffer_in_all_windows): Remove with some functionality
5538 moved into replace_buffer_in_windows_safely.
5539 (replace_buffer_in_windows_safely): New function.
5540 (select_window_norecord, select_frame_norecord): Move in front
5541 of run_window_configuration_change_hook. Remove now obsolete
5543 (Fset_window_buffer): Rewrite doc-string.
5544 Call Qrecord_window_buffer.
5545 (keys_of_window): Move binding for other-window to window.el.
5547 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5549 * dispextern.h (struct image): Replace data member, whose int_val
5550 and ptr_val fields were not used by anything, with a single
5553 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5554 (gif_clear_image, gif_load, imagemagick_load_image)
5555 (gs_clear_image, gs_load): Callers changed.
5557 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5559 * buffer.h: Include <time.h>, for time_t.
5560 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5562 Fix minor problems found by static checking.
5564 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5566 Make identifiers static if they are not used in other modules.
5567 * data.c (Qcompiled_function, Qframe, Qvector):
5568 * image.c (QimageMagick, Qsvg):
5569 * minibuf.c (Qmetadata):
5570 * window.c (resize_window_check, resize_root_window): Now static.
5571 * window.h (resize_window_check, resize_root_window): Remove decls.
5573 * window.c (window_deletion_count, delete_deletable_window):
5575 (window_body_lines): Now static.
5576 (Fdelete_other_windows_internal): Mark vars as initialized.
5577 Make sure 'resize_failed' is initialized.
5578 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5579 (resize_window_apply): Remove unused local.
5580 * window.h (delete_deletable_window): Remove decl.
5582 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5583 (imagemagick_load_image): Fix pointer signedness problem by changing
5584 last arg from unsigned char * to char *. All uses changed.
5585 Also, fix a local for similar reasons.
5586 Remove unused locals. Remove locals to avoid shadowing.
5587 (fn_rsvg_handle_free): Remove; unused.
5588 (svg_load, svg_load_image): Fix pointer signedness problem.
5589 (imagemagick_load_image): Don't use garbage pointer image_wand.
5591 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5593 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5595 * image.c (gif_load): Fix omitted cast error introduced by
5598 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5600 * window.h (resize_proportionally, orig_total_lines)
5601 (orig_top_line): Remove from window structure.
5602 (set_window_height, set_window_width, change_window_heights)
5603 (Fdelete_window): Remove prototypes.
5604 (resize_frame_windows): Remove duplicate declaration.
5606 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5608 * window.h (resize_frame_windows, resize_window_check)
5609 (delete_deletable_window, resize_root_window)
5610 (resize_frame_windows): Declare prototypes.
5612 * window.c (resize_window_apply): Make definition be "static" to
5613 match the prototype.
5615 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5617 * window.c: Remove declarations of Qwindow_size_fixed,
5618 window_min_size_1, window_min_size_2, window_min_size,
5619 size_window, window_fixed_size_p, enlarge_window, delete_window.
5620 Remove static from declaration of Qdelete_window, it's
5621 temporarily needed by Fbury_buffer.
5622 (replace_window): Don't assign orig_top_line and
5624 (Fdelete_window, delete_window): Remove. Window deletion is
5625 handled by window.el.
5626 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5627 Replace Fdelete_window calls with calls to Qdelete_window.
5628 (Fdelete_other_windows): Remove. Deleting other windows is
5629 handled by window.el.
5630 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5631 handled in window.el.
5632 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5633 Window minimum sizes are handled in window.el.
5634 (shrink_windows, size_window, set_window_height)
5635 (set_window_width, change_window_heights, window_height)
5636 (window_width, CURBEG, CURSIZE, enlarge_window)
5637 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5638 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5639 handled in window.el.
5640 (make_dummy_parent): Rename to make_parent_window and give it a
5641 second argument horflag.
5642 (make_window): Don't set resize_proportionally any more.
5643 (Fsplit_window): Remove. Windows are split in window.el.
5644 (save_restore_action, save_restore_orig_size)
5645 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5646 Resize mini windows in window.el.
5647 (grow_mini_window, shrink_mini_window): Implement by calling
5648 Qresize_root_window_vertically, resize_window_check and
5649 resize_window_apply.
5650 (saved_window, Fset_window_configuration, save_window_save):
5651 Do not handle orig_top_line, orig_total_lines, and
5652 resize_proportionally.
5653 (window_min_height, window_min_width): Move to window.el.
5654 (keys_of_window): Move bindings for delete-other-windows,
5655 split-window, delete-window and enlarge-window to window.el.
5657 * buffer.c: Temporarily extern Qdelete_window.
5658 (Fbury_buffer): Temporarily call Qdelete_window instead of
5659 Fdelete_window (Fbury_buffer will move to window.el soon).
5661 * frame.c (set_menu_bar_lines_1): Remove code handling
5662 orig_top_line and orig_total_lines.
5664 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5665 set_window_height but set heights directly.
5666 (change_frame_size_1): Use resize_frame_windows.
5668 * xdisp.c (init_xdisp): Don't use set_window_height but set
5671 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5672 Use resize_frame_windows instead of change_window_heights and run
5673 run_window_configuration_change_hook.
5675 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5676 instead of change_window_heights and run
5677 run_window_configuration_change_hook.
5679 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5681 * window.c (replace_window): Rename second argument REPLACEMENT to
5682 NEW. New third argument SETFLAG. Rewrite.
5683 (delete_window, make_dummy_parent): Call replace_window with
5685 (window_list_1): Move down in code.
5686 (run_window_configuration_change_hook): Move set_buffer part
5687 before select_frame_norecord part in order to unwind correctly.
5688 Rename count1 to count.
5689 (recombine_windows, delete_deletable_window, resize_root_window)
5690 (Fdelete_other_windows_internal)
5691 (Frun_window_configuration_change_hook, make_parent_window)
5692 (resize_window_check, resize_window_apply, Fresize_window_apply)
5693 (resize_frame_windows, Fsplit_window_internal)
5694 (Fdelete_window_internal, Fresize_mini_window_internal):
5696 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5698 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5700 * window.h (window): Add some new members to window structure -
5701 normal_lines, normal_cols, new_total, new_normal, clone_number,
5702 splits, nest, prev_buffers, next_buffers.
5703 (WINDOW_TOTAL_SIZE): Move here from window.c.
5704 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5706 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5708 (make_dummy_parent): Set new members of windows structure.
5709 (make_window): Move down in code. Handle new members of window
5711 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5712 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5713 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5714 (Fset_window_prev_buffers, Fwindow_next_buffers)
5715 (Fset_window_next_buffers, Fset_window_clone_number):
5717 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5718 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5720 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5721 Argument WINDOW can be now internal window too.
5722 (Fwindow_use_time): Move up in code.
5723 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5725 (Fset_window_configuration, saved_window)
5726 (Fcurrent_window_configuration, save_window_save): Handle new
5727 members of window structure.
5728 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5729 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5730 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5731 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5732 Qget_mru_window, Qresize_root_window,
5733 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5734 Qauto_buffer_name; staticpro them.
5736 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5738 * window.c (Fwindow_total_size, Fwindow_left_column)
5739 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5740 (Fwindow_list_1): New functions.
5741 (window_box_text_cols): Replace with window_body_cols.
5742 (Fwindow_width, Fscroll_left, Fscroll_right):
5743 Use window_body_cols instead of window_box_text_cols.
5744 (delete_window, Fset_window_configuration):
5745 Call delete_all_subwindows with window as argument.
5746 (delete_all_subwindows): Take a window as argument and not a
5748 (window_loop): Remove handling of GET_LRU_WINDOW and
5750 (Fget_lru_window, Fget_largest_window): Move to window.el.
5752 * window.h: Extern window_body_cols instead of
5753 window_box_text_cols. delete_all_subwindows now takes a
5754 Lisp_Object as argument.
5756 * indent.c (compute_motion, Fcompute_motion):
5757 Use window_body_cols instead of window_box_text_cols.
5759 * frame.c (delete_frame): Call delete_all_subwindows with root
5762 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5764 * fns.c (Fputhash): Document return value.
5766 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5768 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5770 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5772 Cons<->int and similar integer overflow fixes (Bug#8794).
5774 Check for overflow when converting integer to cons and back.
5775 * charset.c (Fdefine_charset_internal, Fdecode_char):
5776 Use cons_to_unsigned to catch overflow.
5777 (Fencode_char): Use INTEGER_TO_CONS.
5778 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5779 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5780 * data.c (long_to_cons, cons_to_long): Remove.
5781 (cons_to_unsigned, cons_to_signed): New functions.
5782 These signal an error for invalid or out-of-range values.
5783 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5784 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5785 * font.c (Ffont_variation_glyphs):
5786 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5787 * lisp.h: Include <intprops.h>.
5788 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5789 (cons_to_signed, cons_to_unsigned): New decls.
5790 (long_to_cons, cons_to_long): Remove decls.
5791 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5792 (Fprimitive_undo): Use CONS_TO_INTEGER.
5793 * xfns.c (Fx_window_property): Likewise.
5794 * xselect.c: Include <limits.h>.
5795 (x_own_selection, selection_data_to_lisp_data):
5796 Use INTEGER_TO_CONS.
5797 (x_handle_selection_request, x_handle_selection_clear)
5798 (x_get_foreign_selection, Fx_disown_selection_internal)
5799 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5800 (lisp_data_to_selection_data): Use cons_to_unsigned.
5801 (x_fill_property_data): Use cons_to_signed.
5802 Report values out of range.
5804 Check for buffer and string overflow more precisely.
5805 * buffer.h (BUF_BYTES_MAX): New macro.
5806 * lisp.h (STRING_BYTES_MAX): New macro.
5807 * alloc.c (Fmake_string):
5808 * character.c (string_escape_byte8):
5809 * coding.c (coding_alloc_by_realloc):
5810 * doprnt.c (doprnt):
5811 * editfns.c (Fformat):
5813 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5814 since they may not be the same number.
5815 * editfns.c (Finsert_char):
5816 * fileio.c (Finsert_file_contents):
5817 Likewise for BUF_BYTES_MAX.
5819 * image.c: Use ptrdiff_t, not int, for sizes.
5820 (slurp_file): Switch from int to ptrdiff_t.
5822 (slurp_file): Check that file size fits in both size_t (for
5823 malloc) and ptrdiff_t (for sanity and safety).
5825 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5826 if b->modtime has its maximal value.
5828 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5830 Don't assume time_t can fit into int.
5831 * buffer.h (struct buffer.modtime): Now time_t, not int.
5832 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5833 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5835 Minor fixes for signed vs unsigned integers.
5836 * character.h (MAYBE_UNIFY_CHAR):
5837 * charset.c (maybe_unify_char):
5838 * keyboard.c (read_char, reorder_modifiers):
5839 XINT -> XFASTINT, since the integer must be nonnegative.
5840 * ftfont.c (ftfont_spec_pattern):
5841 * keymap.c (access_keymap, silly_event_symbol_error):
5842 XUINT -> XFASTINT, since the integer must be nonnegative.
5843 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5844 since it makes no difference and we prefer signed.
5845 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5846 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5849 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5851 * window.h (Fwindow_frame): Declare.
5853 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5855 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5856 (SPARE_MEMORY): Always define.
5857 (LARGE_REQUEST): Remove.
5858 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5860 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5862 * lisp.h: Move EXFUNS for Fframe_root_window,
5863 Fframe_first_window and Fset_frame_selected_window to window.h.
5865 * window.h: Move EXFUNS for Fframe_root_window,
5866 Fframe_first_window and Fset_frame_selected_window here from
5869 * frame.c (Fwindow_frame, Fframe_first_window)
5870 (Fframe_root_window, Fframe_selected_window)
5871 (Fset_frame_selected_window): Move to window.c.
5872 (Factive_minibuffer_window): Move to minibuf.c.
5873 (Fother_visible_frames_p): New function.
5875 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5877 * window.c (decode_window, decode_any_window): Move up in code.
5878 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5879 (inhibit_frame_unsplittable): Remove unused variable.
5880 (Fwindow_buffer): Move up and rewrite doc-string.
5881 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5882 (Fwindow_prev): New functions.
5883 (Fwindow_frame): Move here from frame.c. Accept any window as
5885 (Fframe_root_window, Fframe_first_window)
5886 (Fframe_selected_window): Move here from frame.c. Accept frame
5887 or arbitrary window as argument. Update doc-strings.
5888 (Fminibuffer_window): Move up in code.
5889 (Fwindow_minibuffer_p): Move up in code and simplify.
5890 (Fset_frame_selected_window): Move here from frame.c.
5892 (Fselected_window, select_window, Fselect_window): Move up in
5893 code. Minor doc-string fixes.
5895 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5897 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5898 Do not assume that spare memory exists; that assumption is valid
5899 only if SYSTEM_MALLOC.
5900 (LARGE_REQUEST): New macro, so that the issue of large requests
5901 is separated from the issue of spare memory.
5903 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5905 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5908 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5910 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5913 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5915 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5917 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5919 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5920 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5922 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5924 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5926 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5928 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5929 (x_clipboard_manager_save): Add return value.
5930 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5932 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5933 Obey Vx_select_enable_clipboard_manager. Catch errors in
5934 x_clipboard_manager_save (Bug#8779).
5935 (Vx_select_enable_clipboard_manager): New variable.
5936 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5938 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5940 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5942 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5944 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5945 in the current matrix if keep_current_p is non-zero.
5947 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5949 * bidi.c (bidi_level_of_next_char): Fix last change.
5951 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5953 Support bidi reordering of text covered by display properties.
5955 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5956 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5957 (bidi_cache_search, bidi_cache_iterator_state)
5958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5959 (bidi_level_of_next_char, bidi_move_to_visually_next):
5960 Support character positions inside a run of characters covered by a
5962 (bidi_paragraph_init, bidi_resolve_explicit_1)
5963 (bidi_level_of_next_char): Call bidi_fetch_char and
5964 bidi_fetch_char_advance instead of FETCH_CHAR and
5966 (bidi_init_it): Initialize new members.
5967 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5969 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5970 instead of using explicit *_CHAR codes.
5971 (bidi_resolve_explicit, bidi_resolve_weak):
5972 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5973 bidirectional text is supported only in multibyte buffers.
5974 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5975 it to initialize the frame_window_p member of struct bidi_it.
5976 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5977 (bidi_resolve_explicit, bidi_resolve_weak)
5978 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5979 bidi_it->nchars is non-positive.
5980 (bidi_level_of_next_char): Don't try to lookup the cache for the
5981 next/previous character if nothing is cached there yet, or if we
5982 were just reseat()'ed to a new position.
5984 * xdisp.c (set_cursor_from_row): Set start and stop points
5985 according to the row's direction when priming the loop that looks
5986 for the glyph on which to display cursor.
5987 (single_display_spec_intangible_p): Function deleted.
5988 (display_prop_intangible_p): Reimplement to call
5989 handle_display_spec instead of single_display_spec_intangible_p.
5990 Accept 3 additional arguments needed by handle_display_spec.
5991 This fixes incorrect cursor motion across display property with complex
5992 values: lists, `(when COND...)' forms, etc.
5993 (single_display_spec_string_p): Support property values that are
5994 lists with the argument STRING its top-level element.
5995 (display_prop_string_p): Fix the condition for processing a
5996 property that is a list to be consistent with handle_display_spec.
5997 (handle_display_spec): New function, refactored from the
5998 last portion of handle_display_prop.
5999 (compute_display_string_pos): Accept additional argument
6000 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6001 value of a `display' property is a "replacing spec".
6002 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6003 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6004 the display property, but just return a value indicating whether
6005 the display property will replace the characters it covers.
6006 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6007 frame_window_p members of struct bidi_it.
6008 (compute_display_string_pos, compute_display_string_end):
6010 (push_it): Accept second argument POSITION, where pop_it should
6011 jump to continue iteration.
6012 (reseat_1): Initialize bidi_it.disp_pos.
6014 * keyboard.c (adjust_point_for_property): Adjust the call to
6015 display_prop_intangible_p to its new signature.
6017 * dispextern.h (struct bidi_it): New member frame_window_p.
6018 (bidi_init_it): Update prototypes.
6019 (display_prop_intangible_p): Update prototype.
6020 (compute_display_string_pos, compute_display_string_end):
6022 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6025 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6027 Malloc failure behavior now depends on size of allocation.
6028 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6029 * lisp.h: Change signatures accordingly.
6030 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6031 All callers changed. (Bug#8762)
6033 * gnutls.c: Use Emacs's memory allocators.
6034 Without this change, the gnutls library would invoke malloc etc.
6035 directly, which causes problems on non-SYNC_INPUT hosts, and which
6036 runs afoul of improving memory_full behavior. (Bug#8761)
6037 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6038 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6039 xfree instead of the default malloc, realloc, free.
6040 (Fgnutls_boot): No need to check for memory allocation failure,
6041 since xmalloc does that for us.
6043 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6044 * category.c (hash_get_category_set):
6045 * ccl.c (ccl_driver):
6046 * charset.c (Fdefine_charset_internal):
6047 * charset.h (struct charset.hash_index):
6048 * composite.c (get_composition_id, gstring_lookup_cache)
6049 (composition_gstring_put_cache):
6050 * composite.h (struct composition.hash_index):
6051 * dispextern.h (struct image.hash):
6052 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6053 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6054 (hashfn_equal, hashfn_user_defined, make_hash_table)
6055 (maybe_resize_hash_table, hash_lookup, hash_put)
6056 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6057 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6058 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6059 * image.c (make_image, search_image_cache, lookup_image)
6060 (xpm_put_color_table_h):
6061 * lisp.h (struct Lisp_Hash_Table):
6062 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6063 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6064 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6065 * alloc.c (allocate_vectorlike):
6066 Check for overflow in vector size calculations.
6067 * ccl.c (ccl_driver):
6068 Check for overflow when converting EMACS_INT to int.
6069 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6070 need to be updated by these changes.
6071 * fns.c (make_hash_table, maybe_resize_hash_table):
6072 Check for integer overflow with large hash tables.
6073 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6074 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6075 (SXHASH_REDUCE): New macro.
6076 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6077 Use it instead of discarding useful hash info with large hash values.
6078 (sxhash_float): New function.
6079 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6080 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6081 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6082 Rewrite to use FIXNUM_BITS, as this simplifies things.
6083 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6084 Adjust signatures to match updated version of code.
6085 (consing_since_gc): Now EMACS_INT, since a single hash table can
6086 use more than INT_MAX bytes.
6088 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6090 Make it possible to build with GCC-4.6+ -O2 -flto.
6092 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6094 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6096 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6097 Call minibuffer-inactive-mode.
6099 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6101 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6102 Update dependencies.
6104 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6106 * data.c (init_data): Remove code for UTS, this system is not
6109 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6111 Don't force ./temacs to start in terminal mode.
6113 * frame.c (make_initial_frame): Initialize faces in all cases, not
6114 only when CANNOT_DUMP is defined.
6115 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6117 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6119 * dispnew.c (add_window_display_history): Use const for the string
6120 pointer. Remove declaration, not needed.
6122 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6124 Use 'inline', not 'INLINE'.
6125 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6126 * alloc.c, fontset.c (INLINE): Remove.
6127 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6128 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6129 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6130 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6131 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6133 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6135 Make it possible to run ./temacs.
6137 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6138 syms_of_callproc does the same thing. Remove test for
6139 "initialized", do it in the caller.
6140 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6142 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6144 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6145 (read_minibuf): Use get_minibuffer.
6146 (syms_of_minibuf): Use DEFSYM.
6147 (Qmetadata): New var.
6148 * data.c (Qbuffer): Don't make it static.
6149 (syms_of_data): Use DEFSYM.
6151 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6153 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6154 (CCL_CODE_MIN): New macro.
6156 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6158 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6160 * eval.c (Qdebug): Now static.
6161 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6162 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6163 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6165 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6167 * image.c: Various fixes to ImageMagick code comments.
6168 (Fimagemagick_types): Doc fix.
6170 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6172 Minor fixes prompted by GCC 4.6.0 warnings.
6174 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6176 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6177 (x_clipboard_manager_save_all): Move extern decl to ...
6178 * xterm.h: ... here, so that it can be checked for consistency.
6180 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6182 * xselect.c (x_clipboard_manager_save_frame)
6183 (x_clipboard_manager_save_all): New functions.
6184 (Fx_clipboard_manager_save): Lisp function deleted.
6186 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6187 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6189 * xterm.h: Update prototype.
6191 2011-05-28 William Xu <william.xwl@gmail.com>
6193 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6196 2011-05-28 Jim Meyering <meyering@redhat.com>
6198 Avoid a sign-extension bug in crypto_hash_function.
6199 * fns.c (to_uchar): Define.
6200 (crypto_hash_function): Use it to convert some newly-signed
6201 variables to unsigned, to avoid sign-extension bugs. For example,
6202 without this change, (md5 "truc") would evaluate to
6203 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6204 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6205 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6207 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6209 Integer overflow fixes.
6211 * dbusbind.c: Serial number integer overflow fixes.
6212 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6213 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6214 to hold a serial number that is too large for a fixnum.
6215 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6216 Check for serial numbers out of range. Decode any serial number
6217 that was so large that it became a float. (Bug#8722)
6219 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6220 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6221 Use XFASTINT rather than XUINT when numbers are nonnegative.
6222 (xd_append_arg, Fdbus_method_return_internal):
6223 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6224 arguments, check that Lisp number is nonnegative, rather than
6225 silently wrapping negative numbers around. (Bug#8722)
6226 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6229 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6231 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6233 ccl: Add integer overflow checks.
6234 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6235 (IN_INT_RANGE): New macros.
6236 (ccl_driver): Use them to check for integer overflow when
6237 decoding a CCL program. Many of the new checks are whether XINT (x)
6238 fits in int; it doesn't always, on 64-bit hosts. The new version
6239 doesn't catch all possible integer overflows, but it's an
6240 improvement. (Bug#8719)
6242 * alloc.c (make_event_array): Use XINT, not XUINT.
6243 There's no need for unsigned here.
6245 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6246 This follows up to the 2011-05-06 change that substituted uintptr_t
6247 for EMACS_INT. This case wasn't caught back then.
6249 Rework Fformat to avoid integer overflow issues.
6250 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6251 now (part of C89). Include <verify.h>.
6252 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6253 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6254 (Fformat): Avoid the prepass trying to compute sizes; it was only
6255 approximate and thus did not catch overflow reliably. Instead, walk
6256 through the format just once, formatting and computing sizes as we go,
6257 checking for integer overflow at every step, and allocating a larger
6258 buffer as needed. Keep track separately whether the format is
6259 multibyte. Keep only the most-recently calculated precision, rather
6260 than them all. Record whether each argument has been converted to
6261 string. Use EMACS_INT, not int, for byte and char and arg counts.
6262 Support field widths and precisions larger than INT_MAX. Avoid
6263 sprintf's undefined behavior with conversion specifications such as %#d
6264 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6265 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6266 formatting out-of-range floating point numbers with int
6269 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6271 * data.c: Avoid integer truncation in expressions involving floats.
6272 * data.c: Include <intprops.h>.
6273 (arith_driver): When there's an integer overflow in an expression
6274 involving floating point, convert the integers to floating point
6275 so that the resulting value does not suffer from catastrophic
6276 integer truncation. For example, on a 64-bit host (* 4
6277 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6278 Do not rely on undefined behavior after integer overflow.
6280 merge count_size_as_multibyte, parse_str_to_multibyte
6281 * character.c, character.h (count_size_as_multibyte):
6282 Rename from parse_str_to_multibyte; all uses changed.
6283 Check for integer overflow.
6284 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6285 since it's now a duplicate of the other. This is more of
6286 a character than a buffer op, so better that it's in character.c.
6287 * fns.c, print.c: Adjust to above changes.
6289 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6291 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6293 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6295 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6296 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6297 (x_clipboard_manager_save): Now static.
6298 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6300 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6301 (crypto_hash_function): Now static.
6302 Fix pointer signedness problems. Avoid unnecessary initializations.
6304 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6306 * termhooks.h (Vselection_alist): Make it terminal-local.
6308 * terminal.c (create_terminal): Initialize it.
6310 * xselect.c: Support for clipboard managers.
6311 (Vselection_alist): Move to termhooks.h as terminal-local var.
6312 (LOCAL_SELECTION): New macro.
6313 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6314 (symbol_to_x_atom): Remove gratuitous arg.
6315 (x_handle_selection_request, lisp_data_to_selection_data)
6316 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6317 (x_own_selection, x_get_local_selection, x_convert_selection):
6318 New arg, specifying work frame. Use terminal-local Vselection_alist.
6319 (some_frame_on_display): Delete unused function.
6320 (Fx_own_selection_internal, Fx_get_selection_internal)
6321 (Fx_disown_selection_internal, Fx_selection_owner_p)
6322 (Fx_selection_exists_p): New optional frame arg.
6323 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6324 (x_handle_selection_clear): Don't treat other terminals with the
6325 same keyboard specially. Use the terminal-local Vselection_alist.
6326 (x_clear_frame_selections): Use Frun_hook_with_args.
6328 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6330 * xterm.h: Add support for those atoms.
6332 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6334 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6335 (converted_selections, conversion_fail_tag): New global variables.
6336 (x_selection_request_lisp_error): Free the above.
6337 (x_get_local_selection): Remove unnecessary code.
6338 (x_reply_selection_request): Args changed; handle arbitrary array
6339 of converted selections stored in converted_selections.
6340 Separate the XChangeProperty and SelectionNotify steps.
6341 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6342 (x_convert_selection): New function.
6343 (x_handle_selection_event): Simplify.
6344 (x_get_foreign_selection): Don't ignore incoming requests while
6345 waiting for an answer; this will fail when we implement
6346 SAVE_TARGETS, and seems unnecessary anyway.
6347 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6348 (Vx_sent_selection_functions): Doc fix.
6350 2011-05-26 Leo Liu <sdl.web@gmail.com>
6352 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6354 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6356 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6358 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6359 for fringe update if it has periodic bitmap.
6360 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6361 and fringe_bitmap_periodic_p.
6363 * fringe.c (get_fringe_bitmap_data): New function.
6364 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6365 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6366 row. Mark glyph row for fringe update if periodicity changed.
6368 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6369 for fringe update unless it has periodic bitmap.
6371 2011-05-25 Kenichi Handa <handa@m17n.org>
6373 * xdisp.c (get_next_display_element): Set correct it->face_id for
6374 a static composition.
6376 2011-05-24 Leo Liu <sdl.web@gmail.com>
6379 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6381 * fns.c (crypto_hash_function, Fsha1): New function.
6382 (Fmd5): Use crypto_hash_function.
6383 (syms_of_fns): Add Ssha1.
6385 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6387 * gnutls.c: Remove unused macros.
6388 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6389 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6390 Remove macros that are defined and never used.
6391 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6393 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6395 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6396 (Fx_get_selection_internal): Minor cleanup.
6397 (Fx_own_selection_internal): Rename arguments for consistency with
6400 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6402 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6404 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6406 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6408 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6410 * dispnew.c (scrolling_window): Don't exclude the case that the
6411 last enabled row in the desired matrix touches the bottom boundary.
6413 2011-05-21 Glenn Morris <rgm@gnu.org>
6415 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6416 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6417 and add some more files.
6419 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6421 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6422 report_file_error introduced by the change from 2011-05-07.
6424 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6426 * systime.h (Time): Define only if emacs is defined.
6427 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6428 where the include path doesn't have X11/X.h by default. See
6429 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6431 2011-05-20 Kenichi Handa <handa@m17n.org>
6433 * composite.c (find_automatic_composition): Fix previous change.
6435 2011-05-20 Glenn Morris <rgm@gnu.org>
6437 * lisp.mk: New file, split from Makefile.in.
6438 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6439 (shortlisp): Remove.
6440 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6442 2011-05-19 Glenn Morris <rgm@gnu.org>
6444 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6445 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6446 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6447 (lisp): Set the order to that of loadup.el.
6448 (shortlisp): Make it a copy of $lisp.
6449 (SOME_MACHINE_LISP): Remove.
6450 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6451 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6453 2011-05-18 Kenichi Handa <handa@m17n.org>
6455 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6456 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6457 (find_automatic_composition): Mostly rewrite for efficiency.
6459 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6461 * makefile.w32-in: Update dependencies.
6463 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6465 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6466 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6468 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6470 Fix some integer overflow issues, such as string length overflow.
6472 * insdel.c (count_size_as_multibyte): Check for string overflow.
6474 * character.c (lisp_string_width): Check for string overflow.
6475 Use EMACS_INT, not int, for string indexes and lengths; in
6476 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6477 the resulting string length overflows an EMACS_INT; instead,
6478 report a string overflow if no precision given. When checking for
6479 precision exhaustion, use a check that cannot possibly have
6480 integer overflow. (Bug#8675)
6481 * character.h (lisp_string_width): Adjust to new signature.
6483 * alloc.c (string_overflow): New function.
6484 (Fmake_string): Use it. This doesn't change behavior, but saves
6485 a few bytes and will simplify future changes.
6486 * character.c (string_escape_byte8): Likewise.
6487 * lisp.h (string_overflow): New decl.
6489 Fixups, following up to the user-interface timestamp change.
6490 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6491 for UI timestamps, instead of unsigned long.
6492 * msdos.c (mouse_get_pos): Likewise.
6493 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6494 * w32gui.h (Time): Define by including "systime.h" rather than by
6495 declaring it ourselves. (Bug#8664)
6497 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6498 * image.c (clear_image_cache): Likewise.
6500 * term.c (term_mouse_position): Don't assume time_t wraparound.
6502 Be more systematic about user-interface timestamps.
6503 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6504 and sometimes 'EMACS_UINT', to represent these timestamps.
6505 This change causes it to use 'Time' uniformly, as that's what X uses.
6506 This makes the code easier to follow, and makes it easier to catch
6507 integer overflow bugs such as Bug#8664.
6508 * frame.c (Fmouse_position, Fmouse_pixel_position):
6509 Use Time, not unsigned long, for user-interface timestamps.
6510 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6511 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6512 * keyboard.h (last_event_timestamp): Likewise.
6513 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6514 * menu.h (xmenu_show): Likewise.
6515 * term.c (term_mouse_position): Likewise.
6516 * termhooks.h (struct input_event.timestamp): Likewise.
6517 (struct terminal.mouse_position_hook): Likewise.
6518 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6519 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6520 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6521 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6523 * menu.h, termhooks.h: Include "systime.h", for Time.
6525 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6526 Don't assume that the difference between two unsigned long values
6527 can fit into an integer. At this point, we know button_down_time
6528 <= event->timestamp, so the difference must be nonnegative, so
6529 there's no need to cast the result if double-click-time is
6530 nonnegative, as it should be; check that it's nonnegative, just in
6531 case. This bug is triggered when events are more than 2**31 ms
6532 apart (about 25 days). (Bug#8664)
6534 * xselect.c (last_event_timestamp): Remove duplicate decl.
6535 (x_own_selection): Remove needless cast to unsigned long.
6537 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6538 that always fit in int. Use a sentinel instead of a counter, to
6539 avoid a temp and to allay GCC's concerns about possible int overflow.
6540 * frame.h (struct frame): Use int for menu_bar_items_used
6541 instead of EMACS_INT, since it always fits in int.
6543 * menu.c (grow_menu_items): Check for int overflow.
6545 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6547 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6548 Before, the code was not consistent. These values cannot exceed
6549 2**31 - 1 so there's no need to make them unsigned.
6550 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6551 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6552 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6554 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6556 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6557 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6558 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6559 presumably because the widths might not match.
6561 * window.c (size_window): Avoid needless test at loop start.
6563 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6565 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6567 2011-05-12 Drew Adams <drew.adams@oracle.com>
6569 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6571 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6573 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6574 `width' to `bar_area_x' and `bar_area_width', respectively.
6575 (x_scroll_run): Take account of fringe background extension.
6577 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6578 Rename local vars `left' and `width' to `bar_area_x' and
6579 `bar_area_width', respectively.
6580 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6581 background extension.
6583 2011-05-10 Jim Meyering <meyering@redhat.com>
6585 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6587 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6589 * image.c (Finit_image_library): Return t for built-in image types,
6590 like pbm and xbm. (Bug#8640)
6592 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6594 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6596 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6598 * w32console.c (Fset_screen_color): Doc fix.
6599 (Fget_screen_color): New function.
6600 (syms_of_ntterm): Defsubr it.
6602 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6603 unlink the temporary file if Fcall_process didn't create it in the
6605 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6606 child process will be redirected to a file specified with `:file'.
6607 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6608 cue to call_process_cleanup not to close that handle.
6610 2011-05-07 Ben Key <bkey76@gmail.com>
6612 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6613 one of two shell specific rules, either bootstrap-temacs-CMD or
6614 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6615 to the previous implementation of the bootstrap-temacs rule.
6616 The bootstrap-temacs-CMD rule is similar to the previous
6617 implementation of the bootstrap-temacs rule except that it
6618 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6621 These changes, along with some changes to nt/configure.bat,
6622 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6623 earlier fix to add support for --cflags and --ldflags options
6624 that include quotes so that it works whether make uses cmd or
6627 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6629 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6630 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6632 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6633 a string. Handle both cases.
6634 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6635 (Fdbus_register_method): Use Qinvalid_function.
6637 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6639 * makefile.w32-in: Update dependencies.
6640 (LISP_H): Add inttypes.h and stdin.h.
6641 (PROCESS_H): Add unistd.h.
6643 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6645 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6646 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6648 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6650 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6652 * term.c (vfatal): Remove stray call to va_end.
6653 It's not needed and the C Standard doesn't allow it here anyway.
6655 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6656 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6658 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6661 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6663 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6665 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6667 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6669 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6671 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6672 * charset.c (Fdefine_charset_internal): Don't initialize
6673 charset.code_space[15]. The value was garbage, on hosts with
6674 32-bit int (Bug#8600).
6676 * lread.c (read_integer): Be more consistent with string-to-number.
6677 Use string_to_number to do the actual conversion; this avoids
6678 rounding errors and fixes some other screwups. Without this fix,
6679 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6680 (digit_to_number): Move earlier, for benefit of read_integer.
6681 Return -1 if the digit is out of range for the base, -2 if it is
6682 not a digit in any supported base. (Bug#8602)
6684 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6686 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6687 to match comment at start of function. This also removes a
6688 GCC warning about overflow in a 32+64-bit port.
6690 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6692 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6693 Reported by Stefan Monnier in
6694 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6695 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6696 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6698 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6699 (EMACS_UINTPTR): Likewise, with uintptr_t.
6701 * lisp.h: Prefer 64-bit EMACS_INT if available.
6702 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6703 on 32-bit hosts that have 64-bit int, so that they can access
6705 However, temporarily disable this change unless the temporary
6706 symbol WIDE_EMACS_INT is defined.
6708 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6710 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6711 This removes an assumption that EMACS_INT and long are the same
6712 width as pointers. The assumption is true for Emacs porting targets
6713 now, but we want to make other targets possible.
6714 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6715 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6716 In the rest of the code, change types of integers that hold casted
6717 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6718 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6719 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6720 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6721 No need to cast type when ORing.
6722 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6723 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6724 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6725 assume EMACS_INT is the same width as char *.
6726 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6727 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6728 Remove no-longer-needed casts.
6729 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6730 (xg_tool_bar_help_callback, xg_make_tool_item):
6731 Use EMACS_INTPTR to hold an integer
6732 that will be cast to void *; this can avoid a GCC warning
6733 if EMACS_INT is not the same width as void *.
6734 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6735 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6736 (current_message_1, set_message_1):
6737 Use a local to convert to proper width without a cast.
6738 * xmenu.c (dialog_selection_callback): Likewise.
6740 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6741 Also, don't assume VALBITS / RAND_BITS is less than 5,
6742 and don't rely on undefined behavior when shifting a 1 left into
6744 * lisp.h (get_random): Change signature to match.
6746 * lread.c (hash_string): Use size_t, not int, for hash computation.
6747 Normally we prefer signed values; but hashing is special, because
6748 it's better to use unsigned division on hash table sizes so that
6749 the remainder is nonnegative. Also, size_t is the natural width
6750 for hashing into memory. The previous code used 'int', which doesn't
6751 retain enough info to hash well into very large tables.
6752 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6754 * dbusbind.c: Don't possibly lose pointer info when converting.
6755 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6756 Use XPNTR rather than XHASH, so that the high-order bits of
6757 the pointer aren't lost when converting through void *.
6759 * eval.c (Fautoload): Don't double-shift a pointer.
6761 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6763 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6765 * gnutls.c (DEF_GNUTLS_FN):
6766 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6768 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6770 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6773 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6775 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6776 New version that can reserve upto 2GB of heap space.
6778 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6780 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6782 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6784 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6785 `gnutls_certificate_set_x509_key_file'.
6787 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6789 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6790 Update dependencies.
6792 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6794 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6795 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6796 Remove unused parameter `fildes'.
6797 * process.c (read_process_output, send_process): Don't pass it.
6799 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6801 Fix previous change: the library cache is defined in w32.c.
6802 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6803 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6805 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6807 Implement dynamic loading of GnuTLS on Windows.
6809 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6810 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6811 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6814 * gnutls.c (Qgnutls_dll): Define.
6815 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6816 (gnutls_*): Declare function pointers.
6817 (init_gnutls_functions): New function to initialize function pointers.
6818 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6819 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6820 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6821 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6822 (emacs_gnutls_write, emacs_gnutls_read)
6823 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6824 (Fgnutls_available_p): New function.
6825 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6826 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6827 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6829 * image.c: Include w32.h.
6830 (Vimage_type_cache): Delete.
6831 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6832 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6833 (w32_delayed_load): Move to w32.c.
6835 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6837 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6838 (w32_delayed_load): Move from image.c. When loading a library, record
6839 its filename in the :loaded-from property of the library id.
6840 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6841 Initialize and staticpro them.
6842 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6844 * process.c: Include lisp.h before w32.h, not after.
6845 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6846 instead of gnutls_record_check_pending.
6848 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6850 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6852 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6853 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6856 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6858 * xterm.c (x_set_frame_alpha): Do not set property on anything
6859 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6861 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6863 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6865 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6867 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6868 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6869 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6870 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6871 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6872 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6873 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6874 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6875 (Qgnutls_bootprop_callbacks_verify): Make static.
6877 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6879 * callproc.c: Indentation fixup.
6881 * sysdep.c (wait_for_termination_1): Make static.
6882 (wait_for_termination, interruptible_wait_for_termination):
6883 Move after wait_for_termination_1.
6885 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6887 * sysdep.c (interruptible_wait_for_termination): New function
6888 which is like wait_for_termination, but allows keyboard
6891 * callproc.c (Fcall_process): Add (:file "file") as an option for
6893 (Fcall_process_region): Ditto.
6895 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6897 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6898 rather than `XVECTOR (FOO)->size'.
6900 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6901 inttypes.h, as a gnulib replacement is used if it not available in
6904 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6906 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6907 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6908 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6910 * coding.c (coding_alloc_by_realloc): Error out if destination
6911 will grow beyond MOST_POSITIVE_FIXNUM.
6912 (decode_coding_emacs_mule): Abort if there isn't enough place in
6913 charbuf for the composition carryover bytes. Reserve an extra
6914 space for up to 2 characters produced in a loop.
6915 (decode_coding_iso_2022): Abort if there isn't enough place in
6916 charbuf for the composition carryover bytes.
6918 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6920 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6921 aborting when %lld or %lll format is passed.
6922 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6923 %llo or %llx format is passed. (Bug#8545)
6925 * window.c (window_scroll_line_based): Use a marker instead of
6926 simple variables to record original value of point. (Bug#7952)
6928 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6929 produced by %s or %c overflows available buffer space. (Bug#8545)
6931 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6933 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6934 (SIZE_MAX): Move defn after all includes, as they might #define it.
6936 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6938 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6940 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6942 * keyboard.c (Qdelayed_warnings_hook): Define.
6943 (command_loop_1): Run `delayed-warnings-hook'
6944 if Vdelayed_warnings_list is non-nil.
6945 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6946 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6948 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6950 * doprnt.c (doprnt): Don't return value smaller than the buffer
6951 size if the message was truncated. (Bug#8545).
6953 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6955 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6956 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6958 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6960 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6962 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6964 * makefile.w32-in: Update dependencies.
6966 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6968 Improve `doprnt' and its usage. (Bug#8545)
6969 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6970 `format_end'. Remove support for %l as a conversion specifier.
6971 Don't use xrealloc. Improve diagnostics when the %l size modifier
6972 is used. Update the commentary.
6974 * eval.c (verror): Simplify calculation of size_t.
6976 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6979 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6981 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6984 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6986 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6987 This makes this file independent of the recent pseudovector change.
6989 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6991 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6993 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6994 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6995 Remove unused local.
6996 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6998 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6999 GCC 4.6.0 optimizes based on type-based alias analysis.
7000 For example, if b is of type struct buffer * and v of type struct
7001 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7002 != &v->size, and therefore "v->size = 1; b->size = 2; return
7003 v->size;" must therefore return 1. This assumption is incorrect
7004 for Emacs, since it type-puns struct Lisp_Vector * with many other
7005 types. To fix this problem, this patch adds a new type struct
7006 vectorlike_header that documents the constraints on layout of vectors
7007 and pseudovectors, and helps optimizing compilers not get fooled
7008 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7009 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7010 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7012 (XSETPVECTYPE): Rewrite in terms of new macro.
7013 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7014 This is a bit clearer, and further avoids the possibility of
7015 undesirable aliasing.
7016 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7017 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7018 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7019 since Lisp_Subr is a special case (no "next" field).
7020 (ASIZE): Now uses header.size rather than size.
7021 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7022 to avoid the hassle of writing XVECTOR (foo)->header.size.
7023 (struct vectorlike_header): New type.
7024 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7025 object, to help avoid aliasing.
7026 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7027 (SUBRP): Likewise, since Lisp_Subr is a special case.
7028 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7029 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7030 (struct Lisp_Hash_Table): Combine first two members into a single
7031 struct vectorlike_header member. All uses of "size" and "next" members
7032 changed to be "header.size" and "header.next".
7033 * buffer.h (struct buffer): Likewise.
7034 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7035 * frame.h (struct frame): Likewise.
7036 * process.h (struct Lisp_Process): Likewise.
7037 * termhooks.h (struct terminal): Likewise.
7038 * window.c (struct save_window_data, struct saved_window): Likewise.
7039 * window.h (struct window): Likewise.
7040 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7041 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7042 * buffer.c (init_buffer_once): Likewise.
7043 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7045 * process.c (Fformat_network_address): Use local var for size,
7048 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7050 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7051 * data.c (atof): Remove decl; no longer used or needed.
7052 (digit_to_number): Move to lread.c.
7053 (Fstring_to_number): Use new string_to_number function, to be
7054 consistent with how the Lisp reader treats infinities and NaNs.
7055 Do not assume that floating-point numbers represent EMACS_INT
7056 without losing information; this is not true on most 64-bit hosts.
7057 Avoid double-rounding errors, by insisting on integers when
7058 parsing non-base-10 numbers, as the documentation specifies.
7059 * lisp.h (string_to_number): New decl, replacing ...
7060 (isfloat_string): Remove.
7061 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7062 (read1): Do not accept +. and -. as integers; this
7063 appears to have been a coding error. Similarly, do not accept
7064 strings like +-1e0 as floating point numbers. Do not report
7065 overflow for integer overflows unless the base is not 10 which
7066 means we have no simple and reliable way to continue.
7067 Break out the floating-point parsing into a new
7068 function string_to_number, so that Fstring_to_number parses
7069 floating point numbers consistently with the Lisp reader.
7070 (digit_to_number): Move here from data.c. Make it static inline.
7071 (E_CHAR, EXP_INT): Remove, replacing with ...
7072 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7073 (string_to_number): New function, replacing isfloat_string.
7074 This function checks for valid syntax and produces the resulting
7075 Lisp float number too. Rework it so that string-to-number
7076 no longer mishandles examples like "1.0e+". Use strtoumax,
7077 so that overflow for non-base-10 numbers is reported only when
7078 there's no portable and simple way to convert to floating point.
7080 * textprop.c (set_text_properties_1): Rewrite for clarity,
7081 and to avoid GCC warning about integer overflow.
7083 * intervals.h (struct interval): Use EMACS_INT for members
7084 where EMACS_UINT might cause problems. See
7085 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7086 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7087 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7089 (offset_intervals): Tell GCC not to worry about length overflow
7090 when negating a negative length.
7092 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7093 (overrun_check_free): Likewise.
7095 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7096 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7099 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7100 (gnutls_make_error): Rename local to avoid shadowing.
7101 (gnutls_emacs_global_deinit): ifdef out; not used.
7102 (Fgnutls_boot): Use const for pointer to readonly storage.
7103 Comment out unused local. Fix pointer signedness problems.
7105 * lread.c (openp): Don't stuff size_t into an 'int'.
7106 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7107 about possible signed overflow.
7109 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7110 (GDK_KEY_g): Don't define if already defined.
7111 (xg_prepare_tooltip): Avoid pointer signedness problem.
7112 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7114 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7115 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7117 * xfns.c (Fx_window_property): Simplify a bit,
7118 to make a bit faster and to avoid GCC 4.6.0 warning.
7119 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7121 * fns.c (internal_equal): Don't assume size_t fits in int.
7123 * alloc.c (compact_small_strings): Tighten assertion a little.
7125 Replace pEd with more-general pI, and fix some printf arg casts.
7126 * lisp.h (pI): New macro, generalizing old pEd macro to other
7127 conversion specifiers. For example, use "...%"pI"d..." rather
7128 than "...%"pEd"...".
7129 (pEd): Remove. All uses replaced with similar uses of pI.
7130 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7131 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7132 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7133 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7134 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7135 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7136 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7138 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7139 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7140 * print.c (safe_debug_print, print_object): Likewise.
7141 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7143 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7144 avoiding the 0 flag, which is not portable.
7145 * process.c (Fmake_network_process): Use pI to avoid cast.
7146 * region-cache.c (pp_cache): Likewise.
7147 * xdisp.c (decode_mode_spec): Likewise.
7148 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7149 behavior on 64-bit hosts with printf arg.
7150 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7151 (x_stop_queuing_selection_requests): Likewise.
7152 (x_get_window_property): Don't truncate byte count to an 'int'
7155 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7156 here, since it parses constructs like leading '-' and spaces,
7157 which are not wanted; and it overflows with large numbers.
7158 Instead, simply match F[0-9]+, which is what is wanted anyway.
7160 * alloc.c: Remove unportable assumptions about struct layout.
7161 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7162 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7163 (allocate_vectorlike, make_pure_vector): Use the new macros,
7164 plus offsetof, to remove unportable assumptions about struct layout.
7165 These assumptions hold on all porting targets that I know of, but
7166 they are not guaranteed, they're easy to remove, and removing them
7167 makes further changes easier.
7169 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7170 This doesn't fix a bug but makes the code clearer.
7171 (string_overrun_cookie): Now const. Use initializers that
7172 don't formally overflow signed char, to avoid warnings.
7173 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7174 can cause Emacs to crash when string overrun checking is enabled.
7175 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7176 multiple of sizeof (EMACS_INT); it need not be, if
7177 alignof(EMACS_INT) < sizeof (EMACS_INT).
7178 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7180 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7182 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7184 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7186 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7187 supposed to be handshaking. (Bug#8556)
7188 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7190 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7192 * lisp.h (Qdebug): List symbol.
7193 * eval.c (Qdebug): Restore global linkage.
7194 * keyboard.c (debug-on-event): New variable.
7195 (handle_user_signal): Break into debugger when debug-on-event
7196 matches the current signal symbol.
7198 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7200 * alloc.c (check_sblock, check_string_bytes)
7201 (check_string_free_list): Convert to standard C.
7203 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7205 * w32.c (emacs_gnutls_push): Fix typo.
7207 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7209 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7210 "cast to pointer from integer of different size".
7212 Improve doprnt and its use in verror. (Bug#8545)
7213 * doprnt.c (doprnt): Document the set of format control sequences
7214 supported by the function. Use SAFE_ALLOCA instead of always
7217 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7218 is one byte too soon. Don't use xrealloc; instead xfree and
7221 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7223 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7226 * gnutls.c: Renamed global_initialized to
7227 gnutls_global_initialized. Added internals for the
7228 :verify-hostname-error, :verify-error, and :verify-flags
7229 parameters of `gnutls-boot' and documented those parameters in the
7230 docstring. Start callback support.
7231 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7232 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7233 on error. Return error code.
7234 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7235 (emacs_gnutls_read): Likewise.
7236 (Fgnutls_boot): Return handshake error code.
7237 (emacs_gnutls_handle_error): New function.
7238 (wsaerror_to_errno): Likewise.
7240 * w32.h (emacs_gnutls_pull): Add prototype.
7241 (emacs_gnutls_push): Likewise.
7243 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7244 (emacs_gnutls_push): Likewise.
7246 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7248 * process.c (wait_reading_process_output): Check if GnuTLS
7249 buffered some data internally if no FDs are set for TLS
7252 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7253 (LIBS): Link to USER_LIBS.
7254 ($(BLD)/gnutls.$(0)): New target.
7256 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7258 * xdisp.c (handle_single_display_spec): Rename the
7259 display_replaced_before_p argument into display_replaced_p, to
7260 make it consistent with the commentary. Fix typos in the
7263 * textprop.c (syms_of_textprop): Remove dead code.
7264 (copy_text_properties): Delete obsolete commentary about an
7265 interface that was deleted long ago. Fix typos in the description
7268 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7269 to changes in oldXMenu/XMenu.h from 2011-04-16.
7270 <menu_help_message, prev_menu_help_message>: Constify.
7271 (IT_menu_make_room): menu->help_text is now `const char **';
7274 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7275 to changes in oldXMenu/XMenu.h from 2011-04-16.
7276 (struct XMenu): Declare `help_text' `const char **'.
7278 * xfaces.c <Qunspecified>: Make extern again.
7280 * syntax.c: Include sys/types.h before including regex.h, as
7283 * doc.c (get_doc_string): Improve the format passed to `error'.
7285 * doprnt.c (doprnt): Improve commentary.
7287 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7289 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7292 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7293 changes in globals.h immediately force recompilation.
7294 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7295 $(CURDIR)/s/ms-w32.h.
7296 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7298 * character.c (Fchar_direction): Function deleted.
7299 (syms_of_character): Don't defsubr it.
7300 <char-direction-table>: Deleted.
7302 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7304 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7305 * doprnt.c: Include limits.h.
7306 (SIZE_MAX): New macro.
7307 (doprnt): Return a size_t value. 2nd arg is now size_t.
7308 Many local variables are now size_t instead of int or unsigned.
7309 Improve overflow protection. Support `l' modifier for integer
7310 conversions. Support %l conversion. Don't assume an EMACS_INT
7311 argument for integer conversions and for %c.
7313 * lisp.h (doprnt): Restore prototype.
7315 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7318 * Makefile.in (base_obj): Add back doprnt.o.
7320 * deps.mk (doprnt.o): Add back prerequisites.
7321 (callint.o): Depend on character.h.
7323 * eval.c (internal_lisp_condition_case): Include the handler
7324 representation in the error message.
7325 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7326 when breaking from the loop.
7328 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7330 * callint.c (Fcall_interactively): When displaying error message
7331 about invalid control letter, pass the character's codepoint, not
7332 a pointer to its multibyte form. Improve display of the character
7333 in octal and display also its hex code.
7335 * character.c (char_string): Use %x to display the (unsigned)
7336 codepoint of an invalid character, to avoid displaying a bogus
7339 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7340 `error', not SYMBOL_NAME itself.
7342 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7343 character arguments to `error'.
7345 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7346 to `error' in error message about FINAL_CHAR argument. Make sure
7347 FINAL_CHAR is a character, and use %c when it is passed as
7348 argument to `error'.
7350 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7352 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7354 * w32.c: Include <time.h>.
7355 (sys_localtime): New function.
7357 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7359 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7361 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7363 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7365 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7368 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7370 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7371 gl_state.e_property when gl_state.object is Qt.
7373 * insdel.c (make_gap_larger): Remove limitation of buffer size
7376 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7378 * xdisp.c (lookup_glyphless_char_display)
7379 (produce_glyphless_glyph): Handle cons cell entry in
7380 glyphless-char-display.
7381 (Vglyphless_char_display): Document it.
7383 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7384 glyphless-char-display.
7386 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7388 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7390 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7392 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7393 definition for no-X builds.
7395 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7397 Static checks with GCC 4.6.0 and non-default toolkits.
7399 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7401 * process.c (keyboard_bit_set): Define only if SIGIO.
7402 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7403 (send_process): Repair possible setjmp clobbering.
7405 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7407 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7409 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7411 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7412 Define only if needed.
7414 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7415 by pacifying GCC about it. Maybe it's time to retire it?
7416 * xfaces.c (USG, __TIMEVAL__): Likewise.
7418 * dispextern.h (struct redisplay_interface): Rename param
7420 * termhooks.h (struct terminal): Likewise.
7421 * xterm.c (xembed_send_message): Likewise.
7423 * insdel.c (make_gap_smaller): Define only if
7424 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7426 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7429 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7430 so that we aren't warned about unused symbols.
7432 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7434 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7436 * xfns.c (x_real_positions): Mark locals as initialized.
7438 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7440 * xterm.c: Fix problems found by static analysis with other toolkits.
7441 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7442 (x_dispatch_event): Declare static if USE_GTK, and
7443 define if USE_GTK || USE_X_TOOLKIT.
7444 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7445 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7446 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7447 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7449 * xmenu.c (menu_help_callback): Pointer type fixes.
7450 Use const pointers when pointing at readonly data. Avoid pointer
7452 (FALSE): Remove unused macro.
7453 (update_frame_menubar): Remove unused decl.
7455 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7457 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7458 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7459 (single_menu_item): Rename local to avoid shadowing.
7461 * keyboard.c (make_lispy_event): Remove unused local var.
7463 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7464 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7466 * bitmaps: Change bitmaps from unsigned char back to the X11
7467 compatible char. Avoid the old compiler warnings about
7468 out-of-range initializers by using, for example, '\xab' rather
7471 * xgselect.c (xgselect_initialize): Check vs interface
7472 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7474 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7476 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7477 to read-only memory.
7479 * fns.c (vector): Remove; this old hack is no longer needed.
7481 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7483 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7485 * xrdb.c (x_load_resources): Omit unused local.
7487 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7488 (x_window): Rename locals to avoid shadowing.
7489 (USG): Use the kludged USG macro, to pacify gcc.
7491 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7492 (x_term_init): Remove local to avoid shadowing.
7494 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7496 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7497 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7499 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7501 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7503 Fix regex.c, syntax.c and friends for buffers > 2GB.
7504 * syntax.h (struct gl_state_s): Declare character position members
7507 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7509 * textprop.c (verify_interval_modification, interval_of):
7510 Declare arguments EMACS_INT.
7512 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7515 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7517 * indent.c (Fvertical_motion): Local variable it_start is now
7520 * regex.c (re_match, re_match_2, re_match_2_internal)
7521 (bcmp_translate, regcomp, regexec, print_double_string)
7522 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7523 (re_compile_pattern, re_exec): Declare arguments and local
7524 variables `size_t' and `ssize_t' and return values `regoff_t', as
7526 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7527 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7528 <compile_stack_type>: `size' and `avail' are now `size_t'.
7530 * regex.h <regoff_t>: Use ssize_t, not int.
7531 (re_search, re_search_2, re_match, re_match_2): Arguments that
7532 specify buffer/string position and length are now ssize_t and
7533 size_t. Return type is regoff_t.
7535 2011-04-16 Ben Key <bkey76@gmail.com>
7537 * nsfont.m: Fixed bugs in ns_get_family and
7538 ns_descriptor_to_entity that were caused by using free to
7539 deallocate memory blocks that were allocated by xmalloc (via
7540 xstrdup). This caused Emacs to crash when compiled with
7541 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7542 --enable-checking=xmallocoverrun). xfree is now used to
7543 deallocate these memory blocks.
7545 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7547 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7549 emacs_write: Accept and return EMACS_INT for sizes.
7550 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7552 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7553 Accept and return EMACS_INT.
7554 (emacs_gnutls_write): Return the number of bytes written on
7556 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7557 (emacs_read, emacs_write): Remove check for negative size, as the
7558 Emacs source code has been audited now.
7559 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7560 (emacs_read, emacs_write): Use it.
7561 * process.c (send_process): Adjust to the new signatures of
7562 emacs_write and emacs_gnutls_write. Do not attempt to store
7563 a byte offset into an 'int'; it might overflow.
7564 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7566 * sound.c: Don't assume sizes fit in 'int'.
7567 (struct sound_device.period_size, alsa_period_size):
7568 Return EMACS_INT, not int.
7569 (struct sound_device.write, vox_write, alsa_write):
7570 Accept EMACS_INT, not int.
7571 (wav_play, au_play): Use EMACS_INT to store sizes and to
7572 record read return values.
7574 2011-04-15 Ben Key <bkey76@gmail.com>
7576 * keyboard.c (Qundefined): Don't declare static since it is used
7578 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7579 static since they are used in nsfont.m.
7581 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7583 * process.c (Qprocessp): Don't declare static.
7584 * lisp.h (Qprocessp): Declare again.
7586 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7588 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7590 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7592 Improve C-level modularity by making more things 'static'.
7594 Don't publish debugger-only interfaces to other modules.
7595 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7596 (verify_bytepos, count_markers): Move decls to the only modules
7598 * region-cache.h (pp_cache): Likewise.
7599 * window.h (check_all_windows): Likewise.
7600 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7602 * sysdep.c (croak): Now static, if
7603 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7604 * syssignal.h (croak): Declare only if not static.
7606 * alloc.c (refill_memory_reserve): Now static if
7607 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7608 * lisp.h (refill_memory_reserve): Declare only if not static.
7610 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7611 Define only if USE_LUCID.
7613 * xrdb.c (x_customization_string, x_rm_string): Now static.
7615 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7616 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7618 * xdisp.c (draw_row_with_mouse_face): Now static.
7619 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7621 * window.h (check_all_windows): Mark externally visible.
7623 * window.c (window_deletion_count): Now static.
7625 * undo.c: Make symbols static if they're not exported.
7626 (last_undo_buffer, last_boundary_position, pending_boundary):
7629 * textprop.c (interval_insert_behind_hooks): Now static.
7630 (interval_insert_in_front_hooks): Likewise.
7632 * term.c: Make symbols static if they're not exported.
7633 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7634 (max_frame_lines, tty_set_terminal_modes):
7635 (tty_reset_terminal_modes, tty_turn_off_highlight):
7636 (get_tty_terminal): Now static.
7637 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7638 * termhooks.h (term_mouse_moveto): Do not declare if
7640 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7641 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7643 * sysdep.c: Make symbols static if they're not exported.
7644 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7646 (sigprocmask_set, full_mask): Remove; unused.
7647 (wait_debugging): Mark as visible.
7648 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7649 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7651 * syntax.c (syntax_temp): Define only if !__GNUC__.
7653 * sound.c (current_sound_device, current_sound): Now static.
7655 * search.c (searchbufs, searchbuf_head): Now static.
7657 * scroll.c (scroll_cost): Remove; unused.
7658 * dispextern.h (scroll_cost): Remove decl.
7660 * region-cache.h (pp_cache): Mark as externally visible.
7662 * process.c: Make symbols static if they're not exported.
7663 (process_tick, update_tick, create_process, chan_process):
7664 (Vprocess_alist, proc_buffered_char, datagram_access):
7665 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7666 (deactivate_process): Mark defn as static, as well as decl.
7667 * lisp.h (create_process): Remove decl.
7668 * process.h (chan_process, Vprocess_alist): Remove decls.
7670 * print.c: Make symbols static if they're not exported.
7671 (print_depth, new_backquote_output, being_printed, print_buffer):
7672 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7673 (print_interval, print_number_index, initial_stderr_stream):
7675 * lisp.h (Fprinc): Remove decl.
7676 (debug_output_compilation_hack): Mark as externally visible.
7678 * sysdep.c (croak): Move decl from here to syssignal.h.
7679 * syssignal.h (croak): Put it here, so the API can be checked when
7680 'croak' is called from dissociate_if_controlling_tty.
7682 * minibuf.c: Make symbols static if they're not exported.
7683 (minibuf_save_list, choose_minibuf_frame): Now static.
7684 * lisp.h (choose_minibuf_frame): Remove decl.
7686 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7688 * lread.c: Make symbols static if they're not exported.
7689 (read_objects, initial_obarray, oblookup_last_bucket_number):
7691 (make_symbol): Remove; unused.
7692 * lisp.h (initial_obarray, make_symbol): Remove decls.
7694 * keyboard.c: Make symbols static if they're not exported.
7695 (single_kboard, recent_keys_index, total_keys, recent_keys):
7696 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7697 (this_single_command_key_start, echoing, last_auto_save):
7698 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7699 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7700 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7701 (Vlispy_mouse_stem, double_click_count):
7703 (force_auto_save_soon): Define only if SIGDANGER.
7704 (ignore_mouse_drag_p): Now static if
7705 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7706 (print_help): Remove; unused.
7707 (stop_character, last_timer_event): Mark as externally visible.
7708 * keyboard.h (ignore_mouse_drag_p): Declare only if
7709 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7710 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7711 * lisp.h (echoing): Remove decl.
7712 (force_auto_save_soon): Declare only if SIGDANGER.
7713 * xdisp.c (redisplay_window): Simplify code, to make it more
7714 obvious that ignore_mouse_drag_p is not accessed if !defined
7715 USE_GTK && !defined HAVE_NS.
7717 * intervals.c: Make symbols static if they're not exported.
7718 (merge_properties_sticky, merge_interval_right, delete_interval):
7720 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7722 * insdel.c: Make symbols static if they're not exported.
7723 However, leave prepare_to_modify_buffer alone. It's never
7724 called from outside this function, but that appears to be a bug.
7725 (combine_after_change_list, combine_after_change_buffer):
7726 (adjust_after_replace, signal_before_change): Now static.
7727 (adjust_after_replace_noundo): Remove; unused.
7728 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7729 (signal_before_change): Remove decls.
7731 * indent.c (val_compute_motion, val_vmotion): Now static.
7733 * image.c: Make symbols static if they're not exported.
7734 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7736 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7737 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7739 * fringe.c (standard_bitmaps): Now static.
7740 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7742 * frame.c: Make symbols static if they're not exported.
7743 (x_report_frame_params, make_terminal_frame): Now static.
7744 (get_frame_param): Now static, unless HAVE_NS.
7745 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7746 (x_get_resource_string): Remove; not used.
7747 * frame.h (make_terminal_frame, x_report_frame_params):
7748 (x_get_resource_string); Remove decls.
7749 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7750 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7752 * font.c, fontset.c: Make symbols static if they're not exported.
7753 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7754 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7755 * font.c (font_close_object): Now static.
7756 * font.h (font_close_object): Remove.
7757 * fontset.c (FONTSET_OBJLIST): Remove.
7758 (free_realized_fontset) #if-0 the body, which does nothing.
7759 (face_suitable_for_char_p): #if-0, as it's never called.
7760 * fontset.h (face_suitable_for_char_p): Remove decl.
7761 * xfaces.c (face_at_string_position):
7762 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7763 since 0 is always ASCII.
7765 * fns.c (weak_hash_tables): Now static.
7767 * fileio.c: Make symbols static if they're not exported.
7768 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7769 (Vwrite_region_annotation_buffers): Now static.
7771 * eval.c: Make symbols static if they're not exported.
7772 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7773 * lisp.h (backtrace_list): Remove decl.
7775 * emacs.c: Make symbols static if they're not exported.
7776 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7777 (fatal_error_code, fatal_error_signal_hook, standard_args):
7779 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7780 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7781 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7782 * lisp.h (fatal_error_signal_hook): Remove decl.
7783 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7785 * editfns.c: Move a (normally-unused) function to its only use.
7786 * editfns.c, lisp.h (get_operating_system_release): Remove.
7787 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7788 worth the hassle of breaking this out.
7790 * xterm.c: Make symbols static if they're not exported.
7791 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7792 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7793 (x_destroy_window, x_delete_display):
7795 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7796 (x_mouse_leave): Remove; unused.
7797 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7798 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7799 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7801 (x_mouse_leave): Declare only if WINDOWSNT.
7802 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7803 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7806 * ftxfont.c: Make symbols static if they're not exported.
7807 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7809 * font.h (ftxfont_driver): Likewise.
7811 * xfns.c: Make symbols static if they're not exported.
7812 (x_last_font_name, x_display_info_for_name):
7813 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7814 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7815 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7816 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7817 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7818 (last_show_tip_args): Now static.
7819 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7820 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7821 (x_screen_planes): Remove; unused.
7822 * dispextern.h (x_screen_planes): Remove decl.
7824 * dispnew.c: Make symbols static if they're not exported.
7825 * dispextern.h (redraw_garbaged_frames, scrolling):
7826 (increment_row_positions): Remove.
7827 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7828 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7830 (redraw_garbaged_frames): Remove; unused.
7832 * xfaces.c: Make symbols static if they're not exported.
7833 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7835 * xterm.h (defined_color): Remove decls.
7836 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7837 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7838 (menu_face_changed_default, defined_color, free_realized_face):
7839 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7840 (ascii_face_of_lisp_face): Remove; unused.
7842 * xdisp.c: Make symbols static if they're not exported.
7843 * dispextern.h (scratch_glyph_row, window_box_edges):
7844 (glyph_to_pixel_coords, set_cursor_from_row):
7845 (get_next_display_element, set_iterator_to_next):
7846 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7847 (show_mouse_face): Remove decls
7848 * frame.h (message_buf_print): Likewise.
7849 * lisp.h (pop_message, set_message, check_point_in_composition):
7851 * xterm.h (set_vertical_scroll_bar): Likewise.
7852 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7853 (message_buf_print, scratch_glyph_row, displayed_buffer):
7854 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7855 (get_next_display_element, show_mouse_face, window_box_edges):
7856 (frame_to_window_pixel_xy, check_point_in_composition):
7857 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7858 (glyph_to_pixel_coords): Remove; unused.
7860 * dired.c (file_name_completion): Now static.
7862 * dbusbind.c (xd_in_read_queued_messages): Now static.
7864 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7865 * data.c (circular_list_error): Remove.
7867 * commands.h (last_point_position, last_point_position_buffer):
7868 (last_point_position_window): Remove decls.
7869 * keyboard.c: Make these variables static.
7871 * coding.h (coding, code_convert_region, encode_coding_gap):
7873 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7874 (iso_code_class, detect_coding, code_convert_region): Now static.
7875 (encode_coding_gap): Remove; unused.
7877 * chartab.c (chartab_chars, chartab_bits): Now static.
7879 * charset.h (charset_iso_8859_1): Remove decl.
7880 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7883 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7884 * ccl.c (Vccl_program_table): Now static.
7885 (check_ccl_update): Remove; unused.
7887 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7888 * category.h: ... from here.
7889 * category.c (check_category_table, set_category_set): Now static.
7891 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7892 * lisp.h: Remove these decls.
7894 * buffer.c (buffer_count): Remove unused var.
7896 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7897 so that it's not optimized away.
7898 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7899 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7900 exported only to the debugger.
7902 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7903 * atimer.h (run_all_atimers): Remove; not exported.
7905 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7906 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7907 was inaccessible from Lisp.
7908 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7909 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7911 alloc.c: Import and export fewer symbols, and remove unused items.
7912 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7914 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7915 it's not optimized away by whole-program optimization.
7916 (message_enable_multibyte, free_misc): Remove.
7917 (catchlist, handlerlist, mark_backtrace):
7918 Declare only if BYTE_MARK_STACK.
7919 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7920 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7921 (message_enable_multibyte): Remove decl.
7922 (free_misc, interval_free_list, float_block, float_block_index):
7923 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7924 (cons_free_list, last_marked_index):
7926 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7927 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7928 (mark_backtrace): Define only if BYTE_MARK_STACK.
7929 * xdisp.c (message_enable_multibyte): Now static.
7931 Declare Lisp_Object Q* variables to be 'static' if not exported.
7932 This makes it easier for human readers (and static analyzers)
7933 to see whether these variables are used from other modules.
7934 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7935 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7936 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7937 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7938 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7939 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7940 * xmenu.c, xselect.c:
7941 Declare Q* vars static if they are not used in other modules.
7942 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7943 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7944 Remove decls of unexported vars.
7945 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7947 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7949 Make Emacs functions such as Fatom 'static' by default.
7950 This makes it easier for human readers (and static analyzers)
7951 to see whether these functions can be called from other modules.
7952 DEFUN now defines a static function. To make the function external
7953 so that it can be used in other C modules, use the new macro DEFUE.
7954 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7955 (Finit_image_library):
7956 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7957 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7958 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7959 Remove decls, since these functions are now static.
7960 (Funintern, Fget_internal_run_time): New decls, since these functions
7961 were already external.
7963 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7964 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7965 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7966 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7967 * keyboard.c, keymap.c, lread.c:
7968 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7969 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7970 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7971 Mark functions with DEFUE instead of DEFUN,
7972 if they are used in other modules.
7973 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7974 decls for now-static functions.
7975 * buffer.h (Fdelete_overlay): Remove decl.
7976 * callproc.c (Fgetenv_internal): Mark as internal.
7977 * composite.c (Fremove_list_of_text_properties): Remove decl.
7978 (Fcomposition_get_gstring): New forward static decl.
7979 * composite.h (Fcomposite_get_gstring): Remove decl.
7980 * dired.c (Ffile_attributes): New forward static decl.
7981 * doc.c (Fdocumntation_property): New forward static decl.
7982 * eval.c (Ffetch_bytecode): New forward static decl.
7983 (Funintern): Remove extern decl; now in .h file where it belongs.
7984 * fileio.c (Fmake_symbolic_link): New forward static decl.
7985 * image.c (Finit_image_library): New forward static decl.
7986 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7987 * intervals.h (Fprevious_property_change):
7988 (Fremove_list_of_text_properties): Remove decls.
7989 * keyboard.c (Fthis_command_keys): Remove decl.
7990 (Fcommand_execute): New forward static decl.
7991 * keymap.c (Flookup_key): New forward static decl.
7992 (Fcopy_keymap): Now static.
7993 * keymap.h (Flookup_key): Remove decl.
7994 * process.c (Fget_process): New forward static decl.
7995 (Fprocess_datagram_address): Mark as internal.
7996 * syntax.c (Fsyntax_table_p): New forward static decl.
7997 (skip_chars): Remove duplicate decl.
7998 * textprop.c (Fprevious_property_change): New forward static decl.
7999 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8001 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8002 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8004 * editfns.c (Fformat): Remove unreachable code.
8006 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8008 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8011 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8013 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8014 when at ZV. (Bug#8487)
8016 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8018 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8020 * keyboard.c (parse_tool_bar_item): Likewise.
8021 * sound.c (sound_cleanup, alsa_close): Likewise.
8022 * termcap.c (tgetent): Likewise.
8023 * xfns.c (x_default_font_parameter): Likewise.
8024 * xsettings.c (read_and_apply_settings): Likewise.
8026 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8027 (overrun_check_free): Protoize.
8029 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8031 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8032 since callers should never pass a negative size.
8033 Change the signature to match that of plain 'read' and 'write'; see
8034 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8035 * lisp.h: Update prototypes of emacs_write and emacs_read.
8037 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8039 * xdisp.c (redisplay_window): Don't try to determine the character
8040 position of the scroll margin if the window start point w->startp
8041 is outside the buffer's accessible region. (Bug#8468)
8043 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8045 Fix write-region and its subroutines for buffers > 2GB.
8046 * fileio.c (a_write, e_write): Modify declaration of arguments and
8047 local variables to support buffers larger than 2GB.
8048 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8050 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8051 argument, local variables, and return value.
8053 * lisp.h: Update prototypes of emacs_write and emacs_read.
8055 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8057 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8059 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8061 Fix more problems found by GCC 4.6.0's static checks.
8063 * xdisp.c (vmessage): Use a better test for character truncation.
8065 * charset.c (load_charset_map): <, not <=, for optimization,
8066 and to avoid potential problems with integer overflow.
8067 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8068 * casetab.c (set_identity, shuffle): Likewise.
8069 * editfns.c (Fformat): Likewise.
8070 * syntax.c (skip_chars): Likewise.
8072 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8073 This also lets GCC 4.6.0 generate slightly better loop code.
8075 * callint.c (Fcall_interactively): <, not <=, for optimization.
8076 (Fcall_interactively): Count the number of arguments produced,
8077 not the number of arguments given. This is simpler and lets GCC
8078 4.6.0 generate slightly better code.
8080 * ftfont.c: Distingish more carefully between FcChar8 and char.
8081 The previous code passed unsigned char * to a functions like
8082 strlen and xstrcasecmp that expect char *, which does not
8083 conform to the C standard.
8084 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8085 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8086 char * when the C standard requires it.
8088 * keyboard.c (read_char): Remove unused var.
8090 * eval.c: Port to Windows vsnprintf (Bug#8435).
8092 (SIZE_MAX): Define if the headers do not.
8093 (verror): Do not give up if vsnprintf returns a negative count.
8094 Instead, grow the buffer. This ports to Windows vsnprintf, which
8095 does not conform to C99. Problem reported by Eli Zaretskii.
8096 Also, simplify the allocation scheme, by avoiding the need for
8097 calling realloc, and removing the ALLOCATED variable.
8099 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8101 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8102 But keep the doprint source code for now, as we might revamp it
8103 and use it again (Bug#8435).
8104 * lisp.h (doprnt): Remove.
8105 * Makefile.in (base_obj): Remove doprnt.o.
8106 * deps.mk (doprnt.o): Remove.
8108 error: Print 32- and 64-bit integers portably (Bug#8435).
8109 Without this change, on typical 64-bit hosts error ("...%d...", N)
8110 was used to print both 32- and 64-bit integers N, which relied on
8112 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8113 * lisp.h (error, verror): Mark as printf-like functions.
8114 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8115 Report overflow in size calculations when allocating printf buffer.
8116 Do not truncate output string at its first null byte.
8117 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8118 Truncate the output at a character boundary, since vsnprintf does not
8120 * charset.c (check_iso_charset_parameter): Convert internal
8121 character to string before calling 'error', since %c now has the
8123 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8124 overflow when computing char to be passed to 'error'. Do not
8125 pass Lisp_Object to 'error'; pass the integer instead.
8126 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8127 formatted with plain %d.
8129 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8131 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8133 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8135 * xterm.c (x_catch_errors): Remove duplicate declaration.
8137 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8139 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8141 2011-04-10 Jim Meyering <meyering@redhat.com>
8143 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8144 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8145 return ssize_t not "int", and use size_t as the buffer length.
8146 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8147 * gnutls.h: Update declarations.
8148 * process.c (read_process_output): Use ssize_t, to match.
8149 (send_process): Likewise.
8151 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8153 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8155 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8157 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8158 Use unsigned char, to match FcChar8 type definition.
8160 * xterm.c (handle_one_xevent):
8161 * xmenu.c (create_and_show_popup_menu):
8162 * xselect.c (x_decline_selection_request)
8163 (x_reply_selection_request): Avoid type-punned deref of X events.
8165 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8167 Fix some uses of `int' instead of EMACS_INT.
8168 * search.c (string_match_1, fast_string_match)
8169 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8170 (scan_buffer, find_next_newline_no_quit)
8171 (find_before_next_newline, search_command, Freplace_match)
8172 (Fmatch_data): Make some `int' variables be EMACS_INT.
8174 * xdisp.c (display_count_lines): 3rd argument and return value now
8175 EMACS_INT. All callers changed.
8176 (pint2hrstr): Last argument is now EMACS_INT.
8178 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8179 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8180 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8181 (decode_coding_utf_16, decode_coding_emacs_mule)
8182 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8183 (decode_coding_ccl, decode_coding_charset)
8184 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8185 (decode_coding_iso_2022, decode_coding_emacs_mule)
8186 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8187 <char_offset, last_offset>: Declare EMACS_INT.
8188 (encode_coding_utf_8, encode_coding_utf_16)
8189 (encode_coding_emacs_mule, encode_invocation_designation)
8190 (encode_designation_at_bol, encode_coding_iso_2022)
8191 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8192 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8194 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8195 (encode_invocation_designation): Last argument P_NCHARS is now
8197 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8198 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8200 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8203 * ccl.c (Fccl_execute_on_string): Declare some variables
8206 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8208 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8210 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8212 * process.c (Fformat_network_address): Doc fix.
8214 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8216 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8218 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8220 * keyboard.c (read_char): Call Lisp function help-form-show,
8221 instead of using internal_with_output_to_temp_buffer.
8222 (Qhelp_form_show): New var.
8223 (syms_of_keyboard): Use DEFSYM macro.
8225 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8227 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8229 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8231 * process.c (Flist_processes): Remove to Lisp.
8232 (list_processes_1): Delete.
8234 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8236 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8238 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8240 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8242 Fix more problems found by GCC 4.6.0's static checks.
8244 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8246 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8248 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8250 * xdisp.c (vmessage): Mark as a printf-like function.
8252 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8254 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8256 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8257 printf-like functions.
8258 (tiff_load): Add casts to remove these marks before passing them
8259 to system-supplied API.
8261 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8263 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8264 This avoids several warnings with gcc -Wstrict-overflow.
8265 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8266 directly, rather than having caller test rule sign. This avoids
8267 some unnecessary tests.
8268 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8269 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8270 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8272 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8273 (xfont_open): Avoid unnecessary tests.
8275 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8277 * composite.h, composite.c (composition_gstring_put_cache):
8278 Use EMACS_INT, not int, for length.
8280 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8281 breaking out part of COMPOSITION_DECODE_RULE.
8282 (COMPOSITION_DECODE_RULE): Use it.
8283 * composite.c (get_composition_id): Remove unused local vars,
8284 by using the new macro.
8286 * textprop.c (set_text_properties_1): Change while to do-while,
8287 since the condition is always true at first.
8289 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8290 (interval_deletion_adjustment): Return unsigned value.
8293 * process.c (list_processes_1, create_pty, read_process_output):
8294 (exec_sentinel): Remove vars that were set but not used.
8295 (create_pty): Remove unnecessary "volatile"s.
8296 (Fnetwork_interface_info): Avoid possibility of int overflow.
8297 (read_process_output): Do adaptive read buffering even if carryover.
8298 (read_process_output): Simplify nbytes computation if buffered.
8300 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8302 * syntax.c (scan_words): Remove var that was set but not used.
8303 (update_syntax_table): Use unsigned instead of int.
8305 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8306 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8307 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8309 * print.c (print_error_message): Avoid int overflow.
8311 * font.c (font_list_entities): Redo for clarity,
8312 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8314 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8315 (font_score): Avoid potential overflow in diff calculation.
8317 * fns.c (substring_both): Remove var that is set but not used.
8318 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8320 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8322 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8323 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8324 can always succeed if overflow has undefined behavior.
8326 * search.c (boyer_moore, wordify): Remove vars set but not used.
8327 (wordify): Omit three unnecessary tests.
8329 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8330 All callers changed. This avoids the need for an unused var.
8332 * casefiddle.c (casify_region): Remove var that is set but not used.
8334 * dired.c (file_name_completion): Remove var that is set but not used.
8336 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8338 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8339 (Finsert_file_contents): Remove unnecessary code checking fd.
8341 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8342 Check for integer overflow on size calculations.
8344 * buffer.c (Fprevious_overlay_change): Remove var that is set
8347 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8348 Remove vars that are set but not used.
8349 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8350 (timer_check_2): Mark vars as initialized.
8352 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8354 * image.c (lookup_image): Remove var that is set but not used.
8355 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8357 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8358 that are set but not used.
8360 * xfns.c (make_invisible_cursor): Don't return garbage
8361 if XCreateBitmapFromData fails (Bug#8410).
8363 * xselect.c (x_get_local_selection, x_handle_property_notify):
8364 Remove vars that are set but not used.
8366 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8367 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8369 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8370 Remove var that is set but not used.
8371 (scroll_bar_windows_size): Now size_t, not int.
8372 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8375 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8376 (map_tty_color) [!defined MSDOS]: Likewise.
8378 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8380 * coding.c: Remove vars that are set but not used.
8381 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8382 All callers changed.
8383 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8384 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8385 (decode_coding_charset): Remove vars that are set but not used.
8387 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8388 that is set but not used.
8390 * print.c (print_object): Remove var that is set but not used.
8392 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8393 The gnulib version avoids calling malloc in the usual case,
8394 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8395 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8396 * filelock.c (current_lock_owner): Likewise.
8397 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8398 * sysdep.c: Include allocator.h, careadlinkat.h.
8399 (emacs_no_realloc_allocator): New static constant.
8400 (emacs_readlink): New function.
8401 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8402 ../lib/careadlinkat.h.
8404 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8406 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8407 first non-nil return value).
8409 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8411 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8412 if not defined (Bug#8403).
8414 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8416 * xdisp.c (display_count_lines): Remove parameter `start',
8417 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8418 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8419 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8420 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8421 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8422 and thereabouts. All callers changed.
8423 (get_per_char_metric): Remove parameter `f', unused since
8424 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8426 2011-04-02 Jim Meyering <meyering@redhat.com>
8428 do not dereference NULL upon failed strdup
8429 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8430 (ns_get_family): Likewise.
8432 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8434 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8436 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8438 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8441 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8443 Add lexical binding.
8445 * window.c (Ftemp_output_buffer_show): New fun.
8446 (Fsave_window_excursion):
8447 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8449 * lread.c (lisp_file_lexically_bound_p): New function.
8450 (Fload): Bind Qlexical_binding.
8451 (readevalloop): Remove `evalfun' arg.
8452 Bind Qinternal_interpreter_environment.
8453 (Feval_buffer): Bind Qlexical_binding.
8454 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8456 (syms_of_lread): Declare `lexical-binding'.
8458 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8460 * keyboard.c (eval_dyn): New fun.
8461 (menu_item_eval_property): Use it.
8463 * image.c (parse_image_spec): Use Ffunctionp.
8465 * fns.c (concat, mapcar1): Accept byte-code-functions.
8467 * eval.c (Fsetq): Handle lexical vars.
8468 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8469 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8470 (FletX, Flet): Obey lexical binding.
8471 (Fcommandp): Handle closures.
8472 (Feval): New `lexical' arg.
8473 (eval_sub): New function extracted from Feval. Use it almost
8474 everywhere where Feval was used. Look up vars in lexical env.
8476 (Ffunctionp): Move from subr.el.
8477 (Ffuncall): Handle closures.
8478 (apply_lambda): Remove `eval_flags'.
8479 (funcall_lambda): Handle closures and new byte-code-functions.
8480 (Fspecial_variable_p): New function.
8481 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8482 but without exporting it to Lisp.
8484 * doc.c (Fdocumentation, store_function_docstring):
8485 * data.c (Finteractive_form): Handle closures.
8487 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8490 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8492 (exec_byte_code): New function extracted from Fbyte_code to handle new
8493 calling convention for byte-code-functions. Add new byte-codes.
8495 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8497 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8499 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8501 * xdisp.c (redisplay_internal): Fix prototype.
8503 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8505 * xdisp.c (SCROLL_LIMIT): New macro.
8506 (try_scrolling): Use it when setting scroll_limit.
8507 Limit scrolling to 100 screen lines.
8508 (redisplay_window): Even when falling back on "recentering",
8509 position point in the window according to scroll-conservatively,
8510 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8512 (try_scrolling): When point is above the window, allow searching
8513 as far as scroll_max, or one screenful, to compute vertical
8514 distance from PT to the scroll margin position. This prevents
8515 try_scrolling from unnecessarily failing when
8516 scroll-conservatively is set to a value slightly larger than the
8517 window height. Clean up the case of PT below the margin at bottom
8518 of window: scroll_max can no longer be INT_MAX. When aggressive
8519 scrolling is in use, don't let point enter the opposite scroll
8520 margin as result of the scroll.
8521 (syms_of_xdisp) <scroll-conservatively>: Document the
8522 threshold of 100 lines for never-recentering scrolling.
8524 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8526 * dispextern.h (move_it_by_lines):
8527 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8528 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8529 (message_log_check_duplicate): Remove parameters `prev_bol' and
8530 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8531 (redisplay_internal): Remove parameter `preserve_echo_area',
8532 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8534 * indent.c (Fvertical_motion):
8535 * window.c (window_scroll_pixel_based, Frecenter):
8536 Don't pass `need_y_p' to `move_it_by_lines'.
8538 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8540 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8541 steal a few bits to be more compact.
8542 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8543 Remove unneeded casts.
8545 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8547 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8549 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8550 binding" message (bug#7967).
8552 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8554 Fix more problems found by GCC 4.6.0's static checks.
8556 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8557 Remove unused local var.
8559 * editfns.c (Fmessage_box): Remove unused local var.
8561 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8562 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8563 Omit unused local vars.
8564 * window.c (shrink_windows): Omit unused local var.
8565 * menu.c (digest_single_submenu): Omit unused local var.
8566 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8567 Omit unused local var.
8569 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8570 Don't assume string length fits in int.
8571 (keyremap_step, read_key_sequence): Use size_t for sizes.
8572 (read_key_sequence): Don't check last_real_key_start redundantly.
8574 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8575 instead of alloca (Bug#8344).
8577 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8578 (Fbacktrace_frame): Don't assume nframes fits in int.
8580 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8582 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8585 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8587 * cm.c (calccost): Turn while-do into do-while, for clarity.
8589 * keyboard.c (syms_of_keyboard): Use the same style as later
8590 in this function when indexing through an array. This also
8591 works around GCC bug 48267.
8593 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8595 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8597 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8598 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8600 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8601 This avoids undefined behavior on integer overflow, and is a bit
8602 more convenient anyway since it is compared to a size_t variable.
8604 Variadic C functions now count arguments with size_t, not int.
8605 This avoids an unnecessary limitation on 64-bit machines, which
8606 caused (substring ...) to crash on large vectors (Bug#8344).
8607 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8608 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8609 All variadic functions and their callers changed accordingly.
8610 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8611 * data.c (arith_driver, float_arith_driver): Likewise.
8612 * editfns.c (general_insert_function): Likewise.
8613 * eval.c (struct backtrace.nargs, interactive_p)
8614 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8615 (funcall_lambda, mark_backtrace): Likewise.
8616 * fns.c (concat): Likewise.
8617 * frame.c (x_set_frame_parameters): Likewise.
8618 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8619 0 if not found, not -1. All callers changed.
8621 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8622 (stack_copy_size): Now size_t, not int.
8623 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8625 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8627 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8628 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8629 All callers changed.
8631 * lisp.h (multibyte_char_to_unibyte):
8632 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8633 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8634 * character.h (CHAR_TO_BYTE8):
8635 * cmds.c (internal_self_insert):
8636 * editfns.c (general_insert_function):
8637 * keymap.c (push_key_description):
8638 * search.c (Freplace_match):
8639 * xdisp.c (message_dolog, set_message_1): All callers changed.
8641 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8643 * keyboard.c (safe_run_hook_funcall): New function.
8644 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8645 don't set the hook to nil, but remove the offending function instead.
8646 (Qcommand_hook_internal): Remove, unused.
8647 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8648 Vcommand_hook_internal.
8650 * eval.c (enum run_hooks_condition): Remove.
8651 (funcall_nil, funcall_not): New functions.
8652 (run_hook_with_args): Call each function through a `funcall' argument.
8653 Remove `cond' argument, now redundant.
8654 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8655 (Frun_hook_with_args_until_failure): Adjust accordingly.
8656 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8658 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8660 * dispextern.h (string_buffer_position): Remove declaration.
8662 * print.c (strout): Remove parameter `multibyte', unused since
8663 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8665 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8666 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8667 All callers changed.
8669 * w32.c (_wsa_errlist): Use braces for struct initializers.
8671 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8672 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8673 All callers changed.
8674 (string_buffer_position): Likewise. Also, make static (it's never
8675 used outside xdisp.c).
8676 (cursor_row_p): Remove parameter `w', unused since
8677 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8678 (decode_mode_spec): Remove parameter `precision', introduced during
8679 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8680 All callers changed.
8682 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8684 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8686 2011-03-27 Anders Lindgren <andlind@gmail.com>
8688 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8689 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8690 (ns_update_auto_hide_menu_bar): New functions.
8691 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8692 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8693 ns_constrain_all_frames.
8694 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8695 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8697 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8699 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8701 2011-03-27 Glenn Morris <rgm@gnu.org>
8703 * syssignal.h: Replace RETSIGTYPE with void.
8704 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8705 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8706 Replace SIGTYPE with void everywhere.
8707 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8708 * s/template.h (SIGTYPE): Remove commented out definition.
8710 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8712 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8713 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8715 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8717 * w32.c (read_unc_volume): Use parameter `henum', instead of
8718 global variable `wget_enum_handle'.
8720 * keymap.c (describe_vector): Remove parameters `indices' and
8721 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8722 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8724 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8726 * keyboard.c (timer_check): Remove parameter `do_it_now',
8727 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8728 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8729 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8731 * keyboard.c (read_char):
8732 * w32menu.c (w32_menu_display_help):
8733 * xmenu.c (show_help_event, menu_help_callback):
8734 Adjust calls to `show_help_echo'.
8736 * gtkutil.c (xg_maybe_add_timer):
8737 * keyboard.c (readable_events):
8738 * process.c (wait_reading_process_output):
8739 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8741 * insdel.c (adjust_markers_gap_motion):
8742 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8743 (gap_left, gap_right): Don't call it.
8745 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8747 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8748 incurred during fontification.
8750 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8752 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8753 (DEFVAR_PER_BUFFER): Don't pass it.
8755 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8756 (scrolling_window): Don't pass it.
8758 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8760 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8762 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8764 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8765 of variables specific to SELinux and computation of `encoded_absname'.
8767 * image.c (XPutPixel): Remove unused variable `height'.
8769 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8771 * unexw32.c (get_section_info): Remove unused variable `section'.
8773 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8774 (system_process_attributes): Remove unused variable `sess'.
8775 (sys_read): Remove unused variable `err'.
8777 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8778 (w32_wnd_proc): Remove unused variable `isdead'.
8779 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8780 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8781 (x_create_tip_frame): Remove unused variable `tem'.
8783 * w32inevt.c (w32_console_read_socket):
8784 Remove unused variable `no_events'.
8786 * w32term.c (x_draw_composite_glyph_string_foreground):
8787 Remove unused variable `width'.
8789 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8791 * w32term.c (x_set_glyph_string_clipping):
8792 Don't pass uninitialized region to CombineRgn.
8794 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8796 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8797 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8798 (Fx_close_connection): Remove unused variable `i'.
8800 * w32font.c (w32font_draw): Return number of glyphs.
8801 (w32font_open_internal): Remove unused variable `i'.
8802 (w32font_driver): Add missing initializer.
8804 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8805 (fill_in_menu): Remove unused variable `items_added'.
8807 * w32term.c (last_mouse_press_frame): Remove static global variable.
8808 (w32_clip_to_row): Remove unused variable `f'.
8809 (x_delete_terminal): Remove unused variable `i'.
8811 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8812 (NOTHING): Remove unused static global variable.
8813 (uniscribe_check_otf): Remove unused variable `table'.
8814 (uniscribe_font_driver): Add missing initializers.
8816 2011-03-23 Julien Danjou <julien@danjou.info>
8818 * term.c (Fsuspend_tty, Fresume_tty):
8819 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8820 * window.c (temp_output_buffer_show):
8821 * insdel.c (signal_before_change):
8822 * frame.c (Fhandle_switch_frame):
8823 * fileio.c (Fdo_auto_save):
8824 * emacs.c (Fkill_emacs):
8825 * editfns.c (save_excursion_restore):
8826 * cmds.c (internal_self_insert):
8827 * callint.c (Fcall_interactively):
8828 * buffer.c (Fkill_all_local_variables):
8829 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8831 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8832 unconditionally since it does the check itself.
8834 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8836 Fix more problems found by GCC 4.5.2's static checks.
8838 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8839 the first time through the loop, since we know p0 < p1 then.
8840 This also avoids a gcc -Wstrict-overflow warning.
8842 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8843 leading to a memory leak, possible in functions like
8844 load_charset_map_from_file that can allocate an unbounded number
8845 of objects (Bug#8318).
8847 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8848 that could (at least in theory) be that large.
8850 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8851 This is less likely to overflow, and avoids undefined behavior if
8852 overflow does occur. All callers changed. Use strtoul to scan
8853 for the unsigned long integer.
8854 (pint2hrstr): Simplify and tune code slightly.
8855 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8857 * scroll.c (do_scrolling): Work around GCC bug 48228.
8858 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8860 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8861 This also avoids a warning with gcc -Wstrict-overflow.
8862 (validate_x_resource_name): Simplify count usage.
8863 This also avoids a warning with gcc -Wstrict-overflow.
8865 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8868 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8870 * process.c (Fmake_network_process): Use socklen_t, not int,
8871 where POSIX says socklen_t is required in portable programs.
8872 This fixes a porting bug on hosts like 64-bit HP-UX, where
8873 socklen_t is wider than int (Bug#8277).
8874 (Fmake_network_process, server_accept_connection):
8875 (wait_reading_process_output, read_process_output):
8878 * process.c: Rename or move locals to avoid shadowing.
8879 (list_processes_1, Fmake_network_process):
8880 (read_process_output_error_handler, exec_sentinel_error_handler):
8881 Rename or move locals.
8882 (Fmake_network_process): Define label "retry_connect" only if needed.
8883 (Fnetwork_interface_info): Fix pointer signedness.
8884 (process_send_signal): Add cast to avoid pointer signedness problem.
8885 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8886 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8888 Make tparam.h and terminfo.c consistent.
8889 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8890 Include tparam.h instead, since it declares them.
8891 * cm.h (PC): Remove extern decl; tparam.h now does this.
8892 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8893 * terminfo.c: Include tparam.h, to check interfaces.
8894 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8895 (tparam): Adjust signature to match interface in tparam.h;
8896 this removes some undefined behavior. Check that outstring and len
8897 are zero, which they always are with Emacs.
8898 * tparam.h (PC, BC, UP): New extern decls.
8900 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8901 (xftfont_open): Rename locals to avoid shadowing.
8903 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8904 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8905 (OTF_TAG_SYM): Omit macro if not needed.
8906 (ftfont_list): Remove unused local.
8907 (get_adstyle_property, ftfont_pattern_entity):
8908 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8909 Rename locals to avoid shadowing.
8911 * xfont.c (xfont_list_family): Mark var as initialized.
8913 * xml.c (make_dom): Now static.
8915 * composite.c (composition_compute_stop_pos): Rename local to
8917 (composition_reseat_it): Remove unused locals.
8918 (find_automatic_composition, composition_adjust_point): Likewise.
8919 (composition_update_it): Mark var as initialized.
8920 (find_automatic_composition): Mark vars as initialized,
8921 with a FIXME (Bug#8290).
8923 character.h: Rename locals to avoid shadowing.
8924 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8925 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8926 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8927 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8930 * textprop.c (property_change_between_p): Remove; unused.
8932 * intervals.c (interval_start_pos): Now static.
8934 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8936 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8937 Rename locals to avoid shadowing.
8939 * sound.c (wav_play, au_play, Fplay_sound_internal):
8940 Fix pointer signedness.
8941 (alsa_choose_format): Remove unused local var.
8942 (wav_play): Initialize a variable to 0, to prevent undefined
8943 behavior (Bug#8278).
8945 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8947 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8949 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8950 clobbering (Bug#8298).
8951 * sysdep.c (sys_subshell): Likewise.
8952 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8954 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8955 This should get cleaned up, so that child_setup has the
8956 same signature on all platforms.
8958 * callproc.c (call_process_cleanup): Now static.
8959 (relocate_fd): Rename locals to avoid shadowing.
8961 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8963 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8964 not to be necessary, and produces flickering.
8966 2011-03-20 Glenn Morris <rgm@gnu.org>
8968 * config.in: Remove file.
8970 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8972 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8973 are now in src/globals.h.
8974 (syms_of_minibuf): Remove spurious & from previous change.
8976 2011-03-20 Leo Liu <sdl.web@gmail.com>
8978 * minibuf.c (completing-read-function): New variable.
8979 (completing-read-default): Rename from completing-read.
8980 (completing-read): Call completing-read-function.
8982 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8984 * xfaces.c (Fx_load_color_file):
8985 Read color file from absolute filename (bug#8250).
8987 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8989 * makefile.w32-in: Update dependencies.
8991 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8993 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8995 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8997 Fix more problems found by GCC 4.5.2's static checks.
8999 * process.c (make_serial_process_unwind, send_process_trap):
9000 (sigchld_handler): Now static.
9002 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9003 That way, the code declares only the vars that it needs.
9004 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9005 * s/cygwin.h (PTY_ITERATION): Likewise.
9006 * s/darwin.h (PTY_ITERATION): Likewise.
9007 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9009 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9010 * process.c (allocate_pty): Don't declare stb unless it's needed.
9012 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9013 (CONSTANTLIM): Remove; unused.
9014 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9015 Define only if needed.
9017 * unexelf.c (unexec): Name an expression,
9018 to avoid gcc -Wbad-function-cast warning.
9019 Use a different way to cause a compilation error if anyone uses
9020 n rather than nn, a way that does not involve shadowing.
9021 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9023 * deps.mk (unexalpha.o): Remove; unused.
9025 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9026 * unexec.h: New file.
9027 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9028 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9030 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9031 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9032 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9033 Change as necessary to match prototype in unexec.h.
9035 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9037 (back_comment, skip_chars): Mark vars as initialized.
9039 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9040 Rename locals to avoid shadowing.
9042 * lread.c (read1): Rewrite so as not to use empty "else".
9043 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9045 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9047 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9048 warning when compiling print.c.
9050 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9051 instead of using an uninitialized var.
9052 (font_sort_entities): Mark var as initialized.
9054 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9056 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9057 pointers to constants.
9058 (font_parse_fcname): Remove unused vars.
9059 (font_delete_unmatched): Now static.
9060 (font_get_spec): Remove; unused.
9061 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9062 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9063 Rename or move locals to avoid shadowing.
9065 * fns.c (require_nesting_list, require_unwind): Now static.
9066 (Ffillarray): Rename locals to avoid shadowing.
9068 * floatfns.c (domain_error2): Define only if needed.
9069 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9071 * alloc.c (mark_backtrace): Move decl from here ...
9072 * lisp.h: ... to here, so that it can be checked.
9074 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9075 (Fdefvar): Rewrite so as not to use empty "else".
9076 (lisp_indirect_variable): Name an expression,
9077 to avoid gcc -Wbad-function-cast warning.
9078 (Fdefvar): Rename locals to avoid shadowing.
9080 * callint.c (quotify_arg, quotify_args): Now static.
9081 (Fcall_interactively): Rename locals to avoid shadowing.
9082 Use const pointer when appropriate.
9084 * lisp.h (get_system_name, get_operating_system_release):
9085 Move decls here, to check interfaces.
9086 * process.c (get_operating_system_release): Move decl to lisp.h.
9087 * xrdb.c (get_system_name): Likewise.
9088 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9089 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9090 some of which prompt warnings from gcc -Wbad-function-cast.
9091 (Fformat_time_string, Fencode_time, Finsert_char):
9092 (Ftranslate_region_internal, Fformat):
9093 Rename or remove local vars to avoid shadowing.
9094 (Ftranslate_region_internal): Mark var as initialized.
9096 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9099 * lisp.h (eassert): Check that the argument compiles, even if
9100 ENABLE_CHECKING is not defined.
9102 * data.c (Findirect_variable): Name an expression, to avoid
9103 gcc -Wbad-function-cast warning.
9104 (default_value, arithcompare, arith_driver, arith_error): Now static.
9105 (store_symval_forwarding): Rename local to avoid shadowing.
9106 (Fmake_variable_buffer_local, Fmake_local_variable):
9107 Mark variables as initialized.
9108 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9110 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9111 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9112 Rename locals to avoid shadowing.
9113 (mark_stack): Move local variables into the #ifdef region where
9115 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9116 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9118 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9119 (GC_STRING_CHARS): Remove; not used.
9120 (Fmemory_limit): Cast sbrk's returned value to char *.
9122 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9123 avoids undefined behavior in theory.
9125 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9127 Use functions, not macros, for up- and down-casing (Bug#8254).
9128 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9129 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9130 to use the following functions instead of these macros.
9131 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9132 EMACS_INT, since callers assume the returned value fits in int.
9133 (upcase1): Likewise, for UPCASE_TABLE.
9134 (uppercasep, lowercasep, upcase): New static inline functions.
9135 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9136 the race-condition problem in the old DOWNCASE.
9138 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9139 Rename locals to avoid shadowing.
9140 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9141 (regex_compile, re_search_2, re_match_2_internal):
9142 Remove unused local vars.
9143 (FREE_VAR): Rewrite so as not to use empty "else",
9144 which gcc can warn about.
9145 (regex_compile, re_match_2_internal): Mark locals as initialized.
9146 (RETALLOC_IF): Define only if needed.
9147 (WORDCHAR_P): Likewise. This one is never needed, but is used
9148 only in a comment talking about a compiler bug, so put inside
9149 the #if 0 of that comment.
9150 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9151 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9154 * search.c (boyer_moore): Rename locals to avoid shadowing.
9155 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9156 (PREV_CHAR_BOUNDARY): Likewise.
9158 * search.c (simple_search): Remove unused var.
9160 * dired.c (compile_pattern): Move decl from here ...
9161 * lisp.h: ... to here, so that it can be checked.
9162 (struct re_registers): New forward decl.
9164 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9166 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9168 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9169 Rename locals to avoid shadowing.
9170 (Fvertical_motion): Mark locals as initialized.
9172 * casefiddle.c (casify_object, casify_region): Now static.
9173 (casify_region): Mark local as initialized.
9175 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9177 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9178 New macros, so that the caller can use some names other than
9179 gcpro1, gcpro2, etc.
9180 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9182 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9183 argument, for consistency with GCPRO2_VAR, etc: it is now the
9184 prefix of the variable, not the variable itself. All uses
9186 * dired.c (directory_files_internal, file_name_completion):
9187 Rename locals to avoid shadowing.
9189 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9190 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9191 dired.c's scmp function, had undefined behavior.
9192 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9193 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9194 * buffer.h: ... to here, because these macros use current_buffer,
9195 and the new implementation with inline functions needs to have
9196 current_buffer in scope now, rather than later when the macros
9198 (downcase, upcase1): New static inline functions.
9199 (DOWNCASE, UPCASE1): Reimplement using these functions.
9200 This avoids undefined behavior in expressions like
9201 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9202 from race conditions in accessing the global variables
9203 case_temp1 and case_temp2.
9204 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9205 * lisp.h (case_temp1, case_temp2): Remove their decls.
9206 * character.h (ASCII_CHAR_P): Move from here ...
9207 * lisp.h: ... to here, so that the inline functions mentioned
9210 * dired.c (directory_files_internal_unwind): Now static.
9212 * fileio.c (file_name_as_directory, directory_file_name):
9213 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9215 (file_name_as_directory): Use const pointers when appropriate.
9216 (Fexpand_file_name): Likewise. In particular, newdir might
9217 point at constant storage, so make it a const pointer.
9218 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9219 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9221 (Fset_file_times, Finsert_file_contents, auto_save_error):
9222 Rename locals to avoid shadowing.
9224 * minibuf.c (choose_minibuf_frame_1): Now static.
9225 (Ftry_completion, Fall_completions): Rename or remove locals
9228 * marker.c (bytepos_to_charpos): Remove; unused.
9230 * lisp.h (verify_bytepos, count_markers): New decls,
9231 so that gcc does not warn that these functions aren't declared.
9233 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9234 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9235 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9236 (copy_text): Remove unused local var.
9238 * filelock.c (within_one_second): Now static.
9239 (lock_file_1): Rename local to avoid shadowing.
9241 * buffer.c (fix_overlays_before): Mark locals as initialized.
9242 (fix_start_end_in_overlays): Likewise. This function should be
9243 simplified by using pointers-to-pointers, but that's a different
9245 (switch_to_buffer_1): Now static.
9246 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9247 (report_overlay_modification): Rename locals to avoid shadowing.
9249 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9250 Fix pointer signedness issue.
9251 (sys_subshell): Mark local as volatile if checking for lint,
9252 to suppress a gcc -Wclobbered warning that does not seem to be right.
9253 (MAXPATHLEN): Define only if needed.
9255 * process.c (serial_open, serial_configure): Move decls from here ...
9256 * systty.h: ... to here, so that they can be checked.
9258 * fns.c (get_random, seed_random): Move extern decls from here ...
9259 * lisp.h: ... to here, so that they can be checked.
9261 * sysdep.c (reset_io): Now static.
9262 (wait_for_termination_signal): Remove; unused.
9264 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9265 (copy_keymap_item, append_key, push_text_char_description):
9267 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9268 (DENSE_TABLE_SIZE): Remove; unused.
9269 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9270 (describe_map_tree):
9271 Rename locals to avoid shadowing.
9273 * keyboard.c: Declare functions static if they are not used elsewhere.
9274 (echo_char, echo_dash, cmd_error, top_level_2):
9275 (poll_for_input, handle_async_input): Now static.
9276 (read_char, kbd_buffer_get_event, make_lispy_position):
9277 (make_lispy_event, make_lispy_movement, apply_modifiers):
9278 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9279 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9280 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9281 (read_key_sequence, read_char): Mark locals as initialized.
9282 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9284 * keyboard.h (make_ctrl_char): New decl.
9285 (mark_kboards): Move decl here ...
9286 * alloc.c (mark_kboards): ... from here.
9288 * lisp.h (force_auto_save_soon): New decl.
9290 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9291 (DEFINE_DUMMY_FUNCTION): New macro.
9292 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9294 (main): Add casts to avoid warnings
9295 if GCC considers string literals to be constants.
9297 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9299 * dbusbind.c: Pointer signedness fixes.
9300 (xd_signature, xd_append_arg, xd_initialize):
9301 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9302 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9303 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9304 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9306 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9307 if GCC considers string literals to be constants.
9308 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9310 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9312 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9313 (print_preprocess, print_object): New macro to fix last change.
9315 * print.c (print_preprocess): Don't forget font objects.
9317 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9319 * emacs.c (USAGE3): Doc fixes.
9321 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9323 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9326 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9328 * lisp.h (VWindow_system, Qfile_name_history):
9329 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9330 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9331 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9333 * w32select.c: Don't #include "keyboard.h".
9334 (run_protected): Add extern declaration for waiting_for_input.
9336 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9337 * w32console.c (detect_input_pending, read_input_pending)
9338 (encode_terminal_code):
9339 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9340 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9341 (w32_system_caret_y, Qfile_name_history):
9342 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9343 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9344 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9345 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9346 * w32proc.c (Qlocal, report_file_error):
9347 * w32term.c (Vwindow_system, updating_frame):
9348 * w32uniscribe.c (initialized, uniscribe_font_driver):
9349 Remove unneeded extern declarations.
9351 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9353 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9355 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9357 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9358 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9359 These macros can no longer be used for assignment.
9361 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9362 Assign struct members directly, instead of using BUF_BEGV etc.
9363 (record_buffer_markers, fetch_buffer_markers): New functions for
9364 recording and fetching special buffer markers.
9365 (set_buffer_internal_1, set_buffer_temp): Use them.
9367 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9369 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9371 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9372 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9374 * xdisp.c (hscroll_window_tree):
9375 (reconsider_clip_changes): Use PT instead of BUF_PT.
9377 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9379 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9380 $(EMACS_ROOT)/lib/intprops.h.
9382 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9384 Fix more problems found by GCC 4.5.2's static checks.
9386 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9387 to unsigned char * to avoid compiler diagnostic.
9388 (xg_free_frame_widgets): Make it clear that a local variable is
9389 needed only if USE_GTK_TOOLTIP.
9390 (gdk_window_get_screen): Make it clear that this macro is needed
9391 only if USE_GTK_TOOLTIP.
9392 (int_gtk_range_get_value): New function, which avoids a diagnostic
9393 from gcc -Wbad-function-cast.
9394 (xg_set_toolkit_scroll_bar_thumb): Use it.
9395 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9396 diagnostic from gcc -Wbad-function-cast.
9397 (get_utf8_string, xg_get_file_with_chooser):
9398 Rename locals to avoid shadowing.
9399 (create_dialog): Move locals to avoid shadowing.
9401 * xgselect.c (xg_select): Remove unused var.
9403 * image.c (four_corners_best): Mark locals as initialized.
9404 (gif_load): Initialize transparent_p to zero (Bug#8238).
9405 Mark another local as initialized.
9406 (my_png_error, my_error_exit): Mark with NO_RETURN.
9408 * image.c (clear_image_cache): Now static.
9409 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9410 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9411 (x_edge_detection): Remove unnecessary cast that
9412 gcc -Wbad-function-cast diagnoses.
9413 (gif_load): Fix pointer signedness.
9414 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9415 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9417 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9419 Improve quality of tests for time stamp overflow.
9420 For example, without this patch (encode-time 0 0 0 1 1
9421 1152921504606846976) returns the obviously-bogus value (-948597
9422 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9423 reports time overflow. See
9424 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9425 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9426 * editfns.c: Include limits.h and intprops.h.
9427 (TIME_T_MIN, TIME_T_MAX): New macros.
9428 (time_overflow): Move earlier, to before first use.
9429 (hi_time, lo_time): New functions, for an accurate test for
9431 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9432 (Fget_internal_run_time): Don't assume time_t fits in int.
9433 (make_time): Use list2 instead of Fcons twice.
9434 (Fdecode_time): More accurate test for out-of-range times.
9435 (check_tm_member): New function.
9436 (Fencode_time): Use it, to test for out-of-range times.
9437 (lisp_time_argument): Don't rely on undefined left-shift and
9438 right-shift behavior when checking for time stamp overflow.
9440 * editfns.c (time_overflow): New function, refactoring common code.
9441 (Fformat_time_string, Fdecode_time, Fencode_time):
9442 (Fcurrent_time_string): Use it.
9444 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9445 * dired.c (make_time): Move to ...
9446 * editfns.c (make_time): ... here.
9447 * systime.h: Note the move.
9449 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9451 * fringe.c (update_window_fringes): Remove unused variables.
9453 * unexmacosx.c (copy_data_segment): Also copy __got section.
9456 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9458 * termcap.c [MSDOS]: Include "msdos.h".
9459 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9460 Constify `char *' arguments and their references according to
9461 prototypes in tparam.h.
9463 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9465 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9466 Adapt all references accordingly.
9468 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9470 2011-03-11 Tom Tromey <tromey@redhat.com>
9472 * buffer.c (syms_of_buffer): Remove obsolete comment.
9474 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9476 * termhooks.h (encode_terminal_code): Declare prototype.
9478 * msdos.c (encode_terminal_code): Don't declare prototype.
9480 * term.c (encode_terminal_code): Now external again, used by
9481 w32console.c and msdos.c.
9483 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9484 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9486 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9488 Fix some minor problems found by GCC 4.5.2's static checks.
9490 * fringe.c (update_window_fringes): Mark locals as initialized
9492 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9494 * alloc.c (mark_fringe_data): Move decl from here ...
9495 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9496 to check its interface.
9497 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9499 * fontset.c (free_realized_fontset): Now static.
9500 (Fset_fontset_font): Rename local to avoid shadowing.
9501 (fontset_font): Mark local as initialized.
9502 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9504 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9506 * xselect.c (x_disown_buffer_selections): Remove; not used.
9507 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9508 (x_own_selection, Fx_disown_selection_internal): Rename locals
9510 (x_handle_dnd_message): Remove local to avoid shadowing.
9512 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9513 so that the caller can use some name other than gcpro1.
9514 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9515 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9516 (Fx_backspace_delete_keys_p):
9517 Use them to avoid shadowing, and rename vars to avoid shadowing.
9518 (x_decode_color, x_set_name, x_window): Now static.
9519 (Fx_create_frame): Add braces to silence GCC warning.
9520 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9521 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9522 Remove unused locals.
9523 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9524 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9525 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9528 * xterm.h (x_mouse_leave): New decl.
9530 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9531 Remove unused functions.
9532 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9533 (x_calc_absolute_position): Now static.
9534 (XTread_socket): Don't define label "out" unless it's used.
9535 Don't declare local "event" unless it's used.
9536 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9537 unless they are used.
9538 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9539 (x_fatal_error_signal): Remove; not used.
9540 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9541 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9542 (x_error_catcher, x_connection_closed, x_error_handler):
9543 (x_error_quitter, xembed_send_message, x_iconify_frame):
9544 (my_log_handler): Rename locals to avoid shadowing.
9545 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9546 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9548 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9549 Rename or move locals to avoid shadowing.
9550 (tty_defined_color, merge_face_heights): Now static.
9551 (free_realized_faces_for_fontset): Remove; not used.
9552 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9553 does not deduce is never used uninitialized.
9554 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9555 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9557 * terminal.c (store_terminal_param): Now static.
9559 * xmenu.c (menu_highlight_callback): Now static.
9560 (set_frame_menubar): Remove unused local.
9561 (xmenu_show): Rename parameter to avoid shadowing.
9562 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9563 since they might point to immutable storage.
9564 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9565 since it's unused otherwise.
9567 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9568 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9569 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9570 avoids a gcc -Wuninitialized diagnostic.
9571 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9572 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9573 does not deduce are never used uninitialized.
9575 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9577 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9578 * window.c (window_loop, size_window):
9579 (run_window_configuration_change_hook, enlarge_window): Likewise.
9581 * window.c (display_buffer): Now static.
9582 (size_window): Mark variables that gcc -Wuninitialized
9583 does not deduce are never used uninitialized.
9584 * window.h (check_all_windows): New decl, to forestall
9585 gcc -Wmissing-prototypes diagnostic.
9586 * dispextern.h (bidi_dump_cached_states): Likewise.
9588 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9590 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9592 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9593 and to avoid gcc -Wuninitialized warning.
9594 (load_charset_map): Mark variables that gcc -Wuninitialized
9595 does not deduce are never used uninitialized.
9596 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9598 * coding.c (coding_set_source, coding_set_destination):
9599 Use "else { /* comment */ }" rather than "else /* comment */;"
9600 for clarity, and to avoid gcc -Wempty-body warning.
9601 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9602 a block, when the outer 'i' will do.
9603 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9604 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9605 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9606 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9607 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9608 Rename locals to avoid shadowing.
9609 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9610 * coding.c (emacs_mule_char, encode_invocation_designation):
9611 Now static, since they're not used elsewhere.
9612 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9613 (decode_coding_object, encode_coding_object, detect_coding_system):
9614 (decode_coding_emacs_mule): Mark variables that gcc
9615 -Wuninitialized does not deduce are never used uninitialized.
9616 (detect_coding_iso_2022): Initialize a local variable that might
9617 be used uninitialized. Leave a FIXME because it's not clear that
9618 this initialization is needed. (Bug#8211)
9619 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9620 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9621 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9622 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9623 Remove unused macros.
9625 * category.c (hash_get_category_set): Remove unused local var.
9626 (copy_category_table): Now static, since it's not used elsewhere.
9627 * character.c (string_count_byte8): Likewise.
9629 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9630 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9632 * chartab.c (copy_sub_char_table): Now static, since it's not used
9634 (sub_char_table_ref_and_range, char_table_ref_and_range):
9635 Rename locals to avoid shadowing.
9636 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9638 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9639 (BIDI_BOB): Remove unused macro.
9641 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9642 deduce are never used uninitialized.
9643 * term.c (encode_terminal_code): Likewise.
9645 * term.c (encode_terminal_code): Now static. Remove unused local.
9647 * tparam.h: New file.
9648 * term.c, tparam.h: Include it.
9649 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9650 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9651 Move these decls to tparam.h, and make them agree with what
9652 is actually in tparam.c. The previous trick of using incompatible
9653 decls in different modules does not conform to the C standard.
9654 All callers of tparam changed to use tparam's actual API.
9655 * tparam.c (tparam1, tparam, tgoto):
9656 Use const pointers where appropriate.
9658 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9659 * cm.h (struct cm): Likewise.
9660 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9661 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9662 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9663 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9664 (turn_on_face, init_tty): Likewise.
9665 * termchar.h (struct tty_display_info): Likewise.
9667 * term.c (term_mouse_position): Rename local to avoid shadowing.
9669 * alloc.c (mark_ttys): Move decl from here ...
9670 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9672 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9674 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9676 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9678 * search.c (compile_pattern_1): Remove argument regp, unused since
9679 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9680 (compile_pattern): Don't pass it.
9682 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9684 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9685 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9687 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9689 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9691 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9692 gdk_window_get_screen, gdk_window_get_geometry,
9693 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9694 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9695 (xg_get_pixbuf_from_pixmap): New function.
9696 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9697 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9698 Call xg_get_pixbuf_from_pixmap instead of
9699 gdk_pixbuf_get_from_drawable.
9700 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9701 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9702 (xg_check_special_colors): Use GtkStyleContext and its functions
9704 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9705 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9706 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9707 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9708 Call gtk_widget_get_preferred_size.
9709 (xg_frame_resized): gdk_window_get_geometry only takes 5
9711 (xg_win_to_widget, xg_event_is_for_menubar):
9712 Call gdk_x11_window_lookup_for_display.
9713 (xg_set_widget_bg): New function.
9714 (delete_cb): New function.
9715 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9716 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9717 (xg_set_background_color): Call xg_set_widget_bg.
9718 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9719 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9720 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9721 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9723 (update_frame_tool_bar): Call gtk_widget_hide.
9724 (xg_initialize): Use GDK_KEY_g.
9726 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9728 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9730 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9731 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9732 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9734 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9736 * w32xfns.c (select_palette): Check success of RealizePalette against
9737 GDI_ERROR, not zero.
9739 See ChangeLog.11 for earlier changes.
9745 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9747 This file is part of GNU Emacs.
9749 GNU Emacs is free software: you can redistribute it and/or modify
9750 it under the terms of the GNU General Public License as published by
9751 the Free Software Foundation, either version 3 of the License, or
9752 (at your option) any later version.
9754 GNU Emacs is distributed in the hope that it will be useful,
9755 but WITHOUT ANY WARRANTY; without even the implied warranty of
9756 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9757 GNU General Public License for more details.
9759 You should have received a copy of the GNU General Public License
9760 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.